Playing media elements which call "pause(); play()" will have the play promise rejected.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-12-19  Jer Noble  <jer.noble@apple.com>
2
3         Playing media elements which call "pause(); play()" will have the play promise rejected.
4         https://bugs.webkit.org/show_bug.cgi?id=180781
5         <rdar://problem/33191377>
6
7         Reviewed by Eric Carlson.
8
9         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
10
11         * WebView/WebView.mm:
12         (shouldRequireUserGestureToLoadVideo):
13
14 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
15
16         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
17         https://bugs.webkit.org/show_bug.cgi?id=180977
18
19         Reviewed by Tim Horton.
20
21         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
22         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
23         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
24
25         * WebCoreSupport/WebEditorClient.mm:
26         (attributesForAttributedStringConversion):
27         * WebView/WebHTMLView.mm:
28         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
29
30 2017-12-18  David Kilzer  <ddkilzer@apple.com>
31
32         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
33
34         Attempt to fix the following warnings:
35
36             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
37
38         For the following instance variables:
39
40             _borderView
41             _contentView
42             _frame
43             _wFlags
44
45         * Carbon/CarbonWindowAdapter.mm:
46         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
47         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
48         (-[CarbonWindowAdapter _termWindowIfOwner]):
49         (-[CarbonWindowAdapter _windowMovedToRect:]):
50         (-[CarbonWindowAdapter setContentView:]):
51         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
52         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
53
54 2017-12-16  Dan Bernstein  <mitz@apple.com>
55
56         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
57         https://bugs.webkit.org/show_bug.cgi?id=180613
58         <rdar://problem/35946124>
59
60         Reviewed by Geoff Garen.
61
62         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
63           clients.
64         * WebView/WebDynamicScrollBarsView.h: Ditto.
65         * WebView/WebDynamicScrollBarsView.mm: Ditto.
66
67 2017-12-14  David Kilzer  <ddkilzer@apple.com>
68
69         Enable -Wstrict-prototypes for WebKit
70         <https://webkit.org/b/180757>
71         <rdar://problem/36024132>
72
73         Rubber-stamped by Joseph Pecoraro.
74
75         * Configurations/Base.xcconfig:
76         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
77
78 2017-12-14  John Wilander  <wilander@apple.com>
79
80         Storage Access API: Implement frame-specific access in the document.cookie layer
81         https://bugs.webkit.org/show_bug.cgi?id=180682
82         <rdar://problem/35982257>
83
84         Reviewed by Alex Christensen.
85
86         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
87         CookiesStrategy::cookieRequestHeaderFieldValue(), and
88         CookiesStrategy::getRawCookies() now take optional parameters for
89         frameID and pageID to allow frame-specific scoping of cookies.
90
91         This change makes the return values of FrameLoaderClient::frameID()
92         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
93         WebCore can call those getters and get the right return values in
94         WebKit and std:nullopt in WebKitLegacy.
95
96         * WebCoreSupport/WebFrameLoaderClient.h:
97         * WebCoreSupport/WebFrameLoaderClient.mm:
98         (WebFrameLoaderClient::pageID const):
99         (WebFrameLoaderClient::frameID const):
100         * WebCoreSupport/WebPlatformStrategies.h:
101         * WebCoreSupport/WebPlatformStrategies.mm:
102         (WebPlatformStrategies::cookiesForDOM):
103         (WebPlatformStrategies::setCookiesFromDOM):
104         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
105         (WebPlatformStrategies::getRawCookies):
106
107 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
108
109         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
110         https://bugs.webkit.org/show_bug.cgi?id=180689
111
112         Reviewed by Tim Horton.
113
114         Use sRGBColorSpaceRef() from WebCore.
115
116         * WebView/WebHTMLView.mm:
117         (imageFromRect):
118
119 2017-12-11  Tim Horton  <timothy_horton@apple.com>
120
121         Stop using deprecated target conditional for simulator builds
122         https://bugs.webkit.org/show_bug.cgi?id=180662
123         <rdar://problem/35136156>
124
125         Reviewed by Simon Fraser.
126
127         * postprocess-headers.sh:
128
129 2017-12-11  David Quesada  <david_quesada@apple.com>
130
131         Turn on ENABLE_APPLICATION_MANIFEST
132         https://bugs.webkit.org/show_bug.cgi?id=180562
133         rdar://problem/35924737
134
135         Reviewed by Geoffrey Garen.
136
137         * Configurations/FeatureDefines.xcconfig:
138
139 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
140
141         Remove pthread_once in favor of dispatch_once
142         https://bugs.webkit.org/show_bug.cgi?id=180591
143
144         Reviewed by Saam Barati.
145
146         * Misc/WebKitErrors.m:
147         (+[NSError _registerWebKitErrors]):
148         (registerErrors): Deleted.
149         * Storage/WebStorageManager.mm:
150         (+[WebStorageManager _storageDirectoryPath]):
151         (initializeLocalStoragePath): Deleted.
152
153 2017-12-07  Darin Adler  <darin@apple.com>
154
155         Remove some unused code from WebKitLegacy
156         https://bugs.webkit.org/show_bug.cgi?id=180567
157
158         Reviewed by Anders Carlsson.
159
160         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
161         macOS (back a few versions) and iOS and removed unused
162         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
163         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
164         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
165         _webkit_stringByCollapsingNonPrintingCharacters,
166         _webkit_stringByCollapsingWhitespaceCharacters,
167         _web_stringWithData:textEncodingName:, and
168         _webkit_localStorageDirectoryWithBundleIdentifier:.
169
170         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
171         this source file.
172         (canUseFastRenderer): Made this faster by not calling u_charDirection for
173         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
174         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
175         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
176         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
177         handle font smoothing options.
178         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
179         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
180         from header and made it a little clearer.
181         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
182         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
183         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
184         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
185         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
186         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
187         implementation a bit and used whole words instead of abbreviations.
188         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
189
190         * Misc/WebNSFileManagerExtras.mm:
191         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
192         filenameByFixingIllegalCharacters function from WebCore directly instead of
193         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
194
195         * Plugins/WebBaseNetscapePluginView.mm:
196         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
197         string replacements instead of _web_stringByStrippingReturnCharacters
198         and to use NSString methods instead of CFString functions.
199
200 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
201
202         Ignore deprecation warnings.
203
204         * WebView/WebHTMLView.mm:
205         (-[NSWindow _web_borderView]):
206         (-[WebHTMLView _setAsideSubviews]):
207         * WebView/WebView.mm:
208         (-[WebView encodeWithCoder:]):
209
210 2017-12-02  Darin Adler  <darin@apple.com>
211
212         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
213         https://bugs.webkit.org/show_bug.cgi?id=180009
214
215         Reviewed by Alex Christensen.
216
217         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
218
219         * Plugins/WebBaseNetscapePluginView.mm:
220         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
221         of strcasecmp.
222
223         * WebView/WebPreferences.mm:
224         (contains): Ditto. Also made this a template so it's easier to call on an array.
225         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
226
227 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
228
229         Limit user agent versioning to an upper bound
230         https://bugs.webkit.org/show_bug.cgi?id=180365
231         <rdar://problem/34550617>
232
233         Reviewed by Joseph Pecoraro.
234
235         * WebView/WebView.mm:
236         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
237         creating the User Agent string.
238         (webKitBundleVersionString): Deleted.
239
240 2017-12-05  Andy Estes  <aestes@apple.com>
241
242         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
243         https://bugs.webkit.org/show_bug.cgi?id=180457
244         <rdar://problem/35143007>
245
246         Reviewed by Tim Horton.
247
248         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
249         check for this macro during post-processing.
250
251         * postprocess-headers.sh:
252
253 2017-12-04  David Quesada  <david_quesada@apple.com>
254
255         Add a class for parsing application manifests
256         https://bugs.webkit.org/show_bug.cgi?id=177973
257         rdar://problem/34747949
258
259         Reviewed by Geoffrey Garen.
260
261         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
262
263 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
264
265         Make LegacyCustomProtocolManager optional for network process
266         https://bugs.webkit.org/show_bug.cgi?id=176230
267
268         Reviewed by Alex Christensen.
269
270         * Configurations/FeatureDefines.xcconfig:
271
272 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
273
274         Fix some NSOperationQueue leaks
275         https://bugs.webkit.org/show_bug.cgi?id=180221
276
277         Reviewed by Wenson Hsieh.
278
279         * WebView/WebView.mm:
280         (-[WebView performDragOperation:]):
281
282 2017-11-30  Darin Adler  <darin@apple.com>
283
284         [Mac] remove unneeded RetainPtr use introduced in r225142
285         https://bugs.webkit.org/show_bug.cgi?id=180202
286
287         Reviewed by Tim Horton.
288
289         * WebView/WebImmediateActionController.mm:
290         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
291         RetainPtr.
292
293 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
294
295         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
296         https://bugs.webkit.org/show_bug.cgi?id=175595
297
298         Reviewed by Darin Adler.
299
300         * WebView/WebPreferences.mm:
301
302 2017-11-27  Tim Horton  <timothy_horton@apple.com>
303
304         One too many zeroes in macOS version number in FeatureDefines
305         https://bugs.webkit.org/show_bug.cgi?id=180011
306
307         Reviewed by Dan Bernstein.
308
309         * Configurations/FeatureDefines.xcconfig:
310
311 2017-11-23  Darin Adler  <darin@apple.com>
312
313         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
314         https://bugs.webkit.org/show_bug.cgi?id=179981
315
316         Reviewed by Sam Weinig.
317
318         * WebView/WebImmediateActionController.mm:
319         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
320         * WebView/WebView.mm:
321         (coreOptions): Use |= instead of | to build up FindOptions.
322
323 2017-11-23  Sam Weinig  <sam@webkit.org>
324
325         Remove unneeded ScriptController::processingUserGesture() forwarding functions
326         https://bugs.webkit.org/show_bug.cgi?id=179954
327
328         Reviewed by Darin Adler.
329
330         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
331         with direct calls to the corresponding UserGestureIndicator functions.
332
333         * Plugins/WebPluginController.mm:
334         (-[WebPluginController processingUserGesture]):
335         * WebView/WebView.mm:
336         (-[WebView _isProcessingUserGesture]):
337
338 2017-11-23  Darin Adler  <darin@apple.com>
339
340         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
341         https://bugs.webkit.org/show_bug.cgi?id=179907
342
343         Reviewed by Sam Weinig.
344
345         * History/BinaryPropertyList.cpp:
346         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
347         (BinaryPropertyListSerializer::appendStringObject): Ditto.
348         * WebView/WebHTMLRepresentation.mm:
349         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
350         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
351
352 2017-11-22  Ali Juma  <ajuma@chromium.org>
353
354         Implement VisualViewport API attributes
355         https://bugs.webkit.org/show_bug.cgi?id=179385
356
357         Reviewed by Frédéric Wang.
358
359         Add a VisualViewportAPI preference.
360
361         * WebView/WebPreferenceKeysPrivate.h:
362         * WebView/WebPreferences.mm:
363         (+[WebPreferences initialize]):
364         (-[WebPreferences visualViewportAPIEnabled]):
365         (-[WebPreferences setVisualViewportAPIEnabled:]):
366         * WebView/WebPreferencesPrivate.h:
367         * WebView/WebView.mm:
368         (-[WebView _preferencesChanged:]):
369
370 2017-11-22  Christopher Reid  <chris.reid@sony.com>
371
372         WebCoreObjCExtras.h is being included in too many places
373         https://bugs.webkit.org/show_bug.cgi?id=179931
374
375         Reviewed by Darin Adler.
376
377         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
378         * Plugins/WebBaseNetscapePluginView.mm:
379         * Plugins/WebBasePluginPackage.mm:
380         * Plugins/WebNetscapePluginStream.mm:
381         * Plugins/WebNetscapePluginView.mm:
382         * WebView/WebTextIterator.mm:
383         * WebView/WebViewData.mm:
384
385 2017-11-22  Commit Queue  <commit-queue@webkit.org>
386
387         Unreviewed, rolling out r225093.
388         https://bugs.webkit.org/show_bug.cgi?id=179938
389
390         Compilation failed on WinCairo 64-bit Release (Requested by
391         fredw on #webkit).
392
393         Reverted changeset:
394
395         "Implement VisualViewport API attributes"
396         https://bugs.webkit.org/show_bug.cgi?id=179385
397         https://trac.webkit.org/changeset/225093
398
399 2017-11-21  Ali Juma  <ajuma@chromium.org>
400
401         Implement VisualViewport API attributes
402         https://bugs.webkit.org/show_bug.cgi?id=179385
403
404         Reviewed by Frédéric Wang.
405
406         Add a VisualViewportAPI preference.
407
408         * WebView/WebPreferenceKeysPrivate.h:
409         * WebView/WebPreferences.mm:
410         (+[WebPreferences initialize]):
411         (-[WebPreferences visualViewportAPIEnabled]):
412         (-[WebPreferences setVisualViewportAPIEnabled:]):
413         * WebView/WebPreferencesPrivate.h:
414         * WebView/WebView.mm:
415         (-[WebView _preferencesChanged:]):
416
417 2017-11-21  Christopher Reid  <chris.reid@sony.com>
418
419         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
420         https://bugs.webkit.org/show_bug.cgi?id=179504
421
422         Reviewed by Darin Adler.
423
424         * Misc/WebKitNSStringExtras.mm:
425         * Plugins/Hosted/NetscapePluginHostManager.mm:
426         * Plugins/WebBasePluginPackage.mm:
427
428 2017-11-19  Tim Horton  <timothy_horton@apple.com>
429
430         Remove unused TOUCH_ICON_LOADING feature flag
431         https://bugs.webkit.org/show_bug.cgi?id=179873
432
433         Reviewed by Simon Fraser.
434
435         * Configurations/FeatureDefines.xcconfig:
436
437 2017-11-19  Tim Horton  <timothy_horton@apple.com>
438
439         Remove unused LEGACY_VENDOR_PREFIXES feature flag
440         https://bugs.webkit.org/show_bug.cgi?id=179872
441
442         Reviewed by Darin Adler.
443
444         * Configurations/FeatureDefines.xcconfig:
445
446 2017-11-16  Daniel Bates  <dabates@apple.com>
447
448         Add feature define for alternative presentation button element
449         https://bugs.webkit.org/show_bug.cgi?id=179692
450         Part of <rdar://problem/34917108>
451
452         Reviewed by Andy Estes.
453
454         Only enabled on Cocoa platforms by default.
455
456         * Configurations/FeatureDefines.xcconfig:
457
458 2017-11-14  Nan Wang  <n_wang@apple.com>
459
460         AX: AOM: Implement AccessibleNode class and support label and role attributes
461         https://bugs.webkit.org/show_bug.cgi?id=179494
462
463         Reviewed by Ryosuke Niwa.
464
465         * WebView/WebPreferenceKeysPrivate.h:
466         * WebView/WebPreferences.mm:
467         (+[WebPreferences initialize]):
468         (-[WebPreferences accessibilityObjectModelEnabled]):
469         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
470         * WebView/WebPreferencesPrivate.h:
471         * WebView/WebView.mm:
472         (-[WebView _preferencesChanged:]):
473
474 2017-11-14  Alex Christensen  <achristensen@webkit.org>
475
476         Remove Cocoa CFURLConnection loading code
477         https://bugs.webkit.org/show_bug.cgi?id=179688
478
479         Reviewed by Antti Koivisto.
480
481         * Misc/WebDownload.mm:
482         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
483         * Misc/WebDownloadInternal.h:
484         * Plugins/WebBaseNetscapePluginView.mm:
485         * WebCoreSupport/WebFrameLoaderClient.mm:
486         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
487         * WebView/WebView.mm:
488         (-[WebView scheduleInRunLoop:forMode:]):
489         (-[WebView unscheduleFromRunLoop:forMode:]):
490
491 2017-11-14  Daniel Bates  <dabates@apple.com>
492
493         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
494         for feature defines
495
496         Following r195498 and r201917 the Visual Studio property files for feature defines have
497         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
498         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
499         files.
500
501         * Configurations/FeatureDefines.xcconfig:
502
503 2017-11-14  Jer Noble  <jer.noble@apple.com>
504
505         Enable Modern EME tests in DumpRenderTree
506         https://bugs.webkit.org/show_bug.cgi?id=179544
507
508         Reviewed by Alex Christensen.
509
510         Add a WebPreferences property to enable the (modern) EME API.
511
512         * WebView/WebPreferenceKeysPrivate.h:
513         * WebView/WebPreferences.mm:
514         (+[WebPreferences initialize]):
515         (-[WebPreferences encryptedMediaAPIEnabled]):
516         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
517         * WebView/WebPreferencesPrivate.h:
518         * WebView/WebView.mm:
519         (-[WebView _preferencesChanged:]):
520
521 2017-11-14  Antti Koivisto  <antti@apple.com>
522
523         Enable display:contents by default
524         https://bugs.webkit.org/show_bug.cgi?id=179655
525
526         Reviewed by Sam Weinig.
527
528         * WebView/WebPreferences.mm:
529         (+[WebPreferences initialize]):
530
531 2017-11-13  Alex Christensen  <achristensen@webkit.org>
532
533         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
534         https://bugs.webkit.org/show_bug.cgi?id=178751
535
536         Reviewed by Brady Eidson.
537
538         * WebCoreSupport/WebFrameNetworkingContext.mm:
539         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
540
541 2017-11-08  Keith Miller  <keith_miller@apple.com>
542
543         Async iteration should only fetch the next method once and add feature flag
544         https://bugs.webkit.org/show_bug.cgi?id=179451
545
546         Reviewed by Geoffrey Garen.
547
548         Add feature flag for Async iteration.
549
550         * Configurations/FeatureDefines.xcconfig:
551
552 2017-11-13  Mark Lam  <mark.lam@apple.com>
553
554         Add more overflow check book-keeping for MarkedArgumentBuffer.
555         https://bugs.webkit.org/show_bug.cgi?id=179634
556         <rdar://problem/35492517>
557
558         Reviewed by Saam Barati.
559
560         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
561         (WebKit::NetscapePluginInstanceProxy::invoke):
562         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
563         (WebKit::NetscapePluginInstanceProxy::construct):
564
565 2017-11-12  Darin Adler  <darin@apple.com>
566
567         More is<> and downcast<>, less static_cast<>
568         https://bugs.webkit.org/show_bug.cgi?id=179600
569
570         Reviewed by Chris Dumez.
571
572         * DOM/DOM.mm:
573         (kit): Use is/downcast.
574         * WebCoreSupport/WebEditorClient.mm:
575         (WebEditorClient::handleKeyboardEvent): Ditto.
576         (WebEditorClient::handleInputMethodKeydown): Ditto.
577         * WebView/WebHTMLView.mm:
578         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
579
580 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
581
582         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
583         https://bugs.webkit.org/show_bug.cgi?id=179397
584
585         Reviewed by Wenson Hsieh.
586
587         * DOM/DOMHTMLInputElement.mm:
588         (-[DOMHTMLInputElement insertTextSuggestion:]):
589
590 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
591
592         HTMLMediaElement should not use element fullscreen on iOS
593         https://bugs.webkit.org/show_bug.cgi?id=179418
594         rdar://problem/35409277
595
596         Reviewed by Eric Carlson.
597
598         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
599
600         * Configurations/FeatureDefines.xcconfig:
601
602 2017-11-06  Alex Christensen  <achristensen@webkit.org>
603
604         Make ResourceLoader::willSendRequestInternal asynchronous
605         https://bugs.webkit.org/show_bug.cgi?id=179251
606
607         Reviewed by Andy Estes.
608
609         * Plugins/Hosted/HostedNetscapePluginStream.mm:
610         (WebKit::HostedNetscapePluginStream::start):
611         * Plugins/WebNetscapePluginStream.mm:
612         (WebNetscapePluginStream::start):
613
614 2017-11-01  Darin Adler  <darin@apple.com>
615
616         Simplify event dispatch code and make it a bit more consistent
617         https://bugs.webkit.org/show_bug.cgi?id=178991
618
619         Reviewed by Chris Dumez.
620
621         * DOM/DOMEvent.mm:
622         (-[DOMEvent srcElement]): Call target instead of srcElement.
623
624 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
625
626         [Touch Bar Web API] Add support for menuitem tag
627         https://bugs.webkit.org/show_bug.cgi?id=179020
628
629         Reviewed by Ryosuke Niwa.
630
631         Adds in properties and methods that allow the menuitem runtime feature
632         to be enabled or disabled.
633
634         * WebView/WebPreferenceKeysPrivate.h:
635         * WebView/WebPreferences.mm:
636         (-[WebPreferences menuItemElementEnabled]):
637         (-[WebPreferences setMenuItemElementEnabled:]):
638         * WebView/WebPreferencesPrivate.h:
639         * WebView/WebView.mm:
640         (-[WebView _preferencesChanged:]):
641
642 2017-11-02  Alex Christensen  <achristensen@webkit.org>
643
644         Use CompletionHandlers for redirects
645         https://bugs.webkit.org/show_bug.cgi?id=179163
646
647         Reviewed by Tim Horton.
648
649         * Plugins/Hosted/HostedNetscapePluginStream.h:
650         * Plugins/Hosted/HostedNetscapePluginStream.mm:
651         (WebKit::HostedNetscapePluginStream::willSendRequest):
652         * Plugins/WebNetscapePluginStream.h:
653         * Plugins/WebNetscapePluginStream.mm:
654         (WebNetscapePluginStream::willSendRequest):
655
656 2017-11-02  Christopher Reid  <chris.reid@sony.com>
657
658         Add a FileSystem namespace to FileSystem.cpp
659         https://bugs.webkit.org/show_bug.cgi?id=179063
660
661         Reviewed by Darin Adler.
662
663         * Misc/WebNSFileManagerExtras.mm:
664         * Storage/WebDatabaseProvider.mm:
665
666 2017-11-02  Frederic Wang  <fwang@igalia.com>
667
668         Add references to bug 179167 in FIXME comments
669         https://bugs.webkit.org/show_bug.cgi?id=179168
670
671         Reviewed by Daniel Bates.
672
673         * Configurations/FeatureDefines.xcconfig:
674
675 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
676
677         Implement WKFullscreenWindowController for iOS.
678         https://bugs.webkit.org/show_bug.cgi?id=178924
679         rdar://problem/34697120
680
681         Reviewed by Simon Fraser.
682
683         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
684
685         * Configurations/FeatureDefines.xcconfig:
686         * WebView/WebView.mm:
687         (-[WebView fullScreenPlaceholderView]):
688
689 2017-10-31  Tim Horton  <timothy_horton@apple.com>
690
691         Clean up some drag and drop feature flags
692         https://bugs.webkit.org/show_bug.cgi?id=179082
693
694         Reviewed by Simon Fraser.
695
696         * Configurations/FeatureDefines.xcconfig:
697
698 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
699
700         Make it possible to test rubber-banding in overflow scroll
701         https://bugs.webkit.org/show_bug.cgi?id=179078
702
703         Reviewed by Sam Weinig.
704
705         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
706         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
707
708         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
709         functions, since most callers want clamped.
710
711         * DOM/DOMHTML.mm:
712         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
713
714 2017-10-31  Tim Horton  <timothy_horton@apple.com>
715
716         Fix up some content filtering feature flags
717         https://bugs.webkit.org/show_bug.cgi?id=179079
718
719         Reviewed by Simon Fraser.
720
721         * Configurations/FeatureDefines.xcconfig:
722
723 2017-10-28  Zalan Bujtas  <zalan@apple.com>
724
725         [FrameView::layout cleanup] Move core layout logic to a separate class.
726         https://bugs.webkit.org/show_bug.cgi?id=178771
727         <rdar://problem/35166542>
728
729         Reviewed by Simon Fraser.
730
731         Move layout code out from FrameView to LayoutContext.
732
733         * WebView/WebClipView.mm:
734         (-[WebClipView _immediateScrollToPoint:]):
735         * WebView/WebFrame.mm:
736         (-[WebFrame layoutCount]):
737
738 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
739
740         Fix issues with WebView subframe painting
741         https://bugs.webkit.org/show_bug.cgi?id=178842
742         rdar://problem/34072253
743
744         Reviewed by Daniel Bates.
745         
746         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
747         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
748         High Sierra, so match the new signature.
749
750         Also rename the 'rect' param to 'displayRect' to match AppKit code.
751
752         * WebView/WebHTMLView.mm:
753         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
754         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
755
756 2017-10-25  Youenn Fablet  <youenn@apple.com>
757
758         Enable ServiceWorker to fetch resources
759         https://bugs.webkit.org/show_bug.cgi?id=178673
760
761         Reviewed by Brady Eidson.
762
763         * WebCoreSupport/WebFrameLoaderClient.mm:
764         (WebFrameLoaderClient::pageID const):
765         (WebFrameLoaderClient::frameID const):
766         (WebFrameLoaderClient::sessionID const):
767
768         Added implementation to the new getters.
769         They are noop in the context of WK1.
770
771 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
772
773         Web Inspector: Enable WebKit logging configuration and display
774         https://bugs.webkit.org/show_bug.cgi?id=177027
775         <rdar://problem/33964767>
776
777         Reviewed by Joseph Pecoraro.
778
779         * WebCoreSupport/WebChromeClient.mm:
780         (stringForMessageSource): Deal with Media and WebRTC message sources.
781
782 2017-10-20  Antoine Quint  <graouts@apple.com>
783
784         [Web Animations] Provide basic timeline and animation interfaces
785         https://bugs.webkit.org/show_bug.cgi?id=178526
786
787         Reviewed by Dean Jackson.
788
789         Remove the WEB_ANIMATIONS compile-time flag.
790
791         * Configurations/FeatureDefines.xcconfig:
792         * WebView/WebPreferences.mm:
793         (+[WebPreferences initialize]):
794         * WebView/WebView.mm:
795         (-[WebView _preferencesChanged:]):
796
797 2017-10-19  Sam Weinig  <sam@webkit.org>
798
799         [Settings] Move global settings into their own file
800         https://bugs.webkit.org/show_bug.cgi?id=178512
801
802         Reviewed by Darin Adler.
803
804         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
805
806         * WebCoreSupport/WebChromeClient.mm:
807         (WebChromeClient::supportsVideoFullscreen):
808         * WebView/WebDynamicScrollBarsView.mm:
809         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
810         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
811         * WebView/WebPreferences.mm:
812         (+[WebPreferences initialize]):
813         * WebView/WebView.mm:
814         (-[WebView _commonInitializationWithFrameName:groupName:]):
815         (-[WebView _preferencesChanged:]):
816         (+[WebView _doNotStartObservingNetworkReachability]):
817
818 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
819
820         Replace some stack raw pointers with RefPtrs within WebCore/html
821         https://bugs.webkit.org/show_bug.cgi?id=178201
822         <rdar://problem/34841692>
823
824         Reviewed by Ryosuke Niwa.
825
826         * DOM/DOM.mm:
827         (kit):
828         Change the type of node as toNode() is changed to return RefPtr.
829
830 2017-10-18  Chris Dumez  <cdumez@apple.com>
831
832         [Service Worker] Add stubs for Client / WindowClient / Clients
833         https://bugs.webkit.org/show_bug.cgi?id=178469
834
835         Reviewed by Youenn Fablet.
836
837         Rename PageVisiblityState to VisibilityState.
838
839         * WebView/WebView.mm:
840         (kit):
841
842 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
843
844         Unreviewed, rolling out r223291.
845
846         See WebCore ChangeLog for more detail.
847
848         Reverted changeset:
849
850         "Remove Editor::simplifyMarkup"
851         https://bugs.webkit.org/show_bug.cgi?id=178271
852         https://trac.webkit.org/changeset/223291
853
854 2017-10-17  Keith Miller  <keith_miller@apple.com>
855
856         Change WebCore sources to work with unified source builds
857         https://bugs.webkit.org/show_bug.cgi?id=178229
858
859         Rubber stamped by Tim Horton.
860
861         * Configurations/FeatureDefines.xcconfig:
862
863 2017-10-16  Sam Weinig  <sam@webkit.org>
864
865         [Settings] Remove all custom code from Settings.h/cpp
866         https://bugs.webkit.org/show_bug.cgi?id=178330
867
868         Reviewed by Simon Fraser.
869
870         * WebView/WebPreferences.mm:
871         (+[WebPreferences initialize]):
872         
873             Update for naming changes of FrameFlattening now that it is an enum class.
874
875 2017-10-13  Alex Christensen  <achristensen@webkit.org>
876
877         Remove Editor::simplifyMarkup
878         https://bugs.webkit.org/show_bug.cgi?id=178271
879
880         Reviewed by Wenson Hsieh.
881
882         * WebView/WebView.mm:
883         (-[WebView _simplifyMarkup:endNode:]):
884
885 2017-10-12  Chris Dumez  <cdumez@apple.com>
886
887         [Mac] Add support for MouseEvent.buttons
888         https://bugs.webkit.org/show_bug.cgi?id=178214
889
890         Reviewed by Ryosuke Niwa.
891
892         * WebView/WebPDFView.mm:
893         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
894
895 2017-10-11  Sam Weinig  <sam@webkit.org>
896
897         Remove out-parameter variants of copyToVector
898         https://bugs.webkit.org/show_bug.cgi?id=178155
899
900         Reviewed by Tim Horton.
901
902         * Plugins/WebNetscapePluginView.mm:
903         (-[WebNetscapePluginView destroyPlugin]):
904         * WebView/WebHTMLRepresentation.mm:
905         (newArrayWithStrings):
906
907             Replace out-parameter based copyToVector, with one that returns a Vector.
908
909 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
910
911         Sanitize URL in pasteboard for other applications and cross origin content
912         https://bugs.webkit.org/show_bug.cgi?id=178060
913         <rdar://problem/34874518>
914
915         Reviewed by Wenson Hsieh.
916
917         * WebCoreSupport/WebPlatformStrategies.h:
918         * WebCoreSupport/WebPlatformStrategies.mm:
919         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
920
921 2017-10-11  Chris Dumez  <cdumez@apple.com>
922
923         Modernize Geolocation code
924         https://bugs.webkit.org/show_bug.cgi?id=178148
925
926         Reviewed by Ryosuke Niwa.
927
928         * WebCoreSupport/WebGeolocationClient.h:
929         * WebCoreSupport/WebGeolocationClient.mm:
930         (WebGeolocationClient::lastPosition):
931         * WebView/WebGeolocationPosition.mm:
932         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
933         (core):
934         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
935         (-[WebGeolocationPosition initWithGeolocationPosition:]):
936         * WebView/WebGeolocationPositionInternal.h:
937
938 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
939
940         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
941         https://bugs.webkit.org/show_bug.cgi?id=178154
942
943         Reviewed by Wenson Hsieh.
944
945         Enable custom pasteboard data by default.
946
947         * WebView/WebPreferenceKeysPrivate.h:
948         * WebView/WebPreferences.mm:
949         (+[WebPreferences initialize]):
950         (-[WebPreferences customPasteboardDataEnabled]): Added.
951         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
952         * WebView/WebPreferencesPrivate.h:
953         * WebView/WebView.mm:
954         (-[WebView _preferencesChanged:]):
955
956 2017-10-10  Sam Weinig  <sam@webkit.org>
957
958         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
959         https://bugs.webkit.org/show_bug.cgi?id=178102
960
961         Reviewed by Tim Horton.
962
963         * History/WebHistory.mm:
964         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
965         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
966         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
967         * WebCoreSupport/WebUserMediaClient.mm:
968         (WebUserMediaClient::pageDestroyed):
969
970 2017-10-09  Robin Morisset  <rmorisset@apple.com>
971
972         Make the names of the options consistent
973         https://bugs.webkit.org/show_bug.cgi?id=177933
974
975         Reviewed by Saam Barati.
976
977         * WebView/WebFrame.h:
978         * WebView/WebHTMLView.mm:
979         (-[WebHTMLView setMarkedText:selectedRange:]):
980         * WebView/WebView.h:
981
982 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
983
984         [iOS] Tweak support for classifying form controls (followup to r222487)
985         https://bugs.webkit.org/show_bug.cgi?id=177917
986         <rdar://problem/34820122>
987
988         Reviewed by Dean Jackson.
989
990         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
991
992         * DOM/DOMHTMLInputElement.mm:
993         (-[DOMHTMLInputElement _autofillContext]):
994         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
995         (-[DOMHTMLInputElement representingPageURL]): Deleted.
996
997 2017-10-05  Keith Miller  <keith_miller@apple.com>
998
999         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1000
1001         * Configurations/WebKitLegacy.xcconfig:
1002
1003 2017-10-05  Jer Noble  <jer.noble@apple.com>
1004
1005         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1006         https://bugs.webkit.org/show_bug.cgi?id=177261
1007
1008         Reviewed by Eric Carlson.
1009
1010         * Configurations/FeatureDefines.xcconfig:
1011
1012 2017-10-05  Chris Dumez  <cdumez@apple.com>
1013
1014         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1015         https://bugs.webkit.org/show_bug.cgi?id=177957
1016
1017         Reviewed by Alex Christensen.
1018
1019         * WebCoreSupport/WebPlatformStrategies.h:
1020         * WebCoreSupport/WebPlatformStrategies.mm:
1021         (WebPlatformStrategies::cookiesEnabled):
1022
1023 2017-10-05  Youenn Fablet  <youenn@apple.com>
1024
1025         Make LibWebRTCProvider port agnostic
1026         https://bugs.webkit.org/show_bug.cgi?id=177747
1027
1028         Reviewed by Alex Christensen & Alex Garcia.
1029
1030         * WebView/WebView.mm:
1031         (-[WebView _commonInitializationWithFrameName:groupName:]):
1032         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1033
1034 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1035
1036         Stop linking with WebKitSystemInterface
1037         https://bugs.webkit.org/show_bug.cgi?id=177915
1038
1039         Reviewed by Antti Koivisto.
1040
1041         * Configurations/DebugRelease.xcconfig:
1042         * Configurations/WebKitLegacy.xcconfig:
1043
1044 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1045
1046         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1047         https://bugs.webkit.org/show_bug.cgi?id=177912
1048
1049         Reviewed by Saam Barati.
1050
1051         * Carbon/CarbonUtils.m:
1052         * Carbon/CarbonWindowAdapter.mm:
1053         * Carbon/HIWebView.mm:
1054         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1055         * Misc/WebNSFileManagerExtras.mm:
1056         * Misc/WebNSPasteboardExtras.mm:
1057         * Misc/WebNSURLExtras.mm:
1058         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1059         * Plugins/Hosted/NetscapePluginHostManager.mm:
1060         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1061         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1062         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1063         * Plugins/Hosted/WebTextInputWindowController.m:
1064         * Plugins/WebBaseNetscapePluginView.mm:
1065         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1066         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1067         * Plugins/WebNetscapePluginStream.mm:
1068         * Plugins/WebNetscapePluginView.mm:
1069         * Plugins/WebPluginDatabase.mm:
1070         * WebCoreSupport/PopupMenuMac.mm:
1071         * WebCoreSupport/WebChromeClient.mm:
1072         * WebCoreSupport/WebFrameLoaderClient.mm:
1073         * WebCoreSupport/WebInspectorClient.mm:
1074         * WebCoreSupport/WebPlatformStrategies.mm:
1075         * WebCoreSupport/WebSystemInterface.mm:
1076         * WebView/WebDynamicScrollBarsView.mm:
1077         * WebView/WebFrame.mm:
1078         * WebView/WebFrameView.mm:
1079         * WebView/WebFullScreenController.mm:
1080         * WebView/WebHTMLView.mm:
1081         * WebView/WebPreferences.mm:
1082         * WebView/WebView.mm:
1083
1084 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1085
1086         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1087         rdar://problem/34705779
1088
1089         Addressing review comments that I somehow landed without.
1090
1091         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1092
1093 2017-09-29  Chris Dumez  <cdumez@apple.com>
1094
1095         Split some logic out of VisitedLinkStore and make it reusable
1096         https://bugs.webkit.org/show_bug.cgi?id=177575
1097
1098         Reviewed by Alex Christensen.
1099
1100         * WebCoreSupport/WebVisitedLinkStore.h:
1101         * WebCoreSupport/WebVisitedLinkStore.mm:
1102         (WebVisitedLinkStore::addVisitedLink):
1103         (WebVisitedLinkStore::removeVisitedLink):
1104         (WebVisitedLinkStore::isLinkVisited):
1105         (WebVisitedLinkStore::addVisitedLinkHash):
1106
1107 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1108
1109         Build fix for High Sierra 32 bit Mac
1110         https://bugs.webkit.org/show_bug.cgi?id=177551
1111         <rdar://problem/34690283>
1112
1113         Reviewed by Alexey Proskuryakov.
1114
1115         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1116         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1117         also made.
1118
1119         * Carbon/CarbonWindowAdapter.mm:
1120         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1121         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1122         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1123         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1124         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1125         (-[CarbonWindowAdapter dealloc]):
1126         (-[CarbonWindowAdapter windowRef]):
1127         (-[CarbonWindowAdapter _hasWindowRef]):
1128         (-[CarbonWindowAdapter _managesWindowRef]):
1129         (-[CarbonWindowAdapter _removeWindowRef]):
1130         (-[CarbonWindowAdapter _carbonWindowClass]):
1131         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1132         (-[CarbonWindowAdapter sendSuperEvent:]):
1133         (-[CarbonWindowAdapter relinquishFocus]):
1134         (-[CarbonWindowAdapter _cancelKey:]):
1135         (-[CarbonWindowAdapter _commonAwake]):
1136         (-[CarbonWindowAdapter _destroyRealWindow:]):
1137         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1138         (-[CarbonWindowAdapter _termWindowIfOwner]):
1139         (-[CarbonWindowAdapter _windowMovedToRect:]):
1140         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1141         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1142         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1143         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1144         (-[CarbonWindowAdapter canBecomeMainWindow]):
1145         (-[CarbonWindowAdapter encodeWithCoder:]):
1146         (-[CarbonWindowAdapter initWithCoder:]):
1147         (-[CarbonWindowAdapter setContentView:]):
1148         (-[CarbonWindowAdapter worksWhenModal]):
1149         (-[CarbonWindowAdapter _setModalWindowLevel]):
1150         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1151         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1152         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1153         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1154         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1155         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1156         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1157         (NSCarbonWindowHandleEvent):
1158         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1159         (-[CarbonWindowAdapter _growBoxRect]):
1160         * Carbon/HIWebView.mm:
1161         (HIWebViewGetWebView):
1162         (HIWebViewConstructor):
1163         (HIWebViewDestructor):
1164         (HIWebViewRegisterClass):
1165         (GetBehaviors):
1166         (Draw):
1167         (HitTest):
1168         (GetRegion):
1169         (GetWindowRef):
1170         (CreateNSEventAdoptingCGEvent):
1171         (CopyEventCGEvent):
1172         (CreateNSEventWithCarbonClickEvent):
1173         (Click):
1174         (CreateNSEventWithCarbonEvent):
1175         (MouseUp):
1176         (CreateNSEventWithCarbonMouseMoveEvent):
1177         (MouseMoved):
1178         (MouseDragged):
1179         (MouseWheelMoved):
1180         (ContextMenuClick):
1181         (GetKind):
1182         (BoundsChanged):
1183         (OwningWindowChanged):
1184         (WindowHandler):
1185         (SyncFrame):
1186         (SetFocusPart):
1187         (AdvanceFocus):
1188         (RelinquishFocus):
1189         (ActiveStateChanged):
1190         (ProcessCommand):
1191         (UpdateCommandStatus):
1192         (_NSSelectorForHICommand):
1193         (HIWebViewEventHandler):
1194         (StartUpdateObserver):
1195         (StopUpdateObserver):
1196         (UpdateObserver):
1197
1198 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1201         https://bugs.webkit.org/show_bug.cgi?id=172526
1202         <rdar://problem/32396081>
1203
1204         Reviewed by Ryosuke Niwa.
1205
1206         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1207
1208         * WebCoreSupport/WebPlatformStrategies.h:
1209         * WebCoreSupport/WebPlatformStrategies.mm:
1210         (WebPlatformStrategies::webExposedTypes):
1211         (WebPlatformStrategies::writeCustomData):
1212
1213 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1214
1215         Unreviewed, rolling out r222567.
1216
1217         This broke and internal build.
1218
1219         Reverted changeset:
1220
1221         "Build fix for High Sierra 32 bit Mac"
1222         https://bugs.webkit.org/show_bug.cgi?id=177551
1223         http://trac.webkit.org/changeset/222567
1224
1225 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1226
1227         Build fix for High Sierra 32 bit Mac
1228         https://bugs.webkit.org/show_bug.cgi?id=177551
1229         <rdar://problem/34690283>
1230
1231         Reviewed by Alexey Proskuryakov.
1232
1233         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1234         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1235         also made.
1236
1237         * Carbon/CarbonWindowAdapter.mm:
1238         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1239         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1240         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1241         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1242         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1243         (-[CarbonWindowAdapter dealloc]):
1244         (-[CarbonWindowAdapter windowRef]):
1245         (-[CarbonWindowAdapter _hasWindowRef]):
1246         (-[CarbonWindowAdapter _managesWindowRef]):
1247         (-[CarbonWindowAdapter _removeWindowRef]):
1248         (-[CarbonWindowAdapter _carbonWindowClass]):
1249         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1250         (-[CarbonWindowAdapter sendSuperEvent:]):
1251         (-[CarbonWindowAdapter relinquishFocus]):
1252         (-[CarbonWindowAdapter _cancelKey:]):
1253         (-[CarbonWindowAdapter _commonAwake]):
1254         (-[CarbonWindowAdapter _destroyRealWindow:]):
1255         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1256         (-[CarbonWindowAdapter _termWindowIfOwner]):
1257         (-[CarbonWindowAdapter _windowMovedToRect:]):
1258         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1259         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1260         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1261         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1262         (-[CarbonWindowAdapter canBecomeMainWindow]):
1263         (-[CarbonWindowAdapter encodeWithCoder:]):
1264         (-[CarbonWindowAdapter initWithCoder:]):
1265         (-[CarbonWindowAdapter setContentView:]):
1266         (-[CarbonWindowAdapter worksWhenModal]):
1267         (-[CarbonWindowAdapter _setModalWindowLevel]):
1268         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1269         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1270         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1271         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1272         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1273         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1274         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1275         (NSCarbonWindowHandleEvent):
1276         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1277         (-[CarbonWindowAdapter _growBoxRect]):
1278         * Carbon/HIWebView.mm:
1279         (HIWebViewGetWebView):
1280         (HIWebViewConstructor):
1281         (HIWebViewDestructor):
1282         (HIWebViewRegisterClass):
1283         (GetBehaviors):
1284         (Draw):
1285         (HitTest):
1286         (GetRegion):
1287         (GetWindowRef):
1288         (CreateNSEventAdoptingCGEvent):
1289         (CopyEventCGEvent):
1290         (CreateNSEventWithCarbonClickEvent):
1291         (Click):
1292         (CreateNSEventWithCarbonEvent):
1293         (MouseUp):
1294         (CreateNSEventWithCarbonMouseMoveEvent):
1295         (MouseMoved):
1296         (MouseDragged):
1297         (MouseWheelMoved):
1298         (ContextMenuClick):
1299         (GetKind):
1300         (BoundsChanged):
1301         (OwningWindowChanged):
1302         (WindowHandler):
1303         (SyncFrame):
1304         (SetFocusPart):
1305         (AdvanceFocus):
1306         (RelinquishFocus):
1307         (ActiveStateChanged):
1308         (ProcessCommand):
1309         (UpdateCommandStatus):
1310         (_NSSelectorForHICommand):
1311         (HIWebViewEventHandler):
1312         (StartUpdateObserver):
1313         (StopUpdateObserver):
1314         (UpdateObserver):
1315
1316 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1317
1318         Make PolicyAction an encodable enum class
1319         https://bugs.webkit.org/show_bug.cgi?id=177480
1320
1321         Reviewed by Antti Koivisto.
1322
1323         * Plugins/WebPluginContainerCheck.mm:
1324         (-[WebPluginContainerCheck _continueWithPolicy:]):
1325         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1326         * WebCoreSupport/WebFrameLoaderClient.mm:
1327         (-[WebFramePolicyListener invalidate]):
1328         (-[WebFramePolicyListener ignore]):
1329         (-[WebFramePolicyListener download]):
1330         (-[WebFramePolicyListener use]):
1331         (-[WebFramePolicyListener continue]):
1332         * WebView/WebPolicyDelegate.mm:
1333         (-[WebPolicyDecisionListener use]):
1334         (-[WebPolicyDecisionListener ignore]):
1335         (-[WebPolicyDecisionListener download]):
1336
1337 2017-09-25  Frederik Riedel  <riedel@apple.com>
1338
1339         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1340         https://bugs.webkit.org/show_bug.cgi?id=174394
1341         <rdar://problem/33183504>
1342
1343         Reviewed by Ryosuke Niwa.
1344
1345         * DOM/DOMHTMLInputElement.h:
1346         * DOM/DOMHTMLInputElement.mm:
1347         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1348         Determines if this HTMLInputElement is part of a login screen.
1349         (-[DOMHTMLInputElement representingPageUrl]):
1350         Returns the webpage's URL that is currently displayed in the Web View.
1351         (-[DOMHTMLInputElement insertTextSuggestion:]):
1352         Inserts login credentials into the Web View.
1353
1354 2017-09-25  Sam Weinig  <sam@webkit.org>
1355
1356         Remove unused EditorClient functions
1357         https://bugs.webkit.org/show_bug.cgi?id=177463
1358
1359         Reviewed by Alex Christensen.
1360
1361         Remove unused EditorClient functions.
1362
1363         * WebCoreSupport/WebEditorClient.h:
1364         * WebCoreSupport/WebEditorClient.mm:
1365         (WebEditorClient::canonicalizeURL): Deleted.
1366         (WebEditorClient::canonicalizeURLString): Deleted.
1367         (WebEditorClient::writeDataToPasteboard): Deleted.
1368         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1369         (WebEditorClient::readDataFromPasteboard): Deleted.
1370         (WebEditorClient::pasteboardChangeCount): Deleted.
1371
1372 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1373
1374         Stop using PolicyCallback
1375         https://bugs.webkit.org/show_bug.cgi?id=176088
1376
1377         Reviewed by Andy Estes.
1378
1379         * WebCoreSupport/WebFrameLoaderClient.mm:
1380         (-[WebFramePolicyListener invalidate]):
1381         (-[WebFramePolicyListener receivedPolicyDecision:]):
1382
1383 2017-09-25  Sam Weinig  <sam@webkit.org>
1384
1385         Remove unnecessary userVisibleString EditorClient function
1386         https://bugs.webkit.org/show_bug.cgi?id=177456
1387
1388         Reviewed by Dan Bernstein.
1389
1390         * WebCoreSupport/WebEditorClient.h:
1391         * WebCoreSupport/WebEditorClient.mm:
1392         (WebEditorClient::userVisibleString): Deleted.
1393
1394             Remove userVisibleString client function.
1395
1396 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1397
1398         Separate form submission from PolicyChecker infrastructure
1399         https://bugs.webkit.org/show_bug.cgi?id=177396
1400
1401         Reviewed by Geoffrey Garen.
1402
1403         * WebCoreSupport/WebFrameLoaderClient.h:
1404         * WebCoreSupport/WebFrameLoaderClient.mm:
1405         (WebFrameLoaderClient::dispatchWillSubmitForm):
1406
1407 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1408
1409         WeakPtrFactory should populate m_ref lazily.
1410         https://bugs.webkit.org/show_bug.cgi?id=177375
1411
1412         Reviewed by Geoffrey Garen.
1413
1414         * WebCoreSupport/WebEditorClient.mm:
1415         (WebEditorClient::WebEditorClient):
1416         (WebEditorClient::requestCandidatesForSelection):
1417
1418 2017-09-22  Chris Dumez  <cdumez@apple.com>
1419
1420         Use high resolution timestamp for event time
1421         https://bugs.webkit.org/show_bug.cgi?id=154246
1422         <rdar://problem/34333304>
1423
1424         Reviewed by Ryosuke Niwa.
1425
1426         Use WallTime / MonotonicTime instead of double type for clarity.
1427
1428         * DOM/DOMEvent.mm:
1429         (-[DOMEvent timeStamp]):
1430         * WebView/WebFrame.mm:
1431         (-[WebFrame _dragSourceEndedAt:operation:]):
1432         * WebView/WebPDFView.mm:
1433         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1434
1435 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1436
1437         Enable dataTransfer.items on macOS and iOS
1438         https://bugs.webkit.org/show_bug.cgi?id=177335
1439
1440         Reviewed by Sam Weinig.
1441
1442         * WebView/WebPreferences.mm:
1443         (+[WebPreferences initialize]):
1444
1445 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1446
1447         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1448         https://bugs.webkit.org/show_bug.cgi?id=177101
1449         <rdar://problem/34500648>
1450
1451         Reviewed by Brian Burg.
1452
1453         * WebInspector/WebNodeHighlight.mm:
1454         Ensure we close the window that we have just removed.
1455
1456 2017-09-20  Antti Koivisto  <antti@apple.com>
1457
1458         Remove DOM and styling support for CSS Regions
1459         https://bugs.webkit.org/show_bug.cgi?id=177221
1460
1461         Reviewed by Andreas Kling.
1462
1463         * Configurations/FeatureDefines.xcconfig:
1464         * DOM/DOMCSS.mm:
1465         (kitClass):
1466         * DOM/DOMElement.mm:
1467         (-[DOMElement webkitRegionOverset]): Deleted.
1468
1469 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1470
1471         Layering violation in Editor::createFragment
1472         https://bugs.webkit.org/show_bug.cgi?id=176123
1473
1474         Reviewed by Darin Adler.
1475
1476         * Misc/WebNSURLExtras.h:
1477         * Misc/WebNSURLExtras.mm:
1478         * WebView/WebFrame.mm:
1479         * WebView/WebHTMLView.mm:
1480         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1481
1482         * WebCoreSupport/WebEditorClient.mm:
1483         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1484         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1485         way to avoid exporting the symbol just on newer OSes.
1486
1487 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1488
1489         On iOS, getData can't get text set by setData during copy event
1490         https://bugs.webkit.org/show_bug.cgi?id=176980
1491         <rdar://problem/34453915>
1492
1493         Reviewed by Darin Adler.
1494
1495         * WebCoreSupport/WebPlatformStrategies.h:
1496         * WebCoreSupport/WebPlatformStrategies.mm:
1497         (WebPlatformStrategies::copy): Deleted.
1498
1499 2017-09-18  Andy Estes  <aestes@apple.com>
1500
1501         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1502         https://bugs.webkit.org/show_bug.cgi?id=177029
1503
1504         Reviewed by Alex Christensen.
1505
1506         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1507         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1508         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1509         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1510         * WebCoreSupport/PopupMenuMac.mm:
1511         (PopupMenuMac::show):
1512         * WebCoreSupport/WebSystemInterface.mm:
1513         (InitWebCoreSystemInterface):
1514         * WebView/WebHTMLView.mm:
1515         (-[WebHTMLView setDataSource:]):
1516         (-[WebHTMLView attachRootLayer:]):
1517         * WebView/WebView.mm:
1518         (-[WebView _needsAdobeFrameReloadingQuirk]):
1519         (-[WebView _needsLinkElementTextCSSQuirk]):
1520         (-[WebView _needsIsLoadingInAPISenseQuirk]):
1521         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
1522         (-[WebView _preferencesChanged:]):
1523
1524 2017-09-15  Andy Estes  <aestes@apple.com>
1525
1526         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
1527         https://bugs.webkit.org/show_bug.cgi?id=176953
1528
1529         Reviewed by Eric Carlson.
1530
1531         * WebCoreSupport/WebSystemInterface.mm:
1532         (InitWebCoreSystemInterface):
1533
1534 2017-09-14  Andy Estes  <aestes@apple.com>
1535
1536         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
1537         https://bugs.webkit.org/show_bug.cgi?id=176931
1538
1539         Reviewed by Joseph Pecoraro.
1540
1541         * WebCoreSupport/WebSystemInterface.mm:
1542         (InitWebCoreSystemInterface):
1543
1544 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1545
1546         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
1547         https://bugs.webkit.org/show_bug.cgi?id=176867
1548
1549         Reviewed by Sam Weinig.
1550
1551         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1552         (WebKit::NetscapePluginInstanceProxy::enumerate):
1553
1554 2017-09-13  Andy Estes  <aestes@apple.com>
1555
1556         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1557         https://bugs.webkit.org/show_bug.cgi?id=176729
1558
1559         Reviewed by Alex Christensen.
1560
1561         * WebCoreSupport/WebSystemInterface.mm:
1562         (InitWebCoreSystemInterface):
1563         * WebView/WebView.mm:
1564         (+[WebView _setCacheModel:]):
1565
1566 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1567
1568         Refactor WebContentReader out of EditorMac and EditorIOS
1569         https://bugs.webkit.org/show_bug.cgi?id=176770
1570
1571         Reviewed by Sam Weinig.
1572
1573         * WebCoreSupport/WebEditorClient.mm:
1574
1575 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1576
1577         Dragging & dropping a file creates an attachment element even when it's disabled
1578         https://bugs.webkit.org/show_bug.cgi?id=176769
1579
1580         Reviewed by Tim Horton.
1581
1582         * WebView/WebView.mm:
1583         (-[WebView _preferencesChanged:]):
1584
1585 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1586
1587         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1588         https://bugs.webkit.org/show_bug.cgi?id=176721
1589         <rdar://problem/34373660>
1590
1591         Reviewed by Tim Horton.
1592
1593         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1594         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1595
1596         * WebView/WebView.mm:
1597         (-[WebView _startDrag:]):
1598         (-[WebView _draggedElementBounds]):
1599         (-[WebView _endedDataInteraction:global:]):
1600         * WebView/WebViewData.h:
1601
1602 2017-09-11  Andy Estes  <aestes@apple.com>
1603
1604         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1605         https://bugs.webkit.org/show_bug.cgi?id=176472
1606
1607         Reviewed by Eric Carlson.
1608
1609         * WebCoreSupport/WebSystemInterface.mm:
1610         (InitWebCoreSystemInterface):
1611
1612 2017-09-09  Mark Lam  <mark.lam@apple.com>
1613
1614         Avoid duplicate computations of ExecState::vm().
1615         https://bugs.webkit.org/show_bug.cgi?id=176647
1616
1617         Reviewed by Saam Barati.
1618
1619         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1620         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1621         (WebKit::NetscapePluginInstanceProxy::construct):
1622         (WebKit::NetscapePluginInstanceProxy::setProperty):
1623         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1624         (WebKit::NetscapePluginInstanceProxy::enumerate):
1625         * Plugins/Hosted/ProxyInstance.mm:
1626         (WebKit::ProxyRuntimeMethod::create):
1627
1628 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1629
1630         Unreviewed, rolling out r221773.
1631         https://bugs.webkit.org/show_bug.cgi?id=176614
1632
1633         This caused build failures. (Requested by mlewis13 on
1634         #webkit).
1635
1636         Reverted changeset:
1637
1638         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1639         https://bugs.webkit.org/show_bug.cgi?id=176472
1640         http://trac.webkit.org/changeset/221773
1641
1642 2017-09-07  Andy Estes  <aestes@apple.com>
1643
1644         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1645         https://bugs.webkit.org/show_bug.cgi?id=176472
1646
1647         Reviewed by Eric Carlson.
1648
1649         * WebCoreSupport/WebSystemInterface.mm:
1650         (InitWebCoreSystemInterface):
1651
1652 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1653
1654         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1655         https://bugs.webkit.org/show_bug.cgi?id=176561
1656
1657         Reviewed by Brent Fulgham.
1658
1659         * Misc/WebNSUserDefaultsExtras.mm:
1660
1661 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1662
1663         Modernize Geolocation code
1664         https://bugs.webkit.org/show_bug.cgi?id=176496
1665
1666         Reviewed by Andy Estes.
1667
1668         * WebCoreSupport/WebGeolocationClient.h:
1669         * WebCoreSupport/WebGeolocationClient.mm:
1670         (WebGeolocationClient::requestPermission):
1671         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1672         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1673         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1674         * WebView/WebView.mm:
1675         (-[WebView _commonInitializationWithFrameName:groupName:]):
1676         (-[WebView _geolocationDidFailWithMessage:]):
1677
1678 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1679
1680         Remove some unused bits of code and resources
1681         https://bugs.webkit.org/show_bug.cgi?id=176275
1682
1683         Reviewed by Dan Bernstein.
1684
1685         * Misc/WebNSFileManagerExtras.mm:
1686         Include FileSystem instead of FileSystemIOS.
1687
1688 2017-09-03  Darin Adler  <darin@apple.com>
1689
1690         [Cocoa] Tidy a few things in legacy WebHTMLView
1691         https://bugs.webkit.org/show_bug.cgi?id=176280
1692
1693         Reviewed by Dan Bernstein.
1694
1695         * WebCoreSupport/WebChromeClient.mm:
1696         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1697         methods it calls on WebHTMLView were doing nothing on iOS.
1698
1699         * WebView/WebFrame.mm:
1700         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1701         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1702
1703         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1704         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1705         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1706         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1707         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1708         Use RetainPtr instead of writing retain/release wherever possible.
1709         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1710         initialization for it. Removed various unused methods and declarations of methods.
1711         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1712         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1713         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1714         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1715         and remove CFRetain no longer needed since we don't support garbage collection any more.
1716         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1717         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1718         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1719         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1720         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1721         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1722         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1723         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1724         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1725         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1726         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1727         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1728         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1729         debug flag; we haven't used it for years and it's not clearly helpful.
1730         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1731         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1732         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1733         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1734         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1735         two additional methods in the WebPrivate category and still be called by the two
1736         methods in the WebInternal category that were already using it.
1737         (-[WebHTMLView didAddSubview:]): Deleted.
1738         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1739         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1740         place this was called, the close method.
1741         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1742         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1743         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1744         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1745         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1746         Added helper method to make the one below simpler.
1747         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1748         Compared pasteboard type strings using isEqualToString: rather than using == since
1749         we want to actually compare the string contents. Also updated to use modern for loop,
1750         renamed a local variable from "s" to "localSubresources", and factored out the handling
1751         of three image types to use the helper method above.
1752         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1753         _web_makePluginSubviewsPerformSelector:withObject: method.
1754         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1755         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1756         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1757         not call the -[NSView subviews] method to make this identical on both platforms and used
1758         a modern for loop.
1759         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1760         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1761         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1762         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1763         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1764         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1765         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1766         of it is Mac-only.
1767         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1768         method did was call itself on the main thread, and do nothing if called on main thread.
1769         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1770         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1771         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1772         half of this method.
1773         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1774         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1775         Simplified using a modern for loop and RetainPtr.
1776         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1777         (-[WebHTMLView keyDown:]): Ditto.
1778         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1779         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1780         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1781         (-[WebHTMLView complete:]): Ditto.
1782         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1783         now macOS-only.
1784         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1785         iOS since that is now macOS-only.
1786         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1787         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1788         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1789         and reorganized to use early return.
1790         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1791         on iOS, but kept there so we don't have to do #if at every call site.
1792         (-[WebHTMLView _pluginController]): Moved into internal category.
1793         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1794         there only for GC, using C++ initialization, removing obsolete comment.
1795         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1796         peculiar iOS-only comment.
1797         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1798
1799         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1800         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1801         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1802         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1803         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1804
1805         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1806         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1807         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1808         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1809         them at this time.
1810
1811 2017-09-03  Sam Weinig  <sam@webkit.org>
1812
1813         Remove CanvasProxy
1814         https://bugs.webkit.org/show_bug.cgi?id=176288
1815
1816         Reviewed by Yusuke Suzuki.
1817
1818         CanvasProxy does not appear to be in any current HTML spec
1819         and was disabled and unimplemented in our tree. Time to 
1820         get rid of it.
1821
1822         * Configurations/FeatureDefines.xcconfig:
1823
1824 2017-09-02  Andy Estes  <aestes@apple.com>
1825
1826         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1827         https://bugs.webkit.org/show_bug.cgi?id=176270
1828
1829         Reviewed by Tim Horton.
1830
1831         * Plugins/Hosted/NetscapePluginHostManager.mm:
1832         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1833         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1834         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1835         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1836         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1837         (WebKit::SoftwareCARenderer::context const):
1838         (WebKit::SoftwareCARenderer::renderContext const):
1839         (WebKit::SoftwareCARenderer::render):
1840         (-[WebHostedNetscapePluginView createPlugin]):
1841         (-[WebHostedNetscapePluginView createPluginLayer]):
1842         (-[WebHostedNetscapePluginView destroyPlugin]):
1843         (-[WebHostedNetscapePluginView drawRect:]):
1844         * WebCoreSupport/WebSystemInterface.mm:
1845         (InitWebCoreSystemInterface):
1846
1847 2017-09-01  Andy Estes  <aestes@apple.com>
1848
1849         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1850         https://bugs.webkit.org/show_bug.cgi?id=176200
1851
1852         Reviewed by Tim Horton.
1853
1854         * Carbon/HIWebView.mm:
1855         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
1856         (overrideCGContext):
1857         (restoreCGContext):
1858         (Draw):
1859         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1860         (+[WebHostedNetscapePluginView initialize]):
1861         * Plugins/WebBaseNetscapePluginView.h:
1862         * Plugins/WebBaseNetscapePluginView.mm:
1863         (WebKit::sendUserChangeNotifications):
1864         * Plugins/WebNetscapePluginView.mm:
1865         (+[WebNetscapePluginView initialize]):
1866         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1867         * WebCoreSupport/WebSystemInterface.mm:
1868         (InitWebCoreSystemInterface):
1869         * WebView/WebFrame.mm:
1870         (-[WebFrame _paintBehaviorForDestinationContext:]):
1871         * WebView/WebFullScreenController.mm:
1872         (setClipRectForWindow):
1873         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1874         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1875         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1876         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1877
1878 2017-08-31  Andy Estes  <aestes@apple.com>
1879
1880         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1881         https://bugs.webkit.org/show_bug.cgi?id=176175
1882
1883         Reviewed by Brady Eidson.
1884
1885         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1886         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1887         * Plugins/Hosted/WebTextInputWindowController.m:
1888         (-[WebTextInputPanel init]):
1889         * WebCoreSupport/WebSystemInterface.mm:
1890         (InitWebCoreSystemInterface):
1891         * WebView/WebDynamicScrollBarsView.mm:
1892         (-[WebDynamicScrollBarsView scrollWheel:]):
1893         * WebView/WebHTMLView.mm:
1894         (-[WebHTMLView _removeWindowObservers]):
1895         (-[WebHTMLView addWindowObservers]):
1896         * WebView/WebView.mm:
1897         (-[WebView addWindowObserversForWindow:]):
1898         (-[WebView removeWindowObservers]):
1899         (-[WebView viewWillMoveToWindow:]):
1900
1901 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1902
1903         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1904         https://bugs.webkit.org/show_bug.cgi?id=175779
1905         <rdar://problem/22367975>
1906
1907         Reviewed by Tim Horton.
1908
1909         * WebCoreSupport/WebFrameLoaderClient.h:
1910         * WebCoreSupport/WebFrameLoaderClient.mm:
1911         (WebFrameLoaderClient::webGLPolicyForURL const):
1912         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1913
1914 2017-08-30  Andy Estes  <aestes@apple.com>
1915
1916         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1917         https://bugs.webkit.org/show_bug.cgi?id=176093
1918
1919         Reviewed by Eric Carlson.
1920
1921         * WebCoreSupport/WebSystemInterface.mm:
1922         (InitWebCoreSystemInterface):
1923
1924 2017-08-30  Andy Estes  <aestes@apple.com>
1925
1926         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1927         https://bugs.webkit.org/show_bug.cgi?id=176087
1928
1929         Reviewed by Alex Christensen.
1930
1931         * Carbon/CarbonUtils.m:
1932         (getNSAutoreleasePoolCount):
1933         (WebInitForCarbon):
1934         (PoolCleaner):
1935         * Carbon/CarbonWindowAdapter.mm:
1936         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1937         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1938         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1939         (-[CarbonWindowAdapter _windowMovedToRect:]):
1940         * Carbon/HIViewAdapter.m:
1941         * Carbon/HIWebView.mm:
1942         (Draw):
1943         (CreateNSEventAdoptingCGEvent):
1944         (CopyEventCGEvent):
1945         (CreateNSEventWithCarbonClickEvent):
1946         (Click):
1947         (CreateNSEventWithCarbonEvent):
1948         (MouseUp):
1949         (CreateNSEventWithCarbonMouseMoveEvent):
1950         (MouseMoved):
1951         (MouseDragged):
1952         (MouseWheelMoved):
1953         (WindowHandler):
1954         (HIWebViewEventHandler):
1955         * Misc/QuickDrawCompatibility.h: Removed.
1956         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1957         (getCarbonEvent):
1958         (WebNetscapePluginEventHandlerCarbon::keyDown):
1959         (WebNetscapePluginEventHandlerCarbon::keyUp):
1960         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1961         (WebNetscapePluginEventHandlerCocoa::keyDown):
1962         * Plugins/WebNetscapePluginView.mm:
1963         (-[WebNetscapePluginView tellQuickTimeToChill]):
1964
1965 2017-08-29  Andy Estes  <aestes@apple.com>
1966
1967         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
1968         https://bugs.webkit.org/show_bug.cgi?id=176046
1969
1970         Reviewed by Alex Christensen.
1971
1972         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
1973         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
1974
1975         * Misc/WebNSFileManagerExtras.mm:
1976         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1977         (setMetaData): Deleted.
1978         * WebCoreSupport/WebSystemInterface.mm:
1979         (InitWebCoreSystemInterface):
1980
1981 2017-08-28  Andy Estes  <aestes@apple.com>
1982
1983         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
1984         https://bugs.webkit.org/show_bug.cgi?id=176039
1985
1986         Reviewed by Alex Christensen.
1987
1988         * WebCoreSupport/WebSystemInterface.mm:
1989         (InitWebCoreSystemInterface):
1990         * WebView/WebPreferences.mm:
1991         (+[WebPreferences _systemCFStringEncoding]):
1992
1993 2017-08-28  Andy Estes  <aestes@apple.com>
1994
1995         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
1996         https://bugs.webkit.org/show_bug.cgi?id=176032
1997
1998         Reviewed by Alex Christensen.
1999
2000         * WebCoreSupport/WebSystemInterface.mm:
2001         (InitWebCoreSystemInterface):
2002         * WebView/WebView.mm:
2003         (-[WebView _cachedResponseForURL:]):
2004
2005 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2006
2007         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2008         https://bugs.webkit.org/show_bug.cgi?id=175992
2009         <rdar://problem/34086613>
2010
2011         Reviewed by Daniel Bates.
2012
2013         * WebCoreSupport/WebPlatformStrategies.h:
2014         * WebCoreSupport/WebPlatformStrategies.mm:
2015         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2016         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2017         indicating if secure cookies were accessed.
2018
2019 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2020
2021         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2022         https://bugs.webkit.org/show_bug.cgi?id=170955
2023         <rdar://problem/31697653>
2024
2025         Reviewed by Ryosuke Niwa.
2026
2027         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2028         text is being replaced.
2029
2030         * WebView/WebHTMLView.mm:
2031         (-[WebHTMLView insertText:]):
2032
2033 2017-08-24  Chris Dumez  <cdumez@apple.com>
2034
2035         [Directory Upload] Add basic support for input.webkitdirectory
2036         https://bugs.webkit.org/show_bug.cgi?id=175950
2037         <rdar://problem/33951915>
2038
2039         Reviewed by Geoffrey Garen.
2040
2041         Add private API to toggle Directory Upload support on Mac WebKit1.
2042
2043         * WebView/WebPreferenceKeysPrivate.h:
2044         * WebView/WebPreferences.mm:
2045         (+[WebPreferences initialize]):
2046         (-[WebPreferences setDirectoryUploadEnabled:]):
2047         (-[WebPreferences directoryUploadEnabled]):
2048         * WebView/WebPreferencesPrivate.h:
2049         * WebView/WebView.mm:
2050         (-[WebView _preferencesChanged:]):
2051
2052 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2053
2054         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2055         https://bugs.webkit.org/show_bug.cgi?id=175370
2056         <rdar://problem/33799806>
2057
2058         Reviewed by Ryosuke Niwa.
2059
2060         Adjust WebEditorClient for interface changes.
2061
2062         * WebCoreSupport/WebEditorClient.h:
2063
2064 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2065
2066         Remove ChromeClient::scrollbarsModeDidChange
2067         https://bugs.webkit.org/show_bug.cgi?id=175805
2068
2069         Reviewed by Daniel Bates.
2070
2071         * WebCoreSupport/WebChromeClient.h:
2072
2073 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2074
2075         Remove ChromeClient::hasOpenedPopup
2076         https://bugs.webkit.org/show_bug.cgi?id=175804
2077
2078         Reviewed by Sam Weinig.
2079
2080         * WebCoreSupport/WebChromeClient.h:
2081         * WebCoreSupport/WebChromeClient.mm:
2082         (WebChromeClient::hasOpenedPopup const): Deleted.
2083
2084 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2085
2086         Disable access to secure cookies if an HTTPS site loads mixed content
2087         https://bugs.webkit.org/show_bug.cgi?id=157053
2088         <rdar://problem/11290808>
2089
2090         Reviewed by Dan Bates.
2091
2092         * WebCoreSupport/WebPlatformStrategies.h:
2093         * WebCoreSupport/WebPlatformStrategies.mm:
2094         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2095         indicating whether secure cookies should be included in the response.
2096
2097 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2098
2099         [PAL] Move spi/mac directory into PAL
2100         https://bugs.webkit.org/show_bug.cgi?id=175649
2101
2102         Reviewed by Myles C. Maxfield.
2103
2104         * Misc/WebSharingServicePickerController.h:
2105         * WebCoreSupport/WebContextMenuClient.mm:
2106         * WebCoreSupport/WebEditorClient.mm:
2107         * WebCoreSupport/WebSelectionServiceController.mm:
2108         * WebView/WebHTMLView.mm:
2109         * WebView/WebImmediateActionController.h:
2110         * WebView/WebImmediateActionController.mm:
2111         * WebView/WebView.mm:
2112
2113 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2114
2115         [PAL] Relocate SessionID to root
2116         https://bugs.webkit.org/show_bug.cgi?id=175684
2117
2118         Reviewed by Alex Christensen.
2119
2120         * WebCoreSupport/WebFrameNetworkingContext.mm:
2121
2122 2017-08-17  Andreas Kling  <akling@apple.com>
2123
2124         Disable CSS regions at compile time
2125         https://bugs.webkit.org/show_bug.cgi?id=175630
2126
2127         Reviewed by Antti Koivisto.
2128
2129         * Configurations/FeatureDefines.xcconfig:
2130
2131 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2132
2133         [PAL] Move SessionID into PAL
2134         https://bugs.webkit.org/show_bug.cgi?id=174192
2135
2136         Reviewed by Antti Koivisto.
2137
2138         * Misc/WebCache.mm:
2139         (+[WebCache imageForURL:]):
2140         * WebCoreSupport/WebFrameLoaderClient.h:
2141         * WebCoreSupport/WebFrameLoaderClient.mm:
2142         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2143         * WebCoreSupport/WebFrameNetworkingContext.mm:
2144         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2145         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2146         (WebFrameNetworkingContext::storageSession const):
2147         * WebCoreSupport/WebPlatformStrategies.h:
2148         * WebCoreSupport/WebPlatformStrategies.mm:
2149         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2150         * WebKitPrefix.h:
2151
2152 2017-08-16  Andy Estes  <aestes@apple.com>
2153
2154         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2155         https://bugs.webkit.org/show_bug.cgi?id=175648
2156
2157         Reviewed by Tim Horton.
2158
2159         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2160         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2161         (WebPaymentCoordinatorClient::showPaymentUI):
2162
2163 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2164
2165         [PAL] Move spi/ios and spi/win directories into PAL
2166         https://bugs.webkit.org/show_bug.cgi?id=175171
2167
2168         Reviewed by Antti Koivisto.
2169
2170         * WebCoreSupport/WebFrameLoaderClient.mm:
2171         * WebView/WebView.mm:
2172
2173 2017-08-16  Andy Estes  <aestes@apple.com>
2174
2175         [Payment Request] Add an ENABLE flag and an experimental feature preference
2176         https://bugs.webkit.org/show_bug.cgi?id=175622
2177
2178         Reviewed by Tim Horton.
2179
2180         * Configurations/FeatureDefines.xcconfig:
2181
2182 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2183
2184         [PAL] Move Sleep classes into PAL
2185         https://bugs.webkit.org/show_bug.cgi?id=175456
2186
2187         Reviewed by Ryosuke Niwa.
2188
2189         * WebView/WebFullScreenController.h:
2190
2191 2017-08-15  Youenn Fablet  <youenn@apple.com>
2192
2193         [Cache API] Adding generic support for CacheStorage and Cache methods
2194         https://bugs.webkit.org/show_bug.cgi?id=175455
2195
2196         Reviewed by Chris Dumez.
2197
2198         * WebView/WebView.mm:
2199         (-[WebView _commonInitializationWithFrameName:groupName:]):
2200
2201 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2202
2203         Remove Proximity Events and related code
2204         https://bugs.webkit.org/show_bug.cgi?id=175545
2205
2206         Reviewed by Daniel Bates.
2207
2208         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2209         and other related code.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2214
2215         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2216         https://bugs.webkit.org/show_bug.cgi?id=175504
2217
2218         Reviewed by Sam Weinig.
2219
2220         * Configurations/FeatureDefines.xcconfig:
2221         * DOM/DOMHTMLFormElement.mm:
2222         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2223         * WebCoreSupport/WebFrameLoaderClient.h:
2224
2225 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2226
2227         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2228         https://bugs.webkit.org/show_bug.cgi?id=175557
2229
2230         Reviewed by Jon Lee.
2231
2232         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2233
2234         * Configurations/FeatureDefines.xcconfig:
2235
2236 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2237
2238         Composition underline color is always black
2239         https://bugs.webkit.org/show_bug.cgi?id=174675
2240
2241         Reviewed by Ryosuke Niwa.
2242
2243         * WebView/WebHTMLView.mm:
2244         (extractUnderlines): If NSUnderlineColorAttributeName
2245         is not present use text color for composition underline.
2246         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2247         for composition underline in the plain text case.
2248
2249 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2252         https://bugs.webkit.org/show_bug.cgi?id=175474
2253         <rdar://problem/33844628>
2254
2255         Reviewed by Wenson Hsieh.
2256
2257         Replaced the build flag by a runtime flag and disabled the feature by default.
2258
2259         * Configurations/FeatureDefines.xcconfig:
2260         * WebView/WebPreferenceKeysPrivate.h:
2261         * WebView/WebPreferences.mm:
2262         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2263         (-[WebPreferences dataTransferItemsEnabled]): Added.
2264         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2265         * WebView/WebPreferencesPrivate.h:
2266         * WebView/WebView.mm:
2267         (-[WebView _preferencesChanged:]):
2268
2269 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2270
2271         Remove ENABLE_GAMEPAD_DEPRECATED
2272         https://bugs.webkit.org/show_bug.cgi?id=175361
2273
2274         Reviewed by Carlos Garcia Campos.
2275
2276         * Configurations/FeatureDefines.xcconfig:
2277
2278 2017-08-09  Chris Dumez  <cdumez@apple.com>
2279
2280         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2281         https://bugs.webkit.org/show_bug.cgi?id=175401
2282
2283         Reviewed by Brady Eidson.
2284
2285         * WebView/WebPreferenceKeysPrivate.h:
2286         * WebView/WebPreferences.mm:
2287         (+[WebPreferences initialize]):
2288         (-[WebPreferences beaconAPIEnabled]): Deleted.
2289         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2290         * WebView/WebPreferencesPrivate.h:
2291         * WebView/WebView.mm:
2292         (-[WebView _preferencesChanged:]):
2293
2294 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2295
2296         [PAL] Move spi/cocoa and spi/cg directories into PAL
2297         https://bugs.webkit.org/show_bug.cgi?id=175175
2298
2299         Reviewed by Myles C. Maxfield.
2300
2301         * History/WebHistory.mm:
2302         * Misc/WebDownload.mm:
2303         * Misc/WebKitNSStringExtras.mm:
2304         * Plugins/Hosted/NetscapePluginHostManager.mm:
2305         * Plugins/WebPluginDatabase.mm:
2306         * WebCoreSupport/WebFrameLoaderClient.mm:
2307         * WebInspector/WebNodeHighlight.mm:
2308         * WebView/WebHTMLView.mm:
2309         * WebView/WebIndicateLayer.mm:
2310         * WebView/WebView.mm:
2311         * WebView/WebViewData.h:
2312
2313 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2314
2315         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2316         https://bugs.webkit.org/show_bug.cgi?id=175392
2317         <rdar://problem/33783207>
2318
2319         Reviewed by Tim Horton and Megan Gardner.
2320
2321         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2322
2323         * Configurations/FeatureDefines.xcconfig:
2324
2325 2017-08-09  Daniel Bates  <dabates@apple.com>
2326
2327         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2328         https://bugs.webkit.org/show_bug.cgi?id=175247
2329         <rdar://problem/33679804>
2330
2331         Reviewed by Brady Eidson.
2332
2333         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2334         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2335         clients that need to make use of this information at this time. If such a needs comes up
2336         then we can expose API/SPI similar to what we do for WebKit.
2337
2338         * WebCoreSupport/WebFrameLoaderClient.h:
2339         * WebCoreSupport/WebFrameLoaderClient.mm:
2340         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2341
2342 2017-08-08  Brady Eidson  <beidson@apple.com>
2343
2344         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2345         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2346
2347         Reviewed by Andy Estes.
2348
2349         * Misc/WebKitVersionChecks.h:
2350         * WebCoreSupport/WebFrameLoaderClient.mm:
2351         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2352           the app is linked against new WebKit with the new behavior.
2353
2354 2017-08-07  Devin Rousso  <drousso@apple.com>
2355
2356         Web Inspector: Preview Canvas path when viewing a recording
2357         https://bugs.webkit.org/show_bug.cgi?id=174967
2358
2359         Reviewed by Brian Burg.
2360
2361         * WebView/WebPreferenceKeysPrivate.h:
2362         * WebView/WebPreferences.mm:
2363         (+[WebPreferences initialize]):
2364         (-[WebPreferences inspectorAdditionsEnabled]):
2365         (-[WebPreferences setInspectorAdditionsEnabled:]):
2366         * WebView/WebPreferencesPrivate.h:
2367         * WebView/WebView.mm:
2368         (-[WebView _preferencesChanged:]):
2369         Add plumbing for new InspectorAdditions runtime flag.
2370
2371 2017-08-07  Brian Burg  <bburg@apple.com>
2372
2373         Remove CANVAS_PATH compilation guard
2374         https://bugs.webkit.org/show_bug.cgi?id=175207
2375
2376         Reviewed by Sam Weinig.
2377
2378         * Configurations/FeatureDefines.xcconfig:
2379
2380 2017-08-04  Youenn Fablet  <youenn@apple.com>
2381
2382         [Cache API] Add Cache and CacheStorage IDL definitions
2383         https://bugs.webkit.org/show_bug.cgi?id=175201
2384
2385         Reviewed by Brady Eidson.
2386
2387         * WebView/WebPreferenceKeysPrivate.h:
2388         * WebView/WebPreferences.mm:
2389         (+[WebPreferences initialize]):
2390         (-[WebPreferences cacheAPIEnabled]):
2391         (-[WebPreferences setCacheAPIEnabled:]):
2392         * WebView/WebPreferencesPrivate.h:
2393         * WebView/WebView.mm:
2394         (-[WebView _preferencesChanged:]):
2395
2396 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2397
2398         Unreviewed, rolling out r220271.
2399
2400         Rolling out due to Layout Test failing on iOS Simulator.
2401
2402         Reverted changeset:
2403
2404         "Remove STREAMS_API compilation guard"
2405         https://bugs.webkit.org/show_bug.cgi?id=175165
2406         http://trac.webkit.org/changeset/220271
2407
2408 2017-08-04  Youenn Fablet  <youenn@apple.com>
2409
2410         Remove STREAMS_API compilation guard
2411         https://bugs.webkit.org/show_bug.cgi?id=175165
2412
2413         Reviewed by Darin Adler.
2414
2415         * Configurations/FeatureDefines.xcconfig:
2416         * WebView/WebPreferences.mm:
2417         (+[WebPreferences initialize]):
2418         * WebView/WebView.mm:
2419         (-[WebView _preferencesChanged:]):
2420
2421 2017-08-03  Brian Burg  <bburg@apple.com>
2422
2423         Remove ENABLE(WEB_SOCKET) guards
2424         https://bugs.webkit.org/show_bug.cgi?id=167044
2425
2426         Reviewed by Joseph Pecoraro.
2427
2428         * Configurations/FeatureDefines.xcconfig:
2429         * WebView/WebPreferencesPrivate.h:
2430
2431 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2432
2433         [PAL] Move spi/cf directory into PAL
2434         https://bugs.webkit.org/show_bug.cgi?id=175057
2435
2436         Reviewed by Antti Koivisto.
2437
2438         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2439         * Plugins/WebNetscapePluginStream.mm:
2440         * WebCoreSupport/WebFrameNetworkingContext.mm:
2441         * WebView/WebPreferences.mm:
2442         * WebView/WebView.mm:
2443
2444 2017-08-03  Youenn Fablet  <youenn@apple.com>
2445
2446         Remove FETCH_API compilation guard
2447         https://bugs.webkit.org/show_bug.cgi?id=175154
2448
2449         Reviewed by Chris Dumez.
2450
2451         * Configurations/FeatureDefines.xcconfig:
2452         * WebView/WebPreferences.mm:
2453         (+[WebPreferences initialize]):
2454         * WebView/WebView.mm:
2455         (-[WebView _preferencesChanged:]):
2456
2457 2017-08-03  Brady Eidson  <beidson@apple.com>
2458
2459         Add SW IDLs and stub out basic functionality.
2460         https://bugs.webkit.org/show_bug.cgi?id=175115
2461
2462         Reviewed by Chris Dumez.
2463
2464         * Configurations/FeatureDefines.xcconfig:
2465
2466 2017-08-02  Sam Weinig  <sam@webkit.org>
2467
2468         [WebIDL] Convert MutationCallback to be a normal generated callback
2469         https://bugs.webkit.org/show_bug.cgi?id=174140
2470
2471         Reviewed by Darin Adler.
2472
2473         * DOM/DOMDocument.mm:
2474         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2475         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2476         Pass, now necessary, Document to NativeNodeFilter constructor.
2477
2478 2017-08-01  Chris Dumez  <cdumez@apple.com>
2479
2480         Add initial support for navigator.sendBeacon
2481         https://bugs.webkit.org/show_bug.cgi?id=175007
2482         <rdar://problem/33547728>
2483
2484         Reviewed by Sam Weinig.
2485
2486         Add setting to toggle support for the Beacon API (it is disabled by default).
2487
2488         * WebView/WebPreferenceKeysPrivate.h:
2489         * WebView/WebPreferences.mm:
2490         (+[WebPreferences initialize]):
2491         (-[WebPreferences beaconAPIEnabled]):
2492         (-[WebPreferences setBeaconAPIEnabled:]):
2493         * WebView/WebPreferencesPrivate.h:
2494         * WebView/WebView.mm:
2495         (-[WebView _preferencesChanged:]):
2496
2497 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2498
2499         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2500         https://bugs.webkit.org/show_bug.cgi?id=174437
2501
2502         Reviewed by Darin Adler.
2503
2504         Remove redundant Web- prefix from classes in WebKit namespace.
2505
2506         * WebView/WebView.mm:
2507         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2508         * WebView/WebViewData.h:
2509         * WebView/WebViewData.mm:
2510
2511 2017-07-26  Brian Burg  <bburg@apple.com>
2512
2513         Remove WEB_TIMING feature flag
2514         https://bugs.webkit.org/show_bug.cgi?id=174795
2515
2516         Reviewed by Alex Christensen.
2517
2518         * Configurations/FeatureDefines.xcconfig:
2519
2520 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2521
2522         Async image decoding for large images should be disabled after the first time a tile is painted
2523         https://bugs.webkit.org/show_bug.cgi?id=174451
2524         <rdar://problem/31246421>
2525
2526         Reviewed by Simon Fraser.
2527
2528         * WebView/WebFrame.mm:
2529         (-[WebFrame _paintBehaviorForDestinationContext:]):
2530         (-[WebFrame _drawRect:contentsOnly:]):
2531         * WebView/WebHTMLView.mm:
2532         (imageFromRect):
2533
2534 2017-07-23  Darin Adler  <darin@apple.com>
2535
2536         More NeverDestroyed and related cleanup
2537         https://bugs.webkit.org/show_bug.cgi?id=174745
2538
2539         Reviewed by Alex Christensen.
2540
2541         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
2542         for names that aren't even used in this file.
2543         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
2544         -[NSArray arrayWithObject:].
2545         (-[DOMNode absoluteQuads]): Ditto.
2546         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
2547         of writing out various types.
2548         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
2549         syntax instea of -[NSArray arrayWithObject:].
2550         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2551         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2552         of writing out various types.
2553         (-[DOMHTMLImageElement mimeType]): Ditto.
2554
2555 2017-07-24  Chris Dumez  <cdumez@apple.com>
2556
2557         ExceptionCode enumeration should use modern exception names
2558         https://bugs.webkit.org/show_bug.cgi?id=174794
2559
2560         Reviewed by Geoffrey Garen.
2561
2562         * DOM/ExceptionHandlers.mm:
2563         (raiseNotSupportedErrorException):
2564
2565 2017-07-23  Chris Dumez  <cdumez@apple.com>
2566
2567         Drop ExceptionCodeDescription class
2568         https://bugs.webkit.org/show_bug.cgi?id=174757
2569
2570         Reviewed by Darin Adler.
2571
2572         Stop using ExceptionCodeDescription.
2573
2574         * DOM/ExceptionHandlers.mm:
2575         (raiseDOMErrorException):
2576
2577 2017-07-21  Andreas Kling  <akling@apple.com>
2578
2579         Use more references in event dispatch code
2580         https://bugs.webkit.org/show_bug.cgi?id=174681
2581
2582         Reviewed by Geoffrey Garen.
2583
2584         * DOM/ObjCEventListener.h:
2585         * DOM/ObjCEventListener.mm:
2586         (WebCore::ObjCEventListener::handleEvent):
2587         * WebCoreSupport/WebFrameLoaderClient.mm:
2588         (NetscapePluginWidget::handleEvent):
2589
2590 2017-07-21  Brady Eidson  <beidson@apple.com>
2591
2592         Get rid of WebCore IconDatabase code.
2593         https://bugs.webkit.org/show_bug.cgi?id=174700
2594
2595         Reviewed by Tim Horton.
2596
2597         * Misc/WebCoreStatistics.mm:
2598         (+[WebCoreStatistics iconPageURLMappingCount]):
2599         (+[WebCoreStatistics iconRetainedPageURLCount]):
2600         (+[WebCoreStatistics iconRecordCount]):
2601         (+[WebCoreStatistics iconsWithDataCount]):
2602         * WebCoreSupport/WebFrameLoaderClient.h:
2603         * WebCoreSupport/WebFrameLoaderClient.mm:
2604         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2605         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2606         * WebView/WebView.mm:
2607         (-[WebView mainFrameIconURL]):
2608
2609 2017-07-20  Chris Dumez  <cdumez@apple.com>
2610
2611         Drop legacy XPathException type
2612         https://bugs.webkit.org/show_bug.cgi?id=174679
2613
2614         Reviewed by Sam Weinig.
2615
2616         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2617         no longer expose XPathException.
2618
2619         * DOM/ExceptionHandlers.mm:
2620         (raiseDOMErrorException):
2621
2622 2017-07-20  Chris Dumez  <cdumez@apple.com>
2623
2624         Unreviewed, rolling out r219706.
2625
2626         Broke iOS build
2627
2628         Reverted changeset:
2629
2630         "Drop legacy XPathException type"
2631         https://bugs.webkit.org/show_bug.cgi?id=174679
2632         http://trac.webkit.org/changeset/219706
2633
2634 2017-07-20  Chris Dumez  <cdumez@apple.com>
2635
2636         Drop legacy XPathException type
2637         https://bugs.webkit.org/show_bug.cgi?id=174679
2638
2639         Reviewed by Sam Weinig.
2640
2641         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2642         no longer expose XPathException.
2643
2644         * DOM/ExceptionHandlers.mm:
2645         (raiseDOMErrorException):
2646         * WebKit.exp:
2647
2648 2017-07-20  Chris Dumez  <cdumez@apple.com>
2649
2650         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2651         https://bugs.webkit.org/show_bug.cgi?id=174660
2652
2653         Reviewed by Geoffrey Garen.
2654
2655         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2656         This essentially replaces a branch to figure out if the new size is less or greater than the
2657         current size by an assertion.
2658
2659         * Plugins/WebNetscapePluginView.mm:
2660         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2661
2662 2017-07-20  Brady Eidson  <beidson@apple.com>
2663
2664         Deprecate WebIconDatabase in WebKitLegacy/mac.
2665         https://bugs.webkit.org/show_bug.cgi?id=174607
2666
2667         Reviewed by Alex Christensen.
2668
2669         This patch:
2670         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2671         2 - Guts the class to where it can only return the default icon at the small size
2672         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2673             use something else or to not do anything.
2674         
2675         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2676         and that patch will remove all of the last remnants of WebIconDatabase.
2677         
2678         * History/WebHistoryItem.mm:
2679         (-[WebHistoryItem icon]):
2680
2681         * Misc/WebIconDatabase.h:
2682         * Misc/WebIconDatabase.mm:
2683         (-[WebIconDatabase init]):
2684         (-[WebIconDatabase iconForURL:withSize:cache:]):
2685         (-[WebIconDatabase iconForURL:withSize:]):
2686         (-[WebIconDatabase defaultIconWithSize:]):
2687         (-[WebIconDatabase defaultIconForURL:withSize:]):
2688         (-[WebIconDatabase iconURLForURL:]):
2689         (-[WebIconDatabase retainIconForURL:]):
2690         (-[WebIconDatabase releaseIconForURL:]):
2691         (+[WebIconDatabase delayDatabaseCleanup]):
2692         (+[WebIconDatabase allowDatabaseCleanup]):
2693         (-[WebIconDatabase setDelegate:]):
2694         (-[WebIconDatabase delegate]):
2695         (+[WebIconDatabase initialize]): Deleted.
2696         (-[WebIconDatabase isEnabled]): Deleted.
2697         (-[WebIconDatabase setEnabled:]): Deleted.
2698         (-[WebIconDatabase removeAllIcons]): Deleted.
2699         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2700         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2701         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2702         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2703         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2704         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2705         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2706         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2707         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2708         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2709         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2710         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2711         (-[WebIconDatabase _databaseDirectory]): Deleted.
2712         (webGetNSImage): Deleted.
2713
2714         * Misc/WebIconDatabaseDelegate.h: Removed.
2715         * Misc/WebIconDatabaseInternal.h: Removed.
2716         * Misc/WebIconDatabasePrivate.h: Removed.
2717
2718         * WebCoreSupport/WebFrameLoaderClient.mm:
2719         (webGetNSImage):
2720
2721         * WebCoreSupport/WebIconDatabaseClient.mm:
2722         (WebIconDatabaseClient::didRemoveAllIcons):
2723         (WebIconDatabaseClient::didImportIconURLForPageURL):
2724
2725         * WebView/WebView.mm:
2726         (-[WebView setFrameLoadDelegate:]):
2727         (-[WebView mainFrameIcon]):
2728
2729 2017-07-18  Andy Estes  <aestes@apple.com>
2730
2731         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2732         https://bugs.webkit.org/show_bug.cgi?id=174631
2733
2734         Reviewed by Tim Horton.
2735
2736         * Configurations/Base.xcconfig:
2737
2738 2017-07-18  Andy Estes  <aestes@apple.com>
2739
2740         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2741         https://bugs.webkit.org/show_bug.cgi?id=174631
2742
2743         Reviewed by Sam Weinig.
2744
2745         * Configurations/Base.xcconfig:
2746
2747 2017-07-18  Andy Estes  <aestes@apple.com>
2748
2749         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2750         https://bugs.webkit.org/show_bug.cgi?id=174631
2751
2752         Reviewed by Dan Bernstein.
2753
2754         * Configurations/Base.xcconfig:
2755
2756 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2757
2758         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2759         https://bugs.webkit.org/show_bug.cgi?id=174640
2760         <rdar://problem/33297400>
2761
2762         Reviewed by Tim Horton.
2763
2764         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2765         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2766         web thread here, to match the other WebView drag and drop SPI methods.
2767
2768         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2769         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2770         should make this robust against future UIKit changes that could make this no longer the case.
2771
2772         * WebView/WebView.mm:
2773         (-[WebView _requestStartDataInteraction:globalPosition:]):
2774         (-[WebView _dataInteractionCaretRect]):
2775
2776 2017-07-18  Andy Estes  <aestes@apple.com>
2777
2778         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2779         https://bugs.webkit.org/show_bug.cgi?id=174631
2780
2781         Reviewed by Darin Adler.
2782
2783         * Configurations/Base.xcconfig:
2784
2785 2017-07-17  Sam Weinig  <sam@webkit.org>
2786
2787         [WebIDL] Remove custom bindings that require non-caching JS strings
2788         https://bugs.webkit.org/show_bug.cgi?id=174552
2789
2790         Reviewed by Darin Adler.
2791
2792         * DOM/DOMHTMLCanvasElement.mm:
2793         (-[DOMHTMLCanvasElement toDataURL:]):
2794         Update to account for implementation now returning an UncachedString.
2795
2796 2017-07-17  Darin Adler  <darin@apple.com>
2797
2798         Improve use of NeverDestroyed
2799         https://bugs.webkit.org/show_bug.cgi?id=174348
2800
2801         Reviewed by Sam Weinig.
2802
2803         * Misc/WebStringTruncator.mm:
2804         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2805         NeverDestroyed<RetainPtr> with just an NSFont * global.
2806
2807         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2808         NeverDestroyed.h.
2809         * Storage/WebDatabaseManager.mm: Ditto.
2810         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2811         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2812
2813         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2814         (aeDescFromJSValue): Removed double hashing by using the return value from
2815         add rather than calling contains before calling add.
2816
2817 2017-07-14  Jer Noble  <jer.noble@apple.com>
2818
2819         Allow clients to override their own hardware media requirements where no fallback media exists.
2820         https://bugs.webkit.org/show_bug.cgi?id=174426
2821         <rdar://problem/32537704>
2822
2823         Reviewed by Eric Carlson.
2824
2825         Add a new WebPreferences property to control WebCore's new
2826         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2827
2828         * WebView/WebPreferenceKeysPrivate.h:
2829         * WebView/WebPreferences.mm:
2830         (+[WebPreferences initialize]):
2831         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2832         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2833         * WebView/WebPreferencesPrivate.h:
2834         * WebView/WebView.mm:
2835         (-[WebView _preferencesChanged:]):
2836
2837 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2838
2839         Async image decoding for large images should be disabled by default
2840         https://bugs.webkit.org/show_bug.cgi?id=174432
2841
2842         Reviewed by Simon Fraser.
2843
2844         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2845         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2846         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2847            a child view instead of propagating PaintBehaviorSnapshotting.
2848         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2849            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2850
2851         * WebView/WebFrame.mm:
2852         (-[WebFrame _paintBehaviorForDestinationContext:]):
2853         (-[WebFrame _drawRect:contentsOnly:]):
2854         * WebView/WebHTMLView.mm:
2855         (imageFromRect):
2856
2857 2017-07-12  Daniel Bates  <dabates@apple.com>
2858
2859         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2860         https://bugs.webkit.org/show_bug.cgi?id=174427
2861
2862         Rubber-stamped by Brady Eidson.
2863
2864         * WebView/WebPDFView.mm:
2865         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2866
2867 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2868
2869         Unreviewed, rolling out r219401.
2870
2871         This revision rolled out the previous patch, but after talking
2872         with reviewer, a rebaseline is what was needed.Rolling back in
2873         before rebaseline.
2874
2875         Reverted changeset:
2876
2877         "Unreviewed, rolling out r219379."
2878         https://bugs.webkit.org/show_bug.cgi?id=174400
2879         http://trac.webkit.org/changeset/219401
2880
2881 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2882
2883         Unreviewed, rolling out r219379.
2884
2885         This revision caused a consistent failure in the test
2886         fast/dom/Window/property-access-on-cached-window-after-frame-
2887         removed.html.
2888
2889         Reverted changeset:
2890
2891         "Remove NAVIGATOR_HWCONCURRENCY"
2892         https://bugs.webkit.org/show_bug.cgi?id=174400
2893         http://trac.webkit.org/changeset/219379
2894
2895 2017-07-11  Dean Jackson  <dino@apple.com>
2896
2897         Remove NAVIGATOR_HWCONCURRENCY
2898         https://bugs.webkit.org/show_bug.cgi?id=174400
2899
2900         * Configurations/FeatureDefines.xcconfig:
2901
2902 2017-07-11  Dean Jackson  <dino@apple.com>
2903
2904         Rolling out r219372.
2905
2906         * Configurations/FeatureDefines.xcconfig:
2907
2908 2017-07-11  Dean Jackson  <dino@apple.com>
2909
2910         Remove NAVIGATOR_HWCONCURRENCY
2911         https://bugs.webkit.org/show_bug.cgi?id=174400
2912
2913         * Configurations/FeatureDefines.xcconfig:
2914
2915 2017-07-03  Brian Burg  <bburg@apple.com>
2916
2917         Web Replay: remove some unused code
2918         https://bugs.webkit.org/show_bug.cgi?id=173903
2919
2920         Rubber-stamped by Joseph Pecoraro.
2921
2922         * Configurations/FeatureDefines.xcconfig:
2923
2924 2017-07-09  Brady Eidson  <beidson@apple.com>
2925
2926         Remove some obsolete WebKitVersionChecks.
2927         https://bugs.webkit.org/show_bug.cgi?id=174294
2928
2929         Reviewed by Dan Bernstein.
2930
2931         * Misc/WebKitVersionChecks.h:
2932
2933         * WebView/WebHTMLView.mm:
2934         (-[WebHTMLView hitTest:]):
2935
2936         * WebView/WebView.mm:
2937         (shouldRespectPriorityInCSSAttributeSetters):
2938         (-[WebView _commonInitializationWithFrameName:groupName:]):
2939         (-[WebView _preferencesChanged:]):
2940         (shouldTransformsAffectOverflow): Deleted.
2941         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2942
2943 2017-07-08  Brady Eidson  <beidson@apple.com>
2944
2945         Remove some obsolete RuntimeApplicationChecks.
2946         https://bugs.webkit.org/show_bug.cgi?id=174293
2947
2948         Reviewed by Dan Bernstein.
2949
2950         * Misc/WebKitVersionChecks.h:
2951         * WebView/WebView.mm:
2952         (+[WebView enableWebThread]):
2953         (-[WebView _needsPreHTML5ParserQuirks]):
2954
2955 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2956
2957         Drop NOSNIFF compile flag
2958         https://bugs.webkit.org/show_bug.cgi?id=174289
2959
2960         Reviewed by Michael Catanzaro.
2961
2962         * Configurations/FeatureDefines.xcconfig:
2963
2964 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2965
2966         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2967         https://bugs.webkit.org/show_bug.cgi?id=174150
2968
2969         Reviewed by Mark Lam.
2970
2971         * DOM/DOM.mm:
2972         (lookupElementClass):
2973
2974 2017-07-06  Brady Eidson  <beidson@apple.com>
2975
2976         Add logging to first attempt to use the WebIconDatabase class.
2977         https://bugs.webkit.org/show_bug.cgi?id=174190
2978
2979         Reviewed by Andy Estes.
2980
2981         * Misc/WebIconDatabase.mm:
2982         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
2983         * Misc/WebKitVersionChecks.h:
2984
2985 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2986
2987         Unreviewed, rolling out r219178.
2988
2989         This caused a consistent failure with the API test
2990         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2991
2992         Reverted changeset:
2993
2994         "[WTF] Clean up StringStatics.cpp by using
2995         LazyNeverDestroyed<> for Atoms"
2996         https://bugs.webkit.org/show_bug.cgi?id=174150
2997         http://trac.webkit.org/changeset/219178
2998
2999 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3000
3001         [WTF] Move SoftLinking.h into WTF
3002         https://bugs.webkit.org/show_bug.cgi?id=174000
3003
3004         Reviewed by Alex Christensen.
3005
3006         * Plugins/WebNetscapePluginView.mm:
3007         * Plugins/WebPluginController.mm:
3008         * WebCoreSupport/WebInspectorClient.mm:
3009         * WebView/WebFullScreenController.mm:
3010         * WebView/WebImmediateActionController.mm:
3011         * WebView/WebView.mm:
3012
3013 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3014
3015         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3016         https://bugs.webkit.org/show_bug.cgi?id=174150
3017
3018         Reviewed by Mark Lam.
3019
3020         * DOM/DOM.mm:
3021         (lookupElementClass):
3022
3023 2017-07-05  Brady Eidson  <beidson@apple.com>
3024
3025         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3026         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3027
3028         Reviewed by Alex Christensen.
3029
3030         Adopt to the new constructor for FrameLoadRequest.
3031
3032         * WebView/WebPDFView.mm:
3033         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3034
3035 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3036
3037         Make WebKit's public headers on Mac and iOS C++ module safe
3038         https://bugs.webkit.org/show_bug.cgi?id=174175
3039
3040         Reviewed by Alex Christensen.
3041
3042         Fixed the header files.
3043
3044         * Misc/WebDownload.h:
3045         * Misc/WebKitErrors.h:
3046         * Plugins/WebPluginContainer.h:
3047         * WebView/WebResourceLoadDelegate.h:
3048
3049 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3050
3051         Remove copy of ICU headers from WebKit
3052         https://bugs.webkit.org/show_bug.cgi?id=116407
3053
3054         Reviewed by Alex Christensen.
3055
3056         Use WTF's copy of ICU headers.
3057
3058         * Configurations/WebKitLegacy.xcconfig:
3059         * icu/unicode/localpointer.h: Removed.
3060         * icu/unicode/parseerr.h: Removed.
3061         * icu/unicode/platform.h: Removed.
3062         * icu/unicode/ptypes.h: Removed.
3063         * icu/unicode/putil.h: Removed.
3064         * icu/unicode/uchar.h: Removed.
3065         * icu/unicode/uconfig.h: Removed.
3066         * icu/unicode/ucurr.h: Removed.
3067         * icu/unicode/uidna.h: Removed.
3068         * icu/unicode/uiter.h: Removed.
3069         * icu/unicode/umachine.h: Removed.
3070         * icu/unicode/unorm.h: Removed.
3071         * icu/unicode/unorm2.h: Removed.
3072         * icu/unicode/urename.h: Removed.
3073         * icu/unicode/uscript.h: Removed.
3074         * icu/unicode/ustring.h: Removed.
3075         * icu/unicode/utf.h: Removed.
3076         * icu/unicode/utf16.h: Removed.
3077         * icu/unicode/utf8.h: Removed.
3078         * icu/unicode/utf_old.h: Removed.
3079         * icu/unicode/utypes.h: Removed.
3080         * icu/unicode/uvernum.h: Removed.
3081         * icu/unicode/uversion.h: Removed.
3082
3083 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3084
3085         Add WebKitPrivateFrameworkStubs for iOS 11
3086         https://bugs.webkit.org/show_bug.cgi?id=173988
3087
3088         Reviewed by David Kilzer.
3089
3090         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3091         use the same directory for private framework stubs.
3092
3093 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3094
3095         Unreviewed, rolling out r219103.
3096
3097         Caused multiple build failures.
3098
3099         Reverted changeset:
3100
3101         "Remove copy of ICU headers from WebKit"
3102         https://bugs.webkit.org/show_bug.cgi?id=116407
3103         http://trac.webkit.org/changeset/219103
3104
3105 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3106
3107         Remove copy of ICU headers from WebKit
3108         https://bugs.webkit.org/show_bug.cgi?id=116407
3109
3110         Reviewed by Alex Christensen.
3111
3112         Use WTF's copy of ICU headers.
3113
3114         * Configurations/WebKitLegacy.xcconfig:
3115         * icu/unicode/localpointer.h: Removed.
3116         * icu/unicode/parseerr.h: Removed.
3117         * icu/unicode/platform.h: Removed.
3118         * icu/unicode/ptypes.h: Removed.
3119         * icu/unicode/putil.h: Removed.
3120         * icu/unicode/uchar.h: Removed.
3121         * icu/unicode/uconfig.h: Removed.
3122         * icu/unicode/ucurr.h: Removed.
3123         * icu/unicode/uidna.h: Removed.
3124         * icu/unicode/uiter.h: Removed.
3125         * icu/unicode/umachine.h: Removed.
3126         * icu/unicode/unorm.h: Removed.
3127         * icu/unicode/unorm2.h: Removed.
3128         * icu/unicode/urename.h: Removed.
3129         * icu/unicode/uscript.h: Removed.
3130         * icu/unicode/ustring.h: Removed.
3131         * icu/unicode/utf.h: Removed.
3132         * icu/unicode/utf16.h: Removed.
3133         * icu/unicode/utf8.h: Removed.
3134         * icu/unicode/utf_old.h: Removed.
3135         * icu/unicode/utypes.h: Removed.
3136         * icu/unicode/uvernum.h: Removed.
3137         * icu/unicode/uversion.h: Removed.
3138
3139 2017-07-03  Brady Eidson  <beidson@apple.com>
3140
3141         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3142         https://bugs.webkit.org/show_bug.cgi?id=174073
3143
3144         Reviewed by Andy Estes.
3145
3146         WebView now keeps a direct copy of its main frame icon as a member variable.
3147         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3148         
3149         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3150         have both the old icon and new icon at the time it changes.
3151
3152         * WebCoreSupport/WebFrameLoaderClient.h:
3153         * WebCoreSupport/WebFrameLoaderClient.mm:
3154         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3155         (WebFrameLoaderClient::getLoadDecisionForIcons):
3156         (WebFrameLoaderClient::finishedLoadingIcon):
3157         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3158         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3159
3160         * WebView/WebView.mm:
3161         (+[WebView _setIconLoadingEnabled:]):
3162         (+[WebView _isIconLoadingEnabled]):
3163         (-[WebView mainFrameIcon]):
3164         (-[WebView _setMainFrameIcon:]):
3165         (-[WebView _receivedIconChangedNotification:]): Deleted.
3166         (-[WebView _registerForIconNotification:]): Deleted.
3167         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3168         * WebView/WebViewData.h:
3169         * WebView/WebViewInternal.h:
3170         * WebView/WebViewPrivate.h:
3171
3172 2017-07-03  Sam Weinig  <sam@webkit.org>
3173
3174         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3175         https://bugs.webkit.org/show_bug.cgi?id=174083
3176
3177         Reviewed by Alex Christensen.
3178
3179         * Configurations/FeatureDefines.xcconfig:
3180         Add ENABLE_NAVIGATOR_STANDALONE.
3181
3182 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3183
3184         Expose unobscuredSafeAreaInsets on WebView
3185         https://bugs.webkit.org/show_bug.cgi?id=174075
3186         <rdar://problem/33096997>
3187
3188         Reviewed by Beth Dakin.
3189
3190         * WebView/WebView.mm:
3191         (-[WebView _setUnobscuredSafeAreaInsets:]):
3192         (-[WebView _unobscuredSafeAreaInsets]):
3193         * WebView/WebViewPrivate.h:
3194         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3195         similar to how it is exposed in WebKit2.
3196
3197 2017-07-03  Andy Estes  <aestes@apple.com>
3198
3199         [Xcode] Add an experimental setting to build with ccache
3200         https://bugs.webkit.org/show_bug.cgi?id=173875
3201
3202         Reviewed by Tim Horton.
3203
3204         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3205
3206 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3207
3208         Expose WebPreferences for viewport-fit and constant() properties
3209         https://bugs.webkit.org/show_bug.cgi?id=174072
3210         <rdar://problem/33096639>
3211
3212         Reviewed by Ryosuke Niwa.
3213
3214         * WebView/WebPreferenceKeysPrivate.h:
3215         * WebView/WebPreferences.mm:
3216         (-[WebPreferences viewportFitEnabled]):
3217         (-[WebPreferences setViewportFitEnabled:]):
3218         (-[WebPreferences constantPropertiesEnabled]):
3219         (-[WebPreferences setConstantPropertiesEnabled:]):
3220         * WebView/WebPreferencesPrivate.h:
3221         * WebView/WebView.mm:
3222         (-[WebView _preferencesChanged:]):
3223
3224 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3225
3226         Expose viewport-fit value to UIKit via viewport arguments dictionary
3227         https://bugs.webkit.org/show_bug.cgi?id=174071
3228         <rdar://problem/33096620>
3229
3230         Reviewed by Wenson Hsieh.
3231
3232         * History/WebHistoryItem.mm:
3233         * History/WebHistoryItemPrivate.h:
3234         Add another dictionary key and three values.
3235
3236 2017-07-01  Dan Bernstein  <mitz@apple.com>
3237
3238         [iOS] Remove code only needed when building for iOS 9.x
3239         https://bugs.webkit.org/show_bug.cgi?id=174068
3240
3241         Reviewed by Tim Horton.
3242
3243         * Configurations/FeatureDefines.xcconfig:
3244
3245 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3246
3247         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3248         https://bugs.webkit.org/show_bug.cgi?id=174004
3249
3250         Reviewed by Simon Fraser.
3251
3252         * WebCoreSupport/WebPluginInfoProvider.mm:
3253
3254 2017-07-01  Dan Bernstein  <mitz@apple.com>
3255
3256         [macOS] Remove code only needed when building for OS X Yosemite
3257         https://bugs.webkit.org/show_bug.cgi?id=174067
3258
3259         Reviewed by Tim Horton.
3260
3261         * Configurations/Base.xcconfig:
3262         * Configurations/DebugRelease.xcconfig:
3263         * Configurations/FeatureDefines.xcconfig:
3264         * Configurations/Version.xcconfig:
3265         * Plugins/WebBasePluginPackage.mm:
3266         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3267         * WebCoreSupport/PopupMenuMac.mm:
3268         (PopupMenuMac::show):
3269         * WebCoreSupport/WebInspectorClient.mm:
3270         (WebInspectorFrontendClient::startWindowDrag):
3271         (-[WebInspectorWindowController window]):
3272         * WebView/WebView.mm:
3273         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3274
3275 2017-06-30  Daniel Bates  <dabates@apple.com>
3276
3277         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3278         https://bugs.webkit.org/show_bug.cgi?id=165160
3279         <rdar://problem/29451999>
3280
3281         Reviewed by Brady Eidson.
3282
3283         Pass the document that is requesting the load to the loader.
3284
3285         * WebView/WebPDFView.mm:
3286         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3287
3288 2017-06-29  Jer Noble  <jer.noble@apple.com>
3289
3290         Make Legacy EME API controlled by RuntimeEnabled setting.
3291         https://bugs.webkit.org/show_bug.cgi?id=173994
3292
3293         Reviewed by Sam Weinig.
3294
3295         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3296
3297         * Configurations/FeatureDefines.xcconfig:
3298         * WebView/WebPreferenceKeysPrivate.h:
3299         * WebView/WebPreferences.mm:
3300         (+[WebPreferences initialize]):
3301         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3302         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3303         * WebView/WebPreferencesPrivate.h:
3304         * WebView/WebView.mm:
3305         (-[WebView _preferencesChanged:]):
3306
3307 2017-06-30  Chris Dumez  <cdumez@apple.com>
3308
3309         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3310         https://bugs.webkit.org/show_bug.cgi?id=174013
3311
3312         Reviewed by Brent Fulgham.
3313
3314         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3315         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3316
3317         * WebView/WebView.mm:
3318         (-[WebView _commonInitializationWithFrameName:groupName:]):
3319
3320 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3323         https://bugs.webkit.org/show_bug.cgi?id=174017
3324         <rdar://problem/32959782>
3325
3326         Reviewed by Simon Fraser.
3327
3328         Use root view coordinates when computing the drag caret rect.
3329
3330         * WebView/WebView.mm:
3331         (-[WebView _dataInteractionCaretRect]):
3332
3333 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3334
3335         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3336         https://bugs.webkit.org/show_bug.cgi?id=173899
3337         rdar://problem/32994474
3338
3339         Reviewed by Tim Horton.
3340
3341         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3342         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3343         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3344
3345         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3346         documentView is a WebHTMLView.
3347
3348         * WebView/WebFrame.mm:
3349         (-[WebFrame _webHTMLDocumentView]):
3350         (-[WebFrame _paintBehaviorForDestinationContext:]):
3351         (-[WebFrame _drawRect:contentsOnly:]):
3352         (-[WebFrame setTimeoutsPaused:]):
3353         (-[WebFrame prepareForPause]):
3354         (-[WebFrame resumeFromPause]):
3355         (-[WebFrame resetTextAutosizingBeforeLayout]):
3356         * WebView/WebHTMLView.mm:
3357         (-[WebHTMLView drawLayer:inContext:]):
3358         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3359         * WebView/WebHTMLViewInternal.h:
3360
3361 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3362
3363         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3364         https://bugs.webkit.org/show_bug.cgi?id=173854
3365         <rdar://problem/32236827>
3366
3367         Reviewed by Ryosuke Niwa and Tim Horton.
3368
3369         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3370         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3371
3372         * WebView/WebView.mm:
3373         (-[WebView _startDrag:]):
3374         (-[WebView _dragSourceAction]):
3375         (-[WebView _draggedLinkTitle]):
3376         (-[WebView _draggedLinkURL]):
3377         (-[WebView _draggedElementBounds]):
3378         (-[WebView _endedDataInteraction:global:]):
3379         * WebView/WebViewData.h:
3380         * WebView/WebViewPrivate.h:
3381
3382 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3383
3384         Refactor drag start codepaths to plumb a DragItem to client layers
3385         https://bugs.webkit.org/show_bug.cgi?id=173832
3386         Work towards <rdar://problem/32236827>
3387
3388         Reviewed by Ryosuke Niwa and Tim Horton.
3389
3390         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3391         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3392         to _startDrag: to match logic used to start a drag on other platforms.
3393
3394         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3395         through the DragItem struct.
3396
3397         * WebCoreSupport/WebDragClient.h:
3398         * WebCoreSupport/WebDragClient.mm:
3399         (WebDragClient::startDrag):
3400         (WebDragClient::dragSourceActionMaskForPoint):
3401         (WebDragClient::willPerformDragSourceAction):
3402         (WebDragClient::beginDrag):
3403         * WebView/WebView.mm:
3404         (-[WebView _startDrag:]):
3405         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3406         * WebView/WebViewInternal.h:
3407
3408 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3409
3410         Remove excessive headers from JavaScriptCore
3411         https://bugs.webkit.org/show_bug.cgi?id=173812
3412
3413         Reviewed by Darin Adler.
3414
3415         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3416         * WebView/WebView.mm:
3417
3418 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3419
3420         Remove an unused typedef from WebFrameLoaderClient
3421         https://bugs.webkit.org/show_bug.cgi?id=173795
3422
3423         Reviewed by Simon Fraser.
3424
3425         * WebCoreSupport/WebFrameLoaderClient.h:
3426         This unused typedef in the global namespace conflicts with one in a macOS system header.
3427         Also... it's unused.
3428         Remove it.
3429
3430 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3431
3432         Remove excessive headers from WebCore/{bindings,css,dom}
3433         https://bugs.webkit.org/show_bug.cgi?id=173766
3434
3435         Reviewed by Simon Fraser.
3436
3437         * DOM/DOMInternal.mm:
3438
3439 2017-06-22  Daniel Bates  <dabates@apple.com>
3440
3441         Make FrameLoadRequest a move-only type
3442         https://bugs.webkit.org/show_bug.cgi?id=173682
3443
3444         Reviewed by Alex Christensen and Darin Adler.
3445
3446         A FrameLoadRequest groups together the information to perform a load into a single object
3447         that is more manageable to pass around than its constituent parts. Code that receives a
3448         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3449         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3450         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3451
3452         * Plugins/WebPluginController.mm:
3453         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3454         * WebView/WebPDFView.mm:
3455         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3456
3457 2017-06-21  Antoine Quint  <graouts@apple.com>
3458
3459         Ensure DRT always logs rAF suspension debugging code
3460         https://bugs.webkit.org/show_bug.cgi?id=173681
3461
3462         Reviewed by Tim "Mr. T" Horton.
3463
3464         * WebView/WebPreferenceKeysPrivate.h:
3465         * WebView/WebPreferences.mm:
3466         (+[WebPreferences initialize]):
3467         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3468         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3469         * WebView/WebPreferencesPrivate.h:
3470         * WebView/WebView.mm:
3471         (-[WebView _preferencesChanged:]):
3472
3473 2017-06-21  Daniel Bates  <dabates@apple.com>
3474
3475         Cleanup FrameLoadRequest
3476         https://bugs.webkit.org/show_bug.cgi?id=173564
3477         <rdar://problem/32903570>
3478
3479         Reviewed by Brent Fulgham.
3480
3481         * WebView/WebPDFView.mm:
3482         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
3483         into a local variable and use C++11 brace initialization syntax to make it easier to identify
3484         the arguments passed to FrameLoader::loadFrameRequest().
3485
3486 2017-06-21  Antoine Quint  <graouts@apple.com>
3487
3488         Add logging to identify when the Page suspends scripted animations
3489         https://bugs.webkit.org/show_bug.cgi?id=173626
3490
3491         Reviewed by Tim Horton.
3492
3493         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
3494         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
3495
3496         * WebView/WebPreferenceKeysPrivate.h:
3497         * WebView/WebPreferences.mm:
3498         (+[WebPreferences initialize]):
3499         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
3500         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
3501         * WebView/WebPreferencesPrivate.h:
3502         * WebView/WebView.mm:
3503         (-[WebView _preferencesChanged:]):
3504
3505 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3506
3507         Disable font variations on macOS Sierra and iOS 10
3508         https://bugs.webkit.org/show_bug.cgi?id=173618
3509         <rdar://problem/32879164>
3510
3511         Reviewed by Jon Lee.
3512
3513         * Configurations/FeatureDefines.xcconfig:
3514
3515 2017-06-20  Daniel Bates  <dabates@apple.com>
3516
3517         Have FrameLoadRequest takes a Frame& instead of a Frame*
3518         https://bugs.webkit.org/show_bug.cgi?id=173614
3519         <rdar://problem/32884890>
3520
3521         Reviewed by Brent Fulgham.
3522
3523         * Plugins/WebPluginController.mm:
3524         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3525         * WebView/WebFrame.mm:
3526         (-[WebFrame loadRequest:]):
3527         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3528
3529 2017-06-19  Frederic Wang  <fwang@igalia.com>
3530
3531         [Mac] Add an experimental feature setting for async frame scrolling
3532         https://bugs.webkit.org/show_bug.cgi?id=173359
3533
3534         Reviewed by Simon Fraser.
3535
3536         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
3537         * WebView/WebPreferences.mm:
3538         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
3539         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
3540         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
3541         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
3542         * WebView/WebView.mm:
3543         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
3544         scrolling.
3545
3546 2017-06-19  Chris Dumez  <cdumez@apple.com>
3547
3548         Use WTF::Function instead of std::function in more places in WebCore/
3549         https://bugs.webkit.org/show_bug.cgi?id=173535
3550
3551         Reviewed by Antti Koivisto.
3552
3553         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3554
3555         * WebCoreSupport/WebFrameLoaderClient.h:
3556         * WebCoreSupport/WebFrameLoaderClient.mm:
3557         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3558         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3559         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3560         (WebFrameLoaderClient::dispatchWillSubmitForm):
3561         (WebFrameLoaderClient::setUpPolicyListener):
3562         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
3563         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
3564
3565 2017-05-14 Frederic Wang  <fwang@igalia.com>
3566
3567         Add heuristic to avoid flattening "fullscreen" iframes
3568         https://bugs.webkit.org/show_bug.cgi?id=171914
3569
3570         Reviewed by Simon Fraser.
3571
3572         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
3573
3574         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
3575         * WebView/WebPreferences.mm:
3576         (+[WebPreferences initialize]): Handle frame flattening as an enum.
3577         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
3578         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
3579         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
3580         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
3581         * WebView/WebPreferencesPrivate.h: Ditto.
3582         * WebView/WebView.mm:
3583         (-[WebView _preferencesChanged:]): Ditto.
3584         * WebView/WebPreferencesPrivate.h: Add new enum definition.
3585
3586 2017-06-17  Chris Dumez  <cdumez@apple.com>
3587
3588         Use WTF::Function instead of std::function in WebKit2/
3589         https://bugs.webkit.org/show_bug.cgi?id=173504
3590
3591         Reviewed by Darin Adler.
3592
3593         Use WTF::Function instead of std::function in WebKit2/ to avoid
3594         unnecessary copying.
3595
3596         * Plugins/Hosted/HostedNetscapePluginStream.h:
3597         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3598         (WebKit::HostedNetscapePluginStream::willSendRequest):
3599         * Plugins/WebNetscapePluginStream.h:
3600         * Plugins/WebNetscapePluginStream.mm:
3601         (WebNetscapePluginStream::willSendRequest):
3602         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3603         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3604         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3605         (WebPaymentCoordinatorClient::openPaymentSetup):
3606
3607 2017-06-16  Sam Weinig  <sam@webkit.org>
3608
3609         [WebIDL] Remove custom bindings for HTMLDocument
3610         https://bugs.webkit.org/show_bug.cgi?id=173444
3611
3612         Reviewed by Darin Adler.
3613
3614         * DOM/DOMHTMLDocument.mm:
3615         (-[DOMHTMLDocument linkColor]):
3616         (-[DOMHTMLDocument setLinkColor:]):
3617         (-[DOMHTMLDocument write:]):
3618         (-[DOMHTMLDocument writeln:]):
3619         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3620
3621 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3622
3623         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3624         https://bugs.webkit.org/show_bug.cgi?id=173366
3625         <rdar://problem/32767014>
3626
3627         Reviewed by Tim Horton.
3628
3629         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3630
3631         * Configurations/FeatureDefines.xcconfig:
3632         * WebCoreSupport/WebDragClient.mm:
3633         (WebDragClient::useLegacyDragClient):
3634         (WebDragClient::willPerformDragDestinationAction):
3635         (WebDragClient::dragSourceActionMaskForPoint):
3636         (WebDragClient::willPerformDragSourceAction):
3637         (WebDragClient::startDrag):
3638         (WebDragClient::beginDrag):
3639         (WebDragClient::declareAndWriteDragImage):
3640         (WebDragClient::declareAndWriteAttachment):
3641         (WebDragClient::didConcludeEditDrag):
3642         * WebView/WebView.mm:
3643         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3644         (-[WebView _getDataInteractionData]):
3645         (-[WebView dragDataForSession:client:global:operation:]):
3646         (-[WebView _enteredDataInteraction:client:global:operation:]):
3647         (-[WebView _updatedDataInteraction:client:global:operation:]):
3648         (-[WebView _exitedDataInteraction:client:global:operation:]):
3649         (-[WebView _performDataInteraction:client:global:operation:]):
3650         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3651         (-[WebView _endedDataInteraction:global:]):
3652         (-[WebView _didConcludeEditDataInteraction]):
3653         (floatRectsForCGRectArray): Deleted.
3654         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3655         * WebView/WebViewData.h:
3656         * WebView/WebViewData.mm:
3657         (-[WebViewPrivate dealloc]):
3658         * WebView/WebViewPrivate.h:
3659
3660 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3661
3662         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3663         https://bugs.webkit.org/show_bug.cgi?id=173454
3664         <rdar://problem/31720671>
3665
3666         Reviewed by Tim Horton.
3667
3668         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3669         If unimplemented, the default UI delegate allows all actions except for URL loading.
3670
3671         * DefaultDelegates/WebDefaultUIDelegate.mm:
3672         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3673         * WebView/WebUIDelegatePrivate.h:
3674         * WebView/WebView.mm:
3675         (-[WebView dragDestinationActionMaskForSession:]):
3676
3677 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3678
3679         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3680         https://bugs.webkit.org/show_bug.cgi?id=173338
3681         <rdar://problem/32777720>
3682
3683         Reviewed by Tim Horton.
3684
3685         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3686
3687         * WebCoreSupport/WebPlatformStrategies.h:
3688         * WebCoreSupport/WebPlatformStrategies.mm:
3689         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3690         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3691
3692 2017-06-13  Daniel Bates  <dabates@apple.com>
3693
3694         Implement W3C Secure Contexts Draft Specification
3695         https://bugs.webkit.org/show_bug.cgi?id=158121
3696         <rdar://problem/26012994>
3697
3698         Reviewed by Brent Fulgham.
3699
3700         Part 4
3701
3702         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3703
3704         * WebView/WebPreferenceKeysPrivate.h:
3705         * WebView/WebPreferences.mm:
3706         (+[WebPreferences initialize]):
3707         (-[WebPreferences isSecureContextAttributeEnabled]):
3708         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3709         * WebView/WebPreferencesPrivate.h:
3710         * WebView/WebView.mm:
3711         (-[WebView _preferencesChanged:]):
3712
3713 2017-06-13  Sam Weinig  <sam@webkit.org>
3714
3715         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3716         https://bugs.webkit.org/show_bug.cgi?id=80733
3717
3718         Reviewed by Chris Dumez.
3719
3720         * DOM/DOMUtility.mm:
3721         (createDOMWrapper):
3722         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3723         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3724         * WebView/WebFrame.mm:
3725         (-[WebFrame _attachScriptDebugger]):
3726         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3727
3728 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3729
3730         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3731         https://bugs.webkit.org/show_bug.cgi?id=173197
3732         <rdar://problem/32688148>
3733
3734         Reviewed by Brent Fulgham.
3735
3736         * WebView/WebPreferences.mm:
3737         (+[WebPreferences initialize]):
3738         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3739         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3740         * WebView/WebPreferencesPrivate.h:
3741         * WebView/WebView.mm:
3742         (-[WebView _preferencesChanged:]):
3743
3744 2017-06-10  Dan Bernstein  <mitz@apple.com>
3745
3746         Reverted r218056 because it made the IDE reindex constantly.
3747
3748         * Configurations/DebugRelease.xcconfig:
3749
3750 2017-06-10  Dan Bernstein  <mitz@apple.com>
3751
3752         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3753         https://bugs.webkit.org/show_bug.cgi?id=173223
3754
3755         Reviewed by Sam Weinig.
3756
3757         The rebuilds were happening due to a difference in the compiler options that the IDE and
3758         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3759         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3760         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3761
3762         * Configurations/DebugRelease.xcconfig:
3763
3764 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3765
3766         [iOS DnD] Add a hook to perform two-step drops in editable content
3767         https://bugs.webkit.org/show_bug.cgi?id=172992
3768         <rdar://problem/32590174>
3769
3770         Reviewed by Tim Horton.
3771
3772         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
3773         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
3774         returning NO will continue with default WebKit behavior.
3775
3776         * WebCoreSupport/WebEditorClient.h:
3777         * WebCoreSupport/WebEditorClient.mm:
3778         (WebEditorClient::performTwoStepDrop):
3779
3780 2017-06-08  Jer Noble  <jer.noble@apple.com>
3781
3782         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
3783         https://bugs.webkit.org/show_bug.cgi?id=173091
3784
3785         Reviewed by Eric Carlson.
3786
3787         * WebView/WebPreferences.mm:
3788         (+[WebPreferences initialize]):
3789
3790 2017-06-07  Jer Noble  <jer.noble@apple.com>
3791
3792         Clean-up: RenderElement.h includes headers it doesn't use
3793         https://bugs.webkit.org/show_bug.cgi?id=173046
3794
3795         Reviewed by Andy Estes.
3796
3797         * WebView/WebImmediateActionController.mm:
3798
3799 2017-06-07  Zalan Bujtas  <zalan@apple.com>
3800
3801         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
3802         https://bugs.webkit.org/show_bug.cgi?id=173044
3803         <rdar://problem/32449338>
3804
3805         Reviewed by Tim Horton.
3806
3807         Cache the current device orientation so that we don't have to lift the WebThread lock
3808         to collect it.
3809
3810         * WebView/WebFrame.mm:
3811         (-[WebFrame deviceOrientationChanged]):
3812         * WebView/WebView.mm:
3813         (-[WebView _commonInitializationWithFrameName:groupName:]):
3814         (-[WebView _setDeviceOrientation:]):
3815         (-[WebView _deviceOrientation]):
3816         * WebView/WebViewData.h:
3817         * WebView/WebViewInternal.h:
3818
3819 2017-06-06  Jer Noble  <jer.noble@apple.com>
3820
3821         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
3822         https://bugs.webkit.org/show_bug.cgi?id=173008
3823
3824         Reviewed by Eric Carlson.
3825
3826         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
3827
3828         * WebView/WebPreferenceKeysPrivate.h:
3829         * WebView/WebPreferences.mm:
3830         (+[WebPreferences initialize]):
3831         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3832         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3833         * WebView/WebPreferencesPrivate.h:
3834         * WebView/WebView.mm:
3835         (-[WebView _preferencesChanged:]):
3836
3837 2017-06-06  Youenn Fablet  <youenn@apple.com>
3838
3839         Add an option to disable getUserMedia prompt in case of mock capture sources
3840         https://bugs.webkit.org/show_bug.cgi?id=172981
3841         <rdar://problem/32580325>
3842
3843         Reviewed by Eric Carlson.
3844
3845         Defining the option, getter and setter.
3846
3847         * WebView/WebPreferences.mm:
3848         (+[WebPreferences initialize]):
3849         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
3850         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
3851         * WebView/WebPreferencesPrivate.h:
3852
3853 2017-06-05  Dan Bernstein  <mitz@apple.com>
3854
3855         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
3856
3857         * WebView/WebView.mm:
3858         (-[WebView updateMediaTouchBar]):
3859         * WebView/WebViewData.h:
3860
3861 2017-06-03  Darin Adler  <darin@apple.com>
3862
3863         Streamline handling of attributes, using references as much as possible
3864         https://bugs.webkit.org/show_bug.cgi?id=172899
3865
3866         Reviewed by Chris Dumez.
3867
3868         * WebView/WebHTMLRepresentation.mm:
3869         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
3870         passed in element can't be null. Removed unnecessary conversion from NSString to String
3871         and then back to NSString.
3872
3873 2017-06-01  Andy Estes  <aestes@apple.com>
3874
3875         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3876         https://bugs.webkit.org/show_bug.cgi?id=172828
3877
3878         Reviewed by Beth Dakin.
3879
3880         * Configurations/FeatureDefines.xcconfig:
3881
3882 2017-05-31  Andy Estes  <aestes@apple.com>
3883
3884         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3885         https://bugs.webkit.org/show_bug.cgi?id=172366
3886
3887         Reviewed by Daniel Bates.
3888
3889         * Configurations/FeatureDefines.xcconfig:
3890
3891 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3892
3893         Only include DataDetectorsUI headers in iOS
3894         https://bugs.webkit.org/show_bug.cgi?id=172633
3895
3896         Reviewed by David Kilzer.
3897
3898         Enable data detectors only on iOS and not other variants of iOS.
3899
3900         * WebCoreSupport/WebFrameLoaderClient.mm:
3901
3902 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3903
3904         Update libwebrtc configuration
3905         https://bugs.webkit.org/show_bug.cgi?id=172727
3906
3907         Reviewed by Geoffrey Garen.
3908
3909         * Configurations/FeatureDefines.xcconfig:
3910
3911 2017-05-28  Dan Bernstein  <mitz@apple.com>
3912
3913         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
3914         https://bugs.webkit.org/show_bug.cgi?id=172691
3915
3916         Reviewed by Tim Horton.
3917
3918         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
3919
3920 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
3921
3922         [WK2] Address thread safety issues with ResourceLoadStatistics
3923         https://bugs.webkit.org/show_bug.cgi?id=172519
3924         <rdar://problem/31707642>
3925
3926         Reviewed by Chris Dumez.
3927
3928         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
3929
3930         * WebView/WebView.mm:
3931         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
3932
3933 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3934
3935         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3936         https://bugs.webkit.org/show_bug.cgi?id=172554
3937         <rdar://problem/31247133>
3938
3939         Reviewed by Simon Fraser.
3940
3941         Update an overridden internal AppKit function to the new signature.
3942
3943         * WebView/WebHTMLView.mm:
3944         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
3945         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3946         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
3947         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
3948
3949 2017-05-24  Jer Noble  <jer.noble@apple.com>
3950
3951         Rename DisplaySleepDisabler -> SleepDisabler
3952         https://bugs.webkit.org/show_bug.cgi?id=172478
3953
3954         Reviewed by Sam Weinig.
3955
3956         * WebView/WebFullScreenController.h:
3957
3958 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3959
3960         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3961         https://bugs.webkit.org/show_bug.cgi?id=172522
3962         rdar://problem/31071812
3963
3964         Reviewed by Tim Horton.
3965
3966         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
3967         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
3968         versions this synchronization is no longer required.
3969
3970         * WebView/WebView.mm:
3971         (LayerFlushController::flushLayers):
3972
3973 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3974
3975         Snapshotting via -renderInContext: should do synchronous image decodes
3976         https://bugs.webkit.org/show_bug.cgi?id=172485
3977         rdar://problem/32276146
3978
3979         Reviewed by Tim Horton.
3980
3981         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
3982         has any callers.
3983
3984         * Plugins/WebBaseNetscapePluginView.h:
3985         * Plugins/WebBaseNetscapePluginView.mm:
3986         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
3987         * WebView/WebFrame.mm:
3988         (-[WebFrame _paintBehaviorForDestinationContext:]):
3989         (-[WebFrame _drawRect:contentsOnly:]):
3990         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
3991         * WebView/WebHTMLView.mm:
3992         (imageFromRect):
3993         * WebView/WebView.mm:
3994         (-[WebView _commonInitializationWithFrameName:groupName:]):
3995         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
3996         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
3997         * WebView/WebViewData.h:
3998         * WebView/WebViewPrivate.h:
3999
4000 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
4001
4002         Remove dead ENABLE(FONT_LOAD_EVENTS) code
4003         https://bugs.webkit.org/show_bug.cgi?id=172517
4004
4005         Rubber-stamped by Simon Fraser.
4006
4007         * Configurations/FeatureDefines.xcconfig:
4008
4009 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
4010
4011         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
4012         https://bugs.webkit.org/show_bug.cgi?id=171984
4013
4014         Reviewed by Antti Koivisto.
4015
4016         * WebView/WebPreferenceKeysPrivate.h:
4017         * WebView/WebPreferences.mm:
4018         (+[WebPreferences initialize]):
4019         (-[WebPreferences displayContentsEnabled]):
4020         (-[WebPreferences setDisplayContentsEnabled:]):
4021         * WebView/WebPreferencesPrivate.h:
4022         * WebView/WebView.mm:
4023         (-[WebView _preferencesChanged:]):
4024
4025 2017-05-22  Youenn Fablet  <youenn@apple.com>
4026
4027         Remove AVAudioCaptureSource
4028         https://bugs.webkit.org/show_bug.cgi?id=172360
4029
4030         Reviewed by Sam Weinig.
4031
4032         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
4033
4034         * WebView/WebPreferenceKeysPrivate.h:
4035         * WebView/WebPreferences.mm:
4036         (+[WebPreferences initialize]):
4037         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
4038         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
4039         * WebView/WebPreferencesPrivate.h:
4040         * WebView/WebView.mm:
4041         (-[WebView _preferencesChanged:]):
4042
4043 2017-05-22  Sam Weinig  <sam@webkit.org>
4044
4045         [WebIDL] Support callbacks with arbitrary return types
4046         https://bugs.webkit.org/show_bug.cgi?id=172407
4047
4048         Reviewed by Chris Dumez.
4049
4050         * DOM/DOM.mm:
4051         (-[DOMNodeFilter acceptNode:]):
4052         Update for CallbackResult adoption in the base class.
4053
4054         * DOM/DOMNodeIterator.mm:
4055         * DOM/DOMTreeWalker.mm:
4056         Update to account for new WebCore implementation return types. We return nil
4057         if there was an exception, since retains the existing behavior if a javascript
4058         NodeFilter had been used (an exception would cause all nodes to be rejected,
4059         thus returning nullptr).
4060
4061         * DOM/ObjCNodeFilterCondition.h:
4062         * DOM/ObjCNodeFilterCondition.mm:
4063         Update to match new interface of NodeFilterCondition.
4064
4065 2017-05-18  Sam Weinig  <sam@webkit.org>
4066
4067         [WebIDL] Remove the need for the generator to know about native type mapping
4068         https://bugs.webkit.org/show_bug.cgi?id=172310
4069
4070         Reviewed by Darin Adler.
4071
4072         * DOM/DOM.mm:
4073         (-[DOMNodeFilter acceptNode:]):
4074         Update to pass Node by reference.
4075
4076 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4077
4078         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
4079         https://bugs.webkit.org/show_bug.cgi?id=172098
4080
4081         Reviewed by Saam Barati.
4082
4083         * Plugins/Hosted/ProxyInstance.mm:
4084         * Plugins/Hosted/ProxyRuntimeObject.mm:
4085
4086 2017-05-18  Andy Estes  <aestes@apple.com>
4087