Have prefers-color-scheme: light always match on macOS versions before Mojave.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2
3         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4         https://bugs.webkit.org/show_bug.cgi?id=191655
5         rdar://problem/46074680
6
7         Reviewed by Megan Gardner.
8
9         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
10         * WebView/WebView.mm:
11         (-[WebView _effectiveAppearanceIsDark]):
12
13 2019-01-12  Dan Bernstein  <mitz@apple.com>
14
15         [Cocoa] Avoid importing directly from subumbrella frameworks
16         https://bugs.webkit.org/show_bug.cgi?id=186016
17         <rdar://problem/40591038>
18
19         Reviewed by Sam Weinig.
20
21         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
22         * Carbon/CarbonWindowAdapter.mm: Ditto.
23         * Carbon/CarbonWindowFrame.m: Ditto.
24         * Carbon/HIViewAdapter.h: Ditto.
25         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
26           OTHER_CFLAGS_COCOA_TOUCH_NO.
27         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
28         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
29         * WebView/WebPDFView.h: Ditto.
30
31 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
32
33         Enable visual viewport API by default
34         https://bugs.webkit.org/show_bug.cgi?id=193376
35
36         Reviewed by Simon Fraser.
37
38         * WebView/WebPreferences.mm:
39         (+[WebPreferences initialize]):
40
41 2019-01-11  John Wilander  <wilander@apple.com>
42
43         Compile out Web API Statistics Collection
44         https://bugs.webkit.org/show_bug.cgi?id=193370
45         <rdar://problem/45388584>
46
47         Reviewed by Brent Fulgham.
48
49         * Configurations/FeatureDefines.xcconfig:
50             Defined ENABLE_WEB_API_STATISTICS, off by default.
51
52 2019-01-08  Alex Christensen  <achristensen@webkit.org>
53
54         Stop using NetworkStorageSession in WebProcess
55         https://bugs.webkit.org/show_bug.cgi?id=193236
56
57         Reviewed by Don Olmstead.
58
59         * WebCoreSupport/WebFrameNetworkingContext.h:
60         * WebCoreSupport/WebFrameNetworkingContext.mm:
61         (WebFrameNetworkingContext::storageSession const):
62         * WebCoreSupport/WebPlatformStrategies.h:
63         * WebCoreSupport/WebPlatformStrategies.mm:
64         (WebPlatformStrategies::cookiesForDOM):
65         (WebPlatformStrategies::setCookiesFromDOM):
66         (WebPlatformStrategies::cookiesEnabled):
67         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
68         (WebPlatformStrategies::getRawCookies):
69         (WebPlatformStrategies::deleteCookie):
70         * WebView/WebView.mm:
71         (-[WebView _cachedResponseForURL:]):
72         (-[WebView _clearCredentials]):
73
74 2019-01-08  Alex Christensen  <achristensen@webkit.org>
75
76         Unreviewed, rolling out r239727.
77
78         Broke API tests
79
80         Reverted changeset:
81
82         "Stop using NetworkStorageSession in WebProcess"
83         https://bugs.webkit.org/show_bug.cgi?id=193236
84         https://trac.webkit.org/changeset/239727
85
86 2019-01-08  Alex Christensen  <achristensen@webkit.org>
87
88         Stop using NetworkStorageSession in WebProcess
89         https://bugs.webkit.org/show_bug.cgi?id=193236
90
91         Reviewed by Don Olmstead.
92
93         * WebCoreSupport/WebFrameNetworkingContext.h:
94         * WebCoreSupport/WebFrameNetworkingContext.mm:
95         (WebFrameNetworkingContext::storageSession const):
96         * WebView/WebView.mm:
97         (-[WebView _cachedResponseForURL:]):
98         (-[WebView _clearCredentials]):
99
100 2019-01-07  David Kilzer  <ddkilzer@apple.com>
101
102         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
103         <https://webkit.org/b/193056>
104
105         Reviewed by Alex Christensen.
106
107         * Plugins/Hosted/NetscapePluginHostProxy.h:
108         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
109         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
110         (WebKit::NetscapePluginInstanceProxy::enumerate):
111         (WebKit::NetscapePluginInstanceProxy::marshalValue):
112         (WebKit::NetscapePluginInstanceProxy::marshalValues):
113         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
114         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
115         * Plugins/Hosted/ProxyInstance.mm:
116         (WebKit::ProxyInstance::invoke):
117         * WebCoreSupport/WebGeolocationClient.mm:
118         * WebView/WebDataSource.mm:
119         (-[WebDataSource _receivedData:]):
120         * WebView/WebView.mm:
121         (-[WebView _cachedResponseForURL:]):
122         - Remove '*' from RetainPtr<> type.
123
124 2019-01-04  Alex Christensen  <achristensen@webkit.org>
125
126         Progress towards fixing Mac CMake build
127         https://bugs.webkit.org/show_bug.cgi?id=193105
128
129         Reviewed by Don Olmstead.
130
131         * WebKitPrefix.h:
132
133 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
134
135         Web Inspector: Use save sheet instead of dialog where possible
136         https://bugs.webkit.org/show_bug.cgi?id=193160
137         <rdar://problem/37399759>
138
139         Reviewed by Devin Rousso.
140
141         * WebCoreSupport/WebInspectorClient.mm:
142         (WebInspectorFrontendClient::save):
143
144 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
145
146         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
147         https://bugs.webkit.org/show_bug.cgi?id=193129
148
149         Reviewed by Tim Horton.
150
151         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
152
153         * WebCoreSupport/WebEditorClient.mm:
154         (WebEditorClient::registerUndoOrRedoStep):
155         (undoNameForEditAction): Deleted.
156
157 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
158
159         Add support for using the current text selection as the find string on iOS
160         https://bugs.webkit.org/show_bug.cgi?id=193034
161         <rdar://problem/45138739>
162
163         Reviewed by Tim Horton.
164
165         Add a method stub for WebKitLegacy.
166
167         * WebCoreSupport/WebEditorClient.h:
168
169 2019-01-01  Jeff Miller  <jeffm@apple.com>
170
171         Update user-visible copyright strings to include 2019
172         https://bugs.webkit.org/show_bug.cgi?id=192811
173
174         Reviewed by Mark Lam.
175
176         * Info.plist:
177
178 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
179
180         Use Ref<> as much as possible
181         https://bugs.webkit.org/show_bug.cgi?id=192808
182
183         Reviewed by Alex Christensen.
184
185         * DOM/DOM.mm:
186         (-[DOMNode getPreviewSnapshotImage:andRects:]):
187         * Plugins/Hosted/NetscapePluginHostManager.mm:
188         (WebKit::NetscapePluginHostManager::instantiatePlugin):
189         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
190         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
191         (WebKit::NetscapePluginInstanceProxy::loadRequest):
192         * Plugins/WebNetscapePluginView.mm:
193         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
194         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
195         * WebCoreSupport/WebContextMenuClient.mm:
196         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
197         * WebCoreSupport/WebFrameLoaderClient.mm:
198         (WebFrameLoaderClient::transitionToCommittedForNewPage):
199         * WebView/WebFrame.mm:
200         (-[WebFrame getDictationResultRanges:andMetadatas:]):
201         * WebView/WebHTMLView.mm:
202         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
203         * WebView/WebView.mm:
204         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
205         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
206
207 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
208
209         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
210         https://bugs.webkit.org/show_bug.cgi?id=192821
211
212         Reviewed by Chris Dumez.
213
214         When a window becomes occluded, the window server informs the application.
215         This should be used to suspend any work that is not visible by the user.
216
217         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
218         In some cases, that lead to performance impact (see radar).
219
220         This patch adds an observer for the occlusion notification. I tried to stick
221         with the same names used by WebKit2.
222
223         * WebView/WebView.mm:
224         (-[WebView _isViewVisible]):
225         (-[WebView addWindowObserversForWindow:]):
226         (-[WebView removeWindowObservers]):
227         (-[WebView _windowDidChangeOcclusionState:]):
228
229 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
230
231         [WebAuthN] Add a runtime flag for local authenticator
232         https://bugs.webkit.org/show_bug.cgi?id=192792
233         <rdar://problem/46798738>
234
235         Reviewed by Brent Fulgham.
236
237         * WebView/WebPreferenceKeysPrivate.h:
238         * WebView/WebPreferences.mm:
239         (+[WebPreferences initialize]):
240         (-[WebPreferences webAuthenticationEnabled]): Deleted.
241         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
242         * WebView/WebPreferencesPrivate.h:
243         * WebView/WebView.mm:
244         (-[WebView _preferencesChanged:]):
245
246 2018-12-20  Chris Dumez  <cdumez@apple.com>
247
248         Use Optional::valueOr() instead of Optional::value_or()
249         https://bugs.webkit.org/show_bug.cgi?id=192933
250
251         Reviewed by Geoffrey Garen.
252
253         * WebCoreSupport/WebSecurityOrigin.mm:
254         (-[WebSecurityOrigin port]):
255
256 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
257
258         Unreviewed, rolling out r239417.
259
260         Introduced two API test failures on macOS.
261
262         Reverted changeset:
263
264         "<rdar://problem/46194315> macOS: WebKit1 does not handle
265         occlusion changes"
266         https://bugs.webkit.org/show_bug.cgi?id=192821
267         https://trac.webkit.org/changeset/239417
268
269 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
270
271         WKWebView default UA doesn't freeze the build number
272         https://bugs.webkit.org/show_bug.cgi?id=192809
273         <rdar://problem/44687185>
274
275         Reviewed by Andy Estes.
276
277         Always reports the frozen build number.
278
279         * WebView/WebView.mm:
280         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
281         actual build number through this method call.
282         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
283
284 2018-12-19  Chris Dumez  <cdumez@apple.com>
285
286         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
287         https://bugs.webkit.org/show_bug.cgi?id=192728
288         <rdar://problem/46746779>
289
290         Reviewed by Geoff Garen.
291
292         * DOM/*:
293         * Plugins/*:
294         * WebCoreSupport/*:
295         * WebView/*:
296
297 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
298
299         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
300         https://bugs.webkit.org/show_bug.cgi?id=192821
301
302         Reviewed by Chris Dumez.
303
304         When a window becomes occluded, the window server informs the application.
305         This should be used to suspend any work that is not visible by the user.
306
307         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
308         In some cases, that lead to performance impact (see radar).
309
310         This patch adds an observer for the occlusion notification. I tried to stick
311         with the same names used by WebKit2.
312
313         * WebView/WebView.mm:
314         (-[WebView _isViewVisible]):
315         (-[WebView addWindowObserversForWindow:]):
316         (-[WebView removeWindowObservers]):
317         (-[WebView _windowDidChangeOcclusionState:]):
318
319 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
320
321         Allow clients to set the navigator platform
322         https://bugs.webkit.org/show_bug.cgi?id=192735
323
324         Reviewed by Tim Horton.
325
326         Add stubs to fill out the added functionality in FrameLoaderClient.
327
328         * WebCoreSupport/WebFrameLoaderClient.h:
329         * WebCoreSupport/WebFrameLoaderClient.mm:
330         (WebFrameLoaderClient::navigatorPlatform):
331
332 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
333
334         offsetLeft and offsetParent should adjust across shadow boundaries
335         https://bugs.webkit.org/show_bug.cgi?id=157437
336         <rdar://problem/26154021>
337
338         Reviewed by Simon Fraser.
339
340         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
341
342         * DOM/DOMElement.mm:
343         (-[DOMElement offsetLeft]):
344         (-[DOMElement offsetTop]):
345         (-[DOMElement offsetParent]):
346
347 2018-12-17  Zalan Bujtas  <zalan@apple.com>
348
349         Unreviewed build fix.
350
351         * WebView/WebFrame.mm:
352         (-[WebFrame getDictationResultRanges:andMetadatas:]):
353
354 2018-12-15  Darin Adler  <darin@apple.com>
355
356         Use warning-ignoring macros more consistently and simply
357         https://bugs.webkit.org/show_bug.cgi?id=192743
358
359         Reviewed by Mark Lam.
360
361         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
362         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
363         compilers in Objective-C++ code.
364
365         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
366         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
367         accomodate non-clang compilers here. Also use #pragma once, add a missing
368         "explicit" and fix conditionals.
369
370 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
371
372         Make TextInputController.legacyAttributedString take DOM nodes and offsets
373         https://bugs.webkit.org/show_bug.cgi?id=192653
374
375         Reviewed by Wenson Hsieh.
376
377         * WebView/WebHTMLView.mm:
378         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
379
380 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
381
382         Implement feature flag for CSS Typed OM
383         https://bugs.webkit.org/show_bug.cgi?id=192610
384
385         Reviewed by Ryosuke Niwa.
386
387         * Configurations/FeatureDefines.xcconfig:
388
389 2018-12-11  Tim Horton  <timothy_horton@apple.com>
390
391         WebCore shouldn't have a Objective-C class named NSCursor
392         https://bugs.webkit.org/show_bug.cgi?id=192602
393         <rdar://problem/46615532>
394
395         Reviewed by Wenson Hsieh.
396
397         * WebView/WebFrameView.mm:
398         (-[WebFrameView keyDown:keyDown:]):
399         * WebView/WebHTMLView.mm:
400         (-[WebHTMLView keyDown:]):
401         (-[WebHTMLView performKeyEquivalent:]):
402         Only use NSCursor on macOS.
403
404 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
405
406         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
407         https://bugs.webkit.org/show_bug.cgi?id=192573
408
409         Reviewed by Simon Fraser.
410
411         * Configurations/FeatureDefines.xcconfig:
412
413 2018-12-10  Antti Koivisto  <antti@apple.com>
414
415         Rename "forced style recalc" to "full style rebuild"
416         https://bugs.webkit.org/show_bug.cgi?id=192572
417
418         Reviewed by Zalan Bujtas.
419
420         * WebView/WebHTMLView.mm:
421         (-[WebHTMLView setNeedsToApplyStyles:]):
422
423 2018-12-10  Darin Adler  <darin@apple.com>
424
425         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
426         https://bugs.webkit.org/show_bug.cgi?id=192533
427         rdar://problem/45732710
428
429         Reviewed by Anders Carlsson.
430
431         * Plugins/Hosted/NetscapePluginHostProxy.mm:
432         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
433
434 2018-12-10  Darin Adler  <darin@apple.com>
435
436         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
437         https://bugs.webkit.org/show_bug.cgi?id=192532
438         rdar://problem/45731047
439
440         Reviewed by Chris Dumez.
441
442         * Plugins/Hosted/NetscapePluginHostManager.mm:
443         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
444         * Plugins/Hosted/NetscapePluginHostProxy.mm:
445         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
446
447 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         Turn WritingDirection into an enum class
450         https://bugs.webkit.org/show_bug.cgi?id=192401
451         Work towards <rdar://problem/42075638>
452
453         Reviewed by Dan Bernstein.
454
455         Change WritingDirection from an enum to an enum class. No change in behavior.
456
457         * WebView/WebHTMLView.mm:
458         (-[WebHTMLView toggleBaseWritingDirection:]):
459         (-[WebHTMLView changeBaseWritingDirection:]):
460         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
461
462 2018-12-03  Alex Christensen  <achristensen@webkit.org>
463
464         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
465         https://bugs.webkit.org/show_bug.cgi?id=192272
466
467         Reviewed by Brady Eidson.
468
469         * WebCoreSupport/WebFrameLoaderClient.h:
470         * WebCoreSupport/WebFrameLoaderClient.mm:
471         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
472
473 2018-12-03  Jer Noble  <jer.noble@apple.com>
474
475         Get rid of old, dead Mac video fullscreen code.
476         https://bugs.webkit.org/show_bug.cgi?id=192315
477
478         Reviewed by Eric Carlson.
479
480         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
481         is no longer supported in the Mac port.
482
483         * WebView/WebVideoFullscreenController.h: Removed.
484         * WebView/WebVideoFullscreenController.mm: Removed.
485         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
486         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
487         * WebView/WebView.mm:
488         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
489         (-[WebView _exitVideoFullscreen]):
490
491 2018-12-03  Daniel Bates  <dabates@apple.com>
492
493         [iOS] Do not handle key events that are key commands
494         https://bugs.webkit.org/show_bug.cgi?id=191608
495         <rdar://problem/46046013>
496
497         Reviewed by Ryosuke Niwa.
498
499         A key down event may be associated with a key command. If it is then we want to execute the
500         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
501         event as a key command to find out.
502
503         * WebView/WebHTMLView.mm:
504         (-[WebHTMLView _handleEditingKeyEvent:]):
505
506 2018-12-02  Zalan Bujtas  <zalan@apple.com>
507
508         Add a runtime feature flag for LayoutFormattingContext.
509         https://bugs.webkit.org/show_bug.cgi?id=192280
510
511         Reviewed by Simon Fraser.
512
513         * Configurations/FeatureDefines.xcconfig:
514
515 2018-11-30  Alex Christensen  <achristensen@webkit.org>
516
517         Move URL from WebCore to WTF
518         https://bugs.webkit.org/show_bug.cgi?id=190234
519
520         Reviewed by Keith Miller.
521
522         * DOM/DOMAttr.mm:
523         * DOM/DOMBlob.mm:
524         * DOM/DOMCSSCharsetRule.mm:
525         * DOM/DOMCSSImportRule.mm:
526         * DOM/DOMCSSMediaRule.mm:
527         * DOM/DOMCSSPageRule.mm:
528         * DOM/DOMCSSPrimitiveValue.mm:
529         * DOM/DOMCSSRule.mm:
530         * DOM/DOMCSSStyleDeclaration.mm:
531         * DOM/DOMCSSStyleRule.mm:
532         * DOM/DOMCSSStyleSheet.mm:
533         * DOM/DOMCSSValue.mm:
534         * DOM/DOMCharacterData.mm:
535         * DOM/DOMCounter.mm:
536         * DOM/DOMDocument.mm:
537         * DOM/DOMDocumentFragment.mm:
538         * DOM/DOMDocumentType.mm:
539         * DOM/DOMEvent.mm:
540         * DOM/DOMFile.mm:
541         * DOM/DOMHTMLAnchorElement.mm:
542         * DOM/DOMHTMLAppletElement.mm:
543         * DOM/DOMHTMLAreaElement.mm:
544         * DOM/DOMHTMLBRElement.mm:
545         * DOM/DOMHTMLBaseElement.mm:
546         * DOM/DOMHTMLBaseFontElement.mm:
547         * DOM/DOMHTMLBodyElement.mm:
548         * DOM/DOMHTMLButtonElement.mm:
549         * DOM/DOMHTMLCanvasElement.mm:
550         * DOM/DOMHTMLCollection.mm:
551         * DOM/DOMHTMLDivElement.mm:
552         * DOM/DOMHTMLDocument.mm:
553         * DOM/DOMHTMLElement.mm:
554         * DOM/DOMHTMLEmbedElement.mm:
555         * DOM/DOMHTMLFieldSetElement.mm:
556         * DOM/DOMHTMLFontElement.mm:
557         * DOM/DOMHTMLFormElement.mm:
558         * DOM/DOMHTMLFrameElement.mm:
559         * DOM/DOMHTMLFrameSetElement.mm:
560         * DOM/DOMHTMLHRElement.mm:
561         * DOM/DOMHTMLHeadElement.mm:
562         * DOM/DOMHTMLHeadingElement.mm:
563         * DOM/DOMHTMLHtmlElement.mm:
564         * DOM/DOMHTMLIFrameElement.mm:
565         * DOM/DOMHTMLImageElement.mm:
566         * DOM/DOMHTMLInputElement.mm:
567         * DOM/DOMHTMLLIElement.mm:
568         * DOM/DOMHTMLLabelElement.mm:
569         * DOM/DOMHTMLLegendElement.mm:
570         * DOM/DOMHTMLLinkElement.mm:
571         * DOM/DOMHTMLMapElement.mm:
572         * DOM/DOMHTMLMarqueeElement.mm:
573         * DOM/DOMHTMLMediaElement.mm:
574         * DOM/DOMHTMLMetaElement.mm:
575         * DOM/DOMHTMLModElement.mm:
576         * DOM/DOMHTMLOListElement.mm:
577         * DOM/DOMHTMLObjectElement.mm:
578         * DOM/DOMHTMLOptGroupElement.mm:
579         * DOM/DOMHTMLOptionElement.mm:
580         * DOM/DOMHTMLOptionsCollection.mm:
581         * DOM/DOMHTMLParagraphElement.mm:
582         * DOM/DOMHTMLParamElement.mm:
583         * DOM/DOMHTMLQuoteElement.mm:
584         * DOM/DOMHTMLScriptElement.mm:
585         * DOM/DOMHTMLSelectElement.mm:
586         * DOM/DOMHTMLStyleElement.mm:
587         * DOM/DOMHTMLTableCaptionElement.mm:
588         * DOM/DOMHTMLTableCellElement.mm:
589         * DOM/DOMHTMLTableColElement.mm:
590         * DOM/DOMHTMLTableElement.mm:
591         * DOM/DOMHTMLTableRowElement.mm:
592         * DOM/DOMHTMLTableSectionElement.mm:
593         * DOM/DOMHTMLTitleElement.mm:
594         * DOM/DOMHTMLUListElement.mm:
595         * DOM/DOMHTMLVideoElement.mm:
596         * DOM/DOMKeyboardEvent.mm:
597         * DOM/DOMMediaList.mm:
598         * DOM/DOMMouseEvent.mm:
599         * DOM/DOMMutationEvent.mm:
600         * DOM/DOMNamedNodeMap.mm:
601         * DOM/DOMProcessingInstruction.mm:
602         * DOM/DOMRange.mm:
603         * DOM/DOMStyleSheet.mm:
604         * DOM/DOMText.mm:
605         * DOM/DOMTextEvent.mm:
606         * DOM/DOMTokenList.mm:
607         * DOM/DOMUIEvent.mm:
608         * DOM/DOMXPathResult.mm:
609         * History/WebHistoryItem.mm:
610         * Misc/WebNSURLExtras.mm:
611         (-[NSURL _web_userVisibleString]):
612         (-[NSURL _web_URLByRemovingUserInfo]):
613         (-[NSURL _web_dataForURLComponentType:]):
614         (-[NSURL _web_schemeData]):
615         (-[NSURL _web_hostData]):
616         * Misc/WebUserContentURLPattern.mm:
617         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
618         * Plugins/WebNetscapePluginStream.h:
619         (WebNetscapePluginStream::setRequestURL):
620         * WebCoreSupport/WebChromeClient.h:
621         * WebCoreSupport/WebChromeClient.mm:
622         (WebChromeClient::signedPublicKeyAndChallengeString const):
623         * WebCoreSupport/WebContextMenuClient.h:
624         * WebCoreSupport/WebContextMenuClient.mm:
625         * WebCoreSupport/WebDragClient.h:
626         * WebCoreSupport/WebFrameLoaderClient.h:
627         * WebCoreSupport/WebFrameLoaderClient.mm:
628         (WebFrameLoaderClient::updateGlobalHistory):
629         * WebCoreSupport/WebPaymentCoordinatorClient.h:
630         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
631         (WebPaymentCoordinatorClient::showPaymentUI):
632         * WebCoreSupport/WebPlatformStrategies.h:
633         * WebCoreSupport/WebPlatformStrategies.mm:
634         (WebPlatformStrategies::readURLFromPasteboard):
635         * WebCoreSupport/WebPluginInfoProvider.h:
636         * WebCoreSupport/WebPluginInfoProvider.mm:
637         (WebPluginInfoProvider::webVisiblePluginInfo):
638         * WebCoreSupport/WebSecurityOrigin.mm:
639         * WebCoreSupport/WebVisitedLinkStore.h:
640         * WebView/WebDataSource.mm:
641         * WebView/WebFrame.mm:
642         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
643         * WebView/WebImmediateActionController.mm:
644         (-[WebImmediateActionController _defaultAnimationController]):
645         * WebView/WebPDFView.mm:
646         * WebView/WebScriptDebugger.mm:
647         * WebView/WebViewInternal.h:
648
649 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
650
651         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
652         https://bugs.webkit.org/show_bug.cgi?id=192197
653
654         Reviewed by Jiewen Tan.
655
656         * Configurations/FeatureDefines.xcconfig:
657         * WebCoreSupport/WebChromeClient.h:
658         * WebCoreSupport/WebChromeClient.mm:
659
660 2018-11-28  Alex Christensen  <achristensen@webkit.org>
661
662         Remove dead code from an earlier attempt at implementing safe browsing
663         https://bugs.webkit.org/show_bug.cgi?id=192067
664
665         Reviewed by Chris Dumez.
666
667         * WebCoreSupport/WebFrameLoaderClient.h:
668         * WebCoreSupport/WebFrameLoaderClient.mm:
669         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
670
671 2018-11-27  Mark Lam  <mark.lam@apple.com>
672
673         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
674         https://bugs.webkit.org/show_bug.cgi?id=192055
675         <rdar://problem/46288783>
676
677         Reviewed by Saam Barati.
678
679         * Configurations/FeatureDefines.xcconfig:
680
681 2018-11-25  Tim Horton  <timothy_horton@apple.com>
682
683         Make it possible to insert editable images with a gesture
684         https://bugs.webkit.org/show_bug.cgi?id=191937
685
686         Reviewed by Wenson Hsieh.
687
688         * WebCoreSupport/WebEditorClient.mm:
689         (undoNameForEditAction):
690         Add a undo name.
691
692 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
693
694         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
695         https://bugs.webkit.org/show_bug.cgi?id=191945
696
697         Reviewed by Anders Carlsson.
698
699         * WebCoreSupport/WebEditorClient.mm:
700         (undoNameForEditAction):
701
702 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
703
704         Enable drag and drop support for iOSMac
705         https://bugs.webkit.org/show_bug.cgi?id=191818
706         <rdar://problem/43907454>
707
708         Reviewed by Dean Jackson.
709
710         * Configurations/FeatureDefines.xcconfig:
711
712 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
713
714         Address post-review feedback after r238438
715         https://bugs.webkit.org/show_bug.cgi?id=191913
716
717         Reviewed by Ryosuke Niwa.
718
719         * WebView/WebFrame.mm:
720         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
721         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
722         * WebView/WebView.mm:
723         (-[WebView setSelectedDOMRange:affinity:]):
724
725 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
726
727         Web Inspector: "Reload Web Inspector" button no longer partially works
728         https://bugs.webkit.org/show_bug.cgi?id=191773
729         <rdar://problem/46139932>
730
731         Reviewed by Devin Rousso.
732
733         * WebCoreSupport/WebInspectorClient.h:
734         * WebCoreSupport/WebInspectorClient.mm:
735         (WebInspectorFrontendClient::reopen):
736
737 2018-11-17  Devin Rousso  <drousso@apple.com>
738
739         Web Inspector: Network: add button to show system certificate dialog
740         https://bugs.webkit.org/show_bug.cgi?id=191458
741         <rdar://problem/45977019>
742
743         Reviewed by Joseph Pecoraro.
744
745         * WebCoreSupport/WebInspectorClient.h:
746         * WebCoreSupport/WebInspectorClient.mm:
747         (WebInspectorFrontendClient::showCertificate): Added.
748
749         * Configurations/WebKitLegacy.xcconfig:
750
751 2018-11-15  Truitt Savell  <tsavell@apple.com>
752
753         Unreviewed, rolling out r238244.
754
755         Caused High Sierra test runs to fail early with 50 crashes and
756         casued 25 API failures.
757
758         Reverted changeset:
759
760         "[css-logical] Implement flow-relative margin, padding and
761         border shorthands"
762         https://bugs.webkit.org/show_bug.cgi?id=188697
763         https://trac.webkit.org/changeset/238244
764
765 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
766
767         [css-logical] Implement flow-relative margin, padding and border shorthands
768         https://bugs.webkit.org/show_bug.cgi?id=188697
769
770         Reviewed by Simon Fraser and Antti Koivisto.
771
772         Add CSSLogicalEnabled runtime flag.
773
774         * WebView/WebPreferenceKeysPrivate.h:
775         * WebView/WebPreferences.mm:
776         (+[WebPreferences initialize]):
777         (-[WebPreferences cssLogicalEnabled]):
778         (-[WebPreferences setCSSLogicalEnabled:]):
779         * WebView/WebPreferencesPrivate.h:
780         * WebView/WebView.mm:
781         (-[WebView _preferencesChanged:]):
782
783 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
784
785         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
786         https://bugs.webkit.org/show_bug.cgi?id=191612
787
788         Reviewed by Matt Baker.
789
790         * WebCoreSupport/WebInspectorClient.mm:
791         (-[WebInspectorWindowController destroyInspectorView]):
792
793 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
794
795         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
796         https://bugs.webkit.org/show_bug.cgi?id=191494
797         <rdar://problem/45469854>
798
799         Reviewed by Devin Rousso.
800
801         * WebCoreSupport/WebInspectorClient.h:
802         WebKitLegacy will still have remote inspection of the Page directly.
803
804 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
805
806         Make compositing updates incremental
807         https://bugs.webkit.org/show_bug.cgi?id=90342
808
809         Reviewed by Antti Koivisto.
810
811         Fix spelling error.
812
813         * WebView/WebView.mm:
814         (-[WebView _setMediaLayer:forPluginView:]):
815
816 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
817
818         Implement a new edit command to change the enclosing list type
819         https://bugs.webkit.org/show_bug.cgi?id=191487
820         <rdar://problem/45955922>
821
822         Reviewed by Ryosuke Niwa.
823
824         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
825
826         * WebCoreSupport/WebEditorClient.mm:
827         (undoNameForEditAction):
828
829 2018-11-11  Daniel Bates  <dabates@apple.com>
830
831         [iOS] Draw caps lock indicator in password fields
832         https://bugs.webkit.org/show_bug.cgi?id=190565
833         <rdar://problem/45262343>
834
835         Reviewed by Dean Jackson.
836
837         Update the caps lock state when a hardware keyboard is attached or detached.
838
839         * WebView/WebHTMLView.mm:
840         (hardwareKeyboardAvailabilityChangedCallback): Added.
841         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
842         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
843
844 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
845
846         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
847         https://bugs.webkit.org/show_bug.cgi?id=191492
848
849         Reviewed by Alex Christensen.
850
851         * Carbon/HIWebView.mm:
852         * Misc/WebNSFileManagerExtras.mm:
853         * Misc/WebNSURLExtras.mm:
854         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
855         * Plugins/WebBasePluginPackage.mm:
856         * Plugins/WebPluginContainerCheck.mm:
857         * WebCoreSupport/WebCachedFramePlatformData.h:
858         * WebCoreSupport/WebDeviceOrientationClient.mm:
859         * WebView/WebDelegateImplementationCaching.mm:
860         * WebView/WebHTMLView.mm:
861         * WebView/WebPDFRepresentation.mm:
862         * WebView/WebPolicyDelegate.mm:
863         * WebView/WebView.mm:
864
865 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
866
867         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
868         https://bugs.webkit.org/show_bug.cgi?id=191492
869
870         Reviewed by Alex Christensen.
871
872         * Carbon/HIWebView.mm:
873         (UpdateCommandStatus):
874         * Misc/WebNSFileManagerExtras.mm:
875         * Misc/WebNSURLExtras.mm:
876         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
877         * Plugins/WebBasePluginPackage.mm:
878         * Plugins/WebPluginContainerCheck.mm:
879         (-[WebPluginContainerCheck _continueWithPolicy:]):
880         * WebCoreSupport/WebCachedFramePlatformData.h:
881         (WebCachedFramePlatformData::clear):
882         * WebCoreSupport/WebDeviceOrientationClient.mm:
883         (WebDeviceOrientationClient::getProvider const):
884         * WebView/WebDelegateImplementationCaching.mm:
885         (CallDelegate):
886         (CallDelegateReturningBoolean):
887         (CallResourceLoadDelegateReturningBoolean):
888         (CallFormDelegate):
889         (CallFormDelegateReturningBoolean):
890         * WebView/WebHTMLView.mm:
891         * WebView/WebPDFRepresentation.mm:
892         * WebView/WebPolicyDelegate.mm:
893         (-[WebPolicyDecisionListener _usePolicy:]):
894         * WebView/WebView.mm:
895
896 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
897
898         Unreviewed, rolling out r238047.
899
900         Introduced layout test failures on iOS simulator.
901
902         Reverted changeset:
903
904         "[iOS] Draw caps lock indicator in password fields"
905         https://bugs.webkit.org/show_bug.cgi?id=190565
906         https://trac.webkit.org/changeset/238047
907
908 2018-11-09  Antti Koivisto  <antti@apple.com>
909
910         Use OptionSet for layout milestones
911         https://bugs.webkit.org/show_bug.cgi?id=191470
912
913         Reviewed by Dean Jackson.
914
915         * WebCoreSupport/WebFrameLoaderClient.h:
916         * WebCoreSupport/WebFrameLoaderClient.mm:
917         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
918         * WebView/WebView.mm:
919         (coreLayoutMilestones):
920         (kitLayoutMilestones):
921         (-[WebView _cacheFrameLoadDelegateImplementations]):
922         * WebView/WebViewInternal.h:
923
924 2018-11-09  Daniel Bates  <dabates@apple.com>
925
926         [iOS] Draw caps lock indicator in password fields
927         https://bugs.webkit.org/show_bug.cgi?id=190565
928         <rdar://problem/45262343>
929
930         Reviewed by Dean Jackson.
931
932         Update the caps lock state when a hardware keyboard is attached or detached.
933
934         * WebView/WebHTMLView.mm:
935         (hardwareKeyboardAvailabilityChangedCallback): Added.
936         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
937         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
938
939 2018-11-09  Daniel Bates  <dabates@apple.com>
940
941         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
942         action when forward delete is pressed outside a text field
943         https://bugs.webkit.org/show_bug.cgi?id=190566
944         <rdar://problem/45262367>
945
946         Reviewed by Wenson Hsieh.
947
948         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
949         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
950         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
951
952         * WebView/WebHTMLView.mm:
953         (-[WebHTMLView _handleEditingKeyEvent:]):
954
955 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
956
957         Adopt Reveal Framework to replace Lookup
958         https://bugs.webkit.org/show_bug.cgi?id=191097
959         <rdar://problem/45924508>
960
961         Reviewed by Tim Horton.
962
963         Pass in what it needed to clear the textIndicators. This is better than
964         the current notification structure.
965
966         * WebView/WebView.mm:
967         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
968         (-[WebView _prepareForDictionaryLookup]):
969
970 2018-11-06  Justin Fan  <justin_fan@apple.com>
971
972         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
973         https://bugs.webkit.org/show_bug.cgi?id=191291
974
975         Reviewed by Myles Maxfield.
976
977         Properly disable WEBGPU on all non-Metal platforms for now.
978
979         * Configurations/FeatureDefines.xcconfig:
980
981 2018-11-02  Daniel Bates  <dabates@apple.com>
982
983         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
984         https://bugs.webkit.org/show_bug.cgi?id=190487
985
986         Reviewed by Tim Horton.
987
988         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
989         allow the default handling.
990
991         * WebView/WebHTMLView.mm:
992         (-[WebHTMLView _handleEditingKeyEvent:]):
993
994 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
995
996         Add a storage limit for IndexedDB
997         https://bugs.webkit.org/show_bug.cgi?id=190598
998         <rdar://problem/44654715>
999
1000         Reviewed by Chris Dumez.
1001
1002         * Storage/WebDatabaseManager.mm:
1003         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1004         * Storage/WebDatabaseManagerPrivate.h:
1005
1006 2018-10-31  Antti Koivisto  <antti@apple.com>
1007
1008         Remove LayerFlushScheduler
1009         https://bugs.webkit.org/show_bug.cgi?id=191103
1010
1011         Reviewed by Anders Carlsson.
1012
1013         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1014         all the virtual cruft.
1015
1016         * WebView/WebViewData.h:
1017         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1018         (): Deleted.
1019         * WebView/WebViewData.mm:
1020         (currentRunLoop):
1021         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1022         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1023         (WebViewLayerFlushScheduler::schedule):
1024         (WebViewLayerFlushScheduler::invalidate):
1025         (WebViewLayerFlushScheduler::layerFlushCallback):
1026
1027 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1028
1029         Enable InstallAPI for iOS unconditionally
1030         https://bugs.webkit.org/show_bug.cgi?id=191043
1031         rdar://problem/32728423
1032
1033         Reviewed by Dan Bernstein.
1034
1035         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1036         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1037         shouldn't be processed by InstallAPI.
1038         * MigrateHeaders.make: Removed an obsolete workaround.
1039         * Misc/NSURLDownloadSPI.h: Added.
1040         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1041
1042 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1043
1044         Clean up some obsolete MAX_ALLOWED macros
1045         https://bugs.webkit.org/show_bug.cgi?id=190916
1046
1047         Reviewed by Tim Horton.
1048
1049         * WebView/WebHTMLView.mm:
1050         (-[WebHTMLView pressureChangeWithEvent:]):
1051         * WebView/WebPDFView.h:
1052
1053 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1054
1055         Unreviewed, rolling out r237600 and r237604.
1056         https://bugs.webkit.org/show_bug.cgi?id=191086
1057
1058         Breaks internal iOS builds (Requested by ryanhadd_ on
1059         #webkit).
1060
1061         Reverted changesets:
1062
1063         "Enable InstallAPI for iOS unconditionally"
1064         https://bugs.webkit.org/show_bug.cgi?id=191043
1065         https://trac.webkit.org/changeset/237600
1066
1067         "Build fix attempt after enabling InstallAPI for iOS."
1068         https://bugs.webkit.org/show_bug.cgi?id=191043
1069         https://trac.webkit.org/changeset/237604
1070
1071 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1072
1073         Enable InstallAPI for iOS unconditionally
1074         https://bugs.webkit.org/show_bug.cgi?id=191043
1075         rdar://problem/32728423
1076
1077         Reviewed by Dan Bernstein.
1078
1079         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1080         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1081         shouldn't be processed by InstallAPI.
1082         * MigrateHeaders.make: Removed an obsolete workaround.
1083         * Misc/NSURLDownloadSPI.h: Added.
1084         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1085
1086 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1087
1088         Modernize WebKit nibs and lprojs for localization's sake
1089         https://bugs.webkit.org/show_bug.cgi?id=190911
1090         <rdar://problem/45349466>
1091
1092         Reviewed by Dan Bernstein.
1093
1094         * Misc/WebNSControlExtras.m:
1095         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1096         NSWindow and its contents are both in the same scale space these days; avoid
1097         double-applying the scale factor, or you can't see the prompt.
1098
1099         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1100         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1101         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1102         NIB->XIB
1103
1104 2018-10-25  Antoine Quint  <graouts@apple.com>
1105
1106         [Web Animations] Turn Web Animations CSS Integration off by default
1107         https://bugs.webkit.org/show_bug.cgi?id=190901
1108
1109         Reviewed by Dean Jackson.
1110
1111         * WebView/WebPreferences.mm:
1112         (+[WebPreferences initialize]):
1113
1114 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1115
1116         Clean up some obsolete macOS version guards
1117         https://bugs.webkit.org/show_bug.cgi?id=190887
1118
1119         Reviewed by Dan Bernstein.
1120
1121         * Misc/WebNSPasteboardExtras.mm:
1122         (+[NSPasteboard _web_dragTypesForURL]):
1123         * WebCoreSupport/PopupMenuMac.mm:
1124         (PopupMenuMac::show):
1125         * WebCoreSupport/WebEditorClient.h:
1126         * WebCoreSupport/WebEditorClient.mm:
1127         (WebEditorClient::respondToChangedSelection):
1128         * WebView/WebPDFView.mm:
1129         (-[WebPDFView _clipViewForPDFDocumentView]):
1130
1131 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1132
1133         Turn on Conic Gradients
1134         https://bugs.webkit.org/show_bug.cgi?id=190810
1135
1136         Reviewed by Tim Horton.
1137
1138         * Configurations/FeatureDefines.xcconfig:
1139
1140 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1141
1142         Cleanup: MIMETypeRegistry functions
1143         https://bugs.webkit.org/show_bug.cgi?id=190838
1144
1145         Reviewed by Simon Fraser.
1146
1147         * Misc/WebNSPasteboardExtras.mm:
1148         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1149         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1150         because they were identical.
1151
1152         * WebView/WebHTMLRepresentation.mm:
1153         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1154         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1155         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1156         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1157         * WebView/WebView.mm:
1158         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1159         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1160         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1161
1162 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1163
1164         Fix false positive leaks when using custom -init methods that don't start with -init
1165         <https://webkit.org/b/190818>
1166         <rdar://problem/45476042>
1167
1168         Reviewed by Dan Bernstein.
1169
1170         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1171         it is accessible by both categories.
1172         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1173         NSError (WebKitInternal) category.  Add attribute to make this
1174         behave like an -init method.
1175         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1176         NSError (WebKitInternal) category.  Modernize method.  Replace
1177         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1178
1179 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1180
1181         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1182         https://bugs.webkit.org/show_bug.cgi?id=190729
1183
1184         Reviewed by Tim Horton.
1185
1186         * DOM/DOM.mm:
1187         (-[DOMNode boundingBox]):
1188         * DOM/DOMElement.mm:
1189         * DOM/DOMHTML.mm:
1190         * DOM/DOMInternal.mm:
1191         * DOM/DOMUIKitExtensions.mm:
1192         * DOM/WebDOMOperations.mm:
1193         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1194         * DefaultDelegates/WebDefaultEditingDelegate.m:
1195         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1196         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1197         * DefaultDelegates/WebDefaultUIDelegate.h:
1198         * DefaultDelegates/WebDefaultUIDelegate.mm:
1199         (-[WebDefaultUIDelegate webViewClose:]):
1200         (-[WebDefaultUIDelegate webViewFocus:]):
1201         (-[WebDefaultUIDelegate webViewUnfocus:]):
1202         (-[WebDefaultUIDelegate webViewIsResizable:]):
1203         (-[WebDefaultUIDelegate webView:setResizable:]):
1204         (-[WebDefaultUIDelegate webView:setFrame:]):
1205         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1206         * History/BackForwardList.h:
1207         * History/BackForwardList.mm:
1208         * History/WebBackForwardList.mm:
1209         (+[WebBackForwardList initialize]):
1210         (bumperCarBackForwardHackNeeded):
1211         * History/WebHistory.mm:
1212         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1213         (-[WebHistory _sendNotification:entries:]):
1214         (-[WebHistory loadFromURL:error:]):
1215         (-[WebHistory saveToURL:error:]):
1216         * History/WebHistoryItem.mm:
1217         (WKNotifyHistoryItemChanged):
1218         (+[WebHistoryItem initialize]):
1219         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1220         * History/WebURLsWithTitles.m:
1221         * Misc/WebCache.mm:
1222         (+[WebCache initialize]):
1223         * Misc/WebDownload.mm:
1224         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1225         * Misc/WebElementDictionary.mm:
1226         (+[WebElementDictionary initialize]):
1227         (+[WebElementDictionary initializeLookupTable]):
1228         * Misc/WebIconDatabase.mm:
1229         * Misc/WebKitNSStringExtras.mm:
1230         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1231         * Misc/WebKitVersionChecks.h:
1232         * Misc/WebKitVersionChecks.mm:
1233         (WebKitLinkedOnOrAfter):
1234         (WebKitLinkTimeVersion):
1235         * Misc/WebLocalizableStrings.mm:
1236         * Misc/WebNSControlExtras.h:
1237         * Misc/WebNSControlExtras.m:
1238         * Misc/WebNSEventExtras.m:
1239         * Misc/WebNSFileManagerExtras.mm:
1240         * Misc/WebNSImageExtras.h:
1241         * Misc/WebNSImageExtras.m:
1242         * Misc/WebNSPasteboardExtras.mm:
1243         * Misc/WebNSPrintOperationExtras.h:
1244         * Misc/WebNSPrintOperationExtras.m:
1245         * Misc/WebNSViewExtras.m:
1246         * Misc/WebNSWindowExtras.m:
1247         * Panels/WebAuthenticationPanel.h:
1248         * Panels/WebAuthenticationPanel.m:
1249         * Panels/WebPanelAuthenticationHandler.m:
1250         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1251         (+[WebHostedNetscapePluginView initialize]):
1252         * Plugins/WebBasePluginPackage.h:
1253         * Plugins/WebBasePluginPackage.mm:
1254         * Plugins/WebJavaPlugIn.h:
1255         * Plugins/WebPluginContainerCheck.mm:
1256         * Plugins/WebPluginController.h:
1257         * Plugins/WebPluginController.mm:
1258         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1259         (-[WebPluginController addPlugin:]):
1260         (-[WebPluginController destroyPlugin:]):
1261         (-[WebPluginController destroyAllPlugins]):
1262         * Plugins/WebPluginDatabase.mm:
1263         (+[WebPluginDatabase _defaultPlugInPaths]):
1264         * Plugins/WebPluginPackage.mm:
1265         (-[WebPluginPackage initWithPath:]):
1266         * Storage/WebDatabaseManager.mm:
1267         (-[WebDatabaseManager deleteAllDatabases]):
1268         * Storage/WebDatabaseManagerClient.h:
1269         * Storage/WebDatabaseManagerClient.mm:
1270         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1271         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1272         * Storage/WebStorageManager.mm:
1273         (-[WebStorageManager deleteAllOrigins]):
1274         (WebKitInitializeStorageIfNecessary):
1275         * WebCoreSupport/WebAlternativeTextClient.h:
1276         * WebCoreSupport/WebApplicationCache.mm:
1277         (applicationCacheBundleIdentifier):
1278         * WebCoreSupport/WebChromeClient.h:
1279         * WebCoreSupport/WebChromeClient.mm:
1280         (WebChromeClient::setWindowRect):
1281         (WebChromeClient::windowRect):
1282         (WebChromeClient::takeFocus):
1283         (WebChromeClient::addMessageToConsole):
1284         (WebChromeClient::enableSuddenTermination):
1285         (WebChromeClient::disableSuddenTermination):
1286         (WebChromeClient::createPopupMenu const):
1287         (WebChromeClient::createSearchPopupMenu const):
1288         (WebChromeClient::shouldPaintEntireContents const):
1289         (WebChromeClient::supportsVideoFullscreen):
1290         (WebChromeClient::supportsFullScreenForElement):
1291         (WebChromeClient::enterFullScreenForElement):
1292         (WebChromeClient::exitFullScreenForElement):
1293         * WebCoreSupport/WebContextMenuClient.mm:
1294         * WebCoreSupport/WebDragClient.mm:
1295         * WebCoreSupport/WebEditorClient.h:
1296         * WebCoreSupport/WebEditorClient.mm:
1297         (+[WebUndoStep initialize]):
1298         (updateFontPanel):
1299         (WebEditorClient::didBeginEditing):
1300         (WebEditorClient::respondToChangedContents):
1301         (WebEditorClient::respondToChangedSelection):
1302         (WebEditorClient::canceledComposition):
1303         (WebEditorClient::didEndEditing):
1304         (WebEditorClient::didWriteSelectionToPasteboard):
1305         (attributesForAttributedStringConversion):
1306         (WebEditorClient::setInsertionPasteboard):
1307         (WebEditorClient::registerUndoOrRedoStep):
1308         (WebEditorClient::handleKeyboardEvent):
1309         (WebEditorClient::handleInputMethodKeydown):
1310         (WebEditorClient::textDidChangeInTextField):
1311         (WebEditorClient::requestCheckingOfString):
1312         * WebCoreSupport/WebFrameLoaderClient.h:
1313         * WebCoreSupport/WebFrameLoaderClient.mm:
1314         (WebFrameLoaderClient::detachedFromParent2):
1315         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1316         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1317         (WebFrameLoaderClient::dispatchWillSendRequest):
1318         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1319         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1320         (WebFrameLoaderClient::willCacheResponse const):
1321         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1322         (WebFrameLoaderClient::dispatchDidFinishLoading):
1323         (WebFrameLoaderClient::dispatchDidFailLoading):
1324         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1325         (WebFrameLoaderClient::dispatchWillClose):
1326         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1327         (WebFrameLoaderClient::dispatchDidCommitLoad):
1328         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1329         (WebFrameLoaderClient::dispatchDidFailLoad):
1330         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1331         (WebFrameLoaderClient::dispatchDidFinishLoad):
1332         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1333         (WebFrameLoaderClient::willChangeTitle):
1334         (WebFrameLoaderClient::didChangeTitle):
1335         (WebFrameLoaderClient::didReplaceMultipartContent):
1336         (WebFrameLoaderClient::updateGlobalHistory):
1337         (WebFrameLoaderClient::saveViewStateToItem):
1338         (WebFrameLoaderClient::restoreViewState):
1339         (WebFrameLoaderClient::provisionalLoadStarted):
1340         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1341         (WebFrameLoaderClient::setTitle):
1342         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1343         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1344         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1345         (WebFrameLoaderClient::didRestoreFromPageCache):
1346         (WebFrameLoaderClient::actionDictionary const):
1347         (WebFrameLoaderClient::createPlugin):
1348         (WebFrameLoaderClient::getLoadDecisionForIcons):
1349         (WebFrameLoaderClient::finishedLoadingIcon):
1350         (+[WebFramePolicyListener initialize]):
1351         * WebCoreSupport/WebFrameNetworkingContext.mm:
1352         * WebCoreSupport/WebGeolocationClient.h:
1353         * WebCoreSupport/WebGeolocationClient.mm:
1354         (WebGeolocationClient::requestPermission):
1355         * WebCoreSupport/WebInspectorClient.h:
1356         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1357         * WebCoreSupport/WebNotificationClient.mm:
1358         * WebCoreSupport/WebOpenPanelResultListener.mm:
1359         * WebCoreSupport/WebPlatformStrategies.h:
1360         * WebCoreSupport/WebPlatformStrategies.mm:
1361         * WebCoreSupport/WebProgressTrackerClient.h:
1362         * WebCoreSupport/WebProgressTrackerClient.mm:
1363         (WebProgressTrackerClient::progressStarted):
1364         (WebProgressTrackerClient::progressEstimateChanged):
1365         (WebProgressTrackerClient::progressFinished):
1366         * WebCoreSupport/WebSecurityOrigin.mm:
1367         * WebInspector/WebNodeHighlight.h:
1368         * WebInspector/WebNodeHighlight.mm:
1369         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1370         (-[WebNodeHighlight dealloc]):
1371         (-[WebNodeHighlight attach]):
1372         * WebInspector/WebNodeHighlightView.h:
1373         * WebInspector/WebNodeHighlightView.mm:
1374         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1375         (-[WebNodeHighlightView dealloc]):
1376         * WebInspector/WebNodeHighlighter.mm:
1377         (-[WebNodeHighlighter highlight]):
1378         * WebView/WebArchive.mm:
1379         (+[WebArchivePrivate initialize]):
1380         * WebView/WebClipView.h:
1381         * WebView/WebDataSource.mm:
1382         (WebDataSourcePrivate::WebDataSourcePrivate):
1383         (+[WebDataSource initialize]):
1384         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1385         (-[WebDataSource _makeRepresentation]):
1386         * WebView/WebDelegateImplementationCaching.h:
1387         * WebView/WebDelegateImplementationCaching.mm:
1388         (CallDelegate):
1389         (CallDelegateReturningFloat):
1390         (CallDelegateReturningBoolean):
1391         (CallUIDelegate):
1392         (CallUIDelegateReturningFloat):
1393         (CallUIDelegateReturningBoolean):
1394         (CallFrameLoadDelegate):
1395         (CallFrameLoadDelegateReturningBoolean):
1396         (CallResourceLoadDelegate):
1397         (CallScriptDebugDelegate):
1398         (CallFormDelegate):
1399         (CallFormDelegateReturningBoolean):
1400         * WebView/WebDeviceOrientation.mm:
1401         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1402         * WebView/WebDocumentInternal.h:
1403         * WebView/WebDocumentLoaderMac.mm:
1404         (needsDataLoadWorkaround):
1405         * WebView/WebDynamicScrollBarsViewInternal.h:
1406         * WebView/WebFormDelegate.m:
1407         * WebView/WebFrame.mm:
1408         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1409         (-[WebFrame _unmarkAllMisspellings]):
1410         (-[WebFrame _paintBehaviorForDestinationContext:]):
1411         (-[WebFrame _drawRect:contentsOnly:]):
1412         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1413         (-[WebFrame _scrollDOMRangeToVisible:]):
1414         (-[WebFrame _bodyBackgroundColor]):
1415         (-[WebFrame accessibilityRoot]):
1416         (needsMicrosoftMessengerDOMDocumentWorkaround):
1417         * WebView/WebFrameInternal.h:
1418         * WebView/WebFrameView.mm:
1419         (-[WebFrameView _setDocumentView:]):
1420         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1421         (-[WebFrameView _viewClassForMIMEType:]):
1422         (-[WebFrameView initWithFrame:]):
1423         (-[WebFrameView drawRect:]):
1424         (-[WebFrameView _firstResponderIsFormControl]):
1425         (-[WebFrameView keyDown:keyDown:]):
1426         (-[WebFrameView _isScrollable]):
1427         * WebView/WebFullScreenController.h:
1428         * WebView/WebFullScreenController.mm:
1429         * WebView/WebHTMLRepresentation.mm:
1430         * WebView/WebHTMLView.mm:
1431         (-[WebHTMLView hitTest:]):
1432         (-[WebHTMLView initWithFrame:]):
1433         (-[WebHTMLView dealloc]):
1434         (-[WebHTMLView addSubview:]):
1435         (-[WebHTMLView mouseDown:]):
1436         (-[WebHTMLView mouseUp:]):
1437         (-[WebHTMLView resignFirstResponder]):
1438         (-[WebHTMLView accessibilityHitTest:]):
1439         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1440         * WebView/WebHTMLViewInternal.h:
1441         * WebView/WebIndicateLayer.h:
1442         * WebView/WebIndicateLayer.mm:
1443         * WebView/WebMediaPlaybackTargetPicker.h:
1444         * WebView/WebMediaPlaybackTargetPicker.mm:
1445         * WebView/WebPDFDocumentExtras.h:
1446         * WebView/WebPDFDocumentExtras.mm:
1447         * WebView/WebPDFRepresentation.h:
1448         * WebView/WebPDFRepresentation.mm:
1449         * WebView/WebPDFView.h:
1450         * WebView/WebPreferences.mm:
1451         (cacheModelForMainBundle):
1452         (WebPreferencesPrivate::WebPreferencesPrivate):
1453         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1454         (-[WebPreferences encodeWithCoder:]):
1455         (+[WebPreferences standardPreferences]):
1456         (+[WebPreferences initialize]):
1457         (-[WebPreferences _valueForKey:]):
1458         (-[WebPreferences _setStringValue:forKey:]):
1459         (-[WebPreferences _setIntegerValue:forKey:]):
1460         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1461         (-[WebPreferences _setFloatValue:forKey:]):
1462         (-[WebPreferences _setBoolValue:forKey:]):
1463         (-[WebPreferences _setLongLongValue:forKey:]):
1464         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1465         (-[WebPreferences _postCacheModelChangedNotification]):
1466         (-[WebPreferences _postPreferencesChangedNotification]):
1467         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1468         (-[WebPreferences setStorageBlockingPolicy:]):
1469         * WebView/WebResource.mm:
1470         (+[WebResourcePrivate initialize]):
1471         * WebView/WebTextCompletionController.h:
1472         * WebView/WebTextIterator.mm:
1473         (+[WebTextIteratorPrivate initialize]):
1474         * WebView/WebView.mm:
1475         (shouldEnableLoadDeferring):
1476         (shouldRestrictWindowFocus):
1477         (shouldRespectPriorityInCSSAttributeSetters):
1478         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1479         (shouldAllowPictureInPictureMediaPlayback):
1480         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1481         (shouldAllowWindowOpenWithoutUserGesture):
1482         (shouldConvertInvalidURLsToBlank):
1483         (shouldRequireUserGestureToLoadVideo):
1484         (-[WebView _commonInitializationWithFrameName:groupName:]):
1485         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1486         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1487         (-[WebView _closePluginDatabases]):
1488         (-[WebView _closeWithFastTeardown]):
1489         (-[WebView _close]):
1490         (+[WebView _MIMETypeForFile:]):
1491         (-[WebView setShowingInspectorIndication:]):
1492         (-[WebView _setFormDelegate:]):
1493         (-[WebView _needsPreHTML5ParserQuirks]):
1494         (-[WebView _preferencesChangedNotification:]):
1495         (-[WebView _preferencesChanged:]):
1496         (-[WebView _cacheResourceLoadDelegateImplementations]):
1497         (-[WebView _cacheFrameLoadDelegateImplementations]):
1498         (-[WebView _policyDelegateForwarder]):
1499         (-[WebView _UIDelegateForwarder]):
1500         (-[WebView _editingDelegateForwarder]):
1501         (-[WebView _updateActiveState]):
1502         (-[_WebSafeForwarder forwardInvocation:]):
1503         (+[WebView initialize]):
1504         (-[WebView _pluginForMIMEType:]):
1505         (-[WebView _pluginForExtension:]):
1506         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1507         (+[WebView canShowMIMETypeAsHTML:]):
1508         (-[WebView _initWithArguments:]):
1509         (-[WebView initWithFrame:frameName:groupName:]):
1510         (-[WebView dealloc]):
1511         (-[WebView close]):
1512         (-[WebView viewDidMoveToWindow]):
1513         (-[WebView setUIDelegate:]):
1514         (-[WebView setResourceLoadDelegate:]):
1515         (-[WebView setPolicyDelegate:]):
1516         (-[WebView setFrameLoadDelegate:]):
1517         (-[WebView goBack]):
1518         (-[WebView goForward]):
1519         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1520         (-[WebView setHostWindow:]):
1521         (-[WebView becomeFirstResponder]):
1522         (+[WebView _cacheModelChangedNotification:]):
1523         (-[WebView _frameViewAtWindowPoint:]):
1524         (+[WebView _preflightSpellCheckerNow:]):
1525         (+[WebView _preflightSpellChecker]):
1526         (-[WebView canGoBack]):
1527         (-[WebView canGoForward]):
1528         (-[WebView stopLoading:]):
1529         (-[WebView reload:]):
1530         (-[WebView setMainFrameDocumentReady:]):
1531         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1532         (-[WebView setContinuousSpellCheckingEnabled:]):
1533         (-[WebView undoManager]):
1534         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1535         (-[WebView isAutomaticLinkDetectionEnabled]):
1536         (-[WebView isAutomaticDashSubstitutionEnabled]):
1537         (-[WebView isAutomaticTextReplacementEnabled]):
1538         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1539         (+[WebView _setCacheModel:]):
1540         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1541         (-[WebView _keyboardUIMode]):
1542         (LayerFlushController::flushLayers):
1543         (-[WebView _scheduleCompositingLayerFlush]):
1544         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1545         (-[WebView fullScreenPlaceholderView]):
1546         (WebInstallMemoryPressureHandler):
1547         * WebView/WebViewData.h:
1548         * WebView/WebViewData.mm:
1549         (+[WebViewPrivate initialize]):
1550         (-[WebViewPrivate init]):
1551         (-[WebViewPrivate dealloc]):
1552         * WebView/WebViewInternal.h:
1553
1554 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1555
1556         Clean up FrameLoader two-state enums
1557         https://bugs.webkit.org/show_bug.cgi?id=190731
1558
1559         Reviewed by Chris Dumez.
1560
1561         * WebCoreSupport/WebFrameLoaderClient.h:
1562         * WebCoreSupport/WebFrameLoaderClient.mm:
1563         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1564
1565 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1566
1567         Unreviewed, rolling out r237137.
1568
1569         SPI is actually used
1570
1571         Reverted changeset:
1572
1573         "Remove unused WebFrame._loadType"
1574         https://bugs.webkit.org/show_bug.cgi?id=190583
1575         https://trac.webkit.org/changeset/237137
1576
1577 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1578
1579         Enable the datalist element by default on iOS and macOS
1580         https://bugs.webkit.org/show_bug.cgi?id=190594
1581         <rdar://problem/45281159>
1582
1583         Reviewed by Ryosuke Niwa and Tim Horton.
1584
1585         * Configurations/FeatureDefines.xcconfig:
1586
1587 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1588
1589         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1590         https://bugs.webkit.org/show_bug.cgi?id=190675
1591
1592         Reviewed by Chris Dumez.
1593
1594         * History/BackForwardList.h:
1595         * History/BackForwardList.mm:
1596         (BackForwardList::backItem):
1597         (BackForwardList::currentItem):
1598         (BackForwardList::forwardItem):
1599         (BackForwardList::backListCount const):
1600         (BackForwardList::forwardListCount const):
1601         (BackForwardList::itemAtIndex):
1602         * History/WebBackForwardList.mm:
1603         (-[WebBackForwardList backItem]):
1604         (-[WebBackForwardList currentItem]):
1605         (-[WebBackForwardList forwardItem]):
1606         (-[WebBackForwardList itemAtIndex:]):
1607
1608 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1609
1610         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1611         https://bugs.webkit.org/show_bug.cgi?id=190526
1612         rdar://problem/45230140
1613
1614         Reviewed by Dean Jackson.
1615
1616         * WebCoreSupport/WebEditorClient.mm:
1617         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1618
1619 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1620
1621         Implement feature flag and bindings for CSS Painting API
1622         https://bugs.webkit.org/show_bug.cgi?id=190237
1623
1624         Reviewed by Ryosuke Niwa.
1625
1626         * Configurations/FeatureDefines.xcconfig:
1627
1628 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1629
1630         Replace HistoryItem* with HistoryItem& where possible
1631         https://bugs.webkit.org/show_bug.cgi?id=190617
1632
1633         Reviewed by Chris Dumez.
1634
1635         * History/BackForwardList.h:
1636         * History/BackForwardList.mm:
1637         (BackForwardList::goToItem):
1638         * History/WebBackForwardList.mm:
1639         (-[WebBackForwardList goToItem:]):
1640         * History/WebHistoryItem.mm:
1641         (WKNotifyHistoryItemChanged):
1642         * History/WebHistoryItemInternal.h:
1643
1644 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1645
1646         Remove unused WebHistoryItem._transientPropertyForKey
1647         https://bugs.webkit.org/show_bug.cgi?id=190606
1648
1649         Reviewed by Chris Dumez.
1650
1651         * History/WebHistoryItem.mm:
1652         * History/WebHistoryItemPrivate.h:
1653
1654 2018-10-15  Justin Fan  <justin_fan@apple.com>
1655
1656         Add WebGPU 2018 feature flag and experimental feature flag
1657         https://bugs.webkit.org/show_bug.cgi?id=190509
1658
1659         Reviewed by Dean Jackson.
1660
1661         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1662         for the 2018 WebGPU prototype.
1663
1664         * Configurations/FeatureDefines.xcconfig:
1665         * WebView/WebPreferenceKeysPrivate.h:
1666         * WebView/WebPreferences.mm:
1667         (+[WebPreferences initialize]):
1668         (-[WebPreferences webGPUEnabled]):
1669         (-[WebPreferences setWebGPUEnabled:]):
1670         * WebView/WebPreferencesPrivate.h:
1671         * WebView/WebView.mm:
1672         (-[WebView _preferencesChanged:]):
1673
1674 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1675
1676         Fix iOS build after r237157
1677
1678         * WebView/WebView.mm:
1679         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1680
1681 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1682
1683         Modernize BackForwardClient.h
1684         https://bugs.webkit.org/show_bug.cgi?id=190610
1685
1686         Reviewed by Chris Dumez.
1687
1688         * History/BackForwardList.h:
1689         * History/BackForwardList.mm:
1690         (BackForwardList::backListCount const):
1691         (BackForwardList::forwardListCount const):
1692         (BackForwardList::backListCount): Deleted.
1693         (BackForwardList::forwardListCount): Deleted.
1694         * History/WebBackForwardList.mm:
1695         (-[WebBackForwardList init]):
1696         * WebCoreSupport/WebFrameLoaderClient.mm:
1697         (WebFrameLoaderClient::canCachePage const):
1698         * WebView/WebFrameView.mm:
1699         (-[WebFrameView keyDown:keyDown:]):
1700         * WebView/WebView.mm:
1701         (-[WebView _commonInitializationWithFrameName:groupName:]):
1702         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1703         (-[WebView _loadBackForwardListFromOtherView:]):
1704         (-[WebView initWithCoder:]):
1705         (-[WebView encodeWithCoder:]):
1706         (-[WebView backForwardList]):
1707         (-[WebView setMaintainsBackForwardList:]):
1708
1709 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1710
1711         Add support for prefers-color-scheme media query
1712         https://bugs.webkit.org/show_bug.cgi?id=190499
1713         rdar://problem/45212025
1714
1715         Reviewed by Dean Jackson.
1716
1717         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1718
1719 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1720
1721         Remove unused WebView._globalHistoryItem
1722         https://bugs.webkit.org/show_bug.cgi?id=190601
1723
1724         Reviewed by Chris Dumez.
1725
1726         * WebCoreSupport/WebFrameLoaderClient.h:
1727         * WebCoreSupport/WebFrameLoaderClient.mm:
1728         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1729         * WebView/WebView.mm:
1730         (-[WebView _globalHistoryItem]): Deleted.
1731         (-[WebView _setGlobalHistoryItem:]): Deleted.
1732         * WebView/WebViewData.h:
1733         * WebView/WebViewInternal.h:
1734         * WebView/WebViewPrivate.h:
1735
1736 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1737
1738         Remove unused parameters from FrameLoaderClient::createFrame
1739         https://bugs.webkit.org/show_bug.cgi?id=190587
1740
1741         Reviewed by Chris Dumez.
1742
1743         * WebCoreSupport/WebFrameLoaderClient.h:
1744         * WebCoreSupport/WebFrameLoaderClient.mm:
1745         (WebFrameLoaderClient::createFrame):
1746
1747 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1748
1749         Remove unused WebFrame._loadType
1750         https://bugs.webkit.org/show_bug.cgi?id=190583
1751
1752         Reviewed by Chris Dumez.
1753
1754         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1755
1756         * WebView/WebFrame.mm:
1757         (toWebFrameLoadType): Deleted.
1758         (-[WebFrame _loadType]): Deleted.
1759         * WebView/WebFramePrivate.h:
1760
1761 2018-10-15  Chris Dumez  <cdumez@apple.com>
1762
1763         Restrict browsing context lookup by name to frames that are related to one another
1764         https://bugs.webkit.org/show_bug.cgi?id=190475
1765
1766         Reviewed by Alex Christensen.
1767
1768         * WebView/WebFrame.mm:
1769         (-[WebFrame findFrameNamed:]):
1770
1771 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1772
1773         Remove InjectedBundle processing of back/forward lists
1774         https://bugs.webkit.org/show_bug.cgi?id=190459
1775
1776         Reviewed by Chris Dumez.
1777
1778         * WebCoreSupport/WebFrameLoaderClient.h:
1779         * WebCoreSupport/WebFrameLoaderClient.mm:
1780         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1781
1782 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1783
1784         [JSC] Remove Option::useAsyncIterator
1785         https://bugs.webkit.org/show_bug.cgi?id=190567
1786
1787         Reviewed by Saam Barati.
1788
1789         * Configurations/FeatureDefines.xcconfig:
1790
1791 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1792
1793         Allow encoding of small enum classes
1794         https://bugs.webkit.org/show_bug.cgi?id=190531
1795
1796         Reviewed by Tim Horton.
1797
1798         * WebCoreSupport/WebFrameLoaderClient.mm:
1799         (-[WebFramePolicyListener dealloc]):
1800
1801 2018-10-11  Keith Rollin  <krollin@apple.com>
1802
1803         CURRENT_ARCH should not be used in Run Script phase.
1804         https://bugs.webkit.org/show_bug.cgi?id=190407
1805         <rdar://problem/45133556>
1806
1807         Reviewed by Alexey Proskuryakov.
1808
1809         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1810         CURRENT_ARCH is not well-defined during this phase (and may even have
1811         the value "undefined") since this phase is run just once per build
1812         rather than once per supported architecture. Migrate away from
1813         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1814         performing an operation for each value, or by picking the first entry
1815         in ARCHS and using that as a representative value.
1816
1817         * Configurations/WebKitLegacy.xcconfig: When generating
1818         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1819         macosx platforms.
1820
1821         * MigrateHeaders.make:
1822         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1823         generate one for each architecture in ARCHS.
1824
1825 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1826
1827         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1828         https://bugs.webkit.org/show_bug.cgi?id=190429
1829
1830         Reviewed by Saam Barati.
1831
1832         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1833
1834         * WebView/WebPDFRepresentation.mm:
1835         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1836
1837 2018-10-08  Justin Fan  <justin_fan@apple.com>
1838
1839         WebGPU: Rename old WebGPU prototype to WebMetal
1840         https://bugs.webkit.org/show_bug.cgi?id=190325
1841         <rdar://problem/44990443>
1842
1843         Reviewed by Dean Jackson.
1844
1845         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1846
1847         * Configurations/FeatureDefines.xcconfig:
1848         * WebView/WebPreferenceKeysPrivate.h:
1849         * WebView/WebPreferences.mm:
1850         (+[WebPreferences initialize]):
1851         (-[WebPreferences webMetalEnabled]):
1852         (-[WebPreferences setWebMetalEnabled:]):
1853         (-[WebPreferences webGPUEnabled]): Deleted.
1854         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1855         * WebView/WebPreferencesPrivate.h:
1856         * WebView/WebView.mm:
1857         (-[WebView _preferencesChanged:]):
1858
1859 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1860
1861         Make <input type=color> a runtime enabled (on-by-default) feature
1862         https://bugs.webkit.org/show_bug.cgi?id=189162
1863
1864         Reviewed by Wenson Hsieh and Tim Horton.
1865
1866         * Configurations/FeatureDefines.xcconfig:
1867
1868 2018-10-07  Dan Bernstein  <mitz@apple.com>
1869
1870         Fixed building with the latest macOS SDK
1871
1872         * Plugins/WebNetscapePluginPackage.mm:
1873         (-[WebNetscapePluginPackage openResourceFile]):
1874         (-[WebNetscapePluginPackage closeResourceFile:]):
1875
1876 2018-10-04  Dan Bernstein  <mitz@apple.com>
1877
1878         More Carbon build-fixing.
1879
1880         * Carbon/CarbonWindowAdapter.mm:
1881         (-[CarbonWindowAdapter _destroyRealWindow:]):
1882         (-[CarbonWindowAdapter _growBoxRect]):
1883
1884 2018-10-04  Dan Bernstein  <mitz@apple.com>
1885
1886         Retried to fix 32-bit macOS builds after r236846.
1887
1888         * WebView/WebHTMLView.mm:
1889         (-[WebHTMLView setMarkedText:selectedRange:]):
1890
1891 2018-10-04  Dan Bernstein  <mitz@apple.com>
1892
1893         Retried to fix 32-bit macOS builds after r236846.
1894
1895         * Carbon/HIWebView.mm:
1896         (ActiveStateChanged):
1897
1898 2018-10-04  Dan Bernstein  <mitz@apple.com>
1899
1900         Tried to fix 32-bit macOS builds after r236846.
1901
1902         * Carbon/HIWebView.mm:
1903         (_NSSelectorForHICommand):
1904
1905 2018-10-04  Dan Bernstein  <mitz@apple.com>
1906
1907         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1908         https://bugs.webkit.org/show_bug.cgi?id=190250
1909
1910         Reviewed by Andy Estes.
1911
1912         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1913           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1914           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1915           an earlier line set it to YES.
1916
1917         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1918         changes below.
1919
1920         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1921           provides some missing method declarations.
1922
1923         * Misc/WebDownload.mm:
1924         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1925           a deprecated method.
1926
1927         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1928
1929         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1930           other code in the file uses a method from it.
1931
1932         * Plugins/WebBaseNetscapePluginView.mm:
1933         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1934           a deprecated method.
1935
1936         * Plugins/WebPluginController.mm:
1937         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1938           around use of a selector that may be present in some WebKit client.
1939
1940         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1941           method declarations.
1942
1943         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1944           from here.
1945
1946         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1947           missing method declarations.
1948
1949         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1950           from here.
1951
1952         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1953           call from here.
1954         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1955           an obsolete delegate method for binary compatibility.
1956         (pluginView): Ditto.
1957
1958         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1959           call from here.
1960
1961         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1962           WebDeviceOrientationProviderMock protocol.
1963
1964         * WebView/WebDeviceOrientationProviderMock.mm:
1965         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1966           main @implementation.
1967
1968         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1969           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1970
1971         * WebView/WebDynamicScrollBarsView.mm:
1972         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1973           of a deprecated method.
1974
1975         * WebView/WebHTMLView.mm:
1976         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1977           selector warning around action methods that are not declared anywhere in WebKit.
1978
1979         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1980           about implementing this deprecated method.
1981         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1982         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1983         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1984         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1985         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1986         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1987         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1988         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1989         (-[WebHTMLView doCommandBySelector:]): Ditto.
1990         (-[WebHTMLView insertText:]): Ditto.
1991
1992         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1993
1994         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1995
1996         * WebView/WebPDFView.h: Removed previewView ivar.
1997
1998         * WebView/WebPDFView.mm:
1999           Removed declaration of FileInternal category and merged its implementation with the main
2000           implementation.
2001         (-[WebPDFView dealloc]): Removed previewView ivar.
2002         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2003           exist in macOS versions we support.
2004         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2005         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2006           action methods internal to PDFKit.
2007         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2008         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2009
2010         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2011           call on macOS, even though in r86988 we started calling different methods on iOS.
2012
2013         * WebView/WebView.mm:
2014         - Imported headers that declare delegate methods that we call.
2015         - Removed declaration of WebFileInternal category and merged its implementation with the
2016           main implementation.
2017         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2018           category, which made them impossible to call from the main implementation. Moved those
2019           into the main implementation. One of those had to be declared in a class extension,
2020           because it is called from a method implemented in the WebPrivate category, and that
2021           category’s implementation appears first in the file.
2022
2023         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2024           around use of obsolete delegate method for binary compatibility.
2025
2026         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2027
2028 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2029
2030         Runtime flag and IDL for MediaRecorder
2031         https://bugs.webkit.org/show_bug.cgi?id=190018
2032
2033         Reviewed by Youenn Fablet and Chris Dumez.
2034
2035         * WebView/WebPreferenceKeysPrivate.h:
2036         * WebView/WebPreferences.mm:
2037         (+[WebPreferences initialize]):
2038         (-[WebPreferences mediaRecorderEnabled]):
2039         (-[WebPreferences setMediaRecorderEnabled:]):
2040         * WebView/WebPreferencesPrivate.h:
2041         * WebView/WebView.mm:
2042         (-[WebView _preferencesChanged:]):
2043
2044 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2045
2046         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2047         https://bugs.webkit.org/show_bug.cgi?id=190238
2048
2049         Reviewed by Antti Koivisto.
2050
2051         Enabled the feature by default.
2052
2053         * WebView/WebPreferences.mm:
2054         (+[WebPreferences initialize]):
2055
2056 2018-10-01  Dean Jackson  <dino@apple.com>
2057
2058         [macOS] Switching to discrete GPU should be done in the UI process
2059         https://bugs.webkit.org/show_bug.cgi?id=189361
2060         <rdar://problem/43949622>
2061
2062         Reviewed by Simon Fraser.
2063
2064         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2065         not support swapping to the discrete GPU in this configuration.
2066
2067         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2068         (WebKit::WebSwitchingGPUClient::singleton):
2069         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2070         * WebView/WebView.mm:
2071         (-[WebView _commonInitializationWithFrameName:groupName:]):
2072
2073 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2074
2075         Remove ParsedURLString
2076         https://bugs.webkit.org/show_bug.cgi?id=190154
2077
2078         Reviewed by Chris Dumez.
2079
2080         * WebView/WebScriptDebugger.mm:
2081         (toNSURL):
2082
2083 2018-10-01  Dean Jackson  <dino@apple.com>
2084
2085         Remove CSS Animation Triggers
2086         https://bugs.webkit.org/show_bug.cgi?id=190175
2087         <rdar://problem/44925626>
2088
2089         Reviewed by Simon Fraser.
2090
2091         * Configurations/FeatureDefines.xcconfig:
2092
2093 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2094
2095         Unreviewed, rolling out r236624 and r236671.
2096         https://bugs.webkit.org/show_bug.cgi?id=190207
2097
2098         The change in r236624 introduced crashes on the bots
2099         (Requested by ryanhaddad on #webkit).
2100
2101         Reverted changesets:
2102
2103         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2104         https://bugs.webkit.org/show_bug.cgi?id=188747
2105         https://trac.webkit.org/changeset/236624
2106
2107         "Unify implementation in VideoFullscreenInterfaceAVKit"
2108         https://bugs.webkit.org/show_bug.cgi?id=190091
2109         https://trac.webkit.org/changeset/236671
2110
2111 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2112
2113         URL should not use TextEncoding internally
2114         https://bugs.webkit.org/show_bug.cgi?id=190111
2115
2116         Reviewed by Andy Estes.
2117
2118         * Misc/WebNSURLExtras.mm:
2119
2120 2018-09-28  Jer Noble  <jer.noble@apple.com>
2121
2122         Refactoring: eliminate raw pointer usage in Fullscreen code
2123         https://bugs.webkit.org/show_bug.cgi?id=188747
2124         <rdar://problem/43541164>
2125
2126         Reviewed by Alex Christensen.
2127
2128         PlaybackSessionInterface no longer has an invalidate() method.
2129
2130         * WebView/WebView.mm:
2131         (-[WebView _clearPlaybackControlsManager]):
2132
2133 2018-09-28  Chris Dumez  <cdumez@apple.com>
2134
2135         Drop support for cross-origin-window-policy header
2136         https://bugs.webkit.org/show_bug.cgi?id=190081
2137
2138         Reviewed by Ryosuke Niwa.
2139
2140         * WebView/WebPreferenceKeysPrivate.h:
2141         * WebView/WebPreferences.mm:
2142         (+[WebPreferences initialize]):
2143         * WebView/WebPreferencesPrivate.h:
2144         * WebView/WebView.mm:
2145         (-[WebView _preferencesChanged:]):
2146
2147 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         Rename createMarkup to serializePreservingVisualAppearance
2150         https://bugs.webkit.org/show_bug.cgi?id=190086
2151
2152         Reviewed by Wenson Hsieh.
2153
2154         * DOM/WebDOMOperations.mm:
2155         (-[DOMRange markupString]):
2156
2157 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2158
2159         Unreviewed, rolling out r236605.
2160         https://bugs.webkit.org/show_bug.cgi?id=190087
2161
2162         caused three API test timeouts (Requested by jernoble on
2163         #webkit).
2164
2165         Reverted changeset:
2166
2167         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2168         https://bugs.webkit.org/show_bug.cgi?id=188747
2169         https://trac.webkit.org/changeset/236605
2170
2171 2018-09-28  Jer Noble  <jer.noble@apple.com>
2172
2173         Refactoring: eliminate raw pointer usage in Fullscreen code
2174         https://bugs.webkit.org/show_bug.cgi?id=188747
2175         <rdar://problem/43541164>
2176
2177         Reviewed by Alex Christensen.
2178
2179         PlaybackSessionInterface no longer has an invalidate() method.
2180
2181         * WebView/WebView.mm:
2182         (-[WebView _clearPlaybackControlsManager]):
2183
2184 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2185
2186         Use enum class in createMarkup arguments
2187         https://bugs.webkit.org/show_bug.cgi?id=190028
2188
2189         Reviewed by Wenson Hsieh.
2190
2191         * DOM/WebDOMOperations.mm:
2192         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2193         (-[DOMRange markupString]): Ditto.
2194
2195 2018-09-27  Antoine Quint  <graouts@apple.com>
2196
2197         [Web Animations] Turn Web Animations with CSS integration on
2198         https://bugs.webkit.org/show_bug.cgi?id=184819
2199         <rdar://problem/39597337>
2200
2201         Reviewed by Dean Jackson.
2202
2203         * WebView/WebPreferences.mm:
2204         (+[WebPreferences initialize]):
2205
2206 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         Selection should work across shadow boundary when initiated by a mouse drag
2209         https://bugs.webkit.org/show_bug.cgi?id=151380
2210         <rdar://problem/24363872>
2211
2212         Reviewed by Wenson Hsieh.
2213
2214         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2215
2216         * WebView/WebPreferenceKeysPrivate.h:
2217         * WebView/WebPreferences.mm:
2218         (+[WebPreferences initialize]):
2219         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2220         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2221         * WebView/WebPreferencesPrivate.h:
2222         * WebView/WebView.mm:
2223         (-[WebView _preferencesChanged:]):
2224
2225 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2226
2227         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2228         https://bugs.webkit.org/show_bug.cgi?id=189918
2229         Work towards <rdar://problem/44648705>
2230
2231         Reviewed by Tim Horton.
2232
2233         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2234
2235         * WebView/WebHTMLView.mm:
2236         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2237         (-[WebHTMLView _updateFontPanel]):
2238         * WebView/WebView.mm:
2239         (-[WebView typingAttributes]):
2240
2241 2018-09-17  Darin Adler  <darin@apple.com>
2242
2243         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2244         https://bugs.webkit.org/show_bug.cgi?id=189652
2245
2246         Reviewed by Saam Barati.
2247
2248         * WebView/WebPDFRepresentation.mm:
2249         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2250
2251 2018-09-14  Jer Noble  <jer.noble@apple.com>
2252
2253         Turn SourceBufferChangeTypeEnabled on by default
2254         https://bugs.webkit.org/show_bug.cgi?id=189527
2255
2256         Reviewed by Eric Carlson.
2257
2258         * WebView/WebPreferences.mm:
2259         (+[WebPreferences initialize]):
2260
2261 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2262
2263         Fix an internal build after r235935
2264         https://bugs.webkit.org/show_bug.cgi?id=188996
2265
2266         * Carbon/HIWebView.mm:
2267         (Draw):
2268         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2269
2270 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2271
2272         Add IGNORE_WARNING_.* macros
2273         https://bugs.webkit.org/show_bug.cgi?id=188996
2274
2275         Reviewed by Michael Catanzaro.
2276
2277         * Carbon/CarbonUtils.m:
2278         (PoolCleaner):
2279         * Carbon/CarbonWindowAdapter.mm:
2280         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2281         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2282         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2283         (-[CarbonWindowAdapter _termWindowIfOwner]):
2284         (-[CarbonWindowAdapter _windowMovedToRect:]):
2285         (-[CarbonWindowAdapter setContentView:]):
2286         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2287         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2288         * Carbon/CarbonWindowFrame.m:
2289         (-[CarbonWindowFrame title]):
2290         * Carbon/HIViewAdapter.m:
2291         (+[HIViewAdapter getHIViewForNSView:]):
2292         * Carbon/HIWebView.mm:
2293         (overrideCGContext):
2294         (restoreCGContext):
2295         (Draw):
2296         * DOM/DOM.mm:
2297         * History/WebHistory.mm:
2298         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2299         * History/WebHistoryItem.mm:
2300         (-[WebHistoryItem icon]):
2301         * Misc/WebKitNSStringExtras.mm:
2302         (-[NSString _web_drawAtPoint:font:textColor:]):
2303         * Misc/WebNSImageExtras.m:
2304         (-[NSImage _web_scaleToMaxSize:]):
2305         (-[NSImage _web_dissolveToFraction:]):
2306         * Misc/WebNSPasteboardExtras.mm:
2307         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2308         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2309         * Panels/WebAuthenticationPanel.m:
2310         (-[WebAuthenticationPanel loadNib]):
2311         * Plugins/Hosted/NetscapePluginHostManager.mm:
2312         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2313         (WebKit::NetscapePluginHostManager::didCreateWindow):
2314         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2315         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2316         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2317         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2318         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2319         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2320         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2321         (-[WebHostedNetscapePluginView drawRect:]):
2322         * Plugins/Hosted/WebTextInputWindowController.m:
2323         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2324         * Plugins/WebBaseNetscapePluginView.mm:
2325         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2326         * Plugins/WebNetscapePluginPackage.mm:
2327         (-[WebNetscapePluginPackage _tryLoad]):
2328         * Plugins/WebNetscapePluginView.mm:
2329         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2330         (-[WebNetscapePluginView sendDrawRectEvent:]):
2331         (-[WebNetscapePluginView drawRect:]):
2332         * Plugins/WebPluginController.mm:
2333         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2334         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2335         * WebCoreSupport/PopupMenuMac.mm:
2336         (PopupMenuMac::populate):
2337         * WebCoreSupport/WebAlternativeTextClient.h:
2338         * WebCoreSupport/WebDragClient.mm:
2339         (WebDragClient::startDrag):
2340         * WebCoreSupport/WebFrameLoaderClient.mm:
2341         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2342         (webGetNSImage):
2343         * WebInspector/WebNodeHighlight.mm:
2344         * WebInspector/WebNodeHighlightView.mm:
2345         (-[WebNodeHighlightView drawRect:]):
2346         * WebView/WebClipView.mm:
2347         (-[WebClipView initWithFrame:]):
2348         * WebView/WebFrame.mm:
2349         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2350         (-[WebFrame _drawRect:contentsOnly:]):
2351         (-[WebFrame accessibilityRoot]):
2352         * WebView/WebFullScreenController.mm:
2353         (-[WebFullScreenController enterFullScreen:]):
2354         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2355         (-[WebFullScreenController exitFullScreen]):
2356         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2357         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2358         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2359         * WebView/WebHTMLView.mm:
2360         (-[NSWindow _web_borderView]):
2361         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2362         (-[WebHTMLView _setAsideSubviews]):
2363         (-[WebHTMLView _autoscroll]):
2364         (-[WebHTMLView drawRect:]):
2365         (-[WebHTMLView mouseDown:]):
2366         (-[WebHTMLView mouseDragged:]):
2367         (-[WebHTMLView mouseUp:]):
2368         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2369         (-[WebHTMLView knowsPageRange:]):
2370         (-[WebHTMLView accessibilityHitTest:]):
2371         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2372         (-[WebHTMLView _colorAsString:]):
2373         (-[WebHTMLView copyFont:]):
2374         (-[WebHTMLView _executeSavedKeypressCommands]):
2375         (-[WebHTMLView attachRootLayer:]):
2376         (-[WebHTMLView textStorage]):
2377         (-[WebHTMLView _updateSelectionForInputManager]):
2378         * WebView/WebPDFView.mm:
2379         (_applicationInfoForMIMEType):
2380         (-[WebPDFView centerSelectionInVisibleArea:]):
2381         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2382         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2383         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2384         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2385         * WebView/WebTextCompletionController.mm:
2386         (-[WebTextCompletionController _buildUI]):
2387         (-[WebTextCompletionController _placePopupWindow:]):
2388         * WebView/WebVideoFullscreenController.mm:
2389         * WebView/WebVideoFullscreenHUDWindowController.mm:
2390         (createMediaUIBackgroundView):
2391         * WebView/WebView.mm:
2392         (-[WebTextListTouchBarViewController initWithWebView:]):
2393         (-[WebView _dispatchTileDidDraw:]):
2394         (-[WebView encodeWithCoder:]):
2395         (-[WebView mainFrameIcon]):
2396         (LayerFlushController::flushLayers):
2397         * WebView/WebWindowAnimation.mm:
2398         (setScaledFrameForWindow):
2399
2400 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2401
2402         Remove unused needsDestruction class variables from HashTraits
2403         https://bugs.webkit.org/show_bug.cgi?id=189490
2404
2405         Reviewed by Daniel Bates.
2406
2407         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2408
2409 2018-09-07  Frederic Wang  <fwang@igalia.com>
2410
2411         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2412         https://bugs.webkit.org/show_bug.cgi?id=182230
2413
2414         Reviewed by Simon Fraser.
2415
2416         * DOM/DOMDocument.mm:
2417         (-[DOMDocument scrollingElement]): Use the new name.
2418
2419 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2420
2421         Refactor WebCore::EditAction to be an 8-bit enum class
2422         https://bugs.webkit.org/show_bug.cgi?id=189383
2423
2424         Reviewed by Dan Bernstein.
2425
2426         * WebCoreSupport/WebEditorClient.mm:
2427         (undoNameForEditAction):
2428         * WebView/WebHTMLView.mm:
2429         (-[WebHTMLView pasteFont:]):
2430         (-[WebHTMLView changeFont:]):
2431         (-[WebHTMLView changeAttributes:]):
2432         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2433         (-[WebHTMLView changeColor:]):
2434         * WebView/WebView.mm:
2435         (-[WebView setTypingStyle:]):
2436
2437 2018-09-06  Frederic Wang  <fwang@igalia.com>
2438
2439         Group options of scrollRectToVisible into a struct
2440         https://bugs.webkit.org/show_bug.cgi?id=189352
2441
2442         Reviewed by Simon Fraser.
2443
2444         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2445         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2446         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2447
2448 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         [macOS] Cannot change font size at selection until font panel is shown
2451         https://bugs.webkit.org/show_bug.cgi?id=189295
2452         <rdar://problem/35593389>
2453
2454         Reviewed by Ryosuke Niwa.
2455
2456         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2457         WebCore ChangeLog for more details.
2458
2459         * WebView/WebHTMLView.mm:
2460         (-[WebHTMLView changeFont:]):
2461         (-[WebHTMLView changeAttributes:]):
2462         (-[WebHTMLView _originalFontA]): Deleted.
2463         (-[WebHTMLView _originalFontB]): Deleted.
2464         (fontNameForDescription): Deleted.
2465         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2466         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2467         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2468
2469 2018-09-05  Jer Noble  <jer.noble@apple.com>
2470
2471         Add MediaCapabilities as an Experimental Feature
2472         https://bugs.webkit.org/show_bug.cgi?id=189209
2473
2474         Reviewed by Eric Carlson.
2475
2476         RuntimeEnabledFeature -> Setting.
2477
2478         * WebView/WebView.mm:
2479         (-[WebView _preferencesChanged:]):
2480
2481 2018-09-04  Frederic Wang  <fwang@igalia.com>
2482
2483         Add basic support for ScrollIntoViewOptions
2484         https://bugs.webkit.org/show_bug.cgi?id=189258
2485
2486         Reviewed by Simon Fraser.
2487
2488         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2489         header so that this file can build despite the new scrollIntoView function.
2490
2491 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2492
2493         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2494         https://bugs.webkit.org/show_bug.cgi?id=188890
2495         <rdar://problem/43648605>
2496
2497         Reviewed by Tim Horton.
2498
2499         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2500         more detail.
2501
2502         * WebCoreSupport/WebPlatformStrategies.h:
2503         * WebCoreSupport/WebPlatformStrategies.mm:
2504         (WebPlatformStrategies::allStringsForType):
2505
2506 2018-09-01  Darin Adler  <darin@apple.com>
2507
2508         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2509         https://bugs.webkit.org/show_bug.cgi?id=189072
2510         Reviewed by Dan Bernstein.
2511
2512         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2513         and declarations for NSURLDownload init methods.
2514
2515         * Misc/WebDownloadInternal.h: Removed.
2516
2517         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2518         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2519         "-Wdeprecated-declarations" because the method used here is deprecated.
2520
2521         * WebView/WebView.mm:
2522         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2523         used here is deprecated.
2524
2525 2018-08-31  Chris Dumez  <cdumez@apple.com>
2526
2527         Assertion hit in ~CompletionHandler() from ~WebFrame()
2528         https://bugs.webkit.org/show_bug.cgi?id=189199
2529         <rdar://problem/42657233>
2530
2531         Reviewed by Youenn Fablet.
2532
2533         * WebCoreSupport/WebFrameLoaderClient.h:
2534         * WebCoreSupport/WebFrameLoaderClient.mm:
2535         (WebFrameLoaderClient::dispatchWillSubmitForm):
2536
2537 2018-08-31  Antti Koivisto  <antti@apple.com>
2538
2539         Replace OptionSet |= and -= operators with add() and remove() functions
2540         https://bugs.webkit.org/show_bug.cgi?id=189169
2541
2542         Reviewed by Anders Carlsson.
2543
2544         * WebView/WebFrame.mm:
2545         (-[WebFrame _drawRect:contentsOnly:]):
2546         * WebView/WebView.mm:
2547         (coreOptions):
2548
2549 2018-08-31  Frederic Wang  <fwang@igalia.com>
2550
2551         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2552         https://bugs.webkit.org/show_bug.cgi?id=182053
2553
2554         Reviewed by Simon Fraser.
2555
2556         Add developer flag to use standard behavior for scrolling* attributes.
2557
2558         * WebView/WebPreferenceKeysPrivate.h:
2559         * WebView/WebPreferences.mm:
2560         (+[WebPreferences initialize]):
2561         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2562         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2563         * WebView/WebPreferencesPrivate.h:
2564         * WebView/WebView.mm:
2565         (-[WebView _preferencesChanged:]):
2566
2567 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2568
2569         Implement the Web Share API
2570         https://bugs.webkit.org/show_bug.cgi?id=171100
2571         <rdar://problem/31751734>
2572
2573         Reviewed by Tim Horton.
2574
2575         * WebCoreSupport/WebChromeClient.h:
2576         * WebCoreSupport/WebChromeClient.mm:
2577         (WebChromeClient::showShareSheet):
2578         Empty declaration of showShareSheet.
2579
2580 2018-08-29  Youenn Fablet  <youenn@apple.com>
2581
2582         Remove WebRTC legacy API implementation
2583         https://bugs.webkit.org/show_bug.cgi?id=189040
2584
2585         Reviewed by Eric Carlson.
2586
2587         * WebView/WebPreferenceKeysPrivate.h:
2588         * WebView/WebPreferences.mm:
2589         (+[WebPreferences initialize]):
2590         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2591         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2592         * WebView/WebPreferencesPrivate.h:
2593         * WebView/WebView.mm:
2594         (-[WebView _preferencesChanged:]):
2595
2596 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2597
2598         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2599         https://bugs.webkit.org/show_bug.cgi?id=189054
2600
2601         Reviewed by Andy Estes.
2602
2603         Remove the pasteboard type argument from readURLFromPasteboard.
2604
2605         * WebCoreSupport/WebPlatformStrategies.h:
2606         * WebCoreSupport/WebPlatformStrategies.mm:
2607         (WebPlatformStrategies::readURLFromPasteboard):
2608
2609 2018-08-27  Keith Rollin  <krollin@apple.com>
2610
2611         Unreviewed build fix -- disable LTO for production builds
2612
2613         * Configurations/Base.xcconfig:
2614
2615 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2616
2617         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2618         https://bugs.webkit.org/show_bug.cgi?id=188931
2619
2620         Reviewed by Wenson Hsieh.
2621
2622         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2623
2624 2018-08-27  Keith Rollin  <krollin@apple.com>
2625
2626         Build system support for LTO
2627         https://bugs.webkit.org/show_bug.cgi?id=187785
2628         <rdar://problem/42353132>
2629
2630         Reviewed by Dan Bernstein.
2631
2632         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2633         LTO.
2634
2635         * Configurations/Base.xcconfig:
2636         * Configurations/DebugRelease.xcconfig:
2637
2638 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2639
2640         Pass in IsComposed flag to Event constructors
2641         https://bugs.webkit.org/show_bug.cgi?id=188720
2642         <rdar://problem/43580387>
2643
2644         Reviewed by Simon Fraser.
2645
2646         * WebView/WebPDFView.mm:
2647         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2648         whether it's simulated or not.
2649
2650 2018-08-23  Mark Lam  <mark.lam@apple.com>
2651
2652         Move vmEntryGlobalObject() to VM from CallFrame.
2653         https://bugs.webkit.org/show_bug.cgi?id=188900
2654         <rdar://problem/43655753>
2655
2656         Reviewed by Michael Saboff.
2657
2658         * WebView/WebScriptDebugger.mm:
2659         (WebScriptDebugger::sourceParsed):
2660
2661 2018-08-23  Andy Estes  <aestes@apple.com>
2662
2663         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2664         https://bugs.webkit.org/show_bug.cgi?id=188829
2665
2666         Reviewed by Tim Horton.
2667
2668         * Configurations/FeatureDefines.xcconfig:
2669
2670 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2671
2672         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2673         https://bugs.webkit.org/show_bug.cgi?id=188777
2674
2675         Reviewed by Simon Fraser.
2676
2677         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2678         being "true" before the code change.
2679
2680         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2681
2682         * WebView/WebPDFView.mm:
2683         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2684
2685 2018-08-21  Daniel Bates  <dabates@apple.com>
2686
2687         Replace TextCheckingTypeMask with OptionSet
2688         https://bugs.webkit.org/show_bug.cgi?id=188678
2689
2690         Reviewed by Antti Koivisto.
2691
2692         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2693         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2694         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2695         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2696
2697         * WebCoreSupport/WebEditorClient.h:
2698         * WebCoreSupport/WebEditorClient.mm:
2699         (WebEditorClient::checkTextOfParagraph):
2700         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2701         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2702         left as this is more readable and unncessary now that modern compilers like Clang have
2703         diagnostics to catch accidental assignments when equality was intended.
2704         (WebEditorClient::didCheckSucceed):
2705         * WebView/WebView.mm:
2706         (coreTextCheckingType):
2707         (textCheckingResultFromNSTextCheckingResult):
2708
2709 2018-08-21  Daniel Bates  <dabates@apple.com>
2710
2711         [iOS][WK1] Support toggling continuous spell checking from tests
2712         https://bugs.webkit.org/show_bug.cgi?id=188763
2713
2714         Reviewed by Simon Fraser.
2715
2716         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2717         spell checking from tests in iOS WebKit Legacy.
2718
2719         * WebCoreSupport/WebEditorClient.h:
2720         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2721         * WebCoreSupport/WebEditorClient.mm:
2722         * WebView/WebView.h:
2723         * WebView/WebView.mm:
2724         (-[WebView toggleContinuousSpellChecking:]):
2725         (-[WebView toggleSmartInsertDelete:]):
2726
2727 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2728
2729         Add some plumbing for safe browsing
2730         https://bugs.webkit.org/show_bug.cgi?id=188709
2731
2732         Reviewed by Tim Horton.
2733
2734         * WebCoreSupport/WebFrameLoaderClient.h:
2735         * WebCoreSupport/WebFrameLoaderClient.mm:
2736         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2737
2738 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2739
2740         Replace canBubble and cancelable booleans in Event by enum classes
2741         https://bugs.webkit.org/show_bug.cgi?id=188692
2742
2743         Reviewed by Alex Christensen.
2744
2745         * WebView/WebPDFView.mm:
2746         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2747         * WebView/WebView.mm:
2748         (-[WebView _dispatchUnloadEvent]):
2749
2750 2018-08-16  Jer Noble  <jer.noble@apple.com>
2751
2752         Add Experimental Feature support for SourceBuffer.changeType()
2753         https://bugs.webkit.org/show_bug.cgi?id=188626
2754         <rdar://problem/43356021>
2755
2756         Reviewed by Eric Carlson.
2757
2758         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2759
2760         * WebView/WebPreferenceKeysPrivate.h:
2761         * WebView/WebPreferences.mm:
2762         (+[WebPreferences initialize]):
2763         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2764         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2765         * WebView/WebPreferencesPrivate.h:
2766         * WebView/WebView.mm:
2767         (-[WebView _preferencesChanged:]):
2768
2769 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2770
2771         Support drag-and-drop for input[type=color]
2772         https://bugs.webkit.org/show_bug.cgi?id=188464
2773
2774         Reviewed by Wenson Hsieh.
2775
2776         * WebCoreSupport/WebPlatformStrategies.h:
2777         * WebCoreSupport/WebPlatformStrategies.mm:
2778         (WebPlatformStrategies::setColor):
2779
2780 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2781
2782         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2783         https://bugs.webkit.org/show_bug.cgi?id=188569
2784         <rdar://problem/34201095>
2785
2786         Reviewed by Megan Gardner.
2787
2788         * WebView/WebImmediateActionController.mm:
2789         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2790         Speculative fix; the crashes indicate font is null, but we just checked it,
2791         so it must be getting made null by convertFont:toSize:. Check again!
2792
2793 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2794
2795         Use a 1-byte enum class for TextDirection
2796         https://bugs.webkit.org/show_bug.cgi?id=188350
2797
2798         Reviewed by Simon Fraser.
2799
2800         * WebCoreSupport/PopupMenuMac.mm:
2801         (PopupMenuMac::populate):
2802         (PopupMenuMac::show):
2803         * WebCoreSupport/WebFrameLoaderClient.mm:
2804         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2805         * WebView/WebFrame.mm:
2806         (-[WebFrame _dispatchDidReceiveTitle:]):
2807
2808 2018-08-09  Ali Juma  <ajuma@chromium.org>
2809
2810         Import WPTs for IntersectionObserver
2811         https://bugs.webkit.org/show_bug.cgi?id=188416
2812
2813         Reviewed by Simon Fraser.
2814
2815         * WebView/WebPreferencesPrivate.h:
2816
2817 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2818
2819         Follow-up build fix for r234685
2820         https://bugs.webkit.org/show_bug.cgi?id=188245
2821
2822         Unreviewed build fix.
2823
2824         * WebCoreSupport/WebSecurityOriginPrivate.h:
2825
2826 2018-08-05  Darin Adler  <darin@apple.com>
2827
2828         [Cocoa] More tweaks and refactoring to prepare for ARC
2829         https://bugs.webkit.org/show_bug.cgi?id=188245
2830
2831         Reviewed by Dan Bernstein.
2832
2833         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2834
2835         * Carbon/CarbonWindowFrame.m:
2836         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2837
2838         * DOM/DOM.mm:
2839         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2840         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2841         garbage collection so this method isn't useful.
2842
2843         * DOM/DOMXPath.mm:
2844         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2845         Objective-C garbage collection so this method isn't useful.
2846
2847         * History/WebHistory.mm:
2848         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2849
2850         * Misc/WebElementDictionary.mm:
2851         (addLookupKey): Use a bridging cast.
2852         (cacheValueForKey): Ditto.
2853         (-[WebElementDictionary _fillCache]): Ditto.
2854         (-[WebElementDictionary objectForKey:]): Ditto.
2855
2856         * Misc/WebKitNSStringExtras.mm:
2857         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2858         (-[NSString _web_widthWithFont:]): Ditto.
2859         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2860
2861         * Misc/WebLocalizableStrings.mm:
2862         (WebLocalizedString): Use a bridging cast.
2863
2864         * Misc/WebNSDataExtras.mm:
2865         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2866         and use CFBridgingRelease instead of calling autorelease directly.
2867         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2868         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2869         on the amount of explicit release and autorelease.
2870
2871         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2872         * Misc/WebNSDictionaryExtras.m:
2873         (-[NSDictionary _webkit_intForKey:]): Deleted.
2874         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2875         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2876         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2877         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2878         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2879         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2880
2881         * Misc/WebStringTruncator.mm:
2882         (fontFromNSFont): Use a bridging cast.
2883
2884         * Plugins/Hosted/NetscapePluginHostManager.mm:
2885         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2886
2887         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2888         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2889         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2890         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2891         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2892         * Plugins/Hosted/ProxyInstance.mm:
2893         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2894         * Plugins/WebBasePluginPackage.mm:
2895         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2896         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2897         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2898         * Plugins/WebNetscapePluginPackage.mm:
2899         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2900
2901         * Plugins/WebNetscapePluginView.mm:
2902         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2903         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2904         (-[WebNetscapePluginView status:]): Use a bridging cast.
2905         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2906
2907         * Plugins/WebPluginController.mm:
2908         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2909
2910         * Plugins/WebPluginDatabase.mm:
2911         (checkCandidate): Use explicit __strong for out argument types.
2912
2913         * Plugins/npapi.mm:
2914         (pluginViewForInstance): Use a bridging cast.
2915
2916         * Storage/WebDatabaseManager.mm:
2917         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2918         explicit NSNumber and NSDictionary calls.
2919
2920         * WebCoreSupport/WebContextMenuClient.mm:
2921         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2922
2923         * WebCoreSupport/WebEditorClient.mm:
2924         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2925         (WebEditorClient::handleInputMethodKeydown): Ditto.
2926
2927         * WebCoreSupport/WebFrameNetworkingContext.mm:
2928         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2929
2930         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2931         as a struct rather than an Objective-C class, since that's how it's defined.
2932
2933         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2934
2935         * WebView/WebFullScreenController.mm:
2936         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2937         * WebView/WebHTMLView.mm:
2938         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2939         Ditto.
2940         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2941
2942         * WebView/WebImmediateActionController.mm:
2943         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2944         go down to the document and then back to the frame.
2945         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2946         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2947         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2948
2949         * WebView/WebJSPDFDoc.mm:
2950         (jsPDFDocInitialize): Removed some unneeded type casting.
2951         (jsPDFDocFinalize): Ditto.
2952         (jsPDFDocPrint): Use a bridging cast.
2953
2954         * WebView/WebPDFView.mm:
2955         (_applicationInfoForMIMEType): Use bridging casts.
2956
2957         * WebView/WebPreferences.mm:
2958         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2959         instead of methods from WebNSDictionaryExtras.
2960         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2961         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2962         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2963         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2964         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2965
2966         * WebView/WebView.mm:
2967         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2968         (-[WebView _addToAllWebViewsSet]): Ditto.
2969         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2970         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2971         so it can be called from WebViewData methods.
2972
2973         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2974         method, _windowVisibilityChanged:.
2975
2976         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2977         called from WebViewData methods.
2978
2979 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2980
2981         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2982         https://bugs.webkit.org/show_bug.cgi?id=188323
2983
2984         Reviewed by Simon Fraser.
2985
2986         * WebCoreSupport/WebContextMenuClient.mm:
2987         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2988         * WebView/WebFrame.mm:
2989         (-[WebFrame _paintBehaviorForDestinationContext:]):
2990         (-[WebFrame _drawRect:contentsOnly:]):
2991         * WebView/WebHTMLView.mm:
2992         (imageFromRect):
2993         (selectionImage):
2994
2995 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2996
2997         Add support for microtasks in workers
2998         https://bugs.webkit.org/show_bug.cgi?id=188246
2999
3000         Reviewed by Darin Adler.
3001
3002         Rename JSMainThreadExecState.h to JSExecState.h.
3003
3004         * DOM/DOMAttr.mm:
3005         * DOM/DOMBlob.mm:
3006         * DOM/DOMCDATASection.mm:
3007         * DOM/DOMCSSCharsetRule.mm:
3008         * DOM/DOMCSSFontFaceRule.mm:
3009         * DOM/DOMCSSImportRule.mm:
3010         * DOM/DOMCSSMediaRule.mm:
3011         * DOM/DOMCSSPageRule.mm:
3012         * DOM/DOMCSSPrimitiveValue.mm:
3013         * DOM/DOMCSSRule.mm:
3014         * DOM/DOMCSSRuleList.mm:
3015         * DOM/DOMCSSStyleDeclaration.mm:
3016         * DOM/DOMCSSStyleRule.mm:
3017         * DOM/DOMCSSStyleSheet.mm:
3018         * DOM/DOMCSSUnknownRule.mm:
3019         * DOM/DOMCSSValue.mm:
3020         * DOM/DOMCSSValueList.mm:
3021         * DOM/DOMCharacterData.mm:
3022         * DOM/DOMComment.mm:
3023         * DOM/DOMCounter.mm:
3024         * DOM/DOMDocument.mm:
3025         * DOM/DOMDocumentFragment.mm:
3026         * DOM/DOMDocumentType.mm:
3027         * DOM/DOMElement.mm:
3028         * DOM/DOMEvent.mm:
3029         * DOM/DOMFile.mm:
3030         * DOM/DOMFileList.mm:
3031         * DOM/DOMHTML.mm:
3032         * DOM/DOMHTMLAnchorElement.mm:
3033         * DOM/DOMHTMLAppletElement.mm:
3034         * DOM/DOMHTMLAreaElement.mm:
3035         * DOM/DOMHTMLBRElement.mm:
3036         * DOM/DOMHTMLBaseElement.mm:
3037         * DOM/DOMHTMLBaseFontElement.mm:
3038         * DOM/DOMHTMLBodyElement.mm:
3039         * DOM/DOMHTMLButtonElement.mm:
3040         * DOM/DOMHTMLCanvasElement.mm:
3041         * DOM/DOMHTMLCollection.mm:
3042         * DOM/DOMHTMLDListElement.mm:
3043         * DOM/DOMHTMLDirectoryElement.mm:
3044         * DOM/DOMHTMLDivElement.mm:
3045         * DOM/DOMHTMLDocument.mm:
3046         * DOM/DOMHTMLElement.mm:
3047         * DOM/DOMHTMLEmbedElement.mm:
3048         * DOM/DOMHTMLFieldSetElement.mm:
3049         * DOM/DOMHTMLFontElement.mm:
3050         * DOM/DOMHTMLFormElement.mm:
3051         * DOM/DOMHTMLFrameElement.mm:
3052         * DOM/DOMHTMLFrameSetElement.mm:
3053         * DOM/DOMHTMLHRElement.mm:
3054         * DOM/DOMHTMLHeadElement.mm:
3055         * DOM/DOMHTMLHeadingElement.mm:
3056         * DOM/DOMHTMLHtmlElement.mm:
3057         * DOM/DOMHTMLIFrameElement.mm:
3058         * DOM/DOMHTMLImageElement.mm:
3059         * DOM/DOMHTMLInputElement.mm:
3060         * DOM/DOMHTMLLIElement.mm:
3061         * DOM/DOMHTMLLabelElement.mm:
3062         * DOM/DOMHTMLLegendElement.mm:
3063         * DOM/DOMHTMLLinkElement.mm:
3064         * DOM/DOMHTMLMapElement.mm:
3065         * DOM/DOMHTMLMarqueeElement.mm:
3066         * DOM/DOMHTMLMediaElement.mm:
3067         * DOM/DOMHTMLMenuElement.mm:
3068         * DOM/DOMHTMLMetaElement.mm:
3069         * DOM/DOMHTMLModElement.mm:
3070         * DOM/DOMHTMLOListElement.mm:
3071         * DOM/DOMHTMLObjectElement.mm:
3072         * DOM/DOMHTMLOptGroupElement.mm:
3073         * DOM/DOMHTMLOptionElement.mm:
3074         * DOM/DOMHTMLOptionsCollection.mm:
3075         * DOM/DOMHTMLParagraphElement.mm:
3076         * DOM/DOMHTMLParamElement.mm:
3077         * DOM/DOMHTMLPreElement.mm:
3078         * DOM/DOMHTMLQuoteElement.mm:
3079         * DOM/DOMHTMLScriptElement.mm:
3080         * DOM/DOMHTMLSelectElement.mm:
3081         * DOM/DOMHTMLStyleElement.mm:
3082         * DOM/DOMHTMLTableCaptionElement.mm:
3083         * DOM/DOMHTMLTableCellElement.mm:
3084         * DOM/DOMHTMLTableColElement.mm:
3085         * DOM/DOMHTMLTableElement.mm:
3086         * DOM/DOMHTMLTableRowElement.mm:
3087         * DOM/DOMHTMLTableSectionElement.mm:
3088         * DOM/DOMHTMLTextAreaElement.mm:
3089         * DOM/DOMHTMLTitleElement.mm:
3090         * DOM/DOMHTMLUListElement.mm:
3091         * DOM/DOMHTMLVideoElement.mm:
3092         * DOM/DOMImplementation.mm:
3093         * DOM/DOMKeyboardEvent.mm:
3094         * DOM/DOMMediaError.mm:
3095         * DOM/DOMMediaList.mm:
3096         * DOM/DOMMouseEvent.mm:
3097         * DOM/DOMMutationEvent.mm:
3098         * DOM/DOMNamedNodeMap.mm:
3099         * DOM/DOMNode.mm:
3100         * DOM/DOMNodeIterator.mm:
3101         * DOM/DOMNodeList.mm:
3102         * DOM/DOMOverflowEvent.mm:
3103         * DOM/DOMProcessingInstruction.mm:
3104         * DOM/DOMProgressEvent.mm:
3105         * DOM/DOMRGBColor.mm:
3106         * DOM/DOMRange.mm:
3107         * DOM/DOMRect.mm:
3108         * DOM/DOMStyleSheet.mm:
3109         * DOM/DOMStyleSheetList.mm:
3110         * DOM/DOMText.mm:
3111         * DOM/DOMTextEvent.mm:
3112         * DOM/DOMTimeRanges.mm:
3113         * DOM/DOMTokenList.mm:
3114         * DOM/DOMTreeWalker.mm:
3115         * DOM/DOMUIEvent.mm:
3116         * DOM/DOMWheelEvent.mm:
3117         * DOM/DOMXPathExpression.mm:
3118         * DOM/DOMXPathResult.mm:
3119         * DOM/ObjCEventListener.mm:
3120
3121 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3122
3123         Fix spelling of "overridden"
3124         https://bugs.webkit.org/show_bug.cgi?id=188315
3125
3126         Reviewed by Darin Adler.
3127
3128         * Misc/WebKitVersionChecks.mm:
3129         (setWebKitLinkTimeVersion):
3130         (WebKitLinkTimeVersion):
3131         * Plugins/WebBaseNetscapePluginView.mm:
3132         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3133         * WebCoreSupport/PopupMenuMac.mm:
3134         (PopupMenuMac::populate):
3135
3136 2018-08-01  Nan Wang  <n_wang@apple.com>
3137
3138         AX: AOM: Add ARIA IDL Attribute Reflection
3139         https://bugs.webkit.org/show_bug.cgi?id=184676
3140         <rdar://problem/39476882>
3141
3142         Reviewed by Chris Fleizach.
3143
3144         * WebView/WebPreferenceKeysPrivate.h:
3145         * WebView/WebPreferences.mm:
3146         (+[WebPreferences initialize]):
3147         (-[WebPreferences ariaReflectionEnabled]):
3148         (-[WebPreferences setAriaReflectionEnabled:]):
3149         * WebView/WebPreferencesPrivate.h:
3150         * WebView/WebView.mm:
3151         (-[WebView _preferencesChanged:]):
3152
3153 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3154
3155         Shrink GraphicsLayerCA
3156         https://bugs.webkit.org/show_bug.cgi?id=188141
3157
3158         Reviewed by Zalan Bujtas.
3159
3160         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3161         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3162         * moving all the animation-related stuff into the lazily-allocated m_animations
3163         * making enums be 8-bit
3164         * re-ordering data members
3165
3166         * WebView/WebView.mm:
3167         (-[WebView _setMediaLayer:forPluginView:]):
3168
3169 2018-07-30  Rob Buis  <rbuis@igalia.com>
3170
3171         Merge PlatformCookieJar functions into NetworkStorageSession
3172         https://bugs.webkit.org/show_bug.cgi?id=188137
3173
3174         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3175
3176         Reviewed by Alex Christensen.
3177
3178         * WebCoreSupport/WebPlatformStrategies.mm:
3179         (WebPlatformStrategies::cookiesForDOM):
3180         (WebPlatformStrategies::setCookiesFromDOM):
3181         (WebPlatformStrategies::cookiesEnabled):
3182         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3183         (WebPlatformStrategies::getRawCookies):
3184         (WebPlatformStrategies::deleteCookie):
3185         * WebView/WebPreferences.mm:
3186         (+[WebPreferences _clearNetworkLoaderSession]):
3187
3188 2018-07-28  Darin Adler  <darin@apple.com>
3189
3190         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3191         https://bugs.webkit.org/show_bug.cgi?id=188140
3192
3193         Reviewed by Sam Weinig.
3194
3195         * WebView/WebImmediateActionController.mm:
3196         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3197         new DictionaryLookup function that returns a tuple instead of using an out argument.
3198
3199 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3200
3201         [INTL] Remove INTL sub-feature compile flags
3202         https://bugs.webkit.org/show_bug.cgi?id=188081
3203
3204         Reviewed by Michael Catanzaro.
3205
3206         * Configurations/FeatureDefines.xcconfig:
3207
3208 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3209
3210         Unreviewed, rolling out r234181 and r234189.
3211         https://bugs.webkit.org/show_bug.cgi?id=188075
3212
3213         These are not needed right now (Requested by thorton on
3214         #webkit).
3215
3216         Reverted changesets:
3217
3218         "Enable Web Content Filtering on watchOS"
3219         https://bugs.webkit.org/show_bug.cgi?id=187979
3220         https://trac.webkit.org/changeset/234181
3221
3222         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3223         https://bugs.webkit.org/show_bug.cgi?id=187985
3224         https://trac.webkit.org/changeset/234189
3225
3226 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3227
3228         Use the Page's appearance when converting pasteboard attributed strings.
3229         https://bugs.webkit.org/show_bug.cgi?id=188067
3230         rdar://problem/42632246
3231
3232         Reviewed by Wenson Hsieh.
3233
3234         * WebCoreSupport/WebEditorClient.mm:
3235         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3236
3237 2018-07-25  Chris Dumez  <cdumez@apple.com>
3238
3239         navigator.userAgent may return outdated value after webView.customUserAgent is set
3240         https://bugs.webkit.org/show_bug.cgi?id=188009
3241         <rdar://problem/42566456>
3242
3243         Reviewed by Alex Christensen.
3244
3245         Let the page know when the user agent changes.
3246
3247         * WebView/WebView.mm:
3248         (-[WebView _preferencesChanged:]):
3249         (-[WebView setApplicationNameForUserAgent:]):
3250         (-[WebView _invalidateUserAgentCache]):
3251         (-[WebView setCustomUserAgent:]):
3252         * WebView/WebViewInternal.h:
3253
3254 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3255
3256         Enable Web Content Filtering on watchOS
3257         https://bugs.webkit.org/show_bug.cgi?id=187979
3258         <rdar://problem/42559346>
3259
3260         Reviewed by Wenson Hsieh.
3261
3262         * Configurations/FeatureDefines.xcconfig:
3263
3264 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3265
3266         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3267         https://bugs.webkit.org/show_bug.cgi?id=187846
3268
3269         Reviewed by Simon Fraser.
3270
3271         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3272
3273         * WebView/WebHTMLView.mm:
3274         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3275         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3276
3277 2018-07-11  Dean Jackson  <dino@apple.com>
3278
3279         Allow removal of white backgrounds
3280         https://bugs.webkit.org/show_bug.cgi?id=187574
3281         <rdar://problem/41146792>
3282
3283         Reviewed by Simon Fraser.
3284
3285         Add a new WebPreference for punching out white backgrounds.
3286
3287         * WebView/WebPreferenceKeysPrivate.h:
3288         * WebView/WebPreferences.mm:
3289         (+[WebPreferences initialize]):
3290         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3291         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3292         * WebView/WebPreferencesPrivate.h:
3293         * WebView/WebView.mm:
3294         (-[WebView _preferencesChanged:]):
3295
3296 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3297
3298         Ensure WebKit stack is ad-hoc signed
3299         https://bugs.webkit.org/show_bug.cgi?id=187667
3300
3301         Reviewed by Alexey Proskuryakov.
3302
3303         * Configurations/Base.xcconfig:
3304
3305 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3306
3307         REGRESSION (231276): Attempting to copy an image fails
3308         https://bugs.webkit.org/show_bug.cgi?id=187212
3309         <rdar://problem/41540074>
3310
3311         Reviewed by Ryosuke Niwa.
3312
3313         Renamed methods to make it clear that one URL and one title are being passed in.
3314
3315         * WebCoreSupport/WebPlatformStrategies.h:
3316         * WebCoreSupport/WebPlatformStrategies.mm:
3317         (WebPlatformStrategies::setURL):
3318
3319 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3320
3321         Disable cross-origin-window-policy by default
3322         https://bugs.webkit.org/show_bug.cgi?id=187509
3323
3324         Reviewed by Chris Dumez.
3325
3326         * WebView/WebPreferences.mm:
3327         (+[WebPreferences initialize]):
3328
3329 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3330
3331         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3332         https://bugs.webkit.org/show_bug.cgi?id=187425
3333         rdar://problem/39948240
3334
3335         Reviewed by Tim Horton.
3336
3337         * WebView/WebView.mm:
3338         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3339         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3340         a call in this method to setUseDarkAppearance.
3341         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3342         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3343         (-[WebView _updateDefaultAppearance]): Deleted.
3344         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3345
3346 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3347
3348         Shrink various loading-related enums to shrink CachedResource
3349         https://bugs.webkit.org/show_bug.cgi?id=187443
3350
3351         Reviewed by Chris Dumez.
3352
3353         * WebCoreSupport/WebFrameLoaderClient.mm:
3354         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3355         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3356         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3357         (WebFrameLoaderClient::dispatchWillSendRequest):
3358         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3359         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3360         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3361         (WebFrameLoaderClient::updateGlobalHistory):
3362         (WebFrameLoaderClient::canHandleRequest const):
3363         * WebView/WebDataSource.mm:
3364         (-[WebDataSource initialRequest]):
3365         (-[WebDataSource request]):
3366
3367 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3368
3369         Unreviewed, rolling out r233612.
3370         https://bugs.webkit.org/show_bug.cgi?id=187475
3371
3372         Revision caused the api test LinkColorWithSystemAppearance to
3373         fail on all systems. (Requested by Truitt on #webkit).
3374
3375         Reverted changeset:
3376
3377         "Semantic colors don't update when accessibility Increase
3378         Contrast mode is enabled."
3379         https://bugs.webkit.org/show_bug.cgi?id=187425
3380         https://trac.webkit.org/changeset/233612
3381
3382 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3383
3384         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3385         https://bugs.webkit.org/show_bug.cgi?id=187425
3386         rdar://problem/39948240
3387
3388         Reviewed by Tim Horton.
3389
3390         * WebView/WebView.mm:
3391         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3392         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3393         a call in this method to setUseDarkAppearance.
3394         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3395         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3396         (-[WebView _updateDefaultAppearance]): Deleted.
3397         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3398
3399 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3400
3401         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3402         https://bugs.webkit.org/show_bug.cgi?id=187369
3403         rdar://problem/41870420
3404
3405         Reviewed by Tim Horton.
3406
3407         * WebView/WebMediaPlaybackTargetPicker.mm:
3408         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3409         * WebView/WebView.mm:
3410         (-[WebView _commonInitializationWithFrameName:groupName:]):
3411         (-[WebView _effectiveAppearanceIsDark]):
3412         (-[WebView _updateDefaultAppearance]):
3413         (-[WebView _defaultAppearance]): Deleted.
3414
3415 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3416
3417         Youtube video pages crash after a couple of minutes
3418         https://bugs.webkit.org/show_bug.cgi?id=187316
3419
3420         Reviewed by Antti Koivisto.
3421
3422         * WebView/WebView.mm:
3423         (-[WebView _preferencesChanged:]):
3424
3425 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3426
3427         Introduce PLATFORM(IOSMAC)
3428         https://bugs.webkit.org/show_bug.cgi?id=187315
3429
3430         Reviewed by Dan Bernstein.
3431
3432         * Configurations/Base.xcconfig:
3433         * Configurations/FeatureDefines.xcconfig:
3434
3435 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3436
3437         [iOS] DataTransfer.getData always returns the empty string when dropping text
3438         https://bugs.webkit.org/show_bug.cgi?id=187130
3439         <rdar://problem/41014117>
3440
3441         Reviewed by Ryosuke Niwa.
3442
3443         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3444
3445         * WebCoreSupport/WebPlatformStrategies.h:
3446         * WebCoreSupport/WebPlatformStrategies.mm:
3447         (WebPlatformStrategies::allPasteboardItemInfo):
3448
3449 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3450
3451         [Mac] AirPlay picker uses incorrect theme in Dark mode
3452         https://bugs.webkit.org/show_bug.cgi?id=187054
3453         <rdar://problem/41291093>
3454
3455         Reviewed by Timothy Hatcher.
3456
3457         * WebView/WebMediaPlaybackTargetPicker.mm:
3458         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3459
3460 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3461
3462         [WTF] Add user-defined literal for ASCIILiteral
3463         https://bugs.webkit.org/show_bug.cgi?id=186839
3464
3465         Reviewed by Darin Adler.
3466
3467         * DOM/ExceptionHandlers.mm:
3468         (raiseDOMErrorException):
3469         * Plugins/Hosted/ProxyInstance.mm:
3470         (WebKit::ProxyInstance::invokeMethod):
3471         * Storage/WebDatabaseProvider.mm:
3472         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3473
3474 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3475
3476         Recalc styles every time defaultAppearance changes.
3477         https://bugs.webkit.org/show_bug.cgi?id=186866
3478         rdar://problem/41309805
3479
3480         Reviewed by Tim Horton.
3481
3482         * WebView/WebView.mm:
3483         (-[WebView _updateDefaultAppearance]):
3484         (-[WebView _setUseSystemAppearance:]):
3485         (-[WebView _useSystemAppearance]):
3486
3487 2018-06-20  Darin Adler  <darin@apple.com>
3488
3489         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3490         https://bugs.webkit.org/show_bug.cgi?id=186875
3491
3492         Reviewed by Anders Carlsson.
3493
3494         * WebView/WebHTMLView.mm:
3495         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3496         to write te file to.
3497         * WebView/WebPreferences.mm:
3498         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3499         * WebView/WebView.mm:
3500         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3501
3502 2018-06-12  Darin Adler  <darin@apple.com>
3503
3504         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3505         https://bugs.webkit.org/show_bug.cgi?id=186526
3506
3507         Reviewed by Anders Carlsson.
3508
3509         * Plugins/Hosted/NetscapePluginHostManager.mm:
3510         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3511
3512         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3513         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3514         assignment rather than adoptNS/leakRef.
3515         * Plugins/WebNetscapePluginView.mm:
3516         (-[WebNetscapePluginView createPlugin]): Ditto.
3517
3518         * WebCoreSupport/WebContextMenuClient.mm:
3519         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3520         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3521         argument, so use RetainPtr::get instead.
3522
3523         * WebView/WebHTMLView.mm:
3524         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3525         No need to autorelease the result when the return type is RetainPtr.
3526
3527         * WebView/WebPDFRepresentation.mm:
3528         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3529
3530 2018-06-13  Youenn Fablet  <youenn@apple.com>
3531
3532         Supported plugin check should be based on plugin identifier
3533         https://bugs.webkit.org/show_bug.cgi?id=186578
3534         <rdar://problem/40523828>
3535
3536         Reviewed by Darin Adler.
3537
3538         * WebCoreSupport/WebPluginInfoProvider.h:
3539         * WebCoreSupport/WebPluginInfoProvider.mm:
3540         (WebPluginInfoProvider::pluginInfo):
3541         (WebPluginInfoProvider::webVisiblePluginInfo):
3542
3543 2018-06-13  Chris Dumez  <cdumez@apple.com>
3544
3545         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3546         https://bugs.webkit.org/show_bug.cgi?id=186545
3547
3548         Reviewed by Brady Eidson.
3549
3550         Update client delegate now that parameter type has changed.
3551
3552         * WebCoreSupport/WebFrameLoaderClient.h:
3553         * WebCoreSupport/WebFrameLoaderClient.mm:
3554         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3555
3556 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3557
3558         Link drag image is inconsistently unreadable in dark mode
3559         https://bugs.webkit.org/show_bug.cgi?id=186472
3560
3561         Reviewed by Timothy Hatcher.
3562
3563         * WebView/WebView.mm:
3564         (-[WebView _defaultAppearance]):
3565         Make defaultAppearance accurate even if useSystemAppearance is false.
3566         Some parts of WebKit (like the link drag image, but also context menus)
3567         want to be able to follow the system appearance regardless of whether
3568         the view or content has opted in.
3569
3570 2018-06-11  Chris Dumez  <cdumez@apple.com>
3571
3572         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3573         https://bugs.webkit.org/show_bug.cgi?id=186441
3574
3575         Reviewed by Brady Eidson.
3576
3577         Rename existing flag to something a bit more generic, now that it is used for
3578         more things than bypassing the navigation policy check.
3579
3580         * WebView/WebView.mm:
3581         (-[WebView _loadBackForwardListFromOtherView:]):
3582         (-[WebView goToBackForwardItem:]):
3583
3584 2018-06-09  Dan Bernstein  <mitz@apple.com>
3585
3586         [Xcode] Clean up and modernize some build setting definitions
3587         https://bugs.webkit.org/show_bug.cgi?id=186463
3588
3589         Reviewed by Sam Weinig.
3590
3591         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3592         * Configurations/DebugRelease.xcconfig: Ditto.
3593         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3594           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3595         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3596         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3597           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3598         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3599
3600 2018-06-08  Darin Adler  <darin@apple.com>
3601
3602         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3603         https://bugs.webkit.org/show_bug.cgi?id=186436
3604
3605         Reviewed by Anders Carlsson.
3606
3607         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3608         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3609         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3610         (PoolCleaner): Ditto.
3611
3612         * History/WebHistory.mm:
3613         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3614         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3615         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3616         now hardly used if at all.
3617         * WebView/WebView.mm:
3618         (-[WebView rectsForTextMatches]): Ditto.
3619
3620 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3621
3622         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3623         https://bugs.webkit.org/show_bug.cgi?id=186442
3624         <rdar://problem/40879364>
3625
3626         Reviewed by Tim Horton.
3627
3628         * Configurations/FeatureDefines.xcconfig:
3629
3630 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3631
3632         [Datalist] Allow TextFieldInputType to show and hide suggestions
3633         https://bugs.webkit.org/show_bug.cgi?id=186151
3634
3635         Reviewed by Tim Horton.
3636
3637         * WebCoreSupport/WebChromeClient.h:
3638         * WebCoreSupport/WebChromeClient.mm:
3639         (WebChromeClient::createDataListSuggestionPicker):
3640
3641 2018-06-07  Chris Dumez  <cdumez@apple.com>
3642
3643         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3644         https://bugs.webkit.org/show_bug.cgi?id=186407
3645
3646         Reviewed by Brent Fulgham.
3647
3648         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3649         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3650         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3651         makeWeakPtr().
3652
3653         * WebCoreSupport/WebEditorClient.h:
3654         * WebCoreSupport/WebEditorClient.mm:
3655         (WebEditorClient::requestCandidatesForSelection):
3656
3657 2018-06-05  Chris Dumez  <cdumez@apple.com>
3658
3659         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3660         https://bugs.webkit.org/show_bug.cgi?id=186331
3661         <rdar://problem/40735446>
3662
3663         Reviewed by Darin Adler.
3664
3665         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3666         but does not call use / ignore on the listener, then we would do "use" by default.
3667         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3668         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3669         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3670         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3671         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3672         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3673         and Box.app is still working properly.
3674
3675         * WebCoreSupport/WebFrameLoaderClient.h:
3676         * WebCoreSupport/WebFrameLoaderClient.mm:
3677         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3678         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3679         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3680         (WebFrameLoaderClient::dispatchWillSubmitForm):
3681         (WebFrameLoaderClient::setUpPolicyListener):
3682         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3683         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3684         (-[WebFramePolicyListener dealloc]):
3685         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3686         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3687
3688 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3689
3690         Adjust compile and runtime flags to match shippable state of features
3691         https://bugs.webkit.org/show_bug.cgi?id=186319
3692         <rdar://problem/40352045>
3693
3694         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3695
3696         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3697         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3698         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3699         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3700         Cocoa builds.
3701
3702 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3703
3704         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3705
3706         https://bugs.webkit.org/show_bug.cgi?id=186323
3707         rdar://problem/38382252
3708
3709         Reviewed by Tim Horton.
3710
3711         * WebView/WebView.mm:
3712         (-[WebView _defaultAppearance]):
3713
3714 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3715
3716         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3717         https://bugs.webkit.org/show_bug.cgi?id=186286
3718         <rdar://problem/40782992>
3719
3720         Reviewed by Dan Bernstein.
3721
3722         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3723         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3724         change this flag when preparing for a production release.
3725
3726         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3727         whether experimental features should be enabled, and use it to properly define the
3728         feature flag.
3729
3730 2018-06-03  Darin Adler  <darin@apple.com>
3731
3732         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3733         https://bugs.webkit.org/show_bug.cgi?id=186258
3734
3735         Reviewed by Daniel Bates.
3736
3737         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3738         forward declarations. Removed methods that don't need to be public.
3739
3740         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3741         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3742         unnamed category in here and also replaced the HUDWindowControllerDelegate
3743         with the unnamed category. Removed unused NSWindow category defining the
3744         isOnActiveSpace, which is not called anywhere in this file at this time.
3745         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3746         into setVideoElement.
3747         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3748         and removed unneeded typecast.
3749         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3750         using statement at the top of the file.
3751         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3752         the many side effects and special considerations that this method that sounds
3753         like a setter has. Updated code to use the new
3754         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3755         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3756         bit and added some FIXME comments about small problems noticed but not fixed.
3757         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3758         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3759         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3760         typecast. Removed call to updatePowerAssertions method.
3761         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3762         updatePowerAssertions method.
3763         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3764         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3765         else, so this was dead code that did nothing.
3766         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3767         updatePowerAssertions method.
3768
3769 2018-06-04  Chris Dumez  <cdumez@apple.com>
3770
3771         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3772         https://bugs.webkit.org/show_bug.cgi?id=186287
3773         <rdar://problem/40783352>
3774
3775         Reviewed by Youenn Fablet.
3776
3777         * WebView/WebPreferenceKeysPrivate.h:
3778         * WebView/WebPreferences.mm:
3779         (+[WebPreferences initialize]):
3780         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3781         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3782         * WebView/WebPreferencesPrivate.h:
3783         * WebView/WebView.mm:
3784         (-[WebView _preferencesChanged:]):
3785
3786 2018-06-02  Darin Adler  <darin@apple.com>
3787
3788         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3789         https://bugs.webkit.org/show_bug.cgi?id=186227
3790
3791         Reviewed by Dan Bernstein.
3792
3793         * Misc/WebKitErrors.m:
3794         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3795         * Plugins/WebPluginDatabase.mm:
3796         (-[WebPluginDatabase refresh]): Ditto.
3797         * WebCoreSupport/WebChromeClient.mm:
3798         (WebChromeClient::setStatusbarText): Ditto.
3799
3800 2018-06-01  Chris Dumez  <cdumez@apple.com>
3801
3802         REGRESSION (r231456): Colloquy is broken
3803         https://bugs.webkit.org/show_bug.cgi?id=186197
3804         <rdar://problem/40722960>
3805
3806         Reviewed by Timothy Hatcher.
3807
3808         Restore pre-r231456 behavior for Colloquy app so that it works again.
3809
3810         * WebView/WebView.mm:
3811         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3812         (-[WebView _preferencesChanged:]):
3813
3814 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3815
3816         [JSC] Pass VM& parameter as much as possible
3817         https://bugs.webkit.org/show_bug.cgi?id=186085
3818
3819         Reviewed by Saam Barati.
3820
3821         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3822         (WebKit::NetscapePluginInstanceProxy::invoke):
3823
3824 2018-05-30  Daniel Bates  <dabates@apple.com>
3825
3826         NavigationAction does not need to hold initiating DOM Event
3827         https://bugs.webkit.org/show_bug.cgi?id=185958
3828         <rdar://problem/40531539>
3829
3830         Reviewed by Simon Fraser.
3831
3832         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3833
3834         * WebCoreSupport/WebFrameLoaderClient.mm:
3835         (WebFrameLoaderClient::actionDictionary const):
3836         (findMouseEvent): Deleted.
3837
3838 2018-05-27  Dan Bernstein  <mitz@apple.com>
3839
3840         Reverted the changes made for https://webkit.org/b/186016
3841
3842         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3843
3844
3845 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3846
3847         [iOS] Fix warnings about leaks found by clang static analyzer
3848         <https://webkit.org/b/186009>
3849         <rdar://problem/40574267>
3850
3851         Reviewed by Daniel Bates.
3852
3853         * WebView/WebHTMLView.mm:
3854         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3855         uninitialized boolean variable (`eventWasHandled`) that only
3856         happened on iOS.
3857
3858 2018-05-27  Dan Bernstein  <mitz@apple.com>
3859
3860         [Cocoa] Avoid importing directly from subumbrella frameworks
3861         https://bugs.webkit.org/show_bug.cgi?id=186016
3862
3863         Reviewed by Sam Weinig.
3864
3865         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3866         * Carbon/CarbonWindowAdapter.mm: Ditto.
3867         * Carbon/CarbonWindowFrame.m: Ditto.
3868         * Carbon/HIViewAdapter.h: Ditto.
3869         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3870           OTHER_CPLUSPLUSFLAGS.
3871         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3872         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3873         * WebView/WebPDFView.h: Ditto.
3874
3875 2018-05-27  Sam Weinig  <sam@webkit.org>
3876
3877         Modernize RenderStyleConstants.h - Part 3
3878         https://bugs.webkit.org/show_bug.cgi?id=186015
3879
3880         Reviewed by Yusuke Suzuki.
3881
3882         * WebView/WebView.mm:
3883         (-[WebView updateTextTouchBar]):
3884         Update for new enum name.
3885
3886 2018-05-25  Chris Dumez  <cdumez@apple.com>
3887
3888         Minor ApplicationCacheStorage clean up
3889         https://bugs.webkit.org/show_bug.cgi?id=185984
3890
3891         Reviewed by Youenn Fablet.
3892
3893         * WebCoreSupport/WebApplicationCache.mm:
3894         (+[WebApplicationCache originsWithCache]):
3895
3896 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3897
3898         Fix issues with -dealloc methods found by clang static analyzer
3899         <https://webkit.org/b/185887>
3900
3901         Reviewed by Joseph Pecoraro.
3902
3903         * WebView/WebView.mm:
3904         (-[WebUITextIndicatorData dealloc]):
3905         - Move method implementation from (WebUITextIndicatorInternal)
3906           category to the main category since this is public API.  This
3907           fixes the false positive warning about a missing -dealloc
3908           method.
3909
3910 2018-05-24  Sam Weinig  <sam@webkit.org>
3911
3912         Modernize RenderStyleConstants.h - Part 2
3913         https://bugs.webkit.org/show_bug.cgi?id=185901
3914
3915         Reviewed by Simon Fraser.
3916
3917         * WebView/WebHTMLRepresentation.mm:
3918         (searchForLabelsBeforeElement):
3919         * WebView/WebView.mm:
3920         (nsTextAlignmentFromRenderStyle):
3921         Update for new enum names.
3922
3923 2018-05-22  Chris Dumez  <cdumez@apple.com>
3924
3925         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3926         https://bugs.webkit.org/show_bug.cgi?id=185832
3927         <rdar://problem/40307871>
3928
3929         Reviewed by Geoffrey Garen.
3930
3931         We used to have a bug where where we would fail to wait for the policy decision for
3932         the navigation response from the client and the load would keep going, racing with
3933         the client's policy decision. If the client did not respond in time, the behavior
3934         would be the same as "Use" policy action.
3935
3936         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3937         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3938         WebKit bug, however, the load would hang because the completion handler for the
3939         decidePolicyForNavigationResponse would never get called.
3940
3941         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3942         instead of retaining it. If the policy listener object gets destroyed because getting
3943         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3944         behavior.
3945
3946         * WebCoreSupport/WebFrameLoaderClient.h:
3947         * WebCoreSupport/WebFrameLoaderClient.mm:
3948         (WebFrameLoaderClient::cancelPolicyCheck):
3949         (WebFrameLoaderClient::setUpPolicyListener):
3950         (-[WebFramePolicyListener dealloc]):
3951
3952 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3953
3954         Unreviewed, rolling out r232052.
3955
3956         Breaks internal builds.
3957
3958         Reverted changeset:
3959
3960         "Use more C++17"
3961         https://bugs.webkit.org/show_bug.cgi?id=185176
3962         https://trac.webkit.org/changeset/232052
3963
3964 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3965
3966         Use more C++17
3967         https://bugs.webkit.org/show_bug.cgi?id=185176
3968
3969         Reviewed by JF Bastien.
3970
3971         * Configurations/Base.xcconfig:
3972         * Configurations/WebKitLegacy.xcconfig:
3973
3974 2018-05-21  Chris Nardi  <cnardi@chromium.org>
3975
3976         Remove dead exception in MediaList.appendMedium
3977         https://bugs.webkit.org/show_bug.cgi?id=185278
3978
3979         Reviewed by Chris Dumez.
3980
3981         Remove code pertaining to an exception being thrown by appendMedium().
3982
3983         * DOM/DOMMediaList.mm:
3984         (-[DOMMediaList appendMedium:]):
3985
3986 2018-05-21  Jer Noble  <jer.noble@apple.com>
3987
3988         Complete fix for enabling modern EME by default
3989         https://bugs.webkit.org/show_bug.cgi?id=185770
3990         <rdar://problem/40368220>
3991
3992         Reviewed by Eric Carlson.
3993
3994         * Configurations/FeatureDefines.xcconfig:
3995
3996 2018-05-21  Antti Koivisto  <antti@apple.com>
3997
3998         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3999         https://bugs.webkit.org/show_bug.cgi?id=185815
4000         <rdar://problem/40310069>
4001
4002         Reviewed by Simon Fraser.
4003
4004         User stylesheet parsing may depend on the colorFilterEnabled preference.
4005
4006         * WebView/WebView.mm:
4007         (-[WebView _preferencesChanged:]):
4008
4009 2018-05-18  Commit Queue  <commit-queue@webkit.org>
4010
4011         Unreviewed, rolling out r231982.
4012         https://bugs.webkit.org/show_bug.cgi?id=185793
4013
4014         Caused layout test failures (Requested by realdawei on
4015         #webkit).
4016
4017         Reverted changeset:
4018
4019         "Complete fix for enabling modern EME by default"
4020         https://bugs.webkit.org/show_bug.cgi?id=185770
4021         https://trac.webkit.org/changeset/231982
4022
4023 2018-05-18  Jer Noble  <jer.noble@apple.com>
4024
4025         Complete fix for enabling modern EME by default
4026         https://bugs.webkit.org/show_bug.cgi?id=185770
4027         <rdar://problem/40368220>
4028
4029         Reviewed by Eric Carlson.
4030
4031         * Configurations/FeatureDefines.xcconfig:
4032
4033 2018-05-18  Chris Dumez  <cdumez@apple.com>
4034
4035         Avoid keeping the frame alive when ref'ing a WindowProxy
4036         https://bugs.webkit.org/show_bug.cgi?id=185737
4037         <rdar://problem/40004666>
4038
4039         Reviewed by Sam Weinig.
4040
4041         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4042         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
4043
4044 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
4045
4046         Add support for Intl NumberFormat formatToParts
4047         https://bugs.webkit.org/show_bug.cgi?id=185375
4048
4049         Reviewed by Yusuke Suzuki.
4050