Add SPI to canonicalize NSURLs with WTF::URL
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2
3         Add SPI to canonicalize NSURLs with WTF::URL
4         https://bugs.webkit.org/show_bug.cgi?id=196415
5         <rdar://problem/44980271>
6
7         Reviewed by Darin Adler.
8
9         * Misc/WebNSURLExtras.h:
10         * Misc/WebNSURLExtras.mm:
11         (-[NSURL _webkit_canonicalize_with_wtf]):
12         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
13         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
14
15 2019-03-31  Sam Weinig  <weinig@apple.com>
16
17         Remove more i386 specific configurations
18         https://bugs.webkit.org/show_bug.cgi?id=196430
19
20         Reviewed by Alexey Proskuryakov.
21
22         * Configurations/FeatureDefines.xcconfig:
23         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
24
25 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
26
27         Delete WebMetal implementation in favor of WebGPU
28         https://bugs.webkit.org/show_bug.cgi?id=195418
29
30         Reviewed by Dean Jackson.
31
32         * Configurations/FeatureDefines.xcconfig:
33         * WebView/WebPreferenceKeysPrivate.h:
34         * WebView/WebPreferences.mm:
35         (+[WebPreferences initialize]):
36         (-[WebPreferences webMetalEnabled]): Deleted.
37         (-[WebPreferences setWebMetalEnabled:]): Deleted.
38         * WebView/WebPreferencesPrivate.h:
39         * WebView/WebView.mm:
40         (-[WebView _preferencesChanged:]):
41
42 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
43
44         Implement ResizeObserver.
45         https://bugs.webkit.org/show_bug.cgi?id=157743
46
47         Reviewed by Simon Fraser.
48
49         * Configurations/FeatureDefines.xcconfig:
50         * WebView/WebPreferenceKeysPrivate.h:
51         * WebView/WebPreferences.mm:
52         (+[WebPreferences initialize]):
53         (-[WebPreferences resizeObserverEnabled]):
54         (-[WebPreferences setResizeObserverEnabled:]):
55         * WebView/WebPreferencesPrivate.h:
56         * WebView/WebView.mm:
57         (-[WebView _preferencesChanged:]):
58         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
59
60 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
61
62         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
63         https://bugs.webkit.org/show_bug.cgi?id=196336
64
65         Reviewed by Tim Horton.
66
67         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
68
69         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
70
71         * WebCoreSupport/PopupMenuMac.mm:
72         (PopupMenuMac::hide):
73
74 2019-03-25  Andy Estes  <aestes@apple.com>
75
76         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
77         https://bugs.webkit.org/show_bug.cgi?id=194964
78         <rdar://problem/48279441>
79
80         Reviewed by Alex Christensen.
81
82         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
83         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
84         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
85         PreviewLoaderClient alive for its lifetime. This ensures that as long as
86         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
87         by WebKit.
88
89         * WebCoreSupport/WebFrameLoaderClient.mm:
90         (WebFrameLoaderClient::createPreviewLoaderClient):
91         * WebView/WebDataSource.mm:
92         (-[WebDataSource _quickLookPreviewLoaderClient]):
93         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
94         * WebView/WebDataSourceInternal.h:
95
96 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
97
98         Remove NavigatorContentUtils in WebCore/Modules
99         https://bugs.webkit.org/show_bug.cgi?id=196070
100
101         Reviewed by Alex Christensen.
102
103         NavigatorContentUtils was to support the custom scheme spec [1].
104         However, in WebKit side, no port has supported the feature in
105         WebKit layer after EFL port was removed. So there has been the
106         only IDL implementation of the NavigatorContentUtils in WebCore.
107         So we don't need to keep the implementation in WebKit.
108
109         * Configurations/FeatureDefines.xcconfig:
110
111 2019-03-22  Keith Rollin  <krollin@apple.com>
112
113         Enable ThinLTO support in Production builds
114         https://bugs.webkit.org/show_bug.cgi?id=190758
115         <rdar://problem/45413233>
116
117         Reviewed by Daniel Bates.
118
119         Enable building with Thin LTO in Production when using Xcode 10.2 or
120         later. This change results in a 1.45% progression in PLT5. Full
121         Production build times increase about 2-3%. Incremental build times
122         are more severely affected, and so LTO is not enabled for local
123         engineering builds.
124
125         LTO is enabled only on macOS for now, until rdar://problem/49013399,
126         which affects ARM builds, is fixed.
127
128         To change the LTO setting when building locally:
129
130         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
131           command line.
132         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
133           on the command line.
134         - If building with `build-root`, specify --lto={none,thin,full} on the
135           command line.
136         - If building with Xcode, create a LocalOverrides.xcconfig file at the
137           top level of your repository directory (if needed) and define
138           WK_LTO_MODE to full, thin, or none.
139
140         * Configurations/Base.xcconfig:
141
142 2019-03-21  Andy Estes  <aestes@apple.com>
143
144         [iOS] Apple Pay should be available in documents with no user agent scripts
145         https://bugs.webkit.org/show_bug.cgi?id=196061
146         <rdar://problem/48649391>
147
148         Reviewed by Brady Eidson.
149
150         * WebView/WebFrame.mm:
151         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
152
153 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
154
155         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
156         https://bugs.webkit.org/show_bug.cgi?id=196049
157
158         Reviewed by Tim Horton.
159
160         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
161         overflow scrolling in general, so rename it.
162
163         * Configurations/FeatureDefines.xcconfig:
164
165 2019-03-13  Dean Jackson  <dino@apple.com>
166
167         Block all plugins smaller than 5x5px
168         https://bugs.webkit.org/show_bug.cgi?id=195702
169         <rdar://problem/28435204>
170
171         Reviewed by Sam Weinig.
172
173         Removed a function that was never being called.
174
175         * WebCoreSupport/WebFrameLoaderClient.h:
176         * WebCoreSupport/WebFrameLoaderClient.mm:
177         (WebFrameLoaderClient::recreatePlugin): Deleted.
178
179 2019-03-13  Keith Rollin  <krollin@apple.com>
180
181         Add support for new StagedFrameworks layout
182         https://bugs.webkit.org/show_bug.cgi?id=195543
183
184         Reviewed by Alexey Proskuryakov.
185
186         When creating the WebKit layout for out-of-band Safari/WebKit updates,
187         use an optional path prefix when called for.
188
189         * Configurations/WebKitLegacy.xcconfig:
190
191 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
192
193         Remove a site specific hack for AppleConnect plugin
194         https://bugs.webkit.org/show_bug.cgi?id=195643
195
196         Reviewed by Simon Fraser.
197
198         r66437 added a workaround for AppleConnect plugin.
199
200         Remove this code since Safari doesn't even use WebKitLegacy anymore,
201         and other WebKit clients support AppleConnect plugins.
202
203         * WebCoreSupport/WebFrameLoaderClient.mm:
204         (WebFrameLoaderClient::createPlugin):
205
206 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
207
208         Unreviewed, rolling out r242688, r242643, r242624.
209
210         Caused multiple layout test failures and crashes on iOS and macOS.
211
212         Reverted changeset:
213
214         "requestAnimationFrame should execute before the next frame"
215         https://bugs.webkit.org/show_bug.cgi?id=177484
216         https://trac.webkit.org/changeset/242624/webkit
217
218         * WebView/WebView.mm:
219         (-[WebView _viewWillDrawInternal]):
220
221 2019-03-09  Andy Estes  <aestes@apple.com>
222
223         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
224         https://bugs.webkit.org/show_bug.cgi?id=195526
225         <rdar://problem/48745636>
226
227         Reviewed by Chris Dumez.
228
229         * WebCoreSupport/WebPaymentCoordinatorClient.h:
230         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
231         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
232         (WebPaymentCoordinatorClient::openPaymentSetup):
233
234 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
235
236         requestAnimationFrame should execute before the next frame
237         https://bugs.webkit.org/show_bug.cgi?id=177484
238
239         Reviewed by Simon Fraser.
240
241         * WebView/WebView.mm:
242         (-[WebView _viewWillDrawInternal]):
243         Call Page::renderingUpdate() which implements  "Update the rendering"
244         step of the HTML Event Loop specification.
245
246 2019-03-07  Zalan Bujtas  <zalan@apple.com>
247
248         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
249         https://bugs.webkit.org/show_bug.cgi?id=195353
250         <rdar://problem/48626394>
251
252         Reviewed by Simon Fraser.
253
254         * WebView/WebPreferenceKeysPrivate.h:
255         * WebView/WebPreferences.mm:
256         (+[WebPreferences initialize]):
257         (-[WebPreferences contentChangeObserverEnabled]):
258         (-[WebPreferences setContentChangeObserverEnabled:]):
259         * WebView/WebPreferencesPrivate.h:
260         * WebView/WebView.mm:
261         (-[WebView _preferencesChanged:]):
262
263 2019-03-06  Sam Weinig  <sam@webkit.org>
264
265         WebKitLegacy does not need to generate an export file for i386 anymore
266         https://bugs.webkit.org/show_bug.cgi?id=195380
267
268         Reviewed by Dan Bernstein.
269
270         * Configurations/WebKitLegacy.xcconfig:
271         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
272         It still needs to be generated, since we are concatenating the shared exports
273         file with a macOS or iOS specific one.
274
275         * WebKit.mac.exp:
276         Remove i386 specific symbols that we were previously stripping.
277
278 2019-03-06  Rob Buis  <rbuis@igalia.com>
279
280         Consider supporting the `referrerpolicy` attribute.
281         https://bugs.webkit.org/show_bug.cgi?id=179053
282
283         Reviewed by Darin Adler.
284
285         Add a runtime flag for referrerpolicy attribute.
286
287         * WebView/WebPreferenceKeysPrivate.h:
288         * WebView/WebPreferences.mm:
289         (+[WebPreferences initialize]):
290         (-[WebPreferences referrerPolicyAttributeEnabled]):
291         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
292         * WebView/WebPreferencesPrivate.h:
293         * WebView/WebView.mm:
294         (-[WebView _preferencesChanged:]):
295
296 2019-03-03  Tim Horton  <timothy_horton@apple.com>
297
298         Remove some more unused 32-bit code
299         https://bugs.webkit.org/show_bug.cgi?id=195255
300
301         Reviewed by Darin Adler.
302
303         * Plugins/WebNetscapePluginEventHandler.mm:
304         (WebNetscapePluginEventHandler::create):
305         * Plugins/WebNetscapePluginView.h:
306         * Plugins/WebNetscapePluginView.mm:
307         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
308         (-[WebNetscapePluginView restorePortState:]):
309         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
310         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
311         (-[WebNetscapePluginView updateAndSetWindow]):
312         (-[WebNetscapePluginView setWindowIfNecessary]):
313         (-[WebNetscapePluginView createPlugin]):
314         (-[WebNetscapePluginView fini]):
315         (-[WebNetscapePluginView drawRect:]):
316         (-[WebNetscapePluginView invalidateRegion:]):
317         (-[WebNetscapePluginView getVariable:value:]):
318         (-[WebNetscapePluginView setVariable:value:]):
319         (isDrawingModelQuickDraw): Deleted.
320         (-[WebNetscapePluginView fixWindowPort]): Deleted.
321         (getQDPixelFormatForBitmapContext): Deleted.
322         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
323         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
324         * WebView/WebDelegateImplementationCaching.mm:
325
326 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
327
328         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
329         https://bugs.webkit.org/show_bug.cgi?id=195053
330         <rdar://problem/48134710>
331
332         Reviewed by Ryosuke Niwa.
333
334         * WebCoreSupport/WebEditorClient.h:
335
336 2019-03-01  Tim Horton  <timothy_horton@apple.com>
337
338         Remove unused code in WebKitLegacy
339         https://bugs.webkit.org/show_bug.cgi?id=189614
340
341         Reviewed by Simon Fraser.
342
343         * Carbon/CarbonUtils.h: Removed.
344         * Carbon/CarbonUtils.m: Removed.
345         * Carbon/CarbonWindowAdapter.h: Removed.
346         * Carbon/CarbonWindowAdapter.mm: Removed.
347         * Carbon/CarbonWindowContentView.h: Removed.
348         * Carbon/CarbonWindowContentView.m: Removed.
349         * Carbon/CarbonWindowFrame.h: Removed.
350         * Carbon/CarbonWindowFrame.m: Removed.
351         * Carbon/HIViewAdapter.h: Removed.
352         * Carbon/HIViewAdapter.m: Removed.
353         * Carbon/HIWebView.h: Removed.
354         * Carbon/HIWebView.mm: Removed.
355         * Configurations/WebKitLegacy.xcconfig:
356         * WebKit.mac.exp:
357
358 2019-03-01  Justin Fan  <justin_fan@apple.com>
359
360         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
361         https://bugs.webkit.org/show_bug.cgi?id=195191
362
363         Rubber-stamped by Dean Jackson.
364
365         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
366
367         * Configurations/FeatureDefines.xcconfig:
368
369 2019-02-28  Antoine Quint  <graouts@apple.com>
370
371         Enable the Pointer Events runtime flag by default
372         https://bugs.webkit.org/show_bug.cgi?id=195156
373
374         Reviewed by Dean Jackson.
375
376         * WebView/WebPreferences.mm:
377         (+[WebPreferences initialize]):
378
379 2019-02-28  Justin Fan  <justin_fan@apple.com>
380
381         [Web GPU] Enable Web GPU only on 64-bit
382         https://bugs.webkit.org/show_bug.cgi?id=195139
383
384         Because Metal is only supported on 64 bit apps.
385
386         Unreviewed build fix.
387
388         * Configurations/FeatureDefines.xcconfig:
389
390 2019-02-27  Antoine Quint  <graouts@apple.com>
391
392         Support Pointer Events on macOS
393         https://bugs.webkit.org/show_bug.cgi?id=195008
394         <rdar://problem/47454419>
395
396         Reviewed by Dean Jackson.
397
398         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
399
400         * Configurations/FeatureDefines.xcconfig:
401         * WebView/WebPreferenceKeysPrivate.h:
402         * WebView/WebPreferences.mm:
403         (+[WebPreferences initialize]):
404         (-[WebPreferences pointerEventsEnabled]):
405         (-[WebPreferences setPointerEventsEnabled:]):
406         * WebView/WebPreferencesPrivate.h:
407         * WebView/WebView.mm:
408         (-[WebView _preferencesChanged:]):
409
410 2019-02-23  Keith Miller  <keith_miller@apple.com>
411
412         Add new mac target numbers
413         https://bugs.webkit.org/show_bug.cgi?id=194955
414
415         Reviewed by Tim Horton.
416
417         * Configurations/Base.xcconfig:
418         * Configurations/DebugRelease.xcconfig:
419
420 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
421
422         Hardcode Visual Viewports on everywhere except iOS WK1
423         https://bugs.webkit.org/show_bug.cgi?id=194928
424
425         Reviewed by Zalan Bujtas.
426
427         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
428         change the default value of the Setting to 'true', and hardcode WebView on iOS to
429         set it to false. The setting has shipped for several years and there's no need to turn
430         it off now.
431
432         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
433         Visual Viewports are not enabled.
434         
435         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
436         that only runs in WK2
437
438         * WebView/WebPreferenceKeysPrivate.h:
439         * WebView/WebPreferences.mm:
440         (+[WebPreferences initialize]):
441         (-[WebPreferences visualViewportEnabled]): Deleted.
442         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
443         * WebView/WebPreferencesPrivate.h:
444         * WebView/WebView.mm:
445         (-[WebView _preferencesChanged:]):
446
447 2019-02-21  Darin Adler  <darin@apple.com>
448
449         Some refinements for Node and Document
450         https://bugs.webkit.org/show_bug.cgi?id=194764
451
452         Reviewed by Ryosuke Niwa.
453
454         * DOM/DOMDocument.mm:
455         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
456         through to WebCore or even looking at the arguments.
457         (-[DOMDocument getOverrideStyle::]): Ditto.
458
459 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
460
461         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
462         https://bugs.webkit.org/show_bug.cgi?id=194670
463         <rdar://problem/39066529>
464
465         Reviewed by Tim Horton.
466
467         * WebCoreSupport/WebEditorClient.h:
468         * WebCoreSupport/WebEditorClient.mm:
469         (WebEditorClient::replacementURLForResource): Deleted.
470         * WebCoreSupport/WebPlatformStrategies.h:
471         * WebCoreSupport/WebPlatformStrategies.mm:
472         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
473
474 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
475
476         Add MSE logging configuration
477         https://bugs.webkit.org/show_bug.cgi?id=194719
478         <rdar://problem/48122151>
479
480         Reviewed by Joseph Pecoraro.
481
482         * WebCoreSupport/WebChromeClient.mm:
483         (stringForMessageSource): Recognize the MSE message source.
484
485 2019-02-17  David Kilzer  <ddkilzer@apple.com>
486
487         Unreviewed, rolling out r241620.
488
489         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
490         (Requested by ddkilzer on #webkit.)
491
492         Reverted changeset:
493
494         "[WTF] Add environment variable helpers"
495         https://bugs.webkit.org/show_bug.cgi?id=192405
496         https://trac.webkit.org/changeset/241620
497
498 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
499
500         [WTF] Add environment variable helpers
501         https://bugs.webkit.org/show_bug.cgi?id=192405
502
503         Reviewed by Michael Catanzaro.
504
505         * WebView/WebView.mm:
506         (-[WebView _initWithFrame:frameName:groupName:]):
507         Utilize WTF::Environment where possible.
508
509 2019-02-15  Brian Burg  <bburg@apple.com>
510
511         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
512         https://bugs.webkit.org/show_bug.cgi?id=194411
513         <rdar://problem/47787614>
514
515         Reviewed by Joseph Pecoraro.
516
517         * Configurations/WebKitLegacy.xcconfig:
518         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
519
520         * WebCoreSupport/WebInspectorClient.mm:
521         (WebInspectorFrontendClient::localizedStringsURL):
522         (-[WebInspectorWindowController inspectorPagePath]):
523         (-[WebInspectorWindowController inspectorTestPagePath]):
524         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
525
526 2019-02-15  Commit Queue  <commit-queue@webkit.org>
527
528         Unreviewed, rolling out r241559 and r241566.
529         https://bugs.webkit.org/show_bug.cgi?id=194710
530
531         Causes layout test crashes under GuardMalloc (Requested by
532         ryanhaddad on #webkit).
533
534         Reverted changesets:
535
536         "[WTF] Add environment variable helpers"
537         https://bugs.webkit.org/show_bug.cgi?id=192405
538         https://trac.webkit.org/changeset/241559
539
540         "Unreviewed build fix for WinCairo Debug after r241559."
541         https://trac.webkit.org/changeset/241566
542
543 2019-02-15  Truitt Savell  <tsavell@apple.com>
544
545         Unreviewed, rolling out r241564.
546
547         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
548
549         Reverted changeset:
550
551         "[Mac] WebInspectorUI.framework does not need to be soft-
552         linked anymore"
553         https://bugs.webkit.org/show_bug.cgi?id=194411
554         https://trac.webkit.org/changeset/241564
555
556 2019-02-14  Brian Burg  <bburg@apple.com>
557
558         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
559         https://bugs.webkit.org/show_bug.cgi?id=194411
560         <rdar://problem/47787614>
561
562         Reviewed by Joseph Pecoraro.
563
564         * Configurations/WebKitLegacy.xcconfig:
565         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
566
567         * WebCoreSupport/WebInspectorClient.mm:
568         (WebInspectorFrontendClient::localizedStringsURL):
569         (-[WebInspectorWindowController inspectorPagePath]):
570         (-[WebInspectorWindowController inspectorTestPagePath]):
571         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
572
573 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
574
575         [WTF] Add environment variable helpers
576         https://bugs.webkit.org/show_bug.cgi?id=192405
577
578         Reviewed by Michael Catanzaro.
579
580         * WebView/WebView.mm:
581         (-[WebView _initWithFrame:frameName:groupName:]):
582         Utilize WTF::Environment where possible.
583
584 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
585
586         Allow pages to trigger programmatic paste from script on iOS
587         https://bugs.webkit.org/show_bug.cgi?id=194271
588         <rdar://problem/47808810>
589
590         Reviewed by Ryosuke Niwa.
591
592         See WebCore and WebKit ChangeLogs for more details.
593
594         * WebCoreSupport/WebEditorClient.h:
595
596 2019-02-12  Andy Estes  <aestes@apple.com>
597
598         [iOSMac] Enable Parental Controls Content Filtering
599         https://bugs.webkit.org/show_bug.cgi?id=194521
600         <rdar://39732376>
601
602         Reviewed by Tim Horton.
603
604         * Configurations/FeatureDefines.xcconfig:
605
606 2019-02-06  Andy Estes  <aestes@apple.com>
607
608         [Payment Request] It should be possible to require a phonetic name for shipping contacts
609         https://bugs.webkit.org/show_bug.cgi?id=194311
610         <rdar://46733045>
611
612         Reviewed by Alex Christensen.
613
614         * WebCoreSupport/WebPaymentCoordinatorClient.h:
615         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
616         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
617
618 2019-02-04  Said Abou-Hallawa  <said@apple.com>
619
620         [CG] Enable setAdditionalSupportedImageTypes for WK1
621         https://bugs.webkit.org/show_bug.cgi?id=194190
622
623         Reviewed by Tim Horton.
624
625         1. Define the preferences key AdditionalSupportedImageTypes.
626         2. Add additionalSupportedImageTypes as a private preference property.
627         3. Define the setter and the getter of the property.
628         4. Add function to convert from an id to an array of strings.
629         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
630
631         * WebView/WebPreferenceKeysPrivate.h:
632         * WebView/WebPreferences.mm:
633         (-[WebPreferences _stringArrayValueForKey:]):
634         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
635         (-[WebPreferences setAdditionalSupportedImageTypes:]):
636         (-[WebPreferences additionalSupportedImageTypes]):
637         * WebView/WebPreferencesPrivate.h:
638         * WebView/WebView.mm:
639         (-[WebView _preferencesChanged:]):
640
641 2019-02-04  Timothy Hatcher  <timothy@apple.com>
642
643         Add WebView SPI to temporarily force light or dark appearance on a page.
644         https://bugs.webkit.org/show_bug.cgi?id=194230
645
646         Reviewed by Tim Horton.
647
648         * WebView/WebView.mm:
649         (-[WebView _useDarkAppearance:]): Added.
650         (-[WebView _setUseDarkAppearance:]): Added.
651         * WebView/WebViewPrivate.h:
652
653 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
654
655         PageOverlayController's layers should be created lazily
656         https://bugs.webkit.org/show_bug.cgi?id=194199
657         rdar://problem/46571593
658
659         Reviewed by Tim Horton.
660
661         * WebCoreSupport/WebChromeClient.h:
662         * WebCoreSupport/WebChromeClient.mm:
663         (WebChromeClient::attachViewOverlayGraphicsLayer):
664
665 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
666
667         Make setNeedsLayout on the root more explicitly about triggering its side-effects
668         https://bugs.webkit.org/show_bug.cgi?id=194198
669
670         Reviewed by Antti Koivisto.
671
672         Call the newly named functions.
673
674         * WebView/WebFrame.mm:
675         (-[WebFrame setNeedsLayout]):
676         * WebView/WebHTMLView.mm:
677         (-[WebHTMLView setNeedsLayout:]):
678
679 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
680
681         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
682         https://bugs.webkit.org/show_bug.cgi?id=194189
683
684         Reviewed by Geoffrey Garen.
685
686         Pass the policy check identifier around functions and store it in WebFramePolicyListener
687         so that we can send it back to WebCore with the navigation policy decision.
688
689         * WebCoreSupport/WebFrameLoaderClient.h:
690         * WebCoreSupport/WebFrameLoaderClient.mm:
691         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
692         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
693         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
694         (WebFrameLoaderClient::dispatchWillSubmitForm):
695         (WebFrameLoaderClient::setUpPolicyListener):
696         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
697         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
698         (-[WebFramePolicyListener invalidate]):
699         (-[WebFramePolicyListener dealloc]):
700         (-[WebFramePolicyListener receivedPolicyDecision:]):
701         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
702         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
703
704 2019-01-31  Alex Christensen  <achristensen@webkit.org>
705
706         Revert r238819 which is unneeded and caused a performance regression.
707         https://bugs.webkit.org/show_bug.cgi?id=192272
708         <rdar://problem/46664625>
709
710         * WebCoreSupport/WebFrameLoaderClient.h:
711         * WebCoreSupport/WebFrameLoaderClient.mm:
712         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
713
714 2019-01-28  Devin Rousso  <drousso@apple.com>
715
716         Web Inspector: provide a way to edit page WebRTC settings on a remote target
717         https://bugs.webkit.org/show_bug.cgi?id=193863
718         <rdar://problem/47572764>
719
720         Reviewed by Joseph Pecoraro.
721
722         * WebView/WebView.mm:
723         (-[WebView _preferencesChanged:]):
724         Add page-level settings for WebRTC preferences.
725
726 2019-01-28  Andy Estes  <aestes@apple.com>
727
728         [watchOS] Enable Parental Controls content filtering
729         https://bugs.webkit.org/show_bug.cgi?id=193939
730         <rdar://problem/46641912>
731
732         Reviewed by Ryosuke Niwa.
733
734         * Configurations/FeatureDefines.xcconfig:
735
736 2019-01-28  Timothy Hatcher  <timothy@apple.com>
737
738         Make it easier for non-Apple ports to enable dark mode CSS support.
739         https://bugs.webkit.org/show_bug.cgi?id=193882
740
741         Reviewed by Megan Gardner.
742
743         * WebView/WebView.mm:
744         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
745         (-[WebView _effectiveAppearanceIsDark]): Ditto.
746
747 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
748
749         AX: Introduce a static accessibility tree
750         https://bugs.webkit.org/show_bug.cgi?id=193348
751         <rdar://problem/47203295>
752
753         Reviewed by Ryosuke Niwa.
754
755         * Configurations/FeatureDefines.xcconfig:
756
757 2019-01-25  Keith Rollin  <krollin@apple.com>
758
759         Update WebKitAdditions.xcconfig with correct order of variable definitions
760         https://bugs.webkit.org/show_bug.cgi?id=193793
761         <rdar://problem/47532439>
762
763         Reviewed by Alex Christensen.
764
765         XCBuild changes the way xcconfig variables are evaluated. In short,
766         all config file assignments are now considered in part of the
767         evaluation. When using the new build system and an .xcconfig file
768         contains multiple assignments of the same build setting:
769
770         - Later assignments using $(inherited) will inherit from earlier
771           assignments in the xcconfig file.
772         - Later assignments not using $(inherited) will take precedence over
773           earlier assignments. An assignment to a more general setting will
774           mask an earlier assignment to a less general setting. For example,
775           an assignment without a condition ('FOO = bar') will completely mask
776           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
777
778         This affects some of our .xcconfig files, in that sometimes platform-
779         or sdk-specific definitions appear before the general definitions.
780         Under the new evaluations rules, the general definitions alway take
781         effect because they always overwrite the more-specific definitions. The
782         solution is to swap the order, so that the general definitions are
783         established first, and then conditionally overwritten by the
784         more-specific definitions.
785
786         * Configurations/Version.xcconfig:
787         * Configurations/WebKitLegacy.xcconfig:
788
789 2019-01-25  David Kilzer  <ddkilzer@apple.com>
790
791         Move soft-linking of Lookup.framework out of LookupSPI.h
792         <https://webkit.org/b/193815>
793
794         Reviewed by Tim Horton.
795
796         * WebView/WebImmediateActionController.mm:
797         (-[WebImmediateActionController _animationControllerForText]):
798         * WebView/WebView.mm:
799         (-[WebView _prepareForDictionaryLookup]):
800         - Move soft-linking to LookupSoftLink.{h,mm}.
801
802 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
803
804         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
805         https://bugs.webkit.org/show_bug.cgi?id=193829
806
807         Reviewed by Tim Horton.
808
809         * WebCoreSupport/WebDragClient.mm:
810         (WebDragClient::didConcludeEditDrag):
811         * WebView/WebView.mm:
812         (-[WebView _requestStartDataInteraction:globalPosition:]):
813         (-[WebView _didConcludeEditDrag]):
814         (-[WebView _didConcludeEditDataInteraction]): Deleted.
815         * WebView/WebViewInternal.h:
816
817 2019-01-24  John Wilander  <wilander@apple.com>
818
819         Add Ad Click Attribution as an internal/experimental feature
820         https://bugs.webkit.org/show_bug.cgi?id=193685
821         <rdar://problem/47450399>
822
823         Reviewed by Brent Fulgham.
824
825         * WebView/WebPreferenceKeysPrivate.h:
826         * WebView/WebPreferences.mm:
827         (+[WebPreferences initialize]):
828         (-[WebPreferences adClickAttributionEnabled]):
829         (-[WebPreferences setAdClickAttributionEnabled:]):
830             Added support for experimental ad click attribution.
831         * WebView/WebPreferencesPrivate.h:
832         * WebView/WebView.mm:
833         (-[WebView _preferencesChanged:]):
834
835 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
836
837         Move FileSystem to WTF
838         https://bugs.webkit.org/show_bug.cgi?id=193602
839
840         Reviewed by Yusuke Suzuki.
841
842         * Misc/WebNSFileManagerExtras.mm:
843         * Storage/WebDatabaseProvider.mm:
844         * WebView/WebView.mm:
845
846 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
847
848         Fix the Apple Internal build. See <rdar://problem/47491383>.
849
850         Rubber-stamped by Tim Horton.
851
852         * WebCoreSupport/WebFrameLoaderClient.mm:
853
854 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
855
856         Clean up USE(WEB_THREAD)
857         https://bugs.webkit.org/show_bug.cgi?id=193698
858
859         Rubber-stamped by Tim Horton.
860
861         * Misc/WebCache.mm:
862         (+[WebCache emptyInMemoryResources]):
863         * WebCoreSupport/WebFrameLoaderClient.mm:
864         (-[WebFramePolicyListener use]):
865         * WebCoreSupport/WebGeolocationClient.mm:
866         (-[WebGeolocationPolicyListener allow]):
867         (-[WebGeolocationPolicyListener deny]):
868         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
869         * WebView/WebFrame.mm:
870         (-[WebFrame deviceOrientationChanged]):
871         * WebView/WebHTMLView.mm:
872         (hardwareKeyboardAvailabilityChangedCallback):
873         * WebView/WebView.mm:
874         (+[WebView _releaseMemoryNow]):
875         (+[WebView willEnterBackgroundWithCompletionHandler:]):
876         (-[WebView updateLayoutIgnorePendingStyleSheets]):
877         (-[WebView _dispatchUnloadEvent]):
878         (-[WebView _close]):
879         (-[WebView _preferencesChangedNotification:]):
880         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
881         (-[WebView goBack]):
882         (-[WebView goForward]):
883         (+[WebView _cacheModelChangedNotification:]):
884         (-[WebView stopLoading:]):
885         (-[WebView stopLoadingAndClear]):
886         (-[WebView reload:]):
887         (WebInstallMemoryPressureHandler):
888
889 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
890
891         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
892         https://bugs.webkit.org/show_bug.cgi?id=193706
893         <rdar://problem/44807048>
894
895         Reviewed by Ryosuke Niwa.
896
897         Use UndoStep::label().
898
899         * WebCoreSupport/WebEditorClient.h:
900         * WebCoreSupport/WebEditorClient.mm:
901         (-[WebUndoStep initWithUndoStep:]):
902         (+[WebUndoStep stepWithUndoStep:]):
903         (WebEditorClient::registerUndoOrRedoStep):
904         (WebEditorClient::registerUndoStep):
905         (WebEditorClient::registerRedoStep):
906
907 2019-01-22  Alex Christensen  <achristensen@webkit.org>
908
909         Move NetworkStorageSession ownership to NetworkProcess
910         https://bugs.webkit.org/show_bug.cgi?id=193580
911
912         Reviewed by Geoff Garen.
913
914         * Misc/WebCache.mm:
915         (+[WebCache clearCachedCredentials]):
916         * Misc/WebDownload.mm:
917         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
918         * Plugins/WebBaseNetscapePluginView.mm:
919         (WebKit::getAuthenticationInfo):
920         * WebCoreSupport/WebFrameNetworkingContext.mm:
921         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
922         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
923         (WebFrameNetworkingContext::storageSession const):
924         * WebView/WebPreferences.mm:
925         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
926         (+[WebPreferences _clearNetworkLoaderSession]):
927         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
928
929 2019-01-22  Daniel Bates  <dabates@apple.com>
930
931         [iOS] Interpret text key commands on keydown and app key commands on keypress
932         https://bugs.webkit.org/show_bug.cgi?id=192897
933         <rdar://problem/46857378>
934
935         Reviewed by Brent Fulgham.
936
937         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
938         is false) and keypress (isCharEvent is true), respectively.
939
940         * WebView/WebHTMLView.mm:
941         (-[WebHTMLView _handleEditingKeyEvent:]):
942
943 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
944
945         [css-logical] Implement flow-relative margin, padding and border shorthands
946         https://bugs.webkit.org/show_bug.cgi?id=188697
947
948         Reviewed by Simon Fraser and Antti Koivisto.
949
950         Add CSSLogicalEnabled runtime flag.
951
952         * WebView/WebPreferenceKeysPrivate.h:
953         * WebView/WebPreferences.mm:
954         (+[WebPreferences initialize]):
955         (-[WebPreferences cssLogicalEnabled]):
956         (-[WebPreferences setCSSLogicalEnabled:]):
957         * WebView/WebPreferencesPrivate.h:
958         * WebView/WebView.mm:
959         (-[WebView _preferencesChanged:]):
960
961 2019-01-15  Darin Adler  <darin@apple.com>
962
963         Use references rather than pointers for register/unregister functions, and more
964         https://bugs.webkit.org/show_bug.cgi?id=175028
965
966         Reviewed by Daniel Bates.
967
968         * WebCoreSupport/WebKitFullScreenListener.mm:
969         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
970         functions in Document; pass a reference.
971         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
972         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
973         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
974         * WebView/WebFullScreenController.mm:
975         (-[WebFullScreenController enterFullScreen:]): Ditto.
976         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
977         (-[WebFullScreenController exitFullScreen]): Ditto.
978         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
979         * WebView/WebFullScreenController.mm:
980         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
981
982 2019-01-12  Dan Bernstein  <mitz@apple.com>
983
984         [Cocoa] Avoid importing directly from subumbrella frameworks
985         https://bugs.webkit.org/show_bug.cgi?id=186016
986         <rdar://problem/40591038>
987
988         Reviewed by Sam Weinig.
989
990         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
991         * Carbon/CarbonWindowAdapter.mm: Ditto.
992         * Carbon/CarbonWindowFrame.m: Ditto.
993         * Carbon/HIViewAdapter.h: Ditto.
994         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
995           OTHER_CFLAGS_COCOA_TOUCH_NO.
996         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
997         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
998         * WebView/WebPDFView.h: Ditto.
999
1000 2019-01-20  Antoine Quint  <graouts@apple.com>
1001
1002         Add a POINTER_EVENTS feature flag
1003         https://bugs.webkit.org/show_bug.cgi?id=193577
1004         <rdar://problem/47408511>
1005
1006         Unreviewed. Also enable Pointer Events for iosmac.
1007
1008         * Configurations/FeatureDefines.xcconfig:
1009
1010 2019-01-19  Antoine Quint  <graouts@apple.com>
1011
1012         Add a POINTER_EVENTS feature flag
1013         https://bugs.webkit.org/show_bug.cgi?id=193577
1014
1015         Reviewed by Dean Jackson.
1016
1017         * Configurations/FeatureDefines.xcconfig:
1018
1019 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1020
1021         Revert r238815, it broke WK1 video fullscreen on Mac
1022         https://bugs.webkit.org/show_bug.cgi?id=193586
1023         <rdar://problem/47358941>
1024
1025         Reviewed by Jer Noble.
1026
1027         * WebView/WebVideoFullscreenController.h: Added.
1028         * WebView/WebVideoFullscreenController.mm: Added.
1029         (SOFT_LINK_CLASS):
1030         (-[WebVideoFullscreenController init]):
1031         (-[WebVideoFullscreenController dealloc]):
1032         (-[WebVideoFullscreenController fullscreenWindow]):
1033         (-[WebVideoFullscreenController windowDidLoad]):
1034         (-[WebVideoFullscreenController videoElement]):
1035         (-[WebVideoFullscreenController setVideoElement:]):
1036         (-[WebVideoFullscreenController clearFadeAnimation]):
1037         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1038         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1039         (-[WebVideoFullscreenController videoElementRect]):
1040         (-[WebVideoFullscreenController applicationDidResignActive:]):
1041         (frameExpandedToRatioOfFrame):
1042         (createBackgroundFullscreenWindow):
1043         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1044         (-[WebVideoFullscreenController enterFullscreen:]):
1045         (-[WebVideoFullscreenController exitFullscreen]):
1046         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1047         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1048         (-[WebVideoFullscreenController _requestExit]):
1049         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1050         (-[WebVideoFullscreenController requestExitFullscreen]):
1051         (-[WebVideoFullscreenController fadeHUDIn]):
1052         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1053         (-[WebVideoFullscreenController rateChanged:]):
1054         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1055         (-[WebVideoFullscreenWindow dealloc]):
1056         (-[WebVideoFullscreenWindow resignFirstResponder]):
1057         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1058         (-[WebVideoFullscreenWindow mouseDown:]):
1059         (-[WebVideoFullscreenWindow cancelOperation:]):
1060         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1061         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1062         (-[WebVideoFullscreenWindow animationDidEnd:]):
1063         (-[WebVideoFullscreenWindow mouseMoved:]):
1064         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1065         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1066         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1067         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1068         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1069         (-[WebVideoFullscreenHUDWindow center]):
1070         (-[WebVideoFullscreenHUDWindow keyDown:]):
1071         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1072         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1073         (-[WebVideoFullscreenHUDWindowController init]):
1074         (-[WebVideoFullscreenHUDWindowController dealloc]):
1075         (-[WebVideoFullscreenHUDWindowController setArea:]):
1076         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1077         (-[WebVideoFullscreenHUDWindowController delegate]):
1078         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1079         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1080         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1081         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1082         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1083         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1084         (createMediaUIControl):
1085         (createControlWithMediaUIControlType):
1086         (createTimeTextField):
1087         (createMediaUIBackgroundView):
1088         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1089         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1090         (-[WebVideoFullscreenHUDWindowController updateTime]):
1091         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1092         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1093         (-[WebVideoFullscreenHUDWindowController currentTime]):
1094         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1095         (-[WebVideoFullscreenHUDWindowController duration]):
1096         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1097         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1098         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1099         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1100         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1101         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1102         (-[WebVideoFullscreenHUDWindowController volume]):
1103         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1104         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1105         (-[WebVideoFullscreenHUDWindowController updateRate]):
1106         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1107         (-[WebVideoFullscreenHUDWindowController playing]):
1108         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1109         (timeToString):
1110         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1111         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1112         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1113         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1114         (-[WebVideoFullscreenHUDWindowController rewind:]):
1115         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1116         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1117         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1118         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1119         * WebView/WebView.mm:
1120         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1121         (-[WebView _exitVideoFullscreen]):
1122
1123 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1124
1125         Get rid of ADVANCED_SPELL_CHECKING
1126         https://bugs.webkit.org/show_bug.cgi?id=193592
1127
1128         Reviewed by Wenson Hsieh.
1129
1130         * WebCoreSupport/WebEditorClient.mm:
1131         (insertionPointFromCurrentSelection):
1132         (WebEditorClient::checkTextOfParagraph):
1133         (WebEditorClient::getGuessesForWord):
1134         (WebEditorClient::requestCandidatesForSelection):
1135         (WebEditorClient::requestCheckingOfString):
1136         * WebView/WebHTMLView.mm:
1137         (-[WebHTMLView insertText:]):
1138
1139 2019-01-18  Jer Noble  <jer.noble@apple.com>
1140
1141         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1142         https://bugs.webkit.org/show_bug.cgi?id=189553
1143
1144         Reviewed by Tim Horton.
1145
1146         * Configurations/Base.xcconfig:
1147         * Configurations/SDKVariant.xcconfig: Added.
1148         * Configurations/WebKitLegacy.xcconfig:
1149
1150 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1151
1152         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1153         <https://webkit.org/b/193568>
1154         <rdar://problem/47381130>
1155
1156         Reviewed by Alex Christensen.
1157
1158         * WebView/WebView.mm:
1159         - Remove unused soft-linking macros.
1160         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1161         (-[WebUITextIndicatorData initWithImage:scale:]):
1162         - Update to use exported PAL functions.
1163
1164 2019-01-17  Truitt Savell  <tsavell@apple.com>
1165
1166         Unreviewed, rolling out r240124.
1167
1168         This commit broke an internal build.
1169
1170         Reverted changeset:
1171
1172         "SDK_VARIANT build destinations should be separate from non-
1173         SDK_VARIANT builds"
1174         https://bugs.webkit.org/show_bug.cgi?id=189553
1175         https://trac.webkit.org/changeset/240124
1176
1177 2019-01-17  Jer Noble  <jer.noble@apple.com>
1178
1179         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1180         https://bugs.webkit.org/show_bug.cgi?id=189553
1181
1182         Reviewed by Tim Horton.
1183
1184         * Configurations/Base.xcconfig:
1185         * Configurations/SDKVariant.xcconfig: Added.
1186         * Configurations/WebKitLegacy.xcconfig:
1187
1188 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1189
1190         Stop using NetworkStorageSession::storageSession in WebCore
1191         https://bugs.webkit.org/show_bug.cgi?id=193529
1192
1193         Reviewed by Tim Horton.
1194
1195         * Misc/WebCache.mm:
1196         (+[WebCache addImageToCache:forURL:forFrame:]):
1197         * WebView/WebView.mm:
1198         (-[WebView _commonInitializationWithFrameName:groupName:]):
1199         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1200
1201 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1202
1203         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1204         https://bugs.webkit.org/show_bug.cgi?id=193368
1205
1206         Reviewed by Geoff Garen.
1207
1208         * Misc/WebCache.mm:
1209         (+[WebCache clearCachedCredentials]):
1210         * Misc/WebDownload.mm:
1211         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1212         * Plugins/WebBaseNetscapePluginView.mm:
1213         (WebKit::getAuthenticationInfo):
1214
1215 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1216
1217         Stop using CookiesStrategy
1218         https://bugs.webkit.org/show_bug.cgi?id=161106
1219
1220         Reviewed by Don Olmstead and Antti Koivisto.
1221
1222         * Misc/WebCache.mm:
1223         (+[WebCache addImageToCache:forURL:forFrame:]):
1224         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1225         (WebKit::NetscapePluginInstanceProxy::getCookies):
1226         (WebKit::NetscapePluginInstanceProxy::setCookies):
1227         * Plugins/WebNetscapePluginView.mm:
1228         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1229         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1230         * WebCoreSupport/WebPlatformStrategies.h:
1231         * WebCoreSupport/WebPlatformStrategies.mm:
1232         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1233         (WebPlatformStrategies::cookiesForDOM): Deleted.
1234         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1235         (WebPlatformStrategies::cookiesEnabled): Deleted.
1236         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1237         (WebPlatformStrategies::getRawCookies): Deleted.
1238         (WebPlatformStrategies::deleteCookie): Deleted.
1239         * WebView/WebView.mm:
1240         (-[WebView _commonInitializationWithFrameName:groupName:]):
1241         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1242
1243 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1244
1245         Cannot tab out of WKWebView on macOS
1246         https://bugs.webkit.org/show_bug.cgi?id=161448
1247         <rdar://problem/28100085>
1248
1249         Reviewed by Dean Jackson.
1250
1251         * WebCoreSupport/WebChromeClient.mm:
1252         * WebView/WebView.mm:
1253         Make use of SPI headers.
1254
1255 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1256
1257         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1258         r239913, and r239914.
1259         https://bugs.webkit.org/show_bug.cgi?id=193407
1260
1261         These revisions caused an internal failure (Requested by
1262         Truitt on #webkit).
1263
1264         Reverted changesets:
1265
1266         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1267         https://bugs.webkit.org/show_bug.cgi?id=186016
1268         https://trac.webkit.org/changeset/239901
1269
1270         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1271         https://trac.webkit.org/changeset/239909
1272
1273         "Tried to fix the build."
1274         https://trac.webkit.org/changeset/239910
1275
1276         "Fixed iOS builds after r239910."
1277         https://trac.webkit.org/changeset/239912
1278
1279         "More build fixing."
1280         https://trac.webkit.org/changeset/239913
1281
1282         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1283         https://trac.webkit.org/changeset/239914
1284
1285 2019-01-14  Mark Lam  <mark.lam@apple.com>
1286
1287         Re-enable ability to build --cloop builds.
1288         https://bugs.webkit.org/show_bug.cgi?id=192955
1289         <rdar://problem/46882363>
1290
1291         Reviewed by Saam barati and Keith Miller.
1292
1293         * Configurations/FeatureDefines.xcconfig:
1294
1295 2019-01-13  Dan Bernstein  <mitz@apple.com>
1296
1297         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1298
1299         Patch by Keith Rollin.
1300
1301         * WebView/PDFViewSPI.h:
1302
1303 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1304
1305         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1306         https://bugs.webkit.org/show_bug.cgi?id=191655
1307         rdar://problem/46074680
1308
1309         Reviewed by Megan Gardner.
1310
1311         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1312         * WebView/WebView.mm:
1313         (-[WebView _effectiveAppearanceIsDark]):
1314
1315 2019-01-12  Dan Bernstein  <mitz@apple.com>
1316
1317         [Cocoa] Avoid importing directly from subumbrella frameworks
1318         https://bugs.webkit.org/show_bug.cgi?id=186016
1319         <rdar://problem/40591038>
1320
1321         Reviewed by Sam Weinig.
1322
1323         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1324         * Carbon/CarbonWindowAdapter.mm: Ditto.
1325         * Carbon/CarbonWindowFrame.m: Ditto.
1326         * Carbon/HIViewAdapter.h: Ditto.
1327         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1328           OTHER_CFLAGS_COCOA_TOUCH_NO.
1329         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1330         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1331         * WebView/WebPDFView.h: Ditto.
1332
1333 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1334
1335         Enable visual viewport API by default
1336         https://bugs.webkit.org/show_bug.cgi?id=193376
1337
1338         Reviewed by Simon Fraser.
1339
1340         * WebView/WebPreferences.mm:
1341         (+[WebPreferences initialize]):
1342
1343 2019-01-11  John Wilander  <wilander@apple.com>
1344
1345         Compile out Web API Statistics Collection
1346         https://bugs.webkit.org/show_bug.cgi?id=193370
1347         <rdar://problem/45388584>
1348
1349         Reviewed by Brent Fulgham.
1350
1351         * Configurations/FeatureDefines.xcconfig:
1352             Defined ENABLE_WEB_API_STATISTICS, off by default.
1353
1354 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1355
1356         Stop using NetworkStorageSession in WebProcess
1357         https://bugs.webkit.org/show_bug.cgi?id=193236
1358
1359         Reviewed by Don Olmstead.
1360
1361         * WebCoreSupport/WebFrameNetworkingContext.h:
1362         * WebCoreSupport/WebFrameNetworkingContext.mm:
1363         (WebFrameNetworkingContext::storageSession const):
1364         * WebCoreSupport/WebPlatformStrategies.h:
1365         * WebCoreSupport/WebPlatformStrategies.mm:
1366         (WebPlatformStrategies::cookiesForDOM):
1367         (WebPlatformStrategies::setCookiesFromDOM):
1368         (WebPlatformStrategies::cookiesEnabled):
1369         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1370         (WebPlatformStrategies::getRawCookies):
1371         (WebPlatformStrategies::deleteCookie):
1372         * WebView/WebView.mm:
1373         (-[WebView _cachedResponseForURL:]):
1374         (-[WebView _clearCredentials]):
1375
1376 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1377
1378         Unreviewed, rolling out r239727.
1379
1380         Broke API tests
1381
1382         Reverted changeset:
1383
1384         "Stop using NetworkStorageSession in WebProcess"
1385         https://bugs.webkit.org/show_bug.cgi?id=193236
1386         https://trac.webkit.org/changeset/239727
1387
1388 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1389
1390         Stop using NetworkStorageSession in WebProcess
1391         https://bugs.webkit.org/show_bug.cgi?id=193236
1392
1393         Reviewed by Don Olmstead.
1394
1395         * WebCoreSupport/WebFrameNetworkingContext.h:
1396         * WebCoreSupport/WebFrameNetworkingContext.mm:
1397         (WebFrameNetworkingContext::storageSession const):
1398         * WebView/WebView.mm:
1399         (-[WebView _cachedResponseForURL:]):
1400         (-[WebView _clearCredentials]):
1401
1402 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1403
1404         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1405         <https://webkit.org/b/193056>
1406
1407         Reviewed by Alex Christensen.
1408
1409         * Plugins/Hosted/NetscapePluginHostProxy.h:
1410         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1411         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1412         (WebKit::NetscapePluginInstanceProxy::enumerate):
1413         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1414         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1415         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1416         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1417         * Plugins/Hosted/ProxyInstance.mm:
1418         (WebKit::ProxyInstance::invoke):
1419         * WebCoreSupport/WebGeolocationClient.mm:
1420         * WebView/WebDataSource.mm:
1421         (-[WebDataSource _receivedData:]):
1422         * WebView/WebView.mm:
1423         (-[WebView _cachedResponseForURL:]):
1424         - Remove '*' from RetainPtr<> type.
1425
1426 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1427
1428         Progress towards fixing Mac CMake build
1429         https://bugs.webkit.org/show_bug.cgi?id=193105
1430
1431         Reviewed by Don Olmstead.
1432
1433         * WebKitPrefix.h:
1434
1435 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1436
1437         Web Inspector: Use save sheet instead of dialog where possible
1438         https://bugs.webkit.org/show_bug.cgi?id=193160
1439         <rdar://problem/37399759>
1440
1441         Reviewed by Devin Rousso.
1442
1443         * WebCoreSupport/WebInspectorClient.mm:
1444         (WebInspectorFrontendClient::save):
1445
1446 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1447
1448         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1449         https://bugs.webkit.org/show_bug.cgi?id=193129
1450
1451         Reviewed by Tim Horton.
1452
1453         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1454
1455         * WebCoreSupport/WebEditorClient.mm:
1456         (WebEditorClient::registerUndoOrRedoStep):
1457         (undoNameForEditAction): Deleted.
1458
1459 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1460
1461         Add support for using the current text selection as the find string on iOS
1462         https://bugs.webkit.org/show_bug.cgi?id=193034
1463         <rdar://problem/45138739>
1464
1465         Reviewed by Tim Horton.
1466
1467         Add a method stub for WebKitLegacy.
1468
1469         * WebCoreSupport/WebEditorClient.h:
1470
1471 2019-01-01  Jeff Miller  <jeffm@apple.com>
1472
1473         Update user-visible copyright strings to include 2019
1474         https://bugs.webkit.org/show_bug.cgi?id=192811
1475
1476         Reviewed by Mark Lam.
1477
1478         * Info.plist:
1479
1480 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1481
1482         Use Ref<> as much as possible
1483         https://bugs.webkit.org/show_bug.cgi?id=192808
1484
1485         Reviewed by Alex Christensen.
1486
1487         * DOM/DOM.mm:
1488         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1489         * Plugins/Hosted/NetscapePluginHostManager.mm:
1490         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1491         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1492         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1493         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1494         * Plugins/WebNetscapePluginView.mm:
1495         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1496         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1497         * WebCoreSupport/WebContextMenuClient.mm:
1498         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1499         * WebCoreSupport/WebFrameLoaderClient.mm:
1500         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1501         * WebView/WebFrame.mm:
1502         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1503         * WebView/WebHTMLView.mm:
1504         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1505         * WebView/WebView.mm:
1506         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1507         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1508
1509 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1510
1511         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1512         https://bugs.webkit.org/show_bug.cgi?id=192821
1513
1514         Reviewed by Chris Dumez.
1515
1516         When a window becomes occluded, the window server informs the application.
1517         This should be used to suspend any work that is not visible by the user.
1518
1519         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1520         In some cases, that lead to performance impact (see radar).
1521
1522         This patch adds an observer for the occlusion notification. I tried to stick
1523         with the same names used by WebKit2.
1524
1525         * WebView/WebView.mm:
1526         (-[WebView _isViewVisible]):
1527         (-[WebView addWindowObserversForWindow:]):
1528         (-[WebView removeWindowObservers]):
1529         (-[WebView _windowDidChangeOcclusionState:]):
1530
1531 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1532
1533         [WebAuthN] Add a runtime flag for local authenticator
1534         https://bugs.webkit.org/show_bug.cgi?id=192792
1535         <rdar://problem/46798738>
1536
1537         Reviewed by Brent Fulgham.
1538
1539         * WebView/WebPreferenceKeysPrivate.h:
1540         * WebView/WebPreferences.mm:
1541         (+[WebPreferences initialize]):
1542         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1543         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1544         * WebView/WebPreferencesPrivate.h:
1545         * WebView/WebView.mm:
1546         (-[WebView _preferencesChanged:]):
1547
1548 2018-12-20  Chris Dumez  <cdumez@apple.com>
1549
1550         Use Optional::valueOr() instead of Optional::value_or()
1551         https://bugs.webkit.org/show_bug.cgi?id=192933
1552
1553         Reviewed by Geoffrey Garen.
1554
1555         * WebCoreSupport/WebSecurityOrigin.mm:
1556         (-[WebSecurityOrigin port]):
1557
1558 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1559
1560         Unreviewed, rolling out r239417.
1561
1562         Introduced two API test failures on macOS.
1563
1564         Reverted changeset:
1565
1566         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1567         occlusion changes"
1568         https://bugs.webkit.org/show_bug.cgi?id=192821
1569         https://trac.webkit.org/changeset/239417
1570
1571 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1572
1573         WKWebView default UA doesn't freeze the build number
1574         https://bugs.webkit.org/show_bug.cgi?id=192809
1575         <rdar://problem/44687185>
1576
1577         Reviewed by Andy Estes.
1578
1579         Always reports the frozen build number.
1580
1581         * WebView/WebView.mm:
1582         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1583         actual build number through this method call.
1584         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1585
1586 2018-12-19  Chris Dumez  <cdumez@apple.com>
1587
1588         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1589         https://bugs.webkit.org/show_bug.cgi?id=192728
1590         <rdar://problem/46746779>
1591
1592         Reviewed by Geoff Garen.
1593
1594         * DOM/*:
1595         * Plugins/*:
1596         * WebCoreSupport/*:
1597         * WebView/*:
1598
1599 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1600
1601         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1602         https://bugs.webkit.org/show_bug.cgi?id=192821
1603
1604         Reviewed by Chris Dumez.
1605
1606         When a window becomes occluded, the window server informs the application.
1607         This should be used to suspend any work that is not visible by the user.
1608
1609         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1610         In some cases, that lead to performance impact (see radar).
1611
1612         This patch adds an observer for the occlusion notification. I tried to stick
1613         with the same names used by WebKit2.
1614
1615         * WebView/WebView.mm:
1616         (-[WebView _isViewVisible]):
1617         (-[WebView addWindowObserversForWindow:]):
1618         (-[WebView removeWindowObservers]):
1619         (-[WebView _windowDidChangeOcclusionState:]):
1620
1621 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1622
1623         Allow clients to set the navigator platform
1624         https://bugs.webkit.org/show_bug.cgi?id=192735
1625
1626         Reviewed by Tim Horton.
1627
1628         Add stubs to fill out the added functionality in FrameLoaderClient.
1629
1630         * WebCoreSupport/WebFrameLoaderClient.h:
1631         * WebCoreSupport/WebFrameLoaderClient.mm:
1632         (WebFrameLoaderClient::navigatorPlatform):
1633
1634 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1635
1636         offsetLeft and offsetParent should adjust across shadow boundaries
1637         https://bugs.webkit.org/show_bug.cgi?id=157437
1638         <rdar://problem/26154021>
1639
1640         Reviewed by Simon Fraser.
1641
1642         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1643
1644         * DOM/DOMElement.mm:
1645         (-[DOMElement offsetLeft]):
1646         (-[DOMElement offsetTop]):
1647         (-[DOMElement offsetParent]):
1648
1649 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1650
1651         Unreviewed build fix.
1652
1653         * WebView/WebFrame.mm:
1654         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1655
1656 2018-12-15  Darin Adler  <darin@apple.com>
1657
1658         Use warning-ignoring macros more consistently and simply
1659         https://bugs.webkit.org/show_bug.cgi?id=192743
1660
1661         Reviewed by Mark Lam.
1662
1663         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1664         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1665         compilers in Objective-C++ code.
1666
1667         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1668         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1669         accomodate non-clang compilers here. Also use #pragma once, add a missing
1670         "explicit" and fix conditionals.
1671
1672 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1673
1674         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1675         https://bugs.webkit.org/show_bug.cgi?id=192653
1676
1677         Reviewed by Wenson Hsieh.
1678
1679         * WebView/WebHTMLView.mm:
1680         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1681
1682 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1683
1684         Implement feature flag for CSS Typed OM
1685         https://bugs.webkit.org/show_bug.cgi?id=192610
1686
1687         Reviewed by Ryosuke Niwa.
1688
1689         * Configurations/FeatureDefines.xcconfig:
1690
1691 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1692
1693         WebCore shouldn't have a Objective-C class named NSCursor
1694         https://bugs.webkit.org/show_bug.cgi?id=192602
1695         <rdar://problem/46615532>
1696
1697         Reviewed by Wenson Hsieh.
1698
1699         * WebView/WebFrameView.mm:
1700         (-[WebFrameView keyDown:keyDown:]):
1701         * WebView/WebHTMLView.mm:
1702         (-[WebHTMLView keyDown:]):
1703         (-[WebHTMLView performKeyEquivalent:]):
1704         Only use NSCursor on macOS.
1705
1706 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1707
1708         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1709         https://bugs.webkit.org/show_bug.cgi?id=192573
1710
1711         Reviewed by Simon Fraser.
1712
1713         * Configurations/FeatureDefines.xcconfig:
1714
1715 2018-12-10  Antti Koivisto  <antti@apple.com>
1716
1717         Rename "forced style recalc" to "full style rebuild"
1718         https://bugs.webkit.org/show_bug.cgi?id=192572
1719
1720         Reviewed by Zalan Bujtas.
1721
1722         * WebView/WebHTMLView.mm:
1723         (-[WebHTMLView setNeedsToApplyStyles:]):
1724
1725 2018-12-10  Darin Adler  <darin@apple.com>
1726
1727         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1728         https://bugs.webkit.org/show_bug.cgi?id=192533
1729         rdar://problem/45732710
1730
1731         Reviewed by Anders Carlsson.
1732
1733         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1734         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1735
1736 2018-12-10  Darin Adler  <darin@apple.com>
1737
1738         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1739         https://bugs.webkit.org/show_bug.cgi?id=192532
1740         rdar://problem/45731047
1741
1742         Reviewed by Chris Dumez.
1743
1744         * Plugins/Hosted/NetscapePluginHostManager.mm:
1745         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1746         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1747         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1748
1749 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1750
1751         Turn WritingDirection into an enum class
1752         https://bugs.webkit.org/show_bug.cgi?id=192401
1753         Work towards <rdar://problem/42075638>
1754
1755         Reviewed by Dan Bernstein.
1756
1757         Change WritingDirection from an enum to an enum class. No change in behavior.
1758
1759         * WebView/WebHTMLView.mm:
1760         (-[WebHTMLView toggleBaseWritingDirection:]):
1761         (-[WebHTMLView changeBaseWritingDirection:]):
1762         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1763
1764 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1765
1766         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1767         https://bugs.webkit.org/show_bug.cgi?id=192272
1768
1769         Reviewed by Brady Eidson.
1770
1771         * WebCoreSupport/WebFrameLoaderClient.h:
1772         * WebCoreSupport/WebFrameLoaderClient.mm:
1773         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1774
1775 2018-12-03  Jer Noble  <jer.noble@apple.com>
1776
1777         Get rid of old, dead Mac video fullscreen code.
1778         https://bugs.webkit.org/show_bug.cgi?id=192315
1779
1780         Reviewed by Eric Carlson.
1781
1782         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1783         is no longer supported in the Mac port.
1784
1785         * WebView/WebVideoFullscreenController.h: Removed.
1786         * WebView/WebVideoFullscreenController.mm: Removed.
1787         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1788         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1789         * WebView/WebView.mm:
1790         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1791         (-[WebView _exitVideoFullscreen]):
1792
1793 2018-12-03  Daniel Bates  <dabates@apple.com>
1794
1795         [iOS] Do not handle key events that are key commands
1796         https://bugs.webkit.org/show_bug.cgi?id=191608
1797         <rdar://problem/46046013>
1798
1799         Reviewed by Ryosuke Niwa.
1800
1801         A key down event may be associated with a key command. If it is then we want to execute the
1802         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1803         event as a key command to find out.
1804
1805         * WebView/WebHTMLView.mm:
1806         (-[WebHTMLView _handleEditingKeyEvent:]):
1807
1808 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1809
1810         Add a runtime feature flag for LayoutFormattingContext.
1811         https://bugs.webkit.org/show_bug.cgi?id=192280
1812
1813         Reviewed by Simon Fraser.
1814
1815         * Configurations/FeatureDefines.xcconfig:
1816
1817 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1818
1819         Move URL from WebCore to WTF
1820         https://bugs.webkit.org/show_bug.cgi?id=190234
1821
1822         Reviewed by Keith Miller.
1823
1824         * DOM/DOMAttr.mm:
1825         * DOM/DOMBlob.mm:
1826         * DOM/DOMCSSCharsetRule.mm:
1827         * DOM/DOMCSSImportRule.mm:
1828         * DOM/DOMCSSMediaRule.mm:
1829         * DOM/DOMCSSPageRule.mm:
1830         * DOM/DOMCSSPrimitiveValue.mm:
1831         * DOM/DOMCSSRule.mm:
1832         * DOM/DOMCSSStyleDeclaration.mm:
1833         * DOM/DOMCSSStyleRule.mm:
1834         * DOM/DOMCSSStyleSheet.mm:
1835         * DOM/DOMCSSValue.mm:
1836         * DOM/DOMCharacterData.mm:
1837         * DOM/DOMCounter.mm:
1838         * DOM/DOMDocument.mm:
1839         * DOM/DOMDocumentFragment.mm:
1840         * DOM/DOMDocumentType.mm:
1841         * DOM/DOMEvent.mm:
1842         * DOM/DOMFile.mm:
1843         * DOM/DOMHTMLAnchorElement.mm:
1844         * DOM/DOMHTMLAppletElement.mm:
1845         * DOM/DOMHTMLAreaElement.mm:
1846         * DOM/DOMHTMLBRElement.mm:
1847         * DOM/DOMHTMLBaseElement.mm:
1848         * DOM/DOMHTMLBaseFontElement.mm:
1849         * DOM/DOMHTMLBodyElement.mm:
1850         * DOM/DOMHTMLButtonElement.mm:
1851         * DOM/DOMHTMLCanvasElement.mm:
1852         * DOM/DOMHTMLCollection.mm:
1853         * DOM/DOMHTMLDivElement.mm:
1854         * DOM/DOMHTMLDocument.mm:
1855         * DOM/DOMHTMLElement.mm:
1856         * DOM/DOMHTMLEmbedElement.mm:
1857         * DOM/DOMHTMLFieldSetElement.mm:
1858         * DOM/DOMHTMLFontElement.mm:
1859         * DOM/DOMHTMLFormElement.mm:
1860         * DOM/DOMHTMLFrameElement.mm:
1861         * DOM/DOMHTMLFrameSetElement.mm:
1862         * DOM/DOMHTMLHRElement.mm:
1863         * DOM/DOMHTMLHeadElement.mm:
1864         * DOM/DOMHTMLHeadingElement.mm:
1865         * DOM/DOMHTMLHtmlElement.mm:
1866         * DOM/DOMHTMLIFrameElement.mm:
1867         * DOM/DOMHTMLImageElement.mm:
1868         * DOM/DOMHTMLInputElement.mm:
1869         * DOM/DOMHTMLLIElement.mm:
1870         * DOM/DOMHTMLLabelElement.mm:
1871         * DOM/DOMHTMLLegendElement.mm:
1872         * DOM/DOMHTMLLinkElement.mm:
1873         * DOM/DOMHTMLMapElement.mm:
1874         * DOM/DOMHTMLMarqueeElement.mm:
1875         * DOM/DOMHTMLMediaElement.mm:
1876         * DOM/DOMHTMLMetaElement.mm:
1877         * DOM/DOMHTMLModElement.mm:
1878         * DOM/DOMHTMLOListElement.mm:
1879         * DOM/DOMHTMLObjectElement.mm:
1880         * DOM/DOMHTMLOptGroupElement.mm:
1881         * DOM/DOMHTMLOptionElement.mm:
1882         * DOM/DOMHTMLOptionsCollection.mm:
1883         * DOM/DOMHTMLParagraphElement.mm:
1884         * DOM/DOMHTMLParamElement.mm:
1885         * DOM/DOMHTMLQuoteElement.mm:
1886         * DOM/DOMHTMLScriptElement.mm:
1887         * DOM/DOMHTMLSelectElement.mm:
1888         * DOM/DOMHTMLStyleElement.mm:
1889         * DOM/DOMHTMLTableCaptionElement.mm:
1890         * DOM/DOMHTMLTableCellElement.mm:
1891         * DOM/DOMHTMLTableColElement.mm:
1892         * DOM/DOMHTMLTableElement.mm:
1893         * DOM/DOMHTMLTableRowElement.mm:
1894         * DOM/DOMHTMLTableSectionElement.mm:
1895         * DOM/DOMHTMLTitleElement.mm:
1896         * DOM/DOMHTMLUListElement.mm:
1897         * DOM/DOMHTMLVideoElement.mm:
1898         * DOM/DOMKeyboardEvent.mm:
1899         * DOM/DOMMediaList.mm:
1900         * DOM/DOMMouseEvent.mm:
1901         * DOM/DOMMutationEvent.mm:
1902         * DOM/DOMNamedNodeMap.mm:
1903         * DOM/DOMProcessingInstruction.mm:
1904         * DOM/DOMRange.mm:
1905         * DOM/DOMStyleSheet.mm:
1906         * DOM/DOMText.mm:
1907         * DOM/DOMTextEvent.mm:
1908         * DOM/DOMTokenList.mm:
1909         * DOM/DOMUIEvent.mm:
1910         * DOM/DOMXPathResult.mm:
1911         * History/WebHistoryItem.mm:
1912         * Misc/WebNSURLExtras.mm:
1913         (-[NSURL _web_userVisibleString]):
1914         (-[NSURL _web_URLByRemovingUserInfo]):
1915         (-[NSURL _web_dataForURLComponentType:]):
1916         (-[NSURL _web_schemeData]):
1917         (-[NSURL _web_hostData]):
1918         * Misc/WebUserContentURLPattern.mm:
1919         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1920         * Plugins/WebNetscapePluginStream.h:
1921         (WebNetscapePluginStream::setRequestURL):
1922         * WebCoreSupport/WebChromeClient.h:
1923         * WebCoreSupport/WebChromeClient.mm:
1924         (WebChromeClient::signedPublicKeyAndChallengeString const):
1925         * WebCoreSupport/WebContextMenuClient.h:
1926         * WebCoreSupport/WebContextMenuClient.mm:
1927         * WebCoreSupport/WebDragClient.h:
1928         * WebCoreSupport/WebFrameLoaderClient.h:
1929         * WebCoreSupport/WebFrameLoaderClient.mm:
1930         (WebFrameLoaderClient::updateGlobalHistory):
1931         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1932         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1933         (WebPaymentCoordinatorClient::showPaymentUI):
1934         * WebCoreSupport/WebPlatformStrategies.h:
1935         * WebCoreSupport/WebPlatformStrategies.mm:
1936         (WebPlatformStrategies::readURLFromPasteboard):
1937         * WebCoreSupport/WebPluginInfoProvider.h:
1938         * WebCoreSupport/WebPluginInfoProvider.mm:
1939         (WebPluginInfoProvider::webVisiblePluginInfo):
1940         * WebCoreSupport/WebSecurityOrigin.mm:
1941         * WebCoreSupport/WebVisitedLinkStore.h:
1942         * WebView/WebDataSource.mm:
1943         * WebView/WebFrame.mm:
1944         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1945         * WebView/WebImmediateActionController.mm:
1946         (-[WebImmediateActionController _defaultAnimationController]):
1947         * WebView/WebPDFView.mm:
1948         * WebView/WebScriptDebugger.mm:
1949         * WebView/WebViewInternal.h:
1950
1951 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1952
1953         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1954         https://bugs.webkit.org/show_bug.cgi?id=192197
1955
1956         Reviewed by Jiewen Tan.
1957
1958         * Configurations/FeatureDefines.xcconfig:
1959         * WebCoreSupport/WebChromeClient.h:
1960         * WebCoreSupport/WebChromeClient.mm:
1961
1962 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1963
1964         Remove dead code from an earlier attempt at implementing safe browsing
1965         https://bugs.webkit.org/show_bug.cgi?id=192067
1966
1967         Reviewed by Chris Dumez.
1968
1969         * WebCoreSupport/WebFrameLoaderClient.h:
1970         * WebCoreSupport/WebFrameLoaderClient.mm:
1971         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1972
1973 2018-11-27  Mark Lam  <mark.lam@apple.com>
1974
1975         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1976         https://bugs.webkit.org/show_bug.cgi?id=192055
1977         <rdar://problem/46288783>
1978
1979         Reviewed by Saam Barati.
1980
1981         * Configurations/FeatureDefines.xcconfig:
1982
1983 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1984
1985         Make it possible to insert editable images with a gesture
1986         https://bugs.webkit.org/show_bug.cgi?id=191937
1987
1988         Reviewed by Wenson Hsieh.
1989
1990         * WebCoreSupport/WebEditorClient.mm:
1991         (undoNameForEditAction):
1992         Add a undo name.
1993
1994 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1995
1996         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1997         https://bugs.webkit.org/show_bug.cgi?id=191945
1998
1999         Reviewed by Anders Carlsson.
2000
2001         * WebCoreSupport/WebEditorClient.mm:
2002         (undoNameForEditAction):
2003
2004 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2005
2006         Enable drag and drop support for iOSMac
2007         https://bugs.webkit.org/show_bug.cgi?id=191818
2008         <rdar://problem/43907454>
2009
2010         Reviewed by Dean Jackson.
2011
2012         * Configurations/FeatureDefines.xcconfig:
2013
2014 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2015
2016         Address post-review feedback after r238438
2017         https://bugs.webkit.org/show_bug.cgi?id=191913
2018
2019         Reviewed by Ryosuke Niwa.
2020
2021         * WebView/WebFrame.mm:
2022         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2023         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2024         * WebView/WebView.mm:
2025         (-[WebView setSelectedDOMRange:affinity:]):
2026
2027 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2028
2029         Web Inspector: "Reload Web Inspector" button no longer partially works
2030         https://bugs.webkit.org/show_bug.cgi?id=191773
2031         <rdar://problem/46139932>
2032
2033         Reviewed by Devin Rousso.
2034
2035         * WebCoreSupport/WebInspectorClient.h:
2036         * WebCoreSupport/WebInspectorClient.mm:
2037         (WebInspectorFrontendClient::reopen):
2038
2039 2018-11-17  Devin Rousso  <drousso@apple.com>
2040
2041         Web Inspector: Network: add button to show system certificate dialog
2042         https://bugs.webkit.org/show_bug.cgi?id=191458
2043         <rdar://problem/45977019>
2044
2045         Reviewed by Joseph Pecoraro.
2046
2047         * WebCoreSupport/WebInspectorClient.h:
2048         * WebCoreSupport/WebInspectorClient.mm:
2049         (WebInspectorFrontendClient::showCertificate): Added.
2050
2051         * Configurations/WebKitLegacy.xcconfig:
2052
2053 2018-11-15  Truitt Savell  <tsavell@apple.com>
2054
2055         Unreviewed, rolling out r238244.
2056
2057         Caused High Sierra test runs to fail early with 50 crashes and
2058         casued 25 API failures.
2059
2060         Reverted changeset:
2061
2062         "[css-logical] Implement flow-relative margin, padding and
2063         border shorthands"
2064         https://bugs.webkit.org/show_bug.cgi?id=188697
2065         https://trac.webkit.org/changeset/238244
2066
2067 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2068
2069         [css-logical] Implement flow-relative margin, padding and border shorthands
2070         https://bugs.webkit.org/show_bug.cgi?id=188697
2071
2072         Reviewed by Simon Fraser and Antti Koivisto.
2073
2074         Add CSSLogicalEnabled runtime flag.
2075
2076         * WebView/WebPreferenceKeysPrivate.h:
2077         * WebView/WebPreferences.mm:
2078         (+[WebPreferences initialize]):
2079         (-[WebPreferences cssLogicalEnabled]):
2080         (-[WebPreferences setCSSLogicalEnabled:]):
2081         * WebView/WebPreferencesPrivate.h:
2082         * WebView/WebView.mm:
2083         (-[WebView _preferencesChanged:]):
2084
2085 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2086
2087         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2088         https://bugs.webkit.org/show_bug.cgi?id=191612
2089
2090         Reviewed by Matt Baker.
2091
2092         * WebCoreSupport/WebInspectorClient.mm:
2093         (-[WebInspectorWindowController destroyInspectorView]):
2094
2095 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2096
2097         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2098         https://bugs.webkit.org/show_bug.cgi?id=191494
2099         <rdar://problem/45469854>
2100
2101         Reviewed by Devin Rousso.
2102
2103         * WebCoreSupport/WebInspectorClient.h:
2104         WebKitLegacy will still have remote inspection of the Page directly.
2105
2106 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2107
2108         Make compositing updates incremental
2109         https://bugs.webkit.org/show_bug.cgi?id=90342
2110
2111         Reviewed by Antti Koivisto.
2112
2113         Fix spelling error.
2114
2115         * WebView/WebView.mm:
2116         (-[WebView _setMediaLayer:forPluginView:]):
2117
2118 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2119
2120         Implement a new edit command to change the enclosing list type
2121         https://bugs.webkit.org/show_bug.cgi?id=191487
2122         <rdar://problem/45955922>
2123
2124         Reviewed by Ryosuke Niwa.
2125
2126         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2127
2128         * WebCoreSupport/WebEditorClient.mm:
2129         (undoNameForEditAction):
2130
2131 2018-11-11  Daniel Bates  <dabates@apple.com>
2132
2133         [iOS] Draw caps lock indicator in password fields
2134         https://bugs.webkit.org/show_bug.cgi?id=190565
2135         <rdar://problem/45262343>
2136
2137         Reviewed by Dean Jackson.
2138
2139         Update the caps lock state when a hardware keyboard is attached or detached.
2140
2141         * WebView/WebHTMLView.mm:
2142         (hardwareKeyboardAvailabilityChangedCallback): Added.
2143         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2144         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2145
2146 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2147
2148         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2149         https://bugs.webkit.org/show_bug.cgi?id=191492
2150
2151         Reviewed by Alex Christensen.
2152
2153         * Carbon/HIWebView.mm:
2154         * Misc/WebNSFileManagerExtras.mm:
2155         * Misc/WebNSURLExtras.mm:
2156         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2157         * Plugins/WebBasePluginPackage.mm:
2158         * Plugins/WebPluginContainerCheck.mm:
2159         * WebCoreSupport/WebCachedFramePlatformData.h:
2160         * WebCoreSupport/WebDeviceOrientationClient.mm:
2161         * WebView/WebDelegateImplementationCaching.mm:
2162         * WebView/WebHTMLView.mm:
2163         * WebView/WebPDFRepresentation.mm:
2164         * WebView/WebPolicyDelegate.mm:
2165         * WebView/WebView.mm:
2166
2167 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2168
2169         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2170         https://bugs.webkit.org/show_bug.cgi?id=191492
2171
2172         Reviewed by Alex Christensen.
2173
2174         * Carbon/HIWebView.mm:
2175         (UpdateCommandStatus):
2176         * Misc/WebNSFileManagerExtras.mm:
2177         * Misc/WebNSURLExtras.mm:
2178         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2179         * Plugins/WebBasePluginPackage.mm:
2180         * Plugins/WebPluginContainerCheck.mm:
2181         (-[WebPluginContainerCheck _continueWithPolicy:]):
2182         * WebCoreSupport/WebCachedFramePlatformData.h:
2183         (WebCachedFramePlatformData::clear):
2184         * WebCoreSupport/WebDeviceOrientationClient.mm:
2185         (WebDeviceOrientationClient::getProvider const):
2186         * WebView/WebDelegateImplementationCaching.mm:
2187         (CallDelegate):
2188         (CallDelegateReturningBoolean):
2189         (CallResourceLoadDelegateReturningBoolean):
2190         (CallFormDelegate):
2191         (CallFormDelegateReturningBoolean):
2192         * WebView/WebHTMLView.mm:
2193         * WebView/WebPDFRepresentation.mm:
2194         * WebView/WebPolicyDelegate.mm:
2195         (-[WebPolicyDecisionListener _usePolicy:]):
2196         * WebView/WebView.mm:
2197
2198 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2199
2200         Unreviewed, rolling out r238047.
2201
2202         Introduced layout test failures on iOS simulator.
2203
2204         Reverted changeset:
2205
2206         "[iOS] Draw caps lock indicator in password fields"
2207         https://bugs.webkit.org/show_bug.cgi?id=190565
2208         https://trac.webkit.org/changeset/238047
2209
2210 2018-11-09  Antti Koivisto  <antti@apple.com>
2211
2212         Use OptionSet for layout milestones
2213         https://bugs.webkit.org/show_bug.cgi?id=191470
2214
2215         Reviewed by Dean Jackson.
2216
2217         * WebCoreSupport/WebFrameLoaderClient.h:
2218         * WebCoreSupport/WebFrameLoaderClient.mm:
2219         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2220         * WebView/WebView.mm:
2221         (coreLayoutMilestones):
2222         (kitLayoutMilestones):
2223         (-[WebView _cacheFrameLoadDelegateImplementations]):
2224         * WebView/WebViewInternal.h:
2225
2226 2018-11-09  Daniel Bates  <dabates@apple.com>
2227
2228         [iOS] Draw caps lock indicator in password fields
2229         https://bugs.webkit.org/show_bug.cgi?id=190565
2230         <rdar://problem/45262343>
2231
2232         Reviewed by Dean Jackson.
2233
2234         Update the caps lock state when a hardware keyboard is attached or detached.
2235
2236         * WebView/WebHTMLView.mm:
2237         (hardwareKeyboardAvailabilityChangedCallback): Added.
2238         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2239         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2240
2241 2018-11-09  Daniel Bates  <dabates@apple.com>
2242
2243         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2244         action when forward delete is pressed outside a text field
2245         https://bugs.webkit.org/show_bug.cgi?id=190566
2246         <rdar://problem/45262367>
2247
2248         Reviewed by Wenson Hsieh.
2249
2250         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2251         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2252         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2253
2254         * WebView/WebHTMLView.mm:
2255         (-[WebHTMLView _handleEditingKeyEvent:]):
2256
2257 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2258
2259         Adopt Reveal Framework to replace Lookup
2260         https://bugs.webkit.org/show_bug.cgi?id=191097
2261         <rdar://problem/45924508>
2262
2263         Reviewed by Tim Horton.
2264
2265         Pass in what it needed to clear the textIndicators. This is better than
2266         the current notification structure.
2267
2268         * WebView/WebView.mm:
2269         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2270         (-[WebView _prepareForDictionaryLookup]):
2271
2272 2018-11-06  Justin Fan  <justin_fan@apple.com>
2273
2274         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2275         https://bugs.webkit.org/show_bug.cgi?id=191291
2276
2277         Reviewed by Myles Maxfield.
2278
2279         Properly disable WEBGPU on all non-Metal platforms for now.
2280
2281         * Configurations/FeatureDefines.xcconfig:
2282
2283 2018-11-02  Daniel Bates  <dabates@apple.com>
2284
2285         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2286         https://bugs.webkit.org/show_bug.cgi?id=190487
2287
2288         Reviewed by Tim Horton.
2289
2290         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2291         allow the default handling.
2292
2293         * WebView/WebHTMLView.mm:
2294         (-[WebHTMLView _handleEditingKeyEvent:]):
2295
2296 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2297
2298         Add a storage limit for IndexedDB
2299         https://bugs.webkit.org/show_bug.cgi?id=190598
2300         <rdar://problem/44654715>
2301
2302         Reviewed by Chris Dumez.
2303
2304         * Storage/WebDatabaseManager.mm:
2305         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2306         * Storage/WebDatabaseManagerPrivate.h:
2307
2308 2018-10-31  Antti Koivisto  <antti@apple.com>
2309
2310         Remove LayerFlushScheduler
2311         https://bugs.webkit.org/show_bug.cgi?id=191103
2312
2313         Reviewed by Anders Carlsson.
2314
2315         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2316         all the virtual cruft.
2317
2318         * WebView/WebViewData.h:
2319         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2320         (): Deleted.
2321         * WebView/WebViewData.mm:
2322         (currentRunLoop):
2323         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2324         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2325         (WebViewLayerFlushScheduler::schedule):
2326         (WebViewLayerFlushScheduler::invalidate):
2327         (WebViewLayerFlushScheduler::layerFlushCallback):
2328
2329 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2330
2331         Enable InstallAPI for iOS unconditionally
2332         https://bugs.webkit.org/show_bug.cgi?id=191043
2333         rdar://problem/32728423
2334
2335         Reviewed by Dan Bernstein.
2336
2337         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2338         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2339         shouldn't be processed by InstallAPI.
2340         * MigrateHeaders.make: Removed an obsolete workaround.
2341         * Misc/NSURLDownloadSPI.h: Added.
2342         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2343
2344 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2345
2346         Clean up some obsolete MAX_ALLOWED macros
2347         https://bugs.webkit.org/show_bug.cgi?id=190916
2348
2349         Reviewed by Tim Horton.
2350
2351         * WebView/WebHTMLView.mm:
2352         (-[WebHTMLView pressureChangeWithEvent:]):
2353         * WebView/WebPDFView.h:
2354
2355 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2356
2357         Unreviewed, rolling out r237600 and r237604.
2358         https://bugs.webkit.org/show_bug.cgi?id=191086
2359
2360         Breaks internal iOS builds (Requested by ryanhadd_ on
2361         #webkit).
2362
2363         Reverted changesets:
2364
2365         "Enable InstallAPI for iOS unconditionally"
2366         https://bugs.webkit.org/show_bug.cgi?id=191043
2367         https://trac.webkit.org/changeset/237600
2368
2369         "Build fix attempt after enabling InstallAPI for iOS."
2370         https://bugs.webkit.org/show_bug.cgi?id=191043
2371         https://trac.webkit.org/changeset/237604
2372
2373 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2374
2375         Enable InstallAPI for iOS unconditionally
2376         https://bugs.webkit.org/show_bug.cgi?id=191043
2377         rdar://problem/32728423
2378
2379         Reviewed by Dan Bernstein.
2380
2381         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2382         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2383         shouldn't be processed by InstallAPI.
2384         * MigrateHeaders.make: Removed an obsolete workaround.
2385         * Misc/NSURLDownloadSPI.h: Added.
2386         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2387
2388 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2389
2390         Modernize WebKit nibs and lprojs for localization's sake
2391         https://bugs.webkit.org/show_bug.cgi?id=190911
2392         <rdar://problem/45349466>
2393
2394         Reviewed by Dan Bernstein.
2395
2396         * Misc/WebNSControlExtras.m:
2397         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2398         NSWindow and its contents are both in the same scale space these days; avoid
2399         double-applying the scale factor, or you can't see the prompt.
2400
2401         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2402         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2403         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2404         NIB->XIB
2405
2406 2018-10-25  Antoine Quint  <graouts@apple.com>
2407
2408         [Web Animations] Turn Web Animations CSS Integration off by default
2409         https://bugs.webkit.org/show_bug.cgi?id=190901
2410
2411         Reviewed by Dean Jackson.
2412
2413         * WebView/WebPreferences.mm:
2414         (+[WebPreferences initialize]):
2415
2416 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2417
2418         Clean up some obsolete macOS version guards
2419         https://bugs.webkit.org/show_bug.cgi?id=190887
2420
2421         Reviewed by Dan Bernstein.
2422
2423         * Misc/WebNSPasteboardExtras.mm:
2424         (+[NSPasteboard _web_dragTypesForURL]):
2425         * WebCoreSupport/PopupMenuMac.mm:
2426         (PopupMenuMac::show):
2427         * WebCoreSupport/WebEditorClient.h:
2428         * WebCoreSupport/WebEditorClient.mm:
2429         (WebEditorClient::respondToChangedSelection):
2430         * WebView/WebPDFView.mm:
2431         (-[WebPDFView _clipViewForPDFDocumentView]):
2432
2433 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2434
2435         Turn on Conic Gradients
2436         https://bugs.webkit.org/show_bug.cgi?id=190810
2437
2438         Reviewed by Tim Horton.
2439
2440         * Configurations/FeatureDefines.xcconfig:
2441
2442 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2443
2444         Cleanup: MIMETypeRegistry functions
2445         https://bugs.webkit.org/show_bug.cgi?id=190838
2446
2447         Reviewed by Simon Fraser.
2448
2449         * Misc/WebNSPasteboardExtras.mm:
2450         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2451         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2452         because they were identical.
2453
2454         * WebView/WebHTMLRepresentation.mm:
2455         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2456         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2457         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2458         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2459         * WebView/WebView.mm:
2460         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2461         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2462         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2463
2464 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2465
2466         Fix false positive leaks when using custom -init methods that don't start with -init
2467         <https://webkit.org/b/190818>
2468         <rdar://problem/45476042>
2469
2470         Reviewed by Dan Bernstein.
2471
2472         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2473         it is accessible by both categories.
2474         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2475         NSError (WebKitInternal) category.  Add attribute to make this
2476         behave like an -init method.
2477         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2478         NSError (WebKitInternal) category.  Modernize method.  Replace
2479         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2480
2481 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2482
2483         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2484         https://bugs.webkit.org/show_bug.cgi?id=190729
2485
2486         Reviewed by Tim Horton.
2487
2488         * DOM/DOM.mm:
2489         (-[DOMNode boundingBox]):
2490         * DOM/DOMElement.mm:
2491         * DOM/DOMHTML.mm:
2492         * DOM/DOMInternal.mm:
2493         * DOM/DOMUIKitExtensions.mm:
2494         * DOM/WebDOMOperations.mm:
2495         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2496         * DefaultDelegates/WebDefaultEditingDelegate.m:
2497         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2498         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2499         * DefaultDelegates/WebDefaultUIDelegate.h:
2500         * DefaultDelegates/WebDefaultUIDelegate.mm:
2501         (-[WebDefaultUIDelegate webViewClose:]):
2502         (-[WebDefaultUIDelegate webViewFocus:]):
2503         (-[WebDefaultUIDelegate webViewUnfocus:]):
2504         (-[WebDefaultUIDelegate webViewIsResizable:]):
2505         (-[WebDefaultUIDelegate webView:setResizable:]):
2506         (-[WebDefaultUIDelegate webView:setFrame:]):
2507         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2508         * History/BackForwardList.h:
2509         * History/BackForwardList.mm:
2510         * History/WebBackForwardList.mm:
2511         (+[WebBackForwardList initialize]):
2512         (bumperCarBackForwardHackNeeded):
2513         * History/WebHistory.mm:
2514         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2515         (-[WebHistory _sendNotification:entries:]):
2516         (-[WebHistory loadFromURL:error:]):
2517         (-[WebHistory saveToURL:error:]):
2518         * History/WebHistoryItem.mm:
2519         (WKNotifyHistoryItemChanged):
2520         (+[WebHistoryItem initialize]):
2521         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2522         * History/WebURLsWithTitles.m:
2523         * Misc/WebCache.mm:
2524         (+[WebCache initialize]):
2525         * Misc/WebDownload.mm:
2526         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2527         * Misc/WebElementDictionary.mm:
2528         (+[WebElementDictionary initialize]):
2529         (+[WebElementDictionary initializeLookupTable]):
2530         * Misc/WebIconDatabase.mm:
2531         * Misc/WebKitNSStringExtras.mm:
2532         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2533         * Misc/WebKitVersionChecks.h:
2534         * Misc/WebKitVersionChecks.mm:
2535         (WebKitLinkedOnOrAfter):
2536         (WebKitLinkTimeVersion):
2537         * Misc/WebLocalizableStrings.mm:
2538         * Misc/WebNSControlExtras.h:
2539         * Misc/WebNSControlExtras.m:
2540         * Misc/WebNSEventExtras.m:
2541         * Misc/WebNSFileManagerExtras.mm:
2542         * Misc/WebNSImageExtras.h:
2543         * Misc/WebNSImageExtras.m:
2544         * Misc/WebNSPasteboardExtras.mm:
2545         * Misc/WebNSPrintOperationExtras.h:
2546         * Misc/WebNSPrintOperationExtras.m:
2547         * Misc/WebNSViewExtras.m:
2548         * Misc/WebNSWindowExtras.m:
2549         * Panels/WebAuthenticationPanel.h:
2550         * Panels/WebAuthenticationPanel.m:
2551         * Panels/WebPanelAuthenticationHandler.m:
2552         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2553         (+[WebHostedNetscapePluginView initialize]):
2554         * Plugins/WebBasePluginPackage.h:
2555         * Plugins/WebBasePluginPackage.mm:
2556         * Plugins/WebJavaPlugIn.h:
2557         * Plugins/WebPluginContainerCheck.mm:
2558         * Plugins/WebPluginController.h:
2559         * Plugins/WebPluginController.mm:
2560         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2561         (-[WebPluginController addPlugin:]):
2562         (-[WebPluginController destroyPlugin:]):
2563         (-[WebPluginController destroyAllPlugins]):
2564         * Plugins/WebPluginDatabase.mm:
2565         (+[WebPluginDatabase _defaultPlugInPaths]):
2566         * Plugins/WebPluginPackage.mm:
2567         (-[WebPluginPackage initWithPath:]):
2568         * Storage/WebDatabaseManager.mm:
2569         (-[WebDatabaseManager deleteAllDatabases]):
2570         * Storage/WebDatabaseManagerClient.h:
2571         * Storage/WebDatabaseManagerClient.mm:
2572         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2573         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2574         * Storage/WebStorageManager.mm:
2575         (-[WebStorageManager deleteAllOrigins]):
2576         (WebKitInitializeStorageIfNecessary):
2577         * WebCoreSupport/WebAlternativeTextClient.h:
2578         * WebCoreSupport/WebApplicationCache.mm:
2579         (applicationCacheBundleIdentifier):
2580         * WebCoreSupport/WebChromeClient.h:
2581         * WebCoreSupport/WebChromeClient.mm:
2582         (WebChromeClient::setWindowRect):
2583         (WebChromeClient::windowRect):
2584         (WebChromeClient::takeFocus):
2585         (WebChromeClient::addMessageToConsole):
2586         (WebChromeClient::enableSuddenTermination):
2587         (WebChromeClient::disableSuddenTermination):
2588         (WebChromeClient::createPopupMenu const):
2589         (WebChromeClient::createSearchPopupMenu const):
2590         (WebChromeClient::shouldPaintEntireContents const):
2591         (WebChromeClient::supportsVideoFullscreen):
2592         (WebChromeClient::supportsFullScreenForElement):
2593         (WebChromeClient::enterFullScreenForElement):
2594         (WebChromeClient::exitFullScreenForElement):
2595         * WebCoreSupport/WebContextMenuClient.mm:
2596         * WebCoreSupport/WebDragClient.mm:
2597         * WebCoreSupport/WebEditorClient.h:
2598         * WebCoreSupport/WebEditorClient.mm:
2599         (+[WebUndoStep initialize]):
2600         (updateFontPanel):
2601         (WebEditorClient::didBeginEditing):
2602         (WebEditorClient::respondToChangedContents):
2603         (WebEditorClient::respondToChangedSelection):
2604         (WebEditorClient::canceledComposition):
2605         (WebEditorClient::didEndEditing):
2606         (WebEditorClient::didWriteSelectionToPasteboard):
2607         (attributesForAttributedStringConversion):
2608         (WebEditorClient::setInsertionPasteboard):
2609         (WebEditorClient::registerUndoOrRedoStep):
2610         (WebEditorClient::handleKeyboardEvent):
2611         (WebEditorClient::handleInputMethodKeydown):
2612         (WebEditorClient::textDidChangeInTextField):
2613         (WebEditorClient::requestCheckingOfString):
2614         * WebCoreSupport/WebFrameLoaderClient.h:
2615         * WebCoreSupport/WebFrameLoaderClient.mm:
2616         (WebFrameLoaderClient::detachedFromParent2):
2617         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2618         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2619         (WebFrameLoaderClient::dispatchWillSendRequest):
2620         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2621         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2622         (WebFrameLoaderClient::willCacheResponse const):
2623         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2624         (WebFrameLoaderClient::dispatchDidFinishLoading):
2625         (WebFrameLoaderClient::dispatchDidFailLoading):
2626         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2627         (WebFrameLoaderClient::dispatchWillClose):
2628         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2629         (WebFrameLoaderClient::dispatchDidCommitLoad):
2630         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2631         (WebFrameLoaderClient::dispatchDidFailLoad):
2632         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2633         (WebFrameLoaderClient::dispatchDidFinishLoad):
2634         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2635         (WebFrameLoaderClient::willChangeTitle):
2636         (WebFrameLoaderClient::didChangeTitle):
2637         (WebFrameLoaderClient::didReplaceMultipartContent):
2638         (WebFrameLoaderClient::updateGlobalHistory):
2639         (WebFrameLoaderClient::saveViewStateToItem):
2640         (WebFrameLoaderClient::restoreViewState):
2641         (WebFrameLoaderClient::provisionalLoadStarted):
2642         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2643         (WebFrameLoaderClient::setTitle):
2644         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2645         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2646         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2647         (WebFrameLoaderClient::didRestoreFromPageCache):
2648         (WebFrameLoaderClient::actionDictionary const):
2649         (WebFrameLoaderClient::createPlugin):
2650         (WebFrameLoaderClient::getLoadDecisionForIcons):
2651         (WebFrameLoaderClient::finishedLoadingIcon):
2652         (+[WebFramePolicyListener initialize]):
2653         * WebCoreSupport/WebFrameNetworkingContext.mm:
2654         * WebCoreSupport/WebGeolocationClient.h:
2655         * WebCoreSupport/WebGeolocationClient.mm:
2656         (WebGeolocationClient::requestPermission):
2657         * WebCoreSupport/WebInspectorClient.h:
2658         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2659         * WebCoreSupport/WebNotificationClient.mm:
2660         * WebCoreSupport/WebOpenPanelResultListener.mm:
2661         * WebCoreSupport/WebPlatformStrategies.h:
2662         * WebCoreSupport/WebPlatformStrategies.mm:
2663         * WebCoreSupport/WebProgressTrackerClient.h:
2664         * WebCoreSupport/WebProgressTrackerClient.mm:
2665         (WebProgressTrackerClient::progressStarted):
2666         (WebProgressTrackerClient::progressEstimateChanged):
2667         (WebProgressTrackerClient::progressFinished):
2668         * WebCoreSupport/WebSecurityOrigin.mm:
2669         * WebInspector/WebNodeHighlight.h:
2670         * WebInspector/WebNodeHighlight.mm:
2671         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2672         (-[WebNodeHighlight dealloc]):
2673         (-[WebNodeHighlight attach]):
2674         * WebInspector/WebNodeHighlightView.h:
2675         * WebInspector/WebNodeHighlightView.mm:
2676         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2677         (-[WebNodeHighlightView dealloc]):
2678         * WebInspector/WebNodeHighlighter.mm:
2679         (-[WebNodeHighlighter highlight]):
2680         * WebView/WebArchive.mm:
2681         (+[WebArchivePrivate initialize]):
2682         * WebView/WebClipView.h:
2683         * WebView/WebDataSource.mm:
2684         (WebDataSourcePrivate::WebDataSourcePrivate):
2685         (+[WebDataSource initialize]):
2686         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2687         (-[WebDataSource _makeRepresentation]):
2688         * WebView/WebDelegateImplementationCaching.h:
2689         * WebView/WebDelegateImplementationCaching.mm:
2690         (CallDelegate):
2691         (CallDelegateReturningFloat):
2692         (CallDelegateReturningBoolean):
2693         (CallUIDelegate):
2694         (CallUIDelegateReturningFloat):
2695         (CallUIDelegateReturningBoolean):
2696         (CallFrameLoadDelegate):
2697         (CallFrameLoadDelegateReturningBoolean):
2698         (CallResourceLoadDelegate):
2699         (CallScriptDebugDelegate):
2700         (CallFormDelegate):
2701         (CallFormDelegateReturningBoolean):
2702         * WebView/WebDeviceOrientation.mm:
2703         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2704         * WebView/WebDocumentInternal.h:
2705         * WebView/WebDocumentLoaderMac.mm:
2706         (needsDataLoadWorkaround):
2707         * WebView/WebDynamicScrollBarsViewInternal.h:
2708         * WebView/WebFormDelegate.m:
2709         * WebView/WebFrame.mm:
2710         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2711         (-[WebFrame _unmarkAllMisspellings]):
2712         (-[WebFrame _paintBehaviorForDestinationContext:]):
2713         (-[WebFrame _drawRect:contentsOnly:]):
2714         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2715         (-[WebFrame _scrollDOMRangeToVisible:]):
2716         (-[WebFrame _bodyBackgroundColor]):
2717         (-[WebFrame accessibilityRoot]):
2718         (needsMicrosoftMessengerDOMDocumentWorkaround):
2719         * WebView/WebFrameInternal.h:
2720         * WebView/WebFrameView.mm:
2721         (-[WebFrameView _setDocumentView:]):
2722         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2723         (-[WebFrameView _viewClassForMIMEType:]):
2724         (-[WebFrameView initWithFrame:]):
2725         (-[WebFrameView drawRect:]):
2726         (-[WebFrameView _firstResponderIsFormControl]):
2727         (-[WebFrameView keyDown:keyDown:]):
2728         (-[WebFrameView _isScrollable]):
2729         * WebView/WebFullScreenController.h:
2730         * WebView/WebFullScreenController.mm:
2731         * WebView/WebHTMLRepresentation.mm:
2732         * WebView/WebHTMLView.mm:
2733         (-[WebHTMLView hitTest:]):
2734         (-[WebHTMLView initWithFrame:]):
2735         (-[WebHTMLView dealloc]):
2736         (-[WebHTMLView addSubview:]):
2737         (-[WebHTMLView mouseDown:]):
2738         (-[WebHTMLView mouseUp:]):
2739         (-[WebHTMLView resignFirstResponder]):
2740         (-[WebHTMLView accessibilityHitTest:]):
2741         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2742         * WebView/WebHTMLViewInternal.h:
2743         * WebView/WebIndicateLayer.h:
2744         * WebView/WebIndicateLayer.mm:
2745         * WebView/WebMediaPlaybackTargetPicker.h:
2746         * WebView/WebMediaPlaybackTargetPicker.mm:
2747         * WebView/WebPDFDocumentExtras.h:
2748         * WebView/WebPDFDocumentExtras.mm:
2749         * WebView/WebPDFRepresentation.h:
2750         * WebView/WebPDFRepresentation.mm:
2751         * WebView/WebPDFView.h:
2752         * WebView/WebPreferences.mm:
2753         (cacheModelForMainBundle):
2754         (WebPreferencesPrivate::WebPreferencesPrivate):
2755         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2756         (-[WebPreferences encodeWithCoder:]):
2757         (+[WebPreferences standardPreferences]):
2758         (+[WebPreferences initialize]):
2759         (-[WebPreferences _valueForKey:]):
2760         (-[WebPreferences _setStringValue:forKey:]):
2761         (-[WebPreferences _setIntegerValue:forKey:]):
2762         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2763         (-[WebPreferences _setFloatValue:forKey:]):
2764         (-[WebPreferences _setBoolValue:forKey:]):
2765         (-[WebPreferences _setLongLongValue:forKey:]):
2766         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2767         (-[WebPreferences _postCacheModelChangedNotification]):
2768         (-[WebPreferences _postPreferencesChangedNotification]):
2769         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2770         (-[WebPreferences setStorageBlockingPolicy:]):
2771         * WebView/WebResource.mm:
2772         (+[WebResourcePrivate initialize]):
2773         * WebView/WebTextCompletionController.h:
2774         * WebView/WebTextIterator.mm:
2775         (+[WebTextIteratorPrivate initialize]):
2776         * WebView/WebView.mm:
2777         (shouldEnableLoadDeferring):
2778         (shouldRestrictWindowFocus):
2779         (shouldRespectPriorityInCSSAttributeSetters):
2780         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2781         (shouldAllowPictureInPictureMediaPlayback):
2782         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2783         (shouldAllowWindowOpenWithoutUserGesture):
2784         (shouldConvertInvalidURLsToBlank):
2785         (shouldRequireUserGestureToLoadVideo):
2786         (-[WebView _commonInitializationWithFrameName:groupName:]):
2787         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2788         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2789         (-[WebView _closePluginDatabases]):
2790         (-[WebView _closeWithFastTeardown]):
2791         (-[WebView _close]):
2792         (+[WebView _MIMETypeForFile:]):
2793         (-[WebView setShowingInspectorIndication:]):
2794         (-[WebView _setFormDelegate:]):
2795         (-[WebView _needsPreHTML5ParserQuirks]):
2796         (-[WebView _preferencesChangedNotification:]):
2797         (-[WebView _preferencesChanged:]):
2798         (-[WebView _cacheResourceLoadDelegateImplementations]):
2799         (-[WebView _cacheFrameLoadDelegateImplementations]):
2800         (-[WebView _policyDelegateForwarder]):
2801         (-[WebView _UIDelegateForwarder]):
2802         (-[WebView _editingDelegateForwarder]):
2803         (-[WebView _updateActiveState]):
2804         (-[_WebSafeForwarder forwardInvocation:]):
2805         (+[WebView initialize]):
2806         (-[WebView _pluginForMIMEType:]):
2807         (-[WebView _pluginForExtension:]):
2808         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2809         (+[WebView canShowMIMETypeAsHTML:]):
2810         (-[WebView _initWithArguments:]):
2811         (-[WebView initWithFrame:frameName:groupName:]):
2812         (-[WebView dealloc]):
2813         (-[WebView close]):
2814         (-[WebView viewDidMoveToWindow]):
2815         (-[WebView setUIDelegate:]):
2816         (-[WebView setResourceLoadDelegate:]):
2817         (-[WebView setPolicyDelegate:]):
2818         (-[WebView setFrameLoadDelegate:]):
2819         (-[WebView goBack]):
2820         (-[WebView goForward]):
2821         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2822         (-[WebView setHostWindow:]):
2823         (-[WebView becomeFirstResponder]):
2824         (+[WebView _cacheModelChangedNotification:]):
2825         (-[WebView _frameViewAtWindowPoint:]):
2826         (+[WebView _preflightSpellCheckerNow:]):
2827         (+[WebView _preflightSpellChecker]):
2828         (-[WebView canGoBack]):
2829         (-[WebView canGoForward]):
2830         (-[WebView stopLoading:]):
2831         (-[WebView reload:]):
2832         (-[WebView setMainFrameDocumentReady:]):
2833         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2834         (-[WebView setContinuousSpellCheckingEnabled:]):
2835         (-[WebView undoManager]):
2836         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2837         (-[WebView isAutomaticLinkDetectionEnabled]):
2838         (-[WebView isAutomaticDashSubstitutionEnabled]):
2839         (-[WebView isAutomaticTextReplacementEnabled]):
2840         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2841         (+[WebView _setCacheModel:]):
2842         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2843         (-[WebView _keyboardUIMode]):
2844         (LayerFlushController::flushLayers):
2845         (-[WebView _scheduleCompositingLayerFlush]):
2846         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2847         (-[WebView fullScreenPlaceholderView]):
2848         (WebInstallMemoryPressureHandler):
2849         * WebView/WebViewData.h:
2850         * WebView/WebViewData.mm:
2851         (+[WebViewPrivate initialize]):
2852         (-[WebViewPrivate init]):
2853         (-[WebViewPrivate dealloc]):
2854         * WebView/WebViewInternal.h:
2855
2856 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2857
2858         Clean up FrameLoader two-state enums
2859         https://bugs.webkit.org/show_bug.cgi?id=190731
2860
2861         Reviewed by Chris Dumez.
2862
2863         * WebCoreSupport/WebFrameLoaderClient.h:
2864         * WebCoreSupport/WebFrameLoaderClient.mm:
2865         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2866
2867 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2868
2869         Unreviewed, rolling out r237137.
2870
2871         SPI is actually used
2872
2873         Reverted changeset:
2874
2875         "Remove unused WebFrame._loadType"
2876         https://bugs.webkit.org/show_bug.cgi?id=190583
2877         https://trac.webkit.org/changeset/237137
2878
2879 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2880
2881         Enable the datalist element by default on iOS and macOS
2882         https://bugs.webkit.org/show_bug.cgi?id=190594
2883         <rdar://problem/45281159>
2884
2885         Reviewed by Ryosuke Niwa and Tim Horton.
2886
2887         * Configurations/FeatureDefines.xcconfig:
2888
2889 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2890
2891         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2892         https://bugs.webkit.org/show_bug.cgi?id=190675
2893
2894         Reviewed by Chris Dumez.
2895
2896         * History/BackForwardList.h:
2897         * History/BackForwardList.mm:
2898         (BackForwardList::backItem):
2899         (BackForwardList::currentItem):
2900         (BackForwardList::forwardItem):
2901         (BackForwardList::backListCount const):
2902         (BackForwardList::forwardListCount const):
2903         (BackForwardList::itemAtIndex):
2904         * History/WebBackForwardList.mm:
2905         (-[WebBackForwardList backItem]):
2906         (-[WebBackForwardList currentItem]):
2907         (-[WebBackForwardList forwardItem]):
2908         (-[WebBackForwardList itemAtIndex:]):
2909
2910 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2911
2912         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2913         https://bugs.webkit.org/show_bug.cgi?id=190526
2914         rdar://problem/45230140
2915
2916         Reviewed by Dean Jackson.
2917
2918         * WebCoreSupport/WebEditorClient.mm:
2919         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2920
2921 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2922
2923         Implement feature flag and bindings for CSS Painting API
2924         https://bugs.webkit.org/show_bug.cgi?id=190237
2925
2926         Reviewed by Ryosuke Niwa.
2927
2928         * Configurations/FeatureDefines.xcconfig:
2929
2930 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2931
2932         Replace HistoryItem* with HistoryItem& where possible
2933         https://bugs.webkit.org/show_bug.cgi?id=190617
2934
2935         Reviewed by Chris Dumez.
2936
2937         * History/BackForwardList.h:
2938         * History/BackForwardList.mm:
2939         (BackForwardList::goToItem):
2940         * History/WebBackForwardList.mm:
2941         (-[WebBackForwardList goToItem:]):
2942         * History/WebHistoryItem.mm:
2943         (WKNotifyHistoryItemChanged):
2944         * History/WebHistoryItemInternal.h:
2945
2946 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2947
2948         Remove unused WebHistoryItem._transientPropertyForKey
2949         https://bugs.webkit.org/show_bug.cgi?id=190606
2950
2951         Reviewed by Chris Dumez.
2952
2953         * History/WebHistoryItem.mm:
2954         * History/WebHistoryItemPrivate.h:
2955
2956 2018-10-15  Justin Fan  <justin_fan@apple.com>
2957
2958         Add WebGPU 2018 feature flag and experimental feature flag
2959         https://bugs.webkit.org/show_bug.cgi?id=190509
2960
2961         Reviewed by Dean Jackson.
2962
2963         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2964         for the 2018 WebGPU prototype.
2965
2966         * Configurations/FeatureDefines.xcconfig:
2967         * WebView/WebPreferenceKeysPrivate.h:
2968         * WebView/WebPreferences.mm:
2969         (+[WebPreferences initialize]):
2970         (-[WebPreferences webGPUEnabled]):
2971         (-[WebPreferences setWebGPUEnabled:]):
2972         * WebView/WebPreferencesPrivate.h:
2973         * WebView/WebView.mm:
2974         (-[WebView _preferencesChanged:]):
2975
2976 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2977
2978         Fix iOS build after r237157
2979
2980         * WebView/WebView.mm:
2981         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2982
2983 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2984
2985         Modernize BackForwardClient.h
2986         https://bugs.webkit.org/show_bug.cgi?id=190610
2987
2988         Reviewed by Chris Dumez.
2989
2990         * History/BackForwardList.h:
2991         * History/BackForwardList.mm:
2992         (BackForwardList::backListCount const):
2993         (BackForwardList::forwardListCount const):
2994         (BackForwardList::backListCount): Deleted.
2995         (BackForwardList::forwardListCount): Deleted.
2996         * History/WebBackForwardList.mm:
2997         (-[WebBackForwardList init]):
2998         * WebCoreSupport/WebFrameLoaderClient.mm:
2999         (WebFrameLoaderClient::canCachePage const):
3000         * WebView/WebFrameView.mm:
3001         (-[WebFrameView keyDown:keyDown:]):
3002         * WebView/WebView.mm:
3003         (-[WebView _commonInitializationWithFrameName:groupName:]):
3004         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3005         (-[WebView _loadBackForwardListFromOtherView:]):
3006         (-[WebView initWithCoder:]):
3007         (-[WebView encodeWithCoder:]):
3008         (-[WebView backForwardList]):
3009         (-[WebView setMaintainsBackForwardList:]):
3010
3011 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3012
3013         Add support for prefers-color-scheme media query
3014         https://bugs.webkit.org/show_bug.cgi?id=190499
3015         rdar://problem/45212025
3016
3017         Reviewed by Dean Jackson.
3018
3019         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3020
3021 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3022
3023         Remove unused WebView._globalHistoryItem
3024         https://bugs.webkit.org/show_bug.cgi?id=190601
3025
3026         Reviewed by Chris Dumez.
3027
3028         * WebCoreSupport/WebFrameLoaderClient.h:
3029         * WebCoreSupport/WebFrameLoaderClient.mm:
3030         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3031         * WebView/WebView.mm:
3032         (-[WebView _globalHistoryItem]): Deleted.
3033         (-[WebView _setGlobalHistoryItem:]): Deleted.
3034         * WebView/WebViewData.h:
3035         * WebView/WebViewInternal.h:
3036         * WebView/WebViewPrivate.h:
3037
3038 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3039
3040         Remove unused parameters from FrameLoaderClient::createFrame
3041         https://bugs.webkit.org/show_bug.cgi?id=190587
3042
3043         Reviewed by Chris Dumez.
3044
3045         * WebCoreSupport/WebFrameLoaderClient.h:
3046         * WebCoreSupport/WebFrameLoaderClient.mm:
3047         (WebFrameLoaderClient::createFrame):
3048
3049 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3050
3051         Remove unused WebFrame._loadType
3052         https://bugs.webkit.org/show_bug.cgi?id=190583
3053
3054         Reviewed by Chris Dumez.
3055
3056         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3057
3058         * WebView/WebFrame.mm:
3059         (toWebFrameLoadType): Deleted.
3060         (-[WebFrame _loadType]): Deleted.
3061         * WebView/WebFramePrivate.h:
3062
3063 2018-10-15  Chris Dumez  <cdumez@apple.com>
3064
3065         Restrict browsing context lookup by name to frames that are related to one another
3066         https://bugs.webkit.org/show_bug.cgi?id=190475
3067
3068         Reviewed by Alex Christensen.
3069
3070         * WebView/WebFrame.mm:
3071         (-[WebFrame findFrameNamed:]):
3072
3073 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3074
3075         Remove InjectedBundle processing of back/forward lists
3076         https://bugs.webkit.org/show_bug.cgi?id=190459
3077
3078         Reviewed by Chris Dumez.
3079
3080         * WebCoreSupport/WebFrameLoaderClient.h:
3081         * WebCoreSupport/WebFrameLoaderClient.mm:
3082         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3083
3084 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3085
3086         [JSC] Remove Option::useAsyncIterator
3087         https://bugs.webkit.org/show_bug.cgi?id=190567
3088
3089         Reviewed by Saam Barati.
3090
3091         * Configurations/FeatureDefines.xcconfig:
3092
3093 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3094
3095         Allow encoding of small enum classes
3096         https://bugs.webkit.org/show_bug.cgi?id=190531
3097
3098         Reviewed by Tim Horton.
3099
3100         * WebCoreSupport/WebFrameLoaderClient.mm:
3101         (-[WebFramePolicyListener dealloc]):
3102
3103 2018-10-11  Keith Rollin  <krollin@apple.com>
3104
3105         CURRENT_ARCH should not be used in Run Script phase.
3106         https://bugs.webkit.org/show_bug.cgi?id=190407
3107         <rdar://problem/45133556>
3108
3109         Reviewed by Alexey Proskuryakov.
3110
3111         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3112         CURRENT_ARCH is not well-defined during this phase (and may even have
3113         the value "undefined") since this phase is run just once per build
3114         rather than once per supported architecture. Migrate away from
3115         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3116         performing an operation for each value, or by picking the first entry
3117         in ARCHS and using that as a representative value.
3118
3119         * Configurations/WebKitLegacy.xcconfig: When generating
3120         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3121         macosx platforms.
3122
3123         * MigrateHeaders.make:
3124         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3125         generate one for each architecture in ARCHS.
3126
3127 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3128
3129         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3130         https://bugs.webkit.org/show_bug.cgi?id=190429
3131
3132         Reviewed by Saam Barati.
3133
3134         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3135
3136         * WebView/WebPDFRepresentation.mm:
3137         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3138
3139 2018-10-08  Justin Fan  <justin_fan@apple.com>
3140
3141         WebGPU: Rename old WebGPU prototype to WebMetal
3142         https://bugs.webkit.org/show_bug.cgi?id=190325
3143         <rdar://problem/44990443>
3144
3145         Reviewed by Dean Jackson.
3146
3147         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3148
3149         * Configurations/FeatureDefines.xcconfig:
3150         * WebView/WebPreferenceKeysPrivate.h:
3151         * WebView/WebPreferences.mm:
3152         (+[WebPreferences initialize]):
3153         (-[WebPreferences webMetalEnabled]):
3154         (-[WebPreferences setWebMetalEnabled:]):
3155         (-[WebPreferences webGPUEnabled]): Deleted.
3156         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3157         * WebView/WebPreferencesPrivate.h:
3158         * WebView/WebView.mm:
3159         (-[WebView _preferencesChanged:]):
3160
3161 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3162
3163         Make <input type=color> a runtime enabled (on-by-default) feature
3164         https://bugs.webkit.org/show_bug.cgi?id=189162
3165
3166         Reviewed by Wenson Hsieh and Tim Horton.
3167
3168         * Configurations/FeatureDefines.xcconfig:
3169
3170 2018-10-07  Dan Bernstein  <mitz@apple.com>
3171
3172         Fixed building with the latest macOS SDK
3173
3174         * Plugins/WebNetscapePluginPackage.mm:
3175         (-[WebNetscapePluginPackage openResourceFile]):
3176         (-[WebNetscapePluginPackage closeResourceFile:]):
3177
3178 2018-10-04  Dan Bernstein  <mitz@apple.com>
3179
3180         More Carbon build-fixing.
3181
3182         * Carbon/CarbonWindowAdapter.mm:
3183         (-[CarbonWindowAdapter _destroyRealWindow:]):
3184         (-[CarbonWindowAdapter _growBoxRect]):
3185
3186 2018-10-04  Dan Bernstein  <mitz@apple.com>
3187
3188         Retried to fix 32-bit macOS builds after r236846.
3189
3190         * WebView/WebHTMLView.mm:
3191         (-[WebHTMLView setMarkedText:selectedRange:]):
3192
3193 2018-10-04  Dan Bernstein  <mitz@apple.com>
3194
3195         Retried to fix 32-bit macOS builds after r236846.
3196
3197         * Carbon/HIWebView.mm:
3198         (ActiveStateChanged):
3199
3200 2018-10-04  Dan Bernstein  <mitz@apple.com>
3201
3202         Tried to fix 32-bit macOS builds after r236846.
3203
3204         * Carbon/HIWebView.mm:
3205         (_NSSelectorForHICommand):
3206
3207 2018-10-04  Dan Bernstein  <mitz@apple.com>
3208
3209         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3210         https://bugs.webkit.org/show_bug.cgi?id=190250
3211
3212         Reviewed by Andy Estes.
3213
3214         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3215           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3216           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3217           an earlier line set it to YES.
3218
3219         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3220         changes below.
3221
3222         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3223           provides some missing method declarations.
3224
3225         * Misc/WebDownload.mm:
3226         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3227           a deprecated method.
3228
3229         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3230
3231         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3232           other code in the file uses a method from it.
3233
3234         * Plugins/WebBaseNetscapePluginView.mm:
3235         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3236           a deprecated method.
3237
3238         * Plugins/WebPluginController.mm:
3239         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3240           around use of a selector that may be present in some WebKit client.
3241
3242         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3243           method declarations.
3244
3245         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3246           from here.
3247
3248         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3249           missing method declarations.
3250
3251         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3252           from here.
3253
3254         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3255           call from here.
3256         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3257           an obsolete delegate method for binary compatibility.
3258         (pluginView): Ditto.
3259
3260         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3261           call from here.
3262
3263         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3264           WebDeviceOrientationProviderMock protocol.
3265
3266         * WebView/WebDeviceOrientationProviderMock.mm:
3267         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3268           main @implementation.
3269
3270         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3271           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3272
3273         * WebView/WebDynamicScrollBarsView.mm:
3274         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3275           of a deprecated method.
3276
3277         * WebView/WebHTMLView.mm:
3278         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3279           selector warning around action methods that are not declared anywhere in WebKit.
3280
3281         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3282           about implementing this deprecated method.
3283         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3284         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3285         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3286         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3287         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3288         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3289         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3290         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3291         (-[WebHTMLView doCommandBySelector:]): Ditto.
3292         (-[WebHTMLView insertText:]): Ditto.
3293
3294         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3295
3296         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3297
3298         * WebView/WebPDFView.h: Removed previewView ivar.
3299
3300         * WebView/WebPDFView.mm:
3301           Removed declaration of FileInternal category and merged its implementation with the main
3302           implementation.
3303         (-[WebPDFView dealloc]): Removed previewView ivar.
3304         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3305           exist in macOS versions we support.
3306         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3307         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3308           action methods internal to PDFKit.
3309         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3310         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3311
3312         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3313           call on macOS, even though in r86988 we started calling different methods on iOS.
3314
3315         * WebView/WebView.mm:
3316         - Imported headers that declare delegate methods that we call.
3317         - Removed declaration of WebFileInternal category and merged its implementation with the
3318           main implementation.
3319         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3320           category, which made them impossible to call from the main implementation. Moved those
3321           into the main implementation. One of those had to be declared in a class extension,
3322           because it is called from a method implemented in the WebPrivate category, and that
3323           category’s implementation appears first in the file.
3324
3325         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3326           around use of obsolete delegate method for binary compatibility.
3327
3328         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3329
3330 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3331
3332         Runtime flag and IDL for MediaRecorder
3333         https://bugs.webkit.org/show_bug.cgi?id=190018
3334
3335         Reviewed by Youenn Fablet and Chris Dumez.
3336
3337         * WebView/WebPreferenceKeysPrivate.h:
3338         * WebView/WebPreferences.mm:
3339         (+[WebPreferences initialize]):
3340         (-[WebPreferences mediaRecorderEnabled]):
3341         (-[WebPreferences setMediaRecorderEnabled:]):
3342         * WebView/WebPreferencesPrivate.h:
3343         * WebView/WebView.mm:
3344         (-[WebView _preferencesChanged:]):
3345
3346 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3347
3348         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3349         https://bugs.webkit.org/show_bug.cgi?id=190238
3350
3351         Reviewed by Antti Koivisto.
3352
3353         Enabled the feature by default.
3354
3355         * WebView/WebPreferences.mm:
3356         (+[WebPreferences initialize]):
3357
3358 2018-10-01  Dean Jackson  <dino@apple.com>
3359
3360         [macOS] Switching to discrete GPU should be done in the UI process
3361         https://bugs.webkit.org/show_bug.cgi?id=189361
3362         <rdar://problem/43949622>
3363
3364         Reviewed by Simon Fraser.
3365
3366         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3367         not support swapping to the discrete GPU in this configuration.
3368
3369         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3370         (WebKit::WebSwitchingGPUClient::singleton):
3371         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3372         * WebView/WebView.mm:
3373         (-[WebView _commonInitializationWithFrameName:groupName:]):
3374
3375 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3376
3377         Remove ParsedURLString
3378         https://bugs.webkit.org/show_bug.cgi?id=190154
3379
3380         Reviewed by Chris Dumez.
3381
3382         * WebView/WebScriptDebugger.mm:
3383         (toNSURL):
3384
3385 2018-10-01  Dean Jackson  <dino@apple.com>
3386
3387         Remove CSS Animation Triggers
3388         https://bugs.webkit.org/show_bug.cgi?id=190175
3389         <rdar://problem/44925626>
3390
3391         Reviewed by Simon Fraser.
3392
3393         * Configurations/FeatureDefines.xcconfig:
3394
3395 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3396
3397         Unreviewed, rolling out r236624 and r236671.
3398         https://bugs.webkit.org/show_bug.cgi?id=190207
3399
3400         The change in r236624 introduced crashes on the bots
3401         (Requested by ryanhaddad on #webkit).
3402
3403         Reverted changesets:
3404
3405         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3406         https://bugs.webkit.org/show_bug.cgi?id=188747
3407         https://trac.webkit.org/changeset/236624
3408
3409         "Unify implementation in VideoFullscreenInterfaceAVKit"
3410         https://bugs.webkit.org/show_bug.cgi?id=190091
3411         https://trac.webkit.org/changeset/236671
3412
3413 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3414
3415         URL should not use TextEncoding internally
3416         https://bugs.webkit.org/show_bug.cgi?id=190111
3417
3418         Reviewed by Andy Estes.
3419
3420         * Misc/WebNSURLExtras.mm:
3421
3422 2018-09-28  Jer Noble  <jer.noble@apple.com>
3423
3424         Refactoring: eliminate raw pointer usage in Fullscreen code
3425         https://bugs.webkit.org/show_bug.cgi?id=188747
3426         <rdar://problem/43541164>
3427
3428         Reviewed by Alex Christensen.
3429
3430         PlaybackSessionInterface no longer has an invalidate() method.
3431
3432         * WebView/WebView.mm:
3433         (-[WebView _clearPlaybackControlsManager]):
3434
3435 2018-09-28  Chris Dumez  <cdumez@apple.com>
3436
3437         Drop support for cross-origin-window-policy header
3438         https://bugs.webkit.org/show_bug.cgi?id=190081
3439
3440         Reviewed by Ryosuke Niwa.
3441
3442         * WebView/WebPreferenceKeysPrivate.h:
3443         * WebView/WebPreferences.mm:
3444         (+[WebPreferences initialize]):
3445         * WebView/WebPreferencesPrivate.h:
3446         * WebView/WebView.mm:
3447         (-[WebView _preferencesChanged:]):
3448
3449 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3450
3451         Rename createMarkup to serializePreservingVisualAppearance
3452         https://bugs.webkit.org/show_bug.cgi?id=190086
3453
3454         Reviewed by Wenson Hsieh.
3455
3456         * DOM/WebDOMOperations.mm:
3457         (-[DOMRange markupString]):
3458
3459 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3460
3461         Unreviewed, rolling out r236605.
3462         https://bugs.webkit.org/show_bug.cgi?id=190087
3463
3464         caused three API test timeouts (Requested by jernoble on
3465         #webkit).
3466
3467         Reverted changeset:
3468
3469         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3470         https://bugs.webkit.org/show_bug.cgi?id=188747
3471         https://trac.webkit.org/changeset/236605
3472
3473 2018-09-28  Jer Noble  <jer.noble@apple.com>
3474
3475         Refactoring: eliminate raw pointer usage in Fullscreen code
3476         https://bugs.webkit.org/show_bug.cgi?id=188747
3477         <rdar://problem/43541164>
3478
3479         Reviewed by Alex Christensen.
3480
3481         PlaybackSessionInterface no longer has an invalidate() method.
3482
3483         * WebView/WebView.mm:
3484         (-[WebView _clearPlaybackControlsManager]):
3485
3486 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3487
3488         Use enum class in createMarkup arguments
3489         https://bugs.webkit.org/show_bug.cgi?id=190028
3490
3491         Reviewed by Wenson Hsieh.
3492
3493         * DOM/WebDOMOperations.mm:
3494         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3495         (-[DOMRange markupString]): Ditto.
3496
3497 2018-09-27  Antoine Quint  <graouts@apple.com>
3498
3499         [Web Animations] Turn Web Animations with CSS integration on
3500         https://bugs.webkit.org/show_bug.cgi?id=184819
3501         <rdar://problem/39597337>
3502
3503         Reviewed by Dean Jackson.
3504
3505         * WebView/WebPreferences.mm:
3506         (+[WebPreferences initialize]):
3507
3508 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3509
3510         Selection should work across shadow boundary when initiated by a mouse drag
3511         https://bugs.webkit.org/show_bug.cgi?id=151380
3512         <rdar://problem/24363872>
3513
3514         Reviewed by Wenson Hsieh.
3515
3516         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3517
3518         * WebView/WebPreferenceKeysPrivate.h:
3519         * WebView/WebPreferences.mm:
3520         (+[WebPreferences initialize]):
3521         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3522         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3523         * WebView/WebPreferencesPrivate.h:
3524         * WebView/WebView.mm:
3525         (-[WebView _preferencesChanged:]):
3526
3527 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3528
3529         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3530         https://bugs.webkit.org/show_bug.cgi?id=189918
3531         Work towards <rdar://problem/44648705>
3532
3533         Reviewed by Tim Horton.
3534
3535         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3536
3537         * WebView/WebHTMLView.mm:
3538         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3539         (-[WebHTMLView _updateFontPanel]):
3540         * WebView/WebView.mm:
3541         (-[WebView typingAttributes]):
3542
3543 2018-09-17  Darin Adler  <darin@apple.com>
3544
3545         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3546         https://bugs.webkit.org/show_bug.cgi?id=189652
3547
3548         Reviewed by Saam Barati.
3549
3550         * WebView/WebPDFRepresentation.mm:
3551         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3552
3553 2018-09-14  Jer Noble  <jer.noble@apple.com>
3554
3555         Turn SourceBufferChangeTypeEnabled on by default
3556         https://bugs.webkit.org/show_bug.cgi?id=189527
3557
3558         Reviewed by Eric Carlson.
3559
3560         * WebView/WebPreferences.mm:
3561         (+[WebPreferences initialize]):
3562
3563 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3564
3565         Fix an internal build after r235935
3566         https://bugs.webkit.org/show_bug.cgi?id=188996
3567
3568         * Carbon/HIWebView.mm:
3569         (Draw):
3570         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3571
3572 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3573
3574         Add IGNORE_WARNING_.* macros
3575         https://bugs.webkit.org/show_bug.cgi?id=188996
3576
3577         Reviewed by Michael Catanzaro.
3578
3579         * Carbon/CarbonUtils.m:
3580         (PoolCleaner):
3581         * Carbon/CarbonWindowAdapter.mm:
3582         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3583         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3584         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3585         (-[CarbonWindowAdapter _termWindowIfOwner]):
3586         (-[CarbonWindowAdapter _windowMovedToRect:]):
3587         (-[CarbonWindowAdapter setContentView:]):
3588         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3589         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3590         * Carbon/CarbonWindowFrame.m:
3591         (-[CarbonWindowFrame title]):
3592         * Carbon/HIViewAdapter.m:
3593         (+[HIViewAdapter getHIViewForNSView:]):
3594         * Carbon/HIWebView.mm:
3595         (overrideCGContext):
3596         (restoreCGContext):
3597         (Draw):
3598         * DOM/DOM.mm:
3599         * History/WebHistory.mm:
3600         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3601         * History/WebHistoryItem.mm:
3602         (-[WebHistoryItem icon]):
3603         * Misc/WebKitNSStringExtras.mm:
3604         (-[NSString _web_drawAtPoint:font:textColor:]):
3605         * Misc/WebNSImageExtras.m:
3606         (-[NSImage _web_scaleToMaxSize:]):
3607         (-[NSImage _web_dissolveToFraction:]):
3608         * Misc/WebNSPasteboardExtras.mm:
3609         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3610         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3611         * Panels/WebAuthenticationPanel.m:
3612         (-[WebAuthenticationPanel loadNib]):
3613         * Plugins/Hosted/NetscapePluginHostManager.mm:
3614         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3615         (WebKit::NetscapePluginHostManager::didCreateWindow):
3616         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3617         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3618         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3619         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3620         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3621         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3622         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3623         (-[WebHostedNetscapePluginView drawRect:]):
3624         * Plugins/Hosted/WebTextInputWindowController.m:
3625         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3626         * Plugins/WebBaseNetscapePluginView.mm:
3627         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3628         * Plugins/WebNetscapePluginPackage.mm:
3629         (-[WebNetscapePluginPackage _tryLoad]):
3630         * Plugins/WebNetscapePluginView.mm:
3631         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3632         (-[WebNetscapePluginView sendDrawRectEvent:]):
3633         (-[WebNetscapePluginView drawRect:]):
3634         * Plugins/WebPluginController.mm:
3635         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3636         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3637         * WebCoreSupport/PopupMenuMac.mm:
3638         (PopupMenuMac::populate):
3639         * WebCoreSupport/WebAlternativeTextClient.h:
3640         * WebCoreSupport/WebDragClient.mm:
3641         (WebDragClient::startDrag):
3642         * WebCoreSupport/WebFrameLoaderClient.mm:
3643         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3644         (webGetNSImage):
3645         * WebInspector/WebNodeHighlight.mm:
3646         * WebInspector/WebNodeHighlightView.mm:
3647         (-[WebNodeHighlightView drawRect:]):
3648         * WebView/WebClipView.mm:
3649         (-[WebClipView initWithFrame:]):
3650         * WebView/WebFrame.mm:
3651         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3652         (-[WebFrame _drawRect:contentsOnly:]):
3653         (-[WebFrame accessibilityRoot]):
3654         * WebView/WebFullScreenController.mm:
3655         (-[WebFullScreenController enterFullScreen:]):
3656         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3657         (-[WebFullScreenController exitFullScreen]):
3658         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3659         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3660         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3661         * WebView/WebHTMLView.mm:
3662         (-[NSWindow _web_borderView]):
3663         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3664         (-[WebHTMLView _setAsideSubviews]):
3665         (-[WebHTMLView _autoscroll]):
3666         (-[WebHTMLView drawRect:]):
3667         (-[WebHTMLView mouseDown:]):
3668         (-[WebHTMLView mouseDragged:]):
3669         (-[WebHTMLView mouseUp:]):
3670         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3671         (-[WebHTMLView knowsPageRange:]):
3672         (-[WebHTMLView accessibilityHitTest:]):
3673         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3674         (-[WebHTMLView _colorAsString:]):
3675         (-[WebHTMLView copyFont:]):
3676         (-[WebHTMLView _executeSavedKeypressCommands]):
3677         (-[WebHTMLView attachRootLayer:]):
3678         (-[WebHTMLView textStorage]):
3679         (-[WebHTMLView _updateSelectionForInputManager]):
3680         * WebView/WebPDFView.mm:
3681         (_applicationInfoForMIMEType):
3682         (-[WebPDFView centerSelectionInVisibleArea:]):
3683         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3684         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3685         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3686         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3687         * WebView/WebTextCompletionController.mm:
3688         (-[WebTextCompletionController _buildUI]):
3689         (-[WebTextCompletionController _placePopupWindow:]):
3690         * WebView/WebVideoFullscreenController.mm:
3691         * WebView/WebVideoFullscreenHUDWindowController.mm:
3692         (createMediaUIBackgroundView):
3693         * WebView/WebView.mm:
3694         (-[WebTextListTouchBarViewController initWithWebView:]):
3695         (-[WebView _dispatchTileDidDraw:]):
3696         (-[WebView encodeWithCoder:]):
3697         (-[WebView mainFrameIcon]):
3698         (LayerFlushController::flushLayers):
3699         * WebView/WebWindowAnimation.mm:
3700         (setScaledFrameForWindow):
3701
3702 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3703
3704         Remove unused needsDestruction class variables from HashTraits
3705         https://bugs.webkit.org/show_bug.cgi?id=189490
3706
3707         Reviewed by Daniel Bates.
3708
3709         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3710
3711 2018-09-07  Frederic Wang  <fwang@igalia.com>
3712
3713         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3714         https://bugs.webkit.org/show_bug.cgi?id=182230
3715
3716         Reviewed by Simon Fraser.
3717
3718         * DOM/DOMDocument.mm:
3719         (-[DOMDocument scrollingElement]): Use the new name.
3720
3721 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3722
3723         Refactor WebCore::EditAction to be an 8-bit enum class
3724         https://bugs.webkit.org/show_bug.cgi?id=189383
3725
3726         Reviewed by Dan Bernstein.
3727
3728         * WebCoreSupport/WebEditorClient.mm:
3729         (undoNameForEditAction):
3730         * WebView/WebHTMLView.mm:
3731         (-[WebHTMLView pasteFont:]):
3732         (-[WebHTMLView changeFont:]):
3733         (-[WebHTMLView changeAttributes:]):
3734         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3735         (-[WebHTMLView changeColor:]):
3736         * WebView/WebView.mm:
3737         (-[WebView setTypingStyle:]):
3738
3739 2018-09-06  Frederic Wang  <fwang@igalia.com>
3740
3741         Group options of scrollRectToVisible into a struct
3742         https://bugs.webkit.org/show_bug.cgi?id=189352
3743
3744         Reviewed by Simon Fraser.
3745
3746         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3747         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3748         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3749
3750 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3751
3752         [macOS] Cannot change font size at selection until font panel is shown
3753         https://bugs.webkit.org/show_bug.cgi?id=189295
3754         <rdar://problem/35593389>
3755
3756         Reviewed by Ryosuke Niwa.
3757
3758         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3759         WebCore ChangeLog for more details.
3760
3761         * WebView/WebHTMLView.mm:
3762         (-[WebHTMLView changeFont:]):
3763         (-[WebHTMLView changeAttributes:]):
3764         (-[WebHTMLView _originalFontA]): Deleted.
3765         (-[WebHTMLView _originalFontB]): Deleted.
3766         (fontNameForDescription): Deleted.
3767         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3768         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3769         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3770
3771 2018-09-05  Jer Noble  <jer.noble@apple.com>
3772
3773         Add MediaCapabilities as an Experimental Feature
3774         https://bugs.webkit.org/show_bug.cgi?id=189209
3775
3776         Reviewed by Eric Carlson.
3777
3778         RuntimeEnabledFeature -> Setting.
3779
3780         * WebView/WebView.mm:
3781         (-[WebView _preferencesChanged:]):
3782
3783 2018-09-04  Frederic Wang  <fwang@igalia.com>
3784
3785         Add basic support for ScrollIntoViewOptions
3786         https://bugs.webkit.org/show_bug.cgi?id=189258
3787
3788         Reviewed by Simon Fraser.
3789
3790         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3791         header so that this file can build despite the new scrollIntoView function.
3792
3793 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3794
3795         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3796         https://bugs.webkit.org/show_bug.cgi?id=188890
3797         <rdar://problem/43648605>
3798
3799         Reviewed by Tim Horton.
3800
3801         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3802         more detail.
3803
3804         * WebCoreSupport/WebPlatformStrategies.h:
3805         * WebCoreSupport/WebPlatformStrategies.mm:
3806         (WebPlatformStrategies::allStringsForType):
3807
3808 2018-09-01  Darin Adler  <darin@apple.com>
3809
3810         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3811         https://bugs.webkit.org/show_bug.cgi?id=189072
3812         Reviewed by Dan Bernstein.
3813
3814         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3815         and declarations for NSURLDownload init methods.
3816
3817         * Misc/WebDownloadInternal.h: Removed.
3818
3819         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3820         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3821         "-Wdeprecated-declarations" because the method used here is deprecated.
3822
3823         * WebView/WebView.mm:
3824         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3825         used here is deprecated.
3826
3827 2018-08-31  Chris Dumez  <cdumez@apple.com>
3828
3829         Assertion hit in ~CompletionHandler() from ~WebFrame()
3830         https://bugs.webkit.org/show_bug.cgi?id=189199
3831         <rdar://problem/42657233>
3832
3833         Reviewed by Youenn Fablet.
3834
3835         * WebCoreSupport/WebFrameLoaderClient.h:
3836         * WebCoreSupport/WebFrameLoaderClient.mm:
3837         (WebFrameLoaderClient::dispatchWillSubmitForm):
3838
3839 2018-08-31  Antti Koivisto  <antti@apple.com>
3840
3841         Replace OptionSet |= and -= operators with add() and remove() functions
3842         https://bugs.webkit.org/show_bug.cgi?id=189169
3843
3844         Reviewed by Anders Carlsson.
3845
3846         * WebView/WebFrame.mm:
3847         (-[WebFrame _drawRect:contentsOnly:]):
3848         * WebView/WebView.mm:
3849         (coreOptions):
3850
3851 2018-08-31  Frederic Wang  <fwang@igalia.com>
3852
3853         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3854         https://bugs.webkit.org/show_bug.cgi?id=182053
3855
3856         Reviewed by Simon Fraser.
3857
3858         Add developer flag to use standard behavior for scrolling* attributes.
3859
3860         * WebView/WebPreferenceKeysPrivate.h:
3861         * WebView/WebPreferences.mm:
3862         (+[WebPreferences initialize]):
3863         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3864         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3865         * WebView/WebPreferencesPrivate.h:
3866         * WebView/WebView.mm:
3867         (-[WebView _preferencesChanged:]):
3868
3869 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3870
3871         Implement the Web Share API
3872         https://bugs.webkit.org/show_bug.cgi?id=171100
3873         <rdar://problem/31751734>
3874
3875         Reviewed by Tim Horton.
3876
3877         * WebCoreSupport/WebChromeClient.h:
3878         * WebCoreSupport/WebChromeClient.mm:
3879         (WebChromeClient::showShareSheet):
3880         Empty declaration of showShareSheet.
3881
3882 2018-08-29  Youenn Fablet  <youenn@apple.com>
3883
3884         Remove WebRTC legacy API implementation
3885         https://bugs.webkit.org/show_bug.cgi?id=189040
3886
3887         Reviewed by Eric Carlson.
3888
3889         * WebView/WebPreferenceKeysPrivate.h:
3890         * WebView/WebPreferences.mm:
3891         (+[WebPreferences initialize]):
3892         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3893         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3894         * WebView/WebPreferencesPrivate.h:
3895         * WebView/WebView.mm:
3896         (-[WebView _preferencesChanged:]):
3897
3898 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3899
3900         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3901         https://bugs.webkit.org/show_bug.cgi?id=189054
3902
3903         Reviewed by Andy Estes.
3904
3905         Remove the pasteboard type argument from readURLFromPasteboard.
3906
3907         * WebCoreSupport/WebPlatformStrategies.h:
3908         * WebCoreSupport/WebPlatformStrategies.mm:
3909         (WebPlatformStrategies::readURLFromPasteboard):
3910
3911 2018-08-27  Keith Rollin  <krollin@apple.com>
3912
3913         Unreviewed build fix -- disable LTO for production builds
3914
3915         * Configurations/Base.xcconfig:
3916
3917 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3918
3919         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3920         https://bugs.webkit.org/show_bug.cgi?id=188931
3921
3922         Reviewed by Wenson Hsieh.
3923
3924         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3925
3926 2018-08-27  Keith Rollin  <krollin@apple.com>
3927
3928         Build system support for LTO
3929         https://bugs.webkit.org/show_bug.cgi?id=187785
3930         <rdar://problem/42353132>
3931
3932         Reviewed by Dan Bernstein.
3933
3934         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3935         LTO.
3936
3937         * Configurations/Base.xcconfig:
3938         * Configurations/DebugRelease.xcconfig:
3939
3940 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3941
3942         Pass in IsComposed flag to Event constructors
3943         https://bugs.webkit.org/show_bug.cgi?id=188720
3944         <rdar://problem/43580387>
3945
3946         Reviewed by Simon Fraser.
3947
3948         * WebView/WebPDFView.mm:
3949         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3950         whether it's simulated or not.
3951
3952 2018-08-23  Mark Lam  <mark.lam@apple.com>
3953
3954         Move vmEntryGlobalObject() to VM from CallFrame.
3955         https://bugs.webkit.org/show_bug.cgi?id=188900
3956         <rdar://problem/43655753>
3957
3958         Reviewed by Michael Saboff.
3959
3960         * WebView/WebScriptDebugger.mm:
3961         (WebScriptDebugger::sourceParsed):
3962
3963 2018-08-23  Andy Estes  <aestes@apple.com>
3964
3965         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3966         https://bugs.webkit.org/show_bug.cgi?id=188829
3967
3968         Reviewed by Tim Horton.
3969
3970         * Configurations/FeatureDefines.xcconfig:
3971
3972 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3973
3974         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3975         https://bugs.webkit.org/show_bug.cgi?id=188777
3976
3977         Reviewed by Simon Fraser.
3978
3979         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3980         being "true" before the code change.
3981
3982         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3983
3984         * WebView/WebPDFView.mm:
3985         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3986
3987 2018-08-21  Daniel Bates  <dabates@apple.com>
3988
3989         Replace TextCheckingTypeMask with OptionSet
3990         https://bugs.webkit.org/show_bug.cgi?id=188678
3991
3992         Reviewed by Antti Koivisto.
3993
3994         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3995         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3996         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3997         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3998
3999         * WebCoreSupport/WebEditorClient.h:
4000         * WebCoreSupport/WebEditorClient.mm:
4001         (WebEditorClient::checkTextOfParagraph):
4002         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
4003         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
4004         left as this is more readable and unncessary now that modern compilers like Clang have
4005         diagnostics to catch accidental assignments when equality was intended.
4006         (WebEditorClient::didCheckSucceed):
4007         * WebView/WebView.mm:
4008         (coreTextCheckingType):
4009         (textCheckingResultFromNSTextCheckingResult):
4010
4011 2018-08-21  Daniel Bates  <dabates@apple.com>
4012
4013         [iOS][WK1] Support toggling continuous spell checking from tests
4014         https://bugs.webkit.org/show_bug.cgi?id=188763
4015
4016         Reviewed by Simon Fraser.
4017
4018         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
4019         spell checking from tests in iOS WebKit Legacy.
4020
4021         * WebCoreSupport/WebEditorClient.h:
4022         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
4023         * WebCoreSupport/WebEditorClient.mm:
4024         * WebView/WebView.h:
4025         * WebView/WebView.mm:
4026         (-[WebView toggleContinuousSpellChecking:]):
4027         (-[WebView toggleSmartInsertDelete:]):
4028
4029 2018-08-17  Alex Christensen  <achristensen@webkit.org>
4030
4031         Add some plumbing for safe browsing
4032         https://bugs.webkit.org/show_bug.cgi?id=188709
4033
4034         Reviewed by Tim Horton.
4035
4036         * WebCoreSupport/WebFrameLoaderClient.h:
4037         * WebCoreSupport/WebFrameLoaderClient.mm:
4038         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4039
4040 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
4041
4042         Replace canBubble and cancelable booleans in Event by enum classes
4043         https://bugs.webkit.org/show_bug.cgi?id=188692
4044
4045         Reviewed by Alex Christensen.
4046
4047         * WebView/WebPDFView.mm:
4048         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4049         * WebView/WebView.mm:
4050         (-[WebView _dispatchUnloadEvent]):
4051
4052 2018-08-16  Jer Noble  <jer.noble@apple.com>
4053
4054         Add Experimental Feature support for SourceBuffer.changeType()
4055         https://bugs.webkit.org/show_bug.cgi?id=188626
4056         <rdar://problem/43356021>
4057
4058         Reviewed by Eric Carlson.
4059
4060         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.