Add new mac target numbers
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-23  Keith Miller  <keith_miller@apple.com>
2
3         Add new mac target numbers
4         https://bugs.webkit.org/show_bug.cgi?id=194955
5
6         Reviewed by Tim Horton.
7
8         * Configurations/Base.xcconfig:
9         * Configurations/DebugRelease.xcconfig:
10
11 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
12
13         Hardcode Visual Viewports on everywhere except iOS WK1
14         https://bugs.webkit.org/show_bug.cgi?id=194928
15
16         Reviewed by Zalan Bujtas.
17
18         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
19         change the default value of the Setting to 'true', and hardcode WebView on iOS to
20         set it to false. The setting has shipped for several years and there's no need to turn
21         it off now.
22
23         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
24         Visual Viewports are not enabled.
25         
26         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
27         that only runs in WK2
28
29         * WebView/WebPreferenceKeysPrivate.h:
30         * WebView/WebPreferences.mm:
31         (+[WebPreferences initialize]):
32         (-[WebPreferences visualViewportEnabled]): Deleted.
33         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
34         * WebView/WebPreferencesPrivate.h:
35         * WebView/WebView.mm:
36         (-[WebView _preferencesChanged:]):
37
38 2019-02-21  Darin Adler  <darin@apple.com>
39
40         Some refinements for Node and Document
41         https://bugs.webkit.org/show_bug.cgi?id=194764
42
43         Reviewed by Ryosuke Niwa.
44
45         * DOM/DOMDocument.mm:
46         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
47         through to WebCore or even looking at the arguments.
48         (-[DOMDocument getOverrideStyle::]): Ditto.
49
50 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
51
52         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
53         https://bugs.webkit.org/show_bug.cgi?id=194670
54         <rdar://problem/39066529>
55
56         Reviewed by Tim Horton.
57
58         * WebCoreSupport/WebEditorClient.h:
59         * WebCoreSupport/WebEditorClient.mm:
60         (WebEditorClient::replacementURLForResource): Deleted.
61         * WebCoreSupport/WebPlatformStrategies.h:
62         * WebCoreSupport/WebPlatformStrategies.mm:
63         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
64
65 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
66
67         Add MSE logging configuration
68         https://bugs.webkit.org/show_bug.cgi?id=194719
69         <rdar://problem/48122151>
70
71         Reviewed by Joseph Pecoraro.
72
73         * WebCoreSupport/WebChromeClient.mm:
74         (stringForMessageSource): Recognize the MSE message source.
75
76 2019-02-17  David Kilzer  <ddkilzer@apple.com>
77
78         Unreviewed, rolling out r241620.
79
80         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
81         (Requested by ddkilzer on #webkit.)
82
83         Reverted changeset:
84
85         "[WTF] Add environment variable helpers"
86         https://bugs.webkit.org/show_bug.cgi?id=192405
87         https://trac.webkit.org/changeset/241620
88
89 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
90
91         [WTF] Add environment variable helpers
92         https://bugs.webkit.org/show_bug.cgi?id=192405
93
94         Reviewed by Michael Catanzaro.
95
96         * WebView/WebView.mm:
97         (-[WebView _initWithFrame:frameName:groupName:]):
98         Utilize WTF::Environment where possible.
99
100 2019-02-15  Brian Burg  <bburg@apple.com>
101
102         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
103         https://bugs.webkit.org/show_bug.cgi?id=194411
104         <rdar://problem/47787614>
105
106         Reviewed by Joseph Pecoraro.
107
108         * Configurations/WebKitLegacy.xcconfig:
109         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
110
111         * WebCoreSupport/WebInspectorClient.mm:
112         (WebInspectorFrontendClient::localizedStringsURL):
113         (-[WebInspectorWindowController inspectorPagePath]):
114         (-[WebInspectorWindowController inspectorTestPagePath]):
115         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
116
117 2019-02-15  Commit Queue  <commit-queue@webkit.org>
118
119         Unreviewed, rolling out r241559 and r241566.
120         https://bugs.webkit.org/show_bug.cgi?id=194710
121
122         Causes layout test crashes under GuardMalloc (Requested by
123         ryanhaddad on #webkit).
124
125         Reverted changesets:
126
127         "[WTF] Add environment variable helpers"
128         https://bugs.webkit.org/show_bug.cgi?id=192405
129         https://trac.webkit.org/changeset/241559
130
131         "Unreviewed build fix for WinCairo Debug after r241559."
132         https://trac.webkit.org/changeset/241566
133
134 2019-02-15  Truitt Savell  <tsavell@apple.com>
135
136         Unreviewed, rolling out r241564.
137
138         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
139
140         Reverted changeset:
141
142         "[Mac] WebInspectorUI.framework does not need to be soft-
143         linked anymore"
144         https://bugs.webkit.org/show_bug.cgi?id=194411
145         https://trac.webkit.org/changeset/241564
146
147 2019-02-14  Brian Burg  <bburg@apple.com>
148
149         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
150         https://bugs.webkit.org/show_bug.cgi?id=194411
151         <rdar://problem/47787614>
152
153         Reviewed by Joseph Pecoraro.
154
155         * Configurations/WebKitLegacy.xcconfig:
156         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
157
158         * WebCoreSupport/WebInspectorClient.mm:
159         (WebInspectorFrontendClient::localizedStringsURL):
160         (-[WebInspectorWindowController inspectorPagePath]):
161         (-[WebInspectorWindowController inspectorTestPagePath]):
162         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
163
164 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
165
166         [WTF] Add environment variable helpers
167         https://bugs.webkit.org/show_bug.cgi?id=192405
168
169         Reviewed by Michael Catanzaro.
170
171         * WebView/WebView.mm:
172         (-[WebView _initWithFrame:frameName:groupName:]):
173         Utilize WTF::Environment where possible.
174
175 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
176
177         Allow pages to trigger programmatic paste from script on iOS
178         https://bugs.webkit.org/show_bug.cgi?id=194271
179         <rdar://problem/47808810>
180
181         Reviewed by Ryosuke Niwa.
182
183         See WebCore and WebKit ChangeLogs for more details.
184
185         * WebCoreSupport/WebEditorClient.h:
186
187 2019-02-12  Andy Estes  <aestes@apple.com>
188
189         [iOSMac] Enable Parental Controls Content Filtering
190         https://bugs.webkit.org/show_bug.cgi?id=194521
191         <rdar://39732376>
192
193         Reviewed by Tim Horton.
194
195         * Configurations/FeatureDefines.xcconfig:
196
197 2019-02-06  Andy Estes  <aestes@apple.com>
198
199         [Payment Request] It should be possible to require a phonetic name for shipping contacts
200         https://bugs.webkit.org/show_bug.cgi?id=194311
201         <rdar://46733045>
202
203         Reviewed by Alex Christensen.
204
205         * WebCoreSupport/WebPaymentCoordinatorClient.h:
206         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
207         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
208
209 2019-02-04  Said Abou-Hallawa  <said@apple.com>
210
211         [CG] Enable setAdditionalSupportedImageTypes for WK1
212         https://bugs.webkit.org/show_bug.cgi?id=194190
213
214         Reviewed by Tim Horton.
215
216         1. Define the preferences key AdditionalSupportedImageTypes.
217         2. Add additionalSupportedImageTypes as a private preference property.
218         3. Define the setter and the getter of the property.
219         4. Add function to convert from an id to an array of strings.
220         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
221
222         * WebView/WebPreferenceKeysPrivate.h:
223         * WebView/WebPreferences.mm:
224         (-[WebPreferences _stringArrayValueForKey:]):
225         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
226         (-[WebPreferences setAdditionalSupportedImageTypes:]):
227         (-[WebPreferences additionalSupportedImageTypes]):
228         * WebView/WebPreferencesPrivate.h:
229         * WebView/WebView.mm:
230         (-[WebView _preferencesChanged:]):
231
232 2019-02-04  Timothy Hatcher  <timothy@apple.com>
233
234         Add WebView SPI to temporarily force light or dark appearance on a page.
235         https://bugs.webkit.org/show_bug.cgi?id=194230
236
237         Reviewed by Tim Horton.
238
239         * WebView/WebView.mm:
240         (-[WebView _useDarkAppearance:]): Added.
241         (-[WebView _setUseDarkAppearance:]): Added.
242         * WebView/WebViewPrivate.h:
243
244 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
245
246         PageOverlayController's layers should be created lazily
247         https://bugs.webkit.org/show_bug.cgi?id=194199
248         rdar://problem/46571593
249
250         Reviewed by Tim Horton.
251
252         * WebCoreSupport/WebChromeClient.h:
253         * WebCoreSupport/WebChromeClient.mm:
254         (WebChromeClient::attachViewOverlayGraphicsLayer):
255
256 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
257
258         Make setNeedsLayout on the root more explicitly about triggering its side-effects
259         https://bugs.webkit.org/show_bug.cgi?id=194198
260
261         Reviewed by Antti Koivisto.
262
263         Call the newly named functions.
264
265         * WebView/WebFrame.mm:
266         (-[WebFrame setNeedsLayout]):
267         * WebView/WebHTMLView.mm:
268         (-[WebHTMLView setNeedsLayout:]):
269
270 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
271
272         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
273         https://bugs.webkit.org/show_bug.cgi?id=194189
274
275         Reviewed by Geoffrey Garen.
276
277         Pass the policy check identifier around functions and store it in WebFramePolicyListener
278         so that we can send it back to WebCore with the navigation policy decision.
279
280         * WebCoreSupport/WebFrameLoaderClient.h:
281         * WebCoreSupport/WebFrameLoaderClient.mm:
282         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
283         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
284         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
285         (WebFrameLoaderClient::dispatchWillSubmitForm):
286         (WebFrameLoaderClient::setUpPolicyListener):
287         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
288         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
289         (-[WebFramePolicyListener invalidate]):
290         (-[WebFramePolicyListener dealloc]):
291         (-[WebFramePolicyListener receivedPolicyDecision:]):
292         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
293         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
294
295 2019-01-31  Alex Christensen  <achristensen@webkit.org>
296
297         Revert r238819 which is unneeded and caused a performance regression.
298         https://bugs.webkit.org/show_bug.cgi?id=192272
299         <rdar://problem/46664625>
300
301         * WebCoreSupport/WebFrameLoaderClient.h:
302         * WebCoreSupport/WebFrameLoaderClient.mm:
303         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
304
305 2019-01-28  Devin Rousso  <drousso@apple.com>
306
307         Web Inspector: provide a way to edit page WebRTC settings on a remote target
308         https://bugs.webkit.org/show_bug.cgi?id=193863
309         <rdar://problem/47572764>
310
311         Reviewed by Joseph Pecoraro.
312
313         * WebView/WebView.mm:
314         (-[WebView _preferencesChanged:]):
315         Add page-level settings for WebRTC preferences.
316
317 2019-01-28  Andy Estes  <aestes@apple.com>
318
319         [watchOS] Enable Parental Controls content filtering
320         https://bugs.webkit.org/show_bug.cgi?id=193939
321         <rdar://problem/46641912>
322
323         Reviewed by Ryosuke Niwa.
324
325         * Configurations/FeatureDefines.xcconfig:
326
327 2019-01-28  Timothy Hatcher  <timothy@apple.com>
328
329         Make it easier for non-Apple ports to enable dark mode CSS support.
330         https://bugs.webkit.org/show_bug.cgi?id=193882
331
332         Reviewed by Megan Gardner.
333
334         * WebView/WebView.mm:
335         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
336         (-[WebView _effectiveAppearanceIsDark]): Ditto.
337
338 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
339
340         AX: Introduce a static accessibility tree
341         https://bugs.webkit.org/show_bug.cgi?id=193348
342         <rdar://problem/47203295>
343
344         Reviewed by Ryosuke Niwa.
345
346         * Configurations/FeatureDefines.xcconfig:
347
348 2019-01-25  Keith Rollin  <krollin@apple.com>
349
350         Update WebKitAdditions.xcconfig with correct order of variable definitions
351         https://bugs.webkit.org/show_bug.cgi?id=193793
352         <rdar://problem/47532439>
353
354         Reviewed by Alex Christensen.
355
356         XCBuild changes the way xcconfig variables are evaluated. In short,
357         all config file assignments are now considered in part of the
358         evaluation. When using the new build system and an .xcconfig file
359         contains multiple assignments of the same build setting:
360
361         - Later assignments using $(inherited) will inherit from earlier
362           assignments in the xcconfig file.
363         - Later assignments not using $(inherited) will take precedence over
364           earlier assignments. An assignment to a more general setting will
365           mask an earlier assignment to a less general setting. For example,
366           an assignment without a condition ('FOO = bar') will completely mask
367           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
368
369         This affects some of our .xcconfig files, in that sometimes platform-
370         or sdk-specific definitions appear before the general definitions.
371         Under the new evaluations rules, the general definitions alway take
372         effect because they always overwrite the more-specific definitions. The
373         solution is to swap the order, so that the general definitions are
374         established first, and then conditionally overwritten by the
375         more-specific definitions.
376
377         * Configurations/Version.xcconfig:
378         * Configurations/WebKitLegacy.xcconfig:
379
380 2019-01-25  David Kilzer  <ddkilzer@apple.com>
381
382         Move soft-linking of Lookup.framework out of LookupSPI.h
383         <https://webkit.org/b/193815>
384
385         Reviewed by Tim Horton.
386
387         * WebView/WebImmediateActionController.mm:
388         (-[WebImmediateActionController _animationControllerForText]):
389         * WebView/WebView.mm:
390         (-[WebView _prepareForDictionaryLookup]):
391         - Move soft-linking to LookupSoftLink.{h,mm}.
392
393 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
394
395         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
396         https://bugs.webkit.org/show_bug.cgi?id=193829
397
398         Reviewed by Tim Horton.
399
400         * WebCoreSupport/WebDragClient.mm:
401         (WebDragClient::didConcludeEditDrag):
402         * WebView/WebView.mm:
403         (-[WebView _requestStartDataInteraction:globalPosition:]):
404         (-[WebView _didConcludeEditDrag]):
405         (-[WebView _didConcludeEditDataInteraction]): Deleted.
406         * WebView/WebViewInternal.h:
407
408 2019-01-24  John Wilander  <wilander@apple.com>
409
410         Add Ad Click Attribution as an internal/experimental feature
411         https://bugs.webkit.org/show_bug.cgi?id=193685
412         <rdar://problem/47450399>
413
414         Reviewed by Brent Fulgham.
415
416         * WebView/WebPreferenceKeysPrivate.h:
417         * WebView/WebPreferences.mm:
418         (+[WebPreferences initialize]):
419         (-[WebPreferences adClickAttributionEnabled]):
420         (-[WebPreferences setAdClickAttributionEnabled:]):
421             Added support for experimental ad click attribution.
422         * WebView/WebPreferencesPrivate.h:
423         * WebView/WebView.mm:
424         (-[WebView _preferencesChanged:]):
425
426 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
427
428         Move FileSystem to WTF
429         https://bugs.webkit.org/show_bug.cgi?id=193602
430
431         Reviewed by Yusuke Suzuki.
432
433         * Misc/WebNSFileManagerExtras.mm:
434         * Storage/WebDatabaseProvider.mm:
435         * WebView/WebView.mm:
436
437 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
438
439         Fix the Apple Internal build. See <rdar://problem/47491383>.
440
441         Rubber-stamped by Tim Horton.
442
443         * WebCoreSupport/WebFrameLoaderClient.mm:
444
445 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
446
447         Clean up USE(WEB_THREAD)
448         https://bugs.webkit.org/show_bug.cgi?id=193698
449
450         Rubber-stamped by Tim Horton.
451
452         * Misc/WebCache.mm:
453         (+[WebCache emptyInMemoryResources]):
454         * WebCoreSupport/WebFrameLoaderClient.mm:
455         (-[WebFramePolicyListener use]):
456         * WebCoreSupport/WebGeolocationClient.mm:
457         (-[WebGeolocationPolicyListener allow]):
458         (-[WebGeolocationPolicyListener deny]):
459         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
460         * WebView/WebFrame.mm:
461         (-[WebFrame deviceOrientationChanged]):
462         * WebView/WebHTMLView.mm:
463         (hardwareKeyboardAvailabilityChangedCallback):
464         * WebView/WebView.mm:
465         (+[WebView _releaseMemoryNow]):
466         (+[WebView willEnterBackgroundWithCompletionHandler:]):
467         (-[WebView updateLayoutIgnorePendingStyleSheets]):
468         (-[WebView _dispatchUnloadEvent]):
469         (-[WebView _close]):
470         (-[WebView _preferencesChangedNotification:]):
471         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
472         (-[WebView goBack]):
473         (-[WebView goForward]):
474         (+[WebView _cacheModelChangedNotification:]):
475         (-[WebView stopLoading:]):
476         (-[WebView stopLoadingAndClear]):
477         (-[WebView reload:]):
478         (WebInstallMemoryPressureHandler):
479
480 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
481
482         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
483         https://bugs.webkit.org/show_bug.cgi?id=193706
484         <rdar://problem/44807048>
485
486         Reviewed by Ryosuke Niwa.
487
488         Use UndoStep::label().
489
490         * WebCoreSupport/WebEditorClient.h:
491         * WebCoreSupport/WebEditorClient.mm:
492         (-[WebUndoStep initWithUndoStep:]):
493         (+[WebUndoStep stepWithUndoStep:]):
494         (WebEditorClient::registerUndoOrRedoStep):
495         (WebEditorClient::registerUndoStep):
496         (WebEditorClient::registerRedoStep):
497
498 2019-01-22  Alex Christensen  <achristensen@webkit.org>
499
500         Move NetworkStorageSession ownership to NetworkProcess
501         https://bugs.webkit.org/show_bug.cgi?id=193580
502
503         Reviewed by Geoff Garen.
504
505         * Misc/WebCache.mm:
506         (+[WebCache clearCachedCredentials]):
507         * Misc/WebDownload.mm:
508         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
509         * Plugins/WebBaseNetscapePluginView.mm:
510         (WebKit::getAuthenticationInfo):
511         * WebCoreSupport/WebFrameNetworkingContext.mm:
512         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
513         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
514         (WebFrameNetworkingContext::storageSession const):
515         * WebView/WebPreferences.mm:
516         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
517         (+[WebPreferences _clearNetworkLoaderSession]):
518         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
519
520 2019-01-22  Daniel Bates  <dabates@apple.com>
521
522         [iOS] Interpret text key commands on keydown and app key commands on keypress
523         https://bugs.webkit.org/show_bug.cgi?id=192897
524         <rdar://problem/46857378>
525
526         Reviewed by Brent Fulgham.
527
528         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
529         is false) and keypress (isCharEvent is true), respectively.
530
531         * WebView/WebHTMLView.mm:
532         (-[WebHTMLView _handleEditingKeyEvent:]):
533
534 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
535
536         [css-logical] Implement flow-relative margin, padding and border shorthands
537         https://bugs.webkit.org/show_bug.cgi?id=188697
538
539         Reviewed by Simon Fraser and Antti Koivisto.
540
541         Add CSSLogicalEnabled runtime flag.
542
543         * WebView/WebPreferenceKeysPrivate.h:
544         * WebView/WebPreferences.mm:
545         (+[WebPreferences initialize]):
546         (-[WebPreferences cssLogicalEnabled]):
547         (-[WebPreferences setCSSLogicalEnabled:]):
548         * WebView/WebPreferencesPrivate.h:
549         * WebView/WebView.mm:
550         (-[WebView _preferencesChanged:]):
551
552 2019-01-15  Darin Adler  <darin@apple.com>
553
554         Use references rather than pointers for register/unregister functions, and more
555         https://bugs.webkit.org/show_bug.cgi?id=175028
556
557         Reviewed by Daniel Bates.
558
559         * WebCoreSupport/WebKitFullScreenListener.mm:
560         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
561         functions in Document; pass a reference.
562         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
563         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
564         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
565         * WebView/WebFullScreenController.mm:
566         (-[WebFullScreenController enterFullScreen:]): Ditto.
567         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
568         (-[WebFullScreenController exitFullScreen]): Ditto.
569         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
570         * WebView/WebFullScreenController.mm:
571         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
572
573 2019-01-12  Dan Bernstein  <mitz@apple.com>
574
575         [Cocoa] Avoid importing directly from subumbrella frameworks
576         https://bugs.webkit.org/show_bug.cgi?id=186016
577         <rdar://problem/40591038>
578
579         Reviewed by Sam Weinig.
580
581         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
582         * Carbon/CarbonWindowAdapter.mm: Ditto.
583         * Carbon/CarbonWindowFrame.m: Ditto.
584         * Carbon/HIViewAdapter.h: Ditto.
585         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
586           OTHER_CFLAGS_COCOA_TOUCH_NO.
587         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
588         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
589         * WebView/WebPDFView.h: Ditto.
590
591 2019-01-20  Antoine Quint  <graouts@apple.com>
592
593         Add a POINTER_EVENTS feature flag
594         https://bugs.webkit.org/show_bug.cgi?id=193577
595         <rdar://problem/47408511>
596
597         Unreviewed. Also enable Pointer Events for iosmac.
598
599         * Configurations/FeatureDefines.xcconfig:
600
601 2019-01-19  Antoine Quint  <graouts@apple.com>
602
603         Add a POINTER_EVENTS feature flag
604         https://bugs.webkit.org/show_bug.cgi?id=193577
605
606         Reviewed by Dean Jackson.
607
608         * Configurations/FeatureDefines.xcconfig:
609
610 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
611
612         Revert r238815, it broke WK1 video fullscreen on Mac
613         https://bugs.webkit.org/show_bug.cgi?id=193586
614         <rdar://problem/47358941>
615
616         Reviewed by Jer Noble.
617
618         * WebView/WebVideoFullscreenController.h: Added.
619         * WebView/WebVideoFullscreenController.mm: Added.
620         (SOFT_LINK_CLASS):
621         (-[WebVideoFullscreenController init]):
622         (-[WebVideoFullscreenController dealloc]):
623         (-[WebVideoFullscreenController fullscreenWindow]):
624         (-[WebVideoFullscreenController windowDidLoad]):
625         (-[WebVideoFullscreenController videoElement]):
626         (-[WebVideoFullscreenController setVideoElement:]):
627         (-[WebVideoFullscreenController clearFadeAnimation]):
628         (-[WebVideoFullscreenController windowDidExitFullscreen]):
629         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
630         (-[WebVideoFullscreenController videoElementRect]):
631         (-[WebVideoFullscreenController applicationDidResignActive:]):
632         (frameExpandedToRatioOfFrame):
633         (createBackgroundFullscreenWindow):
634         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
635         (-[WebVideoFullscreenController enterFullscreen:]):
636         (-[WebVideoFullscreenController exitFullscreen]):
637         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
638         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
639         (-[WebVideoFullscreenController _requestExit]):
640         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
641         (-[WebVideoFullscreenController requestExitFullscreen]):
642         (-[WebVideoFullscreenController fadeHUDIn]):
643         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
644         (-[WebVideoFullscreenController rateChanged:]):
645         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
646         (-[WebVideoFullscreenWindow dealloc]):
647         (-[WebVideoFullscreenWindow resignFirstResponder]):
648         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
649         (-[WebVideoFullscreenWindow mouseDown:]):
650         (-[WebVideoFullscreenWindow cancelOperation:]):
651         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
652         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
653         (-[WebVideoFullscreenWindow animationDidEnd:]):
654         (-[WebVideoFullscreenWindow mouseMoved:]):
655         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
656         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
657         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
658         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
659         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
660         (-[WebVideoFullscreenHUDWindow center]):
661         (-[WebVideoFullscreenHUDWindow keyDown:]):
662         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
663         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
664         (-[WebVideoFullscreenHUDWindowController init]):
665         (-[WebVideoFullscreenHUDWindowController dealloc]):
666         (-[WebVideoFullscreenHUDWindowController setArea:]):
667         (-[WebVideoFullscreenHUDWindowController keyDown:]):
668         (-[WebVideoFullscreenHUDWindowController delegate]):
669         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
670         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
671         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
672         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
673         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
674         (-[WebVideoFullscreenHUDWindowController closeWindow]):
675         (createMediaUIControl):
676         (createControlWithMediaUIControlType):
677         (createTimeTextField):
678         (createMediaUIBackgroundView):
679         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
680         (-[WebVideoFullscreenHUDWindowController updateVolume]):
681         (-[WebVideoFullscreenHUDWindowController updateTime]):
682         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
683         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
684         (-[WebVideoFullscreenHUDWindowController currentTime]):
685         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
686         (-[WebVideoFullscreenHUDWindowController duration]):
687         (-[WebVideoFullscreenHUDWindowController maxVolume]):
688         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
689         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
690         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
691         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
692         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
693         (-[WebVideoFullscreenHUDWindowController volume]):
694         (-[WebVideoFullscreenHUDWindowController setVolume:]):
695         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
696         (-[WebVideoFullscreenHUDWindowController updateRate]):
697         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
698         (-[WebVideoFullscreenHUDWindowController playing]):
699         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
700         (timeToString):
701         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
702         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
703         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
704         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
705         (-[WebVideoFullscreenHUDWindowController rewind:]):
706         (-[WebVideoFullscreenHUDWindowController fastForward:]):
707         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
708         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
709         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
710         * WebView/WebView.mm:
711         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
712         (-[WebView _exitVideoFullscreen]):
713
714 2019-01-18  Tim Horton  <timothy_horton@apple.com>
715
716         Get rid of ADVANCED_SPELL_CHECKING
717         https://bugs.webkit.org/show_bug.cgi?id=193592
718
719         Reviewed by Wenson Hsieh.
720
721         * WebCoreSupport/WebEditorClient.mm:
722         (insertionPointFromCurrentSelection):
723         (WebEditorClient::checkTextOfParagraph):
724         (WebEditorClient::getGuessesForWord):
725         (WebEditorClient::requestCandidatesForSelection):
726         (WebEditorClient::requestCheckingOfString):
727         * WebView/WebHTMLView.mm:
728         (-[WebHTMLView insertText:]):
729
730 2019-01-18  Jer Noble  <jer.noble@apple.com>
731
732         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
733         https://bugs.webkit.org/show_bug.cgi?id=189553
734
735         Reviewed by Tim Horton.
736
737         * Configurations/Base.xcconfig:
738         * Configurations/SDKVariant.xcconfig: Added.
739         * Configurations/WebKitLegacy.xcconfig:
740
741 2019-01-18  David Kilzer  <ddkilzer@apple.com>
742
743         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
744         <https://webkit.org/b/193568>
745         <rdar://problem/47381130>
746
747         Reviewed by Alex Christensen.
748
749         * WebView/WebView.mm:
750         - Remove unused soft-linking macros.
751         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
752         (-[WebUITextIndicatorData initWithImage:scale:]):
753         - Update to use exported PAL functions.
754
755 2019-01-17  Truitt Savell  <tsavell@apple.com>
756
757         Unreviewed, rolling out r240124.
758
759         This commit broke an internal build.
760
761         Reverted changeset:
762
763         "SDK_VARIANT build destinations should be separate from non-
764         SDK_VARIANT builds"
765         https://bugs.webkit.org/show_bug.cgi?id=189553
766         https://trac.webkit.org/changeset/240124
767
768 2019-01-17  Jer Noble  <jer.noble@apple.com>
769
770         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
771         https://bugs.webkit.org/show_bug.cgi?id=189553
772
773         Reviewed by Tim Horton.
774
775         * Configurations/Base.xcconfig:
776         * Configurations/SDKVariant.xcconfig: Added.
777         * Configurations/WebKitLegacy.xcconfig:
778
779 2019-01-17  Alex Christensen  <achristensen@webkit.org>
780
781         Stop using NetworkStorageSession::storageSession in WebCore
782         https://bugs.webkit.org/show_bug.cgi?id=193529
783
784         Reviewed by Tim Horton.
785
786         * Misc/WebCache.mm:
787         (+[WebCache addImageToCache:forURL:forFrame:]):
788         * WebView/WebView.mm:
789         (-[WebView _commonInitializationWithFrameName:groupName:]):
790         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
791
792 2019-01-15  Alex Christensen  <achristensen@webkit.org>
793
794         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
795         https://bugs.webkit.org/show_bug.cgi?id=193368
796
797         Reviewed by Geoff Garen.
798
799         * Misc/WebCache.mm:
800         (+[WebCache clearCachedCredentials]):
801         * Misc/WebDownload.mm:
802         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
803         * Plugins/WebBaseNetscapePluginView.mm:
804         (WebKit::getAuthenticationInfo):
805
806 2019-01-15  Alex Christensen  <achristensen@webkit.org>
807
808         Stop using CookiesStrategy
809         https://bugs.webkit.org/show_bug.cgi?id=161106
810
811         Reviewed by Don Olmstead and Antti Koivisto.
812
813         * Misc/WebCache.mm:
814         (+[WebCache addImageToCache:forURL:forFrame:]):
815         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
816         (WebKit::NetscapePluginInstanceProxy::getCookies):
817         (WebKit::NetscapePluginInstanceProxy::setCookies):
818         * Plugins/WebNetscapePluginView.mm:
819         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
820         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
821         * WebCoreSupport/WebPlatformStrategies.h:
822         * WebCoreSupport/WebPlatformStrategies.mm:
823         (WebPlatformStrategies::createCookiesStrategy): Deleted.
824         (WebPlatformStrategies::cookiesForDOM): Deleted.
825         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
826         (WebPlatformStrategies::cookiesEnabled): Deleted.
827         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
828         (WebPlatformStrategies::getRawCookies): Deleted.
829         (WebPlatformStrategies::deleteCookie): Deleted.
830         * WebView/WebView.mm:
831         (-[WebView _commonInitializationWithFrameName:groupName:]):
832         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
833
834 2019-01-15  Tim Horton  <timothy_horton@apple.com>
835
836         Cannot tab out of WKWebView on macOS
837         https://bugs.webkit.org/show_bug.cgi?id=161448
838         <rdar://problem/28100085>
839
840         Reviewed by Dean Jackson.
841
842         * WebCoreSupport/WebChromeClient.mm:
843         * WebView/WebView.mm:
844         Make use of SPI headers.
845
846 2019-01-14  Commit Queue  <commit-queue@webkit.org>
847
848         Unreviewed, rolling out r239901, r239909, r239910, r239912,
849         r239913, and r239914.
850         https://bugs.webkit.org/show_bug.cgi?id=193407
851
852         These revisions caused an internal failure (Requested by
853         Truitt on #webkit).
854
855         Reverted changesets:
856
857         "[Cocoa] Avoid importing directly from subumbrella frameworks"
858         https://bugs.webkit.org/show_bug.cgi?id=186016
859         https://trac.webkit.org/changeset/239901
860
861         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
862         https://trac.webkit.org/changeset/239909
863
864         "Tried to fix the build."
865         https://trac.webkit.org/changeset/239910
866
867         "Fixed iOS builds after r239910."
868         https://trac.webkit.org/changeset/239912
869
870         "More build fixing."
871         https://trac.webkit.org/changeset/239913
872
873         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
874         https://trac.webkit.org/changeset/239914
875
876 2019-01-14  Mark Lam  <mark.lam@apple.com>
877
878         Re-enable ability to build --cloop builds.
879         https://bugs.webkit.org/show_bug.cgi?id=192955
880         <rdar://problem/46882363>
881
882         Reviewed by Saam barati and Keith Miller.
883
884         * Configurations/FeatureDefines.xcconfig:
885
886 2019-01-13  Dan Bernstein  <mitz@apple.com>
887
888         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
889
890         Patch by Keith Rollin.
891
892         * WebView/PDFViewSPI.h:
893
894 2019-01-12  Timothy Hatcher  <timothy@apple.com>
895
896         Have prefers-color-scheme: light always match on macOS versions before Mojave.
897         https://bugs.webkit.org/show_bug.cgi?id=191655
898         rdar://problem/46074680
899
900         Reviewed by Megan Gardner.
901
902         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
903         * WebView/WebView.mm:
904         (-[WebView _effectiveAppearanceIsDark]):
905
906 2019-01-12  Dan Bernstein  <mitz@apple.com>
907
908         [Cocoa] Avoid importing directly from subumbrella frameworks
909         https://bugs.webkit.org/show_bug.cgi?id=186016
910         <rdar://problem/40591038>
911
912         Reviewed by Sam Weinig.
913
914         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
915         * Carbon/CarbonWindowAdapter.mm: Ditto.
916         * Carbon/CarbonWindowFrame.m: Ditto.
917         * Carbon/HIViewAdapter.h: Ditto.
918         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
919           OTHER_CFLAGS_COCOA_TOUCH_NO.
920         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
921         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
922         * WebView/WebPDFView.h: Ditto.
923
924 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
925
926         Enable visual viewport API by default
927         https://bugs.webkit.org/show_bug.cgi?id=193376
928
929         Reviewed by Simon Fraser.
930
931         * WebView/WebPreferences.mm:
932         (+[WebPreferences initialize]):
933
934 2019-01-11  John Wilander  <wilander@apple.com>
935
936         Compile out Web API Statistics Collection
937         https://bugs.webkit.org/show_bug.cgi?id=193370
938         <rdar://problem/45388584>
939
940         Reviewed by Brent Fulgham.
941
942         * Configurations/FeatureDefines.xcconfig:
943             Defined ENABLE_WEB_API_STATISTICS, off by default.
944
945 2019-01-08  Alex Christensen  <achristensen@webkit.org>
946
947         Stop using NetworkStorageSession in WebProcess
948         https://bugs.webkit.org/show_bug.cgi?id=193236
949
950         Reviewed by Don Olmstead.
951
952         * WebCoreSupport/WebFrameNetworkingContext.h:
953         * WebCoreSupport/WebFrameNetworkingContext.mm:
954         (WebFrameNetworkingContext::storageSession const):
955         * WebCoreSupport/WebPlatformStrategies.h:
956         * WebCoreSupport/WebPlatformStrategies.mm:
957         (WebPlatformStrategies::cookiesForDOM):
958         (WebPlatformStrategies::setCookiesFromDOM):
959         (WebPlatformStrategies::cookiesEnabled):
960         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
961         (WebPlatformStrategies::getRawCookies):
962         (WebPlatformStrategies::deleteCookie):
963         * WebView/WebView.mm:
964         (-[WebView _cachedResponseForURL:]):
965         (-[WebView _clearCredentials]):
966
967 2019-01-08  Alex Christensen  <achristensen@webkit.org>
968
969         Unreviewed, rolling out r239727.
970
971         Broke API tests
972
973         Reverted changeset:
974
975         "Stop using NetworkStorageSession in WebProcess"
976         https://bugs.webkit.org/show_bug.cgi?id=193236
977         https://trac.webkit.org/changeset/239727
978
979 2019-01-08  Alex Christensen  <achristensen@webkit.org>
980
981         Stop using NetworkStorageSession in WebProcess
982         https://bugs.webkit.org/show_bug.cgi?id=193236
983
984         Reviewed by Don Olmstead.
985
986         * WebCoreSupport/WebFrameNetworkingContext.h:
987         * WebCoreSupport/WebFrameNetworkingContext.mm:
988         (WebFrameNetworkingContext::storageSession const):
989         * WebView/WebView.mm:
990         (-[WebView _cachedResponseForURL:]):
991         (-[WebView _clearCredentials]):
992
993 2019-01-07  David Kilzer  <ddkilzer@apple.com>
994
995         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
996         <https://webkit.org/b/193056>
997
998         Reviewed by Alex Christensen.
999
1000         * Plugins/Hosted/NetscapePluginHostProxy.h:
1001         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1002         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1003         (WebKit::NetscapePluginInstanceProxy::enumerate):
1004         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1005         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1006         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1007         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1008         * Plugins/Hosted/ProxyInstance.mm:
1009         (WebKit::ProxyInstance::invoke):
1010         * WebCoreSupport/WebGeolocationClient.mm:
1011         * WebView/WebDataSource.mm:
1012         (-[WebDataSource _receivedData:]):
1013         * WebView/WebView.mm:
1014         (-[WebView _cachedResponseForURL:]):
1015         - Remove '*' from RetainPtr<> type.
1016
1017 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1018
1019         Progress towards fixing Mac CMake build
1020         https://bugs.webkit.org/show_bug.cgi?id=193105
1021
1022         Reviewed by Don Olmstead.
1023
1024         * WebKitPrefix.h:
1025
1026 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1027
1028         Web Inspector: Use save sheet instead of dialog where possible
1029         https://bugs.webkit.org/show_bug.cgi?id=193160
1030         <rdar://problem/37399759>
1031
1032         Reviewed by Devin Rousso.
1033
1034         * WebCoreSupport/WebInspectorClient.mm:
1035         (WebInspectorFrontendClient::save):
1036
1037 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1038
1039         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1040         https://bugs.webkit.org/show_bug.cgi?id=193129
1041
1042         Reviewed by Tim Horton.
1043
1044         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1045
1046         * WebCoreSupport/WebEditorClient.mm:
1047         (WebEditorClient::registerUndoOrRedoStep):
1048         (undoNameForEditAction): Deleted.
1049
1050 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1051
1052         Add support for using the current text selection as the find string on iOS
1053         https://bugs.webkit.org/show_bug.cgi?id=193034
1054         <rdar://problem/45138739>
1055
1056         Reviewed by Tim Horton.
1057
1058         Add a method stub for WebKitLegacy.
1059
1060         * WebCoreSupport/WebEditorClient.h:
1061
1062 2019-01-01  Jeff Miller  <jeffm@apple.com>
1063
1064         Update user-visible copyright strings to include 2019
1065         https://bugs.webkit.org/show_bug.cgi?id=192811
1066
1067         Reviewed by Mark Lam.
1068
1069         * Info.plist:
1070
1071 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1072
1073         Use Ref<> as much as possible
1074         https://bugs.webkit.org/show_bug.cgi?id=192808
1075
1076         Reviewed by Alex Christensen.
1077
1078         * DOM/DOM.mm:
1079         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1080         * Plugins/Hosted/NetscapePluginHostManager.mm:
1081         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1082         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1083         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1084         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1085         * Plugins/WebNetscapePluginView.mm:
1086         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1087         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1088         * WebCoreSupport/WebContextMenuClient.mm:
1089         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1090         * WebCoreSupport/WebFrameLoaderClient.mm:
1091         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1092         * WebView/WebFrame.mm:
1093         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1094         * WebView/WebHTMLView.mm:
1095         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1096         * WebView/WebView.mm:
1097         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1098         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1099
1100 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1101
1102         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1103         https://bugs.webkit.org/show_bug.cgi?id=192821
1104
1105         Reviewed by Chris Dumez.
1106
1107         When a window becomes occluded, the window server informs the application.
1108         This should be used to suspend any work that is not visible by the user.
1109
1110         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1111         In some cases, that lead to performance impact (see radar).
1112
1113         This patch adds an observer for the occlusion notification. I tried to stick
1114         with the same names used by WebKit2.
1115
1116         * WebView/WebView.mm:
1117         (-[WebView _isViewVisible]):
1118         (-[WebView addWindowObserversForWindow:]):
1119         (-[WebView removeWindowObservers]):
1120         (-[WebView _windowDidChangeOcclusionState:]):
1121
1122 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1123
1124         [WebAuthN] Add a runtime flag for local authenticator
1125         https://bugs.webkit.org/show_bug.cgi?id=192792
1126         <rdar://problem/46798738>
1127
1128         Reviewed by Brent Fulgham.
1129
1130         * WebView/WebPreferenceKeysPrivate.h:
1131         * WebView/WebPreferences.mm:
1132         (+[WebPreferences initialize]):
1133         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1134         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1135         * WebView/WebPreferencesPrivate.h:
1136         * WebView/WebView.mm:
1137         (-[WebView _preferencesChanged:]):
1138
1139 2018-12-20  Chris Dumez  <cdumez@apple.com>
1140
1141         Use Optional::valueOr() instead of Optional::value_or()
1142         https://bugs.webkit.org/show_bug.cgi?id=192933
1143
1144         Reviewed by Geoffrey Garen.
1145
1146         * WebCoreSupport/WebSecurityOrigin.mm:
1147         (-[WebSecurityOrigin port]):
1148
1149 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1150
1151         Unreviewed, rolling out r239417.
1152
1153         Introduced two API test failures on macOS.
1154
1155         Reverted changeset:
1156
1157         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1158         occlusion changes"
1159         https://bugs.webkit.org/show_bug.cgi?id=192821
1160         https://trac.webkit.org/changeset/239417
1161
1162 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1163
1164         WKWebView default UA doesn't freeze the build number
1165         https://bugs.webkit.org/show_bug.cgi?id=192809
1166         <rdar://problem/44687185>
1167
1168         Reviewed by Andy Estes.
1169
1170         Always reports the frozen build number.
1171
1172         * WebView/WebView.mm:
1173         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1174         actual build number through this method call.
1175         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1176
1177 2018-12-19  Chris Dumez  <cdumez@apple.com>
1178
1179         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1180         https://bugs.webkit.org/show_bug.cgi?id=192728
1181         <rdar://problem/46746779>
1182
1183         Reviewed by Geoff Garen.
1184
1185         * DOM/*:
1186         * Plugins/*:
1187         * WebCoreSupport/*:
1188         * WebView/*:
1189
1190 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1191
1192         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1193         https://bugs.webkit.org/show_bug.cgi?id=192821
1194
1195         Reviewed by Chris Dumez.
1196
1197         When a window becomes occluded, the window server informs the application.
1198         This should be used to suspend any work that is not visible by the user.
1199
1200         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1201         In some cases, that lead to performance impact (see radar).
1202
1203         This patch adds an observer for the occlusion notification. I tried to stick
1204         with the same names used by WebKit2.
1205
1206         * WebView/WebView.mm:
1207         (-[WebView _isViewVisible]):
1208         (-[WebView addWindowObserversForWindow:]):
1209         (-[WebView removeWindowObservers]):
1210         (-[WebView _windowDidChangeOcclusionState:]):
1211
1212 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1213
1214         Allow clients to set the navigator platform
1215         https://bugs.webkit.org/show_bug.cgi?id=192735
1216
1217         Reviewed by Tim Horton.
1218
1219         Add stubs to fill out the added functionality in FrameLoaderClient.
1220
1221         * WebCoreSupport/WebFrameLoaderClient.h:
1222         * WebCoreSupport/WebFrameLoaderClient.mm:
1223         (WebFrameLoaderClient::navigatorPlatform):
1224
1225 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         offsetLeft and offsetParent should adjust across shadow boundaries
1228         https://bugs.webkit.org/show_bug.cgi?id=157437
1229         <rdar://problem/26154021>
1230
1231         Reviewed by Simon Fraser.
1232
1233         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1234
1235         * DOM/DOMElement.mm:
1236         (-[DOMElement offsetLeft]):
1237         (-[DOMElement offsetTop]):
1238         (-[DOMElement offsetParent]):
1239
1240 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1241
1242         Unreviewed build fix.
1243
1244         * WebView/WebFrame.mm:
1245         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1246
1247 2018-12-15  Darin Adler  <darin@apple.com>
1248
1249         Use warning-ignoring macros more consistently and simply
1250         https://bugs.webkit.org/show_bug.cgi?id=192743
1251
1252         Reviewed by Mark Lam.
1253
1254         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1255         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1256         compilers in Objective-C++ code.
1257
1258         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1259         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1260         accomodate non-clang compilers here. Also use #pragma once, add a missing
1261         "explicit" and fix conditionals.
1262
1263 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1266         https://bugs.webkit.org/show_bug.cgi?id=192653
1267
1268         Reviewed by Wenson Hsieh.
1269
1270         * WebView/WebHTMLView.mm:
1271         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1272
1273 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1274
1275         Implement feature flag for CSS Typed OM
1276         https://bugs.webkit.org/show_bug.cgi?id=192610
1277
1278         Reviewed by Ryosuke Niwa.
1279
1280         * Configurations/FeatureDefines.xcconfig:
1281
1282 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1283
1284         WebCore shouldn't have a Objective-C class named NSCursor
1285         https://bugs.webkit.org/show_bug.cgi?id=192602
1286         <rdar://problem/46615532>
1287
1288         Reviewed by Wenson Hsieh.
1289
1290         * WebView/WebFrameView.mm:
1291         (-[WebFrameView keyDown:keyDown:]):
1292         * WebView/WebHTMLView.mm:
1293         (-[WebHTMLView keyDown:]):
1294         (-[WebHTMLView performKeyEquivalent:]):
1295         Only use NSCursor on macOS.
1296
1297 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1298
1299         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1300         https://bugs.webkit.org/show_bug.cgi?id=192573
1301
1302         Reviewed by Simon Fraser.
1303
1304         * Configurations/FeatureDefines.xcconfig:
1305
1306 2018-12-10  Antti Koivisto  <antti@apple.com>
1307
1308         Rename "forced style recalc" to "full style rebuild"
1309         https://bugs.webkit.org/show_bug.cgi?id=192572
1310
1311         Reviewed by Zalan Bujtas.
1312
1313         * WebView/WebHTMLView.mm:
1314         (-[WebHTMLView setNeedsToApplyStyles:]):
1315
1316 2018-12-10  Darin Adler  <darin@apple.com>
1317
1318         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1319         https://bugs.webkit.org/show_bug.cgi?id=192533
1320         rdar://problem/45732710
1321
1322         Reviewed by Anders Carlsson.
1323
1324         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1325         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1326
1327 2018-12-10  Darin Adler  <darin@apple.com>
1328
1329         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1330         https://bugs.webkit.org/show_bug.cgi?id=192532
1331         rdar://problem/45731047
1332
1333         Reviewed by Chris Dumez.
1334
1335         * Plugins/Hosted/NetscapePluginHostManager.mm:
1336         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1337         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1338         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1339
1340 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1341
1342         Turn WritingDirection into an enum class
1343         https://bugs.webkit.org/show_bug.cgi?id=192401
1344         Work towards <rdar://problem/42075638>
1345
1346         Reviewed by Dan Bernstein.
1347
1348         Change WritingDirection from an enum to an enum class. No change in behavior.
1349
1350         * WebView/WebHTMLView.mm:
1351         (-[WebHTMLView toggleBaseWritingDirection:]):
1352         (-[WebHTMLView changeBaseWritingDirection:]):
1353         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1354
1355 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1356
1357         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1358         https://bugs.webkit.org/show_bug.cgi?id=192272
1359
1360         Reviewed by Brady Eidson.
1361
1362         * WebCoreSupport/WebFrameLoaderClient.h:
1363         * WebCoreSupport/WebFrameLoaderClient.mm:
1364         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1365
1366 2018-12-03  Jer Noble  <jer.noble@apple.com>
1367
1368         Get rid of old, dead Mac video fullscreen code.
1369         https://bugs.webkit.org/show_bug.cgi?id=192315
1370
1371         Reviewed by Eric Carlson.
1372
1373         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1374         is no longer supported in the Mac port.
1375
1376         * WebView/WebVideoFullscreenController.h: Removed.
1377         * WebView/WebVideoFullscreenController.mm: Removed.
1378         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1379         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1380         * WebView/WebView.mm:
1381         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1382         (-[WebView _exitVideoFullscreen]):
1383
1384 2018-12-03  Daniel Bates  <dabates@apple.com>
1385
1386         [iOS] Do not handle key events that are key commands
1387         https://bugs.webkit.org/show_bug.cgi?id=191608
1388         <rdar://problem/46046013>
1389
1390         Reviewed by Ryosuke Niwa.
1391
1392         A key down event may be associated with a key command. If it is then we want to execute the
1393         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1394         event as a key command to find out.
1395
1396         * WebView/WebHTMLView.mm:
1397         (-[WebHTMLView _handleEditingKeyEvent:]):
1398
1399 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1400
1401         Add a runtime feature flag for LayoutFormattingContext.
1402         https://bugs.webkit.org/show_bug.cgi?id=192280
1403
1404         Reviewed by Simon Fraser.
1405
1406         * Configurations/FeatureDefines.xcconfig:
1407
1408 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1409
1410         Move URL from WebCore to WTF
1411         https://bugs.webkit.org/show_bug.cgi?id=190234
1412
1413         Reviewed by Keith Miller.
1414
1415         * DOM/DOMAttr.mm:
1416         * DOM/DOMBlob.mm:
1417         * DOM/DOMCSSCharsetRule.mm:
1418         * DOM/DOMCSSImportRule.mm:
1419         * DOM/DOMCSSMediaRule.mm:
1420         * DOM/DOMCSSPageRule.mm:
1421         * DOM/DOMCSSPrimitiveValue.mm:
1422         * DOM/DOMCSSRule.mm:
1423         * DOM/DOMCSSStyleDeclaration.mm:
1424         * DOM/DOMCSSStyleRule.mm:
1425         * DOM/DOMCSSStyleSheet.mm:
1426         * DOM/DOMCSSValue.mm:
1427         * DOM/DOMCharacterData.mm:
1428         * DOM/DOMCounter.mm:
1429         * DOM/DOMDocument.mm:
1430         * DOM/DOMDocumentFragment.mm:
1431         * DOM/DOMDocumentType.mm:
1432         * DOM/DOMEvent.mm:
1433         * DOM/DOMFile.mm:
1434         * DOM/DOMHTMLAnchorElement.mm:
1435         * DOM/DOMHTMLAppletElement.mm:
1436         * DOM/DOMHTMLAreaElement.mm:
1437         * DOM/DOMHTMLBRElement.mm:
1438         * DOM/DOMHTMLBaseElement.mm:
1439         * DOM/DOMHTMLBaseFontElement.mm:
1440         * DOM/DOMHTMLBodyElement.mm:
1441         * DOM/DOMHTMLButtonElement.mm:
1442         * DOM/DOMHTMLCanvasElement.mm:
1443         * DOM/DOMHTMLCollection.mm:
1444         * DOM/DOMHTMLDivElement.mm:
1445         * DOM/DOMHTMLDocument.mm:
1446         * DOM/DOMHTMLElement.mm:
1447         * DOM/DOMHTMLEmbedElement.mm:
1448         * DOM/DOMHTMLFieldSetElement.mm:
1449         * DOM/DOMHTMLFontElement.mm:
1450         * DOM/DOMHTMLFormElement.mm:
1451         * DOM/DOMHTMLFrameElement.mm:
1452         * DOM/DOMHTMLFrameSetElement.mm:
1453         * DOM/DOMHTMLHRElement.mm:
1454         * DOM/DOMHTMLHeadElement.mm:
1455         * DOM/DOMHTMLHeadingElement.mm:
1456         * DOM/DOMHTMLHtmlElement.mm:
1457         * DOM/DOMHTMLIFrameElement.mm:
1458         * DOM/DOMHTMLImageElement.mm:
1459         * DOM/DOMHTMLInputElement.mm:
1460         * DOM/DOMHTMLLIElement.mm:
1461         * DOM/DOMHTMLLabelElement.mm:
1462         * DOM/DOMHTMLLegendElement.mm:
1463         * DOM/DOMHTMLLinkElement.mm:
1464         * DOM/DOMHTMLMapElement.mm:
1465         * DOM/DOMHTMLMarqueeElement.mm:
1466         * DOM/DOMHTMLMediaElement.mm:
1467         * DOM/DOMHTMLMetaElement.mm:
1468         * DOM/DOMHTMLModElement.mm:
1469         * DOM/DOMHTMLOListElement.mm:
1470         * DOM/DOMHTMLObjectElement.mm:
1471         * DOM/DOMHTMLOptGroupElement.mm:
1472         * DOM/DOMHTMLOptionElement.mm:
1473         * DOM/DOMHTMLOptionsCollection.mm:
1474         * DOM/DOMHTMLParagraphElement.mm:
1475         * DOM/DOMHTMLParamElement.mm:
1476         * DOM/DOMHTMLQuoteElement.mm:
1477         * DOM/DOMHTMLScriptElement.mm:
1478         * DOM/DOMHTMLSelectElement.mm:
1479         * DOM/DOMHTMLStyleElement.mm:
1480         * DOM/DOMHTMLTableCaptionElement.mm:
1481         * DOM/DOMHTMLTableCellElement.mm:
1482         * DOM/DOMHTMLTableColElement.mm:
1483         * DOM/DOMHTMLTableElement.mm:
1484         * DOM/DOMHTMLTableRowElement.mm:
1485         * DOM/DOMHTMLTableSectionElement.mm:
1486         * DOM/DOMHTMLTitleElement.mm:
1487         * DOM/DOMHTMLUListElement.mm:
1488         * DOM/DOMHTMLVideoElement.mm:
1489         * DOM/DOMKeyboardEvent.mm:
1490         * DOM/DOMMediaList.mm:
1491         * DOM/DOMMouseEvent.mm:
1492         * DOM/DOMMutationEvent.mm:
1493         * DOM/DOMNamedNodeMap.mm:
1494         * DOM/DOMProcessingInstruction.mm:
1495         * DOM/DOMRange.mm:
1496         * DOM/DOMStyleSheet.mm:
1497         * DOM/DOMText.mm:
1498         * DOM/DOMTextEvent.mm:
1499         * DOM/DOMTokenList.mm:
1500         * DOM/DOMUIEvent.mm:
1501         * DOM/DOMXPathResult.mm:
1502         * History/WebHistoryItem.mm:
1503         * Misc/WebNSURLExtras.mm:
1504         (-[NSURL _web_userVisibleString]):
1505         (-[NSURL _web_URLByRemovingUserInfo]):
1506         (-[NSURL _web_dataForURLComponentType:]):
1507         (-[NSURL _web_schemeData]):
1508         (-[NSURL _web_hostData]):
1509         * Misc/WebUserContentURLPattern.mm:
1510         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1511         * Plugins/WebNetscapePluginStream.h:
1512         (WebNetscapePluginStream::setRequestURL):
1513         * WebCoreSupport/WebChromeClient.h:
1514         * WebCoreSupport/WebChromeClient.mm:
1515         (WebChromeClient::signedPublicKeyAndChallengeString const):
1516         * WebCoreSupport/WebContextMenuClient.h:
1517         * WebCoreSupport/WebContextMenuClient.mm:
1518         * WebCoreSupport/WebDragClient.h:
1519         * WebCoreSupport/WebFrameLoaderClient.h:
1520         * WebCoreSupport/WebFrameLoaderClient.mm:
1521         (WebFrameLoaderClient::updateGlobalHistory):
1522         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1523         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1524         (WebPaymentCoordinatorClient::showPaymentUI):
1525         * WebCoreSupport/WebPlatformStrategies.h:
1526         * WebCoreSupport/WebPlatformStrategies.mm:
1527         (WebPlatformStrategies::readURLFromPasteboard):
1528         * WebCoreSupport/WebPluginInfoProvider.h:
1529         * WebCoreSupport/WebPluginInfoProvider.mm:
1530         (WebPluginInfoProvider::webVisiblePluginInfo):
1531         * WebCoreSupport/WebSecurityOrigin.mm:
1532         * WebCoreSupport/WebVisitedLinkStore.h:
1533         * WebView/WebDataSource.mm:
1534         * WebView/WebFrame.mm:
1535         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1536         * WebView/WebImmediateActionController.mm:
1537         (-[WebImmediateActionController _defaultAnimationController]):
1538         * WebView/WebPDFView.mm:
1539         * WebView/WebScriptDebugger.mm:
1540         * WebView/WebViewInternal.h:
1541
1542 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1543
1544         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1545         https://bugs.webkit.org/show_bug.cgi?id=192197
1546
1547         Reviewed by Jiewen Tan.
1548
1549         * Configurations/FeatureDefines.xcconfig:
1550         * WebCoreSupport/WebChromeClient.h:
1551         * WebCoreSupport/WebChromeClient.mm:
1552
1553 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1554
1555         Remove dead code from an earlier attempt at implementing safe browsing
1556         https://bugs.webkit.org/show_bug.cgi?id=192067
1557
1558         Reviewed by Chris Dumez.
1559
1560         * WebCoreSupport/WebFrameLoaderClient.h:
1561         * WebCoreSupport/WebFrameLoaderClient.mm:
1562         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1563
1564 2018-11-27  Mark Lam  <mark.lam@apple.com>
1565
1566         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1567         https://bugs.webkit.org/show_bug.cgi?id=192055
1568         <rdar://problem/46288783>
1569
1570         Reviewed by Saam Barati.
1571
1572         * Configurations/FeatureDefines.xcconfig:
1573
1574 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1575
1576         Make it possible to insert editable images with a gesture
1577         https://bugs.webkit.org/show_bug.cgi?id=191937
1578
1579         Reviewed by Wenson Hsieh.
1580
1581         * WebCoreSupport/WebEditorClient.mm:
1582         (undoNameForEditAction):
1583         Add a undo name.
1584
1585 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1586
1587         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1588         https://bugs.webkit.org/show_bug.cgi?id=191945
1589
1590         Reviewed by Anders Carlsson.
1591
1592         * WebCoreSupport/WebEditorClient.mm:
1593         (undoNameForEditAction):
1594
1595 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1596
1597         Enable drag and drop support for iOSMac
1598         https://bugs.webkit.org/show_bug.cgi?id=191818
1599         <rdar://problem/43907454>
1600
1601         Reviewed by Dean Jackson.
1602
1603         * Configurations/FeatureDefines.xcconfig:
1604
1605 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1606
1607         Address post-review feedback after r238438
1608         https://bugs.webkit.org/show_bug.cgi?id=191913
1609
1610         Reviewed by Ryosuke Niwa.
1611
1612         * WebView/WebFrame.mm:
1613         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1614         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1615         * WebView/WebView.mm:
1616         (-[WebView setSelectedDOMRange:affinity:]):
1617
1618 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1619
1620         Web Inspector: "Reload Web Inspector" button no longer partially works
1621         https://bugs.webkit.org/show_bug.cgi?id=191773
1622         <rdar://problem/46139932>
1623
1624         Reviewed by Devin Rousso.
1625
1626         * WebCoreSupport/WebInspectorClient.h:
1627         * WebCoreSupport/WebInspectorClient.mm:
1628         (WebInspectorFrontendClient::reopen):
1629
1630 2018-11-17  Devin Rousso  <drousso@apple.com>
1631
1632         Web Inspector: Network: add button to show system certificate dialog
1633         https://bugs.webkit.org/show_bug.cgi?id=191458
1634         <rdar://problem/45977019>
1635
1636         Reviewed by Joseph Pecoraro.
1637
1638         * WebCoreSupport/WebInspectorClient.h:
1639         * WebCoreSupport/WebInspectorClient.mm:
1640         (WebInspectorFrontendClient::showCertificate): Added.
1641
1642         * Configurations/WebKitLegacy.xcconfig:
1643
1644 2018-11-15  Truitt Savell  <tsavell@apple.com>
1645
1646         Unreviewed, rolling out r238244.
1647
1648         Caused High Sierra test runs to fail early with 50 crashes and
1649         casued 25 API failures.
1650
1651         Reverted changeset:
1652
1653         "[css-logical] Implement flow-relative margin, padding and
1654         border shorthands"
1655         https://bugs.webkit.org/show_bug.cgi?id=188697
1656         https://trac.webkit.org/changeset/238244
1657
1658 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1659
1660         [css-logical] Implement flow-relative margin, padding and border shorthands
1661         https://bugs.webkit.org/show_bug.cgi?id=188697
1662
1663         Reviewed by Simon Fraser and Antti Koivisto.
1664
1665         Add CSSLogicalEnabled runtime flag.
1666
1667         * WebView/WebPreferenceKeysPrivate.h:
1668         * WebView/WebPreferences.mm:
1669         (+[WebPreferences initialize]):
1670         (-[WebPreferences cssLogicalEnabled]):
1671         (-[WebPreferences setCSSLogicalEnabled:]):
1672         * WebView/WebPreferencesPrivate.h:
1673         * WebView/WebView.mm:
1674         (-[WebView _preferencesChanged:]):
1675
1676 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1677
1678         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1679         https://bugs.webkit.org/show_bug.cgi?id=191612
1680
1681         Reviewed by Matt Baker.
1682
1683         * WebCoreSupport/WebInspectorClient.mm:
1684         (-[WebInspectorWindowController destroyInspectorView]):
1685
1686 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1687
1688         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1689         https://bugs.webkit.org/show_bug.cgi?id=191494
1690         <rdar://problem/45469854>
1691
1692         Reviewed by Devin Rousso.
1693
1694         * WebCoreSupport/WebInspectorClient.h:
1695         WebKitLegacy will still have remote inspection of the Page directly.
1696
1697 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1698
1699         Make compositing updates incremental
1700         https://bugs.webkit.org/show_bug.cgi?id=90342
1701
1702         Reviewed by Antti Koivisto.
1703
1704         Fix spelling error.
1705
1706         * WebView/WebView.mm:
1707         (-[WebView _setMediaLayer:forPluginView:]):
1708
1709 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1710
1711         Implement a new edit command to change the enclosing list type
1712         https://bugs.webkit.org/show_bug.cgi?id=191487
1713         <rdar://problem/45955922>
1714
1715         Reviewed by Ryosuke Niwa.
1716
1717         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1718
1719         * WebCoreSupport/WebEditorClient.mm:
1720         (undoNameForEditAction):
1721
1722 2018-11-11  Daniel Bates  <dabates@apple.com>
1723
1724         [iOS] Draw caps lock indicator in password fields
1725         https://bugs.webkit.org/show_bug.cgi?id=190565
1726         <rdar://problem/45262343>
1727
1728         Reviewed by Dean Jackson.
1729
1730         Update the caps lock state when a hardware keyboard is attached or detached.
1731
1732         * WebView/WebHTMLView.mm:
1733         (hardwareKeyboardAvailabilityChangedCallback): Added.
1734         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1735         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1736
1737 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1738
1739         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1740         https://bugs.webkit.org/show_bug.cgi?id=191492
1741
1742         Reviewed by Alex Christensen.
1743
1744         * Carbon/HIWebView.mm:
1745         * Misc/WebNSFileManagerExtras.mm:
1746         * Misc/WebNSURLExtras.mm:
1747         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1748         * Plugins/WebBasePluginPackage.mm:
1749         * Plugins/WebPluginContainerCheck.mm:
1750         * WebCoreSupport/WebCachedFramePlatformData.h:
1751         * WebCoreSupport/WebDeviceOrientationClient.mm:
1752         * WebView/WebDelegateImplementationCaching.mm:
1753         * WebView/WebHTMLView.mm:
1754         * WebView/WebPDFRepresentation.mm:
1755         * WebView/WebPolicyDelegate.mm:
1756         * WebView/WebView.mm:
1757
1758 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1759
1760         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1761         https://bugs.webkit.org/show_bug.cgi?id=191492
1762
1763         Reviewed by Alex Christensen.
1764
1765         * Carbon/HIWebView.mm:
1766         (UpdateCommandStatus):
1767         * Misc/WebNSFileManagerExtras.mm:
1768         * Misc/WebNSURLExtras.mm:
1769         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1770         * Plugins/WebBasePluginPackage.mm:
1771         * Plugins/WebPluginContainerCheck.mm:
1772         (-[WebPluginContainerCheck _continueWithPolicy:]):
1773         * WebCoreSupport/WebCachedFramePlatformData.h:
1774         (WebCachedFramePlatformData::clear):
1775         * WebCoreSupport/WebDeviceOrientationClient.mm:
1776         (WebDeviceOrientationClient::getProvider const):
1777         * WebView/WebDelegateImplementationCaching.mm:
1778         (CallDelegate):
1779         (CallDelegateReturningBoolean):
1780         (CallResourceLoadDelegateReturningBoolean):
1781         (CallFormDelegate):
1782         (CallFormDelegateReturningBoolean):
1783         * WebView/WebHTMLView.mm:
1784         * WebView/WebPDFRepresentation.mm:
1785         * WebView/WebPolicyDelegate.mm:
1786         (-[WebPolicyDecisionListener _usePolicy:]):
1787         * WebView/WebView.mm:
1788
1789 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1790
1791         Unreviewed, rolling out r238047.
1792
1793         Introduced layout test failures on iOS simulator.
1794
1795         Reverted changeset:
1796
1797         "[iOS] Draw caps lock indicator in password fields"
1798         https://bugs.webkit.org/show_bug.cgi?id=190565
1799         https://trac.webkit.org/changeset/238047
1800
1801 2018-11-09  Antti Koivisto  <antti@apple.com>
1802
1803         Use OptionSet for layout milestones
1804         https://bugs.webkit.org/show_bug.cgi?id=191470
1805
1806         Reviewed by Dean Jackson.
1807
1808         * WebCoreSupport/WebFrameLoaderClient.h:
1809         * WebCoreSupport/WebFrameLoaderClient.mm:
1810         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1811         * WebView/WebView.mm:
1812         (coreLayoutMilestones):
1813         (kitLayoutMilestones):
1814         (-[WebView _cacheFrameLoadDelegateImplementations]):
1815         * WebView/WebViewInternal.h:
1816
1817 2018-11-09  Daniel Bates  <dabates@apple.com>
1818
1819         [iOS] Draw caps lock indicator in password fields
1820         https://bugs.webkit.org/show_bug.cgi?id=190565
1821         <rdar://problem/45262343>
1822
1823         Reviewed by Dean Jackson.
1824
1825         Update the caps lock state when a hardware keyboard is attached or detached.
1826
1827         * WebView/WebHTMLView.mm:
1828         (hardwareKeyboardAvailabilityChangedCallback): Added.
1829         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1830         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1831
1832 2018-11-09  Daniel Bates  <dabates@apple.com>
1833
1834         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1835         action when forward delete is pressed outside a text field
1836         https://bugs.webkit.org/show_bug.cgi?id=190566
1837         <rdar://problem/45262367>
1838
1839         Reviewed by Wenson Hsieh.
1840
1841         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1842         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1843         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1844
1845         * WebView/WebHTMLView.mm:
1846         (-[WebHTMLView _handleEditingKeyEvent:]):
1847
1848 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1849
1850         Adopt Reveal Framework to replace Lookup
1851         https://bugs.webkit.org/show_bug.cgi?id=191097
1852         <rdar://problem/45924508>
1853
1854         Reviewed by Tim Horton.
1855
1856         Pass in what it needed to clear the textIndicators. This is better than
1857         the current notification structure.
1858
1859         * WebView/WebView.mm:
1860         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1861         (-[WebView _prepareForDictionaryLookup]):
1862
1863 2018-11-06  Justin Fan  <justin_fan@apple.com>
1864
1865         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1866         https://bugs.webkit.org/show_bug.cgi?id=191291
1867
1868         Reviewed by Myles Maxfield.
1869
1870         Properly disable WEBGPU on all non-Metal platforms for now.
1871
1872         * Configurations/FeatureDefines.xcconfig:
1873
1874 2018-11-02  Daniel Bates  <dabates@apple.com>
1875
1876         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1877         https://bugs.webkit.org/show_bug.cgi?id=190487
1878
1879         Reviewed by Tim Horton.
1880
1881         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1882         allow the default handling.
1883
1884         * WebView/WebHTMLView.mm:
1885         (-[WebHTMLView _handleEditingKeyEvent:]):
1886
1887 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1888
1889         Add a storage limit for IndexedDB
1890         https://bugs.webkit.org/show_bug.cgi?id=190598
1891         <rdar://problem/44654715>
1892
1893         Reviewed by Chris Dumez.
1894
1895         * Storage/WebDatabaseManager.mm:
1896         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1897         * Storage/WebDatabaseManagerPrivate.h:
1898
1899 2018-10-31  Antti Koivisto  <antti@apple.com>
1900
1901         Remove LayerFlushScheduler
1902         https://bugs.webkit.org/show_bug.cgi?id=191103
1903
1904         Reviewed by Anders Carlsson.
1905
1906         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1907         all the virtual cruft.
1908
1909         * WebView/WebViewData.h:
1910         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1911         (): Deleted.
1912         * WebView/WebViewData.mm:
1913         (currentRunLoop):
1914         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1915         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1916         (WebViewLayerFlushScheduler::schedule):
1917         (WebViewLayerFlushScheduler::invalidate):
1918         (WebViewLayerFlushScheduler::layerFlushCallback):
1919
1920 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1921
1922         Enable InstallAPI for iOS unconditionally
1923         https://bugs.webkit.org/show_bug.cgi?id=191043
1924         rdar://problem/32728423
1925
1926         Reviewed by Dan Bernstein.
1927
1928         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1929         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1930         shouldn't be processed by InstallAPI.
1931         * MigrateHeaders.make: Removed an obsolete workaround.
1932         * Misc/NSURLDownloadSPI.h: Added.
1933         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1934
1935 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1936
1937         Clean up some obsolete MAX_ALLOWED macros
1938         https://bugs.webkit.org/show_bug.cgi?id=190916
1939
1940         Reviewed by Tim Horton.
1941
1942         * WebView/WebHTMLView.mm:
1943         (-[WebHTMLView pressureChangeWithEvent:]):
1944         * WebView/WebPDFView.h:
1945
1946 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1947
1948         Unreviewed, rolling out r237600 and r237604.
1949         https://bugs.webkit.org/show_bug.cgi?id=191086
1950
1951         Breaks internal iOS builds (Requested by ryanhadd_ on
1952         #webkit).
1953
1954         Reverted changesets:
1955
1956         "Enable InstallAPI for iOS unconditionally"
1957         https://bugs.webkit.org/show_bug.cgi?id=191043
1958         https://trac.webkit.org/changeset/237600
1959
1960         "Build fix attempt after enabling InstallAPI for iOS."
1961         https://bugs.webkit.org/show_bug.cgi?id=191043
1962         https://trac.webkit.org/changeset/237604
1963
1964 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1965
1966         Enable InstallAPI for iOS unconditionally
1967         https://bugs.webkit.org/show_bug.cgi?id=191043
1968         rdar://problem/32728423
1969
1970         Reviewed by Dan Bernstein.
1971
1972         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1973         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1974         shouldn't be processed by InstallAPI.
1975         * MigrateHeaders.make: Removed an obsolete workaround.
1976         * Misc/NSURLDownloadSPI.h: Added.
1977         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1978
1979 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1980
1981         Modernize WebKit nibs and lprojs for localization's sake
1982         https://bugs.webkit.org/show_bug.cgi?id=190911
1983         <rdar://problem/45349466>
1984
1985         Reviewed by Dan Bernstein.
1986
1987         * Misc/WebNSControlExtras.m:
1988         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1989         NSWindow and its contents are both in the same scale space these days; avoid
1990         double-applying the scale factor, or you can't see the prompt.
1991
1992         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1993         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1994         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1995         NIB->XIB
1996
1997 2018-10-25  Antoine Quint  <graouts@apple.com>
1998
1999         [Web Animations] Turn Web Animations CSS Integration off by default
2000         https://bugs.webkit.org/show_bug.cgi?id=190901
2001
2002         Reviewed by Dean Jackson.
2003
2004         * WebView/WebPreferences.mm:
2005         (+[WebPreferences initialize]):
2006
2007 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2008
2009         Clean up some obsolete macOS version guards
2010         https://bugs.webkit.org/show_bug.cgi?id=190887
2011
2012         Reviewed by Dan Bernstein.
2013
2014         * Misc/WebNSPasteboardExtras.mm:
2015         (+[NSPasteboard _web_dragTypesForURL]):
2016         * WebCoreSupport/PopupMenuMac.mm:
2017         (PopupMenuMac::show):
2018         * WebCoreSupport/WebEditorClient.h:
2019         * WebCoreSupport/WebEditorClient.mm:
2020         (WebEditorClient::respondToChangedSelection):
2021         * WebView/WebPDFView.mm:
2022         (-[WebPDFView _clipViewForPDFDocumentView]):
2023
2024 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2025
2026         Turn on Conic Gradients
2027         https://bugs.webkit.org/show_bug.cgi?id=190810
2028
2029         Reviewed by Tim Horton.
2030
2031         * Configurations/FeatureDefines.xcconfig:
2032
2033 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2034
2035         Cleanup: MIMETypeRegistry functions
2036         https://bugs.webkit.org/show_bug.cgi?id=190838
2037
2038         Reviewed by Simon Fraser.
2039
2040         * Misc/WebNSPasteboardExtras.mm:
2041         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2042         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2043         because they were identical.
2044
2045         * WebView/WebHTMLRepresentation.mm:
2046         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2047         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2048         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2049         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2050         * WebView/WebView.mm:
2051         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2052         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2053         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2054
2055 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2056
2057         Fix false positive leaks when using custom -init methods that don't start with -init
2058         <https://webkit.org/b/190818>
2059         <rdar://problem/45476042>
2060
2061         Reviewed by Dan Bernstein.
2062
2063         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2064         it is accessible by both categories.
2065         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2066         NSError (WebKitInternal) category.  Add attribute to make this
2067         behave like an -init method.
2068         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2069         NSError (WebKitInternal) category.  Modernize method.  Replace
2070         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2071
2072 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2073
2074         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2075         https://bugs.webkit.org/show_bug.cgi?id=190729
2076
2077         Reviewed by Tim Horton.
2078
2079         * DOM/DOM.mm:
2080         (-[DOMNode boundingBox]):
2081         * DOM/DOMElement.mm:
2082         * DOM/DOMHTML.mm:
2083         * DOM/DOMInternal.mm:
2084         * DOM/DOMUIKitExtensions.mm:
2085         * DOM/WebDOMOperations.mm:
2086         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2087         * DefaultDelegates/WebDefaultEditingDelegate.m:
2088         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2089         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2090         * DefaultDelegates/WebDefaultUIDelegate.h:
2091         * DefaultDelegates/WebDefaultUIDelegate.mm:
2092         (-[WebDefaultUIDelegate webViewClose:]):
2093         (-[WebDefaultUIDelegate webViewFocus:]):
2094         (-[WebDefaultUIDelegate webViewUnfocus:]):
2095         (-[WebDefaultUIDelegate webViewIsResizable:]):
2096         (-[WebDefaultUIDelegate webView:setResizable:]):
2097         (-[WebDefaultUIDelegate webView:setFrame:]):
2098         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2099         * History/BackForwardList.h:
2100         * History/BackForwardList.mm:
2101         * History/WebBackForwardList.mm:
2102         (+[WebBackForwardList initialize]):
2103         (bumperCarBackForwardHackNeeded):
2104         * History/WebHistory.mm:
2105         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2106         (-[WebHistory _sendNotification:entries:]):
2107         (-[WebHistory loadFromURL:error:]):
2108         (-[WebHistory saveToURL:error:]):
2109         * History/WebHistoryItem.mm:
2110         (WKNotifyHistoryItemChanged):
2111         (+[WebHistoryItem initialize]):
2112         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2113         * History/WebURLsWithTitles.m:
2114         * Misc/WebCache.mm:
2115         (+[WebCache initialize]):
2116         * Misc/WebDownload.mm:
2117         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2118         * Misc/WebElementDictionary.mm:
2119         (+[WebElementDictionary initialize]):
2120         (+[WebElementDictionary initializeLookupTable]):
2121         * Misc/WebIconDatabase.mm:
2122         * Misc/WebKitNSStringExtras.mm:
2123         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2124         * Misc/WebKitVersionChecks.h:
2125         * Misc/WebKitVersionChecks.mm:
2126         (WebKitLinkedOnOrAfter):
2127         (WebKitLinkTimeVersion):
2128         * Misc/WebLocalizableStrings.mm:
2129         * Misc/WebNSControlExtras.h:
2130         * Misc/WebNSControlExtras.m:
2131         * Misc/WebNSEventExtras.m:
2132         * Misc/WebNSFileManagerExtras.mm:
2133         * Misc/WebNSImageExtras.h:
2134         * Misc/WebNSImageExtras.m:
2135         * Misc/WebNSPasteboardExtras.mm:
2136         * Misc/WebNSPrintOperationExtras.h:
2137         * Misc/WebNSPrintOperationExtras.m:
2138         * Misc/WebNSViewExtras.m:
2139         * Misc/WebNSWindowExtras.m:
2140         * Panels/WebAuthenticationPanel.h:
2141         * Panels/WebAuthenticationPanel.m:
2142         * Panels/WebPanelAuthenticationHandler.m:
2143         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2144         (+[WebHostedNetscapePluginView initialize]):
2145         * Plugins/WebBasePluginPackage.h:
2146         * Plugins/WebBasePluginPackage.mm:
2147         * Plugins/WebJavaPlugIn.h:
2148         * Plugins/WebPluginContainerCheck.mm:
2149         * Plugins/WebPluginController.h:
2150         * Plugins/WebPluginController.mm:
2151         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2152         (-[WebPluginController addPlugin:]):
2153         (-[WebPluginController destroyPlugin:]):
2154         (-[WebPluginController destroyAllPlugins]):
2155         * Plugins/WebPluginDatabase.mm:
2156         (+[WebPluginDatabase _defaultPlugInPaths]):
2157         * Plugins/WebPluginPackage.mm:
2158         (-[WebPluginPackage initWithPath:]):
2159         * Storage/WebDatabaseManager.mm:
2160         (-[WebDatabaseManager deleteAllDatabases]):
2161         * Storage/WebDatabaseManagerClient.h:
2162         * Storage/WebDatabaseManagerClient.mm:
2163         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2164         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2165         * Storage/WebStorageManager.mm:
2166         (-[WebStorageManager deleteAllOrigins]):
2167         (WebKitInitializeStorageIfNecessary):
2168         * WebCoreSupport/WebAlternativeTextClient.h:
2169         * WebCoreSupport/WebApplicationCache.mm:
2170         (applicationCacheBundleIdentifier):
2171         * WebCoreSupport/WebChromeClient.h:
2172         * WebCoreSupport/WebChromeClient.mm:
2173         (WebChromeClient::setWindowRect):
2174         (WebChromeClient::windowRect):
2175         (WebChromeClient::takeFocus):
2176         (WebChromeClient::addMessageToConsole):
2177         (WebChromeClient::enableSuddenTermination):
2178         (WebChromeClient::disableSuddenTermination):
2179         (WebChromeClient::createPopupMenu const):
2180         (WebChromeClient::createSearchPopupMenu const):
2181         (WebChromeClient::shouldPaintEntireContents const):
2182         (WebChromeClient::supportsVideoFullscreen):
2183         (WebChromeClient::supportsFullScreenForElement):
2184         (WebChromeClient::enterFullScreenForElement):
2185         (WebChromeClient::exitFullScreenForElement):
2186         * WebCoreSupport/WebContextMenuClient.mm:
2187         * WebCoreSupport/WebDragClient.mm:
2188         * WebCoreSupport/WebEditorClient.h:
2189         * WebCoreSupport/WebEditorClient.mm:
2190         (+[WebUndoStep initialize]):
2191         (updateFontPanel):
2192         (WebEditorClient::didBeginEditing):
2193         (WebEditorClient::respondToChangedContents):
2194         (WebEditorClient::respondToChangedSelection):
2195         (WebEditorClient::canceledComposition):
2196         (WebEditorClient::didEndEditing):
2197         (WebEditorClient::didWriteSelectionToPasteboard):
2198         (attributesForAttributedStringConversion):
2199         (WebEditorClient::setInsertionPasteboard):
2200         (WebEditorClient::registerUndoOrRedoStep):
2201         (WebEditorClient::handleKeyboardEvent):
2202         (WebEditorClient::handleInputMethodKeydown):
2203         (WebEditorClient::textDidChangeInTextField):
2204         (WebEditorClient::requestCheckingOfString):
2205         * WebCoreSupport/WebFrameLoaderClient.h:
2206         * WebCoreSupport/WebFrameLoaderClient.mm:
2207         (WebFrameLoaderClient::detachedFromParent2):
2208         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2209         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2210         (WebFrameLoaderClient::dispatchWillSendRequest):
2211         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2212         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2213         (WebFrameLoaderClient::willCacheResponse const):
2214         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2215         (WebFrameLoaderClient::dispatchDidFinishLoading):
2216         (WebFrameLoaderClient::dispatchDidFailLoading):
2217         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2218         (WebFrameLoaderClient::dispatchWillClose):
2219         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2220         (WebFrameLoaderClient::dispatchDidCommitLoad):
2221         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2222         (WebFrameLoaderClient::dispatchDidFailLoad):
2223         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2224         (WebFrameLoaderClient::dispatchDidFinishLoad):
2225         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2226         (WebFrameLoaderClient::willChangeTitle):
2227         (WebFrameLoaderClient::didChangeTitle):
2228         (WebFrameLoaderClient::didReplaceMultipartContent):
2229         (WebFrameLoaderClient::updateGlobalHistory):
2230         (WebFrameLoaderClient::saveViewStateToItem):
2231         (WebFrameLoaderClient::restoreViewState):
2232         (WebFrameLoaderClient::provisionalLoadStarted):
2233         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2234         (WebFrameLoaderClient::setTitle):
2235         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2236         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2237         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2238         (WebFrameLoaderClient::didRestoreFromPageCache):
2239         (WebFrameLoaderClient::actionDictionary const):
2240         (WebFrameLoaderClient::createPlugin):
2241         (WebFrameLoaderClient::getLoadDecisionForIcons):
2242         (WebFrameLoaderClient::finishedLoadingIcon):
2243         (+[WebFramePolicyListener initialize]):
2244         * WebCoreSupport/WebFrameNetworkingContext.mm:
2245         * WebCoreSupport/WebGeolocationClient.h:
2246         * WebCoreSupport/WebGeolocationClient.mm:
2247         (WebGeolocationClient::requestPermission):
2248         * WebCoreSupport/WebInspectorClient.h:
2249         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2250         * WebCoreSupport/WebNotificationClient.mm:
2251         * WebCoreSupport/WebOpenPanelResultListener.mm:
2252         * WebCoreSupport/WebPlatformStrategies.h:
2253         * WebCoreSupport/WebPlatformStrategies.mm:
2254         * WebCoreSupport/WebProgressTrackerClient.h:
2255         * WebCoreSupport/WebProgressTrackerClient.mm:
2256         (WebProgressTrackerClient::progressStarted):
2257         (WebProgressTrackerClient::progressEstimateChanged):
2258         (WebProgressTrackerClient::progressFinished):
2259         * WebCoreSupport/WebSecurityOrigin.mm:
2260         * WebInspector/WebNodeHighlight.h:
2261         * WebInspector/WebNodeHighlight.mm:
2262         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2263         (-[WebNodeHighlight dealloc]):
2264         (-[WebNodeHighlight attach]):
2265         * WebInspector/WebNodeHighlightView.h:
2266         * WebInspector/WebNodeHighlightView.mm:
2267         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2268         (-[WebNodeHighlightView dealloc]):
2269         * WebInspector/WebNodeHighlighter.mm:
2270         (-[WebNodeHighlighter highlight]):
2271         * WebView/WebArchive.mm:
2272         (+[WebArchivePrivate initialize]):
2273         * WebView/WebClipView.h:
2274         * WebView/WebDataSource.mm:
2275         (WebDataSourcePrivate::WebDataSourcePrivate):
2276         (+[WebDataSource initialize]):
2277         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2278         (-[WebDataSource _makeRepresentation]):
2279         * WebView/WebDelegateImplementationCaching.h:
2280         * WebView/WebDelegateImplementationCaching.mm:
2281         (CallDelegate):
2282         (CallDelegateReturningFloat):
2283         (CallDelegateReturningBoolean):
2284         (CallUIDelegate):
2285         (CallUIDelegateReturningFloat):
2286         (CallUIDelegateReturningBoolean):
2287         (CallFrameLoadDelegate):
2288         (CallFrameLoadDelegateReturningBoolean):
2289         (CallResourceLoadDelegate):
2290         (CallScriptDebugDelegate):
2291         (CallFormDelegate):
2292         (CallFormDelegateReturningBoolean):
2293         * WebView/WebDeviceOrientation.mm:
2294         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2295         * WebView/WebDocumentInternal.h:
2296         * WebView/WebDocumentLoaderMac.mm:
2297         (needsDataLoadWorkaround):
2298         * WebView/WebDynamicScrollBarsViewInternal.h:
2299         * WebView/WebFormDelegate.m:
2300         * WebView/WebFrame.mm:
2301         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2302         (-[WebFrame _unmarkAllMisspellings]):
2303         (-[WebFrame _paintBehaviorForDestinationContext:]):
2304         (-[WebFrame _drawRect:contentsOnly:]):
2305         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2306         (-[WebFrame _scrollDOMRangeToVisible:]):
2307         (-[WebFrame _bodyBackgroundColor]):
2308         (-[WebFrame accessibilityRoot]):
2309         (needsMicrosoftMessengerDOMDocumentWorkaround):
2310         * WebView/WebFrameInternal.h:
2311         * WebView/WebFrameView.mm:
2312         (-[WebFrameView _setDocumentView:]):
2313         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2314         (-[WebFrameView _viewClassForMIMEType:]):
2315         (-[WebFrameView initWithFrame:]):
2316         (-[WebFrameView drawRect:]):
2317         (-[WebFrameView _firstResponderIsFormControl]):
2318         (-[WebFrameView keyDown:keyDown:]):
2319         (-[WebFrameView _isScrollable]):
2320         * WebView/WebFullScreenController.h:
2321         * WebView/WebFullScreenController.mm:
2322         * WebView/WebHTMLRepresentation.mm:
2323         * WebView/WebHTMLView.mm:
2324         (-[WebHTMLView hitTest:]):
2325         (-[WebHTMLView initWithFrame:]):
2326         (-[WebHTMLView dealloc]):
2327         (-[WebHTMLView addSubview:]):
2328         (-[WebHTMLView mouseDown:]):
2329         (-[WebHTMLView mouseUp:]):
2330         (-[WebHTMLView resignFirstResponder]):
2331         (-[WebHTMLView accessibilityHitTest:]):
2332         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2333         * WebView/WebHTMLViewInternal.h:
2334         * WebView/WebIndicateLayer.h:
2335         * WebView/WebIndicateLayer.mm:
2336         * WebView/WebMediaPlaybackTargetPicker.h:
2337         * WebView/WebMediaPlaybackTargetPicker.mm:
2338         * WebView/WebPDFDocumentExtras.h:
2339         * WebView/WebPDFDocumentExtras.mm:
2340         * WebView/WebPDFRepresentation.h:
2341         * WebView/WebPDFRepresentation.mm:
2342         * WebView/WebPDFView.h:
2343         * WebView/WebPreferences.mm:
2344         (cacheModelForMainBundle):
2345         (WebPreferencesPrivate::WebPreferencesPrivate):
2346         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2347         (-[WebPreferences encodeWithCoder:]):
2348         (+[WebPreferences standardPreferences]):
2349         (+[WebPreferences initialize]):
2350         (-[WebPreferences _valueForKey:]):
2351         (-[WebPreferences _setStringValue:forKey:]):
2352         (-[WebPreferences _setIntegerValue:forKey:]):
2353         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2354         (-[WebPreferences _setFloatValue:forKey:]):
2355         (-[WebPreferences _setBoolValue:forKey:]):
2356         (-[WebPreferences _setLongLongValue:forKey:]):
2357         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2358         (-[WebPreferences _postCacheModelChangedNotification]):
2359         (-[WebPreferences _postPreferencesChangedNotification]):
2360         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2361         (-[WebPreferences setStorageBlockingPolicy:]):
2362         * WebView/WebResource.mm:
2363         (+[WebResourcePrivate initialize]):
2364         * WebView/WebTextCompletionController.h:
2365         * WebView/WebTextIterator.mm:
2366         (+[WebTextIteratorPrivate initialize]):
2367         * WebView/WebView.mm:
2368         (shouldEnableLoadDeferring):
2369         (shouldRestrictWindowFocus):
2370         (shouldRespectPriorityInCSSAttributeSetters):
2371         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2372         (shouldAllowPictureInPictureMediaPlayback):
2373         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2374         (shouldAllowWindowOpenWithoutUserGesture):
2375         (shouldConvertInvalidURLsToBlank):
2376         (shouldRequireUserGestureToLoadVideo):
2377         (-[WebView _commonInitializationWithFrameName:groupName:]):
2378         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2379         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2380         (-[WebView _closePluginDatabases]):
2381         (-[WebView _closeWithFastTeardown]):
2382         (-[WebView _close]):
2383         (+[WebView _MIMETypeForFile:]):
2384         (-[WebView setShowingInspectorIndication:]):
2385         (-[WebView _setFormDelegate:]):
2386         (-[WebView _needsPreHTML5ParserQuirks]):
2387         (-[WebView _preferencesChangedNotification:]):
2388         (-[WebView _preferencesChanged:]):
2389         (-[WebView _cacheResourceLoadDelegateImplementations]):
2390         (-[WebView _cacheFrameLoadDelegateImplementations]):
2391         (-[WebView _policyDelegateForwarder]):
2392         (-[WebView _UIDelegateForwarder]):
2393         (-[WebView _editingDelegateForwarder]):
2394         (-[WebView _updateActiveState]):
2395         (-[_WebSafeForwarder forwardInvocation:]):
2396         (+[WebView initialize]):
2397         (-[WebView _pluginForMIMEType:]):
2398         (-[WebView _pluginForExtension:]):
2399         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2400         (+[WebView canShowMIMETypeAsHTML:]):
2401         (-[WebView _initWithArguments:]):
2402         (-[WebView initWithFrame:frameName:groupName:]):
2403         (-[WebView dealloc]):
2404         (-[WebView close]):
2405         (-[WebView viewDidMoveToWindow]):
2406         (-[WebView setUIDelegate:]):
2407         (-[WebView setResourceLoadDelegate:]):
2408         (-[WebView setPolicyDelegate:]):
2409         (-[WebView setFrameLoadDelegate:]):
2410         (-[WebView goBack]):
2411         (-[WebView goForward]):
2412         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2413         (-[WebView setHostWindow:]):
2414         (-[WebView becomeFirstResponder]):
2415         (+[WebView _cacheModelChangedNotification:]):
2416         (-[WebView _frameViewAtWindowPoint:]):
2417         (+[WebView _preflightSpellCheckerNow:]):
2418         (+[WebView _preflightSpellChecker]):
2419         (-[WebView canGoBack]):
2420         (-[WebView canGoForward]):
2421         (-[WebView stopLoading:]):
2422         (-[WebView reload:]):
2423         (-[WebView setMainFrameDocumentReady:]):
2424         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2425         (-[WebView setContinuousSpellCheckingEnabled:]):
2426         (-[WebView undoManager]):
2427         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2428         (-[WebView isAutomaticLinkDetectionEnabled]):
2429         (-[WebView isAutomaticDashSubstitutionEnabled]):
2430         (-[WebView isAutomaticTextReplacementEnabled]):
2431         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2432         (+[WebView _setCacheModel:]):
2433         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2434         (-[WebView _keyboardUIMode]):
2435         (LayerFlushController::flushLayers):
2436         (-[WebView _scheduleCompositingLayerFlush]):
2437         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2438         (-[WebView fullScreenPlaceholderView]):
2439         (WebInstallMemoryPressureHandler):
2440         * WebView/WebViewData.h:
2441         * WebView/WebViewData.mm:
2442         (+[WebViewPrivate initialize]):
2443         (-[WebViewPrivate init]):
2444         (-[WebViewPrivate dealloc]):
2445         * WebView/WebViewInternal.h:
2446
2447 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2448
2449         Clean up FrameLoader two-state enums
2450         https://bugs.webkit.org/show_bug.cgi?id=190731
2451
2452         Reviewed by Chris Dumez.
2453
2454         * WebCoreSupport/WebFrameLoaderClient.h:
2455         * WebCoreSupport/WebFrameLoaderClient.mm:
2456         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2457
2458 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2459
2460         Unreviewed, rolling out r237137.
2461
2462         SPI is actually used
2463
2464         Reverted changeset:
2465
2466         "Remove unused WebFrame._loadType"
2467         https://bugs.webkit.org/show_bug.cgi?id=190583
2468         https://trac.webkit.org/changeset/237137
2469
2470 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2471
2472         Enable the datalist element by default on iOS and macOS
2473         https://bugs.webkit.org/show_bug.cgi?id=190594
2474         <rdar://problem/45281159>
2475
2476         Reviewed by Ryosuke Niwa and Tim Horton.
2477
2478         * Configurations/FeatureDefines.xcconfig:
2479
2480 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2481
2482         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2483         https://bugs.webkit.org/show_bug.cgi?id=190675
2484
2485         Reviewed by Chris Dumez.
2486
2487         * History/BackForwardList.h:
2488         * History/BackForwardList.mm:
2489         (BackForwardList::backItem):
2490         (BackForwardList::currentItem):
2491         (BackForwardList::forwardItem):
2492         (BackForwardList::backListCount const):
2493         (BackForwardList::forwardListCount const):
2494         (BackForwardList::itemAtIndex):
2495         * History/WebBackForwardList.mm:
2496         (-[WebBackForwardList backItem]):
2497         (-[WebBackForwardList currentItem]):
2498         (-[WebBackForwardList forwardItem]):
2499         (-[WebBackForwardList itemAtIndex:]):
2500
2501 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2502
2503         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2504         https://bugs.webkit.org/show_bug.cgi?id=190526
2505         rdar://problem/45230140
2506
2507         Reviewed by Dean Jackson.
2508
2509         * WebCoreSupport/WebEditorClient.mm:
2510         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2511
2512 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2513
2514         Implement feature flag and bindings for CSS Painting API
2515         https://bugs.webkit.org/show_bug.cgi?id=190237
2516
2517         Reviewed by Ryosuke Niwa.
2518
2519         * Configurations/FeatureDefines.xcconfig:
2520
2521 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2522
2523         Replace HistoryItem* with HistoryItem& where possible
2524         https://bugs.webkit.org/show_bug.cgi?id=190617
2525
2526         Reviewed by Chris Dumez.
2527
2528         * History/BackForwardList.h:
2529         * History/BackForwardList.mm:
2530         (BackForwardList::goToItem):
2531         * History/WebBackForwardList.mm:
2532         (-[WebBackForwardList goToItem:]):
2533         * History/WebHistoryItem.mm:
2534         (WKNotifyHistoryItemChanged):
2535         * History/WebHistoryItemInternal.h:
2536
2537 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2538
2539         Remove unused WebHistoryItem._transientPropertyForKey
2540         https://bugs.webkit.org/show_bug.cgi?id=190606
2541
2542         Reviewed by Chris Dumez.
2543
2544         * History/WebHistoryItem.mm:
2545         * History/WebHistoryItemPrivate.h:
2546
2547 2018-10-15  Justin Fan  <justin_fan@apple.com>
2548
2549         Add WebGPU 2018 feature flag and experimental feature flag
2550         https://bugs.webkit.org/show_bug.cgi?id=190509
2551
2552         Reviewed by Dean Jackson.
2553
2554         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2555         for the 2018 WebGPU prototype.
2556
2557         * Configurations/FeatureDefines.xcconfig:
2558         * WebView/WebPreferenceKeysPrivate.h:
2559         * WebView/WebPreferences.mm:
2560         (+[WebPreferences initialize]):
2561         (-[WebPreferences webGPUEnabled]):
2562         (-[WebPreferences setWebGPUEnabled:]):
2563         * WebView/WebPreferencesPrivate.h:
2564         * WebView/WebView.mm:
2565         (-[WebView _preferencesChanged:]):
2566
2567 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2568
2569         Fix iOS build after r237157
2570
2571         * WebView/WebView.mm:
2572         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2573
2574 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2575
2576         Modernize BackForwardClient.h
2577         https://bugs.webkit.org/show_bug.cgi?id=190610
2578
2579         Reviewed by Chris Dumez.
2580
2581         * History/BackForwardList.h:
2582         * History/BackForwardList.mm:
2583         (BackForwardList::backListCount const):
2584         (BackForwardList::forwardListCount const):
2585         (BackForwardList::backListCount): Deleted.
2586         (BackForwardList::forwardListCount): Deleted.
2587         * History/WebBackForwardList.mm:
2588         (-[WebBackForwardList init]):
2589         * WebCoreSupport/WebFrameLoaderClient.mm:
2590         (WebFrameLoaderClient::canCachePage const):
2591         * WebView/WebFrameView.mm:
2592         (-[WebFrameView keyDown:keyDown:]):
2593         * WebView/WebView.mm:
2594         (-[WebView _commonInitializationWithFrameName:groupName:]):
2595         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2596         (-[WebView _loadBackForwardListFromOtherView:]):
2597         (-[WebView initWithCoder:]):
2598         (-[WebView encodeWithCoder:]):
2599         (-[WebView backForwardList]):
2600         (-[WebView setMaintainsBackForwardList:]):
2601
2602 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2603
2604         Add support for prefers-color-scheme media query
2605         https://bugs.webkit.org/show_bug.cgi?id=190499
2606         rdar://problem/45212025
2607
2608         Reviewed by Dean Jackson.
2609
2610         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2611
2612 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2613
2614         Remove unused WebView._globalHistoryItem
2615         https://bugs.webkit.org/show_bug.cgi?id=190601
2616
2617         Reviewed by Chris Dumez.
2618
2619         * WebCoreSupport/WebFrameLoaderClient.h:
2620         * WebCoreSupport/WebFrameLoaderClient.mm:
2621         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2622         * WebView/WebView.mm:
2623         (-[WebView _globalHistoryItem]): Deleted.
2624         (-[WebView _setGlobalHistoryItem:]): Deleted.
2625         * WebView/WebViewData.h:
2626         * WebView/WebViewInternal.h:
2627         * WebView/WebViewPrivate.h:
2628
2629 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2630
2631         Remove unused parameters from FrameLoaderClient::createFrame
2632         https://bugs.webkit.org/show_bug.cgi?id=190587
2633
2634         Reviewed by Chris Dumez.
2635
2636         * WebCoreSupport/WebFrameLoaderClient.h:
2637         * WebCoreSupport/WebFrameLoaderClient.mm:
2638         (WebFrameLoaderClient::createFrame):
2639
2640 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2641
2642         Remove unused WebFrame._loadType
2643         https://bugs.webkit.org/show_bug.cgi?id=190583
2644
2645         Reviewed by Chris Dumez.
2646
2647         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2648
2649         * WebView/WebFrame.mm:
2650         (toWebFrameLoadType): Deleted.
2651         (-[WebFrame _loadType]): Deleted.
2652         * WebView/WebFramePrivate.h:
2653
2654 2018-10-15  Chris Dumez  <cdumez@apple.com>
2655
2656         Restrict browsing context lookup by name to frames that are related to one another
2657         https://bugs.webkit.org/show_bug.cgi?id=190475
2658
2659         Reviewed by Alex Christensen.
2660
2661         * WebView/WebFrame.mm:
2662         (-[WebFrame findFrameNamed:]):
2663
2664 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2665
2666         Remove InjectedBundle processing of back/forward lists
2667         https://bugs.webkit.org/show_bug.cgi?id=190459
2668
2669         Reviewed by Chris Dumez.
2670
2671         * WebCoreSupport/WebFrameLoaderClient.h:
2672         * WebCoreSupport/WebFrameLoaderClient.mm:
2673         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2674
2675 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2676
2677         [JSC] Remove Option::useAsyncIterator
2678         https://bugs.webkit.org/show_bug.cgi?id=190567
2679
2680         Reviewed by Saam Barati.
2681
2682         * Configurations/FeatureDefines.xcconfig:
2683
2684 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2685
2686         Allow encoding of small enum classes
2687         https://bugs.webkit.org/show_bug.cgi?id=190531
2688
2689         Reviewed by Tim Horton.
2690
2691         * WebCoreSupport/WebFrameLoaderClient.mm:
2692         (-[WebFramePolicyListener dealloc]):
2693
2694 2018-10-11  Keith Rollin  <krollin@apple.com>
2695
2696         CURRENT_ARCH should not be used in Run Script phase.
2697         https://bugs.webkit.org/show_bug.cgi?id=190407
2698         <rdar://problem/45133556>
2699
2700         Reviewed by Alexey Proskuryakov.
2701
2702         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2703         CURRENT_ARCH is not well-defined during this phase (and may even have
2704         the value "undefined") since this phase is run just once per build
2705         rather than once per supported architecture. Migrate away from
2706         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2707         performing an operation for each value, or by picking the first entry
2708         in ARCHS and using that as a representative value.
2709
2710         * Configurations/WebKitLegacy.xcconfig: When generating
2711         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2712         macosx platforms.
2713
2714         * MigrateHeaders.make:
2715         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2716         generate one for each architecture in ARCHS.
2717
2718 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2719
2720         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2721         https://bugs.webkit.org/show_bug.cgi?id=190429
2722
2723         Reviewed by Saam Barati.
2724
2725         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2726
2727         * WebView/WebPDFRepresentation.mm:
2728         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2729
2730 2018-10-08  Justin Fan  <justin_fan@apple.com>
2731
2732         WebGPU: Rename old WebGPU prototype to WebMetal
2733         https://bugs.webkit.org/show_bug.cgi?id=190325
2734         <rdar://problem/44990443>
2735
2736         Reviewed by Dean Jackson.
2737
2738         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2739
2740         * Configurations/FeatureDefines.xcconfig:
2741         * WebView/WebPreferenceKeysPrivate.h:
2742         * WebView/WebPreferences.mm:
2743         (+[WebPreferences initialize]):
2744         (-[WebPreferences webMetalEnabled]):
2745         (-[WebPreferences setWebMetalEnabled:]):
2746         (-[WebPreferences webGPUEnabled]): Deleted.
2747         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2748         * WebView/WebPreferencesPrivate.h:
2749         * WebView/WebView.mm:
2750         (-[WebView _preferencesChanged:]):
2751
2752 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2753
2754         Make <input type=color> a runtime enabled (on-by-default) feature
2755         https://bugs.webkit.org/show_bug.cgi?id=189162
2756
2757         Reviewed by Wenson Hsieh and Tim Horton.
2758
2759         * Configurations/FeatureDefines.xcconfig:
2760
2761 2018-10-07  Dan Bernstein  <mitz@apple.com>
2762
2763         Fixed building with the latest macOS SDK
2764
2765         * Plugins/WebNetscapePluginPackage.mm:
2766         (-[WebNetscapePluginPackage openResourceFile]):
2767         (-[WebNetscapePluginPackage closeResourceFile:]):
2768
2769 2018-10-04  Dan Bernstein  <mitz@apple.com>
2770
2771         More Carbon build-fixing.
2772
2773         * Carbon/CarbonWindowAdapter.mm:
2774         (-[CarbonWindowAdapter _destroyRealWindow:]):
2775         (-[CarbonWindowAdapter _growBoxRect]):
2776
2777 2018-10-04  Dan Bernstein  <mitz@apple.com>
2778
2779         Retried to fix 32-bit macOS builds after r236846.
2780
2781         * WebView/WebHTMLView.mm:
2782         (-[WebHTMLView setMarkedText:selectedRange:]):
2783
2784 2018-10-04  Dan Bernstein  <mitz@apple.com>
2785
2786         Retried to fix 32-bit macOS builds after r236846.
2787
2788         * Carbon/HIWebView.mm:
2789         (ActiveStateChanged):
2790
2791 2018-10-04  Dan Bernstein  <mitz@apple.com>
2792
2793         Tried to fix 32-bit macOS builds after r236846.
2794
2795         * Carbon/HIWebView.mm:
2796         (_NSSelectorForHICommand):
2797
2798 2018-10-04  Dan Bernstein  <mitz@apple.com>
2799
2800         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2801         https://bugs.webkit.org/show_bug.cgi?id=190250
2802
2803         Reviewed by Andy Estes.
2804
2805         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2806           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2807           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2808           an earlier line set it to YES.
2809
2810         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2811         changes below.
2812
2813         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2814           provides some missing method declarations.
2815
2816         * Misc/WebDownload.mm:
2817         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2818           a deprecated method.
2819
2820         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2821
2822         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2823           other code in the file uses a method from it.
2824
2825         * Plugins/WebBaseNetscapePluginView.mm:
2826         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2827           a deprecated method.
2828
2829         * Plugins/WebPluginController.mm:
2830         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2831           around use of a selector that may be present in some WebKit client.
2832
2833         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2834           method declarations.
2835
2836         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2837           from here.
2838
2839         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2840           missing method declarations.
2841
2842         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2843           from here.
2844
2845         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2846           call from here.
2847         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2848           an obsolete delegate method for binary compatibility.
2849         (pluginView): Ditto.
2850
2851         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2852           call from here.
2853
2854         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2855           WebDeviceOrientationProviderMock protocol.
2856
2857         * WebView/WebDeviceOrientationProviderMock.mm:
2858         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2859           main @implementation.
2860
2861         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2862           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2863
2864         * WebView/WebDynamicScrollBarsView.mm:
2865         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2866           of a deprecated method.
2867
2868         * WebView/WebHTMLView.mm:
2869         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2870           selector warning around action methods that are not declared anywhere in WebKit.
2871
2872         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2873           about implementing this deprecated method.
2874         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2875         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2876         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2877         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2878         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2879         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2880         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2881         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2882         (-[WebHTMLView doCommandBySelector:]): Ditto.
2883         (-[WebHTMLView insertText:]): Ditto.
2884
2885         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2886
2887         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2888
2889         * WebView/WebPDFView.h: Removed previewView ivar.
2890
2891         * WebView/WebPDFView.mm:
2892           Removed declaration of FileInternal category and merged its implementation with the main
2893           implementation.
2894         (-[WebPDFView dealloc]): Removed previewView ivar.
2895         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2896           exist in macOS versions we support.
2897         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2898         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2899           action methods internal to PDFKit.
2900         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2901         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2902
2903         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2904           call on macOS, even though in r86988 we started calling different methods on iOS.
2905
2906         * WebView/WebView.mm:
2907         - Imported headers that declare delegate methods that we call.
2908         - Removed declaration of WebFileInternal category and merged its implementation with the
2909           main implementation.
2910         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2911           category, which made them impossible to call from the main implementation. Moved those
2912           into the main implementation. One of those had to be declared in a class extension,
2913           because it is called from a method implemented in the WebPrivate category, and that
2914           category’s implementation appears first in the file.
2915
2916         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2917           around use of obsolete delegate method for binary compatibility.
2918
2919         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2920
2921 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2922
2923         Runtime flag and IDL for MediaRecorder
2924         https://bugs.webkit.org/show_bug.cgi?id=190018
2925
2926         Reviewed by Youenn Fablet and Chris Dumez.
2927
2928         * WebView/WebPreferenceKeysPrivate.h:
2929         * WebView/WebPreferences.mm:
2930         (+[WebPreferences initialize]):
2931         (-[WebPreferences mediaRecorderEnabled]):
2932         (-[WebPreferences setMediaRecorderEnabled:]):
2933         * WebView/WebPreferencesPrivate.h:
2934         * WebView/WebView.mm:
2935         (-[WebView _preferencesChanged:]):
2936
2937 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2938
2939         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2940         https://bugs.webkit.org/show_bug.cgi?id=190238
2941
2942         Reviewed by Antti Koivisto.
2943
2944         Enabled the feature by default.
2945
2946         * WebView/WebPreferences.mm:
2947         (+[WebPreferences initialize]):
2948
2949 2018-10-01  Dean Jackson  <dino@apple.com>
2950
2951         [macOS] Switching to discrete GPU should be done in the UI process
2952         https://bugs.webkit.org/show_bug.cgi?id=189361
2953         <rdar://problem/43949622>
2954
2955         Reviewed by Simon Fraser.
2956
2957         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2958         not support swapping to the discrete GPU in this configuration.
2959
2960         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2961         (WebKit::WebSwitchingGPUClient::singleton):
2962         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2963         * WebView/WebView.mm:
2964         (-[WebView _commonInitializationWithFrameName:groupName:]):
2965
2966 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2967
2968         Remove ParsedURLString
2969         https://bugs.webkit.org/show_bug.cgi?id=190154
2970
2971         Reviewed by Chris Dumez.
2972
2973         * WebView/WebScriptDebugger.mm:
2974         (toNSURL):
2975
2976 2018-10-01  Dean Jackson  <dino@apple.com>
2977
2978         Remove CSS Animation Triggers
2979         https://bugs.webkit.org/show_bug.cgi?id=190175
2980         <rdar://problem/44925626>
2981
2982         Reviewed by Simon Fraser.
2983
2984         * Configurations/FeatureDefines.xcconfig:
2985
2986 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2987
2988         Unreviewed, rolling out r236624 and r236671.
2989         https://bugs.webkit.org/show_bug.cgi?id=190207
2990
2991         The change in r236624 introduced crashes on the bots
2992         (Requested by ryanhaddad on #webkit).
2993
2994         Reverted changesets:
2995
2996         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2997         https://bugs.webkit.org/show_bug.cgi?id=188747
2998         https://trac.webkit.org/changeset/236624
2999
3000         "Unify implementation in VideoFullscreenInterfaceAVKit"
3001         https://bugs.webkit.org/show_bug.cgi?id=190091
3002         https://trac.webkit.org/changeset/236671
3003
3004 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3005
3006         URL should not use TextEncoding internally
3007         https://bugs.webkit.org/show_bug.cgi?id=190111
3008
3009         Reviewed by Andy Estes.
3010
3011         * Misc/WebNSURLExtras.mm:
3012
3013 2018-09-28  Jer Noble  <jer.noble@apple.com>
3014
3015         Refactoring: eliminate raw pointer usage in Fullscreen code
3016         https://bugs.webkit.org/show_bug.cgi?id=188747
3017         <rdar://problem/43541164>
3018
3019         Reviewed by Alex Christensen.
3020
3021         PlaybackSessionInterface no longer has an invalidate() method.
3022
3023         * WebView/WebView.mm:
3024         (-[WebView _clearPlaybackControlsManager]):
3025
3026 2018-09-28  Chris Dumez  <cdumez@apple.com>
3027
3028         Drop support for cross-origin-window-policy header
3029         https://bugs.webkit.org/show_bug.cgi?id=190081
3030
3031         Reviewed by Ryosuke Niwa.
3032
3033         * WebView/WebPreferenceKeysPrivate.h:
3034         * WebView/WebPreferences.mm:
3035         (+[WebPreferences initialize]):
3036         * WebView/WebPreferencesPrivate.h:
3037         * WebView/WebView.mm:
3038         (-[WebView _preferencesChanged:]):
3039
3040 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3041
3042         Rename createMarkup to serializePreservingVisualAppearance
3043         https://bugs.webkit.org/show_bug.cgi?id=190086
3044
3045         Reviewed by Wenson Hsieh.
3046
3047         * DOM/WebDOMOperations.mm:
3048         (-[DOMRange markupString]):
3049
3050 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3051
3052         Unreviewed, rolling out r236605.
3053         https://bugs.webkit.org/show_bug.cgi?id=190087
3054
3055         caused three API test timeouts (Requested by jernoble on
3056         #webkit).
3057
3058         Reverted changeset:
3059
3060         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3061         https://bugs.webkit.org/show_bug.cgi?id=188747
3062         https://trac.webkit.org/changeset/236605
3063
3064 2018-09-28  Jer Noble  <jer.noble@apple.com>
3065
3066         Refactoring: eliminate raw pointer usage in Fullscreen code
3067         https://bugs.webkit.org/show_bug.cgi?id=188747
3068         <rdar://problem/43541164>
3069
3070         Reviewed by Alex Christensen.
3071
3072         PlaybackSessionInterface no longer has an invalidate() method.
3073
3074         * WebView/WebView.mm:
3075         (-[WebView _clearPlaybackControlsManager]):
3076
3077 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3078
3079         Use enum class in createMarkup arguments
3080         https://bugs.webkit.org/show_bug.cgi?id=190028
3081
3082         Reviewed by Wenson Hsieh.
3083
3084         * DOM/WebDOMOperations.mm:
3085         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3086         (-[DOMRange markupString]): Ditto.
3087
3088 2018-09-27  Antoine Quint  <graouts@apple.com>
3089
3090         [Web Animations] Turn Web Animations with CSS integration on
3091         https://bugs.webkit.org/show_bug.cgi?id=184819
3092         <rdar://problem/39597337>
3093
3094         Reviewed by Dean Jackson.
3095
3096         * WebView/WebPreferences.mm:
3097         (+[WebPreferences initialize]):
3098
3099 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3100
3101         Selection should work across shadow boundary when initiated by a mouse drag
3102         https://bugs.webkit.org/show_bug.cgi?id=151380
3103         <rdar://problem/24363872>
3104
3105         Reviewed by Wenson Hsieh.
3106
3107         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3108
3109         * WebView/WebPreferenceKeysPrivate.h:
3110         * WebView/WebPreferences.mm:
3111         (+[WebPreferences initialize]):
3112         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3113         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3114         * WebView/WebPreferencesPrivate.h:
3115         * WebView/WebView.mm:
3116         (-[WebView _preferencesChanged:]):
3117
3118 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3119
3120         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3121         https://bugs.webkit.org/show_bug.cgi?id=189918
3122         Work towards <rdar://problem/44648705>
3123
3124         Reviewed by Tim Horton.
3125
3126         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3127
3128         * WebView/WebHTMLView.mm:
3129         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3130         (-[WebHTMLView _updateFontPanel]):
3131         * WebView/WebView.mm:
3132         (-[WebView typingAttributes]):
3133
3134 2018-09-17  Darin Adler  <darin@apple.com>
3135
3136         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3137         https://bugs.webkit.org/show_bug.cgi?id=189652
3138
3139         Reviewed by Saam Barati.
3140
3141         * WebView/WebPDFRepresentation.mm:
3142         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3143
3144 2018-09-14  Jer Noble  <jer.noble@apple.com>
3145
3146         Turn SourceBufferChangeTypeEnabled on by default
3147         https://bugs.webkit.org/show_bug.cgi?id=189527
3148
3149         Reviewed by Eric Carlson.
3150
3151         * WebView/WebPreferences.mm:
3152         (+[WebPreferences initialize]):
3153
3154 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3155
3156         Fix an internal build after r235935
3157         https://bugs.webkit.org/show_bug.cgi?id=188996
3158
3159         * Carbon/HIWebView.mm:
3160         (Draw):
3161         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3162
3163 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3164
3165         Add IGNORE_WARNING_.* macros
3166         https://bugs.webkit.org/show_bug.cgi?id=188996
3167
3168         Reviewed by Michael Catanzaro.
3169
3170         * Carbon/CarbonUtils.m:
3171         (PoolCleaner):
3172         * Carbon/CarbonWindowAdapter.mm:
3173         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3174         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3175         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3176         (-[CarbonWindowAdapter _termWindowIfOwner]):
3177         (-[CarbonWindowAdapter _windowMovedToRect:]):
3178         (-[CarbonWindowAdapter setContentView:]):
3179         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3180         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3181         * Carbon/CarbonWindowFrame.m:
3182         (-[CarbonWindowFrame title]):
3183         * Carbon/HIViewAdapter.m:
3184         (+[HIViewAdapter getHIViewForNSView:]):
3185         * Carbon/HIWebView.mm:
3186         (overrideCGContext):
3187         (restoreCGContext):
3188         (Draw):
3189         * DOM/DOM.mm:
3190         * History/WebHistory.mm:
3191         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3192         * History/WebHistoryItem.mm:
3193         (-[WebHistoryItem icon]):
3194         * Misc/WebKitNSStringExtras.mm:
3195         (-[NSString _web_drawAtPoint:font:textColor:]):
3196         * Misc/WebNSImageExtras.m:
3197         (-[NSImage _web_scaleToMaxSize:]):
3198         (-[NSImage _web_dissolveToFraction:]):
3199         * Misc/WebNSPasteboardExtras.mm:
3200         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3201         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3202         * Panels/WebAuthenticationPanel.m:
3203         (-[WebAuthenticationPanel loadNib]):
3204         * Plugins/Hosted/NetscapePluginHostManager.mm:
3205         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3206         (WebKit::NetscapePluginHostManager::didCreateWindow):
3207         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3208         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3209         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3210         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3211         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3212         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3213         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3214         (-[WebHostedNetscapePluginView drawRect:]):
3215         * Plugins/Hosted/WebTextInputWindowController.m:
3216         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3217         * Plugins/WebBaseNetscapePluginView.mm:
3218         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3219         * Plugins/WebNetscapePluginPackage.mm:
3220         (-[WebNetscapePluginPackage _tryLoad]):
3221         * Plugins/WebNetscapePluginView.mm:
3222         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3223         (-[WebNetscapePluginView sendDrawRectEvent:]):
3224         (-[WebNetscapePluginView drawRect:]):
3225         * Plugins/WebPluginController.mm:
3226         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3227         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3228         * WebCoreSupport/PopupMenuMac.mm:
3229         (PopupMenuMac::populate):
3230         * WebCoreSupport/WebAlternativeTextClient.h:
3231         * WebCoreSupport/WebDragClient.mm:
3232         (WebDragClient::startDrag):
3233         * WebCoreSupport/WebFrameLoaderClient.mm:
3234         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3235         (webGetNSImage):
3236         * WebInspector/WebNodeHighlight.mm:
3237         * WebInspector/WebNodeHighlightView.mm:
3238         (-[WebNodeHighlightView drawRect:]):
3239         * WebView/WebClipView.mm:
3240         (-[WebClipView initWithFrame:]):
3241         * WebView/WebFrame.mm:
3242         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3243         (-[WebFrame _drawRect:contentsOnly:]):
3244         (-[WebFrame accessibilityRoot]):
3245         * WebView/WebFullScreenController.mm:
3246         (-[WebFullScreenController enterFullScreen:]):
3247         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3248         (-[WebFullScreenController exitFullScreen]):
3249         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3250         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3251         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3252         * WebView/WebHTMLView.mm:
3253         (-[NSWindow _web_borderView]):
3254         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3255         (-[WebHTMLView _setAsideSubviews]):
3256         (-[WebHTMLView _autoscroll]):
3257         (-[WebHTMLView drawRect:]):
3258         (-[WebHTMLView mouseDown:]):
3259         (-[WebHTMLView mouseDragged:]):
3260         (-[WebHTMLView mouseUp:]):
3261         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3262         (-[WebHTMLView knowsPageRange:]):
3263         (-[WebHTMLView accessibilityHitTest:]):
3264         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3265         (-[WebHTMLView _colorAsString:]):
3266         (-[WebHTMLView copyFont:]):
3267         (-[WebHTMLView _executeSavedKeypressCommands]):
3268         (-[WebHTMLView attachRootLayer:]):
3269         (-[WebHTMLView textStorage]):
3270         (-[WebHTMLView _updateSelectionForInputManager]):
3271         * WebView/WebPDFView.mm:
3272         (_applicationInfoForMIMEType):
3273         (-[WebPDFView centerSelectionInVisibleArea:]):
3274         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3275         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3276         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3277         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3278         * WebView/WebTextCompletionController.mm:
3279         (-[WebTextCompletionController _buildUI]):
3280         (-[WebTextCompletionController _placePopupWindow:]):
3281         * WebView/WebVideoFullscreenController.mm:
3282         * WebView/WebVideoFullscreenHUDWindowController.mm:
3283         (createMediaUIBackgroundView):
3284         * WebView/WebView.mm:
3285         (-[WebTextListTouchBarViewController initWithWebView:]):
3286         (-[WebView _dispatchTileDidDraw:]):
3287         (-[WebView encodeWithCoder:]):
3288         (-[WebView mainFrameIcon]):
3289         (LayerFlushController::flushLayers):
3290         * WebView/WebWindowAnimation.mm:
3291         (setScaledFrameForWindow):
3292
3293 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3294
3295         Remove unused needsDestruction class variables from HashTraits
3296         https://bugs.webkit.org/show_bug.cgi?id=189490
3297
3298         Reviewed by Daniel Bates.
3299
3300         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3301
3302 2018-09-07  Frederic Wang  <fwang@igalia.com>
3303
3304         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3305         https://bugs.webkit.org/show_bug.cgi?id=182230
3306
3307         Reviewed by Simon Fraser.
3308
3309         * DOM/DOMDocument.mm:
3310         (-[DOMDocument scrollingElement]): Use the new name.
3311
3312 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3313
3314         Refactor WebCore::EditAction to be an 8-bit enum class
3315         https://bugs.webkit.org/show_bug.cgi?id=189383
3316
3317         Reviewed by Dan Bernstein.
3318
3319         * WebCoreSupport/WebEditorClient.mm:
3320         (undoNameForEditAction):
3321         * WebView/WebHTMLView.mm:
3322         (-[WebHTMLView pasteFont:]):
3323         (-[WebHTMLView changeFont:]):
3324         (-[WebHTMLView changeAttributes:]):
3325         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3326         (-[WebHTMLView changeColor:]):
3327         * WebView/WebView.mm:
3328         (-[WebView setTypingStyle:]):
3329
3330 2018-09-06  Frederic Wang  <fwang@igalia.com>
3331
3332         Group options of scrollRectToVisible into a struct
3333         https://bugs.webkit.org/show_bug.cgi?id=189352
3334
3335         Reviewed by Simon Fraser.
3336
3337         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3338         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3339         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3340
3341 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3342
3343         [macOS] Cannot change font size at selection until font panel is shown
3344         https://bugs.webkit.org/show_bug.cgi?id=189295
3345         <rdar://problem/35593389>
3346
3347         Reviewed by Ryosuke Niwa.
3348
3349         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3350         WebCore ChangeLog for more details.
3351
3352         * WebView/WebHTMLView.mm:
3353         (-[WebHTMLView changeFont:]):
3354         (-[WebHTMLView changeAttributes:]):
3355         (-[WebHTMLView _originalFontA]): Deleted.
3356         (-[WebHTMLView _originalFontB]): Deleted.
3357         (fontNameForDescription): Deleted.
3358         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3359         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3360         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3361
3362 2018-09-05  Jer Noble  <jer.noble@apple.com>
3363
3364         Add MediaCapabilities as an Experimental Feature
3365         https://bugs.webkit.org/show_bug.cgi?id=189209
3366
3367         Reviewed by Eric Carlson.
3368
3369         RuntimeEnabledFeature -> Setting.
3370
3371         * WebView/WebView.mm:
3372         (-[WebView _preferencesChanged:]):
3373
3374 2018-09-04  Frederic Wang  <fwang@igalia.com>
3375
3376         Add basic support for ScrollIntoViewOptions
3377         https://bugs.webkit.org/show_bug.cgi?id=189258
3378
3379         Reviewed by Simon Fraser.
3380
3381         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3382         header so that this file can build despite the new scrollIntoView function.
3383
3384 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3385
3386         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3387         https://bugs.webkit.org/show_bug.cgi?id=188890
3388         <rdar://problem/43648605>
3389
3390         Reviewed by Tim Horton.
3391
3392         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3393         more detail.
3394
3395         * WebCoreSupport/WebPlatformStrategies.h:
3396         * WebCoreSupport/WebPlatformStrategies.mm:
3397         (WebPlatformStrategies::allStringsForType):
3398
3399 2018-09-01  Darin Adler  <darin@apple.com>
3400
3401         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3402         https://bugs.webkit.org/show_bug.cgi?id=189072
3403         Reviewed by Dan Bernstein.
3404
3405         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3406         and declarations for NSURLDownload init methods.
3407
3408         * Misc/WebDownloadInternal.h: Removed.
3409
3410         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3411         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3412         "-Wdeprecated-declarations" because the method used here is deprecated.
3413
3414         * WebView/WebView.mm:
3415         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3416         used here is deprecated.
3417
3418 2018-08-31  Chris Dumez  <cdumez@apple.com>
3419
3420         Assertion hit in ~CompletionHandler() from ~WebFrame()
3421         https://bugs.webkit.org/show_bug.cgi?id=189199
3422         <rdar://problem/42657233>
3423
3424         Reviewed by Youenn Fablet.
3425
3426         * WebCoreSupport/WebFrameLoaderClient.h:
3427         * WebCoreSupport/WebFrameLoaderClient.mm:
3428         (WebFrameLoaderClient::dispatchWillSubmitForm):
3429
3430 2018-08-31  Antti Koivisto  <antti@apple.com>
3431
3432         Replace OptionSet |= and -= operators with add() and remove() functions
3433         https://bugs.webkit.org/show_bug.cgi?id=189169
3434
3435         Reviewed by Anders Carlsson.
3436
3437         * WebView/WebFrame.mm:
3438         (-[WebFrame _drawRect:contentsOnly:]):
3439         * WebView/WebView.mm:
3440         (coreOptions):
3441
3442 2018-08-31  Frederic Wang  <fwang@igalia.com>
3443
3444         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3445         https://bugs.webkit.org/show_bug.cgi?id=182053
3446
3447         Reviewed by Simon Fraser.
3448
3449         Add developer flag to use standard behavior for scrolling* attributes.
3450
3451         * WebView/WebPreferenceKeysPrivate.h:
3452         * WebView/WebPreferences.mm:
3453         (+[WebPreferences initialize]):
3454         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3455         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3456         * WebView/WebPreferencesPrivate.h:
3457         * WebView/WebView.mm:
3458         (-[WebView _preferencesChanged:]):
3459
3460 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3461
3462         Implement the Web Share API
3463         https://bugs.webkit.org/show_bug.cgi?id=171100
3464         <rdar://problem/31751734>
3465
3466         Reviewed by Tim Horton.
3467
3468         * WebCoreSupport/WebChromeClient.h:
3469         * WebCoreSupport/WebChromeClient.mm:
3470         (WebChromeClient::showShareSheet):
3471         Empty declaration of showShareSheet.
3472
3473 2018-08-29  Youenn Fablet  <youenn@apple.com>
3474
3475         Remove WebRTC legacy API implementation
3476         https://bugs.webkit.org/show_bug.cgi?id=189040
3477
3478         Reviewed by Eric Carlson.
3479
3480         * WebView/WebPreferenceKeysPrivate.h:
3481         * WebView/WebPreferences.mm:
3482         (+[WebPreferences initialize]):
3483         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3484         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3485         * WebView/WebPreferencesPrivate.h:
3486         * WebView/WebView.mm:
3487         (-[WebView _preferencesChanged:]):
3488
3489 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3490
3491         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3492         https://bugs.webkit.org/show_bug.cgi?id=189054
3493
3494         Reviewed by Andy Estes.
3495
3496         Remove the pasteboard type argument from readURLFromPasteboard.
3497
3498         * WebCoreSupport/WebPlatformStrategies.h:
3499         * WebCoreSupport/WebPlatformStrategies.mm:
3500         (WebPlatformStrategies::readURLFromPasteboard):
3501
3502 2018-08-27  Keith Rollin  <krollin@apple.com>
3503
3504         Unreviewed build fix -- disable LTO for production builds
3505
3506         * Configurations/Base.xcconfig:
3507
3508 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3509
3510         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3511         https://bugs.webkit.org/show_bug.cgi?id=188931
3512
3513         Reviewed by Wenson Hsieh.
3514
3515         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3516
3517 2018-08-27  Keith Rollin  <krollin@apple.com>
3518
3519         Build system support for LTO
3520         https://bugs.webkit.org/show_bug.cgi?id=187785
3521         <rdar://problem/42353132>
3522
3523         Reviewed by Dan Bernstein.
3524
3525         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3526         LTO.
3527
3528         * Configurations/Base.xcconfig:
3529         * Configurations/DebugRelease.xcconfig:
3530
3531 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3532
3533         Pass in IsComposed flag to Event constructors
3534         https://bugs.webkit.org/show_bug.cgi?id=188720
3535         <rdar://problem/43580387>
3536
3537         Reviewed by Simon Fraser.
3538
3539         * WebView/WebPDFView.mm:
3540         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3541         whether it's simulated or not.
3542
3543 2018-08-23  Mark Lam  <mark.lam@apple.com>
3544
3545         Move vmEntryGlobalObject() to VM from CallFrame.
3546         https://bugs.webkit.org/show_bug.cgi?id=188900
3547         <rdar://problem/43655753>
3548
3549         Reviewed by Michael Saboff.
3550
3551         * WebView/WebScriptDebugger.mm:
3552         (WebScriptDebugger::sourceParsed):
3553
3554 2018-08-23  Andy Estes  <aestes@apple.com>
3555
3556         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3557         https://bugs.webkit.org/show_bug.cgi?id=188829
3558
3559         Reviewed by Tim Horton.
3560
3561         * Configurations/FeatureDefines.xcconfig:
3562
3563 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3564
3565         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3566         https://bugs.webkit.org/show_bug.cgi?id=188777
3567
3568         Reviewed by Simon Fraser.
3569
3570         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3571         being "true" before the code change.
3572
3573         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3574
3575         * WebView/WebPDFView.mm:
3576         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3577
3578 2018-08-21  Daniel Bates  <dabates@apple.com>
3579
3580         Replace TextCheckingTypeMask with OptionSet
3581         https://bugs.webkit.org/show_bug.cgi?id=188678
3582
3583         Reviewed by Antti Koivisto.
3584
3585         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3586         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3587         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3588         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3589
3590         * WebCoreSupport/WebEditorClient.h:
3591         * WebCoreSupport/WebEditorClient.mm:
3592         (WebEditorClient::checkTextOfParagraph):
3593         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3594         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3595         left as this is more readable and unncessary now that modern compilers like Clang have
3596         diagnostics to catch accidental assignments when equality was intended.
3597         (WebEditorClient::didCheckSucceed):
3598         * WebView/WebView.mm:
3599         (coreTextCheckingType):
3600         (textCheckingResultFromNSTextCheckingResult):
3601
3602 2018-08-21  Daniel Bates  <dabates@apple.com>
3603
3604         [iOS][WK1] Support toggling continuous spell checking from tests
3605         https://bugs.webkit.org/show_bug.cgi?id=188763
3606
3607         Reviewed by Simon Fraser.
3608
3609         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3610         spell checking from tests in iOS WebKit Legacy.
3611
3612         * WebCoreSupport/WebEditorClient.h:
3613         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3614         * WebCoreSupport/WebEditorClient.mm:
3615         * WebView/WebView.h:
3616         * WebView/WebView.mm:
3617         (-[WebView toggleContinuousSpellChecking:]):
3618         (-[WebView toggleSmartInsertDelete:]):
3619
3620 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3621
3622         Add some plumbing for safe browsing
3623         https://bugs.webkit.org/show_bug.cgi?id=188709
3624
3625         Reviewed by Tim Horton.
3626
3627         * WebCoreSupport/WebFrameLoaderClient.h:
3628         * WebCoreSupport/WebFrameLoaderClient.mm:
3629         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3630
3631 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3632
3633         Replace canBubble and cancelable booleans in Event by enum classes
3634         https://bugs.webkit.org/show_bug.cgi?id=188692
3635
3636         Reviewed by Alex Christensen.
3637
3638         * WebView/WebPDFView.mm:
3639         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3640         * WebView/WebView.mm:
3641         (-[WebView _dispatchUnloadEvent]):
3642
3643 2018-08-16  Jer Noble  <jer.noble@apple.com>
3644
3645         Add Experimental Feature support for SourceBuffer.changeType()
3646         https://bugs.webkit.org/show_bug.cgi?id=188626
3647         <rdar://problem/43356021>
3648
3649         Reviewed by Eric Carlson.
3650
3651         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3652
3653         * WebView/WebPreferenceKeysPrivate.h:
3654         * WebView/WebPreferences.mm:
3655         (+[WebPreferences initialize]):
3656         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3657         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3658         * WebView/WebPreferencesPrivate.h:
3659         * WebView/WebView.mm:
3660         (-[WebView _preferencesChanged:]):
3661
3662 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3663
3664         Support drag-and-drop for input[type=color]
3665         https://bugs.webkit.org/show_bug.cgi?id=188464
3666
3667         Reviewed by Wenson Hsieh.
3668
3669         * WebCoreSupport/WebPlatformStrategies.h:
3670         * WebCoreSupport/WebPlatformStrategies.mm:
3671         (WebPlatformStrategies::setColor):
3672
3673 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3674
3675         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3676         https://bugs.webkit.org/show_bug.cgi?id=188569
3677         <rdar://problem/34201095>
3678
3679         Reviewed by Megan Gardner.
3680
3681         * WebView/WebImmediateActionController.mm:
3682         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3683         Speculative fix; the crashes indicate font is null, but we just checked it,
3684         so it must be getting made null by convertFont:toSize:. Check again!
3685
3686 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3687
3688         Use a 1-byte enum class for TextDirection
3689         https://bugs.webkit.org/show_bug.cgi?id=188350
3690
3691         Reviewed by Simon Fraser.
3692
3693         * WebCoreSupport/PopupMenuMac.mm:
3694         (PopupMenuMac::populate):
3695         (PopupMenuMac::show):
3696         * WebCoreSupport/WebFrameLoaderClient.mm:
3697         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3698         * WebView/WebFrame.mm:
3699         (-[WebFrame _dispatchDidReceiveTitle:]):
3700
3701 2018-08-09  Ali Juma  <ajuma@chromium.org>
3702
3703         Import WPTs for IntersectionObserver
3704         https://bugs.webkit.org/show_bug.cgi?id=188416
3705
3706         Reviewed by Simon Fraser.
3707
3708         * WebView/WebPreferencesPrivate.h:
3709
3710 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3711
3712         Follow-up build fix for r234685
3713         https://bugs.webkit.org/show_bug.cgi?id=188245
3714
3715         Unreviewed build fix.
3716
3717         * WebCoreSupport/WebSecurityOriginPrivate.h:
3718
3719 2018-08-05  Darin Adler  <darin@apple.com>
3720
3721         [Cocoa] More tweaks and refactoring to prepare for ARC
3722         https://bugs.webkit.org/show_bug.cgi?id=188245
3723
3724         Reviewed by Dan Bernstein.
3725
3726         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3727
3728         * Carbon/CarbonWindowFrame.m:
3729         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3730
3731         * DOM/DOM.mm:
3732         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3733         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3734         garbage collection so this method isn't useful.
3735
3736         * DOM/DOMXPath.mm:
3737         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3738         Objective-C garbage collection so this method isn't useful.
3739
3740         * History/WebHistory.mm:
3741         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3742
3743         * Misc/WebElementDictionary.mm:
3744         (addLookupKey): Use a bridging cast.
3745         (cacheValueForKey): Ditto.
3746         (-[WebElementDictionary _fillCache]): Ditto.
3747         (-[WebElementDictionary objectForKey:]): Ditto.
3748
3749         * Misc/WebKitNSStringExtras.mm:
3750         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3751         (-[NSString _web_widthWithFont:]): Ditto.
3752         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3753
3754         * Misc/WebLocalizableStrings.mm:
3755         (WebLocalizedString): Use a bridging cast.
3756
3757         * Misc/WebNSDataExtras.mm:
3758         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3759         and use CFBridgingRelease instead of calling autorelease directly.
3760         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3761         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3762         on the amount of explicit release and autorelease.
3763
3764         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3765         * Misc/WebNSDictionaryExtras.m:
3766         (-[NSDictionary _webkit_intForKey:]): Deleted.
3767         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3768         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3769         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3770         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3771         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3772         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3773
3774         * Misc/WebStringTruncator.mm:
3775         (fontFromNSFont): Use a bridging cast.
3776
3777         * Plugins/Hosted/NetscapePluginHostManager.mm:
3778         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3779
3780         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3781         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3782         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3783         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3784         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3785         * Plugins/Hosted/ProxyInstance.mm:
3786         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3787         * Plugins/WebBasePluginPackage.mm:
3788         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3789         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3790         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3791         * Plugins/WebNetscapePluginPackage.mm:
3792         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3793
3794         * Plugins/WebNetscapePluginView.mm:
3795         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3796         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3797         (-[WebNetscapePluginView status:]): Use a bridging cast.
3798         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3799
3800         * Plugins/WebPluginController.mm:
3801         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3802
3803         * Plugins/WebPluginDatabase.mm:
3804         (checkCandidate): Use explicit __strong for out argument types.
3805
3806         * Plugins/npapi.mm:
3807         (pluginViewForInstance): Use a bridging cast.
3808
3809         * Storage/WebDatabaseManager.mm:
3810         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3811         explicit NSNumber and NSDictionary calls.
3812
3813         * WebCoreSupport/WebContextMenuClient.mm:
3814         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3815
3816         * WebCoreSupport/WebEditorClient.mm:
3817         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3818         (WebEditorClient::handleInputMethodKeydown): Ditto.
3819
3820         * WebCoreSupport/WebFrameNetworkingContext.mm:
3821         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3822
3823         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3824         as a struct rather than an Objective-C class, since that's how it's defined.
3825
3826         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3827
3828         * WebView/WebFullScreenController.mm:
3829         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3830         * WebView/WebHTMLView.mm:
3831         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3832         Ditto.
3833         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3834
3835         * WebView/WebImmediateActionController.mm:
3836         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3837         go down to the document and then back to the frame.
3838         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3839         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3840         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3841
3842         * WebView/WebJSPDFDoc.mm:
3843         (jsPDFDocInitialize): Removed some unneeded type casting.
3844         (jsPDFDocFinalize): Ditto.
3845         (jsPDFDocPrint): Use a bridging cast.
3846
3847         * WebView/WebPDFView.mm:
3848         (_applicationInfoForMIMEType): Use bridging casts.
3849
3850         * WebView/WebPreferences.mm:
3851         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3852         instead of methods from WebNSDictionaryExtras.
3853         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3854         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3855         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3856         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3857         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3858
3859         * WebView/WebView.mm:
3860         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3861         (-[WebView _addToAllWebViewsSet]): Ditto.
3862         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3863         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3864         so it can be called from WebViewData methods.
3865
3866         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3867         method, _windowVisibilityChanged:.
3868
3869         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3870         called from WebViewData methods.
3871
3872 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3873
3874         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3875         https://bugs.webkit.org/show_bug.cgi?id=188323
3876
3877         Reviewed by Simon Fraser.
3878
3879         * WebCoreSupport/WebContextMenuClient.mm:
3880         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3881         * WebView/WebFrame.mm:
3882         (-[WebFrame _paintBehaviorForDestinationContext:]):
3883         (-[WebFrame _drawRect:contentsOnly:]):
3884         * WebView/WebHTMLView.mm:
3885         (imageFromRect):
3886         (selectionImage):
3887
3888 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3889
3890         Add support for microtasks in workers
3891         https://bugs.webkit.org/show_bug.cgi?id=188246
3892
3893         Reviewed by Darin Adler.
3894
3895         Rename JSMainThreadExecState.h to JSExecState.h.
3896
3897         * DOM/DOMAttr.mm:
3898         * DOM/DOMBlob.mm:
3899         * DOM/DOMCDATASection.mm:
3900         * DOM/DOMCSSCharsetRule.mm:
3901         * DOM/DOMCSSFontFaceRule.mm:
3902         * DOM/DOMCSSImportRule.mm:
3903         * DOM/DOMCSSMediaRule.mm:
3904         * DOM/DOMCSSPageRule.mm:
3905         * DOM/DOMCSSPrimitiveValue.mm:
3906         * DOM/DOMCSSRule.mm:
3907         * DOM/DOMCSSRuleList.mm:
3908         * DOM/DOMCSSStyleDeclaration.mm:
3909         * DOM/DOMCSSStyleRule.mm:
3910         * DOM/DOMCSSStyleSheet.mm:
3911         * DOM/DOMCSSUnknownRule.mm:
3912         * DOM/DOMCSSValue.mm:
3913         * DOM/DOMCSSValueList.mm:
3914         * DOM/DOMCharacterData.mm:
3915         * DOM/DOMComment.mm:
3916         * DOM/DOMCounter.mm:
3917         * DOM/DOMDocument.mm:
3918         * DOM/DOMDocumentFragment.mm:
3919         * DOM/DOMDocumentType.mm:
3920         * DOM/DOMElement.mm:
3921         * DOM/DOMEvent.mm:
3922         * DOM/DOMFile.mm:
3923         * DOM/DOMFileList.mm:
3924         * DOM/DOMHTML.mm:
3925         * DOM/DOMHTMLAnchorElement.mm:
3926         * DOM/DOMHTMLAppletElement.mm:
3927         * DOM/DOMHTMLAreaElement.mm:
3928         * DOM/DOMHTMLBRElement.mm:
3929         * DOM/DOMHTMLBaseElement.mm:
3930         * DOM/DOMHTMLBaseFontElement.mm:
3931         * DOM/DOMHTMLBodyElement.mm:
3932         * DOM/DOMHTMLButtonElement.mm:
3933         * DOM/DOMHTMLCanvasElement.mm:
3934         * DOM/DOMHTMLCollection.mm:
3935         * DOM/DOMHTMLDListElement.mm:
3936         * DOM/DOMHTMLDirectoryElement.mm:
3937         * DOM/DOMHTMLDivElement.mm:
3938         * DOM/DOMHTMLDocument.mm:
3939         * DOM/DOMHTMLElement.mm:
3940         * DOM/DOMHTMLEmbedElement.mm:
3941         * DOM/DOMHTMLFieldSetElement.mm:
3942         * DOM/DOMHTMLFontElement.mm:
3943         * DOM/DOMHTMLFormElement.mm:
3944         * DOM/DOMHTMLFrameElement.mm:
3945         * DOM/DOMHTMLFrameSetElement.mm:
3946         * DOM/DOMHTMLHRElement.mm:
3947         * DOM/DOMHTMLHeadElement.mm:
3948         * DOM/DOMHTMLHeadingElement.mm:
3949         * DOM/DOMHTMLHtmlElement.mm:
3950         * DOM/DOMHTMLIFrameElement.mm:
3951         * DOM/DOMHTMLImageElement.mm:
3952         * DOM/DOMHTMLInputElement.mm:
3953         * DOM/DOMHTMLLIElement.mm:
3954         * DOM/DOMHTMLLabelElement.mm:
3955         * DOM/DOMHTMLLegendElement.mm:
3956         * DOM/DOMHTMLLinkElement.mm:
3957         * DOM/DOMHTMLMapElement.mm:
3958         * DOM/DOMHTMLMarqueeElement.mm:
3959         * DOM/DOMHTMLMediaElement.mm:
3960         * DOM/DOMHTMLMenuElement.mm:
3961         * DOM/DOMHTMLMetaElement.mm:
3962         * DOM/DOMHTMLModElement.mm:
3963         * DOM/DOMHTMLOListElement.mm:
3964         * DOM/DOMHTMLObjectElement.mm:
3965         * DOM/DOMHTMLOptGroupElement.mm:
3966         * DOM/DOMHTMLOptionElement.mm:
3967         * DOM/DOMHTMLOptionsCollection.mm:
3968         * DOM/DOMHTMLParagraphElement.mm:
3969         * DOM/DOMHTMLParamElement.mm:
3970         * DOM/DOMHTMLPreElement.mm:
3971         * DOM/DOMHTMLQuoteElement.mm:
3972         * DOM/DOMHTMLScriptElement.mm:
3973         * DOM/DOMHTMLSelectElement.mm:
3974         * DOM/DOMHTMLStyleElement.mm:
3975         * DOM/DOMHTMLTableCaptionElement.mm:
3976         * DOM/DOMHTMLTableCellElement.mm:
3977         * DOM/DOMHTMLTableColElement.mm:
3978         * DOM/DOMHTMLTableElement.mm:
3979         * DOM/DOMHTMLTableRowElement.mm:
3980         * DOM/DOMHTMLTableSectionElement.mm:
3981         * DOM/DOMHTMLTextAreaElement.mm:
3982         * DOM/DOMHTMLTitleElement.mm:
3983         * DOM/DOMHTMLUListElement.mm:
3984         * DOM/DOMHTMLVideoElement.mm:
3985         * DOM/DOMImplementation.mm:
3986         * DOM/DOMKeyboardEvent.mm:
3987         * DOM/DOMMediaError.mm:
3988         * DOM/DOMMediaList.mm:
3989         * DOM/DOMMouseEvent.mm:
3990         * DOM/DOMMutationEvent.mm:
3991         * DOM/DOMNamedNodeMap.mm:
3992         * DOM/DOMNode.mm:
3993         * DOM/DOMNodeIterator.mm:
3994         * DOM/DOMNodeList.mm:
3995         * DOM/DOMOverflowEvent.mm:
3996         * DOM/DOMProcessingInstruction.mm:
3997         * DOM/DOMProgressEvent.mm:
3998         * DOM/DOMRGBColor.mm:
3999         * DOM/DOMRange.mm:
4000         * DOM/DOMRect.mm:
4001         * DOM/DOMStyleSheet.mm:
4002         * DOM/DOMStyleSheetList.mm:
4003         * DOM/DOMText.mm:
4004         * DOM/DOMTextEvent.mm:
4005         * DOM/DOMTimeRanges.mm:
4006         * DOM/DOMTokenList.mm:
4007         * DOM/DOMTreeWalker.mm:
4008         * DOM/DOMUIEvent.mm:
4009         * DOM/DOMWheelEvent.mm:
4010         * DOM/DOMXPathExpression.mm:
4011         * DOM/DOMXPathResult.mm:
4012         * DOM/ObjCEventListener.mm:
4013
4014 2018-08-03  Alex Christensen  <achristensen@webkit.org>
4015
4016         Fix spelling of "overridden"
4017         https://bugs.webkit.org/show_bug.cgi?id=188315
4018
4019         Reviewed by Darin Adler.
4020
4021         * Misc/WebKitVersionChecks.mm:
4022         (setWebKitLinkTimeVersion):
4023         (WebKitLinkTimeVersion):
4024         * Plugins/WebBaseNetscapePluginView.mm:
4025         (-[WebBaseNetscapePluginView handleMouseMoved:]):
4026         * WebCoreSupport/PopupMenuMac.mm:
4027         (PopupMenuMac::populate):
4028
4029 2018-08-01  Nan Wang  <n_wang@apple.com>
4030
4031         AX: AOM: Add ARIA IDL Attribute Reflection
4032         https://bugs.webkit.org/show_bug.cgi?id=184676
4033         <rdar://problem/39476882>
4034
4035         Reviewed by Chris Fleizach.
4036
4037         * WebView/WebPreferenceKeysPrivate.h:
4038         * WebView/WebPreferences.mm:
4039         (+[WebPreferences initialize]):
4040         (-[WebPreferences ariaReflectionEnabled]):
4041         (-[WebPreferences setAriaReflectionEnabled:]):
4042         * WebView/WebPreferencesPrivate.h:
4043         * WebView/WebView.mm:
4044         (-[WebView _preferencesChanged:]):
4045
4046 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
4047
4048         Shrink GraphicsLayerCA
4049         https://bugs.webkit.org/show_bug.cgi?id=188141
4050
4051         Reviewed by Zalan Bujtas.
4052
4053