Allow encoding of small enum classes
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2
3         Allow encoding of small enum classes
4         https://bugs.webkit.org/show_bug.cgi?id=190531
5
6         Reviewed by Tim Horton.
7
8         * WebCoreSupport/WebFrameLoaderClient.mm:
9         (-[WebFramePolicyListener dealloc]):
10
11 2018-10-11  Keith Rollin  <krollin@apple.com>
12
13         CURRENT_ARCH should not be used in Run Script phase.
14         https://bugs.webkit.org/show_bug.cgi?id=190407
15         <rdar://problem/45133556>
16
17         Reviewed by Alexey Proskuryakov.
18
19         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
20         CURRENT_ARCH is not well-defined during this phase (and may even have
21         the value "undefined") since this phase is run just once per build
22         rather than once per supported architecture. Migrate away from
23         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
24         performing an operation for each value, or by picking the first entry
25         in ARCHS and using that as a representative value.
26
27         * Configurations/WebKitLegacy.xcconfig: When generating
28         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
29         macosx platforms.
30
31         * MigrateHeaders.make:
32         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
33         generate one for each architecture in ARCHS.
34
35 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
36
37         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
38         https://bugs.webkit.org/show_bug.cgi?id=190429
39
40         Reviewed by Saam Barati.
41
42         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
43
44         * WebView/WebPDFRepresentation.mm:
45         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
46
47 2018-10-08  Justin Fan  <justin_fan@apple.com>
48
49         WebGPU: Rename old WebGPU prototype to WebMetal
50         https://bugs.webkit.org/show_bug.cgi?id=190325
51         <rdar://problem/44990443>
52
53         Reviewed by Dean Jackson.
54
55         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
56
57         * Configurations/FeatureDefines.xcconfig:
58         * WebView/WebPreferenceKeysPrivate.h:
59         * WebView/WebPreferences.mm:
60         (+[WebPreferences initialize]):
61         (-[WebPreferences webMetalEnabled]):
62         (-[WebPreferences setWebMetalEnabled:]):
63         (-[WebPreferences webGPUEnabled]): Deleted.
64         (-[WebPreferences setWebGPUEnabled:]): Deleted.
65         * WebView/WebPreferencesPrivate.h:
66         * WebView/WebView.mm:
67         (-[WebView _preferencesChanged:]):
68
69 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
70
71         Make <input type=color> a runtime enabled (on-by-default) feature
72         https://bugs.webkit.org/show_bug.cgi?id=189162
73
74         Reviewed by Wenson Hsieh and Tim Horton.
75
76         * Configurations/FeatureDefines.xcconfig:
77
78 2018-10-07  Dan Bernstein  <mitz@apple.com>
79
80         Fixed building with the latest macOS SDK
81
82         * Plugins/WebNetscapePluginPackage.mm:
83         (-[WebNetscapePluginPackage openResourceFile]):
84         (-[WebNetscapePluginPackage closeResourceFile:]):
85
86 2018-10-04  Dan Bernstein  <mitz@apple.com>
87
88         More Carbon build-fixing.
89
90         * Carbon/CarbonWindowAdapter.mm:
91         (-[CarbonWindowAdapter _destroyRealWindow:]):
92         (-[CarbonWindowAdapter _growBoxRect]):
93
94 2018-10-04  Dan Bernstein  <mitz@apple.com>
95
96         Retried to fix 32-bit macOS builds after r236846.
97
98         * WebView/WebHTMLView.mm:
99         (-[WebHTMLView setMarkedText:selectedRange:]):
100
101 2018-10-04  Dan Bernstein  <mitz@apple.com>
102
103         Retried to fix 32-bit macOS builds after r236846.
104
105         * Carbon/HIWebView.mm:
106         (ActiveStateChanged):
107
108 2018-10-04  Dan Bernstein  <mitz@apple.com>
109
110         Tried to fix 32-bit macOS builds after r236846.
111
112         * Carbon/HIWebView.mm:
113         (_NSSelectorForHICommand):
114
115 2018-10-04  Dan Bernstein  <mitz@apple.com>
116
117         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
118         https://bugs.webkit.org/show_bug.cgi?id=190250
119
120         Reviewed by Andy Estes.
121
122         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
123           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
124           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
125           an earlier line set it to YES.
126
127         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
128         changes below.
129
130         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
131           provides some missing method declarations.
132
133         * Misc/WebDownload.mm:
134         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
135           a deprecated method.
136
137         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
138
139         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
140           other code in the file uses a method from it.
141
142         * Plugins/WebBaseNetscapePluginView.mm:
143         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
144           a deprecated method.
145
146         * Plugins/WebPluginController.mm:
147         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
148           around use of a selector that may be present in some WebKit client.
149
150         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
151           method declarations.
152
153         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
154           from here.
155
156         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
157           missing method declarations.
158
159         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
160           from here.
161
162         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
163           call from here.
164         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
165           an obsolete delegate method for binary compatibility.
166         (pluginView): Ditto.
167
168         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
169           call from here.
170
171         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
172           WebDeviceOrientationProviderMock protocol.
173
174         * WebView/WebDeviceOrientationProviderMock.mm:
175         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
176           main @implementation.
177
178         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
179           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
180
181         * WebView/WebDynamicScrollBarsView.mm:
182         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
183           of a deprecated method.
184
185         * WebView/WebHTMLView.mm:
186         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
187           selector warning around action methods that are not declared anywhere in WebKit.
188
189         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
190           about implementing this deprecated method.
191         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
192         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
193         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
194         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
195         (-[WebHTMLView characterIndexForPoint:]): Ditto.
196         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
197         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
198         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
199         (-[WebHTMLView doCommandBySelector:]): Ditto.
200         (-[WebHTMLView insertText:]): Ditto.
201
202         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
203
204         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
205
206         * WebView/WebPDFView.h: Removed previewView ivar.
207
208         * WebView/WebPDFView.mm:
209           Removed declaration of FileInternal category and merged its implementation with the main
210           implementation.
211         (-[WebPDFView dealloc]): Removed previewView ivar.
212         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
213           exist in macOS versions we support.
214         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
215         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
216           action methods internal to PDFKit.
217         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
218         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
219
220         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
221           call on macOS, even though in r86988 we started calling different methods on iOS.
222
223         * WebView/WebView.mm:
224         - Imported headers that declare delegate methods that we call.
225         - Removed declaration of WebFileInternal category and merged its implementation with the
226           main implementation.
227         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
228           category, which made them impossible to call from the main implementation. Moved those
229           into the main implementation. One of those had to be declared in a class extension,
230           because it is called from a method implemented in the WebPrivate category, and that
231           category’s implementation appears first in the file.
232
233         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
234           around use of obsolete delegate method for binary compatibility.
235
236         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
237
238 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
239
240         Runtime flag and IDL for MediaRecorder
241         https://bugs.webkit.org/show_bug.cgi?id=190018
242
243         Reviewed by Youenn Fablet and Chris Dumez.
244
245         * WebView/WebPreferenceKeysPrivate.h:
246         * WebView/WebPreferences.mm:
247         (+[WebPreferences initialize]):
248         (-[WebPreferences mediaRecorderEnabled]):
249         (-[WebPreferences setMediaRecorderEnabled:]):
250         * WebView/WebPreferencesPrivate.h:
251         * WebView/WebView.mm:
252         (-[WebView _preferencesChanged:]):
253
254 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
255
256         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
257         https://bugs.webkit.org/show_bug.cgi?id=190238
258
259         Reviewed by Antti Koivisto.
260
261         Enabled the feature by default.
262
263         * WebView/WebPreferences.mm:
264         (+[WebPreferences initialize]):
265
266 2018-10-01  Dean Jackson  <dino@apple.com>
267
268         [macOS] Switching to discrete GPU should be done in the UI process
269         https://bugs.webkit.org/show_bug.cgi?id=189361
270         <rdar://problem/43949622>
271
272         Reviewed by Simon Fraser.
273
274         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
275         not support swapping to the discrete GPU in this configuration.
276
277         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
278         (WebKit::WebSwitchingGPUClient::singleton):
279         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
280         * WebView/WebView.mm:
281         (-[WebView _commonInitializationWithFrameName:groupName:]):
282
283 2018-10-02  Alex Christensen  <achristensen@webkit.org>
284
285         Remove ParsedURLString
286         https://bugs.webkit.org/show_bug.cgi?id=190154
287
288         Reviewed by Chris Dumez.
289
290         * WebView/WebScriptDebugger.mm:
291         (toNSURL):
292
293 2018-10-01  Dean Jackson  <dino@apple.com>
294
295         Remove CSS Animation Triggers
296         https://bugs.webkit.org/show_bug.cgi?id=190175
297         <rdar://problem/44925626>
298
299         Reviewed by Simon Fraser.
300
301         * Configurations/FeatureDefines.xcconfig:
302
303 2018-10-02  Commit Queue  <commit-queue@webkit.org>
304
305         Unreviewed, rolling out r236624 and r236671.
306         https://bugs.webkit.org/show_bug.cgi?id=190207
307
308         The change in r236624 introduced crashes on the bots
309         (Requested by ryanhaddad on #webkit).
310
311         Reverted changesets:
312
313         "Refactoring: eliminate raw pointer usage in Fullscreen code"
314         https://bugs.webkit.org/show_bug.cgi?id=188747
315         https://trac.webkit.org/changeset/236624
316
317         "Unify implementation in VideoFullscreenInterfaceAVKit"
318         https://bugs.webkit.org/show_bug.cgi?id=190091
319         https://trac.webkit.org/changeset/236671
320
321 2018-10-01  Alex Christensen  <achristensen@webkit.org>
322
323         URL should not use TextEncoding internally
324         https://bugs.webkit.org/show_bug.cgi?id=190111
325
326         Reviewed by Andy Estes.
327
328         * Misc/WebNSURLExtras.mm:
329
330 2018-09-28  Jer Noble  <jer.noble@apple.com>
331
332         Refactoring: eliminate raw pointer usage in Fullscreen code
333         https://bugs.webkit.org/show_bug.cgi?id=188747
334         <rdar://problem/43541164>
335
336         Reviewed by Alex Christensen.
337
338         PlaybackSessionInterface no longer has an invalidate() method.
339
340         * WebView/WebView.mm:
341         (-[WebView _clearPlaybackControlsManager]):
342
343 2018-09-28  Chris Dumez  <cdumez@apple.com>
344
345         Drop support for cross-origin-window-policy header
346         https://bugs.webkit.org/show_bug.cgi?id=190081
347
348         Reviewed by Ryosuke Niwa.
349
350         * WebView/WebPreferenceKeysPrivate.h:
351         * WebView/WebPreferences.mm:
352         (+[WebPreferences initialize]):
353         * WebView/WebPreferencesPrivate.h:
354         * WebView/WebView.mm:
355         (-[WebView _preferencesChanged:]):
356
357 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
358
359         Rename createMarkup to serializePreservingVisualAppearance
360         https://bugs.webkit.org/show_bug.cgi?id=190086
361
362         Reviewed by Wenson Hsieh.
363
364         * DOM/WebDOMOperations.mm:
365         (-[DOMRange markupString]):
366
367 2018-09-28  Commit Queue  <commit-queue@webkit.org>
368
369         Unreviewed, rolling out r236605.
370         https://bugs.webkit.org/show_bug.cgi?id=190087
371
372         caused three API test timeouts (Requested by jernoble on
373         #webkit).
374
375         Reverted changeset:
376
377         "Refactoring: eliminate raw pointer usage in Fullscreen code"
378         https://bugs.webkit.org/show_bug.cgi?id=188747
379         https://trac.webkit.org/changeset/236605
380
381 2018-09-28  Jer Noble  <jer.noble@apple.com>
382
383         Refactoring: eliminate raw pointer usage in Fullscreen code
384         https://bugs.webkit.org/show_bug.cgi?id=188747
385         <rdar://problem/43541164>
386
387         Reviewed by Alex Christensen.
388
389         PlaybackSessionInterface no longer has an invalidate() method.
390
391         * WebView/WebView.mm:
392         (-[WebView _clearPlaybackControlsManager]):
393
394 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
395
396         Use enum class in createMarkup arguments
397         https://bugs.webkit.org/show_bug.cgi?id=190028
398
399         Reviewed by Wenson Hsieh.
400
401         * DOM/WebDOMOperations.mm:
402         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
403         (-[DOMRange markupString]): Ditto.
404
405 2018-09-27  Antoine Quint  <graouts@apple.com>
406
407         [Web Animations] Turn Web Animations with CSS integration on
408         https://bugs.webkit.org/show_bug.cgi?id=184819
409         <rdar://problem/39597337>
410
411         Reviewed by Dean Jackson.
412
413         * WebView/WebPreferences.mm:
414         (+[WebPreferences initialize]):
415
416 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
417
418         Selection should work across shadow boundary when initiated by a mouse drag
419         https://bugs.webkit.org/show_bug.cgi?id=151380
420         <rdar://problem/24363872>
421
422         Reviewed by Wenson Hsieh.
423
424         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
425
426         * WebView/WebPreferenceKeysPrivate.h:
427         * WebView/WebPreferences.mm:
428         (+[WebPreferences initialize]):
429         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
430         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
431         * WebView/WebPreferencesPrivate.h:
432         * WebView/WebView.mm:
433         (-[WebView _preferencesChanged:]):
434
435 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
436
437         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
438         https://bugs.webkit.org/show_bug.cgi?id=189918
439         Work towards <rdar://problem/44648705>
440
441         Reviewed by Tim Horton.
442
443         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
444
445         * WebView/WebHTMLView.mm:
446         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
447         (-[WebHTMLView _updateFontPanel]):
448         * WebView/WebView.mm:
449         (-[WebView typingAttributes]):
450
451 2018-09-17  Darin Adler  <darin@apple.com>
452
453         Use OpaqueJSString rather than JSRetainPtr inside WebKit
454         https://bugs.webkit.org/show_bug.cgi?id=189652
455
456         Reviewed by Saam Barati.
457
458         * WebView/WebPDFRepresentation.mm:
459         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
460
461 2018-09-14  Jer Noble  <jer.noble@apple.com>
462
463         Turn SourceBufferChangeTypeEnabled on by default
464         https://bugs.webkit.org/show_bug.cgi?id=189527
465
466         Reviewed by Eric Carlson.
467
468         * WebView/WebPreferences.mm:
469         (+[WebPreferences initialize]):
470
471 2018-09-12  Alex Christensen  <achristensen@webkit.org>
472
473         Fix an internal build after r235935
474         https://bugs.webkit.org/show_bug.cgi?id=188996
475
476         * Carbon/HIWebView.mm:
477         (Draw):
478         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
479
480 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
481
482         Add IGNORE_WARNING_.* macros
483         https://bugs.webkit.org/show_bug.cgi?id=188996
484
485         Reviewed by Michael Catanzaro.
486
487         * Carbon/CarbonUtils.m:
488         (PoolCleaner):
489         * Carbon/CarbonWindowAdapter.mm:
490         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
491         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
492         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
493         (-[CarbonWindowAdapter _termWindowIfOwner]):
494         (-[CarbonWindowAdapter _windowMovedToRect:]):
495         (-[CarbonWindowAdapter setContentView:]):
496         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
497         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
498         * Carbon/CarbonWindowFrame.m:
499         (-[CarbonWindowFrame title]):
500         * Carbon/HIViewAdapter.m:
501         (+[HIViewAdapter getHIViewForNSView:]):
502         * Carbon/HIWebView.mm:
503         (overrideCGContext):
504         (restoreCGContext):
505         (Draw):
506         * DOM/DOM.mm:
507         * History/WebHistory.mm:
508         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
509         * History/WebHistoryItem.mm:
510         (-[WebHistoryItem icon]):
511         * Misc/WebKitNSStringExtras.mm:
512         (-[NSString _web_drawAtPoint:font:textColor:]):
513         * Misc/WebNSImageExtras.m:
514         (-[NSImage _web_scaleToMaxSize:]):
515         (-[NSImage _web_dissolveToFraction:]):
516         * Misc/WebNSPasteboardExtras.mm:
517         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
518         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
519         * Panels/WebAuthenticationPanel.m:
520         (-[WebAuthenticationPanel loadNib]):
521         * Plugins/Hosted/NetscapePluginHostManager.mm:
522         (WebKit::NetscapePluginHostManager::spawnPluginHost):
523         (WebKit::NetscapePluginHostManager::didCreateWindow):
524         * Plugins/Hosted/NetscapePluginHostProxy.mm:
525         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
526         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
527         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
528         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
529         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
530         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
531         (-[WebHostedNetscapePluginView drawRect:]):
532         * Plugins/Hosted/WebTextInputWindowController.m:
533         (-[WebTextInputPanel _interpretKeyEvent:string:]):
534         * Plugins/WebBaseNetscapePluginView.mm:
535         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
536         * Plugins/WebNetscapePluginPackage.mm:
537         (-[WebNetscapePluginPackage _tryLoad]):
538         * Plugins/WebNetscapePluginView.mm:
539         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
540         (-[WebNetscapePluginView sendDrawRectEvent:]):
541         (-[WebNetscapePluginView drawRect:]):
542         * Plugins/WebPluginController.mm:
543         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
544         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
545         * WebCoreSupport/PopupMenuMac.mm:
546         (PopupMenuMac::populate):
547         * WebCoreSupport/WebAlternativeTextClient.h:
548         * WebCoreSupport/WebDragClient.mm:
549         (WebDragClient::startDrag):
550         * WebCoreSupport/WebFrameLoaderClient.mm:
551         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
552         (webGetNSImage):
553         * WebInspector/WebNodeHighlight.mm:
554         * WebInspector/WebNodeHighlightView.mm:
555         (-[WebNodeHighlightView drawRect:]):
556         * WebView/WebClipView.mm:
557         (-[WebClipView initWithFrame:]):
558         * WebView/WebFrame.mm:
559         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
560         (-[WebFrame _drawRect:contentsOnly:]):
561         (-[WebFrame accessibilityRoot]):
562         * WebView/WebFullScreenController.mm:
563         (-[WebFullScreenController enterFullScreen:]):
564         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
565         (-[WebFullScreenController exitFullScreen]):
566         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
567         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
568         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
569         * WebView/WebHTMLView.mm:
570         (-[NSWindow _web_borderView]):
571         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
572         (-[WebHTMLView _setAsideSubviews]):
573         (-[WebHTMLView _autoscroll]):
574         (-[WebHTMLView drawRect:]):
575         (-[WebHTMLView mouseDown:]):
576         (-[WebHTMLView mouseDragged:]):
577         (-[WebHTMLView mouseUp:]):
578         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
579         (-[WebHTMLView knowsPageRange:]):
580         (-[WebHTMLView accessibilityHitTest:]):
581         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
582         (-[WebHTMLView _colorAsString:]):
583         (-[WebHTMLView copyFont:]):
584         (-[WebHTMLView _executeSavedKeypressCommands]):
585         (-[WebHTMLView attachRootLayer:]):
586         (-[WebHTMLView textStorage]):
587         (-[WebHTMLView _updateSelectionForInputManager]):
588         * WebView/WebPDFView.mm:
589         (_applicationInfoForMIMEType):
590         (-[WebPDFView centerSelectionInVisibleArea:]):
591         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
592         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
593         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
594         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
595         * WebView/WebTextCompletionController.mm:
596         (-[WebTextCompletionController _buildUI]):
597         (-[WebTextCompletionController _placePopupWindow:]):
598         * WebView/WebVideoFullscreenController.mm:
599         * WebView/WebVideoFullscreenHUDWindowController.mm:
600         (createMediaUIBackgroundView):
601         * WebView/WebView.mm:
602         (-[WebTextListTouchBarViewController initWithWebView:]):
603         (-[WebView _dispatchTileDidDraw:]):
604         (-[WebView encodeWithCoder:]):
605         (-[WebView mainFrameIcon]):
606         (LayerFlushController::flushLayers):
607         * WebView/WebWindowAnimation.mm:
608         (setScaledFrameForWindow):
609
610 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
611
612         Remove unused needsDestruction class variables from HashTraits
613         https://bugs.webkit.org/show_bug.cgi?id=189490
614
615         Reviewed by Daniel Bates.
616
617         * History/BinaryPropertyList.cpp: Removed needsDestruction.
618
619 2018-09-07  Frederic Wang  <fwang@igalia.com>
620
621         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
622         https://bugs.webkit.org/show_bug.cgi?id=182230
623
624         Reviewed by Simon Fraser.
625
626         * DOM/DOMDocument.mm:
627         (-[DOMDocument scrollingElement]): Use the new name.
628
629 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
630
631         Refactor WebCore::EditAction to be an 8-bit enum class
632         https://bugs.webkit.org/show_bug.cgi?id=189383
633
634         Reviewed by Dan Bernstein.
635
636         * WebCoreSupport/WebEditorClient.mm:
637         (undoNameForEditAction):
638         * WebView/WebHTMLView.mm:
639         (-[WebHTMLView pasteFont:]):
640         (-[WebHTMLView changeFont:]):
641         (-[WebHTMLView changeAttributes:]):
642         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
643         (-[WebHTMLView changeColor:]):
644         * WebView/WebView.mm:
645         (-[WebView setTypingStyle:]):
646
647 2018-09-06  Frederic Wang  <fwang@igalia.com>
648
649         Group options of scrollRectToVisible into a struct
650         https://bugs.webkit.org/show_bug.cgi?id=189352
651
652         Reviewed by Simon Fraser.
653
654         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
655         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
656         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
657
658 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
659
660         [macOS] Cannot change font size at selection until font panel is shown
661         https://bugs.webkit.org/show_bug.cgi?id=189295
662         <rdar://problem/35593389>
663
664         Reviewed by Ryosuke Niwa.
665
666         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
667         WebCore ChangeLog for more details.
668
669         * WebView/WebHTMLView.mm:
670         (-[WebHTMLView changeFont:]):
671         (-[WebHTMLView changeAttributes:]):
672         (-[WebHTMLView _originalFontA]): Deleted.
673         (-[WebHTMLView _originalFontB]): Deleted.
674         (fontNameForDescription): Deleted.
675         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
676         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
677         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
678
679 2018-09-05  Jer Noble  <jer.noble@apple.com>
680
681         Add MediaCapabilities as an Experimental Feature
682         https://bugs.webkit.org/show_bug.cgi?id=189209
683
684         Reviewed by Eric Carlson.
685
686         RuntimeEnabledFeature -> Setting.
687
688         * WebView/WebView.mm:
689         (-[WebView _preferencesChanged:]):
690
691 2018-09-04  Frederic Wang  <fwang@igalia.com>
692
693         Add basic support for ScrollIntoViewOptions
694         https://bugs.webkit.org/show_bug.cgi?id=189258
695
696         Reviewed by Simon Fraser.
697
698         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
699         header so that this file can build despite the new scrollIntoView function.
700
701 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
702
703         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
704         https://bugs.webkit.org/show_bug.cgi?id=188890
705         <rdar://problem/43648605>
706
707         Reviewed by Tim Horton.
708
709         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
710         more detail.
711
712         * WebCoreSupport/WebPlatformStrategies.h:
713         * WebCoreSupport/WebPlatformStrategies.mm:
714         (WebPlatformStrategies::allStringsForType):
715
716 2018-09-01  Darin Adler  <darin@apple.com>
717
718         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
719         https://bugs.webkit.org/show_bug.cgi?id=189072
720         Reviewed by Dan Bernstein.
721
722         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
723         and declarations for NSURLDownload init methods.
724
725         * Misc/WebDownloadInternal.h: Removed.
726
727         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
728         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
729         "-Wdeprecated-declarations" because the method used here is deprecated.
730
731         * WebView/WebView.mm:
732         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
733         used here is deprecated.
734
735 2018-08-31  Chris Dumez  <cdumez@apple.com>
736
737         Assertion hit in ~CompletionHandler() from ~WebFrame()
738         https://bugs.webkit.org/show_bug.cgi?id=189199
739         <rdar://problem/42657233>
740
741         Reviewed by Youenn Fablet.
742
743         * WebCoreSupport/WebFrameLoaderClient.h:
744         * WebCoreSupport/WebFrameLoaderClient.mm:
745         (WebFrameLoaderClient::dispatchWillSubmitForm):
746
747 2018-08-31  Antti Koivisto  <antti@apple.com>
748
749         Replace OptionSet |= and -= operators with add() and remove() functions
750         https://bugs.webkit.org/show_bug.cgi?id=189169
751
752         Reviewed by Anders Carlsson.
753
754         * WebView/WebFrame.mm:
755         (-[WebFrame _drawRect:contentsOnly:]):
756         * WebView/WebView.mm:
757         (coreOptions):
758
759 2018-08-31  Frederic Wang  <fwang@igalia.com>
760
761         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
762         https://bugs.webkit.org/show_bug.cgi?id=182053
763
764         Reviewed by Simon Fraser.
765
766         Add developer flag to use standard behavior for scrolling* attributes.
767
768         * WebView/WebPreferenceKeysPrivate.h:
769         * WebView/WebPreferences.mm:
770         (+[WebPreferences initialize]):
771         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
772         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
773         * WebView/WebPreferencesPrivate.h:
774         * WebView/WebView.mm:
775         (-[WebView _preferencesChanged:]):
776
777 2018-08-29  Olivia Barnett  <obarnett@apple.com>
778
779         Implement the Web Share API
780         https://bugs.webkit.org/show_bug.cgi?id=171100
781         <rdar://problem/31751734>
782
783         Reviewed by Tim Horton.
784
785         * WebCoreSupport/WebChromeClient.h:
786         * WebCoreSupport/WebChromeClient.mm:
787         (WebChromeClient::showShareSheet):
788         Empty declaration of showShareSheet.
789
790 2018-08-29  Youenn Fablet  <youenn@apple.com>
791
792         Remove WebRTC legacy API implementation
793         https://bugs.webkit.org/show_bug.cgi?id=189040
794
795         Reviewed by Eric Carlson.
796
797         * WebView/WebPreferenceKeysPrivate.h:
798         * WebView/WebPreferences.mm:
799         (+[WebPreferences initialize]):
800         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
801         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
802         * WebView/WebPreferencesPrivate.h:
803         * WebView/WebView.mm:
804         (-[WebView _preferencesChanged:]):
805
806 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
807
808         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
809         https://bugs.webkit.org/show_bug.cgi?id=189054
810
811         Reviewed by Andy Estes.
812
813         Remove the pasteboard type argument from readURLFromPasteboard.
814
815         * WebCoreSupport/WebPlatformStrategies.h:
816         * WebCoreSupport/WebPlatformStrategies.mm:
817         (WebPlatformStrategies::readURLFromPasteboard):
818
819 2018-08-27  Keith Rollin  <krollin@apple.com>
820
821         Unreviewed build fix -- disable LTO for production builds
822
823         * Configurations/Base.xcconfig:
824
825 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
826
827         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
828         https://bugs.webkit.org/show_bug.cgi?id=188931
829
830         Reviewed by Wenson Hsieh.
831
832         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
833
834 2018-08-27  Keith Rollin  <krollin@apple.com>
835
836         Build system support for LTO
837         https://bugs.webkit.org/show_bug.cgi?id=187785
838         <rdar://problem/42353132>
839
840         Reviewed by Dan Bernstein.
841
842         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
843         LTO.
844
845         * Configurations/Base.xcconfig:
846         * Configurations/DebugRelease.xcconfig:
847
848 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
849
850         Pass in IsComposed flag to Event constructors
851         https://bugs.webkit.org/show_bug.cgi?id=188720
852         <rdar://problem/43580387>
853
854         Reviewed by Simon Fraser.
855
856         * WebView/WebPDFView.mm:
857         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
858         whether it's simulated or not.
859
860 2018-08-23  Mark Lam  <mark.lam@apple.com>
861
862         Move vmEntryGlobalObject() to VM from CallFrame.
863         https://bugs.webkit.org/show_bug.cgi?id=188900
864         <rdar://problem/43655753>
865
866         Reviewed by Michael Saboff.
867
868         * WebView/WebScriptDebugger.mm:
869         (WebScriptDebugger::sourceParsed):
870
871 2018-08-23  Andy Estes  <aestes@apple.com>
872
873         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
874         https://bugs.webkit.org/show_bug.cgi?id=188829
875
876         Reviewed by Tim Horton.
877
878         * Configurations/FeatureDefines.xcconfig:
879
880 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
881
882         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
883         https://bugs.webkit.org/show_bug.cgi?id=188777
884
885         Reviewed by Simon Fraser.
886
887         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
888         being "true" before the code change.
889
890         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
891
892         * WebView/WebPDFView.mm:
893         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
894
895 2018-08-21  Daniel Bates  <dabates@apple.com>
896
897         Replace TextCheckingTypeMask with OptionSet
898         https://bugs.webkit.org/show_bug.cgi?id=188678
899
900         Reviewed by Antti Koivisto.
901
902         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
903         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
904         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
905         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
906
907         * WebCoreSupport/WebEditorClient.h:
908         * WebCoreSupport/WebEditorClient.mm:
909         (WebEditorClient::checkTextOfParagraph):
910         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
911         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
912         left as this is more readable and unncessary now that modern compilers like Clang have
913         diagnostics to catch accidental assignments when equality was intended.
914         (WebEditorClient::didCheckSucceed):
915         * WebView/WebView.mm:
916         (coreTextCheckingType):
917         (textCheckingResultFromNSTextCheckingResult):
918
919 2018-08-21  Daniel Bates  <dabates@apple.com>
920
921         [iOS][WK1] Support toggling continuous spell checking from tests
922         https://bugs.webkit.org/show_bug.cgi?id=188763
923
924         Reviewed by Simon Fraser.
925
926         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
927         spell checking from tests in iOS WebKit Legacy.
928
929         * WebCoreSupport/WebEditorClient.h:
930         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
931         * WebCoreSupport/WebEditorClient.mm:
932         * WebView/WebView.h:
933         * WebView/WebView.mm:
934         (-[WebView toggleContinuousSpellChecking:]):
935         (-[WebView toggleSmartInsertDelete:]):
936
937 2018-08-17  Alex Christensen  <achristensen@webkit.org>
938
939         Add some plumbing for safe browsing
940         https://bugs.webkit.org/show_bug.cgi?id=188709
941
942         Reviewed by Tim Horton.
943
944         * WebCoreSupport/WebFrameLoaderClient.h:
945         * WebCoreSupport/WebFrameLoaderClient.mm:
946         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
947
948 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
949
950         Replace canBubble and cancelable booleans in Event by enum classes
951         https://bugs.webkit.org/show_bug.cgi?id=188692
952
953         Reviewed by Alex Christensen.
954
955         * WebView/WebPDFView.mm:
956         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
957         * WebView/WebView.mm:
958         (-[WebView _dispatchUnloadEvent]):
959
960 2018-08-16  Jer Noble  <jer.noble@apple.com>
961
962         Add Experimental Feature support for SourceBuffer.changeType()
963         https://bugs.webkit.org/show_bug.cgi?id=188626
964         <rdar://problem/43356021>
965
966         Reviewed by Eric Carlson.
967
968         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
969
970         * WebView/WebPreferenceKeysPrivate.h:
971         * WebView/WebPreferences.mm:
972         (+[WebPreferences initialize]):
973         (-[WebPreferences sourceBufferChangeTypeEnabled]):
974         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
975         * WebView/WebPreferencesPrivate.h:
976         * WebView/WebView.mm:
977         (-[WebView _preferencesChanged:]):
978
979 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
980
981         Support drag-and-drop for input[type=color]
982         https://bugs.webkit.org/show_bug.cgi?id=188464
983
984         Reviewed by Wenson Hsieh.
985
986         * WebCoreSupport/WebPlatformStrategies.h:
987         * WebCoreSupport/WebPlatformStrategies.mm:
988         (WebPlatformStrategies::setColor):
989
990 2018-08-15  Tim Horton  <timothy_horton@apple.com>
991
992         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
993         https://bugs.webkit.org/show_bug.cgi?id=188569
994         <rdar://problem/34201095>
995
996         Reviewed by Megan Gardner.
997
998         * WebView/WebImmediateActionController.mm:
999         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1000         Speculative fix; the crashes indicate font is null, but we just checked it,
1001         so it must be getting made null by convertFont:toSize:. Check again!
1002
1003 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1004
1005         Use a 1-byte enum class for TextDirection
1006         https://bugs.webkit.org/show_bug.cgi?id=188350
1007
1008         Reviewed by Simon Fraser.
1009
1010         * WebCoreSupport/PopupMenuMac.mm:
1011         (PopupMenuMac::populate):
1012         (PopupMenuMac::show):
1013         * WebCoreSupport/WebFrameLoaderClient.mm:
1014         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1015         * WebView/WebFrame.mm:
1016         (-[WebFrame _dispatchDidReceiveTitle:]):
1017
1018 2018-08-09  Ali Juma  <ajuma@chromium.org>
1019
1020         Import WPTs for IntersectionObserver
1021         https://bugs.webkit.org/show_bug.cgi?id=188416
1022
1023         Reviewed by Simon Fraser.
1024
1025         * WebView/WebPreferencesPrivate.h:
1026
1027 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1028
1029         Follow-up build fix for r234685
1030         https://bugs.webkit.org/show_bug.cgi?id=188245
1031
1032         Unreviewed build fix.
1033
1034         * WebCoreSupport/WebSecurityOriginPrivate.h:
1035
1036 2018-08-05  Darin Adler  <darin@apple.com>
1037
1038         [Cocoa] More tweaks and refactoring to prepare for ARC
1039         https://bugs.webkit.org/show_bug.cgi?id=188245
1040
1041         Reviewed by Dan Bernstein.
1042
1043         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1044
1045         * Carbon/CarbonWindowFrame.m:
1046         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1047
1048         * DOM/DOM.mm:
1049         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1050         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1051         garbage collection so this method isn't useful.
1052
1053         * DOM/DOMXPath.mm:
1054         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1055         Objective-C garbage collection so this method isn't useful.
1056
1057         * History/WebHistory.mm:
1058         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1059
1060         * Misc/WebElementDictionary.mm:
1061         (addLookupKey): Use a bridging cast.
1062         (cacheValueForKey): Ditto.
1063         (-[WebElementDictionary _fillCache]): Ditto.
1064         (-[WebElementDictionary objectForKey:]): Ditto.
1065
1066         * Misc/WebKitNSStringExtras.mm:
1067         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1068         (-[NSString _web_widthWithFont:]): Ditto.
1069         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1070
1071         * Misc/WebLocalizableStrings.mm:
1072         (WebLocalizedString): Use a bridging cast.
1073
1074         * Misc/WebNSDataExtras.mm:
1075         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1076         and use CFBridgingRelease instead of calling autorelease directly.
1077         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1078         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1079         on the amount of explicit release and autorelease.
1080
1081         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1082         * Misc/WebNSDictionaryExtras.m:
1083         (-[NSDictionary _webkit_intForKey:]): Deleted.
1084         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1085         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1086         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1087         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1088         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1089         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1090
1091         * Misc/WebStringTruncator.mm:
1092         (fontFromNSFont): Use a bridging cast.
1093
1094         * Plugins/Hosted/NetscapePluginHostManager.mm:
1095         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1096
1097         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1098         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1099         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1100         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1101         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1102         * Plugins/Hosted/ProxyInstance.mm:
1103         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1104         * Plugins/WebBasePluginPackage.mm:
1105         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1106         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1107         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1108         * Plugins/WebNetscapePluginPackage.mm:
1109         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1110
1111         * Plugins/WebNetscapePluginView.mm:
1112         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1113         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1114         (-[WebNetscapePluginView status:]): Use a bridging cast.
1115         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1116
1117         * Plugins/WebPluginController.mm:
1118         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1119
1120         * Plugins/WebPluginDatabase.mm:
1121         (checkCandidate): Use explicit __strong for out argument types.
1122
1123         * Plugins/npapi.mm:
1124         (pluginViewForInstance): Use a bridging cast.
1125
1126         * Storage/WebDatabaseManager.mm:
1127         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1128         explicit NSNumber and NSDictionary calls.
1129
1130         * WebCoreSupport/WebContextMenuClient.mm:
1131         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1132
1133         * WebCoreSupport/WebEditorClient.mm:
1134         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1135         (WebEditorClient::handleInputMethodKeydown): Ditto.
1136
1137         * WebCoreSupport/WebFrameNetworkingContext.mm:
1138         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1139
1140         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1141         as a struct rather than an Objective-C class, since that's how it's defined.
1142
1143         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1144
1145         * WebView/WebFullScreenController.mm:
1146         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1147         * WebView/WebHTMLView.mm:
1148         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1149         Ditto.
1150         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1151
1152         * WebView/WebImmediateActionController.mm:
1153         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1154         go down to the document and then back to the frame.
1155         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1156         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1157         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1158
1159         * WebView/WebJSPDFDoc.mm:
1160         (jsPDFDocInitialize): Removed some unneeded type casting.
1161         (jsPDFDocFinalize): Ditto.
1162         (jsPDFDocPrint): Use a bridging cast.
1163
1164         * WebView/WebPDFView.mm:
1165         (_applicationInfoForMIMEType): Use bridging casts.
1166
1167         * WebView/WebPreferences.mm:
1168         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1169         instead of methods from WebNSDictionaryExtras.
1170         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1171         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1172         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1173         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1174         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1175
1176         * WebView/WebView.mm:
1177         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1178         (-[WebView _addToAllWebViewsSet]): Ditto.
1179         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1180         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1181         so it can be called from WebViewData methods.
1182
1183         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1184         method, _windowVisibilityChanged:.
1185
1186         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1187         called from WebViewData methods.
1188
1189 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1190
1191         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1192         https://bugs.webkit.org/show_bug.cgi?id=188323
1193
1194         Reviewed by Simon Fraser.
1195
1196         * WebCoreSupport/WebContextMenuClient.mm:
1197         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1198         * WebView/WebFrame.mm:
1199         (-[WebFrame _paintBehaviorForDestinationContext:]):
1200         (-[WebFrame _drawRect:contentsOnly:]):
1201         * WebView/WebHTMLView.mm:
1202         (imageFromRect):
1203         (selectionImage):
1204
1205 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1206
1207         Add support for microtasks in workers
1208         https://bugs.webkit.org/show_bug.cgi?id=188246
1209
1210         Reviewed by Darin Adler.
1211
1212         Rename JSMainThreadExecState.h to JSExecState.h.
1213
1214         * DOM/DOMAttr.mm:
1215         * DOM/DOMBlob.mm:
1216         * DOM/DOMCDATASection.mm:
1217         * DOM/DOMCSSCharsetRule.mm:
1218         * DOM/DOMCSSFontFaceRule.mm:
1219         * DOM/DOMCSSImportRule.mm:
1220         * DOM/DOMCSSMediaRule.mm:
1221         * DOM/DOMCSSPageRule.mm:
1222         * DOM/DOMCSSPrimitiveValue.mm:
1223         * DOM/DOMCSSRule.mm:
1224         * DOM/DOMCSSRuleList.mm:
1225         * DOM/DOMCSSStyleDeclaration.mm:
1226         * DOM/DOMCSSStyleRule.mm:
1227         * DOM/DOMCSSStyleSheet.mm:
1228         * DOM/DOMCSSUnknownRule.mm:
1229         * DOM/DOMCSSValue.mm:
1230         * DOM/DOMCSSValueList.mm:
1231         * DOM/DOMCharacterData.mm:
1232         * DOM/DOMComment.mm:
1233         * DOM/DOMCounter.mm:
1234         * DOM/DOMDocument.mm:
1235         * DOM/DOMDocumentFragment.mm:
1236         * DOM/DOMDocumentType.mm:
1237         * DOM/DOMElement.mm:
1238         * DOM/DOMEvent.mm:
1239         * DOM/DOMFile.mm:
1240         * DOM/DOMFileList.mm:
1241         * DOM/DOMHTML.mm:
1242         * DOM/DOMHTMLAnchorElement.mm:
1243         * DOM/DOMHTMLAppletElement.mm:
1244         * DOM/DOMHTMLAreaElement.mm:
1245         * DOM/DOMHTMLBRElement.mm:
1246         * DOM/DOMHTMLBaseElement.mm:
1247         * DOM/DOMHTMLBaseFontElement.mm:
1248         * DOM/DOMHTMLBodyElement.mm:
1249         * DOM/DOMHTMLButtonElement.mm:
1250         * DOM/DOMHTMLCanvasElement.mm:
1251         * DOM/DOMHTMLCollection.mm:
1252         * DOM/DOMHTMLDListElement.mm:
1253         * DOM/DOMHTMLDirectoryElement.mm:
1254         * DOM/DOMHTMLDivElement.mm:
1255         * DOM/DOMHTMLDocument.mm:
1256         * DOM/DOMHTMLElement.mm:
1257         * DOM/DOMHTMLEmbedElement.mm:
1258         * DOM/DOMHTMLFieldSetElement.mm:
1259         * DOM/DOMHTMLFontElement.mm:
1260         * DOM/DOMHTMLFormElement.mm:
1261         * DOM/DOMHTMLFrameElement.mm:
1262         * DOM/DOMHTMLFrameSetElement.mm:
1263         * DOM/DOMHTMLHRElement.mm:
1264         * DOM/DOMHTMLHeadElement.mm:
1265         * DOM/DOMHTMLHeadingElement.mm:
1266         * DOM/DOMHTMLHtmlElement.mm:
1267         * DOM/DOMHTMLIFrameElement.mm:
1268         * DOM/DOMHTMLImageElement.mm:
1269         * DOM/DOMHTMLInputElement.mm:
1270         * DOM/DOMHTMLLIElement.mm:
1271         * DOM/DOMHTMLLabelElement.mm:
1272         * DOM/DOMHTMLLegendElement.mm:
1273         * DOM/DOMHTMLLinkElement.mm:
1274         * DOM/DOMHTMLMapElement.mm:
1275         * DOM/DOMHTMLMarqueeElement.mm:
1276         * DOM/DOMHTMLMediaElement.mm:
1277         * DOM/DOMHTMLMenuElement.mm:
1278         * DOM/DOMHTMLMetaElement.mm:
1279         * DOM/DOMHTMLModElement.mm:
1280         * DOM/DOMHTMLOListElement.mm:
1281         * DOM/DOMHTMLObjectElement.mm:
1282         * DOM/DOMHTMLOptGroupElement.mm:
1283         * DOM/DOMHTMLOptionElement.mm:
1284         * DOM/DOMHTMLOptionsCollection.mm:
1285         * DOM/DOMHTMLParagraphElement.mm:
1286         * DOM/DOMHTMLParamElement.mm:
1287         * DOM/DOMHTMLPreElement.mm:
1288         * DOM/DOMHTMLQuoteElement.mm:
1289         * DOM/DOMHTMLScriptElement.mm:
1290         * DOM/DOMHTMLSelectElement.mm:
1291         * DOM/DOMHTMLStyleElement.mm:
1292         * DOM/DOMHTMLTableCaptionElement.mm:
1293         * DOM/DOMHTMLTableCellElement.mm:
1294         * DOM/DOMHTMLTableColElement.mm:
1295         * DOM/DOMHTMLTableElement.mm:
1296         * DOM/DOMHTMLTableRowElement.mm:
1297         * DOM/DOMHTMLTableSectionElement.mm:
1298         * DOM/DOMHTMLTextAreaElement.mm:
1299         * DOM/DOMHTMLTitleElement.mm:
1300         * DOM/DOMHTMLUListElement.mm:
1301         * DOM/DOMHTMLVideoElement.mm:
1302         * DOM/DOMImplementation.mm:
1303         * DOM/DOMKeyboardEvent.mm:
1304         * DOM/DOMMediaError.mm:
1305         * DOM/DOMMediaList.mm:
1306         * DOM/DOMMouseEvent.mm:
1307         * DOM/DOMMutationEvent.mm:
1308         * DOM/DOMNamedNodeMap.mm:
1309         * DOM/DOMNode.mm:
1310         * DOM/DOMNodeIterator.mm:
1311         * DOM/DOMNodeList.mm:
1312         * DOM/DOMOverflowEvent.mm:
1313         * DOM/DOMProcessingInstruction.mm:
1314         * DOM/DOMProgressEvent.mm:
1315         * DOM/DOMRGBColor.mm:
1316         * DOM/DOMRange.mm:
1317         * DOM/DOMRect.mm:
1318         * DOM/DOMStyleSheet.mm:
1319         * DOM/DOMStyleSheetList.mm:
1320         * DOM/DOMText.mm:
1321         * DOM/DOMTextEvent.mm:
1322         * DOM/DOMTimeRanges.mm:
1323         * DOM/DOMTokenList.mm:
1324         * DOM/DOMTreeWalker.mm:
1325         * DOM/DOMUIEvent.mm:
1326         * DOM/DOMWheelEvent.mm:
1327         * DOM/DOMXPathExpression.mm:
1328         * DOM/DOMXPathResult.mm:
1329         * DOM/ObjCEventListener.mm:
1330
1331 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1332
1333         Fix spelling of "overridden"
1334         https://bugs.webkit.org/show_bug.cgi?id=188315
1335
1336         Reviewed by Darin Adler.
1337
1338         * Misc/WebKitVersionChecks.mm:
1339         (setWebKitLinkTimeVersion):
1340         (WebKitLinkTimeVersion):
1341         * Plugins/WebBaseNetscapePluginView.mm:
1342         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1343         * WebCoreSupport/PopupMenuMac.mm:
1344         (PopupMenuMac::populate):
1345
1346 2018-08-01  Nan Wang  <n_wang@apple.com>
1347
1348         AX: AOM: Add ARIA IDL Attribute Reflection
1349         https://bugs.webkit.org/show_bug.cgi?id=184676
1350         <rdar://problem/39476882>
1351
1352         Reviewed by Chris Fleizach.
1353
1354         * WebView/WebPreferenceKeysPrivate.h:
1355         * WebView/WebPreferences.mm:
1356         (+[WebPreferences initialize]):
1357         (-[WebPreferences ariaReflectionEnabled]):
1358         (-[WebPreferences setAriaReflectionEnabled:]):
1359         * WebView/WebPreferencesPrivate.h:
1360         * WebView/WebView.mm:
1361         (-[WebView _preferencesChanged:]):
1362
1363 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1364
1365         Shrink GraphicsLayerCA
1366         https://bugs.webkit.org/show_bug.cgi?id=188141
1367
1368         Reviewed by Zalan Bujtas.
1369
1370         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1371         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1372         * moving all the animation-related stuff into the lazily-allocated m_animations
1373         * making enums be 8-bit
1374         * re-ordering data members
1375
1376         * WebView/WebView.mm:
1377         (-[WebView _setMediaLayer:forPluginView:]):
1378
1379 2018-07-30  Rob Buis  <rbuis@igalia.com>
1380
1381         Merge PlatformCookieJar functions into NetworkStorageSession
1382         https://bugs.webkit.org/show_bug.cgi?id=188137
1383
1384         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1385
1386         Reviewed by Alex Christensen.
1387
1388         * WebCoreSupport/WebPlatformStrategies.mm:
1389         (WebPlatformStrategies::cookiesForDOM):
1390         (WebPlatformStrategies::setCookiesFromDOM):
1391         (WebPlatformStrategies::cookiesEnabled):
1392         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1393         (WebPlatformStrategies::getRawCookies):
1394         (WebPlatformStrategies::deleteCookie):
1395         * WebView/WebPreferences.mm:
1396         (+[WebPreferences _clearNetworkLoaderSession]):
1397
1398 2018-07-28  Darin Adler  <darin@apple.com>
1399
1400         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1401         https://bugs.webkit.org/show_bug.cgi?id=188140
1402
1403         Reviewed by Sam Weinig.
1404
1405         * WebView/WebImmediateActionController.mm:
1406         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1407         new DictionaryLookup function that returns a tuple instead of using an out argument.
1408
1409 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1410
1411         [INTL] Remove INTL sub-feature compile flags
1412         https://bugs.webkit.org/show_bug.cgi?id=188081
1413
1414         Reviewed by Michael Catanzaro.
1415
1416         * Configurations/FeatureDefines.xcconfig:
1417
1418 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1419
1420         Unreviewed, rolling out r234181 and r234189.
1421         https://bugs.webkit.org/show_bug.cgi?id=188075
1422
1423         These are not needed right now (Requested by thorton on
1424         #webkit).
1425
1426         Reverted changesets:
1427
1428         "Enable Web Content Filtering on watchOS"
1429         https://bugs.webkit.org/show_bug.cgi?id=187979
1430         https://trac.webkit.org/changeset/234181
1431
1432         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1433         https://bugs.webkit.org/show_bug.cgi?id=187985
1434         https://trac.webkit.org/changeset/234189
1435
1436 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1437
1438         Use the Page's appearance when converting pasteboard attributed strings.
1439         https://bugs.webkit.org/show_bug.cgi?id=188067
1440         rdar://problem/42632246
1441
1442         Reviewed by Wenson Hsieh.
1443
1444         * WebCoreSupport/WebEditorClient.mm:
1445         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1446
1447 2018-07-25  Chris Dumez  <cdumez@apple.com>
1448
1449         navigator.userAgent may return outdated value after webView.customUserAgent is set
1450         https://bugs.webkit.org/show_bug.cgi?id=188009
1451         <rdar://problem/42566456>
1452
1453         Reviewed by Alex Christensen.
1454
1455         Let the page know when the user agent changes.
1456
1457         * WebView/WebView.mm:
1458         (-[WebView _preferencesChanged:]):
1459         (-[WebView setApplicationNameForUserAgent:]):
1460         (-[WebView _invalidateUserAgentCache]):
1461         (-[WebView setCustomUserAgent:]):
1462         * WebView/WebViewInternal.h:
1463
1464 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1465
1466         Enable Web Content Filtering on watchOS
1467         https://bugs.webkit.org/show_bug.cgi?id=187979
1468         <rdar://problem/42559346>
1469
1470         Reviewed by Wenson Hsieh.
1471
1472         * Configurations/FeatureDefines.xcconfig:
1473
1474 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1475
1476         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1477         https://bugs.webkit.org/show_bug.cgi?id=187846
1478
1479         Reviewed by Simon Fraser.
1480
1481         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1482
1483         * WebView/WebHTMLView.mm:
1484         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1485         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1486
1487 2018-07-11  Dean Jackson  <dino@apple.com>
1488
1489         Allow removal of white backgrounds
1490         https://bugs.webkit.org/show_bug.cgi?id=187574
1491         <rdar://problem/41146792>
1492
1493         Reviewed by Simon Fraser.
1494
1495         Add a new WebPreference for punching out white backgrounds.
1496
1497         * WebView/WebPreferenceKeysPrivate.h:
1498         * WebView/WebPreferences.mm:
1499         (+[WebPreferences initialize]):
1500         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1501         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1502         * WebView/WebPreferencesPrivate.h:
1503         * WebView/WebView.mm:
1504         (-[WebView _preferencesChanged:]):
1505
1506 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1507
1508         Ensure WebKit stack is ad-hoc signed
1509         https://bugs.webkit.org/show_bug.cgi?id=187667
1510
1511         Reviewed by Alexey Proskuryakov.
1512
1513         * Configurations/Base.xcconfig:
1514
1515 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1516
1517         REGRESSION (231276): Attempting to copy an image fails
1518         https://bugs.webkit.org/show_bug.cgi?id=187212
1519         <rdar://problem/41540074>
1520
1521         Reviewed by Ryosuke Niwa.
1522
1523         Renamed methods to make it clear that one URL and one title are being passed in.
1524
1525         * WebCoreSupport/WebPlatformStrategies.h:
1526         * WebCoreSupport/WebPlatformStrategies.mm:
1527         (WebPlatformStrategies::setURL):
1528
1529 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1530
1531         Disable cross-origin-window-policy by default
1532         https://bugs.webkit.org/show_bug.cgi?id=187509
1533
1534         Reviewed by Chris Dumez.
1535
1536         * WebView/WebPreferences.mm:
1537         (+[WebPreferences initialize]):
1538
1539 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1540
1541         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1542         https://bugs.webkit.org/show_bug.cgi?id=187425
1543         rdar://problem/39948240
1544
1545         Reviewed by Tim Horton.
1546
1547         * WebView/WebView.mm:
1548         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1549         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1550         a call in this method to setUseDarkAppearance.
1551         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1552         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1553         (-[WebView _updateDefaultAppearance]): Deleted.
1554         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1555
1556 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1557
1558         Shrink various loading-related enums to shrink CachedResource
1559         https://bugs.webkit.org/show_bug.cgi?id=187443
1560
1561         Reviewed by Chris Dumez.
1562
1563         * WebCoreSupport/WebFrameLoaderClient.mm:
1564         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1565         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1566         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1567         (WebFrameLoaderClient::dispatchWillSendRequest):
1568         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1569         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1570         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1571         (WebFrameLoaderClient::updateGlobalHistory):
1572         (WebFrameLoaderClient::canHandleRequest const):
1573         * WebView/WebDataSource.mm:
1574         (-[WebDataSource initialRequest]):
1575         (-[WebDataSource request]):
1576
1577 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1578
1579         Unreviewed, rolling out r233612.
1580         https://bugs.webkit.org/show_bug.cgi?id=187475
1581
1582         Revision caused the api test LinkColorWithSystemAppearance to
1583         fail on all systems. (Requested by Truitt on #webkit).
1584
1585         Reverted changeset:
1586
1587         "Semantic colors don't update when accessibility Increase
1588         Contrast mode is enabled."
1589         https://bugs.webkit.org/show_bug.cgi?id=187425
1590         https://trac.webkit.org/changeset/233612
1591
1592 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1593
1594         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1595         https://bugs.webkit.org/show_bug.cgi?id=187425
1596         rdar://problem/39948240
1597
1598         Reviewed by Tim Horton.
1599
1600         * WebView/WebView.mm:
1601         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1602         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1603         a call in this method to setUseDarkAppearance.
1604         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1605         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1606         (-[WebView _updateDefaultAppearance]): Deleted.
1607         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1608
1609 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1610
1611         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1612         https://bugs.webkit.org/show_bug.cgi?id=187369
1613         rdar://problem/41870420
1614
1615         Reviewed by Tim Horton.
1616
1617         * WebView/WebMediaPlaybackTargetPicker.mm:
1618         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1619         * WebView/WebView.mm:
1620         (-[WebView _commonInitializationWithFrameName:groupName:]):
1621         (-[WebView _effectiveAppearanceIsDark]):
1622         (-[WebView _updateDefaultAppearance]):
1623         (-[WebView _defaultAppearance]): Deleted.
1624
1625 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1626
1627         Youtube video pages crash after a couple of minutes
1628         https://bugs.webkit.org/show_bug.cgi?id=187316
1629
1630         Reviewed by Antti Koivisto.
1631
1632         * WebView/WebView.mm:
1633         (-[WebView _preferencesChanged:]):
1634
1635 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1636
1637         Introduce PLATFORM(IOSMAC)
1638         https://bugs.webkit.org/show_bug.cgi?id=187315
1639
1640         Reviewed by Dan Bernstein.
1641
1642         * Configurations/Base.xcconfig:
1643         * Configurations/FeatureDefines.xcconfig:
1644
1645 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1646
1647         [iOS] DataTransfer.getData always returns the empty string when dropping text
1648         https://bugs.webkit.org/show_bug.cgi?id=187130
1649         <rdar://problem/41014117>
1650
1651         Reviewed by Ryosuke Niwa.
1652
1653         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1654
1655         * WebCoreSupport/WebPlatformStrategies.h:
1656         * WebCoreSupport/WebPlatformStrategies.mm:
1657         (WebPlatformStrategies::allPasteboardItemInfo):
1658
1659 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1660
1661         [Mac] AirPlay picker uses incorrect theme in Dark mode
1662         https://bugs.webkit.org/show_bug.cgi?id=187054
1663         <rdar://problem/41291093>
1664
1665         Reviewed by Timothy Hatcher.
1666
1667         * WebView/WebMediaPlaybackTargetPicker.mm:
1668         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1669
1670 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1671
1672         [WTF] Add user-defined literal for ASCIILiteral
1673         https://bugs.webkit.org/show_bug.cgi?id=186839
1674
1675         Reviewed by Darin Adler.
1676
1677         * DOM/ExceptionHandlers.mm:
1678         (raiseDOMErrorException):
1679         * Plugins/Hosted/ProxyInstance.mm:
1680         (WebKit::ProxyInstance::invokeMethod):
1681         * Storage/WebDatabaseProvider.mm:
1682         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1683
1684 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1685
1686         Recalc styles every time defaultAppearance changes.
1687         https://bugs.webkit.org/show_bug.cgi?id=186866
1688         rdar://problem/41309805
1689
1690         Reviewed by Tim Horton.
1691
1692         * WebView/WebView.mm:
1693         (-[WebView _updateDefaultAppearance]):
1694         (-[WebView _setUseSystemAppearance:]):
1695         (-[WebView _useSystemAppearance]):
1696
1697 2018-06-20  Darin Adler  <darin@apple.com>
1698
1699         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1700         https://bugs.webkit.org/show_bug.cgi?id=186875
1701
1702         Reviewed by Anders Carlsson.
1703
1704         * WebView/WebHTMLView.mm:
1705         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1706         to write te file to.
1707         * WebView/WebPreferences.mm:
1708         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1709         * WebView/WebView.mm:
1710         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1711
1712 2018-06-12  Darin Adler  <darin@apple.com>
1713
1714         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1715         https://bugs.webkit.org/show_bug.cgi?id=186526
1716
1717         Reviewed by Anders Carlsson.
1718
1719         * Plugins/Hosted/NetscapePluginHostManager.mm:
1720         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1721
1722         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1723         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1724         assignment rather than adoptNS/leakRef.
1725         * Plugins/WebNetscapePluginView.mm:
1726         (-[WebNetscapePluginView createPlugin]): Ditto.
1727
1728         * WebCoreSupport/WebContextMenuClient.mm:
1729         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1730         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1731         argument, so use RetainPtr::get instead.
1732
1733         * WebView/WebHTMLView.mm:
1734         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1735         No need to autorelease the result when the return type is RetainPtr.
1736
1737         * WebView/WebPDFRepresentation.mm:
1738         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1739
1740 2018-06-13  Youenn Fablet  <youenn@apple.com>
1741
1742         Supported plugin check should be based on plugin identifier
1743         https://bugs.webkit.org/show_bug.cgi?id=186578
1744         <rdar://problem/40523828>
1745
1746         Reviewed by Darin Adler.
1747
1748         * WebCoreSupport/WebPluginInfoProvider.h:
1749         * WebCoreSupport/WebPluginInfoProvider.mm:
1750         (WebPluginInfoProvider::pluginInfo):
1751         (WebPluginInfoProvider::webVisiblePluginInfo):
1752
1753 2018-06-13  Chris Dumez  <cdumez@apple.com>
1754
1755         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1756         https://bugs.webkit.org/show_bug.cgi?id=186545
1757
1758         Reviewed by Brady Eidson.
1759
1760         Update client delegate now that parameter type has changed.
1761
1762         * WebCoreSupport/WebFrameLoaderClient.h:
1763         * WebCoreSupport/WebFrameLoaderClient.mm:
1764         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1765
1766 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1767
1768         Link drag image is inconsistently unreadable in dark mode
1769         https://bugs.webkit.org/show_bug.cgi?id=186472
1770
1771         Reviewed by Timothy Hatcher.
1772
1773         * WebView/WebView.mm:
1774         (-[WebView _defaultAppearance]):
1775         Make defaultAppearance accurate even if useSystemAppearance is false.
1776         Some parts of WebKit (like the link drag image, but also context menus)
1777         want to be able to follow the system appearance regardless of whether
1778         the view or content has opted in.
1779
1780 2018-06-11  Chris Dumez  <cdumez@apple.com>
1781
1782         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1783         https://bugs.webkit.org/show_bug.cgi?id=186441
1784
1785         Reviewed by Brady Eidson.
1786
1787         Rename existing flag to something a bit more generic, now that it is used for
1788         more things than bypassing the navigation policy check.
1789
1790         * WebView/WebView.mm:
1791         (-[WebView _loadBackForwardListFromOtherView:]):
1792         (-[WebView goToBackForwardItem:]):
1793
1794 2018-06-09  Dan Bernstein  <mitz@apple.com>
1795
1796         [Xcode] Clean up and modernize some build setting definitions
1797         https://bugs.webkit.org/show_bug.cgi?id=186463
1798
1799         Reviewed by Sam Weinig.
1800
1801         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1802         * Configurations/DebugRelease.xcconfig: Ditto.
1803         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1804           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1805         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1806         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1807           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1808         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1809
1810 2018-06-08  Darin Adler  <darin@apple.com>
1811
1812         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1813         https://bugs.webkit.org/show_bug.cgi?id=186436
1814
1815         Reviewed by Anders Carlsson.
1816
1817         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1818         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1819         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1820         (PoolCleaner): Ditto.
1821
1822         * History/WebHistory.mm:
1823         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1824         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1825         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1826         now hardly used if at all.
1827         * WebView/WebView.mm:
1828         (-[WebView rectsForTextMatches]): Ditto.
1829
1830 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1831
1832         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1833         https://bugs.webkit.org/show_bug.cgi?id=186442
1834         <rdar://problem/40879364>
1835
1836         Reviewed by Tim Horton.
1837
1838         * Configurations/FeatureDefines.xcconfig:
1839
1840 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1841
1842         [Datalist] Allow TextFieldInputType to show and hide suggestions
1843         https://bugs.webkit.org/show_bug.cgi?id=186151
1844
1845         Reviewed by Tim Horton.
1846
1847         * WebCoreSupport/WebChromeClient.h:
1848         * WebCoreSupport/WebChromeClient.mm:
1849         (WebChromeClient::createDataListSuggestionPicker):
1850
1851 2018-06-07  Chris Dumez  <cdumez@apple.com>
1852
1853         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1854         https://bugs.webkit.org/show_bug.cgi?id=186407
1855
1856         Reviewed by Brent Fulgham.
1857
1858         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1859         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1860         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1861         makeWeakPtr().
1862
1863         * WebCoreSupport/WebEditorClient.h:
1864         * WebCoreSupport/WebEditorClient.mm:
1865         (WebEditorClient::requestCandidatesForSelection):
1866
1867 2018-06-05  Chris Dumez  <cdumez@apple.com>
1868
1869         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1870         https://bugs.webkit.org/show_bug.cgi?id=186331
1871         <rdar://problem/40735446>
1872
1873         Reviewed by Darin Adler.
1874
1875         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1876         but does not call use / ignore on the listener, then we would do "use" by default.
1877         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1878         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1879         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1880         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1881         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1882         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
1883         and Box.app is still working properly.
1884
1885         * WebCoreSupport/WebFrameLoaderClient.h:
1886         * WebCoreSupport/WebFrameLoaderClient.mm:
1887         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1888         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1889         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1890         (WebFrameLoaderClient::dispatchWillSubmitForm):
1891         (WebFrameLoaderClient::setUpPolicyListener):
1892         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
1893         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
1894         (-[WebFramePolicyListener dealloc]):
1895         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
1896         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
1897
1898 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1899
1900         Adjust compile and runtime flags to match shippable state of features
1901         https://bugs.webkit.org/show_bug.cgi?id=186319
1902         <rdar://problem/40352045>
1903
1904         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1905
1906         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1907         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1908         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
1909         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1910         Cocoa builds.
1911
1912 2018-06-05  Timothy Hatcher  <timothy@apple.com>
1913
1914         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
1915
1916         https://bugs.webkit.org/show_bug.cgi?id=186323
1917         rdar://problem/38382252
1918
1919         Reviewed by Tim Horton.
1920
1921         * WebView/WebView.mm:
1922         (-[WebView _defaultAppearance]):
1923
1924 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1925
1926         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1927         https://bugs.webkit.org/show_bug.cgi?id=186286
1928         <rdar://problem/40782992>
1929
1930         Reviewed by Dan Bernstein.
1931
1932         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1933         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1934         change this flag when preparing for a production release.
1935
1936         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
1937         whether experimental features should be enabled, and use it to properly define the
1938         feature flag.
1939
1940 2018-06-03  Darin Adler  <darin@apple.com>
1941
1942         Simplify and remove some unused video element code (helpful for ARC-compatibility)
1943         https://bugs.webkit.org/show_bug.cgi?id=186258
1944
1945         Reviewed by Daniel Bates.
1946
1947         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
1948         forward declarations. Removed methods that don't need to be public.
1949
1950         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
1951         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
1952         unnamed category in here and also replaced the HUDWindowControllerDelegate
1953         with the unnamed category. Removed unused NSWindow category defining the
1954         isOnActiveSpace, which is not called anywhere in this file at this time.
1955         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
1956         into setVideoElement.
1957         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
1958         and removed unneeded typecast.
1959         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
1960         using statement at the top of the file.
1961         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
1962         the many side effects and special considerations that this method that sounds
1963         like a setter has. Updated code to use the new
1964         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
1965         HTMLVideoElement::platformMedia function. Also straightened out the logic a
1966         bit and added some FIXME comments about small problems noticed but not fixed.
1967         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
1968         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
1969         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
1970         typecast. Removed call to updatePowerAssertions method.
1971         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
1972         updatePowerAssertions method.
1973         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
1974         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
1975         else, so this was dead code that did nothing.
1976         (-[WebVideoFullscreenController rateChanged:]): Removed call to
1977         updatePowerAssertions method.
1978
1979 2018-06-04  Chris Dumez  <cdumez@apple.com>
1980
1981         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1982         https://bugs.webkit.org/show_bug.cgi?id=186287
1983         <rdar://problem/40783352>
1984
1985         Reviewed by Youenn Fablet.
1986
1987         * WebView/WebPreferenceKeysPrivate.h:
1988         * WebView/WebPreferences.mm:
1989         (+[WebPreferences initialize]):
1990         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
1991         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
1992         * WebView/WebPreferencesPrivate.h:
1993         * WebView/WebView.mm:
1994         (-[WebView _preferencesChanged:]):
1995
1996 2018-06-02  Darin Adler  <darin@apple.com>
1997
1998         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
1999         https://bugs.webkit.org/show_bug.cgi?id=186227
2000
2001         Reviewed by Dan Bernstein.
2002
2003         * Misc/WebKitErrors.m:
2004         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2005         * Plugins/WebPluginDatabase.mm:
2006         (-[WebPluginDatabase refresh]): Ditto.
2007         * WebCoreSupport/WebChromeClient.mm:
2008         (WebChromeClient::setStatusbarText): Ditto.
2009
2010 2018-06-01  Chris Dumez  <cdumez@apple.com>
2011
2012         REGRESSION (r231456): Colloquy is broken
2013         https://bugs.webkit.org/show_bug.cgi?id=186197
2014         <rdar://problem/40722960>
2015
2016         Reviewed by Timothy Hatcher.
2017
2018         Restore pre-r231456 behavior for Colloquy app so that it works again.
2019
2020         * WebView/WebView.mm:
2021         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2022         (-[WebView _preferencesChanged:]):
2023
2024 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2025
2026         [JSC] Pass VM& parameter as much as possible
2027         https://bugs.webkit.org/show_bug.cgi?id=186085
2028
2029         Reviewed by Saam Barati.
2030
2031         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2032         (WebKit::NetscapePluginInstanceProxy::invoke):
2033
2034 2018-05-30  Daniel Bates  <dabates@apple.com>
2035
2036         NavigationAction does not need to hold initiating DOM Event
2037         https://bugs.webkit.org/show_bug.cgi?id=185958
2038         <rdar://problem/40531539>
2039
2040         Reviewed by Simon Fraser.
2041
2042         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2043
2044         * WebCoreSupport/WebFrameLoaderClient.mm:
2045         (WebFrameLoaderClient::actionDictionary const):
2046         (findMouseEvent): Deleted.
2047
2048 2018-05-27  Dan Bernstein  <mitz@apple.com>
2049
2050         Reverted the changes made for https://webkit.org/b/186016
2051
2052         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2053
2054
2055 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2056
2057         [iOS] Fix warnings about leaks found by clang static analyzer
2058         <https://webkit.org/b/186009>
2059         <rdar://problem/40574267>
2060
2061         Reviewed by Daniel Bates.
2062
2063         * WebView/WebHTMLView.mm:
2064         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2065         uninitialized boolean variable (`eventWasHandled`) that only
2066         happened on iOS.
2067
2068 2018-05-27  Dan Bernstein  <mitz@apple.com>
2069
2070         [Cocoa] Avoid importing directly from subumbrella frameworks
2071         https://bugs.webkit.org/show_bug.cgi?id=186016
2072
2073         Reviewed by Sam Weinig.
2074
2075         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2076         * Carbon/CarbonWindowAdapter.mm: Ditto.
2077         * Carbon/CarbonWindowFrame.m: Ditto.
2078         * Carbon/HIViewAdapter.h: Ditto.
2079         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2080           OTHER_CPLUSPLUSFLAGS.
2081         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2082         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2083         * WebView/WebPDFView.h: Ditto.
2084
2085 2018-05-27  Sam Weinig  <sam@webkit.org>
2086
2087         Modernize RenderStyleConstants.h - Part 3
2088         https://bugs.webkit.org/show_bug.cgi?id=186015
2089
2090         Reviewed by Yusuke Suzuki.
2091
2092         * WebView/WebView.mm:
2093         (-[WebView updateTextTouchBar]):
2094         Update for new enum name.
2095
2096 2018-05-25  Chris Dumez  <cdumez@apple.com>
2097
2098         Minor ApplicationCacheStorage clean up
2099         https://bugs.webkit.org/show_bug.cgi?id=185984
2100
2101         Reviewed by Youenn Fablet.
2102
2103         * WebCoreSupport/WebApplicationCache.mm:
2104         (+[WebApplicationCache originsWithCache]):
2105
2106 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2107
2108         Fix issues with -dealloc methods found by clang static analyzer
2109         <https://webkit.org/b/185887>
2110
2111         Reviewed by Joseph Pecoraro.
2112
2113         * WebView/WebView.mm:
2114         (-[WebUITextIndicatorData dealloc]):
2115         - Move method implementation from (WebUITextIndicatorInternal)
2116           category to the main category since this is public API.  This
2117           fixes the false positive warning about a missing -dealloc
2118           method.
2119
2120 2018-05-24  Sam Weinig  <sam@webkit.org>
2121
2122         Modernize RenderStyleConstants.h - Part 2
2123         https://bugs.webkit.org/show_bug.cgi?id=185901
2124
2125         Reviewed by Simon Fraser.
2126
2127         * WebView/WebHTMLRepresentation.mm:
2128         (searchForLabelsBeforeElement):
2129         * WebView/WebView.mm:
2130         (nsTextAlignmentFromRenderStyle):
2131         Update for new enum names.
2132
2133 2018-05-22  Chris Dumez  <cdumez@apple.com>
2134
2135         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2136         https://bugs.webkit.org/show_bug.cgi?id=185832
2137         <rdar://problem/40307871>
2138
2139         Reviewed by Geoffrey Garen.
2140
2141         We used to have a bug where where we would fail to wait for the policy decision for
2142         the navigation response from the client and the load would keep going, racing with
2143         the client's policy decision. If the client did not respond in time, the behavior
2144         would be the same as "Use" policy action.
2145
2146         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2147         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2148         WebKit bug, however, the load would hang because the completion handler for the
2149         decidePolicyForNavigationResponse would never get called.
2150
2151         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2152         instead of retaining it. If the policy listener object gets destroyed because getting
2153         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2154         behavior.
2155
2156         * WebCoreSupport/WebFrameLoaderClient.h:
2157         * WebCoreSupport/WebFrameLoaderClient.mm:
2158         (WebFrameLoaderClient::cancelPolicyCheck):
2159         (WebFrameLoaderClient::setUpPolicyListener):
2160         (-[WebFramePolicyListener dealloc]):
2161
2162 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2163
2164         Unreviewed, rolling out r232052.
2165
2166         Breaks internal builds.
2167
2168         Reverted changeset:
2169
2170         "Use more C++17"
2171         https://bugs.webkit.org/show_bug.cgi?id=185176
2172         https://trac.webkit.org/changeset/232052
2173
2174 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2175
2176         Use more C++17
2177         https://bugs.webkit.org/show_bug.cgi?id=185176
2178
2179         Reviewed by JF Bastien.
2180
2181         * Configurations/Base.xcconfig:
2182         * Configurations/WebKitLegacy.xcconfig:
2183
2184 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2185
2186         Remove dead exception in MediaList.appendMedium
2187         https://bugs.webkit.org/show_bug.cgi?id=185278
2188
2189         Reviewed by Chris Dumez.
2190
2191         Remove code pertaining to an exception being thrown by appendMedium().
2192
2193         * DOM/DOMMediaList.mm:
2194         (-[DOMMediaList appendMedium:]):
2195
2196 2018-05-21  Jer Noble  <jer.noble@apple.com>
2197
2198         Complete fix for enabling modern EME by default
2199         https://bugs.webkit.org/show_bug.cgi?id=185770
2200         <rdar://problem/40368220>
2201
2202         Reviewed by Eric Carlson.
2203
2204         * Configurations/FeatureDefines.xcconfig:
2205
2206 2018-05-21  Antti Koivisto  <antti@apple.com>
2207
2208         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2209         https://bugs.webkit.org/show_bug.cgi?id=185815
2210         <rdar://problem/40310069>
2211
2212         Reviewed by Simon Fraser.
2213
2214         User stylesheet parsing may depend on the colorFilterEnabled preference.
2215
2216         * WebView/WebView.mm:
2217         (-[WebView _preferencesChanged:]):
2218
2219 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2220
2221         Unreviewed, rolling out r231982.
2222         https://bugs.webkit.org/show_bug.cgi?id=185793
2223
2224         Caused layout test failures (Requested by realdawei on
2225         #webkit).
2226
2227         Reverted changeset:
2228
2229         "Complete fix for enabling modern EME by default"
2230         https://bugs.webkit.org/show_bug.cgi?id=185770
2231         https://trac.webkit.org/changeset/231982
2232
2233 2018-05-18  Jer Noble  <jer.noble@apple.com>
2234
2235         Complete fix for enabling modern EME by default
2236         https://bugs.webkit.org/show_bug.cgi?id=185770
2237         <rdar://problem/40368220>
2238
2239         Reviewed by Eric Carlson.
2240
2241         * Configurations/FeatureDefines.xcconfig:
2242
2243 2018-05-18  Chris Dumez  <cdumez@apple.com>
2244
2245         Avoid keeping the frame alive when ref'ing a WindowProxy
2246         https://bugs.webkit.org/show_bug.cgi?id=185737
2247         <rdar://problem/40004666>
2248
2249         Reviewed by Sam Weinig.
2250
2251         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2252         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2253
2254 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2255
2256         Add support for Intl NumberFormat formatToParts
2257         https://bugs.webkit.org/show_bug.cgi?id=185375
2258
2259         Reviewed by Yusuke Suzuki.
2260
2261         Add flag for NumberFormat formatToParts.
2262
2263         * Configurations/FeatureDefines.xcconfig:
2264
2265 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2266
2267         Fixup after r231849: Do not mark Mac API methods as deprecated
2268         https://bugs.webkit.org/show_bug.cgi?id=185684
2269
2270         Reviewed by Darin Adler.
2271
2272         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2273         as the entire class is already marked as deprecated, so it is unnecessary.
2274
2275         * DOM/DOMDocument.h:
2276
2277 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2278
2279         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2280         https://bugs.webkit.org/show_bug.cgi?id=185381
2281
2282         Reviewed by Darin Adler.
2283
2284         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2285         and make them do nothing.
2286
2287         * DOM/DOMDocument.h:
2288         * DOM/DOMDocument.mm:
2289         (-[DOMDocument preferredStylesheetSet]):
2290         (-[DOMDocument selectedStylesheetSet]):
2291         (-[DOMDocument setSelectedStylesheetSet:]):
2292
2293 2018-05-15  Antoine Quint  <graouts@apple.com>
2294
2295         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2296         https://bugs.webkit.org/show_bug.cgi?id=185647
2297
2298         Reviewed by Dean Jackson.
2299
2300         Rename the Web Animations CSS integration flag.
2301
2302         * WebView/WebPreferenceKeysPrivate.h:
2303         * WebView/WebPreferences.mm:
2304         (+[WebPreferences initialize]):
2305         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2306         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2307         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2308         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2309         * WebView/WebPreferencesPrivate.h:
2310         * WebView/WebView.mm:
2311         (-[WebView _preferencesChanged:]):
2312
2313 2018-05-14  Daniel Bates  <dabates@apple.com>
2314
2315         Fix the Apple Internal build
2316
2317         See <rdar://problem/40237873> for more details.
2318
2319         * WebView/WebFullScreenController.mm:
2320         (-[WebFullScreenController enterFullScreen:]):
2321         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2322         (-[WebFullScreenController exitFullScreen]):
2323         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2324         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2325         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2326
2327 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2328
2329         WebHTMLView is not setting aside subviews when drawing.
2330
2331         https://bugs.webkit.org/show_bug.cgi?id=185561
2332         rdar://problem/40172894
2333
2334         Reviewed by Simon Fraser.
2335
2336         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2337
2338         * WebView/WebHTMLView.mm:
2339         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2340
2341 2018-05-07  Daniel Bates  <dabates@apple.com>
2342
2343         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2344         https://bugs.webkit.org/show_bug.cgi?id=185170
2345
2346         Reviewed by Per Arne Vollan.
2347
2348         * Misc/WebCache.mm:
2349         (+[WebCache empty]):
2350
2351 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2352
2353         Deprecate legacy WebView and friends
2354         https://bugs.webkit.org/show_bug.cgi?id=185279
2355         rdar://problem/33268700
2356
2357         Reviewed by Tim Horton.
2358
2359         Added deprecation macros to all the classes, extern strings, and enums.
2360
2361         * Configurations/WebKitLegacy.xcconfig:
2362         Added BUILDING_WEBKIT define to disable the deprecation macros.
2363         * DOM/DOMAbstractView.h:
2364         * DOM/DOMAttr.h:
2365         * DOM/DOMBlob.h:
2366         * DOM/DOMCDATASection.h:
2367         * DOM/DOMCSSCharsetRule.h:
2368         * DOM/DOMCSSFontFaceRule.h:
2369         * DOM/DOMCSSImportRule.h:
2370         * DOM/DOMCSSMediaRule.h:
2371         * DOM/DOMCSSPageRule.h:
2372         * DOM/DOMCSSPrimitiveValue.h:
2373         * DOM/DOMCSSRule.h:
2374         * DOM/DOMCSSRuleList.h:
2375         * DOM/DOMCSSStyleDeclaration.h:
2376         * DOM/DOMCSSStyleRule.h:
2377         * DOM/DOMCSSStyleSheet.h:
2378         * DOM/DOMCSSUnknownRule.h:
2379         * DOM/DOMCSSValue.h:
2380         * DOM/DOMCSSValueList.h:
2381         * DOM/DOMCharacterData.h:
2382         * DOM/DOMComment.h:
2383         * DOM/DOMCounter.h:
2384         * DOM/DOMDocument.h:
2385         * DOM/DOMDocumentFragment.h:
2386         * DOM/DOMDocumentType.h:
2387         * DOM/DOMElement.h:
2388         * DOM/DOMEntity.h:
2389         * DOM/DOMEntityReference.h:
2390         * DOM/DOMEvent.h:
2391         * DOM/DOMEventException.h:
2392         * DOM/DOMEventListener.h:
2393         * DOM/DOMEventTarget.h:
2394         * DOM/DOMException.h:
2395         * DOM/DOMFile.h:
2396         * DOM/DOMFileList.h:
2397         * DOM/DOMHTMLAnchorElement.h:
2398         * DOM/DOMHTMLAppletElement.h:
2399         * DOM/DOMHTMLAreaElement.h:
2400         * DOM/DOMHTMLBRElement.h:
2401         * DOM/DOMHTMLBaseElement.h:
2402         * DOM/DOMHTMLBaseFontElement.h:
2403         * DOM/DOMHTMLBodyElement.h:
2404         * DOM/DOMHTMLButtonElement.h:
2405         * DOM/DOMHTMLCanvasElement.h:
2406         * DOM/DOMHTMLCollection.h:
2407         * DOM/DOMHTMLDListElement.h:
2408         * DOM/DOMHTMLDirectoryElement.h:
2409         * DOM/DOMHTMLDivElement.h:
2410         * DOM/DOMHTMLDocument.h:
2411         * DOM/DOMHTMLElement.h:
2412         * DOM/DOMHTMLEmbedElement.h:
2413         * DOM/DOMHTMLFieldSetElement.h:
2414         * DOM/DOMHTMLFontElement.h:
2415         * DOM/DOMHTMLFormElement.h:
2416         * DOM/DOMHTMLFrameElement.h:
2417         * DOM/DOMHTMLFrameSetElement.h:
2418         * DOM/DOMHTMLHRElement.h:
2419         * DOM/DOMHTMLHeadElement.h:
2420         * DOM/DOMHTMLHeadingElement.h:
2421         * DOM/DOMHTMLHtmlElement.h:
2422         * DOM/DOMHTMLIFrameElement.h:
2423         * DOM/DOMHTMLImageElement.h:
2424         * DOM/DOMHTMLInputElement.h:
2425         * DOM/DOMHTMLLIElement.h:
2426         * DOM/DOMHTMLLabelElement.h:
2427         * DOM/DOMHTMLLegendElement.h:
2428         * DOM/DOMHTMLLinkElement.h:
2429         * DOM/DOMHTMLMapElement.h:
2430         * DOM/DOMHTMLMarqueeElement.h:
2431         * DOM/DOMHTMLMediaElement.h:
2432         * DOM/DOMHTMLMenuElement.h:
2433         * DOM/DOMHTMLMetaElement.h:
2434         * DOM/DOMHTMLModElement.h:
2435         * DOM/DOMHTMLOListElement.h:
2436         * DOM/DOMHTMLObjectElement.h:
2437         * DOM/DOMHTMLOptGroupElement.h:
2438         * DOM/DOMHTMLOptionElement.h:
2439         * DOM/DOMHTMLOptionsCollection.h:
2440         * DOM/DOMHTMLParagraphElement.h:
2441         * DOM/DOMHTMLParamElement.h:
2442         * DOM/DOMHTMLPreElement.h:
2443         * DOM/DOMHTMLQuoteElement.h:
2444         * DOM/DOMHTMLScriptElement.h:
2445         * DOM/DOMHTMLSelectElement.h:
2446         * DOM/DOMHTMLStyleElement.h:
2447         * DOM/DOMHTMLTableCaptionElement.h:
2448         * DOM/DOMHTMLTableCellElement.h:
2449         * DOM/DOMHTMLTableColElement.h:
2450         * DOM/DOMHTMLTableElement.h:
2451         * DOM/DOMHTMLTableRowElement.h:
2452         * DOM/DOMHTMLTableSectionElement.h:
2453         * DOM/DOMHTMLTextAreaElement.h:
2454         * DOM/DOMHTMLTitleElement.h:
2455         * DOM/DOMHTMLUListElement.h:
2456         * DOM/DOMHTMLVideoElement.h:
2457         * DOM/DOMImplementation.h:
2458         * DOM/DOMKeyboardEvent.h:
2459         * DOM/DOMMediaError.h:
2460         * DOM/DOMMediaList.h:
2461         * DOM/DOMMouseEvent.h:
2462         * DOM/DOMMutationEvent.h:
2463         * DOM/DOMNamedNodeMap.h:
2464         * DOM/DOMNode.h:
2465         * DOM/DOMNodeFilter.h:
2466         * DOM/DOMNodeIterator.h:
2467         * DOM/DOMNodeList.h:
2468         * DOM/DOMObject.h:
2469         * DOM/DOMOverflowEvent.h:
2470         * DOM/DOMProcessingInstruction.h:
2471         * DOM/DOMProgressEvent.h:
2472         * DOM/DOMRGBColor.h:
2473         * DOM/DOMRange.h:
2474         * DOM/DOMRangeException.h:
2475         * DOM/DOMRect.h:
2476         * DOM/DOMStyleSheet.h:
2477         * DOM/DOMStyleSheetList.h:
2478         * DOM/DOMText.h:
2479         * DOM/DOMTextEvent.h:
2480         * DOM/DOMTimeRanges.h:
2481         * DOM/DOMTokenList.h:
2482         * DOM/DOMTreeWalker.h:
2483         * DOM/DOMUIEvent.h:
2484         * DOM/DOMWheelEvent.h:
2485         * DOM/DOMXPathException.h:
2486         * DOM/DOMXPathExpression.h:
2487         * DOM/DOMXPathNSResolver.h:
2488         * DOM/DOMXPathResult.h:
2489         * History/WebBackForwardList.h:
2490         * History/WebHistory.h:
2491         * History/WebHistoryItem.h:
2492         * Misc/WebDownload.h:
2493         * Misc/WebKitErrors.h:
2494         * Plugins/WebPluginViewFactory.h:
2495         * WebView/WebArchive.h:
2496         * WebView/WebDataSource.h:
2497         * WebView/WebDocument.h:
2498         * WebView/WebEditingDelegate.h:
2499         * WebView/WebFormDelegate.h:
2500         * WebView/WebFrame.h:
2501         * WebView/WebFrameLoadDelegate.h:
2502         * WebView/WebFrameView.h:
2503         * WebView/WebPolicyDelegate.h:
2504         * WebView/WebPreferences.h:
2505         * WebView/WebPreferencesPrivate.h:
2506         * WebView/WebResourceLoadDelegate.h:
2507         * WebView/WebUIDelegate.h:
2508         * WebView/WebUIDelegatePrivate.h:
2509         * WebView/WebView.h:
2510         * WebView/WebViewPrivate.h:
2511         * postprocess-headers.sh:
2512         Remove step that converts WEBKIT macros to NS macros.
2513         Change it to just remove the macros on iOS builds.
2514
2515 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2516
2517         [MediaStream] remove WK1 support
2518         https://bugs.webkit.org/show_bug.cgi?id=185136
2519
2520         Reviewed by Youenn Fablet.
2521
2522         * WebCoreSupport/WebUserMediaClient.h: Removed.
2523         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2524         * WebView/WebView.mm:
2525         (-[WebView _commonInitializationWithFrameName:groupName:]):
2526         (-[WebView _preferencesChanged:]):
2527         (-[WebView _setUserMediaClient:]): Deleted.
2528         (-[WebView _userMediaClient]): Deleted.
2529         * WebView/WebViewData.h:
2530         * WebView/WebViewPrivate.h:
2531
2532 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2533
2534         WebAssembly: add support for stream APIs - JavaScript API
2535         https://bugs.webkit.org/show_bug.cgi?id=183442
2536
2537         Reviewed by Yusuke Suzuki and JF Bastien.
2538
2539         Add WEBASSEMBLY_STREAMINNG_API feature flag
2540
2541         * Configurations/FeatureDefines.xcconfig:
2542
2543 2018-04-30  JF Bastien  <jfbastien@apple.com>
2544
2545         Use some C++17 features
2546         https://bugs.webkit.org/show_bug.cgi?id=185135
2547
2548         Reviewed by Alex Christensen.
2549
2550         * Configurations/WebKitLegacy.xcconfig:
2551
2552 2018-04-27  Chris Dumez  <cdumez@apple.com>
2553
2554         Use WindowProxy instead of DOMWindow in our IDL
2555         https://bugs.webkit.org/show_bug.cgi?id=185022
2556
2557         Reviewed by Sam Weinig.
2558
2559         * DOM/DOMAbstractView.mm:
2560         (kit):
2561         (toWindowProxy):
2562         * DOM/DOMAbstractViewInternal.h:
2563         * DOM/DOMDocument.mm:
2564         (-[DOMDocument defaultView]):
2565         (-[DOMDocument getComputedStyle:pseudoElement:]):
2566         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2567         * DOM/DOMHTMLFrameElement.mm:
2568         (-[DOMHTMLFrameElement contentWindow]):
2569         * DOM/DOMHTMLIFrameElement.mm:
2570         (-[DOMHTMLIFrameElement contentWindow]):
2571         * DOM/DOMKeyboardEvent.mm:
2572         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2573         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2574         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2575         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2576         * DOM/DOMMouseEvent.mm:
2577         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2578         * DOM/DOMTextEvent.mm:
2579         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2580         * DOM/DOMUIEvent.mm:
2581         (-[DOMUIEvent view]):
2582         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2583         * DOM/DOMWheelEvent.mm:
2584         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2585
2586 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2587
2588         Implement rendering support for the color-filter CSS property
2589         https://bugs.webkit.org/show_bug.cgi?id=185047
2590         rdar://problem/39664967
2591
2592         Reviewed by Tim Horton.
2593         
2594         The body background should reflect the filtered color.
2595
2596         * WebView/WebFrame.mm:
2597         (-[WebFrame _bodyBackgroundColor]):
2598         * WebView/WebView.mm:
2599         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2600
2601 2018-04-26  Jer Noble  <jer.noble@apple.com>
2602
2603         WK_COCOA_TOUCH all the things.
2604         https://bugs.webkit.org/show_bug.cgi?id=185006
2605
2606         Reviewed by Tim Horton.
2607
2608         * Configurations/WebKitLegacy.xcconfig:
2609
2610 2018-04-26  Daniel Bates  <dabates@apple.com>
2611
2612         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2613         https://bugs.webkit.org/show_bug.cgi?id=184161
2614         <rdar://problem/39051645>
2615
2616         Reviewed by Dan Bernstein.
2617
2618         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2619         dropping a PDF embedded using an HTML image element into the same web view.
2620
2621         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2622         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2623         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2624         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2625         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2626         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2627         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2628         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2629         image document when navigated to directly. Since we can support dragging PDF document images we need to
2630         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2631         We need to do both such queries before falling back to using the main resource of the Web Archive as
2632         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2633         not an image document.
2634
2635         * Misc/WebNSPasteboardExtras.mm:
2636         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2637
2638 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2639
2640         Disable content filtering in minimal simulator mode
2641         https://bugs.webkit.org/show_bug.cgi?id=185027
2642         <rdar://problem/39736091>
2643
2644         Reviewed by Jer Noble.
2645
2646         * Configurations/FeatureDefines.xcconfig:
2647
2648 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2649
2650         [INTL] Implement Intl.PluralRules
2651         https://bugs.webkit.org/show_bug.cgi?id=184312
2652
2653         Reviewed by JF Bastien.
2654
2655         Added Intl.PluralRules feature flag.
2656
2657         * Configurations/FeatureDefines.xcconfig:
2658
2659 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2660
2661         Remove access to keychain from the WebContent process
2662         https://bugs.webkit.org/show_bug.cgi?id=184428
2663         <rdar://problem/13150903>
2664
2665         Reviewed by Brent Fulgham.
2666
2667         This patch does the followings:
2668         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2669         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2670         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2671
2672         * WebCoreSupport/WebChromeClient.h:
2673         * WebCoreSupport/WebChromeClient.mm:
2674         (WebChromeClient::signedPublicKeyAndChallengeString const):
2675         * WebView/WebUIDelegatePrivate.h:
2676
2677 2018-04-24  Jer Noble  <jer.noble@apple.com>
2678
2679         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2680         https://bugs.webkit.org/show_bug.cgi?id=184786
2681
2682         Reviewed by Tim Horton.
2683
2684         * Configurations/WebKitLegacy.xcconfig:
2685         * MigrateHeaders.make:
2686
2687 2018-04-23  Daniel Bates  <dabates@apple.com>
2688
2689         Implement Same-Site cookies
2690         https://bugs.webkit.org/show_bug.cgi?id=159464
2691         <rdar://problem/27196358>
2692
2693         Reviewed by Brent Fulgham.
2694
2695         Pass the Same-Site info through the strategy.
2696
2697         * WebCoreSupport/WebPlatformStrategies.h:
2698         * WebCoreSupport/WebPlatformStrategies.mm:
2699         (WebPlatformStrategies::cookiesForDOM):
2700         (WebPlatformStrategies::setCookiesFromDOM):
2701         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2702         (WebPlatformStrategies::getRawCookies):
2703
2704 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2705
2706         [LayoutFormattingContext] Initial commit.
2707         https://bugs.webkit.org/show_bug.cgi?id=184896
2708
2709         Reviewed by Antti Koivisto.
2710
2711         * Configurations/FeatureDefines.xcconfig:
2712
2713 2018-04-23  Daniel Bates  <dabates@apple.com>
2714
2715         Implement Same-Site cookies
2716         https://bugs.webkit.org/show_bug.cgi?id=159464
2717         <rdar://problem/27196358>
2718
2719         Reviewed by Brent Fulgham.
2720
2721         Pass the Same-Site info through the strategy.
2722
2723         * WebCoreSupport/WebPlatformStrategies.h:
2724         * WebCoreSupport/WebPlatformStrategies.mm:
2725         (WebPlatformStrategies::cookiesForDOM):
2726         (WebPlatformStrategies::setCookiesFromDOM):
2727         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2728         (WebPlatformStrategies::getRawCookies):
2729
2730 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2731
2732         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=184851
2735         rdar://problem/39611236
2736
2737         Reviewed by Tim Horton.
2738
2739         * WebView/WebView.mm:
2740         (-[WebView _commonInitializationWithFrameName:groupName:]):
2741         (-[WebView effectiveAppearanceDidChange]):
2742         Added a null check and call the code later in initialization.
2743
2744 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2745
2746         Adjust geolocation feature flag
2747         https://bugs.webkit.org/show_bug.cgi?id=184856
2748
2749         Reviewed by Wenson Hsieh.
2750
2751         * Configurations/FeatureDefines.xcconfig:
2752
2753 2018-04-18  Jer Noble  <jer.noble@apple.com>
2754
2755         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2756         https://bugs.webkit.org/show_bug.cgi?id=184762
2757
2758         Reviewed by Dan Bernstein.
2759
2760         * Configurations/WebKitLegacy.xcconfig:
2761
2762 2018-04-20  Youenn Fablet  <youenn@apple.com>
2763
2764         Make PluginData cache its web visible plugins
2765         https://bugs.webkit.org/show_bug.cgi?id=184421
2766
2767         Reviewed by Chris Dumez.
2768
2769         * WebCoreSupport/WebPluginInfoProvider.h:
2770         * WebCoreSupport/WebPluginInfoProvider.mm:
2771         (WebPluginInfoProvider::pluginInfo):
2772         (WebPluginInfoProvider::webVisiblePluginInfo):
2773
2774 2018-04-19  Chris Dumez  <cdumez@apple.com>
2775
2776         Rename JSDOMWindowProxy to JSWindowProxy
2777         https://bugs.webkit.org/show_bug.cgi?id=184797
2778
2779         Reviewed by Sam Weinig.
2780
2781         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2782
2783         * DOM/DOMUtility.mm:
2784         (createDOMWrapper):
2785         * WebView/WebFrame.mm:
2786         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2787
2788 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2789
2790         Enable Objective-C weak references
2791         <https://webkit.org/b/184789>
2792         <rdar://problem/39571716>
2793
2794         Reviewed by Dan Bernstein.
2795
2796         * Configurations/Base.xcconfig:
2797         (CLANG_ENABLE_OBJC_WEAK): Enable.
2798
2799 2018-04-18  Chris Dumez  <cdumez@apple.com>
2800
2801         Rename WindowProxyController to WindowProxy
2802         https://bugs.webkit.org/show_bug.cgi?id=184756
2803
2804         Reviewed by Sam Weinig.
2805
2806         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2807         needed use WindowProxyController type, which was a bit confusing.
2808
2809         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2810         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2811         * WebView/WebFrame.mm:
2812         (-[WebFrame _attachScriptDebugger]):
2813
2814 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2815
2816         Unreviewed rollout of r230632. Regression in memory usage.
2817
2818         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2819
2820         * WebView/WebPreferences.mm:
2821         (+[WebPreferences initialize]):
2822
2823 2018-04-17  Chris Dumez  <cdumez@apple.com>
2824
2825         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2826         https://bugs.webkit.org/show_bug.cgi?id=184678
2827         <rdar://problem/39422122>
2828
2829         Reviewed by Alex Christensen.
2830
2831         Add new parameter to dispatchDecidePolicyForNavigationAction.
2832
2833         * WebCoreSupport/WebFrameLoaderClient.h:
2834         * WebCoreSupport/WebFrameLoaderClient.mm:
2835         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2836
2837 2018-04-13  Chris Dumez  <cdumez@apple.com>
2838
2839         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2840         https://bugs.webkit.org/show_bug.cgi?id=184591
2841
2842         Reviewed by Sam Weinig.
2843
2844         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2845         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2846         This is work towards fixing Bug 184515.
2847
2848         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2849         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2850         * WebView/WebFrame.mm:
2851         (-[WebFrame _attachScriptDebugger]):
2852
2853 2018-04-12  Antoine Quint  <graouts@apple.com>
2854
2855         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2856         https://bugs.webkit.org/show_bug.cgi?id=184569
2857         <rdar://problem/38671301>
2858
2859         Reviewed by Jon Lee.
2860
2861         * WebView/WebPreferences.mm:
2862
2863 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2864
2865         [WTF] Remove StaticLock
2866         https://bugs.webkit.org/show_bug.cgi?id=184332
2867
2868         Reviewed by Mark Lam.
2869
2870         * DOM/DOMInternal.mm:
2871         (getDOMWrapper):
2872         (addDOMWrapper):
2873         (removeDOMWrapper):
2874
2875 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2876
2877         Failures from mach port reference handling should be fatal
2878         https://bugs.webkit.org/show_bug.cgi?id=184202
2879         <rdar://problem/37771114>
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * Plugins/Hosted/NetscapePluginHostManager.mm:
2884         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
2885
2886 2018-04-03  Andy Estes  <aestes@apple.com>
2887
2888         [Mac] Prioritize file promises over filenames during drag and drop
2889         https://bugs.webkit.org/show_bug.cgi?id=184237
2890         <rdar://problem/38278076>
2891
2892         Reviewed by Wenson Hsieh.
2893
2894         * WebView/WebView.mm:
2895         (-[WebView performDragOperation:]):
2896
2897 2018-04-03  Chris Dumez  <cdumez@apple.com>
2898
2899         Drop MainFrame class
2900         https://bugs.webkit.org/show_bug.cgi?id=184191
2901
2902         Reviewed by Darin Adler.
2903
2904         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2905         relationship between the Page and the MainFrame.
2906
2907         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2908
2909         * WebCoreSupport/WebDragClient.mm:
2910         * WebCoreSupport/WebFrameLoaderClient.mm:
2911         * WebCoreSupport/WebInspectorClient.mm:
2912         * WebCoreSupport/WebPlatformStrategies.mm:
2913         * WebCoreSupport/WebPluginInfoProvider.mm:
2914         * WebView/WebFrame.mm:
2915         * WebView/WebFrameView.mm:
2916         * WebView/WebHTMLView.mm:
2917         * WebView/WebView.mm:
2918
2919 2018-04-02  Jer Noble  <jer.noble@apple.com>
2920
2921         Enable Legacy EME for all WebKit & WebKitLegacy clients
2922         https://bugs.webkit.org/show_bug.cgi?id=184018
2923         <rdar://problem/34887387>
2924
2925         Reviewed by Eric Carlson.
2926
2927         * WebView/WebPreferences.mm:
2928         (+[WebPreferences initialize]):
2929
2930 2018-03-29  JF Bastien  <jfbastien@apple.com>
2931
2932         Use Forward.h instead of forward-declaring WTF::String
2933         https://bugs.webkit.org/show_bug.cgi?id=184172
2934         <rdar://problem/39026146>
2935
2936         Reviewed by Yusuke Suzuki.
2937
2938         As part of #184164 I'm changing WTF::String, and the forward
2939         declarations are just wrong because I'm making it templated. We
2940         should use Forward.h anyways, so do that instead.
2941
2942         * WebView/WebScriptDebugger.h:
2943
2944 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2945
2946         Protect against invalid mach ports returned by mach_port_request_notification
2947         https://bugs.webkit.org/show_bug.cgi?id=184106
2948         <rdar://problem/37865316>
2949
2950         Reviewed by Chris Dumez.
2951
2952         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2953         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
2954         and clean up if it experienced an error.
2955         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
2956
2957 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2958
2959         Avoid uninitialized mach ports
2960         https://bugs.webkit.org/show_bug.cgi?id=184090
2961         <rdar://problem/37261129>
2962
2963         Reviewed by Chris Dumez.
2964
2965         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
2966         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
2967         there is a potential for us to try to use invalid ports.
2968
2969         We should always check return values, and ensure that the mach port variables we seek to initialize are
2970         kept in a valid state.
2971
2972         Reviewed by Chris Dumez.
2973
2974         * Plugins/Hosted/NetscapePluginHostManager.h:
2975         * Plugins/Hosted/NetscapePluginHostManager.mm:
2976         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
2977         port is passed to an API function.
2978         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
2979         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
2980         * Plugins/Hosted/NetscapePluginHostProxy.h:
2981         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2982         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
2983         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
2984         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
2985         (WKPCStatusText): Ditto.
2986         (WKPCLoadURL): Ditto.
2987         (WKPCCancelLoadURL): Ditto.
2988         (WKPCInvalidateRect): Ditto.
2989         (WKPCGetScriptableNPObjectReply): Ditto.
2990         (WKPCBooleanReply): Ditto.
2991         (WKPCBooleanAndDataReply): Ditto.
2992         (WKPCInstantiatePluginReply): Ditto.
2993         (WKPCGetWindowNPObject): Ditto.
2994         (WKPCGetPluginElementNPObject): Ditto.
2995         (WKPCForgetBrowserObject): Ditto.
2996         (WKPCEvaluate): Ditto.
2997         (WKPCGetStringIdentifier): Ditto.
2998         (WKPCGetIntIdentifier): Ditto.
2999         (WKPCInvoke): Ditto.
3000         (WKPCInvokeDefault): Ditto.
3001         (WKPCConstruct): Ditto.
3002         (WKPCGetProperty): Ditto.
3003         (WKPCSetProperty): Ditto.
3004         (WKPCRemoveProperty): Ditto.
3005         (WKPCHasProperty): Ditto.
3006         (WKPCHasMethod): Ditto.
3007         (WKPCIdentifierInfo): Ditto.
3008         (WKPCEnumerate): Ditto.
3009         (WKPCSetMenuBarVisible): Ditto.
3010         (WKPCSetFullscreenWindowIsShowing): Ditto.
3011         (WKPCSetModal): Ditto.
3012         (WKPCGetCookies): Ditto.
3013         (WKPCGetProxy): Ditto.
3014         (WKPCSetCookies): Ditto.
3015         (WKPCGetAuthenticationInfo): Ditto.
3016         (WKPCConvertPoint): Ditto.
3017         (WKPCLayerHostingModeChanged): Ditto.
3018         (WKPCSetException): Ditto.
3019
3020 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3021
3022         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3023         https://bugs.webkit.org/show_bug.cgi?id=184030
3024         <rdar://problem/38895281>
3025
3026         Reviewed by Dan Bernstein.
3027
3028         * Configurations/Base.xcconfig:
3029
3030 2018-03-26  Chris Dumez  <cdumez@apple.com>
3031
3032         Use SecurityOriginData more consistently in Service Worker code
3033         https://bugs.webkit.org/show_bug.cgi?id=183969
3034
3035         Reviewed by Darin Adler.
3036
3037         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3038
3039         * Storage/WebDatabaseManager.mm:
3040         (-[WebDatabaseManager databasesWithOrigin:]):
3041         (-[WebDatabaseManager deleteOrigin:]):
3042         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3043         * Storage/WebDatabaseQuotaManager.mm:
3044         (-[WebDatabaseQuotaManager usage]):
3045         (-[WebDatabaseQuotaManager quota]):
3046         (-[WebDatabaseQuotaManager setQuota:]):
3047         * Storage/WebStorageManager.mm:
3048         (-[WebStorageManager deleteOrigin:]):
3049         * WebCoreSupport/WebSecurityOrigin.mm:
3050         (-[WebSecurityOrigin databaseIdentifier]):
3051         (-[WebSecurityOrigin usage]):
3052         (-[WebSecurityOrigin quota]):
3053         (-[WebSecurityOrigin setQuota:]):
3054
3055 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3056
3057         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3058         https://bugs.webkit.org/show_bug.cgi?id=183911
3059         <rdar://problem/38762306>
3060
3061         Reviewed by Youenn Fablet.
3062
3063         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3064
3065         * WebView/WebView.mm:
3066         (+[WebView initialize]):
3067
3068 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3069
3070         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3071         https://bugs.webkit.org/show_bug.cgi?id=183965
3072
3073         Reviewed by Chris Dumez.
3074
3075         * WebCoreSupport/WebFrameLoaderClient.h:
3076         * WebCoreSupport/WebFrameLoaderClient.mm:
3077         (WebFrameLoaderClient::willCacheResponse const):
3078
3079 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3080
3081         Unreviewed, rolling out r229954.
3082         https://bugs.webkit.org/show_bug.cgi?id=184000
3083
3084         Caused many layout tests to crash on Apple High Sierra,
3085         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3086         by dydz on #webkit).
3087
3088         Reverted changeset:
3089
3090         "Use SecurityOriginData more consistently in Service Worker
3091         code"
3092         https://bugs.webkit.org/show_bug.cgi?id=183969
3093         https://trac.webkit.org/changeset/229954
3094
3095 2018-03-24  Chris Dumez  <cdumez@apple.com>
3096
3097         Use SecurityOriginData more consistently in Service Worker code
3098         https://bugs.webkit.org/show_bug.cgi?id=183969
3099
3100         Reviewed by Darin Adler.
3101
3102         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3103
3104         * Storage/WebDatabaseManager.mm:
3105         (-[WebDatabaseManager databasesWithOrigin:]):
3106         (-[WebDatabaseManager deleteOrigin:]):
3107         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3108         * Storage/WebDatabaseQuotaManager.mm:
3109         (-[WebDatabaseQuotaManager usage]):
3110         (-[WebDatabaseQuotaManager quota]):
3111         (-[WebDatabaseQuotaManager setQuota:]):
3112         * Storage/WebStorageManager.mm:
3113         (-[WebStorageManager deleteOrigin:]):
3114         * WebCoreSupport/WebSecurityOrigin.mm:
3115         (-[WebSecurityOrigin databaseIdentifier]):
3116         (-[WebSecurityOrigin usage]):
3117         (-[WebSecurityOrigin quota]):
3118         (-[WebSecurityOrigin setQuota:]):
3119
3120 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3121
3122         Fix the build
3123
3124         * WebView/WebView.mm:
3125
3126 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3127
3128         Fix the build with no pasteboard
3129         https://bugs.webkit.org/show_bug.cgi?id=183973
3130
3131         Reviewed by Dan Bernstein.
3132
3133         * Configurations/FeatureDefines.xcconfig:
3134         * WebView/WebView.mm:
3135         (-[WebView _requestStartDataInteraction:globalPosition:]):
3136         (-[WebView _getDataInteractionData]):
3137         (-[WebView _dataOperationTextIndicator]):
3138         (-[WebView _dragSourceAction]):
3139         (-[WebView _draggedLinkTitle]):
3140         (-[WebView _draggedLinkURL]):
3141         (-[WebView _draggedElementBounds]):
3142         (-[WebView _enteredDataInteraction:client:global:operation:]):
3143         (-[WebView _updatedDataInteraction:client:global:operation:]):
3144         (-[WebView _exitedDataInteraction:client:global:operation:]):
3145         (-[WebView _performDataInteraction:client:global:operation:]):
3146         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3147         (-[WebView _endedDataInteraction:global:]):
3148         (-[WebView _dataInteractionCaretRect]):
3149         * WebView/WebViewPrivate.h:
3150
3151 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3152
3153         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3154         https://bugs.webkit.org/show_bug.cgi?id=183960
3155         <rdar://problem/38812356>
3156
3157         Reviewed by Dan Bernstein.
3158
3159         * Configurations/WebKitLegacy.xcconfig:
3160
3161 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3162
3163         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3164         https://bugs.webkit.org/show_bug.cgi?id=183954
3165         <rdar://problem/38808858>
3166
3167         Reviewed by Dan Bernstein.
3168
3169         * WebView/WebPreferences.mm:
3170         (-[WebPreferences setAudioSessionCategoryOverride:]):
3171
3172 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3173
3174         Adopt WK_PLATFORM_NAME in WebKitLegacy
3175         https://bugs.webkit.org/show_bug.cgi?id=183948
3176         <rdar://problem/38803908>
3177
3178         Reviewed by Dan Bernstein.
3179
3180         * Configurations/WebKitLegacy.xcconfig:
3181         * MigrateHeaders.make:
3182         * postprocess-headers.sh:
3183
3184 2018-03-23  Brady Eidson  <beidson@apple.com>
3185
3186         Go to back/forward list items after a process-swapped navigation.
3187         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3188
3189         Reviewed by Andy Estes.
3190
3191         * WebView/WebView.mm:
3192         (-[WebView _loadBackForwardListFromOtherView:]):
3193         (-[WebView goToBackForwardItem:]):
3194
3195 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3196
3197         Improve readability of WebCore's OTHER_LDFLAGS
3198         https://bugs.webkit.org/show_bug.cgi?id=183909
3199         <rdar://problem/38760992>
3200
3201         Reviewed by Dan Bernstein.
3202
3203         * Configurations/Base.xcconfig:
3204         * Configurations/FeatureDefines.xcconfig:
3205
3206 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3207
3208         Enable the minimal simulator feature flag when appropriate
3209         https://bugs.webkit.org/show_bug.cgi?id=183807
3210
3211         Reviewed by Dan Bernstein.
3212
3213         * Configurations/FeatureDefines.xcconfig:
3214
3215 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3216
3217         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3218         https://bugs.webkit.org/show_bug.cgi?id=183758
3219         <rdar://problem/38017644>
3220
3221         Reviewed by Dan Bernstein.
3222
3223         * Configurations/FeatureDefines.xcconfig:
3224
3225 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3226
3227         Clear style colors when setting default appearance
3228         https://bugs.webkit.org/show_bug.cgi?id=183759
3229
3230         Reviewed by Tim Horton.
3231
3232         Colors are cached and need to be cleared and recalculated.
3233         Refactor to do all style recalcs together.
3234
3235         * WebView/WebView.mm:
3236         (-[WebView _setDefaultAppearanceAndClearStyle]):
3237         (-[WebView _setUseSystemAppearance:]):
3238         (-[WebView effectiveAppearanceDidChange]):
3239
3240 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3241
3242         Unreviewed, another quick fix for r229699
3243
3244         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3245
3246         * Configurations/FeatureDefines.xcconfig:
3247
3248 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3249
3250         Ensure that style is updated when the effective appearance changes
3251         https://bugs.webkit.org/show_bug.cgi?id=183690
3252         <rdar://problem/38385900>
3253
3254         Reviewed by Tim Horton and Wenson Hsieh.
3255
3256         Respond to and respect the effective appearance changing.
3257
3258         * WebView/WebView.mm:
3259         (-[WebView _setUseSystemAppearance:]):
3260         (-[WebView effectiveAppearanceDidChange]):
3261
3262 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3263
3264         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3265         https://bugs.webkit.org/show_bug.cgi?id=183677
3266
3267         Reviewed by Tim Horton.
3268
3269         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3270
3271         * DOM/DOM.mm:
3272         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3273
3274 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3275
3276         Fix the build after r229567
3277
3278         * Configurations/FeatureDefines.xcconfig:
3279
3280 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3281
3282         Stop using SDK conditionals to control feature definitions
3283         https://bugs.webkit.org/show_bug.cgi?id=183430
3284         <rdar://problem/38251619>
3285
3286         Reviewed by Dan Bernstein.
3287
3288         * Configurations/FeatureDefines.xcconfig:
3289         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3290
3291 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3292
3293         Runtime flag for link prefetch and remove link subresource.
3294         https://bugs.webkit.org/show_bug.cgi?id=183540
3295
3296         Reviewed by Chris Dumez.
3297
3298         Remove the LINK_PREFETCH build time flag.
3299
3300         * Configurations/FeatureDefines.xcconfig:
3301
3302 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3303
3304         Remove GridLayout runtime flag
3305         https://bugs.webkit.org/show_bug.cgi?id=183484
3306
3307         Reviewed by Myles C. Maxfield.
3308
3309         The Grid Layout feature has been enabled by default for almost a
3310         year, so I think it's time to remove the runtime flag and the
3311
3312         * WebView/WebPreferenceKeysPrivate.h:
3313         * WebView/WebPreferences.mm:
3314         (+[WebPreferences initialize]):
3315         * WebView/WebPreferencesPrivate.h:
3316         * WebView/WebView.mm:
3317         (-[WebView _preferencesChanged:]):
3318
3319 2018-03-12  Antoine Quint  <graouts@apple.com>
3320
3321         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3322         https://bugs.webkit.org/show_bug.cgi?id=183504
3323         <rdar://problem/38372965>
3324
3325         Reviewed by Dean Jackson and Jon Lee.
3326
3327         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3328         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3329
3330         * WebView/WebPreferenceKeysPrivate.h:
3331         * WebView/WebPreferences.mm:
3332         (+[WebPreferences initialize]):
3333         (-[WebPreferences setModernMediaControlsEnabled:]):
3334         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3335         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3336         * WebView/WebPreferencesPrivate.h:
3337         * WebView/WebView.mm:
3338         (-[WebView _preferencesChanged:]):
3339
3340 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3341
3342         Media query for default appearance
3343         https://bugs.webkit.org/show_bug.cgi?id=183539
3344         <rdar://problem/38326388>
3345
3346         Reviewed by Tim Horton.
3347
3348         Write a media query to evaluate appearance.
3349
3350         * WebView/WebView.mm:
3351         (-[WebView _commonInitializationWithFrameName:groupName:]):
3352         (-[WebView _setUseSystemAppearance:]):
3353
3354 2018-03-09  Andy Estes  <aestes@apple.com>
3355
3356         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3357         https://bugs.webkit.org/show_bug.cgi?id=183489
3358         <rdar://problem/38267517>
3359
3360         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3361         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3362         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3363         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3364         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3365
3366         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3367         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3368         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3369         drop destination.
3370
3371         Reviewed by Wenson Hsieh.
3372
3373         * WebView/WebView.mm:
3374         (-[WebView performDragOperation:]):
3375
3376 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3377
3378         Allow WebViews to disable system appearance
3379         https://bugs.webkit.org/show_bug.cgi?id=183418
3380         <rdar://problem/36975642>
3381
3382         Reviewed by Tim Horton.
3383
3384         Allow webviews to choose whether or not to follow the default system appearance.
3385
3386         * WebView/WebView.mm:
3387         (-[WebView _setUseSystemAppearance:]):
3388         (-[WebView _useSystemAppearance]):
3389         * WebView/WebViewPrivate.h:
3390
3391 2018-03-08  Youenn Fablet  <youenn@apple.com>
3392
3393         libwebrtc update broke internal builds
3394         https://bugs.webkit.org/show_bug.cgi?id=183454
3395
3396         Reviewed by Eric Carlson.
3397
3398         * Configurations/WebKitLegacy.xcconfig:
3399
3400 2018-03-08  Chris Dumez  <cdumez@apple.com>
3401
3402         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3403         https://bugs.webkit.org/show_bug.cgi?id=183455
3404         <rdar://problem/38191749>
3405
3406         Reviewed by Youenn Fablet.
3407
3408         Add a null check for the page as we have evidence from crashes that it can be null.
3409         Other functions in WebFrameNetworkingContext already null check the page as well,
3410         not just the frame so this is consistent.
3411
3412         * WebCoreSupport/WebFrameNetworkingContext.mm:
3413         (WebFrameNetworkingContext::storageSession const):
3414
3415 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3416
3417         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3418         https://bugs.webkit.org/show_bug.cgi?id=183429
3419
3420         Reviewed by Mark Lam.
3421
3422         * DOM/DOM.mm:
3423         (+[DOMNode _nodeFromJSWrapper:]):
3424         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3425         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3426         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3427         * Plugins/Hosted/ProxyInstance.mm:
3428         (WebKit::ProxyInstance::invokeMethod):
3429         * WebView/WebView.mm:
3430         (aeDescFromJSValue):
3431
3432 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3433
3434         Stop linking ApplicationServices directly
3435         https://bugs.webkit.org/show_bug.cgi?id=182867
3436         <rdar://problem/38252142>
3437
3438         Reviewed by Alex Christensen.
3439
3440         The frameworks that we use that live inside ApplicationServices
3441         have mostly moved out, so import them directly.
3442
3443         * Carbon/CarbonUtils.h:
3444         * WebKitPrefix.h:
3445         * WebView/WebHTMLView.mm:
3446         * WebView/WebPDFView.mm:
3447
3448 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3449
3450         Sort and separate FeatureDefines.xcconfig
3451         https://bugs.webkit.org/show_bug.cgi?id=183427
3452
3453         Reviewed by Dan Bernstein.
3454
3455         * Configurations/FeatureDefines.xcconfig:
3456         Sort and split FeatureDefines into paragraphs
3457         (to make it easier to sort later).
3458
3459 2018-03-07  Youenn Fablet  <youenn@apple.com>
3460
3461         Match unsupported plugins based on domains and not origin
3462         https://bugs.webkit.org/show_bug.cgi?id=183384
3463
3464         Reviewed by Chris Dumez.
3465
3466         * WebCoreSupport/WebPluginInfoProvider.h:
3467         * WebCoreSupport/WebPluginInfoProvider.mm:
3468         (WebPluginInfoProvider::getPluginInfo):
3469         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3470
3471 2018-03-05  Andy Estes  <aestes@apple.com>
3472
3473         [Mac] Teach WebCore::Pasteboard about file promise drags
3474         https://bugs.webkit.org/show_bug.cgi?id=183314
3475         <rdar://problem/38105493>
3476
3477         Reviewed by Darin Adler.
3478
3479         Added a FIXME comment.
3480
3481         * WebView/WebView.mm:
3482         (-[WebView performDragOperation:]):
3483
3484 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3485
3486         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3487         https://bugs.webkit.org/show_bug.cgi?id=183312
3488
3489         Reviewed by Mark Lam.
3490
3491         Remove wtf/CurrentTime.h include pragma.
3492
3493         * WebView/WebFrame.mm:
3494         * WebView/WebPDFView.mm:
3495
3496 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3497
3498         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3499         https://bugs.webkit.org/show_bug.cgi?id=183283
3500         <rdar://problem/38062148>
3501
3502         Reviewed by Sam Weinig.
3503
3504         * Configurations/FeatureDefines.xcconfig:
3505
3506 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3507
3508         Reduce use of NetworkingContext in WebKit
3509         https://bugs.webkit.org/show_bug.cgi?id=183213
3510
3511         Reviewed by Brady Eidson.
3512
3513         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3514         (WebKit::NetscapePluginInstanceProxy::getProxy):
3515         * Plugins/WebNetscapePluginView.mm:
3516         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3517
3518 2018-02-17  Darin Adler  <darin@apple.com>
3519
3520         Prepare for ExtendedColor changes (first step)
3521         https://bugs.webkit.org/show_bug.cgi?id=182904
3522
3523         Reviewed by Sam Weinig.
3524
3525         * Misc/WebKitNSStringExtras.mm:
3526         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3527
3528 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3529
3530         Remove currentTime() / currentTimeMS()
3531         https://bugs.webkit.org/show_bug.cgi?id=183052
3532
3533         Reviewed by Mark Lam.
3534
3535         * WebCoreSupport/WebFrameLoaderClient.h:
3536         * WebCoreSupport/WebFrameLoaderClient.mm:
3537         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3538
3539 2018-02-16  Youenn Fablet  <youenn@apple.com>
3540
3541         Allow specifying which plug-ins are supported
3542         https://bugs.webkit.org/show_bug.cgi?id=182748
3543
3544         Reviewed by Chris Dumez.
3545
3546         * WebCoreSupport/WebPluginInfoProvider.h:
3547         * WebCoreSupport/WebPluginInfoProvider.mm:
3548         (WebPluginInfoProvider::getPluginInfo):
3549         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3550
3551 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3552
3553         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3554         https://bugs.webkit.org/show_bug.cgi?id=182882
3555         <rdar://problem/35672661>
3556
3557         Reviewed by Dan Bernstein.
3558
3559         Make sure the smart pointer hold the collection of subviews lives at least as
3560         long as the loop using it.
3561
3562         * WebView/WebHTMLView.mm:
3563         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3564
3565 2018-02-14  Daniel Bates  <dabates@apple.com>
3566
3567         Disallow cross-origin subresources from asking for credentials
3568         https://bugs.webkit.org/show_bug.cgi?id=182579
3569         <rdar://problem/36162271>
3570
3571         Reviewed by Andy Estes.
3572
3573         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3574         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3575
3576         * WebView/WebPreferenceKeysPrivate.h:
3577         * WebView/WebPreferences.mm:
3578         (+[WebPreferences initialize]):
3579         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3580         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3581         * WebView/WebPreferencesPrivate.h:
3582         * WebView/WebView.mm:
3583         (-[WebView _preferencesChanged:]):
3584
3585 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3586
3587         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3588         https://bugs.webkit.org/show_bug.cgi?id=182738
3589
3590         Reviewed by Darin Adler.
3591
3592         * ForwardingHeaders/collector/handles/Global.h: Removed.
3593         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3594         * ForwardingHeaders/runtime/Completion.h: Removed.
3595         * ForwardingHeaders/runtime/Error.h: Removed.
3596         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3597         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3598         * ForwardingHeaders/runtime/JSLock.h: Removed.
3599         * ForwardingHeaders/runtime/JSObject.h: Removed.
3600         * ForwardingHeaders/runtime/JSString.h: Removed.
3601         * ForwardingHeaders/runtime/Protect.h: Removed.
3602         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3603
3604 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3605
3606         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3607         https://bugs.webkit.org/show_bug.cgi?id=182641
3608
3609         Reviewed by Dan Bernstein.
3610
3611         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3612         https://trac.webkit.org/changeset/228308.
3613
3614         * WebView/WebVideoFullscreenController.h:
3615         * WebView/WebVideoFullscreenHUDWindowController.mm:
3616         * WebView/WebWindowAnimation.h:
3617         * WebView/WebWindowAnimation.mm:
3618         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3619         (WebCore::scaledRect): Deleted.
3620         (WebCore::squaredDistance): Deleted.
3621
3622 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3623
3624         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3625
3626         * WebView/WebWindowAnimation.mm:
3627         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3628
3629 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3630
3631         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3632         https://bugs.webkit.org/show_bug.cgi?id=182615
3633
3634         Reviewed by Eric Carlson.
3635
3636         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3637         Ideally, we should not reference NSApp in WebCore.
3638
3639         * WebView/WebFullScreenController.mm:
3640         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3641         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3642         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3643         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3644         * WebView/WebView.mm:
3645         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3646         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3647
3648 2018-01-13  Darin Adler  <darin@apple.com>
3649
3650         Event improvements
3651         https://bugs.webkit.org/show_bug.cgi?id=179591
3652
3653         Reviewed by Chris Dumez.
3654
3655         * DOM/DOMWheelEvent.mm:
3656         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3657         Call initWebKitWheelEvent.
3658
3659         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3660         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3661         * WebView/WebFrame.mm: Ditto.
3662
3663         * WebView/WebHTMLView.mm:
3664         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3665         underlyingPlatformEvent.
3666         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3667
3668         * WebView/WebScriptWorld.mm:
3669         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3670
3671         * WebView/WebView.mm: Removed include of ScriptValue.h.
3672
3673 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3674
3675         Remove WebCore/ForwardingHeaders directory
3676         https://bugs.webkit.org/show_bug.cgi?id=182347
3677
3678         Reviewed by Keith Miller.
3679
3680         * Carbon/CarbonWindowAdapter.mm:
3681         * DOM/WebDOMOperations.mm:
3682         * History/WebBackForwardList.mm:
3683         * History/WebHistoryItem.mm:
3684         * Misc/WebCache.mm:
3685         * Misc/WebElementDictionary.mm:
3686         * Misc/WebIconDatabase.mm:
3687         * Misc/WebStringTruncator.mm:
3688         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3689         * Plugins/Hosted/ProxyInstance.mm:
3690         * Plugins/Hosted/ProxyRuntimeObject.mm:
3691         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3692         * Plugins/WebBaseNetscapePluginView.mm:
3693         * Plugins/WebBasePluginPackage.mm:
3694         * Plugins/WebNetscapePluginStream.mm:
3695         * Plugins/WebNetscapePluginView.mm:
3696         * Plugins/WebPluginController.mm:
3697         * WebCoreSupport/WebEditorClient.mm:
3698         * WebCoreSupport/WebFrameLoaderClient.mm:
3699         * WebCoreSupport/WebInspectorClient.h:
3700         * WebCoreSupport/WebInspectorClient.mm:
3701         * WebView/WebDataSource.mm:
3702         * WebView/WebFrame.mm:
3703         * WebView/WebHTMLRepresentation.mm:
3704         * WebView/WebHTMLView.mm:
3705         * WebView/WebPreferences.mm:
3706         * WebView/WebScriptDebugDelegate.mm:
3707         * WebView/WebScriptDebugger.h:
3708         * WebView/WebTextIterator.mm:
3709         * WebView/WebView.mm:
3710         * WebView/WebViewData.mm:
3711
3712 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3713
3714         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3715         https://bugs.webkit.org/show_bug.cgi?id=182312
3716
3717         Reviewed by Michael Catanzaro.
3718
3719         * WebKitPrefix.h:
3720
3721 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3722
3723         [WebAuthN] Add a compile-time feature flag
3724         https://bugs.webkit.org/show_bug.cgi?id=182211
3725         <rdar://problem/36936365>
3726
3727         Reviewed by Brent Fulgham.
3728
3729         * Configurations/FeatureDefines.xcconfig:
3730
3731 2018-01-27  Dan Bernstein  <mitz@apple.com>
3732
3733         HaveInternalSDK includes should be "#include?"
3734         https://bugs.webkit.org/show_bug.cgi?id=179670
3735
3736         * Configurations/Base.xcconfig:
3737
3738 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3739
3740         Remove unused QTKit preference
3741         https://bugs.webkit.org/show_bug.cgi?id=181968
3742
3743         Reviewed by Alexey Proskuryakov.
3744
3745         * WebView/WebPreferenceKeysPrivate.h:
3746         * WebView/WebPreferences.mm:
3747         (+[WebPreferences initialize]):
3748         (-[WebPreferences setQTKitEnabled:]): Deleted.
3749         (-[WebPreferences isQTKitEnabled]): Deleted.
3750         * WebView/WebPreferencesPrivate.h:
3751         * WebView/WebView.mm:
3752         (-[WebView _preferencesChanged:]):
3753
3754 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3755
3756         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3757         https://bugs.webkit.org/show_bug.cgi?id=182037
3758         <rdar://problem/36747812>
3759
3760         Reviewed by Ryosuke Niwa.
3761
3762         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3763         for more details.
3764
3765         * WebView/WebHTMLRepresentation.mm:
3766         (-[WebHTMLRepresentation elementWithName:inForm:]):
3767         (-[WebHTMLRepresentation controlsInForm:]):
3768
3769 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3770
3771         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3772         https://bugs.webkit.org/show_bug.cgi?id=181961
3773
3774         Reviewed by Michael Catanzaro.
3775
3776         * WebView/WebPreferences.mm:
3777
3778 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3779
3780         Unreviewed, rolling out r227437.
3781         https://bugs.webkit.org/show_bug.cgi?id=182011
3782
3783         broke build (Requested by alexchristensen on #webkit).
3784
3785         Reverted changeset:
3786
3787         "Remove unused QTKit preference"
3788         https://bugs.webkit.org/show_bug.cgi?id=181968
3789         https://trac.webkit.org/changeset/227437
3790
3791 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3792
3793         Remove unused QTKit preference
3794         https://bugs.webkit.org/show_bug.cgi?id=181968
3795
3796         Reviewed by Alexey Proskuryakov.
3797
3798         * WebView/WebPreferenceKeysPrivate.h:
3799         * WebView/WebPreferences.mm:
3800         (+[WebPreferences initialize]):
3801         (-[WebPreferences setQTKitEnabled:]): Deleted.
3802         (-[WebPreferences isQTKitEnabled]): Deleted.
3803         * WebView/WebPreferencesPrivate.h:
3804         * WebView/WebView.mm:
3805         (-[WebView _preferencesChanged:]):
3806
3807 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3808
3809         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3810         https://bugs.webkit.org/show_bug.cgi?id=181960
3811         <rdar://problem/36431678>
3812
3813         Reviewed by Tim Horton.
3814
3815         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3816         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
3817         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
3818
3819         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
3820         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
3821         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
3822
3823         * WebView/WebView.mm:
3824         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3825
3826 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
3827
3828         Turning off custom pasteboard data doesn't actually turn it off in WK2
3829         https://bugs.webkit.org/show_bug.cgi?id=181920
3830         <rdar://problem/36686429>
3831
3832         Reviewed by Wenson Hsieh.
3833
3834         Always disable custom pasteboard data in WebKit1. See r226156 for details.
3835
3836         * WebView/WebPreferences.mm:
3837         (+[WebPreferences initialize]):
3838         * WebView/WebView.mm:
3839         (-[WebView _preferencesChanged:]):
3840
3841 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3842
3843         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3844         https://bugs.webkit.org/show_bug.cgi?id=181918
3845
3846         Reviewed by Tim Horton.
3847
3848         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3849
3850         * Configurations/FeatureDefines.xcconfig:
3851
3852 2018-01-20  Andy Estes  <aestes@apple.com>
3853
3854         [Apple Pay] Stop eagerly loading PassKit.framework
3855         https://bugs.webkit.org/show_bug.cgi?id=181911
3856         <rdar://problem/36555369>
3857
3858         Reviewed by Tim Horton.
3859
3860         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3861         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3862         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
3863
3864         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
3865
3866 2018-01-19  Dean Jackson  <dino@apple.com>
3867
3868         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
3869         https://bugs.webkit.org/show_bug.cgi?id=181817
3870         <rdar://problem/35274055>
3871
3872         Reviewed by Simon Fraser.
3873
3874         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
3875
3876         * Misc/WebKitVersionChecks.h:
3877         * WebView/WebView.mm:
3878         (-[WebView _commonInitializationWithFrameName:groupName:]):
3879
3880 2018-01-19  Alex Christensen  <achristensen@webkit.org>
3881
3882         Remove unused WebViewPrivate _allowCookies
3883         https://bugs.webkit.org/show_bug.cgi?id=181812
3884
3885         Reviewed by Tim Horton.
3886
3887         * WebView/WebView.mm:
3888         (+[WebView _setAllowCookies:]): Deleted.
3889         (+[WebView _allowCookies]): Deleted.
3890         * WebView/WebViewPrivate.h:
3891
3892 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
3893
3894         Build fix, remove a call to -[NSWindow setOneShot:]
3895         https://bugs.webkit.org/show_bug.cgi?id=181809
3896
3897         Reviewed by Tim Horton.
3898
3899         * WebView/WebTextCompletionController.mm:
3900         (-[WebTextCompletionController _buildUI]):
3901
3902 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3903
3904         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
3905
3906         * Carbon/HIWebView.mm:
3907         (overrideCGContext):
3908         (restoreCGContext):
3909
3910 2018-01-18  Dan Bernstein  <mitz@apple.com>
3911
3912         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3913         https://bugs.webkit.org/show_bug.cgi?id=181803
3914
3915         Reviewed by Tim Horton.
3916
3917         * Configurations/Base.xcconfig: Updated.
3918         * Configurations/DebugRelease.xcconfig: Ditto.
3919         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3920         * Configurations/Version.xcconfig: Updated.
3921         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3922           useful for defining settings that depend on the target macOS version.
3923
3924 2018-01-17  Youenn Fablet  <youenn@apple.com>
3925
3926         Put fetch Request.keepalive behind a runtime flag
3927         https://bugs.webkit.org/show_bug.cgi?id=181592
3928
3929         Reviewed by Chris Dumez.
3930
3931         * WebView/WebPreferenceKeysPrivate.h:
3932         * WebView/WebPreferences.mm:
3933         (+[WebPreferences initialize]):
3934         (-[WebPreferences fetchAPIKeepAliveEnabled]):
3935         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
3936         * WebView/WebPreferencesPrivate.h:
3937         * WebView/WebView.mm:
3938         (-[WebView _preferencesChanged:]):
3939
3940 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3941
3942         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3943         https://bugs.webkit.org/show_bug.cgi?id=181637
3944         <rdar://problem/36508471>
3945
3946         Reviewed by Tim Horton.
3947
3948         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
3949
3950         * WebCoreSupport/WebEditorClient.h:
3951         * WebCoreSupport/WebEditorClient.mm:
3952         (WebEditorClient::replacementURLForResource):
3953
3954 2018-01-11  Keith Miller  <keith_miller@apple.com>
3955
3956         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3957         https://bugs.webkit.org/show_bug.cgi?id=181573
3958
3959         Reviewed by Simon Fraser.
3960
3961         * Configurations/FeatureDefines.xcconfig:
3962
3963 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3964
3965         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
3966         https://bugs.webkit.org/show_bug.cgi?id=181497
3967
3968         Reviewed by Tim Horton.
3969
3970         See other ChangeLogs for more detail.
3971
3972         * WebCoreSupport/WebDragClient.h:
3973
3974 2018-01-11  Tim Horton  <timothy_horton@apple.com>
3975
3976         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
3977         https://bugs.webkit.org/show_bug.cgi?id=181523
3978         <rdar://problem/28959131>
3979
3980         Reviewed by Alex Christensen.
3981
3982         * WebView/WebImmediateActionController.mm:
3983         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3984         Apply the change made in r216652 to WebKit1's immediate action controller.
3985
3986         Speculative (but successful in WebKit2) fix for non-reproducible crash when
3987         the startContainer of the range is in an anonymous node.
3988
3989 2018-01-11  Youenn Fablet  <youenn@apple.com>
3990
3991         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
3992         https://bugs.webkit.org/show_bug.cgi?id=181480
3993
3994         Reviewed by Eric Carlson.
3995
3996         * WebView/WebPreferences.mm:
3997         (+[WebPreferences initialize]):
3998
3999 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4000
4001         Fix check-webkit-style issues with WebNSDataExtras.mm
4002         <https://webkit.org/b/181369>
4003
4004         Reviewed by Alex Christensen.
4005
4006         * Misc/WebNSDataExtras.mm:
4007         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
4008         (-[NSData _webkit_guessedMIMETypeForXML]):
4009         (-[NSData _webkit_guessedMIMEType]):
4010         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
4011         (_findEOL):
4012         (-[NSData _webkit_parseRFC822HeaderFields]):
4013         (-[NSData _web_locationAfterFirstBlankLine]):
4014         - Fix all the check-webkit-style warnings.
4015
4016 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4017
4018         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4019         <https://webkit.org/b/181256>
4020         <rdar://problem/36281730>
4021
4022         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
4023         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
4024         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
4025           to avoid warnings from casting CFStringRef to NPNSString*.
4026           Note that CFMutableStringRef is the same as CFStringRef
4027           without the const modifier, hence its use in the const_cast<>
4028           above.
4029
4030 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4031
4032         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4033         <https://webkit.org/b/181256>
4034         <rdar://problem/36281730>
4035
4036         * Carbon/HIWebView.mm:
4037         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
4038         checked_cf_cast<CFRunLoopRef>() to fix warning.
4039
4040 2018-01-07  David Kilzer  <ddkilzer@apple.com>
4041
4042         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4043         <https://webkit.org/b/181256>
4044         <rdar://problem/36281730>
4045
4046         Reviewed by Darin Adler.
4047
4048         * Carbon/CarbonUtils.m:
4049         (PoolCleaner):
4050         - Use #pragmas to ignore -Wcast-qual warnings when using a
4051           C-style cast from CFTypeRef to CFRunloopRef.
4052         * Carbon/CarbonWindowFrame.m:
4053         (-[CarbonWindowFrame title]):
4054         - Use #pragmas to ignore -Wcast-qual warnings when using a
4055           C-style cast from CFStringRef to NSString *.
4056         * Carbon/HIViewAdapter.m:
4057         (+[HIViewAdapter getHIViewForNSView:]):
4058         - Use #pragmas to ignore -Wcast-qual warnings when using a
4059           C-style cast from CFTypeRef to HIViewRef.
4060         * Configurations/Base.xcconfig:
4061         (WARNING_CFLAGS): Add -Wcast-qual.
4062         * Misc/WebElementDictionary.mm:
4063         (-[WebElementDictionary objectForKey:]):
4064         - Use static_cast<SEL>(const_cast<void*>()) to fix