Unreviewed, rolling out r230921, r230923, r230924, r230932,
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-23  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r230921, r230923, r230924, r230932,
4         and r230934.
5         https://bugs.webkit.org/show_bug.cgi?id=184903
6
7         Builds still broken (Requested by ryanhaddad on #webkit).
8
9         Reverted changesets:
10
11         "Implement Same-Site cookies"
12         https://bugs.webkit.org/show_bug.cgi?id=159464
13         https://trac.webkit.org/changeset/230921
14
15         "Attempt to fix the build after r230921"
16         https://bugs.webkit.org/show_bug.cgi?id=159464
17         https://trac.webkit.org/changeset/230923
18
19         "Attempt to fix the Mac and iOS build after r230921"
20         https://bugs.webkit.org/show_bug.cgi?id=159464
21         https://trac.webkit.org/changeset/230924
22
23         "Another attempt to fix the Windows build following r230921"
24         https://bugs.webkit.org/show_bug.cgi?id=159464
25         https://trac.webkit.org/changeset/230932
26
27         "Attempt to fix the Apple Internal build following r230921"
28         https://bugs.webkit.org/show_bug.cgi?id=159464
29         https://trac.webkit.org/changeset/230934
30
31 2018-04-23  Zalan Bujtas  <zalan@apple.com>
32
33         [LayoutFormattingContext] Initial commit.
34         https://bugs.webkit.org/show_bug.cgi?id=184896
35
36         Reviewed by Antti Koivisto.
37
38         * Configurations/FeatureDefines.xcconfig:
39
40 2018-04-23  Daniel Bates  <dabates@apple.com>
41
42         Implement Same-Site cookies
43         https://bugs.webkit.org/show_bug.cgi?id=159464
44         <rdar://problem/27196358>
45
46         Reviewed by Brent Fulgham.
47
48         Pass the Same-Site info through the strategy.
49
50         * WebCoreSupport/WebPlatformStrategies.h:
51         * WebCoreSupport/WebPlatformStrategies.mm:
52         (WebPlatformStrategies::cookiesForDOM):
53         (WebPlatformStrategies::setCookiesFromDOM):
54         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
55         (WebPlatformStrategies::getRawCookies):
56
57 2018-04-20  Timothy Hatcher  <timothy@apple.com>
58
59         NULL dereference crash sometimes under [super initWithCoder:] in WebView
60
61         https://bugs.webkit.org/show_bug.cgi?id=184851
62         rdar://problem/39611236
63
64         Reviewed by Tim Horton.
65
66         * WebView/WebView.mm:
67         (-[WebView _commonInitializationWithFrameName:groupName:]):
68         (-[WebView effectiveAppearanceDidChange]):
69         Added a null check and call the code later in initialization.
70
71 2018-04-20  Tim Horton  <timothy_horton@apple.com>
72
73         Adjust geolocation feature flag
74         https://bugs.webkit.org/show_bug.cgi?id=184856
75
76         Reviewed by Wenson Hsieh.
77
78         * Configurations/FeatureDefines.xcconfig:
79
80 2018-04-18  Jer Noble  <jer.noble@apple.com>
81
82         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
83         https://bugs.webkit.org/show_bug.cgi?id=184762
84
85         Reviewed by Dan Bernstein.
86
87         * Configurations/WebKitLegacy.xcconfig:
88
89 2018-04-20  Youenn Fablet  <youenn@apple.com>
90
91         Make PluginData cache its web visible plugins
92         https://bugs.webkit.org/show_bug.cgi?id=184421
93
94         Reviewed by Chris Dumez.
95
96         * WebCoreSupport/WebPluginInfoProvider.h:
97         * WebCoreSupport/WebPluginInfoProvider.mm:
98         (WebPluginInfoProvider::pluginInfo):
99         (WebPluginInfoProvider::webVisiblePluginInfo):
100
101 2018-04-19  Chris Dumez  <cdumez@apple.com>
102
103         Rename JSDOMWindowProxy to JSWindowProxy
104         https://bugs.webkit.org/show_bug.cgi?id=184797
105
106         Reviewed by Sam Weinig.
107
108         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
109
110         * DOM/DOMUtility.mm:
111         (createDOMWrapper):
112         * WebView/WebFrame.mm:
113         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
114
115 2018-04-19  David Kilzer  <ddkilzer@apple.com>
116
117         Enable Objective-C weak references
118         <https://webkit.org/b/184789>
119         <rdar://problem/39571716>
120
121         Reviewed by Dan Bernstein.
122
123         * Configurations/Base.xcconfig:
124         (CLANG_ENABLE_OBJC_WEAK): Enable.
125
126 2018-04-18  Chris Dumez  <cdumez@apple.com>
127
128         Rename WindowProxyController to WindowProxy
129         https://bugs.webkit.org/show_bug.cgi?id=184756
130
131         Reviewed by Sam Weinig.
132
133         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
134         needed use WindowProxyController type, which was a bit confusing.
135
136         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
137         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
138         * WebView/WebFrame.mm:
139         (-[WebFrame _attachScriptDebugger]):
140
141 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
142
143         Unreviewed rollout of r230632. Regression in memory usage.
144
145         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
146
147         * WebView/WebPreferences.mm:
148         (+[WebPreferences initialize]):
149
150 2018-04-17  Chris Dumez  <cdumez@apple.com>
151
152         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
153         https://bugs.webkit.org/show_bug.cgi?id=184678
154         <rdar://problem/39422122>
155
156         Reviewed by Alex Christensen.
157
158         Add new parameter to dispatchDecidePolicyForNavigationAction.
159
160         * WebCoreSupport/WebFrameLoaderClient.h:
161         * WebCoreSupport/WebFrameLoaderClient.mm:
162         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
163
164 2018-04-13  Chris Dumez  <cdumez@apple.com>
165
166         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
167         https://bugs.webkit.org/show_bug.cgi?id=184591
168
169         Reviewed by Sam Weinig.
170
171         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
172         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
173         This is work towards fixing Bug 184515.
174
175         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
176         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
177         * WebView/WebFrame.mm:
178         (-[WebFrame _attachScriptDebugger]):
179
180 2018-04-12  Antoine Quint  <graouts@apple.com>
181
182         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
183         https://bugs.webkit.org/show_bug.cgi?id=184569
184         <rdar://problem/38671301>
185
186         Reviewed by Jon Lee.
187
188         * WebView/WebPreferences.mm:
189
190 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
191
192         [WTF] Remove StaticLock
193         https://bugs.webkit.org/show_bug.cgi?id=184332
194
195         Reviewed by Mark Lam.
196
197         * DOM/DOMInternal.mm:
198         (getDOMWrapper):
199         (addDOMWrapper):
200         (removeDOMWrapper):
201
202 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
203
204         Failures from mach port reference handling should be fatal
205         https://bugs.webkit.org/show_bug.cgi?id=184202
206         <rdar://problem/37771114>
207
208         Reviewed by Anders Carlsson.
209
210         * Plugins/Hosted/NetscapePluginHostManager.mm:
211         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
212
213 2018-04-03  Andy Estes  <aestes@apple.com>
214
215         [Mac] Prioritize file promises over filenames during drag and drop
216         https://bugs.webkit.org/show_bug.cgi?id=184237
217         <rdar://problem/38278076>
218
219         Reviewed by Wenson Hsieh.
220
221         * WebView/WebView.mm:
222         (-[WebView performDragOperation:]):
223
224 2018-04-03  Chris Dumez  <cdumez@apple.com>
225
226         Drop MainFrame class
227         https://bugs.webkit.org/show_bug.cgi?id=184191
228
229         Reviewed by Darin Adler.
230
231         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
232         relationship between the Page and the MainFrame.
233
234         This is ground work for introducing LocalFrame / RemoteFrame concepts.
235
236         * WebCoreSupport/WebDragClient.mm:
237         * WebCoreSupport/WebFrameLoaderClient.mm:
238         * WebCoreSupport/WebInspectorClient.mm:
239         * WebCoreSupport/WebPlatformStrategies.mm:
240         * WebCoreSupport/WebPluginInfoProvider.mm:
241         * WebView/WebFrame.mm:
242         * WebView/WebFrameView.mm:
243         * WebView/WebHTMLView.mm:
244         * WebView/WebView.mm:
245
246 2018-04-02  Jer Noble  <jer.noble@apple.com>
247
248         Enable Legacy EME for all WebKit & WebKitLegacy clients
249         https://bugs.webkit.org/show_bug.cgi?id=184018
250         <rdar://problem/34887387>
251
252         Reviewed by Eric Carlson.
253
254         * WebView/WebPreferences.mm:
255         (+[WebPreferences initialize]):
256
257 2018-03-29  JF Bastien  <jfbastien@apple.com>
258
259         Use Forward.h instead of forward-declaring WTF::String
260         https://bugs.webkit.org/show_bug.cgi?id=184172
261         <rdar://problem/39026146>
262
263         Reviewed by Yusuke Suzuki.
264
265         As part of #184164 I'm changing WTF::String, and the forward
266         declarations are just wrong because I'm making it templated. We
267         should use Forward.h anyways, so do that instead.
268
269         * WebView/WebScriptDebugger.h:
270
271 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
272
273         Protect against invalid mach ports returned by mach_port_request_notification
274         https://bugs.webkit.org/show_bug.cgi?id=184106
275         <rdar://problem/37865316>
276
277         Reviewed by Chris Dumez.
278
279         * Plugins/Hosted/NetscapePluginHostProxy.mm:
280         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
281         and clean up if it experienced an error.
282         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
283
284 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
285
286         Avoid uninitialized mach ports
287         https://bugs.webkit.org/show_bug.cgi?id=184090
288         <rdar://problem/37261129>
289
290         Reviewed by Chris Dumez.
291
292         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
293         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
294         there is a potential for us to try to use invalid ports.
295
296         We should always check return values, and ensure that the mach port variables we seek to initialize are
297         kept in a valid state.
298
299         Reviewed by Chris Dumez.
300
301         * Plugins/Hosted/NetscapePluginHostManager.h:
302         * Plugins/Hosted/NetscapePluginHostManager.mm:
303         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
304         port is passed to an API function.
305         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
306         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
307         * Plugins/Hosted/NetscapePluginHostProxy.h:
308         * Plugins/Hosted/NetscapePluginHostProxy.mm:
309         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
310         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
311         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
312         (WKPCStatusText): Ditto.
313         (WKPCLoadURL): Ditto.
314         (WKPCCancelLoadURL): Ditto.
315         (WKPCInvalidateRect): Ditto.
316         (WKPCGetScriptableNPObjectReply): Ditto.
317         (WKPCBooleanReply): Ditto.
318         (WKPCBooleanAndDataReply): Ditto.
319         (WKPCInstantiatePluginReply): Ditto.
320         (WKPCGetWindowNPObject): Ditto.
321         (WKPCGetPluginElementNPObject): Ditto.
322         (WKPCForgetBrowserObject): Ditto.
323         (WKPCEvaluate): Ditto.
324         (WKPCGetStringIdentifier): Ditto.
325         (WKPCGetIntIdentifier): Ditto.
326         (WKPCInvoke): Ditto.
327         (WKPCInvokeDefault): Ditto.
328         (WKPCConstruct): Ditto.
329         (WKPCGetProperty): Ditto.
330         (WKPCSetProperty): Ditto.
331         (WKPCRemoveProperty): Ditto.
332         (WKPCHasProperty): Ditto.
333         (WKPCHasMethod): Ditto.
334         (WKPCIdentifierInfo): Ditto.
335         (WKPCEnumerate): Ditto.
336         (WKPCSetMenuBarVisible): Ditto.
337         (WKPCSetFullscreenWindowIsShowing): Ditto.
338         (WKPCSetModal): Ditto.
339         (WKPCGetCookies): Ditto.
340         (WKPCGetProxy): Ditto.
341         (WKPCSetCookies): Ditto.
342         (WKPCGetAuthenticationInfo): Ditto.
343         (WKPCConvertPoint): Ditto.
344         (WKPCLayerHostingModeChanged): Ditto.
345         (WKPCSetException): Ditto.
346
347 2018-03-26  Tim Horton  <timothy_horton@apple.com>
348
349         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
350         https://bugs.webkit.org/show_bug.cgi?id=184030
351         <rdar://problem/38895281>
352
353         Reviewed by Dan Bernstein.
354
355         * Configurations/Base.xcconfig:
356
357 2018-03-26  Chris Dumez  <cdumez@apple.com>
358
359         Use SecurityOriginData more consistently in Service Worker code
360         https://bugs.webkit.org/show_bug.cgi?id=183969
361
362         Reviewed by Darin Adler.
363
364         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
365
366         * Storage/WebDatabaseManager.mm:
367         (-[WebDatabaseManager databasesWithOrigin:]):
368         (-[WebDatabaseManager deleteOrigin:]):
369         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
370         * Storage/WebDatabaseQuotaManager.mm:
371         (-[WebDatabaseQuotaManager usage]):
372         (-[WebDatabaseQuotaManager quota]):
373         (-[WebDatabaseQuotaManager setQuota:]):
374         * Storage/WebStorageManager.mm:
375         (-[WebStorageManager deleteOrigin:]):
376         * WebCoreSupport/WebSecurityOrigin.mm:
377         (-[WebSecurityOrigin databaseIdentifier]):
378         (-[WebSecurityOrigin usage]):
379         (-[WebSecurityOrigin quota]):
380         (-[WebSecurityOrigin setQuota:]):
381
382 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
383
384         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
385         https://bugs.webkit.org/show_bug.cgi?id=183911
386         <rdar://problem/38762306>
387
388         Reviewed by Youenn Fablet.
389
390         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
391
392         * WebView/WebView.mm:
393         (+[WebView initialize]):
394
395 2018-03-26  Alex Christensen  <achristensen@webkit.org>
396
397         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
398         https://bugs.webkit.org/show_bug.cgi?id=183965
399
400         Reviewed by Chris Dumez.
401
402         * WebCoreSupport/WebFrameLoaderClient.h:
403         * WebCoreSupport/WebFrameLoaderClient.mm:
404         (WebFrameLoaderClient::willCacheResponse const):
405
406 2018-03-25  Commit Queue  <commit-queue@webkit.org>
407
408         Unreviewed, rolling out r229954.
409         https://bugs.webkit.org/show_bug.cgi?id=184000
410
411         Caused many layout tests to crash on Apple High Sierra,
412         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
413         by dydz on #webkit).
414
415         Reverted changeset:
416
417         "Use SecurityOriginData more consistently in Service Worker
418         code"
419         https://bugs.webkit.org/show_bug.cgi?id=183969
420         https://trac.webkit.org/changeset/229954
421
422 2018-03-24  Chris Dumez  <cdumez@apple.com>
423
424         Use SecurityOriginData more consistently in Service Worker code
425         https://bugs.webkit.org/show_bug.cgi?id=183969
426
427         Reviewed by Darin Adler.
428
429         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
430
431         * Storage/WebDatabaseManager.mm:
432         (-[WebDatabaseManager databasesWithOrigin:]):
433         (-[WebDatabaseManager deleteOrigin:]):
434         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
435         * Storage/WebDatabaseQuotaManager.mm:
436         (-[WebDatabaseQuotaManager usage]):
437         (-[WebDatabaseQuotaManager quota]):
438         (-[WebDatabaseQuotaManager setQuota:]):
439         * Storage/WebStorageManager.mm:
440         (-[WebStorageManager deleteOrigin:]):
441         * WebCoreSupport/WebSecurityOrigin.mm:
442         (-[WebSecurityOrigin databaseIdentifier]):
443         (-[WebSecurityOrigin usage]):
444         (-[WebSecurityOrigin quota]):
445         (-[WebSecurityOrigin setQuota:]):
446
447 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
448
449         Fix the build
450
451         * WebView/WebView.mm:
452
453 2018-03-23  Tim Horton  <timothy_horton@apple.com>
454
455         Fix the build with no pasteboard
456         https://bugs.webkit.org/show_bug.cgi?id=183973
457
458         Reviewed by Dan Bernstein.
459
460         * Configurations/FeatureDefines.xcconfig:
461         * WebView/WebView.mm:
462         (-[WebView _requestStartDataInteraction:globalPosition:]):
463         (-[WebView _getDataInteractionData]):
464         (-[WebView _dataOperationTextIndicator]):
465         (-[WebView _dragSourceAction]):
466         (-[WebView _draggedLinkTitle]):
467         (-[WebView _draggedLinkURL]):
468         (-[WebView _draggedElementBounds]):
469         (-[WebView _enteredDataInteraction:client:global:operation:]):
470         (-[WebView _updatedDataInteraction:client:global:operation:]):
471         (-[WebView _exitedDataInteraction:client:global:operation:]):
472         (-[WebView _performDataInteraction:client:global:operation:]):
473         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
474         (-[WebView _endedDataInteraction:global:]):
475         (-[WebView _dataInteractionCaretRect]):
476         * WebView/WebViewPrivate.h:
477
478 2018-03-23  Tim Horton  <timothy_horton@apple.com>
479
480         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
481         https://bugs.webkit.org/show_bug.cgi?id=183960
482         <rdar://problem/38812356>
483
484         Reviewed by Dan Bernstein.
485
486         * Configurations/WebKitLegacy.xcconfig:
487
488 2018-03-23  Tim Horton  <timothy_horton@apple.com>
489
490         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
491         https://bugs.webkit.org/show_bug.cgi?id=183954
492         <rdar://problem/38808858>
493
494         Reviewed by Dan Bernstein.
495
496         * WebView/WebPreferences.mm:
497         (-[WebPreferences setAudioSessionCategoryOverride:]):
498
499 2018-03-23  Tim Horton  <timothy_horton@apple.com>
500
501         Adopt WK_PLATFORM_NAME in WebKitLegacy
502         https://bugs.webkit.org/show_bug.cgi?id=183948
503         <rdar://problem/38803908>
504
505         Reviewed by Dan Bernstein.
506
507         * Configurations/WebKitLegacy.xcconfig:
508         * MigrateHeaders.make:
509         * postprocess-headers.sh:
510
511 2018-03-23  Brady Eidson  <beidson@apple.com>
512
513         Go to back/forward list items after a process-swapped navigation.
514         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
515
516         Reviewed by Andy Estes.
517
518         * WebView/WebView.mm:
519         (-[WebView _loadBackForwardListFromOtherView:]):
520         (-[WebView goToBackForwardItem:]):
521
522 2018-03-22  Tim Horton  <timothy_horton@apple.com>
523
524         Improve readability of WebCore's OTHER_LDFLAGS
525         https://bugs.webkit.org/show_bug.cgi?id=183909
526         <rdar://problem/38760992>
527
528         Reviewed by Dan Bernstein.
529
530         * Configurations/Base.xcconfig:
531         * Configurations/FeatureDefines.xcconfig:
532
533 2018-03-20  Tim Horton  <timothy_horton@apple.com>
534
535         Enable the minimal simulator feature flag when appropriate
536         https://bugs.webkit.org/show_bug.cgi?id=183807
537
538         Reviewed by Dan Bernstein.
539
540         * Configurations/FeatureDefines.xcconfig:
541
542 2018-03-20  Tim Horton  <timothy_horton@apple.com>
543
544         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
545         https://bugs.webkit.org/show_bug.cgi?id=183758
546         <rdar://problem/38017644>
547
548         Reviewed by Dan Bernstein.
549
550         * Configurations/FeatureDefines.xcconfig:
551
552 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
553
554         Clear style colors when setting default appearance
555         https://bugs.webkit.org/show_bug.cgi?id=183759
556
557         Reviewed by Tim Horton.
558
559         Colors are cached and need to be cleared and recalculated.
560         Refactor to do all style recalcs together.
561
562         * WebView/WebView.mm:
563         (-[WebView _setDefaultAppearanceAndClearStyle]):
564         (-[WebView _setUseSystemAppearance:]):
565         (-[WebView effectiveAppearanceDidChange]):
566
567 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
568
569         Unreviewed, another quick fix for r229699
570
571         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
572
573         * Configurations/FeatureDefines.xcconfig:
574
575 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
576
577         Ensure that style is updated when the effective appearance changes
578         https://bugs.webkit.org/show_bug.cgi?id=183690
579         <rdar://problem/38385900>
580
581         Reviewed by Tim Horton and Wenson Hsieh.
582
583         Respond to and respect the effective appearance changing.
584
585         * WebView/WebView.mm:
586         (-[WebView _setUseSystemAppearance:]):
587         (-[WebView effectiveAppearanceDidChange]):
588
589 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
590
591         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
592         https://bugs.webkit.org/show_bug.cgi?id=183677
593
594         Reviewed by Tim Horton.
595
596         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
597
598         * DOM/DOM.mm:
599         (-[DOMHTMLLinkElement _mediaQueryMatches]):
600
601 2018-03-14  Tim Horton  <timothy_horton@apple.com>
602
603         Fix the build after r229567
604
605         * Configurations/FeatureDefines.xcconfig:
606
607 2018-03-12  Tim Horton  <timothy_horton@apple.com>
608
609         Stop using SDK conditionals to control feature definitions
610         https://bugs.webkit.org/show_bug.cgi?id=183430
611         <rdar://problem/38251619>
612
613         Reviewed by Dan Bernstein.
614
615         * Configurations/FeatureDefines.xcconfig:
616         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
617
618 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
619
620         Runtime flag for link prefetch and remove link subresource.
621         https://bugs.webkit.org/show_bug.cgi?id=183540
622
623         Reviewed by Chris Dumez.
624
625         Remove the LINK_PREFETCH build time flag.
626
627         * Configurations/FeatureDefines.xcconfig:
628
629 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
630
631         Remove GridLayout runtime flag
632         https://bugs.webkit.org/show_bug.cgi?id=183484
633
634         Reviewed by Myles C. Maxfield.
635
636         The Grid Layout feature has been enabled by default for almost a
637         year, so I think it's time to remove the runtime flag and the
638
639         * WebView/WebPreferenceKeysPrivate.h:
640         * WebView/WebPreferences.mm:
641         (+[WebPreferences initialize]):
642         * WebView/WebPreferencesPrivate.h:
643         * WebView/WebView.mm:
644         (-[WebView _preferencesChanged:]):
645
646 2018-03-12  Antoine Quint  <graouts@apple.com>
647
648         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
649         https://bugs.webkit.org/show_bug.cgi?id=183504
650         <rdar://problem/38372965>
651
652         Reviewed by Dean Jackson and Jon Lee.
653
654         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
655         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
656
657         * WebView/WebPreferenceKeysPrivate.h:
658         * WebView/WebPreferences.mm:
659         (+[WebPreferences initialize]):
660         (-[WebPreferences setModernMediaControlsEnabled:]):
661         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
662         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
663         * WebView/WebPreferencesPrivate.h:
664         * WebView/WebView.mm:
665         (-[WebView _preferencesChanged:]):
666
667 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
668
669         Media query for default appearance
670         https://bugs.webkit.org/show_bug.cgi?id=183539
671         <rdar://problem/38326388>
672
673         Reviewed by Tim Horton.
674
675         Write a media query to evaluate appearance.
676
677         * WebView/WebView.mm:
678         (-[WebView _commonInitializationWithFrameName:groupName:]):
679         (-[WebView _setUseSystemAppearance:]):
680
681 2018-03-09  Andy Estes  <aestes@apple.com>
682
683         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
684         https://bugs.webkit.org/show_bug.cgi?id=183489
685         <rdar://problem/38267517>
686
687         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
688         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
689         to issue a sandbox extension for this directory, but for security reasons App Sandbox
690         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
691         block with a nil error and a valid file URL, but no file will actually exist at that URL.
692
693         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
694         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
695         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
696         drop destination.
697
698         Reviewed by Wenson Hsieh.
699
700         * WebView/WebView.mm:
701         (-[WebView performDragOperation:]):
702
703 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
704
705         Allow WebViews to disable system appearance
706         https://bugs.webkit.org/show_bug.cgi?id=183418
707         <rdar://problem/36975642>
708
709         Reviewed by Tim Horton.
710
711         Allow webviews to choose whether or not to follow the default system appearance.
712
713         * WebView/WebView.mm:
714         (-[WebView _setUseSystemAppearance:]):
715         (-[WebView _useSystemAppearance]):
716         * WebView/WebViewPrivate.h:
717
718 2018-03-08  Youenn Fablet  <youenn@apple.com>
719
720         libwebrtc update broke internal builds
721         https://bugs.webkit.org/show_bug.cgi?id=183454
722
723         Reviewed by Eric Carlson.
724
725         * Configurations/WebKitLegacy.xcconfig:
726
727 2018-03-08  Chris Dumez  <cdumez@apple.com>
728
729         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
730         https://bugs.webkit.org/show_bug.cgi?id=183455
731         <rdar://problem/38191749>
732
733         Reviewed by Youenn Fablet.
734
735         Add a null check for the page as we have evidence from crashes that it can be null.
736         Other functions in WebFrameNetworkingContext already null check the page as well,
737         not just the frame so this is consistent.
738
739         * WebCoreSupport/WebFrameNetworkingContext.mm:
740         (WebFrameNetworkingContext::storageSession const):
741
742 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
743
744         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
745         https://bugs.webkit.org/show_bug.cgi?id=183429
746
747         Reviewed by Mark Lam.
748
749         * DOM/DOM.mm:
750         (+[DOMNode _nodeFromJSWrapper:]):
751         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
752         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
753         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
754         * Plugins/Hosted/ProxyInstance.mm:
755         (WebKit::ProxyInstance::invokeMethod):
756         * WebView/WebView.mm:
757         (aeDescFromJSValue):
758
759 2018-03-08  Tim Horton  <timothy_horton@apple.com>
760
761         Stop linking ApplicationServices directly
762         https://bugs.webkit.org/show_bug.cgi?id=182867
763         <rdar://problem/38252142>
764
765         Reviewed by Alex Christensen.
766
767         The frameworks that we use that live inside ApplicationServices
768         have mostly moved out, so import them directly.
769
770         * Carbon/CarbonUtils.h:
771         * WebKitPrefix.h:
772         * WebView/WebHTMLView.mm:
773         * WebView/WebPDFView.mm:
774
775 2018-03-07  Tim Horton  <timothy_horton@apple.com>
776
777         Sort and separate FeatureDefines.xcconfig
778         https://bugs.webkit.org/show_bug.cgi?id=183427
779
780         Reviewed by Dan Bernstein.
781
782         * Configurations/FeatureDefines.xcconfig:
783         Sort and split FeatureDefines into paragraphs
784         (to make it easier to sort later).
785
786 2018-03-07  Youenn Fablet  <youenn@apple.com>
787
788         Match unsupported plugins based on domains and not origin
789         https://bugs.webkit.org/show_bug.cgi?id=183384
790
791         Reviewed by Chris Dumez.
792
793         * WebCoreSupport/WebPluginInfoProvider.h:
794         * WebCoreSupport/WebPluginInfoProvider.mm:
795         (WebPluginInfoProvider::getPluginInfo):
796         (WebPluginInfoProvider::getWebVisiblePluginInfo):
797
798 2018-03-05  Andy Estes  <aestes@apple.com>
799
800         [Mac] Teach WebCore::Pasteboard about file promise drags
801         https://bugs.webkit.org/show_bug.cgi?id=183314
802         <rdar://problem/38105493>
803
804         Reviewed by Darin Adler.
805
806         Added a FIXME comment.
807
808         * WebView/WebView.mm:
809         (-[WebView performDragOperation:]):
810
811 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
812
813         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
814         https://bugs.webkit.org/show_bug.cgi?id=183312
815
816         Reviewed by Mark Lam.
817
818         Remove wtf/CurrentTime.h include pragma.
819
820         * WebView/WebFrame.mm:
821         * WebView/WebPDFView.mm:
822
823 2018-03-04  Tim Horton  <timothy_horton@apple.com>
824
825         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
826         https://bugs.webkit.org/show_bug.cgi?id=183283
827         <rdar://problem/38062148>
828
829         Reviewed by Sam Weinig.
830
831         * Configurations/FeatureDefines.xcconfig:
832
833 2018-02-28  Alex Christensen  <achristensen@webkit.org>
834
835         Reduce use of NetworkingContext in WebKit
836         https://bugs.webkit.org/show_bug.cgi?id=183213
837
838         Reviewed by Brady Eidson.
839
840         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
841         (WebKit::NetscapePluginInstanceProxy::getProxy):
842         * Plugins/WebNetscapePluginView.mm:
843         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
844
845 2018-02-17  Darin Adler  <darin@apple.com>
846
847         Prepare for ExtendedColor changes (first step)
848         https://bugs.webkit.org/show_bug.cgi?id=182904
849
850         Reviewed by Sam Weinig.
851
852         * Misc/WebKitNSStringExtras.mm:
853         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
854
855 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
856
857         Remove currentTime() / currentTimeMS()
858         https://bugs.webkit.org/show_bug.cgi?id=183052
859
860         Reviewed by Mark Lam.
861
862         * WebCoreSupport/WebFrameLoaderClient.h:
863         * WebCoreSupport/WebFrameLoaderClient.mm:
864         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
865
866 2018-02-16  Youenn Fablet  <youenn@apple.com>
867
868         Allow specifying which plug-ins are supported
869         https://bugs.webkit.org/show_bug.cgi?id=182748
870
871         Reviewed by Chris Dumez.
872
873         * WebCoreSupport/WebPluginInfoProvider.h:
874         * WebCoreSupport/WebPluginInfoProvider.mm:
875         (WebPluginInfoProvider::getPluginInfo):
876         (WebPluginInfoProvider::getWebVisiblePluginInfo):
877
878 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
879
880         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
881         https://bugs.webkit.org/show_bug.cgi?id=182882
882         <rdar://problem/35672661>
883
884         Reviewed by Dan Bernstein.
885
886         Make sure the smart pointer hold the collection of subviews lives at least as
887         long as the loop using it.
888
889         * WebView/WebHTMLView.mm:
890         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
891
892 2018-02-14  Daniel Bates  <dabates@apple.com>
893
894         Disallow cross-origin subresources from asking for credentials
895         https://bugs.webkit.org/show_bug.cgi?id=182579
896         <rdar://problem/36162271>
897
898         Reviewed by Andy Estes.
899
900         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
901         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
902
903         * WebView/WebPreferenceKeysPrivate.h:
904         * WebView/WebPreferences.mm:
905         (+[WebPreferences initialize]):
906         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
907         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
908         * WebView/WebPreferencesPrivate.h:
909         * WebView/WebView.mm:
910         (-[WebView _preferencesChanged:]):
911
912 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
913
914         Remove ForwardingHeaders directory from WebKitLegacy/mac.
915         https://bugs.webkit.org/show_bug.cgi?id=182738
916
917         Reviewed by Darin Adler.
918
919         * ForwardingHeaders/collector/handles/Global.h: Removed.
920         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
921         * ForwardingHeaders/runtime/Completion.h: Removed.
922         * ForwardingHeaders/runtime/Error.h: Removed.
923         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
924         * ForwardingHeaders/runtime/JSFunction.h: Removed.
925         * ForwardingHeaders/runtime/JSLock.h: Removed.
926         * ForwardingHeaders/runtime/JSObject.h: Removed.
927         * ForwardingHeaders/runtime/JSString.h: Removed.
928         * ForwardingHeaders/runtime/Protect.h: Removed.
929         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
930
931 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
932
933         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
934         https://bugs.webkit.org/show_bug.cgi?id=182641
935
936         Reviewed by Dan Bernstein.
937
938         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
939         https://trac.webkit.org/changeset/228308.
940
941         * WebView/WebVideoFullscreenController.h:
942         * WebView/WebVideoFullscreenHUDWindowController.mm:
943         * WebView/WebWindowAnimation.h:
944         * WebView/WebWindowAnimation.mm:
945         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
946         (WebCore::scaledRect): Deleted.
947         (WebCore::squaredDistance): Deleted.
948
949 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
950
951         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
952
953         * WebView/WebWindowAnimation.mm:
954         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
955
956 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
957
958         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
959         https://bugs.webkit.org/show_bug.cgi?id=182615
960
961         Reviewed by Eric Carlson.
962
963         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
964         Ideally, we should not reference NSApp in WebCore.
965
966         * WebView/WebFullScreenController.mm:
967         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
968         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
969         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
970         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
971         * WebView/WebView.mm:
972         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
973         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
974
975 2018-01-13  Darin Adler  <darin@apple.com>
976
977         Event improvements
978         https://bugs.webkit.org/show_bug.cgi?id=179591
979
980         Reviewed by Chris Dumez.
981
982         * DOM/DOMWheelEvent.mm:
983         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
984         Call initWebKitWheelEvent.
985
986         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
987         * WebCoreSupport/WebInspectorClient.mm: Ditto.
988         * WebView/WebFrame.mm: Ditto.
989
990         * WebView/WebHTMLView.mm:
991         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
992         underlyingPlatformEvent.
993         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
994
995         * WebView/WebScriptWorld.mm:
996         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
997
998         * WebView/WebView.mm: Removed include of ScriptValue.h.
999
1000 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1001
1002         Remove WebCore/ForwardingHeaders directory
1003         https://bugs.webkit.org/show_bug.cgi?id=182347
1004
1005         Reviewed by Keith Miller.
1006
1007         * Carbon/CarbonWindowAdapter.mm:
1008         * DOM/WebDOMOperations.mm:
1009         * History/WebBackForwardList.mm:
1010         * History/WebHistoryItem.mm:
1011         * Misc/WebCache.mm:
1012         * Misc/WebElementDictionary.mm:
1013         * Misc/WebIconDatabase.mm:
1014         * Misc/WebStringTruncator.mm:
1015         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1016         * Plugins/Hosted/ProxyInstance.mm:
1017         * Plugins/Hosted/ProxyRuntimeObject.mm:
1018         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1019         * Plugins/WebBaseNetscapePluginView.mm:
1020         * Plugins/WebBasePluginPackage.mm:
1021         * Plugins/WebNetscapePluginStream.mm:
1022         * Plugins/WebNetscapePluginView.mm:
1023         * Plugins/WebPluginController.mm:
1024         * WebCoreSupport/WebEditorClient.mm:
1025         * WebCoreSupport/WebFrameLoaderClient.mm:
1026         * WebCoreSupport/WebInspectorClient.h:
1027         * WebCoreSupport/WebInspectorClient.mm:
1028         * WebView/WebDataSource.mm:
1029         * WebView/WebFrame.mm:
1030         * WebView/WebHTMLRepresentation.mm:
1031         * WebView/WebHTMLView.mm:
1032         * WebView/WebPreferences.mm:
1033         * WebView/WebScriptDebugDelegate.mm:
1034         * WebView/WebScriptDebugger.h:
1035         * WebView/WebTextIterator.mm:
1036         * WebView/WebView.mm:
1037         * WebView/WebViewData.mm:
1038
1039 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1040
1041         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1042         https://bugs.webkit.org/show_bug.cgi?id=182312
1043
1044         Reviewed by Michael Catanzaro.
1045
1046         * WebKitPrefix.h:
1047
1048 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1049
1050         [WebAuthN] Add a compile-time feature flag
1051         https://bugs.webkit.org/show_bug.cgi?id=182211
1052         <rdar://problem/36936365>
1053
1054         Reviewed by Brent Fulgham.
1055
1056         * Configurations/FeatureDefines.xcconfig:
1057
1058 2018-01-27  Dan Bernstein  <mitz@apple.com>
1059
1060         HaveInternalSDK includes should be "#include?"
1061         https://bugs.webkit.org/show_bug.cgi?id=179670
1062
1063         * Configurations/Base.xcconfig:
1064
1065 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1066
1067         Remove unused QTKit preference
1068         https://bugs.webkit.org/show_bug.cgi?id=181968
1069
1070         Reviewed by Alexey Proskuryakov.
1071
1072         * WebView/WebPreferenceKeysPrivate.h:
1073         * WebView/WebPreferences.mm:
1074         (+[WebPreferences initialize]):
1075         (-[WebPreferences setQTKitEnabled:]): Deleted.
1076         (-[WebPreferences isQTKitEnabled]): Deleted.
1077         * WebView/WebPreferencesPrivate.h:
1078         * WebView/WebView.mm:
1079         (-[WebView _preferencesChanged:]):
1080
1081 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1082
1083         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1084         https://bugs.webkit.org/show_bug.cgi?id=182037
1085         <rdar://problem/36747812>
1086
1087         Reviewed by Ryosuke Niwa.
1088
1089         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1090         for more details.
1091
1092         * WebView/WebHTMLRepresentation.mm:
1093         (-[WebHTMLRepresentation elementWithName:inForm:]):
1094         (-[WebHTMLRepresentation controlsInForm:]):
1095
1096 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1097
1098         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1099         https://bugs.webkit.org/show_bug.cgi?id=181961
1100
1101         Reviewed by Michael Catanzaro.
1102
1103         * WebView/WebPreferences.mm:
1104
1105 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1106
1107         Unreviewed, rolling out r227437.
1108         https://bugs.webkit.org/show_bug.cgi?id=182011
1109
1110         broke build (Requested by alexchristensen on #webkit).
1111
1112         Reverted changeset:
1113
1114         "Remove unused QTKit preference"
1115         https://bugs.webkit.org/show_bug.cgi?id=181968
1116         https://trac.webkit.org/changeset/227437
1117
1118 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1119
1120         Remove unused QTKit preference
1121         https://bugs.webkit.org/show_bug.cgi?id=181968
1122
1123         Reviewed by Alexey Proskuryakov.
1124
1125         * WebView/WebPreferenceKeysPrivate.h:
1126         * WebView/WebPreferences.mm:
1127         (+[WebPreferences initialize]):
1128         (-[WebPreferences setQTKitEnabled:]): Deleted.
1129         (-[WebPreferences isQTKitEnabled]): Deleted.
1130         * WebView/WebPreferencesPrivate.h:
1131         * WebView/WebView.mm:
1132         (-[WebView _preferencesChanged:]):
1133
1134 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1135
1136         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1137         https://bugs.webkit.org/show_bug.cgi?id=181960
1138         <rdar://problem/36431678>
1139
1140         Reviewed by Tim Horton.
1141
1142         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1143         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1144         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1145
1146         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1147         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1148         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1149
1150         * WebView/WebView.mm:
1151         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1152
1153 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1154
1155         Turning off custom pasteboard data doesn't actually turn it off in WK2
1156         https://bugs.webkit.org/show_bug.cgi?id=181920
1157         <rdar://problem/36686429>
1158
1159         Reviewed by Wenson Hsieh.
1160
1161         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1162
1163         * WebView/WebPreferences.mm:
1164         (+[WebPreferences initialize]):
1165         * WebView/WebView.mm:
1166         (-[WebView _preferencesChanged:]):
1167
1168 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1169
1170         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1171         https://bugs.webkit.org/show_bug.cgi?id=181918
1172
1173         Reviewed by Tim Horton.
1174
1175         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1176
1177         * Configurations/FeatureDefines.xcconfig:
1178
1179 2018-01-20  Andy Estes  <aestes@apple.com>
1180
1181         [Apple Pay] Stop eagerly loading PassKit.framework
1182         https://bugs.webkit.org/show_bug.cgi?id=181911
1183         <rdar://problem/36555369>
1184
1185         Reviewed by Tim Horton.
1186
1187         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1188         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1189         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1190
1191         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1192
1193 2018-01-19  Dean Jackson  <dino@apple.com>
1194
1195         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1196         https://bugs.webkit.org/show_bug.cgi?id=181817
1197         <rdar://problem/35274055>
1198
1199         Reviewed by Simon Fraser.
1200
1201         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1202
1203         * Misc/WebKitVersionChecks.h:
1204         * WebView/WebView.mm:
1205         (-[WebView _commonInitializationWithFrameName:groupName:]):
1206
1207 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1208
1209         Remove unused WebViewPrivate _allowCookies
1210         https://bugs.webkit.org/show_bug.cgi?id=181812
1211
1212         Reviewed by Tim Horton.
1213
1214         * WebView/WebView.mm:
1215         (+[WebView _setAllowCookies:]): Deleted.
1216         (+[WebView _allowCookies]): Deleted.
1217         * WebView/WebViewPrivate.h:
1218
1219 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1220
1221         Build fix, remove a call to -[NSWindow setOneShot:]
1222         https://bugs.webkit.org/show_bug.cgi?id=181809
1223
1224         Reviewed by Tim Horton.
1225
1226         * WebView/WebTextCompletionController.mm:
1227         (-[WebTextCompletionController _buildUI]):
1228
1229 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1230
1231         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1232
1233         * Carbon/HIWebView.mm:
1234         (overrideCGContext):
1235         (restoreCGContext):
1236
1237 2018-01-18  Dan Bernstein  <mitz@apple.com>
1238
1239         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1240         https://bugs.webkit.org/show_bug.cgi?id=181803
1241
1242         Reviewed by Tim Horton.
1243
1244         * Configurations/Base.xcconfig: Updated.
1245         * Configurations/DebugRelease.xcconfig: Ditto.
1246         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1247         * Configurations/Version.xcconfig: Updated.
1248         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1249           useful for defining settings that depend on the target macOS version.
1250
1251 2018-01-17  Youenn Fablet  <youenn@apple.com>
1252
1253         Put fetch Request.keepalive behind a runtime flag
1254         https://bugs.webkit.org/show_bug.cgi?id=181592
1255
1256         Reviewed by Chris Dumez.
1257
1258         * WebView/WebPreferenceKeysPrivate.h:
1259         * WebView/WebPreferences.mm:
1260         (+[WebPreferences initialize]):
1261         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1262         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1263         * WebView/WebPreferencesPrivate.h:
1264         * WebView/WebView.mm:
1265         (-[WebView _preferencesChanged:]):
1266
1267 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1268
1269         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1270         https://bugs.webkit.org/show_bug.cgi?id=181637
1271         <rdar://problem/36508471>
1272
1273         Reviewed by Tim Horton.
1274
1275         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1276
1277         * WebCoreSupport/WebEditorClient.h:
1278         * WebCoreSupport/WebEditorClient.mm:
1279         (WebEditorClient::replacementURLForResource):
1280
1281 2018-01-11  Keith Miller  <keith_miller@apple.com>
1282
1283         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1284         https://bugs.webkit.org/show_bug.cgi?id=181573
1285
1286         Reviewed by Simon Fraser.
1287
1288         * Configurations/FeatureDefines.xcconfig:
1289
1290 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1291
1292         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1293         https://bugs.webkit.org/show_bug.cgi?id=181497
1294
1295         Reviewed by Tim Horton.
1296
1297         See other ChangeLogs for more detail.
1298
1299         * WebCoreSupport/WebDragClient.h:
1300
1301 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1302
1303         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1304         https://bugs.webkit.org/show_bug.cgi?id=181523
1305         <rdar://problem/28959131>
1306
1307         Reviewed by Alex Christensen.
1308
1309         * WebView/WebImmediateActionController.mm:
1310         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1311         Apply the change made in r216652 to WebKit1's immediate action controller.
1312
1313         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1314         the startContainer of the range is in an anonymous node.
1315
1316 2018-01-11  Youenn Fablet  <youenn@apple.com>
1317
1318         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1319         https://bugs.webkit.org/show_bug.cgi?id=181480
1320
1321         Reviewed by Eric Carlson.
1322
1323         * WebView/WebPreferences.mm:
1324         (+[WebPreferences initialize]):
1325
1326 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1327
1328         Fix check-webkit-style issues with WebNSDataExtras.mm
1329         <https://webkit.org/b/181369>
1330
1331         Reviewed by Alex Christensen.
1332
1333         * Misc/WebNSDataExtras.mm:
1334         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1335         (-[NSData _webkit_guessedMIMETypeForXML]):
1336         (-[NSData _webkit_guessedMIMEType]):
1337         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1338         (_findEOL):
1339         (-[NSData _webkit_parseRFC822HeaderFields]):
1340         (-[NSData _web_locationAfterFirstBlankLine]):
1341         - Fix all the check-webkit-style warnings.
1342
1343 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1344
1345         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1346         <https://webkit.org/b/181256>
1347         <rdar://problem/36281730>
1348
1349         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1350         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1351         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1352           to avoid warnings from casting CFStringRef to NPNSString*.
1353           Note that CFMutableStringRef is the same as CFStringRef
1354           without the const modifier, hence its use in the const_cast<>
1355           above.
1356
1357 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1358
1359         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1360         <https://webkit.org/b/181256>
1361         <rdar://problem/36281730>
1362
1363         * Carbon/HIWebView.mm:
1364         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1365         checked_cf_cast<CFRunLoopRef>() to fix warning.
1366
1367 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1368
1369         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1370         <https://webkit.org/b/181256>
1371         <rdar://problem/36281730>
1372
1373         Reviewed by Darin Adler.
1374
1375         * Carbon/CarbonUtils.m:
1376         (PoolCleaner):
1377         - Use #pragmas to ignore -Wcast-qual warnings when using a
1378           C-style cast from CFTypeRef to CFRunloopRef.
1379         * Carbon/CarbonWindowFrame.m:
1380         (-[CarbonWindowFrame title]):
1381         - Use #pragmas to ignore -Wcast-qual warnings when using a
1382           C-style cast from CFStringRef to NSString *.
1383         * Carbon/HIViewAdapter.m:
1384         (+[HIViewAdapter getHIViewForNSView:]):
1385         - Use #pragmas to ignore -Wcast-qual warnings when using a
1386           C-style cast from CFTypeRef to HIViewRef.
1387         * Configurations/Base.xcconfig:
1388         (WARNING_CFLAGS): Add -Wcast-qual.
1389         * Misc/WebElementDictionary.mm:
1390         (-[WebElementDictionary objectForKey:]):
1391         - Use static_cast<SEL>(const_cast<void*>()) to fix
1392           warning.
1393         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1394         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1395         (-[NSData _webkit_guessedMIMETypeForXML]):
1396         (-[NSData _webkit_guessedMIMEType]):
1397         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1398         (_findEOL):
1399         (-[NSData _webkit_parseRFC822HeaderFields]):
1400         (-[NSData _web_startsWithBlankLine]):
1401         (-[NSData _web_locationAfterFirstBlankLine]):
1402         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1403           type to Objective-C++.  This fixes the warnings about
1404           discarding the `const` modifier when casing from CFStringRef
1405           to NSString * because in older clang versions, -Wcast-qual was
1406           completely broken when compiling C++ and Objective-C++ source
1407           files.  In newer clang versions, discarding the `const`
1408           modifier for toll-free bridged types is ignored when compiling
1409           Objective-C++ source.
1410         - Update copyright and license header.
1411         - Use reinterpret_cast<> and static_cast<> to fix warnings
1412           unrelated to (NSString *) C-style casts.
1413         - Replace use of MIN() macro with std::min<> template functions.
1414         - Fix location of `*` for local variables modified above.
1415         * Plugins/Hosted/NetscapePluginHostManager.mm:
1416         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1417         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1418         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1419         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1420           warnings.
1421         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1422         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1423         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1424           to fix warning.
1425         * Plugins/Hosted/ProxyInstance.mm:
1426         (WebKit::ProxyInstance::invoke):
1427         - Use static_cast<char*>(const_cast<void*>()) to fix
1428           warning when using -[NSData bytes].
1429         (WebKit::ProxyInstance::fieldValue const):
1430         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1431           to fix warning when using CFDataGetBytePtr().
1432         * Plugins/Hosted/WebTextInputWindowController.m:
1433         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1434         - Use #pragma to ignore -Wcast-qual warning since there
1435           is not a good way to avoid this warning in Objective-C.
1436         * Plugins/WebNetscapePluginStream.mm:
1437         (WebNetscapePluginStream::deliverData):
1438         - Use const_cast<void*>() to fix warning when using
1439           -[NSData bytes].
1440         * Plugins/WebNetscapePluginView.mm:
1441         (-[WebNetscapePluginView _createPlugin]):
1442         - Change C-style cast to const_cast<char*>() to fix
1443           warning.
1444         * WebCoreSupport/WebChromeClient.mm:
1445         (WebChromeClient::wrapCryptoKey const):
1446         (WebChromeClient::unwrapCryptoKey const):
1447         - Change C-style cast to
1448           static_cast<uint8_t*>(const_cast<void*>() to fix
1449           warning.
1450         * WebView/WebPDFView.mm:
1451         (_applicationInfoForMIMEType):
1452         - Change local variable type from 'NSURL *' to
1453           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1454           when calling -[NSURL path].
1455
1456 2018-01-05  Dan Bernstein  <mitz@apple.com>
1457
1458         Fixed the build following AppKit API deprecations in a recent SDKs
1459
1460         * WebView/WebFullScreenController.mm:
1461         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1462         (-[WebFullScreenController exitFullScreen]): Ditto.
1463         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1464         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1465         * WebView/WebHTMLView.mm:
1466         (-[WebHTMLView drawRect:]): Ditto.
1467         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1468         (-[WebHTMLView knowsPageRange:]): Ditto.
1469         * WebView/WebView.mm:
1470         (LayerFlushController::flushLayers): Ditto.
1471
1472 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1473
1474         [Attachment Support] Create attachment elements when dropping files on iOS
1475         https://bugs.webkit.org/show_bug.cgi?id=181192
1476         <rdar://problem/36280945>
1477
1478         Reviewed by Tim Horton.
1479
1480         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1481
1482         * WebCoreSupport/WebPlatformStrategies.h:
1483         * WebCoreSupport/WebPlatformStrategies.mm:
1484         (WebPlatformStrategies::informationForItemAtIndex):
1485         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1486
1487 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         [Attachment Support] Add plumbing for starting a drag with promised blob data
1490         https://bugs.webkit.org/show_bug.cgi?id=181201
1491
1492         Reviewed by Tim Horton.
1493
1494         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1495
1496         * WebCoreSupport/WebDragClient.h:
1497
1498 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1499
1500         Add a WebAuthentication runtime feature flag
1501         https://bugs.webkit.org/show_bug.cgi?id=181220
1502         <rdar://problem/36055305>
1503
1504         Reviewed by Brent Fulgham.
1505
1506         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1507
1508         * WebView/WebPreferenceKeysPrivate.h:
1509         * WebView/WebPreferences.mm:
1510         (+[WebPreferences initialize]):
1511         (-[WebPreferences webAuthenticationEnabled]):
1512         (-[WebPreferences setWebAuthenticationEnabled:]):
1513         (-[WebPreferences credentialManagementEnabled]): Deleted.
1514         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1515         * WebView/WebPreferencesPrivate.h:
1516         * WebView/WebView.mm:
1517         (-[WebView _preferencesChanged:]):
1518
1519 2017-12-22  Jeff Miller  <jeffm@apple.com>
1520
1521         Update user-visible copyright strings to include 2018
1522         https://bugs.webkit.org/show_bug.cgi?id=181141
1523
1524         Reviewed by Dan Bernstein.
1525
1526         * Info.plist:
1527
1528 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1529
1530         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1531         https://bugs.webkit.org/show_bug.cgi?id=181188
1532
1533         Reviewed by Dan Bernstein.
1534
1535         See WebCore/ChangeLog for more detail.
1536
1537         * WebCoreSupport/WebDragClient.h:
1538         * WebCoreSupport/WebDragClient.mm:
1539         (WebDragClient::declareAndWriteAttachment): Deleted.
1540         * WebView/WebHTMLView.mm:
1541         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1542
1543 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1544
1545         Unreviewed, continue to fix build failures due to AppKit API deprecation
1546
1547         Wraps more code in -Wdeprecated-declarations.
1548
1549         * Carbon/HIWebView.mm:
1550         (overrideCGContext):
1551
1552 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1553
1554         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1555
1556         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1557
1558         * Carbon/CarbonWindowAdapter.mm:
1559         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1560         * Plugins/WebNetscapePluginView.mm:
1561         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1562         (-[WebNetscapePluginView sendDrawRectEvent:]):
1563         (-[WebNetscapePluginView drawRect:]):
1564
1565 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1566
1567         Fix build failures due to using deprecated AppKit symbols
1568         https://bugs.webkit.org/show_bug.cgi?id=181110
1569         <rdar://problem/36162865>
1570
1571         Reviewed by Dan Bernstein and Tim Horton.
1572
1573         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1574
1575         * Misc/WebKitNSStringExtras.mm:
1576         (-[NSString _web_drawAtPoint:font:textColor:]):
1577         * Misc/WebNSPasteboardExtras.h:
1578         * Misc/WebNSPasteboardExtras.mm:
1579         (+[NSPasteboard _web_writableTypesForURL]):
1580         (_createWritableTypesForImageWithoutArchive):
1581         (_createWritableTypesForImageWithArchive):
1582         (+[NSPasteboard _web_dragTypesForURL]):
1583         (-[NSPasteboard _web_bestURL]):
1584         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1585         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1586         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1587         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1588         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1589         * Panels/WebAuthenticationPanel.m:
1590         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1591         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1592         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1593         (-[WebHostedNetscapePluginView drawRect:]):
1594         * WebInspector/WebNodeHighlightView.mm:
1595         (-[WebNodeHighlightView drawRect:]):
1596         * WebView/WebFrame.mm:
1597         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1598         (-[WebFrame _drawRect:contentsOnly:]):
1599         * WebView/WebHTMLView.mm:
1600         (kit):
1601         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1602         (-[WebHTMLView _plainTextFromPasteboard:]):
1603         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1604         (+[WebHTMLView _insertablePasteboardTypes]):
1605         (+[WebHTMLView _selectionPasteboardTypes]):
1606         (-[WebHTMLView pasteboard:provideDataForType:]):
1607         (-[WebHTMLView _writeSelectionToPasteboard:]):
1608         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1609         (-[WebHTMLView validRequestorForSendType:returnType:]):
1610         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1611         (createMenuItem):
1612         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1613         (-[WebHTMLView _colorAsString:]):
1614         (-[WebHTMLView copyFont:]):
1615         * WebView/WebPDFView.mm:
1616         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1617         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1618         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1619         (-[WebPDFView pasteboardTypesForSelection]):
1620         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1621         * WebView/WebView.h:
1622         * WebView/WebView.mm:
1623         (-[WebView performDragOperation:]):
1624         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1625         (-[WebView _searchWithGoogleFromMenu:]):
1626
1627 2017-12-21  Youenn Fablet  <youenn@apple.com>
1628
1629         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1630         https://bugs.webkit.org/show_bug.cgi?id=181000
1631
1632         Reviewed by Chris Dumez.
1633
1634         * Misc/WebCache.mm:
1635         (+[WebCache addImageToCache:forURL:forFrame:]):
1636
1637 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1638
1639         Update FULLSCREEN_API feature defines.
1640         https://bugs.webkit.org/show_bug.cgi?id=181015
1641
1642         Reviewed by Tim Horton.
1643
1644         Change enabled iphone sdk for FULLSCREEN_API.
1645
1646         * Configurations/FeatureDefines.xcconfig:
1647
1648 2017-12-21  Jer Noble  <jer.noble@apple.com>
1649
1650         Add initial DOM support for Media Capabilities
1651         https://bugs.webkit.org/show_bug.cgi?id=181064
1652
1653         Reviewed by Eric Carlson.
1654
1655         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1656
1657         * WebView/WebPreferenceKeysPrivate.h:
1658         * WebView/WebPreferences.mm:
1659         (+[WebPreferences initialize]):
1660         (-[WebPreferences mediaCapabilitiesEnabled]):
1661         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1662         * WebView/WebPreferencesPrivate.h:
1663         * WebView/WebView.mm:
1664         (-[WebView _preferencesChanged:]):
1665
1666 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1667
1668         Enable picture-in-picture from inline element on suspend.
1669         https://bugs.webkit.org/show_bug.cgi?id=180942
1670         rdar://problem/34745234
1671
1672         Reviewed by Jer Noble.
1673
1674         Update signature of enterVideoFullscreenForVideoElement().
1675
1676         * WebCoreSupport/WebChromeClient.h:
1677         * WebCoreSupport/WebChromeClient.mm:
1678         (WebChromeClient::enterVideoFullscreenForVideoElement):
1679
1680 2017-12-20  Daniel Bates  <dabates@apple.com>
1681
1682         Remove Alternative Presentation Button
1683         https://bugs.webkit.org/show_bug.cgi?id=180500
1684         <rdar://problem/35891047>
1685
1686         Reviewed by Simon Fraser.
1687
1688         We no longer need the alternative presentation button.
1689
1690         * Configurations/FeatureDefines.xcconfig:
1691
1692 2017-12-19  Jer Noble  <jer.noble@apple.com>
1693
1694         Playing media elements which call "pause(); play()" will have the play promise rejected.
1695         https://bugs.webkit.org/show_bug.cgi?id=180781
1696         <rdar://problem/33191377>
1697
1698         Reviewed by Eric Carlson.
1699
1700         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1701
1702         * WebView/WebView.mm:
1703         (shouldRequireUserGestureToLoadVideo):
1704
1705 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1706
1707         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1708         https://bugs.webkit.org/show_bug.cgi?id=180977
1709
1710         Reviewed by Tim Horton.
1711
1712         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1713         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1714         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1715
1716         * WebCoreSupport/WebEditorClient.mm:
1717         (attributesForAttributedStringConversion):
1718         * WebView/WebHTMLView.mm:
1719         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1720
1721 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1722
1723         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1724
1725         Attempt to fix the following warnings:
1726
1727             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1728
1729         For the following instance variables:
1730
1731             _borderView
1732             _contentView
1733             _frame
1734             _wFlags
1735
1736         * Carbon/CarbonWindowAdapter.mm:
1737         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1738         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1739         (-[CarbonWindowAdapter _termWindowIfOwner]):
1740         (-[CarbonWindowAdapter _windowMovedToRect:]):
1741         (-[CarbonWindowAdapter setContentView:]):
1742         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1743         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1744
1745 2017-12-16  Dan Bernstein  <mitz@apple.com>
1746
1747         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1748         https://bugs.webkit.org/show_bug.cgi?id=180613
1749         <rdar://problem/35946124>
1750
1751         Reviewed by Geoff Garen.
1752
1753         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1754           clients.
1755         * WebView/WebDynamicScrollBarsView.h: Ditto.
1756         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1757
1758 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1759
1760         Enable -Wstrict-prototypes for WebKit
1761         <https://webkit.org/b/180757>
1762         <rdar://problem/36024132>
1763
1764         Rubber-stamped by Joseph Pecoraro.
1765
1766         * Configurations/Base.xcconfig:
1767         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1768
1769 2017-12-14  John Wilander  <wilander@apple.com>
1770
1771         Storage Access API: Implement frame-specific access in the document.cookie layer
1772         https://bugs.webkit.org/show_bug.cgi?id=180682
1773         <rdar://problem/35982257>
1774
1775         Reviewed by Alex Christensen.
1776
1777         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1778         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1779         CookiesStrategy::getRawCookies() now take optional parameters for
1780         frameID and pageID to allow frame-specific scoping of cookies.
1781
1782         This change makes the return values of FrameLoaderClient::frameID()
1783         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1784         WebCore can call those getters and get the right return values in
1785         WebKit and std:nullopt in WebKitLegacy.
1786
1787         * WebCoreSupport/WebFrameLoaderClient.h:
1788         * WebCoreSupport/WebFrameLoaderClient.mm:
1789         (WebFrameLoaderClient::pageID const):
1790         (WebFrameLoaderClient::frameID const):
1791         * WebCoreSupport/WebPlatformStrategies.h:
1792         * WebCoreSupport/WebPlatformStrategies.mm:
1793         (WebPlatformStrategies::cookiesForDOM):
1794         (WebPlatformStrategies::setCookiesFromDOM):
1795         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1796         (WebPlatformStrategies::getRawCookies):
1797
1798 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1799
1800         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1801         https://bugs.webkit.org/show_bug.cgi?id=180689
1802
1803         Reviewed by Tim Horton.
1804
1805         Use sRGBColorSpaceRef() from WebCore.
1806
1807         * WebView/WebHTMLView.mm:
1808         (imageFromRect):
1809
1810 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1811
1812         Stop using deprecated target conditional for simulator builds
1813         https://bugs.webkit.org/show_bug.cgi?id=180662
1814         <rdar://problem/35136156>
1815
1816         Reviewed by Simon Fraser.
1817
1818         * postprocess-headers.sh:
1819
1820 2017-12-11  David Quesada  <david_quesada@apple.com>
1821
1822         Turn on ENABLE_APPLICATION_MANIFEST
1823         https://bugs.webkit.org/show_bug.cgi?id=180562
1824         rdar://problem/35924737
1825
1826         Reviewed by Geoffrey Garen.
1827
1828         * Configurations/FeatureDefines.xcconfig:
1829
1830 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1831
1832         Remove pthread_once in favor of dispatch_once
1833         https://bugs.webkit.org/show_bug.cgi?id=180591
1834
1835         Reviewed by Saam Barati.
1836
1837         * Misc/WebKitErrors.m:
1838         (+[NSError _registerWebKitErrors]):
1839         (registerErrors): Deleted.
1840         * Storage/WebStorageManager.mm:
1841         (+[WebStorageManager _storageDirectoryPath]):
1842         (initializeLocalStoragePath): Deleted.
1843
1844 2017-12-07  Darin Adler  <darin@apple.com>
1845
1846         Remove some unused code from WebKitLegacy
1847         https://bugs.webkit.org/show_bug.cgi?id=180567
1848
1849         Reviewed by Anders Carlsson.
1850
1851         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1852         macOS (back a few versions) and iOS and removed unused
1853         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1854         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1855         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1856         _webkit_stringByCollapsingNonPrintingCharacters,
1857         _webkit_stringByCollapsingWhitespaceCharacters,
1858         _web_stringWithData:textEncodingName:, and
1859         _webkit_localStorageDirectoryWithBundleIdentifier:.
1860
1861         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1862         this source file.
1863         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1864         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1865         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1866         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1867         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1868         handle font smoothing options.
1869         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1870         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1871         from header and made it a little clearer.
1872         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1873         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1874         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1875         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1876         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1877         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1878         implementation a bit and used whole words instead of abbreviations.
1879         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1880
1881         * Misc/WebNSFileManagerExtras.mm:
1882         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1883         filenameByFixingIllegalCharacters function from WebCore directly instead of
1884         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1885
1886         * Plugins/WebBaseNetscapePluginView.mm:
1887         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1888         string replacements instead of _web_stringByStrippingReturnCharacters
1889         and to use NSString methods instead of CFString functions.
1890
1891 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1892
1893         Ignore deprecation warnings.
1894
1895         * WebView/WebHTMLView.mm:
1896         (-[NSWindow _web_borderView]):
1897         (-[WebHTMLView _setAsideSubviews]):
1898         * WebView/WebView.mm:
1899         (-[WebView encodeWithCoder:]):
1900
1901 2017-12-02  Darin Adler  <darin@apple.com>
1902
1903         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1904         https://bugs.webkit.org/show_bug.cgi?id=180009
1905
1906         Reviewed by Alex Christensen.
1907
1908         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1909
1910         * Plugins/WebBaseNetscapePluginView.mm:
1911         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1912         of strcasecmp.
1913
1914         * WebView/WebPreferences.mm:
1915         (contains): Ditto. Also made this a template so it's easier to call on an array.
1916         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1917
1918 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1919
1920         Limit user agent versioning to an upper bound
1921         https://bugs.webkit.org/show_bug.cgi?id=180365
1922         <rdar://problem/34550617>
1923
1924         Reviewed by Joseph Pecoraro.
1925
1926         * WebView/WebView.mm:
1927         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1928         creating the User Agent string.
1929         (webKitBundleVersionString): Deleted.
1930
1931 2017-12-05  Andy Estes  <aestes@apple.com>
1932
1933         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1934         https://bugs.webkit.org/show_bug.cgi?id=180457
1935         <rdar://problem/35143007>
1936
1937         Reviewed by Tim Horton.
1938
1939         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1940         check for this macro during post-processing.
1941
1942         * postprocess-headers.sh:
1943
1944 2017-12-04  David Quesada  <david_quesada@apple.com>
1945
1946         Add a class for parsing application manifests
1947         https://bugs.webkit.org/show_bug.cgi?id=177973
1948         rdar://problem/34747949
1949
1950         Reviewed by Geoffrey Garen.
1951
1952         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1953
1954 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1955
1956         Make LegacyCustomProtocolManager optional for network process
1957         https://bugs.webkit.org/show_bug.cgi?id=176230
1958
1959         Reviewed by Alex Christensen.
1960
1961         * Configurations/FeatureDefines.xcconfig:
1962
1963 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1964
1965         Fix some NSOperationQueue leaks
1966         https://bugs.webkit.org/show_bug.cgi?id=180221
1967
1968         Reviewed by Wenson Hsieh.
1969
1970         * WebView/WebView.mm:
1971         (-[WebView performDragOperation:]):
1972
1973 2017-11-30  Darin Adler  <darin@apple.com>
1974
1975         [Mac] remove unneeded RetainPtr use introduced in r225142
1976         https://bugs.webkit.org/show_bug.cgi?id=180202
1977
1978         Reviewed by Tim Horton.
1979
1980         * WebView/WebImmediateActionController.mm:
1981         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1982         RetainPtr.
1983
1984 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1985
1986         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1987         https://bugs.webkit.org/show_bug.cgi?id=175595
1988
1989         Reviewed by Darin Adler.
1990
1991         * WebView/WebPreferences.mm:
1992
1993 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1994
1995         One too many zeroes in macOS version number in FeatureDefines
1996         https://bugs.webkit.org/show_bug.cgi?id=180011
1997
1998         Reviewed by Dan Bernstein.
1999
2000         * Configurations/FeatureDefines.xcconfig:
2001
2002 2017-11-23  Darin Adler  <darin@apple.com>
2003
2004         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2005         https://bugs.webkit.org/show_bug.cgi?id=179981
2006
2007         Reviewed by Sam Weinig.
2008
2009         * WebView/WebImmediateActionController.mm:
2010         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2011         * WebView/WebView.mm:
2012         (coreOptions): Use |= instead of | to build up FindOptions.
2013
2014 2017-11-23  Sam Weinig  <sam@webkit.org>
2015
2016         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2017         https://bugs.webkit.org/show_bug.cgi?id=179954
2018
2019         Reviewed by Darin Adler.
2020
2021         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2022         with direct calls to the corresponding UserGestureIndicator functions.
2023
2024         * Plugins/WebPluginController.mm:
2025         (-[WebPluginController processingUserGesture]):
2026         * WebView/WebView.mm:
2027         (-[WebView _isProcessingUserGesture]):
2028
2029 2017-11-23  Darin Adler  <darin@apple.com>
2030
2031         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2032         https://bugs.webkit.org/show_bug.cgi?id=179907
2033
2034         Reviewed by Sam Weinig.
2035
2036         * History/BinaryPropertyList.cpp:
2037         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2038         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2039         * WebView/WebHTMLRepresentation.mm:
2040         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2041         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2042
2043 2017-11-22  Ali Juma  <ajuma@chromium.org>
2044
2045         Implement VisualViewport API attributes
2046         https://bugs.webkit.org/show_bug.cgi?id=179385
2047
2048         Reviewed by Frédéric Wang.
2049
2050         Add a VisualViewportAPI preference.
2051
2052         * WebView/WebPreferenceKeysPrivate.h:
2053         * WebView/WebPreferences.mm:
2054         (+[WebPreferences initialize]):
2055         (-[WebPreferences visualViewportAPIEnabled]):
2056         (-[WebPreferences setVisualViewportAPIEnabled:]):
2057         * WebView/WebPreferencesPrivate.h:
2058         * WebView/WebView.mm:
2059         (-[WebView _preferencesChanged:]):
2060
2061 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2062
2063         WebCoreObjCExtras.h is being included in too many places
2064         https://bugs.webkit.org/show_bug.cgi?id=179931
2065
2066         Reviewed by Darin Adler.
2067
2068         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2069         * Plugins/WebBaseNetscapePluginView.mm:
2070         * Plugins/WebBasePluginPackage.mm:
2071         * Plugins/WebNetscapePluginStream.mm:
2072         * Plugins/WebNetscapePluginView.mm:
2073         * WebView/WebTextIterator.mm:
2074         * WebView/WebViewData.mm:
2075
2076 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2077
2078         Unreviewed, rolling out r225093.
2079         https://bugs.webkit.org/show_bug.cgi?id=179938
2080
2081         Compilation failed on WinCairo 64-bit Release (Requested by
2082         fredw on #webkit).
2083
2084         Reverted changeset:
2085
2086         "Implement VisualViewport API attributes"
2087         https://bugs.webkit.org/show_bug.cgi?id=179385
2088         https://trac.webkit.org/changeset/225093
2089
2090 2017-11-21  Ali Juma  <ajuma@chromium.org>
2091
2092         Implement VisualViewport API attributes
2093         https://bugs.webkit.org/show_bug.cgi?id=179385
2094
2095         Reviewed by Frédéric Wang.
2096
2097         Add a VisualViewportAPI preference.
2098
2099         * WebView/WebPreferenceKeysPrivate.h:
2100         * WebView/WebPreferences.mm:
2101         (+[WebPreferences initialize]):
2102         (-[WebPreferences visualViewportAPIEnabled]):
2103         (-[WebPreferences setVisualViewportAPIEnabled:]):
2104         * WebView/WebPreferencesPrivate.h:
2105         * WebView/WebView.mm:
2106         (-[WebView _preferencesChanged:]):
2107
2108 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2109
2110         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2111         https://bugs.webkit.org/show_bug.cgi?id=179504
2112
2113         Reviewed by Darin Adler.
2114
2115         * Misc/WebKitNSStringExtras.mm:
2116         * Plugins/Hosted/NetscapePluginHostManager.mm:
2117         * Plugins/WebBasePluginPackage.mm:
2118
2119 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2120
2121         Remove unused TOUCH_ICON_LOADING feature flag
2122         https://bugs.webkit.org/show_bug.cgi?id=179873
2123
2124         Reviewed by Simon Fraser.
2125
2126         * Configurations/FeatureDefines.xcconfig:
2127
2128 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2129
2130         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2131         https://bugs.webkit.org/show_bug.cgi?id=179872
2132
2133         Reviewed by Darin Adler.
2134
2135         * Configurations/FeatureDefines.xcconfig:
2136
2137 2017-11-16  Daniel Bates  <dabates@apple.com>
2138
2139         Add feature define for alternative presentation button element
2140         https://bugs.webkit.org/show_bug.cgi?id=179692
2141         Part of <rdar://problem/34917108>
2142
2143         Reviewed by Andy Estes.
2144
2145         Only enabled on Cocoa platforms by default.
2146
2147         * Configurations/FeatureDefines.xcconfig:
2148
2149 2017-11-14  Nan Wang  <n_wang@apple.com>
2150
2151         AX: AOM: Implement AccessibleNode class and support label and role attributes
2152         https://bugs.webkit.org/show_bug.cgi?id=179494
2153
2154         Reviewed by Ryosuke Niwa.
2155
2156         * WebView/WebPreferenceKeysPrivate.h:
2157         * WebView/WebPreferences.mm:
2158         (+[WebPreferences initialize]):
2159         (-[WebPreferences accessibilityObjectModelEnabled]):
2160         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2161         * WebView/WebPreferencesPrivate.h:
2162         * WebView/WebView.mm:
2163         (-[WebView _preferencesChanged:]):
2164
2165 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2166
2167         Remove Cocoa CFURLConnection loading code
2168         https://bugs.webkit.org/show_bug.cgi?id=179688
2169
2170         Reviewed by Antti Koivisto.
2171
2172         * Misc/WebDownload.mm:
2173         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2174         * Misc/WebDownloadInternal.h:
2175         * Plugins/WebBaseNetscapePluginView.mm:
2176         * WebCoreSupport/WebFrameLoaderClient.mm:
2177         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2178         * WebView/WebView.mm:
2179         (-[WebView scheduleInRunLoop:forMode:]):
2180         (-[WebView unscheduleFromRunLoop:forMode:]):
2181
2182 2017-11-14  Daniel Bates  <dabates@apple.com>
2183
2184         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2185         for feature defines
2186
2187         Following r195498 and r201917 the Visual Studio property files for feature defines have
2188         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2189         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2190         files.
2191
2192         * Configurations/FeatureDefines.xcconfig:
2193
2194 2017-11-14  Jer Noble  <jer.noble@apple.com>
2195
2196         Enable Modern EME tests in DumpRenderTree
2197         https://bugs.webkit.org/show_bug.cgi?id=179544
2198
2199         Reviewed by Alex Christensen.
2200
2201         Add a WebPreferences property to enable the (modern) EME API.
2202
2203         * WebView/WebPreferenceKeysPrivate.h:
2204         * WebView/WebPreferences.mm:
2205         (+[WebPreferences initialize]):
2206         (-[WebPreferences encryptedMediaAPIEnabled]):
2207         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2208         * WebView/WebPreferencesPrivate.h:
2209         * WebView/WebView.mm:
2210         (-[WebView _preferencesChanged:]):
2211
2212 2017-11-14  Antti Koivisto  <antti@apple.com>
2213
2214         Enable display:contents by default
2215         https://bugs.webkit.org/show_bug.cgi?id=179655
2216
2217         Reviewed by Sam Weinig.
2218
2219         * WebView/WebPreferences.mm:
2220         (+[WebPreferences initialize]):
2221
2222 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2223
2224         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2225         https://bugs.webkit.org/show_bug.cgi?id=178751
2226
2227         Reviewed by Brady Eidson.
2228
2229         * WebCoreSupport/WebFrameNetworkingContext.mm:
2230         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2231
2232 2017-11-08  Keith Miller  <keith_miller@apple.com>
2233
2234         Async iteration should only fetch the next method once and add feature flag
2235         https://bugs.webkit.org/show_bug.cgi?id=179451
2236
2237         Reviewed by Geoffrey Garen.
2238
2239         Add feature flag for Async iteration.
2240
2241         * Configurations/FeatureDefines.xcconfig:
2242
2243 2017-11-13  Mark Lam  <mark.lam@apple.com>
2244
2245         Add more overflow check book-keeping for MarkedArgumentBuffer.
2246         https://bugs.webkit.org/show_bug.cgi?id=179634
2247         <rdar://problem/35492517>
2248
2249         Reviewed by Saam Barati.
2250
2251         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2252         (WebKit::NetscapePluginInstanceProxy::invoke):
2253         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2254         (WebKit::NetscapePluginInstanceProxy::construct):
2255
2256 2017-11-12  Darin Adler  <darin@apple.com>
2257
2258         More is<> and downcast<>, less static_cast<>
2259         https://bugs.webkit.org/show_bug.cgi?id=179600
2260
2261         Reviewed by Chris Dumez.
2262
2263         * DOM/DOM.mm:
2264         (kit): Use is/downcast.
2265         * WebCoreSupport/WebEditorClient.mm:
2266         (WebEditorClient::handleKeyboardEvent): Ditto.
2267         (WebEditorClient::handleInputMethodKeydown): Ditto.
2268         * WebView/WebHTMLView.mm:
2269         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2270
2271 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2272
2273         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2274         https://bugs.webkit.org/show_bug.cgi?id=179397
2275
2276         Reviewed by Wenson Hsieh.
2277
2278         * DOM/DOMHTMLInputElement.mm:
2279         (-[DOMHTMLInputElement insertTextSuggestion:]):
2280
2281 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2282
2283         HTMLMediaElement should not use element fullscreen on iOS
2284         https://bugs.webkit.org/show_bug.cgi?id=179418
2285         rdar://problem/35409277
2286
2287         Reviewed by Eric Carlson.
2288
2289         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2290
2291         * Configurations/FeatureDefines.xcconfig:
2292
2293 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2294
2295         Make ResourceLoader::willSendRequestInternal asynchronous
2296         https://bugs.webkit.org/show_bug.cgi?id=179251
2297
2298         Reviewed by Andy Estes.
2299
2300         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2301         (WebKit::HostedNetscapePluginStream::start):
2302         * Plugins/WebNetscapePluginStream.mm:
2303         (WebNetscapePluginStream::start):
2304
2305 2017-11-01  Darin Adler  <darin@apple.com>
2306
2307         Simplify event dispatch code and make it a bit more consistent
2308         https://bugs.webkit.org/show_bug.cgi?id=178991
2309
2310         Reviewed by Chris Dumez.
2311
2312         * DOM/DOMEvent.mm:
2313         (-[DOMEvent srcElement]): Call target instead of srcElement.
2314
2315 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2316
2317         [Touch Bar Web API] Add support for menuitem tag
2318         https://bugs.webkit.org/show_bug.cgi?id=179020
2319
2320         Reviewed by Ryosuke Niwa.
2321
2322         Adds in properties and methods that allow the menuitem runtime feature
2323         to be enabled or disabled.
2324
2325         * WebView/WebPreferenceKeysPrivate.h:
2326         * WebView/WebPreferences.mm:
2327         (-[WebPreferences menuItemElementEnabled]):
2328         (-[WebPreferences setMenuItemElementEnabled:]):
2329         * WebView/WebPreferencesPrivate.h:
2330         * WebView/WebView.mm:
2331         (-[WebView _preferencesChanged:]):
2332
2333 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2334
2335         Use CompletionHandlers for redirects
2336         https://bugs.webkit.org/show_bug.cgi?id=179163
2337
2338         Reviewed by Tim Horton.
2339
2340         * Plugins/Hosted/HostedNetscapePluginStream.h:
2341         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2342         (WebKit::HostedNetscapePluginStream::willSendRequest):
2343         * Plugins/WebNetscapePluginStream.h:
2344         * Plugins/WebNetscapePluginStream.mm:
2345         (WebNetscapePluginStream::willSendRequest):
2346
2347 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2348
2349         Add a FileSystem namespace to FileSystem.cpp
2350         https://bugs.webkit.org/show_bug.cgi?id=179063
2351
2352         Reviewed by Darin Adler.
2353
2354         * Misc/WebNSFileManagerExtras.mm:
2355         * Storage/WebDatabaseProvider.mm:
2356
2357 2017-11-02  Frederic Wang  <fwang@igalia.com>
2358
2359         Add references to bug 179167 in FIXME comments
2360         https://bugs.webkit.org/show_bug.cgi?id=179168
2361
2362         Reviewed by Daniel Bates.
2363
2364         * Configurations/FeatureDefines.xcconfig:
2365
2366 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2367
2368         Implement WKFullscreenWindowController for iOS.
2369         https://bugs.webkit.org/show_bug.cgi?id=178924
2370         rdar://problem/34697120
2371
2372         Reviewed by Simon Fraser.
2373
2374         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2375
2376         * Configurations/FeatureDefines.xcconfig:
2377         * WebView/WebView.mm:
2378         (-[WebView fullScreenPlaceholderView]):
2379
2380 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2381
2382         Clean up some drag and drop feature flags
2383         https://bugs.webkit.org/show_bug.cgi?id=179082
2384
2385         Reviewed by Simon Fraser.
2386
2387         * Configurations/FeatureDefines.xcconfig:
2388
2389 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2390
2391         Make it possible to test rubber-banding in overflow scroll
2392         https://bugs.webkit.org/show_bug.cgi?id=179078
2393
2394         Reviewed by Sam Weinig.
2395
2396         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2397         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2398
2399         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2400         functions, since most callers want clamped.
2401
2402         * DOM/DOMHTML.mm:
2403         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2404
2405 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2406
2407         Fix up some content filtering feature flags
2408         https://bugs.webkit.org/show_bug.cgi?id=179079
2409
2410         Reviewed by Simon Fraser.
2411
2412         * Configurations/FeatureDefines.xcconfig:
2413
2414 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2415
2416         [FrameView::layout cleanup] Move core layout logic to a separate class.
2417         https://bugs.webkit.org/show_bug.cgi?id=178771
2418         <rdar://problem/35166542>
2419
2420         Reviewed by Simon Fraser.
2421
2422         Move layout code out from FrameView to LayoutContext.
2423
2424         * WebView/WebClipView.mm:
2425         (-[WebClipView _immediateScrollToPoint:]):
2426         * WebView/WebFrame.mm:
2427         (-[WebFrame layoutCount]):
2428
2429 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2430
2431         Fix issues with WebView subframe painting
2432         https://bugs.webkit.org/show_bug.cgi?id=178842
2433         rdar://problem/34072253
2434
2435         Reviewed by Daniel Bates.
2436         
2437         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2438         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2439         High Sierra, so match the new signature.
2440
2441         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2442
2443         * WebView/WebHTMLView.mm:
2444         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2445         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2446
2447 2017-10-25  Youenn Fablet  <youenn@apple.com>
2448
2449         Enable ServiceWorker to fetch resources
2450         https://bugs.webkit.org/show_bug.cgi?id=178673
2451
2452         Reviewed by Brady Eidson.
2453
2454         * WebCoreSupport/WebFrameLoaderClient.mm:
2455         (WebFrameLoaderClient::pageID const):
2456         (WebFrameLoaderClient::frameID const):
2457         (WebFrameLoaderClient::sessionID const):
2458
2459         Added implementation to the new getters.
2460         They are noop in the context of WK1.
2461
2462 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2463
2464         Web Inspector: Enable WebKit logging configuration and display
2465         https://bugs.webkit.org/show_bug.cgi?id=177027
2466         <rdar://problem/33964767>
2467
2468         Reviewed by Joseph Pecoraro.
2469
2470         * WebCoreSupport/WebChromeClient.mm:
2471         (stringForMessageSource): Deal with Media and WebRTC message sources.
2472
2473 2017-10-20  Antoine Quint  <graouts@apple.com>
2474
2475         [Web Animations] Provide basic timeline and animation interfaces
2476         https://bugs.webkit.org/show_bug.cgi?id=178526
2477
2478         Reviewed by Dean Jackson.
2479
2480         Remove the WEB_ANIMATIONS compile-time flag.
2481
2482         * Configurations/FeatureDefines.xcconfig:
2483         * WebView/WebPreferences.mm:
2484         (+[WebPreferences initialize]):
2485         * WebView/WebView.mm:
2486         (-[WebView _preferencesChanged:]):
2487
2488 2017-10-19  Sam Weinig  <sam@webkit.org>
2489
2490         [Settings] Move global settings into their own file
2491         https://bugs.webkit.org/show_bug.cgi?id=178512
2492
2493         Reviewed by Darin Adler.
2494
2495         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2496
2497         * WebCoreSupport/WebChromeClient.mm:
2498         (WebChromeClient::supportsVideoFullscreen):
2499         * WebView/WebDynamicScrollBarsView.mm:
2500         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2501         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2502         * WebView/WebPreferences.mm:
2503         (+[WebPreferences initialize]):
2504         * WebView/WebView.mm:
2505         (-[WebView _commonInitializationWithFrameName:groupName:]):
2506         (-[WebView _preferencesChanged:]):
2507         (+[WebView _doNotStartObservingNetworkReachability]):
2508
2509 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2510
2511         Replace some stack raw pointers with RefPtrs within WebCore/html
2512         https://bugs.webkit.org/show_bug.cgi?id=178201
2513         <rdar://problem/34841692>
2514
2515         Reviewed by Ryosuke Niwa.
2516
2517         * DOM/DOM.mm:
2518         (kit):
2519         Change the type of node as toNode() is changed to return RefPtr.
2520
2521 2017-10-18  Chris Dumez  <cdumez@apple.com>
2522
2523         [Service Worker] Add stubs for Client / WindowClient / Clients
2524         https://bugs.webkit.org/show_bug.cgi?id=178469
2525
2526         Reviewed by Youenn Fablet.
2527
2528         Rename PageVisiblityState to VisibilityState.
2529
2530         * WebView/WebView.mm:
2531         (kit):
2532
2533 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         Unreviewed, rolling out r223291.
2536
2537         See WebCore ChangeLog for more detail.
2538
2539         Reverted changeset:
2540
2541         "Remove Editor::simplifyMarkup"
2542         https://bugs.webkit.org/show_bug.cgi?id=178271
2543         https://trac.webkit.org/changeset/223291
2544
2545 2017-10-17  Keith Miller  <keith_miller@apple.com>
2546
2547         Change WebCore sources to work with unified source builds
2548         https://bugs.webkit.org/show_bug.cgi?id=178229
2549
2550         Rubber stamped by Tim Horton.
2551
2552         * Configurations/FeatureDefines.xcconfig:
2553
2554 2017-10-16  Sam Weinig  <sam@webkit.org>
2555
2556         [Settings] Remove all custom code from Settings.h/cpp
2557         https://bugs.webkit.org/show_bug.cgi?id=178330
2558
2559         Reviewed by Simon Fraser.
2560
2561         * WebView/WebPreferences.mm:
2562         (+[WebPreferences initialize]):
2563         
2564             Update for naming changes of FrameFlattening now that it is an enum class.
2565
2566 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2567
2568         Remove Editor::simplifyMarkup
2569         https://bugs.webkit.org/show_bug.cgi?id=178271
2570
2571         Reviewed by Wenson Hsieh.
2572
2573         * WebView/WebView.mm:
2574         (-[WebView _simplifyMarkup:endNode:]):
2575
2576 2017-10-12  Chris Dumez  <cdumez@apple.com>
2577
2578         [Mac] Add support for MouseEvent.buttons
2579         https://bugs.webkit.org/show_bug.cgi?id=178214
2580
2581         Reviewed by Ryosuke Niwa.
2582
2583         * WebView/WebPDFView.mm:
2584         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2585
2586 2017-10-11  Sam Weinig  <sam@webkit.org>
2587
2588         Remove out-parameter variants of copyToVector
2589         https://bugs.webkit.org/show_bug.cgi?id=178155
2590
2591         Reviewed by Tim Horton.
2592
2593         * Plugins/WebNetscapePluginView.mm:
2594         (-[WebNetscapePluginView destroyPlugin]):
2595         * WebView/WebHTMLRepresentation.mm:
2596         (newArrayWithStrings):
2597
2598             Replace out-parameter based copyToVector, with one that returns a Vector.
2599
2600 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2601
2602         Sanitize URL in pasteboard for other applications and cross origin content
2603         https://bugs.webkit.org/show_bug.cgi?id=178060
2604         <rdar://problem/34874518>
2605
2606         Reviewed by Wenson Hsieh.
2607
2608         * WebCoreSupport/WebPlatformStrategies.h:
2609         * WebCoreSupport/WebPlatformStrategies.mm:
2610         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2611
2612 2017-10-11  Chris Dumez  <cdumez@apple.com>
2613
2614         Modernize Geolocation code
2615         https://bugs.webkit.org/show_bug.cgi?id=178148
2616
2617         Reviewed by Ryosuke Niwa.
2618
2619         * WebCoreSupport/WebGeolocationClient.h:
2620         * WebCoreSupport/WebGeolocationClient.mm:
2621         (WebGeolocationClient::lastPosition):
2622         * WebView/WebGeolocationPosition.mm:
2623         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2624         (core):
2625         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2626         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2627         * WebView/WebGeolocationPositionInternal.h:
2628
2629 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2630
2631         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2632         https://bugs.webkit.org/show_bug.cgi?id=178154
2633
2634         Reviewed by Wenson Hsieh.
2635
2636         Enable custom pasteboard data by default.
2637
2638         * WebView/WebPreferenceKeysPrivate.h:
2639         * WebView/WebPreferences.mm:
2640         (+[WebPreferences initialize]):
2641         (-[WebPreferences customPasteboardDataEnabled]): Added.
2642         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2643         * WebView/WebPreferencesPrivate.h:
2644         * WebView/WebView.mm:
2645         (-[WebView _preferencesChanged:]):
2646
2647 2017-10-10  Sam Weinig  <sam@webkit.org>
2648
2649         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2650         https://bugs.webkit.org/show_bug.cgi?id=178102
2651
2652         Reviewed by Tim Horton.
2653
2654         * History/WebHistory.mm:
2655         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2656         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2657         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2658         * WebCoreSupport/WebUserMediaClient.mm:
2659         (WebUserMediaClient::pageDestroyed):
2660
2661 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2662
2663         Make the names of the options consistent
2664         https://bugs.webkit.org/show_bug.cgi?id=177933
2665
2666         Reviewed by Saam Barati.
2667
2668         * WebView/WebFrame.h:
2669         * WebView/WebHTMLView.mm:
2670         (-[WebHTMLView setMarkedText:selectedRange:]):
2671         * WebView/WebView.h:
2672
2673 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         [iOS] Tweak support for classifying form controls (followup to r222487)
2676         https://bugs.webkit.org/show_bug.cgi?id=177917
2677         <rdar://problem/34820122>
2678
2679         Reviewed by Dean Jackson.
2680
2681         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2682
2683         * DOM/DOMHTMLInputElement.mm:
2684         (-[DOMHTMLInputElement _autofillContext]):
2685         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2686         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2687
2688 2017-10-05  Keith Miller  <keith_miller@apple.com>
2689
2690         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2691
2692         * Configurations/WebKitLegacy.xcconfig:
2693
2694 2017-10-05  Jer Noble  <jer.noble@apple.com>
2695
2696         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2697         https://bugs.webkit.org/show_bug.cgi?id=177261
2698
2699         Reviewed by Eric Carlson.
2700
2701         * Configurations/FeatureDefines.xcconfig:
2702
2703 2017-10-05  Chris Dumez  <cdumez@apple.com>
2704
2705         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2706         https://bugs.webkit.org/show_bug.cgi?id=177957
2707
2708         Reviewed by Alex Christensen.
2709
2710         * WebCoreSupport/WebPlatformStrategies.h:
2711         * WebCoreSupport/WebPlatformStrategies.mm:
2712         (WebPlatformStrategies::cookiesEnabled):
2713
2714 2017-10-05  Youenn Fablet  <youenn@apple.com>
2715
2716         Make LibWebRTCProvider port agnostic
2717         https://bugs.webkit.org/show_bug.cgi?id=177747
2718
2719         Reviewed by Alex Christensen & Alex Garcia.
2720
2721         * WebView/WebView.mm:
2722         (-[WebView _commonInitializationWithFrameName:groupName:]):
2723         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2724
2725 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2726
2727         Stop linking with WebKitSystemInterface
2728         https://bugs.webkit.org/show_bug.cgi?id=177915
2729
2730         Reviewed by Antti Koivisto.
2731
2732         * Configurations/DebugRelease.xcconfig:
2733         * Configurations/WebKitLegacy.xcconfig:
2734
2735 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2736
2737         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2738         https://bugs.webkit.org/show_bug.cgi?id=177912
2739
2740         Reviewed by Saam Barati.
2741
2742         * Carbon/CarbonUtils.m:
2743         * Carbon/CarbonWindowAdapter.mm:
2744         * Carbon/HIWebView.mm:
2745         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2746         * Misc/WebNSFileManagerExtras.mm:
2747         * Misc/WebNSPasteboardExtras.mm:
2748         * Misc/WebNSURLExtras.mm:
2749         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2750         * Plugins/Hosted/NetscapePluginHostManager.mm:
2751         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2752         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2753         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2754         * Plugins/Hosted/WebTextInputWindowController.m:
2755         * Plugins/WebBaseNetscapePluginView.mm:
2756         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2757         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2758         * Plugins/WebNetscapePluginStream.mm:
2759         * Plugins/WebNetscapePluginView.mm:
2760         * Plugins/WebPluginDatabase.mm:
2761         * WebCoreSupport/PopupMenuMac.mm:
2762         * WebCoreSupport/WebChromeClient.mm:
2763         * WebCoreSupport/WebFrameLoaderClient.mm:
2764         * WebCoreSupport/WebInspectorClient.mm:
2765         * WebCoreSupport/WebPlatformStrategies.mm:
2766         * WebCoreSupport/WebSystemInterface.mm:
2767         * WebView/WebDynamicScrollBarsView.mm:
2768         * WebView/WebFrame.mm:
2769         * WebView/WebFrameView.mm:
2770         * WebView/WebFullScreenController.mm:
2771         * WebView/WebHTMLView.mm:
2772         * WebView/WebPreferences.mm:
2773         * WebView/WebView.mm:
2774
2775 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2776
2777         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2778         rdar://problem/34705779
2779
2780         Addressing review comments that I somehow landed without.
2781
2782         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2783
2784 2017-09-29  Chris Dumez  <cdumez@apple.com>
2785
2786         Split some logic out of VisitedLinkStore and make it reusable
2787         https://bugs.webkit.org/show_bug.cgi?id=177575
2788
2789         Reviewed by Alex Christensen.
2790
2791         * WebCoreSupport/WebVisitedLinkStore.h:
2792         * WebCoreSupport/WebVisitedLinkStore.mm:
2793         (WebVisitedLinkStore::addVisitedLink):
2794         (WebVisitedLinkStore::removeVisitedLink):
2795         (WebVisitedLinkStore::isLinkVisited):
2796         (WebVisitedLinkStore::addVisitedLinkHash):
2797
2798 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2799
2800         Build fix for High Sierra 32 bit Mac
2801         https://bugs.webkit.org/show_bug.cgi?id=177551
2802         <rdar://problem/34690283>
2803
2804         Reviewed by Alexey Proskuryakov.
2805
2806         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2807         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2808         also made.
2809
2810         * Carbon/CarbonWindowAdapter.mm:
2811         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2812         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2813         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2814         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2815         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2816         (-[CarbonWindowAdapter dealloc]):
2817         (-[CarbonWindowAdapter windowRef]):
2818         (-[CarbonWindowAdapter _hasWindowRef]):
2819         (-[CarbonWindowAdapter _managesWindowRef]):
2820         (-[CarbonWindowAdapter _removeWindowRef]):
2821         (-[CarbonWindowAdapter _carbonWindowClass]):
2822         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2823         (-[CarbonWindowAdapter sendSuperEvent:]):
2824         (-[CarbonWindowAdapter relinquishFocus]):
2825         (-[CarbonWindowAdapter _cancelKey:]):
2826         (-[CarbonWindowAdapter _commonAwake]):
2827         (-[CarbonWindowAdapter _destroyRealWindow:]):
2828         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2829         (-[CarbonWindowAdapter _termWindowIfOwner]):
2830         (-[CarbonWindowAdapter _windowMovedToRect:]):
2831         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2832         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2833         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2834         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2835         (-[CarbonWindowAdapter canBecomeMainWindow]):
2836         (-[CarbonWindowAdapter encodeWithCoder:]):
2837         (-[CarbonWindowAdapter initWithCoder:]):
2838         (-[CarbonWindowAdapter setContentView:]):
2839         (-[CarbonWindowAdapter worksWhenModal]):
2840         (-[CarbonWindowAdapter _setModalWindowLevel]):
2841         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2842         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2843         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2844         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2845         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2846         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2847         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2848         (NSCarbonWindowHandleEvent):
2849         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2850         (-[CarbonWindowAdapter _growBoxRect]):
2851         * Carbon/HIWebView.mm:
2852         (HIWebViewGetWebView):
2853         (HIWebViewConstructor):
2854         (HIWebViewDestructor):
2855         (HIWebViewRegisterClass):
2856         (GetBehaviors):
2857         (Draw):
2858         (HitTest):
2859         (GetRegion):
2860         (GetWindowRef):
2861         (CreateNSEventAdoptingCGEvent):
2862         (CopyEventCGEvent):
2863         (CreateNSEventWithCarbonClickEvent):
2864         (Click):
2865         (CreateNSEventWithCarbonEvent):
2866         (MouseUp):
2867         (CreateNSEventWithCarbonMouseMoveEvent):
2868         (MouseMoved):
2869         (MouseDragged):
2870         (MouseWheelMoved):
2871         (ContextMenuClick):
2872         (GetKind):
2873         (BoundsChanged):
2874         (OwningWindowChanged):
2875         (WindowHandler):
2876         (SyncFrame):
2877         (SetFocusPart):
2878         (AdvanceFocus):
2879         (RelinquishFocus):
2880         (ActiveStateChanged):
2881         (ProcessCommand):
2882         (UpdateCommandStatus):
2883         (_NSSelectorForHICommand):
2884         (HIWebViewEventHandler):
2885         (StartUpdateObserver):
2886         (StopUpdateObserver):
2887         (UpdateObserver):
2888
2889 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2890
2891         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2892         https://bugs.webkit.org/show_bug.cgi?id=172526
2893         <rdar://problem/32396081>
2894
2895         Reviewed by Ryosuke Niwa.
2896
2897         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2898
2899         * WebCoreSupport/WebPlatformStrategies.h:
2900         * WebCoreSupport/WebPlatformStrategies.mm:
2901         (WebPlatformStrategies::webExposedTypes):
2902         (WebPlatformStrategies::writeCustomData):
2903
2904 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2905
2906         Unreviewed, rolling out r222567.
2907
2908         This broke and internal build.
2909
2910         Reverted changeset:
2911
2912         "Build fix for High Sierra 32 bit Mac"
2913         https://bugs.webkit.org/show_bug.cgi?id=177551
2914         http://trac.webkit.org/changeset/222567
2915
2916 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2917
2918         Build fix for High Sierra 32 bit Mac
2919         https://bugs.webkit.org/show_bug.cgi?id=177551
2920         <rdar://problem/34690283>
2921
2922         Reviewed by Alexey Proskuryakov.
2923
2924         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2925         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2926         also made.
2927
2928         * Carbon/CarbonWindowAdapter.mm:
2929         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2930         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2931         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2932         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2933         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2934         (-[CarbonWindowAdapter dealloc]):
2935         (-[CarbonWindowAdapter windowRef]):
2936         (-[CarbonWindowAdapter _hasWindowRef]):
2937         (-[CarbonWindowAdapter _managesWindowRef]):
2938         (-[CarbonWindowAdapter _removeWindowRef]):
2939         (-[CarbonWindowAdapter _carbonWindowClass]):
2940         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2941         (-[CarbonWindowAdapter sendSuperEvent:]):
2942         (-[CarbonWindowAdapter relinquishFocus]):
2943         (-[CarbonWindowAdapter _cancelKey:]):
2944         (-[CarbonWindowAdapter _commonAwake]):
2945         (-[CarbonWindowAdapter _destroyRealWindow:]):
2946         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2947         (-[CarbonWindowAdapter _termWindowIfOwner]):
2948         (-[CarbonWindowAdapter _windowMovedToRect:]):
2949         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2950         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2951         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2952         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2953         (-[CarbonWindowAdapter canBecomeMainWindow]):
2954         (-[CarbonWindowAdapter encodeWithCoder:]):
2955         (-[CarbonWindowAdapter initWithCoder:]):
2956         (-[CarbonWindowAdapter setContentView:]):
2957         (-[CarbonWindowAdapter worksWhenModal]):
2958         (-[CarbonWindowAdapter _setModalWindowLevel]):
2959         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2960         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2961         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2962         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2963         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2964         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2965         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2966         (NSCarbonWindowHandleEvent):
2967         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2968         (-[CarbonWindowAdapter _growBoxRect]):
2969         * Carbon/HIWebView.mm:
2970         (HIWebViewGetWebView):
2971         (HIWebViewConstructor):
2972         (HIWebViewDestructor):
2973         (HIWebViewRegisterClass):
2974         (GetBehaviors):
2975         (Draw):
2976         (HitTest):
2977         (GetRegion):
2978         (GetWindowRef):
2979         (CreateNSEventAdoptingCGEvent):
2980         (CopyEventCGEvent):
2981         (CreateNSEventWithCarbonClickEvent):
2982         (Click):
2983         (CreateNSEventWithCarbonEvent):
2984         (MouseUp):
2985         (CreateNSEventWithCarbonMouseMoveEvent):
2986         (MouseMoved):
2987         (MouseDragged):
2988         (MouseWheelMoved):
2989         (ContextMenuClick):
2990         (GetKind):
2991         (BoundsChanged):
2992         (OwningWindowChanged):
2993         (WindowHandler):
2994         (SyncFrame):
2995         (SetFocusPart):
2996         (AdvanceFocus):
2997         (RelinquishFocus):
2998         (ActiveStateChanged):
2999         (ProcessCommand):
3000         (UpdateCommandStatus):
3001         (_NSSelectorForHICommand):
3002         (HIWebViewEventHandler):
3003         (StartUpdateObserver):
3004         (StopUpdateObserver):
3005         (UpdateObserver):
3006
3007 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3008
3009         Make PolicyAction an encodable enum class
3010         https://bugs.webkit.org/show_bug.cgi?id=177480
3011
3012         Reviewed by Antti Koivisto.
3013
3014         * Plugins/WebPluginContainerCheck.mm:
3015         (-[WebPluginContainerCheck _continueWithPolicy:]):
3016         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3017         * WebCoreSupport/WebFrameLoaderClient.mm:
3018         (-[WebFramePolicyListener invalidate]):
3019         (-[WebFramePolicyListener ignore]):
3020         (-[WebFramePolicyListener download]):
3021         (-[WebFramePolicyListener use]):
3022         (-[WebFramePolicyListener continue]):
3023         * WebView/WebPolicyDelegate.mm:
3024         (-[WebPolicyDecisionListener use]):
3025         (-[WebPolicyDecisionListener ignore]):
3026         (-[WebPolicyDecisionListener download]):
3027
3028 2017-09-25  Frederik Riedel  <riedel@apple.com>
3029
3030         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3031         https://bugs.webkit.org/show_bug.cgi?id=174394
3032         <rdar://problem/33183504>
3033
3034         Reviewed by Ryosuke Niwa.
3035
3036         * DOM/DOMHTMLInputElement.h:
3037         * DOM/DOMHTMLInputElement.mm:
3038         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3039         Determines if this HTMLInputElement is part of a login screen.
3040         (-[DOMHTMLInputElement representingPageUrl]):
3041         Returns the webpage's URL that is currently displayed in the Web View.
3042         (-[DOMHTMLInputElement insertTextSuggestion:]):
3043         Inserts login credentials into the Web View.
3044
3045 2017-09-25  Sam Weinig  <sam@webkit.org>
3046
3047         Remove unused EditorClient functions
3048         https://bugs.webkit.org/show_bug.cgi?id=177463
3049
3050         Reviewed by Alex Christensen.
3051
3052         Remove unused EditorClient functions.
3053
3054         * WebCoreSupport/WebEditorClient.h:
3055         * WebCoreSupport/WebEditorClient.mm:
3056         (WebEditorClient::canonicalizeURL): Deleted.
3057         (WebEditorClient::canonicalizeURLString): Deleted.
3058         (WebEditorClient::writeDataToPasteboard): Deleted.
3059         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3060         (WebEditorClient::readDataFromPasteboard): Deleted.
3061         (WebEditorClient::pasteboardChangeCount): Deleted.
3062
3063 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3064
3065         Stop using PolicyCallback
3066         https://bugs.webkit.org/show_bug.cgi?id=176088
3067
3068         Reviewed by Andy Estes.
3069
3070         * WebCoreSupport/WebFrameLoaderClient.mm:
3071         (-[WebFramePolicyListener invalidate]):
3072         (-[WebFramePolicyListener receivedPolicyDecision:]):
3073
3074 2017-09-25  Sam Weinig  <sam@webkit.org>
3075
3076         Remove unnecessary userVisibleString EditorClient function
3077         https://bugs.webkit.org/show_bug.cgi?id=177456
3078
3079         Reviewed by Dan Bernstein.
3080
3081         * WebCoreSupport/WebEditorClient.h:
3082         * WebCoreSupport/WebEditorClient.mm:
3083         (WebEditorClient::userVisibleString): Deleted.
3084
3085             Remove userVisibleString client function.
3086
3087 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3088
3089         Separate form submission from PolicyChecker infrastructure
3090         https://bugs.webkit.org/show_bug.cgi?id=177396
3091
3092         Reviewed by Geoffrey Garen.
3093
3094         * WebCoreSupport/WebFrameLoaderClient.h:
3095         * WebCoreSupport/WebFrameLoaderClient.mm:
3096         (WebFrameLoaderClient::dispatchWillSubmitForm):
3097
3098 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3099
3100         WeakPtrFactory should populate m_ref lazily.
3101         https://bugs.webkit.org/show_bug.cgi?id=177375
3102
3103         Reviewed by Geoffrey Garen.
3104
3105         * WebCoreSupport/WebEditorClient.mm:
3106         (WebEditorClient::WebEditorClient):
3107         (WebEditorClient::requestCandidatesForSelection):
3108
3109 2017-09-22  Chris Dumez  <cdumez@apple.com>
3110
3111         Use high resolution timestamp for event time
3112         https://bugs.webkit.org/show_bug.cgi?id=154246
3113         <rdar://problem/34333304>
3114
3115         Reviewed by Ryosuke Niwa.
3116
3117         Use WallTime / MonotonicTime instead of double type for clarity.
3118
3119         * DOM/DOMEvent.mm:
3120         (-[DOMEvent timeStamp]):
3121         * WebView/WebFrame.mm:
3122         (-[WebFrame _dragSourceEndedAt:operation:]):
3123         * WebView/WebPDFView.mm:
3124         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3125
3126 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3127
3128         Enable dataTransfer.items on macOS and iOS
3129         https://bugs.webkit.org/show_bug.cgi?id=177335
3130
3131         Reviewed by Sam Weinig.
3132
3133         * WebView/WebPreferences.mm:
3134         (+[WebPreferences initialize]):
3135
3136 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3137
3138         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3139         https://bugs.webkit.org/show_bug.cgi?id=177101
3140         <rdar://problem/34500648>
3141
3142         Reviewed by Brian Burg.
3143
3144         * WebInspector/WebNodeHighlight.mm:
3145         Ensure we close the window that we have just removed.
3146
3147 2017-09-20  Antti Koivisto  <antti@apple.com>
3148
3149         Remove DOM and styling support for CSS Regions
3150         https://bugs.webkit.org/show_bug.cgi?id=177221
3151
3152         Reviewed by Andreas Kling.
3153
3154         * Configurations/FeatureDefines.xcconfig:
3155         * DOM/DOMCSS.mm:
3156         (kitClass):
3157         * DOM/DOMElement.mm:
3158         (-[DOMElement webkitRegionOverset]): Deleted.
3159
3160 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3161
3162         Layering violation in Editor::createFragment
3163         https://bugs.webkit.org/show_bug.cgi?id=176123
3164
3165         Reviewed by Darin Adler.
3166
3167         * Misc/WebNSURLExtras.h:
3168         * Misc/WebNSURLExtras.mm:
3169         * WebView/WebFrame.mm:
3170         * WebView/WebHTMLView.mm:
3171         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3172
3173         * WebCoreSupport/WebEditorClient.mm:
3174         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3175         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3176         way to avoid exporting the symbol just on newer OSes.
3177
3178 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3179
3180         On iOS, getData can't get text set by setData during copy event
3181         https://bugs.webkit.org/show_bug.cgi?id=176980
3182         <rdar://problem/34453915>
3183
3184         Reviewed by Darin Adler.
3185
3186         * WebCoreSupport/WebPlatformStrategies.h:
3187         * WebCoreSupport/WebPlatformStrategies.mm:
3188         (WebPlatformStrategies::copy): Deleted.
3189
3190 2017-09-18  Andy Estes  <aestes@apple.com>
3191
3192         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3193         https://bugs.webkit.org/show_bug.cgi?id=177029
3194
3195         Reviewed by Alex Christensen.
3196
3197         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3198         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3199         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3200         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3201         * WebCoreSupport/PopupMenuMac.mm:
3202         (PopupMenuMac::show):
3203         * WebCoreSupport/WebSystemInterface.mm:
3204         (InitWebCoreSystemInterface):
3205         * WebView/WebHTMLView.mm:
3206         (-[WebHTMLView setDataSource:]):
3207         (-[WebHTMLView attachRootLayer:]):
3208         * WebView/WebView.mm:
3209         (-[WebView _needsAdobeFrameReloadingQuirk]):
3210         (-[WebView _needsLinkElementTextCSSQuirk]):
3211         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3212         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3213         (-[WebView _preferencesChanged:]):
3214
3215 2017-09-15  Andy Estes  <aestes@apple.com>
3216
3217         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3218         https://bugs.webkit.org/show_bug.cgi?id=176953
3219
3220         Reviewed by Eric Carlson.
3221
3222         * WebCoreSupport/WebSystemInterface.mm:
3223         (InitWebCoreSystemInterface):
3224
3225 2017-09-14  Andy Estes  <aestes@apple.com>
3226
3227         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3228         https://bugs.webkit.org/show_bug.cgi?id=176931
3229
3230         Reviewed by Joseph Pecoraro.
3231
3232         * WebCoreSupport/WebSystemInterface.mm:
3233         (InitWebCoreSystemInterface):
3234
3235 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3236
3237         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3238         https://bugs.webkit.org/show_bug.cgi?id=176867
3239
3240         Reviewed by Sam Weinig.
3241
3242         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3243         (WebKit::NetscapePluginInstanceProxy::enumerate):
3244
3245 2017-09-13  Andy Estes  <aestes@apple.com>
3246
3247         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3248         https://bugs.webkit.org/show_bug.cgi?id=176729
3249
3250         Reviewed by Alex Christensen.
3251
3252         * WebCoreSupport/WebSystemInterface.mm:
3253         (InitWebCoreSystemInterface):
3254         * WebView/WebView.mm:
3255         (+[WebView _setCacheModel:]):
3256
3257 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3258
3259         Refactor WebContentReader out of EditorMac and EditorIOS
3260         https://bugs.webkit.org/show_bug.cgi?id=176770
3261
3262         Reviewed by Sam Weinig.
3263
3264         * WebCoreSupport/WebEditorClient.mm:
3265
3266 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3267
3268         Dragging & dropping a file creates an attachment element even when it's disabled
3269         https://bugs.webkit.org/show_bug.cgi?id=176769
3270
3271         Reviewed by Tim Horton.
3272
3273         * WebView/WebView.mm:
3274         (-[WebView _preferencesChanged:]):
3275
3276 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3277
3278         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3279         https://bugs.webkit.org/show_bug.cgi?id=176721
3280         <rdar://problem/34373660>
3281
3282         Reviewed by Tim Horton.
3283
3284         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3285         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3286
3287         * WebView/WebView.mm:
3288         (-[WebView _startDrag:]):
3289         (-[WebView _draggedElementBounds]):
3290         (-[WebView _endedDataInteraction:global:]):
3291         * WebView/WebViewData.h:
3292
3293 2017-09-11  Andy Estes  <aestes@apple.com>
3294
3295         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3296         https://bugs.webkit.org/show_bug.cgi?id=176472
3297
3298         Reviewed by Eric Carlson.
3299
3300         * WebCoreSupport/WebSystemInterface.mm:
3301         (InitWebCoreSystemInterface):
3302
3303 2017-09-09  Mark Lam  <mark.lam@apple.com>
3304
3305         Avoid duplicate computations of ExecState::vm().
3306         https://bugs.webkit.org/show_bug.cgi?id=176647
3307
3308         Reviewed by Saam Barati.
3309
3310         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3311         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3312         (WebKit::NetscapePluginInstanceProxy::construct):
3313         (WebKit::NetscapePluginInstanceProxy::setProperty):
3314         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3315         (WebKit::NetscapePluginInstanceProxy::enumerate):
3316         * Plugins/Hosted/ProxyInstance.mm:
3317         (WebKit::ProxyRuntimeMethod::create):
3318
3319 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3320
3321         Unreviewed, rolling out r221773.
3322         https://bugs.webkit.org/show_bug.cgi?id=176614
3323
3324         This caused build failures. (Requested by mlewis13 on
3325         #webkit).
3326
3327         Reverted changeset:
3328
3329         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3330         https://bugs.webkit.org/show_bug.cgi?id=176472
3331         http://trac.webkit.org/changeset/221773
3332
3333 2017-09-07  Andy Estes  <aestes@apple.com>
3334
3335         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3336         https://bugs.webkit.org/show_bug.cgi?id=176472
3337
3338         Reviewed by Eric Carlson.
3339
3340         * WebCoreSupport/WebSystemInterface.mm:
3341         (InitWebCoreSystemInterface):
3342
3343 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3344
3345         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3346         https://bugs.webkit.org/show_bug.cgi?id=176561
3347
3348         Reviewed by Brent Fulgham.
3349
3350         * Misc/WebNSUserDefaultsExtras.mm:
3351
3352 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3353
3354         Modernize Geolocation code
3355         https://bugs.webkit.org/show_bug.cgi?id=176496
3356
3357         Reviewed by Andy Estes.
3358
3359         * WebCoreSupport/WebGeolocationClient.h:
3360         * WebCoreSupport/WebGeolocationClient.mm:
3361         (WebGeolocationClient::requestPermission):
3362         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3363         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3364         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3365         * WebView/WebView.mm:
3366         (-[WebView _commonInitializationWithFrameName:groupName:]):
3367         (-[WebView _geolocationDidFailWithMessage:]):
3368
3369 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3370
3371         Remove some unused bits of code and resources
3372         https://bugs.webkit.org/show_bug.cgi?id=176275
3373
3374         Reviewed by Dan Bernstein.
3375
3376         * Misc/WebNSFileManagerExtras.mm:
3377         Include FileSystem instead of FileSystemIOS.
3378
3379 2017-09-03  Darin Adler  <darin@apple.com>
3380
3381         [Cocoa] Tidy a few things in legacy WebHTMLView
3382         https://bugs.webkit.org/show_bug.cgi?id=176280
3383
3384         Reviewed by Dan Bernstein.
3385
3386         * WebCoreSupport/WebChromeClient.mm:
3387         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3388         methods it calls on WebHTMLView were doing nothing on iOS.
3389
3390         * WebView/WebFrame.mm:
3391         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3392         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3393
3394         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3395         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3396         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3397         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3398         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3399         Use RetainPtr instead of writing retain/release wherever possible.
3400         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3401         initialization for it. Removed various unused methods and declarations of methods.
3402         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3403         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3404         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3405         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3406         and remove CFRetain no longer needed since we don't support garbage collection any more.
3407         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3408         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3409         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3410         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3411         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3412         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3413         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3414         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3415         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3416         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3417         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3418         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3419         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3420         debug flag; we haven't used it for years and it's not clearly helpful.
3421         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3422         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3423         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3424         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3425         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3426         two additional methods in the WebPrivate category and still be called by the two
3427         methods in the WebInternal category that were already using it.
3428         (-[WebHTMLView didAddSubview:]): Deleted.
3429         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3430         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3431         place this was called, the close method.
3432         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3433         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3434         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3435         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3436         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3437         Added helper method to make the one below simpler.
3438         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3439         Compared pasteboard type strings using isEqualToString: rather than using == since
3440         we want to actually compare the string contents. Also updated to use modern for loop,
3441         renamed a local variable from "s" to "localSubresources", and factored out the handling
3442         of three image types to use the helper method above.
3443         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3444         _web_makePluginSubviewsPerformSelector:withObject: method.
3445         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3446         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3447         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3448         not call the -[NSView subviews] method to make this identical on both platforms and used
3449         a modern for loop.
3450         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3451         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3452         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3453         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3454         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3455         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3456         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3457         of it is Mac-only.
3458         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3459         method did was call itself on the main thread, and do nothing if called on main thread.
3460         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3461         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3462         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3463         half of this method.
3464         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3465         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3466         Simplified using a modern for loop and RetainPtr.
3467         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3468         (-[WebHTMLView keyDown:]): Ditto.
3469         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3470         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3471         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3472         (-[WebHTMLView complete:]): Ditto.
3473         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3474         now macOS-only.
3475         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3476         iOS since that is now macOS-only.
3477         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3478         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3479         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3480         and reorganized to use early return.
3481         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3482         on iOS, but kept there so we don't have to do #if at every call site.
3483         (-[WebHTMLView _pluginController]): Moved into internal category.
3484         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3485         there only for GC, using C++ initialization, removing obsolete comment.
3486         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3487         peculiar iOS-only comment.
3488         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3489
3490         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3491         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3492         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3493         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3494         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3495
3496         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3497         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3498         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3499         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3500         them at this time.
3501
3502 2017-09-03  Sam Weinig  <sam@webkit.org>
3503
3504         Remove CanvasProxy
3505         https://bugs.webkit.org/show_bug.cgi?id=176288
3506
3507         Reviewed by Yusuke Suzuki.
3508
3509         CanvasProxy does not appear to be in any current HTML spec
3510         and was disabled and unimplemented in our tree. Time to 
3511         get rid of it.
3512
3513         * Configurations/FeatureDefines.xcconfig:
3514
3515 2017-09-02  Andy Estes  <aestes@apple.com>
3516
3517         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3518         https://bugs.webkit.org/show_bug.cgi?id=176270
3519
3520         Reviewed by Tim Horton.
3521
3522         * Plugins/Hosted/NetscapePluginHostManager.mm:
3523         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3524         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3525         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3526         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3527         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3528         (WebKit::SoftwareCARenderer::context const):
3529         (WebKit::SoftwareCARenderer::renderContext const):
3530         (WebKit::SoftwareCARenderer::render):
3531         (-[WebHostedNetscapePluginView createPlugin]):
3532         (-[WebHostedNetscapePluginView createPluginLayer]):
3533         (-[WebHostedNetscapePluginView destroyPlugin]):
3534         (-[WebHostedNetscapePluginView drawRect:]):
3535         * WebCoreSupport/WebSystemInterface.mm:
3536         (InitWebCoreSystemInterface):
3537
3538 2017-09-01  Andy Estes  <aestes@apple.com>
3539
3540         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3541         https://bugs.webkit.org/show_bug.cgi?id=176200
3542
3543         Reviewed by Tim Horton.
3544
3545         * Carbon/HIWebView.mm:
3546         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3547         (overrideCGContext):
3548         (restoreCGContext):
3549         (Draw):
3550         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3551         (+[WebHostedNetscapePluginView initialize]):
3552         * Plugins/WebBaseNetscapePluginView.h:
3553         * Plugins/WebBaseNetscapePluginView.mm:
3554         (WebKit::sendUserChangeNotifications):
3555         * Plugins/WebNetscapePluginView.mm:
3556         (+[WebNetscapePluginView initialize]):
3557         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3558         * WebCoreSupport/WebSystemInterface.mm:
3559         (InitWebCoreSystemInterface):
3560         * WebView/WebFrame.mm:
3561         (-[WebFrame _paintBehaviorForDestinationContext:]):
3562         * WebView/WebFullScreenController.mm:
3563         (setClipRectForWindow):
3564         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3565         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3566         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3567         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3568
3569 2017-08-31  Andy Estes  <aestes@apple.com>
3570
3571         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3572         https://bugs.webkit.org/show_bug.cgi?id=176175
3573
3574         Reviewed by Brady Eidson.
3575
3576         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3577         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3578         * Plugins/Hosted/WebTextInputWindowController.m:
3579         (-[WebTextInputPanel init]):
3580         * WebCoreSupport/WebSystemInterface.mm:
3581         (InitWebCoreSystemInterface):
3582         * WebView/WebDynamicScrollBarsView.mm:
3583         (-[WebDynamicScrollBarsView scrollWheel:]):
3584         * WebView/WebHTMLView.mm:
3585         (-[WebHTMLView _removeWindowObservers]):
3586         (-[WebHTMLView addWindowObservers]):
3587         * WebView/WebView.mm:
3588         (-[WebView addWindowObserversForWindow:]):
3589         (-[WebView removeWindowObservers]):
3590         (-[WebView viewWillMoveToWindow:]):
3591
3592 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3593
3594         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3595         https://bugs.webkit.org/show_bug.cgi?id=175779
3596         <rdar://problem/22367975>
3597
3598         Reviewed by Tim Horton.
3599
3600         * WebCoreSupport/WebFrameLoaderClient.h:
3601         * WebCoreSupport/WebFrameLoaderClient.mm:
3602         (WebFrameLoaderClient::webGLPolicyForURL const):
3603         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3604
3605 2017-08-30  Andy Estes  <aestes@apple.com>
3606
3607         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3608         https://bugs.webkit.org/show_bug.cgi?id=176093
3609
3610         Reviewed by Eric Carlson.
3611
3612         * WebCoreSupport/WebSystemInterface.mm:
3613         (InitWebCoreSystemInterface):
3614
3615 2017-08-30  Andy Estes  <aestes@apple.com>
3616
3617         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3618         https://bugs.webkit.org/show_bug.cgi?id=176087
3619
3620         Reviewed by Alex Christensen.
3621
3622         * Carbon/CarbonUtils.m:
3623         (getNSAutoreleasePoolCount):
3624         (WebInitForCarbon):
3625         (PoolCleaner):
3626         * Carbon/CarbonWindowAdapter.mm:
3627         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3628         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3629         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3630         (-[CarbonWindowAdapter _windowMovedToRect:]):
3631         * Carbon/HIViewAdapter.m:
3632         * Carbon/HIWebView.mm:
3633         (Draw):
3634         (CreateNSEventAdoptingCGEvent):
3635         (CopyEventCGEvent):
3636         (CreateNSEventWithCarbonClickEvent):
3637         (Click):
3638         (CreateNSEventWithCarbonEvent):
3639         (MouseUp):
3640         (CreateNSEventWithCarbonMouseMoveEvent):
3641         (MouseMoved):
3642         (MouseDragged):
3643         (MouseWheelMoved):
3644         (WindowHandler):
3645         (HIWebViewEventHandler):
3646         * Misc/QuickDrawCompatibility.h: Removed.
3647         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3648         (getCarbonEvent):
3649         (WebNetscapePluginEventHandlerCarbon::keyDown):
3650         (WebNetscapePluginEventHandlerCarbon::keyUp):
3651         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3652         (WebNetscapePluginEventHandlerCocoa::keyDown):
3653         * Plugins/WebNetscapePluginView.mm:
3654         (-[WebNetscapePluginView tellQuickTimeToChill]):
3655
3656 2017-08-29  Andy Estes  <aestes@apple.com>
3657
3658         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3659         https://bugs.webkit.org/show_bug.cgi?id=176046
3660
3661         Reviewed by Alex Christensen.
3662
3663         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3664         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3665
3666         * Misc/WebNSFileManagerExtras.mm:
3667         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3668         (setMetaData): Deleted.
3669         * WebCoreSupport/WebSystemInterface.mm:
3670         (InitWebCoreSystemInterface):
3671
3672 2017-08-28  Andy Estes  <aestes@apple.com>
3673
3674         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3675         https://bugs.webkit.org/show_bug.cgi?id=176039
3676
3677         Reviewed by Alex Christensen.
3678
3679         * WebCoreSupport/WebSystemInterface.mm:
3680         (InitWebCoreSystemInterface):
3681         * WebView/WebPreferences.mm:
3682         (+[WebPreferences _systemCFStringEncoding]):
3683
3684 2017-08-28  Andy Estes  <aestes@apple.com>
3685
3686         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3687         https://bugs.webkit.org/show_bug.cgi?id=176032
3688
3689         Reviewed by Alex Christensen.
3690
3691         * WebCoreSupport/WebSystemInterface.mm:
3692         (InitWebCoreSystemInterface):
3693         * WebView/WebView.mm:
3694         (-[WebView _cachedResponseForURL:]):
3695
3696 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3697
3698         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3699         https://bugs.webkit.org/show_bug.cgi?id=175992
3700         <rdar://problem/34086613>
3701
3702         Reviewed by Daniel Bates.
3703
3704         * WebCoreSupport/WebPlatformStrategies.h:
3705         * WebCoreSupport/WebPlatformStrategies.mm:
3706         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3707         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3708         indicating if secure cookies were accessed.
3709
3710 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3711
3712         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3713         https://bugs.webkit.org/show_bug.cgi?id=170955
3714         <rdar://problem/31697653>
3715
3716         Reviewed by Ryosuke Niwa.
3717
3718         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3719         text is being replaced.
3720
3721         * WebView/WebHTMLView.mm:
3722         (-[WebHTMLView insertText:]):
3723
3724 2017-08-24  Chris Dumez  <cdumez@apple.com>
3725
3726         [Directory Upload] Add basic support for input.webkitdirectory
3727         https://bugs.webkit.org/show_bug.cgi?id=175950
3728         <rdar://problem/33951915>
3729
3730         Reviewed by Geoffrey Garen.
3731
3732         Add private API to toggle Directory Upload support on Mac WebKit1.
3733
3734         * WebView/WebPreferenceKeysPrivate.h:
3735         * WebView/WebPreferences.mm:
3736         (+[WebPreferences initialize]):
3737         (-[WebPreferences setDirectoryUploadEnabled:]):
3738         (-[WebPreferences directoryUploadEnabled]):
3739         * WebView/WebPreferencesPrivate.h:
3740         * WebView/WebView.mm:
3741         (-[WebView _preferencesChanged:]):
3742
3743 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3744
3745         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3746         https://bugs.webkit.org/show_bug.cgi?id=175370
3747         <rdar://problem/33799806>
3748
3749         Reviewed by Ryosuke Niwa.
3750
3751         Adjust WebEditorClient for interface changes.
3752
3753         * WebCoreSupport/WebEditorClient.h:
3754
3755 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3756
3757         Remove ChromeClient::scrollbarsModeDidChange
3758         https://bugs.webkit.org/show_bug.cgi?id=175805
3759
3760         Reviewed by Daniel Bates.
3761
3762         * WebCoreSupport/WebChromeClient.h:
3763
3764 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3765
3766         Remove ChromeClient::hasOpenedPopup
3767         https://bugs.webkit.org/show_bug.cgi?id=175804
3768
3769         Reviewed by Sam Weinig.
3770
3771         * WebCoreSupport/WebChromeClient.h:
3772         * WebCoreSupport/WebChromeClient.mm:
3773         (WebChromeClient::hasOpenedPopup const): Deleted.
3774
3775 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3776
3777         Disable access to secure cookies if an HTTPS site loads mixed content
3778         https://bugs.webkit.org/show_bug.cgi?id=157053
3779         <rdar://problem/11290808>
3780
3781         Reviewed by Dan Bates.
3782
3783         * WebCoreSupport/WebPlatformStrategies.h:
3784         * WebCoreSupport/WebPlatformStrategies.mm:
3785         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3786         indicating whether secure cookies should be included in the response.
3787
3788 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3789
3790         [PAL] Move spi/mac directory into PAL
3791         https://bugs.webkit.org/show_bug.cgi?id=175649
3792
3793         Reviewed by Myles C. Maxfield.
3794
3795         * Misc/WebSharingServicePickerController.h:
3796         * WebCoreSupport/WebContextMenuClient.mm:
3797         * WebCoreSupport/WebEditorClient.mm:
3798         * WebCoreSupport/WebSelectionServiceController.mm:
3799         * WebView/WebHTMLView.mm:
3800         * WebView/WebImmediateActionController.h:
3801         * WebView/WebImmediateActionController.mm:
3802         * WebView/WebView.mm:
3803
3804 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3805
3806         [PAL] Relocate SessionID to root
3807         https://bugs.webkit.org/show_bug.cgi?id=175684
3808
3809         Reviewed by Alex Christensen.
3810
3811         * WebCoreSupport/WebFrameNetworkingContext.mm:
3812
3813 2017-08-17  Andreas Kling  <akling@apple.com>
3814
3815         Disable CSS regions at compile time
3816         https://bugs.webkit.org/show_bug.cgi?id=175630
3817
3818         Reviewed by Antti Koivisto.
3819
3820         * Configurations/FeatureDefines.xcconfig:
3821
3822 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3823
3824         [PAL] Move SessionID into PAL
3825         https://bugs.webkit.org/show_bug.cgi?id=174192
3826
3827         Reviewed by Antti Koivisto.
3828
3829         * Misc/WebCache.mm:
3830         (+[WebCache imageForURL:]):
3831         * WebCoreSupport/WebFrameLoaderClient.h:
3832         * WebCoreSupport/WebFrameLoaderClient.mm:
3833         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3834         * WebCoreSupport/WebFrameNetworkingContext.mm:
3835         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3836         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3837         (WebFrameNetworkingContext::storageSession const):
3838         * WebCoreSupport/WebPlatformStrategies.h:
3839         * WebCoreSupport/WebPlatformStrategies.mm:
3840         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3841         * WebKitPrefix.h:
3842
3843 2017-08-16  Andy Estes  <aestes@apple.com>
3844
3845         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3846         https://bugs.webkit.org/show_bug.cgi?id=175648
3847
3848         Reviewed by Tim Horton.
3849
3850         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3851         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3852         (WebPaymentCoordinatorClient::showPaymentUI):
3853
3854 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3855
3856         [PAL] Move spi/ios and spi/win directories into PAL
3857         https://bugs.webkit.org/show_bug.cgi?id=175171
3858
3859         Reviewed by Antti Koivisto.
3860
3861         * WebCoreSupport/WebFrameLoaderClient.mm:
3862         * WebView/WebView.mm:
3863
3864 2017-08-16  Andy Estes  <aestes@apple.com>
3865
3866         [Payment Request] Add an ENABLE flag and an experimental feature preference
3867         https://bugs.webkit.org/show_bug.cgi?id=175622
3868
3869         Reviewed by Tim Horton.
3870
3871         * Configurations/FeatureDefines.xcconfig:
3872
3873 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3874
3875         [PAL] Move Sleep classes into PAL
3876         https://bugs.webkit.org/show_bug.cgi?id=175456
3877
3878         Reviewed by Ryosuke Niwa.
3879
3880         * WebView/WebFullScreenController.h:
3881
3882 2017-08-15  Youenn Fablet  <youenn@apple.com>
3883
3884         [Cache API] Adding generic support for CacheStorage and Cache methods
3885         https://bugs.webkit.org/show_bug.cgi?id=175455
3886
3887         Reviewed by Chris Dumez.
3888
3889         * WebView/WebView.mm:
3890         (-[WebView _commonInitializationWithFrameName:groupName:]):
3891
3892 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3893
3894         Remove Proximity Events and related code
3895         https://bugs.webkit.org/show_bug.cgi?id=175545
3896
3897         Reviewed by Daniel Bates.
3898
3899         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3900         and other related code.
3901
3902         * Configurations/FeatureDefines.xcconfig:
3903
3904 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3905
3906         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3907         https://bugs.webkit.org/show_bug.cgi?id=175504
3908
3909         Reviewed by Sam Weinig.
3910
3911         * Configurations/FeatureDefines.xcconfig:
3912         * DOM/DOMHTMLFormElement.mm:
3913         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3914         * WebCoreSupport/WebFrameLoaderClient.h:
3915
3916 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3917
3918         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3919         https://bugs.webkit.org/show_bug.cgi?id=175557
3920
3921         Reviewed by Jon Lee.
3922
3923         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3924
3925         * Configurations/FeatureDefines.xcconfig:
3926
3927 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3928
3929         Composition underline color is always black
3930         https://bugs.webkit.org/show_bug.cgi?id=174675
3931
3932         Reviewed by Ryosuke Niwa.
3933
3934         * WebView/WebHTMLView.mm:
3935         (extractUnderlines): If NSUnderlineColorAttributeName
3936         is not present use text color for composition underline.
3937         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3938         for composition underline in the plain text case.
3939
3940 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3941
3942         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3943         https://bugs.webkit.org/show_bug.cgi?id=175474
3944         <rdar://problem/33844628>
3945
3946         Reviewed by Wenson Hsieh.
3947
3948         Replaced the build flag by a runtime flag and disabled the feature by default.
3949
3950         * Configurations/FeatureDefines.xcconfig:
3951         * WebView/WebPreferenceKeysPrivate.h:
3952         * WebView/WebPreferences.mm:
3953         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3954         (-[WebPreferences dataTransferItemsEnabled]): Added.
3955         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3956         * WebView/WebPreferencesPrivate.h:
3957         * WebView/WebView.mm:
3958         (-[WebView _preferencesChanged:]):
3959
3960 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3961
3962         Remove ENABLE_GAMEPAD_DEPRECATED
3963         https://bugs.webkit.org/show_bug.cgi?id=175361
3964
3965         Reviewed by Carlos Garcia Campos.
3966
3967         * Configurations/FeatureDefines.xcconfig:
3968
3969 2017-08-09  Chris Dumez  <cdumez@apple.com>
3970
3971         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3972         https://bugs.webkit.org/show_bug.cgi?id=175401
3973
3974         Reviewed by Brady Eidson.
3975
3976         * WebView/WebPreferenceKeysPrivate.h:
3977         * WebView/WebPreferences.mm:
3978         (+[WebPreferences initialize]):
3979         (-[WebPreferences beaconAPIEnabled]): Deleted.
3980         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3981         * WebView/WebPreferencesPrivate.h:
3982         * WebView/WebView.mm:
3983         (-[WebView _preferencesChanged:]):
3984
3985 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3986
3987         [PAL] Move spi/cocoa and spi/cg directories into PAL
3988         https://bugs.webkit.org/show_bug.cgi?id=175175
3989
3990         Reviewed by Myles C. Maxfield.
3991
3992         * History/WebHistory.mm:
3993         * Misc/WebDownload.mm:
3994         * Misc/WebKitNSStringExtras.mm:
3995         * Plugins/Hosted/NetscapePluginHostManager.mm:
3996         * Plugins/WebPluginDatabase.mm:
3997         * WebCoreSupport/WebFrameLoaderClient.mm:
3998         * WebInspector/WebNodeHighlight.mm:
3999         * WebView/WebHTMLView.mm:
4000         * WebView/WebIndicateLayer.mm:
4001         * WebView/WebView.mm:
4002         * WebView/WebViewData.h:
4003
4004 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4005
4006         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
4007         https://bugs.webkit.org/show_bug.cgi?id=175392
4008         <rdar://problem/33783207>
4009
4010         Reviewed by Tim Horton and Megan Gardner.
4011
4012         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
4013
4014         * Configurations/FeatureDefines.xcconfig:
4015
4016 2017-08-09  Daniel Bates  <dabates@apple.com>
4017
4018         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
4019         https://bugs.webkit.org/show_bug.cgi?id=175247
4020         <rdar://problem/33679804>
4021
4022         Reviewed by Brady Eidson.
4023
4024         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
4025         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
4026         clients that need to make use of this information at this time. If such a needs comes up
4027         then we can expose API/SPI similar to what we do for WebKit.
4028
4029         * WebCoreSupport/WebFrameLoaderClient.h:
4030         * WebCoreSupport/WebFrameLoaderClient.mm:
4031         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4032
4033 2017-08-08  Brady Eidson  <beidson@apple.com>
4034
4035         Don't enable default icon loading in WK1 for apps linked against old SDKs.
4036         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
4037
4038         Reviewed by Andy Estes.
4039
4040         * Misc/WebKitVersionChecks.h:
4041         * WebCoreSupport/WebFrameLoaderClient.mm:
4042         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
4043           the app is linked against new WebKit with the new behavior.
4044
4045 2017-08-07  Devin Rousso  <drousso@apple.com>
4046
4047         Web Inspector: Preview Canvas path when viewing a recording
4048         https://bugs.webkit.org/show_bug.cgi?id=174967
4049
4050         Reviewed by Brian Burg.
4051
4052         * WebView/WebPreferenceKeysPrivate.h:
4053         * WebView/WebPreferences.mm:
4054         (+[WebPreferences initialize]):
4055         (-[WebPreferences inspectorAdditionsEnabled]):
4056         (-[WebPreferences setInspectorAdditionsEnabled:]):
4057         * WebView/WebPreferencesPrivate.h:
4058         * WebView/WebView.mm:
4059         (-[WebView _preferencesChanged:]):
4060         Add plumbing for new InspectorAdditions runtime flag.
4061
4062 2017-08-07  Brian Burg  <bburg@apple.com>
4063
4064         Remove CANVAS_PATH compilation guard
4065         https://bugs.webkit.org/show_bug.cgi?id=175207
4066
4067         Reviewed by Sam Weinig.
4068
4069         * Configurations/FeatureDefines.xcconfig:
4070
4071 2017-08-04  Youenn Fablet  <youenn@apple.com>
4072
4073         [Cache API] Add Cache and CacheStorage IDL definitions
4074         https://bugs.webkit.org/show_bug.cgi?id=175201
4075
4076         Reviewed by Brady Eidson.
4077
4078         * WebView/WebPreferenceKeysPrivate.h:
4079         * WebView/WebPreferences.mm:
4080         (+[WebPreferences initialize]):
4081         (-[WebPreferences cacheAPIEnabled]):
4082         (-[WebPreferences setCacheAPIEnabled:]):
4083         * WebView/WebPreferencesPrivate.h:
4084         * WebView/WebView.mm: