Unreviewed rollout of r230632. Regression in memory usage.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2
3         Unreviewed rollout of r230632. Regression in memory usage.
4
5         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
6
7         * WebView/WebPreferences.mm:
8         (+[WebPreferences initialize]):
9
10 2018-04-17  Chris Dumez  <cdumez@apple.com>
11
12         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
13         https://bugs.webkit.org/show_bug.cgi?id=184678
14         <rdar://problem/39422122>
15
16         Reviewed by Alex Christensen.
17
18         Add new parameter to dispatchDecidePolicyForNavigationAction.
19
20         * WebCoreSupport/WebFrameLoaderClient.h:
21         * WebCoreSupport/WebFrameLoaderClient.mm:
22         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
23
24 2018-04-13  Chris Dumez  <cdumez@apple.com>
25
26         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
27         https://bugs.webkit.org/show_bug.cgi?id=184591
28
29         Reviewed by Sam Weinig.
30
31         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
32         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
33         This is work towards fixing Bug 184515.
34
35         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
36         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
37         * WebView/WebFrame.mm:
38         (-[WebFrame _attachScriptDebugger]):
39
40 2018-04-12  Antoine Quint  <graouts@apple.com>
41
42         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
43         https://bugs.webkit.org/show_bug.cgi?id=184569
44         <rdar://problem/38671301>
45
46         Reviewed by Jon Lee.
47
48         * WebView/WebPreferences.mm:
49
50 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
51
52         [WTF] Remove StaticLock
53         https://bugs.webkit.org/show_bug.cgi?id=184332
54
55         Reviewed by Mark Lam.
56
57         * DOM/DOMInternal.mm:
58         (getDOMWrapper):
59         (addDOMWrapper):
60         (removeDOMWrapper):
61
62 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
63
64         Failures from mach port reference handling should be fatal
65         https://bugs.webkit.org/show_bug.cgi?id=184202
66         <rdar://problem/37771114>
67
68         Reviewed by Anders Carlsson.
69
70         * Plugins/Hosted/NetscapePluginHostManager.mm:
71         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
72
73 2018-04-03  Andy Estes  <aestes@apple.com>
74
75         [Mac] Prioritize file promises over filenames during drag and drop
76         https://bugs.webkit.org/show_bug.cgi?id=184237
77         <rdar://problem/38278076>
78
79         Reviewed by Wenson Hsieh.
80
81         * WebView/WebView.mm:
82         (-[WebView performDragOperation:]):
83
84 2018-04-03  Chris Dumez  <cdumez@apple.com>
85
86         Drop MainFrame class
87         https://bugs.webkit.org/show_bug.cgi?id=184191
88
89         Reviewed by Darin Adler.
90
91         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
92         relationship between the Page and the MainFrame.
93
94         This is ground work for introducing LocalFrame / RemoteFrame concepts.
95
96         * WebCoreSupport/WebDragClient.mm:
97         * WebCoreSupport/WebFrameLoaderClient.mm:
98         * WebCoreSupport/WebInspectorClient.mm:
99         * WebCoreSupport/WebPlatformStrategies.mm:
100         * WebCoreSupport/WebPluginInfoProvider.mm:
101         * WebView/WebFrame.mm:
102         * WebView/WebFrameView.mm:
103         * WebView/WebHTMLView.mm:
104         * WebView/WebView.mm:
105
106 2018-04-02  Jer Noble  <jer.noble@apple.com>
107
108         Enable Legacy EME for all WebKit & WebKitLegacy clients
109         https://bugs.webkit.org/show_bug.cgi?id=184018
110         <rdar://problem/34887387>
111
112         Reviewed by Eric Carlson.
113
114         * WebView/WebPreferences.mm:
115         (+[WebPreferences initialize]):
116
117 2018-03-29  JF Bastien  <jfbastien@apple.com>
118
119         Use Forward.h instead of forward-declaring WTF::String
120         https://bugs.webkit.org/show_bug.cgi?id=184172
121         <rdar://problem/39026146>
122
123         Reviewed by Yusuke Suzuki.
124
125         As part of #184164 I'm changing WTF::String, and the forward
126         declarations are just wrong because I'm making it templated. We
127         should use Forward.h anyways, so do that instead.
128
129         * WebView/WebScriptDebugger.h:
130
131 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
132
133         Protect against invalid mach ports returned by mach_port_request_notification
134         https://bugs.webkit.org/show_bug.cgi?id=184106
135         <rdar://problem/37865316>
136
137         Reviewed by Chris Dumez.
138
139         * Plugins/Hosted/NetscapePluginHostProxy.mm:
140         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
141         and clean up if it experienced an error.
142         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
143
144 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
145
146         Avoid uninitialized mach ports
147         https://bugs.webkit.org/show_bug.cgi?id=184090
148         <rdar://problem/37261129>
149
150         Reviewed by Chris Dumez.
151
152         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
153         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
154         there is a potential for us to try to use invalid ports.
155
156         We should always check return values, and ensure that the mach port variables we seek to initialize are
157         kept in a valid state.
158
159         Reviewed by Chris Dumez.
160
161         * Plugins/Hosted/NetscapePluginHostManager.h:
162         * Plugins/Hosted/NetscapePluginHostManager.mm:
163         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
164         port is passed to an API function.
165         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
166         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
167         * Plugins/Hosted/NetscapePluginHostProxy.h:
168         * Plugins/Hosted/NetscapePluginHostProxy.mm:
169         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
170         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
171         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
172         (WKPCStatusText): Ditto.
173         (WKPCLoadURL): Ditto.
174         (WKPCCancelLoadURL): Ditto.
175         (WKPCInvalidateRect): Ditto.
176         (WKPCGetScriptableNPObjectReply): Ditto.
177         (WKPCBooleanReply): Ditto.
178         (WKPCBooleanAndDataReply): Ditto.
179         (WKPCInstantiatePluginReply): Ditto.
180         (WKPCGetWindowNPObject): Ditto.
181         (WKPCGetPluginElementNPObject): Ditto.
182         (WKPCForgetBrowserObject): Ditto.
183         (WKPCEvaluate): Ditto.
184         (WKPCGetStringIdentifier): Ditto.
185         (WKPCGetIntIdentifier): Ditto.
186         (WKPCInvoke): Ditto.
187         (WKPCInvokeDefault): Ditto.
188         (WKPCConstruct): Ditto.
189         (WKPCGetProperty): Ditto.
190         (WKPCSetProperty): Ditto.
191         (WKPCRemoveProperty): Ditto.
192         (WKPCHasProperty): Ditto.
193         (WKPCHasMethod): Ditto.
194         (WKPCIdentifierInfo): Ditto.
195         (WKPCEnumerate): Ditto.
196         (WKPCSetMenuBarVisible): Ditto.
197         (WKPCSetFullscreenWindowIsShowing): Ditto.
198         (WKPCSetModal): Ditto.
199         (WKPCGetCookies): Ditto.
200         (WKPCGetProxy): Ditto.
201         (WKPCSetCookies): Ditto.
202         (WKPCGetAuthenticationInfo): Ditto.
203         (WKPCConvertPoint): Ditto.
204         (WKPCLayerHostingModeChanged): Ditto.
205         (WKPCSetException): Ditto.
206
207 2018-03-26  Tim Horton  <timothy_horton@apple.com>
208
209         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
210         https://bugs.webkit.org/show_bug.cgi?id=184030
211         <rdar://problem/38895281>
212
213         Reviewed by Dan Bernstein.
214
215         * Configurations/Base.xcconfig:
216
217 2018-03-26  Chris Dumez  <cdumez@apple.com>
218
219         Use SecurityOriginData more consistently in Service Worker code
220         https://bugs.webkit.org/show_bug.cgi?id=183969
221
222         Reviewed by Darin Adler.
223
224         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
225
226         * Storage/WebDatabaseManager.mm:
227         (-[WebDatabaseManager databasesWithOrigin:]):
228         (-[WebDatabaseManager deleteOrigin:]):
229         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
230         * Storage/WebDatabaseQuotaManager.mm:
231         (-[WebDatabaseQuotaManager usage]):
232         (-[WebDatabaseQuotaManager quota]):
233         (-[WebDatabaseQuotaManager setQuota:]):
234         * Storage/WebStorageManager.mm:
235         (-[WebStorageManager deleteOrigin:]):
236         * WebCoreSupport/WebSecurityOrigin.mm:
237         (-[WebSecurityOrigin databaseIdentifier]):
238         (-[WebSecurityOrigin usage]):
239         (-[WebSecurityOrigin quota]):
240         (-[WebSecurityOrigin setQuota:]):
241
242 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
243
244         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
245         https://bugs.webkit.org/show_bug.cgi?id=183911
246         <rdar://problem/38762306>
247
248         Reviewed by Youenn Fablet.
249
250         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
251
252         * WebView/WebView.mm:
253         (+[WebView initialize]):
254
255 2018-03-26  Alex Christensen  <achristensen@webkit.org>
256
257         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
258         https://bugs.webkit.org/show_bug.cgi?id=183965
259
260         Reviewed by Chris Dumez.
261
262         * WebCoreSupport/WebFrameLoaderClient.h:
263         * WebCoreSupport/WebFrameLoaderClient.mm:
264         (WebFrameLoaderClient::willCacheResponse const):
265
266 2018-03-25  Commit Queue  <commit-queue@webkit.org>
267
268         Unreviewed, rolling out r229954.
269         https://bugs.webkit.org/show_bug.cgi?id=184000
270
271         Caused many layout tests to crash on Apple High Sierra,
272         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
273         by dydz on #webkit).
274
275         Reverted changeset:
276
277         "Use SecurityOriginData more consistently in Service Worker
278         code"
279         https://bugs.webkit.org/show_bug.cgi?id=183969
280         https://trac.webkit.org/changeset/229954
281
282 2018-03-24  Chris Dumez  <cdumez@apple.com>
283
284         Use SecurityOriginData more consistently in Service Worker code
285         https://bugs.webkit.org/show_bug.cgi?id=183969
286
287         Reviewed by Darin Adler.
288
289         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
290
291         * Storage/WebDatabaseManager.mm:
292         (-[WebDatabaseManager databasesWithOrigin:]):
293         (-[WebDatabaseManager deleteOrigin:]):
294         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
295         * Storage/WebDatabaseQuotaManager.mm:
296         (-[WebDatabaseQuotaManager usage]):
297         (-[WebDatabaseQuotaManager quota]):
298         (-[WebDatabaseQuotaManager setQuota:]):
299         * Storage/WebStorageManager.mm:
300         (-[WebStorageManager deleteOrigin:]):
301         * WebCoreSupport/WebSecurityOrigin.mm:
302         (-[WebSecurityOrigin databaseIdentifier]):
303         (-[WebSecurityOrigin usage]):
304         (-[WebSecurityOrigin quota]):
305         (-[WebSecurityOrigin setQuota:]):
306
307 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
308
309         Fix the build
310
311         * WebView/WebView.mm:
312
313 2018-03-23  Tim Horton  <timothy_horton@apple.com>
314
315         Fix the build with no pasteboard
316         https://bugs.webkit.org/show_bug.cgi?id=183973
317
318         Reviewed by Dan Bernstein.
319
320         * Configurations/FeatureDefines.xcconfig:
321         * WebView/WebView.mm:
322         (-[WebView _requestStartDataInteraction:globalPosition:]):
323         (-[WebView _getDataInteractionData]):
324         (-[WebView _dataOperationTextIndicator]):
325         (-[WebView _dragSourceAction]):
326         (-[WebView _draggedLinkTitle]):
327         (-[WebView _draggedLinkURL]):
328         (-[WebView _draggedElementBounds]):
329         (-[WebView _enteredDataInteraction:client:global:operation:]):
330         (-[WebView _updatedDataInteraction:client:global:operation:]):
331         (-[WebView _exitedDataInteraction:client:global:operation:]):
332         (-[WebView _performDataInteraction:client:global:operation:]):
333         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
334         (-[WebView _endedDataInteraction:global:]):
335         (-[WebView _dataInteractionCaretRect]):
336         * WebView/WebViewPrivate.h:
337
338 2018-03-23  Tim Horton  <timothy_horton@apple.com>
339
340         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
341         https://bugs.webkit.org/show_bug.cgi?id=183960
342         <rdar://problem/38812356>
343
344         Reviewed by Dan Bernstein.
345
346         * Configurations/WebKitLegacy.xcconfig:
347
348 2018-03-23  Tim Horton  <timothy_horton@apple.com>
349
350         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
351         https://bugs.webkit.org/show_bug.cgi?id=183954
352         <rdar://problem/38808858>
353
354         Reviewed by Dan Bernstein.
355
356         * WebView/WebPreferences.mm:
357         (-[WebPreferences setAudioSessionCategoryOverride:]):
358
359 2018-03-23  Tim Horton  <timothy_horton@apple.com>
360
361         Adopt WK_PLATFORM_NAME in WebKitLegacy
362         https://bugs.webkit.org/show_bug.cgi?id=183948
363         <rdar://problem/38803908>
364
365         Reviewed by Dan Bernstein.
366
367         * Configurations/WebKitLegacy.xcconfig:
368         * MigrateHeaders.make:
369         * postprocess-headers.sh:
370
371 2018-03-23  Brady Eidson  <beidson@apple.com>
372
373         Go to back/forward list items after a process-swapped navigation.
374         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
375
376         Reviewed by Andy Estes.
377
378         * WebView/WebView.mm:
379         (-[WebView _loadBackForwardListFromOtherView:]):
380         (-[WebView goToBackForwardItem:]):
381
382 2018-03-22  Tim Horton  <timothy_horton@apple.com>
383
384         Improve readability of WebCore's OTHER_LDFLAGS
385         https://bugs.webkit.org/show_bug.cgi?id=183909
386         <rdar://problem/38760992>
387
388         Reviewed by Dan Bernstein.
389
390         * Configurations/Base.xcconfig:
391         * Configurations/FeatureDefines.xcconfig:
392
393 2018-03-20  Tim Horton  <timothy_horton@apple.com>
394
395         Enable the minimal simulator feature flag when appropriate
396         https://bugs.webkit.org/show_bug.cgi?id=183807
397
398         Reviewed by Dan Bernstein.
399
400         * Configurations/FeatureDefines.xcconfig:
401
402 2018-03-20  Tim Horton  <timothy_horton@apple.com>
403
404         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
405         https://bugs.webkit.org/show_bug.cgi?id=183758
406         <rdar://problem/38017644>
407
408         Reviewed by Dan Bernstein.
409
410         * Configurations/FeatureDefines.xcconfig:
411
412 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
413
414         Clear style colors when setting default appearance
415         https://bugs.webkit.org/show_bug.cgi?id=183759
416
417         Reviewed by Tim Horton.
418
419         Colors are cached and need to be cleared and recalculated.
420         Refactor to do all style recalcs together.
421
422         * WebView/WebView.mm:
423         (-[WebView _setDefaultAppearanceAndClearStyle]):
424         (-[WebView _setUseSystemAppearance:]):
425         (-[WebView effectiveAppearanceDidChange]):
426
427 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
428
429         Unreviewed, another quick fix for r229699
430
431         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
432
433         * Configurations/FeatureDefines.xcconfig:
434
435 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
436
437         Ensure that style is updated when the effective appearance changes
438         https://bugs.webkit.org/show_bug.cgi?id=183690
439         <rdar://problem/38385900>
440
441         Reviewed by Tim Horton and Wenson Hsieh.
442
443         Respond to and respect the effective appearance changing.
444
445         * WebView/WebView.mm:
446         (-[WebView _setUseSystemAppearance:]):
447         (-[WebView effectiveAppearanceDidChange]):
448
449 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
450
451         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
452         https://bugs.webkit.org/show_bug.cgi?id=183677
453
454         Reviewed by Tim Horton.
455
456         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
457
458         * DOM/DOM.mm:
459         (-[DOMHTMLLinkElement _mediaQueryMatches]):
460
461 2018-03-14  Tim Horton  <timothy_horton@apple.com>
462
463         Fix the build after r229567
464
465         * Configurations/FeatureDefines.xcconfig:
466
467 2018-03-12  Tim Horton  <timothy_horton@apple.com>
468
469         Stop using SDK conditionals to control feature definitions
470         https://bugs.webkit.org/show_bug.cgi?id=183430
471         <rdar://problem/38251619>
472
473         Reviewed by Dan Bernstein.
474
475         * Configurations/FeatureDefines.xcconfig:
476         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
477
478 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
479
480         Runtime flag for link prefetch and remove link subresource.
481         https://bugs.webkit.org/show_bug.cgi?id=183540
482
483         Reviewed by Chris Dumez.
484
485         Remove the LINK_PREFETCH build time flag.
486
487         * Configurations/FeatureDefines.xcconfig:
488
489 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
490
491         Remove GridLayout runtime flag
492         https://bugs.webkit.org/show_bug.cgi?id=183484
493
494         Reviewed by Myles C. Maxfield.
495
496         The Grid Layout feature has been enabled by default for almost a
497         year, so I think it's time to remove the runtime flag and the
498
499         * WebView/WebPreferenceKeysPrivate.h:
500         * WebView/WebPreferences.mm:
501         (+[WebPreferences initialize]):
502         * WebView/WebPreferencesPrivate.h:
503         * WebView/WebView.mm:
504         (-[WebView _preferencesChanged:]):
505
506 2018-03-12  Antoine Quint  <graouts@apple.com>
507
508         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
509         https://bugs.webkit.org/show_bug.cgi?id=183504
510         <rdar://problem/38372965>
511
512         Reviewed by Dean Jackson and Jon Lee.
513
514         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
515         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
516
517         * WebView/WebPreferenceKeysPrivate.h:
518         * WebView/WebPreferences.mm:
519         (+[WebPreferences initialize]):
520         (-[WebPreferences setModernMediaControlsEnabled:]):
521         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
522         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
523         * WebView/WebPreferencesPrivate.h:
524         * WebView/WebView.mm:
525         (-[WebView _preferencesChanged:]):
526
527 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
528
529         Media query for default appearance
530         https://bugs.webkit.org/show_bug.cgi?id=183539
531         <rdar://problem/38326388>
532
533         Reviewed by Tim Horton.
534
535         Write a media query to evaluate appearance.
536
537         * WebView/WebView.mm:
538         (-[WebView _commonInitializationWithFrameName:groupName:]):
539         (-[WebView _setUseSystemAppearance:]):
540
541 2018-03-09  Andy Estes  <aestes@apple.com>
542
543         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
544         https://bugs.webkit.org/show_bug.cgi?id=183489
545         <rdar://problem/38267517>
546
547         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
548         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
549         to issue a sandbox extension for this directory, but for security reasons App Sandbox
550         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
551         block with a nil error and a valid file URL, but no file will actually exist at that URL.
552
553         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
554         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
555         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
556         drop destination.
557
558         Reviewed by Wenson Hsieh.
559
560         * WebView/WebView.mm:
561         (-[WebView performDragOperation:]):
562
563 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
564
565         Allow WebViews to disable system appearance
566         https://bugs.webkit.org/show_bug.cgi?id=183418
567         <rdar://problem/36975642>
568
569         Reviewed by Tim Horton.
570
571         Allow webviews to choose whether or not to follow the default system appearance.
572
573         * WebView/WebView.mm:
574         (-[WebView _setUseSystemAppearance:]):
575         (-[WebView _useSystemAppearance]):
576         * WebView/WebViewPrivate.h:
577
578 2018-03-08  Youenn Fablet  <youenn@apple.com>
579
580         libwebrtc update broke internal builds
581         https://bugs.webkit.org/show_bug.cgi?id=183454
582
583         Reviewed by Eric Carlson.
584
585         * Configurations/WebKitLegacy.xcconfig:
586
587 2018-03-08  Chris Dumez  <cdumez@apple.com>
588
589         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
590         https://bugs.webkit.org/show_bug.cgi?id=183455
591         <rdar://problem/38191749>
592
593         Reviewed by Youenn Fablet.
594
595         Add a null check for the page as we have evidence from crashes that it can be null.
596         Other functions in WebFrameNetworkingContext already null check the page as well,
597         not just the frame so this is consistent.
598
599         * WebCoreSupport/WebFrameNetworkingContext.mm:
600         (WebFrameNetworkingContext::storageSession const):
601
602 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
603
604         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
605         https://bugs.webkit.org/show_bug.cgi?id=183429
606
607         Reviewed by Mark Lam.
608
609         * DOM/DOM.mm:
610         (+[DOMNode _nodeFromJSWrapper:]):
611         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
612         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
613         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
614         * Plugins/Hosted/ProxyInstance.mm:
615         (WebKit::ProxyInstance::invokeMethod):
616         * WebView/WebView.mm:
617         (aeDescFromJSValue):
618
619 2018-03-08  Tim Horton  <timothy_horton@apple.com>
620
621         Stop linking ApplicationServices directly
622         https://bugs.webkit.org/show_bug.cgi?id=182867
623         <rdar://problem/38252142>
624
625         Reviewed by Alex Christensen.
626
627         The frameworks that we use that live inside ApplicationServices
628         have mostly moved out, so import them directly.
629
630         * Carbon/CarbonUtils.h:
631         * WebKitPrefix.h:
632         * WebView/WebHTMLView.mm:
633         * WebView/WebPDFView.mm:
634
635 2018-03-07  Tim Horton  <timothy_horton@apple.com>
636
637         Sort and separate FeatureDefines.xcconfig
638         https://bugs.webkit.org/show_bug.cgi?id=183427
639
640         Reviewed by Dan Bernstein.
641
642         * Configurations/FeatureDefines.xcconfig:
643         Sort and split FeatureDefines into paragraphs
644         (to make it easier to sort later).
645
646 2018-03-07  Youenn Fablet  <youenn@apple.com>
647
648         Match unsupported plugins based on domains and not origin
649         https://bugs.webkit.org/show_bug.cgi?id=183384
650
651         Reviewed by Chris Dumez.
652
653         * WebCoreSupport/WebPluginInfoProvider.h:
654         * WebCoreSupport/WebPluginInfoProvider.mm:
655         (WebPluginInfoProvider::getPluginInfo):
656         (WebPluginInfoProvider::getWebVisiblePluginInfo):
657
658 2018-03-05  Andy Estes  <aestes@apple.com>
659
660         [Mac] Teach WebCore::Pasteboard about file promise drags
661         https://bugs.webkit.org/show_bug.cgi?id=183314
662         <rdar://problem/38105493>
663
664         Reviewed by Darin Adler.
665
666         Added a FIXME comment.
667
668         * WebView/WebView.mm:
669         (-[WebView performDragOperation:]):
670
671 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
672
673         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
674         https://bugs.webkit.org/show_bug.cgi?id=183312
675
676         Reviewed by Mark Lam.
677
678         Remove wtf/CurrentTime.h include pragma.
679
680         * WebView/WebFrame.mm:
681         * WebView/WebPDFView.mm:
682
683 2018-03-04  Tim Horton  <timothy_horton@apple.com>
684
685         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
686         https://bugs.webkit.org/show_bug.cgi?id=183283
687         <rdar://problem/38062148>
688
689         Reviewed by Sam Weinig.
690
691         * Configurations/FeatureDefines.xcconfig:
692
693 2018-02-28  Alex Christensen  <achristensen@webkit.org>
694
695         Reduce use of NetworkingContext in WebKit
696         https://bugs.webkit.org/show_bug.cgi?id=183213
697
698         Reviewed by Brady Eidson.
699
700         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
701         (WebKit::NetscapePluginInstanceProxy::getProxy):
702         * Plugins/WebNetscapePluginView.mm:
703         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
704
705 2018-02-17  Darin Adler  <darin@apple.com>
706
707         Prepare for ExtendedColor changes (first step)
708         https://bugs.webkit.org/show_bug.cgi?id=182904
709
710         Reviewed by Sam Weinig.
711
712         * Misc/WebKitNSStringExtras.mm:
713         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
714
715 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
716
717         Remove currentTime() / currentTimeMS()
718         https://bugs.webkit.org/show_bug.cgi?id=183052
719
720         Reviewed by Mark Lam.
721
722         * WebCoreSupport/WebFrameLoaderClient.h:
723         * WebCoreSupport/WebFrameLoaderClient.mm:
724         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
725
726 2018-02-16  Youenn Fablet  <youenn@apple.com>
727
728         Allow specifying which plug-ins are supported
729         https://bugs.webkit.org/show_bug.cgi?id=182748
730
731         Reviewed by Chris Dumez.
732
733         * WebCoreSupport/WebPluginInfoProvider.h:
734         * WebCoreSupport/WebPluginInfoProvider.mm:
735         (WebPluginInfoProvider::getPluginInfo):
736         (WebPluginInfoProvider::getWebVisiblePluginInfo):
737
738 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
739
740         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
741         https://bugs.webkit.org/show_bug.cgi?id=182882
742         <rdar://problem/35672661>
743
744         Reviewed by Dan Bernstein.
745
746         Make sure the smart pointer hold the collection of subviews lives at least as
747         long as the loop using it.
748
749         * WebView/WebHTMLView.mm:
750         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
751
752 2018-02-14  Daniel Bates  <dabates@apple.com>
753
754         Disallow cross-origin subresources from asking for credentials
755         https://bugs.webkit.org/show_bug.cgi?id=182579
756         <rdar://problem/36162271>
757
758         Reviewed by Andy Estes.
759
760         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
761         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
762
763         * WebView/WebPreferenceKeysPrivate.h:
764         * WebView/WebPreferences.mm:
765         (+[WebPreferences initialize]):
766         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
767         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
768         * WebView/WebPreferencesPrivate.h:
769         * WebView/WebView.mm:
770         (-[WebView _preferencesChanged:]):
771
772 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
773
774         Remove ForwardingHeaders directory from WebKitLegacy/mac.
775         https://bugs.webkit.org/show_bug.cgi?id=182738
776
777         Reviewed by Darin Adler.
778
779         * ForwardingHeaders/collector/handles/Global.h: Removed.
780         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
781         * ForwardingHeaders/runtime/Completion.h: Removed.
782         * ForwardingHeaders/runtime/Error.h: Removed.
783         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
784         * ForwardingHeaders/runtime/JSFunction.h: Removed.
785         * ForwardingHeaders/runtime/JSLock.h: Removed.
786         * ForwardingHeaders/runtime/JSObject.h: Removed.
787         * ForwardingHeaders/runtime/JSString.h: Removed.
788         * ForwardingHeaders/runtime/Protect.h: Removed.
789         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
790
791 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
792
793         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
794         https://bugs.webkit.org/show_bug.cgi?id=182641
795
796         Reviewed by Dan Bernstein.
797
798         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
799         https://trac.webkit.org/changeset/228308.
800
801         * WebView/WebVideoFullscreenController.h:
802         * WebView/WebVideoFullscreenHUDWindowController.mm:
803         * WebView/WebWindowAnimation.h:
804         * WebView/WebWindowAnimation.mm:
805         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
806         (WebCore::scaledRect): Deleted.
807         (WebCore::squaredDistance): Deleted.
808
809 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
810
811         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
812
813         * WebView/WebWindowAnimation.mm:
814         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
815
816 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
817
818         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
819         https://bugs.webkit.org/show_bug.cgi?id=182615
820
821         Reviewed by Eric Carlson.
822
823         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
824         Ideally, we should not reference NSApp in WebCore.
825
826         * WebView/WebFullScreenController.mm:
827         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
828         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
829         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
830         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
831         * WebView/WebView.mm:
832         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
833         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
834
835 2018-01-13  Darin Adler  <darin@apple.com>
836
837         Event improvements
838         https://bugs.webkit.org/show_bug.cgi?id=179591
839
840         Reviewed by Chris Dumez.
841
842         * DOM/DOMWheelEvent.mm:
843         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
844         Call initWebKitWheelEvent.
845
846         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
847         * WebCoreSupport/WebInspectorClient.mm: Ditto.
848         * WebView/WebFrame.mm: Ditto.
849
850         * WebView/WebHTMLView.mm:
851         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
852         underlyingPlatformEvent.
853         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
854
855         * WebView/WebScriptWorld.mm:
856         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
857
858         * WebView/WebView.mm: Removed include of ScriptValue.h.
859
860 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
861
862         Remove WebCore/ForwardingHeaders directory
863         https://bugs.webkit.org/show_bug.cgi?id=182347
864
865         Reviewed by Keith Miller.
866
867         * Carbon/CarbonWindowAdapter.mm:
868         * DOM/WebDOMOperations.mm:
869         * History/WebBackForwardList.mm:
870         * History/WebHistoryItem.mm:
871         * Misc/WebCache.mm:
872         * Misc/WebElementDictionary.mm:
873         * Misc/WebIconDatabase.mm:
874         * Misc/WebStringTruncator.mm:
875         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
876         * Plugins/Hosted/ProxyInstance.mm:
877         * Plugins/Hosted/ProxyRuntimeObject.mm:
878         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
879         * Plugins/WebBaseNetscapePluginView.mm:
880         * Plugins/WebBasePluginPackage.mm:
881         * Plugins/WebNetscapePluginStream.mm:
882         * Plugins/WebNetscapePluginView.mm:
883         * Plugins/WebPluginController.mm:
884         * WebCoreSupport/WebEditorClient.mm:
885         * WebCoreSupport/WebFrameLoaderClient.mm:
886         * WebCoreSupport/WebInspectorClient.h:
887         * WebCoreSupport/WebInspectorClient.mm:
888         * WebView/WebDataSource.mm:
889         * WebView/WebFrame.mm:
890         * WebView/WebHTMLRepresentation.mm:
891         * WebView/WebHTMLView.mm:
892         * WebView/WebPreferences.mm:
893         * WebView/WebScriptDebugDelegate.mm:
894         * WebView/WebScriptDebugger.h:
895         * WebView/WebTextIterator.mm:
896         * WebView/WebView.mm:
897         * WebView/WebViewData.mm:
898
899 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
900
901         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
902         https://bugs.webkit.org/show_bug.cgi?id=182312
903
904         Reviewed by Michael Catanzaro.
905
906         * WebKitPrefix.h:
907
908 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
909
910         [WebAuthN] Add a compile-time feature flag
911         https://bugs.webkit.org/show_bug.cgi?id=182211
912         <rdar://problem/36936365>
913
914         Reviewed by Brent Fulgham.
915
916         * Configurations/FeatureDefines.xcconfig:
917
918 2018-01-27  Dan Bernstein  <mitz@apple.com>
919
920         HaveInternalSDK includes should be "#include?"
921         https://bugs.webkit.org/show_bug.cgi?id=179670
922
923         * Configurations/Base.xcconfig:
924
925 2018-01-24  Alex Christensen  <achristensen@webkit.org>
926
927         Remove unused QTKit preference
928         https://bugs.webkit.org/show_bug.cgi?id=181968
929
930         Reviewed by Alexey Proskuryakov.
931
932         * WebView/WebPreferenceKeysPrivate.h:
933         * WebView/WebPreferences.mm:
934         (+[WebPreferences initialize]):
935         (-[WebPreferences setQTKitEnabled:]): Deleted.
936         (-[WebPreferences isQTKitEnabled]): Deleted.
937         * WebView/WebPreferencesPrivate.h:
938         * WebView/WebView.mm:
939         (-[WebView _preferencesChanged:]):
940
941 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
942
943         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
944         https://bugs.webkit.org/show_bug.cgi?id=182037
945         <rdar://problem/36747812>
946
947         Reviewed by Ryosuke Niwa.
948
949         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
950         for more details.
951
952         * WebView/WebHTMLRepresentation.mm:
953         (-[WebHTMLRepresentation elementWithName:inForm:]):
954         (-[WebHTMLRepresentation controlsInForm:]):
955
956 2018-01-23  Alex Christensen  <achristensen@webkit.org>
957
958         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
959         https://bugs.webkit.org/show_bug.cgi?id=181961
960
961         Reviewed by Michael Catanzaro.
962
963         * WebView/WebPreferences.mm:
964
965 2018-01-23  Commit Queue  <commit-queue@webkit.org>
966
967         Unreviewed, rolling out r227437.
968         https://bugs.webkit.org/show_bug.cgi?id=182011
969
970         broke build (Requested by alexchristensen on #webkit).
971
972         Reverted changeset:
973
974         "Remove unused QTKit preference"
975         https://bugs.webkit.org/show_bug.cgi?id=181968
976         https://trac.webkit.org/changeset/227437
977
978 2018-01-23  Alex Christensen  <achristensen@webkit.org>
979
980         Remove unused QTKit preference
981         https://bugs.webkit.org/show_bug.cgi?id=181968
982
983         Reviewed by Alexey Proskuryakov.
984
985         * WebView/WebPreferenceKeysPrivate.h:
986         * WebView/WebPreferences.mm:
987         (+[WebPreferences initialize]):
988         (-[WebPreferences setQTKitEnabled:]): Deleted.
989         (-[WebPreferences isQTKitEnabled]): Deleted.
990         * WebView/WebPreferencesPrivate.h:
991         * WebView/WebView.mm:
992         (-[WebView _preferencesChanged:]):
993
994 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
997         https://bugs.webkit.org/show_bug.cgi?id=181960
998         <rdar://problem/36431678>
999
1000         Reviewed by Tim Horton.
1001
1002         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1003         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1004         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1005
1006         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1007         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1008         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1009
1010         * WebView/WebView.mm:
1011         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1012
1013 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1014
1015         Turning off custom pasteboard data doesn't actually turn it off in WK2
1016         https://bugs.webkit.org/show_bug.cgi?id=181920
1017         <rdar://problem/36686429>
1018
1019         Reviewed by Wenson Hsieh.
1020
1021         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1022
1023         * WebView/WebPreferences.mm:
1024         (+[WebPreferences initialize]):
1025         * WebView/WebView.mm:
1026         (-[WebView _preferencesChanged:]):
1027
1028 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1029
1030         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1031         https://bugs.webkit.org/show_bug.cgi?id=181918
1032
1033         Reviewed by Tim Horton.
1034
1035         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1036
1037         * Configurations/FeatureDefines.xcconfig:
1038
1039 2018-01-20  Andy Estes  <aestes@apple.com>
1040
1041         [Apple Pay] Stop eagerly loading PassKit.framework
1042         https://bugs.webkit.org/show_bug.cgi?id=181911
1043         <rdar://problem/36555369>
1044
1045         Reviewed by Tim Horton.
1046
1047         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1048         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1049         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1050
1051         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1052
1053 2018-01-19  Dean Jackson  <dino@apple.com>
1054
1055         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1056         https://bugs.webkit.org/show_bug.cgi?id=181817
1057         <rdar://problem/35274055>
1058
1059         Reviewed by Simon Fraser.
1060
1061         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1062
1063         * Misc/WebKitVersionChecks.h:
1064         * WebView/WebView.mm:
1065         (-[WebView _commonInitializationWithFrameName:groupName:]):
1066
1067 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1068
1069         Remove unused WebViewPrivate _allowCookies
1070         https://bugs.webkit.org/show_bug.cgi?id=181812
1071
1072         Reviewed by Tim Horton.
1073
1074         * WebView/WebView.mm:
1075         (+[WebView _setAllowCookies:]): Deleted.
1076         (+[WebView _allowCookies]): Deleted.
1077         * WebView/WebViewPrivate.h:
1078
1079 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1080
1081         Build fix, remove a call to -[NSWindow setOneShot:]
1082         https://bugs.webkit.org/show_bug.cgi?id=181809
1083
1084         Reviewed by Tim Horton.
1085
1086         * WebView/WebTextCompletionController.mm:
1087         (-[WebTextCompletionController _buildUI]):
1088
1089 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1090
1091         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1092
1093         * Carbon/HIWebView.mm:
1094         (overrideCGContext):
1095         (restoreCGContext):
1096
1097 2018-01-18  Dan Bernstein  <mitz@apple.com>
1098
1099         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1100         https://bugs.webkit.org/show_bug.cgi?id=181803
1101
1102         Reviewed by Tim Horton.
1103
1104         * Configurations/Base.xcconfig: Updated.
1105         * Configurations/DebugRelease.xcconfig: Ditto.
1106         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1107         * Configurations/Version.xcconfig: Updated.
1108         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1109           useful for defining settings that depend on the target macOS version.
1110
1111 2018-01-17  Youenn Fablet  <youenn@apple.com>
1112
1113         Put fetch Request.keepalive behind a runtime flag
1114         https://bugs.webkit.org/show_bug.cgi?id=181592
1115
1116         Reviewed by Chris Dumez.
1117
1118         * WebView/WebPreferenceKeysPrivate.h:
1119         * WebView/WebPreferences.mm:
1120         (+[WebPreferences initialize]):
1121         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1122         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1123         * WebView/WebPreferencesPrivate.h:
1124         * WebView/WebView.mm:
1125         (-[WebView _preferencesChanged:]):
1126
1127 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1130         https://bugs.webkit.org/show_bug.cgi?id=181637
1131         <rdar://problem/36508471>
1132
1133         Reviewed by Tim Horton.
1134
1135         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1136
1137         * WebCoreSupport/WebEditorClient.h:
1138         * WebCoreSupport/WebEditorClient.mm:
1139         (WebEditorClient::replacementURLForResource):
1140
1141 2018-01-11  Keith Miller  <keith_miller@apple.com>
1142
1143         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1144         https://bugs.webkit.org/show_bug.cgi?id=181573
1145
1146         Reviewed by Simon Fraser.
1147
1148         * Configurations/FeatureDefines.xcconfig:
1149
1150 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1151
1152         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1153         https://bugs.webkit.org/show_bug.cgi?id=181497
1154
1155         Reviewed by Tim Horton.
1156
1157         See other ChangeLogs for more detail.
1158
1159         * WebCoreSupport/WebDragClient.h:
1160
1161 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1162
1163         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1164         https://bugs.webkit.org/show_bug.cgi?id=181523
1165         <rdar://problem/28959131>
1166
1167         Reviewed by Alex Christensen.
1168
1169         * WebView/WebImmediateActionController.mm:
1170         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1171         Apply the change made in r216652 to WebKit1's immediate action controller.
1172
1173         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1174         the startContainer of the range is in an anonymous node.
1175
1176 2018-01-11  Youenn Fablet  <youenn@apple.com>
1177
1178         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1179         https://bugs.webkit.org/show_bug.cgi?id=181480
1180
1181         Reviewed by Eric Carlson.
1182
1183         * WebView/WebPreferences.mm:
1184         (+[WebPreferences initialize]):
1185
1186 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1187
1188         Fix check-webkit-style issues with WebNSDataExtras.mm
1189         <https://webkit.org/b/181369>
1190
1191         Reviewed by Alex Christensen.
1192
1193         * Misc/WebNSDataExtras.mm:
1194         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1195         (-[NSData _webkit_guessedMIMETypeForXML]):
1196         (-[NSData _webkit_guessedMIMEType]):
1197         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1198         (_findEOL):
1199         (-[NSData _webkit_parseRFC822HeaderFields]):
1200         (-[NSData _web_locationAfterFirstBlankLine]):
1201         - Fix all the check-webkit-style warnings.
1202
1203 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1204
1205         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1206         <https://webkit.org/b/181256>
1207         <rdar://problem/36281730>
1208
1209         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1210         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1211         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1212           to avoid warnings from casting CFStringRef to NPNSString*.
1213           Note that CFMutableStringRef is the same as CFStringRef
1214           without the const modifier, hence its use in the const_cast<>
1215           above.
1216
1217 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1218
1219         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1220         <https://webkit.org/b/181256>
1221         <rdar://problem/36281730>
1222
1223         * Carbon/HIWebView.mm:
1224         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1225         checked_cf_cast<CFRunLoopRef>() to fix warning.
1226
1227 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1228
1229         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1230         <https://webkit.org/b/181256>
1231         <rdar://problem/36281730>
1232
1233         Reviewed by Darin Adler.
1234
1235         * Carbon/CarbonUtils.m:
1236         (PoolCleaner):
1237         - Use #pragmas to ignore -Wcast-qual warnings when using a
1238           C-style cast from CFTypeRef to CFRunloopRef.
1239         * Carbon/CarbonWindowFrame.m:
1240         (-[CarbonWindowFrame title]):
1241         - Use #pragmas to ignore -Wcast-qual warnings when using a
1242           C-style cast from CFStringRef to NSString *.
1243         * Carbon/HIViewAdapter.m:
1244         (+[HIViewAdapter getHIViewForNSView:]):
1245         - Use #pragmas to ignore -Wcast-qual warnings when using a
1246           C-style cast from CFTypeRef to HIViewRef.
1247         * Configurations/Base.xcconfig:
1248         (WARNING_CFLAGS): Add -Wcast-qual.
1249         * Misc/WebElementDictionary.mm:
1250         (-[WebElementDictionary objectForKey:]):
1251         - Use static_cast<SEL>(const_cast<void*>()) to fix
1252           warning.
1253         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1254         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1255         (-[NSData _webkit_guessedMIMETypeForXML]):
1256         (-[NSData _webkit_guessedMIMEType]):
1257         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1258         (_findEOL):
1259         (-[NSData _webkit_parseRFC822HeaderFields]):
1260         (-[NSData _web_startsWithBlankLine]):
1261         (-[NSData _web_locationAfterFirstBlankLine]):
1262         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1263           type to Objective-C++.  This fixes the warnings about
1264           discarding the `const` modifier when casing from CFStringRef
1265           to NSString * because in older clang versions, -Wcast-qual was
1266           completely broken when compiling C++ and Objective-C++ source
1267           files.  In newer clang versions, discarding the `const`
1268           modifier for toll-free bridged types is ignored when compiling
1269           Objective-C++ source.
1270         - Update copyright and license header.
1271         - Use reinterpret_cast<> and static_cast<> to fix warnings
1272           unrelated to (NSString *) C-style casts.
1273         - Replace use of MIN() macro with std::min<> template functions.
1274         - Fix location of `*` for local variables modified above.
1275         * Plugins/Hosted/NetscapePluginHostManager.mm:
1276         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1277         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1278         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1279         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1280           warnings.
1281         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1282         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1283         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1284           to fix warning.
1285         * Plugins/Hosted/ProxyInstance.mm:
1286         (WebKit::ProxyInstance::invoke):
1287         - Use static_cast<char*>(const_cast<void*>()) to fix
1288           warning when using -[NSData bytes].
1289         (WebKit::ProxyInstance::fieldValue const):
1290         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1291           to fix warning when using CFDataGetBytePtr().
1292         * Plugins/Hosted/WebTextInputWindowController.m:
1293         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1294         - Use #pragma to ignore -Wcast-qual warning since there
1295           is not a good way to avoid this warning in Objective-C.
1296         * Plugins/WebNetscapePluginStream.mm:
1297         (WebNetscapePluginStream::deliverData):
1298         - Use const_cast<void*>() to fix warning when using
1299           -[NSData bytes].
1300         * Plugins/WebNetscapePluginView.mm:
1301         (-[WebNetscapePluginView _createPlugin]):
1302         - Change C-style cast to const_cast<char*>() to fix
1303           warning.
1304         * WebCoreSupport/WebChromeClient.mm:
1305         (WebChromeClient::wrapCryptoKey const):
1306         (WebChromeClient::unwrapCryptoKey const):
1307         - Change C-style cast to
1308           static_cast<uint8_t*>(const_cast<void*>() to fix
1309           warning.
1310         * WebView/WebPDFView.mm:
1311         (_applicationInfoForMIMEType):
1312         - Change local variable type from 'NSURL *' to
1313           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1314           when calling -[NSURL path].
1315
1316 2018-01-05  Dan Bernstein  <mitz@apple.com>
1317
1318         Fixed the build following AppKit API deprecations in a recent SDKs
1319
1320         * WebView/WebFullScreenController.mm:
1321         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1322         (-[WebFullScreenController exitFullScreen]): Ditto.
1323         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1324         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1325         * WebView/WebHTMLView.mm:
1326         (-[WebHTMLView drawRect:]): Ditto.
1327         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1328         (-[WebHTMLView knowsPageRange:]): Ditto.
1329         * WebView/WebView.mm:
1330         (LayerFlushController::flushLayers): Ditto.
1331
1332 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1333
1334         [Attachment Support] Create attachment elements when dropping files on iOS
1335         https://bugs.webkit.org/show_bug.cgi?id=181192
1336         <rdar://problem/36280945>
1337
1338         Reviewed by Tim Horton.
1339
1340         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1341
1342         * WebCoreSupport/WebPlatformStrategies.h:
1343         * WebCoreSupport/WebPlatformStrategies.mm:
1344         (WebPlatformStrategies::informationForItemAtIndex):
1345         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1346
1347 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1348
1349         [Attachment Support] Add plumbing for starting a drag with promised blob data
1350         https://bugs.webkit.org/show_bug.cgi?id=181201
1351
1352         Reviewed by Tim Horton.
1353
1354         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1355
1356         * WebCoreSupport/WebDragClient.h:
1357
1358 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1359
1360         Add a WebAuthentication runtime feature flag
1361         https://bugs.webkit.org/show_bug.cgi?id=181220
1362         <rdar://problem/36055305>
1363
1364         Reviewed by Brent Fulgham.
1365
1366         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1367
1368         * WebView/WebPreferenceKeysPrivate.h:
1369         * WebView/WebPreferences.mm:
1370         (+[WebPreferences initialize]):
1371         (-[WebPreferences webAuthenticationEnabled]):
1372         (-[WebPreferences setWebAuthenticationEnabled:]):
1373         (-[WebPreferences credentialManagementEnabled]): Deleted.
1374         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1375         * WebView/WebPreferencesPrivate.h:
1376         * WebView/WebView.mm:
1377         (-[WebView _preferencesChanged:]):
1378
1379 2017-12-22  Jeff Miller  <jeffm@apple.com>
1380
1381         Update user-visible copyright strings to include 2018
1382         https://bugs.webkit.org/show_bug.cgi?id=181141
1383
1384         Reviewed by Dan Bernstein.
1385
1386         * Info.plist:
1387
1388 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1389
1390         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1391         https://bugs.webkit.org/show_bug.cgi?id=181188
1392
1393         Reviewed by Dan Bernstein.
1394
1395         See WebCore/ChangeLog for more detail.
1396
1397         * WebCoreSupport/WebDragClient.h:
1398         * WebCoreSupport/WebDragClient.mm:
1399         (WebDragClient::declareAndWriteAttachment): Deleted.
1400         * WebView/WebHTMLView.mm:
1401         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1402
1403 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1404
1405         Unreviewed, continue to fix build failures due to AppKit API deprecation
1406
1407         Wraps more code in -Wdeprecated-declarations.
1408
1409         * Carbon/HIWebView.mm:
1410         (overrideCGContext):
1411
1412 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1413
1414         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1415
1416         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1417
1418         * Carbon/CarbonWindowAdapter.mm:
1419         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1420         * Plugins/WebNetscapePluginView.mm:
1421         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1422         (-[WebNetscapePluginView sendDrawRectEvent:]):
1423         (-[WebNetscapePluginView drawRect:]):
1424
1425 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1426
1427         Fix build failures due to using deprecated AppKit symbols
1428         https://bugs.webkit.org/show_bug.cgi?id=181110
1429         <rdar://problem/36162865>
1430
1431         Reviewed by Dan Bernstein and Tim Horton.
1432
1433         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1434
1435         * Misc/WebKitNSStringExtras.mm:
1436         (-[NSString _web_drawAtPoint:font:textColor:]):
1437         * Misc/WebNSPasteboardExtras.h:
1438         * Misc/WebNSPasteboardExtras.mm:
1439         (+[NSPasteboard _web_writableTypesForURL]):
1440         (_createWritableTypesForImageWithoutArchive):
1441         (_createWritableTypesForImageWithArchive):
1442         (+[NSPasteboard _web_dragTypesForURL]):
1443         (-[NSPasteboard _web_bestURL]):
1444         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1445         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1446         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1447         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1448         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1449         * Panels/WebAuthenticationPanel.m:
1450         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1451         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1452         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1453         (-[WebHostedNetscapePluginView drawRect:]):
1454         * WebInspector/WebNodeHighlightView.mm:
1455         (-[WebNodeHighlightView drawRect:]):
1456         * WebView/WebFrame.mm:
1457         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1458         (-[WebFrame _drawRect:contentsOnly:]):
1459         * WebView/WebHTMLView.mm:
1460         (kit):
1461         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1462         (-[WebHTMLView _plainTextFromPasteboard:]):
1463         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1464         (+[WebHTMLView _insertablePasteboardTypes]):
1465         (+[WebHTMLView _selectionPasteboardTypes]):
1466         (-[WebHTMLView pasteboard:provideDataForType:]):
1467         (-[WebHTMLView _writeSelectionToPasteboard:]):
1468         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1469         (-[WebHTMLView validRequestorForSendType:returnType:]):
1470         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1471         (createMenuItem):
1472         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1473         (-[WebHTMLView _colorAsString:]):
1474         (-[WebHTMLView copyFont:]):
1475         * WebView/WebPDFView.mm:
1476         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1477         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1478         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1479         (-[WebPDFView pasteboardTypesForSelection]):
1480         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1481         * WebView/WebView.h:
1482         * WebView/WebView.mm:
1483         (-[WebView performDragOperation:]):
1484         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1485         (-[WebView _searchWithGoogleFromMenu:]):
1486
1487 2017-12-21  Youenn Fablet  <youenn@apple.com>
1488
1489         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1490         https://bugs.webkit.org/show_bug.cgi?id=181000
1491
1492         Reviewed by Chris Dumez.
1493
1494         * Misc/WebCache.mm:
1495         (+[WebCache addImageToCache:forURL:forFrame:]):
1496
1497 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1498
1499         Update FULLSCREEN_API feature defines.
1500         https://bugs.webkit.org/show_bug.cgi?id=181015
1501
1502         Reviewed by Tim Horton.
1503
1504         Change enabled iphone sdk for FULLSCREEN_API.
1505
1506         * Configurations/FeatureDefines.xcconfig:
1507
1508 2017-12-21  Jer Noble  <jer.noble@apple.com>
1509
1510         Add initial DOM support for Media Capabilities
1511         https://bugs.webkit.org/show_bug.cgi?id=181064
1512
1513         Reviewed by Eric Carlson.
1514
1515         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1516
1517         * WebView/WebPreferenceKeysPrivate.h:
1518         * WebView/WebPreferences.mm:
1519         (+[WebPreferences initialize]):
1520         (-[WebPreferences mediaCapabilitiesEnabled]):
1521         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1522         * WebView/WebPreferencesPrivate.h:
1523         * WebView/WebView.mm:
1524         (-[WebView _preferencesChanged:]):
1525
1526 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1527
1528         Enable picture-in-picture from inline element on suspend.
1529         https://bugs.webkit.org/show_bug.cgi?id=180942
1530         rdar://problem/34745234
1531
1532         Reviewed by Jer Noble.
1533
1534         Update signature of enterVideoFullscreenForVideoElement().
1535
1536         * WebCoreSupport/WebChromeClient.h:
1537         * WebCoreSupport/WebChromeClient.mm:
1538         (WebChromeClient::enterVideoFullscreenForVideoElement):
1539
1540 2017-12-20  Daniel Bates  <dabates@apple.com>
1541
1542         Remove Alternative Presentation Button
1543         https://bugs.webkit.org/show_bug.cgi?id=180500
1544         <rdar://problem/35891047>
1545
1546         Reviewed by Simon Fraser.
1547
1548         We no longer need the alternative presentation button.
1549
1550         * Configurations/FeatureDefines.xcconfig:
1551
1552 2017-12-19  Jer Noble  <jer.noble@apple.com>
1553
1554         Playing media elements which call "pause(); play()" will have the play promise rejected.
1555         https://bugs.webkit.org/show_bug.cgi?id=180781
1556         <rdar://problem/33191377>
1557
1558         Reviewed by Eric Carlson.
1559
1560         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1561
1562         * WebView/WebView.mm:
1563         (shouldRequireUserGestureToLoadVideo):
1564
1565 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1566
1567         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1568         https://bugs.webkit.org/show_bug.cgi?id=180977
1569
1570         Reviewed by Tim Horton.
1571
1572         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1573         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1574         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1575
1576         * WebCoreSupport/WebEditorClient.mm:
1577         (attributesForAttributedStringConversion):
1578         * WebView/WebHTMLView.mm:
1579         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1580
1581 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1582
1583         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1584
1585         Attempt to fix the following warnings:
1586
1587             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1588
1589         For the following instance variables:
1590
1591             _borderView
1592             _contentView
1593             _frame
1594             _wFlags
1595
1596         * Carbon/CarbonWindowAdapter.mm:
1597         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1598         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1599         (-[CarbonWindowAdapter _termWindowIfOwner]):
1600         (-[CarbonWindowAdapter _windowMovedToRect:]):
1601         (-[CarbonWindowAdapter setContentView:]):
1602         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1603         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1604
1605 2017-12-16  Dan Bernstein  <mitz@apple.com>
1606
1607         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1608         https://bugs.webkit.org/show_bug.cgi?id=180613
1609         <rdar://problem/35946124>
1610
1611         Reviewed by Geoff Garen.
1612
1613         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1614           clients.
1615         * WebView/WebDynamicScrollBarsView.h: Ditto.
1616         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1617
1618 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1619
1620         Enable -Wstrict-prototypes for WebKit
1621         <https://webkit.org/b/180757>
1622         <rdar://problem/36024132>
1623
1624         Rubber-stamped by Joseph Pecoraro.
1625
1626         * Configurations/Base.xcconfig:
1627         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1628
1629 2017-12-14  John Wilander  <wilander@apple.com>
1630
1631         Storage Access API: Implement frame-specific access in the document.cookie layer
1632         https://bugs.webkit.org/show_bug.cgi?id=180682
1633         <rdar://problem/35982257>
1634
1635         Reviewed by Alex Christensen.
1636
1637         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1638         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1639         CookiesStrategy::getRawCookies() now take optional parameters for
1640         frameID and pageID to allow frame-specific scoping of cookies.
1641
1642         This change makes the return values of FrameLoaderClient::frameID()
1643         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1644         WebCore can call those getters and get the right return values in
1645         WebKit and std:nullopt in WebKitLegacy.
1646
1647         * WebCoreSupport/WebFrameLoaderClient.h:
1648         * WebCoreSupport/WebFrameLoaderClient.mm:
1649         (WebFrameLoaderClient::pageID const):
1650         (WebFrameLoaderClient::frameID const):
1651         * WebCoreSupport/WebPlatformStrategies.h:
1652         * WebCoreSupport/WebPlatformStrategies.mm:
1653         (WebPlatformStrategies::cookiesForDOM):
1654         (WebPlatformStrategies::setCookiesFromDOM):
1655         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1656         (WebPlatformStrategies::getRawCookies):
1657
1658 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1659
1660         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1661         https://bugs.webkit.org/show_bug.cgi?id=180689
1662
1663         Reviewed by Tim Horton.
1664
1665         Use sRGBColorSpaceRef() from WebCore.
1666
1667         * WebView/WebHTMLView.mm:
1668         (imageFromRect):
1669
1670 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1671
1672         Stop using deprecated target conditional for simulator builds
1673         https://bugs.webkit.org/show_bug.cgi?id=180662
1674         <rdar://problem/35136156>
1675
1676         Reviewed by Simon Fraser.
1677
1678         * postprocess-headers.sh:
1679
1680 2017-12-11  David Quesada  <david_quesada@apple.com>
1681
1682         Turn on ENABLE_APPLICATION_MANIFEST
1683         https://bugs.webkit.org/show_bug.cgi?id=180562
1684         rdar://problem/35924737
1685
1686         Reviewed by Geoffrey Garen.
1687
1688         * Configurations/FeatureDefines.xcconfig:
1689
1690 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1691
1692         Remove pthread_once in favor of dispatch_once
1693         https://bugs.webkit.org/show_bug.cgi?id=180591
1694
1695         Reviewed by Saam Barati.
1696
1697         * Misc/WebKitErrors.m:
1698         (+[NSError _registerWebKitErrors]):
1699         (registerErrors): Deleted.
1700         * Storage/WebStorageManager.mm:
1701         (+[WebStorageManager _storageDirectoryPath]):
1702         (initializeLocalStoragePath): Deleted.
1703
1704 2017-12-07  Darin Adler  <darin@apple.com>
1705
1706         Remove some unused code from WebKitLegacy
1707         https://bugs.webkit.org/show_bug.cgi?id=180567
1708
1709         Reviewed by Anders Carlsson.
1710
1711         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1712         macOS (back a few versions) and iOS and removed unused
1713         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1714         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1715         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1716         _webkit_stringByCollapsingNonPrintingCharacters,
1717         _webkit_stringByCollapsingWhitespaceCharacters,
1718         _web_stringWithData:textEncodingName:, and
1719         _webkit_localStorageDirectoryWithBundleIdentifier:.
1720
1721         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1722         this source file.
1723         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1724         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1725         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1726         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1727         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1728         handle font smoothing options.
1729         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1730         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1731         from header and made it a little clearer.
1732         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1733         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1734         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1735         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1736         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1737         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1738         implementation a bit and used whole words instead of abbreviations.
1739         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1740
1741         * Misc/WebNSFileManagerExtras.mm:
1742         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1743         filenameByFixingIllegalCharacters function from WebCore directly instead of
1744         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1745
1746         * Plugins/WebBaseNetscapePluginView.mm:
1747         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1748         string replacements instead of _web_stringByStrippingReturnCharacters
1749         and to use NSString methods instead of CFString functions.
1750
1751 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1752
1753         Ignore deprecation warnings.
1754
1755         * WebView/WebHTMLView.mm:
1756         (-[NSWindow _web_borderView]):
1757         (-[WebHTMLView _setAsideSubviews]):
1758         * WebView/WebView.mm:
1759         (-[WebView encodeWithCoder:]):
1760
1761 2017-12-02  Darin Adler  <darin@apple.com>
1762
1763         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1764         https://bugs.webkit.org/show_bug.cgi?id=180009
1765
1766         Reviewed by Alex Christensen.
1767
1768         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1769
1770         * Plugins/WebBaseNetscapePluginView.mm:
1771         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1772         of strcasecmp.
1773
1774         * WebView/WebPreferences.mm:
1775         (contains): Ditto. Also made this a template so it's easier to call on an array.
1776         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1777
1778 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1779
1780         Limit user agent versioning to an upper bound
1781         https://bugs.webkit.org/show_bug.cgi?id=180365
1782         <rdar://problem/34550617>
1783
1784         Reviewed by Joseph Pecoraro.
1785
1786         * WebView/WebView.mm:
1787         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1788         creating the User Agent string.
1789         (webKitBundleVersionString): Deleted.
1790
1791 2017-12-05  Andy Estes  <aestes@apple.com>
1792
1793         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1794         https://bugs.webkit.org/show_bug.cgi?id=180457
1795         <rdar://problem/35143007>
1796
1797         Reviewed by Tim Horton.
1798
1799         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1800         check for this macro during post-processing.
1801
1802         * postprocess-headers.sh:
1803
1804 2017-12-04  David Quesada  <david_quesada@apple.com>
1805
1806         Add a class for parsing application manifests
1807         https://bugs.webkit.org/show_bug.cgi?id=177973
1808         rdar://problem/34747949
1809
1810         Reviewed by Geoffrey Garen.
1811
1812         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1813
1814 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1815
1816         Make LegacyCustomProtocolManager optional for network process
1817         https://bugs.webkit.org/show_bug.cgi?id=176230
1818
1819         Reviewed by Alex Christensen.
1820
1821         * Configurations/FeatureDefines.xcconfig:
1822
1823 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1824
1825         Fix some NSOperationQueue leaks
1826         https://bugs.webkit.org/show_bug.cgi?id=180221
1827
1828         Reviewed by Wenson Hsieh.
1829
1830         * WebView/WebView.mm:
1831         (-[WebView performDragOperation:]):
1832
1833 2017-11-30  Darin Adler  <darin@apple.com>
1834
1835         [Mac] remove unneeded RetainPtr use introduced in r225142
1836         https://bugs.webkit.org/show_bug.cgi?id=180202
1837
1838         Reviewed by Tim Horton.
1839
1840         * WebView/WebImmediateActionController.mm:
1841         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1842         RetainPtr.
1843
1844 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1845
1846         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1847         https://bugs.webkit.org/show_bug.cgi?id=175595
1848
1849         Reviewed by Darin Adler.
1850
1851         * WebView/WebPreferences.mm:
1852
1853 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1854
1855         One too many zeroes in macOS version number in FeatureDefines
1856         https://bugs.webkit.org/show_bug.cgi?id=180011
1857
1858         Reviewed by Dan Bernstein.
1859
1860         * Configurations/FeatureDefines.xcconfig:
1861
1862 2017-11-23  Darin Adler  <darin@apple.com>
1863
1864         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1865         https://bugs.webkit.org/show_bug.cgi?id=179981
1866
1867         Reviewed by Sam Weinig.
1868
1869         * WebView/WebImmediateActionController.mm:
1870         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1871         * WebView/WebView.mm:
1872         (coreOptions): Use |= instead of | to build up FindOptions.
1873
1874 2017-11-23  Sam Weinig  <sam@webkit.org>
1875
1876         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1877         https://bugs.webkit.org/show_bug.cgi?id=179954
1878
1879         Reviewed by Darin Adler.
1880
1881         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1882         with direct calls to the corresponding UserGestureIndicator functions.
1883
1884         * Plugins/WebPluginController.mm:
1885         (-[WebPluginController processingUserGesture]):
1886         * WebView/WebView.mm:
1887         (-[WebView _isProcessingUserGesture]):
1888
1889 2017-11-23  Darin Adler  <darin@apple.com>
1890
1891         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1892         https://bugs.webkit.org/show_bug.cgi?id=179907
1893
1894         Reviewed by Sam Weinig.
1895
1896         * History/BinaryPropertyList.cpp:
1897         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1898         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1899         * WebView/WebHTMLRepresentation.mm:
1900         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1901         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1902
1903 2017-11-22  Ali Juma  <ajuma@chromium.org>
1904
1905         Implement VisualViewport API attributes
1906         https://bugs.webkit.org/show_bug.cgi?id=179385
1907
1908         Reviewed by Frédéric Wang.
1909
1910         Add a VisualViewportAPI preference.
1911
1912         * WebView/WebPreferenceKeysPrivate.h:
1913         * WebView/WebPreferences.mm:
1914         (+[WebPreferences initialize]):
1915         (-[WebPreferences visualViewportAPIEnabled]):
1916         (-[WebPreferences setVisualViewportAPIEnabled:]):
1917         * WebView/WebPreferencesPrivate.h:
1918         * WebView/WebView.mm:
1919         (-[WebView _preferencesChanged:]):
1920
1921 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1922
1923         WebCoreObjCExtras.h is being included in too many places
1924         https://bugs.webkit.org/show_bug.cgi?id=179931
1925
1926         Reviewed by Darin Adler.
1927
1928         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1929         * Plugins/WebBaseNetscapePluginView.mm:
1930         * Plugins/WebBasePluginPackage.mm:
1931         * Plugins/WebNetscapePluginStream.mm:
1932         * Plugins/WebNetscapePluginView.mm:
1933         * WebView/WebTextIterator.mm:
1934         * WebView/WebViewData.mm:
1935
1936 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1937
1938         Unreviewed, rolling out r225093.
1939         https://bugs.webkit.org/show_bug.cgi?id=179938
1940
1941         Compilation failed on WinCairo 64-bit Release (Requested by
1942         fredw on #webkit).
1943
1944         Reverted changeset:
1945
1946         "Implement VisualViewport API attributes"
1947         https://bugs.webkit.org/show_bug.cgi?id=179385
1948         https://trac.webkit.org/changeset/225093
1949
1950 2017-11-21  Ali Juma  <ajuma@chromium.org>
1951
1952         Implement VisualViewport API attributes
1953         https://bugs.webkit.org/show_bug.cgi?id=179385
1954
1955         Reviewed by Frédéric Wang.
1956
1957         Add a VisualViewportAPI preference.
1958
1959         * WebView/WebPreferenceKeysPrivate.h:
1960         * WebView/WebPreferences.mm:
1961         (+[WebPreferences initialize]):
1962         (-[WebPreferences visualViewportAPIEnabled]):
1963         (-[WebPreferences setVisualViewportAPIEnabled:]):
1964         * WebView/WebPreferencesPrivate.h:
1965         * WebView/WebView.mm:
1966         (-[WebView _preferencesChanged:]):
1967
1968 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1969
1970         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1971         https://bugs.webkit.org/show_bug.cgi?id=179504
1972
1973         Reviewed by Darin Adler.
1974
1975         * Misc/WebKitNSStringExtras.mm:
1976         * Plugins/Hosted/NetscapePluginHostManager.mm:
1977         * Plugins/WebBasePluginPackage.mm:
1978
1979 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1980
1981         Remove unused TOUCH_ICON_LOADING feature flag
1982         https://bugs.webkit.org/show_bug.cgi?id=179873
1983
1984         Reviewed by Simon Fraser.
1985
1986         * Configurations/FeatureDefines.xcconfig:
1987
1988 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1989
1990         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1991         https://bugs.webkit.org/show_bug.cgi?id=179872
1992
1993         Reviewed by Darin Adler.
1994
1995         * Configurations/FeatureDefines.xcconfig:
1996
1997 2017-11-16  Daniel Bates  <dabates@apple.com>
1998
1999         Add feature define for alternative presentation button element
2000         https://bugs.webkit.org/show_bug.cgi?id=179692
2001         Part of <rdar://problem/34917108>
2002
2003         Reviewed by Andy Estes.
2004
2005         Only enabled on Cocoa platforms by default.
2006
2007         * Configurations/FeatureDefines.xcconfig:
2008
2009 2017-11-14  Nan Wang  <n_wang@apple.com>
2010
2011         AX: AOM: Implement AccessibleNode class and support label and role attributes
2012         https://bugs.webkit.org/show_bug.cgi?id=179494
2013
2014         Reviewed by Ryosuke Niwa.
2015
2016         * WebView/WebPreferenceKeysPrivate.h:
2017         * WebView/WebPreferences.mm:
2018         (+[WebPreferences initialize]):
2019         (-[WebPreferences accessibilityObjectModelEnabled]):
2020         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2021         * WebView/WebPreferencesPrivate.h:
2022         * WebView/WebView.mm:
2023         (-[WebView _preferencesChanged:]):
2024
2025 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2026
2027         Remove Cocoa CFURLConnection loading code
2028         https://bugs.webkit.org/show_bug.cgi?id=179688
2029
2030         Reviewed by Antti Koivisto.
2031
2032         * Misc/WebDownload.mm:
2033         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2034         * Misc/WebDownloadInternal.h:
2035         * Plugins/WebBaseNetscapePluginView.mm:
2036         * WebCoreSupport/WebFrameLoaderClient.mm:
2037         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2038         * WebView/WebView.mm:
2039         (-[WebView scheduleInRunLoop:forMode:]):
2040         (-[WebView unscheduleFromRunLoop:forMode:]):
2041
2042 2017-11-14  Daniel Bates  <dabates@apple.com>
2043
2044         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2045         for feature defines
2046
2047         Following r195498 and r201917 the Visual Studio property files for feature defines have
2048         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2049         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2050         files.
2051
2052         * Configurations/FeatureDefines.xcconfig:
2053
2054 2017-11-14  Jer Noble  <jer.noble@apple.com>
2055
2056         Enable Modern EME tests in DumpRenderTree
2057         https://bugs.webkit.org/show_bug.cgi?id=179544
2058
2059         Reviewed by Alex Christensen.
2060
2061         Add a WebPreferences property to enable the (modern) EME API.
2062
2063         * WebView/WebPreferenceKeysPrivate.h:
2064         * WebView/WebPreferences.mm:
2065         (+[WebPreferences initialize]):
2066         (-[WebPreferences encryptedMediaAPIEnabled]):
2067         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2068         * WebView/WebPreferencesPrivate.h:
2069         * WebView/WebView.mm:
2070         (-[WebView _preferencesChanged:]):
2071
2072 2017-11-14  Antti Koivisto  <antti@apple.com>
2073
2074         Enable display:contents by default
2075         https://bugs.webkit.org/show_bug.cgi?id=179655
2076
2077         Reviewed by Sam Weinig.
2078
2079         * WebView/WebPreferences.mm:
2080         (+[WebPreferences initialize]):
2081
2082 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2083
2084         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2085         https://bugs.webkit.org/show_bug.cgi?id=178751
2086
2087         Reviewed by Brady Eidson.
2088
2089         * WebCoreSupport/WebFrameNetworkingContext.mm:
2090         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2091
2092 2017-11-08  Keith Miller  <keith_miller@apple.com>
2093
2094         Async iteration should only fetch the next method once and add feature flag
2095         https://bugs.webkit.org/show_bug.cgi?id=179451
2096
2097         Reviewed by Geoffrey Garen.
2098
2099         Add feature flag for Async iteration.
2100
2101         * Configurations/FeatureDefines.xcconfig:
2102
2103 2017-11-13  Mark Lam  <mark.lam@apple.com>
2104
2105         Add more overflow check book-keeping for MarkedArgumentBuffer.
2106         https://bugs.webkit.org/show_bug.cgi?id=179634
2107         <rdar://problem/35492517>
2108
2109         Reviewed by Saam Barati.
2110
2111         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2112         (WebKit::NetscapePluginInstanceProxy::invoke):
2113         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2114         (WebKit::NetscapePluginInstanceProxy::construct):
2115
2116 2017-11-12  Darin Adler  <darin@apple.com>
2117
2118         More is<> and downcast<>, less static_cast<>
2119         https://bugs.webkit.org/show_bug.cgi?id=179600
2120
2121         Reviewed by Chris Dumez.
2122
2123         * DOM/DOM.mm:
2124         (kit): Use is/downcast.
2125         * WebCoreSupport/WebEditorClient.mm:
2126         (WebEditorClient::handleKeyboardEvent): Ditto.
2127         (WebEditorClient::handleInputMethodKeydown): Ditto.
2128         * WebView/WebHTMLView.mm:
2129         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2130
2131 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2132
2133         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2134         https://bugs.webkit.org/show_bug.cgi?id=179397
2135
2136         Reviewed by Wenson Hsieh.
2137
2138         * DOM/DOMHTMLInputElement.mm:
2139         (-[DOMHTMLInputElement insertTextSuggestion:]):
2140
2141 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2142
2143         HTMLMediaElement should not use element fullscreen on iOS
2144         https://bugs.webkit.org/show_bug.cgi?id=179418
2145         rdar://problem/35409277
2146
2147         Reviewed by Eric Carlson.
2148
2149         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2150
2151         * Configurations/FeatureDefines.xcconfig:
2152
2153 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2154
2155         Make ResourceLoader::willSendRequestInternal asynchronous
2156         https://bugs.webkit.org/show_bug.cgi?id=179251
2157
2158         Reviewed by Andy Estes.
2159
2160         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2161         (WebKit::HostedNetscapePluginStream::start):
2162         * Plugins/WebNetscapePluginStream.mm:
2163         (WebNetscapePluginStream::start):
2164
2165 2017-11-01  Darin Adler  <darin@apple.com>
2166
2167         Simplify event dispatch code and make it a bit more consistent
2168         https://bugs.webkit.org/show_bug.cgi?id=178991
2169
2170         Reviewed by Chris Dumez.
2171
2172         * DOM/DOMEvent.mm:
2173         (-[DOMEvent srcElement]): Call target instead of srcElement.
2174
2175 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2176
2177         [Touch Bar Web API] Add support for menuitem tag
2178         https://bugs.webkit.org/show_bug.cgi?id=179020
2179
2180         Reviewed by Ryosuke Niwa.
2181
2182         Adds in properties and methods that allow the menuitem runtime feature
2183         to be enabled or disabled.
2184
2185         * WebView/WebPreferenceKeysPrivate.h:
2186         * WebView/WebPreferences.mm:
2187         (-[WebPreferences menuItemElementEnabled]):
2188         (-[WebPreferences setMenuItemElementEnabled:]):
2189         * WebView/WebPreferencesPrivate.h:
2190         * WebView/WebView.mm:
2191         (-[WebView _preferencesChanged:]):
2192
2193 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2194
2195         Use CompletionHandlers for redirects
2196         https://bugs.webkit.org/show_bug.cgi?id=179163
2197
2198         Reviewed by Tim Horton.
2199
2200         * Plugins/Hosted/HostedNetscapePluginStream.h:
2201         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2202         (WebKit::HostedNetscapePluginStream::willSendRequest):
2203         * Plugins/WebNetscapePluginStream.h:
2204         * Plugins/WebNetscapePluginStream.mm:
2205         (WebNetscapePluginStream::willSendRequest):
2206
2207 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2208
2209         Add a FileSystem namespace to FileSystem.cpp
2210         https://bugs.webkit.org/show_bug.cgi?id=179063
2211
2212         Reviewed by Darin Adler.
2213
2214         * Misc/WebNSFileManagerExtras.mm:
2215         * Storage/WebDatabaseProvider.mm:
2216
2217 2017-11-02  Frederic Wang  <fwang@igalia.com>
2218
2219         Add references to bug 179167 in FIXME comments
2220         https://bugs.webkit.org/show_bug.cgi?id=179168
2221
2222         Reviewed by Daniel Bates.
2223
2224         * Configurations/FeatureDefines.xcconfig:
2225
2226 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2227
2228         Implement WKFullscreenWindowController for iOS.
2229         https://bugs.webkit.org/show_bug.cgi?id=178924
2230         rdar://problem/34697120
2231
2232         Reviewed by Simon Fraser.
2233
2234         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2235
2236         * Configurations/FeatureDefines.xcconfig:
2237         * WebView/WebView.mm:
2238         (-[WebView fullScreenPlaceholderView]):
2239
2240 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2241
2242         Clean up some drag and drop feature flags
2243         https://bugs.webkit.org/show_bug.cgi?id=179082
2244
2245         Reviewed by Simon Fraser.
2246
2247         * Configurations/FeatureDefines.xcconfig:
2248
2249 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2250
2251         Make it possible to test rubber-banding in overflow scroll
2252         https://bugs.webkit.org/show_bug.cgi?id=179078
2253
2254         Reviewed by Sam Weinig.
2255
2256         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2257         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2258
2259         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2260         functions, since most callers want clamped.
2261
2262         * DOM/DOMHTML.mm:
2263         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2264
2265 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2266
2267         Fix up some content filtering feature flags
2268         https://bugs.webkit.org/show_bug.cgi?id=179079
2269
2270         Reviewed by Simon Fraser.
2271
2272         * Configurations/FeatureDefines.xcconfig:
2273
2274 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2275
2276         [FrameView::layout cleanup] Move core layout logic to a separate class.
2277         https://bugs.webkit.org/show_bug.cgi?id=178771
2278         <rdar://problem/35166542>
2279
2280         Reviewed by Simon Fraser.
2281
2282         Move layout code out from FrameView to LayoutContext.
2283
2284         * WebView/WebClipView.mm:
2285         (-[WebClipView _immediateScrollToPoint:]):
2286         * WebView/WebFrame.mm:
2287         (-[WebFrame layoutCount]):
2288
2289 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2290
2291         Fix issues with WebView subframe painting
2292         https://bugs.webkit.org/show_bug.cgi?id=178842
2293         rdar://problem/34072253
2294
2295         Reviewed by Daniel Bates.
2296         
2297         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2298         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2299         High Sierra, so match the new signature.
2300
2301         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2302
2303         * WebView/WebHTMLView.mm:
2304         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2305         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2306
2307 2017-10-25  Youenn Fablet  <youenn@apple.com>
2308
2309         Enable ServiceWorker to fetch resources
2310         https://bugs.webkit.org/show_bug.cgi?id=178673
2311
2312         Reviewed by Brady Eidson.
2313
2314         * WebCoreSupport/WebFrameLoaderClient.mm:
2315         (WebFrameLoaderClient::pageID const):
2316         (WebFrameLoaderClient::frameID const):
2317         (WebFrameLoaderClient::sessionID const):
2318
2319         Added implementation to the new getters.
2320         They are noop in the context of WK1.
2321
2322 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2323
2324         Web Inspector: Enable WebKit logging configuration and display
2325         https://bugs.webkit.org/show_bug.cgi?id=177027
2326         <rdar://problem/33964767>
2327
2328         Reviewed by Joseph Pecoraro.
2329
2330         * WebCoreSupport/WebChromeClient.mm:
2331         (stringForMessageSource): Deal with Media and WebRTC message sources.
2332
2333 2017-10-20  Antoine Quint  <graouts@apple.com>
2334
2335         [Web Animations] Provide basic timeline and animation interfaces
2336         https://bugs.webkit.org/show_bug.cgi?id=178526
2337
2338         Reviewed by Dean Jackson.
2339
2340         Remove the WEB_ANIMATIONS compile-time flag.
2341
2342         * Configurations/FeatureDefines.xcconfig:
2343         * WebView/WebPreferences.mm:
2344         (+[WebPreferences initialize]):
2345         * WebView/WebView.mm:
2346         (-[WebView _preferencesChanged:]):
2347
2348 2017-10-19  Sam Weinig  <sam@webkit.org>
2349
2350         [Settings] Move global settings into their own file
2351         https://bugs.webkit.org/show_bug.cgi?id=178512
2352
2353         Reviewed by Darin Adler.
2354
2355         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2356
2357         * WebCoreSupport/WebChromeClient.mm:
2358         (WebChromeClient::supportsVideoFullscreen):
2359         * WebView/WebDynamicScrollBarsView.mm:
2360         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2361         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2362         * WebView/WebPreferences.mm:
2363         (+[WebPreferences initialize]):
2364         * WebView/WebView.mm:
2365         (-[WebView _commonInitializationWithFrameName:groupName:]):
2366         (-[WebView _preferencesChanged:]):
2367         (+[WebView _doNotStartObservingNetworkReachability]):
2368
2369 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2370
2371         Replace some stack raw pointers with RefPtrs within WebCore/html
2372         https://bugs.webkit.org/show_bug.cgi?id=178201
2373         <rdar://problem/34841692>
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         * DOM/DOM.mm:
2378         (kit):
2379         Change the type of node as toNode() is changed to return RefPtr.
2380
2381 2017-10-18  Chris Dumez  <cdumez@apple.com>
2382
2383         [Service Worker] Add stubs for Client / WindowClient / Clients
2384         https://bugs.webkit.org/show_bug.cgi?id=178469
2385
2386         Reviewed by Youenn Fablet.
2387
2388         Rename PageVisiblityState to VisibilityState.
2389
2390         * WebView/WebView.mm:
2391         (kit):
2392
2393 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2394
2395         Unreviewed, rolling out r223291.
2396
2397         See WebCore ChangeLog for more detail.
2398
2399         Reverted changeset:
2400
2401         "Remove Editor::simplifyMarkup"
2402         https://bugs.webkit.org/show_bug.cgi?id=178271
2403         https://trac.webkit.org/changeset/223291
2404
2405 2017-10-17  Keith Miller  <keith_miller@apple.com>
2406
2407         Change WebCore sources to work with unified source builds
2408         https://bugs.webkit.org/show_bug.cgi?id=178229
2409
2410         Rubber stamped by Tim Horton.
2411
2412         * Configurations/FeatureDefines.xcconfig:
2413
2414 2017-10-16  Sam Weinig  <sam@webkit.org>
2415
2416         [Settings] Remove all custom code from Settings.h/cpp
2417         https://bugs.webkit.org/show_bug.cgi?id=178330
2418
2419         Reviewed by Simon Fraser.
2420
2421         * WebView/WebPreferences.mm:
2422         (+[WebPreferences initialize]):
2423         
2424             Update for naming changes of FrameFlattening now that it is an enum class.
2425
2426 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2427
2428         Remove Editor::simplifyMarkup
2429         https://bugs.webkit.org/show_bug.cgi?id=178271
2430
2431         Reviewed by Wenson Hsieh.
2432
2433         * WebView/WebView.mm:
2434         (-[WebView _simplifyMarkup:endNode:]):
2435
2436 2017-10-12  Chris Dumez  <cdumez@apple.com>
2437
2438         [Mac] Add support for MouseEvent.buttons
2439         https://bugs.webkit.org/show_bug.cgi?id=178214
2440
2441         Reviewed by Ryosuke Niwa.
2442
2443         * WebView/WebPDFView.mm:
2444         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2445
2446 2017-10-11  Sam Weinig  <sam@webkit.org>
2447
2448         Remove out-parameter variants of copyToVector
2449         https://bugs.webkit.org/show_bug.cgi?id=178155
2450
2451         Reviewed by Tim Horton.
2452
2453         * Plugins/WebNetscapePluginView.mm:
2454         (-[WebNetscapePluginView destroyPlugin]):
2455         * WebView/WebHTMLRepresentation.mm:
2456         (newArrayWithStrings):
2457
2458             Replace out-parameter based copyToVector, with one that returns a Vector.
2459
2460 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         Sanitize URL in pasteboard for other applications and cross origin content
2463         https://bugs.webkit.org/show_bug.cgi?id=178060
2464         <rdar://problem/34874518>
2465
2466         Reviewed by Wenson Hsieh.
2467
2468         * WebCoreSupport/WebPlatformStrategies.h:
2469         * WebCoreSupport/WebPlatformStrategies.mm:
2470         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2471
2472 2017-10-11  Chris Dumez  <cdumez@apple.com>
2473
2474         Modernize Geolocation code
2475         https://bugs.webkit.org/show_bug.cgi?id=178148
2476
2477         Reviewed by Ryosuke Niwa.
2478
2479         * WebCoreSupport/WebGeolocationClient.h:
2480         * WebCoreSupport/WebGeolocationClient.mm:
2481         (WebGeolocationClient::lastPosition):
2482         * WebView/WebGeolocationPosition.mm:
2483         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2484         (core):
2485         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2486         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2487         * WebView/WebGeolocationPositionInternal.h:
2488
2489 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2490
2491         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2492         https://bugs.webkit.org/show_bug.cgi?id=178154
2493
2494         Reviewed by Wenson Hsieh.
2495
2496         Enable custom pasteboard data by default.
2497
2498         * WebView/WebPreferenceKeysPrivate.h:
2499         * WebView/WebPreferences.mm:
2500         (+[WebPreferences initialize]):
2501         (-[WebPreferences customPasteboardDataEnabled]): Added.
2502         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2503         * WebView/WebPreferencesPrivate.h:
2504         * WebView/WebView.mm:
2505         (-[WebView _preferencesChanged:]):
2506
2507 2017-10-10  Sam Weinig  <sam@webkit.org>
2508
2509         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2510         https://bugs.webkit.org/show_bug.cgi?id=178102
2511
2512         Reviewed by Tim Horton.
2513
2514         * History/WebHistory.mm:
2515         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2516         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2517         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2518         * WebCoreSupport/WebUserMediaClient.mm:
2519         (WebUserMediaClient::pageDestroyed):
2520
2521 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2522
2523         Make the names of the options consistent
2524         https://bugs.webkit.org/show_bug.cgi?id=177933
2525
2526         Reviewed by Saam Barati.
2527
2528         * WebView/WebFrame.h:
2529         * WebView/WebHTMLView.mm:
2530         (-[WebHTMLView setMarkedText:selectedRange:]):
2531         * WebView/WebView.h:
2532
2533 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         [iOS] Tweak support for classifying form controls (followup to r222487)
2536         https://bugs.webkit.org/show_bug.cgi?id=177917
2537         <rdar://problem/34820122>
2538
2539         Reviewed by Dean Jackson.
2540
2541         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2542
2543         * DOM/DOMHTMLInputElement.mm:
2544         (-[DOMHTMLInputElement _autofillContext]):
2545         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2546         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2547
2548 2017-10-05  Keith Miller  <keith_miller@apple.com>
2549
2550         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2551
2552         * Configurations/WebKitLegacy.xcconfig:
2553
2554 2017-10-05  Jer Noble  <jer.noble@apple.com>
2555
2556         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2557         https://bugs.webkit.org/show_bug.cgi?id=177261
2558
2559         Reviewed by Eric Carlson.
2560
2561         * Configurations/FeatureDefines.xcconfig:
2562
2563 2017-10-05  Chris Dumez  <cdumez@apple.com>
2564
2565         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2566         https://bugs.webkit.org/show_bug.cgi?id=177957
2567
2568         Reviewed by Alex Christensen.
2569
2570         * WebCoreSupport/WebPlatformStrategies.h:
2571         * WebCoreSupport/WebPlatformStrategies.mm:
2572         (WebPlatformStrategies::cookiesEnabled):
2573
2574 2017-10-05  Youenn Fablet  <youenn@apple.com>
2575
2576         Make LibWebRTCProvider port agnostic
2577         https://bugs.webkit.org/show_bug.cgi?id=177747
2578
2579         Reviewed by Alex Christensen & Alex Garcia.
2580
2581         * WebView/WebView.mm:
2582         (-[WebView _commonInitializationWithFrameName:groupName:]):
2583         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2584
2585 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2586
2587         Stop linking with WebKitSystemInterface
2588         https://bugs.webkit.org/show_bug.cgi?id=177915
2589
2590         Reviewed by Antti Koivisto.
2591
2592         * Configurations/DebugRelease.xcconfig:
2593         * Configurations/WebKitLegacy.xcconfig:
2594
2595 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2596
2597         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2598         https://bugs.webkit.org/show_bug.cgi?id=177912
2599
2600         Reviewed by Saam Barati.
2601
2602         * Carbon/CarbonUtils.m:
2603         * Carbon/CarbonWindowAdapter.mm:
2604         * Carbon/HIWebView.mm:
2605         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2606         * Misc/WebNSFileManagerExtras.mm:
2607         * Misc/WebNSPasteboardExtras.mm:
2608         * Misc/WebNSURLExtras.mm:
2609         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2610         * Plugins/Hosted/NetscapePluginHostManager.mm:
2611         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2612         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2613         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2614         * Plugins/Hosted/WebTextInputWindowController.m:
2615         * Plugins/WebBaseNetscapePluginView.mm:
2616         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2617         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2618         * Plugins/WebNetscapePluginStream.mm:
2619         * Plugins/WebNetscapePluginView.mm:
2620         * Plugins/WebPluginDatabase.mm:
2621         * WebCoreSupport/PopupMenuMac.mm:
2622         * WebCoreSupport/WebChromeClient.mm:
2623         * WebCoreSupport/WebFrameLoaderClient.mm:
2624         * WebCoreSupport/WebInspectorClient.mm:
2625         * WebCoreSupport/WebPlatformStrategies.mm:
2626         * WebCoreSupport/WebSystemInterface.mm:
2627         * WebView/WebDynamicScrollBarsView.mm:
2628         * WebView/WebFrame.mm:
2629         * WebView/WebFrameView.mm:
2630         * WebView/WebFullScreenController.mm:
2631         * WebView/WebHTMLView.mm:
2632         * WebView/WebPreferences.mm:
2633         * WebView/WebView.mm:
2634
2635 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2636
2637         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2638         rdar://problem/34705779
2639
2640         Addressing review comments that I somehow landed without.
2641
2642         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2643
2644 2017-09-29  Chris Dumez  <cdumez@apple.com>
2645
2646         Split some logic out of VisitedLinkStore and make it reusable
2647         https://bugs.webkit.org/show_bug.cgi?id=177575
2648
2649         Reviewed by Alex Christensen.
2650
2651         * WebCoreSupport/WebVisitedLinkStore.h:
2652         * WebCoreSupport/WebVisitedLinkStore.mm:
2653         (WebVisitedLinkStore::addVisitedLink):
2654         (WebVisitedLinkStore::removeVisitedLink):
2655         (WebVisitedLinkStore::isLinkVisited):
2656         (WebVisitedLinkStore::addVisitedLinkHash):
2657
2658 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2659
2660         Build fix for High Sierra 32 bit Mac
2661         https://bugs.webkit.org/show_bug.cgi?id=177551
2662         <rdar://problem/34690283>
2663
2664         Reviewed by Alexey Proskuryakov.
2665
2666         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2667         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2668         also made.
2669
2670         * Carbon/CarbonWindowAdapter.mm:
2671         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2672         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2673         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2674         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2675         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2676         (-[CarbonWindowAdapter dealloc]):
2677         (-[CarbonWindowAdapter windowRef]):
2678         (-[CarbonWindowAdapter _hasWindowRef]):
2679         (-[CarbonWindowAdapter _managesWindowRef]):
2680         (-[CarbonWindowAdapter _removeWindowRef]):
2681         (-[CarbonWindowAdapter _carbonWindowClass]):
2682         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2683         (-[CarbonWindowAdapter sendSuperEvent:]):
2684         (-[CarbonWindowAdapter relinquishFocus]):
2685         (-[CarbonWindowAdapter _cancelKey:]):
2686         (-[CarbonWindowAdapter _commonAwake]):
2687         (-[CarbonWindowAdapter _destroyRealWindow:]):
2688         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2689         (-[CarbonWindowAdapter _termWindowIfOwner]):
2690         (-[CarbonWindowAdapter _windowMovedToRect:]):
2691         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2692         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2693         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2694         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2695         (-[CarbonWindowAdapter canBecomeMainWindow]):
2696         (-[CarbonWindowAdapter encodeWithCoder:]):
2697         (-[CarbonWindowAdapter initWithCoder:]):
2698         (-[CarbonWindowAdapter setContentView:]):
2699         (-[CarbonWindowAdapter worksWhenModal]):
2700         (-[CarbonWindowAdapter _setModalWindowLevel]):
2701         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2702         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2703         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2704         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2705         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2706         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2707         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2708         (NSCarbonWindowHandleEvent):
2709         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2710         (-[CarbonWindowAdapter _growBoxRect]):
2711         * Carbon/HIWebView.mm:
2712         (HIWebViewGetWebView):
2713         (HIWebViewConstructor):
2714         (HIWebViewDestructor):
2715         (HIWebViewRegisterClass):
2716         (GetBehaviors):
2717         (Draw):
2718         (HitTest):
2719         (GetRegion):
2720         (GetWindowRef):
2721         (CreateNSEventAdoptingCGEvent):
2722         (CopyEventCGEvent):
2723         (CreateNSEventWithCarbonClickEvent):
2724         (Click):
2725         (CreateNSEventWithCarbonEvent):
2726         (MouseUp):
2727         (CreateNSEventWithCarbonMouseMoveEvent):
2728         (MouseMoved):
2729         (MouseDragged):
2730         (MouseWheelMoved):
2731         (ContextMenuClick):
2732         (GetKind):
2733         (BoundsChanged):
2734         (OwningWindowChanged):
2735         (WindowHandler):
2736         (SyncFrame):
2737         (SetFocusPart):
2738         (AdvanceFocus):
2739         (RelinquishFocus):
2740         (ActiveStateChanged):
2741         (ProcessCommand):
2742         (UpdateCommandStatus):
2743         (_NSSelectorForHICommand):
2744         (HIWebViewEventHandler):
2745         (StartUpdateObserver):
2746         (StopUpdateObserver):
2747         (UpdateObserver):
2748
2749 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2750
2751         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2752         https://bugs.webkit.org/show_bug.cgi?id=172526
2753         <rdar://problem/32396081>
2754
2755         Reviewed by Ryosuke Niwa.
2756
2757         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2758
2759         * WebCoreSupport/WebPlatformStrategies.h:
2760         * WebCoreSupport/WebPlatformStrategies.mm:
2761         (WebPlatformStrategies::webExposedTypes):
2762         (WebPlatformStrategies::writeCustomData):
2763
2764 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2765
2766         Unreviewed, rolling out r222567.
2767
2768         This broke and internal build.
2769
2770         Reverted changeset:
2771
2772         "Build fix for High Sierra 32 bit Mac"
2773         https://bugs.webkit.org/show_bug.cgi?id=177551
2774         http://trac.webkit.org/changeset/222567
2775
2776 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2777
2778         Build fix for High Sierra 32 bit Mac
2779         https://bugs.webkit.org/show_bug.cgi?id=177551
2780         <rdar://problem/34690283>
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2785         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2786         also made.
2787
2788         * Carbon/CarbonWindowAdapter.mm:
2789         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2790         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2791         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2792         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2793         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2794         (-[CarbonWindowAdapter dealloc]):
2795         (-[CarbonWindowAdapter windowRef]):
2796         (-[CarbonWindowAdapter _hasWindowRef]):
2797         (-[CarbonWindowAdapter _managesWindowRef]):
2798         (-[CarbonWindowAdapter _removeWindowRef]):
2799         (-[CarbonWindowAdapter _carbonWindowClass]):
2800         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2801         (-[CarbonWindowAdapter sendSuperEvent:]):
2802         (-[CarbonWindowAdapter relinquishFocus]):
2803         (-[CarbonWindowAdapter _cancelKey:]):
2804         (-[CarbonWindowAdapter _commonAwake]):
2805         (-[CarbonWindowAdapter _destroyRealWindow:]):
2806         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2807         (-[CarbonWindowAdapter _termWindowIfOwner]):
2808         (-[CarbonWindowAdapter _windowMovedToRect:]):
2809         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2810         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2811         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2812         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2813         (-[CarbonWindowAdapter canBecomeMainWindow]):
2814         (-[CarbonWindowAdapter encodeWithCoder:]):
2815         (-[CarbonWindowAdapter initWithCoder:]):
2816         (-[CarbonWindowAdapter setContentView:]):
2817         (-[CarbonWindowAdapter worksWhenModal]):
2818         (-[CarbonWindowAdapter _setModalWindowLevel]):
2819         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2820         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2821         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2822         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2823         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2824         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2825         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2826         (NSCarbonWindowHandleEvent):
2827         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2828         (-[CarbonWindowAdapter _growBoxRect]):
2829         * Carbon/HIWebView.mm:
2830         (HIWebViewGetWebView):
2831         (HIWebViewConstructor):
2832         (HIWebViewDestructor):
2833         (HIWebViewRegisterClass):
2834         (GetBehaviors):
2835         (Draw):
2836         (HitTest):
2837         (GetRegion):
2838         (GetWindowRef):
2839         (CreateNSEventAdoptingCGEvent):
2840         (CopyEventCGEvent):
2841         (CreateNSEventWithCarbonClickEvent):
2842         (Click):
2843         (CreateNSEventWithCarbonEvent):
2844         (MouseUp):
2845         (CreateNSEventWithCarbonMouseMoveEvent):
2846         (MouseMoved):
2847         (MouseDragged):
2848         (MouseWheelMoved):
2849         (ContextMenuClick):
2850         (GetKind):
2851         (BoundsChanged):
2852         (OwningWindowChanged):
2853         (WindowHandler):
2854         (SyncFrame):
2855         (SetFocusPart):
2856         (AdvanceFocus):
2857         (RelinquishFocus):
2858         (ActiveStateChanged):
2859         (ProcessCommand):
2860         (UpdateCommandStatus):
2861         (_NSSelectorForHICommand):
2862         (HIWebViewEventHandler):
2863         (StartUpdateObserver):
2864         (StopUpdateObserver):
2865         (UpdateObserver):
2866
2867 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2868
2869         Make PolicyAction an encodable enum class
2870         https://bugs.webkit.org/show_bug.cgi?id=177480
2871
2872         Reviewed by Antti Koivisto.
2873
2874         * Plugins/WebPluginContainerCheck.mm:
2875         (-[WebPluginContainerCheck _continueWithPolicy:]):
2876         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2877         * WebCoreSupport/WebFrameLoaderClient.mm:
2878         (-[WebFramePolicyListener invalidate]):
2879         (-[WebFramePolicyListener ignore]):
2880         (-[WebFramePolicyListener download]):
2881         (-[WebFramePolicyListener use]):
2882         (-[WebFramePolicyListener continue]):
2883         * WebView/WebPolicyDelegate.mm:
2884         (-[WebPolicyDecisionListener use]):
2885         (-[WebPolicyDecisionListener ignore]):
2886         (-[WebPolicyDecisionListener download]):
2887
2888 2017-09-25  Frederik Riedel  <riedel@apple.com>
2889
2890         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2891         https://bugs.webkit.org/show_bug.cgi?id=174394
2892         <rdar://problem/33183504>
2893
2894         Reviewed by Ryosuke Niwa.
2895
2896         * DOM/DOMHTMLInputElement.h:
2897         * DOM/DOMHTMLInputElement.mm:
2898         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2899         Determines if this HTMLInputElement is part of a login screen.
2900         (-[DOMHTMLInputElement representingPageUrl]):
2901         Returns the webpage's URL that is currently displayed in the Web View.
2902         (-[DOMHTMLInputElement insertTextSuggestion:]):
2903         Inserts login credentials into the Web View.
2904
2905 2017-09-25  Sam Weinig  <sam@webkit.org>
2906
2907         Remove unused EditorClient functions
2908         https://bugs.webkit.org/show_bug.cgi?id=177463
2909
2910         Reviewed by Alex Christensen.
2911
2912         Remove unused EditorClient functions.
2913
2914         * WebCoreSupport/WebEditorClient.h:
2915         * WebCoreSupport/WebEditorClient.mm:
2916         (WebEditorClient::canonicalizeURL): Deleted.
2917         (WebEditorClient::canonicalizeURLString): Deleted.
2918         (WebEditorClient::writeDataToPasteboard): Deleted.
2919         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2920         (WebEditorClient::readDataFromPasteboard): Deleted.
2921         (WebEditorClient::pasteboardChangeCount): Deleted.
2922
2923 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2924
2925         Stop using PolicyCallback
2926         https://bugs.webkit.org/show_bug.cgi?id=176088
2927
2928         Reviewed by Andy Estes.
2929
2930         * WebCoreSupport/WebFrameLoaderClient.mm:
2931         (-[WebFramePolicyListener invalidate]):
2932         (-[WebFramePolicyListener receivedPolicyDecision:]):
2933
2934 2017-09-25  Sam Weinig  <sam@webkit.org>
2935
2936         Remove unnecessary userVisibleString EditorClient function
2937         https://bugs.webkit.org/show_bug.cgi?id=177456
2938
2939         Reviewed by Dan Bernstein.
2940
2941         * WebCoreSupport/WebEditorClient.h:
2942         * WebCoreSupport/WebEditorClient.mm:
2943         (WebEditorClient::userVisibleString): Deleted.
2944
2945             Remove userVisibleString client function.
2946
2947 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2948
2949         Separate form submission from PolicyChecker infrastructure
2950         https://bugs.webkit.org/show_bug.cgi?id=177396
2951
2952         Reviewed by Geoffrey Garen.
2953
2954         * WebCoreSupport/WebFrameLoaderClient.h:
2955         * WebCoreSupport/WebFrameLoaderClient.mm:
2956         (WebFrameLoaderClient::dispatchWillSubmitForm):
2957
2958 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2959
2960         WeakPtrFactory should populate m_ref lazily.
2961         https://bugs.webkit.org/show_bug.cgi?id=177375
2962
2963         Reviewed by Geoffrey Garen.
2964
2965         * WebCoreSupport/WebEditorClient.mm:
2966         (WebEditorClient::WebEditorClient):
2967         (WebEditorClient::requestCandidatesForSelection):
2968
2969 2017-09-22  Chris Dumez  <cdumez@apple.com>
2970
2971         Use high resolution timestamp for event time
2972         https://bugs.webkit.org/show_bug.cgi?id=154246
2973         <rdar://problem/34333304>
2974
2975         Reviewed by Ryosuke Niwa.
2976
2977         Use WallTime / MonotonicTime instead of double type for clarity.
2978
2979         * DOM/DOMEvent.mm:
2980         (-[DOMEvent timeStamp]):
2981         * WebView/WebFrame.mm:
2982         (-[WebFrame _dragSourceEndedAt:operation:]):
2983         * WebView/WebPDFView.mm:
2984         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2985
2986 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         Enable dataTransfer.items on macOS and iOS
2989         https://bugs.webkit.org/show_bug.cgi?id=177335
2990
2991         Reviewed by Sam Weinig.
2992
2993         * WebView/WebPreferences.mm:
2994         (+[WebPreferences initialize]):
2995
2996 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2997
2998         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2999         https://bugs.webkit.org/show_bug.cgi?id=177101
3000         <rdar://problem/34500648>
3001
3002         Reviewed by Brian Burg.
3003
3004         * WebInspector/WebNodeHighlight.mm:
3005         Ensure we close the window that we have just removed.
3006
3007 2017-09-20  Antti Koivisto  <antti@apple.com>
3008
3009         Remove DOM and styling support for CSS Regions
3010         https://bugs.webkit.org/show_bug.cgi?id=177221
3011
3012         Reviewed by Andreas Kling.
3013
3014         * Configurations/FeatureDefines.xcconfig:
3015         * DOM/DOMCSS.mm:
3016         (kitClass):
3017         * DOM/DOMElement.mm:
3018         (-[DOMElement webkitRegionOverset]): Deleted.
3019
3020 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3021
3022         Layering violation in Editor::createFragment
3023         https://bugs.webkit.org/show_bug.cgi?id=176123
3024
3025         Reviewed by Darin Adler.
3026
3027         * Misc/WebNSURLExtras.h:
3028         * Misc/WebNSURLExtras.mm:
3029         * WebView/WebFrame.mm:
3030         * WebView/WebHTMLView.mm:
3031         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3032
3033         * WebCoreSupport/WebEditorClient.mm:
3034         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3035         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3036         way to avoid exporting the symbol just on newer OSes.
3037
3038 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3039
3040         On iOS, getData can't get text set by setData during copy event
3041         https://bugs.webkit.org/show_bug.cgi?id=176980
3042         <rdar://problem/34453915>
3043
3044         Reviewed by Darin Adler.
3045
3046         * WebCoreSupport/WebPlatformStrategies.h:
3047         * WebCoreSupport/WebPlatformStrategies.mm:
3048         (WebPlatformStrategies::copy): Deleted.
3049
3050 2017-09-18  Andy Estes  <aestes@apple.com>
3051
3052         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3053         https://bugs.webkit.org/show_bug.cgi?id=177029
3054
3055         Reviewed by Alex Christensen.
3056
3057         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3058         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3059         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3060         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3061         * WebCoreSupport/PopupMenuMac.mm:
3062         (PopupMenuMac::show):
3063         * WebCoreSupport/WebSystemInterface.mm:
3064         (InitWebCoreSystemInterface):
3065         * WebView/WebHTMLView.mm:
3066         (-[WebHTMLView setDataSource:]):
3067         (-[WebHTMLView attachRootLayer:]):
3068         * WebView/WebView.mm:
3069         (-[WebView _needsAdobeFrameReloadingQuirk]):
3070         (-[WebView _needsLinkElementTextCSSQuirk]):
3071         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3072         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3073         (-[WebView _preferencesChanged:]):
3074
3075 2017-09-15  Andy Estes  <aestes@apple.com>
3076
3077         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3078         https://bugs.webkit.org/show_bug.cgi?id=176953
3079
3080         Reviewed by Eric Carlson.
3081
3082         * WebCoreSupport/WebSystemInterface.mm:
3083         (InitWebCoreSystemInterface):
3084
3085 2017-09-14  Andy Estes  <aestes@apple.com>
3086
3087         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3088         https://bugs.webkit.org/show_bug.cgi?id=176931
3089
3090         Reviewed by Joseph Pecoraro.
3091
3092         * WebCoreSupport/WebSystemInterface.mm:
3093         (InitWebCoreSystemInterface):
3094
3095 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3096
3097         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3098         https://bugs.webkit.org/show_bug.cgi?id=176867
3099
3100         Reviewed by Sam Weinig.
3101
3102         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3103         (WebKit::NetscapePluginInstanceProxy::enumerate):
3104
3105 2017-09-13  Andy Estes  <aestes@apple.com>
3106
3107         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3108         https://bugs.webkit.org/show_bug.cgi?id=176729
3109
3110         Reviewed by Alex Christensen.
3111
3112         * WebCoreSupport/WebSystemInterface.mm:
3113         (InitWebCoreSystemInterface):
3114         * WebView/WebView.mm:
3115         (+[WebView _setCacheModel:]):
3116
3117 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3118
3119         Refactor WebContentReader out of EditorMac and EditorIOS
3120         https://bugs.webkit.org/show_bug.cgi?id=176770
3121
3122         Reviewed by Sam Weinig.
3123
3124         * WebCoreSupport/WebEditorClient.mm:
3125
3126 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3127
3128         Dragging & dropping a file creates an attachment element even when it's disabled
3129         https://bugs.webkit.org/show_bug.cgi?id=176769
3130
3131         Reviewed by Tim Horton.
3132
3133         * WebView/WebView.mm:
3134         (-[WebView _preferencesChanged:]):
3135
3136 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3137
3138         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3139         https://bugs.webkit.org/show_bug.cgi?id=176721
3140         <rdar://problem/34373660>
3141
3142         Reviewed by Tim Horton.
3143
3144         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3145         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3146
3147         * WebView/WebView.mm:
3148         (-[WebView _startDrag:]):
3149         (-[WebView _draggedElementBounds]):
3150         (-[WebView _endedDataInteraction:global:]):
3151         * WebView/WebViewData.h:
3152
3153 2017-09-11  Andy Estes  <aestes@apple.com>
3154
3155         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3156         https://bugs.webkit.org/show_bug.cgi?id=176472
3157
3158         Reviewed by Eric Carlson.
3159
3160         * WebCoreSupport/WebSystemInterface.mm:
3161         (InitWebCoreSystemInterface):
3162
3163 2017-09-09  Mark Lam  <mark.lam@apple.com>
3164
3165         Avoid duplicate computations of ExecState::vm().
3166         https://bugs.webkit.org/show_bug.cgi?id=176647
3167
3168         Reviewed by Saam Barati.
3169
3170         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3171         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3172         (WebKit::NetscapePluginInstanceProxy::construct):
3173         (WebKit::NetscapePluginInstanceProxy::setProperty):
3174         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3175         (WebKit::NetscapePluginInstanceProxy::enumerate):
3176         * Plugins/Hosted/ProxyInstance.mm:
3177         (WebKit::ProxyRuntimeMethod::create):
3178
3179 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3180
3181         Unreviewed, rolling out r221773.
3182         https://bugs.webkit.org/show_bug.cgi?id=176614
3183
3184         This caused build failures. (Requested by mlewis13 on
3185         #webkit).
3186
3187         Reverted changeset:
3188
3189         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3190         https://bugs.webkit.org/show_bug.cgi?id=176472
3191         http://trac.webkit.org/changeset/221773
3192
3193 2017-09-07  Andy Estes  <aestes@apple.com>
3194
3195         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3196         https://bugs.webkit.org/show_bug.cgi?id=176472
3197
3198         Reviewed by Eric Carlson.
3199
3200         * WebCoreSupport/WebSystemInterface.mm:
3201         (InitWebCoreSystemInterface):
3202
3203 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3204
3205         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3206         https://bugs.webkit.org/show_bug.cgi?id=176561
3207
3208         Reviewed by Brent Fulgham.
3209
3210         * Misc/WebNSUserDefaultsExtras.mm:
3211
3212 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3213
3214         Modernize Geolocation code
3215         https://bugs.webkit.org/show_bug.cgi?id=176496
3216
3217         Reviewed by Andy Estes.
3218
3219         * WebCoreSupport/WebGeolocationClient.h:
3220         * WebCoreSupport/WebGeolocationClient.mm:
3221         (WebGeolocationClient::requestPermission):
3222         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3223         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3224         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3225         * WebView/WebView.mm:
3226         (-[WebView _commonInitializationWithFrameName:groupName:]):
3227         (-[WebView _geolocationDidFailWithMessage:]):
3228
3229 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3230
3231         Remove some unused bits of code and resources
3232         https://bugs.webkit.org/show_bug.cgi?id=176275
3233
3234         Reviewed by Dan Bernstein.
3235
3236         * Misc/WebNSFileManagerExtras.mm:
3237         Include FileSystem instead of FileSystemIOS.
3238
3239 2017-09-03  Darin Adler  <darin@apple.com>
3240
3241         [Cocoa] Tidy a few things in legacy WebHTMLView
3242         https://bugs.webkit.org/show_bug.cgi?id=176280
3243
3244         Reviewed by Dan Bernstein.
3245
3246         * WebCoreSupport/WebChromeClient.mm:
3247         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3248         methods it calls on WebHTMLView were doing nothing on iOS.
3249
3250         * WebView/WebFrame.mm:
3251         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3252         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3253
3254         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3255         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3256         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3257         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3258         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3259         Use RetainPtr instead of writing retain/release wherever possible.
3260         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3261         initialization for it. Removed various unused methods and declarations of methods.
3262         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3263         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3264         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3265         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3266         and remove CFRetain no longer needed since we don't support garbage collection any more.
3267         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3268         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3269         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3270         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3271         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3272         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3273         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3274         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3275         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3276         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3277         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3278         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3279         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3280         debug flag; we haven't used it for years and it's not clearly helpful.
3281         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3282         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3283         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3284         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3285         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3286         two additional methods in the WebPrivate category and still be called by the two
3287         methods in the WebInternal category that were already using it.
3288         (-[WebHTMLView didAddSubview:]): Deleted.
3289         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3290         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3291         place this was called, the close method.
3292         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3293         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3294         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3295         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3296         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3297         Added helper method to make the one below simpler.
3298         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3299         Compared pasteboard type strings using isEqualToString: rather than using == since
3300         we want to actually compare the string contents. Also updated to use modern for loop,
3301         renamed a local variable from "s" to "localSubresources", and factored out the handling
3302         of three image types to use the helper method above.
3303         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3304         _web_makePluginSubviewsPerformSelector:withObject: method.
3305         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3306         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3307         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3308         not call the -[NSView subviews] method to make this identical on both platforms and used
3309         a modern for loop.
3310         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3311         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3312         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3313         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3314         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3315         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3316         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3317         of it is Mac-only.
3318         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3319         method did was call itself on the main thread, and do nothing if called on main thread.
3320         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3321         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3322         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3323         half of this method.
3324         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3325         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3326         Simplified using a modern for loop and RetainPtr.
3327         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3328         (-[WebHTMLView keyDown:]): Ditto.
3329         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3330         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3331         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3332         (-[WebHTMLView complete:]): Ditto.
3333         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3334         now macOS-only.
3335         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3336         iOS since that is now macOS-only.
3337         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3338         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3339         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3340         and reorganized to use early return.
3341         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3342         on iOS, but kept there so we don't have to do #if at every call site.
3343         (-[WebHTMLView _pluginController]): Moved into internal category.
3344         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3345         there only for GC, using C++ initialization, removing obsolete comment.
3346         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3347         peculiar iOS-only comment.
3348         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3349
3350         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3351         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3352         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3353         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3354         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3355
3356         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3357         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3358         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3359         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3360         them at this time.
3361
3362 2017-09-03  Sam Weinig  <sam@webkit.org>
3363
3364         Remove CanvasProxy
3365         https://bugs.webkit.org/show_bug.cgi?id=176288
3366
3367         Reviewed by Yusuke Suzuki.
3368
3369         CanvasProxy does not appear to be in any current HTML spec
3370         and was disabled and unimplemented in our tree. Time to 
3371         get rid of it.
3372
3373         * Configurations/FeatureDefines.xcconfig:
3374
3375 2017-09-02  Andy Estes  <aestes@apple.com>
3376
3377         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3378         https://bugs.webkit.org/show_bug.cgi?id=176270
3379
3380         Reviewed by Tim Horton.
3381
3382         * Plugins/Hosted/NetscapePluginHostManager.mm:
3383         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3384         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3385         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3386         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3387         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3388         (WebKit::SoftwareCARenderer::context const):
3389         (WebKit::SoftwareCARenderer::renderContext const):
3390         (WebKit::SoftwareCARenderer::render):
3391         (-[WebHostedNetscapePluginView createPlugin]):
3392         (-[WebHostedNetscapePluginView createPluginLayer]):
3393         (-[WebHostedNetscapePluginView destroyPlugin]):
3394         (-[WebHostedNetscapePluginView drawRect:]):
3395         * WebCoreSupport/WebSystemInterface.mm:
3396         (InitWebCoreSystemInterface):
3397
3398 2017-09-01  Andy Estes  <aestes@apple.com>
3399
3400         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3401         https://bugs.webkit.org/show_bug.cgi?id=176200
3402
3403         Reviewed by Tim Horton.
3404
3405         * Carbon/HIWebView.mm:
3406         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3407         (overrideCGContext):
3408         (restoreCGContext):
3409         (Draw):
3410         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3411         (+[WebHostedNetscapePluginView initialize]):
3412         * Plugins/WebBaseNetscapePluginView.h:
3413         * Plugins/WebBaseNetscapePluginView.mm:
3414         (WebKit::sendUserChangeNotifications):
3415         * Plugins/WebNetscapePluginView.mm:
3416         (+[WebNetscapePluginView initialize]):
3417         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3418         * WebCoreSupport/WebSystemInterface.mm:
3419         (InitWebCoreSystemInterface):
3420         * WebView/WebFrame.mm:
3421         (-[WebFrame _paintBehaviorForDestinationContext:]):
3422         * WebView/WebFullScreenController.mm:
3423         (setClipRectForWindow):
3424         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3425         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3426         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3427         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3428
3429 2017-08-31  Andy Estes  <aestes@apple.com>
3430
3431         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3432         https://bugs.webkit.org/show_bug.cgi?id=176175
3433
3434         Reviewed by Brady Eidson.
3435
3436         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3437         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3438         * Plugins/Hosted/WebTextInputWindowController.m:
3439         (-[WebTextInputPanel init]):
3440         * WebCoreSupport/WebSystemInterface.mm:
3441         (InitWebCoreSystemInterface):
3442         * WebView/WebDynamicScrollBarsView.mm:
3443         (-[WebDynamicScrollBarsView scrollWheel:]):
3444         * WebView/WebHTMLView.mm:
3445         (-[WebHTMLView _removeWindowObservers]):
3446         (-[WebHTMLView addWindowObservers]):
3447         * WebView/WebView.mm:
3448         (-[WebView addWindowObserversForWindow:]):
3449         (-[WebView removeWindowObservers]):
3450         (-[WebView viewWillMoveToWindow:]):
3451
3452 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3453
3454         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3455         https://bugs.webkit.org/show_bug.cgi?id=175779
3456         <rdar://problem/22367975>
3457
3458         Reviewed by Tim Horton.
3459
3460         * WebCoreSupport/WebFrameLoaderClient.h:
3461         * WebCoreSupport/WebFrameLoaderClient.mm:
3462         (WebFrameLoaderClient::webGLPolicyForURL const):
3463         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3464
3465 2017-08-30  Andy Estes  <aestes@apple.com>
3466
3467         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3468         https://bugs.webkit.org/show_bug.cgi?id=176093
3469
3470         Reviewed by Eric Carlson.
3471
3472         * WebCoreSupport/WebSystemInterface.mm:
3473         (InitWebCoreSystemInterface):
3474
3475 2017-08-30  Andy Estes  <aestes@apple.com>
3476
3477         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3478         https://bugs.webkit.org/show_bug.cgi?id=176087
3479
3480         Reviewed by Alex Christensen.
3481
3482         * Carbon/CarbonUtils.m:
3483         (getNSAutoreleasePoolCount):
3484         (WebInitForCarbon):
3485         (PoolCleaner):
3486         * Carbon/CarbonWindowAdapter.mm:
3487         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3488         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3489         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3490         (-[CarbonWindowAdapter _windowMovedToRect:]):
3491         * Carbon/HIViewAdapter.m:
3492         * Carbon/HIWebView.mm:
3493         (Draw):
3494         (CreateNSEventAdoptingCGEvent):
3495         (CopyEventCGEvent):
3496         (CreateNSEventWithCarbonClickEvent):
3497         (Click):
3498         (CreateNSEventWithCarbonEvent):
3499         (MouseUp):
3500         (CreateNSEventWithCarbonMouseMoveEvent):
3501         (MouseMoved):
3502         (MouseDragged):
3503         (MouseWheelMoved):
3504         (WindowHandler):
3505         (HIWebViewEventHandler):
3506         * Misc/QuickDrawCompatibility.h: Removed.
3507         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3508         (getCarbonEvent):
3509         (WebNetscapePluginEventHandlerCarbon::keyDown):
3510         (WebNetscapePluginEventHandlerCarbon::keyUp):
3511         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3512         (WebNetscapePluginEventHandlerCocoa::keyDown):
3513         * Plugins/WebNetscapePluginView.mm:
3514         (-[WebNetscapePluginView tellQuickTimeToChill]):
3515
3516 2017-08-29  Andy Estes  <aestes@apple.com>
3517
3518         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3519         https://bugs.webkit.org/show_bug.cgi?id=176046
3520
3521         Reviewed by Alex Christensen.
3522
3523         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3524         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3525
3526         * Misc/WebNSFileManagerExtras.mm:
3527         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3528         (setMetaData): Deleted.
3529         * WebCoreSupport/WebSystemInterface.mm:
3530         (InitWebCoreSystemInterface):
3531
3532 2017-08-28  Andy Estes  <aestes@apple.com>
3533
3534         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3535         https://bugs.webkit.org/show_bug.cgi?id=176039
3536
3537         Reviewed by Alex Christensen.
3538
3539         * WebCoreSupport/WebSystemInterface.mm:
3540         (InitWebCoreSystemInterface):
3541         * WebView/WebPreferences.mm:
3542         (+[WebPreferences _systemCFStringEncoding]):
3543
3544 2017-08-28  Andy Estes  <aestes@apple.com>
3545
3546         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3547         https://bugs.webkit.org/show_bug.cgi?id=176032
3548
3549         Reviewed by Alex Christensen.
3550
3551         * WebCoreSupport/WebSystemInterface.mm:
3552         (InitWebCoreSystemInterface):
3553         * WebView/WebView.mm:
3554         (-[WebView _cachedResponseForURL:]):
3555
3556 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3557
3558         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3559         https://bugs.webkit.org/show_bug.cgi?id=175992
3560         <rdar://problem/34086613>
3561
3562         Reviewed by Daniel Bates.
3563
3564         * WebCoreSupport/WebPlatformStrategies.h:
3565         * WebCoreSupport/WebPlatformStrategies.mm:
3566         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3567         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3568         indicating if secure cookies were accessed.
3569
3570 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3571
3572         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3573         https://bugs.webkit.org/show_bug.cgi?id=170955
3574         <rdar://problem/31697653>
3575
3576         Reviewed by Ryosuke Niwa.
3577
3578         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3579         text is being replaced.
3580
3581         * WebView/WebHTMLView.mm:
3582         (-[WebHTMLView insertText:]):
3583
3584 2017-08-24  Chris Dumez  <cdumez@apple.com>
3585
3586         [Directory Upload] Add basic support for input.webkitdirectory
3587         https://bugs.webkit.org/show_bug.cgi?id=175950
3588         <rdar://problem/33951915>
3589
3590         Reviewed by Geoffrey Garen.
3591
3592         Add private API to toggle Directory Upload support on Mac WebKit1.
3593
3594         * WebView/WebPreferenceKeysPrivate.h:
3595         * WebView/WebPreferences.mm:
3596         (+[WebPreferences initialize]):
3597         (-[WebPreferences setDirectoryUploadEnabled:]):
3598         (-[WebPreferences directoryUploadEnabled]):
3599         * WebView/WebPreferencesPrivate.h:
3600         * WebView/WebView.mm:
3601         (-[WebView _preferencesChanged:]):
3602
3603 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3604
3605         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3606         https://bugs.webkit.org/show_bug.cgi?id=175370
3607         <rdar://problem/33799806>
3608
3609         Reviewed by Ryosuke Niwa.
3610
3611         Adjust WebEditorClient for interface changes.
3612
3613         * WebCoreSupport/WebEditorClient.h:
3614
3615 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3616
3617         Remove ChromeClient::scrollbarsModeDidChange
3618         https://bugs.webkit.org/show_bug.cgi?id=175805
3619
3620         Reviewed by Daniel Bates.
3621
3622         * WebCoreSupport/WebChromeClient.h:
3623
3624 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3625
3626         Remove ChromeClient::hasOpenedPopup
3627         https://bugs.webkit.org/show_bug.cgi?id=175804
3628
3629         Reviewed by Sam Weinig.
3630
3631         * WebCoreSupport/WebChromeClient.h:
3632         * WebCoreSupport/WebChromeClient.mm:
3633         (WebChromeClient::hasOpenedPopup const): Deleted.
3634
3635 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3636
3637         Disable access to secure cookies if an HTTPS site loads mixed content
3638         https://bugs.webkit.org/show_bug.cgi?id=157053
3639         <rdar://problem/11290808>
3640
3641         Reviewed by Dan Bates.
3642
3643         * WebCoreSupport/WebPlatformStrategies.h:
3644         * WebCoreSupport/WebPlatformStrategies.mm:
3645         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3646         indicating whether secure cookies should be included in the response.
3647
3648 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3649
3650         [PAL] Move spi/mac directory into PAL
3651         https://bugs.webkit.org/show_bug.cgi?id=175649
3652
3653         Reviewed by Myles C. Maxfield.
3654
3655         * Misc/WebSharingServicePickerController.h:
3656         * WebCoreSupport/WebContextMenuClient.mm:
3657         * WebCoreSupport/WebEditorClient.mm:
3658         * WebCoreSupport/WebSelectionServiceController.mm:
3659         * WebView/WebHTMLView.mm:
3660         * WebView/WebImmediateActionController.h:
3661         * WebView/WebImmediateActionController.mm:
3662         * WebView/WebView.mm:
3663
3664 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3665
3666         [PAL] Relocate SessionID to root
3667         https://bugs.webkit.org/show_bug.cgi?id=175684
3668
3669         Reviewed by Alex Christensen.
3670
3671         * WebCoreSupport/WebFrameNetworkingContext.mm:
3672
3673 2017-08-17  Andreas Kling  <akling@apple.com>
3674
3675         Disable CSS regions at compile time
3676         https://bugs.webkit.org/show_bug.cgi?id=175630
3677
3678         Reviewed by Antti Koivisto.
3679
3680         * Configurations/FeatureDefines.xcconfig:
3681
3682 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3683
3684         [PAL] Move SessionID into PAL
3685         https://bugs.webkit.org/show_bug.cgi?id=174192
3686
3687         Reviewed by Antti Koivisto.
3688
3689         * Misc/WebCache.mm:
3690         (+[WebCache imageForURL:]):
3691         * WebCoreSupport/WebFrameLoaderClient.h:
3692         * WebCoreSupport/WebFrameLoaderClient.mm:
3693         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3694         * WebCoreSupport/WebFrameNetworkingContext.mm:
3695         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3696         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3697         (WebFrameNetworkingContext::storageSession const):
3698         * WebCoreSupport/WebPlatformStrategies.h:
3699         * WebCoreSupport/WebPlatformStrategies.mm:
3700         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3701         * WebKitPrefix.h:
3702
3703 2017-08-16  Andy Estes  <aestes@apple.com>
3704
3705         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3706         https://bugs.webkit.org/show_bug.cgi?id=175648
3707
3708         Reviewed by Tim Horton.
3709
3710         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3711         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3712         (WebPaymentCoordinatorClient::showPaymentUI):
3713
3714 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3715
3716         [PAL] Move spi/ios and spi/win directories into PAL
3717         https://bugs.webkit.org/show_bug.cgi?id=175171
3718
3719         Reviewed by Antti Koivisto.
3720
3721         * WebCoreSupport/WebFrameLoaderClient.mm:
3722         * WebView/WebView.mm:
3723
3724 2017-08-16  Andy Estes  <aestes@apple.com>
3725
3726         [Payment Request] Add an ENABLE flag and an experimental feature preference
3727         https://bugs.webkit.org/show_bug.cgi?id=175622
3728
3729         Reviewed by Tim Horton.
3730
3731         * Configurations/FeatureDefines.xcconfig:
3732
3733 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3734
3735         [PAL] Move Sleep classes into PAL
3736         https://bugs.webkit.org/show_bug.cgi?id=175456
3737
3738         Reviewed by Ryosuke Niwa.
3739
3740         * WebView/WebFullScreenController.h:
3741
3742 2017-08-15  Youenn Fablet  <youenn@apple.com>
3743
3744         [Cache API] Adding generic support for CacheStorage and Cache methods
3745         https://bugs.webkit.org/show_bug.cgi?id=175455
3746
3747         Reviewed by Chris Dumez.
3748
3749         * WebView/WebView.mm:
3750         (-[WebView _commonInitializationWithFrameName:groupName:]):
3751
3752 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3753
3754         Remove Proximity Events and related code
3755         https://bugs.webkit.org/show_bug.cgi?id=175545
3756
3757         Reviewed by Daniel Bates.
3758
3759         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3760         and other related code.
3761
3762         * Configurations/FeatureDefines.xcconfig:
3763
3764 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3765
3766         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3767         https://bugs.webkit.org/show_bug.cgi?id=175504
3768
3769         Reviewed by Sam Weinig.
3770
3771         * Configurations/FeatureDefines.xcconfig:
3772         * DOM/DOMHTMLFormElement.mm:
3773         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3774         * WebCoreSupport/WebFrameLoaderClient.h:
3775
3776 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3777
3778         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3779         https://bugs.webkit.org/show_bug.cgi?id=175557
3780
3781         Reviewed by Jon Lee.
3782
3783         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3784
3785         * Configurations/FeatureDefines.xcconfig:
3786
3787 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3788
3789         Composition underline color is always black
3790         https://bugs.webkit.org/show_bug.cgi?id=174675
3791
3792         Reviewed by Ryosuke Niwa.
3793
3794         * WebView/WebHTMLView.mm:
3795         (extractUnderlines): If NSUnderlineColorAttributeName
3796         is not present use text color for composition underline.
3797         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3798         for composition underline in the plain text case.
3799
3800 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3801
3802         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3803         https://bugs.webkit.org/show_bug.cgi?id=175474
3804         <rdar://problem/33844628>
3805
3806         Reviewed by Wenson Hsieh.
3807
3808         Replaced the build flag by a runtime flag and disabled the feature by default.
3809
3810         * Configurations/FeatureDefines.xcconfig:
3811         * WebView/WebPreferenceKeysPrivate.h:
3812         * WebView/WebPreferences.mm:
3813         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3814         (-[WebPreferences dataTransferItemsEnabled]): Added.
3815         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3816         * WebView/WebPreferencesPrivate.h:
3817         * WebView/WebView.mm:
3818         (-[WebView _preferencesChanged:]):
3819
3820 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3821
3822         Remove ENABLE_GAMEPAD_DEPRECATED
3823         https://bugs.webkit.org/show_bug.cgi?id=175361
3824
3825         Reviewed by Carlos Garcia Campos.
3826
3827         * Configurations/FeatureDefines.xcconfig:
3828
3829 2017-08-09  Chris Dumez  <cdumez@apple.com>
3830
3831         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3832         https://bugs.webkit.org/show_bug.cgi?id=175401
3833
3834         Reviewed by Brady Eidson.
3835
3836         * WebView/WebPreferenceKeysPrivate.h:
3837         * WebView/WebPreferences.mm:
3838         (+[WebPreferences initialize]):
3839         (-[WebPreferences beaconAPIEnabled]): Deleted.
3840         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3841         * WebView/WebPreferencesPrivate.h:
3842         * WebView/WebView.mm:
3843         (-[WebView _preferencesChanged:]):
3844
3845 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3846
3847         [PAL] Move spi/cocoa and spi/cg directories into PAL
3848         https://bugs.webkit.org/show_bug.cgi?id=175175
3849
3850         Reviewed by Myles C. Maxfield.
3851
3852         * History/WebHistory.mm:
3853         * Misc/WebDownload.mm:
3854         * Misc/WebKitNSStringExtras.mm:
3855         * Plugins/Hosted/NetscapePluginHostManager.mm:
3856         * Plugins/WebPluginDatabase.mm:
3857         * WebCoreSupport/WebFrameLoaderClient.mm:
3858         * WebInspector/WebNodeHighlight.mm:
3859         * WebView/WebHTMLView.mm:
3860         * WebView/WebIndicateLayer.mm:
3861         * WebView/WebView.mm:
3862         * WebView/WebViewData.h:
3863
3864 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3865
3866         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3867         https://bugs.webkit.org/show_bug.cgi?id=175392
3868         <rdar://problem/33783207>
3869
3870         Reviewed by Tim Horton and Megan Gardner.
3871
3872         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3873
3874         * Configurations/FeatureDefines.xcconfig:
3875
3876 2017-08-09  Daniel Bates  <dabates@apple.com>
3877
3878         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3879         https://bugs.webkit.org/show_bug.cgi?id=175247
3880         <rdar://problem/33679804>
3881
3882         Reviewed by Brady Eidson.
3883
3884         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3885         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3886         clients that need to make use of this information at this time. If such a needs comes up
3887         then we can expose API/SPI similar to what we do for WebKit.
3888
3889         * WebCoreSupport/WebFrameLoaderClient.h:
3890         * WebCoreSupport/WebFrameLoaderClient.mm:
3891         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3892
3893 2017-08-08  Brady Eidson  <beidson@apple.com>
3894
3895         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3896         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3897
3898         Reviewed by Andy Estes.
3899
3900         * Misc/WebKitVersionChecks.h:
3901         * WebCoreSupport/WebFrameLoaderClient.mm:
3902         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3903           the app is linked against new WebKit with the new behavior.
3904
3905 2017-08-07  Devin Rousso  <drousso@apple.com>
3906
3907         Web Inspector: Preview Canvas path when viewing a recording
3908         https://bugs.webkit.org/show_bug.cgi?id=174967
3909
3910         Reviewed by Brian Burg.
3911
3912         * WebView/WebPreferenceKeysPrivate.h:
3913         * WebView/WebPreferences.mm:
3914         (+[WebPreferences initialize]):
3915         (-[WebPreferences inspectorAdditionsEnabled]):
3916         (-[WebPreferences setInspectorAdditionsEnabled:]):
3917         * WebView/WebPreferencesPrivate.h:
3918         * WebView/WebView.mm:
3919         (-[WebView _preferencesChanged:]):
3920         Add plumbing for new InspectorAdditions runtime flag.
3921
3922 2017-08-07  Brian Burg  <bburg@apple.com>
3923
3924         Remove CANVAS_PATH compilation guard
3925         https://bugs.webkit.org/show_bug.cgi?id=175207
3926
3927         Reviewed by Sam Weinig.
3928
3929         * Configurations/FeatureDefines.xcconfig:
3930
3931 2017-08-04  Youenn Fablet  <youenn@apple.com>
3932
3933         [Cache API] Add Cache and CacheStorage IDL definitions
3934         https://bugs.webkit.org/show_bug.cgi?id=175201
3935
3936         Reviewed by Brady Eidson.
3937
3938         * WebView/WebPreferenceKeysPrivate.h:
3939         * WebView/WebPreferences.mm:
3940         (+[WebPreferences initialize]):
3941         (-[WebPreferences cacheAPIEnabled]):
3942         (-[WebPreferences setCacheAPIEnabled:]):
3943         * WebView/WebPreferencesPrivate.h:
3944         * WebView/WebView.mm:
3945         (-[WebView _preferencesChanged:]):
3946
3947 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3948
3949         Unreviewed, rolling out r220271.
3950
3951         Rolling out due to Layout Test failing on iOS Simulator.
3952
3953         Reverted changeset:
3954
3955         "Remove STREAMS_API compilation guard"
3956         https://bugs.webkit.org/show_bug.cgi?id=175165
3957         http://trac.webkit.org/changeset/220271
3958
3959 2017-08-04  Youenn Fablet  <youenn@apple.com>
3960
3961         Remove STREAMS_API compilation guard
3962         https://bugs.webkit.org/show_bug.cgi?id=175165
3963
3964         Reviewed by Darin Adler.
3965
3966         * Configurations/FeatureDefines.xcconfig:
3967         * WebView/WebPreferences.mm:
3968         (+[WebPreferences initialize]):
3969         * WebView/WebView.mm:
3970         (-[WebView _preferencesChanged:]):
3971
3972 2017-08-03  Brian Burg  <bburg@apple.com>
3973
3974         Remove ENABLE(WEB_SOCKET) guards
3975         https://bugs.webkit.org/show_bug.cgi?id=167044
3976
3977         Reviewed by Joseph Pecoraro.
3978
3979         * Configurations/FeatureDefines.xcconfig:
3980         * WebView/WebPreferencesPrivate.h:
3981
3982 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3983
3984         [PAL] Move spi/cf directory into PAL
3985         https://bugs.webkit.org/show_bug.cgi?id=175057
3986
3987         Reviewed by Antti Koivisto.
3988
3989         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3990         * Plugins/WebNetscapePluginStream.mm:
3991         * WebCoreSupport/WebFrameNetworkingContext.mm:
3992         * WebView/WebPreferences.mm:
3993         * WebView/WebView.mm:
3994
3995 2017-08-03  Youenn Fablet  <youenn@apple.com>
3996
3997         Remove FETCH_API compilation guard
3998         https://bugs.webkit.org/show_bug.cgi?id=175154
3999
4000         Reviewed by Chris Dumez.
4001
4002         * Configurations/FeatureDefines.xcconfig:
4003         * WebView/WebPreferences.mm:
4004         (+[WebPreferences initialize]):
4005         * WebView/WebView.mm:
4006         (-[WebView _preferencesChanged:]):
4007
4008 2017-08-03  Brady Eidson  <beidson@apple.com>
4009
4010         Add SW IDLs and stub out basic functionality.
4011         https://bugs.webkit.org/show_bug.cgi?id=175115
4012
4013         Reviewed by Chris Dumez.
4014
4015         * Configurations/FeatureDefines.xcconfig:
4016
4017 2017-08-02  Sam Weinig  <sam@webkit.org>
4018
4019         [WebIDL] Convert MutationCallback to be a normal generated callback
4020         https://bugs.webkit.org/show_bug.cgi?id=174140
4021
4022         Reviewed by Darin Adler.
4023
4024         * DOM/DOMDocument.mm:
4025         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
4026         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
4027         Pass, now necessary, Document to NativeNodeFilter constructor.
4028
4029 2017-08-01  Chris Dumez  <cdumez@apple.com>
4030
4031         Add initial support for navigator.sendBeacon
4032         https://bugs.webkit.org/show_bug.cgi?id=175007
4033         <rdar://problem/33547728>
4034
4035         Reviewed by Sam Weinig.
4036
4037         Add setting to toggle support for the Beacon API (it is disabled by default).
4038
4039         * WebView/WebPreferenceKeysPrivate.h:
4040         * WebView/WebPreferences.mm:
4041         (+[WebPreferences initialize]):
4042         (-[WebPreferences beaconAPIEnabled]):
4043         (-[WebPreferences setBeaconAPIEnabled:]):
4044         * WebView/WebPreferencesPrivate.h:
4045         * WebView/WebView.mm:
4046         (-[WebView _preferencesChanged:]):
4047
4048 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
4049
4050         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
4051         https://bugs.webkit.org/show_bug.cgi?id=174437
4052
4053         Reviewed by Darin Adler.
4054
4055         Remove redundant Web- prefix from classes in WebKit namespace.
4056
4057         * WebView/WebView.mm:
4058         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
4059         * WebView/WebViewData.h:
4060         * WebView/WebViewData.mm:
4061
4062 2017-07-26  Brian Burg  <bburg@apple.com>
4063
4064         Remove WEB_TIMING feature flag
4065         https://bugs.webkit.org/show_bug.cgi?id=174795
4066
4067         Reviewed by Alex Christensen.
4068
4069         * Configurations/FeatureDefines.xcconfig:
4070
4071 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
4072
4073         Async image decoding for large images should be disabled after the first time a tile is painted
4074         https://bugs.webkit.org/show_bug.cgi?id=174451
4075         <rdar://problem/31246421>
4076
4077         Reviewed by Simon Fraser.
4078
4079         * WebView/WebFrame.mm:
4080         (-[WebFrame _paintBehaviorForDestinationContext:]):
4081         (-[WebFrame _drawRect:contentsOnly:]):
4082         * WebView/WebHTMLView.mm:
4083         (imageFromRect):
4084
4085 2017-07-23  Darin Adler  <darin@apple.com>
4086