Add <meta name="supported-color-schemes"> to control what color schemes the page...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2
3         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
4         https://bugs.webkit.org/show_bug.cgi?id=190526
5         rdar://problem/45230140
6
7         Reviewed by Dean Jackson.
8
9         * WebCoreSupport/WebEditorClient.mm:
10         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
11
12 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
13
14         Implement feature flag and bindings for CSS Painting API
15         https://bugs.webkit.org/show_bug.cgi?id=190237
16
17         Reviewed by Ryosuke Niwa.
18
19         * Configurations/FeatureDefines.xcconfig:
20
21 2018-10-16  Alex Christensen  <achristensen@webkit.org>
22
23         Replace HistoryItem* with HistoryItem& where possible
24         https://bugs.webkit.org/show_bug.cgi?id=190617
25
26         Reviewed by Chris Dumez.
27
28         * History/BackForwardList.h:
29         * History/BackForwardList.mm:
30         (BackForwardList::goToItem):
31         * History/WebBackForwardList.mm:
32         (-[WebBackForwardList goToItem:]):
33         * History/WebHistoryItem.mm:
34         (WKNotifyHistoryItemChanged):
35         * History/WebHistoryItemInternal.h:
36
37 2018-10-16  Alex Christensen  <achristensen@webkit.org>
38
39         Remove unused WebHistoryItem._transientPropertyForKey
40         https://bugs.webkit.org/show_bug.cgi?id=190606
41
42         Reviewed by Chris Dumez.
43
44         * History/WebHistoryItem.mm:
45         * History/WebHistoryItemPrivate.h:
46
47 2018-10-15  Justin Fan  <justin_fan@apple.com>
48
49         Add WebGPU 2018 feature flag and experimental feature flag
50         https://bugs.webkit.org/show_bug.cgi?id=190509
51
52         Reviewed by Dean Jackson.
53
54         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
55         for the 2018 WebGPU prototype.
56
57         * Configurations/FeatureDefines.xcconfig:
58         * WebView/WebPreferenceKeysPrivate.h:
59         * WebView/WebPreferences.mm:
60         (+[WebPreferences initialize]):
61         (-[WebPreferences webGPUEnabled]):
62         (-[WebPreferences setWebGPUEnabled:]):
63         * WebView/WebPreferencesPrivate.h:
64         * WebView/WebView.mm:
65         (-[WebView _preferencesChanged:]):
66
67 2018-10-15  Alex Christensen  <achristensen@webkit.org>
68
69         Fix iOS build after r237157
70
71         * WebView/WebView.mm:
72         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
73
74 2018-10-15  Alex Christensen  <achristensen@webkit.org>
75
76         Modernize BackForwardClient.h
77         https://bugs.webkit.org/show_bug.cgi?id=190610
78
79         Reviewed by Chris Dumez.
80
81         * History/BackForwardList.h:
82         * History/BackForwardList.mm:
83         (BackForwardList::backListCount const):
84         (BackForwardList::forwardListCount const):
85         (BackForwardList::backListCount): Deleted.
86         (BackForwardList::forwardListCount): Deleted.
87         * History/WebBackForwardList.mm:
88         (-[WebBackForwardList init]):
89         * WebCoreSupport/WebFrameLoaderClient.mm:
90         (WebFrameLoaderClient::canCachePage const):
91         * WebView/WebFrameView.mm:
92         (-[WebFrameView keyDown:keyDown:]):
93         * WebView/WebView.mm:
94         (-[WebView _commonInitializationWithFrameName:groupName:]):
95         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
96         (-[WebView _loadBackForwardListFromOtherView:]):
97         (-[WebView initWithCoder:]):
98         (-[WebView encodeWithCoder:]):
99         (-[WebView backForwardList]):
100         (-[WebView setMaintainsBackForwardList:]):
101
102 2018-10-15  Timothy Hatcher  <timothy@apple.com>
103
104         Add support for prefers-color-scheme media query
105         https://bugs.webkit.org/show_bug.cgi?id=190499
106         rdar://problem/45212025
107
108         Reviewed by Dean Jackson.
109
110         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
111
112 2018-10-15  Alex Christensen  <achristensen@webkit.org>
113
114         Remove unused WebView._globalHistoryItem
115         https://bugs.webkit.org/show_bug.cgi?id=190601
116
117         Reviewed by Chris Dumez.
118
119         * WebCoreSupport/WebFrameLoaderClient.h:
120         * WebCoreSupport/WebFrameLoaderClient.mm:
121         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
122         * WebView/WebView.mm:
123         (-[WebView _globalHistoryItem]): Deleted.
124         (-[WebView _setGlobalHistoryItem:]): Deleted.
125         * WebView/WebViewData.h:
126         * WebView/WebViewInternal.h:
127         * WebView/WebViewPrivate.h:
128
129 2018-10-15  Alex Christensen  <achristensen@webkit.org>
130
131         Remove unused parameters from FrameLoaderClient::createFrame
132         https://bugs.webkit.org/show_bug.cgi?id=190587
133
134         Reviewed by Chris Dumez.
135
136         * WebCoreSupport/WebFrameLoaderClient.h:
137         * WebCoreSupport/WebFrameLoaderClient.mm:
138         (WebFrameLoaderClient::createFrame):
139
140 2018-10-15  Alex Christensen  <achristensen@webkit.org>
141
142         Remove unused WebFrame._loadType
143         https://bugs.webkit.org/show_bug.cgi?id=190583
144
145         Reviewed by Chris Dumez.
146
147         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
148
149         * WebView/WebFrame.mm:
150         (toWebFrameLoadType): Deleted.
151         (-[WebFrame _loadType]): Deleted.
152         * WebView/WebFramePrivate.h:
153
154 2018-10-15  Chris Dumez  <cdumez@apple.com>
155
156         Restrict browsing context lookup by name to frames that are related to one another
157         https://bugs.webkit.org/show_bug.cgi?id=190475
158
159         Reviewed by Alex Christensen.
160
161         * WebView/WebFrame.mm:
162         (-[WebFrame findFrameNamed:]):
163
164 2018-10-15  Alex Christensen  <achristensen@webkit.org>
165
166         Remove InjectedBundle processing of back/forward lists
167         https://bugs.webkit.org/show_bug.cgi?id=190459
168
169         Reviewed by Chris Dumez.
170
171         * WebCoreSupport/WebFrameLoaderClient.h:
172         * WebCoreSupport/WebFrameLoaderClient.mm:
173         (WebFrameLoaderClient::shouldGoToHistoryItem const):
174
175 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
176
177         [JSC] Remove Option::useAsyncIterator
178         https://bugs.webkit.org/show_bug.cgi?id=190567
179
180         Reviewed by Saam Barati.
181
182         * Configurations/FeatureDefines.xcconfig:
183
184 2018-10-12  Alex Christensen  <achristensen@webkit.org>
185
186         Allow encoding of small enum classes
187         https://bugs.webkit.org/show_bug.cgi?id=190531
188
189         Reviewed by Tim Horton.
190
191         * WebCoreSupport/WebFrameLoaderClient.mm:
192         (-[WebFramePolicyListener dealloc]):
193
194 2018-10-11  Keith Rollin  <krollin@apple.com>
195
196         CURRENT_ARCH should not be used in Run Script phase.
197         https://bugs.webkit.org/show_bug.cgi?id=190407
198         <rdar://problem/45133556>
199
200         Reviewed by Alexey Proskuryakov.
201
202         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
203         CURRENT_ARCH is not well-defined during this phase (and may even have
204         the value "undefined") since this phase is run just once per build
205         rather than once per supported architecture. Migrate away from
206         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
207         performing an operation for each value, or by picking the first entry
208         in ARCHS and using that as a representative value.
209
210         * Configurations/WebKitLegacy.xcconfig: When generating
211         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
212         macosx platforms.
213
214         * MigrateHeaders.make:
215         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
216         generate one for each architecture in ARCHS.
217
218 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
219
220         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
221         https://bugs.webkit.org/show_bug.cgi?id=190429
222
223         Reviewed by Saam Barati.
224
225         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
226
227         * WebView/WebPDFRepresentation.mm:
228         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
229
230 2018-10-08  Justin Fan  <justin_fan@apple.com>
231
232         WebGPU: Rename old WebGPU prototype to WebMetal
233         https://bugs.webkit.org/show_bug.cgi?id=190325
234         <rdar://problem/44990443>
235
236         Reviewed by Dean Jackson.
237
238         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
239
240         * Configurations/FeatureDefines.xcconfig:
241         * WebView/WebPreferenceKeysPrivate.h:
242         * WebView/WebPreferences.mm:
243         (+[WebPreferences initialize]):
244         (-[WebPreferences webMetalEnabled]):
245         (-[WebPreferences setWebMetalEnabled:]):
246         (-[WebPreferences webGPUEnabled]): Deleted.
247         (-[WebPreferences setWebGPUEnabled:]): Deleted.
248         * WebView/WebPreferencesPrivate.h:
249         * WebView/WebView.mm:
250         (-[WebView _preferencesChanged:]):
251
252 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
253
254         Make <input type=color> a runtime enabled (on-by-default) feature
255         https://bugs.webkit.org/show_bug.cgi?id=189162
256
257         Reviewed by Wenson Hsieh and Tim Horton.
258
259         * Configurations/FeatureDefines.xcconfig:
260
261 2018-10-07  Dan Bernstein  <mitz@apple.com>
262
263         Fixed building with the latest macOS SDK
264
265         * Plugins/WebNetscapePluginPackage.mm:
266         (-[WebNetscapePluginPackage openResourceFile]):
267         (-[WebNetscapePluginPackage closeResourceFile:]):
268
269 2018-10-04  Dan Bernstein  <mitz@apple.com>
270
271         More Carbon build-fixing.
272
273         * Carbon/CarbonWindowAdapter.mm:
274         (-[CarbonWindowAdapter _destroyRealWindow:]):
275         (-[CarbonWindowAdapter _growBoxRect]):
276
277 2018-10-04  Dan Bernstein  <mitz@apple.com>
278
279         Retried to fix 32-bit macOS builds after r236846.
280
281         * WebView/WebHTMLView.mm:
282         (-[WebHTMLView setMarkedText:selectedRange:]):
283
284 2018-10-04  Dan Bernstein  <mitz@apple.com>
285
286         Retried to fix 32-bit macOS builds after r236846.
287
288         * Carbon/HIWebView.mm:
289         (ActiveStateChanged):
290
291 2018-10-04  Dan Bernstein  <mitz@apple.com>
292
293         Tried to fix 32-bit macOS builds after r236846.
294
295         * Carbon/HIWebView.mm:
296         (_NSSelectorForHICommand):
297
298 2018-10-04  Dan Bernstein  <mitz@apple.com>
299
300         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
301         https://bugs.webkit.org/show_bug.cgi?id=190250
302
303         Reviewed by Andy Estes.
304
305         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
306           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
307           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
308           an earlier line set it to YES.
309
310         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
311         changes below.
312
313         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
314           provides some missing method declarations.
315
316         * Misc/WebDownload.mm:
317         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
318           a deprecated method.
319
320         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
321
322         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
323           other code in the file uses a method from it.
324
325         * Plugins/WebBaseNetscapePluginView.mm:
326         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
327           a deprecated method.
328
329         * Plugins/WebPluginController.mm:
330         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
331           around use of a selector that may be present in some WebKit client.
332
333         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
334           method declarations.
335
336         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
337           from here.
338
339         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
340           missing method declarations.
341
342         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
343           from here.
344
345         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
346           call from here.
347         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
348           an obsolete delegate method for binary compatibility.
349         (pluginView): Ditto.
350
351         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
352           call from here.
353
354         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
355           WebDeviceOrientationProviderMock protocol.
356
357         * WebView/WebDeviceOrientationProviderMock.mm:
358         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
359           main @implementation.
360
361         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
362           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
363
364         * WebView/WebDynamicScrollBarsView.mm:
365         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
366           of a deprecated method.
367
368         * WebView/WebHTMLView.mm:
369         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
370           selector warning around action methods that are not declared anywhere in WebKit.
371
372         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
373           about implementing this deprecated method.
374         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
375         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
376         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
377         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
378         (-[WebHTMLView characterIndexForPoint:]): Ditto.
379         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
380         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
381         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
382         (-[WebHTMLView doCommandBySelector:]): Ditto.
383         (-[WebHTMLView insertText:]): Ditto.
384
385         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
386
387         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
388
389         * WebView/WebPDFView.h: Removed previewView ivar.
390
391         * WebView/WebPDFView.mm:
392           Removed declaration of FileInternal category and merged its implementation with the main
393           implementation.
394         (-[WebPDFView dealloc]): Removed previewView ivar.
395         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
396           exist in macOS versions we support.
397         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
398         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
399           action methods internal to PDFKit.
400         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
401         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
402
403         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
404           call on macOS, even though in r86988 we started calling different methods on iOS.
405
406         * WebView/WebView.mm:
407         - Imported headers that declare delegate methods that we call.
408         - Removed declaration of WebFileInternal category and merged its implementation with the
409           main implementation.
410         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
411           category, which made them impossible to call from the main implementation. Moved those
412           into the main implementation. One of those had to be declared in a class extension,
413           because it is called from a method implemented in the WebPrivate category, and that
414           category’s implementation appears first in the file.
415
416         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
417           around use of obsolete delegate method for binary compatibility.
418
419         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
420
421 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
422
423         Runtime flag and IDL for MediaRecorder
424         https://bugs.webkit.org/show_bug.cgi?id=190018
425
426         Reviewed by Youenn Fablet and Chris Dumez.
427
428         * WebView/WebPreferenceKeysPrivate.h:
429         * WebView/WebPreferences.mm:
430         (+[WebPreferences initialize]):
431         (-[WebPreferences mediaRecorderEnabled]):
432         (-[WebPreferences setMediaRecorderEnabled:]):
433         * WebView/WebPreferencesPrivate.h:
434         * WebView/WebView.mm:
435         (-[WebView _preferencesChanged:]):
436
437 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
438
439         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
440         https://bugs.webkit.org/show_bug.cgi?id=190238
441
442         Reviewed by Antti Koivisto.
443
444         Enabled the feature by default.
445
446         * WebView/WebPreferences.mm:
447         (+[WebPreferences initialize]):
448
449 2018-10-01  Dean Jackson  <dino@apple.com>
450
451         [macOS] Switching to discrete GPU should be done in the UI process
452         https://bugs.webkit.org/show_bug.cgi?id=189361
453         <rdar://problem/43949622>
454
455         Reviewed by Simon Fraser.
456
457         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
458         not support swapping to the discrete GPU in this configuration.
459
460         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
461         (WebKit::WebSwitchingGPUClient::singleton):
462         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
463         * WebView/WebView.mm:
464         (-[WebView _commonInitializationWithFrameName:groupName:]):
465
466 2018-10-02  Alex Christensen  <achristensen@webkit.org>
467
468         Remove ParsedURLString
469         https://bugs.webkit.org/show_bug.cgi?id=190154
470
471         Reviewed by Chris Dumez.
472
473         * WebView/WebScriptDebugger.mm:
474         (toNSURL):
475
476 2018-10-01  Dean Jackson  <dino@apple.com>
477
478         Remove CSS Animation Triggers
479         https://bugs.webkit.org/show_bug.cgi?id=190175
480         <rdar://problem/44925626>
481
482         Reviewed by Simon Fraser.
483
484         * Configurations/FeatureDefines.xcconfig:
485
486 2018-10-02  Commit Queue  <commit-queue@webkit.org>
487
488         Unreviewed, rolling out r236624 and r236671.
489         https://bugs.webkit.org/show_bug.cgi?id=190207
490
491         The change in r236624 introduced crashes on the bots
492         (Requested by ryanhaddad on #webkit).
493
494         Reverted changesets:
495
496         "Refactoring: eliminate raw pointer usage in Fullscreen code"
497         https://bugs.webkit.org/show_bug.cgi?id=188747
498         https://trac.webkit.org/changeset/236624
499
500         "Unify implementation in VideoFullscreenInterfaceAVKit"
501         https://bugs.webkit.org/show_bug.cgi?id=190091
502         https://trac.webkit.org/changeset/236671
503
504 2018-10-01  Alex Christensen  <achristensen@webkit.org>
505
506         URL should not use TextEncoding internally
507         https://bugs.webkit.org/show_bug.cgi?id=190111
508
509         Reviewed by Andy Estes.
510
511         * Misc/WebNSURLExtras.mm:
512
513 2018-09-28  Jer Noble  <jer.noble@apple.com>
514
515         Refactoring: eliminate raw pointer usage in Fullscreen code
516         https://bugs.webkit.org/show_bug.cgi?id=188747
517         <rdar://problem/43541164>
518
519         Reviewed by Alex Christensen.
520
521         PlaybackSessionInterface no longer has an invalidate() method.
522
523         * WebView/WebView.mm:
524         (-[WebView _clearPlaybackControlsManager]):
525
526 2018-09-28  Chris Dumez  <cdumez@apple.com>
527
528         Drop support for cross-origin-window-policy header
529         https://bugs.webkit.org/show_bug.cgi?id=190081
530
531         Reviewed by Ryosuke Niwa.
532
533         * WebView/WebPreferenceKeysPrivate.h:
534         * WebView/WebPreferences.mm:
535         (+[WebPreferences initialize]):
536         * WebView/WebPreferencesPrivate.h:
537         * WebView/WebView.mm:
538         (-[WebView _preferencesChanged:]):
539
540 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
541
542         Rename createMarkup to serializePreservingVisualAppearance
543         https://bugs.webkit.org/show_bug.cgi?id=190086
544
545         Reviewed by Wenson Hsieh.
546
547         * DOM/WebDOMOperations.mm:
548         (-[DOMRange markupString]):
549
550 2018-09-28  Commit Queue  <commit-queue@webkit.org>
551
552         Unreviewed, rolling out r236605.
553         https://bugs.webkit.org/show_bug.cgi?id=190087
554
555         caused three API test timeouts (Requested by jernoble on
556         #webkit).
557
558         Reverted changeset:
559
560         "Refactoring: eliminate raw pointer usage in Fullscreen code"
561         https://bugs.webkit.org/show_bug.cgi?id=188747
562         https://trac.webkit.org/changeset/236605
563
564 2018-09-28  Jer Noble  <jer.noble@apple.com>
565
566         Refactoring: eliminate raw pointer usage in Fullscreen code
567         https://bugs.webkit.org/show_bug.cgi?id=188747
568         <rdar://problem/43541164>
569
570         Reviewed by Alex Christensen.
571
572         PlaybackSessionInterface no longer has an invalidate() method.
573
574         * WebView/WebView.mm:
575         (-[WebView _clearPlaybackControlsManager]):
576
577 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
578
579         Use enum class in createMarkup arguments
580         https://bugs.webkit.org/show_bug.cgi?id=190028
581
582         Reviewed by Wenson Hsieh.
583
584         * DOM/WebDOMOperations.mm:
585         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
586         (-[DOMRange markupString]): Ditto.
587
588 2018-09-27  Antoine Quint  <graouts@apple.com>
589
590         [Web Animations] Turn Web Animations with CSS integration on
591         https://bugs.webkit.org/show_bug.cgi?id=184819
592         <rdar://problem/39597337>
593
594         Reviewed by Dean Jackson.
595
596         * WebView/WebPreferences.mm:
597         (+[WebPreferences initialize]):
598
599 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
600
601         Selection should work across shadow boundary when initiated by a mouse drag
602         https://bugs.webkit.org/show_bug.cgi?id=151380
603         <rdar://problem/24363872>
604
605         Reviewed by Wenson Hsieh.
606
607         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
608
609         * WebView/WebPreferenceKeysPrivate.h:
610         * WebView/WebPreferences.mm:
611         (+[WebPreferences initialize]):
612         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
613         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
614         * WebView/WebPreferencesPrivate.h:
615         * WebView/WebView.mm:
616         (-[WebView _preferencesChanged:]):
617
618 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
619
620         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
621         https://bugs.webkit.org/show_bug.cgi?id=189918
622         Work towards <rdar://problem/44648705>
623
624         Reviewed by Tim Horton.
625
626         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
627
628         * WebView/WebHTMLView.mm:
629         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
630         (-[WebHTMLView _updateFontPanel]):
631         * WebView/WebView.mm:
632         (-[WebView typingAttributes]):
633
634 2018-09-17  Darin Adler  <darin@apple.com>
635
636         Use OpaqueJSString rather than JSRetainPtr inside WebKit
637         https://bugs.webkit.org/show_bug.cgi?id=189652
638
639         Reviewed by Saam Barati.
640
641         * WebView/WebPDFRepresentation.mm:
642         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
643
644 2018-09-14  Jer Noble  <jer.noble@apple.com>
645
646         Turn SourceBufferChangeTypeEnabled on by default
647         https://bugs.webkit.org/show_bug.cgi?id=189527
648
649         Reviewed by Eric Carlson.
650
651         * WebView/WebPreferences.mm:
652         (+[WebPreferences initialize]):
653
654 2018-09-12  Alex Christensen  <achristensen@webkit.org>
655
656         Fix an internal build after r235935
657         https://bugs.webkit.org/show_bug.cgi?id=188996
658
659         * Carbon/HIWebView.mm:
660         (Draw):
661         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
662
663 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
664
665         Add IGNORE_WARNING_.* macros
666         https://bugs.webkit.org/show_bug.cgi?id=188996
667
668         Reviewed by Michael Catanzaro.
669
670         * Carbon/CarbonUtils.m:
671         (PoolCleaner):
672         * Carbon/CarbonWindowAdapter.mm:
673         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
674         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
675         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
676         (-[CarbonWindowAdapter _termWindowIfOwner]):
677         (-[CarbonWindowAdapter _windowMovedToRect:]):
678         (-[CarbonWindowAdapter setContentView:]):
679         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
680         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
681         * Carbon/CarbonWindowFrame.m:
682         (-[CarbonWindowFrame title]):
683         * Carbon/HIViewAdapter.m:
684         (+[HIViewAdapter getHIViewForNSView:]):
685         * Carbon/HIWebView.mm:
686         (overrideCGContext):
687         (restoreCGContext):
688         (Draw):
689         * DOM/DOM.mm:
690         * History/WebHistory.mm:
691         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
692         * History/WebHistoryItem.mm:
693         (-[WebHistoryItem icon]):
694         * Misc/WebKitNSStringExtras.mm:
695         (-[NSString _web_drawAtPoint:font:textColor:]):
696         * Misc/WebNSImageExtras.m:
697         (-[NSImage _web_scaleToMaxSize:]):
698         (-[NSImage _web_dissolveToFraction:]):
699         * Misc/WebNSPasteboardExtras.mm:
700         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
701         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
702         * Panels/WebAuthenticationPanel.m:
703         (-[WebAuthenticationPanel loadNib]):
704         * Plugins/Hosted/NetscapePluginHostManager.mm:
705         (WebKit::NetscapePluginHostManager::spawnPluginHost):
706         (WebKit::NetscapePluginHostManager::didCreateWindow):
707         * Plugins/Hosted/NetscapePluginHostProxy.mm:
708         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
709         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
710         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
711         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
712         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
713         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
714         (-[WebHostedNetscapePluginView drawRect:]):
715         * Plugins/Hosted/WebTextInputWindowController.m:
716         (-[WebTextInputPanel _interpretKeyEvent:string:]):
717         * Plugins/WebBaseNetscapePluginView.mm:
718         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
719         * Plugins/WebNetscapePluginPackage.mm:
720         (-[WebNetscapePluginPackage _tryLoad]):
721         * Plugins/WebNetscapePluginView.mm:
722         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
723         (-[WebNetscapePluginView sendDrawRectEvent:]):
724         (-[WebNetscapePluginView drawRect:]):
725         * Plugins/WebPluginController.mm:
726         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
727         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
728         * WebCoreSupport/PopupMenuMac.mm:
729         (PopupMenuMac::populate):
730         * WebCoreSupport/WebAlternativeTextClient.h:
731         * WebCoreSupport/WebDragClient.mm:
732         (WebDragClient::startDrag):
733         * WebCoreSupport/WebFrameLoaderClient.mm:
734         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
735         (webGetNSImage):
736         * WebInspector/WebNodeHighlight.mm:
737         * WebInspector/WebNodeHighlightView.mm:
738         (-[WebNodeHighlightView drawRect:]):
739         * WebView/WebClipView.mm:
740         (-[WebClipView initWithFrame:]):
741         * WebView/WebFrame.mm:
742         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
743         (-[WebFrame _drawRect:contentsOnly:]):
744         (-[WebFrame accessibilityRoot]):
745         * WebView/WebFullScreenController.mm:
746         (-[WebFullScreenController enterFullScreen:]):
747         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
748         (-[WebFullScreenController exitFullScreen]):
749         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
750         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
751         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
752         * WebView/WebHTMLView.mm:
753         (-[NSWindow _web_borderView]):
754         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
755         (-[WebHTMLView _setAsideSubviews]):
756         (-[WebHTMLView _autoscroll]):
757         (-[WebHTMLView drawRect:]):
758         (-[WebHTMLView mouseDown:]):
759         (-[WebHTMLView mouseDragged:]):
760         (-[WebHTMLView mouseUp:]):
761         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
762         (-[WebHTMLView knowsPageRange:]):
763         (-[WebHTMLView accessibilityHitTest:]):
764         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
765         (-[WebHTMLView _colorAsString:]):
766         (-[WebHTMLView copyFont:]):
767         (-[WebHTMLView _executeSavedKeypressCommands]):
768         (-[WebHTMLView attachRootLayer:]):
769         (-[WebHTMLView textStorage]):
770         (-[WebHTMLView _updateSelectionForInputManager]):
771         * WebView/WebPDFView.mm:
772         (_applicationInfoForMIMEType):
773         (-[WebPDFView centerSelectionInVisibleArea:]):
774         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
775         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
776         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
777         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
778         * WebView/WebTextCompletionController.mm:
779         (-[WebTextCompletionController _buildUI]):
780         (-[WebTextCompletionController _placePopupWindow:]):
781         * WebView/WebVideoFullscreenController.mm:
782         * WebView/WebVideoFullscreenHUDWindowController.mm:
783         (createMediaUIBackgroundView):
784         * WebView/WebView.mm:
785         (-[WebTextListTouchBarViewController initWithWebView:]):
786         (-[WebView _dispatchTileDidDraw:]):
787         (-[WebView encodeWithCoder:]):
788         (-[WebView mainFrameIcon]):
789         (LayerFlushController::flushLayers):
790         * WebView/WebWindowAnimation.mm:
791         (setScaledFrameForWindow):
792
793 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
794
795         Remove unused needsDestruction class variables from HashTraits
796         https://bugs.webkit.org/show_bug.cgi?id=189490
797
798         Reviewed by Daniel Bates.
799
800         * History/BinaryPropertyList.cpp: Removed needsDestruction.
801
802 2018-09-07  Frederic Wang  <fwang@igalia.com>
803
804         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
805         https://bugs.webkit.org/show_bug.cgi?id=182230
806
807         Reviewed by Simon Fraser.
808
809         * DOM/DOMDocument.mm:
810         (-[DOMDocument scrollingElement]): Use the new name.
811
812 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         Refactor WebCore::EditAction to be an 8-bit enum class
815         https://bugs.webkit.org/show_bug.cgi?id=189383
816
817         Reviewed by Dan Bernstein.
818
819         * WebCoreSupport/WebEditorClient.mm:
820         (undoNameForEditAction):
821         * WebView/WebHTMLView.mm:
822         (-[WebHTMLView pasteFont:]):
823         (-[WebHTMLView changeFont:]):
824         (-[WebHTMLView changeAttributes:]):
825         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
826         (-[WebHTMLView changeColor:]):
827         * WebView/WebView.mm:
828         (-[WebView setTypingStyle:]):
829
830 2018-09-06  Frederic Wang  <fwang@igalia.com>
831
832         Group options of scrollRectToVisible into a struct
833         https://bugs.webkit.org/show_bug.cgi?id=189352
834
835         Reviewed by Simon Fraser.
836
837         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
838         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
839         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
840
841 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
842
843         [macOS] Cannot change font size at selection until font panel is shown
844         https://bugs.webkit.org/show_bug.cgi?id=189295
845         <rdar://problem/35593389>
846
847         Reviewed by Ryosuke Niwa.
848
849         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
850         WebCore ChangeLog for more details.
851
852         * WebView/WebHTMLView.mm:
853         (-[WebHTMLView changeFont:]):
854         (-[WebHTMLView changeAttributes:]):
855         (-[WebHTMLView _originalFontA]): Deleted.
856         (-[WebHTMLView _originalFontB]): Deleted.
857         (fontNameForDescription): Deleted.
858         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
859         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
860         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
861
862 2018-09-05  Jer Noble  <jer.noble@apple.com>
863
864         Add MediaCapabilities as an Experimental Feature
865         https://bugs.webkit.org/show_bug.cgi?id=189209
866
867         Reviewed by Eric Carlson.
868
869         RuntimeEnabledFeature -> Setting.
870
871         * WebView/WebView.mm:
872         (-[WebView _preferencesChanged:]):
873
874 2018-09-04  Frederic Wang  <fwang@igalia.com>
875
876         Add basic support for ScrollIntoViewOptions
877         https://bugs.webkit.org/show_bug.cgi?id=189258
878
879         Reviewed by Simon Fraser.
880
881         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
882         header so that this file can build despite the new scrollIntoView function.
883
884 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
885
886         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
887         https://bugs.webkit.org/show_bug.cgi?id=188890
888         <rdar://problem/43648605>
889
890         Reviewed by Tim Horton.
891
892         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
893         more detail.
894
895         * WebCoreSupport/WebPlatformStrategies.h:
896         * WebCoreSupport/WebPlatformStrategies.mm:
897         (WebPlatformStrategies::allStringsForType):
898
899 2018-09-01  Darin Adler  <darin@apple.com>
900
901         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
902         https://bugs.webkit.org/show_bug.cgi?id=189072
903         Reviewed by Dan Bernstein.
904
905         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
906         and declarations for NSURLDownload init methods.
907
908         * Misc/WebDownloadInternal.h: Removed.
909
910         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
911         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
912         "-Wdeprecated-declarations" because the method used here is deprecated.
913
914         * WebView/WebView.mm:
915         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
916         used here is deprecated.
917
918 2018-08-31  Chris Dumez  <cdumez@apple.com>
919
920         Assertion hit in ~CompletionHandler() from ~WebFrame()
921         https://bugs.webkit.org/show_bug.cgi?id=189199
922         <rdar://problem/42657233>
923
924         Reviewed by Youenn Fablet.
925
926         * WebCoreSupport/WebFrameLoaderClient.h:
927         * WebCoreSupport/WebFrameLoaderClient.mm:
928         (WebFrameLoaderClient::dispatchWillSubmitForm):
929
930 2018-08-31  Antti Koivisto  <antti@apple.com>
931
932         Replace OptionSet |= and -= operators with add() and remove() functions
933         https://bugs.webkit.org/show_bug.cgi?id=189169
934
935         Reviewed by Anders Carlsson.
936
937         * WebView/WebFrame.mm:
938         (-[WebFrame _drawRect:contentsOnly:]):
939         * WebView/WebView.mm:
940         (coreOptions):
941
942 2018-08-31  Frederic Wang  <fwang@igalia.com>
943
944         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
945         https://bugs.webkit.org/show_bug.cgi?id=182053
946
947         Reviewed by Simon Fraser.
948
949         Add developer flag to use standard behavior for scrolling* attributes.
950
951         * WebView/WebPreferenceKeysPrivate.h:
952         * WebView/WebPreferences.mm:
953         (+[WebPreferences initialize]):
954         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
955         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
956         * WebView/WebPreferencesPrivate.h:
957         * WebView/WebView.mm:
958         (-[WebView _preferencesChanged:]):
959
960 2018-08-29  Olivia Barnett  <obarnett@apple.com>
961
962         Implement the Web Share API
963         https://bugs.webkit.org/show_bug.cgi?id=171100
964         <rdar://problem/31751734>
965
966         Reviewed by Tim Horton.
967
968         * WebCoreSupport/WebChromeClient.h:
969         * WebCoreSupport/WebChromeClient.mm:
970         (WebChromeClient::showShareSheet):
971         Empty declaration of showShareSheet.
972
973 2018-08-29  Youenn Fablet  <youenn@apple.com>
974
975         Remove WebRTC legacy API implementation
976         https://bugs.webkit.org/show_bug.cgi?id=189040
977
978         Reviewed by Eric Carlson.
979
980         * WebView/WebPreferenceKeysPrivate.h:
981         * WebView/WebPreferences.mm:
982         (+[WebPreferences initialize]):
983         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
984         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
985         * WebView/WebPreferencesPrivate.h:
986         * WebView/WebView.mm:
987         (-[WebView _preferencesChanged:]):
988
989 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
990
991         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
992         https://bugs.webkit.org/show_bug.cgi?id=189054
993
994         Reviewed by Andy Estes.
995
996         Remove the pasteboard type argument from readURLFromPasteboard.
997
998         * WebCoreSupport/WebPlatformStrategies.h:
999         * WebCoreSupport/WebPlatformStrategies.mm:
1000         (WebPlatformStrategies::readURLFromPasteboard):
1001
1002 2018-08-27  Keith Rollin  <krollin@apple.com>
1003
1004         Unreviewed build fix -- disable LTO for production builds
1005
1006         * Configurations/Base.xcconfig:
1007
1008 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1009
1010         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1011         https://bugs.webkit.org/show_bug.cgi?id=188931
1012
1013         Reviewed by Wenson Hsieh.
1014
1015         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1016
1017 2018-08-27  Keith Rollin  <krollin@apple.com>
1018
1019         Build system support for LTO
1020         https://bugs.webkit.org/show_bug.cgi?id=187785
1021         <rdar://problem/42353132>
1022
1023         Reviewed by Dan Bernstein.
1024
1025         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1026         LTO.
1027
1028         * Configurations/Base.xcconfig:
1029         * Configurations/DebugRelease.xcconfig:
1030
1031 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1032
1033         Pass in IsComposed flag to Event constructors
1034         https://bugs.webkit.org/show_bug.cgi?id=188720
1035         <rdar://problem/43580387>
1036
1037         Reviewed by Simon Fraser.
1038
1039         * WebView/WebPDFView.mm:
1040         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1041         whether it's simulated or not.
1042
1043 2018-08-23  Mark Lam  <mark.lam@apple.com>
1044
1045         Move vmEntryGlobalObject() to VM from CallFrame.
1046         https://bugs.webkit.org/show_bug.cgi?id=188900
1047         <rdar://problem/43655753>
1048
1049         Reviewed by Michael Saboff.
1050
1051         * WebView/WebScriptDebugger.mm:
1052         (WebScriptDebugger::sourceParsed):
1053
1054 2018-08-23  Andy Estes  <aestes@apple.com>
1055
1056         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1057         https://bugs.webkit.org/show_bug.cgi?id=188829
1058
1059         Reviewed by Tim Horton.
1060
1061         * Configurations/FeatureDefines.xcconfig:
1062
1063 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1064
1065         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1066         https://bugs.webkit.org/show_bug.cgi?id=188777
1067
1068         Reviewed by Simon Fraser.
1069
1070         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1071         being "true" before the code change.
1072
1073         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1074
1075         * WebView/WebPDFView.mm:
1076         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1077
1078 2018-08-21  Daniel Bates  <dabates@apple.com>
1079
1080         Replace TextCheckingTypeMask with OptionSet
1081         https://bugs.webkit.org/show_bug.cgi?id=188678
1082
1083         Reviewed by Antti Koivisto.
1084
1085         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1086         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1087         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1088         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1089
1090         * WebCoreSupport/WebEditorClient.h:
1091         * WebCoreSupport/WebEditorClient.mm:
1092         (WebEditorClient::checkTextOfParagraph):
1093         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1094         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1095         left as this is more readable and unncessary now that modern compilers like Clang have
1096         diagnostics to catch accidental assignments when equality was intended.
1097         (WebEditorClient::didCheckSucceed):
1098         * WebView/WebView.mm:
1099         (coreTextCheckingType):
1100         (textCheckingResultFromNSTextCheckingResult):
1101
1102 2018-08-21  Daniel Bates  <dabates@apple.com>
1103
1104         [iOS][WK1] Support toggling continuous spell checking from tests
1105         https://bugs.webkit.org/show_bug.cgi?id=188763
1106
1107         Reviewed by Simon Fraser.
1108
1109         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1110         spell checking from tests in iOS WebKit Legacy.
1111
1112         * WebCoreSupport/WebEditorClient.h:
1113         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1114         * WebCoreSupport/WebEditorClient.mm:
1115         * WebView/WebView.h:
1116         * WebView/WebView.mm:
1117         (-[WebView toggleContinuousSpellChecking:]):
1118         (-[WebView toggleSmartInsertDelete:]):
1119
1120 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1121
1122         Add some plumbing for safe browsing
1123         https://bugs.webkit.org/show_bug.cgi?id=188709
1124
1125         Reviewed by Tim Horton.
1126
1127         * WebCoreSupport/WebFrameLoaderClient.h:
1128         * WebCoreSupport/WebFrameLoaderClient.mm:
1129         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1130
1131 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1132
1133         Replace canBubble and cancelable booleans in Event by enum classes
1134         https://bugs.webkit.org/show_bug.cgi?id=188692
1135
1136         Reviewed by Alex Christensen.
1137
1138         * WebView/WebPDFView.mm:
1139         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1140         * WebView/WebView.mm:
1141         (-[WebView _dispatchUnloadEvent]):
1142
1143 2018-08-16  Jer Noble  <jer.noble@apple.com>
1144
1145         Add Experimental Feature support for SourceBuffer.changeType()
1146         https://bugs.webkit.org/show_bug.cgi?id=188626
1147         <rdar://problem/43356021>
1148
1149         Reviewed by Eric Carlson.
1150
1151         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1152
1153         * WebView/WebPreferenceKeysPrivate.h:
1154         * WebView/WebPreferences.mm:
1155         (+[WebPreferences initialize]):
1156         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1157         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1158         * WebView/WebPreferencesPrivate.h:
1159         * WebView/WebView.mm:
1160         (-[WebView _preferencesChanged:]):
1161
1162 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1163
1164         Support drag-and-drop for input[type=color]
1165         https://bugs.webkit.org/show_bug.cgi?id=188464
1166
1167         Reviewed by Wenson Hsieh.
1168
1169         * WebCoreSupport/WebPlatformStrategies.h:
1170         * WebCoreSupport/WebPlatformStrategies.mm:
1171         (WebPlatformStrategies::setColor):
1172
1173 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1174
1175         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1176         https://bugs.webkit.org/show_bug.cgi?id=188569
1177         <rdar://problem/34201095>
1178
1179         Reviewed by Megan Gardner.
1180
1181         * WebView/WebImmediateActionController.mm:
1182         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1183         Speculative fix; the crashes indicate font is null, but we just checked it,
1184         so it must be getting made null by convertFont:toSize:. Check again!
1185
1186 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1187
1188         Use a 1-byte enum class for TextDirection
1189         https://bugs.webkit.org/show_bug.cgi?id=188350
1190
1191         Reviewed by Simon Fraser.
1192
1193         * WebCoreSupport/PopupMenuMac.mm:
1194         (PopupMenuMac::populate):
1195         (PopupMenuMac::show):
1196         * WebCoreSupport/WebFrameLoaderClient.mm:
1197         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1198         * WebView/WebFrame.mm:
1199         (-[WebFrame _dispatchDidReceiveTitle:]):
1200
1201 2018-08-09  Ali Juma  <ajuma@chromium.org>
1202
1203         Import WPTs for IntersectionObserver
1204         https://bugs.webkit.org/show_bug.cgi?id=188416
1205
1206         Reviewed by Simon Fraser.
1207
1208         * WebView/WebPreferencesPrivate.h:
1209
1210 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1211
1212         Follow-up build fix for r234685
1213         https://bugs.webkit.org/show_bug.cgi?id=188245
1214
1215         Unreviewed build fix.
1216
1217         * WebCoreSupport/WebSecurityOriginPrivate.h:
1218
1219 2018-08-05  Darin Adler  <darin@apple.com>
1220
1221         [Cocoa] More tweaks and refactoring to prepare for ARC
1222         https://bugs.webkit.org/show_bug.cgi?id=188245
1223
1224         Reviewed by Dan Bernstein.
1225
1226         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1227
1228         * Carbon/CarbonWindowFrame.m:
1229         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1230
1231         * DOM/DOM.mm:
1232         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1233         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1234         garbage collection so this method isn't useful.
1235
1236         * DOM/DOMXPath.mm:
1237         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1238         Objective-C garbage collection so this method isn't useful.
1239
1240         * History/WebHistory.mm:
1241         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1242
1243         * Misc/WebElementDictionary.mm:
1244         (addLookupKey): Use a bridging cast.
1245         (cacheValueForKey): Ditto.
1246         (-[WebElementDictionary _fillCache]): Ditto.
1247         (-[WebElementDictionary objectForKey:]): Ditto.
1248
1249         * Misc/WebKitNSStringExtras.mm:
1250         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1251         (-[NSString _web_widthWithFont:]): Ditto.
1252         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1253
1254         * Misc/WebLocalizableStrings.mm:
1255         (WebLocalizedString): Use a bridging cast.
1256
1257         * Misc/WebNSDataExtras.mm:
1258         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1259         and use CFBridgingRelease instead of calling autorelease directly.
1260         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1261         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1262         on the amount of explicit release and autorelease.
1263
1264         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1265         * Misc/WebNSDictionaryExtras.m:
1266         (-[NSDictionary _webkit_intForKey:]): Deleted.
1267         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1268         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1269         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1270         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1271         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1272         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1273
1274         * Misc/WebStringTruncator.mm:
1275         (fontFromNSFont): Use a bridging cast.
1276
1277         * Plugins/Hosted/NetscapePluginHostManager.mm:
1278         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1279
1280         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1281         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1282         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1283         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1284         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1285         * Plugins/Hosted/ProxyInstance.mm:
1286         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1287         * Plugins/WebBasePluginPackage.mm:
1288         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1289         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1290         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1291         * Plugins/WebNetscapePluginPackage.mm:
1292         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1293
1294         * Plugins/WebNetscapePluginView.mm:
1295         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1296         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1297         (-[WebNetscapePluginView status:]): Use a bridging cast.
1298         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1299
1300         * Plugins/WebPluginController.mm:
1301         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1302
1303         * Plugins/WebPluginDatabase.mm:
1304         (checkCandidate): Use explicit __strong for out argument types.
1305
1306         * Plugins/npapi.mm:
1307         (pluginViewForInstance): Use a bridging cast.
1308
1309         * Storage/WebDatabaseManager.mm:
1310         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1311         explicit NSNumber and NSDictionary calls.
1312
1313         * WebCoreSupport/WebContextMenuClient.mm:
1314         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1315
1316         * WebCoreSupport/WebEditorClient.mm:
1317         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1318         (WebEditorClient::handleInputMethodKeydown): Ditto.
1319
1320         * WebCoreSupport/WebFrameNetworkingContext.mm:
1321         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1322
1323         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1324         as a struct rather than an Objective-C class, since that's how it's defined.
1325
1326         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1327
1328         * WebView/WebFullScreenController.mm:
1329         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1330         * WebView/WebHTMLView.mm:
1331         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1332         Ditto.
1333         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1334
1335         * WebView/WebImmediateActionController.mm:
1336         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1337         go down to the document and then back to the frame.
1338         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1339         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1340         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1341
1342         * WebView/WebJSPDFDoc.mm:
1343         (jsPDFDocInitialize): Removed some unneeded type casting.
1344         (jsPDFDocFinalize): Ditto.
1345         (jsPDFDocPrint): Use a bridging cast.
1346
1347         * WebView/WebPDFView.mm:
1348         (_applicationInfoForMIMEType): Use bridging casts.
1349
1350         * WebView/WebPreferences.mm:
1351         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1352         instead of methods from WebNSDictionaryExtras.
1353         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1354         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1355         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1356         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1357         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1358
1359         * WebView/WebView.mm:
1360         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1361         (-[WebView _addToAllWebViewsSet]): Ditto.
1362         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1363         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1364         so it can be called from WebViewData methods.
1365
1366         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1367         method, _windowVisibilityChanged:.
1368
1369         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1370         called from WebViewData methods.
1371
1372 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1373
1374         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1375         https://bugs.webkit.org/show_bug.cgi?id=188323
1376
1377         Reviewed by Simon Fraser.
1378
1379         * WebCoreSupport/WebContextMenuClient.mm:
1380         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1381         * WebView/WebFrame.mm:
1382         (-[WebFrame _paintBehaviorForDestinationContext:]):
1383         (-[WebFrame _drawRect:contentsOnly:]):
1384         * WebView/WebHTMLView.mm:
1385         (imageFromRect):
1386         (selectionImage):
1387
1388 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1389
1390         Add support for microtasks in workers
1391         https://bugs.webkit.org/show_bug.cgi?id=188246
1392
1393         Reviewed by Darin Adler.
1394
1395         Rename JSMainThreadExecState.h to JSExecState.h.
1396
1397         * DOM/DOMAttr.mm:
1398         * DOM/DOMBlob.mm:
1399         * DOM/DOMCDATASection.mm:
1400         * DOM/DOMCSSCharsetRule.mm:
1401         * DOM/DOMCSSFontFaceRule.mm:
1402         * DOM/DOMCSSImportRule.mm:
1403         * DOM/DOMCSSMediaRule.mm:
1404         * DOM/DOMCSSPageRule.mm:
1405         * DOM/DOMCSSPrimitiveValue.mm:
1406         * DOM/DOMCSSRule.mm:
1407         * DOM/DOMCSSRuleList.mm:
1408         * DOM/DOMCSSStyleDeclaration.mm:
1409         * DOM/DOMCSSStyleRule.mm:
1410         * DOM/DOMCSSStyleSheet.mm:
1411         * DOM/DOMCSSUnknownRule.mm:
1412         * DOM/DOMCSSValue.mm:
1413         * DOM/DOMCSSValueList.mm:
1414         * DOM/DOMCharacterData.mm:
1415         * DOM/DOMComment.mm:
1416         * DOM/DOMCounter.mm:
1417         * DOM/DOMDocument.mm:
1418         * DOM/DOMDocumentFragment.mm:
1419         * DOM/DOMDocumentType.mm:
1420         * DOM/DOMElement.mm:
1421         * DOM/DOMEvent.mm:
1422         * DOM/DOMFile.mm:
1423         * DOM/DOMFileList.mm:
1424         * DOM/DOMHTML.mm:
1425         * DOM/DOMHTMLAnchorElement.mm:
1426         * DOM/DOMHTMLAppletElement.mm:
1427         * DOM/DOMHTMLAreaElement.mm:
1428         * DOM/DOMHTMLBRElement.mm:
1429         * DOM/DOMHTMLBaseElement.mm:
1430         * DOM/DOMHTMLBaseFontElement.mm:
1431         * DOM/DOMHTMLBodyElement.mm:
1432         * DOM/DOMHTMLButtonElement.mm:
1433         * DOM/DOMHTMLCanvasElement.mm:
1434         * DOM/DOMHTMLCollection.mm:
1435         * DOM/DOMHTMLDListElement.mm:
1436         * DOM/DOMHTMLDirectoryElement.mm:
1437         * DOM/DOMHTMLDivElement.mm:
1438         * DOM/DOMHTMLDocument.mm:
1439         * DOM/DOMHTMLElement.mm:
1440         * DOM/DOMHTMLEmbedElement.mm:
1441         * DOM/DOMHTMLFieldSetElement.mm:
1442         * DOM/DOMHTMLFontElement.mm:
1443         * DOM/DOMHTMLFormElement.mm:
1444         * DOM/DOMHTMLFrameElement.mm:
1445         * DOM/DOMHTMLFrameSetElement.mm:
1446         * DOM/DOMHTMLHRElement.mm:
1447         * DOM/DOMHTMLHeadElement.mm:
1448         * DOM/DOMHTMLHeadingElement.mm:
1449         * DOM/DOMHTMLHtmlElement.mm:
1450         * DOM/DOMHTMLIFrameElement.mm:
1451         * DOM/DOMHTMLImageElement.mm:
1452         * DOM/DOMHTMLInputElement.mm:
1453         * DOM/DOMHTMLLIElement.mm:
1454         * DOM/DOMHTMLLabelElement.mm:
1455         * DOM/DOMHTMLLegendElement.mm:
1456         * DOM/DOMHTMLLinkElement.mm:
1457         * DOM/DOMHTMLMapElement.mm:
1458         * DOM/DOMHTMLMarqueeElement.mm:
1459         * DOM/DOMHTMLMediaElement.mm:
1460         * DOM/DOMHTMLMenuElement.mm:
1461         * DOM/DOMHTMLMetaElement.mm:
1462         * DOM/DOMHTMLModElement.mm:
1463         * DOM/DOMHTMLOListElement.mm:
1464         * DOM/DOMHTMLObjectElement.mm:
1465         * DOM/DOMHTMLOptGroupElement.mm:
1466         * DOM/DOMHTMLOptionElement.mm:
1467         * DOM/DOMHTMLOptionsCollection.mm:
1468         * DOM/DOMHTMLParagraphElement.mm:
1469         * DOM/DOMHTMLParamElement.mm:
1470         * DOM/DOMHTMLPreElement.mm:
1471         * DOM/DOMHTMLQuoteElement.mm:
1472         * DOM/DOMHTMLScriptElement.mm:
1473         * DOM/DOMHTMLSelectElement.mm:
1474         * DOM/DOMHTMLStyleElement.mm:
1475         * DOM/DOMHTMLTableCaptionElement.mm:
1476         * DOM/DOMHTMLTableCellElement.mm:
1477         * DOM/DOMHTMLTableColElement.mm:
1478         * DOM/DOMHTMLTableElement.mm:
1479         * DOM/DOMHTMLTableRowElement.mm:
1480         * DOM/DOMHTMLTableSectionElement.mm:
1481         * DOM/DOMHTMLTextAreaElement.mm:
1482         * DOM/DOMHTMLTitleElement.mm:
1483         * DOM/DOMHTMLUListElement.mm:
1484         * DOM/DOMHTMLVideoElement.mm:
1485         * DOM/DOMImplementation.mm:
1486         * DOM/DOMKeyboardEvent.mm:
1487         * DOM/DOMMediaError.mm:
1488         * DOM/DOMMediaList.mm:
1489         * DOM/DOMMouseEvent.mm:
1490         * DOM/DOMMutationEvent.mm:
1491         * DOM/DOMNamedNodeMap.mm:
1492         * DOM/DOMNode.mm:
1493         * DOM/DOMNodeIterator.mm:
1494         * DOM/DOMNodeList.mm:
1495         * DOM/DOMOverflowEvent.mm:
1496         * DOM/DOMProcessingInstruction.mm:
1497         * DOM/DOMProgressEvent.mm:
1498         * DOM/DOMRGBColor.mm:
1499         * DOM/DOMRange.mm:
1500         * DOM/DOMRect.mm:
1501         * DOM/DOMStyleSheet.mm:
1502         * DOM/DOMStyleSheetList.mm:
1503         * DOM/DOMText.mm:
1504         * DOM/DOMTextEvent.mm:
1505         * DOM/DOMTimeRanges.mm:
1506         * DOM/DOMTokenList.mm:
1507         * DOM/DOMTreeWalker.mm:
1508         * DOM/DOMUIEvent.mm:
1509         * DOM/DOMWheelEvent.mm:
1510         * DOM/DOMXPathExpression.mm:
1511         * DOM/DOMXPathResult.mm:
1512         * DOM/ObjCEventListener.mm:
1513
1514 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1515
1516         Fix spelling of "overridden"
1517         https://bugs.webkit.org/show_bug.cgi?id=188315
1518
1519         Reviewed by Darin Adler.
1520
1521         * Misc/WebKitVersionChecks.mm:
1522         (setWebKitLinkTimeVersion):
1523         (WebKitLinkTimeVersion):
1524         * Plugins/WebBaseNetscapePluginView.mm:
1525         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1526         * WebCoreSupport/PopupMenuMac.mm:
1527         (PopupMenuMac::populate):
1528
1529 2018-08-01  Nan Wang  <n_wang@apple.com>
1530
1531         AX: AOM: Add ARIA IDL Attribute Reflection
1532         https://bugs.webkit.org/show_bug.cgi?id=184676
1533         <rdar://problem/39476882>
1534
1535         Reviewed by Chris Fleizach.
1536
1537         * WebView/WebPreferenceKeysPrivate.h:
1538         * WebView/WebPreferences.mm:
1539         (+[WebPreferences initialize]):
1540         (-[WebPreferences ariaReflectionEnabled]):
1541         (-[WebPreferences setAriaReflectionEnabled:]):
1542         * WebView/WebPreferencesPrivate.h:
1543         * WebView/WebView.mm:
1544         (-[WebView _preferencesChanged:]):
1545
1546 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1547
1548         Shrink GraphicsLayerCA
1549         https://bugs.webkit.org/show_bug.cgi?id=188141
1550
1551         Reviewed by Zalan Bujtas.
1552
1553         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1554         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1555         * moving all the animation-related stuff into the lazily-allocated m_animations
1556         * making enums be 8-bit
1557         * re-ordering data members
1558
1559         * WebView/WebView.mm:
1560         (-[WebView _setMediaLayer:forPluginView:]):
1561
1562 2018-07-30  Rob Buis  <rbuis@igalia.com>
1563
1564         Merge PlatformCookieJar functions into NetworkStorageSession
1565         https://bugs.webkit.org/show_bug.cgi?id=188137
1566
1567         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1568
1569         Reviewed by Alex Christensen.
1570
1571         * WebCoreSupport/WebPlatformStrategies.mm:
1572         (WebPlatformStrategies::cookiesForDOM):
1573         (WebPlatformStrategies::setCookiesFromDOM):
1574         (WebPlatformStrategies::cookiesEnabled):
1575         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1576         (WebPlatformStrategies::getRawCookies):
1577         (WebPlatformStrategies::deleteCookie):
1578         * WebView/WebPreferences.mm:
1579         (+[WebPreferences _clearNetworkLoaderSession]):
1580
1581 2018-07-28  Darin Adler  <darin@apple.com>
1582
1583         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1584         https://bugs.webkit.org/show_bug.cgi?id=188140
1585
1586         Reviewed by Sam Weinig.
1587
1588         * WebView/WebImmediateActionController.mm:
1589         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1590         new DictionaryLookup function that returns a tuple instead of using an out argument.
1591
1592 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1593
1594         [INTL] Remove INTL sub-feature compile flags
1595         https://bugs.webkit.org/show_bug.cgi?id=188081
1596
1597         Reviewed by Michael Catanzaro.
1598
1599         * Configurations/FeatureDefines.xcconfig:
1600
1601 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1602
1603         Unreviewed, rolling out r234181 and r234189.
1604         https://bugs.webkit.org/show_bug.cgi?id=188075
1605
1606         These are not needed right now (Requested by thorton on
1607         #webkit).
1608
1609         Reverted changesets:
1610
1611         "Enable Web Content Filtering on watchOS"
1612         https://bugs.webkit.org/show_bug.cgi?id=187979
1613         https://trac.webkit.org/changeset/234181
1614
1615         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1616         https://bugs.webkit.org/show_bug.cgi?id=187985
1617         https://trac.webkit.org/changeset/234189
1618
1619 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1620
1621         Use the Page's appearance when converting pasteboard attributed strings.
1622         https://bugs.webkit.org/show_bug.cgi?id=188067
1623         rdar://problem/42632246
1624
1625         Reviewed by Wenson Hsieh.
1626
1627         * WebCoreSupport/WebEditorClient.mm:
1628         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1629
1630 2018-07-25  Chris Dumez  <cdumez@apple.com>
1631
1632         navigator.userAgent may return outdated value after webView.customUserAgent is set
1633         https://bugs.webkit.org/show_bug.cgi?id=188009
1634         <rdar://problem/42566456>
1635
1636         Reviewed by Alex Christensen.
1637
1638         Let the page know when the user agent changes.
1639
1640         * WebView/WebView.mm:
1641         (-[WebView _preferencesChanged:]):
1642         (-[WebView setApplicationNameForUserAgent:]):
1643         (-[WebView _invalidateUserAgentCache]):
1644         (-[WebView setCustomUserAgent:]):
1645         * WebView/WebViewInternal.h:
1646
1647 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1648
1649         Enable Web Content Filtering on watchOS
1650         https://bugs.webkit.org/show_bug.cgi?id=187979
1651         <rdar://problem/42559346>
1652
1653         Reviewed by Wenson Hsieh.
1654
1655         * Configurations/FeatureDefines.xcconfig:
1656
1657 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1658
1659         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1660         https://bugs.webkit.org/show_bug.cgi?id=187846
1661
1662         Reviewed by Simon Fraser.
1663
1664         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1665
1666         * WebView/WebHTMLView.mm:
1667         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1668         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1669
1670 2018-07-11  Dean Jackson  <dino@apple.com>
1671
1672         Allow removal of white backgrounds
1673         https://bugs.webkit.org/show_bug.cgi?id=187574
1674         <rdar://problem/41146792>
1675
1676         Reviewed by Simon Fraser.
1677
1678         Add a new WebPreference for punching out white backgrounds.
1679
1680         * WebView/WebPreferenceKeysPrivate.h:
1681         * WebView/WebPreferences.mm:
1682         (+[WebPreferences initialize]):
1683         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1684         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1685         * WebView/WebPreferencesPrivate.h:
1686         * WebView/WebView.mm:
1687         (-[WebView _preferencesChanged:]):
1688
1689 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1690
1691         Ensure WebKit stack is ad-hoc signed
1692         https://bugs.webkit.org/show_bug.cgi?id=187667
1693
1694         Reviewed by Alexey Proskuryakov.
1695
1696         * Configurations/Base.xcconfig:
1697
1698 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1699
1700         REGRESSION (231276): Attempting to copy an image fails
1701         https://bugs.webkit.org/show_bug.cgi?id=187212
1702         <rdar://problem/41540074>
1703
1704         Reviewed by Ryosuke Niwa.
1705
1706         Renamed methods to make it clear that one URL and one title are being passed in.
1707
1708         * WebCoreSupport/WebPlatformStrategies.h:
1709         * WebCoreSupport/WebPlatformStrategies.mm:
1710         (WebPlatformStrategies::setURL):
1711
1712 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1713
1714         Disable cross-origin-window-policy by default
1715         https://bugs.webkit.org/show_bug.cgi?id=187509
1716
1717         Reviewed by Chris Dumez.
1718
1719         * WebView/WebPreferences.mm:
1720         (+[WebPreferences initialize]):
1721
1722 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1723
1724         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1725         https://bugs.webkit.org/show_bug.cgi?id=187425
1726         rdar://problem/39948240
1727
1728         Reviewed by Tim Horton.
1729
1730         * WebView/WebView.mm:
1731         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1732         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1733         a call in this method to setUseDarkAppearance.
1734         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1735         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1736         (-[WebView _updateDefaultAppearance]): Deleted.
1737         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1738
1739 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1740
1741         Shrink various loading-related enums to shrink CachedResource
1742         https://bugs.webkit.org/show_bug.cgi?id=187443
1743
1744         Reviewed by Chris Dumez.
1745
1746         * WebCoreSupport/WebFrameLoaderClient.mm:
1747         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1748         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1749         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1750         (WebFrameLoaderClient::dispatchWillSendRequest):
1751         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1752         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1753         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1754         (WebFrameLoaderClient::updateGlobalHistory):
1755         (WebFrameLoaderClient::canHandleRequest const):
1756         * WebView/WebDataSource.mm:
1757         (-[WebDataSource initialRequest]):
1758         (-[WebDataSource request]):
1759
1760 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1761
1762         Unreviewed, rolling out r233612.
1763         https://bugs.webkit.org/show_bug.cgi?id=187475
1764
1765         Revision caused the api test LinkColorWithSystemAppearance to
1766         fail on all systems. (Requested by Truitt on #webkit).
1767
1768         Reverted changeset:
1769
1770         "Semantic colors don't update when accessibility Increase
1771         Contrast mode is enabled."
1772         https://bugs.webkit.org/show_bug.cgi?id=187425
1773         https://trac.webkit.org/changeset/233612
1774
1775 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1776
1777         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1778         https://bugs.webkit.org/show_bug.cgi?id=187425
1779         rdar://problem/39948240
1780
1781         Reviewed by Tim Horton.
1782
1783         * WebView/WebView.mm:
1784         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1785         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1786         a call in this method to setUseDarkAppearance.
1787         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1788         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1789         (-[WebView _updateDefaultAppearance]): Deleted.
1790         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1791
1792 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1793
1794         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1795         https://bugs.webkit.org/show_bug.cgi?id=187369
1796         rdar://problem/41870420
1797
1798         Reviewed by Tim Horton.
1799
1800         * WebView/WebMediaPlaybackTargetPicker.mm:
1801         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1802         * WebView/WebView.mm:
1803         (-[WebView _commonInitializationWithFrameName:groupName:]):
1804         (-[WebView _effectiveAppearanceIsDark]):
1805         (-[WebView _updateDefaultAppearance]):
1806         (-[WebView _defaultAppearance]): Deleted.
1807
1808 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1809
1810         Youtube video pages crash after a couple of minutes
1811         https://bugs.webkit.org/show_bug.cgi?id=187316
1812
1813         Reviewed by Antti Koivisto.
1814
1815         * WebView/WebView.mm:
1816         (-[WebView _preferencesChanged:]):
1817
1818 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1819
1820         Introduce PLATFORM(IOSMAC)
1821         https://bugs.webkit.org/show_bug.cgi?id=187315
1822
1823         Reviewed by Dan Bernstein.
1824
1825         * Configurations/Base.xcconfig:
1826         * Configurations/FeatureDefines.xcconfig:
1827
1828 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1829
1830         [iOS] DataTransfer.getData always returns the empty string when dropping text
1831         https://bugs.webkit.org/show_bug.cgi?id=187130
1832         <rdar://problem/41014117>
1833
1834         Reviewed by Ryosuke Niwa.
1835
1836         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1837
1838         * WebCoreSupport/WebPlatformStrategies.h:
1839         * WebCoreSupport/WebPlatformStrategies.mm:
1840         (WebPlatformStrategies::allPasteboardItemInfo):
1841
1842 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1843
1844         [Mac] AirPlay picker uses incorrect theme in Dark mode
1845         https://bugs.webkit.org/show_bug.cgi?id=187054
1846         <rdar://problem/41291093>
1847
1848         Reviewed by Timothy Hatcher.
1849
1850         * WebView/WebMediaPlaybackTargetPicker.mm:
1851         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1852
1853 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1854
1855         [WTF] Add user-defined literal for ASCIILiteral
1856         https://bugs.webkit.org/show_bug.cgi?id=186839
1857
1858         Reviewed by Darin Adler.
1859
1860         * DOM/ExceptionHandlers.mm:
1861         (raiseDOMErrorException):
1862         * Plugins/Hosted/ProxyInstance.mm:
1863         (WebKit::ProxyInstance::invokeMethod):
1864         * Storage/WebDatabaseProvider.mm:
1865         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1866
1867 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1868
1869         Recalc styles every time defaultAppearance changes.
1870         https://bugs.webkit.org/show_bug.cgi?id=186866
1871         rdar://problem/41309805
1872
1873         Reviewed by Tim Horton.
1874
1875         * WebView/WebView.mm:
1876         (-[WebView _updateDefaultAppearance]):
1877         (-[WebView _setUseSystemAppearance:]):
1878         (-[WebView _useSystemAppearance]):
1879
1880 2018-06-20  Darin Adler  <darin@apple.com>
1881
1882         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1883         https://bugs.webkit.org/show_bug.cgi?id=186875
1884
1885         Reviewed by Anders Carlsson.
1886
1887         * WebView/WebHTMLView.mm:
1888         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1889         to write te file to.
1890         * WebView/WebPreferences.mm:
1891         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1892         * WebView/WebView.mm:
1893         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1894
1895 2018-06-12  Darin Adler  <darin@apple.com>
1896
1897         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1898         https://bugs.webkit.org/show_bug.cgi?id=186526
1899
1900         Reviewed by Anders Carlsson.
1901
1902         * Plugins/Hosted/NetscapePluginHostManager.mm:
1903         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1904
1905         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1906         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1907         assignment rather than adoptNS/leakRef.
1908         * Plugins/WebNetscapePluginView.mm:
1909         (-[WebNetscapePluginView createPlugin]): Ditto.
1910
1911         * WebCoreSupport/WebContextMenuClient.mm:
1912         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1913         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1914         argument, so use RetainPtr::get instead.
1915
1916         * WebView/WebHTMLView.mm:
1917         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1918         No need to autorelease the result when the return type is RetainPtr.
1919
1920         * WebView/WebPDFRepresentation.mm:
1921         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1922
1923 2018-06-13  Youenn Fablet  <youenn@apple.com>
1924
1925         Supported plugin check should be based on plugin identifier
1926         https://bugs.webkit.org/show_bug.cgi?id=186578
1927         <rdar://problem/40523828>
1928
1929         Reviewed by Darin Adler.
1930
1931         * WebCoreSupport/WebPluginInfoProvider.h:
1932         * WebCoreSupport/WebPluginInfoProvider.mm:
1933         (WebPluginInfoProvider::pluginInfo):
1934         (WebPluginInfoProvider::webVisiblePluginInfo):
1935
1936 2018-06-13  Chris Dumez  <cdumez@apple.com>
1937
1938         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1939         https://bugs.webkit.org/show_bug.cgi?id=186545
1940
1941         Reviewed by Brady Eidson.
1942
1943         Update client delegate now that parameter type has changed.
1944
1945         * WebCoreSupport/WebFrameLoaderClient.h:
1946         * WebCoreSupport/WebFrameLoaderClient.mm:
1947         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1948
1949 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1950
1951         Link drag image is inconsistently unreadable in dark mode
1952         https://bugs.webkit.org/show_bug.cgi?id=186472
1953
1954         Reviewed by Timothy Hatcher.
1955
1956         * WebView/WebView.mm:
1957         (-[WebView _defaultAppearance]):
1958         Make defaultAppearance accurate even if useSystemAppearance is false.
1959         Some parts of WebKit (like the link drag image, but also context menus)
1960         want to be able to follow the system appearance regardless of whether
1961         the view or content has opted in.
1962
1963 2018-06-11  Chris Dumez  <cdumez@apple.com>
1964
1965         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1966         https://bugs.webkit.org/show_bug.cgi?id=186441
1967
1968         Reviewed by Brady Eidson.
1969
1970         Rename existing flag to something a bit more generic, now that it is used for
1971         more things than bypassing the navigation policy check.
1972
1973         * WebView/WebView.mm:
1974         (-[WebView _loadBackForwardListFromOtherView:]):
1975         (-[WebView goToBackForwardItem:]):
1976
1977 2018-06-09  Dan Bernstein  <mitz@apple.com>
1978
1979         [Xcode] Clean up and modernize some build setting definitions
1980         https://bugs.webkit.org/show_bug.cgi?id=186463
1981
1982         Reviewed by Sam Weinig.
1983
1984         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1985         * Configurations/DebugRelease.xcconfig: Ditto.
1986         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1987           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1988         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1989         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1990           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1991         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1992
1993 2018-06-08  Darin Adler  <darin@apple.com>
1994
1995         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1996         https://bugs.webkit.org/show_bug.cgi?id=186436
1997
1998         Reviewed by Anders Carlsson.
1999
2000         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2001         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2002         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2003         (PoolCleaner): Ditto.
2004
2005         * History/WebHistory.mm:
2006         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2007         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2008         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2009         now hardly used if at all.
2010         * WebView/WebView.mm:
2011         (-[WebView rectsForTextMatches]): Ditto.
2012
2013 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2014
2015         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2016         https://bugs.webkit.org/show_bug.cgi?id=186442
2017         <rdar://problem/40879364>
2018
2019         Reviewed by Tim Horton.
2020
2021         * Configurations/FeatureDefines.xcconfig:
2022
2023 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2024
2025         [Datalist] Allow TextFieldInputType to show and hide suggestions
2026         https://bugs.webkit.org/show_bug.cgi?id=186151
2027
2028         Reviewed by Tim Horton.
2029
2030         * WebCoreSupport/WebChromeClient.h:
2031         * WebCoreSupport/WebChromeClient.mm:
2032         (WebChromeClient::createDataListSuggestionPicker):
2033
2034 2018-06-07  Chris Dumez  <cdumez@apple.com>
2035
2036         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2037         https://bugs.webkit.org/show_bug.cgi?id=186407
2038
2039         Reviewed by Brent Fulgham.
2040
2041         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2042         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2043         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2044         makeWeakPtr().
2045
2046         * WebCoreSupport/WebEditorClient.h:
2047         * WebCoreSupport/WebEditorClient.mm:
2048         (WebEditorClient::requestCandidatesForSelection):
2049
2050 2018-06-05  Chris Dumez  <cdumez@apple.com>
2051
2052         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2053         https://bugs.webkit.org/show_bug.cgi?id=186331
2054         <rdar://problem/40735446>
2055
2056         Reviewed by Darin Adler.
2057
2058         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2059         but does not call use / ignore on the listener, then we would do "use" by default.
2060         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2061         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2062         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2063         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2064         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2065         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2066         and Box.app is still working properly.
2067
2068         * WebCoreSupport/WebFrameLoaderClient.h:
2069         * WebCoreSupport/WebFrameLoaderClient.mm:
2070         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2071         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2072         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2073         (WebFrameLoaderClient::dispatchWillSubmitForm):
2074         (WebFrameLoaderClient::setUpPolicyListener):
2075         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2076         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2077         (-[WebFramePolicyListener dealloc]):
2078         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2079         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2080
2081 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2082
2083         Adjust compile and runtime flags to match shippable state of features
2084         https://bugs.webkit.org/show_bug.cgi?id=186319
2085         <rdar://problem/40352045>
2086
2087         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2088
2089         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2090         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2091         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2092         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2093         Cocoa builds.
2094
2095 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2096
2097         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2098
2099         https://bugs.webkit.org/show_bug.cgi?id=186323
2100         rdar://problem/38382252
2101
2102         Reviewed by Tim Horton.
2103
2104         * WebView/WebView.mm:
2105         (-[WebView _defaultAppearance]):
2106
2107 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2108
2109         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2110         https://bugs.webkit.org/show_bug.cgi?id=186286
2111         <rdar://problem/40782992>
2112
2113         Reviewed by Dan Bernstein.
2114
2115         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2116         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2117         change this flag when preparing for a production release.
2118
2119         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2120         whether experimental features should be enabled, and use it to properly define the
2121         feature flag.
2122
2123 2018-06-03  Darin Adler  <darin@apple.com>
2124
2125         Simplify and remove some unused video element code (helpful for ARC-compatibility)
2126         https://bugs.webkit.org/show_bug.cgi?id=186258
2127
2128         Reviewed by Daniel Bates.
2129
2130         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2131         forward declarations. Removed methods that don't need to be public.
2132
2133         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2134         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2135         unnamed category in here and also replaced the HUDWindowControllerDelegate
2136         with the unnamed category. Removed unused NSWindow category defining the
2137         isOnActiveSpace, which is not called anywhere in this file at this time.
2138         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2139         into setVideoElement.
2140         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2141         and removed unneeded typecast.
2142         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2143         using statement at the top of the file.
2144         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2145         the many side effects and special considerations that this method that sounds
2146         like a setter has. Updated code to use the new
2147         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2148         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2149         bit and added some FIXME comments about small problems noticed but not fixed.
2150         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2151         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2152         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2153         typecast. Removed call to updatePowerAssertions method.
2154         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2155         updatePowerAssertions method.
2156         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2157         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2158         else, so this was dead code that did nothing.
2159         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2160         updatePowerAssertions method.
2161
2162 2018-06-04  Chris Dumez  <cdumez@apple.com>
2163
2164         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2165         https://bugs.webkit.org/show_bug.cgi?id=186287
2166         <rdar://problem/40783352>
2167
2168         Reviewed by Youenn Fablet.
2169
2170         * WebView/WebPreferenceKeysPrivate.h:
2171         * WebView/WebPreferences.mm:
2172         (+[WebPreferences initialize]):
2173         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2174         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2175         * WebView/WebPreferencesPrivate.h:
2176         * WebView/WebView.mm:
2177         (-[WebView _preferencesChanged:]):
2178
2179 2018-06-02  Darin Adler  <darin@apple.com>
2180
2181         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2182         https://bugs.webkit.org/show_bug.cgi?id=186227
2183
2184         Reviewed by Dan Bernstein.
2185
2186         * Misc/WebKitErrors.m:
2187         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2188         * Plugins/WebPluginDatabase.mm:
2189         (-[WebPluginDatabase refresh]): Ditto.
2190         * WebCoreSupport/WebChromeClient.mm:
2191         (WebChromeClient::setStatusbarText): Ditto.
2192
2193 2018-06-01  Chris Dumez  <cdumez@apple.com>
2194
2195         REGRESSION (r231456): Colloquy is broken
2196         https://bugs.webkit.org/show_bug.cgi?id=186197
2197         <rdar://problem/40722960>
2198
2199         Reviewed by Timothy Hatcher.
2200
2201         Restore pre-r231456 behavior for Colloquy app so that it works again.
2202
2203         * WebView/WebView.mm:
2204         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2205         (-[WebView _preferencesChanged:]):
2206
2207 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2208
2209         [JSC] Pass VM& parameter as much as possible
2210         https://bugs.webkit.org/show_bug.cgi?id=186085
2211
2212         Reviewed by Saam Barati.
2213
2214         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2215         (WebKit::NetscapePluginInstanceProxy::invoke):
2216
2217 2018-05-30  Daniel Bates  <dabates@apple.com>
2218
2219         NavigationAction does not need to hold initiating DOM Event
2220         https://bugs.webkit.org/show_bug.cgi?id=185958
2221         <rdar://problem/40531539>
2222
2223         Reviewed by Simon Fraser.
2224
2225         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2226
2227         * WebCoreSupport/WebFrameLoaderClient.mm:
2228         (WebFrameLoaderClient::actionDictionary const):
2229         (findMouseEvent): Deleted.
2230
2231 2018-05-27  Dan Bernstein  <mitz@apple.com>
2232
2233         Reverted the changes made for https://webkit.org/b/186016
2234
2235         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2236
2237
2238 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2239
2240         [iOS] Fix warnings about leaks found by clang static analyzer
2241         <https://webkit.org/b/186009>
2242         <rdar://problem/40574267>
2243
2244         Reviewed by Daniel Bates.
2245
2246         * WebView/WebHTMLView.mm:
2247         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2248         uninitialized boolean variable (`eventWasHandled`) that only
2249         happened on iOS.
2250
2251 2018-05-27  Dan Bernstein  <mitz@apple.com>
2252
2253         [Cocoa] Avoid importing directly from subumbrella frameworks
2254         https://bugs.webkit.org/show_bug.cgi?id=186016
2255
2256         Reviewed by Sam Weinig.
2257
2258         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2259         * Carbon/CarbonWindowAdapter.mm: Ditto.
2260         * Carbon/CarbonWindowFrame.m: Ditto.
2261         * Carbon/HIViewAdapter.h: Ditto.
2262         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2263           OTHER_CPLUSPLUSFLAGS.
2264         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2265         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2266         * WebView/WebPDFView.h: Ditto.
2267
2268 2018-05-27  Sam Weinig  <sam@webkit.org>
2269
2270         Modernize RenderStyleConstants.h - Part 3
2271         https://bugs.webkit.org/show_bug.cgi?id=186015
2272
2273         Reviewed by Yusuke Suzuki.
2274
2275         * WebView/WebView.mm:
2276         (-[WebView updateTextTouchBar]):
2277         Update for new enum name.
2278
2279 2018-05-25  Chris Dumez  <cdumez@apple.com>
2280
2281         Minor ApplicationCacheStorage clean up
2282         https://bugs.webkit.org/show_bug.cgi?id=185984
2283
2284         Reviewed by Youenn Fablet.
2285
2286         * WebCoreSupport/WebApplicationCache.mm:
2287         (+[WebApplicationCache originsWithCache]):
2288
2289 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2290
2291         Fix issues with -dealloc methods found by clang static analyzer
2292         <https://webkit.org/b/185887>
2293
2294         Reviewed by Joseph Pecoraro.
2295
2296         * WebView/WebView.mm:
2297         (-[WebUITextIndicatorData dealloc]):
2298         - Move method implementation from (WebUITextIndicatorInternal)
2299           category to the main category since this is public API.  This
2300           fixes the false positive warning about a missing -dealloc
2301           method.
2302
2303 2018-05-24  Sam Weinig  <sam@webkit.org>
2304
2305         Modernize RenderStyleConstants.h - Part 2
2306         https://bugs.webkit.org/show_bug.cgi?id=185901
2307
2308         Reviewed by Simon Fraser.
2309
2310         * WebView/WebHTMLRepresentation.mm:
2311         (searchForLabelsBeforeElement):
2312         * WebView/WebView.mm:
2313         (nsTextAlignmentFromRenderStyle):
2314         Update for new enum names.
2315
2316 2018-05-22  Chris Dumez  <cdumez@apple.com>
2317
2318         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2319         https://bugs.webkit.org/show_bug.cgi?id=185832
2320         <rdar://problem/40307871>
2321
2322         Reviewed by Geoffrey Garen.
2323
2324         We used to have a bug where where we would fail to wait for the policy decision for
2325         the navigation response from the client and the load would keep going, racing with
2326         the client's policy decision. If the client did not respond in time, the behavior
2327         would be the same as "Use" policy action.
2328
2329         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2330         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2331         WebKit bug, however, the load would hang because the completion handler for the
2332         decidePolicyForNavigationResponse would never get called.
2333
2334         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2335         instead of retaining it. If the policy listener object gets destroyed because getting
2336         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2337         behavior.
2338
2339         * WebCoreSupport/WebFrameLoaderClient.h:
2340         * WebCoreSupport/WebFrameLoaderClient.mm:
2341         (WebFrameLoaderClient::cancelPolicyCheck):
2342         (WebFrameLoaderClient::setUpPolicyListener):
2343         (-[WebFramePolicyListener dealloc]):
2344
2345 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2346
2347         Unreviewed, rolling out r232052.
2348
2349         Breaks internal builds.
2350
2351         Reverted changeset:
2352
2353         "Use more C++17"
2354         https://bugs.webkit.org/show_bug.cgi?id=185176
2355         https://trac.webkit.org/changeset/232052
2356
2357 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2358
2359         Use more C++17
2360         https://bugs.webkit.org/show_bug.cgi?id=185176
2361
2362         Reviewed by JF Bastien.
2363
2364         * Configurations/Base.xcconfig:
2365         * Configurations/WebKitLegacy.xcconfig:
2366
2367 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2368
2369         Remove dead exception in MediaList.appendMedium
2370         https://bugs.webkit.org/show_bug.cgi?id=185278
2371
2372         Reviewed by Chris Dumez.
2373
2374         Remove code pertaining to an exception being thrown by appendMedium().
2375
2376         * DOM/DOMMediaList.mm:
2377         (-[DOMMediaList appendMedium:]):
2378
2379 2018-05-21  Jer Noble  <jer.noble@apple.com>
2380
2381         Complete fix for enabling modern EME by default
2382         https://bugs.webkit.org/show_bug.cgi?id=185770
2383         <rdar://problem/40368220>
2384
2385         Reviewed by Eric Carlson.
2386
2387         * Configurations/FeatureDefines.xcconfig:
2388
2389 2018-05-21  Antti Koivisto  <antti@apple.com>
2390
2391         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2392         https://bugs.webkit.org/show_bug.cgi?id=185815
2393         <rdar://problem/40310069>
2394
2395         Reviewed by Simon Fraser.
2396
2397         User stylesheet parsing may depend on the colorFilterEnabled preference.
2398
2399         * WebView/WebView.mm:
2400         (-[WebView _preferencesChanged:]):
2401
2402 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2403
2404         Unreviewed, rolling out r231982.
2405         https://bugs.webkit.org/show_bug.cgi?id=185793
2406
2407         Caused layout test failures (Requested by realdawei on
2408         #webkit).
2409
2410         Reverted changeset:
2411
2412         "Complete fix for enabling modern EME by default"
2413         https://bugs.webkit.org/show_bug.cgi?id=185770
2414         https://trac.webkit.org/changeset/231982
2415
2416 2018-05-18  Jer Noble  <jer.noble@apple.com>
2417
2418         Complete fix for enabling modern EME by default
2419         https://bugs.webkit.org/show_bug.cgi?id=185770
2420         <rdar://problem/40368220>
2421
2422         Reviewed by Eric Carlson.
2423
2424         * Configurations/FeatureDefines.xcconfig:
2425
2426 2018-05-18  Chris Dumez  <cdumez@apple.com>
2427
2428         Avoid keeping the frame alive when ref'ing a WindowProxy
2429         https://bugs.webkit.org/show_bug.cgi?id=185737
2430         <rdar://problem/40004666>
2431
2432         Reviewed by Sam Weinig.
2433
2434         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2435         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2436
2437 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2438
2439         Add support for Intl NumberFormat formatToParts
2440         https://bugs.webkit.org/show_bug.cgi?id=185375
2441
2442         Reviewed by Yusuke Suzuki.
2443
2444         Add flag for NumberFormat formatToParts.
2445
2446         * Configurations/FeatureDefines.xcconfig:
2447
2448 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2449
2450         Fixup after r231849: Do not mark Mac API methods as deprecated
2451         https://bugs.webkit.org/show_bug.cgi?id=185684
2452
2453         Reviewed by Darin Adler.
2454
2455         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2456         as the entire class is already marked as deprecated, so it is unnecessary.
2457
2458         * DOM/DOMDocument.h:
2459
2460 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2461
2462         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2463         https://bugs.webkit.org/show_bug.cgi?id=185381
2464
2465         Reviewed by Darin Adler.
2466
2467         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2468         and make them do nothing.
2469
2470         * DOM/DOMDocument.h:
2471         * DOM/DOMDocument.mm:
2472         (-[DOMDocument preferredStylesheetSet]):
2473         (-[DOMDocument selectedStylesheetSet]):
2474         (-[DOMDocument setSelectedStylesheetSet:]):
2475
2476 2018-05-15  Antoine Quint  <graouts@apple.com>
2477
2478         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2479         https://bugs.webkit.org/show_bug.cgi?id=185647
2480
2481         Reviewed by Dean Jackson.
2482
2483         Rename the Web Animations CSS integration flag.
2484
2485         * WebView/WebPreferenceKeysPrivate.h:
2486         * WebView/WebPreferences.mm:
2487         (+[WebPreferences initialize]):
2488         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2489         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2490         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2491         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2492         * WebView/WebPreferencesPrivate.h:
2493         * WebView/WebView.mm:
2494         (-[WebView _preferencesChanged:]):
2495
2496 2018-05-14  Daniel Bates  <dabates@apple.com>
2497
2498         Fix the Apple Internal build
2499
2500         See <rdar://problem/40237873> for more details.
2501
2502         * WebView/WebFullScreenController.mm:
2503         (-[WebFullScreenController enterFullScreen:]):
2504         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2505         (-[WebFullScreenController exitFullScreen]):
2506         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2507         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2508         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2509
2510 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2511
2512         WebHTMLView is not setting aside subviews when drawing.
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=185561
2515         rdar://problem/40172894
2516
2517         Reviewed by Simon Fraser.
2518
2519         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2520
2521         * WebView/WebHTMLView.mm:
2522         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2523
2524 2018-05-07  Daniel Bates  <dabates@apple.com>
2525
2526         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2527         https://bugs.webkit.org/show_bug.cgi?id=185170
2528
2529         Reviewed by Per Arne Vollan.
2530
2531         * Misc/WebCache.mm:
2532         (+[WebCache empty]):
2533
2534 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2535
2536         Deprecate legacy WebView and friends
2537         https://bugs.webkit.org/show_bug.cgi?id=185279
2538         rdar://problem/33268700
2539
2540         Reviewed by Tim Horton.
2541
2542         Added deprecation macros to all the classes, extern strings, and enums.
2543
2544         * Configurations/WebKitLegacy.xcconfig:
2545         Added BUILDING_WEBKIT define to disable the deprecation macros.
2546         * DOM/DOMAbstractView.h:
2547         * DOM/DOMAttr.h:
2548         * DOM/DOMBlob.h:
2549         * DOM/DOMCDATASection.h:
2550         * DOM/DOMCSSCharsetRule.h:
2551         * DOM/DOMCSSFontFaceRule.h:
2552         * DOM/DOMCSSImportRule.h:
2553         * DOM/DOMCSSMediaRule.h:
2554         * DOM/DOMCSSPageRule.h:
2555         * DOM/DOMCSSPrimitiveValue.h:
2556         * DOM/DOMCSSRule.h:
2557         * DOM/DOMCSSRuleList.h:
2558         * DOM/DOMCSSStyleDeclaration.h:
2559         * DOM/DOMCSSStyleRule.h:
2560         * DOM/DOMCSSStyleSheet.h:
2561         * DOM/DOMCSSUnknownRule.h:
2562         * DOM/DOMCSSValue.h:
2563         * DOM/DOMCSSValueList.h:
2564         * DOM/DOMCharacterData.h:
2565         * DOM/DOMComment.h:
2566         * DOM/DOMCounter.h:
2567         * DOM/DOMDocument.h:
2568         * DOM/DOMDocumentFragment.h:
2569         * DOM/DOMDocumentType.h:
2570         * DOM/DOMElement.h:
2571         * DOM/DOMEntity.h:
2572         * DOM/DOMEntityReference.h:
2573         * DOM/DOMEvent.h:
2574         * DOM/DOMEventException.h:
2575         * DOM/DOMEventListener.h:
2576         * DOM/DOMEventTarget.h:
2577         * DOM/DOMException.h:
2578         * DOM/DOMFile.h:
2579         * DOM/DOMFileList.h:
2580         * DOM/DOMHTMLAnchorElement.h:
2581         * DOM/DOMHTMLAppletElement.h:
2582         * DOM/DOMHTMLAreaElement.h:
2583         * DOM/DOMHTMLBRElement.h:
2584         * DOM/DOMHTMLBaseElement.h:
2585         * DOM/DOMHTMLBaseFontElement.h:
2586         * DOM/DOMHTMLBodyElement.h:
2587         * DOM/DOMHTMLButtonElement.h:
2588         * DOM/DOMHTMLCanvasElement.h:
2589         * DOM/DOMHTMLCollection.h:
2590         * DOM/DOMHTMLDListElement.h:
2591         * DOM/DOMHTMLDirectoryElement.h:
2592         * DOM/DOMHTMLDivElement.h:
2593         * DOM/DOMHTMLDocument.h:
2594         * DOM/DOMHTMLElement.h:
2595         * DOM/DOMHTMLEmbedElement.h:
2596         * DOM/DOMHTMLFieldSetElement.h:
2597         * DOM/DOMHTMLFontElement.h:
2598         * DOM/DOMHTMLFormElement.h:
2599         * DOM/DOMHTMLFrameElement.h:
2600         * DOM/DOMHTMLFrameSetElement.h:
2601         * DOM/DOMHTMLHRElement.h:
2602         * DOM/DOMHTMLHeadElement.h:
2603         * DOM/DOMHTMLHeadingElement.h:
2604         * DOM/DOMHTMLHtmlElement.h:
2605         * DOM/DOMHTMLIFrameElement.h:
2606         * DOM/DOMHTMLImageElement.h:
2607         * DOM/DOMHTMLInputElement.h:
2608         * DOM/DOMHTMLLIElement.h:
2609         * DOM/DOMHTMLLabelElement.h:
2610         * DOM/DOMHTMLLegendElement.h:
2611         * DOM/DOMHTMLLinkElement.h:
2612         * DOM/DOMHTMLMapElement.h:
2613         * DOM/DOMHTMLMarqueeElement.h:
2614         * DOM/DOMHTMLMediaElement.h:
2615         * DOM/DOMHTMLMenuElement.h:
2616         * DOM/DOMHTMLMetaElement.h:
2617         * DOM/DOMHTMLModElement.h:
2618         * DOM/DOMHTMLOListElement.h:
2619         * DOM/DOMHTMLObjectElement.h:
2620         * DOM/DOMHTMLOptGroupElement.h:
2621         * DOM/DOMHTMLOptionElement.h:
2622         * DOM/DOMHTMLOptionsCollection.h:
2623         * DOM/DOMHTMLParagraphElement.h:
2624         * DOM/DOMHTMLParamElement.h:
2625         * DOM/DOMHTMLPreElement.h:
2626         * DOM/DOMHTMLQuoteElement.h:
2627         * DOM/DOMHTMLScriptElement.h:
2628         * DOM/DOMHTMLSelectElement.h:
2629         * DOM/DOMHTMLStyleElement.h:
2630         * DOM/DOMHTMLTableCaptionElement.h:
2631         * DOM/DOMHTMLTableCellElement.h:
2632         * DOM/DOMHTMLTableColElement.h:
2633         * DOM/DOMHTMLTableElement.h:
2634         * DOM/DOMHTMLTableRowElement.h:
2635         * DOM/DOMHTMLTableSectionElement.h:
2636         * DOM/DOMHTMLTextAreaElement.h:
2637         * DOM/DOMHTMLTitleElement.h:
2638         * DOM/DOMHTMLUListElement.h:
2639         * DOM/DOMHTMLVideoElement.h:
2640         * DOM/DOMImplementation.h:
2641         * DOM/DOMKeyboardEvent.h:
2642         * DOM/DOMMediaError.h:
2643         * DOM/DOMMediaList.h:
2644         * DOM/DOMMouseEvent.h:
2645         * DOM/DOMMutationEvent.h:
2646         * DOM/DOMNamedNodeMap.h:
2647         * DOM/DOMNode.h:
2648         * DOM/DOMNodeFilter.h:
2649         * DOM/DOMNodeIterator.h:
2650         * DOM/DOMNodeList.h:
2651         * DOM/DOMObject.h:
2652         * DOM/DOMOverflowEvent.h:
2653         * DOM/DOMProcessingInstruction.h:
2654         * DOM/DOMProgressEvent.h:
2655         * DOM/DOMRGBColor.h:
2656         * DOM/DOMRange.h:
2657         * DOM/DOMRangeException.h:
2658         * DOM/DOMRect.h:
2659         * DOM/DOMStyleSheet.h:
2660         * DOM/DOMStyleSheetList.h:
2661         * DOM/DOMText.h:
2662         * DOM/DOMTextEvent.h:
2663         * DOM/DOMTimeRanges.h:
2664         * DOM/DOMTokenList.h:
2665         * DOM/DOMTreeWalker.h:
2666         * DOM/DOMUIEvent.h:
2667         * DOM/DOMWheelEvent.h:
2668         * DOM/DOMXPathException.h:
2669         * DOM/DOMXPathExpression.h:
2670         * DOM/DOMXPathNSResolver.h:
2671         * DOM/DOMXPathResult.h:
2672         * History/WebBackForwardList.h:
2673         * History/WebHistory.h:
2674         * History/WebHistoryItem.h:
2675         * Misc/WebDownload.h:
2676         * Misc/WebKitErrors.h:
2677         * Plugins/WebPluginViewFactory.h:
2678         * WebView/WebArchive.h:
2679         * WebView/WebDataSource.h:
2680         * WebView/WebDocument.h:
2681         * WebView/WebEditingDelegate.h:
2682         * WebView/WebFormDelegate.h:
2683         * WebView/WebFrame.h:
2684         * WebView/WebFrameLoadDelegate.h:
2685         * WebView/WebFrameView.h:
2686         * WebView/WebPolicyDelegate.h:
2687         * WebView/WebPreferences.h:
2688         * WebView/WebPreferencesPrivate.h:
2689         * WebView/WebResourceLoadDelegate.h:
2690         * WebView/WebUIDelegate.h:
2691         * WebView/WebUIDelegatePrivate.h:
2692         * WebView/WebView.h:
2693         * WebView/WebViewPrivate.h:
2694         * postprocess-headers.sh:
2695         Remove step that converts WEBKIT macros to NS macros.
2696         Change it to just remove the macros on iOS builds.
2697
2698 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2699
2700         [MediaStream] remove WK1 support
2701         https://bugs.webkit.org/show_bug.cgi?id=185136
2702
2703         Reviewed by Youenn Fablet.
2704
2705         * WebCoreSupport/WebUserMediaClient.h: Removed.
2706         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2707         * WebView/WebView.mm:
2708         (-[WebView _commonInitializationWithFrameName:groupName:]):
2709         (-[WebView _preferencesChanged:]):
2710         (-[WebView _setUserMediaClient:]): Deleted.
2711         (-[WebView _userMediaClient]): Deleted.
2712         * WebView/WebViewData.h:
2713         * WebView/WebViewPrivate.h:
2714
2715 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2716
2717         WebAssembly: add support for stream APIs - JavaScript API
2718         https://bugs.webkit.org/show_bug.cgi?id=183442
2719
2720         Reviewed by Yusuke Suzuki and JF Bastien.
2721
2722         Add WEBASSEMBLY_STREAMINNG_API feature flag
2723
2724         * Configurations/FeatureDefines.xcconfig:
2725
2726 2018-04-30  JF Bastien  <jfbastien@apple.com>
2727
2728         Use some C++17 features
2729         https://bugs.webkit.org/show_bug.cgi?id=185135
2730
2731         Reviewed by Alex Christensen.
2732
2733         * Configurations/WebKitLegacy.xcconfig:
2734
2735 2018-04-27  Chris Dumez  <cdumez@apple.com>
2736
2737         Use WindowProxy instead of DOMWindow in our IDL
2738         https://bugs.webkit.org/show_bug.cgi?id=185022
2739
2740         Reviewed by Sam Weinig.
2741
2742         * DOM/DOMAbstractView.mm:
2743         (kit):
2744         (toWindowProxy):
2745         * DOM/DOMAbstractViewInternal.h:
2746         * DOM/DOMDocument.mm:
2747         (-[DOMDocument defaultView]):
2748         (-[DOMDocument getComputedStyle:pseudoElement:]):
2749         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2750         * DOM/DOMHTMLFrameElement.mm:
2751         (-[DOMHTMLFrameElement contentWindow]):
2752         * DOM/DOMHTMLIFrameElement.mm:
2753         (-[DOMHTMLIFrameElement contentWindow]):
2754         * DOM/DOMKeyboardEvent.mm:
2755         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2756         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2757         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2758         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2759         * DOM/DOMMouseEvent.mm:
2760         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2761         * DOM/DOMTextEvent.mm:
2762         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2763         * DOM/DOMUIEvent.mm:
2764         (-[DOMUIEvent view]):
2765         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2766         * DOM/DOMWheelEvent.mm:
2767         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2768
2769 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2770
2771         Implement rendering support for the color-filter CSS property
2772         https://bugs.webkit.org/show_bug.cgi?id=185047
2773         rdar://problem/39664967
2774
2775         Reviewed by Tim Horton.
2776         
2777         The body background should reflect the filtered color.
2778
2779         * WebView/WebFrame.mm:
2780         (-[WebFrame _bodyBackgroundColor]):
2781         * WebView/WebView.mm:
2782         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2783
2784 2018-04-26  Jer Noble  <jer.noble@apple.com>
2785
2786         WK_COCOA_TOUCH all the things.
2787         https://bugs.webkit.org/show_bug.cgi?id=185006
2788
2789         Reviewed by Tim Horton.
2790
2791         * Configurations/WebKitLegacy.xcconfig:
2792
2793 2018-04-26  Daniel Bates  <dabates@apple.com>
2794
2795         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2796         https://bugs.webkit.org/show_bug.cgi?id=184161
2797         <rdar://problem/39051645>
2798
2799         Reviewed by Dan Bernstein.
2800
2801         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2802         dropping a PDF embedded using an HTML image element into the same web view.
2803
2804         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2805         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2806         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2807         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2808         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2809         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2810         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2811         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2812         image document when navigated to directly. Since we can support dragging PDF document images we need to
2813         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2814         We need to do both such queries before falling back to using the main resource of the Web Archive as
2815         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2816         not an image document.
2817
2818         * Misc/WebNSPasteboardExtras.mm:
2819         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2820
2821 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2822
2823         Disable content filtering in minimal simulator mode
2824         https://bugs.webkit.org/show_bug.cgi?id=185027
2825         <rdar://problem/39736091>
2826
2827         Reviewed by Jer Noble.
2828
2829         * Configurations/FeatureDefines.xcconfig:
2830
2831 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2832
2833         [INTL] Implement Intl.PluralRules
2834         https://bugs.webkit.org/show_bug.cgi?id=184312
2835
2836         Reviewed by JF Bastien.
2837
2838         Added Intl.PluralRules feature flag.
2839
2840         * Configurations/FeatureDefines.xcconfig:
2841
2842 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2843
2844         Remove access to keychain from the WebContent process
2845         https://bugs.webkit.org/show_bug.cgi?id=184428
2846         <rdar://problem/13150903>
2847
2848         Reviewed by Brent Fulgham.
2849
2850         This patch does the followings:
2851         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2852         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2853         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2854
2855         * WebCoreSupport/WebChromeClient.h:
2856         * WebCoreSupport/WebChromeClient.mm:
2857         (WebChromeClient::signedPublicKeyAndChallengeString const):
2858         * WebView/WebUIDelegatePrivate.h:
2859
2860 2018-04-24  Jer Noble  <jer.noble@apple.com>
2861
2862         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2863         https://bugs.webkit.org/show_bug.cgi?id=184786
2864
2865         Reviewed by Tim Horton.
2866
2867         * Configurations/WebKitLegacy.xcconfig:
2868         * MigrateHeaders.make:
2869
2870 2018-04-23  Daniel Bates  <dabates@apple.com>
2871
2872         Implement Same-Site cookies
2873         https://bugs.webkit.org/show_bug.cgi?id=159464
2874         <rdar://problem/27196358>
2875
2876         Reviewed by Brent Fulgham.
2877
2878         Pass the Same-Site info through the strategy.
2879
2880         * WebCoreSupport/WebPlatformStrategies.h:
2881         * WebCoreSupport/WebPlatformStrategies.mm:
2882         (WebPlatformStrategies::cookiesForDOM):
2883         (WebPlatformStrategies::setCookiesFromDOM):
2884         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2885         (WebPlatformStrategies::getRawCookies):
2886
2887 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2888
2889         [LayoutFormattingContext] Initial commit.
2890         https://bugs.webkit.org/show_bug.cgi?id=184896
2891
2892         Reviewed by Antti Koivisto.
2893
2894         * Configurations/FeatureDefines.xcconfig:
2895
2896 2018-04-23  Daniel Bates  <dabates@apple.com>
2897
2898         Implement Same-Site cookies
2899         https://bugs.webkit.org/show_bug.cgi?id=159464
2900         <rdar://problem/27196358>
2901
2902         Reviewed by Brent Fulgham.
2903
2904         Pass the Same-Site info through the strategy.
2905
2906         * WebCoreSupport/WebPlatformStrategies.h:
2907         * WebCoreSupport/WebPlatformStrategies.mm:
2908         (WebPlatformStrategies::cookiesForDOM):
2909         (WebPlatformStrategies::setCookiesFromDOM):
2910         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2911         (WebPlatformStrategies::getRawCookies):
2912
2913 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2914
2915         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2916
2917         https://bugs.webkit.org/show_bug.cgi?id=184851
2918         rdar://problem/39611236
2919
2920         Reviewed by Tim Horton.
2921
2922         * WebView/WebView.mm:
2923         (-[WebView _commonInitializationWithFrameName:groupName:]):
2924         (-[WebView effectiveAppearanceDidChange]):
2925         Added a null check and call the code later in initialization.
2926
2927 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2928
2929         Adjust geolocation feature flag
2930         https://bugs.webkit.org/show_bug.cgi?id=184856
2931
2932         Reviewed by Wenson Hsieh.
2933
2934         * Configurations/FeatureDefines.xcconfig:
2935
2936 2018-04-18  Jer Noble  <jer.noble@apple.com>
2937
2938         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2939         https://bugs.webkit.org/show_bug.cgi?id=184762
2940
2941         Reviewed by Dan Bernstein.
2942
2943         * Configurations/WebKitLegacy.xcconfig:
2944
2945 2018-04-20  Youenn Fablet  <youenn@apple.com>
2946
2947         Make PluginData cache its web visible plugins
2948         https://bugs.webkit.org/show_bug.cgi?id=184421
2949
2950         Reviewed by Chris Dumez.
2951
2952         * WebCoreSupport/WebPluginInfoProvider.h:
2953         * WebCoreSupport/WebPluginInfoProvider.mm:
2954         (WebPluginInfoProvider::pluginInfo):
2955         (WebPluginInfoProvider::webVisiblePluginInfo):
2956
2957 2018-04-19  Chris Dumez  <cdumez@apple.com>
2958
2959         Rename JSDOMWindowProxy to JSWindowProxy
2960         https://bugs.webkit.org/show_bug.cgi?id=184797
2961
2962         Reviewed by Sam Weinig.
2963
2964         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2965
2966         * DOM/DOMUtility.mm:
2967         (createDOMWrapper):
2968         * WebView/WebFrame.mm:
2969         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2970
2971 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2972
2973         Enable Objective-C weak references
2974         <https://webkit.org/b/184789>
2975         <rdar://problem/39571716>
2976
2977         Reviewed by Dan Bernstein.
2978
2979         * Configurations/Base.xcconfig:
2980         (CLANG_ENABLE_OBJC_WEAK): Enable.
2981
2982 2018-04-18  Chris Dumez  <cdumez@apple.com>
2983
2984         Rename WindowProxyController to WindowProxy
2985         https://bugs.webkit.org/show_bug.cgi?id=184756
2986
2987         Reviewed by Sam Weinig.
2988
2989         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2990         needed use WindowProxyController type, which was a bit confusing.
2991
2992         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2993         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2994         * WebView/WebFrame.mm:
2995         (-[WebFrame _attachScriptDebugger]):
2996
2997 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2998
2999         Unreviewed rollout of r230632. Regression in memory usage.
3000
3001         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3002
3003         * WebView/WebPreferences.mm:
3004         (+[WebPreferences initialize]):
3005
3006 2018-04-17  Chris Dumez  <cdumez@apple.com>
3007
3008         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3009         https://bugs.webkit.org/show_bug.cgi?id=184678
3010         <rdar://problem/39422122>
3011
3012         Reviewed by Alex Christensen.
3013
3014         Add new parameter to dispatchDecidePolicyForNavigationAction.
3015
3016         * WebCoreSupport/WebFrameLoaderClient.h:
3017         * WebCoreSupport/WebFrameLoaderClient.mm:
3018         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3019
3020 2018-04-13  Chris Dumez  <cdumez@apple.com>
3021
3022         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3023         https://bugs.webkit.org/show_bug.cgi?id=184591
3024
3025         Reviewed by Sam Weinig.
3026
3027         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3028         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3029         This is work towards fixing Bug 184515.
3030
3031         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3032         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3033         * WebView/WebFrame.mm:
3034         (-[WebFrame _attachScriptDebugger]):
3035
3036 2018-04-12  Antoine Quint  <graouts@apple.com>
3037
3038         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3039         https://bugs.webkit.org/show_bug.cgi?id=184569
3040         <rdar://problem/38671301>
3041
3042         Reviewed by Jon Lee.
3043
3044         * WebView/WebPreferences.mm:
3045
3046 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3047
3048         [WTF] Remove StaticLock
3049         https://bugs.webkit.org/show_bug.cgi?id=184332
3050
3051         Reviewed by Mark Lam.
3052
3053         * DOM/DOMInternal.mm:
3054         (getDOMWrapper):
3055         (addDOMWrapper):
3056         (removeDOMWrapper):
3057
3058 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3059
3060         Failures from mach port reference handling should be fatal
3061         https://bugs.webkit.org/show_bug.cgi?id=184202
3062         <rdar://problem/37771114>
3063
3064         Reviewed by Anders Carlsson.
3065
3066         * Plugins/Hosted/NetscapePluginHostManager.mm:
3067         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3068
3069 2018-04-03  Andy Estes  <aestes@apple.com>
3070
3071         [Mac] Prioritize file promises over filenames during drag and drop
3072         https://bugs.webkit.org/show_bug.cgi?id=184237
3073         <rdar://problem/38278076>
3074
3075         Reviewed by Wenson Hsieh.
3076
3077         * WebView/WebView.mm:
3078         (-[WebView performDragOperation:]):
3079
3080 2018-04-03  Chris Dumez  <cdumez@apple.com>
3081
3082         Drop MainFrame class
3083         https://bugs.webkit.org/show_bug.cgi?id=184191
3084
3085         Reviewed by Darin Adler.
3086
3087         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3088         relationship between the Page and the MainFrame.
3089
3090         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3091
3092         * WebCoreSupport/WebDragClient.mm:
3093         * WebCoreSupport/WebFrameLoaderClient.mm:
3094         * WebCoreSupport/WebInspectorClient.mm:
3095         * WebCoreSupport/WebPlatformStrategies.mm:
3096         * WebCoreSupport/WebPluginInfoProvider.mm:
3097         * WebView/WebFrame.mm:
3098         * WebView/WebFrameView.mm:
3099         * WebView/WebHTMLView.mm:
3100         * WebView/WebView.mm:
3101
3102 2018-04-02  Jer Noble  <jer.noble@apple.com>
3103
3104         Enable Legacy EME for all WebKit & WebKitLegacy clients
3105         https://bugs.webkit.org/show_bug.cgi?id=184018
3106         <rdar://problem/34887387>
3107
3108         Reviewed by Eric Carlson.
3109
3110         * WebView/WebPreferences.mm:
3111         (+[WebPreferences initialize]):
3112
3113 2018-03-29  JF Bastien  <jfbastien@apple.com>
3114
3115         Use Forward.h instead of forward-declaring WTF::String
3116         https://bugs.webkit.org/show_bug.cgi?id=184172
3117         <rdar://problem/39026146>
3118
3119         Reviewed by Yusuke Suzuki.
3120
3121         As part of #184164 I'm changing WTF::String, and the forward
3122         declarations are just wrong because I'm making it templated. We
3123         should use Forward.h anyways, so do that instead.
3124
3125         * WebView/WebScriptDebugger.h:
3126
3127 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3128
3129         Protect against invalid mach ports returned by mach_port_request_notification
3130         https://bugs.webkit.org/show_bug.cgi?id=184106
3131         <rdar://problem/37865316>
3132
3133         Reviewed by Chris Dumez.
3134
3135         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3136         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3137         and clean up if it experienced an error.
3138         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3139
3140 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3141
3142         Avoid uninitialized mach ports
3143         https://bugs.webkit.org/show_bug.cgi?id=184090
3144         <rdar://problem/37261129>
3145
3146         Reviewed by Chris Dumez.
3147
3148         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3149         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3150         there is a potential for us to try to use invalid ports.
3151
3152         We should always check return values, and ensure that the mach port variables we seek to initialize are
3153         kept in a valid state.
3154
3155         Reviewed by Chris Dumez.
3156
3157         * Plugins/Hosted/NetscapePluginHostManager.h:
3158         * Plugins/Hosted/NetscapePluginHostManager.mm:
3159         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3160         port is passed to an API function.
3161         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3162         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3163         * Plugins/Hosted/NetscapePluginHostProxy.h:
3164         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3165         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3166         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3167         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3168         (WKPCStatusText): Ditto.
3169         (WKPCLoadURL): Ditto.
3170         (WKPCCancelLoadURL): Ditto.
3171         (WKPCInvalidateRect): Ditto.
3172         (WKPCGetScriptableNPObjectReply): Ditto.
3173         (WKPCBooleanReply): Ditto.
3174         (WKPCBooleanAndDataReply): Ditto.
3175         (WKPCInstantiatePluginReply): Ditto.
3176         (WKPCGetWindowNPObject): Ditto.
3177         (WKPCGetPluginElementNPObject): Ditto.
3178         (WKPCForgetBrowserObject): Ditto.
3179         (WKPCEvaluate): Ditto.
3180         (WKPCGetStringIdentifier): Ditto.
3181         (WKPCGetIntIdentifier): Ditto.
3182         (WKPCInvoke): Ditto.
3183         (WKPCInvokeDefault): Ditto.
3184         (WKPCConstruct): Ditto.
3185         (WKPCGetProperty): Ditto.
3186         (WKPCSetProperty): Ditto.
3187         (WKPCRemoveProperty): Ditto.
3188         (WKPCHasProperty): Ditto.
3189         (WKPCHasMethod): Ditto.
3190         (WKPCIdentifierInfo): Ditto.
3191         (WKPCEnumerate): Ditto.
3192         (WKPCSetMenuBarVisible): Ditto.
3193         (WKPCSetFullscreenWindowIsShowing): Ditto.
3194         (WKPCSetModal): Ditto.
3195         (WKPCGetCookies): Ditto.
3196         (WKPCGetProxy): Ditto.
3197         (WKPCSetCookies): Ditto.
3198         (WKPCGetAuthenticationInfo): Ditto.
3199         (WKPCConvertPoint): Ditto.
3200         (WKPCLayerHostingModeChanged): Ditto.
3201         (WKPCSetException): Ditto.
3202
3203 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3204
3205         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3206         https://bugs.webkit.org/show_bug.cgi?id=184030
3207         <rdar://problem/38895281>
3208
3209         Reviewed by Dan Bernstein.
3210
3211         * Configurations/Base.xcconfig:
3212
3213 2018-03-26  Chris Dumez  <cdumez@apple.com>
3214
3215         Use SecurityOriginData more consistently in Service Worker code
3216         https://bugs.webkit.org/show_bug.cgi?id=183969
3217
3218         Reviewed by Darin Adler.
3219
3220         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3221
3222         * Storage/WebDatabaseManager.mm:
3223         (-[WebDatabaseManager databasesWithOrigin:]):
3224         (-[WebDatabaseManager deleteOrigin:]):
3225         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3226         * Storage/WebDatabaseQuotaManager.mm:
3227         (-[WebDatabaseQuotaManager usage]):
3228         (-[WebDatabaseQuotaManager quota]):
3229         (-[WebDatabaseQuotaManager setQuota:]):
3230         * Storage/WebStorageManager.mm:
3231         (-[WebStorageManager deleteOrigin:]):
3232         * WebCoreSupport/WebSecurityOrigin.mm:
3233         (-[WebSecurityOrigin databaseIdentifier]):
3234         (-[WebSecurityOrigin usage]):
3235         (-[WebSecurityOrigin quota]):
3236         (-[WebSecurityOrigin setQuota:]):
3237
3238 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3239
3240         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3241         https://bugs.webkit.org/show_bug.cgi?id=183911
3242         <rdar://problem/38762306>
3243
3244         Reviewed by Youenn Fablet.
3245
3246         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3247
3248         * WebView/WebView.mm:
3249         (+[WebView initialize]):
3250
3251 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3252
3253         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3254         https://bugs.webkit.org/show_bug.cgi?id=183965
3255
3256         Reviewed by Chris Dumez.
3257
3258         * WebCoreSupport/WebFrameLoaderClient.h:
3259         * WebCoreSupport/WebFrameLoaderClient.mm:
3260         (WebFrameLoaderClient::willCacheResponse const):
3261
3262 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3263
3264         Unreviewed, rolling out r229954.
3265         https://bugs.webkit.org/show_bug.cgi?id=184000
3266
3267         Caused many layout tests to crash on Apple High Sierra,
3268         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3269         by dydz on #webkit).
3270
3271         Reverted changeset:
3272
3273         "Use SecurityOriginData more consistently in Service Worker
3274         code"
3275         https://bugs.webkit.org/show_bug.cgi?id=183969
3276         https://trac.webkit.org/changeset/229954
3277
3278 2018-03-24  Chris Dumez  <cdumez@apple.com>
3279
3280         Use SecurityOriginData more consistently in Service Worker code
3281         https://bugs.webkit.org/show_bug.cgi?id=183969
3282
3283         Reviewed by Darin Adler.
3284
3285         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3286
3287         * Storage/WebDatabaseManager.mm:
3288         (-[WebDatabaseManager databasesWithOrigin:]):
3289         (-[WebDatabaseManager deleteOrigin:]):
3290         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3291         * Storage/WebDatabaseQuotaManager.mm:
3292         (-[WebDatabaseQuotaManager usage]):
3293         (-[WebDatabaseQuotaManager quota]):
3294         (-[WebDatabaseQuotaManager setQuota:]):
3295         * Storage/WebStorageManager.mm:
3296         (-[WebStorageManager deleteOrigin:]):
3297         * WebCoreSupport/WebSecurityOrigin.mm:
3298         (-[WebSecurityOrigin databaseIdentifier]):
3299         (-[WebSecurityOrigin usage]):
3300         (-[WebSecurityOrigin quota]):
3301         (-[WebSecurityOrigin setQuota:]):
3302
3303 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3304
3305         Fix the build
3306
3307         * WebView/WebView.mm:
3308
3309 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3310
3311         Fix the build with no pasteboard
3312         https://bugs.webkit.org/show_bug.cgi?id=183973
3313
3314         Reviewed by Dan Bernstein.
3315
3316         * Configurations/FeatureDefines.xcconfig:
3317         * WebView/WebView.mm:
3318         (-[WebView _requestStartDataInteraction:globalPosition:]):
3319         (-[WebView _getDataInteractionData]):
3320         (-[WebView _dataOperationTextIndicator]):
3321         (-[WebView _dragSourceAction]):
3322         (-[WebView _draggedLinkTitle]):
3323         (-[WebView _draggedLinkURL]):
3324         (-[WebView _draggedElementBounds]):
3325         (-[WebView _enteredDataInteraction:client:global:operation:]):
3326         (-[WebView _updatedDataInteraction:client:global:operation:]):
3327         (-[WebView _exitedDataInteraction:client:global:operation:]):
3328         (-[WebView _performDataInteraction:client:global:operation:]):
3329         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3330         (-[WebView _endedDataInteraction:global:]):
3331         (-[WebView _dataInteractionCaretRect]):
3332         * WebView/WebViewPrivate.h:
3333
3334 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3335
3336         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3337         https://bugs.webkit.org/show_bug.cgi?id=183960
3338         <rdar://problem/38812356>
3339
3340         Reviewed by Dan Bernstein.
3341
3342         * Configurations/WebKitLegacy.xcconfig:
3343
3344 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3345
3346         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3347         https://bugs.webkit.org/show_bug.cgi?id=183954
3348         <rdar://problem/38808858>
3349
3350         Reviewed by Dan Bernstein.
3351
3352         * WebView/WebPreferences.mm:
3353         (-[WebPreferences setAudioSessionCategoryOverride:]):
3354
3355 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3356
3357         Adopt WK_PLATFORM_NAME in WebKitLegacy
3358         https://bugs.webkit.org/show_bug.cgi?id=183948
3359         <rdar://problem/38803908>
3360
3361         Reviewed by Dan Bernstein.
3362
3363         * Configurations/WebKitLegacy.xcconfig:
3364         * MigrateHeaders.make:
3365         * postprocess-headers.sh:
3366
3367 2018-03-23  Brady Eidson  <beidson@apple.com>
3368
3369         Go to back/forward list items after a process-swapped navigation.
3370         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3371
3372         Reviewed by Andy Estes.
3373
3374         * WebView/WebView.mm:
3375         (-[WebView _loadBackForwardListFromOtherView:]):
3376         (-[WebView goToBackForwardItem:]):
3377
3378 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3379
3380         Improve readability of WebCore's OTHER_LDFLAGS
3381         https://bugs.webkit.org/show_bug.cgi?id=183909
3382         <rdar://problem/38760992>
3383
3384         Reviewed by Dan Bernstein.
3385
3386         * Configurations/Base.xcconfig:
3387         * Configurations/FeatureDefines.xcconfig:
3388
3389 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3390
3391         Enable the minimal simulator feature flag when appropriate
3392         https://bugs.webkit.org/show_bug.cgi?id=183807
3393
3394         Reviewed by Dan Bernstein.
3395
3396         * Configurations/FeatureDefines.xcconfig:
3397
3398 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3399
3400         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3401         https://bugs.webkit.org/show_bug.cgi?id=183758
3402         <rdar://problem/38017644>
3403
3404         Reviewed by Dan Bernstein.
3405
3406         * Configurations/FeatureDefines.xcconfig:
3407
3408 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3409
3410         Clear style colors when setting default appearance
3411         https://bugs.webkit.org/show_bug.cgi?id=183759
3412
3413         Reviewed by Tim Horton.
3414
3415         Colors are cached and need to be cleared and recalculated.
3416         Refactor to do all style recalcs together.
3417
3418         * WebView/WebView.mm:
3419         (-[WebView _setDefaultAppearanceAndClearStyle]):
3420         (-[WebView _setUseSystemAppearance:]):
3421         (-[WebView effectiveAppearanceDidChange]):
3422
3423 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3424
3425         Unreviewed, another quick fix for r229699
3426
3427         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3428
3429         * Configurations/FeatureDefines.xcconfig:
3430
3431 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3432
3433         Ensure that style is updated when the effective appearance changes
3434         https://bugs.webkit.org/show_bug.cgi?id=183690
3435         <rdar://problem/38385900>
3436
3437         Reviewed by Tim Horton and Wenson Hsieh.
3438
3439         Respond to and respect the effective appearance changing.
3440
3441         * WebView/WebView.mm:
3442         (-[WebView _setUseSystemAppearance:]):
3443         (-[WebView effectiveAppearanceDidChange]):
3444
3445 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3446
3447         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3448         https://bugs.webkit.org/show_bug.cgi?id=183677
3449
3450         Reviewed by Tim Horton.
3451
3452         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3453
3454         * DOM/DOM.mm:
3455         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3456
3457 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3458
3459         Fix the build after r229567
3460
3461         * Configurations/FeatureDefines.xcconfig:
3462
3463 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3464
3465         Stop using SDK conditionals to control feature definitions
3466         https://bugs.webkit.org/show_bug.cgi?id=183430
3467         <rdar://problem/38251619>
3468
3469         Reviewed by Dan Bernstein.
3470
3471         * Configurations/FeatureDefines.xcconfig:
3472         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3473
3474 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3475
3476         Runtime flag for link prefetch and remove link subresource.
3477         https://bugs.webkit.org/show_bug.cgi?id=183540
3478
3479         Reviewed by Chris Dumez.
3480
3481         Remove the LINK_PREFETCH build time flag.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484
3485 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3486
3487         Remove GridLayout runtime flag
3488         https://bugs.webkit.org/show_bug.cgi?id=183484
3489
3490         Reviewed by Myles C. Maxfield.
3491
3492         The Grid Layout feature has been enabled by default for almost a
3493         year, so I think it's time to remove the runtime flag and the
3494
3495         * WebView/WebPreferenceKeysPrivate.h:
3496         * WebView/WebPreferences.mm:
3497         (+[WebPreferences initialize]):
3498         * WebView/WebPreferencesPrivate.h:
3499         * WebView/WebView.mm:
3500         (-[WebView _preferencesChanged:]):
3501
3502 2018-03-12  Antoine Quint  <graouts@apple.com>
3503
3504         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3505         https://bugs.webkit.org/show_bug.cgi?id=183504
3506         <rdar://problem/38372965>
3507
3508         Reviewed by Dean Jackson and Jon Lee.
3509
3510         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3511         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3512
3513         * WebView/WebPreferenceKeysPrivate.h:
3514         * WebView/WebPreferences.mm:
3515         (+[WebPreferences initialize]):
3516         (-[WebPreferences setModernMediaControlsEnabled:]):
3517         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3518         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3519         * WebView/WebPreferencesPrivate.h:
3520         * WebView/WebView.mm:
3521         (-[WebView _preferencesChanged:]):
3522
3523 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3524
3525         Media query for default appearance
3526         https://bugs.webkit.org/show_bug.cgi?id=183539
3527         <rdar://problem/38326388>
3528
3529         Reviewed by Tim Horton.
3530
3531         Write a media query to evaluate appearance.
3532
3533         * WebView/WebView.mm:
3534         (-[WebView _commonInitializationWithFrameName:groupName:]):
3535         (-[WebView _setUseSystemAppearance:]):
3536
3537 2018-03-09  Andy Estes  <aestes@apple.com>
3538
3539         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3540         https://bugs.webkit.org/show_bug.cgi?id=183489
3541         <rdar://problem/38267517>
3542
3543         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3544         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3545         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3546         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3547         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3548
3549         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3550         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3551         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3552         drop destination.
3553
3554         Reviewed by Wenson Hsieh.
3555
3556         * WebView/WebView.mm:
3557         (-[WebView performDragOperation:]):
3558
3559 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3560
3561         Allow WebViews to disable system appearance
3562         https://bugs.webkit.org/show_bug.cgi?id=183418
3563         <rdar://problem/36975642>
3564
3565         Reviewed by Tim Horton.
3566
3567         Allow webviews to choose whether or not to follow the default system appearance.
3568
3569         * WebView/WebView.mm:
3570         (-[WebView _setUseSystemAppearance:]):
3571         (-[WebView _useSystemAppearance]):
3572         * WebView/WebViewPrivate.h:
3573
3574 2018-03-08  Youenn Fablet  <youenn@apple.com>
3575
3576         libwebrtc update broke internal builds
3577         https://bugs.webkit.org/show_bug.cgi?id=183454
3578
3579         Reviewed by Eric Carlson.
3580
3581         * Configurations/WebKitLegacy.xcconfig:
3582
3583 2018-03-08  Chris Dumez  <cdumez@apple.com>
3584
3585         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3586         https://bugs.webkit.org/show_bug.cgi?id=183455
3587         <rdar://problem/38191749>
3588
3589         Reviewed by Youenn Fablet.
3590
3591         Add a null check for the page as we have evidence from crashes that it can be null.
3592         Other functions in WebFrameNetworkingContext already null check the page as well,
3593         not just the frame so this is consistent.
3594
3595         * WebCoreSupport/WebFrameNetworkingContext.mm:
3596         (WebFrameNetworkingContext::storageSession const):
3597
3598 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3599
3600         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3601         https://bugs.webkit.org/show_bug.cgi?id=183429
3602
3603         Reviewed by Mark Lam.
3604
3605         * DOM/DOM.mm:
3606         (+[DOMNode _nodeFromJSWrapper:]):
3607         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3608         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3609         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3610         * Plugins/Hosted/ProxyInstance.mm:
3611         (WebKit::ProxyInstance::invokeMethod):
3612         * WebView/WebView.mm:
3613         (aeDescFromJSValue):
3614
3615 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3616
3617         Stop linking ApplicationServices directly
3618         https://bugs.webkit.org/show_bug.cgi?id=182867
3619         <rdar://problem/38252142>
3620
3621         Reviewed by Alex Christensen.
3622
3623         The frameworks that we use that live inside ApplicationServices
3624         have mostly moved out, so import them directly.
3625
3626         * Carbon/CarbonUtils.h:
3627         * WebKitPrefix.h:
3628         * WebView/WebHTMLView.mm:
3629         * WebView/WebPDFView.mm:
3630
3631 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3632
3633         Sort and separate FeatureDefines.xcconfig
3634         https://bugs.webkit.org/show_bug.cgi?id=183427
3635
3636         Reviewed by Dan Bernstein.
3637
3638         * Configurations/FeatureDefines.xcconfig:
3639         Sort and split FeatureDefines into paragraphs
3640         (to make it easier to sort later).
3641
3642 2018-03-07  Youenn Fablet  <youenn@apple.com>
3643
3644         Match unsupported plugins based on domains and not origin
3645         https://bugs.webkit.org/show_bug.cgi?id=183384
3646
3647         Reviewed by Chris Dumez.
3648
3649         * WebCoreSupport/WebPluginInfoProvider.h:
3650         * WebCoreSupport/WebPluginInfoProvider.mm:
3651         (WebPluginInfoProvider::getPluginInfo):
3652         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3653
3654 2018-03-05  Andy Estes  <aestes@apple.com>
3655
3656         [Mac] Teach WebCore::Pasteboard about file promise drags
3657         https://bugs.webkit.org/show_bug.cgi?id=183314
3658         <rdar://problem/38105493>
3659
3660         Reviewed by Darin Adler.
3661
3662         Added a FIXME comment.
3663
3664         * WebView/WebView.mm:
3665         (-[WebView performDragOperation:]):
3666
3667 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3668
3669         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3670         https://bugs.webkit.org/show_bug.cgi?id=183312
3671
3672         Reviewed by Mark Lam.
3673
3674         Remove wtf/CurrentTime.h include pragma.
3675
3676         * WebView/WebFrame.mm:
3677         * WebView/WebPDFView.mm:
3678
3679 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3680
3681         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3682         https://bugs.webkit.org/show_bug.cgi?id=183283
3683         <rdar://problem/38062148>
3684
3685         Reviewed by Sam Weinig.
3686
3687         * Configurations/FeatureDefines.xcconfig:
3688
3689 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3690
3691         Reduce use of NetworkingContext in WebKit
3692         https://bugs.webkit.org/show_bug.cgi?id=183213
3693
3694         Reviewed by Brady Eidson.
3695
3696         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3697         (WebKit::NetscapePluginInstanceProxy::getProxy):
3698         * Plugins/WebNetscapePluginView.mm:
3699         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3700
3701 2018-02-17  Darin Adler  <darin@apple.com>
3702
3703         Prepare for ExtendedColor changes (first step)
3704         https://bugs.webkit.org/show_bug.cgi?id=182904
3705
3706         Reviewed by Sam Weinig.
3707
3708         * Misc/WebKitNSStringExtras.mm:
3709         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3710
3711 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3712
3713         Remove currentTime() / currentTimeMS()
3714         https://bugs.webkit.org/show_bug.cgi?id=183052
3715
3716         Reviewed by Mark Lam.
3717
3718         * WebCoreSupport/WebFrameLoaderClient.h:
3719         * WebCoreSupport/WebFrameLoaderClient.mm:
3720         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3721
3722 2018-02-16  Youenn Fablet  <youenn@apple.com>
3723
3724         Allow specifying which plug-ins are supported
3725         https://bugs.webkit.org/show_bug.cgi?id=182748
3726
3727         Reviewed by Chris Dumez.
3728
3729         * WebCoreSupport/WebPluginInfoProvider.h:
3730         * WebCoreSupport/WebPluginInfoProvider.mm:
3731         (WebPluginInfoProvider::getPluginInfo):
3732         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3733
3734 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3735
3736         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3737         https://bugs.webkit.org/show_bug.cgi?id=182882
3738         <rdar://problem/35672661>
3739
3740         Reviewed by Dan Bernstein.
3741
3742         Make sure the smart pointer hold the collection of subviews lives at least as
3743         long as the loop using it.
3744
3745         * WebView/WebHTMLView.mm:
3746         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3747
3748 2018-02-14  Daniel Bates  <dabates@apple.com>
3749
3750         Disallow cross-origin subresources from asking for credentials
3751         https://bugs.webkit.org/show_bug.cgi?id=182579
3752         <rdar://problem/36162271>
3753
3754         Reviewed by Andy Estes.
3755
3756         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3757         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3758
3759         * WebView/WebPreferenceKeysPrivate.h:
3760         * WebView/WebPreferences.mm:
3761         (+[WebPreferences initialize]):
3762         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3763         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3764         * WebView/WebPreferencesPrivate.h:
3765         * WebView/WebView.mm:
3766         (-[WebView _preferencesChanged:]):
3767
3768 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3769
3770         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3771         https://bugs.webkit.org/show_bug.cgi?id=182738
3772
3773         Reviewed by Darin Adler.
3774
3775         * ForwardingHeaders/collector/handles/Global.h: Removed.
3776         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3777         * ForwardingHeaders/runtime/Completion.h: Removed.
3778         * ForwardingHeaders/runtime/Error.h: Removed.
3779         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3780         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3781         * ForwardingHeaders/runtime/JSLock.h: Removed.
3782         * ForwardingHeaders/runtime/JSObject.h: Removed.
3783         * ForwardingHeaders/runtime/JSString.h: Removed.
3784         * ForwardingHeaders/runtime/Protect.h: Removed.
3785         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3786
3787 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3788
3789         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3790         https://bugs.webkit.org/show_bug.cgi?id=182641
3791
3792         Reviewed by Dan Bernstein.
3793
3794         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3795         https://trac.webkit.org/changeset/228308.
3796
3797         * WebView/WebVideoFullscreenController.h:
3798         * WebView/WebVideoFullscreenHUDWindowController.mm:
3799         * WebView/WebWindowAnimation.h:
3800         * WebView/WebWindowAnimation.mm:
3801         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3802         (WebCore::scaledRect): Deleted.
3803         (WebCore::squaredDistance): Deleted.
3804
3805 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3806
3807         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3808
3809         * WebView/WebWindowAnimation.mm:
3810         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3811
3812 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3813
3814         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3815         https://bugs.webkit.org/show_bug.cgi?id=182615
3816
3817         Reviewed by Eric Carlson.
3818
3819         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3820         Ideally, we should not reference NSApp in WebCore.
3821
3822         * WebView/WebFullScreenController.mm:
3823         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3824         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3825         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3826         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3827         * WebView/WebView.mm:
3828         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3829         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3830
3831 2018-01-13  Darin Adler  <darin@apple.com>
3832
3833         Event improvements
3834         https://bugs.webkit.org/show_bug.cgi?id=179591
3835
3836         Reviewed by Chris Dumez.
3837
3838         * DOM/DOMWheelEvent.mm:
3839         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3840         Call initWebKitWheelEvent.
3841
3842         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3843         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3844         * WebView/WebFrame.mm: Ditto.
3845
3846         * WebView/WebHTMLView.mm:
3847         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3848         underlyingPlatformEvent.
3849         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3850
3851         * WebView/WebScriptWorld.mm:
3852         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3853
3854         * WebView/WebView.mm: Removed include of ScriptValue.h.
3855
3856 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3857
3858         Remove WebCore/ForwardingHeaders directory
3859         https://bugs.webkit.org/show_bug.cgi?id=182347
3860
3861         Reviewed by Keith Miller.
3862
3863         * Carbon/CarbonWindowAdapter.mm:
3864         * DOM/WebDOMOperations.mm:
3865         * History/WebBackForwardList.mm:
3866         * History/WebHistoryItem.mm:
3867         * Misc/WebCache.mm:
3868         * Misc/WebElementDictionary.mm:
3869         * Misc/WebIconDatabase.mm:
3870         * Misc/WebStringTruncator.mm:
3871         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3872         * Plugins/Hosted/ProxyInstance.mm:
3873         * Plugins/Hosted/ProxyRuntimeObject.mm:
3874         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3875         * Plugins/WebBaseNetscapePluginView.mm:
3876         * Plugins/WebBasePluginPackage.mm:
3877         * Plugins/WebNetscapePluginStream.mm:
3878         * Plugins/WebNetscapePluginView.mm:
3879         * Plugins/WebPluginController.mm:
3880         * WebCoreSupport/WebEditorClient.mm:
3881         * WebCoreSupport/WebFrameLoaderClient.mm:
3882         * WebCoreSupport/WebInspectorClient.h:
3883         * WebCoreSupport/WebInspectorClient.mm:
3884         * WebView/WebDataSource.mm:
3885         * WebView/WebFrame.mm:
3886         * WebView/WebHTMLRepresentation.mm:
3887         * WebView/WebHTMLView.mm:
3888         * WebView/WebPreferences.mm:
3889         * WebView/WebScriptDebugDelegate.mm:
3890         * WebView/WebScriptDebugger.h:
3891         * WebView/WebTextIterator.mm:
3892         * WebView/WebView.mm:
3893         * WebView/WebViewData.mm:
3894
3895 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3896
3897         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3898         https://bugs.webkit.org/show_bug.cgi?id=182312
3899
3900         Reviewed by Michael Catanzaro.
3901
3902         * WebKitPrefix.h:
3903
3904 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3905
3906         [WebAuthN] Add a compile-time feature flag
3907         https://bugs.webkit.org/show_bug.cgi?id=182211
3908         <rdar://problem/36936365>
3909
3910         Reviewed by Brent Fulgham.
3911
3912         * Configurations/FeatureDefines.xcconfig:
3913
3914 2018-01-27  Dan Bernstein  <mitz@apple.com>
3915
3916         HaveInternalSDK includes should be "#include?"
3917         https://bugs.webkit.org/show_bug.cgi?id=179670
3918
3919         * Configurations/Base.xcconfig:
3920
3921 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3922
3923         Remove unused QTKit preference
3924         https://bugs.webkit.org/show_bug.cgi?id=181968
3925
3926         Reviewed by Alexey Proskuryakov.
3927
3928         * WebView/WebPreferenceKeysPrivate.h:
3929         * WebView/WebPreferences.mm:
3930         (+[WebPreferences initialize]):
3931         (-[WebPreferences setQTKitEnabled:]): Deleted.
3932         (-[WebPreferences isQTKitEnabled]): Deleted.
3933         * WebView/WebPreferencesPrivate.h:
3934         * WebView/WebView.mm:
3935         (-[WebView _preferencesChanged:]):
3936
3937 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3938
3939         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3940         https://bugs.webkit.org/show_bug.cgi?id=182037
3941         <rdar://problem/36747812>
3942
3943         Reviewed by Ryosuke Niwa.
3944
3945         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3946         for more details.
3947
3948         * WebView/WebHTMLRepresentation.mm:
3949         (-[WebHTMLRepresentation elementWithName:inForm:]):
3950         (-[WebHTMLRepresentation controlsInForm:]):
3951
3952 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3953
3954         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3955         https://bugs.webkit.org/show_bug.cgi?id=181961
3956
3957         Reviewed by Michael Catanzaro.
3958
3959         * WebView/WebPreferences.mm:
3960
3961 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3962
3963         Unreviewed, rolling out r227437.
3964         https://bugs.webkit.org/show_bug.cgi?id=182011
3965
3966         broke build (Requested by alexchristensen on #webkit).
3967
3968         Reverted changeset:
3969
3970         "Remove unused QTKit preference"
3971         https://bugs.webkit.org/show_bug.cgi?id=181968
3972         https://trac.webkit.org/changeset/227437
3973
3974 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3975
3976         Remove unused QTKit preference
3977         https://bugs.webkit.org/show_bug.cgi?id=181968
3978
3979         Reviewed by Alexey Proskuryakov.
3980
3981         * WebView/WebPreferenceKeysPrivate.h:
3982         * WebView/WebPreferences.mm:
3983         (+[WebPreferences initialize]):
3984         (-[WebPreferences setQTKitEnabled:]): Deleted.
3985         (-[WebPreferences isQTKitEnabled]): Deleted.
3986         * WebView/WebPreferencesPrivate.h:
3987         * WebView/WebView.mm:
3988         (-[WebView _preferencesChanged:]):
3989
3990 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3991
3992         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3993         https://bugs.webkit.org/show_bug.cgi?id=181960
3994         <rdar://problem/36431678>
3995
3996         Reviewed by Tim Horton.
3997
3998         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3999         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
4000         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
4001
4002         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
4003         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
4004         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
4005
4006         * WebView/WebView.mm:
4007         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
4008
4009 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
4010
4011         Turning off custom pasteboard data doesn't actually turn it off in WK2
4012         https://bugs.webkit.org/show_bug.cgi?id=181920
4013         <rdar://problem/36686429>
4014
4015         Reviewed by Wenson Hsieh.
4016
4017         Always disable custom pasteboard data in WebKit1. See r226156 for details.
4018
4019         * WebView/WebPreferences.mm:
4020         (+[WebPreferences initialize]):
4021         * WebView/WebView.mm:
4022         (-[WebView _preferencesChanged:]):
4023
4024 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
4025
4026         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
4027         https://bugs.webkit.org/show_bug.cgi?id=181918
4028
4029         Reviewed by Tim Horton.
4030
4031         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
4032
4033         * Configurations/FeatureDefines.xcconfig:
4034
4035 2018-01-20  Andy Estes  <aestes@apple.com>
4036
4037         [Apple Pay] Stop eagerly loading PassKit.framework
4038         https://bugs.webkit.org/show_bug.cgi?id=181911
4039         <rdar://problem/36555369>
4040
4041         Reviewed by Tim Horton.
4042
4043         * WebCoreSupport/WebPaymentCoordinatorClient.h:
4044         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
4045         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
4046
4047         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
4048
4049 2018-01-19  Dean Jackson  <dino@apple.com>
4050
4051         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
4052         https://bugs.webkit.org/show_bug.cgi?id=181817
4053         <rdar://problem/35274055>
4054
4055         Reviewed by Simon Fraser.
4056
4057         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
4058
4059         * Misc/WebKitVersionChecks.h:
4060         * WebView/WebView.mm:
4061         (-[WebView _commonInitializationWithFrameName:groupName:]):
4062
4063 2018-01-19  Alex Christensen  <achristensen@webkit.org>
4064
4065         Remove unused WebViewPrivate _allowCookies
4066         https://bugs.webkit.org/show_bug.cgi?id=181812
4067
4068         Reviewed by Tim Horton.
4069
4070         * WebView/WebView.mm: