Remove unused WebViewPrivate _allowCookies
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-19  Alex Christensen  <achristensen@webkit.org>
2
3         Remove unused WebViewPrivate _allowCookies
4         https://bugs.webkit.org/show_bug.cgi?id=181812
5
6         Reviewed by Tim Horton.
7
8         * WebView/WebView.mm:
9         (+[WebView _setAllowCookies:]): Deleted.
10         (+[WebView _allowCookies]): Deleted.
11         * WebView/WebViewPrivate.h:
12
13 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
14
15         Build fix, remove a call to -[NSWindow setOneShot:]
16         https://bugs.webkit.org/show_bug.cgi?id=181809
17
18         Reviewed by Tim Horton.
19
20         * WebView/WebTextCompletionController.mm:
21         (-[WebTextCompletionController _buildUI]):
22
23 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
24
25         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
26
27         * Carbon/HIWebView.mm:
28         (overrideCGContext):
29         (restoreCGContext):
30
31 2018-01-18  Dan Bernstein  <mitz@apple.com>
32
33         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
34         https://bugs.webkit.org/show_bug.cgi?id=181803
35
36         Reviewed by Tim Horton.
37
38         * Configurations/Base.xcconfig: Updated.
39         * Configurations/DebugRelease.xcconfig: Ditto.
40         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
41         * Configurations/Version.xcconfig: Updated.
42         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
43           useful for defining settings that depend on the target macOS version.
44
45 2018-01-17  Youenn Fablet  <youenn@apple.com>
46
47         Put fetch Request.keepalive behind a runtime flag
48         https://bugs.webkit.org/show_bug.cgi?id=181592
49
50         Reviewed by Chris Dumez.
51
52         * WebView/WebPreferenceKeysPrivate.h:
53         * WebView/WebPreferences.mm:
54         (+[WebPreferences initialize]):
55         (-[WebPreferences fetchAPIKeepAliveEnabled]):
56         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
57         * WebView/WebPreferencesPrivate.h:
58         * WebView/WebView.mm:
59         (-[WebView _preferencesChanged:]):
60
61 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
62
63         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
64         https://bugs.webkit.org/show_bug.cgi?id=181637
65         <rdar://problem/36508471>
66
67         Reviewed by Tim Horton.
68
69         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
70
71         * WebCoreSupport/WebEditorClient.h:
72         * WebCoreSupport/WebEditorClient.mm:
73         (WebEditorClient::replacementURLForResource):
74
75 2018-01-11  Keith Miller  <keith_miller@apple.com>
76
77         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
78         https://bugs.webkit.org/show_bug.cgi?id=181573
79
80         Reviewed by Simon Fraser.
81
82         * Configurations/FeatureDefines.xcconfig:
83
84 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
85
86         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
87         https://bugs.webkit.org/show_bug.cgi?id=181497
88
89         Reviewed by Tim Horton.
90
91         See other ChangeLogs for more detail.
92
93         * WebCoreSupport/WebDragClient.h:
94
95 2018-01-11  Tim Horton  <timothy_horton@apple.com>
96
97         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
98         https://bugs.webkit.org/show_bug.cgi?id=181523
99         <rdar://problem/28959131>
100
101         Reviewed by Alex Christensen.
102
103         * WebView/WebImmediateActionController.mm:
104         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
105         Apply the change made in r216652 to WebKit1's immediate action controller.
106
107         Speculative (but successful in WebKit2) fix for non-reproducible crash when
108         the startContainer of the range is in an anonymous node.
109
110 2018-01-11  Youenn Fablet  <youenn@apple.com>
111
112         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
113         https://bugs.webkit.org/show_bug.cgi?id=181480
114
115         Reviewed by Eric Carlson.
116
117         * WebView/WebPreferences.mm:
118         (+[WebPreferences initialize]):
119
120 2018-01-08  David Kilzer  <ddkilzer@apple.com>
121
122         Fix check-webkit-style issues with WebNSDataExtras.mm
123         <https://webkit.org/b/181369>
124
125         Reviewed by Alex Christensen.
126
127         * Misc/WebNSDataExtras.mm:
128         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
129         (-[NSData _webkit_guessedMIMETypeForXML]):
130         (-[NSData _webkit_guessedMIMEType]):
131         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
132         (_findEOL):
133         (-[NSData _webkit_parseRFC822HeaderFields]):
134         (-[NSData _web_locationAfterFirstBlankLine]):
135         - Fix all the check-webkit-style warnings.
136
137 2018-01-08  David Kilzer  <ddkilzer@apple.com>
138
139         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
140         <https://webkit.org/b/181256>
141         <rdar://problem/36281730>
142
143         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
144         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
145         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
146           to avoid warnings from casting CFStringRef to NPNSString*.
147           Note that CFMutableStringRef is the same as CFStringRef
148           without the const modifier, hence its use in the const_cast<>
149           above.
150
151 2018-01-08  David Kilzer  <ddkilzer@apple.com>
152
153         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
154         <https://webkit.org/b/181256>
155         <rdar://problem/36281730>
156
157         * Carbon/HIWebView.mm:
158         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
159         checked_cf_cast<CFRunLoopRef>() to fix warning.
160
161 2018-01-07  David Kilzer  <ddkilzer@apple.com>
162
163         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
164         <https://webkit.org/b/181256>
165         <rdar://problem/36281730>
166
167         Reviewed by Darin Adler.
168
169         * Carbon/CarbonUtils.m:
170         (PoolCleaner):
171         - Use #pragmas to ignore -Wcast-qual warnings when using a
172           C-style cast from CFTypeRef to CFRunloopRef.
173         * Carbon/CarbonWindowFrame.m:
174         (-[CarbonWindowFrame title]):
175         - Use #pragmas to ignore -Wcast-qual warnings when using a
176           C-style cast from CFStringRef to NSString *.
177         * Carbon/HIViewAdapter.m:
178         (+[HIViewAdapter getHIViewForNSView:]):
179         - Use #pragmas to ignore -Wcast-qual warnings when using a
180           C-style cast from CFTypeRef to HIViewRef.
181         * Configurations/Base.xcconfig:
182         (WARNING_CFLAGS): Add -Wcast-qual.
183         * Misc/WebElementDictionary.mm:
184         (-[WebElementDictionary objectForKey:]):
185         - Use static_cast<SEL>(const_cast<void*>()) to fix
186           warning.
187         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
188         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
189         (-[NSData _webkit_guessedMIMETypeForXML]):
190         (-[NSData _webkit_guessedMIMEType]):
191         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
192         (_findEOL):
193         (-[NSData _webkit_parseRFC822HeaderFields]):
194         (-[NSData _web_startsWithBlankLine]):
195         (-[NSData _web_locationAfterFirstBlankLine]):
196         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
197           type to Objective-C++.  This fixes the warnings about
198           discarding the `const` modifier when casing from CFStringRef
199           to NSString * because in older clang versions, -Wcast-qual was
200           completely broken when compiling C++ and Objective-C++ source
201           files.  In newer clang versions, discarding the `const`
202           modifier for toll-free bridged types is ignored when compiling
203           Objective-C++ source.
204         - Update copyright and license header.
205         - Use reinterpret_cast<> and static_cast<> to fix warnings
206           unrelated to (NSString *) C-style casts.
207         - Replace use of MIN() macro with std::min<> template functions.
208         - Fix location of `*` for local variables modified above.
209         * Plugins/Hosted/NetscapePluginHostManager.mm:
210         (WebKit::NetscapePluginHostManager::spawnPluginHost):
211         (WebKit::NetscapePluginHostManager::initializeVendorPort):
212         (WebKit::NetscapePluginHostManager::instantiatePlugin):
213         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
214           warnings.
215         * Plugins/Hosted/NetscapePluginHostProxy.mm:
216         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
217         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
218           to fix warning.
219         * Plugins/Hosted/ProxyInstance.mm:
220         (WebKit::ProxyInstance::invoke):
221         - Use static_cast<char*>(const_cast<void*>()) to fix
222           warning when using -[NSData bytes].
223         (WebKit::ProxyInstance::fieldValue const):
224         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
225           to fix warning when using CFDataGetBytePtr().
226         * Plugins/Hosted/WebTextInputWindowController.m:
227         (-[WebTextInputPanel _interpretKeyEvent:string:]):
228         - Use #pragma to ignore -Wcast-qual warning since there
229           is not a good way to avoid this warning in Objective-C.
230         * Plugins/WebNetscapePluginStream.mm:
231         (WebNetscapePluginStream::deliverData):
232         - Use const_cast<void*>() to fix warning when using
233           -[NSData bytes].
234         * Plugins/WebNetscapePluginView.mm:
235         (-[WebNetscapePluginView _createPlugin]):
236         - Change C-style cast to const_cast<char*>() to fix
237           warning.
238         * WebCoreSupport/WebChromeClient.mm:
239         (WebChromeClient::wrapCryptoKey const):
240         (WebChromeClient::unwrapCryptoKey const):
241         - Change C-style cast to
242           static_cast<uint8_t*>(const_cast<void*>() to fix
243           warning.
244         * WebView/WebPDFView.mm:
245         (_applicationInfoForMIMEType):
246         - Change local variable type from 'NSURL *' to
247           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
248           when calling -[NSURL path].
249
250 2018-01-05  Dan Bernstein  <mitz@apple.com>
251
252         Fixed the build following AppKit API deprecations in a recent SDKs
253
254         * WebView/WebFullScreenController.mm:
255         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
256         (-[WebFullScreenController exitFullScreen]): Ditto.
257         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
258         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
259         * WebView/WebHTMLView.mm:
260         (-[WebHTMLView drawRect:]): Ditto.
261         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
262         (-[WebHTMLView knowsPageRange:]): Ditto.
263         * WebView/WebView.mm:
264         (LayerFlushController::flushLayers): Ditto.
265
266 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         [Attachment Support] Create attachment elements when dropping files on iOS
269         https://bugs.webkit.org/show_bug.cgi?id=181192
270         <rdar://problem/36280945>
271
272         Reviewed by Tim Horton.
273
274         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
275
276         * WebCoreSupport/WebPlatformStrategies.h:
277         * WebCoreSupport/WebPlatformStrategies.mm:
278         (WebPlatformStrategies::informationForItemAtIndex):
279         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
280
281 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
282
283         [Attachment Support] Add plumbing for starting a drag with promised blob data
284         https://bugs.webkit.org/show_bug.cgi?id=181201
285
286         Reviewed by Tim Horton.
287
288         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
289
290         * WebCoreSupport/WebDragClient.h:
291
292 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
293
294         Add a WebAuthentication runtime feature flag
295         https://bugs.webkit.org/show_bug.cgi?id=181220
296         <rdar://problem/36055305>
297
298         Reviewed by Brent Fulgham.
299
300         Renames the CredentialManagement runtime feature flag into WebAuthentication.
301
302         * WebView/WebPreferenceKeysPrivate.h:
303         * WebView/WebPreferences.mm:
304         (+[WebPreferences initialize]):
305         (-[WebPreferences webAuthenticationEnabled]):
306         (-[WebPreferences setWebAuthenticationEnabled:]):
307         (-[WebPreferences credentialManagementEnabled]): Deleted.
308         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
309         * WebView/WebPreferencesPrivate.h:
310         * WebView/WebView.mm:
311         (-[WebView _preferencesChanged:]):
312
313 2017-12-22  Jeff Miller  <jeffm@apple.com>
314
315         Update user-visible copyright strings to include 2018
316         https://bugs.webkit.org/show_bug.cgi?id=181141
317
318         Reviewed by Dan Bernstein.
319
320         * Info.plist:
321
322 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
323
324         [Attachment Support] Remove current macOS support for dragging file-backed attachments
325         https://bugs.webkit.org/show_bug.cgi?id=181188
326
327         Reviewed by Dan Bernstein.
328
329         See WebCore/ChangeLog for more detail.
330
331         * WebCoreSupport/WebDragClient.h:
332         * WebCoreSupport/WebDragClient.mm:
333         (WebDragClient::declareAndWriteAttachment): Deleted.
334         * WebView/WebHTMLView.mm:
335         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
336
337 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
338
339         Unreviewed, continue to fix build failures due to AppKit API deprecation
340
341         Wraps more code in -Wdeprecated-declarations.
342
343         * Carbon/HIWebView.mm:
344         (overrideCGContext):
345
346 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
349
350         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
351
352         * Carbon/CarbonWindowAdapter.mm:
353         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
354         * Plugins/WebNetscapePluginView.mm:
355         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
356         (-[WebNetscapePluginView sendDrawRectEvent:]):
357         (-[WebNetscapePluginView drawRect:]):
358
359 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
360
361         Fix build failures due to using deprecated AppKit symbols
362         https://bugs.webkit.org/show_bug.cgi?id=181110
363         <rdar://problem/36162865>
364
365         Reviewed by Dan Bernstein and Tim Horton.
366
367         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
368
369         * Misc/WebKitNSStringExtras.mm:
370         (-[NSString _web_drawAtPoint:font:textColor:]):
371         * Misc/WebNSPasteboardExtras.h:
372         * Misc/WebNSPasteboardExtras.mm:
373         (+[NSPasteboard _web_writableTypesForURL]):
374         (_createWritableTypesForImageWithoutArchive):
375         (_createWritableTypesForImageWithArchive):
376         (+[NSPasteboard _web_dragTypesForURL]):
377         (-[NSPasteboard _web_bestURL]):
378         (-[NSPasteboard _web_writeURL:andTitle:types:]):
379         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
380         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
381         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
382         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
383         * Panels/WebAuthenticationPanel.m:
384         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
385         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
386         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
387         (-[WebHostedNetscapePluginView drawRect:]):
388         * WebInspector/WebNodeHighlightView.mm:
389         (-[WebNodeHighlightView drawRect:]):
390         * WebView/WebFrame.mm:
391         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
392         (-[WebFrame _drawRect:contentsOnly:]):
393         * WebView/WebHTMLView.mm:
394         (kit):
395         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
396         (-[WebHTMLView _plainTextFromPasteboard:]):
397         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
398         (+[WebHTMLView _insertablePasteboardTypes]):
399         (+[WebHTMLView _selectionPasteboardTypes]):
400         (-[WebHTMLView pasteboard:provideDataForType:]):
401         (-[WebHTMLView _writeSelectionToPasteboard:]):
402         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
403         (-[WebHTMLView validRequestorForSendType:returnType:]):
404         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
405         (createMenuItem):
406         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
407         (-[WebHTMLView _colorAsString:]):
408         (-[WebHTMLView copyFont:]):
409         * WebView/WebPDFView.mm:
410         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
411         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
412         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
413         (-[WebPDFView pasteboardTypesForSelection]):
414         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
415         * WebView/WebView.h:
416         * WebView/WebView.mm:
417         (-[WebView performDragOperation:]):
418         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
419         (-[WebView _searchWithGoogleFromMenu:]):
420
421 2017-12-21  Youenn Fablet  <youenn@apple.com>
422
423         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
424         https://bugs.webkit.org/show_bug.cgi?id=181000
425
426         Reviewed by Chris Dumez.
427
428         * Misc/WebCache.mm:
429         (+[WebCache addImageToCache:forURL:forFrame:]):
430
431 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
432
433         Update FULLSCREEN_API feature defines.
434         https://bugs.webkit.org/show_bug.cgi?id=181015
435
436         Reviewed by Tim Horton.
437
438         Change enabled iphone sdk for FULLSCREEN_API.
439
440         * Configurations/FeatureDefines.xcconfig:
441
442 2017-12-21  Jer Noble  <jer.noble@apple.com>
443
444         Add initial DOM support for Media Capabilities
445         https://bugs.webkit.org/show_bug.cgi?id=181064
446
447         Reviewed by Eric Carlson.
448
449         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
450
451         * WebView/WebPreferenceKeysPrivate.h:
452         * WebView/WebPreferences.mm:
453         (+[WebPreferences initialize]):
454         (-[WebPreferences mediaCapabilitiesEnabled]):
455         (-[WebPreferences setMediaCapabilitiesEnabled:]):
456         * WebView/WebPreferencesPrivate.h:
457         * WebView/WebView.mm:
458         (-[WebView _preferencesChanged:]):
459
460 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
461
462         Enable picture-in-picture from inline element on suspend.
463         https://bugs.webkit.org/show_bug.cgi?id=180942
464         rdar://problem/34745234
465
466         Reviewed by Jer Noble.
467
468         Update signature of enterVideoFullscreenForVideoElement().
469
470         * WebCoreSupport/WebChromeClient.h:
471         * WebCoreSupport/WebChromeClient.mm:
472         (WebChromeClient::enterVideoFullscreenForVideoElement):
473
474 2017-12-20  Daniel Bates  <dabates@apple.com>
475
476         Remove Alternative Presentation Button
477         https://bugs.webkit.org/show_bug.cgi?id=180500
478         <rdar://problem/35891047>
479
480         Reviewed by Simon Fraser.
481
482         We no longer need the alternative presentation button.
483
484         * Configurations/FeatureDefines.xcconfig:
485
486 2017-12-19  Jer Noble  <jer.noble@apple.com>
487
488         Playing media elements which call "pause(); play()" will have the play promise rejected.
489         https://bugs.webkit.org/show_bug.cgi?id=180781
490         <rdar://problem/33191377>
491
492         Reviewed by Eric Carlson.
493
494         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
495
496         * WebView/WebView.mm:
497         (shouldRequireUserGestureToLoadVideo):
498
499 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
500
501         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
502         https://bugs.webkit.org/show_bug.cgi?id=180977
503
504         Reviewed by Tim Horton.
505
506         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
507         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
508         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
509
510         * WebCoreSupport/WebEditorClient.mm:
511         (attributesForAttributedStringConversion):
512         * WebView/WebHTMLView.mm:
513         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
514
515 2017-12-18  David Kilzer  <ddkilzer@apple.com>
516
517         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
518
519         Attempt to fix the following warnings:
520
521             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
522
523         For the following instance variables:
524
525             _borderView
526             _contentView
527             _frame
528             _wFlags
529
530         * Carbon/CarbonWindowAdapter.mm:
531         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
532         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
533         (-[CarbonWindowAdapter _termWindowIfOwner]):
534         (-[CarbonWindowAdapter _windowMovedToRect:]):
535         (-[CarbonWindowAdapter setContentView:]):
536         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
537         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
538
539 2017-12-16  Dan Bernstein  <mitz@apple.com>
540
541         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
542         https://bugs.webkit.org/show_bug.cgi?id=180613
543         <rdar://problem/35946124>
544
545         Reviewed by Geoff Garen.
546
547         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
548           clients.
549         * WebView/WebDynamicScrollBarsView.h: Ditto.
550         * WebView/WebDynamicScrollBarsView.mm: Ditto.
551
552 2017-12-14  David Kilzer  <ddkilzer@apple.com>
553
554         Enable -Wstrict-prototypes for WebKit
555         <https://webkit.org/b/180757>
556         <rdar://problem/36024132>
557
558         Rubber-stamped by Joseph Pecoraro.
559
560         * Configurations/Base.xcconfig:
561         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
562
563 2017-12-14  John Wilander  <wilander@apple.com>
564
565         Storage Access API: Implement frame-specific access in the document.cookie layer
566         https://bugs.webkit.org/show_bug.cgi?id=180682
567         <rdar://problem/35982257>
568
569         Reviewed by Alex Christensen.
570
571         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
572         CookiesStrategy::cookieRequestHeaderFieldValue(), and
573         CookiesStrategy::getRawCookies() now take optional parameters for
574         frameID and pageID to allow frame-specific scoping of cookies.
575
576         This change makes the return values of FrameLoaderClient::frameID()
577         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
578         WebCore can call those getters and get the right return values in
579         WebKit and std:nullopt in WebKitLegacy.
580
581         * WebCoreSupport/WebFrameLoaderClient.h:
582         * WebCoreSupport/WebFrameLoaderClient.mm:
583         (WebFrameLoaderClient::pageID const):
584         (WebFrameLoaderClient::frameID const):
585         * WebCoreSupport/WebPlatformStrategies.h:
586         * WebCoreSupport/WebPlatformStrategies.mm:
587         (WebPlatformStrategies::cookiesForDOM):
588         (WebPlatformStrategies::setCookiesFromDOM):
589         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
590         (WebPlatformStrategies::getRawCookies):
591
592 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
593
594         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
595         https://bugs.webkit.org/show_bug.cgi?id=180689
596
597         Reviewed by Tim Horton.
598
599         Use sRGBColorSpaceRef() from WebCore.
600
601         * WebView/WebHTMLView.mm:
602         (imageFromRect):
603
604 2017-12-11  Tim Horton  <timothy_horton@apple.com>
605
606         Stop using deprecated target conditional for simulator builds
607         https://bugs.webkit.org/show_bug.cgi?id=180662
608         <rdar://problem/35136156>
609
610         Reviewed by Simon Fraser.
611
612         * postprocess-headers.sh:
613
614 2017-12-11  David Quesada  <david_quesada@apple.com>
615
616         Turn on ENABLE_APPLICATION_MANIFEST
617         https://bugs.webkit.org/show_bug.cgi?id=180562
618         rdar://problem/35924737
619
620         Reviewed by Geoffrey Garen.
621
622         * Configurations/FeatureDefines.xcconfig:
623
624 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
625
626         Remove pthread_once in favor of dispatch_once
627         https://bugs.webkit.org/show_bug.cgi?id=180591
628
629         Reviewed by Saam Barati.
630
631         * Misc/WebKitErrors.m:
632         (+[NSError _registerWebKitErrors]):
633         (registerErrors): Deleted.
634         * Storage/WebStorageManager.mm:
635         (+[WebStorageManager _storageDirectoryPath]):
636         (initializeLocalStoragePath): Deleted.
637
638 2017-12-07  Darin Adler  <darin@apple.com>
639
640         Remove some unused code from WebKitLegacy
641         https://bugs.webkit.org/show_bug.cgi?id=180567
642
643         Reviewed by Anders Carlsson.
644
645         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
646         macOS (back a few versions) and iOS and removed unused
647         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
648         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
649         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
650         _webkit_stringByCollapsingNonPrintingCharacters,
651         _webkit_stringByCollapsingWhitespaceCharacters,
652         _web_stringWithData:textEncodingName:, and
653         _webkit_localStorageDirectoryWithBundleIdentifier:.
654
655         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
656         this source file.
657         (canUseFastRenderer): Made this faster by not calling u_charDirection for
658         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
659         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
660         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
661         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
662         handle font smoothing options.
663         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
664         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
665         from header and made it a little clearer.
666         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
667         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
668         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
669         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
670         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
671         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
672         implementation a bit and used whole words instead of abbreviations.
673         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
674
675         * Misc/WebNSFileManagerExtras.mm:
676         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
677         filenameByFixingIllegalCharacters function from WebCore directly instead of
678         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
679
680         * Plugins/WebBaseNetscapePluginView.mm:
681         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
682         string replacements instead of _web_stringByStrippingReturnCharacters
683         and to use NSString methods instead of CFString functions.
684
685 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
686
687         Ignore deprecation warnings.
688
689         * WebView/WebHTMLView.mm:
690         (-[NSWindow _web_borderView]):
691         (-[WebHTMLView _setAsideSubviews]):
692         * WebView/WebView.mm:
693         (-[WebView encodeWithCoder:]):
694
695 2017-12-02  Darin Adler  <darin@apple.com>
696
697         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
698         https://bugs.webkit.org/show_bug.cgi?id=180009
699
700         Reviewed by Alex Christensen.
701
702         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
703
704         * Plugins/WebBaseNetscapePluginView.mm:
705         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
706         of strcasecmp.
707
708         * WebView/WebPreferences.mm:
709         (contains): Ditto. Also made this a template so it's easier to call on an array.
710         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
711
712 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
713
714         Limit user agent versioning to an upper bound
715         https://bugs.webkit.org/show_bug.cgi?id=180365
716         <rdar://problem/34550617>
717
718         Reviewed by Joseph Pecoraro.
719
720         * WebView/WebView.mm:
721         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
722         creating the User Agent string.
723         (webKitBundleVersionString): Deleted.
724
725 2017-12-05  Andy Estes  <aestes@apple.com>
726
727         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
728         https://bugs.webkit.org/show_bug.cgi?id=180457
729         <rdar://problem/35143007>
730
731         Reviewed by Tim Horton.
732
733         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
734         check for this macro during post-processing.
735
736         * postprocess-headers.sh:
737
738 2017-12-04  David Quesada  <david_quesada@apple.com>
739
740         Add a class for parsing application manifests
741         https://bugs.webkit.org/show_bug.cgi?id=177973
742         rdar://problem/34747949
743
744         Reviewed by Geoffrey Garen.
745
746         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
747
748 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
749
750         Make LegacyCustomProtocolManager optional for network process
751         https://bugs.webkit.org/show_bug.cgi?id=176230
752
753         Reviewed by Alex Christensen.
754
755         * Configurations/FeatureDefines.xcconfig:
756
757 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
758
759         Fix some NSOperationQueue leaks
760         https://bugs.webkit.org/show_bug.cgi?id=180221
761
762         Reviewed by Wenson Hsieh.
763
764         * WebView/WebView.mm:
765         (-[WebView performDragOperation:]):
766
767 2017-11-30  Darin Adler  <darin@apple.com>
768
769         [Mac] remove unneeded RetainPtr use introduced in r225142
770         https://bugs.webkit.org/show_bug.cgi?id=180202
771
772         Reviewed by Tim Horton.
773
774         * WebView/WebImmediateActionController.mm:
775         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
776         RetainPtr.
777
778 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
779
780         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
781         https://bugs.webkit.org/show_bug.cgi?id=175595
782
783         Reviewed by Darin Adler.
784
785         * WebView/WebPreferences.mm:
786
787 2017-11-27  Tim Horton  <timothy_horton@apple.com>
788
789         One too many zeroes in macOS version number in FeatureDefines
790         https://bugs.webkit.org/show_bug.cgi?id=180011
791
792         Reviewed by Dan Bernstein.
793
794         * Configurations/FeatureDefines.xcconfig:
795
796 2017-11-23  Darin Adler  <darin@apple.com>
797
798         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
799         https://bugs.webkit.org/show_bug.cgi?id=179981
800
801         Reviewed by Sam Weinig.
802
803         * WebView/WebImmediateActionController.mm:
804         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
805         * WebView/WebView.mm:
806         (coreOptions): Use |= instead of | to build up FindOptions.
807
808 2017-11-23  Sam Weinig  <sam@webkit.org>
809
810         Remove unneeded ScriptController::processingUserGesture() forwarding functions
811         https://bugs.webkit.org/show_bug.cgi?id=179954
812
813         Reviewed by Darin Adler.
814
815         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
816         with direct calls to the corresponding UserGestureIndicator functions.
817
818         * Plugins/WebPluginController.mm:
819         (-[WebPluginController processingUserGesture]):
820         * WebView/WebView.mm:
821         (-[WebView _isProcessingUserGesture]):
822
823 2017-11-23  Darin Adler  <darin@apple.com>
824
825         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
826         https://bugs.webkit.org/show_bug.cgi?id=179907
827
828         Reviewed by Sam Weinig.
829
830         * History/BinaryPropertyList.cpp:
831         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
832         (BinaryPropertyListSerializer::appendStringObject): Ditto.
833         * WebView/WebHTMLRepresentation.mm:
834         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
835         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
836
837 2017-11-22  Ali Juma  <ajuma@chromium.org>
838
839         Implement VisualViewport API attributes
840         https://bugs.webkit.org/show_bug.cgi?id=179385
841
842         Reviewed by Frédéric Wang.
843
844         Add a VisualViewportAPI preference.
845
846         * WebView/WebPreferenceKeysPrivate.h:
847         * WebView/WebPreferences.mm:
848         (+[WebPreferences initialize]):
849         (-[WebPreferences visualViewportAPIEnabled]):
850         (-[WebPreferences setVisualViewportAPIEnabled:]):
851         * WebView/WebPreferencesPrivate.h:
852         * WebView/WebView.mm:
853         (-[WebView _preferencesChanged:]):
854
855 2017-11-22  Christopher Reid  <chris.reid@sony.com>
856
857         WebCoreObjCExtras.h is being included in too many places
858         https://bugs.webkit.org/show_bug.cgi?id=179931
859
860         Reviewed by Darin Adler.
861
862         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
863         * Plugins/WebBaseNetscapePluginView.mm:
864         * Plugins/WebBasePluginPackage.mm:
865         * Plugins/WebNetscapePluginStream.mm:
866         * Plugins/WebNetscapePluginView.mm:
867         * WebView/WebTextIterator.mm:
868         * WebView/WebViewData.mm:
869
870 2017-11-22  Commit Queue  <commit-queue@webkit.org>
871
872         Unreviewed, rolling out r225093.
873         https://bugs.webkit.org/show_bug.cgi?id=179938
874
875         Compilation failed on WinCairo 64-bit Release (Requested by
876         fredw on #webkit).
877
878         Reverted changeset:
879
880         "Implement VisualViewport API attributes"
881         https://bugs.webkit.org/show_bug.cgi?id=179385
882         https://trac.webkit.org/changeset/225093
883
884 2017-11-21  Ali Juma  <ajuma@chromium.org>
885
886         Implement VisualViewport API attributes
887         https://bugs.webkit.org/show_bug.cgi?id=179385
888
889         Reviewed by Frédéric Wang.
890
891         Add a VisualViewportAPI preference.
892
893         * WebView/WebPreferenceKeysPrivate.h:
894         * WebView/WebPreferences.mm:
895         (+[WebPreferences initialize]):
896         (-[WebPreferences visualViewportAPIEnabled]):
897         (-[WebPreferences setVisualViewportAPIEnabled:]):
898         * WebView/WebPreferencesPrivate.h:
899         * WebView/WebView.mm:
900         (-[WebView _preferencesChanged:]):
901
902 2017-11-21  Christopher Reid  <chris.reid@sony.com>
903
904         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
905         https://bugs.webkit.org/show_bug.cgi?id=179504
906
907         Reviewed by Darin Adler.
908
909         * Misc/WebKitNSStringExtras.mm:
910         * Plugins/Hosted/NetscapePluginHostManager.mm:
911         * Plugins/WebBasePluginPackage.mm:
912
913 2017-11-19  Tim Horton  <timothy_horton@apple.com>
914
915         Remove unused TOUCH_ICON_LOADING feature flag
916         https://bugs.webkit.org/show_bug.cgi?id=179873
917
918         Reviewed by Simon Fraser.
919
920         * Configurations/FeatureDefines.xcconfig:
921
922 2017-11-19  Tim Horton  <timothy_horton@apple.com>
923
924         Remove unused LEGACY_VENDOR_PREFIXES feature flag
925         https://bugs.webkit.org/show_bug.cgi?id=179872
926
927         Reviewed by Darin Adler.
928
929         * Configurations/FeatureDefines.xcconfig:
930
931 2017-11-16  Daniel Bates  <dabates@apple.com>
932
933         Add feature define for alternative presentation button element
934         https://bugs.webkit.org/show_bug.cgi?id=179692
935         Part of <rdar://problem/34917108>
936
937         Reviewed by Andy Estes.
938
939         Only enabled on Cocoa platforms by default.
940
941         * Configurations/FeatureDefines.xcconfig:
942
943 2017-11-14  Nan Wang  <n_wang@apple.com>
944
945         AX: AOM: Implement AccessibleNode class and support label and role attributes
946         https://bugs.webkit.org/show_bug.cgi?id=179494
947
948         Reviewed by Ryosuke Niwa.
949
950         * WebView/WebPreferenceKeysPrivate.h:
951         * WebView/WebPreferences.mm:
952         (+[WebPreferences initialize]):
953         (-[WebPreferences accessibilityObjectModelEnabled]):
954         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
955         * WebView/WebPreferencesPrivate.h:
956         * WebView/WebView.mm:
957         (-[WebView _preferencesChanged:]):
958
959 2017-11-14  Alex Christensen  <achristensen@webkit.org>
960
961         Remove Cocoa CFURLConnection loading code
962         https://bugs.webkit.org/show_bug.cgi?id=179688
963
964         Reviewed by Antti Koivisto.
965
966         * Misc/WebDownload.mm:
967         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
968         * Misc/WebDownloadInternal.h:
969         * Plugins/WebBaseNetscapePluginView.mm:
970         * WebCoreSupport/WebFrameLoaderClient.mm:
971         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
972         * WebView/WebView.mm:
973         (-[WebView scheduleInRunLoop:forMode:]):
974         (-[WebView unscheduleFromRunLoop:forMode:]):
975
976 2017-11-14  Daniel Bates  <dabates@apple.com>
977
978         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
979         for feature defines
980
981         Following r195498 and r201917 the Visual Studio property files for feature defines have
982         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
983         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
984         files.
985
986         * Configurations/FeatureDefines.xcconfig:
987
988 2017-11-14  Jer Noble  <jer.noble@apple.com>
989
990         Enable Modern EME tests in DumpRenderTree
991         https://bugs.webkit.org/show_bug.cgi?id=179544
992
993         Reviewed by Alex Christensen.
994
995         Add a WebPreferences property to enable the (modern) EME API.
996
997         * WebView/WebPreferenceKeysPrivate.h:
998         * WebView/WebPreferences.mm:
999         (+[WebPreferences initialize]):
1000         (-[WebPreferences encryptedMediaAPIEnabled]):
1001         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1002         * WebView/WebPreferencesPrivate.h:
1003         * WebView/WebView.mm:
1004         (-[WebView _preferencesChanged:]):
1005
1006 2017-11-14  Antti Koivisto  <antti@apple.com>
1007
1008         Enable display:contents by default
1009         https://bugs.webkit.org/show_bug.cgi?id=179655
1010
1011         Reviewed by Sam Weinig.
1012
1013         * WebView/WebPreferences.mm:
1014         (+[WebPreferences initialize]):
1015
1016 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1017
1018         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1019         https://bugs.webkit.org/show_bug.cgi?id=178751
1020
1021         Reviewed by Brady Eidson.
1022
1023         * WebCoreSupport/WebFrameNetworkingContext.mm:
1024         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1025
1026 2017-11-08  Keith Miller  <keith_miller@apple.com>
1027
1028         Async iteration should only fetch the next method once and add feature flag
1029         https://bugs.webkit.org/show_bug.cgi?id=179451
1030
1031         Reviewed by Geoffrey Garen.
1032
1033         Add feature flag for Async iteration.
1034
1035         * Configurations/FeatureDefines.xcconfig:
1036
1037 2017-11-13  Mark Lam  <mark.lam@apple.com>
1038
1039         Add more overflow check book-keeping for MarkedArgumentBuffer.
1040         https://bugs.webkit.org/show_bug.cgi?id=179634
1041         <rdar://problem/35492517>
1042
1043         Reviewed by Saam Barati.
1044
1045         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1046         (WebKit::NetscapePluginInstanceProxy::invoke):
1047         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1048         (WebKit::NetscapePluginInstanceProxy::construct):
1049
1050 2017-11-12  Darin Adler  <darin@apple.com>
1051
1052         More is<> and downcast<>, less static_cast<>
1053         https://bugs.webkit.org/show_bug.cgi?id=179600
1054
1055         Reviewed by Chris Dumez.
1056
1057         * DOM/DOM.mm:
1058         (kit): Use is/downcast.
1059         * WebCoreSupport/WebEditorClient.mm:
1060         (WebEditorClient::handleKeyboardEvent): Ditto.
1061         (WebEditorClient::handleInputMethodKeydown): Ditto.
1062         * WebView/WebHTMLView.mm:
1063         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1064
1065 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1066
1067         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1068         https://bugs.webkit.org/show_bug.cgi?id=179397
1069
1070         Reviewed by Wenson Hsieh.
1071
1072         * DOM/DOMHTMLInputElement.mm:
1073         (-[DOMHTMLInputElement insertTextSuggestion:]):
1074
1075 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1076
1077         HTMLMediaElement should not use element fullscreen on iOS
1078         https://bugs.webkit.org/show_bug.cgi?id=179418
1079         rdar://problem/35409277
1080
1081         Reviewed by Eric Carlson.
1082
1083         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1084
1085         * Configurations/FeatureDefines.xcconfig:
1086
1087 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1088
1089         Make ResourceLoader::willSendRequestInternal asynchronous
1090         https://bugs.webkit.org/show_bug.cgi?id=179251
1091
1092         Reviewed by Andy Estes.
1093
1094         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1095         (WebKit::HostedNetscapePluginStream::start):
1096         * Plugins/WebNetscapePluginStream.mm:
1097         (WebNetscapePluginStream::start):
1098
1099 2017-11-01  Darin Adler  <darin@apple.com>
1100
1101         Simplify event dispatch code and make it a bit more consistent
1102         https://bugs.webkit.org/show_bug.cgi?id=178991
1103
1104         Reviewed by Chris Dumez.
1105
1106         * DOM/DOMEvent.mm:
1107         (-[DOMEvent srcElement]): Call target instead of srcElement.
1108
1109 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1110
1111         [Touch Bar Web API] Add support for menuitem tag
1112         https://bugs.webkit.org/show_bug.cgi?id=179020
1113
1114         Reviewed by Ryosuke Niwa.
1115
1116         Adds in properties and methods that allow the menuitem runtime feature
1117         to be enabled or disabled.
1118
1119         * WebView/WebPreferenceKeysPrivate.h:
1120         * WebView/WebPreferences.mm:
1121         (-[WebPreferences menuItemElementEnabled]):
1122         (-[WebPreferences setMenuItemElementEnabled:]):
1123         * WebView/WebPreferencesPrivate.h:
1124         * WebView/WebView.mm:
1125         (-[WebView _preferencesChanged:]):
1126
1127 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1128
1129         Use CompletionHandlers for redirects
1130         https://bugs.webkit.org/show_bug.cgi?id=179163
1131
1132         Reviewed by Tim Horton.
1133
1134         * Plugins/Hosted/HostedNetscapePluginStream.h:
1135         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1136         (WebKit::HostedNetscapePluginStream::willSendRequest):
1137         * Plugins/WebNetscapePluginStream.h:
1138         * Plugins/WebNetscapePluginStream.mm:
1139         (WebNetscapePluginStream::willSendRequest):
1140
1141 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1142
1143         Add a FileSystem namespace to FileSystem.cpp
1144         https://bugs.webkit.org/show_bug.cgi?id=179063
1145
1146         Reviewed by Darin Adler.
1147
1148         * Misc/WebNSFileManagerExtras.mm:
1149         * Storage/WebDatabaseProvider.mm:
1150
1151 2017-11-02  Frederic Wang  <fwang@igalia.com>
1152
1153         Add references to bug 179167 in FIXME comments
1154         https://bugs.webkit.org/show_bug.cgi?id=179168
1155
1156         Reviewed by Daniel Bates.
1157
1158         * Configurations/FeatureDefines.xcconfig:
1159
1160 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1161
1162         Implement WKFullscreenWindowController for iOS.
1163         https://bugs.webkit.org/show_bug.cgi?id=178924
1164         rdar://problem/34697120
1165
1166         Reviewed by Simon Fraser.
1167
1168         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1169
1170         * Configurations/FeatureDefines.xcconfig:
1171         * WebView/WebView.mm:
1172         (-[WebView fullScreenPlaceholderView]):
1173
1174 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1175
1176         Clean up some drag and drop feature flags
1177         https://bugs.webkit.org/show_bug.cgi?id=179082
1178
1179         Reviewed by Simon Fraser.
1180
1181         * Configurations/FeatureDefines.xcconfig:
1182
1183 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1184
1185         Make it possible to test rubber-banding in overflow scroll
1186         https://bugs.webkit.org/show_bug.cgi?id=179078
1187
1188         Reviewed by Sam Weinig.
1189
1190         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1191         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1192
1193         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1194         functions, since most callers want clamped.
1195
1196         * DOM/DOMHTML.mm:
1197         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1198
1199 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1200
1201         Fix up some content filtering feature flags
1202         https://bugs.webkit.org/show_bug.cgi?id=179079
1203
1204         Reviewed by Simon Fraser.
1205
1206         * Configurations/FeatureDefines.xcconfig:
1207
1208 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1209
1210         [FrameView::layout cleanup] Move core layout logic to a separate class.
1211         https://bugs.webkit.org/show_bug.cgi?id=178771
1212         <rdar://problem/35166542>
1213
1214         Reviewed by Simon Fraser.
1215
1216         Move layout code out from FrameView to LayoutContext.
1217
1218         * WebView/WebClipView.mm:
1219         (-[WebClipView _immediateScrollToPoint:]):
1220         * WebView/WebFrame.mm:
1221         (-[WebFrame layoutCount]):
1222
1223 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1224
1225         Fix issues with WebView subframe painting
1226         https://bugs.webkit.org/show_bug.cgi?id=178842
1227         rdar://problem/34072253
1228
1229         Reviewed by Daniel Bates.
1230         
1231         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1232         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1233         High Sierra, so match the new signature.
1234
1235         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1236
1237         * WebView/WebHTMLView.mm:
1238         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1239         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1240
1241 2017-10-25  Youenn Fablet  <youenn@apple.com>
1242
1243         Enable ServiceWorker to fetch resources
1244         https://bugs.webkit.org/show_bug.cgi?id=178673
1245
1246         Reviewed by Brady Eidson.
1247
1248         * WebCoreSupport/WebFrameLoaderClient.mm:
1249         (WebFrameLoaderClient::pageID const):
1250         (WebFrameLoaderClient::frameID const):
1251         (WebFrameLoaderClient::sessionID const):
1252
1253         Added implementation to the new getters.
1254         They are noop in the context of WK1.
1255
1256 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1257
1258         Web Inspector: Enable WebKit logging configuration and display
1259         https://bugs.webkit.org/show_bug.cgi?id=177027
1260         <rdar://problem/33964767>
1261
1262         Reviewed by Joseph Pecoraro.
1263
1264         * WebCoreSupport/WebChromeClient.mm:
1265         (stringForMessageSource): Deal with Media and WebRTC message sources.
1266
1267 2017-10-20  Antoine Quint  <graouts@apple.com>
1268
1269         [Web Animations] Provide basic timeline and animation interfaces
1270         https://bugs.webkit.org/show_bug.cgi?id=178526
1271
1272         Reviewed by Dean Jackson.
1273
1274         Remove the WEB_ANIMATIONS compile-time flag.
1275
1276         * Configurations/FeatureDefines.xcconfig:
1277         * WebView/WebPreferences.mm:
1278         (+[WebPreferences initialize]):
1279         * WebView/WebView.mm:
1280         (-[WebView _preferencesChanged:]):
1281
1282 2017-10-19  Sam Weinig  <sam@webkit.org>
1283
1284         [Settings] Move global settings into their own file
1285         https://bugs.webkit.org/show_bug.cgi?id=178512
1286
1287         Reviewed by Darin Adler.
1288
1289         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1290
1291         * WebCoreSupport/WebChromeClient.mm:
1292         (WebChromeClient::supportsVideoFullscreen):
1293         * WebView/WebDynamicScrollBarsView.mm:
1294         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1295         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1296         * WebView/WebPreferences.mm:
1297         (+[WebPreferences initialize]):
1298         * WebView/WebView.mm:
1299         (-[WebView _commonInitializationWithFrameName:groupName:]):
1300         (-[WebView _preferencesChanged:]):
1301         (+[WebView _doNotStartObservingNetworkReachability]):
1302
1303 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1304
1305         Replace some stack raw pointers with RefPtrs within WebCore/html
1306         https://bugs.webkit.org/show_bug.cgi?id=178201
1307         <rdar://problem/34841692>
1308
1309         Reviewed by Ryosuke Niwa.
1310
1311         * DOM/DOM.mm:
1312         (kit):
1313         Change the type of node as toNode() is changed to return RefPtr.
1314
1315 2017-10-18  Chris Dumez  <cdumez@apple.com>
1316
1317         [Service Worker] Add stubs for Client / WindowClient / Clients
1318         https://bugs.webkit.org/show_bug.cgi?id=178469
1319
1320         Reviewed by Youenn Fablet.
1321
1322         Rename PageVisiblityState to VisibilityState.
1323
1324         * WebView/WebView.mm:
1325         (kit):
1326
1327 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1328
1329         Unreviewed, rolling out r223291.
1330
1331         See WebCore ChangeLog for more detail.
1332
1333         Reverted changeset:
1334
1335         "Remove Editor::simplifyMarkup"
1336         https://bugs.webkit.org/show_bug.cgi?id=178271
1337         https://trac.webkit.org/changeset/223291
1338
1339 2017-10-17  Keith Miller  <keith_miller@apple.com>
1340
1341         Change WebCore sources to work with unified source builds
1342         https://bugs.webkit.org/show_bug.cgi?id=178229
1343
1344         Rubber stamped by Tim Horton.
1345
1346         * Configurations/FeatureDefines.xcconfig:
1347
1348 2017-10-16  Sam Weinig  <sam@webkit.org>
1349
1350         [Settings] Remove all custom code from Settings.h/cpp
1351         https://bugs.webkit.org/show_bug.cgi?id=178330
1352
1353         Reviewed by Simon Fraser.
1354
1355         * WebView/WebPreferences.mm:
1356         (+[WebPreferences initialize]):
1357         
1358             Update for naming changes of FrameFlattening now that it is an enum class.
1359
1360 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1361
1362         Remove Editor::simplifyMarkup
1363         https://bugs.webkit.org/show_bug.cgi?id=178271
1364
1365         Reviewed by Wenson Hsieh.
1366
1367         * WebView/WebView.mm:
1368         (-[WebView _simplifyMarkup:endNode:]):
1369
1370 2017-10-12  Chris Dumez  <cdumez@apple.com>
1371
1372         [Mac] Add support for MouseEvent.buttons
1373         https://bugs.webkit.org/show_bug.cgi?id=178214
1374
1375         Reviewed by Ryosuke Niwa.
1376
1377         * WebView/WebPDFView.mm:
1378         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1379
1380 2017-10-11  Sam Weinig  <sam@webkit.org>
1381
1382         Remove out-parameter variants of copyToVector
1383         https://bugs.webkit.org/show_bug.cgi?id=178155
1384
1385         Reviewed by Tim Horton.
1386
1387         * Plugins/WebNetscapePluginView.mm:
1388         (-[WebNetscapePluginView destroyPlugin]):
1389         * WebView/WebHTMLRepresentation.mm:
1390         (newArrayWithStrings):
1391
1392             Replace out-parameter based copyToVector, with one that returns a Vector.
1393
1394 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1395
1396         Sanitize URL in pasteboard for other applications and cross origin content
1397         https://bugs.webkit.org/show_bug.cgi?id=178060
1398         <rdar://problem/34874518>
1399
1400         Reviewed by Wenson Hsieh.
1401
1402         * WebCoreSupport/WebPlatformStrategies.h:
1403         * WebCoreSupport/WebPlatformStrategies.mm:
1404         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1405
1406 2017-10-11  Chris Dumez  <cdumez@apple.com>
1407
1408         Modernize Geolocation code
1409         https://bugs.webkit.org/show_bug.cgi?id=178148
1410
1411         Reviewed by Ryosuke Niwa.
1412
1413         * WebCoreSupport/WebGeolocationClient.h:
1414         * WebCoreSupport/WebGeolocationClient.mm:
1415         (WebGeolocationClient::lastPosition):
1416         * WebView/WebGeolocationPosition.mm:
1417         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1418         (core):
1419         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1420         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1421         * WebView/WebGeolocationPositionInternal.h:
1422
1423 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1426         https://bugs.webkit.org/show_bug.cgi?id=178154
1427
1428         Reviewed by Wenson Hsieh.
1429
1430         Enable custom pasteboard data by default.
1431
1432         * WebView/WebPreferenceKeysPrivate.h:
1433         * WebView/WebPreferences.mm:
1434         (+[WebPreferences initialize]):
1435         (-[WebPreferences customPasteboardDataEnabled]): Added.
1436         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1437         * WebView/WebPreferencesPrivate.h:
1438         * WebView/WebView.mm:
1439         (-[WebView _preferencesChanged:]):
1440
1441 2017-10-10  Sam Weinig  <sam@webkit.org>
1442
1443         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1444         https://bugs.webkit.org/show_bug.cgi?id=178102
1445
1446         Reviewed by Tim Horton.
1447
1448         * History/WebHistory.mm:
1449         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1450         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1451         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1452         * WebCoreSupport/WebUserMediaClient.mm:
1453         (WebUserMediaClient::pageDestroyed):
1454
1455 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1456
1457         Make the names of the options consistent
1458         https://bugs.webkit.org/show_bug.cgi?id=177933
1459
1460         Reviewed by Saam Barati.
1461
1462         * WebView/WebFrame.h:
1463         * WebView/WebHTMLView.mm:
1464         (-[WebHTMLView setMarkedText:selectedRange:]):
1465         * WebView/WebView.h:
1466
1467 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1468
1469         [iOS] Tweak support for classifying form controls (followup to r222487)
1470         https://bugs.webkit.org/show_bug.cgi?id=177917
1471         <rdar://problem/34820122>
1472
1473         Reviewed by Dean Jackson.
1474
1475         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1476
1477         * DOM/DOMHTMLInputElement.mm:
1478         (-[DOMHTMLInputElement _autofillContext]):
1479         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1480         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1481
1482 2017-10-05  Keith Miller  <keith_miller@apple.com>
1483
1484         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1485
1486         * Configurations/WebKitLegacy.xcconfig:
1487
1488 2017-10-05  Jer Noble  <jer.noble@apple.com>
1489
1490         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1491         https://bugs.webkit.org/show_bug.cgi?id=177261
1492
1493         Reviewed by Eric Carlson.
1494
1495         * Configurations/FeatureDefines.xcconfig:
1496
1497 2017-10-05  Chris Dumez  <cdumez@apple.com>
1498
1499         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1500         https://bugs.webkit.org/show_bug.cgi?id=177957
1501
1502         Reviewed by Alex Christensen.
1503
1504         * WebCoreSupport/WebPlatformStrategies.h:
1505         * WebCoreSupport/WebPlatformStrategies.mm:
1506         (WebPlatformStrategies::cookiesEnabled):
1507
1508 2017-10-05  Youenn Fablet  <youenn@apple.com>
1509
1510         Make LibWebRTCProvider port agnostic
1511         https://bugs.webkit.org/show_bug.cgi?id=177747
1512
1513         Reviewed by Alex Christensen & Alex Garcia.
1514
1515         * WebView/WebView.mm:
1516         (-[WebView _commonInitializationWithFrameName:groupName:]):
1517         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1518
1519 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1520
1521         Stop linking with WebKitSystemInterface
1522         https://bugs.webkit.org/show_bug.cgi?id=177915
1523
1524         Reviewed by Antti Koivisto.
1525
1526         * Configurations/DebugRelease.xcconfig:
1527         * Configurations/WebKitLegacy.xcconfig:
1528
1529 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1530
1531         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1532         https://bugs.webkit.org/show_bug.cgi?id=177912
1533
1534         Reviewed by Saam Barati.
1535
1536         * Carbon/CarbonUtils.m:
1537         * Carbon/CarbonWindowAdapter.mm:
1538         * Carbon/HIWebView.mm:
1539         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1540         * Misc/WebNSFileManagerExtras.mm:
1541         * Misc/WebNSPasteboardExtras.mm:
1542         * Misc/WebNSURLExtras.mm:
1543         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1544         * Plugins/Hosted/NetscapePluginHostManager.mm:
1545         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1546         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1547         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1548         * Plugins/Hosted/WebTextInputWindowController.m:
1549         * Plugins/WebBaseNetscapePluginView.mm:
1550         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1551         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1552         * Plugins/WebNetscapePluginStream.mm:
1553         * Plugins/WebNetscapePluginView.mm:
1554         * Plugins/WebPluginDatabase.mm:
1555         * WebCoreSupport/PopupMenuMac.mm:
1556         * WebCoreSupport/WebChromeClient.mm:
1557         * WebCoreSupport/WebFrameLoaderClient.mm:
1558         * WebCoreSupport/WebInspectorClient.mm:
1559         * WebCoreSupport/WebPlatformStrategies.mm:
1560         * WebCoreSupport/WebSystemInterface.mm:
1561         * WebView/WebDynamicScrollBarsView.mm:
1562         * WebView/WebFrame.mm:
1563         * WebView/WebFrameView.mm:
1564         * WebView/WebFullScreenController.mm:
1565         * WebView/WebHTMLView.mm:
1566         * WebView/WebPreferences.mm:
1567         * WebView/WebView.mm:
1568
1569 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1570
1571         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1572         rdar://problem/34705779
1573
1574         Addressing review comments that I somehow landed without.
1575
1576         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1577
1578 2017-09-29  Chris Dumez  <cdumez@apple.com>
1579
1580         Split some logic out of VisitedLinkStore and make it reusable
1581         https://bugs.webkit.org/show_bug.cgi?id=177575
1582
1583         Reviewed by Alex Christensen.
1584
1585         * WebCoreSupport/WebVisitedLinkStore.h:
1586         * WebCoreSupport/WebVisitedLinkStore.mm:
1587         (WebVisitedLinkStore::addVisitedLink):
1588         (WebVisitedLinkStore::removeVisitedLink):
1589         (WebVisitedLinkStore::isLinkVisited):
1590         (WebVisitedLinkStore::addVisitedLinkHash):
1591
1592 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1593
1594         Build fix for High Sierra 32 bit Mac
1595         https://bugs.webkit.org/show_bug.cgi?id=177551
1596         <rdar://problem/34690283>
1597
1598         Reviewed by Alexey Proskuryakov.
1599
1600         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1601         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1602         also made.
1603
1604         * Carbon/CarbonWindowAdapter.mm:
1605         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1606         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1607         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1608         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1609         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1610         (-[CarbonWindowAdapter dealloc]):
1611         (-[CarbonWindowAdapter windowRef]):
1612         (-[CarbonWindowAdapter _hasWindowRef]):
1613         (-[CarbonWindowAdapter _managesWindowRef]):
1614         (-[CarbonWindowAdapter _removeWindowRef]):
1615         (-[CarbonWindowAdapter _carbonWindowClass]):
1616         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1617         (-[CarbonWindowAdapter sendSuperEvent:]):
1618         (-[CarbonWindowAdapter relinquishFocus]):
1619         (-[CarbonWindowAdapter _cancelKey:]):
1620         (-[CarbonWindowAdapter _commonAwake]):
1621         (-[CarbonWindowAdapter _destroyRealWindow:]):
1622         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1623         (-[CarbonWindowAdapter _termWindowIfOwner]):
1624         (-[CarbonWindowAdapter _windowMovedToRect:]):
1625         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1626         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1627         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1628         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1629         (-[CarbonWindowAdapter canBecomeMainWindow]):
1630         (-[CarbonWindowAdapter encodeWithCoder:]):
1631         (-[CarbonWindowAdapter initWithCoder:]):
1632         (-[CarbonWindowAdapter setContentView:]):
1633         (-[CarbonWindowAdapter worksWhenModal]):
1634         (-[CarbonWindowAdapter _setModalWindowLevel]):
1635         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1636         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1637         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1638         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1639         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1640         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1641         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1642         (NSCarbonWindowHandleEvent):
1643         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1644         (-[CarbonWindowAdapter _growBoxRect]):
1645         * Carbon/HIWebView.mm:
1646         (HIWebViewGetWebView):
1647         (HIWebViewConstructor):
1648         (HIWebViewDestructor):
1649         (HIWebViewRegisterClass):
1650         (GetBehaviors):
1651         (Draw):
1652         (HitTest):
1653         (GetRegion):
1654         (GetWindowRef):
1655         (CreateNSEventAdoptingCGEvent):
1656         (CopyEventCGEvent):
1657         (CreateNSEventWithCarbonClickEvent):
1658         (Click):
1659         (CreateNSEventWithCarbonEvent):
1660         (MouseUp):
1661         (CreateNSEventWithCarbonMouseMoveEvent):
1662         (MouseMoved):
1663         (MouseDragged):
1664         (MouseWheelMoved):
1665         (ContextMenuClick):
1666         (GetKind):
1667         (BoundsChanged):
1668         (OwningWindowChanged):
1669         (WindowHandler):
1670         (SyncFrame):
1671         (SetFocusPart):
1672         (AdvanceFocus):
1673         (RelinquishFocus):
1674         (ActiveStateChanged):
1675         (ProcessCommand):
1676         (UpdateCommandStatus):
1677         (_NSSelectorForHICommand):
1678         (HIWebViewEventHandler):
1679         (StartUpdateObserver):
1680         (StopUpdateObserver):
1681         (UpdateObserver):
1682
1683 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1684
1685         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1686         https://bugs.webkit.org/show_bug.cgi?id=172526
1687         <rdar://problem/32396081>
1688
1689         Reviewed by Ryosuke Niwa.
1690
1691         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1692
1693         * WebCoreSupport/WebPlatformStrategies.h:
1694         * WebCoreSupport/WebPlatformStrategies.mm:
1695         (WebPlatformStrategies::webExposedTypes):
1696         (WebPlatformStrategies::writeCustomData):
1697
1698 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1699
1700         Unreviewed, rolling out r222567.
1701
1702         This broke and internal build.
1703
1704         Reverted changeset:
1705
1706         "Build fix for High Sierra 32 bit Mac"
1707         https://bugs.webkit.org/show_bug.cgi?id=177551
1708         http://trac.webkit.org/changeset/222567
1709
1710 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1711
1712         Build fix for High Sierra 32 bit Mac
1713         https://bugs.webkit.org/show_bug.cgi?id=177551
1714         <rdar://problem/34690283>
1715
1716         Reviewed by Alexey Proskuryakov.
1717
1718         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1719         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1720         also made.
1721
1722         * Carbon/CarbonWindowAdapter.mm:
1723         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1724         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1725         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1726         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1727         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1728         (-[CarbonWindowAdapter dealloc]):
1729         (-[CarbonWindowAdapter windowRef]):
1730         (-[CarbonWindowAdapter _hasWindowRef]):
1731         (-[CarbonWindowAdapter _managesWindowRef]):
1732         (-[CarbonWindowAdapter _removeWindowRef]):
1733         (-[CarbonWindowAdapter _carbonWindowClass]):
1734         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1735         (-[CarbonWindowAdapter sendSuperEvent:]):
1736         (-[CarbonWindowAdapter relinquishFocus]):
1737         (-[CarbonWindowAdapter _cancelKey:]):
1738         (-[CarbonWindowAdapter _commonAwake]):
1739         (-[CarbonWindowAdapter _destroyRealWindow:]):
1740         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1741         (-[CarbonWindowAdapter _termWindowIfOwner]):
1742         (-[CarbonWindowAdapter _windowMovedToRect:]):
1743         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1744         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1745         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1746         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1747         (-[CarbonWindowAdapter canBecomeMainWindow]):
1748         (-[CarbonWindowAdapter encodeWithCoder:]):
1749         (-[CarbonWindowAdapter initWithCoder:]):
1750         (-[CarbonWindowAdapter setContentView:]):
1751         (-[CarbonWindowAdapter worksWhenModal]):
1752         (-[CarbonWindowAdapter _setModalWindowLevel]):
1753         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1754         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1755         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1756         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1757         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1758         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1759         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1760         (NSCarbonWindowHandleEvent):
1761         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1762         (-[CarbonWindowAdapter _growBoxRect]):
1763         * Carbon/HIWebView.mm:
1764         (HIWebViewGetWebView):
1765         (HIWebViewConstructor):
1766         (HIWebViewDestructor):
1767         (HIWebViewRegisterClass):
1768         (GetBehaviors):
1769         (Draw):
1770         (HitTest):
1771         (GetRegion):
1772         (GetWindowRef):
1773         (CreateNSEventAdoptingCGEvent):
1774         (CopyEventCGEvent):
1775         (CreateNSEventWithCarbonClickEvent):
1776         (Click):
1777         (CreateNSEventWithCarbonEvent):
1778         (MouseUp):
1779         (CreateNSEventWithCarbonMouseMoveEvent):
1780         (MouseMoved):
1781         (MouseDragged):
1782         (MouseWheelMoved):
1783         (ContextMenuClick):
1784         (GetKind):
1785         (BoundsChanged):
1786         (OwningWindowChanged):
1787         (WindowHandler):
1788         (SyncFrame):
1789         (SetFocusPart):
1790         (AdvanceFocus):
1791         (RelinquishFocus):
1792         (ActiveStateChanged):
1793         (ProcessCommand):
1794         (UpdateCommandStatus):
1795         (_NSSelectorForHICommand):
1796         (HIWebViewEventHandler):
1797         (StartUpdateObserver):
1798         (StopUpdateObserver):
1799         (UpdateObserver):
1800
1801 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1802
1803         Make PolicyAction an encodable enum class
1804         https://bugs.webkit.org/show_bug.cgi?id=177480
1805
1806         Reviewed by Antti Koivisto.
1807
1808         * Plugins/WebPluginContainerCheck.mm:
1809         (-[WebPluginContainerCheck _continueWithPolicy:]):
1810         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1811         * WebCoreSupport/WebFrameLoaderClient.mm:
1812         (-[WebFramePolicyListener invalidate]):
1813         (-[WebFramePolicyListener ignore]):
1814         (-[WebFramePolicyListener download]):
1815         (-[WebFramePolicyListener use]):
1816         (-[WebFramePolicyListener continue]):
1817         * WebView/WebPolicyDelegate.mm:
1818         (-[WebPolicyDecisionListener use]):
1819         (-[WebPolicyDecisionListener ignore]):
1820         (-[WebPolicyDecisionListener download]):
1821
1822 2017-09-25  Frederik Riedel  <riedel@apple.com>
1823
1824         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1825         https://bugs.webkit.org/show_bug.cgi?id=174394
1826         <rdar://problem/33183504>
1827
1828         Reviewed by Ryosuke Niwa.
1829
1830         * DOM/DOMHTMLInputElement.h:
1831         * DOM/DOMHTMLInputElement.mm:
1832         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1833         Determines if this HTMLInputElement is part of a login screen.
1834         (-[DOMHTMLInputElement representingPageUrl]):
1835         Returns the webpage's URL that is currently displayed in the Web View.
1836         (-[DOMHTMLInputElement insertTextSuggestion:]):
1837         Inserts login credentials into the Web View.
1838
1839 2017-09-25  Sam Weinig  <sam@webkit.org>
1840
1841         Remove unused EditorClient functions
1842         https://bugs.webkit.org/show_bug.cgi?id=177463
1843
1844         Reviewed by Alex Christensen.
1845
1846         Remove unused EditorClient functions.
1847
1848         * WebCoreSupport/WebEditorClient.h:
1849         * WebCoreSupport/WebEditorClient.mm:
1850         (WebEditorClient::canonicalizeURL): Deleted.
1851         (WebEditorClient::canonicalizeURLString): Deleted.
1852         (WebEditorClient::writeDataToPasteboard): Deleted.
1853         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1854         (WebEditorClient::readDataFromPasteboard): Deleted.
1855         (WebEditorClient::pasteboardChangeCount): Deleted.
1856
1857 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1858
1859         Stop using PolicyCallback
1860         https://bugs.webkit.org/show_bug.cgi?id=176088
1861
1862         Reviewed by Andy Estes.
1863
1864         * WebCoreSupport/WebFrameLoaderClient.mm:
1865         (-[WebFramePolicyListener invalidate]):
1866         (-[WebFramePolicyListener receivedPolicyDecision:]):
1867
1868 2017-09-25  Sam Weinig  <sam@webkit.org>
1869
1870         Remove unnecessary userVisibleString EditorClient function
1871         https://bugs.webkit.org/show_bug.cgi?id=177456
1872
1873         Reviewed by Dan Bernstein.
1874
1875         * WebCoreSupport/WebEditorClient.h:
1876         * WebCoreSupport/WebEditorClient.mm:
1877         (WebEditorClient::userVisibleString): Deleted.
1878
1879             Remove userVisibleString client function.
1880
1881 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1882
1883         Separate form submission from PolicyChecker infrastructure
1884         https://bugs.webkit.org/show_bug.cgi?id=177396
1885
1886         Reviewed by Geoffrey Garen.
1887
1888         * WebCoreSupport/WebFrameLoaderClient.h:
1889         * WebCoreSupport/WebFrameLoaderClient.mm:
1890         (WebFrameLoaderClient::dispatchWillSubmitForm):
1891
1892 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1893
1894         WeakPtrFactory should populate m_ref lazily.
1895         https://bugs.webkit.org/show_bug.cgi?id=177375
1896
1897         Reviewed by Geoffrey Garen.
1898
1899         * WebCoreSupport/WebEditorClient.mm:
1900         (WebEditorClient::WebEditorClient):
1901         (WebEditorClient::requestCandidatesForSelection):
1902
1903 2017-09-22  Chris Dumez  <cdumez@apple.com>
1904
1905         Use high resolution timestamp for event time
1906         https://bugs.webkit.org/show_bug.cgi?id=154246
1907         <rdar://problem/34333304>
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         Use WallTime / MonotonicTime instead of double type for clarity.
1912
1913         * DOM/DOMEvent.mm:
1914         (-[DOMEvent timeStamp]):
1915         * WebView/WebFrame.mm:
1916         (-[WebFrame _dragSourceEndedAt:operation:]):
1917         * WebView/WebPDFView.mm:
1918         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1919
1920 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1921
1922         Enable dataTransfer.items on macOS and iOS
1923         https://bugs.webkit.org/show_bug.cgi?id=177335
1924
1925         Reviewed by Sam Weinig.
1926
1927         * WebView/WebPreferences.mm:
1928         (+[WebPreferences initialize]):
1929
1930 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1931
1932         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1933         https://bugs.webkit.org/show_bug.cgi?id=177101
1934         <rdar://problem/34500648>
1935
1936         Reviewed by Brian Burg.
1937
1938         * WebInspector/WebNodeHighlight.mm:
1939         Ensure we close the window that we have just removed.
1940
1941 2017-09-20  Antti Koivisto  <antti@apple.com>
1942
1943         Remove DOM and styling support for CSS Regions
1944         https://bugs.webkit.org/show_bug.cgi?id=177221
1945
1946         Reviewed by Andreas Kling.
1947
1948         * Configurations/FeatureDefines.xcconfig:
1949         * DOM/DOMCSS.mm:
1950         (kitClass):
1951         * DOM/DOMElement.mm:
1952         (-[DOMElement webkitRegionOverset]): Deleted.
1953
1954 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1955
1956         Layering violation in Editor::createFragment
1957         https://bugs.webkit.org/show_bug.cgi?id=176123
1958
1959         Reviewed by Darin Adler.
1960
1961         * Misc/WebNSURLExtras.h:
1962         * Misc/WebNSURLExtras.mm:
1963         * WebView/WebFrame.mm:
1964         * WebView/WebHTMLView.mm:
1965         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1966
1967         * WebCoreSupport/WebEditorClient.mm:
1968         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1969         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1970         way to avoid exporting the symbol just on newer OSes.
1971
1972 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1973
1974         On iOS, getData can't get text set by setData during copy event
1975         https://bugs.webkit.org/show_bug.cgi?id=176980
1976         <rdar://problem/34453915>
1977
1978         Reviewed by Darin Adler.
1979
1980         * WebCoreSupport/WebPlatformStrategies.h:
1981         * WebCoreSupport/WebPlatformStrategies.mm:
1982         (WebPlatformStrategies::copy): Deleted.
1983
1984 2017-09-18  Andy Estes  <aestes@apple.com>
1985
1986         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1987         https://bugs.webkit.org/show_bug.cgi?id=177029
1988
1989         Reviewed by Alex Christensen.
1990
1991         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1992         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1993         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1994         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1995         * WebCoreSupport/PopupMenuMac.mm:
1996         (PopupMenuMac::show):
1997         * WebCoreSupport/WebSystemInterface.mm:
1998         (InitWebCoreSystemInterface):
1999         * WebView/WebHTMLView.mm:
2000         (-[WebHTMLView setDataSource:]):
2001         (-[WebHTMLView attachRootLayer:]):
2002         * WebView/WebView.mm:
2003         (-[WebView _needsAdobeFrameReloadingQuirk]):
2004         (-[WebView _needsLinkElementTextCSSQuirk]):
2005         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2006         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2007         (-[WebView _preferencesChanged:]):
2008
2009 2017-09-15  Andy Estes  <aestes@apple.com>
2010
2011         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2012         https://bugs.webkit.org/show_bug.cgi?id=176953
2013
2014         Reviewed by Eric Carlson.
2015
2016         * WebCoreSupport/WebSystemInterface.mm:
2017         (InitWebCoreSystemInterface):
2018
2019 2017-09-14  Andy Estes  <aestes@apple.com>
2020
2021         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2022         https://bugs.webkit.org/show_bug.cgi?id=176931
2023
2024         Reviewed by Joseph Pecoraro.
2025
2026         * WebCoreSupport/WebSystemInterface.mm:
2027         (InitWebCoreSystemInterface):
2028
2029 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2030
2031         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2032         https://bugs.webkit.org/show_bug.cgi?id=176867
2033
2034         Reviewed by Sam Weinig.
2035
2036         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2037         (WebKit::NetscapePluginInstanceProxy::enumerate):
2038
2039 2017-09-13  Andy Estes  <aestes@apple.com>
2040
2041         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2042         https://bugs.webkit.org/show_bug.cgi?id=176729
2043
2044         Reviewed by Alex Christensen.
2045
2046         * WebCoreSupport/WebSystemInterface.mm:
2047         (InitWebCoreSystemInterface):
2048         * WebView/WebView.mm:
2049         (+[WebView _setCacheModel:]):
2050
2051 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2052
2053         Refactor WebContentReader out of EditorMac and EditorIOS
2054         https://bugs.webkit.org/show_bug.cgi?id=176770
2055
2056         Reviewed by Sam Weinig.
2057
2058         * WebCoreSupport/WebEditorClient.mm:
2059
2060 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2061
2062         Dragging & dropping a file creates an attachment element even when it's disabled
2063         https://bugs.webkit.org/show_bug.cgi?id=176769
2064
2065         Reviewed by Tim Horton.
2066
2067         * WebView/WebView.mm:
2068         (-[WebView _preferencesChanged:]):
2069
2070 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2073         https://bugs.webkit.org/show_bug.cgi?id=176721
2074         <rdar://problem/34373660>
2075
2076         Reviewed by Tim Horton.
2077
2078         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2079         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2080
2081         * WebView/WebView.mm:
2082         (-[WebView _startDrag:]):
2083         (-[WebView _draggedElementBounds]):
2084         (-[WebView _endedDataInteraction:global:]):
2085         * WebView/WebViewData.h:
2086
2087 2017-09-11  Andy Estes  <aestes@apple.com>
2088
2089         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2090         https://bugs.webkit.org/show_bug.cgi?id=176472
2091
2092         Reviewed by Eric Carlson.
2093
2094         * WebCoreSupport/WebSystemInterface.mm:
2095         (InitWebCoreSystemInterface):
2096
2097 2017-09-09  Mark Lam  <mark.lam@apple.com>
2098
2099         Avoid duplicate computations of ExecState::vm().
2100         https://bugs.webkit.org/show_bug.cgi?id=176647
2101
2102         Reviewed by Saam Barati.
2103
2104         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2105         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2106         (WebKit::NetscapePluginInstanceProxy::construct):
2107         (WebKit::NetscapePluginInstanceProxy::setProperty):
2108         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2109         (WebKit::NetscapePluginInstanceProxy::enumerate):
2110         * Plugins/Hosted/ProxyInstance.mm:
2111         (WebKit::ProxyRuntimeMethod::create):
2112
2113 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2114
2115         Unreviewed, rolling out r221773.
2116         https://bugs.webkit.org/show_bug.cgi?id=176614
2117
2118         This caused build failures. (Requested by mlewis13 on
2119         #webkit).
2120
2121         Reverted changeset:
2122
2123         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2124         https://bugs.webkit.org/show_bug.cgi?id=176472
2125         http://trac.webkit.org/changeset/221773
2126
2127 2017-09-07  Andy Estes  <aestes@apple.com>
2128
2129         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2130         https://bugs.webkit.org/show_bug.cgi?id=176472
2131
2132         Reviewed by Eric Carlson.
2133
2134         * WebCoreSupport/WebSystemInterface.mm:
2135         (InitWebCoreSystemInterface):
2136
2137 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2138
2139         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2140         https://bugs.webkit.org/show_bug.cgi?id=176561
2141
2142         Reviewed by Brent Fulgham.
2143
2144         * Misc/WebNSUserDefaultsExtras.mm:
2145
2146 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2147
2148         Modernize Geolocation code
2149         https://bugs.webkit.org/show_bug.cgi?id=176496
2150
2151         Reviewed by Andy Estes.
2152
2153         * WebCoreSupport/WebGeolocationClient.h:
2154         * WebCoreSupport/WebGeolocationClient.mm:
2155         (WebGeolocationClient::requestPermission):
2156         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2157         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2158         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2159         * WebView/WebView.mm:
2160         (-[WebView _commonInitializationWithFrameName:groupName:]):
2161         (-[WebView _geolocationDidFailWithMessage:]):
2162
2163 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2164
2165         Remove some unused bits of code and resources
2166         https://bugs.webkit.org/show_bug.cgi?id=176275
2167
2168         Reviewed by Dan Bernstein.
2169
2170         * Misc/WebNSFileManagerExtras.mm:
2171         Include FileSystem instead of FileSystemIOS.
2172
2173 2017-09-03  Darin Adler  <darin@apple.com>
2174
2175         [Cocoa] Tidy a few things in legacy WebHTMLView
2176         https://bugs.webkit.org/show_bug.cgi?id=176280
2177
2178         Reviewed by Dan Bernstein.
2179
2180         * WebCoreSupport/WebChromeClient.mm:
2181         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2182         methods it calls on WebHTMLView were doing nothing on iOS.
2183
2184         * WebView/WebFrame.mm:
2185         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2186         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2187
2188         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2189         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2190         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2191         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2192         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2193         Use RetainPtr instead of writing retain/release wherever possible.
2194         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2195         initialization for it. Removed various unused methods and declarations of methods.
2196         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2197         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2198         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2199         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2200         and remove CFRetain no longer needed since we don't support garbage collection any more.
2201         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2202         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2203         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2204         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2205         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2206         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2207         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2208         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2209         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2210         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2211         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2212         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2213         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2214         debug flag; we haven't used it for years and it's not clearly helpful.
2215         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2216         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2217         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2218         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2219         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2220         two additional methods in the WebPrivate category and still be called by the two
2221         methods in the WebInternal category that were already using it.
2222         (-[WebHTMLView didAddSubview:]): Deleted.
2223         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2224         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2225         place this was called, the close method.
2226         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2227         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2228         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2229         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2230         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2231         Added helper method to make the one below simpler.
2232         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2233         Compared pasteboard type strings using isEqualToString: rather than using == since
2234         we want to actually compare the string contents. Also updated to use modern for loop,
2235         renamed a local variable from "s" to "localSubresources", and factored out the handling
2236         of three image types to use the helper method above.
2237         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2238         _web_makePluginSubviewsPerformSelector:withObject: method.
2239         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2240         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2241         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2242         not call the -[NSView subviews] method to make this identical on both platforms and used
2243         a modern for loop.
2244         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2245         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2246         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2247         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2248         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2249         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2250         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2251         of it is Mac-only.
2252         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2253         method did was call itself on the main thread, and do nothing if called on main thread.
2254         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2255         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2256         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2257         half of this method.
2258         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2259         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2260         Simplified using a modern for loop and RetainPtr.
2261         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2262         (-[WebHTMLView keyDown:]): Ditto.
2263         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2264         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2265         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2266         (-[WebHTMLView complete:]): Ditto.
2267         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2268         now macOS-only.
2269         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2270         iOS since that is now macOS-only.
2271         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2272         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2273         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2274         and reorganized to use early return.
2275         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2276         on iOS, but kept there so we don't have to do #if at every call site.
2277         (-[WebHTMLView _pluginController]): Moved into internal category.
2278         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2279         there only for GC, using C++ initialization, removing obsolete comment.
2280         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2281         peculiar iOS-only comment.
2282         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2283
2284         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2285         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2286         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2287         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2288         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2289
2290         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2291         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2292         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2293         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2294         them at this time.
2295
2296 2017-09-03  Sam Weinig  <sam@webkit.org>
2297
2298         Remove CanvasProxy
2299         https://bugs.webkit.org/show_bug.cgi?id=176288
2300
2301         Reviewed by Yusuke Suzuki.
2302
2303         CanvasProxy does not appear to be in any current HTML spec
2304         and was disabled and unimplemented in our tree. Time to 
2305         get rid of it.
2306
2307         * Configurations/FeatureDefines.xcconfig:
2308
2309 2017-09-02  Andy Estes  <aestes@apple.com>
2310
2311         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2312         https://bugs.webkit.org/show_bug.cgi?id=176270
2313
2314         Reviewed by Tim Horton.
2315
2316         * Plugins/Hosted/NetscapePluginHostManager.mm:
2317         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2318         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2319         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2320         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2321         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2322         (WebKit::SoftwareCARenderer::context const):
2323         (WebKit::SoftwareCARenderer::renderContext const):
2324         (WebKit::SoftwareCARenderer::render):
2325         (-[WebHostedNetscapePluginView createPlugin]):
2326         (-[WebHostedNetscapePluginView createPluginLayer]):
2327         (-[WebHostedNetscapePluginView destroyPlugin]):
2328         (-[WebHostedNetscapePluginView drawRect:]):
2329         * WebCoreSupport/WebSystemInterface.mm:
2330         (InitWebCoreSystemInterface):
2331
2332 2017-09-01  Andy Estes  <aestes@apple.com>
2333
2334         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2335         https://bugs.webkit.org/show_bug.cgi?id=176200
2336
2337         Reviewed by Tim Horton.
2338
2339         * Carbon/HIWebView.mm:
2340         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2341         (overrideCGContext):
2342         (restoreCGContext):
2343         (Draw):
2344         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2345         (+[WebHostedNetscapePluginView initialize]):
2346         * Plugins/WebBaseNetscapePluginView.h:
2347         * Plugins/WebBaseNetscapePluginView.mm:
2348         (WebKit::sendUserChangeNotifications):
2349         * Plugins/WebNetscapePluginView.mm:
2350         (+[WebNetscapePluginView initialize]):
2351         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2352         * WebCoreSupport/WebSystemInterface.mm:
2353         (InitWebCoreSystemInterface):
2354         * WebView/WebFrame.mm:
2355         (-[WebFrame _paintBehaviorForDestinationContext:]):
2356         * WebView/WebFullScreenController.mm:
2357         (setClipRectForWindow):
2358         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2359         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2360         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2361         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2362
2363 2017-08-31  Andy Estes  <aestes@apple.com>
2364
2365         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2366         https://bugs.webkit.org/show_bug.cgi?id=176175
2367
2368         Reviewed by Brady Eidson.
2369
2370         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2371         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2372         * Plugins/Hosted/WebTextInputWindowController.m:
2373         (-[WebTextInputPanel init]):
2374         * WebCoreSupport/WebSystemInterface.mm:
2375         (InitWebCoreSystemInterface):
2376         * WebView/WebDynamicScrollBarsView.mm:
2377         (-[WebDynamicScrollBarsView scrollWheel:]):
2378         * WebView/WebHTMLView.mm:
2379         (-[WebHTMLView _removeWindowObservers]):
2380         (-[WebHTMLView addWindowObservers]):
2381         * WebView/WebView.mm:
2382         (-[WebView addWindowObserversForWindow:]):
2383         (-[WebView removeWindowObservers]):
2384         (-[WebView viewWillMoveToWindow:]):
2385
2386 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2387
2388         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2389         https://bugs.webkit.org/show_bug.cgi?id=175779
2390         <rdar://problem/22367975>
2391
2392         Reviewed by Tim Horton.
2393
2394         * WebCoreSupport/WebFrameLoaderClient.h:
2395         * WebCoreSupport/WebFrameLoaderClient.mm:
2396         (WebFrameLoaderClient::webGLPolicyForURL const):
2397         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2398
2399 2017-08-30  Andy Estes  <aestes@apple.com>
2400
2401         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2402         https://bugs.webkit.org/show_bug.cgi?id=176093
2403
2404         Reviewed by Eric Carlson.
2405
2406         * WebCoreSupport/WebSystemInterface.mm:
2407         (InitWebCoreSystemInterface):
2408
2409 2017-08-30  Andy Estes  <aestes@apple.com>
2410
2411         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2412         https://bugs.webkit.org/show_bug.cgi?id=176087
2413
2414         Reviewed by Alex Christensen.
2415
2416         * Carbon/CarbonUtils.m:
2417         (getNSAutoreleasePoolCount):
2418         (WebInitForCarbon):
2419         (PoolCleaner):
2420         * Carbon/CarbonWindowAdapter.mm:
2421         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2422         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2423         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2424         (-[CarbonWindowAdapter _windowMovedToRect:]):
2425         * Carbon/HIViewAdapter.m:
2426         * Carbon/HIWebView.mm:
2427         (Draw):
2428         (CreateNSEventAdoptingCGEvent):
2429         (CopyEventCGEvent):
2430         (CreateNSEventWithCarbonClickEvent):
2431         (Click):
2432         (CreateNSEventWithCarbonEvent):
2433         (MouseUp):
2434         (CreateNSEventWithCarbonMouseMoveEvent):
2435         (MouseMoved):
2436         (MouseDragged):
2437         (MouseWheelMoved):
2438         (WindowHandler):
2439         (HIWebViewEventHandler):
2440         * Misc/QuickDrawCompatibility.h: Removed.
2441         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2442         (getCarbonEvent):
2443         (WebNetscapePluginEventHandlerCarbon::keyDown):
2444         (WebNetscapePluginEventHandlerCarbon::keyUp):
2445         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2446         (WebNetscapePluginEventHandlerCocoa::keyDown):
2447         * Plugins/WebNetscapePluginView.mm:
2448         (-[WebNetscapePluginView tellQuickTimeToChill]):
2449
2450 2017-08-29  Andy Estes  <aestes@apple.com>
2451
2452         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2453         https://bugs.webkit.org/show_bug.cgi?id=176046
2454
2455         Reviewed by Alex Christensen.
2456
2457         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2458         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2459
2460         * Misc/WebNSFileManagerExtras.mm:
2461         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2462         (setMetaData): Deleted.
2463         * WebCoreSupport/WebSystemInterface.mm:
2464         (InitWebCoreSystemInterface):
2465
2466 2017-08-28  Andy Estes  <aestes@apple.com>
2467
2468         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2469         https://bugs.webkit.org/show_bug.cgi?id=176039
2470
2471         Reviewed by Alex Christensen.
2472
2473         * WebCoreSupport/WebSystemInterface.mm:
2474         (InitWebCoreSystemInterface):
2475         * WebView/WebPreferences.mm:
2476         (+[WebPreferences _systemCFStringEncoding]):
2477
2478 2017-08-28  Andy Estes  <aestes@apple.com>
2479
2480         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2481         https://bugs.webkit.org/show_bug.cgi?id=176032
2482
2483         Reviewed by Alex Christensen.
2484
2485         * WebCoreSupport/WebSystemInterface.mm:
2486         (InitWebCoreSystemInterface):
2487         * WebView/WebView.mm:
2488         (-[WebView _cachedResponseForURL:]):
2489
2490 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2491
2492         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2493         https://bugs.webkit.org/show_bug.cgi?id=175992
2494         <rdar://problem/34086613>
2495
2496         Reviewed by Daniel Bates.
2497
2498         * WebCoreSupport/WebPlatformStrategies.h:
2499         * WebCoreSupport/WebPlatformStrategies.mm:
2500         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2501         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2502         indicating if secure cookies were accessed.
2503
2504 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2505
2506         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2507         https://bugs.webkit.org/show_bug.cgi?id=170955
2508         <rdar://problem/31697653>
2509
2510         Reviewed by Ryosuke Niwa.
2511
2512         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2513         text is being replaced.
2514
2515         * WebView/WebHTMLView.mm:
2516         (-[WebHTMLView insertText:]):
2517
2518 2017-08-24  Chris Dumez  <cdumez@apple.com>
2519
2520         [Directory Upload] Add basic support for input.webkitdirectory
2521         https://bugs.webkit.org/show_bug.cgi?id=175950
2522         <rdar://problem/33951915>
2523
2524         Reviewed by Geoffrey Garen.
2525
2526         Add private API to toggle Directory Upload support on Mac WebKit1.
2527
2528         * WebView/WebPreferenceKeysPrivate.h:
2529         * WebView/WebPreferences.mm:
2530         (+[WebPreferences initialize]):
2531         (-[WebPreferences setDirectoryUploadEnabled:]):
2532         (-[WebPreferences directoryUploadEnabled]):
2533         * WebView/WebPreferencesPrivate.h:
2534         * WebView/WebView.mm:
2535         (-[WebView _preferencesChanged:]):
2536
2537 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2538
2539         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2540         https://bugs.webkit.org/show_bug.cgi?id=175370
2541         <rdar://problem/33799806>
2542
2543         Reviewed by Ryosuke Niwa.
2544
2545         Adjust WebEditorClient for interface changes.
2546
2547         * WebCoreSupport/WebEditorClient.h:
2548
2549 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2550
2551         Remove ChromeClient::scrollbarsModeDidChange
2552         https://bugs.webkit.org/show_bug.cgi?id=175805
2553
2554         Reviewed by Daniel Bates.
2555
2556         * WebCoreSupport/WebChromeClient.h:
2557
2558 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2559
2560         Remove ChromeClient::hasOpenedPopup
2561         https://bugs.webkit.org/show_bug.cgi?id=175804
2562
2563         Reviewed by Sam Weinig.
2564
2565         * WebCoreSupport/WebChromeClient.h:
2566         * WebCoreSupport/WebChromeClient.mm:
2567         (WebChromeClient::hasOpenedPopup const): Deleted.
2568
2569 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2570
2571         Disable access to secure cookies if an HTTPS site loads mixed content
2572         https://bugs.webkit.org/show_bug.cgi?id=157053
2573         <rdar://problem/11290808>
2574
2575         Reviewed by Dan Bates.
2576
2577         * WebCoreSupport/WebPlatformStrategies.h:
2578         * WebCoreSupport/WebPlatformStrategies.mm:
2579         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2580         indicating whether secure cookies should be included in the response.
2581
2582 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2583
2584         [PAL] Move spi/mac directory into PAL
2585         https://bugs.webkit.org/show_bug.cgi?id=175649
2586
2587         Reviewed by Myles C. Maxfield.
2588
2589         * Misc/WebSharingServicePickerController.h:
2590         * WebCoreSupport/WebContextMenuClient.mm:
2591         * WebCoreSupport/WebEditorClient.mm:
2592         * WebCoreSupport/WebSelectionServiceController.mm:
2593         * WebView/WebHTMLView.mm:
2594         * WebView/WebImmediateActionController.h:
2595         * WebView/WebImmediateActionController.mm:
2596         * WebView/WebView.mm:
2597
2598 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2599
2600         [PAL] Relocate SessionID to root
2601         https://bugs.webkit.org/show_bug.cgi?id=175684
2602
2603         Reviewed by Alex Christensen.
2604
2605         * WebCoreSupport/WebFrameNetworkingContext.mm:
2606
2607 2017-08-17  Andreas Kling  <akling@apple.com>
2608
2609         Disable CSS regions at compile time
2610         https://bugs.webkit.org/show_bug.cgi?id=175630
2611
2612         Reviewed by Antti Koivisto.
2613
2614         * Configurations/FeatureDefines.xcconfig:
2615
2616 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2617
2618         [PAL] Move SessionID into PAL
2619         https://bugs.webkit.org/show_bug.cgi?id=174192
2620
2621         Reviewed by Antti Koivisto.
2622
2623         * Misc/WebCache.mm:
2624         (+[WebCache imageForURL:]):
2625         * WebCoreSupport/WebFrameLoaderClient.h:
2626         * WebCoreSupport/WebFrameLoaderClient.mm:
2627         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2628         * WebCoreSupport/WebFrameNetworkingContext.mm:
2629         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2630         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2631         (WebFrameNetworkingContext::storageSession const):
2632         * WebCoreSupport/WebPlatformStrategies.h:
2633         * WebCoreSupport/WebPlatformStrategies.mm:
2634         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2635         * WebKitPrefix.h:
2636
2637 2017-08-16  Andy Estes  <aestes@apple.com>
2638
2639         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2640         https://bugs.webkit.org/show_bug.cgi?id=175648
2641
2642         Reviewed by Tim Horton.
2643
2644         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2645         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2646         (WebPaymentCoordinatorClient::showPaymentUI):
2647
2648 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2649
2650         [PAL] Move spi/ios and spi/win directories into PAL
2651         https://bugs.webkit.org/show_bug.cgi?id=175171
2652
2653         Reviewed by Antti Koivisto.
2654
2655         * WebCoreSupport/WebFrameLoaderClient.mm:
2656         * WebView/WebView.mm:
2657
2658 2017-08-16  Andy Estes  <aestes@apple.com>
2659
2660         [Payment Request] Add an ENABLE flag and an experimental feature preference
2661         https://bugs.webkit.org/show_bug.cgi?id=175622
2662
2663         Reviewed by Tim Horton.
2664
2665         * Configurations/FeatureDefines.xcconfig:
2666
2667 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2668
2669         [PAL] Move Sleep classes into PAL
2670         https://bugs.webkit.org/show_bug.cgi?id=175456
2671
2672         Reviewed by Ryosuke Niwa.
2673
2674         * WebView/WebFullScreenController.h:
2675
2676 2017-08-15  Youenn Fablet  <youenn@apple.com>
2677
2678         [Cache API] Adding generic support for CacheStorage and Cache methods
2679         https://bugs.webkit.org/show_bug.cgi?id=175455
2680
2681         Reviewed by Chris Dumez.
2682
2683         * WebView/WebView.mm:
2684         (-[WebView _commonInitializationWithFrameName:groupName:]):
2685
2686 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2687
2688         Remove Proximity Events and related code
2689         https://bugs.webkit.org/show_bug.cgi?id=175545
2690
2691         Reviewed by Daniel Bates.
2692
2693         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2694         and other related code.
2695
2696         * Configurations/FeatureDefines.xcconfig:
2697
2698 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2699
2700         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2701         https://bugs.webkit.org/show_bug.cgi?id=175504
2702
2703         Reviewed by Sam Weinig.
2704
2705         * Configurations/FeatureDefines.xcconfig:
2706         * DOM/DOMHTMLFormElement.mm:
2707         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2708         * WebCoreSupport/WebFrameLoaderClient.h:
2709
2710 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2711
2712         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2713         https://bugs.webkit.org/show_bug.cgi?id=175557
2714
2715         Reviewed by Jon Lee.
2716
2717         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2718
2719         * Configurations/FeatureDefines.xcconfig:
2720
2721 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2722
2723         Composition underline color is always black
2724         https://bugs.webkit.org/show_bug.cgi?id=174675
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         * WebView/WebHTMLView.mm:
2729         (extractUnderlines): If NSUnderlineColorAttributeName
2730         is not present use text color for composition underline.
2731         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2732         for composition underline in the plain text case.
2733
2734 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2735
2736         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2737         https://bugs.webkit.org/show_bug.cgi?id=175474
2738         <rdar://problem/33844628>
2739
2740         Reviewed by Wenson Hsieh.
2741
2742         Replaced the build flag by a runtime flag and disabled the feature by default.
2743
2744         * Configurations/FeatureDefines.xcconfig:
2745         * WebView/WebPreferenceKeysPrivate.h:
2746         * WebView/WebPreferences.mm:
2747         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2748         (-[WebPreferences dataTransferItemsEnabled]): Added.
2749         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2750         * WebView/WebPreferencesPrivate.h:
2751         * WebView/WebView.mm:
2752         (-[WebView _preferencesChanged:]):
2753
2754 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2755
2756         Remove ENABLE_GAMEPAD_DEPRECATED
2757         https://bugs.webkit.org/show_bug.cgi?id=175361
2758
2759         Reviewed by Carlos Garcia Campos.
2760
2761         * Configurations/FeatureDefines.xcconfig:
2762
2763 2017-08-09  Chris Dumez  <cdumez@apple.com>
2764
2765         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2766         https://bugs.webkit.org/show_bug.cgi?id=175401
2767
2768         Reviewed by Brady Eidson.
2769
2770         * WebView/WebPreferenceKeysPrivate.h:
2771         * WebView/WebPreferences.mm:
2772         (+[WebPreferences initialize]):
2773         (-[WebPreferences beaconAPIEnabled]): Deleted.
2774         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2775         * WebView/WebPreferencesPrivate.h:
2776         * WebView/WebView.mm:
2777         (-[WebView _preferencesChanged:]):
2778
2779 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2780
2781         [PAL] Move spi/cocoa and spi/cg directories into PAL
2782         https://bugs.webkit.org/show_bug.cgi?id=175175
2783
2784         Reviewed by Myles C. Maxfield.
2785
2786         * History/WebHistory.mm:
2787         * Misc/WebDownload.mm:
2788         * Misc/WebKitNSStringExtras.mm:
2789         * Plugins/Hosted/NetscapePluginHostManager.mm:
2790         * Plugins/WebPluginDatabase.mm:
2791         * WebCoreSupport/WebFrameLoaderClient.mm:
2792         * WebInspector/WebNodeHighlight.mm:
2793         * WebView/WebHTMLView.mm:
2794         * WebView/WebIndicateLayer.mm:
2795         * WebView/WebView.mm:
2796         * WebView/WebViewData.h:
2797
2798 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2799
2800         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2801         https://bugs.webkit.org/show_bug.cgi?id=175392
2802         <rdar://problem/33783207>
2803
2804         Reviewed by Tim Horton and Megan Gardner.
2805
2806         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2807
2808         * Configurations/FeatureDefines.xcconfig:
2809
2810 2017-08-09  Daniel Bates  <dabates@apple.com>
2811
2812         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2813         https://bugs.webkit.org/show_bug.cgi?id=175247
2814         <rdar://problem/33679804>
2815
2816         Reviewed by Brady Eidson.
2817
2818         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2819         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2820         clients that need to make use of this information at this time. If such a needs comes up
2821         then we can expose API/SPI similar to what we do for WebKit.
2822
2823         * WebCoreSupport/WebFrameLoaderClient.h:
2824         * WebCoreSupport/WebFrameLoaderClient.mm:
2825         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2826
2827 2017-08-08  Brady Eidson  <beidson@apple.com>
2828
2829         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2830         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2831
2832         Reviewed by Andy Estes.
2833
2834         * Misc/WebKitVersionChecks.h:
2835         * WebCoreSupport/WebFrameLoaderClient.mm:
2836         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2837           the app is linked against new WebKit with the new behavior.
2838
2839 2017-08-07  Devin Rousso  <drousso@apple.com>
2840
2841         Web Inspector: Preview Canvas path when viewing a recording
2842         https://bugs.webkit.org/show_bug.cgi?id=174967
2843
2844         Reviewed by Brian Burg.
2845
2846         * WebView/WebPreferenceKeysPrivate.h:
2847         * WebView/WebPreferences.mm:
2848         (+[WebPreferences initialize]):
2849         (-[WebPreferences inspectorAdditionsEnabled]):
2850         (-[WebPreferences setInspectorAdditionsEnabled:]):
2851         * WebView/WebPreferencesPrivate.h:
2852         * WebView/WebView.mm:
2853         (-[WebView _preferencesChanged:]):
2854         Add plumbing for new InspectorAdditions runtime flag.
2855
2856 2017-08-07  Brian Burg  <bburg@apple.com>
2857
2858         Remove CANVAS_PATH compilation guard
2859         https://bugs.webkit.org/show_bug.cgi?id=175207
2860
2861         Reviewed by Sam Weinig.
2862
2863         * Configurations/FeatureDefines.xcconfig:
2864
2865 2017-08-04  Youenn Fablet  <youenn@apple.com>
2866
2867         [Cache API] Add Cache and CacheStorage IDL definitions
2868         https://bugs.webkit.org/show_bug.cgi?id=175201
2869
2870         Reviewed by Brady Eidson.
2871
2872         * WebView/WebPreferenceKeysPrivate.h:
2873         * WebView/WebPreferences.mm:
2874         (+[WebPreferences initialize]):
2875         (-[WebPreferences cacheAPIEnabled]):
2876         (-[WebPreferences setCacheAPIEnabled:]):
2877         * WebView/WebPreferencesPrivate.h:
2878         * WebView/WebView.mm:
2879         (-[WebView _preferencesChanged:]):
2880
2881 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2882
2883         Unreviewed, rolling out r220271.
2884
2885         Rolling out due to Layout Test failing on iOS Simulator.
2886
2887         Reverted changeset:
2888
2889         "Remove STREAMS_API compilation guard"
2890         https://bugs.webkit.org/show_bug.cgi?id=175165
2891         http://trac.webkit.org/changeset/220271
2892
2893 2017-08-04  Youenn Fablet  <youenn@apple.com>
2894
2895         Remove STREAMS_API compilation guard
2896         https://bugs.webkit.org/show_bug.cgi?id=175165
2897
2898         Reviewed by Darin Adler.
2899
2900         * Configurations/FeatureDefines.xcconfig:
2901         * WebView/WebPreferences.mm:
2902         (+[WebPreferences initialize]):
2903         * WebView/WebView.mm:
2904         (-[WebView _preferencesChanged:]):
2905
2906 2017-08-03  Brian Burg  <bburg@apple.com>
2907
2908         Remove ENABLE(WEB_SOCKET) guards
2909         https://bugs.webkit.org/show_bug.cgi?id=167044
2910
2911         Reviewed by Joseph Pecoraro.
2912
2913         * Configurations/FeatureDefines.xcconfig:
2914         * WebView/WebPreferencesPrivate.h:
2915
2916 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2917
2918         [PAL] Move spi/cf directory into PAL
2919         https://bugs.webkit.org/show_bug.cgi?id=175057
2920
2921         Reviewed by Antti Koivisto.
2922
2923         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2924         * Plugins/WebNetscapePluginStream.mm:
2925         * WebCoreSupport/WebFrameNetworkingContext.mm:
2926         * WebView/WebPreferences.mm:
2927         * WebView/WebView.mm:
2928
2929 2017-08-03  Youenn Fablet  <youenn@apple.com>
2930
2931         Remove FETCH_API compilation guard
2932         https://bugs.webkit.org/show_bug.cgi?id=175154
2933
2934         Reviewed by Chris Dumez.
2935
2936         * Configurations/FeatureDefines.xcconfig:
2937         * WebView/WebPreferences.mm:
2938         (+[WebPreferences initialize]):
2939         * WebView/WebView.mm:
2940         (-[WebView _preferencesChanged:]):
2941
2942 2017-08-03  Brady Eidson  <beidson@apple.com>
2943
2944         Add SW IDLs and stub out basic functionality.
2945         https://bugs.webkit.org/show_bug.cgi?id=175115
2946
2947         Reviewed by Chris Dumez.
2948
2949         * Configurations/FeatureDefines.xcconfig:
2950
2951 2017-08-02  Sam Weinig  <sam@webkit.org>
2952
2953         [WebIDL] Convert MutationCallback to be a normal generated callback
2954         https://bugs.webkit.org/show_bug.cgi?id=174140
2955
2956         Reviewed by Darin Adler.
2957
2958         * DOM/DOMDocument.mm:
2959         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2960         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2961         Pass, now necessary, Document to NativeNodeFilter constructor.
2962
2963 2017-08-01  Chris Dumez  <cdumez@apple.com>
2964
2965         Add initial support for navigator.sendBeacon
2966         https://bugs.webkit.org/show_bug.cgi?id=175007
2967         <rdar://problem/33547728>
2968
2969         Reviewed by Sam Weinig.
2970
2971         Add setting to toggle support for the Beacon API (it is disabled by default).
2972
2973         * WebView/WebPreferenceKeysPrivate.h:
2974         * WebView/WebPreferences.mm:
2975         (+[WebPreferences initialize]):
2976         (-[WebPreferences beaconAPIEnabled]):
2977         (-[WebPreferences setBeaconAPIEnabled:]):
2978         * WebView/WebPreferencesPrivate.h:
2979         * WebView/WebView.mm:
2980         (-[WebView _preferencesChanged:]):
2981
2982 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2983
2984         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2985         https://bugs.webkit.org/show_bug.cgi?id=174437
2986
2987         Reviewed by Darin Adler.
2988
2989         Remove redundant Web- prefix from classes in WebKit namespace.
2990
2991         * WebView/WebView.mm:
2992         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2993         * WebView/WebViewData.h:
2994         * WebView/WebViewData.mm:
2995
2996 2017-07-26  Brian Burg  <bburg@apple.com>
2997
2998         Remove WEB_TIMING feature flag
2999         https://bugs.webkit.org/show_bug.cgi?id=174795
3000
3001         Reviewed by Alex Christensen.
3002
3003         * Configurations/FeatureDefines.xcconfig:
3004
3005 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3006
3007         Async image decoding for large images should be disabled after the first time a tile is painted
3008         https://bugs.webkit.org/show_bug.cgi?id=174451
3009         <rdar://problem/31246421>
3010
3011         Reviewed by Simon Fraser.
3012
3013         * WebView/WebFrame.mm:
3014         (-[WebFrame _paintBehaviorForDestinationContext:]):
3015         (-[WebFrame _drawRect:contentsOnly:]):
3016         * WebView/WebHTMLView.mm:
3017         (imageFromRect):
3018
3019 2017-07-23  Darin Adler  <darin@apple.com>
3020
3021         More NeverDestroyed and related cleanup
3022         https://bugs.webkit.org/show_bug.cgi?id=174745
3023
3024         Reviewed by Alex Christensen.
3025
3026         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3027         for names that aren't even used in this file.
3028         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3029         -[NSArray arrayWithObject:].
3030         (-[DOMNode absoluteQuads]): Ditto.
3031         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3032         of writing out various types.
3033         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3034         syntax instea of -[NSArray arrayWithObject:].
3035         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3036         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3037         of writing out various types.
3038         (-[DOMHTMLImageElement mimeType]): Ditto.
3039
3040 2017-07-24  Chris Dumez  <cdumez@apple.com>
3041
3042         ExceptionCode enumeration should use modern exception names
3043         https://bugs.webkit.org/show_bug.cgi?id=174794
3044
3045         Reviewed by Geoffrey Garen.
3046
3047         * DOM/ExceptionHandlers.mm:
3048         (raiseNotSupportedErrorException):
3049
3050 2017-07-23  Chris Dumez  <cdumez@apple.com>
3051
3052         Drop ExceptionCodeDescription class
3053         https://bugs.webkit.org/show_bug.cgi?id=174757
3054
3055         Reviewed by Darin Adler.
3056
3057         Stop using ExceptionCodeDescription.
3058
3059         * DOM/ExceptionHandlers.mm:
3060         (raiseDOMErrorException):
3061
3062 2017-07-21  Andreas Kling  <akling@apple.com>
3063
3064         Use more references in event dispatch code
3065         https://bugs.webkit.org/show_bug.cgi?id=174681
3066
3067         Reviewed by Geoffrey Garen.
3068
3069         * DOM/ObjCEventListener.h:
3070         * DOM/ObjCEventListener.mm:
3071         (WebCore::ObjCEventListener::handleEvent):
3072         * WebCoreSupport/WebFrameLoaderClient.mm:
3073         (NetscapePluginWidget::handleEvent):
3074
3075 2017-07-21  Brady Eidson  <beidson@apple.com>
3076
3077         Get rid of WebCore IconDatabase code.
3078         https://bugs.webkit.org/show_bug.cgi?id=174700
3079
3080         Reviewed by Tim Horton.
3081
3082         * Misc/WebCoreStatistics.mm:
3083         (+[WebCoreStatistics iconPageURLMappingCount]):
3084         (+[WebCoreStatistics iconRetainedPageURLCount]):
3085         (+[WebCoreStatistics iconRecordCount]):
3086         (+[WebCoreStatistics iconsWithDataCount]):
3087         * WebCoreSupport/WebFrameLoaderClient.h:
3088         * WebCoreSupport/WebFrameLoaderClient.mm:
3089         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3090         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3091         * WebView/WebView.mm:
3092         (-[WebView mainFrameIconURL]):
3093
3094 2017-07-20  Chris Dumez  <cdumez@apple.com>
3095
3096         Drop legacy XPathException type
3097         https://bugs.webkit.org/show_bug.cgi?id=174679
3098
3099         Reviewed by Sam Weinig.
3100
3101         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3102         no longer expose XPathException.
3103
3104         * DOM/ExceptionHandlers.mm:
3105         (raiseDOMErrorException):
3106
3107 2017-07-20  Chris Dumez  <cdumez@apple.com>
3108
3109         Unreviewed, rolling out r219706.
3110
3111         Broke iOS build
3112
3113         Reverted changeset:
3114
3115         "Drop legacy XPathException type"
3116         https://bugs.webkit.org/show_bug.cgi?id=174679
3117         http://trac.webkit.org/changeset/219706
3118
3119 2017-07-20  Chris Dumez  <cdumez@apple.com>
3120
3121         Drop legacy XPathException type
3122         https://bugs.webkit.org/show_bug.cgi?id=174679
3123
3124         Reviewed by Sam Weinig.
3125
3126         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3127         no longer expose XPathException.
3128
3129         * DOM/ExceptionHandlers.mm:
3130         (raiseDOMErrorException):
3131         * WebKit.exp:
3132
3133 2017-07-20  Chris Dumez  <cdumez@apple.com>
3134
3135         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3136         https://bugs.webkit.org/show_bug.cgi?id=174660
3137
3138         Reviewed by Geoffrey Garen.
3139
3140         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3141         This essentially replaces a branch to figure out if the new size is less or greater than the
3142         current size by an assertion.
3143
3144         * Plugins/WebNetscapePluginView.mm:
3145         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3146
3147 2017-07-20  Brady Eidson  <beidson@apple.com>
3148
3149         Deprecate WebIconDatabase in WebKitLegacy/mac.
3150         https://bugs.webkit.org/show_bug.cgi?id=174607
3151
3152         Reviewed by Alex Christensen.
3153
3154         This patch:
3155         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3156         2 - Guts the class to where it can only return the default icon at the small size
3157         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3158             use something else or to not do anything.
3159         
3160         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3161         and that patch will remove all of the last remnants of WebIconDatabase.
3162         
3163         * History/WebHistoryItem.mm:
3164         (-[WebHistoryItem icon]):
3165
3166         * Misc/WebIconDatabase.h:
3167         * Misc/WebIconDatabase.mm:
3168         (-[WebIconDatabase init]):
3169         (-[WebIconDatabase iconForURL:withSize:cache:]):
3170         (-[WebIconDatabase iconForURL:withSize:]):
3171         (-[WebIconDatabase defaultIconWithSize:]):
3172         (-[WebIconDatabase defaultIconForURL:withSize:]):
3173         (-[WebIconDatabase iconURLForURL:]):
3174         (-[WebIconDatabase retainIconForURL:]):
3175         (-[WebIconDatabase releaseIconForURL:]):
3176         (+[WebIconDatabase delayDatabaseCleanup]):
3177         (+[WebIconDatabase allowDatabaseCleanup]):
3178         (-[WebIconDatabase setDelegate:]):
3179         (-[WebIconDatabase delegate]):
3180         (+[WebIconDatabase initialize]): Deleted.
3181         (-[WebIconDatabase isEnabled]): Deleted.
3182         (-[WebIconDatabase setEnabled:]): Deleted.
3183         (-[WebIconDatabase removeAllIcons]): Deleted.
3184         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3185         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3186         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3187         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3188         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3189         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3190         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3191         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3192         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3193         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3194         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3195         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3196         (-[WebIconDatabase _databaseDirectory]): Deleted.
3197         (webGetNSImage): Deleted.
3198
3199         * Misc/WebIconDatabaseDelegate.h: Removed.
3200         * Misc/WebIconDatabaseInternal.h: Removed.
3201         * Misc/WebIconDatabasePrivate.h: Removed.
3202
3203         * WebCoreSupport/WebFrameLoaderClient.mm:
3204         (webGetNSImage):
3205
3206         * WebCoreSupport/WebIconDatabaseClient.mm:
3207         (WebIconDatabaseClient::didRemoveAllIcons):
3208         (WebIconDatabaseClient::didImportIconURLForPageURL):
3209
3210         * WebView/WebView.mm:
3211         (-[WebView setFrameLoadDelegate:]):
3212         (-[WebView mainFrameIcon]):
3213
3214 2017-07-18  Andy Estes  <aestes@apple.com>
3215
3216         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3217         https://bugs.webkit.org/show_bug.cgi?id=174631
3218
3219         Reviewed by Tim Horton.
3220
3221         * Configurations/Base.xcconfig:
3222
3223 2017-07-18  Andy Estes  <aestes@apple.com>
3224
3225         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3226         https://bugs.webkit.org/show_bug.cgi?id=174631
3227
3228         Reviewed by Sam Weinig.
3229
3230         * Configurations/Base.xcconfig:
3231
3232 2017-07-18  Andy Estes  <aestes@apple.com>
3233
3234         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3235         https://bugs.webkit.org/show_bug.cgi?id=174631
3236
3237         Reviewed by Dan Bernstein.
3238
3239         * Configurations/Base.xcconfig:
3240
3241 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3242
3243         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3244         https://bugs.webkit.org/show_bug.cgi?id=174640
3245         <rdar://problem/33297400>
3246
3247         Reviewed by Tim Horton.
3248
3249         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3250         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3251         web thread here, to match the other WebView drag and drop SPI methods.
3252
3253         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3254         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3255         should make this robust against future UIKit changes that could make this no longer the case.
3256
3257         * WebView/WebView.mm:
3258         (-[WebView _requestStartDataInteraction:globalPosition:]):
3259         (-[WebView _dataInteractionCaretRect]):
3260
3261 2017-07-18  Andy Estes  <aestes@apple.com>
3262
3263         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3264         https://bugs.webkit.org/show_bug.cgi?id=174631
3265
3266         Reviewed by Darin Adler.
3267
3268         * Configurations/Base.xcconfig:
3269
3270 2017-07-17  Sam Weinig  <sam@webkit.org>
3271
3272         [WebIDL] Remove custom bindings that require non-caching JS strings
3273         https://bugs.webkit.org/show_bug.cgi?id=174552
3274
3275         Reviewed by Darin Adler.
3276
3277         * DOM/DOMHTMLCanvasElement.mm:
3278         (-[DOMHTMLCanvasElement toDataURL:]):
3279         Update to account for implementation now returning an UncachedString.
3280
3281 2017-07-17  Darin Adler  <darin@apple.com>
3282
3283         Improve use of NeverDestroyed
3284         https://bugs.webkit.org/show_bug.cgi?id=174348
3285
3286         Reviewed by Sam Weinig.
3287
3288         * Misc/WebStringTruncator.mm:
3289         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3290         NeverDestroyed<RetainPtr> with just an NSFont * global.
3291
3292         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3293         NeverDestroyed.h.
3294         * Storage/WebDatabaseManager.mm: Ditto.
3295         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3296         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3297
3298         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3299         (aeDescFromJSValue): Removed double hashing by using the return value from
3300         add rather than calling contains before calling add.
3301
3302 2017-07-14  Jer Noble  <jer.noble@apple.com>
3303
3304         Allow clients to override their own hardware media requirements where no fallback media exists.
3305         https://bugs.webkit.org/show_bug.cgi?id=174426
3306         <rdar://problem/32537704>
3307
3308         Reviewed by Eric Carlson.
3309
3310         Add a new WebPreferences property to control WebCore's new
3311         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3312
3313         * WebView/WebPreferenceKeysPrivate.h:
3314         * WebView/WebPreferences.mm:
3315         (+[WebPreferences initialize]):
3316         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3317         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3318         * WebView/WebPreferencesPrivate.h:
3319         * WebView/WebView.mm:
3320         (-[WebView _preferencesChanged:]):
3321
3322 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3323
3324         Async image decoding for large images should be disabled by default
3325         https://bugs.webkit.org/show_bug.cgi?id=174432
3326
3327         Reviewed by Simon Fraser.
3328
3329         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3330         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3331         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3332            a child view instead of propagating PaintBehaviorSnapshotting.
3333         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3334            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3335
3336         * WebView/WebFrame.mm:
3337         (-[WebFrame _paintBehaviorForDestinationContext:]):
3338         (-[WebFrame _drawRect:contentsOnly:]):
3339         * WebView/WebHTMLView.mm:
3340         (imageFromRect):
3341
3342 2017-07-12  Daniel Bates  <dabates@apple.com>
3343
3344         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3345         https://bugs.webkit.org/show_bug.cgi?id=174427
3346
3347         Rubber-stamped by Brady Eidson.
3348
3349         * WebView/WebPDFView.mm:
3350         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3351
3352 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3353
3354         Unreviewed, rolling out r219401.
3355
3356         This revision rolled out the previous patch, but after talking
3357         with reviewer, a rebaseline is what was needed.Rolling back in
3358         before rebaseline.
3359
3360         Reverted changeset:
3361
3362         "Unreviewed, rolling out r219379."
3363         https://bugs.webkit.org/show_bug.cgi?id=174400
3364         http://trac.webkit.org/changeset/219401
3365
3366 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3367
3368         Unreviewed, rolling out r219379.
3369
3370         This revision caused a consistent failure in the test
3371         fast/dom/Window/property-access-on-cached-window-after-frame-
3372         removed.html.
3373
3374         Reverted changeset:
3375
3376         "Remove NAVIGATOR_HWCONCURRENCY"
3377         https://bugs.webkit.org/show_bug.cgi?id=174400
3378         http://trac.webkit.org/changeset/219379
3379
3380 2017-07-11  Dean Jackson  <dino@apple.com>
3381
3382         Remove NAVIGATOR_HWCONCURRENCY
3383         https://bugs.webkit.org/show_bug.cgi?id=174400
3384
3385         * Configurations/FeatureDefines.xcconfig:
3386
3387 2017-07-11  Dean Jackson  <dino@apple.com>
3388
3389         Rolling out r219372.
3390
3391         * Configurations/FeatureDefines.xcconfig:
3392
3393 2017-07-11  Dean Jackson  <dino@apple.com>
3394
3395         Remove NAVIGATOR_HWCONCURRENCY
3396         https://bugs.webkit.org/show_bug.cgi?id=174400
3397
3398         * Configurations/FeatureDefines.xcconfig:
3399
3400 2017-07-03  Brian Burg  <bburg@apple.com>
3401
3402         Web Replay: remove some unused code
3403         https://bugs.webkit.org/show_bug.cgi?id=173903
3404
3405         Rubber-stamped by Joseph Pecoraro.
3406
3407         * Configurations/FeatureDefines.xcconfig:
3408
3409 2017-07-09  Brady Eidson  <beidson@apple.com>
3410
3411         Remove some obsolete WebKitVersionChecks.
3412         https://bugs.webkit.org/show_bug.cgi?id=174294
3413
3414         Reviewed by Dan Bernstein.
3415
3416         * Misc/WebKitVersionChecks.h:
3417
3418         * WebView/WebHTMLView.mm:
3419         (-[WebHTMLView hitTest:]):
3420
3421         * WebView/WebView.mm:
3422         (shouldRespectPriorityInCSSAttributeSetters):
3423         (-[WebView _commonInitializationWithFrameName:groupName:]):
3424         (-[WebView _preferencesChanged:]):
3425         (shouldTransformsAffectOverflow): Deleted.
3426         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3427
3428 2017-07-08  Brady Eidson  <beidson@apple.com>
3429
3430         Remove some obsolete RuntimeApplicationChecks.
3431         https://bugs.webkit.org/show_bug.cgi?id=174293
3432
3433         Reviewed by Dan Bernstein.
3434
3435         * Misc/WebKitVersionChecks.h:
3436         * WebView/WebView.mm:
3437         (+[WebView enableWebThread]):
3438         (-[WebView _needsPreHTML5ParserQuirks]):
3439
3440 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3441
3442         Drop NOSNIFF compile flag
3443         https://bugs.webkit.org/show_bug.cgi?id=174289
3444
3445         Reviewed by Michael Catanzaro.
3446
3447         * Configurations/FeatureDefines.xcconfig:
3448
3449 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3450
3451         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3452         https://bugs.webkit.org/show_bug.cgi?id=174150
3453
3454         Reviewed by Mark Lam.
3455
3456         * DOM/DOM.mm:
3457         (lookupElementClass):
3458
3459 2017-07-06  Brady Eidson  <beidson@apple.com>
3460
3461         Add logging to first attempt to use the WebIconDatabase class.
3462         https://bugs.webkit.org/show_bug.cgi?id=174190
3463
3464         Reviewed by Andy Estes.
3465
3466         * Misc/WebIconDatabase.mm:
3467         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3468         * Misc/WebKitVersionChecks.h:
3469
3470 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3471
3472         Unreviewed, rolling out r219178.
3473
3474         This caused a consistent failure with the API test
3475         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3476
3477         Reverted changeset:
3478
3479         "[WTF] Clean up StringStatics.cpp by using
3480         LazyNeverDestroyed<> for Atoms"
3481         https://bugs.webkit.org/show_bug.cgi?id=174150
3482         http://trac.webkit.org/changeset/219178
3483
3484 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3485
3486         [WTF] Move SoftLinking.h into WTF
3487         https://bugs.webkit.org/show_bug.cgi?id=174000
3488
3489         Reviewed by Alex Christensen.
3490
3491         * Plugins/WebNetscapePluginView.mm:
3492         * Plugins/WebPluginController.mm:
3493         * WebCoreSupport/WebInspectorClient.mm:
3494         * WebView/WebFullScreenController.mm:
3495         * WebView/WebImmediateActionController.mm:
3496         * WebView/WebView.mm:
3497
3498 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3499
3500         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3501         https://bugs.webkit.org/show_bug.cgi?id=174150
3502
3503         Reviewed by Mark Lam.
3504
3505         * DOM/DOM.mm:
3506         (lookupElementClass):
3507
3508 2017-07-05  Brady Eidson  <beidson@apple.com>
3509
3510         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3511         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3512
3513         Reviewed by Alex Christensen.
3514
3515         Adopt to the new constructor for FrameLoadRequest.
3516
3517         * WebView/WebPDFView.mm:
3518         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3519
3520 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3521
3522         Make WebKit's public headers on Mac and iOS C++ module safe
3523         https://bugs.webkit.org/show_bug.cgi?id=174175
3524
3525         Reviewed by Alex Christensen.
3526
3527         Fixed the header files.
3528
3529         * Misc/WebDownload.h:
3530         * Misc/WebKitErrors.h:
3531         * Plugins/WebPluginContainer.h:
3532         * WebView/WebResourceLoadDelegate.h:
3533
3534 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3535
3536         Remove copy of ICU headers from WebKit
3537         https://bugs.webkit.org/show_bug.cgi?id=116407
3538
3539         Reviewed by Alex Christensen.
3540
3541         Use WTF's copy of ICU headers.
3542
3543         * Configurations/WebKitLegacy.xcconfig:
3544         * icu/unicode/localpointer.h: Removed.
3545         * icu/unicode/parseerr.h: Removed.
3546         * icu/unicode/platform.h: Removed.
3547         * icu/unicode/ptypes.h: Removed.
3548         * icu/unicode/putil.h: Removed.
3549         * icu/unicode/uchar.h: Removed.
3550         * icu/unicode/uconfig.h: Removed.
3551         * icu/unicode/ucurr.h: Removed.
3552         * icu/unicode/uidna.h: Removed.
3553         * icu/unicode/uiter.h: Removed.
3554         * icu/unicode/umachine.h: Removed.
3555         * icu/unicode/unorm.h: Removed.
3556         * icu/unicode/unorm2.h: Removed.
3557         * icu/unicode/urename.h: Removed.
3558         * icu/unicode/uscript.h: Removed.
3559         * icu/unicode/ustring.h: Removed.
3560         * icu/unicode/utf.h: Removed.
3561         * icu/unicode/utf16.h: Removed.
3562         * icu/unicode/utf8.h: Removed.
3563         * icu/unicode/utf_old.h: Removed.
3564         * icu/unicode/utypes.h: Removed.
3565         * icu/unicode/uvernum.h: Removed.
3566         * icu/unicode/uversion.h: Removed.
3567
3568 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3569
3570         Add WebKitPrivateFrameworkStubs for iOS 11
3571         https://bugs.webkit.org/show_bug.cgi?id=173988
3572
3573         Reviewed by David Kilzer.
3574
3575         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3576         use the same directory for private framework stubs.
3577
3578 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3579
3580         Unreviewed, rolling out r219103.
3581
3582         Caused multiple build failures.
3583
3584         Reverted changeset:
3585
3586         "Remove copy of ICU headers from WebKit"
3587         https://bugs.webkit.org/show_bug.cgi?id=116407
3588         http://trac.webkit.org/changeset/219103
3589
3590 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3591
3592         Remove copy of ICU headers from WebKit
3593         https://bugs.webkit.org/show_bug.cgi?id=116407
3594
3595         Reviewed by Alex Christensen.
3596
3597         Use WTF's copy of ICU headers.
3598
3599         * Configurations/WebKitLegacy.xcconfig:
3600         * icu/unicode/localpointer.h: Removed.
3601         * icu/unicode/parseerr.h: Removed.
3602         * icu/unicode/platform.h: Removed.
3603         * icu/unicode/ptypes.h: Removed.
3604         * icu/unicode/putil.h: Removed.
3605         * icu/unicode/uchar.h: Removed.
3606         * icu/unicode/uconfig.h: Removed.
3607         * icu/unicode/ucurr.h: Removed.
3608         * icu/unicode/uidna.h: Removed.
3609         * icu/unicode/uiter.h: Removed.
3610         * icu/unicode/umachine.h: Removed.
3611         * icu/unicode/unorm.h: Removed.
3612         * icu/unicode/unorm2.h: Removed.
3613         * icu/unicode/urename.h: Removed.
3614         * icu/unicode/uscript.h: Removed.
3615         * icu/unicode/ustring.h: Removed.
3616         * icu/unicode/utf.h: Removed.
3617         * icu/unicode/utf16.h: Removed.
3618         * icu/unicode/utf8.h: Removed.
3619         * icu/unicode/utf_old.h: Removed.
3620         * icu/unicode/utypes.h: Removed.
3621         * icu/unicode/uvernum.h: Removed.
3622         * icu/unicode/uversion.h: Removed.
3623
3624 2017-07-03  Brady Eidson  <beidson@apple.com>
3625
3626         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3627         https://bugs.webkit.org/show_bug.cgi?id=174073
3628
3629         Reviewed by Andy Estes.
3630
3631         WebView now keeps a direct copy of its main frame icon as a member variable.
3632         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3633         
3634         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3635         have both the old icon and new icon at the time it changes.
3636
3637         * WebCoreSupport/WebFrameLoaderClient.h:
3638         * WebCoreSupport/WebFrameLoaderClient.mm:
3639         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3640         (WebFrameLoaderClient::getLoadDecisionForIcons):
3641         (WebFrameLoaderClient::finishedLoadingIcon):
3642         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3643         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3644
3645         * WebView/WebView.mm:
3646         (+[WebView _setIconLoadingEnabled:]):
3647         (+[WebView _isIconLoadingEnabled]):
3648         (-[WebView mainFrameIcon]):
3649         (-[WebView _setMainFrameIcon:]):
3650         (-[WebView _receivedIconChangedNotification:]): Deleted.
3651         (-[WebView _registerForIconNotification:]): Deleted.
3652         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3653         * WebView/WebViewData.h:
3654         * WebView/WebViewInternal.h:
3655         * WebView/WebViewPrivate.h:
3656
3657 2017-07-03  Sam Weinig  <sam@webkit.org>
3658
3659         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3660         https://bugs.webkit.org/show_bug.cgi?id=174083
3661
3662         Reviewed by Alex Christensen.
3663
3664         * Configurations/FeatureDefines.xcconfig:
3665         Add ENABLE_NAVIGATOR_STANDALONE.
3666
3667 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3668
3669         Expose unobscuredSafeAreaInsets on WebView
3670         https://bugs.webkit.org/show_bug.cgi?id=174075
3671         <rdar://problem/33096997>
3672
3673         Reviewed by Beth Dakin.
3674
3675         * WebView/WebView.mm:
3676         (-[WebView _setUnobscuredSafeAreaInsets:]):
3677         (-[WebView _unobscuredSafeAreaInsets]):
3678         * WebView/WebViewPrivate.h:
3679         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3680         similar to how it is exposed in WebKit2.
3681
3682 2017-07-03  Andy Estes  <aestes@apple.com>
3683
3684         [Xcode] Add an experimental setting to build with ccache
3685         https://bugs.webkit.org/show_bug.cgi?id=173875
3686
3687         Reviewed by Tim Horton.
3688
3689         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3690
3691 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3692
3693         Expose WebPreferences for viewport-fit and constant() properties
3694         https://bugs.webkit.org/show_bug.cgi?id=174072
3695         <rdar://problem/33096639>
3696
3697         Reviewed by Ryosuke Niwa.
3698
3699         * WebView/WebPreferenceKeysPrivate.h:
3700         * WebView/WebPreferences.mm:
3701         (-[WebPreferences viewportFitEnabled]):
3702         (-[WebPreferences setViewportFitEnabled:]):
3703         (-[WebPreferences constantPropertiesEnabled]):
3704         (-[WebPreferences setConstantPropertiesEnabled:]):
3705         * WebView/WebPreferencesPrivate.h:
3706         * WebView/WebView.mm:
3707         (-[WebView _preferencesChanged:]):
3708
3709 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3710
3711         Expose viewport-fit value to UIKit via viewport arguments dictionary
3712         https://bugs.webkit.org/show_bug.cgi?id=174071
3713         <rdar://problem/33096620>
3714
3715         Reviewed by Wenson Hsieh.
3716
3717         * History/WebHistoryItem.mm:
3718         * History/WebHistoryItemPrivate.h:
3719         Add another dictionary key and three values.
3720
3721 2017-07-01  Dan Bernstein  <mitz@apple.com>
3722
3723         [iOS] Remove code only needed when building for iOS 9.x
3724         https://bugs.webkit.org/show_bug.cgi?id=174068
3725
3726         Reviewed by Tim Horton.
3727
3728         * Configurations/FeatureDefines.xcconfig:
3729
3730 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3731
3732         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3733         https://bugs.webkit.org/show_bug.cgi?id=174004
3734
3735         Reviewed by Simon Fraser.
3736
3737         * WebCoreSupport/WebPluginInfoProvider.mm:
3738
3739 2017-07-01  Dan Bernstein  <mitz@apple.com>
3740
3741         [macOS] Remove code only needed when building for OS X Yosemite
3742         https://bugs.webkit.org/show_bug.cgi?id=174067
3743
3744         Reviewed by Tim Horton.
3745
3746         * Configurations/Base.xcconfig:
3747         * Configurations/DebugRelease.xcconfig:
3748         * Configurations/FeatureDefines.xcconfig:
3749         * Configurations/Version.xcconfig:
3750         * Plugins/WebBasePluginPackage.mm:
3751         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3752         * WebCoreSupport/PopupMenuMac.mm:
3753         (PopupMenuMac::show):
3754         * WebCoreSupport/WebInspectorClient.mm:
3755         (WebInspectorFrontendClient::startWindowDrag):
3756         (-[WebInspectorWindowController window]):
3757         * WebView/WebView.mm:
3758         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3759
3760 2017-06-30  Daniel Bates  <dabates@apple.com>
3761
3762         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3763         https://bugs.webkit.org/show_bug.cgi?id=165160
3764         <rdar://problem/29451999>
3765
3766         Reviewed by Brady Eidson.
3767
3768         Pass the document that is requesting the load to the loader.
3769
3770         * WebView/WebPDFView.mm:
3771         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3772
3773 2017-06-29  Jer Noble  <jer.noble@apple.com>
3774
3775         Make Legacy EME API controlled by RuntimeEnabled setting.
3776         https://bugs.webkit.org/show_bug.cgi?id=173994
3777
3778         Reviewed by Sam Weinig.
3779
3780         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3781
3782         * Configurations/FeatureDefines.xcconfig:
3783         * WebView/WebPreferenceKeysPrivate.h:
3784         * WebView/WebPreferences.mm:
3785         (+[WebPreferences initialize]):
3786         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3787         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3788         * WebView/WebPreferencesPrivate.h:
3789         * WebView/WebView.mm:
3790         (-[WebView _preferencesChanged:]):
3791
3792 2017-06-30  Chris Dumez  <cdumez@apple.com>
3793
3794         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3795         https://bugs.webkit.org/show_bug.cgi?id=174013
3796
3797         Reviewed by Brent Fulgham.
3798
3799         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3800         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3801
3802         * WebView/WebView.mm:
3803         (-[WebView _commonInitializationWithFrameName:groupName:]):
3804
3805 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3806
3807         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3808         https://bugs.webkit.org/show_bug.cgi?id=174017
3809         <rdar://problem/32959782>
3810
3811         Reviewed by Simon Fraser.
3812
3813         Use root view coordinates when computing the drag caret rect.
3814
3815         * WebView/WebView.mm:
3816         (-[WebView _dataInteractionCaretRect]):
3817
3818 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3819
3820         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3821         https://bugs.webkit.org/show_bug.cgi?id=173899
3822         rdar://problem/32994474
3823
3824         Reviewed by Tim Horton.
3825
3826         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3827         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3828         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3829
3830         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3831         documentView is a WebHTMLView.
3832
3833         * WebView/WebFrame.mm:
3834         (-[WebFrame _webHTMLDocumentView]):
3835         (-[WebFrame _paintBehaviorForDestinationContext:]):
3836         (-[WebFrame _drawRect:contentsOnly:]):
3837         (-[WebFrame setTimeoutsPaused:]):
3838         (-[WebFrame prepareForPause]):
3839         (-[WebFrame resumeFromPause]):
3840         (-[WebFrame resetTextAutosizingBeforeLayout]):
3841         * WebView/WebHTMLView.mm:
3842         (-[WebHTMLView drawLayer:inContext:]):
3843         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3844         * WebView/WebHTMLViewInternal.h:
3845
3846 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3847
3848         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3849         https://bugs.webkit.org/show_bug.cgi?id=173854
3850         <rdar://problem/32236827>
3851
3852         Reviewed by Ryosuke Niwa and Tim Horton.
3853
3854         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3855         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3856
3857         * WebView/WebView.mm:
3858         (-[WebView _startDrag:]):
3859         (-[WebView _dragSourceAction]):
3860         (-[WebView _draggedLinkTitle]):
3861         (-[WebView _draggedLinkURL]):
3862         (-[WebView _draggedElementBounds]):
3863         (-[WebView _endedDataInteraction:global:]):
3864         * WebView/WebViewData.h:
3865         * WebView/WebViewPrivate.h:
3866
3867 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3868
3869         Refactor drag start codepaths to plumb a DragItem to client layers
3870         https://bugs.webkit.org/show_bug.cgi?id=173832
3871         Work towards <rdar://problem/32236827>
3872
3873         Reviewed by Ryosuke Niwa and Tim Horton.
3874
3875         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3876         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3877         to _startDrag: to match logic used to start a drag on other platforms.
3878
3879         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3880         through the DragItem struct.
3881
3882         * WebCoreSupport/WebDragClient.h:
3883         * WebCoreSupport/WebDragClient.mm:
3884         (WebDragClient::startDrag):
3885         (WebDragClient::dragSourceActionMaskForPoint):
3886         (WebDragClient::willPerformDragSourceAction):
3887         (WebDragClient::beginDrag):
3888         * WebView/WebView.mm:
3889         (-[WebView _startDrag:]):
3890         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3891         * WebView/WebViewInternal.h:
3892
3893 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3894
3895         Remove excessive headers from JavaScriptCore
3896         https://bugs.webkit.org/show_bug.cgi?id=173812
3897
3898         Reviewed by Darin Adler.
3899
3900         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3901         * WebView/WebView.mm:
3902
3903 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3904
3905         Remove an unused typedef from WebFrameLoaderClient
3906         https://bugs.webkit.org/show_bug.cgi?id=173795
3907
3908         Reviewed by Simon Fraser.
3909
3910         * WebCoreSupport/WebFrameLoaderClient.h:
3911         This unused typedef in the global namespace conflicts with one in a macOS system header.
3912         Also... it's unused.
3913         Remove it.
3914
3915 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3916
3917         Remove excessive headers from WebCore/{bindings,css,dom}
3918         https://bugs.webkit.org/show_bug.cgi?id=173766
3919
3920         Reviewed by Simon Fraser.
3921
3922         * DOM/DOMInternal.mm:
3923
3924 2017-06-22  Daniel Bates  <dabates@apple.com>
3925
3926         Make FrameLoadRequest a move-only type
3927         https://bugs.webkit.org/show_bug.cgi?id=173682
3928
3929         Reviewed by Alex Christensen and Darin Adler.
3930
3931         A FrameLoadRequest groups together the information to perform a load into a single object
3932         that is more manageable to pass around than its constituent parts. Code that receives a
3933         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3934         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3935         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3936
3937         * Plugins/WebPluginController.mm:
3938         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3939         * WebView/WebPDFView.mm:
3940         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3941
3942 2017-06-21  Antoine Quint  <graouts@apple.com>
3943
3944         Ensure DRT always logs rAF suspension debugging code
3945         https://bugs.webkit.org/show_bug.cgi?id=173681
3946
3947         Reviewed by Tim "Mr. T" Horton.
3948
3949         * WebView/WebPreferenceKeysPrivate.h:
3950         * WebView/WebPreferences.mm:
3951         (+[WebPreferences initialize]):
3952         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3953         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3954         * WebView/WebPreferencesPrivate.h:
3955         * WebView/WebView.mm:
3956         (-[WebView _preferencesChanged:]):
3957
3958 2017-06-21  Daniel Bates  <dabates@apple.com>
3959
3960         Cleanup FrameLoadRequest
3961         https://bugs.webkit.org/show_bug.cgi?id=173564
3962         <rdar://problem/32903570>
3963
3964         Reviewed by Brent Fulgham.
3965
3966         * WebView/WebPDFView.mm:
3967         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
3968         into a local variable and use C++11 brace initialization syntax to make it easier to identify
3969         the arguments passed to FrameLoader::loadFrameRequest().
3970
3971 2017-06-21  Antoine Quint  <graouts@apple.com>
3972
3973         Add logging to identify when the Page suspends scripted animations
3974         https://bugs.webkit.org/show_bug.cgi?id=173626
3975
3976         Reviewed by Tim Horton.
3977
3978         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
3979         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
3980
3981         * WebView/WebPreferenceKeysPrivate.h:
3982         * WebView/WebPreferences.mm:
3983         (+[WebPreferences initialize]):
3984         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
3985         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
3986         * WebView/WebPreferencesPrivate.h:
3987         * WebView/WebView.mm:
3988         (-[WebView _preferencesChanged:]):
3989
3990 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3991
3992         Disable font variations on macOS Sierra and iOS 10
3993         https://bugs.webkit.org/show_bug.cgi?id=173618
3994         <rdar://problem/32879164>
3995
3996         Reviewed by Jon Lee.
3997
3998         * Configurations/FeatureDefines.xcconfig:
3999
4000 2017-06-20  Daniel Bates  <dabates@apple.com>
4001
4002         Have FrameLoadRequest takes a Frame& instead of a Frame*
4003         https://bugs.webkit.org/show_bug.cgi?id=173614
4004         <rdar://problem/32884890>
4005
4006         Reviewed by Brent Fulgham.
4007
4008         * Plugins/WebPluginController.mm:
4009         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
4010         * WebView/WebFrame.mm:
4011         (-[WebFrame loadRequest:]):
4012         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
4013
4014 2017-06-19  Frederic Wang  <fwang@igalia.com>
4015
4016         [Mac] Add an experimental feature setting for async frame scrolling
4017         https://bugs.webkit.org/show_bug.cgi?id=173359
4018
4019         Reviewed by Simon Fraser.
4020
4021         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
4022         * WebView/WebPreferences.mm:
4023         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
4024         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
4025         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
4026         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
4027         * WebView/WebView.mm:
4028         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
4029         scrolling.
4030
4031 2017-06-19  Chris Dumez  <cdumez@apple.com>
4032
4033         Use WTF::Function instead of std::function in more places in WebCore/
4034         https://bugs.webkit.org/show_bug.cgi?id=173535
4035
4036         Reviewed by Antti Koivisto.
4037
4038         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
4039
4040         * WebCoreSupport/WebFrameLoaderClient.h:
4041         * WebCoreSupport/WebFrameLoaderClient.mm:
4042         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
4043         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
4044         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4045         (WebFrameLoaderClient::dispatchWillSubmitForm):
4046         (WebFrameLoaderClient::setUpPolicyListener):
4047         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
4048         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
4049
4050 2017-05-14 Frederic Wang  <fwang@igalia.com>
4051
4052         Add heuristic to avoid flattening "fullscreen" iframes
4053         https://bugs.webkit.org/show_bug.cgi?id=171914
4054
4055         Reviewed by Simon Fraser.
4056
4057         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
4058
4059         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
4060         * WebView/WebPreferences.mm:
4061         (+[WebPreferences initialize]): Handle frame flattening as an enum.
4062         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
4063         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
4064         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
4065         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
4066         * WebView/WebPreferencesPrivate.h: Ditto.
4067         * WebView/WebView.mm:
4068         (-[WebView _preferencesChanged:]): Ditto.
4069         * WebView/WebPreferencesPrivate.h: Add new enum definition.
4070
4071 2017-06-17  Chris Dumez  <cdumez@apple.com>
4072
4073         Use WTF::Function instead of std::function in WebKit2/
4074         https://bugs.webkit.org/show_bug.cgi?id=173504
4075