[watchOS] Enable Parental Controls content filtering
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-28  Andy Estes  <aestes@apple.com>
2
3         [watchOS] Enable Parental Controls content filtering
4         https://bugs.webkit.org/show_bug.cgi?id=193939
5         <rdar://problem/46641912>
6
7         Reviewed by Ryosuke Niwa.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2019-01-28  Timothy Hatcher  <timothy@apple.com>
12
13         Make it easier for non-Apple ports to enable dark mode CSS support.
14         https://bugs.webkit.org/show_bug.cgi?id=193882
15
16         Reviewed by Megan Gardner.
17
18         * WebView/WebView.mm:
19         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
20         (-[WebView _effectiveAppearanceIsDark]): Ditto.
21
22 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
23
24         AX: Introduce a static accessibility tree
25         https://bugs.webkit.org/show_bug.cgi?id=193348
26         <rdar://problem/47203295>
27
28         Reviewed by Ryosuke Niwa.
29
30         * Configurations/FeatureDefines.xcconfig:
31
32 2019-01-25  Keith Rollin  <krollin@apple.com>
33
34         Update WebKitAdditions.xcconfig with correct order of variable definitions
35         https://bugs.webkit.org/show_bug.cgi?id=193793
36         <rdar://problem/47532439>
37
38         Reviewed by Alex Christensen.
39
40         XCBuild changes the way xcconfig variables are evaluated. In short,
41         all config file assignments are now considered in part of the
42         evaluation. When using the new build system and an .xcconfig file
43         contains multiple assignments of the same build setting:
44
45         - Later assignments using $(inherited) will inherit from earlier
46           assignments in the xcconfig file.
47         - Later assignments not using $(inherited) will take precedence over
48           earlier assignments. An assignment to a more general setting will
49           mask an earlier assignment to a less general setting. For example,
50           an assignment without a condition ('FOO = bar') will completely mask
51           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
52
53         This affects some of our .xcconfig files, in that sometimes platform-
54         or sdk-specific definitions appear before the general definitions.
55         Under the new evaluations rules, the general definitions alway take
56         effect because they always overwrite the more-specific definitions. The
57         solution is to swap the order, so that the general definitions are
58         established first, and then conditionally overwritten by the
59         more-specific definitions.
60
61         * Configurations/Version.xcconfig:
62         * Configurations/WebKitLegacy.xcconfig:
63
64 2019-01-25  David Kilzer  <ddkilzer@apple.com>
65
66         Move soft-linking of Lookup.framework out of LookupSPI.h
67         <https://webkit.org/b/193815>
68
69         Reviewed by Tim Horton.
70
71         * WebView/WebImmediateActionController.mm:
72         (-[WebImmediateActionController _animationControllerForText]):
73         * WebView/WebView.mm:
74         (-[WebView _prepareForDictionaryLookup]):
75         - Move soft-linking to LookupSoftLink.{h,mm}.
76
77 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
78
79         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
80         https://bugs.webkit.org/show_bug.cgi?id=193829
81
82         Reviewed by Tim Horton.
83
84         * WebCoreSupport/WebDragClient.mm:
85         (WebDragClient::didConcludeEditDrag):
86         * WebView/WebView.mm:
87         (-[WebView _requestStartDataInteraction:globalPosition:]):
88         (-[WebView _didConcludeEditDrag]):
89         (-[WebView _didConcludeEditDataInteraction]): Deleted.
90         * WebView/WebViewInternal.h:
91
92 2019-01-24  John Wilander  <wilander@apple.com>
93
94         Add Ad Click Attribution as an internal/experimental feature
95         https://bugs.webkit.org/show_bug.cgi?id=193685
96         <rdar://problem/47450399>
97
98         Reviewed by Brent Fulgham.
99
100         * WebView/WebPreferenceKeysPrivate.h:
101         * WebView/WebPreferences.mm:
102         (+[WebPreferences initialize]):
103         (-[WebPreferences adClickAttributionEnabled]):
104         (-[WebPreferences setAdClickAttributionEnabled:]):
105             Added support for experimental ad click attribution.
106         * WebView/WebPreferencesPrivate.h:
107         * WebView/WebView.mm:
108         (-[WebView _preferencesChanged:]):
109
110 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
111
112         Move FileSystem to WTF
113         https://bugs.webkit.org/show_bug.cgi?id=193602
114
115         Reviewed by Yusuke Suzuki.
116
117         * Misc/WebNSFileManagerExtras.mm:
118         * Storage/WebDatabaseProvider.mm:
119         * WebView/WebView.mm:
120
121 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
122
123         Fix the Apple Internal build. See <rdar://problem/47491383>.
124
125         Rubber-stamped by Tim Horton.
126
127         * WebCoreSupport/WebFrameLoaderClient.mm:
128
129 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
130
131         Clean up USE(WEB_THREAD)
132         https://bugs.webkit.org/show_bug.cgi?id=193698
133
134         Rubber-stamped by Tim Horton.
135
136         * Misc/WebCache.mm:
137         (+[WebCache emptyInMemoryResources]):
138         * WebCoreSupport/WebFrameLoaderClient.mm:
139         (-[WebFramePolicyListener use]):
140         * WebCoreSupport/WebGeolocationClient.mm:
141         (-[WebGeolocationPolicyListener allow]):
142         (-[WebGeolocationPolicyListener deny]):
143         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
144         * WebView/WebFrame.mm:
145         (-[WebFrame deviceOrientationChanged]):
146         * WebView/WebHTMLView.mm:
147         (hardwareKeyboardAvailabilityChangedCallback):
148         * WebView/WebView.mm:
149         (+[WebView _releaseMemoryNow]):
150         (+[WebView willEnterBackgroundWithCompletionHandler:]):
151         (-[WebView updateLayoutIgnorePendingStyleSheets]):
152         (-[WebView _dispatchUnloadEvent]):
153         (-[WebView _close]):
154         (-[WebView _preferencesChangedNotification:]):
155         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
156         (-[WebView goBack]):
157         (-[WebView goForward]):
158         (+[WebView _cacheModelChangedNotification:]):
159         (-[WebView stopLoading:]):
160         (-[WebView stopLoadingAndClear]):
161         (-[WebView reload:]):
162         (WebInstallMemoryPressureHandler):
163
164 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
165
166         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
167         https://bugs.webkit.org/show_bug.cgi?id=193706
168         <rdar://problem/44807048>
169
170         Reviewed by Ryosuke Niwa.
171
172         Use UndoStep::label().
173
174         * WebCoreSupport/WebEditorClient.h:
175         * WebCoreSupport/WebEditorClient.mm:
176         (-[WebUndoStep initWithUndoStep:]):
177         (+[WebUndoStep stepWithUndoStep:]):
178         (WebEditorClient::registerUndoOrRedoStep):
179         (WebEditorClient::registerUndoStep):
180         (WebEditorClient::registerRedoStep):
181
182 2019-01-22  Alex Christensen  <achristensen@webkit.org>
183
184         Move NetworkStorageSession ownership to NetworkProcess
185         https://bugs.webkit.org/show_bug.cgi?id=193580
186
187         Reviewed by Geoff Garen.
188
189         * Misc/WebCache.mm:
190         (+[WebCache clearCachedCredentials]):
191         * Misc/WebDownload.mm:
192         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
193         * Plugins/WebBaseNetscapePluginView.mm:
194         (WebKit::getAuthenticationInfo):
195         * WebCoreSupport/WebFrameNetworkingContext.mm:
196         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
197         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
198         (WebFrameNetworkingContext::storageSession const):
199         * WebView/WebPreferences.mm:
200         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
201         (+[WebPreferences _clearNetworkLoaderSession]):
202         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
203
204 2019-01-22  Daniel Bates  <dabates@apple.com>
205
206         [iOS] Interpret text key commands on keydown and app key commands on keypress
207         https://bugs.webkit.org/show_bug.cgi?id=192897
208         <rdar://problem/46857378>
209
210         Reviewed by Brent Fulgham.
211
212         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
213         is false) and keypress (isCharEvent is true), respectively.
214
215         * WebView/WebHTMLView.mm:
216         (-[WebHTMLView _handleEditingKeyEvent:]):
217
218 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
219
220         [css-logical] Implement flow-relative margin, padding and border shorthands
221         https://bugs.webkit.org/show_bug.cgi?id=188697
222
223         Reviewed by Simon Fraser and Antti Koivisto.
224
225         Add CSSLogicalEnabled runtime flag.
226
227         * WebView/WebPreferenceKeysPrivate.h:
228         * WebView/WebPreferences.mm:
229         (+[WebPreferences initialize]):
230         (-[WebPreferences cssLogicalEnabled]):
231         (-[WebPreferences setCSSLogicalEnabled:]):
232         * WebView/WebPreferencesPrivate.h:
233         * WebView/WebView.mm:
234         (-[WebView _preferencesChanged:]):
235
236 2019-01-15  Darin Adler  <darin@apple.com>
237
238         Use references rather than pointers for register/unregister functions, and more
239         https://bugs.webkit.org/show_bug.cgi?id=175028
240
241         Reviewed by Daniel Bates.
242
243         * WebCoreSupport/WebKitFullScreenListener.mm:
244         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
245         functions in Document; pass a reference.
246         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
247         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
248         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
249         * WebView/WebFullScreenController.mm:
250         (-[WebFullScreenController enterFullScreen:]): Ditto.
251         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
252         (-[WebFullScreenController exitFullScreen]): Ditto.
253         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
254         * WebView/WebFullScreenController.mm:
255         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
256
257 2019-01-12  Dan Bernstein  <mitz@apple.com>
258
259         [Cocoa] Avoid importing directly from subumbrella frameworks
260         https://bugs.webkit.org/show_bug.cgi?id=186016
261         <rdar://problem/40591038>
262
263         Reviewed by Sam Weinig.
264
265         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
266         * Carbon/CarbonWindowAdapter.mm: Ditto.
267         * Carbon/CarbonWindowFrame.m: Ditto.
268         * Carbon/HIViewAdapter.h: Ditto.
269         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
270           OTHER_CFLAGS_COCOA_TOUCH_NO.
271         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
272         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
273         * WebView/WebPDFView.h: Ditto.
274
275 2019-01-20  Antoine Quint  <graouts@apple.com>
276
277         Add a POINTER_EVENTS feature flag
278         https://bugs.webkit.org/show_bug.cgi?id=193577
279         <rdar://problem/47408511>
280
281         Unreviewed. Also enable Pointer Events for iosmac.
282
283         * Configurations/FeatureDefines.xcconfig:
284
285 2019-01-19  Antoine Quint  <graouts@apple.com>
286
287         Add a POINTER_EVENTS feature flag
288         https://bugs.webkit.org/show_bug.cgi?id=193577
289
290         Reviewed by Dean Jackson.
291
292         * Configurations/FeatureDefines.xcconfig:
293
294 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
295
296         Revert r238815, it broke WK1 video fullscreen on Mac
297         https://bugs.webkit.org/show_bug.cgi?id=193586
298         <rdar://problem/47358941>
299
300         Reviewed by Jer Noble.
301
302         * WebView/WebVideoFullscreenController.h: Added.
303         * WebView/WebVideoFullscreenController.mm: Added.
304         (SOFT_LINK_CLASS):
305         (-[WebVideoFullscreenController init]):
306         (-[WebVideoFullscreenController dealloc]):
307         (-[WebVideoFullscreenController fullscreenWindow]):
308         (-[WebVideoFullscreenController windowDidLoad]):
309         (-[WebVideoFullscreenController videoElement]):
310         (-[WebVideoFullscreenController setVideoElement:]):
311         (-[WebVideoFullscreenController clearFadeAnimation]):
312         (-[WebVideoFullscreenController windowDidExitFullscreen]):
313         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
314         (-[WebVideoFullscreenController videoElementRect]):
315         (-[WebVideoFullscreenController applicationDidResignActive:]):
316         (frameExpandedToRatioOfFrame):
317         (createBackgroundFullscreenWindow):
318         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
319         (-[WebVideoFullscreenController enterFullscreen:]):
320         (-[WebVideoFullscreenController exitFullscreen]):
321         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
322         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
323         (-[WebVideoFullscreenController _requestExit]):
324         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
325         (-[WebVideoFullscreenController requestExitFullscreen]):
326         (-[WebVideoFullscreenController fadeHUDIn]):
327         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
328         (-[WebVideoFullscreenController rateChanged:]):
329         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
330         (-[WebVideoFullscreenWindow dealloc]):
331         (-[WebVideoFullscreenWindow resignFirstResponder]):
332         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
333         (-[WebVideoFullscreenWindow mouseDown:]):
334         (-[WebVideoFullscreenWindow cancelOperation:]):
335         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
336         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
337         (-[WebVideoFullscreenWindow animationDidEnd:]):
338         (-[WebVideoFullscreenWindow mouseMoved:]):
339         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
340         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
341         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
342         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
343         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
344         (-[WebVideoFullscreenHUDWindow center]):
345         (-[WebVideoFullscreenHUDWindow keyDown:]):
346         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
347         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
348         (-[WebVideoFullscreenHUDWindowController init]):
349         (-[WebVideoFullscreenHUDWindowController dealloc]):
350         (-[WebVideoFullscreenHUDWindowController setArea:]):
351         (-[WebVideoFullscreenHUDWindowController keyDown:]):
352         (-[WebVideoFullscreenHUDWindowController delegate]):
353         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
354         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
355         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
356         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
357         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
358         (-[WebVideoFullscreenHUDWindowController closeWindow]):
359         (createMediaUIControl):
360         (createControlWithMediaUIControlType):
361         (createTimeTextField):
362         (createMediaUIBackgroundView):
363         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
364         (-[WebVideoFullscreenHUDWindowController updateVolume]):
365         (-[WebVideoFullscreenHUDWindowController updateTime]):
366         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
367         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
368         (-[WebVideoFullscreenHUDWindowController currentTime]):
369         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
370         (-[WebVideoFullscreenHUDWindowController duration]):
371         (-[WebVideoFullscreenHUDWindowController maxVolume]):
372         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
373         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
374         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
375         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
376         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
377         (-[WebVideoFullscreenHUDWindowController volume]):
378         (-[WebVideoFullscreenHUDWindowController setVolume:]):
379         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
380         (-[WebVideoFullscreenHUDWindowController updateRate]):
381         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
382         (-[WebVideoFullscreenHUDWindowController playing]):
383         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
384         (timeToString):
385         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
386         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
387         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
388         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
389         (-[WebVideoFullscreenHUDWindowController rewind:]):
390         (-[WebVideoFullscreenHUDWindowController fastForward:]):
391         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
392         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
393         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
394         * WebView/WebView.mm:
395         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
396         (-[WebView _exitVideoFullscreen]):
397
398 2019-01-18  Tim Horton  <timothy_horton@apple.com>
399
400         Get rid of ADVANCED_SPELL_CHECKING
401         https://bugs.webkit.org/show_bug.cgi?id=193592
402
403         Reviewed by Wenson Hsieh.
404
405         * WebCoreSupport/WebEditorClient.mm:
406         (insertionPointFromCurrentSelection):
407         (WebEditorClient::checkTextOfParagraph):
408         (WebEditorClient::getGuessesForWord):
409         (WebEditorClient::requestCandidatesForSelection):
410         (WebEditorClient::requestCheckingOfString):
411         * WebView/WebHTMLView.mm:
412         (-[WebHTMLView insertText:]):
413
414 2019-01-18  Jer Noble  <jer.noble@apple.com>
415
416         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
417         https://bugs.webkit.org/show_bug.cgi?id=189553
418
419         Reviewed by Tim Horton.
420
421         * Configurations/Base.xcconfig:
422         * Configurations/SDKVariant.xcconfig: Added.
423         * Configurations/WebKitLegacy.xcconfig:
424
425 2019-01-18  David Kilzer  <ddkilzer@apple.com>
426
427         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
428         <https://webkit.org/b/193568>
429         <rdar://problem/47381130>
430
431         Reviewed by Alex Christensen.
432
433         * WebView/WebView.mm:
434         - Remove unused soft-linking macros.
435         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
436         (-[WebUITextIndicatorData initWithImage:scale:]):
437         - Update to use exported PAL functions.
438
439 2019-01-17  Truitt Savell  <tsavell@apple.com>
440
441         Unreviewed, rolling out r240124.
442
443         This commit broke an internal build.
444
445         Reverted changeset:
446
447         "SDK_VARIANT build destinations should be separate from non-
448         SDK_VARIANT builds"
449         https://bugs.webkit.org/show_bug.cgi?id=189553
450         https://trac.webkit.org/changeset/240124
451
452 2019-01-17  Jer Noble  <jer.noble@apple.com>
453
454         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
455         https://bugs.webkit.org/show_bug.cgi?id=189553
456
457         Reviewed by Tim Horton.
458
459         * Configurations/Base.xcconfig:
460         * Configurations/SDKVariant.xcconfig: Added.
461         * Configurations/WebKitLegacy.xcconfig:
462
463 2019-01-17  Alex Christensen  <achristensen@webkit.org>
464
465         Stop using NetworkStorageSession::storageSession in WebCore
466         https://bugs.webkit.org/show_bug.cgi?id=193529
467
468         Reviewed by Tim Horton.
469
470         * Misc/WebCache.mm:
471         (+[WebCache addImageToCache:forURL:forFrame:]):
472         * WebView/WebView.mm:
473         (-[WebView _commonInitializationWithFrameName:groupName:]):
474         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
475
476 2019-01-15  Alex Christensen  <achristensen@webkit.org>
477
478         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
479         https://bugs.webkit.org/show_bug.cgi?id=193368
480
481         Reviewed by Geoff Garen.
482
483         * Misc/WebCache.mm:
484         (+[WebCache clearCachedCredentials]):
485         * Misc/WebDownload.mm:
486         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
487         * Plugins/WebBaseNetscapePluginView.mm:
488         (WebKit::getAuthenticationInfo):
489
490 2019-01-15  Alex Christensen  <achristensen@webkit.org>
491
492         Stop using CookiesStrategy
493         https://bugs.webkit.org/show_bug.cgi?id=161106
494
495         Reviewed by Don Olmstead and Antti Koivisto.
496
497         * Misc/WebCache.mm:
498         (+[WebCache addImageToCache:forURL:forFrame:]):
499         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
500         (WebKit::NetscapePluginInstanceProxy::getCookies):
501         (WebKit::NetscapePluginInstanceProxy::setCookies):
502         * Plugins/WebNetscapePluginView.mm:
503         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
504         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
505         * WebCoreSupport/WebPlatformStrategies.h:
506         * WebCoreSupport/WebPlatformStrategies.mm:
507         (WebPlatformStrategies::createCookiesStrategy): Deleted.
508         (WebPlatformStrategies::cookiesForDOM): Deleted.
509         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
510         (WebPlatformStrategies::cookiesEnabled): Deleted.
511         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
512         (WebPlatformStrategies::getRawCookies): Deleted.
513         (WebPlatformStrategies::deleteCookie): Deleted.
514         * WebView/WebView.mm:
515         (-[WebView _commonInitializationWithFrameName:groupName:]):
516         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
517
518 2019-01-15  Tim Horton  <timothy_horton@apple.com>
519
520         Cannot tab out of WKWebView on macOS
521         https://bugs.webkit.org/show_bug.cgi?id=161448
522         <rdar://problem/28100085>
523
524         Reviewed by Dean Jackson.
525
526         * WebCoreSupport/WebChromeClient.mm:
527         * WebView/WebView.mm:
528         Make use of SPI headers.
529
530 2019-01-14  Commit Queue  <commit-queue@webkit.org>
531
532         Unreviewed, rolling out r239901, r239909, r239910, r239912,
533         r239913, and r239914.
534         https://bugs.webkit.org/show_bug.cgi?id=193407
535
536         These revisions caused an internal failure (Requested by
537         Truitt on #webkit).
538
539         Reverted changesets:
540
541         "[Cocoa] Avoid importing directly from subumbrella frameworks"
542         https://bugs.webkit.org/show_bug.cgi?id=186016
543         https://trac.webkit.org/changeset/239901
544
545         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
546         https://trac.webkit.org/changeset/239909
547
548         "Tried to fix the build."
549         https://trac.webkit.org/changeset/239910
550
551         "Fixed iOS builds after r239910."
552         https://trac.webkit.org/changeset/239912
553
554         "More build fixing."
555         https://trac.webkit.org/changeset/239913
556
557         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
558         https://trac.webkit.org/changeset/239914
559
560 2019-01-14  Mark Lam  <mark.lam@apple.com>
561
562         Re-enable ability to build --cloop builds.
563         https://bugs.webkit.org/show_bug.cgi?id=192955
564         <rdar://problem/46882363>
565
566         Reviewed by Saam barati and Keith Miller.
567
568         * Configurations/FeatureDefines.xcconfig:
569
570 2019-01-13  Dan Bernstein  <mitz@apple.com>
571
572         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
573
574         Patch by Keith Rollin.
575
576         * WebView/PDFViewSPI.h:
577
578 2019-01-12  Timothy Hatcher  <timothy@apple.com>
579
580         Have prefers-color-scheme: light always match on macOS versions before Mojave.
581         https://bugs.webkit.org/show_bug.cgi?id=191655
582         rdar://problem/46074680
583
584         Reviewed by Megan Gardner.
585
586         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
587         * WebView/WebView.mm:
588         (-[WebView _effectiveAppearanceIsDark]):
589
590 2019-01-12  Dan Bernstein  <mitz@apple.com>
591
592         [Cocoa] Avoid importing directly from subumbrella frameworks
593         https://bugs.webkit.org/show_bug.cgi?id=186016
594         <rdar://problem/40591038>
595
596         Reviewed by Sam Weinig.
597
598         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
599         * Carbon/CarbonWindowAdapter.mm: Ditto.
600         * Carbon/CarbonWindowFrame.m: Ditto.
601         * Carbon/HIViewAdapter.h: Ditto.
602         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
603           OTHER_CFLAGS_COCOA_TOUCH_NO.
604         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
605         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
606         * WebView/WebPDFView.h: Ditto.
607
608 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
609
610         Enable visual viewport API by default
611         https://bugs.webkit.org/show_bug.cgi?id=193376
612
613         Reviewed by Simon Fraser.
614
615         * WebView/WebPreferences.mm:
616         (+[WebPreferences initialize]):
617
618 2019-01-11  John Wilander  <wilander@apple.com>
619
620         Compile out Web API Statistics Collection
621         https://bugs.webkit.org/show_bug.cgi?id=193370
622         <rdar://problem/45388584>
623
624         Reviewed by Brent Fulgham.
625
626         * Configurations/FeatureDefines.xcconfig:
627             Defined ENABLE_WEB_API_STATISTICS, off by default.
628
629 2019-01-08  Alex Christensen  <achristensen@webkit.org>
630
631         Stop using NetworkStorageSession in WebProcess
632         https://bugs.webkit.org/show_bug.cgi?id=193236
633
634         Reviewed by Don Olmstead.
635
636         * WebCoreSupport/WebFrameNetworkingContext.h:
637         * WebCoreSupport/WebFrameNetworkingContext.mm:
638         (WebFrameNetworkingContext::storageSession const):
639         * WebCoreSupport/WebPlatformStrategies.h:
640         * WebCoreSupport/WebPlatformStrategies.mm:
641         (WebPlatformStrategies::cookiesForDOM):
642         (WebPlatformStrategies::setCookiesFromDOM):
643         (WebPlatformStrategies::cookiesEnabled):
644         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
645         (WebPlatformStrategies::getRawCookies):
646         (WebPlatformStrategies::deleteCookie):
647         * WebView/WebView.mm:
648         (-[WebView _cachedResponseForURL:]):
649         (-[WebView _clearCredentials]):
650
651 2019-01-08  Alex Christensen  <achristensen@webkit.org>
652
653         Unreviewed, rolling out r239727.
654
655         Broke API tests
656
657         Reverted changeset:
658
659         "Stop using NetworkStorageSession in WebProcess"
660         https://bugs.webkit.org/show_bug.cgi?id=193236
661         https://trac.webkit.org/changeset/239727
662
663 2019-01-08  Alex Christensen  <achristensen@webkit.org>
664
665         Stop using NetworkStorageSession in WebProcess
666         https://bugs.webkit.org/show_bug.cgi?id=193236
667
668         Reviewed by Don Olmstead.
669
670         * WebCoreSupport/WebFrameNetworkingContext.h:
671         * WebCoreSupport/WebFrameNetworkingContext.mm:
672         (WebFrameNetworkingContext::storageSession const):
673         * WebView/WebView.mm:
674         (-[WebView _cachedResponseForURL:]):
675         (-[WebView _clearCredentials]):
676
677 2019-01-07  David Kilzer  <ddkilzer@apple.com>
678
679         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
680         <https://webkit.org/b/193056>
681
682         Reviewed by Alex Christensen.
683
684         * Plugins/Hosted/NetscapePluginHostProxy.h:
685         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
686         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
687         (WebKit::NetscapePluginInstanceProxy::enumerate):
688         (WebKit::NetscapePluginInstanceProxy::marshalValue):
689         (WebKit::NetscapePluginInstanceProxy::marshalValues):
690         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
691         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
692         * Plugins/Hosted/ProxyInstance.mm:
693         (WebKit::ProxyInstance::invoke):
694         * WebCoreSupport/WebGeolocationClient.mm:
695         * WebView/WebDataSource.mm:
696         (-[WebDataSource _receivedData:]):
697         * WebView/WebView.mm:
698         (-[WebView _cachedResponseForURL:]):
699         - Remove '*' from RetainPtr<> type.
700
701 2019-01-04  Alex Christensen  <achristensen@webkit.org>
702
703         Progress towards fixing Mac CMake build
704         https://bugs.webkit.org/show_bug.cgi?id=193105
705
706         Reviewed by Don Olmstead.
707
708         * WebKitPrefix.h:
709
710 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
711
712         Web Inspector: Use save sheet instead of dialog where possible
713         https://bugs.webkit.org/show_bug.cgi?id=193160
714         <rdar://problem/37399759>
715
716         Reviewed by Devin Rousso.
717
718         * WebCoreSupport/WebInspectorClient.mm:
719         (WebInspectorFrontendClient::save):
720
721 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
722
723         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
724         https://bugs.webkit.org/show_bug.cgi?id=193129
725
726         Reviewed by Tim Horton.
727
728         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
729
730         * WebCoreSupport/WebEditorClient.mm:
731         (WebEditorClient::registerUndoOrRedoStep):
732         (undoNameForEditAction): Deleted.
733
734 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
735
736         Add support for using the current text selection as the find string on iOS
737         https://bugs.webkit.org/show_bug.cgi?id=193034
738         <rdar://problem/45138739>
739
740         Reviewed by Tim Horton.
741
742         Add a method stub for WebKitLegacy.
743
744         * WebCoreSupport/WebEditorClient.h:
745
746 2019-01-01  Jeff Miller  <jeffm@apple.com>
747
748         Update user-visible copyright strings to include 2019
749         https://bugs.webkit.org/show_bug.cgi?id=192811
750
751         Reviewed by Mark Lam.
752
753         * Info.plist:
754
755 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
756
757         Use Ref<> as much as possible
758         https://bugs.webkit.org/show_bug.cgi?id=192808
759
760         Reviewed by Alex Christensen.
761
762         * DOM/DOM.mm:
763         (-[DOMNode getPreviewSnapshotImage:andRects:]):
764         * Plugins/Hosted/NetscapePluginHostManager.mm:
765         (WebKit::NetscapePluginHostManager::instantiatePlugin):
766         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
767         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
768         (WebKit::NetscapePluginInstanceProxy::loadRequest):
769         * Plugins/WebNetscapePluginView.mm:
770         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
771         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
772         * WebCoreSupport/WebContextMenuClient.mm:
773         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
774         * WebCoreSupport/WebFrameLoaderClient.mm:
775         (WebFrameLoaderClient::transitionToCommittedForNewPage):
776         * WebView/WebFrame.mm:
777         (-[WebFrame getDictationResultRanges:andMetadatas:]):
778         * WebView/WebHTMLView.mm:
779         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
780         * WebView/WebView.mm:
781         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
782         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
783
784 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
785
786         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
787         https://bugs.webkit.org/show_bug.cgi?id=192821
788
789         Reviewed by Chris Dumez.
790
791         When a window becomes occluded, the window server informs the application.
792         This should be used to suspend any work that is not visible by the user.
793
794         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
795         In some cases, that lead to performance impact (see radar).
796
797         This patch adds an observer for the occlusion notification. I tried to stick
798         with the same names used by WebKit2.
799
800         * WebView/WebView.mm:
801         (-[WebView _isViewVisible]):
802         (-[WebView addWindowObserversForWindow:]):
803         (-[WebView removeWindowObservers]):
804         (-[WebView _windowDidChangeOcclusionState:]):
805
806 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
807
808         [WebAuthN] Add a runtime flag for local authenticator
809         https://bugs.webkit.org/show_bug.cgi?id=192792
810         <rdar://problem/46798738>
811
812         Reviewed by Brent Fulgham.
813
814         * WebView/WebPreferenceKeysPrivate.h:
815         * WebView/WebPreferences.mm:
816         (+[WebPreferences initialize]):
817         (-[WebPreferences webAuthenticationEnabled]): Deleted.
818         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
819         * WebView/WebPreferencesPrivate.h:
820         * WebView/WebView.mm:
821         (-[WebView _preferencesChanged:]):
822
823 2018-12-20  Chris Dumez  <cdumez@apple.com>
824
825         Use Optional::valueOr() instead of Optional::value_or()
826         https://bugs.webkit.org/show_bug.cgi?id=192933
827
828         Reviewed by Geoffrey Garen.
829
830         * WebCoreSupport/WebSecurityOrigin.mm:
831         (-[WebSecurityOrigin port]):
832
833 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
834
835         Unreviewed, rolling out r239417.
836
837         Introduced two API test failures on macOS.
838
839         Reverted changeset:
840
841         "<rdar://problem/46194315> macOS: WebKit1 does not handle
842         occlusion changes"
843         https://bugs.webkit.org/show_bug.cgi?id=192821
844         https://trac.webkit.org/changeset/239417
845
846 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
847
848         WKWebView default UA doesn't freeze the build number
849         https://bugs.webkit.org/show_bug.cgi?id=192809
850         <rdar://problem/44687185>
851
852         Reviewed by Andy Estes.
853
854         Always reports the frozen build number.
855
856         * WebView/WebView.mm:
857         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
858         actual build number through this method call.
859         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
860
861 2018-12-19  Chris Dumez  <cdumez@apple.com>
862
863         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
864         https://bugs.webkit.org/show_bug.cgi?id=192728
865         <rdar://problem/46746779>
866
867         Reviewed by Geoff Garen.
868
869         * DOM/*:
870         * Plugins/*:
871         * WebCoreSupport/*:
872         * WebView/*:
873
874 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
875
876         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
877         https://bugs.webkit.org/show_bug.cgi?id=192821
878
879         Reviewed by Chris Dumez.
880
881         When a window becomes occluded, the window server informs the application.
882         This should be used to suspend any work that is not visible by the user.
883
884         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
885         In some cases, that lead to performance impact (see radar).
886
887         This patch adds an observer for the occlusion notification. I tried to stick
888         with the same names used by WebKit2.
889
890         * WebView/WebView.mm:
891         (-[WebView _isViewVisible]):
892         (-[WebView addWindowObserversForWindow:]):
893         (-[WebView removeWindowObservers]):
894         (-[WebView _windowDidChangeOcclusionState:]):
895
896 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
897
898         Allow clients to set the navigator platform
899         https://bugs.webkit.org/show_bug.cgi?id=192735
900
901         Reviewed by Tim Horton.
902
903         Add stubs to fill out the added functionality in FrameLoaderClient.
904
905         * WebCoreSupport/WebFrameLoaderClient.h:
906         * WebCoreSupport/WebFrameLoaderClient.mm:
907         (WebFrameLoaderClient::navigatorPlatform):
908
909 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
910
911         offsetLeft and offsetParent should adjust across shadow boundaries
912         https://bugs.webkit.org/show_bug.cgi?id=157437
913         <rdar://problem/26154021>
914
915         Reviewed by Simon Fraser.
916
917         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
918
919         * DOM/DOMElement.mm:
920         (-[DOMElement offsetLeft]):
921         (-[DOMElement offsetTop]):
922         (-[DOMElement offsetParent]):
923
924 2018-12-17  Zalan Bujtas  <zalan@apple.com>
925
926         Unreviewed build fix.
927
928         * WebView/WebFrame.mm:
929         (-[WebFrame getDictationResultRanges:andMetadatas:]):
930
931 2018-12-15  Darin Adler  <darin@apple.com>
932
933         Use warning-ignoring macros more consistently and simply
934         https://bugs.webkit.org/show_bug.cgi?id=192743
935
936         Reviewed by Mark Lam.
937
938         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
939         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
940         compilers in Objective-C++ code.
941
942         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
943         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
944         accomodate non-clang compilers here. Also use #pragma once, add a missing
945         "explicit" and fix conditionals.
946
947 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
948
949         Make TextInputController.legacyAttributedString take DOM nodes and offsets
950         https://bugs.webkit.org/show_bug.cgi?id=192653
951
952         Reviewed by Wenson Hsieh.
953
954         * WebView/WebHTMLView.mm:
955         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
956
957 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
958
959         Implement feature flag for CSS Typed OM
960         https://bugs.webkit.org/show_bug.cgi?id=192610
961
962         Reviewed by Ryosuke Niwa.
963
964         * Configurations/FeatureDefines.xcconfig:
965
966 2018-12-11  Tim Horton  <timothy_horton@apple.com>
967
968         WebCore shouldn't have a Objective-C class named NSCursor
969         https://bugs.webkit.org/show_bug.cgi?id=192602
970         <rdar://problem/46615532>
971
972         Reviewed by Wenson Hsieh.
973
974         * WebView/WebFrameView.mm:
975         (-[WebFrameView keyDown:keyDown:]):
976         * WebView/WebHTMLView.mm:
977         (-[WebHTMLView keyDown:]):
978         (-[WebHTMLView performKeyEquivalent:]):
979         Only use NSCursor on macOS.
980
981 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
982
983         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
984         https://bugs.webkit.org/show_bug.cgi?id=192573
985
986         Reviewed by Simon Fraser.
987
988         * Configurations/FeatureDefines.xcconfig:
989
990 2018-12-10  Antti Koivisto  <antti@apple.com>
991
992         Rename "forced style recalc" to "full style rebuild"
993         https://bugs.webkit.org/show_bug.cgi?id=192572
994
995         Reviewed by Zalan Bujtas.
996
997         * WebView/WebHTMLView.mm:
998         (-[WebHTMLView setNeedsToApplyStyles:]):
999
1000 2018-12-10  Darin Adler  <darin@apple.com>
1001
1002         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1003         https://bugs.webkit.org/show_bug.cgi?id=192533
1004         rdar://problem/45732710
1005
1006         Reviewed by Anders Carlsson.
1007
1008         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1009         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1010
1011 2018-12-10  Darin Adler  <darin@apple.com>
1012
1013         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1014         https://bugs.webkit.org/show_bug.cgi?id=192532
1015         rdar://problem/45731047
1016
1017         Reviewed by Chris Dumez.
1018
1019         * Plugins/Hosted/NetscapePluginHostManager.mm:
1020         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1021         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1022         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1023
1024 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1025
1026         Turn WritingDirection into an enum class
1027         https://bugs.webkit.org/show_bug.cgi?id=192401
1028         Work towards <rdar://problem/42075638>
1029
1030         Reviewed by Dan Bernstein.
1031
1032         Change WritingDirection from an enum to an enum class. No change in behavior.
1033
1034         * WebView/WebHTMLView.mm:
1035         (-[WebHTMLView toggleBaseWritingDirection:]):
1036         (-[WebHTMLView changeBaseWritingDirection:]):
1037         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1038
1039 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1040
1041         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1042         https://bugs.webkit.org/show_bug.cgi?id=192272
1043
1044         Reviewed by Brady Eidson.
1045
1046         * WebCoreSupport/WebFrameLoaderClient.h:
1047         * WebCoreSupport/WebFrameLoaderClient.mm:
1048         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1049
1050 2018-12-03  Jer Noble  <jer.noble@apple.com>
1051
1052         Get rid of old, dead Mac video fullscreen code.
1053         https://bugs.webkit.org/show_bug.cgi?id=192315
1054
1055         Reviewed by Eric Carlson.
1056
1057         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1058         is no longer supported in the Mac port.
1059
1060         * WebView/WebVideoFullscreenController.h: Removed.
1061         * WebView/WebVideoFullscreenController.mm: Removed.
1062         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1063         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1064         * WebView/WebView.mm:
1065         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1066         (-[WebView _exitVideoFullscreen]):
1067
1068 2018-12-03  Daniel Bates  <dabates@apple.com>
1069
1070         [iOS] Do not handle key events that are key commands
1071         https://bugs.webkit.org/show_bug.cgi?id=191608
1072         <rdar://problem/46046013>
1073
1074         Reviewed by Ryosuke Niwa.
1075
1076         A key down event may be associated with a key command. If it is then we want to execute the
1077         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1078         event as a key command to find out.
1079
1080         * WebView/WebHTMLView.mm:
1081         (-[WebHTMLView _handleEditingKeyEvent:]):
1082
1083 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1084
1085         Add a runtime feature flag for LayoutFormattingContext.
1086         https://bugs.webkit.org/show_bug.cgi?id=192280
1087
1088         Reviewed by Simon Fraser.
1089
1090         * Configurations/FeatureDefines.xcconfig:
1091
1092 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1093
1094         Move URL from WebCore to WTF
1095         https://bugs.webkit.org/show_bug.cgi?id=190234
1096
1097         Reviewed by Keith Miller.
1098
1099         * DOM/DOMAttr.mm:
1100         * DOM/DOMBlob.mm:
1101         * DOM/DOMCSSCharsetRule.mm:
1102         * DOM/DOMCSSImportRule.mm:
1103         * DOM/DOMCSSMediaRule.mm:
1104         * DOM/DOMCSSPageRule.mm:
1105         * DOM/DOMCSSPrimitiveValue.mm:
1106         * DOM/DOMCSSRule.mm:
1107         * DOM/DOMCSSStyleDeclaration.mm:
1108         * DOM/DOMCSSStyleRule.mm:
1109         * DOM/DOMCSSStyleSheet.mm:
1110         * DOM/DOMCSSValue.mm:
1111         * DOM/DOMCharacterData.mm:
1112         * DOM/DOMCounter.mm:
1113         * DOM/DOMDocument.mm:
1114         * DOM/DOMDocumentFragment.mm:
1115         * DOM/DOMDocumentType.mm:
1116         * DOM/DOMEvent.mm:
1117         * DOM/DOMFile.mm:
1118         * DOM/DOMHTMLAnchorElement.mm:
1119         * DOM/DOMHTMLAppletElement.mm:
1120         * DOM/DOMHTMLAreaElement.mm:
1121         * DOM/DOMHTMLBRElement.mm:
1122         * DOM/DOMHTMLBaseElement.mm:
1123         * DOM/DOMHTMLBaseFontElement.mm:
1124         * DOM/DOMHTMLBodyElement.mm:
1125         * DOM/DOMHTMLButtonElement.mm:
1126         * DOM/DOMHTMLCanvasElement.mm:
1127         * DOM/DOMHTMLCollection.mm:
1128         * DOM/DOMHTMLDivElement.mm:
1129         * DOM/DOMHTMLDocument.mm:
1130         * DOM/DOMHTMLElement.mm:
1131         * DOM/DOMHTMLEmbedElement.mm:
1132         * DOM/DOMHTMLFieldSetElement.mm:
1133         * DOM/DOMHTMLFontElement.mm:
1134         * DOM/DOMHTMLFormElement.mm:
1135         * DOM/DOMHTMLFrameElement.mm:
1136         * DOM/DOMHTMLFrameSetElement.mm:
1137         * DOM/DOMHTMLHRElement.mm:
1138         * DOM/DOMHTMLHeadElement.mm:
1139         * DOM/DOMHTMLHeadingElement.mm:
1140         * DOM/DOMHTMLHtmlElement.mm:
1141         * DOM/DOMHTMLIFrameElement.mm:
1142         * DOM/DOMHTMLImageElement.mm:
1143         * DOM/DOMHTMLInputElement.mm:
1144         * DOM/DOMHTMLLIElement.mm:
1145         * DOM/DOMHTMLLabelElement.mm:
1146         * DOM/DOMHTMLLegendElement.mm:
1147         * DOM/DOMHTMLLinkElement.mm:
1148         * DOM/DOMHTMLMapElement.mm:
1149         * DOM/DOMHTMLMarqueeElement.mm:
1150         * DOM/DOMHTMLMediaElement.mm:
1151         * DOM/DOMHTMLMetaElement.mm:
1152         * DOM/DOMHTMLModElement.mm:
1153         * DOM/DOMHTMLOListElement.mm:
1154         * DOM/DOMHTMLObjectElement.mm:
1155         * DOM/DOMHTMLOptGroupElement.mm:
1156         * DOM/DOMHTMLOptionElement.mm:
1157         * DOM/DOMHTMLOptionsCollection.mm:
1158         * DOM/DOMHTMLParagraphElement.mm:
1159         * DOM/DOMHTMLParamElement.mm:
1160         * DOM/DOMHTMLQuoteElement.mm:
1161         * DOM/DOMHTMLScriptElement.mm:
1162         * DOM/DOMHTMLSelectElement.mm:
1163         * DOM/DOMHTMLStyleElement.mm:
1164         * DOM/DOMHTMLTableCaptionElement.mm:
1165         * DOM/DOMHTMLTableCellElement.mm:
1166         * DOM/DOMHTMLTableColElement.mm:
1167         * DOM/DOMHTMLTableElement.mm:
1168         * DOM/DOMHTMLTableRowElement.mm:
1169         * DOM/DOMHTMLTableSectionElement.mm:
1170         * DOM/DOMHTMLTitleElement.mm:
1171         * DOM/DOMHTMLUListElement.mm:
1172         * DOM/DOMHTMLVideoElement.mm:
1173         * DOM/DOMKeyboardEvent.mm:
1174         * DOM/DOMMediaList.mm:
1175         * DOM/DOMMouseEvent.mm:
1176         * DOM/DOMMutationEvent.mm:
1177         * DOM/DOMNamedNodeMap.mm:
1178         * DOM/DOMProcessingInstruction.mm:
1179         * DOM/DOMRange.mm:
1180         * DOM/DOMStyleSheet.mm:
1181         * DOM/DOMText.mm:
1182         * DOM/DOMTextEvent.mm:
1183         * DOM/DOMTokenList.mm:
1184         * DOM/DOMUIEvent.mm:
1185         * DOM/DOMXPathResult.mm:
1186         * History/WebHistoryItem.mm:
1187         * Misc/WebNSURLExtras.mm:
1188         (-[NSURL _web_userVisibleString]):
1189         (-[NSURL _web_URLByRemovingUserInfo]):
1190         (-[NSURL _web_dataForURLComponentType:]):
1191         (-[NSURL _web_schemeData]):
1192         (-[NSURL _web_hostData]):
1193         * Misc/WebUserContentURLPattern.mm:
1194         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1195         * Plugins/WebNetscapePluginStream.h:
1196         (WebNetscapePluginStream::setRequestURL):
1197         * WebCoreSupport/WebChromeClient.h:
1198         * WebCoreSupport/WebChromeClient.mm:
1199         (WebChromeClient::signedPublicKeyAndChallengeString const):
1200         * WebCoreSupport/WebContextMenuClient.h:
1201         * WebCoreSupport/WebContextMenuClient.mm:
1202         * WebCoreSupport/WebDragClient.h:
1203         * WebCoreSupport/WebFrameLoaderClient.h:
1204         * WebCoreSupport/WebFrameLoaderClient.mm:
1205         (WebFrameLoaderClient::updateGlobalHistory):
1206         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1207         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1208         (WebPaymentCoordinatorClient::showPaymentUI):
1209         * WebCoreSupport/WebPlatformStrategies.h:
1210         * WebCoreSupport/WebPlatformStrategies.mm:
1211         (WebPlatformStrategies::readURLFromPasteboard):
1212         * WebCoreSupport/WebPluginInfoProvider.h:
1213         * WebCoreSupport/WebPluginInfoProvider.mm:
1214         (WebPluginInfoProvider::webVisiblePluginInfo):
1215         * WebCoreSupport/WebSecurityOrigin.mm:
1216         * WebCoreSupport/WebVisitedLinkStore.h:
1217         * WebView/WebDataSource.mm:
1218         * WebView/WebFrame.mm:
1219         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1220         * WebView/WebImmediateActionController.mm:
1221         (-[WebImmediateActionController _defaultAnimationController]):
1222         * WebView/WebPDFView.mm:
1223         * WebView/WebScriptDebugger.mm:
1224         * WebView/WebViewInternal.h:
1225
1226 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1227
1228         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1229         https://bugs.webkit.org/show_bug.cgi?id=192197
1230
1231         Reviewed by Jiewen Tan.
1232
1233         * Configurations/FeatureDefines.xcconfig:
1234         * WebCoreSupport/WebChromeClient.h:
1235         * WebCoreSupport/WebChromeClient.mm:
1236
1237 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1238
1239         Remove dead code from an earlier attempt at implementing safe browsing
1240         https://bugs.webkit.org/show_bug.cgi?id=192067
1241
1242         Reviewed by Chris Dumez.
1243
1244         * WebCoreSupport/WebFrameLoaderClient.h:
1245         * WebCoreSupport/WebFrameLoaderClient.mm:
1246         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1247
1248 2018-11-27  Mark Lam  <mark.lam@apple.com>
1249
1250         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1251         https://bugs.webkit.org/show_bug.cgi?id=192055
1252         <rdar://problem/46288783>
1253
1254         Reviewed by Saam Barati.
1255
1256         * Configurations/FeatureDefines.xcconfig:
1257
1258 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1259
1260         Make it possible to insert editable images with a gesture
1261         https://bugs.webkit.org/show_bug.cgi?id=191937
1262
1263         Reviewed by Wenson Hsieh.
1264
1265         * WebCoreSupport/WebEditorClient.mm:
1266         (undoNameForEditAction):
1267         Add a undo name.
1268
1269 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1270
1271         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1272         https://bugs.webkit.org/show_bug.cgi?id=191945
1273
1274         Reviewed by Anders Carlsson.
1275
1276         * WebCoreSupport/WebEditorClient.mm:
1277         (undoNameForEditAction):
1278
1279 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1280
1281         Enable drag and drop support for iOSMac
1282         https://bugs.webkit.org/show_bug.cgi?id=191818
1283         <rdar://problem/43907454>
1284
1285         Reviewed by Dean Jackson.
1286
1287         * Configurations/FeatureDefines.xcconfig:
1288
1289 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1290
1291         Address post-review feedback after r238438
1292         https://bugs.webkit.org/show_bug.cgi?id=191913
1293
1294         Reviewed by Ryosuke Niwa.
1295
1296         * WebView/WebFrame.mm:
1297         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1298         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1299         * WebView/WebView.mm:
1300         (-[WebView setSelectedDOMRange:affinity:]):
1301
1302 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1303
1304         Web Inspector: "Reload Web Inspector" button no longer partially works
1305         https://bugs.webkit.org/show_bug.cgi?id=191773
1306         <rdar://problem/46139932>
1307
1308         Reviewed by Devin Rousso.
1309
1310         * WebCoreSupport/WebInspectorClient.h:
1311         * WebCoreSupport/WebInspectorClient.mm:
1312         (WebInspectorFrontendClient::reopen):
1313
1314 2018-11-17  Devin Rousso  <drousso@apple.com>
1315
1316         Web Inspector: Network: add button to show system certificate dialog
1317         https://bugs.webkit.org/show_bug.cgi?id=191458
1318         <rdar://problem/45977019>
1319
1320         Reviewed by Joseph Pecoraro.
1321
1322         * WebCoreSupport/WebInspectorClient.h:
1323         * WebCoreSupport/WebInspectorClient.mm:
1324         (WebInspectorFrontendClient::showCertificate): Added.
1325
1326         * Configurations/WebKitLegacy.xcconfig:
1327
1328 2018-11-15  Truitt Savell  <tsavell@apple.com>
1329
1330         Unreviewed, rolling out r238244.
1331
1332         Caused High Sierra test runs to fail early with 50 crashes and
1333         casued 25 API failures.
1334
1335         Reverted changeset:
1336
1337         "[css-logical] Implement flow-relative margin, padding and
1338         border shorthands"
1339         https://bugs.webkit.org/show_bug.cgi?id=188697
1340         https://trac.webkit.org/changeset/238244
1341
1342 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1343
1344         [css-logical] Implement flow-relative margin, padding and border shorthands
1345         https://bugs.webkit.org/show_bug.cgi?id=188697
1346
1347         Reviewed by Simon Fraser and Antti Koivisto.
1348
1349         Add CSSLogicalEnabled runtime flag.
1350
1351         * WebView/WebPreferenceKeysPrivate.h:
1352         * WebView/WebPreferences.mm:
1353         (+[WebPreferences initialize]):
1354         (-[WebPreferences cssLogicalEnabled]):
1355         (-[WebPreferences setCSSLogicalEnabled:]):
1356         * WebView/WebPreferencesPrivate.h:
1357         * WebView/WebView.mm:
1358         (-[WebView _preferencesChanged:]):
1359
1360 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1361
1362         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1363         https://bugs.webkit.org/show_bug.cgi?id=191612
1364
1365         Reviewed by Matt Baker.
1366
1367         * WebCoreSupport/WebInspectorClient.mm:
1368         (-[WebInspectorWindowController destroyInspectorView]):
1369
1370 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1371
1372         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1373         https://bugs.webkit.org/show_bug.cgi?id=191494
1374         <rdar://problem/45469854>
1375
1376         Reviewed by Devin Rousso.
1377
1378         * WebCoreSupport/WebInspectorClient.h:
1379         WebKitLegacy will still have remote inspection of the Page directly.
1380
1381 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1382
1383         Make compositing updates incremental
1384         https://bugs.webkit.org/show_bug.cgi?id=90342
1385
1386         Reviewed by Antti Koivisto.
1387
1388         Fix spelling error.
1389
1390         * WebView/WebView.mm:
1391         (-[WebView _setMediaLayer:forPluginView:]):
1392
1393 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1394
1395         Implement a new edit command to change the enclosing list type
1396         https://bugs.webkit.org/show_bug.cgi?id=191487
1397         <rdar://problem/45955922>
1398
1399         Reviewed by Ryosuke Niwa.
1400
1401         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1402
1403         * WebCoreSupport/WebEditorClient.mm:
1404         (undoNameForEditAction):
1405
1406 2018-11-11  Daniel Bates  <dabates@apple.com>
1407
1408         [iOS] Draw caps lock indicator in password fields
1409         https://bugs.webkit.org/show_bug.cgi?id=190565
1410         <rdar://problem/45262343>
1411
1412         Reviewed by Dean Jackson.
1413
1414         Update the caps lock state when a hardware keyboard is attached or detached.
1415
1416         * WebView/WebHTMLView.mm:
1417         (hardwareKeyboardAvailabilityChangedCallback): Added.
1418         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1419         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1420
1421 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1422
1423         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1424         https://bugs.webkit.org/show_bug.cgi?id=191492
1425
1426         Reviewed by Alex Christensen.
1427
1428         * Carbon/HIWebView.mm:
1429         * Misc/WebNSFileManagerExtras.mm:
1430         * Misc/WebNSURLExtras.mm:
1431         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1432         * Plugins/WebBasePluginPackage.mm:
1433         * Plugins/WebPluginContainerCheck.mm:
1434         * WebCoreSupport/WebCachedFramePlatformData.h:
1435         * WebCoreSupport/WebDeviceOrientationClient.mm:
1436         * WebView/WebDelegateImplementationCaching.mm:
1437         * WebView/WebHTMLView.mm:
1438         * WebView/WebPDFRepresentation.mm:
1439         * WebView/WebPolicyDelegate.mm:
1440         * WebView/WebView.mm:
1441
1442 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1443
1444         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1445         https://bugs.webkit.org/show_bug.cgi?id=191492
1446
1447         Reviewed by Alex Christensen.
1448
1449         * Carbon/HIWebView.mm:
1450         (UpdateCommandStatus):
1451         * Misc/WebNSFileManagerExtras.mm:
1452         * Misc/WebNSURLExtras.mm:
1453         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1454         * Plugins/WebBasePluginPackage.mm:
1455         * Plugins/WebPluginContainerCheck.mm:
1456         (-[WebPluginContainerCheck _continueWithPolicy:]):
1457         * WebCoreSupport/WebCachedFramePlatformData.h:
1458         (WebCachedFramePlatformData::clear):
1459         * WebCoreSupport/WebDeviceOrientationClient.mm:
1460         (WebDeviceOrientationClient::getProvider const):
1461         * WebView/WebDelegateImplementationCaching.mm:
1462         (CallDelegate):
1463         (CallDelegateReturningBoolean):
1464         (CallResourceLoadDelegateReturningBoolean):
1465         (CallFormDelegate):
1466         (CallFormDelegateReturningBoolean):
1467         * WebView/WebHTMLView.mm:
1468         * WebView/WebPDFRepresentation.mm:
1469         * WebView/WebPolicyDelegate.mm:
1470         (-[WebPolicyDecisionListener _usePolicy:]):
1471         * WebView/WebView.mm:
1472
1473 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1474
1475         Unreviewed, rolling out r238047.
1476
1477         Introduced layout test failures on iOS simulator.
1478
1479         Reverted changeset:
1480
1481         "[iOS] Draw caps lock indicator in password fields"
1482         https://bugs.webkit.org/show_bug.cgi?id=190565
1483         https://trac.webkit.org/changeset/238047
1484
1485 2018-11-09  Antti Koivisto  <antti@apple.com>
1486
1487         Use OptionSet for layout milestones
1488         https://bugs.webkit.org/show_bug.cgi?id=191470
1489
1490         Reviewed by Dean Jackson.
1491
1492         * WebCoreSupport/WebFrameLoaderClient.h:
1493         * WebCoreSupport/WebFrameLoaderClient.mm:
1494         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1495         * WebView/WebView.mm:
1496         (coreLayoutMilestones):
1497         (kitLayoutMilestones):
1498         (-[WebView _cacheFrameLoadDelegateImplementations]):
1499         * WebView/WebViewInternal.h:
1500
1501 2018-11-09  Daniel Bates  <dabates@apple.com>
1502
1503         [iOS] Draw caps lock indicator in password fields
1504         https://bugs.webkit.org/show_bug.cgi?id=190565
1505         <rdar://problem/45262343>
1506
1507         Reviewed by Dean Jackson.
1508
1509         Update the caps lock state when a hardware keyboard is attached or detached.
1510
1511         * WebView/WebHTMLView.mm:
1512         (hardwareKeyboardAvailabilityChangedCallback): Added.
1513         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1514         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1515
1516 2018-11-09  Daniel Bates  <dabates@apple.com>
1517
1518         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1519         action when forward delete is pressed outside a text field
1520         https://bugs.webkit.org/show_bug.cgi?id=190566
1521         <rdar://problem/45262367>
1522
1523         Reviewed by Wenson Hsieh.
1524
1525         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1526         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1527         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1528
1529         * WebView/WebHTMLView.mm:
1530         (-[WebHTMLView _handleEditingKeyEvent:]):
1531
1532 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1533
1534         Adopt Reveal Framework to replace Lookup
1535         https://bugs.webkit.org/show_bug.cgi?id=191097
1536         <rdar://problem/45924508>
1537
1538         Reviewed by Tim Horton.
1539
1540         Pass in what it needed to clear the textIndicators. This is better than
1541         the current notification structure.
1542
1543         * WebView/WebView.mm:
1544         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1545         (-[WebView _prepareForDictionaryLookup]):
1546
1547 2018-11-06  Justin Fan  <justin_fan@apple.com>
1548
1549         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1550         https://bugs.webkit.org/show_bug.cgi?id=191291
1551
1552         Reviewed by Myles Maxfield.
1553
1554         Properly disable WEBGPU on all non-Metal platforms for now.
1555
1556         * Configurations/FeatureDefines.xcconfig:
1557
1558 2018-11-02  Daniel Bates  <dabates@apple.com>
1559
1560         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1561         https://bugs.webkit.org/show_bug.cgi?id=190487
1562
1563         Reviewed by Tim Horton.
1564
1565         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1566         allow the default handling.
1567
1568         * WebView/WebHTMLView.mm:
1569         (-[WebHTMLView _handleEditingKeyEvent:]):
1570
1571 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1572
1573         Add a storage limit for IndexedDB
1574         https://bugs.webkit.org/show_bug.cgi?id=190598
1575         <rdar://problem/44654715>
1576
1577         Reviewed by Chris Dumez.
1578
1579         * Storage/WebDatabaseManager.mm:
1580         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1581         * Storage/WebDatabaseManagerPrivate.h:
1582
1583 2018-10-31  Antti Koivisto  <antti@apple.com>
1584
1585         Remove LayerFlushScheduler
1586         https://bugs.webkit.org/show_bug.cgi?id=191103
1587
1588         Reviewed by Anders Carlsson.
1589
1590         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1591         all the virtual cruft.
1592
1593         * WebView/WebViewData.h:
1594         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1595         (): Deleted.
1596         * WebView/WebViewData.mm:
1597         (currentRunLoop):
1598         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1599         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1600         (WebViewLayerFlushScheduler::schedule):
1601         (WebViewLayerFlushScheduler::invalidate):
1602         (WebViewLayerFlushScheduler::layerFlushCallback):
1603
1604 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1605
1606         Enable InstallAPI for iOS unconditionally
1607         https://bugs.webkit.org/show_bug.cgi?id=191043
1608         rdar://problem/32728423
1609
1610         Reviewed by Dan Bernstein.
1611
1612         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1613         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1614         shouldn't be processed by InstallAPI.
1615         * MigrateHeaders.make: Removed an obsolete workaround.
1616         * Misc/NSURLDownloadSPI.h: Added.
1617         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1618
1619 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1620
1621         Clean up some obsolete MAX_ALLOWED macros
1622         https://bugs.webkit.org/show_bug.cgi?id=190916
1623
1624         Reviewed by Tim Horton.
1625
1626         * WebView/WebHTMLView.mm:
1627         (-[WebHTMLView pressureChangeWithEvent:]):
1628         * WebView/WebPDFView.h:
1629
1630 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1631
1632         Unreviewed, rolling out r237600 and r237604.
1633         https://bugs.webkit.org/show_bug.cgi?id=191086
1634
1635         Breaks internal iOS builds (Requested by ryanhadd_ on
1636         #webkit).
1637
1638         Reverted changesets:
1639
1640         "Enable InstallAPI for iOS unconditionally"
1641         https://bugs.webkit.org/show_bug.cgi?id=191043
1642         https://trac.webkit.org/changeset/237600
1643
1644         "Build fix attempt after enabling InstallAPI for iOS."
1645         https://bugs.webkit.org/show_bug.cgi?id=191043
1646         https://trac.webkit.org/changeset/237604
1647
1648 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1649
1650         Enable InstallAPI for iOS unconditionally
1651         https://bugs.webkit.org/show_bug.cgi?id=191043
1652         rdar://problem/32728423
1653
1654         Reviewed by Dan Bernstein.
1655
1656         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1657         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1658         shouldn't be processed by InstallAPI.
1659         * MigrateHeaders.make: Removed an obsolete workaround.
1660         * Misc/NSURLDownloadSPI.h: Added.
1661         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1662
1663 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1664
1665         Modernize WebKit nibs and lprojs for localization's sake
1666         https://bugs.webkit.org/show_bug.cgi?id=190911
1667         <rdar://problem/45349466>
1668
1669         Reviewed by Dan Bernstein.
1670
1671         * Misc/WebNSControlExtras.m:
1672         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1673         NSWindow and its contents are both in the same scale space these days; avoid
1674         double-applying the scale factor, or you can't see the prompt.
1675
1676         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1677         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1678         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1679         NIB->XIB
1680
1681 2018-10-25  Antoine Quint  <graouts@apple.com>
1682
1683         [Web Animations] Turn Web Animations CSS Integration off by default
1684         https://bugs.webkit.org/show_bug.cgi?id=190901
1685
1686         Reviewed by Dean Jackson.
1687
1688         * WebView/WebPreferences.mm:
1689         (+[WebPreferences initialize]):
1690
1691 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1692
1693         Clean up some obsolete macOS version guards
1694         https://bugs.webkit.org/show_bug.cgi?id=190887
1695
1696         Reviewed by Dan Bernstein.
1697
1698         * Misc/WebNSPasteboardExtras.mm:
1699         (+[NSPasteboard _web_dragTypesForURL]):
1700         * WebCoreSupport/PopupMenuMac.mm:
1701         (PopupMenuMac::show):
1702         * WebCoreSupport/WebEditorClient.h:
1703         * WebCoreSupport/WebEditorClient.mm:
1704         (WebEditorClient::respondToChangedSelection):
1705         * WebView/WebPDFView.mm:
1706         (-[WebPDFView _clipViewForPDFDocumentView]):
1707
1708 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1709
1710         Turn on Conic Gradients
1711         https://bugs.webkit.org/show_bug.cgi?id=190810
1712
1713         Reviewed by Tim Horton.
1714
1715         * Configurations/FeatureDefines.xcconfig:
1716
1717 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1718
1719         Cleanup: MIMETypeRegistry functions
1720         https://bugs.webkit.org/show_bug.cgi?id=190838
1721
1722         Reviewed by Simon Fraser.
1723
1724         * Misc/WebNSPasteboardExtras.mm:
1725         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1726         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1727         because they were identical.
1728
1729         * WebView/WebHTMLRepresentation.mm:
1730         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1731         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1732         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1733         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1734         * WebView/WebView.mm:
1735         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1736         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1737         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1738
1739 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1740
1741         Fix false positive leaks when using custom -init methods that don't start with -init
1742         <https://webkit.org/b/190818>
1743         <rdar://problem/45476042>
1744
1745         Reviewed by Dan Bernstein.
1746
1747         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1748         it is accessible by both categories.
1749         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1750         NSError (WebKitInternal) category.  Add attribute to make this
1751         behave like an -init method.
1752         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1753         NSError (WebKitInternal) category.  Modernize method.  Replace
1754         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1755
1756 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1757
1758         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1759         https://bugs.webkit.org/show_bug.cgi?id=190729
1760
1761         Reviewed by Tim Horton.
1762
1763         * DOM/DOM.mm:
1764         (-[DOMNode boundingBox]):
1765         * DOM/DOMElement.mm:
1766         * DOM/DOMHTML.mm:
1767         * DOM/DOMInternal.mm:
1768         * DOM/DOMUIKitExtensions.mm:
1769         * DOM/WebDOMOperations.mm:
1770         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1771         * DefaultDelegates/WebDefaultEditingDelegate.m:
1772         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1773         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1774         * DefaultDelegates/WebDefaultUIDelegate.h:
1775         * DefaultDelegates/WebDefaultUIDelegate.mm:
1776         (-[WebDefaultUIDelegate webViewClose:]):
1777         (-[WebDefaultUIDelegate webViewFocus:]):
1778         (-[WebDefaultUIDelegate webViewUnfocus:]):
1779         (-[WebDefaultUIDelegate webViewIsResizable:]):
1780         (-[WebDefaultUIDelegate webView:setResizable:]):
1781         (-[WebDefaultUIDelegate webView:setFrame:]):
1782         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1783         * History/BackForwardList.h:
1784         * History/BackForwardList.mm:
1785         * History/WebBackForwardList.mm:
1786         (+[WebBackForwardList initialize]):
1787         (bumperCarBackForwardHackNeeded):
1788         * History/WebHistory.mm:
1789         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1790         (-[WebHistory _sendNotification:entries:]):
1791         (-[WebHistory loadFromURL:error:]):
1792         (-[WebHistory saveToURL:error:]):
1793         * History/WebHistoryItem.mm:
1794         (WKNotifyHistoryItemChanged):
1795         (+[WebHistoryItem initialize]):
1796         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1797         * History/WebURLsWithTitles.m:
1798         * Misc/WebCache.mm:
1799         (+[WebCache initialize]):
1800         * Misc/WebDownload.mm:
1801         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1802         * Misc/WebElementDictionary.mm:
1803         (+[WebElementDictionary initialize]):
1804         (+[WebElementDictionary initializeLookupTable]):
1805         * Misc/WebIconDatabase.mm:
1806         * Misc/WebKitNSStringExtras.mm:
1807         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1808         * Misc/WebKitVersionChecks.h:
1809         * Misc/WebKitVersionChecks.mm:
1810         (WebKitLinkedOnOrAfter):
1811         (WebKitLinkTimeVersion):
1812         * Misc/WebLocalizableStrings.mm:
1813         * Misc/WebNSControlExtras.h:
1814         * Misc/WebNSControlExtras.m:
1815         * Misc/WebNSEventExtras.m:
1816         * Misc/WebNSFileManagerExtras.mm:
1817         * Misc/WebNSImageExtras.h:
1818         * Misc/WebNSImageExtras.m:
1819         * Misc/WebNSPasteboardExtras.mm:
1820         * Misc/WebNSPrintOperationExtras.h:
1821         * Misc/WebNSPrintOperationExtras.m:
1822         * Misc/WebNSViewExtras.m:
1823         * Misc/WebNSWindowExtras.m:
1824         * Panels/WebAuthenticationPanel.h:
1825         * Panels/WebAuthenticationPanel.m:
1826         * Panels/WebPanelAuthenticationHandler.m:
1827         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1828         (+[WebHostedNetscapePluginView initialize]):
1829         * Plugins/WebBasePluginPackage.h:
1830         * Plugins/WebBasePluginPackage.mm:
1831         * Plugins/WebJavaPlugIn.h:
1832         * Plugins/WebPluginContainerCheck.mm:
1833         * Plugins/WebPluginController.h:
1834         * Plugins/WebPluginController.mm:
1835         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1836         (-[WebPluginController addPlugin:]):
1837         (-[WebPluginController destroyPlugin:]):
1838         (-[WebPluginController destroyAllPlugins]):
1839         * Plugins/WebPluginDatabase.mm:
1840         (+[WebPluginDatabase _defaultPlugInPaths]):
1841         * Plugins/WebPluginPackage.mm:
1842         (-[WebPluginPackage initWithPath:]):
1843         * Storage/WebDatabaseManager.mm:
1844         (-[WebDatabaseManager deleteAllDatabases]):
1845         * Storage/WebDatabaseManagerClient.h:
1846         * Storage/WebDatabaseManagerClient.mm:
1847         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1848         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1849         * Storage/WebStorageManager.mm:
1850         (-[WebStorageManager deleteAllOrigins]):
1851         (WebKitInitializeStorageIfNecessary):
1852         * WebCoreSupport/WebAlternativeTextClient.h:
1853         * WebCoreSupport/WebApplicationCache.mm:
1854         (applicationCacheBundleIdentifier):
1855         * WebCoreSupport/WebChromeClient.h:
1856         * WebCoreSupport/WebChromeClient.mm:
1857         (WebChromeClient::setWindowRect):
1858         (WebChromeClient::windowRect):
1859         (WebChromeClient::takeFocus):
1860         (WebChromeClient::addMessageToConsole):
1861         (WebChromeClient::enableSuddenTermination):
1862         (WebChromeClient::disableSuddenTermination):
1863         (WebChromeClient::createPopupMenu const):
1864         (WebChromeClient::createSearchPopupMenu const):
1865         (WebChromeClient::shouldPaintEntireContents const):
1866         (WebChromeClient::supportsVideoFullscreen):
1867         (WebChromeClient::supportsFullScreenForElement):
1868         (WebChromeClient::enterFullScreenForElement):
1869         (WebChromeClient::exitFullScreenForElement):
1870         * WebCoreSupport/WebContextMenuClient.mm:
1871         * WebCoreSupport/WebDragClient.mm:
1872         * WebCoreSupport/WebEditorClient.h:
1873         * WebCoreSupport/WebEditorClient.mm:
1874         (+[WebUndoStep initialize]):
1875         (updateFontPanel):
1876         (WebEditorClient::didBeginEditing):
1877         (WebEditorClient::respondToChangedContents):
1878         (WebEditorClient::respondToChangedSelection):
1879         (WebEditorClient::canceledComposition):
1880         (WebEditorClient::didEndEditing):
1881         (WebEditorClient::didWriteSelectionToPasteboard):
1882         (attributesForAttributedStringConversion):
1883         (WebEditorClient::setInsertionPasteboard):
1884         (WebEditorClient::registerUndoOrRedoStep):
1885         (WebEditorClient::handleKeyboardEvent):
1886         (WebEditorClient::handleInputMethodKeydown):
1887         (WebEditorClient::textDidChangeInTextField):
1888         (WebEditorClient::requestCheckingOfString):
1889         * WebCoreSupport/WebFrameLoaderClient.h:
1890         * WebCoreSupport/WebFrameLoaderClient.mm:
1891         (WebFrameLoaderClient::detachedFromParent2):
1892         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1893         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1894         (WebFrameLoaderClient::dispatchWillSendRequest):
1895         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1896         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1897         (WebFrameLoaderClient::willCacheResponse const):
1898         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1899         (WebFrameLoaderClient::dispatchDidFinishLoading):
1900         (WebFrameLoaderClient::dispatchDidFailLoading):
1901         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1902         (WebFrameLoaderClient::dispatchWillClose):
1903         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1904         (WebFrameLoaderClient::dispatchDidCommitLoad):
1905         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1906         (WebFrameLoaderClient::dispatchDidFailLoad):
1907         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1908         (WebFrameLoaderClient::dispatchDidFinishLoad):
1909         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1910         (WebFrameLoaderClient::willChangeTitle):
1911         (WebFrameLoaderClient::didChangeTitle):
1912         (WebFrameLoaderClient::didReplaceMultipartContent):
1913         (WebFrameLoaderClient::updateGlobalHistory):
1914         (WebFrameLoaderClient::saveViewStateToItem):
1915         (WebFrameLoaderClient::restoreViewState):
1916         (WebFrameLoaderClient::provisionalLoadStarted):
1917         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1918         (WebFrameLoaderClient::setTitle):
1919         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1920         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1921         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1922         (WebFrameLoaderClient::didRestoreFromPageCache):
1923         (WebFrameLoaderClient::actionDictionary const):
1924         (WebFrameLoaderClient::createPlugin):
1925         (WebFrameLoaderClient::getLoadDecisionForIcons):
1926         (WebFrameLoaderClient::finishedLoadingIcon):
1927         (+[WebFramePolicyListener initialize]):
1928         * WebCoreSupport/WebFrameNetworkingContext.mm:
1929         * WebCoreSupport/WebGeolocationClient.h:
1930         * WebCoreSupport/WebGeolocationClient.mm:
1931         (WebGeolocationClient::requestPermission):
1932         * WebCoreSupport/WebInspectorClient.h:
1933         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1934         * WebCoreSupport/WebNotificationClient.mm:
1935         * WebCoreSupport/WebOpenPanelResultListener.mm:
1936         * WebCoreSupport/WebPlatformStrategies.h:
1937         * WebCoreSupport/WebPlatformStrategies.mm:
1938         * WebCoreSupport/WebProgressTrackerClient.h:
1939         * WebCoreSupport/WebProgressTrackerClient.mm:
1940         (WebProgressTrackerClient::progressStarted):
1941         (WebProgressTrackerClient::progressEstimateChanged):
1942         (WebProgressTrackerClient::progressFinished):
1943         * WebCoreSupport/WebSecurityOrigin.mm:
1944         * WebInspector/WebNodeHighlight.h:
1945         * WebInspector/WebNodeHighlight.mm:
1946         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1947         (-[WebNodeHighlight dealloc]):
1948         (-[WebNodeHighlight attach]):
1949         * WebInspector/WebNodeHighlightView.h:
1950         * WebInspector/WebNodeHighlightView.mm:
1951         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1952         (-[WebNodeHighlightView dealloc]):
1953         * WebInspector/WebNodeHighlighter.mm:
1954         (-[WebNodeHighlighter highlight]):
1955         * WebView/WebArchive.mm:
1956         (+[WebArchivePrivate initialize]):
1957         * WebView/WebClipView.h:
1958         * WebView/WebDataSource.mm:
1959         (WebDataSourcePrivate::WebDataSourcePrivate):
1960         (+[WebDataSource initialize]):
1961         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1962         (-[WebDataSource _makeRepresentation]):
1963         * WebView/WebDelegateImplementationCaching.h:
1964         * WebView/WebDelegateImplementationCaching.mm:
1965         (CallDelegate):
1966         (CallDelegateReturningFloat):
1967         (CallDelegateReturningBoolean):
1968         (CallUIDelegate):
1969         (CallUIDelegateReturningFloat):
1970         (CallUIDelegateReturningBoolean):
1971         (CallFrameLoadDelegate):
1972         (CallFrameLoadDelegateReturningBoolean):
1973         (CallResourceLoadDelegate):
1974         (CallScriptDebugDelegate):
1975         (CallFormDelegate):
1976         (CallFormDelegateReturningBoolean):
1977         * WebView/WebDeviceOrientation.mm:
1978         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1979         * WebView/WebDocumentInternal.h:
1980         * WebView/WebDocumentLoaderMac.mm:
1981         (needsDataLoadWorkaround):
1982         * WebView/WebDynamicScrollBarsViewInternal.h:
1983         * WebView/WebFormDelegate.m:
1984         * WebView/WebFrame.mm:
1985         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1986         (-[WebFrame _unmarkAllMisspellings]):
1987         (-[WebFrame _paintBehaviorForDestinationContext:]):
1988         (-[WebFrame _drawRect:contentsOnly:]):
1989         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1990         (-[WebFrame _scrollDOMRangeToVisible:]):
1991         (-[WebFrame _bodyBackgroundColor]):
1992         (-[WebFrame accessibilityRoot]):
1993         (needsMicrosoftMessengerDOMDocumentWorkaround):
1994         * WebView/WebFrameInternal.h:
1995         * WebView/WebFrameView.mm:
1996         (-[WebFrameView _setDocumentView:]):
1997         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1998         (-[WebFrameView _viewClassForMIMEType:]):
1999         (-[WebFrameView initWithFrame:]):
2000         (-[WebFrameView drawRect:]):
2001         (-[WebFrameView _firstResponderIsFormControl]):
2002         (-[WebFrameView keyDown:keyDown:]):
2003         (-[WebFrameView _isScrollable]):
2004         * WebView/WebFullScreenController.h:
2005         * WebView/WebFullScreenController.mm:
2006         * WebView/WebHTMLRepresentation.mm:
2007         * WebView/WebHTMLView.mm:
2008         (-[WebHTMLView hitTest:]):
2009         (-[WebHTMLView initWithFrame:]):
2010         (-[WebHTMLView dealloc]):
2011         (-[WebHTMLView addSubview:]):
2012         (-[WebHTMLView mouseDown:]):
2013         (-[WebHTMLView mouseUp:]):
2014         (-[WebHTMLView resignFirstResponder]):
2015         (-[WebHTMLView accessibilityHitTest:]):
2016         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2017         * WebView/WebHTMLViewInternal.h:
2018         * WebView/WebIndicateLayer.h:
2019         * WebView/WebIndicateLayer.mm:
2020         * WebView/WebMediaPlaybackTargetPicker.h:
2021         * WebView/WebMediaPlaybackTargetPicker.mm:
2022         * WebView/WebPDFDocumentExtras.h:
2023         * WebView/WebPDFDocumentExtras.mm:
2024         * WebView/WebPDFRepresentation.h:
2025         * WebView/WebPDFRepresentation.mm:
2026         * WebView/WebPDFView.h:
2027         * WebView/WebPreferences.mm:
2028         (cacheModelForMainBundle):
2029         (WebPreferencesPrivate::WebPreferencesPrivate):
2030         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2031         (-[WebPreferences encodeWithCoder:]):
2032         (+[WebPreferences standardPreferences]):
2033         (+[WebPreferences initialize]):
2034         (-[WebPreferences _valueForKey:]):
2035         (-[WebPreferences _setStringValue:forKey:]):
2036         (-[WebPreferences _setIntegerValue:forKey:]):
2037         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2038         (-[WebPreferences _setFloatValue:forKey:]):
2039         (-[WebPreferences _setBoolValue:forKey:]):
2040         (-[WebPreferences _setLongLongValue:forKey:]):
2041         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2042         (-[WebPreferences _postCacheModelChangedNotification]):
2043         (-[WebPreferences _postPreferencesChangedNotification]):
2044         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2045         (-[WebPreferences setStorageBlockingPolicy:]):
2046         * WebView/WebResource.mm:
2047         (+[WebResourcePrivate initialize]):
2048         * WebView/WebTextCompletionController.h:
2049         * WebView/WebTextIterator.mm:
2050         (+[WebTextIteratorPrivate initialize]):
2051         * WebView/WebView.mm:
2052         (shouldEnableLoadDeferring):
2053         (shouldRestrictWindowFocus):
2054         (shouldRespectPriorityInCSSAttributeSetters):
2055         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2056         (shouldAllowPictureInPictureMediaPlayback):
2057         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2058         (shouldAllowWindowOpenWithoutUserGesture):
2059         (shouldConvertInvalidURLsToBlank):
2060         (shouldRequireUserGestureToLoadVideo):
2061         (-[WebView _commonInitializationWithFrameName:groupName:]):
2062         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2063         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2064         (-[WebView _closePluginDatabases]):
2065         (-[WebView _closeWithFastTeardown]):
2066         (-[WebView _close]):
2067         (+[WebView _MIMETypeForFile:]):
2068         (-[WebView setShowingInspectorIndication:]):
2069         (-[WebView _setFormDelegate:]):
2070         (-[WebView _needsPreHTML5ParserQuirks]):
2071         (-[WebView _preferencesChangedNotification:]):
2072         (-[WebView _preferencesChanged:]):
2073         (-[WebView _cacheResourceLoadDelegateImplementations]):
2074         (-[WebView _cacheFrameLoadDelegateImplementations]):
2075         (-[WebView _policyDelegateForwarder]):
2076         (-[WebView _UIDelegateForwarder]):
2077         (-[WebView _editingDelegateForwarder]):
2078         (-[WebView _updateActiveState]):
2079         (-[_WebSafeForwarder forwardInvocation:]):
2080         (+[WebView initialize]):
2081         (-[WebView _pluginForMIMEType:]):
2082         (-[WebView _pluginForExtension:]):
2083         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2084         (+[WebView canShowMIMETypeAsHTML:]):
2085         (-[WebView _initWithArguments:]):
2086         (-[WebView initWithFrame:frameName:groupName:]):
2087         (-[WebView dealloc]):
2088         (-[WebView close]):
2089         (-[WebView viewDidMoveToWindow]):
2090         (-[WebView setUIDelegate:]):
2091         (-[WebView setResourceLoadDelegate:]):
2092         (-[WebView setPolicyDelegate:]):
2093         (-[WebView setFrameLoadDelegate:]):
2094         (-[WebView goBack]):
2095         (-[WebView goForward]):
2096         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2097         (-[WebView setHostWindow:]):
2098         (-[WebView becomeFirstResponder]):
2099         (+[WebView _cacheModelChangedNotification:]):
2100         (-[WebView _frameViewAtWindowPoint:]):
2101         (+[WebView _preflightSpellCheckerNow:]):
2102         (+[WebView _preflightSpellChecker]):
2103         (-[WebView canGoBack]):
2104         (-[WebView canGoForward]):
2105         (-[WebView stopLoading:]):
2106         (-[WebView reload:]):
2107         (-[WebView setMainFrameDocumentReady:]):
2108         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2109         (-[WebView setContinuousSpellCheckingEnabled:]):
2110         (-[WebView undoManager]):
2111         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2112         (-[WebView isAutomaticLinkDetectionEnabled]):
2113         (-[WebView isAutomaticDashSubstitutionEnabled]):
2114         (-[WebView isAutomaticTextReplacementEnabled]):
2115         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2116         (+[WebView _setCacheModel:]):
2117         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2118         (-[WebView _keyboardUIMode]):
2119         (LayerFlushController::flushLayers):
2120         (-[WebView _scheduleCompositingLayerFlush]):
2121         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2122         (-[WebView fullScreenPlaceholderView]):
2123         (WebInstallMemoryPressureHandler):
2124         * WebView/WebViewData.h:
2125         * WebView/WebViewData.mm:
2126         (+[WebViewPrivate initialize]):
2127         (-[WebViewPrivate init]):
2128         (-[WebViewPrivate dealloc]):
2129         * WebView/WebViewInternal.h:
2130
2131 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2132
2133         Clean up FrameLoader two-state enums
2134         https://bugs.webkit.org/show_bug.cgi?id=190731
2135
2136         Reviewed by Chris Dumez.
2137
2138         * WebCoreSupport/WebFrameLoaderClient.h:
2139         * WebCoreSupport/WebFrameLoaderClient.mm:
2140         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2141
2142 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2143
2144         Unreviewed, rolling out r237137.
2145
2146         SPI is actually used
2147
2148         Reverted changeset:
2149
2150         "Remove unused WebFrame._loadType"
2151         https://bugs.webkit.org/show_bug.cgi?id=190583
2152         https://trac.webkit.org/changeset/237137
2153
2154 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2155
2156         Enable the datalist element by default on iOS and macOS
2157         https://bugs.webkit.org/show_bug.cgi?id=190594
2158         <rdar://problem/45281159>
2159
2160         Reviewed by Ryosuke Niwa and Tim Horton.
2161
2162         * Configurations/FeatureDefines.xcconfig:
2163
2164 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2165
2166         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2167         https://bugs.webkit.org/show_bug.cgi?id=190675
2168
2169         Reviewed by Chris Dumez.
2170
2171         * History/BackForwardList.h:
2172         * History/BackForwardList.mm:
2173         (BackForwardList::backItem):
2174         (BackForwardList::currentItem):
2175         (BackForwardList::forwardItem):
2176         (BackForwardList::backListCount const):
2177         (BackForwardList::forwardListCount const):
2178         (BackForwardList::itemAtIndex):
2179         * History/WebBackForwardList.mm:
2180         (-[WebBackForwardList backItem]):
2181         (-[WebBackForwardList currentItem]):
2182         (-[WebBackForwardList forwardItem]):
2183         (-[WebBackForwardList itemAtIndex:]):
2184
2185 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2186
2187         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2188         https://bugs.webkit.org/show_bug.cgi?id=190526
2189         rdar://problem/45230140
2190
2191         Reviewed by Dean Jackson.
2192
2193         * WebCoreSupport/WebEditorClient.mm:
2194         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2195
2196 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2197
2198         Implement feature flag and bindings for CSS Painting API
2199         https://bugs.webkit.org/show_bug.cgi?id=190237
2200
2201         Reviewed by Ryosuke Niwa.
2202
2203         * Configurations/FeatureDefines.xcconfig:
2204
2205 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2206
2207         Replace HistoryItem* with HistoryItem& where possible
2208         https://bugs.webkit.org/show_bug.cgi?id=190617
2209
2210         Reviewed by Chris Dumez.
2211
2212         * History/BackForwardList.h:
2213         * History/BackForwardList.mm:
2214         (BackForwardList::goToItem):
2215         * History/WebBackForwardList.mm:
2216         (-[WebBackForwardList goToItem:]):
2217         * History/WebHistoryItem.mm:
2218         (WKNotifyHistoryItemChanged):
2219         * History/WebHistoryItemInternal.h:
2220
2221 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2222
2223         Remove unused WebHistoryItem._transientPropertyForKey
2224         https://bugs.webkit.org/show_bug.cgi?id=190606
2225
2226         Reviewed by Chris Dumez.
2227
2228         * History/WebHistoryItem.mm:
2229         * History/WebHistoryItemPrivate.h:
2230
2231 2018-10-15  Justin Fan  <justin_fan@apple.com>
2232
2233         Add WebGPU 2018 feature flag and experimental feature flag
2234         https://bugs.webkit.org/show_bug.cgi?id=190509
2235
2236         Reviewed by Dean Jackson.
2237
2238         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2239         for the 2018 WebGPU prototype.
2240
2241         * Configurations/FeatureDefines.xcconfig:
2242         * WebView/WebPreferenceKeysPrivate.h:
2243         * WebView/WebPreferences.mm:
2244         (+[WebPreferences initialize]):
2245         (-[WebPreferences webGPUEnabled]):
2246         (-[WebPreferences setWebGPUEnabled:]):
2247         * WebView/WebPreferencesPrivate.h:
2248         * WebView/WebView.mm:
2249         (-[WebView _preferencesChanged:]):
2250
2251 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2252
2253         Fix iOS build after r237157
2254
2255         * WebView/WebView.mm:
2256         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2257
2258 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2259
2260         Modernize BackForwardClient.h
2261         https://bugs.webkit.org/show_bug.cgi?id=190610
2262
2263         Reviewed by Chris Dumez.
2264
2265         * History/BackForwardList.h:
2266         * History/BackForwardList.mm:
2267         (BackForwardList::backListCount const):
2268         (BackForwardList::forwardListCount const):
2269         (BackForwardList::backListCount): Deleted.
2270         (BackForwardList::forwardListCount): Deleted.
2271         * History/WebBackForwardList.mm:
2272         (-[WebBackForwardList init]):
2273         * WebCoreSupport/WebFrameLoaderClient.mm:
2274         (WebFrameLoaderClient::canCachePage const):
2275         * WebView/WebFrameView.mm:
2276         (-[WebFrameView keyDown:keyDown:]):
2277         * WebView/WebView.mm:
2278         (-[WebView _commonInitializationWithFrameName:groupName:]):
2279         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2280         (-[WebView _loadBackForwardListFromOtherView:]):
2281         (-[WebView initWithCoder:]):
2282         (-[WebView encodeWithCoder:]):
2283         (-[WebView backForwardList]):
2284         (-[WebView setMaintainsBackForwardList:]):
2285
2286 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2287
2288         Add support for prefers-color-scheme media query
2289         https://bugs.webkit.org/show_bug.cgi?id=190499
2290         rdar://problem/45212025
2291
2292         Reviewed by Dean Jackson.
2293
2294         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2295
2296 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2297
2298         Remove unused WebView._globalHistoryItem
2299         https://bugs.webkit.org/show_bug.cgi?id=190601
2300
2301         Reviewed by Chris Dumez.
2302
2303         * WebCoreSupport/WebFrameLoaderClient.h:
2304         * WebCoreSupport/WebFrameLoaderClient.mm:
2305         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2306         * WebView/WebView.mm:
2307         (-[WebView _globalHistoryItem]): Deleted.
2308         (-[WebView _setGlobalHistoryItem:]): Deleted.
2309         * WebView/WebViewData.h:
2310         * WebView/WebViewInternal.h:
2311         * WebView/WebViewPrivate.h:
2312
2313 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2314
2315         Remove unused parameters from FrameLoaderClient::createFrame
2316         https://bugs.webkit.org/show_bug.cgi?id=190587
2317
2318         Reviewed by Chris Dumez.
2319
2320         * WebCoreSupport/WebFrameLoaderClient.h:
2321         * WebCoreSupport/WebFrameLoaderClient.mm:
2322         (WebFrameLoaderClient::createFrame):
2323
2324 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2325
2326         Remove unused WebFrame._loadType
2327         https://bugs.webkit.org/show_bug.cgi?id=190583
2328
2329         Reviewed by Chris Dumez.
2330
2331         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2332
2333         * WebView/WebFrame.mm:
2334         (toWebFrameLoadType): Deleted.
2335         (-[WebFrame _loadType]): Deleted.
2336         * WebView/WebFramePrivate.h:
2337
2338 2018-10-15  Chris Dumez  <cdumez@apple.com>
2339
2340         Restrict browsing context lookup by name to frames that are related to one another
2341         https://bugs.webkit.org/show_bug.cgi?id=190475
2342
2343         Reviewed by Alex Christensen.
2344
2345         * WebView/WebFrame.mm:
2346         (-[WebFrame findFrameNamed:]):
2347
2348 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2349
2350         Remove InjectedBundle processing of back/forward lists
2351         https://bugs.webkit.org/show_bug.cgi?id=190459
2352
2353         Reviewed by Chris Dumez.
2354
2355         * WebCoreSupport/WebFrameLoaderClient.h:
2356         * WebCoreSupport/WebFrameLoaderClient.mm:
2357         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2358
2359 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2360
2361         [JSC] Remove Option::useAsyncIterator
2362         https://bugs.webkit.org/show_bug.cgi?id=190567
2363
2364         Reviewed by Saam Barati.
2365
2366         * Configurations/FeatureDefines.xcconfig:
2367
2368 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2369
2370         Allow encoding of small enum classes
2371         https://bugs.webkit.org/show_bug.cgi?id=190531
2372
2373         Reviewed by Tim Horton.
2374
2375         * WebCoreSupport/WebFrameLoaderClient.mm:
2376         (-[WebFramePolicyListener dealloc]):
2377
2378 2018-10-11  Keith Rollin  <krollin@apple.com>
2379
2380         CURRENT_ARCH should not be used in Run Script phase.
2381         https://bugs.webkit.org/show_bug.cgi?id=190407
2382         <rdar://problem/45133556>
2383
2384         Reviewed by Alexey Proskuryakov.
2385
2386         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2387         CURRENT_ARCH is not well-defined during this phase (and may even have
2388         the value "undefined") since this phase is run just once per build
2389         rather than once per supported architecture. Migrate away from
2390         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2391         performing an operation for each value, or by picking the first entry
2392         in ARCHS and using that as a representative value.
2393
2394         * Configurations/WebKitLegacy.xcconfig: When generating
2395         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2396         macosx platforms.
2397
2398         * MigrateHeaders.make:
2399         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2400         generate one for each architecture in ARCHS.
2401
2402 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2403
2404         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2405         https://bugs.webkit.org/show_bug.cgi?id=190429
2406
2407         Reviewed by Saam Barati.
2408
2409         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2410
2411         * WebView/WebPDFRepresentation.mm:
2412         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2413
2414 2018-10-08  Justin Fan  <justin_fan@apple.com>
2415
2416         WebGPU: Rename old WebGPU prototype to WebMetal
2417         https://bugs.webkit.org/show_bug.cgi?id=190325
2418         <rdar://problem/44990443>
2419
2420         Reviewed by Dean Jackson.
2421
2422         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2423
2424         * Configurations/FeatureDefines.xcconfig:
2425         * WebView/WebPreferenceKeysPrivate.h:
2426         * WebView/WebPreferences.mm:
2427         (+[WebPreferences initialize]):
2428         (-[WebPreferences webMetalEnabled]):
2429         (-[WebPreferences setWebMetalEnabled:]):
2430         (-[WebPreferences webGPUEnabled]): Deleted.
2431         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2432         * WebView/WebPreferencesPrivate.h:
2433         * WebView/WebView.mm:
2434         (-[WebView _preferencesChanged:]):
2435
2436 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2437
2438         Make <input type=color> a runtime enabled (on-by-default) feature
2439         https://bugs.webkit.org/show_bug.cgi?id=189162
2440
2441         Reviewed by Wenson Hsieh and Tim Horton.
2442
2443         * Configurations/FeatureDefines.xcconfig:
2444
2445 2018-10-07  Dan Bernstein  <mitz@apple.com>
2446
2447         Fixed building with the latest macOS SDK
2448
2449         * Plugins/WebNetscapePluginPackage.mm:
2450         (-[WebNetscapePluginPackage openResourceFile]):
2451         (-[WebNetscapePluginPackage closeResourceFile:]):
2452
2453 2018-10-04  Dan Bernstein  <mitz@apple.com>
2454
2455         More Carbon build-fixing.
2456
2457         * Carbon/CarbonWindowAdapter.mm:
2458         (-[CarbonWindowAdapter _destroyRealWindow:]):
2459         (-[CarbonWindowAdapter _growBoxRect]):
2460
2461 2018-10-04  Dan Bernstein  <mitz@apple.com>
2462
2463         Retried to fix 32-bit macOS builds after r236846.
2464
2465         * WebView/WebHTMLView.mm:
2466         (-[WebHTMLView setMarkedText:selectedRange:]):
2467
2468 2018-10-04  Dan Bernstein  <mitz@apple.com>
2469
2470         Retried to fix 32-bit macOS builds after r236846.
2471
2472         * Carbon/HIWebView.mm:
2473         (ActiveStateChanged):
2474
2475 2018-10-04  Dan Bernstein  <mitz@apple.com>
2476
2477         Tried to fix 32-bit macOS builds after r236846.
2478
2479         * Carbon/HIWebView.mm:
2480         (_NSSelectorForHICommand):
2481
2482 2018-10-04  Dan Bernstein  <mitz@apple.com>
2483
2484         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2485         https://bugs.webkit.org/show_bug.cgi?id=190250
2486
2487         Reviewed by Andy Estes.
2488
2489         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2490           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2491           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2492           an earlier line set it to YES.
2493
2494         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2495         changes below.
2496
2497         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2498           provides some missing method declarations.
2499
2500         * Misc/WebDownload.mm:
2501         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2502           a deprecated method.
2503
2504         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2505
2506         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2507           other code in the file uses a method from it.
2508
2509         * Plugins/WebBaseNetscapePluginView.mm:
2510         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2511           a deprecated method.
2512
2513         * Plugins/WebPluginController.mm:
2514         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2515           around use of a selector that may be present in some WebKit client.
2516
2517         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2518           method declarations.
2519
2520         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2521           from here.
2522
2523         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2524           missing method declarations.
2525
2526         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2527           from here.
2528
2529         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2530           call from here.
2531         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2532           an obsolete delegate method for binary compatibility.
2533         (pluginView): Ditto.
2534
2535         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2536           call from here.
2537
2538         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2539           WebDeviceOrientationProviderMock protocol.
2540
2541         * WebView/WebDeviceOrientationProviderMock.mm:
2542         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2543           main @implementation.
2544
2545         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2546           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2547
2548         * WebView/WebDynamicScrollBarsView.mm:
2549         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2550           of a deprecated method.
2551
2552         * WebView/WebHTMLView.mm:
2553         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2554           selector warning around action methods that are not declared anywhere in WebKit.
2555
2556         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2557           about implementing this deprecated method.
2558         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2559         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2560         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2561         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2562         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2563         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2564         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2565         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2566         (-[WebHTMLView doCommandBySelector:]): Ditto.
2567         (-[WebHTMLView insertText:]): Ditto.
2568
2569         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2570
2571         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2572
2573         * WebView/WebPDFView.h: Removed previewView ivar.
2574
2575         * WebView/WebPDFView.mm:
2576           Removed declaration of FileInternal category and merged its implementation with the main
2577           implementation.
2578         (-[WebPDFView dealloc]): Removed previewView ivar.
2579         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2580           exist in macOS versions we support.
2581         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2582         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2583           action methods internal to PDFKit.
2584         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2585         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2586
2587         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2588           call on macOS, even though in r86988 we started calling different methods on iOS.
2589
2590         * WebView/WebView.mm:
2591         - Imported headers that declare delegate methods that we call.
2592         - Removed declaration of WebFileInternal category and merged its implementation with the
2593           main implementation.
2594         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2595           category, which made them impossible to call from the main implementation. Moved those
2596           into the main implementation. One of those had to be declared in a class extension,
2597           because it is called from a method implemented in the WebPrivate category, and that
2598           category’s implementation appears first in the file.
2599
2600         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2601           around use of obsolete delegate method for binary compatibility.
2602
2603         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2604
2605 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2606
2607         Runtime flag and IDL for MediaRecorder
2608         https://bugs.webkit.org/show_bug.cgi?id=190018
2609
2610         Reviewed by Youenn Fablet and Chris Dumez.
2611
2612         * WebView/WebPreferenceKeysPrivate.h:
2613         * WebView/WebPreferences.mm:
2614         (+[WebPreferences initialize]):
2615         (-[WebPreferences mediaRecorderEnabled]):
2616         (-[WebPreferences setMediaRecorderEnabled:]):
2617         * WebView/WebPreferencesPrivate.h:
2618         * WebView/WebView.mm:
2619         (-[WebView _preferencesChanged:]):
2620
2621 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2622
2623         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2624         https://bugs.webkit.org/show_bug.cgi?id=190238
2625
2626         Reviewed by Antti Koivisto.
2627
2628         Enabled the feature by default.
2629
2630         * WebView/WebPreferences.mm:
2631         (+[WebPreferences initialize]):
2632
2633 2018-10-01  Dean Jackson  <dino@apple.com>
2634
2635         [macOS] Switching to discrete GPU should be done in the UI process
2636         https://bugs.webkit.org/show_bug.cgi?id=189361
2637         <rdar://problem/43949622>
2638
2639         Reviewed by Simon Fraser.
2640
2641         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2642         not support swapping to the discrete GPU in this configuration.
2643
2644         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2645         (WebKit::WebSwitchingGPUClient::singleton):
2646         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2647         * WebView/WebView.mm:
2648         (-[WebView _commonInitializationWithFrameName:groupName:]):
2649
2650 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2651
2652         Remove ParsedURLString
2653         https://bugs.webkit.org/show_bug.cgi?id=190154
2654
2655         Reviewed by Chris Dumez.
2656
2657         * WebView/WebScriptDebugger.mm:
2658         (toNSURL):
2659
2660 2018-10-01  Dean Jackson  <dino@apple.com>
2661
2662         Remove CSS Animation Triggers
2663         https://bugs.webkit.org/show_bug.cgi?id=190175
2664         <rdar://problem/44925626>
2665
2666         Reviewed by Simon Fraser.
2667
2668         * Configurations/FeatureDefines.xcconfig:
2669
2670 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2671
2672         Unreviewed, rolling out r236624 and r236671.
2673         https://bugs.webkit.org/show_bug.cgi?id=190207
2674
2675         The change in r236624 introduced crashes on the bots
2676         (Requested by ryanhaddad on #webkit).
2677
2678         Reverted changesets:
2679
2680         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2681         https://bugs.webkit.org/show_bug.cgi?id=188747
2682         https://trac.webkit.org/changeset/236624
2683
2684         "Unify implementation in VideoFullscreenInterfaceAVKit"
2685         https://bugs.webkit.org/show_bug.cgi?id=190091
2686         https://trac.webkit.org/changeset/236671
2687
2688 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2689
2690         URL should not use TextEncoding internally
2691         https://bugs.webkit.org/show_bug.cgi?id=190111
2692
2693         Reviewed by Andy Estes.
2694
2695         * Misc/WebNSURLExtras.mm:
2696
2697 2018-09-28  Jer Noble  <jer.noble@apple.com>
2698
2699         Refactoring: eliminate raw pointer usage in Fullscreen code
2700         https://bugs.webkit.org/show_bug.cgi?id=188747
2701         <rdar://problem/43541164>
2702
2703         Reviewed by Alex Christensen.
2704
2705         PlaybackSessionInterface no longer has an invalidate() method.
2706
2707         * WebView/WebView.mm:
2708         (-[WebView _clearPlaybackControlsManager]):
2709
2710 2018-09-28  Chris Dumez  <cdumez@apple.com>
2711
2712         Drop support for cross-origin-window-policy header
2713         https://bugs.webkit.org/show_bug.cgi?id=190081
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         * WebView/WebPreferenceKeysPrivate.h:
2718         * WebView/WebPreferences.mm:
2719         (+[WebPreferences initialize]):
2720         * WebView/WebPreferencesPrivate.h:
2721         * WebView/WebView.mm:
2722         (-[WebView _preferencesChanged:]):
2723
2724 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2725
2726         Rename createMarkup to serializePreservingVisualAppearance
2727         https://bugs.webkit.org/show_bug.cgi?id=190086
2728
2729         Reviewed by Wenson Hsieh.
2730
2731         * DOM/WebDOMOperations.mm:
2732         (-[DOMRange markupString]):
2733
2734 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2735
2736         Unreviewed, rolling out r236605.
2737         https://bugs.webkit.org/show_bug.cgi?id=190087
2738
2739         caused three API test timeouts (Requested by jernoble on
2740         #webkit).
2741
2742         Reverted changeset:
2743
2744         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2745         https://bugs.webkit.org/show_bug.cgi?id=188747
2746         https://trac.webkit.org/changeset/236605
2747
2748 2018-09-28  Jer Noble  <jer.noble@apple.com>
2749
2750         Refactoring: eliminate raw pointer usage in Fullscreen code
2751         https://bugs.webkit.org/show_bug.cgi?id=188747
2752         <rdar://problem/43541164>
2753
2754         Reviewed by Alex Christensen.
2755
2756         PlaybackSessionInterface no longer has an invalidate() method.
2757
2758         * WebView/WebView.mm:
2759         (-[WebView _clearPlaybackControlsManager]):
2760
2761 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         Use enum class in createMarkup arguments
2764         https://bugs.webkit.org/show_bug.cgi?id=190028
2765
2766         Reviewed by Wenson Hsieh.
2767
2768         * DOM/WebDOMOperations.mm:
2769         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2770         (-[DOMRange markupString]): Ditto.
2771
2772 2018-09-27  Antoine Quint  <graouts@apple.com>
2773
2774         [Web Animations] Turn Web Animations with CSS integration on
2775         https://bugs.webkit.org/show_bug.cgi?id=184819
2776         <rdar://problem/39597337>
2777
2778         Reviewed by Dean Jackson.
2779
2780         * WebView/WebPreferences.mm:
2781         (+[WebPreferences initialize]):
2782
2783 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2784
2785         Selection should work across shadow boundary when initiated by a mouse drag
2786         https://bugs.webkit.org/show_bug.cgi?id=151380
2787         <rdar://problem/24363872>
2788
2789         Reviewed by Wenson Hsieh.
2790
2791         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2792
2793         * WebView/WebPreferenceKeysPrivate.h:
2794         * WebView/WebPreferences.mm:
2795         (+[WebPreferences initialize]):
2796         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2797         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2798         * WebView/WebPreferencesPrivate.h:
2799         * WebView/WebView.mm:
2800         (-[WebView _preferencesChanged:]):
2801
2802 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2803
2804         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2805         https://bugs.webkit.org/show_bug.cgi?id=189918
2806         Work towards <rdar://problem/44648705>
2807
2808         Reviewed by Tim Horton.
2809
2810         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2811
2812         * WebView/WebHTMLView.mm:
2813         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2814         (-[WebHTMLView _updateFontPanel]):
2815         * WebView/WebView.mm:
2816         (-[WebView typingAttributes]):
2817
2818 2018-09-17  Darin Adler  <darin@apple.com>
2819
2820         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2821         https://bugs.webkit.org/show_bug.cgi?id=189652
2822
2823         Reviewed by Saam Barati.
2824
2825         * WebView/WebPDFRepresentation.mm:
2826         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2827
2828 2018-09-14  Jer Noble  <jer.noble@apple.com>
2829
2830         Turn SourceBufferChangeTypeEnabled on by default
2831         https://bugs.webkit.org/show_bug.cgi?id=189527
2832
2833         Reviewed by Eric Carlson.
2834
2835         * WebView/WebPreferences.mm:
2836         (+[WebPreferences initialize]):
2837
2838 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2839
2840         Fix an internal build after r235935
2841         https://bugs.webkit.org/show_bug.cgi?id=188996
2842
2843         * Carbon/HIWebView.mm:
2844         (Draw):
2845         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2846
2847 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2848
2849         Add IGNORE_WARNING_.* macros
2850         https://bugs.webkit.org/show_bug.cgi?id=188996
2851
2852         Reviewed by Michael Catanzaro.
2853
2854         * Carbon/CarbonUtils.m:
2855         (PoolCleaner):
2856         * Carbon/CarbonWindowAdapter.mm:
2857         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2858         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2859         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2860         (-[CarbonWindowAdapter _termWindowIfOwner]):
2861         (-[CarbonWindowAdapter _windowMovedToRect:]):
2862         (-[CarbonWindowAdapter setContentView:]):
2863         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2864         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2865         * Carbon/CarbonWindowFrame.m:
2866         (-[CarbonWindowFrame title]):
2867         * Carbon/HIViewAdapter.m:
2868         (+[HIViewAdapter getHIViewForNSView:]):
2869         * Carbon/HIWebView.mm:
2870         (overrideCGContext):
2871         (restoreCGContext):
2872         (Draw):
2873         * DOM/DOM.mm:
2874         * History/WebHistory.mm:
2875         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2876         * History/WebHistoryItem.mm:
2877         (-[WebHistoryItem icon]):
2878         * Misc/WebKitNSStringExtras.mm:
2879         (-[NSString _web_drawAtPoint:font:textColor:]):
2880         * Misc/WebNSImageExtras.m:
2881         (-[NSImage _web_scaleToMaxSize:]):
2882         (-[NSImage _web_dissolveToFraction:]):
2883         * Misc/WebNSPasteboardExtras.mm:
2884         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2885         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2886         * Panels/WebAuthenticationPanel.m:
2887         (-[WebAuthenticationPanel loadNib]):
2888         * Plugins/Hosted/NetscapePluginHostManager.mm:
2889         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2890         (WebKit::NetscapePluginHostManager::didCreateWindow):
2891         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2892         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2893         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2894         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2895         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2896         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2897         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2898         (-[WebHostedNetscapePluginView drawRect:]):
2899         * Plugins/Hosted/WebTextInputWindowController.m:
2900         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2901         * Plugins/WebBaseNetscapePluginView.mm:
2902         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2903         * Plugins/WebNetscapePluginPackage.mm:
2904         (-[WebNetscapePluginPackage _tryLoad]):
2905         * Plugins/WebNetscapePluginView.mm:
2906         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2907         (-[WebNetscapePluginView sendDrawRectEvent:]):
2908         (-[WebNetscapePluginView drawRect:]):
2909         * Plugins/WebPluginController.mm:
2910         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2911         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2912         * WebCoreSupport/PopupMenuMac.mm:
2913         (PopupMenuMac::populate):
2914         * WebCoreSupport/WebAlternativeTextClient.h:
2915         * WebCoreSupport/WebDragClient.mm:
2916         (WebDragClient::startDrag):
2917         * WebCoreSupport/WebFrameLoaderClient.mm:
2918         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2919         (webGetNSImage):
2920         * WebInspector/WebNodeHighlight.mm:
2921         * WebInspector/WebNodeHighlightView.mm:
2922         (-[WebNodeHighlightView drawRect:]):
2923         * WebView/WebClipView.mm:
2924         (-[WebClipView initWithFrame:]):
2925         * WebView/WebFrame.mm:
2926         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2927         (-[WebFrame _drawRect:contentsOnly:]):
2928         (-[WebFrame accessibilityRoot]):
2929         * WebView/WebFullScreenController.mm:
2930         (-[WebFullScreenController enterFullScreen:]):
2931         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2932         (-[WebFullScreenController exitFullScreen]):
2933         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2934         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2935         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2936         * WebView/WebHTMLView.mm:
2937         (-[NSWindow _web_borderView]):
2938         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2939         (-[WebHTMLView _setAsideSubviews]):
2940         (-[WebHTMLView _autoscroll]):
2941         (-[WebHTMLView drawRect:]):
2942         (-[WebHTMLView mouseDown:]):
2943         (-[WebHTMLView mouseDragged:]):
2944         (-[WebHTMLView mouseUp:]):
2945         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2946         (-[WebHTMLView knowsPageRange:]):
2947         (-[WebHTMLView accessibilityHitTest:]):
2948         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2949         (-[WebHTMLView _colorAsString:]):
2950         (-[WebHTMLView copyFont:]):
2951         (-[WebHTMLView _executeSavedKeypressCommands]):
2952         (-[WebHTMLView attachRootLayer:]):
2953         (-[WebHTMLView textStorage]):
2954         (-[WebHTMLView _updateSelectionForInputManager]):
2955         * WebView/WebPDFView.mm:
2956         (_applicationInfoForMIMEType):
2957         (-[WebPDFView centerSelectionInVisibleArea:]):
2958         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2959         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2960         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2961         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2962         * WebView/WebTextCompletionController.mm:
2963         (-[WebTextCompletionController _buildUI]):
2964         (-[WebTextCompletionController _placePopupWindow:]):
2965         * WebView/WebVideoFullscreenController.mm:
2966         * WebView/WebVideoFullscreenHUDWindowController.mm:
2967         (createMediaUIBackgroundView):
2968         * WebView/WebView.mm:
2969         (-[WebTextListTouchBarViewController initWithWebView:]):
2970         (-[WebView _dispatchTileDidDraw:]):
2971         (-[WebView encodeWithCoder:]):
2972         (-[WebView mainFrameIcon]):
2973         (LayerFlushController::flushLayers):
2974         * WebView/WebWindowAnimation.mm:
2975         (setScaledFrameForWindow):
2976
2977 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2978
2979         Remove unused needsDestruction class variables from HashTraits
2980         https://bugs.webkit.org/show_bug.cgi?id=189490
2981
2982         Reviewed by Daniel Bates.
2983
2984         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2985
2986 2018-09-07  Frederic Wang  <fwang@igalia.com>
2987
2988         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2989         https://bugs.webkit.org/show_bug.cgi?id=182230
2990
2991         Reviewed by Simon Fraser.
2992
2993         * DOM/DOMDocument.mm:
2994         (-[DOMDocument scrollingElement]): Use the new name.
2995
2996 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2997
2998         Refactor WebCore::EditAction to be an 8-bit enum class
2999         https://bugs.webkit.org/show_bug.cgi?id=189383
3000
3001         Reviewed by Dan Bernstein.
3002
3003         * WebCoreSupport/WebEditorClient.mm:
3004         (undoNameForEditAction):
3005         * WebView/WebHTMLView.mm:
3006         (-[WebHTMLView pasteFont:]):
3007         (-[WebHTMLView changeFont:]):
3008         (-[WebHTMLView changeAttributes:]):
3009         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3010         (-[WebHTMLView changeColor:]):
3011         * WebView/WebView.mm:
3012         (-[WebView setTypingStyle:]):
3013
3014 2018-09-06  Frederic Wang  <fwang@igalia.com>
3015
3016         Group options of scrollRectToVisible into a struct
3017         https://bugs.webkit.org/show_bug.cgi?id=189352
3018
3019         Reviewed by Simon Fraser.
3020
3021         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3022         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3023         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3024
3025 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3026
3027         [macOS] Cannot change font size at selection until font panel is shown
3028         https://bugs.webkit.org/show_bug.cgi?id=189295
3029         <rdar://problem/35593389>
3030
3031         Reviewed by Ryosuke Niwa.
3032
3033         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3034         WebCore ChangeLog for more details.
3035
3036         * WebView/WebHTMLView.mm:
3037         (-[WebHTMLView changeFont:]):
3038         (-[WebHTMLView changeAttributes:]):
3039         (-[WebHTMLView _originalFontA]): Deleted.
3040         (-[WebHTMLView _originalFontB]): Deleted.
3041         (fontNameForDescription): Deleted.
3042         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3043         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3044         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3045
3046 2018-09-05  Jer Noble  <jer.noble@apple.com>
3047
3048         Add MediaCapabilities as an Experimental Feature
3049         https://bugs.webkit.org/show_bug.cgi?id=189209
3050
3051         Reviewed by Eric Carlson.
3052
3053         RuntimeEnabledFeature -> Setting.
3054
3055         * WebView/WebView.mm:
3056         (-[WebView _preferencesChanged:]):
3057
3058 2018-09-04  Frederic Wang  <fwang@igalia.com>
3059
3060         Add basic support for ScrollIntoViewOptions
3061         https://bugs.webkit.org/show_bug.cgi?id=189258
3062
3063         Reviewed by Simon Fraser.
3064
3065         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3066         header so that this file can build despite the new scrollIntoView function.
3067
3068 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3069
3070         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3071         https://bugs.webkit.org/show_bug.cgi?id=188890
3072         <rdar://problem/43648605>
3073
3074         Reviewed by Tim Horton.
3075
3076         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3077         more detail.
3078
3079         * WebCoreSupport/WebPlatformStrategies.h:
3080         * WebCoreSupport/WebPlatformStrategies.mm:
3081         (WebPlatformStrategies::allStringsForType):
3082
3083 2018-09-01  Darin Adler  <darin@apple.com>
3084
3085         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3086         https://bugs.webkit.org/show_bug.cgi?id=189072
3087         Reviewed by Dan Bernstein.
3088
3089         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3090         and declarations for NSURLDownload init methods.
3091
3092         * Misc/WebDownloadInternal.h: Removed.
3093
3094         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3095         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3096         "-Wdeprecated-declarations" because the method used here is deprecated.
3097
3098         * WebView/WebView.mm:
3099         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3100         used here is deprecated.
3101
3102 2018-08-31  Chris Dumez  <cdumez@apple.com>
3103
3104         Assertion hit in ~CompletionHandler() from ~WebFrame()
3105         https://bugs.webkit.org/show_bug.cgi?id=189199
3106         <rdar://problem/42657233>
3107
3108         Reviewed by Youenn Fablet.
3109
3110         * WebCoreSupport/WebFrameLoaderClient.h:
3111         * WebCoreSupport/WebFrameLoaderClient.mm:
3112         (WebFrameLoaderClient::dispatchWillSubmitForm):
3113
3114 2018-08-31  Antti Koivisto  <antti@apple.com>
3115
3116         Replace OptionSet |= and -= operators with add() and remove() functions
3117         https://bugs.webkit.org/show_bug.cgi?id=189169
3118
3119         Reviewed by Anders Carlsson.
3120
3121         * WebView/WebFrame.mm:
3122         (-[WebFrame _drawRect:contentsOnly:]):
3123         * WebView/WebView.mm:
3124         (coreOptions):
3125
3126 2018-08-31  Frederic Wang  <fwang@igalia.com>
3127
3128         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3129         https://bugs.webkit.org/show_bug.cgi?id=182053
3130
3131         Reviewed by Simon Fraser.
3132
3133         Add developer flag to use standard behavior for scrolling* attributes.
3134
3135         * WebView/WebPreferenceKeysPrivate.h:
3136         * WebView/WebPreferences.mm:
3137         (+[WebPreferences initialize]):
3138         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3139         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3140         * WebView/WebPreferencesPrivate.h:
3141         * WebView/WebView.mm:
3142         (-[WebView _preferencesChanged:]):
3143
3144 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3145
3146         Implement the Web Share API
3147         https://bugs.webkit.org/show_bug.cgi?id=171100
3148         <rdar://problem/31751734>
3149
3150         Reviewed by Tim Horton.
3151
3152         * WebCoreSupport/WebChromeClient.h:
3153         * WebCoreSupport/WebChromeClient.mm:
3154         (WebChromeClient::showShareSheet):
3155         Empty declaration of showShareSheet.
3156
3157 2018-08-29  Youenn Fablet  <youenn@apple.com>
3158
3159         Remove WebRTC legacy API implementation
3160         https://bugs.webkit.org/show_bug.cgi?id=189040
3161
3162         Reviewed by Eric Carlson.
3163
3164         * WebView/WebPreferenceKeysPrivate.h:
3165         * WebView/WebPreferences.mm:
3166         (+[WebPreferences initialize]):
3167         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3168         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3169         * WebView/WebPreferencesPrivate.h:
3170         * WebView/WebView.mm:
3171         (-[WebView _preferencesChanged:]):
3172
3173 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3174
3175         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3176         https://bugs.webkit.org/show_bug.cgi?id=189054
3177
3178         Reviewed by Andy Estes.
3179
3180         Remove the pasteboard type argument from readURLFromPasteboard.
3181
3182         * WebCoreSupport/WebPlatformStrategies.h:
3183         * WebCoreSupport/WebPlatformStrategies.mm:
3184         (WebPlatformStrategies::readURLFromPasteboard):
3185
3186 2018-08-27  Keith Rollin  <krollin@apple.com>
3187
3188         Unreviewed build fix -- disable LTO for production builds
3189
3190         * Configurations/Base.xcconfig:
3191
3192 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3193
3194         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3195         https://bugs.webkit.org/show_bug.cgi?id=188931
3196
3197         Reviewed by Wenson Hsieh.
3198
3199         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3200
3201 2018-08-27  Keith Rollin  <krollin@apple.com>
3202
3203         Build system support for LTO
3204         https://bugs.webkit.org/show_bug.cgi?id=187785
3205         <rdar://problem/42353132>
3206
3207         Reviewed by Dan Bernstein.
3208
3209         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3210         LTO.
3211
3212         * Configurations/Base.xcconfig:
3213         * Configurations/DebugRelease.xcconfig:
3214
3215 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3216
3217         Pass in IsComposed flag to Event constructors
3218         https://bugs.webkit.org/show_bug.cgi?id=188720
3219         <rdar://problem/43580387>
3220
3221         Reviewed by Simon Fraser.
3222
3223         * WebView/WebPDFView.mm:
3224         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3225         whether it's simulated or not.
3226
3227 2018-08-23  Mark Lam  <mark.lam@apple.com>
3228
3229         Move vmEntryGlobalObject() to VM from CallFrame.
3230         https://bugs.webkit.org/show_bug.cgi?id=188900
3231         <rdar://problem/43655753>
3232
3233         Reviewed by Michael Saboff.
3234
3235         * WebView/WebScriptDebugger.mm:
3236         (WebScriptDebugger::sourceParsed):
3237
3238 2018-08-23  Andy Estes  <aestes@apple.com>
3239
3240         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3241         https://bugs.webkit.org/show_bug.cgi?id=188829
3242
3243         Reviewed by Tim Horton.
3244
3245         * Configurations/FeatureDefines.xcconfig:
3246
3247 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3248
3249         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3250         https://bugs.webkit.org/show_bug.cgi?id=188777
3251
3252         Reviewed by Simon Fraser.
3253
3254         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3255         being "true" before the code change.
3256
3257         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3258
3259         * WebView/WebPDFView.mm:
3260         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3261
3262 2018-08-21  Daniel Bates  <dabates@apple.com>
3263
3264         Replace TextCheckingTypeMask with OptionSet
3265         https://bugs.webkit.org/show_bug.cgi?id=188678
3266
3267         Reviewed by Antti Koivisto.
3268
3269         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3270         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3271         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3272         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3273
3274         * WebCoreSupport/WebEditorClient.h:
3275         * WebCoreSupport/WebEditorClient.mm:
3276         (WebEditorClient::checkTextOfParagraph):
3277         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3278         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3279         left as this is more readable and unncessary now that modern compilers like Clang have
3280         diagnostics to catch accidental assignments when equality was intended.
3281         (WebEditorClient::didCheckSucceed):
3282         * WebView/WebView.mm:
3283         (coreTextCheckingType):
3284         (textCheckingResultFromNSTextCheckingResult):
3285
3286 2018-08-21  Daniel Bates  <dabates@apple.com>
3287
3288         [iOS][WK1] Support toggling continuous spell checking from tests
3289         https://bugs.webkit.org/show_bug.cgi?id=188763
3290
3291         Reviewed by Simon Fraser.
3292
3293         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3294         spell checking from tests in iOS WebKit Legacy.
3295
3296         * WebCoreSupport/WebEditorClient.h:
3297         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3298         * WebCoreSupport/WebEditorClient.mm:
3299         * WebView/WebView.h:
3300         * WebView/WebView.mm:
3301         (-[WebView toggleContinuousSpellChecking:]):
3302         (-[WebView toggleSmartInsertDelete:]):
3303
3304 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3305
3306         Add some plumbing for safe browsing
3307         https://bugs.webkit.org/show_bug.cgi?id=188709
3308
3309         Reviewed by Tim Horton.
3310
3311         * WebCoreSupport/WebFrameLoaderClient.h:
3312         * WebCoreSupport/WebFrameLoaderClient.mm:
3313         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3314
3315 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3316
3317         Replace canBubble and cancelable booleans in Event by enum classes
3318         https://bugs.webkit.org/show_bug.cgi?id=188692
3319
3320         Reviewed by Alex Christensen.
3321
3322         * WebView/WebPDFView.mm:
3323         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3324         * WebView/WebView.mm:
3325         (-[WebView _dispatchUnloadEvent]):
3326
3327 2018-08-16  Jer Noble  <jer.noble@apple.com>
3328
3329         Add Experimental Feature support for SourceBuffer.changeType()
3330         https://bugs.webkit.org/show_bug.cgi?id=188626
3331         <rdar://problem/43356021>
3332
3333         Reviewed by Eric Carlson.
3334
3335         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3336
3337         * WebView/WebPreferenceKeysPrivate.h:
3338         * WebView/WebPreferences.mm:
3339         (+[WebPreferences initialize]):
3340         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3341         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3342         * WebView/WebPreferencesPrivate.h:
3343         * WebView/WebView.mm:
3344         (-[WebView _preferencesChanged:]):
3345
3346 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3347
3348         Support drag-and-drop for input[type=color]
3349         https://bugs.webkit.org/show_bug.cgi?id=188464
3350
3351         Reviewed by Wenson Hsieh.
3352
3353         * WebCoreSupport/WebPlatformStrategies.h:
3354         * WebCoreSupport/WebPlatformStrategies.mm:
3355         (WebPlatformStrategies::setColor):
3356
3357 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3358
3359         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3360         https://bugs.webkit.org/show_bug.cgi?id=188569
3361         <rdar://problem/34201095>
3362
3363         Reviewed by Megan Gardner.
3364
3365         * WebView/WebImmediateActionController.mm:
3366         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3367         Speculative fix; the crashes indicate font is null, but we just checked it,
3368         so it must be getting made null by convertFont:toSize:. Check again!
3369
3370 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3371
3372         Use a 1-byte enum class for TextDirection
3373         https://bugs.webkit.org/show_bug.cgi?id=188350
3374
3375         Reviewed by Simon Fraser.
3376
3377         * WebCoreSupport/PopupMenuMac.mm:
3378         (PopupMenuMac::populate):
3379         (PopupMenuMac::show):
3380         * WebCoreSupport/WebFrameLoaderClient.mm:
3381         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3382         * WebView/WebFrame.mm:
3383         (-[WebFrame _dispatchDidReceiveTitle:]):
3384
3385 2018-08-09  Ali Juma  <ajuma@chromium.org>
3386
3387         Import WPTs for IntersectionObserver
3388         https://bugs.webkit.org/show_bug.cgi?id=188416
3389
3390         Reviewed by Simon Fraser.
3391
3392         * WebView/WebPreferencesPrivate.h:
3393
3394 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3395
3396         Follow-up build fix for r234685
3397         https://bugs.webkit.org/show_bug.cgi?id=188245
3398
3399         Unreviewed build fix.
3400
3401         * WebCoreSupport/WebSecurityOriginPrivate.h:
3402
3403 2018-08-05  Darin Adler  <darin@apple.com>
3404
3405         [Cocoa] More tweaks and refactoring to prepare for ARC
3406         https://bugs.webkit.org/show_bug.cgi?id=188245
3407
3408         Reviewed by Dan Bernstein.
3409
3410         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3411
3412         * Carbon/CarbonWindowFrame.m:
3413         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3414
3415         * DOM/DOM.mm:
3416         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3417         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3418         garbage collection so this method isn't useful.
3419
3420         * DOM/DOMXPath.mm:
3421         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3422         Objective-C garbage collection so this method isn't useful.
3423
3424         * History/WebHistory.mm:
3425         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3426
3427         * Misc/WebElementDictionary.mm:
3428         (addLookupKey): Use a bridging cast.
3429         (cacheValueForKey): Ditto.
3430         (-[WebElementDictionary _fillCache]): Ditto.
3431         (-[WebElementDictionary objectForKey:]): Ditto.
3432
3433         * Misc/WebKitNSStringExtras.mm:
3434         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3435         (-[NSString _web_widthWithFont:]): Ditto.
3436         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3437
3438         * Misc/WebLocalizableStrings.mm:
3439         (WebLocalizedString): Use a bridging cast.
3440
3441         * Misc/WebNSDataExtras.mm:
3442         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3443         and use CFBridgingRelease instead of calling autorelease directly.
3444         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3445         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3446         on the amount of explicit release and autorelease.
3447
3448         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3449         * Misc/WebNSDictionaryExtras.m:
3450         (-[NSDictionary _webkit_intForKey:]): Deleted.
3451         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3452         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3453         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3454         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3455         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3456         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3457
3458         * Misc/WebStringTruncator.mm:
3459         (fontFromNSFont): Use a bridging cast.
3460
3461         * Plugins/Hosted/NetscapePluginHostManager.mm:
3462         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3463
3464         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3465         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3466         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3467         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3468         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3469         * Plugins/Hosted/ProxyInstance.mm:
3470         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3471         * Plugins/WebBasePluginPackage.mm:
3472         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3473         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3474         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3475         * Plugins/WebNetscapePluginPackage.mm:
3476         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3477
3478         * Plugins/WebNetscapePluginView.mm:
3479         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3480         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3481         (-[WebNetscapePluginView status:]): Use a bridging cast.
3482         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3483
3484         * Plugins/WebPluginController.mm:
3485         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3486
3487         * Plugins/WebPluginDatabase.mm:
3488         (checkCandidate): Use explicit __strong for out argument types.
3489
3490         * Plugins/npapi.mm:
3491         (pluginViewForInstance): Use a bridging cast.
3492
3493         * Storage/WebDatabaseManager.mm:
3494         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3495         explicit NSNumber and NSDictionary calls.
3496
3497         * WebCoreSupport/WebContextMenuClient.mm:
3498         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3499
3500         * WebCoreSupport/WebEditorClient.mm:
3501         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3502         (WebEditorClient::handleInputMethodKeydown): Ditto.
3503
3504         * WebCoreSupport/WebFrameNetworkingContext.mm:
3505         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3506
3507         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3508         as a struct rather than an Objective-C class, since that's how it's defined.
3509
3510         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3511
3512         * WebView/WebFullScreenController.mm:
3513         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3514         * WebView/WebHTMLView.mm:
3515         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3516         Ditto.
3517         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3518
3519         * WebView/WebImmediateActionController.mm:
3520         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3521         go down to the document and then back to the frame.
3522         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3523         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3524         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3525
3526         * WebView/WebJSPDFDoc.mm:
3527         (jsPDFDocInitialize): Removed some unneeded type casting.
3528         (jsPDFDocFinalize): Ditto.
3529         (jsPDFDocPrint): Use a bridging cast.
3530
3531         * WebView/WebPDFView.mm:
3532         (_applicationInfoForMIMEType): Use bridging casts.
3533
3534         * WebView/WebPreferences.mm:
3535         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3536         instead of methods from WebNSDictionaryExtras.
3537         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3538         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3539         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3540         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3541         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3542
3543         * WebView/WebView.mm:
3544         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3545         (-[WebView _addToAllWebViewsSet]): Ditto.
3546         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3547         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3548         so it can be called from WebViewData methods.
3549
3550         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3551         method, _windowVisibilityChanged:.
3552
3553         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3554         called from WebViewData methods.
3555
3556 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3557
3558         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3559         https://bugs.webkit.org/show_bug.cgi?id=188323
3560
3561         Reviewed by Simon Fraser.
3562
3563         * WebCoreSupport/WebContextMenuClient.mm:
3564         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3565         * WebView/WebFrame.mm:
3566         (-[WebFrame _paintBehaviorForDestinationContext:]):
3567         (-[WebFrame _drawRect:contentsOnly:]):
3568         * WebView/WebHTMLView.mm:
3569         (imageFromRect):
3570         (selectionImage):
3571
3572 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3573
3574         Add support for microtasks in workers
3575         https://bugs.webkit.org/show_bug.cgi?id=188246
3576
3577         Reviewed by Darin Adler.
3578
3579         Rename JSMainThreadExecState.h to JSExecState.h.
3580
3581         * DOM/DOMAttr.mm:
3582         * DOM/DOMBlob.mm:
3583         * DOM/DOMCDATASection.mm:
3584         * DOM/DOMCSSCharsetRule.mm:
3585         * DOM/DOMCSSFontFaceRule.mm:
3586         * DOM/DOMCSSImportRule.mm:
3587         * DOM/DOMCSSMediaRule.mm:
3588         * DOM/DOMCSSPageRule.mm:
3589         * DOM/DOMCSSPrimitiveValue.mm:
3590         * DOM/DOMCSSRule.mm:
3591         * DOM/DOMCSSRuleList.mm:
3592         * DOM/DOMCSSStyleDeclaration.mm:
3593         * DOM/DOMCSSStyleRule.mm:
3594         * DOM/DOMCSSStyleSheet.mm:
3595         * DOM/DOMCSSUnknownRule.mm:
3596         * DOM/DOMCSSValue.mm:
3597         * DOM/DOMCSSValueList.mm:
3598         * DOM/DOMCharacterData.mm:
3599         * DOM/DOMComment.mm:
3600         * DOM/DOMCounter.mm:
3601         * DOM/DOMDocument.mm:
3602         * DOM/DOMDocumentFragment.mm:
3603         * DOM/DOMDocumentType.mm:
3604         * DOM/DOMElement.mm:
3605         * DOM/DOMEvent.mm:
3606         * DOM/DOMFile.mm:
3607         * DOM/DOMFileList.mm:
3608         * DOM/DOMHTML.mm:
3609         * DOM/DOMHTMLAnchorElement.mm:
3610         * DOM/DOMHTMLAppletElement.mm:
3611         * DOM/DOMHTMLAreaElement.mm:
3612         * DOM/DOMHTMLBRElement.mm:
3613         * DOM/DOMHTMLBaseElement.mm:
3614         * DOM/DOMHTMLBaseFontElement.mm:
3615         * DOM/DOMHTMLBodyElement.mm:
3616         * DOM/DOMHTMLButtonElement.mm:
3617         * DOM/DOMHTMLCanvasElement.mm:
3618         * DOM/DOMHTMLCollection.mm:
3619         * DOM/DOMHTMLDListElement.mm:
3620         * DOM/DOMHTMLDirectoryElement.mm:
3621         * DOM/DOMHTMLDivElement.mm:
3622         * DOM/DOMHTMLDocument.mm:
3623         * DOM/DOMHTMLElement.mm:
3624         * DOM/DOMHTMLEmbedElement.mm:
3625         * DOM/DOMHTMLFieldSetElement.mm:
3626         * DOM/DOMHTMLFontElement.mm:
3627         * DOM/DOMHTMLFormElement.mm:
3628         * DOM/DOMHTMLFrameElement.mm:
3629         * DOM/DOMHTMLFrameSetElement.mm:
3630         * DOM/DOMHTMLHRElement.mm:
3631         * DOM/DOMHTMLHeadElement.mm:
3632         * DOM/DOMHTMLHeadingElement.mm:
3633         * DOM/DOMHTMLHtmlElement.mm:
3634         * DOM/DOMHTMLIFrameElement.mm:
3635         * DOM/DOMHTMLImageElement.mm:
3636         * DOM/DOMHTMLInputElement.mm:
3637         * DOM/DOMHTMLLIElement.mm:
3638         * DOM/DOMHTMLLabelElement.mm:
3639         * DOM/DOMHTMLLegendElement.mm:
3640         * DOM/DOMHTMLLinkElement.mm:
3641         * DOM/DOMHTMLMapElement.mm:
3642         * DOM/DOMHTMLMarqueeElement.mm:
3643         * DOM/DOMHTMLMediaElement.mm:
3644         * DOM/DOMHTMLMenuElement.mm:
3645         * DOM/DOMHTMLMetaElement.mm:
3646         * DOM/DOMHTMLModElement.mm:
3647         * DOM/DOMHTMLOListElement.mm:
3648         * DOM/DOMHTMLObjectElement.mm:
3649         * DOM/DOMHTMLOptGroupElement.mm:
3650         * DOM/DOMHTMLOptionElement.mm:
3651         * DOM/DOMHTMLOptionsCollection.mm:
3652         * DOM/DOMHTMLParagraphElement.mm:
3653         * DOM/DOMHTMLParamElement.mm:
3654         * DOM/DOMHTMLPreElement.mm:
3655         * DOM/DOMHTMLQuoteElement.mm:
3656         * DOM/DOMHTMLScriptElement.mm:
3657         * DOM/DOMHTMLSelectElement.mm:
3658         * DOM/DOMHTMLStyleElement.mm:
3659         * DOM/DOMHTMLTableCaptionElement.mm:
3660         * DOM/DOMHTMLTableCellElement.mm:
3661         * DOM/DOMHTMLTableColElement.mm:
3662         * DOM/DOMHTMLTableElement.mm:
3663         * DOM/DOMHTMLTableRowElement.mm:
3664         * DOM/DOMHTMLTableSectionElement.mm:
3665         * DOM/DOMHTMLTextAreaElement.mm:
3666         * DOM/DOMHTMLTitleElement.mm:
3667         * DOM/DOMHTMLUListElement.mm:
3668         * DOM/DOMHTMLVideoElement.mm:
3669         * DOM/DOMImplementation.mm:
3670         * DOM/DOMKeyboardEvent.mm:
3671         * DOM/DOMMediaError.mm:
3672         * DOM/DOMMediaList.mm:
3673         * DOM/DOMMouseEvent.mm:
3674         * DOM/DOMMutationEvent.mm:
3675         * DOM/DOMNamedNodeMap.mm:
3676         * DOM/DOMNode.mm:
3677         * DOM/DOMNodeIterator.mm:
3678         * DOM/DOMNodeList.mm:
3679         * DOM/DOMOverflowEvent.mm:
3680         * DOM/DOMProcessingInstruction.mm:
3681         * DOM/DOMProgressEvent.mm:
3682         * DOM/DOMRGBColor.mm:
3683         * DOM/DOMRange.mm:
3684         * DOM/DOMRect.mm:
3685         * DOM/DOMStyleSheet.mm:
3686         * DOM/DOMStyleSheetList.mm:
3687         * DOM/DOMText.mm:
3688         * DOM/DOMTextEvent.mm:
3689         * DOM/DOMTimeRanges.mm:
3690         * DOM/DOMTokenList.mm:
3691         * DOM/DOMTreeWalker.mm:
3692         * DOM/DOMUIEvent.mm:
3693         * DOM/DOMWheelEvent.mm:
3694         * DOM/DOMXPathExpression.mm:
3695         * DOM/DOMXPathResult.mm:
3696         * DOM/ObjCEventListener.mm:
3697
3698 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3699
3700         Fix spelling of "overridden"
3701         https://bugs.webkit.org/show_bug.cgi?id=188315
3702
3703         Reviewed by Darin Adler.
3704
3705         * Misc/WebKitVersionChecks.mm:
3706         (setWebKitLinkTimeVersion):
3707         (WebKitLinkTimeVersion):
3708         * Plugins/WebBaseNetscapePluginView.mm:
3709         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3710         * WebCoreSupport/PopupMenuMac.mm:
3711         (PopupMenuMac::populate):
3712
3713 2018-08-01  Nan Wang  <n_wang@apple.com>
3714
3715         AX: AOM: Add ARIA IDL Attribute Reflection
3716         https://bugs.webkit.org/show_bug.cgi?id=184676
3717         <rdar://problem/39476882>
3718
3719         Reviewed by Chris Fleizach.
3720
3721         * WebView/WebPreferenceKeysPrivate.h:
3722         * WebView/WebPreferences.mm:
3723         (+[WebPreferences initialize]):
3724         (-[WebPreferences ariaReflectionEnabled]):
3725         (-[WebPreferences setAriaReflectionEnabled:]):
3726         * WebView/WebPreferencesPrivate.h:
3727         * WebView/WebView.mm:
3728         (-[WebView _preferencesChanged:]):
3729
3730 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3731
3732         Shrink GraphicsLayerCA
3733         https://bugs.webkit.org/show_bug.cgi?id=188141
3734
3735         Reviewed by Zalan Bujtas.
3736
3737         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3738         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3739         * moving all the animation-related stuff into the lazily-allocated m_animations
3740         * making enums be 8-bit
3741         * re-ordering data members
3742
3743         * WebView/WebView.mm:
3744         (-[WebView _setMediaLayer:forPluginView:]):
3745
3746 2018-07-30  Rob Buis  <rbuis@igalia.com>
3747
3748         Merge PlatformCookieJar functions into NetworkStorageSession
3749         https://bugs.webkit.org/show_bug.cgi?id=188137
3750
3751         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3752
3753         Reviewed by Alex Christensen.
3754
3755         * WebCoreSupport/WebPlatformStrategies.mm:
3756         (WebPlatformStrategies::cookiesForDOM):
3757         (WebPlatformStrategies::setCookiesFromDOM):
3758         (WebPlatformStrategies::cookiesEnabled):
3759         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3760         (WebPlatformStrategies::getRawCookies):
3761         (WebPlatformStrategies::deleteCookie):
3762         * WebView/WebPreferences.mm:
3763         (+[WebPreferences _clearNetworkLoaderSession]):
3764
3765 2018-07-28  Darin Adler  <darin@apple.com>
3766
3767         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3768         https://bugs.webkit.org/show_bug.cgi?id=188140
3769
3770         Reviewed by Sam Weinig.
3771
3772         * WebView/WebImmediateActionController.mm:
3773         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3774         new DictionaryLookup function that returns a tuple instead of using an out argument.
3775
3776 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3777
3778         [INTL] Remove INTL sub-feature compile flags
3779         https://bugs.webkit.org/show_bug.cgi?id=188081
3780
3781         Reviewed by Michael Catanzaro.
3782
3783         * Configurations/FeatureDefines.xcconfig:
3784
3785 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3786
3787         Unreviewed, rolling out r234181 and r234189.
3788         https://bugs.webkit.org/show_bug.cgi?id=188075
3789
3790         These are not needed right now (Requested by thorton on
3791         #webkit).
3792
3793         Reverted changesets:
3794
3795         "Enable Web Content Filtering on watchOS"
3796         https://bugs.webkit.org/show_bug.cgi?id=187979
3797         https://trac.webkit.org/changeset/234181
3798
3799         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3800         https://bugs.webkit.org/show_bug.cgi?id=187985
3801         https://trac.webkit.org/changeset/234189
3802
3803 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3804
3805         Use the Page's appearance when converting pasteboard attributed strings.
3806         https://bugs.webkit.org/show_bug.cgi?id=188067
3807         rdar://problem/42632246
3808
3809         Reviewed by Wenson Hsieh.
3810
3811         * WebCoreSupport/WebEditorClient.mm:
3812         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3813
3814 2018-07-25  Chris Dumez  <cdumez@apple.com>
3815
3816         navigator.userAgent may return outdated value after webView.customUserAgent is set
3817         https://bugs.webkit.org/show_bug.cgi?id=188009
3818         <rdar://problem/42566456>
3819
3820         Reviewed by Alex Christensen.
3821
3822         Let the page know when the user agent changes.
3823
3824         * WebView/WebView.mm:
3825         (-[WebView _preferencesChanged:]):
3826         (-[WebView setApplicationNameForUserAgent:]):
3827         (-[WebView _invalidateUserAgentCache]):
3828         (-[WebView setCustomUserAgent:]):
3829         * WebView/WebViewInternal.h:
3830
3831 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3832
3833         Enable Web Content Filtering on watchOS
3834         https://bugs.webkit.org/show_bug.cgi?id=187979
3835         <rdar://problem/42559346>
3836
3837         Reviewed by Wenson Hsieh.
3838
3839         * Configurations/FeatureDefines.xcconfig:
3840
3841 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3842
3843         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3844         https://bugs.webkit.org/show_bug.cgi?id=187846
3845
3846         Reviewed by Simon Fraser.
3847
3848         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3849
3850         * WebView/WebHTMLView.mm:
3851         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3852         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3853
3854 2018-07-11  Dean Jackson  <dino@apple.com>
3855
3856         Allow removal of white backgrounds
3857         https://bugs.webkit.org/show_bug.cgi?id=187574
3858         <rdar://problem/41146792>
3859
3860         Reviewed by Simon Fraser.
3861
3862         Add a new WebPreference for punching out white backgrounds.
3863
3864         * WebView/WebPreferenceKeysPrivate.h:
3865         * WebView/WebPreferences.mm:
3866         (+[WebPreferences initialize]):
3867         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3868         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3869         * WebView/WebPreferencesPrivate.h:
3870         * WebView/WebView.mm:
3871         (-[WebView _preferencesChanged:]):
3872
3873 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3874
3875         Ensure WebKit stack is ad-hoc signed
3876         https://bugs.webkit.org/show_bug.cgi?id=187667
3877
3878         Reviewed by Alexey Proskuryakov.
3879
3880         * Configurations/Base.xcconfig:
3881
3882 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3883
3884         REGRESSION (231276): Attempting to copy an image fails
3885         https://bugs.webkit.org/show_bug.cgi?id=187212
3886         <rdar://problem/41540074>
3887
3888         Reviewed by Ryosuke Niwa.
3889
3890         Renamed methods to make it clear that one URL and one title are being passed in.
3891
3892         * WebCoreSupport/WebPlatformStrategies.h:
3893         * WebCoreSupport/WebPlatformStrategies.mm:
3894         (WebPlatformStrategies::setURL):
3895
3896 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3897
3898         Disable cross-origin-window-policy by default
3899         https://bugs.webkit.org/show_bug.cgi?id=187509
3900
3901         Reviewed by Chris Dumez.
3902
3903         * WebView/WebPreferences.mm:
3904         (+[WebPreferences initialize]):
3905
3906 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3907
3908         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3909         https://bugs.webkit.org/show_bug.cgi?id=187425
3910         rdar://problem/39948240
3911
3912         Reviewed by Tim Horton.
3913
3914         * WebView/WebView.mm:
3915         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3916         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3917         a call in this method to setUseDarkAppearance.
3918         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3919         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3920         (-[WebView _updateDefaultAppearance]): Deleted.
3921         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3922
3923 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3924
3925         Shrink various loading-related enums to shrink CachedResource
3926         https://bugs.webkit.org/show_bug.cgi?id=187443
3927
3928         Reviewed by Chris Dumez.
3929
3930         * WebCoreSupport/WebFrameLoaderClient.mm:
3931         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3932         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3933         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3934         (WebFrameLoaderClient::dispatchWillSendRequest):
3935         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3936         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3937         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3938         (WebFrameLoaderClient::updateGlobalHistory):
3939         (WebFrameLoaderClient::canHandleRequest const):
3940         * WebView/WebDataSource.mm:
3941         (-[WebDataSource initialRequest]):
3942         (-[WebDataSource request]):
3943
3944 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3945
3946         Unreviewed, rolling out r233612.
3947         https://bugs.webkit.org/show_bug.cgi?id=187475
3948
3949         Revision caused the api test LinkColorWithSystemAppearance to
3950         fail on all systems. (Requested by Truitt on #webkit).
3951
3952         Reverted changeset:
3953
3954         "Semantic colors don't update when accessibility Increase
3955         Contrast mode is enabled."
3956         https://bugs.webkit.org/show_bug.cgi?id=187425
3957         https://trac.webkit.org/changeset/233612
3958
3959 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3960
3961         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3962         https://bugs.webkit.org/show_bug.cgi?id=187425
3963         rdar://problem/39948240
3964
3965         Reviewed by Tim Horton.
3966
3967         * WebView/WebView.mm:
3968         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3969         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3970         a call in this method to setUseDarkAppearance.
3971         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3972         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3973         (-[WebView _updateDefaultAppearance]): Deleted.
3974         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3975
3976 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3977
3978         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3979         https://bugs.webkit.org/show_bug.cgi?id=187369
3980         rdar://problem/41870420
3981
3982         Reviewed by Tim Horton.
3983
3984         * WebView/WebMediaPlaybackTargetPicker.mm:
3985         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3986         * WebView/WebView.mm:
3987         (-[WebView _commonInitializationWithFrameName:groupName:]):
3988         (-[WebView _effectiveAppearanceIsDark]):
3989         (-[WebView _updateDefaultAppearance]):
3990         (-[WebView _defaultAppearance]): Deleted.
3991
3992 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3993
3994         Youtube video pages crash after a couple of minutes
3995         https://bugs.webkit.org/show_bug.cgi?id=187316
3996
3997         Reviewed by Antti Koivisto.
3998
3999         * WebView/WebView.mm:
4000         (-[WebView _preferencesChanged:]):
4001
4002 2018-07-04  Tim Horton  <timothy_horton@apple.com>
4003
4004         Introduce PLATFORM(IOSMAC)
4005         https://bugs.webkit.org/show_bug.cgi?id=187315
4006
4007         Reviewed by Dan Bernstein.
4008
4009         * Configurations/Base.xcconfig:
4010         * Configurations/FeatureDefines.xcconfig:
4011
4012 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4013
4014         [iOS] DataTransfer.getData always returns the empty string when dropping text
4015         https://bugs.webkit.org/show_bug.cgi?id=187130
4016         <rdar://problem/41014117>
4017
4018         Reviewed by Ryosuke Niwa.
4019
4020         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
4021
4022         * WebCoreSupport/WebPlatformStrategies.h:
4023         * WebCoreSupport/WebPlatformStrategies.mm:
4024         (WebPlatformStrategies::allPasteboardItemInfo):
4025
4026 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
4027
4028         [Mac] AirPlay picker uses incorrect theme in Dark mode
4029         https://bugs.webkit.org/show_bug.cgi?id=187054
4030         <rdar://problem/41291093>
4031
4032         Reviewed by Timothy Hatcher.
4033
4034         * WebView/WebMediaPlaybackTargetPicker.mm:
4035         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
4036
4037 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
4038
4039         [WTF] Add user-defined literal for ASCIILiteral
4040         https://bugs.webkit.org/show_bug.cgi?id=186839
4041
4042         Reviewed by Darin Adler.
4043
4044         * DOM/ExceptionHandlers.mm:
4045         (raiseDOMErrorException):
4046         * Plugins/Hosted/ProxyInstance.mm:
4047         (WebKit::ProxyInstance::invokeMethod):
4048         * Storage/WebDatabaseProvider.mm:
4049         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
4050
4051 2018-06-22  Timothy Hatcher  <timothy@apple.com>
4052
4053         Recalc styles every time defaultAppearance changes.