LayoutTests/imported/w3c:
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2
3         Runtime flag and IDL for MediaRecorder
4         https://bugs.webkit.org/show_bug.cgi?id=190018
5
6         Reviewed by Youenn Fablet and Chris Dumez.
7
8         * WebView/WebPreferenceKeysPrivate.h:
9         * WebView/WebPreferences.mm:
10         (+[WebPreferences initialize]):
11         (-[WebPreferences mediaRecorderEnabled]):
12         (-[WebPreferences setMediaRecorderEnabled:]):
13         * WebView/WebPreferencesPrivate.h:
14         * WebView/WebView.mm:
15         (-[WebView _preferencesChanged:]):
16
17 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
20         https://bugs.webkit.org/show_bug.cgi?id=190238
21
22         Reviewed by Antti Koivisto.
23
24         Enabled the feature by default.
25
26         * WebView/WebPreferences.mm:
27         (+[WebPreferences initialize]):
28
29 2018-10-01  Dean Jackson  <dino@apple.com>
30
31         [macOS] Switching to discrete GPU should be done in the UI process
32         https://bugs.webkit.org/show_bug.cgi?id=189361
33         <rdar://problem/43949622>
34
35         Reviewed by Simon Fraser.
36
37         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
38         not support swapping to the discrete GPU in this configuration.
39
40         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
41         (WebKit::WebSwitchingGPUClient::singleton):
42         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
43         * WebView/WebView.mm:
44         (-[WebView _commonInitializationWithFrameName:groupName:]):
45
46 2018-10-02  Alex Christensen  <achristensen@webkit.org>
47
48         Remove ParsedURLString
49         https://bugs.webkit.org/show_bug.cgi?id=190154
50
51         Reviewed by Chris Dumez.
52
53         * WebView/WebScriptDebugger.mm:
54         (toNSURL):
55
56 2018-10-01  Dean Jackson  <dino@apple.com>
57
58         Remove CSS Animation Triggers
59         https://bugs.webkit.org/show_bug.cgi?id=190175
60         <rdar://problem/44925626>
61
62         Reviewed by Simon Fraser.
63
64         * Configurations/FeatureDefines.xcconfig:
65
66 2018-10-02  Commit Queue  <commit-queue@webkit.org>
67
68         Unreviewed, rolling out r236624 and r236671.
69         https://bugs.webkit.org/show_bug.cgi?id=190207
70
71         The change in r236624 introduced crashes on the bots
72         (Requested by ryanhaddad on #webkit).
73
74         Reverted changesets:
75
76         "Refactoring: eliminate raw pointer usage in Fullscreen code"
77         https://bugs.webkit.org/show_bug.cgi?id=188747
78         https://trac.webkit.org/changeset/236624
79
80         "Unify implementation in VideoFullscreenInterfaceAVKit"
81         https://bugs.webkit.org/show_bug.cgi?id=190091
82         https://trac.webkit.org/changeset/236671
83
84 2018-10-01  Alex Christensen  <achristensen@webkit.org>
85
86         URL should not use TextEncoding internally
87         https://bugs.webkit.org/show_bug.cgi?id=190111
88
89         Reviewed by Andy Estes.
90
91         * Misc/WebNSURLExtras.mm:
92
93 2018-09-28  Jer Noble  <jer.noble@apple.com>
94
95         Refactoring: eliminate raw pointer usage in Fullscreen code
96         https://bugs.webkit.org/show_bug.cgi?id=188747
97         <rdar://problem/43541164>
98
99         Reviewed by Alex Christensen.
100
101         PlaybackSessionInterface no longer has an invalidate() method.
102
103         * WebView/WebView.mm:
104         (-[WebView _clearPlaybackControlsManager]):
105
106 2018-09-28  Chris Dumez  <cdumez@apple.com>
107
108         Drop support for cross-origin-window-policy header
109         https://bugs.webkit.org/show_bug.cgi?id=190081
110
111         Reviewed by Ryosuke Niwa.
112
113         * WebView/WebPreferenceKeysPrivate.h:
114         * WebView/WebPreferences.mm:
115         (+[WebPreferences initialize]):
116         * WebView/WebPreferencesPrivate.h:
117         * WebView/WebView.mm:
118         (-[WebView _preferencesChanged:]):
119
120 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Rename createMarkup to serializePreservingVisualAppearance
123         https://bugs.webkit.org/show_bug.cgi?id=190086
124
125         Reviewed by Wenson Hsieh.
126
127         * DOM/WebDOMOperations.mm:
128         (-[DOMRange markupString]):
129
130 2018-09-28  Commit Queue  <commit-queue@webkit.org>
131
132         Unreviewed, rolling out r236605.
133         https://bugs.webkit.org/show_bug.cgi?id=190087
134
135         caused three API test timeouts (Requested by jernoble on
136         #webkit).
137
138         Reverted changeset:
139
140         "Refactoring: eliminate raw pointer usage in Fullscreen code"
141         https://bugs.webkit.org/show_bug.cgi?id=188747
142         https://trac.webkit.org/changeset/236605
143
144 2018-09-28  Jer Noble  <jer.noble@apple.com>
145
146         Refactoring: eliminate raw pointer usage in Fullscreen code
147         https://bugs.webkit.org/show_bug.cgi?id=188747
148         <rdar://problem/43541164>
149
150         Reviewed by Alex Christensen.
151
152         PlaybackSessionInterface no longer has an invalidate() method.
153
154         * WebView/WebView.mm:
155         (-[WebView _clearPlaybackControlsManager]):
156
157 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
158
159         Use enum class in createMarkup arguments
160         https://bugs.webkit.org/show_bug.cgi?id=190028
161
162         Reviewed by Wenson Hsieh.
163
164         * DOM/WebDOMOperations.mm:
165         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
166         (-[DOMRange markupString]): Ditto.
167
168 2018-09-27  Antoine Quint  <graouts@apple.com>
169
170         [Web Animations] Turn Web Animations with CSS integration on
171         https://bugs.webkit.org/show_bug.cgi?id=184819
172         <rdar://problem/39597337>
173
174         Reviewed by Dean Jackson.
175
176         * WebView/WebPreferences.mm:
177         (+[WebPreferences initialize]):
178
179 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
180
181         Selection should work across shadow boundary when initiated by a mouse drag
182         https://bugs.webkit.org/show_bug.cgi?id=151380
183         <rdar://problem/24363872>
184
185         Reviewed by Wenson Hsieh.
186
187         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
188
189         * WebView/WebPreferenceKeysPrivate.h:
190         * WebView/WebPreferences.mm:
191         (+[WebPreferences initialize]):
192         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
193         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
194         * WebView/WebPreferencesPrivate.h:
195         * WebView/WebView.mm:
196         (-[WebView _preferencesChanged:]):
197
198 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
199
200         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
201         https://bugs.webkit.org/show_bug.cgi?id=189918
202         Work towards <rdar://problem/44648705>
203
204         Reviewed by Tim Horton.
205
206         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
207
208         * WebView/WebHTMLView.mm:
209         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
210         (-[WebHTMLView _updateFontPanel]):
211         * WebView/WebView.mm:
212         (-[WebView typingAttributes]):
213
214 2018-09-17  Darin Adler  <darin@apple.com>
215
216         Use OpaqueJSString rather than JSRetainPtr inside WebKit
217         https://bugs.webkit.org/show_bug.cgi?id=189652
218
219         Reviewed by Saam Barati.
220
221         * WebView/WebPDFRepresentation.mm:
222         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
223
224 2018-09-14  Jer Noble  <jer.noble@apple.com>
225
226         Turn SourceBufferChangeTypeEnabled on by default
227         https://bugs.webkit.org/show_bug.cgi?id=189527
228
229         Reviewed by Eric Carlson.
230
231         * WebView/WebPreferences.mm:
232         (+[WebPreferences initialize]):
233
234 2018-09-12  Alex Christensen  <achristensen@webkit.org>
235
236         Fix an internal build after r235935
237         https://bugs.webkit.org/show_bug.cgi?id=188996
238
239         * Carbon/HIWebView.mm:
240         (Draw):
241         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
242
243 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
244
245         Add IGNORE_WARNING_.* macros
246         https://bugs.webkit.org/show_bug.cgi?id=188996
247
248         Reviewed by Michael Catanzaro.
249
250         * Carbon/CarbonUtils.m:
251         (PoolCleaner):
252         * Carbon/CarbonWindowAdapter.mm:
253         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
254         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
255         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
256         (-[CarbonWindowAdapter _termWindowIfOwner]):
257         (-[CarbonWindowAdapter _windowMovedToRect:]):
258         (-[CarbonWindowAdapter setContentView:]):
259         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
260         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
261         * Carbon/CarbonWindowFrame.m:
262         (-[CarbonWindowFrame title]):
263         * Carbon/HIViewAdapter.m:
264         (+[HIViewAdapter getHIViewForNSView:]):
265         * Carbon/HIWebView.mm:
266         (overrideCGContext):
267         (restoreCGContext):
268         (Draw):
269         * DOM/DOM.mm:
270         * History/WebHistory.mm:
271         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
272         * History/WebHistoryItem.mm:
273         (-[WebHistoryItem icon]):
274         * Misc/WebKitNSStringExtras.mm:
275         (-[NSString _web_drawAtPoint:font:textColor:]):
276         * Misc/WebNSImageExtras.m:
277         (-[NSImage _web_scaleToMaxSize:]):
278         (-[NSImage _web_dissolveToFraction:]):
279         * Misc/WebNSPasteboardExtras.mm:
280         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
281         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
282         * Panels/WebAuthenticationPanel.m:
283         (-[WebAuthenticationPanel loadNib]):
284         * Plugins/Hosted/NetscapePluginHostManager.mm:
285         (WebKit::NetscapePluginHostManager::spawnPluginHost):
286         (WebKit::NetscapePluginHostManager::didCreateWindow):
287         * Plugins/Hosted/NetscapePluginHostProxy.mm:
288         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
289         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
290         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
291         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
292         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
293         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
294         (-[WebHostedNetscapePluginView drawRect:]):
295         * Plugins/Hosted/WebTextInputWindowController.m:
296         (-[WebTextInputPanel _interpretKeyEvent:string:]):
297         * Plugins/WebBaseNetscapePluginView.mm:
298         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
299         * Plugins/WebNetscapePluginPackage.mm:
300         (-[WebNetscapePluginPackage _tryLoad]):
301         * Plugins/WebNetscapePluginView.mm:
302         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
303         (-[WebNetscapePluginView sendDrawRectEvent:]):
304         (-[WebNetscapePluginView drawRect:]):
305         * Plugins/WebPluginController.mm:
306         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
307         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
308         * WebCoreSupport/PopupMenuMac.mm:
309         (PopupMenuMac::populate):
310         * WebCoreSupport/WebAlternativeTextClient.h:
311         * WebCoreSupport/WebDragClient.mm:
312         (WebDragClient::startDrag):
313         * WebCoreSupport/WebFrameLoaderClient.mm:
314         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
315         (webGetNSImage):
316         * WebInspector/WebNodeHighlight.mm:
317         * WebInspector/WebNodeHighlightView.mm:
318         (-[WebNodeHighlightView drawRect:]):
319         * WebView/WebClipView.mm:
320         (-[WebClipView initWithFrame:]):
321         * WebView/WebFrame.mm:
322         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
323         (-[WebFrame _drawRect:contentsOnly:]):
324         (-[WebFrame accessibilityRoot]):
325         * WebView/WebFullScreenController.mm:
326         (-[WebFullScreenController enterFullScreen:]):
327         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
328         (-[WebFullScreenController exitFullScreen]):
329         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
330         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
331         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
332         * WebView/WebHTMLView.mm:
333         (-[NSWindow _web_borderView]):
334         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
335         (-[WebHTMLView _setAsideSubviews]):
336         (-[WebHTMLView _autoscroll]):
337         (-[WebHTMLView drawRect:]):
338         (-[WebHTMLView mouseDown:]):
339         (-[WebHTMLView mouseDragged:]):
340         (-[WebHTMLView mouseUp:]):
341         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
342         (-[WebHTMLView knowsPageRange:]):
343         (-[WebHTMLView accessibilityHitTest:]):
344         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
345         (-[WebHTMLView _colorAsString:]):
346         (-[WebHTMLView copyFont:]):
347         (-[WebHTMLView _executeSavedKeypressCommands]):
348         (-[WebHTMLView attachRootLayer:]):
349         (-[WebHTMLView textStorage]):
350         (-[WebHTMLView _updateSelectionForInputManager]):
351         * WebView/WebPDFView.mm:
352         (_applicationInfoForMIMEType):
353         (-[WebPDFView centerSelectionInVisibleArea:]):
354         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
355         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
356         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
357         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
358         * WebView/WebTextCompletionController.mm:
359         (-[WebTextCompletionController _buildUI]):
360         (-[WebTextCompletionController _placePopupWindow:]):
361         * WebView/WebVideoFullscreenController.mm:
362         * WebView/WebVideoFullscreenHUDWindowController.mm:
363         (createMediaUIBackgroundView):
364         * WebView/WebView.mm:
365         (-[WebTextListTouchBarViewController initWithWebView:]):
366         (-[WebView _dispatchTileDidDraw:]):
367         (-[WebView encodeWithCoder:]):
368         (-[WebView mainFrameIcon]):
369         (LayerFlushController::flushLayers):
370         * WebView/WebWindowAnimation.mm:
371         (setScaledFrameForWindow):
372
373 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
374
375         Remove unused needsDestruction class variables from HashTraits
376         https://bugs.webkit.org/show_bug.cgi?id=189490
377
378         Reviewed by Daniel Bates.
379
380         * History/BinaryPropertyList.cpp: Removed needsDestruction.
381
382 2018-09-07  Frederic Wang  <fwang@igalia.com>
383
384         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
385         https://bugs.webkit.org/show_bug.cgi?id=182230
386
387         Reviewed by Simon Fraser.
388
389         * DOM/DOMDocument.mm:
390         (-[DOMDocument scrollingElement]): Use the new name.
391
392 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
393
394         Refactor WebCore::EditAction to be an 8-bit enum class
395         https://bugs.webkit.org/show_bug.cgi?id=189383
396
397         Reviewed by Dan Bernstein.
398
399         * WebCoreSupport/WebEditorClient.mm:
400         (undoNameForEditAction):
401         * WebView/WebHTMLView.mm:
402         (-[WebHTMLView pasteFont:]):
403         (-[WebHTMLView changeFont:]):
404         (-[WebHTMLView changeAttributes:]):
405         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
406         (-[WebHTMLView changeColor:]):
407         * WebView/WebView.mm:
408         (-[WebView setTypingStyle:]):
409
410 2018-09-06  Frederic Wang  <fwang@igalia.com>
411
412         Group options of scrollRectToVisible into a struct
413         https://bugs.webkit.org/show_bug.cgi?id=189352
414
415         Reviewed by Simon Fraser.
416
417         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
418         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
419         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
420
421 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
422
423         [macOS] Cannot change font size at selection until font panel is shown
424         https://bugs.webkit.org/show_bug.cgi?id=189295
425         <rdar://problem/35593389>
426
427         Reviewed by Ryosuke Niwa.
428
429         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
430         WebCore ChangeLog for more details.
431
432         * WebView/WebHTMLView.mm:
433         (-[WebHTMLView changeFont:]):
434         (-[WebHTMLView changeAttributes:]):
435         (-[WebHTMLView _originalFontA]): Deleted.
436         (-[WebHTMLView _originalFontB]): Deleted.
437         (fontNameForDescription): Deleted.
438         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
439         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
440         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
441
442 2018-09-05  Jer Noble  <jer.noble@apple.com>
443
444         Add MediaCapabilities as an Experimental Feature
445         https://bugs.webkit.org/show_bug.cgi?id=189209
446
447         Reviewed by Eric Carlson.
448
449         RuntimeEnabledFeature -> Setting.
450
451         * WebView/WebView.mm:
452         (-[WebView _preferencesChanged:]):
453
454 2018-09-04  Frederic Wang  <fwang@igalia.com>
455
456         Add basic support for ScrollIntoViewOptions
457         https://bugs.webkit.org/show_bug.cgi?id=189258
458
459         Reviewed by Simon Fraser.
460
461         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
462         header so that this file can build despite the new scrollIntoView function.
463
464 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
465
466         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
467         https://bugs.webkit.org/show_bug.cgi?id=188890
468         <rdar://problem/43648605>
469
470         Reviewed by Tim Horton.
471
472         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
473         more detail.
474
475         * WebCoreSupport/WebPlatformStrategies.h:
476         * WebCoreSupport/WebPlatformStrategies.mm:
477         (WebPlatformStrategies::allStringsForType):
478
479 2018-09-01  Darin Adler  <darin@apple.com>
480
481         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
482         https://bugs.webkit.org/show_bug.cgi?id=189072
483         Reviewed by Dan Bernstein.
484
485         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
486         and declarations for NSURLDownload init methods.
487
488         * Misc/WebDownloadInternal.h: Removed.
489
490         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
491         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
492         "-Wdeprecated-declarations" because the method used here is deprecated.
493
494         * WebView/WebView.mm:
495         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
496         used here is deprecated.
497
498 2018-08-31  Chris Dumez  <cdumez@apple.com>
499
500         Assertion hit in ~CompletionHandler() from ~WebFrame()
501         https://bugs.webkit.org/show_bug.cgi?id=189199
502         <rdar://problem/42657233>
503
504         Reviewed by Youenn Fablet.
505
506         * WebCoreSupport/WebFrameLoaderClient.h:
507         * WebCoreSupport/WebFrameLoaderClient.mm:
508         (WebFrameLoaderClient::dispatchWillSubmitForm):
509
510 2018-08-31  Antti Koivisto  <antti@apple.com>
511
512         Replace OptionSet |= and -= operators with add() and remove() functions
513         https://bugs.webkit.org/show_bug.cgi?id=189169
514
515         Reviewed by Anders Carlsson.
516
517         * WebView/WebFrame.mm:
518         (-[WebFrame _drawRect:contentsOnly:]):
519         * WebView/WebView.mm:
520         (coreOptions):
521
522 2018-08-31  Frederic Wang  <fwang@igalia.com>
523
524         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
525         https://bugs.webkit.org/show_bug.cgi?id=182053
526
527         Reviewed by Simon Fraser.
528
529         Add developer flag to use standard behavior for scrolling* attributes.
530
531         * WebView/WebPreferenceKeysPrivate.h:
532         * WebView/WebPreferences.mm:
533         (+[WebPreferences initialize]):
534         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
535         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
536         * WebView/WebPreferencesPrivate.h:
537         * WebView/WebView.mm:
538         (-[WebView _preferencesChanged:]):
539
540 2018-08-29  Olivia Barnett  <obarnett@apple.com>
541
542         Implement the Web Share API
543         https://bugs.webkit.org/show_bug.cgi?id=171100
544         <rdar://problem/31751734>
545
546         Reviewed by Tim Horton.
547
548         * WebCoreSupport/WebChromeClient.h:
549         * WebCoreSupport/WebChromeClient.mm:
550         (WebChromeClient::showShareSheet):
551         Empty declaration of showShareSheet.
552
553 2018-08-29  Youenn Fablet  <youenn@apple.com>
554
555         Remove WebRTC legacy API implementation
556         https://bugs.webkit.org/show_bug.cgi?id=189040
557
558         Reviewed by Eric Carlson.
559
560         * WebView/WebPreferenceKeysPrivate.h:
561         * WebView/WebPreferences.mm:
562         (+[WebPreferences initialize]):
563         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
564         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
565         * WebView/WebPreferencesPrivate.h:
566         * WebView/WebView.mm:
567         (-[WebView _preferencesChanged:]):
568
569 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
572         https://bugs.webkit.org/show_bug.cgi?id=189054
573
574         Reviewed by Andy Estes.
575
576         Remove the pasteboard type argument from readURLFromPasteboard.
577
578         * WebCoreSupport/WebPlatformStrategies.h:
579         * WebCoreSupport/WebPlatformStrategies.mm:
580         (WebPlatformStrategies::readURLFromPasteboard):
581
582 2018-08-27  Keith Rollin  <krollin@apple.com>
583
584         Unreviewed build fix -- disable LTO for production builds
585
586         * Configurations/Base.xcconfig:
587
588 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
589
590         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
591         https://bugs.webkit.org/show_bug.cgi?id=188931
592
593         Reviewed by Wenson Hsieh.
594
595         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
596
597 2018-08-27  Keith Rollin  <krollin@apple.com>
598
599         Build system support for LTO
600         https://bugs.webkit.org/show_bug.cgi?id=187785
601         <rdar://problem/42353132>
602
603         Reviewed by Dan Bernstein.
604
605         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
606         LTO.
607
608         * Configurations/Base.xcconfig:
609         * Configurations/DebugRelease.xcconfig:
610
611 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
612
613         Pass in IsComposed flag to Event constructors
614         https://bugs.webkit.org/show_bug.cgi?id=188720
615         <rdar://problem/43580387>
616
617         Reviewed by Simon Fraser.
618
619         * WebView/WebPDFView.mm:
620         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
621         whether it's simulated or not.
622
623 2018-08-23  Mark Lam  <mark.lam@apple.com>
624
625         Move vmEntryGlobalObject() to VM from CallFrame.
626         https://bugs.webkit.org/show_bug.cgi?id=188900
627         <rdar://problem/43655753>
628
629         Reviewed by Michael Saboff.
630
631         * WebView/WebScriptDebugger.mm:
632         (WebScriptDebugger::sourceParsed):
633
634 2018-08-23  Andy Estes  <aestes@apple.com>
635
636         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
637         https://bugs.webkit.org/show_bug.cgi?id=188829
638
639         Reviewed by Tim Horton.
640
641         * Configurations/FeatureDefines.xcconfig:
642
643 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
644
645         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
646         https://bugs.webkit.org/show_bug.cgi?id=188777
647
648         Reviewed by Simon Fraser.
649
650         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
651         being "true" before the code change.
652
653         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
654
655         * WebView/WebPDFView.mm:
656         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
657
658 2018-08-21  Daniel Bates  <dabates@apple.com>
659
660         Replace TextCheckingTypeMask with OptionSet
661         https://bugs.webkit.org/show_bug.cgi?id=188678
662
663         Reviewed by Antti Koivisto.
664
665         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
666         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
667         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
668         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
669
670         * WebCoreSupport/WebEditorClient.h:
671         * WebCoreSupport/WebEditorClient.mm:
672         (WebEditorClient::checkTextOfParagraph):
673         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
674         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
675         left as this is more readable and unncessary now that modern compilers like Clang have
676         diagnostics to catch accidental assignments when equality was intended.
677         (WebEditorClient::didCheckSucceed):
678         * WebView/WebView.mm:
679         (coreTextCheckingType):
680         (textCheckingResultFromNSTextCheckingResult):
681
682 2018-08-21  Daniel Bates  <dabates@apple.com>
683
684         [iOS][WK1] Support toggling continuous spell checking from tests
685         https://bugs.webkit.org/show_bug.cgi?id=188763
686
687         Reviewed by Simon Fraser.
688
689         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
690         spell checking from tests in iOS WebKit Legacy.
691
692         * WebCoreSupport/WebEditorClient.h:
693         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
694         * WebCoreSupport/WebEditorClient.mm:
695         * WebView/WebView.h:
696         * WebView/WebView.mm:
697         (-[WebView toggleContinuousSpellChecking:]):
698         (-[WebView toggleSmartInsertDelete:]):
699
700 2018-08-17  Alex Christensen  <achristensen@webkit.org>
701
702         Add some plumbing for safe browsing
703         https://bugs.webkit.org/show_bug.cgi?id=188709
704
705         Reviewed by Tim Horton.
706
707         * WebCoreSupport/WebFrameLoaderClient.h:
708         * WebCoreSupport/WebFrameLoaderClient.mm:
709         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
710
711 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
712
713         Replace canBubble and cancelable booleans in Event by enum classes
714         https://bugs.webkit.org/show_bug.cgi?id=188692
715
716         Reviewed by Alex Christensen.
717
718         * WebView/WebPDFView.mm:
719         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
720         * WebView/WebView.mm:
721         (-[WebView _dispatchUnloadEvent]):
722
723 2018-08-16  Jer Noble  <jer.noble@apple.com>
724
725         Add Experimental Feature support for SourceBuffer.changeType()
726         https://bugs.webkit.org/show_bug.cgi?id=188626
727         <rdar://problem/43356021>
728
729         Reviewed by Eric Carlson.
730
731         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
732
733         * WebView/WebPreferenceKeysPrivate.h:
734         * WebView/WebPreferences.mm:
735         (+[WebPreferences initialize]):
736         (-[WebPreferences sourceBufferChangeTypeEnabled]):
737         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
738         * WebView/WebPreferencesPrivate.h:
739         * WebView/WebView.mm:
740         (-[WebView _preferencesChanged:]):
741
742 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
743
744         Support drag-and-drop for input[type=color]
745         https://bugs.webkit.org/show_bug.cgi?id=188464
746
747         Reviewed by Wenson Hsieh.
748
749         * WebCoreSupport/WebPlatformStrategies.h:
750         * WebCoreSupport/WebPlatformStrategies.mm:
751         (WebPlatformStrategies::setColor):
752
753 2018-08-15  Tim Horton  <timothy_horton@apple.com>
754
755         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
756         https://bugs.webkit.org/show_bug.cgi?id=188569
757         <rdar://problem/34201095>
758
759         Reviewed by Megan Gardner.
760
761         * WebView/WebImmediateActionController.mm:
762         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
763         Speculative fix; the crashes indicate font is null, but we just checked it,
764         so it must be getting made null by convertFont:toSize:. Check again!
765
766 2018-08-13  Alex Christensen  <achristensen@webkit.org>
767
768         Use a 1-byte enum class for TextDirection
769         https://bugs.webkit.org/show_bug.cgi?id=188350
770
771         Reviewed by Simon Fraser.
772
773         * WebCoreSupport/PopupMenuMac.mm:
774         (PopupMenuMac::populate):
775         (PopupMenuMac::show):
776         * WebCoreSupport/WebFrameLoaderClient.mm:
777         (WebFrameLoaderClient::transitionToCommittedForNewPage):
778         * WebView/WebFrame.mm:
779         (-[WebFrame _dispatchDidReceiveTitle:]):
780
781 2018-08-09  Ali Juma  <ajuma@chromium.org>
782
783         Import WPTs for IntersectionObserver
784         https://bugs.webkit.org/show_bug.cgi?id=188416
785
786         Reviewed by Simon Fraser.
787
788         * WebView/WebPreferencesPrivate.h:
789
790 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
791
792         Follow-up build fix for r234685
793         https://bugs.webkit.org/show_bug.cgi?id=188245
794
795         Unreviewed build fix.
796
797         * WebCoreSupport/WebSecurityOriginPrivate.h:
798
799 2018-08-05  Darin Adler  <darin@apple.com>
800
801         [Cocoa] More tweaks and refactoring to prepare for ARC
802         https://bugs.webkit.org/show_bug.cgi?id=188245
803
804         Reviewed by Dan Bernstein.
805
806         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
807
808         * Carbon/CarbonWindowFrame.m:
809         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
810
811         * DOM/DOM.mm:
812         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
813         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
814         garbage collection so this method isn't useful.
815
816         * DOM/DOMXPath.mm:
817         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
818         Objective-C garbage collection so this method isn't useful.
819
820         * History/WebHistory.mm:
821         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
822
823         * Misc/WebElementDictionary.mm:
824         (addLookupKey): Use a bridging cast.
825         (cacheValueForKey): Ditto.
826         (-[WebElementDictionary _fillCache]): Ditto.
827         (-[WebElementDictionary objectForKey:]): Ditto.
828
829         * Misc/WebKitNSStringExtras.mm:
830         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
831         (-[NSString _web_widthWithFont:]): Ditto.
832         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
833
834         * Misc/WebLocalizableStrings.mm:
835         (WebLocalizedString): Use a bridging cast.
836
837         * Misc/WebNSDataExtras.mm:
838         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
839         and use CFBridgingRelease instead of calling autorelease directly.
840         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
841         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
842         on the amount of explicit release and autorelease.
843
844         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
845         * Misc/WebNSDictionaryExtras.m:
846         (-[NSDictionary _webkit_intForKey:]): Deleted.
847         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
848         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
849         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
850         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
851         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
852         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
853
854         * Misc/WebStringTruncator.mm:
855         (fontFromNSFont): Use a bridging cast.
856
857         * Plugins/Hosted/NetscapePluginHostManager.mm:
858         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
859
860         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
861         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
862         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
863         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
864         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
865         * Plugins/Hosted/ProxyInstance.mm:
866         (WebKit::ProxyInstance::getPropertyNames): Ditto.
867         * Plugins/WebBasePluginPackage.mm:
868         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
869         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
870         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
871         * Plugins/WebNetscapePluginPackage.mm:
872         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
873
874         * Plugins/WebNetscapePluginView.mm:
875         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
876         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
877         (-[WebNetscapePluginView status:]): Use a bridging cast.
878         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
879
880         * Plugins/WebPluginController.mm:
881         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
882
883         * Plugins/WebPluginDatabase.mm:
884         (checkCandidate): Use explicit __strong for out argument types.
885
886         * Plugins/npapi.mm:
887         (pluginViewForInstance): Use a bridging cast.
888
889         * Storage/WebDatabaseManager.mm:
890         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
891         explicit NSNumber and NSDictionary calls.
892
893         * WebCoreSupport/WebContextMenuClient.mm:
894         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
895
896         * WebCoreSupport/WebEditorClient.mm:
897         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
898         (WebEditorClient::handleInputMethodKeydown): Ditto.
899
900         * WebCoreSupport/WebFrameNetworkingContext.mm:
901         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
902
903         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
904         as a struct rather than an Objective-C class, since that's how it's defined.
905
906         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
907
908         * WebView/WebFullScreenController.mm:
909         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
910         * WebView/WebHTMLView.mm:
911         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
912         Ditto.
913         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
914
915         * WebView/WebImmediateActionController.mm:
916         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
917         go down to the document and then back to the frame.
918         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
919         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
920         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
921
922         * WebView/WebJSPDFDoc.mm:
923         (jsPDFDocInitialize): Removed some unneeded type casting.
924         (jsPDFDocFinalize): Ditto.
925         (jsPDFDocPrint): Use a bridging cast.
926
927         * WebView/WebPDFView.mm:
928         (_applicationInfoForMIMEType): Use bridging casts.
929
930         * WebView/WebPreferences.mm:
931         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
932         instead of methods from WebNSDictionaryExtras.
933         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
934         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
935         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
936         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
937         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
938
939         * WebView/WebView.mm:
940         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
941         (-[WebView _addToAllWebViewsSet]): Ditto.
942         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
943         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
944         so it can be called from WebViewData methods.
945
946         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
947         method, _windowVisibilityChanged:.
948
949         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
950         called from WebViewData methods.
951
952 2018-08-06  Alex Christensen  <achristensen@webkit.org>
953
954         Use enum classes and OptionSets for PaintPhase and PaintBehavior
955         https://bugs.webkit.org/show_bug.cgi?id=188323
956
957         Reviewed by Simon Fraser.
958
959         * WebCoreSupport/WebContextMenuClient.mm:
960         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
961         * WebView/WebFrame.mm:
962         (-[WebFrame _paintBehaviorForDestinationContext:]):
963         (-[WebFrame _drawRect:contentsOnly:]):
964         * WebView/WebHTMLView.mm:
965         (imageFromRect):
966         (selectionImage):
967
968 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
969
970         Add support for microtasks in workers
971         https://bugs.webkit.org/show_bug.cgi?id=188246
972
973         Reviewed by Darin Adler.
974
975         Rename JSMainThreadExecState.h to JSExecState.h.
976
977         * DOM/DOMAttr.mm:
978         * DOM/DOMBlob.mm:
979         * DOM/DOMCDATASection.mm:
980         * DOM/DOMCSSCharsetRule.mm:
981         * DOM/DOMCSSFontFaceRule.mm:
982         * DOM/DOMCSSImportRule.mm:
983         * DOM/DOMCSSMediaRule.mm:
984         * DOM/DOMCSSPageRule.mm:
985         * DOM/DOMCSSPrimitiveValue.mm:
986         * DOM/DOMCSSRule.mm:
987         * DOM/DOMCSSRuleList.mm:
988         * DOM/DOMCSSStyleDeclaration.mm:
989         * DOM/DOMCSSStyleRule.mm:
990         * DOM/DOMCSSStyleSheet.mm:
991         * DOM/DOMCSSUnknownRule.mm:
992         * DOM/DOMCSSValue.mm:
993         * DOM/DOMCSSValueList.mm:
994         * DOM/DOMCharacterData.mm:
995         * DOM/DOMComment.mm:
996         * DOM/DOMCounter.mm:
997         * DOM/DOMDocument.mm:
998         * DOM/DOMDocumentFragment.mm:
999         * DOM/DOMDocumentType.mm:
1000         * DOM/DOMElement.mm:
1001         * DOM/DOMEvent.mm:
1002         * DOM/DOMFile.mm:
1003         * DOM/DOMFileList.mm:
1004         * DOM/DOMHTML.mm:
1005         * DOM/DOMHTMLAnchorElement.mm:
1006         * DOM/DOMHTMLAppletElement.mm:
1007         * DOM/DOMHTMLAreaElement.mm:
1008         * DOM/DOMHTMLBRElement.mm:
1009         * DOM/DOMHTMLBaseElement.mm:
1010         * DOM/DOMHTMLBaseFontElement.mm:
1011         * DOM/DOMHTMLBodyElement.mm:
1012         * DOM/DOMHTMLButtonElement.mm:
1013         * DOM/DOMHTMLCanvasElement.mm:
1014         * DOM/DOMHTMLCollection.mm:
1015         * DOM/DOMHTMLDListElement.mm:
1016         * DOM/DOMHTMLDirectoryElement.mm:
1017         * DOM/DOMHTMLDivElement.mm:
1018         * DOM/DOMHTMLDocument.mm:
1019         * DOM/DOMHTMLElement.mm:
1020         * DOM/DOMHTMLEmbedElement.mm:
1021         * DOM/DOMHTMLFieldSetElement.mm:
1022         * DOM/DOMHTMLFontElement.mm:
1023         * DOM/DOMHTMLFormElement.mm:
1024         * DOM/DOMHTMLFrameElement.mm:
1025         * DOM/DOMHTMLFrameSetElement.mm:
1026         * DOM/DOMHTMLHRElement.mm:
1027         * DOM/DOMHTMLHeadElement.mm:
1028         * DOM/DOMHTMLHeadingElement.mm:
1029         * DOM/DOMHTMLHtmlElement.mm:
1030         * DOM/DOMHTMLIFrameElement.mm:
1031         * DOM/DOMHTMLImageElement.mm:
1032         * DOM/DOMHTMLInputElement.mm:
1033         * DOM/DOMHTMLLIElement.mm:
1034         * DOM/DOMHTMLLabelElement.mm:
1035         * DOM/DOMHTMLLegendElement.mm:
1036         * DOM/DOMHTMLLinkElement.mm:
1037         * DOM/DOMHTMLMapElement.mm:
1038         * DOM/DOMHTMLMarqueeElement.mm:
1039         * DOM/DOMHTMLMediaElement.mm:
1040         * DOM/DOMHTMLMenuElement.mm:
1041         * DOM/DOMHTMLMetaElement.mm:
1042         * DOM/DOMHTMLModElement.mm:
1043         * DOM/DOMHTMLOListElement.mm:
1044         * DOM/DOMHTMLObjectElement.mm:
1045         * DOM/DOMHTMLOptGroupElement.mm:
1046         * DOM/DOMHTMLOptionElement.mm:
1047         * DOM/DOMHTMLOptionsCollection.mm:
1048         * DOM/DOMHTMLParagraphElement.mm:
1049         * DOM/DOMHTMLParamElement.mm:
1050         * DOM/DOMHTMLPreElement.mm:
1051         * DOM/DOMHTMLQuoteElement.mm:
1052         * DOM/DOMHTMLScriptElement.mm:
1053         * DOM/DOMHTMLSelectElement.mm:
1054         * DOM/DOMHTMLStyleElement.mm:
1055         * DOM/DOMHTMLTableCaptionElement.mm:
1056         * DOM/DOMHTMLTableCellElement.mm:
1057         * DOM/DOMHTMLTableColElement.mm:
1058         * DOM/DOMHTMLTableElement.mm:
1059         * DOM/DOMHTMLTableRowElement.mm:
1060         * DOM/DOMHTMLTableSectionElement.mm:
1061         * DOM/DOMHTMLTextAreaElement.mm:
1062         * DOM/DOMHTMLTitleElement.mm:
1063         * DOM/DOMHTMLUListElement.mm:
1064         * DOM/DOMHTMLVideoElement.mm:
1065         * DOM/DOMImplementation.mm:
1066         * DOM/DOMKeyboardEvent.mm:
1067         * DOM/DOMMediaError.mm:
1068         * DOM/DOMMediaList.mm:
1069         * DOM/DOMMouseEvent.mm:
1070         * DOM/DOMMutationEvent.mm:
1071         * DOM/DOMNamedNodeMap.mm:
1072         * DOM/DOMNode.mm:
1073         * DOM/DOMNodeIterator.mm:
1074         * DOM/DOMNodeList.mm:
1075         * DOM/DOMOverflowEvent.mm:
1076         * DOM/DOMProcessingInstruction.mm:
1077         * DOM/DOMProgressEvent.mm:
1078         * DOM/DOMRGBColor.mm:
1079         * DOM/DOMRange.mm:
1080         * DOM/DOMRect.mm:
1081         * DOM/DOMStyleSheet.mm:
1082         * DOM/DOMStyleSheetList.mm:
1083         * DOM/DOMText.mm:
1084         * DOM/DOMTextEvent.mm:
1085         * DOM/DOMTimeRanges.mm:
1086         * DOM/DOMTokenList.mm:
1087         * DOM/DOMTreeWalker.mm:
1088         * DOM/DOMUIEvent.mm:
1089         * DOM/DOMWheelEvent.mm:
1090         * DOM/DOMXPathExpression.mm:
1091         * DOM/DOMXPathResult.mm:
1092         * DOM/ObjCEventListener.mm:
1093
1094 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1095
1096         Fix spelling of "overridden"
1097         https://bugs.webkit.org/show_bug.cgi?id=188315
1098
1099         Reviewed by Darin Adler.
1100
1101         * Misc/WebKitVersionChecks.mm:
1102         (setWebKitLinkTimeVersion):
1103         (WebKitLinkTimeVersion):
1104         * Plugins/WebBaseNetscapePluginView.mm:
1105         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1106         * WebCoreSupport/PopupMenuMac.mm:
1107         (PopupMenuMac::populate):
1108
1109 2018-08-01  Nan Wang  <n_wang@apple.com>
1110
1111         AX: AOM: Add ARIA IDL Attribute Reflection
1112         https://bugs.webkit.org/show_bug.cgi?id=184676
1113         <rdar://problem/39476882>
1114
1115         Reviewed by Chris Fleizach.
1116
1117         * WebView/WebPreferenceKeysPrivate.h:
1118         * WebView/WebPreferences.mm:
1119         (+[WebPreferences initialize]):
1120         (-[WebPreferences ariaReflectionEnabled]):
1121         (-[WebPreferences setAriaReflectionEnabled:]):
1122         * WebView/WebPreferencesPrivate.h:
1123         * WebView/WebView.mm:
1124         (-[WebView _preferencesChanged:]):
1125
1126 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1127
1128         Shrink GraphicsLayerCA
1129         https://bugs.webkit.org/show_bug.cgi?id=188141
1130
1131         Reviewed by Zalan Bujtas.
1132
1133         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1134         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1135         * moving all the animation-related stuff into the lazily-allocated m_animations
1136         * making enums be 8-bit
1137         * re-ordering data members
1138
1139         * WebView/WebView.mm:
1140         (-[WebView _setMediaLayer:forPluginView:]):
1141
1142 2018-07-30  Rob Buis  <rbuis@igalia.com>
1143
1144         Merge PlatformCookieJar functions into NetworkStorageSession
1145         https://bugs.webkit.org/show_bug.cgi?id=188137
1146
1147         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1148
1149         Reviewed by Alex Christensen.
1150
1151         * WebCoreSupport/WebPlatformStrategies.mm:
1152         (WebPlatformStrategies::cookiesForDOM):
1153         (WebPlatformStrategies::setCookiesFromDOM):
1154         (WebPlatformStrategies::cookiesEnabled):
1155         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1156         (WebPlatformStrategies::getRawCookies):
1157         (WebPlatformStrategies::deleteCookie):
1158         * WebView/WebPreferences.mm:
1159         (+[WebPreferences _clearNetworkLoaderSession]):
1160
1161 2018-07-28  Darin Adler  <darin@apple.com>
1162
1163         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1164         https://bugs.webkit.org/show_bug.cgi?id=188140
1165
1166         Reviewed by Sam Weinig.
1167
1168         * WebView/WebImmediateActionController.mm:
1169         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1170         new DictionaryLookup function that returns a tuple instead of using an out argument.
1171
1172 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1173
1174         [INTL] Remove INTL sub-feature compile flags
1175         https://bugs.webkit.org/show_bug.cgi?id=188081
1176
1177         Reviewed by Michael Catanzaro.
1178
1179         * Configurations/FeatureDefines.xcconfig:
1180
1181 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1182
1183         Unreviewed, rolling out r234181 and r234189.
1184         https://bugs.webkit.org/show_bug.cgi?id=188075
1185
1186         These are not needed right now (Requested by thorton on
1187         #webkit).
1188
1189         Reverted changesets:
1190
1191         "Enable Web Content Filtering on watchOS"
1192         https://bugs.webkit.org/show_bug.cgi?id=187979
1193         https://trac.webkit.org/changeset/234181
1194
1195         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1196         https://bugs.webkit.org/show_bug.cgi?id=187985
1197         https://trac.webkit.org/changeset/234189
1198
1199 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1200
1201         Use the Page's appearance when converting pasteboard attributed strings.
1202         https://bugs.webkit.org/show_bug.cgi?id=188067
1203         rdar://problem/42632246
1204
1205         Reviewed by Wenson Hsieh.
1206
1207         * WebCoreSupport/WebEditorClient.mm:
1208         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1209
1210 2018-07-25  Chris Dumez  <cdumez@apple.com>
1211
1212         navigator.userAgent may return outdated value after webView.customUserAgent is set
1213         https://bugs.webkit.org/show_bug.cgi?id=188009
1214         <rdar://problem/42566456>
1215
1216         Reviewed by Alex Christensen.
1217
1218         Let the page know when the user agent changes.
1219
1220         * WebView/WebView.mm:
1221         (-[WebView _preferencesChanged:]):
1222         (-[WebView setApplicationNameForUserAgent:]):
1223         (-[WebView _invalidateUserAgentCache]):
1224         (-[WebView setCustomUserAgent:]):
1225         * WebView/WebViewInternal.h:
1226
1227 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1228
1229         Enable Web Content Filtering on watchOS
1230         https://bugs.webkit.org/show_bug.cgi?id=187979
1231         <rdar://problem/42559346>
1232
1233         Reviewed by Wenson Hsieh.
1234
1235         * Configurations/FeatureDefines.xcconfig:
1236
1237 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1238
1239         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1240         https://bugs.webkit.org/show_bug.cgi?id=187846
1241
1242         Reviewed by Simon Fraser.
1243
1244         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1245
1246         * WebView/WebHTMLView.mm:
1247         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1248         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1249
1250 2018-07-11  Dean Jackson  <dino@apple.com>
1251
1252         Allow removal of white backgrounds
1253         https://bugs.webkit.org/show_bug.cgi?id=187574
1254         <rdar://problem/41146792>
1255
1256         Reviewed by Simon Fraser.
1257
1258         Add a new WebPreference for punching out white backgrounds.
1259
1260         * WebView/WebPreferenceKeysPrivate.h:
1261         * WebView/WebPreferences.mm:
1262         (+[WebPreferences initialize]):
1263         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1264         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1265         * WebView/WebPreferencesPrivate.h:
1266         * WebView/WebView.mm:
1267         (-[WebView _preferencesChanged:]):
1268
1269 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1270
1271         Ensure WebKit stack is ad-hoc signed
1272         https://bugs.webkit.org/show_bug.cgi?id=187667
1273
1274         Reviewed by Alexey Proskuryakov.
1275
1276         * Configurations/Base.xcconfig:
1277
1278 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1279
1280         REGRESSION (231276): Attempting to copy an image fails
1281         https://bugs.webkit.org/show_bug.cgi?id=187212
1282         <rdar://problem/41540074>
1283
1284         Reviewed by Ryosuke Niwa.
1285
1286         Renamed methods to make it clear that one URL and one title are being passed in.
1287
1288         * WebCoreSupport/WebPlatformStrategies.h:
1289         * WebCoreSupport/WebPlatformStrategies.mm:
1290         (WebPlatformStrategies::setURL):
1291
1292 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1293
1294         Disable cross-origin-window-policy by default
1295         https://bugs.webkit.org/show_bug.cgi?id=187509
1296
1297         Reviewed by Chris Dumez.
1298
1299         * WebView/WebPreferences.mm:
1300         (+[WebPreferences initialize]):
1301
1302 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1303
1304         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1305         https://bugs.webkit.org/show_bug.cgi?id=187425
1306         rdar://problem/39948240
1307
1308         Reviewed by Tim Horton.
1309
1310         * WebView/WebView.mm:
1311         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1312         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1313         a call in this method to setUseDarkAppearance.
1314         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1315         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1316         (-[WebView _updateDefaultAppearance]): Deleted.
1317         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1318
1319 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1320
1321         Shrink various loading-related enums to shrink CachedResource
1322         https://bugs.webkit.org/show_bug.cgi?id=187443
1323
1324         Reviewed by Chris Dumez.
1325
1326         * WebCoreSupport/WebFrameLoaderClient.mm:
1327         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1328         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1329         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1330         (WebFrameLoaderClient::dispatchWillSendRequest):
1331         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1332         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1333         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1334         (WebFrameLoaderClient::updateGlobalHistory):
1335         (WebFrameLoaderClient::canHandleRequest const):
1336         * WebView/WebDataSource.mm:
1337         (-[WebDataSource initialRequest]):
1338         (-[WebDataSource request]):
1339
1340 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1341
1342         Unreviewed, rolling out r233612.
1343         https://bugs.webkit.org/show_bug.cgi?id=187475
1344
1345         Revision caused the api test LinkColorWithSystemAppearance to
1346         fail on all systems. (Requested by Truitt on #webkit).
1347
1348         Reverted changeset:
1349
1350         "Semantic colors don't update when accessibility Increase
1351         Contrast mode is enabled."
1352         https://bugs.webkit.org/show_bug.cgi?id=187425
1353         https://trac.webkit.org/changeset/233612
1354
1355 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1356
1357         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1358         https://bugs.webkit.org/show_bug.cgi?id=187425
1359         rdar://problem/39948240
1360
1361         Reviewed by Tim Horton.
1362
1363         * WebView/WebView.mm:
1364         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1365         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1366         a call in this method to setUseDarkAppearance.
1367         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1368         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1369         (-[WebView _updateDefaultAppearance]): Deleted.
1370         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1371
1372 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1373
1374         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1375         https://bugs.webkit.org/show_bug.cgi?id=187369
1376         rdar://problem/41870420
1377
1378         Reviewed by Tim Horton.
1379
1380         * WebView/WebMediaPlaybackTargetPicker.mm:
1381         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1382         * WebView/WebView.mm:
1383         (-[WebView _commonInitializationWithFrameName:groupName:]):
1384         (-[WebView _effectiveAppearanceIsDark]):
1385         (-[WebView _updateDefaultAppearance]):
1386         (-[WebView _defaultAppearance]): Deleted.
1387
1388 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1389
1390         Youtube video pages crash after a couple of minutes
1391         https://bugs.webkit.org/show_bug.cgi?id=187316
1392
1393         Reviewed by Antti Koivisto.
1394
1395         * WebView/WebView.mm:
1396         (-[WebView _preferencesChanged:]):
1397
1398 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1399
1400         Introduce PLATFORM(IOSMAC)
1401         https://bugs.webkit.org/show_bug.cgi?id=187315
1402
1403         Reviewed by Dan Bernstein.
1404
1405         * Configurations/Base.xcconfig:
1406         * Configurations/FeatureDefines.xcconfig:
1407
1408 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1409
1410         [iOS] DataTransfer.getData always returns the empty string when dropping text
1411         https://bugs.webkit.org/show_bug.cgi?id=187130
1412         <rdar://problem/41014117>
1413
1414         Reviewed by Ryosuke Niwa.
1415
1416         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1417
1418         * WebCoreSupport/WebPlatformStrategies.h:
1419         * WebCoreSupport/WebPlatformStrategies.mm:
1420         (WebPlatformStrategies::allPasteboardItemInfo):
1421
1422 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1423
1424         [Mac] AirPlay picker uses incorrect theme in Dark mode
1425         https://bugs.webkit.org/show_bug.cgi?id=187054
1426         <rdar://problem/41291093>
1427
1428         Reviewed by Timothy Hatcher.
1429
1430         * WebView/WebMediaPlaybackTargetPicker.mm:
1431         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1432
1433 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1434
1435         [WTF] Add user-defined literal for ASCIILiteral
1436         https://bugs.webkit.org/show_bug.cgi?id=186839
1437
1438         Reviewed by Darin Adler.
1439
1440         * DOM/ExceptionHandlers.mm:
1441         (raiseDOMErrorException):
1442         * Plugins/Hosted/ProxyInstance.mm:
1443         (WebKit::ProxyInstance::invokeMethod):
1444         * Storage/WebDatabaseProvider.mm:
1445         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1446
1447 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1448
1449         Recalc styles every time defaultAppearance changes.
1450         https://bugs.webkit.org/show_bug.cgi?id=186866
1451         rdar://problem/41309805
1452
1453         Reviewed by Tim Horton.
1454
1455         * WebView/WebView.mm:
1456         (-[WebView _updateDefaultAppearance]):
1457         (-[WebView _setUseSystemAppearance:]):
1458         (-[WebView _useSystemAppearance]):
1459
1460 2018-06-20  Darin Adler  <darin@apple.com>
1461
1462         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1463         https://bugs.webkit.org/show_bug.cgi?id=186875
1464
1465         Reviewed by Anders Carlsson.
1466
1467         * WebView/WebHTMLView.mm:
1468         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1469         to write te file to.
1470         * WebView/WebPreferences.mm:
1471         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1472         * WebView/WebView.mm:
1473         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1474
1475 2018-06-12  Darin Adler  <darin@apple.com>
1476
1477         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1478         https://bugs.webkit.org/show_bug.cgi?id=186526
1479
1480         Reviewed by Anders Carlsson.
1481
1482         * Plugins/Hosted/NetscapePluginHostManager.mm:
1483         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1484
1485         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1486         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1487         assignment rather than adoptNS/leakRef.
1488         * Plugins/WebNetscapePluginView.mm:
1489         (-[WebNetscapePluginView createPlugin]): Ditto.
1490
1491         * WebCoreSupport/WebContextMenuClient.mm:
1492         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1493         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1494         argument, so use RetainPtr::get instead.
1495
1496         * WebView/WebHTMLView.mm:
1497         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1498         No need to autorelease the result when the return type is RetainPtr.
1499
1500         * WebView/WebPDFRepresentation.mm:
1501         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1502
1503 2018-06-13  Youenn Fablet  <youenn@apple.com>
1504
1505         Supported plugin check should be based on plugin identifier
1506         https://bugs.webkit.org/show_bug.cgi?id=186578
1507         <rdar://problem/40523828>
1508
1509         Reviewed by Darin Adler.
1510
1511         * WebCoreSupport/WebPluginInfoProvider.h:
1512         * WebCoreSupport/WebPluginInfoProvider.mm:
1513         (WebPluginInfoProvider::pluginInfo):
1514         (WebPluginInfoProvider::webVisiblePluginInfo):
1515
1516 2018-06-13  Chris Dumez  <cdumez@apple.com>
1517
1518         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1519         https://bugs.webkit.org/show_bug.cgi?id=186545
1520
1521         Reviewed by Brady Eidson.
1522
1523         Update client delegate now that parameter type has changed.
1524
1525         * WebCoreSupport/WebFrameLoaderClient.h:
1526         * WebCoreSupport/WebFrameLoaderClient.mm:
1527         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1528
1529 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1530
1531         Link drag image is inconsistently unreadable in dark mode
1532         https://bugs.webkit.org/show_bug.cgi?id=186472
1533
1534         Reviewed by Timothy Hatcher.
1535
1536         * WebView/WebView.mm:
1537         (-[WebView _defaultAppearance]):
1538         Make defaultAppearance accurate even if useSystemAppearance is false.
1539         Some parts of WebKit (like the link drag image, but also context menus)
1540         want to be able to follow the system appearance regardless of whether
1541         the view or content has opted in.
1542
1543 2018-06-11  Chris Dumez  <cdumez@apple.com>
1544
1545         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1546         https://bugs.webkit.org/show_bug.cgi?id=186441
1547
1548         Reviewed by Brady Eidson.
1549
1550         Rename existing flag to something a bit more generic, now that it is used for
1551         more things than bypassing the navigation policy check.
1552
1553         * WebView/WebView.mm:
1554         (-[WebView _loadBackForwardListFromOtherView:]):
1555         (-[WebView goToBackForwardItem:]):
1556
1557 2018-06-09  Dan Bernstein  <mitz@apple.com>
1558
1559         [Xcode] Clean up and modernize some build setting definitions
1560         https://bugs.webkit.org/show_bug.cgi?id=186463
1561
1562         Reviewed by Sam Weinig.
1563
1564         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1565         * Configurations/DebugRelease.xcconfig: Ditto.
1566         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1567           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1568         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1569         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1570           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1571         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1572
1573 2018-06-08  Darin Adler  <darin@apple.com>
1574
1575         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1576         https://bugs.webkit.org/show_bug.cgi?id=186436
1577
1578         Reviewed by Anders Carlsson.
1579
1580         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1581         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1582         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1583         (PoolCleaner): Ditto.
1584
1585         * History/WebHistory.mm:
1586         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1587         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1588         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1589         now hardly used if at all.
1590         * WebView/WebView.mm:
1591         (-[WebView rectsForTextMatches]): Ditto.
1592
1593 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1594
1595         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1596         https://bugs.webkit.org/show_bug.cgi?id=186442
1597         <rdar://problem/40879364>
1598
1599         Reviewed by Tim Horton.
1600
1601         * Configurations/FeatureDefines.xcconfig:
1602
1603 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1604
1605         [Datalist] Allow TextFieldInputType to show and hide suggestions
1606         https://bugs.webkit.org/show_bug.cgi?id=186151
1607
1608         Reviewed by Tim Horton.
1609
1610         * WebCoreSupport/WebChromeClient.h:
1611         * WebCoreSupport/WebChromeClient.mm:
1612         (WebChromeClient::createDataListSuggestionPicker):
1613
1614 2018-06-07  Chris Dumez  <cdumez@apple.com>
1615
1616         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1617         https://bugs.webkit.org/show_bug.cgi?id=186407
1618
1619         Reviewed by Brent Fulgham.
1620
1621         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1622         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1623         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1624         makeWeakPtr().
1625
1626         * WebCoreSupport/WebEditorClient.h:
1627         * WebCoreSupport/WebEditorClient.mm:
1628         (WebEditorClient::requestCandidatesForSelection):
1629
1630 2018-06-05  Chris Dumez  <cdumez@apple.com>
1631
1632         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1633         https://bugs.webkit.org/show_bug.cgi?id=186331
1634         <rdar://problem/40735446>
1635
1636         Reviewed by Darin Adler.
1637
1638         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1639         but does not call use / ignore on the listener, then we would do "use" by default.
1640         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1641         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1642         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1643         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1644         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1645         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
1646         and Box.app is still working properly.
1647
1648         * WebCoreSupport/WebFrameLoaderClient.h:
1649         * WebCoreSupport/WebFrameLoaderClient.mm:
1650         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1651         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1652         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1653         (WebFrameLoaderClient::dispatchWillSubmitForm):
1654         (WebFrameLoaderClient::setUpPolicyListener):
1655         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
1656         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
1657         (-[WebFramePolicyListener dealloc]):
1658         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
1659         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
1660
1661 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1662
1663         Adjust compile and runtime flags to match shippable state of features
1664         https://bugs.webkit.org/show_bug.cgi?id=186319
1665         <rdar://problem/40352045>
1666
1667         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1668
1669         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1670         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1671         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
1672         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1673         Cocoa builds.
1674
1675 2018-06-05  Timothy Hatcher  <timothy@apple.com>
1676
1677         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
1678
1679         https://bugs.webkit.org/show_bug.cgi?id=186323
1680         rdar://problem/38382252
1681
1682         Reviewed by Tim Horton.
1683
1684         * WebView/WebView.mm:
1685         (-[WebView _defaultAppearance]):
1686
1687 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1688
1689         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1690         https://bugs.webkit.org/show_bug.cgi?id=186286
1691         <rdar://problem/40782992>
1692
1693         Reviewed by Dan Bernstein.
1694
1695         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1696         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1697         change this flag when preparing for a production release.
1698
1699         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
1700         whether experimental features should be enabled, and use it to properly define the
1701         feature flag.
1702
1703 2018-06-03  Darin Adler  <darin@apple.com>
1704
1705         Simplify and remove some unused video element code (helpful for ARC-compatibility)
1706         https://bugs.webkit.org/show_bug.cgi?id=186258
1707
1708         Reviewed by Daniel Bates.
1709
1710         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
1711         forward declarations. Removed methods that don't need to be public.
1712
1713         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
1714         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
1715         unnamed category in here and also replaced the HUDWindowControllerDelegate
1716         with the unnamed category. Removed unused NSWindow category defining the
1717         isOnActiveSpace, which is not called anywhere in this file at this time.
1718         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
1719         into setVideoElement.
1720         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
1721         and removed unneeded typecast.
1722         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
1723         using statement at the top of the file.
1724         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
1725         the many side effects and special considerations that this method that sounds
1726         like a setter has. Updated code to use the new
1727         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
1728         HTMLVideoElement::platformMedia function. Also straightened out the logic a
1729         bit and added some FIXME comments about small problems noticed but not fixed.
1730         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
1731         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
1732         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
1733         typecast. Removed call to updatePowerAssertions method.
1734         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
1735         updatePowerAssertions method.
1736         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
1737         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
1738         else, so this was dead code that did nothing.
1739         (-[WebVideoFullscreenController rateChanged:]): Removed call to
1740         updatePowerAssertions method.
1741
1742 2018-06-04  Chris Dumez  <cdumez@apple.com>
1743
1744         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1745         https://bugs.webkit.org/show_bug.cgi?id=186287
1746         <rdar://problem/40783352>
1747
1748         Reviewed by Youenn Fablet.
1749
1750         * WebView/WebPreferenceKeysPrivate.h:
1751         * WebView/WebPreferences.mm:
1752         (+[WebPreferences initialize]):
1753         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
1754         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
1755         * WebView/WebPreferencesPrivate.h:
1756         * WebView/WebView.mm:
1757         (-[WebView _preferencesChanged:]):
1758
1759 2018-06-02  Darin Adler  <darin@apple.com>
1760
1761         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
1762         https://bugs.webkit.org/show_bug.cgi?id=186227
1763
1764         Reviewed by Dan Bernstein.
1765
1766         * Misc/WebKitErrors.m:
1767         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
1768         * Plugins/WebPluginDatabase.mm:
1769         (-[WebPluginDatabase refresh]): Ditto.
1770         * WebCoreSupport/WebChromeClient.mm:
1771         (WebChromeClient::setStatusbarText): Ditto.
1772
1773 2018-06-01  Chris Dumez  <cdumez@apple.com>
1774
1775         REGRESSION (r231456): Colloquy is broken
1776         https://bugs.webkit.org/show_bug.cgi?id=186197
1777         <rdar://problem/40722960>
1778
1779         Reviewed by Timothy Hatcher.
1780
1781         Restore pre-r231456 behavior for Colloquy app so that it works again.
1782
1783         * WebView/WebView.mm:
1784         (-[WebView _needsFrameNameFallbackToIdQuirk]):
1785         (-[WebView _preferencesChanged:]):
1786
1787 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1788
1789         [JSC] Pass VM& parameter as much as possible
1790         https://bugs.webkit.org/show_bug.cgi?id=186085
1791
1792         Reviewed by Saam Barati.
1793
1794         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1795         (WebKit::NetscapePluginInstanceProxy::invoke):
1796
1797 2018-05-30  Daniel Bates  <dabates@apple.com>
1798
1799         NavigationAction does not need to hold initiating DOM Event
1800         https://bugs.webkit.org/show_bug.cgi?id=185958
1801         <rdar://problem/40531539>
1802
1803         Reviewed by Simon Fraser.
1804
1805         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
1806
1807         * WebCoreSupport/WebFrameLoaderClient.mm:
1808         (WebFrameLoaderClient::actionDictionary const):
1809         (findMouseEvent): Deleted.
1810
1811 2018-05-27  Dan Bernstein  <mitz@apple.com>
1812
1813         Reverted the changes made for https://webkit.org/b/186016
1814
1815         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1816
1817
1818 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1819
1820         [iOS] Fix warnings about leaks found by clang static analyzer
1821         <https://webkit.org/b/186009>
1822         <rdar://problem/40574267>
1823
1824         Reviewed by Daniel Bates.
1825
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView doCommandBySelector:]): Fix use of an
1828         uninitialized boolean variable (`eventWasHandled`) that only
1829         happened on iOS.
1830
1831 2018-05-27  Dan Bernstein  <mitz@apple.com>
1832
1833         [Cocoa] Avoid importing directly from subumbrella frameworks
1834         https://bugs.webkit.org/show_bug.cgi?id=186016
1835
1836         Reviewed by Sam Weinig.
1837
1838         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1839         * Carbon/CarbonWindowAdapter.mm: Ditto.
1840         * Carbon/CarbonWindowFrame.m: Ditto.
1841         * Carbon/HIViewAdapter.h: Ditto.
1842         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
1843           OTHER_CPLUSPLUSFLAGS.
1844         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1845         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1846         * WebView/WebPDFView.h: Ditto.
1847
1848 2018-05-27  Sam Weinig  <sam@webkit.org>
1849
1850         Modernize RenderStyleConstants.h - Part 3
1851         https://bugs.webkit.org/show_bug.cgi?id=186015
1852
1853         Reviewed by Yusuke Suzuki.
1854
1855         * WebView/WebView.mm:
1856         (-[WebView updateTextTouchBar]):
1857         Update for new enum name.
1858
1859 2018-05-25  Chris Dumez  <cdumez@apple.com>
1860
1861         Minor ApplicationCacheStorage clean up
1862         https://bugs.webkit.org/show_bug.cgi?id=185984
1863
1864         Reviewed by Youenn Fablet.
1865
1866         * WebCoreSupport/WebApplicationCache.mm:
1867         (+[WebApplicationCache originsWithCache]):
1868
1869 2018-05-25  David Kilzer  <ddkilzer@apple.com>
1870
1871         Fix issues with -dealloc methods found by clang static analyzer
1872         <https://webkit.org/b/185887>
1873
1874         Reviewed by Joseph Pecoraro.
1875
1876         * WebView/WebView.mm:
1877         (-[WebUITextIndicatorData dealloc]):
1878         - Move method implementation from (WebUITextIndicatorInternal)
1879           category to the main category since this is public API.  This
1880           fixes the false positive warning about a missing -dealloc
1881           method.
1882
1883 2018-05-24  Sam Weinig  <sam@webkit.org>
1884
1885         Modernize RenderStyleConstants.h - Part 2
1886         https://bugs.webkit.org/show_bug.cgi?id=185901
1887
1888         Reviewed by Simon Fraser.
1889
1890         * WebView/WebHTMLRepresentation.mm:
1891         (searchForLabelsBeforeElement):
1892         * WebView/WebView.mm:
1893         (nsTextAlignmentFromRenderStyle):
1894         Update for new enum names.
1895
1896 2018-05-22  Chris Dumez  <cdumez@apple.com>
1897
1898         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1899         https://bugs.webkit.org/show_bug.cgi?id=185832
1900         <rdar://problem/40307871>
1901
1902         Reviewed by Geoffrey Garen.
1903
1904         We used to have a bug where where we would fail to wait for the policy decision for
1905         the navigation response from the client and the load would keep going, racing with
1906         the client's policy decision. If the client did not respond in time, the behavior
1907         would be the same as "Use" policy action.
1908
1909         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
1910         but the load happened to proceed anyway due to our bug. Now that we've fixed the
1911         WebKit bug, however, the load would hang because the completion handler for the
1912         decidePolicyForNavigationResponse would never get called.
1913
1914         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
1915         instead of retaining it. If the policy listener object gets destroyed because getting
1916         resolved, we now use "Use" policy action in its dealloc function to maintain previous
1917         behavior.
1918
1919         * WebCoreSupport/WebFrameLoaderClient.h:
1920         * WebCoreSupport/WebFrameLoaderClient.mm:
1921         (WebFrameLoaderClient::cancelPolicyCheck):
1922         (WebFrameLoaderClient::setUpPolicyListener):
1923         (-[WebFramePolicyListener dealloc]):
1924
1925 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1926
1927         Unreviewed, rolling out r232052.
1928
1929         Breaks internal builds.
1930
1931         Reverted changeset:
1932
1933         "Use more C++17"
1934         https://bugs.webkit.org/show_bug.cgi?id=185176
1935         https://trac.webkit.org/changeset/232052
1936
1937 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1938
1939         Use more C++17
1940         https://bugs.webkit.org/show_bug.cgi?id=185176
1941
1942         Reviewed by JF Bastien.
1943
1944         * Configurations/Base.xcconfig:
1945         * Configurations/WebKitLegacy.xcconfig:
1946
1947 2018-05-21  Chris Nardi  <cnardi@chromium.org>
1948
1949         Remove dead exception in MediaList.appendMedium
1950         https://bugs.webkit.org/show_bug.cgi?id=185278
1951
1952         Reviewed by Chris Dumez.
1953
1954         Remove code pertaining to an exception being thrown by appendMedium().
1955
1956         * DOM/DOMMediaList.mm:
1957         (-[DOMMediaList appendMedium:]):
1958
1959 2018-05-21  Jer Noble  <jer.noble@apple.com>
1960
1961         Complete fix for enabling modern EME by default
1962         https://bugs.webkit.org/show_bug.cgi?id=185770
1963         <rdar://problem/40368220>
1964
1965         Reviewed by Eric Carlson.
1966
1967         * Configurations/FeatureDefines.xcconfig:
1968
1969 2018-05-21  Antti Koivisto  <antti@apple.com>
1970
1971         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
1972         https://bugs.webkit.org/show_bug.cgi?id=185815
1973         <rdar://problem/40310069>
1974
1975         Reviewed by Simon Fraser.
1976
1977         User stylesheet parsing may depend on the colorFilterEnabled preference.
1978
1979         * WebView/WebView.mm:
1980         (-[WebView _preferencesChanged:]):
1981
1982 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1983
1984         Unreviewed, rolling out r231982.
1985         https://bugs.webkit.org/show_bug.cgi?id=185793
1986
1987         Caused layout test failures (Requested by realdawei on
1988         #webkit).
1989
1990         Reverted changeset:
1991
1992         "Complete fix for enabling modern EME by default"
1993         https://bugs.webkit.org/show_bug.cgi?id=185770
1994         https://trac.webkit.org/changeset/231982
1995
1996 2018-05-18  Jer Noble  <jer.noble@apple.com>
1997
1998         Complete fix for enabling modern EME by default
1999         https://bugs.webkit.org/show_bug.cgi?id=185770
2000         <rdar://problem/40368220>
2001
2002         Reviewed by Eric Carlson.
2003
2004         * Configurations/FeatureDefines.xcconfig:
2005
2006 2018-05-18  Chris Dumez  <cdumez@apple.com>
2007
2008         Avoid keeping the frame alive when ref'ing a WindowProxy
2009         https://bugs.webkit.org/show_bug.cgi?id=185737
2010         <rdar://problem/40004666>
2011
2012         Reviewed by Sam Weinig.
2013
2014         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2015         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2016
2017 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2018
2019         Add support for Intl NumberFormat formatToParts
2020         https://bugs.webkit.org/show_bug.cgi?id=185375
2021
2022         Reviewed by Yusuke Suzuki.
2023
2024         Add flag for NumberFormat formatToParts.
2025
2026         * Configurations/FeatureDefines.xcconfig:
2027
2028 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2029
2030         Fixup after r231849: Do not mark Mac API methods as deprecated
2031         https://bugs.webkit.org/show_bug.cgi?id=185684
2032
2033         Reviewed by Darin Adler.
2034
2035         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2036         as the entire class is already marked as deprecated, so it is unnecessary.
2037
2038         * DOM/DOMDocument.h:
2039
2040 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2041
2042         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2043         https://bugs.webkit.org/show_bug.cgi?id=185381
2044
2045         Reviewed by Darin Adler.
2046
2047         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2048         and make them do nothing.
2049
2050         * DOM/DOMDocument.h:
2051         * DOM/DOMDocument.mm:
2052         (-[DOMDocument preferredStylesheetSet]):
2053         (-[DOMDocument selectedStylesheetSet]):
2054         (-[DOMDocument setSelectedStylesheetSet:]):
2055
2056 2018-05-15  Antoine Quint  <graouts@apple.com>
2057
2058         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2059         https://bugs.webkit.org/show_bug.cgi?id=185647
2060
2061         Reviewed by Dean Jackson.
2062
2063         Rename the Web Animations CSS integration flag.
2064
2065         * WebView/WebPreferenceKeysPrivate.h:
2066         * WebView/WebPreferences.mm:
2067         (+[WebPreferences initialize]):
2068         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2069         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2070         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2071         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2072         * WebView/WebPreferencesPrivate.h:
2073         * WebView/WebView.mm:
2074         (-[WebView _preferencesChanged:]):
2075
2076 2018-05-14  Daniel Bates  <dabates@apple.com>
2077
2078         Fix the Apple Internal build
2079
2080         See <rdar://problem/40237873> for more details.
2081
2082         * WebView/WebFullScreenController.mm:
2083         (-[WebFullScreenController enterFullScreen:]):
2084         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2085         (-[WebFullScreenController exitFullScreen]):
2086         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2087         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2088         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2089
2090 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2091
2092         WebHTMLView is not setting aside subviews when drawing.
2093
2094         https://bugs.webkit.org/show_bug.cgi?id=185561
2095         rdar://problem/40172894
2096
2097         Reviewed by Simon Fraser.
2098
2099         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2100
2101         * WebView/WebHTMLView.mm:
2102         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2103
2104 2018-05-07  Daniel Bates  <dabates@apple.com>
2105
2106         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2107         https://bugs.webkit.org/show_bug.cgi?id=185170
2108
2109         Reviewed by Per Arne Vollan.
2110
2111         * Misc/WebCache.mm:
2112         (+[WebCache empty]):
2113
2114 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2115
2116         Deprecate legacy WebView and friends
2117         https://bugs.webkit.org/show_bug.cgi?id=185279
2118         rdar://problem/33268700
2119
2120         Reviewed by Tim Horton.
2121
2122         Added deprecation macros to all the classes, extern strings, and enums.
2123
2124         * Configurations/WebKitLegacy.xcconfig:
2125         Added BUILDING_WEBKIT define to disable the deprecation macros.
2126         * DOM/DOMAbstractView.h:
2127         * DOM/DOMAttr.h:
2128         * DOM/DOMBlob.h:
2129         * DOM/DOMCDATASection.h:
2130         * DOM/DOMCSSCharsetRule.h:
2131         * DOM/DOMCSSFontFaceRule.h:
2132         * DOM/DOMCSSImportRule.h:
2133         * DOM/DOMCSSMediaRule.h:
2134         * DOM/DOMCSSPageRule.h:
2135         * DOM/DOMCSSPrimitiveValue.h:
2136         * DOM/DOMCSSRule.h:
2137         * DOM/DOMCSSRuleList.h:
2138         * DOM/DOMCSSStyleDeclaration.h:
2139         * DOM/DOMCSSStyleRule.h:
2140         * DOM/DOMCSSStyleSheet.h:
2141         * DOM/DOMCSSUnknownRule.h:
2142         * DOM/DOMCSSValue.h:
2143         * DOM/DOMCSSValueList.h:
2144         * DOM/DOMCharacterData.h:
2145         * DOM/DOMComment.h:
2146         * DOM/DOMCounter.h:
2147         * DOM/DOMDocument.h:
2148         * DOM/DOMDocumentFragment.h:
2149         * DOM/DOMDocumentType.h:
2150         * DOM/DOMElement.h:
2151         * DOM/DOMEntity.h:
2152         * DOM/DOMEntityReference.h:
2153         * DOM/DOMEvent.h:
2154         * DOM/DOMEventException.h:
2155         * DOM/DOMEventListener.h:
2156         * DOM/DOMEventTarget.h:
2157         * DOM/DOMException.h:
2158         * DOM/DOMFile.h:
2159         * DOM/DOMFileList.h:
2160         * DOM/DOMHTMLAnchorElement.h:
2161         * DOM/DOMHTMLAppletElement.h:
2162         * DOM/DOMHTMLAreaElement.h:
2163         * DOM/DOMHTMLBRElement.h:
2164         * DOM/DOMHTMLBaseElement.h:
2165         * DOM/DOMHTMLBaseFontElement.h:
2166         * DOM/DOMHTMLBodyElement.h:
2167         * DOM/DOMHTMLButtonElement.h:
2168         * DOM/DOMHTMLCanvasElement.h:
2169         * DOM/DOMHTMLCollection.h:
2170         * DOM/DOMHTMLDListElement.h:
2171         * DOM/DOMHTMLDirectoryElement.h:
2172         * DOM/DOMHTMLDivElement.h:
2173         * DOM/DOMHTMLDocument.h:
2174         * DOM/DOMHTMLElement.h:
2175         * DOM/DOMHTMLEmbedElement.h:
2176         * DOM/DOMHTMLFieldSetElement.h:
2177         * DOM/DOMHTMLFontElement.h:
2178         * DOM/DOMHTMLFormElement.h:
2179         * DOM/DOMHTMLFrameElement.h:
2180         * DOM/DOMHTMLFrameSetElement.h:
2181         * DOM/DOMHTMLHRElement.h:
2182         * DOM/DOMHTMLHeadElement.h:
2183         * DOM/DOMHTMLHeadingElement.h:
2184         * DOM/DOMHTMLHtmlElement.h:
2185         * DOM/DOMHTMLIFrameElement.h:
2186         * DOM/DOMHTMLImageElement.h:
2187         * DOM/DOMHTMLInputElement.h:
2188         * DOM/DOMHTMLLIElement.h:
2189         * DOM/DOMHTMLLabelElement.h:
2190         * DOM/DOMHTMLLegendElement.h:
2191         * DOM/DOMHTMLLinkElement.h:
2192         * DOM/DOMHTMLMapElement.h:
2193         * DOM/DOMHTMLMarqueeElement.h:
2194         * DOM/DOMHTMLMediaElement.h:
2195         * DOM/DOMHTMLMenuElement.h:
2196         * DOM/DOMHTMLMetaElement.h:
2197         * DOM/DOMHTMLModElement.h:
2198         * DOM/DOMHTMLOListElement.h:
2199         * DOM/DOMHTMLObjectElement.h:
2200         * DOM/DOMHTMLOptGroupElement.h:
2201         * DOM/DOMHTMLOptionElement.h:
2202         * DOM/DOMHTMLOptionsCollection.h:
2203         * DOM/DOMHTMLParagraphElement.h:
2204         * DOM/DOMHTMLParamElement.h:
2205         * DOM/DOMHTMLPreElement.h:
2206         * DOM/DOMHTMLQuoteElement.h:
2207         * DOM/DOMHTMLScriptElement.h:
2208         * DOM/DOMHTMLSelectElement.h:
2209         * DOM/DOMHTMLStyleElement.h:
2210         * DOM/DOMHTMLTableCaptionElement.h:
2211         * DOM/DOMHTMLTableCellElement.h:
2212         * DOM/DOMHTMLTableColElement.h:
2213         * DOM/DOMHTMLTableElement.h:
2214         * DOM/DOMHTMLTableRowElement.h:
2215         * DOM/DOMHTMLTableSectionElement.h:
2216         * DOM/DOMHTMLTextAreaElement.h:
2217         * DOM/DOMHTMLTitleElement.h:
2218         * DOM/DOMHTMLUListElement.h:
2219         * DOM/DOMHTMLVideoElement.h:
2220         * DOM/DOMImplementation.h:
2221         * DOM/DOMKeyboardEvent.h:
2222         * DOM/DOMMediaError.h:
2223         * DOM/DOMMediaList.h:
2224         * DOM/DOMMouseEvent.h:
2225         * DOM/DOMMutationEvent.h:
2226         * DOM/DOMNamedNodeMap.h:
2227         * DOM/DOMNode.h:
2228         * DOM/DOMNodeFilter.h:
2229         * DOM/DOMNodeIterator.h:
2230         * DOM/DOMNodeList.h:
2231         * DOM/DOMObject.h:
2232         * DOM/DOMOverflowEvent.h:
2233         * DOM/DOMProcessingInstruction.h:
2234         * DOM/DOMProgressEvent.h:
2235         * DOM/DOMRGBColor.h:
2236         * DOM/DOMRange.h:
2237         * DOM/DOMRangeException.h:
2238         * DOM/DOMRect.h:
2239         * DOM/DOMStyleSheet.h:
2240         * DOM/DOMStyleSheetList.h:
2241         * DOM/DOMText.h:
2242         * DOM/DOMTextEvent.h:
2243         * DOM/DOMTimeRanges.h:
2244         * DOM/DOMTokenList.h:
2245         * DOM/DOMTreeWalker.h:
2246         * DOM/DOMUIEvent.h:
2247         * DOM/DOMWheelEvent.h:
2248         * DOM/DOMXPathException.h:
2249         * DOM/DOMXPathExpression.h:
2250         * DOM/DOMXPathNSResolver.h:
2251         * DOM/DOMXPathResult.h:
2252         * History/WebBackForwardList.h:
2253         * History/WebHistory.h:
2254         * History/WebHistoryItem.h:
2255         * Misc/WebDownload.h:
2256         * Misc/WebKitErrors.h:
2257         * Plugins/WebPluginViewFactory.h:
2258         * WebView/WebArchive.h:
2259         * WebView/WebDataSource.h:
2260         * WebView/WebDocument.h:
2261         * WebView/WebEditingDelegate.h:
2262         * WebView/WebFormDelegate.h:
2263         * WebView/WebFrame.h:
2264         * WebView/WebFrameLoadDelegate.h:
2265         * WebView/WebFrameView.h:
2266         * WebView/WebPolicyDelegate.h:
2267         * WebView/WebPreferences.h:
2268         * WebView/WebPreferencesPrivate.h:
2269         * WebView/WebResourceLoadDelegate.h:
2270         * WebView/WebUIDelegate.h:
2271         * WebView/WebUIDelegatePrivate.h:
2272         * WebView/WebView.h:
2273         * WebView/WebViewPrivate.h:
2274         * postprocess-headers.sh:
2275         Remove step that converts WEBKIT macros to NS macros.
2276         Change it to just remove the macros on iOS builds.
2277
2278 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2279
2280         [MediaStream] remove WK1 support
2281         https://bugs.webkit.org/show_bug.cgi?id=185136
2282
2283         Reviewed by Youenn Fablet.
2284
2285         * WebCoreSupport/WebUserMediaClient.h: Removed.
2286         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2287         * WebView/WebView.mm:
2288         (-[WebView _commonInitializationWithFrameName:groupName:]):
2289         (-[WebView _preferencesChanged:]):
2290         (-[WebView _setUserMediaClient:]): Deleted.
2291         (-[WebView _userMediaClient]): Deleted.
2292         * WebView/WebViewData.h:
2293         * WebView/WebViewPrivate.h:
2294
2295 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2296
2297         WebAssembly: add support for stream APIs - JavaScript API
2298         https://bugs.webkit.org/show_bug.cgi?id=183442
2299
2300         Reviewed by Yusuke Suzuki and JF Bastien.
2301
2302         Add WEBASSEMBLY_STREAMINNG_API feature flag
2303
2304         * Configurations/FeatureDefines.xcconfig:
2305
2306 2018-04-30  JF Bastien  <jfbastien@apple.com>
2307
2308         Use some C++17 features
2309         https://bugs.webkit.org/show_bug.cgi?id=185135
2310
2311         Reviewed by Alex Christensen.
2312
2313         * Configurations/WebKitLegacy.xcconfig:
2314
2315 2018-04-27  Chris Dumez  <cdumez@apple.com>
2316
2317         Use WindowProxy instead of DOMWindow in our IDL
2318         https://bugs.webkit.org/show_bug.cgi?id=185022
2319
2320         Reviewed by Sam Weinig.
2321
2322         * DOM/DOMAbstractView.mm:
2323         (kit):
2324         (toWindowProxy):
2325         * DOM/DOMAbstractViewInternal.h:
2326         * DOM/DOMDocument.mm:
2327         (-[DOMDocument defaultView]):
2328         (-[DOMDocument getComputedStyle:pseudoElement:]):
2329         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2330         * DOM/DOMHTMLFrameElement.mm:
2331         (-[DOMHTMLFrameElement contentWindow]):
2332         * DOM/DOMHTMLIFrameElement.mm:
2333         (-[DOMHTMLIFrameElement contentWindow]):
2334         * DOM/DOMKeyboardEvent.mm:
2335         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2336         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2337         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2338         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2339         * DOM/DOMMouseEvent.mm:
2340         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2341         * DOM/DOMTextEvent.mm:
2342         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2343         * DOM/DOMUIEvent.mm:
2344         (-[DOMUIEvent view]):
2345         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2346         * DOM/DOMWheelEvent.mm:
2347         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2348
2349 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2350
2351         Implement rendering support for the color-filter CSS property
2352         https://bugs.webkit.org/show_bug.cgi?id=185047
2353         rdar://problem/39664967
2354
2355         Reviewed by Tim Horton.
2356         
2357         The body background should reflect the filtered color.
2358
2359         * WebView/WebFrame.mm:
2360         (-[WebFrame _bodyBackgroundColor]):
2361         * WebView/WebView.mm:
2362         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2363
2364 2018-04-26  Jer Noble  <jer.noble@apple.com>
2365
2366         WK_COCOA_TOUCH all the things.
2367         https://bugs.webkit.org/show_bug.cgi?id=185006
2368
2369         Reviewed by Tim Horton.
2370
2371         * Configurations/WebKitLegacy.xcconfig:
2372
2373 2018-04-26  Daniel Bates  <dabates@apple.com>
2374
2375         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2376         https://bugs.webkit.org/show_bug.cgi?id=184161
2377         <rdar://problem/39051645>
2378
2379         Reviewed by Dan Bernstein.
2380
2381         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2382         dropping a PDF embedded using an HTML image element into the same web view.
2383
2384         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2385         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2386         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2387         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2388         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2389         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2390         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2391         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2392         image document when navigated to directly. Since we can support dragging PDF document images we need to
2393         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2394         We need to do both such queries before falling back to using the main resource of the Web Archive as
2395         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2396         not an image document.
2397
2398         * Misc/WebNSPasteboardExtras.mm:
2399         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2400
2401 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2402
2403         Disable content filtering in minimal simulator mode
2404         https://bugs.webkit.org/show_bug.cgi?id=185027
2405         <rdar://problem/39736091>
2406
2407         Reviewed by Jer Noble.
2408
2409         * Configurations/FeatureDefines.xcconfig:
2410
2411 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2412
2413         [INTL] Implement Intl.PluralRules
2414         https://bugs.webkit.org/show_bug.cgi?id=184312
2415
2416         Reviewed by JF Bastien.
2417
2418         Added Intl.PluralRules feature flag.
2419
2420         * Configurations/FeatureDefines.xcconfig:
2421
2422 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2423
2424         Remove access to keychain from the WebContent process
2425         https://bugs.webkit.org/show_bug.cgi?id=184428
2426         <rdar://problem/13150903>
2427
2428         Reviewed by Brent Fulgham.
2429
2430         This patch does the followings:
2431         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2432         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2433         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2434
2435         * WebCoreSupport/WebChromeClient.h:
2436         * WebCoreSupport/WebChromeClient.mm:
2437         (WebChromeClient::signedPublicKeyAndChallengeString const):
2438         * WebView/WebUIDelegatePrivate.h:
2439
2440 2018-04-24  Jer Noble  <jer.noble@apple.com>
2441
2442         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2443         https://bugs.webkit.org/show_bug.cgi?id=184786
2444
2445         Reviewed by Tim Horton.
2446
2447         * Configurations/WebKitLegacy.xcconfig:
2448         * MigrateHeaders.make:
2449
2450 2018-04-23  Daniel Bates  <dabates@apple.com>
2451
2452         Implement Same-Site cookies
2453         https://bugs.webkit.org/show_bug.cgi?id=159464
2454         <rdar://problem/27196358>
2455
2456         Reviewed by Brent Fulgham.
2457
2458         Pass the Same-Site info through the strategy.
2459
2460         * WebCoreSupport/WebPlatformStrategies.h:
2461         * WebCoreSupport/WebPlatformStrategies.mm:
2462         (WebPlatformStrategies::cookiesForDOM):
2463         (WebPlatformStrategies::setCookiesFromDOM):
2464         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2465         (WebPlatformStrategies::getRawCookies):
2466
2467 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2468
2469         [LayoutFormattingContext] Initial commit.
2470         https://bugs.webkit.org/show_bug.cgi?id=184896
2471
2472         Reviewed by Antti Koivisto.
2473
2474         * Configurations/FeatureDefines.xcconfig:
2475
2476 2018-04-23  Daniel Bates  <dabates@apple.com>
2477
2478         Implement Same-Site cookies
2479         https://bugs.webkit.org/show_bug.cgi?id=159464
2480         <rdar://problem/27196358>
2481
2482         Reviewed by Brent Fulgham.
2483
2484         Pass the Same-Site info through the strategy.
2485
2486         * WebCoreSupport/WebPlatformStrategies.h:
2487         * WebCoreSupport/WebPlatformStrategies.mm:
2488         (WebPlatformStrategies::cookiesForDOM):
2489         (WebPlatformStrategies::setCookiesFromDOM):
2490         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2491         (WebPlatformStrategies::getRawCookies):
2492
2493 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2494
2495         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2496
2497         https://bugs.webkit.org/show_bug.cgi?id=184851
2498         rdar://problem/39611236
2499
2500         Reviewed by Tim Horton.
2501
2502         * WebView/WebView.mm:
2503         (-[WebView _commonInitializationWithFrameName:groupName:]):
2504         (-[WebView effectiveAppearanceDidChange]):
2505         Added a null check and call the code later in initialization.
2506
2507 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2508
2509         Adjust geolocation feature flag
2510         https://bugs.webkit.org/show_bug.cgi?id=184856
2511
2512         Reviewed by Wenson Hsieh.
2513
2514         * Configurations/FeatureDefines.xcconfig:
2515
2516 2018-04-18  Jer Noble  <jer.noble@apple.com>
2517
2518         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2519         https://bugs.webkit.org/show_bug.cgi?id=184762
2520
2521         Reviewed by Dan Bernstein.
2522
2523         * Configurations/WebKitLegacy.xcconfig:
2524
2525 2018-04-20  Youenn Fablet  <youenn@apple.com>
2526
2527         Make PluginData cache its web visible plugins
2528         https://bugs.webkit.org/show_bug.cgi?id=184421
2529
2530         Reviewed by Chris Dumez.
2531
2532         * WebCoreSupport/WebPluginInfoProvider.h:
2533         * WebCoreSupport/WebPluginInfoProvider.mm:
2534         (WebPluginInfoProvider::pluginInfo):
2535         (WebPluginInfoProvider::webVisiblePluginInfo):
2536
2537 2018-04-19  Chris Dumez  <cdumez@apple.com>
2538
2539         Rename JSDOMWindowProxy to JSWindowProxy
2540         https://bugs.webkit.org/show_bug.cgi?id=184797
2541
2542         Reviewed by Sam Weinig.
2543
2544         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2545
2546         * DOM/DOMUtility.mm:
2547         (createDOMWrapper):
2548         * WebView/WebFrame.mm:
2549         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2550
2551 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2552
2553         Enable Objective-C weak references
2554         <https://webkit.org/b/184789>
2555         <rdar://problem/39571716>
2556
2557         Reviewed by Dan Bernstein.
2558
2559         * Configurations/Base.xcconfig:
2560         (CLANG_ENABLE_OBJC_WEAK): Enable.
2561
2562 2018-04-18  Chris Dumez  <cdumez@apple.com>
2563
2564         Rename WindowProxyController to WindowProxy
2565         https://bugs.webkit.org/show_bug.cgi?id=184756
2566
2567         Reviewed by Sam Weinig.
2568
2569         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2570         needed use WindowProxyController type, which was a bit confusing.
2571
2572         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2573         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2574         * WebView/WebFrame.mm:
2575         (-[WebFrame _attachScriptDebugger]):
2576
2577 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2578
2579         Unreviewed rollout of r230632. Regression in memory usage.
2580
2581         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2582
2583         * WebView/WebPreferences.mm:
2584         (+[WebPreferences initialize]):
2585
2586 2018-04-17  Chris Dumez  <cdumez@apple.com>
2587
2588         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2589         https://bugs.webkit.org/show_bug.cgi?id=184678
2590         <rdar://problem/39422122>
2591
2592         Reviewed by Alex Christensen.
2593
2594         Add new parameter to dispatchDecidePolicyForNavigationAction.
2595
2596         * WebCoreSupport/WebFrameLoaderClient.h:
2597         * WebCoreSupport/WebFrameLoaderClient.mm:
2598         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2599
2600 2018-04-13  Chris Dumez  <cdumez@apple.com>
2601
2602         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2603         https://bugs.webkit.org/show_bug.cgi?id=184591
2604
2605         Reviewed by Sam Weinig.
2606
2607         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2608         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2609         This is work towards fixing Bug 184515.
2610
2611         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2612         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2613         * WebView/WebFrame.mm:
2614         (-[WebFrame _attachScriptDebugger]):
2615
2616 2018-04-12  Antoine Quint  <graouts@apple.com>
2617
2618         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2619         https://bugs.webkit.org/show_bug.cgi?id=184569
2620         <rdar://problem/38671301>
2621
2622         Reviewed by Jon Lee.
2623
2624         * WebView/WebPreferences.mm:
2625
2626 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2627
2628         [WTF] Remove StaticLock
2629         https://bugs.webkit.org/show_bug.cgi?id=184332
2630
2631         Reviewed by Mark Lam.
2632
2633         * DOM/DOMInternal.mm:
2634         (getDOMWrapper):
2635         (addDOMWrapper):
2636         (removeDOMWrapper):
2637
2638 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2639
2640         Failures from mach port reference handling should be fatal
2641         https://bugs.webkit.org/show_bug.cgi?id=184202
2642         <rdar://problem/37771114>
2643
2644         Reviewed by Anders Carlsson.
2645
2646         * Plugins/Hosted/NetscapePluginHostManager.mm:
2647         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
2648
2649 2018-04-03  Andy Estes  <aestes@apple.com>
2650
2651         [Mac] Prioritize file promises over filenames during drag and drop
2652         https://bugs.webkit.org/show_bug.cgi?id=184237
2653         <rdar://problem/38278076>
2654
2655         Reviewed by Wenson Hsieh.
2656
2657         * WebView/WebView.mm:
2658         (-[WebView performDragOperation:]):
2659
2660 2018-04-03  Chris Dumez  <cdumez@apple.com>
2661
2662         Drop MainFrame class
2663         https://bugs.webkit.org/show_bug.cgi?id=184191
2664
2665         Reviewed by Darin Adler.
2666
2667         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2668         relationship between the Page and the MainFrame.
2669
2670         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2671
2672         * WebCoreSupport/WebDragClient.mm:
2673         * WebCoreSupport/WebFrameLoaderClient.mm:
2674         * WebCoreSupport/WebInspectorClient.mm:
2675         * WebCoreSupport/WebPlatformStrategies.mm:
2676         * WebCoreSupport/WebPluginInfoProvider.mm:
2677         * WebView/WebFrame.mm:
2678         * WebView/WebFrameView.mm:
2679         * WebView/WebHTMLView.mm:
2680         * WebView/WebView.mm:
2681
2682 2018-04-02  Jer Noble  <jer.noble@apple.com>
2683
2684         Enable Legacy EME for all WebKit & WebKitLegacy clients
2685         https://bugs.webkit.org/show_bug.cgi?id=184018
2686         <rdar://problem/34887387>
2687
2688         Reviewed by Eric Carlson.
2689
2690         * WebView/WebPreferences.mm:
2691         (+[WebPreferences initialize]):
2692
2693 2018-03-29  JF Bastien  <jfbastien@apple.com>
2694
2695         Use Forward.h instead of forward-declaring WTF::String
2696         https://bugs.webkit.org/show_bug.cgi?id=184172
2697         <rdar://problem/39026146>
2698
2699         Reviewed by Yusuke Suzuki.
2700
2701         As part of #184164 I'm changing WTF::String, and the forward
2702         declarations are just wrong because I'm making it templated. We
2703         should use Forward.h anyways, so do that instead.
2704
2705         * WebView/WebScriptDebugger.h:
2706
2707 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2708
2709         Protect against invalid mach ports returned by mach_port_request_notification
2710         https://bugs.webkit.org/show_bug.cgi?id=184106
2711         <rdar://problem/37865316>
2712
2713         Reviewed by Chris Dumez.
2714
2715         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2716         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
2717         and clean up if it experienced an error.
2718         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
2719
2720 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2721
2722         Avoid uninitialized mach ports
2723         https://bugs.webkit.org/show_bug.cgi?id=184090
2724         <rdar://problem/37261129>
2725
2726         Reviewed by Chris Dumez.
2727
2728         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
2729         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
2730         there is a potential for us to try to use invalid ports.
2731
2732         We should always check return values, and ensure that the mach port variables we seek to initialize are
2733         kept in a valid state.
2734
2735         Reviewed by Chris Dumez.
2736
2737         * Plugins/Hosted/NetscapePluginHostManager.h:
2738         * Plugins/Hosted/NetscapePluginHostManager.mm:
2739         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
2740         port is passed to an API function.
2741         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
2742         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
2743         * Plugins/Hosted/NetscapePluginHostProxy.h:
2744         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2745         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
2746         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
2747         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
2748         (WKPCStatusText): Ditto.
2749         (WKPCLoadURL): Ditto.
2750         (WKPCCancelLoadURL): Ditto.
2751         (WKPCInvalidateRect): Ditto.
2752         (WKPCGetScriptableNPObjectReply): Ditto.
2753         (WKPCBooleanReply): Ditto.
2754         (WKPCBooleanAndDataReply): Ditto.
2755         (WKPCInstantiatePluginReply): Ditto.
2756         (WKPCGetWindowNPObject): Ditto.
2757         (WKPCGetPluginElementNPObject): Ditto.
2758         (WKPCForgetBrowserObject): Ditto.
2759         (WKPCEvaluate): Ditto.
2760         (WKPCGetStringIdentifier): Ditto.
2761         (WKPCGetIntIdentifier): Ditto.
2762         (WKPCInvoke): Ditto.
2763         (WKPCInvokeDefault): Ditto.
2764         (WKPCConstruct): Ditto.
2765         (WKPCGetProperty): Ditto.
2766         (WKPCSetProperty): Ditto.
2767         (WKPCRemoveProperty): Ditto.
2768         (WKPCHasProperty): Ditto.
2769         (WKPCHasMethod): Ditto.
2770         (WKPCIdentifierInfo): Ditto.
2771         (WKPCEnumerate): Ditto.
2772         (WKPCSetMenuBarVisible): Ditto.
2773         (WKPCSetFullscreenWindowIsShowing): Ditto.
2774         (WKPCSetModal): Ditto.
2775         (WKPCGetCookies): Ditto.
2776         (WKPCGetProxy): Ditto.
2777         (WKPCSetCookies): Ditto.
2778         (WKPCGetAuthenticationInfo): Ditto.
2779         (WKPCConvertPoint): Ditto.
2780         (WKPCLayerHostingModeChanged): Ditto.
2781         (WKPCSetException): Ditto.
2782
2783 2018-03-26  Tim Horton  <timothy_horton@apple.com>
2784
2785         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
2786         https://bugs.webkit.org/show_bug.cgi?id=184030
2787         <rdar://problem/38895281>
2788
2789         Reviewed by Dan Bernstein.
2790
2791         * Configurations/Base.xcconfig:
2792
2793 2018-03-26  Chris Dumez  <cdumez@apple.com>
2794
2795         Use SecurityOriginData more consistently in Service Worker code
2796         https://bugs.webkit.org/show_bug.cgi?id=183969
2797
2798         Reviewed by Darin Adler.
2799
2800         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2801
2802         * Storage/WebDatabaseManager.mm:
2803         (-[WebDatabaseManager databasesWithOrigin:]):
2804         (-[WebDatabaseManager deleteOrigin:]):
2805         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2806         * Storage/WebDatabaseQuotaManager.mm:
2807         (-[WebDatabaseQuotaManager usage]):
2808         (-[WebDatabaseQuotaManager quota]):
2809         (-[WebDatabaseQuotaManager setQuota:]):
2810         * Storage/WebStorageManager.mm:
2811         (-[WebStorageManager deleteOrigin:]):
2812         * WebCoreSupport/WebSecurityOrigin.mm:
2813         (-[WebSecurityOrigin databaseIdentifier]):
2814         (-[WebSecurityOrigin usage]):
2815         (-[WebSecurityOrigin quota]):
2816         (-[WebSecurityOrigin setQuota:]):
2817
2818 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2819
2820         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2821         https://bugs.webkit.org/show_bug.cgi?id=183911
2822         <rdar://problem/38762306>
2823
2824         Reviewed by Youenn Fablet.
2825
2826         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2827
2828         * WebView/WebView.mm:
2829         (+[WebView initialize]):
2830
2831 2018-03-26  Alex Christensen  <achristensen@webkit.org>
2832
2833         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
2834         https://bugs.webkit.org/show_bug.cgi?id=183965
2835
2836         Reviewed by Chris Dumez.
2837
2838         * WebCoreSupport/WebFrameLoaderClient.h:
2839         * WebCoreSupport/WebFrameLoaderClient.mm:
2840         (WebFrameLoaderClient::willCacheResponse const):
2841
2842 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2843
2844         Unreviewed, rolling out r229954.
2845         https://bugs.webkit.org/show_bug.cgi?id=184000
2846
2847         Caused many layout tests to crash on Apple High Sierra,
2848         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2849         by dydz on #webkit).
2850
2851         Reverted changeset:
2852
2853         "Use SecurityOriginData more consistently in Service Worker
2854         code"
2855         https://bugs.webkit.org/show_bug.cgi?id=183969
2856         https://trac.webkit.org/changeset/229954
2857
2858 2018-03-24  Chris Dumez  <cdumez@apple.com>
2859
2860         Use SecurityOriginData more consistently in Service Worker code
2861         https://bugs.webkit.org/show_bug.cgi?id=183969
2862
2863         Reviewed by Darin Adler.
2864
2865         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2866
2867         * Storage/WebDatabaseManager.mm:
2868         (-[WebDatabaseManager databasesWithOrigin:]):
2869         (-[WebDatabaseManager deleteOrigin:]):
2870         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2871         * Storage/WebDatabaseQuotaManager.mm:
2872         (-[WebDatabaseQuotaManager usage]):
2873         (-[WebDatabaseQuotaManager quota]):
2874         (-[WebDatabaseQuotaManager setQuota:]):
2875         * Storage/WebStorageManager.mm:
2876         (-[WebStorageManager deleteOrigin:]):
2877         * WebCoreSupport/WebSecurityOrigin.mm:
2878         (-[WebSecurityOrigin databaseIdentifier]):
2879         (-[WebSecurityOrigin usage]):
2880         (-[WebSecurityOrigin quota]):
2881         (-[WebSecurityOrigin setQuota:]):
2882
2883 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
2884
2885         Fix the build
2886
2887         * WebView/WebView.mm:
2888
2889 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2890
2891         Fix the build with no pasteboard
2892         https://bugs.webkit.org/show_bug.cgi?id=183973
2893
2894         Reviewed by Dan Bernstein.
2895
2896         * Configurations/FeatureDefines.xcconfig:
2897         * WebView/WebView.mm:
2898         (-[WebView _requestStartDataInteraction:globalPosition:]):
2899         (-[WebView _getDataInteractionData]):
2900         (-[WebView _dataOperationTextIndicator]):
2901         (-[WebView _dragSourceAction]):
2902         (-[WebView _draggedLinkTitle]):
2903         (-[WebView _draggedLinkURL]):
2904         (-[WebView _draggedElementBounds]):
2905         (-[WebView _enteredDataInteraction:client:global:operation:]):
2906         (-[WebView _updatedDataInteraction:client:global:operation:]):
2907         (-[WebView _exitedDataInteraction:client:global:operation:]):
2908         (-[WebView _performDataInteraction:client:global:operation:]):
2909         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
2910         (-[WebView _endedDataInteraction:global:]):
2911         (-[WebView _dataInteractionCaretRect]):
2912         * WebView/WebViewPrivate.h:
2913
2914 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2915
2916         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
2917         https://bugs.webkit.org/show_bug.cgi?id=183960
2918         <rdar://problem/38812356>
2919
2920         Reviewed by Dan Bernstein.
2921
2922         * Configurations/WebKitLegacy.xcconfig:
2923
2924 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2925
2926         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
2927         https://bugs.webkit.org/show_bug.cgi?id=183954
2928         <rdar://problem/38808858>
2929
2930         Reviewed by Dan Bernstein.
2931
2932         * WebView/WebPreferences.mm:
2933         (-[WebPreferences setAudioSessionCategoryOverride:]):
2934
2935 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2936
2937         Adopt WK_PLATFORM_NAME in WebKitLegacy
2938         https://bugs.webkit.org/show_bug.cgi?id=183948
2939         <rdar://problem/38803908>
2940
2941         Reviewed by Dan Bernstein.
2942
2943         * Configurations/WebKitLegacy.xcconfig:
2944         * MigrateHeaders.make:
2945         * postprocess-headers.sh:
2946
2947 2018-03-23  Brady Eidson  <beidson@apple.com>
2948
2949         Go to back/forward list items after a process-swapped navigation.
2950         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2951
2952         Reviewed by Andy Estes.
2953
2954         * WebView/WebView.mm:
2955         (-[WebView _loadBackForwardListFromOtherView:]):
2956         (-[WebView goToBackForwardItem:]):
2957
2958 2018-03-22  Tim Horton  <timothy_horton@apple.com>
2959
2960         Improve readability of WebCore's OTHER_LDFLAGS
2961         https://bugs.webkit.org/show_bug.cgi?id=183909
2962         <rdar://problem/38760992>
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * Configurations/Base.xcconfig:
2967         * Configurations/FeatureDefines.xcconfig:
2968
2969 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2970
2971         Enable the minimal simulator feature flag when appropriate
2972         https://bugs.webkit.org/show_bug.cgi?id=183807
2973
2974         Reviewed by Dan Bernstein.
2975
2976         * Configurations/FeatureDefines.xcconfig:
2977
2978 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2979
2980         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
2981         https://bugs.webkit.org/show_bug.cgi?id=183758
2982         <rdar://problem/38017644>
2983
2984         Reviewed by Dan Bernstein.
2985
2986         * Configurations/FeatureDefines.xcconfig:
2987
2988 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
2989
2990         Clear style colors when setting default appearance
2991         https://bugs.webkit.org/show_bug.cgi?id=183759
2992
2993         Reviewed by Tim Horton.
2994
2995         Colors are cached and need to be cleared and recalculated.
2996         Refactor to do all style recalcs together.
2997
2998         * WebView/WebView.mm:
2999         (-[WebView _setDefaultAppearanceAndClearStyle]):
3000         (-[WebView _setUseSystemAppearance:]):
3001         (-[WebView effectiveAppearanceDidChange]):
3002
3003 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3004
3005         Unreviewed, another quick fix for r229699
3006
3007         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3008
3009         * Configurations/FeatureDefines.xcconfig:
3010
3011 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3012
3013         Ensure that style is updated when the effective appearance changes
3014         https://bugs.webkit.org/show_bug.cgi?id=183690
3015         <rdar://problem/38385900>
3016
3017         Reviewed by Tim Horton and Wenson Hsieh.
3018
3019         Respond to and respect the effective appearance changing.
3020
3021         * WebView/WebView.mm:
3022         (-[WebView _setUseSystemAppearance:]):
3023         (-[WebView effectiveAppearanceDidChange]):
3024
3025 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3026
3027         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3028         https://bugs.webkit.org/show_bug.cgi?id=183677
3029
3030         Reviewed by Tim Horton.
3031
3032         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3033
3034         * DOM/DOM.mm:
3035         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3036
3037 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3038
3039         Fix the build after r229567
3040
3041         * Configurations/FeatureDefines.xcconfig:
3042
3043 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3044
3045         Stop using SDK conditionals to control feature definitions
3046         https://bugs.webkit.org/show_bug.cgi?id=183430
3047         <rdar://problem/38251619>
3048
3049         Reviewed by Dan Bernstein.
3050
3051         * Configurations/FeatureDefines.xcconfig:
3052         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3053
3054 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3055
3056         Runtime flag for link prefetch and remove link subresource.
3057         https://bugs.webkit.org/show_bug.cgi?id=183540
3058
3059         Reviewed by Chris Dumez.
3060
3061         Remove the LINK_PREFETCH build time flag.
3062
3063         * Configurations/FeatureDefines.xcconfig:
3064
3065 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3066
3067         Remove GridLayout runtime flag
3068         https://bugs.webkit.org/show_bug.cgi?id=183484
3069
3070         Reviewed by Myles C. Maxfield.
3071
3072         The Grid Layout feature has been enabled by default for almost a
3073         year, so I think it's time to remove the runtime flag and the
3074
3075         * WebView/WebPreferenceKeysPrivate.h:
3076         * WebView/WebPreferences.mm:
3077         (+[WebPreferences initialize]):
3078         * WebView/WebPreferencesPrivate.h:
3079         * WebView/WebView.mm:
3080         (-[WebView _preferencesChanged:]):
3081
3082 2018-03-12  Antoine Quint  <graouts@apple.com>
3083
3084         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3085         https://bugs.webkit.org/show_bug.cgi?id=183504
3086         <rdar://problem/38372965>
3087
3088         Reviewed by Dean Jackson and Jon Lee.
3089
3090         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3091         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3092
3093         * WebView/WebPreferenceKeysPrivate.h:
3094         * WebView/WebPreferences.mm:
3095         (+[WebPreferences initialize]):
3096         (-[WebPreferences setModernMediaControlsEnabled:]):
3097         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3098         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3099         * WebView/WebPreferencesPrivate.h:
3100         * WebView/WebView.mm:
3101         (-[WebView _preferencesChanged:]):
3102
3103 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3104
3105         Media query for default appearance
3106         https://bugs.webkit.org/show_bug.cgi?id=183539
3107         <rdar://problem/38326388>
3108
3109         Reviewed by Tim Horton.
3110
3111         Write a media query to evaluate appearance.
3112
3113         * WebView/WebView.mm:
3114         (-[WebView _commonInitializationWithFrameName:groupName:]):
3115         (-[WebView _setUseSystemAppearance:]):
3116
3117 2018-03-09  Andy Estes  <aestes@apple.com>
3118
3119         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3120         https://bugs.webkit.org/show_bug.cgi?id=183489
3121         <rdar://problem/38267517>
3122
3123         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3124         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3125         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3126         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3127         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3128
3129         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3130         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3131         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3132         drop destination.
3133
3134         Reviewed by Wenson Hsieh.
3135
3136         * WebView/WebView.mm:
3137         (-[WebView performDragOperation:]):
3138
3139 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3140
3141         Allow WebViews to disable system appearance
3142         https://bugs.webkit.org/show_bug.cgi?id=183418
3143         <rdar://problem/36975642>
3144
3145         Reviewed by Tim Horton.
3146
3147         Allow webviews to choose whether or not to follow the default system appearance.
3148
3149         * WebView/WebView.mm:
3150         (-[WebView _setUseSystemAppearance:]):
3151         (-[WebView _useSystemAppearance]):
3152         * WebView/WebViewPrivate.h:
3153
3154 2018-03-08  Youenn Fablet  <youenn@apple.com>
3155
3156         libwebrtc update broke internal builds
3157         https://bugs.webkit.org/show_bug.cgi?id=183454
3158
3159         Reviewed by Eric Carlson.
3160
3161         * Configurations/WebKitLegacy.xcconfig:
3162
3163 2018-03-08  Chris Dumez  <cdumez@apple.com>
3164
3165         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3166         https://bugs.webkit.org/show_bug.cgi?id=183455
3167         <rdar://problem/38191749>
3168
3169         Reviewed by Youenn Fablet.
3170
3171         Add a null check for the page as we have evidence from crashes that it can be null.
3172         Other functions in WebFrameNetworkingContext already null check the page as well,
3173         not just the frame so this is consistent.
3174
3175         * WebCoreSupport/WebFrameNetworkingContext.mm:
3176         (WebFrameNetworkingContext::storageSession const):
3177
3178 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3179
3180         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3181         https://bugs.webkit.org/show_bug.cgi?id=183429
3182
3183         Reviewed by Mark Lam.
3184
3185         * DOM/DOM.mm:
3186         (+[DOMNode _nodeFromJSWrapper:]):
3187         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3188         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3189         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3190         * Plugins/Hosted/ProxyInstance.mm:
3191         (WebKit::ProxyInstance::invokeMethod):
3192         * WebView/WebView.mm:
3193         (aeDescFromJSValue):
3194
3195 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3196
3197         Stop linking ApplicationServices directly
3198         https://bugs.webkit.org/show_bug.cgi?id=182867
3199         <rdar://problem/38252142>
3200
3201         Reviewed by Alex Christensen.
3202
3203         The frameworks that we use that live inside ApplicationServices
3204         have mostly moved out, so import them directly.
3205
3206         * Carbon/CarbonUtils.h:
3207         * WebKitPrefix.h:
3208         * WebView/WebHTMLView.mm:
3209         * WebView/WebPDFView.mm:
3210
3211 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3212
3213         Sort and separate FeatureDefines.xcconfig
3214         https://bugs.webkit.org/show_bug.cgi?id=183427
3215
3216         Reviewed by Dan Bernstein.
3217
3218         * Configurations/FeatureDefines.xcconfig:
3219         Sort and split FeatureDefines into paragraphs
3220         (to make it easier to sort later).
3221
3222 2018-03-07  Youenn Fablet  <youenn@apple.com>
3223
3224         Match unsupported plugins based on domains and not origin
3225         https://bugs.webkit.org/show_bug.cgi?id=183384
3226
3227         Reviewed by Chris Dumez.
3228
3229         * WebCoreSupport/WebPluginInfoProvider.h:
3230         * WebCoreSupport/WebPluginInfoProvider.mm:
3231         (WebPluginInfoProvider::getPluginInfo):
3232         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3233
3234 2018-03-05  Andy Estes  <aestes@apple.com>
3235
3236         [Mac] Teach WebCore::Pasteboard about file promise drags
3237         https://bugs.webkit.org/show_bug.cgi?id=183314
3238         <rdar://problem/38105493>
3239
3240         Reviewed by Darin Adler.
3241
3242         Added a FIXME comment.
3243
3244         * WebView/WebView.mm:
3245         (-[WebView performDragOperation:]):
3246
3247 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3248
3249         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3250         https://bugs.webkit.org/show_bug.cgi?id=183312
3251
3252         Reviewed by Mark Lam.
3253
3254         Remove wtf/CurrentTime.h include pragma.
3255
3256         * WebView/WebFrame.mm:
3257         * WebView/WebPDFView.mm:
3258
3259 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3260
3261         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3262         https://bugs.webkit.org/show_bug.cgi?id=183283
3263         <rdar://problem/38062148>
3264
3265         Reviewed by Sam Weinig.
3266
3267         * Configurations/FeatureDefines.xcconfig:
3268
3269 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3270
3271         Reduce use of NetworkingContext in WebKit
3272         https://bugs.webkit.org/show_bug.cgi?id=183213
3273
3274         Reviewed by Brady Eidson.
3275
3276         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3277         (WebKit::NetscapePluginInstanceProxy::getProxy):
3278         * Plugins/WebNetscapePluginView.mm:
3279         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3280
3281 2018-02-17  Darin Adler  <darin@apple.com>
3282
3283         Prepare for ExtendedColor changes (first step)
3284         https://bugs.webkit.org/show_bug.cgi?id=182904
3285
3286         Reviewed by Sam Weinig.
3287
3288         * Misc/WebKitNSStringExtras.mm:
3289         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3290
3291 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3292
3293         Remove currentTime() / currentTimeMS()
3294         https://bugs.webkit.org/show_bug.cgi?id=183052
3295
3296         Reviewed by Mark Lam.
3297
3298         * WebCoreSupport/WebFrameLoaderClient.h:
3299         * WebCoreSupport/WebFrameLoaderClient.mm:
3300         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3301
3302 2018-02-16  Youenn Fablet  <youenn@apple.com>
3303
3304         Allow specifying which plug-ins are supported
3305         https://bugs.webkit.org/show_bug.cgi?id=182748
3306
3307         Reviewed by Chris Dumez.
3308
3309         * WebCoreSupport/WebPluginInfoProvider.h:
3310         * WebCoreSupport/WebPluginInfoProvider.mm:
3311         (WebPluginInfoProvider::getPluginInfo):
3312         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3313
3314 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3315
3316         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3317         https://bugs.webkit.org/show_bug.cgi?id=182882
3318         <rdar://problem/35672661>
3319
3320         Reviewed by Dan Bernstein.
3321
3322         Make sure the smart pointer hold the collection of subviews lives at least as
3323         long as the loop using it.
3324
3325         * WebView/WebHTMLView.mm:
3326         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3327
3328 2018-02-14  Daniel Bates  <dabates@apple.com>
3329
3330         Disallow cross-origin subresources from asking for credentials
3331         https://bugs.webkit.org/show_bug.cgi?id=182579
3332         <rdar://problem/36162271>
3333
3334         Reviewed by Andy Estes.
3335
3336         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3337         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3338
3339         * WebView/WebPreferenceKeysPrivate.h:
3340         * WebView/WebPreferences.mm:
3341         (+[WebPreferences initialize]):
3342         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3343         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3344         * WebView/WebPreferencesPrivate.h:
3345         * WebView/WebView.mm:
3346         (-[WebView _preferencesChanged:]):
3347
3348 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3349
3350         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3351         https://bugs.webkit.org/show_bug.cgi?id=182738
3352
3353         Reviewed by Darin Adler.
3354
3355         * ForwardingHeaders/collector/handles/Global.h: Removed.
3356         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3357         * ForwardingHeaders/runtime/Completion.h: Removed.
3358         * ForwardingHeaders/runtime/Error.h: Removed.
3359         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3360         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3361         * ForwardingHeaders/runtime/JSLock.h: Removed.
3362         * ForwardingHeaders/runtime/JSObject.h: Removed.
3363         * ForwardingHeaders/runtime/JSString.h: Removed.
3364         * ForwardingHeaders/runtime/Protect.h: Removed.
3365         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3366
3367 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3368
3369         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3370         https://bugs.webkit.org/show_bug.cgi?id=182641
3371
3372         Reviewed by Dan Bernstein.
3373
3374         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3375         https://trac.webkit.org/changeset/228308.
3376
3377         * WebView/WebVideoFullscreenController.h:
3378         * WebView/WebVideoFullscreenHUDWindowController.mm:
3379         * WebView/WebWindowAnimation.h:
3380         * WebView/WebWindowAnimation.mm:
3381         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3382         (WebCore::scaledRect): Deleted.
3383         (WebCore::squaredDistance): Deleted.
3384
3385 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3386
3387         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3388
3389         * WebView/WebWindowAnimation.mm:
3390         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3391
3392 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3393
3394         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3395         https://bugs.webkit.org/show_bug.cgi?id=182615
3396
3397         Reviewed by Eric Carlson.
3398
3399         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3400         Ideally, we should not reference NSApp in WebCore.
3401
3402         * WebView/WebFullScreenController.mm:
3403         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3404         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3405         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3406         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3407         * WebView/WebView.mm:
3408         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3409         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3410
3411 2018-01-13  Darin Adler  <darin@apple.com>
3412
3413         Event improvements
3414         https://bugs.webkit.org/show_bug.cgi?id=179591
3415
3416         Reviewed by Chris Dumez.
3417
3418         * DOM/DOMWheelEvent.mm:
3419         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3420         Call initWebKitWheelEvent.
3421
3422         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3423         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3424         * WebView/WebFrame.mm: Ditto.
3425
3426         * WebView/WebHTMLView.mm:
3427         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3428         underlyingPlatformEvent.
3429         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3430
3431         * WebView/WebScriptWorld.mm:
3432         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3433
3434         * WebView/WebView.mm: Removed include of ScriptValue.h.
3435
3436 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3437
3438         Remove WebCore/ForwardingHeaders directory
3439         https://bugs.webkit.org/show_bug.cgi?id=182347
3440
3441         Reviewed by Keith Miller.
3442
3443         * Carbon/CarbonWindowAdapter.mm:
3444         * DOM/WebDOMOperations.mm:
3445         * History/WebBackForwardList.mm:
3446         * History/WebHistoryItem.mm:
3447         * Misc/WebCache.mm:
3448         * Misc/WebElementDictionary.mm:
3449         * Misc/WebIconDatabase.mm:
3450         * Misc/WebStringTruncator.mm:
3451         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3452         * Plugins/Hosted/ProxyInstance.mm:
3453         * Plugins/Hosted/ProxyRuntimeObject.mm:
3454         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3455         * Plugins/WebBaseNetscapePluginView.mm:
3456         * Plugins/WebBasePluginPackage.mm:
3457         * Plugins/WebNetscapePluginStream.mm:
3458         * Plugins/WebNetscapePluginView.mm:
3459         * Plugins/WebPluginController.mm:
3460         * WebCoreSupport/WebEditorClient.mm:
3461         * WebCoreSupport/WebFrameLoaderClient.mm:
3462         * WebCoreSupport/WebInspectorClient.h:
3463         * WebCoreSupport/WebInspectorClient.mm:
3464         * WebView/WebDataSource.mm:
3465         * WebView/WebFrame.mm:
3466         * WebView/WebHTMLRepresentation.mm:
3467         * WebView/WebHTMLView.mm:
3468         * WebView/WebPreferences.mm:
3469         * WebView/WebScriptDebugDelegate.mm:
3470         * WebView/WebScriptDebugger.h:
3471         * WebView/WebTextIterator.mm:
3472         * WebView/WebView.mm:
3473         * WebView/WebViewData.mm:
3474
3475 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3476
3477         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3478         https://bugs.webkit.org/show_bug.cgi?id=182312
3479
3480         Reviewed by Michael Catanzaro.
3481
3482         * WebKitPrefix.h:
3483
3484 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3485
3486         [WebAuthN] Add a compile-time feature flag
3487         https://bugs.webkit.org/show_bug.cgi?id=182211
3488         <rdar://problem/36936365>
3489
3490         Reviewed by Brent Fulgham.
3491
3492         * Configurations/FeatureDefines.xcconfig:
3493
3494 2018-01-27  Dan Bernstein  <mitz@apple.com>
3495
3496         HaveInternalSDK includes should be "#include?"
3497         https://bugs.webkit.org/show_bug.cgi?id=179670
3498
3499         * Configurations/Base.xcconfig:
3500
3501 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3502
3503         Remove unused QTKit preference
3504         https://bugs.webkit.org/show_bug.cgi?id=181968
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         * WebView/WebPreferenceKeysPrivate.h:
3509         * WebView/WebPreferences.mm:
3510         (+[WebPreferences initialize]):
3511         (-[WebPreferences setQTKitEnabled:]): Deleted.
3512         (-[WebPreferences isQTKitEnabled]): Deleted.
3513         * WebView/WebPreferencesPrivate.h:
3514         * WebView/WebView.mm:
3515         (-[WebView _preferencesChanged:]):
3516
3517 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3518
3519         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3520         https://bugs.webkit.org/show_bug.cgi?id=182037
3521         <rdar://problem/36747812>
3522
3523         Reviewed by Ryosuke Niwa.
3524
3525         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3526         for more details.
3527
3528         * WebView/WebHTMLRepresentation.mm:
3529         (-[WebHTMLRepresentation elementWithName:inForm:]):
3530         (-[WebHTMLRepresentation controlsInForm:]):
3531
3532 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3533
3534         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3535         https://bugs.webkit.org/show_bug.cgi?id=181961
3536
3537         Reviewed by Michael Catanzaro.
3538
3539         * WebView/WebPreferences.mm:
3540
3541 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3542
3543         Unreviewed, rolling out r227437.
3544         https://bugs.webkit.org/show_bug.cgi?id=182011
3545
3546         broke build (Requested by alexchristensen on #webkit).
3547
3548         Reverted changeset:
3549
3550         "Remove unused QTKit preference"
3551         https://bugs.webkit.org/show_bug.cgi?id=181968
3552         https://trac.webkit.org/changeset/227437
3553
3554 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3555
3556         Remove unused QTKit preference
3557         https://bugs.webkit.org/show_bug.cgi?id=181968
3558
3559         Reviewed by Alexey Proskuryakov.
3560
3561         * WebView/WebPreferenceKeysPrivate.h:
3562         * WebView/WebPreferences.mm:
3563         (+[WebPreferences initialize]):
3564         (-[WebPreferences setQTKitEnabled:]): Deleted.
3565         (-[WebPreferences isQTKitEnabled]): Deleted.
3566         * WebView/WebPreferencesPrivate.h:
3567         * WebView/WebView.mm:
3568         (-[WebView _preferencesChanged:]):
3569
3570 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3571
3572         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3573         https://bugs.webkit.org/show_bug.cgi?id=181960
3574         <rdar://problem/36431678>
3575
3576         Reviewed by Tim Horton.
3577
3578         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3579         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
3580         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
3581
3582         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
3583         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
3584         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
3585
3586         * WebView/WebView.mm:
3587         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3588
3589 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
3590
3591         Turning off custom pasteboard data doesn't actually turn it off in WK2
3592         https://bugs.webkit.org/show_bug.cgi?id=181920
3593         <rdar://problem/36686429>
3594
3595         Reviewed by Wenson Hsieh.
3596
3597         Always disable custom pasteboard data in WebKit1. See r226156 for details.
3598
3599         * WebView/WebPreferences.mm:
3600         (+[WebPreferences initialize]):
3601         * WebView/WebView.mm:
3602         (-[WebView _preferencesChanged:]):
3603
3604 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3605
3606         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3607         https://bugs.webkit.org/show_bug.cgi?id=181918
3608
3609         Reviewed by Tim Horton.
3610
3611         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3612
3613         * Configurations/FeatureDefines.xcconfig:
3614
3615 2018-01-20  Andy Estes  <aestes@apple.com>
3616
3617         [Apple Pay] Stop eagerly loading PassKit.framework
3618         https://bugs.webkit.org/show_bug.cgi?id=181911
3619         <rdar://problem/36555369>
3620
3621         Reviewed by Tim Horton.
3622
3623         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3624         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3625         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
3626
3627         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
3628
3629 2018-01-19  Dean Jackson  <dino@apple.com>
3630
3631         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
3632         https://bugs.webkit.org/show_bug.cgi?id=181817
3633         <rdar://problem/35274055>
3634
3635         Reviewed by Simon Fraser.
3636
3637         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
3638
3639         * Misc/WebKitVersionChecks.h:
3640         * WebView/WebView.mm:
3641         (-[WebView _commonInitializationWithFrameName:groupName:]):
3642
3643 2018-01-19  Alex Christensen  <achristensen@webkit.org>
3644
3645         Remove unused WebViewPrivate _allowCookies
3646         https://bugs.webkit.org/show_bug.cgi?id=181812
3647
3648         Reviewed by Tim Horton.
3649
3650         * WebView/WebView.mm:
3651         (+[WebView _setAllowCookies:]): Deleted.
3652         (+[WebView _allowCookies]): Deleted.
3653         * WebView/WebViewPrivate.h:
3654
3655 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
3656
3657         Build fix, remove a call to -[NSWindow setOneShot:]
3658         https://bugs.webkit.org/show_bug.cgi?id=181809
3659
3660         Reviewed by Tim Horton.
3661
3662         * WebView/WebTextCompletionController.mm:
3663         (-[WebTextCompletionController _buildUI]):
3664
3665 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3666
3667         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
3668
3669         * Carbon/HIWebView.mm:
3670         (overrideCGContext):
3671         (restoreCGContext):
3672
3673 2018-01-18  Dan Bernstein  <mitz@apple.com>
3674
3675         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3676         https://bugs.webkit.org/show_bug.cgi?id=181803
3677
3678         Reviewed by Tim Horton.
3679
3680         * Configurations/Base.xcconfig: Updated.
3681         * Configurations/DebugRelease.xcconfig: Ditto.
3682         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3683         * Configurations/Version.xcconfig: Updated.
3684         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3685           useful for defining settings that depend on the target macOS version.
3686
3687 2018-01-17  Youenn Fablet  <youenn@apple.com>
3688
3689         Put fetch Request.keepalive behind a runtime flag
3690         https://bugs.webkit.org/show_bug.cgi?id=181592
3691
3692         Reviewed by Chris Dumez.
3693
3694         * WebView/WebPreferenceKeysPrivate.h:
3695         * WebView/WebPreferences.mm:
3696         (+[WebPreferences initialize]):
3697         (-[WebPreferences fetchAPIKeepAliveEnabled]):
3698         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
3699         * WebView/WebPreferencesPrivate.h:
3700         * WebView/WebView.mm:
3701         (-[WebView _preferencesChanged:]):
3702
3703 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3704
3705         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3706         https://bugs.webkit.org/show_bug.cgi?id=181637
3707         <rdar://problem/36508471>
3708
3709         Reviewed by Tim Horton.
3710
3711         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
3712
3713         * WebCoreSupport/WebEditorClient.h:
3714         * WebCoreSupport/WebEditorClient.mm:
3715         (WebEditorClient::replacementURLForResource):
3716
3717 2018-01-11  Keith Miller  <keith_miller@apple.com>
3718
3719         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3720         https://bugs.webkit.org/show_bug.cgi?id=181573
3721
3722         Reviewed by Simon Fraser.
3723
3724         * Configurations/FeatureDefines.xcconfig:
3725
3726 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3727
3728         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
3729         https://bugs.webkit.org/show_bug.cgi?id=181497
3730
3731         Reviewed by Tim Horton.
3732
3733         See other ChangeLogs for more detail.
3734
3735         * WebCoreSupport/WebDragClient.h:
3736
3737 2018-01-11  Tim Horton  <timothy_horton@apple.com>
3738
3739         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
3740         https://bugs.webkit.org/show_bug.cgi?id=181523
3741         <rdar://problem/28959131>
3742
3743         Reviewed by Alex Christensen.
3744
3745         * WebView/WebImmediateActionController.mm:
3746         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3747         Apply the change made in r216652 to WebKit1's immediate action controller.
3748
3749         Speculative (but successful in WebKit2) fix for non-reproducible crash when
3750         the startContainer of the range is in an anonymous node.
3751
3752 2018-01-11  Youenn Fablet  <youenn@apple.com>
3753
3754         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
3755         https://bugs.webkit.org/show_bug.cgi?id=181480
3756
3757         Reviewed by Eric Carlson.
3758
3759         * WebView/WebPreferences.mm:
3760         (+[WebPreferences initialize]):
3761
3762 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3763
3764         Fix check-webkit-style issues with WebNSDataExtras.mm
3765         <https://webkit.org/b/181369>
3766
3767         Reviewed by Alex Christensen.
3768
3769         * Misc/WebNSDataExtras.mm:
3770         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3771         (-[NSData _webkit_guessedMIMETypeForXML]):
3772         (-[NSData _webkit_guessedMIMEType]):
3773         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3774         (_findEOL):
3775         (-[NSData _webkit_parseRFC822HeaderFields]):
3776         (-[NSData _web_locationAfterFirstBlankLine]):
3777         - Fix all the check-webkit-style warnings.
3778
3779 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3780
3781         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3782         <https://webkit.org/b/181256>
3783         <rdar://problem/36281730>
3784
3785         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3786         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
3787         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
3788           to avoid warnings from casting CFStringRef to NPNSString*.
3789           Note that CFMutableStringRef is the same as CFStringRef
3790           without the const modifier, hence its use in the const_cast<>
3791           above.
3792
3793 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3794
3795         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3796         <https://webkit.org/b/181256>
3797         <rdar://problem/36281730>
3798
3799         * Carbon/HIWebView.mm:
3800         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
3801         checked_cf_cast<CFRunLoopRef>() to fix warning.
3802
3803 2018-01-07  David Kilzer  <ddkilzer@apple.com>
3804
3805         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3806         <https://webkit.org/b/181256>
3807         <rdar://problem/36281730>
3808
3809         Reviewed by Darin Adler.
3810
3811         * Carbon/CarbonUtils.m:
3812         (PoolCleaner):
3813         - Use #pragmas to ignore -Wcast-qual warnings when using a
3814           C-style cast from CFTypeRef to CFRunloopRef.
3815         * Carbon/CarbonWindowFrame.m:
3816         (-[CarbonWindowFrame title]):
3817         - Use #pragmas to ignore -Wcast-qual warnings when using a
3818           C-style cast from CFStringRef to NSString *.
3819         * Carbon/HIViewAdapter.m:
3820         (+[HIViewAdapter getHIViewForNSView:]):
3821         - Use #pragmas to ignore -Wcast-qual warnings when using a
3822           C-style cast from CFTypeRef to HIViewRef.
3823         * Configurations/Base.xcconfig:
3824         (WARNING_CFLAGS): Add -Wcast-qual.
3825         * Misc/WebElementDictionary.mm:
3826         (-[WebElementDictionary objectForKey:]):
3827         - Use static_cast<SEL>(const_cast<void*>()) to fix
3828           warning.
3829         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
3830         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3831         (-[NSData _webkit_guessedMIMETypeForXML]):
3832         (-[NSData _webkit_guessedMIMEType]):
3833         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3834         (_findEOL):
3835         (-[NSData _webkit_parseRFC822HeaderFields]):
3836         (-[NSData _web_startsWithBlankLine]):
3837         (-[NSData _web_locationAfterFirstBlankLine]):
3838         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
3839           type to Objective-C++.  This fixes the warnings about
3840           discarding the `const` modifier when casing from CFStringRef
3841           to NSString * because in older clang versions, -Wcast-qual was
3842           completely broken when compiling C++ and Objective-C++ source
3843           files.  In newer clang versions, discarding the `const`
3844           modifier for toll-free bridged types is ignored when compiling
3845           Objective-C++ source.
3846         - Update copyright and license header.
3847         - Use reinterpret_cast<> and static_cast<> to fix warnings
3848           unrelated to (NSString *) C-style casts.
3849         - Replace use of MIN() macro with std::min<> template functions.
3850         - Fix location of `*` for local variables modified above.
3851         * Plugins/Hosted/NetscapePluginHostManager.mm:
3852         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3853         (WebKit::NetscapePluginHostManager::initializeVendorPort):
3854         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3855         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
3856           warnings.
3857         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3858         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3859         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
3860           to fix warning.
3861         * Plugins/Hosted/ProxyInstance.mm:
3862         (WebKit::ProxyInstance::invoke):
3863         - Use static_cast<char*>(const_cast<void*>()) to fix
3864           warning when using -[NSData bytes].
3865         (WebKit::ProxyInstance::fieldValue const):
3866         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
3867           to fix warning when using CFDataGetBytePtr().
3868         * Plugins/Hosted/WebTextInputWindowController.m:
3869         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3870         - Use #pragma to ignore -Wcast-qual warning since there
3871           is not a good way to avoid this warning in Objective-C.
3872         * Plugins/WebNetscapePluginStream.mm:
3873         (WebNetscapePluginStream::deliverData):
3874         - Use const_cast<void*>() to fix warning when using
3875           -[NSData bytes].
3876         * Plugins/WebNetscapePluginView.mm:
3877         (-[WebNetscapePluginView _createPlugin]):
3878         - Change C-style cast to const_cast<char*>() to fix
3879           warning.
3880         * WebCoreSupport/WebChromeClient.mm:
3881         (WebChromeClient::wrapCryptoKey const):
3882         (WebChromeClient::unwrapCryptoKey const):
3883         - Change C-style cast to
3884           static_cast<uint8_t*>(const_cast<void*>() to fix
3885           warning.
3886         * WebView/WebPDFView.mm:
3887         (_applicationInfoForMIMEType):
3888         - Change local variable type from 'NSURL *' to
3889           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
3890           when calling -[NSURL path].
3891
3892 2018-01-05  Dan Bernstein  <mitz@apple.com>
3893
3894         Fixed the build following AppKit API deprecations in a recent SDKs
3895
3896         * WebView/WebFullScreenController.mm:
3897         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
3898         (-[WebFullScreenController exitFullScreen]): Ditto.
3899         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
3900         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
3901         * WebView/WebHTMLView.mm:
3902         (-[WebHTMLView drawRect:]): Ditto.
3903         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
3904         (-[WebHTMLView knowsPageRange:]): Ditto.
3905         * WebView/WebView.mm:
3906         (LayerFlushController::flushLayers): Ditto.
3907
3908 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3909
3910         [Attachment Support] Create attachment elements when dropping files on iOS
3911         https://bugs.webkit.org/show_bug.cgi?id=181192
3912         <rdar://problem/36280945>
3913
3914         Reviewed by Tim Horton.
3915
3916         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
3917
3918         * WebCoreSupport/WebPlatformStrategies.h:
3919         * WebCoreSupport/WebPlatformStrategies.mm:
3920         (WebPlatformStrategies::informationForItemAtIndex):
3921         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
3922
3923 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3924
3925         [Attachment Support] Add plumbing for starting a drag with promised blob data
3926         https://bugs.webkit.org/show_bug.cgi?id=181201
3927
3928         Reviewed by Tim Horton.
3929
3930         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
3931
3932         * WebCoreSupport/WebDragClient.h:
3933
3934 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3935
3936         Add a WebAuthentication runtime feature flag
3937         https://bugs.webkit.org/show_bug.cgi?id=181220
3938         <rdar://problem/36055305>
3939
3940         Reviewed by Brent Fulgham.
3941
3942         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3943
3944         * WebView/WebPreferenceKeysPrivate.h:
3945         * WebView/WebPreferences.mm:
3946         (+[WebPreferences initialize]):
3947         (-[WebPreferences webAuthenticationEnabled]):
3948         (-[WebPreferences setWebAuthenticationEnabled:]):
3949         (-[WebPreferences credentialManagementEnabled]): Deleted.
3950         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
3951         * WebView/WebPreferencesPrivate.h:
3952         * WebView/WebView.mm:
3953         (-[WebView _preferencesChanged:]):
3954
3955 2017-12-22  Jeff Miller  <jeffm@apple.com>
3956
3957         Update user-visible copyright strings to include 2018
3958         https://bugs.webkit.org/show_bug.cgi?id=181141
3959
3960         Reviewed by Dan Bernstein.
3961
3962         * Info.plist:
3963
3964 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3965
3966         [Attachment Support] Remove current macOS support for dragging file-backed attachments
3967         https://bugs.webkit.org/show_bug.cgi?id=181188
3968
3969         Reviewed by Dan Bernstein.
3970
3971         See WebCore/ChangeLog for more detail.
3972
3973         * WebCoreSupport/WebDragClient.h:
3974         * WebCoreSupport/WebDragClient.mm:
3975         (WebDragClient::declareAndWriteAttachment): Deleted.
3976         * WebView/WebHTMLView.mm:
3977         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
3978
3979 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3980
3981         Unreviewed, continue to fix build failures due to AppKit API deprecation
3982
3983         Wraps more code in -Wdeprecated-declarations.
3984
3985         * Carbon/HIWebView.mm:
3986         (overrideCGContext):
3987
3988 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3989
3990         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
3991
3992         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
3993
3994         * Carbon/CarbonWindowAdapter.mm:
3995         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3996         * Plugins/WebNetscapePluginView.mm:
3997         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3998         (-[WebNetscapePluginView sendDrawRectEvent:]):
3999         (-[WebNetscapePluginView drawRect:]):
4000
4001 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4002
4003         Fix build failures due to using deprecated AppKit symbols
4004         https://bugs.webkit.org/show_bug.cgi?id=181110
4005         <rdar://problem/36162865>
4006
4007         Reviewed by Dan Bernstein and Tim Horton.
4008
4009         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
4010
4011         * Misc/WebKitNSStringExtras.mm:
4012         (-[NSString _web_drawAtPoint:font:textColor:]):
4013         * Misc/WebNSPasteboardExtras.h:
4014         * Misc/WebNSPasteboardExtras.mm:
4015         (+[NSPasteboard _web_writableTypesForURL]):
4016         (_createWritableTypesForImageWithoutArchive):
4017         (_createWritableTypesForImageWithArchive):
4018         (+[NSPasteboard _web_dragTypesForURL]):
4019         (-[NSPasteboard _web_bestURL]):
4020         (-[NSPasteboard _web_writeURL:andTitle:types:]):
4021         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
4022         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
4023         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
4024         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
4025         * Panels/WebAuthenticationPanel.m:
4026         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
4027         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
4028         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
4029         (-[WebHostedNetscapePluginView drawRect:]):
4030         * WebInspector/WebNodeHighlightView.mm:
4031         (-[WebNodeHighlightView drawRect:]):
4032         * WebView/WebFrame.mm:
4033         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
4034         (-[WebFrame _drawRect:contentsOnly:]):
4035         * WebView/WebHTMLView.mm:
4036         (kit):
4037         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
4038         (-[WebHTMLView _plainTextFromPasteboard:]):
4039         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
4040         (+[WebHTMLView _insertablePasteboardTypes]):
4041         (+[WebHTMLView _selectionPasteboardTypes]):
4042         (-[WebHTMLView pasteboard:provideDataForType:]):
4043         (-[WebHTMLView _writeSelectionToPasteboard:]):
4044         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
4045         (-[WebHTMLView validRequestorForSendType:returnType:]):
4046         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
4047         (createMenuItem):
4048         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
4049         (-[WebHTMLView _colorAsString:]):
4050         (-[WebHTMLView copyFont:]):
4051         * WebView/WebPDFView.mm:
4052         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
4053         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
4054         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
4055         (-[WebPDFView pasteboardTypesForSelection]):
4056         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
4057         * WebView/WebView.h:
4058         * WebView/WebView.mm:
4059         (-[WebView performDragOperation:]):
4060         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
4061         (-[WebView _searchWithGoogleFromMenu:]):
4062
4063 2017-1