Unreviewed, rolling out r240124.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-17  Truitt Savell  <tsavell@apple.com>
2
3         Unreviewed, rolling out r240124.
4
5         This commit broke an internal build.
6
7         Reverted changeset:
8
9         "SDK_VARIANT build destinations should be separate from non-
10         SDK_VARIANT builds"
11         https://bugs.webkit.org/show_bug.cgi?id=189553
12         https://trac.webkit.org/changeset/240124
13
14 2019-01-17  Jer Noble  <jer.noble@apple.com>
15
16         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
17         https://bugs.webkit.org/show_bug.cgi?id=189553
18
19         Reviewed by Tim Horton.
20
21         * Configurations/Base.xcconfig:
22         * Configurations/SDKVariant.xcconfig: Added.
23         * Configurations/WebKitLegacy.xcconfig:
24
25 2019-01-17  Alex Christensen  <achristensen@webkit.org>
26
27         Stop using NetworkStorageSession::storageSession in WebCore
28         https://bugs.webkit.org/show_bug.cgi?id=193529
29
30         Reviewed by Tim Horton.
31
32         * Misc/WebCache.mm:
33         (+[WebCache addImageToCache:forURL:forFrame:]):
34         * WebView/WebView.mm:
35         (-[WebView _commonInitializationWithFrameName:groupName:]):
36         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
37
38 2019-01-15  Alex Christensen  <achristensen@webkit.org>
39
40         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
41         https://bugs.webkit.org/show_bug.cgi?id=193368
42
43         Reviewed by Geoff Garen.
44
45         * Misc/WebCache.mm:
46         (+[WebCache clearCachedCredentials]):
47         * Misc/WebDownload.mm:
48         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
49         * Plugins/WebBaseNetscapePluginView.mm:
50         (WebKit::getAuthenticationInfo):
51
52 2019-01-15  Alex Christensen  <achristensen@webkit.org>
53
54         Stop using CookiesStrategy
55         https://bugs.webkit.org/show_bug.cgi?id=161106
56
57         Reviewed by Don Olmstead and Antti Koivisto.
58
59         * Misc/WebCache.mm:
60         (+[WebCache addImageToCache:forURL:forFrame:]):
61         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
62         (WebKit::NetscapePluginInstanceProxy::getCookies):
63         (WebKit::NetscapePluginInstanceProxy::setCookies):
64         * Plugins/WebNetscapePluginView.mm:
65         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
66         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
67         * WebCoreSupport/WebPlatformStrategies.h:
68         * WebCoreSupport/WebPlatformStrategies.mm:
69         (WebPlatformStrategies::createCookiesStrategy): Deleted.
70         (WebPlatformStrategies::cookiesForDOM): Deleted.
71         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
72         (WebPlatformStrategies::cookiesEnabled): Deleted.
73         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
74         (WebPlatformStrategies::getRawCookies): Deleted.
75         (WebPlatformStrategies::deleteCookie): Deleted.
76         * WebView/WebView.mm:
77         (-[WebView _commonInitializationWithFrameName:groupName:]):
78         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
79
80 2019-01-15  Tim Horton  <timothy_horton@apple.com>
81
82         Cannot tab out of WKWebView on macOS
83         https://bugs.webkit.org/show_bug.cgi?id=161448
84         <rdar://problem/28100085>
85
86         Reviewed by Dean Jackson.
87
88         * WebCoreSupport/WebChromeClient.mm:
89         * WebView/WebView.mm:
90         Make use of SPI headers.
91
92 2019-01-14  Commit Queue  <commit-queue@webkit.org>
93
94         Unreviewed, rolling out r239901, r239909, r239910, r239912,
95         r239913, and r239914.
96         https://bugs.webkit.org/show_bug.cgi?id=193407
97
98         These revisions caused an internal failure (Requested by
99         Truitt on #webkit).
100
101         Reverted changesets:
102
103         "[Cocoa] Avoid importing directly from subumbrella frameworks"
104         https://bugs.webkit.org/show_bug.cgi?id=186016
105         https://trac.webkit.org/changeset/239901
106
107         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
108         https://trac.webkit.org/changeset/239909
109
110         "Tried to fix the build."
111         https://trac.webkit.org/changeset/239910
112
113         "Fixed iOS builds after r239910."
114         https://trac.webkit.org/changeset/239912
115
116         "More build fixing."
117         https://trac.webkit.org/changeset/239913
118
119         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
120         https://trac.webkit.org/changeset/239914
121
122 2019-01-14  Mark Lam  <mark.lam@apple.com>
123
124         Re-enable ability to build --cloop builds.
125         https://bugs.webkit.org/show_bug.cgi?id=192955
126         <rdar://problem/46882363>
127
128         Reviewed by Saam barati and Keith Miller.
129
130         * Configurations/FeatureDefines.xcconfig:
131
132 2019-01-13  Dan Bernstein  <mitz@apple.com>
133
134         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
135
136         Patch by Keith Rollin.
137
138         * WebView/PDFViewSPI.h:
139
140 2019-01-12  Timothy Hatcher  <timothy@apple.com>
141
142         Have prefers-color-scheme: light always match on macOS versions before Mojave.
143         https://bugs.webkit.org/show_bug.cgi?id=191655
144         rdar://problem/46074680
145
146         Reviewed by Megan Gardner.
147
148         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
149         * WebView/WebView.mm:
150         (-[WebView _effectiveAppearanceIsDark]):
151
152 2019-01-12  Dan Bernstein  <mitz@apple.com>
153
154         [Cocoa] Avoid importing directly from subumbrella frameworks
155         https://bugs.webkit.org/show_bug.cgi?id=186016
156         <rdar://problem/40591038>
157
158         Reviewed by Sam Weinig.
159
160         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
161         * Carbon/CarbonWindowAdapter.mm: Ditto.
162         * Carbon/CarbonWindowFrame.m: Ditto.
163         * Carbon/HIViewAdapter.h: Ditto.
164         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
165           OTHER_CFLAGS_COCOA_TOUCH_NO.
166         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
167         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
168         * WebView/WebPDFView.h: Ditto.
169
170 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
171
172         Enable visual viewport API by default
173         https://bugs.webkit.org/show_bug.cgi?id=193376
174
175         Reviewed by Simon Fraser.
176
177         * WebView/WebPreferences.mm:
178         (+[WebPreferences initialize]):
179
180 2019-01-11  John Wilander  <wilander@apple.com>
181
182         Compile out Web API Statistics Collection
183         https://bugs.webkit.org/show_bug.cgi?id=193370
184         <rdar://problem/45388584>
185
186         Reviewed by Brent Fulgham.
187
188         * Configurations/FeatureDefines.xcconfig:
189             Defined ENABLE_WEB_API_STATISTICS, off by default.
190
191 2019-01-08  Alex Christensen  <achristensen@webkit.org>
192
193         Stop using NetworkStorageSession in WebProcess
194         https://bugs.webkit.org/show_bug.cgi?id=193236
195
196         Reviewed by Don Olmstead.
197
198         * WebCoreSupport/WebFrameNetworkingContext.h:
199         * WebCoreSupport/WebFrameNetworkingContext.mm:
200         (WebFrameNetworkingContext::storageSession const):
201         * WebCoreSupport/WebPlatformStrategies.h:
202         * WebCoreSupport/WebPlatformStrategies.mm:
203         (WebPlatformStrategies::cookiesForDOM):
204         (WebPlatformStrategies::setCookiesFromDOM):
205         (WebPlatformStrategies::cookiesEnabled):
206         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
207         (WebPlatformStrategies::getRawCookies):
208         (WebPlatformStrategies::deleteCookie):
209         * WebView/WebView.mm:
210         (-[WebView _cachedResponseForURL:]):
211         (-[WebView _clearCredentials]):
212
213 2019-01-08  Alex Christensen  <achristensen@webkit.org>
214
215         Unreviewed, rolling out r239727.
216
217         Broke API tests
218
219         Reverted changeset:
220
221         "Stop using NetworkStorageSession in WebProcess"
222         https://bugs.webkit.org/show_bug.cgi?id=193236
223         https://trac.webkit.org/changeset/239727
224
225 2019-01-08  Alex Christensen  <achristensen@webkit.org>
226
227         Stop using NetworkStorageSession in WebProcess
228         https://bugs.webkit.org/show_bug.cgi?id=193236
229
230         Reviewed by Don Olmstead.
231
232         * WebCoreSupport/WebFrameNetworkingContext.h:
233         * WebCoreSupport/WebFrameNetworkingContext.mm:
234         (WebFrameNetworkingContext::storageSession const):
235         * WebView/WebView.mm:
236         (-[WebView _cachedResponseForURL:]):
237         (-[WebView _clearCredentials]):
238
239 2019-01-07  David Kilzer  <ddkilzer@apple.com>
240
241         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
242         <https://webkit.org/b/193056>
243
244         Reviewed by Alex Christensen.
245
246         * Plugins/Hosted/NetscapePluginHostProxy.h:
247         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
248         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
249         (WebKit::NetscapePluginInstanceProxy::enumerate):
250         (WebKit::NetscapePluginInstanceProxy::marshalValue):
251         (WebKit::NetscapePluginInstanceProxy::marshalValues):
252         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
253         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
254         * Plugins/Hosted/ProxyInstance.mm:
255         (WebKit::ProxyInstance::invoke):
256         * WebCoreSupport/WebGeolocationClient.mm:
257         * WebView/WebDataSource.mm:
258         (-[WebDataSource _receivedData:]):
259         * WebView/WebView.mm:
260         (-[WebView _cachedResponseForURL:]):
261         - Remove '*' from RetainPtr<> type.
262
263 2019-01-04  Alex Christensen  <achristensen@webkit.org>
264
265         Progress towards fixing Mac CMake build
266         https://bugs.webkit.org/show_bug.cgi?id=193105
267
268         Reviewed by Don Olmstead.
269
270         * WebKitPrefix.h:
271
272 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
273
274         Web Inspector: Use save sheet instead of dialog where possible
275         https://bugs.webkit.org/show_bug.cgi?id=193160
276         <rdar://problem/37399759>
277
278         Reviewed by Devin Rousso.
279
280         * WebCoreSupport/WebInspectorClient.mm:
281         (WebInspectorFrontendClient::save):
282
283 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
284
285         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
286         https://bugs.webkit.org/show_bug.cgi?id=193129
287
288         Reviewed by Tim Horton.
289
290         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
291
292         * WebCoreSupport/WebEditorClient.mm:
293         (WebEditorClient::registerUndoOrRedoStep):
294         (undoNameForEditAction): Deleted.
295
296 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
297
298         Add support for using the current text selection as the find string on iOS
299         https://bugs.webkit.org/show_bug.cgi?id=193034
300         <rdar://problem/45138739>
301
302         Reviewed by Tim Horton.
303
304         Add a method stub for WebKitLegacy.
305
306         * WebCoreSupport/WebEditorClient.h:
307
308 2019-01-01  Jeff Miller  <jeffm@apple.com>
309
310         Update user-visible copyright strings to include 2019
311         https://bugs.webkit.org/show_bug.cgi?id=192811
312
313         Reviewed by Mark Lam.
314
315         * Info.plist:
316
317 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
318
319         Use Ref<> as much as possible
320         https://bugs.webkit.org/show_bug.cgi?id=192808
321
322         Reviewed by Alex Christensen.
323
324         * DOM/DOM.mm:
325         (-[DOMNode getPreviewSnapshotImage:andRects:]):
326         * Plugins/Hosted/NetscapePluginHostManager.mm:
327         (WebKit::NetscapePluginHostManager::instantiatePlugin):
328         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
329         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
330         (WebKit::NetscapePluginInstanceProxy::loadRequest):
331         * Plugins/WebNetscapePluginView.mm:
332         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
333         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
334         * WebCoreSupport/WebContextMenuClient.mm:
335         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
336         * WebCoreSupport/WebFrameLoaderClient.mm:
337         (WebFrameLoaderClient::transitionToCommittedForNewPage):
338         * WebView/WebFrame.mm:
339         (-[WebFrame getDictationResultRanges:andMetadatas:]):
340         * WebView/WebHTMLView.mm:
341         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
342         * WebView/WebView.mm:
343         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
344         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
345
346 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
347
348         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
349         https://bugs.webkit.org/show_bug.cgi?id=192821
350
351         Reviewed by Chris Dumez.
352
353         When a window becomes occluded, the window server informs the application.
354         This should be used to suspend any work that is not visible by the user.
355
356         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
357         In some cases, that lead to performance impact (see radar).
358
359         This patch adds an observer for the occlusion notification. I tried to stick
360         with the same names used by WebKit2.
361
362         * WebView/WebView.mm:
363         (-[WebView _isViewVisible]):
364         (-[WebView addWindowObserversForWindow:]):
365         (-[WebView removeWindowObservers]):
366         (-[WebView _windowDidChangeOcclusionState:]):
367
368 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
369
370         [WebAuthN] Add a runtime flag for local authenticator
371         https://bugs.webkit.org/show_bug.cgi?id=192792
372         <rdar://problem/46798738>
373
374         Reviewed by Brent Fulgham.
375
376         * WebView/WebPreferenceKeysPrivate.h:
377         * WebView/WebPreferences.mm:
378         (+[WebPreferences initialize]):
379         (-[WebPreferences webAuthenticationEnabled]): Deleted.
380         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
381         * WebView/WebPreferencesPrivate.h:
382         * WebView/WebView.mm:
383         (-[WebView _preferencesChanged:]):
384
385 2018-12-20  Chris Dumez  <cdumez@apple.com>
386
387         Use Optional::valueOr() instead of Optional::value_or()
388         https://bugs.webkit.org/show_bug.cgi?id=192933
389
390         Reviewed by Geoffrey Garen.
391
392         * WebCoreSupport/WebSecurityOrigin.mm:
393         (-[WebSecurityOrigin port]):
394
395 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
396
397         Unreviewed, rolling out r239417.
398
399         Introduced two API test failures on macOS.
400
401         Reverted changeset:
402
403         "<rdar://problem/46194315> macOS: WebKit1 does not handle
404         occlusion changes"
405         https://bugs.webkit.org/show_bug.cgi?id=192821
406         https://trac.webkit.org/changeset/239417
407
408 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
409
410         WKWebView default UA doesn't freeze the build number
411         https://bugs.webkit.org/show_bug.cgi?id=192809
412         <rdar://problem/44687185>
413
414         Reviewed by Andy Estes.
415
416         Always reports the frozen build number.
417
418         * WebView/WebView.mm:
419         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
420         actual build number through this method call.
421         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
422
423 2018-12-19  Chris Dumez  <cdumez@apple.com>
424
425         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
426         https://bugs.webkit.org/show_bug.cgi?id=192728
427         <rdar://problem/46746779>
428
429         Reviewed by Geoff Garen.
430
431         * DOM/*:
432         * Plugins/*:
433         * WebCoreSupport/*:
434         * WebView/*:
435
436 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
437
438         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
439         https://bugs.webkit.org/show_bug.cgi?id=192821
440
441         Reviewed by Chris Dumez.
442
443         When a window becomes occluded, the window server informs the application.
444         This should be used to suspend any work that is not visible by the user.
445
446         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
447         In some cases, that lead to performance impact (see radar).
448
449         This patch adds an observer for the occlusion notification. I tried to stick
450         with the same names used by WebKit2.
451
452         * WebView/WebView.mm:
453         (-[WebView _isViewVisible]):
454         (-[WebView addWindowObserversForWindow:]):
455         (-[WebView removeWindowObservers]):
456         (-[WebView _windowDidChangeOcclusionState:]):
457
458 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
459
460         Allow clients to set the navigator platform
461         https://bugs.webkit.org/show_bug.cgi?id=192735
462
463         Reviewed by Tim Horton.
464
465         Add stubs to fill out the added functionality in FrameLoaderClient.
466
467         * WebCoreSupport/WebFrameLoaderClient.h:
468         * WebCoreSupport/WebFrameLoaderClient.mm:
469         (WebFrameLoaderClient::navigatorPlatform):
470
471 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
472
473         offsetLeft and offsetParent should adjust across shadow boundaries
474         https://bugs.webkit.org/show_bug.cgi?id=157437
475         <rdar://problem/26154021>
476
477         Reviewed by Simon Fraser.
478
479         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
480
481         * DOM/DOMElement.mm:
482         (-[DOMElement offsetLeft]):
483         (-[DOMElement offsetTop]):
484         (-[DOMElement offsetParent]):
485
486 2018-12-17  Zalan Bujtas  <zalan@apple.com>
487
488         Unreviewed build fix.
489
490         * WebView/WebFrame.mm:
491         (-[WebFrame getDictationResultRanges:andMetadatas:]):
492
493 2018-12-15  Darin Adler  <darin@apple.com>
494
495         Use warning-ignoring macros more consistently and simply
496         https://bugs.webkit.org/show_bug.cgi?id=192743
497
498         Reviewed by Mark Lam.
499
500         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
501         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
502         compilers in Objective-C++ code.
503
504         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
505         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
506         accomodate non-clang compilers here. Also use #pragma once, add a missing
507         "explicit" and fix conditionals.
508
509 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
510
511         Make TextInputController.legacyAttributedString take DOM nodes and offsets
512         https://bugs.webkit.org/show_bug.cgi?id=192653
513
514         Reviewed by Wenson Hsieh.
515
516         * WebView/WebHTMLView.mm:
517         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
518
519 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
520
521         Implement feature flag for CSS Typed OM
522         https://bugs.webkit.org/show_bug.cgi?id=192610
523
524         Reviewed by Ryosuke Niwa.
525
526         * Configurations/FeatureDefines.xcconfig:
527
528 2018-12-11  Tim Horton  <timothy_horton@apple.com>
529
530         WebCore shouldn't have a Objective-C class named NSCursor
531         https://bugs.webkit.org/show_bug.cgi?id=192602
532         <rdar://problem/46615532>
533
534         Reviewed by Wenson Hsieh.
535
536         * WebView/WebFrameView.mm:
537         (-[WebFrameView keyDown:keyDown:]):
538         * WebView/WebHTMLView.mm:
539         (-[WebHTMLView keyDown:]):
540         (-[WebHTMLView performKeyEquivalent:]):
541         Only use NSCursor on macOS.
542
543 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
544
545         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
546         https://bugs.webkit.org/show_bug.cgi?id=192573
547
548         Reviewed by Simon Fraser.
549
550         * Configurations/FeatureDefines.xcconfig:
551
552 2018-12-10  Antti Koivisto  <antti@apple.com>
553
554         Rename "forced style recalc" to "full style rebuild"
555         https://bugs.webkit.org/show_bug.cgi?id=192572
556
557         Reviewed by Zalan Bujtas.
558
559         * WebView/WebHTMLView.mm:
560         (-[WebHTMLView setNeedsToApplyStyles:]):
561
562 2018-12-10  Darin Adler  <darin@apple.com>
563
564         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
565         https://bugs.webkit.org/show_bug.cgi?id=192533
566         rdar://problem/45732710
567
568         Reviewed by Anders Carlsson.
569
570         * Plugins/Hosted/NetscapePluginHostProxy.mm:
571         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
572
573 2018-12-10  Darin Adler  <darin@apple.com>
574
575         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
576         https://bugs.webkit.org/show_bug.cgi?id=192532
577         rdar://problem/45731047
578
579         Reviewed by Chris Dumez.
580
581         * Plugins/Hosted/NetscapePluginHostManager.mm:
582         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
583         * Plugins/Hosted/NetscapePluginHostProxy.mm:
584         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
585
586 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
587
588         Turn WritingDirection into an enum class
589         https://bugs.webkit.org/show_bug.cgi?id=192401
590         Work towards <rdar://problem/42075638>
591
592         Reviewed by Dan Bernstein.
593
594         Change WritingDirection from an enum to an enum class. No change in behavior.
595
596         * WebView/WebHTMLView.mm:
597         (-[WebHTMLView toggleBaseWritingDirection:]):
598         (-[WebHTMLView changeBaseWritingDirection:]):
599         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
600
601 2018-12-03  Alex Christensen  <achristensen@webkit.org>
602
603         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
604         https://bugs.webkit.org/show_bug.cgi?id=192272
605
606         Reviewed by Brady Eidson.
607
608         * WebCoreSupport/WebFrameLoaderClient.h:
609         * WebCoreSupport/WebFrameLoaderClient.mm:
610         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
611
612 2018-12-03  Jer Noble  <jer.noble@apple.com>
613
614         Get rid of old, dead Mac video fullscreen code.
615         https://bugs.webkit.org/show_bug.cgi?id=192315
616
617         Reviewed by Eric Carlson.
618
619         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
620         is no longer supported in the Mac port.
621
622         * WebView/WebVideoFullscreenController.h: Removed.
623         * WebView/WebVideoFullscreenController.mm: Removed.
624         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
625         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
626         * WebView/WebView.mm:
627         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
628         (-[WebView _exitVideoFullscreen]):
629
630 2018-12-03  Daniel Bates  <dabates@apple.com>
631
632         [iOS] Do not handle key events that are key commands
633         https://bugs.webkit.org/show_bug.cgi?id=191608
634         <rdar://problem/46046013>
635
636         Reviewed by Ryosuke Niwa.
637
638         A key down event may be associated with a key command. If it is then we want to execute the
639         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
640         event as a key command to find out.
641
642         * WebView/WebHTMLView.mm:
643         (-[WebHTMLView _handleEditingKeyEvent:]):
644
645 2018-12-02  Zalan Bujtas  <zalan@apple.com>
646
647         Add a runtime feature flag for LayoutFormattingContext.
648         https://bugs.webkit.org/show_bug.cgi?id=192280
649
650         Reviewed by Simon Fraser.
651
652         * Configurations/FeatureDefines.xcconfig:
653
654 2018-11-30  Alex Christensen  <achristensen@webkit.org>
655
656         Move URL from WebCore to WTF
657         https://bugs.webkit.org/show_bug.cgi?id=190234
658
659         Reviewed by Keith Miller.
660
661         * DOM/DOMAttr.mm:
662         * DOM/DOMBlob.mm:
663         * DOM/DOMCSSCharsetRule.mm:
664         * DOM/DOMCSSImportRule.mm:
665         * DOM/DOMCSSMediaRule.mm:
666         * DOM/DOMCSSPageRule.mm:
667         * DOM/DOMCSSPrimitiveValue.mm:
668         * DOM/DOMCSSRule.mm:
669         * DOM/DOMCSSStyleDeclaration.mm:
670         * DOM/DOMCSSStyleRule.mm:
671         * DOM/DOMCSSStyleSheet.mm:
672         * DOM/DOMCSSValue.mm:
673         * DOM/DOMCharacterData.mm:
674         * DOM/DOMCounter.mm:
675         * DOM/DOMDocument.mm:
676         * DOM/DOMDocumentFragment.mm:
677         * DOM/DOMDocumentType.mm:
678         * DOM/DOMEvent.mm:
679         * DOM/DOMFile.mm:
680         * DOM/DOMHTMLAnchorElement.mm:
681         * DOM/DOMHTMLAppletElement.mm:
682         * DOM/DOMHTMLAreaElement.mm:
683         * DOM/DOMHTMLBRElement.mm:
684         * DOM/DOMHTMLBaseElement.mm:
685         * DOM/DOMHTMLBaseFontElement.mm:
686         * DOM/DOMHTMLBodyElement.mm:
687         * DOM/DOMHTMLButtonElement.mm:
688         * DOM/DOMHTMLCanvasElement.mm:
689         * DOM/DOMHTMLCollection.mm:
690         * DOM/DOMHTMLDivElement.mm:
691         * DOM/DOMHTMLDocument.mm:
692         * DOM/DOMHTMLElement.mm:
693         * DOM/DOMHTMLEmbedElement.mm:
694         * DOM/DOMHTMLFieldSetElement.mm:
695         * DOM/DOMHTMLFontElement.mm:
696         * DOM/DOMHTMLFormElement.mm:
697         * DOM/DOMHTMLFrameElement.mm:
698         * DOM/DOMHTMLFrameSetElement.mm:
699         * DOM/DOMHTMLHRElement.mm:
700         * DOM/DOMHTMLHeadElement.mm:
701         * DOM/DOMHTMLHeadingElement.mm:
702         * DOM/DOMHTMLHtmlElement.mm:
703         * DOM/DOMHTMLIFrameElement.mm:
704         * DOM/DOMHTMLImageElement.mm:
705         * DOM/DOMHTMLInputElement.mm:
706         * DOM/DOMHTMLLIElement.mm:
707         * DOM/DOMHTMLLabelElement.mm:
708         * DOM/DOMHTMLLegendElement.mm:
709         * DOM/DOMHTMLLinkElement.mm:
710         * DOM/DOMHTMLMapElement.mm:
711         * DOM/DOMHTMLMarqueeElement.mm:
712         * DOM/DOMHTMLMediaElement.mm:
713         * DOM/DOMHTMLMetaElement.mm:
714         * DOM/DOMHTMLModElement.mm:
715         * DOM/DOMHTMLOListElement.mm:
716         * DOM/DOMHTMLObjectElement.mm:
717         * DOM/DOMHTMLOptGroupElement.mm:
718         * DOM/DOMHTMLOptionElement.mm:
719         * DOM/DOMHTMLOptionsCollection.mm:
720         * DOM/DOMHTMLParagraphElement.mm:
721         * DOM/DOMHTMLParamElement.mm:
722         * DOM/DOMHTMLQuoteElement.mm:
723         * DOM/DOMHTMLScriptElement.mm:
724         * DOM/DOMHTMLSelectElement.mm:
725         * DOM/DOMHTMLStyleElement.mm:
726         * DOM/DOMHTMLTableCaptionElement.mm:
727         * DOM/DOMHTMLTableCellElement.mm:
728         * DOM/DOMHTMLTableColElement.mm:
729         * DOM/DOMHTMLTableElement.mm:
730         * DOM/DOMHTMLTableRowElement.mm:
731         * DOM/DOMHTMLTableSectionElement.mm:
732         * DOM/DOMHTMLTitleElement.mm:
733         * DOM/DOMHTMLUListElement.mm:
734         * DOM/DOMHTMLVideoElement.mm:
735         * DOM/DOMKeyboardEvent.mm:
736         * DOM/DOMMediaList.mm:
737         * DOM/DOMMouseEvent.mm:
738         * DOM/DOMMutationEvent.mm:
739         * DOM/DOMNamedNodeMap.mm:
740         * DOM/DOMProcessingInstruction.mm:
741         * DOM/DOMRange.mm:
742         * DOM/DOMStyleSheet.mm:
743         * DOM/DOMText.mm:
744         * DOM/DOMTextEvent.mm:
745         * DOM/DOMTokenList.mm:
746         * DOM/DOMUIEvent.mm:
747         * DOM/DOMXPathResult.mm:
748         * History/WebHistoryItem.mm:
749         * Misc/WebNSURLExtras.mm:
750         (-[NSURL _web_userVisibleString]):
751         (-[NSURL _web_URLByRemovingUserInfo]):
752         (-[NSURL _web_dataForURLComponentType:]):
753         (-[NSURL _web_schemeData]):
754         (-[NSURL _web_hostData]):
755         * Misc/WebUserContentURLPattern.mm:
756         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
757         * Plugins/WebNetscapePluginStream.h:
758         (WebNetscapePluginStream::setRequestURL):
759         * WebCoreSupport/WebChromeClient.h:
760         * WebCoreSupport/WebChromeClient.mm:
761         (WebChromeClient::signedPublicKeyAndChallengeString const):
762         * WebCoreSupport/WebContextMenuClient.h:
763         * WebCoreSupport/WebContextMenuClient.mm:
764         * WebCoreSupport/WebDragClient.h:
765         * WebCoreSupport/WebFrameLoaderClient.h:
766         * WebCoreSupport/WebFrameLoaderClient.mm:
767         (WebFrameLoaderClient::updateGlobalHistory):
768         * WebCoreSupport/WebPaymentCoordinatorClient.h:
769         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
770         (WebPaymentCoordinatorClient::showPaymentUI):
771         * WebCoreSupport/WebPlatformStrategies.h:
772         * WebCoreSupport/WebPlatformStrategies.mm:
773         (WebPlatformStrategies::readURLFromPasteboard):
774         * WebCoreSupport/WebPluginInfoProvider.h:
775         * WebCoreSupport/WebPluginInfoProvider.mm:
776         (WebPluginInfoProvider::webVisiblePluginInfo):
777         * WebCoreSupport/WebSecurityOrigin.mm:
778         * WebCoreSupport/WebVisitedLinkStore.h:
779         * WebView/WebDataSource.mm:
780         * WebView/WebFrame.mm:
781         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
782         * WebView/WebImmediateActionController.mm:
783         (-[WebImmediateActionController _defaultAnimationController]):
784         * WebView/WebPDFView.mm:
785         * WebView/WebScriptDebugger.mm:
786         * WebView/WebViewInternal.h:
787
788 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
789
790         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
791         https://bugs.webkit.org/show_bug.cgi?id=192197
792
793         Reviewed by Jiewen Tan.
794
795         * Configurations/FeatureDefines.xcconfig:
796         * WebCoreSupport/WebChromeClient.h:
797         * WebCoreSupport/WebChromeClient.mm:
798
799 2018-11-28  Alex Christensen  <achristensen@webkit.org>
800
801         Remove dead code from an earlier attempt at implementing safe browsing
802         https://bugs.webkit.org/show_bug.cgi?id=192067
803
804         Reviewed by Chris Dumez.
805
806         * WebCoreSupport/WebFrameLoaderClient.h:
807         * WebCoreSupport/WebFrameLoaderClient.mm:
808         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
809
810 2018-11-27  Mark Lam  <mark.lam@apple.com>
811
812         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
813         https://bugs.webkit.org/show_bug.cgi?id=192055
814         <rdar://problem/46288783>
815
816         Reviewed by Saam Barati.
817
818         * Configurations/FeatureDefines.xcconfig:
819
820 2018-11-25  Tim Horton  <timothy_horton@apple.com>
821
822         Make it possible to insert editable images with a gesture
823         https://bugs.webkit.org/show_bug.cgi?id=191937
824
825         Reviewed by Wenson Hsieh.
826
827         * WebCoreSupport/WebEditorClient.mm:
828         (undoNameForEditAction):
829         Add a undo name.
830
831 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
832
833         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
834         https://bugs.webkit.org/show_bug.cgi?id=191945
835
836         Reviewed by Anders Carlsson.
837
838         * WebCoreSupport/WebEditorClient.mm:
839         (undoNameForEditAction):
840
841 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
842
843         Enable drag and drop support for iOSMac
844         https://bugs.webkit.org/show_bug.cgi?id=191818
845         <rdar://problem/43907454>
846
847         Reviewed by Dean Jackson.
848
849         * Configurations/FeatureDefines.xcconfig:
850
851 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
852
853         Address post-review feedback after r238438
854         https://bugs.webkit.org/show_bug.cgi?id=191913
855
856         Reviewed by Ryosuke Niwa.
857
858         * WebView/WebFrame.mm:
859         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
860         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
861         * WebView/WebView.mm:
862         (-[WebView setSelectedDOMRange:affinity:]):
863
864 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
865
866         Web Inspector: "Reload Web Inspector" button no longer partially works
867         https://bugs.webkit.org/show_bug.cgi?id=191773
868         <rdar://problem/46139932>
869
870         Reviewed by Devin Rousso.
871
872         * WebCoreSupport/WebInspectorClient.h:
873         * WebCoreSupport/WebInspectorClient.mm:
874         (WebInspectorFrontendClient::reopen):
875
876 2018-11-17  Devin Rousso  <drousso@apple.com>
877
878         Web Inspector: Network: add button to show system certificate dialog
879         https://bugs.webkit.org/show_bug.cgi?id=191458
880         <rdar://problem/45977019>
881
882         Reviewed by Joseph Pecoraro.
883
884         * WebCoreSupport/WebInspectorClient.h:
885         * WebCoreSupport/WebInspectorClient.mm:
886         (WebInspectorFrontendClient::showCertificate): Added.
887
888         * Configurations/WebKitLegacy.xcconfig:
889
890 2018-11-15  Truitt Savell  <tsavell@apple.com>
891
892         Unreviewed, rolling out r238244.
893
894         Caused High Sierra test runs to fail early with 50 crashes and
895         casued 25 API failures.
896
897         Reverted changeset:
898
899         "[css-logical] Implement flow-relative margin, padding and
900         border shorthands"
901         https://bugs.webkit.org/show_bug.cgi?id=188697
902         https://trac.webkit.org/changeset/238244
903
904 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
905
906         [css-logical] Implement flow-relative margin, padding and border shorthands
907         https://bugs.webkit.org/show_bug.cgi?id=188697
908
909         Reviewed by Simon Fraser and Antti Koivisto.
910
911         Add CSSLogicalEnabled runtime flag.
912
913         * WebView/WebPreferenceKeysPrivate.h:
914         * WebView/WebPreferences.mm:
915         (+[WebPreferences initialize]):
916         (-[WebPreferences cssLogicalEnabled]):
917         (-[WebPreferences setCSSLogicalEnabled:]):
918         * WebView/WebPreferencesPrivate.h:
919         * WebView/WebView.mm:
920         (-[WebView _preferencesChanged:]):
921
922 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
923
924         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
925         https://bugs.webkit.org/show_bug.cgi?id=191612
926
927         Reviewed by Matt Baker.
928
929         * WebCoreSupport/WebInspectorClient.mm:
930         (-[WebInspectorWindowController destroyInspectorView]):
931
932 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
933
934         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
935         https://bugs.webkit.org/show_bug.cgi?id=191494
936         <rdar://problem/45469854>
937
938         Reviewed by Devin Rousso.
939
940         * WebCoreSupport/WebInspectorClient.h:
941         WebKitLegacy will still have remote inspection of the Page directly.
942
943 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
944
945         Make compositing updates incremental
946         https://bugs.webkit.org/show_bug.cgi?id=90342
947
948         Reviewed by Antti Koivisto.
949
950         Fix spelling error.
951
952         * WebView/WebView.mm:
953         (-[WebView _setMediaLayer:forPluginView:]):
954
955 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
956
957         Implement a new edit command to change the enclosing list type
958         https://bugs.webkit.org/show_bug.cgi?id=191487
959         <rdar://problem/45955922>
960
961         Reviewed by Ryosuke Niwa.
962
963         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
964
965         * WebCoreSupport/WebEditorClient.mm:
966         (undoNameForEditAction):
967
968 2018-11-11  Daniel Bates  <dabates@apple.com>
969
970         [iOS] Draw caps lock indicator in password fields
971         https://bugs.webkit.org/show_bug.cgi?id=190565
972         <rdar://problem/45262343>
973
974         Reviewed by Dean Jackson.
975
976         Update the caps lock state when a hardware keyboard is attached or detached.
977
978         * WebView/WebHTMLView.mm:
979         (hardwareKeyboardAvailabilityChangedCallback): Added.
980         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
981         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
982
983 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
984
985         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
986         https://bugs.webkit.org/show_bug.cgi?id=191492
987
988         Reviewed by Alex Christensen.
989
990         * Carbon/HIWebView.mm:
991         * Misc/WebNSFileManagerExtras.mm:
992         * Misc/WebNSURLExtras.mm:
993         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
994         * Plugins/WebBasePluginPackage.mm:
995         * Plugins/WebPluginContainerCheck.mm:
996         * WebCoreSupport/WebCachedFramePlatformData.h:
997         * WebCoreSupport/WebDeviceOrientationClient.mm:
998         * WebView/WebDelegateImplementationCaching.mm:
999         * WebView/WebHTMLView.mm:
1000         * WebView/WebPDFRepresentation.mm:
1001         * WebView/WebPolicyDelegate.mm:
1002         * WebView/WebView.mm:
1003
1004 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1005
1006         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1007         https://bugs.webkit.org/show_bug.cgi?id=191492
1008
1009         Reviewed by Alex Christensen.
1010
1011         * Carbon/HIWebView.mm:
1012         (UpdateCommandStatus):
1013         * Misc/WebNSFileManagerExtras.mm:
1014         * Misc/WebNSURLExtras.mm:
1015         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1016         * Plugins/WebBasePluginPackage.mm:
1017         * Plugins/WebPluginContainerCheck.mm:
1018         (-[WebPluginContainerCheck _continueWithPolicy:]):
1019         * WebCoreSupport/WebCachedFramePlatformData.h:
1020         (WebCachedFramePlatformData::clear):
1021         * WebCoreSupport/WebDeviceOrientationClient.mm:
1022         (WebDeviceOrientationClient::getProvider const):
1023         * WebView/WebDelegateImplementationCaching.mm:
1024         (CallDelegate):
1025         (CallDelegateReturningBoolean):
1026         (CallResourceLoadDelegateReturningBoolean):
1027         (CallFormDelegate):
1028         (CallFormDelegateReturningBoolean):
1029         * WebView/WebHTMLView.mm:
1030         * WebView/WebPDFRepresentation.mm:
1031         * WebView/WebPolicyDelegate.mm:
1032         (-[WebPolicyDecisionListener _usePolicy:]):
1033         * WebView/WebView.mm:
1034
1035 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1036
1037         Unreviewed, rolling out r238047.
1038
1039         Introduced layout test failures on iOS simulator.
1040
1041         Reverted changeset:
1042
1043         "[iOS] Draw caps lock indicator in password fields"
1044         https://bugs.webkit.org/show_bug.cgi?id=190565
1045         https://trac.webkit.org/changeset/238047
1046
1047 2018-11-09  Antti Koivisto  <antti@apple.com>
1048
1049         Use OptionSet for layout milestones
1050         https://bugs.webkit.org/show_bug.cgi?id=191470
1051
1052         Reviewed by Dean Jackson.
1053
1054         * WebCoreSupport/WebFrameLoaderClient.h:
1055         * WebCoreSupport/WebFrameLoaderClient.mm:
1056         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1057         * WebView/WebView.mm:
1058         (coreLayoutMilestones):
1059         (kitLayoutMilestones):
1060         (-[WebView _cacheFrameLoadDelegateImplementations]):
1061         * WebView/WebViewInternal.h:
1062
1063 2018-11-09  Daniel Bates  <dabates@apple.com>
1064
1065         [iOS] Draw caps lock indicator in password fields
1066         https://bugs.webkit.org/show_bug.cgi?id=190565
1067         <rdar://problem/45262343>
1068
1069         Reviewed by Dean Jackson.
1070
1071         Update the caps lock state when a hardware keyboard is attached or detached.
1072
1073         * WebView/WebHTMLView.mm:
1074         (hardwareKeyboardAvailabilityChangedCallback): Added.
1075         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1076         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1077
1078 2018-11-09  Daniel Bates  <dabates@apple.com>
1079
1080         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1081         action when forward delete is pressed outside a text field
1082         https://bugs.webkit.org/show_bug.cgi?id=190566
1083         <rdar://problem/45262367>
1084
1085         Reviewed by Wenson Hsieh.
1086
1087         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1088         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1089         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1090
1091         * WebView/WebHTMLView.mm:
1092         (-[WebHTMLView _handleEditingKeyEvent:]):
1093
1094 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1095
1096         Adopt Reveal Framework to replace Lookup
1097         https://bugs.webkit.org/show_bug.cgi?id=191097
1098         <rdar://problem/45924508>
1099
1100         Reviewed by Tim Horton.
1101
1102         Pass in what it needed to clear the textIndicators. This is better than
1103         the current notification structure.
1104
1105         * WebView/WebView.mm:
1106         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1107         (-[WebView _prepareForDictionaryLookup]):
1108
1109 2018-11-06  Justin Fan  <justin_fan@apple.com>
1110
1111         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1112         https://bugs.webkit.org/show_bug.cgi?id=191291
1113
1114         Reviewed by Myles Maxfield.
1115
1116         Properly disable WEBGPU on all non-Metal platforms for now.
1117
1118         * Configurations/FeatureDefines.xcconfig:
1119
1120 2018-11-02  Daniel Bates  <dabates@apple.com>
1121
1122         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1123         https://bugs.webkit.org/show_bug.cgi?id=190487
1124
1125         Reviewed by Tim Horton.
1126
1127         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1128         allow the default handling.
1129
1130         * WebView/WebHTMLView.mm:
1131         (-[WebHTMLView _handleEditingKeyEvent:]):
1132
1133 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1134
1135         Add a storage limit for IndexedDB
1136         https://bugs.webkit.org/show_bug.cgi?id=190598
1137         <rdar://problem/44654715>
1138
1139         Reviewed by Chris Dumez.
1140
1141         * Storage/WebDatabaseManager.mm:
1142         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1143         * Storage/WebDatabaseManagerPrivate.h:
1144
1145 2018-10-31  Antti Koivisto  <antti@apple.com>
1146
1147         Remove LayerFlushScheduler
1148         https://bugs.webkit.org/show_bug.cgi?id=191103
1149
1150         Reviewed by Anders Carlsson.
1151
1152         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1153         all the virtual cruft.
1154
1155         * WebView/WebViewData.h:
1156         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1157         (): Deleted.
1158         * WebView/WebViewData.mm:
1159         (currentRunLoop):
1160         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1161         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1162         (WebViewLayerFlushScheduler::schedule):
1163         (WebViewLayerFlushScheduler::invalidate):
1164         (WebViewLayerFlushScheduler::layerFlushCallback):
1165
1166 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1167
1168         Enable InstallAPI for iOS unconditionally
1169         https://bugs.webkit.org/show_bug.cgi?id=191043
1170         rdar://problem/32728423
1171
1172         Reviewed by Dan Bernstein.
1173
1174         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1175         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1176         shouldn't be processed by InstallAPI.
1177         * MigrateHeaders.make: Removed an obsolete workaround.
1178         * Misc/NSURLDownloadSPI.h: Added.
1179         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1180
1181 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1182
1183         Clean up some obsolete MAX_ALLOWED macros
1184         https://bugs.webkit.org/show_bug.cgi?id=190916
1185
1186         Reviewed by Tim Horton.
1187
1188         * WebView/WebHTMLView.mm:
1189         (-[WebHTMLView pressureChangeWithEvent:]):
1190         * WebView/WebPDFView.h:
1191
1192 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1193
1194         Unreviewed, rolling out r237600 and r237604.
1195         https://bugs.webkit.org/show_bug.cgi?id=191086
1196
1197         Breaks internal iOS builds (Requested by ryanhadd_ on
1198         #webkit).
1199
1200         Reverted changesets:
1201
1202         "Enable InstallAPI for iOS unconditionally"
1203         https://bugs.webkit.org/show_bug.cgi?id=191043
1204         https://trac.webkit.org/changeset/237600
1205
1206         "Build fix attempt after enabling InstallAPI for iOS."
1207         https://bugs.webkit.org/show_bug.cgi?id=191043
1208         https://trac.webkit.org/changeset/237604
1209
1210 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1211
1212         Enable InstallAPI for iOS unconditionally
1213         https://bugs.webkit.org/show_bug.cgi?id=191043
1214         rdar://problem/32728423
1215
1216         Reviewed by Dan Bernstein.
1217
1218         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1219         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1220         shouldn't be processed by InstallAPI.
1221         * MigrateHeaders.make: Removed an obsolete workaround.
1222         * Misc/NSURLDownloadSPI.h: Added.
1223         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1224
1225 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1226
1227         Modernize WebKit nibs and lprojs for localization's sake
1228         https://bugs.webkit.org/show_bug.cgi?id=190911
1229         <rdar://problem/45349466>
1230
1231         Reviewed by Dan Bernstein.
1232
1233         * Misc/WebNSControlExtras.m:
1234         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1235         NSWindow and its contents are both in the same scale space these days; avoid
1236         double-applying the scale factor, or you can't see the prompt.
1237
1238         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1239         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1240         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1241         NIB->XIB
1242
1243 2018-10-25  Antoine Quint  <graouts@apple.com>
1244
1245         [Web Animations] Turn Web Animations CSS Integration off by default
1246         https://bugs.webkit.org/show_bug.cgi?id=190901
1247
1248         Reviewed by Dean Jackson.
1249
1250         * WebView/WebPreferences.mm:
1251         (+[WebPreferences initialize]):
1252
1253 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1254
1255         Clean up some obsolete macOS version guards
1256         https://bugs.webkit.org/show_bug.cgi?id=190887
1257
1258         Reviewed by Dan Bernstein.
1259
1260         * Misc/WebNSPasteboardExtras.mm:
1261         (+[NSPasteboard _web_dragTypesForURL]):
1262         * WebCoreSupport/PopupMenuMac.mm:
1263         (PopupMenuMac::show):
1264         * WebCoreSupport/WebEditorClient.h:
1265         * WebCoreSupport/WebEditorClient.mm:
1266         (WebEditorClient::respondToChangedSelection):
1267         * WebView/WebPDFView.mm:
1268         (-[WebPDFView _clipViewForPDFDocumentView]):
1269
1270 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1271
1272         Turn on Conic Gradients
1273         https://bugs.webkit.org/show_bug.cgi?id=190810
1274
1275         Reviewed by Tim Horton.
1276
1277         * Configurations/FeatureDefines.xcconfig:
1278
1279 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1280
1281         Cleanup: MIMETypeRegistry functions
1282         https://bugs.webkit.org/show_bug.cgi?id=190838
1283
1284         Reviewed by Simon Fraser.
1285
1286         * Misc/WebNSPasteboardExtras.mm:
1287         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1288         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1289         because they were identical.
1290
1291         * WebView/WebHTMLRepresentation.mm:
1292         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1293         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1294         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1295         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1296         * WebView/WebView.mm:
1297         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1298         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1299         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1300
1301 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1302
1303         Fix false positive leaks when using custom -init methods that don't start with -init
1304         <https://webkit.org/b/190818>
1305         <rdar://problem/45476042>
1306
1307         Reviewed by Dan Bernstein.
1308
1309         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1310         it is accessible by both categories.
1311         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1312         NSError (WebKitInternal) category.  Add attribute to make this
1313         behave like an -init method.
1314         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1315         NSError (WebKitInternal) category.  Modernize method.  Replace
1316         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1317
1318 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1319
1320         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1321         https://bugs.webkit.org/show_bug.cgi?id=190729
1322
1323         Reviewed by Tim Horton.
1324
1325         * DOM/DOM.mm:
1326         (-[DOMNode boundingBox]):
1327         * DOM/DOMElement.mm:
1328         * DOM/DOMHTML.mm:
1329         * DOM/DOMInternal.mm:
1330         * DOM/DOMUIKitExtensions.mm:
1331         * DOM/WebDOMOperations.mm:
1332         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1333         * DefaultDelegates/WebDefaultEditingDelegate.m:
1334         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1335         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1336         * DefaultDelegates/WebDefaultUIDelegate.h:
1337         * DefaultDelegates/WebDefaultUIDelegate.mm:
1338         (-[WebDefaultUIDelegate webViewClose:]):
1339         (-[WebDefaultUIDelegate webViewFocus:]):
1340         (-[WebDefaultUIDelegate webViewUnfocus:]):
1341         (-[WebDefaultUIDelegate webViewIsResizable:]):
1342         (-[WebDefaultUIDelegate webView:setResizable:]):
1343         (-[WebDefaultUIDelegate webView:setFrame:]):
1344         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1345         * History/BackForwardList.h:
1346         * History/BackForwardList.mm:
1347         * History/WebBackForwardList.mm:
1348         (+[WebBackForwardList initialize]):
1349         (bumperCarBackForwardHackNeeded):
1350         * History/WebHistory.mm:
1351         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1352         (-[WebHistory _sendNotification:entries:]):
1353         (-[WebHistory loadFromURL:error:]):
1354         (-[WebHistory saveToURL:error:]):
1355         * History/WebHistoryItem.mm:
1356         (WKNotifyHistoryItemChanged):
1357         (+[WebHistoryItem initialize]):
1358         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1359         * History/WebURLsWithTitles.m:
1360         * Misc/WebCache.mm:
1361         (+[WebCache initialize]):
1362         * Misc/WebDownload.mm:
1363         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1364         * Misc/WebElementDictionary.mm:
1365         (+[WebElementDictionary initialize]):
1366         (+[WebElementDictionary initializeLookupTable]):
1367         * Misc/WebIconDatabase.mm:
1368         * Misc/WebKitNSStringExtras.mm:
1369         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1370         * Misc/WebKitVersionChecks.h:
1371         * Misc/WebKitVersionChecks.mm:
1372         (WebKitLinkedOnOrAfter):
1373         (WebKitLinkTimeVersion):
1374         * Misc/WebLocalizableStrings.mm:
1375         * Misc/WebNSControlExtras.h:
1376         * Misc/WebNSControlExtras.m:
1377         * Misc/WebNSEventExtras.m:
1378         * Misc/WebNSFileManagerExtras.mm:
1379         * Misc/WebNSImageExtras.h:
1380         * Misc/WebNSImageExtras.m:
1381         * Misc/WebNSPasteboardExtras.mm:
1382         * Misc/WebNSPrintOperationExtras.h:
1383         * Misc/WebNSPrintOperationExtras.m:
1384         * Misc/WebNSViewExtras.m:
1385         * Misc/WebNSWindowExtras.m:
1386         * Panels/WebAuthenticationPanel.h:
1387         * Panels/WebAuthenticationPanel.m:
1388         * Panels/WebPanelAuthenticationHandler.m:
1389         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1390         (+[WebHostedNetscapePluginView initialize]):
1391         * Plugins/WebBasePluginPackage.h:
1392         * Plugins/WebBasePluginPackage.mm:
1393         * Plugins/WebJavaPlugIn.h:
1394         * Plugins/WebPluginContainerCheck.mm:
1395         * Plugins/WebPluginController.h:
1396         * Plugins/WebPluginController.mm:
1397         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1398         (-[WebPluginController addPlugin:]):
1399         (-[WebPluginController destroyPlugin:]):
1400         (-[WebPluginController destroyAllPlugins]):
1401         * Plugins/WebPluginDatabase.mm:
1402         (+[WebPluginDatabase _defaultPlugInPaths]):
1403         * Plugins/WebPluginPackage.mm:
1404         (-[WebPluginPackage initWithPath:]):
1405         * Storage/WebDatabaseManager.mm:
1406         (-[WebDatabaseManager deleteAllDatabases]):
1407         * Storage/WebDatabaseManagerClient.h:
1408         * Storage/WebDatabaseManagerClient.mm:
1409         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1410         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1411         * Storage/WebStorageManager.mm:
1412         (-[WebStorageManager deleteAllOrigins]):
1413         (WebKitInitializeStorageIfNecessary):
1414         * WebCoreSupport/WebAlternativeTextClient.h:
1415         * WebCoreSupport/WebApplicationCache.mm:
1416         (applicationCacheBundleIdentifier):
1417         * WebCoreSupport/WebChromeClient.h:
1418         * WebCoreSupport/WebChromeClient.mm:
1419         (WebChromeClient::setWindowRect):
1420         (WebChromeClient::windowRect):
1421         (WebChromeClient::takeFocus):
1422         (WebChromeClient::addMessageToConsole):
1423         (WebChromeClient::enableSuddenTermination):
1424         (WebChromeClient::disableSuddenTermination):
1425         (WebChromeClient::createPopupMenu const):
1426         (WebChromeClient::createSearchPopupMenu const):
1427         (WebChromeClient::shouldPaintEntireContents const):
1428         (WebChromeClient::supportsVideoFullscreen):
1429         (WebChromeClient::supportsFullScreenForElement):
1430         (WebChromeClient::enterFullScreenForElement):
1431         (WebChromeClient::exitFullScreenForElement):
1432         * WebCoreSupport/WebContextMenuClient.mm:
1433         * WebCoreSupport/WebDragClient.mm:
1434         * WebCoreSupport/WebEditorClient.h:
1435         * WebCoreSupport/WebEditorClient.mm:
1436         (+[WebUndoStep initialize]):
1437         (updateFontPanel):
1438         (WebEditorClient::didBeginEditing):
1439         (WebEditorClient::respondToChangedContents):
1440         (WebEditorClient::respondToChangedSelection):
1441         (WebEditorClient::canceledComposition):
1442         (WebEditorClient::didEndEditing):
1443         (WebEditorClient::didWriteSelectionToPasteboard):
1444         (attributesForAttributedStringConversion):
1445         (WebEditorClient::setInsertionPasteboard):
1446         (WebEditorClient::registerUndoOrRedoStep):
1447         (WebEditorClient::handleKeyboardEvent):
1448         (WebEditorClient::handleInputMethodKeydown):
1449         (WebEditorClient::textDidChangeInTextField):
1450         (WebEditorClient::requestCheckingOfString):
1451         * WebCoreSupport/WebFrameLoaderClient.h:
1452         * WebCoreSupport/WebFrameLoaderClient.mm:
1453         (WebFrameLoaderClient::detachedFromParent2):
1454         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1455         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1456         (WebFrameLoaderClient::dispatchWillSendRequest):
1457         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1458         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1459         (WebFrameLoaderClient::willCacheResponse const):
1460         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1461         (WebFrameLoaderClient::dispatchDidFinishLoading):
1462         (WebFrameLoaderClient::dispatchDidFailLoading):
1463         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1464         (WebFrameLoaderClient::dispatchWillClose):
1465         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1466         (WebFrameLoaderClient::dispatchDidCommitLoad):
1467         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1468         (WebFrameLoaderClient::dispatchDidFailLoad):
1469         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1470         (WebFrameLoaderClient::dispatchDidFinishLoad):
1471         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1472         (WebFrameLoaderClient::willChangeTitle):
1473         (WebFrameLoaderClient::didChangeTitle):
1474         (WebFrameLoaderClient::didReplaceMultipartContent):
1475         (WebFrameLoaderClient::updateGlobalHistory):
1476         (WebFrameLoaderClient::saveViewStateToItem):
1477         (WebFrameLoaderClient::restoreViewState):
1478         (WebFrameLoaderClient::provisionalLoadStarted):
1479         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1480         (WebFrameLoaderClient::setTitle):
1481         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1482         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1483         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1484         (WebFrameLoaderClient::didRestoreFromPageCache):
1485         (WebFrameLoaderClient::actionDictionary const):
1486         (WebFrameLoaderClient::createPlugin):
1487         (WebFrameLoaderClient::getLoadDecisionForIcons):
1488         (WebFrameLoaderClient::finishedLoadingIcon):
1489         (+[WebFramePolicyListener initialize]):
1490         * WebCoreSupport/WebFrameNetworkingContext.mm:
1491         * WebCoreSupport/WebGeolocationClient.h:
1492         * WebCoreSupport/WebGeolocationClient.mm:
1493         (WebGeolocationClient::requestPermission):
1494         * WebCoreSupport/WebInspectorClient.h:
1495         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1496         * WebCoreSupport/WebNotificationClient.mm:
1497         * WebCoreSupport/WebOpenPanelResultListener.mm:
1498         * WebCoreSupport/WebPlatformStrategies.h:
1499         * WebCoreSupport/WebPlatformStrategies.mm:
1500         * WebCoreSupport/WebProgressTrackerClient.h:
1501         * WebCoreSupport/WebProgressTrackerClient.mm:
1502         (WebProgressTrackerClient::progressStarted):
1503         (WebProgressTrackerClient::progressEstimateChanged):
1504         (WebProgressTrackerClient::progressFinished):
1505         * WebCoreSupport/WebSecurityOrigin.mm:
1506         * WebInspector/WebNodeHighlight.h:
1507         * WebInspector/WebNodeHighlight.mm:
1508         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1509         (-[WebNodeHighlight dealloc]):
1510         (-[WebNodeHighlight attach]):
1511         * WebInspector/WebNodeHighlightView.h:
1512         * WebInspector/WebNodeHighlightView.mm:
1513         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1514         (-[WebNodeHighlightView dealloc]):
1515         * WebInspector/WebNodeHighlighter.mm:
1516         (-[WebNodeHighlighter highlight]):
1517         * WebView/WebArchive.mm:
1518         (+[WebArchivePrivate initialize]):
1519         * WebView/WebClipView.h:
1520         * WebView/WebDataSource.mm:
1521         (WebDataSourcePrivate::WebDataSourcePrivate):
1522         (+[WebDataSource initialize]):
1523         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1524         (-[WebDataSource _makeRepresentation]):
1525         * WebView/WebDelegateImplementationCaching.h:
1526         * WebView/WebDelegateImplementationCaching.mm:
1527         (CallDelegate):
1528         (CallDelegateReturningFloat):
1529         (CallDelegateReturningBoolean):
1530         (CallUIDelegate):
1531         (CallUIDelegateReturningFloat):
1532         (CallUIDelegateReturningBoolean):
1533         (CallFrameLoadDelegate):
1534         (CallFrameLoadDelegateReturningBoolean):
1535         (CallResourceLoadDelegate):
1536         (CallScriptDebugDelegate):
1537         (CallFormDelegate):
1538         (CallFormDelegateReturningBoolean):
1539         * WebView/WebDeviceOrientation.mm:
1540         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1541         * WebView/WebDocumentInternal.h:
1542         * WebView/WebDocumentLoaderMac.mm:
1543         (needsDataLoadWorkaround):
1544         * WebView/WebDynamicScrollBarsViewInternal.h:
1545         * WebView/WebFormDelegate.m:
1546         * WebView/WebFrame.mm:
1547         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1548         (-[WebFrame _unmarkAllMisspellings]):
1549         (-[WebFrame _paintBehaviorForDestinationContext:]):
1550         (-[WebFrame _drawRect:contentsOnly:]):
1551         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1552         (-[WebFrame _scrollDOMRangeToVisible:]):
1553         (-[WebFrame _bodyBackgroundColor]):
1554         (-[WebFrame accessibilityRoot]):
1555         (needsMicrosoftMessengerDOMDocumentWorkaround):
1556         * WebView/WebFrameInternal.h:
1557         * WebView/WebFrameView.mm:
1558         (-[WebFrameView _setDocumentView:]):
1559         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1560         (-[WebFrameView _viewClassForMIMEType:]):
1561         (-[WebFrameView initWithFrame:]):
1562         (-[WebFrameView drawRect:]):
1563         (-[WebFrameView _firstResponderIsFormControl]):
1564         (-[WebFrameView keyDown:keyDown:]):
1565         (-[WebFrameView _isScrollable]):
1566         * WebView/WebFullScreenController.h:
1567         * WebView/WebFullScreenController.mm:
1568         * WebView/WebHTMLRepresentation.mm:
1569         * WebView/WebHTMLView.mm:
1570         (-[WebHTMLView hitTest:]):
1571         (-[WebHTMLView initWithFrame:]):
1572         (-[WebHTMLView dealloc]):
1573         (-[WebHTMLView addSubview:]):
1574         (-[WebHTMLView mouseDown:]):
1575         (-[WebHTMLView mouseUp:]):
1576         (-[WebHTMLView resignFirstResponder]):
1577         (-[WebHTMLView accessibilityHitTest:]):
1578         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1579         * WebView/WebHTMLViewInternal.h:
1580         * WebView/WebIndicateLayer.h:
1581         * WebView/WebIndicateLayer.mm:
1582         * WebView/WebMediaPlaybackTargetPicker.h:
1583         * WebView/WebMediaPlaybackTargetPicker.mm:
1584         * WebView/WebPDFDocumentExtras.h:
1585         * WebView/WebPDFDocumentExtras.mm:
1586         * WebView/WebPDFRepresentation.h:
1587         * WebView/WebPDFRepresentation.mm:
1588         * WebView/WebPDFView.h:
1589         * WebView/WebPreferences.mm:
1590         (cacheModelForMainBundle):
1591         (WebPreferencesPrivate::WebPreferencesPrivate):
1592         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1593         (-[WebPreferences encodeWithCoder:]):
1594         (+[WebPreferences standardPreferences]):
1595         (+[WebPreferences initialize]):
1596         (-[WebPreferences _valueForKey:]):
1597         (-[WebPreferences _setStringValue:forKey:]):
1598         (-[WebPreferences _setIntegerValue:forKey:]):
1599         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1600         (-[WebPreferences _setFloatValue:forKey:]):
1601         (-[WebPreferences _setBoolValue:forKey:]):
1602         (-[WebPreferences _setLongLongValue:forKey:]):
1603         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1604         (-[WebPreferences _postCacheModelChangedNotification]):
1605         (-[WebPreferences _postPreferencesChangedNotification]):
1606         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1607         (-[WebPreferences setStorageBlockingPolicy:]):
1608         * WebView/WebResource.mm:
1609         (+[WebResourcePrivate initialize]):
1610         * WebView/WebTextCompletionController.h:
1611         * WebView/WebTextIterator.mm:
1612         (+[WebTextIteratorPrivate initialize]):
1613         * WebView/WebView.mm:
1614         (shouldEnableLoadDeferring):
1615         (shouldRestrictWindowFocus):
1616         (shouldRespectPriorityInCSSAttributeSetters):
1617         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1618         (shouldAllowPictureInPictureMediaPlayback):
1619         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1620         (shouldAllowWindowOpenWithoutUserGesture):
1621         (shouldConvertInvalidURLsToBlank):
1622         (shouldRequireUserGestureToLoadVideo):
1623         (-[WebView _commonInitializationWithFrameName:groupName:]):
1624         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1625         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1626         (-[WebView _closePluginDatabases]):
1627         (-[WebView _closeWithFastTeardown]):
1628         (-[WebView _close]):
1629         (+[WebView _MIMETypeForFile:]):
1630         (-[WebView setShowingInspectorIndication:]):
1631         (-[WebView _setFormDelegate:]):
1632         (-[WebView _needsPreHTML5ParserQuirks]):
1633         (-[WebView _preferencesChangedNotification:]):
1634         (-[WebView _preferencesChanged:]):
1635         (-[WebView _cacheResourceLoadDelegateImplementations]):
1636         (-[WebView _cacheFrameLoadDelegateImplementations]):
1637         (-[WebView _policyDelegateForwarder]):
1638         (-[WebView _UIDelegateForwarder]):
1639         (-[WebView _editingDelegateForwarder]):
1640         (-[WebView _updateActiveState]):
1641         (-[_WebSafeForwarder forwardInvocation:]):
1642         (+[WebView initialize]):
1643         (-[WebView _pluginForMIMEType:]):
1644         (-[WebView _pluginForExtension:]):
1645         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1646         (+[WebView canShowMIMETypeAsHTML:]):
1647         (-[WebView _initWithArguments:]):
1648         (-[WebView initWithFrame:frameName:groupName:]):
1649         (-[WebView dealloc]):
1650         (-[WebView close]):
1651         (-[WebView viewDidMoveToWindow]):
1652         (-[WebView setUIDelegate:]):
1653         (-[WebView setResourceLoadDelegate:]):
1654         (-[WebView setPolicyDelegate:]):
1655         (-[WebView setFrameLoadDelegate:]):
1656         (-[WebView goBack]):
1657         (-[WebView goForward]):
1658         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1659         (-[WebView setHostWindow:]):
1660         (-[WebView becomeFirstResponder]):
1661         (+[WebView _cacheModelChangedNotification:]):
1662         (-[WebView _frameViewAtWindowPoint:]):
1663         (+[WebView _preflightSpellCheckerNow:]):
1664         (+[WebView _preflightSpellChecker]):
1665         (-[WebView canGoBack]):
1666         (-[WebView canGoForward]):
1667         (-[WebView stopLoading:]):
1668         (-[WebView reload:]):
1669         (-[WebView setMainFrameDocumentReady:]):
1670         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1671         (-[WebView setContinuousSpellCheckingEnabled:]):
1672         (-[WebView undoManager]):
1673         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1674         (-[WebView isAutomaticLinkDetectionEnabled]):
1675         (-[WebView isAutomaticDashSubstitutionEnabled]):
1676         (-[WebView isAutomaticTextReplacementEnabled]):
1677         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1678         (+[WebView _setCacheModel:]):
1679         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1680         (-[WebView _keyboardUIMode]):
1681         (LayerFlushController::flushLayers):
1682         (-[WebView _scheduleCompositingLayerFlush]):
1683         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1684         (-[WebView fullScreenPlaceholderView]):
1685         (WebInstallMemoryPressureHandler):
1686         * WebView/WebViewData.h:
1687         * WebView/WebViewData.mm:
1688         (+[WebViewPrivate initialize]):
1689         (-[WebViewPrivate init]):
1690         (-[WebViewPrivate dealloc]):
1691         * WebView/WebViewInternal.h:
1692
1693 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1694
1695         Clean up FrameLoader two-state enums
1696         https://bugs.webkit.org/show_bug.cgi?id=190731
1697
1698         Reviewed by Chris Dumez.
1699
1700         * WebCoreSupport/WebFrameLoaderClient.h:
1701         * WebCoreSupport/WebFrameLoaderClient.mm:
1702         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1703
1704 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1705
1706         Unreviewed, rolling out r237137.
1707
1708         SPI is actually used
1709
1710         Reverted changeset:
1711
1712         "Remove unused WebFrame._loadType"
1713         https://bugs.webkit.org/show_bug.cgi?id=190583
1714         https://trac.webkit.org/changeset/237137
1715
1716 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1717
1718         Enable the datalist element by default on iOS and macOS
1719         https://bugs.webkit.org/show_bug.cgi?id=190594
1720         <rdar://problem/45281159>
1721
1722         Reviewed by Ryosuke Niwa and Tim Horton.
1723
1724         * Configurations/FeatureDefines.xcconfig:
1725
1726 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1727
1728         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1729         https://bugs.webkit.org/show_bug.cgi?id=190675
1730
1731         Reviewed by Chris Dumez.
1732
1733         * History/BackForwardList.h:
1734         * History/BackForwardList.mm:
1735         (BackForwardList::backItem):
1736         (BackForwardList::currentItem):
1737         (BackForwardList::forwardItem):
1738         (BackForwardList::backListCount const):
1739         (BackForwardList::forwardListCount const):
1740         (BackForwardList::itemAtIndex):
1741         * History/WebBackForwardList.mm:
1742         (-[WebBackForwardList backItem]):
1743         (-[WebBackForwardList currentItem]):
1744         (-[WebBackForwardList forwardItem]):
1745         (-[WebBackForwardList itemAtIndex:]):
1746
1747 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1748
1749         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1750         https://bugs.webkit.org/show_bug.cgi?id=190526
1751         rdar://problem/45230140
1752
1753         Reviewed by Dean Jackson.
1754
1755         * WebCoreSupport/WebEditorClient.mm:
1756         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1757
1758 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1759
1760         Implement feature flag and bindings for CSS Painting API
1761         https://bugs.webkit.org/show_bug.cgi?id=190237
1762
1763         Reviewed by Ryosuke Niwa.
1764
1765         * Configurations/FeatureDefines.xcconfig:
1766
1767 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1768
1769         Replace HistoryItem* with HistoryItem& where possible
1770         https://bugs.webkit.org/show_bug.cgi?id=190617
1771
1772         Reviewed by Chris Dumez.
1773
1774         * History/BackForwardList.h:
1775         * History/BackForwardList.mm:
1776         (BackForwardList::goToItem):
1777         * History/WebBackForwardList.mm:
1778         (-[WebBackForwardList goToItem:]):
1779         * History/WebHistoryItem.mm:
1780         (WKNotifyHistoryItemChanged):
1781         * History/WebHistoryItemInternal.h:
1782
1783 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1784
1785         Remove unused WebHistoryItem._transientPropertyForKey
1786         https://bugs.webkit.org/show_bug.cgi?id=190606
1787
1788         Reviewed by Chris Dumez.
1789
1790         * History/WebHistoryItem.mm:
1791         * History/WebHistoryItemPrivate.h:
1792
1793 2018-10-15  Justin Fan  <justin_fan@apple.com>
1794
1795         Add WebGPU 2018 feature flag and experimental feature flag
1796         https://bugs.webkit.org/show_bug.cgi?id=190509
1797
1798         Reviewed by Dean Jackson.
1799
1800         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1801         for the 2018 WebGPU prototype.
1802
1803         * Configurations/FeatureDefines.xcconfig:
1804         * WebView/WebPreferenceKeysPrivate.h:
1805         * WebView/WebPreferences.mm:
1806         (+[WebPreferences initialize]):
1807         (-[WebPreferences webGPUEnabled]):
1808         (-[WebPreferences setWebGPUEnabled:]):
1809         * WebView/WebPreferencesPrivate.h:
1810         * WebView/WebView.mm:
1811         (-[WebView _preferencesChanged:]):
1812
1813 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1814
1815         Fix iOS build after r237157
1816
1817         * WebView/WebView.mm:
1818         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1819
1820 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1821
1822         Modernize BackForwardClient.h
1823         https://bugs.webkit.org/show_bug.cgi?id=190610
1824
1825         Reviewed by Chris Dumez.
1826
1827         * History/BackForwardList.h:
1828         * History/BackForwardList.mm:
1829         (BackForwardList::backListCount const):
1830         (BackForwardList::forwardListCount const):
1831         (BackForwardList::backListCount): Deleted.
1832         (BackForwardList::forwardListCount): Deleted.
1833         * History/WebBackForwardList.mm:
1834         (-[WebBackForwardList init]):
1835         * WebCoreSupport/WebFrameLoaderClient.mm:
1836         (WebFrameLoaderClient::canCachePage const):
1837         * WebView/WebFrameView.mm:
1838         (-[WebFrameView keyDown:keyDown:]):
1839         * WebView/WebView.mm:
1840         (-[WebView _commonInitializationWithFrameName:groupName:]):
1841         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1842         (-[WebView _loadBackForwardListFromOtherView:]):
1843         (-[WebView initWithCoder:]):
1844         (-[WebView encodeWithCoder:]):
1845         (-[WebView backForwardList]):
1846         (-[WebView setMaintainsBackForwardList:]):
1847
1848 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1849
1850         Add support for prefers-color-scheme media query
1851         https://bugs.webkit.org/show_bug.cgi?id=190499
1852         rdar://problem/45212025
1853
1854         Reviewed by Dean Jackson.
1855
1856         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1857
1858 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1859
1860         Remove unused WebView._globalHistoryItem
1861         https://bugs.webkit.org/show_bug.cgi?id=190601
1862
1863         Reviewed by Chris Dumez.
1864
1865         * WebCoreSupport/WebFrameLoaderClient.h:
1866         * WebCoreSupport/WebFrameLoaderClient.mm:
1867         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1868         * WebView/WebView.mm:
1869         (-[WebView _globalHistoryItem]): Deleted.
1870         (-[WebView _setGlobalHistoryItem:]): Deleted.
1871         * WebView/WebViewData.h:
1872         * WebView/WebViewInternal.h:
1873         * WebView/WebViewPrivate.h:
1874
1875 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1876
1877         Remove unused parameters from FrameLoaderClient::createFrame
1878         https://bugs.webkit.org/show_bug.cgi?id=190587
1879
1880         Reviewed by Chris Dumez.
1881
1882         * WebCoreSupport/WebFrameLoaderClient.h:
1883         * WebCoreSupport/WebFrameLoaderClient.mm:
1884         (WebFrameLoaderClient::createFrame):
1885
1886 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1887
1888         Remove unused WebFrame._loadType
1889         https://bugs.webkit.org/show_bug.cgi?id=190583
1890
1891         Reviewed by Chris Dumez.
1892
1893         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1894
1895         * WebView/WebFrame.mm:
1896         (toWebFrameLoadType): Deleted.
1897         (-[WebFrame _loadType]): Deleted.
1898         * WebView/WebFramePrivate.h:
1899
1900 2018-10-15  Chris Dumez  <cdumez@apple.com>
1901
1902         Restrict browsing context lookup by name to frames that are related to one another
1903         https://bugs.webkit.org/show_bug.cgi?id=190475
1904
1905         Reviewed by Alex Christensen.
1906
1907         * WebView/WebFrame.mm:
1908         (-[WebFrame findFrameNamed:]):
1909
1910 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1911
1912         Remove InjectedBundle processing of back/forward lists
1913         https://bugs.webkit.org/show_bug.cgi?id=190459
1914
1915         Reviewed by Chris Dumez.
1916
1917         * WebCoreSupport/WebFrameLoaderClient.h:
1918         * WebCoreSupport/WebFrameLoaderClient.mm:
1919         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1920
1921 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1922
1923         [JSC] Remove Option::useAsyncIterator
1924         https://bugs.webkit.org/show_bug.cgi?id=190567
1925
1926         Reviewed by Saam Barati.
1927
1928         * Configurations/FeatureDefines.xcconfig:
1929
1930 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1931
1932         Allow encoding of small enum classes
1933         https://bugs.webkit.org/show_bug.cgi?id=190531
1934
1935         Reviewed by Tim Horton.
1936
1937         * WebCoreSupport/WebFrameLoaderClient.mm:
1938         (-[WebFramePolicyListener dealloc]):
1939
1940 2018-10-11  Keith Rollin  <krollin@apple.com>
1941
1942         CURRENT_ARCH should not be used in Run Script phase.
1943         https://bugs.webkit.org/show_bug.cgi?id=190407
1944         <rdar://problem/45133556>
1945
1946         Reviewed by Alexey Proskuryakov.
1947
1948         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1949         CURRENT_ARCH is not well-defined during this phase (and may even have
1950         the value "undefined") since this phase is run just once per build
1951         rather than once per supported architecture. Migrate away from
1952         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1953         performing an operation for each value, or by picking the first entry
1954         in ARCHS and using that as a representative value.
1955
1956         * Configurations/WebKitLegacy.xcconfig: When generating
1957         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1958         macosx platforms.
1959
1960         * MigrateHeaders.make:
1961         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1962         generate one for each architecture in ARCHS.
1963
1964 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1965
1966         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1967         https://bugs.webkit.org/show_bug.cgi?id=190429
1968
1969         Reviewed by Saam Barati.
1970
1971         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1972
1973         * WebView/WebPDFRepresentation.mm:
1974         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1975
1976 2018-10-08  Justin Fan  <justin_fan@apple.com>
1977
1978         WebGPU: Rename old WebGPU prototype to WebMetal
1979         https://bugs.webkit.org/show_bug.cgi?id=190325
1980         <rdar://problem/44990443>
1981
1982         Reviewed by Dean Jackson.
1983
1984         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1985
1986         * Configurations/FeatureDefines.xcconfig:
1987         * WebView/WebPreferenceKeysPrivate.h:
1988         * WebView/WebPreferences.mm:
1989         (+[WebPreferences initialize]):
1990         (-[WebPreferences webMetalEnabled]):
1991         (-[WebPreferences setWebMetalEnabled:]):
1992         (-[WebPreferences webGPUEnabled]): Deleted.
1993         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1994         * WebView/WebPreferencesPrivate.h:
1995         * WebView/WebView.mm:
1996         (-[WebView _preferencesChanged:]):
1997
1998 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1999
2000         Make <input type=color> a runtime enabled (on-by-default) feature
2001         https://bugs.webkit.org/show_bug.cgi?id=189162
2002
2003         Reviewed by Wenson Hsieh and Tim Horton.
2004
2005         * Configurations/FeatureDefines.xcconfig:
2006
2007 2018-10-07  Dan Bernstein  <mitz@apple.com>
2008
2009         Fixed building with the latest macOS SDK
2010
2011         * Plugins/WebNetscapePluginPackage.mm:
2012         (-[WebNetscapePluginPackage openResourceFile]):
2013         (-[WebNetscapePluginPackage closeResourceFile:]):
2014
2015 2018-10-04  Dan Bernstein  <mitz@apple.com>
2016
2017         More Carbon build-fixing.
2018
2019         * Carbon/CarbonWindowAdapter.mm:
2020         (-[CarbonWindowAdapter _destroyRealWindow:]):
2021         (-[CarbonWindowAdapter _growBoxRect]):
2022
2023 2018-10-04  Dan Bernstein  <mitz@apple.com>
2024
2025         Retried to fix 32-bit macOS builds after r236846.
2026
2027         * WebView/WebHTMLView.mm:
2028         (-[WebHTMLView setMarkedText:selectedRange:]):
2029
2030 2018-10-04  Dan Bernstein  <mitz@apple.com>
2031
2032         Retried to fix 32-bit macOS builds after r236846.
2033
2034         * Carbon/HIWebView.mm:
2035         (ActiveStateChanged):
2036
2037 2018-10-04  Dan Bernstein  <mitz@apple.com>
2038
2039         Tried to fix 32-bit macOS builds after r236846.
2040
2041         * Carbon/HIWebView.mm:
2042         (_NSSelectorForHICommand):
2043
2044 2018-10-04  Dan Bernstein  <mitz@apple.com>
2045
2046         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2047         https://bugs.webkit.org/show_bug.cgi?id=190250
2048
2049         Reviewed by Andy Estes.
2050
2051         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2052           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2053           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2054           an earlier line set it to YES.
2055
2056         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2057         changes below.
2058
2059         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2060           provides some missing method declarations.
2061
2062         * Misc/WebDownload.mm:
2063         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2064           a deprecated method.
2065
2066         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2067
2068         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2069           other code in the file uses a method from it.
2070
2071         * Plugins/WebBaseNetscapePluginView.mm:
2072         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2073           a deprecated method.
2074
2075         * Plugins/WebPluginController.mm:
2076         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2077           around use of a selector that may be present in some WebKit client.
2078
2079         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2080           method declarations.
2081
2082         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2083           from here.
2084
2085         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2086           missing method declarations.
2087
2088         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2089           from here.
2090
2091         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2092           call from here.
2093         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2094           an obsolete delegate method for binary compatibility.
2095         (pluginView): Ditto.
2096
2097         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2098           call from here.
2099
2100         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2101           WebDeviceOrientationProviderMock protocol.
2102
2103         * WebView/WebDeviceOrientationProviderMock.mm:
2104         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2105           main @implementation.
2106
2107         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2108           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2109
2110         * WebView/WebDynamicScrollBarsView.mm:
2111         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2112           of a deprecated method.
2113
2114         * WebView/WebHTMLView.mm:
2115         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2116           selector warning around action methods that are not declared anywhere in WebKit.
2117
2118         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2119           about implementing this deprecated method.
2120         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2121         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2122         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2123         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2124         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2125         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2126         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2127         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2128         (-[WebHTMLView doCommandBySelector:]): Ditto.
2129         (-[WebHTMLView insertText:]): Ditto.
2130
2131         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2132
2133         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2134
2135         * WebView/WebPDFView.h: Removed previewView ivar.
2136
2137         * WebView/WebPDFView.mm:
2138           Removed declaration of FileInternal category and merged its implementation with the main
2139           implementation.
2140         (-[WebPDFView dealloc]): Removed previewView ivar.
2141         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2142           exist in macOS versions we support.
2143         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2144         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2145           action methods internal to PDFKit.
2146         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2147         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2148
2149         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2150           call on macOS, even though in r86988 we started calling different methods on iOS.
2151
2152         * WebView/WebView.mm:
2153         - Imported headers that declare delegate methods that we call.
2154         - Removed declaration of WebFileInternal category and merged its implementation with the
2155           main implementation.
2156         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2157           category, which made them impossible to call from the main implementation. Moved those
2158           into the main implementation. One of those had to be declared in a class extension,
2159           because it is called from a method implemented in the WebPrivate category, and that
2160           category’s implementation appears first in the file.
2161
2162         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2163           around use of obsolete delegate method for binary compatibility.
2164
2165         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2166
2167 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2168
2169         Runtime flag and IDL for MediaRecorder
2170         https://bugs.webkit.org/show_bug.cgi?id=190018
2171
2172         Reviewed by Youenn Fablet and Chris Dumez.
2173
2174         * WebView/WebPreferenceKeysPrivate.h:
2175         * WebView/WebPreferences.mm:
2176         (+[WebPreferences initialize]):
2177         (-[WebPreferences mediaRecorderEnabled]):
2178         (-[WebPreferences setMediaRecorderEnabled:]):
2179         * WebView/WebPreferencesPrivate.h:
2180         * WebView/WebView.mm:
2181         (-[WebView _preferencesChanged:]):
2182
2183 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2184
2185         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2186         https://bugs.webkit.org/show_bug.cgi?id=190238
2187
2188         Reviewed by Antti Koivisto.
2189
2190         Enabled the feature by default.
2191
2192         * WebView/WebPreferences.mm:
2193         (+[WebPreferences initialize]):
2194
2195 2018-10-01  Dean Jackson  <dino@apple.com>
2196
2197         [macOS] Switching to discrete GPU should be done in the UI process
2198         https://bugs.webkit.org/show_bug.cgi?id=189361
2199         <rdar://problem/43949622>
2200
2201         Reviewed by Simon Fraser.
2202
2203         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2204         not support swapping to the discrete GPU in this configuration.
2205
2206         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2207         (WebKit::WebSwitchingGPUClient::singleton):
2208         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2209         * WebView/WebView.mm:
2210         (-[WebView _commonInitializationWithFrameName:groupName:]):
2211
2212 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2213
2214         Remove ParsedURLString
2215         https://bugs.webkit.org/show_bug.cgi?id=190154
2216
2217         Reviewed by Chris Dumez.
2218
2219         * WebView/WebScriptDebugger.mm:
2220         (toNSURL):
2221
2222 2018-10-01  Dean Jackson  <dino@apple.com>
2223
2224         Remove CSS Animation Triggers
2225         https://bugs.webkit.org/show_bug.cgi?id=190175
2226         <rdar://problem/44925626>
2227
2228         Reviewed by Simon Fraser.
2229
2230         * Configurations/FeatureDefines.xcconfig:
2231
2232 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2233
2234         Unreviewed, rolling out r236624 and r236671.
2235         https://bugs.webkit.org/show_bug.cgi?id=190207
2236
2237         The change in r236624 introduced crashes on the bots
2238         (Requested by ryanhaddad on #webkit).
2239
2240         Reverted changesets:
2241
2242         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2243         https://bugs.webkit.org/show_bug.cgi?id=188747
2244         https://trac.webkit.org/changeset/236624
2245
2246         "Unify implementation in VideoFullscreenInterfaceAVKit"
2247         https://bugs.webkit.org/show_bug.cgi?id=190091
2248         https://trac.webkit.org/changeset/236671
2249
2250 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2251
2252         URL should not use TextEncoding internally
2253         https://bugs.webkit.org/show_bug.cgi?id=190111
2254
2255         Reviewed by Andy Estes.
2256
2257         * Misc/WebNSURLExtras.mm:
2258
2259 2018-09-28  Jer Noble  <jer.noble@apple.com>
2260
2261         Refactoring: eliminate raw pointer usage in Fullscreen code
2262         https://bugs.webkit.org/show_bug.cgi?id=188747
2263         <rdar://problem/43541164>
2264
2265         Reviewed by Alex Christensen.
2266
2267         PlaybackSessionInterface no longer has an invalidate() method.
2268
2269         * WebView/WebView.mm:
2270         (-[WebView _clearPlaybackControlsManager]):
2271
2272 2018-09-28  Chris Dumez  <cdumez@apple.com>
2273
2274         Drop support for cross-origin-window-policy header
2275         https://bugs.webkit.org/show_bug.cgi?id=190081
2276
2277         Reviewed by Ryosuke Niwa.
2278
2279         * WebView/WebPreferenceKeysPrivate.h:
2280         * WebView/WebPreferences.mm:
2281         (+[WebPreferences initialize]):
2282         * WebView/WebPreferencesPrivate.h:
2283         * WebView/WebView.mm:
2284         (-[WebView _preferencesChanged:]):
2285
2286 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2287
2288         Rename createMarkup to serializePreservingVisualAppearance
2289         https://bugs.webkit.org/show_bug.cgi?id=190086
2290
2291         Reviewed by Wenson Hsieh.
2292
2293         * DOM/WebDOMOperations.mm:
2294         (-[DOMRange markupString]):
2295
2296 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2297
2298         Unreviewed, rolling out r236605.
2299         https://bugs.webkit.org/show_bug.cgi?id=190087
2300
2301         caused three API test timeouts (Requested by jernoble on
2302         #webkit).
2303
2304         Reverted changeset:
2305
2306         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2307         https://bugs.webkit.org/show_bug.cgi?id=188747
2308         https://trac.webkit.org/changeset/236605
2309
2310 2018-09-28  Jer Noble  <jer.noble@apple.com>
2311
2312         Refactoring: eliminate raw pointer usage in Fullscreen code
2313         https://bugs.webkit.org/show_bug.cgi?id=188747
2314         <rdar://problem/43541164>
2315
2316         Reviewed by Alex Christensen.
2317
2318         PlaybackSessionInterface no longer has an invalidate() method.
2319
2320         * WebView/WebView.mm:
2321         (-[WebView _clearPlaybackControlsManager]):
2322
2323 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2324
2325         Use enum class in createMarkup arguments
2326         https://bugs.webkit.org/show_bug.cgi?id=190028
2327
2328         Reviewed by Wenson Hsieh.
2329
2330         * DOM/WebDOMOperations.mm:
2331         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2332         (-[DOMRange markupString]): Ditto.
2333
2334 2018-09-27  Antoine Quint  <graouts@apple.com>
2335
2336         [Web Animations] Turn Web Animations with CSS integration on
2337         https://bugs.webkit.org/show_bug.cgi?id=184819
2338         <rdar://problem/39597337>
2339
2340         Reviewed by Dean Jackson.
2341
2342         * WebView/WebPreferences.mm:
2343         (+[WebPreferences initialize]):
2344
2345 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2346
2347         Selection should work across shadow boundary when initiated by a mouse drag
2348         https://bugs.webkit.org/show_bug.cgi?id=151380
2349         <rdar://problem/24363872>
2350
2351         Reviewed by Wenson Hsieh.
2352
2353         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2354
2355         * WebView/WebPreferenceKeysPrivate.h:
2356         * WebView/WebPreferences.mm:
2357         (+[WebPreferences initialize]):
2358         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2359         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2360         * WebView/WebPreferencesPrivate.h:
2361         * WebView/WebView.mm:
2362         (-[WebView _preferencesChanged:]):
2363
2364 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2365
2366         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2367         https://bugs.webkit.org/show_bug.cgi?id=189918
2368         Work towards <rdar://problem/44648705>
2369
2370         Reviewed by Tim Horton.
2371
2372         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2373
2374         * WebView/WebHTMLView.mm:
2375         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2376         (-[WebHTMLView _updateFontPanel]):
2377         * WebView/WebView.mm:
2378         (-[WebView typingAttributes]):
2379
2380 2018-09-17  Darin Adler  <darin@apple.com>
2381
2382         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2383         https://bugs.webkit.org/show_bug.cgi?id=189652
2384
2385         Reviewed by Saam Barati.
2386
2387         * WebView/WebPDFRepresentation.mm:
2388         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2389
2390 2018-09-14  Jer Noble  <jer.noble@apple.com>
2391
2392         Turn SourceBufferChangeTypeEnabled on by default
2393         https://bugs.webkit.org/show_bug.cgi?id=189527
2394
2395         Reviewed by Eric Carlson.
2396
2397         * WebView/WebPreferences.mm:
2398         (+[WebPreferences initialize]):
2399
2400 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2401
2402         Fix an internal build after r235935
2403         https://bugs.webkit.org/show_bug.cgi?id=188996
2404
2405         * Carbon/HIWebView.mm:
2406         (Draw):
2407         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2408
2409 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2410
2411         Add IGNORE_WARNING_.* macros
2412         https://bugs.webkit.org/show_bug.cgi?id=188996
2413
2414         Reviewed by Michael Catanzaro.
2415
2416         * Carbon/CarbonUtils.m:
2417         (PoolCleaner):
2418         * Carbon/CarbonWindowAdapter.mm:
2419         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2420         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2421         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2422         (-[CarbonWindowAdapter _termWindowIfOwner]):
2423         (-[CarbonWindowAdapter _windowMovedToRect:]):
2424         (-[CarbonWindowAdapter setContentView:]):
2425         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2426         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2427         * Carbon/CarbonWindowFrame.m:
2428         (-[CarbonWindowFrame title]):
2429         * Carbon/HIViewAdapter.m:
2430         (+[HIViewAdapter getHIViewForNSView:]):
2431         * Carbon/HIWebView.mm:
2432         (overrideCGContext):
2433         (restoreCGContext):
2434         (Draw):
2435         * DOM/DOM.mm:
2436         * History/WebHistory.mm:
2437         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2438         * History/WebHistoryItem.mm:
2439         (-[WebHistoryItem icon]):
2440         * Misc/WebKitNSStringExtras.mm:
2441         (-[NSString _web_drawAtPoint:font:textColor:]):
2442         * Misc/WebNSImageExtras.m:
2443         (-[NSImage _web_scaleToMaxSize:]):
2444         (-[NSImage _web_dissolveToFraction:]):
2445         * Misc/WebNSPasteboardExtras.mm:
2446         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2447         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2448         * Panels/WebAuthenticationPanel.m:
2449         (-[WebAuthenticationPanel loadNib]):
2450         * Plugins/Hosted/NetscapePluginHostManager.mm:
2451         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2452         (WebKit::NetscapePluginHostManager::didCreateWindow):
2453         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2454         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2455         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2456         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2457         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2458         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2459         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2460         (-[WebHostedNetscapePluginView drawRect:]):
2461         * Plugins/Hosted/WebTextInputWindowController.m:
2462         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2463         * Plugins/WebBaseNetscapePluginView.mm:
2464         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2465         * Plugins/WebNetscapePluginPackage.mm:
2466         (-[WebNetscapePluginPackage _tryLoad]):
2467         * Plugins/WebNetscapePluginView.mm:
2468         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2469         (-[WebNetscapePluginView sendDrawRectEvent:]):
2470         (-[WebNetscapePluginView drawRect:]):
2471         * Plugins/WebPluginController.mm:
2472         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2473         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2474         * WebCoreSupport/PopupMenuMac.mm:
2475         (PopupMenuMac::populate):
2476         * WebCoreSupport/WebAlternativeTextClient.h:
2477         * WebCoreSupport/WebDragClient.mm:
2478         (WebDragClient::startDrag):
2479         * WebCoreSupport/WebFrameLoaderClient.mm:
2480         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2481         (webGetNSImage):
2482         * WebInspector/WebNodeHighlight.mm:
2483         * WebInspector/WebNodeHighlightView.mm:
2484         (-[WebNodeHighlightView drawRect:]):
2485         * WebView/WebClipView.mm:
2486         (-[WebClipView initWithFrame:]):
2487         * WebView/WebFrame.mm:
2488         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2489         (-[WebFrame _drawRect:contentsOnly:]):
2490         (-[WebFrame accessibilityRoot]):
2491         * WebView/WebFullScreenController.mm:
2492         (-[WebFullScreenController enterFullScreen:]):
2493         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2494         (-[WebFullScreenController exitFullScreen]):
2495         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2496         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2497         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2498         * WebView/WebHTMLView.mm:
2499         (-[NSWindow _web_borderView]):
2500         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2501         (-[WebHTMLView _setAsideSubviews]):
2502         (-[WebHTMLView _autoscroll]):
2503         (-[WebHTMLView drawRect:]):
2504         (-[WebHTMLView mouseDown:]):
2505         (-[WebHTMLView mouseDragged:]):
2506         (-[WebHTMLView mouseUp:]):
2507         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2508         (-[WebHTMLView knowsPageRange:]):
2509         (-[WebHTMLView accessibilityHitTest:]):
2510         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2511         (-[WebHTMLView _colorAsString:]):
2512         (-[WebHTMLView copyFont:]):
2513         (-[WebHTMLView _executeSavedKeypressCommands]):
2514         (-[WebHTMLView attachRootLayer:]):
2515         (-[WebHTMLView textStorage]):
2516         (-[WebHTMLView _updateSelectionForInputManager]):
2517         * WebView/WebPDFView.mm:
2518         (_applicationInfoForMIMEType):
2519         (-[WebPDFView centerSelectionInVisibleArea:]):
2520         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2521         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2522         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2523         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2524         * WebView/WebTextCompletionController.mm:
2525         (-[WebTextCompletionController _buildUI]):
2526         (-[WebTextCompletionController _placePopupWindow:]):
2527         * WebView/WebVideoFullscreenController.mm:
2528         * WebView/WebVideoFullscreenHUDWindowController.mm:
2529         (createMediaUIBackgroundView):
2530         * WebView/WebView.mm:
2531         (-[WebTextListTouchBarViewController initWithWebView:]):
2532         (-[WebView _dispatchTileDidDraw:]):
2533         (-[WebView encodeWithCoder:]):
2534         (-[WebView mainFrameIcon]):
2535         (LayerFlushController::flushLayers):
2536         * WebView/WebWindowAnimation.mm:
2537         (setScaledFrameForWindow):
2538
2539 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2540
2541         Remove unused needsDestruction class variables from HashTraits
2542         https://bugs.webkit.org/show_bug.cgi?id=189490
2543
2544         Reviewed by Daniel Bates.
2545
2546         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2547
2548 2018-09-07  Frederic Wang  <fwang@igalia.com>
2549
2550         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2551         https://bugs.webkit.org/show_bug.cgi?id=182230
2552
2553         Reviewed by Simon Fraser.
2554
2555         * DOM/DOMDocument.mm:
2556         (-[DOMDocument scrollingElement]): Use the new name.
2557
2558 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2559
2560         Refactor WebCore::EditAction to be an 8-bit enum class
2561         https://bugs.webkit.org/show_bug.cgi?id=189383
2562
2563         Reviewed by Dan Bernstein.
2564
2565         * WebCoreSupport/WebEditorClient.mm:
2566         (undoNameForEditAction):
2567         * WebView/WebHTMLView.mm:
2568         (-[WebHTMLView pasteFont:]):
2569         (-[WebHTMLView changeFont:]):
2570         (-[WebHTMLView changeAttributes:]):
2571         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2572         (-[WebHTMLView changeColor:]):
2573         * WebView/WebView.mm:
2574         (-[WebView setTypingStyle:]):
2575
2576 2018-09-06  Frederic Wang  <fwang@igalia.com>
2577
2578         Group options of scrollRectToVisible into a struct
2579         https://bugs.webkit.org/show_bug.cgi?id=189352
2580
2581         Reviewed by Simon Fraser.
2582
2583         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2584         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2585         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2586
2587 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2588
2589         [macOS] Cannot change font size at selection until font panel is shown
2590         https://bugs.webkit.org/show_bug.cgi?id=189295
2591         <rdar://problem/35593389>
2592
2593         Reviewed by Ryosuke Niwa.
2594
2595         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2596         WebCore ChangeLog for more details.
2597
2598         * WebView/WebHTMLView.mm:
2599         (-[WebHTMLView changeFont:]):
2600         (-[WebHTMLView changeAttributes:]):
2601         (-[WebHTMLView _originalFontA]): Deleted.
2602         (-[WebHTMLView _originalFontB]): Deleted.
2603         (fontNameForDescription): Deleted.
2604         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2605         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2606         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2607
2608 2018-09-05  Jer Noble  <jer.noble@apple.com>
2609
2610         Add MediaCapabilities as an Experimental Feature
2611         https://bugs.webkit.org/show_bug.cgi?id=189209
2612
2613         Reviewed by Eric Carlson.
2614
2615         RuntimeEnabledFeature -> Setting.
2616
2617         * WebView/WebView.mm:
2618         (-[WebView _preferencesChanged:]):
2619
2620 2018-09-04  Frederic Wang  <fwang@igalia.com>
2621
2622         Add basic support for ScrollIntoViewOptions
2623         https://bugs.webkit.org/show_bug.cgi?id=189258
2624
2625         Reviewed by Simon Fraser.
2626
2627         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2628         header so that this file can build despite the new scrollIntoView function.
2629
2630 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2631
2632         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2633         https://bugs.webkit.org/show_bug.cgi?id=188890
2634         <rdar://problem/43648605>
2635
2636         Reviewed by Tim Horton.
2637
2638         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2639         more detail.
2640
2641         * WebCoreSupport/WebPlatformStrategies.h:
2642         * WebCoreSupport/WebPlatformStrategies.mm:
2643         (WebPlatformStrategies::allStringsForType):
2644
2645 2018-09-01  Darin Adler  <darin@apple.com>
2646
2647         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2648         https://bugs.webkit.org/show_bug.cgi?id=189072
2649         Reviewed by Dan Bernstein.
2650
2651         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2652         and declarations for NSURLDownload init methods.
2653
2654         * Misc/WebDownloadInternal.h: Removed.
2655
2656         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2657         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2658         "-Wdeprecated-declarations" because the method used here is deprecated.
2659
2660         * WebView/WebView.mm:
2661         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2662         used here is deprecated.
2663
2664 2018-08-31  Chris Dumez  <cdumez@apple.com>
2665
2666         Assertion hit in ~CompletionHandler() from ~WebFrame()
2667         https://bugs.webkit.org/show_bug.cgi?id=189199
2668         <rdar://problem/42657233>
2669
2670         Reviewed by Youenn Fablet.
2671
2672         * WebCoreSupport/WebFrameLoaderClient.h:
2673         * WebCoreSupport/WebFrameLoaderClient.mm:
2674         (WebFrameLoaderClient::dispatchWillSubmitForm):
2675
2676 2018-08-31  Antti Koivisto  <antti@apple.com>
2677
2678         Replace OptionSet |= and -= operators with add() and remove() functions
2679         https://bugs.webkit.org/show_bug.cgi?id=189169
2680
2681         Reviewed by Anders Carlsson.
2682
2683         * WebView/WebFrame.mm:
2684         (-[WebFrame _drawRect:contentsOnly:]):
2685         * WebView/WebView.mm:
2686         (coreOptions):
2687
2688 2018-08-31  Frederic Wang  <fwang@igalia.com>
2689
2690         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2691         https://bugs.webkit.org/show_bug.cgi?id=182053
2692
2693         Reviewed by Simon Fraser.
2694
2695         Add developer flag to use standard behavior for scrolling* attributes.
2696
2697         * WebView/WebPreferenceKeysPrivate.h:
2698         * WebView/WebPreferences.mm:
2699         (+[WebPreferences initialize]):
2700         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2701         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2702         * WebView/WebPreferencesPrivate.h:
2703         * WebView/WebView.mm:
2704         (-[WebView _preferencesChanged:]):
2705
2706 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2707
2708         Implement the Web Share API
2709         https://bugs.webkit.org/show_bug.cgi?id=171100
2710         <rdar://problem/31751734>
2711
2712         Reviewed by Tim Horton.
2713
2714         * WebCoreSupport/WebChromeClient.h:
2715         * WebCoreSupport/WebChromeClient.mm:
2716         (WebChromeClient::showShareSheet):
2717         Empty declaration of showShareSheet.
2718
2719 2018-08-29  Youenn Fablet  <youenn@apple.com>
2720
2721         Remove WebRTC legacy API implementation
2722         https://bugs.webkit.org/show_bug.cgi?id=189040
2723
2724         Reviewed by Eric Carlson.
2725
2726         * WebView/WebPreferenceKeysPrivate.h:
2727         * WebView/WebPreferences.mm:
2728         (+[WebPreferences initialize]):
2729         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2730         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2731         * WebView/WebPreferencesPrivate.h:
2732         * WebView/WebView.mm:
2733         (-[WebView _preferencesChanged:]):
2734
2735 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2736
2737         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2738         https://bugs.webkit.org/show_bug.cgi?id=189054
2739
2740         Reviewed by Andy Estes.
2741
2742         Remove the pasteboard type argument from readURLFromPasteboard.
2743
2744         * WebCoreSupport/WebPlatformStrategies.h:
2745         * WebCoreSupport/WebPlatformStrategies.mm:
2746         (WebPlatformStrategies::readURLFromPasteboard):
2747
2748 2018-08-27  Keith Rollin  <krollin@apple.com>
2749
2750         Unreviewed build fix -- disable LTO for production builds
2751
2752         * Configurations/Base.xcconfig:
2753
2754 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2755
2756         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2757         https://bugs.webkit.org/show_bug.cgi?id=188931
2758
2759         Reviewed by Wenson Hsieh.
2760
2761         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2762
2763 2018-08-27  Keith Rollin  <krollin@apple.com>
2764
2765         Build system support for LTO
2766         https://bugs.webkit.org/show_bug.cgi?id=187785
2767         <rdar://problem/42353132>
2768
2769         Reviewed by Dan Bernstein.
2770
2771         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2772         LTO.
2773
2774         * Configurations/Base.xcconfig:
2775         * Configurations/DebugRelease.xcconfig:
2776
2777 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2778
2779         Pass in IsComposed flag to Event constructors
2780         https://bugs.webkit.org/show_bug.cgi?id=188720
2781         <rdar://problem/43580387>
2782
2783         Reviewed by Simon Fraser.
2784
2785         * WebView/WebPDFView.mm:
2786         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2787         whether it's simulated or not.
2788
2789 2018-08-23  Mark Lam  <mark.lam@apple.com>
2790
2791         Move vmEntryGlobalObject() to VM from CallFrame.
2792         https://bugs.webkit.org/show_bug.cgi?id=188900
2793         <rdar://problem/43655753>
2794
2795         Reviewed by Michael Saboff.
2796
2797         * WebView/WebScriptDebugger.mm:
2798         (WebScriptDebugger::sourceParsed):
2799
2800 2018-08-23  Andy Estes  <aestes@apple.com>
2801
2802         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2803         https://bugs.webkit.org/show_bug.cgi?id=188829
2804
2805         Reviewed by Tim Horton.
2806
2807         * Configurations/FeatureDefines.xcconfig:
2808
2809 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2810
2811         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2812         https://bugs.webkit.org/show_bug.cgi?id=188777
2813
2814         Reviewed by Simon Fraser.
2815
2816         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2817         being "true" before the code change.
2818
2819         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2820
2821         * WebView/WebPDFView.mm:
2822         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2823
2824 2018-08-21  Daniel Bates  <dabates@apple.com>
2825
2826         Replace TextCheckingTypeMask with OptionSet
2827         https://bugs.webkit.org/show_bug.cgi?id=188678
2828
2829         Reviewed by Antti Koivisto.
2830
2831         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2832         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2833         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2834         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2835
2836         * WebCoreSupport/WebEditorClient.h:
2837         * WebCoreSupport/WebEditorClient.mm:
2838         (WebEditorClient::checkTextOfParagraph):
2839         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2840         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2841         left as this is more readable and unncessary now that modern compilers like Clang have
2842         diagnostics to catch accidental assignments when equality was intended.
2843         (WebEditorClient::didCheckSucceed):
2844         * WebView/WebView.mm:
2845         (coreTextCheckingType):
2846         (textCheckingResultFromNSTextCheckingResult):
2847
2848 2018-08-21  Daniel Bates  <dabates@apple.com>
2849
2850         [iOS][WK1] Support toggling continuous spell checking from tests
2851         https://bugs.webkit.org/show_bug.cgi?id=188763
2852
2853         Reviewed by Simon Fraser.
2854
2855         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2856         spell checking from tests in iOS WebKit Legacy.
2857
2858         * WebCoreSupport/WebEditorClient.h:
2859         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2860         * WebCoreSupport/WebEditorClient.mm:
2861         * WebView/WebView.h:
2862         * WebView/WebView.mm:
2863         (-[WebView toggleContinuousSpellChecking:]):
2864         (-[WebView toggleSmartInsertDelete:]):
2865
2866 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2867
2868         Add some plumbing for safe browsing
2869         https://bugs.webkit.org/show_bug.cgi?id=188709
2870
2871         Reviewed by Tim Horton.
2872
2873         * WebCoreSupport/WebFrameLoaderClient.h:
2874         * WebCoreSupport/WebFrameLoaderClient.mm:
2875         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2876
2877 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2878
2879         Replace canBubble and cancelable booleans in Event by enum classes
2880         https://bugs.webkit.org/show_bug.cgi?id=188692
2881
2882         Reviewed by Alex Christensen.
2883
2884         * WebView/WebPDFView.mm:
2885         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2886         * WebView/WebView.mm:
2887         (-[WebView _dispatchUnloadEvent]):
2888
2889 2018-08-16  Jer Noble  <jer.noble@apple.com>
2890
2891         Add Experimental Feature support for SourceBuffer.changeType()
2892         https://bugs.webkit.org/show_bug.cgi?id=188626
2893         <rdar://problem/43356021>
2894
2895         Reviewed by Eric Carlson.
2896
2897         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2898
2899         * WebView/WebPreferenceKeysPrivate.h:
2900         * WebView/WebPreferences.mm:
2901         (+[WebPreferences initialize]):
2902         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2903         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2904         * WebView/WebPreferencesPrivate.h:
2905         * WebView/WebView.mm:
2906         (-[WebView _preferencesChanged:]):
2907
2908 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2909
2910         Support drag-and-drop for input[type=color]
2911         https://bugs.webkit.org/show_bug.cgi?id=188464
2912
2913         Reviewed by Wenson Hsieh.
2914
2915         * WebCoreSupport/WebPlatformStrategies.h:
2916         * WebCoreSupport/WebPlatformStrategies.mm:
2917         (WebPlatformStrategies::setColor):
2918
2919 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2920
2921         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2922         https://bugs.webkit.org/show_bug.cgi?id=188569
2923         <rdar://problem/34201095>
2924
2925         Reviewed by Megan Gardner.
2926
2927         * WebView/WebImmediateActionController.mm:
2928         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2929         Speculative fix; the crashes indicate font is null, but we just checked it,
2930         so it must be getting made null by convertFont:toSize:. Check again!
2931
2932 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2933
2934         Use a 1-byte enum class for TextDirection
2935         https://bugs.webkit.org/show_bug.cgi?id=188350
2936
2937         Reviewed by Simon Fraser.
2938
2939         * WebCoreSupport/PopupMenuMac.mm:
2940         (PopupMenuMac::populate):
2941         (PopupMenuMac::show):
2942         * WebCoreSupport/WebFrameLoaderClient.mm:
2943         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2944         * WebView/WebFrame.mm:
2945         (-[WebFrame _dispatchDidReceiveTitle:]):
2946
2947 2018-08-09  Ali Juma  <ajuma@chromium.org>
2948
2949         Import WPTs for IntersectionObserver
2950         https://bugs.webkit.org/show_bug.cgi?id=188416
2951
2952         Reviewed by Simon Fraser.
2953
2954         * WebView/WebPreferencesPrivate.h:
2955
2956 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2957
2958         Follow-up build fix for r234685
2959         https://bugs.webkit.org/show_bug.cgi?id=188245
2960
2961         Unreviewed build fix.
2962
2963         * WebCoreSupport/WebSecurityOriginPrivate.h:
2964
2965 2018-08-05  Darin Adler  <darin@apple.com>
2966
2967         [Cocoa] More tweaks and refactoring to prepare for ARC
2968         https://bugs.webkit.org/show_bug.cgi?id=188245
2969
2970         Reviewed by Dan Bernstein.
2971
2972         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2973
2974         * Carbon/CarbonWindowFrame.m:
2975         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2976
2977         * DOM/DOM.mm:
2978         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2979         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2980         garbage collection so this method isn't useful.
2981
2982         * DOM/DOMXPath.mm:
2983         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2984         Objective-C garbage collection so this method isn't useful.
2985
2986         * History/WebHistory.mm:
2987         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2988
2989         * Misc/WebElementDictionary.mm:
2990         (addLookupKey): Use a bridging cast.
2991         (cacheValueForKey): Ditto.
2992         (-[WebElementDictionary _fillCache]): Ditto.
2993         (-[WebElementDictionary objectForKey:]): Ditto.
2994
2995         * Misc/WebKitNSStringExtras.mm:
2996         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2997         (-[NSString _web_widthWithFont:]): Ditto.
2998         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2999
3000         * Misc/WebLocalizableStrings.mm:
3001         (WebLocalizedString): Use a bridging cast.
3002
3003         * Misc/WebNSDataExtras.mm:
3004         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3005         and use CFBridgingRelease instead of calling autorelease directly.
3006         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3007         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3008         on the amount of explicit release and autorelease.
3009
3010         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3011         * Misc/WebNSDictionaryExtras.m:
3012         (-[NSDictionary _webkit_intForKey:]): Deleted.
3013         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3014         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3015         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3016         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3017         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3018         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3019
3020         * Misc/WebStringTruncator.mm:
3021         (fontFromNSFont): Use a bridging cast.
3022
3023         * Plugins/Hosted/NetscapePluginHostManager.mm:
3024         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3025
3026         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3027         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3028         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3029         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3030         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3031         * Plugins/Hosted/ProxyInstance.mm:
3032         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3033         * Plugins/WebBasePluginPackage.mm:
3034         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3035         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3036         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3037         * Plugins/WebNetscapePluginPackage.mm:
3038         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3039
3040         * Plugins/WebNetscapePluginView.mm:
3041         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3042         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3043         (-[WebNetscapePluginView status:]): Use a bridging cast.
3044         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3045
3046         * Plugins/WebPluginController.mm:
3047         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3048
3049         * Plugins/WebPluginDatabase.mm:
3050         (checkCandidate): Use explicit __strong for out argument types.
3051
3052         * Plugins/npapi.mm:
3053         (pluginViewForInstance): Use a bridging cast.
3054
3055         * Storage/WebDatabaseManager.mm:
3056         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3057         explicit NSNumber and NSDictionary calls.
3058
3059         * WebCoreSupport/WebContextMenuClient.mm:
3060         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3061
3062         * WebCoreSupport/WebEditorClient.mm:
3063         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3064         (WebEditorClient::handleInputMethodKeydown): Ditto.
3065
3066         * WebCoreSupport/WebFrameNetworkingContext.mm:
3067         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3068
3069         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3070         as a struct rather than an Objective-C class, since that's how it's defined.
3071
3072         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3073
3074         * WebView/WebFullScreenController.mm:
3075         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3076         * WebView/WebHTMLView.mm:
3077         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3078         Ditto.
3079         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3080
3081         * WebView/WebImmediateActionController.mm:
3082         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3083         go down to the document and then back to the frame.
3084         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3085         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3086         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3087
3088         * WebView/WebJSPDFDoc.mm:
3089         (jsPDFDocInitialize): Removed some unneeded type casting.
3090         (jsPDFDocFinalize): Ditto.
3091         (jsPDFDocPrint): Use a bridging cast.
3092
3093         * WebView/WebPDFView.mm:
3094         (_applicationInfoForMIMEType): Use bridging casts.
3095
3096         * WebView/WebPreferences.mm:
3097         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3098         instead of methods from WebNSDictionaryExtras.
3099         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3100         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3101         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3102         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3103         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3104
3105         * WebView/WebView.mm:
3106         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3107         (-[WebView _addToAllWebViewsSet]): Ditto.
3108         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3109         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3110         so it can be called from WebViewData methods.
3111
3112         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3113         method, _windowVisibilityChanged:.
3114
3115         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3116         called from WebViewData methods.
3117
3118 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3119
3120         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3121         https://bugs.webkit.org/show_bug.cgi?id=188323
3122
3123         Reviewed by Simon Fraser.
3124
3125         * WebCoreSupport/WebContextMenuClient.mm:
3126         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3127         * WebView/WebFrame.mm:
3128         (-[WebFrame _paintBehaviorForDestinationContext:]):
3129         (-[WebFrame _drawRect:contentsOnly:]):
3130         * WebView/WebHTMLView.mm:
3131         (imageFromRect):
3132         (selectionImage):
3133
3134 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3135
3136         Add support for microtasks in workers
3137         https://bugs.webkit.org/show_bug.cgi?id=188246
3138
3139         Reviewed by Darin Adler.
3140
3141         Rename JSMainThreadExecState.h to JSExecState.h.
3142
3143         * DOM/DOMAttr.mm:
3144         * DOM/DOMBlob.mm:
3145         * DOM/DOMCDATASection.mm:
3146         * DOM/DOMCSSCharsetRule.mm:
3147         * DOM/DOMCSSFontFaceRule.mm:
3148         * DOM/DOMCSSImportRule.mm:
3149         * DOM/DOMCSSMediaRule.mm:
3150         * DOM/DOMCSSPageRule.mm:
3151         * DOM/DOMCSSPrimitiveValue.mm:
3152         * DOM/DOMCSSRule.mm:
3153         * DOM/DOMCSSRuleList.mm:
3154         * DOM/DOMCSSStyleDeclaration.mm:
3155         * DOM/DOMCSSStyleRule.mm:
3156         * DOM/DOMCSSStyleSheet.mm:
3157         * DOM/DOMCSSUnknownRule.mm:
3158         * DOM/DOMCSSValue.mm:
3159         * DOM/DOMCSSValueList.mm:
3160         * DOM/DOMCharacterData.mm:
3161         * DOM/DOMComment.mm:
3162         * DOM/DOMCounter.mm:
3163         * DOM/DOMDocument.mm:
3164         * DOM/DOMDocumentFragment.mm:
3165         * DOM/DOMDocumentType.mm:
3166         * DOM/DOMElement.mm:
3167         * DOM/DOMEvent.mm:
3168         * DOM/DOMFile.mm:
3169         * DOM/DOMFileList.mm:
3170         * DOM/DOMHTML.mm:
3171         * DOM/DOMHTMLAnchorElement.mm:
3172         * DOM/DOMHTMLAppletElement.mm:
3173         * DOM/DOMHTMLAreaElement.mm:
3174         * DOM/DOMHTMLBRElement.mm:
3175         * DOM/DOMHTMLBaseElement.mm:
3176         * DOM/DOMHTMLBaseFontElement.mm:
3177         * DOM/DOMHTMLBodyElement.mm:
3178         * DOM/DOMHTMLButtonElement.mm:
3179         * DOM/DOMHTMLCanvasElement.mm:
3180         * DOM/DOMHTMLCollection.mm:
3181         * DOM/DOMHTMLDListElement.mm:
3182         * DOM/DOMHTMLDirectoryElement.mm:
3183         * DOM/DOMHTMLDivElement.mm:
3184         * DOM/DOMHTMLDocument.mm:
3185         * DOM/DOMHTMLElement.mm:
3186         * DOM/DOMHTMLEmbedElement.mm:
3187         * DOM/DOMHTMLFieldSetElement.mm:
3188         * DOM/DOMHTMLFontElement.mm:
3189         * DOM/DOMHTMLFormElement.mm:
3190         * DOM/DOMHTMLFrameElement.mm:
3191         * DOM/DOMHTMLFrameSetElement.mm:
3192         * DOM/DOMHTMLHRElement.mm:
3193         * DOM/DOMHTMLHeadElement.mm:
3194         * DOM/DOMHTMLHeadingElement.mm:
3195         * DOM/DOMHTMLHtmlElement.mm:
3196         * DOM/DOMHTMLIFrameElement.mm:
3197         * DOM/DOMHTMLImageElement.mm:
3198         * DOM/DOMHTMLInputElement.mm:
3199         * DOM/DOMHTMLLIElement.mm:
3200         * DOM/DOMHTMLLabelElement.mm:
3201         * DOM/DOMHTMLLegendElement.mm:
3202         * DOM/DOMHTMLLinkElement.mm:
3203         * DOM/DOMHTMLMapElement.mm:
3204         * DOM/DOMHTMLMarqueeElement.mm:
3205         * DOM/DOMHTMLMediaElement.mm:
3206         * DOM/DOMHTMLMenuElement.mm:
3207         * DOM/DOMHTMLMetaElement.mm:
3208         * DOM/DOMHTMLModElement.mm:
3209         * DOM/DOMHTMLOListElement.mm:
3210         * DOM/DOMHTMLObjectElement.mm:
3211         * DOM/DOMHTMLOptGroupElement.mm:
3212         * DOM/DOMHTMLOptionElement.mm:
3213         * DOM/DOMHTMLOptionsCollection.mm:
3214         * DOM/DOMHTMLParagraphElement.mm:
3215         * DOM/DOMHTMLParamElement.mm:
3216         * DOM/DOMHTMLPreElement.mm:
3217         * DOM/DOMHTMLQuoteElement.mm:
3218         * DOM/DOMHTMLScriptElement.mm:
3219         * DOM/DOMHTMLSelectElement.mm:
3220         * DOM/DOMHTMLStyleElement.mm:
3221         * DOM/DOMHTMLTableCaptionElement.mm:
3222         * DOM/DOMHTMLTableCellElement.mm:
3223         * DOM/DOMHTMLTableColElement.mm:
3224         * DOM/DOMHTMLTableElement.mm:
3225         * DOM/DOMHTMLTableRowElement.mm:
3226         * DOM/DOMHTMLTableSectionElement.mm:
3227         * DOM/DOMHTMLTextAreaElement.mm:
3228         * DOM/DOMHTMLTitleElement.mm:
3229         * DOM/DOMHTMLUListElement.mm:
3230         * DOM/DOMHTMLVideoElement.mm:
3231         * DOM/DOMImplementation.mm:
3232         * DOM/DOMKeyboardEvent.mm:
3233         * DOM/DOMMediaError.mm:
3234         * DOM/DOMMediaList.mm:
3235         * DOM/DOMMouseEvent.mm:
3236         * DOM/DOMMutationEvent.mm:
3237         * DOM/DOMNamedNodeMap.mm:
3238         * DOM/DOMNode.mm:
3239         * DOM/DOMNodeIterator.mm:
3240         * DOM/DOMNodeList.mm:
3241         * DOM/DOMOverflowEvent.mm:
3242         * DOM/DOMProcessingInstruction.mm:
3243         * DOM/DOMProgressEvent.mm:
3244         * DOM/DOMRGBColor.mm:
3245         * DOM/DOMRange.mm:
3246         * DOM/DOMRect.mm:
3247         * DOM/DOMStyleSheet.mm:
3248         * DOM/DOMStyleSheetList.mm:
3249         * DOM/DOMText.mm:
3250         * DOM/DOMTextEvent.mm:
3251         * DOM/DOMTimeRanges.mm:
3252         * DOM/DOMTokenList.mm:
3253         * DOM/DOMTreeWalker.mm:
3254         * DOM/DOMUIEvent.mm:
3255         * DOM/DOMWheelEvent.mm:
3256         * DOM/DOMXPathExpression.mm:
3257         * DOM/DOMXPathResult.mm:
3258         * DOM/ObjCEventListener.mm:
3259
3260 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3261
3262         Fix spelling of "overridden"
3263         https://bugs.webkit.org/show_bug.cgi?id=188315
3264
3265         Reviewed by Darin Adler.
3266
3267         * Misc/WebKitVersionChecks.mm:
3268         (setWebKitLinkTimeVersion):
3269         (WebKitLinkTimeVersion):
3270         * Plugins/WebBaseNetscapePluginView.mm:
3271         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3272         * WebCoreSupport/PopupMenuMac.mm:
3273         (PopupMenuMac::populate):
3274
3275 2018-08-01  Nan Wang  <n_wang@apple.com>
3276
3277         AX: AOM: Add ARIA IDL Attribute Reflection
3278         https://bugs.webkit.org/show_bug.cgi?id=184676
3279         <rdar://problem/39476882>
3280
3281         Reviewed by Chris Fleizach.
3282
3283         * WebView/WebPreferenceKeysPrivate.h:
3284         * WebView/WebPreferences.mm:
3285         (+[WebPreferences initialize]):
3286         (-[WebPreferences ariaReflectionEnabled]):
3287         (-[WebPreferences setAriaReflectionEnabled:]):
3288         * WebView/WebPreferencesPrivate.h:
3289         * WebView/WebView.mm:
3290         (-[WebView _preferencesChanged:]):
3291
3292 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3293
3294         Shrink GraphicsLayerCA
3295         https://bugs.webkit.org/show_bug.cgi?id=188141
3296
3297         Reviewed by Zalan Bujtas.
3298
3299         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3300         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3301         * moving all the animation-related stuff into the lazily-allocated m_animations
3302         * making enums be 8-bit
3303         * re-ordering data members
3304
3305         * WebView/WebView.mm:
3306         (-[WebView _setMediaLayer:forPluginView:]):
3307
3308 2018-07-30  Rob Buis  <rbuis@igalia.com>
3309
3310         Merge PlatformCookieJar functions into NetworkStorageSession
3311         https://bugs.webkit.org/show_bug.cgi?id=188137
3312
3313         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3314
3315         Reviewed by Alex Christensen.
3316
3317         * WebCoreSupport/WebPlatformStrategies.mm:
3318         (WebPlatformStrategies::cookiesForDOM):
3319         (WebPlatformStrategies::setCookiesFromDOM):
3320         (WebPlatformStrategies::cookiesEnabled):
3321         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3322         (WebPlatformStrategies::getRawCookies):
3323         (WebPlatformStrategies::deleteCookie):
3324         * WebView/WebPreferences.mm:
3325         (+[WebPreferences _clearNetworkLoaderSession]):
3326
3327 2018-07-28  Darin Adler  <darin@apple.com>
3328
3329         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3330         https://bugs.webkit.org/show_bug.cgi?id=188140
3331
3332         Reviewed by Sam Weinig.
3333
3334         * WebView/WebImmediateActionController.mm:
3335         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3336         new DictionaryLookup function that returns a tuple instead of using an out argument.
3337
3338 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3339
3340         [INTL] Remove INTL sub-feature compile flags
3341         https://bugs.webkit.org/show_bug.cgi?id=188081
3342
3343         Reviewed by Michael Catanzaro.
3344
3345         * Configurations/FeatureDefines.xcconfig:
3346
3347 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3348
3349         Unreviewed, rolling out r234181 and r234189.
3350         https://bugs.webkit.org/show_bug.cgi?id=188075
3351
3352         These are not needed right now (Requested by thorton on
3353         #webkit).
3354
3355         Reverted changesets:
3356
3357         "Enable Web Content Filtering on watchOS"
3358         https://bugs.webkit.org/show_bug.cgi?id=187979
3359         https://trac.webkit.org/changeset/234181
3360
3361         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3362         https://bugs.webkit.org/show_bug.cgi?id=187985
3363         https://trac.webkit.org/changeset/234189
3364
3365 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3366
3367         Use the Page's appearance when converting pasteboard attributed strings.
3368         https://bugs.webkit.org/show_bug.cgi?id=188067
3369         rdar://problem/42632246
3370
3371         Reviewed by Wenson Hsieh.
3372
3373         * WebCoreSupport/WebEditorClient.mm:
3374         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3375
3376 2018-07-25  Chris Dumez  <cdumez@apple.com>
3377
3378         navigator.userAgent may return outdated value after webView.customUserAgent is set
3379         https://bugs.webkit.org/show_bug.cgi?id=188009
3380         <rdar://problem/42566456>
3381
3382         Reviewed by Alex Christensen.
3383
3384         Let the page know when the user agent changes.
3385
3386         * WebView/WebView.mm:
3387         (-[WebView _preferencesChanged:]):
3388         (-[WebView setApplicationNameForUserAgent:]):
3389         (-[WebView _invalidateUserAgentCache]):
3390         (-[WebView setCustomUserAgent:]):
3391         * WebView/WebViewInternal.h:
3392
3393 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3394
3395         Enable Web Content Filtering on watchOS
3396         https://bugs.webkit.org/show_bug.cgi?id=187979
3397         <rdar://problem/42559346>
3398
3399         Reviewed by Wenson Hsieh.
3400
3401         * Configurations/FeatureDefines.xcconfig:
3402
3403 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3404
3405         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3406         https://bugs.webkit.org/show_bug.cgi?id=187846
3407
3408         Reviewed by Simon Fraser.
3409
3410         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3411
3412         * WebView/WebHTMLView.mm:
3413         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3414         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3415
3416 2018-07-11  Dean Jackson  <dino@apple.com>
3417
3418         Allow removal of white backgrounds
3419         https://bugs.webkit.org/show_bug.cgi?id=187574
3420         <rdar://problem/41146792>
3421
3422         Reviewed by Simon Fraser.
3423
3424         Add a new WebPreference for punching out white backgrounds.
3425
3426         * WebView/WebPreferenceKeysPrivate.h:
3427         * WebView/WebPreferences.mm:
3428         (+[WebPreferences initialize]):
3429         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3430         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3431         * WebView/WebPreferencesPrivate.h:
3432         * WebView/WebView.mm:
3433         (-[WebView _preferencesChanged:]):
3434
3435 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3436
3437         Ensure WebKit stack is ad-hoc signed
3438         https://bugs.webkit.org/show_bug.cgi?id=187667
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         * Configurations/Base.xcconfig:
3443
3444 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3445
3446         REGRESSION (231276): Attempting to copy an image fails
3447         https://bugs.webkit.org/show_bug.cgi?id=187212
3448         <rdar://problem/41540074>
3449
3450         Reviewed by Ryosuke Niwa.
3451
3452         Renamed methods to make it clear that one URL and one title are being passed in.
3453
3454         * WebCoreSupport/WebPlatformStrategies.h:
3455         * WebCoreSupport/WebPlatformStrategies.mm:
3456         (WebPlatformStrategies::setURL):
3457
3458 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3459
3460         Disable cross-origin-window-policy by default
3461         https://bugs.webkit.org/show_bug.cgi?id=187509
3462
3463         Reviewed by Chris Dumez.
3464
3465         * WebView/WebPreferences.mm:
3466         (+[WebPreferences initialize]):
3467
3468 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3469
3470         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3471         https://bugs.webkit.org/show_bug.cgi?id=187425
3472         rdar://problem/39948240
3473
3474         Reviewed by Tim Horton.
3475
3476         * WebView/WebView.mm:
3477         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3478         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3479         a call in this method to setUseDarkAppearance.
3480         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3481         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3482         (-[WebView _updateDefaultAppearance]): Deleted.
3483         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3484
3485 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3486
3487         Shrink various loading-related enums to shrink CachedResource
3488         https://bugs.webkit.org/show_bug.cgi?id=187443
3489
3490         Reviewed by Chris Dumez.
3491
3492         * WebCoreSupport/WebFrameLoaderClient.mm:
3493         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3494         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3495         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3496         (WebFrameLoaderClient::dispatchWillSendRequest):
3497         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3498         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3499         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3500         (WebFrameLoaderClient::updateGlobalHistory):
3501         (WebFrameLoaderClient::canHandleRequest const):
3502         * WebView/WebDataSource.mm:
3503         (-[WebDataSource initialRequest]):
3504         (-[WebDataSource request]):
3505
3506 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3507
3508         Unreviewed, rolling out r233612.
3509         https://bugs.webkit.org/show_bug.cgi?id=187475
3510
3511         Revision caused the api test LinkColorWithSystemAppearance to
3512         fail on all systems. (Requested by Truitt on #webkit).
3513
3514         Reverted changeset:
3515
3516         "Semantic colors don't update when accessibility Increase
3517         Contrast mode is enabled."
3518         https://bugs.webkit.org/show_bug.cgi?id=187425
3519         https://trac.webkit.org/changeset/233612
3520
3521 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3522
3523         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3524         https://bugs.webkit.org/show_bug.cgi?id=187425
3525         rdar://problem/39948240
3526
3527         Reviewed by Tim Horton.
3528
3529         * WebView/WebView.mm:
3530         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3531         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3532         a call in this method to setUseDarkAppearance.
3533         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3534         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3535         (-[WebView _updateDefaultAppearance]): Deleted.
3536         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3537
3538 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3539
3540         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3541         https://bugs.webkit.org/show_bug.cgi?id=187369
3542         rdar://problem/41870420
3543
3544         Reviewed by Tim Horton.
3545
3546         * WebView/WebMediaPlaybackTargetPicker.mm:
3547         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3548         * WebView/WebView.mm:
3549         (-[WebView _commonInitializationWithFrameName:groupName:]):
3550         (-[WebView _effectiveAppearanceIsDark]):
3551         (-[WebView _updateDefaultAppearance]):
3552         (-[WebView _defaultAppearance]): Deleted.
3553
3554 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3555
3556         Youtube video pages crash after a couple of minutes
3557         https://bugs.webkit.org/show_bug.cgi?id=187316
3558
3559         Reviewed by Antti Koivisto.
3560
3561         * WebView/WebView.mm:
3562         (-[WebView _preferencesChanged:]):
3563
3564 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3565
3566         Introduce PLATFORM(IOSMAC)
3567         https://bugs.webkit.org/show_bug.cgi?id=187315
3568
3569         Reviewed by Dan Bernstein.
3570
3571         * Configurations/Base.xcconfig:
3572         * Configurations/FeatureDefines.xcconfig:
3573
3574 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3575
3576         [iOS] DataTransfer.getData always returns the empty string when dropping text
3577         https://bugs.webkit.org/show_bug.cgi?id=187130
3578         <rdar://problem/41014117>
3579
3580         Reviewed by Ryosuke Niwa.
3581
3582         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3583
3584         * WebCoreSupport/WebPlatformStrategies.h:
3585         * WebCoreSupport/WebPlatformStrategies.mm:
3586         (WebPlatformStrategies::allPasteboardItemInfo):
3587
3588 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3589
3590         [Mac] AirPlay picker uses incorrect theme in Dark mode
3591         https://bugs.webkit.org/show_bug.cgi?id=187054
3592         <rdar://problem/41291093>
3593
3594         Reviewed by Timothy Hatcher.
3595
3596         * WebView/WebMediaPlaybackTargetPicker.mm:
3597         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3598
3599 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3600
3601         [WTF] Add user-defined literal for ASCIILiteral
3602         https://bugs.webkit.org/show_bug.cgi?id=186839
3603
3604         Reviewed by Darin Adler.
3605
3606         * DOM/ExceptionHandlers.mm:
3607         (raiseDOMErrorException):
3608         * Plugins/Hosted/ProxyInstance.mm:
3609         (WebKit::ProxyInstance::invokeMethod):
3610         * Storage/WebDatabaseProvider.mm:
3611         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3612
3613 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3614
3615         Recalc styles every time defaultAppearance changes.
3616         https://bugs.webkit.org/show_bug.cgi?id=186866
3617         rdar://problem/41309805
3618
3619         Reviewed by Tim Horton.
3620
3621         * WebView/WebView.mm:
3622         (-[WebView _updateDefaultAppearance]):
3623         (-[WebView _setUseSystemAppearance:]):
3624         (-[WebView _useSystemAppearance]):
3625
3626 2018-06-20  Darin Adler  <darin@apple.com>
3627
3628         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3629         https://bugs.webkit.org/show_bug.cgi?id=186875
3630
3631         Reviewed by Anders Carlsson.
3632
3633         * WebView/WebHTMLView.mm:
3634         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3635         to write te file to.
3636         * WebView/WebPreferences.mm:
3637         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3638         * WebView/WebView.mm:
3639         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3640
3641 2018-06-12  Darin Adler  <darin@apple.com>
3642
3643         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3644         https://bugs.webkit.org/show_bug.cgi?id=186526
3645
3646         Reviewed by Anders Carlsson.
3647
3648         * Plugins/Hosted/NetscapePluginHostManager.mm:
3649         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3650
3651         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3652         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3653         assignment rather than adoptNS/leakRef.
3654         * Plugins/WebNetscapePluginView.mm:
3655         (-[WebNetscapePluginView createPlugin]): Ditto.
3656
3657         * WebCoreSupport/WebContextMenuClient.mm:
3658         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3659         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3660         argument, so use RetainPtr::get instead.
3661
3662         * WebView/WebHTMLView.mm:
3663         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3664         No need to autorelease the result when the return type is RetainPtr.
3665
3666         * WebView/WebPDFRepresentation.mm:
3667         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3668
3669 2018-06-13  Youenn Fablet  <youenn@apple.com>
3670
3671         Supported plugin check should be based on plugin identifier
3672         https://bugs.webkit.org/show_bug.cgi?id=186578
3673         <rdar://problem/40523828>
3674
3675         Reviewed by Darin Adler.
3676
3677         * WebCoreSupport/WebPluginInfoProvider.h:
3678         * WebCoreSupport/WebPluginInfoProvider.mm:
3679         (WebPluginInfoProvider::pluginInfo):
3680         (WebPluginInfoProvider::webVisiblePluginInfo):
3681
3682 2018-06-13  Chris Dumez  <cdumez@apple.com>
3683
3684         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3685         https://bugs.webkit.org/show_bug.cgi?id=186545
3686
3687         Reviewed by Brady Eidson.
3688
3689         Update client delegate now that parameter type has changed.
3690
3691         * WebCoreSupport/WebFrameLoaderClient.h:
3692         * WebCoreSupport/WebFrameLoaderClient.mm:
3693         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3694
3695 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3696
3697         Link drag image is inconsistently unreadable in dark mode
3698         https://bugs.webkit.org/show_bug.cgi?id=186472
3699
3700         Reviewed by Timothy Hatcher.
3701
3702         * WebView/WebView.mm:
3703         (-[WebView _defaultAppearance]):
3704         Make defaultAppearance accurate even if useSystemAppearance is false.
3705         Some parts of WebKit (like the link drag image, but also context menus)
3706         want to be able to follow the system appearance regardless of whether
3707         the view or content has opted in.
3708
3709 2018-06-11  Chris Dumez  <cdumez@apple.com>
3710
3711         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3712         https://bugs.webkit.org/show_bug.cgi?id=186441
3713
3714         Reviewed by Brady Eidson.
3715
3716         Rename existing flag to something a bit more generic, now that it is used for
3717         more things than bypassing the navigation policy check.
3718
3719         * WebView/WebView.mm:
3720         (-[WebView _loadBackForwardListFromOtherView:]):
3721         (-[WebView goToBackForwardItem:]):
3722
3723 2018-06-09  Dan Bernstein  <mitz@apple.com>
3724
3725         [Xcode] Clean up and modernize some build setting definitions
3726         https://bugs.webkit.org/show_bug.cgi?id=186463
3727
3728         Reviewed by Sam Weinig.
3729
3730         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3731         * Configurations/DebugRelease.xcconfig: Ditto.
3732         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3733           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3734         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3735         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3736           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3737         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3738
3739 2018-06-08  Darin Adler  <darin@apple.com>
3740
3741         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3742         https://bugs.webkit.org/show_bug.cgi?id=186436
3743
3744         Reviewed by Anders Carlsson.
3745
3746         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3747         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3748         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3749         (PoolCleaner): Ditto.
3750
3751         * History/WebHistory.mm:
3752         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3753         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3754         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3755         now hardly used if at all.
3756         * WebView/WebView.mm:
3757         (-[WebView rectsForTextMatches]): Ditto.
3758
3759 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3760
3761         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3762         https://bugs.webkit.org/show_bug.cgi?id=186442
3763         <rdar://problem/40879364>
3764
3765         Reviewed by Tim Horton.
3766
3767         * Configurations/FeatureDefines.xcconfig:
3768
3769 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3770
3771         [Datalist] Allow TextFieldInputType to show and hide suggestions
3772         https://bugs.webkit.org/show_bug.cgi?id=186151
3773
3774         Reviewed by Tim Horton.
3775
3776         * WebCoreSupport/WebChromeClient.h:
3777         * WebCoreSupport/WebChromeClient.mm:
3778         (WebChromeClient::createDataListSuggestionPicker):
3779
3780 2018-06-07  Chris Dumez  <cdumez@apple.com>
3781
3782         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3783         https://bugs.webkit.org/show_bug.cgi?id=186407
3784
3785         Reviewed by Brent Fulgham.
3786
3787         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3788         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3789         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3790         makeWeakPtr().
3791
3792         * WebCoreSupport/WebEditorClient.h:
3793         * WebCoreSupport/WebEditorClient.mm:
3794         (WebEditorClient::requestCandidatesForSelection):
3795
3796 2018-06-05  Chris Dumez  <cdumez@apple.com>
3797
3798         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3799         https://bugs.webkit.org/show_bug.cgi?id=186331
3800         <rdar://problem/40735446>
3801
3802         Reviewed by Darin Adler.
3803
3804         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3805         but does not call use / ignore on the listener, then we would do "use" by default.
3806         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3807         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3808         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3809         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3810         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3811         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3812         and Box.app is still working properly.
3813
3814         * WebCoreSupport/WebFrameLoaderClient.h:
3815         * WebCoreSupport/WebFrameLoaderClient.mm:
3816         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3817         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3818         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3819         (WebFrameLoaderClient::dispatchWillSubmitForm):
3820         (WebFrameLoaderClient::setUpPolicyListener):
3821         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3822         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3823         (-[WebFramePolicyListener dealloc]):
3824         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3825         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3826
3827 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3828
3829         Adjust compile and runtime flags to match shippable state of features
3830         https://bugs.webkit.org/show_bug.cgi?id=186319
3831         <rdar://problem/40352045>
3832
3833         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3834
3835         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3836         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3837         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3838         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3839         Cocoa builds.
3840
3841 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3842
3843         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3844
3845         https://bugs.webkit.org/show_bug.cgi?id=186323
3846         rdar://problem/38382252
3847
3848         Reviewed by Tim Horton.
3849
3850         * WebView/WebView.mm:
3851         (-[WebView _defaultAppearance]):
3852
3853 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3854
3855         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3856         https://bugs.webkit.org/show_bug.cgi?id=186286
3857         <rdar://problem/40782992>
3858
3859         Reviewed by Dan Bernstein.
3860
3861         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3862         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3863         change this flag when preparing for a production release.
3864
3865         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3866         whether experimental features should be enabled, and use it to properly define the
3867         feature flag.
3868
3869 2018-06-03  Darin Adler  <darin@apple.com>
3870
3871         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3872         https://bugs.webkit.org/show_bug.cgi?id=186258
3873
3874         Reviewed by Daniel Bates.
3875
3876         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3877         forward declarations. Removed methods that don't need to be public.
3878
3879         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3880         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3881         unnamed category in here and also replaced the HUDWindowControllerDelegate
3882         with the unnamed category. Removed unused NSWindow category defining the
3883         isOnActiveSpace, which is not called anywhere in this file at this time.
3884         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3885         into setVideoElement.
3886         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3887         and removed unneeded typecast.
3888         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3889         using statement at the top of the file.
3890         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3891         the many side effects and special considerations that this method that sounds
3892         like a setter has. Updated code to use the new
3893         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3894         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3895         bit and added some FIXME comments about small problems noticed but not fixed.
3896         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3897         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3898         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3899         typecast. Removed call to updatePowerAssertions method.
3900         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3901         updatePowerAssertions method.
3902         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3903         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3904         else, so this was dead code that did nothing.
3905         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3906         updatePowerAssertions method.
3907
3908 2018-06-04  Chris Dumez  <cdumez@apple.com>
3909
3910         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3911         https://bugs.webkit.org/show_bug.cgi?id=186287
3912         <rdar://problem/40783352>
3913
3914         Reviewed by Youenn Fablet.
3915
3916         * WebView/WebPreferenceKeysPrivate.h:
3917         * WebView/WebPreferences.mm:
3918         (+[WebPreferences initialize]):
3919         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3920         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3921         * WebView/WebPreferencesPrivate.h:
3922         * WebView/WebView.mm:
3923         (-[WebView _preferencesChanged:]):
3924
3925 2018-06-02  Darin Adler  <darin@apple.com>
3926
3927         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3928         https://bugs.webkit.org/show_bug.cgi?id=186227
3929
3930         Reviewed by Dan Bernstein.
3931
3932         * Misc/WebKitErrors.m:
3933         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3934         * Plugins/WebPluginDatabase.mm:
3935         (-[WebPluginDatabase refresh]): Ditto.
3936         * WebCoreSupport/WebChromeClient.mm:
3937         (WebChromeClient::setStatusbarText): Ditto.
3938
3939 2018-06-01  Chris Dumez  <cdumez@apple.com>
3940
3941         REGRESSION (r231456): Colloquy is broken
3942         https://bugs.webkit.org/show_bug.cgi?id=186197
3943         <rdar://problem/40722960>
3944
3945         Reviewed by Timothy Hatcher.
3946
3947         Restore pre-r231456 behavior for Colloquy app so that it works again.
3948
3949         * WebView/WebView.mm:
3950         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3951         (-[WebView _preferencesChanged:]):
3952
3953 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3954
3955         [JSC] Pass VM& parameter as much as possible
3956         https://bugs.webkit.org/show_bug.cgi?id=186085
3957
3958         Reviewed by Saam Barati.
3959
3960         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3961         (WebKit::NetscapePluginInstanceProxy::invoke):
3962
3963 2018-05-30  Daniel Bates  <dabates@apple.com>
3964
3965         NavigationAction does not need to hold initiating DOM Event
3966         https://bugs.webkit.org/show_bug.cgi?id=185958
3967         <rdar://problem/40531539>
3968
3969         Reviewed by Simon Fraser.
3970
3971         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3972
3973         * WebCoreSupport/WebFrameLoaderClient.mm:
3974         (WebFrameLoaderClient::actionDictionary const):
3975         (findMouseEvent): Deleted.
3976
3977 2018-05-27  Dan Bernstein  <mitz@apple.com>
3978
3979         Reverted the changes made for https://webkit.org/b/186016
3980
3981         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3982
3983
3984 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3985
3986         [iOS] Fix warnings about leaks found by clang static analyzer
3987         <https://webkit.org/b/186009>
3988         <rdar://problem/40574267>
3989
3990         Reviewed by Daniel Bates.
3991
3992         * WebView/WebHTMLView.mm:
3993         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3994         uninitialized boolean variable (`eventWasHandled`) that only
3995         happened on iOS.
3996
3997 2018-05-27  Dan Bernstein  <mitz@apple.com>
3998
3999         [Cocoa] Avoid importing directly from subumbrella frameworks
4000         https://bugs.webkit.org/show_bug.cgi?id=186016
4001
4002         Reviewed by Sam Weinig.
4003
4004         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
4005         * Carbon/CarbonWindowAdapter.mm: Ditto.
4006         * Carbon/CarbonWindowFrame.m: Ditto.
4007         * Carbon/HIViewAdapter.h: Ditto.
4008         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
4009           OTHER_CPLUSPLUSFLAGS.
4010         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
4011         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
4012         * WebView/WebPDFView.h: Ditto.
4013
4014 2018-05-27  Sam Weinig  <sam@webkit.org>
4015
4016         Modernize RenderStyleConstants.h - Part 3
4017         https://bugs.webkit.org/show_bug.cgi?id=186015
4018
4019         Reviewed by Yusuke Suzuki.
4020
4021         * WebView/WebView.mm:
4022         (-[WebView updateTextTouchBar]):
4023         Update for new enum name.
4024
4025 2018-05-25  Chris Dumez  <cdumez@apple.com>
4026
4027         Minor ApplicationCacheStorage clean up
4028         https://bugs.webkit.org/show_bug.cgi?id=185984
4029
4030         Reviewed by Youenn Fablet.
4031
4032         * WebCoreSupport/WebApplicationCache.mm:
4033         (+[WebApplicationCache originsWithCache]):
4034
4035 2018-05-25  David Kilzer  <ddkilzer@apple.com>
4036
4037         Fix issues with -dealloc methods found by clang static analyzer
4038         <https://webkit.org/b/185887>
4039
4040         Reviewed by Joseph Pecoraro.
4041
4042         * WebView/WebView.mm:
4043         (-[WebUITextIndicatorData dealloc]):
4044         - Move method implementation from (WebUITextIndicatorInternal)
4045           category to the main category since this is public API.  This
4046           fixes the false positive warning about a missing -dealloc
4047           method.
4048
4049 2018-05-24  Sam Weinig  <sam@webkit.org>
4050
4051         Modernize