Complete fix for enabling modern EME by default
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-05-18  Jer Noble  <jer.noble@apple.com>
2
3         Complete fix for enabling modern EME by default
4         https://bugs.webkit.org/show_bug.cgi?id=185770
5         <rdar://problem/40368220>
6
7         Reviewed by Eric Carlson.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2018-05-18  Chris Dumez  <cdumez@apple.com>
12
13         Avoid keeping the frame alive when ref'ing a WindowProxy
14         https://bugs.webkit.org/show_bug.cgi?id=185737
15         <rdar://problem/40004666>
16
17         Reviewed by Sam Weinig.
18
19         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
21
22 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
23
24         Add support for Intl NumberFormat formatToParts
25         https://bugs.webkit.org/show_bug.cgi?id=185375
26
27         Reviewed by Yusuke Suzuki.
28
29         Add flag for NumberFormat formatToParts.
30
31         * Configurations/FeatureDefines.xcconfig:
32
33 2018-05-16  Chris Nardi  <cnardi@chromium.org>
34
35         Fixup after r231849: Do not mark Mac API methods as deprecated
36         https://bugs.webkit.org/show_bug.cgi?id=185684
37
38         Reviewed by Darin Adler.
39
40         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
41         as the entire class is already marked as deprecated, so it is unnecessary.
42
43         * DOM/DOMDocument.h:
44
45 2018-05-16  Chris Nardi  <cnardi@chromium.org>
46
47         Remove Document#selectedStylesheetSet/preferredStylesheetSet
48         https://bugs.webkit.org/show_bug.cgi?id=185381
49
50         Reviewed by Darin Adler.
51
52         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
53         and make them do nothing.
54
55         * DOM/DOMDocument.h:
56         * DOM/DOMDocument.mm:
57         (-[DOMDocument preferredStylesheetSet]):
58         (-[DOMDocument selectedStylesheetSet]):
59         (-[DOMDocument setSelectedStylesheetSet:]):
60
61 2018-05-15  Antoine Quint  <graouts@apple.com>
62
63         [Web Animations] Expose Web Animations CSS integration as an experimental feature
64         https://bugs.webkit.org/show_bug.cgi?id=185647
65
66         Reviewed by Dean Jackson.
67
68         Rename the Web Animations CSS integration flag.
69
70         * WebView/WebPreferenceKeysPrivate.h:
71         * WebView/WebPreferences.mm:
72         (+[WebPreferences initialize]):
73         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
74         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
75         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
76         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
77         * WebView/WebPreferencesPrivate.h:
78         * WebView/WebView.mm:
79         (-[WebView _preferencesChanged:]):
80
81 2018-05-14  Daniel Bates  <dabates@apple.com>
82
83         Fix the Apple Internal build
84
85         See <rdar://problem/40237873> for more details.
86
87         * WebView/WebFullScreenController.mm:
88         (-[WebFullScreenController enterFullScreen:]):
89         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
90         (-[WebFullScreenController exitFullScreen]):
91         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
92         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
93         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
94
95 2018-05-11  Timothy Hatcher  <timothy@apple.com>
96
97         WebHTMLView is not setting aside subviews when drawing.
98
99         https://bugs.webkit.org/show_bug.cgi?id=185561
100         rdar://problem/40172894
101
102         Reviewed by Simon Fraser.
103
104         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
105
106         * WebView/WebHTMLView.mm:
107         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
108
109 2018-05-07  Daniel Bates  <dabates@apple.com>
110
111         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
112         https://bugs.webkit.org/show_bug.cgi?id=185170
113
114         Reviewed by Per Arne Vollan.
115
116         * Misc/WebCache.mm:
117         (+[WebCache empty]):
118
119 2018-05-04  Timothy Hatcher  <timothy@apple.com>
120
121         Deprecate legacy WebView and friends
122         https://bugs.webkit.org/show_bug.cgi?id=185279
123         rdar://problem/33268700
124
125         Reviewed by Tim Horton.
126
127         Added deprecation macros to all the classes, extern strings, and enums.
128
129         * Configurations/WebKitLegacy.xcconfig:
130         Added BUILDING_WEBKIT define to disable the deprecation macros.
131         * DOM/DOMAbstractView.h:
132         * DOM/DOMAttr.h:
133         * DOM/DOMBlob.h:
134         * DOM/DOMCDATASection.h:
135         * DOM/DOMCSSCharsetRule.h:
136         * DOM/DOMCSSFontFaceRule.h:
137         * DOM/DOMCSSImportRule.h:
138         * DOM/DOMCSSMediaRule.h:
139         * DOM/DOMCSSPageRule.h:
140         * DOM/DOMCSSPrimitiveValue.h:
141         * DOM/DOMCSSRule.h:
142         * DOM/DOMCSSRuleList.h:
143         * DOM/DOMCSSStyleDeclaration.h:
144         * DOM/DOMCSSStyleRule.h:
145         * DOM/DOMCSSStyleSheet.h:
146         * DOM/DOMCSSUnknownRule.h:
147         * DOM/DOMCSSValue.h:
148         * DOM/DOMCSSValueList.h:
149         * DOM/DOMCharacterData.h:
150         * DOM/DOMComment.h:
151         * DOM/DOMCounter.h:
152         * DOM/DOMDocument.h:
153         * DOM/DOMDocumentFragment.h:
154         * DOM/DOMDocumentType.h:
155         * DOM/DOMElement.h:
156         * DOM/DOMEntity.h:
157         * DOM/DOMEntityReference.h:
158         * DOM/DOMEvent.h:
159         * DOM/DOMEventException.h:
160         * DOM/DOMEventListener.h:
161         * DOM/DOMEventTarget.h:
162         * DOM/DOMException.h:
163         * DOM/DOMFile.h:
164         * DOM/DOMFileList.h:
165         * DOM/DOMHTMLAnchorElement.h:
166         * DOM/DOMHTMLAppletElement.h:
167         * DOM/DOMHTMLAreaElement.h:
168         * DOM/DOMHTMLBRElement.h:
169         * DOM/DOMHTMLBaseElement.h:
170         * DOM/DOMHTMLBaseFontElement.h:
171         * DOM/DOMHTMLBodyElement.h:
172         * DOM/DOMHTMLButtonElement.h:
173         * DOM/DOMHTMLCanvasElement.h:
174         * DOM/DOMHTMLCollection.h:
175         * DOM/DOMHTMLDListElement.h:
176         * DOM/DOMHTMLDirectoryElement.h:
177         * DOM/DOMHTMLDivElement.h:
178         * DOM/DOMHTMLDocument.h:
179         * DOM/DOMHTMLElement.h:
180         * DOM/DOMHTMLEmbedElement.h:
181         * DOM/DOMHTMLFieldSetElement.h:
182         * DOM/DOMHTMLFontElement.h:
183         * DOM/DOMHTMLFormElement.h:
184         * DOM/DOMHTMLFrameElement.h:
185         * DOM/DOMHTMLFrameSetElement.h:
186         * DOM/DOMHTMLHRElement.h:
187         * DOM/DOMHTMLHeadElement.h:
188         * DOM/DOMHTMLHeadingElement.h:
189         * DOM/DOMHTMLHtmlElement.h:
190         * DOM/DOMHTMLIFrameElement.h:
191         * DOM/DOMHTMLImageElement.h:
192         * DOM/DOMHTMLInputElement.h:
193         * DOM/DOMHTMLLIElement.h:
194         * DOM/DOMHTMLLabelElement.h:
195         * DOM/DOMHTMLLegendElement.h:
196         * DOM/DOMHTMLLinkElement.h:
197         * DOM/DOMHTMLMapElement.h:
198         * DOM/DOMHTMLMarqueeElement.h:
199         * DOM/DOMHTMLMediaElement.h:
200         * DOM/DOMHTMLMenuElement.h:
201         * DOM/DOMHTMLMetaElement.h:
202         * DOM/DOMHTMLModElement.h:
203         * DOM/DOMHTMLOListElement.h:
204         * DOM/DOMHTMLObjectElement.h:
205         * DOM/DOMHTMLOptGroupElement.h:
206         * DOM/DOMHTMLOptionElement.h:
207         * DOM/DOMHTMLOptionsCollection.h:
208         * DOM/DOMHTMLParagraphElement.h:
209         * DOM/DOMHTMLParamElement.h:
210         * DOM/DOMHTMLPreElement.h:
211         * DOM/DOMHTMLQuoteElement.h:
212         * DOM/DOMHTMLScriptElement.h:
213         * DOM/DOMHTMLSelectElement.h:
214         * DOM/DOMHTMLStyleElement.h:
215         * DOM/DOMHTMLTableCaptionElement.h:
216         * DOM/DOMHTMLTableCellElement.h:
217         * DOM/DOMHTMLTableColElement.h:
218         * DOM/DOMHTMLTableElement.h:
219         * DOM/DOMHTMLTableRowElement.h:
220         * DOM/DOMHTMLTableSectionElement.h:
221         * DOM/DOMHTMLTextAreaElement.h:
222         * DOM/DOMHTMLTitleElement.h:
223         * DOM/DOMHTMLUListElement.h:
224         * DOM/DOMHTMLVideoElement.h:
225         * DOM/DOMImplementation.h:
226         * DOM/DOMKeyboardEvent.h:
227         * DOM/DOMMediaError.h:
228         * DOM/DOMMediaList.h:
229         * DOM/DOMMouseEvent.h:
230         * DOM/DOMMutationEvent.h:
231         * DOM/DOMNamedNodeMap.h:
232         * DOM/DOMNode.h:
233         * DOM/DOMNodeFilter.h:
234         * DOM/DOMNodeIterator.h:
235         * DOM/DOMNodeList.h:
236         * DOM/DOMObject.h:
237         * DOM/DOMOverflowEvent.h:
238         * DOM/DOMProcessingInstruction.h:
239         * DOM/DOMProgressEvent.h:
240         * DOM/DOMRGBColor.h:
241         * DOM/DOMRange.h:
242         * DOM/DOMRangeException.h:
243         * DOM/DOMRect.h:
244         * DOM/DOMStyleSheet.h:
245         * DOM/DOMStyleSheetList.h:
246         * DOM/DOMText.h:
247         * DOM/DOMTextEvent.h:
248         * DOM/DOMTimeRanges.h:
249         * DOM/DOMTokenList.h:
250         * DOM/DOMTreeWalker.h:
251         * DOM/DOMUIEvent.h:
252         * DOM/DOMWheelEvent.h:
253         * DOM/DOMXPathException.h:
254         * DOM/DOMXPathExpression.h:
255         * DOM/DOMXPathNSResolver.h:
256         * DOM/DOMXPathResult.h:
257         * History/WebBackForwardList.h:
258         * History/WebHistory.h:
259         * History/WebHistoryItem.h:
260         * Misc/WebDownload.h:
261         * Misc/WebKitErrors.h:
262         * Plugins/WebPluginViewFactory.h:
263         * WebView/WebArchive.h:
264         * WebView/WebDataSource.h:
265         * WebView/WebDocument.h:
266         * WebView/WebEditingDelegate.h:
267         * WebView/WebFormDelegate.h:
268         * WebView/WebFrame.h:
269         * WebView/WebFrameLoadDelegate.h:
270         * WebView/WebFrameView.h:
271         * WebView/WebPolicyDelegate.h:
272         * WebView/WebPreferences.h:
273         * WebView/WebPreferencesPrivate.h:
274         * WebView/WebResourceLoadDelegate.h:
275         * WebView/WebUIDelegate.h:
276         * WebView/WebUIDelegatePrivate.h:
277         * WebView/WebView.h:
278         * WebView/WebViewPrivate.h:
279         * postprocess-headers.sh:
280         Remove step that converts WEBKIT macros to NS macros.
281         Change it to just remove the macros on iOS builds.
282
283 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
284
285         [MediaStream] remove WK1 support
286         https://bugs.webkit.org/show_bug.cgi?id=185136
287
288         Reviewed by Youenn Fablet.
289
290         * WebCoreSupport/WebUserMediaClient.h: Removed.
291         * WebCoreSupport/WebUserMediaClient.mm: Removed.
292         * WebView/WebView.mm:
293         (-[WebView _commonInitializationWithFrameName:groupName:]):
294         (-[WebView _preferencesChanged:]):
295         (-[WebView _setUserMediaClient:]): Deleted.
296         (-[WebView _userMediaClient]): Deleted.
297         * WebView/WebViewData.h:
298         * WebView/WebViewPrivate.h:
299
300 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
301
302         WebAssembly: add support for stream APIs - JavaScript API
303         https://bugs.webkit.org/show_bug.cgi?id=183442
304
305         Reviewed by Yusuke Suzuki and JF Bastien.
306
307         Add WEBASSEMBLY_STREAMINNG_API feature flag
308
309         * Configurations/FeatureDefines.xcconfig:
310
311 2018-04-30  JF Bastien  <jfbastien@apple.com>
312
313         Use some C++17 features
314         https://bugs.webkit.org/show_bug.cgi?id=185135
315
316         Reviewed by Alex Christensen.
317
318         * Configurations/WebKitLegacy.xcconfig:
319
320 2018-04-27  Chris Dumez  <cdumez@apple.com>
321
322         Use WindowProxy instead of DOMWindow in our IDL
323         https://bugs.webkit.org/show_bug.cgi?id=185022
324
325         Reviewed by Sam Weinig.
326
327         * DOM/DOMAbstractView.mm:
328         (kit):
329         (toWindowProxy):
330         * DOM/DOMAbstractViewInternal.h:
331         * DOM/DOMDocument.mm:
332         (-[DOMDocument defaultView]):
333         (-[DOMDocument getComputedStyle:pseudoElement:]):
334         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
335         * DOM/DOMHTMLFrameElement.mm:
336         (-[DOMHTMLFrameElement contentWindow]):
337         * DOM/DOMHTMLIFrameElement.mm:
338         (-[DOMHTMLIFrameElement contentWindow]):
339         * DOM/DOMKeyboardEvent.mm:
340         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
341         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
342         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
343         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
344         * DOM/DOMMouseEvent.mm:
345         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
346         * DOM/DOMTextEvent.mm:
347         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
348         * DOM/DOMUIEvent.mm:
349         (-[DOMUIEvent view]):
350         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
351         * DOM/DOMWheelEvent.mm:
352         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
353
354 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
355
356         Implement rendering support for the color-filter CSS property
357         https://bugs.webkit.org/show_bug.cgi?id=185047
358         rdar://problem/39664967
359
360         Reviewed by Tim Horton.
361         
362         The body background should reflect the filtered color.
363
364         * WebView/WebFrame.mm:
365         (-[WebFrame _bodyBackgroundColor]):
366         * WebView/WebView.mm:
367         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
368
369 2018-04-26  Jer Noble  <jer.noble@apple.com>
370
371         WK_COCOA_TOUCH all the things.
372         https://bugs.webkit.org/show_bug.cgi?id=185006
373
374         Reviewed by Tim Horton.
375
376         * Configurations/WebKitLegacy.xcconfig:
377
378 2018-04-26  Daniel Bates  <dabates@apple.com>
379
380         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
381         https://bugs.webkit.org/show_bug.cgi?id=184161
382         <rdar://problem/39051645>
383
384         Reviewed by Dan Bernstein.
385
386         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
387         dropping a PDF embedded using an HTML image element into the same web view.
388
389         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
390         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
391         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
392         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
393         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
394         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
395         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
396         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
397         image document when navigated to directly. Since we can support dragging PDF document images we need to
398         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
399         We need to do both such queries before falling back to using the main resource of the Web Archive as
400         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
401         not an image document.
402
403         * Misc/WebNSPasteboardExtras.mm:
404         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
405
406 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
407
408         Disable content filtering in minimal simulator mode
409         https://bugs.webkit.org/show_bug.cgi?id=185027
410         <rdar://problem/39736091>
411
412         Reviewed by Jer Noble.
413
414         * Configurations/FeatureDefines.xcconfig:
415
416 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
417
418         [INTL] Implement Intl.PluralRules
419         https://bugs.webkit.org/show_bug.cgi?id=184312
420
421         Reviewed by JF Bastien.
422
423         Added Intl.PluralRules feature flag.
424
425         * Configurations/FeatureDefines.xcconfig:
426
427 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
428
429         Remove access to keychain from the WebContent process
430         https://bugs.webkit.org/show_bug.cgi?id=184428
431         <rdar://problem/13150903>
432
433         Reviewed by Brent Fulgham.
434
435         This patch does the followings:
436         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
437         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
438         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
439
440         * WebCoreSupport/WebChromeClient.h:
441         * WebCoreSupport/WebChromeClient.mm:
442         (WebChromeClient::signedPublicKeyAndChallengeString const):
443         * WebView/WebUIDelegatePrivate.h:
444
445 2018-04-24  Jer Noble  <jer.noble@apple.com>
446
447         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
448         https://bugs.webkit.org/show_bug.cgi?id=184786
449
450         Reviewed by Tim Horton.
451
452         * Configurations/WebKitLegacy.xcconfig:
453         * MigrateHeaders.make:
454
455 2018-04-23  Daniel Bates  <dabates@apple.com>
456
457         Implement Same-Site cookies
458         https://bugs.webkit.org/show_bug.cgi?id=159464
459         <rdar://problem/27196358>
460
461         Reviewed by Brent Fulgham.
462
463         Pass the Same-Site info through the strategy.
464
465         * WebCoreSupport/WebPlatformStrategies.h:
466         * WebCoreSupport/WebPlatformStrategies.mm:
467         (WebPlatformStrategies::cookiesForDOM):
468         (WebPlatformStrategies::setCookiesFromDOM):
469         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
470         (WebPlatformStrategies::getRawCookies):
471
472 2018-04-23  Zalan Bujtas  <zalan@apple.com>
473
474         [LayoutFormattingContext] Initial commit.
475         https://bugs.webkit.org/show_bug.cgi?id=184896
476
477         Reviewed by Antti Koivisto.
478
479         * Configurations/FeatureDefines.xcconfig:
480
481 2018-04-23  Daniel Bates  <dabates@apple.com>
482
483         Implement Same-Site cookies
484         https://bugs.webkit.org/show_bug.cgi?id=159464
485         <rdar://problem/27196358>
486
487         Reviewed by Brent Fulgham.
488
489         Pass the Same-Site info through the strategy.
490
491         * WebCoreSupport/WebPlatformStrategies.h:
492         * WebCoreSupport/WebPlatformStrategies.mm:
493         (WebPlatformStrategies::cookiesForDOM):
494         (WebPlatformStrategies::setCookiesFromDOM):
495         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
496         (WebPlatformStrategies::getRawCookies):
497
498 2018-04-20  Timothy Hatcher  <timothy@apple.com>
499
500         NULL dereference crash sometimes under [super initWithCoder:] in WebView
501
502         https://bugs.webkit.org/show_bug.cgi?id=184851
503         rdar://problem/39611236
504
505         Reviewed by Tim Horton.
506
507         * WebView/WebView.mm:
508         (-[WebView _commonInitializationWithFrameName:groupName:]):
509         (-[WebView effectiveAppearanceDidChange]):
510         Added a null check and call the code later in initialization.
511
512 2018-04-20  Tim Horton  <timothy_horton@apple.com>
513
514         Adjust geolocation feature flag
515         https://bugs.webkit.org/show_bug.cgi?id=184856
516
517         Reviewed by Wenson Hsieh.
518
519         * Configurations/FeatureDefines.xcconfig:
520
521 2018-04-18  Jer Noble  <jer.noble@apple.com>
522
523         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
524         https://bugs.webkit.org/show_bug.cgi?id=184762
525
526         Reviewed by Dan Bernstein.
527
528         * Configurations/WebKitLegacy.xcconfig:
529
530 2018-04-20  Youenn Fablet  <youenn@apple.com>
531
532         Make PluginData cache its web visible plugins
533         https://bugs.webkit.org/show_bug.cgi?id=184421
534
535         Reviewed by Chris Dumez.
536
537         * WebCoreSupport/WebPluginInfoProvider.h:
538         * WebCoreSupport/WebPluginInfoProvider.mm:
539         (WebPluginInfoProvider::pluginInfo):
540         (WebPluginInfoProvider::webVisiblePluginInfo):
541
542 2018-04-19  Chris Dumez  <cdumez@apple.com>
543
544         Rename JSDOMWindowProxy to JSWindowProxy
545         https://bugs.webkit.org/show_bug.cgi?id=184797
546
547         Reviewed by Sam Weinig.
548
549         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
550
551         * DOM/DOMUtility.mm:
552         (createDOMWrapper):
553         * WebView/WebFrame.mm:
554         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
555
556 2018-04-19  David Kilzer  <ddkilzer@apple.com>
557
558         Enable Objective-C weak references
559         <https://webkit.org/b/184789>
560         <rdar://problem/39571716>
561
562         Reviewed by Dan Bernstein.
563
564         * Configurations/Base.xcconfig:
565         (CLANG_ENABLE_OBJC_WEAK): Enable.
566
567 2018-04-18  Chris Dumez  <cdumez@apple.com>
568
569         Rename WindowProxyController to WindowProxy
570         https://bugs.webkit.org/show_bug.cgi?id=184756
571
572         Reviewed by Sam Weinig.
573
574         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
575         needed use WindowProxyController type, which was a bit confusing.
576
577         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
578         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
579         * WebView/WebFrame.mm:
580         (-[WebFrame _attachScriptDebugger]):
581
582 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
583
584         Unreviewed rollout of r230632. Regression in memory usage.
585
586         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
587
588         * WebView/WebPreferences.mm:
589         (+[WebPreferences initialize]):
590
591 2018-04-17  Chris Dumez  <cdumez@apple.com>
592
593         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
594         https://bugs.webkit.org/show_bug.cgi?id=184678
595         <rdar://problem/39422122>
596
597         Reviewed by Alex Christensen.
598
599         Add new parameter to dispatchDecidePolicyForNavigationAction.
600
601         * WebCoreSupport/WebFrameLoaderClient.h:
602         * WebCoreSupport/WebFrameLoaderClient.mm:
603         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
604
605 2018-04-13  Chris Dumez  <cdumez@apple.com>
606
607         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
608         https://bugs.webkit.org/show_bug.cgi?id=184591
609
610         Reviewed by Sam Weinig.
611
612         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
613         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
614         This is work towards fixing Bug 184515.
615
616         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
617         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
618         * WebView/WebFrame.mm:
619         (-[WebFrame _attachScriptDebugger]):
620
621 2018-04-12  Antoine Quint  <graouts@apple.com>
622
623         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
624         https://bugs.webkit.org/show_bug.cgi?id=184569
625         <rdar://problem/38671301>
626
627         Reviewed by Jon Lee.
628
629         * WebView/WebPreferences.mm:
630
631 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
632
633         [WTF] Remove StaticLock
634         https://bugs.webkit.org/show_bug.cgi?id=184332
635
636         Reviewed by Mark Lam.
637
638         * DOM/DOMInternal.mm:
639         (getDOMWrapper):
640         (addDOMWrapper):
641         (removeDOMWrapper):
642
643 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
644
645         Failures from mach port reference handling should be fatal
646         https://bugs.webkit.org/show_bug.cgi?id=184202
647         <rdar://problem/37771114>
648
649         Reviewed by Anders Carlsson.
650
651         * Plugins/Hosted/NetscapePluginHostManager.mm:
652         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
653
654 2018-04-03  Andy Estes  <aestes@apple.com>
655
656         [Mac] Prioritize file promises over filenames during drag and drop
657         https://bugs.webkit.org/show_bug.cgi?id=184237
658         <rdar://problem/38278076>
659
660         Reviewed by Wenson Hsieh.
661
662         * WebView/WebView.mm:
663         (-[WebView performDragOperation:]):
664
665 2018-04-03  Chris Dumez  <cdumez@apple.com>
666
667         Drop MainFrame class
668         https://bugs.webkit.org/show_bug.cgi?id=184191
669
670         Reviewed by Darin Adler.
671
672         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
673         relationship between the Page and the MainFrame.
674
675         This is ground work for introducing LocalFrame / RemoteFrame concepts.
676
677         * WebCoreSupport/WebDragClient.mm:
678         * WebCoreSupport/WebFrameLoaderClient.mm:
679         * WebCoreSupport/WebInspectorClient.mm:
680         * WebCoreSupport/WebPlatformStrategies.mm:
681         * WebCoreSupport/WebPluginInfoProvider.mm:
682         * WebView/WebFrame.mm:
683         * WebView/WebFrameView.mm:
684         * WebView/WebHTMLView.mm:
685         * WebView/WebView.mm:
686
687 2018-04-02  Jer Noble  <jer.noble@apple.com>
688
689         Enable Legacy EME for all WebKit & WebKitLegacy clients
690         https://bugs.webkit.org/show_bug.cgi?id=184018
691         <rdar://problem/34887387>
692
693         Reviewed by Eric Carlson.
694
695         * WebView/WebPreferences.mm:
696         (+[WebPreferences initialize]):
697
698 2018-03-29  JF Bastien  <jfbastien@apple.com>
699
700         Use Forward.h instead of forward-declaring WTF::String
701         https://bugs.webkit.org/show_bug.cgi?id=184172
702         <rdar://problem/39026146>
703
704         Reviewed by Yusuke Suzuki.
705
706         As part of #184164 I'm changing WTF::String, and the forward
707         declarations are just wrong because I'm making it templated. We
708         should use Forward.h anyways, so do that instead.
709
710         * WebView/WebScriptDebugger.h:
711
712 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
713
714         Protect against invalid mach ports returned by mach_port_request_notification
715         https://bugs.webkit.org/show_bug.cgi?id=184106
716         <rdar://problem/37865316>
717
718         Reviewed by Chris Dumez.
719
720         * Plugins/Hosted/NetscapePluginHostProxy.mm:
721         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
722         and clean up if it experienced an error.
723         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
724
725 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
726
727         Avoid uninitialized mach ports
728         https://bugs.webkit.org/show_bug.cgi?id=184090
729         <rdar://problem/37261129>
730
731         Reviewed by Chris Dumez.
732
733         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
734         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
735         there is a potential for us to try to use invalid ports.
736
737         We should always check return values, and ensure that the mach port variables we seek to initialize are
738         kept in a valid state.
739
740         Reviewed by Chris Dumez.
741
742         * Plugins/Hosted/NetscapePluginHostManager.h:
743         * Plugins/Hosted/NetscapePluginHostManager.mm:
744         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
745         port is passed to an API function.
746         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
747         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
748         * Plugins/Hosted/NetscapePluginHostProxy.h:
749         * Plugins/Hosted/NetscapePluginHostProxy.mm:
750         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
751         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
752         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
753         (WKPCStatusText): Ditto.
754         (WKPCLoadURL): Ditto.
755         (WKPCCancelLoadURL): Ditto.
756         (WKPCInvalidateRect): Ditto.
757         (WKPCGetScriptableNPObjectReply): Ditto.
758         (WKPCBooleanReply): Ditto.
759         (WKPCBooleanAndDataReply): Ditto.
760         (WKPCInstantiatePluginReply): Ditto.
761         (WKPCGetWindowNPObject): Ditto.
762         (WKPCGetPluginElementNPObject): Ditto.
763         (WKPCForgetBrowserObject): Ditto.
764         (WKPCEvaluate): Ditto.
765         (WKPCGetStringIdentifier): Ditto.
766         (WKPCGetIntIdentifier): Ditto.
767         (WKPCInvoke): Ditto.
768         (WKPCInvokeDefault): Ditto.
769         (WKPCConstruct): Ditto.
770         (WKPCGetProperty): Ditto.
771         (WKPCSetProperty): Ditto.
772         (WKPCRemoveProperty): Ditto.
773         (WKPCHasProperty): Ditto.
774         (WKPCHasMethod): Ditto.
775         (WKPCIdentifierInfo): Ditto.
776         (WKPCEnumerate): Ditto.
777         (WKPCSetMenuBarVisible): Ditto.
778         (WKPCSetFullscreenWindowIsShowing): Ditto.
779         (WKPCSetModal): Ditto.
780         (WKPCGetCookies): Ditto.
781         (WKPCGetProxy): Ditto.
782         (WKPCSetCookies): Ditto.
783         (WKPCGetAuthenticationInfo): Ditto.
784         (WKPCConvertPoint): Ditto.
785         (WKPCLayerHostingModeChanged): Ditto.
786         (WKPCSetException): Ditto.
787
788 2018-03-26  Tim Horton  <timothy_horton@apple.com>
789
790         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
791         https://bugs.webkit.org/show_bug.cgi?id=184030
792         <rdar://problem/38895281>
793
794         Reviewed by Dan Bernstein.
795
796         * Configurations/Base.xcconfig:
797
798 2018-03-26  Chris Dumez  <cdumez@apple.com>
799
800         Use SecurityOriginData more consistently in Service Worker code
801         https://bugs.webkit.org/show_bug.cgi?id=183969
802
803         Reviewed by Darin Adler.
804
805         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
806
807         * Storage/WebDatabaseManager.mm:
808         (-[WebDatabaseManager databasesWithOrigin:]):
809         (-[WebDatabaseManager deleteOrigin:]):
810         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
811         * Storage/WebDatabaseQuotaManager.mm:
812         (-[WebDatabaseQuotaManager usage]):
813         (-[WebDatabaseQuotaManager quota]):
814         (-[WebDatabaseQuotaManager setQuota:]):
815         * Storage/WebStorageManager.mm:
816         (-[WebStorageManager deleteOrigin:]):
817         * WebCoreSupport/WebSecurityOrigin.mm:
818         (-[WebSecurityOrigin databaseIdentifier]):
819         (-[WebSecurityOrigin usage]):
820         (-[WebSecurityOrigin quota]):
821         (-[WebSecurityOrigin setQuota:]):
822
823 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
824
825         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
826         https://bugs.webkit.org/show_bug.cgi?id=183911
827         <rdar://problem/38762306>
828
829         Reviewed by Youenn Fablet.
830
831         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
832
833         * WebView/WebView.mm:
834         (+[WebView initialize]):
835
836 2018-03-26  Alex Christensen  <achristensen@webkit.org>
837
838         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
839         https://bugs.webkit.org/show_bug.cgi?id=183965
840
841         Reviewed by Chris Dumez.
842
843         * WebCoreSupport/WebFrameLoaderClient.h:
844         * WebCoreSupport/WebFrameLoaderClient.mm:
845         (WebFrameLoaderClient::willCacheResponse const):
846
847 2018-03-25  Commit Queue  <commit-queue@webkit.org>
848
849         Unreviewed, rolling out r229954.
850         https://bugs.webkit.org/show_bug.cgi?id=184000
851
852         Caused many layout tests to crash on Apple High Sierra,
853         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
854         by dydz on #webkit).
855
856         Reverted changeset:
857
858         "Use SecurityOriginData more consistently in Service Worker
859         code"
860         https://bugs.webkit.org/show_bug.cgi?id=183969
861         https://trac.webkit.org/changeset/229954
862
863 2018-03-24  Chris Dumez  <cdumez@apple.com>
864
865         Use SecurityOriginData more consistently in Service Worker code
866         https://bugs.webkit.org/show_bug.cgi?id=183969
867
868         Reviewed by Darin Adler.
869
870         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
871
872         * Storage/WebDatabaseManager.mm:
873         (-[WebDatabaseManager databasesWithOrigin:]):
874         (-[WebDatabaseManager deleteOrigin:]):
875         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
876         * Storage/WebDatabaseQuotaManager.mm:
877         (-[WebDatabaseQuotaManager usage]):
878         (-[WebDatabaseQuotaManager quota]):
879         (-[WebDatabaseQuotaManager setQuota:]):
880         * Storage/WebStorageManager.mm:
881         (-[WebStorageManager deleteOrigin:]):
882         * WebCoreSupport/WebSecurityOrigin.mm:
883         (-[WebSecurityOrigin databaseIdentifier]):
884         (-[WebSecurityOrigin usage]):
885         (-[WebSecurityOrigin quota]):
886         (-[WebSecurityOrigin setQuota:]):
887
888 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
889
890         Fix the build
891
892         * WebView/WebView.mm:
893
894 2018-03-23  Tim Horton  <timothy_horton@apple.com>
895
896         Fix the build with no pasteboard
897         https://bugs.webkit.org/show_bug.cgi?id=183973
898
899         Reviewed by Dan Bernstein.
900
901         * Configurations/FeatureDefines.xcconfig:
902         * WebView/WebView.mm:
903         (-[WebView _requestStartDataInteraction:globalPosition:]):
904         (-[WebView _getDataInteractionData]):
905         (-[WebView _dataOperationTextIndicator]):
906         (-[WebView _dragSourceAction]):
907         (-[WebView _draggedLinkTitle]):
908         (-[WebView _draggedLinkURL]):
909         (-[WebView _draggedElementBounds]):
910         (-[WebView _enteredDataInteraction:client:global:operation:]):
911         (-[WebView _updatedDataInteraction:client:global:operation:]):
912         (-[WebView _exitedDataInteraction:client:global:operation:]):
913         (-[WebView _performDataInteraction:client:global:operation:]):
914         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
915         (-[WebView _endedDataInteraction:global:]):
916         (-[WebView _dataInteractionCaretRect]):
917         * WebView/WebViewPrivate.h:
918
919 2018-03-23  Tim Horton  <timothy_horton@apple.com>
920
921         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
922         https://bugs.webkit.org/show_bug.cgi?id=183960
923         <rdar://problem/38812356>
924
925         Reviewed by Dan Bernstein.
926
927         * Configurations/WebKitLegacy.xcconfig:
928
929 2018-03-23  Tim Horton  <timothy_horton@apple.com>
930
931         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
932         https://bugs.webkit.org/show_bug.cgi?id=183954
933         <rdar://problem/38808858>
934
935         Reviewed by Dan Bernstein.
936
937         * WebView/WebPreferences.mm:
938         (-[WebPreferences setAudioSessionCategoryOverride:]):
939
940 2018-03-23  Tim Horton  <timothy_horton@apple.com>
941
942         Adopt WK_PLATFORM_NAME in WebKitLegacy
943         https://bugs.webkit.org/show_bug.cgi?id=183948
944         <rdar://problem/38803908>
945
946         Reviewed by Dan Bernstein.
947
948         * Configurations/WebKitLegacy.xcconfig:
949         * MigrateHeaders.make:
950         * postprocess-headers.sh:
951
952 2018-03-23  Brady Eidson  <beidson@apple.com>
953
954         Go to back/forward list items after a process-swapped navigation.
955         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
956
957         Reviewed by Andy Estes.
958
959         * WebView/WebView.mm:
960         (-[WebView _loadBackForwardListFromOtherView:]):
961         (-[WebView goToBackForwardItem:]):
962
963 2018-03-22  Tim Horton  <timothy_horton@apple.com>
964
965         Improve readability of WebCore's OTHER_LDFLAGS
966         https://bugs.webkit.org/show_bug.cgi?id=183909
967         <rdar://problem/38760992>
968
969         Reviewed by Dan Bernstein.
970
971         * Configurations/Base.xcconfig:
972         * Configurations/FeatureDefines.xcconfig:
973
974 2018-03-20  Tim Horton  <timothy_horton@apple.com>
975
976         Enable the minimal simulator feature flag when appropriate
977         https://bugs.webkit.org/show_bug.cgi?id=183807
978
979         Reviewed by Dan Bernstein.
980
981         * Configurations/FeatureDefines.xcconfig:
982
983 2018-03-20  Tim Horton  <timothy_horton@apple.com>
984
985         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
986         https://bugs.webkit.org/show_bug.cgi?id=183758
987         <rdar://problem/38017644>
988
989         Reviewed by Dan Bernstein.
990
991         * Configurations/FeatureDefines.xcconfig:
992
993 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
994
995         Clear style colors when setting default appearance
996         https://bugs.webkit.org/show_bug.cgi?id=183759
997
998         Reviewed by Tim Horton.
999
1000         Colors are cached and need to be cleared and recalculated.
1001         Refactor to do all style recalcs together.
1002
1003         * WebView/WebView.mm:
1004         (-[WebView _setDefaultAppearanceAndClearStyle]):
1005         (-[WebView _setUseSystemAppearance:]):
1006         (-[WebView effectiveAppearanceDidChange]):
1007
1008 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1009
1010         Unreviewed, another quick fix for r229699
1011
1012         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
1013
1014         * Configurations/FeatureDefines.xcconfig:
1015
1016 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
1017
1018         Ensure that style is updated when the effective appearance changes
1019         https://bugs.webkit.org/show_bug.cgi?id=183690
1020         <rdar://problem/38385900>
1021
1022         Reviewed by Tim Horton and Wenson Hsieh.
1023
1024         Respond to and respect the effective appearance changing.
1025
1026         * WebView/WebView.mm:
1027         (-[WebView _setUseSystemAppearance:]):
1028         (-[WebView effectiveAppearanceDidChange]):
1029
1030 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
1031
1032         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
1033         https://bugs.webkit.org/show_bug.cgi?id=183677
1034
1035         Reviewed by Tim Horton.
1036
1037         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
1038
1039         * DOM/DOM.mm:
1040         (-[DOMHTMLLinkElement _mediaQueryMatches]):
1041
1042 2018-03-14  Tim Horton  <timothy_horton@apple.com>
1043
1044         Fix the build after r229567
1045
1046         * Configurations/FeatureDefines.xcconfig:
1047
1048 2018-03-12  Tim Horton  <timothy_horton@apple.com>
1049
1050         Stop using SDK conditionals to control feature definitions
1051         https://bugs.webkit.org/show_bug.cgi?id=183430
1052         <rdar://problem/38251619>
1053
1054         Reviewed by Dan Bernstein.
1055
1056         * Configurations/FeatureDefines.xcconfig:
1057         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
1058
1059 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
1060
1061         Runtime flag for link prefetch and remove link subresource.
1062         https://bugs.webkit.org/show_bug.cgi?id=183540
1063
1064         Reviewed by Chris Dumez.
1065
1066         Remove the LINK_PREFETCH build time flag.
1067
1068         * Configurations/FeatureDefines.xcconfig:
1069
1070 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
1071
1072         Remove GridLayout runtime flag
1073         https://bugs.webkit.org/show_bug.cgi?id=183484
1074
1075         Reviewed by Myles C. Maxfield.
1076
1077         The Grid Layout feature has been enabled by default for almost a
1078         year, so I think it's time to remove the runtime flag and the
1079
1080         * WebView/WebPreferenceKeysPrivate.h:
1081         * WebView/WebPreferences.mm:
1082         (+[WebPreferences initialize]):
1083         * WebView/WebPreferencesPrivate.h:
1084         * WebView/WebView.mm:
1085         (-[WebView _preferencesChanged:]):
1086
1087 2018-03-12  Antoine Quint  <graouts@apple.com>
1088
1089         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1090         https://bugs.webkit.org/show_bug.cgi?id=183504
1091         <rdar://problem/38372965>
1092
1093         Reviewed by Dean Jackson and Jon Lee.
1094
1095         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1096         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1097
1098         * WebView/WebPreferenceKeysPrivate.h:
1099         * WebView/WebPreferences.mm:
1100         (+[WebPreferences initialize]):
1101         (-[WebPreferences setModernMediaControlsEnabled:]):
1102         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
1103         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
1104         * WebView/WebPreferencesPrivate.h:
1105         * WebView/WebView.mm:
1106         (-[WebView _preferencesChanged:]):
1107
1108 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
1109
1110         Media query for default appearance
1111         https://bugs.webkit.org/show_bug.cgi?id=183539
1112         <rdar://problem/38326388>
1113
1114         Reviewed by Tim Horton.
1115
1116         Write a media query to evaluate appearance.
1117
1118         * WebView/WebView.mm:
1119         (-[WebView _commonInitializationWithFrameName:groupName:]):
1120         (-[WebView _setUseSystemAppearance:]):
1121
1122 2018-03-09  Andy Estes  <aestes@apple.com>
1123
1124         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
1125         https://bugs.webkit.org/show_bug.cgi?id=183489
1126         <rdar://problem/38267517>
1127
1128         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
1129         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
1130         to issue a sandbox extension for this directory, but for security reasons App Sandbox
1131         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
1132         block with a nil error and a valid file URL, but no file will actually exist at that URL.
1133
1134         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
1135         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
1136         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
1137         drop destination.
1138
1139         Reviewed by Wenson Hsieh.
1140
1141         * WebView/WebView.mm:
1142         (-[WebView performDragOperation:]):
1143
1144 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
1145
1146         Allow WebViews to disable system appearance
1147         https://bugs.webkit.org/show_bug.cgi?id=183418
1148         <rdar://problem/36975642>
1149
1150         Reviewed by Tim Horton.
1151
1152         Allow webviews to choose whether or not to follow the default system appearance.
1153
1154         * WebView/WebView.mm:
1155         (-[WebView _setUseSystemAppearance:]):
1156         (-[WebView _useSystemAppearance]):
1157         * WebView/WebViewPrivate.h:
1158
1159 2018-03-08  Youenn Fablet  <youenn@apple.com>
1160
1161         libwebrtc update broke internal builds
1162         https://bugs.webkit.org/show_bug.cgi?id=183454
1163
1164         Reviewed by Eric Carlson.
1165
1166         * Configurations/WebKitLegacy.xcconfig:
1167
1168 2018-03-08  Chris Dumez  <cdumez@apple.com>
1169
1170         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
1171         https://bugs.webkit.org/show_bug.cgi?id=183455
1172         <rdar://problem/38191749>
1173
1174         Reviewed by Youenn Fablet.
1175
1176         Add a null check for the page as we have evidence from crashes that it can be null.
1177         Other functions in WebFrameNetworkingContext already null check the page as well,
1178         not just the frame so this is consistent.
1179
1180         * WebCoreSupport/WebFrameNetworkingContext.mm:
1181         (WebFrameNetworkingContext::storageSession const):
1182
1183 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1184
1185         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1186         https://bugs.webkit.org/show_bug.cgi?id=183429
1187
1188         Reviewed by Mark Lam.
1189
1190         * DOM/DOM.mm:
1191         (+[DOMNode _nodeFromJSWrapper:]):
1192         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1193         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1194         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1195         * Plugins/Hosted/ProxyInstance.mm:
1196         (WebKit::ProxyInstance::invokeMethod):
1197         * WebView/WebView.mm:
1198         (aeDescFromJSValue):
1199
1200 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1201
1202         Stop linking ApplicationServices directly
1203         https://bugs.webkit.org/show_bug.cgi?id=182867
1204         <rdar://problem/38252142>
1205
1206         Reviewed by Alex Christensen.
1207
1208         The frameworks that we use that live inside ApplicationServices
1209         have mostly moved out, so import them directly.
1210
1211         * Carbon/CarbonUtils.h:
1212         * WebKitPrefix.h:
1213         * WebView/WebHTMLView.mm:
1214         * WebView/WebPDFView.mm:
1215
1216 2018-03-07  Tim Horton  <timothy_horton@apple.com>
1217
1218         Sort and separate FeatureDefines.xcconfig
1219         https://bugs.webkit.org/show_bug.cgi?id=183427
1220
1221         Reviewed by Dan Bernstein.
1222
1223         * Configurations/FeatureDefines.xcconfig:
1224         Sort and split FeatureDefines into paragraphs
1225         (to make it easier to sort later).
1226
1227 2018-03-07  Youenn Fablet  <youenn@apple.com>
1228
1229         Match unsupported plugins based on domains and not origin
1230         https://bugs.webkit.org/show_bug.cgi?id=183384
1231
1232         Reviewed by Chris Dumez.
1233
1234         * WebCoreSupport/WebPluginInfoProvider.h:
1235         * WebCoreSupport/WebPluginInfoProvider.mm:
1236         (WebPluginInfoProvider::getPluginInfo):
1237         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1238
1239 2018-03-05  Andy Estes  <aestes@apple.com>
1240
1241         [Mac] Teach WebCore::Pasteboard about file promise drags
1242         https://bugs.webkit.org/show_bug.cgi?id=183314
1243         <rdar://problem/38105493>
1244
1245         Reviewed by Darin Adler.
1246
1247         Added a FIXME comment.
1248
1249         * WebView/WebView.mm:
1250         (-[WebView performDragOperation:]):
1251
1252 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1253
1254         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1255         https://bugs.webkit.org/show_bug.cgi?id=183312
1256
1257         Reviewed by Mark Lam.
1258
1259         Remove wtf/CurrentTime.h include pragma.
1260
1261         * WebView/WebFrame.mm:
1262         * WebView/WebPDFView.mm:
1263
1264 2018-03-04  Tim Horton  <timothy_horton@apple.com>
1265
1266         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
1267         https://bugs.webkit.org/show_bug.cgi?id=183283
1268         <rdar://problem/38062148>
1269
1270         Reviewed by Sam Weinig.
1271
1272         * Configurations/FeatureDefines.xcconfig:
1273
1274 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1275
1276         Reduce use of NetworkingContext in WebKit
1277         https://bugs.webkit.org/show_bug.cgi?id=183213
1278
1279         Reviewed by Brady Eidson.
1280
1281         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1282         (WebKit::NetscapePluginInstanceProxy::getProxy):
1283         * Plugins/WebNetscapePluginView.mm:
1284         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1285
1286 2018-02-17  Darin Adler  <darin@apple.com>
1287
1288         Prepare for ExtendedColor changes (first step)
1289         https://bugs.webkit.org/show_bug.cgi?id=182904
1290
1291         Reviewed by Sam Weinig.
1292
1293         * Misc/WebKitNSStringExtras.mm:
1294         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
1295
1296 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1297
1298         Remove currentTime() / currentTimeMS()
1299         https://bugs.webkit.org/show_bug.cgi?id=183052
1300
1301         Reviewed by Mark Lam.
1302
1303         * WebCoreSupport/WebFrameLoaderClient.h:
1304         * WebCoreSupport/WebFrameLoaderClient.mm:
1305         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1306
1307 2018-02-16  Youenn Fablet  <youenn@apple.com>
1308
1309         Allow specifying which plug-ins are supported
1310         https://bugs.webkit.org/show_bug.cgi?id=182748
1311
1312         Reviewed by Chris Dumez.
1313
1314         * WebCoreSupport/WebPluginInfoProvider.h:
1315         * WebCoreSupport/WebPluginInfoProvider.mm:
1316         (WebPluginInfoProvider::getPluginInfo):
1317         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1318
1319 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
1320
1321         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
1322         https://bugs.webkit.org/show_bug.cgi?id=182882
1323         <rdar://problem/35672661>
1324
1325         Reviewed by Dan Bernstein.
1326
1327         Make sure the smart pointer hold the collection of subviews lives at least as
1328         long as the loop using it.
1329
1330         * WebView/WebHTMLView.mm:
1331         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
1332
1333 2018-02-14  Daniel Bates  <dabates@apple.com>
1334
1335         Disallow cross-origin subresources from asking for credentials
1336         https://bugs.webkit.org/show_bug.cgi?id=182579
1337         <rdar://problem/36162271>
1338
1339         Reviewed by Andy Estes.
1340
1341         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
1342         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
1343
1344         * WebView/WebPreferenceKeysPrivate.h:
1345         * WebView/WebPreferences.mm:
1346         (+[WebPreferences initialize]):
1347         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
1348         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
1349         * WebView/WebPreferencesPrivate.h:
1350         * WebView/WebView.mm:
1351         (-[WebView _preferencesChanged:]):
1352
1353 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1354
1355         Remove ForwardingHeaders directory from WebKitLegacy/mac.
1356         https://bugs.webkit.org/show_bug.cgi?id=182738
1357
1358         Reviewed by Darin Adler.
1359
1360         * ForwardingHeaders/collector/handles/Global.h: Removed.
1361         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
1362         * ForwardingHeaders/runtime/Completion.h: Removed.
1363         * ForwardingHeaders/runtime/Error.h: Removed.
1364         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
1365         * ForwardingHeaders/runtime/JSFunction.h: Removed.
1366         * ForwardingHeaders/runtime/JSLock.h: Removed.
1367         * ForwardingHeaders/runtime/JSObject.h: Removed.
1368         * ForwardingHeaders/runtime/JSString.h: Removed.
1369         * ForwardingHeaders/runtime/Protect.h: Removed.
1370         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
1371
1372 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1373
1374         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
1375         https://bugs.webkit.org/show_bug.cgi?id=182641
1376
1377         Reviewed by Dan Bernstein.
1378
1379         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1380         https://trac.webkit.org/changeset/228308.
1381
1382         * WebView/WebVideoFullscreenController.h:
1383         * WebView/WebVideoFullscreenHUDWindowController.mm:
1384         * WebView/WebWindowAnimation.h:
1385         * WebView/WebWindowAnimation.mm:
1386         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1387         (WebCore::scaledRect): Deleted.
1388         (WebCore::squaredDistance): Deleted.
1389
1390 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1391
1392         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1393
1394         * WebView/WebWindowAnimation.mm:
1395         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1396
1397 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1398
1399         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1400         https://bugs.webkit.org/show_bug.cgi?id=182615
1401
1402         Reviewed by Eric Carlson.
1403
1404         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1405         Ideally, we should not reference NSApp in WebCore.
1406
1407         * WebView/WebFullScreenController.mm:
1408         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1409         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1410         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1411         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1412         * WebView/WebView.mm:
1413         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1414         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1415
1416 2018-01-13  Darin Adler  <darin@apple.com>
1417
1418         Event improvements
1419         https://bugs.webkit.org/show_bug.cgi?id=179591
1420
1421         Reviewed by Chris Dumez.
1422
1423         * DOM/DOMWheelEvent.mm:
1424         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1425         Call initWebKitWheelEvent.
1426
1427         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1428         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1429         * WebView/WebFrame.mm: Ditto.
1430
1431         * WebView/WebHTMLView.mm:
1432         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1433         underlyingPlatformEvent.
1434         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1435
1436         * WebView/WebScriptWorld.mm:
1437         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1438
1439         * WebView/WebView.mm: Removed include of ScriptValue.h.
1440
1441 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1442
1443         Remove WebCore/ForwardingHeaders directory
1444         https://bugs.webkit.org/show_bug.cgi?id=182347
1445
1446         Reviewed by Keith Miller.
1447
1448         * Carbon/CarbonWindowAdapter.mm:
1449         * DOM/WebDOMOperations.mm:
1450         * History/WebBackForwardList.mm:
1451         * History/WebHistoryItem.mm:
1452         * Misc/WebCache.mm:
1453         * Misc/WebElementDictionary.mm:
1454         * Misc/WebIconDatabase.mm:
1455         * Misc/WebStringTruncator.mm:
1456         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1457         * Plugins/Hosted/ProxyInstance.mm:
1458         * Plugins/Hosted/ProxyRuntimeObject.mm:
1459         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1460         * Plugins/WebBaseNetscapePluginView.mm:
1461         * Plugins/WebBasePluginPackage.mm:
1462         * Plugins/WebNetscapePluginStream.mm:
1463         * Plugins/WebNetscapePluginView.mm:
1464         * Plugins/WebPluginController.mm:
1465         * WebCoreSupport/WebEditorClient.mm:
1466         * WebCoreSupport/WebFrameLoaderClient.mm:
1467         * WebCoreSupport/WebInspectorClient.h:
1468         * WebCoreSupport/WebInspectorClient.mm:
1469         * WebView/WebDataSource.mm:
1470         * WebView/WebFrame.mm:
1471         * WebView/WebHTMLRepresentation.mm:
1472         * WebView/WebHTMLView.mm:
1473         * WebView/WebPreferences.mm:
1474         * WebView/WebScriptDebugDelegate.mm:
1475         * WebView/WebScriptDebugger.h:
1476         * WebView/WebTextIterator.mm:
1477         * WebView/WebView.mm:
1478         * WebView/WebViewData.mm:
1479
1480 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1481
1482         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1483         https://bugs.webkit.org/show_bug.cgi?id=182312
1484
1485         Reviewed by Michael Catanzaro.
1486
1487         * WebKitPrefix.h:
1488
1489 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1490
1491         [WebAuthN] Add a compile-time feature flag
1492         https://bugs.webkit.org/show_bug.cgi?id=182211
1493         <rdar://problem/36936365>
1494
1495         Reviewed by Brent Fulgham.
1496
1497         * Configurations/FeatureDefines.xcconfig:
1498
1499 2018-01-27  Dan Bernstein  <mitz@apple.com>
1500
1501         HaveInternalSDK includes should be "#include?"
1502         https://bugs.webkit.org/show_bug.cgi?id=179670
1503
1504         * Configurations/Base.xcconfig:
1505
1506 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1507
1508         Remove unused QTKit preference
1509         https://bugs.webkit.org/show_bug.cgi?id=181968
1510
1511         Reviewed by Alexey Proskuryakov.
1512
1513         * WebView/WebPreferenceKeysPrivate.h:
1514         * WebView/WebPreferences.mm:
1515         (+[WebPreferences initialize]):
1516         (-[WebPreferences setQTKitEnabled:]): Deleted.
1517         (-[WebPreferences isQTKitEnabled]): Deleted.
1518         * WebView/WebPreferencesPrivate.h:
1519         * WebView/WebView.mm:
1520         (-[WebView _preferencesChanged:]):
1521
1522 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1523
1524         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1525         https://bugs.webkit.org/show_bug.cgi?id=182037
1526         <rdar://problem/36747812>
1527
1528         Reviewed by Ryosuke Niwa.
1529
1530         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1531         for more details.
1532
1533         * WebView/WebHTMLRepresentation.mm:
1534         (-[WebHTMLRepresentation elementWithName:inForm:]):
1535         (-[WebHTMLRepresentation controlsInForm:]):
1536
1537 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1538
1539         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1540         https://bugs.webkit.org/show_bug.cgi?id=181961
1541
1542         Reviewed by Michael Catanzaro.
1543
1544         * WebView/WebPreferences.mm:
1545
1546 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1547
1548         Unreviewed, rolling out r227437.
1549         https://bugs.webkit.org/show_bug.cgi?id=182011
1550
1551         broke build (Requested by alexchristensen on #webkit).
1552
1553         Reverted changeset:
1554
1555         "Remove unused QTKit preference"
1556         https://bugs.webkit.org/show_bug.cgi?id=181968
1557         https://trac.webkit.org/changeset/227437
1558
1559 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1560
1561         Remove unused QTKit preference
1562         https://bugs.webkit.org/show_bug.cgi?id=181968
1563
1564         Reviewed by Alexey Proskuryakov.
1565
1566         * WebView/WebPreferenceKeysPrivate.h:
1567         * WebView/WebPreferences.mm:
1568         (+[WebPreferences initialize]):
1569         (-[WebPreferences setQTKitEnabled:]): Deleted.
1570         (-[WebPreferences isQTKitEnabled]): Deleted.
1571         * WebView/WebPreferencesPrivate.h:
1572         * WebView/WebView.mm:
1573         (-[WebView _preferencesChanged:]):
1574
1575 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1576
1577         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1578         https://bugs.webkit.org/show_bug.cgi?id=181960
1579         <rdar://problem/36431678>
1580
1581         Reviewed by Tim Horton.
1582
1583         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1584         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1585         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1586
1587         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1588         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1589         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1590
1591         * WebView/WebView.mm:
1592         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1593
1594 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1595
1596         Turning off custom pasteboard data doesn't actually turn it off in WK2
1597         https://bugs.webkit.org/show_bug.cgi?id=181920
1598         <rdar://problem/36686429>
1599
1600         Reviewed by Wenson Hsieh.
1601
1602         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1603
1604         * WebView/WebPreferences.mm:
1605         (+[WebPreferences initialize]):
1606         * WebView/WebView.mm:
1607         (-[WebView _preferencesChanged:]):
1608
1609 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1610
1611         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1612         https://bugs.webkit.org/show_bug.cgi?id=181918
1613
1614         Reviewed by Tim Horton.
1615
1616         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1617
1618         * Configurations/FeatureDefines.xcconfig:
1619
1620 2018-01-20  Andy Estes  <aestes@apple.com>
1621
1622         [Apple Pay] Stop eagerly loading PassKit.framework
1623         https://bugs.webkit.org/show_bug.cgi?id=181911
1624         <rdar://problem/36555369>
1625
1626         Reviewed by Tim Horton.
1627
1628         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1629         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1630         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1631
1632         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1633
1634 2018-01-19  Dean Jackson  <dino@apple.com>
1635
1636         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1637         https://bugs.webkit.org/show_bug.cgi?id=181817
1638         <rdar://problem/35274055>
1639
1640         Reviewed by Simon Fraser.
1641
1642         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1643
1644         * Misc/WebKitVersionChecks.h:
1645         * WebView/WebView.mm:
1646         (-[WebView _commonInitializationWithFrameName:groupName:]):
1647
1648 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1649
1650         Remove unused WebViewPrivate _allowCookies
1651         https://bugs.webkit.org/show_bug.cgi?id=181812
1652
1653         Reviewed by Tim Horton.
1654
1655         * WebView/WebView.mm:
1656         (+[WebView _setAllowCookies:]): Deleted.
1657         (+[WebView _allowCookies]): Deleted.
1658         * WebView/WebViewPrivate.h:
1659
1660 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1661
1662         Build fix, remove a call to -[NSWindow setOneShot:]
1663         https://bugs.webkit.org/show_bug.cgi?id=181809
1664
1665         Reviewed by Tim Horton.
1666
1667         * WebView/WebTextCompletionController.mm:
1668         (-[WebTextCompletionController _buildUI]):
1669
1670 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1671
1672         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1673
1674         * Carbon/HIWebView.mm:
1675         (overrideCGContext):
1676         (restoreCGContext):
1677
1678 2018-01-18  Dan Bernstein  <mitz@apple.com>
1679
1680         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1681         https://bugs.webkit.org/show_bug.cgi?id=181803
1682
1683         Reviewed by Tim Horton.
1684
1685         * Configurations/Base.xcconfig: Updated.
1686         * Configurations/DebugRelease.xcconfig: Ditto.
1687         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1688         * Configurations/Version.xcconfig: Updated.
1689         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1690           useful for defining settings that depend on the target macOS version.
1691
1692 2018-01-17  Youenn Fablet  <youenn@apple.com>
1693
1694         Put fetch Request.keepalive behind a runtime flag
1695         https://bugs.webkit.org/show_bug.cgi?id=181592
1696
1697         Reviewed by Chris Dumez.
1698
1699         * WebView/WebPreferenceKeysPrivate.h:
1700         * WebView/WebPreferences.mm:
1701         (+[WebPreferences initialize]):
1702         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1703         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1704         * WebView/WebPreferencesPrivate.h:
1705         * WebView/WebView.mm:
1706         (-[WebView _preferencesChanged:]):
1707
1708 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1709
1710         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1711         https://bugs.webkit.org/show_bug.cgi?id=181637
1712         <rdar://problem/36508471>
1713
1714         Reviewed by Tim Horton.
1715
1716         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1717
1718         * WebCoreSupport/WebEditorClient.h:
1719         * WebCoreSupport/WebEditorClient.mm:
1720         (WebEditorClient::replacementURLForResource):
1721
1722 2018-01-11  Keith Miller  <keith_miller@apple.com>
1723
1724         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1725         https://bugs.webkit.org/show_bug.cgi?id=181573
1726
1727         Reviewed by Simon Fraser.
1728
1729         * Configurations/FeatureDefines.xcconfig:
1730
1731 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1732
1733         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1734         https://bugs.webkit.org/show_bug.cgi?id=181497
1735
1736         Reviewed by Tim Horton.
1737
1738         See other ChangeLogs for more detail.
1739
1740         * WebCoreSupport/WebDragClient.h:
1741
1742 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1743
1744         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1745         https://bugs.webkit.org/show_bug.cgi?id=181523
1746         <rdar://problem/28959131>
1747
1748         Reviewed by Alex Christensen.
1749
1750         * WebView/WebImmediateActionController.mm:
1751         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1752         Apply the change made in r216652 to WebKit1's immediate action controller.
1753
1754         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1755         the startContainer of the range is in an anonymous node.
1756
1757 2018-01-11  Youenn Fablet  <youenn@apple.com>
1758
1759         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1760         https://bugs.webkit.org/show_bug.cgi?id=181480
1761
1762         Reviewed by Eric Carlson.
1763
1764         * WebView/WebPreferences.mm:
1765         (+[WebPreferences initialize]):
1766
1767 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1768
1769         Fix check-webkit-style issues with WebNSDataExtras.mm
1770         <https://webkit.org/b/181369>
1771
1772         Reviewed by Alex Christensen.
1773
1774         * Misc/WebNSDataExtras.mm:
1775         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1776         (-[NSData _webkit_guessedMIMETypeForXML]):
1777         (-[NSData _webkit_guessedMIMEType]):
1778         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1779         (_findEOL):
1780         (-[NSData _webkit_parseRFC822HeaderFields]):
1781         (-[NSData _web_locationAfterFirstBlankLine]):
1782         - Fix all the check-webkit-style warnings.
1783
1784 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1785
1786         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1787         <https://webkit.org/b/181256>
1788         <rdar://problem/36281730>
1789
1790         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1791         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1792         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1793           to avoid warnings from casting CFStringRef to NPNSString*.
1794           Note that CFMutableStringRef is the same as CFStringRef
1795           without the const modifier, hence its use in the const_cast<>
1796           above.
1797
1798 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1799
1800         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1801         <https://webkit.org/b/181256>
1802         <rdar://problem/36281730>
1803
1804         * Carbon/HIWebView.mm:
1805         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1806         checked_cf_cast<CFRunLoopRef>() to fix warning.
1807
1808 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1809
1810         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1811         <https://webkit.org/b/181256>
1812         <rdar://problem/36281730>
1813
1814         Reviewed by Darin Adler.
1815
1816         * Carbon/CarbonUtils.m:
1817         (PoolCleaner):
1818         - Use #pragmas to ignore -Wcast-qual warnings when using a
1819           C-style cast from CFTypeRef to CFRunloopRef.
1820         * Carbon/CarbonWindowFrame.m:
1821         (-[CarbonWindowFrame title]):
1822         - Use #pragmas to ignore -Wcast-qual warnings when using a
1823           C-style cast from CFStringRef to NSString *.
1824         * Carbon/HIViewAdapter.m:
1825         (+[HIViewAdapter getHIViewForNSView:]):
1826         - Use #pragmas to ignore -Wcast-qual warnings when using a
1827           C-style cast from CFTypeRef to HIViewRef.
1828         * Configurations/Base.xcconfig:
1829         (WARNING_CFLAGS): Add -Wcast-qual.
1830         * Misc/WebElementDictionary.mm:
1831         (-[WebElementDictionary objectForKey:]):
1832         - Use static_cast<SEL>(const_cast<void*>()) to fix
1833           warning.
1834         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1835         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1836         (-[NSData _webkit_guessedMIMETypeForXML]):
1837         (-[NSData _webkit_guessedMIMEType]):
1838         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1839         (_findEOL):
1840         (-[NSData _webkit_parseRFC822HeaderFields]):
1841         (-[NSData _web_startsWithBlankLine]):
1842         (-[NSData _web_locationAfterFirstBlankLine]):
1843         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1844           type to Objective-C++.  This fixes the warnings about
1845           discarding the `const` modifier when casing from CFStringRef
1846           to NSString * because in older clang versions, -Wcast-qual was
1847           completely broken when compiling C++ and Objective-C++ source
1848           files.  In newer clang versions, discarding the `const`
1849           modifier for toll-free bridged types is ignored when compiling
1850           Objective-C++ source.
1851         - Update copyright and license header.
1852         - Use reinterpret_cast<> and static_cast<> to fix warnings
1853           unrelated to (NSString *) C-style casts.
1854         - Replace use of MIN() macro with std::min<> template functions.
1855         - Fix location of `*` for local variables modified above.
1856         * Plugins/Hosted/NetscapePluginHostManager.mm:
1857         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1858         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1859         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1860         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1861           warnings.
1862         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1863         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1864         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1865           to fix warning.
1866         * Plugins/Hosted/ProxyInstance.mm:
1867         (WebKit::ProxyInstance::invoke):
1868         - Use static_cast<char*>(const_cast<void*>()) to fix
1869           warning when using -[NSData bytes].
1870         (WebKit::ProxyInstance::fieldValue const):
1871         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1872           to fix warning when using CFDataGetBytePtr().
1873         * Plugins/Hosted/WebTextInputWindowController.m:
1874         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1875         - Use #pragma to ignore -Wcast-qual warning since there
1876           is not a good way to avoid this warning in Objective-C.
1877         * Plugins/WebNetscapePluginStream.mm:
1878         (WebNetscapePluginStream::deliverData):
1879         - Use const_cast<void*>() to fix warning when using
1880           -[NSData bytes].
1881         * Plugins/WebNetscapePluginView.mm:
1882         (-[WebNetscapePluginView _createPlugin]):
1883         - Change C-style cast to const_cast<char*>() to fix
1884           warning.
1885         * WebCoreSupport/WebChromeClient.mm:
1886         (WebChromeClient::wrapCryptoKey const):
1887         (WebChromeClient::unwrapCryptoKey const):
1888         - Change C-style cast to
1889           static_cast<uint8_t*>(const_cast<void*>() to fix
1890           warning.
1891         * WebView/WebPDFView.mm:
1892         (_applicationInfoForMIMEType):
1893         - Change local variable type from 'NSURL *' to
1894           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1895           when calling -[NSURL path].
1896
1897 2018-01-05  Dan Bernstein  <mitz@apple.com>
1898
1899         Fixed the build following AppKit API deprecations in a recent SDKs
1900
1901         * WebView/WebFullScreenController.mm:
1902         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1903         (-[WebFullScreenController exitFullScreen]): Ditto.
1904         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1905         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1906         * WebView/WebHTMLView.mm:
1907         (-[WebHTMLView drawRect:]): Ditto.
1908         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1909         (-[WebHTMLView knowsPageRange:]): Ditto.
1910         * WebView/WebView.mm:
1911         (LayerFlushController::flushLayers): Ditto.
1912
1913 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1914
1915         [Attachment Support] Create attachment elements when dropping files on iOS
1916         https://bugs.webkit.org/show_bug.cgi?id=181192
1917         <rdar://problem/36280945>
1918
1919         Reviewed by Tim Horton.
1920
1921         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1922
1923         * WebCoreSupport/WebPlatformStrategies.h:
1924         * WebCoreSupport/WebPlatformStrategies.mm:
1925         (WebPlatformStrategies::informationForItemAtIndex):
1926         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1927
1928 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1929
1930         [Attachment Support] Add plumbing for starting a drag with promised blob data
1931         https://bugs.webkit.org/show_bug.cgi?id=181201
1932
1933         Reviewed by Tim Horton.
1934
1935         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1936
1937         * WebCoreSupport/WebDragClient.h:
1938
1939 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1940
1941         Add a WebAuthentication runtime feature flag
1942         https://bugs.webkit.org/show_bug.cgi?id=181220
1943         <rdar://problem/36055305>
1944
1945         Reviewed by Brent Fulgham.
1946
1947         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1948
1949         * WebView/WebPreferenceKeysPrivate.h:
1950         * WebView/WebPreferences.mm:
1951         (+[WebPreferences initialize]):
1952         (-[WebPreferences webAuthenticationEnabled]):
1953         (-[WebPreferences setWebAuthenticationEnabled:]):
1954         (-[WebPreferences credentialManagementEnabled]): Deleted.
1955         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1956         * WebView/WebPreferencesPrivate.h:
1957         * WebView/WebView.mm:
1958         (-[WebView _preferencesChanged:]):
1959
1960 2017-12-22  Jeff Miller  <jeffm@apple.com>
1961
1962         Update user-visible copyright strings to include 2018
1963         https://bugs.webkit.org/show_bug.cgi?id=181141
1964
1965         Reviewed by Dan Bernstein.
1966
1967         * Info.plist:
1968
1969 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1970
1971         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1972         https://bugs.webkit.org/show_bug.cgi?id=181188
1973
1974         Reviewed by Dan Bernstein.
1975
1976         See WebCore/ChangeLog for more detail.
1977
1978         * WebCoreSupport/WebDragClient.h:
1979         * WebCoreSupport/WebDragClient.mm:
1980         (WebDragClient::declareAndWriteAttachment): Deleted.
1981         * WebView/WebHTMLView.mm:
1982         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1983
1984 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1985
1986         Unreviewed, continue to fix build failures due to AppKit API deprecation
1987
1988         Wraps more code in -Wdeprecated-declarations.
1989
1990         * Carbon/HIWebView.mm:
1991         (overrideCGContext):
1992
1993 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1994
1995         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1996
1997         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1998
1999         * Carbon/CarbonWindowAdapter.mm:
2000         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2001         * Plugins/WebNetscapePluginView.mm:
2002         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2003         (-[WebNetscapePluginView sendDrawRectEvent:]):
2004         (-[WebNetscapePluginView drawRect:]):
2005
2006 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2007
2008         Fix build failures due to using deprecated AppKit symbols
2009         https://bugs.webkit.org/show_bug.cgi?id=181110
2010         <rdar://problem/36162865>
2011
2012         Reviewed by Dan Bernstein and Tim Horton.
2013
2014         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
2015
2016         * Misc/WebKitNSStringExtras.mm:
2017         (-[NSString _web_drawAtPoint:font:textColor:]):
2018         * Misc/WebNSPasteboardExtras.h:
2019         * Misc/WebNSPasteboardExtras.mm:
2020         (+[NSPasteboard _web_writableTypesForURL]):
2021         (_createWritableTypesForImageWithoutArchive):
2022         (_createWritableTypesForImageWithArchive):
2023         (+[NSPasteboard _web_dragTypesForURL]):
2024         (-[NSPasteboard _web_bestURL]):
2025         (-[NSPasteboard _web_writeURL:andTitle:types:]):
2026         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2027         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
2028         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
2029         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2030         * Panels/WebAuthenticationPanel.m:
2031         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
2032         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
2033         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2034         (-[WebHostedNetscapePluginView drawRect:]):
2035         * WebInspector/WebNodeHighlightView.mm:
2036         (-[WebNodeHighlightView drawRect:]):
2037         * WebView/WebFrame.mm:
2038         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2039         (-[WebFrame _drawRect:contentsOnly:]):
2040         * WebView/WebHTMLView.mm:
2041         (kit):
2042         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
2043         (-[WebHTMLView _plainTextFromPasteboard:]):
2044         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2045         (+[WebHTMLView _insertablePasteboardTypes]):
2046         (+[WebHTMLView _selectionPasteboardTypes]):
2047         (-[WebHTMLView pasteboard:provideDataForType:]):
2048         (-[WebHTMLView _writeSelectionToPasteboard:]):
2049         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2050         (-[WebHTMLView validRequestorForSendType:returnType:]):
2051         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2052         (createMenuItem):
2053         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2054         (-[WebHTMLView _colorAsString:]):
2055         (-[WebHTMLView copyFont:]):
2056         * WebView/WebPDFView.mm:
2057         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2058         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2059         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2060         (-[WebPDFView pasteboardTypesForSelection]):
2061         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
2062         * WebView/WebView.h:
2063         * WebView/WebView.mm:
2064         (-[WebView performDragOperation:]):
2065         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
2066         (-[WebView _searchWithGoogleFromMenu:]):
2067
2068 2017-12-21  Youenn Fablet  <youenn@apple.com>
2069
2070         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
2071         https://bugs.webkit.org/show_bug.cgi?id=181000
2072
2073         Reviewed by Chris Dumez.
2074
2075         * Misc/WebCache.mm:
2076         (+[WebCache addImageToCache:forURL:forFrame:]):
2077
2078 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2079
2080         Update FULLSCREEN_API feature defines.
2081         https://bugs.webkit.org/show_bug.cgi?id=181015
2082
2083         Reviewed by Tim Horton.
2084
2085         Change enabled iphone sdk for FULLSCREEN_API.
2086
2087         * Configurations/FeatureDefines.xcconfig:
2088
2089 2017-12-21  Jer Noble  <jer.noble@apple.com>
2090
2091         Add initial DOM support for Media Capabilities
2092         https://bugs.webkit.org/show_bug.cgi?id=181064
2093
2094         Reviewed by Eric Carlson.
2095
2096         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
2097
2098         * WebView/WebPreferenceKeysPrivate.h:
2099         * WebView/WebPreferences.mm:
2100         (+[WebPreferences initialize]):
2101         (-[WebPreferences mediaCapabilitiesEnabled]):
2102         (-[WebPreferences setMediaCapabilitiesEnabled:]):
2103         * WebView/WebPreferencesPrivate.h:
2104         * WebView/WebView.mm:
2105         (-[WebView _preferencesChanged:]):
2106
2107 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2108
2109         Enable picture-in-picture from inline element on suspend.
2110         https://bugs.webkit.org/show_bug.cgi?id=180942
2111         rdar://problem/34745234
2112
2113         Reviewed by Jer Noble.
2114
2115         Update signature of enterVideoFullscreenForVideoElement().
2116
2117         * WebCoreSupport/WebChromeClient.h:
2118         * WebCoreSupport/WebChromeClient.mm:
2119         (WebChromeClient::enterVideoFullscreenForVideoElement):
2120
2121 2017-12-20  Daniel Bates  <dabates@apple.com>
2122
2123         Remove Alternative Presentation Button
2124         https://bugs.webkit.org/show_bug.cgi?id=180500
2125         <rdar://problem/35891047>
2126
2127         Reviewed by Simon Fraser.
2128
2129         We no longer need the alternative presentation button.
2130
2131         * Configurations/FeatureDefines.xcconfig:
2132
2133 2017-12-19  Jer Noble  <jer.noble@apple.com>
2134
2135         Playing media elements which call "pause(); play()" will have the play promise rejected.
2136         https://bugs.webkit.org/show_bug.cgi?id=180781
2137         <rdar://problem/33191377>
2138
2139         Reviewed by Eric Carlson.
2140
2141         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
2142
2143         * WebView/WebView.mm:
2144         (shouldRequireUserGestureToLoadVideo):
2145
2146 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
2149         https://bugs.webkit.org/show_bug.cgi?id=180977
2150
2151         Reviewed by Tim Horton.
2152
2153         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
2154         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
2155         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
2156
2157         * WebCoreSupport/WebEditorClient.mm:
2158         (attributesForAttributedStringConversion):
2159         * WebView/WebHTMLView.mm:
2160         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2161
2162 2017-12-18  David Kilzer  <ddkilzer@apple.com>
2163
2164         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
2165
2166         Attempt to fix the following warnings:
2167
2168             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
2169
2170         For the following instance variables:
2171
2172             _borderView
2173             _contentView
2174             _frame
2175             _wFlags
2176
2177         * Carbon/CarbonWindowAdapter.mm:
2178         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2179         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2180         (-[CarbonWindowAdapter _termWindowIfOwner]):
2181         (-[CarbonWindowAdapter _windowMovedToRect:]):
2182         (-[CarbonWindowAdapter setContentView:]):
2183         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2184         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2185
2186 2017-12-16  Dan Bernstein  <mitz@apple.com>
2187
2188         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
2189         https://bugs.webkit.org/show_bug.cgi?id=180613
2190         <rdar://problem/35946124>
2191
2192         Reviewed by Geoff Garen.
2193
2194         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
2195           clients.
2196         * WebView/WebDynamicScrollBarsView.h: Ditto.
2197         * WebView/WebDynamicScrollBarsView.mm: Ditto.
2198
2199 2017-12-14  David Kilzer  <ddkilzer@apple.com>
2200
2201         Enable -Wstrict-prototypes for WebKit
2202         <https://webkit.org/b/180757>
2203         <rdar://problem/36024132>
2204
2205         Rubber-stamped by Joseph Pecoraro.
2206
2207         * Configurations/Base.xcconfig:
2208         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
2209
2210 2017-12-14  John Wilander  <wilander@apple.com>
2211
2212         Storage Access API: Implement frame-specific access in the document.cookie layer
2213         https://bugs.webkit.org/show_bug.cgi?id=180682
2214         <rdar://problem/35982257>
2215
2216         Reviewed by Alex Christensen.
2217
2218         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2219         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2220         CookiesStrategy::getRawCookies() now take optional parameters for
2221         frameID and pageID to allow frame-specific scoping of cookies.
2222
2223         This change makes the return values of FrameLoaderClient::frameID()
2224         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2225         WebCore can call those getters and get the right return values in
2226         WebKit and std:nullopt in WebKitLegacy.
2227
2228         * WebCoreSupport/WebFrameLoaderClient.h:
2229         * WebCoreSupport/WebFrameLoaderClient.mm:
2230         (WebFrameLoaderClient::pageID const):
2231         (WebFrameLoaderClient::frameID const):
2232         * WebCoreSupport/WebPlatformStrategies.h:
2233         * WebCoreSupport/WebPlatformStrategies.mm:
2234         (WebPlatformStrategies::cookiesForDOM):
2235         (WebPlatformStrategies::setCookiesFromDOM):
2236         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2237         (WebPlatformStrategies::getRawCookies):
2238
2239 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
2240
2241         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
2242         https://bugs.webkit.org/show_bug.cgi?id=180689
2243
2244         Reviewed by Tim Horton.
2245
2246         Use sRGBColorSpaceRef() from WebCore.
2247
2248         * WebView/WebHTMLView.mm:
2249         (imageFromRect):
2250
2251 2017-12-11  Tim Horton  <timothy_horton@apple.com>
2252
2253         Stop using deprecated target conditional for simulator builds
2254         https://bugs.webkit.org/show_bug.cgi?id=180662
2255         <rdar://problem/35136156>
2256
2257         Reviewed by Simon Fraser.
2258
2259         * postprocess-headers.sh:
2260
2261 2017-12-11  David Quesada  <david_quesada@apple.com>
2262
2263         Turn on ENABLE_APPLICATION_MANIFEST
2264         https://bugs.webkit.org/show_bug.cgi?id=180562
2265         rdar://problem/35924737
2266
2267         Reviewed by Geoffrey Garen.
2268
2269         * Configurations/FeatureDefines.xcconfig:
2270
2271 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2272
2273         Remove pthread_once in favor of dispatch_once
2274         https://bugs.webkit.org/show_bug.cgi?id=180591
2275
2276         Reviewed by Saam Barati.
2277
2278         * Misc/WebKitErrors.m:
2279         (+[NSError _registerWebKitErrors]):
2280         (registerErrors): Deleted.
2281         * Storage/WebStorageManager.mm:
2282         (+[WebStorageManager _storageDirectoryPath]):
2283         (initializeLocalStoragePath): Deleted.
2284
2285 2017-12-07  Darin Adler  <darin@apple.com>
2286
2287         Remove some unused code from WebKitLegacy
2288         https://bugs.webkit.org/show_bug.cgi?id=180567
2289
2290         Reviewed by Anders Carlsson.
2291
2292         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
2293         macOS (back a few versions) and iOS and removed unused
2294         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
2295         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
2296         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
2297         _webkit_stringByCollapsingNonPrintingCharacters,
2298         _webkit_stringByCollapsingWhitespaceCharacters,
2299         _web_stringWithData:textEncodingName:, and
2300         _webkit_localStorageDirectoryWithBundleIdentifier:.
2301
2302         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
2303         this source file.
2304         (canUseFastRenderer): Made this faster by not calling u_charDirection for
2305         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
2306         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
2307         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
2308         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
2309         handle font smoothing options.
2310         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
2311         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
2312         from header and made it a little clearer.
2313         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
2314         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
2315         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
2316         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
2317         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
2318         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
2319         implementation a bit and used whole words instead of abbreviations.
2320         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
2321
2322         * Misc/WebNSFileManagerExtras.mm:
2323         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
2324         filenameByFixingIllegalCharacters function from WebCore directly instead of
2325         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
2326
2327         * Plugins/WebBaseNetscapePluginView.mm:
2328         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
2329         string replacements instead of _web_stringByStrippingReturnCharacters
2330         and to use NSString methods instead of CFString functions.
2331
2332 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
2333
2334         Ignore deprecation warnings.
2335
2336         * WebView/WebHTMLView.mm:
2337         (-[NSWindow _web_borderView]):
2338         (-[WebHTMLView _setAsideSubviews]):
2339         * WebView/WebView.mm:
2340         (-[WebView encodeWithCoder:]):
2341
2342 2017-12-02  Darin Adler  <darin@apple.com>
2343
2344         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
2345         https://bugs.webkit.org/show_bug.cgi?id=180009
2346
2347         Reviewed by Alex Christensen.
2348
2349         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
2350
2351         * Plugins/WebBaseNetscapePluginView.mm:
2352         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
2353         of strcasecmp.
2354
2355         * WebView/WebPreferences.mm:
2356         (contains): Ditto. Also made this a template so it's easier to call on an array.
2357         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
2358
2359 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
2360
2361         Limit user agent versioning to an upper bound
2362         https://bugs.webkit.org/show_bug.cgi?id=180365
2363         <rdar://problem/34550617>
2364
2365         Reviewed by Joseph Pecoraro.
2366
2367         * WebView/WebView.mm:
2368         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
2369         creating the User Agent string.
2370         (webKitBundleVersionString): Deleted.
2371
2372 2017-12-05  Andy Estes  <aestes@apple.com>
2373
2374         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
2375         https://bugs.webkit.org/show_bug.cgi?id=180457
2376         <rdar://problem/35143007>
2377
2378         Reviewed by Tim Horton.
2379
2380         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2381         check for this macro during post-processing.
2382
2383         * postprocess-headers.sh:
2384
2385 2017-12-04  David Quesada  <david_quesada@apple.com>
2386
2387         Add a class for parsing application manifests
2388         https://bugs.webkit.org/show_bug.cgi?id=177973
2389         rdar://problem/34747949
2390
2391         Reviewed by Geoffrey Garen.
2392
2393         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2394
2395 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2396
2397         Make LegacyCustomProtocolManager optional for network process
2398         https://bugs.webkit.org/show_bug.cgi?id=176230
2399
2400         Reviewed by Alex Christensen.
2401
2402         * Configurations/FeatureDefines.xcconfig:
2403
2404 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2405
2406         Fix some NSOperationQueue leaks
2407         https://bugs.webkit.org/show_bug.cgi?id=180221
2408
2409         Reviewed by Wenson Hsieh.
2410
2411         * WebView/WebView.mm:
2412         (-[WebView performDragOperation:]):
2413
2414 2017-11-30  Darin Adler  <darin@apple.com>
2415
2416         [Mac] remove unneeded RetainPtr use introduced in r225142
2417         https://bugs.webkit.org/show_bug.cgi?id=180202
2418
2419         Reviewed by Tim Horton.
2420
2421         * WebView/WebImmediateActionController.mm:
2422         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2423         RetainPtr.
2424
2425 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2426
2427         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2428         https://bugs.webkit.org/show_bug.cgi?id=175595
2429
2430         Reviewed by Darin Adler.
2431
2432         * WebView/WebPreferences.mm:
2433
2434 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2435
2436         One too many zeroes in macOS version number in FeatureDefines
2437         https://bugs.webkit.org/show_bug.cgi?id=180011
2438
2439         Reviewed by Dan Bernstein.
2440
2441         * Configurations/FeatureDefines.xcconfig:
2442
2443 2017-11-23  Darin Adler  <darin@apple.com>
2444
2445         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2446         https://bugs.webkit.org/show_bug.cgi?id=179981
2447
2448         Reviewed by Sam Weinig.
2449
2450         * WebView/WebImmediateActionController.mm:
2451         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2452         * WebView/WebView.mm:
2453         (coreOptions): Use |= instead of | to build up FindOptions.
2454
2455 2017-11-23  Sam Weinig  <sam@webkit.org>
2456
2457         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2458         https://bugs.webkit.org/show_bug.cgi?id=179954
2459
2460         Reviewed by Darin Adler.
2461
2462         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2463         with direct calls to the corresponding UserGestureIndicator functions.
2464
2465         * Plugins/WebPluginController.mm:
2466         (-[WebPluginController processingUserGesture]):
2467         * WebView/WebView.mm:
2468         (-[WebView _isProcessingUserGesture]):
2469
2470 2017-11-23  Darin Adler  <darin@apple.com>
2471
2472         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2473         https://bugs.webkit.org/show_bug.cgi?id=179907
2474
2475         Reviewed by Sam Weinig.
2476
2477         * History/BinaryPropertyList.cpp:
2478         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2479         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2480         * WebView/WebHTMLRepresentation.mm:
2481         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2482         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2483
2484 2017-11-22  Ali Juma  <ajuma@chromium.org>
2485
2486         Implement VisualViewport API attributes
2487         https://bugs.webkit.org/show_bug.cgi?id=179385
2488
2489         Reviewed by Frédéric Wang.
2490
2491         Add a VisualViewportAPI preference.
2492
2493         * WebView/WebPreferenceKeysPrivate.h:
2494         * WebView/WebPreferences.mm:
2495         (+[WebPreferences initialize]):
2496         (-[WebPreferences visualViewportAPIEnabled]):
2497         (-[WebPreferences setVisualViewportAPIEnabled:]):
2498         * WebView/WebPreferencesPrivate.h:
2499         * WebView/WebView.mm:
2500         (-[WebView _preferencesChanged:]):
2501
2502 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2503
2504         WebCoreObjCExtras.h is being included in too many places
2505         https://bugs.webkit.org/show_bug.cgi?id=179931
2506
2507         Reviewed by Darin Adler.
2508
2509         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2510         * Plugins/WebBaseNetscapePluginView.mm:
2511         * Plugins/WebBasePluginPackage.mm:
2512         * Plugins/WebNetscapePluginStream.mm:
2513         * Plugins/WebNetscapePluginView.mm:
2514         * WebView/WebTextIterator.mm:
2515         * WebView/WebViewData.mm:
2516
2517 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2518
2519         Unreviewed, rolling out r225093.
2520         https://bugs.webkit.org/show_bug.cgi?id=179938
2521
2522         Compilation failed on WinCairo 64-bit Release (Requested by
2523         fredw on #webkit).
2524
2525         Reverted changeset:
2526
2527         "Implement VisualViewport API attributes"
2528         https://bugs.webkit.org/show_bug.cgi?id=179385
2529         https://trac.webkit.org/changeset/225093
2530
2531 2017-11-21  Ali Juma  <ajuma@chromium.org>
2532
2533         Implement VisualViewport API attributes
2534         https://bugs.webkit.org/show_bug.cgi?id=179385
2535
2536         Reviewed by Frédéric Wang.
2537
2538         Add a VisualViewportAPI preference.
2539
2540         * WebView/WebPreferenceKeysPrivate.h:
2541         * WebView/WebPreferences.mm:
2542         (+[WebPreferences initialize]):
2543         (-[WebPreferences visualViewportAPIEnabled]):
2544         (-[WebPreferences setVisualViewportAPIEnabled:]):
2545         * WebView/WebPreferencesPrivate.h:
2546         * WebView/WebView.mm:
2547         (-[WebView _preferencesChanged:]):
2548
2549 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2550
2551         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2552         https://bugs.webkit.org/show_bug.cgi?id=179504
2553
2554         Reviewed by Darin Adler.
2555
2556         * Misc/WebKitNSStringExtras.mm:
2557         * Plugins/Hosted/NetscapePluginHostManager.mm:
2558         * Plugins/WebBasePluginPackage.mm:
2559
2560 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2561
2562         Remove unused TOUCH_ICON_LOADING feature flag
2563         https://bugs.webkit.org/show_bug.cgi?id=179873
2564
2565         Reviewed by Simon Fraser.
2566
2567         * Configurations/FeatureDefines.xcconfig:
2568
2569 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2570
2571         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2572         https://bugs.webkit.org/show_bug.cgi?id=179872
2573
2574         Reviewed by Darin Adler.
2575
2576         * Configurations/FeatureDefines.xcconfig:
2577
2578 2017-11-16  Daniel Bates  <dabates@apple.com>
2579
2580         Add feature define for alternative presentation button element
2581         https://bugs.webkit.org/show_bug.cgi?id=179692
2582         Part of <rdar://problem/34917108>
2583
2584         Reviewed by Andy Estes.
2585
2586         Only enabled on Cocoa platforms by default.
2587
2588         * Configurations/FeatureDefines.xcconfig:
2589
2590 2017-11-14  Nan Wang  <n_wang@apple.com>
2591
2592         AX: AOM: Implement AccessibleNode class and support label and role attributes
2593         https://bugs.webkit.org/show_bug.cgi?id=179494
2594
2595         Reviewed by Ryosuke Niwa.
2596
2597         * WebView/WebPreferenceKeysPrivate.h:
2598         * WebView/WebPreferences.mm:
2599         (+[WebPreferences initialize]):
2600         (-[WebPreferences accessibilityObjectModelEnabled]):
2601         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2602         * WebView/WebPreferencesPrivate.h:
2603         * WebView/WebView.mm:
2604         (-[WebView _preferencesChanged:]):
2605
2606 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2607
2608         Remove Cocoa CFURLConnection loading code
2609         https://bugs.webkit.org/show_bug.cgi?id=179688
2610
2611         Reviewed by Antti Koivisto.
2612
2613         * Misc/WebDownload.mm:
2614         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2615         * Misc/WebDownloadInternal.h:
2616         * Plugins/WebBaseNetscapePluginView.mm:
2617         * WebCoreSupport/WebFrameLoaderClient.mm:
2618         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2619         * WebView/WebView.mm:
2620         (-[WebView scheduleInRunLoop:forMode:]):
2621         (-[WebView unscheduleFromRunLoop:forMode:]):
2622
2623 2017-11-14  Daniel Bates  <dabates@apple.com>
2624
2625         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2626         for feature defines
2627
2628         Following r195498 and r201917 the Visual Studio property files for feature defines have
2629         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2630         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2631         files.
2632
2633         * Configurations/FeatureDefines.xcconfig:
2634
2635 2017-11-14  Jer Noble  <jer.noble@apple.com>
2636
2637         Enable Modern EME tests in DumpRenderTree
2638         https://bugs.webkit.org/show_bug.cgi?id=179544
2639
2640         Reviewed by Alex Christensen.
2641
2642         Add a WebPreferences property to enable the (modern) EME API.
2643
2644         * WebView/WebPreferenceKeysPrivate.h:
2645         * WebView/WebPreferences.mm:
2646         (+[WebPreferences initialize]):
2647         (-[WebPreferences encryptedMediaAPIEnabled]):
2648         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2649         * WebView/WebPreferencesPrivate.h:
2650         * WebView/WebView.mm:
2651         (-[WebView _preferencesChanged:]):
2652
2653 2017-11-14  Antti Koivisto  <antti@apple.com>
2654
2655         Enable display:contents by default
2656         https://bugs.webkit.org/show_bug.cgi?id=179655
2657
2658         Reviewed by Sam Weinig.
2659
2660         * WebView/WebPreferences.mm:
2661         (+[WebPreferences initialize]):
2662
2663 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2664
2665         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2666         https://bugs.webkit.org/show_bug.cgi?id=178751
2667
2668         Reviewed by Brady Eidson.
2669
2670         * WebCoreSupport/WebFrameNetworkingContext.mm:
2671         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2672
2673 2017-11-08  Keith Miller  <keith_miller@apple.com>
2674
2675         Async iteration should only fetch the next method once and add feature flag
2676         https://bugs.webkit.org/show_bug.cgi?id=179451
2677
2678         Reviewed by Geoffrey Garen.
2679
2680         Add feature flag for Async iteration.
2681
2682         * Configurations/FeatureDefines.xcconfig:
2683
2684 2017-11-13  Mark Lam  <mark.lam@apple.com>
2685
2686         Add more overflow check book-keeping for MarkedArgumentBuffer.
2687         https://bugs.webkit.org/show_bug.cgi?id=179634
2688         <rdar://problem/35492517>
2689
2690         Reviewed by Saam Barati.
2691
2692         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2693         (WebKit::NetscapePluginInstanceProxy::invoke):
2694         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2695         (WebKit::NetscapePluginInstanceProxy::construct):
2696
2697 2017-11-12  Darin Adler  <darin@apple.com>
2698
2699         More is<> and downcast<>, less static_cast<>
2700         https://bugs.webkit.org/show_bug.cgi?id=179600
2701
2702         Reviewed by Chris Dumez.
2703
2704         * DOM/DOM.mm:
2705         (kit): Use is/downcast.
2706         * WebCoreSupport/WebEditorClient.mm:
2707         (WebEditorClient::handleKeyboardEvent): Ditto.
2708         (WebEditorClient::handleInputMethodKeydown): Ditto.
2709         * WebView/WebHTMLView.mm:
2710         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2711
2712 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2713
2714         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2715         https://bugs.webkit.org/show_bug.cgi?id=179397
2716
2717         Reviewed by Wenson Hsieh.
2718
2719         * DOM/DOMHTMLInputElement.mm:
2720         (-[DOMHTMLInputElement insertTextSuggestion:]):
2721
2722 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2723
2724         HTMLMediaElement should not use element fullscreen on iOS
2725         https://bugs.webkit.org/show_bug.cgi?id=179418
2726         rdar://problem/35409277
2727
2728         Reviewed by Eric Carlson.
2729
2730         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2731
2732         * Configurations/FeatureDefines.xcconfig:
2733
2734 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2735
2736         Make ResourceLoader::willSendRequestInternal asynchronous
2737         https://bugs.webkit.org/show_bug.cgi?id=179251
2738
2739         Reviewed by Andy Estes.
2740
2741         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2742         (WebKit::HostedNetscapePluginStream::start):
2743         * Plugins/WebNetscapePluginStream.mm:
2744         (WebNetscapePluginStream::start):
2745
2746 2017-11-01  Darin Adler  <darin@apple.com>
2747
2748         Simplify event dispatch code and make it a bit more consistent
2749         https://bugs.webkit.org/show_bug.cgi?id=178991
2750
2751         Reviewed by Chris Dumez.
2752
2753         * DOM/DOMEvent.mm:
2754         (-[DOMEvent srcElement]): Call target instead of srcElement.
2755
2756 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2757
2758         [Touch Bar Web API] Add support for menuitem tag
2759         https://bugs.webkit.org/show_bug.cgi?id=179020
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         Adds in properties and methods that allow the menuitem runtime feature
2764         to be enabled or disabled.
2765
2766         * WebView/WebPreferenceKeysPrivate.h:
2767         * WebView/WebPreferences.mm:
2768         (-[WebPreferences menuItemElementEnabled]):
2769         (-[WebPreferences setMenuItemElementEnabled:]):
2770         * WebView/WebPreferencesPrivate.h:
2771         * WebView/WebView.mm:
2772         (-[WebView _preferencesChanged:]):
2773
2774 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2775
2776         Use CompletionHandlers for redirects
2777         https://bugs.webkit.org/show_bug.cgi?id=179163
2778
2779         Reviewed by Tim Horton.
2780
2781         * Plugins/Hosted/HostedNetscapePluginStream.h:
2782         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2783         (WebKit::HostedNetscapePluginStream::willSendRequest):
2784         * Plugins/WebNetscapePluginStream.h:
2785         * Plugins/WebNetscapePluginStream.mm:
2786         (WebNetscapePluginStream::willSendRequest):
2787
2788 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2789
2790         Add a FileSystem namespace to FileSystem.cpp
2791         https://bugs.webkit.org/show_bug.cgi?id=179063
2792
2793         Reviewed by Darin Adler.
2794
2795         * Misc/WebNSFileManagerExtras.mm:
2796         * Storage/WebDatabaseProvider.mm:
2797
2798 2017-11-02  Frederic Wang  <fwang@igalia.com>
2799
2800         Add references to bug 179167 in FIXME comments
2801         https://bugs.webkit.org/show_bug.cgi?id=179168
2802
2803         Reviewed by Daniel Bates.
2804
2805         * Configurations/FeatureDefines.xcconfig:
2806
2807 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2808
2809         Implement WKFullscreenWindowController for iOS.
2810         https://bugs.webkit.org/show_bug.cgi?id=178924
2811         rdar://problem/34697120
2812
2813         Reviewed by Simon Fraser.
2814
2815         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2816
2817         * Configurations/FeatureDefines.xcconfig:
2818         * WebView/WebView.mm:
2819         (-[WebView fullScreenPlaceholderView]):
2820
2821 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2822
2823         Clean up some drag and drop feature flags
2824         https://bugs.webkit.org/show_bug.cgi?id=179082
2825
2826         Reviewed by Simon Fraser.
2827
2828         * Configurations/FeatureDefines.xcconfig:
2829
2830 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2831
2832         Make it possible to test rubber-banding in overflow scroll
2833         https://bugs.webkit.org/show_bug.cgi?id=179078
2834
2835         Reviewed by Sam Weinig.
2836
2837         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2838         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2839
2840         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2841         functions, since most callers want clamped.
2842
2843         * DOM/DOMHTML.mm:
2844         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2845
2846 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2847
2848         Fix up some content filtering feature flags
2849         https://bugs.webkit.org/show_bug.cgi?id=179079
2850
2851         Reviewed by Simon Fraser.
2852
2853         * Configurations/FeatureDefines.xcconfig:
2854
2855 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2856
2857         [FrameView::layout cleanup] Move core layout logic to a separate class.
2858         https://bugs.webkit.org/show_bug.cgi?id=178771
2859         <rdar://problem/35166542>
2860
2861         Reviewed by Simon Fraser.
2862
2863         Move layout code out from FrameView to LayoutContext.
2864
2865         * WebView/WebClipView.mm:
2866         (-[WebClipView _immediateScrollToPoint:]):
2867         * WebView/WebFrame.mm:
2868         (-[WebFrame layoutCount]):
2869
2870 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2871
2872         Fix issues with WebView subframe painting
2873         https://bugs.webkit.org/show_bug.cgi?id=178842
2874         rdar://problem/34072253
2875
2876         Reviewed by Daniel Bates.
2877         
2878         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2879         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2880         High Sierra, so match the new signature.
2881
2882         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2883
2884         * WebView/WebHTMLView.mm:
2885         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2886         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2887
2888 2017-10-25  Youenn Fablet  <youenn@apple.com>
2889
2890         Enable ServiceWorker to fetch resources
2891         https://bugs.webkit.org/show_bug.cgi?id=178673
2892
2893         Reviewed by Brady Eidson.
2894
2895         * WebCoreSupport/WebFrameLoaderClient.mm:
2896         (WebFrameLoaderClient::pageID const):
2897         (WebFrameLoaderClient::frameID const):
2898         (WebFrameLoaderClient::sessionID const):
2899
2900         Added implementation to the new getters.
2901         They are noop in the context of WK1.
2902
2903 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2904
2905         Web Inspector: Enable WebKit logging configuration and display
2906         https://bugs.webkit.org/show_bug.cgi?id=177027
2907         <rdar://problem/33964767>
2908
2909         Reviewed by Joseph Pecoraro.
2910
2911         * WebCoreSupport/WebChromeClient.mm:
2912         (stringForMessageSource): Deal with Media and WebRTC message sources.
2913
2914 2017-10-20  Antoine Quint  <graouts@apple.com>
2915
2916         [Web Animations] Provide basic timeline and animation interfaces
2917         https://bugs.webkit.org/show_bug.cgi?id=178526
2918
2919         Reviewed by Dean Jackson.
2920
2921         Remove the WEB_ANIMATIONS compile-time flag.
2922
2923         * Configurations/FeatureDefines.xcconfig:
2924         * WebView/WebPreferences.mm:
2925         (+[WebPreferences initialize]):
2926         * WebView/WebView.mm:
2927         (-[WebView _preferencesChanged:]):
2928
2929 2017-10-19  Sam Weinig  <sam@webkit.org>
2930
2931         [Settings] Move global settings into their own file
2932         https://bugs.webkit.org/show_bug.cgi?id=178512
2933
2934         Reviewed by Darin Adler.
2935
2936         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2937
2938         * WebCoreSupport/WebChromeClient.mm:
2939         (WebChromeClient::supportsVideoFullscreen):
2940         * WebView/WebDynamicScrollBarsView.mm:
2941         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2942         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2943         * WebView/WebPreferences.mm:
2944         (+[WebPreferences initialize]):
2945         * WebView/WebView.mm:
2946         (-[WebView _commonInitializationWithFrameName:groupName:]):
2947         (-[WebView _preferencesChanged:]):
2948         (+[WebView _doNotStartObservingNetworkReachability]):
2949
2950 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2951
2952         Replace some stack raw pointers with RefPtrs within WebCore/html
2953         https://bugs.webkit.org/show_bug.cgi?id=178201
2954         <rdar://problem/34841692>
2955
2956         Reviewed by Ryosuke Niwa.
2957
2958         * DOM/DOM.mm:
2959         (kit):
2960         Change the type of node as toNode() is changed to return RefPtr.
2961
2962 2017-10-18  Chris Dumez  <cdumez@apple.com>
2963
2964         [Service Worker] Add stubs for Client / WindowClient / Clients
2965         https://bugs.webkit.org/show_bug.cgi?id=178469
2966
2967         Reviewed by Youenn Fablet.
2968
2969         Rename PageVisiblityState to VisibilityState.
2970
2971         * WebView/WebView.mm:
2972         (kit):
2973
2974 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2975
2976         Unreviewed, rolling out r223291.
2977
2978         See WebCore ChangeLog for more detail.
2979
2980         Reverted changeset:
2981
2982         "Remove Editor::simplifyMarkup"
2983         https://bugs.webkit.org/show_bug.cgi?id=178271
2984         https://trac.webkit.org/changeset/223291
2985
2986 2017-10-17  Keith Miller  <keith_miller@apple.com>
2987
2988         Change WebCore sources to work with unified source builds
2989         https://bugs.webkit.org/show_bug.cgi?id=178229
2990
2991         Rubber stamped by Tim Horton.
2992
2993         * Configurations/FeatureDefines.xcconfig:
2994
2995 2017-10-16  Sam Weinig  <sam@webkit.org>
2996
2997         [Settings] Remove all custom code from Settings.h/cpp
2998         https://bugs.webkit.org/show_bug.cgi?id=178330
2999
3000         Reviewed by Simon Fraser.
3001
3002         * WebView/WebPreferences.mm:
3003         (+[WebPreferences initialize]):
3004         
3005             Update for naming changes of FrameFlattening now that it is an enum class.
3006
3007 2017-10-13  Alex Christensen  <achristensen@webkit.org>
3008
3009         Remove Editor::simplifyMarkup
3010         https://bugs.webkit.org/show_bug.cgi?id=178271
3011
3012         Reviewed by Wenson Hsieh.
3013
3014         * WebView/WebView.mm:
3015         (-[WebView _simplifyMarkup:endNode:]):
3016
3017 2017-10-12  Chris Dumez  <cdumez@apple.com>
3018
3019         [Mac] Add support for MouseEvent.buttons
3020         https://bugs.webkit.org/show_bug.cgi?id=178214
3021
3022         Reviewed by Ryosuke Niwa.
3023
3024         * WebView/WebPDFView.mm:
3025         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3026
3027 2017-10-11  Sam Weinig  <sam@webkit.org>
3028
3029         Remove out-parameter variants of copyToVector
3030         https://bugs.webkit.org/show_bug.cgi?id=178155
3031
3032         Reviewed by Tim Horton.
3033
3034         * Plugins/WebNetscapePluginView.mm:
3035         (-[WebNetscapePluginView destroyPlugin]):
3036         * WebView/WebHTMLRepresentation.mm:
3037         (newArrayWithStrings):
3038
3039             Replace out-parameter based copyToVector, with one that returns a Vector.
3040
3041 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
3042
3043         Sanitize URL in pasteboard for other applications and cross origin content
3044         https://bugs.webkit.org/show_bug.cgi?id=178060
3045         <rdar://problem/34874518>
3046
3047         Reviewed by Wenson Hsieh.
3048
3049         * WebCoreSupport/WebPlatformStrategies.h:
3050         * WebCoreSupport/WebPlatformStrategies.mm:
3051         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
3052
3053 2017-10-11  Chris Dumez  <cdumez@apple.com>
3054
3055         Modernize Geolocation code
3056         https://bugs.webkit.org/show_bug.cgi?id=178148
3057
3058         Reviewed by Ryosuke Niwa.
3059
3060         * WebCoreSupport/WebGeolocationClient.h:
3061         * WebCoreSupport/WebGeolocationClient.mm:
3062         (WebGeolocationClient::lastPosition):
3063         * WebView/WebGeolocationPosition.mm:
3064         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
3065         (core):
3066         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
3067         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3068         * WebView/WebGeolocationPositionInternal.h:
3069
3070 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
3071
3072         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
3073         https://bugs.webkit.org/show_bug.cgi?id=178154
3074
3075         Reviewed by Wenson Hsieh.
3076
3077         Enable custom pasteboard data by default.
3078
3079         * WebView/WebPreferenceKeysPrivate.h:
3080         * WebView/WebPreferences.mm:
3081         (+[WebPreferences initialize]):
3082         (-[WebPreferences customPasteboardDataEnabled]): Added.
3083         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
3084         * WebView/WebPreferencesPrivate.h:
3085         * WebView/WebView.mm:
3086         (-[WebView _preferencesChanged:]):
3087
3088 2017-10-10  Sam Weinig  <sam@webkit.org>
3089
3090         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
3091         https://bugs.webkit.org/show_bug.cgi?id=178102
3092
3093         Reviewed by Tim Horton.
3094
3095         * History/WebHistory.mm:
3096         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
3097         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3098         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
3099         * WebCoreSupport/WebUserMediaClient.mm:
3100         (WebUserMediaClient::pageDestroyed):
3101
3102 2017-10-09  Robin Morisset  <rmorisset@apple.com>
3103
3104         Make the names of the options consistent
3105         https://bugs.webkit.org/show_bug.cgi?id=177933
3106
3107         Reviewed by Saam Barati.
3108
3109         * WebView/WebFrame.h:
3110         * WebView/WebHTMLView.mm:
3111         (-[WebHTMLView setMarkedText:selectedRange:]):
3112         * WebView/WebView.h:
3113
3114 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3115
3116         [iOS] Tweak support for classifying form controls (followup to r222487)
3117         https://bugs.webkit.org/show_bug.cgi?id=177917
3118         <rdar://problem/34820122>
3119
3120         Reviewed by Dean Jackson.
3121
3122         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
3123
3124         * DOM/DOMHTMLInputElement.mm:
3125         (-[DOMHTMLInputElement _autofillContext]):
3126         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
3127         (-[DOMHTMLInputElement representingPageURL]): Deleted.
3128
3129 2017-10-05  Keith Miller  <keith_miller@apple.com>
3130
3131         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
3132
3133         * Configurations/WebKitLegacy.xcconfig:
3134
3135 2017-10-05  Jer Noble  <jer.noble@apple.com>
3136
3137         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
3138         https://bugs.webkit.org/show_bug.cgi?id=177261
3139
3140         Reviewed by Eric Carlson.
3141
3142         * Configurations/FeatureDefines.xcconfig:
3143
3144 2017-10-05  Chris Dumez  <cdumez@apple.com>
3145
3146         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3147         https://bugs.webkit.org/show_bug.cgi?id=177957
3148
3149         Reviewed by Alex Christensen.
3150
3151         * WebCoreSupport/WebPlatformStrategies.h:
3152         * WebCoreSupport/WebPlatformStrategies.mm:
3153         (WebPlatformStrategies::cookiesEnabled):
3154
3155 2017-10-05  Youenn Fablet  <youenn@apple.com>
3156
3157         Make LibWebRTCProvider port agnostic
3158         https://bugs.webkit.org/show_bug.cgi?id=177747
3159
3160         Reviewed by Alex Christensen & Alex Garcia.
3161
3162         * WebView/WebView.mm:
3163         (-[WebView _commonInitializationWithFrameName:groupName:]):
3164         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3165
3166 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3167
3168         Stop linking with WebKitSystemInterface
3169         https://bugs.webkit.org/show_bug.cgi?id=177915
3170
3171         Reviewed by Antti Koivisto.
3172
3173         * Configurations/DebugRelease.xcconfig:
3174         * Configurations/WebKitLegacy.xcconfig:
3175
3176 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3177
3178         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
3179         https://bugs.webkit.org/show_bug.cgi?id=177912
3180
3181         Reviewed by Saam Barati.
3182
3183         * Carbon/CarbonUtils.m:
3184         * Carbon/CarbonWindowAdapter.mm:
3185         * Carbon/HIWebView.mm:
3186         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3187         * Misc/WebNSFileManagerExtras.mm:
3188         * Misc/WebNSPasteboardExtras.mm:
3189         * Misc/WebNSURLExtras.mm:
3190         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3191         * Plugins/Hosted/NetscapePluginHostManager.mm:
3192         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3193         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3194         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3195         * Plugins/Hosted/WebTextInputWindowController.m:
3196         * Plugins/WebBaseNetscapePluginView.mm:
3197         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3198         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3199         * Plugins/WebNetscapePluginStream.mm:
3200         * Plugins/WebNetscapePluginView.mm:
3201         * Plugins/WebPluginDatabase.mm:
3202         * WebCoreSupport/PopupMenuMac.mm:
3203         * WebCoreSupport/WebChromeClient.mm:
3204         * WebCoreSupport/WebFrameLoaderClient.mm:
3205         * WebCoreSupport/WebInspectorClient.mm:
3206         * WebCoreSupport/WebPlatformStrategies.mm:
3207         * WebCoreSupport/WebSystemInterface.mm:
3208         * WebView/WebDynamicScrollBarsView.mm:
3209         * WebView/WebFrame.mm:
3210         * WebView/WebFrameView.mm:
3211         * WebView/WebFullScreenController.mm:
3212         * WebView/WebHTMLView.mm:
3213         * WebView/WebPreferences.mm:
3214         * WebView/WebView.mm:
3215
3216 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
3217
3218         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
3219         rdar://problem/34705779
3220
3221         Addressing review comments that I somehow landed without.
3222
3223         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
3224
3225 2017-09-29  Chris Dumez  <cdumez@apple.com>
3226
3227         Split some logic out of VisitedLinkStore and make it reusable
3228         https://bugs.webkit.org/show_bug.cgi?id=177575
3229
3230         Reviewed by Alex Christensen.
3231
3232         * WebCoreSupport/WebVisitedLinkStore.h:
3233         * WebCoreSupport/WebVisitedLinkStore.mm:
3234         (WebVisitedLinkStore::addVisitedLink):
3235         (WebVisitedLinkStore::removeVisitedLink):
3236         (WebVisitedLinkStore::isLinkVisited):
3237         (WebVisitedLinkStore::addVisitedLinkHash):
3238
3239 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
3240
3241         Build fix for High Sierra 32 bit Mac
3242         https://bugs.webkit.org/show_bug.cgi?id=177551
3243         <rdar://problem/34690283>
3244
3245         Reviewed by Alexey Proskuryakov.
3246
3247         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3248         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3249         also made.
3250
3251         * Carbon/CarbonWindowAdapter.mm:
3252         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3253         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3254         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3255         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3256         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3257         (-[CarbonWindowAdapter dealloc]):
3258         (-[CarbonWindowAdapter windowRef]):
3259         (-[CarbonWindowAdapter _hasWindowRef]):
3260         (-[CarbonWindowAdapter _managesWindowRef]):
3261         (-[CarbonWindowAdapter _removeWindowRef]):
3262         (-[CarbonWindowAdapter _carbonWindowClass]):
3263         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3264         (-[CarbonWindowAdapter sendSuperEvent:]):
3265         (-[CarbonWindowAdapter relinquishFocus]):
3266         (-[CarbonWindowAdapter _cancelKey:]):
3267         (-[CarbonWindowAdapter _commonAwake]):
3268         (-[CarbonWindowAdapter _destroyRealWindow:]):
3269         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3270         (-[CarbonWindowAdapter _termWindowIfOwner]):
3271         (-[CarbonWindowAdapter _windowMovedToRect:]):
3272         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3273         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3274         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3275         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3276         (-[CarbonWindowAdapter canBecomeMainWindow]):
3277         (-[CarbonWindowAdapter encodeWithCoder:]):
3278         (-[CarbonWindowAdapter initWithCoder:]):
3279         (-[CarbonWindowAdapter setContentView:]):
3280         (-[CarbonWindowAdapter worksWhenModal]):
3281         (-[CarbonWindowAdapter _setModalWindowLevel]):
3282         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3283         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3284         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3285         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3286         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3287         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3288         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3289         (NSCarbonWindowHandleEvent):
3290         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3291         (-[CarbonWindowAdapter _growBoxRect]):
3292         * Carbon/HIWebView.mm:
3293         (HIWebViewGetWebView):
3294         (HIWebViewConstructor):
3295         (HIWebViewDestructor):
3296         (HIWebViewRegisterClass):
3297         (GetBehaviors):
3298         (Draw):
3299         (HitTest):
3300         (GetRegion):
3301         (GetWindowRef):
3302         (CreateNSEventAdoptingCGEvent):
3303         (CopyEventCGEvent):
3304         (CreateNSEventWithCarbonClickEvent):
3305         (Click):
3306         (CreateNSEventWithCarbonEvent):
3307         (MouseUp):
3308         (CreateNSEventWithCarbonMouseMoveEvent):
3309         (MouseMoved):
3310         (MouseDragged):
3311         (MouseWheelMoved):
3312         (ContextMenuClick):
3313         (GetKind):
3314         (BoundsChanged):
3315         (OwningWindowChanged):
3316         (WindowHandler):
3317         (SyncFrame):
3318         (SetFocusPart):
3319         (AdvanceFocus):
3320         (RelinquishFocus):
3321         (ActiveStateChanged):
3322         (ProcessCommand):
3323         (UpdateCommandStatus):
3324         (_NSSelectorForHICommand):
3325         (HIWebViewEventHandler):
3326         (StartUpdateObserver):
3327         (StopUpdateObserver):
3328         (UpdateObserver):
3329
3330 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3331
3332         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
3333         https://bugs.webkit.org/show_bug.cgi?id=172526
3334         <rdar://problem/32396081>
3335
3336         Reviewed by Ryosuke Niwa.
3337
3338         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
3339
3340         * WebCoreSupport/WebPlatformStrategies.h:
3341         * WebCoreSupport/WebPlatformStrategies.mm:
3342         (WebPlatformStrategies::webExposedTypes):
3343         (WebPlatformStrategies::writeCustomData):
3344
3345 2017-09-27  Matt Lewis  <jlewis3@apple.com>
3346
3347         Unreviewed, rolling out r222567.
3348
3349         This broke and internal build.
3350
3351         Reverted changeset:
3352
3353         "Build fix for High Sierra 32 bit Mac"
3354         https://bugs.webkit.org/show_bug.cgi?id=177551
3355         http://trac.webkit.org/changeset/222567
3356
3357 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
3358
3359         Build fix for High Sierra 32 bit Mac
3360         https://bugs.webkit.org/show_bug.cgi?id=177551
3361         <rdar://problem/34690283>
3362
3363         Reviewed by Alexey Proskuryakov.
3364
3365         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3366         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3367         also made.
3368
3369         * Carbon/CarbonWindowAdapter.mm:
3370         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3371         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3372         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3373         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3374         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3375         (-[CarbonWindowAdapter dealloc]):
3376         (-[CarbonWindowAdapter windowRef]):
3377         (-[CarbonWindowAdapter _hasWindowRef]):
3378         (-[CarbonWindowAdapter _managesWindowRef]):
3379         (-[CarbonWindowAdapter _removeWindowRef]):
3380         (-[CarbonWindowAdapter _carbonWindowClass]):
3381         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3382         (-[CarbonWindowAdapter sendSuperEvent:]):
3383         (-[CarbonWindowAdapter relinquishFocus]):
3384         (-[CarbonWindowAdapter _cancelKey:]):
3385         (-[CarbonWindowAdapter _commonAwake]):
3386         (-[CarbonWindowAdapter _destroyRealWindow:]):
3387         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3388         (-[CarbonWindowAdapter _termWindowIfOwner]):
3389         (-[CarbonWindowAdapter _windowMovedToRect:]):
3390         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3391         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3392         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3393         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3394         (-[CarbonWindowAdapter canBecomeMainWindow]):
3395         (-[CarbonWindowAdapter encodeWithCoder:]):
3396         (-[CarbonWindowAdapter initWithCoder:]):
3397         (-[CarbonWindowAdapter setContentView:]):
3398         (-[CarbonWindowAdapter worksWhenModal]):
3399         (-[CarbonWindowAdapter _setModalWindowLevel]):
3400         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3401         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3402         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3403         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3404         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3405         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3406         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3407         (NSCarbonWindowHandleEvent):
3408         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3409         (-[CarbonWindowAdapter _growBoxRect]):
3410         * Carbon/HIWebView.mm:
3411         (HIWebViewGetWebView):
3412         (HIWebViewConstructor):
3413         (HIWebViewDestructor):
3414         (HIWebViewRegisterClass):
3415         (GetBehaviors):
3416         (Draw):
3417         (HitTest):
3418         (GetRegion):
3419         (GetWindowRef):
3420         (CreateNSEventAdoptingCGEvent):
3421         (CopyEventCGEvent):
3422         (CreateNSEventWithCarbonClickEvent):
3423         (Click):
3424         (CreateNSEventWithCarbonEvent):
3425         (MouseUp):
3426         (CreateNSEventWithCarbonMouseMoveEvent):
3427         (MouseMoved):
3428         (MouseDragged):
3429         (MouseWheelMoved):
3430         (ContextMenuClick):
3431         (GetKind):
3432         (BoundsChanged):
3433         (OwningWindowChanged):
3434         (WindowHandler):
3435         (SyncFrame):
3436         (SetFocusPart):
3437         (AdvanceFocus):
3438         (RelinquishFocus):
3439         (ActiveStateChanged):
3440         (ProcessCommand):
3441         (UpdateCommandStatus):
3442         (_NSSelectorForHICommand):
3443         (HIWebViewEventHandler):
3444         (StartUpdateObserver):
3445         (StopUpdateObserver):
3446         (UpdateObserver):
3447
3448 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3449
3450         Make PolicyAction an encodable enum class
3451         https://bugs.webkit.org/show_bug.cgi?id=177480
3452
3453         Reviewed by Antti Koivisto.
3454
3455         * Plugins/WebPluginContainerCheck.mm:
3456         (-[WebPluginContainerCheck _continueWithPolicy:]):
3457         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3458         * WebCoreSupport/WebFrameLoaderClient.mm:
3459         (-[WebFramePolicyListener invalidate]):
3460         (-[WebFramePolicyListener ignore]):
3461         (-[WebFramePolicyListener download]):
3462         (-[WebFramePolicyListener use]):
3463         (-[WebFramePolicyListener continue]):
3464         * WebView/WebPolicyDelegate.mm:
3465         (-[WebPolicyDecisionListener use]):
3466         (-[WebPolicyDecisionListener ignore]):
3467         (-[WebPolicyDecisionListener download]):
3468
3469 2017-09-25  Frederik Riedel  <riedel@apple.com>
3470
3471         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3472         https://bugs.webkit.org/show_bug.cgi?id=174394
3473         <rdar://problem/33183504>
3474
3475         Reviewed by Ryosuke Niwa.
3476
3477         * DOM/DOMHTMLInputElement.h:
3478         * DOM/DOMHTMLInputElement.mm:
3479         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3480         Determines if this HTMLInputElement is part of a login screen.
3481         (-[DOMHTMLInputElement representingPageUrl]):
3482         Returns the webpage's URL that is currently displayed in the Web View.
3483         (-[DOMHTMLInputElement insertTextSuggestion:]):
3484         Inserts login credentials into the Web View.
3485
3486 2017-09-25  Sam Weinig  <sam@webkit.org>
3487
3488         Remove unused EditorClient functions
3489         https://bugs.webkit.org/show_bug.cgi?id=177463
3490
3491         Reviewed by Alex Christensen.
3492
3493         Remove unused EditorClient functions.
3494
3495         * WebCoreSupport/WebEditorClient.h:
3496         * WebCoreSupport/WebEditorClient.mm:
3497         (WebEditorClient::canonicalizeURL): Deleted.
3498         (WebEditorClient::canonicalizeURLString): Deleted.
3499         (WebEditorClient::writeDataToPasteboard): Deleted.
3500         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3501         (WebEditorClient::readDataFromPasteboard): Deleted.
3502         (WebEditorClient::pasteboardChangeCount): Deleted.
3503
3504 2017-09-25  Alex Christensen  <achristensen@webkit.org>