Delete WebMetal implementation in favor of WebGPU
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Delete WebMetal implementation in favor of WebGPU
4         https://bugs.webkit.org/show_bug.cgi?id=195418
5
6         Reviewed by Dean Jackson.
7
8         * Configurations/FeatureDefines.xcconfig:
9         * WebView/WebPreferenceKeysPrivate.h:
10         * WebView/WebPreferences.mm:
11         (+[WebPreferences initialize]):
12         (-[WebPreferences webMetalEnabled]): Deleted.
13         (-[WebPreferences setWebMetalEnabled:]): Deleted.
14         * WebView/WebPreferencesPrivate.h:
15         * WebView/WebView.mm:
16         (-[WebView _preferencesChanged:]):
17
18 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
19
20         Implement ResizeObserver.
21         https://bugs.webkit.org/show_bug.cgi?id=157743
22
23         Reviewed by Simon Fraser.
24
25         * Configurations/FeatureDefines.xcconfig:
26         * WebView/WebPreferenceKeysPrivate.h:
27         * WebView/WebPreferences.mm:
28         (+[WebPreferences initialize]):
29         (-[WebPreferences resizeObserverEnabled]):
30         (-[WebPreferences setResizeObserverEnabled:]):
31         * WebView/WebPreferencesPrivate.h:
32         * WebView/WebView.mm:
33         (-[WebView _preferencesChanged:]):
34         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
35
36 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
37
38         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
39         https://bugs.webkit.org/show_bug.cgi?id=196336
40
41         Reviewed by Tim Horton.
42
43         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
44
45         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
46
47         * WebCoreSupport/PopupMenuMac.mm:
48         (PopupMenuMac::hide):
49
50 2019-03-25  Andy Estes  <aestes@apple.com>
51
52         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
53         https://bugs.webkit.org/show_bug.cgi?id=194964
54         <rdar://problem/48279441>
55
56         Reviewed by Alex Christensen.
57
58         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
59         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
60         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
61         PreviewLoaderClient alive for its lifetime. This ensures that as long as
62         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
63         by WebKit.
64
65         * WebCoreSupport/WebFrameLoaderClient.mm:
66         (WebFrameLoaderClient::createPreviewLoaderClient):
67         * WebView/WebDataSource.mm:
68         (-[WebDataSource _quickLookPreviewLoaderClient]):
69         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
70         * WebView/WebDataSourceInternal.h:
71
72 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
73
74         Remove NavigatorContentUtils in WebCore/Modules
75         https://bugs.webkit.org/show_bug.cgi?id=196070
76
77         Reviewed by Alex Christensen.
78
79         NavigatorContentUtils was to support the custom scheme spec [1].
80         However, in WebKit side, no port has supported the feature in
81         WebKit layer after EFL port was removed. So there has been the
82         only IDL implementation of the NavigatorContentUtils in WebCore.
83         So we don't need to keep the implementation in WebKit.
84
85         * Configurations/FeatureDefines.xcconfig:
86
87 2019-03-22  Keith Rollin  <krollin@apple.com>
88
89         Enable ThinLTO support in Production builds
90         https://bugs.webkit.org/show_bug.cgi?id=190758
91         <rdar://problem/45413233>
92
93         Reviewed by Daniel Bates.
94
95         Enable building with Thin LTO in Production when using Xcode 10.2 or
96         later. This change results in a 1.45% progression in PLT5. Full
97         Production build times increase about 2-3%. Incremental build times
98         are more severely affected, and so LTO is not enabled for local
99         engineering builds.
100
101         LTO is enabled only on macOS for now, until rdar://problem/49013399,
102         which affects ARM builds, is fixed.
103
104         To change the LTO setting when building locally:
105
106         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
107           command line.
108         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
109           on the command line.
110         - If building with `build-root`, specify --lto={none,thin,full} on the
111           command line.
112         - If building with Xcode, create a LocalOverrides.xcconfig file at the
113           top level of your repository directory (if needed) and define
114           WK_LTO_MODE to full, thin, or none.
115
116         * Configurations/Base.xcconfig:
117
118 2019-03-21  Andy Estes  <aestes@apple.com>
119
120         [iOS] Apple Pay should be available in documents with no user agent scripts
121         https://bugs.webkit.org/show_bug.cgi?id=196061
122         <rdar://problem/48649391>
123
124         Reviewed by Brady Eidson.
125
126         * WebView/WebFrame.mm:
127         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
128
129 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
130
131         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
132         https://bugs.webkit.org/show_bug.cgi?id=196049
133
134         Reviewed by Tim Horton.
135
136         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
137         overflow scrolling in general, so rename it.
138
139         * Configurations/FeatureDefines.xcconfig:
140
141 2019-03-13  Dean Jackson  <dino@apple.com>
142
143         Block all plugins smaller than 5x5px
144         https://bugs.webkit.org/show_bug.cgi?id=195702
145         <rdar://problem/28435204>
146
147         Reviewed by Sam Weinig.
148
149         Removed a function that was never being called.
150
151         * WebCoreSupport/WebFrameLoaderClient.h:
152         * WebCoreSupport/WebFrameLoaderClient.mm:
153         (WebFrameLoaderClient::recreatePlugin): Deleted.
154
155 2019-03-13  Keith Rollin  <krollin@apple.com>
156
157         Add support for new StagedFrameworks layout
158         https://bugs.webkit.org/show_bug.cgi?id=195543
159
160         Reviewed by Alexey Proskuryakov.
161
162         When creating the WebKit layout for out-of-band Safari/WebKit updates,
163         use an optional path prefix when called for.
164
165         * Configurations/WebKitLegacy.xcconfig:
166
167 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
168
169         Remove a site specific hack for AppleConnect plugin
170         https://bugs.webkit.org/show_bug.cgi?id=195643
171
172         Reviewed by Simon Fraser.
173
174         r66437 added a workaround for AppleConnect plugin.
175
176         Remove this code since Safari doesn't even use WebKitLegacy anymore,
177         and other WebKit clients support AppleConnect plugins.
178
179         * WebCoreSupport/WebFrameLoaderClient.mm:
180         (WebFrameLoaderClient::createPlugin):
181
182 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
183
184         Unreviewed, rolling out r242688, r242643, r242624.
185
186         Caused multiple layout test failures and crashes on iOS and macOS.
187
188         Reverted changeset:
189
190         "requestAnimationFrame should execute before the next frame"
191         https://bugs.webkit.org/show_bug.cgi?id=177484
192         https://trac.webkit.org/changeset/242624/webkit
193
194         * WebView/WebView.mm:
195         (-[WebView _viewWillDrawInternal]):
196
197 2019-03-09  Andy Estes  <aestes@apple.com>
198
199         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
200         https://bugs.webkit.org/show_bug.cgi?id=195526
201         <rdar://problem/48745636>
202
203         Reviewed by Chris Dumez.
204
205         * WebCoreSupport/WebPaymentCoordinatorClient.h:
206         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
207         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
208         (WebPaymentCoordinatorClient::openPaymentSetup):
209
210 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
211
212         requestAnimationFrame should execute before the next frame
213         https://bugs.webkit.org/show_bug.cgi?id=177484
214
215         Reviewed by Simon Fraser.
216
217         * WebView/WebView.mm:
218         (-[WebView _viewWillDrawInternal]):
219         Call Page::renderingUpdate() which implements  "Update the rendering"
220         step of the HTML Event Loop specification.
221
222 2019-03-07  Zalan Bujtas  <zalan@apple.com>
223
224         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
225         https://bugs.webkit.org/show_bug.cgi?id=195353
226         <rdar://problem/48626394>
227
228         Reviewed by Simon Fraser.
229
230         * WebView/WebPreferenceKeysPrivate.h:
231         * WebView/WebPreferences.mm:
232         (+[WebPreferences initialize]):
233         (-[WebPreferences contentChangeObserverEnabled]):
234         (-[WebPreferences setContentChangeObserverEnabled:]):
235         * WebView/WebPreferencesPrivate.h:
236         * WebView/WebView.mm:
237         (-[WebView _preferencesChanged:]):
238
239 2019-03-06  Sam Weinig  <sam@webkit.org>
240
241         WebKitLegacy does not need to generate an export file for i386 anymore
242         https://bugs.webkit.org/show_bug.cgi?id=195380
243
244         Reviewed by Dan Bernstein.
245
246         * Configurations/WebKitLegacy.xcconfig:
247         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
248         It still needs to be generated, since we are concatenating the shared exports
249         file with a macOS or iOS specific one.
250
251         * WebKit.mac.exp:
252         Remove i386 specific symbols that we were previously stripping.
253
254 2019-03-06  Rob Buis  <rbuis@igalia.com>
255
256         Consider supporting the `referrerpolicy` attribute.
257         https://bugs.webkit.org/show_bug.cgi?id=179053
258
259         Reviewed by Darin Adler.
260
261         Add a runtime flag for referrerpolicy attribute.
262
263         * WebView/WebPreferenceKeysPrivate.h:
264         * WebView/WebPreferences.mm:
265         (+[WebPreferences initialize]):
266         (-[WebPreferences referrerPolicyAttributeEnabled]):
267         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
268         * WebView/WebPreferencesPrivate.h:
269         * WebView/WebView.mm:
270         (-[WebView _preferencesChanged:]):
271
272 2019-03-03  Tim Horton  <timothy_horton@apple.com>
273
274         Remove some more unused 32-bit code
275         https://bugs.webkit.org/show_bug.cgi?id=195255
276
277         Reviewed by Darin Adler.
278
279         * Plugins/WebNetscapePluginEventHandler.mm:
280         (WebNetscapePluginEventHandler::create):
281         * Plugins/WebNetscapePluginView.h:
282         * Plugins/WebNetscapePluginView.mm:
283         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
284         (-[WebNetscapePluginView restorePortState:]):
285         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
286         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
287         (-[WebNetscapePluginView updateAndSetWindow]):
288         (-[WebNetscapePluginView setWindowIfNecessary]):
289         (-[WebNetscapePluginView createPlugin]):
290         (-[WebNetscapePluginView fini]):
291         (-[WebNetscapePluginView drawRect:]):
292         (-[WebNetscapePluginView invalidateRegion:]):
293         (-[WebNetscapePluginView getVariable:value:]):
294         (-[WebNetscapePluginView setVariable:value:]):
295         (isDrawingModelQuickDraw): Deleted.
296         (-[WebNetscapePluginView fixWindowPort]): Deleted.
297         (getQDPixelFormatForBitmapContext): Deleted.
298         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
299         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
300         * WebView/WebDelegateImplementationCaching.mm:
301
302 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
305         https://bugs.webkit.org/show_bug.cgi?id=195053
306         <rdar://problem/48134710>
307
308         Reviewed by Ryosuke Niwa.
309
310         * WebCoreSupport/WebEditorClient.h:
311
312 2019-03-01  Tim Horton  <timothy_horton@apple.com>
313
314         Remove unused code in WebKitLegacy
315         https://bugs.webkit.org/show_bug.cgi?id=189614
316
317         Reviewed by Simon Fraser.
318
319         * Carbon/CarbonUtils.h: Removed.
320         * Carbon/CarbonUtils.m: Removed.
321         * Carbon/CarbonWindowAdapter.h: Removed.
322         * Carbon/CarbonWindowAdapter.mm: Removed.
323         * Carbon/CarbonWindowContentView.h: Removed.
324         * Carbon/CarbonWindowContentView.m: Removed.
325         * Carbon/CarbonWindowFrame.h: Removed.
326         * Carbon/CarbonWindowFrame.m: Removed.
327         * Carbon/HIViewAdapter.h: Removed.
328         * Carbon/HIViewAdapter.m: Removed.
329         * Carbon/HIWebView.h: Removed.
330         * Carbon/HIWebView.mm: Removed.
331         * Configurations/WebKitLegacy.xcconfig:
332         * WebKit.mac.exp:
333
334 2019-03-01  Justin Fan  <justin_fan@apple.com>
335
336         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
337         https://bugs.webkit.org/show_bug.cgi?id=195191
338
339         Rubber-stamped by Dean Jackson.
340
341         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
342
343         * Configurations/FeatureDefines.xcconfig:
344
345 2019-02-28  Antoine Quint  <graouts@apple.com>
346
347         Enable the Pointer Events runtime flag by default
348         https://bugs.webkit.org/show_bug.cgi?id=195156
349
350         Reviewed by Dean Jackson.
351
352         * WebView/WebPreferences.mm:
353         (+[WebPreferences initialize]):
354
355 2019-02-28  Justin Fan  <justin_fan@apple.com>
356
357         [Web GPU] Enable Web GPU only on 64-bit
358         https://bugs.webkit.org/show_bug.cgi?id=195139
359
360         Because Metal is only supported on 64 bit apps.
361
362         Unreviewed build fix.
363
364         * Configurations/FeatureDefines.xcconfig:
365
366 2019-02-27  Antoine Quint  <graouts@apple.com>
367
368         Support Pointer Events on macOS
369         https://bugs.webkit.org/show_bug.cgi?id=195008
370         <rdar://problem/47454419>
371
372         Reviewed by Dean Jackson.
373
374         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
375
376         * Configurations/FeatureDefines.xcconfig:
377         * WebView/WebPreferenceKeysPrivate.h:
378         * WebView/WebPreferences.mm:
379         (+[WebPreferences initialize]):
380         (-[WebPreferences pointerEventsEnabled]):
381         (-[WebPreferences setPointerEventsEnabled:]):
382         * WebView/WebPreferencesPrivate.h:
383         * WebView/WebView.mm:
384         (-[WebView _preferencesChanged:]):
385
386 2019-02-23  Keith Miller  <keith_miller@apple.com>
387
388         Add new mac target numbers
389         https://bugs.webkit.org/show_bug.cgi?id=194955
390
391         Reviewed by Tim Horton.
392
393         * Configurations/Base.xcconfig:
394         * Configurations/DebugRelease.xcconfig:
395
396 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
397
398         Hardcode Visual Viewports on everywhere except iOS WK1
399         https://bugs.webkit.org/show_bug.cgi?id=194928
400
401         Reviewed by Zalan Bujtas.
402
403         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
404         change the default value of the Setting to 'true', and hardcode WebView on iOS to
405         set it to false. The setting has shipped for several years and there's no need to turn
406         it off now.
407
408         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
409         Visual Viewports are not enabled.
410         
411         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
412         that only runs in WK2
413
414         * WebView/WebPreferenceKeysPrivate.h:
415         * WebView/WebPreferences.mm:
416         (+[WebPreferences initialize]):
417         (-[WebPreferences visualViewportEnabled]): Deleted.
418         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
419         * WebView/WebPreferencesPrivate.h:
420         * WebView/WebView.mm:
421         (-[WebView _preferencesChanged:]):
422
423 2019-02-21  Darin Adler  <darin@apple.com>
424
425         Some refinements for Node and Document
426         https://bugs.webkit.org/show_bug.cgi?id=194764
427
428         Reviewed by Ryosuke Niwa.
429
430         * DOM/DOMDocument.mm:
431         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
432         through to WebCore or even looking at the arguments.
433         (-[DOMDocument getOverrideStyle::]): Ditto.
434
435 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
436
437         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
438         https://bugs.webkit.org/show_bug.cgi?id=194670
439         <rdar://problem/39066529>
440
441         Reviewed by Tim Horton.
442
443         * WebCoreSupport/WebEditorClient.h:
444         * WebCoreSupport/WebEditorClient.mm:
445         (WebEditorClient::replacementURLForResource): Deleted.
446         * WebCoreSupport/WebPlatformStrategies.h:
447         * WebCoreSupport/WebPlatformStrategies.mm:
448         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
449
450 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
451
452         Add MSE logging configuration
453         https://bugs.webkit.org/show_bug.cgi?id=194719
454         <rdar://problem/48122151>
455
456         Reviewed by Joseph Pecoraro.
457
458         * WebCoreSupport/WebChromeClient.mm:
459         (stringForMessageSource): Recognize the MSE message source.
460
461 2019-02-17  David Kilzer  <ddkilzer@apple.com>
462
463         Unreviewed, rolling out r241620.
464
465         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
466         (Requested by ddkilzer on #webkit.)
467
468         Reverted changeset:
469
470         "[WTF] Add environment variable helpers"
471         https://bugs.webkit.org/show_bug.cgi?id=192405
472         https://trac.webkit.org/changeset/241620
473
474 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
475
476         [WTF] Add environment variable helpers
477         https://bugs.webkit.org/show_bug.cgi?id=192405
478
479         Reviewed by Michael Catanzaro.
480
481         * WebView/WebView.mm:
482         (-[WebView _initWithFrame:frameName:groupName:]):
483         Utilize WTF::Environment where possible.
484
485 2019-02-15  Brian Burg  <bburg@apple.com>
486
487         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
488         https://bugs.webkit.org/show_bug.cgi?id=194411
489         <rdar://problem/47787614>
490
491         Reviewed by Joseph Pecoraro.
492
493         * Configurations/WebKitLegacy.xcconfig:
494         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
495
496         * WebCoreSupport/WebInspectorClient.mm:
497         (WebInspectorFrontendClient::localizedStringsURL):
498         (-[WebInspectorWindowController inspectorPagePath]):
499         (-[WebInspectorWindowController inspectorTestPagePath]):
500         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
501
502 2019-02-15  Commit Queue  <commit-queue@webkit.org>
503
504         Unreviewed, rolling out r241559 and r241566.
505         https://bugs.webkit.org/show_bug.cgi?id=194710
506
507         Causes layout test crashes under GuardMalloc (Requested by
508         ryanhaddad on #webkit).
509
510         Reverted changesets:
511
512         "[WTF] Add environment variable helpers"
513         https://bugs.webkit.org/show_bug.cgi?id=192405
514         https://trac.webkit.org/changeset/241559
515
516         "Unreviewed build fix for WinCairo Debug after r241559."
517         https://trac.webkit.org/changeset/241566
518
519 2019-02-15  Truitt Savell  <tsavell@apple.com>
520
521         Unreviewed, rolling out r241564.
522
523         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
524
525         Reverted changeset:
526
527         "[Mac] WebInspectorUI.framework does not need to be soft-
528         linked anymore"
529         https://bugs.webkit.org/show_bug.cgi?id=194411
530         https://trac.webkit.org/changeset/241564
531
532 2019-02-14  Brian Burg  <bburg@apple.com>
533
534         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
535         https://bugs.webkit.org/show_bug.cgi?id=194411
536         <rdar://problem/47787614>
537
538         Reviewed by Joseph Pecoraro.
539
540         * Configurations/WebKitLegacy.xcconfig:
541         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
542
543         * WebCoreSupport/WebInspectorClient.mm:
544         (WebInspectorFrontendClient::localizedStringsURL):
545         (-[WebInspectorWindowController inspectorPagePath]):
546         (-[WebInspectorWindowController inspectorTestPagePath]):
547         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
548
549 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
550
551         [WTF] Add environment variable helpers
552         https://bugs.webkit.org/show_bug.cgi?id=192405
553
554         Reviewed by Michael Catanzaro.
555
556         * WebView/WebView.mm:
557         (-[WebView _initWithFrame:frameName:groupName:]):
558         Utilize WTF::Environment where possible.
559
560 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
561
562         Allow pages to trigger programmatic paste from script on iOS
563         https://bugs.webkit.org/show_bug.cgi?id=194271
564         <rdar://problem/47808810>
565
566         Reviewed by Ryosuke Niwa.
567
568         See WebCore and WebKit ChangeLogs for more details.
569
570         * WebCoreSupport/WebEditorClient.h:
571
572 2019-02-12  Andy Estes  <aestes@apple.com>
573
574         [iOSMac] Enable Parental Controls Content Filtering
575         https://bugs.webkit.org/show_bug.cgi?id=194521
576         <rdar://39732376>
577
578         Reviewed by Tim Horton.
579
580         * Configurations/FeatureDefines.xcconfig:
581
582 2019-02-06  Andy Estes  <aestes@apple.com>
583
584         [Payment Request] It should be possible to require a phonetic name for shipping contacts
585         https://bugs.webkit.org/show_bug.cgi?id=194311
586         <rdar://46733045>
587
588         Reviewed by Alex Christensen.
589
590         * WebCoreSupport/WebPaymentCoordinatorClient.h:
591         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
592         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
593
594 2019-02-04  Said Abou-Hallawa  <said@apple.com>
595
596         [CG] Enable setAdditionalSupportedImageTypes for WK1
597         https://bugs.webkit.org/show_bug.cgi?id=194190
598
599         Reviewed by Tim Horton.
600
601         1. Define the preferences key AdditionalSupportedImageTypes.
602         2. Add additionalSupportedImageTypes as a private preference property.
603         3. Define the setter and the getter of the property.
604         4. Add function to convert from an id to an array of strings.
605         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
606
607         * WebView/WebPreferenceKeysPrivate.h:
608         * WebView/WebPreferences.mm:
609         (-[WebPreferences _stringArrayValueForKey:]):
610         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
611         (-[WebPreferences setAdditionalSupportedImageTypes:]):
612         (-[WebPreferences additionalSupportedImageTypes]):
613         * WebView/WebPreferencesPrivate.h:
614         * WebView/WebView.mm:
615         (-[WebView _preferencesChanged:]):
616
617 2019-02-04  Timothy Hatcher  <timothy@apple.com>
618
619         Add WebView SPI to temporarily force light or dark appearance on a page.
620         https://bugs.webkit.org/show_bug.cgi?id=194230
621
622         Reviewed by Tim Horton.
623
624         * WebView/WebView.mm:
625         (-[WebView _useDarkAppearance:]): Added.
626         (-[WebView _setUseDarkAppearance:]): Added.
627         * WebView/WebViewPrivate.h:
628
629 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
630
631         PageOverlayController's layers should be created lazily
632         https://bugs.webkit.org/show_bug.cgi?id=194199
633         rdar://problem/46571593
634
635         Reviewed by Tim Horton.
636
637         * WebCoreSupport/WebChromeClient.h:
638         * WebCoreSupport/WebChromeClient.mm:
639         (WebChromeClient::attachViewOverlayGraphicsLayer):
640
641 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
642
643         Make setNeedsLayout on the root more explicitly about triggering its side-effects
644         https://bugs.webkit.org/show_bug.cgi?id=194198
645
646         Reviewed by Antti Koivisto.
647
648         Call the newly named functions.
649
650         * WebView/WebFrame.mm:
651         (-[WebFrame setNeedsLayout]):
652         * WebView/WebHTMLView.mm:
653         (-[WebHTMLView setNeedsLayout:]):
654
655 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
658         https://bugs.webkit.org/show_bug.cgi?id=194189
659
660         Reviewed by Geoffrey Garen.
661
662         Pass the policy check identifier around functions and store it in WebFramePolicyListener
663         so that we can send it back to WebCore with the navigation policy decision.
664
665         * WebCoreSupport/WebFrameLoaderClient.h:
666         * WebCoreSupport/WebFrameLoaderClient.mm:
667         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
668         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
669         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
670         (WebFrameLoaderClient::dispatchWillSubmitForm):
671         (WebFrameLoaderClient::setUpPolicyListener):
672         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
673         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
674         (-[WebFramePolicyListener invalidate]):
675         (-[WebFramePolicyListener dealloc]):
676         (-[WebFramePolicyListener receivedPolicyDecision:]):
677         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
678         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
679
680 2019-01-31  Alex Christensen  <achristensen@webkit.org>
681
682         Revert r238819 which is unneeded and caused a performance regression.
683         https://bugs.webkit.org/show_bug.cgi?id=192272
684         <rdar://problem/46664625>
685
686         * WebCoreSupport/WebFrameLoaderClient.h:
687         * WebCoreSupport/WebFrameLoaderClient.mm:
688         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
689
690 2019-01-28  Devin Rousso  <drousso@apple.com>
691
692         Web Inspector: provide a way to edit page WebRTC settings on a remote target
693         https://bugs.webkit.org/show_bug.cgi?id=193863
694         <rdar://problem/47572764>
695
696         Reviewed by Joseph Pecoraro.
697
698         * WebView/WebView.mm:
699         (-[WebView _preferencesChanged:]):
700         Add page-level settings for WebRTC preferences.
701
702 2019-01-28  Andy Estes  <aestes@apple.com>
703
704         [watchOS] Enable Parental Controls content filtering
705         https://bugs.webkit.org/show_bug.cgi?id=193939
706         <rdar://problem/46641912>
707
708         Reviewed by Ryosuke Niwa.
709
710         * Configurations/FeatureDefines.xcconfig:
711
712 2019-01-28  Timothy Hatcher  <timothy@apple.com>
713
714         Make it easier for non-Apple ports to enable dark mode CSS support.
715         https://bugs.webkit.org/show_bug.cgi?id=193882
716
717         Reviewed by Megan Gardner.
718
719         * WebView/WebView.mm:
720         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
721         (-[WebView _effectiveAppearanceIsDark]): Ditto.
722
723 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
724
725         AX: Introduce a static accessibility tree
726         https://bugs.webkit.org/show_bug.cgi?id=193348
727         <rdar://problem/47203295>
728
729         Reviewed by Ryosuke Niwa.
730
731         * Configurations/FeatureDefines.xcconfig:
732
733 2019-01-25  Keith Rollin  <krollin@apple.com>
734
735         Update WebKitAdditions.xcconfig with correct order of variable definitions
736         https://bugs.webkit.org/show_bug.cgi?id=193793
737         <rdar://problem/47532439>
738
739         Reviewed by Alex Christensen.
740
741         XCBuild changes the way xcconfig variables are evaluated. In short,
742         all config file assignments are now considered in part of the
743         evaluation. When using the new build system and an .xcconfig file
744         contains multiple assignments of the same build setting:
745
746         - Later assignments using $(inherited) will inherit from earlier
747           assignments in the xcconfig file.
748         - Later assignments not using $(inherited) will take precedence over
749           earlier assignments. An assignment to a more general setting will
750           mask an earlier assignment to a less general setting. For example,
751           an assignment without a condition ('FOO = bar') will completely mask
752           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
753
754         This affects some of our .xcconfig files, in that sometimes platform-
755         or sdk-specific definitions appear before the general definitions.
756         Under the new evaluations rules, the general definitions alway take
757         effect because they always overwrite the more-specific definitions. The
758         solution is to swap the order, so that the general definitions are
759         established first, and then conditionally overwritten by the
760         more-specific definitions.
761
762         * Configurations/Version.xcconfig:
763         * Configurations/WebKitLegacy.xcconfig:
764
765 2019-01-25  David Kilzer  <ddkilzer@apple.com>
766
767         Move soft-linking of Lookup.framework out of LookupSPI.h
768         <https://webkit.org/b/193815>
769
770         Reviewed by Tim Horton.
771
772         * WebView/WebImmediateActionController.mm:
773         (-[WebImmediateActionController _animationControllerForText]):
774         * WebView/WebView.mm:
775         (-[WebView _prepareForDictionaryLookup]):
776         - Move soft-linking to LookupSoftLink.{h,mm}.
777
778 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
781         https://bugs.webkit.org/show_bug.cgi?id=193829
782
783         Reviewed by Tim Horton.
784
785         * WebCoreSupport/WebDragClient.mm:
786         (WebDragClient::didConcludeEditDrag):
787         * WebView/WebView.mm:
788         (-[WebView _requestStartDataInteraction:globalPosition:]):
789         (-[WebView _didConcludeEditDrag]):
790         (-[WebView _didConcludeEditDataInteraction]): Deleted.
791         * WebView/WebViewInternal.h:
792
793 2019-01-24  John Wilander  <wilander@apple.com>
794
795         Add Ad Click Attribution as an internal/experimental feature
796         https://bugs.webkit.org/show_bug.cgi?id=193685
797         <rdar://problem/47450399>
798
799         Reviewed by Brent Fulgham.
800
801         * WebView/WebPreferenceKeysPrivate.h:
802         * WebView/WebPreferences.mm:
803         (+[WebPreferences initialize]):
804         (-[WebPreferences adClickAttributionEnabled]):
805         (-[WebPreferences setAdClickAttributionEnabled:]):
806             Added support for experimental ad click attribution.
807         * WebView/WebPreferencesPrivate.h:
808         * WebView/WebView.mm:
809         (-[WebView _preferencesChanged:]):
810
811 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
812
813         Move FileSystem to WTF
814         https://bugs.webkit.org/show_bug.cgi?id=193602
815
816         Reviewed by Yusuke Suzuki.
817
818         * Misc/WebNSFileManagerExtras.mm:
819         * Storage/WebDatabaseProvider.mm:
820         * WebView/WebView.mm:
821
822 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
823
824         Fix the Apple Internal build. See <rdar://problem/47491383>.
825
826         Rubber-stamped by Tim Horton.
827
828         * WebCoreSupport/WebFrameLoaderClient.mm:
829
830 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
831
832         Clean up USE(WEB_THREAD)
833         https://bugs.webkit.org/show_bug.cgi?id=193698
834
835         Rubber-stamped by Tim Horton.
836
837         * Misc/WebCache.mm:
838         (+[WebCache emptyInMemoryResources]):
839         * WebCoreSupport/WebFrameLoaderClient.mm:
840         (-[WebFramePolicyListener use]):
841         * WebCoreSupport/WebGeolocationClient.mm:
842         (-[WebGeolocationPolicyListener allow]):
843         (-[WebGeolocationPolicyListener deny]):
844         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
845         * WebView/WebFrame.mm:
846         (-[WebFrame deviceOrientationChanged]):
847         * WebView/WebHTMLView.mm:
848         (hardwareKeyboardAvailabilityChangedCallback):
849         * WebView/WebView.mm:
850         (+[WebView _releaseMemoryNow]):
851         (+[WebView willEnterBackgroundWithCompletionHandler:]):
852         (-[WebView updateLayoutIgnorePendingStyleSheets]):
853         (-[WebView _dispatchUnloadEvent]):
854         (-[WebView _close]):
855         (-[WebView _preferencesChangedNotification:]):
856         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
857         (-[WebView goBack]):
858         (-[WebView goForward]):
859         (+[WebView _cacheModelChangedNotification:]):
860         (-[WebView stopLoading:]):
861         (-[WebView stopLoadingAndClear]):
862         (-[WebView reload:]):
863         (WebInstallMemoryPressureHandler):
864
865 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
866
867         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
868         https://bugs.webkit.org/show_bug.cgi?id=193706
869         <rdar://problem/44807048>
870
871         Reviewed by Ryosuke Niwa.
872
873         Use UndoStep::label().
874
875         * WebCoreSupport/WebEditorClient.h:
876         * WebCoreSupport/WebEditorClient.mm:
877         (-[WebUndoStep initWithUndoStep:]):
878         (+[WebUndoStep stepWithUndoStep:]):
879         (WebEditorClient::registerUndoOrRedoStep):
880         (WebEditorClient::registerUndoStep):
881         (WebEditorClient::registerRedoStep):
882
883 2019-01-22  Alex Christensen  <achristensen@webkit.org>
884
885         Move NetworkStorageSession ownership to NetworkProcess
886         https://bugs.webkit.org/show_bug.cgi?id=193580
887
888         Reviewed by Geoff Garen.
889
890         * Misc/WebCache.mm:
891         (+[WebCache clearCachedCredentials]):
892         * Misc/WebDownload.mm:
893         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
894         * Plugins/WebBaseNetscapePluginView.mm:
895         (WebKit::getAuthenticationInfo):
896         * WebCoreSupport/WebFrameNetworkingContext.mm:
897         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
898         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
899         (WebFrameNetworkingContext::storageSession const):
900         * WebView/WebPreferences.mm:
901         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
902         (+[WebPreferences _clearNetworkLoaderSession]):
903         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
904
905 2019-01-22  Daniel Bates  <dabates@apple.com>
906
907         [iOS] Interpret text key commands on keydown and app key commands on keypress
908         https://bugs.webkit.org/show_bug.cgi?id=192897
909         <rdar://problem/46857378>
910
911         Reviewed by Brent Fulgham.
912
913         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
914         is false) and keypress (isCharEvent is true), respectively.
915
916         * WebView/WebHTMLView.mm:
917         (-[WebHTMLView _handleEditingKeyEvent:]):
918
919 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
920
921         [css-logical] Implement flow-relative margin, padding and border shorthands
922         https://bugs.webkit.org/show_bug.cgi?id=188697
923
924         Reviewed by Simon Fraser and Antti Koivisto.
925
926         Add CSSLogicalEnabled runtime flag.
927
928         * WebView/WebPreferenceKeysPrivate.h:
929         * WebView/WebPreferences.mm:
930         (+[WebPreferences initialize]):
931         (-[WebPreferences cssLogicalEnabled]):
932         (-[WebPreferences setCSSLogicalEnabled:]):
933         * WebView/WebPreferencesPrivate.h:
934         * WebView/WebView.mm:
935         (-[WebView _preferencesChanged:]):
936
937 2019-01-15  Darin Adler  <darin@apple.com>
938
939         Use references rather than pointers for register/unregister functions, and more
940         https://bugs.webkit.org/show_bug.cgi?id=175028
941
942         Reviewed by Daniel Bates.
943
944         * WebCoreSupport/WebKitFullScreenListener.mm:
945         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
946         functions in Document; pass a reference.
947         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
948         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
949         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
950         * WebView/WebFullScreenController.mm:
951         (-[WebFullScreenController enterFullScreen:]): Ditto.
952         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
953         (-[WebFullScreenController exitFullScreen]): Ditto.
954         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
955         * WebView/WebFullScreenController.mm:
956         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
957
958 2019-01-12  Dan Bernstein  <mitz@apple.com>
959
960         [Cocoa] Avoid importing directly from subumbrella frameworks
961         https://bugs.webkit.org/show_bug.cgi?id=186016
962         <rdar://problem/40591038>
963
964         Reviewed by Sam Weinig.
965
966         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
967         * Carbon/CarbonWindowAdapter.mm: Ditto.
968         * Carbon/CarbonWindowFrame.m: Ditto.
969         * Carbon/HIViewAdapter.h: Ditto.
970         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
971           OTHER_CFLAGS_COCOA_TOUCH_NO.
972         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
973         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
974         * WebView/WebPDFView.h: Ditto.
975
976 2019-01-20  Antoine Quint  <graouts@apple.com>
977
978         Add a POINTER_EVENTS feature flag
979         https://bugs.webkit.org/show_bug.cgi?id=193577
980         <rdar://problem/47408511>
981
982         Unreviewed. Also enable Pointer Events for iosmac.
983
984         * Configurations/FeatureDefines.xcconfig:
985
986 2019-01-19  Antoine Quint  <graouts@apple.com>
987
988         Add a POINTER_EVENTS feature flag
989         https://bugs.webkit.org/show_bug.cgi?id=193577
990
991         Reviewed by Dean Jackson.
992
993         * Configurations/FeatureDefines.xcconfig:
994
995 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
996
997         Revert r238815, it broke WK1 video fullscreen on Mac
998         https://bugs.webkit.org/show_bug.cgi?id=193586
999         <rdar://problem/47358941>
1000
1001         Reviewed by Jer Noble.
1002
1003         * WebView/WebVideoFullscreenController.h: Added.
1004         * WebView/WebVideoFullscreenController.mm: Added.
1005         (SOFT_LINK_CLASS):
1006         (-[WebVideoFullscreenController init]):
1007         (-[WebVideoFullscreenController dealloc]):
1008         (-[WebVideoFullscreenController fullscreenWindow]):
1009         (-[WebVideoFullscreenController windowDidLoad]):
1010         (-[WebVideoFullscreenController videoElement]):
1011         (-[WebVideoFullscreenController setVideoElement:]):
1012         (-[WebVideoFullscreenController clearFadeAnimation]):
1013         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1014         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1015         (-[WebVideoFullscreenController videoElementRect]):
1016         (-[WebVideoFullscreenController applicationDidResignActive:]):
1017         (frameExpandedToRatioOfFrame):
1018         (createBackgroundFullscreenWindow):
1019         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1020         (-[WebVideoFullscreenController enterFullscreen:]):
1021         (-[WebVideoFullscreenController exitFullscreen]):
1022         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1023         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1024         (-[WebVideoFullscreenController _requestExit]):
1025         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1026         (-[WebVideoFullscreenController requestExitFullscreen]):
1027         (-[WebVideoFullscreenController fadeHUDIn]):
1028         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1029         (-[WebVideoFullscreenController rateChanged:]):
1030         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1031         (-[WebVideoFullscreenWindow dealloc]):
1032         (-[WebVideoFullscreenWindow resignFirstResponder]):
1033         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1034         (-[WebVideoFullscreenWindow mouseDown:]):
1035         (-[WebVideoFullscreenWindow cancelOperation:]):
1036         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1037         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1038         (-[WebVideoFullscreenWindow animationDidEnd:]):
1039         (-[WebVideoFullscreenWindow mouseMoved:]):
1040         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1041         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1042         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1043         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1044         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1045         (-[WebVideoFullscreenHUDWindow center]):
1046         (-[WebVideoFullscreenHUDWindow keyDown:]):
1047         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1048         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1049         (-[WebVideoFullscreenHUDWindowController init]):
1050         (-[WebVideoFullscreenHUDWindowController dealloc]):
1051         (-[WebVideoFullscreenHUDWindowController setArea:]):
1052         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1053         (-[WebVideoFullscreenHUDWindowController delegate]):
1054         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1055         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1056         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1057         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1058         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1059         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1060         (createMediaUIControl):
1061         (createControlWithMediaUIControlType):
1062         (createTimeTextField):
1063         (createMediaUIBackgroundView):
1064         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1065         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1066         (-[WebVideoFullscreenHUDWindowController updateTime]):
1067         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1068         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1069         (-[WebVideoFullscreenHUDWindowController currentTime]):
1070         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1071         (-[WebVideoFullscreenHUDWindowController duration]):
1072         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1073         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1074         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1075         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1076         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1077         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1078         (-[WebVideoFullscreenHUDWindowController volume]):
1079         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1080         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1081         (-[WebVideoFullscreenHUDWindowController updateRate]):
1082         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1083         (-[WebVideoFullscreenHUDWindowController playing]):
1084         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1085         (timeToString):
1086         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1087         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1088         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1089         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1090         (-[WebVideoFullscreenHUDWindowController rewind:]):
1091         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1092         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1093         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1094         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1095         * WebView/WebView.mm:
1096         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1097         (-[WebView _exitVideoFullscreen]):
1098
1099 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1100
1101         Get rid of ADVANCED_SPELL_CHECKING
1102         https://bugs.webkit.org/show_bug.cgi?id=193592
1103
1104         Reviewed by Wenson Hsieh.
1105
1106         * WebCoreSupport/WebEditorClient.mm:
1107         (insertionPointFromCurrentSelection):
1108         (WebEditorClient::checkTextOfParagraph):
1109         (WebEditorClient::getGuessesForWord):
1110         (WebEditorClient::requestCandidatesForSelection):
1111         (WebEditorClient::requestCheckingOfString):
1112         * WebView/WebHTMLView.mm:
1113         (-[WebHTMLView insertText:]):
1114
1115 2019-01-18  Jer Noble  <jer.noble@apple.com>
1116
1117         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1118         https://bugs.webkit.org/show_bug.cgi?id=189553
1119
1120         Reviewed by Tim Horton.
1121
1122         * Configurations/Base.xcconfig:
1123         * Configurations/SDKVariant.xcconfig: Added.
1124         * Configurations/WebKitLegacy.xcconfig:
1125
1126 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1127
1128         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1129         <https://webkit.org/b/193568>
1130         <rdar://problem/47381130>
1131
1132         Reviewed by Alex Christensen.
1133
1134         * WebView/WebView.mm:
1135         - Remove unused soft-linking macros.
1136         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1137         (-[WebUITextIndicatorData initWithImage:scale:]):
1138         - Update to use exported PAL functions.
1139
1140 2019-01-17  Truitt Savell  <tsavell@apple.com>
1141
1142         Unreviewed, rolling out r240124.
1143
1144         This commit broke an internal build.
1145
1146         Reverted changeset:
1147
1148         "SDK_VARIANT build destinations should be separate from non-
1149         SDK_VARIANT builds"
1150         https://bugs.webkit.org/show_bug.cgi?id=189553
1151         https://trac.webkit.org/changeset/240124
1152
1153 2019-01-17  Jer Noble  <jer.noble@apple.com>
1154
1155         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1156         https://bugs.webkit.org/show_bug.cgi?id=189553
1157
1158         Reviewed by Tim Horton.
1159
1160         * Configurations/Base.xcconfig:
1161         * Configurations/SDKVariant.xcconfig: Added.
1162         * Configurations/WebKitLegacy.xcconfig:
1163
1164 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1165
1166         Stop using NetworkStorageSession::storageSession in WebCore
1167         https://bugs.webkit.org/show_bug.cgi?id=193529
1168
1169         Reviewed by Tim Horton.
1170
1171         * Misc/WebCache.mm:
1172         (+[WebCache addImageToCache:forURL:forFrame:]):
1173         * WebView/WebView.mm:
1174         (-[WebView _commonInitializationWithFrameName:groupName:]):
1175         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1176
1177 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1178
1179         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1180         https://bugs.webkit.org/show_bug.cgi?id=193368
1181
1182         Reviewed by Geoff Garen.
1183
1184         * Misc/WebCache.mm:
1185         (+[WebCache clearCachedCredentials]):
1186         * Misc/WebDownload.mm:
1187         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1188         * Plugins/WebBaseNetscapePluginView.mm:
1189         (WebKit::getAuthenticationInfo):
1190
1191 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1192
1193         Stop using CookiesStrategy
1194         https://bugs.webkit.org/show_bug.cgi?id=161106
1195
1196         Reviewed by Don Olmstead and Antti Koivisto.
1197
1198         * Misc/WebCache.mm:
1199         (+[WebCache addImageToCache:forURL:forFrame:]):
1200         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1201         (WebKit::NetscapePluginInstanceProxy::getCookies):
1202         (WebKit::NetscapePluginInstanceProxy::setCookies):
1203         * Plugins/WebNetscapePluginView.mm:
1204         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1205         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1206         * WebCoreSupport/WebPlatformStrategies.h:
1207         * WebCoreSupport/WebPlatformStrategies.mm:
1208         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1209         (WebPlatformStrategies::cookiesForDOM): Deleted.
1210         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1211         (WebPlatformStrategies::cookiesEnabled): Deleted.
1212         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1213         (WebPlatformStrategies::getRawCookies): Deleted.
1214         (WebPlatformStrategies::deleteCookie): Deleted.
1215         * WebView/WebView.mm:
1216         (-[WebView _commonInitializationWithFrameName:groupName:]):
1217         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1218
1219 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1220
1221         Cannot tab out of WKWebView on macOS
1222         https://bugs.webkit.org/show_bug.cgi?id=161448
1223         <rdar://problem/28100085>
1224
1225         Reviewed by Dean Jackson.
1226
1227         * WebCoreSupport/WebChromeClient.mm:
1228         * WebView/WebView.mm:
1229         Make use of SPI headers.
1230
1231 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1232
1233         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1234         r239913, and r239914.
1235         https://bugs.webkit.org/show_bug.cgi?id=193407
1236
1237         These revisions caused an internal failure (Requested by
1238         Truitt on #webkit).
1239
1240         Reverted changesets:
1241
1242         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1243         https://bugs.webkit.org/show_bug.cgi?id=186016
1244         https://trac.webkit.org/changeset/239901
1245
1246         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1247         https://trac.webkit.org/changeset/239909
1248
1249         "Tried to fix the build."
1250         https://trac.webkit.org/changeset/239910
1251
1252         "Fixed iOS builds after r239910."
1253         https://trac.webkit.org/changeset/239912
1254
1255         "More build fixing."
1256         https://trac.webkit.org/changeset/239913
1257
1258         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1259         https://trac.webkit.org/changeset/239914
1260
1261 2019-01-14  Mark Lam  <mark.lam@apple.com>
1262
1263         Re-enable ability to build --cloop builds.
1264         https://bugs.webkit.org/show_bug.cgi?id=192955
1265         <rdar://problem/46882363>
1266
1267         Reviewed by Saam barati and Keith Miller.
1268
1269         * Configurations/FeatureDefines.xcconfig:
1270
1271 2019-01-13  Dan Bernstein  <mitz@apple.com>
1272
1273         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1274
1275         Patch by Keith Rollin.
1276
1277         * WebView/PDFViewSPI.h:
1278
1279 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1280
1281         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1282         https://bugs.webkit.org/show_bug.cgi?id=191655
1283         rdar://problem/46074680
1284
1285         Reviewed by Megan Gardner.
1286
1287         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1288         * WebView/WebView.mm:
1289         (-[WebView _effectiveAppearanceIsDark]):
1290
1291 2019-01-12  Dan Bernstein  <mitz@apple.com>
1292
1293         [Cocoa] Avoid importing directly from subumbrella frameworks
1294         https://bugs.webkit.org/show_bug.cgi?id=186016
1295         <rdar://problem/40591038>
1296
1297         Reviewed by Sam Weinig.
1298
1299         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1300         * Carbon/CarbonWindowAdapter.mm: Ditto.
1301         * Carbon/CarbonWindowFrame.m: Ditto.
1302         * Carbon/HIViewAdapter.h: Ditto.
1303         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1304           OTHER_CFLAGS_COCOA_TOUCH_NO.
1305         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1306         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1307         * WebView/WebPDFView.h: Ditto.
1308
1309 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1310
1311         Enable visual viewport API by default
1312         https://bugs.webkit.org/show_bug.cgi?id=193376
1313
1314         Reviewed by Simon Fraser.
1315
1316         * WebView/WebPreferences.mm:
1317         (+[WebPreferences initialize]):
1318
1319 2019-01-11  John Wilander  <wilander@apple.com>
1320
1321         Compile out Web API Statistics Collection
1322         https://bugs.webkit.org/show_bug.cgi?id=193370
1323         <rdar://problem/45388584>
1324
1325         Reviewed by Brent Fulgham.
1326
1327         * Configurations/FeatureDefines.xcconfig:
1328             Defined ENABLE_WEB_API_STATISTICS, off by default.
1329
1330 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1331
1332         Stop using NetworkStorageSession in WebProcess
1333         https://bugs.webkit.org/show_bug.cgi?id=193236
1334
1335         Reviewed by Don Olmstead.
1336
1337         * WebCoreSupport/WebFrameNetworkingContext.h:
1338         * WebCoreSupport/WebFrameNetworkingContext.mm:
1339         (WebFrameNetworkingContext::storageSession const):
1340         * WebCoreSupport/WebPlatformStrategies.h:
1341         * WebCoreSupport/WebPlatformStrategies.mm:
1342         (WebPlatformStrategies::cookiesForDOM):
1343         (WebPlatformStrategies::setCookiesFromDOM):
1344         (WebPlatformStrategies::cookiesEnabled):
1345         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1346         (WebPlatformStrategies::getRawCookies):
1347         (WebPlatformStrategies::deleteCookie):
1348         * WebView/WebView.mm:
1349         (-[WebView _cachedResponseForURL:]):
1350         (-[WebView _clearCredentials]):
1351
1352 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1353
1354         Unreviewed, rolling out r239727.
1355
1356         Broke API tests
1357
1358         Reverted changeset:
1359
1360         "Stop using NetworkStorageSession in WebProcess"
1361         https://bugs.webkit.org/show_bug.cgi?id=193236
1362         https://trac.webkit.org/changeset/239727
1363
1364 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1365
1366         Stop using NetworkStorageSession in WebProcess
1367         https://bugs.webkit.org/show_bug.cgi?id=193236
1368
1369         Reviewed by Don Olmstead.
1370
1371         * WebCoreSupport/WebFrameNetworkingContext.h:
1372         * WebCoreSupport/WebFrameNetworkingContext.mm:
1373         (WebFrameNetworkingContext::storageSession const):
1374         * WebView/WebView.mm:
1375         (-[WebView _cachedResponseForURL:]):
1376         (-[WebView _clearCredentials]):
1377
1378 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1379
1380         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1381         <https://webkit.org/b/193056>
1382
1383         Reviewed by Alex Christensen.
1384
1385         * Plugins/Hosted/NetscapePluginHostProxy.h:
1386         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1387         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1388         (WebKit::NetscapePluginInstanceProxy::enumerate):
1389         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1390         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1391         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1392         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1393         * Plugins/Hosted/ProxyInstance.mm:
1394         (WebKit::ProxyInstance::invoke):
1395         * WebCoreSupport/WebGeolocationClient.mm:
1396         * WebView/WebDataSource.mm:
1397         (-[WebDataSource _receivedData:]):
1398         * WebView/WebView.mm:
1399         (-[WebView _cachedResponseForURL:]):
1400         - Remove '*' from RetainPtr<> type.
1401
1402 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1403
1404         Progress towards fixing Mac CMake build
1405         https://bugs.webkit.org/show_bug.cgi?id=193105
1406
1407         Reviewed by Don Olmstead.
1408
1409         * WebKitPrefix.h:
1410
1411 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1412
1413         Web Inspector: Use save sheet instead of dialog where possible
1414         https://bugs.webkit.org/show_bug.cgi?id=193160
1415         <rdar://problem/37399759>
1416
1417         Reviewed by Devin Rousso.
1418
1419         * WebCoreSupport/WebInspectorClient.mm:
1420         (WebInspectorFrontendClient::save):
1421
1422 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1423
1424         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1425         https://bugs.webkit.org/show_bug.cgi?id=193129
1426
1427         Reviewed by Tim Horton.
1428
1429         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1430
1431         * WebCoreSupport/WebEditorClient.mm:
1432         (WebEditorClient::registerUndoOrRedoStep):
1433         (undoNameForEditAction): Deleted.
1434
1435 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1436
1437         Add support for using the current text selection as the find string on iOS
1438         https://bugs.webkit.org/show_bug.cgi?id=193034
1439         <rdar://problem/45138739>
1440
1441         Reviewed by Tim Horton.
1442
1443         Add a method stub for WebKitLegacy.
1444
1445         * WebCoreSupport/WebEditorClient.h:
1446
1447 2019-01-01  Jeff Miller  <jeffm@apple.com>
1448
1449         Update user-visible copyright strings to include 2019
1450         https://bugs.webkit.org/show_bug.cgi?id=192811
1451
1452         Reviewed by Mark Lam.
1453
1454         * Info.plist:
1455
1456 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1457
1458         Use Ref<> as much as possible
1459         https://bugs.webkit.org/show_bug.cgi?id=192808
1460
1461         Reviewed by Alex Christensen.
1462
1463         * DOM/DOM.mm:
1464         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1465         * Plugins/Hosted/NetscapePluginHostManager.mm:
1466         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1467         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1468         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1469         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1470         * Plugins/WebNetscapePluginView.mm:
1471         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1472         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1473         * WebCoreSupport/WebContextMenuClient.mm:
1474         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1475         * WebCoreSupport/WebFrameLoaderClient.mm:
1476         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1477         * WebView/WebFrame.mm:
1478         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1479         * WebView/WebHTMLView.mm:
1480         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1481         * WebView/WebView.mm:
1482         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1483         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1484
1485 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1486
1487         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1488         https://bugs.webkit.org/show_bug.cgi?id=192821
1489
1490         Reviewed by Chris Dumez.
1491
1492         When a window becomes occluded, the window server informs the application.
1493         This should be used to suspend any work that is not visible by the user.
1494
1495         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1496         In some cases, that lead to performance impact (see radar).
1497
1498         This patch adds an observer for the occlusion notification. I tried to stick
1499         with the same names used by WebKit2.
1500
1501         * WebView/WebView.mm:
1502         (-[WebView _isViewVisible]):
1503         (-[WebView addWindowObserversForWindow:]):
1504         (-[WebView removeWindowObservers]):
1505         (-[WebView _windowDidChangeOcclusionState:]):
1506
1507 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1508
1509         [WebAuthN] Add a runtime flag for local authenticator
1510         https://bugs.webkit.org/show_bug.cgi?id=192792
1511         <rdar://problem/46798738>
1512
1513         Reviewed by Brent Fulgham.
1514
1515         * WebView/WebPreferenceKeysPrivate.h:
1516         * WebView/WebPreferences.mm:
1517         (+[WebPreferences initialize]):
1518         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1519         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1520         * WebView/WebPreferencesPrivate.h:
1521         * WebView/WebView.mm:
1522         (-[WebView _preferencesChanged:]):
1523
1524 2018-12-20  Chris Dumez  <cdumez@apple.com>
1525
1526         Use Optional::valueOr() instead of Optional::value_or()
1527         https://bugs.webkit.org/show_bug.cgi?id=192933
1528
1529         Reviewed by Geoffrey Garen.
1530
1531         * WebCoreSupport/WebSecurityOrigin.mm:
1532         (-[WebSecurityOrigin port]):
1533
1534 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1535
1536         Unreviewed, rolling out r239417.
1537
1538         Introduced two API test failures on macOS.
1539
1540         Reverted changeset:
1541
1542         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1543         occlusion changes"
1544         https://bugs.webkit.org/show_bug.cgi?id=192821
1545         https://trac.webkit.org/changeset/239417
1546
1547 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1548
1549         WKWebView default UA doesn't freeze the build number
1550         https://bugs.webkit.org/show_bug.cgi?id=192809
1551         <rdar://problem/44687185>
1552
1553         Reviewed by Andy Estes.
1554
1555         Always reports the frozen build number.
1556
1557         * WebView/WebView.mm:
1558         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1559         actual build number through this method call.
1560         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1561
1562 2018-12-19  Chris Dumez  <cdumez@apple.com>
1563
1564         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1565         https://bugs.webkit.org/show_bug.cgi?id=192728
1566         <rdar://problem/46746779>
1567
1568         Reviewed by Geoff Garen.
1569
1570         * DOM/*:
1571         * Plugins/*:
1572         * WebCoreSupport/*:
1573         * WebView/*:
1574
1575 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1576
1577         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1578         https://bugs.webkit.org/show_bug.cgi?id=192821
1579
1580         Reviewed by Chris Dumez.
1581
1582         When a window becomes occluded, the window server informs the application.
1583         This should be used to suspend any work that is not visible by the user.
1584
1585         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1586         In some cases, that lead to performance impact (see radar).
1587
1588         This patch adds an observer for the occlusion notification. I tried to stick
1589         with the same names used by WebKit2.
1590
1591         * WebView/WebView.mm:
1592         (-[WebView _isViewVisible]):
1593         (-[WebView addWindowObserversForWindow:]):
1594         (-[WebView removeWindowObservers]):
1595         (-[WebView _windowDidChangeOcclusionState:]):
1596
1597 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1598
1599         Allow clients to set the navigator platform
1600         https://bugs.webkit.org/show_bug.cgi?id=192735
1601
1602         Reviewed by Tim Horton.
1603
1604         Add stubs to fill out the added functionality in FrameLoaderClient.
1605
1606         * WebCoreSupport/WebFrameLoaderClient.h:
1607         * WebCoreSupport/WebFrameLoaderClient.mm:
1608         (WebFrameLoaderClient::navigatorPlatform):
1609
1610 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1611
1612         offsetLeft and offsetParent should adjust across shadow boundaries
1613         https://bugs.webkit.org/show_bug.cgi?id=157437
1614         <rdar://problem/26154021>
1615
1616         Reviewed by Simon Fraser.
1617
1618         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1619
1620         * DOM/DOMElement.mm:
1621         (-[DOMElement offsetLeft]):
1622         (-[DOMElement offsetTop]):
1623         (-[DOMElement offsetParent]):
1624
1625 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1626
1627         Unreviewed build fix.
1628
1629         * WebView/WebFrame.mm:
1630         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1631
1632 2018-12-15  Darin Adler  <darin@apple.com>
1633
1634         Use warning-ignoring macros more consistently and simply
1635         https://bugs.webkit.org/show_bug.cgi?id=192743
1636
1637         Reviewed by Mark Lam.
1638
1639         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1640         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1641         compilers in Objective-C++ code.
1642
1643         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1644         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1645         accomodate non-clang compilers here. Also use #pragma once, add a missing
1646         "explicit" and fix conditionals.
1647
1648 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1649
1650         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1651         https://bugs.webkit.org/show_bug.cgi?id=192653
1652
1653         Reviewed by Wenson Hsieh.
1654
1655         * WebView/WebHTMLView.mm:
1656         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1657
1658 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1659
1660         Implement feature flag for CSS Typed OM
1661         https://bugs.webkit.org/show_bug.cgi?id=192610
1662
1663         Reviewed by Ryosuke Niwa.
1664
1665         * Configurations/FeatureDefines.xcconfig:
1666
1667 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1668
1669         WebCore shouldn't have a Objective-C class named NSCursor
1670         https://bugs.webkit.org/show_bug.cgi?id=192602
1671         <rdar://problem/46615532>
1672
1673         Reviewed by Wenson Hsieh.
1674
1675         * WebView/WebFrameView.mm:
1676         (-[WebFrameView keyDown:keyDown:]):
1677         * WebView/WebHTMLView.mm:
1678         (-[WebHTMLView keyDown:]):
1679         (-[WebHTMLView performKeyEquivalent:]):
1680         Only use NSCursor on macOS.
1681
1682 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1683
1684         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1685         https://bugs.webkit.org/show_bug.cgi?id=192573
1686
1687         Reviewed by Simon Fraser.
1688
1689         * Configurations/FeatureDefines.xcconfig:
1690
1691 2018-12-10  Antti Koivisto  <antti@apple.com>
1692
1693         Rename "forced style recalc" to "full style rebuild"
1694         https://bugs.webkit.org/show_bug.cgi?id=192572
1695
1696         Reviewed by Zalan Bujtas.
1697
1698         * WebView/WebHTMLView.mm:
1699         (-[WebHTMLView setNeedsToApplyStyles:]):
1700
1701 2018-12-10  Darin Adler  <darin@apple.com>
1702
1703         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1704         https://bugs.webkit.org/show_bug.cgi?id=192533
1705         rdar://problem/45732710
1706
1707         Reviewed by Anders Carlsson.
1708
1709         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1710         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1711
1712 2018-12-10  Darin Adler  <darin@apple.com>
1713
1714         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1715         https://bugs.webkit.org/show_bug.cgi?id=192532
1716         rdar://problem/45731047
1717
1718         Reviewed by Chris Dumez.
1719
1720         * Plugins/Hosted/NetscapePluginHostManager.mm:
1721         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1722         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1723         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1724
1725 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1726
1727         Turn WritingDirection into an enum class
1728         https://bugs.webkit.org/show_bug.cgi?id=192401
1729         Work towards <rdar://problem/42075638>
1730
1731         Reviewed by Dan Bernstein.
1732
1733         Change WritingDirection from an enum to an enum class. No change in behavior.
1734
1735         * WebView/WebHTMLView.mm:
1736         (-[WebHTMLView toggleBaseWritingDirection:]):
1737         (-[WebHTMLView changeBaseWritingDirection:]):
1738         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1739
1740 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1741
1742         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1743         https://bugs.webkit.org/show_bug.cgi?id=192272
1744
1745         Reviewed by Brady Eidson.
1746
1747         * WebCoreSupport/WebFrameLoaderClient.h:
1748         * WebCoreSupport/WebFrameLoaderClient.mm:
1749         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1750
1751 2018-12-03  Jer Noble  <jer.noble@apple.com>
1752
1753         Get rid of old, dead Mac video fullscreen code.
1754         https://bugs.webkit.org/show_bug.cgi?id=192315
1755
1756         Reviewed by Eric Carlson.
1757
1758         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1759         is no longer supported in the Mac port.
1760
1761         * WebView/WebVideoFullscreenController.h: Removed.
1762         * WebView/WebVideoFullscreenController.mm: Removed.
1763         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1764         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1765         * WebView/WebView.mm:
1766         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1767         (-[WebView _exitVideoFullscreen]):
1768
1769 2018-12-03  Daniel Bates  <dabates@apple.com>
1770
1771         [iOS] Do not handle key events that are key commands
1772         https://bugs.webkit.org/show_bug.cgi?id=191608
1773         <rdar://problem/46046013>
1774
1775         Reviewed by Ryosuke Niwa.
1776
1777         A key down event may be associated with a key command. If it is then we want to execute the
1778         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1779         event as a key command to find out.
1780
1781         * WebView/WebHTMLView.mm:
1782         (-[WebHTMLView _handleEditingKeyEvent:]):
1783
1784 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1785
1786         Add a runtime feature flag for LayoutFormattingContext.
1787         https://bugs.webkit.org/show_bug.cgi?id=192280
1788
1789         Reviewed by Simon Fraser.
1790
1791         * Configurations/FeatureDefines.xcconfig:
1792
1793 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1794
1795         Move URL from WebCore to WTF
1796         https://bugs.webkit.org/show_bug.cgi?id=190234
1797
1798         Reviewed by Keith Miller.
1799
1800         * DOM/DOMAttr.mm:
1801         * DOM/DOMBlob.mm:
1802         * DOM/DOMCSSCharsetRule.mm:
1803         * DOM/DOMCSSImportRule.mm:
1804         * DOM/DOMCSSMediaRule.mm:
1805         * DOM/DOMCSSPageRule.mm:
1806         * DOM/DOMCSSPrimitiveValue.mm:
1807         * DOM/DOMCSSRule.mm:
1808         * DOM/DOMCSSStyleDeclaration.mm:
1809         * DOM/DOMCSSStyleRule.mm:
1810         * DOM/DOMCSSStyleSheet.mm:
1811         * DOM/DOMCSSValue.mm:
1812         * DOM/DOMCharacterData.mm:
1813         * DOM/DOMCounter.mm:
1814         * DOM/DOMDocument.mm:
1815         * DOM/DOMDocumentFragment.mm:
1816         * DOM/DOMDocumentType.mm:
1817         * DOM/DOMEvent.mm:
1818         * DOM/DOMFile.mm:
1819         * DOM/DOMHTMLAnchorElement.mm:
1820         * DOM/DOMHTMLAppletElement.mm:
1821         * DOM/DOMHTMLAreaElement.mm:
1822         * DOM/DOMHTMLBRElement.mm:
1823         * DOM/DOMHTMLBaseElement.mm:
1824         * DOM/DOMHTMLBaseFontElement.mm:
1825         * DOM/DOMHTMLBodyElement.mm:
1826         * DOM/DOMHTMLButtonElement.mm:
1827         * DOM/DOMHTMLCanvasElement.mm:
1828         * DOM/DOMHTMLCollection.mm:
1829         * DOM/DOMHTMLDivElement.mm:
1830         * DOM/DOMHTMLDocument.mm:
1831         * DOM/DOMHTMLElement.mm:
1832         * DOM/DOMHTMLEmbedElement.mm:
1833         * DOM/DOMHTMLFieldSetElement.mm:
1834         * DOM/DOMHTMLFontElement.mm:
1835         * DOM/DOMHTMLFormElement.mm:
1836         * DOM/DOMHTMLFrameElement.mm:
1837         * DOM/DOMHTMLFrameSetElement.mm:
1838         * DOM/DOMHTMLHRElement.mm:
1839         * DOM/DOMHTMLHeadElement.mm:
1840         * DOM/DOMHTMLHeadingElement.mm:
1841         * DOM/DOMHTMLHtmlElement.mm:
1842         * DOM/DOMHTMLIFrameElement.mm:
1843         * DOM/DOMHTMLImageElement.mm:
1844         * DOM/DOMHTMLInputElement.mm:
1845         * DOM/DOMHTMLLIElement.mm:
1846         * DOM/DOMHTMLLabelElement.mm:
1847         * DOM/DOMHTMLLegendElement.mm:
1848         * DOM/DOMHTMLLinkElement.mm:
1849         * DOM/DOMHTMLMapElement.mm:
1850         * DOM/DOMHTMLMarqueeElement.mm:
1851         * DOM/DOMHTMLMediaElement.mm:
1852         * DOM/DOMHTMLMetaElement.mm:
1853         * DOM/DOMHTMLModElement.mm:
1854         * DOM/DOMHTMLOListElement.mm:
1855         * DOM/DOMHTMLObjectElement.mm:
1856         * DOM/DOMHTMLOptGroupElement.mm:
1857         * DOM/DOMHTMLOptionElement.mm:
1858         * DOM/DOMHTMLOptionsCollection.mm:
1859         * DOM/DOMHTMLParagraphElement.mm:
1860         * DOM/DOMHTMLParamElement.mm:
1861         * DOM/DOMHTMLQuoteElement.mm:
1862         * DOM/DOMHTMLScriptElement.mm:
1863         * DOM/DOMHTMLSelectElement.mm:
1864         * DOM/DOMHTMLStyleElement.mm:
1865         * DOM/DOMHTMLTableCaptionElement.mm:
1866         * DOM/DOMHTMLTableCellElement.mm:
1867         * DOM/DOMHTMLTableColElement.mm:
1868         * DOM/DOMHTMLTableElement.mm:
1869         * DOM/DOMHTMLTableRowElement.mm:
1870         * DOM/DOMHTMLTableSectionElement.mm:
1871         * DOM/DOMHTMLTitleElement.mm:
1872         * DOM/DOMHTMLUListElement.mm:
1873         * DOM/DOMHTMLVideoElement.mm:
1874         * DOM/DOMKeyboardEvent.mm:
1875         * DOM/DOMMediaList.mm:
1876         * DOM/DOMMouseEvent.mm:
1877         * DOM/DOMMutationEvent.mm:
1878         * DOM/DOMNamedNodeMap.mm:
1879         * DOM/DOMProcessingInstruction.mm:
1880         * DOM/DOMRange.mm:
1881         * DOM/DOMStyleSheet.mm:
1882         * DOM/DOMText.mm:
1883         * DOM/DOMTextEvent.mm:
1884         * DOM/DOMTokenList.mm:
1885         * DOM/DOMUIEvent.mm:
1886         * DOM/DOMXPathResult.mm:
1887         * History/WebHistoryItem.mm:
1888         * Misc/WebNSURLExtras.mm:
1889         (-[NSURL _web_userVisibleString]):
1890         (-[NSURL _web_URLByRemovingUserInfo]):
1891         (-[NSURL _web_dataForURLComponentType:]):
1892         (-[NSURL _web_schemeData]):
1893         (-[NSURL _web_hostData]):
1894         * Misc/WebUserContentURLPattern.mm:
1895         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1896         * Plugins/WebNetscapePluginStream.h:
1897         (WebNetscapePluginStream::setRequestURL):
1898         * WebCoreSupport/WebChromeClient.h:
1899         * WebCoreSupport/WebChromeClient.mm:
1900         (WebChromeClient::signedPublicKeyAndChallengeString const):
1901         * WebCoreSupport/WebContextMenuClient.h:
1902         * WebCoreSupport/WebContextMenuClient.mm:
1903         * WebCoreSupport/WebDragClient.h:
1904         * WebCoreSupport/WebFrameLoaderClient.h:
1905         * WebCoreSupport/WebFrameLoaderClient.mm:
1906         (WebFrameLoaderClient::updateGlobalHistory):
1907         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1908         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1909         (WebPaymentCoordinatorClient::showPaymentUI):
1910         * WebCoreSupport/WebPlatformStrategies.h:
1911         * WebCoreSupport/WebPlatformStrategies.mm:
1912         (WebPlatformStrategies::readURLFromPasteboard):
1913         * WebCoreSupport/WebPluginInfoProvider.h:
1914         * WebCoreSupport/WebPluginInfoProvider.mm:
1915         (WebPluginInfoProvider::webVisiblePluginInfo):
1916         * WebCoreSupport/WebSecurityOrigin.mm:
1917         * WebCoreSupport/WebVisitedLinkStore.h:
1918         * WebView/WebDataSource.mm:
1919         * WebView/WebFrame.mm:
1920         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1921         * WebView/WebImmediateActionController.mm:
1922         (-[WebImmediateActionController _defaultAnimationController]):
1923         * WebView/WebPDFView.mm:
1924         * WebView/WebScriptDebugger.mm:
1925         * WebView/WebViewInternal.h:
1926
1927 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1928
1929         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1930         https://bugs.webkit.org/show_bug.cgi?id=192197
1931
1932         Reviewed by Jiewen Tan.
1933
1934         * Configurations/FeatureDefines.xcconfig:
1935         * WebCoreSupport/WebChromeClient.h:
1936         * WebCoreSupport/WebChromeClient.mm:
1937
1938 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1939
1940         Remove dead code from an earlier attempt at implementing safe browsing
1941         https://bugs.webkit.org/show_bug.cgi?id=192067
1942
1943         Reviewed by Chris Dumez.
1944
1945         * WebCoreSupport/WebFrameLoaderClient.h:
1946         * WebCoreSupport/WebFrameLoaderClient.mm:
1947         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1948
1949 2018-11-27  Mark Lam  <mark.lam@apple.com>
1950
1951         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1952         https://bugs.webkit.org/show_bug.cgi?id=192055
1953         <rdar://problem/46288783>
1954
1955         Reviewed by Saam Barati.
1956
1957         * Configurations/FeatureDefines.xcconfig:
1958
1959 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1960
1961         Make it possible to insert editable images with a gesture
1962         https://bugs.webkit.org/show_bug.cgi?id=191937
1963
1964         Reviewed by Wenson Hsieh.
1965
1966         * WebCoreSupport/WebEditorClient.mm:
1967         (undoNameForEditAction):
1968         Add a undo name.
1969
1970 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1971
1972         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1973         https://bugs.webkit.org/show_bug.cgi?id=191945
1974
1975         Reviewed by Anders Carlsson.
1976
1977         * WebCoreSupport/WebEditorClient.mm:
1978         (undoNameForEditAction):
1979
1980 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1981
1982         Enable drag and drop support for iOSMac
1983         https://bugs.webkit.org/show_bug.cgi?id=191818
1984         <rdar://problem/43907454>
1985
1986         Reviewed by Dean Jackson.
1987
1988         * Configurations/FeatureDefines.xcconfig:
1989
1990 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1991
1992         Address post-review feedback after r238438
1993         https://bugs.webkit.org/show_bug.cgi?id=191913
1994
1995         Reviewed by Ryosuke Niwa.
1996
1997         * WebView/WebFrame.mm:
1998         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1999         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2000         * WebView/WebView.mm:
2001         (-[WebView setSelectedDOMRange:affinity:]):
2002
2003 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2004
2005         Web Inspector: "Reload Web Inspector" button no longer partially works
2006         https://bugs.webkit.org/show_bug.cgi?id=191773
2007         <rdar://problem/46139932>
2008
2009         Reviewed by Devin Rousso.
2010
2011         * WebCoreSupport/WebInspectorClient.h:
2012         * WebCoreSupport/WebInspectorClient.mm:
2013         (WebInspectorFrontendClient::reopen):
2014
2015 2018-11-17  Devin Rousso  <drousso@apple.com>
2016
2017         Web Inspector: Network: add button to show system certificate dialog
2018         https://bugs.webkit.org/show_bug.cgi?id=191458
2019         <rdar://problem/45977019>
2020
2021         Reviewed by Joseph Pecoraro.
2022
2023         * WebCoreSupport/WebInspectorClient.h:
2024         * WebCoreSupport/WebInspectorClient.mm:
2025         (WebInspectorFrontendClient::showCertificate): Added.
2026
2027         * Configurations/WebKitLegacy.xcconfig:
2028
2029 2018-11-15  Truitt Savell  <tsavell@apple.com>
2030
2031         Unreviewed, rolling out r238244.
2032
2033         Caused High Sierra test runs to fail early with 50 crashes and
2034         casued 25 API failures.
2035
2036         Reverted changeset:
2037
2038         "[css-logical] Implement flow-relative margin, padding and
2039         border shorthands"
2040         https://bugs.webkit.org/show_bug.cgi?id=188697
2041         https://trac.webkit.org/changeset/238244
2042
2043 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2044
2045         [css-logical] Implement flow-relative margin, padding and border shorthands
2046         https://bugs.webkit.org/show_bug.cgi?id=188697
2047
2048         Reviewed by Simon Fraser and Antti Koivisto.
2049
2050         Add CSSLogicalEnabled runtime flag.
2051
2052         * WebView/WebPreferenceKeysPrivate.h:
2053         * WebView/WebPreferences.mm:
2054         (+[WebPreferences initialize]):
2055         (-[WebPreferences cssLogicalEnabled]):
2056         (-[WebPreferences setCSSLogicalEnabled:]):
2057         * WebView/WebPreferencesPrivate.h:
2058         * WebView/WebView.mm:
2059         (-[WebView _preferencesChanged:]):
2060
2061 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2062
2063         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2064         https://bugs.webkit.org/show_bug.cgi?id=191612
2065
2066         Reviewed by Matt Baker.
2067
2068         * WebCoreSupport/WebInspectorClient.mm:
2069         (-[WebInspectorWindowController destroyInspectorView]):
2070
2071 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2072
2073         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2074         https://bugs.webkit.org/show_bug.cgi?id=191494
2075         <rdar://problem/45469854>
2076
2077         Reviewed by Devin Rousso.
2078
2079         * WebCoreSupport/WebInspectorClient.h:
2080         WebKitLegacy will still have remote inspection of the Page directly.
2081
2082 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2083
2084         Make compositing updates incremental
2085         https://bugs.webkit.org/show_bug.cgi?id=90342
2086
2087         Reviewed by Antti Koivisto.
2088
2089         Fix spelling error.
2090
2091         * WebView/WebView.mm:
2092         (-[WebView _setMediaLayer:forPluginView:]):
2093
2094 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         Implement a new edit command to change the enclosing list type
2097         https://bugs.webkit.org/show_bug.cgi?id=191487
2098         <rdar://problem/45955922>
2099
2100         Reviewed by Ryosuke Niwa.
2101
2102         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2103
2104         * WebCoreSupport/WebEditorClient.mm:
2105         (undoNameForEditAction):
2106
2107 2018-11-11  Daniel Bates  <dabates@apple.com>
2108
2109         [iOS] Draw caps lock indicator in password fields
2110         https://bugs.webkit.org/show_bug.cgi?id=190565
2111         <rdar://problem/45262343>
2112
2113         Reviewed by Dean Jackson.
2114
2115         Update the caps lock state when a hardware keyboard is attached or detached.
2116
2117         * WebView/WebHTMLView.mm:
2118         (hardwareKeyboardAvailabilityChangedCallback): Added.
2119         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2120         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2121
2122 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2123
2124         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2125         https://bugs.webkit.org/show_bug.cgi?id=191492
2126
2127         Reviewed by Alex Christensen.
2128
2129         * Carbon/HIWebView.mm:
2130         * Misc/WebNSFileManagerExtras.mm:
2131         * Misc/WebNSURLExtras.mm:
2132         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2133         * Plugins/WebBasePluginPackage.mm:
2134         * Plugins/WebPluginContainerCheck.mm:
2135         * WebCoreSupport/WebCachedFramePlatformData.h:
2136         * WebCoreSupport/WebDeviceOrientationClient.mm:
2137         * WebView/WebDelegateImplementationCaching.mm:
2138         * WebView/WebHTMLView.mm:
2139         * WebView/WebPDFRepresentation.mm:
2140         * WebView/WebPolicyDelegate.mm:
2141         * WebView/WebView.mm:
2142
2143 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2144
2145         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2146         https://bugs.webkit.org/show_bug.cgi?id=191492
2147
2148         Reviewed by Alex Christensen.
2149
2150         * Carbon/HIWebView.mm:
2151         (UpdateCommandStatus):
2152         * Misc/WebNSFileManagerExtras.mm:
2153         * Misc/WebNSURLExtras.mm:
2154         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2155         * Plugins/WebBasePluginPackage.mm:
2156         * Plugins/WebPluginContainerCheck.mm:
2157         (-[WebPluginContainerCheck _continueWithPolicy:]):
2158         * WebCoreSupport/WebCachedFramePlatformData.h:
2159         (WebCachedFramePlatformData::clear):
2160         * WebCoreSupport/WebDeviceOrientationClient.mm:
2161         (WebDeviceOrientationClient::getProvider const):
2162         * WebView/WebDelegateImplementationCaching.mm:
2163         (CallDelegate):
2164         (CallDelegateReturningBoolean):
2165         (CallResourceLoadDelegateReturningBoolean):
2166         (CallFormDelegate):
2167         (CallFormDelegateReturningBoolean):
2168         * WebView/WebHTMLView.mm:
2169         * WebView/WebPDFRepresentation.mm:
2170         * WebView/WebPolicyDelegate.mm:
2171         (-[WebPolicyDecisionListener _usePolicy:]):
2172         * WebView/WebView.mm:
2173
2174 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2175
2176         Unreviewed, rolling out r238047.
2177
2178         Introduced layout test failures on iOS simulator.
2179
2180         Reverted changeset:
2181
2182         "[iOS] Draw caps lock indicator in password fields"
2183         https://bugs.webkit.org/show_bug.cgi?id=190565
2184         https://trac.webkit.org/changeset/238047
2185
2186 2018-11-09  Antti Koivisto  <antti@apple.com>
2187
2188         Use OptionSet for layout milestones
2189         https://bugs.webkit.org/show_bug.cgi?id=191470
2190
2191         Reviewed by Dean Jackson.
2192
2193         * WebCoreSupport/WebFrameLoaderClient.h:
2194         * WebCoreSupport/WebFrameLoaderClient.mm:
2195         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2196         * WebView/WebView.mm:
2197         (coreLayoutMilestones):
2198         (kitLayoutMilestones):
2199         (-[WebView _cacheFrameLoadDelegateImplementations]):
2200         * WebView/WebViewInternal.h:
2201
2202 2018-11-09  Daniel Bates  <dabates@apple.com>
2203
2204         [iOS] Draw caps lock indicator in password fields
2205         https://bugs.webkit.org/show_bug.cgi?id=190565
2206         <rdar://problem/45262343>
2207
2208         Reviewed by Dean Jackson.
2209
2210         Update the caps lock state when a hardware keyboard is attached or detached.
2211
2212         * WebView/WebHTMLView.mm:
2213         (hardwareKeyboardAvailabilityChangedCallback): Added.
2214         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2215         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2216
2217 2018-11-09  Daniel Bates  <dabates@apple.com>
2218
2219         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2220         action when forward delete is pressed outside a text field
2221         https://bugs.webkit.org/show_bug.cgi?id=190566
2222         <rdar://problem/45262367>
2223
2224         Reviewed by Wenson Hsieh.
2225
2226         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2227         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2228         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2229
2230         * WebView/WebHTMLView.mm:
2231         (-[WebHTMLView _handleEditingKeyEvent:]):
2232
2233 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2234
2235         Adopt Reveal Framework to replace Lookup
2236         https://bugs.webkit.org/show_bug.cgi?id=191097
2237         <rdar://problem/45924508>
2238
2239         Reviewed by Tim Horton.
2240
2241         Pass in what it needed to clear the textIndicators. This is better than
2242         the current notification structure.
2243
2244         * WebView/WebView.mm:
2245         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2246         (-[WebView _prepareForDictionaryLookup]):
2247
2248 2018-11-06  Justin Fan  <justin_fan@apple.com>
2249
2250         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2251         https://bugs.webkit.org/show_bug.cgi?id=191291
2252
2253         Reviewed by Myles Maxfield.
2254
2255         Properly disable WEBGPU on all non-Metal platforms for now.
2256
2257         * Configurations/FeatureDefines.xcconfig:
2258
2259 2018-11-02  Daniel Bates  <dabates@apple.com>
2260
2261         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2262         https://bugs.webkit.org/show_bug.cgi?id=190487
2263
2264         Reviewed by Tim Horton.
2265
2266         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2267         allow the default handling.
2268
2269         * WebView/WebHTMLView.mm:
2270         (-[WebHTMLView _handleEditingKeyEvent:]):
2271
2272 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2273
2274         Add a storage limit for IndexedDB
2275         https://bugs.webkit.org/show_bug.cgi?id=190598
2276         <rdar://problem/44654715>
2277
2278         Reviewed by Chris Dumez.
2279
2280         * Storage/WebDatabaseManager.mm:
2281         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2282         * Storage/WebDatabaseManagerPrivate.h:
2283
2284 2018-10-31  Antti Koivisto  <antti@apple.com>
2285
2286         Remove LayerFlushScheduler
2287         https://bugs.webkit.org/show_bug.cgi?id=191103
2288
2289         Reviewed by Anders Carlsson.
2290
2291         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2292         all the virtual cruft.
2293
2294         * WebView/WebViewData.h:
2295         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2296         (): Deleted.
2297         * WebView/WebViewData.mm:
2298         (currentRunLoop):
2299         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2300         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2301         (WebViewLayerFlushScheduler::schedule):
2302         (WebViewLayerFlushScheduler::invalidate):
2303         (WebViewLayerFlushScheduler::layerFlushCallback):
2304
2305 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2306
2307         Enable InstallAPI for iOS unconditionally
2308         https://bugs.webkit.org/show_bug.cgi?id=191043
2309         rdar://problem/32728423
2310
2311         Reviewed by Dan Bernstein.
2312
2313         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2314         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2315         shouldn't be processed by InstallAPI.
2316         * MigrateHeaders.make: Removed an obsolete workaround.
2317         * Misc/NSURLDownloadSPI.h: Added.
2318         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2319
2320 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2321
2322         Clean up some obsolete MAX_ALLOWED macros
2323         https://bugs.webkit.org/show_bug.cgi?id=190916
2324
2325         Reviewed by Tim Horton.
2326
2327         * WebView/WebHTMLView.mm:
2328         (-[WebHTMLView pressureChangeWithEvent:]):
2329         * WebView/WebPDFView.h:
2330
2331 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2332
2333         Unreviewed, rolling out r237600 and r237604.
2334         https://bugs.webkit.org/show_bug.cgi?id=191086
2335
2336         Breaks internal iOS builds (Requested by ryanhadd_ on
2337         #webkit).
2338
2339         Reverted changesets:
2340
2341         "Enable InstallAPI for iOS unconditionally"
2342         https://bugs.webkit.org/show_bug.cgi?id=191043
2343         https://trac.webkit.org/changeset/237600
2344
2345         "Build fix attempt after enabling InstallAPI for iOS."
2346         https://bugs.webkit.org/show_bug.cgi?id=191043
2347         https://trac.webkit.org/changeset/237604
2348
2349 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2350
2351         Enable InstallAPI for iOS unconditionally
2352         https://bugs.webkit.org/show_bug.cgi?id=191043
2353         rdar://problem/32728423
2354
2355         Reviewed by Dan Bernstein.
2356
2357         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2358         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2359         shouldn't be processed by InstallAPI.
2360         * MigrateHeaders.make: Removed an obsolete workaround.
2361         * Misc/NSURLDownloadSPI.h: Added.
2362         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2363
2364 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2365
2366         Modernize WebKit nibs and lprojs for localization's sake
2367         https://bugs.webkit.org/show_bug.cgi?id=190911
2368         <rdar://problem/45349466>
2369
2370         Reviewed by Dan Bernstein.
2371
2372         * Misc/WebNSControlExtras.m:
2373         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2374         NSWindow and its contents are both in the same scale space these days; avoid
2375         double-applying the scale factor, or you can't see the prompt.
2376
2377         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2378         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2379         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2380         NIB->XIB
2381
2382 2018-10-25  Antoine Quint  <graouts@apple.com>
2383
2384         [Web Animations] Turn Web Animations CSS Integration off by default
2385         https://bugs.webkit.org/show_bug.cgi?id=190901
2386
2387         Reviewed by Dean Jackson.
2388
2389         * WebView/WebPreferences.mm:
2390         (+[WebPreferences initialize]):
2391
2392 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2393
2394         Clean up some obsolete macOS version guards
2395         https://bugs.webkit.org/show_bug.cgi?id=190887
2396
2397         Reviewed by Dan Bernstein.
2398
2399         * Misc/WebNSPasteboardExtras.mm:
2400         (+[NSPasteboard _web_dragTypesForURL]):
2401         * WebCoreSupport/PopupMenuMac.mm:
2402         (PopupMenuMac::show):
2403         * WebCoreSupport/WebEditorClient.h:
2404         * WebCoreSupport/WebEditorClient.mm:
2405         (WebEditorClient::respondToChangedSelection):
2406         * WebView/WebPDFView.mm:
2407         (-[WebPDFView _clipViewForPDFDocumentView]):
2408
2409 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2410
2411         Turn on Conic Gradients
2412         https://bugs.webkit.org/show_bug.cgi?id=190810
2413
2414         Reviewed by Tim Horton.
2415
2416         * Configurations/FeatureDefines.xcconfig:
2417
2418 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2419
2420         Cleanup: MIMETypeRegistry functions
2421         https://bugs.webkit.org/show_bug.cgi?id=190838
2422
2423         Reviewed by Simon Fraser.
2424
2425         * Misc/WebNSPasteboardExtras.mm:
2426         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2427         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2428         because they were identical.
2429
2430         * WebView/WebHTMLRepresentation.mm:
2431         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2432         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2433         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2434         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2435         * WebView/WebView.mm:
2436         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2437         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2438         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2439
2440 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2441
2442         Fix false positive leaks when using custom -init methods that don't start with -init
2443         <https://webkit.org/b/190818>
2444         <rdar://problem/45476042>
2445
2446         Reviewed by Dan Bernstein.
2447
2448         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2449         it is accessible by both categories.
2450         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2451         NSError (WebKitInternal) category.  Add attribute to make this
2452         behave like an -init method.
2453         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2454         NSError (WebKitInternal) category.  Modernize method.  Replace
2455         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2456
2457 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2458
2459         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2460         https://bugs.webkit.org/show_bug.cgi?id=190729
2461
2462         Reviewed by Tim Horton.
2463
2464         * DOM/DOM.mm:
2465         (-[DOMNode boundingBox]):
2466         * DOM/DOMElement.mm:
2467         * DOM/DOMHTML.mm:
2468         * DOM/DOMInternal.mm:
2469         * DOM/DOMUIKitExtensions.mm:
2470         * DOM/WebDOMOperations.mm:
2471         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2472         * DefaultDelegates/WebDefaultEditingDelegate.m:
2473         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2474         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2475         * DefaultDelegates/WebDefaultUIDelegate.h:
2476         * DefaultDelegates/WebDefaultUIDelegate.mm:
2477         (-[WebDefaultUIDelegate webViewClose:]):
2478         (-[WebDefaultUIDelegate webViewFocus:]):
2479         (-[WebDefaultUIDelegate webViewUnfocus:]):
2480         (-[WebDefaultUIDelegate webViewIsResizable:]):
2481         (-[WebDefaultUIDelegate webView:setResizable:]):
2482         (-[WebDefaultUIDelegate webView:setFrame:]):
2483         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2484         * History/BackForwardList.h:
2485         * History/BackForwardList.mm:
2486         * History/WebBackForwardList.mm:
2487         (+[WebBackForwardList initialize]):
2488         (bumperCarBackForwardHackNeeded):
2489         * History/WebHistory.mm:
2490         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2491         (-[WebHistory _sendNotification:entries:]):
2492         (-[WebHistory loadFromURL:error:]):
2493         (-[WebHistory saveToURL:error:]):
2494         * History/WebHistoryItem.mm:
2495         (WKNotifyHistoryItemChanged):
2496         (+[WebHistoryItem initialize]):
2497         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2498         * History/WebURLsWithTitles.m:
2499         * Misc/WebCache.mm:
2500         (+[WebCache initialize]):
2501         * Misc/WebDownload.mm:
2502         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2503         * Misc/WebElementDictionary.mm:
2504         (+[WebElementDictionary initialize]):
2505         (+[WebElementDictionary initializeLookupTable]):
2506         * Misc/WebIconDatabase.mm:
2507         * Misc/WebKitNSStringExtras.mm:
2508         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2509         * Misc/WebKitVersionChecks.h:
2510         * Misc/WebKitVersionChecks.mm:
2511         (WebKitLinkedOnOrAfter):
2512         (WebKitLinkTimeVersion):
2513         * Misc/WebLocalizableStrings.mm:
2514         * Misc/WebNSControlExtras.h:
2515         * Misc/WebNSControlExtras.m:
2516         * Misc/WebNSEventExtras.m:
2517         * Misc/WebNSFileManagerExtras.mm:
2518         * Misc/WebNSImageExtras.h:
2519         * Misc/WebNSImageExtras.m:
2520         * Misc/WebNSPasteboardExtras.mm:
2521         * Misc/WebNSPrintOperationExtras.h:
2522         * Misc/WebNSPrintOperationExtras.m:
2523         * Misc/WebNSViewExtras.m:
2524         * Misc/WebNSWindowExtras.m:
2525         * Panels/WebAuthenticationPanel.h:
2526         * Panels/WebAuthenticationPanel.m:
2527         * Panels/WebPanelAuthenticationHandler.m:
2528         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2529         (+[WebHostedNetscapePluginView initialize]):
2530         * Plugins/WebBasePluginPackage.h:
2531         * Plugins/WebBasePluginPackage.mm:
2532         * Plugins/WebJavaPlugIn.h:
2533         * Plugins/WebPluginContainerCheck.mm:
2534         * Plugins/WebPluginController.h:
2535         * Plugins/WebPluginController.mm:
2536         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2537         (-[WebPluginController addPlugin:]):
2538         (-[WebPluginController destroyPlugin:]):
2539         (-[WebPluginController destroyAllPlugins]):
2540         * Plugins/WebPluginDatabase.mm:
2541         (+[WebPluginDatabase _defaultPlugInPaths]):
2542         * Plugins/WebPluginPackage.mm:
2543         (-[WebPluginPackage initWithPath:]):
2544         * Storage/WebDatabaseManager.mm:
2545         (-[WebDatabaseManager deleteAllDatabases]):
2546         * Storage/WebDatabaseManagerClient.h:
2547         * Storage/WebDatabaseManagerClient.mm:
2548         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2549         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2550         * Storage/WebStorageManager.mm:
2551         (-[WebStorageManager deleteAllOrigins]):
2552         (WebKitInitializeStorageIfNecessary):
2553         * WebCoreSupport/WebAlternativeTextClient.h:
2554         * WebCoreSupport/WebApplicationCache.mm:
2555         (applicationCacheBundleIdentifier):
2556         * WebCoreSupport/WebChromeClient.h:
2557         * WebCoreSupport/WebChromeClient.mm:
2558         (WebChromeClient::setWindowRect):
2559         (WebChromeClient::windowRect):
2560         (WebChromeClient::takeFocus):
2561         (WebChromeClient::addMessageToConsole):
2562         (WebChromeClient::enableSuddenTermination):
2563         (WebChromeClient::disableSuddenTermination):
2564         (WebChromeClient::createPopupMenu const):
2565         (WebChromeClient::createSearchPopupMenu const):
2566         (WebChromeClient::shouldPaintEntireContents const):
2567         (WebChromeClient::supportsVideoFullscreen):
2568         (WebChromeClient::supportsFullScreenForElement):
2569         (WebChromeClient::enterFullScreenForElement):
2570         (WebChromeClient::exitFullScreenForElement):
2571         * WebCoreSupport/WebContextMenuClient.mm:
2572         * WebCoreSupport/WebDragClient.mm:
2573         * WebCoreSupport/WebEditorClient.h:
2574         * WebCoreSupport/WebEditorClient.mm:
2575         (+[WebUndoStep initialize]):
2576         (updateFontPanel):
2577         (WebEditorClient::didBeginEditing):
2578         (WebEditorClient::respondToChangedContents):
2579         (WebEditorClient::respondToChangedSelection):
2580         (WebEditorClient::canceledComposition):
2581         (WebEditorClient::didEndEditing):
2582         (WebEditorClient::didWriteSelectionToPasteboard):
2583         (attributesForAttributedStringConversion):
2584         (WebEditorClient::setInsertionPasteboard):
2585         (WebEditorClient::registerUndoOrRedoStep):
2586         (WebEditorClient::handleKeyboardEvent):
2587         (WebEditorClient::handleInputMethodKeydown):
2588         (WebEditorClient::textDidChangeInTextField):
2589         (WebEditorClient::requestCheckingOfString):
2590         * WebCoreSupport/WebFrameLoaderClient.h:
2591         * WebCoreSupport/WebFrameLoaderClient.mm:
2592         (WebFrameLoaderClient::detachedFromParent2):
2593         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2594         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2595         (WebFrameLoaderClient::dispatchWillSendRequest):
2596         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2597         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2598         (WebFrameLoaderClient::willCacheResponse const):
2599         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2600         (WebFrameLoaderClient::dispatchDidFinishLoading):
2601         (WebFrameLoaderClient::dispatchDidFailLoading):
2602         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2603         (WebFrameLoaderClient::dispatchWillClose):
2604         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2605         (WebFrameLoaderClient::dispatchDidCommitLoad):
2606         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2607         (WebFrameLoaderClient::dispatchDidFailLoad):
2608         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2609         (WebFrameLoaderClient::dispatchDidFinishLoad):
2610         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2611         (WebFrameLoaderClient::willChangeTitle):
2612         (WebFrameLoaderClient::didChangeTitle):
2613         (WebFrameLoaderClient::didReplaceMultipartContent):
2614         (WebFrameLoaderClient::updateGlobalHistory):
2615         (WebFrameLoaderClient::saveViewStateToItem):
2616         (WebFrameLoaderClient::restoreViewState):
2617         (WebFrameLoaderClient::provisionalLoadStarted):
2618         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2619         (WebFrameLoaderClient::setTitle):
2620         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2621         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2622         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2623         (WebFrameLoaderClient::didRestoreFromPageCache):
2624         (WebFrameLoaderClient::actionDictionary const):
2625         (WebFrameLoaderClient::createPlugin):
2626         (WebFrameLoaderClient::getLoadDecisionForIcons):
2627         (WebFrameLoaderClient::finishedLoadingIcon):
2628         (+[WebFramePolicyListener initialize]):
2629         * WebCoreSupport/WebFrameNetworkingContext.mm:
2630         * WebCoreSupport/WebGeolocationClient.h:
2631         * WebCoreSupport/WebGeolocationClient.mm:
2632         (WebGeolocationClient::requestPermission):
2633         * WebCoreSupport/WebInspectorClient.h:
2634         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2635         * WebCoreSupport/WebNotificationClient.mm:
2636         * WebCoreSupport/WebOpenPanelResultListener.mm:
2637         * WebCoreSupport/WebPlatformStrategies.h:
2638         * WebCoreSupport/WebPlatformStrategies.mm:
2639         * WebCoreSupport/WebProgressTrackerClient.h:
2640         * WebCoreSupport/WebProgressTrackerClient.mm:
2641         (WebProgressTrackerClient::progressStarted):
2642         (WebProgressTrackerClient::progressEstimateChanged):
2643         (WebProgressTrackerClient::progressFinished):
2644         * WebCoreSupport/WebSecurityOrigin.mm:
2645         * WebInspector/WebNodeHighlight.h:
2646         * WebInspector/WebNodeHighlight.mm:
2647         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2648         (-[WebNodeHighlight dealloc]):
2649         (-[WebNodeHighlight attach]):
2650         * WebInspector/WebNodeHighlightView.h:
2651         * WebInspector/WebNodeHighlightView.mm:
2652         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2653         (-[WebNodeHighlightView dealloc]):
2654         * WebInspector/WebNodeHighlighter.mm:
2655         (-[WebNodeHighlighter highlight]):
2656         * WebView/WebArchive.mm:
2657         (+[WebArchivePrivate initialize]):
2658         * WebView/WebClipView.h:
2659         * WebView/WebDataSource.mm:
2660         (WebDataSourcePrivate::WebDataSourcePrivate):
2661         (+[WebDataSource initialize]):
2662         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2663         (-[WebDataSource _makeRepresentation]):
2664         * WebView/WebDelegateImplementationCaching.h:
2665         * WebView/WebDelegateImplementationCaching.mm:
2666         (CallDelegate):
2667         (CallDelegateReturningFloat):
2668         (CallDelegateReturningBoolean):
2669         (CallUIDelegate):
2670         (CallUIDelegateReturningFloat):
2671         (CallUIDelegateReturningBoolean):
2672         (CallFrameLoadDelegate):
2673         (CallFrameLoadDelegateReturningBoolean):
2674         (CallResourceLoadDelegate):
2675         (CallScriptDebugDelegate):
2676         (CallFormDelegate):
2677         (CallFormDelegateReturningBoolean):
2678         * WebView/WebDeviceOrientation.mm:
2679         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2680         * WebView/WebDocumentInternal.h:
2681         * WebView/WebDocumentLoaderMac.mm:
2682         (needsDataLoadWorkaround):
2683         * WebView/WebDynamicScrollBarsViewInternal.h:
2684         * WebView/WebFormDelegate.m:
2685         * WebView/WebFrame.mm:
2686         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2687         (-[WebFrame _unmarkAllMisspellings]):
2688         (-[WebFrame _paintBehaviorForDestinationContext:]):
2689         (-[WebFrame _drawRect:contentsOnly:]):
2690         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2691         (-[WebFrame _scrollDOMRangeToVisible:]):
2692         (-[WebFrame _bodyBackgroundColor]):
2693         (-[WebFrame accessibilityRoot]):
2694         (needsMicrosoftMessengerDOMDocumentWorkaround):
2695         * WebView/WebFrameInternal.h:
2696         * WebView/WebFrameView.mm:
2697         (-[WebFrameView _setDocumentView:]):
2698         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2699         (-[WebFrameView _viewClassForMIMEType:]):
2700         (-[WebFrameView initWithFrame:]):
2701         (-[WebFrameView drawRect:]):
2702         (-[WebFrameView _firstResponderIsFormControl]):
2703         (-[WebFrameView keyDown:keyDown:]):
2704         (-[WebFrameView _isScrollable]):
2705         * WebView/WebFullScreenController.h:
2706         * WebView/WebFullScreenController.mm:
2707         * WebView/WebHTMLRepresentation.mm:
2708         * WebView/WebHTMLView.mm:
2709         (-[WebHTMLView hitTest:]):
2710         (-[WebHTMLView initWithFrame:]):
2711         (-[WebHTMLView dealloc]):
2712         (-[WebHTMLView addSubview:]):
2713         (-[WebHTMLView mouseDown:]):
2714         (-[WebHTMLView mouseUp:]):
2715         (-[WebHTMLView resignFirstResponder]):
2716         (-[WebHTMLView accessibilityHitTest:]):
2717         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2718         * WebView/WebHTMLViewInternal.h:
2719         * WebView/WebIndicateLayer.h:
2720         * WebView/WebIndicateLayer.mm:
2721         * WebView/WebMediaPlaybackTargetPicker.h:
2722         * WebView/WebMediaPlaybackTargetPicker.mm:
2723         * WebView/WebPDFDocumentExtras.h:
2724         * WebView/WebPDFDocumentExtras.mm:
2725         * WebView/WebPDFRepresentation.h:
2726         * WebView/WebPDFRepresentation.mm:
2727         * WebView/WebPDFView.h:
2728         * WebView/WebPreferences.mm:
2729         (cacheModelForMainBundle):
2730         (WebPreferencesPrivate::WebPreferencesPrivate):
2731         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2732         (-[WebPreferences encodeWithCoder:]):
2733         (+[WebPreferences standardPreferences]):
2734         (+[WebPreferences initialize]):
2735         (-[WebPreferences _valueForKey:]):
2736         (-[WebPreferences _setStringValue:forKey:]):
2737         (-[WebPreferences _setIntegerValue:forKey:]):
2738         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2739         (-[WebPreferences _setFloatValue:forKey:]):
2740         (-[WebPreferences _setBoolValue:forKey:]):
2741         (-[WebPreferences _setLongLongValue:forKey:]):
2742         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2743         (-[WebPreferences _postCacheModelChangedNotification]):
2744         (-[WebPreferences _postPreferencesChangedNotification]):
2745         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2746         (-[WebPreferences setStorageBlockingPolicy:]):
2747         * WebView/WebResource.mm:
2748         (+[WebResourcePrivate initialize]):
2749         * WebView/WebTextCompletionController.h:
2750         * WebView/WebTextIterator.mm:
2751         (+[WebTextIteratorPrivate initialize]):
2752         * WebView/WebView.mm:
2753         (shouldEnableLoadDeferring):
2754         (shouldRestrictWindowFocus):
2755         (shouldRespectPriorityInCSSAttributeSetters):
2756         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2757         (shouldAllowPictureInPictureMediaPlayback):
2758         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2759         (shouldAllowWindowOpenWithoutUserGesture):
2760         (shouldConvertInvalidURLsToBlank):
2761         (shouldRequireUserGestureToLoadVideo):
2762         (-[WebView _commonInitializationWithFrameName:groupName:]):
2763         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2764         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2765         (-[WebView _closePluginDatabases]):
2766         (-[WebView _closeWithFastTeardown]):
2767         (-[WebView _close]):
2768         (+[WebView _MIMETypeForFile:]):
2769         (-[WebView setShowingInspectorIndication:]):
2770         (-[WebView _setFormDelegate:]):
2771         (-[WebView _needsPreHTML5ParserQuirks]):
2772         (-[WebView _preferencesChangedNotification:]):
2773         (-[WebView _preferencesChanged:]):
2774         (-[WebView _cacheResourceLoadDelegateImplementations]):
2775         (-[WebView _cacheFrameLoadDelegateImplementations]):
2776         (-[WebView _policyDelegateForwarder]):
2777         (-[WebView _UIDelegateForwarder]):
2778         (-[WebView _editingDelegateForwarder]):
2779         (-[WebView _updateActiveState]):
2780         (-[_WebSafeForwarder forwardInvocation:]):
2781         (+[WebView initialize]):
2782         (-[WebView _pluginForMIMEType:]):
2783         (-[WebView _pluginForExtension:]):
2784         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2785         (+[WebView canShowMIMETypeAsHTML:]):
2786         (-[WebView _initWithArguments:]):
2787         (-[WebView initWithFrame:frameName:groupName:]):
2788         (-[WebView dealloc]):
2789         (-[WebView close]):
2790         (-[WebView viewDidMoveToWindow]):
2791         (-[WebView setUIDelegate:]):
2792         (-[WebView setResourceLoadDelegate:]):
2793         (-[WebView setPolicyDelegate:]):
2794         (-[WebView setFrameLoadDelegate:]):
2795         (-[WebView goBack]):
2796         (-[WebView goForward]):
2797         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2798         (-[WebView setHostWindow:]):
2799         (-[WebView becomeFirstResponder]):
2800         (+[WebView _cacheModelChangedNotification:]):
2801         (-[WebView _frameViewAtWindowPoint:]):
2802         (+[WebView _preflightSpellCheckerNow:]):
2803         (+[WebView _preflightSpellChecker]):
2804         (-[WebView canGoBack]):
2805         (-[WebView canGoForward]):
2806         (-[WebView stopLoading:]):
2807         (-[WebView reload:]):
2808         (-[WebView setMainFrameDocumentReady:]):
2809         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2810         (-[WebView setContinuousSpellCheckingEnabled:]):
2811         (-[WebView undoManager]):
2812         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2813         (-[WebView isAutomaticLinkDetectionEnabled]):
2814         (-[WebView isAutomaticDashSubstitutionEnabled]):
2815         (-[WebView isAutomaticTextReplacementEnabled]):
2816         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2817         (+[WebView _setCacheModel:]):
2818         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2819         (-[WebView _keyboardUIMode]):
2820         (LayerFlushController::flushLayers):
2821         (-[WebView _scheduleCompositingLayerFlush]):
2822         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2823         (-[WebView fullScreenPlaceholderView]):
2824         (WebInstallMemoryPressureHandler):
2825         * WebView/WebViewData.h:
2826         * WebView/WebViewData.mm:
2827         (+[WebViewPrivate initialize]):
2828         (-[WebViewPrivate init]):
2829         (-[WebViewPrivate dealloc]):
2830         * WebView/WebViewInternal.h:
2831
2832 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2833
2834         Clean up FrameLoader two-state enums
2835         https://bugs.webkit.org/show_bug.cgi?id=190731
2836
2837         Reviewed by Chris Dumez.
2838
2839         * WebCoreSupport/WebFrameLoaderClient.h:
2840         * WebCoreSupport/WebFrameLoaderClient.mm:
2841         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2842
2843 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2844
2845         Unreviewed, rolling out r237137.
2846
2847         SPI is actually used
2848
2849         Reverted changeset:
2850
2851         "Remove unused WebFrame._loadType"
2852         https://bugs.webkit.org/show_bug.cgi?id=190583
2853         https://trac.webkit.org/changeset/237137
2854
2855 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2856
2857         Enable the datalist element by default on iOS and macOS
2858         https://bugs.webkit.org/show_bug.cgi?id=190594
2859         <rdar://problem/45281159>
2860
2861         Reviewed by Ryosuke Niwa and Tim Horton.
2862
2863         * Configurations/FeatureDefines.xcconfig:
2864
2865 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2866
2867         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2868         https://bugs.webkit.org/show_bug.cgi?id=190675
2869
2870         Reviewed by Chris Dumez.
2871
2872         * History/BackForwardList.h:
2873         * History/BackForwardList.mm:
2874         (BackForwardList::backItem):
2875         (BackForwardList::currentItem):
2876         (BackForwardList::forwardItem):
2877         (BackForwardList::backListCount const):
2878         (BackForwardList::forwardListCount const):
2879         (BackForwardList::itemAtIndex):
2880         * History/WebBackForwardList.mm:
2881         (-[WebBackForwardList backItem]):
2882         (-[WebBackForwardList currentItem]):
2883         (-[WebBackForwardList forwardItem]):
2884         (-[WebBackForwardList itemAtIndex:]):
2885
2886 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2887
2888         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2889         https://bugs.webkit.org/show_bug.cgi?id=190526
2890         rdar://problem/45230140
2891
2892         Reviewed by Dean Jackson.
2893
2894         * WebCoreSupport/WebEditorClient.mm:
2895         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2896
2897 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2898
2899         Implement feature flag and bindings for CSS Painting API
2900         https://bugs.webkit.org/show_bug.cgi?id=190237
2901
2902         Reviewed by Ryosuke Niwa.
2903
2904         * Configurations/FeatureDefines.xcconfig:
2905
2906 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2907
2908         Replace HistoryItem* with HistoryItem& where possible
2909         https://bugs.webkit.org/show_bug.cgi?id=190617
2910
2911         Reviewed by Chris Dumez.
2912
2913         * History/BackForwardList.h:
2914         * History/BackForwardList.mm:
2915         (BackForwardList::goToItem):
2916         * History/WebBackForwardList.mm:
2917         (-[WebBackForwardList goToItem:]):
2918         * History/WebHistoryItem.mm:
2919         (WKNotifyHistoryItemChanged):
2920         * History/WebHistoryItemInternal.h:
2921
2922 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2923
2924         Remove unused WebHistoryItem._transientPropertyForKey
2925         https://bugs.webkit.org/show_bug.cgi?id=190606
2926
2927         Reviewed by Chris Dumez.
2928
2929         * History/WebHistoryItem.mm:
2930         * History/WebHistoryItemPrivate.h:
2931
2932 2018-10-15  Justin Fan  <justin_fan@apple.com>
2933
2934         Add WebGPU 2018 feature flag and experimental feature flag
2935         https://bugs.webkit.org/show_bug.cgi?id=190509
2936
2937         Reviewed by Dean Jackson.
2938
2939         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2940         for the 2018 WebGPU prototype.
2941
2942         * Configurations/FeatureDefines.xcconfig:
2943         * WebView/WebPreferenceKeysPrivate.h:
2944         * WebView/WebPreferences.mm:
2945         (+[WebPreferences initialize]):
2946         (-[WebPreferences webGPUEnabled]):
2947         (-[WebPreferences setWebGPUEnabled:]):
2948         * WebView/WebPreferencesPrivate.h:
2949         * WebView/WebView.mm:
2950         (-[WebView _preferencesChanged:]):
2951
2952 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2953
2954         Fix iOS build after r237157
2955
2956         * WebView/WebView.mm:
2957         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2958
2959 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2960
2961         Modernize BackForwardClient.h
2962         https://bugs.webkit.org/show_bug.cgi?id=190610
2963
2964         Reviewed by Chris Dumez.
2965
2966         * History/BackForwardList.h:
2967         * History/BackForwardList.mm:
2968         (BackForwardList::backListCount const):
2969         (BackForwardList::forwardListCount const):
2970         (BackForwardList::backListCount): Deleted.
2971         (BackForwardList::forwardListCount): Deleted.
2972         * History/WebBackForwardList.mm:
2973         (-[WebBackForwardList init]):
2974         * WebCoreSupport/WebFrameLoaderClient.mm:
2975         (WebFrameLoaderClient::canCachePage const):
2976         * WebView/WebFrameView.mm:
2977         (-[WebFrameView keyDown:keyDown:]):
2978         * WebView/WebView.mm:
2979         (-[WebView _commonInitializationWithFrameName:groupName:]):
2980         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2981         (-[WebView _loadBackForwardListFromOtherView:]):
2982         (-[WebView initWithCoder:]):
2983         (-[WebView encodeWithCoder:]):
2984         (-[WebView backForwardList]):
2985         (-[WebView setMaintainsBackForwardList:]):
2986
2987 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2988
2989         Add support for prefers-color-scheme media query
2990         https://bugs.webkit.org/show_bug.cgi?id=190499
2991         rdar://problem/45212025
2992
2993         Reviewed by Dean Jackson.
2994
2995         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2996
2997 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2998
2999         Remove unused WebView._globalHistoryItem
3000         https://bugs.webkit.org/show_bug.cgi?id=190601
3001
3002         Reviewed by Chris Dumez.
3003
3004         * WebCoreSupport/WebFrameLoaderClient.h:
3005         * WebCoreSupport/WebFrameLoaderClient.mm:
3006         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3007         * WebView/WebView.mm:
3008         (-[WebView _globalHistoryItem]): Deleted.
3009         (-[WebView _setGlobalHistoryItem:]): Deleted.
3010         * WebView/WebViewData.h:
3011         * WebView/WebViewInternal.h:
3012         * WebView/WebViewPrivate.h:
3013
3014 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3015
3016         Remove unused parameters from FrameLoaderClient::createFrame
3017         https://bugs.webkit.org/show_bug.cgi?id=190587
3018
3019         Reviewed by Chris Dumez.
3020
3021         * WebCoreSupport/WebFrameLoaderClient.h:
3022         * WebCoreSupport/WebFrameLoaderClient.mm:
3023         (WebFrameLoaderClient::createFrame):
3024
3025 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3026
3027         Remove unused WebFrame._loadType
3028         https://bugs.webkit.org/show_bug.cgi?id=190583
3029
3030         Reviewed by Chris Dumez.
3031
3032         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3033
3034         * WebView/WebFrame.mm:
3035         (toWebFrameLoadType): Deleted.
3036         (-[WebFrame _loadType]): Deleted.
3037         * WebView/WebFramePrivate.h:
3038
3039 2018-10-15  Chris Dumez  <cdumez@apple.com>
3040
3041         Restrict browsing context lookup by name to frames that are related to one another
3042         https://bugs.webkit.org/show_bug.cgi?id=190475
3043
3044         Reviewed by Alex Christensen.
3045
3046         * WebView/WebFrame.mm:
3047         (-[WebFrame findFrameNamed:]):
3048
3049 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3050
3051         Remove InjectedBundle processing of back/forward lists
3052         https://bugs.webkit.org/show_bug.cgi?id=190459
3053
3054         Reviewed by Chris Dumez.
3055
3056         * WebCoreSupport/WebFrameLoaderClient.h:
3057         * WebCoreSupport/WebFrameLoaderClient.mm:
3058         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3059
3060 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3061
3062         [JSC] Remove Option::useAsyncIterator
3063         https://bugs.webkit.org/show_bug.cgi?id=190567
3064
3065         Reviewed by Saam Barati.
3066
3067         * Configurations/FeatureDefines.xcconfig:
3068
3069 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3070
3071         Allow encoding of small enum classes
3072         https://bugs.webkit.org/show_bug.cgi?id=190531
3073
3074         Reviewed by Tim Horton.
3075
3076         * WebCoreSupport/WebFrameLoaderClient.mm:
3077         (-[WebFramePolicyListener dealloc]):
3078
3079 2018-10-11  Keith Rollin  <krollin@apple.com>
3080
3081         CURRENT_ARCH should not be used in Run Script phase.
3082         https://bugs.webkit.org/show_bug.cgi?id=190407
3083         <rdar://problem/45133556>
3084
3085         Reviewed by Alexey Proskuryakov.
3086
3087         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3088         CURRENT_ARCH is not well-defined during this phase (and may even have
3089         the value "undefined") since this phase is run just once per build
3090         rather than once per supported architecture. Migrate away from
3091         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3092         performing an operation for each value, or by picking the first entry
3093         in ARCHS and using that as a representative value.
3094
3095         * Configurations/WebKitLegacy.xcconfig: When generating
3096         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3097         macosx platforms.
3098
3099         * MigrateHeaders.make:
3100         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3101         generate one for each architecture in ARCHS.
3102
3103 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3104
3105         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3106         https://bugs.webkit.org/show_bug.cgi?id=190429
3107
3108         Reviewed by Saam Barati.
3109
3110         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3111
3112         * WebView/WebPDFRepresentation.mm:
3113         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3114
3115 2018-10-08  Justin Fan  <justin_fan@apple.com>
3116
3117         WebGPU: Rename old WebGPU prototype to WebMetal
3118         https://bugs.webkit.org/show_bug.cgi?id=190325
3119         <rdar://problem/44990443>
3120
3121         Reviewed by Dean Jackson.
3122
3123         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3124
3125         * Configurations/FeatureDefines.xcconfig:
3126         * WebView/WebPreferenceKeysPrivate.h:
3127         * WebView/WebPreferences.mm:
3128         (+[WebPreferences initialize]):
3129         (-[WebPreferences webMetalEnabled]):
3130         (-[WebPreferences setWebMetalEnabled:]):
3131         (-[WebPreferences webGPUEnabled]): Deleted.
3132         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3133         * WebView/WebPreferencesPrivate.h:
3134         * WebView/WebView.mm:
3135         (-[WebView _preferencesChanged:]):
3136
3137 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3138
3139         Make <input type=color> a runtime enabled (on-by-default) feature
3140         https://bugs.webkit.org/show_bug.cgi?id=189162
3141
3142         Reviewed by Wenson Hsieh and Tim Horton.
3143
3144         * Configurations/FeatureDefines.xcconfig:
3145
3146 2018-10-07  Dan Bernstein  <mitz@apple.com>
3147
3148         Fixed building with the latest macOS SDK
3149
3150         * Plugins/WebNetscapePluginPackage.mm:
3151         (-[WebNetscapePluginPackage openResourceFile]):
3152         (-[WebNetscapePluginPackage closeResourceFile:]):
3153
3154 2018-10-04  Dan Bernstein  <mitz@apple.com>
3155
3156         More Carbon build-fixing.
3157
3158         * Carbon/CarbonWindowAdapter.mm:
3159         (-[CarbonWindowAdapter _destroyRealWindow:]):
3160         (-[CarbonWindowAdapter _growBoxRect]):
3161
3162 2018-10-04  Dan Bernstein  <mitz@apple.com>
3163
3164         Retried to fix 32-bit macOS builds after r236846.
3165
3166         * WebView/WebHTMLView.mm:
3167         (-[WebHTMLView setMarkedText:selectedRange:]):
3168
3169 2018-10-04  Dan Bernstein  <mitz@apple.com>
3170
3171         Retried to fix 32-bit macOS builds after r236846.
3172
3173         * Carbon/HIWebView.mm:
3174         (ActiveStateChanged):
3175
3176 2018-10-04  Dan Bernstein  <mitz@apple.com>
3177
3178         Tried to fix 32-bit macOS builds after r236846.
3179
3180         * Carbon/HIWebView.mm:
3181         (_NSSelectorForHICommand):
3182
3183 2018-10-04  Dan Bernstein  <mitz@apple.com>
3184
3185         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3186         https://bugs.webkit.org/show_bug.cgi?id=190250
3187
3188         Reviewed by Andy Estes.
3189
3190         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3191           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3192           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3193           an earlier line set it to YES.
3194
3195         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3196         changes below.
3197
3198         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3199           provides some missing method declarations.
3200
3201         * Misc/WebDownload.mm:
3202         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3203           a deprecated method.
3204
3205         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3206
3207         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3208           other code in the file uses a method from it.
3209
3210         * Plugins/WebBaseNetscapePluginView.mm:
3211         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3212           a deprecated method.
3213
3214         * Plugins/WebPluginController.mm:
3215         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3216           around use of a selector that may be present in some WebKit client.
3217
3218         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3219           method declarations.
3220
3221         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3222           from here.
3223
3224         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3225           missing method declarations.
3226
3227         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3228           from here.
3229
3230         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3231           call from here.
3232         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3233           an obsolete delegate method for binary compatibility.
3234         (pluginView): Ditto.
3235
3236         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3237           call from here.
3238
3239         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3240           WebDeviceOrientationProviderMock protocol.
3241
3242         * WebView/WebDeviceOrientationProviderMock.mm:
3243         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3244           main @implementation.
3245
3246         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3247           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3248
3249         * WebView/WebDynamicScrollBarsView.mm:
3250         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3251           of a deprecated method.
3252
3253         * WebView/WebHTMLView.mm:
3254         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3255           selector warning around action methods that are not declared anywhere in WebKit.
3256
3257         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3258           about implementing this deprecated method.
3259         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3260         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3261         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3262         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3263         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3264         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3265         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3266         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3267         (-[WebHTMLView doCommandBySelector:]): Ditto.
3268         (-[WebHTMLView insertText:]): Ditto.
3269
3270         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3271
3272         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3273
3274         * WebView/WebPDFView.h: Removed previewView ivar.
3275
3276         * WebView/WebPDFView.mm:
3277           Removed declaration of FileInternal category and merged its implementation with the main
3278           implementation.
3279         (-[WebPDFView dealloc]): Removed previewView ivar.
3280         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3281           exist in macOS versions we support.
3282         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3283         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3284           action methods internal to PDFKit.
3285         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3286         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3287
3288         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3289           call on macOS, even though in r86988 we started calling different methods on iOS.
3290
3291         * WebView/WebView.mm:
3292         - Imported headers that declare delegate methods that we call.
3293         - Removed declaration of WebFileInternal category and merged its implementation with the
3294           main implementation.
3295         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3296           category, which made them impossible to call from the main implementation. Moved those
3297           into the main implementation. One of those had to be declared in a class extension,
3298           because it is called from a method implemented in the WebPrivate category, and that
3299           category’s implementation appears first in the file.
3300
3301         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3302           around use of obsolete delegate method for binary compatibility.
3303
3304         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3305
3306 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3307
3308         Runtime flag and IDL for MediaRecorder
3309         https://bugs.webkit.org/show_bug.cgi?id=190018
3310
3311         Reviewed by Youenn Fablet and Chris Dumez.
3312
3313         * WebView/WebPreferenceKeysPrivate.h:
3314         * WebView/WebPreferences.mm:
3315         (+[WebPreferences initialize]):
3316         (-[WebPreferences mediaRecorderEnabled]):
3317         (-[WebPreferences setMediaRecorderEnabled:]):
3318         * WebView/WebPreferencesPrivate.h:
3319         * WebView/WebView.mm:
3320         (-[WebView _preferencesChanged:]):
3321
3322 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3323
3324         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3325         https://bugs.webkit.org/show_bug.cgi?id=190238
3326
3327         Reviewed by Antti Koivisto.
3328
3329         Enabled the feature by default.
3330
3331         * WebView/WebPreferences.mm:
3332         (+[WebPreferences initialize]):
3333
3334 2018-10-01  Dean Jackson  <dino@apple.com>
3335
3336         [macOS] Switching to discrete GPU should be done in the UI process
3337         https://bugs.webkit.org/show_bug.cgi?id=189361
3338         <rdar://problem/43949622>
3339
3340         Reviewed by Simon Fraser.
3341
3342         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3343         not support swapping to the discrete GPU in this configuration.
3344
3345         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3346         (WebKit::WebSwitchingGPUClient::singleton):
3347         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3348         * WebView/WebView.mm:
3349         (-[WebView _commonInitializationWithFrameName:groupName:]):
3350
3351 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3352
3353         Remove ParsedURLString
3354         https://bugs.webkit.org/show_bug.cgi?id=190154
3355
3356         Reviewed by Chris Dumez.
3357
3358         * WebView/WebScriptDebugger.mm:
3359         (toNSURL):
3360
3361 2018-10-01  Dean Jackson  <dino@apple.com>
3362
3363         Remove CSS Animation Triggers
3364         https://bugs.webkit.org/show_bug.cgi?id=190175
3365         <rdar://problem/44925626>
3366
3367         Reviewed by Simon Fraser.
3368
3369         * Configurations/FeatureDefines.xcconfig:
3370
3371 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3372
3373         Unreviewed, rolling out r236624 and r236671.
3374         https://bugs.webkit.org/show_bug.cgi?id=190207
3375
3376         The change in r236624 introduced crashes on the bots
3377         (Requested by ryanhaddad on #webkit).
3378
3379         Reverted changesets:
3380
3381         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3382         https://bugs.webkit.org/show_bug.cgi?id=188747
3383         https://trac.webkit.org/changeset/236624
3384
3385         "Unify implementation in VideoFullscreenInterfaceAVKit"
3386         https://bugs.webkit.org/show_bug.cgi?id=190091
3387         https://trac.webkit.org/changeset/236671
3388
3389 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3390
3391         URL should not use TextEncoding internally
3392         https://bugs.webkit.org/show_bug.cgi?id=190111
3393
3394         Reviewed by Andy Estes.
3395
3396         * Misc/WebNSURLExtras.mm:
3397
3398 2018-09-28  Jer Noble  <jer.noble@apple.com>
3399
3400         Refactoring: eliminate raw pointer usage in Fullscreen code
3401         https://bugs.webkit.org/show_bug.cgi?id=188747
3402         <rdar://problem/43541164>
3403
3404         Reviewed by Alex Christensen.
3405
3406         PlaybackSessionInterface no longer has an invalidate() method.
3407
3408         * WebView/WebView.mm:
3409         (-[WebView _clearPlaybackControlsManager]):
3410
3411 2018-09-28  Chris Dumez  <cdumez@apple.com>
3412
3413         Drop support for cross-origin-window-policy header
3414         https://bugs.webkit.org/show_bug.cgi?id=190081
3415
3416         Reviewed by Ryosuke Niwa.
3417
3418         * WebView/WebPreferenceKeysPrivate.h:
3419         * WebView/WebPreferences.mm:
3420         (+[WebPreferences initialize]):
3421         * WebView/WebPreferencesPrivate.h:
3422         * WebView/WebView.mm:
3423         (-[WebView _preferencesChanged:]):
3424
3425 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3426
3427         Rename createMarkup to serializePreservingVisualAppearance
3428         https://bugs.webkit.org/show_bug.cgi?id=190086
3429
3430         Reviewed by Wenson Hsieh.
3431
3432         * DOM/WebDOMOperations.mm:
3433         (-[DOMRange markupString]):
3434
3435 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3436
3437         Unreviewed, rolling out r236605.
3438         https://bugs.webkit.org/show_bug.cgi?id=190087
3439
3440         caused three API test timeouts (Requested by jernoble on
3441         #webkit).
3442
3443         Reverted changeset:
3444
3445         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3446         https://bugs.webkit.org/show_bug.cgi?id=188747
3447         https://trac.webkit.org/changeset/236605
3448
3449 2018-09-28  Jer Noble  <jer.noble@apple.com>
3450
3451         Refactoring: eliminate raw pointer usage in Fullscreen code
3452         https://bugs.webkit.org/show_bug.cgi?id=188747
3453         <rdar://problem/43541164>
3454
3455         Reviewed by Alex Christensen.
3456
3457         PlaybackSessionInterface no longer has an invalidate() method.
3458
3459         * WebView/WebView.mm:
3460         (-[WebView _clearPlaybackControlsManager]):
3461
3462 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3463
3464         Use enum class in createMarkup arguments
3465         https://bugs.webkit.org/show_bug.cgi?id=190028
3466
3467         Reviewed by Wenson Hsieh.
3468
3469         * DOM/WebDOMOperations.mm:
3470         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3471         (-[DOMRange markupString]): Ditto.
3472
3473 2018-09-27  Antoine Quint  <graouts@apple.com>
3474
3475         [Web Animations] Turn Web Animations with CSS integration on
3476         https://bugs.webkit.org/show_bug.cgi?id=184819
3477         <rdar://problem/39597337>
3478
3479         Reviewed b