Source/WebKitLegacy/mac/ChangeLog

   1 2018-04-02  Jer Noble  <jer.noble@apple.com>
   2
   3         Enable Legacy EME for all WebKit & WebKitLegacy clients
   4         https://bugs.webkit.org/show_bug.cgi?id=184018
   5         <rdar://problem/34887387>
   6
   7         Reviewed by Eric Carlson.
   8
   9         * WebView/WebPreferences.mm:
  10         (+[WebPreferences initialize]):
  11
  12 2018-03-29  JF Bastien  <jfbastien@apple.com>
  13
  14         Use Forward.h instead of forward-declaring WTF::String
  15         https://bugs.webkit.org/show_bug.cgi?id=184172
  16         <rdar://problem/39026146>
  17
  18         Reviewed by Yusuke Suzuki.
  19
  20         As part of #184164 I'm changing WTF::String, and the forward
  21         declarations are just wrong because I'm making it templated. We
  22         should use Forward.h anyways, so do that instead.
  23
  24         * WebView/WebScriptDebugger.h:
  25
  26 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
  27
  28         Protect against invalid mach ports returned by mach_port_request_notification
  29         https://bugs.webkit.org/show_bug.cgi?id=184106
  30         <rdar://problem/37865316>
  31
  32         Reviewed by Chris Dumez.
  33
  34         * Plugins/Hosted/NetscapePluginHostProxy.mm:
  35         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
  36         and clean up if it experienced an error.
  37         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
  38
  39 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
  40
  41         Avoid uninitialized mach ports
  42         https://bugs.webkit.org/show_bug.cgi?id=184090
  43         <rdar://problem/37261129>
  44
  45         Reviewed by Chris Dumez.
  46
  47         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
  48         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
  49         there is a potential for us to try to use invalid ports.
  50
  51         We should always check return values, and ensure that the mach port variables we seek to initialize are
  52         kept in a valid state.
  53
  54         Reviewed by Chris Dumez.
  55
  56         * Plugins/Hosted/NetscapePluginHostManager.h:
  57         * Plugins/Hosted/NetscapePluginHostManager.mm:
  58         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
  59         port is passed to an API function.
  60         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
  61         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
  62         * Plugins/Hosted/NetscapePluginHostProxy.h:
  63         * Plugins/Hosted/NetscapePluginHostProxy.mm:
  64         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
  65         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
  66         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
  67         (WKPCStatusText): Ditto.
  68         (WKPCLoadURL): Ditto.
  69         (WKPCCancelLoadURL): Ditto.
  70         (WKPCInvalidateRect): Ditto.
  71         (WKPCGetScriptableNPObjectReply): Ditto.
  72         (WKPCBooleanReply): Ditto.
  73         (WKPCBooleanAndDataReply): Ditto.
  74         (WKPCInstantiatePluginReply): Ditto.
  75         (WKPCGetWindowNPObject): Ditto.
  76         (WKPCGetPluginElementNPObject): Ditto.
  77         (WKPCForgetBrowserObject): Ditto.
  78         (WKPCEvaluate): Ditto.
  79         (WKPCGetStringIdentifier): Ditto.
  80         (WKPCGetIntIdentifier): Ditto.
  81         (WKPCInvoke): Ditto.
  82         (WKPCInvokeDefault): Ditto.
  83         (WKPCConstruct): Ditto.
  84         (WKPCGetProperty): Ditto.
  85         (WKPCSetProperty): Ditto.
  86         (WKPCRemoveProperty): Ditto.
  87         (WKPCHasProperty): Ditto.
  88         (WKPCHasMethod): Ditto.
  89         (WKPCIdentifierInfo): Ditto.
  90         (WKPCEnumerate): Ditto.
  91         (WKPCSetMenuBarVisible): Ditto.
  92         (WKPCSetFullscreenWindowIsShowing): Ditto.
  93         (WKPCSetModal): Ditto.
  94         (WKPCGetCookies): Ditto.
  95         (WKPCGetProxy): Ditto.
  96         (WKPCSetCookies): Ditto.
  97         (WKPCGetAuthenticationInfo): Ditto.
  98         (WKPCConvertPoint): Ditto.
  99         (WKPCLayerHostingModeChanged): Ditto.
 100         (WKPCSetException): Ditto.
 101
 102 2018-03-26  Tim Horton  <timothy_horton@apple.com>
 103
 104         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
 105         https://bugs.webkit.org/show_bug.cgi?id=184030
 106         <rdar://problem/38895281>
 107
 108         Reviewed by Dan Bernstein.
 109
 110         * Configurations/Base.xcconfig:
 111
 112 2018-03-26  Chris Dumez  <cdumez@apple.com>
 113
 114         Use SecurityOriginData more consistently in Service Worker code
 115         https://bugs.webkit.org/show_bug.cgi?id=183969
 116
 117         Reviewed by Darin Adler.
 118
 119         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
 120
 121         * Storage/WebDatabaseManager.mm:
 122         (-[WebDatabaseManager databasesWithOrigin:]):
 123         (-[WebDatabaseManager deleteOrigin:]):
 124         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
 125         * Storage/WebDatabaseQuotaManager.mm:
 126         (-[WebDatabaseQuotaManager usage]):
 127         (-[WebDatabaseQuotaManager quota]):
 128         (-[WebDatabaseQuotaManager setQuota:]):
 129         * Storage/WebStorageManager.mm:
 130         (-[WebStorageManager deleteOrigin:]):
 131         * WebCoreSupport/WebSecurityOrigin.mm:
 132         (-[WebSecurityOrigin databaseIdentifier]):
 133         (-[WebSecurityOrigin usage]):
 134         (-[WebSecurityOrigin quota]):
 135         (-[WebSecurityOrigin setQuota:]):
 136
 137 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
 138
 139         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
 140         https://bugs.webkit.org/show_bug.cgi?id=183911
 141         <rdar://problem/38762306>
 142
 143         Reviewed by Youenn Fablet.
 144
 145         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
 146
 147         * WebView/WebView.mm:
 148         (+[WebView initialize]):
 149
 150 2018-03-26  Alex Christensen  <achristensen@webkit.org>
 151
 152         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
 153         https://bugs.webkit.org/show_bug.cgi?id=183965
 154
 155         Reviewed by Chris Dumez.
 156
 157         * WebCoreSupport/WebFrameLoaderClient.h:
 158         * WebCoreSupport/WebFrameLoaderClient.mm:
 159         (WebFrameLoaderClient::willCacheResponse const):
 160
 161 2018-03-25  Commit Queue  <commit-queue@webkit.org>
 162
 163         Unreviewed, rolling out r229954.
 164         https://bugs.webkit.org/show_bug.cgi?id=184000
 165
 166         Caused many layout tests to crash on Apple High Sierra,
 167         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
 168         by dydz on #webkit).
 169
 170         Reverted changeset:
 171
 172         "Use SecurityOriginData more consistently in Service Worker
 173         code"
 174         https://bugs.webkit.org/show_bug.cgi?id=183969
 175         https://trac.webkit.org/changeset/229954
 176
 177 2018-03-24  Chris Dumez  <cdumez@apple.com>
 178
 179         Use SecurityOriginData more consistently in Service Worker code
 180         https://bugs.webkit.org/show_bug.cgi?id=183969
 181
 182         Reviewed by Darin Adler.
 183
 184         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
 185
 186         * Storage/WebDatabaseManager.mm:
 187         (-[WebDatabaseManager databasesWithOrigin:]):
 188         (-[WebDatabaseManager deleteOrigin:]):
 189         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
 190         * Storage/WebDatabaseQuotaManager.mm:
 191         (-[WebDatabaseQuotaManager usage]):
 192         (-[WebDatabaseQuotaManager quota]):
 193         (-[WebDatabaseQuotaManager setQuota:]):
 194         * Storage/WebStorageManager.mm:
 195         (-[WebStorageManager deleteOrigin:]):
 196         * WebCoreSupport/WebSecurityOrigin.mm:
 197         (-[WebSecurityOrigin databaseIdentifier]):
 198         (-[WebSecurityOrigin usage]):
 199         (-[WebSecurityOrigin quota]):
 200         (-[WebSecurityOrigin setQuota:]):
 201
 202 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
 203
 204         Fix the build
 205
 206         * WebView/WebView.mm:
 207
 208 2018-03-23  Tim Horton  <timothy_horton@apple.com>
 209
 210         Fix the build with no pasteboard
 211         https://bugs.webkit.org/show_bug.cgi?id=183973
 212
 213         Reviewed by Dan Bernstein.
 214
 215         * Configurations/FeatureDefines.xcconfig:
 216         * WebView/WebView.mm:
 217         (-[WebView _requestStartDataInteraction:globalPosition:]):
 218         (-[WebView _getDataInteractionData]):
 219         (-[WebView _dataOperationTextIndicator]):
 220         (-[WebView _dragSourceAction]):
 221         (-[WebView _draggedLinkTitle]):
 222         (-[WebView _draggedLinkURL]):
 223         (-[WebView _draggedElementBounds]):
 224         (-[WebView _enteredDataInteraction:client:global:operation:]):
 225         (-[WebView _updatedDataInteraction:client:global:operation:]):
 226         (-[WebView _exitedDataInteraction:client:global:operation:]):
 227         (-[WebView _performDataInteraction:client:global:operation:]):
 228         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
 229         (-[WebView _endedDataInteraction:global:]):
 230         (-[WebView _dataInteractionCaretRect]):
 231         * WebView/WebViewPrivate.h:
 232
 233 2018-03-23  Tim Horton  <timothy_horton@apple.com>
 234
 235         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
 236         https://bugs.webkit.org/show_bug.cgi?id=183960
 237         <rdar://problem/38812356>
 238
 239         Reviewed by Dan Bernstein.
 240
 241         * Configurations/WebKitLegacy.xcconfig:
 242
 243 2018-03-23  Tim Horton  <timothy_horton@apple.com>
 244
 245         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
 246         https://bugs.webkit.org/show_bug.cgi?id=183954
 247         <rdar://problem/38808858>
 248
 249         Reviewed by Dan Bernstein.
 250
 251         * WebView/WebPreferences.mm:
 252         (-[WebPreferences setAudioSessionCategoryOverride:]):
 253
 254 2018-03-23  Tim Horton  <timothy_horton@apple.com>
 255
 256         Adopt WK_PLATFORM_NAME in WebKitLegacy
 257         https://bugs.webkit.org/show_bug.cgi?id=183948
 258         <rdar://problem/38803908>
 259
 260         Reviewed by Dan Bernstein.
 261
 262         * Configurations/WebKitLegacy.xcconfig:
 263         * MigrateHeaders.make:
 264         * postprocess-headers.sh:
 265
 266 2018-03-23  Brady Eidson  <beidson@apple.com>
 267
 268         Go to back/forward list items after a process-swapped navigation.
 269         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
 270
 271         Reviewed by Andy Estes.
 272
 273         * WebView/WebView.mm:
 274         (-[WebView _loadBackForwardListFromOtherView:]):
 275         (-[WebView goToBackForwardItem:]):
 276
 277 2018-03-22  Tim Horton  <timothy_horton@apple.com>
 278
 279         Improve readability of WebCore's OTHER_LDFLAGS
 280         https://bugs.webkit.org/show_bug.cgi?id=183909
 281         <rdar://problem/38760992>
 282
 283         Reviewed by Dan Bernstein.
 284
 285         * Configurations/Base.xcconfig:
 286         * Configurations/FeatureDefines.xcconfig:
 287
 288 2018-03-20  Tim Horton  <timothy_horton@apple.com>
 289
 290         Enable the minimal simulator feature flag when appropriate
 291         https://bugs.webkit.org/show_bug.cgi?id=183807
 292
 293         Reviewed by Dan Bernstein.
 294
 295         * Configurations/FeatureDefines.xcconfig:
 296
 297 2018-03-20  Tim Horton  <timothy_horton@apple.com>
 298
 299         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
 300         https://bugs.webkit.org/show_bug.cgi?id=183758
 301         <rdar://problem/38017644>
 302
 303         Reviewed by Dan Bernstein.
 304
 305         * Configurations/FeatureDefines.xcconfig:
 306
 307 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
 308
 309         Clear style colors when setting default appearance
 310         https://bugs.webkit.org/show_bug.cgi?id=183759
 311
 312         Reviewed by Tim Horton.
 313
 314         Colors are cached and need to be cleared and recalculated.
 315         Refactor to do all style recalcs together.
 316
 317         * WebView/WebView.mm:
 318         (-[WebView _setDefaultAppearanceAndClearStyle]):
 319         (-[WebView _setUseSystemAppearance:]):
 320         (-[WebView effectiveAppearanceDidChange]):
 321
 322 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
 323
 324         Unreviewed, another quick fix for r229699
 325
 326         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
 327
 328         * Configurations/FeatureDefines.xcconfig:
 329
 330 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
 331
 332         Ensure that style is updated when the effective appearance changes
 333         https://bugs.webkit.org/show_bug.cgi?id=183690
 334         <rdar://problem/38385900>
 335
 336         Reviewed by Tim Horton and Wenson Hsieh.
 337
 338         Respond to and respect the effective appearance changing.
 339
 340         * WebView/WebView.mm:
 341         (-[WebView _setUseSystemAppearance:]):
 342         (-[WebView effectiveAppearanceDidChange]):
 343
 344 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
 345
 346         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
 347         https://bugs.webkit.org/show_bug.cgi?id=183677
 348
 349         Reviewed by Tim Horton.
 350
 351         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
 352
 353         * DOM/DOM.mm:
 354         (-[DOMHTMLLinkElement _mediaQueryMatches]):
 355
 356 2018-03-14  Tim Horton  <timothy_horton@apple.com>
 357
 358         Fix the build after r229567
 359
 360         * Configurations/FeatureDefines.xcconfig:
 361
 362 2018-03-12  Tim Horton  <timothy_horton@apple.com>
 363
 364         Stop using SDK conditionals to control feature definitions
 365         https://bugs.webkit.org/show_bug.cgi?id=183430
 366         <rdar://problem/38251619>
 367
 368         Reviewed by Dan Bernstein.
 369
 370         * Configurations/FeatureDefines.xcconfig:
 371         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
 372
 373 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
 374
 375         Runtime flag for link prefetch and remove link subresource.
 376         https://bugs.webkit.org/show_bug.cgi?id=183540
 377
 378         Reviewed by Chris Dumez.
 379
 380         Remove the LINK_PREFETCH build time flag.
 381
 382         * Configurations/FeatureDefines.xcconfig:
 383
 384 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
 385
 386         Remove GridLayout runtime flag
 387         https://bugs.webkit.org/show_bug.cgi?id=183484
 388
 389         Reviewed by Myles C. Maxfield.
 390
 391         The Grid Layout feature has been enabled by default for almost a
 392         year, so I think it's time to remove the runtime flag and the
 393
 394         * WebView/WebPreferenceKeysPrivate.h:
 395         * WebView/WebPreferences.mm:
 396         (+[WebPreferences initialize]):
 397         * WebView/WebPreferencesPrivate.h:
 398         * WebView/WebView.mm:
 399         (-[WebView _preferencesChanged:]):
 400
 401 2018-03-12  Antoine Quint  <graouts@apple.com>
 402
 403         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
 404         https://bugs.webkit.org/show_bug.cgi?id=183504
 405         <rdar://problem/38372965>
 406
 407         Reviewed by Dean Jackson and Jon Lee.
 408
 409         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
 410         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
 411
 412         * WebView/WebPreferenceKeysPrivate.h:
 413         * WebView/WebPreferences.mm:
 414         (+[WebPreferences initialize]):
 415         (-[WebPreferences setModernMediaControlsEnabled:]):
 416         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
 417         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
 418         * WebView/WebPreferencesPrivate.h:
 419         * WebView/WebView.mm:
 420         (-[WebView _preferencesChanged:]):
 421
 422 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
 423
 424         Media query for default appearance
 425         https://bugs.webkit.org/show_bug.cgi?id=183539
 426         <rdar://problem/38326388>
 427
 428         Reviewed by Tim Horton.
 429
 430         Write a media query to evaluate appearance.
 431
 432         * WebView/WebView.mm:
 433         (-[WebView _commonInitializationWithFrameName:groupName:]):
 434         (-[WebView _setUseSystemAppearance:]):
 435
 436 2018-03-09  Andy Estes  <aestes@apple.com>
 437
 438         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
 439         https://bugs.webkit.org/show_bug.cgi?id=183489
 440         <rdar://problem/38267517>
 441
 442         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
 443         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
 444         to issue a sandbox extension for this directory, but for security reasons App Sandbox
 445         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
 446         block with a nil error and a valid file URL, but no file will actually exist at that URL.
 447
 448         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
 449         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
 450         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
 451         drop destination.
 452
 453         Reviewed by Wenson Hsieh.
 454
 455         * WebView/WebView.mm:
 456         (-[WebView performDragOperation:]):
 457
 458 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
 459
 460         Allow WebViews to disable system appearance
 461         https://bugs.webkit.org/show_bug.cgi?id=183418
 462         <rdar://problem/36975642>
 463
 464         Reviewed by Tim Horton.
 465
 466         Allow webviews to choose whether or not to follow the default system appearance.
 467
 468         * WebView/WebView.mm:
 469         (-[WebView _setUseSystemAppearance:]):
 470         (-[WebView _useSystemAppearance]):
 471         * WebView/WebViewPrivate.h:
 472
 473 2018-03-08  Youenn Fablet  <youenn@apple.com>
 474
 475         libwebrtc update broke internal builds
 476         https://bugs.webkit.org/show_bug.cgi?id=183454
 477
 478         Reviewed by Eric Carlson.
 479
 480         * Configurations/WebKitLegacy.xcconfig:
 481
 482 2018-03-08  Chris Dumez  <cdumez@apple.com>
 483
 484         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
 485         https://bugs.webkit.org/show_bug.cgi?id=183455
 486         <rdar://problem/38191749>
 487
 488         Reviewed by Youenn Fablet.
 489
 490         Add a null check for the page as we have evidence from crashes that it can be null.
 491         Other functions in WebFrameNetworkingContext already null check the page as well,
 492         not just the frame so this is consistent.
 493
 494         * WebCoreSupport/WebFrameNetworkingContext.mm:
 495         (WebFrameNetworkingContext::storageSession const):
 496
 497 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
 498
 499         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
 500         https://bugs.webkit.org/show_bug.cgi?id=183429
 501
 502         Reviewed by Mark Lam.
 503
 504         * DOM/DOM.mm:
 505         (+[DOMNode _nodeFromJSWrapper:]):
 506         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
 507         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
 508         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
 509         * Plugins/Hosted/ProxyInstance.mm:
 510         (WebKit::ProxyInstance::invokeMethod):
 511         * WebView/WebView.mm:
 512         (aeDescFromJSValue):
 513
 514 2018-03-08  Tim Horton  <timothy_horton@apple.com>
 515
 516         Stop linking ApplicationServices directly
 517         https://bugs.webkit.org/show_bug.cgi?id=182867
 518         <rdar://problem/38252142>
 519
 520         Reviewed by Alex Christensen.
 521
 522         The frameworks that we use that live inside ApplicationServices
 523         have mostly moved out, so import them directly.
 524
 525         * Carbon/CarbonUtils.h:
 526         * WebKitPrefix.h:
 527         * WebView/WebHTMLView.mm:
 528         * WebView/WebPDFView.mm:
 529
 530 2018-03-07  Tim Horton  <timothy_horton@apple.com>
 531
 532         Sort and separate FeatureDefines.xcconfig
 533         https://bugs.webkit.org/show_bug.cgi?id=183427
 534
 535         Reviewed by Dan Bernstein.
 536
 537         * Configurations/FeatureDefines.xcconfig:
 538         Sort and split FeatureDefines into paragraphs
 539         (to make it easier to sort later).
 540
 541 2018-03-07  Youenn Fablet  <youenn@apple.com>
 542
 543         Match unsupported plugins based on domains and not origin
 544         https://bugs.webkit.org/show_bug.cgi?id=183384
 545
 546         Reviewed by Chris Dumez.
 547
 548         * WebCoreSupport/WebPluginInfoProvider.h:
 549         * WebCoreSupport/WebPluginInfoProvider.mm:
 550         (WebPluginInfoProvider::getPluginInfo):
 551         (WebPluginInfoProvider::getWebVisiblePluginInfo):
 552
 553 2018-03-05  Andy Estes  <aestes@apple.com>
 554
 555         [Mac] Teach WebCore::Pasteboard about file promise drags
 556         https://bugs.webkit.org/show_bug.cgi?id=183314
 557         <rdar://problem/38105493>
 558
 559         Reviewed by Darin Adler.
 560
 561         Added a FIXME comment.
 562
 563         * WebView/WebView.mm:
 564         (-[WebView performDragOperation:]):
 565
 566 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
 567
 568         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
 569         https://bugs.webkit.org/show_bug.cgi?id=183312
 570
 571         Reviewed by Mark Lam.
 572
 573         Remove wtf/CurrentTime.h include pragma.
 574
 575         * WebView/WebFrame.mm:
 576         * WebView/WebPDFView.mm:
 577
 578 2018-03-04  Tim Horton  <timothy_horton@apple.com>
 579
 580         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
 581         https://bugs.webkit.org/show_bug.cgi?id=183283
 582         <rdar://problem/38062148>
 583
 584         Reviewed by Sam Weinig.
 585
 586         * Configurations/FeatureDefines.xcconfig:
 587
 588 2018-02-28  Alex Christensen  <achristensen@webkit.org>
 589
 590         Reduce use of NetworkingContext in WebKit
 591         https://bugs.webkit.org/show_bug.cgi?id=183213
 592
 593         Reviewed by Brady Eidson.
 594
 595         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
 596         (WebKit::NetscapePluginInstanceProxy::getProxy):
 597         * Plugins/WebNetscapePluginView.mm:
 598         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
 599
 600 2018-02-17  Darin Adler  <darin@apple.com>
 601
 602         Prepare for ExtendedColor changes (first step)
 603         https://bugs.webkit.org/show_bug.cgi?id=182904
 604
 605         Reviewed by Sam Weinig.
 606
 607         * Misc/WebKitNSStringExtras.mm:
 608         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
 609
 610 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
 611
 612         Remove currentTime() / currentTimeMS()
 613         https://bugs.webkit.org/show_bug.cgi?id=183052
 614
 615         Reviewed by Mark Lam.
 616
 617         * WebCoreSupport/WebFrameLoaderClient.h:
 618         * WebCoreSupport/WebFrameLoaderClient.mm:
 619         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
 620
 621 2018-02-16  Youenn Fablet  <youenn@apple.com>
 622
 623         Allow specifying which plug-ins are supported
 624         https://bugs.webkit.org/show_bug.cgi?id=182748
 625
 626         Reviewed by Chris Dumez.
 627
 628         * WebCoreSupport/WebPluginInfoProvider.h:
 629         * WebCoreSupport/WebPluginInfoProvider.mm:
 630         (WebPluginInfoProvider::getPluginInfo):
 631         (WebPluginInfoProvider::getWebVisiblePluginInfo):
 632
 633 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
 634
 635         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
 636         https://bugs.webkit.org/show_bug.cgi?id=182882
 637         <rdar://problem/35672661>
 638
 639         Reviewed by Dan Bernstein.
 640
 641         Make sure the smart pointer hold the collection of subviews lives at least as
 642         long as the loop using it.
 643
 644         * WebView/WebHTMLView.mm:
 645         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
 646
 647 2018-02-14  Daniel Bates  <dabates@apple.com>
 648
 649         Disallow cross-origin subresources from asking for credentials
 650         https://bugs.webkit.org/show_bug.cgi?id=182579
 651         <rdar://problem/36162271>
 652
 653         Reviewed by Andy Estes.
 654
 655         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
 656         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
 657
 658         * WebView/WebPreferenceKeysPrivate.h:
 659         * WebView/WebPreferences.mm:
 660         (+[WebPreferences initialize]):
 661         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
 662         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
 663         * WebView/WebPreferencesPrivate.h:
 664         * WebView/WebView.mm:
 665         (-[WebView _preferencesChanged:]):
 666
 667 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
 668
 669         Remove ForwardingHeaders directory from WebKitLegacy/mac.
 670         https://bugs.webkit.org/show_bug.cgi?id=182738
 671
 672         Reviewed by Darin Adler.
 673
 674         * ForwardingHeaders/collector/handles/Global.h: Removed.
 675         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
 676         * ForwardingHeaders/runtime/Completion.h: Removed.
 677         * ForwardingHeaders/runtime/Error.h: Removed.
 678         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
 679         * ForwardingHeaders/runtime/JSFunction.h: Removed.
 680         * ForwardingHeaders/runtime/JSLock.h: Removed.
 681         * ForwardingHeaders/runtime/JSObject.h: Removed.
 682         * ForwardingHeaders/runtime/JSString.h: Removed.
 683         * ForwardingHeaders/runtime/Protect.h: Removed.
 684         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
 685
 686 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
 687
 688         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
 689         https://bugs.webkit.org/show_bug.cgi?id=182641
 690
 691         Reviewed by Dan Bernstein.
 692
 693         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
 694         https://trac.webkit.org/changeset/228308.
 695
 696         * WebView/WebVideoFullscreenController.h:
 697         * WebView/WebVideoFullscreenHUDWindowController.mm:
 698         * WebView/WebWindowAnimation.h:
 699         * WebView/WebWindowAnimation.mm:
 700         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
 701         (WebCore::scaledRect): Deleted.
 702         (WebCore::squaredDistance): Deleted.
 703
 704 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
 705
 706         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
 707
 708         * WebView/WebWindowAnimation.mm:
 709         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
 710
 711 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
 712
 713         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
 714         https://bugs.webkit.org/show_bug.cgi?id=182615
 715
 716         Reviewed by Eric Carlson.
 717
 718         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
 719         Ideally, we should not reference NSApp in WebCore.
 720
 721         * WebView/WebFullScreenController.mm:
 722         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
 723         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
 724         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
 725         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
 726         * WebView/WebView.mm:
 727         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
 728         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
 729
 730 2018-01-13  Darin Adler  <darin@apple.com>
 731
 732         Event improvements
 733         https://bugs.webkit.org/show_bug.cgi?id=179591
 734
 735         Reviewed by Chris Dumez.
 736
 737         * DOM/DOMWheelEvent.mm:
 738         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
 739         Call initWebKitWheelEvent.
 740
 741         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
 742         * WebCoreSupport/WebInspectorClient.mm: Ditto.
 743         * WebView/WebFrame.mm: Ditto.
 744
 745         * WebView/WebHTMLView.mm:
 746         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
 747         underlyingPlatformEvent.
 748         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
 749
 750         * WebView/WebScriptWorld.mm:
 751         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
 752
 753         * WebView/WebView.mm: Removed include of ScriptValue.h.
 754
 755 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
 756
 757         Remove WebCore/ForwardingHeaders directory
 758         https://bugs.webkit.org/show_bug.cgi?id=182347
 759
 760         Reviewed by Keith Miller.
 761
 762         * Carbon/CarbonWindowAdapter.mm:
 763         * DOM/WebDOMOperations.mm:
 764         * History/WebBackForwardList.mm:
 765         * History/WebHistoryItem.mm:
 766         * Misc/WebCache.mm:
 767         * Misc/WebElementDictionary.mm:
 768         * Misc/WebIconDatabase.mm:
 769         * Misc/WebStringTruncator.mm:
 770         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
 771         * Plugins/Hosted/ProxyInstance.mm:
 772         * Plugins/Hosted/ProxyRuntimeObject.mm:
 773         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 774         * Plugins/WebBaseNetscapePluginView.mm:
 775         * Plugins/WebBasePluginPackage.mm:
 776         * Plugins/WebNetscapePluginStream.mm:
 777         * Plugins/WebNetscapePluginView.mm:
 778         * Plugins/WebPluginController.mm:
 779         * WebCoreSupport/WebEditorClient.mm:
 780         * WebCoreSupport/WebFrameLoaderClient.mm:
 781         * WebCoreSupport/WebInspectorClient.h:
 782         * WebCoreSupport/WebInspectorClient.mm:
 783         * WebView/WebDataSource.mm:
 784         * WebView/WebFrame.mm:
 785         * WebView/WebHTMLRepresentation.mm:
 786         * WebView/WebHTMLView.mm:
 787         * WebView/WebPreferences.mm:
 788         * WebView/WebScriptDebugDelegate.mm:
 789         * WebView/WebScriptDebugger.h:
 790         * WebView/WebTextIterator.mm:
 791         * WebView/WebView.mm:
 792         * WebView/WebViewData.mm:
 793
 794 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
 795
 796         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
 797         https://bugs.webkit.org/show_bug.cgi?id=182312
 798
 799         Reviewed by Michael Catanzaro.
 800
 801         * WebKitPrefix.h:
 802
 803 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
 804
 805         [WebAuthN] Add a compile-time feature flag
 806         https://bugs.webkit.org/show_bug.cgi?id=182211
 807         <rdar://problem/36936365>
 808
 809         Reviewed by Brent Fulgham.
 810
 811         * Configurations/FeatureDefines.xcconfig:
 812
 813 2018-01-27  Dan Bernstein  <mitz@apple.com>
 814
 815         HaveInternalSDK includes should be "#include?"
 816         https://bugs.webkit.org/show_bug.cgi?id=179670
 817
 818         * Configurations/Base.xcconfig:
 819
 820 2018-01-24  Alex Christensen  <achristensen@webkit.org>
 821
 822         Remove unused QTKit preference
 823         https://bugs.webkit.org/show_bug.cgi?id=181968
 824
 825         Reviewed by Alexey Proskuryakov.
 826
 827         * WebView/WebPreferenceKeysPrivate.h:
 828         * WebView/WebPreferences.mm:
 829         (+[WebPreferences initialize]):
 830         (-[WebPreferences setQTKitEnabled:]): Deleted.
 831         (-[WebPreferences isQTKitEnabled]): Deleted.
 832         * WebView/WebPreferencesPrivate.h:
 833         * WebView/WebView.mm:
 834         (-[WebView _preferencesChanged:]):
 835
 836 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 837
 838         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
 839         https://bugs.webkit.org/show_bug.cgi?id=182037
 840         <rdar://problem/36747812>
 841
 842         Reviewed by Ryosuke Niwa.
 843
 844         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
 845         for more details.
 846
 847         * WebView/WebHTMLRepresentation.mm:
 848         (-[WebHTMLRepresentation elementWithName:inForm:]):
 849         (-[WebHTMLRepresentation controlsInForm:]):
 850
 851 2018-01-23  Alex Christensen  <achristensen@webkit.org>
 852
 853         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
 854         https://bugs.webkit.org/show_bug.cgi?id=181961
 855
 856         Reviewed by Michael Catanzaro.
 857
 858         * WebView/WebPreferences.mm:
 859
 860 2018-01-23  Commit Queue  <commit-queue@webkit.org>
 861
 862         Unreviewed, rolling out r227437.
 863         https://bugs.webkit.org/show_bug.cgi?id=182011
 864
 865         broke build (Requested by alexchristensen on #webkit).
 866
 867         Reverted changeset:
 868
 869         "Remove unused QTKit preference"
 870         https://bugs.webkit.org/show_bug.cgi?id=181968
 871         https://trac.webkit.org/changeset/227437
 872
 873 2018-01-23  Alex Christensen  <achristensen@webkit.org>
 874
 875         Remove unused QTKit preference
 876         https://bugs.webkit.org/show_bug.cgi?id=181968
 877
 878         Reviewed by Alexey Proskuryakov.
 879
 880         * WebView/WebPreferenceKeysPrivate.h:
 881         * WebView/WebPreferences.mm:
 882         (+[WebPreferences initialize]):
 883         (-[WebPreferences setQTKitEnabled:]): Deleted.
 884         (-[WebPreferences isQTKitEnabled]): Deleted.
 885         * WebView/WebPreferencesPrivate.h:
 886         * WebView/WebView.mm:
 887         (-[WebView _preferencesChanged:]):
 888
 889 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 890
 891         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
 892         https://bugs.webkit.org/show_bug.cgi?id=181960
 893         <rdar://problem/36431678>
 894
 895         Reviewed by Tim Horton.
 896
 897         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
 898         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
 899         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
 900
 901         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
 902         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
 903         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
 904
 905         * WebView/WebView.mm:
 906         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
 907
 908 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
 909
 910         Turning off custom pasteboard data doesn't actually turn it off in WK2
 911         https://bugs.webkit.org/show_bug.cgi?id=181920
 912         <rdar://problem/36686429>
 913
 914         Reviewed by Wenson Hsieh.
 915
 916         Always disable custom pasteboard data in WebKit1. See r226156 for details.
 917
 918         * WebView/WebPreferences.mm:
 919         (+[WebPreferences initialize]):
 920         * WebView/WebView.mm:
 921         (-[WebView _preferencesChanged:]):
 922
 923 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 924
 925         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
 926         https://bugs.webkit.org/show_bug.cgi?id=181918
 927
 928         Reviewed by Tim Horton.
 929
 930         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
 931
 932         * Configurations/FeatureDefines.xcconfig:
 933
 934 2018-01-20  Andy Estes  <aestes@apple.com>
 935
 936         [Apple Pay] Stop eagerly loading PassKit.framework
 937         https://bugs.webkit.org/show_bug.cgi?id=181911
 938         <rdar://problem/36555369>
 939
 940         Reviewed by Tim Horton.
 941
 942         * WebCoreSupport/WebPaymentCoordinatorClient.h:
 943         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
 944         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
 945
 946         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
 947
 948 2018-01-19  Dean Jackson  <dino@apple.com>
 949
 950         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
 951         https://bugs.webkit.org/show_bug.cgi?id=181817
 952         <rdar://problem/35274055>
 953
 954         Reviewed by Simon Fraser.
 955
 956         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
 957
 958         * Misc/WebKitVersionChecks.h:
 959         * WebView/WebView.mm:
 960         (-[WebView _commonInitializationWithFrameName:groupName:]):
 961
 962 2018-01-19  Alex Christensen  <achristensen@webkit.org>
 963
 964         Remove unused WebViewPrivate _allowCookies
 965         https://bugs.webkit.org/show_bug.cgi?id=181812
 966
 967         Reviewed by Tim Horton.
 968
 969         * WebView/WebView.mm:
 970         (+[WebView _setAllowCookies:]): Deleted.
 971         (+[WebView _allowCookies]): Deleted.
 972         * WebView/WebViewPrivate.h:
 973
 974 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
 975
 976         Build fix, remove a call to -[NSWindow setOneShot:]
 977         https://bugs.webkit.org/show_bug.cgi?id=181809
 978
 979         Reviewed by Tim Horton.
 980
 981         * WebView/WebTextCompletionController.mm:
 982         (-[WebTextCompletionController _buildUI]):
 983
 984 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
 985
 986         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
 987
 988         * Carbon/HIWebView.mm:
 989         (overrideCGContext):
 990         (restoreCGContext):
 991
 992 2018-01-18  Dan Bernstein  <mitz@apple.com>
 993
 994         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
 995         https://bugs.webkit.org/show_bug.cgi?id=181803
 996
 997         Reviewed by Tim Horton.
 998
 999         * Configurations/Base.xcconfig: Updated.
1000         * Configurations/DebugRelease.xcconfig: Ditto.
1001         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1002         * Configurations/Version.xcconfig: Updated.
1003         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1004           useful for defining settings that depend on the target macOS version.
1005
1006 2018-01-17  Youenn Fablet  <youenn@apple.com>
1007
1008         Put fetch Request.keepalive behind a runtime flag
1009         https://bugs.webkit.org/show_bug.cgi?id=181592
1010
1011         Reviewed by Chris Dumez.
1012
1013         * WebView/WebPreferenceKeysPrivate.h:
1014         * WebView/WebPreferences.mm:
1015         (+[WebPreferences initialize]):
1016         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1017         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1018         * WebView/WebPreferencesPrivate.h:
1019         * WebView/WebView.mm:
1020         (-[WebView _preferencesChanged:]):
1021
1022 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1023
1024         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1025         https://bugs.webkit.org/show_bug.cgi?id=181637
1026         <rdar://problem/36508471>
1027
1028         Reviewed by Tim Horton.
1029
1030         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1031
1032         * WebCoreSupport/WebEditorClient.h:
1033         * WebCoreSupport/WebEditorClient.mm:
1034         (WebEditorClient::replacementURLForResource):
1035
1036 2018-01-11  Keith Miller  <keith_miller@apple.com>
1037
1038         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1039         https://bugs.webkit.org/show_bug.cgi?id=181573
1040
1041         Reviewed by Simon Fraser.
1042
1043         * Configurations/FeatureDefines.xcconfig:
1044
1045 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1046
1047         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1048         https://bugs.webkit.org/show_bug.cgi?id=181497
1049
1050         Reviewed by Tim Horton.
1051
1052         See other ChangeLogs for more detail.
1053
1054         * WebCoreSupport/WebDragClient.h:
1055
1056 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1057
1058         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1059         https://bugs.webkit.org/show_bug.cgi?id=181523
1060         <rdar://problem/28959131>
1061
1062         Reviewed by Alex Christensen.
1063
1064         * WebView/WebImmediateActionController.mm:
1065         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1066         Apply the change made in r216652 to WebKit1's immediate action controller.
1067
1068         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1069         the startContainer of the range is in an anonymous node.
1070
1071 2018-01-11  Youenn Fablet  <youenn@apple.com>
1072
1073         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1074         https://bugs.webkit.org/show_bug.cgi?id=181480
1075
1076         Reviewed by Eric Carlson.
1077
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]):
1080
1081 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1082
1083         Fix check-webkit-style issues with WebNSDataExtras.mm
1084         <https://webkit.org/b/181369>
1085
1086         Reviewed by Alex Christensen.
1087
1088         * Misc/WebNSDataExtras.mm:
1089         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1090         (-[NSData _webkit_guessedMIMETypeForXML]):
1091         (-[NSData _webkit_guessedMIMEType]):
1092         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1093         (_findEOL):
1094         (-[NSData _webkit_parseRFC822HeaderFields]):
1095         (-[NSData _web_locationAfterFirstBlankLine]):
1096         - Fix all the check-webkit-style warnings.
1097
1098 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1099
1100         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1101         <https://webkit.org/b/181256>
1102         <rdar://problem/36281730>
1103
1104         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1105         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1106         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1107           to avoid warnings from casting CFStringRef to NPNSString*.
1108           Note that CFMutableStringRef is the same as CFStringRef
1109           without the const modifier, hence its use in the const_cast<>
1110           above.
1111
1112 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1113
1114         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1115         <https://webkit.org/b/181256>
1116         <rdar://problem/36281730>
1117
1118         * Carbon/HIWebView.mm:
1119         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1120         checked_cf_cast<CFRunLoopRef>() to fix warning.
1121
1122 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1123
1124         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1125         <https://webkit.org/b/181256>
1126         <rdar://problem/36281730>
1127
1128         Reviewed by Darin Adler.
1129
1130         * Carbon/CarbonUtils.m:
1131         (PoolCleaner):
1132         - Use #pragmas to ignore -Wcast-qual warnings when using a
1133           C-style cast from CFTypeRef to CFRunloopRef.
1134         * Carbon/CarbonWindowFrame.m:
1135         (-[CarbonWindowFrame title]):
1136         - Use #pragmas to ignore -Wcast-qual warnings when using a
1137           C-style cast from CFStringRef to NSString *.
1138         * Carbon/HIViewAdapter.m:
1139         (+[HIViewAdapter getHIViewForNSView:]):
1140         - Use #pragmas to ignore -Wcast-qual warnings when using a
1141           C-style cast from CFTypeRef to HIViewRef.
1142         * Configurations/Base.xcconfig:
1143         (WARNING_CFLAGS): Add -Wcast-qual.
1144         * Misc/WebElementDictionary.mm:
1145         (-[WebElementDictionary objectForKey:]):
1146         - Use static_cast<SEL>(const_cast<void*>()) to fix
1147           warning.
1148         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1149         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1150         (-[NSData _webkit_guessedMIMETypeForXML]):
1151         (-[NSData _webkit_guessedMIMEType]):
1152         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1153         (_findEOL):
1154         (-[NSData _webkit_parseRFC822HeaderFields]):
1155         (-[NSData _web_startsWithBlankLine]):
1156         (-[NSData _web_locationAfterFirstBlankLine]):
1157         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1158           type to Objective-C++.  This fixes the warnings about
1159           discarding the `const` modifier when casing from CFStringRef
1160           to NSString * because in older clang versions, -Wcast-qual was
1161           completely broken when compiling C++ and Objective-C++ source
1162           files.  In newer clang versions, discarding the `const`
1163           modifier for toll-free bridged types is ignored when compiling
1164           Objective-C++ source.
1165         - Update copyright and license header.
1166         - Use reinterpret_cast<> and static_cast<> to fix warnings
1167           unrelated to (NSString *) C-style casts.
1168         - Replace use of MIN() macro with std::min<> template functions.
1169         - Fix location of `*` for local variables modified above.
1170         * Plugins/Hosted/NetscapePluginHostManager.mm:
1171         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1172         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1173         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1174         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1175           warnings.
1176         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1177         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1178         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1179           to fix warning.
1180         * Plugins/Hosted/ProxyInstance.mm:
1181         (WebKit::ProxyInstance::invoke):
1182         - Use static_cast<char*>(const_cast<void*>()) to fix
1183           warning when using -[NSData bytes].
1184         (WebKit::ProxyInstance::fieldValue const):
1185         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1186           to fix warning when using CFDataGetBytePtr().
1187         * Plugins/Hosted/WebTextInputWindowController.m:
1188         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1189         - Use #pragma to ignore -Wcast-qual warning since there
1190           is not a good way to avoid this warning in Objective-C.
1191         * Plugins/WebNetscapePluginStream.mm:
1192         (WebNetscapePluginStream::deliverData):
1193         - Use const_cast<void*>() to fix warning when using
1194           -[NSData bytes].
1195         * Plugins/WebNetscapePluginView.mm:
1196         (-[WebNetscapePluginView _createPlugin]):
1197         - Change C-style cast to const_cast<char*>() to fix
1198           warning.
1199         * WebCoreSupport/WebChromeClient.mm:
1200         (WebChromeClient::wrapCryptoKey const):
1201         (WebChromeClient::unwrapCryptoKey const):
1202         - Change C-style cast to
1203           static_cast<uint8_t*>(const_cast<void*>() to fix
1204           warning.
1205         * WebView/WebPDFView.mm:
1206         (_applicationInfoForMIMEType):
1207         - Change local variable type from 'NSURL *' to
1208           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1209           when calling -[NSURL path].
1210
1211 2018-01-05  Dan Bernstein  <mitz@apple.com>
1212
1213         Fixed the build following AppKit API deprecations in a recent SDKs
1214
1215         * WebView/WebFullScreenController.mm:
1216         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1217         (-[WebFullScreenController exitFullScreen]): Ditto.
1218         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1219         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1220         * WebView/WebHTMLView.mm:
1221         (-[WebHTMLView drawRect:]): Ditto.
1222         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1223         (-[WebHTMLView knowsPageRange:]): Ditto.
1224         * WebView/WebView.mm:
1225         (LayerFlushController::flushLayers): Ditto.
1226
1227 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1228
1229         [Attachment Support] Create attachment elements when dropping files on iOS
1230         https://bugs.webkit.org/show_bug.cgi?id=181192
1231         <rdar://problem/36280945>
1232
1233         Reviewed by Tim Horton.
1234
1235         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1236
1237         * WebCoreSupport/WebPlatformStrategies.h:
1238         * WebCoreSupport/WebPlatformStrategies.mm:
1239         (WebPlatformStrategies::informationForItemAtIndex):
1240         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1241
1242 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1243
1244         [Attachment Support] Add plumbing for starting a drag with promised blob data
1245         https://bugs.webkit.org/show_bug.cgi?id=181201
1246
1247         Reviewed by Tim Horton.
1248
1249         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1250
1251         * WebCoreSupport/WebDragClient.h:
1252
1253 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1254
1255         Add a WebAuthentication runtime feature flag
1256         https://bugs.webkit.org/show_bug.cgi?id=181220
1257         <rdar://problem/36055305>
1258
1259         Reviewed by Brent Fulgham.
1260
1261         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1262
1263         * WebView/WebPreferenceKeysPrivate.h:
1264         * WebView/WebPreferences.mm:
1265         (+[WebPreferences initialize]):
1266         (-[WebPreferences webAuthenticationEnabled]):
1267         (-[WebPreferences setWebAuthenticationEnabled:]):
1268         (-[WebPreferences credentialManagementEnabled]): Deleted.
1269         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1270         * WebView/WebPreferencesPrivate.h:
1271         * WebView/WebView.mm:
1272         (-[WebView _preferencesChanged:]):
1273
1274 2017-12-22  Jeff Miller  <jeffm@apple.com>
1275
1276         Update user-visible copyright strings to include 2018
1277         https://bugs.webkit.org/show_bug.cgi?id=181141
1278
1279         Reviewed by Dan Bernstein.
1280
1281         * Info.plist:
1282
1283 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1284
1285         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1286         https://bugs.webkit.org/show_bug.cgi?id=181188
1287
1288         Reviewed by Dan Bernstein.
1289
1290         See WebCore/ChangeLog for more detail.
1291
1292         * WebCoreSupport/WebDragClient.h:
1293         * WebCoreSupport/WebDragClient.mm:
1294         (WebDragClient::declareAndWriteAttachment): Deleted.
1295         * WebView/WebHTMLView.mm:
1296         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1297
1298 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1299
1300         Unreviewed, continue to fix build failures due to AppKit API deprecation
1301
1302         Wraps more code in -Wdeprecated-declarations.
1303
1304         * Carbon/HIWebView.mm:
1305         (overrideCGContext):
1306
1307 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1308
1309         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1310
1311         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1312
1313         * Carbon/CarbonWindowAdapter.mm:
1314         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1315         * Plugins/WebNetscapePluginView.mm:
1316         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1317         (-[WebNetscapePluginView sendDrawRectEvent:]):
1318         (-[WebNetscapePluginView drawRect:]):
1319
1320 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1321
1322         Fix build failures due to using deprecated AppKit symbols
1323         https://bugs.webkit.org/show_bug.cgi?id=181110
1324         <rdar://problem/36162865>
1325
1326         Reviewed by Dan Bernstein and Tim Horton.
1327
1328         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1329
1330         * Misc/WebKitNSStringExtras.mm:
1331         (-[NSString _web_drawAtPoint:font:textColor:]):
1332         * Misc/WebNSPasteboardExtras.h:
1333         * Misc/WebNSPasteboardExtras.mm:
1334         (+[NSPasteboard _web_writableTypesForURL]):
1335         (_createWritableTypesForImageWithoutArchive):
1336         (_createWritableTypesForImageWithArchive):
1337         (+[NSPasteboard _web_dragTypesForURL]):
1338         (-[NSPasteboard _web_bestURL]):
1339         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1340         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1341         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1342         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1343         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1344         * Panels/WebAuthenticationPanel.m:
1345         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1346         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1347         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1348         (-[WebHostedNetscapePluginView drawRect:]):
1349         * WebInspector/WebNodeHighlightView.mm:
1350         (-[WebNodeHighlightView drawRect:]):
1351         * WebView/WebFrame.mm:
1352         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1353         (-[WebFrame _drawRect:contentsOnly:]):
1354         * WebView/WebHTMLView.mm:
1355         (kit):
1356         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1357         (-[WebHTMLView _plainTextFromPasteboard:]):
1358         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1359         (+[WebHTMLView _insertablePasteboardTypes]):
1360         (+[WebHTMLView _selectionPasteboardTypes]):
1361         (-[WebHTMLView pasteboard:provideDataForType:]):
1362         (-[WebHTMLView _writeSelectionToPasteboard:]):
1363         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1364         (-[WebHTMLView validRequestorForSendType:returnType:]):
1365         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1366         (createMenuItem):
1367         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1368         (-[WebHTMLView _colorAsString:]):
1369         (-[WebHTMLView copyFont:]):
1370         * WebView/WebPDFView.mm:
1371         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1372         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1373         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1374         (-[WebPDFView pasteboardTypesForSelection]):
1375         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1376         * WebView/WebView.h:
1377         * WebView/WebView.mm:
1378         (-[WebView performDragOperation:]):
1379         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1380         (-[WebView _searchWithGoogleFromMenu:]):
1381
1382 2017-12-21  Youenn Fablet  <youenn@apple.com>
1383
1384         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1385         https://bugs.webkit.org/show_bug.cgi?id=181000
1386
1387         Reviewed by Chris Dumez.
1388
1389         * Misc/WebCache.mm:
1390         (+[WebCache addImageToCache:forURL:forFrame:]):
1391
1392 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1393
1394         Update FULLSCREEN_API feature defines.
1395         https://bugs.webkit.org/show_bug.cgi?id=181015
1396
1397         Reviewed by Tim Horton.
1398
1399         Change enabled iphone sdk for FULLSCREEN_API.
1400
1401         * Configurations/FeatureDefines.xcconfig:
1402
1403 2017-12-21  Jer Noble  <jer.noble@apple.com>
1404
1405         Add initial DOM support for Media Capabilities
1406         https://bugs.webkit.org/show_bug.cgi?id=181064
1407
1408         Reviewed by Eric Carlson.
1409
1410         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1411
1412         * WebView/WebPreferenceKeysPrivate.h:
1413         * WebView/WebPreferences.mm:
1414         (+[WebPreferences initialize]):
1415         (-[WebPreferences mediaCapabilitiesEnabled]):
1416         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1417         * WebView/WebPreferencesPrivate.h:
1418         * WebView/WebView.mm:
1419         (-[WebView _preferencesChanged:]):
1420
1421 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1422
1423         Enable picture-in-picture from inline element on suspend.
1424         https://bugs.webkit.org/show_bug.cgi?id=180942
1425         rdar://problem/34745234
1426
1427         Reviewed by Jer Noble.
1428
1429         Update signature of enterVideoFullscreenForVideoElement().
1430
1431         * WebCoreSupport/WebChromeClient.h:
1432         * WebCoreSupport/WebChromeClient.mm:
1433         (WebChromeClient::enterVideoFullscreenForVideoElement):
1434
1435 2017-12-20  Daniel Bates  <dabates@apple.com>
1436
1437         Remove Alternative Presentation Button
1438         https://bugs.webkit.org/show_bug.cgi?id=180500
1439         <rdar://problem/35891047>
1440
1441         Reviewed by Simon Fraser.
1442
1443         We no longer need the alternative presentation button.
1444
1445         * Configurations/FeatureDefines.xcconfig:
1446
1447 2017-12-19  Jer Noble  <jer.noble@apple.com>
1448
1449         Playing media elements which call "pause(); play()" will have the play promise rejected.
1450         https://bugs.webkit.org/show_bug.cgi?id=180781
1451         <rdar://problem/33191377>
1452
1453         Reviewed by Eric Carlson.
1454
1455         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1456
1457         * WebView/WebView.mm:
1458         (shouldRequireUserGestureToLoadVideo):
1459
1460 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1463         https://bugs.webkit.org/show_bug.cgi?id=180977
1464
1465         Reviewed by Tim Horton.
1466
1467         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1468         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1469         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1470
1471         * WebCoreSupport/WebEditorClient.mm:
1472         (attributesForAttributedStringConversion):
1473         * WebView/WebHTMLView.mm:
1474         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1475
1476 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1477
1478         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1479
1480         Attempt to fix the following warnings:
1481
1482             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1483
1484         For the following instance variables:
1485
1486             _borderView
1487             _contentView
1488             _frame
1489             _wFlags
1490
1491         * Carbon/CarbonWindowAdapter.mm:
1492         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1493         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1494         (-[CarbonWindowAdapter _termWindowIfOwner]):
1495         (-[CarbonWindowAdapter _windowMovedToRect:]):
1496         (-[CarbonWindowAdapter setContentView:]):
1497         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1498         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1499
1500 2017-12-16  Dan Bernstein  <mitz@apple.com>
1501
1502         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1503         https://bugs.webkit.org/show_bug.cgi?id=180613
1504         <rdar://problem/35946124>
1505
1506         Reviewed by Geoff Garen.
1507
1508         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1509           clients.
1510         * WebView/WebDynamicScrollBarsView.h: Ditto.
1511         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1512
1513 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1514
1515         Enable -Wstrict-prototypes for WebKit
1516         <https://webkit.org/b/180757>
1517         <rdar://problem/36024132>
1518
1519         Rubber-stamped by Joseph Pecoraro.
1520
1521         * Configurations/Base.xcconfig:
1522         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1523
1524 2017-12-14  John Wilander  <wilander@apple.com>
1525
1526         Storage Access API: Implement frame-specific access in the document.cookie layer
1527         https://bugs.webkit.org/show_bug.cgi?id=180682
1528         <rdar://problem/35982257>
1529
1530         Reviewed by Alex Christensen.
1531
1532         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1533         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1534         CookiesStrategy::getRawCookies() now take optional parameters for
1535         frameID and pageID to allow frame-specific scoping of cookies.
1536
1537         This change makes the return values of FrameLoaderClient::frameID()
1538         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1539         WebCore can call those getters and get the right return values in
1540         WebKit and std:nullopt in WebKitLegacy.
1541
1542         * WebCoreSupport/WebFrameLoaderClient.h:
1543         * WebCoreSupport/WebFrameLoaderClient.mm:
1544         (WebFrameLoaderClient::pageID const):
1545         (WebFrameLoaderClient::frameID const):
1546         * WebCoreSupport/WebPlatformStrategies.h:
1547         * WebCoreSupport/WebPlatformStrategies.mm:
1548         (WebPlatformStrategies::cookiesForDOM):
1549         (WebPlatformStrategies::setCookiesFromDOM):
1550         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1551         (WebPlatformStrategies::getRawCookies):
1552
1553 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1554
1555         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1556         https://bugs.webkit.org/show_bug.cgi?id=180689
1557
1558         Reviewed by Tim Horton.
1559
1560         Use sRGBColorSpaceRef() from WebCore.
1561
1562         * WebView/WebHTMLView.mm:
1563         (imageFromRect):
1564
1565 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1566
1567         Stop using deprecated target conditional for simulator builds
1568         https://bugs.webkit.org/show_bug.cgi?id=180662
1569         <rdar://problem/35136156>
1570
1571         Reviewed by Simon Fraser.
1572
1573         * postprocess-headers.sh:
1574
1575 2017-12-11  David Quesada  <david_quesada@apple.com>
1576
1577         Turn on ENABLE_APPLICATION_MANIFEST
1578         https://bugs.webkit.org/show_bug.cgi?id=180562
1579         rdar://problem/35924737
1580
1581         Reviewed by Geoffrey Garen.
1582
1583         * Configurations/FeatureDefines.xcconfig:
1584
1585 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1586
1587         Remove pthread_once in favor of dispatch_once
1588         https://bugs.webkit.org/show_bug.cgi?id=180591
1589
1590         Reviewed by Saam Barati.
1591
1592         * Misc/WebKitErrors.m:
1593         (+[NSError _registerWebKitErrors]):
1594         (registerErrors): Deleted.
1595         * Storage/WebStorageManager.mm:
1596         (+[WebStorageManager _storageDirectoryPath]):
1597         (initializeLocalStoragePath): Deleted.
1598
1599 2017-12-07  Darin Adler  <darin@apple.com>
1600
1601         Remove some unused code from WebKitLegacy
1602         https://bugs.webkit.org/show_bug.cgi?id=180567
1603
1604         Reviewed by Anders Carlsson.
1605
1606         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1607         macOS (back a few versions) and iOS and removed unused
1608         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1609         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1610         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1611         _webkit_stringByCollapsingNonPrintingCharacters,
1612         _webkit_stringByCollapsingWhitespaceCharacters,
1613         _web_stringWithData:textEncodingName:, and
1614         _webkit_localStorageDirectoryWithBundleIdentifier:.
1615
1616         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1617         this source file.
1618         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1619         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1620         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1621         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1622         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1623         handle font smoothing options.
1624         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1625         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1626         from header and made it a little clearer.
1627         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1628         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1629         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1630         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1631         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1632         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1633         implementation a bit and used whole words instead of abbreviations.
1634         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1635
1636         * Misc/WebNSFileManagerExtras.mm:
1637         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1638         filenameByFixingIllegalCharacters function from WebCore directly instead of
1639         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1640
1641         * Plugins/WebBaseNetscapePluginView.mm:
1642         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1643         string replacements instead of _web_stringByStrippingReturnCharacters
1644         and to use NSString methods instead of CFString functions.
1645
1646 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1647
1648         Ignore deprecation warnings.
1649
1650         * WebView/WebHTMLView.mm:
1651         (-[NSWindow _web_borderView]):
1652         (-[WebHTMLView _setAsideSubviews]):
1653         * WebView/WebView.mm:
1654         (-[WebView encodeWithCoder:]):
1655
1656 2017-12-02  Darin Adler  <darin@apple.com>
1657
1658         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1659         https://bugs.webkit.org/show_bug.cgi?id=180009
1660
1661         Reviewed by Alex Christensen.
1662
1663         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1664
1665         * Plugins/WebBaseNetscapePluginView.mm:
1666         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1667         of strcasecmp.
1668
1669         * WebView/WebPreferences.mm:
1670         (contains): Ditto. Also made this a template so it's easier to call on an array.
1671         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1672
1673 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1674
1675         Limit user agent versioning to an upper bound
1676         https://bugs.webkit.org/show_bug.cgi?id=180365
1677         <rdar://problem/34550617>
1678
1679         Reviewed by Joseph Pecoraro.
1680
1681         * WebView/WebView.mm:
1682         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1683         creating the User Agent string.
1684         (webKitBundleVersionString): Deleted.
1685
1686 2017-12-05  Andy Estes  <aestes@apple.com>
1687
1688         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1689         https://bugs.webkit.org/show_bug.cgi?id=180457
1690         <rdar://problem/35143007>
1691
1692         Reviewed by Tim Horton.
1693
1694         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1695         check for this macro during post-processing.
1696
1697         * postprocess-headers.sh:
1698
1699 2017-12-04  David Quesada  <david_quesada@apple.com>
1700
1701         Add a class for parsing application manifests
1702         https://bugs.webkit.org/show_bug.cgi?id=177973
1703         rdar://problem/34747949
1704
1705         Reviewed by Geoffrey Garen.
1706
1707         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1708
1709 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1710
1711         Make LegacyCustomProtocolManager optional for network process
1712         https://bugs.webkit.org/show_bug.cgi?id=176230
1713
1714         Reviewed by Alex Christensen.
1715
1716         * Configurations/FeatureDefines.xcconfig:
1717
1718 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1719
1720         Fix some NSOperationQueue leaks
1721         https://bugs.webkit.org/show_bug.cgi?id=180221
1722
1723         Reviewed by Wenson Hsieh.
1724
1725         * WebView/WebView.mm:
1726         (-[WebView performDragOperation:]):
1727
1728 2017-11-30  Darin Adler  <darin@apple.com>
1729
1730         [Mac] remove unneeded RetainPtr use introduced in r225142
1731         https://bugs.webkit.org/show_bug.cgi?id=180202
1732
1733         Reviewed by Tim Horton.
1734
1735         * WebView/WebImmediateActionController.mm:
1736         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1737         RetainPtr.
1738
1739 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1740
1741         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1742         https://bugs.webkit.org/show_bug.cgi?id=175595
1743
1744         Reviewed by Darin Adler.
1745
1746         * WebView/WebPreferences.mm:
1747
1748 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1749
1750         One too many zeroes in macOS version number in FeatureDefines
1751         https://bugs.webkit.org/show_bug.cgi?id=180011
1752
1753         Reviewed by Dan Bernstein.
1754
1755         * Configurations/FeatureDefines.xcconfig:
1756
1757 2017-11-23  Darin Adler  <darin@apple.com>
1758
1759         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1760         https://bugs.webkit.org/show_bug.cgi?id=179981
1761
1762         Reviewed by Sam Weinig.
1763
1764         * WebView/WebImmediateActionController.mm:
1765         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1766         * WebView/WebView.mm:
1767         (coreOptions): Use |= instead of | to build up FindOptions.
1768
1769 2017-11-23  Sam Weinig  <sam@webkit.org>
1770
1771         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1772         https://bugs.webkit.org/show_bug.cgi?id=179954
1773
1774         Reviewed by Darin Adler.
1775
1776         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1777         with direct calls to the corresponding UserGestureIndicator functions.
1778
1779         * Plugins/WebPluginController.mm:
1780         (-[WebPluginController processingUserGesture]):
1781         * WebView/WebView.mm:
1782         (-[WebView _isProcessingUserGesture]):
1783
1784 2017-11-23  Darin Adler  <darin@apple.com>
1785
1786         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1787         https://bugs.webkit.org/show_bug.cgi?id=179907
1788
1789         Reviewed by Sam Weinig.
1790
1791         * History/BinaryPropertyList.cpp:
1792         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1793         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1794         * WebView/WebHTMLRepresentation.mm:
1795         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1796         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1797
1798 2017-11-22  Ali Juma  <ajuma@chromium.org>
1799
1800         Implement VisualViewport API attributes
1801         https://bugs.webkit.org/show_bug.cgi?id=179385
1802
1803         Reviewed by Frédéric Wang.
1804
1805         Add a VisualViewportAPI preference.
1806
1807         * WebView/WebPreferenceKeysPrivate.h:
1808         * WebView/WebPreferences.mm:
1809         (+[WebPreferences initialize]):
1810         (-[WebPreferences visualViewportAPIEnabled]):
1811         (-[WebPreferences setVisualViewportAPIEnabled:]):
1812         * WebView/WebPreferencesPrivate.h:
1813         * WebView/WebView.mm:
1814         (-[WebView _preferencesChanged:]):
1815
1816 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1817
1818         WebCoreObjCExtras.h is being included in too many places
1819         https://bugs.webkit.org/show_bug.cgi?id=179931
1820
1821         Reviewed by Darin Adler.
1822
1823         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1824         * Plugins/WebBaseNetscapePluginView.mm:
1825         * Plugins/WebBasePluginPackage.mm:
1826         * Plugins/WebNetscapePluginStream.mm:
1827         * Plugins/WebNetscapePluginView.mm:
1828         * WebView/WebTextIterator.mm:
1829         * WebView/WebViewData.mm:
1830
1831 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1832
1833         Unreviewed, rolling out r225093.
1834         https://bugs.webkit.org/show_bug.cgi?id=179938
1835
1836         Compilation failed on WinCairo 64-bit Release (Requested by
1837         fredw on #webkit).
1838
1839         Reverted changeset:
1840
1841         "Implement VisualViewport API attributes"
1842         https://bugs.webkit.org/show_bug.cgi?id=179385
1843         https://trac.webkit.org/changeset/225093
1844
1845 2017-11-21  Ali Juma  <ajuma@chromium.org>
1846
1847         Implement VisualViewport API attributes
1848         https://bugs.webkit.org/show_bug.cgi?id=179385
1849
1850         Reviewed by Frédéric Wang.
1851
1852         Add a VisualViewportAPI preference.
1853
1854         * WebView/WebPreferenceKeysPrivate.h:
1855         * WebView/WebPreferences.mm:
1856         (+[WebPreferences initialize]):
1857         (-[WebPreferences visualViewportAPIEnabled]):
1858         (-[WebPreferences setVisualViewportAPIEnabled:]):
1859         * WebView/WebPreferencesPrivate.h:
1860         * WebView/WebView.mm:
1861         (-[WebView _preferencesChanged:]):
1862
1863 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1864
1865         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1866         https://bugs.webkit.org/show_bug.cgi?id=179504
1867
1868         Reviewed by Darin Adler.
1869
1870         * Misc/WebKitNSStringExtras.mm:
1871         * Plugins/Hosted/NetscapePluginHostManager.mm:
1872         * Plugins/WebBasePluginPackage.mm:
1873
1874 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1875
1876         Remove unused TOUCH_ICON_LOADING feature flag
1877         https://bugs.webkit.org/show_bug.cgi?id=179873
1878
1879         Reviewed by Simon Fraser.
1880
1881         * Configurations/FeatureDefines.xcconfig:
1882
1883 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1884
1885         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1886         https://bugs.webkit.org/show_bug.cgi?id=179872
1887
1888         Reviewed by Darin Adler.
1889
1890         * Configurations/FeatureDefines.xcconfig:
1891
1892 2017-11-16  Daniel Bates  <dabates@apple.com>
1893
1894         Add feature define for alternative presentation button element
1895         https://bugs.webkit.org/show_bug.cgi?id=179692
1896         Part of <rdar://problem/34917108>
1897
1898         Reviewed by Andy Estes.
1899
1900         Only enabled on Cocoa platforms by default.
1901
1902         * Configurations/FeatureDefines.xcconfig:
1903
1904 2017-11-14  Nan Wang  <n_wang@apple.com>
1905
1906         AX: AOM: Implement AccessibleNode class and support label and role attributes
1907         https://bugs.webkit.org/show_bug.cgi?id=179494
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         * WebView/WebPreferenceKeysPrivate.h:
1912         * WebView/WebPreferences.mm:
1913         (+[WebPreferences initialize]):
1914         (-[WebPreferences accessibilityObjectModelEnabled]):
1915         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1916         * WebView/WebPreferencesPrivate.h:
1917         * WebView/WebView.mm:
1918         (-[WebView _preferencesChanged:]):
1919
1920 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1921
1922         Remove Cocoa CFURLConnection loading code
1923         https://bugs.webkit.org/show_bug.cgi?id=179688
1924
1925         Reviewed by Antti Koivisto.
1926
1927         * Misc/WebDownload.mm:
1928         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1929         * Misc/WebDownloadInternal.h:
1930         * Plugins/WebBaseNetscapePluginView.mm:
1931         * WebCoreSupport/WebFrameLoaderClient.mm:
1932         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1933         * WebView/WebView.mm:
1934         (-[WebView scheduleInRunLoop:forMode:]):
1935         (-[WebView unscheduleFromRunLoop:forMode:]):
1936
1937 2017-11-14  Daniel Bates  <dabates@apple.com>
1938
1939         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1940         for feature defines
1941
1942         Following r195498 and r201917 the Visual Studio property files for feature defines have
1943         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1944         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1945         files.
1946
1947         * Configurations/FeatureDefines.xcconfig:
1948
1949 2017-11-14  Jer Noble  <jer.noble@apple.com>
1950
1951         Enable Modern EME tests in DumpRenderTree
1952         https://bugs.webkit.org/show_bug.cgi?id=179544
1953
1954         Reviewed by Alex Christensen.
1955
1956         Add a WebPreferences property to enable the (modern) EME API.
1957
1958         * WebView/WebPreferenceKeysPrivate.h:
1959         * WebView/WebPreferences.mm:
1960         (+[WebPreferences initialize]):
1961         (-[WebPreferences encryptedMediaAPIEnabled]):
1962         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1963         * WebView/WebPreferencesPrivate.h:
1964         * WebView/WebView.mm:
1965         (-[WebView _preferencesChanged:]):
1966
1967 2017-11-14  Antti Koivisto  <antti@apple.com>
1968
1969         Enable display:contents by default
1970         https://bugs.webkit.org/show_bug.cgi?id=179655
1971
1972         Reviewed by Sam Weinig.
1973
1974         * WebView/WebPreferences.mm:
1975         (+[WebPreferences initialize]):
1976
1977 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1978
1979         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1980         https://bugs.webkit.org/show_bug.cgi?id=178751
1981
1982         Reviewed by Brady Eidson.
1983
1984         * WebCoreSupport/WebFrameNetworkingContext.mm:
1985         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1986
1987 2017-11-08  Keith Miller  <keith_miller@apple.com>
1988
1989         Async iteration should only fetch the next method once and add feature flag
1990         https://bugs.webkit.org/show_bug.cgi?id=179451
1991
1992         Reviewed by Geoffrey Garen.
1993
1994         Add feature flag for Async iteration.
1995
1996         * Configurations/FeatureDefines.xcconfig:
1997
1998 2017-11-13  Mark Lam  <mark.lam@apple.com>
1999
2000         Add more overflow check book-keeping for MarkedArgumentBuffer.
2001         https://bugs.webkit.org/show_bug.cgi?id=179634
2002         <rdar://problem/35492517>
2003
2004         Reviewed by Saam Barati.
2005
2006         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2007         (WebKit::NetscapePluginInstanceProxy::invoke):
2008         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2009         (WebKit::NetscapePluginInstanceProxy::construct):
2010
2011 2017-11-12  Darin Adler  <darin@apple.com>
2012
2013         More is<> and downcast<>, less static_cast<>
2014         https://bugs.webkit.org/show_bug.cgi?id=179600
2015
2016         Reviewed by Chris Dumez.
2017
2018         * DOM/DOM.mm:
2019         (kit): Use is/downcast.
2020         * WebCoreSupport/WebEditorClient.mm:
2021         (WebEditorClient::handleKeyboardEvent): Ditto.
2022         (WebEditorClient::handleInputMethodKeydown): Ditto.
2023         * WebView/WebHTMLView.mm:
2024         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2025
2026 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2027
2028         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2029         https://bugs.webkit.org/show_bug.cgi?id=179397
2030
2031         Reviewed by Wenson Hsieh.
2032
2033         * DOM/DOMHTMLInputElement.mm:
2034         (-[DOMHTMLInputElement insertTextSuggestion:]):
2035
2036 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2037
2038         HTMLMediaElement should not use element fullscreen on iOS
2039         https://bugs.webkit.org/show_bug.cgi?id=179418
2040         rdar://problem/35409277
2041
2042         Reviewed by Eric Carlson.
2043
2044         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2045
2046         * Configurations/FeatureDefines.xcconfig:
2047
2048 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2049
2050         Make ResourceLoader::willSendRequestInternal asynchronous
2051         https://bugs.webkit.org/show_bug.cgi?id=179251
2052
2053         Reviewed by Andy Estes.
2054
2055         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2056         (WebKit::HostedNetscapePluginStream::start):
2057         * Plugins/WebNetscapePluginStream.mm:
2058         (WebNetscapePluginStream::start):
2059
2060 2017-11-01  Darin Adler  <darin@apple.com>
2061
2062         Simplify event dispatch code and make it a bit more consistent
2063         https://bugs.webkit.org/show_bug.cgi?id=178991
2064
2065         Reviewed by Chris Dumez.
2066
2067         * DOM/DOMEvent.mm:
2068         (-[DOMEvent srcElement]): Call target instead of srcElement.
2069
2070 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2071
2072         [Touch Bar Web API] Add support for menuitem tag
2073         https://bugs.webkit.org/show_bug.cgi?id=179020
2074
2075         Reviewed by Ryosuke Niwa.
2076
2077         Adds in properties and methods that allow the menuitem runtime feature
2078         to be enabled or disabled.
2079
2080         * WebView/WebPreferenceKeysPrivate.h:
2081         * WebView/WebPreferences.mm:
2082         (-[WebPreferences menuItemElementEnabled]):
2083         (-[WebPreferences setMenuItemElementEnabled:]):
2084         * WebView/WebPreferencesPrivate.h:
2085         * WebView/WebView.mm:
2086         (-[WebView _preferencesChanged:]):
2087
2088 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2089
2090         Use CompletionHandlers for redirects
2091         https://bugs.webkit.org/show_bug.cgi?id=179163
2092
2093         Reviewed by Tim Horton.
2094
2095         * Plugins/Hosted/HostedNetscapePluginStream.h:
2096         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2097         (WebKit::HostedNetscapePluginStream::willSendRequest):
2098         * Plugins/WebNetscapePluginStream.h:
2099         * Plugins/WebNetscapePluginStream.mm:
2100         (WebNetscapePluginStream::willSendRequest):
2101
2102 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2103
2104         Add a FileSystem namespace to FileSystem.cpp
2105         https://bugs.webkit.org/show_bug.cgi?id=179063
2106
2107         Reviewed by Darin Adler.
2108
2109         * Misc/WebNSFileManagerExtras.mm:
2110         * Storage/WebDatabaseProvider.mm:
2111
2112 2017-11-02  Frederic Wang  <fwang@igalia.com>
2113
2114         Add references to bug 179167 in FIXME comments
2115         https://bugs.webkit.org/show_bug.cgi?id=179168
2116
2117         Reviewed by Daniel Bates.
2118
2119         * Configurations/FeatureDefines.xcconfig:
2120
2121 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2122
2123         Implement WKFullscreenWindowController for iOS.
2124         https://bugs.webkit.org/show_bug.cgi?id=178924
2125         rdar://problem/34697120
2126
2127         Reviewed by Simon Fraser.
2128
2129         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2130
2131         * Configurations/FeatureDefines.xcconfig:
2132         * WebView/WebView.mm:
2133         (-[WebView fullScreenPlaceholderView]):
2134
2135 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2136
2137         Clean up some drag and drop feature flags
2138         https://bugs.webkit.org/show_bug.cgi?id=179082
2139
2140         Reviewed by Simon Fraser.
2141
2142         * Configurations/FeatureDefines.xcconfig:
2143
2144 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2145
2146         Make it possible to test rubber-banding in overflow scroll
2147         https://bugs.webkit.org/show_bug.cgi?id=179078
2148
2149         Reviewed by Sam Weinig.
2150
2151         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2152         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2153
2154         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2155         functions, since most callers want clamped.
2156
2157         * DOM/DOMHTML.mm:
2158         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2159
2160 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2161
2162         Fix up some content filtering feature flags
2163         https://bugs.webkit.org/show_bug.cgi?id=179079
2164
2165         Reviewed by Simon Fraser.
2166
2167         * Configurations/FeatureDefines.xcconfig:
2168
2169 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2170
2171         [FrameView::layout cleanup] Move core layout logic to a separate class.
2172         https://bugs.webkit.org/show_bug.cgi?id=178771
2173         <rdar://problem/35166542>
2174
2175         Reviewed by Simon Fraser.
2176
2177         Move layout code out from FrameView to LayoutContext.
2178
2179         * WebView/WebClipView.mm:
2180         (-[WebClipView _immediateScrollToPoint:]):
2181         * WebView/WebFrame.mm:
2182         (-[WebFrame layoutCount]):
2183
2184 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2185
2186         Fix issues with WebView subframe painting
2187         https://bugs.webkit.org/show_bug.cgi?id=178842
2188         rdar://problem/34072253
2189
2190         Reviewed by Daniel Bates.
2191
2192         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2193         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2194         High Sierra, so match the new signature.
2195
2196         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2197
2198         * WebView/WebHTMLView.mm:
2199         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2200         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2201
2202 2017-10-25  Youenn Fablet  <youenn@apple.com>
2203
2204         Enable ServiceWorker to fetch resources
2205         https://bugs.webkit.org/show_bug.cgi?id=178673
2206
2207         Reviewed by Brady Eidson.
2208
2209         * WebCoreSupport/WebFrameLoaderClient.mm:
2210         (WebFrameLoaderClient::pageID const):
2211         (WebFrameLoaderClient::frameID const):
2212         (WebFrameLoaderClient::sessionID const):
2213
2214         Added implementation to the new getters.
2215         They are noop in the context of WK1.
2216
2217 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2218
2219         Web Inspector: Enable WebKit logging configuration and display
2220         https://bugs.webkit.org/show_bug.cgi?id=177027
2221         <rdar://problem/33964767>
2222
2223         Reviewed by Joseph Pecoraro.
2224
2225         * WebCoreSupport/WebChromeClient.mm:
2226         (stringForMessageSource): Deal with Media and WebRTC message sources.
2227
2228 2017-10-20  Antoine Quint  <graouts@apple.com>
2229
2230         [Web Animations] Provide basic timeline and animation interfaces
2231         https://bugs.webkit.org/show_bug.cgi?id=178526
2232
2233         Reviewed by Dean Jackson.
2234
2235         Remove the WEB_ANIMATIONS compile-time flag.
2236
2237         * Configurations/FeatureDefines.xcconfig:
2238         * WebView/WebPreferences.mm:
2239         (+[WebPreferences initialize]):
2240         * WebView/WebView.mm:
2241         (-[WebView _preferencesChanged:]):
2242
2243 2017-10-19  Sam Weinig  <sam@webkit.org>
2244
2245         [Settings] Move global settings into their own file
2246         https://bugs.webkit.org/show_bug.cgi?id=178512
2247
2248         Reviewed by Darin Adler.
2249
2250         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2251
2252         * WebCoreSupport/WebChromeClient.mm:
2253         (WebChromeClient::supportsVideoFullscreen):
2254         * WebView/WebDynamicScrollBarsView.mm:
2255         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2256         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2257         * WebView/WebPreferences.mm:
2258         (+[WebPreferences initialize]):
2259         * WebView/WebView.mm:
2260         (-[WebView _commonInitializationWithFrameName:groupName:]):
2261         (-[WebView _preferencesChanged:]):
2262         (+[WebView _doNotStartObservingNetworkReachability]):
2263
2264 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2265
2266         Replace some stack raw pointers with RefPtrs within WebCore/html
2267         https://bugs.webkit.org/show_bug.cgi?id=178201
2268         <rdar://problem/34841692>
2269
2270         Reviewed by Ryosuke Niwa.
2271
2272         * DOM/DOM.mm:
2273         (kit):
2274         Change the type of node as toNode() is changed to return RefPtr.
2275
2276 2017-10-18  Chris Dumez  <cdumez@apple.com>
2277
2278         [Service Worker] Add stubs for Client / WindowClient / Clients
2279         https://bugs.webkit.org/show_bug.cgi?id=178469
2280
2281         Reviewed by Youenn Fablet.
2282
2283         Rename PageVisiblityState to VisibilityState.
2284
2285         * WebView/WebView.mm:
2286         (kit):
2287
2288 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2289
2290         Unreviewed, rolling out r223291.
2291
2292         See WebCore ChangeLog for more detail.
2293
2294         Reverted changeset:
2295
2296         "Remove Editor::simplifyMarkup"
2297         https://bugs.webkit.org/show_bug.cgi?id=178271
2298         https://trac.webkit.org/changeset/223291
2299
2300 2017-10-17  Keith Miller  <keith_miller@apple.com>
2301
2302         Change WebCore sources to work with unified source builds
2303         https://bugs.webkit.org/show_bug.cgi?id=178229
2304
2305         Rubber stamped by Tim Horton.
2306
2307         * Configurations/FeatureDefines.xcconfig:
2308
2309 2017-10-16  Sam Weinig  <sam@webkit.org>
2310
2311         [Settings] Remove all custom code from Settings.h/cpp
2312         https://bugs.webkit.org/show_bug.cgi?id=178330
2313
2314         Reviewed by Simon Fraser.
2315
2316         * WebView/WebPreferences.mm:
2317         (+[WebPreferences initialize]):
2318
2319             Update for naming changes of FrameFlattening now that it is an enum class.
2320
2321 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2322
2323         Remove Editor::simplifyMarkup
2324         https://bugs.webkit.org/show_bug.cgi?id=178271
2325
2326         Reviewed by Wenson Hsieh.
2327
2328         * WebView/WebView.mm:
2329         (-[WebView _simplifyMarkup:endNode:]):
2330
2331 2017-10-12  Chris Dumez  <cdumez@apple.com>
2332
2333         [Mac] Add support for MouseEvent.buttons
2334         https://bugs.webkit.org/show_bug.cgi?id=178214
2335
2336         Reviewed by Ryosuke Niwa.
2337
2338         * WebView/WebPDFView.mm:
2339         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2340
2341 2017-10-11  Sam Weinig  <sam@webkit.org>
2342
2343         Remove out-parameter variants of copyToVector
2344         https://bugs.webkit.org/show_bug.cgi?id=178155
2345
2346         Reviewed by Tim Horton.
2347
2348         * Plugins/WebNetscapePluginView.mm:
2349         (-[WebNetscapePluginView destroyPlugin]):
2350         * WebView/WebHTMLRepresentation.mm:
2351         (newArrayWithStrings):
2352
2353             Replace out-parameter based copyToVector, with one that returns a Vector.
2354
2355 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2356
2357         Sanitize URL in pasteboard for other applications and cross origin content
2358         https://bugs.webkit.org/show_bug.cgi?id=178060
2359         <rdar://problem/34874518>
2360
2361         Reviewed by Wenson Hsieh.
2362
2363         * WebCoreSupport/WebPlatformStrategies.h:
2364         * WebCoreSupport/WebPlatformStrategies.mm:
2365         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2366
2367 2017-10-11  Chris Dumez  <cdumez@apple.com>
2368
2369         Modernize Geolocation code
2370         https://bugs.webkit.org/show_bug.cgi?id=178148
2371
2372         Reviewed by Ryosuke Niwa.
2373
2374         * WebCoreSupport/WebGeolocationClient.h:
2375         * WebCoreSupport/WebGeolocationClient.mm:
2376         (WebGeolocationClient::lastPosition):
2377         * WebView/WebGeolocationPosition.mm:
2378         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2379         (core):
2380         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2381         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2382         * WebView/WebGeolocationPositionInternal.h:
2383
2384 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2385
2386         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2387         https://bugs.webkit.org/show_bug.cgi?id=178154
2388
2389         Reviewed by Wenson Hsieh.
2390
2391         Enable custom pasteboard data by default.
2392
2393         * WebView/WebPreferenceKeysPrivate.h:
2394         * WebView/WebPreferences.mm:
2395         (+[WebPreferences initialize]):
2396         (-[WebPreferences customPasteboardDataEnabled]): Added.
2397         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2398         * WebView/WebPreferencesPrivate.h:
2399         * WebView/WebView.mm:
2400         (-[WebView _preferencesChanged:]):
2401
2402 2017-10-10  Sam Weinig  <sam@webkit.org>
2403
2404         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2405         https://bugs.webkit.org/show_bug.cgi?id=178102
2406
2407         Reviewed by Tim Horton.
2408
2409         * History/WebHistory.mm:
2410         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2411         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2412         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2413         * WebCoreSupport/WebUserMediaClient.mm:
2414         (WebUserMediaClient::pageDestroyed):
2415
2416 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2417
2418         Make the names of the options consistent
2419         https://bugs.webkit.org/show_bug.cgi?id=177933
2420
2421         Reviewed by Saam Barati.
2422
2423         * WebView/WebFrame.h:
2424         * WebView/WebHTMLView.mm:
2425         (-[WebHTMLView setMarkedText:selectedRange:]):
2426         * WebView/WebView.h:
2427
2428 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2429
2430         [iOS] Tweak support for classifying form controls (followup to r222487)
2431         https://bugs.webkit.org/show_bug.cgi?id=177917
2432         <rdar://problem/34820122>
2433
2434         Reviewed by Dean Jackson.
2435
2436         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2437
2438         * DOM/DOMHTMLInputElement.mm:
2439         (-[DOMHTMLInputElement _autofillContext]):
2440         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2441         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2442
2443 2017-10-05  Keith Miller  <keith_miller@apple.com>
2444
2445         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2446
2447         * Configurations/WebKitLegacy.xcconfig:
2448
2449 2017-10-05  Jer Noble  <jer.noble@apple.com>
2450
2451         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2452         https://bugs.webkit.org/show_bug.cgi?id=177261
2453
2454         Reviewed by Eric Carlson.
2455
2456         * Configurations/FeatureDefines.xcconfig:
2457
2458 2017-10-05  Chris Dumez  <cdumez@apple.com>
2459
2460         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2461         https://bugs.webkit.org/show_bug.cgi?id=177957
2462
2463         Reviewed by Alex Christensen.
2464
2465         * WebCoreSupport/WebPlatformStrategies.h:
2466         * WebCoreSupport/WebPlatformStrategies.mm:
2467         (WebPlatformStrategies::cookiesEnabled):
2468
2469 2017-10-05  Youenn Fablet  <youenn@apple.com>
2470
2471         Make LibWebRTCProvider port agnostic
2472         https://bugs.webkit.org/show_bug.cgi?id=177747
2473
2474         Reviewed by Alex Christensen & Alex Garcia.
2475
2476         * WebView/WebView.mm:
2477         (-[WebView _commonInitializationWithFrameName:groupName:]):
2478         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2479
2480 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2481
2482         Stop linking with WebKitSystemInterface
2483         https://bugs.webkit.org/show_bug.cgi?id=177915
2484
2485         Reviewed by Antti Koivisto.
2486
2487         * Configurations/DebugRelease.xcconfig:
2488         * Configurations/WebKitLegacy.xcconfig:
2489
2490 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2491
2492         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2493         https://bugs.webkit.org/show_bug.cgi?id=177912
2494
2495         Reviewed by Saam Barati.
2496
2497         * Carbon/CarbonUtils.m:
2498         * Carbon/CarbonWindowAdapter.mm:
2499         * Carbon/HIWebView.mm:
2500         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2501         * Misc/WebNSFileManagerExtras.mm:
2502         * Misc/WebNSPasteboardExtras.mm:
2503         * Misc/WebNSURLExtras.mm:
2504         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2505         * Plugins/Hosted/NetscapePluginHostManager.mm:
2506         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2507         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2508         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2509         * Plugins/Hosted/WebTextInputWindowController.m:
2510         * Plugins/WebBaseNetscapePluginView.mm:
2511         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2512         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2513         * Plugins/WebNetscapePluginStream.mm:
2514         * Plugins/WebNetscapePluginView.mm:
2515         * Plugins/WebPluginDatabase.mm:
2516         * WebCoreSupport/PopupMenuMac.mm:
2517         * WebCoreSupport/WebChromeClient.mm:
2518         * WebCoreSupport/WebFrameLoaderClient.mm:
2519         * WebCoreSupport/WebInspectorClient.mm:
2520         * WebCoreSupport/WebPlatformStrategies.mm:
2521         * WebCoreSupport/WebSystemInterface.mm:
2522         * WebView/WebDynamicScrollBarsView.mm:
2523         * WebView/WebFrame.mm:
2524         * WebView/WebFrameView.mm:
2525         * WebView/WebFullScreenController.mm:
2526         * WebView/WebHTMLView.mm:
2527         * WebView/WebPreferences.mm:
2528         * WebView/WebView.mm:
2529
2530 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2531
2532         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2533         rdar://problem/34705779
2534
2535         Addressing review comments that I somehow landed without.
2536
2537         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2538
2539 2017-09-29  Chris Dumez  <cdumez@apple.com>
2540
2541         Split some logic out of VisitedLinkStore and make it reusable
2542         https://bugs.webkit.org/show_bug.cgi?id=177575
2543
2544         Reviewed by Alex Christensen.
2545
2546         * WebCoreSupport/WebVisitedLinkStore.h:
2547         * WebCoreSupport/WebVisitedLinkStore.mm:
2548         (WebVisitedLinkStore::addVisitedLink):
2549         (WebVisitedLinkStore::removeVisitedLink):
2550         (WebVisitedLinkStore::isLinkVisited):
2551         (WebVisitedLinkStore::addVisitedLinkHash):
2552
2553 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2554
2555         Build fix for High Sierra 32 bit Mac
2556         https://bugs.webkit.org/show_bug.cgi?id=177551
2557         <rdar://problem/34690283>
2558
2559         Reviewed by Alexey Proskuryakov.
2560
2561         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2562         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2563         also made.
2564
2565         * Carbon/CarbonWindowAdapter.mm:
2566         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2567         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2568         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2569         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2570         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2571         (-[CarbonWindowAdapter dealloc]):
2572         (-[CarbonWindowAdapter windowRef]):
2573         (-[CarbonWindowAdapter _hasWindowRef]):
2574         (-[CarbonWindowAdapter _managesWindowRef]):
2575         (-[CarbonWindowAdapter _removeWindowRef]):
2576         (-[CarbonWindowAdapter _carbonWindowClass]):
2577         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2578         (-[CarbonWindowAdapter sendSuperEvent:]):
2579         (-[CarbonWindowAdapter relinquishFocus]):
2580         (-[CarbonWindowAdapter _cancelKey:]):
2581         (-[CarbonWindowAdapter _commonAwake]):
2582         (-[CarbonWindowAdapter _destroyRealWindow:]):
2583         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2584         (-[CarbonWindowAdapter _termWindowIfOwner]):
2585         (-[CarbonWindowAdapter _windowMovedToRect:]):
2586         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2587         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2588         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2589         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2590         (-[CarbonWindowAdapter canBecomeMainWindow]):
2591         (-[CarbonWindowAdapter encodeWithCoder:]):
2592         (-[CarbonWindowAdapter initWithCoder:]):
2593         (-[CarbonWindowAdapter setContentView:]):
2594         (-[CarbonWindowAdapter worksWhenModal]):
2595         (-[CarbonWindowAdapter _setModalWindowLevel]):
2596         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2597         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2598         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2599         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2600         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2601         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2602         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2603         (NSCarbonWindowHandleEvent):
2604         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2605         (-[CarbonWindowAdapter _growBoxRect]):
2606         * Carbon/HIWebView.mm:
2607         (HIWebViewGetWebView):
2608         (HIWebViewConstructor):
2609         (HIWebViewDestructor):
2610         (HIWebViewRegisterClass):
2611         (GetBehaviors):
2612         (Draw):
2613         (HitTest):
2614         (GetRegion):
2615         (GetWindowRef):
2616         (CreateNSEventAdoptingCGEvent):
2617         (CopyEventCGEvent):
2618         (CreateNSEventWithCarbonClickEvent):
2619         (Click):
2620         (CreateNSEventWithCarbonEvent):
2621         (MouseUp):
2622         (CreateNSEventWithCarbonMouseMoveEvent):
2623         (MouseMoved):
2624         (MouseDragged):
2625         (MouseWheelMoved):
2626         (ContextMenuClick):
2627         (GetKind):
2628         (BoundsChanged):
2629         (OwningWindowChanged):
2630         (WindowHandler):
2631         (SyncFrame):
2632         (SetFocusPart):
2633         (AdvanceFocus):
2634         (RelinquishFocus):
2635         (ActiveStateChanged):
2636         (ProcessCommand):
2637         (UpdateCommandStatus):
2638         (_NSSelectorForHICommand):
2639         (HIWebViewEventHandler):
2640         (StartUpdateObserver):
2641         (StopUpdateObserver):
2642         (UpdateObserver):
2643
2644 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2645
2646         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2647         https://bugs.webkit.org/show_bug.cgi?id=172526
2648         <rdar://problem/32396081>
2649
2650         Reviewed by Ryosuke Niwa.
2651
2652         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2653
2654         * WebCoreSupport/WebPlatformStrategies.h:
2655         * WebCoreSupport/WebPlatformStrategies.mm:
2656         (WebPlatformStrategies::webExposedTypes):
2657         (WebPlatformStrategies::writeCustomData):
2658
2659 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2660
2661         Unreviewed, rolling out r222567.
2662
2663         This broke and internal build.
2664
2665         Reverted changeset:
2666
2667         "Build fix for High Sierra 32 bit Mac"
2668         https://bugs.webkit.org/show_bug.cgi?id=177551
2669         http://trac.webkit.org/changeset/222567
2670
2671 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2672
2673         Build fix for High Sierra 32 bit Mac
2674         https://bugs.webkit.org/show_bug.cgi?id=177551
2675         <rdar://problem/34690283>
2676
2677         Reviewed by Alexey Proskuryakov.
2678
2679         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2680         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2681         also made.
2682
2683         * Carbon/CarbonWindowAdapter.mm:
2684         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2685         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2686         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2687         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2688         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2689         (-[CarbonWindowAdapter dealloc]):
2690         (-[CarbonWindowAdapter windowRef]):
2691         (-[CarbonWindowAdapter _hasWindowRef]):
2692         (-[CarbonWindowAdapter _managesWindowRef]):
2693         (-[CarbonWindowAdapter _removeWindowRef]):
2694         (-[CarbonWindowAdapter _carbonWindowClass]):
2695         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2696         (-[CarbonWindowAdapter sendSuperEvent:]):
2697         (-[CarbonWindowAdapter relinquishFocus]):
2698         (-[CarbonWindowAdapter _cancelKey:]):
2699         (-[CarbonWindowAdapter _commonAwake]):
2700         (-[CarbonWindowAdapter _destroyRealWindow:]):
2701         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2702         (-[CarbonWindowAdapter _termWindowIfOwner]):
2703         (-[CarbonWindowAdapter _windowMovedToRect:]):
2704         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2705         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2706         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2707         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2708         (-[CarbonWindowAdapter canBecomeMainWindow]):
2709         (-[CarbonWindowAdapter encodeWithCoder:]):
2710         (-[CarbonWindowAdapter initWithCoder:]):
2711         (-[CarbonWindowAdapter setContentView:]):
2712         (-[CarbonWindowAdapter worksWhenModal]):
2713         (-[CarbonWindowAdapter _setModalWindowLevel]):
2714         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2715         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2716         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2717         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2718         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2719         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2720         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2721         (NSCarbonWindowHandleEvent):
2722         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2723         (-[CarbonWindowAdapter _growBoxRect]):
2724         * Carbon/HIWebView.mm:
2725         (HIWebViewGetWebView):
2726         (HIWebViewConstructor):
2727         (HIWebViewDestructor):
2728         (HIWebViewRegisterClass):
2729         (GetBehaviors):
2730         (Draw):
2731         (HitTest):
2732         (GetRegion):
2733         (GetWindowRef):
2734         (CreateNSEventAdoptingCGEvent):
2735         (CopyEventCGEvent):
2736         (CreateNSEventWithCarbonClickEvent):
2737         (Click):
2738         (CreateNSEventWithCarbonEvent):
2739         (MouseUp):
2740         (CreateNSEventWithCarbonMouseMoveEvent):
2741         (MouseMoved):
2742         (MouseDragged):
2743         (MouseWheelMoved):
2744         (ContextMenuClick):
2745         (GetKind):
2746         (BoundsChanged):
2747         (OwningWindowChanged):
2748         (WindowHandler):
2749         (SyncFrame):
2750         (SetFocusPart):
2751         (AdvanceFocus):
2752         (RelinquishFocus):
2753         (ActiveStateChanged):
2754         (ProcessCommand):
2755         (UpdateCommandStatus):
2756         (_NSSelectorForHICommand):
2757         (HIWebViewEventHandler):
2758         (StartUpdateObserver):
2759         (StopUpdateObserver):
2760         (UpdateObserver):
2761
2762 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2763
2764         Make PolicyAction an encodable enum class
2765         https://bugs.webkit.org/show_bug.cgi?id=177480
2766
2767         Reviewed by Antti Koivisto.
2768
2769         * Plugins/WebPluginContainerCheck.mm:
2770         (-[WebPluginContainerCheck _continueWithPolicy:]):
2771         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2772         * WebCoreSupport/WebFrameLoaderClient.mm:
2773         (-[WebFramePolicyListener invalidate]):
2774         (-[WebFramePolicyListener ignore]):
2775         (-[WebFramePolicyListener download]):
2776         (-[WebFramePolicyListener use]):
2777         (-[WebFramePolicyListener continue]):
2778         * WebView/WebPolicyDelegate.mm:
2779         (-[WebPolicyDecisionListener use]):
2780         (-[WebPolicyDecisionListener ignore]):
2781         (-[WebPolicyDecisionListener download]):
2782
2783 2017-09-25  Frederik Riedel  <riedel@apple.com>
2784
2785         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2786         https://bugs.webkit.org/show_bug.cgi?id=174394
2787         <rdar://problem/33183504>
2788
2789         Reviewed by Ryosuke Niwa.
2790
2791         * DOM/DOMHTMLInputElement.h:
2792         * DOM/DOMHTMLInputElement.mm:
2793         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2794         Determines if this HTMLInputElement is part of a login screen.
2795         (-[DOMHTMLInputElement representingPageUrl]):
2796         Returns the webpage's URL that is currently displayed in the Web View.
2797         (-[DOMHTMLInputElement insertTextSuggestion:]):
2798         Inserts login credentials into the Web View.
2799
2800 2017-09-25  Sam Weinig  <sam@webkit.org>
2801
2802         Remove unused EditorClient functions
2803         https://bugs.webkit.org/show_bug.cgi?id=177463
2804
2805         Reviewed by Alex Christensen.
2806
2807         Remove unused EditorClient functions.
2808
2809         * WebCoreSupport/WebEditorClient.h:
2810         * WebCoreSupport/WebEditorClient.mm:
2811         (WebEditorClient::canonicalizeURL): Deleted.
2812         (WebEditorClient::canonicalizeURLString): Deleted.
2813         (WebEditorClient::writeDataToPasteboard): Deleted.
2814         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2815         (WebEditorClient::readDataFromPasteboard): Deleted.
2816         (WebEditorClient::pasteboardChangeCount): Deleted.
2817
2818 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2819
2820         Stop using PolicyCallback
2821         https://bugs.webkit.org/show_bug.cgi?id=176088
2822
2823         Reviewed by Andy Estes.
2824
2825         * WebCoreSupport/WebFrameLoaderClient.mm:
2826         (-[WebFramePolicyListener invalidate]):
2827         (-[WebFramePolicyListener receivedPolicyDecision:]):
2828
2829 2017-09-25  Sam Weinig  <sam@webkit.org>
2830
2831         Remove unnecessary userVisibleString EditorClient function
2832         https://bugs.webkit.org/show_bug.cgi?id=177456
2833
2834         Reviewed by Dan Bernstein.
2835
2836         * WebCoreSupport/WebEditorClient.h:
2837         * WebCoreSupport/WebEditorClient.mm:
2838         (WebEditorClient::userVisibleString): Deleted.
2839
2840             Remove userVisibleString client function.
2841
2842 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2843
2844         Separate form submission from PolicyChecker infrastructure
2845         https://bugs.webkit.org/show_bug.cgi?id=177396
2846
2847         Reviewed by Geoffrey Garen.
2848
2849         * WebCoreSupport/WebFrameLoaderClient.h:
2850         * WebCoreSupport/WebFrameLoaderClient.mm:
2851         (WebFrameLoaderClient::dispatchWillSubmitForm):
2852
2853 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2854
2855         WeakPtrFactory should populate m_ref lazily.
2856         https://bugs.webkit.org/show_bug.cgi?id=177375
2857
2858         Reviewed by Geoffrey Garen.
2859
2860         * WebCoreSupport/WebEditorClient.mm:
2861         (WebEditorClient::WebEditorClient):
2862         (WebEditorClient::requestCandidatesForSelection):
2863
2864 2017-09-22  Chris Dumez  <cdumez@apple.com>
2865
2866         Use high resolution timestamp for event time
2867         https://bugs.webkit.org/show_bug.cgi?id=154246
2868         <rdar://problem/34333304>
2869
2870         Reviewed by Ryosuke Niwa.
2871
2872         Use WallTime / MonotonicTime instead of double type for clarity.
2873
2874         * DOM/DOMEvent.mm:
2875         (-[DOMEvent timeStamp]):
2876         * WebView/WebFrame.mm:
2877         (-[WebFrame _dragSourceEndedAt:operation:]):
2878         * WebView/WebPDFView.mm:
2879         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2880
2881 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2882
2883         Enable dataTransfer.items on macOS and iOS
2884         https://bugs.webkit.org/show_bug.cgi?id=177335
2885
2886         Reviewed by Sam Weinig.
2887
2888         * WebView/WebPreferences.mm:
2889         (+[WebPreferences initialize]):
2890
2891 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2892
2893         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2894         https://bugs.webkit.org/show_bug.cgi?id=177101
2895         <rdar://problem/34500648>
2896
2897         Reviewed by Brian Burg.
2898
2899         * WebInspector/WebNodeHighlight.mm:
2900         Ensure we close the window that we have just removed.
2901
2902 2017-09-20  Antti Koivisto  <antti@apple.com>
2903
2904         Remove DOM and styling support for CSS Regions
2905         https://bugs.webkit.org/show_bug.cgi?id=177221
2906
2907         Reviewed by Andreas Kling.
2908
2909         * Configurations/FeatureDefines.xcconfig:
2910         * DOM/DOMCSS.mm:
2911         (kitClass):
2912         * DOM/DOMElement.mm:
2913         (-[DOMElement webkitRegionOverset]): Deleted.
2914
2915 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2916
2917         Layering violation in Editor::createFragment
2918         https://bugs.webkit.org/show_bug.cgi?id=176123
2919
2920         Reviewed by Darin Adler.
2921
2922         * Misc/WebNSURLExtras.h:
2923         * Misc/WebNSURLExtras.mm:
2924         * WebView/WebFrame.mm:
2925         * WebView/WebHTMLView.mm:
2926         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2927
2928         * WebCoreSupport/WebEditorClient.mm:
2929         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2930         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2931         way to avoid exporting the symbol just on newer OSes.
2932
2933 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2934
2935         On iOS, getData can't get text set by setData during copy event
2936         https://bugs.webkit.org/show_bug.cgi?id=176980
2937         <rdar://problem/34453915>
2938
2939         Reviewed by Darin Adler.
2940
2941         * WebCoreSupport/WebPlatformStrategies.h:
2942         * WebCoreSupport/WebPlatformStrategies.mm:
2943         (WebPlatformStrategies::copy): Deleted.
2944
2945 2017-09-18  Andy Estes  <aestes@apple.com>
2946
2947         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2948         https://bugs.webkit.org/show_bug.cgi?id=177029
2949
2950         Reviewed by Alex Christensen.
2951
2952         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2953         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2954         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2955         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2956         * WebCoreSupport/PopupMenuMac.mm:
2957         (PopupMenuMac::show):
2958         * WebCoreSupport/WebSystemInterface.mm:
2959         (InitWebCoreSystemInterface):
2960         * WebView/WebHTMLView.mm:
2961         (-[WebHTMLView setDataSource:]):
2962         (-[WebHTMLView attachRootLayer:]):
2963         * WebView/WebView.mm:
2964         (-[WebView _needsAdobeFrameReloadingQuirk]):
2965         (-[WebView _needsLinkElementTextCSSQuirk]):
2966         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2967         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2968         (-[WebView _preferencesChanged:]):
2969
2970 2017-09-15  Andy Estes  <aestes@apple.com>
2971
2972         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2973         https://bugs.webkit.org/show_bug.cgi?id=176953
2974
2975         Reviewed by Eric Carlson.
2976
2977         * WebCoreSupport/WebSystemInterface.mm:
2978         (InitWebCoreSystemInterface):
2979
2980 2017-09-14  Andy Estes  <aestes@apple.com>
2981
2982         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2983         https://bugs.webkit.org/show_bug.cgi?id=176931
2984
2985         Reviewed by Joseph Pecoraro.
2986
2987         * WebCoreSupport/WebSystemInterface.mm:
2988         (InitWebCoreSystemInterface):
2989
2990 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2991
2992         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2993         https://bugs.webkit.org/show_bug.cgi?id=176867
2994
2995         Reviewed by Sam Weinig.
2996
2997         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2998         (WebKit::NetscapePluginInstanceProxy::enumerate):
2999
3000 2017-09-13  Andy Estes  <aestes@apple.com>
3001
3002         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3003         https://bugs.webkit.org/show_bug.cgi?id=176729
3004
3005         Reviewed by Alex Christensen.
3006
3007         * WebCoreSupport/WebSystemInterface.mm:
3008         (InitWebCoreSystemInterface):
3009         * WebView/WebView.mm:
3010         (+[WebView _setCacheModel:]):
3011
3012 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3013
3014         Refactor WebContentReader out of EditorMac and EditorIOS
3015         https://bugs.webkit.org/show_bug.cgi?id=176770
3016
3017         Reviewed by Sam Weinig.
3018
3019         * WebCoreSupport/WebEditorClient.mm:
3020
3021 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3022
3023         Dragging & dropping a file creates an attachment element even when it's disabled
3024         https://bugs.webkit.org/show_bug.cgi?id=176769
3025
3026         Reviewed by Tim Horton.
3027
3028         * WebView/WebView.mm:
3029         (-[WebView _preferencesChanged:]):
3030
3031 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3032
3033         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3034         https://bugs.webkit.org/show_bug.cgi?id=176721
3035         <rdar://problem/34373660>
3036
3037         Reviewed by Tim Horton.
3038
3039         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3040         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3041
3042         * WebView/WebView.mm:
3043         (-[WebView _startDrag:]):
3044         (-[WebView _draggedElementBounds]):
3045         (-[WebView _endedDataInteraction:global:]):
3046         * WebView/WebViewData.h:
3047
3048 2017-09-11  Andy Estes  <aestes@apple.com>
3049
3050         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3051         https://bugs.webkit.org/show_bug.cgi?id=176472
3052
3053         Reviewed by Eric Carlson.
3054
3055         * WebCoreSupport/WebSystemInterface.mm:
3056         (InitWebCoreSystemInterface):
3057
3058 2017-09-09  Mark Lam  <mark.lam@apple.com>
3059
3060         Avoid duplicate computations of ExecState::vm().
3061         https://bugs.webkit.org/show_bug.cgi?id=176647
3062
3063         Reviewed by Saam Barati.
3064
3065         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3066         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3067         (WebKit::NetscapePluginInstanceProxy::construct):
3068         (WebKit::NetscapePluginInstanceProxy::setProperty):
3069         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3070         (WebKit::NetscapePluginInstanceProxy::enumerate):
3071         * Plugins/Hosted/ProxyInstance.mm:
3072         (WebKit::ProxyRuntimeMethod::create):
3073
3074 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3075
3076         Unreviewed, rolling out r221773.
3077         https://bugs.webkit.org/show_bug.cgi?id=176614
3078
3079         This caused build failures. (Requested by mlewis13 on
3080         #webkit).
3081
3082         Reverted changeset:
3083
3084         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3085         https://bugs.webkit.org/show_bug.cgi?id=176472
3086         http://trac.webkit.org/changeset/221773
3087
3088 2017-09-07  Andy Estes  <aestes@apple.com>
3089
3090         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3091         https://bugs.webkit.org/show_bug.cgi?id=176472
3092
3093         Reviewed by Eric Carlson.
3094
3095         * WebCoreSupport/WebSystemInterface.mm:
3096         (InitWebCoreSystemInterface):
3097
3098 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3099
3100         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3101         https://bugs.webkit.org/show_bug.cgi?id=176561
3102
3103         Reviewed by Brent Fulgham.
3104
3105         * Misc/WebNSUserDefaultsExtras.mm:
3106
3107 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3108
3109         Modernize Geolocation code
3110         https://bugs.webkit.org/show_bug.cgi?id=176496
3111
3112         Reviewed by Andy Estes.
3113
3114         * WebCoreSupport/WebGeolocationClient.h:
3115         * WebCoreSupport/WebGeolocationClient.mm:
3116         (WebGeolocationClient::requestPermission):
3117         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3118         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3119         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3120         * WebView/WebView.mm:
3121         (-[WebView _commonInitializationWithFrameName:groupName:]):
3122         (-[WebView _geolocationDidFailWithMessage:]):
3123
3124 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3125
3126         Remove some unused bits of code and resources
3127         https://bugs.webkit.org/show_bug.cgi?id=176275
3128
3129         Reviewed by Dan Bernstein.
3130
3131         * Misc/WebNSFileManagerExtras.mm:
3132         Include FileSystem instead of FileSystemIOS.
3133
3134 2017-09-03  Darin Adler  <darin@apple.com>
3135
3136         [Cocoa] Tidy a few things in legacy WebHTMLView
3137         https://bugs.webkit.org/show_bug.cgi?id=176280
3138
3139         Reviewed by Dan Bernstein.
3140
3141         * WebCoreSupport/WebChromeClient.mm:
3142         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3143         methods it calls on WebHTMLView were doing nothing on iOS.
3144
3145         * WebView/WebFrame.mm:
3146         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3147         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3148
3149         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3150         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3151         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3152         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3153         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3154         Use RetainPtr instead of writing retain/release wherever possible.
3155         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3156         initialization for it. Removed various unused methods and declarations of methods.
3157         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3158         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3159         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3160         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3161         and remove CFRetain no longer needed since we don't support garbage collection any more.
3162         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3163         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3164         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3165         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3166         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3167         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3168         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3169         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3170         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3171         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3172         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3173         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3174         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3175         debug flag; we haven't used it for years and it's not clearly helpful.
3176         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3177         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3178         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3179         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3180         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3181         two additional methods in the WebPrivate category and still be called by the two
3182         methods in the WebInternal category that were already using it.
3183         (-[WebHTMLView didAddSubview:]): Deleted.
3184         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3185         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3186         place this was called, the close method.
3187         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3188         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3189         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3190         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3191         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3192         Added helper method to make the one below simpler.
3193         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3194         Compared pasteboard type strings using isEqualToString: rather than using == since
3195         we want to actually compare the string contents. Also updated to use modern for loop,
3196         renamed a local variable from "s" to "localSubresources", and factored out the handling
3197         of three image types to use the helper method above.
3198         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3199         _web_makePluginSubviewsPerformSelector:withObject: method.
3200         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3201         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3202         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3203         not call the -[NSView subviews] method to make this identical on both platforms and used
3204         a modern for loop.
3205         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3206         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3207         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3208         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3209         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3210         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3211         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3212         of it is Mac-only.
3213         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3214         method did was call itself on the main thread, and do nothing if called on main thread.
3215         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3216         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3217         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3218         half of this method.
3219         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3220         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3221         Simplified using a modern for loop and RetainPtr.
3222         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3223         (-[WebHTMLView keyDown:]): Ditto.
3224         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3225         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3226         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3227         (-[WebHTMLView complete:]): Ditto.
3228         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3229         now macOS-only.
3230         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3231         iOS since that is now macOS-only.
3232         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3233         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3234         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3235         and reorganized to use early return.
3236         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3237         on iOS, but kept there so we don't have to do #if at every call site.
3238         (-[WebHTMLView _pluginController]): Moved into internal category.
3239         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3240         there only for GC, using C++ initialization, removing obsolete comment.
3241         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3242         peculiar iOS-only comment.
3243         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3244
3245         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3246         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3247         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3248         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3249         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3250
3251         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3252         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3253         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3254         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3255         them at this time.
3256
3257 2017-09-03  Sam Weinig  <sam@webkit.org>
3258
3259         Remove CanvasProxy
3260         https://bugs.webkit.org/show_bug.cgi?id=176288
3261
3262         Reviewed by Yusuke Suzuki.
3263
3264         CanvasProxy does not appear to be in any current HTML spec
3265         and was disabled and unimplemented in our tree. Time to
3266         get rid of it.
3267
3268         * Configurations/FeatureDefines.xcconfig:
3269
3270 2017-09-02  Andy Estes  <aestes@apple.com>
3271
3272         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3273         https://bugs.webkit.org/show_bug.cgi?id=176270
3274
3275         Reviewed by Tim Horton.
3276
3277         * Plugins/Hosted/NetscapePluginHostManager.mm:
3278         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3279         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3280         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3281         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3282         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3283         (WebKit::SoftwareCARenderer::context const):
3284         (WebKit::SoftwareCARenderer::renderContext const):
3285         (WebKit::SoftwareCARenderer::render):
3286         (-[WebHostedNetscapePluginView createPlugin]):
3287         (-[WebHostedNetscapePluginView createPluginLayer]):
3288         (-[WebHostedNetscapePluginView destroyPlugin]):
3289         (-[WebHostedNetscapePluginView drawRect:]):
3290         * WebCoreSupport/WebSystemInterface.mm:
3291         (InitWebCoreSystemInterface):
3292
3293 2017-09-01  Andy Estes  <aestes@apple.com>
3294
3295         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3296         https://bugs.webkit.org/show_bug.cgi?id=176200
3297
3298         Reviewed by Tim Horton.
3299
3300         * Carbon/HIWebView.mm:
3301         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3302         (overrideCGContext):
3303         (restoreCGContext):
3304         (Draw):
3305         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3306         (+[WebHostedNetscapePluginView initialize]):
3307         * Plugins/WebBaseNetscapePluginView.h:
3308         * Plugins/WebBaseNetscapePluginView.mm:
3309         (WebKit::sendUserChangeNotifications):
3310         * Plugins/WebNetscapePluginView.mm:
3311         (+[WebNetscapePluginView initialize]):
3312         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3313         * WebCoreSupport/WebSystemInterface.mm:
3314         (InitWebCoreSystemInterface):
3315         * WebView/WebFrame.mm:
3316         (-[WebFrame _paintBehaviorForDestinationContext:]):
3317         * WebView/WebFullScreenController.mm:
3318         (setClipRectForWindow):
3319         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3320         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3321         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3322         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3323
3324 2017-08-31  Andy Estes  <aestes@apple.com>
3325
3326         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3327         https://bugs.webkit.org/show_bug.cgi?id=176175
3328
3329         Reviewed by Brady Eidson.
3330
3331         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3332         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3333         * Plugins/Hosted/WebTextInputWindowController.m:
3334         (-[WebTextInputPanel init]):
3335         * WebCoreSupport/WebSystemInterface.mm:
3336         (InitWebCoreSystemInterface):
3337         * WebView/WebDynamicScrollBarsView.mm:
3338         (-[WebDynamicScrollBarsView scrollWheel:]):
3339         * WebView/WebHTMLView.mm:
3340         (-[WebHTMLView _removeWindowObservers]):
3341         (-[WebHTMLView addWindowObservers]):
3342         * WebView/WebView.mm:
3343         (-[WebView addWindowObserversForWindow:]):
3344         (-[WebView removeWindowObservers]):
3345         (-[WebView viewWillMoveToWindow:]):
3346
3347 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3348
3349         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3350         https://bugs.webkit.org/show_bug.cgi?id=175779
3351         <rdar://problem/22367975>
3352
3353         Reviewed by Tim Horton.
3354
3355         * WebCoreSupport/WebFrameLoaderClient.h:
3356         * WebCoreSupport/WebFrameLoaderClient.mm:
3357         (WebFrameLoaderClient::webGLPolicyForURL const):
3358         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3359
3360 2017-08-30  Andy Estes  <aestes@apple.com>
3361
3362         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3363         https://bugs.webkit.org/show_bug.cgi?id=176093
3364
3365         Reviewed by Eric Carlson.
3366
3367         * WebCoreSupport/WebSystemInterface.mm:
3368         (InitWebCoreSystemInterface):
3369
3370 2017-08-30  Andy Estes  <aestes@apple.com>
3371
3372         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3373         https://bugs.webkit.org/show_bug.cgi?id=176087
3374
3375         Reviewed by Alex Christensen.
3376
3377         * Carbon/CarbonUtils.m:
3378         (getNSAutoreleasePoolCount):
3379         (WebInitForCarbon):
3380         (PoolCleaner):
3381         * Carbon/CarbonWindowAdapter.mm:
3382         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3383         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3384         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3385         (-[CarbonWindowAdapter _windowMovedToRect:]):
3386         * Carbon/HIViewAdapter.m:
3387         * Carbon/HIWebView.mm:
3388         (Draw):
3389         (CreateNSEventAdoptingCGEvent):
3390         (CopyEventCGEvent):
3391         (CreateNSEventWithCarbonClickEvent):
3392         (Click):
3393         (CreateNSEventWithCarbonEvent):
3394         (MouseUp):
3395         (CreateNSEventWithCarbonMouseMoveEvent):
3396         (MouseMoved):
3397         (MouseDragged):
3398         (MouseWheelMoved):
3399         (WindowHandler):
3400         (HIWebViewEventHandler):
3401         * Misc/QuickDrawCompatibility.h: Removed.
3402         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3403         (getCarbonEvent):
3404         (WebNetscapePluginEventHandlerCarbon::keyDown):
3405         (WebNetscapePluginEventHandlerCarbon::keyUp):
3406         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3407         (WebNetscapePluginEventHandlerCocoa::keyDown):
3408         * Plugins/WebNetscapePluginView.mm:
3409         (-[WebNetscapePluginView tellQuickTimeToChill]):
3410
3411 2017-08-29  Andy Estes  <aestes@apple.com>
3412
3413         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3414         https://bugs.webkit.org/show_bug.cgi?id=176046
3415
3416         Reviewed by Alex Christensen.
3417
3418         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3419         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3420
3421         * Misc/WebNSFileManagerExtras.mm:
3422         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3423         (setMetaData): Deleted.
3424         * WebCoreSupport/WebSystemInterface.mm:
3425         (InitWebCoreSystemInterface):
3426
3427 2017-08-28  Andy Estes  <aestes@apple.com>
3428
3429         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3430         https://bugs.webkit.org/show_bug.cgi?id=176039
3431
3432         Reviewed by Alex Christensen.
3433
3434         * WebCoreSupport/WebSystemInterface.mm:
3435         (InitWebCoreSystemInterface):
3436         * WebView/WebPreferences.mm:
3437         (+[WebPreferences _systemCFStringEncoding]):
3438
3439 2017-08-28  Andy Estes  <aestes@apple.com>
3440
3441         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3442         https://bugs.webkit.org/show_bug.cgi?id=176032
3443
3444         Reviewed by Alex Christensen.
3445
3446         * WebCoreSupport/WebSystemInterface.mm:
3447         (InitWebCoreSystemInterface):
3448         * WebView/WebView.mm:
3449         (-[WebView _cachedResponseForURL:]):
3450
3451 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3452
3453         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3454         https://bugs.webkit.org/show_bug.cgi?id=175992
3455         <rdar://problem/34086613>
3456
3457         Reviewed by Daniel Bates.
3458
3459         * WebCoreSupport/WebPlatformStrategies.h:
3460         * WebCoreSupport/WebPlatformStrategies.mm:
3461         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3462         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3463         indicating if secure cookies were accessed.
3464
3465 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3468         https://bugs.webkit.org/show_bug.cgi?id=170955
3469         <rdar://problem/31697653>
3470
3471         Reviewed by Ryosuke Niwa.
3472
3473         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3474         text is being replaced.
3475
3476         * WebView/WebHTMLView.mm:
3477         (-[WebHTMLView insertText:]):
3478
3479 2017-08-24  Chris Dumez  <cdumez@apple.com>
3480
3481         [Directory Upload] Add basic support for input.webkitdirectory
3482         https://bugs.webkit.org/show_bug.cgi?id=175950
3483         <rdar://problem/33951915>
3484
3485         Reviewed by Geoffrey Garen.