edb3f3033e1bf32ff6a5f8a7b26c80f664d817ea
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Add support for microtasks in workers
4         https://bugs.webkit.org/show_bug.cgi?id=188246
5
6         Reviewed by Darin Adler.
7
8         Rename JSMainThreadExecState.h to JSExecState.h.
9
10         * DOM/DOMAttr.mm:
11         * DOM/DOMBlob.mm:
12         * DOM/DOMCDATASection.mm:
13         * DOM/DOMCSSCharsetRule.mm:
14         * DOM/DOMCSSFontFaceRule.mm:
15         * DOM/DOMCSSImportRule.mm:
16         * DOM/DOMCSSMediaRule.mm:
17         * DOM/DOMCSSPageRule.mm:
18         * DOM/DOMCSSPrimitiveValue.mm:
19         * DOM/DOMCSSRule.mm:
20         * DOM/DOMCSSRuleList.mm:
21         * DOM/DOMCSSStyleDeclaration.mm:
22         * DOM/DOMCSSStyleRule.mm:
23         * DOM/DOMCSSStyleSheet.mm:
24         * DOM/DOMCSSUnknownRule.mm:
25         * DOM/DOMCSSValue.mm:
26         * DOM/DOMCSSValueList.mm:
27         * DOM/DOMCharacterData.mm:
28         * DOM/DOMComment.mm:
29         * DOM/DOMCounter.mm:
30         * DOM/DOMDocument.mm:
31         * DOM/DOMDocumentFragment.mm:
32         * DOM/DOMDocumentType.mm:
33         * DOM/DOMElement.mm:
34         * DOM/DOMEvent.mm:
35         * DOM/DOMFile.mm:
36         * DOM/DOMFileList.mm:
37         * DOM/DOMHTML.mm:
38         * DOM/DOMHTMLAnchorElement.mm:
39         * DOM/DOMHTMLAppletElement.mm:
40         * DOM/DOMHTMLAreaElement.mm:
41         * DOM/DOMHTMLBRElement.mm:
42         * DOM/DOMHTMLBaseElement.mm:
43         * DOM/DOMHTMLBaseFontElement.mm:
44         * DOM/DOMHTMLBodyElement.mm:
45         * DOM/DOMHTMLButtonElement.mm:
46         * DOM/DOMHTMLCanvasElement.mm:
47         * DOM/DOMHTMLCollection.mm:
48         * DOM/DOMHTMLDListElement.mm:
49         * DOM/DOMHTMLDirectoryElement.mm:
50         * DOM/DOMHTMLDivElement.mm:
51         * DOM/DOMHTMLDocument.mm:
52         * DOM/DOMHTMLElement.mm:
53         * DOM/DOMHTMLEmbedElement.mm:
54         * DOM/DOMHTMLFieldSetElement.mm:
55         * DOM/DOMHTMLFontElement.mm:
56         * DOM/DOMHTMLFormElement.mm:
57         * DOM/DOMHTMLFrameElement.mm:
58         * DOM/DOMHTMLFrameSetElement.mm:
59         * DOM/DOMHTMLHRElement.mm:
60         * DOM/DOMHTMLHeadElement.mm:
61         * DOM/DOMHTMLHeadingElement.mm:
62         * DOM/DOMHTMLHtmlElement.mm:
63         * DOM/DOMHTMLIFrameElement.mm:
64         * DOM/DOMHTMLImageElement.mm:
65         * DOM/DOMHTMLInputElement.mm:
66         * DOM/DOMHTMLLIElement.mm:
67         * DOM/DOMHTMLLabelElement.mm:
68         * DOM/DOMHTMLLegendElement.mm:
69         * DOM/DOMHTMLLinkElement.mm:
70         * DOM/DOMHTMLMapElement.mm:
71         * DOM/DOMHTMLMarqueeElement.mm:
72         * DOM/DOMHTMLMediaElement.mm:
73         * DOM/DOMHTMLMenuElement.mm:
74         * DOM/DOMHTMLMetaElement.mm:
75         * DOM/DOMHTMLModElement.mm:
76         * DOM/DOMHTMLOListElement.mm:
77         * DOM/DOMHTMLObjectElement.mm:
78         * DOM/DOMHTMLOptGroupElement.mm:
79         * DOM/DOMHTMLOptionElement.mm:
80         * DOM/DOMHTMLOptionsCollection.mm:
81         * DOM/DOMHTMLParagraphElement.mm:
82         * DOM/DOMHTMLParamElement.mm:
83         * DOM/DOMHTMLPreElement.mm:
84         * DOM/DOMHTMLQuoteElement.mm:
85         * DOM/DOMHTMLScriptElement.mm:
86         * DOM/DOMHTMLSelectElement.mm:
87         * DOM/DOMHTMLStyleElement.mm:
88         * DOM/DOMHTMLTableCaptionElement.mm:
89         * DOM/DOMHTMLTableCellElement.mm:
90         * DOM/DOMHTMLTableColElement.mm:
91         * DOM/DOMHTMLTableElement.mm:
92         * DOM/DOMHTMLTableRowElement.mm:
93         * DOM/DOMHTMLTableSectionElement.mm:
94         * DOM/DOMHTMLTextAreaElement.mm:
95         * DOM/DOMHTMLTitleElement.mm:
96         * DOM/DOMHTMLUListElement.mm:
97         * DOM/DOMHTMLVideoElement.mm:
98         * DOM/DOMImplementation.mm:
99         * DOM/DOMKeyboardEvent.mm:
100         * DOM/DOMMediaError.mm:
101         * DOM/DOMMediaList.mm:
102         * DOM/DOMMouseEvent.mm:
103         * DOM/DOMMutationEvent.mm:
104         * DOM/DOMNamedNodeMap.mm:
105         * DOM/DOMNode.mm:
106         * DOM/DOMNodeIterator.mm:
107         * DOM/DOMNodeList.mm:
108         * DOM/DOMOverflowEvent.mm:
109         * DOM/DOMProcessingInstruction.mm:
110         * DOM/DOMProgressEvent.mm:
111         * DOM/DOMRGBColor.mm:
112         * DOM/DOMRange.mm:
113         * DOM/DOMRect.mm:
114         * DOM/DOMStyleSheet.mm:
115         * DOM/DOMStyleSheetList.mm:
116         * DOM/DOMText.mm:
117         * DOM/DOMTextEvent.mm:
118         * DOM/DOMTimeRanges.mm:
119         * DOM/DOMTokenList.mm:
120         * DOM/DOMTreeWalker.mm:
121         * DOM/DOMUIEvent.mm:
122         * DOM/DOMWheelEvent.mm:
123         * DOM/DOMXPathExpression.mm:
124         * DOM/DOMXPathResult.mm:
125         * DOM/ObjCEventListener.mm:
126
127 2018-08-03  Alex Christensen  <achristensen@webkit.org>
128
129         Fix spelling of "overridden"
130         https://bugs.webkit.org/show_bug.cgi?id=188315
131
132         Reviewed by Darin Adler.
133
134         * Misc/WebKitVersionChecks.mm:
135         (setWebKitLinkTimeVersion):
136         (WebKitLinkTimeVersion):
137         * Plugins/WebBaseNetscapePluginView.mm:
138         (-[WebBaseNetscapePluginView handleMouseMoved:]):
139         * WebCoreSupport/PopupMenuMac.mm:
140         (PopupMenuMac::populate):
141
142 2018-08-01  Nan Wang  <n_wang@apple.com>
143
144         AX: AOM: Add ARIA IDL Attribute Reflection
145         https://bugs.webkit.org/show_bug.cgi?id=184676
146         <rdar://problem/39476882>
147
148         Reviewed by Chris Fleizach.
149
150         * WebView/WebPreferenceKeysPrivate.h:
151         * WebView/WebPreferences.mm:
152         (+[WebPreferences initialize]):
153         (-[WebPreferences ariaReflectionEnabled]):
154         (-[WebPreferences setAriaReflectionEnabled:]):
155         * WebView/WebPreferencesPrivate.h:
156         * WebView/WebView.mm:
157         (-[WebView _preferencesChanged:]):
158
159 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
160
161         Shrink GraphicsLayerCA
162         https://bugs.webkit.org/show_bug.cgi?id=188141
163
164         Reviewed by Zalan Bujtas.
165
166         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
167         * moving all the clone-related stuff into the lazily-allocated m_layerClones
168         * moving all the animation-related stuff into the lazily-allocated m_animations
169         * making enums be 8-bit
170         * re-ordering data members
171
172         * WebView/WebView.mm:
173         (-[WebView _setMediaLayer:forPluginView:]):
174
175 2018-07-30  Rob Buis  <rbuis@igalia.com>
176
177         Merge PlatformCookieJar functions into NetworkStorageSession
178         https://bugs.webkit.org/show_bug.cgi?id=188137
179
180         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
181
182         Reviewed by Alex Christensen.
183
184         * WebCoreSupport/WebPlatformStrategies.mm:
185         (WebPlatformStrategies::cookiesForDOM):
186         (WebPlatformStrategies::setCookiesFromDOM):
187         (WebPlatformStrategies::cookiesEnabled):
188         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
189         (WebPlatformStrategies::getRawCookies):
190         (WebPlatformStrategies::deleteCookie):
191         * WebView/WebPreferences.mm:
192         (+[WebPreferences _clearNetworkLoaderSession]):
193
194 2018-07-28  Darin Adler  <darin@apple.com>
195
196         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
197         https://bugs.webkit.org/show_bug.cgi?id=188140
198
199         Reviewed by Sam Weinig.
200
201         * WebView/WebImmediateActionController.mm:
202         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
203         new DictionaryLookup function that returns a tuple instead of using an out argument.
204
205 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
206
207         [INTL] Remove INTL sub-feature compile flags
208         https://bugs.webkit.org/show_bug.cgi?id=188081
209
210         Reviewed by Michael Catanzaro.
211
212         * Configurations/FeatureDefines.xcconfig:
213
214 2018-07-26  Commit Queue  <commit-queue@webkit.org>
215
216         Unreviewed, rolling out r234181 and r234189.
217         https://bugs.webkit.org/show_bug.cgi?id=188075
218
219         These are not needed right now (Requested by thorton on
220         #webkit).
221
222         Reverted changesets:
223
224         "Enable Web Content Filtering on watchOS"
225         https://bugs.webkit.org/show_bug.cgi?id=187979
226         https://trac.webkit.org/changeset/234181
227
228         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
229         https://bugs.webkit.org/show_bug.cgi?id=187985
230         https://trac.webkit.org/changeset/234189
231
232 2018-07-26  Timothy Hatcher  <timothy@apple.com>
233
234         Use the Page's appearance when converting pasteboard attributed strings.
235         https://bugs.webkit.org/show_bug.cgi?id=188067
236         rdar://problem/42632246
237
238         Reviewed by Wenson Hsieh.
239
240         * WebCoreSupport/WebEditorClient.mm:
241         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
242
243 2018-07-25  Chris Dumez  <cdumez@apple.com>
244
245         navigator.userAgent may return outdated value after webView.customUserAgent is set
246         https://bugs.webkit.org/show_bug.cgi?id=188009
247         <rdar://problem/42566456>
248
249         Reviewed by Alex Christensen.
250
251         Let the page know when the user agent changes.
252
253         * WebView/WebView.mm:
254         (-[WebView _preferencesChanged:]):
255         (-[WebView setApplicationNameForUserAgent:]):
256         (-[WebView _invalidateUserAgentCache]):
257         (-[WebView setCustomUserAgent:]):
258         * WebView/WebViewInternal.h:
259
260 2018-07-24  Tim Horton  <timothy_horton@apple.com>
261
262         Enable Web Content Filtering on watchOS
263         https://bugs.webkit.org/show_bug.cgi?id=187979
264         <rdar://problem/42559346>
265
266         Reviewed by Wenson Hsieh.
267
268         * Configurations/FeatureDefines.xcconfig:
269
270 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
271
272         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
273         https://bugs.webkit.org/show_bug.cgi?id=187846
274
275         Reviewed by Simon Fraser.
276
277         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
278
279         * WebView/WebHTMLView.mm:
280         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
281         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
282
283 2018-07-11  Dean Jackson  <dino@apple.com>
284
285         Allow removal of white backgrounds
286         https://bugs.webkit.org/show_bug.cgi?id=187574
287         <rdar://problem/41146792>
288
289         Reviewed by Simon Fraser.
290
291         Add a new WebPreference for punching out white backgrounds.
292
293         * WebView/WebPreferenceKeysPrivate.h:
294         * WebView/WebPreferences.mm:
295         (+[WebPreferences initialize]):
296         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
297         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
298         * WebView/WebPreferencesPrivate.h:
299         * WebView/WebView.mm:
300         (-[WebView _preferencesChanged:]):
301
302 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
303
304         Ensure WebKit stack is ad-hoc signed
305         https://bugs.webkit.org/show_bug.cgi?id=187667
306
307         Reviewed by Alexey Proskuryakov.
308
309         * Configurations/Base.xcconfig:
310
311 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
312
313         REGRESSION (231276): Attempting to copy an image fails
314         https://bugs.webkit.org/show_bug.cgi?id=187212
315         <rdar://problem/41540074>
316
317         Reviewed by Ryosuke Niwa.
318
319         Renamed methods to make it clear that one URL and one title are being passed in.
320
321         * WebCoreSupport/WebPlatformStrategies.h:
322         * WebCoreSupport/WebPlatformStrategies.mm:
323         (WebPlatformStrategies::setURL):
324
325 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
326
327         Disable cross-origin-window-policy by default
328         https://bugs.webkit.org/show_bug.cgi?id=187509
329
330         Reviewed by Chris Dumez.
331
332         * WebView/WebPreferences.mm:
333         (+[WebPreferences initialize]):
334
335 2018-07-09  Timothy Hatcher  <timothy@apple.com>
336
337         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
338         https://bugs.webkit.org/show_bug.cgi?id=187425
339         rdar://problem/39948240
340
341         Reviewed by Tim Horton.
342
343         * WebView/WebView.mm:
344         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
345         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
346         a call in this method to setUseDarkAppearance.
347         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
348         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
349         (-[WebView _updateDefaultAppearance]): Deleted.
350         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
351
352 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
353
354         Shrink various loading-related enums to shrink CachedResource
355         https://bugs.webkit.org/show_bug.cgi?id=187443
356
357         Reviewed by Chris Dumez.
358
359         * WebCoreSupport/WebFrameLoaderClient.mm:
360         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
361         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
362         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
363         (WebFrameLoaderClient::dispatchWillSendRequest):
364         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
365         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
366         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
367         (WebFrameLoaderClient::updateGlobalHistory):
368         (WebFrameLoaderClient::canHandleRequest const):
369         * WebView/WebDataSource.mm:
370         (-[WebDataSource initialRequest]):
371         (-[WebDataSource request]):
372
373 2018-07-09  Commit Queue  <commit-queue@webkit.org>
374
375         Unreviewed, rolling out r233612.
376         https://bugs.webkit.org/show_bug.cgi?id=187475
377
378         Revision caused the api test LinkColorWithSystemAppearance to
379         fail on all systems. (Requested by Truitt on #webkit).
380
381         Reverted changeset:
382
383         "Semantic colors don't update when accessibility Increase
384         Contrast mode is enabled."
385         https://bugs.webkit.org/show_bug.cgi?id=187425
386         https://trac.webkit.org/changeset/233612
387
388 2018-07-06  Timothy Hatcher  <timothy@apple.com>
389
390         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
391         https://bugs.webkit.org/show_bug.cgi?id=187425
392         rdar://problem/39948240
393
394         Reviewed by Tim Horton.
395
396         * WebView/WebView.mm:
397         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
398         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
399         a call in this method to setUseDarkAppearance.
400         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
401         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
402         (-[WebView _updateDefaultAppearance]): Deleted.
403         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
404
405 2018-07-05  Timothy Hatcher  <timothy@apple.com>
406
407         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
408         https://bugs.webkit.org/show_bug.cgi?id=187369
409         rdar://problem/41870420
410
411         Reviewed by Tim Horton.
412
413         * WebView/WebMediaPlaybackTargetPicker.mm:
414         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
415         * WebView/WebView.mm:
416         (-[WebView _commonInitializationWithFrameName:groupName:]):
417         (-[WebView _effectiveAppearanceIsDark]):
418         (-[WebView _updateDefaultAppearance]):
419         (-[WebView _defaultAppearance]): Deleted.
420
421 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
422
423         Youtube video pages crash after a couple of minutes
424         https://bugs.webkit.org/show_bug.cgi?id=187316
425
426         Reviewed by Antti Koivisto.
427
428         * WebView/WebView.mm:
429         (-[WebView _preferencesChanged:]):
430
431 2018-07-04  Tim Horton  <timothy_horton@apple.com>
432
433         Introduce PLATFORM(IOSMAC)
434         https://bugs.webkit.org/show_bug.cgi?id=187315
435
436         Reviewed by Dan Bernstein.
437
438         * Configurations/Base.xcconfig:
439         * Configurations/FeatureDefines.xcconfig:
440
441 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
442
443         [iOS] DataTransfer.getData always returns the empty string when dropping text
444         https://bugs.webkit.org/show_bug.cgi?id=187130
445         <rdar://problem/41014117>
446
447         Reviewed by Ryosuke Niwa.
448
449         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
450
451         * WebCoreSupport/WebPlatformStrategies.h:
452         * WebCoreSupport/WebPlatformStrategies.mm:
453         (WebPlatformStrategies::allPasteboardItemInfo):
454
455 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
456
457         [Mac] AirPlay picker uses incorrect theme in Dark mode
458         https://bugs.webkit.org/show_bug.cgi?id=187054
459         <rdar://problem/41291093>
460
461         Reviewed by Timothy Hatcher.
462
463         * WebView/WebMediaPlaybackTargetPicker.mm:
464         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
465
466 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
467
468         [WTF] Add user-defined literal for ASCIILiteral
469         https://bugs.webkit.org/show_bug.cgi?id=186839
470
471         Reviewed by Darin Adler.
472
473         * DOM/ExceptionHandlers.mm:
474         (raiseDOMErrorException):
475         * Plugins/Hosted/ProxyInstance.mm:
476         (WebKit::ProxyInstance::invokeMethod):
477         * Storage/WebDatabaseProvider.mm:
478         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
479
480 2018-06-22  Timothy Hatcher  <timothy@apple.com>
481
482         Recalc styles every time defaultAppearance changes.
483         https://bugs.webkit.org/show_bug.cgi?id=186866
484         rdar://problem/41309805
485
486         Reviewed by Tim Horton.
487
488         * WebView/WebView.mm:
489         (-[WebView _updateDefaultAppearance]):
490         (-[WebView _setUseSystemAppearance:]):
491         (-[WebView _useSystemAppearance]):
492
493 2018-06-20  Darin Adler  <darin@apple.com>
494
495         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
496         https://bugs.webkit.org/show_bug.cgi?id=186875
497
498         Reviewed by Anders Carlsson.
499
500         * WebView/WebHTMLView.mm:
501         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
502         to write te file to.
503         * WebView/WebPreferences.mm:
504         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
505         * WebView/WebView.mm:
506         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
507
508 2018-06-12  Darin Adler  <darin@apple.com>
509
510         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
511         https://bugs.webkit.org/show_bug.cgi?id=186526
512
513         Reviewed by Anders Carlsson.
514
515         * Plugins/Hosted/NetscapePluginHostManager.mm:
516         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
517
518         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
519         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
520         assignment rather than adoptNS/leakRef.
521         * Plugins/WebNetscapePluginView.mm:
522         (-[WebNetscapePluginView createPlugin]): Ditto.
523
524         * WebCoreSupport/WebContextMenuClient.mm:
525         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
526         RetainPtr::autorelease; no need to autorelease just to pass something as a function
527         argument, so use RetainPtr::get instead.
528
529         * WebView/WebHTMLView.mm:
530         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
531         No need to autorelease the result when the return type is RetainPtr.
532
533         * WebView/WebPDFRepresentation.mm:
534         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
535
536 2018-06-13  Youenn Fablet  <youenn@apple.com>
537
538         Supported plugin check should be based on plugin identifier
539         https://bugs.webkit.org/show_bug.cgi?id=186578
540         <rdar://problem/40523828>
541
542         Reviewed by Darin Adler.
543
544         * WebCoreSupport/WebPluginInfoProvider.h:
545         * WebCoreSupport/WebPluginInfoProvider.mm:
546         (WebPluginInfoProvider::pluginInfo):
547         (WebPluginInfoProvider::webVisiblePluginInfo):
548
549 2018-06-13  Chris Dumez  <cdumez@apple.com>
550
551         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
552         https://bugs.webkit.org/show_bug.cgi?id=186545
553
554         Reviewed by Brady Eidson.
555
556         Update client delegate now that parameter type has changed.
557
558         * WebCoreSupport/WebFrameLoaderClient.h:
559         * WebCoreSupport/WebFrameLoaderClient.mm:
560         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
561
562 2018-06-11  Tim Horton  <timothy_horton@apple.com>
563
564         Link drag image is inconsistently unreadable in dark mode
565         https://bugs.webkit.org/show_bug.cgi?id=186472
566
567         Reviewed by Timothy Hatcher.
568
569         * WebView/WebView.mm:
570         (-[WebView _defaultAppearance]):
571         Make defaultAppearance accurate even if useSystemAppearance is false.
572         Some parts of WebKit (like the link drag image, but also context menus)
573         want to be able to follow the system appearance regardless of whether
574         the view or content has opted in.
575
576 2018-06-11  Chris Dumez  <cdumez@apple.com>
577
578         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
579         https://bugs.webkit.org/show_bug.cgi?id=186441
580
581         Reviewed by Brady Eidson.
582
583         Rename existing flag to something a bit more generic, now that it is used for
584         more things than bypassing the navigation policy check.
585
586         * WebView/WebView.mm:
587         (-[WebView _loadBackForwardListFromOtherView:]):
588         (-[WebView goToBackForwardItem:]):
589
590 2018-06-09  Dan Bernstein  <mitz@apple.com>
591
592         [Xcode] Clean up and modernize some build setting definitions
593         https://bugs.webkit.org/show_bug.cgi?id=186463
594
595         Reviewed by Sam Weinig.
596
597         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
598         * Configurations/DebugRelease.xcconfig: Ditto.
599         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
600           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
601         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
602         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
603           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
604         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
605
606 2018-06-08  Darin Adler  <darin@apple.com>
607
608         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
609         https://bugs.webkit.org/show_bug.cgi?id=186436
610
611         Reviewed by Anders Carlsson.
612
613         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
614         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
615         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
616         (PoolCleaner): Ditto.
617
618         * History/WebHistory.mm:
619         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
620         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
621         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
622         now hardly used if at all.
623         * WebView/WebView.mm:
624         (-[WebView rectsForTextMatches]): Ditto.
625
626 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
627
628         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
629         https://bugs.webkit.org/show_bug.cgi?id=186442
630         <rdar://problem/40879364>
631
632         Reviewed by Tim Horton.
633
634         * Configurations/FeatureDefines.xcconfig:
635
636 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
637
638         [Datalist] Allow TextFieldInputType to show and hide suggestions
639         https://bugs.webkit.org/show_bug.cgi?id=186151
640
641         Reviewed by Tim Horton.
642
643         * WebCoreSupport/WebChromeClient.h:
644         * WebCoreSupport/WebChromeClient.mm:
645         (WebChromeClient::createDataListSuggestionPicker):
646
647 2018-06-07  Chris Dumez  <cdumez@apple.com>
648
649         Add base class to get WeakPtrFactory member and avoid some boilerplate code
650         https://bugs.webkit.org/show_bug.cgi?id=186407
651
652         Reviewed by Brent Fulgham.
653
654         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
655         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
656         This also gets rid of old-style createWeakPtr() methods in favor of the newer
657         makeWeakPtr().
658
659         * WebCoreSupport/WebEditorClient.h:
660         * WebCoreSupport/WebEditorClient.mm:
661         (WebEditorClient::requestCandidatesForSelection):
662
663 2018-06-05  Chris Dumez  <cdumez@apple.com>
664
665         Regression(r232082): Websites get loaded inside of Messages App chat transcript
666         https://bugs.webkit.org/show_bug.cgi?id=186331
667         <rdar://problem/40735446>
668
669         Reviewed by Darin Adler.
670
671         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
672         but does not call use / ignore on the listener, then we would do "use" by default.
673         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
674         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
675         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
676         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
677         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
678         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
679         and Box.app is still working properly.
680
681         * WebCoreSupport/WebFrameLoaderClient.h:
682         * WebCoreSupport/WebFrameLoaderClient.mm:
683         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
684         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
685         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
686         (WebFrameLoaderClient::dispatchWillSubmitForm):
687         (WebFrameLoaderClient::setUpPolicyListener):
688         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
689         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
690         (-[WebFramePolicyListener dealloc]):
691         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
692         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
693
694 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
695
696         Adjust compile and runtime flags to match shippable state of features
697         https://bugs.webkit.org/show_bug.cgi?id=186319
698         <rdar://problem/40352045>
699
700         Reviewed by Maciej Stachowiak, Jon Lee, and others.
701
702         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
703         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
704         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
705         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
706         Cocoa builds.
707
708 2018-06-05  Timothy Hatcher  <timothy@apple.com>
709
710         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
711
712         https://bugs.webkit.org/show_bug.cgi?id=186323
713         rdar://problem/38382252
714
715         Reviewed by Tim Horton.
716
717         * WebView/WebView.mm:
718         (-[WebView _defaultAppearance]):
719
720 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
721
722         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
723         https://bugs.webkit.org/show_bug.cgi?id=186286
724         <rdar://problem/40782992>
725
726         Reviewed by Dan Bernstein.
727
728         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
729         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
730         change this flag when preparing for a production release.
731
732         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
733         whether experimental features should be enabled, and use it to properly define the
734         feature flag.
735
736 2018-06-03  Darin Adler  <darin@apple.com>
737
738         Simplify and remove some unused video element code (helpful for ARC-compatibility)
739         https://bugs.webkit.org/show_bug.cgi?id=186258
740
741         Reviewed by Daniel Bates.
742
743         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
744         forward declarations. Removed methods that don't need to be public.
745
746         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
747         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
748         unnamed category in here and also replaced the HUDWindowControllerDelegate
749         with the unnamed category. Removed unused NSWindow category defining the
750         isOnActiveSpace, which is not called anywhere in this file at this time.
751         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
752         into setVideoElement.
753         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
754         and removed unneeded typecast.
755         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
756         using statement at the top of the file.
757         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
758         the many side effects and special considerations that this method that sounds
759         like a setter has. Updated code to use the new
760         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
761         HTMLVideoElement::platformMedia function. Also straightened out the logic a
762         bit and added some FIXME comments about small problems noticed but not fixed.
763         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
764         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
765         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
766         typecast. Removed call to updatePowerAssertions method.
767         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
768         updatePowerAssertions method.
769         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
770         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
771         else, so this was dead code that did nothing.
772         (-[WebVideoFullscreenController rateChanged:]): Removed call to
773         updatePowerAssertions method.
774
775 2018-06-04  Chris Dumez  <cdumez@apple.com>
776
777         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
778         https://bugs.webkit.org/show_bug.cgi?id=186287
779         <rdar://problem/40783352>
780
781         Reviewed by Youenn Fablet.
782
783         * WebView/WebPreferenceKeysPrivate.h:
784         * WebView/WebPreferences.mm:
785         (+[WebPreferences initialize]):
786         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
787         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
788         * WebView/WebPreferencesPrivate.h:
789         * WebView/WebView.mm:
790         (-[WebView _preferencesChanged:]):
791
792 2018-06-02  Darin Adler  <darin@apple.com>
793
794         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
795         https://bugs.webkit.org/show_bug.cgi?id=186227
796
797         Reviewed by Dan Bernstein.
798
799         * Misc/WebKitErrors.m:
800         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
801         * Plugins/WebPluginDatabase.mm:
802         (-[WebPluginDatabase refresh]): Ditto.
803         * WebCoreSupport/WebChromeClient.mm:
804         (WebChromeClient::setStatusbarText): Ditto.
805
806 2018-06-01  Chris Dumez  <cdumez@apple.com>
807
808         REGRESSION (r231456): Colloquy is broken
809         https://bugs.webkit.org/show_bug.cgi?id=186197
810         <rdar://problem/40722960>
811
812         Reviewed by Timothy Hatcher.
813
814         Restore pre-r231456 behavior for Colloquy app so that it works again.
815
816         * WebView/WebView.mm:
817         (-[WebView _needsFrameNameFallbackToIdQuirk]):
818         (-[WebView _preferencesChanged:]):
819
820 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
821
822         [JSC] Pass VM& parameter as much as possible
823         https://bugs.webkit.org/show_bug.cgi?id=186085
824
825         Reviewed by Saam Barati.
826
827         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
828         (WebKit::NetscapePluginInstanceProxy::invoke):
829
830 2018-05-30  Daniel Bates  <dabates@apple.com>
831
832         NavigationAction does not need to hold initiating DOM Event
833         https://bugs.webkit.org/show_bug.cgi?id=185958
834         <rdar://problem/40531539>
835
836         Reviewed by Simon Fraser.
837
838         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
839
840         * WebCoreSupport/WebFrameLoaderClient.mm:
841         (WebFrameLoaderClient::actionDictionary const):
842         (findMouseEvent): Deleted.
843
844 2018-05-27  Dan Bernstein  <mitz@apple.com>
845
846         Reverted the changes made for https://webkit.org/b/186016
847
848         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
849
850
851 2018-05-27  David Kilzer  <ddkilzer@apple.com>
852
853         [iOS] Fix warnings about leaks found by clang static analyzer
854         <https://webkit.org/b/186009>
855         <rdar://problem/40574267>
856
857         Reviewed by Daniel Bates.
858
859         * WebView/WebHTMLView.mm:
860         (-[WebHTMLView doCommandBySelector:]): Fix use of an
861         uninitialized boolean variable (`eventWasHandled`) that only
862         happened on iOS.
863
864 2018-05-27  Dan Bernstein  <mitz@apple.com>
865
866         [Cocoa] Avoid importing directly from subumbrella frameworks
867         https://bugs.webkit.org/show_bug.cgi?id=186016
868
869         Reviewed by Sam Weinig.
870
871         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
872         * Carbon/CarbonWindowAdapter.mm: Ditto.
873         * Carbon/CarbonWindowFrame.m: Ditto.
874         * Carbon/HIViewAdapter.h: Ditto.
875         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
876           OTHER_CPLUSPLUSFLAGS.
877         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
878         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
879         * WebView/WebPDFView.h: Ditto.
880
881 2018-05-27  Sam Weinig  <sam@webkit.org>
882
883         Modernize RenderStyleConstants.h - Part 3
884         https://bugs.webkit.org/show_bug.cgi?id=186015
885
886         Reviewed by Yusuke Suzuki.
887
888         * WebView/WebView.mm:
889         (-[WebView updateTextTouchBar]):
890         Update for new enum name.
891
892 2018-05-25  Chris Dumez  <cdumez@apple.com>
893
894         Minor ApplicationCacheStorage clean up
895         https://bugs.webkit.org/show_bug.cgi?id=185984
896
897         Reviewed by Youenn Fablet.
898
899         * WebCoreSupport/WebApplicationCache.mm:
900         (+[WebApplicationCache originsWithCache]):
901
902 2018-05-25  David Kilzer  <ddkilzer@apple.com>
903
904         Fix issues with -dealloc methods found by clang static analyzer
905         <https://webkit.org/b/185887>
906
907         Reviewed by Joseph Pecoraro.
908
909         * WebView/WebView.mm:
910         (-[WebUITextIndicatorData dealloc]):
911         - Move method implementation from (WebUITextIndicatorInternal)
912           category to the main category since this is public API.  This
913           fixes the false positive warning about a missing -dealloc
914           method.
915
916 2018-05-24  Sam Weinig  <sam@webkit.org>
917
918         Modernize RenderStyleConstants.h - Part 2
919         https://bugs.webkit.org/show_bug.cgi?id=185901
920
921         Reviewed by Simon Fraser.
922
923         * WebView/WebHTMLRepresentation.mm:
924         (searchForLabelsBeforeElement):
925         * WebView/WebView.mm:
926         (nsTextAlignmentFromRenderStyle):
927         Update for new enum names.
928
929 2018-05-22  Chris Dumez  <cdumez@apple.com>
930
931         Regression(AsyncPolicyDelegates): Box.app login Window is blank
932         https://bugs.webkit.org/show_bug.cgi?id=185832
933         <rdar://problem/40307871>
934
935         Reviewed by Geoffrey Garen.
936
937         We used to have a bug where where we would fail to wait for the policy decision for
938         the navigation response from the client and the load would keep going, racing with
939         the client's policy decision. If the client did not respond in time, the behavior
940         would be the same as "Use" policy action.
941
942         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
943         but the load happened to proceed anyway due to our bug. Now that we've fixed the
944         WebKit bug, however, the load would hang because the completion handler for the
945         decidePolicyForNavigationResponse would never get called.
946
947         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
948         instead of retaining it. If the policy listener object gets destroyed because getting
949         resolved, we now use "Use" policy action in its dealloc function to maintain previous
950         behavior.
951
952         * WebCoreSupport/WebFrameLoaderClient.h:
953         * WebCoreSupport/WebFrameLoaderClient.mm:
954         (WebFrameLoaderClient::cancelPolicyCheck):
955         (WebFrameLoaderClient::setUpPolicyListener):
956         (-[WebFramePolicyListener dealloc]):
957
958 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
959
960         Unreviewed, rolling out r232052.
961
962         Breaks internal builds.
963
964         Reverted changeset:
965
966         "Use more C++17"
967         https://bugs.webkit.org/show_bug.cgi?id=185176
968         https://trac.webkit.org/changeset/232052
969
970 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
971
972         Use more C++17
973         https://bugs.webkit.org/show_bug.cgi?id=185176
974
975         Reviewed by JF Bastien.
976
977         * Configurations/Base.xcconfig:
978         * Configurations/WebKitLegacy.xcconfig:
979
980 2018-05-21  Chris Nardi  <cnardi@chromium.org>
981
982         Remove dead exception in MediaList.appendMedium
983         https://bugs.webkit.org/show_bug.cgi?id=185278
984
985         Reviewed by Chris Dumez.
986
987         Remove code pertaining to an exception being thrown by appendMedium().
988
989         * DOM/DOMMediaList.mm:
990         (-[DOMMediaList appendMedium:]):
991
992 2018-05-21  Jer Noble  <jer.noble@apple.com>
993
994         Complete fix for enabling modern EME by default
995         https://bugs.webkit.org/show_bug.cgi?id=185770
996         <rdar://problem/40368220>
997
998         Reviewed by Eric Carlson.
999
1000         * Configurations/FeatureDefines.xcconfig:
1001
1002 2018-05-21  Antti Koivisto  <antti@apple.com>
1003
1004         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
1005         https://bugs.webkit.org/show_bug.cgi?id=185815
1006         <rdar://problem/40310069>
1007
1008         Reviewed by Simon Fraser.
1009
1010         User stylesheet parsing may depend on the colorFilterEnabled preference.
1011
1012         * WebView/WebView.mm:
1013         (-[WebView _preferencesChanged:]):
1014
1015 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1016
1017         Unreviewed, rolling out r231982.
1018         https://bugs.webkit.org/show_bug.cgi?id=185793
1019
1020         Caused layout test failures (Requested by realdawei on
1021         #webkit).
1022
1023         Reverted changeset:
1024
1025         "Complete fix for enabling modern EME by default"
1026         https://bugs.webkit.org/show_bug.cgi?id=185770
1027         https://trac.webkit.org/changeset/231982
1028
1029 2018-05-18  Jer Noble  <jer.noble@apple.com>
1030
1031         Complete fix for enabling modern EME by default
1032         https://bugs.webkit.org/show_bug.cgi?id=185770
1033         <rdar://problem/40368220>
1034
1035         Reviewed by Eric Carlson.
1036
1037         * Configurations/FeatureDefines.xcconfig:
1038
1039 2018-05-18  Chris Dumez  <cdumez@apple.com>
1040
1041         Avoid keeping the frame alive when ref'ing a WindowProxy
1042         https://bugs.webkit.org/show_bug.cgi?id=185737
1043         <rdar://problem/40004666>
1044
1045         Reviewed by Sam Weinig.
1046
1047         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1048         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1049
1050 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1051
1052         Add support for Intl NumberFormat formatToParts
1053         https://bugs.webkit.org/show_bug.cgi?id=185375
1054
1055         Reviewed by Yusuke Suzuki.
1056
1057         Add flag for NumberFormat formatToParts.
1058
1059         * Configurations/FeatureDefines.xcconfig:
1060
1061 2018-05-16  Chris Nardi  <cnardi@chromium.org>
1062
1063         Fixup after r231849: Do not mark Mac API methods as deprecated
1064         https://bugs.webkit.org/show_bug.cgi?id=185684
1065
1066         Reviewed by Darin Adler.
1067
1068         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
1069         as the entire class is already marked as deprecated, so it is unnecessary.
1070
1071         * DOM/DOMDocument.h:
1072
1073 2018-05-16  Chris Nardi  <cnardi@chromium.org>
1074
1075         Remove Document#selectedStylesheetSet/preferredStylesheetSet
1076         https://bugs.webkit.org/show_bug.cgi?id=185381
1077
1078         Reviewed by Darin Adler.
1079
1080         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
1081         and make them do nothing.
1082
1083         * DOM/DOMDocument.h:
1084         * DOM/DOMDocument.mm:
1085         (-[DOMDocument preferredStylesheetSet]):
1086         (-[DOMDocument selectedStylesheetSet]):
1087         (-[DOMDocument setSelectedStylesheetSet:]):
1088
1089 2018-05-15  Antoine Quint  <graouts@apple.com>
1090
1091         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1092         https://bugs.webkit.org/show_bug.cgi?id=185647
1093
1094         Reviewed by Dean Jackson.
1095
1096         Rename the Web Animations CSS integration flag.
1097
1098         * WebView/WebPreferenceKeysPrivate.h:
1099         * WebView/WebPreferences.mm:
1100         (+[WebPreferences initialize]):
1101         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
1102         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
1103         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
1104         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
1105         * WebView/WebPreferencesPrivate.h:
1106         * WebView/WebView.mm:
1107         (-[WebView _preferencesChanged:]):
1108
1109 2018-05-14  Daniel Bates  <dabates@apple.com>
1110
1111         Fix the Apple Internal build
1112
1113         See <rdar://problem/40237873> for more details.
1114
1115         * WebView/WebFullScreenController.mm:
1116         (-[WebFullScreenController enterFullScreen:]):
1117         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1118         (-[WebFullScreenController exitFullScreen]):
1119         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1120         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1121         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1122
1123 2018-05-11  Timothy Hatcher  <timothy@apple.com>
1124
1125         WebHTMLView is not setting aside subviews when drawing.
1126
1127         https://bugs.webkit.org/show_bug.cgi?id=185561
1128         rdar://problem/40172894
1129
1130         Reviewed by Simon Fraser.
1131
1132         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
1133
1134         * WebView/WebHTMLView.mm:
1135         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
1136
1137 2018-05-07  Daniel Bates  <dabates@apple.com>
1138
1139         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1140         https://bugs.webkit.org/show_bug.cgi?id=185170
1141
1142         Reviewed by Per Arne Vollan.
1143
1144         * Misc/WebCache.mm:
1145         (+[WebCache empty]):
1146
1147 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1148
1149         Deprecate legacy WebView and friends
1150         https://bugs.webkit.org/show_bug.cgi?id=185279
1151         rdar://problem/33268700
1152
1153         Reviewed by Tim Horton.
1154
1155         Added deprecation macros to all the classes, extern strings, and enums.
1156
1157         * Configurations/WebKitLegacy.xcconfig:
1158         Added BUILDING_WEBKIT define to disable the deprecation macros.
1159         * DOM/DOMAbstractView.h:
1160         * DOM/DOMAttr.h:
1161         * DOM/DOMBlob.h:
1162         * DOM/DOMCDATASection.h:
1163         * DOM/DOMCSSCharsetRule.h:
1164         * DOM/DOMCSSFontFaceRule.h:
1165         * DOM/DOMCSSImportRule.h:
1166         * DOM/DOMCSSMediaRule.h:
1167         * DOM/DOMCSSPageRule.h:
1168         * DOM/DOMCSSPrimitiveValue.h:
1169         * DOM/DOMCSSRule.h:
1170         * DOM/DOMCSSRuleList.h:
1171         * DOM/DOMCSSStyleDeclaration.h:
1172         * DOM/DOMCSSStyleRule.h:
1173         * DOM/DOMCSSStyleSheet.h:
1174         * DOM/DOMCSSUnknownRule.h:
1175         * DOM/DOMCSSValue.h:
1176         * DOM/DOMCSSValueList.h:
1177         * DOM/DOMCharacterData.h:
1178         * DOM/DOMComment.h:
1179         * DOM/DOMCounter.h:
1180         * DOM/DOMDocument.h:
1181         * DOM/DOMDocumentFragment.h:
1182         * DOM/DOMDocumentType.h:
1183         * DOM/DOMElement.h:
1184         * DOM/DOMEntity.h:
1185         * DOM/DOMEntityReference.h:
1186         * DOM/DOMEvent.h:
1187         * DOM/DOMEventException.h:
1188         * DOM/DOMEventListener.h:
1189         * DOM/DOMEventTarget.h:
1190         * DOM/DOMException.h:
1191         * DOM/DOMFile.h:
1192         * DOM/DOMFileList.h:
1193         * DOM/DOMHTMLAnchorElement.h:
1194         * DOM/DOMHTMLAppletElement.h:
1195         * DOM/DOMHTMLAreaElement.h:
1196         * DOM/DOMHTMLBRElement.h:
1197         * DOM/DOMHTMLBaseElement.h:
1198         * DOM/DOMHTMLBaseFontElement.h:
1199         * DOM/DOMHTMLBodyElement.h:
1200         * DOM/DOMHTMLButtonElement.h:
1201         * DOM/DOMHTMLCanvasElement.h:
1202         * DOM/DOMHTMLCollection.h:
1203         * DOM/DOMHTMLDListElement.h:
1204         * DOM/DOMHTMLDirectoryElement.h:
1205         * DOM/DOMHTMLDivElement.h:
1206         * DOM/DOMHTMLDocument.h:
1207         * DOM/DOMHTMLElement.h:
1208         * DOM/DOMHTMLEmbedElement.h:
1209         * DOM/DOMHTMLFieldSetElement.h:
1210         * DOM/DOMHTMLFontElement.h:
1211         * DOM/DOMHTMLFormElement.h:
1212         * DOM/DOMHTMLFrameElement.h:
1213         * DOM/DOMHTMLFrameSetElement.h:
1214         * DOM/DOMHTMLHRElement.h:
1215         * DOM/DOMHTMLHeadElement.h:
1216         * DOM/DOMHTMLHeadingElement.h:
1217         * DOM/DOMHTMLHtmlElement.h:
1218         * DOM/DOMHTMLIFrameElement.h:
1219         * DOM/DOMHTMLImageElement.h:
1220         * DOM/DOMHTMLInputElement.h:
1221         * DOM/DOMHTMLLIElement.h:
1222         * DOM/DOMHTMLLabelElement.h:
1223         * DOM/DOMHTMLLegendElement.h:
1224         * DOM/DOMHTMLLinkElement.h:
1225         * DOM/DOMHTMLMapElement.h:
1226         * DOM/DOMHTMLMarqueeElement.h:
1227         * DOM/DOMHTMLMediaElement.h:
1228         * DOM/DOMHTMLMenuElement.h:
1229         * DOM/DOMHTMLMetaElement.h:
1230         * DOM/DOMHTMLModElement.h:
1231         * DOM/DOMHTMLOListElement.h:
1232         * DOM/DOMHTMLObjectElement.h:
1233         * DOM/DOMHTMLOptGroupElement.h:
1234         * DOM/DOMHTMLOptionElement.h:
1235         * DOM/DOMHTMLOptionsCollection.h:
1236         * DOM/DOMHTMLParagraphElement.h:
1237         * DOM/DOMHTMLParamElement.h:
1238         * DOM/DOMHTMLPreElement.h:
1239         * DOM/DOMHTMLQuoteElement.h:
1240         * DOM/DOMHTMLScriptElement.h:
1241         * DOM/DOMHTMLSelectElement.h:
1242         * DOM/DOMHTMLStyleElement.h:
1243         * DOM/DOMHTMLTableCaptionElement.h:
1244         * DOM/DOMHTMLTableCellElement.h:
1245         * DOM/DOMHTMLTableColElement.h:
1246         * DOM/DOMHTMLTableElement.h:
1247         * DOM/DOMHTMLTableRowElement.h:
1248         * DOM/DOMHTMLTableSectionElement.h:
1249         * DOM/DOMHTMLTextAreaElement.h:
1250         * DOM/DOMHTMLTitleElement.h:
1251         * DOM/DOMHTMLUListElement.h:
1252         * DOM/DOMHTMLVideoElement.h:
1253         * DOM/DOMImplementation.h:
1254         * DOM/DOMKeyboardEvent.h:
1255         * DOM/DOMMediaError.h:
1256         * DOM/DOMMediaList.h:
1257         * DOM/DOMMouseEvent.h:
1258         * DOM/DOMMutationEvent.h:
1259         * DOM/DOMNamedNodeMap.h:
1260         * DOM/DOMNode.h:
1261         * DOM/DOMNodeFilter.h:
1262         * DOM/DOMNodeIterator.h:
1263         * DOM/DOMNodeList.h:
1264         * DOM/DOMObject.h:
1265         * DOM/DOMOverflowEvent.h:
1266         * DOM/DOMProcessingInstruction.h:
1267         * DOM/DOMProgressEvent.h:
1268         * DOM/DOMRGBColor.h:
1269         * DOM/DOMRange.h:
1270         * DOM/DOMRangeException.h:
1271         * DOM/DOMRect.h:
1272         * DOM/DOMStyleSheet.h:
1273         * DOM/DOMStyleSheetList.h:
1274         * DOM/DOMText.h:
1275         * DOM/DOMTextEvent.h:
1276         * DOM/DOMTimeRanges.h:
1277         * DOM/DOMTokenList.h:
1278         * DOM/DOMTreeWalker.h:
1279         * DOM/DOMUIEvent.h:
1280         * DOM/DOMWheelEvent.h:
1281         * DOM/DOMXPathException.h:
1282         * DOM/DOMXPathExpression.h:
1283         * DOM/DOMXPathNSResolver.h:
1284         * DOM/DOMXPathResult.h:
1285         * History/WebBackForwardList.h:
1286         * History/WebHistory.h:
1287         * History/WebHistoryItem.h:
1288         * Misc/WebDownload.h:
1289         * Misc/WebKitErrors.h:
1290         * Plugins/WebPluginViewFactory.h:
1291         * WebView/WebArchive.h:
1292         * WebView/WebDataSource.h:
1293         * WebView/WebDocument.h:
1294         * WebView/WebEditingDelegate.h:
1295         * WebView/WebFormDelegate.h:
1296         * WebView/WebFrame.h:
1297         * WebView/WebFrameLoadDelegate.h:
1298         * WebView/WebFrameView.h:
1299         * WebView/WebPolicyDelegate.h:
1300         * WebView/WebPreferences.h:
1301         * WebView/WebPreferencesPrivate.h:
1302         * WebView/WebResourceLoadDelegate.h:
1303         * WebView/WebUIDelegate.h:
1304         * WebView/WebUIDelegatePrivate.h:
1305         * WebView/WebView.h:
1306         * WebView/WebViewPrivate.h:
1307         * postprocess-headers.sh:
1308         Remove step that converts WEBKIT macros to NS macros.
1309         Change it to just remove the macros on iOS builds.
1310
1311 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1312
1313         [MediaStream] remove WK1 support
1314         https://bugs.webkit.org/show_bug.cgi?id=185136
1315
1316         Reviewed by Youenn Fablet.
1317
1318         * WebCoreSupport/WebUserMediaClient.h: Removed.
1319         * WebCoreSupport/WebUserMediaClient.mm: Removed.
1320         * WebView/WebView.mm:
1321         (-[WebView _commonInitializationWithFrameName:groupName:]):
1322         (-[WebView _preferencesChanged:]):
1323         (-[WebView _setUserMediaClient:]): Deleted.
1324         (-[WebView _userMediaClient]): Deleted.
1325         * WebView/WebViewData.h:
1326         * WebView/WebViewPrivate.h:
1327
1328 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1329
1330         WebAssembly: add support for stream APIs - JavaScript API
1331         https://bugs.webkit.org/show_bug.cgi?id=183442
1332
1333         Reviewed by Yusuke Suzuki and JF Bastien.
1334
1335         Add WEBASSEMBLY_STREAMINNG_API feature flag
1336
1337         * Configurations/FeatureDefines.xcconfig:
1338
1339 2018-04-30  JF Bastien  <jfbastien@apple.com>
1340
1341         Use some C++17 features
1342         https://bugs.webkit.org/show_bug.cgi?id=185135
1343
1344         Reviewed by Alex Christensen.
1345
1346         * Configurations/WebKitLegacy.xcconfig:
1347
1348 2018-04-27  Chris Dumez  <cdumez@apple.com>
1349
1350         Use WindowProxy instead of DOMWindow in our IDL
1351         https://bugs.webkit.org/show_bug.cgi?id=185022
1352
1353         Reviewed by Sam Weinig.
1354
1355         * DOM/DOMAbstractView.mm:
1356         (kit):
1357         (toWindowProxy):
1358         * DOM/DOMAbstractViewInternal.h:
1359         * DOM/DOMDocument.mm:
1360         (-[DOMDocument defaultView]):
1361         (-[DOMDocument getComputedStyle:pseudoElement:]):
1362         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
1363         * DOM/DOMHTMLFrameElement.mm:
1364         (-[DOMHTMLFrameElement contentWindow]):
1365         * DOM/DOMHTMLIFrameElement.mm:
1366         (-[DOMHTMLIFrameElement contentWindow]):
1367         * DOM/DOMKeyboardEvent.mm:
1368         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
1369         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
1370         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
1371         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
1372         * DOM/DOMMouseEvent.mm:
1373         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
1374         * DOM/DOMTextEvent.mm:
1375         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
1376         * DOM/DOMUIEvent.mm:
1377         (-[DOMUIEvent view]):
1378         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
1379         * DOM/DOMWheelEvent.mm:
1380         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1381
1382 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
1383
1384         Implement rendering support for the color-filter CSS property
1385         https://bugs.webkit.org/show_bug.cgi?id=185047
1386         rdar://problem/39664967
1387
1388         Reviewed by Tim Horton.
1389         
1390         The body background should reflect the filtered color.
1391
1392         * WebView/WebFrame.mm:
1393         (-[WebFrame _bodyBackgroundColor]):
1394         * WebView/WebView.mm:
1395         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
1396
1397 2018-04-26  Jer Noble  <jer.noble@apple.com>
1398
1399         WK_COCOA_TOUCH all the things.
1400         https://bugs.webkit.org/show_bug.cgi?id=185006
1401
1402         Reviewed by Tim Horton.
1403
1404         * Configurations/WebKitLegacy.xcconfig:
1405
1406 2018-04-26  Daniel Bates  <dabates@apple.com>
1407
1408         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
1409         https://bugs.webkit.org/show_bug.cgi?id=184161
1410         <rdar://problem/39051645>
1411
1412         Reviewed by Dan Bernstein.
1413
1414         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
1415         dropping a PDF embedded using an HTML image element into the same web view.
1416
1417         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
1418         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
1419         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
1420         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
1421         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
1422         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
1423         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
1424         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
1425         image document when navigated to directly. Since we can support dragging PDF document images we need to
1426         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
1427         We need to do both such queries before falling back to using the main resource of the Web Archive as
1428         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
1429         not an image document.
1430
1431         * Misc/WebNSPasteboardExtras.mm:
1432         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1433
1434 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1435
1436         Disable content filtering in minimal simulator mode
1437         https://bugs.webkit.org/show_bug.cgi?id=185027
1438         <rdar://problem/39736091>
1439
1440         Reviewed by Jer Noble.
1441
1442         * Configurations/FeatureDefines.xcconfig:
1443
1444 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1445
1446         [INTL] Implement Intl.PluralRules
1447         https://bugs.webkit.org/show_bug.cgi?id=184312
1448
1449         Reviewed by JF Bastien.
1450
1451         Added Intl.PluralRules feature flag.
1452
1453         * Configurations/FeatureDefines.xcconfig:
1454
1455 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1456
1457         Remove access to keychain from the WebContent process
1458         https://bugs.webkit.org/show_bug.cgi?id=184428
1459         <rdar://problem/13150903>
1460
1461         Reviewed by Brent Fulgham.
1462
1463         This patch does the followings:
1464         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
1465         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
1466         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
1467
1468         * WebCoreSupport/WebChromeClient.h:
1469         * WebCoreSupport/WebChromeClient.mm:
1470         (WebChromeClient::signedPublicKeyAndChallengeString const):
1471         * WebView/WebUIDelegatePrivate.h:
1472
1473 2018-04-24  Jer Noble  <jer.noble@apple.com>
1474
1475         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
1476         https://bugs.webkit.org/show_bug.cgi?id=184786
1477
1478         Reviewed by Tim Horton.
1479
1480         * Configurations/WebKitLegacy.xcconfig:
1481         * MigrateHeaders.make:
1482
1483 2018-04-23  Daniel Bates  <dabates@apple.com>
1484
1485         Implement Same-Site cookies
1486         https://bugs.webkit.org/show_bug.cgi?id=159464
1487         <rdar://problem/27196358>
1488
1489         Reviewed by Brent Fulgham.
1490
1491         Pass the Same-Site info through the strategy.
1492
1493         * WebCoreSupport/WebPlatformStrategies.h:
1494         * WebCoreSupport/WebPlatformStrategies.mm:
1495         (WebPlatformStrategies::cookiesForDOM):
1496         (WebPlatformStrategies::setCookiesFromDOM):
1497         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1498         (WebPlatformStrategies::getRawCookies):
1499
1500 2018-04-23  Zalan Bujtas  <zalan@apple.com>
1501
1502         [LayoutFormattingContext] Initial commit.
1503         https://bugs.webkit.org/show_bug.cgi?id=184896
1504
1505         Reviewed by Antti Koivisto.
1506
1507         * Configurations/FeatureDefines.xcconfig:
1508
1509 2018-04-23  Daniel Bates  <dabates@apple.com>
1510
1511         Implement Same-Site cookies
1512         https://bugs.webkit.org/show_bug.cgi?id=159464
1513         <rdar://problem/27196358>
1514
1515         Reviewed by Brent Fulgham.
1516
1517         Pass the Same-Site info through the strategy.
1518
1519         * WebCoreSupport/WebPlatformStrategies.h:
1520         * WebCoreSupport/WebPlatformStrategies.mm:
1521         (WebPlatformStrategies::cookiesForDOM):
1522         (WebPlatformStrategies::setCookiesFromDOM):
1523         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1524         (WebPlatformStrategies::getRawCookies):
1525
1526 2018-04-20  Timothy Hatcher  <timothy@apple.com>
1527
1528         NULL dereference crash sometimes under [super initWithCoder:] in WebView
1529
1530         https://bugs.webkit.org/show_bug.cgi?id=184851
1531         rdar://problem/39611236
1532
1533         Reviewed by Tim Horton.
1534
1535         * WebView/WebView.mm:
1536         (-[WebView _commonInitializationWithFrameName:groupName:]):
1537         (-[WebView effectiveAppearanceDidChange]):
1538         Added a null check and call the code later in initialization.
1539
1540 2018-04-20  Tim Horton  <timothy_horton@apple.com>
1541
1542         Adjust geolocation feature flag
1543         https://bugs.webkit.org/show_bug.cgi?id=184856
1544
1545         Reviewed by Wenson Hsieh.
1546
1547         * Configurations/FeatureDefines.xcconfig:
1548
1549 2018-04-18  Jer Noble  <jer.noble@apple.com>
1550
1551         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
1552         https://bugs.webkit.org/show_bug.cgi?id=184762
1553
1554         Reviewed by Dan Bernstein.
1555
1556         * Configurations/WebKitLegacy.xcconfig:
1557
1558 2018-04-20  Youenn Fablet  <youenn@apple.com>
1559
1560         Make PluginData cache its web visible plugins
1561         https://bugs.webkit.org/show_bug.cgi?id=184421
1562
1563         Reviewed by Chris Dumez.
1564
1565         * WebCoreSupport/WebPluginInfoProvider.h:
1566         * WebCoreSupport/WebPluginInfoProvider.mm:
1567         (WebPluginInfoProvider::pluginInfo):
1568         (WebPluginInfoProvider::webVisiblePluginInfo):
1569
1570 2018-04-19  Chris Dumez  <cdumez@apple.com>
1571
1572         Rename JSDOMWindowProxy to JSWindowProxy
1573         https://bugs.webkit.org/show_bug.cgi?id=184797
1574
1575         Reviewed by Sam Weinig.
1576
1577         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1578
1579         * DOM/DOMUtility.mm:
1580         (createDOMWrapper):
1581         * WebView/WebFrame.mm:
1582         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1583
1584 2018-04-19  David Kilzer  <ddkilzer@apple.com>
1585
1586         Enable Objective-C weak references
1587         <https://webkit.org/b/184789>
1588         <rdar://problem/39571716>
1589
1590         Reviewed by Dan Bernstein.
1591
1592         * Configurations/Base.xcconfig:
1593         (CLANG_ENABLE_OBJC_WEAK): Enable.
1594
1595 2018-04-18  Chris Dumez  <cdumez@apple.com>
1596
1597         Rename WindowProxyController to WindowProxy
1598         https://bugs.webkit.org/show_bug.cgi?id=184756
1599
1600         Reviewed by Sam Weinig.
1601
1602         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
1603         needed use WindowProxyController type, which was a bit confusing.
1604
1605         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1606         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1607         * WebView/WebFrame.mm:
1608         (-[WebFrame _attachScriptDebugger]):
1609
1610 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1611
1612         Unreviewed rollout of r230632. Regression in memory usage.
1613
1614         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1615
1616         * WebView/WebPreferences.mm:
1617         (+[WebPreferences initialize]):
1618
1619 2018-04-17  Chris Dumez  <cdumez@apple.com>
1620
1621         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1622         https://bugs.webkit.org/show_bug.cgi?id=184678
1623         <rdar://problem/39422122>
1624
1625         Reviewed by Alex Christensen.
1626
1627         Add new parameter to dispatchDecidePolicyForNavigationAction.
1628
1629         * WebCoreSupport/WebFrameLoaderClient.h:
1630         * WebCoreSupport/WebFrameLoaderClient.mm:
1631         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1632
1633 2018-04-13  Chris Dumez  <cdumez@apple.com>
1634
1635         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
1636         https://bugs.webkit.org/show_bug.cgi?id=184591
1637
1638         Reviewed by Sam Weinig.
1639
1640         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
1641         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
1642         This is work towards fixing Bug 184515.
1643
1644         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1645         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1646         * WebView/WebFrame.mm:
1647         (-[WebFrame _attachScriptDebugger]):
1648
1649 2018-04-12  Antoine Quint  <graouts@apple.com>
1650
1651         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1652         https://bugs.webkit.org/show_bug.cgi?id=184569
1653         <rdar://problem/38671301>
1654
1655         Reviewed by Jon Lee.
1656
1657         * WebView/WebPreferences.mm:
1658
1659 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1660
1661         [WTF] Remove StaticLock
1662         https://bugs.webkit.org/show_bug.cgi?id=184332
1663
1664         Reviewed by Mark Lam.
1665
1666         * DOM/DOMInternal.mm:
1667         (getDOMWrapper):
1668         (addDOMWrapper):
1669         (removeDOMWrapper):
1670
1671 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
1672
1673         Failures from mach port reference handling should be fatal
1674         https://bugs.webkit.org/show_bug.cgi?id=184202
1675         <rdar://problem/37771114>
1676
1677         Reviewed by Anders Carlsson.
1678
1679         * Plugins/Hosted/NetscapePluginHostManager.mm:
1680         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
1681
1682 2018-04-03  Andy Estes  <aestes@apple.com>
1683
1684         [Mac] Prioritize file promises over filenames during drag and drop
1685         https://bugs.webkit.org/show_bug.cgi?id=184237
1686         <rdar://problem/38278076>
1687
1688         Reviewed by Wenson Hsieh.
1689
1690         * WebView/WebView.mm:
1691         (-[WebView performDragOperation:]):
1692
1693 2018-04-03  Chris Dumez  <cdumez@apple.com>
1694
1695         Drop MainFrame class
1696         https://bugs.webkit.org/show_bug.cgi?id=184191
1697
1698         Reviewed by Darin Adler.
1699
1700         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1701         relationship between the Page and the MainFrame.
1702
1703         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1704
1705         * WebCoreSupport/WebDragClient.mm:
1706         * WebCoreSupport/WebFrameLoaderClient.mm:
1707         * WebCoreSupport/WebInspectorClient.mm:
1708         * WebCoreSupport/WebPlatformStrategies.mm:
1709         * WebCoreSupport/WebPluginInfoProvider.mm:
1710         * WebView/WebFrame.mm:
1711         * WebView/WebFrameView.mm:
1712         * WebView/WebHTMLView.mm:
1713         * WebView/WebView.mm:
1714
1715 2018-04-02  Jer Noble  <jer.noble@apple.com>
1716
1717         Enable Legacy EME for all WebKit & WebKitLegacy clients
1718         https://bugs.webkit.org/show_bug.cgi?id=184018
1719         <rdar://problem/34887387>
1720
1721         Reviewed by Eric Carlson.
1722
1723         * WebView/WebPreferences.mm:
1724         (+[WebPreferences initialize]):
1725
1726 2018-03-29  JF Bastien  <jfbastien@apple.com>
1727
1728         Use Forward.h instead of forward-declaring WTF::String
1729         https://bugs.webkit.org/show_bug.cgi?id=184172
1730         <rdar://problem/39026146>
1731
1732         Reviewed by Yusuke Suzuki.
1733
1734         As part of #184164 I'm changing WTF::String, and the forward
1735         declarations are just wrong because I'm making it templated. We
1736         should use Forward.h anyways, so do that instead.
1737
1738         * WebView/WebScriptDebugger.h:
1739
1740 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
1741
1742         Protect against invalid mach ports returned by mach_port_request_notification
1743         https://bugs.webkit.org/show_bug.cgi?id=184106
1744         <rdar://problem/37865316>
1745
1746         Reviewed by Chris Dumez.
1747
1748         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1749         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
1750         and clean up if it experienced an error.
1751         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
1752
1753 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
1754
1755         Avoid uninitialized mach ports
1756         https://bugs.webkit.org/show_bug.cgi?id=184090
1757         <rdar://problem/37261129>
1758
1759         Reviewed by Chris Dumez.
1760
1761         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
1762         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
1763         there is a potential for us to try to use invalid ports.
1764
1765         We should always check return values, and ensure that the mach port variables we seek to initialize are
1766         kept in a valid state.
1767
1768         Reviewed by Chris Dumez.
1769
1770         * Plugins/Hosted/NetscapePluginHostManager.h:
1771         * Plugins/Hosted/NetscapePluginHostManager.mm:
1772         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
1773         port is passed to an API function.
1774         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
1775         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
1776         * Plugins/Hosted/NetscapePluginHostProxy.h:
1777         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1778         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
1779         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1780         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
1781         (WKPCStatusText): Ditto.
1782         (WKPCLoadURL): Ditto.
1783         (WKPCCancelLoadURL): Ditto.
1784         (WKPCInvalidateRect): Ditto.
1785         (WKPCGetScriptableNPObjectReply): Ditto.
1786         (WKPCBooleanReply): Ditto.
1787         (WKPCBooleanAndDataReply): Ditto.
1788         (WKPCInstantiatePluginReply): Ditto.
1789         (WKPCGetWindowNPObject): Ditto.
1790         (WKPCGetPluginElementNPObject): Ditto.
1791         (WKPCForgetBrowserObject): Ditto.
1792         (WKPCEvaluate): Ditto.
1793         (WKPCGetStringIdentifier): Ditto.
1794         (WKPCGetIntIdentifier): Ditto.
1795         (WKPCInvoke): Ditto.
1796         (WKPCInvokeDefault): Ditto.
1797         (WKPCConstruct): Ditto.
1798         (WKPCGetProperty): Ditto.
1799         (WKPCSetProperty): Ditto.
1800         (WKPCRemoveProperty): Ditto.
1801         (WKPCHasProperty): Ditto.
1802         (WKPCHasMethod): Ditto.
1803         (WKPCIdentifierInfo): Ditto.
1804         (WKPCEnumerate): Ditto.
1805         (WKPCSetMenuBarVisible): Ditto.
1806         (WKPCSetFullscreenWindowIsShowing): Ditto.
1807         (WKPCSetModal): Ditto.
1808         (WKPCGetCookies): Ditto.
1809         (WKPCGetProxy): Ditto.
1810         (WKPCSetCookies): Ditto.
1811         (WKPCGetAuthenticationInfo): Ditto.
1812         (WKPCConvertPoint): Ditto.
1813         (WKPCLayerHostingModeChanged): Ditto.
1814         (WKPCSetException): Ditto.
1815
1816 2018-03-26  Tim Horton  <timothy_horton@apple.com>
1817
1818         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
1819         https://bugs.webkit.org/show_bug.cgi?id=184030
1820         <rdar://problem/38895281>
1821
1822         Reviewed by Dan Bernstein.
1823
1824         * Configurations/Base.xcconfig:
1825
1826 2018-03-26  Chris Dumez  <cdumez@apple.com>
1827
1828         Use SecurityOriginData more consistently in Service Worker code
1829         https://bugs.webkit.org/show_bug.cgi?id=183969
1830
1831         Reviewed by Darin Adler.
1832
1833         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1834
1835         * Storage/WebDatabaseManager.mm:
1836         (-[WebDatabaseManager databasesWithOrigin:]):
1837         (-[WebDatabaseManager deleteOrigin:]):
1838         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1839         * Storage/WebDatabaseQuotaManager.mm:
1840         (-[WebDatabaseQuotaManager usage]):
1841         (-[WebDatabaseQuotaManager quota]):
1842         (-[WebDatabaseQuotaManager setQuota:]):
1843         * Storage/WebStorageManager.mm:
1844         (-[WebStorageManager deleteOrigin:]):
1845         * WebCoreSupport/WebSecurityOrigin.mm:
1846         (-[WebSecurityOrigin databaseIdentifier]):
1847         (-[WebSecurityOrigin usage]):
1848         (-[WebSecurityOrigin quota]):
1849         (-[WebSecurityOrigin setQuota:]):
1850
1851 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1852
1853         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1854         https://bugs.webkit.org/show_bug.cgi?id=183911
1855         <rdar://problem/38762306>
1856
1857         Reviewed by Youenn Fablet.
1858
1859         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1860
1861         * WebView/WebView.mm:
1862         (+[WebView initialize]):
1863
1864 2018-03-26  Alex Christensen  <achristensen@webkit.org>
1865
1866         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
1867         https://bugs.webkit.org/show_bug.cgi?id=183965
1868
1869         Reviewed by Chris Dumez.
1870
1871         * WebCoreSupport/WebFrameLoaderClient.h:
1872         * WebCoreSupport/WebFrameLoaderClient.mm:
1873         (WebFrameLoaderClient::willCacheResponse const):
1874
1875 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1876
1877         Unreviewed, rolling out r229954.
1878         https://bugs.webkit.org/show_bug.cgi?id=184000
1879
1880         Caused many layout tests to crash on Apple High Sierra,
1881         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1882         by dydz on #webkit).
1883
1884         Reverted changeset:
1885
1886         "Use SecurityOriginData more consistently in Service Worker
1887         code"
1888         https://bugs.webkit.org/show_bug.cgi?id=183969
1889         https://trac.webkit.org/changeset/229954
1890
1891 2018-03-24  Chris Dumez  <cdumez@apple.com>
1892
1893         Use SecurityOriginData more consistently in Service Worker code
1894         https://bugs.webkit.org/show_bug.cgi?id=183969
1895
1896         Reviewed by Darin Adler.
1897
1898         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1899
1900         * Storage/WebDatabaseManager.mm:
1901         (-[WebDatabaseManager databasesWithOrigin:]):
1902         (-[WebDatabaseManager deleteOrigin:]):
1903         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1904         * Storage/WebDatabaseQuotaManager.mm:
1905         (-[WebDatabaseQuotaManager usage]):
1906         (-[WebDatabaseQuotaManager quota]):
1907         (-[WebDatabaseQuotaManager setQuota:]):
1908         * Storage/WebStorageManager.mm:
1909         (-[WebStorageManager deleteOrigin:]):
1910         * WebCoreSupport/WebSecurityOrigin.mm:
1911         (-[WebSecurityOrigin databaseIdentifier]):
1912         (-[WebSecurityOrigin usage]):
1913         (-[WebSecurityOrigin quota]):
1914         (-[WebSecurityOrigin setQuota:]):
1915
1916 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
1917
1918         Fix the build
1919
1920         * WebView/WebView.mm:
1921
1922 2018-03-23  Tim Horton  <timothy_horton@apple.com>
1923
1924         Fix the build with no pasteboard
1925         https://bugs.webkit.org/show_bug.cgi?id=183973
1926
1927         Reviewed by Dan Bernstein.
1928
1929         * Configurations/FeatureDefines.xcconfig:
1930         * WebView/WebView.mm:
1931         (-[WebView _requestStartDataInteraction:globalPosition:]):
1932         (-[WebView _getDataInteractionData]):
1933         (-[WebView _dataOperationTextIndicator]):
1934         (-[WebView _dragSourceAction]):
1935         (-[WebView _draggedLinkTitle]):
1936         (-[WebView _draggedLinkURL]):
1937         (-[WebView _draggedElementBounds]):
1938         (-[WebView _enteredDataInteraction:client:global:operation:]):
1939         (-[WebView _updatedDataInteraction:client:global:operation:]):
1940         (-[WebView _exitedDataInteraction:client:global:operation:]):
1941         (-[WebView _performDataInteraction:client:global:operation:]):
1942         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1943         (-[WebView _endedDataInteraction:global:]):
1944         (-[WebView _dataInteractionCaretRect]):
1945         * WebView/WebViewPrivate.h:
1946
1947 2018-03-23  Tim Horton  <timothy_horton@apple.com>
1948
1949         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
1950         https://bugs.webkit.org/show_bug.cgi?id=183960
1951         <rdar://problem/38812356>
1952
1953         Reviewed by Dan Bernstein.
1954
1955         * Configurations/WebKitLegacy.xcconfig:
1956
1957 2018-03-23  Tim Horton  <timothy_horton@apple.com>
1958
1959         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
1960         https://bugs.webkit.org/show_bug.cgi?id=183954
1961         <rdar://problem/38808858>
1962
1963         Reviewed by Dan Bernstein.
1964
1965         * WebView/WebPreferences.mm:
1966         (-[WebPreferences setAudioSessionCategoryOverride:]):
1967
1968 2018-03-23  Tim Horton  <timothy_horton@apple.com>
1969
1970         Adopt WK_PLATFORM_NAME in WebKitLegacy
1971         https://bugs.webkit.org/show_bug.cgi?id=183948
1972         <rdar://problem/38803908>
1973
1974         Reviewed by Dan Bernstein.
1975
1976         * Configurations/WebKitLegacy.xcconfig:
1977         * MigrateHeaders.make:
1978         * postprocess-headers.sh:
1979
1980 2018-03-23  Brady Eidson  <beidson@apple.com>
1981
1982         Go to back/forward list items after a process-swapped navigation.
1983         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1984
1985         Reviewed by Andy Estes.
1986
1987         * WebView/WebView.mm:
1988         (-[WebView _loadBackForwardListFromOtherView:]):
1989         (-[WebView goToBackForwardItem:]):
1990
1991 2018-03-22  Tim Horton  <timothy_horton@apple.com>
1992
1993         Improve readability of WebCore's OTHER_LDFLAGS
1994         https://bugs.webkit.org/show_bug.cgi?id=183909
1995         <rdar://problem/38760992>
1996
1997         Reviewed by Dan Bernstein.
1998
1999         * Configurations/Base.xcconfig:
2000         * Configurations/FeatureDefines.xcconfig:
2001
2002 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2003
2004         Enable the minimal simulator feature flag when appropriate
2005         https://bugs.webkit.org/show_bug.cgi?id=183807
2006
2007         Reviewed by Dan Bernstein.
2008
2009         * Configurations/FeatureDefines.xcconfig:
2010
2011 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2012
2013         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
2014         https://bugs.webkit.org/show_bug.cgi?id=183758
2015         <rdar://problem/38017644>
2016
2017         Reviewed by Dan Bernstein.
2018
2019         * Configurations/FeatureDefines.xcconfig:
2020
2021 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
2022
2023         Clear style colors when setting default appearance
2024         https://bugs.webkit.org/show_bug.cgi?id=183759
2025
2026         Reviewed by Tim Horton.
2027
2028         Colors are cached and need to be cleared and recalculated.
2029         Refactor to do all style recalcs together.
2030
2031         * WebView/WebView.mm:
2032         (-[WebView _setDefaultAppearanceAndClearStyle]):
2033         (-[WebView _setUseSystemAppearance:]):
2034         (-[WebView effectiveAppearanceDidChange]):
2035
2036 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2037
2038         Unreviewed, another quick fix for r229699
2039
2040         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
2041
2042         * Configurations/FeatureDefines.xcconfig:
2043
2044 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
2045
2046         Ensure that style is updated when the effective appearance changes
2047         https://bugs.webkit.org/show_bug.cgi?id=183690
2048         <rdar://problem/38385900>
2049
2050         Reviewed by Tim Horton and Wenson Hsieh.
2051
2052         Respond to and respect the effective appearance changing.
2053
2054         * WebView/WebView.mm:
2055         (-[WebView _setUseSystemAppearance:]):
2056         (-[WebView effectiveAppearanceDidChange]):
2057
2058 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
2059
2060         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
2061         https://bugs.webkit.org/show_bug.cgi?id=183677
2062
2063         Reviewed by Tim Horton.
2064
2065         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
2066
2067         * DOM/DOM.mm:
2068         (-[DOMHTMLLinkElement _mediaQueryMatches]):
2069
2070 2018-03-14  Tim Horton  <timothy_horton@apple.com>
2071
2072         Fix the build after r229567
2073
2074         * Configurations/FeatureDefines.xcconfig:
2075
2076 2018-03-12  Tim Horton  <timothy_horton@apple.com>
2077
2078         Stop using SDK conditionals to control feature definitions
2079         https://bugs.webkit.org/show_bug.cgi?id=183430
2080         <rdar://problem/38251619>
2081
2082         Reviewed by Dan Bernstein.
2083
2084         * Configurations/FeatureDefines.xcconfig:
2085         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
2086
2087 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
2088
2089         Runtime flag for link prefetch and remove link subresource.
2090         https://bugs.webkit.org/show_bug.cgi?id=183540
2091
2092         Reviewed by Chris Dumez.
2093
2094         Remove the LINK_PREFETCH build time flag.
2095
2096         * Configurations/FeatureDefines.xcconfig:
2097
2098 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
2099
2100         Remove GridLayout runtime flag
2101         https://bugs.webkit.org/show_bug.cgi?id=183484
2102
2103         Reviewed by Myles C. Maxfield.
2104
2105         The Grid Layout feature has been enabled by default for almost a
2106         year, so I think it's time to remove the runtime flag and the
2107
2108         * WebView/WebPreferenceKeysPrivate.h:
2109         * WebView/WebPreferences.mm:
2110         (+[WebPreferences initialize]):
2111         * WebView/WebPreferencesPrivate.h:
2112         * WebView/WebView.mm:
2113         (-[WebView _preferencesChanged:]):
2114
2115 2018-03-12  Antoine Quint  <graouts@apple.com>
2116
2117         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2118         https://bugs.webkit.org/show_bug.cgi?id=183504
2119         <rdar://problem/38372965>
2120
2121         Reviewed by Dean Jackson and Jon Lee.
2122
2123         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2124         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2125
2126         * WebView/WebPreferenceKeysPrivate.h:
2127         * WebView/WebPreferences.mm:
2128         (+[WebPreferences initialize]):
2129         (-[WebPreferences setModernMediaControlsEnabled:]):
2130         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
2131         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
2132         * WebView/WebPreferencesPrivate.h:
2133         * WebView/WebView.mm:
2134         (-[WebView _preferencesChanged:]):
2135
2136 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
2137
2138         Media query for default appearance
2139         https://bugs.webkit.org/show_bug.cgi?id=183539
2140         <rdar://problem/38326388>
2141
2142         Reviewed by Tim Horton.
2143
2144         Write a media query to evaluate appearance.
2145
2146         * WebView/WebView.mm:
2147         (-[WebView _commonInitializationWithFrameName:groupName:]):
2148         (-[WebView _setUseSystemAppearance:]):
2149
2150 2018-03-09  Andy Estes  <aestes@apple.com>
2151
2152         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
2153         https://bugs.webkit.org/show_bug.cgi?id=183489
2154         <rdar://problem/38267517>
2155
2156         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
2157         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
2158         to issue a sandbox extension for this directory, but for security reasons App Sandbox
2159         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
2160         block with a nil error and a valid file URL, but no file will actually exist at that URL.
2161
2162         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
2163         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
2164         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
2165         drop destination.
2166
2167         Reviewed by Wenson Hsieh.
2168
2169         * WebView/WebView.mm:
2170         (-[WebView performDragOperation:]):
2171
2172 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
2173
2174         Allow WebViews to disable system appearance
2175         https://bugs.webkit.org/show_bug.cgi?id=183418
2176         <rdar://problem/36975642>
2177
2178         Reviewed by Tim Horton.
2179
2180         Allow webviews to choose whether or not to follow the default system appearance.
2181
2182         * WebView/WebView.mm:
2183         (-[WebView _setUseSystemAppearance:]):
2184         (-[WebView _useSystemAppearance]):
2185         * WebView/WebViewPrivate.h:
2186
2187 2018-03-08  Youenn Fablet  <youenn@apple.com>
2188
2189         libwebrtc update broke internal builds
2190         https://bugs.webkit.org/show_bug.cgi?id=183454
2191
2192         Reviewed by Eric Carlson.
2193
2194         * Configurations/WebKitLegacy.xcconfig:
2195
2196 2018-03-08  Chris Dumez  <cdumez@apple.com>
2197
2198         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
2199         https://bugs.webkit.org/show_bug.cgi?id=183455
2200         <rdar://problem/38191749>
2201
2202         Reviewed by Youenn Fablet.
2203
2204         Add a null check for the page as we have evidence from crashes that it can be null.
2205         Other functions in WebFrameNetworkingContext already null check the page as well,
2206         not just the frame so this is consistent.
2207
2208         * WebCoreSupport/WebFrameNetworkingContext.mm:
2209         (WebFrameNetworkingContext::storageSession const):
2210
2211 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2212
2213         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2214         https://bugs.webkit.org/show_bug.cgi?id=183429
2215
2216         Reviewed by Mark Lam.
2217
2218         * DOM/DOM.mm:
2219         (+[DOMNode _nodeFromJSWrapper:]):
2220         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2221         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
2222         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
2223         * Plugins/Hosted/ProxyInstance.mm:
2224         (WebKit::ProxyInstance::invokeMethod):
2225         * WebView/WebView.mm:
2226         (aeDescFromJSValue):
2227
2228 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2229
2230         Stop linking ApplicationServices directly
2231         https://bugs.webkit.org/show_bug.cgi?id=182867
2232         <rdar://problem/38252142>
2233
2234         Reviewed by Alex Christensen.
2235
2236         The frameworks that we use that live inside ApplicationServices
2237         have mostly moved out, so import them directly.
2238
2239         * Carbon/CarbonUtils.h:
2240         * WebKitPrefix.h:
2241         * WebView/WebHTMLView.mm:
2242         * WebView/WebPDFView.mm:
2243
2244 2018-03-07  Tim Horton  <timothy_horton@apple.com>
2245
2246         Sort and separate FeatureDefines.xcconfig
2247         https://bugs.webkit.org/show_bug.cgi?id=183427
2248
2249         Reviewed by Dan Bernstein.
2250
2251         * Configurations/FeatureDefines.xcconfig:
2252         Sort and split FeatureDefines into paragraphs
2253         (to make it easier to sort later).
2254
2255 2018-03-07  Youenn Fablet  <youenn@apple.com>
2256
2257         Match unsupported plugins based on domains and not origin
2258         https://bugs.webkit.org/show_bug.cgi?id=183384
2259
2260         Reviewed by Chris Dumez.
2261
2262         * WebCoreSupport/WebPluginInfoProvider.h:
2263         * WebCoreSupport/WebPluginInfoProvider.mm:
2264         (WebPluginInfoProvider::getPluginInfo):
2265         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2266
2267 2018-03-05  Andy Estes  <aestes@apple.com>
2268
2269         [Mac] Teach WebCore::Pasteboard about file promise drags
2270         https://bugs.webkit.org/show_bug.cgi?id=183314
2271         <rdar://problem/38105493>
2272
2273         Reviewed by Darin Adler.
2274
2275         Added a FIXME comment.
2276
2277         * WebView/WebView.mm:
2278         (-[WebView performDragOperation:]):
2279
2280 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2281
2282         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2283         https://bugs.webkit.org/show_bug.cgi?id=183312
2284
2285         Reviewed by Mark Lam.
2286
2287         Remove wtf/CurrentTime.h include pragma.
2288
2289         * WebView/WebFrame.mm:
2290         * WebView/WebPDFView.mm:
2291
2292 2018-03-04  Tim Horton  <timothy_horton@apple.com>
2293
2294         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
2295         https://bugs.webkit.org/show_bug.cgi?id=183283
2296         <rdar://problem/38062148>
2297
2298         Reviewed by Sam Weinig.
2299
2300         * Configurations/FeatureDefines.xcconfig:
2301
2302 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2303
2304         Reduce use of NetworkingContext in WebKit
2305         https://bugs.webkit.org/show_bug.cgi?id=183213
2306
2307         Reviewed by Brady Eidson.
2308
2309         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2310         (WebKit::NetscapePluginInstanceProxy::getProxy):
2311         * Plugins/WebNetscapePluginView.mm:
2312         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2313
2314 2018-02-17  Darin Adler  <darin@apple.com>
2315
2316         Prepare for ExtendedColor changes (first step)
2317         https://bugs.webkit.org/show_bug.cgi?id=182904
2318
2319         Reviewed by Sam Weinig.
2320
2321         * Misc/WebKitNSStringExtras.mm:
2322         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
2323
2324 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2325
2326         Remove currentTime() / currentTimeMS()
2327         https://bugs.webkit.org/show_bug.cgi?id=183052
2328
2329         Reviewed by Mark Lam.
2330
2331         * WebCoreSupport/WebFrameLoaderClient.h:
2332         * WebCoreSupport/WebFrameLoaderClient.mm:
2333         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2334
2335 2018-02-16  Youenn Fablet  <youenn@apple.com>
2336
2337         Allow specifying which plug-ins are supported
2338         https://bugs.webkit.org/show_bug.cgi?id=182748
2339
2340         Reviewed by Chris Dumez.
2341
2342         * WebCoreSupport/WebPluginInfoProvider.h:
2343         * WebCoreSupport/WebPluginInfoProvider.mm:
2344         (WebPluginInfoProvider::getPluginInfo):
2345         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2346
2347 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
2348
2349         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
2350         https://bugs.webkit.org/show_bug.cgi?id=182882
2351         <rdar://problem/35672661>
2352
2353         Reviewed by Dan Bernstein.
2354
2355         Make sure the smart pointer hold the collection of subviews lives at least as
2356         long as the loop using it.
2357
2358         * WebView/WebHTMLView.mm:
2359         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
2360
2361 2018-02-14  Daniel Bates  <dabates@apple.com>
2362
2363         Disallow cross-origin subresources from asking for credentials
2364         https://bugs.webkit.org/show_bug.cgi?id=182579
2365         <rdar://problem/36162271>
2366
2367         Reviewed by Andy Estes.
2368
2369         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
2370         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
2371
2372         * WebView/WebPreferenceKeysPrivate.h:
2373         * WebView/WebPreferences.mm:
2374         (+[WebPreferences initialize]):
2375         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
2376         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
2377         * WebView/WebPreferencesPrivate.h:
2378         * WebView/WebView.mm:
2379         (-[WebView _preferencesChanged:]):
2380
2381 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2382
2383         Remove ForwardingHeaders directory from WebKitLegacy/mac.
2384         https://bugs.webkit.org/show_bug.cgi?id=182738
2385
2386         Reviewed by Darin Adler.
2387
2388         * ForwardingHeaders/collector/handles/Global.h: Removed.
2389         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
2390         * ForwardingHeaders/runtime/Completion.h: Removed.
2391         * ForwardingHeaders/runtime/Error.h: Removed.
2392         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
2393         * ForwardingHeaders/runtime/JSFunction.h: Removed.
2394         * ForwardingHeaders/runtime/JSLock.h: Removed.
2395         * ForwardingHeaders/runtime/JSObject.h: Removed.
2396         * ForwardingHeaders/runtime/JSString.h: Removed.
2397         * ForwardingHeaders/runtime/Protect.h: Removed.
2398         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
2399
2400 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
2401
2402         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
2403         https://bugs.webkit.org/show_bug.cgi?id=182641
2404
2405         Reviewed by Dan Bernstein.
2406
2407         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
2408         https://trac.webkit.org/changeset/228308.
2409
2410         * WebView/WebVideoFullscreenController.h:
2411         * WebView/WebVideoFullscreenHUDWindowController.mm:
2412         * WebView/WebWindowAnimation.h:
2413         * WebView/WebWindowAnimation.mm:
2414         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
2415         (WebCore::scaledRect): Deleted.
2416         (WebCore::squaredDistance): Deleted.
2417
2418 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
2419
2420         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
2421
2422         * WebView/WebWindowAnimation.mm:
2423         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
2424
2425 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
2426
2427         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
2428         https://bugs.webkit.org/show_bug.cgi?id=182615
2429
2430         Reviewed by Eric Carlson.
2431
2432         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
2433         Ideally, we should not reference NSApp in WebCore.
2434
2435         * WebView/WebFullScreenController.mm:
2436         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
2437         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
2438         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
2439         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
2440         * WebView/WebView.mm:
2441         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
2442         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
2443
2444 2018-01-13  Darin Adler  <darin@apple.com>
2445
2446         Event improvements
2447         https://bugs.webkit.org/show_bug.cgi?id=179591
2448
2449         Reviewed by Chris Dumez.
2450
2451         * DOM/DOMWheelEvent.mm:
2452         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2453         Call initWebKitWheelEvent.
2454
2455         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
2456         * WebCoreSupport/WebInspectorClient.mm: Ditto.
2457         * WebView/WebFrame.mm: Ditto.
2458
2459         * WebView/WebHTMLView.mm:
2460         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
2461         underlyingPlatformEvent.
2462         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
2463
2464         * WebView/WebScriptWorld.mm:
2465         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
2466
2467         * WebView/WebView.mm: Removed include of ScriptValue.h.
2468
2469 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2470
2471         Remove WebCore/ForwardingHeaders directory
2472         https://bugs.webkit.org/show_bug.cgi?id=182347
2473
2474         Reviewed by Keith Miller.
2475
2476         * Carbon/CarbonWindowAdapter.mm:
2477         * DOM/WebDOMOperations.mm:
2478         * History/WebBackForwardList.mm:
2479         * History/WebHistoryItem.mm:
2480         * Misc/WebCache.mm:
2481         * Misc/WebElementDictionary.mm:
2482         * Misc/WebIconDatabase.mm:
2483         * Misc/WebStringTruncator.mm:
2484         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2485         * Plugins/Hosted/ProxyInstance.mm:
2486         * Plugins/Hosted/ProxyRuntimeObject.mm:
2487         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2488         * Plugins/WebBaseNetscapePluginView.mm:
2489         * Plugins/WebBasePluginPackage.mm:
2490         * Plugins/WebNetscapePluginStream.mm:
2491         * Plugins/WebNetscapePluginView.mm:
2492         * Plugins/WebPluginController.mm:
2493         * WebCoreSupport/WebEditorClient.mm:
2494         * WebCoreSupport/WebFrameLoaderClient.mm:
2495         * WebCoreSupport/WebInspectorClient.h:
2496         * WebCoreSupport/WebInspectorClient.mm:
2497         * WebView/WebDataSource.mm:
2498         * WebView/WebFrame.mm:
2499         * WebView/WebHTMLRepresentation.mm:
2500         * WebView/WebHTMLView.mm:
2501         * WebView/WebPreferences.mm:
2502         * WebView/WebScriptDebugDelegate.mm:
2503         * WebView/WebScriptDebugger.h:
2504         * WebView/WebTextIterator.mm:
2505         * WebView/WebView.mm:
2506         * WebView/WebViewData.mm:
2507
2508 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
2509
2510         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
2511         https://bugs.webkit.org/show_bug.cgi?id=182312
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         * WebKitPrefix.h:
2516
2517 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
2518
2519         [WebAuthN] Add a compile-time feature flag
2520         https://bugs.webkit.org/show_bug.cgi?id=182211
2521         <rdar://problem/36936365>
2522
2523         Reviewed by Brent Fulgham.
2524
2525         * Configurations/FeatureDefines.xcconfig:
2526
2527 2018-01-27  Dan Bernstein  <mitz@apple.com>
2528
2529         HaveInternalSDK includes should be "#include?"
2530         https://bugs.webkit.org/show_bug.cgi?id=179670
2531
2532         * Configurations/Base.xcconfig:
2533
2534 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2535
2536         Remove unused QTKit preference
2537         https://bugs.webkit.org/show_bug.cgi?id=181968
2538
2539         Reviewed by Alexey Proskuryakov.
2540
2541         * WebView/WebPreferenceKeysPrivate.h:
2542         * WebView/WebPreferences.mm:
2543         (+[WebPreferences initialize]):
2544         (-[WebPreferences setQTKitEnabled:]): Deleted.
2545         (-[WebPreferences isQTKitEnabled]): Deleted.
2546         * WebView/WebPreferencesPrivate.h:
2547         * WebView/WebView.mm:
2548         (-[WebView _preferencesChanged:]):
2549
2550 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2551
2552         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
2553         https://bugs.webkit.org/show_bug.cgi?id=182037
2554         <rdar://problem/36747812>
2555
2556         Reviewed by Ryosuke Niwa.
2557
2558         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
2559         for more details.
2560
2561         * WebView/WebHTMLRepresentation.mm:
2562         (-[WebHTMLRepresentation elementWithName:inForm:]):
2563         (-[WebHTMLRepresentation controlsInForm:]):
2564
2565 2018-01-23  Alex Christensen  <achristensen@webkit.org>
2566
2567         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
2568         https://bugs.webkit.org/show_bug.cgi?id=181961
2569
2570         Reviewed by Michael Catanzaro.
2571
2572         * WebView/WebPreferences.mm:
2573
2574 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2575
2576         Unreviewed, rolling out r227437.
2577         https://bugs.webkit.org/show_bug.cgi?id=182011
2578
2579         broke build (Requested by alexchristensen on #webkit).
2580
2581         Reverted changeset:
2582
2583         "Remove unused QTKit preference"
2584         https://bugs.webkit.org/show_bug.cgi?id=181968
2585         https://trac.webkit.org/changeset/227437
2586
2587 2018-01-23  Alex Christensen  <achristensen@webkit.org>
2588
2589         Remove unused QTKit preference
2590         https://bugs.webkit.org/show_bug.cgi?id=181968
2591
2592         Reviewed by Alexey Proskuryakov.
2593
2594         * WebView/WebPreferenceKeysPrivate.h:
2595         * WebView/WebPreferences.mm:
2596         (+[WebPreferences initialize]):
2597         (-[WebPreferences setQTKitEnabled:]): Deleted.
2598         (-[WebPreferences isQTKitEnabled]): Deleted.
2599         * WebView/WebPreferencesPrivate.h:
2600         * WebView/WebView.mm:
2601         (-[WebView _preferencesChanged:]):
2602
2603 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2604
2605         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
2606         https://bugs.webkit.org/show_bug.cgi?id=181960
2607         <rdar://problem/36431678>
2608
2609         Reviewed by Tim Horton.
2610
2611         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
2612         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
2613         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
2614
2615         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
2616         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
2617         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
2618
2619         * WebView/WebView.mm:
2620         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2621
2622 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Turning off custom pasteboard data doesn't actually turn it off in WK2
2625         https://bugs.webkit.org/show_bug.cgi?id=181920
2626         <rdar://problem/36686429>
2627
2628         Reviewed by Wenson Hsieh.
2629
2630         Always disable custom pasteboard data in WebKit1. See r226156 for details.
2631
2632         * WebView/WebPreferences.mm:
2633         (+[WebPreferences initialize]):
2634         * WebView/WebView.mm:
2635         (-[WebView _preferencesChanged:]):
2636
2637 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2638
2639         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2640         https://bugs.webkit.org/show_bug.cgi?id=181918
2641
2642         Reviewed by Tim Horton.
2643
2644         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2645
2646         * Configurations/FeatureDefines.xcconfig:
2647
2648 2018-01-20  Andy Estes  <aestes@apple.com>
2649
2650         [Apple Pay] Stop eagerly loading PassKit.framework
2651         https://bugs.webkit.org/show_bug.cgi?id=181911
2652         <rdar://problem/36555369>
2653
2654         Reviewed by Tim Horton.
2655
2656         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2657         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2658         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
2659
2660         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
2661
2662 2018-01-19  Dean Jackson  <dino@apple.com>
2663
2664         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
2665         https://bugs.webkit.org/show_bug.cgi?id=181817
2666         <rdar://problem/35274055>
2667
2668         Reviewed by Simon Fraser.
2669
2670         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
2671
2672         * Misc/WebKitVersionChecks.h:
2673         * WebView/WebView.mm:
2674         (-[WebView _commonInitializationWithFrameName:groupName:]):
2675
2676 2018-01-19  Alex Christensen  <achristensen@webkit.org>
2677
2678         Remove unused WebViewPrivate _allowCookies
2679         https://bugs.webkit.org/show_bug.cgi?id=181812
2680
2681         Reviewed by Tim Horton.
2682
2683         * WebView/WebView.mm:
2684         (+[WebView _setAllowCookies:]): Deleted.
2685         (+[WebView _allowCookies]): Deleted.
2686         * WebView/WebViewPrivate.h:
2687
2688 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
2689
2690         Build fix, remove a call to -[NSWindow setOneShot:]
2691         https://bugs.webkit.org/show_bug.cgi?id=181809
2692
2693         Reviewed by Tim Horton.
2694
2695         * WebView/WebTextCompletionController.mm:
2696         (-[WebTextCompletionController _buildUI]):
2697
2698 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2699
2700         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
2701
2702         * Carbon/HIWebView.mm:
2703         (overrideCGContext):
2704         (restoreCGContext):
2705
2706 2018-01-18  Dan Bernstein  <mitz@apple.com>
2707
2708         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2709         https://bugs.webkit.org/show_bug.cgi?id=181803
2710
2711         Reviewed by Tim Horton.
2712
2713         * Configurations/Base.xcconfig: Updated.
2714         * Configurations/DebugRelease.xcconfig: Ditto.
2715         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
2716         * Configurations/Version.xcconfig: Updated.
2717         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
2718           useful for defining settings that depend on the target macOS version.
2719
2720 2018-01-17  Youenn Fablet  <youenn@apple.com>
2721
2722         Put fetch Request.keepalive behind a runtime flag
2723         https://bugs.webkit.org/show_bug.cgi?id=181592
2724
2725         Reviewed by Chris Dumez.
2726
2727         * WebView/WebPreferenceKeysPrivate.h:
2728         * WebView/WebPreferences.mm:
2729         (+[WebPreferences initialize]):
2730         (-[WebPreferences fetchAPIKeepAliveEnabled]):
2731         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
2732         * WebView/WebPreferencesPrivate.h:
2733         * WebView/WebView.mm:
2734         (-[WebView _preferencesChanged:]):
2735
2736 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2737
2738         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2739         https://bugs.webkit.org/show_bug.cgi?id=181637
2740         <rdar://problem/36508471>
2741
2742         Reviewed by Tim Horton.
2743
2744         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2745
2746         * WebCoreSupport/WebEditorClient.h:
2747         * WebCoreSupport/WebEditorClient.mm:
2748         (WebEditorClient::replacementURLForResource):
2749
2750 2018-01-11  Keith Miller  <keith_miller@apple.com>
2751
2752         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2753         https://bugs.webkit.org/show_bug.cgi?id=181573
2754
2755         Reviewed by Simon Fraser.
2756
2757         * Configurations/FeatureDefines.xcconfig:
2758
2759 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2760
2761         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
2762         https://bugs.webkit.org/show_bug.cgi?id=181497
2763
2764         Reviewed by Tim Horton.
2765
2766         See other ChangeLogs for more detail.
2767
2768         * WebCoreSupport/WebDragClient.h:
2769
2770 2018-01-11  Tim Horton  <timothy_horton@apple.com>
2771
2772         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
2773         https://bugs.webkit.org/show_bug.cgi?id=181523
2774         <rdar://problem/28959131>
2775
2776         Reviewed by Alex Christensen.
2777
2778         * WebView/WebImmediateActionController.mm:
2779         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2780         Apply the change made in r216652 to WebKit1's immediate action controller.
2781
2782         Speculative (but successful in WebKit2) fix for non-reproducible crash when
2783         the startContainer of the range is in an anonymous node.
2784
2785 2018-01-11  Youenn Fablet  <youenn@apple.com>
2786
2787         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
2788         https://bugs.webkit.org/show_bug.cgi?id=181480
2789
2790         Reviewed by Eric Carlson.
2791
2792         * WebView/WebPreferences.mm:
2793         (+[WebPreferences initialize]):
2794
2795 2018-01-08  David Kilzer  <ddkilzer@apple.com>
2796
2797         Fix check-webkit-style issues with WebNSDataExtras.mm
2798         <https://webkit.org/b/181369>
2799
2800         Reviewed by Alex Christensen.
2801
2802         * Misc/WebNSDataExtras.mm:
2803         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
2804         (-[NSData _webkit_guessedMIMETypeForXML]):
2805         (-[NSData _webkit_guessedMIMEType]):
2806         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
2807         (_findEOL):
2808         (-[NSData _webkit_parseRFC822HeaderFields]):
2809         (-[NSData _web_locationAfterFirstBlankLine]):
2810         - Fix all the check-webkit-style warnings.
2811
2812 2018-01-08  David Kilzer  <ddkilzer@apple.com>
2813
2814         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
2815         <https://webkit.org/b/181256>
2816         <rdar://problem/36281730>
2817
2818         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2819         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
2820         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
2821           to avoid warnings from casting CFStringRef to NPNSString*.
2822           Note that CFMutableStringRef is the same as CFStringRef
2823           without the const modifier, hence its use in the const_cast<>
2824           above.
2825
2826 2018-01-08  David Kilzer  <ddkilzer@apple.com>
2827
2828         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
2829         <https://webkit.org/b/181256>
2830         <rdar://problem/36281730>
2831
2832         * Carbon/HIWebView.mm:
2833         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
2834         checked_cf_cast<CFRunLoopRef>() to fix warning.
2835
2836 2018-01-07  David Kilzer  <ddkilzer@apple.com>
2837
2838         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
2839         <https://webkit.org/b/181256>
2840         <rdar://problem/36281730>
2841
2842         Reviewed by Darin Adler.
2843
2844         * Carbon/CarbonUtils.m:
2845         (PoolCleaner):
2846         - Use #pragmas to ignore -Wcast-qual warnings when using a
2847           C-style cast from CFTypeRef to CFRunloopRef.
2848         * Carbon/CarbonWindowFrame.m:
2849         (-[CarbonWindowFrame title]):
2850         - Use #pragmas to ignore -Wcast-qual warnings when using a
2851           C-style cast from CFStringRef to NSString *.
2852         * Carbon/HIViewAdapter.m:
2853         (+[HIViewAdapter getHIViewForNSView:]):
2854         - Use #pragmas to ignore -Wcast-qual warnings when using a
2855           C-style cast from CFTypeRef to HIViewRef.
2856         * Configurations/Base.xcconfig:
2857         (WARNING_CFLAGS): Add -Wcast-qual.
2858         * Misc/WebElementDictionary.mm:
2859         (-[WebElementDictionary objectForKey:]):
2860         - Use static_cast<SEL>(const_cast<void*>()) to fix
2861           warning.
2862         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
2863         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
2864         (-[NSData _webkit_guessedMIMETypeForXML]):
2865         (-[NSData _webkit_guessedMIMEType]):
2866         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
2867         (_findEOL):
2868         (-[NSData _webkit_parseRFC822HeaderFields]):
2869         (-[NSData _web_startsWithBlankLine]):
2870         (-[NSData _web_locationAfterFirstBlankLine]):
2871         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
2872           type to Objective-C++.  This fixes the warnings about
2873           discarding the `const` modifier when casing from CFStringRef
2874           to NSString * because in older clang versions, -Wcast-qual was
2875           completely broken when compiling C++ and Objective-C++ source
2876           files.  In newer clang versions, discarding the `const`
2877           modifier for toll-free bridged types is ignored when compiling
2878           Objective-C++ source.
2879         - Update copyright and license header.
2880         - Use reinterpret_cast<> and static_cast<> to fix warnings
2881           unrelated to (NSString *) C-style casts.
2882         - Replace use of MIN() macro with std::min<> template functions.
2883         - Fix location of `*` for local variables modified above.
2884         * Plugins/Hosted/NetscapePluginHostManager.mm:
2885         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2886         (WebKit::NetscapePluginHostManager::initializeVendorPort):
2887         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2888         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
2889           warnings.
2890         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2891         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2892         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
2893           to fix warning.
2894         * Plugins/Hosted/ProxyInstance.mm:
2895         (WebKit::ProxyInstance::invoke):
2896         - Use static_cast<char*>(const_cast<void*>()) to fix
2897           warning when using -[NSData bytes].
2898         (WebKit::ProxyInstance::fieldValue const):
2899         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
2900           to fix warning when using CFDataGetBytePtr().
2901         * Plugins/Hosted/WebTextInputWindowController.m:
2902         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2903         - Use #pragma to ignore -Wcast-qual warning since there
2904           is not a good way to avoid this warning in Objective-C.
2905         * Plugins/WebNetscapePluginStream.mm:
2906         (WebNetscapePluginStream::deliverData):
2907         - Use const_cast<void*>() to fix warning when using
2908           -[NSData bytes].
2909         * Plugins/WebNetscapePluginView.mm:
2910         (-[WebNetscapePluginView _createPlugin]):
2911         - Change C-style cast to const_cast<char*>() to fix
2912           warning.
2913         * WebCoreSupport/WebChromeClient.mm:
2914         (WebChromeClient::wrapCryptoKey const):
2915         (WebChromeClient::unwrapCryptoKey const):
2916         - Change C-style cast to
2917           static_cast<uint8_t*>(const_cast<void*>() to fix
2918           warning.
2919         * WebView/WebPDFView.mm:
2920         (_applicationInfoForMIMEType):
2921         - Change local variable type from 'NSURL *' to
2922           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
2923           when calling -[NSURL path].
2924
2925 2018-01-05  Dan Bernstein  <mitz@apple.com>
2926
2927         Fixed the build following AppKit API deprecations in a recent SDKs
2928
2929         * WebView/WebFullScreenController.mm:
2930         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
2931         (-[WebFullScreenController exitFullScreen]): Ditto.
2932         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
2933         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
2934         * WebView/WebHTMLView.mm:
2935         (-[WebHTMLView drawRect:]): Ditto.
2936         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
2937         (-[WebHTMLView knowsPageRange:]): Ditto.
2938         * WebView/WebView.mm:
2939         (LayerFlushController::flushLayers): Ditto.
2940
2941 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2942
2943         [Attachment Support] Create attachment elements when dropping files on iOS
2944         https://bugs.webkit.org/show_bug.cgi?id=181192
2945         <rdar://problem/36280945>
2946
2947         Reviewed by Tim Horton.
2948
2949         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
2950
2951         * WebCoreSupport/WebPlatformStrategies.h:
2952         * WebCoreSupport/WebPlatformStrategies.mm:
2953         (WebPlatformStrategies::informationForItemAtIndex):
2954         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
2955
2956 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2957
2958         [Attachment Support] Add plumbing for starting a drag with promised blob data
2959         https://bugs.webkit.org/show_bug.cgi?id=181201
2960
2961         Reviewed by Tim Horton.
2962
2963         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
2964
2965         * WebCoreSupport/WebDragClient.h:
2966
2967 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2968
2969         Add a WebAuthentication runtime feature flag
2970         https://bugs.webkit.org/show_bug.cgi?id=181220
2971         <rdar://problem/36055305>
2972
2973         Reviewed by Brent Fulgham.
2974
2975         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2976
2977         * WebView/WebPreferenceKeysPrivate.h:
2978         * WebView/WebPreferences.mm:
2979         (+[WebPreferences initialize]):
2980         (-[WebPreferences webAuthenticationEnabled]):
2981         (-[WebPreferences setWebAuthenticationEnabled:]):
2982         (-[WebPreferences credentialManagementEnabled]): Deleted.
2983         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
2984         * WebView/WebPreferencesPrivate.h:
2985         * WebView/WebView.mm:
2986         (-[WebView _preferencesChanged:]):
2987
2988 2017-12-22  Jeff Miller  <jeffm@apple.com>
2989
2990         Update user-visible copyright strings to include 2018
2991         https://bugs.webkit.org/show_bug.cgi?id=181141
2992
2993         Reviewed by Dan Bernstein.
2994
2995         * Info.plist:
2996
2997 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2998
2999         [Attachment Support] Remove current macOS support for dragging file-backed attachments
3000         https://bugs.webkit.org/show_bug.cgi?id=181188
3001
3002         Reviewed by Dan Bernstein.
3003
3004         See WebCore/ChangeLog for more detail.
3005
3006         * WebCoreSupport/WebDragClient.h:
3007         * WebCoreSupport/WebDragClient.mm:
3008         (WebDragClient::declareAndWriteAttachment): Deleted.
3009         * WebView/WebHTMLView.mm:
3010         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
3011
3012 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3013
3014         Unreviewed, continue to fix build failures due to AppKit API deprecation
3015
3016         Wraps more code in -Wdeprecated-declarations.
3017
3018         * Carbon/HIWebView.mm:
3019         (overrideCGContext):
3020
3021 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3022
3023         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
3024
3025         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
3026
3027         * Carbon/CarbonWindowAdapter.mm:
3028         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3029         * Plugins/WebNetscapePluginView.mm:
3030         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3031         (-[WebNetscapePluginView sendDrawRectEvent:]):
3032         (-[WebNetscapePluginView drawRect:]):
3033
3034 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3035
3036         Fix build failures due to using deprecated AppKit symbols
3037         https://bugs.webkit.org/show_bug.cgi?id=181110
3038         <rdar://problem/36162865>
3039
3040         Reviewed by Dan Bernstein and Tim Horton.
3041
3042         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
3043
3044         * Misc/WebKitNSStringExtras.mm:
3045         (-[NSString _web_drawAtPoint:font:textColor:]):
3046         * Misc/WebNSPasteboardExtras.h:
3047         * Misc/WebNSPasteboardExtras.mm:
3048         (+[NSPasteboard _web_writableTypesForURL]):
3049         (_createWritableTypesForImageWithoutArchive):
3050         (_createWritableTypesForImageWithArchive):
3051         (+[NSPasteboard _web_dragTypesForURL]):
3052         (-[NSPasteboard _web_bestURL]):
3053         (-[NSPasteboard _web_writeURL:andTitle:types:]):
3054         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3055         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
3056         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
3057         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3058         * Panels/WebAuthenticationPanel.m:
3059         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
3060         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
3061         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3062         (-[WebHostedNetscapePluginView drawRect:]):
3063         * WebInspector/WebNodeHighlightView.mm:
3064         (-[WebNodeHighlightView drawRect:]):
3065         * WebView/WebFrame.mm:
3066         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3067         (-[WebFrame _drawRect:contentsOnly:]):
3068         * WebView/WebHTMLView.mm:
3069         (kit):
3070         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
3071         (-[WebHTMLView _plainTextFromPasteboard:]):
3072         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3073         (+[WebHTMLView _insertablePasteboardTypes]):
3074         (+[WebHTMLView _selectionPasteboardTypes]):
3075         (-[WebHTMLView pasteboard:provideDataForType:]):
3076         (-[WebHTMLView _writeSelectionToPasteboard:]):
3077         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3078         (-[WebHTMLView validRequestorForSendType:returnType:]):
3079         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3080         (createMenuItem):
3081         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3082         (-[WebHTMLView _colorAsString:]):
3083         (-[WebHTMLView copyFont:]):
3084         * WebView/WebPDFView.mm:
3085         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3086         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3087         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3088         (-[WebPDFView pasteboardTypesForSelection]):
3089         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
3090         * WebView/WebView.h:
3091         * WebView/WebView.mm:
3092         (-[WebView performDragOperation:]):
3093         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
3094         (-[WebView _searchWithGoogleFromMenu:]):
3095
3096 2017-12-21  Youenn Fablet  <youenn@apple.com>
3097
3098         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
3099         https://bugs.webkit.org/show_bug.cgi?id=181000
3100
3101         Reviewed by Chris Dumez.
3102
3103         * Misc/WebCache.mm:
3104         (+[WebCache addImageToCache:forURL:forFrame:]):
3105
3106 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
3107
3108         Update FULLSCREEN_API feature defines.
3109         https://bugs.webkit.org/show_bug.cgi?id=181015
3110
3111         Reviewed by Tim Horton.
3112
3113         Change enabled iphone sdk for FULLSCREEN_API.
3114
3115         * Configurations/FeatureDefines.xcconfig:
3116
3117 2017-12-21  Jer Noble  <jer.noble@apple.com>
3118
3119         Add initial DOM support for Media Capabilities
3120         https://bugs.webkit.org/show_bug.cgi?id=181064
3121
3122         Reviewed by Eric Carlson.
3123
3124         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
3125
3126         * WebView/WebPreferenceKeysPrivate.h:
3127         * WebView/WebPreferences.mm:
3128         (+[WebPreferences initialize]):
3129         (-[WebPreferences mediaCapabilitiesEnabled]):
3130         (-[WebPreferences setMediaCapabilitiesEnabled:]):
3131         * WebView/WebPreferencesPrivate.h:
3132         * WebView/WebView.mm:
3133         (-[WebView _preferencesChanged:]):
3134
3135 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
3136
3137         Enable picture-in-picture from inline element on suspend.
3138         https://bugs.webkit.org/show_bug.cgi?id=180942
3139         rdar://problem/34745234
3140
3141         Reviewed by Jer Noble.
3142
3143         Update signature of enterVideoFullscreenForVideoElement().
3144
3145         * WebCoreSupport/WebChromeClient.h:
3146         * WebCoreSupport/WebChromeClient.mm:
3147         (WebChromeClient::enterVideoFullscreenForVideoElement):
3148
3149 2017-12-20  Daniel Bates  <dabates@apple.com>
3150
3151         Remove Alternative Presentation Button
3152         https://bugs.webkit.org/show_bug.cgi?id=180500
3153         <rdar://problem/35891047>
3154
3155         Reviewed by Simon Fraser.
3156
3157         We no longer need the alternative presentation button.
3158
3159         * Configurations/FeatureDefines.xcconfig:
3160
3161 2017-12-19  Jer Noble  <jer.noble@apple.com>
3162
3163         Playing media elements which call "pause(); play()" will have the play promise rejected.
3164         https://bugs.webkit.org/show_bug.cgi?id=180781
3165         <rdar://problem/33191377>
3166
3167         Reviewed by Eric Carlson.
3168
3169         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
3170
3171         * WebView/WebView.mm:
3172         (shouldRequireUserGestureToLoadVideo):
3173
3174 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
3177         https://bugs.webkit.org/show_bug.cgi?id=180977
3178
3179         Reviewed by Tim Horton.
3180
3181         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
3182         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
3183         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
3184
3185         * WebCoreSupport/WebEditorClient.mm:
3186         (attributesForAttributedStringConversion):
3187         * WebView/WebHTMLView.mm:
3188         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
3189
3190 2017-12-18  David Kilzer  <ddkilzer@apple.com>
3191
3192         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
3193
3194         Attempt to fix the following warnings:
3195
3196             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
3197
3198         For the following instance variables:
3199
3200             _borderView
3201             _contentView
3202             _frame
3203             _wFlags
3204
3205         * Carbon/CarbonWindowAdapter.mm:
3206         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3207         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3208         (-[CarbonWindowAdapter _termWindowIfOwner]):
3209         (-[CarbonWindowAdapter _windowMovedToRect:]):
3210         (-[CarbonWindowAdapter setContentView:]):
3211         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3212         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3213
3214 2017-12-16  Dan Bernstein  <mitz@apple.com>
3215
3216         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
3217         https://bugs.webkit.org/show_bug.cgi?id=180613
3218         <rdar://problem/35946124>
3219
3220         Reviewed by Geoff Garen.
3221
3222         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
3223           clients.
3224         * WebView/WebDynamicScrollBarsView.h: Ditto.
3225         * WebView/WebDynamicScrollBarsView.mm: Ditto.
3226
3227 2017-12-14  David Kilzer  <ddkilzer@apple.com>
3228
3229         Enable -Wstrict-prototypes for WebKit
3230         <https://webkit.org/b/180757>
3231         <rdar://problem/36024132>
3232
3233         Rubber-stamped by Joseph Pecoraro.
3234
3235         * Configurations/Base.xcconfig:
3236         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
3237
3238 2017-12-14  John Wilander  <wilander@apple.com>
3239
3240         Storage Access API: Implement frame-specific access in the document.cookie layer
3241         https://bugs.webkit.org/show_bug.cgi?id=180682
3242         <rdar://problem/35982257>
3243
3244         Reviewed by Alex Christensen.
3245
3246         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
3247         CookiesStrategy::cookieRequestHeaderFieldValue(), and
3248         CookiesStrategy::getRawCookies() now take optional parameters for
3249         frameID and pageID to allow frame-specific scoping of cookies.
3250
3251         This change makes the return values of FrameLoaderClient::frameID()
3252         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
3253         WebCore can call those getters and get the right return values in
3254         WebKit and std:nullopt in WebKitLegacy.
3255
3256         * WebCoreSupport/WebFrameLoaderClient.h:
3257         * WebCoreSupport/WebFrameLoaderClient.mm:
3258         (WebFrameLoaderClient::pageID const):
3259         (WebFrameLoaderClient::frameID const):
3260         * WebCoreSupport/WebPlatformStrategies.h:
3261         * WebCoreSupport/WebPlatformStrategies.mm:
3262         (WebPlatformStrategies::cookiesForDOM):
3263         (WebPlatformStrategies::setCookiesFromDOM):
3264         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3265         (WebPlatformStrategies::getRawCookies):
3266
3267 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
3268
3269         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
3270         https://bugs.webkit.org/show_bug.cgi?id=180689
3271
3272         Reviewed by Tim Horton.
3273
3274         Use sRGBColorSpaceRef() from WebCore.
3275
3276         * WebView/WebHTMLView.mm:
3277         (imageFromRect):
3278
3279 2017-12-11  Tim Horton  <timothy_horton@apple.com>
3280
3281         Stop using deprecated target conditional for simulator builds
3282         https://bugs.webkit.org/show_bug.cgi?id=180662
3283         <rdar://problem/35136156>
3284
3285         Reviewed by Simon Fraser.
3286
3287         * postprocess-headers.sh:
3288
3289 2017-12-11  David Quesada  <david_quesada@apple.com>
3290
3291         Turn on ENABLE_APPLICATION_MANIFEST
3292         https://bugs.webkit.org/show_bug.cgi?id=180562
3293         rdar://problem/35924737
3294
3295         Reviewed by Geoffrey Garen.
3296
3297         * Configurations/FeatureDefines.xcconfig:
3298
3299 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3300
3301         Remove pthread_once in favor of dispatch_once
3302         https://bugs.webkit.org/show_bug.cgi?id=180591
3303
3304         Reviewed by Saam Barati.
3305
3306         * Misc/WebKitErrors.m:
3307         (+[NSError _registerWebKitErrors]):
3308         (registerErrors): Deleted.
3309         * Storage/WebStorageManager.mm:
3310         (+[WebStorageManager _storageDirectoryPath]):
3311         (initializeLocalStoragePath): Deleted.
3312
3313 2017-12-07  Darin Adler  <darin@apple.com>
3314
3315         Remove some unused code from WebKitLegacy
3316         https://bugs.webkit.org/show_bug.cgi?id=180567
3317
3318         Reviewed by Anders Carlsson.
3319
3320         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
3321         macOS (back a few versions) and iOS and removed unused
3322         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
3323         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
3324         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
3325         _webkit_stringByCollapsingNonPrintingCharacters,
3326         _webkit_stringByCollapsingWhitespaceCharacters,
3327         _web_stringWithData:textEncodingName:, and
3328         _webkit_localStorageDirectoryWithBundleIdentifier:.
3329
3330         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
3331         this source file.
3332         (canUseFastRenderer): Made this faster by not calling u_charDirection for
3333         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
3334         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
3335         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
3336         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
3337         handle font smoothing options.
3338         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
3339         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
3340         from header and made it a little clearer.
3341         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
3342         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
3343         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
3344         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
3345         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
3346         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
3347         implementation a bit and used whole words instead of abbreviations.
3348         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
3349
3350         * Misc/WebNSFileManagerExtras.mm:
3351         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
3352         filenameByFixingIllegalCharacters function from WebCore directly instead of
3353         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
3354
3355         * Plugins/WebBaseNetscapePluginView.mm:
3356         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
3357         string replacements instead of _web_stringByStrippingReturnCharacters
3358         and to use NSString methods instead of CFString functions.
3359
3360 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
3361
3362         Ignore deprecation warnings.
3363
3364         * WebView/WebHTMLView.mm:
3365         (-[NSWindow _web_borderView]):
3366         (-[WebHTMLView _setAsideSubviews]):
3367         * WebView/WebView.mm:
3368         (-[WebView encodeWithCoder:]):
3369
3370 2017-12-02  Darin Adler  <darin@apple.com>
3371
3372         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
3373         https://bugs.webkit.org/show_bug.cgi?id=180009
3374
3375         Reviewed by Alex Christensen.
3376
3377         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
3378
3379         * Plugins/WebBaseNetscapePluginView.mm:
3380         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
3381         of strcasecmp.
3382
3383         * WebView/WebPreferences.mm:
3384         (contains): Ditto. Also made this a template so it's easier to call on an array.
3385         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
3386
3387 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
3388
3389         Limit user agent versioning to an upper bound
3390         https://bugs.webkit.org/show_bug.cgi?id=180365
3391         <rdar://problem/34550617>
3392
3393         Reviewed by Joseph Pecoraro.
3394
3395         * WebView/WebView.mm:
3396         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
3397         creating the User Agent string.
3398         (webKitBundleVersionString): Deleted.
3399
3400 2017-12-05  Andy Estes  <aestes@apple.com>
3401
3402         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
3403         https://bugs.webkit.org/show_bug.cgi?id=180457
3404         <rdar://problem/35143007>
3405
3406         Reviewed by Tim Horton.
3407
3408         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
3409         check for this macro during post-processing.
3410
3411         * postprocess-headers.sh:
3412
3413 2017-12-04  David Quesada  <david_quesada@apple.com>
3414
3415         Add a class for parsing application manifests
3416         https://bugs.webkit.org/show_bug.cgi?id=177973
3417         rdar://problem/34747949
3418
3419         Reviewed by Geoffrey Garen.
3420
3421         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
3422
3423 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
3424
3425         Make LegacyCustomProtocolManager optional for network process
3426         https://bugs.webkit.org/show_bug.cgi?id=176230
3427
3428         Reviewed by Alex Christensen.
3429
3430         * Configurations/FeatureDefines.xcconfig:
3431
3432 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
3433
3434         Fix some NSOperationQueue leaks
3435         https://bugs.webkit.org/show_bug.cgi?id=180221
3436
3437         Reviewed by Wenson Hsieh.
3438
3439         * WebView/WebView.mm:
3440         (-[WebView performDragOperation:]):
3441
3442 2017-11-30  Darin Adler  <darin@apple.com>
3443
3444         [Mac] remove unneeded RetainPtr use introduced in r225142
3445         https://bugs.webkit.org/show_bug.cgi?id=180202
3446
3447         Reviewed by Tim Horton.
3448
3449         * WebView/WebImmediateActionController.mm:
3450         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
3451         RetainPtr.
3452
3453 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
3454
3455         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
3456         https://bugs.webkit.org/show_bug.cgi?id=175595
3457
3458         Reviewed by Darin Adler.
3459
3460         * WebView/WebPreferences.mm:
3461
3462 2017-11-27  Tim Horton  <timothy_horton@apple.com>
3463
3464         One too many zeroes in macOS version number in FeatureDefines
3465         https://bugs.webkit.org/show_bug.cgi?id=180011
3466
3467         Reviewed by Dan Bernstein.
3468
3469         * Configurations/FeatureDefines.xcconfig:
3470
3471 2017-11-23  Darin Adler  <darin@apple.com>
3472
3473         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
3474         https://bugs.webkit.org/show_bug.cgi?id=179981
3475
3476         Reviewed by Sam Weinig.
3477
3478         * WebView/WebImmediateActionController.mm:
3479         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
3480         * WebView/WebView.mm:
3481         (coreOptions): Use |= instead of | to build up FindOptions.
3482
3483 2017-11-23  Sam Weinig  <sam@webkit.org>
3484
3485         Remove unneeded ScriptController::processingUserGesture() forwarding functions
3486         https://bugs.webkit.org/show_bug.cgi?id=179954
3487
3488         Reviewed by Darin Adler.
3489
3490         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
3491         with direct calls to the corresponding UserGestureIndicator functions.
3492
3493         * Plugins/WebPluginController.mm:
3494         (-[WebPluginController processingUserGesture]):
3495         * WebView/WebView.mm:
3496         (-[WebView _isProcessingUserGesture]):
3497
3498 2017-11-23  Darin Adler  <darin@apple.com>
3499
3500         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
3501         https://bugs.webkit.org/show_bug.cgi?id=179907
3502
3503         Reviewed by Sam Weinig.
3504
3505         * History/BinaryPropertyList.cpp:
3506         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
3507         (BinaryPropertyListSerializer::appendStringObject): Ditto.
3508         * WebView/WebHTMLRepresentation.mm:
3509         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
3510         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
3511
3512 2017-11-22  Ali Juma  <ajuma@chromium.org>
3513
3514         Implement VisualViewport API attributes
3515         https://bugs.webkit.org/show_bug.cgi?id=179385
3516
3517         Reviewed by Frédéric Wang.
3518
3519         Add a VisualViewportAPI preference.
3520
3521         * WebView/WebPreferenceKeysPrivate.h:
3522         * WebView/WebPreferences.mm:
3523         (+[WebPreferences initialize]):
3524         (-[WebPreferences visualViewportAPIEnabled]):
3525         (-[WebPreferences setVisualViewportAPIEnabled:]):
3526         * WebView/WebPreferencesPrivate.h:
3527         * WebView/WebView.mm:
3528         (-[WebView _preferencesChanged:]):
3529
3530 2017-11-22  Christopher Reid  <chris.reid@sony.com>
3531
3532         WebCoreObjCExtras.h is being included in too many places
3533         https://bugs.webkit.org/show_bug.cgi?id=179931
3534
3535         Reviewed by Darin Adler.
3536
3537         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3538         * Plugins/WebBaseNetscapePluginView.mm:
3539         * Plugins/WebBasePluginPackage.mm:
3540         * Plugins/WebNetscapePluginStream.mm:
3541         * Plugins/WebNetscapePluginView.mm:
3542         * WebView/WebTextIterator.mm:
3543         * WebView/WebViewData.mm:
3544
3545 2017-11-22  Commit Queue  <commit-queue@webkit.org>
3546
3547         Unreviewed, rolling out r225093.
3548         https://bugs.webkit.org/show_bug.cgi?id=179938
3549
3550         Compilation failed on WinCairo 64-bit Release (Requested by
3551         fredw on #webkit).
3552
3553         Reverted changeset:
3554
3555         "Implement VisualViewport API attributes"
3556         https://bugs.webkit.org/show_bug.cgi?id=179385
3557         https://trac.webkit.org/changeset/225093
3558
3559 2017-11-21  Ali Juma  <ajuma@chromium.org>
3560
3561         Implement VisualViewport API attributes
3562         https://bugs.webkit.org/show_bug.cgi?id=179385
3563
3564         Reviewed by Frédéric Wang.
3565
3566         Add a VisualViewportAPI preference.
3567
3568         * WebView/WebPreferenceKeysPrivate.h:
3569         * WebView/WebPreferences.mm:
3570         (+[WebPreferences initialize]):
3571         (-[WebPreferences visualViewportAPIEnabled]):
3572         (-[WebPreferences setVisualViewportAPIEnabled:]):
3573         * WebView/WebPreferencesPrivate.h:
3574         * WebView/WebView.mm:
3575         (-[WebView _preferencesChanged:]):
3576
3577 2017-11-21  Christopher Reid  <chris.reid@sony.com>
3578
3579         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
3580         https://bugs.webkit.org/show_bug.cgi?id=179504
3581
3582         Reviewed by Darin Adler.
3583
3584         * Misc/WebKitNSStringExtras.mm:
3585         * Plugins/Hosted/NetscapePluginHostManager.mm:
3586         * Plugins/WebBasePluginPackage.mm:
3587
3588 2017-11-19  Tim Horton  <timothy_horton@apple.com>
3589
3590         Remove unused TOUCH_ICON_LOADING feature flag
3591         https://bugs.webkit.org/show_bug.cgi?id=179873
3592
3593         Reviewed by Simon Fraser.
3594
3595         * Configurations/FeatureDefines.xcconfig:
3596
3597 2017-11-19  Tim Horton  <timothy_horton@apple.com>
3598
3599         Remove unused LEGACY_VENDOR_PREFIXES feature flag
3600         https://bugs.webkit.org/show_bug.cgi?id=179872
3601
3602         Reviewed by Darin Adler.
3603
3604         * Configurations/FeatureDefines.xcconfig:
3605
3606 2017-11-16  Daniel Bates  <dabates@apple.com>
3607
3608         Add feature define for alternative presentation button element
3609         https://bugs.webkit.org/show_bug.cgi?id=179692
3610         Part of <rdar://problem/34917108>
3611
3612         Reviewed by Andy Estes.
3613
3614         Only enabled on Cocoa platforms by default.
3615
3616         * Configurations/FeatureDefines.xcconfig:
3617
3618 2017-11-14  Nan Wang  <n_wang@apple.com>
3619
3620         AX: AOM: Implement AccessibleNode class and support label and role attributes
3621         https://bugs.webkit.org/show_bug.cgi?id=179494
3622
3623         Reviewed by Ryosuke Niwa.
3624
3625         * WebView/WebPreferenceKeysPrivate.h:
3626         * WebView/WebPreferences.mm:
3627         (+[WebPreferences initialize]):
3628         (-[WebPreferences accessibilityObjectModelEnabled]):
3629         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
3630         * WebView/WebPreferencesPrivate.h:
3631         * WebView/WebView.mm:
3632         (-[WebView _preferencesChanged:]):
3633
3634 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3635
3636         Remove Cocoa CFURLConnection loading code
3637         https://bugs.webkit.org/show_bug.cgi?id=179688
3638
3639         Reviewed by Antti Koivisto.
3640
3641         * Misc/WebDownload.mm:
3642         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
3643         * Misc/WebDownloadInternal.h:
3644         * Plugins/WebBaseNetscapePluginView.mm:
3645         * WebCoreSupport/WebFrameLoaderClient.mm:
3646         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3647         * WebView/WebView.mm:
3648         (-[WebView scheduleInRunLoop:forMode:]):
3649         (-[WebView unscheduleFromRunLoop:forMode:]):
3650
3651 2017-11-14  Daniel Bates  <dabates@apple.com>
3652
3653         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
3654         for feature defines
3655
3656         Following r195498 and r201917 the Visual Studio property files for feature defines have
3657         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
3658         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
3659         files.
3660
3661         * Configurations/FeatureDefines.xcconfig:
3662
3663 2017-11-14  Jer Noble  <jer.noble@apple.com>
3664
3665         Enable Modern EME tests in DumpRenderTree
3666         https://bugs.webkit.org/show_bug.cgi?id=179544
3667
3668         Reviewed by Alex Christensen.
3669
3670         Add a WebPreferences property to enable the (modern) EME API.
3671
3672         * WebView/WebPreferenceKeysPrivate.h:
3673         * WebView/WebPreferences.mm:
3674         (+[WebPreferences initialize]):
3675         (-[WebPreferences encryptedMediaAPIEnabled]):
3676         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
3677         * WebView/WebPreferencesPrivate.h:
3678         * WebView/WebView.mm:
3679         (-[WebView _preferencesChanged:]):
3680
3681 2017-11-14  Antti Koivisto  <antti@apple.com>
3682
3683         Enable display:contents by default
3684         https://bugs.webkit.org/show_bug.cgi?id=179655
3685
3686         Reviewed by Sam Weinig.
3687
3688         * WebView/WebPreferences.mm:
3689         (+[WebPreferences initialize]):
3690
3691 2017-11-13  Alex Christensen  <achristensen@webkit.org>
3692
3693         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
3694         https://bugs.webkit.org/show_bug.cgi?id=178751
3695
3696         Reviewed by Brady Eidson.
3697
3698         * WebCoreSupport/WebFrameNetworkingContext.mm:
3699         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3700
3701 2017-11-08  Keith Miller  <keith_miller@apple.com>
3702
3703         Async iteration should only fetch the next method once and add feature flag
3704         https://bugs.webkit.org/show_bug.cgi?id=179451
3705
3706         Reviewed by Geoffrey Garen.
3707
3708         Add feature flag for Async iteration.
3709
3710         * Configurations/FeatureDefines.xcconfig:
3711
3712 2017-11-13  Mark Lam  <mark.lam@apple.com>
3713
3714         Add more overflow check book-keeping for MarkedArgumentBuffer.
3715         https://bugs.webkit.org/show_bug.cgi?id=179634
3716         <rdar://problem/35492517>
3717
3718         Reviewed by Saam Barati.
3719
3720         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3721         (WebKit::NetscapePluginInstanceProxy::invoke):
3722         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3723         (WebKit::NetscapePluginInstanceProxy::construct):
3724
3725 2017-11-12  Darin Adler  <darin@apple.com>
3726
3727         More is<> and downcast<>, less static_cast<>
3728         https://bugs.webkit.org/show_bug.cgi?id=179600
3729
3730         Reviewed by Chris Dumez.
3731
3732         * DOM/DOM.mm:
3733         (kit): Use is/downcast.
3734         * WebCoreSupport/WebEditorClient.mm:
3735         (WebEditorClient::handleKeyboardEvent): Ditto.
3736         (WebEditorClient::handleInputMethodKeydown): Ditto.
3737         * WebView/WebHTMLView.mm:
3738         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
3739
3740 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
3741
3742         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
3743         https://bugs.webkit.org/show_bug.cgi?id=179397
3744
3745         Reviewed by Wenson Hsieh.
3746
3747         * DOM/DOMHTMLInputElement.mm:
3748         (-[DOMHTMLInputElement insertTextSuggestion:]):
3749
3750 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
3751
3752         HTMLMediaElement should not use element fullscreen on iOS
3753         https://bugs.webkit.org/show_bug.cgi?id=179418
3754         rdar://problem/35409277
3755
3756         Reviewed by Eric Carlson.
3757
3758         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
3759
3760         * Configurations/FeatureDefines.xcconfig:
3761
3762 2017-11-06  Alex Christensen  <achristensen@webkit.org>
3763
3764         Make ResourceLoader::willSendRequestInternal asynchronous
3765         https://bugs.webkit.org/show_bug.cgi?id=179251
3766
3767         Reviewed by Andy Estes.
3768
3769         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3770         (WebKit::HostedNetscapePluginStream::start):
3771         * Plugins/WebNetscapePluginStream.mm:
3772         (WebNetscapePluginStream::start):
3773
3774 2017-11-01  Darin Adler  <darin@apple.com>
3775
3776         Simplify event dispatch code and make it a bit more consistent
3777         https://bugs.webkit.org/show_bug.cgi?id=178991
3778
3779         Reviewed by Chris Dumez.
3780
3781         * DOM/DOMEvent.mm:
3782         (-[DOMEvent srcElement]): Call target instead of srcElement.
3783
3784 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
3785
3786         [Touch Bar Web API] Add support for menuitem tag
3787         https://bugs.webkit.org/show_bug.cgi?id=179020
3788
3789         Reviewed by Ryosuke Niwa.
3790
3791         Adds in properties and methods that allow the menuitem runtime feature
3792         to be enabled or disabled.
3793
3794         * WebView/WebPreferenceKeysPrivate.h:
3795         * WebView/WebPreferences.mm:
3796         (-[WebPreferences menuItemElementEnabled]):
3797         (-[WebPreferences setMenuItemElementEnabled:]):
3798         * WebView/WebPreferencesPrivate.h:
3799         * WebView/WebView.mm:
3800         (-[WebView _preferencesChanged:]):
3801
3802 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3803
3804         Use CompletionHandlers for redirects
3805         https://bugs.webkit.org/show_bug.cgi?id=179163
3806
3807         Reviewed by Tim Horton.
3808
3809         * Plugins/Hosted/HostedNetscapePluginStream.h:
3810         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3811         (WebKit::HostedNetscapePluginStream::willSendRequest):
3812         * Plugins/WebNetscapePluginStream.h:
3813         * Plugins/WebNetscapePluginStream.mm:
3814         (WebNetscapePluginStream::willSendRequest):
3815
3816 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3817
3818         Add a FileSystem namespace to FileSystem.cpp
3819         https://bugs.webkit.org/show_bug.cgi?id=179063
3820
3821         Reviewed by Darin Adler.
3822
3823         * Misc/WebNSFileManagerExtras.mm:
3824         * Storage/WebDatabaseProvider.mm:
3825
3826 2017-11-02  Frederic Wang  <fwang@igalia.com>
3827
3828         Add references to bug 179167 in FIXME comments
3829         https://bugs.webkit.org/show_bug.cgi?id=179168
3830
3831         Reviewed by Daniel Bates.
3832
3833         * Configurations/FeatureDefines.xcconfig:
3834
3835 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
3836
3837         Implement WKFullscreenWindowController for iOS.
3838         https://bugs.webkit.org/show_bug.cgi?id=178924
3839         rdar://problem/34697120
3840
3841         Reviewed by Simon Fraser.
3842
3843         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
3844
3845         * Configurations/FeatureDefines.xcconfig:
3846         * WebView/WebView.mm:
3847         (-[WebView fullScreenPlaceholderView]):
3848
3849 2017-10-31  Tim Horton  <timothy_horton@apple.com>
3850
3851         Clean up some drag and drop feature flags
3852         https://bugs.webkit.org/show_bug.cgi?id=179082
3853
3854         Reviewed by Simon Fraser.
3855
3856         * Configurations/FeatureDefines.xcconfig:
3857
3858 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
3859
3860         Make it possible to test rubber-banding in overflow scroll
3861         https://bugs.webkit.org/show_bug.cgi?id=179078
3862
3863         Reviewed by Sam Weinig.
3864
3865         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
3866         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
3867
3868         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
3869         functions, since most callers want clamped.
3870
3871         * DOM/DOMHTML.mm:
3872         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
3873
3874 2017-10-31  Tim Horton  <timothy_horton@apple.com>
3875
3876         Fix up some content filtering feature flags
3877         https://bugs.webkit.org/show_bug.cgi?id=179079
3878
3879         Reviewed by Simon Fraser.
3880
3881         * Configurations/FeatureDefines.xcconfig:
3882
3883 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3884
3885         [FrameView::layout cleanup] Move core layout logic to a separate class.
3886         https://bugs.webkit.org/show_bug.cgi?id=178771
3887         <rdar://problem/35166542>
3888
3889         Reviewed by Simon Fraser.
3890
3891         Move layout code out from FrameView to LayoutContext.
3892
3893         * WebView/WebClipView.mm:
3894         (-[WebClipView _immediateScrollToPoint:]):
3895         * WebView/WebFrame.mm:
3896         (-[WebFrame layoutCount]):
3897
3898 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
3899
3900         Fix issues with WebView subframe painting
3901         https://bugs.webkit.org/show_bug.cgi?id=178842
3902         rdar://problem/34072253
3903
3904         Reviewed by Daniel Bates.
3905         
3906         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
3907         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
3908         High Sierra, so match the new signature.
3909
3910         Also rename the 'rect' param to 'displayRect' to match AppKit code.
3911
3912         * WebView/WebHTMLView.mm:
3913         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3914         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
3915
3916 2017-10-25  Youenn Fablet  <youenn@apple.com>
3917
3918         Enable ServiceWorker to fetch resources
3919         https://bugs.webkit.org/show_bug.cgi?id=178673
3920
3921         Reviewed by Brady Eidson.
3922
3923         * WebCoreSupport/WebFrameLoaderClient.mm:
3924         (WebFrameLoaderClient::pageID const):
3925         (WebFrameLoaderClient::frameID const):
3926         (WebFrameLoaderClient::sessionID const):
3927
3928         Added implementation to the new getters.
3929         They are noop in the context of WK1.
3930
3931 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
3932
3933         Web Inspector: Enable WebKit logging configuration and display
3934         https://bugs.webkit.org/show_bug.cgi?id=177027
3935         <rdar://problem/33964767>
3936
3937         Reviewed by Joseph Pecoraro.
3938
3939         * WebCoreSupport/WebChromeClient.mm:
3940         (stringForMessageSource): Deal with Media and WebRTC message sources.
3941
3942 2017-10-20  Antoine Quint  <graouts@apple.com>
3943
3944         [Web Animations] Provide basic timeline and animation interfaces
3945         https://bugs.webkit.org/show_bug.cgi?id=178526
3946
3947         Reviewed by Dean Jackson.
3948
3949         Remove the WEB_ANIMATIONS compile-time flag.
3950
3951         * Configurations/FeatureDefines.xcconfig:
3952         * WebView/WebPreferences.mm:
3953         (+[WebPreferences initialize]):
3954         * WebView/WebView.mm:
3955         (-[WebView _preferencesChanged:]):
3956
3957 2017-10-19  Sam Weinig  <sam@webkit.org>
3958
3959         [Settings] Move global settings into their own file
3960         https://bugs.webkit.org/show_bug.cgi?id=178512
3961
3962         Reviewed by Darin Adler.
3963
3964         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3965
3966         * WebCoreSupport/WebChromeClient.mm:
3967         (WebChromeClient::supportsVideoFullscreen):
3968         * WebView/WebDynamicScrollBarsView.mm:
3969         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
3970         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
3971         * WebView/WebPreferences.mm:
3972         (+[WebPreferences initialize]):
3973         * WebView/WebView.mm:
3974         (-[WebView _commonInitializationWithFrameName:groupName:]):
3975         (-[WebView _preferencesChanged:]):
3976         (+[WebView _doNotStartObservingNetworkReachability]):
3977
3978 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3979
3980         Replace some stack raw pointers with RefPtrs within WebCore/html
3981         https://bugs.webkit.org/show_bug.cgi?id=178201
3982         <rdar://problem/34841692>
3983
3984         Reviewed by Ryosuke Niwa.
3985
3986         * DOM/DOM.mm:
3987         (kit):
3988         Change the type of node as toNode() is changed to return RefPtr.
3989
3990 2017-10-18  Chris Dumez  <cdumez@apple.com>
3991
3992         [Service Worker] Add stubs for Client / WindowClient / Clients
3993         https://bugs.webkit.org/show_bug.cgi?id=178469
3994
3995         Reviewed by Youenn Fablet.
3996
3997         Rename PageVisiblityState to VisibilityState.
3998
3999         * WebView/WebView.mm:
4000         (kit):
4001
4002 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4003
4004         Unreviewed, rolling out r223291.
4005
4006         See WebCore ChangeLog for more detail.
4007
4008         Reverted changeset:
4009
4010         "Remove Editor::simplifyMarkup"
4011         https://bugs.webkit.org/show_bug.cgi?id=178271
4012         https://trac.webkit.org/changeset/223291
4013
4014 2017-10-17  Keith Miller  <keith_miller@apple.com>
4015
4016         Change WebCore sources to work with unified source builds
4017         https://bugs.webkit.org/show_bug.cgi?id=178229
4018
4019         Rubber stamped by Tim Horton.
4020
4021         * Configurations/FeatureDefines.xcconfig:
4022
4023 2017-10-16  Sam Weinig  <sam@webkit.org>
4024
4025         [Settings] Remove all custom code from Settings.h/cpp
4026         https://bugs.webkit.org/show_bug.cgi?id=178330
4027
4028         Reviewed by Simon Fraser.
4029
4030         * WebView/WebPreferences.mm:
4031         (+[WebPreferences initialize]):
4032         
4033             Update for naming changes of FrameFlattening now that it is an enum class.
4034
4035 2017-10-13  Alex Christensen  <achristensen@webkit.org>
4036
4037         Remove Editor::simplifyMarkup
4038         https://bugs.webkit.org/show_bug.cgi?id=178271
4039
4040         Reviewed by Wenson Hsieh.
4041
4042         * WebView/WebView.mm:
4043         (-[WebView _simplifyMarkup:endNode:]):
4044
4045 2017-10-12  Chris Dumez  <cdumez@apple.com>
4046
4047         [Mac] Add support for MouseEvent.buttons
4048         https://bugs.webkit.org/show_bug.cgi?id=178214
4049
4050         Reviewed by Ryosuke Niwa.
4051
4052         * WebView/WebPDFView.mm:
4053         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4054
4055 2017-10-11  Sam Weinig  <sam@webkit.org>
4056
4057         Remove out-parameter variants of copyToVector
4058         https://bugs.webkit.org/show_bug.cgi?id=178155
4059
4060         Reviewed by Tim Horton.
4061
4062         * Plugins/WebNetscapePluginView.mm:
4063         (-[WebNetscapePluginView destroyPlugin]):
4064         * WebView/WebHTMLRepresentation.mm:
4065         (newArrayWithStrings):
4066
4067             Replace out-parameter based copyToVector, with one that returns a Vector.
4068
4069 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
4070
4071         Sanitize URL in pasteboard for other applications and cross origin content
4072         https://bugs.webkit.org/show_bug.cgi?id=178060
4073         <rdar://problem/34874518>
4074
4075         Reviewed by Wenson Hsieh.
4076
4077         * WebCoreSupport/WebPlatformStrategies.h:
4078         * WebCoreSupport/WebPlatformStrategies.mm:
4079         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
4080
4081 2017-10-11  Chris Dumez  <cdumez@apple.com>
4082
4083         Modernize Geolocation code
4084         https://bugs.webkit.org/show_bug.cgi?id=178148
4085
4086         Reviewed by Ryosuke Niwa.
4087
4088         * WebCoreSupport/WebGeolocationClient.h:
4089         * WebCoreSupport/WebGeolocationClient.mm:
4090         (WebGeolocationClient::lastPosition):
4091         * WebView/WebGeolocationPosition.mm:
4092         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
4093         (core):
4094         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
4095         (-[WebGeolocationPosition initWithGeolocationPosition:]):
4096         * WebView/WebGeolocationPositionInternal.h:
4097
4098 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
4099
4100         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
4101         https://bugs.webkit.org/show_bug.cgi?id=178154
4102
4103         Reviewed by Wenson Hsieh.
4104
4105         Enable custom pasteboard data by default.