ec6ef26a6fa2cc5807b09d9c09853da56a0e109f
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
2
3         Runtime flag for link prefetch and remove link subresource.
4         https://bugs.webkit.org/show_bug.cgi?id=183540
5
6         Reviewed by Chris Dumez.
7
8         Remove the LINK_PREFETCH build time flag.
9
10         * Configurations/FeatureDefines.xcconfig:
11
12 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
13
14         Remove GridLayout runtime flag
15         https://bugs.webkit.org/show_bug.cgi?id=183484
16
17         Reviewed by Myles C. Maxfield.
18
19         The Grid Layout feature has been enabled by default for almost a
20         year, so I think it's time to remove the runtime flag and the
21
22         * WebView/WebPreferenceKeysPrivate.h:
23         * WebView/WebPreferences.mm:
24         (+[WebPreferences initialize]):
25         * WebView/WebPreferencesPrivate.h:
26         * WebView/WebView.mm:
27         (-[WebView _preferencesChanged:]):
28
29 2018-03-12  Antoine Quint  <graouts@apple.com>
30
31         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
32         https://bugs.webkit.org/show_bug.cgi?id=183504
33         <rdar://problem/38372965>
34
35         Reviewed by Dean Jackson and Jon Lee.
36
37         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
38         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
39
40         * WebView/WebPreferenceKeysPrivate.h:
41         * WebView/WebPreferences.mm:
42         (+[WebPreferences initialize]):
43         (-[WebPreferences setModernMediaControlsEnabled:]):
44         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
45         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
46         * WebView/WebPreferencesPrivate.h:
47         * WebView/WebView.mm:
48         (-[WebView _preferencesChanged:]):
49
50 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
51
52         Media query for default appearance
53         https://bugs.webkit.org/show_bug.cgi?id=183539
54         <rdar://problem/38326388>
55
56         Reviewed by Tim Horton.
57
58         Write a media query to evaluate appearance.
59
60         * WebView/WebView.mm:
61         (-[WebView _commonInitializationWithFrameName:groupName:]):
62         (-[WebView _setUseSystemAppearance:]):
63
64 2018-03-09  Andy Estes  <aestes@apple.com>
65
66         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
67         https://bugs.webkit.org/show_bug.cgi?id=183489
68         <rdar://problem/38267517>
69
70         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
71         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
72         to issue a sandbox extension for this directory, but for security reasons App Sandbox
73         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
74         block with a nil error and a valid file URL, but no file will actually exist at that URL.
75
76         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
77         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
78         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
79         drop destination.
80
81         Reviewed by Wenson Hsieh.
82
83         * WebView/WebView.mm:
84         (-[WebView performDragOperation:]):
85
86 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
87
88         Allow WebViews to disable system appearance
89         https://bugs.webkit.org/show_bug.cgi?id=183418
90         <rdar://problem/36975642>
91
92         Reviewed by Tim Horton.
93
94         Allow webviews to choose whether or not to follow the default system appearance.
95
96         * WebView/WebView.mm:
97         (-[WebView _setUseSystemAppearance:]):
98         (-[WebView _useSystemAppearance]):
99         * WebView/WebViewPrivate.h:
100
101 2018-03-08  Youenn Fablet  <youenn@apple.com>
102
103         libwebrtc update broke internal builds
104         https://bugs.webkit.org/show_bug.cgi?id=183454
105
106         Reviewed by Eric Carlson.
107
108         * Configurations/WebKitLegacy.xcconfig:
109
110 2018-03-08  Chris Dumez  <cdumez@apple.com>
111
112         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
113         https://bugs.webkit.org/show_bug.cgi?id=183455
114         <rdar://problem/38191749>
115
116         Reviewed by Youenn Fablet.
117
118         Add a null check for the page as we have evidence from crashes that it can be null.
119         Other functions in WebFrameNetworkingContext already null check the page as well,
120         not just the frame so this is consistent.
121
122         * WebCoreSupport/WebFrameNetworkingContext.mm:
123         (WebFrameNetworkingContext::storageSession const):
124
125 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
126
127         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
128         https://bugs.webkit.org/show_bug.cgi?id=183429
129
130         Reviewed by Mark Lam.
131
132         * DOM/DOM.mm:
133         (+[DOMNode _nodeFromJSWrapper:]):
134         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
135         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
136         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
137         * Plugins/Hosted/ProxyInstance.mm:
138         (WebKit::ProxyInstance::invokeMethod):
139         * WebView/WebView.mm:
140         (aeDescFromJSValue):
141
142 2018-03-08  Tim Horton  <timothy_horton@apple.com>
143
144         Stop linking ApplicationServices directly
145         https://bugs.webkit.org/show_bug.cgi?id=182867
146         <rdar://problem/38252142>
147
148         Reviewed by Alex Christensen.
149
150         The frameworks that we use that live inside ApplicationServices
151         have mostly moved out, so import them directly.
152
153         * Carbon/CarbonUtils.h:
154         * WebKitPrefix.h:
155         * WebView/WebHTMLView.mm:
156         * WebView/WebPDFView.mm:
157
158 2018-03-07  Tim Horton  <timothy_horton@apple.com>
159
160         Sort and separate FeatureDefines.xcconfig
161         https://bugs.webkit.org/show_bug.cgi?id=183427
162
163         Reviewed by Dan Bernstein.
164
165         * Configurations/FeatureDefines.xcconfig:
166         Sort and split FeatureDefines into paragraphs
167         (to make it easier to sort later).
168
169 2018-03-07  Youenn Fablet  <youenn@apple.com>
170
171         Match unsupported plugins based on domains and not origin
172         https://bugs.webkit.org/show_bug.cgi?id=183384
173
174         Reviewed by Chris Dumez.
175
176         * WebCoreSupport/WebPluginInfoProvider.h:
177         * WebCoreSupport/WebPluginInfoProvider.mm:
178         (WebPluginInfoProvider::getPluginInfo):
179         (WebPluginInfoProvider::getWebVisiblePluginInfo):
180
181 2018-03-05  Andy Estes  <aestes@apple.com>
182
183         [Mac] Teach WebCore::Pasteboard about file promise drags
184         https://bugs.webkit.org/show_bug.cgi?id=183314
185         <rdar://problem/38105493>
186
187         Reviewed by Darin Adler.
188
189         Added a FIXME comment.
190
191         * WebView/WebView.mm:
192         (-[WebView performDragOperation:]):
193
194 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
195
196         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
197         https://bugs.webkit.org/show_bug.cgi?id=183312
198
199         Reviewed by Mark Lam.
200
201         Remove wtf/CurrentTime.h include pragma.
202
203         * WebView/WebFrame.mm:
204         * WebView/WebPDFView.mm:
205
206 2018-03-04  Tim Horton  <timothy_horton@apple.com>
207
208         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
209         https://bugs.webkit.org/show_bug.cgi?id=183283
210         <rdar://problem/38062148>
211
212         Reviewed by Sam Weinig.
213
214         * Configurations/FeatureDefines.xcconfig:
215
216 2018-02-28  Alex Christensen  <achristensen@webkit.org>
217
218         Reduce use of NetworkingContext in WebKit
219         https://bugs.webkit.org/show_bug.cgi?id=183213
220
221         Reviewed by Brady Eidson.
222
223         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
224         (WebKit::NetscapePluginInstanceProxy::getProxy):
225         * Plugins/WebNetscapePluginView.mm:
226         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
227
228 2018-02-17  Darin Adler  <darin@apple.com>
229
230         Prepare for ExtendedColor changes (first step)
231         https://bugs.webkit.org/show_bug.cgi?id=182904
232
233         Reviewed by Sam Weinig.
234
235         * Misc/WebKitNSStringExtras.mm:
236         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
237
238 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
239
240         Remove currentTime() / currentTimeMS()
241         https://bugs.webkit.org/show_bug.cgi?id=183052
242
243         Reviewed by Mark Lam.
244
245         * WebCoreSupport/WebFrameLoaderClient.h:
246         * WebCoreSupport/WebFrameLoaderClient.mm:
247         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
248
249 2018-02-16  Youenn Fablet  <youenn@apple.com>
250
251         Allow specifying which plug-ins are supported
252         https://bugs.webkit.org/show_bug.cgi?id=182748
253
254         Reviewed by Chris Dumez.
255
256         * WebCoreSupport/WebPluginInfoProvider.h:
257         * WebCoreSupport/WebPluginInfoProvider.mm:
258         (WebPluginInfoProvider::getPluginInfo):
259         (WebPluginInfoProvider::getWebVisiblePluginInfo):
260
261 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
262
263         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
264         https://bugs.webkit.org/show_bug.cgi?id=182882
265         <rdar://problem/35672661>
266
267         Reviewed by Dan Bernstein.
268
269         Make sure the smart pointer hold the collection of subviews lives at least as
270         long as the loop using it.
271
272         * WebView/WebHTMLView.mm:
273         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
274
275 2018-02-14  Daniel Bates  <dabates@apple.com>
276
277         Disallow cross-origin subresources from asking for credentials
278         https://bugs.webkit.org/show_bug.cgi?id=182579
279         <rdar://problem/36162271>
280
281         Reviewed by Andy Estes.
282
283         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
284         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
285
286         * WebView/WebPreferenceKeysPrivate.h:
287         * WebView/WebPreferences.mm:
288         (+[WebPreferences initialize]):
289         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
290         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
291         * WebView/WebPreferencesPrivate.h:
292         * WebView/WebView.mm:
293         (-[WebView _preferencesChanged:]):
294
295 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
296
297         Remove ForwardingHeaders directory from WebKitLegacy/mac.
298         https://bugs.webkit.org/show_bug.cgi?id=182738
299
300         Reviewed by Darin Adler.
301
302         * ForwardingHeaders/collector/handles/Global.h: Removed.
303         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
304         * ForwardingHeaders/runtime/Completion.h: Removed.
305         * ForwardingHeaders/runtime/Error.h: Removed.
306         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
307         * ForwardingHeaders/runtime/JSFunction.h: Removed.
308         * ForwardingHeaders/runtime/JSLock.h: Removed.
309         * ForwardingHeaders/runtime/JSObject.h: Removed.
310         * ForwardingHeaders/runtime/JSString.h: Removed.
311         * ForwardingHeaders/runtime/Protect.h: Removed.
312         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
313
314 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
315
316         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
317         https://bugs.webkit.org/show_bug.cgi?id=182641
318
319         Reviewed by Dan Bernstein.
320
321         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
322         https://trac.webkit.org/changeset/228308.
323
324         * WebView/WebVideoFullscreenController.h:
325         * WebView/WebVideoFullscreenHUDWindowController.mm:
326         * WebView/WebWindowAnimation.h:
327         * WebView/WebWindowAnimation.mm:
328         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
329         (WebCore::scaledRect): Deleted.
330         (WebCore::squaredDistance): Deleted.
331
332 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
333
334         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
335
336         * WebView/WebWindowAnimation.mm:
337         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
338
339 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
340
341         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
342         https://bugs.webkit.org/show_bug.cgi?id=182615
343
344         Reviewed by Eric Carlson.
345
346         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
347         Ideally, we should not reference NSApp in WebCore.
348
349         * WebView/WebFullScreenController.mm:
350         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
351         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
352         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
353         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
354         * WebView/WebView.mm:
355         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
356         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
357
358 2018-01-13  Darin Adler  <darin@apple.com>
359
360         Event improvements
361         https://bugs.webkit.org/show_bug.cgi?id=179591
362
363         Reviewed by Chris Dumez.
364
365         * DOM/DOMWheelEvent.mm:
366         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
367         Call initWebKitWheelEvent.
368
369         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
370         * WebCoreSupport/WebInspectorClient.mm: Ditto.
371         * WebView/WebFrame.mm: Ditto.
372
373         * WebView/WebHTMLView.mm:
374         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
375         underlyingPlatformEvent.
376         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
377
378         * WebView/WebScriptWorld.mm:
379         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
380
381         * WebView/WebView.mm: Removed include of ScriptValue.h.
382
383 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
384
385         Remove WebCore/ForwardingHeaders directory
386         https://bugs.webkit.org/show_bug.cgi?id=182347
387
388         Reviewed by Keith Miller.
389
390         * Carbon/CarbonWindowAdapter.mm:
391         * DOM/WebDOMOperations.mm:
392         * History/WebBackForwardList.mm:
393         * History/WebHistoryItem.mm:
394         * Misc/WebCache.mm:
395         * Misc/WebElementDictionary.mm:
396         * Misc/WebIconDatabase.mm:
397         * Misc/WebStringTruncator.mm:
398         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
399         * Plugins/Hosted/ProxyInstance.mm:
400         * Plugins/Hosted/ProxyRuntimeObject.mm:
401         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
402         * Plugins/WebBaseNetscapePluginView.mm:
403         * Plugins/WebBasePluginPackage.mm:
404         * Plugins/WebNetscapePluginStream.mm:
405         * Plugins/WebNetscapePluginView.mm:
406         * Plugins/WebPluginController.mm:
407         * WebCoreSupport/WebEditorClient.mm:
408         * WebCoreSupport/WebFrameLoaderClient.mm:
409         * WebCoreSupport/WebInspectorClient.h:
410         * WebCoreSupport/WebInspectorClient.mm:
411         * WebView/WebDataSource.mm:
412         * WebView/WebFrame.mm:
413         * WebView/WebHTMLRepresentation.mm:
414         * WebView/WebHTMLView.mm:
415         * WebView/WebPreferences.mm:
416         * WebView/WebScriptDebugDelegate.mm:
417         * WebView/WebScriptDebugger.h:
418         * WebView/WebTextIterator.mm:
419         * WebView/WebView.mm:
420         * WebView/WebViewData.mm:
421
422 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
423
424         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
425         https://bugs.webkit.org/show_bug.cgi?id=182312
426
427         Reviewed by Michael Catanzaro.
428
429         * WebKitPrefix.h:
430
431 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
432
433         [WebAuthN] Add a compile-time feature flag
434         https://bugs.webkit.org/show_bug.cgi?id=182211
435         <rdar://problem/36936365>
436
437         Reviewed by Brent Fulgham.
438
439         * Configurations/FeatureDefines.xcconfig:
440
441 2018-01-27  Dan Bernstein  <mitz@apple.com>
442
443         HaveInternalSDK includes should be "#include?"
444         https://bugs.webkit.org/show_bug.cgi?id=179670
445
446         * Configurations/Base.xcconfig:
447
448 2018-01-24  Alex Christensen  <achristensen@webkit.org>
449
450         Remove unused QTKit preference
451         https://bugs.webkit.org/show_bug.cgi?id=181968
452
453         Reviewed by Alexey Proskuryakov.
454
455         * WebView/WebPreferenceKeysPrivate.h:
456         * WebView/WebPreferences.mm:
457         (+[WebPreferences initialize]):
458         (-[WebPreferences setQTKitEnabled:]): Deleted.
459         (-[WebPreferences isQTKitEnabled]): Deleted.
460         * WebView/WebPreferencesPrivate.h:
461         * WebView/WebView.mm:
462         (-[WebView _preferencesChanged:]):
463
464 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
465
466         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
467         https://bugs.webkit.org/show_bug.cgi?id=182037
468         <rdar://problem/36747812>
469
470         Reviewed by Ryosuke Niwa.
471
472         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
473         for more details.
474
475         * WebView/WebHTMLRepresentation.mm:
476         (-[WebHTMLRepresentation elementWithName:inForm:]):
477         (-[WebHTMLRepresentation controlsInForm:]):
478
479 2018-01-23  Alex Christensen  <achristensen@webkit.org>
480
481         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
482         https://bugs.webkit.org/show_bug.cgi?id=181961
483
484         Reviewed by Michael Catanzaro.
485
486         * WebView/WebPreferences.mm:
487
488 2018-01-23  Commit Queue  <commit-queue@webkit.org>
489
490         Unreviewed, rolling out r227437.
491         https://bugs.webkit.org/show_bug.cgi?id=182011
492
493         broke build (Requested by alexchristensen on #webkit).
494
495         Reverted changeset:
496
497         "Remove unused QTKit preference"
498         https://bugs.webkit.org/show_bug.cgi?id=181968
499         https://trac.webkit.org/changeset/227437
500
501 2018-01-23  Alex Christensen  <achristensen@webkit.org>
502
503         Remove unused QTKit preference
504         https://bugs.webkit.org/show_bug.cgi?id=181968
505
506         Reviewed by Alexey Proskuryakov.
507
508         * WebView/WebPreferenceKeysPrivate.h:
509         * WebView/WebPreferences.mm:
510         (+[WebPreferences initialize]):
511         (-[WebPreferences setQTKitEnabled:]): Deleted.
512         (-[WebPreferences isQTKitEnabled]): Deleted.
513         * WebView/WebPreferencesPrivate.h:
514         * WebView/WebView.mm:
515         (-[WebView _preferencesChanged:]):
516
517 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
518
519         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
520         https://bugs.webkit.org/show_bug.cgi?id=181960
521         <rdar://problem/36431678>
522
523         Reviewed by Tim Horton.
524
525         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
526         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
527         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
528
529         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
530         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
531         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
532
533         * WebView/WebView.mm:
534         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
535
536 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
537
538         Turning off custom pasteboard data doesn't actually turn it off in WK2
539         https://bugs.webkit.org/show_bug.cgi?id=181920
540         <rdar://problem/36686429>
541
542         Reviewed by Wenson Hsieh.
543
544         Always disable custom pasteboard data in WebKit1. See r226156 for details.
545
546         * WebView/WebPreferences.mm:
547         (+[WebPreferences initialize]):
548         * WebView/WebView.mm:
549         (-[WebView _preferencesChanged:]):
550
551 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
552
553         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
554         https://bugs.webkit.org/show_bug.cgi?id=181918
555
556         Reviewed by Tim Horton.
557
558         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
559
560         * Configurations/FeatureDefines.xcconfig:
561
562 2018-01-20  Andy Estes  <aestes@apple.com>
563
564         [Apple Pay] Stop eagerly loading PassKit.framework
565         https://bugs.webkit.org/show_bug.cgi?id=181911
566         <rdar://problem/36555369>
567
568         Reviewed by Tim Horton.
569
570         * WebCoreSupport/WebPaymentCoordinatorClient.h:
571         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
572         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
573
574         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
575
576 2018-01-19  Dean Jackson  <dino@apple.com>
577
578         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
579         https://bugs.webkit.org/show_bug.cgi?id=181817
580         <rdar://problem/35274055>
581
582         Reviewed by Simon Fraser.
583
584         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
585
586         * Misc/WebKitVersionChecks.h:
587         * WebView/WebView.mm:
588         (-[WebView _commonInitializationWithFrameName:groupName:]):
589
590 2018-01-19  Alex Christensen  <achristensen@webkit.org>
591
592         Remove unused WebViewPrivate _allowCookies
593         https://bugs.webkit.org/show_bug.cgi?id=181812
594
595         Reviewed by Tim Horton.
596
597         * WebView/WebView.mm:
598         (+[WebView _setAllowCookies:]): Deleted.
599         (+[WebView _allowCookies]): Deleted.
600         * WebView/WebViewPrivate.h:
601
602 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
603
604         Build fix, remove a call to -[NSWindow setOneShot:]
605         https://bugs.webkit.org/show_bug.cgi?id=181809
606
607         Reviewed by Tim Horton.
608
609         * WebView/WebTextCompletionController.mm:
610         (-[WebTextCompletionController _buildUI]):
611
612 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
613
614         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
615
616         * Carbon/HIWebView.mm:
617         (overrideCGContext):
618         (restoreCGContext):
619
620 2018-01-18  Dan Bernstein  <mitz@apple.com>
621
622         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
623         https://bugs.webkit.org/show_bug.cgi?id=181803
624
625         Reviewed by Tim Horton.
626
627         * Configurations/Base.xcconfig: Updated.
628         * Configurations/DebugRelease.xcconfig: Ditto.
629         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
630         * Configurations/Version.xcconfig: Updated.
631         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
632           useful for defining settings that depend on the target macOS version.
633
634 2018-01-17  Youenn Fablet  <youenn@apple.com>
635
636         Put fetch Request.keepalive behind a runtime flag
637         https://bugs.webkit.org/show_bug.cgi?id=181592
638
639         Reviewed by Chris Dumez.
640
641         * WebView/WebPreferenceKeysPrivate.h:
642         * WebView/WebPreferences.mm:
643         (+[WebPreferences initialize]):
644         (-[WebPreferences fetchAPIKeepAliveEnabled]):
645         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
646         * WebView/WebPreferencesPrivate.h:
647         * WebView/WebView.mm:
648         (-[WebView _preferencesChanged:]):
649
650 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
651
652         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
653         https://bugs.webkit.org/show_bug.cgi?id=181637
654         <rdar://problem/36508471>
655
656         Reviewed by Tim Horton.
657
658         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
659
660         * WebCoreSupport/WebEditorClient.h:
661         * WebCoreSupport/WebEditorClient.mm:
662         (WebEditorClient::replacementURLForResource):
663
664 2018-01-11  Keith Miller  <keith_miller@apple.com>
665
666         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
667         https://bugs.webkit.org/show_bug.cgi?id=181573
668
669         Reviewed by Simon Fraser.
670
671         * Configurations/FeatureDefines.xcconfig:
672
673 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
674
675         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
676         https://bugs.webkit.org/show_bug.cgi?id=181497
677
678         Reviewed by Tim Horton.
679
680         See other ChangeLogs for more detail.
681
682         * WebCoreSupport/WebDragClient.h:
683
684 2018-01-11  Tim Horton  <timothy_horton@apple.com>
685
686         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
687         https://bugs.webkit.org/show_bug.cgi?id=181523
688         <rdar://problem/28959131>
689
690         Reviewed by Alex Christensen.
691
692         * WebView/WebImmediateActionController.mm:
693         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
694         Apply the change made in r216652 to WebKit1's immediate action controller.
695
696         Speculative (but successful in WebKit2) fix for non-reproducible crash when
697         the startContainer of the range is in an anonymous node.
698
699 2018-01-11  Youenn Fablet  <youenn@apple.com>
700
701         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
702         https://bugs.webkit.org/show_bug.cgi?id=181480
703
704         Reviewed by Eric Carlson.
705
706         * WebView/WebPreferences.mm:
707         (+[WebPreferences initialize]):
708
709 2018-01-08  David Kilzer  <ddkilzer@apple.com>
710
711         Fix check-webkit-style issues with WebNSDataExtras.mm
712         <https://webkit.org/b/181369>
713
714         Reviewed by Alex Christensen.
715
716         * Misc/WebNSDataExtras.mm:
717         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
718         (-[NSData _webkit_guessedMIMETypeForXML]):
719         (-[NSData _webkit_guessedMIMEType]):
720         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
721         (_findEOL):
722         (-[NSData _webkit_parseRFC822HeaderFields]):
723         (-[NSData _web_locationAfterFirstBlankLine]):
724         - Fix all the check-webkit-style warnings.
725
726 2018-01-08  David Kilzer  <ddkilzer@apple.com>
727
728         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
729         <https://webkit.org/b/181256>
730         <rdar://problem/36281730>
731
732         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
733         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
734         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
735           to avoid warnings from casting CFStringRef to NPNSString*.
736           Note that CFMutableStringRef is the same as CFStringRef
737           without the const modifier, hence its use in the const_cast<>
738           above.
739
740 2018-01-08  David Kilzer  <ddkilzer@apple.com>
741
742         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
743         <https://webkit.org/b/181256>
744         <rdar://problem/36281730>
745
746         * Carbon/HIWebView.mm:
747         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
748         checked_cf_cast<CFRunLoopRef>() to fix warning.
749
750 2018-01-07  David Kilzer  <ddkilzer@apple.com>
751
752         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
753         <https://webkit.org/b/181256>
754         <rdar://problem/36281730>
755
756         Reviewed by Darin Adler.
757
758         * Carbon/CarbonUtils.m:
759         (PoolCleaner):
760         - Use #pragmas to ignore -Wcast-qual warnings when using a
761           C-style cast from CFTypeRef to CFRunloopRef.
762         * Carbon/CarbonWindowFrame.m:
763         (-[CarbonWindowFrame title]):
764         - Use #pragmas to ignore -Wcast-qual warnings when using a
765           C-style cast from CFStringRef to NSString *.
766         * Carbon/HIViewAdapter.m:
767         (+[HIViewAdapter getHIViewForNSView:]):
768         - Use #pragmas to ignore -Wcast-qual warnings when using a
769           C-style cast from CFTypeRef to HIViewRef.
770         * Configurations/Base.xcconfig:
771         (WARNING_CFLAGS): Add -Wcast-qual.
772         * Misc/WebElementDictionary.mm:
773         (-[WebElementDictionary objectForKey:]):
774         - Use static_cast<SEL>(const_cast<void*>()) to fix
775           warning.
776         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
777         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
778         (-[NSData _webkit_guessedMIMETypeForXML]):
779         (-[NSData _webkit_guessedMIMEType]):
780         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
781         (_findEOL):
782         (-[NSData _webkit_parseRFC822HeaderFields]):
783         (-[NSData _web_startsWithBlankLine]):
784         (-[NSData _web_locationAfterFirstBlankLine]):
785         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
786           type to Objective-C++.  This fixes the warnings about
787           discarding the `const` modifier when casing from CFStringRef
788           to NSString * because in older clang versions, -Wcast-qual was
789           completely broken when compiling C++ and Objective-C++ source
790           files.  In newer clang versions, discarding the `const`
791           modifier for toll-free bridged types is ignored when compiling
792           Objective-C++ source.
793         - Update copyright and license header.
794         - Use reinterpret_cast<> and static_cast<> to fix warnings
795           unrelated to (NSString *) C-style casts.
796         - Replace use of MIN() macro with std::min<> template functions.
797         - Fix location of `*` for local variables modified above.
798         * Plugins/Hosted/NetscapePluginHostManager.mm:
799         (WebKit::NetscapePluginHostManager::spawnPluginHost):
800         (WebKit::NetscapePluginHostManager::initializeVendorPort):
801         (WebKit::NetscapePluginHostManager::instantiatePlugin):
802         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
803           warnings.
804         * Plugins/Hosted/NetscapePluginHostProxy.mm:
805         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
806         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
807           to fix warning.
808         * Plugins/Hosted/ProxyInstance.mm:
809         (WebKit::ProxyInstance::invoke):
810         - Use static_cast<char*>(const_cast<void*>()) to fix
811           warning when using -[NSData bytes].
812         (WebKit::ProxyInstance::fieldValue const):
813         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
814           to fix warning when using CFDataGetBytePtr().
815         * Plugins/Hosted/WebTextInputWindowController.m:
816         (-[WebTextInputPanel _interpretKeyEvent:string:]):
817         - Use #pragma to ignore -Wcast-qual warning since there
818           is not a good way to avoid this warning in Objective-C.
819         * Plugins/WebNetscapePluginStream.mm:
820         (WebNetscapePluginStream::deliverData):
821         - Use const_cast<void*>() to fix warning when using
822           -[NSData bytes].
823         * Plugins/WebNetscapePluginView.mm:
824         (-[WebNetscapePluginView _createPlugin]):
825         - Change C-style cast to const_cast<char*>() to fix
826           warning.
827         * WebCoreSupport/WebChromeClient.mm:
828         (WebChromeClient::wrapCryptoKey const):
829         (WebChromeClient::unwrapCryptoKey const):
830         - Change C-style cast to
831           static_cast<uint8_t*>(const_cast<void*>() to fix
832           warning.
833         * WebView/WebPDFView.mm:
834         (_applicationInfoForMIMEType):
835         - Change local variable type from 'NSURL *' to
836           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
837           when calling -[NSURL path].
838
839 2018-01-05  Dan Bernstein  <mitz@apple.com>
840
841         Fixed the build following AppKit API deprecations in a recent SDKs
842
843         * WebView/WebFullScreenController.mm:
844         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
845         (-[WebFullScreenController exitFullScreen]): Ditto.
846         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
847         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
848         * WebView/WebHTMLView.mm:
849         (-[WebHTMLView drawRect:]): Ditto.
850         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
851         (-[WebHTMLView knowsPageRange:]): Ditto.
852         * WebView/WebView.mm:
853         (LayerFlushController::flushLayers): Ditto.
854
855 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
856
857         [Attachment Support] Create attachment elements when dropping files on iOS
858         https://bugs.webkit.org/show_bug.cgi?id=181192
859         <rdar://problem/36280945>
860
861         Reviewed by Tim Horton.
862
863         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
864
865         * WebCoreSupport/WebPlatformStrategies.h:
866         * WebCoreSupport/WebPlatformStrategies.mm:
867         (WebPlatformStrategies::informationForItemAtIndex):
868         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
869
870 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
871
872         [Attachment Support] Add plumbing for starting a drag with promised blob data
873         https://bugs.webkit.org/show_bug.cgi?id=181201
874
875         Reviewed by Tim Horton.
876
877         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
878
879         * WebCoreSupport/WebDragClient.h:
880
881 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
882
883         Add a WebAuthentication runtime feature flag
884         https://bugs.webkit.org/show_bug.cgi?id=181220
885         <rdar://problem/36055305>
886
887         Reviewed by Brent Fulgham.
888
889         Renames the CredentialManagement runtime feature flag into WebAuthentication.
890
891         * WebView/WebPreferenceKeysPrivate.h:
892         * WebView/WebPreferences.mm:
893         (+[WebPreferences initialize]):
894         (-[WebPreferences webAuthenticationEnabled]):
895         (-[WebPreferences setWebAuthenticationEnabled:]):
896         (-[WebPreferences credentialManagementEnabled]): Deleted.
897         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
898         * WebView/WebPreferencesPrivate.h:
899         * WebView/WebView.mm:
900         (-[WebView _preferencesChanged:]):
901
902 2017-12-22  Jeff Miller  <jeffm@apple.com>
903
904         Update user-visible copyright strings to include 2018
905         https://bugs.webkit.org/show_bug.cgi?id=181141
906
907         Reviewed by Dan Bernstein.
908
909         * Info.plist:
910
911 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
912
913         [Attachment Support] Remove current macOS support for dragging file-backed attachments
914         https://bugs.webkit.org/show_bug.cgi?id=181188
915
916         Reviewed by Dan Bernstein.
917
918         See WebCore/ChangeLog for more detail.
919
920         * WebCoreSupport/WebDragClient.h:
921         * WebCoreSupport/WebDragClient.mm:
922         (WebDragClient::declareAndWriteAttachment): Deleted.
923         * WebView/WebHTMLView.mm:
924         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
925
926 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
927
928         Unreviewed, continue to fix build failures due to AppKit API deprecation
929
930         Wraps more code in -Wdeprecated-declarations.
931
932         * Carbon/HIWebView.mm:
933         (overrideCGContext):
934
935 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
936
937         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
938
939         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
940
941         * Carbon/CarbonWindowAdapter.mm:
942         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
943         * Plugins/WebNetscapePluginView.mm:
944         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
945         (-[WebNetscapePluginView sendDrawRectEvent:]):
946         (-[WebNetscapePluginView drawRect:]):
947
948 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
949
950         Fix build failures due to using deprecated AppKit symbols
951         https://bugs.webkit.org/show_bug.cgi?id=181110
952         <rdar://problem/36162865>
953
954         Reviewed by Dan Bernstein and Tim Horton.
955
956         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
957
958         * Misc/WebKitNSStringExtras.mm:
959         (-[NSString _web_drawAtPoint:font:textColor:]):
960         * Misc/WebNSPasteboardExtras.h:
961         * Misc/WebNSPasteboardExtras.mm:
962         (+[NSPasteboard _web_writableTypesForURL]):
963         (_createWritableTypesForImageWithoutArchive):
964         (_createWritableTypesForImageWithArchive):
965         (+[NSPasteboard _web_dragTypesForURL]):
966         (-[NSPasteboard _web_bestURL]):
967         (-[NSPasteboard _web_writeURL:andTitle:types:]):
968         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
969         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
970         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
971         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
972         * Panels/WebAuthenticationPanel.m:
973         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
974         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
975         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
976         (-[WebHostedNetscapePluginView drawRect:]):
977         * WebInspector/WebNodeHighlightView.mm:
978         (-[WebNodeHighlightView drawRect:]):
979         * WebView/WebFrame.mm:
980         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
981         (-[WebFrame _drawRect:contentsOnly:]):
982         * WebView/WebHTMLView.mm:
983         (kit):
984         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
985         (-[WebHTMLView _plainTextFromPasteboard:]):
986         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
987         (+[WebHTMLView _insertablePasteboardTypes]):
988         (+[WebHTMLView _selectionPasteboardTypes]):
989         (-[WebHTMLView pasteboard:provideDataForType:]):
990         (-[WebHTMLView _writeSelectionToPasteboard:]):
991         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
992         (-[WebHTMLView validRequestorForSendType:returnType:]):
993         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
994         (createMenuItem):
995         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
996         (-[WebHTMLView _colorAsString:]):
997         (-[WebHTMLView copyFont:]):
998         * WebView/WebPDFView.mm:
999         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1000         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1001         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1002         (-[WebPDFView pasteboardTypesForSelection]):
1003         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1004         * WebView/WebView.h:
1005         * WebView/WebView.mm:
1006         (-[WebView performDragOperation:]):
1007         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1008         (-[WebView _searchWithGoogleFromMenu:]):
1009
1010 2017-12-21  Youenn Fablet  <youenn@apple.com>
1011
1012         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1013         https://bugs.webkit.org/show_bug.cgi?id=181000
1014
1015         Reviewed by Chris Dumez.
1016
1017         * Misc/WebCache.mm:
1018         (+[WebCache addImageToCache:forURL:forFrame:]):
1019
1020 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1021
1022         Update FULLSCREEN_API feature defines.
1023         https://bugs.webkit.org/show_bug.cgi?id=181015
1024
1025         Reviewed by Tim Horton.
1026
1027         Change enabled iphone sdk for FULLSCREEN_API.
1028
1029         * Configurations/FeatureDefines.xcconfig:
1030
1031 2017-12-21  Jer Noble  <jer.noble@apple.com>
1032
1033         Add initial DOM support for Media Capabilities
1034         https://bugs.webkit.org/show_bug.cgi?id=181064
1035
1036         Reviewed by Eric Carlson.
1037
1038         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1039
1040         * WebView/WebPreferenceKeysPrivate.h:
1041         * WebView/WebPreferences.mm:
1042         (+[WebPreferences initialize]):
1043         (-[WebPreferences mediaCapabilitiesEnabled]):
1044         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1045         * WebView/WebPreferencesPrivate.h:
1046         * WebView/WebView.mm:
1047         (-[WebView _preferencesChanged:]):
1048
1049 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1050
1051         Enable picture-in-picture from inline element on suspend.
1052         https://bugs.webkit.org/show_bug.cgi?id=180942
1053         rdar://problem/34745234
1054
1055         Reviewed by Jer Noble.
1056
1057         Update signature of enterVideoFullscreenForVideoElement().
1058
1059         * WebCoreSupport/WebChromeClient.h:
1060         * WebCoreSupport/WebChromeClient.mm:
1061         (WebChromeClient::enterVideoFullscreenForVideoElement):
1062
1063 2017-12-20  Daniel Bates  <dabates@apple.com>
1064
1065         Remove Alternative Presentation Button
1066         https://bugs.webkit.org/show_bug.cgi?id=180500
1067         <rdar://problem/35891047>
1068
1069         Reviewed by Simon Fraser.
1070
1071         We no longer need the alternative presentation button.
1072
1073         * Configurations/FeatureDefines.xcconfig:
1074
1075 2017-12-19  Jer Noble  <jer.noble@apple.com>
1076
1077         Playing media elements which call "pause(); play()" will have the play promise rejected.
1078         https://bugs.webkit.org/show_bug.cgi?id=180781
1079         <rdar://problem/33191377>
1080
1081         Reviewed by Eric Carlson.
1082
1083         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1084
1085         * WebView/WebView.mm:
1086         (shouldRequireUserGestureToLoadVideo):
1087
1088 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1091         https://bugs.webkit.org/show_bug.cgi?id=180977
1092
1093         Reviewed by Tim Horton.
1094
1095         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1096         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1097         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1098
1099         * WebCoreSupport/WebEditorClient.mm:
1100         (attributesForAttributedStringConversion):
1101         * WebView/WebHTMLView.mm:
1102         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1103
1104 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1105
1106         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1107
1108         Attempt to fix the following warnings:
1109
1110             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1111
1112         For the following instance variables:
1113
1114             _borderView
1115             _contentView
1116             _frame
1117             _wFlags
1118
1119         * Carbon/CarbonWindowAdapter.mm:
1120         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1121         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1122         (-[CarbonWindowAdapter _termWindowIfOwner]):
1123         (-[CarbonWindowAdapter _windowMovedToRect:]):
1124         (-[CarbonWindowAdapter setContentView:]):
1125         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1126         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1127
1128 2017-12-16  Dan Bernstein  <mitz@apple.com>
1129
1130         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1131         https://bugs.webkit.org/show_bug.cgi?id=180613
1132         <rdar://problem/35946124>
1133
1134         Reviewed by Geoff Garen.
1135
1136         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1137           clients.
1138         * WebView/WebDynamicScrollBarsView.h: Ditto.
1139         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1140
1141 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1142
1143         Enable -Wstrict-prototypes for WebKit
1144         <https://webkit.org/b/180757>
1145         <rdar://problem/36024132>
1146
1147         Rubber-stamped by Joseph Pecoraro.
1148
1149         * Configurations/Base.xcconfig:
1150         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1151
1152 2017-12-14  John Wilander  <wilander@apple.com>
1153
1154         Storage Access API: Implement frame-specific access in the document.cookie layer
1155         https://bugs.webkit.org/show_bug.cgi?id=180682
1156         <rdar://problem/35982257>
1157
1158         Reviewed by Alex Christensen.
1159
1160         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1161         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1162         CookiesStrategy::getRawCookies() now take optional parameters for
1163         frameID and pageID to allow frame-specific scoping of cookies.
1164
1165         This change makes the return values of FrameLoaderClient::frameID()
1166         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1167         WebCore can call those getters and get the right return values in
1168         WebKit and std:nullopt in WebKitLegacy.
1169
1170         * WebCoreSupport/WebFrameLoaderClient.h:
1171         * WebCoreSupport/WebFrameLoaderClient.mm:
1172         (WebFrameLoaderClient::pageID const):
1173         (WebFrameLoaderClient::frameID const):
1174         * WebCoreSupport/WebPlatformStrategies.h:
1175         * WebCoreSupport/WebPlatformStrategies.mm:
1176         (WebPlatformStrategies::cookiesForDOM):
1177         (WebPlatformStrategies::setCookiesFromDOM):
1178         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1179         (WebPlatformStrategies::getRawCookies):
1180
1181 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1182
1183         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1184         https://bugs.webkit.org/show_bug.cgi?id=180689
1185
1186         Reviewed by Tim Horton.
1187
1188         Use sRGBColorSpaceRef() from WebCore.
1189
1190         * WebView/WebHTMLView.mm:
1191         (imageFromRect):
1192
1193 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1194
1195         Stop using deprecated target conditional for simulator builds
1196         https://bugs.webkit.org/show_bug.cgi?id=180662
1197         <rdar://problem/35136156>
1198
1199         Reviewed by Simon Fraser.
1200
1201         * postprocess-headers.sh:
1202
1203 2017-12-11  David Quesada  <david_quesada@apple.com>
1204
1205         Turn on ENABLE_APPLICATION_MANIFEST
1206         https://bugs.webkit.org/show_bug.cgi?id=180562
1207         rdar://problem/35924737
1208
1209         Reviewed by Geoffrey Garen.
1210
1211         * Configurations/FeatureDefines.xcconfig:
1212
1213 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1214
1215         Remove pthread_once in favor of dispatch_once
1216         https://bugs.webkit.org/show_bug.cgi?id=180591
1217
1218         Reviewed by Saam Barati.
1219
1220         * Misc/WebKitErrors.m:
1221         (+[NSError _registerWebKitErrors]):
1222         (registerErrors): Deleted.
1223         * Storage/WebStorageManager.mm:
1224         (+[WebStorageManager _storageDirectoryPath]):
1225         (initializeLocalStoragePath): Deleted.
1226
1227 2017-12-07  Darin Adler  <darin@apple.com>
1228
1229         Remove some unused code from WebKitLegacy
1230         https://bugs.webkit.org/show_bug.cgi?id=180567
1231
1232         Reviewed by Anders Carlsson.
1233
1234         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1235         macOS (back a few versions) and iOS and removed unused
1236         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1237         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1238         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1239         _webkit_stringByCollapsingNonPrintingCharacters,
1240         _webkit_stringByCollapsingWhitespaceCharacters,
1241         _web_stringWithData:textEncodingName:, and
1242         _webkit_localStorageDirectoryWithBundleIdentifier:.
1243
1244         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1245         this source file.
1246         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1247         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1248         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1249         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1250         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1251         handle font smoothing options.
1252         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1253         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1254         from header and made it a little clearer.
1255         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1256         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1257         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1258         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1259         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1260         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1261         implementation a bit and used whole words instead of abbreviations.
1262         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1263
1264         * Misc/WebNSFileManagerExtras.mm:
1265         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1266         filenameByFixingIllegalCharacters function from WebCore directly instead of
1267         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1268
1269         * Plugins/WebBaseNetscapePluginView.mm:
1270         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1271         string replacements instead of _web_stringByStrippingReturnCharacters
1272         and to use NSString methods instead of CFString functions.
1273
1274 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1275
1276         Ignore deprecation warnings.
1277
1278         * WebView/WebHTMLView.mm:
1279         (-[NSWindow _web_borderView]):
1280         (-[WebHTMLView _setAsideSubviews]):
1281         * WebView/WebView.mm:
1282         (-[WebView encodeWithCoder:]):
1283
1284 2017-12-02  Darin Adler  <darin@apple.com>
1285
1286         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1287         https://bugs.webkit.org/show_bug.cgi?id=180009
1288
1289         Reviewed by Alex Christensen.
1290
1291         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1292
1293         * Plugins/WebBaseNetscapePluginView.mm:
1294         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1295         of strcasecmp.
1296
1297         * WebView/WebPreferences.mm:
1298         (contains): Ditto. Also made this a template so it's easier to call on an array.
1299         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1300
1301 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1302
1303         Limit user agent versioning to an upper bound
1304         https://bugs.webkit.org/show_bug.cgi?id=180365
1305         <rdar://problem/34550617>
1306
1307         Reviewed by Joseph Pecoraro.
1308
1309         * WebView/WebView.mm:
1310         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1311         creating the User Agent string.
1312         (webKitBundleVersionString): Deleted.
1313
1314 2017-12-05  Andy Estes  <aestes@apple.com>
1315
1316         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1317         https://bugs.webkit.org/show_bug.cgi?id=180457
1318         <rdar://problem/35143007>
1319
1320         Reviewed by Tim Horton.
1321
1322         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1323         check for this macro during post-processing.
1324
1325         * postprocess-headers.sh:
1326
1327 2017-12-04  David Quesada  <david_quesada@apple.com>
1328
1329         Add a class for parsing application manifests
1330         https://bugs.webkit.org/show_bug.cgi?id=177973
1331         rdar://problem/34747949
1332
1333         Reviewed by Geoffrey Garen.
1334
1335         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1336
1337 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1338
1339         Make LegacyCustomProtocolManager optional for network process
1340         https://bugs.webkit.org/show_bug.cgi?id=176230
1341
1342         Reviewed by Alex Christensen.
1343
1344         * Configurations/FeatureDefines.xcconfig:
1345
1346 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1347
1348         Fix some NSOperationQueue leaks
1349         https://bugs.webkit.org/show_bug.cgi?id=180221
1350
1351         Reviewed by Wenson Hsieh.
1352
1353         * WebView/WebView.mm:
1354         (-[WebView performDragOperation:]):
1355
1356 2017-11-30  Darin Adler  <darin@apple.com>
1357
1358         [Mac] remove unneeded RetainPtr use introduced in r225142
1359         https://bugs.webkit.org/show_bug.cgi?id=180202
1360
1361         Reviewed by Tim Horton.
1362
1363         * WebView/WebImmediateActionController.mm:
1364         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1365         RetainPtr.
1366
1367 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1368
1369         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1370         https://bugs.webkit.org/show_bug.cgi?id=175595
1371
1372         Reviewed by Darin Adler.
1373
1374         * WebView/WebPreferences.mm:
1375
1376 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1377
1378         One too many zeroes in macOS version number in FeatureDefines
1379         https://bugs.webkit.org/show_bug.cgi?id=180011
1380
1381         Reviewed by Dan Bernstein.
1382
1383         * Configurations/FeatureDefines.xcconfig:
1384
1385 2017-11-23  Darin Adler  <darin@apple.com>
1386
1387         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1388         https://bugs.webkit.org/show_bug.cgi?id=179981
1389
1390         Reviewed by Sam Weinig.
1391
1392         * WebView/WebImmediateActionController.mm:
1393         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1394         * WebView/WebView.mm:
1395         (coreOptions): Use |= instead of | to build up FindOptions.
1396
1397 2017-11-23  Sam Weinig  <sam@webkit.org>
1398
1399         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1400         https://bugs.webkit.org/show_bug.cgi?id=179954
1401
1402         Reviewed by Darin Adler.
1403
1404         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1405         with direct calls to the corresponding UserGestureIndicator functions.
1406
1407         * Plugins/WebPluginController.mm:
1408         (-[WebPluginController processingUserGesture]):
1409         * WebView/WebView.mm:
1410         (-[WebView _isProcessingUserGesture]):
1411
1412 2017-11-23  Darin Adler  <darin@apple.com>
1413
1414         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1415         https://bugs.webkit.org/show_bug.cgi?id=179907
1416
1417         Reviewed by Sam Weinig.
1418
1419         * History/BinaryPropertyList.cpp:
1420         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1421         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1422         * WebView/WebHTMLRepresentation.mm:
1423         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1424         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1425
1426 2017-11-22  Ali Juma  <ajuma@chromium.org>
1427
1428         Implement VisualViewport API attributes
1429         https://bugs.webkit.org/show_bug.cgi?id=179385
1430
1431         Reviewed by Frédéric Wang.
1432
1433         Add a VisualViewportAPI preference.
1434
1435         * WebView/WebPreferenceKeysPrivate.h:
1436         * WebView/WebPreferences.mm:
1437         (+[WebPreferences initialize]):
1438         (-[WebPreferences visualViewportAPIEnabled]):
1439         (-[WebPreferences setVisualViewportAPIEnabled:]):
1440         * WebView/WebPreferencesPrivate.h:
1441         * WebView/WebView.mm:
1442         (-[WebView _preferencesChanged:]):
1443
1444 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1445
1446         WebCoreObjCExtras.h is being included in too many places
1447         https://bugs.webkit.org/show_bug.cgi?id=179931
1448
1449         Reviewed by Darin Adler.
1450
1451         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1452         * Plugins/WebBaseNetscapePluginView.mm:
1453         * Plugins/WebBasePluginPackage.mm:
1454         * Plugins/WebNetscapePluginStream.mm:
1455         * Plugins/WebNetscapePluginView.mm:
1456         * WebView/WebTextIterator.mm:
1457         * WebView/WebViewData.mm:
1458
1459 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1460
1461         Unreviewed, rolling out r225093.
1462         https://bugs.webkit.org/show_bug.cgi?id=179938
1463
1464         Compilation failed on WinCairo 64-bit Release (Requested by
1465         fredw on #webkit).
1466
1467         Reverted changeset:
1468
1469         "Implement VisualViewport API attributes"
1470         https://bugs.webkit.org/show_bug.cgi?id=179385
1471         https://trac.webkit.org/changeset/225093
1472
1473 2017-11-21  Ali Juma  <ajuma@chromium.org>
1474
1475         Implement VisualViewport API attributes
1476         https://bugs.webkit.org/show_bug.cgi?id=179385
1477
1478         Reviewed by Frédéric Wang.
1479
1480         Add a VisualViewportAPI preference.
1481
1482         * WebView/WebPreferenceKeysPrivate.h:
1483         * WebView/WebPreferences.mm:
1484         (+[WebPreferences initialize]):
1485         (-[WebPreferences visualViewportAPIEnabled]):
1486         (-[WebPreferences setVisualViewportAPIEnabled:]):
1487         * WebView/WebPreferencesPrivate.h:
1488         * WebView/WebView.mm:
1489         (-[WebView _preferencesChanged:]):
1490
1491 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1492
1493         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1494         https://bugs.webkit.org/show_bug.cgi?id=179504
1495
1496         Reviewed by Darin Adler.
1497
1498         * Misc/WebKitNSStringExtras.mm:
1499         * Plugins/Hosted/NetscapePluginHostManager.mm:
1500         * Plugins/WebBasePluginPackage.mm:
1501
1502 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1503
1504         Remove unused TOUCH_ICON_LOADING feature flag
1505         https://bugs.webkit.org/show_bug.cgi?id=179873
1506
1507         Reviewed by Simon Fraser.
1508
1509         * Configurations/FeatureDefines.xcconfig:
1510
1511 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1512
1513         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1514         https://bugs.webkit.org/show_bug.cgi?id=179872
1515
1516         Reviewed by Darin Adler.
1517
1518         * Configurations/FeatureDefines.xcconfig:
1519
1520 2017-11-16  Daniel Bates  <dabates@apple.com>
1521
1522         Add feature define for alternative presentation button element
1523         https://bugs.webkit.org/show_bug.cgi?id=179692
1524         Part of <rdar://problem/34917108>
1525
1526         Reviewed by Andy Estes.
1527
1528         Only enabled on Cocoa platforms by default.
1529
1530         * Configurations/FeatureDefines.xcconfig:
1531
1532 2017-11-14  Nan Wang  <n_wang@apple.com>
1533
1534         AX: AOM: Implement AccessibleNode class and support label and role attributes
1535         https://bugs.webkit.org/show_bug.cgi?id=179494
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         * WebView/WebPreferenceKeysPrivate.h:
1540         * WebView/WebPreferences.mm:
1541         (+[WebPreferences initialize]):
1542         (-[WebPreferences accessibilityObjectModelEnabled]):
1543         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1544         * WebView/WebPreferencesPrivate.h:
1545         * WebView/WebView.mm:
1546         (-[WebView _preferencesChanged:]):
1547
1548 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1549
1550         Remove Cocoa CFURLConnection loading code
1551         https://bugs.webkit.org/show_bug.cgi?id=179688
1552
1553         Reviewed by Antti Koivisto.
1554
1555         * Misc/WebDownload.mm:
1556         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1557         * Misc/WebDownloadInternal.h:
1558         * Plugins/WebBaseNetscapePluginView.mm:
1559         * WebCoreSupport/WebFrameLoaderClient.mm:
1560         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1561         * WebView/WebView.mm:
1562         (-[WebView scheduleInRunLoop:forMode:]):
1563         (-[WebView unscheduleFromRunLoop:forMode:]):
1564
1565 2017-11-14  Daniel Bates  <dabates@apple.com>
1566
1567         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1568         for feature defines
1569
1570         Following r195498 and r201917 the Visual Studio property files for feature defines have
1571         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1572         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1573         files.
1574
1575         * Configurations/FeatureDefines.xcconfig:
1576
1577 2017-11-14  Jer Noble  <jer.noble@apple.com>
1578
1579         Enable Modern EME tests in DumpRenderTree
1580         https://bugs.webkit.org/show_bug.cgi?id=179544
1581
1582         Reviewed by Alex Christensen.
1583
1584         Add a WebPreferences property to enable the (modern) EME API.
1585
1586         * WebView/WebPreferenceKeysPrivate.h:
1587         * WebView/WebPreferences.mm:
1588         (+[WebPreferences initialize]):
1589         (-[WebPreferences encryptedMediaAPIEnabled]):
1590         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1591         * WebView/WebPreferencesPrivate.h:
1592         * WebView/WebView.mm:
1593         (-[WebView _preferencesChanged:]):
1594
1595 2017-11-14  Antti Koivisto  <antti@apple.com>
1596
1597         Enable display:contents by default
1598         https://bugs.webkit.org/show_bug.cgi?id=179655
1599
1600         Reviewed by Sam Weinig.
1601
1602         * WebView/WebPreferences.mm:
1603         (+[WebPreferences initialize]):
1604
1605 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1606
1607         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1608         https://bugs.webkit.org/show_bug.cgi?id=178751
1609
1610         Reviewed by Brady Eidson.
1611
1612         * WebCoreSupport/WebFrameNetworkingContext.mm:
1613         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1614
1615 2017-11-08  Keith Miller  <keith_miller@apple.com>
1616
1617         Async iteration should only fetch the next method once and add feature flag
1618         https://bugs.webkit.org/show_bug.cgi?id=179451
1619
1620         Reviewed by Geoffrey Garen.
1621
1622         Add feature flag for Async iteration.
1623
1624         * Configurations/FeatureDefines.xcconfig:
1625
1626 2017-11-13  Mark Lam  <mark.lam@apple.com>
1627
1628         Add more overflow check book-keeping for MarkedArgumentBuffer.
1629         https://bugs.webkit.org/show_bug.cgi?id=179634
1630         <rdar://problem/35492517>
1631
1632         Reviewed by Saam Barati.
1633
1634         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1635         (WebKit::NetscapePluginInstanceProxy::invoke):
1636         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1637         (WebKit::NetscapePluginInstanceProxy::construct):
1638
1639 2017-11-12  Darin Adler  <darin@apple.com>
1640
1641         More is<> and downcast<>, less static_cast<>
1642         https://bugs.webkit.org/show_bug.cgi?id=179600
1643
1644         Reviewed by Chris Dumez.
1645
1646         * DOM/DOM.mm:
1647         (kit): Use is/downcast.
1648         * WebCoreSupport/WebEditorClient.mm:
1649         (WebEditorClient::handleKeyboardEvent): Ditto.
1650         (WebEditorClient::handleInputMethodKeydown): Ditto.
1651         * WebView/WebHTMLView.mm:
1652         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1653
1654 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1655
1656         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1657         https://bugs.webkit.org/show_bug.cgi?id=179397
1658
1659         Reviewed by Wenson Hsieh.
1660
1661         * DOM/DOMHTMLInputElement.mm:
1662         (-[DOMHTMLInputElement insertTextSuggestion:]):
1663
1664 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1665
1666         HTMLMediaElement should not use element fullscreen on iOS
1667         https://bugs.webkit.org/show_bug.cgi?id=179418
1668         rdar://problem/35409277
1669
1670         Reviewed by Eric Carlson.
1671
1672         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1673
1674         * Configurations/FeatureDefines.xcconfig:
1675
1676 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1677
1678         Make ResourceLoader::willSendRequestInternal asynchronous
1679         https://bugs.webkit.org/show_bug.cgi?id=179251
1680
1681         Reviewed by Andy Estes.
1682
1683         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1684         (WebKit::HostedNetscapePluginStream::start):
1685         * Plugins/WebNetscapePluginStream.mm:
1686         (WebNetscapePluginStream::start):
1687
1688 2017-11-01  Darin Adler  <darin@apple.com>
1689
1690         Simplify event dispatch code and make it a bit more consistent
1691         https://bugs.webkit.org/show_bug.cgi?id=178991
1692
1693         Reviewed by Chris Dumez.
1694
1695         * DOM/DOMEvent.mm:
1696         (-[DOMEvent srcElement]): Call target instead of srcElement.
1697
1698 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1699
1700         [Touch Bar Web API] Add support for menuitem tag
1701         https://bugs.webkit.org/show_bug.cgi?id=179020
1702
1703         Reviewed by Ryosuke Niwa.
1704
1705         Adds in properties and methods that allow the menuitem runtime feature
1706         to be enabled or disabled.
1707
1708         * WebView/WebPreferenceKeysPrivate.h:
1709         * WebView/WebPreferences.mm:
1710         (-[WebPreferences menuItemElementEnabled]):
1711         (-[WebPreferences setMenuItemElementEnabled:]):
1712         * WebView/WebPreferencesPrivate.h:
1713         * WebView/WebView.mm:
1714         (-[WebView _preferencesChanged:]):
1715
1716 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1717
1718         Use CompletionHandlers for redirects
1719         https://bugs.webkit.org/show_bug.cgi?id=179163
1720
1721         Reviewed by Tim Horton.
1722
1723         * Plugins/Hosted/HostedNetscapePluginStream.h:
1724         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1725         (WebKit::HostedNetscapePluginStream::willSendRequest):
1726         * Plugins/WebNetscapePluginStream.h:
1727         * Plugins/WebNetscapePluginStream.mm:
1728         (WebNetscapePluginStream::willSendRequest):
1729
1730 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1731
1732         Add a FileSystem namespace to FileSystem.cpp
1733         https://bugs.webkit.org/show_bug.cgi?id=179063
1734
1735         Reviewed by Darin Adler.
1736
1737         * Misc/WebNSFileManagerExtras.mm:
1738         * Storage/WebDatabaseProvider.mm:
1739
1740 2017-11-02  Frederic Wang  <fwang@igalia.com>
1741
1742         Add references to bug 179167 in FIXME comments
1743         https://bugs.webkit.org/show_bug.cgi?id=179168
1744
1745         Reviewed by Daniel Bates.
1746
1747         * Configurations/FeatureDefines.xcconfig:
1748
1749 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1750
1751         Implement WKFullscreenWindowController for iOS.
1752         https://bugs.webkit.org/show_bug.cgi?id=178924
1753         rdar://problem/34697120
1754
1755         Reviewed by Simon Fraser.
1756
1757         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1758
1759         * Configurations/FeatureDefines.xcconfig:
1760         * WebView/WebView.mm:
1761         (-[WebView fullScreenPlaceholderView]):
1762
1763 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1764
1765         Clean up some drag and drop feature flags
1766         https://bugs.webkit.org/show_bug.cgi?id=179082
1767
1768         Reviewed by Simon Fraser.
1769
1770         * Configurations/FeatureDefines.xcconfig:
1771
1772 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1773
1774         Make it possible to test rubber-banding in overflow scroll
1775         https://bugs.webkit.org/show_bug.cgi?id=179078
1776
1777         Reviewed by Sam Weinig.
1778
1779         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1780         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1781
1782         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1783         functions, since most callers want clamped.
1784
1785         * DOM/DOMHTML.mm:
1786         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1787
1788 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1789
1790         Fix up some content filtering feature flags
1791         https://bugs.webkit.org/show_bug.cgi?id=179079
1792
1793         Reviewed by Simon Fraser.
1794
1795         * Configurations/FeatureDefines.xcconfig:
1796
1797 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1798
1799         [FrameView::layout cleanup] Move core layout logic to a separate class.
1800         https://bugs.webkit.org/show_bug.cgi?id=178771
1801         <rdar://problem/35166542>
1802
1803         Reviewed by Simon Fraser.
1804
1805         Move layout code out from FrameView to LayoutContext.
1806
1807         * WebView/WebClipView.mm:
1808         (-[WebClipView _immediateScrollToPoint:]):
1809         * WebView/WebFrame.mm:
1810         (-[WebFrame layoutCount]):
1811
1812 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1813
1814         Fix issues with WebView subframe painting
1815         https://bugs.webkit.org/show_bug.cgi?id=178842
1816         rdar://problem/34072253
1817
1818         Reviewed by Daniel Bates.
1819         
1820         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1821         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1822         High Sierra, so match the new signature.
1823
1824         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1825
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1828         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1829
1830 2017-10-25  Youenn Fablet  <youenn@apple.com>
1831
1832         Enable ServiceWorker to fetch resources
1833         https://bugs.webkit.org/show_bug.cgi?id=178673
1834
1835         Reviewed by Brady Eidson.
1836
1837         * WebCoreSupport/WebFrameLoaderClient.mm:
1838         (WebFrameLoaderClient::pageID const):
1839         (WebFrameLoaderClient::frameID const):
1840         (WebFrameLoaderClient::sessionID const):
1841
1842         Added implementation to the new getters.
1843         They are noop in the context of WK1.
1844
1845 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1846
1847         Web Inspector: Enable WebKit logging configuration and display
1848         https://bugs.webkit.org/show_bug.cgi?id=177027
1849         <rdar://problem/33964767>
1850
1851         Reviewed by Joseph Pecoraro.
1852
1853         * WebCoreSupport/WebChromeClient.mm:
1854         (stringForMessageSource): Deal with Media and WebRTC message sources.
1855
1856 2017-10-20  Antoine Quint  <graouts@apple.com>
1857
1858         [Web Animations] Provide basic timeline and animation interfaces
1859         https://bugs.webkit.org/show_bug.cgi?id=178526
1860
1861         Reviewed by Dean Jackson.
1862
1863         Remove the WEB_ANIMATIONS compile-time flag.
1864
1865         * Configurations/FeatureDefines.xcconfig:
1866         * WebView/WebPreferences.mm:
1867         (+[WebPreferences initialize]):
1868         * WebView/WebView.mm:
1869         (-[WebView _preferencesChanged:]):
1870
1871 2017-10-19  Sam Weinig  <sam@webkit.org>
1872
1873         [Settings] Move global settings into their own file
1874         https://bugs.webkit.org/show_bug.cgi?id=178512
1875
1876         Reviewed by Darin Adler.
1877
1878         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1879
1880         * WebCoreSupport/WebChromeClient.mm:
1881         (WebChromeClient::supportsVideoFullscreen):
1882         * WebView/WebDynamicScrollBarsView.mm:
1883         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1884         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1885         * WebView/WebPreferences.mm:
1886         (+[WebPreferences initialize]):
1887         * WebView/WebView.mm:
1888         (-[WebView _commonInitializationWithFrameName:groupName:]):
1889         (-[WebView _preferencesChanged:]):
1890         (+[WebView _doNotStartObservingNetworkReachability]):
1891
1892 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1893
1894         Replace some stack raw pointers with RefPtrs within WebCore/html
1895         https://bugs.webkit.org/show_bug.cgi?id=178201
1896         <rdar://problem/34841692>
1897
1898         Reviewed by Ryosuke Niwa.
1899
1900         * DOM/DOM.mm:
1901         (kit):
1902         Change the type of node as toNode() is changed to return RefPtr.
1903
1904 2017-10-18  Chris Dumez  <cdumez@apple.com>
1905
1906         [Service Worker] Add stubs for Client / WindowClient / Clients
1907         https://bugs.webkit.org/show_bug.cgi?id=178469
1908
1909         Reviewed by Youenn Fablet.
1910
1911         Rename PageVisiblityState to VisibilityState.
1912
1913         * WebView/WebView.mm:
1914         (kit):
1915
1916 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1917
1918         Unreviewed, rolling out r223291.
1919
1920         See WebCore ChangeLog for more detail.
1921
1922         Reverted changeset:
1923
1924         "Remove Editor::simplifyMarkup"
1925         https://bugs.webkit.org/show_bug.cgi?id=178271
1926         https://trac.webkit.org/changeset/223291
1927
1928 2017-10-17  Keith Miller  <keith_miller@apple.com>
1929
1930         Change WebCore sources to work with unified source builds
1931         https://bugs.webkit.org/show_bug.cgi?id=178229
1932
1933         Rubber stamped by Tim Horton.
1934
1935         * Configurations/FeatureDefines.xcconfig:
1936
1937 2017-10-16  Sam Weinig  <sam@webkit.org>
1938
1939         [Settings] Remove all custom code from Settings.h/cpp
1940         https://bugs.webkit.org/show_bug.cgi?id=178330
1941
1942         Reviewed by Simon Fraser.
1943
1944         * WebView/WebPreferences.mm:
1945         (+[WebPreferences initialize]):
1946         
1947             Update for naming changes of FrameFlattening now that it is an enum class.
1948
1949 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1950
1951         Remove Editor::simplifyMarkup
1952         https://bugs.webkit.org/show_bug.cgi?id=178271
1953
1954         Reviewed by Wenson Hsieh.
1955
1956         * WebView/WebView.mm:
1957         (-[WebView _simplifyMarkup:endNode:]):
1958
1959 2017-10-12  Chris Dumez  <cdumez@apple.com>
1960
1961         [Mac] Add support for MouseEvent.buttons
1962         https://bugs.webkit.org/show_bug.cgi?id=178214
1963
1964         Reviewed by Ryosuke Niwa.
1965
1966         * WebView/WebPDFView.mm:
1967         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1968
1969 2017-10-11  Sam Weinig  <sam@webkit.org>
1970
1971         Remove out-parameter variants of copyToVector
1972         https://bugs.webkit.org/show_bug.cgi?id=178155
1973
1974         Reviewed by Tim Horton.
1975
1976         * Plugins/WebNetscapePluginView.mm:
1977         (-[WebNetscapePluginView destroyPlugin]):
1978         * WebView/WebHTMLRepresentation.mm:
1979         (newArrayWithStrings):
1980
1981             Replace out-parameter based copyToVector, with one that returns a Vector.
1982
1983 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1984
1985         Sanitize URL in pasteboard for other applications and cross origin content
1986         https://bugs.webkit.org/show_bug.cgi?id=178060
1987         <rdar://problem/34874518>
1988
1989         Reviewed by Wenson Hsieh.
1990
1991         * WebCoreSupport/WebPlatformStrategies.h:
1992         * WebCoreSupport/WebPlatformStrategies.mm:
1993         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1994
1995 2017-10-11  Chris Dumez  <cdumez@apple.com>
1996
1997         Modernize Geolocation code
1998         https://bugs.webkit.org/show_bug.cgi?id=178148
1999
2000         Reviewed by Ryosuke Niwa.
2001
2002         * WebCoreSupport/WebGeolocationClient.h:
2003         * WebCoreSupport/WebGeolocationClient.mm:
2004         (WebGeolocationClient::lastPosition):
2005         * WebView/WebGeolocationPosition.mm:
2006         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2007         (core):
2008         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2009         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2010         * WebView/WebGeolocationPositionInternal.h:
2011
2012 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2013
2014         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2015         https://bugs.webkit.org/show_bug.cgi?id=178154
2016
2017         Reviewed by Wenson Hsieh.
2018
2019         Enable custom pasteboard data by default.
2020
2021         * WebView/WebPreferenceKeysPrivate.h:
2022         * WebView/WebPreferences.mm:
2023         (+[WebPreferences initialize]):
2024         (-[WebPreferences customPasteboardDataEnabled]): Added.
2025         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2026         * WebView/WebPreferencesPrivate.h:
2027         * WebView/WebView.mm:
2028         (-[WebView _preferencesChanged:]):
2029
2030 2017-10-10  Sam Weinig  <sam@webkit.org>
2031
2032         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2033         https://bugs.webkit.org/show_bug.cgi?id=178102
2034
2035         Reviewed by Tim Horton.
2036
2037         * History/WebHistory.mm:
2038         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2039         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2040         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2041         * WebCoreSupport/WebUserMediaClient.mm:
2042         (WebUserMediaClient::pageDestroyed):
2043
2044 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2045
2046         Make the names of the options consistent
2047         https://bugs.webkit.org/show_bug.cgi?id=177933
2048
2049         Reviewed by Saam Barati.
2050
2051         * WebView/WebFrame.h:
2052         * WebView/WebHTMLView.mm:
2053         (-[WebHTMLView setMarkedText:selectedRange:]):
2054         * WebView/WebView.h:
2055
2056 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2057
2058         [iOS] Tweak support for classifying form controls (followup to r222487)
2059         https://bugs.webkit.org/show_bug.cgi?id=177917
2060         <rdar://problem/34820122>
2061
2062         Reviewed by Dean Jackson.
2063
2064         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2065
2066         * DOM/DOMHTMLInputElement.mm:
2067         (-[DOMHTMLInputElement _autofillContext]):
2068         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2069         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2070
2071 2017-10-05  Keith Miller  <keith_miller@apple.com>
2072
2073         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2074
2075         * Configurations/WebKitLegacy.xcconfig:
2076
2077 2017-10-05  Jer Noble  <jer.noble@apple.com>
2078
2079         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2080         https://bugs.webkit.org/show_bug.cgi?id=177261
2081
2082         Reviewed by Eric Carlson.
2083
2084         * Configurations/FeatureDefines.xcconfig:
2085
2086 2017-10-05  Chris Dumez  <cdumez@apple.com>
2087
2088         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2089         https://bugs.webkit.org/show_bug.cgi?id=177957
2090
2091         Reviewed by Alex Christensen.
2092
2093         * WebCoreSupport/WebPlatformStrategies.h:
2094         * WebCoreSupport/WebPlatformStrategies.mm:
2095         (WebPlatformStrategies::cookiesEnabled):
2096
2097 2017-10-05  Youenn Fablet  <youenn@apple.com>
2098
2099         Make LibWebRTCProvider port agnostic
2100         https://bugs.webkit.org/show_bug.cgi?id=177747
2101
2102         Reviewed by Alex Christensen & Alex Garcia.
2103
2104         * WebView/WebView.mm:
2105         (-[WebView _commonInitializationWithFrameName:groupName:]):
2106         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2107
2108 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2109
2110         Stop linking with WebKitSystemInterface
2111         https://bugs.webkit.org/show_bug.cgi?id=177915
2112
2113         Reviewed by Antti Koivisto.
2114
2115         * Configurations/DebugRelease.xcconfig:
2116         * Configurations/WebKitLegacy.xcconfig:
2117
2118 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2119
2120         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2121         https://bugs.webkit.org/show_bug.cgi?id=177912
2122
2123         Reviewed by Saam Barati.
2124
2125         * Carbon/CarbonUtils.m:
2126         * Carbon/CarbonWindowAdapter.mm:
2127         * Carbon/HIWebView.mm:
2128         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2129         * Misc/WebNSFileManagerExtras.mm:
2130         * Misc/WebNSPasteboardExtras.mm:
2131         * Misc/WebNSURLExtras.mm:
2132         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2133         * Plugins/Hosted/NetscapePluginHostManager.mm:
2134         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2135         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2136         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2137         * Plugins/Hosted/WebTextInputWindowController.m:
2138         * Plugins/WebBaseNetscapePluginView.mm:
2139         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2140         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2141         * Plugins/WebNetscapePluginStream.mm:
2142         * Plugins/WebNetscapePluginView.mm:
2143         * Plugins/WebPluginDatabase.mm:
2144         * WebCoreSupport/PopupMenuMac.mm:
2145         * WebCoreSupport/WebChromeClient.mm:
2146         * WebCoreSupport/WebFrameLoaderClient.mm:
2147         * WebCoreSupport/WebInspectorClient.mm:
2148         * WebCoreSupport/WebPlatformStrategies.mm:
2149         * WebCoreSupport/WebSystemInterface.mm:
2150         * WebView/WebDynamicScrollBarsView.mm:
2151         * WebView/WebFrame.mm:
2152         * WebView/WebFrameView.mm:
2153         * WebView/WebFullScreenController.mm:
2154         * WebView/WebHTMLView.mm:
2155         * WebView/WebPreferences.mm:
2156         * WebView/WebView.mm:
2157
2158 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2159
2160         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2161         rdar://problem/34705779
2162
2163         Addressing review comments that I somehow landed without.
2164
2165         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2166
2167 2017-09-29  Chris Dumez  <cdumez@apple.com>
2168
2169         Split some logic out of VisitedLinkStore and make it reusable
2170         https://bugs.webkit.org/show_bug.cgi?id=177575
2171
2172         Reviewed by Alex Christensen.
2173
2174         * WebCoreSupport/WebVisitedLinkStore.h:
2175         * WebCoreSupport/WebVisitedLinkStore.mm:
2176         (WebVisitedLinkStore::addVisitedLink):
2177         (WebVisitedLinkStore::removeVisitedLink):
2178         (WebVisitedLinkStore::isLinkVisited):
2179         (WebVisitedLinkStore::addVisitedLinkHash):
2180
2181 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2182
2183         Build fix for High Sierra 32 bit Mac
2184         https://bugs.webkit.org/show_bug.cgi?id=177551
2185         <rdar://problem/34690283>
2186
2187         Reviewed by Alexey Proskuryakov.
2188
2189         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2190         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2191         also made.
2192
2193         * Carbon/CarbonWindowAdapter.mm:
2194         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2195         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2196         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2197         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2198         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2199         (-[CarbonWindowAdapter dealloc]):
2200         (-[CarbonWindowAdapter windowRef]):
2201         (-[CarbonWindowAdapter _hasWindowRef]):
2202         (-[CarbonWindowAdapter _managesWindowRef]):
2203         (-[CarbonWindowAdapter _removeWindowRef]):
2204         (-[CarbonWindowAdapter _carbonWindowClass]):
2205         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2206         (-[CarbonWindowAdapter sendSuperEvent:]):
2207         (-[CarbonWindowAdapter relinquishFocus]):
2208         (-[CarbonWindowAdapter _cancelKey:]):
2209         (-[CarbonWindowAdapter _commonAwake]):
2210         (-[CarbonWindowAdapter _destroyRealWindow:]):
2211         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2212         (-[CarbonWindowAdapter _termWindowIfOwner]):
2213         (-[CarbonWindowAdapter _windowMovedToRect:]):
2214         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2215         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2216         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2217         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2218         (-[CarbonWindowAdapter canBecomeMainWindow]):
2219         (-[CarbonWindowAdapter encodeWithCoder:]):
2220         (-[CarbonWindowAdapter initWithCoder:]):
2221         (-[CarbonWindowAdapter setContentView:]):
2222         (-[CarbonWindowAdapter worksWhenModal]):
2223         (-[CarbonWindowAdapter _setModalWindowLevel]):
2224         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2225         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2226         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2227         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2228         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2229         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2230         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2231         (NSCarbonWindowHandleEvent):
2232         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2233         (-[CarbonWindowAdapter _growBoxRect]):
2234         * Carbon/HIWebView.mm:
2235         (HIWebViewGetWebView):
2236         (HIWebViewConstructor):
2237         (HIWebViewDestructor):
2238         (HIWebViewRegisterClass):
2239         (GetBehaviors):
2240         (Draw):
2241         (HitTest):
2242         (GetRegion):
2243         (GetWindowRef):
2244         (CreateNSEventAdoptingCGEvent):
2245         (CopyEventCGEvent):
2246         (CreateNSEventWithCarbonClickEvent):
2247         (Click):
2248         (CreateNSEventWithCarbonEvent):
2249         (MouseUp):
2250         (CreateNSEventWithCarbonMouseMoveEvent):
2251         (MouseMoved):
2252         (MouseDragged):
2253         (MouseWheelMoved):
2254         (ContextMenuClick):
2255         (GetKind):
2256         (BoundsChanged):
2257         (OwningWindowChanged):
2258         (WindowHandler):
2259         (SyncFrame):
2260         (SetFocusPart):
2261         (AdvanceFocus):
2262         (RelinquishFocus):
2263         (ActiveStateChanged):
2264         (ProcessCommand):
2265         (UpdateCommandStatus):
2266         (_NSSelectorForHICommand):
2267         (HIWebViewEventHandler):
2268         (StartUpdateObserver):
2269         (StopUpdateObserver):
2270         (UpdateObserver):
2271
2272 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2273
2274         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2275         https://bugs.webkit.org/show_bug.cgi?id=172526
2276         <rdar://problem/32396081>
2277
2278         Reviewed by Ryosuke Niwa.
2279
2280         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2281
2282         * WebCoreSupport/WebPlatformStrategies.h:
2283         * WebCoreSupport/WebPlatformStrategies.mm:
2284         (WebPlatformStrategies::webExposedTypes):
2285         (WebPlatformStrategies::writeCustomData):
2286
2287 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2288
2289         Unreviewed, rolling out r222567.
2290
2291         This broke and internal build.
2292
2293         Reverted changeset:
2294
2295         "Build fix for High Sierra 32 bit Mac"
2296         https://bugs.webkit.org/show_bug.cgi?id=177551
2297         http://trac.webkit.org/changeset/222567
2298
2299 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2300
2301         Build fix for High Sierra 32 bit Mac
2302         https://bugs.webkit.org/show_bug.cgi?id=177551
2303         <rdar://problem/34690283>
2304
2305         Reviewed by Alexey Proskuryakov.
2306
2307         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2308         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2309         also made.
2310
2311         * Carbon/CarbonWindowAdapter.mm:
2312         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2313         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2314         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2315         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2316         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2317         (-[CarbonWindowAdapter dealloc]):
2318         (-[CarbonWindowAdapter windowRef]):
2319         (-[CarbonWindowAdapter _hasWindowRef]):
2320         (-[CarbonWindowAdapter _managesWindowRef]):
2321         (-[CarbonWindowAdapter _removeWindowRef]):
2322         (-[CarbonWindowAdapter _carbonWindowClass]):
2323         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2324         (-[CarbonWindowAdapter sendSuperEvent:]):
2325         (-[CarbonWindowAdapter relinquishFocus]):
2326         (-[CarbonWindowAdapter _cancelKey:]):
2327         (-[CarbonWindowAdapter _commonAwake]):
2328         (-[CarbonWindowAdapter _destroyRealWindow:]):
2329         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2330         (-[CarbonWindowAdapter _termWindowIfOwner]):
2331         (-[CarbonWindowAdapter _windowMovedToRect:]):
2332         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2333         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2334         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2335         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2336         (-[CarbonWindowAdapter canBecomeMainWindow]):
2337         (-[CarbonWindowAdapter encodeWithCoder:]):
2338         (-[CarbonWindowAdapter initWithCoder:]):
2339         (-[CarbonWindowAdapter setContentView:]):
2340         (-[CarbonWindowAdapter worksWhenModal]):
2341         (-[CarbonWindowAdapter _setModalWindowLevel]):
2342         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2343         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2344         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2345         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2346         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2347         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2348         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2349         (NSCarbonWindowHandleEvent):
2350         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2351         (-[CarbonWindowAdapter _growBoxRect]):
2352         * Carbon/HIWebView.mm:
2353         (HIWebViewGetWebView):
2354         (HIWebViewConstructor):
2355         (HIWebViewDestructor):
2356         (HIWebViewRegisterClass):
2357         (GetBehaviors):
2358         (Draw):
2359         (HitTest):
2360         (GetRegion):
2361         (GetWindowRef):
2362         (CreateNSEventAdoptingCGEvent):
2363         (CopyEventCGEvent):
2364         (CreateNSEventWithCarbonClickEvent):
2365         (Click):
2366         (CreateNSEventWithCarbonEvent):
2367         (MouseUp):
2368         (CreateNSEventWithCarbonMouseMoveEvent):
2369         (MouseMoved):
2370         (MouseDragged):
2371         (MouseWheelMoved):
2372         (ContextMenuClick):
2373         (GetKind):
2374         (BoundsChanged):
2375         (OwningWindowChanged):
2376         (WindowHandler):
2377         (SyncFrame):
2378         (SetFocusPart):
2379         (AdvanceFocus):
2380         (RelinquishFocus):
2381         (ActiveStateChanged):
2382         (ProcessCommand):
2383         (UpdateCommandStatus):
2384         (_NSSelectorForHICommand):
2385         (HIWebViewEventHandler):
2386         (StartUpdateObserver):
2387         (StopUpdateObserver):
2388         (UpdateObserver):
2389
2390 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2391
2392         Make PolicyAction an encodable enum class
2393         https://bugs.webkit.org/show_bug.cgi?id=177480
2394
2395         Reviewed by Antti Koivisto.
2396
2397         * Plugins/WebPluginContainerCheck.mm:
2398         (-[WebPluginContainerCheck _continueWithPolicy:]):
2399         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2400         * WebCoreSupport/WebFrameLoaderClient.mm:
2401         (-[WebFramePolicyListener invalidate]):
2402         (-[WebFramePolicyListener ignore]):
2403         (-[WebFramePolicyListener download]):
2404         (-[WebFramePolicyListener use]):
2405         (-[WebFramePolicyListener continue]):
2406         * WebView/WebPolicyDelegate.mm:
2407         (-[WebPolicyDecisionListener use]):
2408         (-[WebPolicyDecisionListener ignore]):
2409         (-[WebPolicyDecisionListener download]):
2410
2411 2017-09-25  Frederik Riedel  <riedel@apple.com>
2412
2413         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2414         https://bugs.webkit.org/show_bug.cgi?id=174394
2415         <rdar://problem/33183504>
2416
2417         Reviewed by Ryosuke Niwa.
2418
2419         * DOM/DOMHTMLInputElement.h:
2420         * DOM/DOMHTMLInputElement.mm:
2421         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2422         Determines if this HTMLInputElement is part of a login screen.
2423         (-[DOMHTMLInputElement representingPageUrl]):
2424         Returns the webpage's URL that is currently displayed in the Web View.
2425         (-[DOMHTMLInputElement insertTextSuggestion:]):
2426         Inserts login credentials into the Web View.
2427
2428 2017-09-25  Sam Weinig  <sam@webkit.org>
2429
2430         Remove unused EditorClient functions
2431         https://bugs.webkit.org/show_bug.cgi?id=177463
2432
2433         Reviewed by Alex Christensen.
2434
2435         Remove unused EditorClient functions.
2436
2437         * WebCoreSupport/WebEditorClient.h:
2438         * WebCoreSupport/WebEditorClient.mm:
2439         (WebEditorClient::canonicalizeURL): Deleted.
2440         (WebEditorClient::canonicalizeURLString): Deleted.
2441         (WebEditorClient::writeDataToPasteboard): Deleted.
2442         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2443         (WebEditorClient::readDataFromPasteboard): Deleted.
2444         (WebEditorClient::pasteboardChangeCount): Deleted.
2445
2446 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2447
2448         Stop using PolicyCallback
2449         https://bugs.webkit.org/show_bug.cgi?id=176088
2450
2451         Reviewed by Andy Estes.
2452
2453         * WebCoreSupport/WebFrameLoaderClient.mm:
2454         (-[WebFramePolicyListener invalidate]):
2455         (-[WebFramePolicyListener receivedPolicyDecision:]):
2456
2457 2017-09-25  Sam Weinig  <sam@webkit.org>
2458
2459         Remove unnecessary userVisibleString EditorClient function
2460         https://bugs.webkit.org/show_bug.cgi?id=177456
2461
2462         Reviewed by Dan Bernstein.
2463
2464         * WebCoreSupport/WebEditorClient.h:
2465         * WebCoreSupport/WebEditorClient.mm:
2466         (WebEditorClient::userVisibleString): Deleted.
2467
2468             Remove userVisibleString client function.
2469
2470 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2471
2472         Separate form submission from PolicyChecker infrastructure
2473         https://bugs.webkit.org/show_bug.cgi?id=177396
2474
2475         Reviewed by Geoffrey Garen.
2476
2477         * WebCoreSupport/WebFrameLoaderClient.h:
2478         * WebCoreSupport/WebFrameLoaderClient.mm:
2479         (WebFrameLoaderClient::dispatchWillSubmitForm):
2480
2481 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2482
2483         WeakPtrFactory should populate m_ref lazily.
2484         https://bugs.webkit.org/show_bug.cgi?id=177375
2485
2486         Reviewed by Geoffrey Garen.
2487
2488         * WebCoreSupport/WebEditorClient.mm:
2489         (WebEditorClient::WebEditorClient):
2490         (WebEditorClient::requestCandidatesForSelection):
2491
2492 2017-09-22  Chris Dumez  <cdumez@apple.com>
2493
2494         Use high resolution timestamp for event time
2495         https://bugs.webkit.org/show_bug.cgi?id=154246
2496         <rdar://problem/34333304>
2497
2498         Reviewed by Ryosuke Niwa.
2499
2500         Use WallTime / MonotonicTime instead of double type for clarity.
2501
2502         * DOM/DOMEvent.mm:
2503         (-[DOMEvent timeStamp]):
2504         * WebView/WebFrame.mm:
2505         (-[WebFrame _dragSourceEndedAt:operation:]):
2506         * WebView/WebPDFView.mm:
2507         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2508
2509 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2510
2511         Enable dataTransfer.items on macOS and iOS
2512         https://bugs.webkit.org/show_bug.cgi?id=177335
2513
2514         Reviewed by Sam Weinig.
2515
2516         * WebView/WebPreferences.mm:
2517         (+[WebPreferences initialize]):
2518
2519 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2520
2521         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2522         https://bugs.webkit.org/show_bug.cgi?id=177101
2523         <rdar://problem/34500648>
2524
2525         Reviewed by Brian Burg.
2526
2527         * WebInspector/WebNodeHighlight.mm:
2528         Ensure we close the window that we have just removed.
2529
2530 2017-09-20  Antti Koivisto  <antti@apple.com>
2531
2532         Remove DOM and styling support for CSS Regions
2533         https://bugs.webkit.org/show_bug.cgi?id=177221
2534
2535         Reviewed by Andreas Kling.
2536
2537         * Configurations/FeatureDefines.xcconfig:
2538         * DOM/DOMCSS.mm:
2539         (kitClass):
2540         * DOM/DOMElement.mm:
2541         (-[DOMElement webkitRegionOverset]): Deleted.
2542
2543 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2544
2545         Layering violation in Editor::createFragment
2546         https://bugs.webkit.org/show_bug.cgi?id=176123
2547
2548         Reviewed by Darin Adler.
2549
2550         * Misc/WebNSURLExtras.h:
2551         * Misc/WebNSURLExtras.mm:
2552         * WebView/WebFrame.mm:
2553         * WebView/WebHTMLView.mm:
2554         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2555
2556         * WebCoreSupport/WebEditorClient.mm:
2557         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2558         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2559         way to avoid exporting the symbol just on newer OSes.
2560
2561 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2562
2563         On iOS, getData can't get text set by setData during copy event
2564         https://bugs.webkit.org/show_bug.cgi?id=176980
2565         <rdar://problem/34453915>
2566
2567         Reviewed by Darin Adler.
2568
2569         * WebCoreSupport/WebPlatformStrategies.h:
2570         * WebCoreSupport/WebPlatformStrategies.mm:
2571         (WebPlatformStrategies::copy): Deleted.
2572
2573 2017-09-18  Andy Estes  <aestes@apple.com>
2574
2575         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2576         https://bugs.webkit.org/show_bug.cgi?id=177029
2577
2578         Reviewed by Alex Christensen.
2579
2580         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2581         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2582         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2583         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2584         * WebCoreSupport/PopupMenuMac.mm:
2585         (PopupMenuMac::show):
2586         * WebCoreSupport/WebSystemInterface.mm:
2587         (InitWebCoreSystemInterface):
2588         * WebView/WebHTMLView.mm:
2589         (-[WebHTMLView setDataSource:]):
2590         (-[WebHTMLView attachRootLayer:]):
2591         * WebView/WebView.mm:
2592         (-[WebView _needsAdobeFrameReloadingQuirk]):
2593         (-[WebView _needsLinkElementTextCSSQuirk]):
2594         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2595         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2596         (-[WebView _preferencesChanged:]):
2597
2598 2017-09-15  Andy Estes  <aestes@apple.com>
2599
2600         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2601         https://bugs.webkit.org/show_bug.cgi?id=176953
2602
2603         Reviewed by Eric Carlson.
2604
2605         * WebCoreSupport/WebSystemInterface.mm:
2606         (InitWebCoreSystemInterface):
2607
2608 2017-09-14  Andy Estes  <aestes@apple.com>
2609
2610         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2611         https://bugs.webkit.org/show_bug.cgi?id=176931
2612
2613         Reviewed by Joseph Pecoraro.
2614
2615         * WebCoreSupport/WebSystemInterface.mm:
2616         (InitWebCoreSystemInterface):
2617
2618 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2619
2620         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2621         https://bugs.webkit.org/show_bug.cgi?id=176867
2622
2623         Reviewed by Sam Weinig.
2624
2625         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2626         (WebKit::NetscapePluginInstanceProxy::enumerate):
2627
2628 2017-09-13  Andy Estes  <aestes@apple.com>
2629
2630         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2631         https://bugs.webkit.org/show_bug.cgi?id=176729
2632
2633         Reviewed by Alex Christensen.
2634
2635         * WebCoreSupport/WebSystemInterface.mm:
2636         (InitWebCoreSystemInterface):
2637         * WebView/WebView.mm:
2638         (+[WebView _setCacheModel:]):
2639
2640 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2641
2642         Refactor WebContentReader out of EditorMac and EditorIOS
2643         https://bugs.webkit.org/show_bug.cgi?id=176770
2644
2645         Reviewed by Sam Weinig.
2646
2647         * WebCoreSupport/WebEditorClient.mm:
2648
2649 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2650
2651         Dragging & dropping a file creates an attachment element even when it's disabled
2652         https://bugs.webkit.org/show_bug.cgi?id=176769
2653
2654         Reviewed by Tim Horton.
2655
2656         * WebView/WebView.mm:
2657         (-[WebView _preferencesChanged:]):
2658
2659 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2660
2661         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2662         https://bugs.webkit.org/show_bug.cgi?id=176721
2663         <rdar://problem/34373660>
2664
2665         Reviewed by Tim Horton.
2666
2667         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2668         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2669
2670         * WebView/WebView.mm:
2671         (-[WebView _startDrag:]):
2672         (-[WebView _draggedElementBounds]):
2673         (-[WebView _endedDataInteraction:global:]):
2674         * WebView/WebViewData.h:
2675
2676 2017-09-11  Andy Estes  <aestes@apple.com>
2677
2678         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2679         https://bugs.webkit.org/show_bug.cgi?id=176472
2680
2681         Reviewed by Eric Carlson.
2682
2683         * WebCoreSupport/WebSystemInterface.mm:
2684         (InitWebCoreSystemInterface):
2685
2686 2017-09-09  Mark Lam  <mark.lam@apple.com>
2687
2688         Avoid duplicate computations of ExecState::vm().
2689         https://bugs.webkit.org/show_bug.cgi?id=176647
2690
2691         Reviewed by Saam Barati.
2692
2693         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2694         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2695         (WebKit::NetscapePluginInstanceProxy::construct):
2696         (WebKit::NetscapePluginInstanceProxy::setProperty):
2697         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2698         (WebKit::NetscapePluginInstanceProxy::enumerate):
2699         * Plugins/Hosted/ProxyInstance.mm:
2700         (WebKit::ProxyRuntimeMethod::create):
2701
2702 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2703
2704         Unreviewed, rolling out r221773.
2705         https://bugs.webkit.org/show_bug.cgi?id=176614
2706
2707         This caused build failures. (Requested by mlewis13 on
2708         #webkit).
2709
2710         Reverted changeset:
2711
2712         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2713         https://bugs.webkit.org/show_bug.cgi?id=176472
2714         http://trac.webkit.org/changeset/221773
2715
2716 2017-09-07  Andy Estes  <aestes@apple.com>
2717
2718         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2719         https://bugs.webkit.org/show_bug.cgi?id=176472
2720
2721         Reviewed by Eric Carlson.
2722
2723         * WebCoreSupport/WebSystemInterface.mm:
2724         (InitWebCoreSystemInterface):
2725
2726 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2727
2728         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2729         https://bugs.webkit.org/show_bug.cgi?id=176561
2730
2731         Reviewed by Brent Fulgham.
2732
2733         * Misc/WebNSUserDefaultsExtras.mm:
2734
2735 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2736
2737         Modernize Geolocation code
2738         https://bugs.webkit.org/show_bug.cgi?id=176496
2739
2740         Reviewed by Andy Estes.
2741
2742         * WebCoreSupport/WebGeolocationClient.h:
2743         * WebCoreSupport/WebGeolocationClient.mm:
2744         (WebGeolocationClient::requestPermission):
2745         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2746         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2747         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2748         * WebView/WebView.mm:
2749         (-[WebView _commonInitializationWithFrameName:groupName:]):
2750         (-[WebView _geolocationDidFailWithMessage:]):
2751
2752 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2753
2754         Remove some unused bits of code and resources
2755         https://bugs.webkit.org/show_bug.cgi?id=176275
2756
2757         Reviewed by Dan Bernstein.
2758
2759         * Misc/WebNSFileManagerExtras.mm:
2760         Include FileSystem instead of FileSystemIOS.
2761
2762 2017-09-03  Darin Adler  <darin@apple.com>
2763
2764         [Cocoa] Tidy a few things in legacy WebHTMLView
2765         https://bugs.webkit.org/show_bug.cgi?id=176280
2766
2767         Reviewed by Dan Bernstein.
2768
2769         * WebCoreSupport/WebChromeClient.mm:
2770         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2771         methods it calls on WebHTMLView were doing nothing on iOS.
2772
2773         * WebView/WebFrame.mm:
2774         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2775         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2776
2777         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2778         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2779         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2780         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2781         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2782         Use RetainPtr instead of writing retain/release wherever possible.
2783         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2784         initialization for it. Removed various unused methods and declarations of methods.
2785         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2786         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2787         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2788         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2789         and remove CFRetain no longer needed since we don't support garbage collection any more.
2790         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2791         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2792         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2793         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2794         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2795         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2796         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2797         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2798         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2799         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2800         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2801         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2802         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2803         debug flag; we haven't used it for years and it's not clearly helpful.
2804         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2805         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2806         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2807         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2808         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2809         two additional methods in the WebPrivate category and still be called by the two
2810         methods in the WebInternal category that were already using it.
2811         (-[WebHTMLView didAddSubview:]): Deleted.
2812         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2813         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2814         place this was called, the close method.
2815         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2816         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2817         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2818         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2819         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2820         Added helper method to make the one below simpler.
2821         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2822         Compared pasteboard type strings using isEqualToString: rather than using == since
2823         we want to actually compare the string contents. Also updated to use modern for loop,
2824         renamed a local variable from "s" to "localSubresources", and factored out the handling
2825         of three image types to use the helper method above.
2826         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2827         _web_makePluginSubviewsPerformSelector:withObject: method.
2828         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2829         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2830         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2831         not call the -[NSView subviews] method to make this identical on both platforms and used
2832         a modern for loop.
2833         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2834         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2835         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2836         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2837         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2838         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2839         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2840         of it is Mac-only.
2841         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2842         method did was call itself on the main thread, and do nothing if called on main thread.
2843         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2844         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2845         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2846         half of this method.
2847         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2848         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2849         Simplified using a modern for loop and RetainPtr.
2850         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2851         (-[WebHTMLView keyDown:]): Ditto.
2852         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2853         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2854         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2855         (-[WebHTMLView complete:]): Ditto.
2856         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2857         now macOS-only.
2858         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2859         iOS since that is now macOS-only.
2860         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2861         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2862         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2863         and reorganized to use early return.
2864         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2865         on iOS, but kept there so we don't have to do #if at every call site.
2866         (-[WebHTMLView _pluginController]): Moved into internal category.
2867         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2868         there only for GC, using C++ initialization, removing obsolete comment.
2869         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2870         peculiar iOS-only comment.
2871         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2872
2873         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2874         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2875         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2876         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2877         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2878
2879         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2880         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2881         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2882         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2883         them at this time.
2884
2885 2017-09-03  Sam Weinig  <sam@webkit.org>
2886
2887         Remove CanvasProxy
2888         https://bugs.webkit.org/show_bug.cgi?id=176288
2889
2890         Reviewed by Yusuke Suzuki.
2891
2892         CanvasProxy does not appear to be in any current HTML spec
2893         and was disabled and unimplemented in our tree. Time to 
2894         get rid of it.
2895
2896         * Configurations/FeatureDefines.xcconfig:
2897
2898 2017-09-02  Andy Estes  <aestes@apple.com>
2899
2900         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2901         https://bugs.webkit.org/show_bug.cgi?id=176270
2902
2903         Reviewed by Tim Horton.
2904
2905         * Plugins/Hosted/NetscapePluginHostManager.mm:
2906         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2907         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2908         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2909         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2910         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2911         (WebKit::SoftwareCARenderer::context const):
2912         (WebKit::SoftwareCARenderer::renderContext const):
2913         (WebKit::SoftwareCARenderer::render):
2914         (-[WebHostedNetscapePluginView createPlugin]):
2915         (-[WebHostedNetscapePluginView createPluginLayer]):
2916         (-[WebHostedNetscapePluginView destroyPlugin]):
2917         (-[WebHostedNetscapePluginView drawRect:]):
2918         * WebCoreSupport/WebSystemInterface.mm:
2919         (InitWebCoreSystemInterface):
2920
2921 2017-09-01  Andy Estes  <aestes@apple.com>
2922
2923         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2924         https://bugs.webkit.org/show_bug.cgi?id=176200
2925
2926         Reviewed by Tim Horton.
2927
2928         * Carbon/HIWebView.mm:
2929         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2930         (overrideCGContext):
2931         (restoreCGContext):
2932         (Draw):
2933         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2934         (+[WebHostedNetscapePluginView initialize]):
2935         * Plugins/WebBaseNetscapePluginView.h:
2936         * Plugins/WebBaseNetscapePluginView.mm:
2937         (WebKit::sendUserChangeNotifications):
2938         * Plugins/WebNetscapePluginView.mm:
2939         (+[WebNetscapePluginView initialize]):
2940         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2941         * WebCoreSupport/WebSystemInterface.mm:
2942         (InitWebCoreSystemInterface):
2943         * WebView/WebFrame.mm:
2944         (-[WebFrame _paintBehaviorForDestinationContext:]):
2945         * WebView/WebFullScreenController.mm:
2946         (setClipRectForWindow):
2947         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2948         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2949         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2950         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2951
2952 2017-08-31  Andy Estes  <aestes@apple.com>
2953
2954         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2955         https://bugs.webkit.org/show_bug.cgi?id=176175
2956
2957         Reviewed by Brady Eidson.
2958
2959         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2960         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2961         * Plugins/Hosted/WebTextInputWindowController.m:
2962         (-[WebTextInputPanel init]):
2963         * WebCoreSupport/WebSystemInterface.mm:
2964         (InitWebCoreSystemInterface):
2965         * WebView/WebDynamicScrollBarsView.mm:
2966         (-[WebDynamicScrollBarsView scrollWheel:]):
2967         * WebView/WebHTMLView.mm:
2968         (-[WebHTMLView _removeWindowObservers]):
2969         (-[WebHTMLView addWindowObservers]):
2970         * WebView/WebView.mm:
2971         (-[WebView addWindowObserversForWindow:]):
2972         (-[WebView removeWindowObservers]):
2973         (-[WebView viewWillMoveToWindow:]):
2974
2975 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2976
2977         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2978         https://bugs.webkit.org/show_bug.cgi?id=175779
2979         <rdar://problem/22367975>
2980
2981         Reviewed by Tim Horton.
2982
2983         * WebCoreSupport/WebFrameLoaderClient.h:
2984         * WebCoreSupport/WebFrameLoaderClient.mm:
2985         (WebFrameLoaderClient::webGLPolicyForURL const):
2986         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2987
2988 2017-08-30  Andy Estes  <aestes@apple.com>
2989
2990         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2991         https://bugs.webkit.org/show_bug.cgi?id=176093
2992
2993         Reviewed by Eric Carlson.
2994
2995         * WebCoreSupport/WebSystemInterface.mm:
2996         (InitWebCoreSystemInterface):
2997
2998 2017-08-30  Andy Estes  <aestes@apple.com>
2999
3000         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3001         https://bugs.webkit.org/show_bug.cgi?id=176087
3002
3003         Reviewed by Alex Christensen.
3004
3005         * Carbon/CarbonUtils.m:
3006         (getNSAutoreleasePoolCount):
3007         (WebInitForCarbon):
3008         (PoolCleaner):
3009         * Carbon/CarbonWindowAdapter.mm:
3010         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3011         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3012         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3013         (-[CarbonWindowAdapter _windowMovedToRect:]):
3014         * Carbon/HIViewAdapter.m:
3015         * Carbon/HIWebView.mm:
3016         (Draw):
3017         (CreateNSEventAdoptingCGEvent):
3018         (CopyEventCGEvent):
3019         (CreateNSEventWithCarbonClickEvent):
3020         (Click):
3021         (CreateNSEventWithCarbonEvent):
3022         (MouseUp):
3023         (CreateNSEventWithCarbonMouseMoveEvent):
3024         (MouseMoved):
3025         (MouseDragged):
3026         (MouseWheelMoved):
3027         (WindowHandler):
3028         (HIWebViewEventHandler):
3029         * Misc/QuickDrawCompatibility.h: Removed.
3030         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3031         (getCarbonEvent):
3032         (WebNetscapePluginEventHandlerCarbon::keyDown):
3033         (WebNetscapePluginEventHandlerCarbon::keyUp):
3034         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3035         (WebNetscapePluginEventHandlerCocoa::keyDown):
3036         * Plugins/WebNetscapePluginView.mm:
3037         (-[WebNetscapePluginView tellQuickTimeToChill]):
3038
3039 2017-08-29  Andy Estes  <aestes@apple.com>
3040
3041         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3042         https://bugs.webkit.org/show_bug.cgi?id=176046
3043
3044         Reviewed by Alex Christensen.
3045
3046         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3047         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3048
3049         * Misc/WebNSFileManagerExtras.mm:
3050         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3051         (setMetaData): Deleted.
3052         * WebCoreSupport/WebSystemInterface.mm:
3053         (InitWebCoreSystemInterface):
3054
3055 2017-08-28  Andy Estes  <aestes@apple.com>
3056
3057         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3058         https://bugs.webkit.org/show_bug.cgi?id=176039
3059
3060         Reviewed by Alex Christensen.
3061
3062         * WebCoreSupport/WebSystemInterface.mm:
3063         (InitWebCoreSystemInterface):
3064         * WebView/WebPreferences.mm:
3065         (+[WebPreferences _systemCFStringEncoding]):
3066
3067 2017-08-28  Andy Estes  <aestes@apple.com>
3068
3069         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3070         https://bugs.webkit.org/show_bug.cgi?id=176032
3071
3072         Reviewed by Alex Christensen.
3073
3074         * WebCoreSupport/WebSystemInterface.mm:
3075         (InitWebCoreSystemInterface):
3076         * WebView/WebView.mm:
3077         (-[WebView _cachedResponseForURL:]):
3078
3079 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3080
3081         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3082         https://bugs.webkit.org/show_bug.cgi?id=175992
3083         <rdar://problem/34086613>
3084
3085         Reviewed by Daniel Bates.
3086
3087         * WebCoreSupport/WebPlatformStrategies.h:
3088         * WebCoreSupport/WebPlatformStrategies.mm:
3089         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3090         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3091         indicating if secure cookies were accessed.
3092
3093 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3094
3095         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3096         https://bugs.webkit.org/show_bug.cgi?id=170955
3097         <rdar://problem/31697653>
3098
3099         Reviewed by Ryosuke Niwa.
3100
3101         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3102         text is being replaced.
3103
3104         * WebView/WebHTMLView.mm:
3105         (-[WebHTMLView insertText:]):
3106
3107 2017-08-24  Chris Dumez  <cdumez@apple.com>
3108
3109         [Directory Upload] Add basic support for input.webkitdirectory
3110         https://bugs.webkit.org/show_bug.cgi?id=175950
3111         <rdar://problem/33951915>
3112
3113         Reviewed by Geoffrey Garen.
3114
3115         Add private API to toggle Directory Upload support on Mac WebKit1.
3116
3117         * WebView/WebPreferenceKeysPrivate.h:
3118         * WebView/WebPreferences.mm:
3119         (+[WebPreferences initialize]):
3120         (-[WebPreferences setDirectoryUploadEnabled:]):
3121         (-[WebPreferences directoryUploadEnabled]):
3122         * WebView/WebPreferencesPrivate.h:
3123         * WebView/WebView.mm:
3124         (-[WebView _preferencesChanged:]):
3125
3126 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3127
3128         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3129         https://bugs.webkit.org/show_bug.cgi?id=175370
3130         <rdar://problem/33799806>
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         Adjust WebEditorClient for interface changes.
3135
3136         * WebCoreSupport/WebEditorClient.h:
3137
3138 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3139
3140         Remove ChromeClient::scrollbarsModeDidChange
3141         https://bugs.webkit.org/show_bug.cgi?id=175805
3142
3143         Reviewed by Daniel Bates.
3144
3145         * WebCoreSupport/WebChromeClient.h:
3146
3147 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3148
3149         Remove ChromeClient::hasOpenedPopup
3150         https://bugs.webkit.org/show_bug.cgi?id=175804
3151
3152         Reviewed by Sam Weinig.
3153
3154         * WebCoreSupport/WebChromeClient.h:
3155         * WebCoreSupport/WebChromeClient.mm:
3156         (WebChromeClient::hasOpenedPopup const): Deleted.
3157
3158 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3159
3160         Disable access to secure cookies if an HTTPS site loads mixed content
3161         https://bugs.webkit.org/show_bug.cgi?id=157053
3162         <rdar://problem/11290808>
3163
3164         Reviewed by Dan Bates.
3165
3166         * WebCoreSupport/WebPlatformStrategies.h:
3167         * WebCoreSupport/WebPlatformStrategies.mm:
3168         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3169         indicating whether secure cookies should be included in the response.
3170
3171 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3172
3173         [PAL] Move spi/mac directory into PAL
3174         https://bugs.webkit.org/show_bug.cgi?id=175649
3175
3176         Reviewed by Myles C. Maxfield.
3177
3178         * Misc/WebSharingServicePickerController.h:
3179         * WebCoreSupport/WebContextMenuClient.mm:
3180         * WebCoreSupport/WebEditorClient.mm:
3181         * WebCoreSupport/WebSelectionServiceController.mm:
3182         * WebView/WebHTMLView.mm:
3183         * WebView/WebImmediateActionController.h:
3184         * WebView/WebImmediateActionController.mm:
3185         * WebView/WebView.mm:
3186
3187 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3188
3189         [PAL] Relocate SessionID to root
3190         https://bugs.webkit.org/show_bug.cgi?id=175684
3191
3192         Reviewed by Alex Christensen.
3193
3194         * WebCoreSupport/WebFrameNetworkingContext.mm:
3195
3196 2017-08-17  Andreas Kling  <akling@apple.com>
3197
3198         Disable CSS regions at compile time
3199         https://bugs.webkit.org/show_bug.cgi?id=175630
3200
3201         Reviewed by Antti Koivisto.
3202
3203         * Configurations/FeatureDefines.xcconfig:
3204
3205 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3206
3207         [PAL] Move SessionID into PAL
3208         https://bugs.webkit.org/show_bug.cgi?id=174192
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * Misc/WebCache.mm:
3213         (+[WebCache imageForURL:]):
3214         * WebCoreSupport/WebFrameLoaderClient.h:
3215         * WebCoreSupport/WebFrameLoaderClient.mm:
3216         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3217         * WebCoreSupport/WebFrameNetworkingContext.mm:
3218         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3219         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3220         (WebFrameNetworkingContext::storageSession const):
3221         * WebCoreSupport/WebPlatformStrategies.h:
3222         * WebCoreSupport/WebPlatformStrategies.mm:
3223         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3224         * WebKitPrefix.h:
3225
3226 2017-08-16  Andy Estes  <aestes@apple.com>
3227
3228         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3229         https://bugs.webkit.org/show_bug.cgi?id=175648
3230
3231         Reviewed by Tim Horton.
3232
3233         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3234         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3235         (WebPaymentCoordinatorClient::showPaymentUI):
3236
3237 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3238
3239         [PAL] Move spi/ios and spi/win directories into PAL
3240         https://bugs.webkit.org/show_bug.cgi?id=175171
3241
3242         Reviewed by Antti Koivisto.
3243
3244         * WebCoreSupport/WebFrameLoaderClient.mm:
3245         * WebView/WebView.mm:
3246
3247 2017-08-16  Andy Estes  <aestes@apple.com>
3248
3249         [Payment Request] Add an ENABLE flag and an experimental feature preference
3250         https://bugs.webkit.org/show_bug.cgi?id=175622
3251
3252         Reviewed by Tim Horton.
3253
3254         * Configurations/FeatureDefines.xcconfig:
3255
3256 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3257
3258         [PAL] Move Sleep classes into PAL
3259         https://bugs.webkit.org/show_bug.cgi?id=175456
3260
3261         Reviewed by Ryosuke Niwa.
3262
3263         * WebView/WebFullScreenController.h:
3264
3265 2017-08-15  Youenn Fablet  <youenn@apple.com>
3266
3267         [Cache API] Adding generic support for CacheStorage and Cache methods
3268         https://bugs.webkit.org/show_bug.cgi?id=175455
3269
3270         Reviewed by Chris Dumez.
3271
3272         * WebView/WebView.mm:
3273         (-[WebView _commonInitializationWithFrameName:groupName:]):
3274
3275 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3276
3277         Remove Proximity Events and related code
3278         https://bugs.webkit.org/show_bug.cgi?id=175545
3279
3280         Reviewed by Daniel Bates.
3281
3282         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3283         and other related code.
3284
3285         * Configurations/FeatureDefines.xcconfig:
3286
3287 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3288
3289         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3290         https://bugs.webkit.org/show_bug.cgi?id=175504
3291
3292         Reviewed by Sam Weinig.
3293
3294         * Configurations/FeatureDefines.xcconfig:
3295         * DOM/DOMHTMLFormElement.mm:
3296         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3297         * WebCoreSupport/WebFrameLoaderClient.h:
3298
3299 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3300
3301         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3302         https://bugs.webkit.org/show_bug.cgi?id=175557
3303
3304         Reviewed by Jon Lee.
3305
3306         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3307
3308         * Configurations/FeatureDefines.xcconfig:
3309
3310 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3311
3312         Composition underline color is always black
3313         https://bugs.webkit.org/show_bug.cgi?id=174675
3314
3315         Reviewed by Ryosuke Niwa.
3316
3317         * WebView/WebHTMLView.mm:
3318         (extractUnderlines): If NSUnderlineColorAttributeName
3319         is not present use text color for composition underline.
3320         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3321         for composition underline in the plain text case.
3322
3323 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3324
3325         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3326         https://bugs.webkit.org/show_bug.cgi?id=175474
3327         <rdar://problem/33844628>
3328
3329         Reviewed by Wenson Hsieh.
3330
3331         Replaced the build flag by a runtime flag and disabled the feature by default.
3332
3333         * Configurations/FeatureDefines.xcconfig:
3334         * WebView/WebPreferenceKeysPrivate.h:
3335         * WebView/WebPreferences.mm:
3336         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3337         (-[WebPreferences dataTransferItemsEnabled]): Added.
3338         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3339         * WebView/WebPreferencesPrivate.h:
3340         * WebView/WebView.mm:
3341         (-[WebView _preferencesChanged:]):
3342
3343 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3344
3345         Remove ENABLE_GAMEPAD_DEPRECATED
3346         https://bugs.webkit.org/show_bug.cgi?id=175361
3347
3348         Reviewed by Carlos Garcia Campos.
3349
3350         * Configurations/FeatureDefines.xcconfig:
3351
3352 2017-08-09  Chris Dumez  <cdumez@apple.com>
3353
3354         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3355         https://bugs.webkit.org/show_bug.cgi?id=175401
3356
3357         Reviewed by Brady Eidson.
3358
3359         * WebView/WebPreferenceKeysPrivate.h:
3360         * WebView/WebPreferences.mm:
3361         (+[WebPreferences initialize]):
3362         (-[WebPreferences beaconAPIEnabled]): Deleted.
3363         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3364         * WebView/WebPreferencesPrivate.h:
3365         * WebView/WebView.mm:
3366         (-[WebView _preferencesChanged:]):
3367
3368 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3369
3370         [PAL] Move spi/cocoa and spi/cg directories into PAL
3371         https://bugs.webkit.org/show_bug.cgi?id=175175
3372
3373         Reviewed by Myles C. Maxfield.
3374
3375         * History/WebHistory.mm:
3376         * Misc/WebDownload.mm:
3377         * Misc/WebKitNSStringExtras.mm:
3378         * Plugins/Hosted/NetscapePluginHostManager.mm:
3379         * Plugins/WebPluginDatabase.mm:
3380         * WebCoreSupport/WebFrameLoaderClient.mm:
3381         * WebInspector/WebNodeHighlight.mm:
3382         * WebView/WebHTMLView.mm:
3383         * WebView/WebIndicateLayer.mm:
3384         * WebView/WebView.mm:
3385         * WebView/WebViewData.h:
3386
3387 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3388
3389         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3390         https://bugs.webkit.org/show_bug.cgi?id=175392
3391         <rdar://problem/33783207>
3392
3393         Reviewed by Tim Horton and Megan Gardner.
3394
3395         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3396
3397         * Configurations/FeatureDefines.xcconfig:
3398
3399 2017-08-09  Daniel Bates  <dabates@apple.com>
3400
3401         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3402         https://bugs.webkit.org/show_bug.cgi?id=175247
3403         <rdar://problem/33679804>
3404
3405         Reviewed by Brady Eidson.
3406
3407         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3408         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3409         clients that need to make use of this information at this time. If such a needs comes up
3410         then we can expose API/SPI similar to what we do for WebKit.
3411
3412         * WebCoreSupport/WebFrameLoaderClient.h:
3413         * WebCoreSupport/WebFrameLoaderClient.mm:
3414         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3415
3416 2017-08-08  Brady Eidson  <beidson@apple.com>
3417
3418         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3419         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3420
3421         Reviewed by Andy Estes.
3422
3423         * Misc/WebKitVersionChecks.h:
3424         * WebCoreSupport/WebFrameLoaderClient.mm:
3425         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3426           the app is linked against new WebKit with the new behavior.
3427
3428 2017-08-07  Devin Rousso  <drousso@apple.com>
3429
3430         Web Inspector: Preview Canvas path when viewing a recording
3431         https://bugs.webkit.org/show_bug.cgi?id=174967
3432
3433         Reviewed by Brian Burg.
3434
3435         * WebView/WebPreferenceKeysPrivate.h:
3436         * WebView/WebPreferences.mm:
3437         (+[WebPreferences initialize]):
3438         (-[WebPreferences inspectorAdditionsEnabled]):
3439         (-[WebPreferences setInspectorAdditionsEnabled:]):
3440         * WebView/WebPreferencesPrivate.h:
3441         * WebView/WebView.mm:
3442         (-[WebView _preferencesChanged:]):
3443         Add plumbing for new InspectorAdditions runtime flag.
3444
3445 2017-08-07  Brian Burg  <bburg@apple.com>
3446
3447         Remove CANVAS_PATH compilation guard
3448         https://bugs.webkit.org/show_bug.cgi?id=175207
3449
3450         Reviewed by Sam Weinig.
3451
3452         * Configurations/FeatureDefines.xcconfig:
3453
3454 2017-08-04  Youenn Fablet  <youenn@apple.com>
3455
3456         [Cache API] Add Cache and CacheStorage IDL definitions
3457         https://bugs.webkit.org/show_bug.cgi?id=175201
3458
3459         Reviewed by Brady Eidson.
3460
3461         * WebView/WebPreferenceKeysPrivate.h:
3462         * WebView/WebPreferences.mm:
3463         (+[WebPreferences initialize]):
3464         (-[WebPreferences cacheAPIEnabled]):
3465         (-[WebPreferences setCacheAPIEnabled:]):
3466         * WebView/WebPreferencesPrivate.h:
3467         * WebView/WebView.mm:
3468         (-[WebView _preferencesChanged:]):
3469
3470 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3471
3472         Unreviewed, rolling out r220271.
3473
3474         Rolling out due to Layout Test failing on iOS Simulator.
3475
3476         Reverted changeset:
3477
3478         "Remove STREAMS_API compilation guard"
3479         https://bugs.webkit.org/show_bug.cgi?id=175165
3480         http://trac.webkit.org/changeset/220271
3481
3482 2017-08-04  Youenn Fablet  <youenn@apple.com>
3483
3484         Remove STREAMS_API compilation guard
3485         https://bugs.webkit.org/show_bug.cgi?id=175165
3486
3487         Reviewed by Darin Adler.
3488
3489         * Configurations/FeatureDefines.xcconfig:
3490         * WebView/WebPreferences.mm:
3491         (+[WebPreferences initialize]):
3492         * WebView/WebView.mm:
3493         (-[WebView _preferencesChanged:]):
3494
3495 2017-08-03  Brian Burg  <bburg@apple.com>
3496
3497         Remove ENABLE(WEB_SOCKET) guards
3498         https://bugs.webkit.org/show_bug.cgi?id=167044
3499
3500         Reviewed by Joseph Pecoraro.
3501
3502         * Configurations/FeatureDefines.xcconfig:
3503         * WebView/WebPreferencesPrivate.h:
3504
3505 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3506
3507         [PAL] Move spi/cf directory into PAL
3508         https://bugs.webkit.org/show_bug.cgi?id=175057
3509
3510         Reviewed by Antti Koivisto.
3511
3512         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3513         * Plugins/WebNetscapePluginStream.mm:
3514         * WebCoreSupport/WebFrameNetworkingContext.mm:
3515         * WebView/WebPreferences.mm:
3516         * WebView/WebView.mm:
3517
3518 2017-08-03  Youenn Fablet  <youenn@apple.com>
3519
3520         Remove FETCH_API compilation guard
3521         https://bugs.webkit.org/show_bug.cgi?id=175154
3522
3523         Reviewed by Chris Dumez.
3524
3525         * Configurations/FeatureDefines.xcconfig:
3526         * WebView/WebPreferences.mm:
3527         (+[WebPreferences initialize]):
3528         * WebView/WebView.mm:
3529         (-[WebView _preferencesChanged:]):
3530
3531 2017-08-03  Brady Eidson  <beidson@apple.com>
3532
3533         Add SW IDLs and stub out basic functionality.
3534         https://bugs.webkit.org/show_bug.cgi?id=175115
3535
3536         Reviewed by Chris Dumez.
3537
3538         * Configurations/FeatureDefines.xcconfig:
3539
3540 2017-08-02  Sam Weinig  <sam@webkit.org>
3541
3542         [WebIDL] Convert MutationCallback to be a normal generated callback
3543         https://bugs.webkit.org/show_bug.cgi?id=174140
3544
3545         Reviewed by Darin Adler.
3546
3547         * DOM/DOMDocument.mm:
3548         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3549         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3550         Pass, now necessary, Document to NativeNodeFilter constructor.
3551
3552 2017-08-01  Chris Dumez  <cdumez@apple.com>
3553
3554         Add initial support for navigator.sendBeacon
3555         https://bugs.webkit.org/show_bug.cgi?id=175007
3556         <rdar://problem/33547728>
3557
3558         Reviewed by Sam Weinig.
3559
3560         Add setting to toggle support for the Beacon API (it is disabled by default).
3561
3562         * WebView/WebPreferenceKeysPrivate.h:
3563         * WebView/WebPreferences.mm:
3564         (+[WebPreferences initialize]):
3565         (-[WebPreferences beaconAPIEnabled]):
3566         (-[WebPreferences setBeaconAPIEnabled:]):
3567         * WebView/WebPreferencesPrivate.h:
3568         * WebView/WebView.mm:
3569         (-[WebView _preferencesChanged:]):
3570
3571 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3572
3573         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3574         https://bugs.webkit.org/show_bug.cgi?id=174437
3575
3576         Reviewed by Darin Adler.
3577
3578         Remove redundant Web- prefix from classes in WebKit namespace.
3579
3580         * WebView/WebView.mm:
3581         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3582         * WebView/WebViewData.h:
3583         * WebView/WebViewData.mm:
3584
3585 2017-07-26  Brian Burg  <bburg@apple.com>
3586
3587         Remove WEB_TIMING feature flag
3588         https://bugs.webkit.org/show_bug.cgi?id=174795
3589
3590         Reviewed by Alex Christensen.
3591
3592         * Configurations/FeatureDefines.xcconfig:
3593
3594 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3595
3596         Async image decoding for large images should be disabled after the first time a tile is painted
3597         https://bugs.webkit.org/show_bug.cgi?id=174451
3598         <rdar://problem/31246421>
3599
3600         Reviewed by Simon Fraser.
3601
3602         * WebView/WebFrame.mm:
3603         (-[WebFrame _paintBehaviorForDestinationContext:]):
3604         (-[WebFrame _drawRect:contentsOnly:]):
3605         * WebView/WebHTMLView.mm:
3606         (imageFromRect):
3607
3608 2017-07-23  Darin Adler  <darin@apple.com>
3609
3610         More NeverDestroyed and related cleanup
3611         https://bugs.webkit.org/show_bug.cgi?id=174745
3612
3613         Reviewed by Alex Christensen.
3614
3615         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3616         for names that aren't even used in this file.
3617         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3618         -[NSArray arrayWithObject:].
3619         (-[DOMNode absoluteQuads]): Ditto.
3620         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3621         of writing out various types.
3622         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3623         syntax instea of -[NSArray arrayWithObject:].
3624         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3625         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3626         of writing out various types.
3627         (-[DOMHTMLImageElement mimeType]): Ditto.
3628
3629 2017-07-24  Chris Dumez  <cdumez@apple.com>
3630
3631         ExceptionCode enumeration should use modern exception names
3632         https://bugs.webkit.org/show_bug.cgi?id=174794
3633
3634         Reviewed by Geoffrey Garen.
3635
3636         * DOM/ExceptionHandlers.mm:
3637         (raiseNotSupportedErrorException):
3638
3639 2017-07-23  Chris Dumez  <cdumez@apple.com>
3640
3641         Drop ExceptionCodeDescription class
3642         https://bugs.webkit.org/show_bug.cgi?id=174757
3643
3644         Reviewed by Darin Adler.
3645
3646         Stop using ExceptionCodeDescription.
3647
3648         * DOM/ExceptionHandlers.mm:
3649         (raiseDOMErrorException):
3650
3651 2017-07-21  Andreas Kling  <akling@apple.com>
3652
3653         Use more references in event dispatch code
3654         https://bugs.webkit.org/show_bug.cgi?id=174681
3655
3656         Reviewed by Geoffrey Garen.
3657
3658         * DOM/ObjCEventListener.h:
3659         * DOM/ObjCEventListener.mm:
3660         (WebCore::ObjCEventListener::handleEvent):
3661         * WebCoreSupport/WebFrameLoaderClient.mm:
3662         (NetscapePluginWidget::handleEvent):
3663
3664 2017-07-21  Brady Eidson  <beidson@apple.com>
3665
3666         Get rid of WebCore IconDatabase code.
3667         https://bugs.webkit.org/show_bug.cgi?id=174700
3668
3669         Reviewed by Tim Horton.
3670
3671         * Misc/WebCoreStatistics.mm:
3672         (+[WebCoreStatistics iconPageURLMappingCount]):
3673         (+[WebCoreStatistics iconRetainedPageURLCount]):
3674         (+[WebCoreStatistics iconRecordCount]):
3675         (+[WebCoreStatistics iconsWithDataCount]):
3676         * WebCoreSupport/WebFrameLoaderClient.h:
3677         * WebCoreSupport/WebFrameLoaderClient.mm:
3678         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3679         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3680         * WebView/WebView.mm:
3681         (-[WebView mainFrameIconURL]):
3682
3683 2017-07-20  Chris Dumez  <cdumez@apple.com>
3684
3685         Drop legacy XPathException type
3686         https://bugs.webkit.org/show_bug.cgi?id=174679
3687
3688         Reviewed by Sam Weinig.
3689
3690         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3691         no longer expose XPathException.
3692
3693         * DOM/ExceptionHandlers.mm:
3694         (raiseDOMErrorException):
3695
3696 2017-07-20  Chris Dumez  <cdumez@apple.com>
3697
3698         Unreviewed, rolling out r219706.
3699
3700         Broke iOS build
3701
3702         Reverted changeset:
3703
3704         "Drop legacy XPathException type"
3705         https://bugs.webkit.org/show_bug.cgi?id=174679
3706         http://trac.webkit.org/changeset/219706
3707
3708 2017-07-20  Chris Dumez  <cdumez@apple.com>
3709
3710         Drop legacy XPathException type
3711         https://bugs.webkit.org/show_bug.cgi?id=174679
3712
3713         Reviewed by Sam Weinig.
3714
3715         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3716         no longer expose XPathException.
3717
3718         * DOM/ExceptionHandlers.mm:
3719         (raiseDOMErrorException):
3720         * WebKit.exp:
3721
3722 2017-07-20  Chris Dumez  <cdumez@apple.com>
3723
3724         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3725         https://bugs.webkit.org/show_bug.cgi?id=174660
3726
3727         Reviewed by Geoffrey Garen.
3728
3729         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3730         This essentially replaces a branch to figure out if the new size is less or greater than the
3731         current size by an assertion.
3732
3733         * Plugins/WebNetscapePluginView.mm:
3734         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3735
3736 2017-07-20  Brady Eidson  <beidson@apple.com>
3737
3738         Deprecate WebIconDatabase in WebKitLegacy/mac.
3739         https://bugs.webkit.org/show_bug.cgi?id=174607
3740
3741         Reviewed by Alex Christensen.
3742
3743         This patch:
3744         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3745         2 - Guts the class to where it can only return the default icon at the small size
3746         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3747             use something else or to not do anything.
3748         
3749         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3750         and that patch will remove all of the last remnants of WebIconDatabase.
3751         
3752         * History/WebHistoryItem.mm:
3753         (-[WebHistoryItem icon]):
3754
3755         * Misc/WebIconDatabase.h:
3756         * Misc/WebIconDatabase.mm:
3757         (-[WebIconDatabase init]):
3758         (-[WebIconDatabase iconForURL:withSize:cache:]):
3759         (-[WebIconDatabase iconForURL:withSize:]):
3760         (-[WebIconDatabase defaultIconWithSize:]):
3761         (-[WebIconDatabase defaultIconForURL:withSize:]):
3762         (-[WebIconDatabase iconURLForURL:]):
3763         (-[WebIconDatabase retainIconForURL:]):
3764         (-[WebIconDatabase releaseIconForURL:]):
3765         (+[WebIconDatabase delayDatabaseCleanup]):
3766         (+[WebIconDatabase allowDatabaseCleanup]):
3767         (-[WebIconDatabase setDelegate:]):
3768         (-[WebIconDatabase delegate]):
3769         (+[WebIconDatabase initialize]): Deleted.
3770         (-[WebIconDatabase isEnabled]): Deleted.
3771         (-[WebIconDatabase setEnabled:]): Deleted.
3772         (-[WebIconDatabase removeAllIcons]): Deleted.
3773         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3774         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3775         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3776         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3777         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3778         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3779         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3780         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3781         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3782         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3783         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3784         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3785         (-[WebIconDatabase _databaseDirectory]): Deleted.
3786         (webGetNSImage): Deleted.
3787
3788         * Misc/WebIconDatabaseDelegate.h: Removed.
3789         * Misc/WebIconDatabaseInternal.h: Removed.
3790         * Misc/WebIconDatabasePrivate.h: Removed.
3791
3792         * WebCoreSupport/WebFrameLoaderClient.mm:
3793         (webGetNSImage):
3794
3795         * WebCoreSupport/WebIconDatabaseClient.mm:
3796         (WebIconDatabaseClient::didRemoveAllIcons):
3797         (WebIconDatabaseClient::didImportIconURLForPageURL):
3798
3799         * WebView/WebView.mm:
3800         (-[WebView setFrameLoadDelegate:]):
3801         (-[WebView mainFrameIcon]):
3802
3803 2017-07-18  Andy Estes  <aestes@apple.com>
3804
3805         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3806         https://bugs.webkit.org/show_bug.cgi?id=174631
3807
3808         Reviewed by Tim Horton.
3809
3810         * Configurations/Base.xcconfig:
3811
3812 2017-07-18  Andy Estes  <aestes@apple.com>
3813
3814         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3815         https://bugs.webkit.org/show_bug.cgi?id=174631
3816
3817         Reviewed by Sam Weinig.
3818
3819         * Configurations/Base.xcconfig:
3820
3821 2017-07-18  Andy Estes  <aestes@apple.com>
3822
3823         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3824         https://bugs.webkit.org/show_bug.cgi?id=174631
3825
3826         Reviewed by Dan Bernstein.
3827
3828         * Configurations/Base.xcconfig:
3829
3830 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3831
3832         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3833         https://bugs.webkit.org/show_bug.cgi?id=174640
3834         <rdar://problem/33297400>
3835
3836         Reviewed by Tim Horton.
3837
3838         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3839         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3840         web thread here, to match the other WebView drag and drop SPI methods.
3841
3842         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3843         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3844         should make this robust against future UIKit changes that could make this no longer the case.
3845
3846         * WebView/WebView.mm:
3847         (-[WebView _requestStartDataInteraction:globalPosition:]):
3848         (-[WebView _dataInteractionCaretRect]):
3849
3850 2017-07-18  Andy Estes  <aestes@apple.com>
3851
3852         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3853         https://bugs.webkit.org/show_bug.cgi?id=174631
3854
3855         Reviewed by Darin Adler.
3856
3857         * Configurations/Base.xcconfig:
3858
3859 2017-07-17  Sam Weinig  <sam@webkit.org>
3860
3861         [WebIDL] Remove custom bindings that require non-caching JS strings
3862         https://bugs.webkit.org/show_bug.cgi?id=174552
3863
3864         Reviewed by Darin Adler.
3865
3866         * DOM/DOMHTMLCanvasElement.mm:
3867         (-[DOMHTMLCanvasElement toDataURL:]):
3868         Update to account for implementation now returning an UncachedString.
3869
3870 2017-07-17  Darin Adler  <darin@apple.com>
3871
3872         Improve use of NeverDestroyed
3873         https://bugs.webkit.org/show_bug.cgi?id=174348
3874
3875         Reviewed by Sam Weinig.
3876
3877         * Misc/WebStringTruncator.mm:
3878         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3879         NeverDestroyed<RetainPtr> with just an NSFont * global.
3880
3881         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3882         NeverDestroyed.h.
3883         * Storage/WebDatabaseManager.mm: Ditto.
3884         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3885         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3886
3887         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3888         (aeDescFromJSValue): Removed double hashing by using the return value from
3889         add rather than calling contains before calling add.
3890
3891 2017-07-14  Jer Noble  <jer.noble@apple.com>
3892
3893         Allow clients to override their own hardware media requirements where no fallback media exists.
3894         https://bugs.webkit.org/show_bug.cgi?id=174426
3895         <rdar://problem/32537704>
3896
3897         Reviewed by Eric Carlson.
3898
3899         Add a new WebPreferences property to control WebCore's new
3900         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3901
3902         * WebView/WebPreferenceKeysPrivate.h:
3903         * WebView/WebPreferences.mm:
3904         (+[WebPreferences initialize]):
3905         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3906         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3907         * WebView/WebPreferencesPrivate.h:
3908         * WebView/WebView.mm:
3909         (-[WebView _preferencesChanged:]):
3910
3911 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3912
3913         Async image decoding for large images should be disabled by default
3914         https://bugs.webkit.org/show_bug.cgi?id=174432
3915
3916         Reviewed by Simon Fraser.
3917
3918         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3919         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3920         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3921            a child view instead of propagating PaintBehaviorSnapshotting.
3922         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3923            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3924
3925         * WebView/WebFrame.mm:
3926         (-[WebFrame _paintBehaviorForDestinationContext:]):
3927         (-[WebFrame _drawRect:contentsOnly:]):
3928         * WebView/WebHTMLView.mm:
3929         (imageFromRect):
3930
3931 2017-07-12  Daniel Bates  <dabates@apple.com>
3932
3933         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3934         https://bugs.webkit.org/show_bug.cgi?id=174427
3935
3936         Rubber-stamped by Brady Eidson.
3937
3938         * WebView/WebPDFView.mm:
3939         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3940
3941 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3942
3943         Unreviewed, rolling out r219401.
3944
3945         This revision rolled out the previous patch, but after talking
3946         with reviewer, a rebaseline is what was needed.Rolling back in
3947         before rebaseline.
3948
3949         Reverted changeset:
3950
3951         "Unreviewed, rolling out r219379."
3952         https://bugs.webkit.org/show_bug.cgi?id=174400
3953         http://trac.webkit.org/changeset/219401
3954
3955 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3956
3957         Unreviewed, rolling out r219379.
3958
3959         This revision caused a consistent failure in the test
3960         fast/dom/Window/property-access-on-cached-window-after-frame-
3961         removed.html.
3962
3963         Reverted changeset:
3964
3965         "Remove NAVIGATOR_HWCONCURRENCY"
3966         https://bugs.webkit.org/show_bug.cgi?id=174400
3967         http://trac.webkit.org/changeset/219379
3968
3969 2017-07-11  Dean Jackson  <dino@apple.com>
3970
3971         Remove NAVIGATOR_HWCONCURRENCY
3972         https://bugs.webkit.org/show_bug.cgi?id=174400
3973
3974         * Configurations/FeatureDefines.xcconfig:
3975
3976 2017-07-11  Dean Jackson  <dino@apple.com>
3977
3978         Rolling out r219372.
3979
3980         * Configurations/FeatureDefines.xcconfig:
3981
3982 2017-07-11  Dean Jackson  <dino@apple.com>
3983
3984         Remove NAVIGATOR_HWCONCURRENCY
3985         https://bugs.webkit.org/show_bug.cgi?id=174400
3986
3987         * Configurations/FeatureDefines.xcconfig:
3988
3989 2017-07-03  Brian Burg  <bburg@apple.com>
3990
3991         Web Replay: remove some unused code
3992         https://bugs.webkit.org/show_bug.cgi?id=173903
3993
3994         Rubber-stamped by Joseph Pecoraro.
3995
3996         * Configurations/FeatureDefines.xcconfig:
3997
3998 2017-07-09  Brady Eidson  <beidson@apple.com>
3999
4000         Remove some obsolete WebKitVersionChecks.
4001         https://bugs.webkit.org/show_bug.cgi?id=174294
4002
4003         Reviewed by Dan Bernstein.
4004
4005         * Misc/WebKitVersionChecks.h:
4006
4007         * WebView/WebHTMLView.mm:
4008         (-[WebHTMLView hitTest:]):
4009
4010         * WebView/WebView.mm:
4011         (shouldRespectPriorityInCSSAttributeSetters):
4012         (-[WebView _commonInitializationWithFrameName:groupName:]):
4013         (-[WebView _preferencesChanged:]):
4014         (shouldTransformsAffectOverflow): Deleted.
4015         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
4016
4017 2017-07-08  Brady Eidson  <beidson@apple.com>
4018
4019         Remove some obsolete RuntimeApplicationChecks.
4020         https://bugs.webkit.org/show_bug.cgi?id=174293
4021
4022         Reviewed by Dan Bernstein.
4023
4024         * Misc/WebKitVersionChecks.h:
4025         * WebView/WebView.mm:
4026         (+[WebView enableWebThread]):
4027         (-[WebView _needsPreHTML5ParserQuirks]):
4028
4029 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
4030
4031         Drop NOSNIFF compile flag
4032         https://bugs.webkit.org/show_bug.cgi?id=174289
4033
4034         Reviewed by Michael Catanzaro.
4035
4036         * Configurations/FeatureDefines.xcconfig:
4037
4038 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
4039
4040         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
4041         https://bugs.webkit.org/show_bug.cgi?id=174150
4042
4043         Reviewed by Mark Lam.
4044
4045         * DOM/DOM.mm:
4046         (lookupElementClass):
4047
4048 2017-07-06  Brady Eidson  <beidson@apple.com>
4049
4050         Add logging to first attempt to use the WebIconDatabase class.
4051         https://bugs.webkit.org/show_bug.cgi?id=174190
4052
4053         Reviewed by Andy Estes.
4054
4055         * Misc/WebIconDatabase.mm:
4056         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
4057         * Misc/WebKitVersionChecks.h:
4058
4059 2017-07-06  Matt Lewis  <jlewis3@apple.com>
4060
4061         Unreviewed, rolling out r219178.
4062
4063         This caused a consistent failure with the API test
4064         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
4065
4066         Reverted changeset:
4067
4068         "[WTF] Clean up StringStatics.cpp by using
4069         LazyNeverDestroyed<> for Atoms"
4070         https://bugs.webkit.org/show_bug.cgi?id=174150
4071         http://trac.webkit.org/changeset/219178
4072
4073 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
4074
4075         [WTF] Move SoftLinking.h into WTF
4076         https://bugs.webkit.org/show_bug.cgi?id=174000
4077
4078         Reviewed by Alex Christensen.
4079
4080         * Plugins/WebNetscapePluginView.mm:
4081         * Plugins/WebPluginController.mm:
4082         * WebCoreSupport/WebInspectorClient.mm:
4083         * WebView/WebFullScreenController.mm:
4084         * WebView/WebImmediateActionController.mm:
4085         * WebView/WebView.mm:
4086
4087 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
4088
4089         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
4090         https://bugs.webkit.org/show_bug.cgi?id=174150
4091
4092         Reviewed by Mark Lam.
4093
4094         * DOM/DOM.mm:
4095         (lookupElementClass):
4096
4097 2017-07-05  Brady Eidson  <beidson@apple.com>
4098
4099         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
4100         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
4101
4102         Reviewed by Alex Christensen.
4103
4104         Adopt to the new constructor for FrameLoadRequest.
4105
4106         * WebView/WebPDFView.mm: