e6c9f0ac51dd61a8b36776dc1c198ea5731dee6e
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
4         https://bugs.webkit.org/show_bug.cgi?id=193129
5
6         Reviewed by Tim Horton.
7
8         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
9
10         * WebCoreSupport/WebEditorClient.mm:
11         (WebEditorClient::registerUndoOrRedoStep):
12         (undoNameForEditAction): Deleted.
13
14 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
15
16         Add support for using the current text selection as the find string on iOS
17         https://bugs.webkit.org/show_bug.cgi?id=193034
18         <rdar://problem/45138739>
19
20         Reviewed by Tim Horton.
21
22         Add a method stub for WebKitLegacy.
23
24         * WebCoreSupport/WebEditorClient.h:
25
26 2019-01-01  Jeff Miller  <jeffm@apple.com>
27
28         Update user-visible copyright strings to include 2019
29         https://bugs.webkit.org/show_bug.cgi?id=192811
30
31         Reviewed by Mark Lam.
32
33         * Info.plist:
34
35 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
36
37         Use Ref<> as much as possible
38         https://bugs.webkit.org/show_bug.cgi?id=192808
39
40         Reviewed by Alex Christensen.
41
42         * DOM/DOM.mm:
43         (-[DOMNode getPreviewSnapshotImage:andRects:]):
44         * Plugins/Hosted/NetscapePluginHostManager.mm:
45         (WebKit::NetscapePluginHostManager::instantiatePlugin):
46         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
47         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
48         (WebKit::NetscapePluginInstanceProxy::loadRequest):
49         * Plugins/WebNetscapePluginView.mm:
50         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
51         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
52         * WebCoreSupport/WebContextMenuClient.mm:
53         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
54         * WebCoreSupport/WebFrameLoaderClient.mm:
55         (WebFrameLoaderClient::transitionToCommittedForNewPage):
56         * WebView/WebFrame.mm:
57         (-[WebFrame getDictationResultRanges:andMetadatas:]):
58         * WebView/WebHTMLView.mm:
59         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
60         * WebView/WebView.mm:
61         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
62         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
63
64 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
65
66         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
67         https://bugs.webkit.org/show_bug.cgi?id=192821
68
69         Reviewed by Chris Dumez.
70
71         When a window becomes occluded, the window server informs the application.
72         This should be used to suspend any work that is not visible by the user.
73
74         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
75         In some cases, that lead to performance impact (see radar).
76
77         This patch adds an observer for the occlusion notification. I tried to stick
78         with the same names used by WebKit2.
79
80         * WebView/WebView.mm:
81         (-[WebView _isViewVisible]):
82         (-[WebView addWindowObserversForWindow:]):
83         (-[WebView removeWindowObservers]):
84         (-[WebView _windowDidChangeOcclusionState:]):
85
86 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
87
88         [WebAuthN] Add a runtime flag for local authenticator
89         https://bugs.webkit.org/show_bug.cgi?id=192792
90         <rdar://problem/46798738>
91
92         Reviewed by Brent Fulgham.
93
94         * WebView/WebPreferenceKeysPrivate.h:
95         * WebView/WebPreferences.mm:
96         (+[WebPreferences initialize]):
97         (-[WebPreferences webAuthenticationEnabled]): Deleted.
98         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
99         * WebView/WebPreferencesPrivate.h:
100         * WebView/WebView.mm:
101         (-[WebView _preferencesChanged:]):
102
103 2018-12-20  Chris Dumez  <cdumez@apple.com>
104
105         Use Optional::valueOr() instead of Optional::value_or()
106         https://bugs.webkit.org/show_bug.cgi?id=192933
107
108         Reviewed by Geoffrey Garen.
109
110         * WebCoreSupport/WebSecurityOrigin.mm:
111         (-[WebSecurityOrigin port]):
112
113 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
114
115         Unreviewed, rolling out r239417.
116
117         Introduced two API test failures on macOS.
118
119         Reverted changeset:
120
121         "<rdar://problem/46194315> macOS: WebKit1 does not handle
122         occlusion changes"
123         https://bugs.webkit.org/show_bug.cgi?id=192821
124         https://trac.webkit.org/changeset/239417
125
126 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
127
128         WKWebView default UA doesn't freeze the build number
129         https://bugs.webkit.org/show_bug.cgi?id=192809
130         <rdar://problem/44687185>
131
132         Reviewed by Andy Estes.
133
134         Always reports the frozen build number.
135
136         * WebView/WebView.mm:
137         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
138         actual build number through this method call.
139         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
140
141 2018-12-19  Chris Dumez  <cdumez@apple.com>
142
143         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
144         https://bugs.webkit.org/show_bug.cgi?id=192728
145         <rdar://problem/46746779>
146
147         Reviewed by Geoff Garen.
148
149         * DOM/*:
150         * Plugins/*:
151         * WebCoreSupport/*:
152         * WebView/*:
153
154 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
155
156         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
157         https://bugs.webkit.org/show_bug.cgi?id=192821
158
159         Reviewed by Chris Dumez.
160
161         When a window becomes occluded, the window server informs the application.
162         This should be used to suspend any work that is not visible by the user.
163
164         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
165         In some cases, that lead to performance impact (see radar).
166
167         This patch adds an observer for the occlusion notification. I tried to stick
168         with the same names used by WebKit2.
169
170         * WebView/WebView.mm:
171         (-[WebView _isViewVisible]):
172         (-[WebView addWindowObserversForWindow:]):
173         (-[WebView removeWindowObservers]):
174         (-[WebView _windowDidChangeOcclusionState:]):
175
176 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
177
178         Allow clients to set the navigator platform
179         https://bugs.webkit.org/show_bug.cgi?id=192735
180
181         Reviewed by Tim Horton.
182
183         Add stubs to fill out the added functionality in FrameLoaderClient.
184
185         * WebCoreSupport/WebFrameLoaderClient.h:
186         * WebCoreSupport/WebFrameLoaderClient.mm:
187         (WebFrameLoaderClient::navigatorPlatform):
188
189 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
190
191         offsetLeft and offsetParent should adjust across shadow boundaries
192         https://bugs.webkit.org/show_bug.cgi?id=157437
193         <rdar://problem/26154021>
194
195         Reviewed by Simon Fraser.
196
197         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
198
199         * DOM/DOMElement.mm:
200         (-[DOMElement offsetLeft]):
201         (-[DOMElement offsetTop]):
202         (-[DOMElement offsetParent]):
203
204 2018-12-17  Zalan Bujtas  <zalan@apple.com>
205
206         Unreviewed build fix.
207
208         * WebView/WebFrame.mm:
209         (-[WebFrame getDictationResultRanges:andMetadatas:]):
210
211 2018-12-15  Darin Adler  <darin@apple.com>
212
213         Use warning-ignoring macros more consistently and simply
214         https://bugs.webkit.org/show_bug.cgi?id=192743
215
216         Reviewed by Mark Lam.
217
218         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
219         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
220         compilers in Objective-C++ code.
221
222         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
223         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
224         accomodate non-clang compilers here. Also use #pragma once, add a missing
225         "explicit" and fix conditionals.
226
227 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
228
229         Make TextInputController.legacyAttributedString take DOM nodes and offsets
230         https://bugs.webkit.org/show_bug.cgi?id=192653
231
232         Reviewed by Wenson Hsieh.
233
234         * WebView/WebHTMLView.mm:
235         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
236
237 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
238
239         Implement feature flag for CSS Typed OM
240         https://bugs.webkit.org/show_bug.cgi?id=192610
241
242         Reviewed by Ryosuke Niwa.
243
244         * Configurations/FeatureDefines.xcconfig:
245
246 2018-12-11  Tim Horton  <timothy_horton@apple.com>
247
248         WebCore shouldn't have a Objective-C class named NSCursor
249         https://bugs.webkit.org/show_bug.cgi?id=192602
250         <rdar://problem/46615532>
251
252         Reviewed by Wenson Hsieh.
253
254         * WebView/WebFrameView.mm:
255         (-[WebFrameView keyDown:keyDown:]):
256         * WebView/WebHTMLView.mm:
257         (-[WebHTMLView keyDown:]):
258         (-[WebHTMLView performKeyEquivalent:]):
259         Only use NSCursor on macOS.
260
261 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
262
263         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
264         https://bugs.webkit.org/show_bug.cgi?id=192573
265
266         Reviewed by Simon Fraser.
267
268         * Configurations/FeatureDefines.xcconfig:
269
270 2018-12-10  Antti Koivisto  <antti@apple.com>
271
272         Rename "forced style recalc" to "full style rebuild"
273         https://bugs.webkit.org/show_bug.cgi?id=192572
274
275         Reviewed by Zalan Bujtas.
276
277         * WebView/WebHTMLView.mm:
278         (-[WebHTMLView setNeedsToApplyStyles:]):
279
280 2018-12-10  Darin Adler  <darin@apple.com>
281
282         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
283         https://bugs.webkit.org/show_bug.cgi?id=192533
284         rdar://problem/45732710
285
286         Reviewed by Anders Carlsson.
287
288         * Plugins/Hosted/NetscapePluginHostProxy.mm:
289         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
290
291 2018-12-10  Darin Adler  <darin@apple.com>
292
293         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
294         https://bugs.webkit.org/show_bug.cgi?id=192532
295         rdar://problem/45731047
296
297         Reviewed by Chris Dumez.
298
299         * Plugins/Hosted/NetscapePluginHostManager.mm:
300         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
301         * Plugins/Hosted/NetscapePluginHostProxy.mm:
302         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
303
304 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
305
306         Turn WritingDirection into an enum class
307         https://bugs.webkit.org/show_bug.cgi?id=192401
308         Work towards <rdar://problem/42075638>
309
310         Reviewed by Dan Bernstein.
311
312         Change WritingDirection from an enum to an enum class. No change in behavior.
313
314         * WebView/WebHTMLView.mm:
315         (-[WebHTMLView toggleBaseWritingDirection:]):
316         (-[WebHTMLView changeBaseWritingDirection:]):
317         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
318
319 2018-12-03  Alex Christensen  <achristensen@webkit.org>
320
321         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
322         https://bugs.webkit.org/show_bug.cgi?id=192272
323
324         Reviewed by Brady Eidson.
325
326         * WebCoreSupport/WebFrameLoaderClient.h:
327         * WebCoreSupport/WebFrameLoaderClient.mm:
328         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
329
330 2018-12-03  Jer Noble  <jer.noble@apple.com>
331
332         Get rid of old, dead Mac video fullscreen code.
333         https://bugs.webkit.org/show_bug.cgi?id=192315
334
335         Reviewed by Eric Carlson.
336
337         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
338         is no longer supported in the Mac port.
339
340         * WebView/WebVideoFullscreenController.h: Removed.
341         * WebView/WebVideoFullscreenController.mm: Removed.
342         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
343         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
344         * WebView/WebView.mm:
345         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
346         (-[WebView _exitVideoFullscreen]):
347
348 2018-12-03  Daniel Bates  <dabates@apple.com>
349
350         [iOS] Do not handle key events that are key commands
351         https://bugs.webkit.org/show_bug.cgi?id=191608
352         <rdar://problem/46046013>
353
354         Reviewed by Ryosuke Niwa.
355
356         A key down event may be associated with a key command. If it is then we want to execute the
357         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
358         event as a key command to find out.
359
360         * WebView/WebHTMLView.mm:
361         (-[WebHTMLView _handleEditingKeyEvent:]):
362
363 2018-12-02  Zalan Bujtas  <zalan@apple.com>
364
365         Add a runtime feature flag for LayoutFormattingContext.
366         https://bugs.webkit.org/show_bug.cgi?id=192280
367
368         Reviewed by Simon Fraser.
369
370         * Configurations/FeatureDefines.xcconfig:
371
372 2018-11-30  Alex Christensen  <achristensen@webkit.org>
373
374         Move URL from WebCore to WTF
375         https://bugs.webkit.org/show_bug.cgi?id=190234
376
377         Reviewed by Keith Miller.
378
379         * DOM/DOMAttr.mm:
380         * DOM/DOMBlob.mm:
381         * DOM/DOMCSSCharsetRule.mm:
382         * DOM/DOMCSSImportRule.mm:
383         * DOM/DOMCSSMediaRule.mm:
384         * DOM/DOMCSSPageRule.mm:
385         * DOM/DOMCSSPrimitiveValue.mm:
386         * DOM/DOMCSSRule.mm:
387         * DOM/DOMCSSStyleDeclaration.mm:
388         * DOM/DOMCSSStyleRule.mm:
389         * DOM/DOMCSSStyleSheet.mm:
390         * DOM/DOMCSSValue.mm:
391         * DOM/DOMCharacterData.mm:
392         * DOM/DOMCounter.mm:
393         * DOM/DOMDocument.mm:
394         * DOM/DOMDocumentFragment.mm:
395         * DOM/DOMDocumentType.mm:
396         * DOM/DOMEvent.mm:
397         * DOM/DOMFile.mm:
398         * DOM/DOMHTMLAnchorElement.mm:
399         * DOM/DOMHTMLAppletElement.mm:
400         * DOM/DOMHTMLAreaElement.mm:
401         * DOM/DOMHTMLBRElement.mm:
402         * DOM/DOMHTMLBaseElement.mm:
403         * DOM/DOMHTMLBaseFontElement.mm:
404         * DOM/DOMHTMLBodyElement.mm:
405         * DOM/DOMHTMLButtonElement.mm:
406         * DOM/DOMHTMLCanvasElement.mm:
407         * DOM/DOMHTMLCollection.mm:
408         * DOM/DOMHTMLDivElement.mm:
409         * DOM/DOMHTMLDocument.mm:
410         * DOM/DOMHTMLElement.mm:
411         * DOM/DOMHTMLEmbedElement.mm:
412         * DOM/DOMHTMLFieldSetElement.mm:
413         * DOM/DOMHTMLFontElement.mm:
414         * DOM/DOMHTMLFormElement.mm:
415         * DOM/DOMHTMLFrameElement.mm:
416         * DOM/DOMHTMLFrameSetElement.mm:
417         * DOM/DOMHTMLHRElement.mm:
418         * DOM/DOMHTMLHeadElement.mm:
419         * DOM/DOMHTMLHeadingElement.mm:
420         * DOM/DOMHTMLHtmlElement.mm:
421         * DOM/DOMHTMLIFrameElement.mm:
422         * DOM/DOMHTMLImageElement.mm:
423         * DOM/DOMHTMLInputElement.mm:
424         * DOM/DOMHTMLLIElement.mm:
425         * DOM/DOMHTMLLabelElement.mm:
426         * DOM/DOMHTMLLegendElement.mm:
427         * DOM/DOMHTMLLinkElement.mm:
428         * DOM/DOMHTMLMapElement.mm:
429         * DOM/DOMHTMLMarqueeElement.mm:
430         * DOM/DOMHTMLMediaElement.mm:
431         * DOM/DOMHTMLMetaElement.mm:
432         * DOM/DOMHTMLModElement.mm:
433         * DOM/DOMHTMLOListElement.mm:
434         * DOM/DOMHTMLObjectElement.mm:
435         * DOM/DOMHTMLOptGroupElement.mm:
436         * DOM/DOMHTMLOptionElement.mm:
437         * DOM/DOMHTMLOptionsCollection.mm:
438         * DOM/DOMHTMLParagraphElement.mm:
439         * DOM/DOMHTMLParamElement.mm:
440         * DOM/DOMHTMLQuoteElement.mm:
441         * DOM/DOMHTMLScriptElement.mm:
442         * DOM/DOMHTMLSelectElement.mm:
443         * DOM/DOMHTMLStyleElement.mm:
444         * DOM/DOMHTMLTableCaptionElement.mm:
445         * DOM/DOMHTMLTableCellElement.mm:
446         * DOM/DOMHTMLTableColElement.mm:
447         * DOM/DOMHTMLTableElement.mm:
448         * DOM/DOMHTMLTableRowElement.mm:
449         * DOM/DOMHTMLTableSectionElement.mm:
450         * DOM/DOMHTMLTitleElement.mm:
451         * DOM/DOMHTMLUListElement.mm:
452         * DOM/DOMHTMLVideoElement.mm:
453         * DOM/DOMKeyboardEvent.mm:
454         * DOM/DOMMediaList.mm:
455         * DOM/DOMMouseEvent.mm:
456         * DOM/DOMMutationEvent.mm:
457         * DOM/DOMNamedNodeMap.mm:
458         * DOM/DOMProcessingInstruction.mm:
459         * DOM/DOMRange.mm:
460         * DOM/DOMStyleSheet.mm:
461         * DOM/DOMText.mm:
462         * DOM/DOMTextEvent.mm:
463         * DOM/DOMTokenList.mm:
464         * DOM/DOMUIEvent.mm:
465         * DOM/DOMXPathResult.mm:
466         * History/WebHistoryItem.mm:
467         * Misc/WebNSURLExtras.mm:
468         (-[NSURL _web_userVisibleString]):
469         (-[NSURL _web_URLByRemovingUserInfo]):
470         (-[NSURL _web_dataForURLComponentType:]):
471         (-[NSURL _web_schemeData]):
472         (-[NSURL _web_hostData]):
473         * Misc/WebUserContentURLPattern.mm:
474         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
475         * Plugins/WebNetscapePluginStream.h:
476         (WebNetscapePluginStream::setRequestURL):
477         * WebCoreSupport/WebChromeClient.h:
478         * WebCoreSupport/WebChromeClient.mm:
479         (WebChromeClient::signedPublicKeyAndChallengeString const):
480         * WebCoreSupport/WebContextMenuClient.h:
481         * WebCoreSupport/WebContextMenuClient.mm:
482         * WebCoreSupport/WebDragClient.h:
483         * WebCoreSupport/WebFrameLoaderClient.h:
484         * WebCoreSupport/WebFrameLoaderClient.mm:
485         (WebFrameLoaderClient::updateGlobalHistory):
486         * WebCoreSupport/WebPaymentCoordinatorClient.h:
487         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
488         (WebPaymentCoordinatorClient::showPaymentUI):
489         * WebCoreSupport/WebPlatformStrategies.h:
490         * WebCoreSupport/WebPlatformStrategies.mm:
491         (WebPlatformStrategies::readURLFromPasteboard):
492         * WebCoreSupport/WebPluginInfoProvider.h:
493         * WebCoreSupport/WebPluginInfoProvider.mm:
494         (WebPluginInfoProvider::webVisiblePluginInfo):
495         * WebCoreSupport/WebSecurityOrigin.mm:
496         * WebCoreSupport/WebVisitedLinkStore.h:
497         * WebView/WebDataSource.mm:
498         * WebView/WebFrame.mm:
499         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
500         * WebView/WebImmediateActionController.mm:
501         (-[WebImmediateActionController _defaultAnimationController]):
502         * WebView/WebPDFView.mm:
503         * WebView/WebScriptDebugger.mm:
504         * WebView/WebViewInternal.h:
505
506 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
507
508         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
509         https://bugs.webkit.org/show_bug.cgi?id=192197
510
511         Reviewed by Jiewen Tan.
512
513         * Configurations/FeatureDefines.xcconfig:
514         * WebCoreSupport/WebChromeClient.h:
515         * WebCoreSupport/WebChromeClient.mm:
516
517 2018-11-28  Alex Christensen  <achristensen@webkit.org>
518
519         Remove dead code from an earlier attempt at implementing safe browsing
520         https://bugs.webkit.org/show_bug.cgi?id=192067
521
522         Reviewed by Chris Dumez.
523
524         * WebCoreSupport/WebFrameLoaderClient.h:
525         * WebCoreSupport/WebFrameLoaderClient.mm:
526         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
527
528 2018-11-27  Mark Lam  <mark.lam@apple.com>
529
530         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
531         https://bugs.webkit.org/show_bug.cgi?id=192055
532         <rdar://problem/46288783>
533
534         Reviewed by Saam Barati.
535
536         * Configurations/FeatureDefines.xcconfig:
537
538 2018-11-25  Tim Horton  <timothy_horton@apple.com>
539
540         Make it possible to insert editable images with a gesture
541         https://bugs.webkit.org/show_bug.cgi?id=191937
542
543         Reviewed by Wenson Hsieh.
544
545         * WebCoreSupport/WebEditorClient.mm:
546         (undoNameForEditAction):
547         Add a undo name.
548
549 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
550
551         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
552         https://bugs.webkit.org/show_bug.cgi?id=191945
553
554         Reviewed by Anders Carlsson.
555
556         * WebCoreSupport/WebEditorClient.mm:
557         (undoNameForEditAction):
558
559 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
560
561         Enable drag and drop support for iOSMac
562         https://bugs.webkit.org/show_bug.cgi?id=191818
563         <rdar://problem/43907454>
564
565         Reviewed by Dean Jackson.
566
567         * Configurations/FeatureDefines.xcconfig:
568
569 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         Address post-review feedback after r238438
572         https://bugs.webkit.org/show_bug.cgi?id=191913
573
574         Reviewed by Ryosuke Niwa.
575
576         * WebView/WebFrame.mm:
577         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
578         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
579         * WebView/WebView.mm:
580         (-[WebView setSelectedDOMRange:affinity:]):
581
582 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
583
584         Web Inspector: "Reload Web Inspector" button no longer partially works
585         https://bugs.webkit.org/show_bug.cgi?id=191773
586         <rdar://problem/46139932>
587
588         Reviewed by Devin Rousso.
589
590         * WebCoreSupport/WebInspectorClient.h:
591         * WebCoreSupport/WebInspectorClient.mm:
592         (WebInspectorFrontendClient::reopen):
593
594 2018-11-17  Devin Rousso  <drousso@apple.com>
595
596         Web Inspector: Network: add button to show system certificate dialog
597         https://bugs.webkit.org/show_bug.cgi?id=191458
598         <rdar://problem/45977019>
599
600         Reviewed by Joseph Pecoraro.
601
602         * WebCoreSupport/WebInspectorClient.h:
603         * WebCoreSupport/WebInspectorClient.mm:
604         (WebInspectorFrontendClient::showCertificate): Added.
605
606         * Configurations/WebKitLegacy.xcconfig:
607
608 2018-11-15  Truitt Savell  <tsavell@apple.com>
609
610         Unreviewed, rolling out r238244.
611
612         Caused High Sierra test runs to fail early with 50 crashes and
613         casued 25 API failures.
614
615         Reverted changeset:
616
617         "[css-logical] Implement flow-relative margin, padding and
618         border shorthands"
619         https://bugs.webkit.org/show_bug.cgi?id=188697
620         https://trac.webkit.org/changeset/238244
621
622 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
623
624         [css-logical] Implement flow-relative margin, padding and border shorthands
625         https://bugs.webkit.org/show_bug.cgi?id=188697
626
627         Reviewed by Simon Fraser and Antti Koivisto.
628
629         Add CSSLogicalEnabled runtime flag.
630
631         * WebView/WebPreferenceKeysPrivate.h:
632         * WebView/WebPreferences.mm:
633         (+[WebPreferences initialize]):
634         (-[WebPreferences cssLogicalEnabled]):
635         (-[WebPreferences setCSSLogicalEnabled:]):
636         * WebView/WebPreferencesPrivate.h:
637         * WebView/WebView.mm:
638         (-[WebView _preferencesChanged:]):
639
640 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
641
642         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
643         https://bugs.webkit.org/show_bug.cgi?id=191612
644
645         Reviewed by Matt Baker.
646
647         * WebCoreSupport/WebInspectorClient.mm:
648         (-[WebInspectorWindowController destroyInspectorView]):
649
650 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
651
652         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
653         https://bugs.webkit.org/show_bug.cgi?id=191494
654         <rdar://problem/45469854>
655
656         Reviewed by Devin Rousso.
657
658         * WebCoreSupport/WebInspectorClient.h:
659         WebKitLegacy will still have remote inspection of the Page directly.
660
661 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
662
663         Make compositing updates incremental
664         https://bugs.webkit.org/show_bug.cgi?id=90342
665
666         Reviewed by Antti Koivisto.
667
668         Fix spelling error.
669
670         * WebView/WebView.mm:
671         (-[WebView _setMediaLayer:forPluginView:]):
672
673 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
674
675         Implement a new edit command to change the enclosing list type
676         https://bugs.webkit.org/show_bug.cgi?id=191487
677         <rdar://problem/45955922>
678
679         Reviewed by Ryosuke Niwa.
680
681         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
682
683         * WebCoreSupport/WebEditorClient.mm:
684         (undoNameForEditAction):
685
686 2018-11-11  Daniel Bates  <dabates@apple.com>
687
688         [iOS] Draw caps lock indicator in password fields
689         https://bugs.webkit.org/show_bug.cgi?id=190565
690         <rdar://problem/45262343>
691
692         Reviewed by Dean Jackson.
693
694         Update the caps lock state when a hardware keyboard is attached or detached.
695
696         * WebView/WebHTMLView.mm:
697         (hardwareKeyboardAvailabilityChangedCallback): Added.
698         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
699         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
700
701 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
702
703         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
704         https://bugs.webkit.org/show_bug.cgi?id=191492
705
706         Reviewed by Alex Christensen.
707
708         * Carbon/HIWebView.mm:
709         * Misc/WebNSFileManagerExtras.mm:
710         * Misc/WebNSURLExtras.mm:
711         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
712         * Plugins/WebBasePluginPackage.mm:
713         * Plugins/WebPluginContainerCheck.mm:
714         * WebCoreSupport/WebCachedFramePlatformData.h:
715         * WebCoreSupport/WebDeviceOrientationClient.mm:
716         * WebView/WebDelegateImplementationCaching.mm:
717         * WebView/WebHTMLView.mm:
718         * WebView/WebPDFRepresentation.mm:
719         * WebView/WebPolicyDelegate.mm:
720         * WebView/WebView.mm:
721
722 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
723
724         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
725         https://bugs.webkit.org/show_bug.cgi?id=191492
726
727         Reviewed by Alex Christensen.
728
729         * Carbon/HIWebView.mm:
730         (UpdateCommandStatus):
731         * Misc/WebNSFileManagerExtras.mm:
732         * Misc/WebNSURLExtras.mm:
733         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
734         * Plugins/WebBasePluginPackage.mm:
735         * Plugins/WebPluginContainerCheck.mm:
736         (-[WebPluginContainerCheck _continueWithPolicy:]):
737         * WebCoreSupport/WebCachedFramePlatformData.h:
738         (WebCachedFramePlatformData::clear):
739         * WebCoreSupport/WebDeviceOrientationClient.mm:
740         (WebDeviceOrientationClient::getProvider const):
741         * WebView/WebDelegateImplementationCaching.mm:
742         (CallDelegate):
743         (CallDelegateReturningBoolean):
744         (CallResourceLoadDelegateReturningBoolean):
745         (CallFormDelegate):
746         (CallFormDelegateReturningBoolean):
747         * WebView/WebHTMLView.mm:
748         * WebView/WebPDFRepresentation.mm:
749         * WebView/WebPolicyDelegate.mm:
750         (-[WebPolicyDecisionListener _usePolicy:]):
751         * WebView/WebView.mm:
752
753 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
754
755         Unreviewed, rolling out r238047.
756
757         Introduced layout test failures on iOS simulator.
758
759         Reverted changeset:
760
761         "[iOS] Draw caps lock indicator in password fields"
762         https://bugs.webkit.org/show_bug.cgi?id=190565
763         https://trac.webkit.org/changeset/238047
764
765 2018-11-09  Antti Koivisto  <antti@apple.com>
766
767         Use OptionSet for layout milestones
768         https://bugs.webkit.org/show_bug.cgi?id=191470
769
770         Reviewed by Dean Jackson.
771
772         * WebCoreSupport/WebFrameLoaderClient.h:
773         * WebCoreSupport/WebFrameLoaderClient.mm:
774         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
775         * WebView/WebView.mm:
776         (coreLayoutMilestones):
777         (kitLayoutMilestones):
778         (-[WebView _cacheFrameLoadDelegateImplementations]):
779         * WebView/WebViewInternal.h:
780
781 2018-11-09  Daniel Bates  <dabates@apple.com>
782
783         [iOS] Draw caps lock indicator in password fields
784         https://bugs.webkit.org/show_bug.cgi?id=190565
785         <rdar://problem/45262343>
786
787         Reviewed by Dean Jackson.
788
789         Update the caps lock state when a hardware keyboard is attached or detached.
790
791         * WebView/WebHTMLView.mm:
792         (hardwareKeyboardAvailabilityChangedCallback): Added.
793         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
794         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
795
796 2018-11-09  Daniel Bates  <dabates@apple.com>
797
798         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
799         action when forward delete is pressed outside a text field
800         https://bugs.webkit.org/show_bug.cgi?id=190566
801         <rdar://problem/45262367>
802
803         Reviewed by Wenson Hsieh.
804
805         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
806         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
807         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
808
809         * WebView/WebHTMLView.mm:
810         (-[WebHTMLView _handleEditingKeyEvent:]):
811
812 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
813
814         Adopt Reveal Framework to replace Lookup
815         https://bugs.webkit.org/show_bug.cgi?id=191097
816         <rdar://problem/45924508>
817
818         Reviewed by Tim Horton.
819
820         Pass in what it needed to clear the textIndicators. This is better than
821         the current notification structure.
822
823         * WebView/WebView.mm:
824         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
825         (-[WebView _prepareForDictionaryLookup]):
826
827 2018-11-06  Justin Fan  <justin_fan@apple.com>
828
829         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
830         https://bugs.webkit.org/show_bug.cgi?id=191291
831
832         Reviewed by Myles Maxfield.
833
834         Properly disable WEBGPU on all non-Metal platforms for now.
835
836         * Configurations/FeatureDefines.xcconfig:
837
838 2018-11-02  Daniel Bates  <dabates@apple.com>
839
840         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
841         https://bugs.webkit.org/show_bug.cgi?id=190487
842
843         Reviewed by Tim Horton.
844
845         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
846         allow the default handling.
847
848         * WebView/WebHTMLView.mm:
849         (-[WebHTMLView _handleEditingKeyEvent:]):
850
851 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
852
853         Add a storage limit for IndexedDB
854         https://bugs.webkit.org/show_bug.cgi?id=190598
855         <rdar://problem/44654715>
856
857         Reviewed by Chris Dumez.
858
859         * Storage/WebDatabaseManager.mm:
860         (-[WebDatabaseManager setIDBPerOriginQuota:]):
861         * Storage/WebDatabaseManagerPrivate.h:
862
863 2018-10-31  Antti Koivisto  <antti@apple.com>
864
865         Remove LayerFlushScheduler
866         https://bugs.webkit.org/show_bug.cgi?id=191103
867
868         Reviewed by Anders Carlsson.
869
870         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
871         all the virtual cruft.
872
873         * WebView/WebViewData.h:
874         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
875         (): Deleted.
876         * WebView/WebViewData.mm:
877         (currentRunLoop):
878         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
879         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
880         (WebViewLayerFlushScheduler::schedule):
881         (WebViewLayerFlushScheduler::invalidate):
882         (WebViewLayerFlushScheduler::layerFlushCallback):
883
884 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
885
886         Enable InstallAPI for iOS unconditionally
887         https://bugs.webkit.org/show_bug.cgi?id=191043
888         rdar://problem/32728423
889
890         Reviewed by Dan Bernstein.
891
892         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
893         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
894         shouldn't be processed by InstallAPI.
895         * MigrateHeaders.make: Removed an obsolete workaround.
896         * Misc/NSURLDownloadSPI.h: Added.
897         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
898
899 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
900
901         Clean up some obsolete MAX_ALLOWED macros
902         https://bugs.webkit.org/show_bug.cgi?id=190916
903
904         Reviewed by Tim Horton.
905
906         * WebView/WebHTMLView.mm:
907         (-[WebHTMLView pressureChangeWithEvent:]):
908         * WebView/WebPDFView.h:
909
910 2018-10-30  Commit Queue  <commit-queue@webkit.org>
911
912         Unreviewed, rolling out r237600 and r237604.
913         https://bugs.webkit.org/show_bug.cgi?id=191086
914
915         Breaks internal iOS builds (Requested by ryanhadd_ on
916         #webkit).
917
918         Reverted changesets:
919
920         "Enable InstallAPI for iOS unconditionally"
921         https://bugs.webkit.org/show_bug.cgi?id=191043
922         https://trac.webkit.org/changeset/237600
923
924         "Build fix attempt after enabling InstallAPI for iOS."
925         https://bugs.webkit.org/show_bug.cgi?id=191043
926         https://trac.webkit.org/changeset/237604
927
928 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
929
930         Enable InstallAPI for iOS unconditionally
931         https://bugs.webkit.org/show_bug.cgi?id=191043
932         rdar://problem/32728423
933
934         Reviewed by Dan Bernstein.
935
936         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
937         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
938         shouldn't be processed by InstallAPI.
939         * MigrateHeaders.make: Removed an obsolete workaround.
940         * Misc/NSURLDownloadSPI.h: Added.
941         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
942
943 2018-10-29  Tim Horton  <timothy_horton@apple.com>
944
945         Modernize WebKit nibs and lprojs for localization's sake
946         https://bugs.webkit.org/show_bug.cgi?id=190911
947         <rdar://problem/45349466>
948
949         Reviewed by Dan Bernstein.
950
951         * Misc/WebNSControlExtras.m:
952         (-[NSControl sizeToFitAndAdjustWindowHeight]):
953         NSWindow and its contents are both in the same scale space these days; avoid
954         double-applying the scale factor, or you can't see the prompt.
955
956         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
957         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
958         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
959         NIB->XIB
960
961 2018-10-25  Antoine Quint  <graouts@apple.com>
962
963         [Web Animations] Turn Web Animations CSS Integration off by default
964         https://bugs.webkit.org/show_bug.cgi?id=190901
965
966         Reviewed by Dean Jackson.
967
968         * WebView/WebPreferences.mm:
969         (+[WebPreferences initialize]):
970
971 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
972
973         Clean up some obsolete macOS version guards
974         https://bugs.webkit.org/show_bug.cgi?id=190887
975
976         Reviewed by Dan Bernstein.
977
978         * Misc/WebNSPasteboardExtras.mm:
979         (+[NSPasteboard _web_dragTypesForURL]):
980         * WebCoreSupport/PopupMenuMac.mm:
981         (PopupMenuMac::show):
982         * WebCoreSupport/WebEditorClient.h:
983         * WebCoreSupport/WebEditorClient.mm:
984         (WebEditorClient::respondToChangedSelection):
985         * WebView/WebPDFView.mm:
986         (-[WebPDFView _clipViewForPDFDocumentView]):
987
988 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
989
990         Turn on Conic Gradients
991         https://bugs.webkit.org/show_bug.cgi?id=190810
992
993         Reviewed by Tim Horton.
994
995         * Configurations/FeatureDefines.xcconfig:
996
997 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
998
999         Cleanup: MIMETypeRegistry functions
1000         https://bugs.webkit.org/show_bug.cgi?id=190838
1001
1002         Reviewed by Simon Fraser.
1003
1004         * Misc/WebNSPasteboardExtras.mm:
1005         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1006         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1007         because they were identical.
1008
1009         * WebView/WebHTMLRepresentation.mm:
1010         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1011         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1012         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1013         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1014         * WebView/WebView.mm:
1015         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1016         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1017         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1018
1019 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1020
1021         Fix false positive leaks when using custom -init methods that don't start with -init
1022         <https://webkit.org/b/190818>
1023         <rdar://problem/45476042>
1024
1025         Reviewed by Dan Bernstein.
1026
1027         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1028         it is accessible by both categories.
1029         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1030         NSError (WebKitInternal) category.  Add attribute to make this
1031         behave like an -init method.
1032         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1033         NSError (WebKitInternal) category.  Modernize method.  Replace
1034         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1035
1036 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1037
1038         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1039         https://bugs.webkit.org/show_bug.cgi?id=190729
1040
1041         Reviewed by Tim Horton.
1042
1043         * DOM/DOM.mm:
1044         (-[DOMNode boundingBox]):
1045         * DOM/DOMElement.mm:
1046         * DOM/DOMHTML.mm:
1047         * DOM/DOMInternal.mm:
1048         * DOM/DOMUIKitExtensions.mm:
1049         * DOM/WebDOMOperations.mm:
1050         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1051         * DefaultDelegates/WebDefaultEditingDelegate.m:
1052         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1053         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1054         * DefaultDelegates/WebDefaultUIDelegate.h:
1055         * DefaultDelegates/WebDefaultUIDelegate.mm:
1056         (-[WebDefaultUIDelegate webViewClose:]):
1057         (-[WebDefaultUIDelegate webViewFocus:]):
1058         (-[WebDefaultUIDelegate webViewUnfocus:]):
1059         (-[WebDefaultUIDelegate webViewIsResizable:]):
1060         (-[WebDefaultUIDelegate webView:setResizable:]):
1061         (-[WebDefaultUIDelegate webView:setFrame:]):
1062         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1063         * History/BackForwardList.h:
1064         * History/BackForwardList.mm:
1065         * History/WebBackForwardList.mm:
1066         (+[WebBackForwardList initialize]):
1067         (bumperCarBackForwardHackNeeded):
1068         * History/WebHistory.mm:
1069         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1070         (-[WebHistory _sendNotification:entries:]):
1071         (-[WebHistory loadFromURL:error:]):
1072         (-[WebHistory saveToURL:error:]):
1073         * History/WebHistoryItem.mm:
1074         (WKNotifyHistoryItemChanged):
1075         (+[WebHistoryItem initialize]):
1076         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1077         * History/WebURLsWithTitles.m:
1078         * Misc/WebCache.mm:
1079         (+[WebCache initialize]):
1080         * Misc/WebDownload.mm:
1081         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1082         * Misc/WebElementDictionary.mm:
1083         (+[WebElementDictionary initialize]):
1084         (+[WebElementDictionary initializeLookupTable]):
1085         * Misc/WebIconDatabase.mm:
1086         * Misc/WebKitNSStringExtras.mm:
1087         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1088         * Misc/WebKitVersionChecks.h:
1089         * Misc/WebKitVersionChecks.mm:
1090         (WebKitLinkedOnOrAfter):
1091         (WebKitLinkTimeVersion):
1092         * Misc/WebLocalizableStrings.mm:
1093         * Misc/WebNSControlExtras.h:
1094         * Misc/WebNSControlExtras.m:
1095         * Misc/WebNSEventExtras.m:
1096         * Misc/WebNSFileManagerExtras.mm:
1097         * Misc/WebNSImageExtras.h:
1098         * Misc/WebNSImageExtras.m:
1099         * Misc/WebNSPasteboardExtras.mm:
1100         * Misc/WebNSPrintOperationExtras.h:
1101         * Misc/WebNSPrintOperationExtras.m:
1102         * Misc/WebNSViewExtras.m:
1103         * Misc/WebNSWindowExtras.m:
1104         * Panels/WebAuthenticationPanel.h:
1105         * Panels/WebAuthenticationPanel.m:
1106         * Panels/WebPanelAuthenticationHandler.m:
1107         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1108         (+[WebHostedNetscapePluginView initialize]):
1109         * Plugins/WebBasePluginPackage.h:
1110         * Plugins/WebBasePluginPackage.mm:
1111         * Plugins/WebJavaPlugIn.h:
1112         * Plugins/WebPluginContainerCheck.mm:
1113         * Plugins/WebPluginController.h:
1114         * Plugins/WebPluginController.mm:
1115         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1116         (-[WebPluginController addPlugin:]):
1117         (-[WebPluginController destroyPlugin:]):
1118         (-[WebPluginController destroyAllPlugins]):
1119         * Plugins/WebPluginDatabase.mm:
1120         (+[WebPluginDatabase _defaultPlugInPaths]):
1121         * Plugins/WebPluginPackage.mm:
1122         (-[WebPluginPackage initWithPath:]):
1123         * Storage/WebDatabaseManager.mm:
1124         (-[WebDatabaseManager deleteAllDatabases]):
1125         * Storage/WebDatabaseManagerClient.h:
1126         * Storage/WebDatabaseManagerClient.mm:
1127         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1128         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1129         * Storage/WebStorageManager.mm:
1130         (-[WebStorageManager deleteAllOrigins]):
1131         (WebKitInitializeStorageIfNecessary):
1132         * WebCoreSupport/WebAlternativeTextClient.h:
1133         * WebCoreSupport/WebApplicationCache.mm:
1134         (applicationCacheBundleIdentifier):
1135         * WebCoreSupport/WebChromeClient.h:
1136         * WebCoreSupport/WebChromeClient.mm:
1137         (WebChromeClient::setWindowRect):
1138         (WebChromeClient::windowRect):
1139         (WebChromeClient::takeFocus):
1140         (WebChromeClient::addMessageToConsole):
1141         (WebChromeClient::enableSuddenTermination):
1142         (WebChromeClient::disableSuddenTermination):
1143         (WebChromeClient::createPopupMenu const):
1144         (WebChromeClient::createSearchPopupMenu const):
1145         (WebChromeClient::shouldPaintEntireContents const):
1146         (WebChromeClient::supportsVideoFullscreen):
1147         (WebChromeClient::supportsFullScreenForElement):
1148         (WebChromeClient::enterFullScreenForElement):
1149         (WebChromeClient::exitFullScreenForElement):
1150         * WebCoreSupport/WebContextMenuClient.mm:
1151         * WebCoreSupport/WebDragClient.mm:
1152         * WebCoreSupport/WebEditorClient.h:
1153         * WebCoreSupport/WebEditorClient.mm:
1154         (+[WebUndoStep initialize]):
1155         (updateFontPanel):
1156         (WebEditorClient::didBeginEditing):
1157         (WebEditorClient::respondToChangedContents):
1158         (WebEditorClient::respondToChangedSelection):
1159         (WebEditorClient::canceledComposition):
1160         (WebEditorClient::didEndEditing):
1161         (WebEditorClient::didWriteSelectionToPasteboard):
1162         (attributesForAttributedStringConversion):
1163         (WebEditorClient::setInsertionPasteboard):
1164         (WebEditorClient::registerUndoOrRedoStep):
1165         (WebEditorClient::handleKeyboardEvent):
1166         (WebEditorClient::handleInputMethodKeydown):
1167         (WebEditorClient::textDidChangeInTextField):
1168         (WebEditorClient::requestCheckingOfString):
1169         * WebCoreSupport/WebFrameLoaderClient.h:
1170         * WebCoreSupport/WebFrameLoaderClient.mm:
1171         (WebFrameLoaderClient::detachedFromParent2):
1172         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1173         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1174         (WebFrameLoaderClient::dispatchWillSendRequest):
1175         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1176         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1177         (WebFrameLoaderClient::willCacheResponse const):
1178         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1179         (WebFrameLoaderClient::dispatchDidFinishLoading):
1180         (WebFrameLoaderClient::dispatchDidFailLoading):
1181         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1182         (WebFrameLoaderClient::dispatchWillClose):
1183         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1184         (WebFrameLoaderClient::dispatchDidCommitLoad):
1185         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1186         (WebFrameLoaderClient::dispatchDidFailLoad):
1187         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1188         (WebFrameLoaderClient::dispatchDidFinishLoad):
1189         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1190         (WebFrameLoaderClient::willChangeTitle):
1191         (WebFrameLoaderClient::didChangeTitle):
1192         (WebFrameLoaderClient::didReplaceMultipartContent):
1193         (WebFrameLoaderClient::updateGlobalHistory):
1194         (WebFrameLoaderClient::saveViewStateToItem):
1195         (WebFrameLoaderClient::restoreViewState):
1196         (WebFrameLoaderClient::provisionalLoadStarted):
1197         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1198         (WebFrameLoaderClient::setTitle):
1199         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1200         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1201         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1202         (WebFrameLoaderClient::didRestoreFromPageCache):
1203         (WebFrameLoaderClient::actionDictionary const):
1204         (WebFrameLoaderClient::createPlugin):
1205         (WebFrameLoaderClient::getLoadDecisionForIcons):
1206         (WebFrameLoaderClient::finishedLoadingIcon):
1207         (+[WebFramePolicyListener initialize]):
1208         * WebCoreSupport/WebFrameNetworkingContext.mm:
1209         * WebCoreSupport/WebGeolocationClient.h:
1210         * WebCoreSupport/WebGeolocationClient.mm:
1211         (WebGeolocationClient::requestPermission):
1212         * WebCoreSupport/WebInspectorClient.h:
1213         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1214         * WebCoreSupport/WebNotificationClient.mm:
1215         * WebCoreSupport/WebOpenPanelResultListener.mm:
1216         * WebCoreSupport/WebPlatformStrategies.h:
1217         * WebCoreSupport/WebPlatformStrategies.mm:
1218         * WebCoreSupport/WebProgressTrackerClient.h:
1219         * WebCoreSupport/WebProgressTrackerClient.mm:
1220         (WebProgressTrackerClient::progressStarted):
1221         (WebProgressTrackerClient::progressEstimateChanged):
1222         (WebProgressTrackerClient::progressFinished):
1223         * WebCoreSupport/WebSecurityOrigin.mm:
1224         * WebInspector/WebNodeHighlight.h:
1225         * WebInspector/WebNodeHighlight.mm:
1226         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1227         (-[WebNodeHighlight dealloc]):
1228         (-[WebNodeHighlight attach]):
1229         * WebInspector/WebNodeHighlightView.h:
1230         * WebInspector/WebNodeHighlightView.mm:
1231         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1232         (-[WebNodeHighlightView dealloc]):
1233         * WebInspector/WebNodeHighlighter.mm:
1234         (-[WebNodeHighlighter highlight]):
1235         * WebView/WebArchive.mm:
1236         (+[WebArchivePrivate initialize]):
1237         * WebView/WebClipView.h:
1238         * WebView/WebDataSource.mm:
1239         (WebDataSourcePrivate::WebDataSourcePrivate):
1240         (+[WebDataSource initialize]):
1241         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1242         (-[WebDataSource _makeRepresentation]):
1243         * WebView/WebDelegateImplementationCaching.h:
1244         * WebView/WebDelegateImplementationCaching.mm:
1245         (CallDelegate):
1246         (CallDelegateReturningFloat):
1247         (CallDelegateReturningBoolean):
1248         (CallUIDelegate):
1249         (CallUIDelegateReturningFloat):
1250         (CallUIDelegateReturningBoolean):
1251         (CallFrameLoadDelegate):
1252         (CallFrameLoadDelegateReturningBoolean):
1253         (CallResourceLoadDelegate):
1254         (CallScriptDebugDelegate):
1255         (CallFormDelegate):
1256         (CallFormDelegateReturningBoolean):
1257         * WebView/WebDeviceOrientation.mm:
1258         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1259         * WebView/WebDocumentInternal.h:
1260         * WebView/WebDocumentLoaderMac.mm:
1261         (needsDataLoadWorkaround):
1262         * WebView/WebDynamicScrollBarsViewInternal.h:
1263         * WebView/WebFormDelegate.m:
1264         * WebView/WebFrame.mm:
1265         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1266         (-[WebFrame _unmarkAllMisspellings]):
1267         (-[WebFrame _paintBehaviorForDestinationContext:]):
1268         (-[WebFrame _drawRect:contentsOnly:]):
1269         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1270         (-[WebFrame _scrollDOMRangeToVisible:]):
1271         (-[WebFrame _bodyBackgroundColor]):
1272         (-[WebFrame accessibilityRoot]):
1273         (needsMicrosoftMessengerDOMDocumentWorkaround):
1274         * WebView/WebFrameInternal.h:
1275         * WebView/WebFrameView.mm:
1276         (-[WebFrameView _setDocumentView:]):
1277         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1278         (-[WebFrameView _viewClassForMIMEType:]):
1279         (-[WebFrameView initWithFrame:]):
1280         (-[WebFrameView drawRect:]):
1281         (-[WebFrameView _firstResponderIsFormControl]):
1282         (-[WebFrameView keyDown:keyDown:]):
1283         (-[WebFrameView _isScrollable]):
1284         * WebView/WebFullScreenController.h:
1285         * WebView/WebFullScreenController.mm:
1286         * WebView/WebHTMLRepresentation.mm:
1287         * WebView/WebHTMLView.mm:
1288         (-[WebHTMLView hitTest:]):
1289         (-[WebHTMLView initWithFrame:]):
1290         (-[WebHTMLView dealloc]):
1291         (-[WebHTMLView addSubview:]):
1292         (-[WebHTMLView mouseDown:]):
1293         (-[WebHTMLView mouseUp:]):
1294         (-[WebHTMLView resignFirstResponder]):
1295         (-[WebHTMLView accessibilityHitTest:]):
1296         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1297         * WebView/WebHTMLViewInternal.h:
1298         * WebView/WebIndicateLayer.h:
1299         * WebView/WebIndicateLayer.mm:
1300         * WebView/WebMediaPlaybackTargetPicker.h:
1301         * WebView/WebMediaPlaybackTargetPicker.mm:
1302         * WebView/WebPDFDocumentExtras.h:
1303         * WebView/WebPDFDocumentExtras.mm:
1304         * WebView/WebPDFRepresentation.h:
1305         * WebView/WebPDFRepresentation.mm:
1306         * WebView/WebPDFView.h:
1307         * WebView/WebPreferences.mm:
1308         (cacheModelForMainBundle):
1309         (WebPreferencesPrivate::WebPreferencesPrivate):
1310         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1311         (-[WebPreferences encodeWithCoder:]):
1312         (+[WebPreferences standardPreferences]):
1313         (+[WebPreferences initialize]):
1314         (-[WebPreferences _valueForKey:]):
1315         (-[WebPreferences _setStringValue:forKey:]):
1316         (-[WebPreferences _setIntegerValue:forKey:]):
1317         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1318         (-[WebPreferences _setFloatValue:forKey:]):
1319         (-[WebPreferences _setBoolValue:forKey:]):
1320         (-[WebPreferences _setLongLongValue:forKey:]):
1321         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1322         (-[WebPreferences _postCacheModelChangedNotification]):
1323         (-[WebPreferences _postPreferencesChangedNotification]):
1324         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1325         (-[WebPreferences setStorageBlockingPolicy:]):
1326         * WebView/WebResource.mm:
1327         (+[WebResourcePrivate initialize]):
1328         * WebView/WebTextCompletionController.h:
1329         * WebView/WebTextIterator.mm:
1330         (+[WebTextIteratorPrivate initialize]):
1331         * WebView/WebView.mm:
1332         (shouldEnableLoadDeferring):
1333         (shouldRestrictWindowFocus):
1334         (shouldRespectPriorityInCSSAttributeSetters):
1335         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1336         (shouldAllowPictureInPictureMediaPlayback):
1337         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1338         (shouldAllowWindowOpenWithoutUserGesture):
1339         (shouldConvertInvalidURLsToBlank):
1340         (shouldRequireUserGestureToLoadVideo):
1341         (-[WebView _commonInitializationWithFrameName:groupName:]):
1342         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1343         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1344         (-[WebView _closePluginDatabases]):
1345         (-[WebView _closeWithFastTeardown]):
1346         (-[WebView _close]):
1347         (+[WebView _MIMETypeForFile:]):
1348         (-[WebView setShowingInspectorIndication:]):
1349         (-[WebView _setFormDelegate:]):
1350         (-[WebView _needsPreHTML5ParserQuirks]):
1351         (-[WebView _preferencesChangedNotification:]):
1352         (-[WebView _preferencesChanged:]):
1353         (-[WebView _cacheResourceLoadDelegateImplementations]):
1354         (-[WebView _cacheFrameLoadDelegateImplementations]):
1355         (-[WebView _policyDelegateForwarder]):
1356         (-[WebView _UIDelegateForwarder]):
1357         (-[WebView _editingDelegateForwarder]):
1358         (-[WebView _updateActiveState]):
1359         (-[_WebSafeForwarder forwardInvocation:]):
1360         (+[WebView initialize]):
1361         (-[WebView _pluginForMIMEType:]):
1362         (-[WebView _pluginForExtension:]):
1363         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1364         (+[WebView canShowMIMETypeAsHTML:]):
1365         (-[WebView _initWithArguments:]):
1366         (-[WebView initWithFrame:frameName:groupName:]):
1367         (-[WebView dealloc]):
1368         (-[WebView close]):
1369         (-[WebView viewDidMoveToWindow]):
1370         (-[WebView setUIDelegate:]):
1371         (-[WebView setResourceLoadDelegate:]):
1372         (-[WebView setPolicyDelegate:]):
1373         (-[WebView setFrameLoadDelegate:]):
1374         (-[WebView goBack]):
1375         (-[WebView goForward]):
1376         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1377         (-[WebView setHostWindow:]):
1378         (-[WebView becomeFirstResponder]):
1379         (+[WebView _cacheModelChangedNotification:]):
1380         (-[WebView _frameViewAtWindowPoint:]):
1381         (+[WebView _preflightSpellCheckerNow:]):
1382         (+[WebView _preflightSpellChecker]):
1383         (-[WebView canGoBack]):
1384         (-[WebView canGoForward]):
1385         (-[WebView stopLoading:]):
1386         (-[WebView reload:]):
1387         (-[WebView setMainFrameDocumentReady:]):
1388         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1389         (-[WebView setContinuousSpellCheckingEnabled:]):
1390         (-[WebView undoManager]):
1391         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1392         (-[WebView isAutomaticLinkDetectionEnabled]):
1393         (-[WebView isAutomaticDashSubstitutionEnabled]):
1394         (-[WebView isAutomaticTextReplacementEnabled]):
1395         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1396         (+[WebView _setCacheModel:]):
1397         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1398         (-[WebView _keyboardUIMode]):
1399         (LayerFlushController::flushLayers):
1400         (-[WebView _scheduleCompositingLayerFlush]):
1401         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1402         (-[WebView fullScreenPlaceholderView]):
1403         (WebInstallMemoryPressureHandler):
1404         * WebView/WebViewData.h:
1405         * WebView/WebViewData.mm:
1406         (+[WebViewPrivate initialize]):
1407         (-[WebViewPrivate init]):
1408         (-[WebViewPrivate dealloc]):
1409         * WebView/WebViewInternal.h:
1410
1411 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1412
1413         Clean up FrameLoader two-state enums
1414         https://bugs.webkit.org/show_bug.cgi?id=190731
1415
1416         Reviewed by Chris Dumez.
1417
1418         * WebCoreSupport/WebFrameLoaderClient.h:
1419         * WebCoreSupport/WebFrameLoaderClient.mm:
1420         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1421
1422 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1423
1424         Unreviewed, rolling out r237137.
1425
1426         SPI is actually used
1427
1428         Reverted changeset:
1429
1430         "Remove unused WebFrame._loadType"
1431         https://bugs.webkit.org/show_bug.cgi?id=190583
1432         https://trac.webkit.org/changeset/237137
1433
1434 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1435
1436         Enable the datalist element by default on iOS and macOS
1437         https://bugs.webkit.org/show_bug.cgi?id=190594
1438         <rdar://problem/45281159>
1439
1440         Reviewed by Ryosuke Niwa and Tim Horton.
1441
1442         * Configurations/FeatureDefines.xcconfig:
1443
1444 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1445
1446         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1447         https://bugs.webkit.org/show_bug.cgi?id=190675
1448
1449         Reviewed by Chris Dumez.
1450
1451         * History/BackForwardList.h:
1452         * History/BackForwardList.mm:
1453         (BackForwardList::backItem):
1454         (BackForwardList::currentItem):
1455         (BackForwardList::forwardItem):
1456         (BackForwardList::backListCount const):
1457         (BackForwardList::forwardListCount const):
1458         (BackForwardList::itemAtIndex):
1459         * History/WebBackForwardList.mm:
1460         (-[WebBackForwardList backItem]):
1461         (-[WebBackForwardList currentItem]):
1462         (-[WebBackForwardList forwardItem]):
1463         (-[WebBackForwardList itemAtIndex:]):
1464
1465 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1466
1467         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1468         https://bugs.webkit.org/show_bug.cgi?id=190526
1469         rdar://problem/45230140
1470
1471         Reviewed by Dean Jackson.
1472
1473         * WebCoreSupport/WebEditorClient.mm:
1474         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1475
1476 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1477
1478         Implement feature flag and bindings for CSS Painting API
1479         https://bugs.webkit.org/show_bug.cgi?id=190237
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         * Configurations/FeatureDefines.xcconfig:
1484
1485 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1486
1487         Replace HistoryItem* with HistoryItem& where possible
1488         https://bugs.webkit.org/show_bug.cgi?id=190617
1489
1490         Reviewed by Chris Dumez.
1491
1492         * History/BackForwardList.h:
1493         * History/BackForwardList.mm:
1494         (BackForwardList::goToItem):
1495         * History/WebBackForwardList.mm:
1496         (-[WebBackForwardList goToItem:]):
1497         * History/WebHistoryItem.mm:
1498         (WKNotifyHistoryItemChanged):
1499         * History/WebHistoryItemInternal.h:
1500
1501 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1502
1503         Remove unused WebHistoryItem._transientPropertyForKey
1504         https://bugs.webkit.org/show_bug.cgi?id=190606
1505
1506         Reviewed by Chris Dumez.
1507
1508         * History/WebHistoryItem.mm:
1509         * History/WebHistoryItemPrivate.h:
1510
1511 2018-10-15  Justin Fan  <justin_fan@apple.com>
1512
1513         Add WebGPU 2018 feature flag and experimental feature flag
1514         https://bugs.webkit.org/show_bug.cgi?id=190509
1515
1516         Reviewed by Dean Jackson.
1517
1518         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1519         for the 2018 WebGPU prototype.
1520
1521         * Configurations/FeatureDefines.xcconfig:
1522         * WebView/WebPreferenceKeysPrivate.h:
1523         * WebView/WebPreferences.mm:
1524         (+[WebPreferences initialize]):
1525         (-[WebPreferences webGPUEnabled]):
1526         (-[WebPreferences setWebGPUEnabled:]):
1527         * WebView/WebPreferencesPrivate.h:
1528         * WebView/WebView.mm:
1529         (-[WebView _preferencesChanged:]):
1530
1531 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1532
1533         Fix iOS build after r237157
1534
1535         * WebView/WebView.mm:
1536         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1537
1538 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1539
1540         Modernize BackForwardClient.h
1541         https://bugs.webkit.org/show_bug.cgi?id=190610
1542
1543         Reviewed by Chris Dumez.
1544
1545         * History/BackForwardList.h:
1546         * History/BackForwardList.mm:
1547         (BackForwardList::backListCount const):
1548         (BackForwardList::forwardListCount const):
1549         (BackForwardList::backListCount): Deleted.
1550         (BackForwardList::forwardListCount): Deleted.
1551         * History/WebBackForwardList.mm:
1552         (-[WebBackForwardList init]):
1553         * WebCoreSupport/WebFrameLoaderClient.mm:
1554         (WebFrameLoaderClient::canCachePage const):
1555         * WebView/WebFrameView.mm:
1556         (-[WebFrameView keyDown:keyDown:]):
1557         * WebView/WebView.mm:
1558         (-[WebView _commonInitializationWithFrameName:groupName:]):
1559         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1560         (-[WebView _loadBackForwardListFromOtherView:]):
1561         (-[WebView initWithCoder:]):
1562         (-[WebView encodeWithCoder:]):
1563         (-[WebView backForwardList]):
1564         (-[WebView setMaintainsBackForwardList:]):
1565
1566 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1567
1568         Add support for prefers-color-scheme media query
1569         https://bugs.webkit.org/show_bug.cgi?id=190499
1570         rdar://problem/45212025
1571
1572         Reviewed by Dean Jackson.
1573
1574         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1575
1576 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1577
1578         Remove unused WebView._globalHistoryItem
1579         https://bugs.webkit.org/show_bug.cgi?id=190601
1580
1581         Reviewed by Chris Dumez.
1582
1583         * WebCoreSupport/WebFrameLoaderClient.h:
1584         * WebCoreSupport/WebFrameLoaderClient.mm:
1585         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1586         * WebView/WebView.mm:
1587         (-[WebView _globalHistoryItem]): Deleted.
1588         (-[WebView _setGlobalHistoryItem:]): Deleted.
1589         * WebView/WebViewData.h:
1590         * WebView/WebViewInternal.h:
1591         * WebView/WebViewPrivate.h:
1592
1593 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1594
1595         Remove unused parameters from FrameLoaderClient::createFrame
1596         https://bugs.webkit.org/show_bug.cgi?id=190587
1597
1598         Reviewed by Chris Dumez.
1599
1600         * WebCoreSupport/WebFrameLoaderClient.h:
1601         * WebCoreSupport/WebFrameLoaderClient.mm:
1602         (WebFrameLoaderClient::createFrame):
1603
1604 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1605
1606         Remove unused WebFrame._loadType
1607         https://bugs.webkit.org/show_bug.cgi?id=190583
1608
1609         Reviewed by Chris Dumez.
1610
1611         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1612
1613         * WebView/WebFrame.mm:
1614         (toWebFrameLoadType): Deleted.
1615         (-[WebFrame _loadType]): Deleted.
1616         * WebView/WebFramePrivate.h:
1617
1618 2018-10-15  Chris Dumez  <cdumez@apple.com>
1619
1620         Restrict browsing context lookup by name to frames that are related to one another
1621         https://bugs.webkit.org/show_bug.cgi?id=190475
1622
1623         Reviewed by Alex Christensen.
1624
1625         * WebView/WebFrame.mm:
1626         (-[WebFrame findFrameNamed:]):
1627
1628 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1629
1630         Remove InjectedBundle processing of back/forward lists
1631         https://bugs.webkit.org/show_bug.cgi?id=190459
1632
1633         Reviewed by Chris Dumez.
1634
1635         * WebCoreSupport/WebFrameLoaderClient.h:
1636         * WebCoreSupport/WebFrameLoaderClient.mm:
1637         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1638
1639 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1640
1641         [JSC] Remove Option::useAsyncIterator
1642         https://bugs.webkit.org/show_bug.cgi?id=190567
1643
1644         Reviewed by Saam Barati.
1645
1646         * Configurations/FeatureDefines.xcconfig:
1647
1648 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1649
1650         Allow encoding of small enum classes
1651         https://bugs.webkit.org/show_bug.cgi?id=190531
1652
1653         Reviewed by Tim Horton.
1654
1655         * WebCoreSupport/WebFrameLoaderClient.mm:
1656         (-[WebFramePolicyListener dealloc]):
1657
1658 2018-10-11  Keith Rollin  <krollin@apple.com>
1659
1660         CURRENT_ARCH should not be used in Run Script phase.
1661         https://bugs.webkit.org/show_bug.cgi?id=190407
1662         <rdar://problem/45133556>
1663
1664         Reviewed by Alexey Proskuryakov.
1665
1666         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1667         CURRENT_ARCH is not well-defined during this phase (and may even have
1668         the value "undefined") since this phase is run just once per build
1669         rather than once per supported architecture. Migrate away from
1670         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1671         performing an operation for each value, or by picking the first entry
1672         in ARCHS and using that as a representative value.
1673
1674         * Configurations/WebKitLegacy.xcconfig: When generating
1675         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1676         macosx platforms.
1677
1678         * MigrateHeaders.make:
1679         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1680         generate one for each architecture in ARCHS.
1681
1682 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1683
1684         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1685         https://bugs.webkit.org/show_bug.cgi?id=190429
1686
1687         Reviewed by Saam Barati.
1688
1689         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1690
1691         * WebView/WebPDFRepresentation.mm:
1692         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1693
1694 2018-10-08  Justin Fan  <justin_fan@apple.com>
1695
1696         WebGPU: Rename old WebGPU prototype to WebMetal
1697         https://bugs.webkit.org/show_bug.cgi?id=190325
1698         <rdar://problem/44990443>
1699
1700         Reviewed by Dean Jackson.
1701
1702         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1703
1704         * Configurations/FeatureDefines.xcconfig:
1705         * WebView/WebPreferenceKeysPrivate.h:
1706         * WebView/WebPreferences.mm:
1707         (+[WebPreferences initialize]):
1708         (-[WebPreferences webMetalEnabled]):
1709         (-[WebPreferences setWebMetalEnabled:]):
1710         (-[WebPreferences webGPUEnabled]): Deleted.
1711         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1712         * WebView/WebPreferencesPrivate.h:
1713         * WebView/WebView.mm:
1714         (-[WebView _preferencesChanged:]):
1715
1716 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1717
1718         Make <input type=color> a runtime enabled (on-by-default) feature
1719         https://bugs.webkit.org/show_bug.cgi?id=189162
1720
1721         Reviewed by Wenson Hsieh and Tim Horton.
1722
1723         * Configurations/FeatureDefines.xcconfig:
1724
1725 2018-10-07  Dan Bernstein  <mitz@apple.com>
1726
1727         Fixed building with the latest macOS SDK
1728
1729         * Plugins/WebNetscapePluginPackage.mm:
1730         (-[WebNetscapePluginPackage openResourceFile]):
1731         (-[WebNetscapePluginPackage closeResourceFile:]):
1732
1733 2018-10-04  Dan Bernstein  <mitz@apple.com>
1734
1735         More Carbon build-fixing.
1736
1737         * Carbon/CarbonWindowAdapter.mm:
1738         (-[CarbonWindowAdapter _destroyRealWindow:]):
1739         (-[CarbonWindowAdapter _growBoxRect]):
1740
1741 2018-10-04  Dan Bernstein  <mitz@apple.com>
1742
1743         Retried to fix 32-bit macOS builds after r236846.
1744
1745         * WebView/WebHTMLView.mm:
1746         (-[WebHTMLView setMarkedText:selectedRange:]):
1747
1748 2018-10-04  Dan Bernstein  <mitz@apple.com>
1749
1750         Retried to fix 32-bit macOS builds after r236846.
1751
1752         * Carbon/HIWebView.mm:
1753         (ActiveStateChanged):
1754
1755 2018-10-04  Dan Bernstein  <mitz@apple.com>
1756
1757         Tried to fix 32-bit macOS builds after r236846.
1758
1759         * Carbon/HIWebView.mm:
1760         (_NSSelectorForHICommand):
1761
1762 2018-10-04  Dan Bernstein  <mitz@apple.com>
1763
1764         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1765         https://bugs.webkit.org/show_bug.cgi?id=190250
1766
1767         Reviewed by Andy Estes.
1768
1769         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1770           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1771           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1772           an earlier line set it to YES.
1773
1774         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1775         changes below.
1776
1777         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1778           provides some missing method declarations.
1779
1780         * Misc/WebDownload.mm:
1781         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1782           a deprecated method.
1783
1784         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1785
1786         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1787           other code in the file uses a method from it.
1788
1789         * Plugins/WebBaseNetscapePluginView.mm:
1790         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1791           a deprecated method.
1792
1793         * Plugins/WebPluginController.mm:
1794         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1795           around use of a selector that may be present in some WebKit client.
1796
1797         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1798           method declarations.
1799
1800         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1801           from here.
1802
1803         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1804           missing method declarations.
1805
1806         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1807           from here.
1808
1809         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1810           call from here.
1811         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1812           an obsolete delegate method for binary compatibility.
1813         (pluginView): Ditto.
1814
1815         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1816           call from here.
1817
1818         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1819           WebDeviceOrientationProviderMock protocol.
1820
1821         * WebView/WebDeviceOrientationProviderMock.mm:
1822         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1823           main @implementation.
1824
1825         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1826           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1827
1828         * WebView/WebDynamicScrollBarsView.mm:
1829         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1830           of a deprecated method.
1831
1832         * WebView/WebHTMLView.mm:
1833         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1834           selector warning around action methods that are not declared anywhere in WebKit.
1835
1836         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1837           about implementing this deprecated method.
1838         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1839         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1840         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1841         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1842         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1843         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1844         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1845         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1846         (-[WebHTMLView doCommandBySelector:]): Ditto.
1847         (-[WebHTMLView insertText:]): Ditto.
1848
1849         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1850
1851         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1852
1853         * WebView/WebPDFView.h: Removed previewView ivar.
1854
1855         * WebView/WebPDFView.mm:
1856           Removed declaration of FileInternal category and merged its implementation with the main
1857           implementation.
1858         (-[WebPDFView dealloc]): Removed previewView ivar.
1859         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1860           exist in macOS versions we support.
1861         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1862         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1863           action methods internal to PDFKit.
1864         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1865         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1866
1867         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1868           call on macOS, even though in r86988 we started calling different methods on iOS.
1869
1870         * WebView/WebView.mm:
1871         - Imported headers that declare delegate methods that we call.
1872         - Removed declaration of WebFileInternal category and merged its implementation with the
1873           main implementation.
1874         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1875           category, which made them impossible to call from the main implementation. Moved those
1876           into the main implementation. One of those had to be declared in a class extension,
1877           because it is called from a method implemented in the WebPrivate category, and that
1878           category’s implementation appears first in the file.
1879
1880         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1881           around use of obsolete delegate method for binary compatibility.
1882
1883         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1884
1885 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1886
1887         Runtime flag and IDL for MediaRecorder
1888         https://bugs.webkit.org/show_bug.cgi?id=190018
1889
1890         Reviewed by Youenn Fablet and Chris Dumez.
1891
1892         * WebView/WebPreferenceKeysPrivate.h:
1893         * WebView/WebPreferences.mm:
1894         (+[WebPreferences initialize]):
1895         (-[WebPreferences mediaRecorderEnabled]):
1896         (-[WebPreferences setMediaRecorderEnabled:]):
1897         * WebView/WebPreferencesPrivate.h:
1898         * WebView/WebView.mm:
1899         (-[WebView _preferencesChanged:]):
1900
1901 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1902
1903         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1904         https://bugs.webkit.org/show_bug.cgi?id=190238
1905
1906         Reviewed by Antti Koivisto.
1907
1908         Enabled the feature by default.
1909
1910         * WebView/WebPreferences.mm:
1911         (+[WebPreferences initialize]):
1912
1913 2018-10-01  Dean Jackson  <dino@apple.com>
1914
1915         [macOS] Switching to discrete GPU should be done in the UI process
1916         https://bugs.webkit.org/show_bug.cgi?id=189361
1917         <rdar://problem/43949622>
1918
1919         Reviewed by Simon Fraser.
1920
1921         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1922         not support swapping to the discrete GPU in this configuration.
1923
1924         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1925         (WebKit::WebSwitchingGPUClient::singleton):
1926         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1927         * WebView/WebView.mm:
1928         (-[WebView _commonInitializationWithFrameName:groupName:]):
1929
1930 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1931
1932         Remove ParsedURLString
1933         https://bugs.webkit.org/show_bug.cgi?id=190154
1934
1935         Reviewed by Chris Dumez.
1936
1937         * WebView/WebScriptDebugger.mm:
1938         (toNSURL):
1939
1940 2018-10-01  Dean Jackson  <dino@apple.com>
1941
1942         Remove CSS Animation Triggers
1943         https://bugs.webkit.org/show_bug.cgi?id=190175
1944         <rdar://problem/44925626>
1945
1946         Reviewed by Simon Fraser.
1947
1948         * Configurations/FeatureDefines.xcconfig:
1949
1950 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1951
1952         Unreviewed, rolling out r236624 and r236671.
1953         https://bugs.webkit.org/show_bug.cgi?id=190207
1954
1955         The change in r236624 introduced crashes on the bots
1956         (Requested by ryanhaddad on #webkit).
1957
1958         Reverted changesets:
1959
1960         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1961         https://bugs.webkit.org/show_bug.cgi?id=188747
1962         https://trac.webkit.org/changeset/236624
1963
1964         "Unify implementation in VideoFullscreenInterfaceAVKit"
1965         https://bugs.webkit.org/show_bug.cgi?id=190091
1966         https://trac.webkit.org/changeset/236671
1967
1968 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1969
1970         URL should not use TextEncoding internally
1971         https://bugs.webkit.org/show_bug.cgi?id=190111
1972
1973         Reviewed by Andy Estes.
1974
1975         * Misc/WebNSURLExtras.mm:
1976
1977 2018-09-28  Jer Noble  <jer.noble@apple.com>
1978
1979         Refactoring: eliminate raw pointer usage in Fullscreen code
1980         https://bugs.webkit.org/show_bug.cgi?id=188747
1981         <rdar://problem/43541164>
1982
1983         Reviewed by Alex Christensen.
1984
1985         PlaybackSessionInterface no longer has an invalidate() method.
1986
1987         * WebView/WebView.mm:
1988         (-[WebView _clearPlaybackControlsManager]):
1989
1990 2018-09-28  Chris Dumez  <cdumez@apple.com>
1991
1992         Drop support for cross-origin-window-policy header
1993         https://bugs.webkit.org/show_bug.cgi?id=190081
1994
1995         Reviewed by Ryosuke Niwa.
1996
1997         * WebView/WebPreferenceKeysPrivate.h:
1998         * WebView/WebPreferences.mm:
1999         (+[WebPreferences initialize]):
2000         * WebView/WebPreferencesPrivate.h:
2001         * WebView/WebView.mm:
2002         (-[WebView _preferencesChanged:]):
2003
2004 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2005
2006         Rename createMarkup to serializePreservingVisualAppearance
2007         https://bugs.webkit.org/show_bug.cgi?id=190086
2008
2009         Reviewed by Wenson Hsieh.
2010
2011         * DOM/WebDOMOperations.mm:
2012         (-[DOMRange markupString]):
2013
2014 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2015
2016         Unreviewed, rolling out r236605.
2017         https://bugs.webkit.org/show_bug.cgi?id=190087
2018
2019         caused three API test timeouts (Requested by jernoble on
2020         #webkit).
2021
2022         Reverted changeset:
2023
2024         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2025         https://bugs.webkit.org/show_bug.cgi?id=188747
2026         https://trac.webkit.org/changeset/236605
2027
2028 2018-09-28  Jer Noble  <jer.noble@apple.com>
2029
2030         Refactoring: eliminate raw pointer usage in Fullscreen code
2031         https://bugs.webkit.org/show_bug.cgi?id=188747
2032         <rdar://problem/43541164>
2033
2034         Reviewed by Alex Christensen.
2035
2036         PlaybackSessionInterface no longer has an invalidate() method.
2037
2038         * WebView/WebView.mm:
2039         (-[WebView _clearPlaybackControlsManager]):
2040
2041 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2042
2043         Use enum class in createMarkup arguments
2044         https://bugs.webkit.org/show_bug.cgi?id=190028
2045
2046         Reviewed by Wenson Hsieh.
2047
2048         * DOM/WebDOMOperations.mm:
2049         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2050         (-[DOMRange markupString]): Ditto.
2051
2052 2018-09-27  Antoine Quint  <graouts@apple.com>
2053
2054         [Web Animations] Turn Web Animations with CSS integration on
2055         https://bugs.webkit.org/show_bug.cgi?id=184819
2056         <rdar://problem/39597337>
2057
2058         Reviewed by Dean Jackson.
2059
2060         * WebView/WebPreferences.mm:
2061         (+[WebPreferences initialize]):
2062
2063 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2064
2065         Selection should work across shadow boundary when initiated by a mouse drag
2066         https://bugs.webkit.org/show_bug.cgi?id=151380
2067         <rdar://problem/24363872>
2068
2069         Reviewed by Wenson Hsieh.
2070
2071         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2072
2073         * WebView/WebPreferenceKeysPrivate.h:
2074         * WebView/WebPreferences.mm:
2075         (+[WebPreferences initialize]):
2076         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2077         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2078         * WebView/WebPreferencesPrivate.h:
2079         * WebView/WebView.mm:
2080         (-[WebView _preferencesChanged:]):
2081
2082 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2083
2084         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2085         https://bugs.webkit.org/show_bug.cgi?id=189918
2086         Work towards <rdar://problem/44648705>
2087
2088         Reviewed by Tim Horton.
2089
2090         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2091
2092         * WebView/WebHTMLView.mm:
2093         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2094         (-[WebHTMLView _updateFontPanel]):
2095         * WebView/WebView.mm:
2096         (-[WebView typingAttributes]):
2097
2098 2018-09-17  Darin Adler  <darin@apple.com>
2099
2100         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2101         https://bugs.webkit.org/show_bug.cgi?id=189652
2102
2103         Reviewed by Saam Barati.
2104
2105         * WebView/WebPDFRepresentation.mm:
2106         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2107
2108 2018-09-14  Jer Noble  <jer.noble@apple.com>
2109
2110         Turn SourceBufferChangeTypeEnabled on by default
2111         https://bugs.webkit.org/show_bug.cgi?id=189527
2112
2113         Reviewed by Eric Carlson.
2114
2115         * WebView/WebPreferences.mm:
2116         (+[WebPreferences initialize]):
2117
2118 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2119
2120         Fix an internal build after r235935
2121         https://bugs.webkit.org/show_bug.cgi?id=188996
2122
2123         * Carbon/HIWebView.mm:
2124         (Draw):
2125         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2126
2127 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2128
2129         Add IGNORE_WARNING_.* macros
2130         https://bugs.webkit.org/show_bug.cgi?id=188996
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         * Carbon/CarbonUtils.m:
2135         (PoolCleaner):
2136         * Carbon/CarbonWindowAdapter.mm:
2137         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2138         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2139         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2140         (-[CarbonWindowAdapter _termWindowIfOwner]):
2141         (-[CarbonWindowAdapter _windowMovedToRect:]):
2142         (-[CarbonWindowAdapter setContentView:]):
2143         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2144         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2145         * Carbon/CarbonWindowFrame.m:
2146         (-[CarbonWindowFrame title]):
2147         * Carbon/HIViewAdapter.m:
2148         (+[HIViewAdapter getHIViewForNSView:]):
2149         * Carbon/HIWebView.mm:
2150         (overrideCGContext):
2151         (restoreCGContext):
2152         (Draw):
2153         * DOM/DOM.mm:
2154         * History/WebHistory.mm:
2155         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2156         * History/WebHistoryItem.mm:
2157         (-[WebHistoryItem icon]):
2158         * Misc/WebKitNSStringExtras.mm:
2159         (-[NSString _web_drawAtPoint:font:textColor:]):
2160         * Misc/WebNSImageExtras.m:
2161         (-[NSImage _web_scaleToMaxSize:]):
2162         (-[NSImage _web_dissolveToFraction:]):
2163         * Misc/WebNSPasteboardExtras.mm:
2164         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2165         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2166         * Panels/WebAuthenticationPanel.m:
2167         (-[WebAuthenticationPanel loadNib]):
2168         * Plugins/Hosted/NetscapePluginHostManager.mm:
2169         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2170         (WebKit::NetscapePluginHostManager::didCreateWindow):
2171         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2172         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2173         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2174         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2175         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2176         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2177         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2178         (-[WebHostedNetscapePluginView drawRect:]):
2179         * Plugins/Hosted/WebTextInputWindowController.m:
2180         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2181         * Plugins/WebBaseNetscapePluginView.mm:
2182         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2183         * Plugins/WebNetscapePluginPackage.mm:
2184         (-[WebNetscapePluginPackage _tryLoad]):
2185         * Plugins/WebNetscapePluginView.mm:
2186         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2187         (-[WebNetscapePluginView sendDrawRectEvent:]):
2188         (-[WebNetscapePluginView drawRect:]):
2189         * Plugins/WebPluginController.mm:
2190         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2191         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2192         * WebCoreSupport/PopupMenuMac.mm:
2193         (PopupMenuMac::populate):
2194         * WebCoreSupport/WebAlternativeTextClient.h:
2195         * WebCoreSupport/WebDragClient.mm:
2196         (WebDragClient::startDrag):
2197         * WebCoreSupport/WebFrameLoaderClient.mm:
2198         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2199         (webGetNSImage):
2200         * WebInspector/WebNodeHighlight.mm:
2201         * WebInspector/WebNodeHighlightView.mm:
2202         (-[WebNodeHighlightView drawRect:]):
2203         * WebView/WebClipView.mm:
2204         (-[WebClipView initWithFrame:]):
2205         * WebView/WebFrame.mm:
2206         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2207         (-[WebFrame _drawRect:contentsOnly:]):
2208         (-[WebFrame accessibilityRoot]):
2209         * WebView/WebFullScreenController.mm:
2210         (-[WebFullScreenController enterFullScreen:]):
2211         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2212         (-[WebFullScreenController exitFullScreen]):
2213         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2214         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2215         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2216         * WebView/WebHTMLView.mm:
2217         (-[NSWindow _web_borderView]):
2218         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2219         (-[WebHTMLView _setAsideSubviews]):
2220         (-[WebHTMLView _autoscroll]):
2221         (-[WebHTMLView drawRect:]):
2222         (-[WebHTMLView mouseDown:]):
2223         (-[WebHTMLView mouseDragged:]):
2224         (-[WebHTMLView mouseUp:]):
2225         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2226         (-[WebHTMLView knowsPageRange:]):
2227         (-[WebHTMLView accessibilityHitTest:]):
2228         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2229         (-[WebHTMLView _colorAsString:]):
2230         (-[WebHTMLView copyFont:]):
2231         (-[WebHTMLView _executeSavedKeypressCommands]):
2232         (-[WebHTMLView attachRootLayer:]):
2233         (-[WebHTMLView textStorage]):
2234         (-[WebHTMLView _updateSelectionForInputManager]):
2235         * WebView/WebPDFView.mm:
2236         (_applicationInfoForMIMEType):
2237         (-[WebPDFView centerSelectionInVisibleArea:]):
2238         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2239         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2240         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2241         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2242         * WebView/WebTextCompletionController.mm:
2243         (-[WebTextCompletionController _buildUI]):
2244         (-[WebTextCompletionController _placePopupWindow:]):
2245         * WebView/WebVideoFullscreenController.mm:
2246         * WebView/WebVideoFullscreenHUDWindowController.mm:
2247         (createMediaUIBackgroundView):
2248         * WebView/WebView.mm:
2249         (-[WebTextListTouchBarViewController initWithWebView:]):
2250         (-[WebView _dispatchTileDidDraw:]):
2251         (-[WebView encodeWithCoder:]):
2252         (-[WebView mainFrameIcon]):
2253         (LayerFlushController::flushLayers):
2254         * WebView/WebWindowAnimation.mm:
2255         (setScaledFrameForWindow):
2256
2257 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2258
2259         Remove unused needsDestruction class variables from HashTraits
2260         https://bugs.webkit.org/show_bug.cgi?id=189490
2261
2262         Reviewed by Daniel Bates.
2263
2264         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2265
2266 2018-09-07  Frederic Wang  <fwang@igalia.com>
2267
2268         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2269         https://bugs.webkit.org/show_bug.cgi?id=182230
2270
2271         Reviewed by Simon Fraser.
2272
2273         * DOM/DOMDocument.mm:
2274         (-[DOMDocument scrollingElement]): Use the new name.
2275
2276 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2277
2278         Refactor WebCore::EditAction to be an 8-bit enum class
2279         https://bugs.webkit.org/show_bug.cgi?id=189383
2280
2281         Reviewed by Dan Bernstein.
2282
2283         * WebCoreSupport/WebEditorClient.mm:
2284         (undoNameForEditAction):
2285         * WebView/WebHTMLView.mm:
2286         (-[WebHTMLView pasteFont:]):
2287         (-[WebHTMLView changeFont:]):
2288         (-[WebHTMLView changeAttributes:]):
2289         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2290         (-[WebHTMLView changeColor:]):
2291         * WebView/WebView.mm:
2292         (-[WebView setTypingStyle:]):
2293
2294 2018-09-06  Frederic Wang  <fwang@igalia.com>
2295
2296         Group options of scrollRectToVisible into a struct
2297         https://bugs.webkit.org/show_bug.cgi?id=189352
2298
2299         Reviewed by Simon Fraser.
2300
2301         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2302         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2303         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2304
2305 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2306
2307         [macOS] Cannot change font size at selection until font panel is shown
2308         https://bugs.webkit.org/show_bug.cgi?id=189295
2309         <rdar://problem/35593389>
2310
2311         Reviewed by Ryosuke Niwa.
2312
2313         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2314         WebCore ChangeLog for more details.
2315
2316         * WebView/WebHTMLView.mm:
2317         (-[WebHTMLView changeFont:]):
2318         (-[WebHTMLView changeAttributes:]):
2319         (-[WebHTMLView _originalFontA]): Deleted.
2320         (-[WebHTMLView _originalFontB]): Deleted.
2321         (fontNameForDescription): Deleted.
2322         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2323         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2324         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2325
2326 2018-09-05  Jer Noble  <jer.noble@apple.com>
2327
2328         Add MediaCapabilities as an Experimental Feature
2329         https://bugs.webkit.org/show_bug.cgi?id=189209
2330
2331         Reviewed by Eric Carlson.
2332
2333         RuntimeEnabledFeature -> Setting.
2334
2335         * WebView/WebView.mm:
2336         (-[WebView _preferencesChanged:]):
2337
2338 2018-09-04  Frederic Wang  <fwang@igalia.com>
2339
2340         Add basic support for ScrollIntoViewOptions
2341         https://bugs.webkit.org/show_bug.cgi?id=189258
2342
2343         Reviewed by Simon Fraser.
2344
2345         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2346         header so that this file can build despite the new scrollIntoView function.
2347
2348 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2349
2350         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2351         https://bugs.webkit.org/show_bug.cgi?id=188890
2352         <rdar://problem/43648605>
2353
2354         Reviewed by Tim Horton.
2355
2356         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2357         more detail.
2358
2359         * WebCoreSupport/WebPlatformStrategies.h:
2360         * WebCoreSupport/WebPlatformStrategies.mm:
2361         (WebPlatformStrategies::allStringsForType):
2362
2363 2018-09-01  Darin Adler  <darin@apple.com>
2364
2365         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2366         https://bugs.webkit.org/show_bug.cgi?id=189072
2367         Reviewed by Dan Bernstein.
2368
2369         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2370         and declarations for NSURLDownload init methods.
2371
2372         * Misc/WebDownloadInternal.h: Removed.
2373
2374         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2375         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2376         "-Wdeprecated-declarations" because the method used here is deprecated.
2377
2378         * WebView/WebView.mm:
2379         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2380         used here is deprecated.
2381
2382 2018-08-31  Chris Dumez  <cdumez@apple.com>
2383
2384         Assertion hit in ~CompletionHandler() from ~WebFrame()
2385         https://bugs.webkit.org/show_bug.cgi?id=189199
2386         <rdar://problem/42657233>
2387
2388         Reviewed by Youenn Fablet.
2389
2390         * WebCoreSupport/WebFrameLoaderClient.h:
2391         * WebCoreSupport/WebFrameLoaderClient.mm:
2392         (WebFrameLoaderClient::dispatchWillSubmitForm):
2393
2394 2018-08-31  Antti Koivisto  <antti@apple.com>
2395
2396         Replace OptionSet |= and -= operators with add() and remove() functions
2397         https://bugs.webkit.org/show_bug.cgi?id=189169
2398
2399         Reviewed by Anders Carlsson.
2400
2401         * WebView/WebFrame.mm:
2402         (-[WebFrame _drawRect:contentsOnly:]):
2403         * WebView/WebView.mm:
2404         (coreOptions):
2405
2406 2018-08-31  Frederic Wang  <fwang@igalia.com>
2407
2408         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2409         https://bugs.webkit.org/show_bug.cgi?id=182053
2410
2411         Reviewed by Simon Fraser.
2412
2413         Add developer flag to use standard behavior for scrolling* attributes.
2414
2415         * WebView/WebPreferenceKeysPrivate.h:
2416         * WebView/WebPreferences.mm:
2417         (+[WebPreferences initialize]):
2418         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2419         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2420         * WebView/WebPreferencesPrivate.h:
2421         * WebView/WebView.mm:
2422         (-[WebView _preferencesChanged:]):
2423
2424 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2425
2426         Implement the Web Share API
2427         https://bugs.webkit.org/show_bug.cgi?id=171100
2428         <rdar://problem/31751734>
2429
2430         Reviewed by Tim Horton.
2431
2432         * WebCoreSupport/WebChromeClient.h:
2433         * WebCoreSupport/WebChromeClient.mm:
2434         (WebChromeClient::showShareSheet):
2435         Empty declaration of showShareSheet.
2436
2437 2018-08-29  Youenn Fablet  <youenn@apple.com>
2438
2439         Remove WebRTC legacy API implementation
2440         https://bugs.webkit.org/show_bug.cgi?id=189040
2441
2442         Reviewed by Eric Carlson.
2443
2444         * WebView/WebPreferenceKeysPrivate.h:
2445         * WebView/WebPreferences.mm:
2446         (+[WebPreferences initialize]):
2447         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2448         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2449         * WebView/WebPreferencesPrivate.h:
2450         * WebView/WebView.mm:
2451         (-[WebView _preferencesChanged:]):
2452
2453 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2454
2455         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2456         https://bugs.webkit.org/show_bug.cgi?id=189054
2457
2458         Reviewed by Andy Estes.
2459
2460         Remove the pasteboard type argument from readURLFromPasteboard.
2461
2462         * WebCoreSupport/WebPlatformStrategies.h:
2463         * WebCoreSupport/WebPlatformStrategies.mm:
2464         (WebPlatformStrategies::readURLFromPasteboard):
2465
2466 2018-08-27  Keith Rollin  <krollin@apple.com>
2467
2468         Unreviewed build fix -- disable LTO for production builds
2469
2470         * Configurations/Base.xcconfig:
2471
2472 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2473
2474         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2475         https://bugs.webkit.org/show_bug.cgi?id=188931
2476
2477         Reviewed by Wenson Hsieh.
2478
2479         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2480
2481 2018-08-27  Keith Rollin  <krollin@apple.com>
2482
2483         Build system support for LTO
2484         https://bugs.webkit.org/show_bug.cgi?id=187785
2485         <rdar://problem/42353132>
2486
2487         Reviewed by Dan Bernstein.
2488
2489         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2490         LTO.
2491
2492         * Configurations/Base.xcconfig:
2493         * Configurations/DebugRelease.xcconfig:
2494
2495 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2496
2497         Pass in IsComposed flag to Event constructors
2498         https://bugs.webkit.org/show_bug.cgi?id=188720
2499         <rdar://problem/43580387>
2500
2501         Reviewed by Simon Fraser.
2502
2503         * WebView/WebPDFView.mm:
2504         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2505         whether it's simulated or not.
2506
2507 2018-08-23  Mark Lam  <mark.lam@apple.com>
2508
2509         Move vmEntryGlobalObject() to VM from CallFrame.
2510         https://bugs.webkit.org/show_bug.cgi?id=188900
2511         <rdar://problem/43655753>
2512
2513         Reviewed by Michael Saboff.
2514
2515         * WebView/WebScriptDebugger.mm:
2516         (WebScriptDebugger::sourceParsed):
2517
2518 2018-08-23  Andy Estes  <aestes@apple.com>
2519
2520         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2521         https://bugs.webkit.org/show_bug.cgi?id=188829
2522
2523         Reviewed by Tim Horton.
2524
2525         * Configurations/FeatureDefines.xcconfig:
2526
2527 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2528
2529         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2530         https://bugs.webkit.org/show_bug.cgi?id=188777
2531
2532         Reviewed by Simon Fraser.
2533
2534         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2535         being "true" before the code change.
2536
2537         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2538
2539         * WebView/WebPDFView.mm:
2540         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2541
2542 2018-08-21  Daniel Bates  <dabates@apple.com>
2543
2544         Replace TextCheckingTypeMask with OptionSet
2545         https://bugs.webkit.org/show_bug.cgi?id=188678
2546
2547         Reviewed by Antti Koivisto.
2548
2549         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2550         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2551         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2552         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2553
2554         * WebCoreSupport/WebEditorClient.h:
2555         * WebCoreSupport/WebEditorClient.mm:
2556         (WebEditorClient::checkTextOfParagraph):
2557         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2558         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2559         left as this is more readable and unncessary now that modern compilers like Clang have
2560         diagnostics to catch accidental assignments when equality was intended.
2561         (WebEditorClient::didCheckSucceed):
2562         * WebView/WebView.mm:
2563         (coreTextCheckingType):
2564         (textCheckingResultFromNSTextCheckingResult):
2565
2566 2018-08-21  Daniel Bates  <dabates@apple.com>
2567
2568         [iOS][WK1] Support toggling continuous spell checking from tests
2569         https://bugs.webkit.org/show_bug.cgi?id=188763
2570
2571         Reviewed by Simon Fraser.
2572
2573         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2574         spell checking from tests in iOS WebKit Legacy.
2575
2576         * WebCoreSupport/WebEditorClient.h:
2577         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2578         * WebCoreSupport/WebEditorClient.mm:
2579         * WebView/WebView.h:
2580         * WebView/WebView.mm:
2581         (-[WebView toggleContinuousSpellChecking:]):
2582         (-[WebView toggleSmartInsertDelete:]):
2583
2584 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2585
2586         Add some plumbing for safe browsing
2587         https://bugs.webkit.org/show_bug.cgi?id=188709
2588
2589         Reviewed by Tim Horton.
2590
2591         * WebCoreSupport/WebFrameLoaderClient.h:
2592         * WebCoreSupport/WebFrameLoaderClient.mm:
2593         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2594
2595 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2596
2597         Replace canBubble and cancelable booleans in Event by enum classes
2598         https://bugs.webkit.org/show_bug.cgi?id=188692
2599
2600         Reviewed by Alex Christensen.
2601
2602         * WebView/WebPDFView.mm:
2603         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2604         * WebView/WebView.mm:
2605         (-[WebView _dispatchUnloadEvent]):
2606
2607 2018-08-16  Jer Noble  <jer.noble@apple.com>
2608
2609         Add Experimental Feature support for SourceBuffer.changeType()
2610         https://bugs.webkit.org/show_bug.cgi?id=188626
2611         <rdar://problem/43356021>
2612
2613         Reviewed by Eric Carlson.
2614
2615         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2616
2617         * WebView/WebPreferenceKeysPrivate.h:
2618         * WebView/WebPreferences.mm:
2619         (+[WebPreferences initialize]):
2620         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2621         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2622         * WebView/WebPreferencesPrivate.h:
2623         * WebView/WebView.mm:
2624         (-[WebView _preferencesChanged:]):
2625
2626 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2627
2628         Support drag-and-drop for input[type=color]
2629         https://bugs.webkit.org/show_bug.cgi?id=188464
2630
2631         Reviewed by Wenson Hsieh.
2632
2633         * WebCoreSupport/WebPlatformStrategies.h:
2634         * WebCoreSupport/WebPlatformStrategies.mm:
2635         (WebPlatformStrategies::setColor):
2636
2637 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2638
2639         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2640         https://bugs.webkit.org/show_bug.cgi?id=188569
2641         <rdar://problem/34201095>
2642
2643         Reviewed by Megan Gardner.
2644
2645         * WebView/WebImmediateActionController.mm:
2646         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2647         Speculative fix; the crashes indicate font is null, but we just checked it,
2648         so it must be getting made null by convertFont:toSize:. Check again!
2649
2650 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2651
2652         Use a 1-byte enum class for TextDirection
2653         https://bugs.webkit.org/show_bug.cgi?id=188350
2654
2655         Reviewed by Simon Fraser.
2656
2657         * WebCoreSupport/PopupMenuMac.mm:
2658         (PopupMenuMac::populate):
2659         (PopupMenuMac::show):
2660         * WebCoreSupport/WebFrameLoaderClient.mm:
2661         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2662         * WebView/WebFrame.mm:
2663         (-[WebFrame _dispatchDidReceiveTitle:]):
2664
2665 2018-08-09  Ali Juma  <ajuma@chromium.org>
2666
2667         Import WPTs for IntersectionObserver
2668         https://bugs.webkit.org/show_bug.cgi?id=188416
2669
2670         Reviewed by Simon Fraser.
2671
2672         * WebView/WebPreferencesPrivate.h:
2673
2674 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2675
2676         Follow-up build fix for r234685
2677         https://bugs.webkit.org/show_bug.cgi?id=188245
2678
2679         Unreviewed build fix.
2680
2681         * WebCoreSupport/WebSecurityOriginPrivate.h:
2682
2683 2018-08-05  Darin Adler  <darin@apple.com>
2684
2685         [Cocoa] More tweaks and refactoring to prepare for ARC
2686         https://bugs.webkit.org/show_bug.cgi?id=188245
2687
2688         Reviewed by Dan Bernstein.
2689
2690         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2691
2692         * Carbon/CarbonWindowFrame.m:
2693         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2694
2695         * DOM/DOM.mm:
2696         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2697         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2698         garbage collection so this method isn't useful.
2699
2700         * DOM/DOMXPath.mm:
2701         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2702         Objective-C garbage collection so this method isn't useful.
2703
2704         * History/WebHistory.mm:
2705         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2706
2707         * Misc/WebElementDictionary.mm:
2708         (addLookupKey): Use a bridging cast.
2709         (cacheValueForKey): Ditto.
2710         (-[WebElementDictionary _fillCache]): Ditto.
2711         (-[WebElementDictionary objectForKey:]): Ditto.
2712
2713         * Misc/WebKitNSStringExtras.mm:
2714         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2715         (-[NSString _web_widthWithFont:]): Ditto.
2716         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2717
2718         * Misc/WebLocalizableStrings.mm:
2719         (WebLocalizedString): Use a bridging cast.
2720
2721         * Misc/WebNSDataExtras.mm:
2722         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2723         and use CFBridgingRelease instead of calling autorelease directly.
2724         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2725         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2726         on the amount of explicit release and autorelease.
2727
2728         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2729         * Misc/WebNSDictionaryExtras.m:
2730         (-[NSDictionary _webkit_intForKey:]): Deleted.
2731         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2732         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2733         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2734         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2735         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2736         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2737
2738         * Misc/WebStringTruncator.mm:
2739         (fontFromNSFont): Use a bridging cast.
2740
2741         * Plugins/Hosted/NetscapePluginHostManager.mm:
2742         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2743
2744         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2745         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2746         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2747         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2748         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2749         * Plugins/Hosted/ProxyInstance.mm:
2750         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2751         * Plugins/WebBasePluginPackage.mm:
2752         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2753         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2754         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2755         * Plugins/WebNetscapePluginPackage.mm:
2756         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2757
2758         * Plugins/WebNetscapePluginView.mm:
2759         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2760         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2761         (-[WebNetscapePluginView status:]): Use a bridging cast.
2762         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2763
2764         * Plugins/WebPluginController.mm:
2765         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2766
2767         * Plugins/WebPluginDatabase.mm:
2768         (checkCandidate): Use explicit __strong for out argument types.
2769
2770         * Plugins/npapi.mm:
2771         (pluginViewForInstance): Use a bridging cast.
2772
2773         * Storage/WebDatabaseManager.mm:
2774         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2775         explicit NSNumber and NSDictionary calls.
2776
2777         * WebCoreSupport/WebContextMenuClient.mm:
2778         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2779
2780         * WebCoreSupport/WebEditorClient.mm:
2781         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2782         (WebEditorClient::handleInputMethodKeydown): Ditto.
2783
2784         * WebCoreSupport/WebFrameNetworkingContext.mm:
2785         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2786
2787         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2788         as a struct rather than an Objective-C class, since that's how it's defined.
2789
2790         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2791
2792         * WebView/WebFullScreenController.mm:
2793         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2794         * WebView/WebHTMLView.mm:
2795         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2796         Ditto.
2797         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2798
2799         * WebView/WebImmediateActionController.mm:
2800         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2801         go down to the document and then back to the frame.
2802         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2803         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2804         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2805
2806         * WebView/WebJSPDFDoc.mm:
2807         (jsPDFDocInitialize): Removed some unneeded type casting.
2808         (jsPDFDocFinalize): Ditto.
2809         (jsPDFDocPrint): Use a bridging cast.
2810
2811         * WebView/WebPDFView.mm:
2812         (_applicationInfoForMIMEType): Use bridging casts.
2813
2814         * WebView/WebPreferences.mm:
2815         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2816         instead of methods from WebNSDictionaryExtras.
2817         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2818         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2819         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2820         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2821         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2822
2823         * WebView/WebView.mm:
2824         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2825         (-[WebView _addToAllWebViewsSet]): Ditto.
2826         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2827         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2828         so it can be called from WebViewData methods.
2829
2830         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2831         method, _windowVisibilityChanged:.
2832
2833         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2834         called from WebViewData methods.
2835
2836 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2837
2838         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2839         https://bugs.webkit.org/show_bug.cgi?id=188323
2840
2841         Reviewed by Simon Fraser.
2842
2843         * WebCoreSupport/WebContextMenuClient.mm:
2844         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2845         * WebView/WebFrame.mm:
2846         (-[WebFrame _paintBehaviorForDestinationContext:]):
2847         (-[WebFrame _drawRect:contentsOnly:]):
2848         * WebView/WebHTMLView.mm:
2849         (imageFromRect):
2850         (selectionImage):
2851
2852 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2853
2854         Add support for microtasks in workers
2855         https://bugs.webkit.org/show_bug.cgi?id=188246
2856
2857         Reviewed by Darin Adler.
2858
2859         Rename JSMainThreadExecState.h to JSExecState.h.
2860
2861         * DOM/DOMAttr.mm:
2862         * DOM/DOMBlob.mm:
2863         * DOM/DOMCDATASection.mm:
2864         * DOM/DOMCSSCharsetRule.mm:
2865         * DOM/DOMCSSFontFaceRule.mm:
2866         * DOM/DOMCSSImportRule.mm:
2867         * DOM/DOMCSSMediaRule.mm:
2868         * DOM/DOMCSSPageRule.mm:
2869         * DOM/DOMCSSPrimitiveValue.mm:
2870         * DOM/DOMCSSRule.mm:
2871         * DOM/DOMCSSRuleList.mm:
2872         * DOM/DOMCSSStyleDeclaration.mm:
2873         * DOM/DOMCSSStyleRule.mm:
2874         * DOM/DOMCSSStyleSheet.mm:
2875         * DOM/DOMCSSUnknownRule.mm:
2876         * DOM/DOMCSSValue.mm:
2877         * DOM/DOMCSSValueList.mm:
2878         * DOM/DOMCharacterData.mm:
2879         * DOM/DOMComment.mm:
2880         * DOM/DOMCounter.mm:
2881         * DOM/DOMDocument.mm:
2882         * DOM/DOMDocumentFragment.mm:
2883         * DOM/DOMDocumentType.mm:
2884         * DOM/DOMElement.mm:
2885         * DOM/DOMEvent.mm:
2886         * DOM/DOMFile.mm:
2887         * DOM/DOMFileList.mm:
2888         * DOM/DOMHTML.mm:
2889         * DOM/DOMHTMLAnchorElement.mm:
2890         * DOM/DOMHTMLAppletElement.mm:
2891         * DOM/DOMHTMLAreaElement.mm:
2892         * DOM/DOMHTMLBRElement.mm:
2893         * DOM/DOMHTMLBaseElement.mm:
2894         * DOM/DOMHTMLBaseFontElement.mm:
2895         * DOM/DOMHTMLBodyElement.mm:
2896         * DOM/DOMHTMLButtonElement.mm:
2897         * DOM/DOMHTMLCanvasElement.mm:
2898         * DOM/DOMHTMLCollection.mm:
2899         * DOM/DOMHTMLDListElement.mm:
2900         * DOM/DOMHTMLDirectoryElement.mm:
2901         * DOM/DOMHTMLDivElement.mm:
2902         * DOM/DOMHTMLDocument.mm:
2903         * DOM/DOMHTMLElement.mm:
2904         * DOM/DOMHTMLEmbedElement.mm:
2905         * DOM/DOMHTMLFieldSetElement.mm:
2906         * DOM/DOMHTMLFontElement.mm:
2907         * DOM/DOMHTMLFormElement.mm:
2908         * DOM/DOMHTMLFrameElement.mm:
2909         * DOM/DOMHTMLFrameSetElement.mm:
2910         * DOM/DOMHTMLHRElement.mm:
2911         * DOM/DOMHTMLHeadElement.mm:
2912         * DOM/DOMHTMLHeadingElement.mm:
2913         * DOM/DOMHTMLHtmlElement.mm:
2914         * DOM/DOMHTMLIFrameElement.mm:
2915         * DOM/DOMHTMLImageElement.mm:
2916         * DOM/DOMHTMLInputElement.mm:
2917         * DOM/DOMHTMLLIElement.mm:
2918         * DOM/DOMHTMLLabelElement.mm:
2919         * DOM/DOMHTMLLegendElement.mm:
2920         * DOM/DOMHTMLLinkElement.mm:
2921         * DOM/DOMHTMLMapElement.mm:
2922         * DOM/DOMHTMLMarqueeElement.mm:
2923         * DOM/DOMHTMLMediaElement.mm:
2924         * DOM/DOMHTMLMenuElement.mm:
2925         * DOM/DOMHTMLMetaElement.mm:
2926         * DOM/DOMHTMLModElement.mm:
2927         * DOM/DOMHTMLOListElement.mm:
2928         * DOM/DOMHTMLObjectElement.mm:
2929         * DOM/DOMHTMLOptGroupElement.mm:
2930         * DOM/DOMHTMLOptionElement.mm:
2931         * DOM/DOMHTMLOptionsCollection.mm:
2932         * DOM/DOMHTMLParagraphElement.mm:
2933         * DOM/DOMHTMLParamElement.mm:
2934         * DOM/DOMHTMLPreElement.mm:
2935         * DOM/DOMHTMLQuoteElement.mm:
2936         * DOM/DOMHTMLScriptElement.mm:
2937         * DOM/DOMHTMLSelectElement.mm:
2938         * DOM/DOMHTMLStyleElement.mm:
2939         * DOM/DOMHTMLTableCaptionElement.mm:
2940         * DOM/DOMHTMLTableCellElement.mm:
2941         * DOM/DOMHTMLTableColElement.mm:
2942         * DOM/DOMHTMLTableElement.mm:
2943         * DOM/DOMHTMLTableRowElement.mm:
2944         * DOM/DOMHTMLTableSectionElement.mm:
2945         * DOM/DOMHTMLTextAreaElement.mm:
2946         * DOM/DOMHTMLTitleElement.mm:
2947         * DOM/DOMHTMLUListElement.mm:
2948         * DOM/DOMHTMLVideoElement.mm:
2949         * DOM/DOMImplementation.mm:
2950         * DOM/DOMKeyboardEvent.mm:
2951         * DOM/DOMMediaError.mm:
2952         * DOM/DOMMediaList.mm:
2953         * DOM/DOMMouseEvent.mm:
2954         * DOM/DOMMutationEvent.mm:
2955         * DOM/DOMNamedNodeMap.mm:
2956         * DOM/DOMNode.mm:
2957         * DOM/DOMNodeIterator.mm:
2958         * DOM/DOMNodeList.mm:
2959         * DOM/DOMOverflowEvent.mm:
2960         * DOM/DOMProcessingInstruction.mm:
2961         * DOM/DOMProgressEvent.mm:
2962         * DOM/DOMRGBColor.mm:
2963         * DOM/DOMRange.mm:
2964         * DOM/DOMRect.mm:
2965         * DOM/DOMStyleSheet.mm:
2966         * DOM/DOMStyleSheetList.mm:
2967         * DOM/DOMText.mm:
2968         * DOM/DOMTextEvent.mm:
2969         * DOM/DOMTimeRanges.mm:
2970         * DOM/DOMTokenList.mm:
2971         * DOM/DOMTreeWalker.mm:
2972         * DOM/DOMUIEvent.mm:
2973         * DOM/DOMWheelEvent.mm:
2974         * DOM/DOMXPathExpression.mm:
2975         * DOM/DOMXPathResult.mm:
2976         * DOM/ObjCEventListener.mm:
2977
2978 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2979
2980         Fix spelling of "overridden"
2981         https://bugs.webkit.org/show_bug.cgi?id=188315
2982
2983         Reviewed by Darin Adler.
2984
2985         * Misc/WebKitVersionChecks.mm:
2986         (setWebKitLinkTimeVersion):
2987         (WebKitLinkTimeVersion):
2988         * Plugins/WebBaseNetscapePluginView.mm:
2989         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2990         * WebCoreSupport/PopupMenuMac.mm:
2991         (PopupMenuMac::populate):
2992
2993 2018-08-01  Nan Wang  <n_wang@apple.com>
2994
2995         AX: AOM: Add ARIA IDL Attribute Reflection
2996         https://bugs.webkit.org/show_bug.cgi?id=184676
2997         <rdar://problem/39476882>
2998
2999         Reviewed by Chris Fleizach.
3000
3001         * WebView/WebPreferenceKeysPrivate.h:
3002         * WebView/WebPreferences.mm:
3003         (+[WebPreferences initialize]):
3004         (-[WebPreferences ariaReflectionEnabled]):
3005         (-[WebPreferences setAriaReflectionEnabled:]):
3006         * WebView/WebPreferencesPrivate.h:
3007         * WebView/WebView.mm:
3008         (-[WebView _preferencesChanged:]):
3009
3010 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3011
3012         Shrink GraphicsLayerCA
3013         https://bugs.webkit.org/show_bug.cgi?id=188141
3014
3015         Reviewed by Zalan Bujtas.
3016
3017         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3018         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3019         * moving all the animation-related stuff into the lazily-allocated m_animations
3020         * making enums be 8-bit
3021         * re-ordering data members
3022
3023         * WebView/WebView.mm:
3024         (-[WebView _setMediaLayer:forPluginView:]):
3025
3026 2018-07-30  Rob Buis  <rbuis@igalia.com>
3027
3028         Merge PlatformCookieJar functions into NetworkStorageSession
3029         https://bugs.webkit.org/show_bug.cgi?id=188137
3030
3031         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3032
3033         Reviewed by Alex Christensen.
3034
3035         * WebCoreSupport/WebPlatformStrategies.mm:
3036         (WebPlatformStrategies::cookiesForDOM):
3037         (WebPlatformStrategies::setCookiesFromDOM):
3038         (WebPlatformStrategies::cookiesEnabled):
3039         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3040         (WebPlatformStrategies::getRawCookies):
3041         (WebPlatformStrategies::deleteCookie):
3042         * WebView/WebPreferences.mm:
3043         (+[WebPreferences _clearNetworkLoaderSession]):
3044
3045 2018-07-28  Darin Adler  <darin@apple.com>
3046
3047         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3048         https://bugs.webkit.org/show_bug.cgi?id=188140
3049
3050         Reviewed by Sam Weinig.
3051
3052         * WebView/WebImmediateActionController.mm:
3053         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3054         new DictionaryLookup function that returns a tuple instead of using an out argument.
3055
3056 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3057
3058         [INTL] Remove INTL sub-feature compile flags
3059         https://bugs.webkit.org/show_bug.cgi?id=188081
3060
3061         Reviewed by Michael Catanzaro.
3062
3063         * Configurations/FeatureDefines.xcconfig:
3064
3065 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3066
3067         Unreviewed, rolling out r234181 and r234189.
3068         https://bugs.webkit.org/show_bug.cgi?id=188075
3069
3070         These are not needed right now (Requested by thorton on
3071         #webkit).
3072
3073         Reverted changesets:
3074
3075         "Enable Web Content Filtering on watchOS"
3076         https://bugs.webkit.org/show_bug.cgi?id=187979
3077         https://trac.webkit.org/changeset/234181
3078
3079         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3080         https://bugs.webkit.org/show_bug.cgi?id=187985
3081         https://trac.webkit.org/changeset/234189
3082
3083 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3084
3085         Use the Page's appearance when converting pasteboard attributed strings.
3086         https://bugs.webkit.org/show_bug.cgi?id=188067
3087         rdar://problem/42632246
3088
3089         Reviewed by Wenson Hsieh.
3090
3091         * WebCoreSupport/WebEditorClient.mm:
3092         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3093
3094 2018-07-25  Chris Dumez  <cdumez@apple.com>
3095
3096         navigator.userAgent may return outdated value after webView.customUserAgent is set
3097         https://bugs.webkit.org/show_bug.cgi?id=188009
3098         <rdar://problem/42566456>
3099
3100         Reviewed by Alex Christensen.
3101
3102         Let the page know when the user agent changes.
3103
3104         * WebView/WebView.mm:
3105         (-[WebView _preferencesChanged:]):
3106         (-[WebView setApplicationNameForUserAgent:]):
3107         (-[WebView _invalidateUserAgentCache]):
3108         (-[WebView setCustomUserAgent:]):
3109         * WebView/WebViewInternal.h:
3110
3111 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3112
3113         Enable Web Content Filtering on watchOS
3114         https://bugs.webkit.org/show_bug.cgi?id=187979
3115         <rdar://problem/42559346>
3116
3117         Reviewed by Wenson Hsieh.
3118
3119         * Configurations/FeatureDefines.xcconfig:
3120
3121 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3122
3123         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3124         https://bugs.webkit.org/show_bug.cgi?id=187846
3125
3126         Reviewed by Simon Fraser.
3127
3128         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3129
3130         * WebView/WebHTMLView.mm:
3131         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3132         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3133
3134 2018-07-11  Dean Jackson  <dino@apple.com>
3135
3136         Allow removal of white backgrounds
3137         https://bugs.webkit.org/show_bug.cgi?id=187574
3138         <rdar://problem/41146792>
3139
3140         Reviewed by Simon Fraser.
3141
3142         Add a new WebPreference for punching out white backgrounds.
3143
3144         * WebView/WebPreferenceKeysPrivate.h:
3145         * WebView/WebPreferences.mm:
3146         (+[WebPreferences initialize]):
3147         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3148         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3149         * WebView/WebPreferencesPrivate.h:
3150         * WebView/WebView.mm:
3151         (-[WebView _preferencesChanged:]):
3152
3153 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3154
3155         Ensure WebKit stack is ad-hoc signed
3156         https://bugs.webkit.org/show_bug.cgi?id=187667
3157
3158         Reviewed by Alexey Proskuryakov.
3159
3160         * Configurations/Base.xcconfig:
3161
3162 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3163
3164         REGRESSION (231276): Attempting to copy an image fails
3165         https://bugs.webkit.org/show_bug.cgi?id=187212
3166         <rdar://problem/41540074>
3167
3168         Reviewed by Ryosuke Niwa.
3169
3170         Renamed methods to make it clear that one URL and one title are being passed in.
3171
3172         * WebCoreSupport/WebPlatformStrategies.h:
3173         * WebCoreSupport/WebPlatformStrategies.mm:
3174         (WebPlatformStrategies::setURL):
3175
3176 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3177
3178         Disable cross-origin-window-policy by default
3179         https://bugs.webkit.org/show_bug.cgi?id=187509
3180
3181         Reviewed by Chris Dumez.
3182
3183         * WebView/WebPreferences.mm:
3184         (+[WebPreferences initialize]):
3185
3186 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3187
3188         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3189         https://bugs.webkit.org/show_bug.cgi?id=187425
3190         rdar://problem/39948240
3191
3192         Reviewed by Tim Horton.
3193
3194         * WebView/WebView.mm:
3195         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3196         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3197         a call in this method to setUseDarkAppearance.
3198         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3199         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3200         (-[WebView _updateDefaultAppearance]): Deleted.
3201         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3202
3203 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3204
3205         Shrink various loading-related enums to shrink CachedResource
3206         https://bugs.webkit.org/show_bug.cgi?id=187443
3207
3208         Reviewed by Chris Dumez.
3209
3210         * WebCoreSupport/WebFrameLoaderClient.mm:
3211         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3212         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3213         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3214         (WebFrameLoaderClient::dispatchWillSendRequest):
3215         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3216         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3217         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3218         (WebFrameLoaderClient::updateGlobalHistory):
3219         (WebFrameLoaderClient::canHandleRequest const):
3220         * WebView/WebDataSource.mm:
3221         (-[WebDataSource initialRequest]):
3222         (-[WebDataSource request]):
3223
3224 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3225
3226         Unreviewed, rolling out r233612.
3227         https://bugs.webkit.org/show_bug.cgi?id=187475
3228
3229         Revision caused the api test LinkColorWithSystemAppearance to
3230         fail on all systems. (Requested by Truitt on #webkit).
3231
3232         Reverted changeset:
3233
3234         "Semantic colors don't update when accessibility Increase
3235         Contrast mode is enabled."
3236         https://bugs.webkit.org/show_bug.cgi?id=187425
3237         https://trac.webkit.org/changeset/233612
3238
3239 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3240
3241         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3242         https://bugs.webkit.org/show_bug.cgi?id=187425
3243         rdar://problem/39948240
3244
3245         Reviewed by Tim Horton.
3246
3247         * WebView/WebView.mm:
3248         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3249         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3250         a call in this method to setUseDarkAppearance.
3251         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3252         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3253         (-[WebView _updateDefaultAppearance]): Deleted.
3254         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3255
3256 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3257
3258         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3259         https://bugs.webkit.org/show_bug.cgi?id=187369
3260         rdar://problem/41870420
3261
3262         Reviewed by Tim Horton.
3263
3264         * WebView/WebMediaPlaybackTargetPicker.mm:
3265         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3266         * WebView/WebView.mm:
3267         (-[WebView _commonInitializationWithFrameName:groupName:]):
3268         (-[WebView _effectiveAppearanceIsDark]):
3269         (-[WebView _updateDefaultAppearance]):
3270         (-[WebView _defaultAppearance]): Deleted.
3271
3272 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3273
3274         Youtube video pages crash after a couple of minutes
3275         https://bugs.webkit.org/show_bug.cgi?id=187316
3276
3277         Reviewed by Antti Koivisto.
3278
3279         * WebView/WebView.mm:
3280         (-[WebView _preferencesChanged:]):
3281
3282 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3283
3284         Introduce PLATFORM(IOSMAC)
3285         https://bugs.webkit.org/show_bug.cgi?id=187315
3286
3287         Reviewed by Dan Bernstein.
3288
3289         * Configurations/Base.xcconfig:
3290         * Configurations/FeatureDefines.xcconfig:
3291
3292 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3293
3294         [iOS] DataTransfer.getData always returns the empty string when dropping text
3295         https://bugs.webkit.org/show_bug.cgi?id=187130
3296         <rdar://problem/41014117>
3297
3298         Reviewed by Ryosuke Niwa.
3299
3300         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3301
3302         * WebCoreSupport/WebPlatformStrategies.h:
3303         * WebCoreSupport/WebPlatformStrategies.mm:
3304         (WebPlatformStrategies::allPasteboardItemInfo):
3305
3306 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3307
3308         [Mac] AirPlay picker uses incorrect theme in Dark mode
3309         https://bugs.webkit.org/show_bug.cgi?id=187054
3310         <rdar://problem/41291093>
3311
3312         Reviewed by Timothy Hatcher.
3313
3314         * WebView/WebMediaPlaybackTargetPicker.mm:
3315         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3316
3317 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3318
3319         [WTF] Add user-defined literal for ASCIILiteral
3320         https://bugs.webkit.org/show_bug.cgi?id=186839
3321
3322         Reviewed by Darin Adler.
3323
3324         * DOM/ExceptionHandlers.mm:
3325         (raiseDOMErrorException):
3326         * Plugins/Hosted/ProxyInstance.mm:
3327         (WebKit::ProxyInstance::invokeMethod):
3328         * Storage/WebDatabaseProvider.mm:
3329         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3330
3331 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3332
3333         Recalc styles every time defaultAppearance changes.
3334         https://bugs.webkit.org/show_bug.cgi?id=186866
3335         rdar://problem/41309805
3336
3337         Reviewed by Tim Horton.
3338
3339         * WebView/WebView.mm:
3340         (-[WebView _updateDefaultAppearance]):
3341         (-[WebView _setUseSystemAppearance:]):
3342         (-[WebView _useSystemAppearance]):
3343
3344 2018-06-20  Darin Adler  <darin@apple.com>
3345
3346         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3347         https://bugs.webkit.org/show_bug.cgi?id=186875
3348
3349         Reviewed by Anders Carlsson.
3350
3351         * WebView/WebHTMLView.mm:
3352         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3353         to write te file to.
3354         * WebView/WebPreferences.mm:
3355         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3356         * WebView/WebView.mm:
3357         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3358
3359 2018-06-12  Darin Adler  <darin@apple.com>
3360
3361         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3362         https://bugs.webkit.org/show_bug.cgi?id=186526
3363
3364         Reviewed by Anders Carlsson.
3365
3366         * Plugins/Hosted/NetscapePluginHostManager.mm:
3367         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3368
3369         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3370         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3371         assignment rather than adoptNS/leakRef.
3372         * Plugins/WebNetscapePluginView.mm:
3373         (-[WebNetscapePluginView createPlugin]): Ditto.
3374
3375         * WebCoreSupport/WebContextMenuClient.mm:
3376         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3377         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3378         argument, so use RetainPtr::get instead.
3379
3380         * WebView/WebHTMLView.mm:
3381         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3382         No need to autorelease the result when the return type is RetainPtr.
3383
3384         * WebView/WebPDFRepresentation.mm:
3385         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3386
3387 2018-06-13  Youenn Fablet  <youenn@apple.com>
3388
3389         Supported plugin check should be based on plugin identifier
3390         https://bugs.webkit.org/show_bug.cgi?id=186578
3391         <rdar://problem/40523828>
3392
3393         Reviewed by Darin Adler.
3394
3395         * WebCoreSupport/WebPluginInfoProvider.h:
3396         * WebCoreSupport/WebPluginInfoProvider.mm:
3397         (WebPluginInfoProvider::pluginInfo):
3398         (WebPluginInfoProvider::webVisiblePluginInfo):
3399
3400 2018-06-13  Chris Dumez  <cdumez@apple.com>
3401
3402         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3403         https://bugs.webkit.org/show_bug.cgi?id=186545
3404
3405         Reviewed by Brady Eidson.
3406
3407         Update client delegate now that parameter type has changed.
3408
3409         * WebCoreSupport/WebFrameLoaderClient.h:
3410         * WebCoreSupport/WebFrameLoaderClient.mm:
3411         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3412
3413 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3414
3415         Link drag image is inconsistently unreadable in dark mode
3416         https://bugs.webkit.org/show_bug.cgi?id=186472
3417
3418         Reviewed by Timothy Hatcher.
3419
3420         * WebView/WebView.mm:
3421         (-[WebView _defaultAppearance]):
3422         Make defaultAppearance accurate even if useSystemAppearance is false.
3423         Some parts of WebKit (like the link drag image, but also context menus)
3424         want to be able to follow the system appearance regardless of whether
3425         the view or content has opted in.
3426
3427 2018-06-11  Chris Dumez  <cdumez@apple.com>
3428
3429         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3430         https://bugs.webkit.org/show_bug.cgi?id=186441
3431
3432         Reviewed by Brady Eidson.
3433
3434         Rename existing flag to something a bit more generic, now that it is used for
3435         more things than bypassing the navigation policy check.
3436
3437         * WebView/WebView.mm:
3438         (-[WebView _loadBackForwardListFromOtherView:]):
3439         (-[WebView goToBackForwardItem:]):
3440
3441 2018-06-09  Dan Bernstein  <mitz@apple.com>
3442
3443         [Xcode] Clean up and modernize some build setting definitions
3444         https://bugs.webkit.org/show_bug.cgi?id=186463
3445
3446         Reviewed by Sam Weinig.
3447
3448         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3449         * Configurations/DebugRelease.xcconfig: Ditto.
3450         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3451           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3452         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3453         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3454           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3455         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3456
3457 2018-06-08  Darin Adler  <darin@apple.com>
3458
3459         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3460         https://bugs.webkit.org/show_bug.cgi?id=186436
3461
3462         Reviewed by Anders Carlsson.
3463
3464         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3465         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3466         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3467         (PoolCleaner): Ditto.
3468
3469         * History/WebHistory.mm:
3470         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3471         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3472         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3473         now hardly used if at all.
3474         * WebView/WebView.mm:
3475         (-[WebView rectsForTextMatches]): Ditto.
3476
3477 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3480         https://bugs.webkit.org/show_bug.cgi?id=186442
3481         <rdar://problem/40879364>
3482
3483         Reviewed by Tim Horton.
3484
3485         * Configurations/FeatureDefines.xcconfig:
3486
3487 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3488
3489         [Datalist] Allow TextFieldInputType to show and hide suggestions
3490         https://bugs.webkit.org/show_bug.cgi?id=186151
3491
3492         Reviewed by Tim Horton.
3493
3494         * WebCoreSupport/WebChromeClient.h:
3495         * WebCoreSupport/WebChromeClient.mm:
3496         (WebChromeClient::createDataListSuggestionPicker):
3497
3498 2018-06-07  Chris Dumez  <cdumez@apple.com>
3499
3500         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3501         https://bugs.webkit.org/show_bug.cgi?id=186407
3502
3503         Reviewed by Brent Fulgham.
3504
3505         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3506         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3507         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3508         makeWeakPtr().
3509
3510         * WebCoreSupport/WebEditorClient.h:
3511         * WebCoreSupport/WebEditorClient.mm:
3512         (WebEditorClient::requestCandidatesForSelection):
3513
3514 2018-06-05  Chris Dumez  <cdumez@apple.com>
3515
3516         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3517         https://bugs.webkit.org/show_bug.cgi?id=186331
3518         <rdar://problem/40735446>
3519
3520         Reviewed by Darin Adler.
3521
3522         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3523         but does not call use / ignore on the listener, then we would do "use" by default.
3524         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3525         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3526         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3527         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3528         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3529         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3530         and Box.app is still working properly.
3531
3532         * WebCoreSupport/WebFrameLoaderClient.h:
3533         * WebCoreSupport/WebFrameLoaderClient.mm:
3534         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3535         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3536         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3537         (WebFrameLoaderClient::dispatchWillSubmitForm):
3538         (WebFrameLoaderClient::setUpPolicyListener):
3539         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3540         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3541         (-[WebFramePolicyListener dealloc]):
3542         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3543         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3544
3545 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3546
3547         Adjust compile and runtime flags to match shippable state of features
3548         https://bugs.webkit.org/show_bug.cgi?id=186319
3549         <rdar://problem/40352045>
3550
3551         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3552
3553         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3554         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3555         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3556         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3557         Cocoa builds.
3558
3559 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3560
3561         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=186323
3564         rdar://problem/38382252
3565
3566         Reviewed by Tim Horton.
3567
3568         * WebView/WebView.mm:
3569         (-[WebView _defaultAppearance]):
3570
3571 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3572
3573         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3574         https://bugs.webkit.org/show_bug.cgi?id=186286
3575         <rdar://problem/40782992>
3576
3577         Reviewed by Dan Bernstein.
3578
3579         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3580         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3581         change this flag when preparing for a production release.
3582
3583         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3584         whether experimental features should be enabled, and use it to properly define the
3585         feature flag.
3586
3587 2018-06-03  Darin Adler  <darin@apple.com>
3588
3589         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3590         https://bugs.webkit.org/show_bug.cgi?id=186258
3591
3592         Reviewed by Daniel Bates.
3593
3594         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3595         forward declarations. Removed methods that don't need to be public.
3596
3597         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3598         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3599         unnamed category in here and also replaced the HUDWindowControllerDelegate
3600         with the unnamed category. Removed unused NSWindow category defining the
3601         isOnActiveSpace, which is not called anywhere in this file at this time.
3602         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3603         into setVideoElement.
3604         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3605         and removed unneeded typecast.
3606         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3607         using statement at the top of the file.
3608         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3609         the many side effects and special considerations that this method that sounds
3610         like a setter has. Updated code to use the new
3611         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3612         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3613         bit and added some FIXME comments about small problems noticed but not fixed.
3614         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3615         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3616         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3617         typecast. Removed call to updatePowerAssertions method.
3618         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3619         updatePowerAssertions method.
3620         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3621         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3622         else, so this was dead code that did nothing.
3623         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3624         updatePowerAssertions method.
3625
3626 2018-06-04  Chris Dumez  <cdumez@apple.com>
3627
3628         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3629         https://bugs.webkit.org/show_bug.cgi?id=186287
3630         <rdar://problem/40783352>
3631
3632         Reviewed by Youenn Fablet.
3633
3634         * WebView/WebPreferenceKeysPrivate.h:
3635         * WebView/WebPreferences.mm:
3636         (+[WebPreferences initialize]):
3637         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3638         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3639         * WebView/WebPreferencesPrivate.h:
3640         * WebView/WebView.mm:
3641         (-[WebView _preferencesChanged:]):
3642
3643 2018-06-02  Darin Adler  <darin@apple.com>
3644
3645         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3646         https://bugs.webkit.org/show_bug.cgi?id=186227
3647
3648         Reviewed by Dan Bernstein.
3649
3650         * Misc/WebKitErrors.m:
3651         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3652         * Plugins/WebPluginDatabase.mm:
3653         (-[WebPluginDatabase refresh]): Ditto.
3654         * WebCoreSupport/WebChromeClient.mm:
3655         (WebChromeClient::setStatusbarText): Ditto.
3656
3657 2018-06-01  Chris Dumez  <cdumez@apple.com>
3658
3659         REGRESSION (r231456): Colloquy is broken
3660         https://bugs.webkit.org/show_bug.cgi?id=186197
3661         <rdar://problem/40722960>
3662
3663         Reviewed by Timothy Hatcher.
3664
3665         Restore pre-r231456 behavior for Colloquy app so that it works again.
3666
3667         * WebView/WebView.mm:
3668         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3669         (-[WebView _preferencesChanged:]):
3670
3671 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3672
3673         [JSC] Pass VM& parameter as much as possible
3674         https://bugs.webkit.org/show_bug.cgi?id=186085
3675
3676         Reviewed by Saam Barati.
3677
3678         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3679         (WebKit::NetscapePluginInstanceProxy::invoke):
3680
3681 2018-05-30  Daniel Bates  <dabates@apple.com>
3682
3683         NavigationAction does not need to hold initiating DOM Event
3684         https://bugs.webkit.org/show_bug.cgi?id=185958
3685         <rdar://problem/40531539>
3686
3687         Reviewed by Simon Fraser.
3688
3689         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3690
3691         * WebCoreSupport/WebFrameLoaderClient.mm:
3692         (WebFrameLoaderClient::actionDictionary const):
3693         (findMouseEvent): Deleted.
3694
3695 2018-05-27  Dan Bernstein  <mitz@apple.com>
3696
3697         Reverted the changes made for https://webkit.org/b/186016
3698
3699         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3700
3701
3702 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3703
3704         [iOS] Fix warnings about leaks found by clang static analyzer
3705         <https://webkit.org/b/186009>
3706         <rdar://problem/40574267>
3707
3708         Reviewed by Daniel Bates.
3709
3710         * WebView/WebHTMLView.mm:
3711         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3712         uninitialized boolean variable (`eventWasHandled`) that only
3713         happened on iOS.
3714
3715 2018-05-27  Dan Bernstein  <mitz@apple.com>
3716
3717         [Cocoa] Avoid importing directly from subumbrella frameworks
3718         https://bugs.webkit.org/show_bug.cgi?id=186016
3719
3720         Reviewed by Sam Weinig.
3721
3722         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3723         * Carbon/CarbonWindowAdapter.mm: Ditto.
3724         * Carbon/CarbonWindowFrame.m: Ditto.
3725         * Carbon/HIViewAdapter.h: Ditto.
3726         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3727           OTHER_CPLUSPLUSFLAGS.
3728         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3729         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3730         * WebView/WebPDFView.h: Ditto.
3731
3732 2018-05-27  Sam Weinig  <sam@webkit.org>
3733
3734         Modernize RenderStyleConstants.h - Part 3
3735         https://bugs.webkit.org/show_bug.cgi?id=186015
3736
3737         Reviewed by Yusuke Suzuki.
3738
3739         * WebView/WebView.mm:
3740         (-[WebView updateTextTouchBar]):
3741         Update for new enum name.
3742
3743 2018-05-25  Chris Dumez  <cdumez@apple.com>
3744
3745         Minor ApplicationCacheStorage clean up
3746         https://bugs.webkit.org/show_bug.cgi?id=185984
3747
3748         Reviewed by Youenn Fablet.
3749
3750         * WebCoreSupport/WebApplicationCache.mm:
3751         (+[WebApplicationCache originsWithCache]):
3752
3753 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3754
3755         Fix issues with -dealloc methods found by clang static analyzer
3756         <https://webkit.org/b/185887>
3757
3758         Reviewed by Joseph Pecoraro.
3759
3760         * WebView/WebView.mm:
3761         (-[WebUITextIndicatorData dealloc]):
3762         - Move method implementation from (WebUITextIndicatorInternal)
3763           category to the main category since this is public API.  This
3764           fixes the false positive warning about a missing -dealloc
3765           method.
3766
3767 2018-05-24  Sam Weinig  <sam@webkit.org>
3768
3769         Modernize RenderStyleConstants.h - Part 2
3770         https://bugs.webkit.org/show_bug.cgi?id=185901
3771
3772         Reviewed by Simon Fraser.
3773
3774         * WebView/WebHTMLRepresentation.mm:
3775         (searchForLabelsBeforeElement):
3776         * WebView/WebView.mm:
3777         (nsTextAlignmentFromRenderStyle):
3778         Update for new enum names.
3779
3780 2018-05-22  Chris Dumez  <cdumez@apple.com>
3781
3782         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3783         https://bugs.webkit.org/show_bug.cgi?id=185832
3784         <rdar://problem/40307871>
3785
3786         Reviewed by Geoffrey Garen.
3787
3788         We used to have a bug where where we would fail to wait for the policy decision for
3789         the navigation response from the client and the load would keep going, racing with
3790         the client's policy decision. If the client did not respond in time, the behavior
3791         would be the same as "Use" policy action.
3792
3793         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3794         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3795         WebKit bug, however, the load would hang because the completion handler for the
3796         decidePolicyForNavigationResponse would never get called.
3797
3798         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3799         instead of retaining it. If the policy listener object gets destroyed because getting
3800         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3801         behavior.
3802
3803         * WebCoreSupport/WebFrameLoaderClient.h:
3804         * WebCoreSupport/WebFrameLoaderClient.mm:
3805         (WebFrameLoaderClient::cancelPolicyCheck):
3806         (WebFrameLoaderClient::setUpPolicyListener):
3807         (-[WebFramePolicyListener dealloc]):
3808
3809 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3810
3811         Unreviewed, rolling out r232052.
3812
3813         Breaks internal builds.
3814
3815         Reverted changeset:
3816
3817         "Use more C++17"
3818         https://bugs.webkit.org/show_bug.cgi?id=185176
3819         https://trac.webkit.org/changeset/232052
3820
3821 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3822
3823         Use more C++17
3824         https://bugs.webkit.org/show_bug.cgi?id=185176
3825
3826         Reviewed by JF Bastien.
3827
3828         * Configurations/Base.xcconfig:
3829         * Configurations/WebKitLegacy.xcconfig:
3830
3831 2018-05-21  Chris Nardi  <cnardi@chromium.org>
3832
3833         Remove dead exception in MediaList.appendMedium
3834         https://bugs.webkit.org/show_bug.cgi?id=185278
3835
3836         Reviewed by Chris Dumez.
3837
3838         Remove code pertaining to an exception being thrown by appendMedium().
3839
3840         * DOM/DOMMediaList.mm:
3841         (-[DOMMediaList appendMedium:]):
3842
3843 2018-05-21  Jer Noble  <jer.noble@apple.com>
3844
3845         Complete fix for enabling modern EME by default
3846         https://bugs.webkit.org/show_bug.cgi?id=185770
3847         <rdar://problem/40368220>
3848
3849         Reviewed by Eric Carlson.
3850
3851         * Configurations/FeatureDefines.xcconfig:
3852
3853 2018-05-21  Antti Koivisto  <antti@apple.com>
3854
3855         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3856         https://bugs.webkit.org/show_bug.cgi?id=185815
3857         <rdar://problem/40310069>
3858
3859         Reviewed by Simon Fraser.
3860
3861         User stylesheet parsing may depend on the colorFilterEnabled preference.
3862
3863         * WebView/WebView.mm:
3864         (-[WebView _preferencesChanged:]):
3865
3866 2018-05-18  Commit Queue  <commit-queue@webkit.org>
3867
3868         Unreviewed, rolling out r231982.
3869         https://bugs.webkit.org/show_bug.cgi?id=185793
3870
3871         Caused layout test failures (Requested by realdawei on
3872         #webkit).
3873
3874         Reverted changeset:
3875
3876         "Complete fix for enabling modern EME by default"
3877         https://bugs.webkit.org/show_bug.cgi?id=185770
3878         https://trac.webkit.org/changeset/231982
3879
3880 2018-05-18  Jer Noble  <jer.noble@apple.com>
3881
3882         Complete fix for enabling modern EME by default
3883         https://bugs.webkit.org/show_bug.cgi?id=185770
3884         <rdar://problem/40368220>
3885
3886         Reviewed by Eric Carlson.
3887
3888         * Configurations/FeatureDefines.xcconfig:
3889
3890 2018-05-18  Chris Dumez  <cdumez@apple.com>
3891
3892         Avoid keeping the frame alive when ref'ing a WindowProxy
3893         https://bugs.webkit.org/show_bug.cgi?id=185737
3894         <rdar://problem/40004666>
3895
3896         Reviewed by Sam Weinig.
3897
3898         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3899         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3900
3901 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3902
3903         Add support for Intl NumberFormat formatToParts
3904         https://bugs.webkit.org/show_bug.cgi?id=185375
3905
3906         Reviewed by Yusuke Suzuki.
3907
3908         Add flag for NumberFormat formatToParts.
3909
3910         * Configurations/FeatureDefines.xcconfig:
3911
3912 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3913
3914         Fixup after r231849: Do not mark Mac API methods as deprecated
3915         https://bugs.webkit.org/show_bug.cgi?id=185684
3916
3917         Reviewed by Darin Adler.
3918
3919         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3920         as the entire class is already marked as deprecated, so it is unnecessary.
3921
3922         * DOM/DOMDocument.h:
3923
3924 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3925
3926         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3927         https://bugs.webkit.org/show_bug.cgi?id=185381
3928
3929         Reviewed by Darin Adler.
3930
3931         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3932         and make them do nothing.
3933
3934         * DOM/DOMDocument.h:
3935         * DOM/DOMDocument.mm:
3936         (-[DOMDocument preferredStylesheetSet]):
3937         (-[DOMDocument selectedStylesheetSet]):
3938         (-[DOMDocument setSelectedStylesheetSet:]):
3939
3940 2018-05-15  Antoine Quint  <graouts@apple.com>
3941
3942         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3943         https://bugs.webkit.org/show_bug.cgi?id=185647
3944
3945         Reviewed by Dean Jackson.
3946
3947         Rename the Web Animations CSS integration flag.
3948
3949         * WebView/WebPreferenceKeysPrivate.h:
3950         * WebView/WebPreferences.mm:
3951         (+[WebPreferences initialize]):
3952         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3953         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3954         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3955         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3956         * WebView/WebPreferencesPrivate.h:
3957         * WebView/WebView.mm:
3958         (-[WebView _preferencesChanged:]):
3959
3960 2018-05-14  Daniel Bates  <dabates@apple.com>
3961
3962         Fix the Apple Internal build
3963
3964         See <rdar://problem/40237873> for more details.
3965
3966         * WebView/WebFullScreenController.mm:
3967         (-[WebFullScreenController enterFullScreen:]):
3968         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3969         (-[WebFullScreenController exitFullScreen]):
3970         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3971         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3972         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3973
3974 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3975
3976         WebHTMLView is not setting aside subviews when drawing.
3977
3978         https://bugs.webkit.org/show_bug.cgi?id=185561
3979         rdar://problem/40172894
3980
3981         Reviewed by Simon Fraser.
3982
3983         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3984
3985         * WebView/WebHTMLView.mm:
3986         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3987
3988 2018-05-07  Daniel Bates  <dabates@apple.com>
3989
3990         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3991         https://bugs.webkit.org/show_bug.cgi?id=185170
3992
3993         Reviewed by Per Arne Vollan.
3994
3995         * Misc/WebCache.mm:
3996         (+[WebCache empty]):
3997
3998 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3999
4000         Deprecate legacy WebView and friends
4001         https://bugs.webkit.org/show_bug.cgi?id=185279
4002         rdar://problem/33268700
4003
4004         Reviewed by Tim Horton.
4005
4006         Added deprecation macros to all the classes, extern strings, and enums.
4007
4008         * Configurations/WebKitLegacy.xcconfig:
4009         Added BUILDING_WEBKIT define to disable the deprecation macros.
4010         * DOM/DOMAbstractView.h:
4011         * DOM/DOMAttr.h:
4012         * DOM/DOMBlob.h:
4013         * DOM/DOMCDATASection.h:
4014         * DOM/DOMCSSCharsetRule.h:
4015         * DOM/DOMCSSFontFaceRule.h:
4016         * DOM/DOMCSSImportRule.h:
4017         * DOM/DOMCSSMediaRule.h:
4018         * DOM/DOMCSSPageRule.h:
4019         * DOM/DOMCSSPrimitiveValue.h:
4020         * DOM/DOMCSSRule.h:
4021         * DOM/DOMCSSRuleList.h:
4022         * DOM/DOMCSSStyleDeclaration.h:
4023         * DOM/DOMCSSStyleRule.h:
4024         * DOM/DOMCSSStyleSheet.h:
4025         * DOM/DOMCSSUnknownRule.h:
4026         * DOM/DOMCSSValue.h:
4027         * DOM/DOMCSSValueList.h:
4028         * DOM/DOMCharacterData.h:
4029         * DOM/DOMComment.h:
4030         * DOM/DOMCounter.h:
4031         * DOM/DOMDocument.h:
4032         * DOM/DOMDocumentFragment.h:
4033         * DOM/DOMDocumentType.h:
4034         * DOM/DOMElement.h:
4035         * DOM/DOMEntity.h:
4036         * DOM/DOMEntityReference.h:
4037         * DOM/DOMEvent.h:
4038         * DOM/DOMEventException.h:
4039         * DOM/DOMEventListener.h:
4040         * DOM/DOMEventTarget.h:
4041         * DOM/DOMException.h:
4042         * DOM/DOMFile.h:
4043         * DOM/DOMFileList.h:
4044         * DOM/DOMHTMLAnchorElement.h:
4045         * DOM/DOMHTMLAppletElement.h:
4046         * DOM/DOMHTMLAreaElement.h:
4047         * DOM/DOMHTMLBRElement.h:
4048         * DOM/DOMHTMLBaseElement.h:
4049         * DOM/DOMHTMLBaseFontElement.h:
4050         * DOM/DOMHTMLBodyElement.h:
4051         * DOM/DOMHTMLButtonElement.h:
4052         * DOM/DOMHTMLCanvasElement.h:
4053         * DOM/DOMHTMLCollection.h:
4054         * DOM/DOMHTMLDListElement.h:
4055         * DOM/DOMHTMLDirectoryElement.h:
4056         * DOM/DOMHTMLDivElement.h:
4057         * DOM/DOMHTMLDocument.h:
4058         * DOM/DOMHTMLElement.h:
4059         * DOM/DOMHTMLEmbedElement.h:
4060         * DOM/DOMHTMLFieldSetElement.h:
4061         * DOM/DOMHTMLFontElement.h:
4062         * DOM/DOMHTMLFormElement.h:
4063         * DOM/DOMHTMLFrameElement.h:
4064         * DOM/DOMHTMLFrameSetElement.h:
4065         * DOM/DOMHTMLHRElement.h:
4066         * DOM/DOMHTMLHeadElement.h:
4067         * DOM/DOMHTMLHeadingElement.h:
4068         * DOM/DOMHTMLHtmlElement.h:
4069         * DOM/DOMHTMLIFrameElement.h: