db3e2aef0df74b9a841f7ffa41aa2c8fe11718c7
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-09-17  Chris Dumez  <cdumez@apple.com>
2
3         Stop calling Page::setSessionID() from WebKit2
4         https://bugs.webkit.org/show_bug.cgi?id=201888
5
6         Reviewed by Alex Christensen.
7
8         Stop calling Page::setSessionID() from WebKit2 since Page's sessionID can never change when
9         using WebKit2 (We process-swap and create a new Page in a new process when changing data
10         store). Instead, we now pass the sessionID ID when constructing the Page, as part of the
11         PageConfiguration structure.
12
13         * WebView/WebView.mm:
14         (-[WebView _commonInitializationWithFrameName:groupName:]):
15
16 2019-09-09  Alex Christensen  <achristensen@webkit.org>
17
18         Disable TLS 1.0 and 1.1 in WebSockets
19         https://bugs.webkit.org/show_bug.cgi?id=201573
20
21         Reviewed by Youenn Fablet.
22
23         * WebView/WebView.mm:
24         (-[WebView _commonInitializationWithFrameName:groupName:]):
25
26 2019-09-06  Alex Christensen  <achristensen@webkit.org>
27
28         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
29         https://bugs.webkit.org/show_bug.cgi?id=201480
30
31         Reviewed by Youenn Fablet.
32
33         * WebView/WebView.mm:
34         (-[WebView _preferencesChanged:]):
35
36 2019-09-06  Rob Buis  <rbuis@igalia.com>
37
38         Add runtime flag for lazy image loading
39         https://bugs.webkit.org/show_bug.cgi?id=199794
40
41         Reviewed by Frédéric Wang.
42
43         Remove parts of r248409 that were meant for WK1 since
44         lazy image loading is WK2 only.
45
46         * WebView/WebPreferenceKeysPrivate.h:
47         * WebView/WebPreferences.mm:
48         (+[WebPreferences initialize]):
49         (-[WebPreferences lazyImageLoadingEnabled]): Deleted.
50         (-[WebPreferences setLazyImageLoadingEnabled:]): Deleted.
51         * WebView/WebPreferencesPrivate.h:
52         * WebView/WebView.mm:
53         (-[WebView _preferencesChanged:]):
54
55 2019-09-04  Alex Christensen  <achristensen@webkit.org>
56
57         Remove unused SPI that accesses MemoryCache directly
58         https://bugs.webkit.org/show_bug.cgi?id=201468
59
60         Reviewed by Tim Horton.
61
62         * Misc/WebCache.h:
63         * Misc/WebCache.mm:
64         (+[WebCache addImageToCache:forURL:]): Deleted.
65         (+[WebCache addImageToCache:forURL:forFrame:]): Deleted.
66         (+[WebCache removeImageFromCacheForURL:]): Deleted.
67         (+[WebCache removeImageFromCacheForURL:forFrame:]): Deleted.
68
69 2019-08-30  Keith Rollin  <krollin@apple.com>
70
71         Remove AppKitCompatibilityDeclarations.h
72         https://bugs.webkit.org/show_bug.cgi?id=201283
73         <rdar://problem/54822042>
74
75         Reviewed by Alexey Proskuryakov.
76
77         The two copies of these files -- on in WTF, one in MiniBrowser -- are
78         empty and can be removed.
79
80         * Misc/WebNSEventExtras.m:
81         * Misc/WebNSViewExtras.m:
82         * WebKitPrefix.h:
83
84 2019-08-30  Keith Rollin  <krollin@apple.com>
85
86         Remove extra braces
87         https://bugs.webkit.org/show_bug.cgi?id=201285
88
89         Reviewed by Alexey Proskuryakov.
90
91         Some code evolved such that there was only a single statement under an
92         'if' statement. The braces surrounding the single-line block can now
93         be removed.
94
95         * WebView/WebView.mm:
96         (-[WebView updateMediaTouchBar]):
97
98 2019-08-29  Keith Rollin  <krollin@apple.com>
99
100         Update .xcconfig symbols to reflect the current set of past and future product versions.
101         https://bugs.webkit.org/show_bug.cgi?id=200720
102         <rdar://problem/54305032>
103
104         Reviewed by Alex Christensen.
105
106         Remove version symbols related to old OS's we no longer support,
107         ensure that version symbols are defined for OS's we do support.
108
109         * Configurations/Base.xcconfig:
110         * Configurations/DebugRelease.xcconfig:
111         * Configurations/Version.xcconfig:
112
113 2019-08-29  Keith Rollin  <krollin@apple.com>
114
115         Remove support for macOS < 10.13 (part 3)
116         https://bugs.webkit.org/show_bug.cgi?id=201224
117         <rdar://problem/54795934>
118
119         Reviewed by Darin Adler.
120
121         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
122         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
123         like _MACOS_SINCE_1013.
124
125         * Configurations/WebKitTargetConditionals.xcconfig:
126
127 2019-08-29  Dean Jackson  <dino@apple.com>
128
129         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
130         https://bugs.webkit.org/show_bug.cgi?id=201200
131
132         Reverting r249211 after Dan Bernstein pointed out it will cause
133         an error with the public iOS 13 SDK.
134
135         * Misc/WebDownload.h:
136
137 2019-08-28  Dean Jackson  <dino@apple.com>
138
139         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
140         https://bugs.webkit.org/show_bug.cgi?id=201200
141
142         Reviewed by Simon Fraser.
143
144         We want to include Foundation/NSURLDownload.h if we're on
145         a newer iOS.
146
147         * Misc/WebDownload.h:
148
149 2019-08-28  Keith Rollin  <krollin@apple.com>
150
151         Remove support for macOS < 10.13 (part 2)
152         https://bugs.webkit.org/show_bug.cgi?id=201197
153         <rdar://problem/54759985>
154
155         Reviewed by Darin Adler.
156
157         Update conditionals that reference WK_MACOS_1013 and suffixes like
158         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
159         later and that these conditionals are always True or False.
160
161         See Bug 200694 for earlier changes in this area.
162
163         * Configurations/FeatureDefines.xcconfig:
164
165 2019-08-27  Mark Lam  <mark.lam@apple.com>
166
167         Refactor to use VM& instead of VM* at as many places as possible.
168         https://bugs.webkit.org/show_bug.cgi?id=201172
169
170         Reviewed by Yusuke Suzuki.
171
172         * DOM/DOM.mm:
173         (+[DOMNode _nodeFromJSWrapper:]):
174         * DOM/DOMUtility.mm:
175         (createDOMWrapper):
176         * Plugins/Hosted/NetscapePluginHostProxy.mm:
177         (identifierFromIdentifierRep):
178         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
179         (WebKit::NetscapePluginInstanceProxy::enumerate):
180         (WebKit::getObjectID):
181         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
182         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
183         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
184         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
185         * Plugins/Hosted/ProxyInstance.mm:
186         (WebKit::ProxyInstance::stringValue const):
187         (WebKit::ProxyInstance::getPropertyNames):
188         * WebView/WebFrame.mm:
189         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
190
191 2019-08-23  Chris Dumez  <cdumez@apple.com>
192
193         [geolocation] Rename interfaces and remove [NoInterfaceObject]
194         https://bugs.webkit.org/show_bug.cgi?id=200885
195
196         Reviewed by Alex Christensen.
197
198         * WebCoreSupport/WebGeolocationClient.h:
199         * WebCoreSupport/WebGeolocationClient.mm:
200         (WebGeolocationClient::lastPosition):
201         * WebView/WebGeolocationPosition.mm:
202         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
203         (core):
204         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
205         (-[WebGeolocationPosition initWithGeolocationPosition:]):
206         * WebView/WebGeolocationPositionInternal.h:
207
208 2019-08-22  Andy Estes  <aestes@apple.com>
209
210         [watchOS] Disable Content Filtering in the simulator build
211         https://bugs.webkit.org/show_bug.cgi?id=201047
212
213         Reviewed by Tim Horton.
214
215         * Configurations/FeatureDefines.xcconfig:
216
217 2019-08-21  Tim Horton  <timothy_horton@apple.com>
218
219         [Mail] Tapping top of message scrolls back to copied text instead of top of the message
220         https://bugs.webkit.org/show_bug.cgi?id=200999
221         <rdar://problem/54564878>
222
223         Reviewed by Wenson Hsieh.
224
225         * WebCoreSupport/WebEditorClient.h:
226         * WebCoreSupport/WebEditorClient.mm:
227         (WebEditorClient::shouldAllowSingleClickToChangeSelection const):
228         Copy the existing behavior from EventHandler.
229         We do not fix the bug in WebKitLegacy for a multitude of reasons, primarily
230         because we do not know of any user impact.
231
232 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
233
234         Put keygen element behind a runtime flag and disable it by default
235         https://bugs.webkit.org/show_bug.cgi?id=200850
236
237         Reviewed by Antti Koivisto.
238
239         * WebView/WebPreferenceKeysPrivate.h:
240         * WebView/WebPreferences.mm:
241         (-[WebPreferences keygenElementEnabled]):
242         (-[WebPreferences setKeygenElementEnabled:]):
243         * WebView/WebPreferencesPrivate.h:
244         * WebView/WebView.mm:
245         (-[WebView _preferencesChanged:]):
246
247 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
248
249         Remove IDB-specific quota
250         https://bugs.webkit.org/show_bug.cgi?id=196545
251         <rdar://problem/54201783>
252
253         Reviewed by Youenn Fablet.
254
255         * Storage/WebDatabaseManager.mm:
256         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
257         * Storage/WebDatabaseManagerPrivate.h:
258
259 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
260
261         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
262         https://bugs.webkit.org/show_bug.cgi?id=200620
263
264         Reviewed by Geoffrey Garen.
265
266         * History/WebHistory.mm:
267         (-[WebHistoryPrivate init]):
268         * History/WebHistoryItem.mm:
269         (-[WebHistoryItem initFromDictionaryRepresentation:]):
270         * Plugins/Hosted/NetscapePluginHostProxy.mm:
271         (WKPCGetScriptableNPObjectReply):
272         (WKPCBooleanReply):
273         (WKPCBooleanAndDataReply):
274         (WKPCInstantiatePluginReply):
275         * Plugins/Hosted/ProxyInstance.mm:
276         (WebKit::ProxyInstance::methodNamed):
277         (WebKit::ProxyInstance::fieldNamed):
278         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
279         (-[WebHostedNetscapePluginView createPlugin]):
280         * Plugins/WebNetscapePluginEventHandler.mm:
281         (WebNetscapePluginEventHandler::create):
282         * Plugins/WebNetscapePluginView.mm:
283         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
284         * Storage/WebDatabaseManagerClient.mm:
285         (DidModifyOriginData::dispatchToMainThread):
286         * WebCoreSupport/WebFrameLoaderClient.mm:
287         (addRedirectURL):
288         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
289         * WebCoreSupport/WebInspectorClient.mm:
290         (WebInspectorClient::openLocalFrontend):
291         * WebView/WebDeviceOrientationProviderMock.mm:
292         * WebView/WebFrame.mm:
293         (-[WebFrame _attachScriptDebugger]):
294         * WebView/WebMediaPlaybackTargetPicker.mm:
295         (WebMediaPlaybackTargetPicker::create):
296         * WebView/WebTextIterator.mm:
297         (-[WebTextIterator initWithRange:]):
298         * WebView/WebView.mm:
299         (-[WebView _injectOutlookQuirksScript]):
300         (-[WebView _commonInitializationWithFrameName:groupName:]):
301         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
302         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
303         (-[WebView _selectionServiceController]):
304         (-[WebView _setTextIndicator:withLifetime:]):
305         * WebView/WebViewData.mm:
306         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
307         (-[WebViewPrivate init]):
308
309 2019-08-17  Darin Adler  <darin@apple.com>
310
311         Tidy up checks to see if a character is in the Latin-1 range by using isLatin1 consistently
312         https://bugs.webkit.org/show_bug.cgi?id=200861
313
314         Reviewed by Ross Kirsling.
315
316         * Misc/WebKitNSStringExtras.mm:
317         (canUseFastRenderer): Use isLatin1.
318
319 2019-08-16  Chris Dumez  <cdumez@apple.com>
320
321         LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted
322         https://bugs.webkit.org/show_bug.cgi?id=200825
323
324         Reviewed by Alex Christensen.
325
326         * Misc/WebKitVersionChecks.h:
327         * Storage/WebStorageManager.mm:
328         (WebKitInitializeStorageIfNecessary):
329
330 2019-08-16  Ryosuke Niwa  <rniwa@webkit.org>
331
332         Split tabIndex computation for DOM and the rest of WebCore
333         https://bugs.webkit.org/show_bug.cgi?id=200806
334
335         Reviewed by Chris Dumez.
336
337         * DOM/DOMHTMLElement.mm:
338         (-[DOMHTMLElement tabIndex]):
339         (-[DOMHTMLElement setTabIndex:]):
340
341 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
342
343         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
344         https://bugs.webkit.org/show_bug.cgi?id=200620
345
346         Reviewed by Geoffrey Garen.
347
348         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
349         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
350         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
351         * Storage/WebDatabaseManagerClient.mm:
352         * WebCoreSupport/WebAlternativeTextClient.h:
353         * WebCoreSupport/WebCachedFramePlatformData.h:
354         * WebCoreSupport/WebChromeClient.h:
355         * WebCoreSupport/WebContextMenuClient.h:
356         * WebCoreSupport/WebDragClient.h:
357         * WebCoreSupport/WebEditorClient.h:
358         * WebCoreSupport/WebGeolocationClient.h:
359         * WebCoreSupport/WebInspectorClient.h:
360         * WebCoreSupport/WebNotificationClient.h:
361         * WebCoreSupport/WebSelectionServiceController.h:
362         * WebView/WebMediaPlaybackTargetPicker.h:
363
364 2019-08-15  Tim Horton  <timothy_horton@apple.com>
365
366         Yellow Lookup highlight gets stuck over Mail messages
367         https://bugs.webkit.org/show_bug.cgi?id=200778
368         <rdar://problem/53868514>
369
370         Reviewed by Wenson Hsieh.
371
372         * WebView/WebView.mm:
373         (-[WebView _showDictionaryLookupPopup:]):
374         Add a dismissal callback so that when Reveal hides the panel, it also
375         dismisses the yellow indicator. This matches the behavior in modern WebKit.
376
377 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
378
379         Some improvements on web storage
380         https://bugs.webkit.org/show_bug.cgi?id=200373
381
382         Reviewed by Geoffrey Garen.
383
384         * WebView/WebView.mm:
385         (-[WebView _preferencesChanged:]): notify storageNamespaceProvider about session change.
386
387 2019-08-15  Youenn Fablet  <youenn@apple.com>
388
389         Always create a Document with a valid SessionID
390         https://bugs.webkit.org/show_bug.cgi?id=200727
391
392         Reviewed by Alex Christensen.
393
394         Implement WebKit1 sessionID getter like done for WebKit2.
395         Either the loader client has a page in which case the page session ID is used
396         or the client has no page, in which case the default session ID is used.
397         This is the same behavior as CachedResourceLoader.
398
399         * WebCoreSupport/WebFrameLoaderClient.mm:
400         (WebFrameLoaderClient::sessionID const):
401
402 2019-08-15  Simon Fraser  <simon.fraser@apple.com>
403
404         Use ObjectIdentifier<FrameIdentifierType> for frameIDs
405         https://bugs.webkit.org/show_bug.cgi?id=199986
406
407         Reviewed by Ryosuke Niwa.
408
409         Use the strongly-typed FrameIdentifier instead of uint64_t as frame identifiers everywhere.
410
411         * WebCoreSupport/WebFrameLoaderClient.h:
412         * WebCoreSupport/WebFrameLoaderClient.mm:
413         (WebFrameLoaderClient::frameID const):
414
415 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
416
417         Unreviewed, rolling out r248526.
418
419         Caused two IndexedDB perf tests to fail
420
421         Reverted changeset:
422
423         "Remove IDB-specific quota"
424         https://bugs.webkit.org/show_bug.cgi?id=196545
425         https://trac.webkit.org/changeset/248526
426
427 2019-08-14  Keith Rollin  <krollin@apple.com>
428
429         Remove support for macOS < 10.13
430         https://bugs.webkit.org/show_bug.cgi?id=200694
431         <rdar://problem/54278851>
432
433         Reviewed by Youenn Fablet.
434
435         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
436         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
437         101300. This means that expressions like
438         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
439         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
440
441         * WebCoreSupport/WebEditorClient.mm:
442         * WebView/PDFViewSPI.h:
443         * WebView/WebHTMLView.mm:
444         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:]):
445         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:]):
446         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
447         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
448         * WebView/WebPreferences.mm:
449         (+[WebPreferences initialize]):
450         * WebView/WebView.mm:
451         (-[WebView performDragOperation:]):
452         (LayerFlushController::flushLayers):
453         (-[WebView updateMediaTouchBar]):
454         * WebView/WebViewData.h:
455
456 2019-08-14  Youenn Fablet  <youenn@apple.com>
457
458         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
459         https://bugs.webkit.org/show_bug.cgi?id=200671
460
461         Reviewed by ALex Christensen.
462
463         * WebCoreSupport/WebPlatformStrategies.mm:
464
465 2019-08-13  Youenn Fablet  <youenn@apple.com>
466
467         Blob registries should be keyed by session IDs
468         https://bugs.webkit.org/show_bug.cgi?id=200567
469
470         Reviewed by Alex Christensen.
471
472         * WebCoreSupport/WebPlatformStrategies.mm:
473         (WebPlatformStrategies::createBlobRegistry):
474         Ignore sessionID parameter for WK1.
475
476 2019-08-12  Chris Dumez  <cdumez@apple.com>
477
478         Add threading assertions to RefCounted
479         https://bugs.webkit.org/show_bug.cgi?id=200507
480
481         Reviewed by Ryosuke Niwa.
482
483         * WebView/WebView.mm:
484         (+[WebView initialize]):
485         Enable new RefCounted threading assertions for WebKitLegacy.
486
487 2019-08-12  Chris Dumez  <cdumez@apple.com>
488
489         Unreviewed, rolling out r248525.
490
491         Revert new threading assertions while I work on fixing the
492         issues they exposed
493
494         Reverted changeset:
495
496         "Add threading assertions to RefCounted"
497         https://bugs.webkit.org/show_bug.cgi?id=200507
498         https://trac.webkit.org/changeset/248525
499
500 2019-08-12  Youenn Fablet  <youenn@apple.com>
501
502         Remove IDB-specific quota
503         https://bugs.webkit.org/show_bug.cgi?id=196545
504
505         Reviewed by Alex Christensen.
506
507         * Storage/WebDatabaseManager.mm:
508         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
509         * Storage/WebDatabaseManagerPrivate.h:
510
511 2019-08-11  Chris Dumez  <cdumez@apple.com>
512
513         Add threading assertions to RefCounted
514         https://bugs.webkit.org/show_bug.cgi?id=200507
515
516         Reviewed by Ryosuke Niwa.
517
518         * WebView/WebView.mm:
519         (+[WebView initialize]):
520         Enable new RefCounted threading assertions for WebKitLegacy.
521
522 2019-08-10  Tim Horton  <timothy_horton@apple.com>
523
524         Remove some more unused 32-bit code
525         https://bugs.webkit.org/show_bug.cgi?id=200607
526
527         Reviewed by Alexey Proskuryakov.
528
529         * Configurations/WebKitLegacy.xcconfig:
530         * Misc/WebSharingServicePickerController.mm:
531         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
532         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
533         (-[WebSharingServicePickerController sharingService:didShareItems:]):
534         * Plugins/WebNetscapePluginEventHandler.mm:
535         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Removed.
536         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Removed.
537         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
538         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
539         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
540         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
541         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
542         (WebNetscapePluginEventHandlerCocoa::keyDown):
543         (WebNetscapePluginEventHandlerCocoa::focusChanged):
544         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
545         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
546         (WebNetscapePluginEventHandlerCocoa::TSMEventHandler): Deleted.
547         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): Deleted.
548         * WebCoreSupport/WebContextMenuClient.mm:
549         (WebContextMenuClient::contextMenuForEvent):
550         * WebView/WebHTMLView.mm:
551         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
552         (-[WebHTMLView pressureChangeWithEvent:]):
553         * WebView/WebView.mm:
554         (LayerFlushController::flushLayers):
555
556 2019-08-08  Rob Buis  <rbuis@igalia.com>
557
558         Add runtime flag for lazy image loading
559         https://bugs.webkit.org/show_bug.cgi?id=199794
560
561         Reviewed by Darin Adler.
562
563         Set lazyImageLoading runtime flag if preference is set.
564
565         * WebView/WebPreferenceKeysPrivate.h:
566         * WebView/WebPreferences.mm:
567         (+[WebPreferences initialize]):
568         (-[WebPreferences lazyImageLoadingEnabled]):
569         (-[WebPreferences setLazyImageLoadingEnabled:]):
570         * WebView/WebPreferencesPrivate.h:
571         * WebView/WebView.mm:
572         (-[WebView _preferencesChanged:]):
573
574 2019-08-07  Priyanka Agarwal  <pagarwal999@apple.com>
575
576         Allow clients to toggle a text input field between being viewable and having characters hidden while maintaining 
577         a yellow auto-filled appearance
578         https://bugs.webkit.org/show_bug.cgi?id=200037
579         rdar://problem/51900961
580
581         Reviewed by Daniel Bates.
582
583         * DOM/WebDOMOperations.mm:
584         (-[DOMHTMLInputElement _isAutoFilledAndViewable]):
585         (-[DOMHTMLInputElement _setAutoFilledAndViewable:]):
586         * DOM/WebDOMOperationsPrivate.h:
587
588 2019-08-02  Keith Rollin  <krollin@apple.com>
589
590         Consistently use Obj-C boolean literals
591         https://bugs.webkit.org/show_bug.cgi?id=200405
592         <rdar://problem/53880043>
593
594         Reviewed by Simon Fraser, Joseph Pecoraro.
595
596         There are places where we use equivalent but different expressions for
597         Obj-C boolean objects. For example, we use both [NSNumber
598         numberWithBool:YES] and @YES. There are places where both are used in
599         the same function, such as -[WebPreferences initialize]. The boolean
600         literal is in greater use and is more succinct, so standardize on
601         that. Also, change @(YES/NO) to @YES/NO.
602
603         * History/WebHistoryItem.mm:
604         * WebView/WebFrame.mm:
605         (-[WebFrame _cacheabilityDictionary]):
606         * WebView/WebPreferences.mm:
607         (+[WebPreferences initialize]):
608
609 2019-08-01  Alex Christensen  <achristensen@webkit.org>
610
611         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
612         https://bugs.webkit.org/show_bug.cgi?id=200102
613         <rdar://problem/53275114>
614
615         Reviewed by Darin Adler.
616
617         * DefaultDelegates/WebDefaultUIDelegate.mm:
618         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): Deleted.
619         (-[WebDefaultUIDelegate webView:generateReplacementFile:]): Deleted.
620         * WebCoreSupport/WebChromeClient.h:
621         * WebCoreSupport/WebChromeClient.mm:
622         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Deleted.
623         (WebChromeClient::generateReplacementFile): Deleted.
624         * WebView/WebUIDelegatePrivate.h:
625
626 2019-07-25  Dean Jackson  <dino@apple.com>
627
628         Add helper for ignoring deprecated implementation warnings
629         https://bugs.webkit.org/show_bug.cgi?id=200135
630
631         Reviewed by Wenson Hsieh.
632
633         Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
634         is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
635
636         * Misc/WebDownload.mm:
637         (-[WebDownload initWithRequest:delegate:]):
638         * Misc/WebIconDatabase.mm:
639         * Plugins/WebBaseNetscapePluginView.mm:
640         (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
641         (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.
642         * WebView/WebDynamicScrollBarsView.mm:
643         (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
644         (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.
645         * WebView/WebHTMLView.mm:
646         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
647         (-[WebHTMLView draggedImage:endedAt:operation:]):
648         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
649         (-[WebHTMLView accessibilityAttributeValue:]):
650         (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
651         (-[WebHTMLView characterIndexForPoint:]):
652         (-[WebHTMLView firstRectForCharacterRange:]):
653         (-[WebHTMLView attributedSubstringFromRange:]):
654         (-[WebHTMLView setMarkedText:selectedRange:]):
655         (-[WebHTMLView doCommandBySelector:]):
656         (-[WebHTMLView insertText:]):
657         (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.
658
659 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
660
661         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
662         https://bugs.webkit.org/show_bug.cgi?id=200021
663         <rdar://problem/53301325>
664
665         Reviewed by Ryosuke Niwa.
666
667         Implement a new editing client hook. In WebKit1, this always returns true on macOS and false on iOS.
668
669         * WebCoreSupport/WebEditorClient.h:
670
671 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
672
673         Fix WebView iframe rendering in macOS Catalina
674         https://bugs.webkit.org/show_bug.cgi?id=200022
675         rdar://problem/49102040
676
677         Reviewed by Darin Adler.
678
679         Adapt to internal NSView method renames in Catalina.
680
681         * WebView/WebHTMLView.mm:
682         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
683         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
684
685 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
686
687         Enable CSSOMViewScrollingAPIEnabled in WebKit1
688         https://bugs.webkit.org/show_bug.cgi?id=200008
689         rdar://problem/53409062
690
691         Reviewed by Tim Horton.
692
693         Default WebKitCSSOMViewScrollingAPIEnabledPreferenceKey to YES, so that 
694         CSSOMViewScrollingAPIEnabled is on for both WebKit1 and WebKit2.
695
696         DumpRenderTree already turns this preference on, so this change is not
697         detected by tests.
698
699         * WebView/WebPreferences.mm:
700         (+[WebPreferences initialize]):
701
702 2019-07-22  Youenn Fablet  <youenn@apple.com>
703
704         Disable MediaRecorder for legacy WebKit
705         https://bugs.webkit.org/show_bug.cgi?id=200001
706         <rdar://problem/53400030>
707
708         Reviewed by Eric Carlson.
709
710         Disable MediaRecorder by default in legacy WebKit.
711         Add SPI to set/get this preference.
712
713         * WebView/WebPreferences.mm:
714         (+[WebPreferences initialize]):
715         (-[WebPreferences _mediaRecorderEnabled]):
716         (-[WebPreferences _setMediaRecorderEnabled:]):
717         * WebView/WebPreferencesPrivate.h:
718
719 2019-07-18  Alex Christensen  <achristensen@webkit.org>
720
721         Unify builds in WebKitLegacy/mac/DOM
722         https://bugs.webkit.org/show_bug.cgi?id=199771
723
724         Reviewed by Geoffrey Garen.
725
726         * DOM/DOMAbstractView.mm:
727         * DOM/DOMAttr.mm:
728         * DOM/DOMBlob.mm:
729         * DOM/DOMCDATASection.mm:
730         * DOM/DOMCSSFontFaceRule.mm:
731         * DOM/DOMCSSImportRule.mm:
732         * DOM/DOMCSSMediaRule.mm:
733         * DOM/DOMCSSPageRule.mm:
734         * DOM/DOMCSSPrimitiveValue.mm:
735         * DOM/DOMCSSRule.mm:
736         * DOM/DOMCSSRuleList.mm:
737         * DOM/DOMCSSStyleDeclaration.mm:
738         * DOM/DOMCSSStyleRule.mm:
739         * DOM/DOMCSSStyleSheet.mm:
740         * DOM/DOMCSSUnknownRule.mm:
741         * DOM/DOMCSSValue.mm:
742         * DOM/DOMCSSValueList.mm:
743         * DOM/DOMCharacterData.mm:
744         * DOM/DOMComment.mm:
745         * DOM/DOMCounter.mm:
746         * DOM/DOMDocument.mm:
747         * DOM/DOMDocumentFragment.mm:
748         * DOM/DOMDocumentType.mm:
749         * DOM/DOMEvent.mm:
750         * DOM/DOMFile.mm:
751         * DOM/DOMFileList.mm:
752         * DOM/DOMHTMLAnchorElement.mm:
753         * DOM/DOMHTMLAppletElement.mm:
754         * DOM/DOMHTMLAreaElement.mm:
755         * DOM/DOMHTMLBRElement.mm:
756         * DOM/DOMHTMLBaseElement.mm:
757         * DOM/DOMHTMLBaseFontElement.mm:
758         * DOM/DOMHTMLBodyElement.mm:
759         * DOM/DOMHTMLButtonElement.mm:
760         * DOM/DOMHTMLCanvasElement.mm:
761         * DOM/DOMHTMLCollection.mm:
762         * DOM/DOMHTMLDListElement.mm:
763         * DOM/DOMHTMLDirectoryElement.mm:
764         * DOM/DOMHTMLDivElement.mm:
765         * DOM/DOMHTMLDocument.mm:
766         * DOM/DOMHTMLElement.mm:
767         * DOM/DOMHTMLEmbedElement.mm:
768         * DOM/DOMHTMLFieldSetElement.mm:
769         * DOM/DOMHTMLFontElement.mm:
770         * DOM/DOMHTMLFormElement.mm:
771         * DOM/DOMHTMLFrameElement.mm:
772         * DOM/DOMHTMLFrameSetElement.mm:
773         * DOM/DOMHTMLHRElement.mm:
774         * DOM/DOMHTMLHeadElement.mm:
775         * DOM/DOMHTMLHeadingElement.mm:
776         * DOM/DOMHTMLHtmlElement.mm:
777         * DOM/DOMHTMLIFrameElement.mm:
778         * DOM/DOMHTMLImageElement.mm:
779         * DOM/DOMHTMLInputElement.mm:
780         * DOM/DOMHTMLLIElement.mm:
781         * DOM/DOMHTMLLabelElement.mm:
782         * DOM/DOMHTMLLegendElement.mm:
783         * DOM/DOMHTMLLinkElement.mm:
784         * DOM/DOMHTMLMapElement.mm:
785         * DOM/DOMHTMLMarqueeElement.mm:
786         * DOM/DOMHTMLMediaElement.mm:
787         * DOM/DOMHTMLMenuElement.mm:
788         * DOM/DOMHTMLMetaElement.mm:
789         * DOM/DOMHTMLModElement.mm:
790         * DOM/DOMHTMLOListElement.mm:
791         * DOM/DOMHTMLObjectElement.mm:
792         * DOM/DOMHTMLOptGroupElement.mm:
793         * DOM/DOMHTMLOptionElement.mm:
794         * DOM/DOMHTMLOptionsCollection.mm:
795         * DOM/DOMHTMLParagraphElement.mm:
796         * DOM/DOMHTMLParamElement.mm:
797         * DOM/DOMHTMLPreElement.mm:
798         * DOM/DOMHTMLQuoteElement.mm:
799         * DOM/DOMHTMLScriptElement.mm:
800         * DOM/DOMHTMLSelectElement.mm:
801         * DOM/DOMHTMLStyleElement.mm:
802         * DOM/DOMHTMLTableCaptionElement.mm:
803         * DOM/DOMHTMLTableCellElement.mm:
804         * DOM/DOMHTMLTableColElement.mm:
805         * DOM/DOMHTMLTableElement.mm:
806         * DOM/DOMHTMLTableRowElement.mm:
807         * DOM/DOMHTMLTableSectionElement.mm:
808         * DOM/DOMHTMLTitleElement.mm:
809         * DOM/DOMHTMLUListElement.mm:
810         * DOM/DOMHTMLVideoElement.mm:
811         * DOM/DOMKeyboardEvent.mm:
812         * DOM/DOMMediaError.mm:
813         * DOM/DOMMediaList.mm:
814         * DOM/DOMMouseEvent.mm:
815         * DOM/DOMMutationEvent.mm:
816         * DOM/DOMNamedNodeMap.mm:
817         * DOM/DOMNodeIterator.mm:
818         * DOM/DOMNodeList.mm:
819         * DOM/DOMOverflowEvent.mm:
820         * DOM/DOMProcessingInstruction.mm:
821         * DOM/DOMProgressEvent.mm:
822         * DOM/DOMRGBColor.mm:
823         * DOM/DOMRange.mm:
824         * DOM/DOMRect.mm:
825         * DOM/DOMStyleSheet.mm:
826         * DOM/DOMStyleSheetList.mm:
827         * DOM/DOMText.mm:
828         * DOM/DOMTextEvent.mm:
829         * DOM/DOMTimeRanges.mm:
830         * DOM/DOMTokenList.mm:
831         * DOM/DOMTreeWalker.mm:
832         * DOM/DOMUIEvent.mm:
833         * DOM/DOMWheelEvent.mm:
834         * DOM/DOMXPath.mm:
835         * DOM/DOMXPathExpression.mm:
836         * DOM/DOMXPathResult.mm:
837
838 2019-07-17  Antoine Quint  <graouts@apple.com>
839
840         Disable Pointer Events prior to watchOS 6
841         https://bugs.webkit.org/show_bug.cgi?id=199890
842         <rdar://problem/53206113>
843
844         Reviewed by Dean Jackson.
845
846         * Configurations/FeatureDefines.xcconfig:
847
848 2019-07-17  Zalan Bujtas  <zalan@apple.com>
849
850         Unable to tap buttons at top of Wells Fargo app’s Payees screen
851         https://bugs.webkit.org/show_bug.cgi?id=199846
852         <rdar://problem/48112220>
853
854         Reviewed by Simon Fraser.
855
856         * WebView/WebFrame.mm:
857         (-[WebFrame approximateNodeAtViewportLocation:]):
858
859 2019-07-17  Alex Christensen  <achristensen@webkit.org>
860
861         Add a runtime-disabled dialog element skeleton
862         https://bugs.webkit.org/show_bug.cgi?id=199839
863
864         Reviewed by Ryosuke Niwa.
865
866         * WebView/WebPreferenceKeysPrivate.h:
867         * WebView/WebPreferences.mm:
868         (+[WebPreferences initialize]):
869         (-[WebPreferences dialogElementEnabled]):
870         (-[WebPreferences setDialogElementEnabled:]):
871         * WebView/WebPreferencesPrivate.h:
872         * WebView/WebView.mm:
873         (-[WebView _preferencesChanged:]):
874         Add SPI to enable the dialog element for tests.
875
876 2019-07-15  Dean Jackson  <dino@apple.com>
877
878         [WebGL] Remove software rendering and simplify context creation on macOS
879         https://bugs.webkit.org/show_bug.cgi?id=199789
880
881         Reviewed by Sam Weinig.
882
883         Remove force software WebGL setting.
884
885         * WebView/WebPreferenceKeysPrivate.h:
886         * WebView/WebPreferences.mm:
887         (+[WebPreferences initialize]):
888         (-[WebPreferences forceSoftwareWebGLRendering]): Deleted.
889         (-[WebPreferences setForceSoftwareWebGLRendering:]): Deleted.
890         * WebView/WebPreferencesPrivate.h:
891         * WebView/WebView.mm:
892         (-[WebView _preferencesChanged:]):
893
894 2019-07-13  Zalan Bujtas  <zalan@apple.com>
895
896         Cannot bring up custom media controls at all on v.youku.com
897         https://bugs.webkit.org/show_bug.cgi?id=199699
898         <rdar://problem/51835327>
899
900         Reviewed by Simon Fraser.
901
902         * WebCoreSupport/WebFrameLoaderClient.mm:
903         (WebFrameLoaderClient::actionDictionary const):
904         * WebView/WebFrame.mm:
905         (-[WebFrame elementAtPoint:]):
906         * WebView/WebHTMLView.mm:
907         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
908         * WebView/WebImmediateActionController.mm:
909         (-[WebImmediateActionController performHitTestAtPoint:]):
910
911 2019-07-12  Alex Christensen  <achristensen@webkit.org>
912
913         Begin unifying WebKitLegacy sources
914         https://bugs.webkit.org/show_bug.cgi?id=199730
915
916         Reviewed by Keith Miller.
917
918         * Configurations/WebKitLegacy.xcconfig:
919
920 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
921
922         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
923         https://bugs.webkit.org/show_bug.cgi?id=199625
924
925         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
926         with ENABLE(ACCESSIBILITY) in the code.
927
928         Additionally, the TestRunner code generator now honors the
929         Conditional IDL format.
930
931         Reviewed by Konstantin Tokarev.
932
933         * WebView/WebFrame.mm:
934         (-[WebFrame setAccessibleName:]):
935         (-[WebFrame enhancedAccessibilityEnabled]):
936         (-[WebFrame setEnhancedAccessibility:]):
937         (-[WebFrame accessibilityRoot]):
938
939 2019-07-08  Antoine Quint  <graouts@apple.com>
940
941         [Pointer Events] Enable only on the most recent version of the supported iOS family
942         https://bugs.webkit.org/show_bug.cgi?id=199562
943         <rdar://problem/52766511>
944
945         Reviewed by Dean Jackson.
946
947         * Configurations/FeatureDefines.xcconfig:
948
949 2019-07-03  Sam Weinig  <weinig@apple.com>
950
951         Adopt simple structured bindings in more places
952         https://bugs.webkit.org/show_bug.cgi?id=199247
953
954         Reviewed by Alex Christensen.
955
956         Replaces simple uses of std::tie() with structured bindings. Does not touch
957         uses of std::tie() that are not initial declarations, use std::ignore or in
958         case where the binding is captured by a lambda, as structured bindings don't
959         work for those cases yet.
960
961         * WebView/WebImmediateActionController.mm:
962         (-[WebImmediateActionController _animationControllerForText]):
963
964 2019-07-02  Devin Rousso  <drousso@apple.com>
965
966         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
967         https://bugs.webkit.org/show_bug.cgi?id=198956
968
969         Reviewed by Matt Baker.
970
971         * WebCoreSupport/WebInspectorClient.h:
972         * WebCoreSupport/WebInspectorClient.mm:
973         (WebInspectorFrontendClient::resetWindowState): Added.
974
975 2019-06-28  Timothy Hatcher  <timothy@apple.com>
976
977         Rename effectiveAppearanceIsInactive and useInactiveAppearance to better match UIUserInterfaceLevel.
978         https://bugs.webkit.org/show_bug.cgi?id=199336
979         rdar://problem/52348938
980
981         Reviewed by Tim Horton.
982
983         * WebView/WebView.mm:
984         (-[WebView _commonInitializationWithFrameName:groupName:]):
985         (-[WebView _setUseDarkAppearance:]):
986         (-[WebView _useElevatedUserInterfaceLevel]):
987         (-[WebView _setUseElevatedUserInterfaceLevel:]):
988         (-[WebView _setUseDarkAppearance:useInactiveAppearance:]):
989         (-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]):
990         (-[WebView _effectiveUserInterfaceLevelIsElevated]):
991         (-[WebView viewDidChangeEffectiveAppearance]):
992         (-[WebView _useInactiveAppearance]): Deleted.
993         (-[WebView _setUseInactiveAppearance:]): Deleted.
994         (-[WebView _effectiveAppearanceIsInactive]): Deleted.
995         * WebView/WebViewPrivate.h:
996
997 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
998
999         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
1000         https://bugs.webkit.org/show_bug.cgi?id=199317
1001
1002         Reviewed by Michael Catanzaro.
1003
1004         While IconDatabase and all code using it was removed,
1005         ENABLE_ICONDATABASE still exists as build option and C++ macro.
1006
1007         * Configurations/FeatureDefines.xcconfig:
1008         * WebView/WebView.mm:
1009         (-[WebView _cacheFrameLoadDelegateImplementations]): Use PLATFORM(MAC)
1010         guard instead of ENABLE_ICONDATABASE, because ENABLE_ICONDATABASE was
1011         enabled for macOS only.
1012
1013 2019-06-27  Timothy Hatcher  <timothy@apple.com>
1014
1015         Move WebKitLegacy off of a couple AppKit ivars.
1016         https://bugs.webkit.org/show_bug.cgi?id=199279
1017         rdar://problem/34983438
1018
1019         Reviewed by Tim Horton.
1020
1021         * WebView/WebHTMLView.mm:
1022         (-[NSView _setSubviewsIvar:]): Added. Implement on older systems.
1023         (-[NSView _subviewsIvar]): Added. Ditto.
1024         (needsCursorRectsSupportAtPoint): Use _borderView property.
1025         (-[WebHTMLView _setAsideSubviews]): Use _subviewsIvar property.
1026         (-[NSWindow _web_borderView]): Deleted.
1027
1028 2019-06-27  Beth Dakin  <bdakin@apple.com>
1029
1030         Upstream use of MACCATALYST
1031         https://bugs.webkit.org/show_bug.cgi?id=199245
1032         rdar://problem/51687723
1033
1034         Reviewed by Tim Horton.
1035
1036         * Configurations/Base.xcconfig:
1037         * Configurations/FeatureDefines.xcconfig:
1038         * Configurations/SDKVariant.xcconfig:
1039
1040 2019-06-27  Saam Barati  <sbarati@apple.com>
1041
1042         Make WEBGPU enabled only on Mojave and later.
1043
1044         Rubber-stamped by Myles C. Maxfield.
1045
1046         * Configurations/FeatureDefines.xcconfig:
1047
1048 2019-06-16  Darin Adler  <darin@apple.com>
1049
1050         Rename AtomicString to AtomString
1051         https://bugs.webkit.org/show_bug.cgi?id=195276
1052
1053         Reviewed by Michael Catanzaro.
1054
1055         * many files: Let do-webcore-rename do the renaming.
1056
1057 2019-06-14  Megan Gardner  <megan_gardner@apple.com>
1058
1059         Move Synthetic Editing Commands to behind an experimental feature flag
1060         https://bugs.webkit.org/show_bug.cgi?id=198842
1061         <rdar://problem/50594700>
1062
1063         Reviewed by Simon Fraser.
1064
1065         Add plumbing for synthetic editing command feature flag.
1066
1067         * WebView/WebPreferenceKeysPrivate.h:
1068         * WebView/WebPreferences.mm:
1069         (+[WebPreferences initialize]):
1070         (-[WebPreferences syntheticEditingCommandsEnabled]):
1071         (-[WebPreferences setSyntheticEditingCommandsEnabled:]):
1072         * WebView/WebPreferencesPrivate.h:
1073         * WebView/WebView.mm:
1074         (-[WebView _preferencesChanged:]):
1075
1076 2019-06-13  Antoine Quint  <graouts@apple.com>
1077
1078         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1079         https://bugs.webkit.org/show_bug.cgi?id=198800
1080         <rdar://problem/51679634>
1081
1082         Reviewed by Tim Horton.
1083
1084         Expose a private method that we need to use from DumpRenderTree.
1085
1086         * WebView/WebHTMLView.mm:
1087         (-[WebHTMLView _hitViewForEvent:]):
1088         * WebView/WebHTMLViewPrivate.h:
1089
1090 2019-06-10  Sam Weinig  <weinig@apple.com>
1091
1092         Remove Dashboard support
1093         https://bugs.webkit.org/show_bug.cgi?id=198615
1094
1095         Reviewed by Ryosuke Niwa.
1096
1097         Removes implementation, but keeps privatly exported interfaces and enums
1098         around until we can confirm there are no more users of them. 
1099
1100         * Configurations/FeatureDefines.xcconfig:
1101         * Plugins/WebBaseNetscapePluginView.mm:
1102         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1103         * WebCoreSupport/WebChromeClient.h:
1104         * WebCoreSupport/WebChromeClient.mm:
1105         (WebChromeClient::annotatedRegionsChanged): Deleted.
1106         * WebView/WebClipView.mm:
1107         (-[WebClipView _focusRingVisibleRect]):
1108         (-[WebClipView scrollWheel:]):
1109         * WebView/WebDashboardRegion.h:
1110         * WebView/WebDashboardRegion.mm:
1111         * WebView/WebHTMLView.mm:
1112         (-[WebHTMLView _updateMouseoverWithEvent:]):
1113         (-[WebHTMLView acceptsFirstMouse:]):
1114         (-[WebHTMLView setDataSource:]):
1115         * WebView/WebPreferences.mm:
1116         (cacheModelForMainBundle):
1117         * WebView/WebUIDelegatePrivate.h:
1118         * WebView/WebView.mm:
1119         (-[WebView _needsPreHTML5ParserQuirks]):
1120         (-[WebView _preferencesChanged:]):
1121         (-[WebView _addScrollerDashboardRegions:]):
1122         (-[WebView _dashboardRegions]):
1123         (-[WebView _setDashboardBehavior:to:]):
1124         (-[WebView _dashboardBehavior:]):
1125         (-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted.
1126         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted.
1127         (-[WebView _addScrollerDashboardRegions:from:]): Deleted.
1128         * WebView/WebViewData.h:
1129         * WebView/WebViewData.mm:
1130         (-[WebViewPrivate init]):
1131         * WebView/WebViewPrivate.h:
1132
1133 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1134
1135         Integrate dark mode support for iOS.
1136         https://bugs.webkit.org/show_bug.cgi?id=198687
1137         rdar://problem/51545643
1138
1139         Reviewed by Tim Horton.
1140
1141         * Configurations/FeatureDefines.xcconfig:
1142
1143 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1144
1145         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1146         https://bugs.webkit.org/show_bug.cgi?id=198664
1147
1148         Reviewed by Simon Fraser.
1149
1150         WK1 has to skip using DisplayRefreshMonitor when layers need to be updated.
1151
1152         * WebCoreSupport/WebChromeClient.h:
1153         (WebChromeClient::needsImmediateScheduleCompositingLayerFlush):
1154
1155 == Rolled over to ChangeLog-2019-06-05 ==