d360e7cbb791e213c48372dbc1eec1ca59a43d1f
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2
3         Have ScrollableArea store a ScrollType for the current scroll
4         https://bugs.webkit.org/show_bug.cgi?id=196627
5
6         Reviewed by Zalan Bujtas.
7
8         Send the programmatic scroll type.
9
10         * DOM/DOMHTML.mm:
11         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
12
13 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
14
15         -apple-trailing-word is needed for browser detection
16         https://bugs.webkit.org/show_bug.cgi?id=196575
17
18         Unreviewed.
19
20         * Configurations/FeatureDefines.xcconfig:
21
22 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
23
24         Remove support for -apple-trailing-word
25         https://bugs.webkit.org/show_bug.cgi?id=196525
26
27         Reviewed by Zalan Bujtas.
28
29         This CSS property is nonstandard and not used.
30
31         * Configurations/FeatureDefines.xcconfig:
32
33 2019-04-01  Alex Christensen  <achristensen@webkit.org>
34
35         Add SPI to canonicalize NSURLs with WTF::URL
36         https://bugs.webkit.org/show_bug.cgi?id=196415
37         <rdar://problem/44980271>
38
39         Reviewed by Darin Adler.
40
41         * Misc/WebNSURLExtras.h:
42         * Misc/WebNSURLExtras.mm:
43         (-[NSURL _webkit_canonicalize_with_wtf]):
44         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
45         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
46
47 2019-03-31  Sam Weinig  <weinig@apple.com>
48
49         Remove more i386 specific configurations
50         https://bugs.webkit.org/show_bug.cgi?id=196430
51
52         Reviewed by Alexey Proskuryakov.
53
54         * Configurations/FeatureDefines.xcconfig:
55         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
56
57 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
58
59         Delete WebMetal implementation in favor of WebGPU
60         https://bugs.webkit.org/show_bug.cgi?id=195418
61
62         Reviewed by Dean Jackson.
63
64         * Configurations/FeatureDefines.xcconfig:
65         * WebView/WebPreferenceKeysPrivate.h:
66         * WebView/WebPreferences.mm:
67         (+[WebPreferences initialize]):
68         (-[WebPreferences webMetalEnabled]): Deleted.
69         (-[WebPreferences setWebMetalEnabled:]): Deleted.
70         * WebView/WebPreferencesPrivate.h:
71         * WebView/WebView.mm:
72         (-[WebView _preferencesChanged:]):
73
74 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
75
76         Implement ResizeObserver.
77         https://bugs.webkit.org/show_bug.cgi?id=157743
78
79         Reviewed by Simon Fraser.
80
81         * Configurations/FeatureDefines.xcconfig:
82         * WebView/WebPreferenceKeysPrivate.h:
83         * WebView/WebPreferences.mm:
84         (+[WebPreferences initialize]):
85         (-[WebPreferences resizeObserverEnabled]):
86         (-[WebPreferences setResizeObserverEnabled:]):
87         * WebView/WebPreferencesPrivate.h:
88         * WebView/WebView.mm:
89         (-[WebView _preferencesChanged:]):
90         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
91
92 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
93
94         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
95         https://bugs.webkit.org/show_bug.cgi?id=196336
96
97         Reviewed by Tim Horton.
98
99         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
100
101         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
102
103         * WebCoreSupport/PopupMenuMac.mm:
104         (PopupMenuMac::hide):
105
106 2019-03-25  Andy Estes  <aestes@apple.com>
107
108         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
109         https://bugs.webkit.org/show_bug.cgi?id=194964
110         <rdar://problem/48279441>
111
112         Reviewed by Alex Christensen.
113
114         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
115         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
116         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
117         PreviewLoaderClient alive for its lifetime. This ensures that as long as
118         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
119         by WebKit.
120
121         * WebCoreSupport/WebFrameLoaderClient.mm:
122         (WebFrameLoaderClient::createPreviewLoaderClient):
123         * WebView/WebDataSource.mm:
124         (-[WebDataSource _quickLookPreviewLoaderClient]):
125         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
126         * WebView/WebDataSourceInternal.h:
127
128 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
129
130         Remove NavigatorContentUtils in WebCore/Modules
131         https://bugs.webkit.org/show_bug.cgi?id=196070
132
133         Reviewed by Alex Christensen.
134
135         NavigatorContentUtils was to support the custom scheme spec [1].
136         However, in WebKit side, no port has supported the feature in
137         WebKit layer after EFL port was removed. So there has been the
138         only IDL implementation of the NavigatorContentUtils in WebCore.
139         So we don't need to keep the implementation in WebKit.
140
141         * Configurations/FeatureDefines.xcconfig:
142
143 2019-03-22  Keith Rollin  <krollin@apple.com>
144
145         Enable ThinLTO support in Production builds
146         https://bugs.webkit.org/show_bug.cgi?id=190758
147         <rdar://problem/45413233>
148
149         Reviewed by Daniel Bates.
150
151         Enable building with Thin LTO in Production when using Xcode 10.2 or
152         later. This change results in a 1.45% progression in PLT5. Full
153         Production build times increase about 2-3%. Incremental build times
154         are more severely affected, and so LTO is not enabled for local
155         engineering builds.
156
157         LTO is enabled only on macOS for now, until rdar://problem/49013399,
158         which affects ARM builds, is fixed.
159
160         To change the LTO setting when building locally:
161
162         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
163           command line.
164         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
165           on the command line.
166         - If building with `build-root`, specify --lto={none,thin,full} on the
167           command line.
168         - If building with Xcode, create a LocalOverrides.xcconfig file at the
169           top level of your repository directory (if needed) and define
170           WK_LTO_MODE to full, thin, or none.
171
172         * Configurations/Base.xcconfig:
173
174 2019-03-21  Andy Estes  <aestes@apple.com>
175
176         [iOS] Apple Pay should be available in documents with no user agent scripts
177         https://bugs.webkit.org/show_bug.cgi?id=196061
178         <rdar://problem/48649391>
179
180         Reviewed by Brady Eidson.
181
182         * WebView/WebFrame.mm:
183         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
184
185 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
186
187         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
188         https://bugs.webkit.org/show_bug.cgi?id=196049
189
190         Reviewed by Tim Horton.
191
192         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
193         overflow scrolling in general, so rename it.
194
195         * Configurations/FeatureDefines.xcconfig:
196
197 2019-03-13  Dean Jackson  <dino@apple.com>
198
199         Block all plugins smaller than 5x5px
200         https://bugs.webkit.org/show_bug.cgi?id=195702
201         <rdar://problem/28435204>
202
203         Reviewed by Sam Weinig.
204
205         Removed a function that was never being called.
206
207         * WebCoreSupport/WebFrameLoaderClient.h:
208         * WebCoreSupport/WebFrameLoaderClient.mm:
209         (WebFrameLoaderClient::recreatePlugin): Deleted.
210
211 2019-03-13  Keith Rollin  <krollin@apple.com>
212
213         Add support for new StagedFrameworks layout
214         https://bugs.webkit.org/show_bug.cgi?id=195543
215
216         Reviewed by Alexey Proskuryakov.
217
218         When creating the WebKit layout for out-of-band Safari/WebKit updates,
219         use an optional path prefix when called for.
220
221         * Configurations/WebKitLegacy.xcconfig:
222
223 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Remove a site specific hack for AppleConnect plugin
226         https://bugs.webkit.org/show_bug.cgi?id=195643
227
228         Reviewed by Simon Fraser.
229
230         r66437 added a workaround for AppleConnect plugin.
231
232         Remove this code since Safari doesn't even use WebKitLegacy anymore,
233         and other WebKit clients support AppleConnect plugins.
234
235         * WebCoreSupport/WebFrameLoaderClient.mm:
236         (WebFrameLoaderClient::createPlugin):
237
238 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
239
240         Unreviewed, rolling out r242688, r242643, r242624.
241
242         Caused multiple layout test failures and crashes on iOS and macOS.
243
244         Reverted changeset:
245
246         "requestAnimationFrame should execute before the next frame"
247         https://bugs.webkit.org/show_bug.cgi?id=177484
248         https://trac.webkit.org/changeset/242624/webkit
249
250         * WebView/WebView.mm:
251         (-[WebView _viewWillDrawInternal]):
252
253 2019-03-09  Andy Estes  <aestes@apple.com>
254
255         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
256         https://bugs.webkit.org/show_bug.cgi?id=195526
257         <rdar://problem/48745636>
258
259         Reviewed by Chris Dumez.
260
261         * WebCoreSupport/WebPaymentCoordinatorClient.h:
262         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
263         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
264         (WebPaymentCoordinatorClient::openPaymentSetup):
265
266 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
267
268         requestAnimationFrame should execute before the next frame
269         https://bugs.webkit.org/show_bug.cgi?id=177484
270
271         Reviewed by Simon Fraser.
272
273         * WebView/WebView.mm:
274         (-[WebView _viewWillDrawInternal]):
275         Call Page::renderingUpdate() which implements  "Update the rendering"
276         step of the HTML Event Loop specification.
277
278 2019-03-07  Zalan Bujtas  <zalan@apple.com>
279
280         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
281         https://bugs.webkit.org/show_bug.cgi?id=195353
282         <rdar://problem/48626394>
283
284         Reviewed by Simon Fraser.
285
286         * WebView/WebPreferenceKeysPrivate.h:
287         * WebView/WebPreferences.mm:
288         (+[WebPreferences initialize]):
289         (-[WebPreferences contentChangeObserverEnabled]):
290         (-[WebPreferences setContentChangeObserverEnabled:]):
291         * WebView/WebPreferencesPrivate.h:
292         * WebView/WebView.mm:
293         (-[WebView _preferencesChanged:]):
294
295 2019-03-06  Sam Weinig  <sam@webkit.org>
296
297         WebKitLegacy does not need to generate an export file for i386 anymore
298         https://bugs.webkit.org/show_bug.cgi?id=195380
299
300         Reviewed by Dan Bernstein.
301
302         * Configurations/WebKitLegacy.xcconfig:
303         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
304         It still needs to be generated, since we are concatenating the shared exports
305         file with a macOS or iOS specific one.
306
307         * WebKit.mac.exp:
308         Remove i386 specific symbols that we were previously stripping.
309
310 2019-03-06  Rob Buis  <rbuis@igalia.com>
311
312         Consider supporting the `referrerpolicy` attribute.
313         https://bugs.webkit.org/show_bug.cgi?id=179053
314
315         Reviewed by Darin Adler.
316
317         Add a runtime flag for referrerpolicy attribute.
318
319         * WebView/WebPreferenceKeysPrivate.h:
320         * WebView/WebPreferences.mm:
321         (+[WebPreferences initialize]):
322         (-[WebPreferences referrerPolicyAttributeEnabled]):
323         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
324         * WebView/WebPreferencesPrivate.h:
325         * WebView/WebView.mm:
326         (-[WebView _preferencesChanged:]):
327
328 2019-03-03  Tim Horton  <timothy_horton@apple.com>
329
330         Remove some more unused 32-bit code
331         https://bugs.webkit.org/show_bug.cgi?id=195255
332
333         Reviewed by Darin Adler.
334
335         * Plugins/WebNetscapePluginEventHandler.mm:
336         (WebNetscapePluginEventHandler::create):
337         * Plugins/WebNetscapePluginView.h:
338         * Plugins/WebNetscapePluginView.mm:
339         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
340         (-[WebNetscapePluginView restorePortState:]):
341         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
342         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
343         (-[WebNetscapePluginView updateAndSetWindow]):
344         (-[WebNetscapePluginView setWindowIfNecessary]):
345         (-[WebNetscapePluginView createPlugin]):
346         (-[WebNetscapePluginView fini]):
347         (-[WebNetscapePluginView drawRect:]):
348         (-[WebNetscapePluginView invalidateRegion:]):
349         (-[WebNetscapePluginView getVariable:value:]):
350         (-[WebNetscapePluginView setVariable:value:]):
351         (isDrawingModelQuickDraw): Deleted.
352         (-[WebNetscapePluginView fixWindowPort]): Deleted.
353         (getQDPixelFormatForBitmapContext): Deleted.
354         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
355         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
356         * WebView/WebDelegateImplementationCaching.mm:
357
358 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
359
360         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
361         https://bugs.webkit.org/show_bug.cgi?id=195053
362         <rdar://problem/48134710>
363
364         Reviewed by Ryosuke Niwa.
365
366         * WebCoreSupport/WebEditorClient.h:
367
368 2019-03-01  Tim Horton  <timothy_horton@apple.com>
369
370         Remove unused code in WebKitLegacy
371         https://bugs.webkit.org/show_bug.cgi?id=189614
372
373         Reviewed by Simon Fraser.
374
375         * Carbon/CarbonUtils.h: Removed.
376         * Carbon/CarbonUtils.m: Removed.
377         * Carbon/CarbonWindowAdapter.h: Removed.
378         * Carbon/CarbonWindowAdapter.mm: Removed.
379         * Carbon/CarbonWindowContentView.h: Removed.
380         * Carbon/CarbonWindowContentView.m: Removed.
381         * Carbon/CarbonWindowFrame.h: Removed.
382         * Carbon/CarbonWindowFrame.m: Removed.
383         * Carbon/HIViewAdapter.h: Removed.
384         * Carbon/HIViewAdapter.m: Removed.
385         * Carbon/HIWebView.h: Removed.
386         * Carbon/HIWebView.mm: Removed.
387         * Configurations/WebKitLegacy.xcconfig:
388         * WebKit.mac.exp:
389
390 2019-03-01  Justin Fan  <justin_fan@apple.com>
391
392         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
393         https://bugs.webkit.org/show_bug.cgi?id=195191
394
395         Rubber-stamped by Dean Jackson.
396
397         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
398
399         * Configurations/FeatureDefines.xcconfig:
400
401 2019-02-28  Antoine Quint  <graouts@apple.com>
402
403         Enable the Pointer Events runtime flag by default
404         https://bugs.webkit.org/show_bug.cgi?id=195156
405
406         Reviewed by Dean Jackson.
407
408         * WebView/WebPreferences.mm:
409         (+[WebPreferences initialize]):
410
411 2019-02-28  Justin Fan  <justin_fan@apple.com>
412
413         [Web GPU] Enable Web GPU only on 64-bit
414         https://bugs.webkit.org/show_bug.cgi?id=195139
415
416         Because Metal is only supported on 64 bit apps.
417
418         Unreviewed build fix.
419
420         * Configurations/FeatureDefines.xcconfig:
421
422 2019-02-27  Antoine Quint  <graouts@apple.com>
423
424         Support Pointer Events on macOS
425         https://bugs.webkit.org/show_bug.cgi?id=195008
426         <rdar://problem/47454419>
427
428         Reviewed by Dean Jackson.
429
430         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
431
432         * Configurations/FeatureDefines.xcconfig:
433         * WebView/WebPreferenceKeysPrivate.h:
434         * WebView/WebPreferences.mm:
435         (+[WebPreferences initialize]):
436         (-[WebPreferences pointerEventsEnabled]):
437         (-[WebPreferences setPointerEventsEnabled:]):
438         * WebView/WebPreferencesPrivate.h:
439         * WebView/WebView.mm:
440         (-[WebView _preferencesChanged:]):
441
442 2019-02-23  Keith Miller  <keith_miller@apple.com>
443
444         Add new mac target numbers
445         https://bugs.webkit.org/show_bug.cgi?id=194955
446
447         Reviewed by Tim Horton.
448
449         * Configurations/Base.xcconfig:
450         * Configurations/DebugRelease.xcconfig:
451
452 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
453
454         Hardcode Visual Viewports on everywhere except iOS WK1
455         https://bugs.webkit.org/show_bug.cgi?id=194928
456
457         Reviewed by Zalan Bujtas.
458
459         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
460         change the default value of the Setting to 'true', and hardcode WebView on iOS to
461         set it to false. The setting has shipped for several years and there's no need to turn
462         it off now.
463
464         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
465         Visual Viewports are not enabled.
466         
467         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
468         that only runs in WK2
469
470         * WebView/WebPreferenceKeysPrivate.h:
471         * WebView/WebPreferences.mm:
472         (+[WebPreferences initialize]):
473         (-[WebPreferences visualViewportEnabled]): Deleted.
474         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
475         * WebView/WebPreferencesPrivate.h:
476         * WebView/WebView.mm:
477         (-[WebView _preferencesChanged:]):
478
479 2019-02-21  Darin Adler  <darin@apple.com>
480
481         Some refinements for Node and Document
482         https://bugs.webkit.org/show_bug.cgi?id=194764
483
484         Reviewed by Ryosuke Niwa.
485
486         * DOM/DOMDocument.mm:
487         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
488         through to WebCore or even looking at the arguments.
489         (-[DOMDocument getOverrideStyle::]): Ditto.
490
491 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
494         https://bugs.webkit.org/show_bug.cgi?id=194670
495         <rdar://problem/39066529>
496
497         Reviewed by Tim Horton.
498
499         * WebCoreSupport/WebEditorClient.h:
500         * WebCoreSupport/WebEditorClient.mm:
501         (WebEditorClient::replacementURLForResource): Deleted.
502         * WebCoreSupport/WebPlatformStrategies.h:
503         * WebCoreSupport/WebPlatformStrategies.mm:
504         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
505
506 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
507
508         Add MSE logging configuration
509         https://bugs.webkit.org/show_bug.cgi?id=194719
510         <rdar://problem/48122151>
511
512         Reviewed by Joseph Pecoraro.
513
514         * WebCoreSupport/WebChromeClient.mm:
515         (stringForMessageSource): Recognize the MSE message source.
516
517 2019-02-17  David Kilzer  <ddkilzer@apple.com>
518
519         Unreviewed, rolling out r241620.
520
521         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
522         (Requested by ddkilzer on #webkit.)
523
524         Reverted changeset:
525
526         "[WTF] Add environment variable helpers"
527         https://bugs.webkit.org/show_bug.cgi?id=192405
528         https://trac.webkit.org/changeset/241620
529
530 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
531
532         [WTF] Add environment variable helpers
533         https://bugs.webkit.org/show_bug.cgi?id=192405
534
535         Reviewed by Michael Catanzaro.
536
537         * WebView/WebView.mm:
538         (-[WebView _initWithFrame:frameName:groupName:]):
539         Utilize WTF::Environment where possible.
540
541 2019-02-15  Brian Burg  <bburg@apple.com>
542
543         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
544         https://bugs.webkit.org/show_bug.cgi?id=194411
545         <rdar://problem/47787614>
546
547         Reviewed by Joseph Pecoraro.
548
549         * Configurations/WebKitLegacy.xcconfig:
550         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
551
552         * WebCoreSupport/WebInspectorClient.mm:
553         (WebInspectorFrontendClient::localizedStringsURL):
554         (-[WebInspectorWindowController inspectorPagePath]):
555         (-[WebInspectorWindowController inspectorTestPagePath]):
556         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
557
558 2019-02-15  Commit Queue  <commit-queue@webkit.org>
559
560         Unreviewed, rolling out r241559 and r241566.
561         https://bugs.webkit.org/show_bug.cgi?id=194710
562
563         Causes layout test crashes under GuardMalloc (Requested by
564         ryanhaddad on #webkit).
565
566         Reverted changesets:
567
568         "[WTF] Add environment variable helpers"
569         https://bugs.webkit.org/show_bug.cgi?id=192405
570         https://trac.webkit.org/changeset/241559
571
572         "Unreviewed build fix for WinCairo Debug after r241559."
573         https://trac.webkit.org/changeset/241566
574
575 2019-02-15  Truitt Savell  <tsavell@apple.com>
576
577         Unreviewed, rolling out r241564.
578
579         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
580
581         Reverted changeset:
582
583         "[Mac] WebInspectorUI.framework does not need to be soft-
584         linked anymore"
585         https://bugs.webkit.org/show_bug.cgi?id=194411
586         https://trac.webkit.org/changeset/241564
587
588 2019-02-14  Brian Burg  <bburg@apple.com>
589
590         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
591         https://bugs.webkit.org/show_bug.cgi?id=194411
592         <rdar://problem/47787614>
593
594         Reviewed by Joseph Pecoraro.
595
596         * Configurations/WebKitLegacy.xcconfig:
597         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
598
599         * WebCoreSupport/WebInspectorClient.mm:
600         (WebInspectorFrontendClient::localizedStringsURL):
601         (-[WebInspectorWindowController inspectorPagePath]):
602         (-[WebInspectorWindowController inspectorTestPagePath]):
603         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
604
605 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
606
607         [WTF] Add environment variable helpers
608         https://bugs.webkit.org/show_bug.cgi?id=192405
609
610         Reviewed by Michael Catanzaro.
611
612         * WebView/WebView.mm:
613         (-[WebView _initWithFrame:frameName:groupName:]):
614         Utilize WTF::Environment where possible.
615
616 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
617
618         Allow pages to trigger programmatic paste from script on iOS
619         https://bugs.webkit.org/show_bug.cgi?id=194271
620         <rdar://problem/47808810>
621
622         Reviewed by Ryosuke Niwa.
623
624         See WebCore and WebKit ChangeLogs for more details.
625
626         * WebCoreSupport/WebEditorClient.h:
627
628 2019-02-12  Andy Estes  <aestes@apple.com>
629
630         [iOSMac] Enable Parental Controls Content Filtering
631         https://bugs.webkit.org/show_bug.cgi?id=194521
632         <rdar://39732376>
633
634         Reviewed by Tim Horton.
635
636         * Configurations/FeatureDefines.xcconfig:
637
638 2019-02-06  Andy Estes  <aestes@apple.com>
639
640         [Payment Request] It should be possible to require a phonetic name for shipping contacts
641         https://bugs.webkit.org/show_bug.cgi?id=194311
642         <rdar://46733045>
643
644         Reviewed by Alex Christensen.
645
646         * WebCoreSupport/WebPaymentCoordinatorClient.h:
647         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
648         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
649
650 2019-02-04  Said Abou-Hallawa  <said@apple.com>
651
652         [CG] Enable setAdditionalSupportedImageTypes for WK1
653         https://bugs.webkit.org/show_bug.cgi?id=194190
654
655         Reviewed by Tim Horton.
656
657         1. Define the preferences key AdditionalSupportedImageTypes.
658         2. Add additionalSupportedImageTypes as a private preference property.
659         3. Define the setter and the getter of the property.
660         4. Add function to convert from an id to an array of strings.
661         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
662
663         * WebView/WebPreferenceKeysPrivate.h:
664         * WebView/WebPreferences.mm:
665         (-[WebPreferences _stringArrayValueForKey:]):
666         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
667         (-[WebPreferences setAdditionalSupportedImageTypes:]):
668         (-[WebPreferences additionalSupportedImageTypes]):
669         * WebView/WebPreferencesPrivate.h:
670         * WebView/WebView.mm:
671         (-[WebView _preferencesChanged:]):
672
673 2019-02-04  Timothy Hatcher  <timothy@apple.com>
674
675         Add WebView SPI to temporarily force light or dark appearance on a page.
676         https://bugs.webkit.org/show_bug.cgi?id=194230
677
678         Reviewed by Tim Horton.
679
680         * WebView/WebView.mm:
681         (-[WebView _useDarkAppearance:]): Added.
682         (-[WebView _setUseDarkAppearance:]): Added.
683         * WebView/WebViewPrivate.h:
684
685 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
686
687         PageOverlayController's layers should be created lazily
688         https://bugs.webkit.org/show_bug.cgi?id=194199
689         rdar://problem/46571593
690
691         Reviewed by Tim Horton.
692
693         * WebCoreSupport/WebChromeClient.h:
694         * WebCoreSupport/WebChromeClient.mm:
695         (WebChromeClient::attachViewOverlayGraphicsLayer):
696
697 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
698
699         Make setNeedsLayout on the root more explicitly about triggering its side-effects
700         https://bugs.webkit.org/show_bug.cgi?id=194198
701
702         Reviewed by Antti Koivisto.
703
704         Call the newly named functions.
705
706         * WebView/WebFrame.mm:
707         (-[WebFrame setNeedsLayout]):
708         * WebView/WebHTMLView.mm:
709         (-[WebHTMLView setNeedsLayout:]):
710
711 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
712
713         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
714         https://bugs.webkit.org/show_bug.cgi?id=194189
715
716         Reviewed by Geoffrey Garen.
717
718         Pass the policy check identifier around functions and store it in WebFramePolicyListener
719         so that we can send it back to WebCore with the navigation policy decision.
720
721         * WebCoreSupport/WebFrameLoaderClient.h:
722         * WebCoreSupport/WebFrameLoaderClient.mm:
723         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
724         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
725         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
726         (WebFrameLoaderClient::dispatchWillSubmitForm):
727         (WebFrameLoaderClient::setUpPolicyListener):
728         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
729         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
730         (-[WebFramePolicyListener invalidate]):
731         (-[WebFramePolicyListener dealloc]):
732         (-[WebFramePolicyListener receivedPolicyDecision:]):
733         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
734         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
735
736 2019-01-31  Alex Christensen  <achristensen@webkit.org>
737
738         Revert r238819 which is unneeded and caused a performance regression.
739         https://bugs.webkit.org/show_bug.cgi?id=192272
740         <rdar://problem/46664625>
741
742         * WebCoreSupport/WebFrameLoaderClient.h:
743         * WebCoreSupport/WebFrameLoaderClient.mm:
744         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
745
746 2019-01-28  Devin Rousso  <drousso@apple.com>
747
748         Web Inspector: provide a way to edit page WebRTC settings on a remote target
749         https://bugs.webkit.org/show_bug.cgi?id=193863
750         <rdar://problem/47572764>
751
752         Reviewed by Joseph Pecoraro.
753
754         * WebView/WebView.mm:
755         (-[WebView _preferencesChanged:]):
756         Add page-level settings for WebRTC preferences.
757
758 2019-01-28  Andy Estes  <aestes@apple.com>
759
760         [watchOS] Enable Parental Controls content filtering
761         https://bugs.webkit.org/show_bug.cgi?id=193939
762         <rdar://problem/46641912>
763
764         Reviewed by Ryosuke Niwa.
765
766         * Configurations/FeatureDefines.xcconfig:
767
768 2019-01-28  Timothy Hatcher  <timothy@apple.com>
769
770         Make it easier for non-Apple ports to enable dark mode CSS support.
771         https://bugs.webkit.org/show_bug.cgi?id=193882
772
773         Reviewed by Megan Gardner.
774
775         * WebView/WebView.mm:
776         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
777         (-[WebView _effectiveAppearanceIsDark]): Ditto.
778
779 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
780
781         AX: Introduce a static accessibility tree
782         https://bugs.webkit.org/show_bug.cgi?id=193348
783         <rdar://problem/47203295>
784
785         Reviewed by Ryosuke Niwa.
786
787         * Configurations/FeatureDefines.xcconfig:
788
789 2019-01-25  Keith Rollin  <krollin@apple.com>
790
791         Update WebKitAdditions.xcconfig with correct order of variable definitions
792         https://bugs.webkit.org/show_bug.cgi?id=193793
793         <rdar://problem/47532439>
794
795         Reviewed by Alex Christensen.
796
797         XCBuild changes the way xcconfig variables are evaluated. In short,
798         all config file assignments are now considered in part of the
799         evaluation. When using the new build system and an .xcconfig file
800         contains multiple assignments of the same build setting:
801
802         - Later assignments using $(inherited) will inherit from earlier
803           assignments in the xcconfig file.
804         - Later assignments not using $(inherited) will take precedence over
805           earlier assignments. An assignment to a more general setting will
806           mask an earlier assignment to a less general setting. For example,
807           an assignment without a condition ('FOO = bar') will completely mask
808           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
809
810         This affects some of our .xcconfig files, in that sometimes platform-
811         or sdk-specific definitions appear before the general definitions.
812         Under the new evaluations rules, the general definitions alway take
813         effect because they always overwrite the more-specific definitions. The
814         solution is to swap the order, so that the general definitions are
815         established first, and then conditionally overwritten by the
816         more-specific definitions.
817
818         * Configurations/Version.xcconfig:
819         * Configurations/WebKitLegacy.xcconfig:
820
821 2019-01-25  David Kilzer  <ddkilzer@apple.com>
822
823         Move soft-linking of Lookup.framework out of LookupSPI.h
824         <https://webkit.org/b/193815>
825
826         Reviewed by Tim Horton.
827
828         * WebView/WebImmediateActionController.mm:
829         (-[WebImmediateActionController _animationControllerForText]):
830         * WebView/WebView.mm:
831         (-[WebView _prepareForDictionaryLookup]):
832         - Move soft-linking to LookupSoftLink.{h,mm}.
833
834 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
835
836         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
837         https://bugs.webkit.org/show_bug.cgi?id=193829
838
839         Reviewed by Tim Horton.
840
841         * WebCoreSupport/WebDragClient.mm:
842         (WebDragClient::didConcludeEditDrag):
843         * WebView/WebView.mm:
844         (-[WebView _requestStartDataInteraction:globalPosition:]):
845         (-[WebView _didConcludeEditDrag]):
846         (-[WebView _didConcludeEditDataInteraction]): Deleted.
847         * WebView/WebViewInternal.h:
848
849 2019-01-24  John Wilander  <wilander@apple.com>
850
851         Add Ad Click Attribution as an internal/experimental feature
852         https://bugs.webkit.org/show_bug.cgi?id=193685
853         <rdar://problem/47450399>
854
855         Reviewed by Brent Fulgham.
856
857         * WebView/WebPreferenceKeysPrivate.h:
858         * WebView/WebPreferences.mm:
859         (+[WebPreferences initialize]):
860         (-[WebPreferences adClickAttributionEnabled]):
861         (-[WebPreferences setAdClickAttributionEnabled:]):
862             Added support for experimental ad click attribution.
863         * WebView/WebPreferencesPrivate.h:
864         * WebView/WebView.mm:
865         (-[WebView _preferencesChanged:]):
866
867 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
868
869         Move FileSystem to WTF
870         https://bugs.webkit.org/show_bug.cgi?id=193602
871
872         Reviewed by Yusuke Suzuki.
873
874         * Misc/WebNSFileManagerExtras.mm:
875         * Storage/WebDatabaseProvider.mm:
876         * WebView/WebView.mm:
877
878 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
879
880         Fix the Apple Internal build. See <rdar://problem/47491383>.
881
882         Rubber-stamped by Tim Horton.
883
884         * WebCoreSupport/WebFrameLoaderClient.mm:
885
886 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
887
888         Clean up USE(WEB_THREAD)
889         https://bugs.webkit.org/show_bug.cgi?id=193698
890
891         Rubber-stamped by Tim Horton.
892
893         * Misc/WebCache.mm:
894         (+[WebCache emptyInMemoryResources]):
895         * WebCoreSupport/WebFrameLoaderClient.mm:
896         (-[WebFramePolicyListener use]):
897         * WebCoreSupport/WebGeolocationClient.mm:
898         (-[WebGeolocationPolicyListener allow]):
899         (-[WebGeolocationPolicyListener deny]):
900         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
901         * WebView/WebFrame.mm:
902         (-[WebFrame deviceOrientationChanged]):
903         * WebView/WebHTMLView.mm:
904         (hardwareKeyboardAvailabilityChangedCallback):
905         * WebView/WebView.mm:
906         (+[WebView _releaseMemoryNow]):
907         (+[WebView willEnterBackgroundWithCompletionHandler:]):
908         (-[WebView updateLayoutIgnorePendingStyleSheets]):
909         (-[WebView _dispatchUnloadEvent]):
910         (-[WebView _close]):
911         (-[WebView _preferencesChangedNotification:]):
912         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
913         (-[WebView goBack]):
914         (-[WebView goForward]):
915         (+[WebView _cacheModelChangedNotification:]):
916         (-[WebView stopLoading:]):
917         (-[WebView stopLoadingAndClear]):
918         (-[WebView reload:]):
919         (WebInstallMemoryPressureHandler):
920
921 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
922
923         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
924         https://bugs.webkit.org/show_bug.cgi?id=193706
925         <rdar://problem/44807048>
926
927         Reviewed by Ryosuke Niwa.
928
929         Use UndoStep::label().
930
931         * WebCoreSupport/WebEditorClient.h:
932         * WebCoreSupport/WebEditorClient.mm:
933         (-[WebUndoStep initWithUndoStep:]):
934         (+[WebUndoStep stepWithUndoStep:]):
935         (WebEditorClient::registerUndoOrRedoStep):
936         (WebEditorClient::registerUndoStep):
937         (WebEditorClient::registerRedoStep):
938
939 2019-01-22  Alex Christensen  <achristensen@webkit.org>
940
941         Move NetworkStorageSession ownership to NetworkProcess
942         https://bugs.webkit.org/show_bug.cgi?id=193580
943
944         Reviewed by Geoff Garen.
945
946         * Misc/WebCache.mm:
947         (+[WebCache clearCachedCredentials]):
948         * Misc/WebDownload.mm:
949         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
950         * Plugins/WebBaseNetscapePluginView.mm:
951         (WebKit::getAuthenticationInfo):
952         * WebCoreSupport/WebFrameNetworkingContext.mm:
953         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
954         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
955         (WebFrameNetworkingContext::storageSession const):
956         * WebView/WebPreferences.mm:
957         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
958         (+[WebPreferences _clearNetworkLoaderSession]):
959         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
960
961 2019-01-22  Daniel Bates  <dabates@apple.com>
962
963         [iOS] Interpret text key commands on keydown and app key commands on keypress
964         https://bugs.webkit.org/show_bug.cgi?id=192897
965         <rdar://problem/46857378>
966
967         Reviewed by Brent Fulgham.
968
969         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
970         is false) and keypress (isCharEvent is true), respectively.
971
972         * WebView/WebHTMLView.mm:
973         (-[WebHTMLView _handleEditingKeyEvent:]):
974
975 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
976
977         [css-logical] Implement flow-relative margin, padding and border shorthands
978         https://bugs.webkit.org/show_bug.cgi?id=188697
979
980         Reviewed by Simon Fraser and Antti Koivisto.
981
982         Add CSSLogicalEnabled runtime flag.
983
984         * WebView/WebPreferenceKeysPrivate.h:
985         * WebView/WebPreferences.mm:
986         (+[WebPreferences initialize]):
987         (-[WebPreferences cssLogicalEnabled]):
988         (-[WebPreferences setCSSLogicalEnabled:]):
989         * WebView/WebPreferencesPrivate.h:
990         * WebView/WebView.mm:
991         (-[WebView _preferencesChanged:]):
992
993 2019-01-15  Darin Adler  <darin@apple.com>
994
995         Use references rather than pointers for register/unregister functions, and more
996         https://bugs.webkit.org/show_bug.cgi?id=175028
997
998         Reviewed by Daniel Bates.
999
1000         * WebCoreSupport/WebKitFullScreenListener.mm:
1001         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1002         functions in Document; pass a reference.
1003         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1004         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1005         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1006         * WebView/WebFullScreenController.mm:
1007         (-[WebFullScreenController enterFullScreen:]): Ditto.
1008         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1009         (-[WebFullScreenController exitFullScreen]): Ditto.
1010         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1011         * WebView/WebFullScreenController.mm:
1012         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1013
1014 2019-01-12  Dan Bernstein  <mitz@apple.com>
1015
1016         [Cocoa] Avoid importing directly from subumbrella frameworks
1017         https://bugs.webkit.org/show_bug.cgi?id=186016
1018         <rdar://problem/40591038>
1019
1020         Reviewed by Sam Weinig.
1021
1022         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1023         * Carbon/CarbonWindowAdapter.mm: Ditto.
1024         * Carbon/CarbonWindowFrame.m: Ditto.
1025         * Carbon/HIViewAdapter.h: Ditto.
1026         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1027           OTHER_CFLAGS_COCOA_TOUCH_NO.
1028         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1029         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1030         * WebView/WebPDFView.h: Ditto.
1031
1032 2019-01-20  Antoine Quint  <graouts@apple.com>
1033
1034         Add a POINTER_EVENTS feature flag
1035         https://bugs.webkit.org/show_bug.cgi?id=193577
1036         <rdar://problem/47408511>
1037
1038         Unreviewed. Also enable Pointer Events for iosmac.
1039
1040         * Configurations/FeatureDefines.xcconfig:
1041
1042 2019-01-19  Antoine Quint  <graouts@apple.com>
1043
1044         Add a POINTER_EVENTS feature flag
1045         https://bugs.webkit.org/show_bug.cgi?id=193577
1046
1047         Reviewed by Dean Jackson.
1048
1049         * Configurations/FeatureDefines.xcconfig:
1050
1051 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1052
1053         Revert r238815, it broke WK1 video fullscreen on Mac
1054         https://bugs.webkit.org/show_bug.cgi?id=193586
1055         <rdar://problem/47358941>
1056
1057         Reviewed by Jer Noble.
1058
1059         * WebView/WebVideoFullscreenController.h: Added.
1060         * WebView/WebVideoFullscreenController.mm: Added.
1061         (SOFT_LINK_CLASS):
1062         (-[WebVideoFullscreenController init]):
1063         (-[WebVideoFullscreenController dealloc]):
1064         (-[WebVideoFullscreenController fullscreenWindow]):
1065         (-[WebVideoFullscreenController windowDidLoad]):
1066         (-[WebVideoFullscreenController videoElement]):
1067         (-[WebVideoFullscreenController setVideoElement:]):
1068         (-[WebVideoFullscreenController clearFadeAnimation]):
1069         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1070         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1071         (-[WebVideoFullscreenController videoElementRect]):
1072         (-[WebVideoFullscreenController applicationDidResignActive:]):
1073         (frameExpandedToRatioOfFrame):
1074         (createBackgroundFullscreenWindow):
1075         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1076         (-[WebVideoFullscreenController enterFullscreen:]):
1077         (-[WebVideoFullscreenController exitFullscreen]):
1078         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1079         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1080         (-[WebVideoFullscreenController _requestExit]):
1081         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1082         (-[WebVideoFullscreenController requestExitFullscreen]):
1083         (-[WebVideoFullscreenController fadeHUDIn]):
1084         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1085         (-[WebVideoFullscreenController rateChanged:]):
1086         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1087         (-[WebVideoFullscreenWindow dealloc]):
1088         (-[WebVideoFullscreenWindow resignFirstResponder]):
1089         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1090         (-[WebVideoFullscreenWindow mouseDown:]):
1091         (-[WebVideoFullscreenWindow cancelOperation:]):
1092         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1093         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1094         (-[WebVideoFullscreenWindow animationDidEnd:]):
1095         (-[WebVideoFullscreenWindow mouseMoved:]):
1096         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1097         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1098         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1099         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1100         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1101         (-[WebVideoFullscreenHUDWindow center]):
1102         (-[WebVideoFullscreenHUDWindow keyDown:]):
1103         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1104         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1105         (-[WebVideoFullscreenHUDWindowController init]):
1106         (-[WebVideoFullscreenHUDWindowController dealloc]):
1107         (-[WebVideoFullscreenHUDWindowController setArea:]):
1108         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1109         (-[WebVideoFullscreenHUDWindowController delegate]):
1110         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1111         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1112         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1113         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1114         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1115         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1116         (createMediaUIControl):
1117         (createControlWithMediaUIControlType):
1118         (createTimeTextField):
1119         (createMediaUIBackgroundView):
1120         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1121         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1122         (-[WebVideoFullscreenHUDWindowController updateTime]):
1123         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1124         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1125         (-[WebVideoFullscreenHUDWindowController currentTime]):
1126         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1127         (-[WebVideoFullscreenHUDWindowController duration]):
1128         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1129         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1130         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1131         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1132         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1133         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1134         (-[WebVideoFullscreenHUDWindowController volume]):
1135         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1136         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1137         (-[WebVideoFullscreenHUDWindowController updateRate]):
1138         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1139         (-[WebVideoFullscreenHUDWindowController playing]):
1140         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1141         (timeToString):
1142         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1143         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1144         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1145         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1146         (-[WebVideoFullscreenHUDWindowController rewind:]):
1147         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1148         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1149         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1150         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1151         * WebView/WebView.mm:
1152         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1153         (-[WebView _exitVideoFullscreen]):
1154
1155 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1156
1157         Get rid of ADVANCED_SPELL_CHECKING
1158         https://bugs.webkit.org/show_bug.cgi?id=193592
1159
1160         Reviewed by Wenson Hsieh.
1161
1162         * WebCoreSupport/WebEditorClient.mm:
1163         (insertionPointFromCurrentSelection):
1164         (WebEditorClient::checkTextOfParagraph):
1165         (WebEditorClient::getGuessesForWord):
1166         (WebEditorClient::requestCandidatesForSelection):
1167         (WebEditorClient::requestCheckingOfString):
1168         * WebView/WebHTMLView.mm:
1169         (-[WebHTMLView insertText:]):
1170
1171 2019-01-18  Jer Noble  <jer.noble@apple.com>
1172
1173         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1174         https://bugs.webkit.org/show_bug.cgi?id=189553
1175
1176         Reviewed by Tim Horton.
1177
1178         * Configurations/Base.xcconfig:
1179         * Configurations/SDKVariant.xcconfig: Added.
1180         * Configurations/WebKitLegacy.xcconfig:
1181
1182 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1183
1184         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1185         <https://webkit.org/b/193568>
1186         <rdar://problem/47381130>
1187
1188         Reviewed by Alex Christensen.
1189
1190         * WebView/WebView.mm:
1191         - Remove unused soft-linking macros.
1192         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1193         (-[WebUITextIndicatorData initWithImage:scale:]):
1194         - Update to use exported PAL functions.
1195
1196 2019-01-17  Truitt Savell  <tsavell@apple.com>
1197
1198         Unreviewed, rolling out r240124.
1199
1200         This commit broke an internal build.
1201
1202         Reverted changeset:
1203
1204         "SDK_VARIANT build destinations should be separate from non-
1205         SDK_VARIANT builds"
1206         https://bugs.webkit.org/show_bug.cgi?id=189553
1207         https://trac.webkit.org/changeset/240124
1208
1209 2019-01-17  Jer Noble  <jer.noble@apple.com>
1210
1211         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1212         https://bugs.webkit.org/show_bug.cgi?id=189553
1213
1214         Reviewed by Tim Horton.
1215
1216         * Configurations/Base.xcconfig:
1217         * Configurations/SDKVariant.xcconfig: Added.
1218         * Configurations/WebKitLegacy.xcconfig:
1219
1220 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1221
1222         Stop using NetworkStorageSession::storageSession in WebCore
1223         https://bugs.webkit.org/show_bug.cgi?id=193529
1224
1225         Reviewed by Tim Horton.
1226
1227         * Misc/WebCache.mm:
1228         (+[WebCache addImageToCache:forURL:forFrame:]):
1229         * WebView/WebView.mm:
1230         (-[WebView _commonInitializationWithFrameName:groupName:]):
1231         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1232
1233 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1234
1235         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1236         https://bugs.webkit.org/show_bug.cgi?id=193368
1237
1238         Reviewed by Geoff Garen.
1239
1240         * Misc/WebCache.mm:
1241         (+[WebCache clearCachedCredentials]):
1242         * Misc/WebDownload.mm:
1243         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1244         * Plugins/WebBaseNetscapePluginView.mm:
1245         (WebKit::getAuthenticationInfo):
1246
1247 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1248
1249         Stop using CookiesStrategy
1250         https://bugs.webkit.org/show_bug.cgi?id=161106
1251
1252         Reviewed by Don Olmstead and Antti Koivisto.
1253
1254         * Misc/WebCache.mm:
1255         (+[WebCache addImageToCache:forURL:forFrame:]):
1256         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1257         (WebKit::NetscapePluginInstanceProxy::getCookies):
1258         (WebKit::NetscapePluginInstanceProxy::setCookies):
1259         * Plugins/WebNetscapePluginView.mm:
1260         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1261         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1262         * WebCoreSupport/WebPlatformStrategies.h:
1263         * WebCoreSupport/WebPlatformStrategies.mm:
1264         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1265         (WebPlatformStrategies::cookiesForDOM): Deleted.
1266         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1267         (WebPlatformStrategies::cookiesEnabled): Deleted.
1268         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1269         (WebPlatformStrategies::getRawCookies): Deleted.
1270         (WebPlatformStrategies::deleteCookie): Deleted.
1271         * WebView/WebView.mm:
1272         (-[WebView _commonInitializationWithFrameName:groupName:]):
1273         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1274
1275 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1276
1277         Cannot tab out of WKWebView on macOS
1278         https://bugs.webkit.org/show_bug.cgi?id=161448
1279         <rdar://problem/28100085>
1280
1281         Reviewed by Dean Jackson.
1282
1283         * WebCoreSupport/WebChromeClient.mm:
1284         * WebView/WebView.mm:
1285         Make use of SPI headers.
1286
1287 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1288
1289         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1290         r239913, and r239914.
1291         https://bugs.webkit.org/show_bug.cgi?id=193407
1292
1293         These revisions caused an internal failure (Requested by
1294         Truitt on #webkit).
1295
1296         Reverted changesets:
1297
1298         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1299         https://bugs.webkit.org/show_bug.cgi?id=186016
1300         https://trac.webkit.org/changeset/239901
1301
1302         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1303         https://trac.webkit.org/changeset/239909
1304
1305         "Tried to fix the build."
1306         https://trac.webkit.org/changeset/239910
1307
1308         "Fixed iOS builds after r239910."
1309         https://trac.webkit.org/changeset/239912
1310
1311         "More build fixing."
1312         https://trac.webkit.org/changeset/239913
1313
1314         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1315         https://trac.webkit.org/changeset/239914
1316
1317 2019-01-14  Mark Lam  <mark.lam@apple.com>
1318
1319         Re-enable ability to build --cloop builds.
1320         https://bugs.webkit.org/show_bug.cgi?id=192955
1321         <rdar://problem/46882363>
1322
1323         Reviewed by Saam barati and Keith Miller.
1324
1325         * Configurations/FeatureDefines.xcconfig:
1326
1327 2019-01-13  Dan Bernstein  <mitz@apple.com>
1328
1329         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1330
1331         Patch by Keith Rollin.
1332
1333         * WebView/PDFViewSPI.h:
1334
1335 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1336
1337         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1338         https://bugs.webkit.org/show_bug.cgi?id=191655
1339         rdar://problem/46074680
1340
1341         Reviewed by Megan Gardner.
1342
1343         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1344         * WebView/WebView.mm:
1345         (-[WebView _effectiveAppearanceIsDark]):
1346
1347 2019-01-12  Dan Bernstein  <mitz@apple.com>
1348
1349         [Cocoa] Avoid importing directly from subumbrella frameworks
1350         https://bugs.webkit.org/show_bug.cgi?id=186016
1351         <rdar://problem/40591038>
1352
1353         Reviewed by Sam Weinig.
1354
1355         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1356         * Carbon/CarbonWindowAdapter.mm: Ditto.
1357         * Carbon/CarbonWindowFrame.m: Ditto.
1358         * Carbon/HIViewAdapter.h: Ditto.
1359         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1360           OTHER_CFLAGS_COCOA_TOUCH_NO.
1361         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1362         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1363         * WebView/WebPDFView.h: Ditto.
1364
1365 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1366
1367         Enable visual viewport API by default
1368         https://bugs.webkit.org/show_bug.cgi?id=193376
1369
1370         Reviewed by Simon Fraser.
1371
1372         * WebView/WebPreferences.mm:
1373         (+[WebPreferences initialize]):
1374
1375 2019-01-11  John Wilander  <wilander@apple.com>
1376
1377         Compile out Web API Statistics Collection
1378         https://bugs.webkit.org/show_bug.cgi?id=193370
1379         <rdar://problem/45388584>
1380
1381         Reviewed by Brent Fulgham.
1382
1383         * Configurations/FeatureDefines.xcconfig:
1384             Defined ENABLE_WEB_API_STATISTICS, off by default.
1385
1386 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1387
1388         Stop using NetworkStorageSession in WebProcess
1389         https://bugs.webkit.org/show_bug.cgi?id=193236
1390
1391         Reviewed by Don Olmstead.
1392
1393         * WebCoreSupport/WebFrameNetworkingContext.h:
1394         * WebCoreSupport/WebFrameNetworkingContext.mm:
1395         (WebFrameNetworkingContext::storageSession const):
1396         * WebCoreSupport/WebPlatformStrategies.h:
1397         * WebCoreSupport/WebPlatformStrategies.mm:
1398         (WebPlatformStrategies::cookiesForDOM):
1399         (WebPlatformStrategies::setCookiesFromDOM):
1400         (WebPlatformStrategies::cookiesEnabled):
1401         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1402         (WebPlatformStrategies::getRawCookies):
1403         (WebPlatformStrategies::deleteCookie):
1404         * WebView/WebView.mm:
1405         (-[WebView _cachedResponseForURL:]):
1406         (-[WebView _clearCredentials]):
1407
1408 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1409
1410         Unreviewed, rolling out r239727.
1411
1412         Broke API tests
1413
1414         Reverted changeset:
1415
1416         "Stop using NetworkStorageSession in WebProcess"
1417         https://bugs.webkit.org/show_bug.cgi?id=193236
1418         https://trac.webkit.org/changeset/239727
1419
1420 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1421
1422         Stop using NetworkStorageSession in WebProcess
1423         https://bugs.webkit.org/show_bug.cgi?id=193236
1424
1425         Reviewed by Don Olmstead.
1426
1427         * WebCoreSupport/WebFrameNetworkingContext.h:
1428         * WebCoreSupport/WebFrameNetworkingContext.mm:
1429         (WebFrameNetworkingContext::storageSession const):
1430         * WebView/WebView.mm:
1431         (-[WebView _cachedResponseForURL:]):
1432         (-[WebView _clearCredentials]):
1433
1434 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1435
1436         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1437         <https://webkit.org/b/193056>
1438
1439         Reviewed by Alex Christensen.
1440
1441         * Plugins/Hosted/NetscapePluginHostProxy.h:
1442         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1443         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1444         (WebKit::NetscapePluginInstanceProxy::enumerate):
1445         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1446         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1447         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1448         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1449         * Plugins/Hosted/ProxyInstance.mm:
1450         (WebKit::ProxyInstance::invoke):
1451         * WebCoreSupport/WebGeolocationClient.mm:
1452         * WebView/WebDataSource.mm:
1453         (-[WebDataSource _receivedData:]):
1454         * WebView/WebView.mm:
1455         (-[WebView _cachedResponseForURL:]):
1456         - Remove '*' from RetainPtr<> type.
1457
1458 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1459
1460         Progress towards fixing Mac CMake build
1461         https://bugs.webkit.org/show_bug.cgi?id=193105
1462
1463         Reviewed by Don Olmstead.
1464
1465         * WebKitPrefix.h:
1466
1467 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1468
1469         Web Inspector: Use save sheet instead of dialog where possible
1470         https://bugs.webkit.org/show_bug.cgi?id=193160
1471         <rdar://problem/37399759>
1472
1473         Reviewed by Devin Rousso.
1474
1475         * WebCoreSupport/WebInspectorClient.mm:
1476         (WebInspectorFrontendClient::save):
1477
1478 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1479
1480         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1481         https://bugs.webkit.org/show_bug.cgi?id=193129
1482
1483         Reviewed by Tim Horton.
1484
1485         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1486
1487         * WebCoreSupport/WebEditorClient.mm:
1488         (WebEditorClient::registerUndoOrRedoStep):
1489         (undoNameForEditAction): Deleted.
1490
1491 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1492
1493         Add support for using the current text selection as the find string on iOS
1494         https://bugs.webkit.org/show_bug.cgi?id=193034
1495         <rdar://problem/45138739>
1496
1497         Reviewed by Tim Horton.
1498
1499         Add a method stub for WebKitLegacy.
1500
1501         * WebCoreSupport/WebEditorClient.h:
1502
1503 2019-01-01  Jeff Miller  <jeffm@apple.com>
1504
1505         Update user-visible copyright strings to include 2019
1506         https://bugs.webkit.org/show_bug.cgi?id=192811
1507
1508         Reviewed by Mark Lam.
1509
1510         * Info.plist:
1511
1512 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1513
1514         Use Ref<> as much as possible
1515         https://bugs.webkit.org/show_bug.cgi?id=192808
1516
1517         Reviewed by Alex Christensen.
1518
1519         * DOM/DOM.mm:
1520         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1521         * Plugins/Hosted/NetscapePluginHostManager.mm:
1522         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1523         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1524         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1525         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1526         * Plugins/WebNetscapePluginView.mm:
1527         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1528         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1529         * WebCoreSupport/WebContextMenuClient.mm:
1530         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1531         * WebCoreSupport/WebFrameLoaderClient.mm:
1532         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1533         * WebView/WebFrame.mm:
1534         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1535         * WebView/WebHTMLView.mm:
1536         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1537         * WebView/WebView.mm:
1538         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1539         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1540
1541 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1542
1543         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1544         https://bugs.webkit.org/show_bug.cgi?id=192821
1545
1546         Reviewed by Chris Dumez.
1547
1548         When a window becomes occluded, the window server informs the application.
1549         This should be used to suspend any work that is not visible by the user.
1550
1551         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1552         In some cases, that lead to performance impact (see radar).
1553
1554         This patch adds an observer for the occlusion notification. I tried to stick
1555         with the same names used by WebKit2.
1556
1557         * WebView/WebView.mm:
1558         (-[WebView _isViewVisible]):
1559         (-[WebView addWindowObserversForWindow:]):
1560         (-[WebView removeWindowObservers]):
1561         (-[WebView _windowDidChangeOcclusionState:]):
1562
1563 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1564
1565         [WebAuthN] Add a runtime flag for local authenticator
1566         https://bugs.webkit.org/show_bug.cgi?id=192792
1567         <rdar://problem/46798738>
1568
1569         Reviewed by Brent Fulgham.
1570
1571         * WebView/WebPreferenceKeysPrivate.h:
1572         * WebView/WebPreferences.mm:
1573         (+[WebPreferences initialize]):
1574         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1575         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1576         * WebView/WebPreferencesPrivate.h:
1577         * WebView/WebView.mm:
1578         (-[WebView _preferencesChanged:]):
1579
1580 2018-12-20  Chris Dumez  <cdumez@apple.com>
1581
1582         Use Optional::valueOr() instead of Optional::value_or()
1583         https://bugs.webkit.org/show_bug.cgi?id=192933
1584
1585         Reviewed by Geoffrey Garen.
1586
1587         * WebCoreSupport/WebSecurityOrigin.mm:
1588         (-[WebSecurityOrigin port]):
1589
1590 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1591
1592         Unreviewed, rolling out r239417.
1593
1594         Introduced two API test failures on macOS.
1595
1596         Reverted changeset:
1597
1598         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1599         occlusion changes"
1600         https://bugs.webkit.org/show_bug.cgi?id=192821
1601         https://trac.webkit.org/changeset/239417
1602
1603 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1604
1605         WKWebView default UA doesn't freeze the build number
1606         https://bugs.webkit.org/show_bug.cgi?id=192809
1607         <rdar://problem/44687185>
1608
1609         Reviewed by Andy Estes.
1610
1611         Always reports the frozen build number.
1612
1613         * WebView/WebView.mm:
1614         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1615         actual build number through this method call.
1616         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1617
1618 2018-12-19  Chris Dumez  <cdumez@apple.com>
1619
1620         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1621         https://bugs.webkit.org/show_bug.cgi?id=192728
1622         <rdar://problem/46746779>
1623
1624         Reviewed by Geoff Garen.
1625
1626         * DOM/*:
1627         * Plugins/*:
1628         * WebCoreSupport/*:
1629         * WebView/*:
1630
1631 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1632
1633         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1634         https://bugs.webkit.org/show_bug.cgi?id=192821
1635
1636         Reviewed by Chris Dumez.
1637
1638         When a window becomes occluded, the window server informs the application.
1639         This should be used to suspend any work that is not visible by the user.
1640
1641         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1642         In some cases, that lead to performance impact (see radar).
1643
1644         This patch adds an observer for the occlusion notification. I tried to stick
1645         with the same names used by WebKit2.
1646
1647         * WebView/WebView.mm:
1648         (-[WebView _isViewVisible]):
1649         (-[WebView addWindowObserversForWindow:]):
1650         (-[WebView removeWindowObservers]):
1651         (-[WebView _windowDidChangeOcclusionState:]):
1652
1653 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1654
1655         Allow clients to set the navigator platform
1656         https://bugs.webkit.org/show_bug.cgi?id=192735
1657
1658         Reviewed by Tim Horton.
1659
1660         Add stubs to fill out the added functionality in FrameLoaderClient.
1661
1662         * WebCoreSupport/WebFrameLoaderClient.h:
1663         * WebCoreSupport/WebFrameLoaderClient.mm:
1664         (WebFrameLoaderClient::navigatorPlatform):
1665
1666 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1667
1668         offsetLeft and offsetParent should adjust across shadow boundaries
1669         https://bugs.webkit.org/show_bug.cgi?id=157437
1670         <rdar://problem/26154021>
1671
1672         Reviewed by Simon Fraser.
1673
1674         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1675
1676         * DOM/DOMElement.mm:
1677         (-[DOMElement offsetLeft]):
1678         (-[DOMElement offsetTop]):
1679         (-[DOMElement offsetParent]):
1680
1681 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1682
1683         Unreviewed build fix.
1684
1685         * WebView/WebFrame.mm:
1686         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1687
1688 2018-12-15  Darin Adler  <darin@apple.com>
1689
1690         Use warning-ignoring macros more consistently and simply
1691         https://bugs.webkit.org/show_bug.cgi?id=192743
1692
1693         Reviewed by Mark Lam.
1694
1695         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1696         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1697         compilers in Objective-C++ code.
1698
1699         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1700         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1701         accomodate non-clang compilers here. Also use #pragma once, add a missing
1702         "explicit" and fix conditionals.
1703
1704 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1705
1706         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1707         https://bugs.webkit.org/show_bug.cgi?id=192653
1708
1709         Reviewed by Wenson Hsieh.
1710
1711         * WebView/WebHTMLView.mm:
1712         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1713
1714 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1715
1716         Implement feature flag for CSS Typed OM
1717         https://bugs.webkit.org/show_bug.cgi?id=192610
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         * Configurations/FeatureDefines.xcconfig:
1722
1723 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1724
1725         WebCore shouldn't have a Objective-C class named NSCursor
1726         https://bugs.webkit.org/show_bug.cgi?id=192602
1727         <rdar://problem/46615532>
1728
1729         Reviewed by Wenson Hsieh.
1730
1731         * WebView/WebFrameView.mm:
1732         (-[WebFrameView keyDown:keyDown:]):
1733         * WebView/WebHTMLView.mm:
1734         (-[WebHTMLView keyDown:]):
1735         (-[WebHTMLView performKeyEquivalent:]):
1736         Only use NSCursor on macOS.
1737
1738 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1739
1740         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1741         https://bugs.webkit.org/show_bug.cgi?id=192573
1742
1743         Reviewed by Simon Fraser.
1744
1745         * Configurations/FeatureDefines.xcconfig:
1746
1747 2018-12-10  Antti Koivisto  <antti@apple.com>
1748
1749         Rename "forced style recalc" to "full style rebuild"
1750         https://bugs.webkit.org/show_bug.cgi?id=192572
1751
1752         Reviewed by Zalan Bujtas.
1753
1754         * WebView/WebHTMLView.mm:
1755         (-[WebHTMLView setNeedsToApplyStyles:]):
1756
1757 2018-12-10  Darin Adler  <darin@apple.com>
1758
1759         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1760         https://bugs.webkit.org/show_bug.cgi?id=192533
1761         rdar://problem/45732710
1762
1763         Reviewed by Anders Carlsson.
1764
1765         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1766         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1767
1768 2018-12-10  Darin Adler  <darin@apple.com>
1769
1770         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1771         https://bugs.webkit.org/show_bug.cgi?id=192532
1772         rdar://problem/45731047
1773
1774         Reviewed by Chris Dumez.
1775
1776         * Plugins/Hosted/NetscapePluginHostManager.mm:
1777         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1778         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1779         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1780
1781 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1782
1783         Turn WritingDirection into an enum class
1784         https://bugs.webkit.org/show_bug.cgi?id=192401
1785         Work towards <rdar://problem/42075638>
1786
1787         Reviewed by Dan Bernstein.
1788
1789         Change WritingDirection from an enum to an enum class. No change in behavior.
1790
1791         * WebView/WebHTMLView.mm:
1792         (-[WebHTMLView toggleBaseWritingDirection:]):
1793         (-[WebHTMLView changeBaseWritingDirection:]):
1794         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1795
1796 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1797
1798         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1799         https://bugs.webkit.org/show_bug.cgi?id=192272
1800
1801         Reviewed by Brady Eidson.
1802
1803         * WebCoreSupport/WebFrameLoaderClient.h:
1804         * WebCoreSupport/WebFrameLoaderClient.mm:
1805         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1806
1807 2018-12-03  Jer Noble  <jer.noble@apple.com>
1808
1809         Get rid of old, dead Mac video fullscreen code.
1810         https://bugs.webkit.org/show_bug.cgi?id=192315
1811
1812         Reviewed by Eric Carlson.
1813
1814         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1815         is no longer supported in the Mac port.
1816
1817         * WebView/WebVideoFullscreenController.h: Removed.
1818         * WebView/WebVideoFullscreenController.mm: Removed.
1819         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1820         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1821         * WebView/WebView.mm:
1822         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1823         (-[WebView _exitVideoFullscreen]):
1824
1825 2018-12-03  Daniel Bates  <dabates@apple.com>
1826
1827         [iOS] Do not handle key events that are key commands
1828         https://bugs.webkit.org/show_bug.cgi?id=191608
1829         <rdar://problem/46046013>
1830
1831         Reviewed by Ryosuke Niwa.
1832
1833         A key down event may be associated with a key command. If it is then we want to execute the
1834         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1835         event as a key command to find out.
1836
1837         * WebView/WebHTMLView.mm:
1838         (-[WebHTMLView _handleEditingKeyEvent:]):
1839
1840 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1841
1842         Add a runtime feature flag for LayoutFormattingContext.
1843         https://bugs.webkit.org/show_bug.cgi?id=192280
1844
1845         Reviewed by Simon Fraser.
1846
1847         * Configurations/FeatureDefines.xcconfig:
1848
1849 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1850
1851         Move URL from WebCore to WTF
1852         https://bugs.webkit.org/show_bug.cgi?id=190234
1853
1854         Reviewed by Keith Miller.
1855
1856         * DOM/DOMAttr.mm:
1857         * DOM/DOMBlob.mm:
1858         * DOM/DOMCSSCharsetRule.mm:
1859         * DOM/DOMCSSImportRule.mm:
1860         * DOM/DOMCSSMediaRule.mm:
1861         * DOM/DOMCSSPageRule.mm:
1862         * DOM/DOMCSSPrimitiveValue.mm:
1863         * DOM/DOMCSSRule.mm:
1864         * DOM/DOMCSSStyleDeclaration.mm:
1865         * DOM/DOMCSSStyleRule.mm:
1866         * DOM/DOMCSSStyleSheet.mm:
1867         * DOM/DOMCSSValue.mm:
1868         * DOM/DOMCharacterData.mm:
1869         * DOM/DOMCounter.mm:
1870         * DOM/DOMDocument.mm:
1871         * DOM/DOMDocumentFragment.mm:
1872         * DOM/DOMDocumentType.mm:
1873         * DOM/DOMEvent.mm:
1874         * DOM/DOMFile.mm:
1875         * DOM/DOMHTMLAnchorElement.mm:
1876         * DOM/DOMHTMLAppletElement.mm:
1877         * DOM/DOMHTMLAreaElement.mm:
1878         * DOM/DOMHTMLBRElement.mm:
1879         * DOM/DOMHTMLBaseElement.mm:
1880         * DOM/DOMHTMLBaseFontElement.mm:
1881         * DOM/DOMHTMLBodyElement.mm:
1882         * DOM/DOMHTMLButtonElement.mm:
1883         * DOM/DOMHTMLCanvasElement.mm:
1884         * DOM/DOMHTMLCollection.mm:
1885         * DOM/DOMHTMLDivElement.mm:
1886         * DOM/DOMHTMLDocument.mm:
1887         * DOM/DOMHTMLElement.mm:
1888         * DOM/DOMHTMLEmbedElement.mm:
1889         * DOM/DOMHTMLFieldSetElement.mm:
1890         * DOM/DOMHTMLFontElement.mm:
1891         * DOM/DOMHTMLFormElement.mm:
1892         * DOM/DOMHTMLFrameElement.mm:
1893         * DOM/DOMHTMLFrameSetElement.mm:
1894         * DOM/DOMHTMLHRElement.mm:
1895         * DOM/DOMHTMLHeadElement.mm:
1896         * DOM/DOMHTMLHeadingElement.mm:
1897         * DOM/DOMHTMLHtmlElement.mm:
1898         * DOM/DOMHTMLIFrameElement.mm:
1899         * DOM/DOMHTMLImageElement.mm:
1900         * DOM/DOMHTMLInputElement.mm:
1901         * DOM/DOMHTMLLIElement.mm:
1902         * DOM/DOMHTMLLabelElement.mm:
1903         * DOM/DOMHTMLLegendElement.mm:
1904         * DOM/DOMHTMLLinkElement.mm:
1905         * DOM/DOMHTMLMapElement.mm:
1906         * DOM/DOMHTMLMarqueeElement.mm:
1907         * DOM/DOMHTMLMediaElement.mm:
1908         * DOM/DOMHTMLMetaElement.mm:
1909         * DOM/DOMHTMLModElement.mm:
1910         * DOM/DOMHTMLOListElement.mm:
1911         * DOM/DOMHTMLObjectElement.mm:
1912         * DOM/DOMHTMLOptGroupElement.mm:
1913         * DOM/DOMHTMLOptionElement.mm:
1914         * DOM/DOMHTMLOptionsCollection.mm:
1915         * DOM/DOMHTMLParagraphElement.mm:
1916         * DOM/DOMHTMLParamElement.mm:
1917         * DOM/DOMHTMLQuoteElement.mm:
1918         * DOM/DOMHTMLScriptElement.mm:
1919         * DOM/DOMHTMLSelectElement.mm:
1920         * DOM/DOMHTMLStyleElement.mm:
1921         * DOM/DOMHTMLTableCaptionElement.mm:
1922         * DOM/DOMHTMLTableCellElement.mm:
1923         * DOM/DOMHTMLTableColElement.mm:
1924         * DOM/DOMHTMLTableElement.mm:
1925         * DOM/DOMHTMLTableRowElement.mm:
1926         * DOM/DOMHTMLTableSectionElement.mm:
1927         * DOM/DOMHTMLTitleElement.mm:
1928         * DOM/DOMHTMLUListElement.mm:
1929         * DOM/DOMHTMLVideoElement.mm:
1930         * DOM/DOMKeyboardEvent.mm:
1931         * DOM/DOMMediaList.mm:
1932         * DOM/DOMMouseEvent.mm:
1933         * DOM/DOMMutationEvent.mm:
1934         * DOM/DOMNamedNodeMap.mm:
1935         * DOM/DOMProcessingInstruction.mm:
1936         * DOM/DOMRange.mm:
1937         * DOM/DOMStyleSheet.mm:
1938         * DOM/DOMText.mm:
1939         * DOM/DOMTextEvent.mm:
1940         * DOM/DOMTokenList.mm:
1941         * DOM/DOMUIEvent.mm:
1942         * DOM/DOMXPathResult.mm:
1943         * History/WebHistoryItem.mm:
1944         * Misc/WebNSURLExtras.mm:
1945         (-[NSURL _web_userVisibleString]):
1946         (-[NSURL _web_URLByRemovingUserInfo]):
1947         (-[NSURL _web_dataForURLComponentType:]):
1948         (-[NSURL _web_schemeData]):
1949         (-[NSURL _web_hostData]):
1950         * Misc/WebUserContentURLPattern.mm:
1951         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1952         * Plugins/WebNetscapePluginStream.h:
1953         (WebNetscapePluginStream::setRequestURL):
1954         * WebCoreSupport/WebChromeClient.h:
1955         * WebCoreSupport/WebChromeClient.mm:
1956         (WebChromeClient::signedPublicKeyAndChallengeString const):
1957         * WebCoreSupport/WebContextMenuClient.h:
1958         * WebCoreSupport/WebContextMenuClient.mm:
1959         * WebCoreSupport/WebDragClient.h:
1960         * WebCoreSupport/WebFrameLoaderClient.h:
1961         * WebCoreSupport/WebFrameLoaderClient.mm:
1962         (WebFrameLoaderClient::updateGlobalHistory):
1963         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1964         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1965         (WebPaymentCoordinatorClient::showPaymentUI):
1966         * WebCoreSupport/WebPlatformStrategies.h:
1967         * WebCoreSupport/WebPlatformStrategies.mm:
1968         (WebPlatformStrategies::readURLFromPasteboard):
1969         * WebCoreSupport/WebPluginInfoProvider.h:
1970         * WebCoreSupport/WebPluginInfoProvider.mm:
1971         (WebPluginInfoProvider::webVisiblePluginInfo):
1972         * WebCoreSupport/WebSecurityOrigin.mm:
1973         * WebCoreSupport/WebVisitedLinkStore.h:
1974         * WebView/WebDataSource.mm:
1975         * WebView/WebFrame.mm:
1976         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1977         * WebView/WebImmediateActionController.mm:
1978         (-[WebImmediateActionController _defaultAnimationController]):
1979         * WebView/WebPDFView.mm:
1980         * WebView/WebScriptDebugger.mm:
1981         * WebView/WebViewInternal.h:
1982
1983 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1984
1985         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1986         https://bugs.webkit.org/show_bug.cgi?id=192197
1987
1988         Reviewed by Jiewen Tan.
1989
1990         * Configurations/FeatureDefines.xcconfig:
1991         * WebCoreSupport/WebChromeClient.h:
1992         * WebCoreSupport/WebChromeClient.mm:
1993
1994 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1995
1996         Remove dead code from an earlier attempt at implementing safe browsing
1997         https://bugs.webkit.org/show_bug.cgi?id=192067
1998
1999         Reviewed by Chris Dumez.
2000
2001         * WebCoreSupport/WebFrameLoaderClient.h:
2002         * WebCoreSupport/WebFrameLoaderClient.mm:
2003         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2004
2005 2018-11-27  Mark Lam  <mark.lam@apple.com>
2006
2007         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2008         https://bugs.webkit.org/show_bug.cgi?id=192055
2009         <rdar://problem/46288783>
2010
2011         Reviewed by Saam Barati.
2012
2013         * Configurations/FeatureDefines.xcconfig:
2014
2015 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2016
2017         Make it possible to insert editable images with a gesture
2018         https://bugs.webkit.org/show_bug.cgi?id=191937
2019
2020         Reviewed by Wenson Hsieh.
2021
2022         * WebCoreSupport/WebEditorClient.mm:
2023         (undoNameForEditAction):
2024         Add a undo name.
2025
2026 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2027
2028         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2029         https://bugs.webkit.org/show_bug.cgi?id=191945
2030
2031         Reviewed by Anders Carlsson.
2032
2033         * WebCoreSupport/WebEditorClient.mm:
2034         (undoNameForEditAction):
2035
2036 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2037
2038         Enable drag and drop support for iOSMac
2039         https://bugs.webkit.org/show_bug.cgi?id=191818
2040         <rdar://problem/43907454>
2041
2042         Reviewed by Dean Jackson.
2043
2044         * Configurations/FeatureDefines.xcconfig:
2045
2046 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2047
2048         Address post-review feedback after r238438
2049         https://bugs.webkit.org/show_bug.cgi?id=191913
2050
2051         Reviewed by Ryosuke Niwa.
2052
2053         * WebView/WebFrame.mm:
2054         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2055         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2056         * WebView/WebView.mm:
2057         (-[WebView setSelectedDOMRange:affinity:]):
2058
2059 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2060
2061         Web Inspector: "Reload Web Inspector" button no longer partially works
2062         https://bugs.webkit.org/show_bug.cgi?id=191773
2063         <rdar://problem/46139932>
2064
2065         Reviewed by Devin Rousso.
2066
2067         * WebCoreSupport/WebInspectorClient.h:
2068         * WebCoreSupport/WebInspectorClient.mm:
2069         (WebInspectorFrontendClient::reopen):
2070
2071 2018-11-17  Devin Rousso  <drousso@apple.com>
2072
2073         Web Inspector: Network: add button to show system certificate dialog
2074         https://bugs.webkit.org/show_bug.cgi?id=191458
2075         <rdar://problem/45977019>
2076
2077         Reviewed by Joseph Pecoraro.
2078
2079         * WebCoreSupport/WebInspectorClient.h:
2080         * WebCoreSupport/WebInspectorClient.mm:
2081         (WebInspectorFrontendClient::showCertificate): Added.
2082
2083         * Configurations/WebKitLegacy.xcconfig:
2084
2085 2018-11-15  Truitt Savell  <tsavell@apple.com>
2086
2087         Unreviewed, rolling out r238244.
2088
2089         Caused High Sierra test runs to fail early with 50 crashes and
2090         casued 25 API failures.
2091
2092         Reverted changeset:
2093
2094         "[css-logical] Implement flow-relative margin, padding and
2095         border shorthands"
2096         https://bugs.webkit.org/show_bug.cgi?id=188697
2097         https://trac.webkit.org/changeset/238244
2098
2099 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2100
2101         [css-logical] Implement flow-relative margin, padding and border shorthands
2102         https://bugs.webkit.org/show_bug.cgi?id=188697
2103
2104         Reviewed by Simon Fraser and Antti Koivisto.
2105
2106         Add CSSLogicalEnabled runtime flag.
2107
2108         * WebView/WebPreferenceKeysPrivate.h:
2109         * WebView/WebPreferences.mm:
2110         (+[WebPreferences initialize]):
2111         (-[WebPreferences cssLogicalEnabled]):
2112         (-[WebPreferences setCSSLogicalEnabled:]):
2113         * WebView/WebPreferencesPrivate.h:
2114         * WebView/WebView.mm:
2115         (-[WebView _preferencesChanged:]):
2116
2117 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2118
2119         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2120         https://bugs.webkit.org/show_bug.cgi?id=191612
2121
2122         Reviewed by Matt Baker.
2123
2124         * WebCoreSupport/WebInspectorClient.mm:
2125         (-[WebInspectorWindowController destroyInspectorView]):
2126
2127 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2128
2129         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2130         https://bugs.webkit.org/show_bug.cgi?id=191494
2131         <rdar://problem/45469854>
2132
2133         Reviewed by Devin Rousso.
2134
2135         * WebCoreSupport/WebInspectorClient.h:
2136         WebKitLegacy will still have remote inspection of the Page directly.
2137
2138 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2139
2140         Make compositing updates incremental
2141         https://bugs.webkit.org/show_bug.cgi?id=90342
2142
2143         Reviewed by Antti Koivisto.
2144
2145         Fix spelling error.
2146
2147         * WebView/WebView.mm:
2148         (-[WebView _setMediaLayer:forPluginView:]):
2149
2150 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2151
2152         Implement a new edit command to change the enclosing list type
2153         https://bugs.webkit.org/show_bug.cgi?id=191487
2154         <rdar://problem/45955922>
2155
2156         Reviewed by Ryosuke Niwa.
2157
2158         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2159
2160         * WebCoreSupport/WebEditorClient.mm:
2161         (undoNameForEditAction):
2162
2163 2018-11-11  Daniel Bates  <dabates@apple.com>
2164
2165         [iOS] Draw caps lock indicator in password fields
2166         https://bugs.webkit.org/show_bug.cgi?id=190565
2167         <rdar://problem/45262343>
2168
2169         Reviewed by Dean Jackson.
2170
2171         Update the caps lock state when a hardware keyboard is attached or detached.
2172
2173         * WebView/WebHTMLView.mm:
2174         (hardwareKeyboardAvailabilityChangedCallback): Added.
2175         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2176         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2177
2178 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2179
2180         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2181         https://bugs.webkit.org/show_bug.cgi?id=191492
2182
2183         Reviewed by Alex Christensen.
2184
2185         * Carbon/HIWebView.mm:
2186         * Misc/WebNSFileManagerExtras.mm:
2187         * Misc/WebNSURLExtras.mm:
2188         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2189         * Plugins/WebBasePluginPackage.mm:
2190         * Plugins/WebPluginContainerCheck.mm:
2191         * WebCoreSupport/WebCachedFramePlatformData.h:
2192         * WebCoreSupport/WebDeviceOrientationClient.mm:
2193         * WebView/WebDelegateImplementationCaching.mm:
2194         * WebView/WebHTMLView.mm:
2195         * WebView/WebPDFRepresentation.mm:
2196         * WebView/WebPolicyDelegate.mm:
2197         * WebView/WebView.mm:
2198
2199 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2200
2201         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2202         https://bugs.webkit.org/show_bug.cgi?id=191492
2203
2204         Reviewed by Alex Christensen.
2205
2206         * Carbon/HIWebView.mm:
2207         (UpdateCommandStatus):
2208         * Misc/WebNSFileManagerExtras.mm:
2209         * Misc/WebNSURLExtras.mm:
2210         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2211         * Plugins/WebBasePluginPackage.mm:
2212         * Plugins/WebPluginContainerCheck.mm:
2213         (-[WebPluginContainerCheck _continueWithPolicy:]):
2214         * WebCoreSupport/WebCachedFramePlatformData.h:
2215         (WebCachedFramePlatformData::clear):
2216         * WebCoreSupport/WebDeviceOrientationClient.mm:
2217         (WebDeviceOrientationClient::getProvider const):
2218         * WebView/WebDelegateImplementationCaching.mm:
2219         (CallDelegate):
2220         (CallDelegateReturningBoolean):
2221         (CallResourceLoadDelegateReturningBoolean):
2222         (CallFormDelegate):
2223         (CallFormDelegateReturningBoolean):
2224         * WebView/WebHTMLView.mm:
2225         * WebView/WebPDFRepresentation.mm:
2226         * WebView/WebPolicyDelegate.mm:
2227         (-[WebPolicyDecisionListener _usePolicy:]):
2228         * WebView/WebView.mm:
2229
2230 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2231
2232         Unreviewed, rolling out r238047.
2233
2234         Introduced layout test failures on iOS simulator.
2235
2236         Reverted changeset:
2237
2238         "[iOS] Draw caps lock indicator in password fields"
2239         https://bugs.webkit.org/show_bug.cgi?id=190565
2240         https://trac.webkit.org/changeset/238047
2241
2242 2018-11-09  Antti Koivisto  <antti@apple.com>
2243
2244         Use OptionSet for layout milestones
2245         https://bugs.webkit.org/show_bug.cgi?id=191470
2246
2247         Reviewed by Dean Jackson.
2248
2249         * WebCoreSupport/WebFrameLoaderClient.h:
2250         * WebCoreSupport/WebFrameLoaderClient.mm:
2251         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2252         * WebView/WebView.mm:
2253         (coreLayoutMilestones):
2254         (kitLayoutMilestones):
2255         (-[WebView _cacheFrameLoadDelegateImplementations]):
2256         * WebView/WebViewInternal.h:
2257
2258 2018-11-09  Daniel Bates  <dabates@apple.com>
2259
2260         [iOS] Draw caps lock indicator in password fields
2261         https://bugs.webkit.org/show_bug.cgi?id=190565
2262         <rdar://problem/45262343>
2263
2264         Reviewed by Dean Jackson.
2265
2266         Update the caps lock state when a hardware keyboard is attached or detached.
2267
2268         * WebView/WebHTMLView.mm:
2269         (hardwareKeyboardAvailabilityChangedCallback): Added.
2270         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2271         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2272
2273 2018-11-09  Daniel Bates  <dabates@apple.com>
2274
2275         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2276         action when forward delete is pressed outside a text field
2277         https://bugs.webkit.org/show_bug.cgi?id=190566
2278         <rdar://problem/45262367>
2279
2280         Reviewed by Wenson Hsieh.
2281
2282         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2283         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2284         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2285
2286         * WebView/WebHTMLView.mm:
2287         (-[WebHTMLView _handleEditingKeyEvent:]):
2288
2289 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2290
2291         Adopt Reveal Framework to replace Lookup
2292         https://bugs.webkit.org/show_bug.cgi?id=191097
2293         <rdar://problem/45924508>
2294
2295         Reviewed by Tim Horton.
2296
2297         Pass in what it needed to clear the textIndicators. This is better than
2298         the current notification structure.
2299
2300         * WebView/WebView.mm:
2301         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2302         (-[WebView _prepareForDictionaryLookup]):
2303
2304 2018-11-06  Justin Fan  <justin_fan@apple.com>
2305
2306         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2307         https://bugs.webkit.org/show_bug.cgi?id=191291
2308
2309         Reviewed by Myles Maxfield.
2310
2311         Properly disable WEBGPU on all non-Metal platforms for now.
2312
2313         * Configurations/FeatureDefines.xcconfig:
2314
2315 2018-11-02  Daniel Bates  <dabates@apple.com>
2316
2317         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2318         https://bugs.webkit.org/show_bug.cgi?id=190487
2319
2320         Reviewed by Tim Horton.
2321
2322         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2323         allow the default handling.
2324
2325         * WebView/WebHTMLView.mm:
2326         (-[WebHTMLView _handleEditingKeyEvent:]):
2327
2328 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2329
2330         Add a storage limit for IndexedDB
2331         https://bugs.webkit.org/show_bug.cgi?id=190598
2332         <rdar://problem/44654715>
2333
2334         Reviewed by Chris Dumez.
2335
2336         * Storage/WebDatabaseManager.mm:
2337         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2338         * Storage/WebDatabaseManagerPrivate.h:
2339
2340 2018-10-31  Antti Koivisto  <antti@apple.com>
2341
2342         Remove LayerFlushScheduler
2343         https://bugs.webkit.org/show_bug.cgi?id=191103
2344
2345         Reviewed by Anders Carlsson.
2346
2347         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2348         all the virtual cruft.
2349
2350         * WebView/WebViewData.h:
2351         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2352         (): Deleted.
2353         * WebView/WebViewData.mm:
2354         (currentRunLoop):
2355         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2356         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2357         (WebViewLayerFlushScheduler::schedule):
2358         (WebViewLayerFlushScheduler::invalidate):
2359         (WebViewLayerFlushScheduler::layerFlushCallback):
2360
2361 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2362
2363         Enable InstallAPI for iOS unconditionally
2364         https://bugs.webkit.org/show_bug.cgi?id=191043
2365         rdar://problem/32728423
2366
2367         Reviewed by Dan Bernstein.
2368
2369         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2370         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2371         shouldn't be processed by InstallAPI.
2372         * MigrateHeaders.make: Removed an obsolete workaround.
2373         * Misc/NSURLDownloadSPI.h: Added.
2374         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2375
2376 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2377
2378         Clean up some obsolete MAX_ALLOWED macros
2379         https://bugs.webkit.org/show_bug.cgi?id=190916
2380
2381         Reviewed by Tim Horton.
2382
2383         * WebView/WebHTMLView.mm:
2384         (-[WebHTMLView pressureChangeWithEvent:]):
2385         * WebView/WebPDFView.h:
2386
2387 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2388
2389         Unreviewed, rolling out r237600 and r237604.
2390         https://bugs.webkit.org/show_bug.cgi?id=191086
2391
2392         Breaks internal iOS builds (Requested by ryanhadd_ on
2393         #webkit).
2394
2395         Reverted changesets:
2396
2397         "Enable InstallAPI for iOS unconditionally"
2398         https://bugs.webkit.org/show_bug.cgi?id=191043
2399         https://trac.webkit.org/changeset/237600
2400
2401         "Build fix attempt after enabling InstallAPI for iOS."
2402         https://bugs.webkit.org/show_bug.cgi?id=191043
2403         https://trac.webkit.org/changeset/237604
2404
2405 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2406
2407         Enable InstallAPI for iOS unconditionally
2408         https://bugs.webkit.org/show_bug.cgi?id=191043
2409         rdar://problem/32728423
2410
2411         Reviewed by Dan Bernstein.
2412
2413         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2414         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2415         shouldn't be processed by InstallAPI.
2416         * MigrateHeaders.make: Removed an obsolete workaround.
2417         * Misc/NSURLDownloadSPI.h: Added.
2418         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2419
2420 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2421
2422         Modernize WebKit nibs and lprojs for localization's sake
2423         https://bugs.webkit.org/show_bug.cgi?id=190911
2424         <rdar://problem/45349466>
2425
2426         Reviewed by Dan Bernstein.
2427
2428         * Misc/WebNSControlExtras.m:
2429         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2430         NSWindow and its contents are both in the same scale space these days; avoid
2431         double-applying the scale factor, or you can't see the prompt.
2432
2433         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2434         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2435         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2436         NIB->XIB
2437
2438 2018-10-25  Antoine Quint  <graouts@apple.com>
2439
2440         [Web Animations] Turn Web Animations CSS Integration off by default
2441         https://bugs.webkit.org/show_bug.cgi?id=190901
2442
2443         Reviewed by Dean Jackson.
2444
2445         * WebView/WebPreferences.mm:
2446         (+[WebPreferences initialize]):
2447
2448 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2449
2450         Clean up some obsolete macOS version guards
2451         https://bugs.webkit.org/show_bug.cgi?id=190887
2452
2453         Reviewed by Dan Bernstein.
2454
2455         * Misc/WebNSPasteboardExtras.mm:
2456         (+[NSPasteboard _web_dragTypesForURL]):
2457         * WebCoreSupport/PopupMenuMac.mm:
2458         (PopupMenuMac::show):
2459         * WebCoreSupport/WebEditorClient.h:
2460         * WebCoreSupport/WebEditorClient.mm:
2461         (WebEditorClient::respondToChangedSelection):
2462         * WebView/WebPDFView.mm:
2463         (-[WebPDFView _clipViewForPDFDocumentView]):
2464
2465 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2466
2467         Turn on Conic Gradients
2468         https://bugs.webkit.org/show_bug.cgi?id=190810
2469
2470         Reviewed by Tim Horton.
2471
2472         * Configurations/FeatureDefines.xcconfig:
2473
2474 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2475
2476         Cleanup: MIMETypeRegistry functions
2477         https://bugs.webkit.org/show_bug.cgi?id=190838
2478
2479         Reviewed by Simon Fraser.
2480
2481         * Misc/WebNSPasteboardExtras.mm:
2482         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2483         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2484         because they were identical.
2485
2486         * WebView/WebHTMLRepresentation.mm:
2487         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2488         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2489         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2490         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2491         * WebView/WebView.mm:
2492         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2493         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2494         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2495
2496 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2497
2498         Fix false positive leaks when using custom -init methods that don't start with -init
2499         <https://webkit.org/b/190818>
2500         <rdar://problem/45476042>
2501
2502         Reviewed by Dan Bernstein.
2503
2504         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2505         it is accessible by both categories.
2506         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2507         NSError (WebKitInternal) category.  Add attribute to make this
2508         behave like an -init method.
2509         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2510         NSError (WebKitInternal) category.  Modernize method.  Replace
2511         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2512
2513 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2514
2515         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2516         https://bugs.webkit.org/show_bug.cgi?id=190729
2517
2518         Reviewed by Tim Horton.
2519
2520         * DOM/DOM.mm:
2521         (-[DOMNode boundingBox]):
2522         * DOM/DOMElement.mm:
2523         * DOM/DOMHTML.mm:
2524         * DOM/DOMInternal.mm:
2525         * DOM/DOMUIKitExtensions.mm:
2526         * DOM/WebDOMOperations.mm:
2527         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2528         * DefaultDelegates/WebDefaultEditingDelegate.m:
2529         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2530         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2531         * DefaultDelegates/WebDefaultUIDelegate.h:
2532         * DefaultDelegates/WebDefaultUIDelegate.mm:
2533         (-[WebDefaultUIDelegate webViewClose:]):
2534         (-[WebDefaultUIDelegate webViewFocus:]):
2535         (-[WebDefaultUIDelegate webViewUnfocus:]):
2536         (-[WebDefaultUIDelegate webViewIsResizable:]):
2537         (-[WebDefaultUIDelegate webView:setResizable:]):
2538         (-[WebDefaultUIDelegate webView:setFrame:]):
2539         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2540         * History/BackForwardList.h:
2541         * History/BackForwardList.mm:
2542         * History/WebBackForwardList.mm:
2543         (+[WebBackForwardList initialize]):
2544         (bumperCarBackForwardHackNeeded):
2545         * History/WebHistory.mm:
2546         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2547         (-[WebHistory _sendNotification:entries:]):
2548         (-[WebHistory loadFromURL:error:]):
2549         (-[WebHistory saveToURL:error:]):
2550         * History/WebHistoryItem.mm:
2551         (WKNotifyHistoryItemChanged):
2552         (+[WebHistoryItem initialize]):
2553         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2554         * History/WebURLsWithTitles.m:
2555         * Misc/WebCache.mm:
2556         (+[WebCache initialize]):
2557         * Misc/WebDownload.mm:
2558         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2559         * Misc/WebElementDictionary.mm:
2560         (+[WebElementDictionary initialize]):
2561         (+[WebElementDictionary initializeLookupTable]):
2562         * Misc/WebIconDatabase.mm:
2563         * Misc/WebKitNSStringExtras.mm:
2564         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2565         * Misc/WebKitVersionChecks.h:
2566         * Misc/WebKitVersionChecks.mm:
2567         (WebKitLinkedOnOrAfter):
2568         (WebKitLinkTimeVersion):
2569         * Misc/WebLocalizableStrings.mm:
2570         * Misc/WebNSControlExtras.h:
2571         * Misc/WebNSControlExtras.m:
2572         * Misc/WebNSEventExtras.m:
2573         * Misc/WebNSFileManagerExtras.mm:
2574         * Misc/WebNSImageExtras.h:
2575         * Misc/WebNSImageExtras.m:
2576         * Misc/WebNSPasteboardExtras.mm:
2577         * Misc/WebNSPrintOperationExtras.h:
2578         * Misc/WebNSPrintOperationExtras.m:
2579         * Misc/WebNSViewExtras.m:
2580         * Misc/WebNSWindowExtras.m:
2581         * Panels/WebAuthenticationPanel.h:
2582         * Panels/WebAuthenticationPanel.m:
2583         * Panels/WebPanelAuthenticationHandler.m:
2584         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2585         (+[WebHostedNetscapePluginView initialize]):
2586         * Plugins/WebBasePluginPackage.h:
2587         * Plugins/WebBasePluginPackage.mm:
2588         * Plugins/WebJavaPlugIn.h:
2589         * Plugins/WebPluginContainerCheck.mm:
2590         * Plugins/WebPluginController.h:
2591         * Plugins/WebPluginController.mm:
2592         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2593         (-[WebPluginController addPlugin:]):
2594         (-[WebPluginController destroyPlugin:]):
2595         (-[WebPluginController destroyAllPlugins]):
2596         * Plugins/WebPluginDatabase.mm:
2597         (+[WebPluginDatabase _defaultPlugInPaths]):
2598         * Plugins/WebPluginPackage.mm:
2599         (-[WebPluginPackage initWithPath:]):
2600         * Storage/WebDatabaseManager.mm:
2601         (-[WebDatabaseManager deleteAllDatabases]):
2602         * Storage/WebDatabaseManagerClient.h:
2603         * Storage/WebDatabaseManagerClient.mm:
2604         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2605         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2606         * Storage/WebStorageManager.mm:
2607         (-[WebStorageManager deleteAllOrigins]):
2608         (WebKitInitializeStorageIfNecessary):
2609         * WebCoreSupport/WebAlternativeTextClient.h:
2610         * WebCoreSupport/WebApplicationCache.mm:
2611         (applicationCacheBundleIdentifier):
2612         * WebCoreSupport/WebChromeClient.h:
2613         * WebCoreSupport/WebChromeClient.mm:
2614         (WebChromeClient::setWindowRect):
2615         (WebChromeClient::windowRect):
2616         (WebChromeClient::takeFocus):
2617         (WebChromeClient::addMessageToConsole):
2618         (WebChromeClient::enableSuddenTermination):
2619         (WebChromeClient::disableSuddenTermination):
2620         (WebChromeClient::createPopupMenu const):
2621         (WebChromeClient::createSearchPopupMenu const):
2622         (WebChromeClient::shouldPaintEntireContents const):
2623         (WebChromeClient::supportsVideoFullscreen):
2624         (WebChromeClient::supportsFullScreenForElement):
2625         (WebChromeClient::enterFullScreenForElement):
2626         (WebChromeClient::exitFullScreenForElement):
2627         * WebCoreSupport/WebContextMenuClient.mm:
2628         * WebCoreSupport/WebDragClient.mm:
2629         * WebCoreSupport/WebEditorClient.h:
2630         * WebCoreSupport/WebEditorClient.mm:
2631         (+[WebUndoStep initialize]):
2632         (updateFontPanel):
2633         (WebEditorClient::didBeginEditing):
2634         (WebEditorClient::respondToChangedContents):
2635         (WebEditorClient::respondToChangedSelection):
2636         (WebEditorClient::canceledComposition):
2637         (WebEditorClient::didEndEditing):
2638         (WebEditorClient::didWriteSelectionToPasteboard):
2639         (attributesForAttributedStringConversion):
2640         (WebEditorClient::setInsertionPasteboard):
2641         (WebEditorClient::registerUndoOrRedoStep):
2642         (WebEditorClient::handleKeyboardEvent):
2643         (WebEditorClient::handleInputMethodKeydown):
2644         (WebEditorClient::textDidChangeInTextField):
2645         (WebEditorClient::requestCheckingOfString):
2646         * WebCoreSupport/WebFrameLoaderClient.h:
2647         * WebCoreSupport/WebFrameLoaderClient.mm:
2648         (WebFrameLoaderClient::detachedFromParent2):
2649         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2650         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2651         (WebFrameLoaderClient::dispatchWillSendRequest):
2652         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2653         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2654         (WebFrameLoaderClient::willCacheResponse const):
2655         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2656         (WebFrameLoaderClient::dispatchDidFinishLoading):
2657         (WebFrameLoaderClient::dispatchDidFailLoading):
2658         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2659         (WebFrameLoaderClient::dispatchWillClose):
2660         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2661         (WebFrameLoaderClient::dispatchDidCommitLoad):
2662         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2663         (WebFrameLoaderClient::dispatchDidFailLoad):
2664         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2665         (WebFrameLoaderClient::dispatchDidFinishLoad):
2666         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2667         (WebFrameLoaderClient::willChangeTitle):
2668         (WebFrameLoaderClient::didChangeTitle):
2669         (WebFrameLoaderClient::didReplaceMultipartContent):
2670         (WebFrameLoaderClient::updateGlobalHistory):
2671         (WebFrameLoaderClient::saveViewStateToItem):
2672         (WebFrameLoaderClient::restoreViewState):
2673         (WebFrameLoaderClient::provisionalLoadStarted):
2674         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2675         (WebFrameLoaderClient::setTitle):
2676         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2677         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2678         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2679         (WebFrameLoaderClient::didRestoreFromPageCache):
2680         (WebFrameLoaderClient::actionDictionary const):
2681         (WebFrameLoaderClient::createPlugin):
2682         (WebFrameLoaderClient::getLoadDecisionForIcons):
2683         (WebFrameLoaderClient::finishedLoadingIcon):
2684         (+[WebFramePolicyListener initialize]):
2685         * WebCoreSupport/WebFrameNetworkingContext.mm:
2686         * WebCoreSupport/WebGeolocationClient.h:
2687         * WebCoreSupport/WebGeolocationClient.mm:
2688         (WebGeolocationClient::requestPermission):
2689         * WebCoreSupport/WebInspectorClient.h:
2690         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2691         * WebCoreSupport/WebNotificationClient.mm:
2692         * WebCoreSupport/WebOpenPanelResultListener.mm:
2693         * WebCoreSupport/WebPlatformStrategies.h:
2694         * WebCoreSupport/WebPlatformStrategies.mm:
2695         * WebCoreSupport/WebProgressTrackerClient.h:
2696         * WebCoreSupport/WebProgressTrackerClient.mm:
2697         (WebProgressTrackerClient::progressStarted):
2698         (WebProgressTrackerClient::progressEstimateChanged):
2699         (WebProgressTrackerClient::progressFinished):
2700         * WebCoreSupport/WebSecurityOrigin.mm:
2701         * WebInspector/WebNodeHighlight.h:
2702         * WebInspector/WebNodeHighlight.mm:
2703         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2704         (-[WebNodeHighlight dealloc]):
2705         (-[WebNodeHighlight attach]):
2706         * WebInspector/WebNodeHighlightView.h:
2707         * WebInspector/WebNodeHighlightView.mm:
2708         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2709         (-[WebNodeHighlightView dealloc]):
2710         * WebInspector/WebNodeHighlighter.mm:
2711         (-[WebNodeHighlighter highlight]):
2712         * WebView/WebArchive.mm:
2713         (+[WebArchivePrivate initialize]):
2714         * WebView/WebClipView.h:
2715         * WebView/WebDataSource.mm:
2716         (WebDataSourcePrivate::WebDataSourcePrivate):
2717         (+[WebDataSource initialize]):
2718         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2719         (-[WebDataSource _makeRepresentation]):
2720         * WebView/WebDelegateImplementationCaching.h:
2721         * WebView/WebDelegateImplementationCaching.mm:
2722         (CallDelegate):
2723         (CallDelegateReturningFloat):
2724         (CallDelegateReturningBoolean):
2725         (CallUIDelegate):
2726         (CallUIDelegateReturningFloat):
2727         (CallUIDelegateReturningBoolean):
2728         (CallFrameLoadDelegate):
2729         (CallFrameLoadDelegateReturningBoolean):
2730         (CallResourceLoadDelegate):
2731         (CallScriptDebugDelegate):
2732         (CallFormDelegate):
2733         (CallFormDelegateReturningBoolean):
2734         * WebView/WebDeviceOrientation.mm:
2735         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2736         * WebView/WebDocumentInternal.h:
2737         * WebView/WebDocumentLoaderMac.mm:
2738         (needsDataLoadWorkaround):
2739         * WebView/WebDynamicScrollBarsViewInternal.h:
2740         * WebView/WebFormDelegate.m:
2741         * WebView/WebFrame.mm:
2742         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2743         (-[WebFrame _unmarkAllMisspellings]):
2744         (-[WebFrame _paintBehaviorForDestinationContext:]):
2745         (-[WebFrame _drawRect:contentsOnly:]):
2746         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2747         (-[WebFrame _scrollDOMRangeToVisible:]):
2748         (-[WebFrame _bodyBackgroundColor]):
2749         (-[WebFrame accessibilityRoot]):
2750         (needsMicrosoftMessengerDOMDocumentWorkaround):
2751         * WebView/WebFrameInternal.h:
2752         * WebView/WebFrameView.mm:
2753         (-[WebFrameView _setDocumentView:]):
2754         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2755         (-[WebFrameView _viewClassForMIMEType:]):
2756         (-[WebFrameView initWithFrame:]):
2757         (-[WebFrameView drawRect:]):
2758         (-[WebFrameView _firstResponderIsFormControl]):
2759         (-[WebFrameView keyDown:keyDown:]):
2760         (-[WebFrameView _isScrollable]):
2761         * WebView/WebFullScreenController.h:
2762         * WebView/WebFullScreenController.mm:
2763         * WebView/WebHTMLRepresentation.mm:
2764         * WebView/WebHTMLView.mm:
2765         (-[WebHTMLView hitTest:]):
2766         (-[WebHTMLView initWithFrame:]):
2767         (-[WebHTMLView dealloc]):
2768         (-[WebHTMLView addSubview:]):
2769         (-[WebHTMLView mouseDown:]):
2770         (-[WebHTMLView mouseUp:]):
2771         (-[WebHTMLView resignFirstResponder]):
2772         (-[WebHTMLView accessibilityHitTest:]):
2773         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2774         * WebView/WebHTMLViewInternal.h:
2775         * WebView/WebIndicateLayer.h:
2776         * WebView/WebIndicateLayer.mm:
2777         * WebView/WebMediaPlaybackTargetPicker.h:
2778         * WebView/WebMediaPlaybackTargetPicker.mm:
2779         * WebView/WebPDFDocumentExtras.h:
2780         * WebView/WebPDFDocumentExtras.mm:
2781         * WebView/WebPDFRepresentation.h:
2782         * WebView/WebPDFRepresentation.mm:
2783         * WebView/WebPDFView.h:
2784         * WebView/WebPreferences.mm:
2785         (cacheModelForMainBundle):
2786         (WebPreferencesPrivate::WebPreferencesPrivate):
2787         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2788         (-[WebPreferences encodeWithCoder:]):
2789         (+[WebPreferences standardPreferences]):
2790         (+[WebPreferences initialize]):
2791         (-[WebPreferences _valueForKey:]):
2792         (-[WebPreferences _setStringValue:forKey:]):
2793         (-[WebPreferences _setIntegerValue:forKey:]):
2794         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2795         (-[WebPreferences _setFloatValue:forKey:]):
2796         (-[WebPreferences _setBoolValue:forKey:]):
2797         (-[WebPreferences _setLongLongValue:forKey:]):
2798         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2799         (-[WebPreferences _postCacheModelChangedNotification]):
2800         (-[WebPreferences _postPreferencesChangedNotification]):
2801         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2802         (-[WebPreferences setStorageBlockingPolicy:]):
2803         * WebView/WebResource.mm:
2804         (+[WebResourcePrivate initialize]):
2805         * WebView/WebTextCompletionController.h:
2806         * WebView/WebTextIterator.mm:
2807         (+[WebTextIteratorPrivate initialize]):
2808         * WebView/WebView.mm:
2809         (shouldEnableLoadDeferring):
2810         (shouldRestrictWindowFocus):
2811         (shouldRespectPriorityInCSSAttributeSetters):
2812         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2813         (shouldAllowPictureInPictureMediaPlayback):
2814         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2815         (shouldAllowWindowOpenWithoutUserGesture):
2816         (shouldConvertInvalidURLsToBlank):
2817         (shouldRequireUserGestureToLoadVideo):
2818         (-[WebView _commonInitializationWithFrameName:groupName:]):
2819         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2820         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2821         (-[WebView _closePluginDatabases]):
2822         (-[WebView _closeWithFastTeardown]):
2823         (-[WebView _close]):
2824         (+[WebView _MIMETypeForFile:]):
2825         (-[WebView setShowingInspectorIndication:]):
2826         (-[WebView _setFormDelegate:]):
2827         (-[WebView _needsPreHTML5ParserQuirks]):
2828         (-[WebView _preferencesChangedNotification:]):
2829         (-[WebView _preferencesChanged:]):
2830         (-[WebView _cacheResourceLoadDelegateImplementations]):
2831         (-[WebView _cacheFrameLoadDelegateImplementations]):
2832         (-[WebView _policyDelegateForwarder]):
2833         (-[WebView _UIDelegateForwarder]):
2834         (-[WebView _editingDelegateForwarder]):
2835         (-[WebView _updateActiveState]):
2836         (-[_WebSafeForwarder forwardInvocation:]):
2837         (+[WebView initialize]):
2838         (-[WebView _pluginForMIMEType:]):
2839         (-[WebView _pluginForExtension:]):
2840         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2841         (+[WebView canShowMIMETypeAsHTML:]):
2842         (-[WebView _initWithArguments:]):
2843         (-[WebView initWithFrame:frameName:groupName:]):
2844         (-[WebView dealloc]):
2845         (-[WebView close]):
2846         (-[WebView viewDidMoveToWindow]):
2847         (-[WebView setUIDelegate:]):
2848         (-[WebView setResourceLoadDelegate:]):
2849         (-[WebView setPolicyDelegate:]):
2850         (-[WebView setFrameLoadDelegate:]):
2851         (-[WebView goBack]):
2852         (-[WebView goForward]):
2853         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2854         (-[WebView setHostWindow:]):
2855         (-[WebView becomeFirstResponder]):
2856         (+[WebView _cacheModelChangedNotification:]):
2857         (-[WebView _frameViewAtWindowPoint:]):
2858         (+[WebView _preflightSpellCheckerNow:]):
2859         (+[WebView _preflightSpellChecker]):
2860         (-[WebView canGoBack]):
2861         (-[WebView canGoForward]):
2862         (-[WebView stopLoading:]):
2863         (-[WebView reload:]):
2864         (-[WebView setMainFrameDocumentReady:]):
2865         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2866         (-[WebView setContinuousSpellCheckingEnabled:]):
2867         (-[WebView undoManager]):
2868         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2869         (-[WebView isAutomaticLinkDetectionEnabled]):
2870         (-[WebView isAutomaticDashSubstitutionEnabled]):
2871         (-[WebView isAutomaticTextReplacementEnabled]):
2872         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2873         (+[WebView _setCacheModel:]):
2874         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2875         (-[WebView _keyboardUIMode]):
2876         (LayerFlushController::flushLayers):
2877         (-[WebView _scheduleCompositingLayerFlush]):
2878         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2879         (-[WebView fullScreenPlaceholderView]):
2880         (WebInstallMemoryPressureHandler):
2881         * WebView/WebViewData.h:
2882         * WebView/WebViewData.mm:
2883         (+[WebViewPrivate initialize]):
2884         (-[WebViewPrivate init]):
2885         (-[WebViewPrivate dealloc]):
2886         * WebView/WebViewInternal.h:
2887
2888 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2889
2890         Clean up FrameLoader two-state enums
2891         https://bugs.webkit.org/show_bug.cgi?id=190731
2892
2893         Reviewed by Chris Dumez.
2894
2895         * WebCoreSupport/WebFrameLoaderClient.h:
2896         * WebCoreSupport/WebFrameLoaderClient.mm:
2897         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2898
2899 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2900
2901         Unreviewed, rolling out r237137.
2902
2903         SPI is actually used
2904
2905         Reverted changeset:
2906
2907         "Remove unused WebFrame._loadType"
2908         https://bugs.webkit.org/show_bug.cgi?id=190583
2909         https://trac.webkit.org/changeset/237137
2910
2911 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2912
2913         Enable the datalist element by default on iOS and macOS
2914         https://bugs.webkit.org/show_bug.cgi?id=190594
2915         <rdar://problem/45281159>
2916
2917         Reviewed by Ryosuke Niwa and Tim Horton.
2918
2919         * Configurations/FeatureDefines.xcconfig:
2920
2921 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2922
2923         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2924         https://bugs.webkit.org/show_bug.cgi?id=190675
2925
2926         Reviewed by Chris Dumez.
2927
2928         * History/BackForwardList.h:
2929         * History/BackForwardList.mm:
2930         (BackForwardList::backItem):
2931         (BackForwardList::currentItem):
2932         (BackForwardList::forwardItem):
2933         (BackForwardList::backListCount const):
2934         (BackForwardList::forwardListCount const):
2935         (BackForwardList::itemAtIndex):
2936         * History/WebBackForwardList.mm:
2937         (-[WebBackForwardList backItem]):
2938         (-[WebBackForwardList currentItem]):
2939         (-[WebBackForwardList forwardItem]):
2940         (-[WebBackForwardList itemAtIndex:]):
2941
2942 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2943
2944         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2945         https://bugs.webkit.org/show_bug.cgi?id=190526
2946         rdar://problem/45230140
2947
2948         Reviewed by Dean Jackson.
2949
2950         * WebCoreSupport/WebEditorClient.mm:
2951         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2952
2953 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2954
2955         Implement feature flag and bindings for CSS Painting API
2956         https://bugs.webkit.org/show_bug.cgi?id=190237
2957
2958         Reviewed by Ryosuke Niwa.
2959
2960         * Configurations/FeatureDefines.xcconfig:
2961
2962 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2963
2964         Replace HistoryItem* with HistoryItem& where possible
2965         https://bugs.webkit.org/show_bug.cgi?id=190617
2966
2967         Reviewed by Chris Dumez.
2968
2969         * History/BackForwardList.h:
2970         * History/BackForwardList.mm:
2971         (BackForwardList::goToItem):
2972         * History/WebBackForwardList.mm:
2973         (-[WebBackForwardList goToItem:]):
2974         * History/WebHistoryItem.mm:
2975         (WKNotifyHistoryItemChanged):
2976         * History/WebHistoryItemInternal.h:
2977
2978 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2979
2980         Remove unused WebHistoryItem._transientPropertyForKey
2981         https://bugs.webkit.org/show_bug.cgi?id=190606
2982
2983         Reviewed by Chris Dumez.
2984
2985         * History/WebHistoryItem.mm:
2986         * History/WebHistoryItemPrivate.h:
2987
2988 2018-10-15  Justin Fan  <justin_fan@apple.com>
2989
2990         Add WebGPU 2018 feature flag and experimental feature flag
2991         https://bugs.webkit.org/show_bug.cgi?id=190509
2992
2993         Reviewed by Dean Jackson.
2994
2995         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2996         for the 2018 WebGPU prototype.
2997
2998         * Configurations/FeatureDefines.xcconfig:
2999         * WebView/WebPreferenceKeysPrivate.h:
3000         * WebView/WebPreferences.mm:
3001         (+[WebPreferences initialize]):
3002         (-[WebPreferences webGPUEnabled]):
3003         (-[WebPreferences setWebGPUEnabled:]):
3004         * WebView/WebPreferencesPrivate.h:
3005         * WebView/WebView.mm:
3006         (-[WebView _preferencesChanged:]):
3007
3008 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3009
3010         Fix iOS build after r237157
3011
3012         * WebView/WebView.mm:
3013         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3014
3015 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3016
3017         Modernize BackForwardClient.h
3018         https://bugs.webkit.org/show_bug.cgi?id=190610
3019
3020         Reviewed by Chris Dumez.
3021
3022         * History/BackForwardList.h:
3023         * History/BackForwardList.mm:
3024         (BackForwardList::backListCount const):
3025         (BackForwardList::forwardListCount const):
3026         (BackForwardList::backListCount): Deleted.
3027         (BackForwardList::forwardListCount): Deleted.
3028         * History/WebBackForwardList.mm:
3029         (-[WebBackForwardList init]):
3030         * WebCoreSupport/WebFrameLoaderClient.mm:
3031         (WebFrameLoaderClient::canCachePage const):
3032         * WebView/WebFrameView.mm:
3033         (-[WebFrameView keyDown:keyDown:]):
3034         * WebView/WebView.mm:
3035         (-[WebView _commonInitializationWithFrameName:groupName:]):
3036         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3037         (-[WebView _loadBackForwardListFromOtherView:]):
3038         (-[WebView initWithCoder:]):
3039         (-[WebView encodeWithCoder:]):
3040         (-[WebView backForwardList]):
3041         (-[WebView setMaintainsBackForwardList:]):
3042
3043 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3044
3045         Add support for prefers-color-scheme media query
3046         https://bugs.webkit.org/show_bug.cgi?id=190499
3047         rdar://problem/45212025
3048
3049         Reviewed by Dean Jackson.
3050
3051         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3052
3053 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3054
3055         Remove unused WebView._globalHistoryItem
3056         https://bugs.webkit.org/show_bug.cgi?id=190601
3057
3058         Reviewed by Chris Dumez.
3059
3060         * WebCoreSupport/WebFrameLoaderClient.h:
3061         * WebCoreSupport/WebFrameLoaderClient.mm:
3062         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3063         * WebView/WebView.mm:
3064         (-[WebView _globalHistoryItem]): Deleted.
3065         (-[WebView _setGlobalHistoryItem:]): Deleted.
3066         * WebView/WebViewData.h:
3067         * WebView/WebViewInternal.h:
3068         * WebView/WebViewPrivate.h:
3069
3070 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3071
3072         Remove unused parameters from FrameLoaderClient::createFrame
3073         https://bugs.webkit.org/show_bug.cgi?id=190587
3074
3075         Reviewed by Chris Dumez.
3076
3077         * WebCoreSupport/WebFrameLoaderClient.h:
3078         * WebCoreSupport/WebFrameLoaderClient.mm:
3079         (WebFrameLoaderClient::createFrame):
3080
3081 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3082
3083         Remove unused WebFrame._loadType
3084         https://bugs.webkit.org/show_bug.cgi?id=190583
3085
3086         Reviewed by Chris Dumez.
3087
3088         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3089
3090         * WebView/WebFrame.mm:
3091         (toWebFrameLoadType): Deleted.
3092         (-[WebFrame _loadType]): Deleted.
3093         * WebView/WebFramePrivate.h:
3094
3095 2018-10-15  Chris Dumez  <cdumez@apple.com>
3096
3097         Restrict browsing context lookup by name to frames that are related to one another
3098         https://bugs.webkit.org/show_bug.cgi?id=190475
3099
3100         Reviewed by Alex Christensen.
3101
3102         * WebView/WebFrame.mm:
3103         (-[WebFrame findFrameNamed:]):
3104
3105 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3106
3107         Remove InjectedBundle processing of back/forward lists
3108         https://bugs.webkit.org/show_bug.cgi?id=190459
3109
3110         Reviewed by Chris Dumez.
3111
3112         * WebCoreSupport/WebFrameLoaderClient.h:
3113         * WebCoreSupport/WebFrameLoaderClient.mm:
3114         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3115
3116 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3117
3118         [JSC] Remove Option::useAsyncIterator
3119         https://bugs.webkit.org/show_bug.cgi?id=190567
3120
3121         Reviewed by Saam Barati.
3122
3123         * Configurations/FeatureDefines.xcconfig:
3124
3125 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3126
3127         Allow encoding of small enum classes
3128         https://bugs.webkit.org/show_bug.cgi?id=190531
3129
3130         Reviewed by Tim Horton.
3131
3132         * WebCoreSupport/WebFrameLoaderClient.mm:
3133         (-[WebFramePolicyListener dealloc]):
3134
3135 2018-10-11  Keith Rollin  <krollin@apple.com>
3136
3137         CURRENT_ARCH should not be used in Run Script phase.
3138         https://bugs.webkit.org/show_bug.cgi?id=190407
3139         <rdar://problem/45133556>
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3144         CURRENT_ARCH is not well-defined during this phase (and may even have
3145         the value "undefined") since this phase is run just once per build
3146         rather than once per supported architecture. Migrate away from
3147         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3148         performing an operation for each value, or by picking the first entry
3149         in ARCHS and using that as a representative value.
3150
3151         * Configurations/WebKitLegacy.xcconfig: When generating
3152         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3153         macosx platforms.
3154
3155         * MigrateHeaders.make:
3156         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3157         generate one for each architecture in ARCHS.
3158
3159 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3160
3161         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3162         https://bugs.webkit.org/show_bug.cgi?id=190429
3163
3164         Reviewed by Saam Barati.
3165
3166         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3167
3168         * WebView/WebPDFRepresentation.mm:
3169         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3170
3171 2018-10-08  Justin Fan  <justin_fan@apple.com>
3172
3173         WebGPU: Rename old WebGPU prototype to WebMetal
3174         https://bugs.webkit.org/show_bug.cgi?id=190325
3175         <rdar://problem/44990443>
3176
3177         Reviewed by Dean Jackson.
3178
3179         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3180
3181         * Configurations/FeatureDefines.xcconfig:
3182         * WebView/WebPreferenceKeysPrivate.h:
3183         * WebView/WebPreferences.mm:
3184         (+[WebPreferences initialize]):
3185         (-[WebPreferences webMetalEnabled]):
3186         (-[WebPreferences setWebMetalEnabled:]):
3187         (-[WebPreferences webGPUEnabled]): Deleted.
3188         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3189         * WebView/WebPreferencesPrivate.h:
3190         * WebView/WebView.mm:
3191         (-[WebView _preferencesChanged:]):
3192
3193 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3194
3195         Make <input type=color> a runtime enabled (on-by-default) feature
3196         https://bugs.webkit.org/show_bug.cgi?id=189162
3197
3198         Reviewed by Wenson Hsieh and Tim Horton.
3199
3200         * Configurations/FeatureDefines.xcconfig:
3201
3202 2018-10-07  Dan Bernstein  <mitz@apple.com>
3203
3204         Fixed building with the latest macOS SDK
3205
3206         * Plugins/WebNetscapePluginPackage.mm:
3207         (-[WebNetscapePluginPackage openResourceFile]):
3208         (-[WebNetscapePluginPackage closeResourceFile:]):
3209
3210 2018-10-04  Dan Bernstein  <mitz@apple.com>
3211
3212         More Carbon build-fixing.
3213
3214         * Carbon/CarbonWindowAdapter.mm:
3215         (-[CarbonWindowAdapter _destroyRealWindow:]):
3216         (-[CarbonWindowAdapter _growBoxRect]):
3217
3218 2018-10-04  Dan Bernstein  <mitz@apple.com>
3219
3220         Retried to fix 32-bit macOS builds after r236846.
3221
3222         * WebView/WebHTMLView.mm:
3223         (-[WebHTMLView setMarkedText:selectedRange:]):
3224
3225 2018-10-04  Dan Bernstein  <mitz@apple.com>
3226
3227         Retried to fix 32-bit macOS builds after r236846.
3228
3229         * Carbon/HIWebView.mm:
3230         (ActiveStateChanged):
3231
3232 2018-10-04  Dan Bernstein  <mitz@apple.com>
3233
3234         Tried to fix 32-bit macOS builds after r236846.
3235
3236         * Carbon/HIWebView.mm:
3237         (_NSSelectorForHICommand):
3238
3239 2018-10-04  Dan Bernstein  <mitz@apple.com>
3240
3241         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3242         https://bugs.webkit.org/show_bug.cgi?id=190250
3243
3244         Reviewed by Andy Estes.
3245
3246         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3247           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3248           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3249           an earlier line set it to YES.
3250
3251         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3252         changes below.
3253
3254         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3255           provides some missing method declarations.
3256
3257         * Misc/WebDownload.mm:
3258         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3259           a deprecated method.
3260
3261         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3262
3263         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3264           other code in the file uses a method from it.
3265
3266         * Plugins/WebBaseNetscapePluginView.mm:
3267         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3268           a deprecated method.
3269
3270         * Plugins/WebPluginController.mm:
3271         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3272           around use of a selector that may be present in some WebKit client.
3273
3274         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3275           method declarations.
3276
3277         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3278           from here.
3279
3280         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3281           missing method declarations.
3282
3283         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3284           from here.
3285
3286         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3287           call from here.
3288         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3289           an obsolete delegate method for binary compatibility.
3290         (pluginView): Ditto.
3291
3292         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3293           call from here.
3294
3295         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3296           WebDeviceOrientationProviderMock protocol.
3297
3298         * WebView/WebDeviceOrientationProviderMock.mm:
3299         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3300           main @implementation.
3301
3302         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3303           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3304
3305         * WebView/WebDynamicScrollBarsView.mm:
3306         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3307           of a deprecated method.
3308
3309         * WebView/WebHTMLView.mm:
3310         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3311           selector warning around action methods that are not declared anywhere in WebKit.
3312
3313         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3314           about implementing this deprecated method.
3315         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3316         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3317         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3318         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3319         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3320         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3321         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3322         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3323         (-[WebHTMLView doCommandBySelector:]): Ditto.
3324         (-[WebHTMLView insertText:]): Ditto.
3325
3326         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3327
3328         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3329
3330         * WebView/WebPDFView.h: Removed previewView ivar.
3331
3332         * WebView/WebPDFView.mm:
3333           Removed declaration of FileInternal category and merged its implementation with the main
3334           implementation.
3335         (-[WebPDFView dealloc]): Removed previewView ivar.
3336         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3337           exist in macOS versions we support.
3338         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3339         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3340           action methods internal to PDFKit.
3341         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3342         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3343
3344         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3345           call on macOS, even though in r86988 we started calling different methods on iOS.
3346
3347         * WebView/WebView.mm:
3348         - Imported headers that declare delegate methods that we call.
3349         - Removed declaration of WebFileInternal category and merged its implementation with the
3350           main implementation.
3351         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3352           category, which made them impossible to call from the main implementation. Moved those
3353           into the main implementation. One of those had to be declared in a class extension,
3354           because it is called from a method implemented in the WebPrivate category, and that
3355           category’s implementation appears first in the file.
3356
3357         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3358           around use of obsolete delegate method for binary compatibility.
3359
3360         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3361
3362 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3363
3364         Runtime flag and IDL for MediaRecorder
3365         https://bugs.webkit.org/show_bug.cgi?id=190018
3366
3367         Reviewed by Youenn Fablet and Chris Dumez.
3368
3369         * WebView/WebPreferenceKeysPrivate.h:
3370         * WebView/WebPreferences.mm:
3371         (+[WebPreferences initialize]):
3372         (-[WebPreferences mediaRecorderEnabled]):
3373         (-[WebPreferences setMediaRecorderEnabled:]):
3374         * WebView/WebPreferencesPrivate.h:
3375         * WebView/WebView.mm:
3376         (-[WebView _preferencesChanged:]):
3377
3378 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3379
3380         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3381         https://bugs.webkit.org/show_bug.cgi?id=190238
3382
3383         Reviewed by Antti Koivisto.
3384
3385         Enabled the feature by default.
3386
3387         * WebView/WebPreferences.mm:
3388         (+[WebPreferences initialize]):
3389
3390 2018-10-01  Dean Jackson  <dino@apple.com>
3391
3392         [macOS] Switching to discrete GPU should be done in the UI process
3393         https://bugs.webkit.org/show_bug.cgi?id=189361
3394         <rdar://problem/43949622>
3395
3396         Reviewed by Simon Fraser.
3397
3398         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3399         not support swapping to the discrete GPU in this configuration.
3400
3401         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3402         (WebKit::WebSwitchingGPUClient::singleton):
3403         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3404         * WebView/WebView.mm:
3405         (-[WebView _commonInitializationWithFrameName:groupName:]):
3406
3407 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3408
3409         Remove ParsedURLString
3410         https://bugs.webkit.org/show_bug.cgi?id=190154
3411
3412         Reviewed by Chris Dumez.
3413
3414         * WebView/WebScriptDebugger.mm:
3415         (toNSURL):
3416
3417 2018-10-01  Dean Jackson  <dino@apple.com>
3418
3419         Remove CSS Animation Triggers
3420         https://bugs.webkit.org/show_bug.cgi?id=190175
3421         <rdar://problem/44925626>
3422
3423         Reviewed by Simon Fraser.
3424
3425         * Configurations/FeatureDefines.xcconfig:
3426
3427 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3428
3429         Unreviewed, rolling out r236624 and r236671.
3430         https://bugs.webkit.org/show_bug.cgi?id=190207
3431
3432         The change in r236624 introduced crashes on the bots
3433         (Requested by ryanhaddad on #webkit).
3434
3435         Reverted changesets:
3436
3437         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3438         https://bugs.webkit.org/show_bug.cgi?id=188747
3439         https://trac.webkit.org/changeset/236624
3440
3441         "Unify implementation in VideoFullscreenInterfaceAVKit"
3442         https://bugs.webkit.org/show_bug.cgi?id=190091
3443         https://trac.webkit.org/changeset/236671
3444
3445 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3446
3447         URL should not use TextEncoding internally
3448         https://bugs.webkit.org/show_bug.cgi?id=190111
3449
3450         Reviewed by Andy Estes.
3451
3452         * Misc/WebNSURLExtras.mm:
3453
3454 2018-09-28  Jer Noble  <jer.noble@apple.com>
3455
3456         Refactoring: eliminate raw pointer usage in Fullscreen code
3457         https://bugs.webkit.org/show_bug.cgi?id=188747
3458         <rdar://problem/43541164>
3459
3460         Reviewed by Alex Christensen.
3461
3462         PlaybackSessionInterface no longer has an invalidate() method.
3463
3464         * WebView/WebView.mm:
3465         (-[WebView _clearPlaybackControlsManager]):
3466
3467 2018-09-28  Chris Dumez  <cdumez@apple.com>
3468
3469         Drop support for cross-origin-window-policy header
3470         https://bugs.webkit.org/show_bug.cgi?id=190081
3471
3472         Reviewed by Ryosuke Niwa.
3473
3474         * WebView/WebPreferenceKeysPrivate.h:
3475         * WebView/WebPreferences.mm:
3476         (+[WebPreferences initialize]):
3477         * WebView/WebPreferencesPrivate.h:
3478         * WebView/WebView.mm:
3479         (-[WebView _preferencesChanged:]):
3480
3481 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3482
3483         Rename createMarkup to serializePreservingVisualAppearance
3484         https://bugs.webkit.org/show_bug.cgi?id=190086
3485
3486         Reviewed by Wenson Hsieh.
3487
3488         * DOM/WebDOMOperations.mm:
3489         (-[DOMRange markupString]):
3490
3491 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3492
3493         Unreviewed, rolling out r236605.
3494         https://bugs.webkit.org/show_bug.cgi?id=190087
3495
3496         caused three API test timeouts (Requested by jernoble on
3497         #webkit).
3498
3499         Reverted changeset:
3500
3501         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3502         https://bugs.webkit.org/show_bug.cgi?id=188747
3503         https://trac.webkit.org/changeset/236605
3504
3505 2018-09-28  Jer Noble  <jer.noble@apple.com>
3506
3507         Refactoring: eliminate raw pointer usage in Fullscreen code
3508         https://bugs.webkit.org/show_bug.cgi?id=188747
3509         <rdar://problem/43541164>
3510
3511         Reviewed by Alex Christensen.
3512
3513         PlaybackSessionInterface no longer has an invalidate() method.
3514
3515         * WebView/WebView.mm:
3516         (-[WebView _clearPlaybackControlsManager]):
3517
3518 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3519
3520         Use enum class in createMarkup arguments
3521         https://bugs.webkit.org/show_bug.cgi?id=190028
3522
3523         Reviewed by Wenson Hsieh.
3524
3525         * DOM/WebDOMOperations.mm:
3526         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3527         (-[DOMRange markupString]): Ditto.
3528
3529 2018-09-27  Antoine Quint  <graouts@apple.com>
3530
3531         [Web Animations] Turn Web Animations with CSS integration on
3532         https://bugs.webkit.org/show_bug.cgi?id=184819
3533         <rdar://problem/39597337>
3534
3535         Reviewed by Dean Jackson.
3536
3537         * WebView/WebPreferences.mm:
3538         (+[WebPreferences initialize]):
3539
3540 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3541
3542         Selection should work across shadow boundary when initiated by a mouse drag
3543         https://bugs.webkit.org/show_bug.cgi?id=151380
3544         <rdar://problem/24363872>
3545
3546         Reviewed by Wenson Hsieh.
3547
3548         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3549
3550         * WebView/WebPreferenceKeysPrivate.h:
3551         * WebView/WebPreferences.mm:
3552         (+[WebPreferences initialize]):
3553         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3554         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3555         * WebView/WebPreferencesPrivate.h:
3556         * WebView/WebView.mm:
3557         (-[WebView _preferencesChanged:]):
3558
3559 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3560
3561         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3562         https://bugs.webkit.org/show_bug.cgi?id=189918
3563         Work towards <rdar://problem/44648705>
3564
3565         Reviewed by Tim Horton.
3566
3567         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3568
3569         * WebView/WebHTMLView.mm:
3570         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3571         (-[WebHTMLView _updateFontPanel]):
3572         * WebView/WebView.mm:
3573         (-[WebView typingAttributes]):
3574
3575 2018-09-17  Darin Adler  <darin@apple.com>
3576
3577         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3578         https://bugs.webkit.org/show_bug.cgi?id=189652
3579
3580         Reviewed by Saam Barati.
3581
3582         * WebView/WebPDFRepresentation.mm:
3583         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3584
3585 2018-09-14  Jer Noble  <jer.noble@apple.com>
3586
3587         Turn SourceBufferChangeTypeEnabled on by default
3588         https://bugs.webkit.org/show_bug.cgi?id=189527
3589
3590         Reviewed by Eric Carlson.
3591
3592         * WebView/WebPreferences.mm:
3593         (+[WebPreferences initialize]):
3594
3595 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3596
3597         Fix an internal build after r235935
3598         https://bugs.webkit.org/show_bug.cgi?id=188996
3599
3600         * Carbon/HIWebView.mm:
3601         (Draw):
3602         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3603
3604 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3605
3606         Add IGNORE_WARNING_.* macros
3607         https://bugs.webkit.org/show_bug.cgi?id=188996
3608
3609         Reviewed by Michael Catanzaro.
3610
3611         * Carbon/CarbonUtils.m:
3612         (PoolCleaner):
3613         * Carbon/CarbonWindowAdapter.mm:
3614         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3615         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3616         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3617         (-[CarbonWindowAdapter _termWindowIfOwner]):
3618         (-[CarbonWindowAdapter _windowMovedToRect:]):
3619         (-[CarbonWindowAdapter setContentView:]):
3620         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3621         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3622         * Carbon/CarbonWindowFrame.m:
3623         (-[CarbonWindowFrame title]):
3624         * Carbon/HIViewAdapter.m:
3625         (+[HIViewAdapter getHIViewForNSView:]):
3626         * Carbon/HIWebView.mm:
3627         (overrideCGContext):
3628         (restoreCGContext):
3629         (Draw):
3630         * DOM/DOM.mm:
3631         * History/WebHistory.mm:
3632         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3633         * History/WebHistoryItem.mm:
3634         (-[WebHistoryItem icon]):
3635         * Misc/WebKitNSStringExtras.mm:
3636         (-[NSString _web_drawAtPoint:font:textColor:]):
3637         * Misc/WebNSImageExtras.m:
3638         (-[NSImage _web_scaleToMaxSize:]):
3639         (-[NSImage _web_dissolveToFraction:]):
3640         * Misc/WebNSPasteboardExtras.mm:
3641         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3642         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3643         * Panels/WebAuthenticationPanel.m:
3644         (-[WebAuthenticationPanel loadNib]):
3645         * Plugins/Hosted/NetscapePluginHostManager.mm:
3646         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3647         (WebKit::NetscapePluginHostManager::didCreateWindow):
3648         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3649         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3650         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3651         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3652         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3653         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3654         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3655         (-[WebHostedNetscapePluginView drawRect:]):
3656         * Plugins/Hosted/WebTextInputWindowController.m:
3657         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3658         * Plugins/WebBaseNetscapePluginView.mm:
3659         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3660         * Plugins/WebNetscapePluginPackage.mm:
3661         (-[WebNetscapePluginPackage _tryLoad]):
3662         * Plugins/WebNetscapePluginView.mm:
3663         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3664         (-[WebNetscapePluginView sendDrawRectEvent:]):
3665         (-[WebNetscapePluginView drawRect:]):
3666         * Plugins/WebPluginController.mm:
3667         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3668         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3669         * WebCoreSupport/PopupMenuMac.mm:
3670         (PopupMenuMac::populate):
3671         * WebCoreSupport/WebAlternativeTextClient.h:
3672         * WebCoreSupport/WebDragClient.mm:
3673         (WebDragClient::startDrag):
3674         * WebCoreSupport/WebFrameLoaderClient.mm:
3675         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3676         (webGetNSImage):
3677         * WebInspector/WebNodeHighlight.mm:
3678         * WebInspector/WebNodeHighlightView.mm:
3679         (-[WebNodeHighlightView drawRect:]):
3680         * WebView/WebClipView.mm:
3681         (-[WebClipView initWithFrame:]):
3682         * WebView/WebFrame.mm:
3683         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3684         (-[WebFrame _drawRect:contentsOnly:]):
3685         (-[WebFrame accessibilityRoot]):
3686         * WebView/WebFullScreenController.mm:
3687         (-[WebFullScreenController enterFullScreen:]):
3688         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3689         (-[WebFullScreenController exitFullScreen]):
3690         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3691         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3692         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3693         * WebView/WebHTMLView.mm:
3694         (-[NSWindow _web_borderView]):
3695         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3696         (-[WebHTMLView _setAsideSubviews]):
3697         (-[WebHTMLView _autoscroll]):
3698         (-[WebHTMLView drawRect:]):
3699         (-[WebHTMLView mouseDown:]):
3700         (-[WebHTMLView mouseDragged:]):
3701         (-[WebHTMLView mouseUp:]):
3702         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3703         (-[WebHTMLView knowsPageRange:]):
3704         (-[WebHTMLView accessibilityHitTest:]):
3705         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3706         (-[WebHTMLView _colorAsString:]):
3707         (-[WebHTMLView copyFont:]):
3708         (-[WebHTMLView _executeSavedKeypressCommands]):
3709         (-[WebHTMLView attachRootLayer:]):
3710         (-[WebHTMLView textStorage]):
3711         (-[WebHTMLView _updateSelectionForInputManager]):
3712         * WebView/WebPDFView.mm:
3713         (_applicationInfoForMIMEType):
3714         (-[WebPDFView centerSelectionInVisibleArea:]):
3715         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3716         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3717         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3718         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3719         * WebView/WebTextCompletionController.mm:
3720         (-[WebTextCompletionController _buildUI]):
3721         (-[WebTextCompletionController _placePopupWindow:]):
3722         * WebView/WebVideoFullscreenController.mm:
3723         * WebView/WebVideoFullscreenHUDWindowController.mm:
3724         (createMediaUIBackgroundView):
3725         * WebView/WebView.mm:
3726         (-[WebTextListTouchBarViewController initWithWebView:]):
3727         (-[WebView _dispatchTileDidDraw:]):
3728         (-[WebView encodeWithCoder:]):
3729         (-[WebView mainFrameIcon]):
3730         (LayerFlushController::flushLayers):
3731         * WebView/WebWindowAnimation.mm:
3732         (setScaledFrameForWindow):
3733
3734 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3735
3736         Remove unused needsDestruction class variables from HashTraits
3737         https://bugs.webkit.org/show_bug.cgi?id=189490
3738
3739         Reviewed by Daniel Bates.
3740
3741         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3742
3743 2018-09-07  Frederic Wang  <fwang@igalia.com>
3744
3745         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3746         https://bugs.webkit.org/show_bug.cgi?id=182230
3747
3748         Reviewed by Simon Fraser.
3749
3750         * DOM/DOMDocument.mm:
3751         (-[DOMDocument scrollingElement]): Use the new name.
3752
3753 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3754
3755         Refactor WebCore::EditAction to be an 8-bit enum class
3756         https://bugs.webkit.org/show_bug.cgi?id=189383
3757
3758         Reviewed by Dan Bernstein.
3759
3760         * WebCoreSupport/WebEditorClient.mm:
3761         (undoNameForEditAction):
3762         * WebView/WebHTMLView.mm:
3763         (-[WebHTMLView pasteFont:]):
3764         (-[WebHTMLView changeFont:]):
3765         (-[WebHTMLView changeAttributes:]):
3766         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3767         (-[WebHTMLView changeColor:]):
3768         * WebView/WebView.mm:
3769         (-[WebView setTypingStyle:]):
3770
3771 2018-09-06  Frederic Wang  <fwang@igalia.com>
3772
3773         Group options of scrollRectToVisible into a struct
3774         https://bugs.webkit.org/show_bug.cgi?id=189352
3775
3776         Reviewed by Simon Fraser.
3777
3778         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3779         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3780         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3781
3782 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3783
3784         [macOS] Cannot change font size at selection until font panel is shown
3785         https://bugs.webkit.org/show_bug.cgi?id=189295
3786         <rdar://problem/35593389>
3787
3788         Reviewed by Ryosuke Niwa.
3789
3790         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3791         WebCore ChangeLog for more details.
3792
3793         * WebView/WebHTMLView.mm:
3794         (-[WebHTMLView changeFont:]):
3795         (-[WebHTMLView changeAttributes:]):
3796         (-[WebHTMLView _originalFontA]): Deleted.
3797         (-[WebHTMLView _originalFontB]): Deleted.
3798         (fontNameForDescription): Deleted.
3799         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3800         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3801         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3802
3803 2018-09-05  Jer Noble  <jer.noble@apple.com>
3804
3805         Add MediaCapabilities as an Experimental Feature
3806         https://bugs.webkit.org/show_bug.cgi?id=189209
3807
3808         Reviewed by Eric Carlson.
3809
3810         RuntimeEnabledFeature -> Setting.
3811
3812         * WebView/WebView.mm:
3813         (-[WebView _preferencesChanged:]):
3814
3815 2018-09-04  Frederic Wang  <fwang@igalia.com>
3816
3817         Add basic support for ScrollIntoViewOptions
3818         https://bugs.webkit.org/show_bug.cgi?id=189258
3819
3820         Reviewed by Simon Fraser.
3821
3822         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3823         header so that this file can build despite the new scrollIntoView function.
3824
3825 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3826
3827         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3828         https://bugs.webkit.org/show_bug.cgi?id=188890
3829         <rdar://problem/43648605>
3830
3831         Reviewed by Tim Horton.
3832
3833         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3834         more detail.
3835
3836         * WebCoreSupport/WebPlatformStrategies.h:
3837         * WebCoreSupport/WebPlatformStrategies.mm:
3838         (WebPlatformStrategies::allStringsForType):
3839
3840 2018-09-01  Darin Adler  <darin@apple.com>
3841
3842         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3843         https://bugs.webkit.org/show_bug.cgi?id=189072
3844         Reviewed by Dan Bernstein.
3845
3846         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3847         and declarations for NSURLDownload init methods.
3848
3849         * Misc/WebDownloadInternal.h: Removed.
3850
3851         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3852         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3853         "-Wdeprecated-declarations" because the method used here is deprecated.
3854
3855         * WebView/WebView.mm:
3856         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3857         used here is deprecated.
3858
3859 2018-08-31  Chris Dumez  <cdumez@apple.com>
3860
3861         Assertion hit in ~CompletionHandler() from ~WebFrame()
3862         https://bugs.webkit.org/show_bug.cgi?id=189199
3863         <rdar://problem/42657233>
3864
3865         Reviewed by Youenn Fablet.
3866
3867         * WebCoreSupport/WebFrameLoaderClient.h:
3868         * WebCoreSupport/WebFrameLoaderClient.mm:
3869         (WebFrameLoaderClient::dispatchWillSubmitForm):
3870
3871 2018-08-31  Antti Koivisto  <antti@apple.com>
3872
3873         Replace OptionSet |= and -= operators with add() and remove() functions
3874         https://bugs.webkit.org/show_bug.cgi?id=189169
3875
3876         Reviewed by Anders Carlsson.
3877
3878         * WebView/WebFrame.mm:
3879         (-[WebFrame _drawRect:contentsOnly:]):
3880         * WebView/WebView.mm:
3881         (coreOptions):
3882
3883 2018-08-31  Frederic Wang  <fwang@igalia.com>
3884
3885         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3886         https://bugs.webkit.org/show_bug.cgi?id=182053
3887
3888         Reviewed by Simon Fraser.
3889
3890         Add developer flag to use standard behavior for scrolling* attributes.
3891
3892         * WebView/WebPreferenceKeysPrivate.h:
3893         * WebView/WebPreferences.mm:
3894         (+[WebPreferences initialize]):
3895         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3896         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3897         * WebView/WebPreferencesPrivate.h:
3898         * WebView/WebView.mm:
3899         (-[WebView _preferencesChanged:]):
3900
3901 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3902
3903         Implement the Web Share API
3904         https://bugs.webkit.org/show_bug.cgi?id=171100
3905         <rdar://problem/31751734>
3906
3907         Reviewed by Tim Horton.
3908
3909         * WebCoreSupport/WebChromeClient.h:
3910         * WebCoreSupport/WebChromeClient.mm:
3911         (WebChromeClient::showShareSheet):
3912         Empty declaration of showShareSheet.
3913
3914 2018-08-29  Youenn Fablet  <youenn@apple.com>
3915
3916         Remove WebRTC legacy API implementation
3917         https://bugs.webkit.org/show_bug.cgi?id=189040
3918
3919         Reviewed by Eric Carlson.
3920
3921         * WebView/WebPreferenceKeysPrivate.h:
3922         * WebView/WebPreferences.mm:
3923         (+[WebPreferences initialize]):
3924         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3925         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3926         * WebView/WebPreferencesPrivate.h:
3927         * WebView/WebView.mm:
3928         (-[WebView _preferencesChanged:]):
3929
3930 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3931
3932         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3933         https://bugs.webkit.org/show_bug.cgi?id=189054
3934
3935         Reviewed by Andy Estes.
3936
3937         Remove the pasteboard type argument from readURLFromPasteboard.
3938
3939         * WebCoreSupport/WebPlatformStrategies.h:
3940         * WebCoreSupport/WebPlatformStrategies.mm:
3941         (WebPlatformStrategies::readURLFromPasteboard):
3942
3943 2018-08-27  Keith Rollin  <krollin@apple.com>
3944
3945         Unreviewed build fix -- disable LTO for production builds
3946
3947         * Configurations/Base.xcconfig:
3948
3949 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3950
3951         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3952         https://bugs.webkit.org/show_bug.cgi?id=188931
3953
3954         Reviewed by Wenson Hsieh.
3955
3956         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3957
3958 2018-08-27  Keith Rollin  <krollin@apple.com>
3959
3960         Build system support for LTO
3961         https://bugs.webkit.org/show_bug.cgi?id=187785
3962         <rdar://problem/42353132>
3963
3964         Reviewed by Dan Bernstein.
3965
3966         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3967         LTO.
3968
3969         * Configurations/Base.xcconfig:
3970         * Configurations/DebugRelease.xcconfig:
3971
3972 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3973
3974         Pass in IsComposed flag to Event constructors
3975         https://bugs.webkit.org/show_bug.cgi?id=188720
3976         <rdar://problem/43580387>
3977
3978         Reviewed by Simon Fraser.
3979
3980         * WebView/WebPDFView.mm:
3981         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3982         whether it's simulated or not.
3983
3984 2018-08-23  Mark Lam  <mark.lam@apple.com>
3985
3986         Move vmEntryGlobalObject() to VM from CallFrame.
3987         https://bugs.webkit.org/show_bug.cgi?id=188900
3988         <rdar://problem/43655753>
3989
3990         Reviewed by Michael Saboff.
3991
3992         * WebView/WebScriptDebugger.mm:
3993         (WebScriptDebugger::sourceParsed):
3994
3995 2018-08-23  Andy Estes  <aestes@apple.com>
3996
3997         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3998         https://bugs.webkit.org/show_bug.cgi?id=188829
3999
4000         Reviewed by Tim Horton.
4001
4002         * Configurations/FeatureDefines.xcconfig:
4003
4004 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
4005
4006         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
4007         https://bugs.webkit.org/show_bug.cgi?id=188777
4008
4009         Reviewed by Simon Fraser.
4010
4011         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
4012         being "true" before the code change.
4013
4014         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
4015
4016         * WebView/WebPDFView.mm:
4017         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4018
4019 2018-08-21  Daniel Bates  <dabates@apple.com>
4020
4021         Replace TextCheckingTypeMask with OptionSet
4022         https://bugs.webkit.org/show_bug.cgi?id=188678
4023
4024         Reviewed by Antti Koivisto.
4025
4026         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
4027         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
4028         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
4029         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
4030
4031         * WebCoreSupport/WebEditorClient.h:
4032         * WebCoreSupport/WebEditorClient.mm:
4033         (WebEditorClient::checkTextOfParagraph):
4034         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
4035         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
4036         left as this is more readable and unncessary now that modern compilers like Clang have
4037         diagnostics to catch accidental assignments when equality was intended.
4038         (WebEditorClient::didCheckSucceed):
4039         * WebView/WebView.mm:
4040         (coreTextCheckingType):
4041         (textCheckingResultFromNSTextCheckingResult):
4042
4043 2018-08-21  Daniel Bates  <dabates@apple.com>
4044
4045         [iOS][WK1] Support toggling continuous spell checking from tests
4046         https://bugs.webkit.org/show_bug.cgi?id=188763
4047
4048         Reviewed by Simon Fraser.
4049
4050         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
4051         spell checking from tests in iOS WebKit Legacy.
4052
4053         * WebCoreSupport/WebEditorClient.h:
4054         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
4055         * WebCoreSupport/WebEditorClient.mm:
4056         * WebView/WebView.h:
4057         * WebView/WebView.mm:
4058         (-[WebView toggleContinuousSpellChecking:]):
4059         (-[WebView toggleSmartInsertDelete:]):
4060
4061 2018-08-17  Alex Christensen  <achristensen@webkit.org>
4062
4063         Add some plumbing for safe browsing
4064         https://bugs.webkit.org/show_bug.cgi?id=188709
4065
4066         Reviewed by Tim Horton.
4067
4068         * WebCoreSupport/WebFrameLoaderClient.h:
4069         * WebCoreSupport/WebFrameLoaderClient.mm:
4070         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4071
4072 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
4073
4074         Replace canBubble and cancelable booleans in Event by enum classes
4075         https://bugs.webkit.org/show_bug.cgi?id=188692
4076
4077         Reviewed by Alex Christensen.
4078
4079         * WebView/WebPDFView.mm:
4080         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4081         * WebView/WebView.mm:
4082         (-[WebView _dispatchUnloadEvent]):
4083