Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2
3         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
4         https://bugs.webkit.org/show_bug.cgi?id=183954
5         <rdar://problem/38808858>
6
7         Reviewed by Dan Bernstein.
8
9         * WebView/WebPreferences.mm:
10         (-[WebPreferences setAudioSessionCategoryOverride:]):
11
12 2018-03-23  Tim Horton  <timothy_horton@apple.com>
13
14         Adopt WK_PLATFORM_NAME in WebKitLegacy
15         https://bugs.webkit.org/show_bug.cgi?id=183948
16         <rdar://problem/38803908>
17
18         Reviewed by Dan Bernstein.
19
20         * Configurations/WebKitLegacy.xcconfig:
21         * MigrateHeaders.make:
22         * postprocess-headers.sh:
23
24 2018-03-23  Brady Eidson  <beidson@apple.com>
25
26         Go to back/forward list items after a process-swapped navigation.
27         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
28
29         Reviewed by Andy Estes.
30
31         * WebView/WebView.mm:
32         (-[WebView _loadBackForwardListFromOtherView:]):
33         (-[WebView goToBackForwardItem:]):
34
35 2018-03-22  Tim Horton  <timothy_horton@apple.com>
36
37         Improve readability of WebCore's OTHER_LDFLAGS
38         https://bugs.webkit.org/show_bug.cgi?id=183909
39         <rdar://problem/38760992>
40
41         Reviewed by Dan Bernstein.
42
43         * Configurations/Base.xcconfig:
44         * Configurations/FeatureDefines.xcconfig:
45
46 2018-03-20  Tim Horton  <timothy_horton@apple.com>
47
48         Enable the minimal simulator feature flag when appropriate
49         https://bugs.webkit.org/show_bug.cgi?id=183807
50
51         Reviewed by Dan Bernstein.
52
53         * Configurations/FeatureDefines.xcconfig:
54
55 2018-03-20  Tim Horton  <timothy_horton@apple.com>
56
57         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
58         https://bugs.webkit.org/show_bug.cgi?id=183758
59         <rdar://problem/38017644>
60
61         Reviewed by Dan Bernstein.
62
63         * Configurations/FeatureDefines.xcconfig:
64
65 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
66
67         Clear style colors when setting default appearance
68         https://bugs.webkit.org/show_bug.cgi?id=183759
69
70         Reviewed by Tim Horton.
71
72         Colors are cached and need to be cleared and recalculated.
73         Refactor to do all style recalcs together.
74
75         * WebView/WebView.mm:
76         (-[WebView _setDefaultAppearanceAndClearStyle]):
77         (-[WebView _setUseSystemAppearance:]):
78         (-[WebView effectiveAppearanceDidChange]):
79
80 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
81
82         Unreviewed, another quick fix for r229699
83
84         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
85
86         * Configurations/FeatureDefines.xcconfig:
87
88 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
89
90         Ensure that style is updated when the effective appearance changes
91         https://bugs.webkit.org/show_bug.cgi?id=183690
92         <rdar://problem/38385900>
93
94         Reviewed by Tim Horton and Wenson Hsieh.
95
96         Respond to and respect the effective appearance changing.
97
98         * WebView/WebView.mm:
99         (-[WebView _setUseSystemAppearance:]):
100         (-[WebView effectiveAppearanceDidChange]):
101
102 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
103
104         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
105         https://bugs.webkit.org/show_bug.cgi?id=183677
106
107         Reviewed by Tim Horton.
108
109         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
110
111         * DOM/DOM.mm:
112         (-[DOMHTMLLinkElement _mediaQueryMatches]):
113
114 2018-03-14  Tim Horton  <timothy_horton@apple.com>
115
116         Fix the build after r229567
117
118         * Configurations/FeatureDefines.xcconfig:
119
120 2018-03-12  Tim Horton  <timothy_horton@apple.com>
121
122         Stop using SDK conditionals to control feature definitions
123         https://bugs.webkit.org/show_bug.cgi?id=183430
124         <rdar://problem/38251619>
125
126         Reviewed by Dan Bernstein.
127
128         * Configurations/FeatureDefines.xcconfig:
129         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
130
131 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
132
133         Runtime flag for link prefetch and remove link subresource.
134         https://bugs.webkit.org/show_bug.cgi?id=183540
135
136         Reviewed by Chris Dumez.
137
138         Remove the LINK_PREFETCH build time flag.
139
140         * Configurations/FeatureDefines.xcconfig:
141
142 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
143
144         Remove GridLayout runtime flag
145         https://bugs.webkit.org/show_bug.cgi?id=183484
146
147         Reviewed by Myles C. Maxfield.
148
149         The Grid Layout feature has been enabled by default for almost a
150         year, so I think it's time to remove the runtime flag and the
151
152         * WebView/WebPreferenceKeysPrivate.h:
153         * WebView/WebPreferences.mm:
154         (+[WebPreferences initialize]):
155         * WebView/WebPreferencesPrivate.h:
156         * WebView/WebView.mm:
157         (-[WebView _preferencesChanged:]):
158
159 2018-03-12  Antoine Quint  <graouts@apple.com>
160
161         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
162         https://bugs.webkit.org/show_bug.cgi?id=183504
163         <rdar://problem/38372965>
164
165         Reviewed by Dean Jackson and Jon Lee.
166
167         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
168         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
169
170         * WebView/WebPreferenceKeysPrivate.h:
171         * WebView/WebPreferences.mm:
172         (+[WebPreferences initialize]):
173         (-[WebPreferences setModernMediaControlsEnabled:]):
174         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
175         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
176         * WebView/WebPreferencesPrivate.h:
177         * WebView/WebView.mm:
178         (-[WebView _preferencesChanged:]):
179
180 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
181
182         Media query for default appearance
183         https://bugs.webkit.org/show_bug.cgi?id=183539
184         <rdar://problem/38326388>
185
186         Reviewed by Tim Horton.
187
188         Write a media query to evaluate appearance.
189
190         * WebView/WebView.mm:
191         (-[WebView _commonInitializationWithFrameName:groupName:]):
192         (-[WebView _setUseSystemAppearance:]):
193
194 2018-03-09  Andy Estes  <aestes@apple.com>
195
196         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
197         https://bugs.webkit.org/show_bug.cgi?id=183489
198         <rdar://problem/38267517>
199
200         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
201         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
202         to issue a sandbox extension for this directory, but for security reasons App Sandbox
203         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
204         block with a nil error and a valid file URL, but no file will actually exist at that URL.
205
206         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
207         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
208         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
209         drop destination.
210
211         Reviewed by Wenson Hsieh.
212
213         * WebView/WebView.mm:
214         (-[WebView performDragOperation:]):
215
216 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
217
218         Allow WebViews to disable system appearance
219         https://bugs.webkit.org/show_bug.cgi?id=183418
220         <rdar://problem/36975642>
221
222         Reviewed by Tim Horton.
223
224         Allow webviews to choose whether or not to follow the default system appearance.
225
226         * WebView/WebView.mm:
227         (-[WebView _setUseSystemAppearance:]):
228         (-[WebView _useSystemAppearance]):
229         * WebView/WebViewPrivate.h:
230
231 2018-03-08  Youenn Fablet  <youenn@apple.com>
232
233         libwebrtc update broke internal builds
234         https://bugs.webkit.org/show_bug.cgi?id=183454
235
236         Reviewed by Eric Carlson.
237
238         * Configurations/WebKitLegacy.xcconfig:
239
240 2018-03-08  Chris Dumez  <cdumez@apple.com>
241
242         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
243         https://bugs.webkit.org/show_bug.cgi?id=183455
244         <rdar://problem/38191749>
245
246         Reviewed by Youenn Fablet.
247
248         Add a null check for the page as we have evidence from crashes that it can be null.
249         Other functions in WebFrameNetworkingContext already null check the page as well,
250         not just the frame so this is consistent.
251
252         * WebCoreSupport/WebFrameNetworkingContext.mm:
253         (WebFrameNetworkingContext::storageSession const):
254
255 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
256
257         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
258         https://bugs.webkit.org/show_bug.cgi?id=183429
259
260         Reviewed by Mark Lam.
261
262         * DOM/DOM.mm:
263         (+[DOMNode _nodeFromJSWrapper:]):
264         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
265         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
266         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
267         * Plugins/Hosted/ProxyInstance.mm:
268         (WebKit::ProxyInstance::invokeMethod):
269         * WebView/WebView.mm:
270         (aeDescFromJSValue):
271
272 2018-03-08  Tim Horton  <timothy_horton@apple.com>
273
274         Stop linking ApplicationServices directly
275         https://bugs.webkit.org/show_bug.cgi?id=182867
276         <rdar://problem/38252142>
277
278         Reviewed by Alex Christensen.
279
280         The frameworks that we use that live inside ApplicationServices
281         have mostly moved out, so import them directly.
282
283         * Carbon/CarbonUtils.h:
284         * WebKitPrefix.h:
285         * WebView/WebHTMLView.mm:
286         * WebView/WebPDFView.mm:
287
288 2018-03-07  Tim Horton  <timothy_horton@apple.com>
289
290         Sort and separate FeatureDefines.xcconfig
291         https://bugs.webkit.org/show_bug.cgi?id=183427
292
293         Reviewed by Dan Bernstein.
294
295         * Configurations/FeatureDefines.xcconfig:
296         Sort and split FeatureDefines into paragraphs
297         (to make it easier to sort later).
298
299 2018-03-07  Youenn Fablet  <youenn@apple.com>
300
301         Match unsupported plugins based on domains and not origin
302         https://bugs.webkit.org/show_bug.cgi?id=183384
303
304         Reviewed by Chris Dumez.
305
306         * WebCoreSupport/WebPluginInfoProvider.h:
307         * WebCoreSupport/WebPluginInfoProvider.mm:
308         (WebPluginInfoProvider::getPluginInfo):
309         (WebPluginInfoProvider::getWebVisiblePluginInfo):
310
311 2018-03-05  Andy Estes  <aestes@apple.com>
312
313         [Mac] Teach WebCore::Pasteboard about file promise drags
314         https://bugs.webkit.org/show_bug.cgi?id=183314
315         <rdar://problem/38105493>
316
317         Reviewed by Darin Adler.
318
319         Added a FIXME comment.
320
321         * WebView/WebView.mm:
322         (-[WebView performDragOperation:]):
323
324 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
325
326         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
327         https://bugs.webkit.org/show_bug.cgi?id=183312
328
329         Reviewed by Mark Lam.
330
331         Remove wtf/CurrentTime.h include pragma.
332
333         * WebView/WebFrame.mm:
334         * WebView/WebPDFView.mm:
335
336 2018-03-04  Tim Horton  <timothy_horton@apple.com>
337
338         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
339         https://bugs.webkit.org/show_bug.cgi?id=183283
340         <rdar://problem/38062148>
341
342         Reviewed by Sam Weinig.
343
344         * Configurations/FeatureDefines.xcconfig:
345
346 2018-02-28  Alex Christensen  <achristensen@webkit.org>
347
348         Reduce use of NetworkingContext in WebKit
349         https://bugs.webkit.org/show_bug.cgi?id=183213
350
351         Reviewed by Brady Eidson.
352
353         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
354         (WebKit::NetscapePluginInstanceProxy::getProxy):
355         * Plugins/WebNetscapePluginView.mm:
356         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
357
358 2018-02-17  Darin Adler  <darin@apple.com>
359
360         Prepare for ExtendedColor changes (first step)
361         https://bugs.webkit.org/show_bug.cgi?id=182904
362
363         Reviewed by Sam Weinig.
364
365         * Misc/WebKitNSStringExtras.mm:
366         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
367
368 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
369
370         Remove currentTime() / currentTimeMS()
371         https://bugs.webkit.org/show_bug.cgi?id=183052
372
373         Reviewed by Mark Lam.
374
375         * WebCoreSupport/WebFrameLoaderClient.h:
376         * WebCoreSupport/WebFrameLoaderClient.mm:
377         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
378
379 2018-02-16  Youenn Fablet  <youenn@apple.com>
380
381         Allow specifying which plug-ins are supported
382         https://bugs.webkit.org/show_bug.cgi?id=182748
383
384         Reviewed by Chris Dumez.
385
386         * WebCoreSupport/WebPluginInfoProvider.h:
387         * WebCoreSupport/WebPluginInfoProvider.mm:
388         (WebPluginInfoProvider::getPluginInfo):
389         (WebPluginInfoProvider::getWebVisiblePluginInfo):
390
391 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
392
393         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
394         https://bugs.webkit.org/show_bug.cgi?id=182882
395         <rdar://problem/35672661>
396
397         Reviewed by Dan Bernstein.
398
399         Make sure the smart pointer hold the collection of subviews lives at least as
400         long as the loop using it.
401
402         * WebView/WebHTMLView.mm:
403         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
404
405 2018-02-14  Daniel Bates  <dabates@apple.com>
406
407         Disallow cross-origin subresources from asking for credentials
408         https://bugs.webkit.org/show_bug.cgi?id=182579
409         <rdar://problem/36162271>
410
411         Reviewed by Andy Estes.
412
413         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
414         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
415
416         * WebView/WebPreferenceKeysPrivate.h:
417         * WebView/WebPreferences.mm:
418         (+[WebPreferences initialize]):
419         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
420         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
421         * WebView/WebPreferencesPrivate.h:
422         * WebView/WebView.mm:
423         (-[WebView _preferencesChanged:]):
424
425 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
426
427         Remove ForwardingHeaders directory from WebKitLegacy/mac.
428         https://bugs.webkit.org/show_bug.cgi?id=182738
429
430         Reviewed by Darin Adler.
431
432         * ForwardingHeaders/collector/handles/Global.h: Removed.
433         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
434         * ForwardingHeaders/runtime/Completion.h: Removed.
435         * ForwardingHeaders/runtime/Error.h: Removed.
436         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
437         * ForwardingHeaders/runtime/JSFunction.h: Removed.
438         * ForwardingHeaders/runtime/JSLock.h: Removed.
439         * ForwardingHeaders/runtime/JSObject.h: Removed.
440         * ForwardingHeaders/runtime/JSString.h: Removed.
441         * ForwardingHeaders/runtime/Protect.h: Removed.
442         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
443
444 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
445
446         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
447         https://bugs.webkit.org/show_bug.cgi?id=182641
448
449         Reviewed by Dan Bernstein.
450
451         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
452         https://trac.webkit.org/changeset/228308.
453
454         * WebView/WebVideoFullscreenController.h:
455         * WebView/WebVideoFullscreenHUDWindowController.mm:
456         * WebView/WebWindowAnimation.h:
457         * WebView/WebWindowAnimation.mm:
458         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
459         (WebCore::scaledRect): Deleted.
460         (WebCore::squaredDistance): Deleted.
461
462 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
463
464         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
465
466         * WebView/WebWindowAnimation.mm:
467         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
468
469 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
470
471         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
472         https://bugs.webkit.org/show_bug.cgi?id=182615
473
474         Reviewed by Eric Carlson.
475
476         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
477         Ideally, we should not reference NSApp in WebCore.
478
479         * WebView/WebFullScreenController.mm:
480         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
481         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
482         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
483         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
484         * WebView/WebView.mm:
485         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
486         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
487
488 2018-01-13  Darin Adler  <darin@apple.com>
489
490         Event improvements
491         https://bugs.webkit.org/show_bug.cgi?id=179591
492
493         Reviewed by Chris Dumez.
494
495         * DOM/DOMWheelEvent.mm:
496         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
497         Call initWebKitWheelEvent.
498
499         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
500         * WebCoreSupport/WebInspectorClient.mm: Ditto.
501         * WebView/WebFrame.mm: Ditto.
502
503         * WebView/WebHTMLView.mm:
504         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
505         underlyingPlatformEvent.
506         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
507
508         * WebView/WebScriptWorld.mm:
509         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
510
511         * WebView/WebView.mm: Removed include of ScriptValue.h.
512
513 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
514
515         Remove WebCore/ForwardingHeaders directory
516         https://bugs.webkit.org/show_bug.cgi?id=182347
517
518         Reviewed by Keith Miller.
519
520         * Carbon/CarbonWindowAdapter.mm:
521         * DOM/WebDOMOperations.mm:
522         * History/WebBackForwardList.mm:
523         * History/WebHistoryItem.mm:
524         * Misc/WebCache.mm:
525         * Misc/WebElementDictionary.mm:
526         * Misc/WebIconDatabase.mm:
527         * Misc/WebStringTruncator.mm:
528         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
529         * Plugins/Hosted/ProxyInstance.mm:
530         * Plugins/Hosted/ProxyRuntimeObject.mm:
531         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
532         * Plugins/WebBaseNetscapePluginView.mm:
533         * Plugins/WebBasePluginPackage.mm:
534         * Plugins/WebNetscapePluginStream.mm:
535         * Plugins/WebNetscapePluginView.mm:
536         * Plugins/WebPluginController.mm:
537         * WebCoreSupport/WebEditorClient.mm:
538         * WebCoreSupport/WebFrameLoaderClient.mm:
539         * WebCoreSupport/WebInspectorClient.h:
540         * WebCoreSupport/WebInspectorClient.mm:
541         * WebView/WebDataSource.mm:
542         * WebView/WebFrame.mm:
543         * WebView/WebHTMLRepresentation.mm:
544         * WebView/WebHTMLView.mm:
545         * WebView/WebPreferences.mm:
546         * WebView/WebScriptDebugDelegate.mm:
547         * WebView/WebScriptDebugger.h:
548         * WebView/WebTextIterator.mm:
549         * WebView/WebView.mm:
550         * WebView/WebViewData.mm:
551
552 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
553
554         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
555         https://bugs.webkit.org/show_bug.cgi?id=182312
556
557         Reviewed by Michael Catanzaro.
558
559         * WebKitPrefix.h:
560
561 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
562
563         [WebAuthN] Add a compile-time feature flag
564         https://bugs.webkit.org/show_bug.cgi?id=182211
565         <rdar://problem/36936365>
566
567         Reviewed by Brent Fulgham.
568
569         * Configurations/FeatureDefines.xcconfig:
570
571 2018-01-27  Dan Bernstein  <mitz@apple.com>
572
573         HaveInternalSDK includes should be "#include?"
574         https://bugs.webkit.org/show_bug.cgi?id=179670
575
576         * Configurations/Base.xcconfig:
577
578 2018-01-24  Alex Christensen  <achristensen@webkit.org>
579
580         Remove unused QTKit preference
581         https://bugs.webkit.org/show_bug.cgi?id=181968
582
583         Reviewed by Alexey Proskuryakov.
584
585         * WebView/WebPreferenceKeysPrivate.h:
586         * WebView/WebPreferences.mm:
587         (+[WebPreferences initialize]):
588         (-[WebPreferences setQTKitEnabled:]): Deleted.
589         (-[WebPreferences isQTKitEnabled]): Deleted.
590         * WebView/WebPreferencesPrivate.h:
591         * WebView/WebView.mm:
592         (-[WebView _preferencesChanged:]):
593
594 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
595
596         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
597         https://bugs.webkit.org/show_bug.cgi?id=182037
598         <rdar://problem/36747812>
599
600         Reviewed by Ryosuke Niwa.
601
602         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
603         for more details.
604
605         * WebView/WebHTMLRepresentation.mm:
606         (-[WebHTMLRepresentation elementWithName:inForm:]):
607         (-[WebHTMLRepresentation controlsInForm:]):
608
609 2018-01-23  Alex Christensen  <achristensen@webkit.org>
610
611         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
612         https://bugs.webkit.org/show_bug.cgi?id=181961
613
614         Reviewed by Michael Catanzaro.
615
616         * WebView/WebPreferences.mm:
617
618 2018-01-23  Commit Queue  <commit-queue@webkit.org>
619
620         Unreviewed, rolling out r227437.
621         https://bugs.webkit.org/show_bug.cgi?id=182011
622
623         broke build (Requested by alexchristensen on #webkit).
624
625         Reverted changeset:
626
627         "Remove unused QTKit preference"
628         https://bugs.webkit.org/show_bug.cgi?id=181968
629         https://trac.webkit.org/changeset/227437
630
631 2018-01-23  Alex Christensen  <achristensen@webkit.org>
632
633         Remove unused QTKit preference
634         https://bugs.webkit.org/show_bug.cgi?id=181968
635
636         Reviewed by Alexey Proskuryakov.
637
638         * WebView/WebPreferenceKeysPrivate.h:
639         * WebView/WebPreferences.mm:
640         (+[WebPreferences initialize]):
641         (-[WebPreferences setQTKitEnabled:]): Deleted.
642         (-[WebPreferences isQTKitEnabled]): Deleted.
643         * WebView/WebPreferencesPrivate.h:
644         * WebView/WebView.mm:
645         (-[WebView _preferencesChanged:]):
646
647 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
648
649         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
650         https://bugs.webkit.org/show_bug.cgi?id=181960
651         <rdar://problem/36431678>
652
653         Reviewed by Tim Horton.
654
655         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
656         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
657         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
658
659         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
660         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
661         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
662
663         * WebView/WebView.mm:
664         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
665
666 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
667
668         Turning off custom pasteboard data doesn't actually turn it off in WK2
669         https://bugs.webkit.org/show_bug.cgi?id=181920
670         <rdar://problem/36686429>
671
672         Reviewed by Wenson Hsieh.
673
674         Always disable custom pasteboard data in WebKit1. See r226156 for details.
675
676         * WebView/WebPreferences.mm:
677         (+[WebPreferences initialize]):
678         * WebView/WebView.mm:
679         (-[WebView _preferencesChanged:]):
680
681 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
682
683         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
684         https://bugs.webkit.org/show_bug.cgi?id=181918
685
686         Reviewed by Tim Horton.
687
688         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
689
690         * Configurations/FeatureDefines.xcconfig:
691
692 2018-01-20  Andy Estes  <aestes@apple.com>
693
694         [Apple Pay] Stop eagerly loading PassKit.framework
695         https://bugs.webkit.org/show_bug.cgi?id=181911
696         <rdar://problem/36555369>
697
698         Reviewed by Tim Horton.
699
700         * WebCoreSupport/WebPaymentCoordinatorClient.h:
701         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
702         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
703
704         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
705
706 2018-01-19  Dean Jackson  <dino@apple.com>
707
708         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
709         https://bugs.webkit.org/show_bug.cgi?id=181817
710         <rdar://problem/35274055>
711
712         Reviewed by Simon Fraser.
713
714         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
715
716         * Misc/WebKitVersionChecks.h:
717         * WebView/WebView.mm:
718         (-[WebView _commonInitializationWithFrameName:groupName:]):
719
720 2018-01-19  Alex Christensen  <achristensen@webkit.org>
721
722         Remove unused WebViewPrivate _allowCookies
723         https://bugs.webkit.org/show_bug.cgi?id=181812
724
725         Reviewed by Tim Horton.
726
727         * WebView/WebView.mm:
728         (+[WebView _setAllowCookies:]): Deleted.
729         (+[WebView _allowCookies]): Deleted.
730         * WebView/WebViewPrivate.h:
731
732 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
733
734         Build fix, remove a call to -[NSWindow setOneShot:]
735         https://bugs.webkit.org/show_bug.cgi?id=181809
736
737         Reviewed by Tim Horton.
738
739         * WebView/WebTextCompletionController.mm:
740         (-[WebTextCompletionController _buildUI]):
741
742 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
743
744         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
745
746         * Carbon/HIWebView.mm:
747         (overrideCGContext):
748         (restoreCGContext):
749
750 2018-01-18  Dan Bernstein  <mitz@apple.com>
751
752         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
753         https://bugs.webkit.org/show_bug.cgi?id=181803
754
755         Reviewed by Tim Horton.
756
757         * Configurations/Base.xcconfig: Updated.
758         * Configurations/DebugRelease.xcconfig: Ditto.
759         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
760         * Configurations/Version.xcconfig: Updated.
761         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
762           useful for defining settings that depend on the target macOS version.
763
764 2018-01-17  Youenn Fablet  <youenn@apple.com>
765
766         Put fetch Request.keepalive behind a runtime flag
767         https://bugs.webkit.org/show_bug.cgi?id=181592
768
769         Reviewed by Chris Dumez.
770
771         * WebView/WebPreferenceKeysPrivate.h:
772         * WebView/WebPreferences.mm:
773         (+[WebPreferences initialize]):
774         (-[WebPreferences fetchAPIKeepAliveEnabled]):
775         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
776         * WebView/WebPreferencesPrivate.h:
777         * WebView/WebView.mm:
778         (-[WebView _preferencesChanged:]):
779
780 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
781
782         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
783         https://bugs.webkit.org/show_bug.cgi?id=181637
784         <rdar://problem/36508471>
785
786         Reviewed by Tim Horton.
787
788         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
789
790         * WebCoreSupport/WebEditorClient.h:
791         * WebCoreSupport/WebEditorClient.mm:
792         (WebEditorClient::replacementURLForResource):
793
794 2018-01-11  Keith Miller  <keith_miller@apple.com>
795
796         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
797         https://bugs.webkit.org/show_bug.cgi?id=181573
798
799         Reviewed by Simon Fraser.
800
801         * Configurations/FeatureDefines.xcconfig:
802
803 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
804
805         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
806         https://bugs.webkit.org/show_bug.cgi?id=181497
807
808         Reviewed by Tim Horton.
809
810         See other ChangeLogs for more detail.
811
812         * WebCoreSupport/WebDragClient.h:
813
814 2018-01-11  Tim Horton  <timothy_horton@apple.com>
815
816         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
817         https://bugs.webkit.org/show_bug.cgi?id=181523
818         <rdar://problem/28959131>
819
820         Reviewed by Alex Christensen.
821
822         * WebView/WebImmediateActionController.mm:
823         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
824         Apply the change made in r216652 to WebKit1's immediate action controller.
825
826         Speculative (but successful in WebKit2) fix for non-reproducible crash when
827         the startContainer of the range is in an anonymous node.
828
829 2018-01-11  Youenn Fablet  <youenn@apple.com>
830
831         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
832         https://bugs.webkit.org/show_bug.cgi?id=181480
833
834         Reviewed by Eric Carlson.
835
836         * WebView/WebPreferences.mm:
837         (+[WebPreferences initialize]):
838
839 2018-01-08  David Kilzer  <ddkilzer@apple.com>
840
841         Fix check-webkit-style issues with WebNSDataExtras.mm
842         <https://webkit.org/b/181369>
843
844         Reviewed by Alex Christensen.
845
846         * Misc/WebNSDataExtras.mm:
847         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
848         (-[NSData _webkit_guessedMIMETypeForXML]):
849         (-[NSData _webkit_guessedMIMEType]):
850         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
851         (_findEOL):
852         (-[NSData _webkit_parseRFC822HeaderFields]):
853         (-[NSData _web_locationAfterFirstBlankLine]):
854         - Fix all the check-webkit-style warnings.
855
856 2018-01-08  David Kilzer  <ddkilzer@apple.com>
857
858         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
859         <https://webkit.org/b/181256>
860         <rdar://problem/36281730>
861
862         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
863         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
864         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
865           to avoid warnings from casting CFStringRef to NPNSString*.
866           Note that CFMutableStringRef is the same as CFStringRef
867           without the const modifier, hence its use in the const_cast<>
868           above.
869
870 2018-01-08  David Kilzer  <ddkilzer@apple.com>
871
872         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
873         <https://webkit.org/b/181256>
874         <rdar://problem/36281730>
875
876         * Carbon/HIWebView.mm:
877         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
878         checked_cf_cast<CFRunLoopRef>() to fix warning.
879
880 2018-01-07  David Kilzer  <ddkilzer@apple.com>
881
882         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
883         <https://webkit.org/b/181256>
884         <rdar://problem/36281730>
885
886         Reviewed by Darin Adler.
887
888         * Carbon/CarbonUtils.m:
889         (PoolCleaner):
890         - Use #pragmas to ignore -Wcast-qual warnings when using a
891           C-style cast from CFTypeRef to CFRunloopRef.
892         * Carbon/CarbonWindowFrame.m:
893         (-[CarbonWindowFrame title]):
894         - Use #pragmas to ignore -Wcast-qual warnings when using a
895           C-style cast from CFStringRef to NSString *.
896         * Carbon/HIViewAdapter.m:
897         (+[HIViewAdapter getHIViewForNSView:]):
898         - Use #pragmas to ignore -Wcast-qual warnings when using a
899           C-style cast from CFTypeRef to HIViewRef.
900         * Configurations/Base.xcconfig:
901         (WARNING_CFLAGS): Add -Wcast-qual.
902         * Misc/WebElementDictionary.mm:
903         (-[WebElementDictionary objectForKey:]):
904         - Use static_cast<SEL>(const_cast<void*>()) to fix
905           warning.
906         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
907         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
908         (-[NSData _webkit_guessedMIMETypeForXML]):
909         (-[NSData _webkit_guessedMIMEType]):
910         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
911         (_findEOL):
912         (-[NSData _webkit_parseRFC822HeaderFields]):
913         (-[NSData _web_startsWithBlankLine]):
914         (-[NSData _web_locationAfterFirstBlankLine]):
915         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
916           type to Objective-C++.  This fixes the warnings about
917           discarding the `const` modifier when casing from CFStringRef
918           to NSString * because in older clang versions, -Wcast-qual was
919           completely broken when compiling C++ and Objective-C++ source
920           files.  In newer clang versions, discarding the `const`
921           modifier for toll-free bridged types is ignored when compiling
922           Objective-C++ source.
923         - Update copyright and license header.
924         - Use reinterpret_cast<> and static_cast<> to fix warnings
925           unrelated to (NSString *) C-style casts.
926         - Replace use of MIN() macro with std::min<> template functions.
927         - Fix location of `*` for local variables modified above.
928         * Plugins/Hosted/NetscapePluginHostManager.mm:
929         (WebKit::NetscapePluginHostManager::spawnPluginHost):
930         (WebKit::NetscapePluginHostManager::initializeVendorPort):
931         (WebKit::NetscapePluginHostManager::instantiatePlugin):
932         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
933           warnings.
934         * Plugins/Hosted/NetscapePluginHostProxy.mm:
935         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
936         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
937           to fix warning.
938         * Plugins/Hosted/ProxyInstance.mm:
939         (WebKit::ProxyInstance::invoke):
940         - Use static_cast<char*>(const_cast<void*>()) to fix
941           warning when using -[NSData bytes].
942         (WebKit::ProxyInstance::fieldValue const):
943         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
944           to fix warning when using CFDataGetBytePtr().
945         * Plugins/Hosted/WebTextInputWindowController.m:
946         (-[WebTextInputPanel _interpretKeyEvent:string:]):
947         - Use #pragma to ignore -Wcast-qual warning since there
948           is not a good way to avoid this warning in Objective-C.
949         * Plugins/WebNetscapePluginStream.mm:
950         (WebNetscapePluginStream::deliverData):
951         - Use const_cast<void*>() to fix warning when using
952           -[NSData bytes].
953         * Plugins/WebNetscapePluginView.mm:
954         (-[WebNetscapePluginView _createPlugin]):
955         - Change C-style cast to const_cast<char*>() to fix
956           warning.
957         * WebCoreSupport/WebChromeClient.mm:
958         (WebChromeClient::wrapCryptoKey const):
959         (WebChromeClient::unwrapCryptoKey const):
960         - Change C-style cast to
961           static_cast<uint8_t*>(const_cast<void*>() to fix
962           warning.
963         * WebView/WebPDFView.mm:
964         (_applicationInfoForMIMEType):
965         - Change local variable type from 'NSURL *' to
966           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
967           when calling -[NSURL path].
968
969 2018-01-05  Dan Bernstein  <mitz@apple.com>
970
971         Fixed the build following AppKit API deprecations in a recent SDKs
972
973         * WebView/WebFullScreenController.mm:
974         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
975         (-[WebFullScreenController exitFullScreen]): Ditto.
976         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
977         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
978         * WebView/WebHTMLView.mm:
979         (-[WebHTMLView drawRect:]): Ditto.
980         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
981         (-[WebHTMLView knowsPageRange:]): Ditto.
982         * WebView/WebView.mm:
983         (LayerFlushController::flushLayers): Ditto.
984
985 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
986
987         [Attachment Support] Create attachment elements when dropping files on iOS
988         https://bugs.webkit.org/show_bug.cgi?id=181192
989         <rdar://problem/36280945>
990
991         Reviewed by Tim Horton.
992
993         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
994
995         * WebCoreSupport/WebPlatformStrategies.h:
996         * WebCoreSupport/WebPlatformStrategies.mm:
997         (WebPlatformStrategies::informationForItemAtIndex):
998         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
999
1000 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1001
1002         [Attachment Support] Add plumbing for starting a drag with promised blob data
1003         https://bugs.webkit.org/show_bug.cgi?id=181201
1004
1005         Reviewed by Tim Horton.
1006
1007         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1008
1009         * WebCoreSupport/WebDragClient.h:
1010
1011 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1012
1013         Add a WebAuthentication runtime feature flag
1014         https://bugs.webkit.org/show_bug.cgi?id=181220
1015         <rdar://problem/36055305>
1016
1017         Reviewed by Brent Fulgham.
1018
1019         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1020
1021         * WebView/WebPreferenceKeysPrivate.h:
1022         * WebView/WebPreferences.mm:
1023         (+[WebPreferences initialize]):
1024         (-[WebPreferences webAuthenticationEnabled]):
1025         (-[WebPreferences setWebAuthenticationEnabled:]):
1026         (-[WebPreferences credentialManagementEnabled]): Deleted.
1027         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1028         * WebView/WebPreferencesPrivate.h:
1029         * WebView/WebView.mm:
1030         (-[WebView _preferencesChanged:]):
1031
1032 2017-12-22  Jeff Miller  <jeffm@apple.com>
1033
1034         Update user-visible copyright strings to include 2018
1035         https://bugs.webkit.org/show_bug.cgi?id=181141
1036
1037         Reviewed by Dan Bernstein.
1038
1039         * Info.plist:
1040
1041 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1042
1043         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1044         https://bugs.webkit.org/show_bug.cgi?id=181188
1045
1046         Reviewed by Dan Bernstein.
1047
1048         See WebCore/ChangeLog for more detail.
1049
1050         * WebCoreSupport/WebDragClient.h:
1051         * WebCoreSupport/WebDragClient.mm:
1052         (WebDragClient::declareAndWriteAttachment): Deleted.
1053         * WebView/WebHTMLView.mm:
1054         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1055
1056 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         Unreviewed, continue to fix build failures due to AppKit API deprecation
1059
1060         Wraps more code in -Wdeprecated-declarations.
1061
1062         * Carbon/HIWebView.mm:
1063         (overrideCGContext):
1064
1065 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1066
1067         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1068
1069         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1070
1071         * Carbon/CarbonWindowAdapter.mm:
1072         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1073         * Plugins/WebNetscapePluginView.mm:
1074         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1075         (-[WebNetscapePluginView sendDrawRectEvent:]):
1076         (-[WebNetscapePluginView drawRect:]):
1077
1078 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         Fix build failures due to using deprecated AppKit symbols
1081         https://bugs.webkit.org/show_bug.cgi?id=181110
1082         <rdar://problem/36162865>
1083
1084         Reviewed by Dan Bernstein and Tim Horton.
1085
1086         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1087
1088         * Misc/WebKitNSStringExtras.mm:
1089         (-[NSString _web_drawAtPoint:font:textColor:]):
1090         * Misc/WebNSPasteboardExtras.h:
1091         * Misc/WebNSPasteboardExtras.mm:
1092         (+[NSPasteboard _web_writableTypesForURL]):
1093         (_createWritableTypesForImageWithoutArchive):
1094         (_createWritableTypesForImageWithArchive):
1095         (+[NSPasteboard _web_dragTypesForURL]):
1096         (-[NSPasteboard _web_bestURL]):
1097         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1098         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1099         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1100         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1101         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1102         * Panels/WebAuthenticationPanel.m:
1103         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1104         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1105         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1106         (-[WebHostedNetscapePluginView drawRect:]):
1107         * WebInspector/WebNodeHighlightView.mm:
1108         (-[WebNodeHighlightView drawRect:]):
1109         * WebView/WebFrame.mm:
1110         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1111         (-[WebFrame _drawRect:contentsOnly:]):
1112         * WebView/WebHTMLView.mm:
1113         (kit):
1114         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1115         (-[WebHTMLView _plainTextFromPasteboard:]):
1116         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1117         (+[WebHTMLView _insertablePasteboardTypes]):
1118         (+[WebHTMLView _selectionPasteboardTypes]):
1119         (-[WebHTMLView pasteboard:provideDataForType:]):
1120         (-[WebHTMLView _writeSelectionToPasteboard:]):
1121         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1122         (-[WebHTMLView validRequestorForSendType:returnType:]):
1123         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1124         (createMenuItem):
1125         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1126         (-[WebHTMLView _colorAsString:]):
1127         (-[WebHTMLView copyFont:]):
1128         * WebView/WebPDFView.mm:
1129         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1130         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1131         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1132         (-[WebPDFView pasteboardTypesForSelection]):
1133         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1134         * WebView/WebView.h:
1135         * WebView/WebView.mm:
1136         (-[WebView performDragOperation:]):
1137         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1138         (-[WebView _searchWithGoogleFromMenu:]):
1139
1140 2017-12-21  Youenn Fablet  <youenn@apple.com>
1141
1142         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1143         https://bugs.webkit.org/show_bug.cgi?id=181000
1144
1145         Reviewed by Chris Dumez.
1146
1147         * Misc/WebCache.mm:
1148         (+[WebCache addImageToCache:forURL:forFrame:]):
1149
1150 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1151
1152         Update FULLSCREEN_API feature defines.
1153         https://bugs.webkit.org/show_bug.cgi?id=181015
1154
1155         Reviewed by Tim Horton.
1156
1157         Change enabled iphone sdk for FULLSCREEN_API.
1158
1159         * Configurations/FeatureDefines.xcconfig:
1160
1161 2017-12-21  Jer Noble  <jer.noble@apple.com>
1162
1163         Add initial DOM support for Media Capabilities
1164         https://bugs.webkit.org/show_bug.cgi?id=181064
1165
1166         Reviewed by Eric Carlson.
1167
1168         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1169
1170         * WebView/WebPreferenceKeysPrivate.h:
1171         * WebView/WebPreferences.mm:
1172         (+[WebPreferences initialize]):
1173         (-[WebPreferences mediaCapabilitiesEnabled]):
1174         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1175         * WebView/WebPreferencesPrivate.h:
1176         * WebView/WebView.mm:
1177         (-[WebView _preferencesChanged:]):
1178
1179 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1180
1181         Enable picture-in-picture from inline element on suspend.
1182         https://bugs.webkit.org/show_bug.cgi?id=180942
1183         rdar://problem/34745234
1184
1185         Reviewed by Jer Noble.
1186
1187         Update signature of enterVideoFullscreenForVideoElement().
1188
1189         * WebCoreSupport/WebChromeClient.h:
1190         * WebCoreSupport/WebChromeClient.mm:
1191         (WebChromeClient::enterVideoFullscreenForVideoElement):
1192
1193 2017-12-20  Daniel Bates  <dabates@apple.com>
1194
1195         Remove Alternative Presentation Button
1196         https://bugs.webkit.org/show_bug.cgi?id=180500
1197         <rdar://problem/35891047>
1198
1199         Reviewed by Simon Fraser.
1200
1201         We no longer need the alternative presentation button.
1202
1203         * Configurations/FeatureDefines.xcconfig:
1204
1205 2017-12-19  Jer Noble  <jer.noble@apple.com>
1206
1207         Playing media elements which call "pause(); play()" will have the play promise rejected.
1208         https://bugs.webkit.org/show_bug.cgi?id=180781
1209         <rdar://problem/33191377>
1210
1211         Reviewed by Eric Carlson.
1212
1213         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1214
1215         * WebView/WebView.mm:
1216         (shouldRequireUserGestureToLoadVideo):
1217
1218 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1219
1220         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1221         https://bugs.webkit.org/show_bug.cgi?id=180977
1222
1223         Reviewed by Tim Horton.
1224
1225         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1226         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1227         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1228
1229         * WebCoreSupport/WebEditorClient.mm:
1230         (attributesForAttributedStringConversion):
1231         * WebView/WebHTMLView.mm:
1232         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1233
1234 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1235
1236         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1237
1238         Attempt to fix the following warnings:
1239
1240             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1241
1242         For the following instance variables:
1243
1244             _borderView
1245             _contentView
1246             _frame
1247             _wFlags
1248
1249         * Carbon/CarbonWindowAdapter.mm:
1250         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1251         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1252         (-[CarbonWindowAdapter _termWindowIfOwner]):
1253         (-[CarbonWindowAdapter _windowMovedToRect:]):
1254         (-[CarbonWindowAdapter setContentView:]):
1255         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1256         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1257
1258 2017-12-16  Dan Bernstein  <mitz@apple.com>
1259
1260         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1261         https://bugs.webkit.org/show_bug.cgi?id=180613
1262         <rdar://problem/35946124>
1263
1264         Reviewed by Geoff Garen.
1265
1266         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1267           clients.
1268         * WebView/WebDynamicScrollBarsView.h: Ditto.
1269         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1270
1271 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1272
1273         Enable -Wstrict-prototypes for WebKit
1274         <https://webkit.org/b/180757>
1275         <rdar://problem/36024132>
1276
1277         Rubber-stamped by Joseph Pecoraro.
1278
1279         * Configurations/Base.xcconfig:
1280         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1281
1282 2017-12-14  John Wilander  <wilander@apple.com>
1283
1284         Storage Access API: Implement frame-specific access in the document.cookie layer
1285         https://bugs.webkit.org/show_bug.cgi?id=180682
1286         <rdar://problem/35982257>
1287
1288         Reviewed by Alex Christensen.
1289
1290         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1291         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1292         CookiesStrategy::getRawCookies() now take optional parameters for
1293         frameID and pageID to allow frame-specific scoping of cookies.
1294
1295         This change makes the return values of FrameLoaderClient::frameID()
1296         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1297         WebCore can call those getters and get the right return values in
1298         WebKit and std:nullopt in WebKitLegacy.
1299
1300         * WebCoreSupport/WebFrameLoaderClient.h:
1301         * WebCoreSupport/WebFrameLoaderClient.mm:
1302         (WebFrameLoaderClient::pageID const):
1303         (WebFrameLoaderClient::frameID const):
1304         * WebCoreSupport/WebPlatformStrategies.h:
1305         * WebCoreSupport/WebPlatformStrategies.mm:
1306         (WebPlatformStrategies::cookiesForDOM):
1307         (WebPlatformStrategies::setCookiesFromDOM):
1308         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1309         (WebPlatformStrategies::getRawCookies):
1310
1311 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1312
1313         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1314         https://bugs.webkit.org/show_bug.cgi?id=180689
1315
1316         Reviewed by Tim Horton.
1317
1318         Use sRGBColorSpaceRef() from WebCore.
1319
1320         * WebView/WebHTMLView.mm:
1321         (imageFromRect):
1322
1323 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1324
1325         Stop using deprecated target conditional for simulator builds
1326         https://bugs.webkit.org/show_bug.cgi?id=180662
1327         <rdar://problem/35136156>
1328
1329         Reviewed by Simon Fraser.
1330
1331         * postprocess-headers.sh:
1332
1333 2017-12-11  David Quesada  <david_quesada@apple.com>
1334
1335         Turn on ENABLE_APPLICATION_MANIFEST
1336         https://bugs.webkit.org/show_bug.cgi?id=180562
1337         rdar://problem/35924737
1338
1339         Reviewed by Geoffrey Garen.
1340
1341         * Configurations/FeatureDefines.xcconfig:
1342
1343 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1344
1345         Remove pthread_once in favor of dispatch_once
1346         https://bugs.webkit.org/show_bug.cgi?id=180591
1347
1348         Reviewed by Saam Barati.
1349
1350         * Misc/WebKitErrors.m:
1351         (+[NSError _registerWebKitErrors]):
1352         (registerErrors): Deleted.
1353         * Storage/WebStorageManager.mm:
1354         (+[WebStorageManager _storageDirectoryPath]):
1355         (initializeLocalStoragePath): Deleted.
1356
1357 2017-12-07  Darin Adler  <darin@apple.com>
1358
1359         Remove some unused code from WebKitLegacy
1360         https://bugs.webkit.org/show_bug.cgi?id=180567
1361
1362         Reviewed by Anders Carlsson.
1363
1364         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1365         macOS (back a few versions) and iOS and removed unused
1366         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1367         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1368         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1369         _webkit_stringByCollapsingNonPrintingCharacters,
1370         _webkit_stringByCollapsingWhitespaceCharacters,
1371         _web_stringWithData:textEncodingName:, and
1372         _webkit_localStorageDirectoryWithBundleIdentifier:.
1373
1374         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1375         this source file.
1376         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1377         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1378         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1379         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1380         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1381         handle font smoothing options.
1382         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1383         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1384         from header and made it a little clearer.
1385         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1386         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1387         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1388         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1389         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1390         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1391         implementation a bit and used whole words instead of abbreviations.
1392         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1393
1394         * Misc/WebNSFileManagerExtras.mm:
1395         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1396         filenameByFixingIllegalCharacters function from WebCore directly instead of
1397         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1398
1399         * Plugins/WebBaseNetscapePluginView.mm:
1400         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1401         string replacements instead of _web_stringByStrippingReturnCharacters
1402         and to use NSString methods instead of CFString functions.
1403
1404 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1405
1406         Ignore deprecation warnings.
1407
1408         * WebView/WebHTMLView.mm:
1409         (-[NSWindow _web_borderView]):
1410         (-[WebHTMLView _setAsideSubviews]):
1411         * WebView/WebView.mm:
1412         (-[WebView encodeWithCoder:]):
1413
1414 2017-12-02  Darin Adler  <darin@apple.com>
1415
1416         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1417         https://bugs.webkit.org/show_bug.cgi?id=180009
1418
1419         Reviewed by Alex Christensen.
1420
1421         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1422
1423         * Plugins/WebBaseNetscapePluginView.mm:
1424         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1425         of strcasecmp.
1426
1427         * WebView/WebPreferences.mm:
1428         (contains): Ditto. Also made this a template so it's easier to call on an array.
1429         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1430
1431 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1432
1433         Limit user agent versioning to an upper bound
1434         https://bugs.webkit.org/show_bug.cgi?id=180365
1435         <rdar://problem/34550617>
1436
1437         Reviewed by Joseph Pecoraro.
1438
1439         * WebView/WebView.mm:
1440         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1441         creating the User Agent string.
1442         (webKitBundleVersionString): Deleted.
1443
1444 2017-12-05  Andy Estes  <aestes@apple.com>
1445
1446         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1447         https://bugs.webkit.org/show_bug.cgi?id=180457
1448         <rdar://problem/35143007>
1449
1450         Reviewed by Tim Horton.
1451
1452         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1453         check for this macro during post-processing.
1454
1455         * postprocess-headers.sh:
1456
1457 2017-12-04  David Quesada  <david_quesada@apple.com>
1458
1459         Add a class for parsing application manifests
1460         https://bugs.webkit.org/show_bug.cgi?id=177973
1461         rdar://problem/34747949
1462
1463         Reviewed by Geoffrey Garen.
1464
1465         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1466
1467 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1468
1469         Make LegacyCustomProtocolManager optional for network process
1470         https://bugs.webkit.org/show_bug.cgi?id=176230
1471
1472         Reviewed by Alex Christensen.
1473
1474         * Configurations/FeatureDefines.xcconfig:
1475
1476 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1477
1478         Fix some NSOperationQueue leaks
1479         https://bugs.webkit.org/show_bug.cgi?id=180221
1480
1481         Reviewed by Wenson Hsieh.
1482
1483         * WebView/WebView.mm:
1484         (-[WebView performDragOperation:]):
1485
1486 2017-11-30  Darin Adler  <darin@apple.com>
1487
1488         [Mac] remove unneeded RetainPtr use introduced in r225142
1489         https://bugs.webkit.org/show_bug.cgi?id=180202
1490
1491         Reviewed by Tim Horton.
1492
1493         * WebView/WebImmediateActionController.mm:
1494         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1495         RetainPtr.
1496
1497 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1498
1499         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1500         https://bugs.webkit.org/show_bug.cgi?id=175595
1501
1502         Reviewed by Darin Adler.
1503
1504         * WebView/WebPreferences.mm:
1505
1506 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1507
1508         One too many zeroes in macOS version number in FeatureDefines
1509         https://bugs.webkit.org/show_bug.cgi?id=180011
1510
1511         Reviewed by Dan Bernstein.
1512
1513         * Configurations/FeatureDefines.xcconfig:
1514
1515 2017-11-23  Darin Adler  <darin@apple.com>
1516
1517         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1518         https://bugs.webkit.org/show_bug.cgi?id=179981
1519
1520         Reviewed by Sam Weinig.
1521
1522         * WebView/WebImmediateActionController.mm:
1523         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1524         * WebView/WebView.mm:
1525         (coreOptions): Use |= instead of | to build up FindOptions.
1526
1527 2017-11-23  Sam Weinig  <sam@webkit.org>
1528
1529         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1530         https://bugs.webkit.org/show_bug.cgi?id=179954
1531
1532         Reviewed by Darin Adler.
1533
1534         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1535         with direct calls to the corresponding UserGestureIndicator functions.
1536
1537         * Plugins/WebPluginController.mm:
1538         (-[WebPluginController processingUserGesture]):
1539         * WebView/WebView.mm:
1540         (-[WebView _isProcessingUserGesture]):
1541
1542 2017-11-23  Darin Adler  <darin@apple.com>
1543
1544         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1545         https://bugs.webkit.org/show_bug.cgi?id=179907
1546
1547         Reviewed by Sam Weinig.
1548
1549         * History/BinaryPropertyList.cpp:
1550         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1551         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1552         * WebView/WebHTMLRepresentation.mm:
1553         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1554         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1555
1556 2017-11-22  Ali Juma  <ajuma@chromium.org>
1557
1558         Implement VisualViewport API attributes
1559         https://bugs.webkit.org/show_bug.cgi?id=179385
1560
1561         Reviewed by Frédéric Wang.
1562
1563         Add a VisualViewportAPI preference.
1564
1565         * WebView/WebPreferenceKeysPrivate.h:
1566         * WebView/WebPreferences.mm:
1567         (+[WebPreferences initialize]):
1568         (-[WebPreferences visualViewportAPIEnabled]):
1569         (-[WebPreferences setVisualViewportAPIEnabled:]):
1570         * WebView/WebPreferencesPrivate.h:
1571         * WebView/WebView.mm:
1572         (-[WebView _preferencesChanged:]):
1573
1574 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1575
1576         WebCoreObjCExtras.h is being included in too many places
1577         https://bugs.webkit.org/show_bug.cgi?id=179931
1578
1579         Reviewed by Darin Adler.
1580
1581         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1582         * Plugins/WebBaseNetscapePluginView.mm:
1583         * Plugins/WebBasePluginPackage.mm:
1584         * Plugins/WebNetscapePluginStream.mm:
1585         * Plugins/WebNetscapePluginView.mm:
1586         * WebView/WebTextIterator.mm:
1587         * WebView/WebViewData.mm:
1588
1589 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1590
1591         Unreviewed, rolling out r225093.
1592         https://bugs.webkit.org/show_bug.cgi?id=179938
1593
1594         Compilation failed on WinCairo 64-bit Release (Requested by
1595         fredw on #webkit).
1596
1597         Reverted changeset:
1598
1599         "Implement VisualViewport API attributes"
1600         https://bugs.webkit.org/show_bug.cgi?id=179385
1601         https://trac.webkit.org/changeset/225093
1602
1603 2017-11-21  Ali Juma  <ajuma@chromium.org>
1604
1605         Implement VisualViewport API attributes
1606         https://bugs.webkit.org/show_bug.cgi?id=179385
1607
1608         Reviewed by Frédéric Wang.
1609
1610         Add a VisualViewportAPI preference.
1611
1612         * WebView/WebPreferenceKeysPrivate.h:
1613         * WebView/WebPreferences.mm:
1614         (+[WebPreferences initialize]):
1615         (-[WebPreferences visualViewportAPIEnabled]):
1616         (-[WebPreferences setVisualViewportAPIEnabled:]):
1617         * WebView/WebPreferencesPrivate.h:
1618         * WebView/WebView.mm:
1619         (-[WebView _preferencesChanged:]):
1620
1621 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1622
1623         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1624         https://bugs.webkit.org/show_bug.cgi?id=179504
1625
1626         Reviewed by Darin Adler.
1627
1628         * Misc/WebKitNSStringExtras.mm:
1629         * Plugins/Hosted/NetscapePluginHostManager.mm:
1630         * Plugins/WebBasePluginPackage.mm:
1631
1632 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1633
1634         Remove unused TOUCH_ICON_LOADING feature flag
1635         https://bugs.webkit.org/show_bug.cgi?id=179873
1636
1637         Reviewed by Simon Fraser.
1638
1639         * Configurations/FeatureDefines.xcconfig:
1640
1641 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1642
1643         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1644         https://bugs.webkit.org/show_bug.cgi?id=179872
1645
1646         Reviewed by Darin Adler.
1647
1648         * Configurations/FeatureDefines.xcconfig:
1649
1650 2017-11-16  Daniel Bates  <dabates@apple.com>
1651
1652         Add feature define for alternative presentation button element
1653         https://bugs.webkit.org/show_bug.cgi?id=179692
1654         Part of <rdar://problem/34917108>
1655
1656         Reviewed by Andy Estes.
1657
1658         Only enabled on Cocoa platforms by default.
1659
1660         * Configurations/FeatureDefines.xcconfig:
1661
1662 2017-11-14  Nan Wang  <n_wang@apple.com>
1663
1664         AX: AOM: Implement AccessibleNode class and support label and role attributes
1665         https://bugs.webkit.org/show_bug.cgi?id=179494
1666
1667         Reviewed by Ryosuke Niwa.
1668
1669         * WebView/WebPreferenceKeysPrivate.h:
1670         * WebView/WebPreferences.mm:
1671         (+[WebPreferences initialize]):
1672         (-[WebPreferences accessibilityObjectModelEnabled]):
1673         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1674         * WebView/WebPreferencesPrivate.h:
1675         * WebView/WebView.mm:
1676         (-[WebView _preferencesChanged:]):
1677
1678 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1679
1680         Remove Cocoa CFURLConnection loading code
1681         https://bugs.webkit.org/show_bug.cgi?id=179688
1682
1683         Reviewed by Antti Koivisto.
1684
1685         * Misc/WebDownload.mm:
1686         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1687         * Misc/WebDownloadInternal.h:
1688         * Plugins/WebBaseNetscapePluginView.mm:
1689         * WebCoreSupport/WebFrameLoaderClient.mm:
1690         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1691         * WebView/WebView.mm:
1692         (-[WebView scheduleInRunLoop:forMode:]):
1693         (-[WebView unscheduleFromRunLoop:forMode:]):
1694
1695 2017-11-14  Daniel Bates  <dabates@apple.com>
1696
1697         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1698         for feature defines
1699
1700         Following r195498 and r201917 the Visual Studio property files for feature defines have
1701         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1702         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1703         files.
1704
1705         * Configurations/FeatureDefines.xcconfig:
1706
1707 2017-11-14  Jer Noble  <jer.noble@apple.com>
1708
1709         Enable Modern EME tests in DumpRenderTree
1710         https://bugs.webkit.org/show_bug.cgi?id=179544
1711
1712         Reviewed by Alex Christensen.
1713
1714         Add a WebPreferences property to enable the (modern) EME API.
1715
1716         * WebView/WebPreferenceKeysPrivate.h:
1717         * WebView/WebPreferences.mm:
1718         (+[WebPreferences initialize]):
1719         (-[WebPreferences encryptedMediaAPIEnabled]):
1720         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1721         * WebView/WebPreferencesPrivate.h:
1722         * WebView/WebView.mm:
1723         (-[WebView _preferencesChanged:]):
1724
1725 2017-11-14  Antti Koivisto  <antti@apple.com>
1726
1727         Enable display:contents by default
1728         https://bugs.webkit.org/show_bug.cgi?id=179655
1729
1730         Reviewed by Sam Weinig.
1731
1732         * WebView/WebPreferences.mm:
1733         (+[WebPreferences initialize]):
1734
1735 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1736
1737         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1738         https://bugs.webkit.org/show_bug.cgi?id=178751
1739
1740         Reviewed by Brady Eidson.
1741
1742         * WebCoreSupport/WebFrameNetworkingContext.mm:
1743         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1744
1745 2017-11-08  Keith Miller  <keith_miller@apple.com>
1746
1747         Async iteration should only fetch the next method once and add feature flag
1748         https://bugs.webkit.org/show_bug.cgi?id=179451
1749
1750         Reviewed by Geoffrey Garen.
1751
1752         Add feature flag for Async iteration.
1753
1754         * Configurations/FeatureDefines.xcconfig:
1755
1756 2017-11-13  Mark Lam  <mark.lam@apple.com>
1757
1758         Add more overflow check book-keeping for MarkedArgumentBuffer.
1759         https://bugs.webkit.org/show_bug.cgi?id=179634
1760         <rdar://problem/35492517>
1761
1762         Reviewed by Saam Barati.
1763
1764         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1765         (WebKit::NetscapePluginInstanceProxy::invoke):
1766         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1767         (WebKit::NetscapePluginInstanceProxy::construct):
1768
1769 2017-11-12  Darin Adler  <darin@apple.com>
1770
1771         More is<> and downcast<>, less static_cast<>
1772         https://bugs.webkit.org/show_bug.cgi?id=179600
1773
1774         Reviewed by Chris Dumez.
1775
1776         * DOM/DOM.mm:
1777         (kit): Use is/downcast.
1778         * WebCoreSupport/WebEditorClient.mm:
1779         (WebEditorClient::handleKeyboardEvent): Ditto.
1780         (WebEditorClient::handleInputMethodKeydown): Ditto.
1781         * WebView/WebHTMLView.mm:
1782         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1783
1784 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1785
1786         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1787         https://bugs.webkit.org/show_bug.cgi?id=179397
1788
1789         Reviewed by Wenson Hsieh.
1790
1791         * DOM/DOMHTMLInputElement.mm:
1792         (-[DOMHTMLInputElement insertTextSuggestion:]):
1793
1794 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1795
1796         HTMLMediaElement should not use element fullscreen on iOS
1797         https://bugs.webkit.org/show_bug.cgi?id=179418
1798         rdar://problem/35409277
1799
1800         Reviewed by Eric Carlson.
1801
1802         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1803
1804         * Configurations/FeatureDefines.xcconfig:
1805
1806 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1807
1808         Make ResourceLoader::willSendRequestInternal asynchronous
1809         https://bugs.webkit.org/show_bug.cgi?id=179251
1810
1811         Reviewed by Andy Estes.
1812
1813         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1814         (WebKit::HostedNetscapePluginStream::start):
1815         * Plugins/WebNetscapePluginStream.mm:
1816         (WebNetscapePluginStream::start):
1817
1818 2017-11-01  Darin Adler  <darin@apple.com>
1819
1820         Simplify event dispatch code and make it a bit more consistent
1821         https://bugs.webkit.org/show_bug.cgi?id=178991
1822
1823         Reviewed by Chris Dumez.
1824
1825         * DOM/DOMEvent.mm:
1826         (-[DOMEvent srcElement]): Call target instead of srcElement.
1827
1828 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1829
1830         [Touch Bar Web API] Add support for menuitem tag
1831         https://bugs.webkit.org/show_bug.cgi?id=179020
1832
1833         Reviewed by Ryosuke Niwa.
1834
1835         Adds in properties and methods that allow the menuitem runtime feature
1836         to be enabled or disabled.
1837
1838         * WebView/WebPreferenceKeysPrivate.h:
1839         * WebView/WebPreferences.mm:
1840         (-[WebPreferences menuItemElementEnabled]):
1841         (-[WebPreferences setMenuItemElementEnabled:]):
1842         * WebView/WebPreferencesPrivate.h:
1843         * WebView/WebView.mm:
1844         (-[WebView _preferencesChanged:]):
1845
1846 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1847
1848         Use CompletionHandlers for redirects
1849         https://bugs.webkit.org/show_bug.cgi?id=179163
1850
1851         Reviewed by Tim Horton.
1852
1853         * Plugins/Hosted/HostedNetscapePluginStream.h:
1854         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1855         (WebKit::HostedNetscapePluginStream::willSendRequest):
1856         * Plugins/WebNetscapePluginStream.h:
1857         * Plugins/WebNetscapePluginStream.mm:
1858         (WebNetscapePluginStream::willSendRequest):
1859
1860 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1861
1862         Add a FileSystem namespace to FileSystem.cpp
1863         https://bugs.webkit.org/show_bug.cgi?id=179063
1864
1865         Reviewed by Darin Adler.
1866
1867         * Misc/WebNSFileManagerExtras.mm:
1868         * Storage/WebDatabaseProvider.mm:
1869
1870 2017-11-02  Frederic Wang  <fwang@igalia.com>
1871
1872         Add references to bug 179167 in FIXME comments
1873         https://bugs.webkit.org/show_bug.cgi?id=179168
1874
1875         Reviewed by Daniel Bates.
1876
1877         * Configurations/FeatureDefines.xcconfig:
1878
1879 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1880
1881         Implement WKFullscreenWindowController for iOS.
1882         https://bugs.webkit.org/show_bug.cgi?id=178924
1883         rdar://problem/34697120
1884
1885         Reviewed by Simon Fraser.
1886
1887         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1888
1889         * Configurations/FeatureDefines.xcconfig:
1890         * WebView/WebView.mm:
1891         (-[WebView fullScreenPlaceholderView]):
1892
1893 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1894
1895         Clean up some drag and drop feature flags
1896         https://bugs.webkit.org/show_bug.cgi?id=179082
1897
1898         Reviewed by Simon Fraser.
1899
1900         * Configurations/FeatureDefines.xcconfig:
1901
1902 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1903
1904         Make it possible to test rubber-banding in overflow scroll
1905         https://bugs.webkit.org/show_bug.cgi?id=179078
1906
1907         Reviewed by Sam Weinig.
1908
1909         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1910         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1911
1912         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1913         functions, since most callers want clamped.
1914
1915         * DOM/DOMHTML.mm:
1916         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1917
1918 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1919
1920         Fix up some content filtering feature flags
1921         https://bugs.webkit.org/show_bug.cgi?id=179079
1922
1923         Reviewed by Simon Fraser.
1924
1925         * Configurations/FeatureDefines.xcconfig:
1926
1927 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1928
1929         [FrameView::layout cleanup] Move core layout logic to a separate class.
1930         https://bugs.webkit.org/show_bug.cgi?id=178771
1931         <rdar://problem/35166542>
1932
1933         Reviewed by Simon Fraser.
1934
1935         Move layout code out from FrameView to LayoutContext.
1936
1937         * WebView/WebClipView.mm:
1938         (-[WebClipView _immediateScrollToPoint:]):
1939         * WebView/WebFrame.mm:
1940         (-[WebFrame layoutCount]):
1941
1942 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1943
1944         Fix issues with WebView subframe painting
1945         https://bugs.webkit.org/show_bug.cgi?id=178842
1946         rdar://problem/34072253
1947
1948         Reviewed by Daniel Bates.
1949         
1950         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1951         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1952         High Sierra, so match the new signature.
1953
1954         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1955
1956         * WebView/WebHTMLView.mm:
1957         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1958         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1959
1960 2017-10-25  Youenn Fablet  <youenn@apple.com>
1961
1962         Enable ServiceWorker to fetch resources
1963         https://bugs.webkit.org/show_bug.cgi?id=178673
1964
1965         Reviewed by Brady Eidson.
1966
1967         * WebCoreSupport/WebFrameLoaderClient.mm:
1968         (WebFrameLoaderClient::pageID const):
1969         (WebFrameLoaderClient::frameID const):
1970         (WebFrameLoaderClient::sessionID const):
1971
1972         Added implementation to the new getters.
1973         They are noop in the context of WK1.
1974
1975 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1976
1977         Web Inspector: Enable WebKit logging configuration and display
1978         https://bugs.webkit.org/show_bug.cgi?id=177027
1979         <rdar://problem/33964767>
1980
1981         Reviewed by Joseph Pecoraro.
1982
1983         * WebCoreSupport/WebChromeClient.mm:
1984         (stringForMessageSource): Deal with Media and WebRTC message sources.
1985
1986 2017-10-20  Antoine Quint  <graouts@apple.com>
1987
1988         [Web Animations] Provide basic timeline and animation interfaces
1989         https://bugs.webkit.org/show_bug.cgi?id=178526
1990
1991         Reviewed by Dean Jackson.
1992
1993         Remove the WEB_ANIMATIONS compile-time flag.
1994
1995         * Configurations/FeatureDefines.xcconfig:
1996         * WebView/WebPreferences.mm:
1997         (+[WebPreferences initialize]):
1998         * WebView/WebView.mm:
1999         (-[WebView _preferencesChanged:]):
2000
2001 2017-10-19  Sam Weinig  <sam@webkit.org>
2002
2003         [Settings] Move global settings into their own file
2004         https://bugs.webkit.org/show_bug.cgi?id=178512
2005
2006         Reviewed by Darin Adler.
2007
2008         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2009
2010         * WebCoreSupport/WebChromeClient.mm:
2011         (WebChromeClient::supportsVideoFullscreen):
2012         * WebView/WebDynamicScrollBarsView.mm:
2013         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2014         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2015         * WebView/WebPreferences.mm:
2016         (+[WebPreferences initialize]):
2017         * WebView/WebView.mm:
2018         (-[WebView _commonInitializationWithFrameName:groupName:]):
2019         (-[WebView _preferencesChanged:]):
2020         (+[WebView _doNotStartObservingNetworkReachability]):
2021
2022 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2023
2024         Replace some stack raw pointers with RefPtrs within WebCore/html
2025         https://bugs.webkit.org/show_bug.cgi?id=178201
2026         <rdar://problem/34841692>
2027
2028         Reviewed by Ryosuke Niwa.
2029
2030         * DOM/DOM.mm:
2031         (kit):
2032         Change the type of node as toNode() is changed to return RefPtr.
2033
2034 2017-10-18  Chris Dumez  <cdumez@apple.com>
2035
2036         [Service Worker] Add stubs for Client / WindowClient / Clients
2037         https://bugs.webkit.org/show_bug.cgi?id=178469
2038
2039         Reviewed by Youenn Fablet.
2040
2041         Rename PageVisiblityState to VisibilityState.
2042
2043         * WebView/WebView.mm:
2044         (kit):
2045
2046 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2047
2048         Unreviewed, rolling out r223291.
2049
2050         See WebCore ChangeLog for more detail.
2051
2052         Reverted changeset:
2053
2054         "Remove Editor::simplifyMarkup"
2055         https://bugs.webkit.org/show_bug.cgi?id=178271
2056         https://trac.webkit.org/changeset/223291
2057
2058 2017-10-17  Keith Miller  <keith_miller@apple.com>
2059
2060         Change WebCore sources to work with unified source builds
2061         https://bugs.webkit.org/show_bug.cgi?id=178229
2062
2063         Rubber stamped by Tim Horton.
2064
2065         * Configurations/FeatureDefines.xcconfig:
2066
2067 2017-10-16  Sam Weinig  <sam@webkit.org>
2068
2069         [Settings] Remove all custom code from Settings.h/cpp
2070         https://bugs.webkit.org/show_bug.cgi?id=178330
2071
2072         Reviewed by Simon Fraser.
2073
2074         * WebView/WebPreferences.mm:
2075         (+[WebPreferences initialize]):
2076         
2077             Update for naming changes of FrameFlattening now that it is an enum class.
2078
2079 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2080
2081         Remove Editor::simplifyMarkup
2082         https://bugs.webkit.org/show_bug.cgi?id=178271
2083
2084         Reviewed by Wenson Hsieh.
2085
2086         * WebView/WebView.mm:
2087         (-[WebView _simplifyMarkup:endNode:]):
2088
2089 2017-10-12  Chris Dumez  <cdumez@apple.com>
2090
2091         [Mac] Add support for MouseEvent.buttons
2092         https://bugs.webkit.org/show_bug.cgi?id=178214
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         * WebView/WebPDFView.mm:
2097         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2098
2099 2017-10-11  Sam Weinig  <sam@webkit.org>
2100
2101         Remove out-parameter variants of copyToVector
2102         https://bugs.webkit.org/show_bug.cgi?id=178155
2103
2104         Reviewed by Tim Horton.
2105
2106         * Plugins/WebNetscapePluginView.mm:
2107         (-[WebNetscapePluginView destroyPlugin]):
2108         * WebView/WebHTMLRepresentation.mm:
2109         (newArrayWithStrings):
2110
2111             Replace out-parameter based copyToVector, with one that returns a Vector.
2112
2113 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2114
2115         Sanitize URL in pasteboard for other applications and cross origin content
2116         https://bugs.webkit.org/show_bug.cgi?id=178060
2117         <rdar://problem/34874518>
2118
2119         Reviewed by Wenson Hsieh.
2120
2121         * WebCoreSupport/WebPlatformStrategies.h:
2122         * WebCoreSupport/WebPlatformStrategies.mm:
2123         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2124
2125 2017-10-11  Chris Dumez  <cdumez@apple.com>
2126
2127         Modernize Geolocation code
2128         https://bugs.webkit.org/show_bug.cgi?id=178148
2129
2130         Reviewed by Ryosuke Niwa.
2131
2132         * WebCoreSupport/WebGeolocationClient.h:
2133         * WebCoreSupport/WebGeolocationClient.mm:
2134         (WebGeolocationClient::lastPosition):
2135         * WebView/WebGeolocationPosition.mm:
2136         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2137         (core):
2138         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2139         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2140         * WebView/WebGeolocationPositionInternal.h:
2141
2142 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2143
2144         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2145         https://bugs.webkit.org/show_bug.cgi?id=178154
2146
2147         Reviewed by Wenson Hsieh.
2148
2149         Enable custom pasteboard data by default.
2150
2151         * WebView/WebPreferenceKeysPrivate.h:
2152         * WebView/WebPreferences.mm:
2153         (+[WebPreferences initialize]):
2154         (-[WebPreferences customPasteboardDataEnabled]): Added.
2155         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2156         * WebView/WebPreferencesPrivate.h:
2157         * WebView/WebView.mm:
2158         (-[WebView _preferencesChanged:]):
2159
2160 2017-10-10  Sam Weinig  <sam@webkit.org>
2161
2162         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2163         https://bugs.webkit.org/show_bug.cgi?id=178102
2164
2165         Reviewed by Tim Horton.
2166
2167         * History/WebHistory.mm:
2168         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2169         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2170         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2171         * WebCoreSupport/WebUserMediaClient.mm:
2172         (WebUserMediaClient::pageDestroyed):
2173
2174 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2175
2176         Make the names of the options consistent
2177         https://bugs.webkit.org/show_bug.cgi?id=177933
2178
2179         Reviewed by Saam Barati.
2180
2181         * WebView/WebFrame.h:
2182         * WebView/WebHTMLView.mm:
2183         (-[WebHTMLView setMarkedText:selectedRange:]):
2184         * WebView/WebView.h:
2185
2186 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2187
2188         [iOS] Tweak support for classifying form controls (followup to r222487)
2189         https://bugs.webkit.org/show_bug.cgi?id=177917
2190         <rdar://problem/34820122>
2191
2192         Reviewed by Dean Jackson.
2193
2194         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2195
2196         * DOM/DOMHTMLInputElement.mm:
2197         (-[DOMHTMLInputElement _autofillContext]):
2198         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2199         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2200
2201 2017-10-05  Keith Miller  <keith_miller@apple.com>
2202
2203         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2204
2205         * Configurations/WebKitLegacy.xcconfig:
2206
2207 2017-10-05  Jer Noble  <jer.noble@apple.com>
2208
2209         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2210         https://bugs.webkit.org/show_bug.cgi?id=177261
2211
2212         Reviewed by Eric Carlson.
2213
2214         * Configurations/FeatureDefines.xcconfig:
2215
2216 2017-10-05  Chris Dumez  <cdumez@apple.com>
2217
2218         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2219         https://bugs.webkit.org/show_bug.cgi?id=177957
2220
2221         Reviewed by Alex Christensen.
2222
2223         * WebCoreSupport/WebPlatformStrategies.h:
2224         * WebCoreSupport/WebPlatformStrategies.mm:
2225         (WebPlatformStrategies::cookiesEnabled):
2226
2227 2017-10-05  Youenn Fablet  <youenn@apple.com>
2228
2229         Make LibWebRTCProvider port agnostic
2230         https://bugs.webkit.org/show_bug.cgi?id=177747
2231
2232         Reviewed by Alex Christensen & Alex Garcia.
2233
2234         * WebView/WebView.mm:
2235         (-[WebView _commonInitializationWithFrameName:groupName:]):
2236         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2237
2238 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2239
2240         Stop linking with WebKitSystemInterface
2241         https://bugs.webkit.org/show_bug.cgi?id=177915
2242
2243         Reviewed by Antti Koivisto.
2244
2245         * Configurations/DebugRelease.xcconfig:
2246         * Configurations/WebKitLegacy.xcconfig:
2247
2248 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2249
2250         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2251         https://bugs.webkit.org/show_bug.cgi?id=177912
2252
2253         Reviewed by Saam Barati.
2254
2255         * Carbon/CarbonUtils.m:
2256         * Carbon/CarbonWindowAdapter.mm:
2257         * Carbon/HIWebView.mm:
2258         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2259         * Misc/WebNSFileManagerExtras.mm:
2260         * Misc/WebNSPasteboardExtras.mm:
2261         * Misc/WebNSURLExtras.mm:
2262         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2263         * Plugins/Hosted/NetscapePluginHostManager.mm:
2264         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2265         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2266         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2267         * Plugins/Hosted/WebTextInputWindowController.m:
2268         * Plugins/WebBaseNetscapePluginView.mm:
2269         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2270         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2271         * Plugins/WebNetscapePluginStream.mm:
2272         * Plugins/WebNetscapePluginView.mm:
2273         * Plugins/WebPluginDatabase.mm:
2274         * WebCoreSupport/PopupMenuMac.mm:
2275         * WebCoreSupport/WebChromeClient.mm:
2276         * WebCoreSupport/WebFrameLoaderClient.mm:
2277         * WebCoreSupport/WebInspectorClient.mm:
2278         * WebCoreSupport/WebPlatformStrategies.mm:
2279         * WebCoreSupport/WebSystemInterface.mm:
2280         * WebView/WebDynamicScrollBarsView.mm:
2281         * WebView/WebFrame.mm:
2282         * WebView/WebFrameView.mm:
2283         * WebView/WebFullScreenController.mm:
2284         * WebView/WebHTMLView.mm:
2285         * WebView/WebPreferences.mm:
2286         * WebView/WebView.mm:
2287
2288 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2289
2290         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2291         rdar://problem/34705779
2292
2293         Addressing review comments that I somehow landed without.
2294
2295         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2296
2297 2017-09-29  Chris Dumez  <cdumez@apple.com>
2298
2299         Split some logic out of VisitedLinkStore and make it reusable
2300         https://bugs.webkit.org/show_bug.cgi?id=177575
2301
2302         Reviewed by Alex Christensen.
2303
2304         * WebCoreSupport/WebVisitedLinkStore.h:
2305         * WebCoreSupport/WebVisitedLinkStore.mm:
2306         (WebVisitedLinkStore::addVisitedLink):
2307         (WebVisitedLinkStore::removeVisitedLink):
2308         (WebVisitedLinkStore::isLinkVisited):
2309         (WebVisitedLinkStore::addVisitedLinkHash):
2310
2311 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2312
2313         Build fix for High Sierra 32 bit Mac
2314         https://bugs.webkit.org/show_bug.cgi?id=177551
2315         <rdar://problem/34690283>
2316
2317         Reviewed by Alexey Proskuryakov.
2318
2319         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2320         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2321         also made.
2322
2323         * Carbon/CarbonWindowAdapter.mm:
2324         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2325         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2326         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2327         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2328         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2329         (-[CarbonWindowAdapter dealloc]):
2330         (-[CarbonWindowAdapter windowRef]):
2331         (-[CarbonWindowAdapter _hasWindowRef]):
2332         (-[CarbonWindowAdapter _managesWindowRef]):
2333         (-[CarbonWindowAdapter _removeWindowRef]):
2334         (-[CarbonWindowAdapter _carbonWindowClass]):
2335         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2336         (-[CarbonWindowAdapter sendSuperEvent:]):
2337         (-[CarbonWindowAdapter relinquishFocus]):
2338         (-[CarbonWindowAdapter _cancelKey:]):
2339         (-[CarbonWindowAdapter _commonAwake]):
2340         (-[CarbonWindowAdapter _destroyRealWindow:]):
2341         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2342         (-[CarbonWindowAdapter _termWindowIfOwner]):
2343         (-[CarbonWindowAdapter _windowMovedToRect:]):
2344         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2345         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2346         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2347         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2348         (-[CarbonWindowAdapter canBecomeMainWindow]):
2349         (-[CarbonWindowAdapter encodeWithCoder:]):
2350         (-[CarbonWindowAdapter initWithCoder:]):
2351         (-[CarbonWindowAdapter setContentView:]):
2352         (-[CarbonWindowAdapter worksWhenModal]):
2353         (-[CarbonWindowAdapter _setModalWindowLevel]):
2354         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2355         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2356         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2357         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2358         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2359         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2360         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2361         (NSCarbonWindowHandleEvent):
2362         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2363         (-[CarbonWindowAdapter _growBoxRect]):
2364         * Carbon/HIWebView.mm:
2365         (HIWebViewGetWebView):
2366         (HIWebViewConstructor):
2367         (HIWebViewDestructor):
2368         (HIWebViewRegisterClass):
2369         (GetBehaviors):
2370         (Draw):
2371         (HitTest):
2372         (GetRegion):
2373         (GetWindowRef):
2374         (CreateNSEventAdoptingCGEvent):
2375         (CopyEventCGEvent):
2376         (CreateNSEventWithCarbonClickEvent):
2377         (Click):
2378         (CreateNSEventWithCarbonEvent):
2379         (MouseUp):
2380         (CreateNSEventWithCarbonMouseMoveEvent):
2381         (MouseMoved):
2382         (MouseDragged):
2383         (MouseWheelMoved):
2384         (ContextMenuClick):
2385         (GetKind):
2386         (BoundsChanged):
2387         (OwningWindowChanged):
2388         (WindowHandler):
2389         (SyncFrame):
2390         (SetFocusPart):
2391         (AdvanceFocus):
2392         (RelinquishFocus):
2393         (ActiveStateChanged):
2394         (ProcessCommand):
2395         (UpdateCommandStatus):
2396         (_NSSelectorForHICommand):
2397         (HIWebViewEventHandler):
2398         (StartUpdateObserver):
2399         (StopUpdateObserver):
2400         (UpdateObserver):
2401
2402 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2403
2404         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2405         https://bugs.webkit.org/show_bug.cgi?id=172526
2406         <rdar://problem/32396081>
2407
2408         Reviewed by Ryosuke Niwa.
2409
2410         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2411
2412         * WebCoreSupport/WebPlatformStrategies.h:
2413         * WebCoreSupport/WebPlatformStrategies.mm:
2414         (WebPlatformStrategies::webExposedTypes):
2415         (WebPlatformStrategies::writeCustomData):
2416
2417 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2418
2419         Unreviewed, rolling out r222567.
2420
2421         This broke and internal build.
2422
2423         Reverted changeset:
2424
2425         "Build fix for High Sierra 32 bit Mac"
2426         https://bugs.webkit.org/show_bug.cgi?id=177551
2427         http://trac.webkit.org/changeset/222567
2428
2429 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2430
2431         Build fix for High Sierra 32 bit Mac
2432         https://bugs.webkit.org/show_bug.cgi?id=177551
2433         <rdar://problem/34690283>
2434
2435         Reviewed by Alexey Proskuryakov.
2436
2437         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2438         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2439         also made.
2440
2441         * Carbon/CarbonWindowAdapter.mm:
2442         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2443         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2444         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2445         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2446         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2447         (-[CarbonWindowAdapter dealloc]):
2448         (-[CarbonWindowAdapter windowRef]):
2449         (-[CarbonWindowAdapter _hasWindowRef]):
2450         (-[CarbonWindowAdapter _managesWindowRef]):
2451         (-[CarbonWindowAdapter _removeWindowRef]):
2452         (-[CarbonWindowAdapter _carbonWindowClass]):
2453         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2454         (-[CarbonWindowAdapter sendSuperEvent:]):
2455         (-[CarbonWindowAdapter relinquishFocus]):
2456         (-[CarbonWindowAdapter _cancelKey:]):
2457         (-[CarbonWindowAdapter _commonAwake]):
2458         (-[CarbonWindowAdapter _destroyRealWindow:]):
2459         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2460         (-[CarbonWindowAdapter _termWindowIfOwner]):
2461         (-[CarbonWindowAdapter _windowMovedToRect:]):
2462         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2463         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2464         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2465         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2466         (-[CarbonWindowAdapter canBecomeMainWindow]):
2467         (-[CarbonWindowAdapter encodeWithCoder:]):
2468         (-[CarbonWindowAdapter initWithCoder:]):
2469         (-[CarbonWindowAdapter setContentView:]):
2470         (-[CarbonWindowAdapter worksWhenModal]):
2471         (-[CarbonWindowAdapter _setModalWindowLevel]):
2472         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2473         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2474         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2475         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2476         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2477         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2478         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2479         (NSCarbonWindowHandleEvent):
2480         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2481         (-[CarbonWindowAdapter _growBoxRect]):
2482         * Carbon/HIWebView.mm:
2483         (HIWebViewGetWebView):
2484         (HIWebViewConstructor):
2485         (HIWebViewDestructor):
2486         (HIWebViewRegisterClass):
2487         (GetBehaviors):
2488         (Draw):
2489         (HitTest):
2490         (GetRegion):
2491         (GetWindowRef):
2492         (CreateNSEventAdoptingCGEvent):
2493         (CopyEventCGEvent):
2494         (CreateNSEventWithCarbonClickEvent):
2495         (Click):
2496         (CreateNSEventWithCarbonEvent):
2497         (MouseUp):
2498         (CreateNSEventWithCarbonMouseMoveEvent):
2499         (MouseMoved):
2500         (MouseDragged):
2501         (MouseWheelMoved):
2502         (ContextMenuClick):
2503         (GetKind):
2504         (BoundsChanged):
2505         (OwningWindowChanged):
2506         (WindowHandler):
2507         (SyncFrame):
2508         (SetFocusPart):
2509         (AdvanceFocus):
2510         (RelinquishFocus):
2511         (ActiveStateChanged):
2512         (ProcessCommand):
2513         (UpdateCommandStatus):
2514         (_NSSelectorForHICommand):
2515         (HIWebViewEventHandler):
2516         (StartUpdateObserver):
2517         (StopUpdateObserver):
2518         (UpdateObserver):
2519
2520 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2521
2522         Make PolicyAction an encodable enum class
2523         https://bugs.webkit.org/show_bug.cgi?id=177480
2524
2525         Reviewed by Antti Koivisto.
2526
2527         * Plugins/WebPluginContainerCheck.mm:
2528         (-[WebPluginContainerCheck _continueWithPolicy:]):
2529         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2530         * WebCoreSupport/WebFrameLoaderClient.mm:
2531         (-[WebFramePolicyListener invalidate]):
2532         (-[WebFramePolicyListener ignore]):
2533         (-[WebFramePolicyListener download]):
2534         (-[WebFramePolicyListener use]):
2535         (-[WebFramePolicyListener continue]):
2536         * WebView/WebPolicyDelegate.mm:
2537         (-[WebPolicyDecisionListener use]):
2538         (-[WebPolicyDecisionListener ignore]):
2539         (-[WebPolicyDecisionListener download]):
2540
2541 2017-09-25  Frederik Riedel  <riedel@apple.com>
2542
2543         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2544         https://bugs.webkit.org/show_bug.cgi?id=174394
2545         <rdar://problem/33183504>
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         * DOM/DOMHTMLInputElement.h:
2550         * DOM/DOMHTMLInputElement.mm:
2551         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2552         Determines if this HTMLInputElement is part of a login screen.
2553         (-[DOMHTMLInputElement representingPageUrl]):
2554         Returns the webpage's URL that is currently displayed in the Web View.
2555         (-[DOMHTMLInputElement insertTextSuggestion:]):
2556         Inserts login credentials into the Web View.
2557
2558 2017-09-25  Sam Weinig  <sam@webkit.org>
2559
2560         Remove unused EditorClient functions
2561         https://bugs.webkit.org/show_bug.cgi?id=177463
2562
2563         Reviewed by Alex Christensen.
2564
2565         Remove unused EditorClient functions.
2566
2567         * WebCoreSupport/WebEditorClient.h:
2568         * WebCoreSupport/WebEditorClient.mm:
2569         (WebEditorClient::canonicalizeURL): Deleted.
2570         (WebEditorClient::canonicalizeURLString): Deleted.
2571         (WebEditorClient::writeDataToPasteboard): Deleted.
2572         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2573         (WebEditorClient::readDataFromPasteboard): Deleted.
2574         (WebEditorClient::pasteboardChangeCount): Deleted.
2575
2576 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2577
2578         Stop using PolicyCallback
2579         https://bugs.webkit.org/show_bug.cgi?id=176088
2580
2581         Reviewed by Andy Estes.
2582
2583         * WebCoreSupport/WebFrameLoaderClient.mm:
2584         (-[WebFramePolicyListener invalidate]):
2585         (-[WebFramePolicyListener receivedPolicyDecision:]):
2586
2587 2017-09-25  Sam Weinig  <sam@webkit.org>
2588
2589         Remove unnecessary userVisibleString EditorClient function
2590         https://bugs.webkit.org/show_bug.cgi?id=177456
2591
2592         Reviewed by Dan Bernstein.
2593
2594         * WebCoreSupport/WebEditorClient.h:
2595         * WebCoreSupport/WebEditorClient.mm:
2596         (WebEditorClient::userVisibleString): Deleted.
2597
2598             Remove userVisibleString client function.
2599
2600 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2601
2602         Separate form submission from PolicyChecker infrastructure
2603         https://bugs.webkit.org/show_bug.cgi?id=177396
2604
2605         Reviewed by Geoffrey Garen.
2606
2607         * WebCoreSupport/WebFrameLoaderClient.h:
2608         * WebCoreSupport/WebFrameLoaderClient.mm:
2609         (WebFrameLoaderClient::dispatchWillSubmitForm):
2610
2611 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2612
2613         WeakPtrFactory should populate m_ref lazily.
2614         https://bugs.webkit.org/show_bug.cgi?id=177375
2615
2616         Reviewed by Geoffrey Garen.
2617
2618         * WebCoreSupport/WebEditorClient.mm:
2619         (WebEditorClient::WebEditorClient):
2620         (WebEditorClient::requestCandidatesForSelection):
2621
2622 2017-09-22  Chris Dumez  <cdumez@apple.com>
2623
2624         Use high resolution timestamp for event time
2625         https://bugs.webkit.org/show_bug.cgi?id=154246
2626         <rdar://problem/34333304>
2627
2628         Reviewed by Ryosuke Niwa.
2629
2630         Use WallTime / MonotonicTime instead of double type for clarity.
2631
2632         * DOM/DOMEvent.mm:
2633         (-[DOMEvent timeStamp]):
2634         * WebView/WebFrame.mm:
2635         (-[WebFrame _dragSourceEndedAt:operation:]):
2636         * WebView/WebPDFView.mm:
2637         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2638
2639 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2640
2641         Enable dataTransfer.items on macOS and iOS
2642         https://bugs.webkit.org/show_bug.cgi?id=177335
2643
2644         Reviewed by Sam Weinig.
2645
2646         * WebView/WebPreferences.mm:
2647         (+[WebPreferences initialize]):
2648
2649 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2650
2651         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2652         https://bugs.webkit.org/show_bug.cgi?id=177101
2653         <rdar://problem/34500648>
2654
2655         Reviewed by Brian Burg.
2656
2657         * WebInspector/WebNodeHighlight.mm:
2658         Ensure we close the window that we have just removed.
2659
2660 2017-09-20  Antti Koivisto  <antti@apple.com>
2661
2662         Remove DOM and styling support for CSS Regions
2663         https://bugs.webkit.org/show_bug.cgi?id=177221
2664
2665         Reviewed by Andreas Kling.
2666
2667         * Configurations/FeatureDefines.xcconfig:
2668         * DOM/DOMCSS.mm:
2669         (kitClass):
2670         * DOM/DOMElement.mm:
2671         (-[DOMElement webkitRegionOverset]): Deleted.
2672
2673 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2674
2675         Layering violation in Editor::createFragment
2676         https://bugs.webkit.org/show_bug.cgi?id=176123
2677
2678         Reviewed by Darin Adler.
2679
2680         * Misc/WebNSURLExtras.h:
2681         * Misc/WebNSURLExtras.mm:
2682         * WebView/WebFrame.mm:
2683         * WebView/WebHTMLView.mm:
2684         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2685
2686         * WebCoreSupport/WebEditorClient.mm:
2687         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2688         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2689         way to avoid exporting the symbol just on newer OSes.
2690
2691 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2692
2693         On iOS, getData can't get text set by setData during copy event
2694         https://bugs.webkit.org/show_bug.cgi?id=176980
2695         <rdar://problem/34453915>
2696
2697         Reviewed by Darin Adler.
2698
2699         * WebCoreSupport/WebPlatformStrategies.h:
2700         * WebCoreSupport/WebPlatformStrategies.mm:
2701         (WebPlatformStrategies::copy): Deleted.
2702
2703 2017-09-18  Andy Estes  <aestes@apple.com>
2704
2705         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2706         https://bugs.webkit.org/show_bug.cgi?id=177029
2707
2708         Reviewed by Alex Christensen.
2709
2710         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2711         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2712         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2713         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2714         * WebCoreSupport/PopupMenuMac.mm:
2715         (PopupMenuMac::show):
2716         * WebCoreSupport/WebSystemInterface.mm:
2717         (InitWebCoreSystemInterface):
2718         * WebView/WebHTMLView.mm:
2719         (-[WebHTMLView setDataSource:]):
2720         (-[WebHTMLView attachRootLayer:]):
2721         * WebView/WebView.mm:
2722         (-[WebView _needsAdobeFrameReloadingQuirk]):
2723         (-[WebView _needsLinkElementTextCSSQuirk]):
2724         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2725         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2726         (-[WebView _preferencesChanged:]):
2727
2728 2017-09-15  Andy Estes  <aestes@apple.com>
2729
2730         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2731         https://bugs.webkit.org/show_bug.cgi?id=176953
2732
2733         Reviewed by Eric Carlson.
2734
2735         * WebCoreSupport/WebSystemInterface.mm:
2736         (InitWebCoreSystemInterface):
2737
2738 2017-09-14  Andy Estes  <aestes@apple.com>
2739
2740         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2741         https://bugs.webkit.org/show_bug.cgi?id=176931
2742
2743         Reviewed by Joseph Pecoraro.
2744
2745         * WebCoreSupport/WebSystemInterface.mm:
2746         (InitWebCoreSystemInterface):
2747
2748 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2749
2750         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2751         https://bugs.webkit.org/show_bug.cgi?id=176867
2752
2753         Reviewed by Sam Weinig.
2754
2755         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2756         (WebKit::NetscapePluginInstanceProxy::enumerate):
2757
2758 2017-09-13  Andy Estes  <aestes@apple.com>
2759
2760         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2761         https://bugs.webkit.org/show_bug.cgi?id=176729
2762
2763         Reviewed by Alex Christensen.
2764
2765         * WebCoreSupport/WebSystemInterface.mm:
2766         (InitWebCoreSystemInterface):
2767         * WebView/WebView.mm:
2768         (+[WebView _setCacheModel:]):
2769
2770 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2771
2772         Refactor WebContentReader out of EditorMac and EditorIOS
2773         https://bugs.webkit.org/show_bug.cgi?id=176770
2774
2775         Reviewed by Sam Weinig.
2776
2777         * WebCoreSupport/WebEditorClient.mm:
2778
2779 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2780
2781         Dragging & dropping a file creates an attachment element even when it's disabled
2782         https://bugs.webkit.org/show_bug.cgi?id=176769
2783
2784         Reviewed by Tim Horton.
2785
2786         * WebView/WebView.mm:
2787         (-[WebView _preferencesChanged:]):
2788
2789 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2790
2791         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2792         https://bugs.webkit.org/show_bug.cgi?id=176721
2793         <rdar://problem/34373660>
2794
2795         Reviewed by Tim Horton.
2796
2797         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2798         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2799
2800         * WebView/WebView.mm:
2801         (-[WebView _startDrag:]):
2802         (-[WebView _draggedElementBounds]):
2803         (-[WebView _endedDataInteraction:global:]):
2804         * WebView/WebViewData.h:
2805
2806 2017-09-11  Andy Estes  <aestes@apple.com>
2807
2808         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2809         https://bugs.webkit.org/show_bug.cgi?id=176472
2810
2811         Reviewed by Eric Carlson.
2812
2813         * WebCoreSupport/WebSystemInterface.mm:
2814         (InitWebCoreSystemInterface):
2815
2816 2017-09-09  Mark Lam  <mark.lam@apple.com>
2817
2818         Avoid duplicate computations of ExecState::vm().
2819         https://bugs.webkit.org/show_bug.cgi?id=176647
2820
2821         Reviewed by Saam Barati.
2822
2823         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2824         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2825         (WebKit::NetscapePluginInstanceProxy::construct):
2826         (WebKit::NetscapePluginInstanceProxy::setProperty):
2827         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2828         (WebKit::NetscapePluginInstanceProxy::enumerate):
2829         * Plugins/Hosted/ProxyInstance.mm:
2830         (WebKit::ProxyRuntimeMethod::create):
2831
2832 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2833
2834         Unreviewed, rolling out r221773.
2835         https://bugs.webkit.org/show_bug.cgi?id=176614
2836
2837         This caused build failures. (Requested by mlewis13 on
2838         #webkit).
2839
2840         Reverted changeset:
2841
2842         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2843         https://bugs.webkit.org/show_bug.cgi?id=176472
2844         http://trac.webkit.org/changeset/221773
2845
2846 2017-09-07  Andy Estes  <aestes@apple.com>
2847
2848         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2849         https://bugs.webkit.org/show_bug.cgi?id=176472
2850
2851         Reviewed by Eric Carlson.
2852
2853         * WebCoreSupport/WebSystemInterface.mm:
2854         (InitWebCoreSystemInterface):
2855
2856 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2857
2858         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2859         https://bugs.webkit.org/show_bug.cgi?id=176561
2860
2861         Reviewed by Brent Fulgham.
2862
2863         * Misc/WebNSUserDefaultsExtras.mm:
2864
2865 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2866
2867         Modernize Geolocation code
2868         https://bugs.webkit.org/show_bug.cgi?id=176496
2869
2870         Reviewed by Andy Estes.
2871
2872         * WebCoreSupport/WebGeolocationClient.h:
2873         * WebCoreSupport/WebGeolocationClient.mm:
2874         (WebGeolocationClient::requestPermission):
2875         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2876         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2877         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2878         * WebView/WebView.mm:
2879         (-[WebView _commonInitializationWithFrameName:groupName:]):
2880         (-[WebView _geolocationDidFailWithMessage:]):
2881
2882 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2883
2884         Remove some unused bits of code and resources
2885         https://bugs.webkit.org/show_bug.cgi?id=176275
2886
2887         Reviewed by Dan Bernstein.
2888
2889         * Misc/WebNSFileManagerExtras.mm:
2890         Include FileSystem instead of FileSystemIOS.
2891
2892 2017-09-03  Darin Adler  <darin@apple.com>
2893
2894         [Cocoa] Tidy a few things in legacy WebHTMLView
2895         https://bugs.webkit.org/show_bug.cgi?id=176280
2896
2897         Reviewed by Dan Bernstein.
2898
2899         * WebCoreSupport/WebChromeClient.mm:
2900         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2901         methods it calls on WebHTMLView were doing nothing on iOS.
2902
2903         * WebView/WebFrame.mm:
2904         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2905         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2906
2907         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2908         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2909         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2910         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2911         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2912         Use RetainPtr instead of writing retain/release wherever possible.
2913         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2914         initialization for it. Removed various unused methods and declarations of methods.
2915         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2916         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2917         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2918         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2919         and remove CFRetain no longer needed since we don't support garbage collection any more.
2920         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2921         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2922         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2923         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2924         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2925         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2926         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2927         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2928         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2929         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2930         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2931         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2932         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2933         debug flag; we haven't used it for years and it's not clearly helpful.
2934         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2935         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2936         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2937         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2938         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2939         two additional methods in the WebPrivate category and still be called by the two
2940         methods in the WebInternal category that were already using it.
2941         (-[WebHTMLView didAddSubview:]): Deleted.
2942         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2943         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2944         place this was called, the close method.
2945         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2946         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2947         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2948         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2949         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2950         Added helper method to make the one below simpler.
2951         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2952         Compared pasteboard type strings using isEqualToString: rather than using == since
2953         we want to actually compare the string contents. Also updated to use modern for loop,
2954         renamed a local variable from "s" to "localSubresources", and factored out the handling
2955         of three image types to use the helper method above.
2956         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2957         _web_makePluginSubviewsPerformSelector:withObject: method.
2958         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2959         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2960         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2961         not call the -[NSView subviews] method to make this identical on both platforms and used
2962         a modern for loop.
2963         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2964         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2965         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2966         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2967         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2968         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2969         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2970         of it is Mac-only.
2971         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2972         method did was call itself on the main thread, and do nothing if called on main thread.
2973         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2974         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2975         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2976         half of this method.
2977         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2978         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2979         Simplified using a modern for loop and RetainPtr.
2980         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2981         (-[WebHTMLView keyDown:]): Ditto.
2982         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2983         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2984         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2985         (-[WebHTMLView complete:]): Ditto.
2986         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2987         now macOS-only.
2988         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2989         iOS since that is now macOS-only.
2990         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2991         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2992         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2993         and reorganized to use early return.
2994         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2995         on iOS, but kept there so we don't have to do #if at every call site.
2996         (-[WebHTMLView _pluginController]): Moved into internal category.
2997         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2998         there only for GC, using C++ initialization, removing obsolete comment.
2999         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3000         peculiar iOS-only comment.
3001         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3002
3003         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3004         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3005         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3006         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3007         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3008
3009         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3010         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3011         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3012         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3013         them at this time.
3014
3015 2017-09-03  Sam Weinig  <sam@webkit.org>
3016
3017         Remove CanvasProxy
3018         https://bugs.webkit.org/show_bug.cgi?id=176288
3019
3020         Reviewed by Yusuke Suzuki.
3021
3022         CanvasProxy does not appear to be in any current HTML spec
3023         and was disabled and unimplemented in our tree. Time to 
3024         get rid of it.
3025
3026         * Configurations/FeatureDefines.xcconfig:
3027
3028 2017-09-02  Andy Estes  <aestes@apple.com>
3029
3030         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3031         https://bugs.webkit.org/show_bug.cgi?id=176270
3032
3033         Reviewed by Tim Horton.
3034
3035         * Plugins/Hosted/NetscapePluginHostManager.mm:
3036         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3037         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3038         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3039         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3040         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3041         (WebKit::SoftwareCARenderer::context const):
3042         (WebKit::SoftwareCARenderer::renderContext const):
3043         (WebKit::SoftwareCARenderer::render):
3044         (-[WebHostedNetscapePluginView createPlugin]):
3045         (-[WebHostedNetscapePluginView createPluginLayer]):
3046         (-[WebHostedNetscapePluginView destroyPlugin]):
3047         (-[WebHostedNetscapePluginView drawRect:]):
3048         * WebCoreSupport/WebSystemInterface.mm:
3049         (InitWebCoreSystemInterface):
3050
3051 2017-09-01  Andy Estes  <aestes@apple.com>
3052
3053         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3054         https://bugs.webkit.org/show_bug.cgi?id=176200
3055
3056         Reviewed by Tim Horton.
3057
3058         * Carbon/HIWebView.mm:
3059         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3060         (overrideCGContext):
3061         (restoreCGContext):
3062         (Draw):
3063         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3064         (+[WebHostedNetscapePluginView initialize]):
3065         * Plugins/WebBaseNetscapePluginView.h:
3066         * Plugins/WebBaseNetscapePluginView.mm:
3067         (WebKit::sendUserChangeNotifications):
3068         * Plugins/WebNetscapePluginView.mm:
3069         (+[WebNetscapePluginView initialize]):
3070         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3071         * WebCoreSupport/WebSystemInterface.mm:
3072         (InitWebCoreSystemInterface):
3073         * WebView/WebFrame.mm:
3074         (-[WebFrame _paintBehaviorForDestinationContext:]):
3075         * WebView/WebFullScreenController.mm:
3076         (setClipRectForWindow):
3077         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3078         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3079         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3080         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3081
3082 2017-08-31  Andy Estes  <aestes@apple.com>
3083
3084         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3085         https://bugs.webkit.org/show_bug.cgi?id=176175
3086
3087         Reviewed by Brady Eidson.
3088
3089         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3090         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3091         * Plugins/Hosted/WebTextInputWindowController.m:
3092         (-[WebTextInputPanel init]):
3093         * WebCoreSupport/WebSystemInterface.mm:
3094         (InitWebCoreSystemInterface):
3095         * WebView/WebDynamicScrollBarsView.mm:
3096         (-[WebDynamicScrollBarsView scrollWheel:]):
3097         * WebView/WebHTMLView.mm:
3098         (-[WebHTMLView _removeWindowObservers]):
3099         (-[WebHTMLView addWindowObservers]):
3100         * WebView/WebView.mm:
3101         (-[WebView addWindowObserversForWindow:]):
3102         (-[WebView removeWindowObservers]):
3103         (-[WebView viewWillMoveToWindow:]):
3104
3105 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3106
3107         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3108         https://bugs.webkit.org/show_bug.cgi?id=175779
3109         <rdar://problem/22367975>
3110
3111         Reviewed by Tim Horton.
3112
3113         * WebCoreSupport/WebFrameLoaderClient.h:
3114         * WebCoreSupport/WebFrameLoaderClient.mm:
3115         (WebFrameLoaderClient::webGLPolicyForURL const):
3116         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3117
3118 2017-08-30  Andy Estes  <aestes@apple.com>
3119
3120         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3121         https://bugs.webkit.org/show_bug.cgi?id=176093
3122
3123         Reviewed by Eric Carlson.
3124
3125         * WebCoreSupport/WebSystemInterface.mm:
3126         (InitWebCoreSystemInterface):
3127
3128 2017-08-30  Andy Estes  <aestes@apple.com>
3129
3130         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3131         https://bugs.webkit.org/show_bug.cgi?id=176087
3132
3133         Reviewed by Alex Christensen.
3134
3135         * Carbon/CarbonUtils.m:
3136         (getNSAutoreleasePoolCount):
3137         (WebInitForCarbon):
3138         (PoolCleaner):
3139         * Carbon/CarbonWindowAdapter.mm:
3140         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3141         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3142         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3143         (-[CarbonWindowAdapter _windowMovedToRect:]):
3144         * Carbon/HIViewAdapter.m:
3145         * Carbon/HIWebView.mm:
3146         (Draw):
3147         (CreateNSEventAdoptingCGEvent):
3148         (CopyEventCGEvent):
3149         (CreateNSEventWithCarbonClickEvent):
3150         (Click):
3151         (CreateNSEventWithCarbonEvent):
3152         (MouseUp):
3153         (CreateNSEventWithCarbonMouseMoveEvent):
3154         (MouseMoved):
3155         (MouseDragged):
3156         (MouseWheelMoved):
3157         (WindowHandler):
3158         (HIWebViewEventHandler):
3159         * Misc/QuickDrawCompatibility.h: Removed.
3160         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3161         (getCarbonEvent):
3162         (WebNetscapePluginEventHandlerCarbon::keyDown):
3163         (WebNetscapePluginEventHandlerCarbon::keyUp):
3164         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3165         (WebNetscapePluginEventHandlerCocoa::keyDown):
3166         * Plugins/WebNetscapePluginView.mm:
3167         (-[WebNetscapePluginView tellQuickTimeToChill]):
3168
3169 2017-08-29  Andy Estes  <aestes@apple.com>
3170
3171         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3172         https://bugs.webkit.org/show_bug.cgi?id=176046
3173
3174         Reviewed by Alex Christensen.
3175
3176         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3177         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3178
3179         * Misc/WebNSFileManagerExtras.mm:
3180         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3181         (setMetaData): Deleted.
3182         * WebCoreSupport/WebSystemInterface.mm:
3183         (InitWebCoreSystemInterface):
3184
3185 2017-08-28  Andy Estes  <aestes@apple.com>
3186
3187         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3188         https://bugs.webkit.org/show_bug.cgi?id=176039
3189
3190         Reviewed by Alex Christensen.
3191
3192         * WebCoreSupport/WebSystemInterface.mm:
3193         (InitWebCoreSystemInterface):
3194         * WebView/WebPreferences.mm:
3195         (+[WebPreferences _systemCFStringEncoding]):
3196
3197 2017-08-28  Andy Estes  <aestes@apple.com>
3198
3199         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3200         https://bugs.webkit.org/show_bug.cgi?id=176032
3201
3202         Reviewed by Alex Christensen.
3203
3204         * WebCoreSupport/WebSystemInterface.mm:
3205         (InitWebCoreSystemInterface):
3206         * WebView/WebView.mm:
3207         (-[WebView _cachedResponseForURL:]):
3208
3209 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3210
3211         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3212         https://bugs.webkit.org/show_bug.cgi?id=175992
3213         <rdar://problem/34086613>
3214
3215         Reviewed by Daniel Bates.
3216
3217         * WebCoreSupport/WebPlatformStrategies.h:
3218         * WebCoreSupport/WebPlatformStrategies.mm:
3219         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3220         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3221         indicating if secure cookies were accessed.
3222
3223 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3224
3225         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3226         https://bugs.webkit.org/show_bug.cgi?id=170955
3227         <rdar://problem/31697653>
3228
3229         Reviewed by Ryosuke Niwa.
3230
3231         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3232         text is being replaced.
3233
3234         * WebView/WebHTMLView.mm:
3235         (-[WebHTMLView insertText:]):
3236
3237 2017-08-24  Chris Dumez  <cdumez@apple.com>
3238
3239         [Directory Upload] Add basic support for input.webkitdirectory
3240         https://bugs.webkit.org/show_bug.cgi?id=175950
3241         <rdar://problem/33951915>
3242
3243         Reviewed by Geoffrey Garen.
3244
3245         Add private API to toggle Directory Upload support on Mac WebKit1.
3246
3247         * WebView/WebPreferenceKeysPrivate.h:
3248         * WebView/WebPreferences.mm:
3249         (+[WebPreferences initialize]):
3250         (-[WebPreferences setDirectoryUploadEnabled:]):
3251         (-[WebPreferences directoryUploadEnabled]):
3252         * WebView/WebPreferencesPrivate.h:
3253         * WebView/WebView.mm:
3254         (-[WebView _preferencesChanged:]):
3255
3256 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3257
3258         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3259         https://bugs.webkit.org/show_bug.cgi?id=175370
3260         <rdar://problem/33799806>
3261
3262         Reviewed by Ryosuke Niwa.
3263
3264         Adjust WebEditorClient for interface changes.
3265
3266         * WebCoreSupport/WebEditorClient.h:
3267
3268 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3269
3270         Remove ChromeClient::scrollbarsModeDidChange
3271         https://bugs.webkit.org/show_bug.cgi?id=175805
3272
3273         Reviewed by Daniel Bates.
3274
3275         * WebCoreSupport/WebChromeClient.h:
3276
3277 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3278
3279         Remove ChromeClient::hasOpenedPopup
3280         https://bugs.webkit.org/show_bug.cgi?id=175804
3281
3282         Reviewed by Sam Weinig.
3283
3284         * WebCoreSupport/WebChromeClient.h:
3285         * WebCoreSupport/WebChromeClient.mm:
3286         (WebChromeClient::hasOpenedPopup const): Deleted.
3287
3288 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3289
3290         Disable access to secure cookies if an HTTPS site loads mixed content
3291         https://bugs.webkit.org/show_bug.cgi?id=157053
3292         <rdar://problem/11290808>
3293
3294         Reviewed by Dan Bates.
3295
3296         * WebCoreSupport/WebPlatformStrategies.h:
3297         * WebCoreSupport/WebPlatformStrategies.mm:
3298         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3299         indicating whether secure cookies should be included in the response.
3300
3301 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3302
3303         [PAL] Move spi/mac directory into PAL
3304         https://bugs.webkit.org/show_bug.cgi?id=175649
3305
3306         Reviewed by Myles C. Maxfield.
3307
3308         * Misc/WebSharingServicePickerController.h:
3309         * WebCoreSupport/WebContextMenuClient.mm:
3310         * WebCoreSupport/WebEditorClient.mm:
3311         * WebCoreSupport/WebSelectionServiceController.mm:
3312         * WebView/WebHTMLView.mm:
3313         * WebView/WebImmediateActionController.h:
3314         * WebView/WebImmediateActionController.mm:
3315         * WebView/WebView.mm:
3316
3317 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3318
3319         [PAL] Relocate SessionID to root
3320         https://bugs.webkit.org/show_bug.cgi?id=175684
3321
3322         Reviewed by Alex Christensen.
3323
3324         * WebCoreSupport/WebFrameNetworkingContext.mm:
3325
3326 2017-08-17  Andreas Kling  <akling@apple.com>
3327
3328         Disable CSS regions at compile time
3329         https://bugs.webkit.org/show_bug.cgi?id=175630
3330
3331         Reviewed by Antti Koivisto.
3332
3333         * Configurations/FeatureDefines.xcconfig:
3334
3335 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3336
3337         [PAL] Move SessionID into PAL
3338         https://bugs.webkit.org/show_bug.cgi?id=174192
3339
3340         Reviewed by Antti Koivisto.
3341
3342         * Misc/WebCache.mm:
3343         (+[WebCache imageForURL:]):
3344         * WebCoreSupport/WebFrameLoaderClient.h:
3345         * WebCoreSupport/WebFrameLoaderClient.mm:
3346         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3347         * WebCoreSupport/WebFrameNetworkingContext.mm:
3348         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3349         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3350         (WebFrameNetworkingContext::storageSession const):
3351         * WebCoreSupport/WebPlatformStrategies.h:
3352         * WebCoreSupport/WebPlatformStrategies.mm:
3353         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3354         * WebKitPrefix.h:
3355
3356 2017-08-16  Andy Estes  <aestes@apple.com>
3357
3358         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3359         https://bugs.webkit.org/show_bug.cgi?id=175648
3360
3361         Reviewed by Tim Horton.
3362
3363         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3364         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3365         (WebPaymentCoordinatorClient::showPaymentUI):
3366
3367 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3368
3369         [PAL] Move spi/ios and spi/win directories into PAL
3370         https://bugs.webkit.org/show_bug.cgi?id=175171
3371
3372         Reviewed by Antti Koivisto.
3373
3374         * WebCoreSupport/WebFrameLoaderClient.mm:
3375         * WebView/WebView.mm:
3376
3377 2017-08-16  Andy Estes  <aestes@apple.com>
3378
3379         [Payment Request] Add an ENABLE flag and an experimental feature preference
3380         https://bugs.webkit.org/show_bug.cgi?id=175622
3381
3382         Reviewed by Tim Horton.
3383
3384         * Configurations/FeatureDefines.xcconfig:
3385
3386 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3387
3388         [PAL] Move Sleep classes into PAL
3389         https://bugs.webkit.org/show_bug.cgi?id=175456
3390
3391         Reviewed by Ryosuke Niwa.
3392
3393         * WebView/WebFullScreenController.h:
3394
3395 2017-08-15  Youenn Fablet  <youenn@apple.com>
3396
3397         [Cache API] Adding generic support for CacheStorage and Cache methods
3398         https://bugs.webkit.org/show_bug.cgi?id=175455
3399
3400         Reviewed by Chris Dumez.
3401
3402         * WebView/WebView.mm:
3403         (-[WebView _commonInitializationWithFrameName:groupName:]):
3404
3405 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3406
3407         Remove Proximity Events and related code
3408         https://bugs.webkit.org/show_bug.cgi?id=175545
3409
3410         Reviewed by Daniel Bates.
3411
3412         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3413         and other related code.
3414
3415         * Configurations/FeatureDefines.xcconfig:
3416
3417 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3418
3419         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3420         https://bugs.webkit.org/show_bug.cgi?id=175504
3421
3422         Reviewed by Sam Weinig.
3423
3424         * Configurations/FeatureDefines.xcconfig:
3425         * DOM/DOMHTMLFormElement.mm:
3426         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3427         * WebCoreSupport/WebFrameLoaderClient.h:
3428
3429 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3430
3431         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3432         https://bugs.webkit.org/show_bug.cgi?id=175557
3433
3434         Reviewed by Jon Lee.
3435
3436         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3437
3438         * Configurations/FeatureDefines.xcconfig:
3439
3440 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3441
3442         Composition underline color is always black
3443         https://bugs.webkit.org/show_bug.cgi?id=174675
3444
3445         Reviewed by Ryosuke Niwa.
3446
3447         * WebView/WebHTMLView.mm:
3448         (extractUnderlines): If NSUnderlineColorAttributeName
3449         is not present use text color for composition underline.
3450         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3451         for composition underline in the plain text case.
3452
3453 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3454
3455         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3456         https://bugs.webkit.org/show_bug.cgi?id=175474
3457         <rdar://problem/33844628>
3458
3459         Reviewed by Wenson Hsieh.
3460
3461         Replaced the build flag by a runtime flag and disabled the feature by default.
3462
3463         * Configurations/FeatureDefines.xcconfig:
3464         * WebView/WebPreferenceKeysPrivate.h:
3465         * WebView/WebPreferences.mm:
3466         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3467         (-[WebPreferences dataTransferItemsEnabled]): Added.
3468         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3469         * WebView/WebPreferencesPrivate.h:
3470         * WebView/WebView.mm:
3471         (-[WebView _preferencesChanged:]):
3472
3473 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3474
3475         Remove ENABLE_GAMEPAD_DEPRECATED
3476         https://bugs.webkit.org/show_bug.cgi?id=175361
3477
3478         Reviewed by Carlos Garcia Campos.
3479
3480         * Configurations/FeatureDefines.xcconfig:
3481
3482 2017-08-09  Chris Dumez  <cdumez@apple.com>
3483
3484         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3485         https://bugs.webkit.org/show_bug.cgi?id=175401
3486
3487         Reviewed by Brady Eidson.
3488
3489         * WebView/WebPreferenceKeysPrivate.h:
3490         * WebView/WebPreferences.mm:
3491         (+[WebPreferences initialize]):
3492         (-[WebPreferences beaconAPIEnabled]): Deleted.
3493         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.