d08a24cfe5b4b6630e6688c1ddac97a28b778868
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-17  Brady Eidson  <beidson@apple.com>
2
3         Link clicks in PDFs shouldn't send referrer headers.
4         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
5
6         Reviewed by Tim Horton.
7
8         * WebView/WebPDFView.mm:
9         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
10
11 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
12
13         requestAnimationFrame should execute before the next frame
14         https://bugs.webkit.org/show_bug.cgi?id=177484
15
16         Reviewed by Simon Fraser.
17
18         * WebView/WebView.mm:
19         (-[WebView _viewWillDrawInternal]):
20         (-[WebView _flushCompositingChanges]):
21         Call Page::updateRendering() which implements "Update the rendering"
22         step of the HTML Event Loop specification.
23
24 2019-04-10  Devin Rousso  <drousso@apple.com>
25
26         Web Inspector: save sheet should be anchored underneath the tab bar when detached
27         https://bugs.webkit.org/show_bug.cgi?id=196722
28         <rdar://problem/49613280>
29
30         Reviewed by Timothy Hatcher.
31
32         * WebCoreSupport/WebInspectorClient.h:
33         (WebInspectorFrontendClient::sheetRect const): Added.
34         * WebCoreSupport/WebInspectorClient.mm:
35         (-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
36         (WebInspectorFrontendClient::setSheetRect): Added.
37
38 2019-04-10  Alex Christensen  <achristensen@webkit.org>
39
40         Add SPI WKNavigationResponse._downloadAttribute
41         https://bugs.webkit.org/show_bug.cgi?id=196755
42         <rdar://49587365>
43
44         Reviewed by Brady Eidson.
45
46         * WebCoreSupport/WebFrameLoaderClient.h:
47         * WebCoreSupport/WebFrameLoaderClient.mm:
48         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
49
50 2019-04-10  Antoine Quint  <graouts@apple.com>
51
52         Enable Pointer Events on watchOS
53         https://bugs.webkit.org/show_bug.cgi?id=196771
54         <rdar://problem/49040909>
55
56         Reviewed by Dean Jackson.
57
58         * Configurations/FeatureDefines.xcconfig:
59
60 2019-04-08  Justin Fan  <justin_fan@apple.com>
61
62         [Web GPU] Fix Web GPU experimental feature on iOS
63         https://bugs.webkit.org/show_bug.cgi?id=196632
64
65         Reviewed by Myles C. Maxfield.
66
67         Add feature conditionals for iOS 11.
68         Properly make Web GPU available on iOS 11+.
69
70         * Configurations/FeatureDefines.xcconfig:
71         * Configurations/WebKitTargetConditionals.xcconfig:
72
73 2019-04-05  Alex Christensen  <achristensen@webkit.org>
74
75         REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on non-main thread
76         https://bugs.webkit.org/show_bug.cgi?id=190918
77         <rdar://problem/45603890>
78
79         Reviewed by Darin Adler.
80
81         Since we not doing networking on the main thread but WebView is to be used on the main thread,
82         we need to hop delegate calls to the main thread similarly to how we do it in the non-download
83         delegate calls in WebCoreResourceHandleAsOperationQueueDelegate.
84
85         * Misc/WebDownload.mm:
86         (-[WebDownloadInternal downloadDidBegin:]):
87         (-[WebDownloadInternal download:willSendRequest:redirectResponse:]):
88         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
89         (-[WebDownloadInternal download:didReceiveResponse:]):
90         (-[WebDownloadInternal download:didReceiveDataOfLength:]):
91         (-[WebDownloadInternal download:shouldDecodeSourceDataOfMIMEType:]):
92         (-[WebDownloadInternal download:decideDestinationWithSuggestedFilename:]):
93         (-[WebDownloadInternal download:didCreateDestination:]):
94         (-[WebDownloadInternal downloadDidFinish:]):
95         (-[WebDownloadInternal download:didFailWithError:]):
96
97 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
98
99         Remove AUDIO_TOOLBOX_AUDIO_SESSION
100         https://bugs.webkit.org/show_bug.cgi?id=196653
101         <rdar://problem/49652098>
102
103         Reviewed by Jer Noble.
104
105         * WebView/WebPreferences.mm:
106         (-[WebPreferences setAudioSessionCategoryOverride:]):
107
108 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
109
110         Stop including <AudioToolbox/AudioSession.h>
111         https://bugs.webkit.org/show_bug.cgi?id=196648
112         <rdar://problem/39665771>
113
114         Reviewed by Jer Noble.
115
116         * WebView/WebPreferencesPrivate.h:
117
118 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
119
120         Have ScrollableArea store a ScrollType for the current scroll
121         https://bugs.webkit.org/show_bug.cgi?id=196627
122
123         Reviewed by Zalan Bujtas.
124
125         Send the programmatic scroll type.
126
127         * DOM/DOMHTML.mm:
128         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
129
130 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
131
132         -apple-trailing-word is needed for browser detection
133         https://bugs.webkit.org/show_bug.cgi?id=196575
134
135         Unreviewed.
136
137         * Configurations/FeatureDefines.xcconfig:
138
139 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
140
141         Remove support for -apple-trailing-word
142         https://bugs.webkit.org/show_bug.cgi?id=196525
143
144         Reviewed by Zalan Bujtas.
145
146         This CSS property is nonstandard and not used.
147
148         * Configurations/FeatureDefines.xcconfig:
149
150 2019-04-01  Alex Christensen  <achristensen@webkit.org>
151
152         Add SPI to canonicalize NSURLs with WTF::URL
153         https://bugs.webkit.org/show_bug.cgi?id=196415
154         <rdar://problem/44980271>
155
156         Reviewed by Darin Adler.
157
158         * Misc/WebNSURLExtras.h:
159         * Misc/WebNSURLExtras.mm:
160         (-[NSURL _webkit_canonicalize_with_wtf]):
161         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
162         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
163
164 2019-03-31  Sam Weinig  <weinig@apple.com>
165
166         Remove more i386 specific configurations
167         https://bugs.webkit.org/show_bug.cgi?id=196430
168
169         Reviewed by Alexey Proskuryakov.
170
171         * Configurations/FeatureDefines.xcconfig:
172         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
173
174 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
175
176         Delete WebMetal implementation in favor of WebGPU
177         https://bugs.webkit.org/show_bug.cgi?id=195418
178
179         Reviewed by Dean Jackson.
180
181         * Configurations/FeatureDefines.xcconfig:
182         * WebView/WebPreferenceKeysPrivate.h:
183         * WebView/WebPreferences.mm:
184         (+[WebPreferences initialize]):
185         (-[WebPreferences webMetalEnabled]): Deleted.
186         (-[WebPreferences setWebMetalEnabled:]): Deleted.
187         * WebView/WebPreferencesPrivate.h:
188         * WebView/WebView.mm:
189         (-[WebView _preferencesChanged:]):
190
191 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
192
193         Implement ResizeObserver.
194         https://bugs.webkit.org/show_bug.cgi?id=157743
195
196         Reviewed by Simon Fraser.
197
198         * Configurations/FeatureDefines.xcconfig:
199         * WebView/WebPreferenceKeysPrivate.h:
200         * WebView/WebPreferences.mm:
201         (+[WebPreferences initialize]):
202         (-[WebPreferences resizeObserverEnabled]):
203         (-[WebPreferences setResizeObserverEnabled:]):
204         * WebView/WebPreferencesPrivate.h:
205         * WebView/WebView.mm:
206         (-[WebView _preferencesChanged:]):
207         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
208
209 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
210
211         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
212         https://bugs.webkit.org/show_bug.cgi?id=196336
213
214         Reviewed by Tim Horton.
215
216         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
217
218         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
219
220         * WebCoreSupport/PopupMenuMac.mm:
221         (PopupMenuMac::hide):
222
223 2019-03-25  Andy Estes  <aestes@apple.com>
224
225         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
226         https://bugs.webkit.org/show_bug.cgi?id=194964
227         <rdar://problem/48279441>
228
229         Reviewed by Alex Christensen.
230
231         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
232         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
233         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
234         PreviewLoaderClient alive for its lifetime. This ensures that as long as
235         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
236         by WebKit.
237
238         * WebCoreSupport/WebFrameLoaderClient.mm:
239         (WebFrameLoaderClient::createPreviewLoaderClient):
240         * WebView/WebDataSource.mm:
241         (-[WebDataSource _quickLookPreviewLoaderClient]):
242         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
243         * WebView/WebDataSourceInternal.h:
244
245 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
246
247         Remove NavigatorContentUtils in WebCore/Modules
248         https://bugs.webkit.org/show_bug.cgi?id=196070
249
250         Reviewed by Alex Christensen.
251
252         NavigatorContentUtils was to support the custom scheme spec [1].
253         However, in WebKit side, no port has supported the feature in
254         WebKit layer after EFL port was removed. So there has been the
255         only IDL implementation of the NavigatorContentUtils in WebCore.
256         So we don't need to keep the implementation in WebKit.
257
258         * Configurations/FeatureDefines.xcconfig:
259
260 2019-03-22  Keith Rollin  <krollin@apple.com>
261
262         Enable ThinLTO support in Production builds
263         https://bugs.webkit.org/show_bug.cgi?id=190758
264         <rdar://problem/45413233>
265
266         Reviewed by Daniel Bates.
267
268         Enable building with Thin LTO in Production when using Xcode 10.2 or
269         later. This change results in a 1.45% progression in PLT5. Full
270         Production build times increase about 2-3%. Incremental build times
271         are more severely affected, and so LTO is not enabled for local
272         engineering builds.
273
274         LTO is enabled only on macOS for now, until rdar://problem/49013399,
275         which affects ARM builds, is fixed.
276
277         To change the LTO setting when building locally:
278
279         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
280           command line.
281         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
282           on the command line.
283         - If building with `build-root`, specify --lto={none,thin,full} on the
284           command line.
285         - If building with Xcode, create a LocalOverrides.xcconfig file at the
286           top level of your repository directory (if needed) and define
287           WK_LTO_MODE to full, thin, or none.
288
289         * Configurations/Base.xcconfig:
290
291 2019-03-21  Andy Estes  <aestes@apple.com>
292
293         [iOS] Apple Pay should be available in documents with no user agent scripts
294         https://bugs.webkit.org/show_bug.cgi?id=196061
295         <rdar://problem/48649391>
296
297         Reviewed by Brady Eidson.
298
299         * WebView/WebFrame.mm:
300         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
301
302 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
303
304         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
305         https://bugs.webkit.org/show_bug.cgi?id=196049
306
307         Reviewed by Tim Horton.
308
309         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
310         overflow scrolling in general, so rename it.
311
312         * Configurations/FeatureDefines.xcconfig:
313
314 2019-03-13  Dean Jackson  <dino@apple.com>
315
316         Block all plugins smaller than 5x5px
317         https://bugs.webkit.org/show_bug.cgi?id=195702
318         <rdar://problem/28435204>
319
320         Reviewed by Sam Weinig.
321
322         Removed a function that was never being called.
323
324         * WebCoreSupport/WebFrameLoaderClient.h:
325         * WebCoreSupport/WebFrameLoaderClient.mm:
326         (WebFrameLoaderClient::recreatePlugin): Deleted.
327
328 2019-03-13  Keith Rollin  <krollin@apple.com>
329
330         Add support for new StagedFrameworks layout
331         https://bugs.webkit.org/show_bug.cgi?id=195543
332
333         Reviewed by Alexey Proskuryakov.
334
335         When creating the WebKit layout for out-of-band Safari/WebKit updates,
336         use an optional path prefix when called for.
337
338         * Configurations/WebKitLegacy.xcconfig:
339
340 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
341
342         Remove a site specific hack for AppleConnect plugin
343         https://bugs.webkit.org/show_bug.cgi?id=195643
344
345         Reviewed by Simon Fraser.
346
347         r66437 added a workaround for AppleConnect plugin.
348
349         Remove this code since Safari doesn't even use WebKitLegacy anymore,
350         and other WebKit clients support AppleConnect plugins.
351
352         * WebCoreSupport/WebFrameLoaderClient.mm:
353         (WebFrameLoaderClient::createPlugin):
354
355 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
356
357         Unreviewed, rolling out r242688, r242643, r242624.
358
359         Caused multiple layout test failures and crashes on iOS and macOS.
360
361         Reverted changeset:
362
363         "requestAnimationFrame should execute before the next frame"
364         https://bugs.webkit.org/show_bug.cgi?id=177484
365         https://trac.webkit.org/changeset/242624/webkit
366
367         * WebView/WebView.mm:
368         (-[WebView _viewWillDrawInternal]):
369
370 2019-03-09  Andy Estes  <aestes@apple.com>
371
372         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
373         https://bugs.webkit.org/show_bug.cgi?id=195526
374         <rdar://problem/48745636>
375
376         Reviewed by Chris Dumez.
377
378         * WebCoreSupport/WebPaymentCoordinatorClient.h:
379         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
380         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
381         (WebPaymentCoordinatorClient::openPaymentSetup):
382
383 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
384
385         requestAnimationFrame should execute before the next frame
386         https://bugs.webkit.org/show_bug.cgi?id=177484
387
388         Reviewed by Simon Fraser.
389
390         * WebView/WebView.mm:
391         (-[WebView _viewWillDrawInternal]):
392         Call Page::renderingUpdate() which implements  "Update the rendering"
393         step of the HTML Event Loop specification.
394
395 2019-03-07  Zalan Bujtas  <zalan@apple.com>
396
397         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
398         https://bugs.webkit.org/show_bug.cgi?id=195353
399         <rdar://problem/48626394>
400
401         Reviewed by Simon Fraser.
402
403         * WebView/WebPreferenceKeysPrivate.h:
404         * WebView/WebPreferences.mm:
405         (+[WebPreferences initialize]):
406         (-[WebPreferences contentChangeObserverEnabled]):
407         (-[WebPreferences setContentChangeObserverEnabled:]):
408         * WebView/WebPreferencesPrivate.h:
409         * WebView/WebView.mm:
410         (-[WebView _preferencesChanged:]):
411
412 2019-03-06  Sam Weinig  <sam@webkit.org>
413
414         WebKitLegacy does not need to generate an export file for i386 anymore
415         https://bugs.webkit.org/show_bug.cgi?id=195380
416
417         Reviewed by Dan Bernstein.
418
419         * Configurations/WebKitLegacy.xcconfig:
420         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
421         It still needs to be generated, since we are concatenating the shared exports
422         file with a macOS or iOS specific one.
423
424         * WebKit.mac.exp:
425         Remove i386 specific symbols that we were previously stripping.
426
427 2019-03-06  Rob Buis  <rbuis@igalia.com>
428
429         Consider supporting the `referrerpolicy` attribute.
430         https://bugs.webkit.org/show_bug.cgi?id=179053
431
432         Reviewed by Darin Adler.
433
434         Add a runtime flag for referrerpolicy attribute.
435
436         * WebView/WebPreferenceKeysPrivate.h:
437         * WebView/WebPreferences.mm:
438         (+[WebPreferences initialize]):
439         (-[WebPreferences referrerPolicyAttributeEnabled]):
440         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
441         * WebView/WebPreferencesPrivate.h:
442         * WebView/WebView.mm:
443         (-[WebView _preferencesChanged:]):
444
445 2019-03-03  Tim Horton  <timothy_horton@apple.com>
446
447         Remove some more unused 32-bit code
448         https://bugs.webkit.org/show_bug.cgi?id=195255
449
450         Reviewed by Darin Adler.
451
452         * Plugins/WebNetscapePluginEventHandler.mm:
453         (WebNetscapePluginEventHandler::create):
454         * Plugins/WebNetscapePluginView.h:
455         * Plugins/WebNetscapePluginView.mm:
456         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
457         (-[WebNetscapePluginView restorePortState:]):
458         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
459         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
460         (-[WebNetscapePluginView updateAndSetWindow]):
461         (-[WebNetscapePluginView setWindowIfNecessary]):
462         (-[WebNetscapePluginView createPlugin]):
463         (-[WebNetscapePluginView fini]):
464         (-[WebNetscapePluginView drawRect:]):
465         (-[WebNetscapePluginView invalidateRegion:]):
466         (-[WebNetscapePluginView getVariable:value:]):
467         (-[WebNetscapePluginView setVariable:value:]):
468         (isDrawingModelQuickDraw): Deleted.
469         (-[WebNetscapePluginView fixWindowPort]): Deleted.
470         (getQDPixelFormatForBitmapContext): Deleted.
471         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
472         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
473         * WebView/WebDelegateImplementationCaching.mm:
474
475 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
476
477         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
478         https://bugs.webkit.org/show_bug.cgi?id=195053
479         <rdar://problem/48134710>
480
481         Reviewed by Ryosuke Niwa.
482
483         * WebCoreSupport/WebEditorClient.h:
484
485 2019-03-01  Tim Horton  <timothy_horton@apple.com>
486
487         Remove unused code in WebKitLegacy
488         https://bugs.webkit.org/show_bug.cgi?id=189614
489
490         Reviewed by Simon Fraser.
491
492         * Carbon/CarbonUtils.h: Removed.
493         * Carbon/CarbonUtils.m: Removed.
494         * Carbon/CarbonWindowAdapter.h: Removed.
495         * Carbon/CarbonWindowAdapter.mm: Removed.
496         * Carbon/CarbonWindowContentView.h: Removed.
497         * Carbon/CarbonWindowContentView.m: Removed.
498         * Carbon/CarbonWindowFrame.h: Removed.
499         * Carbon/CarbonWindowFrame.m: Removed.
500         * Carbon/HIViewAdapter.h: Removed.
501         * Carbon/HIViewAdapter.m: Removed.
502         * Carbon/HIWebView.h: Removed.
503         * Carbon/HIWebView.mm: Removed.
504         * Configurations/WebKitLegacy.xcconfig:
505         * WebKit.mac.exp:
506
507 2019-03-01  Justin Fan  <justin_fan@apple.com>
508
509         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
510         https://bugs.webkit.org/show_bug.cgi?id=195191
511
512         Rubber-stamped by Dean Jackson.
513
514         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
515
516         * Configurations/FeatureDefines.xcconfig:
517
518 2019-02-28  Antoine Quint  <graouts@apple.com>
519
520         Enable the Pointer Events runtime flag by default
521         https://bugs.webkit.org/show_bug.cgi?id=195156
522
523         Reviewed by Dean Jackson.
524
525         * WebView/WebPreferences.mm:
526         (+[WebPreferences initialize]):
527
528 2019-02-28  Justin Fan  <justin_fan@apple.com>
529
530         [Web GPU] Enable Web GPU only on 64-bit
531         https://bugs.webkit.org/show_bug.cgi?id=195139
532
533         Because Metal is only supported on 64 bit apps.
534
535         Unreviewed build fix.
536
537         * Configurations/FeatureDefines.xcconfig:
538
539 2019-02-27  Antoine Quint  <graouts@apple.com>
540
541         Support Pointer Events on macOS
542         https://bugs.webkit.org/show_bug.cgi?id=195008
543         <rdar://problem/47454419>
544
545         Reviewed by Dean Jackson.
546
547         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
548
549         * Configurations/FeatureDefines.xcconfig:
550         * WebView/WebPreferenceKeysPrivate.h:
551         * WebView/WebPreferences.mm:
552         (+[WebPreferences initialize]):
553         (-[WebPreferences pointerEventsEnabled]):
554         (-[WebPreferences setPointerEventsEnabled:]):
555         * WebView/WebPreferencesPrivate.h:
556         * WebView/WebView.mm:
557         (-[WebView _preferencesChanged:]):
558
559 2019-02-23  Keith Miller  <keith_miller@apple.com>
560
561         Add new mac target numbers
562         https://bugs.webkit.org/show_bug.cgi?id=194955
563
564         Reviewed by Tim Horton.
565
566         * Configurations/Base.xcconfig:
567         * Configurations/DebugRelease.xcconfig:
568
569 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
570
571         Hardcode Visual Viewports on everywhere except iOS WK1
572         https://bugs.webkit.org/show_bug.cgi?id=194928
573
574         Reviewed by Zalan Bujtas.
575
576         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
577         change the default value of the Setting to 'true', and hardcode WebView on iOS to
578         set it to false. The setting has shipped for several years and there's no need to turn
579         it off now.
580
581         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
582         Visual Viewports are not enabled.
583         
584         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
585         that only runs in WK2
586
587         * WebView/WebPreferenceKeysPrivate.h:
588         * WebView/WebPreferences.mm:
589         (+[WebPreferences initialize]):
590         (-[WebPreferences visualViewportEnabled]): Deleted.
591         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
592         * WebView/WebPreferencesPrivate.h:
593         * WebView/WebView.mm:
594         (-[WebView _preferencesChanged:]):
595
596 2019-02-21  Darin Adler  <darin@apple.com>
597
598         Some refinements for Node and Document
599         https://bugs.webkit.org/show_bug.cgi?id=194764
600
601         Reviewed by Ryosuke Niwa.
602
603         * DOM/DOMDocument.mm:
604         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
605         through to WebCore or even looking at the arguments.
606         (-[DOMDocument getOverrideStyle::]): Ditto.
607
608 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
609
610         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
611         https://bugs.webkit.org/show_bug.cgi?id=194670
612         <rdar://problem/39066529>
613
614         Reviewed by Tim Horton.
615
616         * WebCoreSupport/WebEditorClient.h:
617         * WebCoreSupport/WebEditorClient.mm:
618         (WebEditorClient::replacementURLForResource): Deleted.
619         * WebCoreSupport/WebPlatformStrategies.h:
620         * WebCoreSupport/WebPlatformStrategies.mm:
621         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
622
623 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
624
625         Add MSE logging configuration
626         https://bugs.webkit.org/show_bug.cgi?id=194719
627         <rdar://problem/48122151>
628
629         Reviewed by Joseph Pecoraro.
630
631         * WebCoreSupport/WebChromeClient.mm:
632         (stringForMessageSource): Recognize the MSE message source.
633
634 2019-02-17  David Kilzer  <ddkilzer@apple.com>
635
636         Unreviewed, rolling out r241620.
637
638         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
639         (Requested by ddkilzer on #webkit.)
640
641         Reverted changeset:
642
643         "[WTF] Add environment variable helpers"
644         https://bugs.webkit.org/show_bug.cgi?id=192405
645         https://trac.webkit.org/changeset/241620
646
647 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
648
649         [WTF] Add environment variable helpers
650         https://bugs.webkit.org/show_bug.cgi?id=192405
651
652         Reviewed by Michael Catanzaro.
653
654         * WebView/WebView.mm:
655         (-[WebView _initWithFrame:frameName:groupName:]):
656         Utilize WTF::Environment where possible.
657
658 2019-02-15  Brian Burg  <bburg@apple.com>
659
660         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
661         https://bugs.webkit.org/show_bug.cgi?id=194411
662         <rdar://problem/47787614>
663
664         Reviewed by Joseph Pecoraro.
665
666         * Configurations/WebKitLegacy.xcconfig:
667         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
668
669         * WebCoreSupport/WebInspectorClient.mm:
670         (WebInspectorFrontendClient::localizedStringsURL):
671         (-[WebInspectorWindowController inspectorPagePath]):
672         (-[WebInspectorWindowController inspectorTestPagePath]):
673         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
674
675 2019-02-15  Commit Queue  <commit-queue@webkit.org>
676
677         Unreviewed, rolling out r241559 and r241566.
678         https://bugs.webkit.org/show_bug.cgi?id=194710
679
680         Causes layout test crashes under GuardMalloc (Requested by
681         ryanhaddad on #webkit).
682
683         Reverted changesets:
684
685         "[WTF] Add environment variable helpers"
686         https://bugs.webkit.org/show_bug.cgi?id=192405
687         https://trac.webkit.org/changeset/241559
688
689         "Unreviewed build fix for WinCairo Debug after r241559."
690         https://trac.webkit.org/changeset/241566
691
692 2019-02-15  Truitt Savell  <tsavell@apple.com>
693
694         Unreviewed, rolling out r241564.
695
696         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
697
698         Reverted changeset:
699
700         "[Mac] WebInspectorUI.framework does not need to be soft-
701         linked anymore"
702         https://bugs.webkit.org/show_bug.cgi?id=194411
703         https://trac.webkit.org/changeset/241564
704
705 2019-02-14  Brian Burg  <bburg@apple.com>
706
707         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
708         https://bugs.webkit.org/show_bug.cgi?id=194411
709         <rdar://problem/47787614>
710
711         Reviewed by Joseph Pecoraro.
712
713         * Configurations/WebKitLegacy.xcconfig:
714         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
715
716         * WebCoreSupport/WebInspectorClient.mm:
717         (WebInspectorFrontendClient::localizedStringsURL):
718         (-[WebInspectorWindowController inspectorPagePath]):
719         (-[WebInspectorWindowController inspectorTestPagePath]):
720         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
721
722 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
723
724         [WTF] Add environment variable helpers
725         https://bugs.webkit.org/show_bug.cgi?id=192405
726
727         Reviewed by Michael Catanzaro.
728
729         * WebView/WebView.mm:
730         (-[WebView _initWithFrame:frameName:groupName:]):
731         Utilize WTF::Environment where possible.
732
733 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
734
735         Allow pages to trigger programmatic paste from script on iOS
736         https://bugs.webkit.org/show_bug.cgi?id=194271
737         <rdar://problem/47808810>
738
739         Reviewed by Ryosuke Niwa.
740
741         See WebCore and WebKit ChangeLogs for more details.
742
743         * WebCoreSupport/WebEditorClient.h:
744
745 2019-02-12  Andy Estes  <aestes@apple.com>
746
747         [iOSMac] Enable Parental Controls Content Filtering
748         https://bugs.webkit.org/show_bug.cgi?id=194521
749         <rdar://39732376>
750
751         Reviewed by Tim Horton.
752
753         * Configurations/FeatureDefines.xcconfig:
754
755 2019-02-06  Andy Estes  <aestes@apple.com>
756
757         [Payment Request] It should be possible to require a phonetic name for shipping contacts
758         https://bugs.webkit.org/show_bug.cgi?id=194311
759         <rdar://46733045>
760
761         Reviewed by Alex Christensen.
762
763         * WebCoreSupport/WebPaymentCoordinatorClient.h:
764         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
765         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
766
767 2019-02-04  Said Abou-Hallawa  <said@apple.com>
768
769         [CG] Enable setAdditionalSupportedImageTypes for WK1
770         https://bugs.webkit.org/show_bug.cgi?id=194190
771
772         Reviewed by Tim Horton.
773
774         1. Define the preferences key AdditionalSupportedImageTypes.
775         2. Add additionalSupportedImageTypes as a private preference property.
776         3. Define the setter and the getter of the property.
777         4. Add function to convert from an id to an array of strings.
778         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
779
780         * WebView/WebPreferenceKeysPrivate.h:
781         * WebView/WebPreferences.mm:
782         (-[WebPreferences _stringArrayValueForKey:]):
783         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
784         (-[WebPreferences setAdditionalSupportedImageTypes:]):
785         (-[WebPreferences additionalSupportedImageTypes]):
786         * WebView/WebPreferencesPrivate.h:
787         * WebView/WebView.mm:
788         (-[WebView _preferencesChanged:]):
789
790 2019-02-04  Timothy Hatcher  <timothy@apple.com>
791
792         Add WebView SPI to temporarily force light or dark appearance on a page.
793         https://bugs.webkit.org/show_bug.cgi?id=194230
794
795         Reviewed by Tim Horton.
796
797         * WebView/WebView.mm:
798         (-[WebView _useDarkAppearance:]): Added.
799         (-[WebView _setUseDarkAppearance:]): Added.
800         * WebView/WebViewPrivate.h:
801
802 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
803
804         PageOverlayController's layers should be created lazily
805         https://bugs.webkit.org/show_bug.cgi?id=194199
806         rdar://problem/46571593
807
808         Reviewed by Tim Horton.
809
810         * WebCoreSupport/WebChromeClient.h:
811         * WebCoreSupport/WebChromeClient.mm:
812         (WebChromeClient::attachViewOverlayGraphicsLayer):
813
814 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
815
816         Make setNeedsLayout on the root more explicitly about triggering its side-effects
817         https://bugs.webkit.org/show_bug.cgi?id=194198
818
819         Reviewed by Antti Koivisto.
820
821         Call the newly named functions.
822
823         * WebView/WebFrame.mm:
824         (-[WebFrame setNeedsLayout]):
825         * WebView/WebHTMLView.mm:
826         (-[WebHTMLView setNeedsLayout:]):
827
828 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
829
830         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
831         https://bugs.webkit.org/show_bug.cgi?id=194189
832
833         Reviewed by Geoffrey Garen.
834
835         Pass the policy check identifier around functions and store it in WebFramePolicyListener
836         so that we can send it back to WebCore with the navigation policy decision.
837
838         * WebCoreSupport/WebFrameLoaderClient.h:
839         * WebCoreSupport/WebFrameLoaderClient.mm:
840         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
841         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
842         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
843         (WebFrameLoaderClient::dispatchWillSubmitForm):
844         (WebFrameLoaderClient::setUpPolicyListener):
845         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
846         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
847         (-[WebFramePolicyListener invalidate]):
848         (-[WebFramePolicyListener dealloc]):
849         (-[WebFramePolicyListener receivedPolicyDecision:]):
850         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
851         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
852
853 2019-01-31  Alex Christensen  <achristensen@webkit.org>
854
855         Revert r238819 which is unneeded and caused a performance regression.
856         https://bugs.webkit.org/show_bug.cgi?id=192272
857         <rdar://problem/46664625>
858
859         * WebCoreSupport/WebFrameLoaderClient.h:
860         * WebCoreSupport/WebFrameLoaderClient.mm:
861         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
862
863 2019-01-28  Devin Rousso  <drousso@apple.com>
864
865         Web Inspector: provide a way to edit page WebRTC settings on a remote target
866         https://bugs.webkit.org/show_bug.cgi?id=193863
867         <rdar://problem/47572764>
868
869         Reviewed by Joseph Pecoraro.
870
871         * WebView/WebView.mm:
872         (-[WebView _preferencesChanged:]):
873         Add page-level settings for WebRTC preferences.
874
875 2019-01-28  Andy Estes  <aestes@apple.com>
876
877         [watchOS] Enable Parental Controls content filtering
878         https://bugs.webkit.org/show_bug.cgi?id=193939
879         <rdar://problem/46641912>
880
881         Reviewed by Ryosuke Niwa.
882
883         * Configurations/FeatureDefines.xcconfig:
884
885 2019-01-28  Timothy Hatcher  <timothy@apple.com>
886
887         Make it easier for non-Apple ports to enable dark mode CSS support.
888         https://bugs.webkit.org/show_bug.cgi?id=193882
889
890         Reviewed by Megan Gardner.
891
892         * WebView/WebView.mm:
893         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
894         (-[WebView _effectiveAppearanceIsDark]): Ditto.
895
896 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
897
898         AX: Introduce a static accessibility tree
899         https://bugs.webkit.org/show_bug.cgi?id=193348
900         <rdar://problem/47203295>
901
902         Reviewed by Ryosuke Niwa.
903
904         * Configurations/FeatureDefines.xcconfig:
905
906 2019-01-25  Keith Rollin  <krollin@apple.com>
907
908         Update WebKitAdditions.xcconfig with correct order of variable definitions
909         https://bugs.webkit.org/show_bug.cgi?id=193793
910         <rdar://problem/47532439>
911
912         Reviewed by Alex Christensen.
913
914         XCBuild changes the way xcconfig variables are evaluated. In short,
915         all config file assignments are now considered in part of the
916         evaluation. When using the new build system and an .xcconfig file
917         contains multiple assignments of the same build setting:
918
919         - Later assignments using $(inherited) will inherit from earlier
920           assignments in the xcconfig file.
921         - Later assignments not using $(inherited) will take precedence over
922           earlier assignments. An assignment to a more general setting will
923           mask an earlier assignment to a less general setting. For example,
924           an assignment without a condition ('FOO = bar') will completely mask
925           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
926
927         This affects some of our .xcconfig files, in that sometimes platform-
928         or sdk-specific definitions appear before the general definitions.
929         Under the new evaluations rules, the general definitions alway take
930         effect because they always overwrite the more-specific definitions. The
931         solution is to swap the order, so that the general definitions are
932         established first, and then conditionally overwritten by the
933         more-specific definitions.
934
935         * Configurations/Version.xcconfig:
936         * Configurations/WebKitLegacy.xcconfig:
937
938 2019-01-25  David Kilzer  <ddkilzer@apple.com>
939
940         Move soft-linking of Lookup.framework out of LookupSPI.h
941         <https://webkit.org/b/193815>
942
943         Reviewed by Tim Horton.
944
945         * WebView/WebImmediateActionController.mm:
946         (-[WebImmediateActionController _animationControllerForText]):
947         * WebView/WebView.mm:
948         (-[WebView _prepareForDictionaryLookup]):
949         - Move soft-linking to LookupSoftLink.{h,mm}.
950
951 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
952
953         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
954         https://bugs.webkit.org/show_bug.cgi?id=193829
955
956         Reviewed by Tim Horton.
957
958         * WebCoreSupport/WebDragClient.mm:
959         (WebDragClient::didConcludeEditDrag):
960         * WebView/WebView.mm:
961         (-[WebView _requestStartDataInteraction:globalPosition:]):
962         (-[WebView _didConcludeEditDrag]):
963         (-[WebView _didConcludeEditDataInteraction]): Deleted.
964         * WebView/WebViewInternal.h:
965
966 2019-01-24  John Wilander  <wilander@apple.com>
967
968         Add Ad Click Attribution as an internal/experimental feature
969         https://bugs.webkit.org/show_bug.cgi?id=193685
970         <rdar://problem/47450399>
971
972         Reviewed by Brent Fulgham.
973
974         * WebView/WebPreferenceKeysPrivate.h:
975         * WebView/WebPreferences.mm:
976         (+[WebPreferences initialize]):
977         (-[WebPreferences adClickAttributionEnabled]):
978         (-[WebPreferences setAdClickAttributionEnabled:]):
979             Added support for experimental ad click attribution.
980         * WebView/WebPreferencesPrivate.h:
981         * WebView/WebView.mm:
982         (-[WebView _preferencesChanged:]):
983
984 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
985
986         Move FileSystem to WTF
987         https://bugs.webkit.org/show_bug.cgi?id=193602
988
989         Reviewed by Yusuke Suzuki.
990
991         * Misc/WebNSFileManagerExtras.mm:
992         * Storage/WebDatabaseProvider.mm:
993         * WebView/WebView.mm:
994
995 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
996
997         Fix the Apple Internal build. See <rdar://problem/47491383>.
998
999         Rubber-stamped by Tim Horton.
1000
1001         * WebCoreSupport/WebFrameLoaderClient.mm:
1002
1003 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
1004
1005         Clean up USE(WEB_THREAD)
1006         https://bugs.webkit.org/show_bug.cgi?id=193698
1007
1008         Rubber-stamped by Tim Horton.
1009
1010         * Misc/WebCache.mm:
1011         (+[WebCache emptyInMemoryResources]):
1012         * WebCoreSupport/WebFrameLoaderClient.mm:
1013         (-[WebFramePolicyListener use]):
1014         * WebCoreSupport/WebGeolocationClient.mm:
1015         (-[WebGeolocationPolicyListener allow]):
1016         (-[WebGeolocationPolicyListener deny]):
1017         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
1018         * WebView/WebFrame.mm:
1019         (-[WebFrame deviceOrientationChanged]):
1020         * WebView/WebHTMLView.mm:
1021         (hardwareKeyboardAvailabilityChangedCallback):
1022         * WebView/WebView.mm:
1023         (+[WebView _releaseMemoryNow]):
1024         (+[WebView willEnterBackgroundWithCompletionHandler:]):
1025         (-[WebView updateLayoutIgnorePendingStyleSheets]):
1026         (-[WebView _dispatchUnloadEvent]):
1027         (-[WebView _close]):
1028         (-[WebView _preferencesChangedNotification:]):
1029         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1030         (-[WebView goBack]):
1031         (-[WebView goForward]):
1032         (+[WebView _cacheModelChangedNotification:]):
1033         (-[WebView stopLoading:]):
1034         (-[WebView stopLoadingAndClear]):
1035         (-[WebView reload:]):
1036         (WebInstallMemoryPressureHandler):
1037
1038 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1039
1040         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
1041         https://bugs.webkit.org/show_bug.cgi?id=193706
1042         <rdar://problem/44807048>
1043
1044         Reviewed by Ryosuke Niwa.
1045
1046         Use UndoStep::label().
1047
1048         * WebCoreSupport/WebEditorClient.h:
1049         * WebCoreSupport/WebEditorClient.mm:
1050         (-[WebUndoStep initWithUndoStep:]):
1051         (+[WebUndoStep stepWithUndoStep:]):
1052         (WebEditorClient::registerUndoOrRedoStep):
1053         (WebEditorClient::registerUndoStep):
1054         (WebEditorClient::registerRedoStep):
1055
1056 2019-01-22  Alex Christensen  <achristensen@webkit.org>
1057
1058         Move NetworkStorageSession ownership to NetworkProcess
1059         https://bugs.webkit.org/show_bug.cgi?id=193580
1060
1061         Reviewed by Geoff Garen.
1062
1063         * Misc/WebCache.mm:
1064         (+[WebCache clearCachedCredentials]):
1065         * Misc/WebDownload.mm:
1066         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1067         * Plugins/WebBaseNetscapePluginView.mm:
1068         (WebKit::getAuthenticationInfo):
1069         * WebCoreSupport/WebFrameNetworkingContext.mm:
1070         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1071         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1072         (WebFrameNetworkingContext::storageSession const):
1073         * WebView/WebPreferences.mm:
1074         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1075         (+[WebPreferences _clearNetworkLoaderSession]):
1076         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1077
1078 2019-01-22  Daniel Bates  <dabates@apple.com>
1079
1080         [iOS] Interpret text key commands on keydown and app key commands on keypress
1081         https://bugs.webkit.org/show_bug.cgi?id=192897
1082         <rdar://problem/46857378>
1083
1084         Reviewed by Brent Fulgham.
1085
1086         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
1087         is false) and keypress (isCharEvent is true), respectively.
1088
1089         * WebView/WebHTMLView.mm:
1090         (-[WebHTMLView _handleEditingKeyEvent:]):
1091
1092 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1093
1094         [css-logical] Implement flow-relative margin, padding and border shorthands
1095         https://bugs.webkit.org/show_bug.cgi?id=188697
1096
1097         Reviewed by Simon Fraser and Antti Koivisto.
1098
1099         Add CSSLogicalEnabled runtime flag.
1100
1101         * WebView/WebPreferenceKeysPrivate.h:
1102         * WebView/WebPreferences.mm:
1103         (+[WebPreferences initialize]):
1104         (-[WebPreferences cssLogicalEnabled]):
1105         (-[WebPreferences setCSSLogicalEnabled:]):
1106         * WebView/WebPreferencesPrivate.h:
1107         * WebView/WebView.mm:
1108         (-[WebView _preferencesChanged:]):
1109
1110 2019-01-15  Darin Adler  <darin@apple.com>
1111
1112         Use references rather than pointers for register/unregister functions, and more
1113         https://bugs.webkit.org/show_bug.cgi?id=175028
1114
1115         Reviewed by Daniel Bates.
1116
1117         * WebCoreSupport/WebKitFullScreenListener.mm:
1118         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1119         functions in Document; pass a reference.
1120         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1121         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1122         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1123         * WebView/WebFullScreenController.mm:
1124         (-[WebFullScreenController enterFullScreen:]): Ditto.
1125         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1126         (-[WebFullScreenController exitFullScreen]): Ditto.
1127         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1128         * WebView/WebFullScreenController.mm:
1129         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1130
1131 2019-01-12  Dan Bernstein  <mitz@apple.com>
1132
1133         [Cocoa] Avoid importing directly from subumbrella frameworks
1134         https://bugs.webkit.org/show_bug.cgi?id=186016
1135         <rdar://problem/40591038>
1136
1137         Reviewed by Sam Weinig.
1138
1139         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1140         * Carbon/CarbonWindowAdapter.mm: Ditto.
1141         * Carbon/CarbonWindowFrame.m: Ditto.
1142         * Carbon/HIViewAdapter.h: Ditto.
1143         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1144           OTHER_CFLAGS_COCOA_TOUCH_NO.
1145         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1146         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1147         * WebView/WebPDFView.h: Ditto.
1148
1149 2019-01-20  Antoine Quint  <graouts@apple.com>
1150
1151         Add a POINTER_EVENTS feature flag
1152         https://bugs.webkit.org/show_bug.cgi?id=193577
1153         <rdar://problem/47408511>
1154
1155         Unreviewed. Also enable Pointer Events for iosmac.
1156
1157         * Configurations/FeatureDefines.xcconfig:
1158
1159 2019-01-19  Antoine Quint  <graouts@apple.com>
1160
1161         Add a POINTER_EVENTS feature flag
1162         https://bugs.webkit.org/show_bug.cgi?id=193577
1163
1164         Reviewed by Dean Jackson.
1165
1166         * Configurations/FeatureDefines.xcconfig:
1167
1168 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1169
1170         Revert r238815, it broke WK1 video fullscreen on Mac
1171         https://bugs.webkit.org/show_bug.cgi?id=193586
1172         <rdar://problem/47358941>
1173
1174         Reviewed by Jer Noble.
1175
1176         * WebView/WebVideoFullscreenController.h: Added.
1177         * WebView/WebVideoFullscreenController.mm: Added.
1178         (SOFT_LINK_CLASS):
1179         (-[WebVideoFullscreenController init]):
1180         (-[WebVideoFullscreenController dealloc]):
1181         (-[WebVideoFullscreenController fullscreenWindow]):
1182         (-[WebVideoFullscreenController windowDidLoad]):
1183         (-[WebVideoFullscreenController videoElement]):
1184         (-[WebVideoFullscreenController setVideoElement:]):
1185         (-[WebVideoFullscreenController clearFadeAnimation]):
1186         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1187         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1188         (-[WebVideoFullscreenController videoElementRect]):
1189         (-[WebVideoFullscreenController applicationDidResignActive:]):
1190         (frameExpandedToRatioOfFrame):
1191         (createBackgroundFullscreenWindow):
1192         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1193         (-[WebVideoFullscreenController enterFullscreen:]):
1194         (-[WebVideoFullscreenController exitFullscreen]):
1195         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1196         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1197         (-[WebVideoFullscreenController _requestExit]):
1198         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1199         (-[WebVideoFullscreenController requestExitFullscreen]):
1200         (-[WebVideoFullscreenController fadeHUDIn]):
1201         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1202         (-[WebVideoFullscreenController rateChanged:]):
1203         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1204         (-[WebVideoFullscreenWindow dealloc]):
1205         (-[WebVideoFullscreenWindow resignFirstResponder]):
1206         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1207         (-[WebVideoFullscreenWindow mouseDown:]):
1208         (-[WebVideoFullscreenWindow cancelOperation:]):
1209         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1210         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1211         (-[WebVideoFullscreenWindow animationDidEnd:]):
1212         (-[WebVideoFullscreenWindow mouseMoved:]):
1213         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1214         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1215         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1216         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1217         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1218         (-[WebVideoFullscreenHUDWindow center]):
1219         (-[WebVideoFullscreenHUDWindow keyDown:]):
1220         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1221         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1222         (-[WebVideoFullscreenHUDWindowController init]):
1223         (-[WebVideoFullscreenHUDWindowController dealloc]):
1224         (-[WebVideoFullscreenHUDWindowController setArea:]):
1225         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1226         (-[WebVideoFullscreenHUDWindowController delegate]):
1227         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1228         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1229         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1230         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1231         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1232         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1233         (createMediaUIControl):
1234         (createControlWithMediaUIControlType):
1235         (createTimeTextField):
1236         (createMediaUIBackgroundView):
1237         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1238         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1239         (-[WebVideoFullscreenHUDWindowController updateTime]):
1240         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1241         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1242         (-[WebVideoFullscreenHUDWindowController currentTime]):
1243         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1244         (-[WebVideoFullscreenHUDWindowController duration]):
1245         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1246         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1247         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1248         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1249         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1250         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1251         (-[WebVideoFullscreenHUDWindowController volume]):
1252         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1253         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1254         (-[WebVideoFullscreenHUDWindowController updateRate]):
1255         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1256         (-[WebVideoFullscreenHUDWindowController playing]):
1257         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1258         (timeToString):
1259         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1260         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1261         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1262         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1263         (-[WebVideoFullscreenHUDWindowController rewind:]):
1264         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1265         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1266         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1267         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1268         * WebView/WebView.mm:
1269         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1270         (-[WebView _exitVideoFullscreen]):
1271
1272 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1273
1274         Get rid of ADVANCED_SPELL_CHECKING
1275         https://bugs.webkit.org/show_bug.cgi?id=193592
1276
1277         Reviewed by Wenson Hsieh.
1278
1279         * WebCoreSupport/WebEditorClient.mm:
1280         (insertionPointFromCurrentSelection):
1281         (WebEditorClient::checkTextOfParagraph):
1282         (WebEditorClient::getGuessesForWord):
1283         (WebEditorClient::requestCandidatesForSelection):
1284         (WebEditorClient::requestCheckingOfString):
1285         * WebView/WebHTMLView.mm:
1286         (-[WebHTMLView insertText:]):
1287
1288 2019-01-18  Jer Noble  <jer.noble@apple.com>
1289
1290         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1291         https://bugs.webkit.org/show_bug.cgi?id=189553
1292
1293         Reviewed by Tim Horton.
1294
1295         * Configurations/Base.xcconfig:
1296         * Configurations/SDKVariant.xcconfig: Added.
1297         * Configurations/WebKitLegacy.xcconfig:
1298
1299 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1300
1301         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1302         <https://webkit.org/b/193568>
1303         <rdar://problem/47381130>
1304
1305         Reviewed by Alex Christensen.
1306
1307         * WebView/WebView.mm:
1308         - Remove unused soft-linking macros.
1309         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1310         (-[WebUITextIndicatorData initWithImage:scale:]):
1311         - Update to use exported PAL functions.
1312
1313 2019-01-17  Truitt Savell  <tsavell@apple.com>
1314
1315         Unreviewed, rolling out r240124.
1316
1317         This commit broke an internal build.
1318
1319         Reverted changeset:
1320
1321         "SDK_VARIANT build destinations should be separate from non-
1322         SDK_VARIANT builds"
1323         https://bugs.webkit.org/show_bug.cgi?id=189553
1324         https://trac.webkit.org/changeset/240124
1325
1326 2019-01-17  Jer Noble  <jer.noble@apple.com>
1327
1328         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1329         https://bugs.webkit.org/show_bug.cgi?id=189553
1330
1331         Reviewed by Tim Horton.
1332
1333         * Configurations/Base.xcconfig:
1334         * Configurations/SDKVariant.xcconfig: Added.
1335         * Configurations/WebKitLegacy.xcconfig:
1336
1337 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1338
1339         Stop using NetworkStorageSession::storageSession in WebCore
1340         https://bugs.webkit.org/show_bug.cgi?id=193529
1341
1342         Reviewed by Tim Horton.
1343
1344         * Misc/WebCache.mm:
1345         (+[WebCache addImageToCache:forURL:forFrame:]):
1346         * WebView/WebView.mm:
1347         (-[WebView _commonInitializationWithFrameName:groupName:]):
1348         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1349
1350 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1351
1352         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1353         https://bugs.webkit.org/show_bug.cgi?id=193368
1354
1355         Reviewed by Geoff Garen.
1356
1357         * Misc/WebCache.mm:
1358         (+[WebCache clearCachedCredentials]):
1359         * Misc/WebDownload.mm:
1360         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1361         * Plugins/WebBaseNetscapePluginView.mm:
1362         (WebKit::getAuthenticationInfo):
1363
1364 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1365
1366         Stop using CookiesStrategy
1367         https://bugs.webkit.org/show_bug.cgi?id=161106
1368
1369         Reviewed by Don Olmstead and Antti Koivisto.
1370
1371         * Misc/WebCache.mm:
1372         (+[WebCache addImageToCache:forURL:forFrame:]):
1373         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1374         (WebKit::NetscapePluginInstanceProxy::getCookies):
1375         (WebKit::NetscapePluginInstanceProxy::setCookies):
1376         * Plugins/WebNetscapePluginView.mm:
1377         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1378         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1379         * WebCoreSupport/WebPlatformStrategies.h:
1380         * WebCoreSupport/WebPlatformStrategies.mm:
1381         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1382         (WebPlatformStrategies::cookiesForDOM): Deleted.
1383         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1384         (WebPlatformStrategies::cookiesEnabled): Deleted.
1385         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1386         (WebPlatformStrategies::getRawCookies): Deleted.
1387         (WebPlatformStrategies::deleteCookie): Deleted.
1388         * WebView/WebView.mm:
1389         (-[WebView _commonInitializationWithFrameName:groupName:]):
1390         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1391
1392 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1393
1394         Cannot tab out of WKWebView on macOS
1395         https://bugs.webkit.org/show_bug.cgi?id=161448
1396         <rdar://problem/28100085>
1397
1398         Reviewed by Dean Jackson.
1399
1400         * WebCoreSupport/WebChromeClient.mm:
1401         * WebView/WebView.mm:
1402         Make use of SPI headers.
1403
1404 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1405
1406         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1407         r239913, and r239914.
1408         https://bugs.webkit.org/show_bug.cgi?id=193407
1409
1410         These revisions caused an internal failure (Requested by
1411         Truitt on #webkit).
1412
1413         Reverted changesets:
1414
1415         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1416         https://bugs.webkit.org/show_bug.cgi?id=186016
1417         https://trac.webkit.org/changeset/239901
1418
1419         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1420         https://trac.webkit.org/changeset/239909
1421
1422         "Tried to fix the build."
1423         https://trac.webkit.org/changeset/239910
1424
1425         "Fixed iOS builds after r239910."
1426         https://trac.webkit.org/changeset/239912
1427
1428         "More build fixing."
1429         https://trac.webkit.org/changeset/239913
1430
1431         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1432         https://trac.webkit.org/changeset/239914
1433
1434 2019-01-14  Mark Lam  <mark.lam@apple.com>
1435
1436         Re-enable ability to build --cloop builds.
1437         https://bugs.webkit.org/show_bug.cgi?id=192955
1438         <rdar://problem/46882363>
1439
1440         Reviewed by Saam barati and Keith Miller.
1441
1442         * Configurations/FeatureDefines.xcconfig:
1443
1444 2019-01-13  Dan Bernstein  <mitz@apple.com>
1445
1446         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1447
1448         Patch by Keith Rollin.
1449
1450         * WebView/PDFViewSPI.h:
1451
1452 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1453
1454         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1455         https://bugs.webkit.org/show_bug.cgi?id=191655
1456         rdar://problem/46074680
1457
1458         Reviewed by Megan Gardner.
1459
1460         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1461         * WebView/WebView.mm:
1462         (-[WebView _effectiveAppearanceIsDark]):
1463
1464 2019-01-12  Dan Bernstein  <mitz@apple.com>
1465
1466         [Cocoa] Avoid importing directly from subumbrella frameworks
1467         https://bugs.webkit.org/show_bug.cgi?id=186016
1468         <rdar://problem/40591038>
1469
1470         Reviewed by Sam Weinig.
1471
1472         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1473         * Carbon/CarbonWindowAdapter.mm: Ditto.
1474         * Carbon/CarbonWindowFrame.m: Ditto.
1475         * Carbon/HIViewAdapter.h: Ditto.
1476         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1477           OTHER_CFLAGS_COCOA_TOUCH_NO.
1478         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1479         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1480         * WebView/WebPDFView.h: Ditto.
1481
1482 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1483
1484         Enable visual viewport API by default
1485         https://bugs.webkit.org/show_bug.cgi?id=193376
1486
1487         Reviewed by Simon Fraser.
1488
1489         * WebView/WebPreferences.mm:
1490         (+[WebPreferences initialize]):
1491
1492 2019-01-11  John Wilander  <wilander@apple.com>
1493
1494         Compile out Web API Statistics Collection
1495         https://bugs.webkit.org/show_bug.cgi?id=193370
1496         <rdar://problem/45388584>
1497
1498         Reviewed by Brent Fulgham.
1499
1500         * Configurations/FeatureDefines.xcconfig:
1501             Defined ENABLE_WEB_API_STATISTICS, off by default.
1502
1503 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1504
1505         Stop using NetworkStorageSession in WebProcess
1506         https://bugs.webkit.org/show_bug.cgi?id=193236
1507
1508         Reviewed by Don Olmstead.
1509
1510         * WebCoreSupport/WebFrameNetworkingContext.h:
1511         * WebCoreSupport/WebFrameNetworkingContext.mm:
1512         (WebFrameNetworkingContext::storageSession const):
1513         * WebCoreSupport/WebPlatformStrategies.h:
1514         * WebCoreSupport/WebPlatformStrategies.mm:
1515         (WebPlatformStrategies::cookiesForDOM):
1516         (WebPlatformStrategies::setCookiesFromDOM):
1517         (WebPlatformStrategies::cookiesEnabled):
1518         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1519         (WebPlatformStrategies::getRawCookies):
1520         (WebPlatformStrategies::deleteCookie):
1521         * WebView/WebView.mm:
1522         (-[WebView _cachedResponseForURL:]):
1523         (-[WebView _clearCredentials]):
1524
1525 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1526
1527         Unreviewed, rolling out r239727.
1528
1529         Broke API tests
1530
1531         Reverted changeset:
1532
1533         "Stop using NetworkStorageSession in WebProcess"
1534         https://bugs.webkit.org/show_bug.cgi?id=193236
1535         https://trac.webkit.org/changeset/239727
1536
1537 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1538
1539         Stop using NetworkStorageSession in WebProcess
1540         https://bugs.webkit.org/show_bug.cgi?id=193236
1541
1542         Reviewed by Don Olmstead.
1543
1544         * WebCoreSupport/WebFrameNetworkingContext.h:
1545         * WebCoreSupport/WebFrameNetworkingContext.mm:
1546         (WebFrameNetworkingContext::storageSession const):
1547         * WebView/WebView.mm:
1548         (-[WebView _cachedResponseForURL:]):
1549         (-[WebView _clearCredentials]):
1550
1551 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1552
1553         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1554         <https://webkit.org/b/193056>
1555
1556         Reviewed by Alex Christensen.
1557
1558         * Plugins/Hosted/NetscapePluginHostProxy.h:
1559         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1560         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1561         (WebKit::NetscapePluginInstanceProxy::enumerate):
1562         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1563         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1564         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1565         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1566         * Plugins/Hosted/ProxyInstance.mm:
1567         (WebKit::ProxyInstance::invoke):
1568         * WebCoreSupport/WebGeolocationClient.mm:
1569         * WebView/WebDataSource.mm:
1570         (-[WebDataSource _receivedData:]):
1571         * WebView/WebView.mm:
1572         (-[WebView _cachedResponseForURL:]):
1573         - Remove '*' from RetainPtr<> type.
1574
1575 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1576
1577         Progress towards fixing Mac CMake build
1578         https://bugs.webkit.org/show_bug.cgi?id=193105
1579
1580         Reviewed by Don Olmstead.
1581
1582         * WebKitPrefix.h:
1583
1584 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1585
1586         Web Inspector: Use save sheet instead of dialog where possible
1587         https://bugs.webkit.org/show_bug.cgi?id=193160
1588         <rdar://problem/37399759>
1589
1590         Reviewed by Devin Rousso.
1591
1592         * WebCoreSupport/WebInspectorClient.mm:
1593         (WebInspectorFrontendClient::save):
1594
1595 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1596
1597         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1598         https://bugs.webkit.org/show_bug.cgi?id=193129
1599
1600         Reviewed by Tim Horton.
1601
1602         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1603
1604         * WebCoreSupport/WebEditorClient.mm:
1605         (WebEditorClient::registerUndoOrRedoStep):
1606         (undoNameForEditAction): Deleted.
1607
1608 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1609
1610         Add support for using the current text selection as the find string on iOS
1611         https://bugs.webkit.org/show_bug.cgi?id=193034
1612         <rdar://problem/45138739>
1613
1614         Reviewed by Tim Horton.
1615
1616         Add a method stub for WebKitLegacy.
1617
1618         * WebCoreSupport/WebEditorClient.h:
1619
1620 2019-01-01  Jeff Miller  <jeffm@apple.com>
1621
1622         Update user-visible copyright strings to include 2019
1623         https://bugs.webkit.org/show_bug.cgi?id=192811
1624
1625         Reviewed by Mark Lam.
1626
1627         * Info.plist:
1628
1629 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1630
1631         Use Ref<> as much as possible
1632         https://bugs.webkit.org/show_bug.cgi?id=192808
1633
1634         Reviewed by Alex Christensen.
1635
1636         * DOM/DOM.mm:
1637         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1638         * Plugins/Hosted/NetscapePluginHostManager.mm:
1639         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1640         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1641         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1642         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1643         * Plugins/WebNetscapePluginView.mm:
1644         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1645         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1646         * WebCoreSupport/WebContextMenuClient.mm:
1647         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1648         * WebCoreSupport/WebFrameLoaderClient.mm:
1649         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1650         * WebView/WebFrame.mm:
1651         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1652         * WebView/WebHTMLView.mm:
1653         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1654         * WebView/WebView.mm:
1655         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1656         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1657
1658 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1659
1660         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1661         https://bugs.webkit.org/show_bug.cgi?id=192821
1662
1663         Reviewed by Chris Dumez.
1664
1665         When a window becomes occluded, the window server informs the application.
1666         This should be used to suspend any work that is not visible by the user.
1667
1668         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1669         In some cases, that lead to performance impact (see radar).
1670
1671         This patch adds an observer for the occlusion notification. I tried to stick
1672         with the same names used by WebKit2.
1673
1674         * WebView/WebView.mm:
1675         (-[WebView _isViewVisible]):
1676         (-[WebView addWindowObserversForWindow:]):
1677         (-[WebView removeWindowObservers]):
1678         (-[WebView _windowDidChangeOcclusionState:]):
1679
1680 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1681
1682         [WebAuthN] Add a runtime flag for local authenticator
1683         https://bugs.webkit.org/show_bug.cgi?id=192792
1684         <rdar://problem/46798738>
1685
1686         Reviewed by Brent Fulgham.
1687
1688         * WebView/WebPreferenceKeysPrivate.h:
1689         * WebView/WebPreferences.mm:
1690         (+[WebPreferences initialize]):
1691         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1692         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1693         * WebView/WebPreferencesPrivate.h:
1694         * WebView/WebView.mm:
1695         (-[WebView _preferencesChanged:]):
1696
1697 2018-12-20  Chris Dumez  <cdumez@apple.com>
1698
1699         Use Optional::valueOr() instead of Optional::value_or()
1700         https://bugs.webkit.org/show_bug.cgi?id=192933
1701
1702         Reviewed by Geoffrey Garen.
1703
1704         * WebCoreSupport/WebSecurityOrigin.mm:
1705         (-[WebSecurityOrigin port]):
1706
1707 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1708
1709         Unreviewed, rolling out r239417.
1710
1711         Introduced two API test failures on macOS.
1712
1713         Reverted changeset:
1714
1715         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1716         occlusion changes"
1717         https://bugs.webkit.org/show_bug.cgi?id=192821
1718         https://trac.webkit.org/changeset/239417
1719
1720 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1721
1722         WKWebView default UA doesn't freeze the build number
1723         https://bugs.webkit.org/show_bug.cgi?id=192809
1724         <rdar://problem/44687185>
1725
1726         Reviewed by Andy Estes.
1727
1728         Always reports the frozen build number.
1729
1730         * WebView/WebView.mm:
1731         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1732         actual build number through this method call.
1733         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1734
1735 2018-12-19  Chris Dumez  <cdumez@apple.com>
1736
1737         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1738         https://bugs.webkit.org/show_bug.cgi?id=192728
1739         <rdar://problem/46746779>
1740
1741         Reviewed by Geoff Garen.
1742
1743         * DOM/*:
1744         * Plugins/*:
1745         * WebCoreSupport/*:
1746         * WebView/*:
1747
1748 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1749
1750         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1751         https://bugs.webkit.org/show_bug.cgi?id=192821
1752
1753         Reviewed by Chris Dumez.
1754
1755         When a window becomes occluded, the window server informs the application.
1756         This should be used to suspend any work that is not visible by the user.
1757
1758         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1759         In some cases, that lead to performance impact (see radar).
1760
1761         This patch adds an observer for the occlusion notification. I tried to stick
1762         with the same names used by WebKit2.
1763
1764         * WebView/WebView.mm:
1765         (-[WebView _isViewVisible]):
1766         (-[WebView addWindowObserversForWindow:]):
1767         (-[WebView removeWindowObservers]):
1768         (-[WebView _windowDidChangeOcclusionState:]):
1769
1770 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1771
1772         Allow clients to set the navigator platform
1773         https://bugs.webkit.org/show_bug.cgi?id=192735
1774
1775         Reviewed by Tim Horton.
1776
1777         Add stubs to fill out the added functionality in FrameLoaderClient.
1778
1779         * WebCoreSupport/WebFrameLoaderClient.h:
1780         * WebCoreSupport/WebFrameLoaderClient.mm:
1781         (WebFrameLoaderClient::navigatorPlatform):
1782
1783 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1784
1785         offsetLeft and offsetParent should adjust across shadow boundaries
1786         https://bugs.webkit.org/show_bug.cgi?id=157437
1787         <rdar://problem/26154021>
1788
1789         Reviewed by Simon Fraser.
1790
1791         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1792
1793         * DOM/DOMElement.mm:
1794         (-[DOMElement offsetLeft]):
1795         (-[DOMElement offsetTop]):
1796         (-[DOMElement offsetParent]):
1797
1798 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1799
1800         Unreviewed build fix.
1801
1802         * WebView/WebFrame.mm:
1803         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1804
1805 2018-12-15  Darin Adler  <darin@apple.com>
1806
1807         Use warning-ignoring macros more consistently and simply
1808         https://bugs.webkit.org/show_bug.cgi?id=192743
1809
1810         Reviewed by Mark Lam.
1811
1812         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1813         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1814         compilers in Objective-C++ code.
1815
1816         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1817         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1818         accomodate non-clang compilers here. Also use #pragma once, add a missing
1819         "explicit" and fix conditionals.
1820
1821 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1822
1823         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1824         https://bugs.webkit.org/show_bug.cgi?id=192653
1825
1826         Reviewed by Wenson Hsieh.
1827
1828         * WebView/WebHTMLView.mm:
1829         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1830
1831 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1832
1833         Implement feature flag for CSS Typed OM
1834         https://bugs.webkit.org/show_bug.cgi?id=192610
1835
1836         Reviewed by Ryosuke Niwa.
1837
1838         * Configurations/FeatureDefines.xcconfig:
1839
1840 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1841
1842         WebCore shouldn't have a Objective-C class named NSCursor
1843         https://bugs.webkit.org/show_bug.cgi?id=192602
1844         <rdar://problem/46615532>
1845
1846         Reviewed by Wenson Hsieh.
1847
1848         * WebView/WebFrameView.mm:
1849         (-[WebFrameView keyDown:keyDown:]):
1850         * WebView/WebHTMLView.mm:
1851         (-[WebHTMLView keyDown:]):
1852         (-[WebHTMLView performKeyEquivalent:]):
1853         Only use NSCursor on macOS.
1854
1855 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1856
1857         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1858         https://bugs.webkit.org/show_bug.cgi?id=192573
1859
1860         Reviewed by Simon Fraser.
1861
1862         * Configurations/FeatureDefines.xcconfig:
1863
1864 2018-12-10  Antti Koivisto  <antti@apple.com>
1865
1866         Rename "forced style recalc" to "full style rebuild"
1867         https://bugs.webkit.org/show_bug.cgi?id=192572
1868
1869         Reviewed by Zalan Bujtas.
1870
1871         * WebView/WebHTMLView.mm:
1872         (-[WebHTMLView setNeedsToApplyStyles:]):
1873
1874 2018-12-10  Darin Adler  <darin@apple.com>
1875
1876         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1877         https://bugs.webkit.org/show_bug.cgi?id=192533
1878         rdar://problem/45732710
1879
1880         Reviewed by Anders Carlsson.
1881
1882         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1883         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1884
1885 2018-12-10  Darin Adler  <darin@apple.com>
1886
1887         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1888         https://bugs.webkit.org/show_bug.cgi?id=192532
1889         rdar://problem/45731047
1890
1891         Reviewed by Chris Dumez.
1892
1893         * Plugins/Hosted/NetscapePluginHostManager.mm:
1894         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1895         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1896         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1897
1898 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1899
1900         Turn WritingDirection into an enum class
1901         https://bugs.webkit.org/show_bug.cgi?id=192401
1902         Work towards <rdar://problem/42075638>
1903
1904         Reviewed by Dan Bernstein.
1905
1906         Change WritingDirection from an enum to an enum class. No change in behavior.
1907
1908         * WebView/WebHTMLView.mm:
1909         (-[WebHTMLView toggleBaseWritingDirection:]):
1910         (-[WebHTMLView changeBaseWritingDirection:]):
1911         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1912
1913 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1914
1915         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1916         https://bugs.webkit.org/show_bug.cgi?id=192272
1917
1918         Reviewed by Brady Eidson.
1919
1920         * WebCoreSupport/WebFrameLoaderClient.h:
1921         * WebCoreSupport/WebFrameLoaderClient.mm:
1922         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1923
1924 2018-12-03  Jer Noble  <jer.noble@apple.com>
1925
1926         Get rid of old, dead Mac video fullscreen code.
1927         https://bugs.webkit.org/show_bug.cgi?id=192315
1928
1929         Reviewed by Eric Carlson.
1930
1931         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1932         is no longer supported in the Mac port.
1933
1934         * WebView/WebVideoFullscreenController.h: Removed.
1935         * WebView/WebVideoFullscreenController.mm: Removed.
1936         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1937         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1938         * WebView/WebView.mm:
1939         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1940         (-[WebView _exitVideoFullscreen]):
1941
1942 2018-12-03  Daniel Bates  <dabates@apple.com>
1943
1944         [iOS] Do not handle key events that are key commands
1945         https://bugs.webkit.org/show_bug.cgi?id=191608
1946         <rdar://problem/46046013>
1947
1948         Reviewed by Ryosuke Niwa.
1949
1950         A key down event may be associated with a key command. If it is then we want to execute the
1951         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1952         event as a key command to find out.
1953
1954         * WebView/WebHTMLView.mm:
1955         (-[WebHTMLView _handleEditingKeyEvent:]):
1956
1957 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1958
1959         Add a runtime feature flag for LayoutFormattingContext.
1960         https://bugs.webkit.org/show_bug.cgi?id=192280
1961
1962         Reviewed by Simon Fraser.
1963
1964         * Configurations/FeatureDefines.xcconfig:
1965
1966 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1967
1968         Move URL from WebCore to WTF
1969         https://bugs.webkit.org/show_bug.cgi?id=190234
1970
1971         Reviewed by Keith Miller.
1972
1973         * DOM/DOMAttr.mm:
1974         * DOM/DOMBlob.mm:
1975         * DOM/DOMCSSCharsetRule.mm:
1976         * DOM/DOMCSSImportRule.mm:
1977         * DOM/DOMCSSMediaRule.mm:
1978         * DOM/DOMCSSPageRule.mm:
1979         * DOM/DOMCSSPrimitiveValue.mm:
1980         * DOM/DOMCSSRule.mm:
1981         * DOM/DOMCSSStyleDeclaration.mm:
1982         * DOM/DOMCSSStyleRule.mm:
1983         * DOM/DOMCSSStyleSheet.mm:
1984         * DOM/DOMCSSValue.mm:
1985         * DOM/DOMCharacterData.mm:
1986         * DOM/DOMCounter.mm:
1987         * DOM/DOMDocument.mm:
1988         * DOM/DOMDocumentFragment.mm:
1989         * DOM/DOMDocumentType.mm:
1990         * DOM/DOMEvent.mm:
1991         * DOM/DOMFile.mm:
1992         * DOM/DOMHTMLAnchorElement.mm:
1993         * DOM/DOMHTMLAppletElement.mm:
1994         * DOM/DOMHTMLAreaElement.mm:
1995         * DOM/DOMHTMLBRElement.mm:
1996         * DOM/DOMHTMLBaseElement.mm:
1997         * DOM/DOMHTMLBaseFontElement.mm:
1998         * DOM/DOMHTMLBodyElement.mm:
1999         * DOM/DOMHTMLButtonElement.mm:
2000         * DOM/DOMHTMLCanvasElement.mm:
2001         * DOM/DOMHTMLCollection.mm:
2002         * DOM/DOMHTMLDivElement.mm:
2003         * DOM/DOMHTMLDocument.mm:
2004         * DOM/DOMHTMLElement.mm:
2005         * DOM/DOMHTMLEmbedElement.mm:
2006         * DOM/DOMHTMLFieldSetElement.mm:
2007         * DOM/DOMHTMLFontElement.mm:
2008         * DOM/DOMHTMLFormElement.mm:
2009         * DOM/DOMHTMLFrameElement.mm:
2010         * DOM/DOMHTMLFrameSetElement.mm:
2011         * DOM/DOMHTMLHRElement.mm:
2012         * DOM/DOMHTMLHeadElement.mm:
2013         * DOM/DOMHTMLHeadingElement.mm:
2014         * DOM/DOMHTMLHtmlElement.mm:
2015         * DOM/DOMHTMLIFrameElement.mm:
2016         * DOM/DOMHTMLImageElement.mm:
2017         * DOM/DOMHTMLInputElement.mm:
2018         * DOM/DOMHTMLLIElement.mm:
2019         * DOM/DOMHTMLLabelElement.mm:
2020         * DOM/DOMHTMLLegendElement.mm:
2021         * DOM/DOMHTMLLinkElement.mm:
2022         * DOM/DOMHTMLMapElement.mm:
2023         * DOM/DOMHTMLMarqueeElement.mm:
2024         * DOM/DOMHTMLMediaElement.mm:
2025         * DOM/DOMHTMLMetaElement.mm:
2026         * DOM/DOMHTMLModElement.mm:
2027         * DOM/DOMHTMLOListElement.mm:
2028         * DOM/DOMHTMLObjectElement.mm:
2029         * DOM/DOMHTMLOptGroupElement.mm:
2030         * DOM/DOMHTMLOptionElement.mm:
2031         * DOM/DOMHTMLOptionsCollection.mm:
2032         * DOM/DOMHTMLParagraphElement.mm:
2033         * DOM/DOMHTMLParamElement.mm:
2034         * DOM/DOMHTMLQuoteElement.mm:
2035         * DOM/DOMHTMLScriptElement.mm:
2036         * DOM/DOMHTMLSelectElement.mm:
2037         * DOM/DOMHTMLStyleElement.mm:
2038         * DOM/DOMHTMLTableCaptionElement.mm:
2039         * DOM/DOMHTMLTableCellElement.mm:
2040         * DOM/DOMHTMLTableColElement.mm:
2041         * DOM/DOMHTMLTableElement.mm:
2042         * DOM/DOMHTMLTableRowElement.mm:
2043         * DOM/DOMHTMLTableSectionElement.mm:
2044         * DOM/DOMHTMLTitleElement.mm:
2045         * DOM/DOMHTMLUListElement.mm:
2046         * DOM/DOMHTMLVideoElement.mm:
2047         * DOM/DOMKeyboardEvent.mm:
2048         * DOM/DOMMediaList.mm:
2049         * DOM/DOMMouseEvent.mm:
2050         * DOM/DOMMutationEvent.mm:
2051         * DOM/DOMNamedNodeMap.mm:
2052         * DOM/DOMProcessingInstruction.mm:
2053         * DOM/DOMRange.mm:
2054         * DOM/DOMStyleSheet.mm:
2055         * DOM/DOMText.mm:
2056         * DOM/DOMTextEvent.mm:
2057         * DOM/DOMTokenList.mm:
2058         * DOM/DOMUIEvent.mm:
2059         * DOM/DOMXPathResult.mm:
2060         * History/WebHistoryItem.mm:
2061         * Misc/WebNSURLExtras.mm:
2062         (-[NSURL _web_userVisibleString]):
2063         (-[NSURL _web_URLByRemovingUserInfo]):
2064         (-[NSURL _web_dataForURLComponentType:]):
2065         (-[NSURL _web_schemeData]):
2066         (-[NSURL _web_hostData]):
2067         * Misc/WebUserContentURLPattern.mm:
2068         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2069         * Plugins/WebNetscapePluginStream.h:
2070         (WebNetscapePluginStream::setRequestURL):
2071         * WebCoreSupport/WebChromeClient.h:
2072         * WebCoreSupport/WebChromeClient.mm:
2073         (WebChromeClient::signedPublicKeyAndChallengeString const):
2074         * WebCoreSupport/WebContextMenuClient.h:
2075         * WebCoreSupport/WebContextMenuClient.mm:
2076         * WebCoreSupport/WebDragClient.h:
2077         * WebCoreSupport/WebFrameLoaderClient.h:
2078         * WebCoreSupport/WebFrameLoaderClient.mm:
2079         (WebFrameLoaderClient::updateGlobalHistory):
2080         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2081         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2082         (WebPaymentCoordinatorClient::showPaymentUI):
2083         * WebCoreSupport/WebPlatformStrategies.h:
2084         * WebCoreSupport/WebPlatformStrategies.mm:
2085         (WebPlatformStrategies::readURLFromPasteboard):
2086         * WebCoreSupport/WebPluginInfoProvider.h:
2087         * WebCoreSupport/WebPluginInfoProvider.mm:
2088         (WebPluginInfoProvider::webVisiblePluginInfo):
2089         * WebCoreSupport/WebSecurityOrigin.mm:
2090         * WebCoreSupport/WebVisitedLinkStore.h:
2091         * WebView/WebDataSource.mm:
2092         * WebView/WebFrame.mm:
2093         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2094         * WebView/WebImmediateActionController.mm:
2095         (-[WebImmediateActionController _defaultAnimationController]):
2096         * WebView/WebPDFView.mm:
2097         * WebView/WebScriptDebugger.mm:
2098         * WebView/WebViewInternal.h:
2099
2100 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
2101
2102         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
2103         https://bugs.webkit.org/show_bug.cgi?id=192197
2104
2105         Reviewed by Jiewen Tan.
2106
2107         * Configurations/FeatureDefines.xcconfig:
2108         * WebCoreSupport/WebChromeClient.h:
2109         * WebCoreSupport/WebChromeClient.mm:
2110
2111 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2112
2113         Remove dead code from an earlier attempt at implementing safe browsing
2114         https://bugs.webkit.org/show_bug.cgi?id=192067
2115
2116         Reviewed by Chris Dumez.
2117
2118         * WebCoreSupport/WebFrameLoaderClient.h:
2119         * WebCoreSupport/WebFrameLoaderClient.mm:
2120         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2121
2122 2018-11-27  Mark Lam  <mark.lam@apple.com>
2123
2124         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2125         https://bugs.webkit.org/show_bug.cgi?id=192055
2126         <rdar://problem/46288783>
2127
2128         Reviewed by Saam Barati.
2129
2130         * Configurations/FeatureDefines.xcconfig:
2131
2132 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2133
2134         Make it possible to insert editable images with a gesture
2135         https://bugs.webkit.org/show_bug.cgi?id=191937
2136
2137         Reviewed by Wenson Hsieh.
2138
2139         * WebCoreSupport/WebEditorClient.mm:
2140         (undoNameForEditAction):
2141         Add a undo name.
2142
2143 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2144
2145         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2146         https://bugs.webkit.org/show_bug.cgi?id=191945
2147
2148         Reviewed by Anders Carlsson.
2149
2150         * WebCoreSupport/WebEditorClient.mm:
2151         (undoNameForEditAction):
2152
2153 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2154
2155         Enable drag and drop support for iOSMac
2156         https://bugs.webkit.org/show_bug.cgi?id=191818
2157         <rdar://problem/43907454>
2158
2159         Reviewed by Dean Jackson.
2160
2161         * Configurations/FeatureDefines.xcconfig:
2162
2163 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2164
2165         Address post-review feedback after r238438
2166         https://bugs.webkit.org/show_bug.cgi?id=191913
2167
2168         Reviewed by Ryosuke Niwa.
2169
2170         * WebView/WebFrame.mm:
2171         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2172         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2173         * WebView/WebView.mm:
2174         (-[WebView setSelectedDOMRange:affinity:]):
2175
2176 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2177
2178         Web Inspector: "Reload Web Inspector" button no longer partially works
2179         https://bugs.webkit.org/show_bug.cgi?id=191773
2180         <rdar://problem/46139932>
2181
2182         Reviewed by Devin Rousso.
2183
2184         * WebCoreSupport/WebInspectorClient.h:
2185         * WebCoreSupport/WebInspectorClient.mm:
2186         (WebInspectorFrontendClient::reopen):
2187
2188 2018-11-17  Devin Rousso  <drousso@apple.com>
2189
2190         Web Inspector: Network: add button to show system certificate dialog
2191         https://bugs.webkit.org/show_bug.cgi?id=191458
2192         <rdar://problem/45977019>
2193
2194         Reviewed by Joseph Pecoraro.
2195
2196         * WebCoreSupport/WebInspectorClient.h:
2197         * WebCoreSupport/WebInspectorClient.mm:
2198         (WebInspectorFrontendClient::showCertificate): Added.
2199
2200         * Configurations/WebKitLegacy.xcconfig:
2201
2202 2018-11-15  Truitt Savell  <tsavell@apple.com>
2203
2204         Unreviewed, rolling out r238244.
2205
2206         Caused High Sierra test runs to fail early with 50 crashes and
2207         casued 25 API failures.
2208
2209         Reverted changeset:
2210
2211         "[css-logical] Implement flow-relative margin, padding and
2212         border shorthands"
2213         https://bugs.webkit.org/show_bug.cgi?id=188697
2214         https://trac.webkit.org/changeset/238244
2215
2216 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2217
2218         [css-logical] Implement flow-relative margin, padding and border shorthands
2219         https://bugs.webkit.org/show_bug.cgi?id=188697
2220
2221         Reviewed by Simon Fraser and Antti Koivisto.
2222
2223         Add CSSLogicalEnabled runtime flag.
2224
2225         * WebView/WebPreferenceKeysPrivate.h:
2226         * WebView/WebPreferences.mm:
2227         (+[WebPreferences initialize]):
2228         (-[WebPreferences cssLogicalEnabled]):
2229         (-[WebPreferences setCSSLogicalEnabled:]):
2230         * WebView/WebPreferencesPrivate.h:
2231         * WebView/WebView.mm:
2232         (-[WebView _preferencesChanged:]):
2233
2234 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2235
2236         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2237         https://bugs.webkit.org/show_bug.cgi?id=191612
2238
2239         Reviewed by Matt Baker.
2240
2241         * WebCoreSupport/WebInspectorClient.mm:
2242         (-[WebInspectorWindowController destroyInspectorView]):
2243
2244 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2245
2246         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2247         https://bugs.webkit.org/show_bug.cgi?id=191494
2248         <rdar://problem/45469854>
2249
2250         Reviewed by Devin Rousso.
2251
2252         * WebCoreSupport/WebInspectorClient.h:
2253         WebKitLegacy will still have remote inspection of the Page directly.
2254
2255 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2256
2257         Make compositing updates incremental
2258         https://bugs.webkit.org/show_bug.cgi?id=90342
2259
2260         Reviewed by Antti Koivisto.
2261
2262         Fix spelling error.
2263
2264         * WebView/WebView.mm:
2265         (-[WebView _setMediaLayer:forPluginView:]):
2266
2267 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2268
2269         Implement a new edit command to change the enclosing list type
2270         https://bugs.webkit.org/show_bug.cgi?id=191487
2271         <rdar://problem/45955922>
2272
2273         Reviewed by Ryosuke Niwa.
2274
2275         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2276
2277         * WebCoreSupport/WebEditorClient.mm:
2278         (undoNameForEditAction):
2279
2280 2018-11-11  Daniel Bates  <dabates@apple.com>
2281
2282         [iOS] Draw caps lock indicator in password fields
2283         https://bugs.webkit.org/show_bug.cgi?id=190565
2284         <rdar://problem/45262343>
2285
2286         Reviewed by Dean Jackson.
2287
2288         Update the caps lock state when a hardware keyboard is attached or detached.
2289
2290         * WebView/WebHTMLView.mm:
2291         (hardwareKeyboardAvailabilityChangedCallback): Added.
2292         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2293         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2294
2295 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2296
2297         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2298         https://bugs.webkit.org/show_bug.cgi?id=191492
2299
2300         Reviewed by Alex Christensen.
2301
2302         * Carbon/HIWebView.mm:
2303         * Misc/WebNSFileManagerExtras.mm:
2304         * Misc/WebNSURLExtras.mm:
2305         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2306         * Plugins/WebBasePluginPackage.mm:
2307         * Plugins/WebPluginContainerCheck.mm:
2308         * WebCoreSupport/WebCachedFramePlatformData.h:
2309         * WebCoreSupport/WebDeviceOrientationClient.mm:
2310         * WebView/WebDelegateImplementationCaching.mm:
2311         * WebView/WebHTMLView.mm:
2312         * WebView/WebPDFRepresentation.mm:
2313         * WebView/WebPolicyDelegate.mm:
2314         * WebView/WebView.mm:
2315
2316 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2317
2318         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2319         https://bugs.webkit.org/show_bug.cgi?id=191492
2320
2321         Reviewed by Alex Christensen.
2322
2323         * Carbon/HIWebView.mm:
2324         (UpdateCommandStatus):
2325         * Misc/WebNSFileManagerExtras.mm:
2326         * Misc/WebNSURLExtras.mm:
2327         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2328         * Plugins/WebBasePluginPackage.mm:
2329         * Plugins/WebPluginContainerCheck.mm:
2330         (-[WebPluginContainerCheck _continueWithPolicy:]):
2331         * WebCoreSupport/WebCachedFramePlatformData.h:
2332         (WebCachedFramePlatformData::clear):
2333         * WebCoreSupport/WebDeviceOrientationClient.mm:
2334         (WebDeviceOrientationClient::getProvider const):
2335         * WebView/WebDelegateImplementationCaching.mm:
2336         (CallDelegate):
2337         (CallDelegateReturningBoolean):
2338         (CallResourceLoadDelegateReturningBoolean):
2339         (CallFormDelegate):
2340         (CallFormDelegateReturningBoolean):
2341         * WebView/WebHTMLView.mm:
2342         * WebView/WebPDFRepresentation.mm:
2343         * WebView/WebPolicyDelegate.mm:
2344         (-[WebPolicyDecisionListener _usePolicy:]):
2345         * WebView/WebView.mm:
2346
2347 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2348
2349         Unreviewed, rolling out r238047.
2350
2351         Introduced layout test failures on iOS simulator.
2352
2353         Reverted changeset:
2354
2355         "[iOS] Draw caps lock indicator in password fields"
2356         https://bugs.webkit.org/show_bug.cgi?id=190565
2357         https://trac.webkit.org/changeset/238047
2358
2359 2018-11-09  Antti Koivisto  <antti@apple.com>
2360
2361         Use OptionSet for layout milestones
2362         https://bugs.webkit.org/show_bug.cgi?id=191470
2363
2364         Reviewed by Dean Jackson.
2365
2366         * WebCoreSupport/WebFrameLoaderClient.h:
2367         * WebCoreSupport/WebFrameLoaderClient.mm:
2368         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2369         * WebView/WebView.mm:
2370         (coreLayoutMilestones):
2371         (kitLayoutMilestones):
2372         (-[WebView _cacheFrameLoadDelegateImplementations]):
2373         * WebView/WebViewInternal.h:
2374
2375 2018-11-09  Daniel Bates  <dabates@apple.com>
2376
2377         [iOS] Draw caps lock indicator in password fields
2378         https://bugs.webkit.org/show_bug.cgi?id=190565
2379         <rdar://problem/45262343>
2380
2381         Reviewed by Dean Jackson.
2382
2383         Update the caps lock state when a hardware keyboard is attached or detached.
2384
2385         * WebView/WebHTMLView.mm:
2386         (hardwareKeyboardAvailabilityChangedCallback): Added.
2387         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2388         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2389
2390 2018-11-09  Daniel Bates  <dabates@apple.com>
2391
2392         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2393         action when forward delete is pressed outside a text field
2394         https://bugs.webkit.org/show_bug.cgi?id=190566
2395         <rdar://problem/45262367>
2396
2397         Reviewed by Wenson Hsieh.
2398
2399         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2400         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2401         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2402
2403         * WebView/WebHTMLView.mm:
2404         (-[WebHTMLView _handleEditingKeyEvent:]):
2405
2406 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2407
2408         Adopt Reveal Framework to replace Lookup
2409         https://bugs.webkit.org/show_bug.cgi?id=191097
2410         <rdar://problem/45924508>
2411
2412         Reviewed by Tim Horton.
2413
2414         Pass in what it needed to clear the textIndicators. This is better than
2415         the current notification structure.
2416
2417         * WebView/WebView.mm:
2418         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2419         (-[WebView _prepareForDictionaryLookup]):
2420
2421 2018-11-06  Justin Fan  <justin_fan@apple.com>
2422
2423         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2424         https://bugs.webkit.org/show_bug.cgi?id=191291
2425
2426         Reviewed by Myles Maxfield.
2427
2428         Properly disable WEBGPU on all non-Metal platforms for now.
2429
2430         * Configurations/FeatureDefines.xcconfig:
2431
2432 2018-11-02  Daniel Bates  <dabates@apple.com>
2433
2434         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2435         https://bugs.webkit.org/show_bug.cgi?id=190487
2436
2437         Reviewed by Tim Horton.
2438
2439         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2440         allow the default handling.
2441
2442         * WebView/WebHTMLView.mm:
2443         (-[WebHTMLView _handleEditingKeyEvent:]):
2444
2445 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2446
2447         Add a storage limit for IndexedDB
2448         https://bugs.webkit.org/show_bug.cgi?id=190598
2449         <rdar://problem/44654715>
2450
2451         Reviewed by Chris Dumez.
2452
2453         * Storage/WebDatabaseManager.mm:
2454         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2455         * Storage/WebDatabaseManagerPrivate.h:
2456
2457 2018-10-31  Antti Koivisto  <antti@apple.com>
2458
2459         Remove LayerFlushScheduler
2460         https://bugs.webkit.org/show_bug.cgi?id=191103
2461
2462         Reviewed by Anders Carlsson.
2463
2464         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2465         all the virtual cruft.
2466
2467         * WebView/WebViewData.h:
2468         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2469         (): Deleted.
2470         * WebView/WebViewData.mm:
2471         (currentRunLoop):
2472         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2473         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2474         (WebViewLayerFlushScheduler::schedule):
2475         (WebViewLayerFlushScheduler::invalidate):
2476         (WebViewLayerFlushScheduler::layerFlushCallback):
2477
2478 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2479
2480         Enable InstallAPI for iOS unconditionally
2481         https://bugs.webkit.org/show_bug.cgi?id=191043
2482         rdar://problem/32728423
2483
2484         Reviewed by Dan Bernstein.
2485
2486         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2487         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2488         shouldn't be processed by InstallAPI.
2489         * MigrateHeaders.make: Removed an obsolete workaround.
2490         * Misc/NSURLDownloadSPI.h: Added.
2491         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2492
2493 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2494
2495         Clean up some obsolete MAX_ALLOWED macros
2496         https://bugs.webkit.org/show_bug.cgi?id=190916
2497
2498         Reviewed by Tim Horton.
2499
2500         * WebView/WebHTMLView.mm:
2501         (-[WebHTMLView pressureChangeWithEvent:]):
2502         * WebView/WebPDFView.h:
2503
2504 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2505
2506         Unreviewed, rolling out r237600 and r237604.
2507         https://bugs.webkit.org/show_bug.cgi?id=191086
2508
2509         Breaks internal iOS builds (Requested by ryanhadd_ on
2510         #webkit).
2511
2512         Reverted changesets:
2513
2514         "Enable InstallAPI for iOS unconditionally"
2515         https://bugs.webkit.org/show_bug.cgi?id=191043
2516         https://trac.webkit.org/changeset/237600
2517
2518         "Build fix attempt after enabling InstallAPI for iOS."
2519         https://bugs.webkit.org/show_bug.cgi?id=191043
2520         https://trac.webkit.org/changeset/237604
2521
2522 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2523
2524         Enable InstallAPI for iOS unconditionally
2525         https://bugs.webkit.org/show_bug.cgi?id=191043
2526         rdar://problem/32728423
2527
2528         Reviewed by Dan Bernstein.
2529
2530         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2531         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2532         shouldn't be processed by InstallAPI.
2533         * MigrateHeaders.make: Removed an obsolete workaround.
2534         * Misc/NSURLDownloadSPI.h: Added.
2535         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2536
2537 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2538
2539         Modernize WebKit nibs and lprojs for localization's sake
2540         https://bugs.webkit.org/show_bug.cgi?id=190911
2541         <rdar://problem/45349466>
2542
2543         Reviewed by Dan Bernstein.
2544
2545         * Misc/WebNSControlExtras.m:
2546         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2547         NSWindow and its contents are both in the same scale space these days; avoid
2548         double-applying the scale factor, or you can't see the prompt.
2549
2550         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2551         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2552         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2553         NIB->XIB
2554
2555 2018-10-25  Antoine Quint  <graouts@apple.com>
2556
2557         [Web Animations] Turn Web Animations CSS Integration off by default
2558         https://bugs.webkit.org/show_bug.cgi?id=190901
2559
2560         Reviewed by Dean Jackson.
2561
2562         * WebView/WebPreferences.mm:
2563         (+[WebPreferences initialize]):
2564
2565 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2566
2567         Clean up some obsolete macOS version guards
2568         https://bugs.webkit.org/show_bug.cgi?id=190887
2569
2570         Reviewed by Dan Bernstein.
2571
2572         * Misc/WebNSPasteboardExtras.mm:
2573         (+[NSPasteboard _web_dragTypesForURL]):
2574         * WebCoreSupport/PopupMenuMac.mm:
2575         (PopupMenuMac::show):
2576         * WebCoreSupport/WebEditorClient.h:
2577         * WebCoreSupport/WebEditorClient.mm:
2578         (WebEditorClient::respondToChangedSelection):
2579         * WebView/WebPDFView.mm:
2580         (-[WebPDFView _clipViewForPDFDocumentView]):
2581
2582 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2583
2584         Turn on Conic Gradients
2585         https://bugs.webkit.org/show_bug.cgi?id=190810
2586
2587         Reviewed by Tim Horton.
2588
2589         * Configurations/FeatureDefines.xcconfig:
2590
2591 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2592
2593         Cleanup: MIMETypeRegistry functions
2594         https://bugs.webkit.org/show_bug.cgi?id=190838
2595
2596         Reviewed by Simon Fraser.
2597
2598         * Misc/WebNSPasteboardExtras.mm:
2599         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2600         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2601         because they were identical.
2602
2603         * WebView/WebHTMLRepresentation.mm:
2604         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2605         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2606         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2607         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2608         * WebView/WebView.mm:
2609         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2610         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2611         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2612
2613 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2614
2615         Fix false positive leaks when using custom -init methods that don't start with -init
2616         <https://webkit.org/b/190818>
2617         <rdar://problem/45476042>
2618
2619         Reviewed by Dan Bernstein.
2620
2621         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2622         it is accessible by both categories.
2623         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2624         NSError (WebKitInternal) category.  Add attribute to make this
2625         behave like an -init method.
2626         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2627         NSError (WebKitInternal) category.  Modernize method.  Replace
2628         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2629
2630 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2631
2632         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2633         https://bugs.webkit.org/show_bug.cgi?id=190729
2634
2635         Reviewed by Tim Horton.
2636
2637         * DOM/DOM.mm:
2638         (-[DOMNode boundingBox]):
2639         * DOM/DOMElement.mm:
2640         * DOM/DOMHTML.mm:
2641         * DOM/DOMInternal.mm:
2642         * DOM/DOMUIKitExtensions.mm:
2643         * DOM/WebDOMOperations.mm:
2644         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2645         * DefaultDelegates/WebDefaultEditingDelegate.m:
2646         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2647         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2648         * DefaultDelegates/WebDefaultUIDelegate.h:
2649         * DefaultDelegates/WebDefaultUIDelegate.mm:
2650         (-[WebDefaultUIDelegate webViewClose:]):
2651         (-[WebDefaultUIDelegate webViewFocus:]):
2652         (-[WebDefaultUIDelegate webViewUnfocus:]):
2653         (-[WebDefaultUIDelegate webViewIsResizable:]):
2654         (-[WebDefaultUIDelegate webView:setResizable:]):
2655         (-[WebDefaultUIDelegate webView:setFrame:]):
2656         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2657         * History/BackForwardList.h:
2658         * History/BackForwardList.mm:
2659         * History/WebBackForwardList.mm:
2660         (+[WebBackForwardList initialize]):
2661         (bumperCarBackForwardHackNeeded):
2662         * History/WebHistory.mm:
2663         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2664         (-[WebHistory _sendNotification:entries:]):
2665         (-[WebHistory loadFromURL:error:]):
2666         (-[WebHistory saveToURL:error:]):
2667         * History/WebHistoryItem.mm:
2668         (WKNotifyHistoryItemChanged):
2669         (+[WebHistoryItem initialize]):
2670         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2671         * History/WebURLsWithTitles.m:
2672         * Misc/WebCache.mm:
2673         (+[WebCache initialize]):
2674         * Misc/WebDownload.mm:
2675         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2676         * Misc/WebElementDictionary.mm:
2677         (+[WebElementDictionary initialize]):
2678         (+[WebElementDictionary initializeLookupTable]):
2679         * Misc/WebIconDatabase.mm:
2680         * Misc/WebKitNSStringExtras.mm:
2681         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2682         * Misc/WebKitVersionChecks.h:
2683         * Misc/WebKitVersionChecks.mm:
2684         (WebKitLinkedOnOrAfter):
2685         (WebKitLinkTimeVersion):
2686         * Misc/WebLocalizableStrings.mm:
2687         * Misc/WebNSControlExtras.h:
2688         * Misc/WebNSControlExtras.m:
2689         * Misc/WebNSEventExtras.m:
2690         * Misc/WebNSFileManagerExtras.mm:
2691         * Misc/WebNSImageExtras.h:
2692         * Misc/WebNSImageExtras.m:
2693         * Misc/WebNSPasteboardExtras.mm:
2694         * Misc/WebNSPrintOperationExtras.h:
2695         * Misc/WebNSPrintOperationExtras.m:
2696         * Misc/WebNSViewExtras.m:
2697         * Misc/WebNSWindowExtras.m:
2698         * Panels/WebAuthenticationPanel.h:
2699         * Panels/WebAuthenticationPanel.m:
2700         * Panels/WebPanelAuthenticationHandler.m:
2701         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2702         (+[WebHostedNetscapePluginView initialize]):
2703         * Plugins/WebBasePluginPackage.h:
2704         * Plugins/WebBasePluginPackage.mm:
2705         * Plugins/WebJavaPlugIn.h:
2706         * Plugins/WebPluginContainerCheck.mm:
2707         * Plugins/WebPluginController.h:
2708         * Plugins/WebPluginController.mm:
2709         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2710         (-[WebPluginController addPlugin:]):
2711         (-[WebPluginController destroyPlugin:]):
2712         (-[WebPluginController destroyAllPlugins]):
2713         * Plugins/WebPluginDatabase.mm:
2714         (+[WebPluginDatabase _defaultPlugInPaths]):
2715         * Plugins/WebPluginPackage.mm:
2716         (-[WebPluginPackage initWithPath:]):
2717         * Storage/WebDatabaseManager.mm:
2718         (-[WebDatabaseManager deleteAllDatabases]):
2719         * Storage/WebDatabaseManagerClient.h:
2720         * Storage/WebDatabaseManagerClient.mm:
2721         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2722         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2723         * Storage/WebStorageManager.mm:
2724         (-[WebStorageManager deleteAllOrigins]):
2725         (WebKitInitializeStorageIfNecessary):
2726         * WebCoreSupport/WebAlternativeTextClient.h:
2727         * WebCoreSupport/WebApplicationCache.mm:
2728         (applicationCacheBundleIdentifier):
2729         * WebCoreSupport/WebChromeClient.h:
2730         * WebCoreSupport/WebChromeClient.mm:
2731         (WebChromeClient::setWindowRect):
2732         (WebChromeClient::windowRect):
2733         (WebChromeClient::takeFocus):
2734         (WebChromeClient::addMessageToConsole):
2735         (WebChromeClient::enableSuddenTermination):
2736         (WebChromeClient::disableSuddenTermination):
2737         (WebChromeClient::createPopupMenu const):
2738         (WebChromeClient::createSearchPopupMenu const):
2739         (WebChromeClient::shouldPaintEntireContents const):
2740         (WebChromeClient::supportsVideoFullscreen):
2741         (WebChromeClient::supportsFullScreenForElement):
2742         (WebChromeClient::enterFullScreenForElement):
2743         (WebChromeClient::exitFullScreenForElement):
2744         * WebCoreSupport/WebContextMenuClient.mm:
2745         * WebCoreSupport/WebDragClient.mm:
2746         * WebCoreSupport/WebEditorClient.h:
2747         * WebCoreSupport/WebEditorClient.mm:
2748         (+[WebUndoStep initialize]):
2749         (updateFontPanel):
2750         (WebEditorClient::didBeginEditing):
2751         (WebEditorClient::respondToChangedContents):
2752         (WebEditorClient::respondToChangedSelection):
2753         (WebEditorClient::canceledComposition):
2754         (WebEditorClient::didEndEditing):
2755         (WebEditorClient::didWriteSelectionToPasteboard):
2756         (attributesForAttributedStringConversion):
2757         (WebEditorClient::setInsertionPasteboard):
2758         (WebEditorClient::registerUndoOrRedoStep):
2759         (WebEditorClient::handleKeyboardEvent):
2760         (WebEditorClient::handleInputMethodKeydown):
2761         (WebEditorClient::textDidChangeInTextField):
2762         (WebEditorClient::requestCheckingOfString):
2763         * WebCoreSupport/WebFrameLoaderClient.h:
2764         * WebCoreSupport/WebFrameLoaderClient.mm:
2765         (WebFrameLoaderClient::detachedFromParent2):
2766         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2767         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2768         (WebFrameLoaderClient::dispatchWillSendRequest):
2769         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2770         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2771         (WebFrameLoaderClient::willCacheResponse const):
2772         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2773         (WebFrameLoaderClient::dispatchDidFinishLoading):
2774         (WebFrameLoaderClient::dispatchDidFailLoading):
2775         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2776         (WebFrameLoaderClient::dispatchWillClose):
2777         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2778         (WebFrameLoaderClient::dispatchDidCommitLoad):
2779         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2780         (WebFrameLoaderClient::dispatchDidFailLoad):
2781         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2782         (WebFrameLoaderClient::dispatchDidFinishLoad):
2783         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2784         (WebFrameLoaderClient::willChangeTitle):
2785         (WebFrameLoaderClient::didChangeTitle):
2786         (WebFrameLoaderClient::didReplaceMultipartContent):
2787         (WebFrameLoaderClient::updateGlobalHistory):
2788         (WebFrameLoaderClient::saveViewStateToItem):
2789         (WebFrameLoaderClient::restoreViewState):
2790         (WebFrameLoaderClient::provisionalLoadStarted):
2791         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2792         (WebFrameLoaderClient::setTitle):
2793         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2794         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2795         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2796         (WebFrameLoaderClient::didRestoreFromPageCache):
2797         (WebFrameLoaderClient::actionDictionary const):
2798         (WebFrameLoaderClient::createPlugin):
2799         (WebFrameLoaderClient::getLoadDecisionForIcons):
2800         (WebFrameLoaderClient::finishedLoadingIcon):
2801         (+[WebFramePolicyListener initialize]):
2802         * WebCoreSupport/WebFrameNetworkingContext.mm:
2803         * WebCoreSupport/WebGeolocationClient.h:
2804         * WebCoreSupport/WebGeolocationClient.mm:
2805         (WebGeolocationClient::requestPermission):
2806         * WebCoreSupport/WebInspectorClient.h:
2807         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2808         * WebCoreSupport/WebNotificationClient.mm:
2809         * WebCoreSupport/WebOpenPanelResultListener.mm:
2810         * WebCoreSupport/WebPlatformStrategies.h:
2811         * WebCoreSupport/WebPlatformStrategies.mm:
2812         * WebCoreSupport/WebProgressTrackerClient.h:
2813         * WebCoreSupport/WebProgressTrackerClient.mm:
2814         (WebProgressTrackerClient::progressStarted):
2815         (WebProgressTrackerClient::progressEstimateChanged):
2816         (WebProgressTrackerClient::progressFinished):
2817         * WebCoreSupport/WebSecurityOrigin.mm:
2818         * WebInspector/WebNodeHighlight.h:
2819         * WebInspector/WebNodeHighlight.mm:
2820         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2821         (-[WebNodeHighlight dealloc]):
2822         (-[WebNodeHighlight attach]):
2823         * WebInspector/WebNodeHighlightView.h:
2824         * WebInspector/WebNodeHighlightView.mm:
2825         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2826         (-[WebNodeHighlightView dealloc]):
2827         * WebInspector/WebNodeHighlighter.mm:
2828         (-[WebNodeHighlighter highlight]):
2829         * WebView/WebArchive.mm:
2830         (+[WebArchivePrivate initialize]):
2831         * WebView/WebClipView.h:
2832         * WebView/WebDataSource.mm:
2833         (WebDataSourcePrivate::WebDataSourcePrivate):
2834         (+[WebDataSource initialize]):
2835         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2836         (-[WebDataSource _makeRepresentation]):
2837         * WebView/WebDelegateImplementationCaching.h:
2838         * WebView/WebDelegateImplementationCaching.mm:
2839         (CallDelegate):
2840         (CallDelegateReturningFloat):
2841         (CallDelegateReturningBoolean):
2842         (CallUIDelegate):
2843         (CallUIDelegateReturningFloat):
2844         (CallUIDelegateReturningBoolean):
2845         (CallFrameLoadDelegate):
2846         (CallFrameLoadDelegateReturningBoolean):
2847         (CallResourceLoadDelegate):
2848         (CallScriptDebugDelegate):
2849         (CallFormDelegate):
2850         (CallFormDelegateReturningBoolean):
2851         * WebView/WebDeviceOrientation.mm:
2852         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2853         * WebView/WebDocumentInternal.h:
2854         * WebView/WebDocumentLoaderMac.mm:
2855         (needsDataLoadWorkaround):
2856         * WebView/WebDynamicScrollBarsViewInternal.h:
2857         * WebView/WebFormDelegate.m:
2858         * WebView/WebFrame.mm:
2859         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2860         (-[WebFrame _unmarkAllMisspellings]):
2861         (-[WebFrame _paintBehaviorForDestinationContext:]):
2862         (-[WebFrame _drawRect:contentsOnly:]):
2863         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2864         (-[WebFrame _scrollDOMRangeToVisible:]):
2865         (-[WebFrame _bodyBackgroundColor]):
2866         (-[WebFrame accessibilityRoot]):
2867         (needsMicrosoftMessengerDOMDocumentWorkaround):
2868         * WebView/WebFrameInternal.h:
2869         * WebView/WebFrameView.mm:
2870         (-[WebFrameView _setDocumentView:]):
2871         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2872         (-[WebFrameView _viewClassForMIMEType:]):
2873         (-[WebFrameView initWithFrame:]):
2874         (-[WebFrameView drawRect:]):
2875         (-[WebFrameView _firstResponderIsFormControl]):
2876         (-[WebFrameView keyDown:keyDown:]):
2877         (-[WebFrameView _isScrollable]):
2878         * WebView/WebFullScreenController.h:
2879         * WebView/WebFullScreenController.mm:
2880         * WebView/WebHTMLRepresentation.mm:
2881         * WebView/WebHTMLView.mm:
2882         (-[WebHTMLView hitTest:]):
2883         (-[WebHTMLView initWithFrame:]):
2884         (-[WebHTMLView dealloc]):
2885         (-[WebHTMLView addSubview:]):
2886         (-[WebHTMLView mouseDown:]):
2887         (-[WebHTMLView mouseUp:]):
2888         (-[WebHTMLView resignFirstResponder]):
2889         (-[WebHTMLView accessibilityHitTest:]):
2890         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2891         * WebView/WebHTMLViewInternal.h:
2892         * WebView/WebIndicateLayer.h:
2893         * WebView/WebIndicateLayer.mm:
2894         * WebView/WebMediaPlaybackTargetPicker.h:
2895         * WebView/WebMediaPlaybackTargetPicker.mm:
2896         * WebView/WebPDFDocumentExtras.h:
2897         * WebView/WebPDFDocumentExtras.mm:
2898         * WebView/WebPDFRepresentation.h:
2899         * WebView/WebPDFRepresentation.mm:
2900         * WebView/WebPDFView.h:
2901         * WebView/WebPreferences.mm:
2902         (cacheModelForMainBundle):
2903         (WebPreferencesPrivate::WebPreferencesPrivate):
2904         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2905         (-[WebPreferences encodeWithCoder:]):
2906         (+[WebPreferences standardPreferences]):
2907         (+[WebPreferences initialize]):
2908         (-[WebPreferences _valueForKey:]):
2909         (-[WebPreferences _setStringValue:forKey:]):
2910         (-[WebPreferences _setIntegerValue:forKey:]):
2911         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2912         (-[WebPreferences _setFloatValue:forKey:]):
2913         (-[WebPreferences _setBoolValue:forKey:]):
2914         (-[WebPreferences _setLongLongValue:forKey:]):
2915         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2916         (-[WebPreferences _postCacheModelChangedNotification]):
2917         (-[WebPreferences _postPreferencesChangedNotification]):
2918         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2919         (-[WebPreferences setStorageBlockingPolicy:]):
2920         * WebView/WebResource.mm:
2921         (+[WebResourcePrivate initialize]):
2922         * WebView/WebTextCompletionController.h:
2923         * WebView/WebTextIterator.mm:
2924         (+[WebTextIteratorPrivate initialize]):
2925         * WebView/WebView.mm:
2926         (shouldEnableLoadDeferring):
2927         (shouldRestrictWindowFocus):
2928         (shouldRespectPriorityInCSSAttributeSetters):
2929         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2930         (shouldAllowPictureInPictureMediaPlayback):
2931         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2932         (shouldAllowWindowOpenWithoutUserGesture):
2933         (shouldConvertInvalidURLsToBlank):
2934         (shouldRequireUserGestureToLoadVideo):
2935         (-[WebView _commonInitializationWithFrameName:groupName:]):
2936         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2937         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2938         (-[WebView _closePluginDatabases]):
2939         (-[WebView _closeWithFastTeardown]):
2940         (-[WebView _close]):
2941         (+[WebView _MIMETypeForFile:]):
2942         (-[WebView setShowingInspectorIndication:]):
2943         (-[WebView _setFormDelegate:]):
2944         (-[WebView _needsPreHTML5ParserQuirks]):
2945         (-[WebView _preferencesChangedNotification:]):
2946         (-[WebView _preferencesChanged:]):
2947         (-[WebView _cacheResourceLoadDelegateImplementations]):
2948         (-[WebView _cacheFrameLoadDelegateImplementations]):
2949         (-[WebView _policyDelegateForwarder]):
2950         (-[WebView _UIDelegateForwarder]):
2951         (-[WebView _editingDelegateForwarder]):
2952         (-[WebView _updateActiveState]):
2953         (-[_WebSafeForwarder forwardInvocation:]):
2954         (+[WebView initialize]):
2955         (-[WebView _pluginForMIMEType:]):
2956         (-[WebView _pluginForExtension:]):
2957         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2958         (+[WebView canShowMIMETypeAsHTML:]):
2959         (-[WebView _initWithArguments:]):
2960         (-[WebView initWithFrame:frameName:groupName:]):
2961         (-[WebView dealloc]):
2962         (-[WebView close]):
2963         (-[WebView viewDidMoveToWindow]):
2964         (-[WebView setUIDelegate:]):
2965         (-[WebView setResourceLoadDelegate:]):
2966         (-[WebView setPolicyDelegate:]):
2967         (-[WebView setFrameLoadDelegate:]):
2968         (-[WebView goBack]):
2969         (-[WebView goForward]):
2970         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2971         (-[WebView setHostWindow:]):
2972         (-[WebView becomeFirstResponder]):
2973         (+[WebView _cacheModelChangedNotification:]):
2974         (-[WebView _frameViewAtWindowPoint:]):
2975         (+[WebView _preflightSpellCheckerNow:]):
2976         (+[WebView _preflightSpellChecker]):
2977         (-[WebView canGoBack]):
2978         (-[WebView canGoForward]):
2979         (-[WebView stopLoading:]):
2980         (-[WebView reload:]):
2981         (-[WebView setMainFrameDocumentReady:]):
2982         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2983         (-[WebView setContinuousSpellCheckingEnabled:]):
2984         (-[WebView undoManager]):
2985         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2986         (-[WebView isAutomaticLinkDetectionEnabled]):
2987         (-[WebView isAutomaticDashSubstitutionEnabled]):
2988         (-[WebView isAutomaticTextReplacementEnabled]):
2989         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2990         (+[WebView _setCacheModel:]):
2991         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2992         (-[WebView _keyboardUIMode]):
2993         (LayerFlushController::flushLayers):
2994         (-[WebView _scheduleCompositingLayerFlush]):
2995         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2996         (-[WebView fullScreenPlaceholderView]):
2997         (WebInstallMemoryPressureHandler):
2998         * WebView/WebViewData.h:
2999         * WebView/WebViewData.mm:
3000         (+[WebViewPrivate initialize]):
3001         (-[WebViewPrivate init]):
3002         (-[WebViewPrivate dealloc]):
3003         * WebView/WebViewInternal.h:
3004
3005 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3006
3007         Clean up FrameLoader two-state enums
3008         https://bugs.webkit.org/show_bug.cgi?id=190731
3009
3010         Reviewed by Chris Dumez.
3011
3012         * WebCoreSupport/WebFrameLoaderClient.h:
3013         * WebCoreSupport/WebFrameLoaderClient.mm:
3014         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3015
3016 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3017
3018         Unreviewed, rolling out r237137.
3019
3020         SPI is actually used
3021
3022         Reverted changeset:
3023
3024         "Remove unused WebFrame._loadType"
3025         https://bugs.webkit.org/show_bug.cgi?id=190583
3026         https://trac.webkit.org/changeset/237137
3027
3028 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3029
3030         Enable the datalist element by default on iOS and macOS
3031         https://bugs.webkit.org/show_bug.cgi?id=190594
3032         <rdar://problem/45281159>
3033
3034         Reviewed by Ryosuke Niwa and Tim Horton.
3035
3036         * Configurations/FeatureDefines.xcconfig:
3037
3038 2018-10-17  Alex Christensen  <achristensen@webkit.org>
3039
3040         BackForwardClient needs to be able to support UIProcess-only back/forward lists
3041         https://bugs.webkit.org/show_bug.cgi?id=190675
3042
3043         Reviewed by Chris Dumez.
3044
3045         * History/BackForwardList.h:
3046         * History/BackForwardList.mm:
3047         (BackForwardList::backItem):
3048         (BackForwardList::currentItem):
3049         (BackForwardList::forwardItem):
3050         (BackForwardList::backListCount const):
3051         (BackForwardList::forwardListCount const):
3052         (BackForwardList::itemAtIndex):
3053         * History/WebBackForwardList.mm:
3054         (-[WebBackForwardList backItem]):
3055         (-[WebBackForwardList currentItem]):
3056         (-[WebBackForwardList forwardItem]):
3057         (-[WebBackForwardList itemAtIndex:]):
3058
3059 2018-10-16  Timothy Hatcher  <timothy@apple.com>
3060
3061         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
3062         https://bugs.webkit.org/show_bug.cgi?id=190526
3063         rdar://problem/45230140
3064
3065         Reviewed by Dean Jackson.
3066
3067         * WebCoreSupport/WebEditorClient.mm:
3068         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
3069
3070 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3071
3072         Implement feature flag and bindings for CSS Painting API
3073         https://bugs.webkit.org/show_bug.cgi?id=190237
3074
3075         Reviewed by Ryosuke Niwa.
3076
3077         * Configurations/FeatureDefines.xcconfig:
3078
3079 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3080
3081         Replace HistoryItem* with HistoryItem& where possible
3082         https://bugs.webkit.org/show_bug.cgi?id=190617
3083
3084         Reviewed by Chris Dumez.
3085
3086         * History/BackForwardList.h:
3087         * History/BackForwardList.mm:
3088         (BackForwardList::goToItem):
3089         * History/WebBackForwardList.mm:
3090         (-[WebBackForwardList goToItem:]):
3091         * History/WebHistoryItem.mm:
3092         (WKNotifyHistoryItemChanged):
3093         * History/WebHistoryItemInternal.h:
3094
3095 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3096
3097         Remove unused WebHistoryItem._transientPropertyForKey
3098         https://bugs.webkit.org/show_bug.cgi?id=190606
3099
3100         Reviewed by Chris Dumez.
3101
3102         * History/WebHistoryItem.mm:
3103         * History/WebHistoryItemPrivate.h:
3104
3105 2018-10-15  Justin Fan  <justin_fan@apple.com>
3106
3107         Add WebGPU 2018 feature flag and experimental feature flag
3108         https://bugs.webkit.org/show_bug.cgi?id=190509
3109
3110         Reviewed by Dean Jackson.
3111
3112         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3113         for the 2018 WebGPU prototype.
3114
3115         * Configurations/FeatureDefines.xcconfig:
3116         * WebView/WebPreferenceKeysPrivate.h:
3117         * WebView/WebPreferences.mm:
3118         (+[WebPreferences initialize]):
3119         (-[WebPreferences webGPUEnabled]):
3120         (-[WebPreferences setWebGPUEnabled:]):
3121         * WebView/WebPreferencesPrivate.h:
3122         * WebView/WebView.mm:
3123         (-[WebView _preferencesChanged:]):
3124
3125 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3126
3127         Fix iOS build after r237157
3128
3129         * WebView/WebView.mm:
3130         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3131
3132 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3133
3134         Modernize BackForwardClient.h
3135         https://bugs.webkit.org/show_bug.cgi?id=190610
3136
3137         Reviewed by Chris Dumez.
3138
3139         * History/BackForwardList.h:
3140         * History/BackForwardList.mm:
3141         (BackForwardList::backListCount const):
3142         (BackForwardList::forwardListCount const):
3143         (BackForwardList::backListCount): Deleted.
3144         (BackForwardList::forwardListCount): Deleted.
3145         * History/WebBackForwardList.mm:
3146         (-[WebBackForwardList init]):
3147         * WebCoreSupport/WebFrameLoaderClient.mm:
3148         (WebFrameLoaderClient::canCachePage const):
3149         * WebView/WebFrameView.mm:
3150         (-[WebFrameView keyDown:keyDown:]):
3151         * WebView/WebView.mm:
3152         (-[WebView _commonInitializationWithFrameName:groupName:]):
3153         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3154         (-[WebView _loadBackForwardListFromOtherView:]):
3155         (-[WebView initWithCoder:]):
3156         (-[WebView encodeWithCoder:]):
3157         (-[WebView backForwardList]):
3158         (-[WebView setMaintainsBackForwardList:]):
3159
3160 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3161
3162         Add support for prefers-color-scheme media query
3163         https://bugs.webkit.org/show_bug.cgi?id=190499
3164         rdar://problem/45212025
3165
3166         Reviewed by Dean Jackson.
3167
3168         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3169
3170 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3171
3172         Remove unused WebView._globalHistoryItem
3173         https://bugs.webkit.org/show_bug.cgi?id=190601
3174
3175         Reviewed by Chris Dumez.
3176
3177         * WebCoreSupport/WebFrameLoaderClient.h:
3178         * WebCoreSupport/WebFrameLoaderClient.mm:
3179         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3180         * WebView/WebView.mm:
3181         (-[WebView _globalHistoryItem]): Deleted.
3182         (-[WebView _setGlobalHistoryItem:]): Deleted.
3183         * WebView/WebViewData.h:
3184         * WebView/WebViewInternal.h:
3185         * WebView/WebViewPrivate.h:
3186
3187 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3188
3189         Remove unused parameters from FrameLoaderClient::createFrame
3190         https://bugs.webkit.org/show_bug.cgi?id=190587
3191
3192         Reviewed by Chris Dumez.
3193
3194         * WebCoreSupport/WebFrameLoaderClient.h:
3195         * WebCoreSupport/WebFrameLoaderClient.mm:
3196         (WebFrameLoaderClient::createFrame):
3197
3198 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3199
3200         Remove unused WebFrame._loadType
3201         https://bugs.webkit.org/show_bug.cgi?id=190583
3202
3203         Reviewed by Chris Dumez.
3204
3205         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3206
3207         * WebView/WebFrame.mm:
3208         (toWebFrameLoadType): Deleted.
3209         (-[WebFrame _loadType]): Deleted.
3210         * WebView/WebFramePrivate.h:
3211
3212 2018-10-15  Chris Dumez  <cdumez@apple.com>
3213
3214         Restrict browsing context lookup by name to frames that are related to one another
3215         https://bugs.webkit.org/show_bug.cgi?id=190475
3216
3217         Reviewed by Alex Christensen.
3218
3219         * WebView/WebFrame.mm:
3220         (-[WebFrame findFrameNamed:]):
3221
3222 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3223
3224         Remove InjectedBundle processing of back/forward lists
3225         https://bugs.webkit.org/show_bug.cgi?id=190459
3226
3227         Reviewed by Chris Dumez.
3228
3229         * WebCoreSupport/WebFrameLoaderClient.h:
3230         * WebCoreSupport/WebFrameLoaderClient.mm:
3231         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3232
3233 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3234
3235         [JSC] Remove Option::useAsyncIterator
3236         https://bugs.webkit.org/show_bug.cgi?id=190567
3237
3238         Reviewed by Saam Barati.
3239
3240         * Configurations/FeatureDefines.xcconfig:
3241
3242 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3243
3244         Allow encoding of small enum classes
3245         https://bugs.webkit.org/show_bug.cgi?id=190531
3246
3247         Reviewed by Tim Horton.
3248
3249         * WebCoreSupport/WebFrameLoaderClient.mm:
3250         (-[WebFramePolicyListener dealloc]):
3251
3252 2018-10-11  Keith Rollin  <krollin@apple.com>
3253
3254         CURRENT_ARCH should not be used in Run Script phase.
3255         https://bugs.webkit.org/show_bug.cgi?id=190407
3256         <rdar://problem/45133556>
3257
3258         Reviewed by Alexey Proskuryakov.
3259
3260         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3261         CURRENT_ARCH is not well-defined during this phase (and may even have
3262         the value "undefined") since this phase is run just once per build
3263         rather than once per supported architecture. Migrate away from
3264         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3265         performing an operation for each value, or by picking the first entry
3266         in ARCHS and using that as a representative value.
3267
3268         * Configurations/WebKitLegacy.xcconfig: When generating
3269         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3270         macosx platforms.
3271
3272         * MigrateHeaders.make:
3273         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3274         generate one for each architecture in ARCHS.
3275
3276 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3277
3278         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3279         https://bugs.webkit.org/show_bug.cgi?id=190429
3280
3281         Reviewed by Saam Barati.
3282
3283         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3284
3285         * WebView/WebPDFRepresentation.mm:
3286         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3287
3288 2018-10-08  Justin Fan  <justin_fan@apple.com>
3289
3290         WebGPU: Rename old WebGPU prototype to WebMetal
3291         https://bugs.webkit.org/show_bug.cgi?id=190325
3292         <rdar://problem/44990443>
3293
3294         Reviewed by Dean Jackson.
3295
3296         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3297
3298         * Configurations/FeatureDefines.xcconfig:
3299         * WebView/WebPreferenceKeysPrivate.h:
3300         * WebView/WebPreferences.mm:
3301         (+[WebPreferences initialize]):
3302         (-[WebPreferences webMetalEnabled]):
3303         (-[WebPreferences setWebMetalEnabled:]):
3304         (-[WebPreferences webGPUEnabled]): Deleted.
3305         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3306         * WebView/WebPreferencesPrivate.h:
3307         * WebView/WebView.mm:
3308         (-[WebView _preferencesChanged:]):
3309
3310 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3311
3312         Make <input type=color> a runtime enabled (on-by-default) feature
3313         https://bugs.webkit.org/show_bug.cgi?id=189162
3314
3315         Reviewed by Wenson Hsieh and Tim Horton.
3316
3317         * Configurations/FeatureDefines.xcconfig:
3318
3319 2018-10-07  Dan Bernstein  <mitz@apple.com>
3320
3321         Fixed building with the latest macOS SDK
3322
3323         * Plugins/WebNetscapePluginPackage.mm:
3324         (-[WebNetscapePluginPackage openResourceFile]):
3325         (-[WebNetscapePluginPackage closeResourceFile:]):
3326
3327 2018-10-04  Dan Bernstein  <mitz@apple.com>
3328
3329         More Carbon build-fixing.
3330
3331         * Carbon/CarbonWindowAdapter.mm:
3332         (-[CarbonWindowAdapter _destroyRealWindow:]):
3333         (-[CarbonWindowAdapter _growBoxRect]):
3334
3335 2018-10-04  Dan Bernstein  <mitz@apple.com>
3336
3337         Retried to fix 32-bit macOS builds after r236846.
3338
3339         * WebView/WebHTMLView.mm:
3340         (-[WebHTMLView setMarkedText:selectedRange:]):
3341
3342 2018-10-04  Dan Bernstein  <mitz@apple.com>
3343
3344         Retried to fix 32-bit macOS builds after r236846.
3345
3346         * Carbon/HIWebView.mm:
3347         (ActiveStateChanged):
3348
3349 2018-10-04  Dan Bernstein  <mitz@apple.com>
3350
3351         Tried to fix 32-bit macOS builds after r236846.
3352
3353         * Carbon/HIWebView.mm:
3354         (_NSSelectorForHICommand):
3355
3356 2018-10-04  Dan Bernstein  <mitz@apple.com>
3357
3358         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3359         https://bugs.webkit.org/show_bug.cgi?id=190250
3360
3361         Reviewed by Andy Estes.
3362
3363         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3364           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3365           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3366           an earlier line set it to YES.
3367
3368         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3369         changes below.
3370
3371         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3372           provides some missing method declarations.
3373
3374         * Misc/WebDownload.mm:
3375         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3376           a deprecated method.
3377
3378         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3379
3380         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3381           other code in the file uses a method from it.
3382
3383         * Plugins/WebBaseNetscapePluginView.mm:
3384         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3385           a deprecated method.
3386
3387         * Plugins/WebPluginController.mm:
3388         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3389           around use of a selector that may be present in some WebKit client.
3390
3391         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3392           method declarations.
3393
3394         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3395           from here.
3396
3397         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3398           missing method declarations.
3399
3400         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3401           from here.
3402
3403         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3404           call from here.
3405         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3406           an obsolete delegate method for binary compatibility.
3407         (pluginView): Ditto.
3408
3409         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3410           call from here.
3411
3412         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3413           WebDeviceOrientationProviderMock protocol.
3414
3415         * WebView/WebDeviceOrientationProviderMock.mm:
3416         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3417           main @implementation.
3418
3419         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3420           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3421
3422         * WebView/WebDynamicScrollBarsView.mm:
3423         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3424           of a deprecated method.
3425
3426         * WebView/WebHTMLView.mm:
3427         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3428           selector warning around action methods that are not declared anywhere in WebKit.
3429
3430         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3431           about implementing this deprecated method.
3432         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3433         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3434         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3435         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3436         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3437         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3438         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3439         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3440         (-[WebHTMLView doCommandBySelector:]): Ditto.
3441         (-[WebHTMLView insertText:]): Ditto.
3442
3443         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3444
3445         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3446
3447         * WebView/WebPDFView.h: Removed previewView ivar.
3448
3449         * WebView/WebPDFView.mm:
3450           Removed declaration of FileInternal category and merged its implementation with the main
3451           implementation.
3452         (-[WebPDFView dealloc]): Removed previewView ivar.
3453         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3454           exist in macOS versions we support.
3455         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3456         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3457           action methods internal to PDFKit.
3458         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3459         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3460
3461         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3462           call on macOS, even though in r86988 we started calling different methods on iOS.
3463
3464         * WebView/WebView.mm:
3465         - Imported headers that declare delegate methods that we call.
3466         - Removed declaration of WebFileInternal category and merged its implementation with the
3467           main implementation.
3468         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3469           category, which made them impossible to call from the main implementation. Moved those
3470           into the main implementation. One of those had to be declared in a class extension,
3471           because it is called from a method implemented in the WebPrivate category, and that
3472           category’s implementation appears first in the file.
3473
3474         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3475           around use of obsolete delegate method for binary compatibility.
3476
3477         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3478
3479 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>