Move NetworkStorageSession ownership to NetworkProcess
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-22  Alex Christensen  <achristensen@webkit.org>
2
3         Move NetworkStorageSession ownership to NetworkProcess
4         https://bugs.webkit.org/show_bug.cgi?id=193580
5
6         Reviewed by Geoff Garen.
7
8         * Misc/WebCache.mm:
9         (+[WebCache clearCachedCredentials]):
10         * Misc/WebDownload.mm:
11         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
12         * Plugins/WebBaseNetscapePluginView.mm:
13         (WebKit::getAuthenticationInfo):
14         * WebCoreSupport/WebFrameNetworkingContext.mm:
15         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
16         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
17         (WebFrameNetworkingContext::storageSession const):
18         * WebView/WebPreferences.mm:
19         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
20         (+[WebPreferences _clearNetworkLoaderSession]):
21         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
22
23 2019-01-22  Daniel Bates  <dabates@apple.com>
24
25         [iOS] Interpret text key commands on keydown and app key commands on keypress
26         https://bugs.webkit.org/show_bug.cgi?id=192897
27         <rdar://problem/46857378>
28
29         Reviewed by Brent Fulgham.
30
31         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
32         is false) and keypress (isCharEvent is true), respectively.
33
34         * WebView/WebHTMLView.mm:
35         (-[WebHTMLView _handleEditingKeyEvent:]):
36
37 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
38
39         [css-logical] Implement flow-relative margin, padding and border shorthands
40         https://bugs.webkit.org/show_bug.cgi?id=188697
41
42         Reviewed by Simon Fraser and Antti Koivisto.
43
44         Add CSSLogicalEnabled runtime flag.
45
46         * WebView/WebPreferenceKeysPrivate.h:
47         * WebView/WebPreferences.mm:
48         (+[WebPreferences initialize]):
49         (-[WebPreferences cssLogicalEnabled]):
50         (-[WebPreferences setCSSLogicalEnabled:]):
51         * WebView/WebPreferencesPrivate.h:
52         * WebView/WebView.mm:
53         (-[WebView _preferencesChanged:]):
54
55 2019-01-15  Darin Adler  <darin@apple.com>
56
57         Use references rather than pointers for register/unregister functions, and more
58         https://bugs.webkit.org/show_bug.cgi?id=175028
59
60         Reviewed by Daniel Bates.
61
62         * WebCoreSupport/WebKitFullScreenListener.mm:
63         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
64         functions in Document; pass a reference.
65         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
66         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
67         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
68         * WebView/WebFullScreenController.mm:
69         (-[WebFullScreenController enterFullScreen:]): Ditto.
70         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
71         (-[WebFullScreenController exitFullScreen]): Ditto.
72         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
73         * WebView/WebFullScreenController.mm:
74         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
75
76 2019-01-12  Dan Bernstein  <mitz@apple.com>
77
78         [Cocoa] Avoid importing directly from subumbrella frameworks
79         https://bugs.webkit.org/show_bug.cgi?id=186016
80         <rdar://problem/40591038>
81
82         Reviewed by Sam Weinig.
83
84         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
85         * Carbon/CarbonWindowAdapter.mm: Ditto.
86         * Carbon/CarbonWindowFrame.m: Ditto.
87         * Carbon/HIViewAdapter.h: Ditto.
88         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
89           OTHER_CFLAGS_COCOA_TOUCH_NO.
90         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
91         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
92         * WebView/WebPDFView.h: Ditto.
93
94 2019-01-20  Antoine Quint  <graouts@apple.com>
95
96         Add a POINTER_EVENTS feature flag
97         https://bugs.webkit.org/show_bug.cgi?id=193577
98         <rdar://problem/47408511>
99
100         Unreviewed. Also enable Pointer Events for iosmac.
101
102         * Configurations/FeatureDefines.xcconfig:
103
104 2019-01-19  Antoine Quint  <graouts@apple.com>
105
106         Add a POINTER_EVENTS feature flag
107         https://bugs.webkit.org/show_bug.cgi?id=193577
108
109         Reviewed by Dean Jackson.
110
111         * Configurations/FeatureDefines.xcconfig:
112
113 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
114
115         Revert r238815, it broke WK1 video fullscreen on Mac
116         https://bugs.webkit.org/show_bug.cgi?id=193586
117         <rdar://problem/47358941>
118
119         Reviewed by Jer Noble.
120
121         * WebView/WebVideoFullscreenController.h: Added.
122         * WebView/WebVideoFullscreenController.mm: Added.
123         (SOFT_LINK_CLASS):
124         (-[WebVideoFullscreenController init]):
125         (-[WebVideoFullscreenController dealloc]):
126         (-[WebVideoFullscreenController fullscreenWindow]):
127         (-[WebVideoFullscreenController windowDidLoad]):
128         (-[WebVideoFullscreenController videoElement]):
129         (-[WebVideoFullscreenController setVideoElement:]):
130         (-[WebVideoFullscreenController clearFadeAnimation]):
131         (-[WebVideoFullscreenController windowDidExitFullscreen]):
132         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
133         (-[WebVideoFullscreenController videoElementRect]):
134         (-[WebVideoFullscreenController applicationDidResignActive:]):
135         (frameExpandedToRatioOfFrame):
136         (createBackgroundFullscreenWindow):
137         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
138         (-[WebVideoFullscreenController enterFullscreen:]):
139         (-[WebVideoFullscreenController exitFullscreen]):
140         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
141         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
142         (-[WebVideoFullscreenController _requestExit]):
143         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
144         (-[WebVideoFullscreenController requestExitFullscreen]):
145         (-[WebVideoFullscreenController fadeHUDIn]):
146         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
147         (-[WebVideoFullscreenController rateChanged:]):
148         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
149         (-[WebVideoFullscreenWindow dealloc]):
150         (-[WebVideoFullscreenWindow resignFirstResponder]):
151         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
152         (-[WebVideoFullscreenWindow mouseDown:]):
153         (-[WebVideoFullscreenWindow cancelOperation:]):
154         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
155         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
156         (-[WebVideoFullscreenWindow animationDidEnd:]):
157         (-[WebVideoFullscreenWindow mouseMoved:]):
158         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
159         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
160         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
161         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
162         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
163         (-[WebVideoFullscreenHUDWindow center]):
164         (-[WebVideoFullscreenHUDWindow keyDown:]):
165         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
166         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
167         (-[WebVideoFullscreenHUDWindowController init]):
168         (-[WebVideoFullscreenHUDWindowController dealloc]):
169         (-[WebVideoFullscreenHUDWindowController setArea:]):
170         (-[WebVideoFullscreenHUDWindowController keyDown:]):
171         (-[WebVideoFullscreenHUDWindowController delegate]):
172         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
173         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
174         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
175         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
176         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
177         (-[WebVideoFullscreenHUDWindowController closeWindow]):
178         (createMediaUIControl):
179         (createControlWithMediaUIControlType):
180         (createTimeTextField):
181         (createMediaUIBackgroundView):
182         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
183         (-[WebVideoFullscreenHUDWindowController updateVolume]):
184         (-[WebVideoFullscreenHUDWindowController updateTime]):
185         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
186         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
187         (-[WebVideoFullscreenHUDWindowController currentTime]):
188         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
189         (-[WebVideoFullscreenHUDWindowController duration]):
190         (-[WebVideoFullscreenHUDWindowController maxVolume]):
191         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
192         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
193         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
194         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
195         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
196         (-[WebVideoFullscreenHUDWindowController volume]):
197         (-[WebVideoFullscreenHUDWindowController setVolume:]):
198         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
199         (-[WebVideoFullscreenHUDWindowController updateRate]):
200         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
201         (-[WebVideoFullscreenHUDWindowController playing]):
202         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
203         (timeToString):
204         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
205         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
206         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
207         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
208         (-[WebVideoFullscreenHUDWindowController rewind:]):
209         (-[WebVideoFullscreenHUDWindowController fastForward:]):
210         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
211         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
212         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
213         * WebView/WebView.mm:
214         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
215         (-[WebView _exitVideoFullscreen]):
216
217 2019-01-18  Tim Horton  <timothy_horton@apple.com>
218
219         Get rid of ADVANCED_SPELL_CHECKING
220         https://bugs.webkit.org/show_bug.cgi?id=193592
221
222         Reviewed by Wenson Hsieh.
223
224         * WebCoreSupport/WebEditorClient.mm:
225         (insertionPointFromCurrentSelection):
226         (WebEditorClient::checkTextOfParagraph):
227         (WebEditorClient::getGuessesForWord):
228         (WebEditorClient::requestCandidatesForSelection):
229         (WebEditorClient::requestCheckingOfString):
230         * WebView/WebHTMLView.mm:
231         (-[WebHTMLView insertText:]):
232
233 2019-01-18  Jer Noble  <jer.noble@apple.com>
234
235         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
236         https://bugs.webkit.org/show_bug.cgi?id=189553
237
238         Reviewed by Tim Horton.
239
240         * Configurations/Base.xcconfig:
241         * Configurations/SDKVariant.xcconfig: Added.
242         * Configurations/WebKitLegacy.xcconfig:
243
244 2019-01-18  David Kilzer  <ddkilzer@apple.com>
245
246         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
247         <https://webkit.org/b/193568>
248         <rdar://problem/47381130>
249
250         Reviewed by Alex Christensen.
251
252         * WebView/WebView.mm:
253         - Remove unused soft-linking macros.
254         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
255         (-[WebUITextIndicatorData initWithImage:scale:]):
256         - Update to use exported PAL functions.
257
258 2019-01-17  Truitt Savell  <tsavell@apple.com>
259
260         Unreviewed, rolling out r240124.
261
262         This commit broke an internal build.
263
264         Reverted changeset:
265
266         "SDK_VARIANT build destinations should be separate from non-
267         SDK_VARIANT builds"
268         https://bugs.webkit.org/show_bug.cgi?id=189553
269         https://trac.webkit.org/changeset/240124
270
271 2019-01-17  Jer Noble  <jer.noble@apple.com>
272
273         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
274         https://bugs.webkit.org/show_bug.cgi?id=189553
275
276         Reviewed by Tim Horton.
277
278         * Configurations/Base.xcconfig:
279         * Configurations/SDKVariant.xcconfig: Added.
280         * Configurations/WebKitLegacy.xcconfig:
281
282 2019-01-17  Alex Christensen  <achristensen@webkit.org>
283
284         Stop using NetworkStorageSession::storageSession in WebCore
285         https://bugs.webkit.org/show_bug.cgi?id=193529
286
287         Reviewed by Tim Horton.
288
289         * Misc/WebCache.mm:
290         (+[WebCache addImageToCache:forURL:forFrame:]):
291         * WebView/WebView.mm:
292         (-[WebView _commonInitializationWithFrameName:groupName:]):
293         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
294
295 2019-01-15  Alex Christensen  <achristensen@webkit.org>
296
297         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
298         https://bugs.webkit.org/show_bug.cgi?id=193368
299
300         Reviewed by Geoff Garen.
301
302         * Misc/WebCache.mm:
303         (+[WebCache clearCachedCredentials]):
304         * Misc/WebDownload.mm:
305         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
306         * Plugins/WebBaseNetscapePluginView.mm:
307         (WebKit::getAuthenticationInfo):
308
309 2019-01-15  Alex Christensen  <achristensen@webkit.org>
310
311         Stop using CookiesStrategy
312         https://bugs.webkit.org/show_bug.cgi?id=161106
313
314         Reviewed by Don Olmstead and Antti Koivisto.
315
316         * Misc/WebCache.mm:
317         (+[WebCache addImageToCache:forURL:forFrame:]):
318         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
319         (WebKit::NetscapePluginInstanceProxy::getCookies):
320         (WebKit::NetscapePluginInstanceProxy::setCookies):
321         * Plugins/WebNetscapePluginView.mm:
322         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
323         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
324         * WebCoreSupport/WebPlatformStrategies.h:
325         * WebCoreSupport/WebPlatformStrategies.mm:
326         (WebPlatformStrategies::createCookiesStrategy): Deleted.
327         (WebPlatformStrategies::cookiesForDOM): Deleted.
328         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
329         (WebPlatformStrategies::cookiesEnabled): Deleted.
330         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
331         (WebPlatformStrategies::getRawCookies): Deleted.
332         (WebPlatformStrategies::deleteCookie): Deleted.
333         * WebView/WebView.mm:
334         (-[WebView _commonInitializationWithFrameName:groupName:]):
335         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
336
337 2019-01-15  Tim Horton  <timothy_horton@apple.com>
338
339         Cannot tab out of WKWebView on macOS
340         https://bugs.webkit.org/show_bug.cgi?id=161448
341         <rdar://problem/28100085>
342
343         Reviewed by Dean Jackson.
344
345         * WebCoreSupport/WebChromeClient.mm:
346         * WebView/WebView.mm:
347         Make use of SPI headers.
348
349 2019-01-14  Commit Queue  <commit-queue@webkit.org>
350
351         Unreviewed, rolling out r239901, r239909, r239910, r239912,
352         r239913, and r239914.
353         https://bugs.webkit.org/show_bug.cgi?id=193407
354
355         These revisions caused an internal failure (Requested by
356         Truitt on #webkit).
357
358         Reverted changesets:
359
360         "[Cocoa] Avoid importing directly from subumbrella frameworks"
361         https://bugs.webkit.org/show_bug.cgi?id=186016
362         https://trac.webkit.org/changeset/239901
363
364         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
365         https://trac.webkit.org/changeset/239909
366
367         "Tried to fix the build."
368         https://trac.webkit.org/changeset/239910
369
370         "Fixed iOS builds after r239910."
371         https://trac.webkit.org/changeset/239912
372
373         "More build fixing."
374         https://trac.webkit.org/changeset/239913
375
376         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
377         https://trac.webkit.org/changeset/239914
378
379 2019-01-14  Mark Lam  <mark.lam@apple.com>
380
381         Re-enable ability to build --cloop builds.
382         https://bugs.webkit.org/show_bug.cgi?id=192955
383         <rdar://problem/46882363>
384
385         Reviewed by Saam barati and Keith Miller.
386
387         * Configurations/FeatureDefines.xcconfig:
388
389 2019-01-13  Dan Bernstein  <mitz@apple.com>
390
391         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
392
393         Patch by Keith Rollin.
394
395         * WebView/PDFViewSPI.h:
396
397 2019-01-12  Timothy Hatcher  <timothy@apple.com>
398
399         Have prefers-color-scheme: light always match on macOS versions before Mojave.
400         https://bugs.webkit.org/show_bug.cgi?id=191655
401         rdar://problem/46074680
402
403         Reviewed by Megan Gardner.
404
405         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
406         * WebView/WebView.mm:
407         (-[WebView _effectiveAppearanceIsDark]):
408
409 2019-01-12  Dan Bernstein  <mitz@apple.com>
410
411         [Cocoa] Avoid importing directly from subumbrella frameworks
412         https://bugs.webkit.org/show_bug.cgi?id=186016
413         <rdar://problem/40591038>
414
415         Reviewed by Sam Weinig.
416
417         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
418         * Carbon/CarbonWindowAdapter.mm: Ditto.
419         * Carbon/CarbonWindowFrame.m: Ditto.
420         * Carbon/HIViewAdapter.h: Ditto.
421         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
422           OTHER_CFLAGS_COCOA_TOUCH_NO.
423         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
424         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
425         * WebView/WebPDFView.h: Ditto.
426
427 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
428
429         Enable visual viewport API by default
430         https://bugs.webkit.org/show_bug.cgi?id=193376
431
432         Reviewed by Simon Fraser.
433
434         * WebView/WebPreferences.mm:
435         (+[WebPreferences initialize]):
436
437 2019-01-11  John Wilander  <wilander@apple.com>
438
439         Compile out Web API Statistics Collection
440         https://bugs.webkit.org/show_bug.cgi?id=193370
441         <rdar://problem/45388584>
442
443         Reviewed by Brent Fulgham.
444
445         * Configurations/FeatureDefines.xcconfig:
446             Defined ENABLE_WEB_API_STATISTICS, off by default.
447
448 2019-01-08  Alex Christensen  <achristensen@webkit.org>
449
450         Stop using NetworkStorageSession in WebProcess
451         https://bugs.webkit.org/show_bug.cgi?id=193236
452
453         Reviewed by Don Olmstead.
454
455         * WebCoreSupport/WebFrameNetworkingContext.h:
456         * WebCoreSupport/WebFrameNetworkingContext.mm:
457         (WebFrameNetworkingContext::storageSession const):
458         * WebCoreSupport/WebPlatformStrategies.h:
459         * WebCoreSupport/WebPlatformStrategies.mm:
460         (WebPlatformStrategies::cookiesForDOM):
461         (WebPlatformStrategies::setCookiesFromDOM):
462         (WebPlatformStrategies::cookiesEnabled):
463         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
464         (WebPlatformStrategies::getRawCookies):
465         (WebPlatformStrategies::deleteCookie):
466         * WebView/WebView.mm:
467         (-[WebView _cachedResponseForURL:]):
468         (-[WebView _clearCredentials]):
469
470 2019-01-08  Alex Christensen  <achristensen@webkit.org>
471
472         Unreviewed, rolling out r239727.
473
474         Broke API tests
475
476         Reverted changeset:
477
478         "Stop using NetworkStorageSession in WebProcess"
479         https://bugs.webkit.org/show_bug.cgi?id=193236
480         https://trac.webkit.org/changeset/239727
481
482 2019-01-08  Alex Christensen  <achristensen@webkit.org>
483
484         Stop using NetworkStorageSession in WebProcess
485         https://bugs.webkit.org/show_bug.cgi?id=193236
486
487         Reviewed by Don Olmstead.
488
489         * WebCoreSupport/WebFrameNetworkingContext.h:
490         * WebCoreSupport/WebFrameNetworkingContext.mm:
491         (WebFrameNetworkingContext::storageSession const):
492         * WebView/WebView.mm:
493         (-[WebView _cachedResponseForURL:]):
494         (-[WebView _clearCredentials]):
495
496 2019-01-07  David Kilzer  <ddkilzer@apple.com>
497
498         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
499         <https://webkit.org/b/193056>
500
501         Reviewed by Alex Christensen.
502
503         * Plugins/Hosted/NetscapePluginHostProxy.h:
504         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
505         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
506         (WebKit::NetscapePluginInstanceProxy::enumerate):
507         (WebKit::NetscapePluginInstanceProxy::marshalValue):
508         (WebKit::NetscapePluginInstanceProxy::marshalValues):
509         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
510         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
511         * Plugins/Hosted/ProxyInstance.mm:
512         (WebKit::ProxyInstance::invoke):
513         * WebCoreSupport/WebGeolocationClient.mm:
514         * WebView/WebDataSource.mm:
515         (-[WebDataSource _receivedData:]):
516         * WebView/WebView.mm:
517         (-[WebView _cachedResponseForURL:]):
518         - Remove '*' from RetainPtr<> type.
519
520 2019-01-04  Alex Christensen  <achristensen@webkit.org>
521
522         Progress towards fixing Mac CMake build
523         https://bugs.webkit.org/show_bug.cgi?id=193105
524
525         Reviewed by Don Olmstead.
526
527         * WebKitPrefix.h:
528
529 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
530
531         Web Inspector: Use save sheet instead of dialog where possible
532         https://bugs.webkit.org/show_bug.cgi?id=193160
533         <rdar://problem/37399759>
534
535         Reviewed by Devin Rousso.
536
537         * WebCoreSupport/WebInspectorClient.mm:
538         (WebInspectorFrontendClient::save):
539
540 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
541
542         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
543         https://bugs.webkit.org/show_bug.cgi?id=193129
544
545         Reviewed by Tim Horton.
546
547         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
548
549         * WebCoreSupport/WebEditorClient.mm:
550         (WebEditorClient::registerUndoOrRedoStep):
551         (undoNameForEditAction): Deleted.
552
553 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
554
555         Add support for using the current text selection as the find string on iOS
556         https://bugs.webkit.org/show_bug.cgi?id=193034
557         <rdar://problem/45138739>
558
559         Reviewed by Tim Horton.
560
561         Add a method stub for WebKitLegacy.
562
563         * WebCoreSupport/WebEditorClient.h:
564
565 2019-01-01  Jeff Miller  <jeffm@apple.com>
566
567         Update user-visible copyright strings to include 2019
568         https://bugs.webkit.org/show_bug.cgi?id=192811
569
570         Reviewed by Mark Lam.
571
572         * Info.plist:
573
574 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
575
576         Use Ref<> as much as possible
577         https://bugs.webkit.org/show_bug.cgi?id=192808
578
579         Reviewed by Alex Christensen.
580
581         * DOM/DOM.mm:
582         (-[DOMNode getPreviewSnapshotImage:andRects:]):
583         * Plugins/Hosted/NetscapePluginHostManager.mm:
584         (WebKit::NetscapePluginHostManager::instantiatePlugin):
585         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
586         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
587         (WebKit::NetscapePluginInstanceProxy::loadRequest):
588         * Plugins/WebNetscapePluginView.mm:
589         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
590         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
591         * WebCoreSupport/WebContextMenuClient.mm:
592         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
593         * WebCoreSupport/WebFrameLoaderClient.mm:
594         (WebFrameLoaderClient::transitionToCommittedForNewPage):
595         * WebView/WebFrame.mm:
596         (-[WebFrame getDictationResultRanges:andMetadatas:]):
597         * WebView/WebHTMLView.mm:
598         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
599         * WebView/WebView.mm:
600         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
601         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
602
603 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
604
605         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
606         https://bugs.webkit.org/show_bug.cgi?id=192821
607
608         Reviewed by Chris Dumez.
609
610         When a window becomes occluded, the window server informs the application.
611         This should be used to suspend any work that is not visible by the user.
612
613         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
614         In some cases, that lead to performance impact (see radar).
615
616         This patch adds an observer for the occlusion notification. I tried to stick
617         with the same names used by WebKit2.
618
619         * WebView/WebView.mm:
620         (-[WebView _isViewVisible]):
621         (-[WebView addWindowObserversForWindow:]):
622         (-[WebView removeWindowObservers]):
623         (-[WebView _windowDidChangeOcclusionState:]):
624
625 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
626
627         [WebAuthN] Add a runtime flag for local authenticator
628         https://bugs.webkit.org/show_bug.cgi?id=192792
629         <rdar://problem/46798738>
630
631         Reviewed by Brent Fulgham.
632
633         * WebView/WebPreferenceKeysPrivate.h:
634         * WebView/WebPreferences.mm:
635         (+[WebPreferences initialize]):
636         (-[WebPreferences webAuthenticationEnabled]): Deleted.
637         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
638         * WebView/WebPreferencesPrivate.h:
639         * WebView/WebView.mm:
640         (-[WebView _preferencesChanged:]):
641
642 2018-12-20  Chris Dumez  <cdumez@apple.com>
643
644         Use Optional::valueOr() instead of Optional::value_or()
645         https://bugs.webkit.org/show_bug.cgi?id=192933
646
647         Reviewed by Geoffrey Garen.
648
649         * WebCoreSupport/WebSecurityOrigin.mm:
650         (-[WebSecurityOrigin port]):
651
652 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
653
654         Unreviewed, rolling out r239417.
655
656         Introduced two API test failures on macOS.
657
658         Reverted changeset:
659
660         "<rdar://problem/46194315> macOS: WebKit1 does not handle
661         occlusion changes"
662         https://bugs.webkit.org/show_bug.cgi?id=192821
663         https://trac.webkit.org/changeset/239417
664
665 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
666
667         WKWebView default UA doesn't freeze the build number
668         https://bugs.webkit.org/show_bug.cgi?id=192809
669         <rdar://problem/44687185>
670
671         Reviewed by Andy Estes.
672
673         Always reports the frozen build number.
674
675         * WebView/WebView.mm:
676         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
677         actual build number through this method call.
678         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
679
680 2018-12-19  Chris Dumez  <cdumez@apple.com>
681
682         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
683         https://bugs.webkit.org/show_bug.cgi?id=192728
684         <rdar://problem/46746779>
685
686         Reviewed by Geoff Garen.
687
688         * DOM/*:
689         * Plugins/*:
690         * WebCoreSupport/*:
691         * WebView/*:
692
693 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
694
695         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
696         https://bugs.webkit.org/show_bug.cgi?id=192821
697
698         Reviewed by Chris Dumez.
699
700         When a window becomes occluded, the window server informs the application.
701         This should be used to suspend any work that is not visible by the user.
702
703         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
704         In some cases, that lead to performance impact (see radar).
705
706         This patch adds an observer for the occlusion notification. I tried to stick
707         with the same names used by WebKit2.
708
709         * WebView/WebView.mm:
710         (-[WebView _isViewVisible]):
711         (-[WebView addWindowObserversForWindow:]):
712         (-[WebView removeWindowObservers]):
713         (-[WebView _windowDidChangeOcclusionState:]):
714
715 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
716
717         Allow clients to set the navigator platform
718         https://bugs.webkit.org/show_bug.cgi?id=192735
719
720         Reviewed by Tim Horton.
721
722         Add stubs to fill out the added functionality in FrameLoaderClient.
723
724         * WebCoreSupport/WebFrameLoaderClient.h:
725         * WebCoreSupport/WebFrameLoaderClient.mm:
726         (WebFrameLoaderClient::navigatorPlatform):
727
728 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
729
730         offsetLeft and offsetParent should adjust across shadow boundaries
731         https://bugs.webkit.org/show_bug.cgi?id=157437
732         <rdar://problem/26154021>
733
734         Reviewed by Simon Fraser.
735
736         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
737
738         * DOM/DOMElement.mm:
739         (-[DOMElement offsetLeft]):
740         (-[DOMElement offsetTop]):
741         (-[DOMElement offsetParent]):
742
743 2018-12-17  Zalan Bujtas  <zalan@apple.com>
744
745         Unreviewed build fix.
746
747         * WebView/WebFrame.mm:
748         (-[WebFrame getDictationResultRanges:andMetadatas:]):
749
750 2018-12-15  Darin Adler  <darin@apple.com>
751
752         Use warning-ignoring macros more consistently and simply
753         https://bugs.webkit.org/show_bug.cgi?id=192743
754
755         Reviewed by Mark Lam.
756
757         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
758         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
759         compilers in Objective-C++ code.
760
761         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
762         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
763         accomodate non-clang compilers here. Also use #pragma once, add a missing
764         "explicit" and fix conditionals.
765
766 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
767
768         Make TextInputController.legacyAttributedString take DOM nodes and offsets
769         https://bugs.webkit.org/show_bug.cgi?id=192653
770
771         Reviewed by Wenson Hsieh.
772
773         * WebView/WebHTMLView.mm:
774         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
775
776 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
777
778         Implement feature flag for CSS Typed OM
779         https://bugs.webkit.org/show_bug.cgi?id=192610
780
781         Reviewed by Ryosuke Niwa.
782
783         * Configurations/FeatureDefines.xcconfig:
784
785 2018-12-11  Tim Horton  <timothy_horton@apple.com>
786
787         WebCore shouldn't have a Objective-C class named NSCursor
788         https://bugs.webkit.org/show_bug.cgi?id=192602
789         <rdar://problem/46615532>
790
791         Reviewed by Wenson Hsieh.
792
793         * WebView/WebFrameView.mm:
794         (-[WebFrameView keyDown:keyDown:]):
795         * WebView/WebHTMLView.mm:
796         (-[WebHTMLView keyDown:]):
797         (-[WebHTMLView performKeyEquivalent:]):
798         Only use NSCursor on macOS.
799
800 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
801
802         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
803         https://bugs.webkit.org/show_bug.cgi?id=192573
804
805         Reviewed by Simon Fraser.
806
807         * Configurations/FeatureDefines.xcconfig:
808
809 2018-12-10  Antti Koivisto  <antti@apple.com>
810
811         Rename "forced style recalc" to "full style rebuild"
812         https://bugs.webkit.org/show_bug.cgi?id=192572
813
814         Reviewed by Zalan Bujtas.
815
816         * WebView/WebHTMLView.mm:
817         (-[WebHTMLView setNeedsToApplyStyles:]):
818
819 2018-12-10  Darin Adler  <darin@apple.com>
820
821         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
822         https://bugs.webkit.org/show_bug.cgi?id=192533
823         rdar://problem/45732710
824
825         Reviewed by Anders Carlsson.
826
827         * Plugins/Hosted/NetscapePluginHostProxy.mm:
828         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
829
830 2018-12-10  Darin Adler  <darin@apple.com>
831
832         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
833         https://bugs.webkit.org/show_bug.cgi?id=192532
834         rdar://problem/45731047
835
836         Reviewed by Chris Dumez.
837
838         * Plugins/Hosted/NetscapePluginHostManager.mm:
839         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
840         * Plugins/Hosted/NetscapePluginHostProxy.mm:
841         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
842
843 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
844
845         Turn WritingDirection into an enum class
846         https://bugs.webkit.org/show_bug.cgi?id=192401
847         Work towards <rdar://problem/42075638>
848
849         Reviewed by Dan Bernstein.
850
851         Change WritingDirection from an enum to an enum class. No change in behavior.
852
853         * WebView/WebHTMLView.mm:
854         (-[WebHTMLView toggleBaseWritingDirection:]):
855         (-[WebHTMLView changeBaseWritingDirection:]):
856         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
857
858 2018-12-03  Alex Christensen  <achristensen@webkit.org>
859
860         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
861         https://bugs.webkit.org/show_bug.cgi?id=192272
862
863         Reviewed by Brady Eidson.
864
865         * WebCoreSupport/WebFrameLoaderClient.h:
866         * WebCoreSupport/WebFrameLoaderClient.mm:
867         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
868
869 2018-12-03  Jer Noble  <jer.noble@apple.com>
870
871         Get rid of old, dead Mac video fullscreen code.
872         https://bugs.webkit.org/show_bug.cgi?id=192315
873
874         Reviewed by Eric Carlson.
875
876         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
877         is no longer supported in the Mac port.
878
879         * WebView/WebVideoFullscreenController.h: Removed.
880         * WebView/WebVideoFullscreenController.mm: Removed.
881         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
882         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
883         * WebView/WebView.mm:
884         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
885         (-[WebView _exitVideoFullscreen]):
886
887 2018-12-03  Daniel Bates  <dabates@apple.com>
888
889         [iOS] Do not handle key events that are key commands
890         https://bugs.webkit.org/show_bug.cgi?id=191608
891         <rdar://problem/46046013>
892
893         Reviewed by Ryosuke Niwa.
894
895         A key down event may be associated with a key command. If it is then we want to execute the
896         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
897         event as a key command to find out.
898
899         * WebView/WebHTMLView.mm:
900         (-[WebHTMLView _handleEditingKeyEvent:]):
901
902 2018-12-02  Zalan Bujtas  <zalan@apple.com>
903
904         Add a runtime feature flag for LayoutFormattingContext.
905         https://bugs.webkit.org/show_bug.cgi?id=192280
906
907         Reviewed by Simon Fraser.
908
909         * Configurations/FeatureDefines.xcconfig:
910
911 2018-11-30  Alex Christensen  <achristensen@webkit.org>
912
913         Move URL from WebCore to WTF
914         https://bugs.webkit.org/show_bug.cgi?id=190234
915
916         Reviewed by Keith Miller.
917
918         * DOM/DOMAttr.mm:
919         * DOM/DOMBlob.mm:
920         * DOM/DOMCSSCharsetRule.mm:
921         * DOM/DOMCSSImportRule.mm:
922         * DOM/DOMCSSMediaRule.mm:
923         * DOM/DOMCSSPageRule.mm:
924         * DOM/DOMCSSPrimitiveValue.mm:
925         * DOM/DOMCSSRule.mm:
926         * DOM/DOMCSSStyleDeclaration.mm:
927         * DOM/DOMCSSStyleRule.mm:
928         * DOM/DOMCSSStyleSheet.mm:
929         * DOM/DOMCSSValue.mm:
930         * DOM/DOMCharacterData.mm:
931         * DOM/DOMCounter.mm:
932         * DOM/DOMDocument.mm:
933         * DOM/DOMDocumentFragment.mm:
934         * DOM/DOMDocumentType.mm:
935         * DOM/DOMEvent.mm:
936         * DOM/DOMFile.mm:
937         * DOM/DOMHTMLAnchorElement.mm:
938         * DOM/DOMHTMLAppletElement.mm:
939         * DOM/DOMHTMLAreaElement.mm:
940         * DOM/DOMHTMLBRElement.mm:
941         * DOM/DOMHTMLBaseElement.mm:
942         * DOM/DOMHTMLBaseFontElement.mm:
943         * DOM/DOMHTMLBodyElement.mm:
944         * DOM/DOMHTMLButtonElement.mm:
945         * DOM/DOMHTMLCanvasElement.mm:
946         * DOM/DOMHTMLCollection.mm:
947         * DOM/DOMHTMLDivElement.mm:
948         * DOM/DOMHTMLDocument.mm:
949         * DOM/DOMHTMLElement.mm:
950         * DOM/DOMHTMLEmbedElement.mm:
951         * DOM/DOMHTMLFieldSetElement.mm:
952         * DOM/DOMHTMLFontElement.mm:
953         * DOM/DOMHTMLFormElement.mm:
954         * DOM/DOMHTMLFrameElement.mm:
955         * DOM/DOMHTMLFrameSetElement.mm:
956         * DOM/DOMHTMLHRElement.mm:
957         * DOM/DOMHTMLHeadElement.mm:
958         * DOM/DOMHTMLHeadingElement.mm:
959         * DOM/DOMHTMLHtmlElement.mm:
960         * DOM/DOMHTMLIFrameElement.mm:
961         * DOM/DOMHTMLImageElement.mm:
962         * DOM/DOMHTMLInputElement.mm:
963         * DOM/DOMHTMLLIElement.mm:
964         * DOM/DOMHTMLLabelElement.mm:
965         * DOM/DOMHTMLLegendElement.mm:
966         * DOM/DOMHTMLLinkElement.mm:
967         * DOM/DOMHTMLMapElement.mm:
968         * DOM/DOMHTMLMarqueeElement.mm:
969         * DOM/DOMHTMLMediaElement.mm:
970         * DOM/DOMHTMLMetaElement.mm:
971         * DOM/DOMHTMLModElement.mm:
972         * DOM/DOMHTMLOListElement.mm:
973         * DOM/DOMHTMLObjectElement.mm:
974         * DOM/DOMHTMLOptGroupElement.mm:
975         * DOM/DOMHTMLOptionElement.mm:
976         * DOM/DOMHTMLOptionsCollection.mm:
977         * DOM/DOMHTMLParagraphElement.mm:
978         * DOM/DOMHTMLParamElement.mm:
979         * DOM/DOMHTMLQuoteElement.mm:
980         * DOM/DOMHTMLScriptElement.mm:
981         * DOM/DOMHTMLSelectElement.mm:
982         * DOM/DOMHTMLStyleElement.mm:
983         * DOM/DOMHTMLTableCaptionElement.mm:
984         * DOM/DOMHTMLTableCellElement.mm:
985         * DOM/DOMHTMLTableColElement.mm:
986         * DOM/DOMHTMLTableElement.mm:
987         * DOM/DOMHTMLTableRowElement.mm:
988         * DOM/DOMHTMLTableSectionElement.mm:
989         * DOM/DOMHTMLTitleElement.mm:
990         * DOM/DOMHTMLUListElement.mm:
991         * DOM/DOMHTMLVideoElement.mm:
992         * DOM/DOMKeyboardEvent.mm:
993         * DOM/DOMMediaList.mm:
994         * DOM/DOMMouseEvent.mm:
995         * DOM/DOMMutationEvent.mm:
996         * DOM/DOMNamedNodeMap.mm:
997         * DOM/DOMProcessingInstruction.mm:
998         * DOM/DOMRange.mm:
999         * DOM/DOMStyleSheet.mm:
1000         * DOM/DOMText.mm:
1001         * DOM/DOMTextEvent.mm:
1002         * DOM/DOMTokenList.mm:
1003         * DOM/DOMUIEvent.mm:
1004         * DOM/DOMXPathResult.mm:
1005         * History/WebHistoryItem.mm:
1006         * Misc/WebNSURLExtras.mm:
1007         (-[NSURL _web_userVisibleString]):
1008         (-[NSURL _web_URLByRemovingUserInfo]):
1009         (-[NSURL _web_dataForURLComponentType:]):
1010         (-[NSURL _web_schemeData]):
1011         (-[NSURL _web_hostData]):
1012         * Misc/WebUserContentURLPattern.mm:
1013         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1014         * Plugins/WebNetscapePluginStream.h:
1015         (WebNetscapePluginStream::setRequestURL):
1016         * WebCoreSupport/WebChromeClient.h:
1017         * WebCoreSupport/WebChromeClient.mm:
1018         (WebChromeClient::signedPublicKeyAndChallengeString const):
1019         * WebCoreSupport/WebContextMenuClient.h:
1020         * WebCoreSupport/WebContextMenuClient.mm:
1021         * WebCoreSupport/WebDragClient.h:
1022         * WebCoreSupport/WebFrameLoaderClient.h:
1023         * WebCoreSupport/WebFrameLoaderClient.mm:
1024         (WebFrameLoaderClient::updateGlobalHistory):
1025         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1026         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1027         (WebPaymentCoordinatorClient::showPaymentUI):
1028         * WebCoreSupport/WebPlatformStrategies.h:
1029         * WebCoreSupport/WebPlatformStrategies.mm:
1030         (WebPlatformStrategies::readURLFromPasteboard):
1031         * WebCoreSupport/WebPluginInfoProvider.h:
1032         * WebCoreSupport/WebPluginInfoProvider.mm:
1033         (WebPluginInfoProvider::webVisiblePluginInfo):
1034         * WebCoreSupport/WebSecurityOrigin.mm:
1035         * WebCoreSupport/WebVisitedLinkStore.h:
1036         * WebView/WebDataSource.mm:
1037         * WebView/WebFrame.mm:
1038         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1039         * WebView/WebImmediateActionController.mm:
1040         (-[WebImmediateActionController _defaultAnimationController]):
1041         * WebView/WebPDFView.mm:
1042         * WebView/WebScriptDebugger.mm:
1043         * WebView/WebViewInternal.h:
1044
1045 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1046
1047         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1048         https://bugs.webkit.org/show_bug.cgi?id=192197
1049
1050         Reviewed by Jiewen Tan.
1051
1052         * Configurations/FeatureDefines.xcconfig:
1053         * WebCoreSupport/WebChromeClient.h:
1054         * WebCoreSupport/WebChromeClient.mm:
1055
1056 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1057
1058         Remove dead code from an earlier attempt at implementing safe browsing
1059         https://bugs.webkit.org/show_bug.cgi?id=192067
1060
1061         Reviewed by Chris Dumez.
1062
1063         * WebCoreSupport/WebFrameLoaderClient.h:
1064         * WebCoreSupport/WebFrameLoaderClient.mm:
1065         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1066
1067 2018-11-27  Mark Lam  <mark.lam@apple.com>
1068
1069         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1070         https://bugs.webkit.org/show_bug.cgi?id=192055
1071         <rdar://problem/46288783>
1072
1073         Reviewed by Saam Barati.
1074
1075         * Configurations/FeatureDefines.xcconfig:
1076
1077 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1078
1079         Make it possible to insert editable images with a gesture
1080         https://bugs.webkit.org/show_bug.cgi?id=191937
1081
1082         Reviewed by Wenson Hsieh.
1083
1084         * WebCoreSupport/WebEditorClient.mm:
1085         (undoNameForEditAction):
1086         Add a undo name.
1087
1088 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1091         https://bugs.webkit.org/show_bug.cgi?id=191945
1092
1093         Reviewed by Anders Carlsson.
1094
1095         * WebCoreSupport/WebEditorClient.mm:
1096         (undoNameForEditAction):
1097
1098 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1099
1100         Enable drag and drop support for iOSMac
1101         https://bugs.webkit.org/show_bug.cgi?id=191818
1102         <rdar://problem/43907454>
1103
1104         Reviewed by Dean Jackson.
1105
1106         * Configurations/FeatureDefines.xcconfig:
1107
1108 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1109
1110         Address post-review feedback after r238438
1111         https://bugs.webkit.org/show_bug.cgi?id=191913
1112
1113         Reviewed by Ryosuke Niwa.
1114
1115         * WebView/WebFrame.mm:
1116         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1117         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1118         * WebView/WebView.mm:
1119         (-[WebView setSelectedDOMRange:affinity:]):
1120
1121 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1122
1123         Web Inspector: "Reload Web Inspector" button no longer partially works
1124         https://bugs.webkit.org/show_bug.cgi?id=191773
1125         <rdar://problem/46139932>
1126
1127         Reviewed by Devin Rousso.
1128
1129         * WebCoreSupport/WebInspectorClient.h:
1130         * WebCoreSupport/WebInspectorClient.mm:
1131         (WebInspectorFrontendClient::reopen):
1132
1133 2018-11-17  Devin Rousso  <drousso@apple.com>
1134
1135         Web Inspector: Network: add button to show system certificate dialog
1136         https://bugs.webkit.org/show_bug.cgi?id=191458
1137         <rdar://problem/45977019>
1138
1139         Reviewed by Joseph Pecoraro.
1140
1141         * WebCoreSupport/WebInspectorClient.h:
1142         * WebCoreSupport/WebInspectorClient.mm:
1143         (WebInspectorFrontendClient::showCertificate): Added.
1144
1145         * Configurations/WebKitLegacy.xcconfig:
1146
1147 2018-11-15  Truitt Savell  <tsavell@apple.com>
1148
1149         Unreviewed, rolling out r238244.
1150
1151         Caused High Sierra test runs to fail early with 50 crashes and
1152         casued 25 API failures.
1153
1154         Reverted changeset:
1155
1156         "[css-logical] Implement flow-relative margin, padding and
1157         border shorthands"
1158         https://bugs.webkit.org/show_bug.cgi?id=188697
1159         https://trac.webkit.org/changeset/238244
1160
1161 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1162
1163         [css-logical] Implement flow-relative margin, padding and border shorthands
1164         https://bugs.webkit.org/show_bug.cgi?id=188697
1165
1166         Reviewed by Simon Fraser and Antti Koivisto.
1167
1168         Add CSSLogicalEnabled runtime flag.
1169
1170         * WebView/WebPreferenceKeysPrivate.h:
1171         * WebView/WebPreferences.mm:
1172         (+[WebPreferences initialize]):
1173         (-[WebPreferences cssLogicalEnabled]):
1174         (-[WebPreferences setCSSLogicalEnabled:]):
1175         * WebView/WebPreferencesPrivate.h:
1176         * WebView/WebView.mm:
1177         (-[WebView _preferencesChanged:]):
1178
1179 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1180
1181         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1182         https://bugs.webkit.org/show_bug.cgi?id=191612
1183
1184         Reviewed by Matt Baker.
1185
1186         * WebCoreSupport/WebInspectorClient.mm:
1187         (-[WebInspectorWindowController destroyInspectorView]):
1188
1189 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1190
1191         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1192         https://bugs.webkit.org/show_bug.cgi?id=191494
1193         <rdar://problem/45469854>
1194
1195         Reviewed by Devin Rousso.
1196
1197         * WebCoreSupport/WebInspectorClient.h:
1198         WebKitLegacy will still have remote inspection of the Page directly.
1199
1200 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1201
1202         Make compositing updates incremental
1203         https://bugs.webkit.org/show_bug.cgi?id=90342
1204
1205         Reviewed by Antti Koivisto.
1206
1207         Fix spelling error.
1208
1209         * WebView/WebView.mm:
1210         (-[WebView _setMediaLayer:forPluginView:]):
1211
1212 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1213
1214         Implement a new edit command to change the enclosing list type
1215         https://bugs.webkit.org/show_bug.cgi?id=191487
1216         <rdar://problem/45955922>
1217
1218         Reviewed by Ryosuke Niwa.
1219
1220         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1221
1222         * WebCoreSupport/WebEditorClient.mm:
1223         (undoNameForEditAction):
1224
1225 2018-11-11  Daniel Bates  <dabates@apple.com>
1226
1227         [iOS] Draw caps lock indicator in password fields
1228         https://bugs.webkit.org/show_bug.cgi?id=190565
1229         <rdar://problem/45262343>
1230
1231         Reviewed by Dean Jackson.
1232
1233         Update the caps lock state when a hardware keyboard is attached or detached.
1234
1235         * WebView/WebHTMLView.mm:
1236         (hardwareKeyboardAvailabilityChangedCallback): Added.
1237         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1238         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1239
1240 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1241
1242         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1243         https://bugs.webkit.org/show_bug.cgi?id=191492
1244
1245         Reviewed by Alex Christensen.
1246
1247         * Carbon/HIWebView.mm:
1248         * Misc/WebNSFileManagerExtras.mm:
1249         * Misc/WebNSURLExtras.mm:
1250         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1251         * Plugins/WebBasePluginPackage.mm:
1252         * Plugins/WebPluginContainerCheck.mm:
1253         * WebCoreSupport/WebCachedFramePlatformData.h:
1254         * WebCoreSupport/WebDeviceOrientationClient.mm:
1255         * WebView/WebDelegateImplementationCaching.mm:
1256         * WebView/WebHTMLView.mm:
1257         * WebView/WebPDFRepresentation.mm:
1258         * WebView/WebPolicyDelegate.mm:
1259         * WebView/WebView.mm:
1260
1261 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1262
1263         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1264         https://bugs.webkit.org/show_bug.cgi?id=191492
1265
1266         Reviewed by Alex Christensen.
1267
1268         * Carbon/HIWebView.mm:
1269         (UpdateCommandStatus):
1270         * Misc/WebNSFileManagerExtras.mm:
1271         * Misc/WebNSURLExtras.mm:
1272         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1273         * Plugins/WebBasePluginPackage.mm:
1274         * Plugins/WebPluginContainerCheck.mm:
1275         (-[WebPluginContainerCheck _continueWithPolicy:]):
1276         * WebCoreSupport/WebCachedFramePlatformData.h:
1277         (WebCachedFramePlatformData::clear):
1278         * WebCoreSupport/WebDeviceOrientationClient.mm:
1279         (WebDeviceOrientationClient::getProvider const):
1280         * WebView/WebDelegateImplementationCaching.mm:
1281         (CallDelegate):
1282         (CallDelegateReturningBoolean):
1283         (CallResourceLoadDelegateReturningBoolean):
1284         (CallFormDelegate):
1285         (CallFormDelegateReturningBoolean):
1286         * WebView/WebHTMLView.mm:
1287         * WebView/WebPDFRepresentation.mm:
1288         * WebView/WebPolicyDelegate.mm:
1289         (-[WebPolicyDecisionListener _usePolicy:]):
1290         * WebView/WebView.mm:
1291
1292 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1293
1294         Unreviewed, rolling out r238047.
1295
1296         Introduced layout test failures on iOS simulator.
1297
1298         Reverted changeset:
1299
1300         "[iOS] Draw caps lock indicator in password fields"
1301         https://bugs.webkit.org/show_bug.cgi?id=190565
1302         https://trac.webkit.org/changeset/238047
1303
1304 2018-11-09  Antti Koivisto  <antti@apple.com>
1305
1306         Use OptionSet for layout milestones
1307         https://bugs.webkit.org/show_bug.cgi?id=191470
1308
1309         Reviewed by Dean Jackson.
1310
1311         * WebCoreSupport/WebFrameLoaderClient.h:
1312         * WebCoreSupport/WebFrameLoaderClient.mm:
1313         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1314         * WebView/WebView.mm:
1315         (coreLayoutMilestones):
1316         (kitLayoutMilestones):
1317         (-[WebView _cacheFrameLoadDelegateImplementations]):
1318         * WebView/WebViewInternal.h:
1319
1320 2018-11-09  Daniel Bates  <dabates@apple.com>
1321
1322         [iOS] Draw caps lock indicator in password fields
1323         https://bugs.webkit.org/show_bug.cgi?id=190565
1324         <rdar://problem/45262343>
1325
1326         Reviewed by Dean Jackson.
1327
1328         Update the caps lock state when a hardware keyboard is attached or detached.
1329
1330         * WebView/WebHTMLView.mm:
1331         (hardwareKeyboardAvailabilityChangedCallback): Added.
1332         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1333         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1334
1335 2018-11-09  Daniel Bates  <dabates@apple.com>
1336
1337         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1338         action when forward delete is pressed outside a text field
1339         https://bugs.webkit.org/show_bug.cgi?id=190566
1340         <rdar://problem/45262367>
1341
1342         Reviewed by Wenson Hsieh.
1343
1344         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1345         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1346         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1347
1348         * WebView/WebHTMLView.mm:
1349         (-[WebHTMLView _handleEditingKeyEvent:]):
1350
1351 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1352
1353         Adopt Reveal Framework to replace Lookup
1354         https://bugs.webkit.org/show_bug.cgi?id=191097
1355         <rdar://problem/45924508>
1356
1357         Reviewed by Tim Horton.
1358
1359         Pass in what it needed to clear the textIndicators. This is better than
1360         the current notification structure.
1361
1362         * WebView/WebView.mm:
1363         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1364         (-[WebView _prepareForDictionaryLookup]):
1365
1366 2018-11-06  Justin Fan  <justin_fan@apple.com>
1367
1368         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1369         https://bugs.webkit.org/show_bug.cgi?id=191291
1370
1371         Reviewed by Myles Maxfield.
1372
1373         Properly disable WEBGPU on all non-Metal platforms for now.
1374
1375         * Configurations/FeatureDefines.xcconfig:
1376
1377 2018-11-02  Daniel Bates  <dabates@apple.com>
1378
1379         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1380         https://bugs.webkit.org/show_bug.cgi?id=190487
1381
1382         Reviewed by Tim Horton.
1383
1384         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1385         allow the default handling.
1386
1387         * WebView/WebHTMLView.mm:
1388         (-[WebHTMLView _handleEditingKeyEvent:]):
1389
1390 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1391
1392         Add a storage limit for IndexedDB
1393         https://bugs.webkit.org/show_bug.cgi?id=190598
1394         <rdar://problem/44654715>
1395
1396         Reviewed by Chris Dumez.
1397
1398         * Storage/WebDatabaseManager.mm:
1399         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1400         * Storage/WebDatabaseManagerPrivate.h:
1401
1402 2018-10-31  Antti Koivisto  <antti@apple.com>
1403
1404         Remove LayerFlushScheduler
1405         https://bugs.webkit.org/show_bug.cgi?id=191103
1406
1407         Reviewed by Anders Carlsson.
1408
1409         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1410         all the virtual cruft.
1411
1412         * WebView/WebViewData.h:
1413         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1414         (): Deleted.
1415         * WebView/WebViewData.mm:
1416         (currentRunLoop):
1417         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1418         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1419         (WebViewLayerFlushScheduler::schedule):
1420         (WebViewLayerFlushScheduler::invalidate):
1421         (WebViewLayerFlushScheduler::layerFlushCallback):
1422
1423 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1424
1425         Enable InstallAPI for iOS unconditionally
1426         https://bugs.webkit.org/show_bug.cgi?id=191043
1427         rdar://problem/32728423
1428
1429         Reviewed by Dan Bernstein.
1430
1431         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1432         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1433         shouldn't be processed by InstallAPI.
1434         * MigrateHeaders.make: Removed an obsolete workaround.
1435         * Misc/NSURLDownloadSPI.h: Added.
1436         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1437
1438 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1439
1440         Clean up some obsolete MAX_ALLOWED macros
1441         https://bugs.webkit.org/show_bug.cgi?id=190916
1442
1443         Reviewed by Tim Horton.
1444
1445         * WebView/WebHTMLView.mm:
1446         (-[WebHTMLView pressureChangeWithEvent:]):
1447         * WebView/WebPDFView.h:
1448
1449 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1450
1451         Unreviewed, rolling out r237600 and r237604.
1452         https://bugs.webkit.org/show_bug.cgi?id=191086
1453
1454         Breaks internal iOS builds (Requested by ryanhadd_ on
1455         #webkit).
1456
1457         Reverted changesets:
1458
1459         "Enable InstallAPI for iOS unconditionally"
1460         https://bugs.webkit.org/show_bug.cgi?id=191043
1461         https://trac.webkit.org/changeset/237600
1462
1463         "Build fix attempt after enabling InstallAPI for iOS."
1464         https://bugs.webkit.org/show_bug.cgi?id=191043
1465         https://trac.webkit.org/changeset/237604
1466
1467 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1468
1469         Enable InstallAPI for iOS unconditionally
1470         https://bugs.webkit.org/show_bug.cgi?id=191043
1471         rdar://problem/32728423
1472
1473         Reviewed by Dan Bernstein.
1474
1475         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1476         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1477         shouldn't be processed by InstallAPI.
1478         * MigrateHeaders.make: Removed an obsolete workaround.
1479         * Misc/NSURLDownloadSPI.h: Added.
1480         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1481
1482 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1483
1484         Modernize WebKit nibs and lprojs for localization's sake
1485         https://bugs.webkit.org/show_bug.cgi?id=190911
1486         <rdar://problem/45349466>
1487
1488         Reviewed by Dan Bernstein.
1489
1490         * Misc/WebNSControlExtras.m:
1491         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1492         NSWindow and its contents are both in the same scale space these days; avoid
1493         double-applying the scale factor, or you can't see the prompt.
1494
1495         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1496         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1497         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1498         NIB->XIB
1499
1500 2018-10-25  Antoine Quint  <graouts@apple.com>
1501
1502         [Web Animations] Turn Web Animations CSS Integration off by default
1503         https://bugs.webkit.org/show_bug.cgi?id=190901
1504
1505         Reviewed by Dean Jackson.
1506
1507         * WebView/WebPreferences.mm:
1508         (+[WebPreferences initialize]):
1509
1510 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1511
1512         Clean up some obsolete macOS version guards
1513         https://bugs.webkit.org/show_bug.cgi?id=190887
1514
1515         Reviewed by Dan Bernstein.
1516
1517         * Misc/WebNSPasteboardExtras.mm:
1518         (+[NSPasteboard _web_dragTypesForURL]):
1519         * WebCoreSupport/PopupMenuMac.mm:
1520         (PopupMenuMac::show):
1521         * WebCoreSupport/WebEditorClient.h:
1522         * WebCoreSupport/WebEditorClient.mm:
1523         (WebEditorClient::respondToChangedSelection):
1524         * WebView/WebPDFView.mm:
1525         (-[WebPDFView _clipViewForPDFDocumentView]):
1526
1527 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1528
1529         Turn on Conic Gradients
1530         https://bugs.webkit.org/show_bug.cgi?id=190810
1531
1532         Reviewed by Tim Horton.
1533
1534         * Configurations/FeatureDefines.xcconfig:
1535
1536 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1537
1538         Cleanup: MIMETypeRegistry functions
1539         https://bugs.webkit.org/show_bug.cgi?id=190838
1540
1541         Reviewed by Simon Fraser.
1542
1543         * Misc/WebNSPasteboardExtras.mm:
1544         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1545         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1546         because they were identical.
1547
1548         * WebView/WebHTMLRepresentation.mm:
1549         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1550         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1551         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1552         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1553         * WebView/WebView.mm:
1554         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1555         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1556         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1557
1558 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1559
1560         Fix false positive leaks when using custom -init methods that don't start with -init
1561         <https://webkit.org/b/190818>
1562         <rdar://problem/45476042>
1563
1564         Reviewed by Dan Bernstein.
1565
1566         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1567         it is accessible by both categories.
1568         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1569         NSError (WebKitInternal) category.  Add attribute to make this
1570         behave like an -init method.
1571         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1572         NSError (WebKitInternal) category.  Modernize method.  Replace
1573         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1574
1575 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1576
1577         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1578         https://bugs.webkit.org/show_bug.cgi?id=190729
1579
1580         Reviewed by Tim Horton.
1581
1582         * DOM/DOM.mm:
1583         (-[DOMNode boundingBox]):
1584         * DOM/DOMElement.mm:
1585         * DOM/DOMHTML.mm:
1586         * DOM/DOMInternal.mm:
1587         * DOM/DOMUIKitExtensions.mm:
1588         * DOM/WebDOMOperations.mm:
1589         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1590         * DefaultDelegates/WebDefaultEditingDelegate.m:
1591         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1592         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1593         * DefaultDelegates/WebDefaultUIDelegate.h:
1594         * DefaultDelegates/WebDefaultUIDelegate.mm:
1595         (-[WebDefaultUIDelegate webViewClose:]):
1596         (-[WebDefaultUIDelegate webViewFocus:]):
1597         (-[WebDefaultUIDelegate webViewUnfocus:]):
1598         (-[WebDefaultUIDelegate webViewIsResizable:]):
1599         (-[WebDefaultUIDelegate webView:setResizable:]):
1600         (-[WebDefaultUIDelegate webView:setFrame:]):
1601         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1602         * History/BackForwardList.h:
1603         * History/BackForwardList.mm:
1604         * History/WebBackForwardList.mm:
1605         (+[WebBackForwardList initialize]):
1606         (bumperCarBackForwardHackNeeded):
1607         * History/WebHistory.mm:
1608         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1609         (-[WebHistory _sendNotification:entries:]):
1610         (-[WebHistory loadFromURL:error:]):
1611         (-[WebHistory saveToURL:error:]):
1612         * History/WebHistoryItem.mm:
1613         (WKNotifyHistoryItemChanged):
1614         (+[WebHistoryItem initialize]):
1615         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1616         * History/WebURLsWithTitles.m:
1617         * Misc/WebCache.mm:
1618         (+[WebCache initialize]):
1619         * Misc/WebDownload.mm:
1620         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1621         * Misc/WebElementDictionary.mm:
1622         (+[WebElementDictionary initialize]):
1623         (+[WebElementDictionary initializeLookupTable]):
1624         * Misc/WebIconDatabase.mm:
1625         * Misc/WebKitNSStringExtras.mm:
1626         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1627         * Misc/WebKitVersionChecks.h:
1628         * Misc/WebKitVersionChecks.mm:
1629         (WebKitLinkedOnOrAfter):
1630         (WebKitLinkTimeVersion):
1631         * Misc/WebLocalizableStrings.mm:
1632         * Misc/WebNSControlExtras.h:
1633         * Misc/WebNSControlExtras.m:
1634         * Misc/WebNSEventExtras.m:
1635         * Misc/WebNSFileManagerExtras.mm:
1636         * Misc/WebNSImageExtras.h:
1637         * Misc/WebNSImageExtras.m:
1638         * Misc/WebNSPasteboardExtras.mm:
1639         * Misc/WebNSPrintOperationExtras.h:
1640         * Misc/WebNSPrintOperationExtras.m:
1641         * Misc/WebNSViewExtras.m:
1642         * Misc/WebNSWindowExtras.m:
1643         * Panels/WebAuthenticationPanel.h:
1644         * Panels/WebAuthenticationPanel.m:
1645         * Panels/WebPanelAuthenticationHandler.m:
1646         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1647         (+[WebHostedNetscapePluginView initialize]):
1648         * Plugins/WebBasePluginPackage.h:
1649         * Plugins/WebBasePluginPackage.mm:
1650         * Plugins/WebJavaPlugIn.h:
1651         * Plugins/WebPluginContainerCheck.mm:
1652         * Plugins/WebPluginController.h:
1653         * Plugins/WebPluginController.mm:
1654         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1655         (-[WebPluginController addPlugin:]):
1656         (-[WebPluginController destroyPlugin:]):
1657         (-[WebPluginController destroyAllPlugins]):
1658         * Plugins/WebPluginDatabase.mm:
1659         (+[WebPluginDatabase _defaultPlugInPaths]):
1660         * Plugins/WebPluginPackage.mm:
1661         (-[WebPluginPackage initWithPath:]):
1662         * Storage/WebDatabaseManager.mm:
1663         (-[WebDatabaseManager deleteAllDatabases]):
1664         * Storage/WebDatabaseManagerClient.h:
1665         * Storage/WebDatabaseManagerClient.mm:
1666         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1667         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1668         * Storage/WebStorageManager.mm:
1669         (-[WebStorageManager deleteAllOrigins]):
1670         (WebKitInitializeStorageIfNecessary):
1671         * WebCoreSupport/WebAlternativeTextClient.h:
1672         * WebCoreSupport/WebApplicationCache.mm:
1673         (applicationCacheBundleIdentifier):
1674         * WebCoreSupport/WebChromeClient.h:
1675         * WebCoreSupport/WebChromeClient.mm:
1676         (WebChromeClient::setWindowRect):
1677         (WebChromeClient::windowRect):
1678         (WebChromeClient::takeFocus):
1679         (WebChromeClient::addMessageToConsole):
1680         (WebChromeClient::enableSuddenTermination):
1681         (WebChromeClient::disableSuddenTermination):
1682         (WebChromeClient::createPopupMenu const):
1683         (WebChromeClient::createSearchPopupMenu const):
1684         (WebChromeClient::shouldPaintEntireContents const):
1685         (WebChromeClient::supportsVideoFullscreen):
1686         (WebChromeClient::supportsFullScreenForElement):
1687         (WebChromeClient::enterFullScreenForElement):
1688         (WebChromeClient::exitFullScreenForElement):
1689         * WebCoreSupport/WebContextMenuClient.mm:
1690         * WebCoreSupport/WebDragClient.mm:
1691         * WebCoreSupport/WebEditorClient.h:
1692         * WebCoreSupport/WebEditorClient.mm:
1693         (+[WebUndoStep initialize]):
1694         (updateFontPanel):
1695         (WebEditorClient::didBeginEditing):
1696         (WebEditorClient::respondToChangedContents):
1697         (WebEditorClient::respondToChangedSelection):
1698         (WebEditorClient::canceledComposition):
1699         (WebEditorClient::didEndEditing):
1700         (WebEditorClient::didWriteSelectionToPasteboard):
1701         (attributesForAttributedStringConversion):
1702         (WebEditorClient::setInsertionPasteboard):
1703         (WebEditorClient::registerUndoOrRedoStep):
1704         (WebEditorClient::handleKeyboardEvent):
1705         (WebEditorClient::handleInputMethodKeydown):
1706         (WebEditorClient::textDidChangeInTextField):
1707         (WebEditorClient::requestCheckingOfString):
1708         * WebCoreSupport/WebFrameLoaderClient.h:
1709         * WebCoreSupport/WebFrameLoaderClient.mm:
1710         (WebFrameLoaderClient::detachedFromParent2):
1711         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1712         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1713         (WebFrameLoaderClient::dispatchWillSendRequest):
1714         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1715         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1716         (WebFrameLoaderClient::willCacheResponse const):
1717         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1718         (WebFrameLoaderClient::dispatchDidFinishLoading):
1719         (WebFrameLoaderClient::dispatchDidFailLoading):
1720         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1721         (WebFrameLoaderClient::dispatchWillClose):
1722         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1723         (WebFrameLoaderClient::dispatchDidCommitLoad):
1724         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1725         (WebFrameLoaderClient::dispatchDidFailLoad):
1726         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1727         (WebFrameLoaderClient::dispatchDidFinishLoad):
1728         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1729         (WebFrameLoaderClient::willChangeTitle):
1730         (WebFrameLoaderClient::didChangeTitle):
1731         (WebFrameLoaderClient::didReplaceMultipartContent):
1732         (WebFrameLoaderClient::updateGlobalHistory):
1733         (WebFrameLoaderClient::saveViewStateToItem):
1734         (WebFrameLoaderClient::restoreViewState):
1735         (WebFrameLoaderClient::provisionalLoadStarted):
1736         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1737         (WebFrameLoaderClient::setTitle):
1738         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1739         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1740         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1741         (WebFrameLoaderClient::didRestoreFromPageCache):
1742         (WebFrameLoaderClient::actionDictionary const):
1743         (WebFrameLoaderClient::createPlugin):
1744         (WebFrameLoaderClient::getLoadDecisionForIcons):
1745         (WebFrameLoaderClient::finishedLoadingIcon):
1746         (+[WebFramePolicyListener initialize]):
1747         * WebCoreSupport/WebFrameNetworkingContext.mm:
1748         * WebCoreSupport/WebGeolocationClient.h:
1749         * WebCoreSupport/WebGeolocationClient.mm:
1750         (WebGeolocationClient::requestPermission):
1751         * WebCoreSupport/WebInspectorClient.h:
1752         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1753         * WebCoreSupport/WebNotificationClient.mm:
1754         * WebCoreSupport/WebOpenPanelResultListener.mm:
1755         * WebCoreSupport/WebPlatformStrategies.h:
1756         * WebCoreSupport/WebPlatformStrategies.mm:
1757         * WebCoreSupport/WebProgressTrackerClient.h:
1758         * WebCoreSupport/WebProgressTrackerClient.mm:
1759         (WebProgressTrackerClient::progressStarted):
1760         (WebProgressTrackerClient::progressEstimateChanged):
1761         (WebProgressTrackerClient::progressFinished):
1762         * WebCoreSupport/WebSecurityOrigin.mm:
1763         * WebInspector/WebNodeHighlight.h:
1764         * WebInspector/WebNodeHighlight.mm:
1765         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1766         (-[WebNodeHighlight dealloc]):
1767         (-[WebNodeHighlight attach]):
1768         * WebInspector/WebNodeHighlightView.h:
1769         * WebInspector/WebNodeHighlightView.mm:
1770         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1771         (-[WebNodeHighlightView dealloc]):
1772         * WebInspector/WebNodeHighlighter.mm:
1773         (-[WebNodeHighlighter highlight]):
1774         * WebView/WebArchive.mm:
1775         (+[WebArchivePrivate initialize]):
1776         * WebView/WebClipView.h:
1777         * WebView/WebDataSource.mm:
1778         (WebDataSourcePrivate::WebDataSourcePrivate):
1779         (+[WebDataSource initialize]):
1780         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1781         (-[WebDataSource _makeRepresentation]):
1782         * WebView/WebDelegateImplementationCaching.h:
1783         * WebView/WebDelegateImplementationCaching.mm:
1784         (CallDelegate):
1785         (CallDelegateReturningFloat):
1786         (CallDelegateReturningBoolean):
1787         (CallUIDelegate):
1788         (CallUIDelegateReturningFloat):
1789         (CallUIDelegateReturningBoolean):
1790         (CallFrameLoadDelegate):
1791         (CallFrameLoadDelegateReturningBoolean):
1792         (CallResourceLoadDelegate):
1793         (CallScriptDebugDelegate):
1794         (CallFormDelegate):
1795         (CallFormDelegateReturningBoolean):
1796         * WebView/WebDeviceOrientation.mm:
1797         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1798         * WebView/WebDocumentInternal.h:
1799         * WebView/WebDocumentLoaderMac.mm:
1800         (needsDataLoadWorkaround):
1801         * WebView/WebDynamicScrollBarsViewInternal.h:
1802         * WebView/WebFormDelegate.m:
1803         * WebView/WebFrame.mm:
1804         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1805         (-[WebFrame _unmarkAllMisspellings]):
1806         (-[WebFrame _paintBehaviorForDestinationContext:]):
1807         (-[WebFrame _drawRect:contentsOnly:]):
1808         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1809         (-[WebFrame _scrollDOMRangeToVisible:]):
1810         (-[WebFrame _bodyBackgroundColor]):
1811         (-[WebFrame accessibilityRoot]):
1812         (needsMicrosoftMessengerDOMDocumentWorkaround):
1813         * WebView/WebFrameInternal.h:
1814         * WebView/WebFrameView.mm:
1815         (-[WebFrameView _setDocumentView:]):
1816         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1817         (-[WebFrameView _viewClassForMIMEType:]):
1818         (-[WebFrameView initWithFrame:]):
1819         (-[WebFrameView drawRect:]):
1820         (-[WebFrameView _firstResponderIsFormControl]):
1821         (-[WebFrameView keyDown:keyDown:]):
1822         (-[WebFrameView _isScrollable]):
1823         * WebView/WebFullScreenController.h:
1824         * WebView/WebFullScreenController.mm:
1825         * WebView/WebHTMLRepresentation.mm:
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView hitTest:]):
1828         (-[WebHTMLView initWithFrame:]):
1829         (-[WebHTMLView dealloc]):
1830         (-[WebHTMLView addSubview:]):
1831         (-[WebHTMLView mouseDown:]):
1832         (-[WebHTMLView mouseUp:]):
1833         (-[WebHTMLView resignFirstResponder]):
1834         (-[WebHTMLView accessibilityHitTest:]):
1835         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1836         * WebView/WebHTMLViewInternal.h:
1837         * WebView/WebIndicateLayer.h:
1838         * WebView/WebIndicateLayer.mm:
1839         * WebView/WebMediaPlaybackTargetPicker.h:
1840         * WebView/WebMediaPlaybackTargetPicker.mm:
1841         * WebView/WebPDFDocumentExtras.h:
1842         * WebView/WebPDFDocumentExtras.mm:
1843         * WebView/WebPDFRepresentation.h:
1844         * WebView/WebPDFRepresentation.mm:
1845         * WebView/WebPDFView.h:
1846         * WebView/WebPreferences.mm:
1847         (cacheModelForMainBundle):
1848         (WebPreferencesPrivate::WebPreferencesPrivate):
1849         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1850         (-[WebPreferences encodeWithCoder:]):
1851         (+[WebPreferences standardPreferences]):
1852         (+[WebPreferences initialize]):
1853         (-[WebPreferences _valueForKey:]):
1854         (-[WebPreferences _setStringValue:forKey:]):
1855         (-[WebPreferences _setIntegerValue:forKey:]):
1856         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1857         (-[WebPreferences _setFloatValue:forKey:]):
1858         (-[WebPreferences _setBoolValue:forKey:]):
1859         (-[WebPreferences _setLongLongValue:forKey:]):
1860         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1861         (-[WebPreferences _postCacheModelChangedNotification]):
1862         (-[WebPreferences _postPreferencesChangedNotification]):
1863         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1864         (-[WebPreferences setStorageBlockingPolicy:]):
1865         * WebView/WebResource.mm:
1866         (+[WebResourcePrivate initialize]):
1867         * WebView/WebTextCompletionController.h:
1868         * WebView/WebTextIterator.mm:
1869         (+[WebTextIteratorPrivate initialize]):
1870         * WebView/WebView.mm:
1871         (shouldEnableLoadDeferring):
1872         (shouldRestrictWindowFocus):
1873         (shouldRespectPriorityInCSSAttributeSetters):
1874         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1875         (shouldAllowPictureInPictureMediaPlayback):
1876         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1877         (shouldAllowWindowOpenWithoutUserGesture):
1878         (shouldConvertInvalidURLsToBlank):
1879         (shouldRequireUserGestureToLoadVideo):
1880         (-[WebView _commonInitializationWithFrameName:groupName:]):
1881         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1882         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1883         (-[WebView _closePluginDatabases]):
1884         (-[WebView _closeWithFastTeardown]):
1885         (-[WebView _close]):
1886         (+[WebView _MIMETypeForFile:]):
1887         (-[WebView setShowingInspectorIndication:]):
1888         (-[WebView _setFormDelegate:]):
1889         (-[WebView _needsPreHTML5ParserQuirks]):
1890         (-[WebView _preferencesChangedNotification:]):
1891         (-[WebView _preferencesChanged:]):
1892         (-[WebView _cacheResourceLoadDelegateImplementations]):
1893         (-[WebView _cacheFrameLoadDelegateImplementations]):
1894         (-[WebView _policyDelegateForwarder]):
1895         (-[WebView _UIDelegateForwarder]):
1896         (-[WebView _editingDelegateForwarder]):
1897         (-[WebView _updateActiveState]):
1898         (-[_WebSafeForwarder forwardInvocation:]):
1899         (+[WebView initialize]):
1900         (-[WebView _pluginForMIMEType:]):
1901         (-[WebView _pluginForExtension:]):
1902         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1903         (+[WebView canShowMIMETypeAsHTML:]):
1904         (-[WebView _initWithArguments:]):
1905         (-[WebView initWithFrame:frameName:groupName:]):
1906         (-[WebView dealloc]):
1907         (-[WebView close]):
1908         (-[WebView viewDidMoveToWindow]):
1909         (-[WebView setUIDelegate:]):
1910         (-[WebView setResourceLoadDelegate:]):
1911         (-[WebView setPolicyDelegate:]):
1912         (-[WebView setFrameLoadDelegate:]):
1913         (-[WebView goBack]):
1914         (-[WebView goForward]):
1915         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1916         (-[WebView setHostWindow:]):
1917         (-[WebView becomeFirstResponder]):
1918         (+[WebView _cacheModelChangedNotification:]):
1919         (-[WebView _frameViewAtWindowPoint:]):
1920         (+[WebView _preflightSpellCheckerNow:]):
1921         (+[WebView _preflightSpellChecker]):
1922         (-[WebView canGoBack]):
1923         (-[WebView canGoForward]):
1924         (-[WebView stopLoading:]):
1925         (-[WebView reload:]):
1926         (-[WebView setMainFrameDocumentReady:]):
1927         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1928         (-[WebView setContinuousSpellCheckingEnabled:]):
1929         (-[WebView undoManager]):
1930         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1931         (-[WebView isAutomaticLinkDetectionEnabled]):
1932         (-[WebView isAutomaticDashSubstitutionEnabled]):
1933         (-[WebView isAutomaticTextReplacementEnabled]):
1934         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1935         (+[WebView _setCacheModel:]):
1936         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1937         (-[WebView _keyboardUIMode]):
1938         (LayerFlushController::flushLayers):
1939         (-[WebView _scheduleCompositingLayerFlush]):
1940         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1941         (-[WebView fullScreenPlaceholderView]):
1942         (WebInstallMemoryPressureHandler):
1943         * WebView/WebViewData.h:
1944         * WebView/WebViewData.mm:
1945         (+[WebViewPrivate initialize]):
1946         (-[WebViewPrivate init]):
1947         (-[WebViewPrivate dealloc]):
1948         * WebView/WebViewInternal.h:
1949
1950 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1951
1952         Clean up FrameLoader two-state enums
1953         https://bugs.webkit.org/show_bug.cgi?id=190731
1954
1955         Reviewed by Chris Dumez.
1956
1957         * WebCoreSupport/WebFrameLoaderClient.h:
1958         * WebCoreSupport/WebFrameLoaderClient.mm:
1959         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1960
1961 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1962
1963         Unreviewed, rolling out r237137.
1964
1965         SPI is actually used
1966
1967         Reverted changeset:
1968
1969         "Remove unused WebFrame._loadType"
1970         https://bugs.webkit.org/show_bug.cgi?id=190583
1971         https://trac.webkit.org/changeset/237137
1972
1973 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1974
1975         Enable the datalist element by default on iOS and macOS
1976         https://bugs.webkit.org/show_bug.cgi?id=190594
1977         <rdar://problem/45281159>
1978
1979         Reviewed by Ryosuke Niwa and Tim Horton.
1980
1981         * Configurations/FeatureDefines.xcconfig:
1982
1983 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1984
1985         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1986         https://bugs.webkit.org/show_bug.cgi?id=190675
1987
1988         Reviewed by Chris Dumez.
1989
1990         * History/BackForwardList.h:
1991         * History/BackForwardList.mm:
1992         (BackForwardList::backItem):
1993         (BackForwardList::currentItem):
1994         (BackForwardList::forwardItem):
1995         (BackForwardList::backListCount const):
1996         (BackForwardList::forwardListCount const):
1997         (BackForwardList::itemAtIndex):
1998         * History/WebBackForwardList.mm:
1999         (-[WebBackForwardList backItem]):
2000         (-[WebBackForwardList currentItem]):
2001         (-[WebBackForwardList forwardItem]):
2002         (-[WebBackForwardList itemAtIndex:]):
2003
2004 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2005
2006         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2007         https://bugs.webkit.org/show_bug.cgi?id=190526
2008         rdar://problem/45230140
2009
2010         Reviewed by Dean Jackson.
2011
2012         * WebCoreSupport/WebEditorClient.mm:
2013         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2014
2015 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2016
2017         Implement feature flag and bindings for CSS Painting API
2018         https://bugs.webkit.org/show_bug.cgi?id=190237
2019
2020         Reviewed by Ryosuke Niwa.
2021
2022         * Configurations/FeatureDefines.xcconfig:
2023
2024 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2025
2026         Replace HistoryItem* with HistoryItem& where possible
2027         https://bugs.webkit.org/show_bug.cgi?id=190617
2028
2029         Reviewed by Chris Dumez.
2030
2031         * History/BackForwardList.h:
2032         * History/BackForwardList.mm:
2033         (BackForwardList::goToItem):
2034         * History/WebBackForwardList.mm:
2035         (-[WebBackForwardList goToItem:]):
2036         * History/WebHistoryItem.mm:
2037         (WKNotifyHistoryItemChanged):
2038         * History/WebHistoryItemInternal.h:
2039
2040 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2041
2042         Remove unused WebHistoryItem._transientPropertyForKey
2043         https://bugs.webkit.org/show_bug.cgi?id=190606
2044
2045         Reviewed by Chris Dumez.
2046
2047         * History/WebHistoryItem.mm:
2048         * History/WebHistoryItemPrivate.h:
2049
2050 2018-10-15  Justin Fan  <justin_fan@apple.com>
2051
2052         Add WebGPU 2018 feature flag and experimental feature flag
2053         https://bugs.webkit.org/show_bug.cgi?id=190509
2054
2055         Reviewed by Dean Jackson.
2056
2057         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2058         for the 2018 WebGPU prototype.
2059
2060         * Configurations/FeatureDefines.xcconfig:
2061         * WebView/WebPreferenceKeysPrivate.h:
2062         * WebView/WebPreferences.mm:
2063         (+[WebPreferences initialize]):
2064         (-[WebPreferences webGPUEnabled]):
2065         (-[WebPreferences setWebGPUEnabled:]):
2066         * WebView/WebPreferencesPrivate.h:
2067         * WebView/WebView.mm:
2068         (-[WebView _preferencesChanged:]):
2069
2070 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2071
2072         Fix iOS build after r237157
2073
2074         * WebView/WebView.mm:
2075         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2076
2077 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2078
2079         Modernize BackForwardClient.h
2080         https://bugs.webkit.org/show_bug.cgi?id=190610
2081
2082         Reviewed by Chris Dumez.
2083
2084         * History/BackForwardList.h:
2085         * History/BackForwardList.mm:
2086         (BackForwardList::backListCount const):
2087         (BackForwardList::forwardListCount const):
2088         (BackForwardList::backListCount): Deleted.
2089         (BackForwardList::forwardListCount): Deleted.
2090         * History/WebBackForwardList.mm:
2091         (-[WebBackForwardList init]):
2092         * WebCoreSupport/WebFrameLoaderClient.mm:
2093         (WebFrameLoaderClient::canCachePage const):
2094         * WebView/WebFrameView.mm:
2095         (-[WebFrameView keyDown:keyDown:]):
2096         * WebView/WebView.mm:
2097         (-[WebView _commonInitializationWithFrameName:groupName:]):
2098         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2099         (-[WebView _loadBackForwardListFromOtherView:]):
2100         (-[WebView initWithCoder:]):
2101         (-[WebView encodeWithCoder:]):
2102         (-[WebView backForwardList]):
2103         (-[WebView setMaintainsBackForwardList:]):
2104
2105 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2106
2107         Add support for prefers-color-scheme media query
2108         https://bugs.webkit.org/show_bug.cgi?id=190499
2109         rdar://problem/45212025
2110
2111         Reviewed by Dean Jackson.
2112
2113         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2114
2115 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2116
2117         Remove unused WebView._globalHistoryItem
2118         https://bugs.webkit.org/show_bug.cgi?id=190601
2119
2120         Reviewed by Chris Dumez.
2121
2122         * WebCoreSupport/WebFrameLoaderClient.h:
2123         * WebCoreSupport/WebFrameLoaderClient.mm:
2124         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2125         * WebView/WebView.mm:
2126         (-[WebView _globalHistoryItem]): Deleted.
2127         (-[WebView _setGlobalHistoryItem:]): Deleted.
2128         * WebView/WebViewData.h:
2129         * WebView/WebViewInternal.h:
2130         * WebView/WebViewPrivate.h:
2131
2132 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2133
2134         Remove unused parameters from FrameLoaderClient::createFrame
2135         https://bugs.webkit.org/show_bug.cgi?id=190587
2136
2137         Reviewed by Chris Dumez.
2138
2139         * WebCoreSupport/WebFrameLoaderClient.h:
2140         * WebCoreSupport/WebFrameLoaderClient.mm:
2141         (WebFrameLoaderClient::createFrame):
2142
2143 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2144
2145         Remove unused WebFrame._loadType
2146         https://bugs.webkit.org/show_bug.cgi?id=190583
2147
2148         Reviewed by Chris Dumez.
2149
2150         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2151
2152         * WebView/WebFrame.mm:
2153         (toWebFrameLoadType): Deleted.
2154         (-[WebFrame _loadType]): Deleted.
2155         * WebView/WebFramePrivate.h:
2156
2157 2018-10-15  Chris Dumez  <cdumez@apple.com>
2158
2159         Restrict browsing context lookup by name to frames that are related to one another
2160         https://bugs.webkit.org/show_bug.cgi?id=190475
2161
2162         Reviewed by Alex Christensen.
2163
2164         * WebView/WebFrame.mm:
2165         (-[WebFrame findFrameNamed:]):
2166
2167 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2168
2169         Remove InjectedBundle processing of back/forward lists
2170         https://bugs.webkit.org/show_bug.cgi?id=190459
2171
2172         Reviewed by Chris Dumez.
2173
2174         * WebCoreSupport/WebFrameLoaderClient.h:
2175         * WebCoreSupport/WebFrameLoaderClient.mm:
2176         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2177
2178 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2179
2180         [JSC] Remove Option::useAsyncIterator
2181         https://bugs.webkit.org/show_bug.cgi?id=190567
2182
2183         Reviewed by Saam Barati.
2184
2185         * Configurations/FeatureDefines.xcconfig:
2186
2187 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2188
2189         Allow encoding of small enum classes
2190         https://bugs.webkit.org/show_bug.cgi?id=190531
2191
2192         Reviewed by Tim Horton.
2193
2194         * WebCoreSupport/WebFrameLoaderClient.mm:
2195         (-[WebFramePolicyListener dealloc]):
2196
2197 2018-10-11  Keith Rollin  <krollin@apple.com>
2198
2199         CURRENT_ARCH should not be used in Run Script phase.
2200         https://bugs.webkit.org/show_bug.cgi?id=190407
2201         <rdar://problem/45133556>
2202
2203         Reviewed by Alexey Proskuryakov.
2204
2205         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2206         CURRENT_ARCH is not well-defined during this phase (and may even have
2207         the value "undefined") since this phase is run just once per build
2208         rather than once per supported architecture. Migrate away from
2209         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2210         performing an operation for each value, or by picking the first entry
2211         in ARCHS and using that as a representative value.
2212
2213         * Configurations/WebKitLegacy.xcconfig: When generating
2214         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2215         macosx platforms.
2216
2217         * MigrateHeaders.make:
2218         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2219         generate one for each architecture in ARCHS.
2220
2221 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2222
2223         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2224         https://bugs.webkit.org/show_bug.cgi?id=190429
2225
2226         Reviewed by Saam Barati.
2227
2228         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2229
2230         * WebView/WebPDFRepresentation.mm:
2231         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2232
2233 2018-10-08  Justin Fan  <justin_fan@apple.com>
2234
2235         WebGPU: Rename old WebGPU prototype to WebMetal
2236         https://bugs.webkit.org/show_bug.cgi?id=190325
2237         <rdar://problem/44990443>
2238
2239         Reviewed by Dean Jackson.
2240
2241         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2242
2243         * Configurations/FeatureDefines.xcconfig:
2244         * WebView/WebPreferenceKeysPrivate.h:
2245         * WebView/WebPreferences.mm:
2246         (+[WebPreferences initialize]):
2247         (-[WebPreferences webMetalEnabled]):
2248         (-[WebPreferences setWebMetalEnabled:]):
2249         (-[WebPreferences webGPUEnabled]): Deleted.
2250         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2251         * WebView/WebPreferencesPrivate.h:
2252         * WebView/WebView.mm:
2253         (-[WebView _preferencesChanged:]):
2254
2255 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2256
2257         Make <input type=color> a runtime enabled (on-by-default) feature
2258         https://bugs.webkit.org/show_bug.cgi?id=189162
2259
2260         Reviewed by Wenson Hsieh and Tim Horton.
2261
2262         * Configurations/FeatureDefines.xcconfig:
2263
2264 2018-10-07  Dan Bernstein  <mitz@apple.com>
2265
2266         Fixed building with the latest macOS SDK
2267
2268         * Plugins/WebNetscapePluginPackage.mm:
2269         (-[WebNetscapePluginPackage openResourceFile]):
2270         (-[WebNetscapePluginPackage closeResourceFile:]):
2271
2272 2018-10-04  Dan Bernstein  <mitz@apple.com>
2273
2274         More Carbon build-fixing.
2275
2276         * Carbon/CarbonWindowAdapter.mm:
2277         (-[CarbonWindowAdapter _destroyRealWindow:]):
2278         (-[CarbonWindowAdapter _growBoxRect]):
2279
2280 2018-10-04  Dan Bernstein  <mitz@apple.com>
2281
2282         Retried to fix 32-bit macOS builds after r236846.
2283
2284         * WebView/WebHTMLView.mm:
2285         (-[WebHTMLView setMarkedText:selectedRange:]):
2286
2287 2018-10-04  Dan Bernstein  <mitz@apple.com>
2288
2289         Retried to fix 32-bit macOS builds after r236846.
2290
2291         * Carbon/HIWebView.mm:
2292         (ActiveStateChanged):
2293
2294 2018-10-04  Dan Bernstein  <mitz@apple.com>
2295
2296         Tried to fix 32-bit macOS builds after r236846.
2297
2298         * Carbon/HIWebView.mm:
2299         (_NSSelectorForHICommand):
2300
2301 2018-10-04  Dan Bernstein  <mitz@apple.com>
2302
2303         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2304         https://bugs.webkit.org/show_bug.cgi?id=190250
2305
2306         Reviewed by Andy Estes.
2307
2308         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2309           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2310           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2311           an earlier line set it to YES.
2312
2313         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2314         changes below.
2315
2316         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2317           provides some missing method declarations.
2318
2319         * Misc/WebDownload.mm:
2320         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2321           a deprecated method.
2322
2323         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2324
2325         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2326           other code in the file uses a method from it.
2327
2328         * Plugins/WebBaseNetscapePluginView.mm:
2329         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2330           a deprecated method.
2331
2332         * Plugins/WebPluginController.mm:
2333         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2334           around use of a selector that may be present in some WebKit client.
2335
2336         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2337           method declarations.
2338
2339         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2340           from here.
2341
2342         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2343           missing method declarations.
2344
2345         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2346           from here.
2347
2348         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2349           call from here.
2350         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2351           an obsolete delegate method for binary compatibility.
2352         (pluginView): Ditto.
2353
2354         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2355           call from here.
2356
2357         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2358           WebDeviceOrientationProviderMock protocol.
2359
2360         * WebView/WebDeviceOrientationProviderMock.mm:
2361         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2362           main @implementation.
2363
2364         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2365           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2366
2367         * WebView/WebDynamicScrollBarsView.mm:
2368         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2369           of a deprecated method.
2370
2371         * WebView/WebHTMLView.mm:
2372         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2373           selector warning around action methods that are not declared anywhere in WebKit.
2374
2375         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2376           about implementing this deprecated method.
2377         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2378         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2379         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2380         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2381         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2382         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2383         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2384         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2385         (-[WebHTMLView doCommandBySelector:]): Ditto.
2386         (-[WebHTMLView insertText:]): Ditto.
2387
2388         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2389
2390         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2391
2392         * WebView/WebPDFView.h: Removed previewView ivar.
2393
2394         * WebView/WebPDFView.mm:
2395           Removed declaration of FileInternal category and merged its implementation with the main
2396           implementation.
2397         (-[WebPDFView dealloc]): Removed previewView ivar.
2398         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2399           exist in macOS versions we support.
2400         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2401         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2402           action methods internal to PDFKit.
2403         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2404         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2405
2406         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2407           call on macOS, even though in r86988 we started calling different methods on iOS.
2408
2409         * WebView/WebView.mm:
2410         - Imported headers that declare delegate methods that we call.
2411         - Removed declaration of WebFileInternal category and merged its implementation with the
2412           main implementation.
2413         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2414           category, which made them impossible to call from the main implementation. Moved those
2415           into the main implementation. One of those had to be declared in a class extension,
2416           because it is called from a method implemented in the WebPrivate category, and that
2417           category’s implementation appears first in the file.
2418
2419         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2420           around use of obsolete delegate method for binary compatibility.
2421
2422         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2423
2424 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2425
2426         Runtime flag and IDL for MediaRecorder
2427         https://bugs.webkit.org/show_bug.cgi?id=190018
2428
2429         Reviewed by Youenn Fablet and Chris Dumez.
2430
2431         * WebView/WebPreferenceKeysPrivate.h:
2432         * WebView/WebPreferences.mm:
2433         (+[WebPreferences initialize]):
2434         (-[WebPreferences mediaRecorderEnabled]):
2435         (-[WebPreferences setMediaRecorderEnabled:]):
2436         * WebView/WebPreferencesPrivate.h:
2437         * WebView/WebView.mm:
2438         (-[WebView _preferencesChanged:]):
2439
2440 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2443         https://bugs.webkit.org/show_bug.cgi?id=190238
2444
2445         Reviewed by Antti Koivisto.
2446
2447         Enabled the feature by default.
2448
2449         * WebView/WebPreferences.mm:
2450         (+[WebPreferences initialize]):
2451
2452 2018-10-01  Dean Jackson  <dino@apple.com>
2453
2454         [macOS] Switching to discrete GPU should be done in the UI process
2455         https://bugs.webkit.org/show_bug.cgi?id=189361
2456         <rdar://problem/43949622>
2457
2458         Reviewed by Simon Fraser.
2459
2460         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2461         not support swapping to the discrete GPU in this configuration.
2462
2463         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2464         (WebKit::WebSwitchingGPUClient::singleton):
2465         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2466         * WebView/WebView.mm:
2467         (-[WebView _commonInitializationWithFrameName:groupName:]):
2468
2469 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2470
2471         Remove ParsedURLString
2472         https://bugs.webkit.org/show_bug.cgi?id=190154
2473
2474         Reviewed by Chris Dumez.
2475
2476         * WebView/WebScriptDebugger.mm:
2477         (toNSURL):
2478
2479 2018-10-01  Dean Jackson  <dino@apple.com>
2480
2481         Remove CSS Animation Triggers
2482         https://bugs.webkit.org/show_bug.cgi?id=190175
2483         <rdar://problem/44925626>
2484
2485         Reviewed by Simon Fraser.
2486
2487         * Configurations/FeatureDefines.xcconfig:
2488
2489 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2490
2491         Unreviewed, rolling out r236624 and r236671.
2492         https://bugs.webkit.org/show_bug.cgi?id=190207
2493
2494         The change in r236624 introduced crashes on the bots
2495         (Requested by ryanhaddad on #webkit).
2496
2497         Reverted changesets:
2498
2499         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2500         https://bugs.webkit.org/show_bug.cgi?id=188747
2501         https://trac.webkit.org/changeset/236624
2502
2503         "Unify implementation in VideoFullscreenInterfaceAVKit"
2504         https://bugs.webkit.org/show_bug.cgi?id=190091
2505         https://trac.webkit.org/changeset/236671
2506
2507 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2508
2509         URL should not use TextEncoding internally
2510         https://bugs.webkit.org/show_bug.cgi?id=190111
2511
2512         Reviewed by Andy Estes.
2513
2514         * Misc/WebNSURLExtras.mm:
2515
2516 2018-09-28  Jer Noble  <jer.noble@apple.com>
2517
2518         Refactoring: eliminate raw pointer usage in Fullscreen code
2519         https://bugs.webkit.org/show_bug.cgi?id=188747
2520         <rdar://problem/43541164>
2521
2522         Reviewed by Alex Christensen.
2523
2524         PlaybackSessionInterface no longer has an invalidate() method.
2525
2526         * WebView/WebView.mm:
2527         (-[WebView _clearPlaybackControlsManager]):
2528
2529 2018-09-28  Chris Dumez  <cdumez@apple.com>
2530
2531         Drop support for cross-origin-window-policy header
2532         https://bugs.webkit.org/show_bug.cgi?id=190081
2533
2534         Reviewed by Ryosuke Niwa.
2535
2536         * WebView/WebPreferenceKeysPrivate.h:
2537         * WebView/WebPreferences.mm:
2538         (+[WebPreferences initialize]):
2539         * WebView/WebPreferencesPrivate.h:
2540         * WebView/WebView.mm:
2541         (-[WebView _preferencesChanged:]):
2542
2543 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2544
2545         Rename createMarkup to serializePreservingVisualAppearance
2546         https://bugs.webkit.org/show_bug.cgi?id=190086
2547
2548         Reviewed by Wenson Hsieh.
2549
2550         * DOM/WebDOMOperations.mm:
2551         (-[DOMRange markupString]):
2552
2553 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2554
2555         Unreviewed, rolling out r236605.
2556         https://bugs.webkit.org/show_bug.cgi?id=190087
2557
2558         caused three API test timeouts (Requested by jernoble on
2559         #webkit).
2560
2561         Reverted changeset:
2562
2563         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2564         https://bugs.webkit.org/show_bug.cgi?id=188747
2565         https://trac.webkit.org/changeset/236605
2566
2567 2018-09-28  Jer Noble  <jer.noble@apple.com>
2568
2569         Refactoring: eliminate raw pointer usage in Fullscreen code
2570         https://bugs.webkit.org/show_bug.cgi?id=188747
2571         <rdar://problem/43541164>
2572
2573         Reviewed by Alex Christensen.
2574
2575         PlaybackSessionInterface no longer has an invalidate() method.
2576
2577         * WebView/WebView.mm:
2578         (-[WebView _clearPlaybackControlsManager]):
2579
2580 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Use enum class in createMarkup arguments
2583         https://bugs.webkit.org/show_bug.cgi?id=190028
2584
2585         Reviewed by Wenson Hsieh.
2586
2587         * DOM/WebDOMOperations.mm:
2588         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2589         (-[DOMRange markupString]): Ditto.
2590
2591 2018-09-27  Antoine Quint  <graouts@apple.com>
2592
2593         [Web Animations] Turn Web Animations with CSS integration on
2594         https://bugs.webkit.org/show_bug.cgi?id=184819
2595         <rdar://problem/39597337>
2596
2597         Reviewed by Dean Jackson.
2598
2599         * WebView/WebPreferences.mm:
2600         (+[WebPreferences initialize]):
2601
2602 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2603
2604         Selection should work across shadow boundary when initiated by a mouse drag
2605         https://bugs.webkit.org/show_bug.cgi?id=151380
2606         <rdar://problem/24363872>
2607
2608         Reviewed by Wenson Hsieh.
2609
2610         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2611
2612         * WebView/WebPreferenceKeysPrivate.h:
2613         * WebView/WebPreferences.mm:
2614         (+[WebPreferences initialize]):
2615         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2616         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2617         * WebView/WebPreferencesPrivate.h:
2618         * WebView/WebView.mm:
2619         (-[WebView _preferencesChanged:]):
2620
2621 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2622
2623         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2624         https://bugs.webkit.org/show_bug.cgi?id=189918
2625         Work towards <rdar://problem/44648705>
2626
2627         Reviewed by Tim Horton.
2628
2629         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2630
2631         * WebView/WebHTMLView.mm:
2632         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2633         (-[WebHTMLView _updateFontPanel]):
2634         * WebView/WebView.mm:
2635         (-[WebView typingAttributes]):
2636
2637 2018-09-17  Darin Adler  <darin@apple.com>
2638
2639         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2640         https://bugs.webkit.org/show_bug.cgi?id=189652
2641
2642         Reviewed by Saam Barati.
2643
2644         * WebView/WebPDFRepresentation.mm:
2645         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2646
2647 2018-09-14  Jer Noble  <jer.noble@apple.com>
2648
2649         Turn SourceBufferChangeTypeEnabled on by default
2650         https://bugs.webkit.org/show_bug.cgi?id=189527
2651
2652         Reviewed by Eric Carlson.
2653
2654         * WebView/WebPreferences.mm:
2655         (+[WebPreferences initialize]):
2656
2657 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2658
2659         Fix an internal build after r235935
2660         https://bugs.webkit.org/show_bug.cgi?id=188996
2661
2662         * Carbon/HIWebView.mm:
2663         (Draw):
2664         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2665
2666 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2667
2668         Add IGNORE_WARNING_.* macros
2669         https://bugs.webkit.org/show_bug.cgi?id=188996
2670
2671         Reviewed by Michael Catanzaro.
2672
2673         * Carbon/CarbonUtils.m:
2674         (PoolCleaner):
2675         * Carbon/CarbonWindowAdapter.mm:
2676         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2677         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2678         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2679         (-[CarbonWindowAdapter _termWindowIfOwner]):
2680         (-[CarbonWindowAdapter _windowMovedToRect:]):
2681         (-[CarbonWindowAdapter setContentView:]):
2682         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2683         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2684         * Carbon/CarbonWindowFrame.m:
2685         (-[CarbonWindowFrame title]):
2686         * Carbon/HIViewAdapter.m:
2687         (+[HIViewAdapter getHIViewForNSView:]):
2688         * Carbon/HIWebView.mm:
2689         (overrideCGContext):
2690         (restoreCGContext):
2691         (Draw):
2692         * DOM/DOM.mm:
2693         * History/WebHistory.mm:
2694         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2695         * History/WebHistoryItem.mm:
2696         (-[WebHistoryItem icon]):
2697         * Misc/WebKitNSStringExtras.mm:
2698         (-[NSString _web_drawAtPoint:font:textColor:]):
2699         * Misc/WebNSImageExtras.m:
2700         (-[NSImage _web_scaleToMaxSize:]):
2701         (-[NSImage _web_dissolveToFraction:]):
2702         * Misc/WebNSPasteboardExtras.mm:
2703         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2704         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2705         * Panels/WebAuthenticationPanel.m:
2706         (-[WebAuthenticationPanel loadNib]):
2707         * Plugins/Hosted/NetscapePluginHostManager.mm:
2708         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2709         (WebKit::NetscapePluginHostManager::didCreateWindow):
2710         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2711         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2712         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2713         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2714         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2715         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2716         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2717         (-[WebHostedNetscapePluginView drawRect:]):
2718         * Plugins/Hosted/WebTextInputWindowController.m:
2719         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2720         * Plugins/WebBaseNetscapePluginView.mm:
2721         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2722         * Plugins/WebNetscapePluginPackage.mm:
2723         (-[WebNetscapePluginPackage _tryLoad]):
2724         * Plugins/WebNetscapePluginView.mm:
2725         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2726         (-[WebNetscapePluginView sendDrawRectEvent:]):
2727         (-[WebNetscapePluginView drawRect:]):
2728         * Plugins/WebPluginController.mm:
2729         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2730         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2731         * WebCoreSupport/PopupMenuMac.mm:
2732         (PopupMenuMac::populate):
2733         * WebCoreSupport/WebAlternativeTextClient.h:
2734         * WebCoreSupport/WebDragClient.mm:
2735         (WebDragClient::startDrag):
2736         * WebCoreSupport/WebFrameLoaderClient.mm:
2737         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2738         (webGetNSImage):
2739         * WebInspector/WebNodeHighlight.mm:
2740         * WebInspector/WebNodeHighlightView.mm:
2741         (-[WebNodeHighlightView drawRect:]):
2742         * WebView/WebClipView.mm:
2743         (-[WebClipView initWithFrame:]):
2744         * WebView/WebFrame.mm:
2745         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2746         (-[WebFrame _drawRect:contentsOnly:]):
2747         (-[WebFrame accessibilityRoot]):
2748         * WebView/WebFullScreenController.mm:
2749         (-[WebFullScreenController enterFullScreen:]):
2750         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2751         (-[WebFullScreenController exitFullScreen]):
2752         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2753         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2754         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2755         * WebView/WebHTMLView.mm:
2756         (-[NSWindow _web_borderView]):
2757         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2758         (-[WebHTMLView _setAsideSubviews]):
2759         (-[WebHTMLView _autoscroll]):
2760         (-[WebHTMLView drawRect:]):
2761         (-[WebHTMLView mouseDown:]):
2762         (-[WebHTMLView mouseDragged:]):
2763         (-[WebHTMLView mouseUp:]):
2764         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2765         (-[WebHTMLView knowsPageRange:]):
2766         (-[WebHTMLView accessibilityHitTest:]):
2767         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2768         (-[WebHTMLView _colorAsString:]):
2769         (-[WebHTMLView copyFont:]):
2770         (-[WebHTMLView _executeSavedKeypressCommands]):
2771         (-[WebHTMLView attachRootLayer:]):
2772         (-[WebHTMLView textStorage]):
2773         (-[WebHTMLView _updateSelectionForInputManager]):
2774         * WebView/WebPDFView.mm:
2775         (_applicationInfoForMIMEType):
2776         (-[WebPDFView centerSelectionInVisibleArea:]):
2777         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2778         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2779         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2780         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2781         * WebView/WebTextCompletionController.mm:
2782         (-[WebTextCompletionController _buildUI]):
2783         (-[WebTextCompletionController _placePopupWindow:]):
2784         * WebView/WebVideoFullscreenController.mm:
2785         * WebView/WebVideoFullscreenHUDWindowController.mm:
2786         (createMediaUIBackgroundView):
2787         * WebView/WebView.mm:
2788         (-[WebTextListTouchBarViewController initWithWebView:]):
2789         (-[WebView _dispatchTileDidDraw:]):
2790         (-[WebView encodeWithCoder:]):
2791         (-[WebView mainFrameIcon]):
2792         (LayerFlushController::flushLayers):
2793         * WebView/WebWindowAnimation.mm:
2794         (setScaledFrameForWindow):
2795
2796 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2797
2798         Remove unused needsDestruction class variables from HashTraits
2799         https://bugs.webkit.org/show_bug.cgi?id=189490
2800
2801         Reviewed by Daniel Bates.
2802
2803         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2804
2805 2018-09-07  Frederic Wang  <fwang@igalia.com>
2806
2807         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2808         https://bugs.webkit.org/show_bug.cgi?id=182230
2809
2810         Reviewed by Simon Fraser.
2811
2812         * DOM/DOMDocument.mm:
2813         (-[DOMDocument scrollingElement]): Use the new name.
2814
2815 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2816
2817         Refactor WebCore::EditAction to be an 8-bit enum class
2818         https://bugs.webkit.org/show_bug.cgi?id=189383
2819
2820         Reviewed by Dan Bernstein.
2821
2822         * WebCoreSupport/WebEditorClient.mm:
2823         (undoNameForEditAction):
2824         * WebView/WebHTMLView.mm:
2825         (-[WebHTMLView pasteFont:]):
2826         (-[WebHTMLView changeFont:]):
2827         (-[WebHTMLView changeAttributes:]):
2828         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2829         (-[WebHTMLView changeColor:]):
2830         * WebView/WebView.mm:
2831         (-[WebView setTypingStyle:]):
2832
2833 2018-09-06  Frederic Wang  <fwang@igalia.com>
2834
2835         Group options of scrollRectToVisible into a struct
2836         https://bugs.webkit.org/show_bug.cgi?id=189352
2837
2838         Reviewed by Simon Fraser.
2839
2840         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2841         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2842         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2843
2844 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2845
2846         [macOS] Cannot change font size at selection until font panel is shown
2847         https://bugs.webkit.org/show_bug.cgi?id=189295
2848         <rdar://problem/35593389>
2849
2850         Reviewed by Ryosuke Niwa.
2851
2852         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2853         WebCore ChangeLog for more details.
2854
2855         * WebView/WebHTMLView.mm:
2856         (-[WebHTMLView changeFont:]):
2857         (-[WebHTMLView changeAttributes:]):
2858         (-[WebHTMLView _originalFontA]): Deleted.
2859         (-[WebHTMLView _originalFontB]): Deleted.
2860         (fontNameForDescription): Deleted.
2861         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2862         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2863         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2864
2865 2018-09-05  Jer Noble  <jer.noble@apple.com>
2866
2867         Add MediaCapabilities as an Experimental Feature
2868         https://bugs.webkit.org/show_bug.cgi?id=189209
2869
2870         Reviewed by Eric Carlson.
2871
2872         RuntimeEnabledFeature -> Setting.
2873
2874         * WebView/WebView.mm:
2875         (-[WebView _preferencesChanged:]):
2876
2877 2018-09-04  Frederic Wang  <fwang@igalia.com>
2878
2879         Add basic support for ScrollIntoViewOptions
2880         https://bugs.webkit.org/show_bug.cgi?id=189258
2881
2882         Reviewed by Simon Fraser.
2883
2884         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2885         header so that this file can build despite the new scrollIntoView function.
2886
2887 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2890         https://bugs.webkit.org/show_bug.cgi?id=188890
2891         <rdar://problem/43648605>
2892
2893         Reviewed by Tim Horton.
2894
2895         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2896         more detail.
2897
2898         * WebCoreSupport/WebPlatformStrategies.h:
2899         * WebCoreSupport/WebPlatformStrategies.mm:
2900         (WebPlatformStrategies::allStringsForType):
2901
2902 2018-09-01  Darin Adler  <darin@apple.com>
2903
2904         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2905         https://bugs.webkit.org/show_bug.cgi?id=189072
2906         Reviewed by Dan Bernstein.
2907
2908         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2909         and declarations for NSURLDownload init methods.
2910
2911         * Misc/WebDownloadInternal.h: Removed.
2912
2913         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2914         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2915         "-Wdeprecated-declarations" because the method used here is deprecated.
2916
2917         * WebView/WebView.mm:
2918         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2919         used here is deprecated.
2920
2921 2018-08-31  Chris Dumez  <cdumez@apple.com>
2922
2923         Assertion hit in ~CompletionHandler() from ~WebFrame()
2924         https://bugs.webkit.org/show_bug.cgi?id=189199
2925         <rdar://problem/42657233>
2926
2927         Reviewed by Youenn Fablet.
2928
2929         * WebCoreSupport/WebFrameLoaderClient.h:
2930         * WebCoreSupport/WebFrameLoaderClient.mm:
2931         (WebFrameLoaderClient::dispatchWillSubmitForm):
2932
2933 2018-08-31  Antti Koivisto  <antti@apple.com>
2934
2935         Replace OptionSet |= and -= operators with add() and remove() functions
2936         https://bugs.webkit.org/show_bug.cgi?id=189169
2937
2938         Reviewed by Anders Carlsson.
2939
2940         * WebView/WebFrame.mm:
2941         (-[WebFrame _drawRect:contentsOnly:]):
2942         * WebView/WebView.mm:
2943         (coreOptions):
2944
2945 2018-08-31  Frederic Wang  <fwang@igalia.com>
2946
2947         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2948         https://bugs.webkit.org/show_bug.cgi?id=182053
2949
2950         Reviewed by Simon Fraser.
2951
2952         Add developer flag to use standard behavior for scrolling* attributes.
2953
2954         * WebView/WebPreferenceKeysPrivate.h:
2955         * WebView/WebPreferences.mm:
2956         (+[WebPreferences initialize]):
2957         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2958         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2959         * WebView/WebPreferencesPrivate.h:
2960         * WebView/WebView.mm:
2961         (-[WebView _preferencesChanged:]):
2962
2963 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2964
2965         Implement the Web Share API
2966         https://bugs.webkit.org/show_bug.cgi?id=171100
2967         <rdar://problem/31751734>
2968
2969         Reviewed by Tim Horton.
2970
2971         * WebCoreSupport/WebChromeClient.h:
2972         * WebCoreSupport/WebChromeClient.mm:
2973         (WebChromeClient::showShareSheet):
2974         Empty declaration of showShareSheet.
2975
2976 2018-08-29  Youenn Fablet  <youenn@apple.com>
2977
2978         Remove WebRTC legacy API implementation
2979         https://bugs.webkit.org/show_bug.cgi?id=189040
2980
2981         Reviewed by Eric Carlson.
2982
2983         * WebView/WebPreferenceKeysPrivate.h:
2984         * WebView/WebPreferences.mm:
2985         (+[WebPreferences initialize]):
2986         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2987         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2988         * WebView/WebPreferencesPrivate.h:
2989         * WebView/WebView.mm:
2990         (-[WebView _preferencesChanged:]):
2991
2992 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2993
2994         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2995         https://bugs.webkit.org/show_bug.cgi?id=189054
2996
2997         Reviewed by Andy Estes.
2998
2999         Remove the pasteboard type argument from readURLFromPasteboard.
3000
3001         * WebCoreSupport/WebPlatformStrategies.h:
3002         * WebCoreSupport/WebPlatformStrategies.mm:
3003         (WebPlatformStrategies::readURLFromPasteboard):
3004
3005 2018-08-27  Keith Rollin  <krollin@apple.com>
3006
3007         Unreviewed build fix -- disable LTO for production builds
3008
3009         * Configurations/Base.xcconfig:
3010
3011 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3012
3013         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3014         https://bugs.webkit.org/show_bug.cgi?id=188931
3015
3016         Reviewed by Wenson Hsieh.
3017
3018         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3019
3020 2018-08-27  Keith Rollin  <krollin@apple.com>
3021
3022         Build system support for LTO
3023         https://bugs.webkit.org/show_bug.cgi?id=187785
3024         <rdar://problem/42353132>
3025
3026         Reviewed by Dan Bernstein.
3027
3028         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3029         LTO.
3030
3031         * Configurations/Base.xcconfig:
3032         * Configurations/DebugRelease.xcconfig:
3033
3034 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3035
3036         Pass in IsComposed flag to Event constructors
3037         https://bugs.webkit.org/show_bug.cgi?id=188720
3038         <rdar://problem/43580387>
3039
3040         Reviewed by Simon Fraser.
3041
3042         * WebView/WebPDFView.mm:
3043         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3044         whether it's simulated or not.
3045
3046 2018-08-23  Mark Lam  <mark.lam@apple.com>
3047
3048         Move vmEntryGlobalObject() to VM from CallFrame.
3049         https://bugs.webkit.org/show_bug.cgi?id=188900
3050         <rdar://problem/43655753>
3051
3052         Reviewed by Michael Saboff.
3053
3054         * WebView/WebScriptDebugger.mm:
3055         (WebScriptDebugger::sourceParsed):
3056
3057 2018-08-23  Andy Estes  <aestes@apple.com>
3058
3059         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3060         https://bugs.webkit.org/show_bug.cgi?id=188829
3061
3062         Reviewed by Tim Horton.
3063
3064         * Configurations/FeatureDefines.xcconfig:
3065
3066 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3067
3068         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3069         https://bugs.webkit.org/show_bug.cgi?id=188777
3070
3071         Reviewed by Simon Fraser.
3072
3073         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3074         being "true" before the code change.
3075
3076         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3077
3078         * WebView/WebPDFView.mm:
3079         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3080
3081 2018-08-21  Daniel Bates  <dabates@apple.com>
3082
3083         Replace TextCheckingTypeMask with OptionSet
3084         https://bugs.webkit.org/show_bug.cgi?id=188678
3085
3086         Reviewed by Antti Koivisto.
3087
3088         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3089         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3090         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3091         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3092
3093         * WebCoreSupport/WebEditorClient.h:
3094         * WebCoreSupport/WebEditorClient.mm:
3095         (WebEditorClient::checkTextOfParagraph):
3096         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3097         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3098         left as this is more readable and unncessary now that modern compilers like Clang have
3099         diagnostics to catch accidental assignments when equality was intended.
3100         (WebEditorClient::didCheckSucceed):
3101         * WebView/WebView.mm:
3102         (coreTextCheckingType):
3103         (textCheckingResultFromNSTextCheckingResult):
3104
3105 2018-08-21  Daniel Bates  <dabates@apple.com>
3106
3107         [iOS][WK1] Support toggling continuous spell checking from tests
3108         https://bugs.webkit.org/show_bug.cgi?id=188763
3109
3110         Reviewed by Simon Fraser.
3111
3112         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3113         spell checking from tests in iOS WebKit Legacy.
3114
3115         * WebCoreSupport/WebEditorClient.h:
3116         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3117         * WebCoreSupport/WebEditorClient.mm:
3118         * WebView/WebView.h:
3119         * WebView/WebView.mm:
3120         (-[WebView toggleContinuousSpellChecking:]):
3121         (-[WebView toggleSmartInsertDelete:]):
3122
3123 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3124
3125         Add some plumbing for safe browsing
3126         https://bugs.webkit.org/show_bug.cgi?id=188709
3127
3128         Reviewed by Tim Horton.
3129
3130         * WebCoreSupport/WebFrameLoaderClient.h:
3131         * WebCoreSupport/WebFrameLoaderClient.mm:
3132         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3133
3134 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3135
3136         Replace canBubble and cancelable booleans in Event by enum classes
3137         https://bugs.webkit.org/show_bug.cgi?id=188692
3138
3139         Reviewed by Alex Christensen.
3140
3141         * WebView/WebPDFView.mm:
3142         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3143         * WebView/WebView.mm:
3144         (-[WebView _dispatchUnloadEvent]):
3145
3146 2018-08-16  Jer Noble  <jer.noble@apple.com>
3147
3148         Add Experimental Feature support for SourceBuffer.changeType()
3149         https://bugs.webkit.org/show_bug.cgi?id=188626
3150         <rdar://problem/43356021>
3151
3152         Reviewed by Eric Carlson.
3153
3154         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3155
3156         * WebView/WebPreferenceKeysPrivate.h:
3157         * WebView/WebPreferences.mm:
3158         (+[WebPreferences initialize]):
3159         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3160         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3161         * WebView/WebPreferencesPrivate.h:
3162         * WebView/WebView.mm:
3163         (-[WebView _preferencesChanged:]):
3164
3165 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3166
3167         Support drag-and-drop for input[type=color]
3168         https://bugs.webkit.org/show_bug.cgi?id=188464
3169
3170         Reviewed by Wenson Hsieh.
3171
3172         * WebCoreSupport/WebPlatformStrategies.h:
3173         * WebCoreSupport/WebPlatformStrategies.mm:
3174         (WebPlatformStrategies::setColor):
3175
3176 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3177
3178         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3179         https://bugs.webkit.org/show_bug.cgi?id=188569
3180         <rdar://problem/34201095>
3181
3182         Reviewed by Megan Gardner.
3183
3184         * WebView/WebImmediateActionController.mm:
3185         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3186         Speculative fix; the crashes indicate font is null, but we just checked it,
3187         so it must be getting made null by convertFont:toSize:. Check again!
3188
3189 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3190
3191         Use a 1-byte enum class for TextDirection
3192         https://bugs.webkit.org/show_bug.cgi?id=188350
3193
3194         Reviewed by Simon Fraser.
3195
3196         * WebCoreSupport/PopupMenuMac.mm:
3197         (PopupMenuMac::populate):
3198         (PopupMenuMac::show):
3199         * WebCoreSupport/WebFrameLoaderClient.mm:
3200         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3201         * WebView/WebFrame.mm:
3202         (-[WebFrame _dispatchDidReceiveTitle:]):
3203
3204 2018-08-09  Ali Juma  <ajuma@chromium.org>
3205
3206         Import WPTs for IntersectionObserver
3207         https://bugs.webkit.org/show_bug.cgi?id=188416
3208
3209         Reviewed by Simon Fraser.
3210
3211         * WebView/WebPreferencesPrivate.h:
3212
3213 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3214
3215         Follow-up build fix for r234685
3216         https://bugs.webkit.org/show_bug.cgi?id=188245
3217
3218         Unreviewed build fix.
3219
3220         * WebCoreSupport/WebSecurityOriginPrivate.h:
3221
3222 2018-08-05  Darin Adler  <darin@apple.com>
3223
3224         [Cocoa] More tweaks and refactoring to prepare for ARC
3225         https://bugs.webkit.org/show_bug.cgi?id=188245
3226
3227         Reviewed by Dan Bernstein.
3228
3229         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3230
3231         * Carbon/CarbonWindowFrame.m:
3232         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3233
3234         * DOM/DOM.mm:
3235         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3236         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3237         garbage collection so this method isn't useful.
3238
3239         * DOM/DOMXPath.mm:
3240         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3241         Objective-C garbage collection so this method isn't useful.
3242
3243         * History/WebHistory.mm:
3244         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3245
3246         * Misc/WebElementDictionary.mm:
3247         (addLookupKey): Use a bridging cast.
3248         (cacheValueForKey): Ditto.
3249         (-[WebElementDictionary _fillCache]): Ditto.
3250         (-[WebElementDictionary objectForKey:]): Ditto.
3251
3252         * Misc/WebKitNSStringExtras.mm:
3253         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3254         (-[NSString _web_widthWithFont:]): Ditto.
3255         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3256
3257         * Misc/WebLocalizableStrings.mm:
3258         (WebLocalizedString): Use a bridging cast.
3259
3260         * Misc/WebNSDataExtras.mm:
3261         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3262         and use CFBridgingRelease instead of calling autorelease directly.
3263         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3264         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3265         on the amount of explicit release and autorelease.
3266
3267         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3268         * Misc/WebNSDictionaryExtras.m:
3269         (-[NSDictionary _webkit_intForKey:]): Deleted.
3270         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3271         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3272         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3273         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3274         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3275         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3276
3277         * Misc/WebStringTruncator.mm:
3278         (fontFromNSFont): Use a bridging cast.
3279
3280         * Plugins/Hosted/NetscapePluginHostManager.mm:
3281         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3282
3283         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3284         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3285         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3286         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3287         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3288         * Plugins/Hosted/ProxyInstance.mm:
3289         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3290         * Plugins/WebBasePluginPackage.mm:
3291         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3292         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3293         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3294         * Plugins/WebNetscapePluginPackage.mm:
3295         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3296
3297         * Plugins/WebNetscapePluginView.mm:
3298         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3299         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3300         (-[WebNetscapePluginView status:]): Use a bridging cast.
3301         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3302
3303         * Plugins/WebPluginController.mm:
3304         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3305
3306         * Plugins/WebPluginDatabase.mm:
3307         (checkCandidate): Use explicit __strong for out argument types.
3308
3309         * Plugins/npapi.mm:
3310         (pluginViewForInstance): Use a bridging cast.
3311
3312         * Storage/WebDatabaseManager.mm:
3313         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3314         explicit NSNumber and NSDictionary calls.
3315
3316         * WebCoreSupport/WebContextMenuClient.mm:
3317         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3318
3319         * WebCoreSupport/WebEditorClient.mm:
3320         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3321         (WebEditorClient::handleInputMethodKeydown): Ditto.
3322
3323         * WebCoreSupport/WebFrameNetworkingContext.mm:
3324         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3325
3326         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3327         as a struct rather than an Objective-C class, since that's how it's defined.
3328
3329         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3330
3331         * WebView/WebFullScreenController.mm:
3332         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3333         * WebView/WebHTMLView.mm:
3334         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3335         Ditto.
3336         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3337
3338         * WebView/WebImmediateActionController.mm:
3339         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3340         go down to the document and then back to the frame.
3341         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3342         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3343         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3344
3345         * WebView/WebJSPDFDoc.mm:
3346         (jsPDFDocInitialize): Removed some unneeded type casting.
3347         (jsPDFDocFinalize): Ditto.
3348         (jsPDFDocPrint): Use a bridging cast.
3349
3350         * WebView/WebPDFView.mm:
3351         (_applicationInfoForMIMEType): Use bridging casts.
3352
3353         * WebView/WebPreferences.mm:
3354         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3355         instead of methods from WebNSDictionaryExtras.
3356         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3357         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3358         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3359         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3360         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3361
3362         * WebView/WebView.mm:
3363         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3364         (-[WebView _addToAllWebViewsSet]): Ditto.
3365         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3366         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3367         so it can be called from WebViewData methods.
3368
3369         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3370         method, _windowVisibilityChanged:.
3371
3372         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3373         called from WebViewData methods.
3374
3375 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3376
3377         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3378         https://bugs.webkit.org/show_bug.cgi?id=188323
3379
3380         Reviewed by Simon Fraser.
3381
3382         * WebCoreSupport/WebContextMenuClient.mm:
3383         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3384         * WebView/WebFrame.mm:
3385         (-[WebFrame _paintBehaviorForDestinationContext:]):
3386         (-[WebFrame _drawRect:contentsOnly:]):
3387         * WebView/WebHTMLView.mm:
3388         (imageFromRect):
3389         (selectionImage):
3390
3391 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3392
3393         Add support for microtasks in workers
3394         https://bugs.webkit.org/show_bug.cgi?id=188246
3395
3396         Reviewed by Darin Adler.
3397
3398         Rename JSMainThreadExecState.h to JSExecState.h.
3399
3400         * DOM/DOMAttr.mm:
3401         * DOM/DOMBlob.mm:
3402         * DOM/DOMCDATASection.mm:
3403         * DOM/DOMCSSCharsetRule.mm:
3404         * DOM/DOMCSSFontFaceRule.mm:
3405         * DOM/DOMCSSImportRule.mm:
3406         * DOM/DOMCSSMediaRule.mm:
3407         * DOM/DOMCSSPageRule.mm:
3408         * DOM/DOMCSSPrimitiveValue.mm:
3409         * DOM/DOMCSSRule.mm:
3410         * DOM/DOMCSSRuleList.mm:
3411         * DOM/DOMCSSStyleDeclaration.mm:
3412         * DOM/DOMCSSStyleRule.mm:
3413         * DOM/DOMCSSStyleSheet.mm:
3414         * DOM/DOMCSSUnknownRule.mm:
3415         * DOM/DOMCSSValue.mm:
3416         * DOM/DOMCSSValueList.mm:
3417         * DOM/DOMCharacterData.mm:
3418         * DOM/DOMComment.mm:
3419         * DOM/DOMCounter.mm:
3420         * DOM/DOMDocument.mm:
3421         * DOM/DOMDocumentFragment.mm:
3422         * DOM/DOMDocumentType.mm:
3423         * DOM/DOMElement.mm:
3424         * DOM/DOMEvent.mm:
3425         * DOM/DOMFile.mm:
3426         * DOM/DOMFileList.mm:
3427         * DOM/DOMHTML.mm:
3428         * DOM/DOMHTMLAnchorElement.mm:
3429         * DOM/DOMHTMLAppletElement.mm:
3430         * DOM/DOMHTMLAreaElement.mm:
3431         * DOM/DOMHTMLBRElement.mm:
3432         * DOM/DOMHTMLBaseElement.mm:
3433         * DOM/DOMHTMLBaseFontElement.mm:
3434         * DOM/DOMHTMLBodyElement.mm:
3435         * DOM/DOMHTMLButtonElement.mm:
3436         * DOM/DOMHTMLCanvasElement.mm:
3437         * DOM/DOMHTMLCollection.mm:
3438         * DOM/DOMHTMLDListElement.mm:
3439         * DOM/DOMHTMLDirectoryElement.mm:
3440         * DOM/DOMHTMLDivElement.mm:
3441         * DOM/DOMHTMLDocument.mm:
3442         * DOM/DOMHTMLElement.mm:
3443         * DOM/DOMHTMLEmbedElement.mm:
3444         * DOM/DOMHTMLFieldSetElement.mm:
3445         * DOM/DOMHTMLFontElement.mm:
3446         * DOM/DOMHTMLFormElement.mm:
3447         * DOM/DOMHTMLFrameElement.mm:
3448         * DOM/DOMHTMLFrameSetElement.mm:
3449         * DOM/DOMHTMLHRElement.mm:
3450         * DOM/DOMHTMLHeadElement.mm:
3451         * DOM/DOMHTMLHeadingElement.mm:
3452         * DOM/DOMHTMLHtmlElement.mm:
3453         * DOM/DOMHTMLIFrameElement.mm:
3454         * DOM/DOMHTMLImageElement.mm:
3455         * DOM/DOMHTMLInputElement.mm:
3456         * DOM/DOMHTMLLIElement.mm:
3457         * DOM/DOMHTMLLabelElement.mm:
3458         * DOM/DOMHTMLLegendElement.mm:
3459         * DOM/DOMHTMLLinkElement.mm:
3460         * DOM/DOMHTMLMapElement.mm:
3461         * DOM/DOMHTMLMarqueeElement.mm:
3462         * DOM/DOMHTMLMediaElement.mm:
3463         * DOM/DOMHTMLMenuElement.mm:
3464         * DOM/DOMHTMLMetaElement.mm:
3465         * DOM/DOMHTMLModElement.mm:
3466         * DOM/DOMHTMLOListElement.mm:
3467         * DOM/DOMHTMLObjectElement.mm:
3468         * DOM/DOMHTMLOptGroupElement.mm: