SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-18  Jer Noble  <jer.noble@apple.com>
2
3         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4         https://bugs.webkit.org/show_bug.cgi?id=189553
5
6         Reviewed by Tim Horton.
7
8         * Configurations/Base.xcconfig:
9         * Configurations/SDKVariant.xcconfig: Added.
10         * Configurations/WebKitLegacy.xcconfig:
11
12 2019-01-18  David Kilzer  <ddkilzer@apple.com>
13
14         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
15         <https://webkit.org/b/193568>
16         <rdar://problem/47381130>
17
18         Reviewed by Alex Christensen.
19
20         * WebView/WebView.mm:
21         - Remove unused soft-linking macros.
22         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
23         (-[WebUITextIndicatorData initWithImage:scale:]):
24         - Update to use exported PAL functions.
25
26 2019-01-17  Truitt Savell  <tsavell@apple.com>
27
28         Unreviewed, rolling out r240124.
29
30         This commit broke an internal build.
31
32         Reverted changeset:
33
34         "SDK_VARIANT build destinations should be separate from non-
35         SDK_VARIANT builds"
36         https://bugs.webkit.org/show_bug.cgi?id=189553
37         https://trac.webkit.org/changeset/240124
38
39 2019-01-17  Jer Noble  <jer.noble@apple.com>
40
41         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
42         https://bugs.webkit.org/show_bug.cgi?id=189553
43
44         Reviewed by Tim Horton.
45
46         * Configurations/Base.xcconfig:
47         * Configurations/SDKVariant.xcconfig: Added.
48         * Configurations/WebKitLegacy.xcconfig:
49
50 2019-01-17  Alex Christensen  <achristensen@webkit.org>
51
52         Stop using NetworkStorageSession::storageSession in WebCore
53         https://bugs.webkit.org/show_bug.cgi?id=193529
54
55         Reviewed by Tim Horton.
56
57         * Misc/WebCache.mm:
58         (+[WebCache addImageToCache:forURL:forFrame:]):
59         * WebView/WebView.mm:
60         (-[WebView _commonInitializationWithFrameName:groupName:]):
61         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
62
63 2019-01-15  Alex Christensen  <achristensen@webkit.org>
64
65         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
66         https://bugs.webkit.org/show_bug.cgi?id=193368
67
68         Reviewed by Geoff Garen.
69
70         * Misc/WebCache.mm:
71         (+[WebCache clearCachedCredentials]):
72         * Misc/WebDownload.mm:
73         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
74         * Plugins/WebBaseNetscapePluginView.mm:
75         (WebKit::getAuthenticationInfo):
76
77 2019-01-15  Alex Christensen  <achristensen@webkit.org>
78
79         Stop using CookiesStrategy
80         https://bugs.webkit.org/show_bug.cgi?id=161106
81
82         Reviewed by Don Olmstead and Antti Koivisto.
83
84         * Misc/WebCache.mm:
85         (+[WebCache addImageToCache:forURL:forFrame:]):
86         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
87         (WebKit::NetscapePluginInstanceProxy::getCookies):
88         (WebKit::NetscapePluginInstanceProxy::setCookies):
89         * Plugins/WebNetscapePluginView.mm:
90         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
91         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
92         * WebCoreSupport/WebPlatformStrategies.h:
93         * WebCoreSupport/WebPlatformStrategies.mm:
94         (WebPlatformStrategies::createCookiesStrategy): Deleted.
95         (WebPlatformStrategies::cookiesForDOM): Deleted.
96         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
97         (WebPlatformStrategies::cookiesEnabled): Deleted.
98         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
99         (WebPlatformStrategies::getRawCookies): Deleted.
100         (WebPlatformStrategies::deleteCookie): Deleted.
101         * WebView/WebView.mm:
102         (-[WebView _commonInitializationWithFrameName:groupName:]):
103         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
104
105 2019-01-15  Tim Horton  <timothy_horton@apple.com>
106
107         Cannot tab out of WKWebView on macOS
108         https://bugs.webkit.org/show_bug.cgi?id=161448
109         <rdar://problem/28100085>
110
111         Reviewed by Dean Jackson.
112
113         * WebCoreSupport/WebChromeClient.mm:
114         * WebView/WebView.mm:
115         Make use of SPI headers.
116
117 2019-01-14  Commit Queue  <commit-queue@webkit.org>
118
119         Unreviewed, rolling out r239901, r239909, r239910, r239912,
120         r239913, and r239914.
121         https://bugs.webkit.org/show_bug.cgi?id=193407
122
123         These revisions caused an internal failure (Requested by
124         Truitt on #webkit).
125
126         Reverted changesets:
127
128         "[Cocoa] Avoid importing directly from subumbrella frameworks"
129         https://bugs.webkit.org/show_bug.cgi?id=186016
130         https://trac.webkit.org/changeset/239901
131
132         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
133         https://trac.webkit.org/changeset/239909
134
135         "Tried to fix the build."
136         https://trac.webkit.org/changeset/239910
137
138         "Fixed iOS builds after r239910."
139         https://trac.webkit.org/changeset/239912
140
141         "More build fixing."
142         https://trac.webkit.org/changeset/239913
143
144         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
145         https://trac.webkit.org/changeset/239914
146
147 2019-01-14  Mark Lam  <mark.lam@apple.com>
148
149         Re-enable ability to build --cloop builds.
150         https://bugs.webkit.org/show_bug.cgi?id=192955
151         <rdar://problem/46882363>
152
153         Reviewed by Saam barati and Keith Miller.
154
155         * Configurations/FeatureDefines.xcconfig:
156
157 2019-01-13  Dan Bernstein  <mitz@apple.com>
158
159         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
160
161         Patch by Keith Rollin.
162
163         * WebView/PDFViewSPI.h:
164
165 2019-01-12  Timothy Hatcher  <timothy@apple.com>
166
167         Have prefers-color-scheme: light always match on macOS versions before Mojave.
168         https://bugs.webkit.org/show_bug.cgi?id=191655
169         rdar://problem/46074680
170
171         Reviewed by Megan Gardner.
172
173         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
174         * WebView/WebView.mm:
175         (-[WebView _effectiveAppearanceIsDark]):
176
177 2019-01-12  Dan Bernstein  <mitz@apple.com>
178
179         [Cocoa] Avoid importing directly from subumbrella frameworks
180         https://bugs.webkit.org/show_bug.cgi?id=186016
181         <rdar://problem/40591038>
182
183         Reviewed by Sam Weinig.
184
185         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
186         * Carbon/CarbonWindowAdapter.mm: Ditto.
187         * Carbon/CarbonWindowFrame.m: Ditto.
188         * Carbon/HIViewAdapter.h: Ditto.
189         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
190           OTHER_CFLAGS_COCOA_TOUCH_NO.
191         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
192         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
193         * WebView/WebPDFView.h: Ditto.
194
195 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
196
197         Enable visual viewport API by default
198         https://bugs.webkit.org/show_bug.cgi?id=193376
199
200         Reviewed by Simon Fraser.
201
202         * WebView/WebPreferences.mm:
203         (+[WebPreferences initialize]):
204
205 2019-01-11  John Wilander  <wilander@apple.com>
206
207         Compile out Web API Statistics Collection
208         https://bugs.webkit.org/show_bug.cgi?id=193370
209         <rdar://problem/45388584>
210
211         Reviewed by Brent Fulgham.
212
213         * Configurations/FeatureDefines.xcconfig:
214             Defined ENABLE_WEB_API_STATISTICS, off by default.
215
216 2019-01-08  Alex Christensen  <achristensen@webkit.org>
217
218         Stop using NetworkStorageSession in WebProcess
219         https://bugs.webkit.org/show_bug.cgi?id=193236
220
221         Reviewed by Don Olmstead.
222
223         * WebCoreSupport/WebFrameNetworkingContext.h:
224         * WebCoreSupport/WebFrameNetworkingContext.mm:
225         (WebFrameNetworkingContext::storageSession const):
226         * WebCoreSupport/WebPlatformStrategies.h:
227         * WebCoreSupport/WebPlatformStrategies.mm:
228         (WebPlatformStrategies::cookiesForDOM):
229         (WebPlatformStrategies::setCookiesFromDOM):
230         (WebPlatformStrategies::cookiesEnabled):
231         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
232         (WebPlatformStrategies::getRawCookies):
233         (WebPlatformStrategies::deleteCookie):
234         * WebView/WebView.mm:
235         (-[WebView _cachedResponseForURL:]):
236         (-[WebView _clearCredentials]):
237
238 2019-01-08  Alex Christensen  <achristensen@webkit.org>
239
240         Unreviewed, rolling out r239727.
241
242         Broke API tests
243
244         Reverted changeset:
245
246         "Stop using NetworkStorageSession in WebProcess"
247         https://bugs.webkit.org/show_bug.cgi?id=193236
248         https://trac.webkit.org/changeset/239727
249
250 2019-01-08  Alex Christensen  <achristensen@webkit.org>
251
252         Stop using NetworkStorageSession in WebProcess
253         https://bugs.webkit.org/show_bug.cgi?id=193236
254
255         Reviewed by Don Olmstead.
256
257         * WebCoreSupport/WebFrameNetworkingContext.h:
258         * WebCoreSupport/WebFrameNetworkingContext.mm:
259         (WebFrameNetworkingContext::storageSession const):
260         * WebView/WebView.mm:
261         (-[WebView _cachedResponseForURL:]):
262         (-[WebView _clearCredentials]):
263
264 2019-01-07  David Kilzer  <ddkilzer@apple.com>
265
266         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
267         <https://webkit.org/b/193056>
268
269         Reviewed by Alex Christensen.
270
271         * Plugins/Hosted/NetscapePluginHostProxy.h:
272         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
273         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
274         (WebKit::NetscapePluginInstanceProxy::enumerate):
275         (WebKit::NetscapePluginInstanceProxy::marshalValue):
276         (WebKit::NetscapePluginInstanceProxy::marshalValues):
277         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
278         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
279         * Plugins/Hosted/ProxyInstance.mm:
280         (WebKit::ProxyInstance::invoke):
281         * WebCoreSupport/WebGeolocationClient.mm:
282         * WebView/WebDataSource.mm:
283         (-[WebDataSource _receivedData:]):
284         * WebView/WebView.mm:
285         (-[WebView _cachedResponseForURL:]):
286         - Remove '*' from RetainPtr<> type.
287
288 2019-01-04  Alex Christensen  <achristensen@webkit.org>
289
290         Progress towards fixing Mac CMake build
291         https://bugs.webkit.org/show_bug.cgi?id=193105
292
293         Reviewed by Don Olmstead.
294
295         * WebKitPrefix.h:
296
297 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
298
299         Web Inspector: Use save sheet instead of dialog where possible
300         https://bugs.webkit.org/show_bug.cgi?id=193160
301         <rdar://problem/37399759>
302
303         Reviewed by Devin Rousso.
304
305         * WebCoreSupport/WebInspectorClient.mm:
306         (WebInspectorFrontendClient::save):
307
308 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
309
310         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
311         https://bugs.webkit.org/show_bug.cgi?id=193129
312
313         Reviewed by Tim Horton.
314
315         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
316
317         * WebCoreSupport/WebEditorClient.mm:
318         (WebEditorClient::registerUndoOrRedoStep):
319         (undoNameForEditAction): Deleted.
320
321 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
322
323         Add support for using the current text selection as the find string on iOS
324         https://bugs.webkit.org/show_bug.cgi?id=193034
325         <rdar://problem/45138739>
326
327         Reviewed by Tim Horton.
328
329         Add a method stub for WebKitLegacy.
330
331         * WebCoreSupport/WebEditorClient.h:
332
333 2019-01-01  Jeff Miller  <jeffm@apple.com>
334
335         Update user-visible copyright strings to include 2019
336         https://bugs.webkit.org/show_bug.cgi?id=192811
337
338         Reviewed by Mark Lam.
339
340         * Info.plist:
341
342 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
343
344         Use Ref<> as much as possible
345         https://bugs.webkit.org/show_bug.cgi?id=192808
346
347         Reviewed by Alex Christensen.
348
349         * DOM/DOM.mm:
350         (-[DOMNode getPreviewSnapshotImage:andRects:]):
351         * Plugins/Hosted/NetscapePluginHostManager.mm:
352         (WebKit::NetscapePluginHostManager::instantiatePlugin):
353         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
354         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
355         (WebKit::NetscapePluginInstanceProxy::loadRequest):
356         * Plugins/WebNetscapePluginView.mm:
357         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
358         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
359         * WebCoreSupport/WebContextMenuClient.mm:
360         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
361         * WebCoreSupport/WebFrameLoaderClient.mm:
362         (WebFrameLoaderClient::transitionToCommittedForNewPage):
363         * WebView/WebFrame.mm:
364         (-[WebFrame getDictationResultRanges:andMetadatas:]):
365         * WebView/WebHTMLView.mm:
366         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
367         * WebView/WebView.mm:
368         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
369         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
370
371 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
372
373         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
374         https://bugs.webkit.org/show_bug.cgi?id=192821
375
376         Reviewed by Chris Dumez.
377
378         When a window becomes occluded, the window server informs the application.
379         This should be used to suspend any work that is not visible by the user.
380
381         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
382         In some cases, that lead to performance impact (see radar).
383
384         This patch adds an observer for the occlusion notification. I tried to stick
385         with the same names used by WebKit2.
386
387         * WebView/WebView.mm:
388         (-[WebView _isViewVisible]):
389         (-[WebView addWindowObserversForWindow:]):
390         (-[WebView removeWindowObservers]):
391         (-[WebView _windowDidChangeOcclusionState:]):
392
393 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
394
395         [WebAuthN] Add a runtime flag for local authenticator
396         https://bugs.webkit.org/show_bug.cgi?id=192792
397         <rdar://problem/46798738>
398
399         Reviewed by Brent Fulgham.
400
401         * WebView/WebPreferenceKeysPrivate.h:
402         * WebView/WebPreferences.mm:
403         (+[WebPreferences initialize]):
404         (-[WebPreferences webAuthenticationEnabled]): Deleted.
405         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
406         * WebView/WebPreferencesPrivate.h:
407         * WebView/WebView.mm:
408         (-[WebView _preferencesChanged:]):
409
410 2018-12-20  Chris Dumez  <cdumez@apple.com>
411
412         Use Optional::valueOr() instead of Optional::value_or()
413         https://bugs.webkit.org/show_bug.cgi?id=192933
414
415         Reviewed by Geoffrey Garen.
416
417         * WebCoreSupport/WebSecurityOrigin.mm:
418         (-[WebSecurityOrigin port]):
419
420 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
421
422         Unreviewed, rolling out r239417.
423
424         Introduced two API test failures on macOS.
425
426         Reverted changeset:
427
428         "<rdar://problem/46194315> macOS: WebKit1 does not handle
429         occlusion changes"
430         https://bugs.webkit.org/show_bug.cgi?id=192821
431         https://trac.webkit.org/changeset/239417
432
433 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
434
435         WKWebView default UA doesn't freeze the build number
436         https://bugs.webkit.org/show_bug.cgi?id=192809
437         <rdar://problem/44687185>
438
439         Reviewed by Andy Estes.
440
441         Always reports the frozen build number.
442
443         * WebView/WebView.mm:
444         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
445         actual build number through this method call.
446         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
447
448 2018-12-19  Chris Dumez  <cdumez@apple.com>
449
450         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
451         https://bugs.webkit.org/show_bug.cgi?id=192728
452         <rdar://problem/46746779>
453
454         Reviewed by Geoff Garen.
455
456         * DOM/*:
457         * Plugins/*:
458         * WebCoreSupport/*:
459         * WebView/*:
460
461 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
462
463         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
464         https://bugs.webkit.org/show_bug.cgi?id=192821
465
466         Reviewed by Chris Dumez.
467
468         When a window becomes occluded, the window server informs the application.
469         This should be used to suspend any work that is not visible by the user.
470
471         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
472         In some cases, that lead to performance impact (see radar).
473
474         This patch adds an observer for the occlusion notification. I tried to stick
475         with the same names used by WebKit2.
476
477         * WebView/WebView.mm:
478         (-[WebView _isViewVisible]):
479         (-[WebView addWindowObserversForWindow:]):
480         (-[WebView removeWindowObservers]):
481         (-[WebView _windowDidChangeOcclusionState:]):
482
483 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
484
485         Allow clients to set the navigator platform
486         https://bugs.webkit.org/show_bug.cgi?id=192735
487
488         Reviewed by Tim Horton.
489
490         Add stubs to fill out the added functionality in FrameLoaderClient.
491
492         * WebCoreSupport/WebFrameLoaderClient.h:
493         * WebCoreSupport/WebFrameLoaderClient.mm:
494         (WebFrameLoaderClient::navigatorPlatform):
495
496 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
497
498         offsetLeft and offsetParent should adjust across shadow boundaries
499         https://bugs.webkit.org/show_bug.cgi?id=157437
500         <rdar://problem/26154021>
501
502         Reviewed by Simon Fraser.
503
504         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
505
506         * DOM/DOMElement.mm:
507         (-[DOMElement offsetLeft]):
508         (-[DOMElement offsetTop]):
509         (-[DOMElement offsetParent]):
510
511 2018-12-17  Zalan Bujtas  <zalan@apple.com>
512
513         Unreviewed build fix.
514
515         * WebView/WebFrame.mm:
516         (-[WebFrame getDictationResultRanges:andMetadatas:]):
517
518 2018-12-15  Darin Adler  <darin@apple.com>
519
520         Use warning-ignoring macros more consistently and simply
521         https://bugs.webkit.org/show_bug.cgi?id=192743
522
523         Reviewed by Mark Lam.
524
525         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
526         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
527         compilers in Objective-C++ code.
528
529         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
530         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
531         accomodate non-clang compilers here. Also use #pragma once, add a missing
532         "explicit" and fix conditionals.
533
534 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
535
536         Make TextInputController.legacyAttributedString take DOM nodes and offsets
537         https://bugs.webkit.org/show_bug.cgi?id=192653
538
539         Reviewed by Wenson Hsieh.
540
541         * WebView/WebHTMLView.mm:
542         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
543
544 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
545
546         Implement feature flag for CSS Typed OM
547         https://bugs.webkit.org/show_bug.cgi?id=192610
548
549         Reviewed by Ryosuke Niwa.
550
551         * Configurations/FeatureDefines.xcconfig:
552
553 2018-12-11  Tim Horton  <timothy_horton@apple.com>
554
555         WebCore shouldn't have a Objective-C class named NSCursor
556         https://bugs.webkit.org/show_bug.cgi?id=192602
557         <rdar://problem/46615532>
558
559         Reviewed by Wenson Hsieh.
560
561         * WebView/WebFrameView.mm:
562         (-[WebFrameView keyDown:keyDown:]):
563         * WebView/WebHTMLView.mm:
564         (-[WebHTMLView keyDown:]):
565         (-[WebHTMLView performKeyEquivalent:]):
566         Only use NSCursor on macOS.
567
568 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
569
570         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
571         https://bugs.webkit.org/show_bug.cgi?id=192573
572
573         Reviewed by Simon Fraser.
574
575         * Configurations/FeatureDefines.xcconfig:
576
577 2018-12-10  Antti Koivisto  <antti@apple.com>
578
579         Rename "forced style recalc" to "full style rebuild"
580         https://bugs.webkit.org/show_bug.cgi?id=192572
581
582         Reviewed by Zalan Bujtas.
583
584         * WebView/WebHTMLView.mm:
585         (-[WebHTMLView setNeedsToApplyStyles:]):
586
587 2018-12-10  Darin Adler  <darin@apple.com>
588
589         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
590         https://bugs.webkit.org/show_bug.cgi?id=192533
591         rdar://problem/45732710
592
593         Reviewed by Anders Carlsson.
594
595         * Plugins/Hosted/NetscapePluginHostProxy.mm:
596         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
597
598 2018-12-10  Darin Adler  <darin@apple.com>
599
600         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
601         https://bugs.webkit.org/show_bug.cgi?id=192532
602         rdar://problem/45731047
603
604         Reviewed by Chris Dumez.
605
606         * Plugins/Hosted/NetscapePluginHostManager.mm:
607         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
608         * Plugins/Hosted/NetscapePluginHostProxy.mm:
609         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
610
611 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
612
613         Turn WritingDirection into an enum class
614         https://bugs.webkit.org/show_bug.cgi?id=192401
615         Work towards <rdar://problem/42075638>
616
617         Reviewed by Dan Bernstein.
618
619         Change WritingDirection from an enum to an enum class. No change in behavior.
620
621         * WebView/WebHTMLView.mm:
622         (-[WebHTMLView toggleBaseWritingDirection:]):
623         (-[WebHTMLView changeBaseWritingDirection:]):
624         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
625
626 2018-12-03  Alex Christensen  <achristensen@webkit.org>
627
628         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
629         https://bugs.webkit.org/show_bug.cgi?id=192272
630
631         Reviewed by Brady Eidson.
632
633         * WebCoreSupport/WebFrameLoaderClient.h:
634         * WebCoreSupport/WebFrameLoaderClient.mm:
635         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
636
637 2018-12-03  Jer Noble  <jer.noble@apple.com>
638
639         Get rid of old, dead Mac video fullscreen code.
640         https://bugs.webkit.org/show_bug.cgi?id=192315
641
642         Reviewed by Eric Carlson.
643
644         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
645         is no longer supported in the Mac port.
646
647         * WebView/WebVideoFullscreenController.h: Removed.
648         * WebView/WebVideoFullscreenController.mm: Removed.
649         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
650         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
651         * WebView/WebView.mm:
652         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
653         (-[WebView _exitVideoFullscreen]):
654
655 2018-12-03  Daniel Bates  <dabates@apple.com>
656
657         [iOS] Do not handle key events that are key commands
658         https://bugs.webkit.org/show_bug.cgi?id=191608
659         <rdar://problem/46046013>
660
661         Reviewed by Ryosuke Niwa.
662
663         A key down event may be associated with a key command. If it is then we want to execute the
664         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
665         event as a key command to find out.
666
667         * WebView/WebHTMLView.mm:
668         (-[WebHTMLView _handleEditingKeyEvent:]):
669
670 2018-12-02  Zalan Bujtas  <zalan@apple.com>
671
672         Add a runtime feature flag for LayoutFormattingContext.
673         https://bugs.webkit.org/show_bug.cgi?id=192280
674
675         Reviewed by Simon Fraser.
676
677         * Configurations/FeatureDefines.xcconfig:
678
679 2018-11-30  Alex Christensen  <achristensen@webkit.org>
680
681         Move URL from WebCore to WTF
682         https://bugs.webkit.org/show_bug.cgi?id=190234
683
684         Reviewed by Keith Miller.
685
686         * DOM/DOMAttr.mm:
687         * DOM/DOMBlob.mm:
688         * DOM/DOMCSSCharsetRule.mm:
689         * DOM/DOMCSSImportRule.mm:
690         * DOM/DOMCSSMediaRule.mm:
691         * DOM/DOMCSSPageRule.mm:
692         * DOM/DOMCSSPrimitiveValue.mm:
693         * DOM/DOMCSSRule.mm:
694         * DOM/DOMCSSStyleDeclaration.mm:
695         * DOM/DOMCSSStyleRule.mm:
696         * DOM/DOMCSSStyleSheet.mm:
697         * DOM/DOMCSSValue.mm:
698         * DOM/DOMCharacterData.mm:
699         * DOM/DOMCounter.mm:
700         * DOM/DOMDocument.mm:
701         * DOM/DOMDocumentFragment.mm:
702         * DOM/DOMDocumentType.mm:
703         * DOM/DOMEvent.mm:
704         * DOM/DOMFile.mm:
705         * DOM/DOMHTMLAnchorElement.mm:
706         * DOM/DOMHTMLAppletElement.mm:
707         * DOM/DOMHTMLAreaElement.mm:
708         * DOM/DOMHTMLBRElement.mm:
709         * DOM/DOMHTMLBaseElement.mm:
710         * DOM/DOMHTMLBaseFontElement.mm:
711         * DOM/DOMHTMLBodyElement.mm:
712         * DOM/DOMHTMLButtonElement.mm:
713         * DOM/DOMHTMLCanvasElement.mm:
714         * DOM/DOMHTMLCollection.mm:
715         * DOM/DOMHTMLDivElement.mm:
716         * DOM/DOMHTMLDocument.mm:
717         * DOM/DOMHTMLElement.mm:
718         * DOM/DOMHTMLEmbedElement.mm:
719         * DOM/DOMHTMLFieldSetElement.mm:
720         * DOM/DOMHTMLFontElement.mm:
721         * DOM/DOMHTMLFormElement.mm:
722         * DOM/DOMHTMLFrameElement.mm:
723         * DOM/DOMHTMLFrameSetElement.mm:
724         * DOM/DOMHTMLHRElement.mm:
725         * DOM/DOMHTMLHeadElement.mm:
726         * DOM/DOMHTMLHeadingElement.mm:
727         * DOM/DOMHTMLHtmlElement.mm:
728         * DOM/DOMHTMLIFrameElement.mm:
729         * DOM/DOMHTMLImageElement.mm:
730         * DOM/DOMHTMLInputElement.mm:
731         * DOM/DOMHTMLLIElement.mm:
732         * DOM/DOMHTMLLabelElement.mm:
733         * DOM/DOMHTMLLegendElement.mm:
734         * DOM/DOMHTMLLinkElement.mm:
735         * DOM/DOMHTMLMapElement.mm:
736         * DOM/DOMHTMLMarqueeElement.mm:
737         * DOM/DOMHTMLMediaElement.mm:
738         * DOM/DOMHTMLMetaElement.mm:
739         * DOM/DOMHTMLModElement.mm:
740         * DOM/DOMHTMLOListElement.mm:
741         * DOM/DOMHTMLObjectElement.mm:
742         * DOM/DOMHTMLOptGroupElement.mm:
743         * DOM/DOMHTMLOptionElement.mm:
744         * DOM/DOMHTMLOptionsCollection.mm:
745         * DOM/DOMHTMLParagraphElement.mm:
746         * DOM/DOMHTMLParamElement.mm:
747         * DOM/DOMHTMLQuoteElement.mm:
748         * DOM/DOMHTMLScriptElement.mm:
749         * DOM/DOMHTMLSelectElement.mm:
750         * DOM/DOMHTMLStyleElement.mm:
751         * DOM/DOMHTMLTableCaptionElement.mm:
752         * DOM/DOMHTMLTableCellElement.mm:
753         * DOM/DOMHTMLTableColElement.mm:
754         * DOM/DOMHTMLTableElement.mm:
755         * DOM/DOMHTMLTableRowElement.mm:
756         * DOM/DOMHTMLTableSectionElement.mm:
757         * DOM/DOMHTMLTitleElement.mm:
758         * DOM/DOMHTMLUListElement.mm:
759         * DOM/DOMHTMLVideoElement.mm:
760         * DOM/DOMKeyboardEvent.mm:
761         * DOM/DOMMediaList.mm:
762         * DOM/DOMMouseEvent.mm:
763         * DOM/DOMMutationEvent.mm:
764         * DOM/DOMNamedNodeMap.mm:
765         * DOM/DOMProcessingInstruction.mm:
766         * DOM/DOMRange.mm:
767         * DOM/DOMStyleSheet.mm:
768         * DOM/DOMText.mm:
769         * DOM/DOMTextEvent.mm:
770         * DOM/DOMTokenList.mm:
771         * DOM/DOMUIEvent.mm:
772         * DOM/DOMXPathResult.mm:
773         * History/WebHistoryItem.mm:
774         * Misc/WebNSURLExtras.mm:
775         (-[NSURL _web_userVisibleString]):
776         (-[NSURL _web_URLByRemovingUserInfo]):
777         (-[NSURL _web_dataForURLComponentType:]):
778         (-[NSURL _web_schemeData]):
779         (-[NSURL _web_hostData]):
780         * Misc/WebUserContentURLPattern.mm:
781         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
782         * Plugins/WebNetscapePluginStream.h:
783         (WebNetscapePluginStream::setRequestURL):
784         * WebCoreSupport/WebChromeClient.h:
785         * WebCoreSupport/WebChromeClient.mm:
786         (WebChromeClient::signedPublicKeyAndChallengeString const):
787         * WebCoreSupport/WebContextMenuClient.h:
788         * WebCoreSupport/WebContextMenuClient.mm:
789         * WebCoreSupport/WebDragClient.h:
790         * WebCoreSupport/WebFrameLoaderClient.h:
791         * WebCoreSupport/WebFrameLoaderClient.mm:
792         (WebFrameLoaderClient::updateGlobalHistory):
793         * WebCoreSupport/WebPaymentCoordinatorClient.h:
794         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
795         (WebPaymentCoordinatorClient::showPaymentUI):
796         * WebCoreSupport/WebPlatformStrategies.h:
797         * WebCoreSupport/WebPlatformStrategies.mm:
798         (WebPlatformStrategies::readURLFromPasteboard):
799         * WebCoreSupport/WebPluginInfoProvider.h:
800         * WebCoreSupport/WebPluginInfoProvider.mm:
801         (WebPluginInfoProvider::webVisiblePluginInfo):
802         * WebCoreSupport/WebSecurityOrigin.mm:
803         * WebCoreSupport/WebVisitedLinkStore.h:
804         * WebView/WebDataSource.mm:
805         * WebView/WebFrame.mm:
806         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
807         * WebView/WebImmediateActionController.mm:
808         (-[WebImmediateActionController _defaultAnimationController]):
809         * WebView/WebPDFView.mm:
810         * WebView/WebScriptDebugger.mm:
811         * WebView/WebViewInternal.h:
812
813 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
814
815         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
816         https://bugs.webkit.org/show_bug.cgi?id=192197
817
818         Reviewed by Jiewen Tan.
819
820         * Configurations/FeatureDefines.xcconfig:
821         * WebCoreSupport/WebChromeClient.h:
822         * WebCoreSupport/WebChromeClient.mm:
823
824 2018-11-28  Alex Christensen  <achristensen@webkit.org>
825
826         Remove dead code from an earlier attempt at implementing safe browsing
827         https://bugs.webkit.org/show_bug.cgi?id=192067
828
829         Reviewed by Chris Dumez.
830
831         * WebCoreSupport/WebFrameLoaderClient.h:
832         * WebCoreSupport/WebFrameLoaderClient.mm:
833         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
834
835 2018-11-27  Mark Lam  <mark.lam@apple.com>
836
837         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
838         https://bugs.webkit.org/show_bug.cgi?id=192055
839         <rdar://problem/46288783>
840
841         Reviewed by Saam Barati.
842
843         * Configurations/FeatureDefines.xcconfig:
844
845 2018-11-25  Tim Horton  <timothy_horton@apple.com>
846
847         Make it possible to insert editable images with a gesture
848         https://bugs.webkit.org/show_bug.cgi?id=191937
849
850         Reviewed by Wenson Hsieh.
851
852         * WebCoreSupport/WebEditorClient.mm:
853         (undoNameForEditAction):
854         Add a undo name.
855
856 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
857
858         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
859         https://bugs.webkit.org/show_bug.cgi?id=191945
860
861         Reviewed by Anders Carlsson.
862
863         * WebCoreSupport/WebEditorClient.mm:
864         (undoNameForEditAction):
865
866 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
867
868         Enable drag and drop support for iOSMac
869         https://bugs.webkit.org/show_bug.cgi?id=191818
870         <rdar://problem/43907454>
871
872         Reviewed by Dean Jackson.
873
874         * Configurations/FeatureDefines.xcconfig:
875
876 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
877
878         Address post-review feedback after r238438
879         https://bugs.webkit.org/show_bug.cgi?id=191913
880
881         Reviewed by Ryosuke Niwa.
882
883         * WebView/WebFrame.mm:
884         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
885         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
886         * WebView/WebView.mm:
887         (-[WebView setSelectedDOMRange:affinity:]):
888
889 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
890
891         Web Inspector: "Reload Web Inspector" button no longer partially works
892         https://bugs.webkit.org/show_bug.cgi?id=191773
893         <rdar://problem/46139932>
894
895         Reviewed by Devin Rousso.
896
897         * WebCoreSupport/WebInspectorClient.h:
898         * WebCoreSupport/WebInspectorClient.mm:
899         (WebInspectorFrontendClient::reopen):
900
901 2018-11-17  Devin Rousso  <drousso@apple.com>
902
903         Web Inspector: Network: add button to show system certificate dialog
904         https://bugs.webkit.org/show_bug.cgi?id=191458
905         <rdar://problem/45977019>
906
907         Reviewed by Joseph Pecoraro.
908
909         * WebCoreSupport/WebInspectorClient.h:
910         * WebCoreSupport/WebInspectorClient.mm:
911         (WebInspectorFrontendClient::showCertificate): Added.
912
913         * Configurations/WebKitLegacy.xcconfig:
914
915 2018-11-15  Truitt Savell  <tsavell@apple.com>
916
917         Unreviewed, rolling out r238244.
918
919         Caused High Sierra test runs to fail early with 50 crashes and
920         casued 25 API failures.
921
922         Reverted changeset:
923
924         "[css-logical] Implement flow-relative margin, padding and
925         border shorthands"
926         https://bugs.webkit.org/show_bug.cgi?id=188697
927         https://trac.webkit.org/changeset/238244
928
929 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
930
931         [css-logical] Implement flow-relative margin, padding and border shorthands
932         https://bugs.webkit.org/show_bug.cgi?id=188697
933
934         Reviewed by Simon Fraser and Antti Koivisto.
935
936         Add CSSLogicalEnabled runtime flag.
937
938         * WebView/WebPreferenceKeysPrivate.h:
939         * WebView/WebPreferences.mm:
940         (+[WebPreferences initialize]):
941         (-[WebPreferences cssLogicalEnabled]):
942         (-[WebPreferences setCSSLogicalEnabled:]):
943         * WebView/WebPreferencesPrivate.h:
944         * WebView/WebView.mm:
945         (-[WebView _preferencesChanged:]):
946
947 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
948
949         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
950         https://bugs.webkit.org/show_bug.cgi?id=191612
951
952         Reviewed by Matt Baker.
953
954         * WebCoreSupport/WebInspectorClient.mm:
955         (-[WebInspectorWindowController destroyInspectorView]):
956
957 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
958
959         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
960         https://bugs.webkit.org/show_bug.cgi?id=191494
961         <rdar://problem/45469854>
962
963         Reviewed by Devin Rousso.
964
965         * WebCoreSupport/WebInspectorClient.h:
966         WebKitLegacy will still have remote inspection of the Page directly.
967
968 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
969
970         Make compositing updates incremental
971         https://bugs.webkit.org/show_bug.cgi?id=90342
972
973         Reviewed by Antti Koivisto.
974
975         Fix spelling error.
976
977         * WebView/WebView.mm:
978         (-[WebView _setMediaLayer:forPluginView:]):
979
980 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
981
982         Implement a new edit command to change the enclosing list type
983         https://bugs.webkit.org/show_bug.cgi?id=191487
984         <rdar://problem/45955922>
985
986         Reviewed by Ryosuke Niwa.
987
988         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
989
990         * WebCoreSupport/WebEditorClient.mm:
991         (undoNameForEditAction):
992
993 2018-11-11  Daniel Bates  <dabates@apple.com>
994
995         [iOS] Draw caps lock indicator in password fields
996         https://bugs.webkit.org/show_bug.cgi?id=190565
997         <rdar://problem/45262343>
998
999         Reviewed by Dean Jackson.
1000
1001         Update the caps lock state when a hardware keyboard is attached or detached.
1002
1003         * WebView/WebHTMLView.mm:
1004         (hardwareKeyboardAvailabilityChangedCallback): Added.
1005         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1006         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1007
1008 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1009
1010         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1011         https://bugs.webkit.org/show_bug.cgi?id=191492
1012
1013         Reviewed by Alex Christensen.
1014
1015         * Carbon/HIWebView.mm:
1016         * Misc/WebNSFileManagerExtras.mm:
1017         * Misc/WebNSURLExtras.mm:
1018         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1019         * Plugins/WebBasePluginPackage.mm:
1020         * Plugins/WebPluginContainerCheck.mm:
1021         * WebCoreSupport/WebCachedFramePlatformData.h:
1022         * WebCoreSupport/WebDeviceOrientationClient.mm:
1023         * WebView/WebDelegateImplementationCaching.mm:
1024         * WebView/WebHTMLView.mm:
1025         * WebView/WebPDFRepresentation.mm:
1026         * WebView/WebPolicyDelegate.mm:
1027         * WebView/WebView.mm:
1028
1029 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1030
1031         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1032         https://bugs.webkit.org/show_bug.cgi?id=191492
1033
1034         Reviewed by Alex Christensen.
1035
1036         * Carbon/HIWebView.mm:
1037         (UpdateCommandStatus):
1038         * Misc/WebNSFileManagerExtras.mm:
1039         * Misc/WebNSURLExtras.mm:
1040         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1041         * Plugins/WebBasePluginPackage.mm:
1042         * Plugins/WebPluginContainerCheck.mm:
1043         (-[WebPluginContainerCheck _continueWithPolicy:]):
1044         * WebCoreSupport/WebCachedFramePlatformData.h:
1045         (WebCachedFramePlatformData::clear):
1046         * WebCoreSupport/WebDeviceOrientationClient.mm:
1047         (WebDeviceOrientationClient::getProvider const):
1048         * WebView/WebDelegateImplementationCaching.mm:
1049         (CallDelegate):
1050         (CallDelegateReturningBoolean):
1051         (CallResourceLoadDelegateReturningBoolean):
1052         (CallFormDelegate):
1053         (CallFormDelegateReturningBoolean):
1054         * WebView/WebHTMLView.mm:
1055         * WebView/WebPDFRepresentation.mm:
1056         * WebView/WebPolicyDelegate.mm:
1057         (-[WebPolicyDecisionListener _usePolicy:]):
1058         * WebView/WebView.mm:
1059
1060 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1061
1062         Unreviewed, rolling out r238047.
1063
1064         Introduced layout test failures on iOS simulator.
1065
1066         Reverted changeset:
1067
1068         "[iOS] Draw caps lock indicator in password fields"
1069         https://bugs.webkit.org/show_bug.cgi?id=190565
1070         https://trac.webkit.org/changeset/238047
1071
1072 2018-11-09  Antti Koivisto  <antti@apple.com>
1073
1074         Use OptionSet for layout milestones
1075         https://bugs.webkit.org/show_bug.cgi?id=191470
1076
1077         Reviewed by Dean Jackson.
1078
1079         * WebCoreSupport/WebFrameLoaderClient.h:
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1082         * WebView/WebView.mm:
1083         (coreLayoutMilestones):
1084         (kitLayoutMilestones):
1085         (-[WebView _cacheFrameLoadDelegateImplementations]):
1086         * WebView/WebViewInternal.h:
1087
1088 2018-11-09  Daniel Bates  <dabates@apple.com>
1089
1090         [iOS] Draw caps lock indicator in password fields
1091         https://bugs.webkit.org/show_bug.cgi?id=190565
1092         <rdar://problem/45262343>
1093
1094         Reviewed by Dean Jackson.
1095
1096         Update the caps lock state when a hardware keyboard is attached or detached.
1097
1098         * WebView/WebHTMLView.mm:
1099         (hardwareKeyboardAvailabilityChangedCallback): Added.
1100         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1101         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1102
1103 2018-11-09  Daniel Bates  <dabates@apple.com>
1104
1105         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1106         action when forward delete is pressed outside a text field
1107         https://bugs.webkit.org/show_bug.cgi?id=190566
1108         <rdar://problem/45262367>
1109
1110         Reviewed by Wenson Hsieh.
1111
1112         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1113         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1114         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1115
1116         * WebView/WebHTMLView.mm:
1117         (-[WebHTMLView _handleEditingKeyEvent:]):
1118
1119 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1120
1121         Adopt Reveal Framework to replace Lookup
1122         https://bugs.webkit.org/show_bug.cgi?id=191097
1123         <rdar://problem/45924508>
1124
1125         Reviewed by Tim Horton.
1126
1127         Pass in what it needed to clear the textIndicators. This is better than
1128         the current notification structure.
1129
1130         * WebView/WebView.mm:
1131         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1132         (-[WebView _prepareForDictionaryLookup]):
1133
1134 2018-11-06  Justin Fan  <justin_fan@apple.com>
1135
1136         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1137         https://bugs.webkit.org/show_bug.cgi?id=191291
1138
1139         Reviewed by Myles Maxfield.
1140
1141         Properly disable WEBGPU on all non-Metal platforms for now.
1142
1143         * Configurations/FeatureDefines.xcconfig:
1144
1145 2018-11-02  Daniel Bates  <dabates@apple.com>
1146
1147         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1148         https://bugs.webkit.org/show_bug.cgi?id=190487
1149
1150         Reviewed by Tim Horton.
1151
1152         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1153         allow the default handling.
1154
1155         * WebView/WebHTMLView.mm:
1156         (-[WebHTMLView _handleEditingKeyEvent:]):
1157
1158 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1159
1160         Add a storage limit for IndexedDB
1161         https://bugs.webkit.org/show_bug.cgi?id=190598
1162         <rdar://problem/44654715>
1163
1164         Reviewed by Chris Dumez.
1165
1166         * Storage/WebDatabaseManager.mm:
1167         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1168         * Storage/WebDatabaseManagerPrivate.h:
1169
1170 2018-10-31  Antti Koivisto  <antti@apple.com>
1171
1172         Remove LayerFlushScheduler
1173         https://bugs.webkit.org/show_bug.cgi?id=191103
1174
1175         Reviewed by Anders Carlsson.
1176
1177         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1178         all the virtual cruft.
1179
1180         * WebView/WebViewData.h:
1181         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1182         (): Deleted.
1183         * WebView/WebViewData.mm:
1184         (currentRunLoop):
1185         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1186         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1187         (WebViewLayerFlushScheduler::schedule):
1188         (WebViewLayerFlushScheduler::invalidate):
1189         (WebViewLayerFlushScheduler::layerFlushCallback):
1190
1191 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1192
1193         Enable InstallAPI for iOS unconditionally
1194         https://bugs.webkit.org/show_bug.cgi?id=191043
1195         rdar://problem/32728423
1196
1197         Reviewed by Dan Bernstein.
1198
1199         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1200         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1201         shouldn't be processed by InstallAPI.
1202         * MigrateHeaders.make: Removed an obsolete workaround.
1203         * Misc/NSURLDownloadSPI.h: Added.
1204         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1205
1206 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1207
1208         Clean up some obsolete MAX_ALLOWED macros
1209         https://bugs.webkit.org/show_bug.cgi?id=190916
1210
1211         Reviewed by Tim Horton.
1212
1213         * WebView/WebHTMLView.mm:
1214         (-[WebHTMLView pressureChangeWithEvent:]):
1215         * WebView/WebPDFView.h:
1216
1217 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1218
1219         Unreviewed, rolling out r237600 and r237604.
1220         https://bugs.webkit.org/show_bug.cgi?id=191086
1221
1222         Breaks internal iOS builds (Requested by ryanhadd_ on
1223         #webkit).
1224
1225         Reverted changesets:
1226
1227         "Enable InstallAPI for iOS unconditionally"
1228         https://bugs.webkit.org/show_bug.cgi?id=191043
1229         https://trac.webkit.org/changeset/237600
1230
1231         "Build fix attempt after enabling InstallAPI for iOS."
1232         https://bugs.webkit.org/show_bug.cgi?id=191043
1233         https://trac.webkit.org/changeset/237604
1234
1235 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1236
1237         Enable InstallAPI for iOS unconditionally
1238         https://bugs.webkit.org/show_bug.cgi?id=191043
1239         rdar://problem/32728423
1240
1241         Reviewed by Dan Bernstein.
1242
1243         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1244         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1245         shouldn't be processed by InstallAPI.
1246         * MigrateHeaders.make: Removed an obsolete workaround.
1247         * Misc/NSURLDownloadSPI.h: Added.
1248         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1249
1250 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1251
1252         Modernize WebKit nibs and lprojs for localization's sake
1253         https://bugs.webkit.org/show_bug.cgi?id=190911
1254         <rdar://problem/45349466>
1255
1256         Reviewed by Dan Bernstein.
1257
1258         * Misc/WebNSControlExtras.m:
1259         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1260         NSWindow and its contents are both in the same scale space these days; avoid
1261         double-applying the scale factor, or you can't see the prompt.
1262
1263         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1264         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1265         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1266         NIB->XIB
1267
1268 2018-10-25  Antoine Quint  <graouts@apple.com>
1269
1270         [Web Animations] Turn Web Animations CSS Integration off by default
1271         https://bugs.webkit.org/show_bug.cgi?id=190901
1272
1273         Reviewed by Dean Jackson.
1274
1275         * WebView/WebPreferences.mm:
1276         (+[WebPreferences initialize]):
1277
1278 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1279
1280         Clean up some obsolete macOS version guards
1281         https://bugs.webkit.org/show_bug.cgi?id=190887
1282
1283         Reviewed by Dan Bernstein.
1284
1285         * Misc/WebNSPasteboardExtras.mm:
1286         (+[NSPasteboard _web_dragTypesForURL]):
1287         * WebCoreSupport/PopupMenuMac.mm:
1288         (PopupMenuMac::show):
1289         * WebCoreSupport/WebEditorClient.h:
1290         * WebCoreSupport/WebEditorClient.mm:
1291         (WebEditorClient::respondToChangedSelection):
1292         * WebView/WebPDFView.mm:
1293         (-[WebPDFView _clipViewForPDFDocumentView]):
1294
1295 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1296
1297         Turn on Conic Gradients
1298         https://bugs.webkit.org/show_bug.cgi?id=190810
1299
1300         Reviewed by Tim Horton.
1301
1302         * Configurations/FeatureDefines.xcconfig:
1303
1304 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1305
1306         Cleanup: MIMETypeRegistry functions
1307         https://bugs.webkit.org/show_bug.cgi?id=190838
1308
1309         Reviewed by Simon Fraser.
1310
1311         * Misc/WebNSPasteboardExtras.mm:
1312         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1313         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1314         because they were identical.
1315
1316         * WebView/WebHTMLRepresentation.mm:
1317         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1318         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1319         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1320         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1321         * WebView/WebView.mm:
1322         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1323         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1324         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1325
1326 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1327
1328         Fix false positive leaks when using custom -init methods that don't start with -init
1329         <https://webkit.org/b/190818>
1330         <rdar://problem/45476042>
1331
1332         Reviewed by Dan Bernstein.
1333
1334         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1335         it is accessible by both categories.
1336         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1337         NSError (WebKitInternal) category.  Add attribute to make this
1338         behave like an -init method.
1339         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1340         NSError (WebKitInternal) category.  Modernize method.  Replace
1341         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1342
1343 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1344
1345         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1346         https://bugs.webkit.org/show_bug.cgi?id=190729
1347
1348         Reviewed by Tim Horton.
1349
1350         * DOM/DOM.mm:
1351         (-[DOMNode boundingBox]):
1352         * DOM/DOMElement.mm:
1353         * DOM/DOMHTML.mm:
1354         * DOM/DOMInternal.mm:
1355         * DOM/DOMUIKitExtensions.mm:
1356         * DOM/WebDOMOperations.mm:
1357         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1358         * DefaultDelegates/WebDefaultEditingDelegate.m:
1359         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1360         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1361         * DefaultDelegates/WebDefaultUIDelegate.h:
1362         * DefaultDelegates/WebDefaultUIDelegate.mm:
1363         (-[WebDefaultUIDelegate webViewClose:]):
1364         (-[WebDefaultUIDelegate webViewFocus:]):
1365         (-[WebDefaultUIDelegate webViewUnfocus:]):
1366         (-[WebDefaultUIDelegate webViewIsResizable:]):
1367         (-[WebDefaultUIDelegate webView:setResizable:]):
1368         (-[WebDefaultUIDelegate webView:setFrame:]):
1369         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1370         * History/BackForwardList.h:
1371         * History/BackForwardList.mm:
1372         * History/WebBackForwardList.mm:
1373         (+[WebBackForwardList initialize]):
1374         (bumperCarBackForwardHackNeeded):
1375         * History/WebHistory.mm:
1376         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1377         (-[WebHistory _sendNotification:entries:]):
1378         (-[WebHistory loadFromURL:error:]):
1379         (-[WebHistory saveToURL:error:]):
1380         * History/WebHistoryItem.mm:
1381         (WKNotifyHistoryItemChanged):
1382         (+[WebHistoryItem initialize]):
1383         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1384         * History/WebURLsWithTitles.m:
1385         * Misc/WebCache.mm:
1386         (+[WebCache initialize]):
1387         * Misc/WebDownload.mm:
1388         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1389         * Misc/WebElementDictionary.mm:
1390         (+[WebElementDictionary initialize]):
1391         (+[WebElementDictionary initializeLookupTable]):
1392         * Misc/WebIconDatabase.mm:
1393         * Misc/WebKitNSStringExtras.mm:
1394         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1395         * Misc/WebKitVersionChecks.h:
1396         * Misc/WebKitVersionChecks.mm:
1397         (WebKitLinkedOnOrAfter):
1398         (WebKitLinkTimeVersion):
1399         * Misc/WebLocalizableStrings.mm:
1400         * Misc/WebNSControlExtras.h:
1401         * Misc/WebNSControlExtras.m:
1402         * Misc/WebNSEventExtras.m:
1403         * Misc/WebNSFileManagerExtras.mm:
1404         * Misc/WebNSImageExtras.h:
1405         * Misc/WebNSImageExtras.m:
1406         * Misc/WebNSPasteboardExtras.mm:
1407         * Misc/WebNSPrintOperationExtras.h:
1408         * Misc/WebNSPrintOperationExtras.m:
1409         * Misc/WebNSViewExtras.m:
1410         * Misc/WebNSWindowExtras.m:
1411         * Panels/WebAuthenticationPanel.h:
1412         * Panels/WebAuthenticationPanel.m:
1413         * Panels/WebPanelAuthenticationHandler.m:
1414         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1415         (+[WebHostedNetscapePluginView initialize]):
1416         * Plugins/WebBasePluginPackage.h:
1417         * Plugins/WebBasePluginPackage.mm:
1418         * Plugins/WebJavaPlugIn.h:
1419         * Plugins/WebPluginContainerCheck.mm:
1420         * Plugins/WebPluginController.h:
1421         * Plugins/WebPluginController.mm:
1422         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1423         (-[WebPluginController addPlugin:]):
1424         (-[WebPluginController destroyPlugin:]):
1425         (-[WebPluginController destroyAllPlugins]):
1426         * Plugins/WebPluginDatabase.mm:
1427         (+[WebPluginDatabase _defaultPlugInPaths]):
1428         * Plugins/WebPluginPackage.mm:
1429         (-[WebPluginPackage initWithPath:]):
1430         * Storage/WebDatabaseManager.mm:
1431         (-[WebDatabaseManager deleteAllDatabases]):
1432         * Storage/WebDatabaseManagerClient.h:
1433         * Storage/WebDatabaseManagerClient.mm:
1434         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1435         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1436         * Storage/WebStorageManager.mm:
1437         (-[WebStorageManager deleteAllOrigins]):
1438         (WebKitInitializeStorageIfNecessary):
1439         * WebCoreSupport/WebAlternativeTextClient.h:
1440         * WebCoreSupport/WebApplicationCache.mm:
1441         (applicationCacheBundleIdentifier):
1442         * WebCoreSupport/WebChromeClient.h:
1443         * WebCoreSupport/WebChromeClient.mm:
1444         (WebChromeClient::setWindowRect):
1445         (WebChromeClient::windowRect):
1446         (WebChromeClient::takeFocus):
1447         (WebChromeClient::addMessageToConsole):
1448         (WebChromeClient::enableSuddenTermination):
1449         (WebChromeClient::disableSuddenTermination):
1450         (WebChromeClient::createPopupMenu const):
1451         (WebChromeClient::createSearchPopupMenu const):
1452         (WebChromeClient::shouldPaintEntireContents const):
1453         (WebChromeClient::supportsVideoFullscreen):
1454         (WebChromeClient::supportsFullScreenForElement):
1455         (WebChromeClient::enterFullScreenForElement):
1456         (WebChromeClient::exitFullScreenForElement):
1457         * WebCoreSupport/WebContextMenuClient.mm:
1458         * WebCoreSupport/WebDragClient.mm:
1459         * WebCoreSupport/WebEditorClient.h:
1460         * WebCoreSupport/WebEditorClient.mm:
1461         (+[WebUndoStep initialize]):
1462         (updateFontPanel):
1463         (WebEditorClient::didBeginEditing):
1464         (WebEditorClient::respondToChangedContents):
1465         (WebEditorClient::respondToChangedSelection):
1466         (WebEditorClient::canceledComposition):
1467         (WebEditorClient::didEndEditing):
1468         (WebEditorClient::didWriteSelectionToPasteboard):
1469         (attributesForAttributedStringConversion):
1470         (WebEditorClient::setInsertionPasteboard):
1471         (WebEditorClient::registerUndoOrRedoStep):
1472         (WebEditorClient::handleKeyboardEvent):
1473         (WebEditorClient::handleInputMethodKeydown):
1474         (WebEditorClient::textDidChangeInTextField):
1475         (WebEditorClient::requestCheckingOfString):
1476         * WebCoreSupport/WebFrameLoaderClient.h:
1477         * WebCoreSupport/WebFrameLoaderClient.mm:
1478         (WebFrameLoaderClient::detachedFromParent2):
1479         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1480         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1481         (WebFrameLoaderClient::dispatchWillSendRequest):
1482         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1483         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1484         (WebFrameLoaderClient::willCacheResponse const):
1485         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1486         (WebFrameLoaderClient::dispatchDidFinishLoading):
1487         (WebFrameLoaderClient::dispatchDidFailLoading):
1488         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1489         (WebFrameLoaderClient::dispatchWillClose):
1490         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1491         (WebFrameLoaderClient::dispatchDidCommitLoad):
1492         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1493         (WebFrameLoaderClient::dispatchDidFailLoad):
1494         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1495         (WebFrameLoaderClient::dispatchDidFinishLoad):
1496         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1497         (WebFrameLoaderClient::willChangeTitle):
1498         (WebFrameLoaderClient::didChangeTitle):
1499         (WebFrameLoaderClient::didReplaceMultipartContent):
1500         (WebFrameLoaderClient::updateGlobalHistory):
1501         (WebFrameLoaderClient::saveViewStateToItem):
1502         (WebFrameLoaderClient::restoreViewState):
1503         (WebFrameLoaderClient::provisionalLoadStarted):
1504         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1505         (WebFrameLoaderClient::setTitle):
1506         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1507         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1508         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1509         (WebFrameLoaderClient::didRestoreFromPageCache):
1510         (WebFrameLoaderClient::actionDictionary const):
1511         (WebFrameLoaderClient::createPlugin):
1512         (WebFrameLoaderClient::getLoadDecisionForIcons):
1513         (WebFrameLoaderClient::finishedLoadingIcon):
1514         (+[WebFramePolicyListener initialize]):
1515         * WebCoreSupport/WebFrameNetworkingContext.mm:
1516         * WebCoreSupport/WebGeolocationClient.h:
1517         * WebCoreSupport/WebGeolocationClient.mm:
1518         (WebGeolocationClient::requestPermission):
1519         * WebCoreSupport/WebInspectorClient.h:
1520         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1521         * WebCoreSupport/WebNotificationClient.mm:
1522         * WebCoreSupport/WebOpenPanelResultListener.mm:
1523         * WebCoreSupport/WebPlatformStrategies.h:
1524         * WebCoreSupport/WebPlatformStrategies.mm:
1525         * WebCoreSupport/WebProgressTrackerClient.h:
1526         * WebCoreSupport/WebProgressTrackerClient.mm:
1527         (WebProgressTrackerClient::progressStarted):
1528         (WebProgressTrackerClient::progressEstimateChanged):
1529         (WebProgressTrackerClient::progressFinished):
1530         * WebCoreSupport/WebSecurityOrigin.mm:
1531         * WebInspector/WebNodeHighlight.h:
1532         * WebInspector/WebNodeHighlight.mm:
1533         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1534         (-[WebNodeHighlight dealloc]):
1535         (-[WebNodeHighlight attach]):
1536         * WebInspector/WebNodeHighlightView.h:
1537         * WebInspector/WebNodeHighlightView.mm:
1538         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1539         (-[WebNodeHighlightView dealloc]):
1540         * WebInspector/WebNodeHighlighter.mm:
1541         (-[WebNodeHighlighter highlight]):
1542         * WebView/WebArchive.mm:
1543         (+[WebArchivePrivate initialize]):
1544         * WebView/WebClipView.h:
1545         * WebView/WebDataSource.mm:
1546         (WebDataSourcePrivate::WebDataSourcePrivate):
1547         (+[WebDataSource initialize]):
1548         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1549         (-[WebDataSource _makeRepresentation]):
1550         * WebView/WebDelegateImplementationCaching.h:
1551         * WebView/WebDelegateImplementationCaching.mm:
1552         (CallDelegate):
1553         (CallDelegateReturningFloat):
1554         (CallDelegateReturningBoolean):
1555         (CallUIDelegate):
1556         (CallUIDelegateReturningFloat):
1557         (CallUIDelegateReturningBoolean):
1558         (CallFrameLoadDelegate):
1559         (CallFrameLoadDelegateReturningBoolean):
1560         (CallResourceLoadDelegate):
1561         (CallScriptDebugDelegate):
1562         (CallFormDelegate):
1563         (CallFormDelegateReturningBoolean):
1564         * WebView/WebDeviceOrientation.mm:
1565         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1566         * WebView/WebDocumentInternal.h:
1567         * WebView/WebDocumentLoaderMac.mm:
1568         (needsDataLoadWorkaround):
1569         * WebView/WebDynamicScrollBarsViewInternal.h:
1570         * WebView/WebFormDelegate.m:
1571         * WebView/WebFrame.mm:
1572         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1573         (-[WebFrame _unmarkAllMisspellings]):
1574         (-[WebFrame _paintBehaviorForDestinationContext:]):
1575         (-[WebFrame _drawRect:contentsOnly:]):
1576         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1577         (-[WebFrame _scrollDOMRangeToVisible:]):
1578         (-[WebFrame _bodyBackgroundColor]):
1579         (-[WebFrame accessibilityRoot]):
1580         (needsMicrosoftMessengerDOMDocumentWorkaround):
1581         * WebView/WebFrameInternal.h:
1582         * WebView/WebFrameView.mm:
1583         (-[WebFrameView _setDocumentView:]):
1584         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1585         (-[WebFrameView _viewClassForMIMEType:]):
1586         (-[WebFrameView initWithFrame:]):
1587         (-[WebFrameView drawRect:]):
1588         (-[WebFrameView _firstResponderIsFormControl]):
1589         (-[WebFrameView keyDown:keyDown:]):
1590         (-[WebFrameView _isScrollable]):
1591         * WebView/WebFullScreenController.h:
1592         * WebView/WebFullScreenController.mm:
1593         * WebView/WebHTMLRepresentation.mm:
1594         * WebView/WebHTMLView.mm:
1595         (-[WebHTMLView hitTest:]):
1596         (-[WebHTMLView initWithFrame:]):
1597         (-[WebHTMLView dealloc]):
1598         (-[WebHTMLView addSubview:]):
1599         (-[WebHTMLView mouseDown:]):
1600         (-[WebHTMLView mouseUp:]):
1601         (-[WebHTMLView resignFirstResponder]):
1602         (-[WebHTMLView accessibilityHitTest:]):
1603         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1604         * WebView/WebHTMLViewInternal.h:
1605         * WebView/WebIndicateLayer.h:
1606         * WebView/WebIndicateLayer.mm:
1607         * WebView/WebMediaPlaybackTargetPicker.h:
1608         * WebView/WebMediaPlaybackTargetPicker.mm:
1609         * WebView/WebPDFDocumentExtras.h:
1610         * WebView/WebPDFDocumentExtras.mm:
1611         * WebView/WebPDFRepresentation.h:
1612         * WebView/WebPDFRepresentation.mm:
1613         * WebView/WebPDFView.h:
1614         * WebView/WebPreferences.mm:
1615         (cacheModelForMainBundle):
1616         (WebPreferencesPrivate::WebPreferencesPrivate):
1617         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1618         (-[WebPreferences encodeWithCoder:]):
1619         (+[WebPreferences standardPreferences]):
1620         (+[WebPreferences initialize]):
1621         (-[WebPreferences _valueForKey:]):
1622         (-[WebPreferences _setStringValue:forKey:]):
1623         (-[WebPreferences _setIntegerValue:forKey:]):
1624         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1625         (-[WebPreferences _setFloatValue:forKey:]):
1626         (-[WebPreferences _setBoolValue:forKey:]):
1627         (-[WebPreferences _setLongLongValue:forKey:]):
1628         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1629         (-[WebPreferences _postCacheModelChangedNotification]):
1630         (-[WebPreferences _postPreferencesChangedNotification]):
1631         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1632         (-[WebPreferences setStorageBlockingPolicy:]):
1633         * WebView/WebResource.mm:
1634         (+[WebResourcePrivate initialize]):
1635         * WebView/WebTextCompletionController.h:
1636         * WebView/WebTextIterator.mm:
1637         (+[WebTextIteratorPrivate initialize]):
1638         * WebView/WebView.mm:
1639         (shouldEnableLoadDeferring):
1640         (shouldRestrictWindowFocus):
1641         (shouldRespectPriorityInCSSAttributeSetters):
1642         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1643         (shouldAllowPictureInPictureMediaPlayback):
1644         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1645         (shouldAllowWindowOpenWithoutUserGesture):
1646         (shouldConvertInvalidURLsToBlank):
1647         (shouldRequireUserGestureToLoadVideo):
1648         (-[WebView _commonInitializationWithFrameName:groupName:]):
1649         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1650         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1651         (-[WebView _closePluginDatabases]):
1652         (-[WebView _closeWithFastTeardown]):
1653         (-[WebView _close]):
1654         (+[WebView _MIMETypeForFile:]):
1655         (-[WebView setShowingInspectorIndication:]):
1656         (-[WebView _setFormDelegate:]):
1657         (-[WebView _needsPreHTML5ParserQuirks]):
1658         (-[WebView _preferencesChangedNotification:]):
1659         (-[WebView _preferencesChanged:]):
1660         (-[WebView _cacheResourceLoadDelegateImplementations]):
1661         (-[WebView _cacheFrameLoadDelegateImplementations]):
1662         (-[WebView _policyDelegateForwarder]):
1663         (-[WebView _UIDelegateForwarder]):
1664         (-[WebView _editingDelegateForwarder]):
1665         (-[WebView _updateActiveState]):
1666         (-[_WebSafeForwarder forwardInvocation:]):
1667         (+[WebView initialize]):
1668         (-[WebView _pluginForMIMEType:]):
1669         (-[WebView _pluginForExtension:]):
1670         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1671         (+[WebView canShowMIMETypeAsHTML:]):
1672         (-[WebView _initWithArguments:]):
1673         (-[WebView initWithFrame:frameName:groupName:]):
1674         (-[WebView dealloc]):
1675         (-[WebView close]):
1676         (-[WebView viewDidMoveToWindow]):
1677         (-[WebView setUIDelegate:]):
1678         (-[WebView setResourceLoadDelegate:]):
1679         (-[WebView setPolicyDelegate:]):
1680         (-[WebView setFrameLoadDelegate:]):
1681         (-[WebView goBack]):
1682         (-[WebView goForward]):
1683         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1684         (-[WebView setHostWindow:]):
1685         (-[WebView becomeFirstResponder]):
1686         (+[WebView _cacheModelChangedNotification:]):
1687         (-[WebView _frameViewAtWindowPoint:]):
1688         (+[WebView _preflightSpellCheckerNow:]):
1689         (+[WebView _preflightSpellChecker]):
1690         (-[WebView canGoBack]):
1691         (-[WebView canGoForward]):
1692         (-[WebView stopLoading:]):
1693         (-[WebView reload:]):
1694         (-[WebView setMainFrameDocumentReady:]):
1695         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1696         (-[WebView setContinuousSpellCheckingEnabled:]):
1697         (-[WebView undoManager]):
1698         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1699         (-[WebView isAutomaticLinkDetectionEnabled]):
1700         (-[WebView isAutomaticDashSubstitutionEnabled]):
1701         (-[WebView isAutomaticTextReplacementEnabled]):
1702         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1703         (+[WebView _setCacheModel:]):
1704         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1705         (-[WebView _keyboardUIMode]):
1706         (LayerFlushController::flushLayers):
1707         (-[WebView _scheduleCompositingLayerFlush]):
1708         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1709         (-[WebView fullScreenPlaceholderView]):
1710         (WebInstallMemoryPressureHandler):
1711         * WebView/WebViewData.h:
1712         * WebView/WebViewData.mm:
1713         (+[WebViewPrivate initialize]):
1714         (-[WebViewPrivate init]):
1715         (-[WebViewPrivate dealloc]):
1716         * WebView/WebViewInternal.h:
1717
1718 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1719
1720         Clean up FrameLoader two-state enums
1721         https://bugs.webkit.org/show_bug.cgi?id=190731
1722
1723         Reviewed by Chris Dumez.
1724
1725         * WebCoreSupport/WebFrameLoaderClient.h:
1726         * WebCoreSupport/WebFrameLoaderClient.mm:
1727         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1728
1729 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1730
1731         Unreviewed, rolling out r237137.
1732
1733         SPI is actually used
1734
1735         Reverted changeset:
1736
1737         "Remove unused WebFrame._loadType"
1738         https://bugs.webkit.org/show_bug.cgi?id=190583
1739         https://trac.webkit.org/changeset/237137
1740
1741 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1742
1743         Enable the datalist element by default on iOS and macOS
1744         https://bugs.webkit.org/show_bug.cgi?id=190594
1745         <rdar://problem/45281159>
1746
1747         Reviewed by Ryosuke Niwa and Tim Horton.
1748
1749         * Configurations/FeatureDefines.xcconfig:
1750
1751 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1752
1753         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1754         https://bugs.webkit.org/show_bug.cgi?id=190675
1755
1756         Reviewed by Chris Dumez.
1757
1758         * History/BackForwardList.h:
1759         * History/BackForwardList.mm:
1760         (BackForwardList::backItem):
1761         (BackForwardList::currentItem):
1762         (BackForwardList::forwardItem):
1763         (BackForwardList::backListCount const):
1764         (BackForwardList::forwardListCount const):
1765         (BackForwardList::itemAtIndex):
1766         * History/WebBackForwardList.mm:
1767         (-[WebBackForwardList backItem]):
1768         (-[WebBackForwardList currentItem]):
1769         (-[WebBackForwardList forwardItem]):
1770         (-[WebBackForwardList itemAtIndex:]):
1771
1772 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1773
1774         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1775         https://bugs.webkit.org/show_bug.cgi?id=190526
1776         rdar://problem/45230140
1777
1778         Reviewed by Dean Jackson.
1779
1780         * WebCoreSupport/WebEditorClient.mm:
1781         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1782
1783 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1784
1785         Implement feature flag and bindings for CSS Painting API
1786         https://bugs.webkit.org/show_bug.cgi?id=190237
1787
1788         Reviewed by Ryosuke Niwa.
1789
1790         * Configurations/FeatureDefines.xcconfig:
1791
1792 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1793
1794         Replace HistoryItem* with HistoryItem& where possible
1795         https://bugs.webkit.org/show_bug.cgi?id=190617
1796
1797         Reviewed by Chris Dumez.
1798
1799         * History/BackForwardList.h:
1800         * History/BackForwardList.mm:
1801         (BackForwardList::goToItem):
1802         * History/WebBackForwardList.mm:
1803         (-[WebBackForwardList goToItem:]):
1804         * History/WebHistoryItem.mm:
1805         (WKNotifyHistoryItemChanged):
1806         * History/WebHistoryItemInternal.h:
1807
1808 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1809
1810         Remove unused WebHistoryItem._transientPropertyForKey
1811         https://bugs.webkit.org/show_bug.cgi?id=190606
1812
1813         Reviewed by Chris Dumez.
1814
1815         * History/WebHistoryItem.mm:
1816         * History/WebHistoryItemPrivate.h:
1817
1818 2018-10-15  Justin Fan  <justin_fan@apple.com>
1819
1820         Add WebGPU 2018 feature flag and experimental feature flag
1821         https://bugs.webkit.org/show_bug.cgi?id=190509
1822
1823         Reviewed by Dean Jackson.
1824
1825         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1826         for the 2018 WebGPU prototype.
1827
1828         * Configurations/FeatureDefines.xcconfig:
1829         * WebView/WebPreferenceKeysPrivate.h:
1830         * WebView/WebPreferences.mm:
1831         (+[WebPreferences initialize]):
1832         (-[WebPreferences webGPUEnabled]):
1833         (-[WebPreferences setWebGPUEnabled:]):
1834         * WebView/WebPreferencesPrivate.h:
1835         * WebView/WebView.mm:
1836         (-[WebView _preferencesChanged:]):
1837
1838 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1839
1840         Fix iOS build after r237157
1841
1842         * WebView/WebView.mm:
1843         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1844
1845 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1846
1847         Modernize BackForwardClient.h
1848         https://bugs.webkit.org/show_bug.cgi?id=190610
1849
1850         Reviewed by Chris Dumez.
1851
1852         * History/BackForwardList.h:
1853         * History/BackForwardList.mm:
1854         (BackForwardList::backListCount const):
1855         (BackForwardList::forwardListCount const):
1856         (BackForwardList::backListCount): Deleted.
1857         (BackForwardList::forwardListCount): Deleted.
1858         * History/WebBackForwardList.mm:
1859         (-[WebBackForwardList init]):
1860         * WebCoreSupport/WebFrameLoaderClient.mm:
1861         (WebFrameLoaderClient::canCachePage const):
1862         * WebView/WebFrameView.mm:
1863         (-[WebFrameView keyDown:keyDown:]):
1864         * WebView/WebView.mm:
1865         (-[WebView _commonInitializationWithFrameName:groupName:]):
1866         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1867         (-[WebView _loadBackForwardListFromOtherView:]):
1868         (-[WebView initWithCoder:]):
1869         (-[WebView encodeWithCoder:]):
1870         (-[WebView backForwardList]):
1871         (-[WebView setMaintainsBackForwardList:]):
1872
1873 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1874
1875         Add support for prefers-color-scheme media query
1876         https://bugs.webkit.org/show_bug.cgi?id=190499
1877         rdar://problem/45212025
1878
1879         Reviewed by Dean Jackson.
1880
1881         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1882
1883 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1884
1885         Remove unused WebView._globalHistoryItem
1886         https://bugs.webkit.org/show_bug.cgi?id=190601
1887
1888         Reviewed by Chris Dumez.
1889
1890         * WebCoreSupport/WebFrameLoaderClient.h:
1891         * WebCoreSupport/WebFrameLoaderClient.mm:
1892         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1893         * WebView/WebView.mm:
1894         (-[WebView _globalHistoryItem]): Deleted.
1895         (-[WebView _setGlobalHistoryItem:]): Deleted.
1896         * WebView/WebViewData.h:
1897         * WebView/WebViewInternal.h:
1898         * WebView/WebViewPrivate.h:
1899
1900 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1901
1902         Remove unused parameters from FrameLoaderClient::createFrame
1903         https://bugs.webkit.org/show_bug.cgi?id=190587
1904
1905         Reviewed by Chris Dumez.
1906
1907         * WebCoreSupport/WebFrameLoaderClient.h:
1908         * WebCoreSupport/WebFrameLoaderClient.mm:
1909         (WebFrameLoaderClient::createFrame):
1910
1911 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1912
1913         Remove unused WebFrame._loadType
1914         https://bugs.webkit.org/show_bug.cgi?id=190583
1915
1916         Reviewed by Chris Dumez.
1917
1918         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1919
1920         * WebView/WebFrame.mm:
1921         (toWebFrameLoadType): Deleted.
1922         (-[WebFrame _loadType]): Deleted.
1923         * WebView/WebFramePrivate.h:
1924
1925 2018-10-15  Chris Dumez  <cdumez@apple.com>
1926
1927         Restrict browsing context lookup by name to frames that are related to one another
1928         https://bugs.webkit.org/show_bug.cgi?id=190475
1929
1930         Reviewed by Alex Christensen.
1931
1932         * WebView/WebFrame.mm:
1933         (-[WebFrame findFrameNamed:]):
1934
1935 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1936
1937         Remove InjectedBundle processing of back/forward lists
1938         https://bugs.webkit.org/show_bug.cgi?id=190459
1939
1940         Reviewed by Chris Dumez.
1941
1942         * WebCoreSupport/WebFrameLoaderClient.h:
1943         * WebCoreSupport/WebFrameLoaderClient.mm:
1944         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1945
1946 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1947
1948         [JSC] Remove Option::useAsyncIterator
1949         https://bugs.webkit.org/show_bug.cgi?id=190567
1950
1951         Reviewed by Saam Barati.
1952
1953         * Configurations/FeatureDefines.xcconfig:
1954
1955 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1956
1957         Allow encoding of small enum classes
1958         https://bugs.webkit.org/show_bug.cgi?id=190531
1959
1960         Reviewed by Tim Horton.
1961
1962         * WebCoreSupport/WebFrameLoaderClient.mm:
1963         (-[WebFramePolicyListener dealloc]):
1964
1965 2018-10-11  Keith Rollin  <krollin@apple.com>
1966
1967         CURRENT_ARCH should not be used in Run Script phase.
1968         https://bugs.webkit.org/show_bug.cgi?id=190407
1969         <rdar://problem/45133556>
1970
1971         Reviewed by Alexey Proskuryakov.
1972
1973         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1974         CURRENT_ARCH is not well-defined during this phase (and may even have
1975         the value "undefined") since this phase is run just once per build
1976         rather than once per supported architecture. Migrate away from
1977         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1978         performing an operation for each value, or by picking the first entry
1979         in ARCHS and using that as a representative value.
1980
1981         * Configurations/WebKitLegacy.xcconfig: When generating
1982         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1983         macosx platforms.
1984
1985         * MigrateHeaders.make:
1986         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1987         generate one for each architecture in ARCHS.
1988
1989 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1990
1991         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1992         https://bugs.webkit.org/show_bug.cgi?id=190429
1993
1994         Reviewed by Saam Barati.
1995
1996         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1997
1998         * WebView/WebPDFRepresentation.mm:
1999         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2000
2001 2018-10-08  Justin Fan  <justin_fan@apple.com>
2002
2003         WebGPU: Rename old WebGPU prototype to WebMetal
2004         https://bugs.webkit.org/show_bug.cgi?id=190325
2005         <rdar://problem/44990443>
2006
2007         Reviewed by Dean Jackson.
2008
2009         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2010
2011         * Configurations/FeatureDefines.xcconfig:
2012         * WebView/WebPreferenceKeysPrivate.h:
2013         * WebView/WebPreferences.mm:
2014         (+[WebPreferences initialize]):
2015         (-[WebPreferences webMetalEnabled]):
2016         (-[WebPreferences setWebMetalEnabled:]):
2017         (-[WebPreferences webGPUEnabled]): Deleted.
2018         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2019         * WebView/WebPreferencesPrivate.h:
2020         * WebView/WebView.mm:
2021         (-[WebView _preferencesChanged:]):
2022
2023 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2024
2025         Make <input type=color> a runtime enabled (on-by-default) feature
2026         https://bugs.webkit.org/show_bug.cgi?id=189162
2027
2028         Reviewed by Wenson Hsieh and Tim Horton.
2029
2030         * Configurations/FeatureDefines.xcconfig:
2031
2032 2018-10-07  Dan Bernstein  <mitz@apple.com>
2033
2034         Fixed building with the latest macOS SDK
2035
2036         * Plugins/WebNetscapePluginPackage.mm:
2037         (-[WebNetscapePluginPackage openResourceFile]):
2038         (-[WebNetscapePluginPackage closeResourceFile:]):
2039
2040 2018-10-04  Dan Bernstein  <mitz@apple.com>
2041
2042         More Carbon build-fixing.
2043
2044         * Carbon/CarbonWindowAdapter.mm:
2045         (-[CarbonWindowAdapter _destroyRealWindow:]):
2046         (-[CarbonWindowAdapter _growBoxRect]):
2047
2048 2018-10-04  Dan Bernstein  <mitz@apple.com>
2049
2050         Retried to fix 32-bit macOS builds after r236846.
2051
2052         * WebView/WebHTMLView.mm:
2053         (-[WebHTMLView setMarkedText:selectedRange:]):
2054
2055 2018-10-04  Dan Bernstein  <mitz@apple.com>
2056
2057         Retried to fix 32-bit macOS builds after r236846.
2058
2059         * Carbon/HIWebView.mm:
2060         (ActiveStateChanged):
2061
2062 2018-10-04  Dan Bernstein  <mitz@apple.com>
2063
2064         Tried to fix 32-bit macOS builds after r236846.
2065
2066         * Carbon/HIWebView.mm:
2067         (_NSSelectorForHICommand):
2068
2069 2018-10-04  Dan Bernstein  <mitz@apple.com>
2070
2071         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2072         https://bugs.webkit.org/show_bug.cgi?id=190250
2073
2074         Reviewed by Andy Estes.
2075
2076         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2077           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2078           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2079           an earlier line set it to YES.
2080
2081         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2082         changes below.
2083
2084         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2085           provides some missing method declarations.
2086
2087         * Misc/WebDownload.mm:
2088         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2089           a deprecated method.
2090
2091         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2092
2093         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2094           other code in the file uses a method from it.
2095
2096         * Plugins/WebBaseNetscapePluginView.mm:
2097         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2098           a deprecated method.
2099
2100         * Plugins/WebPluginController.mm:
2101         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2102           around use of a selector that may be present in some WebKit client.
2103
2104         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2105           method declarations.
2106
2107         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2108           from here.
2109
2110         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2111           missing method declarations.
2112
2113         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2114           from here.
2115
2116         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2117           call from here.
2118         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2119           an obsolete delegate method for binary compatibility.
2120         (pluginView): Ditto.
2121
2122         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2123           call from here.
2124
2125         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2126           WebDeviceOrientationProviderMock protocol.
2127
2128         * WebView/WebDeviceOrientationProviderMock.mm:
2129         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2130           main @implementation.
2131
2132         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2133           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2134
2135         * WebView/WebDynamicScrollBarsView.mm:
2136         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2137           of a deprecated method.
2138
2139         * WebView/WebHTMLView.mm:
2140         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2141           selector warning around action methods that are not declared anywhere in WebKit.
2142
2143         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2144           about implementing this deprecated method.
2145         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2146         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2147         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2148         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2149         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2150         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2151         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2152         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2153         (-[WebHTMLView doCommandBySelector:]): Ditto.
2154         (-[WebHTMLView insertText:]): Ditto.
2155
2156         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2157
2158         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2159
2160         * WebView/WebPDFView.h: Removed previewView ivar.
2161
2162         * WebView/WebPDFView.mm:
2163           Removed declaration of FileInternal category and merged its implementation with the main
2164           implementation.
2165         (-[WebPDFView dealloc]): Removed previewView ivar.
2166         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2167           exist in macOS versions we support.
2168         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2169         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2170           action methods internal to PDFKit.
2171         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2172         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2173
2174         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2175           call on macOS, even though in r86988 we started calling different methods on iOS.
2176
2177         * WebView/WebView.mm:
2178         - Imported headers that declare delegate methods that we call.
2179         - Removed declaration of WebFileInternal category and merged its implementation with the
2180           main implementation.
2181         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2182           category, which made them impossible to call from the main implementation. Moved those
2183           into the main implementation. One of those had to be declared in a class extension,
2184           because it is called from a method implemented in the WebPrivate category, and that
2185           category’s implementation appears first in the file.
2186
2187         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2188           around use of obsolete delegate method for binary compatibility.
2189
2190         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2191
2192 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2193
2194         Runtime flag and IDL for MediaRecorder
2195         https://bugs.webkit.org/show_bug.cgi?id=190018
2196
2197         Reviewed by Youenn Fablet and Chris Dumez.
2198
2199         * WebView/WebPreferenceKeysPrivate.h:
2200         * WebView/WebPreferences.mm:
2201         (+[WebPreferences initialize]):
2202         (-[WebPreferences mediaRecorderEnabled]):
2203         (-[WebPreferences setMediaRecorderEnabled:]):
2204         * WebView/WebPreferencesPrivate.h:
2205         * WebView/WebView.mm:
2206         (-[WebView _preferencesChanged:]):
2207
2208 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2209
2210         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2211         https://bugs.webkit.org/show_bug.cgi?id=190238
2212
2213         Reviewed by Antti Koivisto.
2214
2215         Enabled the feature by default.
2216
2217         * WebView/WebPreferences.mm:
2218         (+[WebPreferences initialize]):
2219
2220 2018-10-01  Dean Jackson  <dino@apple.com>
2221
2222         [macOS] Switching to discrete GPU should be done in the UI process
2223         https://bugs.webkit.org/show_bug.cgi?id=189361
2224         <rdar://problem/43949622>
2225
2226         Reviewed by Simon Fraser.
2227
2228         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2229         not support swapping to the discrete GPU in this configuration.
2230
2231         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2232         (WebKit::WebSwitchingGPUClient::singleton):
2233         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2234         * WebView/WebView.mm:
2235         (-[WebView _commonInitializationWithFrameName:groupName:]):
2236
2237 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2238
2239         Remove ParsedURLString
2240         https://bugs.webkit.org/show_bug.cgi?id=190154
2241
2242         Reviewed by Chris Dumez.
2243
2244         * WebView/WebScriptDebugger.mm:
2245         (toNSURL):
2246
2247 2018-10-01  Dean Jackson  <dino@apple.com>
2248
2249         Remove CSS Animation Triggers
2250         https://bugs.webkit.org/show_bug.cgi?id=190175
2251         <rdar://problem/44925626>
2252
2253         Reviewed by Simon Fraser.
2254
2255         * Configurations/FeatureDefines.xcconfig:
2256
2257 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2258
2259         Unreviewed, rolling out r236624 and r236671.
2260         https://bugs.webkit.org/show_bug.cgi?id=190207
2261
2262         The change in r236624 introduced crashes on the bots
2263         (Requested by ryanhaddad on #webkit).
2264
2265         Reverted changesets:
2266
2267         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2268         https://bugs.webkit.org/show_bug.cgi?id=188747
2269         https://trac.webkit.org/changeset/236624
2270
2271         "Unify implementation in VideoFullscreenInterfaceAVKit"
2272         https://bugs.webkit.org/show_bug.cgi?id=190091
2273         https://trac.webkit.org/changeset/236671
2274
2275 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2276
2277         URL should not use TextEncoding internally
2278         https://bugs.webkit.org/show_bug.cgi?id=190111
2279
2280         Reviewed by Andy Estes.
2281
2282         * Misc/WebNSURLExtras.mm:
2283
2284 2018-09-28  Jer Noble  <jer.noble@apple.com>
2285
2286         Refactoring: eliminate raw pointer usage in Fullscreen code
2287         https://bugs.webkit.org/show_bug.cgi?id=188747
2288         <rdar://problem/43541164>
2289
2290         Reviewed by Alex Christensen.
2291
2292         PlaybackSessionInterface no longer has an invalidate() method.
2293
2294         * WebView/WebView.mm:
2295         (-[WebView _clearPlaybackControlsManager]):
2296
2297 2018-09-28  Chris Dumez  <cdumez@apple.com>
2298
2299         Drop support for cross-origin-window-policy header
2300         https://bugs.webkit.org/show_bug.cgi?id=190081
2301
2302         Reviewed by Ryosuke Niwa.
2303
2304         * WebView/WebPreferenceKeysPrivate.h:
2305         * WebView/WebPreferences.mm:
2306         (+[WebPreferences initialize]):
2307         * WebView/WebPreferencesPrivate.h:
2308         * WebView/WebView.mm:
2309         (-[WebView _preferencesChanged:]):
2310
2311 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2312
2313         Rename createMarkup to serializePreservingVisualAppearance
2314         https://bugs.webkit.org/show_bug.cgi?id=190086
2315
2316         Reviewed by Wenson Hsieh.
2317
2318         * DOM/WebDOMOperations.mm:
2319         (-[DOMRange markupString]):
2320
2321 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2322
2323         Unreviewed, rolling out r236605.
2324         https://bugs.webkit.org/show_bug.cgi?id=190087
2325
2326         caused three API test timeouts (Requested by jernoble on
2327         #webkit).
2328
2329         Reverted changeset:
2330
2331         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2332         https://bugs.webkit.org/show_bug.cgi?id=188747
2333         https://trac.webkit.org/changeset/236605
2334
2335 2018-09-28  Jer Noble  <jer.noble@apple.com>
2336
2337         Refactoring: eliminate raw pointer usage in Fullscreen code
2338         https://bugs.webkit.org/show_bug.cgi?id=188747
2339         <rdar://problem/43541164>
2340
2341         Reviewed by Alex Christensen.
2342
2343         PlaybackSessionInterface no longer has an invalidate() method.
2344
2345         * WebView/WebView.mm:
2346         (-[WebView _clearPlaybackControlsManager]):
2347
2348 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2349
2350         Use enum class in createMarkup arguments
2351         https://bugs.webkit.org/show_bug.cgi?id=190028
2352
2353         Reviewed by Wenson Hsieh.
2354
2355         * DOM/WebDOMOperations.mm:
2356         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2357         (-[DOMRange markupString]): Ditto.
2358
2359 2018-09-27  Antoine Quint  <graouts@apple.com>
2360
2361         [Web Animations] Turn Web Animations with CSS integration on
2362         https://bugs.webkit.org/show_bug.cgi?id=184819
2363         <rdar://problem/39597337>
2364
2365         Reviewed by Dean Jackson.
2366
2367         * WebView/WebPreferences.mm:
2368         (+[WebPreferences initialize]):
2369
2370 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2371
2372         Selection should work across shadow boundary when initiated by a mouse drag
2373         https://bugs.webkit.org/show_bug.cgi?id=151380
2374         <rdar://problem/24363872>
2375
2376         Reviewed by Wenson Hsieh.
2377
2378         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2379
2380         * WebView/WebPreferenceKeysPrivate.h:
2381         * WebView/WebPreferences.mm:
2382         (+[WebPreferences initialize]):
2383         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2384         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2385         * WebView/WebPreferencesPrivate.h:
2386         * WebView/WebView.mm:
2387         (-[WebView _preferencesChanged:]):
2388
2389 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2390
2391         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2392         https://bugs.webkit.org/show_bug.cgi?id=189918
2393         Work towards <rdar://problem/44648705>
2394
2395         Reviewed by Tim Horton.
2396
2397         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2398
2399         * WebView/WebHTMLView.mm:
2400         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2401         (-[WebHTMLView _updateFontPanel]):
2402         * WebView/WebView.mm:
2403         (-[WebView typingAttributes]):
2404
2405 2018-09-17  Darin Adler  <darin@apple.com>
2406
2407         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2408         https://bugs.webkit.org/show_bug.cgi?id=189652
2409
2410         Reviewed by Saam Barati.
2411
2412         * WebView/WebPDFRepresentation.mm:
2413         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2414
2415 2018-09-14  Jer Noble  <jer.noble@apple.com>
2416
2417         Turn SourceBufferChangeTypeEnabled on by default
2418         https://bugs.webkit.org/show_bug.cgi?id=189527
2419
2420         Reviewed by Eric Carlson.
2421
2422         * WebView/WebPreferences.mm:
2423         (+[WebPreferences initialize]):
2424
2425 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2426
2427         Fix an internal build after r235935
2428         https://bugs.webkit.org/show_bug.cgi?id=188996
2429
2430         * Carbon/HIWebView.mm:
2431         (Draw):
2432         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2433
2434 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2435
2436         Add IGNORE_WARNING_.* macros
2437         https://bugs.webkit.org/show_bug.cgi?id=188996
2438
2439         Reviewed by Michael Catanzaro.
2440
2441         * Carbon/CarbonUtils.m:
2442         (PoolCleaner):
2443         * Carbon/CarbonWindowAdapter.mm:
2444         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2445         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2446         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2447         (-[CarbonWindowAdapter _termWindowIfOwner]):
2448         (-[CarbonWindowAdapter _windowMovedToRect:]):
2449         (-[CarbonWindowAdapter setContentView:]):
2450         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2451         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2452         * Carbon/CarbonWindowFrame.m:
2453         (-[CarbonWindowFrame title]):
2454         * Carbon/HIViewAdapter.m:
2455         (+[HIViewAdapter getHIViewForNSView:]):
2456         * Carbon/HIWebView.mm:
2457         (overrideCGContext):
2458         (restoreCGContext):
2459         (Draw):
2460         * DOM/DOM.mm:
2461         * History/WebHistory.mm:
2462         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2463         * History/WebHistoryItem.mm:
2464         (-[WebHistoryItem icon]):
2465         * Misc/WebKitNSStringExtras.mm:
2466         (-[NSString _web_drawAtPoint:font:textColor:]):
2467         * Misc/WebNSImageExtras.m:
2468         (-[NSImage _web_scaleToMaxSize:]):
2469         (-[NSImage _web_dissolveToFraction:]):
2470         * Misc/WebNSPasteboardExtras.mm:
2471         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2472         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2473         * Panels/WebAuthenticationPanel.m:
2474         (-[WebAuthenticationPanel loadNib]):
2475         * Plugins/Hosted/NetscapePluginHostManager.mm:
2476         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2477         (WebKit::NetscapePluginHostManager::didCreateWindow):
2478         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2479         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2480         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2481         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2482         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2483         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2484         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2485         (-[WebHostedNetscapePluginView drawRect:]):
2486         * Plugins/Hosted/WebTextInputWindowController.m:
2487         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2488         * Plugins/WebBaseNetscapePluginView.mm:
2489         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2490         * Plugins/WebNetscapePluginPackage.mm:
2491         (-[WebNetscapePluginPackage _tryLoad]):
2492         * Plugins/WebNetscapePluginView.mm:
2493         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2494         (-[WebNetscapePluginView sendDrawRectEvent:]):
2495         (-[WebNetscapePluginView drawRect:]):
2496         * Plugins/WebPluginController.mm:
2497         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2498         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2499         * WebCoreSupport/PopupMenuMac.mm:
2500         (PopupMenuMac::populate):
2501         * WebCoreSupport/WebAlternativeTextClient.h:
2502         * WebCoreSupport/WebDragClient.mm:
2503         (WebDragClient::startDrag):
2504         * WebCoreSupport/WebFrameLoaderClient.mm:
2505         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2506         (webGetNSImage):
2507         * WebInspector/WebNodeHighlight.mm:
2508         * WebInspector/WebNodeHighlightView.mm:
2509         (-[WebNodeHighlightView drawRect:]):
2510         * WebView/WebClipView.mm:
2511         (-[WebClipView initWithFrame:]):
2512         * WebView/WebFrame.mm:
2513         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2514         (-[WebFrame _drawRect:contentsOnly:]):
2515         (-[WebFrame accessibilityRoot]):
2516         * WebView/WebFullScreenController.mm:
2517         (-[WebFullScreenController enterFullScreen:]):
2518         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2519         (-[WebFullScreenController exitFullScreen]):
2520         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2521         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2522         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2523         * WebView/WebHTMLView.mm:
2524         (-[NSWindow _web_borderView]):
2525         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2526         (-[WebHTMLView _setAsideSubviews]):
2527         (-[WebHTMLView _autoscroll]):
2528         (-[WebHTMLView drawRect:]):
2529         (-[WebHTMLView mouseDown:]):
2530         (-[WebHTMLView mouseDragged:]):
2531         (-[WebHTMLView mouseUp:]):
2532         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2533         (-[WebHTMLView knowsPageRange:]):
2534         (-[WebHTMLView accessibilityHitTest:]):
2535         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2536         (-[WebHTMLView _colorAsString:]):
2537         (-[WebHTMLView copyFont:]):
2538         (-[WebHTMLView _executeSavedKeypressCommands]):
2539         (-[WebHTMLView attachRootLayer:]):
2540         (-[WebHTMLView textStorage]):
2541         (-[WebHTMLView _updateSelectionForInputManager]):
2542         * WebView/WebPDFView.mm:
2543         (_applicationInfoForMIMEType):
2544         (-[WebPDFView centerSelectionInVisibleArea:]):
2545         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2546         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2547         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2548         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2549         * WebView/WebTextCompletionController.mm:
2550         (-[WebTextCompletionController _buildUI]):
2551         (-[WebTextCompletionController _placePopupWindow:]):
2552         * WebView/WebVideoFullscreenController.mm:
2553         * WebView/WebVideoFullscreenHUDWindowController.mm:
2554         (createMediaUIBackgroundView):
2555         * WebView/WebView.mm:
2556         (-[WebTextListTouchBarViewController initWithWebView:]):
2557         (-[WebView _dispatchTileDidDraw:]):
2558         (-[WebView encodeWithCoder:]):
2559         (-[WebView mainFrameIcon]):
2560         (LayerFlushController::flushLayers):
2561         * WebView/WebWindowAnimation.mm:
2562         (setScaledFrameForWindow):
2563
2564 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2565
2566         Remove unused needsDestruction class variables from HashTraits
2567         https://bugs.webkit.org/show_bug.cgi?id=189490
2568
2569         Reviewed by Daniel Bates.
2570
2571         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2572
2573 2018-09-07  Frederic Wang  <fwang@igalia.com>
2574
2575         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2576         https://bugs.webkit.org/show_bug.cgi?id=182230
2577
2578         Reviewed by Simon Fraser.
2579
2580         * DOM/DOMDocument.mm:
2581         (-[DOMDocument scrollingElement]): Use the new name.
2582
2583 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2584
2585         Refactor WebCore::EditAction to be an 8-bit enum class
2586         https://bugs.webkit.org/show_bug.cgi?id=189383
2587
2588         Reviewed by Dan Bernstein.
2589
2590         * WebCoreSupport/WebEditorClient.mm:
2591         (undoNameForEditAction):
2592         * WebView/WebHTMLView.mm:
2593         (-[WebHTMLView pasteFont:]):
2594         (-[WebHTMLView changeFont:]):
2595         (-[WebHTMLView changeAttributes:]):
2596         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2597         (-[WebHTMLView changeColor:]):
2598         * WebView/WebView.mm:
2599         (-[WebView setTypingStyle:]):
2600
2601 2018-09-06  Frederic Wang  <fwang@igalia.com>
2602
2603         Group options of scrollRectToVisible into a struct
2604         https://bugs.webkit.org/show_bug.cgi?id=189352
2605
2606         Reviewed by Simon Fraser.
2607
2608         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2609         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2610         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2611
2612 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2613
2614         [macOS] Cannot change font size at selection until font panel is shown
2615         https://bugs.webkit.org/show_bug.cgi?id=189295
2616         <rdar://problem/35593389>
2617
2618         Reviewed by Ryosuke Niwa.
2619
2620         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2621         WebCore ChangeLog for more details.
2622
2623         * WebView/WebHTMLView.mm:
2624         (-[WebHTMLView changeFont:]):
2625         (-[WebHTMLView changeAttributes:]):
2626         (-[WebHTMLView _originalFontA]): Deleted.
2627         (-[WebHTMLView _originalFontB]): Deleted.
2628         (fontNameForDescription): Deleted.
2629         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2630         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2631         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2632
2633 2018-09-05  Jer Noble  <jer.noble@apple.com>
2634
2635         Add MediaCapabilities as an Experimental Feature
2636         https://bugs.webkit.org/show_bug.cgi?id=189209
2637
2638         Reviewed by Eric Carlson.
2639
2640         RuntimeEnabledFeature -> Setting.
2641
2642         * WebView/WebView.mm:
2643         (-[WebView _preferencesChanged:]):
2644
2645 2018-09-04  Frederic Wang  <fwang@igalia.com>
2646
2647         Add basic support for ScrollIntoViewOptions
2648         https://bugs.webkit.org/show_bug.cgi?id=189258
2649
2650         Reviewed by Simon Fraser.
2651
2652         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2653         header so that this file can build despite the new scrollIntoView function.
2654
2655 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2656
2657         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2658         https://bugs.webkit.org/show_bug.cgi?id=188890
2659         <rdar://problem/43648605>
2660
2661         Reviewed by Tim Horton.
2662
2663         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2664         more detail.
2665
2666         * WebCoreSupport/WebPlatformStrategies.h:
2667         * WebCoreSupport/WebPlatformStrategies.mm:
2668         (WebPlatformStrategies::allStringsForType):
2669
2670 2018-09-01  Darin Adler  <darin@apple.com>
2671
2672         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2673         https://bugs.webkit.org/show_bug.cgi?id=189072
2674         Reviewed by Dan Bernstein.
2675
2676         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2677         and declarations for NSURLDownload init methods.
2678
2679         * Misc/WebDownloadInternal.h: Removed.
2680
2681         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2682         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2683         "-Wdeprecated-declarations" because the method used here is deprecated.
2684
2685         * WebView/WebView.mm:
2686         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2687         used here is deprecated.
2688
2689 2018-08-31  Chris Dumez  <cdumez@apple.com>
2690
2691         Assertion hit in ~CompletionHandler() from ~WebFrame()
2692         https://bugs.webkit.org/show_bug.cgi?id=189199
2693         <rdar://problem/42657233>
2694
2695         Reviewed by Youenn Fablet.
2696
2697         * WebCoreSupport/WebFrameLoaderClient.h:
2698         * WebCoreSupport/WebFrameLoaderClient.mm:
2699         (WebFrameLoaderClient::dispatchWillSubmitForm):
2700
2701 2018-08-31  Antti Koivisto  <antti@apple.com>
2702
2703         Replace OptionSet |= and -= operators with add() and remove() functions
2704         https://bugs.webkit.org/show_bug.cgi?id=189169
2705
2706         Reviewed by Anders Carlsson.
2707
2708         * WebView/WebFrame.mm:
2709         (-[WebFrame _drawRect:contentsOnly:]):
2710         * WebView/WebView.mm:
2711         (coreOptions):
2712
2713 2018-08-31  Frederic Wang  <fwang@igalia.com>
2714
2715         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2716         https://bugs.webkit.org/show_bug.cgi?id=182053
2717
2718         Reviewed by Simon Fraser.
2719
2720         Add developer flag to use standard behavior for scrolling* attributes.
2721
2722         * WebView/WebPreferenceKeysPrivate.h:
2723         * WebView/WebPreferences.mm:
2724         (+[WebPreferences initialize]):
2725         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2726         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2727         * WebView/WebPreferencesPrivate.h:
2728         * WebView/WebView.mm:
2729         (-[WebView _preferencesChanged:]):
2730
2731 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2732
2733         Implement the Web Share API
2734         https://bugs.webkit.org/show_bug.cgi?id=171100
2735         <rdar://problem/31751734>
2736
2737         Reviewed by Tim Horton.
2738
2739         * WebCoreSupport/WebChromeClient.h:
2740         * WebCoreSupport/WebChromeClient.mm:
2741         (WebChromeClient::showShareSheet):
2742         Empty declaration of showShareSheet.
2743
2744 2018-08-29  Youenn Fablet  <youenn@apple.com>
2745
2746         Remove WebRTC legacy API implementation
2747         https://bugs.webkit.org/show_bug.cgi?id=189040
2748
2749         Reviewed by Eric Carlson.
2750
2751         * WebView/WebPreferenceKeysPrivate.h:
2752         * WebView/WebPreferences.mm:
2753         (+[WebPreferences initialize]):
2754         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2755         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2756         * WebView/WebPreferencesPrivate.h:
2757         * WebView/WebView.mm:
2758         (-[WebView _preferencesChanged:]):
2759
2760 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2761
2762         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2763         https://bugs.webkit.org/show_bug.cgi?id=189054
2764
2765         Reviewed by Andy Estes.
2766
2767         Remove the pasteboard type argument from readURLFromPasteboard.
2768
2769         * WebCoreSupport/WebPlatformStrategies.h:
2770         * WebCoreSupport/WebPlatformStrategies.mm:
2771         (WebPlatformStrategies::readURLFromPasteboard):
2772
2773 2018-08-27  Keith Rollin  <krollin@apple.com>
2774
2775         Unreviewed build fix -- disable LTO for production builds
2776
2777         * Configurations/Base.xcconfig:
2778
2779 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2780
2781         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2782         https://bugs.webkit.org/show_bug.cgi?id=188931
2783
2784         Reviewed by Wenson Hsieh.
2785
2786         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2787
2788 2018-08-27  Keith Rollin  <krollin@apple.com>
2789
2790         Build system support for LTO
2791         https://bugs.webkit.org/show_bug.cgi?id=187785
2792         <rdar://problem/42353132>
2793
2794         Reviewed by Dan Bernstein.
2795
2796         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2797         LTO.
2798
2799         * Configurations/Base.xcconfig:
2800         * Configurations/DebugRelease.xcconfig:
2801
2802 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2803
2804         Pass in IsComposed flag to Event constructors
2805         https://bugs.webkit.org/show_bug.cgi?id=188720
2806         <rdar://problem/43580387>
2807
2808         Reviewed by Simon Fraser.
2809
2810         * WebView/WebPDFView.mm:
2811         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2812         whether it's simulated or not.
2813
2814 2018-08-23  Mark Lam  <mark.lam@apple.com>
2815
2816         Move vmEntryGlobalObject() to VM from CallFrame.
2817         https://bugs.webkit.org/show_bug.cgi?id=188900
2818         <rdar://problem/43655753>
2819
2820         Reviewed by Michael Saboff.
2821
2822         * WebView/WebScriptDebugger.mm:
2823         (WebScriptDebugger::sourceParsed):
2824
2825 2018-08-23  Andy Estes  <aestes@apple.com>
2826
2827         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2828         https://bugs.webkit.org/show_bug.cgi?id=188829
2829
2830         Reviewed by Tim Horton.
2831
2832         * Configurations/FeatureDefines.xcconfig:
2833
2834 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2837         https://bugs.webkit.org/show_bug.cgi?id=188777
2838
2839         Reviewed by Simon Fraser.
2840
2841         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2842         being "true" before the code change.
2843
2844         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2845
2846         * WebView/WebPDFView.mm:
2847         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2848
2849 2018-08-21  Daniel Bates  <dabates@apple.com>
2850
2851         Replace TextCheckingTypeMask with OptionSet
2852         https://bugs.webkit.org/show_bug.cgi?id=188678
2853
2854         Reviewed by Antti Koivisto.
2855
2856         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2857         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2858         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2859         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2860
2861         * WebCoreSupport/WebEditorClient.h:
2862         * WebCoreSupport/WebEditorClient.mm:
2863         (WebEditorClient::checkTextOfParagraph):
2864         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2865         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2866         left as this is more readable and unncessary now that modern compilers like Clang have
2867         diagnostics to catch accidental assignments when equality was intended.
2868         (WebEditorClient::didCheckSucceed):
2869         * WebView/WebView.mm:
2870         (coreTextCheckingType):
2871         (textCheckingResultFromNSTextCheckingResult):
2872
2873 2018-08-21  Daniel Bates  <dabates@apple.com>
2874
2875         [iOS][WK1] Support toggling continuous spell checking from tests
2876         https://bugs.webkit.org/show_bug.cgi?id=188763
2877
2878         Reviewed by Simon Fraser.
2879
2880         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2881         spell checking from tests in iOS WebKit Legacy.
2882
2883         * WebCoreSupport/WebEditorClient.h:
2884         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2885         * WebCoreSupport/WebEditorClient.mm:
2886         * WebView/WebView.h:
2887         * WebView/WebView.mm:
2888         (-[WebView toggleContinuousSpellChecking:]):
2889         (-[WebView toggleSmartInsertDelete:]):
2890
2891 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2892
2893         Add some plumbing for safe browsing
2894         https://bugs.webkit.org/show_bug.cgi?id=188709
2895
2896         Reviewed by Tim Horton.
2897
2898         * WebCoreSupport/WebFrameLoaderClient.h:
2899         * WebCoreSupport/WebFrameLoaderClient.mm:
2900         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2901
2902 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2903
2904         Replace canBubble and cancelable booleans in Event by enum classes
2905         https://bugs.webkit.org/show_bug.cgi?id=188692
2906
2907         Reviewed by Alex Christensen.
2908
2909         * WebView/WebPDFView.mm:
2910         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2911         * WebView/WebView.mm:
2912         (-[WebView _dispatchUnloadEvent]):
2913
2914 2018-08-16  Jer Noble  <jer.noble@apple.com>
2915
2916         Add Experimental Feature support for SourceBuffer.changeType()
2917         https://bugs.webkit.org/show_bug.cgi?id=188626
2918         <rdar://problem/43356021>
2919
2920         Reviewed by Eric Carlson.
2921
2922         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2923
2924         * WebView/WebPreferenceKeysPrivate.h:
2925         * WebView/WebPreferences.mm:
2926         (+[WebPreferences initialize]):
2927         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2928         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2929         * WebView/WebPreferencesPrivate.h:
2930         * WebView/WebView.mm:
2931         (-[WebView _preferencesChanged:]):
2932
2933 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2934
2935         Support drag-and-drop for input[type=color]
2936         https://bugs.webkit.org/show_bug.cgi?id=188464
2937
2938         Reviewed by Wenson Hsieh.
2939
2940         * WebCoreSupport/WebPlatformStrategies.h:
2941         * WebCoreSupport/WebPlatformStrategies.mm:
2942         (WebPlatformStrategies::setColor):
2943
2944 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2945
2946         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2947         https://bugs.webkit.org/show_bug.cgi?id=188569
2948         <rdar://problem/34201095>
2949
2950         Reviewed by Megan Gardner.
2951
2952         * WebView/WebImmediateActionController.mm:
2953         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2954         Speculative fix; the crashes indicate font is null, but we just checked it,
2955         so it must be getting made null by convertFont:toSize:. Check again!
2956
2957 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2958
2959         Use a 1-byte enum class for TextDirection
2960         https://bugs.webkit.org/show_bug.cgi?id=188350
2961
2962         Reviewed by Simon Fraser.
2963
2964         * WebCoreSupport/PopupMenuMac.mm:
2965         (PopupMenuMac::populate):
2966         (PopupMenuMac::show):
2967         * WebCoreSupport/WebFrameLoaderClient.mm:
2968         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2969         * WebView/WebFrame.mm:
2970         (-[WebFrame _dispatchDidReceiveTitle:]):
2971
2972 2018-08-09  Ali Juma  <ajuma@chromium.org>
2973
2974         Import WPTs for IntersectionObserver
2975         https://bugs.webkit.org/show_bug.cgi?id=188416
2976
2977         Reviewed by Simon Fraser.
2978
2979         * WebView/WebPreferencesPrivate.h:
2980
2981 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2982
2983         Follow-up build fix for r234685
2984         https://bugs.webkit.org/show_bug.cgi?id=188245
2985
2986         Unreviewed build fix.
2987
2988         * WebCoreSupport/WebSecurityOriginPrivate.h:
2989
2990 2018-08-05  Darin Adler  <darin@apple.com>
2991
2992         [Cocoa] More tweaks and refactoring to prepare for ARC
2993         https://bugs.webkit.org/show_bug.cgi?id=188245
2994
2995         Reviewed by Dan Bernstein.
2996
2997         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2998
2999         * Carbon/CarbonWindowFrame.m:
3000         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3001
3002         * DOM/DOM.mm:
3003         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3004         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3005         garbage collection so this method isn't useful.
3006
3007         * DOM/DOMXPath.mm:
3008         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3009         Objective-C garbage collection so this method isn't useful.
3010
3011         * History/WebHistory.mm:
3012         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3013
3014         * Misc/WebElementDictionary.mm:
3015         (addLookupKey): Use a bridging cast.
3016         (cacheValueForKey): Ditto.
3017         (-[WebElementDictionary _fillCache]): Ditto.
3018         (-[WebElementDictionary objectForKey:]): Ditto.
3019
3020         * Misc/WebKitNSStringExtras.mm:
3021         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3022         (-[NSString _web_widthWithFont:]): Ditto.
3023         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3024
3025         * Misc/WebLocalizableStrings.mm:
3026         (WebLocalizedString): Use a bridging cast.
3027
3028         * Misc/WebNSDataExtras.mm:
3029         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3030         and use CFBridgingRelease instead of calling autorelease directly.
3031         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3032         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3033         on the amount of explicit release and autorelease.
3034
3035         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3036         * Misc/WebNSDictionaryExtras.m:
3037         (-[NSDictionary _webkit_intForKey:]): Deleted.
3038         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3039         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3040         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3041         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3042         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3043         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3044
3045         * Misc/WebStringTruncator.mm:
3046         (fontFromNSFont): Use a bridging cast.
3047
3048         * Plugins/Hosted/NetscapePluginHostManager.mm:
3049         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3050
3051         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3052         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3053         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3054         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3055         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3056         * Plugins/Hosted/ProxyInstance.mm:
3057         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3058         * Plugins/WebBasePluginPackage.mm:
3059         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3060         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3061         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3062         * Plugins/WebNetscapePluginPackage.mm:
3063         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3064
3065         * Plugins/WebNetscapePluginView.mm:
3066         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3067         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3068         (-[WebNetscapePluginView status:]): Use a bridging cast.
3069         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3070
3071         * Plugins/WebPluginController.mm:
3072         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3073
3074         * Plugins/WebPluginDatabase.mm:
3075         (checkCandidate): Use explicit __strong for out argument types.
3076
3077         * Plugins/npapi.mm:
3078         (pluginViewForInstance): Use a bridging cast.
3079
3080         * Storage/WebDatabaseManager.mm:
3081         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3082         explicit NSNumber and NSDictionary calls.
3083
3084         * WebCoreSupport/WebContextMenuClient.mm:
3085         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3086
3087         * WebCoreSupport/WebEditorClient.mm:
3088         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3089         (WebEditorClient::handleInputMethodKeydown): Ditto.
3090
3091         * WebCoreSupport/WebFrameNetworkingContext.mm:
3092         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3093
3094         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3095         as a struct rather than an Objective-C class, since that's how it's defined.
3096
3097         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3098
3099         * WebView/WebFullScreenController.mm:
3100         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3101         * WebView/WebHTMLView.mm:
3102         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3103         Ditto.
3104         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3105
3106         * WebView/WebImmediateActionController.mm:
3107         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3108         go down to the document and then back to the frame.
3109         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3110         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3111         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3112
3113         * WebView/WebJSPDFDoc.mm:
3114         (jsPDFDocInitialize): Removed some unneeded type casting.
3115         (jsPDFDocFinalize): Ditto.
3116         (jsPDFDocPrint): Use a bridging cast.
3117
3118         * WebView/WebPDFView.mm:
3119         (_applicationInfoForMIMEType): Use bridging casts.
3120
3121         * WebView/WebPreferences.mm:
3122         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3123         instead of methods from WebNSDictionaryExtras.
3124         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3125         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3126         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3127         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3128         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3129
3130         * WebView/WebView.mm:
3131         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3132         (-[WebView _addToAllWebViewsSet]): Ditto.
3133         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3134         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3135         so it can be called from WebViewData methods.
3136
3137         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3138         method, _windowVisibilityChanged:.
3139
3140         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3141         called from WebViewData methods.
3142
3143 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3144
3145         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3146         https://bugs.webkit.org/show_bug.cgi?id=188323
3147
3148         Reviewed by Simon Fraser.
3149
3150         * WebCoreSupport/WebContextMenuClient.mm:
3151         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3152         * WebView/WebFrame.mm:
3153         (-[WebFrame _paintBehaviorForDestinationContext:]):
3154         (-[WebFrame _drawRect:contentsOnly:]):
3155         * WebView/WebHTMLView.mm:
3156         (imageFromRect):
3157         (selectionImage):
3158
3159 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3160
3161         Add support for microtasks in workers
3162         https://bugs.webkit.org/show_bug.cgi?id=188246
3163
3164         Reviewed by Darin Adler.
3165
3166         Rename JSMainThreadExecState.h to JSExecState.h.
3167
3168         * DOM/DOMAttr.mm:
3169         * DOM/DOMBlob.mm:
3170         * DOM/DOMCDATASection.mm:
3171         * DOM/DOMCSSCharsetRule.mm:
3172         * DOM/DOMCSSFontFaceRule.mm:
3173         * DOM/DOMCSSImportRule.mm:
3174         * DOM/DOMCSSMediaRule.mm:
3175         * DOM/DOMCSSPageRule.mm:
3176         * DOM/DOMCSSPrimitiveValue.mm:
3177         * DOM/DOMCSSRule.mm:
3178         * DOM/DOMCSSRuleList.mm:
3179         * DOM/DOMCSSStyleDeclaration.mm:
3180         * DOM/DOMCSSStyleRule.mm:
3181         * DOM/DOMCSSStyleSheet.mm:
3182         * DOM/DOMCSSUnknownRule.mm:
3183         * DOM/DOMCSSValue.mm:
3184         * DOM/DOMCSSValueList.mm:
3185         * DOM/DOMCharacterData.mm:
3186         * DOM/DOMComment.mm:
3187         * DOM/DOMCounter.mm:
3188         * DOM/DOMDocument.mm:
3189         * DOM/DOMDocumentFragment.mm:
3190         * DOM/DOMDocumentType.mm:
3191         * DOM/DOMElement.mm:
3192         * DOM/DOMEvent.mm:
3193         * DOM/DOMFile.mm:
3194         * DOM/DOMFileList.mm:
3195         * DOM/DOMHTML.mm:
3196         * DOM/DOMHTMLAnchorElement.mm:
3197         * DOM/DOMHTMLAppletElement.mm:
3198         * DOM/DOMHTMLAreaElement.mm:
3199         * DOM/DOMHTMLBRElement.mm:
3200         * DOM/DOMHTMLBaseElement.mm:
3201         * DOM/DOMHTMLBaseFontElement.mm:
3202         * DOM/DOMHTMLBodyElement.mm:
3203         * DOM/DOMHTMLButtonElement.mm:
3204         * DOM/DOMHTMLCanvasElement.mm:
3205         * DOM/DOMHTMLCollection.mm:
3206         * DOM/DOMHTMLDListElement.mm:
3207         * DOM/DOMHTMLDirectoryElement.mm:
3208         * DOM/DOMHTMLDivElement.mm:
3209         * DOM/DOMHTMLDocument.mm:
3210         * DOM/DOMHTMLElement.mm:
3211         * DOM/DOMHTMLEmbedElement.mm:
3212         * DOM/DOMHTMLFieldSetElement.mm:
3213         * DOM/DOMHTMLFontElement.mm:
3214         * DOM/DOMHTMLFormElement.mm:
3215         * DOM/DOMHTMLFrameElement.mm:
3216         * DOM/DOMHTMLFrameSetElement.mm:
3217         * DOM/DOMHTMLHRElement.mm:
3218         * DOM/DOMHTMLHeadElement.mm:
3219         * DOM/DOMHTMLHeadingElement.mm:
3220         * DOM/DOMHTMLHtmlElement.mm:
3221         * DOM/DOMHTMLIFrameElement.mm:
3222         * DOM/DOMHTMLImageElement.mm:
3223         * DOM/DOMHTMLInputElement.mm:
3224         * DOM/DOMHTMLLIElement.mm:
3225         * DOM/DOMHTMLLabelElement.mm:
3226         * DOM/DOMHTMLLegendElement.mm:
3227         * DOM/DOMHTMLLinkElement.mm:
3228         * DOM/DOMHTMLMapElement.mm:
3229         * DOM/DOMHTMLMarqueeElement.mm:
3230         * DOM/DOMHTMLMediaElement.mm:
3231         * DOM/DOMHTMLMenuElement.mm:
3232         * DOM/DOMHTMLMetaElement.mm:
3233         * DOM/DOMHTMLModElement.mm:
3234         * DOM/DOMHTMLOListElement.mm:
3235         * DOM/DOMHTMLObjectElement.mm:
3236         * DOM/DOMHTMLOptGroupElement.mm:
3237         * DOM/DOMHTMLOptionElement.mm:
3238         * DOM/DOMHTMLOptionsCollection.mm:
3239         * DOM/DOMHTMLParagraphElement.mm:
3240         * DOM/DOMHTMLParamElement.mm:
3241         * DOM/DOMHTMLPreElement.mm:
3242         * DOM/DOMHTMLQuoteElement.mm:
3243         * DOM/DOMHTMLScriptElement.mm:
3244         * DOM/DOMHTMLSelectElement.mm:
3245         * DOM/DOMHTMLStyleElement.mm:
3246         * DOM/DOMHTMLTableCaptionElement.mm:
3247         * DOM/DOMHTMLTableCellElement.mm:
3248         * DOM/DOMHTMLTableColElement.mm:
3249         * DOM/DOMHTMLTableElement.mm:
3250         * DOM/DOMHTMLTableRowElement.mm:
3251         * DOM/DOMHTMLTableSectionElement.mm:
3252         * DOM/DOMHTMLTextAreaElement.mm:
3253         * DOM/DOMHTMLTitleElement.mm:
3254         * DOM/DOMHTMLUListElement.mm:
3255         * DOM/DOMHTMLVideoElement.mm:
3256         * DOM/DOMImplementation.mm:
3257         * DOM/DOMKeyboardEvent.mm:
3258         * DOM/DOMMediaError.mm:
3259         * DOM/DOMMediaList.mm:
3260         * DOM/DOMMouseEvent.mm:
3261         * DOM/DOMMutationEvent.mm:
3262         * DOM/DOMNamedNodeMap.mm:
3263         * DOM/DOMNode.mm:
3264         * DOM/DOMNodeIterator.mm:
3265         * DOM/DOMNodeList.mm:
3266         * DOM/DOMOverflowEvent.mm:
3267         * DOM/DOMProcessingInstruction.mm:
3268         * DOM/DOMProgressEvent.mm:
3269         * DOM/DOMRGBColor.mm:
3270         * DOM/DOMRange.mm:
3271         * DOM/DOMRect.mm:
3272         * DOM/DOMStyleSheet.mm:
3273         * DOM/DOMStyleSheetList.mm:
3274         * DOM/DOMText.mm:
3275         * DOM/DOMTextEvent.mm:
3276         * DOM/DOMTimeRanges.mm:
3277         * DOM/DOMTokenList.mm:
3278         * DOM/DOMTreeWalker.mm:
3279         * DOM/DOMUIEvent.mm:
3280         * DOM/DOMWheelEvent.mm:
3281         * DOM/DOMXPathExpression.mm:
3282         * DOM/DOMXPathResult.mm:
3283         * DOM/ObjCEventListener.mm:
3284
3285 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3286
3287         Fix spelling of "overridden"
3288         https://bugs.webkit.org/show_bug.cgi?id=188315
3289
3290         Reviewed by Darin Adler.
3291
3292         * Misc/WebKitVersionChecks.mm:
3293         (setWebKitLinkTimeVersion):
3294         (WebKitLinkTimeVersion):
3295         * Plugins/WebBaseNetscapePluginView.mm:
3296         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3297         * WebCoreSupport/PopupMenuMac.mm:
3298         (PopupMenuMac::populate):
3299
3300 2018-08-01  Nan Wang  <n_wang@apple.com>
3301
3302         AX: AOM: Add ARIA IDL Attribute Reflection
3303         https://bugs.webkit.org/show_bug.cgi?id=184676
3304         <rdar://problem/39476882>
3305
3306         Reviewed by Chris Fleizach.
3307
3308         * WebView/WebPreferenceKeysPrivate.h:
3309         * WebView/WebPreferences.mm:
3310         (+[WebPreferences initialize]):
3311         (-[WebPreferences ariaReflectionEnabled]):
3312         (-[WebPreferences setAriaReflectionEnabled:]):
3313         * WebView/WebPreferencesPrivate.h:
3314         * WebView/WebView.mm:
3315         (-[WebView _preferencesChanged:]):
3316
3317 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3318
3319         Shrink GraphicsLayerCA
3320         https://bugs.webkit.org/show_bug.cgi?id=188141
3321
3322         Reviewed by Zalan Bujtas.
3323
3324         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3325         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3326         * moving all the animation-related stuff into the lazily-allocated m_animations
3327         * making enums be 8-bit
3328         * re-ordering data members
3329
3330         * WebView/WebView.mm:
3331         (-[WebView _setMediaLayer:forPluginView:]):
3332
3333 2018-07-30  Rob Buis  <rbuis@igalia.com>
3334
3335         Merge PlatformCookieJar functions into NetworkStorageSession
3336         https://bugs.webkit.org/show_bug.cgi?id=188137
3337
3338         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3339
3340         Reviewed by Alex Christensen.
3341
3342         * WebCoreSupport/WebPlatformStrategies.mm:
3343         (WebPlatformStrategies::cookiesForDOM):
3344         (WebPlatformStrategies::setCookiesFromDOM):
3345         (WebPlatformStrategies::cookiesEnabled):
3346         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3347         (WebPlatformStrategies::getRawCookies):
3348         (WebPlatformStrategies::deleteCookie):
3349         * WebView/WebPreferences.mm:
3350         (+[WebPreferences _clearNetworkLoaderSession]):
3351
3352 2018-07-28  Darin Adler  <darin@apple.com>
3353
3354         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3355         https://bugs.webkit.org/show_bug.cgi?id=188140
3356
3357         Reviewed by Sam Weinig.
3358
3359         * WebView/WebImmediateActionController.mm:
3360         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3361         new DictionaryLookup function that returns a tuple instead of using an out argument.
3362
3363 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3364
3365         [INTL] Remove INTL sub-feature compile flags
3366         https://bugs.webkit.org/show_bug.cgi?id=188081
3367
3368         Reviewed by Michael Catanzaro.
3369
3370         * Configurations/FeatureDefines.xcconfig:
3371
3372 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3373
3374         Unreviewed, rolling out r234181 and r234189.
3375         https://bugs.webkit.org/show_bug.cgi?id=188075
3376
3377         These are not needed right now (Requested by thorton on
3378         #webkit).
3379
3380         Reverted changesets:
3381
3382         "Enable Web Content Filtering on watchOS"
3383         https://bugs.webkit.org/show_bug.cgi?id=187979
3384         https://trac.webkit.org/changeset/234181
3385
3386         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3387         https://bugs.webkit.org/show_bug.cgi?id=187985
3388         https://trac.webkit.org/changeset/234189
3389
3390 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3391
3392         Use the Page's appearance when converting pasteboard attributed strings.
3393         https://bugs.webkit.org/show_bug.cgi?id=188067
3394         rdar://problem/42632246
3395
3396         Reviewed by Wenson Hsieh.
3397
3398         * WebCoreSupport/WebEditorClient.mm:
3399         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3400
3401 2018-07-25  Chris Dumez  <cdumez@apple.com>
3402
3403         navigator.userAgent may return outdated value after webView.customUserAgent is set
3404         https://bugs.webkit.org/show_bug.cgi?id=188009
3405         <rdar://problem/42566456>
3406
3407         Reviewed by Alex Christensen.
3408
3409         Let the page know when the user agent changes.
3410
3411         * WebView/WebView.mm:
3412         (-[WebView _preferencesChanged:]):
3413         (-[WebView setApplicationNameForUserAgent:]):
3414         (-[WebView _invalidateUserAgentCache]):
3415         (-[WebView setCustomUserAgent:]):
3416         * WebView/WebViewInternal.h:
3417
3418 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3419
3420         Enable Web Content Filtering on watchOS
3421         https://bugs.webkit.org/show_bug.cgi?id=187979
3422         <rdar://problem/42559346>
3423
3424         Reviewed by Wenson Hsieh.
3425
3426         * Configurations/FeatureDefines.xcconfig:
3427
3428 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3429
3430         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3431         https://bugs.webkit.org/show_bug.cgi?id=187846
3432
3433         Reviewed by Simon Fraser.
3434
3435         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3436
3437         * WebView/WebHTMLView.mm:
3438         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3439         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3440
3441 2018-07-11  Dean Jackson  <dino@apple.com>
3442
3443         Allow removal of white backgrounds
3444         https://bugs.webkit.org/show_bug.cgi?id=187574
3445         <rdar://problem/41146792>
3446
3447         Reviewed by Simon Fraser.
3448
3449         Add a new WebPreference for punching out white backgrounds.
3450
3451         * WebView/WebPreferenceKeysPrivate.h:
3452         * WebView/WebPreferences.mm:
3453         (+[WebPreferences initialize]):
3454         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3455         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3456         * WebView/WebPreferencesPrivate.h:
3457         * WebView/WebView.mm:
3458         (-[WebView _preferencesChanged:]):
3459
3460 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3461
3462         Ensure WebKit stack is ad-hoc signed
3463         https://bugs.webkit.org/show_bug.cgi?id=187667
3464
3465         Reviewed by Alexey Proskuryakov.
3466
3467         * Configurations/Base.xcconfig:
3468
3469 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3470
3471         REGRESSION (231276): Attempting to copy an image fails
3472         https://bugs.webkit.org/show_bug.cgi?id=187212
3473         <rdar://problem/41540074>
3474
3475         Reviewed by Ryosuke Niwa.
3476
3477         Renamed methods to make it clear that one URL and one title are being passed in.
3478
3479         * WebCoreSupport/WebPlatformStrategies.h:
3480         * WebCoreSupport/WebPlatformStrategies.mm:
3481         (WebPlatformStrategies::setURL):
3482