b5608015156e4c70e726263da876f66498d82e04
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-26  Jer Noble  <jer.noble@apple.com>
2
3         WK_COCOA_TOUCH all the things.
4         https://bugs.webkit.org/show_bug.cgi?id=185006
5
6         Reviewed by Tim Horton.
7
8         * Configurations/WebKitLegacy.xcconfig:
9
10 2018-04-26  Daniel Bates  <dabates@apple.com>
11
12         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
13         https://bugs.webkit.org/show_bug.cgi?id=184161
14         <rdar://problem/39051645>
15
16         Reviewed by Dan Bernstein.
17
18         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
19         dropping a PDF embedded using an HTML image element into the same web view.
20
21         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
22         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
23         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
24         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
25         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
26         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
27         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
28         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
29         image document when navigated to directly. Since we can support dragging PDF document images we need to
30         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
31         We need to do both such queries before falling back to using the main resource of the Web Archive as
32         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
33         not an image document.
34
35         * Misc/WebNSPasteboardExtras.mm:
36         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
37
38 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
39
40         Disable content filtering in minimal simulator mode
41         https://bugs.webkit.org/show_bug.cgi?id=185027
42         <rdar://problem/39736091>
43
44         Reviewed by Jer Noble.
45
46         * Configurations/FeatureDefines.xcconfig:
47
48 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
49
50         [INTL] Implement Intl.PluralRules
51         https://bugs.webkit.org/show_bug.cgi?id=184312
52
53         Reviewed by JF Bastien.
54
55         Added Intl.PluralRules feature flag.
56
57         * Configurations/FeatureDefines.xcconfig:
58
59 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
60
61         Remove access to keychain from the WebContent process
62         https://bugs.webkit.org/show_bug.cgi?id=184428
63         <rdar://problem/13150903>
64
65         Reviewed by Brent Fulgham.
66
67         This patch does the followings:
68         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
69         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
70         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
71
72         * WebCoreSupport/WebChromeClient.h:
73         * WebCoreSupport/WebChromeClient.mm:
74         (WebChromeClient::signedPublicKeyAndChallengeString const):
75         * WebView/WebUIDelegatePrivate.h:
76
77 2018-04-24  Jer Noble  <jer.noble@apple.com>
78
79         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
80         https://bugs.webkit.org/show_bug.cgi?id=184786
81
82         Reviewed by Tim Horton.
83
84         * Configurations/WebKitLegacy.xcconfig:
85         * MigrateHeaders.make:
86
87 2018-04-23  Daniel Bates  <dabates@apple.com>
88
89         Implement Same-Site cookies
90         https://bugs.webkit.org/show_bug.cgi?id=159464
91         <rdar://problem/27196358>
92
93         Reviewed by Brent Fulgham.
94
95         Pass the Same-Site info through the strategy.
96
97         * WebCoreSupport/WebPlatformStrategies.h:
98         * WebCoreSupport/WebPlatformStrategies.mm:
99         (WebPlatformStrategies::cookiesForDOM):
100         (WebPlatformStrategies::setCookiesFromDOM):
101         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
102         (WebPlatformStrategies::getRawCookies):
103
104 2018-04-23  Zalan Bujtas  <zalan@apple.com>
105
106         [LayoutFormattingContext] Initial commit.
107         https://bugs.webkit.org/show_bug.cgi?id=184896
108
109         Reviewed by Antti Koivisto.
110
111         * Configurations/FeatureDefines.xcconfig:
112
113 2018-04-23  Daniel Bates  <dabates@apple.com>
114
115         Implement Same-Site cookies
116         https://bugs.webkit.org/show_bug.cgi?id=159464
117         <rdar://problem/27196358>
118
119         Reviewed by Brent Fulgham.
120
121         Pass the Same-Site info through the strategy.
122
123         * WebCoreSupport/WebPlatformStrategies.h:
124         * WebCoreSupport/WebPlatformStrategies.mm:
125         (WebPlatformStrategies::cookiesForDOM):
126         (WebPlatformStrategies::setCookiesFromDOM):
127         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
128         (WebPlatformStrategies::getRawCookies):
129
130 2018-04-20  Timothy Hatcher  <timothy@apple.com>
131
132         NULL dereference crash sometimes under [super initWithCoder:] in WebView
133
134         https://bugs.webkit.org/show_bug.cgi?id=184851
135         rdar://problem/39611236
136
137         Reviewed by Tim Horton.
138
139         * WebView/WebView.mm:
140         (-[WebView _commonInitializationWithFrameName:groupName:]):
141         (-[WebView effectiveAppearanceDidChange]):
142         Added a null check and call the code later in initialization.
143
144 2018-04-20  Tim Horton  <timothy_horton@apple.com>
145
146         Adjust geolocation feature flag
147         https://bugs.webkit.org/show_bug.cgi?id=184856
148
149         Reviewed by Wenson Hsieh.
150
151         * Configurations/FeatureDefines.xcconfig:
152
153 2018-04-18  Jer Noble  <jer.noble@apple.com>
154
155         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
156         https://bugs.webkit.org/show_bug.cgi?id=184762
157
158         Reviewed by Dan Bernstein.
159
160         * Configurations/WebKitLegacy.xcconfig:
161
162 2018-04-20  Youenn Fablet  <youenn@apple.com>
163
164         Make PluginData cache its web visible plugins
165         https://bugs.webkit.org/show_bug.cgi?id=184421
166
167         Reviewed by Chris Dumez.
168
169         * WebCoreSupport/WebPluginInfoProvider.h:
170         * WebCoreSupport/WebPluginInfoProvider.mm:
171         (WebPluginInfoProvider::pluginInfo):
172         (WebPluginInfoProvider::webVisiblePluginInfo):
173
174 2018-04-19  Chris Dumez  <cdumez@apple.com>
175
176         Rename JSDOMWindowProxy to JSWindowProxy
177         https://bugs.webkit.org/show_bug.cgi?id=184797
178
179         Reviewed by Sam Weinig.
180
181         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
182
183         * DOM/DOMUtility.mm:
184         (createDOMWrapper):
185         * WebView/WebFrame.mm:
186         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
187
188 2018-04-19  David Kilzer  <ddkilzer@apple.com>
189
190         Enable Objective-C weak references
191         <https://webkit.org/b/184789>
192         <rdar://problem/39571716>
193
194         Reviewed by Dan Bernstein.
195
196         * Configurations/Base.xcconfig:
197         (CLANG_ENABLE_OBJC_WEAK): Enable.
198
199 2018-04-18  Chris Dumez  <cdumez@apple.com>
200
201         Rename WindowProxyController to WindowProxy
202         https://bugs.webkit.org/show_bug.cgi?id=184756
203
204         Reviewed by Sam Weinig.
205
206         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
207         needed use WindowProxyController type, which was a bit confusing.
208
209         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
210         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
211         * WebView/WebFrame.mm:
212         (-[WebFrame _attachScriptDebugger]):
213
214 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
215
216         Unreviewed rollout of r230632. Regression in memory usage.
217
218         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
219
220         * WebView/WebPreferences.mm:
221         (+[WebPreferences initialize]):
222
223 2018-04-17  Chris Dumez  <cdumez@apple.com>
224
225         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
226         https://bugs.webkit.org/show_bug.cgi?id=184678
227         <rdar://problem/39422122>
228
229         Reviewed by Alex Christensen.
230
231         Add new parameter to dispatchDecidePolicyForNavigationAction.
232
233         * WebCoreSupport/WebFrameLoaderClient.h:
234         * WebCoreSupport/WebFrameLoaderClient.mm:
235         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
236
237 2018-04-13  Chris Dumez  <cdumez@apple.com>
238
239         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
240         https://bugs.webkit.org/show_bug.cgi?id=184591
241
242         Reviewed by Sam Weinig.
243
244         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
245         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
246         This is work towards fixing Bug 184515.
247
248         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
249         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
250         * WebView/WebFrame.mm:
251         (-[WebFrame _attachScriptDebugger]):
252
253 2018-04-12  Antoine Quint  <graouts@apple.com>
254
255         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
256         https://bugs.webkit.org/show_bug.cgi?id=184569
257         <rdar://problem/38671301>
258
259         Reviewed by Jon Lee.
260
261         * WebView/WebPreferences.mm:
262
263 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
264
265         [WTF] Remove StaticLock
266         https://bugs.webkit.org/show_bug.cgi?id=184332
267
268         Reviewed by Mark Lam.
269
270         * DOM/DOMInternal.mm:
271         (getDOMWrapper):
272         (addDOMWrapper):
273         (removeDOMWrapper):
274
275 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
276
277         Failures from mach port reference handling should be fatal
278         https://bugs.webkit.org/show_bug.cgi?id=184202
279         <rdar://problem/37771114>
280
281         Reviewed by Anders Carlsson.
282
283         * Plugins/Hosted/NetscapePluginHostManager.mm:
284         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
285
286 2018-04-03  Andy Estes  <aestes@apple.com>
287
288         [Mac] Prioritize file promises over filenames during drag and drop
289         https://bugs.webkit.org/show_bug.cgi?id=184237
290         <rdar://problem/38278076>
291
292         Reviewed by Wenson Hsieh.
293
294         * WebView/WebView.mm:
295         (-[WebView performDragOperation:]):
296
297 2018-04-03  Chris Dumez  <cdumez@apple.com>
298
299         Drop MainFrame class
300         https://bugs.webkit.org/show_bug.cgi?id=184191
301
302         Reviewed by Darin Adler.
303
304         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
305         relationship between the Page and the MainFrame.
306
307         This is ground work for introducing LocalFrame / RemoteFrame concepts.
308
309         * WebCoreSupport/WebDragClient.mm:
310         * WebCoreSupport/WebFrameLoaderClient.mm:
311         * WebCoreSupport/WebInspectorClient.mm:
312         * WebCoreSupport/WebPlatformStrategies.mm:
313         * WebCoreSupport/WebPluginInfoProvider.mm:
314         * WebView/WebFrame.mm:
315         * WebView/WebFrameView.mm:
316         * WebView/WebHTMLView.mm:
317         * WebView/WebView.mm:
318
319 2018-04-02  Jer Noble  <jer.noble@apple.com>
320
321         Enable Legacy EME for all WebKit & WebKitLegacy clients
322         https://bugs.webkit.org/show_bug.cgi?id=184018
323         <rdar://problem/34887387>
324
325         Reviewed by Eric Carlson.
326
327         * WebView/WebPreferences.mm:
328         (+[WebPreferences initialize]):
329
330 2018-03-29  JF Bastien  <jfbastien@apple.com>
331
332         Use Forward.h instead of forward-declaring WTF::String
333         https://bugs.webkit.org/show_bug.cgi?id=184172
334         <rdar://problem/39026146>
335
336         Reviewed by Yusuke Suzuki.
337
338         As part of #184164 I'm changing WTF::String, and the forward
339         declarations are just wrong because I'm making it templated. We
340         should use Forward.h anyways, so do that instead.
341
342         * WebView/WebScriptDebugger.h:
343
344 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
345
346         Protect against invalid mach ports returned by mach_port_request_notification
347         https://bugs.webkit.org/show_bug.cgi?id=184106
348         <rdar://problem/37865316>
349
350         Reviewed by Chris Dumez.
351
352         * Plugins/Hosted/NetscapePluginHostProxy.mm:
353         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
354         and clean up if it experienced an error.
355         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
356
357 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
358
359         Avoid uninitialized mach ports
360         https://bugs.webkit.org/show_bug.cgi?id=184090
361         <rdar://problem/37261129>
362
363         Reviewed by Chris Dumez.
364
365         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
366         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
367         there is a potential for us to try to use invalid ports.
368
369         We should always check return values, and ensure that the mach port variables we seek to initialize are
370         kept in a valid state.
371
372         Reviewed by Chris Dumez.
373
374         * Plugins/Hosted/NetscapePluginHostManager.h:
375         * Plugins/Hosted/NetscapePluginHostManager.mm:
376         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
377         port is passed to an API function.
378         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
379         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
380         * Plugins/Hosted/NetscapePluginHostProxy.h:
381         * Plugins/Hosted/NetscapePluginHostProxy.mm:
382         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
383         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
384         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
385         (WKPCStatusText): Ditto.
386         (WKPCLoadURL): Ditto.
387         (WKPCCancelLoadURL): Ditto.
388         (WKPCInvalidateRect): Ditto.
389         (WKPCGetScriptableNPObjectReply): Ditto.
390         (WKPCBooleanReply): Ditto.
391         (WKPCBooleanAndDataReply): Ditto.
392         (WKPCInstantiatePluginReply): Ditto.
393         (WKPCGetWindowNPObject): Ditto.
394         (WKPCGetPluginElementNPObject): Ditto.
395         (WKPCForgetBrowserObject): Ditto.
396         (WKPCEvaluate): Ditto.
397         (WKPCGetStringIdentifier): Ditto.
398         (WKPCGetIntIdentifier): Ditto.
399         (WKPCInvoke): Ditto.
400         (WKPCInvokeDefault): Ditto.
401         (WKPCConstruct): Ditto.
402         (WKPCGetProperty): Ditto.
403         (WKPCSetProperty): Ditto.
404         (WKPCRemoveProperty): Ditto.
405         (WKPCHasProperty): Ditto.
406         (WKPCHasMethod): Ditto.
407         (WKPCIdentifierInfo): Ditto.
408         (WKPCEnumerate): Ditto.
409         (WKPCSetMenuBarVisible): Ditto.
410         (WKPCSetFullscreenWindowIsShowing): Ditto.
411         (WKPCSetModal): Ditto.
412         (WKPCGetCookies): Ditto.
413         (WKPCGetProxy): Ditto.
414         (WKPCSetCookies): Ditto.
415         (WKPCGetAuthenticationInfo): Ditto.
416         (WKPCConvertPoint): Ditto.
417         (WKPCLayerHostingModeChanged): Ditto.
418         (WKPCSetException): Ditto.
419
420 2018-03-26  Tim Horton  <timothy_horton@apple.com>
421
422         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
423         https://bugs.webkit.org/show_bug.cgi?id=184030
424         <rdar://problem/38895281>
425
426         Reviewed by Dan Bernstein.
427
428         * Configurations/Base.xcconfig:
429
430 2018-03-26  Chris Dumez  <cdumez@apple.com>
431
432         Use SecurityOriginData more consistently in Service Worker code
433         https://bugs.webkit.org/show_bug.cgi?id=183969
434
435         Reviewed by Darin Adler.
436
437         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
438
439         * Storage/WebDatabaseManager.mm:
440         (-[WebDatabaseManager databasesWithOrigin:]):
441         (-[WebDatabaseManager deleteOrigin:]):
442         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
443         * Storage/WebDatabaseQuotaManager.mm:
444         (-[WebDatabaseQuotaManager usage]):
445         (-[WebDatabaseQuotaManager quota]):
446         (-[WebDatabaseQuotaManager setQuota:]):
447         * Storage/WebStorageManager.mm:
448         (-[WebStorageManager deleteOrigin:]):
449         * WebCoreSupport/WebSecurityOrigin.mm:
450         (-[WebSecurityOrigin databaseIdentifier]):
451         (-[WebSecurityOrigin usage]):
452         (-[WebSecurityOrigin quota]):
453         (-[WebSecurityOrigin setQuota:]):
454
455 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
456
457         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
458         https://bugs.webkit.org/show_bug.cgi?id=183911
459         <rdar://problem/38762306>
460
461         Reviewed by Youenn Fablet.
462
463         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
464
465         * WebView/WebView.mm:
466         (+[WebView initialize]):
467
468 2018-03-26  Alex Christensen  <achristensen@webkit.org>
469
470         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
471         https://bugs.webkit.org/show_bug.cgi?id=183965
472
473         Reviewed by Chris Dumez.
474
475         * WebCoreSupport/WebFrameLoaderClient.h:
476         * WebCoreSupport/WebFrameLoaderClient.mm:
477         (WebFrameLoaderClient::willCacheResponse const):
478
479 2018-03-25  Commit Queue  <commit-queue@webkit.org>
480
481         Unreviewed, rolling out r229954.
482         https://bugs.webkit.org/show_bug.cgi?id=184000
483
484         Caused many layout tests to crash on Apple High Sierra,
485         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
486         by dydz on #webkit).
487
488         Reverted changeset:
489
490         "Use SecurityOriginData more consistently in Service Worker
491         code"
492         https://bugs.webkit.org/show_bug.cgi?id=183969
493         https://trac.webkit.org/changeset/229954
494
495 2018-03-24  Chris Dumez  <cdumez@apple.com>
496
497         Use SecurityOriginData more consistently in Service Worker code
498         https://bugs.webkit.org/show_bug.cgi?id=183969
499
500         Reviewed by Darin Adler.
501
502         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
503
504         * Storage/WebDatabaseManager.mm:
505         (-[WebDatabaseManager databasesWithOrigin:]):
506         (-[WebDatabaseManager deleteOrigin:]):
507         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
508         * Storage/WebDatabaseQuotaManager.mm:
509         (-[WebDatabaseQuotaManager usage]):
510         (-[WebDatabaseQuotaManager quota]):
511         (-[WebDatabaseQuotaManager setQuota:]):
512         * Storage/WebStorageManager.mm:
513         (-[WebStorageManager deleteOrigin:]):
514         * WebCoreSupport/WebSecurityOrigin.mm:
515         (-[WebSecurityOrigin databaseIdentifier]):
516         (-[WebSecurityOrigin usage]):
517         (-[WebSecurityOrigin quota]):
518         (-[WebSecurityOrigin setQuota:]):
519
520 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
521
522         Fix the build
523
524         * WebView/WebView.mm:
525
526 2018-03-23  Tim Horton  <timothy_horton@apple.com>
527
528         Fix the build with no pasteboard
529         https://bugs.webkit.org/show_bug.cgi?id=183973
530
531         Reviewed by Dan Bernstein.
532
533         * Configurations/FeatureDefines.xcconfig:
534         * WebView/WebView.mm:
535         (-[WebView _requestStartDataInteraction:globalPosition:]):
536         (-[WebView _getDataInteractionData]):
537         (-[WebView _dataOperationTextIndicator]):
538         (-[WebView _dragSourceAction]):
539         (-[WebView _draggedLinkTitle]):
540         (-[WebView _draggedLinkURL]):
541         (-[WebView _draggedElementBounds]):
542         (-[WebView _enteredDataInteraction:client:global:operation:]):
543         (-[WebView _updatedDataInteraction:client:global:operation:]):
544         (-[WebView _exitedDataInteraction:client:global:operation:]):
545         (-[WebView _performDataInteraction:client:global:operation:]):
546         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
547         (-[WebView _endedDataInteraction:global:]):
548         (-[WebView _dataInteractionCaretRect]):
549         * WebView/WebViewPrivate.h:
550
551 2018-03-23  Tim Horton  <timothy_horton@apple.com>
552
553         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
554         https://bugs.webkit.org/show_bug.cgi?id=183960
555         <rdar://problem/38812356>
556
557         Reviewed by Dan Bernstein.
558
559         * Configurations/WebKitLegacy.xcconfig:
560
561 2018-03-23  Tim Horton  <timothy_horton@apple.com>
562
563         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
564         https://bugs.webkit.org/show_bug.cgi?id=183954
565         <rdar://problem/38808858>
566
567         Reviewed by Dan Bernstein.
568
569         * WebView/WebPreferences.mm:
570         (-[WebPreferences setAudioSessionCategoryOverride:]):
571
572 2018-03-23  Tim Horton  <timothy_horton@apple.com>
573
574         Adopt WK_PLATFORM_NAME in WebKitLegacy
575         https://bugs.webkit.org/show_bug.cgi?id=183948
576         <rdar://problem/38803908>
577
578         Reviewed by Dan Bernstein.
579
580         * Configurations/WebKitLegacy.xcconfig:
581         * MigrateHeaders.make:
582         * postprocess-headers.sh:
583
584 2018-03-23  Brady Eidson  <beidson@apple.com>
585
586         Go to back/forward list items after a process-swapped navigation.
587         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
588
589         Reviewed by Andy Estes.
590
591         * WebView/WebView.mm:
592         (-[WebView _loadBackForwardListFromOtherView:]):
593         (-[WebView goToBackForwardItem:]):
594
595 2018-03-22  Tim Horton  <timothy_horton@apple.com>
596
597         Improve readability of WebCore's OTHER_LDFLAGS
598         https://bugs.webkit.org/show_bug.cgi?id=183909
599         <rdar://problem/38760992>
600
601         Reviewed by Dan Bernstein.
602
603         * Configurations/Base.xcconfig:
604         * Configurations/FeatureDefines.xcconfig:
605
606 2018-03-20  Tim Horton  <timothy_horton@apple.com>
607
608         Enable the minimal simulator feature flag when appropriate
609         https://bugs.webkit.org/show_bug.cgi?id=183807
610
611         Reviewed by Dan Bernstein.
612
613         * Configurations/FeatureDefines.xcconfig:
614
615 2018-03-20  Tim Horton  <timothy_horton@apple.com>
616
617         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
618         https://bugs.webkit.org/show_bug.cgi?id=183758
619         <rdar://problem/38017644>
620
621         Reviewed by Dan Bernstein.
622
623         * Configurations/FeatureDefines.xcconfig:
624
625 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
626
627         Clear style colors when setting default appearance
628         https://bugs.webkit.org/show_bug.cgi?id=183759
629
630         Reviewed by Tim Horton.
631
632         Colors are cached and need to be cleared and recalculated.
633         Refactor to do all style recalcs together.
634
635         * WebView/WebView.mm:
636         (-[WebView _setDefaultAppearanceAndClearStyle]):
637         (-[WebView _setUseSystemAppearance:]):
638         (-[WebView effectiveAppearanceDidChange]):
639
640 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
641
642         Unreviewed, another quick fix for r229699
643
644         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
645
646         * Configurations/FeatureDefines.xcconfig:
647
648 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
649
650         Ensure that style is updated when the effective appearance changes
651         https://bugs.webkit.org/show_bug.cgi?id=183690
652         <rdar://problem/38385900>
653
654         Reviewed by Tim Horton and Wenson Hsieh.
655
656         Respond to and respect the effective appearance changing.
657
658         * WebView/WebView.mm:
659         (-[WebView _setUseSystemAppearance:]):
660         (-[WebView effectiveAppearanceDidChange]):
661
662 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
663
664         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
665         https://bugs.webkit.org/show_bug.cgi?id=183677
666
667         Reviewed by Tim Horton.
668
669         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
670
671         * DOM/DOM.mm:
672         (-[DOMHTMLLinkElement _mediaQueryMatches]):
673
674 2018-03-14  Tim Horton  <timothy_horton@apple.com>
675
676         Fix the build after r229567
677
678         * Configurations/FeatureDefines.xcconfig:
679
680 2018-03-12  Tim Horton  <timothy_horton@apple.com>
681
682         Stop using SDK conditionals to control feature definitions
683         https://bugs.webkit.org/show_bug.cgi?id=183430
684         <rdar://problem/38251619>
685
686         Reviewed by Dan Bernstein.
687
688         * Configurations/FeatureDefines.xcconfig:
689         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
690
691 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
692
693         Runtime flag for link prefetch and remove link subresource.
694         https://bugs.webkit.org/show_bug.cgi?id=183540
695
696         Reviewed by Chris Dumez.
697
698         Remove the LINK_PREFETCH build time flag.
699
700         * Configurations/FeatureDefines.xcconfig:
701
702 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
703
704         Remove GridLayout runtime flag
705         https://bugs.webkit.org/show_bug.cgi?id=183484
706
707         Reviewed by Myles C. Maxfield.
708
709         The Grid Layout feature has been enabled by default for almost a
710         year, so I think it's time to remove the runtime flag and the
711
712         * WebView/WebPreferenceKeysPrivate.h:
713         * WebView/WebPreferences.mm:
714         (+[WebPreferences initialize]):
715         * WebView/WebPreferencesPrivate.h:
716         * WebView/WebView.mm:
717         (-[WebView _preferencesChanged:]):
718
719 2018-03-12  Antoine Quint  <graouts@apple.com>
720
721         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
722         https://bugs.webkit.org/show_bug.cgi?id=183504
723         <rdar://problem/38372965>
724
725         Reviewed by Dean Jackson and Jon Lee.
726
727         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
728         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
729
730         * WebView/WebPreferenceKeysPrivate.h:
731         * WebView/WebPreferences.mm:
732         (+[WebPreferences initialize]):
733         (-[WebPreferences setModernMediaControlsEnabled:]):
734         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
735         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
736         * WebView/WebPreferencesPrivate.h:
737         * WebView/WebView.mm:
738         (-[WebView _preferencesChanged:]):
739
740 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
741
742         Media query for default appearance
743         https://bugs.webkit.org/show_bug.cgi?id=183539
744         <rdar://problem/38326388>
745
746         Reviewed by Tim Horton.
747
748         Write a media query to evaluate appearance.
749
750         * WebView/WebView.mm:
751         (-[WebView _commonInitializationWithFrameName:groupName:]):
752         (-[WebView _setUseSystemAppearance:]):
753
754 2018-03-09  Andy Estes  <aestes@apple.com>
755
756         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
757         https://bugs.webkit.org/show_bug.cgi?id=183489
758         <rdar://problem/38267517>
759
760         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
761         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
762         to issue a sandbox extension for this directory, but for security reasons App Sandbox
763         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
764         block with a nil error and a valid file URL, but no file will actually exist at that URL.
765
766         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
767         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
768         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
769         drop destination.
770
771         Reviewed by Wenson Hsieh.
772
773         * WebView/WebView.mm:
774         (-[WebView performDragOperation:]):
775
776 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
777
778         Allow WebViews to disable system appearance
779         https://bugs.webkit.org/show_bug.cgi?id=183418
780         <rdar://problem/36975642>
781
782         Reviewed by Tim Horton.
783
784         Allow webviews to choose whether or not to follow the default system appearance.
785
786         * WebView/WebView.mm:
787         (-[WebView _setUseSystemAppearance:]):
788         (-[WebView _useSystemAppearance]):
789         * WebView/WebViewPrivate.h:
790
791 2018-03-08  Youenn Fablet  <youenn@apple.com>
792
793         libwebrtc update broke internal builds
794         https://bugs.webkit.org/show_bug.cgi?id=183454
795
796         Reviewed by Eric Carlson.
797
798         * Configurations/WebKitLegacy.xcconfig:
799
800 2018-03-08  Chris Dumez  <cdumez@apple.com>
801
802         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
803         https://bugs.webkit.org/show_bug.cgi?id=183455
804         <rdar://problem/38191749>
805
806         Reviewed by Youenn Fablet.
807
808         Add a null check for the page as we have evidence from crashes that it can be null.
809         Other functions in WebFrameNetworkingContext already null check the page as well,
810         not just the frame so this is consistent.
811
812         * WebCoreSupport/WebFrameNetworkingContext.mm:
813         (WebFrameNetworkingContext::storageSession const):
814
815 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
816
817         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
818         https://bugs.webkit.org/show_bug.cgi?id=183429
819
820         Reviewed by Mark Lam.
821
822         * DOM/DOM.mm:
823         (+[DOMNode _nodeFromJSWrapper:]):
824         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
825         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
826         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
827         * Plugins/Hosted/ProxyInstance.mm:
828         (WebKit::ProxyInstance::invokeMethod):
829         * WebView/WebView.mm:
830         (aeDescFromJSValue):
831
832 2018-03-08  Tim Horton  <timothy_horton@apple.com>
833
834         Stop linking ApplicationServices directly
835         https://bugs.webkit.org/show_bug.cgi?id=182867
836         <rdar://problem/38252142>
837
838         Reviewed by Alex Christensen.
839
840         The frameworks that we use that live inside ApplicationServices
841         have mostly moved out, so import them directly.
842
843         * Carbon/CarbonUtils.h:
844         * WebKitPrefix.h:
845         * WebView/WebHTMLView.mm:
846         * WebView/WebPDFView.mm:
847
848 2018-03-07  Tim Horton  <timothy_horton@apple.com>
849
850         Sort and separate FeatureDefines.xcconfig
851         https://bugs.webkit.org/show_bug.cgi?id=183427
852
853         Reviewed by Dan Bernstein.
854
855         * Configurations/FeatureDefines.xcconfig:
856         Sort and split FeatureDefines into paragraphs
857         (to make it easier to sort later).
858
859 2018-03-07  Youenn Fablet  <youenn@apple.com>
860
861         Match unsupported plugins based on domains and not origin
862         https://bugs.webkit.org/show_bug.cgi?id=183384
863
864         Reviewed by Chris Dumez.
865
866         * WebCoreSupport/WebPluginInfoProvider.h:
867         * WebCoreSupport/WebPluginInfoProvider.mm:
868         (WebPluginInfoProvider::getPluginInfo):
869         (WebPluginInfoProvider::getWebVisiblePluginInfo):
870
871 2018-03-05  Andy Estes  <aestes@apple.com>
872
873         [Mac] Teach WebCore::Pasteboard about file promise drags
874         https://bugs.webkit.org/show_bug.cgi?id=183314
875         <rdar://problem/38105493>
876
877         Reviewed by Darin Adler.
878
879         Added a FIXME comment.
880
881         * WebView/WebView.mm:
882         (-[WebView performDragOperation:]):
883
884 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
885
886         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
887         https://bugs.webkit.org/show_bug.cgi?id=183312
888
889         Reviewed by Mark Lam.
890
891         Remove wtf/CurrentTime.h include pragma.
892
893         * WebView/WebFrame.mm:
894         * WebView/WebPDFView.mm:
895
896 2018-03-04  Tim Horton  <timothy_horton@apple.com>
897
898         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
899         https://bugs.webkit.org/show_bug.cgi?id=183283
900         <rdar://problem/38062148>
901
902         Reviewed by Sam Weinig.
903
904         * Configurations/FeatureDefines.xcconfig:
905
906 2018-02-28  Alex Christensen  <achristensen@webkit.org>
907
908         Reduce use of NetworkingContext in WebKit
909         https://bugs.webkit.org/show_bug.cgi?id=183213
910
911         Reviewed by Brady Eidson.
912
913         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
914         (WebKit::NetscapePluginInstanceProxy::getProxy):
915         * Plugins/WebNetscapePluginView.mm:
916         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
917
918 2018-02-17  Darin Adler  <darin@apple.com>
919
920         Prepare for ExtendedColor changes (first step)
921         https://bugs.webkit.org/show_bug.cgi?id=182904
922
923         Reviewed by Sam Weinig.
924
925         * Misc/WebKitNSStringExtras.mm:
926         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
927
928 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
929
930         Remove currentTime() / currentTimeMS()
931         https://bugs.webkit.org/show_bug.cgi?id=183052
932
933         Reviewed by Mark Lam.
934
935         * WebCoreSupport/WebFrameLoaderClient.h:
936         * WebCoreSupport/WebFrameLoaderClient.mm:
937         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
938
939 2018-02-16  Youenn Fablet  <youenn@apple.com>
940
941         Allow specifying which plug-ins are supported
942         https://bugs.webkit.org/show_bug.cgi?id=182748
943
944         Reviewed by Chris Dumez.
945
946         * WebCoreSupport/WebPluginInfoProvider.h:
947         * WebCoreSupport/WebPluginInfoProvider.mm:
948         (WebPluginInfoProvider::getPluginInfo):
949         (WebPluginInfoProvider::getWebVisiblePluginInfo):
950
951 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
952
953         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
954         https://bugs.webkit.org/show_bug.cgi?id=182882
955         <rdar://problem/35672661>
956
957         Reviewed by Dan Bernstein.
958
959         Make sure the smart pointer hold the collection of subviews lives at least as
960         long as the loop using it.
961
962         * WebView/WebHTMLView.mm:
963         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
964
965 2018-02-14  Daniel Bates  <dabates@apple.com>
966
967         Disallow cross-origin subresources from asking for credentials
968         https://bugs.webkit.org/show_bug.cgi?id=182579
969         <rdar://problem/36162271>
970
971         Reviewed by Andy Estes.
972
973         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
974         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
975
976         * WebView/WebPreferenceKeysPrivate.h:
977         * WebView/WebPreferences.mm:
978         (+[WebPreferences initialize]):
979         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
980         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
981         * WebView/WebPreferencesPrivate.h:
982         * WebView/WebView.mm:
983         (-[WebView _preferencesChanged:]):
984
985 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
986
987         Remove ForwardingHeaders directory from WebKitLegacy/mac.
988         https://bugs.webkit.org/show_bug.cgi?id=182738
989
990         Reviewed by Darin Adler.
991
992         * ForwardingHeaders/collector/handles/Global.h: Removed.
993         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
994         * ForwardingHeaders/runtime/Completion.h: Removed.
995         * ForwardingHeaders/runtime/Error.h: Removed.
996         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
997         * ForwardingHeaders/runtime/JSFunction.h: Removed.
998         * ForwardingHeaders/runtime/JSLock.h: Removed.
999         * ForwardingHeaders/runtime/JSObject.h: Removed.
1000         * ForwardingHeaders/runtime/JSString.h: Removed.
1001         * ForwardingHeaders/runtime/Protect.h: Removed.
1002         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
1003
1004 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1005
1006         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
1007         https://bugs.webkit.org/show_bug.cgi?id=182641
1008
1009         Reviewed by Dan Bernstein.
1010
1011         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1012         https://trac.webkit.org/changeset/228308.
1013
1014         * WebView/WebVideoFullscreenController.h:
1015         * WebView/WebVideoFullscreenHUDWindowController.mm:
1016         * WebView/WebWindowAnimation.h:
1017         * WebView/WebWindowAnimation.mm:
1018         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1019         (WebCore::scaledRect): Deleted.
1020         (WebCore::squaredDistance): Deleted.
1021
1022 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1023
1024         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1025
1026         * WebView/WebWindowAnimation.mm:
1027         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1028
1029 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1030
1031         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1032         https://bugs.webkit.org/show_bug.cgi?id=182615
1033
1034         Reviewed by Eric Carlson.
1035
1036         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1037         Ideally, we should not reference NSApp in WebCore.
1038
1039         * WebView/WebFullScreenController.mm:
1040         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1041         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1042         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1043         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1044         * WebView/WebView.mm:
1045         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1046         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1047
1048 2018-01-13  Darin Adler  <darin@apple.com>
1049
1050         Event improvements
1051         https://bugs.webkit.org/show_bug.cgi?id=179591
1052
1053         Reviewed by Chris Dumez.
1054
1055         * DOM/DOMWheelEvent.mm:
1056         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1057         Call initWebKitWheelEvent.
1058
1059         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1060         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1061         * WebView/WebFrame.mm: Ditto.
1062
1063         * WebView/WebHTMLView.mm:
1064         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1065         underlyingPlatformEvent.
1066         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1067
1068         * WebView/WebScriptWorld.mm:
1069         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1070
1071         * WebView/WebView.mm: Removed include of ScriptValue.h.
1072
1073 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1074
1075         Remove WebCore/ForwardingHeaders directory
1076         https://bugs.webkit.org/show_bug.cgi?id=182347
1077
1078         Reviewed by Keith Miller.
1079
1080         * Carbon/CarbonWindowAdapter.mm:
1081         * DOM/WebDOMOperations.mm:
1082         * History/WebBackForwardList.mm:
1083         * History/WebHistoryItem.mm:
1084         * Misc/WebCache.mm:
1085         * Misc/WebElementDictionary.mm:
1086         * Misc/WebIconDatabase.mm:
1087         * Misc/WebStringTruncator.mm:
1088         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1089         * Plugins/Hosted/ProxyInstance.mm:
1090         * Plugins/Hosted/ProxyRuntimeObject.mm:
1091         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1092         * Plugins/WebBaseNetscapePluginView.mm:
1093         * Plugins/WebBasePluginPackage.mm:
1094         * Plugins/WebNetscapePluginStream.mm:
1095         * Plugins/WebNetscapePluginView.mm:
1096         * Plugins/WebPluginController.mm:
1097         * WebCoreSupport/WebEditorClient.mm:
1098         * WebCoreSupport/WebFrameLoaderClient.mm:
1099         * WebCoreSupport/WebInspectorClient.h:
1100         * WebCoreSupport/WebInspectorClient.mm:
1101         * WebView/WebDataSource.mm:
1102         * WebView/WebFrame.mm:
1103         * WebView/WebHTMLRepresentation.mm:
1104         * WebView/WebHTMLView.mm:
1105         * WebView/WebPreferences.mm:
1106         * WebView/WebScriptDebugDelegate.mm:
1107         * WebView/WebScriptDebugger.h:
1108         * WebView/WebTextIterator.mm:
1109         * WebView/WebView.mm:
1110         * WebView/WebViewData.mm:
1111
1112 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1113
1114         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1115         https://bugs.webkit.org/show_bug.cgi?id=182312
1116
1117         Reviewed by Michael Catanzaro.
1118
1119         * WebKitPrefix.h:
1120
1121 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1122
1123         [WebAuthN] Add a compile-time feature flag
1124         https://bugs.webkit.org/show_bug.cgi?id=182211
1125         <rdar://problem/36936365>
1126
1127         Reviewed by Brent Fulgham.
1128
1129         * Configurations/FeatureDefines.xcconfig:
1130
1131 2018-01-27  Dan Bernstein  <mitz@apple.com>
1132
1133         HaveInternalSDK includes should be "#include?"
1134         https://bugs.webkit.org/show_bug.cgi?id=179670
1135
1136         * Configurations/Base.xcconfig:
1137
1138 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1139
1140         Remove unused QTKit preference
1141         https://bugs.webkit.org/show_bug.cgi?id=181968
1142
1143         Reviewed by Alexey Proskuryakov.
1144
1145         * WebView/WebPreferenceKeysPrivate.h:
1146         * WebView/WebPreferences.mm:
1147         (+[WebPreferences initialize]):
1148         (-[WebPreferences setQTKitEnabled:]): Deleted.
1149         (-[WebPreferences isQTKitEnabled]): Deleted.
1150         * WebView/WebPreferencesPrivate.h:
1151         * WebView/WebView.mm:
1152         (-[WebView _preferencesChanged:]):
1153
1154 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1155
1156         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1157         https://bugs.webkit.org/show_bug.cgi?id=182037
1158         <rdar://problem/36747812>
1159
1160         Reviewed by Ryosuke Niwa.
1161
1162         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1163         for more details.
1164
1165         * WebView/WebHTMLRepresentation.mm:
1166         (-[WebHTMLRepresentation elementWithName:inForm:]):
1167         (-[WebHTMLRepresentation controlsInForm:]):
1168
1169 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1170
1171         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1172         https://bugs.webkit.org/show_bug.cgi?id=181961
1173
1174         Reviewed by Michael Catanzaro.
1175
1176         * WebView/WebPreferences.mm:
1177
1178 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1179
1180         Unreviewed, rolling out r227437.
1181         https://bugs.webkit.org/show_bug.cgi?id=182011
1182
1183         broke build (Requested by alexchristensen on #webkit).
1184
1185         Reverted changeset:
1186
1187         "Remove unused QTKit preference"
1188         https://bugs.webkit.org/show_bug.cgi?id=181968
1189         https://trac.webkit.org/changeset/227437
1190
1191 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1192
1193         Remove unused QTKit preference
1194         https://bugs.webkit.org/show_bug.cgi?id=181968
1195
1196         Reviewed by Alexey Proskuryakov.
1197
1198         * WebView/WebPreferenceKeysPrivate.h:
1199         * WebView/WebPreferences.mm:
1200         (+[WebPreferences initialize]):
1201         (-[WebPreferences setQTKitEnabled:]): Deleted.
1202         (-[WebPreferences isQTKitEnabled]): Deleted.
1203         * WebView/WebPreferencesPrivate.h:
1204         * WebView/WebView.mm:
1205         (-[WebView _preferencesChanged:]):
1206
1207 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1208
1209         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1210         https://bugs.webkit.org/show_bug.cgi?id=181960
1211         <rdar://problem/36431678>
1212
1213         Reviewed by Tim Horton.
1214
1215         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1216         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1217         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1218
1219         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1220         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1221         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1222
1223         * WebView/WebView.mm:
1224         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1225
1226 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1227
1228         Turning off custom pasteboard data doesn't actually turn it off in WK2
1229         https://bugs.webkit.org/show_bug.cgi?id=181920
1230         <rdar://problem/36686429>
1231
1232         Reviewed by Wenson Hsieh.
1233
1234         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1235
1236         * WebView/WebPreferences.mm:
1237         (+[WebPreferences initialize]):
1238         * WebView/WebView.mm:
1239         (-[WebView _preferencesChanged:]):
1240
1241 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1242
1243         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1244         https://bugs.webkit.org/show_bug.cgi?id=181918
1245
1246         Reviewed by Tim Horton.
1247
1248         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1249
1250         * Configurations/FeatureDefines.xcconfig:
1251
1252 2018-01-20  Andy Estes  <aestes@apple.com>
1253
1254         [Apple Pay] Stop eagerly loading PassKit.framework
1255         https://bugs.webkit.org/show_bug.cgi?id=181911
1256         <rdar://problem/36555369>
1257
1258         Reviewed by Tim Horton.
1259
1260         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1261         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1262         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1263
1264         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1265
1266 2018-01-19  Dean Jackson  <dino@apple.com>
1267
1268         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1269         https://bugs.webkit.org/show_bug.cgi?id=181817
1270         <rdar://problem/35274055>
1271
1272         Reviewed by Simon Fraser.
1273
1274         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1275
1276         * Misc/WebKitVersionChecks.h:
1277         * WebView/WebView.mm:
1278         (-[WebView _commonInitializationWithFrameName:groupName:]):
1279
1280 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1281
1282         Remove unused WebViewPrivate _allowCookies
1283         https://bugs.webkit.org/show_bug.cgi?id=181812
1284
1285         Reviewed by Tim Horton.
1286
1287         * WebView/WebView.mm:
1288         (+[WebView _setAllowCookies:]): Deleted.
1289         (+[WebView _allowCookies]): Deleted.
1290         * WebView/WebViewPrivate.h:
1291
1292 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1293
1294         Build fix, remove a call to -[NSWindow setOneShot:]
1295         https://bugs.webkit.org/show_bug.cgi?id=181809
1296
1297         Reviewed by Tim Horton.
1298
1299         * WebView/WebTextCompletionController.mm:
1300         (-[WebTextCompletionController _buildUI]):
1301
1302 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1303
1304         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1305
1306         * Carbon/HIWebView.mm:
1307         (overrideCGContext):
1308         (restoreCGContext):
1309
1310 2018-01-18  Dan Bernstein  <mitz@apple.com>
1311
1312         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1313         https://bugs.webkit.org/show_bug.cgi?id=181803
1314
1315         Reviewed by Tim Horton.
1316
1317         * Configurations/Base.xcconfig: Updated.
1318         * Configurations/DebugRelease.xcconfig: Ditto.
1319         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1320         * Configurations/Version.xcconfig: Updated.
1321         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1322           useful for defining settings that depend on the target macOS version.
1323
1324 2018-01-17  Youenn Fablet  <youenn@apple.com>
1325
1326         Put fetch Request.keepalive behind a runtime flag
1327         https://bugs.webkit.org/show_bug.cgi?id=181592
1328
1329         Reviewed by Chris Dumez.
1330
1331         * WebView/WebPreferenceKeysPrivate.h:
1332         * WebView/WebPreferences.mm:
1333         (+[WebPreferences initialize]):
1334         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1335         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1336         * WebView/WebPreferencesPrivate.h:
1337         * WebView/WebView.mm:
1338         (-[WebView _preferencesChanged:]):
1339
1340 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1341
1342         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1343         https://bugs.webkit.org/show_bug.cgi?id=181637
1344         <rdar://problem/36508471>
1345
1346         Reviewed by Tim Horton.
1347
1348         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1349
1350         * WebCoreSupport/WebEditorClient.h:
1351         * WebCoreSupport/WebEditorClient.mm:
1352         (WebEditorClient::replacementURLForResource):
1353
1354 2018-01-11  Keith Miller  <keith_miller@apple.com>
1355
1356         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1357         https://bugs.webkit.org/show_bug.cgi?id=181573
1358
1359         Reviewed by Simon Fraser.
1360
1361         * Configurations/FeatureDefines.xcconfig:
1362
1363 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1364
1365         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1366         https://bugs.webkit.org/show_bug.cgi?id=181497
1367
1368         Reviewed by Tim Horton.
1369
1370         See other ChangeLogs for more detail.
1371
1372         * WebCoreSupport/WebDragClient.h:
1373
1374 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1375
1376         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1377         https://bugs.webkit.org/show_bug.cgi?id=181523
1378         <rdar://problem/28959131>
1379
1380         Reviewed by Alex Christensen.
1381
1382         * WebView/WebImmediateActionController.mm:
1383         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1384         Apply the change made in r216652 to WebKit1's immediate action controller.
1385
1386         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1387         the startContainer of the range is in an anonymous node.
1388
1389 2018-01-11  Youenn Fablet  <youenn@apple.com>
1390
1391         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1392         https://bugs.webkit.org/show_bug.cgi?id=181480
1393
1394         Reviewed by Eric Carlson.
1395
1396         * WebView/WebPreferences.mm:
1397         (+[WebPreferences initialize]):
1398
1399 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1400
1401         Fix check-webkit-style issues with WebNSDataExtras.mm
1402         <https://webkit.org/b/181369>
1403
1404         Reviewed by Alex Christensen.
1405
1406         * Misc/WebNSDataExtras.mm:
1407         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1408         (-[NSData _webkit_guessedMIMETypeForXML]):
1409         (-[NSData _webkit_guessedMIMEType]):
1410         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1411         (_findEOL):
1412         (-[NSData _webkit_parseRFC822HeaderFields]):
1413         (-[NSData _web_locationAfterFirstBlankLine]):
1414         - Fix all the check-webkit-style warnings.
1415
1416 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1417
1418         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1419         <https://webkit.org/b/181256>
1420         <rdar://problem/36281730>
1421
1422         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1423         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1424         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1425           to avoid warnings from casting CFStringRef to NPNSString*.
1426           Note that CFMutableStringRef is the same as CFStringRef
1427           without the const modifier, hence its use in the const_cast<>
1428           above.
1429
1430 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1431
1432         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1433         <https://webkit.org/b/181256>
1434         <rdar://problem/36281730>
1435
1436         * Carbon/HIWebView.mm:
1437         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1438         checked_cf_cast<CFRunLoopRef>() to fix warning.
1439
1440 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1441
1442         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1443         <https://webkit.org/b/181256>
1444         <rdar://problem/36281730>
1445
1446         Reviewed by Darin Adler.
1447
1448         * Carbon/CarbonUtils.m:
1449         (PoolCleaner):
1450         - Use #pragmas to ignore -Wcast-qual warnings when using a
1451           C-style cast from CFTypeRef to CFRunloopRef.
1452         * Carbon/CarbonWindowFrame.m:
1453         (-[CarbonWindowFrame title]):
1454         - Use #pragmas to ignore -Wcast-qual warnings when using a
1455           C-style cast from CFStringRef to NSString *.
1456         * Carbon/HIViewAdapter.m:
1457         (+[HIViewAdapter getHIViewForNSView:]):
1458         - Use #pragmas to ignore -Wcast-qual warnings when using a
1459           C-style cast from CFTypeRef to HIViewRef.
1460         * Configurations/Base.xcconfig:
1461         (WARNING_CFLAGS): Add -Wcast-qual.
1462         * Misc/WebElementDictionary.mm:
1463         (-[WebElementDictionary objectForKey:]):
1464         - Use static_cast<SEL>(const_cast<void*>()) to fix
1465           warning.
1466         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1467         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1468         (-[NSData _webkit_guessedMIMETypeForXML]):
1469         (-[NSData _webkit_guessedMIMEType]):
1470         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1471         (_findEOL):
1472         (-[NSData _webkit_parseRFC822HeaderFields]):
1473         (-[NSData _web_startsWithBlankLine]):
1474         (-[NSData _web_locationAfterFirstBlankLine]):
1475         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1476           type to Objective-C++.  This fixes the warnings about
1477           discarding the `const` modifier when casing from CFStringRef
1478           to NSString * because in older clang versions, -Wcast-qual was
1479           completely broken when compiling C++ and Objective-C++ source
1480           files.  In newer clang versions, discarding the `const`
1481           modifier for toll-free bridged types is ignored when compiling
1482           Objective-C++ source.
1483         - Update copyright and license header.
1484         - Use reinterpret_cast<> and static_cast<> to fix warnings
1485           unrelated to (NSString *) C-style casts.
1486         - Replace use of MIN() macro with std::min<> template functions.
1487         - Fix location of `*` for local variables modified above.
1488         * Plugins/Hosted/NetscapePluginHostManager.mm:
1489         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1490         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1491         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1492         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1493           warnings.
1494         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1495         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1496         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1497           to fix warning.
1498         * Plugins/Hosted/ProxyInstance.mm:
1499         (WebKit::ProxyInstance::invoke):
1500         - Use static_cast<char*>(const_cast<void*>()) to fix
1501           warning when using -[NSData bytes].
1502         (WebKit::ProxyInstance::fieldValue const):
1503         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1504           to fix warning when using CFDataGetBytePtr().
1505         * Plugins/Hosted/WebTextInputWindowController.m:
1506         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1507         - Use #pragma to ignore -Wcast-qual warning since there
1508           is not a good way to avoid this warning in Objective-C.
1509         * Plugins/WebNetscapePluginStream.mm:
1510         (WebNetscapePluginStream::deliverData):
1511         - Use const_cast<void*>() to fix warning when using
1512           -[NSData bytes].
1513         * Plugins/WebNetscapePluginView.mm:
1514         (-[WebNetscapePluginView _createPlugin]):
1515         - Change C-style cast to const_cast<char*>() to fix
1516           warning.
1517         * WebCoreSupport/WebChromeClient.mm:
1518         (WebChromeClient::wrapCryptoKey const):
1519         (WebChromeClient::unwrapCryptoKey const):
1520         - Change C-style cast to
1521           static_cast<uint8_t*>(const_cast<void*>() to fix
1522           warning.
1523         * WebView/WebPDFView.mm:
1524         (_applicationInfoForMIMEType):
1525         - Change local variable type from 'NSURL *' to
1526           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1527           when calling -[NSURL path].
1528
1529 2018-01-05  Dan Bernstein  <mitz@apple.com>
1530
1531         Fixed the build following AppKit API deprecations in a recent SDKs
1532
1533         * WebView/WebFullScreenController.mm:
1534         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1535         (-[WebFullScreenController exitFullScreen]): Ditto.
1536         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1537         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1538         * WebView/WebHTMLView.mm:
1539         (-[WebHTMLView drawRect:]): Ditto.
1540         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1541         (-[WebHTMLView knowsPageRange:]): Ditto.
1542         * WebView/WebView.mm:
1543         (LayerFlushController::flushLayers): Ditto.
1544
1545 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1546
1547         [Attachment Support] Create attachment elements when dropping files on iOS
1548         https://bugs.webkit.org/show_bug.cgi?id=181192
1549         <rdar://problem/36280945>
1550
1551         Reviewed by Tim Horton.
1552
1553         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1554
1555         * WebCoreSupport/WebPlatformStrategies.h:
1556         * WebCoreSupport/WebPlatformStrategies.mm:
1557         (WebPlatformStrategies::informationForItemAtIndex):
1558         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1559
1560 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1561
1562         [Attachment Support] Add plumbing for starting a drag with promised blob data
1563         https://bugs.webkit.org/show_bug.cgi?id=181201
1564
1565         Reviewed by Tim Horton.
1566
1567         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1568
1569         * WebCoreSupport/WebDragClient.h:
1570
1571 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1572
1573         Add a WebAuthentication runtime feature flag
1574         https://bugs.webkit.org/show_bug.cgi?id=181220
1575         <rdar://problem/36055305>
1576
1577         Reviewed by Brent Fulgham.
1578
1579         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1580
1581         * WebView/WebPreferenceKeysPrivate.h:
1582         * WebView/WebPreferences.mm:
1583         (+[WebPreferences initialize]):
1584         (-[WebPreferences webAuthenticationEnabled]):
1585         (-[WebPreferences setWebAuthenticationEnabled:]):
1586         (-[WebPreferences credentialManagementEnabled]): Deleted.
1587         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1588         * WebView/WebPreferencesPrivate.h:
1589         * WebView/WebView.mm:
1590         (-[WebView _preferencesChanged:]):
1591
1592 2017-12-22  Jeff Miller  <jeffm@apple.com>
1593
1594         Update user-visible copyright strings to include 2018
1595         https://bugs.webkit.org/show_bug.cgi?id=181141
1596
1597         Reviewed by Dan Bernstein.
1598
1599         * Info.plist:
1600
1601 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1602
1603         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1604         https://bugs.webkit.org/show_bug.cgi?id=181188
1605
1606         Reviewed by Dan Bernstein.
1607
1608         See WebCore/ChangeLog for more detail.
1609
1610         * WebCoreSupport/WebDragClient.h:
1611         * WebCoreSupport/WebDragClient.mm:
1612         (WebDragClient::declareAndWriteAttachment): Deleted.
1613         * WebView/WebHTMLView.mm:
1614         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1615
1616 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1617
1618         Unreviewed, continue to fix build failures due to AppKit API deprecation
1619
1620         Wraps more code in -Wdeprecated-declarations.
1621
1622         * Carbon/HIWebView.mm:
1623         (overrideCGContext):
1624
1625 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1626
1627         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1628
1629         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1630
1631         * Carbon/CarbonWindowAdapter.mm:
1632         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1633         * Plugins/WebNetscapePluginView.mm:
1634         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1635         (-[WebNetscapePluginView sendDrawRectEvent:]):
1636         (-[WebNetscapePluginView drawRect:]):
1637
1638 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1639
1640         Fix build failures due to using deprecated AppKit symbols
1641         https://bugs.webkit.org/show_bug.cgi?id=181110
1642         <rdar://problem/36162865>
1643
1644         Reviewed by Dan Bernstein and Tim Horton.
1645
1646         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1647
1648         * Misc/WebKitNSStringExtras.mm:
1649         (-[NSString _web_drawAtPoint:font:textColor:]):
1650         * Misc/WebNSPasteboardExtras.h:
1651         * Misc/WebNSPasteboardExtras.mm:
1652         (+[NSPasteboard _web_writableTypesForURL]):
1653         (_createWritableTypesForImageWithoutArchive):
1654         (_createWritableTypesForImageWithArchive):
1655         (+[NSPasteboard _web_dragTypesForURL]):
1656         (-[NSPasteboard _web_bestURL]):
1657         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1658         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1659         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1660         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1661         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1662         * Panels/WebAuthenticationPanel.m:
1663         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1664         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1665         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1666         (-[WebHostedNetscapePluginView drawRect:]):
1667         * WebInspector/WebNodeHighlightView.mm:
1668         (-[WebNodeHighlightView drawRect:]):
1669         * WebView/WebFrame.mm:
1670         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1671         (-[WebFrame _drawRect:contentsOnly:]):
1672         * WebView/WebHTMLView.mm:
1673         (kit):
1674         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1675         (-[WebHTMLView _plainTextFromPasteboard:]):
1676         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1677         (+[WebHTMLView _insertablePasteboardTypes]):
1678         (+[WebHTMLView _selectionPasteboardTypes]):
1679         (-[WebHTMLView pasteboard:provideDataForType:]):
1680         (-[WebHTMLView _writeSelectionToPasteboard:]):
1681         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1682         (-[WebHTMLView validRequestorForSendType:returnType:]):
1683         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1684         (createMenuItem):
1685         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1686         (-[WebHTMLView _colorAsString:]):
1687         (-[WebHTMLView copyFont:]):
1688         * WebView/WebPDFView.mm:
1689         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1690         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1691         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1692         (-[WebPDFView pasteboardTypesForSelection]):
1693         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1694         * WebView/WebView.h:
1695         * WebView/WebView.mm:
1696         (-[WebView performDragOperation:]):
1697         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1698         (-[WebView _searchWithGoogleFromMenu:]):
1699
1700 2017-12-21  Youenn Fablet  <youenn@apple.com>
1701
1702         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1703         https://bugs.webkit.org/show_bug.cgi?id=181000
1704
1705         Reviewed by Chris Dumez.
1706
1707         * Misc/WebCache.mm:
1708         (+[WebCache addImageToCache:forURL:forFrame:]):
1709
1710 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1711
1712         Update FULLSCREEN_API feature defines.
1713         https://bugs.webkit.org/show_bug.cgi?id=181015
1714
1715         Reviewed by Tim Horton.
1716
1717         Change enabled iphone sdk for FULLSCREEN_API.
1718
1719         * Configurations/FeatureDefines.xcconfig:
1720
1721 2017-12-21  Jer Noble  <jer.noble@apple.com>
1722
1723         Add initial DOM support for Media Capabilities
1724         https://bugs.webkit.org/show_bug.cgi?id=181064
1725
1726         Reviewed by Eric Carlson.
1727
1728         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1729
1730         * WebView/WebPreferenceKeysPrivate.h:
1731         * WebView/WebPreferences.mm:
1732         (+[WebPreferences initialize]):
1733         (-[WebPreferences mediaCapabilitiesEnabled]):
1734         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1735         * WebView/WebPreferencesPrivate.h:
1736         * WebView/WebView.mm:
1737         (-[WebView _preferencesChanged:]):
1738
1739 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1740
1741         Enable picture-in-picture from inline element on suspend.
1742         https://bugs.webkit.org/show_bug.cgi?id=180942
1743         rdar://problem/34745234
1744
1745         Reviewed by Jer Noble.
1746
1747         Update signature of enterVideoFullscreenForVideoElement().
1748
1749         * WebCoreSupport/WebChromeClient.h:
1750         * WebCoreSupport/WebChromeClient.mm:
1751         (WebChromeClient::enterVideoFullscreenForVideoElement):
1752
1753 2017-12-20  Daniel Bates  <dabates@apple.com>
1754
1755         Remove Alternative Presentation Button
1756         https://bugs.webkit.org/show_bug.cgi?id=180500
1757         <rdar://problem/35891047>
1758
1759         Reviewed by Simon Fraser.
1760
1761         We no longer need the alternative presentation button.
1762
1763         * Configurations/FeatureDefines.xcconfig:
1764
1765 2017-12-19  Jer Noble  <jer.noble@apple.com>
1766
1767         Playing media elements which call "pause(); play()" will have the play promise rejected.
1768         https://bugs.webkit.org/show_bug.cgi?id=180781
1769         <rdar://problem/33191377>
1770
1771         Reviewed by Eric Carlson.
1772
1773         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1774
1775         * WebView/WebView.mm:
1776         (shouldRequireUserGestureToLoadVideo):
1777
1778 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1779
1780         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1781         https://bugs.webkit.org/show_bug.cgi?id=180977
1782
1783         Reviewed by Tim Horton.
1784
1785         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1786         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1787         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1788
1789         * WebCoreSupport/WebEditorClient.mm:
1790         (attributesForAttributedStringConversion):
1791         * WebView/WebHTMLView.mm:
1792         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1793
1794 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1795
1796         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1797
1798         Attempt to fix the following warnings:
1799
1800             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1801
1802         For the following instance variables:
1803
1804             _borderView
1805             _contentView
1806             _frame
1807             _wFlags
1808
1809         * Carbon/CarbonWindowAdapter.mm:
1810         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1811         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1812         (-[CarbonWindowAdapter _termWindowIfOwner]):
1813         (-[CarbonWindowAdapter _windowMovedToRect:]):
1814         (-[CarbonWindowAdapter setContentView:]):
1815         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1816         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1817
1818 2017-12-16  Dan Bernstein  <mitz@apple.com>
1819
1820         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1821         https://bugs.webkit.org/show_bug.cgi?id=180613
1822         <rdar://problem/35946124>
1823
1824         Reviewed by Geoff Garen.
1825
1826         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1827           clients.
1828         * WebView/WebDynamicScrollBarsView.h: Ditto.
1829         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1830
1831 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1832
1833         Enable -Wstrict-prototypes for WebKit
1834         <https://webkit.org/b/180757>
1835         <rdar://problem/36024132>
1836
1837         Rubber-stamped by Joseph Pecoraro.
1838
1839         * Configurations/Base.xcconfig:
1840         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1841
1842 2017-12-14  John Wilander  <wilander@apple.com>
1843
1844         Storage Access API: Implement frame-specific access in the document.cookie layer
1845         https://bugs.webkit.org/show_bug.cgi?id=180682
1846         <rdar://problem/35982257>
1847
1848         Reviewed by Alex Christensen.
1849
1850         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1851         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1852         CookiesStrategy::getRawCookies() now take optional parameters for
1853         frameID and pageID to allow frame-specific scoping of cookies.
1854
1855         This change makes the return values of FrameLoaderClient::frameID()
1856         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1857         WebCore can call those getters and get the right return values in
1858         WebKit and std:nullopt in WebKitLegacy.
1859
1860         * WebCoreSupport/WebFrameLoaderClient.h:
1861         * WebCoreSupport/WebFrameLoaderClient.mm:
1862         (WebFrameLoaderClient::pageID const):
1863         (WebFrameLoaderClient::frameID const):
1864         * WebCoreSupport/WebPlatformStrategies.h:
1865         * WebCoreSupport/WebPlatformStrategies.mm:
1866         (WebPlatformStrategies::cookiesForDOM):
1867         (WebPlatformStrategies::setCookiesFromDOM):
1868         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1869         (WebPlatformStrategies::getRawCookies):
1870
1871 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1872
1873         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1874         https://bugs.webkit.org/show_bug.cgi?id=180689
1875
1876         Reviewed by Tim Horton.
1877
1878         Use sRGBColorSpaceRef() from WebCore.
1879
1880         * WebView/WebHTMLView.mm:
1881         (imageFromRect):
1882
1883 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1884
1885         Stop using deprecated target conditional for simulator builds
1886         https://bugs.webkit.org/show_bug.cgi?id=180662
1887         <rdar://problem/35136156>
1888
1889         Reviewed by Simon Fraser.
1890
1891         * postprocess-headers.sh:
1892
1893 2017-12-11  David Quesada  <david_quesada@apple.com>
1894
1895         Turn on ENABLE_APPLICATION_MANIFEST
1896         https://bugs.webkit.org/show_bug.cgi?id=180562
1897         rdar://problem/35924737
1898
1899         Reviewed by Geoffrey Garen.
1900
1901         * Configurations/FeatureDefines.xcconfig:
1902
1903 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1904
1905         Remove pthread_once in favor of dispatch_once
1906         https://bugs.webkit.org/show_bug.cgi?id=180591
1907
1908         Reviewed by Saam Barati.
1909
1910         * Misc/WebKitErrors.m:
1911         (+[NSError _registerWebKitErrors]):
1912         (registerErrors): Deleted.
1913         * Storage/WebStorageManager.mm:
1914         (+[WebStorageManager _storageDirectoryPath]):
1915         (initializeLocalStoragePath): Deleted.
1916
1917 2017-12-07  Darin Adler  <darin@apple.com>
1918
1919         Remove some unused code from WebKitLegacy
1920         https://bugs.webkit.org/show_bug.cgi?id=180567
1921
1922         Reviewed by Anders Carlsson.
1923
1924         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1925         macOS (back a few versions) and iOS and removed unused
1926         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1927         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1928         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1929         _webkit_stringByCollapsingNonPrintingCharacters,
1930         _webkit_stringByCollapsingWhitespaceCharacters,
1931         _web_stringWithData:textEncodingName:, and
1932         _webkit_localStorageDirectoryWithBundleIdentifier:.
1933
1934         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1935         this source file.
1936         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1937         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1938         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1939         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1940         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1941         handle font smoothing options.
1942         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1943         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1944         from header and made it a little clearer.
1945         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1946         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1947         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1948         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1949         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1950         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1951         implementation a bit and used whole words instead of abbreviations.
1952         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1953
1954         * Misc/WebNSFileManagerExtras.mm:
1955         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1956         filenameByFixingIllegalCharacters function from WebCore directly instead of
1957         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1958
1959         * Plugins/WebBaseNetscapePluginView.mm:
1960         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1961         string replacements instead of _web_stringByStrippingReturnCharacters
1962         and to use NSString methods instead of CFString functions.
1963
1964 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1965
1966         Ignore deprecation warnings.
1967
1968         * WebView/WebHTMLView.mm:
1969         (-[NSWindow _web_borderView]):
1970         (-[WebHTMLView _setAsideSubviews]):
1971         * WebView/WebView.mm:
1972         (-[WebView encodeWithCoder:]):
1973
1974 2017-12-02  Darin Adler  <darin@apple.com>
1975
1976         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1977         https://bugs.webkit.org/show_bug.cgi?id=180009
1978
1979         Reviewed by Alex Christensen.
1980
1981         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1982
1983         * Plugins/WebBaseNetscapePluginView.mm:
1984         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1985         of strcasecmp.
1986
1987         * WebView/WebPreferences.mm:
1988         (contains): Ditto. Also made this a template so it's easier to call on an array.
1989         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1990
1991 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1992
1993         Limit user agent versioning to an upper bound
1994         https://bugs.webkit.org/show_bug.cgi?id=180365
1995         <rdar://problem/34550617>
1996
1997         Reviewed by Joseph Pecoraro.
1998
1999         * WebView/WebView.mm:
2000         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
2001         creating the User Agent string.
2002         (webKitBundleVersionString): Deleted.
2003
2004 2017-12-05  Andy Estes  <aestes@apple.com>
2005
2006         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
2007         https://bugs.webkit.org/show_bug.cgi?id=180457
2008         <rdar://problem/35143007>
2009
2010         Reviewed by Tim Horton.
2011
2012         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2013         check for this macro during post-processing.
2014
2015         * postprocess-headers.sh:
2016
2017 2017-12-04  David Quesada  <david_quesada@apple.com>
2018
2019         Add a class for parsing application manifests
2020         https://bugs.webkit.org/show_bug.cgi?id=177973
2021         rdar://problem/34747949
2022
2023         Reviewed by Geoffrey Garen.
2024
2025         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2026
2027 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2028
2029         Make LegacyCustomProtocolManager optional for network process
2030         https://bugs.webkit.org/show_bug.cgi?id=176230
2031
2032         Reviewed by Alex Christensen.
2033
2034         * Configurations/FeatureDefines.xcconfig:
2035
2036 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2037
2038         Fix some NSOperationQueue leaks
2039         https://bugs.webkit.org/show_bug.cgi?id=180221
2040
2041         Reviewed by Wenson Hsieh.
2042
2043         * WebView/WebView.mm:
2044         (-[WebView performDragOperation:]):
2045
2046 2017-11-30  Darin Adler  <darin@apple.com>
2047
2048         [Mac] remove unneeded RetainPtr use introduced in r225142
2049         https://bugs.webkit.org/show_bug.cgi?id=180202
2050
2051         Reviewed by Tim Horton.
2052
2053         * WebView/WebImmediateActionController.mm:
2054         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2055         RetainPtr.
2056
2057 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2058
2059         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2060         https://bugs.webkit.org/show_bug.cgi?id=175595
2061
2062         Reviewed by Darin Adler.
2063
2064         * WebView/WebPreferences.mm:
2065
2066 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2067
2068         One too many zeroes in macOS version number in FeatureDefines
2069         https://bugs.webkit.org/show_bug.cgi?id=180011
2070
2071         Reviewed by Dan Bernstein.
2072
2073         * Configurations/FeatureDefines.xcconfig:
2074
2075 2017-11-23  Darin Adler  <darin@apple.com>
2076
2077         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2078         https://bugs.webkit.org/show_bug.cgi?id=179981
2079
2080         Reviewed by Sam Weinig.
2081
2082         * WebView/WebImmediateActionController.mm:
2083         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2084         * WebView/WebView.mm:
2085         (coreOptions): Use |= instead of | to build up FindOptions.
2086
2087 2017-11-23  Sam Weinig  <sam@webkit.org>
2088
2089         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2090         https://bugs.webkit.org/show_bug.cgi?id=179954
2091
2092         Reviewed by Darin Adler.
2093
2094         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2095         with direct calls to the corresponding UserGestureIndicator functions.
2096
2097         * Plugins/WebPluginController.mm:
2098         (-[WebPluginController processingUserGesture]):
2099         * WebView/WebView.mm:
2100         (-[WebView _isProcessingUserGesture]):
2101
2102 2017-11-23  Darin Adler  <darin@apple.com>
2103
2104         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2105         https://bugs.webkit.org/show_bug.cgi?id=179907
2106
2107         Reviewed by Sam Weinig.
2108
2109         * History/BinaryPropertyList.cpp:
2110         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2111         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2112         * WebView/WebHTMLRepresentation.mm:
2113         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2114         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2115
2116 2017-11-22  Ali Juma  <ajuma@chromium.org>
2117
2118         Implement VisualViewport API attributes
2119         https://bugs.webkit.org/show_bug.cgi?id=179385
2120
2121         Reviewed by Frédéric Wang.
2122
2123         Add a VisualViewportAPI preference.
2124
2125         * WebView/WebPreferenceKeysPrivate.h:
2126         * WebView/WebPreferences.mm:
2127         (+[WebPreferences initialize]):
2128         (-[WebPreferences visualViewportAPIEnabled]):
2129         (-[WebPreferences setVisualViewportAPIEnabled:]):
2130         * WebView/WebPreferencesPrivate.h:
2131         * WebView/WebView.mm:
2132         (-[WebView _preferencesChanged:]):
2133
2134 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2135
2136         WebCoreObjCExtras.h is being included in too many places
2137         https://bugs.webkit.org/show_bug.cgi?id=179931
2138
2139         Reviewed by Darin Adler.
2140
2141         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2142         * Plugins/WebBaseNetscapePluginView.mm:
2143         * Plugins/WebBasePluginPackage.mm:
2144         * Plugins/WebNetscapePluginStream.mm:
2145         * Plugins/WebNetscapePluginView.mm:
2146         * WebView/WebTextIterator.mm:
2147         * WebView/WebViewData.mm:
2148
2149 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2150
2151         Unreviewed, rolling out r225093.
2152         https://bugs.webkit.org/show_bug.cgi?id=179938
2153
2154         Compilation failed on WinCairo 64-bit Release (Requested by
2155         fredw on #webkit).
2156
2157         Reverted changeset:
2158
2159         "Implement VisualViewport API attributes"
2160         https://bugs.webkit.org/show_bug.cgi?id=179385
2161         https://trac.webkit.org/changeset/225093
2162
2163 2017-11-21  Ali Juma  <ajuma@chromium.org>
2164
2165         Implement VisualViewport API attributes
2166         https://bugs.webkit.org/show_bug.cgi?id=179385
2167
2168         Reviewed by Frédéric Wang.
2169
2170         Add a VisualViewportAPI preference.
2171
2172         * WebView/WebPreferenceKeysPrivate.h:
2173         * WebView/WebPreferences.mm:
2174         (+[WebPreferences initialize]):
2175         (-[WebPreferences visualViewportAPIEnabled]):
2176         (-[WebPreferences setVisualViewportAPIEnabled:]):
2177         * WebView/WebPreferencesPrivate.h:
2178         * WebView/WebView.mm:
2179         (-[WebView _preferencesChanged:]):
2180
2181 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2182
2183         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2184         https://bugs.webkit.org/show_bug.cgi?id=179504
2185
2186         Reviewed by Darin Adler.
2187
2188         * Misc/WebKitNSStringExtras.mm:
2189         * Plugins/Hosted/NetscapePluginHostManager.mm:
2190         * Plugins/WebBasePluginPackage.mm:
2191
2192 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2193
2194         Remove unused TOUCH_ICON_LOADING feature flag
2195         https://bugs.webkit.org/show_bug.cgi?id=179873
2196
2197         Reviewed by Simon Fraser.
2198
2199         * Configurations/FeatureDefines.xcconfig:
2200
2201 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2202
2203         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2204         https://bugs.webkit.org/show_bug.cgi?id=179872
2205
2206         Reviewed by Darin Adler.
2207
2208         * Configurations/FeatureDefines.xcconfig:
2209
2210 2017-11-16  Daniel Bates  <dabates@apple.com>
2211
2212         Add feature define for alternative presentation button element
2213         https://bugs.webkit.org/show_bug.cgi?id=179692
2214         Part of <rdar://problem/34917108>
2215
2216         Reviewed by Andy Estes.
2217
2218         Only enabled on Cocoa platforms by default.
2219
2220         * Configurations/FeatureDefines.xcconfig:
2221
2222 2017-11-14  Nan Wang  <n_wang@apple.com>
2223
2224         AX: AOM: Implement AccessibleNode class and support label and role attributes
2225         https://bugs.webkit.org/show_bug.cgi?id=179494
2226
2227         Reviewed by Ryosuke Niwa.
2228
2229         * WebView/WebPreferenceKeysPrivate.h:
2230         * WebView/WebPreferences.mm:
2231         (+[WebPreferences initialize]):
2232         (-[WebPreferences accessibilityObjectModelEnabled]):
2233         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2234         * WebView/WebPreferencesPrivate.h:
2235         * WebView/WebView.mm:
2236         (-[WebView _preferencesChanged:]):
2237
2238 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2239
2240         Remove Cocoa CFURLConnection loading code
2241         https://bugs.webkit.org/show_bug.cgi?id=179688
2242
2243         Reviewed by Antti Koivisto.
2244
2245         * Misc/WebDownload.mm:
2246         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2247         * Misc/WebDownloadInternal.h:
2248         * Plugins/WebBaseNetscapePluginView.mm:
2249         * WebCoreSupport/WebFrameLoaderClient.mm:
2250         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2251         * WebView/WebView.mm:
2252         (-[WebView scheduleInRunLoop:forMode:]):
2253         (-[WebView unscheduleFromRunLoop:forMode:]):
2254
2255 2017-11-14  Daniel Bates  <dabates@apple.com>
2256
2257         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2258         for feature defines
2259
2260         Following r195498 and r201917 the Visual Studio property files for feature defines have
2261         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2262         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2263         files.
2264
2265         * Configurations/FeatureDefines.xcconfig:
2266
2267 2017-11-14  Jer Noble  <jer.noble@apple.com>
2268
2269         Enable Modern EME tests in DumpRenderTree
2270         https://bugs.webkit.org/show_bug.cgi?id=179544
2271
2272         Reviewed by Alex Christensen.
2273
2274         Add a WebPreferences property to enable the (modern) EME API.
2275
2276         * WebView/WebPreferenceKeysPrivate.h:
2277         * WebView/WebPreferences.mm:
2278         (+[WebPreferences initialize]):
2279         (-[WebPreferences encryptedMediaAPIEnabled]):
2280         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2281         * WebView/WebPreferencesPrivate.h:
2282         * WebView/WebView.mm:
2283         (-[WebView _preferencesChanged:]):
2284
2285 2017-11-14  Antti Koivisto  <antti@apple.com>
2286
2287         Enable display:contents by default
2288         https://bugs.webkit.org/show_bug.cgi?id=179655
2289
2290         Reviewed by Sam Weinig.
2291
2292         * WebView/WebPreferences.mm:
2293         (+[WebPreferences initialize]):
2294
2295 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2296
2297         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2298         https://bugs.webkit.org/show_bug.cgi?id=178751
2299
2300         Reviewed by Brady Eidson.
2301
2302         * WebCoreSupport/WebFrameNetworkingContext.mm:
2303         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2304
2305 2017-11-08  Keith Miller  <keith_miller@apple.com>
2306
2307         Async iteration should only fetch the next method once and add feature flag
2308         https://bugs.webkit.org/show_bug.cgi?id=179451
2309
2310         Reviewed by Geoffrey Garen.
2311
2312         Add feature flag for Async iteration.
2313
2314         * Configurations/FeatureDefines.xcconfig:
2315
2316 2017-11-13  Mark Lam  <mark.lam@apple.com>
2317
2318         Add more overflow check book-keeping for MarkedArgumentBuffer.
2319         https://bugs.webkit.org/show_bug.cgi?id=179634
2320         <rdar://problem/35492517>
2321
2322         Reviewed by Saam Barati.
2323
2324         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2325         (WebKit::NetscapePluginInstanceProxy::invoke):
2326         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2327         (WebKit::NetscapePluginInstanceProxy::construct):
2328
2329 2017-11-12  Darin Adler  <darin@apple.com>
2330
2331         More is<> and downcast<>, less static_cast<>
2332         https://bugs.webkit.org/show_bug.cgi?id=179600
2333
2334         Reviewed by Chris Dumez.
2335
2336         * DOM/DOM.mm:
2337         (kit): Use is/downcast.
2338         * WebCoreSupport/WebEditorClient.mm:
2339         (WebEditorClient::handleKeyboardEvent): Ditto.
2340         (WebEditorClient::handleInputMethodKeydown): Ditto.
2341         * WebView/WebHTMLView.mm:
2342         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2343
2344 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2345
2346         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2347         https://bugs.webkit.org/show_bug.cgi?id=179397
2348
2349         Reviewed by Wenson Hsieh.
2350
2351         * DOM/DOMHTMLInputElement.mm:
2352         (-[DOMHTMLInputElement insertTextSuggestion:]):
2353
2354 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2355
2356         HTMLMediaElement should not use element fullscreen on iOS
2357         https://bugs.webkit.org/show_bug.cgi?id=179418
2358         rdar://problem/35409277
2359
2360         Reviewed by Eric Carlson.
2361
2362         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2363
2364         * Configurations/FeatureDefines.xcconfig:
2365
2366 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2367
2368         Make ResourceLoader::willSendRequestInternal asynchronous
2369         https://bugs.webkit.org/show_bug.cgi?id=179251
2370
2371         Reviewed by Andy Estes.
2372
2373         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2374         (WebKit::HostedNetscapePluginStream::start):
2375         * Plugins/WebNetscapePluginStream.mm:
2376         (WebNetscapePluginStream::start):
2377
2378 2017-11-01  Darin Adler  <darin@apple.com>
2379
2380         Simplify event dispatch code and make it a bit more consistent
2381         https://bugs.webkit.org/show_bug.cgi?id=178991
2382
2383         Reviewed by Chris Dumez.
2384
2385         * DOM/DOMEvent.mm:
2386         (-[DOMEvent srcElement]): Call target instead of srcElement.
2387
2388 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2389
2390         [Touch Bar Web API] Add support for menuitem tag
2391         https://bugs.webkit.org/show_bug.cgi?id=179020
2392
2393         Reviewed by Ryosuke Niwa.
2394
2395         Adds in properties and methods that allow the menuitem runtime feature
2396         to be enabled or disabled.
2397
2398         * WebView/WebPreferenceKeysPrivate.h:
2399         * WebView/WebPreferences.mm:
2400         (-[WebPreferences menuItemElementEnabled]):
2401         (-[WebPreferences setMenuItemElementEnabled:]):
2402         * WebView/WebPreferencesPrivate.h:
2403         * WebView/WebView.mm:
2404         (-[WebView _preferencesChanged:]):
2405
2406 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2407
2408         Use CompletionHandlers for redirects
2409         https://bugs.webkit.org/show_bug.cgi?id=179163
2410
2411         Reviewed by Tim Horton.
2412
2413         * Plugins/Hosted/HostedNetscapePluginStream.h:
2414         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2415         (WebKit::HostedNetscapePluginStream::willSendRequest):
2416         * Plugins/WebNetscapePluginStream.h:
2417         * Plugins/WebNetscapePluginStream.mm:
2418         (WebNetscapePluginStream::willSendRequest):
2419
2420 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2421
2422         Add a FileSystem namespace to FileSystem.cpp
2423         https://bugs.webkit.org/show_bug.cgi?id=179063
2424
2425         Reviewed by Darin Adler.
2426
2427         * Misc/WebNSFileManagerExtras.mm:
2428         * Storage/WebDatabaseProvider.mm:
2429
2430 2017-11-02  Frederic Wang  <fwang@igalia.com>
2431
2432         Add references to bug 179167 in FIXME comments
2433         https://bugs.webkit.org/show_bug.cgi?id=179168
2434
2435         Reviewed by Daniel Bates.
2436
2437         * Configurations/FeatureDefines.xcconfig:
2438
2439 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2440
2441         Implement WKFullscreenWindowController for iOS.
2442         https://bugs.webkit.org/show_bug.cgi?id=178924
2443         rdar://problem/34697120
2444
2445         Reviewed by Simon Fraser.
2446
2447         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2448
2449         * Configurations/FeatureDefines.xcconfig:
2450         * WebView/WebView.mm:
2451         (-[WebView fullScreenPlaceholderView]):
2452
2453 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2454
2455         Clean up some drag and drop feature flags
2456         https://bugs.webkit.org/show_bug.cgi?id=179082
2457
2458         Reviewed by Simon Fraser.
2459
2460         * Configurations/FeatureDefines.xcconfig:
2461
2462 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2463
2464         Make it possible to test rubber-banding in overflow scroll
2465         https://bugs.webkit.org/show_bug.cgi?id=179078
2466
2467         Reviewed by Sam Weinig.
2468
2469         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2470         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2471
2472         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2473         functions, since most callers want clamped.
2474
2475         * DOM/DOMHTML.mm:
2476         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2477
2478 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2479
2480         Fix up some content filtering feature flags
2481         https://bugs.webkit.org/show_bug.cgi?id=179079
2482
2483         Reviewed by Simon Fraser.
2484
2485         * Configurations/FeatureDefines.xcconfig:
2486
2487 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2488
2489         [FrameView::layout cleanup] Move core layout logic to a separate class.
2490         https://bugs.webkit.org/show_bug.cgi?id=178771
2491         <rdar://problem/35166542>
2492
2493         Reviewed by Simon Fraser.
2494
2495         Move layout code out from FrameView to LayoutContext.
2496
2497         * WebView/WebClipView.mm:
2498         (-[WebClipView _immediateScrollToPoint:]):
2499         * WebView/WebFrame.mm:
2500         (-[WebFrame layoutCount]):
2501
2502 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2503
2504         Fix issues with WebView subframe painting
2505         https://bugs.webkit.org/show_bug.cgi?id=178842
2506         rdar://problem/34072253
2507
2508         Reviewed by Daniel Bates.
2509         
2510         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2511         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2512         High Sierra, so match the new signature.
2513
2514         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2515
2516         * WebView/WebHTMLView.mm:
2517         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2518         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2519
2520 2017-10-25  Youenn Fablet  <youenn@apple.com>
2521
2522         Enable ServiceWorker to fetch resources
2523         https://bugs.webkit.org/show_bug.cgi?id=178673
2524
2525         Reviewed by Brady Eidson.
2526
2527         * WebCoreSupport/WebFrameLoaderClient.mm:
2528         (WebFrameLoaderClient::pageID const):
2529         (WebFrameLoaderClient::frameID const):
2530         (WebFrameLoaderClient::sessionID const):
2531
2532         Added implementation to the new getters.
2533         They are noop in the context of WK1.
2534
2535 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2536
2537         Web Inspector: Enable WebKit logging configuration and display
2538         https://bugs.webkit.org/show_bug.cgi?id=177027
2539         <rdar://problem/33964767>
2540
2541         Reviewed by Joseph Pecoraro.
2542
2543         * WebCoreSupport/WebChromeClient.mm:
2544         (stringForMessageSource): Deal with Media and WebRTC message sources.
2545
2546 2017-10-20  Antoine Quint  <graouts@apple.com>
2547
2548         [Web Animations] Provide basic timeline and animation interfaces
2549         https://bugs.webkit.org/show_bug.cgi?id=178526
2550
2551         Reviewed by Dean Jackson.
2552
2553         Remove the WEB_ANIMATIONS compile-time flag.
2554
2555         * Configurations/FeatureDefines.xcconfig:
2556         * WebView/WebPreferences.mm:
2557         (+[WebPreferences initialize]):
2558         * WebView/WebView.mm:
2559         (-[WebView _preferencesChanged:]):
2560
2561 2017-10-19  Sam Weinig  <sam@webkit.org>
2562
2563         [Settings] Move global settings into their own file
2564         https://bugs.webkit.org/show_bug.cgi?id=178512
2565
2566         Reviewed by Darin Adler.
2567
2568         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2569
2570         * WebCoreSupport/WebChromeClient.mm:
2571         (WebChromeClient::supportsVideoFullscreen):
2572         * WebView/WebDynamicScrollBarsView.mm:
2573         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2574         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2575         * WebView/WebPreferences.mm:
2576         (+[WebPreferences initialize]):
2577         * WebView/WebView.mm:
2578         (-[WebView _commonInitializationWithFrameName:groupName:]):
2579         (-[WebView _preferencesChanged:]):
2580         (+[WebView _doNotStartObservingNetworkReachability]):
2581
2582 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2583
2584         Replace some stack raw pointers with RefPtrs within WebCore/html
2585         https://bugs.webkit.org/show_bug.cgi?id=178201
2586         <rdar://problem/34841692>
2587
2588         Reviewed by Ryosuke Niwa.
2589
2590         * DOM/DOM.mm:
2591         (kit):
2592         Change the type of node as toNode() is changed to return RefPtr.
2593
2594 2017-10-18  Chris Dumez  <cdumez@apple.com>
2595
2596         [Service Worker] Add stubs for Client / WindowClient / Clients
2597         https://bugs.webkit.org/show_bug.cgi?id=178469
2598
2599         Reviewed by Youenn Fablet.
2600
2601         Rename PageVisiblityState to VisibilityState.
2602
2603         * WebView/WebView.mm:
2604         (kit):
2605
2606 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2607
2608         Unreviewed, rolling out r223291.
2609
2610         See WebCore ChangeLog for more detail.
2611
2612         Reverted changeset:
2613
2614         "Remove Editor::simplifyMarkup"
2615         https://bugs.webkit.org/show_bug.cgi?id=178271
2616         https://trac.webkit.org/changeset/223291
2617
2618 2017-10-17  Keith Miller  <keith_miller@apple.com>
2619
2620         Change WebCore sources to work with unified source builds
2621         https://bugs.webkit.org/show_bug.cgi?id=178229
2622
2623         Rubber stamped by Tim Horton.
2624
2625         * Configurations/FeatureDefines.xcconfig:
2626
2627 2017-10-16  Sam Weinig  <sam@webkit.org>
2628
2629         [Settings] Remove all custom code from Settings.h/cpp
2630         https://bugs.webkit.org/show_bug.cgi?id=178330
2631
2632         Reviewed by Simon Fraser.
2633
2634         * WebView/WebPreferences.mm:
2635         (+[WebPreferences initialize]):
2636         
2637             Update for naming changes of FrameFlattening now that it is an enum class.
2638
2639 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2640
2641         Remove Editor::simplifyMarkup
2642         https://bugs.webkit.org/show_bug.cgi?id=178271
2643
2644         Reviewed by Wenson Hsieh.
2645
2646         * WebView/WebView.mm:
2647         (-[WebView _simplifyMarkup:endNode:]):
2648
2649 2017-10-12  Chris Dumez  <cdumez@apple.com>
2650
2651         [Mac] Add support for MouseEvent.buttons
2652         https://bugs.webkit.org/show_bug.cgi?id=178214
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         * WebView/WebPDFView.mm:
2657         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2658
2659 2017-10-11  Sam Weinig  <sam@webkit.org>
2660
2661         Remove out-parameter variants of copyToVector
2662         https://bugs.webkit.org/show_bug.cgi?id=178155
2663
2664         Reviewed by Tim Horton.
2665
2666         * Plugins/WebNetscapePluginView.mm:
2667         (-[WebNetscapePluginView destroyPlugin]):
2668         * WebView/WebHTMLRepresentation.mm:
2669         (newArrayWithStrings):
2670
2671             Replace out-parameter based copyToVector, with one that returns a Vector.
2672
2673 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2674
2675         Sanitize URL in pasteboard for other applications and cross origin content
2676         https://bugs.webkit.org/show_bug.cgi?id=178060
2677         <rdar://problem/34874518>
2678
2679         Reviewed by Wenson Hsieh.
2680
2681         * WebCoreSupport/WebPlatformStrategies.h:
2682         * WebCoreSupport/WebPlatformStrategies.mm:
2683         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2684
2685 2017-10-11  Chris Dumez  <cdumez@apple.com>
2686
2687         Modernize Geolocation code
2688         https://bugs.webkit.org/show_bug.cgi?id=178148
2689
2690         Reviewed by Ryosuke Niwa.
2691
2692         * WebCoreSupport/WebGeolocationClient.h:
2693         * WebCoreSupport/WebGeolocationClient.mm:
2694         (WebGeolocationClient::lastPosition):
2695         * WebView/WebGeolocationPosition.mm:
2696         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2697         (core):
2698         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2699         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2700         * WebView/WebGeolocationPositionInternal.h:
2701
2702 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2703
2704         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2705         https://bugs.webkit.org/show_bug.cgi?id=178154
2706
2707         Reviewed by Wenson Hsieh.
2708
2709         Enable custom pasteboard data by default.
2710
2711         * WebView/WebPreferenceKeysPrivate.h:
2712         * WebView/WebPreferences.mm:
2713         (+[WebPreferences initialize]):
2714         (-[WebPreferences customPasteboardDataEnabled]): Added.
2715         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2716         * WebView/WebPreferencesPrivate.h:
2717         * WebView/WebView.mm:
2718         (-[WebView _preferencesChanged:]):
2719
2720 2017-10-10  Sam Weinig  <sam@webkit.org>
2721
2722         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2723         https://bugs.webkit.org/show_bug.cgi?id=178102
2724
2725         Reviewed by Tim Horton.
2726
2727         * History/WebHistory.mm:
2728         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2729         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2730         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2731         * WebCoreSupport/WebUserMediaClient.mm:
2732         (WebUserMediaClient::pageDestroyed):
2733
2734 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2735
2736         Make the names of the options consistent
2737         https://bugs.webkit.org/show_bug.cgi?id=177933
2738
2739         Reviewed by Saam Barati.
2740
2741         * WebView/WebFrame.h:
2742         * WebView/WebHTMLView.mm:
2743         (-[WebHTMLView setMarkedText:selectedRange:]):
2744         * WebView/WebView.h:
2745
2746 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2747
2748         [iOS] Tweak support for classifying form controls (followup to r222487)
2749         https://bugs.webkit.org/show_bug.cgi?id=177917
2750         <rdar://problem/34820122>
2751
2752         Reviewed by Dean Jackson.
2753
2754         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2755
2756         * DOM/DOMHTMLInputElement.mm:
2757         (-[DOMHTMLInputElement _autofillContext]):
2758         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2759         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2760
2761 2017-10-05  Keith Miller  <keith_miller@apple.com>
2762
2763         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2764
2765         * Configurations/WebKitLegacy.xcconfig:
2766
2767 2017-10-05  Jer Noble  <jer.noble@apple.com>
2768
2769         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2770         https://bugs.webkit.org/show_bug.cgi?id=177261
2771
2772         Reviewed by Eric Carlson.
2773
2774         * Configurations/FeatureDefines.xcconfig:
2775
2776 2017-10-05  Chris Dumez  <cdumez@apple.com>
2777
2778         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2779         https://bugs.webkit.org/show_bug.cgi?id=177957
2780
2781         Reviewed by Alex Christensen.
2782
2783         * WebCoreSupport/WebPlatformStrategies.h:
2784         * WebCoreSupport/WebPlatformStrategies.mm:
2785         (WebPlatformStrategies::cookiesEnabled):
2786
2787 2017-10-05  Youenn Fablet  <youenn@apple.com>
2788
2789         Make LibWebRTCProvider port agnostic
2790         https://bugs.webkit.org/show_bug.cgi?id=177747
2791
2792         Reviewed by Alex Christensen & Alex Garcia.
2793
2794         * WebView/WebView.mm:
2795         (-[WebView _commonInitializationWithFrameName:groupName:]):
2796         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2797
2798 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2799
2800         Stop linking with WebKitSystemInterface
2801         https://bugs.webkit.org/show_bug.cgi?id=177915
2802
2803         Reviewed by Antti Koivisto.
2804
2805         * Configurations/DebugRelease.xcconfig:
2806         * Configurations/WebKitLegacy.xcconfig:
2807
2808 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2809
2810         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2811         https://bugs.webkit.org/show_bug.cgi?id=177912
2812
2813         Reviewed by Saam Barati.
2814
2815         * Carbon/CarbonUtils.m:
2816         * Carbon/CarbonWindowAdapter.mm:
2817         * Carbon/HIWebView.mm:
2818         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2819         * Misc/WebNSFileManagerExtras.mm:
2820         * Misc/WebNSPasteboardExtras.mm:
2821         * Misc/WebNSURLExtras.mm:
2822         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2823         * Plugins/Hosted/NetscapePluginHostManager.mm:
2824         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2825         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2826         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2827         * Plugins/Hosted/WebTextInputWindowController.m:
2828         * Plugins/WebBaseNetscapePluginView.mm:
2829         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2830         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2831         * Plugins/WebNetscapePluginStream.mm:
2832         * Plugins/WebNetscapePluginView.mm:
2833         * Plugins/WebPluginDatabase.mm:
2834         * WebCoreSupport/PopupMenuMac.mm:
2835         * WebCoreSupport/WebChromeClient.mm:
2836         * WebCoreSupport/WebFrameLoaderClient.mm:
2837         * WebCoreSupport/WebInspectorClient.mm:
2838         * WebCoreSupport/WebPlatformStrategies.mm:
2839         * WebCoreSupport/WebSystemInterface.mm:
2840         * WebView/WebDynamicScrollBarsView.mm:
2841         * WebView/WebFrame.mm:
2842         * WebView/WebFrameView.mm:
2843         * WebView/WebFullScreenController.mm:
2844         * WebView/WebHTMLView.mm:
2845         * WebView/WebPreferences.mm:
2846         * WebView/WebView.mm:
2847
2848 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2849
2850         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2851         rdar://problem/34705779
2852
2853         Addressing review comments that I somehow landed without.
2854
2855         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2856
2857 2017-09-29  Chris Dumez  <cdumez@apple.com>
2858
2859         Split some logic out of VisitedLinkStore and make it reusable
2860         https://bugs.webkit.org/show_bug.cgi?id=177575
2861
2862         Reviewed by Alex Christensen.
2863
2864         * WebCoreSupport/WebVisitedLinkStore.h:
2865         * WebCoreSupport/WebVisitedLinkStore.mm:
2866         (WebVisitedLinkStore::addVisitedLink):
2867         (WebVisitedLinkStore::removeVisitedLink):
2868         (WebVisitedLinkStore::isLinkVisited):
2869         (WebVisitedLinkStore::addVisitedLinkHash):
2870
2871 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2872
2873         Build fix for High Sierra 32 bit Mac
2874         https://bugs.webkit.org/show_bug.cgi?id=177551
2875         <rdar://problem/34690283>
2876
2877         Reviewed by Alexey Proskuryakov.
2878
2879         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2880         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2881         also made.
2882
2883         * Carbon/CarbonWindowAdapter.mm:
2884         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2885         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2886         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2887         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2888         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2889         (-[CarbonWindowAdapter dealloc]):
2890         (-[CarbonWindowAdapter windowRef]):
2891         (-[CarbonWindowAdapter _hasWindowRef]):
2892         (-[CarbonWindowAdapter _managesWindowRef]):
2893         (-[CarbonWindowAdapter _removeWindowRef]):
2894         (-[CarbonWindowAdapter _carbonWindowClass]):
2895         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2896         (-[CarbonWindowAdapter sendSuperEvent:]):
2897         (-[CarbonWindowAdapter relinquishFocus]):
2898         (-[CarbonWindowAdapter _cancelKey:]):
2899         (-[CarbonWindowAdapter _commonAwake]):
2900         (-[CarbonWindowAdapter _destroyRealWindow:]):
2901         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2902         (-[CarbonWindowAdapter _termWindowIfOwner]):
2903         (-[CarbonWindowAdapter _windowMovedToRect:]):
2904         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2905         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2906         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2907         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2908         (-[CarbonWindowAdapter canBecomeMainWindow]):
2909         (-[CarbonWindowAdapter encodeWithCoder:]):
2910         (-[CarbonWindowAdapter initWithCoder:]):
2911         (-[CarbonWindowAdapter setContentView:]):
2912         (-[CarbonWindowAdapter worksWhenModal]):
2913         (-[CarbonWindowAdapter _setModalWindowLevel]):
2914         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2915         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2916         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2917         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2918         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2919         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2920         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2921         (NSCarbonWindowHandleEvent):
2922         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2923         (-[CarbonWindowAdapter _growBoxRect]):
2924         * Carbon/HIWebView.mm:
2925         (HIWebViewGetWebView):
2926         (HIWebViewConstructor):
2927         (HIWebViewDestructor):
2928         (HIWebViewRegisterClass):
2929         (GetBehaviors):
2930         (Draw):
2931         (HitTest):
2932         (GetRegion):
2933         (GetWindowRef):
2934         (CreateNSEventAdoptingCGEvent):
2935         (CopyEventCGEvent):
2936         (CreateNSEventWithCarbonClickEvent):
2937         (Click):
2938         (CreateNSEventWithCarbonEvent):
2939         (MouseUp):
2940         (CreateNSEventWithCarbonMouseMoveEvent):
2941         (MouseMoved):
2942         (MouseDragged):
2943         (MouseWheelMoved):
2944         (ContextMenuClick):
2945         (GetKind):
2946         (BoundsChanged):
2947         (OwningWindowChanged):
2948         (WindowHandler):
2949         (SyncFrame):
2950         (SetFocusPart):
2951         (AdvanceFocus):
2952         (RelinquishFocus):
2953         (ActiveStateChanged):
2954         (ProcessCommand):
2955         (UpdateCommandStatus):
2956         (_NSSelectorForHICommand):
2957         (HIWebViewEventHandler):
2958         (StartUpdateObserver):
2959         (StopUpdateObserver):
2960         (UpdateObserver):
2961
2962 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2963
2964         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2965         https://bugs.webkit.org/show_bug.cgi?id=172526
2966         <rdar://problem/32396081>
2967
2968         Reviewed by Ryosuke Niwa.
2969
2970         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2971
2972         * WebCoreSupport/WebPlatformStrategies.h:
2973         * WebCoreSupport/WebPlatformStrategies.mm:
2974         (WebPlatformStrategies::webExposedTypes):
2975         (WebPlatformStrategies::writeCustomData):
2976
2977 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2978
2979         Unreviewed, rolling out r222567.
2980
2981         This broke and internal build.
2982
2983         Reverted changeset:
2984
2985         "Build fix for High Sierra 32 bit Mac"
2986         https://bugs.webkit.org/show_bug.cgi?id=177551
2987         http://trac.webkit.org/changeset/222567
2988
2989 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2990
2991         Build fix for High Sierra 32 bit Mac
2992         https://bugs.webkit.org/show_bug.cgi?id=177551
2993         <rdar://problem/34690283>
2994
2995         Reviewed by Alexey Proskuryakov.
2996
2997         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2998         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2999         also made.
3000
3001         * Carbon/CarbonWindowAdapter.mm:
3002         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3003         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3004         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3005         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3006         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3007         (-[CarbonWindowAdapter dealloc]):
3008         (-[CarbonWindowAdapter windowRef]):
3009         (-[CarbonWindowAdapter _hasWindowRef]):
3010         (-[CarbonWindowAdapter _managesWindowRef]):
3011         (-[CarbonWindowAdapter _removeWindowRef]):
3012         (-[CarbonWindowAdapter _carbonWindowClass]):
3013         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3014         (-[CarbonWindowAdapter sendSuperEvent:]):
3015         (-[CarbonWindowAdapter relinquishFocus]):
3016         (-[CarbonWindowAdapter _cancelKey:]):
3017         (-[CarbonWindowAdapter _commonAwake]):
3018         (-[CarbonWindowAdapter _destroyRealWindow:]):
3019         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3020         (-[CarbonWindowAdapter _termWindowIfOwner]):
3021         (-[CarbonWindowAdapter _windowMovedToRect:]):
3022         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3023         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3024         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3025         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3026         (-[CarbonWindowAdapter canBecomeMainWindow]):
3027         (-[CarbonWindowAdapter encodeWithCoder:]):
3028         (-[CarbonWindowAdapter initWithCoder:]):
3029         (-[CarbonWindowAdapter setContentView:]):
3030         (-[CarbonWindowAdapter worksWhenModal]):
3031         (-[CarbonWindowAdapter _setModalWindowLevel]):
3032         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3033         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3034         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3035         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3036         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3037         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3038         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3039         (NSCarbonWindowHandleEvent):
3040         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3041         (-[CarbonWindowAdapter _growBoxRect]):
3042         * Carbon/HIWebView.mm:
3043         (HIWebViewGetWebView):
3044         (HIWebViewConstructor):
3045         (HIWebViewDestructor):
3046         (HIWebViewRegisterClass):
3047         (GetBehaviors):
3048         (Draw):
3049         (HitTest):
3050         (GetRegion):
3051         (GetWindowRef):
3052         (CreateNSEventAdoptingCGEvent):
3053         (CopyEventCGEvent):
3054         (CreateNSEventWithCarbonClickEvent):
3055         (Click):
3056         (CreateNSEventWithCarbonEvent):
3057         (MouseUp):
3058         (CreateNSEventWithCarbonMouseMoveEvent):
3059         (MouseMoved):
3060         (MouseDragged):
3061         (MouseWheelMoved):
3062         (ContextMenuClick):
3063         (GetKind):
3064         (BoundsChanged):
3065         (OwningWindowChanged):
3066         (WindowHandler):
3067         (SyncFrame):
3068         (SetFocusPart):
3069         (AdvanceFocus):
3070         (RelinquishFocus):
3071         (ActiveStateChanged):
3072         (ProcessCommand):
3073         (UpdateCommandStatus):
3074         (_NSSelectorForHICommand):
3075         (HIWebViewEventHandler):
3076         (StartUpdateObserver):
3077         (StopUpdateObserver):
3078         (UpdateObserver):
3079
3080 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3081
3082         Make PolicyAction an encodable enum class
3083         https://bugs.webkit.org/show_bug.cgi?id=177480
3084
3085         Reviewed by Antti Koivisto.
3086
3087         * Plugins/WebPluginContainerCheck.mm:
3088         (-[WebPluginContainerCheck _continueWithPolicy:]):
3089         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3090         * WebCoreSupport/WebFrameLoaderClient.mm:
3091         (-[WebFramePolicyListener invalidate]):
3092         (-[WebFramePolicyListener ignore]):
3093         (-[WebFramePolicyListener download]):
3094         (-[WebFramePolicyListener use]):
3095         (-[WebFramePolicyListener continue]):
3096         * WebView/WebPolicyDelegate.mm:
3097         (-[WebPolicyDecisionListener use]):
3098         (-[WebPolicyDecisionListener ignore]):
3099         (-[WebPolicyDecisionListener download]):
3100
3101 2017-09-25  Frederik Riedel  <riedel@apple.com>
3102
3103         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3104         https://bugs.webkit.org/show_bug.cgi?id=174394
3105         <rdar://problem/33183504>
3106
3107         Reviewed by Ryosuke Niwa.
3108
3109         * DOM/DOMHTMLInputElement.h:
3110         * DOM/DOMHTMLInputElement.mm:
3111         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3112         Determines if this HTMLInputElement is part of a login screen.
3113         (-[DOMHTMLInputElement representingPageUrl]):
3114         Returns the webpage's URL that is currently displayed in the Web View.
3115         (-[DOMHTMLInputElement insertTextSuggestion:]):
3116         Inserts login credentials into the Web View.
3117
3118 2017-09-25  Sam Weinig  <sam@webkit.org>
3119
3120         Remove unused EditorClient functions
3121         https://bugs.webkit.org/show_bug.cgi?id=177463
3122
3123         Reviewed by Alex Christensen.
3124
3125         Remove unused EditorClient functions.
3126
3127         * WebCoreSupport/WebEditorClient.h:
3128         * WebCoreSupport/WebEditorClient.mm:
3129         (WebEditorClient::canonicalizeURL): Deleted.
3130         (WebEditorClient::canonicalizeURLString): Deleted.
3131         (WebEditorClient::writeDataToPasteboard): Deleted.
3132         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3133         (WebEditorClient::readDataFromPasteboard): Deleted.
3134         (WebEditorClient::pasteboardChangeCount): Deleted.
3135
3136 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3137
3138         Stop using PolicyCallback
3139         https://bugs.webkit.org/show_bug.cgi?id=176088
3140
3141         Reviewed by Andy Estes.
3142
3143         * WebCoreSupport/WebFrameLoaderClient.mm:
3144         (-[WebFramePolicyListener invalidate]):
3145         (-[WebFramePolicyListener receivedPolicyDecision:]):
3146
3147 2017-09-25  Sam Weinig  <sam@webkit.org>
3148
3149         Remove unnecessary userVisibleString EditorClient function
3150         https://bugs.webkit.org/show_bug.cgi?id=177456
3151
3152         Reviewed by Dan Bernstein.
3153
3154         * WebCoreSupport/WebEditorClient.h:
3155         * WebCoreSupport/WebEditorClient.mm:
3156         (WebEditorClient::userVisibleString): Deleted.
3157
3158             Remove userVisibleString client function.
3159
3160 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3161
3162         Separate form submission from PolicyChecker infrastructure
3163         https://bugs.webkit.org/show_bug.cgi?id=177396
3164
3165         Reviewed by Geoffrey Garen.
3166
3167         * WebCoreSupport/WebFrameLoaderClient.h:
3168         * WebCoreSupport/WebFrameLoaderClient.mm:
3169         (WebFrameLoaderClient::dispatchWillSubmitForm):
3170
3171 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3172
3173         WeakPtrFactory should populate m_ref lazily.
3174         https://bugs.webkit.org/show_bug.cgi?id=177375
3175
3176         Reviewed by Geoffrey Garen.
3177
3178         * WebCoreSupport/WebEditorClient.mm:
3179         (WebEditorClient::WebEditorClient):
3180         (WebEditorClient::requestCandidatesForSelection):
3181
3182 2017-09-22  Chris Dumez  <cdumez@apple.com>
3183
3184         Use high resolution timestamp for event time
3185         https://bugs.webkit.org/show_bug.cgi?id=154246
3186         <rdar://problem/34333304>
3187
3188         Reviewed by Ryosuke Niwa.
3189
3190         Use WallTime / MonotonicTime instead of double type for clarity.
3191
3192         * DOM/DOMEvent.mm:
3193         (-[DOMEvent timeStamp]):
3194         * WebView/WebFrame.mm:
3195         (-[WebFrame _dragSourceEndedAt:operation:]):
3196         * WebView/WebPDFView.mm:
3197         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3198
3199 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3200
3201         Enable dataTransfer.items on macOS and iOS
3202         https://bugs.webkit.org/show_bug.cgi?id=177335
3203
3204         Reviewed by Sam Weinig.
3205
3206         * WebView/WebPreferences.mm:
3207         (+[WebPreferences initialize]):
3208
3209 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3210
3211         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3212         https://bugs.webkit.org/show_bug.cgi?id=177101
3213         <rdar://problem/34500648>
3214
3215         Reviewed by Brian Burg.
3216
3217         * WebInspector/WebNodeHighlight.mm:
3218         Ensure we close the window that we have just removed.
3219
3220 2017-09-20  Antti Koivisto  <antti@apple.com>
3221
3222         Remove DOM and styling support for CSS Regions
3223         https://bugs.webkit.org/show_bug.cgi?id=177221
3224
3225         Reviewed by Andreas Kling.
3226
3227         * Configurations/FeatureDefines.xcconfig:
3228         * DOM/DOMCSS.mm:
3229         (kitClass):
3230         * DOM/DOMElement.mm:
3231         (-[DOMElement webkitRegionOverset]): Deleted.
3232
3233 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3234
3235         Layering violation in Editor::createFragment
3236         https://bugs.webkit.org/show_bug.cgi?id=176123
3237
3238         Reviewed by Darin Adler.
3239
3240         * Misc/WebNSURLExtras.h:
3241         * Misc/WebNSURLExtras.mm:
3242         * WebView/WebFrame.mm:
3243         * WebView/WebHTMLView.mm:
3244         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3245
3246         * WebCoreSupport/WebEditorClient.mm:
3247         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3248         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3249         way to avoid exporting the symbol just on newer OSes.
3250
3251 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3252
3253         On iOS, getData can't get text set by setData during copy event
3254         https://bugs.webkit.org/show_bug.cgi?id=176980
3255         <rdar://problem/34453915>
3256
3257         Reviewed by Darin Adler.
3258
3259         * WebCoreSupport/WebPlatformStrategies.h:
3260         * WebCoreSupport/WebPlatformStrategies.mm:
3261         (WebPlatformStrategies::copy): Deleted.
3262
3263 2017-09-18  Andy Estes  <aestes@apple.com>
3264
3265         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3266         https://bugs.webkit.org/show_bug.cgi?id=177029
3267
3268         Reviewed by Alex Christensen.
3269
3270         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3271         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3272         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3273         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3274         * WebCoreSupport/PopupMenuMac.mm:
3275         (PopupMenuMac::show):
3276         * WebCoreSupport/WebSystemInterface.mm:
3277         (InitWebCoreSystemInterface):
3278         * WebView/WebHTMLView.mm:
3279         (-[WebHTMLView setDataSource:]):
3280         (-[WebHTMLView attachRootLayer:]):
3281         * WebView/WebView.mm:
3282         (-[WebView _needsAdobeFrameReloadingQuirk]):
3283         (-[WebView _needsLinkElementTextCSSQuirk]):
3284         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3285         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3286         (-[WebView _preferencesChanged:]):
3287
3288 2017-09-15  Andy Estes  <aestes@apple.com>
3289
3290         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3291         https://bugs.webkit.org/show_bug.cgi?id=176953
3292
3293         Reviewed by Eric Carlson.
3294
3295         * WebCoreSupport/WebSystemInterface.mm:
3296         (InitWebCoreSystemInterface):
3297
3298 2017-09-14  Andy Estes  <aestes@apple.com>
3299
3300         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3301         https://bugs.webkit.org/show_bug.cgi?id=176931
3302
3303         Reviewed by Joseph Pecoraro.
3304
3305         * WebCoreSupport/WebSystemInterface.mm:
3306         (InitWebCoreSystemInterface):
3307
3308 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3309
3310         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3311         https://bugs.webkit.org/show_bug.cgi?id=176867
3312
3313         Reviewed by Sam Weinig.
3314
3315         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3316         (WebKit::NetscapePluginInstanceProxy::enumerate):
3317
3318 2017-09-13  Andy Estes  <aestes@apple.com>
3319
3320         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3321         https://bugs.webkit.org/show_bug.cgi?id=176729
3322
3323         Reviewed by Alex Christensen.
3324
3325         * WebCoreSupport/WebSystemInterface.mm:
3326         (InitWebCoreSystemInterface):
3327         * WebView/WebView.mm:
3328         (+[WebView _setCacheModel:]):
3329
3330 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3331
3332         Refactor WebContentReader out of EditorMac and EditorIOS
3333         https://bugs.webkit.org/show_bug.cgi?id=176770
3334
3335         Reviewed by Sam Weinig.
3336
3337         * WebCoreSupport/WebEditorClient.mm:
3338
3339 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3340
3341         Dragging & dropping a file creates an attachment element even when it's disabled
3342         https://bugs.webkit.org/show_bug.cgi?id=176769
3343
3344         Reviewed by Tim Horton.
3345
3346         * WebView/WebView.mm:
3347         (-[WebView _preferencesChanged:]):
3348
3349 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3350
3351         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3352         https://bugs.webkit.org/show_bug.cgi?id=176721
3353         <rdar://problem/34373660>
3354
3355         Reviewed by Tim Horton.
3356
3357         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3358         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3359
3360         * WebView/WebView.mm:
3361         (-[WebView _startDrag:]):
3362         (-[WebView _draggedElementBounds]):
3363         (-[WebView _endedDataInteraction:global:]):
3364         * WebView/WebViewData.h:
3365
3366 2017-09-11  Andy Estes  <aestes@apple.com>
3367
3368         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3369         https://bugs.webkit.org/show_bug.cgi?id=176472
3370
3371         Reviewed by Eric Carlson.
3372
3373         * WebCoreSupport/WebSystemInterface.mm:
3374         (InitWebCoreSystemInterface):
3375
3376 2017-09-09  Mark Lam  <mark.lam@apple.com>
3377
3378         Avoid duplicate computations of ExecState::vm().
3379         https://bugs.webkit.org/show_bug.cgi?id=176647
3380
3381         Reviewed by Saam Barati.
3382
3383         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3384         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3385         (WebKit::NetscapePluginInstanceProxy::construct):
3386         (WebKit::NetscapePluginInstanceProxy::setProperty):
3387         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3388         (WebKit::NetscapePluginInstanceProxy::enumerate):
3389         * Plugins/Hosted/ProxyInstance.mm:
3390         (WebKit::ProxyRuntimeMethod::create):
3391
3392 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3393
3394         Unreviewed, rolling out r221773.
3395         https://bugs.webkit.org/show_bug.cgi?id=176614
3396
3397         This caused build failures. (Requested by mlewis13 on
3398         #webkit).
3399
3400         Reverted changeset:
3401
3402         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3403         https://bugs.webkit.org/show_bug.cgi?id=176472
3404         http://trac.webkit.org/changeset/221773
3405
3406 2017-09-07  Andy Estes  <aestes@apple.com>
3407
3408         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3409         https://bugs.webkit.org/show_bug.cgi?id=176472
3410
3411         Reviewed by Eric Carlson.
3412
3413         * WebCoreSupport/WebSystemInterface.mm:
3414         (InitWebCoreSystemInterface):
3415
3416 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3417
3418         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3419         https://bugs.webkit.org/show_bug.cgi?id=176561
3420
3421         Reviewed by Brent Fulgham.
3422
3423         * Misc/WebNSUserDefaultsExtras.mm:
3424
3425 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3426
3427         Modernize Geolocation code
3428         https://bugs.webkit.org/show_bug.cgi?id=176496
3429
3430         Reviewed by Andy Estes.
3431
3432         * WebCoreSupport/WebGeolocationClient.h:
3433         * WebCoreSupport/WebGeolocationClient.mm:
3434         (WebGeolocationClient::requestPermission):
3435         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3436         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3437         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3438         * WebView/WebView.mm:
3439         (-[WebView _commonInitializationWithFrameName:groupName:]):
3440         (-[WebView _geolocationDidFailWithMessage:]):
3441
3442 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3443
3444         Remove some unused bits of code and resources
3445         https://bugs.webkit.org/show_bug.cgi?id=176275
3446
3447         Reviewed by Dan Bernstein.
3448
3449         * Misc/WebNSFileManagerExtras.mm:
3450         Include FileSystem instead of FileSystemIOS.
3451
3452 2017-09-03  Darin Adler  <darin@apple.com>
3453
3454         [Cocoa] Tidy a few things in legacy WebHTMLView
3455         https://bugs.webkit.org/show_bug.cgi?id=176280
3456
3457         Reviewed by Dan Bernstein.
3458
3459         * WebCoreSupport/WebChromeClient.mm:
3460         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3461         methods it calls on WebHTMLView were doing nothing on iOS.
3462
3463         * WebView/WebFrame.mm:
3464         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3465         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3466
3467         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3468         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3469         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3470         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3471         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3472         Use RetainPtr instead of writing retain/release wherever possible.
3473         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3474         initialization for it. Removed various unused methods and declarations of methods.
3475         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3476         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3477         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3478         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3479         and remove CFRetain no longer needed since we don't support garbage collection any more.
3480         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3481         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3482         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3483         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3484         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3485         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3486         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3487         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3488         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3489         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3490         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3491         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3492         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3493         debug flag; we haven't used it for years and it's not clearly helpful.
3494         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3495         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3496         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3497         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3498         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3499         two additional methods in the WebPrivate category and still be called by the two
3500         methods in the WebInternal category that were already using it.
3501         (-[WebHTMLView didAddSubview:]): Deleted.
3502         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3503         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3504         place this was called, the close method.
3505         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3506         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3507         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3508         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3509         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3510         Added helper method to make the one below simpler.
3511         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3512         Compared pasteboard type strings using isEqualToString: rather than using == since
3513         we want to actually compare the string contents. Also updated to use modern for loop,
3514         renamed a local variable from "s" to "localSubresources", and factored out the handling
3515         of three image types to use the helper method above.
3516         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3517         _web_makePluginSubviewsPerformSelector:withObject: method.
3518         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3519         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3520         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3521         not call the -[NSView subviews] method to make this identical on both platforms and used
3522         a modern for loop.
3523         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3524         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3525         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3526         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3527         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3528         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3529         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3530         of it is Mac-only.
3531         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3532         method did was call itself on the main thread, and do nothing if called on main thread.
3533         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3534         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3535         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3536         half of this method.
3537         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3538         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3539         Simplified using a modern for loop and RetainPtr.
3540         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3541         (-[WebHTMLView keyDown:]): Ditto.
3542         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3543         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3544         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3545         (-[WebHTMLView complete:]): Ditto.
3546         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3547         now macOS-only.
3548         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3549         iOS since that is now macOS-only.
3550         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3551         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3552         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3553         and reorganized to use early return.
3554         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3555         on iOS, but kept there so we don't have to do #if at every call site.
3556         (-[WebHTMLView _pluginController]): Moved into internal category.
3557         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3558         there only for GC, using C++ initialization, removing obsolete comment.
3559         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3560         peculiar iOS-only comment.
3561         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3562
3563         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3564         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3565         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3566         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3567         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3568
3569         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3570         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3571         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3572         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3573         them at this time.
3574
3575 2017-09-03  Sam Weinig  <sam@webkit.org>
3576
3577         Remove CanvasProxy
3578         https://bugs.webkit.org/show_bug.cgi?id=176288
3579
3580         Reviewed by Yusuke Suzuki.
3581
3582         CanvasProxy does not appear to be in any current HTML spec
3583         and was disabled and unimplemented in our tree. Time to 
3584         get rid of it.
3585
3586         * Configurations/FeatureDefines.xcconfig:
3587
3588 2017-09-02  Andy Estes  <aestes@apple.com>
3589
3590         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3591         https://bugs.webkit.org/show_bug.cgi?id=176270
3592
3593         Reviewed by Tim Horton.
3594
3595         * Plugins/Hosted/NetscapePluginHostManager.mm:
3596         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3597         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3598         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3599         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3600         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3601         (WebKit::SoftwareCARenderer::context const):
3602         (WebKit::SoftwareCARenderer::renderContext const):
3603         (WebKit::SoftwareCARenderer::render):
3604         (-[WebHostedNetscapePluginView createPlugin]):
3605         (-[WebHostedNetscapePluginView createPluginLayer]):
3606         (-[WebHostedNetscapePluginView destroyPlugin]):
3607         (-[WebHostedNetscapePluginView drawRect:]):
3608         * WebCoreSupport/WebSystemInterface.mm:
3609         (InitWebCoreSystemInterface):
3610
3611 2017-09-01  Andy Estes  <aestes@apple.com>
3612
3613         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3614         https://bugs.webkit.org/show_bug.cgi?id=176200
3615
3616         Reviewed by Tim Horton.
3617
3618         * Carbon/HIWebView.mm:
3619         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3620         (overrideCGContext):
3621         (restoreCGContext):
3622         (Draw):
3623         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3624         (+[WebHostedNetscapePluginView initialize]):
3625         * Plugins/WebBaseNetscapePluginView.h:
3626         * Plugins/WebBaseNetscapePluginView.mm:
3627         (WebKit::sendUserChangeNotifications):
3628         * Plugins/WebNetscapePluginView.mm:
3629         (+[WebNetscapePluginView initialize]):
3630         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3631         * WebCoreSupport/WebSystemInterface.mm:
3632         (InitWebCoreSystemInterface):
3633         * WebView/WebFrame.mm:
3634         (-[WebFrame _paintBehaviorForDestinationContext:]):
3635         * WebView/WebFullScreenController.mm:
3636         (setClipRectForWindow):
3637         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3638         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3639         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3640         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3641
3642 2017-08-31  Andy Estes  <aestes@apple.com>
3643
3644         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3645         https://bugs.webkit.org/show_bug.cgi?id=176175
3646
3647         Reviewed by Brady Eidson.
3648
3649         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3650         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3651         * Plugins/Hosted/WebTextInputWindowController.m:
3652         (-[WebTextInputPanel init]):
3653         * WebCoreSupport/WebSystemInterface.mm:
3654         (InitWebCoreSystemInterface):
3655         * WebView/WebDynamicScrollBarsView.mm:
3656         (-[WebDynamicScrollBarsView scrollWheel:]):
3657         * WebView/WebHTMLView.mm:
3658         (-[WebHTMLView _removeWindowObservers]):
3659         (-[WebHTMLView addWindowObservers]):
3660         * WebView/WebView.mm:
3661         (-[WebView addWindowObserversForWindow:]):
3662         (-[WebView removeWindowObservers]):
3663         (-[WebView viewWillMoveToWindow:]):
3664
3665 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3666
3667         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3668         https://bugs.webkit.org/show_bug.cgi?id=175779
3669         <rdar://problem/22367975>
3670
3671         Reviewed by Tim Horton.
3672
3673         * WebCoreSupport/WebFrameLoaderClient.h:
3674         * WebCoreSupport/WebFrameLoaderClient.mm:
3675         (WebFrameLoaderClient::webGLPolicyForURL const):
3676         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3677
3678 2017-08-30  Andy Estes  <aestes@apple.com>
3679
3680         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3681         https://bugs.webkit.org/show_bug.cgi?id=176093
3682
3683         Reviewed by Eric Carlson.
3684
3685         * WebCoreSupport/WebSystemInterface.mm:
3686         (InitWebCoreSystemInterface):
3687
3688 2017-08-30  Andy Estes  <aestes@apple.com>
3689
3690         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3691         https://bugs.webkit.org/show_bug.cgi?id=176087
3692
3693         Reviewed by Alex Christensen.
3694
3695         * Carbon/CarbonUtils.m:
3696         (getNSAutoreleasePoolCount):
3697         (WebInitForCarbon):
3698         (PoolCleaner):
3699         * Carbon/CarbonWindowAdapter.mm:
3700         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3701         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3702         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3703         (-[CarbonWindowAdapter _windowMovedToRect:]):
3704         * Carbon/HIViewAdapter.m:
3705         * Carbon/HIWebView.mm:
3706         (Draw):
3707         (CreateNSEventAdoptingCGEvent):
3708         (CopyEventCGEvent):
3709         (CreateNSEventWithCarbonClickEvent):
3710         (Click):
3711         (CreateNSEventWithCarbonEvent):
3712         (MouseUp):
3713         (CreateNSEventWithCarbonMouseMoveEvent):
3714         (MouseMoved):
3715         (MouseDragged):
3716         (MouseWheelMoved):
3717         (WindowHandler):
3718         (HIWebViewEventHandler):
3719         * Misc/QuickDrawCompatibility.h: Removed.
3720         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3721         (getCarbonEvent):
3722         (WebNetscapePluginEventHandlerCarbon::keyDown):
3723         (WebNetscapePluginEventHandlerCarbon::keyUp):
3724         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3725         (WebNetscapePluginEventHandlerCocoa::keyDown):
3726         * Plugins/WebNetscapePluginView.mm:
3727         (-[WebNetscapePluginView tellQuickTimeToChill]):
3728
3729 2017-08-29  Andy Estes  <aestes@apple.com>
3730
3731         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3732         https://bugs.webkit.org/show_bug.cgi?id=176046
3733
3734         Reviewed by Alex Christensen.
3735
3736         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3737         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3738
3739         * Misc/WebNSFileManagerExtras.mm:
3740         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3741         (setMetaData): Deleted.
3742         * WebCoreSupport/WebSystemInterface.mm:
3743         (InitWebCoreSystemInterface):
3744
3745 2017-08-28  Andy Estes  <aestes@apple.com>
3746
3747         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3748         https://bugs.webkit.org/show_bug.cgi?id=176039
3749
3750         Reviewed by Alex Christensen.
3751
3752         * WebCoreSupport/WebSystemInterface.mm:
3753         (InitWebCoreSystemInterface):
3754         * WebView/WebPreferences.mm:
3755         (+[WebPreferences _systemCFStringEncoding]):
3756
3757 2017-08-28  Andy Estes  <aestes@apple.com>
3758
3759         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3760         https://bugs.webkit.org/show_bug.cgi?id=176032
3761
3762         Reviewed by Alex Christensen.
3763
3764         * WebCoreSupport/WebSystemInterface.mm:
3765         (InitWebCoreSystemInterface):
3766         * WebView/WebView.mm:
3767         (-[WebView _cachedResponseForURL:]):
3768
3769 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3770
3771         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3772         https://bugs.webkit.org/show_bug.cgi?id=175992
3773         <rdar://problem/34086613>
3774
3775         Reviewed by Daniel Bates.
3776
3777         * WebCoreSupport/WebPlatformStrategies.h:
3778         * WebCoreSupport/WebPlatformStrategies.mm:
3779         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3780         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3781         indicating if secure cookies were accessed.
3782
3783 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3784
3785         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3786         https://bugs.webkit.org/show_bug.cgi?id=170955
3787         <rdar://problem/31697653>
3788
3789         Reviewed by Ryosuke Niwa.
3790
3791         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3792         text is being replaced.
3793
3794         * WebView/WebHTMLView.mm:
3795         (-[WebHTMLView insertText:]):
3796
3797 2017-08-24  Chris Dumez  <cdumez@apple.com>
3798
3799         [Directory Upload] Add basic support for input.webkitdirectory
3800         https://bugs.webkit.org/show_bug.cgi?id=175950
3801         <rdar://problem/33951915>
3802
3803         Reviewed by Geoffrey Garen.
3804
3805         Add private API to toggle Directory Upload support on Mac WebKit1.
3806
3807         * WebView/WebPreferenceKeysPrivate.h:
3808         * WebView/WebPreferences.mm:
3809         (+[WebPreferences initialize]):
3810         (-[WebPreferences setDirectoryUploadEnabled:]):
3811         (-[WebPreferences directoryUploadEnabled]):
3812         * WebView/WebPreferencesPrivate.h:
3813         * WebView/WebView.mm:
3814         (-[WebView _preferencesChanged:]):
3815
3816 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3817
3818         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3819         https://bugs.webkit.org/show_bug.cgi?id=175370
3820         <rdar://problem/33799806>
3821
3822         Reviewed by Ryosuke Niwa.
3823
3824         Adjust WebEditorClient for interface changes.
3825
3826         * WebCoreSupport/WebEditorClient.h:
3827
3828 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3829
3830         Remove ChromeClient::scrollbarsModeDidChange
3831         https://bugs.webkit.org/show_bug.cgi?id=175805
3832
3833         Reviewed by Daniel Bates.
3834
3835         * WebCoreSupport/WebChromeClient.h:
3836
3837 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3838
3839         Remove ChromeClient::hasOpenedPopup
3840         https://bugs.webkit.org/show_bug.cgi?id=175804
3841
3842         Reviewed by Sam Weinig.
3843
3844         * WebCoreSupport/WebChromeClient.h:
3845         * WebCoreSupport/WebChromeClient.mm:
3846         (WebChromeClient::hasOpenedPopup const): Deleted.
3847
3848 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3849
3850         Disable access to secure cookies if an HTTPS site loads mixed content
3851         https://bugs.webkit.org/show_bug.cgi?id=157053
3852         <rdar://problem/11290808>
3853
3854         Reviewed by Dan Bates.
3855
3856         * WebCoreSupport/WebPlatformStrategies.h:
3857         * WebCoreSupport/WebPlatformStrategies.mm:
3858         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3859         indicating whether secure cookies should be included in the response.
3860
3861 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3862
3863         [PAL] Move spi/mac directory into PAL
3864         https://bugs.webkit.org/show_bug.cgi?id=175649
3865
3866         Reviewed by Myles C. Maxfield.
3867
3868         * Misc/WebSharingServicePickerController.h:
3869         * WebCoreSupport/WebContextMenuClient.mm:
3870         * WebCoreSupport/WebEditorClient.mm:
3871         * WebCoreSupport/WebSelectionServiceController.mm:
3872         * WebView/WebHTMLView.mm:
3873         * WebView/WebImmediateActionController.h:
3874         * WebView/WebImmediateActionController.mm:
3875         * WebView/WebView.mm:
3876
3877 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3878
3879         [PAL] Relocate SessionID to root
3880         https://bugs.webkit.org/show_bug.cgi?id=175684
3881
3882         Reviewed by Alex Christensen.
3883
3884         * WebCoreSupport/WebFrameNetworkingContext.mm:
3885
3886 2017-08-17  Andreas Kling  <akling@apple.com>
3887
3888         Disable CSS regions at compile time
3889         https://bugs.webkit.org/show_bug.cgi?id=175630
3890
3891         Reviewed by Antti Koivisto.
3892
3893         * Configurations/FeatureDefines.xcconfig:
3894
3895 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3896
3897         [PAL] Move SessionID into PAL
3898         https://bugs.webkit.org/show_bug.cgi?id=174192
3899
3900         Reviewed by Antti Koivisto.
3901
3902         * Misc/WebCache.mm:
3903         (+[WebCache imageForURL:]):
3904         * WebCoreSupport/WebFrameLoaderClient.h:
3905         * WebCoreSupport/WebFrameLoaderClient.mm:
3906         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3907         * WebCoreSupport/WebFrameNetworkingContext.mm:
3908         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3909         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3910         (WebFrameNetworkingContext::storageSession const):
3911         * WebCoreSupport/WebPlatformStrategies.h:
3912         * WebCoreSupport/WebPlatformStrategies.mm:
3913         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3914         * WebKitPrefix.h:
3915
3916 2017-08-16  Andy Estes  <aestes@apple.com>
3917
3918         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3919         https://bugs.webkit.org/show_bug.cgi?id=175648
3920
3921         Reviewed by Tim Horton.
3922
3923         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3924         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3925         (WebPaymentCoordinatorClient::showPaymentUI):
3926
3927 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3928
3929         [PAL] Move spi/ios and spi/win directories into PAL
3930         https://bugs.webkit.org/show_bug.cgi?id=175171
3931
3932         Reviewed by Antti Koivisto.
3933
3934         * WebCoreSupport/WebFrameLoaderClient.mm:
3935         * WebView/WebView.mm:
3936
3937 2017-08-16  Andy Estes  <aestes@apple.com>
3938
3939         [Payment Request] Add an ENABLE flag and an experimental feature preference
3940         https://bugs.webkit.org/show_bug.cgi?id=175622
3941
3942         Reviewed by Tim Horton.
3943
3944         * Configurations/FeatureDefines.xcconfig:
3945
3946 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3947
3948         [PAL] Move Sleep classes into PAL
3949         https://bugs.webkit.org/show_bug.cgi?id=175456
3950
3951         Reviewed by Ryosuke Niwa.
3952
3953         * WebView/WebFullScreenController.h:
3954
3955 2017-08-15  Youenn Fablet  <youenn@apple.com>
3956
3957         [Cache API] Adding generic support for CacheStorage and Cache methods
3958         https://bugs.webkit.org/show_bug.cgi?id=175455
3959
3960         Reviewed by Chris Dumez.
3961
3962         * WebView/WebView.mm:
3963         (-[WebView _commonInitializationWithFrameName:groupName:]):
3964
3965 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3966
3967         Remove Proximity Events and related code
3968         https://bugs.webkit.org/show_bug.cgi?id=175545
3969
3970         Reviewed by Daniel Bates.
3971
3972         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3973         and other related code.
3974
3975         * Configurations/FeatureDefines.xcconfig:
3976
3977 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3978
3979         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3980         https://bugs.webkit.org/show_bug.cgi?id=175504
3981
3982         Reviewed by Sam Weinig.
3983
3984         * Configurations/FeatureDefines.xcconfig:
3985         * DOM/DOMHTMLFormElement.mm:
3986         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3987         * WebCoreSupport/WebFrameLoaderClient.h:
3988
3989 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3990
3991         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3992         https://bugs.webkit.org/show_bug.cgi?id=175557
3993
3994         Reviewed by Jon Lee.
3995
3996         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3997
3998         * Configurations/FeatureDefines.xcconfig:
3999
4000 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
4001
4002         Composition underline color is always black
4003         https://bugs.webkit.org/show_bug.cgi?id=174675
4004
4005         Reviewed by Ryosuke Niwa.
4006
4007         * WebView/WebHTMLView.mm:
4008         (extractUnderlines): If NSUnderlineColorAttributeName
4009         is not present use text color for composition underline.
4010         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
4011         for composition underline in the plain text case.
4012
4013 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
4014
4015         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
4016         https://bugs.webkit.org/show_bug.cgi?id=175474
4017         <rdar://problem/33844628>
4018
4019         Reviewed by Wenson Hsieh.
4020
4021         Replaced the build flag by a runtime flag and disabled the feature by default.
4022
4023         * Configurations/FeatureDefines.xcconfig:
4024         * WebView/WebPreferenceKeysPrivate.h:
4025         * WebView/WebPreferences.mm:
4026         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
4027         (-[WebPreferences dataTransferItemsEnabled]): Added.
4028         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
4029         * WebView/WebPreferencesPrivate.h:
4030         * WebView/WebView.mm:
4031         (-[WebView _preferencesChanged:]):
4032
4033 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4034
4035         Remove ENABLE_GAMEPAD_DEPRECATED
4036         https://bugs.webkit.org/show_bug.cgi?id=175361
4037
4038         Reviewed by Carlos Garcia Campos.
4039
4040         * Configurations/FeatureDefines.xcconfig:
4041
4042 2017-08-09  Chris Dumez  <cdumez@apple.com>
4043
4044         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
4045         https://bugs.webkit.org/show_bug.cgi?id=175401
4046
4047         Reviewed by Brady Eidson.
4048
4049         * WebView/WebPreferenceKeysPrivate.h:
4050         * WebView/WebPreferences.mm:
4051         (+[WebPreferences initialize]):
4052         (-[WebPreferences beaconAPIEnabled]): Deleted.
4053         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
4054         * WebView/WebPreferencesPrivate.h:
4055         * WebView/WebView.mm:
4056         (-[WebView _preferencesChanged:]):
4057
4058 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
4059
4060         [PAL] Move spi/cocoa and spi/cg directories into PAL
4061         https://bugs.webkit.org/show_bug.cgi?id=175175
4062
4063         Reviewed by Myles C. Maxfield.
4064
4065         * History/WebHistory.mm:
4066         * Misc/WebDownload.mm:
4067         * Misc/WebKitNSStringExtras.mm:
4068         * Plugins/Hosted/NetscapePluginHostManager.mm:
4069         * Plugins/WebPluginDatabase.mm:
4070         * WebCoreSupport/WebFrameLoaderClient.mm:
4071         * WebInspector/WebNodeHighlight.mm:
4072         * WebView/WebHTMLView.mm:
4073         * WebView/WebIndicateLayer.mm:
4074         * WebView/WebView.mm:
4075         * WebView/WebViewData.h:
4076
4077 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4078
4079         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
4080         https://bugs.webkit.org/show_bug.cgi?id=175392
4081         <rdar://problem/33783207>
4082
4083         Reviewed by Tim Horton and Megan Gardner.
4084
4085         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
4086
4087         * Configurations/FeatureDefines.xcconfig:
4088
4089 2017-08-09  Daniel Bates  <dabates@apple.com>
4090
4091         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
4092         https://bugs.webkit.org/show_bug.cgi?id=175247
4093         <rdar://problem/33679804>
4094
4095         Reviewed by Brady Eidson.
4096
4097         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
4098         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
4099         clients that need to make use of this information at this time. If such a needs comes up