Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2
3         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
4         https://bugs.webkit.org/show_bug.cgi?id=196948
5         <rdar://problem/49927131>
6
7         Reviewed by Tim Horton.
8
9         * WebCoreSupport/WebChromeClient.h:
10
11 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
12
13         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
14         https://bugs.webkit.org/show_bug.cgi?id=197171
15         <rdar://problem/47454979>
16
17         Reviewed by Youenn Fablet.
18
19         * WebView/WebVideoFullscreenController.mm:
20         (-[WebVideoFullscreenController setVideoElement:]):
21         (-[WebVideoFullscreenController windowDidExitFullscreen]):
22         (SOFT_LINK_CLASS): Deleted.
23
24 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
25
26         Make it possible to control the renderTreeAsText output by setting options on testRunner
27         https://bugs.webkit.org/show_bug.cgi?id=197133
28
29         Reviewed by Sam Weinig.
30
31         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
32         that make sense in testing (those that don't dump unstable data like addresses), and plumb
33         these flags through the various framework layers.
34
35         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
36
37         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
38         and hand-code DumpRenderTree bindings.
39
40         Some cleanup of the TestRunners, using member initializers.
41
42         * Misc/WebCoreStatistics.h:
43         * Misc/WebCoreStatistics.mm:
44         (-[WebFrame renderTreeAsExternalRepresentationForPrinting]):
45         (toRenderAsTextFlags):
46         (-[WebFrame renderTreeAsExternalRepresentationWithOptions:]):
47         (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): Deleted.
48
49 2019-04-23  Commit Queue  <commit-queue@webkit.org>
50
51         Unreviewed, rolling out r244556.
52         https://bugs.webkit.org/show_bug.cgi?id=197212
53
54         Causing build failures on multiple builders (Requested by
55         ShawnRoberts on #webkit).
56
57         Reverted changeset:
58
59         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
60         https://bugs.webkit.org/show_bug.cgi?id=197171
61         https://trac.webkit.org/changeset/244556
62
63 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
64
65         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
66         https://bugs.webkit.org/show_bug.cgi?id=197171
67         <rdar://problem/47454979>
68
69         Reviewed by Youenn Fablet.
70
71         * WebView/WebVideoFullscreenController.mm:
72         (-[WebVideoFullscreenController setVideoElement:]):
73         (-[WebVideoFullscreenController windowDidExitFullscreen]):
74         (SOFT_LINK_CLASS): Deleted.
75
76 2019-04-23  Chris Dumez  <cdumez@apple.com>
77
78         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
79         https://bugs.webkit.org/show_bug.cgi?id=197097
80         <rdar://problem/50048318>
81
82         Reviewed by Alex Christensen.
83
84         * WebCoreSupport/WebFrameLoaderClient.h:
85         * WebCoreSupport/WebFrameLoaderClient.mm:
86         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
87
88 2019-04-18  Daniel Bates  <dabates@apple.com>
89
90         Use existing KeyEventCodesIOS constants instead of duplicating them
91         https://bugs.webkit.org/show_bug.cgi?id=197081
92
93         Rubber-stamped by Wenson Hsieh.
94
95         * WebView/WebHTMLView.mm:
96         (-[WebHTMLView _handleEditingKeyEvent:]):
97
98 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
99
100         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
101         https://bugs.webkit.org/show_bug.cgi?id=197079
102
103         Reviewed by Darin Adler.
104
105         The crash was caused by the fact deleting a node could end up deleting Objective-C event listeners
106         some of which may be the last object holding onto WebView itself in the middle of running GC.
107
108         It's not generally safe to delete Objective-C objects defiend by client applications since
109         dealloc could execute arbitrary code, and for instance, try to execute JavaScript or load new page.
110
111         Fixed the bug by delaying the dealloc'ing of Objective event listeners via autorelease pool.
112
113         * DOM/ObjCEventListener.mm:
114         (WebCore::ObjCEventListener::~ObjCEventListener):
115
116 2019-04-18  Jer Noble  <jer.noble@apple.com>
117
118         Refactoring: Pull all fullscreen code out of Document and into its own helper class
119         https://bugs.webkit.org/show_bug.cgi?id=197017
120
121         Reviewed by Eric Carlson.
122
123         * DOM/DOMDocument.mm:
124         (-[DOMDocument webkitIsFullScreen]):
125         (-[DOMDocument webkitFullScreenKeyboardInputAllowed]):
126         (-[DOMDocument webkitCurrentFullScreenElement]):
127         (-[DOMDocument webkitFullscreenEnabled]):
128         (-[DOMDocument webkitFullscreenElement]):
129         (-[DOMDocument webkitCancelFullScreen]):
130         (-[DOMDocument webkitExitFullscreen]):
131         * WebCoreSupport/WebChromeClient.mm:
132         (WebChromeClient::createWindow):
133         * WebCoreSupport/WebKitFullScreenListener.mm:
134         (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
135         (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
136         (-[WebKitFullScreenListener webkitWillExitFullScreen]):
137         (-[WebKitFullScreenListener webkitDidExitFullScreen]):
138         * WebView/WebFullScreenController.mm:
139         (-[WebFullScreenController enterFullScreen:]):
140         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
141         (-[WebFullScreenController requestExitFullScreen]):
142         (-[WebFullScreenController exitFullScreen]):
143         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
144         (-[WebFullScreenController _manager]):
145         * WebView/WebView.mm:
146         (-[WebView _didStartProvisionalLoadForFrame:]):
147
148 2019-04-17  Brady Eidson  <beidson@apple.com>
149
150         Link clicks in PDFs shouldn't send referrer headers.
151         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
152
153         Reviewed by Tim Horton.
154
155         * WebView/WebPDFView.mm:
156         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
157
158 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
159
160         requestAnimationFrame should execute before the next frame
161         https://bugs.webkit.org/show_bug.cgi?id=177484
162
163         Reviewed by Simon Fraser.
164
165         * WebView/WebView.mm:
166         (-[WebView _viewWillDrawInternal]):
167         (-[WebView _flushCompositingChanges]):
168         Call Page::updateRendering() which implements "Update the rendering"
169         step of the HTML Event Loop specification.
170
171 2019-04-10  Devin Rousso  <drousso@apple.com>
172
173         Web Inspector: save sheet should be anchored underneath the tab bar when detached
174         https://bugs.webkit.org/show_bug.cgi?id=196722
175         <rdar://problem/49613280>
176
177         Reviewed by Timothy Hatcher.
178
179         * WebCoreSupport/WebInspectorClient.h:
180         (WebInspectorFrontendClient::sheetRect const): Added.
181         * WebCoreSupport/WebInspectorClient.mm:
182         (-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
183         (WebInspectorFrontendClient::setSheetRect): Added.
184
185 2019-04-10  Alex Christensen  <achristensen@webkit.org>
186
187         Add SPI WKNavigationResponse._downloadAttribute
188         https://bugs.webkit.org/show_bug.cgi?id=196755
189         <rdar://49587365>
190
191         Reviewed by Brady Eidson.
192
193         * WebCoreSupport/WebFrameLoaderClient.h:
194         * WebCoreSupport/WebFrameLoaderClient.mm:
195         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
196
197 2019-04-10  Antoine Quint  <graouts@apple.com>
198
199         Enable Pointer Events on watchOS
200         https://bugs.webkit.org/show_bug.cgi?id=196771
201         <rdar://problem/49040909>
202
203         Reviewed by Dean Jackson.
204
205         * Configurations/FeatureDefines.xcconfig:
206
207 2019-04-08  Justin Fan  <justin_fan@apple.com>
208
209         [Web GPU] Fix Web GPU experimental feature on iOS
210         https://bugs.webkit.org/show_bug.cgi?id=196632
211
212         Reviewed by Myles C. Maxfield.
213
214         Add feature conditionals for iOS 11.
215         Properly make Web GPU available on iOS 11+.
216
217         * Configurations/FeatureDefines.xcconfig:
218         * Configurations/WebKitTargetConditionals.xcconfig:
219
220 2019-04-05  Alex Christensen  <achristensen@webkit.org>
221
222         REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on non-main thread
223         https://bugs.webkit.org/show_bug.cgi?id=190918
224         <rdar://problem/45603890>
225
226         Reviewed by Darin Adler.
227
228         Since we not doing networking on the main thread but WebView is to be used on the main thread,
229         we need to hop delegate calls to the main thread similarly to how we do it in the non-download
230         delegate calls in WebCoreResourceHandleAsOperationQueueDelegate.
231
232         * Misc/WebDownload.mm:
233         (-[WebDownloadInternal downloadDidBegin:]):
234         (-[WebDownloadInternal download:willSendRequest:redirectResponse:]):
235         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
236         (-[WebDownloadInternal download:didReceiveResponse:]):
237         (-[WebDownloadInternal download:didReceiveDataOfLength:]):
238         (-[WebDownloadInternal download:shouldDecodeSourceDataOfMIMEType:]):
239         (-[WebDownloadInternal download:decideDestinationWithSuggestedFilename:]):
240         (-[WebDownloadInternal download:didCreateDestination:]):
241         (-[WebDownloadInternal downloadDidFinish:]):
242         (-[WebDownloadInternal download:didFailWithError:]):
243
244 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
245
246         Remove AUDIO_TOOLBOX_AUDIO_SESSION
247         https://bugs.webkit.org/show_bug.cgi?id=196653
248         <rdar://problem/49652098>
249
250         Reviewed by Jer Noble.
251
252         * WebView/WebPreferences.mm:
253         (-[WebPreferences setAudioSessionCategoryOverride:]):
254
255 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
256
257         Stop including <AudioToolbox/AudioSession.h>
258         https://bugs.webkit.org/show_bug.cgi?id=196648
259         <rdar://problem/39665771>
260
261         Reviewed by Jer Noble.
262
263         * WebView/WebPreferencesPrivate.h:
264
265 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
266
267         Have ScrollableArea store a ScrollType for the current scroll
268         https://bugs.webkit.org/show_bug.cgi?id=196627
269
270         Reviewed by Zalan Bujtas.
271
272         Send the programmatic scroll type.
273
274         * DOM/DOMHTML.mm:
275         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
276
277 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
278
279         -apple-trailing-word is needed for browser detection
280         https://bugs.webkit.org/show_bug.cgi?id=196575
281
282         Unreviewed.
283
284         * Configurations/FeatureDefines.xcconfig:
285
286 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
287
288         Remove support for -apple-trailing-word
289         https://bugs.webkit.org/show_bug.cgi?id=196525
290
291         Reviewed by Zalan Bujtas.
292
293         This CSS property is nonstandard and not used.
294
295         * Configurations/FeatureDefines.xcconfig:
296
297 2019-04-01  Alex Christensen  <achristensen@webkit.org>
298
299         Add SPI to canonicalize NSURLs with WTF::URL
300         https://bugs.webkit.org/show_bug.cgi?id=196415
301         <rdar://problem/44980271>
302
303         Reviewed by Darin Adler.
304
305         * Misc/WebNSURLExtras.h:
306         * Misc/WebNSURLExtras.mm:
307         (-[NSURL _webkit_canonicalize_with_wtf]):
308         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
309         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
310
311 2019-03-31  Sam Weinig  <weinig@apple.com>
312
313         Remove more i386 specific configurations
314         https://bugs.webkit.org/show_bug.cgi?id=196430
315
316         Reviewed by Alexey Proskuryakov.
317
318         * Configurations/FeatureDefines.xcconfig:
319         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
320
321 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
322
323         Delete WebMetal implementation in favor of WebGPU
324         https://bugs.webkit.org/show_bug.cgi?id=195418
325
326         Reviewed by Dean Jackson.
327
328         * Configurations/FeatureDefines.xcconfig:
329         * WebView/WebPreferenceKeysPrivate.h:
330         * WebView/WebPreferences.mm:
331         (+[WebPreferences initialize]):
332         (-[WebPreferences webMetalEnabled]): Deleted.
333         (-[WebPreferences setWebMetalEnabled:]): Deleted.
334         * WebView/WebPreferencesPrivate.h:
335         * WebView/WebView.mm:
336         (-[WebView _preferencesChanged:]):
337
338 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
339
340         Implement ResizeObserver.
341         https://bugs.webkit.org/show_bug.cgi?id=157743
342
343         Reviewed by Simon Fraser.
344
345         * Configurations/FeatureDefines.xcconfig:
346         * WebView/WebPreferenceKeysPrivate.h:
347         * WebView/WebPreferences.mm:
348         (+[WebPreferences initialize]):
349         (-[WebPreferences resizeObserverEnabled]):
350         (-[WebPreferences setResizeObserverEnabled:]):
351         * WebView/WebPreferencesPrivate.h:
352         * WebView/WebView.mm:
353         (-[WebView _preferencesChanged:]):
354         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
355
356 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
357
358         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
359         https://bugs.webkit.org/show_bug.cgi?id=196336
360
361         Reviewed by Tim Horton.
362
363         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
364
365         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
366
367         * WebCoreSupport/PopupMenuMac.mm:
368         (PopupMenuMac::hide):
369
370 2019-03-25  Andy Estes  <aestes@apple.com>
371
372         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
373         https://bugs.webkit.org/show_bug.cgi?id=194964
374         <rdar://problem/48279441>
375
376         Reviewed by Alex Christensen.
377
378         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
379         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
380         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
381         PreviewLoaderClient alive for its lifetime. This ensures that as long as
382         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
383         by WebKit.
384
385         * WebCoreSupport/WebFrameLoaderClient.mm:
386         (WebFrameLoaderClient::createPreviewLoaderClient):
387         * WebView/WebDataSource.mm:
388         (-[WebDataSource _quickLookPreviewLoaderClient]):
389         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
390         * WebView/WebDataSourceInternal.h:
391
392 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
393
394         Remove NavigatorContentUtils in WebCore/Modules
395         https://bugs.webkit.org/show_bug.cgi?id=196070
396
397         Reviewed by Alex Christensen.
398
399         NavigatorContentUtils was to support the custom scheme spec [1].
400         However, in WebKit side, no port has supported the feature in
401         WebKit layer after EFL port was removed. So there has been the
402         only IDL implementation of the NavigatorContentUtils in WebCore.
403         So we don't need to keep the implementation in WebKit.
404
405         * Configurations/FeatureDefines.xcconfig:
406
407 2019-03-22  Keith Rollin  <krollin@apple.com>
408
409         Enable ThinLTO support in Production builds
410         https://bugs.webkit.org/show_bug.cgi?id=190758
411         <rdar://problem/45413233>
412
413         Reviewed by Daniel Bates.
414
415         Enable building with Thin LTO in Production when using Xcode 10.2 or
416         later. This change results in a 1.45% progression in PLT5. Full
417         Production build times increase about 2-3%. Incremental build times
418         are more severely affected, and so LTO is not enabled for local
419         engineering builds.
420
421         LTO is enabled only on macOS for now, until rdar://problem/49013399,
422         which affects ARM builds, is fixed.
423
424         To change the LTO setting when building locally:
425
426         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
427           command line.
428         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
429           on the command line.
430         - If building with `build-root`, specify --lto={none,thin,full} on the
431           command line.
432         - If building with Xcode, create a LocalOverrides.xcconfig file at the
433           top level of your repository directory (if needed) and define
434           WK_LTO_MODE to full, thin, or none.
435
436         * Configurations/Base.xcconfig:
437
438 2019-03-21  Andy Estes  <aestes@apple.com>
439
440         [iOS] Apple Pay should be available in documents with no user agent scripts
441         https://bugs.webkit.org/show_bug.cgi?id=196061
442         <rdar://problem/48649391>
443
444         Reviewed by Brady Eidson.
445
446         * WebView/WebFrame.mm:
447         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
448
449 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
450
451         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
452         https://bugs.webkit.org/show_bug.cgi?id=196049
453
454         Reviewed by Tim Horton.
455
456         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
457         overflow scrolling in general, so rename it.
458
459         * Configurations/FeatureDefines.xcconfig:
460
461 2019-03-13  Dean Jackson  <dino@apple.com>
462
463         Block all plugins smaller than 5x5px
464         https://bugs.webkit.org/show_bug.cgi?id=195702
465         <rdar://problem/28435204>
466
467         Reviewed by Sam Weinig.
468
469         Removed a function that was never being called.
470
471         * WebCoreSupport/WebFrameLoaderClient.h:
472         * WebCoreSupport/WebFrameLoaderClient.mm:
473         (WebFrameLoaderClient::recreatePlugin): Deleted.
474
475 2019-03-13  Keith Rollin  <krollin@apple.com>
476
477         Add support for new StagedFrameworks layout
478         https://bugs.webkit.org/show_bug.cgi?id=195543
479
480         Reviewed by Alexey Proskuryakov.
481
482         When creating the WebKit layout for out-of-band Safari/WebKit updates,
483         use an optional path prefix when called for.
484
485         * Configurations/WebKitLegacy.xcconfig:
486
487 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
488
489         Remove a site specific hack for AppleConnect plugin
490         https://bugs.webkit.org/show_bug.cgi?id=195643
491
492         Reviewed by Simon Fraser.
493
494         r66437 added a workaround for AppleConnect plugin.
495
496         Remove this code since Safari doesn't even use WebKitLegacy anymore,
497         and other WebKit clients support AppleConnect plugins.
498
499         * WebCoreSupport/WebFrameLoaderClient.mm:
500         (WebFrameLoaderClient::createPlugin):
501
502 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
503
504         Unreviewed, rolling out r242688, r242643, r242624.
505
506         Caused multiple layout test failures and crashes on iOS and macOS.
507
508         Reverted changeset:
509
510         "requestAnimationFrame should execute before the next frame"
511         https://bugs.webkit.org/show_bug.cgi?id=177484
512         https://trac.webkit.org/changeset/242624/webkit
513
514         * WebView/WebView.mm:
515         (-[WebView _viewWillDrawInternal]):
516
517 2019-03-09  Andy Estes  <aestes@apple.com>
518
519         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
520         https://bugs.webkit.org/show_bug.cgi?id=195526
521         <rdar://problem/48745636>
522
523         Reviewed by Chris Dumez.
524
525         * WebCoreSupport/WebPaymentCoordinatorClient.h:
526         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
527         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
528         (WebPaymentCoordinatorClient::openPaymentSetup):
529
530 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
531
532         requestAnimationFrame should execute before the next frame
533         https://bugs.webkit.org/show_bug.cgi?id=177484
534
535         Reviewed by Simon Fraser.
536
537         * WebView/WebView.mm:
538         (-[WebView _viewWillDrawInternal]):
539         Call Page::renderingUpdate() which implements  "Update the rendering"
540         step of the HTML Event Loop specification.
541
542 2019-03-07  Zalan Bujtas  <zalan@apple.com>
543
544         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
545         https://bugs.webkit.org/show_bug.cgi?id=195353
546         <rdar://problem/48626394>
547
548         Reviewed by Simon Fraser.
549
550         * WebView/WebPreferenceKeysPrivate.h:
551         * WebView/WebPreferences.mm:
552         (+[WebPreferences initialize]):
553         (-[WebPreferences contentChangeObserverEnabled]):
554         (-[WebPreferences setContentChangeObserverEnabled:]):
555         * WebView/WebPreferencesPrivate.h:
556         * WebView/WebView.mm:
557         (-[WebView _preferencesChanged:]):
558
559 2019-03-06  Sam Weinig  <sam@webkit.org>
560
561         WebKitLegacy does not need to generate an export file for i386 anymore
562         https://bugs.webkit.org/show_bug.cgi?id=195380
563
564         Reviewed by Dan Bernstein.
565
566         * Configurations/WebKitLegacy.xcconfig:
567         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
568         It still needs to be generated, since we are concatenating the shared exports
569         file with a macOS or iOS specific one.
570
571         * WebKit.mac.exp:
572         Remove i386 specific symbols that we were previously stripping.
573
574 2019-03-06  Rob Buis  <rbuis@igalia.com>
575
576         Consider supporting the `referrerpolicy` attribute.
577         https://bugs.webkit.org/show_bug.cgi?id=179053
578
579         Reviewed by Darin Adler.
580
581         Add a runtime flag for referrerpolicy attribute.
582
583         * WebView/WebPreferenceKeysPrivate.h:
584         * WebView/WebPreferences.mm:
585         (+[WebPreferences initialize]):
586         (-[WebPreferences referrerPolicyAttributeEnabled]):
587         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
588         * WebView/WebPreferencesPrivate.h:
589         * WebView/WebView.mm:
590         (-[WebView _preferencesChanged:]):
591
592 2019-03-03  Tim Horton  <timothy_horton@apple.com>
593
594         Remove some more unused 32-bit code
595         https://bugs.webkit.org/show_bug.cgi?id=195255
596
597         Reviewed by Darin Adler.
598
599         * Plugins/WebNetscapePluginEventHandler.mm:
600         (WebNetscapePluginEventHandler::create):
601         * Plugins/WebNetscapePluginView.h:
602         * Plugins/WebNetscapePluginView.mm:
603         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
604         (-[WebNetscapePluginView restorePortState:]):
605         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
606         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
607         (-[WebNetscapePluginView updateAndSetWindow]):
608         (-[WebNetscapePluginView setWindowIfNecessary]):
609         (-[WebNetscapePluginView createPlugin]):
610         (-[WebNetscapePluginView fini]):
611         (-[WebNetscapePluginView drawRect:]):
612         (-[WebNetscapePluginView invalidateRegion:]):
613         (-[WebNetscapePluginView getVariable:value:]):
614         (-[WebNetscapePluginView setVariable:value:]):
615         (isDrawingModelQuickDraw): Deleted.
616         (-[WebNetscapePluginView fixWindowPort]): Deleted.
617         (getQDPixelFormatForBitmapContext): Deleted.
618         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
619         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
620         * WebView/WebDelegateImplementationCaching.mm:
621
622 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
623
624         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
625         https://bugs.webkit.org/show_bug.cgi?id=195053
626         <rdar://problem/48134710>
627
628         Reviewed by Ryosuke Niwa.
629
630         * WebCoreSupport/WebEditorClient.h:
631
632 2019-03-01  Tim Horton  <timothy_horton@apple.com>
633
634         Remove unused code in WebKitLegacy
635         https://bugs.webkit.org/show_bug.cgi?id=189614
636
637         Reviewed by Simon Fraser.
638
639         * Carbon/CarbonUtils.h: Removed.
640         * Carbon/CarbonUtils.m: Removed.
641         * Carbon/CarbonWindowAdapter.h: Removed.
642         * Carbon/CarbonWindowAdapter.mm: Removed.
643         * Carbon/CarbonWindowContentView.h: Removed.
644         * Carbon/CarbonWindowContentView.m: Removed.
645         * Carbon/CarbonWindowFrame.h: Removed.
646         * Carbon/CarbonWindowFrame.m: Removed.
647         * Carbon/HIViewAdapter.h: Removed.
648         * Carbon/HIViewAdapter.m: Removed.
649         * Carbon/HIWebView.h: Removed.
650         * Carbon/HIWebView.mm: Removed.
651         * Configurations/WebKitLegacy.xcconfig:
652         * WebKit.mac.exp:
653
654 2019-03-01  Justin Fan  <justin_fan@apple.com>
655
656         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
657         https://bugs.webkit.org/show_bug.cgi?id=195191
658
659         Rubber-stamped by Dean Jackson.
660
661         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
662
663         * Configurations/FeatureDefines.xcconfig:
664
665 2019-02-28  Antoine Quint  <graouts@apple.com>
666
667         Enable the Pointer Events runtime flag by default
668         https://bugs.webkit.org/show_bug.cgi?id=195156
669
670         Reviewed by Dean Jackson.
671
672         * WebView/WebPreferences.mm:
673         (+[WebPreferences initialize]):
674
675 2019-02-28  Justin Fan  <justin_fan@apple.com>
676
677         [Web GPU] Enable Web GPU only on 64-bit
678         https://bugs.webkit.org/show_bug.cgi?id=195139
679
680         Because Metal is only supported on 64 bit apps.
681
682         Unreviewed build fix.
683
684         * Configurations/FeatureDefines.xcconfig:
685
686 2019-02-27  Antoine Quint  <graouts@apple.com>
687
688         Support Pointer Events on macOS
689         https://bugs.webkit.org/show_bug.cgi?id=195008
690         <rdar://problem/47454419>
691
692         Reviewed by Dean Jackson.
693
694         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
695
696         * Configurations/FeatureDefines.xcconfig:
697         * WebView/WebPreferenceKeysPrivate.h:
698         * WebView/WebPreferences.mm:
699         (+[WebPreferences initialize]):
700         (-[WebPreferences pointerEventsEnabled]):
701         (-[WebPreferences setPointerEventsEnabled:]):
702         * WebView/WebPreferencesPrivate.h:
703         * WebView/WebView.mm:
704         (-[WebView _preferencesChanged:]):
705
706 2019-02-23  Keith Miller  <keith_miller@apple.com>
707
708         Add new mac target numbers
709         https://bugs.webkit.org/show_bug.cgi?id=194955
710
711         Reviewed by Tim Horton.
712
713         * Configurations/Base.xcconfig:
714         * Configurations/DebugRelease.xcconfig:
715
716 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
717
718         Hardcode Visual Viewports on everywhere except iOS WK1
719         https://bugs.webkit.org/show_bug.cgi?id=194928
720
721         Reviewed by Zalan Bujtas.
722
723         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
724         change the default value of the Setting to 'true', and hardcode WebView on iOS to
725         set it to false. The setting has shipped for several years and there's no need to turn
726         it off now.
727
728         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
729         Visual Viewports are not enabled.
730         
731         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
732         that only runs in WK2
733
734         * WebView/WebPreferenceKeysPrivate.h:
735         * WebView/WebPreferences.mm:
736         (+[WebPreferences initialize]):
737         (-[WebPreferences visualViewportEnabled]): Deleted.
738         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
739         * WebView/WebPreferencesPrivate.h:
740         * WebView/WebView.mm:
741         (-[WebView _preferencesChanged:]):
742
743 2019-02-21  Darin Adler  <darin@apple.com>
744
745         Some refinements for Node and Document
746         https://bugs.webkit.org/show_bug.cgi?id=194764
747
748         Reviewed by Ryosuke Niwa.
749
750         * DOM/DOMDocument.mm:
751         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
752         through to WebCore or even looking at the arguments.
753         (-[DOMDocument getOverrideStyle::]): Ditto.
754
755 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
756
757         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
758         https://bugs.webkit.org/show_bug.cgi?id=194670
759         <rdar://problem/39066529>
760
761         Reviewed by Tim Horton.
762
763         * WebCoreSupport/WebEditorClient.h:
764         * WebCoreSupport/WebEditorClient.mm:
765         (WebEditorClient::replacementURLForResource): Deleted.
766         * WebCoreSupport/WebPlatformStrategies.h:
767         * WebCoreSupport/WebPlatformStrategies.mm:
768         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
769
770 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
771
772         Add MSE logging configuration
773         https://bugs.webkit.org/show_bug.cgi?id=194719
774         <rdar://problem/48122151>
775
776         Reviewed by Joseph Pecoraro.
777
778         * WebCoreSupport/WebChromeClient.mm:
779         (stringForMessageSource): Recognize the MSE message source.
780
781 2019-02-17  David Kilzer  <ddkilzer@apple.com>
782
783         Unreviewed, rolling out r241620.
784
785         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
786         (Requested by ddkilzer on #webkit.)
787
788         Reverted changeset:
789
790         "[WTF] Add environment variable helpers"
791         https://bugs.webkit.org/show_bug.cgi?id=192405
792         https://trac.webkit.org/changeset/241620
793
794 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
795
796         [WTF] Add environment variable helpers
797         https://bugs.webkit.org/show_bug.cgi?id=192405
798
799         Reviewed by Michael Catanzaro.
800
801         * WebView/WebView.mm:
802         (-[WebView _initWithFrame:frameName:groupName:]):
803         Utilize WTF::Environment where possible.
804
805 2019-02-15  Brian Burg  <bburg@apple.com>
806
807         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
808         https://bugs.webkit.org/show_bug.cgi?id=194411
809         <rdar://problem/47787614>
810
811         Reviewed by Joseph Pecoraro.
812
813         * Configurations/WebKitLegacy.xcconfig:
814         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
815
816         * WebCoreSupport/WebInspectorClient.mm:
817         (WebInspectorFrontendClient::localizedStringsURL):
818         (-[WebInspectorWindowController inspectorPagePath]):
819         (-[WebInspectorWindowController inspectorTestPagePath]):
820         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
821
822 2019-02-15  Commit Queue  <commit-queue@webkit.org>
823
824         Unreviewed, rolling out r241559 and r241566.
825         https://bugs.webkit.org/show_bug.cgi?id=194710
826
827         Causes layout test crashes under GuardMalloc (Requested by
828         ryanhaddad on #webkit).
829
830         Reverted changesets:
831
832         "[WTF] Add environment variable helpers"
833         https://bugs.webkit.org/show_bug.cgi?id=192405
834         https://trac.webkit.org/changeset/241559
835
836         "Unreviewed build fix for WinCairo Debug after r241559."
837         https://trac.webkit.org/changeset/241566
838
839 2019-02-15  Truitt Savell  <tsavell@apple.com>
840
841         Unreviewed, rolling out r241564.
842
843         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
844
845         Reverted changeset:
846
847         "[Mac] WebInspectorUI.framework does not need to be soft-
848         linked anymore"
849         https://bugs.webkit.org/show_bug.cgi?id=194411
850         https://trac.webkit.org/changeset/241564
851
852 2019-02-14  Brian Burg  <bburg@apple.com>
853
854         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
855         https://bugs.webkit.org/show_bug.cgi?id=194411
856         <rdar://problem/47787614>
857
858         Reviewed by Joseph Pecoraro.
859
860         * Configurations/WebKitLegacy.xcconfig:
861         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
862
863         * WebCoreSupport/WebInspectorClient.mm:
864         (WebInspectorFrontendClient::localizedStringsURL):
865         (-[WebInspectorWindowController inspectorPagePath]):
866         (-[WebInspectorWindowController inspectorTestPagePath]):
867         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
868
869 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
870
871         [WTF] Add environment variable helpers
872         https://bugs.webkit.org/show_bug.cgi?id=192405
873
874         Reviewed by Michael Catanzaro.
875
876         * WebView/WebView.mm:
877         (-[WebView _initWithFrame:frameName:groupName:]):
878         Utilize WTF::Environment where possible.
879
880 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
881
882         Allow pages to trigger programmatic paste from script on iOS
883         https://bugs.webkit.org/show_bug.cgi?id=194271
884         <rdar://problem/47808810>
885
886         Reviewed by Ryosuke Niwa.
887
888         See WebCore and WebKit ChangeLogs for more details.
889
890         * WebCoreSupport/WebEditorClient.h:
891
892 2019-02-12  Andy Estes  <aestes@apple.com>
893
894         [iOSMac] Enable Parental Controls Content Filtering
895         https://bugs.webkit.org/show_bug.cgi?id=194521
896         <rdar://39732376>
897
898         Reviewed by Tim Horton.
899
900         * Configurations/FeatureDefines.xcconfig:
901
902 2019-02-06  Andy Estes  <aestes@apple.com>
903
904         [Payment Request] It should be possible to require a phonetic name for shipping contacts
905         https://bugs.webkit.org/show_bug.cgi?id=194311
906         <rdar://46733045>
907
908         Reviewed by Alex Christensen.
909
910         * WebCoreSupport/WebPaymentCoordinatorClient.h:
911         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
912         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
913
914 2019-02-04  Said Abou-Hallawa  <said@apple.com>
915
916         [CG] Enable setAdditionalSupportedImageTypes for WK1
917         https://bugs.webkit.org/show_bug.cgi?id=194190
918
919         Reviewed by Tim Horton.
920
921         1. Define the preferences key AdditionalSupportedImageTypes.
922         2. Add additionalSupportedImageTypes as a private preference property.
923         3. Define the setter and the getter of the property.
924         4. Add function to convert from an id to an array of strings.
925         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
926
927         * WebView/WebPreferenceKeysPrivate.h:
928         * WebView/WebPreferences.mm:
929         (-[WebPreferences _stringArrayValueForKey:]):
930         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
931         (-[WebPreferences setAdditionalSupportedImageTypes:]):
932         (-[WebPreferences additionalSupportedImageTypes]):
933         * WebView/WebPreferencesPrivate.h:
934         * WebView/WebView.mm:
935         (-[WebView _preferencesChanged:]):
936
937 2019-02-04  Timothy Hatcher  <timothy@apple.com>
938
939         Add WebView SPI to temporarily force light or dark appearance on a page.
940         https://bugs.webkit.org/show_bug.cgi?id=194230
941
942         Reviewed by Tim Horton.
943
944         * WebView/WebView.mm:
945         (-[WebView _useDarkAppearance:]): Added.
946         (-[WebView _setUseDarkAppearance:]): Added.
947         * WebView/WebViewPrivate.h:
948
949 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
950
951         PageOverlayController's layers should be created lazily
952         https://bugs.webkit.org/show_bug.cgi?id=194199
953         rdar://problem/46571593
954
955         Reviewed by Tim Horton.
956
957         * WebCoreSupport/WebChromeClient.h:
958         * WebCoreSupport/WebChromeClient.mm:
959         (WebChromeClient::attachViewOverlayGraphicsLayer):
960
961 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
962
963         Make setNeedsLayout on the root more explicitly about triggering its side-effects
964         https://bugs.webkit.org/show_bug.cgi?id=194198
965
966         Reviewed by Antti Koivisto.
967
968         Call the newly named functions.
969
970         * WebView/WebFrame.mm:
971         (-[WebFrame setNeedsLayout]):
972         * WebView/WebHTMLView.mm:
973         (-[WebHTMLView setNeedsLayout:]):
974
975 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
976
977         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
978         https://bugs.webkit.org/show_bug.cgi?id=194189
979
980         Reviewed by Geoffrey Garen.
981
982         Pass the policy check identifier around functions and store it in WebFramePolicyListener
983         so that we can send it back to WebCore with the navigation policy decision.
984
985         * WebCoreSupport/WebFrameLoaderClient.h:
986         * WebCoreSupport/WebFrameLoaderClient.mm:
987         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
988         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
989         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
990         (WebFrameLoaderClient::dispatchWillSubmitForm):
991         (WebFrameLoaderClient::setUpPolicyListener):
992         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
993         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
994         (-[WebFramePolicyListener invalidate]):
995         (-[WebFramePolicyListener dealloc]):
996         (-[WebFramePolicyListener receivedPolicyDecision:]):
997         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
998         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
999
1000 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1001
1002         Revert r238819 which is unneeded and caused a performance regression.
1003         https://bugs.webkit.org/show_bug.cgi?id=192272
1004         <rdar://problem/46664625>
1005
1006         * WebCoreSupport/WebFrameLoaderClient.h:
1007         * WebCoreSupport/WebFrameLoaderClient.mm:
1008         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1009
1010 2019-01-28  Devin Rousso  <drousso@apple.com>
1011
1012         Web Inspector: provide a way to edit page WebRTC settings on a remote target
1013         https://bugs.webkit.org/show_bug.cgi?id=193863
1014         <rdar://problem/47572764>
1015
1016         Reviewed by Joseph Pecoraro.
1017
1018         * WebView/WebView.mm:
1019         (-[WebView _preferencesChanged:]):
1020         Add page-level settings for WebRTC preferences.
1021
1022 2019-01-28  Andy Estes  <aestes@apple.com>
1023
1024         [watchOS] Enable Parental Controls content filtering
1025         https://bugs.webkit.org/show_bug.cgi?id=193939
1026         <rdar://problem/46641912>
1027
1028         Reviewed by Ryosuke Niwa.
1029
1030         * Configurations/FeatureDefines.xcconfig:
1031
1032 2019-01-28  Timothy Hatcher  <timothy@apple.com>
1033
1034         Make it easier for non-Apple ports to enable dark mode CSS support.
1035         https://bugs.webkit.org/show_bug.cgi?id=193882
1036
1037         Reviewed by Megan Gardner.
1038
1039         * WebView/WebView.mm:
1040         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
1041         (-[WebView _effectiveAppearanceIsDark]): Ditto.
1042
1043 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1044
1045         AX: Introduce a static accessibility tree
1046         https://bugs.webkit.org/show_bug.cgi?id=193348
1047         <rdar://problem/47203295>
1048
1049         Reviewed by Ryosuke Niwa.
1050
1051         * Configurations/FeatureDefines.xcconfig:
1052
1053 2019-01-25  Keith Rollin  <krollin@apple.com>
1054
1055         Update WebKitAdditions.xcconfig with correct order of variable definitions
1056         https://bugs.webkit.org/show_bug.cgi?id=193793
1057         <rdar://problem/47532439>
1058
1059         Reviewed by Alex Christensen.
1060
1061         XCBuild changes the way xcconfig variables are evaluated. In short,
1062         all config file assignments are now considered in part of the
1063         evaluation. When using the new build system and an .xcconfig file
1064         contains multiple assignments of the same build setting:
1065
1066         - Later assignments using $(inherited) will inherit from earlier
1067           assignments in the xcconfig file.
1068         - Later assignments not using $(inherited) will take precedence over
1069           earlier assignments. An assignment to a more general setting will
1070           mask an earlier assignment to a less general setting. For example,
1071           an assignment without a condition ('FOO = bar') will completely mask
1072           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
1073
1074         This affects some of our .xcconfig files, in that sometimes platform-
1075         or sdk-specific definitions appear before the general definitions.
1076         Under the new evaluations rules, the general definitions alway take
1077         effect because they always overwrite the more-specific definitions. The
1078         solution is to swap the order, so that the general definitions are
1079         established first, and then conditionally overwritten by the
1080         more-specific definitions.
1081
1082         * Configurations/Version.xcconfig:
1083         * Configurations/WebKitLegacy.xcconfig:
1084
1085 2019-01-25  David Kilzer  <ddkilzer@apple.com>
1086
1087         Move soft-linking of Lookup.framework out of LookupSPI.h
1088         <https://webkit.org/b/193815>
1089
1090         Reviewed by Tim Horton.
1091
1092         * WebView/WebImmediateActionController.mm:
1093         (-[WebImmediateActionController _animationControllerForText]):
1094         * WebView/WebView.mm:
1095         (-[WebView _prepareForDictionaryLookup]):
1096         - Move soft-linking to LookupSoftLink.{h,mm}.
1097
1098 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1099
1100         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
1101         https://bugs.webkit.org/show_bug.cgi?id=193829
1102
1103         Reviewed by Tim Horton.
1104
1105         * WebCoreSupport/WebDragClient.mm:
1106         (WebDragClient::didConcludeEditDrag):
1107         * WebView/WebView.mm:
1108         (-[WebView _requestStartDataInteraction:globalPosition:]):
1109         (-[WebView _didConcludeEditDrag]):
1110         (-[WebView _didConcludeEditDataInteraction]): Deleted.
1111         * WebView/WebViewInternal.h:
1112
1113 2019-01-24  John Wilander  <wilander@apple.com>
1114
1115         Add Ad Click Attribution as an internal/experimental feature
1116         https://bugs.webkit.org/show_bug.cgi?id=193685
1117         <rdar://problem/47450399>
1118
1119         Reviewed by Brent Fulgham.
1120
1121         * WebView/WebPreferenceKeysPrivate.h:
1122         * WebView/WebPreferences.mm:
1123         (+[WebPreferences initialize]):
1124         (-[WebPreferences adClickAttributionEnabled]):
1125         (-[WebPreferences setAdClickAttributionEnabled:]):
1126             Added support for experimental ad click attribution.
1127         * WebView/WebPreferencesPrivate.h:
1128         * WebView/WebView.mm:
1129         (-[WebView _preferencesChanged:]):
1130
1131 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1132
1133         Move FileSystem to WTF
1134         https://bugs.webkit.org/show_bug.cgi?id=193602
1135
1136         Reviewed by Yusuke Suzuki.
1137
1138         * Misc/WebNSFileManagerExtras.mm:
1139         * Storage/WebDatabaseProvider.mm:
1140         * WebView/WebView.mm:
1141
1142 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
1143
1144         Fix the Apple Internal build. See <rdar://problem/47491383>.
1145
1146         Rubber-stamped by Tim Horton.
1147
1148         * WebCoreSupport/WebFrameLoaderClient.mm:
1149
1150 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
1151
1152         Clean up USE(WEB_THREAD)
1153         https://bugs.webkit.org/show_bug.cgi?id=193698
1154
1155         Rubber-stamped by Tim Horton.
1156
1157         * Misc/WebCache.mm:
1158         (+[WebCache emptyInMemoryResources]):
1159         * WebCoreSupport/WebFrameLoaderClient.mm:
1160         (-[WebFramePolicyListener use]):
1161         * WebCoreSupport/WebGeolocationClient.mm:
1162         (-[WebGeolocationPolicyListener allow]):
1163         (-[WebGeolocationPolicyListener deny]):
1164         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
1165         * WebView/WebFrame.mm:
1166         (-[WebFrame deviceOrientationChanged]):
1167         * WebView/WebHTMLView.mm:
1168         (hardwareKeyboardAvailabilityChangedCallback):
1169         * WebView/WebView.mm:
1170         (+[WebView _releaseMemoryNow]):
1171         (+[WebView willEnterBackgroundWithCompletionHandler:]):
1172         (-[WebView updateLayoutIgnorePendingStyleSheets]):
1173         (-[WebView _dispatchUnloadEvent]):
1174         (-[WebView _close]):
1175         (-[WebView _preferencesChangedNotification:]):
1176         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1177         (-[WebView goBack]):
1178         (-[WebView goForward]):
1179         (+[WebView _cacheModelChangedNotification:]):
1180         (-[WebView stopLoading:]):
1181         (-[WebView stopLoadingAndClear]):
1182         (-[WebView reload:]):
1183         (WebInstallMemoryPressureHandler):
1184
1185 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1186
1187         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
1188         https://bugs.webkit.org/show_bug.cgi?id=193706
1189         <rdar://problem/44807048>
1190
1191         Reviewed by Ryosuke Niwa.
1192
1193         Use UndoStep::label().
1194
1195         * WebCoreSupport/WebEditorClient.h:
1196         * WebCoreSupport/WebEditorClient.mm:
1197         (-[WebUndoStep initWithUndoStep:]):
1198         (+[WebUndoStep stepWithUndoStep:]):
1199         (WebEditorClient::registerUndoOrRedoStep):
1200         (WebEditorClient::registerUndoStep):
1201         (WebEditorClient::registerRedoStep):
1202
1203 2019-01-22  Alex Christensen  <achristensen@webkit.org>
1204
1205         Move NetworkStorageSession ownership to NetworkProcess
1206         https://bugs.webkit.org/show_bug.cgi?id=193580
1207
1208         Reviewed by Geoff Garen.
1209
1210         * Misc/WebCache.mm:
1211         (+[WebCache clearCachedCredentials]):
1212         * Misc/WebDownload.mm:
1213         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1214         * Plugins/WebBaseNetscapePluginView.mm:
1215         (WebKit::getAuthenticationInfo):
1216         * WebCoreSupport/WebFrameNetworkingContext.mm:
1217         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1218         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1219         (WebFrameNetworkingContext::storageSession const):
1220         * WebView/WebPreferences.mm:
1221         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1222         (+[WebPreferences _clearNetworkLoaderSession]):
1223         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1224
1225 2019-01-22  Daniel Bates  <dabates@apple.com>
1226
1227         [iOS] Interpret text key commands on keydown and app key commands on keypress
1228         https://bugs.webkit.org/show_bug.cgi?id=192897
1229         <rdar://problem/46857378>
1230
1231         Reviewed by Brent Fulgham.
1232
1233         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
1234         is false) and keypress (isCharEvent is true), respectively.
1235
1236         * WebView/WebHTMLView.mm:
1237         (-[WebHTMLView _handleEditingKeyEvent:]):
1238
1239 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1240
1241         [css-logical] Implement flow-relative margin, padding and border shorthands
1242         https://bugs.webkit.org/show_bug.cgi?id=188697
1243
1244         Reviewed by Simon Fraser and Antti Koivisto.
1245
1246         Add CSSLogicalEnabled runtime flag.
1247
1248         * WebView/WebPreferenceKeysPrivate.h:
1249         * WebView/WebPreferences.mm:
1250         (+[WebPreferences initialize]):
1251         (-[WebPreferences cssLogicalEnabled]):
1252         (-[WebPreferences setCSSLogicalEnabled:]):
1253         * WebView/WebPreferencesPrivate.h:
1254         * WebView/WebView.mm:
1255         (-[WebView _preferencesChanged:]):
1256
1257 2019-01-15  Darin Adler  <darin@apple.com>
1258
1259         Use references rather than pointers for register/unregister functions, and more
1260         https://bugs.webkit.org/show_bug.cgi?id=175028
1261
1262         Reviewed by Daniel Bates.
1263
1264         * WebCoreSupport/WebKitFullScreenListener.mm:
1265         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1266         functions in Document; pass a reference.
1267         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1268         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1269         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1270         * WebView/WebFullScreenController.mm:
1271         (-[WebFullScreenController enterFullScreen:]): Ditto.
1272         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1273         (-[WebFullScreenController exitFullScreen]): Ditto.
1274         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1275         * WebView/WebFullScreenController.mm:
1276         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1277
1278 2019-01-12  Dan Bernstein  <mitz@apple.com>
1279
1280         [Cocoa] Avoid importing directly from subumbrella frameworks
1281         https://bugs.webkit.org/show_bug.cgi?id=186016
1282         <rdar://problem/40591038>
1283
1284         Reviewed by Sam Weinig.
1285
1286         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1287         * Carbon/CarbonWindowAdapter.mm: Ditto.
1288         * Carbon/CarbonWindowFrame.m: Ditto.
1289         * Carbon/HIViewAdapter.h: Ditto.
1290         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1291           OTHER_CFLAGS_COCOA_TOUCH_NO.
1292         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1293         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1294         * WebView/WebPDFView.h: Ditto.
1295
1296 2019-01-20  Antoine Quint  <graouts@apple.com>
1297
1298         Add a POINTER_EVENTS feature flag
1299         https://bugs.webkit.org/show_bug.cgi?id=193577
1300         <rdar://problem/47408511>
1301
1302         Unreviewed. Also enable Pointer Events for iosmac.
1303
1304         * Configurations/FeatureDefines.xcconfig:
1305
1306 2019-01-19  Antoine Quint  <graouts@apple.com>
1307
1308         Add a POINTER_EVENTS feature flag
1309         https://bugs.webkit.org/show_bug.cgi?id=193577
1310
1311         Reviewed by Dean Jackson.
1312
1313         * Configurations/FeatureDefines.xcconfig:
1314
1315 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1316
1317         Revert r238815, it broke WK1 video fullscreen on Mac
1318         https://bugs.webkit.org/show_bug.cgi?id=193586
1319         <rdar://problem/47358941>
1320
1321         Reviewed by Jer Noble.
1322
1323         * WebView/WebVideoFullscreenController.h: Added.
1324         * WebView/WebVideoFullscreenController.mm: Added.
1325         (SOFT_LINK_CLASS):
1326         (-[WebVideoFullscreenController init]):
1327         (-[WebVideoFullscreenController dealloc]):
1328         (-[WebVideoFullscreenController fullscreenWindow]):
1329         (-[WebVideoFullscreenController windowDidLoad]):
1330         (-[WebVideoFullscreenController videoElement]):
1331         (-[WebVideoFullscreenController setVideoElement:]):
1332         (-[WebVideoFullscreenController clearFadeAnimation]):
1333         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1334         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1335         (-[WebVideoFullscreenController videoElementRect]):
1336         (-[WebVideoFullscreenController applicationDidResignActive:]):
1337         (frameExpandedToRatioOfFrame):
1338         (createBackgroundFullscreenWindow):
1339         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1340         (-[WebVideoFullscreenController enterFullscreen:]):
1341         (-[WebVideoFullscreenController exitFullscreen]):
1342         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1343         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1344         (-[WebVideoFullscreenController _requestExit]):
1345         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1346         (-[WebVideoFullscreenController requestExitFullscreen]):
1347         (-[WebVideoFullscreenController fadeHUDIn]):
1348         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1349         (-[WebVideoFullscreenController rateChanged:]):
1350         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1351         (-[WebVideoFullscreenWindow dealloc]):
1352         (-[WebVideoFullscreenWindow resignFirstResponder]):
1353         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1354         (-[WebVideoFullscreenWindow mouseDown:]):
1355         (-[WebVideoFullscreenWindow cancelOperation:]):
1356         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1357         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1358         (-[WebVideoFullscreenWindow animationDidEnd:]):
1359         (-[WebVideoFullscreenWindow mouseMoved:]):
1360         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1361         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1362         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1363         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1364         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1365         (-[WebVideoFullscreenHUDWindow center]):
1366         (-[WebVideoFullscreenHUDWindow keyDown:]):
1367         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1368         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1369         (-[WebVideoFullscreenHUDWindowController init]):
1370         (-[WebVideoFullscreenHUDWindowController dealloc]):
1371         (-[WebVideoFullscreenHUDWindowController setArea:]):
1372         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1373         (-[WebVideoFullscreenHUDWindowController delegate]):
1374         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1375         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1376         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1377         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1378         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1379         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1380         (createMediaUIControl):
1381         (createControlWithMediaUIControlType):
1382         (createTimeTextField):
1383         (createMediaUIBackgroundView):
1384         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1385         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1386         (-[WebVideoFullscreenHUDWindowController updateTime]):
1387         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1388         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1389         (-[WebVideoFullscreenHUDWindowController currentTime]):
1390         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1391         (-[WebVideoFullscreenHUDWindowController duration]):
1392         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1393         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1394         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1395         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1396         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1397         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1398         (-[WebVideoFullscreenHUDWindowController volume]):
1399         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1400         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1401         (-[WebVideoFullscreenHUDWindowController updateRate]):
1402         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1403         (-[WebVideoFullscreenHUDWindowController playing]):
1404         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1405         (timeToString):
1406         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1407         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1408         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1409         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1410         (-[WebVideoFullscreenHUDWindowController rewind:]):
1411         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1412         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1413         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1414         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1415         * WebView/WebView.mm:
1416         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1417         (-[WebView _exitVideoFullscreen]):
1418
1419 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1420
1421         Get rid of ADVANCED_SPELL_CHECKING
1422         https://bugs.webkit.org/show_bug.cgi?id=193592
1423
1424         Reviewed by Wenson Hsieh.
1425
1426         * WebCoreSupport/WebEditorClient.mm:
1427         (insertionPointFromCurrentSelection):
1428         (WebEditorClient::checkTextOfParagraph):
1429         (WebEditorClient::getGuessesForWord):
1430         (WebEditorClient::requestCandidatesForSelection):
1431         (WebEditorClient::requestCheckingOfString):
1432         * WebView/WebHTMLView.mm:
1433         (-[WebHTMLView insertText:]):
1434
1435 2019-01-18  Jer Noble  <jer.noble@apple.com>
1436
1437         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1438         https://bugs.webkit.org/show_bug.cgi?id=189553
1439
1440         Reviewed by Tim Horton.
1441
1442         * Configurations/Base.xcconfig:
1443         * Configurations/SDKVariant.xcconfig: Added.
1444         * Configurations/WebKitLegacy.xcconfig:
1445
1446 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1447
1448         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1449         <https://webkit.org/b/193568>
1450         <rdar://problem/47381130>
1451
1452         Reviewed by Alex Christensen.
1453
1454         * WebView/WebView.mm:
1455         - Remove unused soft-linking macros.
1456         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1457         (-[WebUITextIndicatorData initWithImage:scale:]):
1458         - Update to use exported PAL functions.
1459
1460 2019-01-17  Truitt Savell  <tsavell@apple.com>
1461
1462         Unreviewed, rolling out r240124.
1463
1464         This commit broke an internal build.
1465
1466         Reverted changeset:
1467
1468         "SDK_VARIANT build destinations should be separate from non-
1469         SDK_VARIANT builds"
1470         https://bugs.webkit.org/show_bug.cgi?id=189553
1471         https://trac.webkit.org/changeset/240124
1472
1473 2019-01-17  Jer Noble  <jer.noble@apple.com>
1474
1475         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1476         https://bugs.webkit.org/show_bug.cgi?id=189553
1477
1478         Reviewed by Tim Horton.
1479
1480         * Configurations/Base.xcconfig:
1481         * Configurations/SDKVariant.xcconfig: Added.
1482         * Configurations/WebKitLegacy.xcconfig:
1483
1484 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1485
1486         Stop using NetworkStorageSession::storageSession in WebCore
1487         https://bugs.webkit.org/show_bug.cgi?id=193529
1488
1489         Reviewed by Tim Horton.
1490
1491         * Misc/WebCache.mm:
1492         (+[WebCache addImageToCache:forURL:forFrame:]):
1493         * WebView/WebView.mm:
1494         (-[WebView _commonInitializationWithFrameName:groupName:]):
1495         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1496
1497 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1498
1499         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1500         https://bugs.webkit.org/show_bug.cgi?id=193368
1501
1502         Reviewed by Geoff Garen.
1503
1504         * Misc/WebCache.mm:
1505         (+[WebCache clearCachedCredentials]):
1506         * Misc/WebDownload.mm:
1507         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1508         * Plugins/WebBaseNetscapePluginView.mm:
1509         (WebKit::getAuthenticationInfo):
1510
1511 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1512
1513         Stop using CookiesStrategy
1514         https://bugs.webkit.org/show_bug.cgi?id=161106
1515
1516         Reviewed by Don Olmstead and Antti Koivisto.
1517
1518         * Misc/WebCache.mm:
1519         (+[WebCache addImageToCache:forURL:forFrame:]):
1520         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1521         (WebKit::NetscapePluginInstanceProxy::getCookies):
1522         (WebKit::NetscapePluginInstanceProxy::setCookies):
1523         * Plugins/WebNetscapePluginView.mm:
1524         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1525         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1526         * WebCoreSupport/WebPlatformStrategies.h:
1527         * WebCoreSupport/WebPlatformStrategies.mm:
1528         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1529         (WebPlatformStrategies::cookiesForDOM): Deleted.
1530         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1531         (WebPlatformStrategies::cookiesEnabled): Deleted.
1532         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1533         (WebPlatformStrategies::getRawCookies): Deleted.
1534         (WebPlatformStrategies::deleteCookie): Deleted.
1535         * WebView/WebView.mm:
1536         (-[WebView _commonInitializationWithFrameName:groupName:]):
1537         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1538
1539 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1540
1541         Cannot tab out of WKWebView on macOS
1542         https://bugs.webkit.org/show_bug.cgi?id=161448
1543         <rdar://problem/28100085>
1544
1545         Reviewed by Dean Jackson.
1546
1547         * WebCoreSupport/WebChromeClient.mm:
1548         * WebView/WebView.mm:
1549         Make use of SPI headers.
1550
1551 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1552
1553         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1554         r239913, and r239914.
1555         https://bugs.webkit.org/show_bug.cgi?id=193407
1556
1557         These revisions caused an internal failure (Requested by
1558         Truitt on #webkit).
1559
1560         Reverted changesets:
1561
1562         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1563         https://bugs.webkit.org/show_bug.cgi?id=186016
1564         https://trac.webkit.org/changeset/239901
1565
1566         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1567         https://trac.webkit.org/changeset/239909
1568
1569         "Tried to fix the build."
1570         https://trac.webkit.org/changeset/239910
1571
1572         "Fixed iOS builds after r239910."
1573         https://trac.webkit.org/changeset/239912
1574
1575         "More build fixing."
1576         https://trac.webkit.org/changeset/239913
1577
1578         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1579         https://trac.webkit.org/changeset/239914
1580
1581 2019-01-14  Mark Lam  <mark.lam@apple.com>
1582
1583         Re-enable ability to build --cloop builds.
1584         https://bugs.webkit.org/show_bug.cgi?id=192955
1585         <rdar://problem/46882363>
1586
1587         Reviewed by Saam barati and Keith Miller.
1588
1589         * Configurations/FeatureDefines.xcconfig:
1590
1591 2019-01-13  Dan Bernstein  <mitz@apple.com>
1592
1593         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1594
1595         Patch by Keith Rollin.
1596
1597         * WebView/PDFViewSPI.h:
1598
1599 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1600
1601         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1602         https://bugs.webkit.org/show_bug.cgi?id=191655
1603         rdar://problem/46074680
1604
1605         Reviewed by Megan Gardner.
1606
1607         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1608         * WebView/WebView.mm:
1609         (-[WebView _effectiveAppearanceIsDark]):
1610
1611 2019-01-12  Dan Bernstein  <mitz@apple.com>
1612
1613         [Cocoa] Avoid importing directly from subumbrella frameworks
1614         https://bugs.webkit.org/show_bug.cgi?id=186016
1615         <rdar://problem/40591038>
1616
1617         Reviewed by Sam Weinig.
1618
1619         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1620         * Carbon/CarbonWindowAdapter.mm: Ditto.
1621         * Carbon/CarbonWindowFrame.m: Ditto.
1622         * Carbon/HIViewAdapter.h: Ditto.
1623         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1624           OTHER_CFLAGS_COCOA_TOUCH_NO.
1625         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1626         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1627         * WebView/WebPDFView.h: Ditto.
1628
1629 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1630
1631         Enable visual viewport API by default
1632         https://bugs.webkit.org/show_bug.cgi?id=193376
1633
1634         Reviewed by Simon Fraser.
1635
1636         * WebView/WebPreferences.mm:
1637         (+[WebPreferences initialize]):
1638
1639 2019-01-11  John Wilander  <wilander@apple.com>
1640
1641         Compile out Web API Statistics Collection
1642         https://bugs.webkit.org/show_bug.cgi?id=193370
1643         <rdar://problem/45388584>
1644
1645         Reviewed by Brent Fulgham.
1646
1647         * Configurations/FeatureDefines.xcconfig:
1648             Defined ENABLE_WEB_API_STATISTICS, off by default.
1649
1650 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1651
1652         Stop using NetworkStorageSession in WebProcess
1653         https://bugs.webkit.org/show_bug.cgi?id=193236
1654
1655         Reviewed by Don Olmstead.
1656
1657         * WebCoreSupport/WebFrameNetworkingContext.h:
1658         * WebCoreSupport/WebFrameNetworkingContext.mm:
1659         (WebFrameNetworkingContext::storageSession const):
1660         * WebCoreSupport/WebPlatformStrategies.h:
1661         * WebCoreSupport/WebPlatformStrategies.mm:
1662         (WebPlatformStrategies::cookiesForDOM):
1663         (WebPlatformStrategies::setCookiesFromDOM):
1664         (WebPlatformStrategies::cookiesEnabled):
1665         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1666         (WebPlatformStrategies::getRawCookies):
1667         (WebPlatformStrategies::deleteCookie):
1668         * WebView/WebView.mm:
1669         (-[WebView _cachedResponseForURL:]):
1670         (-[WebView _clearCredentials]):
1671
1672 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1673
1674         Unreviewed, rolling out r239727.
1675
1676         Broke API tests
1677
1678         Reverted changeset:
1679
1680         "Stop using NetworkStorageSession in WebProcess"
1681         https://bugs.webkit.org/show_bug.cgi?id=193236
1682         https://trac.webkit.org/changeset/239727
1683
1684 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1685
1686         Stop using NetworkStorageSession in WebProcess
1687         https://bugs.webkit.org/show_bug.cgi?id=193236
1688
1689         Reviewed by Don Olmstead.
1690
1691         * WebCoreSupport/WebFrameNetworkingContext.h:
1692         * WebCoreSupport/WebFrameNetworkingContext.mm:
1693         (WebFrameNetworkingContext::storageSession const):
1694         * WebView/WebView.mm:
1695         (-[WebView _cachedResponseForURL:]):
1696         (-[WebView _clearCredentials]):
1697
1698 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1699
1700         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1701         <https://webkit.org/b/193056>
1702
1703         Reviewed by Alex Christensen.
1704
1705         * Plugins/Hosted/NetscapePluginHostProxy.h:
1706         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1707         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1708         (WebKit::NetscapePluginInstanceProxy::enumerate):
1709         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1710         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1711         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1712         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1713         * Plugins/Hosted/ProxyInstance.mm:
1714         (WebKit::ProxyInstance::invoke):
1715         * WebCoreSupport/WebGeolocationClient.mm:
1716         * WebView/WebDataSource.mm:
1717         (-[WebDataSource _receivedData:]):
1718         * WebView/WebView.mm:
1719         (-[WebView _cachedResponseForURL:]):
1720         - Remove '*' from RetainPtr<> type.
1721
1722 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1723
1724         Progress towards fixing Mac CMake build
1725         https://bugs.webkit.org/show_bug.cgi?id=193105
1726
1727         Reviewed by Don Olmstead.
1728
1729         * WebKitPrefix.h:
1730
1731 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1732
1733         Web Inspector: Use save sheet instead of dialog where possible
1734         https://bugs.webkit.org/show_bug.cgi?id=193160
1735         <rdar://problem/37399759>
1736
1737         Reviewed by Devin Rousso.
1738
1739         * WebCoreSupport/WebInspectorClient.mm:
1740         (WebInspectorFrontendClient::save):
1741
1742 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1743
1744         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1745         https://bugs.webkit.org/show_bug.cgi?id=193129
1746
1747         Reviewed by Tim Horton.
1748
1749         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1750
1751         * WebCoreSupport/WebEditorClient.mm:
1752         (WebEditorClient::registerUndoOrRedoStep):
1753         (undoNameForEditAction): Deleted.
1754
1755 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1756
1757         Add support for using the current text selection as the find string on iOS
1758         https://bugs.webkit.org/show_bug.cgi?id=193034
1759         <rdar://problem/45138739>
1760
1761         Reviewed by Tim Horton.
1762
1763         Add a method stub for WebKitLegacy.
1764
1765         * WebCoreSupport/WebEditorClient.h:
1766
1767 2019-01-01  Jeff Miller  <jeffm@apple.com>
1768
1769         Update user-visible copyright strings to include 2019
1770         https://bugs.webkit.org/show_bug.cgi?id=192811
1771
1772         Reviewed by Mark Lam.
1773
1774         * Info.plist:
1775
1776 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1777
1778         Use Ref<> as much as possible
1779         https://bugs.webkit.org/show_bug.cgi?id=192808
1780
1781         Reviewed by Alex Christensen.
1782
1783         * DOM/DOM.mm:
1784         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1785         * Plugins/Hosted/NetscapePluginHostManager.mm:
1786         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1787         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1788         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1789         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1790         * Plugins/WebNetscapePluginView.mm:
1791         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1792         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1793         * WebCoreSupport/WebContextMenuClient.mm:
1794         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1795         * WebCoreSupport/WebFrameLoaderClient.mm:
1796         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1797         * WebView/WebFrame.mm:
1798         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1799         * WebView/WebHTMLView.mm:
1800         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1801         * WebView/WebView.mm:
1802         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1803         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1804
1805 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1806
1807         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1808         https://bugs.webkit.org/show_bug.cgi?id=192821
1809
1810         Reviewed by Chris Dumez.
1811
1812         When a window becomes occluded, the window server informs the application.
1813         This should be used to suspend any work that is not visible by the user.
1814
1815         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1816         In some cases, that lead to performance impact (see radar).
1817
1818         This patch adds an observer for the occlusion notification. I tried to stick
1819         with the same names used by WebKit2.
1820
1821         * WebView/WebView.mm:
1822         (-[WebView _isViewVisible]):
1823         (-[WebView addWindowObserversForWindow:]):
1824         (-[WebView removeWindowObservers]):
1825         (-[WebView _windowDidChangeOcclusionState:]):
1826
1827 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1828
1829         [WebAuthN] Add a runtime flag for local authenticator
1830         https://bugs.webkit.org/show_bug.cgi?id=192792
1831         <rdar://problem/46798738>
1832
1833         Reviewed by Brent Fulgham.
1834
1835         * WebView/WebPreferenceKeysPrivate.h:
1836         * WebView/WebPreferences.mm:
1837         (+[WebPreferences initialize]):
1838         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1839         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1840         * WebView/WebPreferencesPrivate.h:
1841         * WebView/WebView.mm:
1842         (-[WebView _preferencesChanged:]):
1843
1844 2018-12-20  Chris Dumez  <cdumez@apple.com>
1845
1846         Use Optional::valueOr() instead of Optional::value_or()
1847         https://bugs.webkit.org/show_bug.cgi?id=192933
1848
1849         Reviewed by Geoffrey Garen.
1850
1851         * WebCoreSupport/WebSecurityOrigin.mm:
1852         (-[WebSecurityOrigin port]):
1853
1854 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1855
1856         Unreviewed, rolling out r239417.
1857
1858         Introduced two API test failures on macOS.
1859
1860         Reverted changeset:
1861
1862         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1863         occlusion changes"
1864         https://bugs.webkit.org/show_bug.cgi?id=192821
1865         https://trac.webkit.org/changeset/239417
1866
1867 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1868
1869         WKWebView default UA doesn't freeze the build number
1870         https://bugs.webkit.org/show_bug.cgi?id=192809
1871         <rdar://problem/44687185>
1872
1873         Reviewed by Andy Estes.
1874
1875         Always reports the frozen build number.
1876
1877         * WebView/WebView.mm:
1878         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1879         actual build number through this method call.
1880         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1881
1882 2018-12-19  Chris Dumez  <cdumez@apple.com>
1883
1884         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1885         https://bugs.webkit.org/show_bug.cgi?id=192728
1886         <rdar://problem/46746779>
1887
1888         Reviewed by Geoff Garen.
1889
1890         * DOM/*:
1891         * Plugins/*:
1892         * WebCoreSupport/*:
1893         * WebView/*:
1894
1895 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1896
1897         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1898         https://bugs.webkit.org/show_bug.cgi?id=192821
1899
1900         Reviewed by Chris Dumez.
1901
1902         When a window becomes occluded, the window server informs the application.
1903         This should be used to suspend any work that is not visible by the user.
1904
1905         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1906         In some cases, that lead to performance impact (see radar).
1907
1908         This patch adds an observer for the occlusion notification. I tried to stick
1909         with the same names used by WebKit2.
1910
1911         * WebView/WebView.mm:
1912         (-[WebView _isViewVisible]):
1913         (-[WebView addWindowObserversForWindow:]):
1914         (-[WebView removeWindowObservers]):
1915         (-[WebView _windowDidChangeOcclusionState:]):
1916
1917 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1918
1919         Allow clients to set the navigator platform
1920         https://bugs.webkit.org/show_bug.cgi?id=192735
1921
1922         Reviewed by Tim Horton.
1923
1924         Add stubs to fill out the added functionality in FrameLoaderClient.
1925
1926         * WebCoreSupport/WebFrameLoaderClient.h:
1927         * WebCoreSupport/WebFrameLoaderClient.mm:
1928         (WebFrameLoaderClient::navigatorPlatform):
1929
1930 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1931
1932         offsetLeft and offsetParent should adjust across shadow boundaries
1933         https://bugs.webkit.org/show_bug.cgi?id=157437
1934         <rdar://problem/26154021>
1935
1936         Reviewed by Simon Fraser.
1937
1938         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1939
1940         * DOM/DOMElement.mm:
1941         (-[DOMElement offsetLeft]):
1942         (-[DOMElement offsetTop]):
1943         (-[DOMElement offsetParent]):
1944
1945 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1946
1947         Unreviewed build fix.
1948
1949         * WebView/WebFrame.mm:
1950         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1951
1952 2018-12-15  Darin Adler  <darin@apple.com>
1953
1954         Use warning-ignoring macros more consistently and simply
1955         https://bugs.webkit.org/show_bug.cgi?id=192743
1956
1957         Reviewed by Mark Lam.
1958
1959         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1960         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1961         compilers in Objective-C++ code.
1962
1963         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1964         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1965         accomodate non-clang compilers here. Also use #pragma once, add a missing
1966         "explicit" and fix conditionals.
1967
1968 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1969
1970         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1971         https://bugs.webkit.org/show_bug.cgi?id=192653
1972
1973         Reviewed by Wenson Hsieh.
1974
1975         * WebView/WebHTMLView.mm:
1976         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1977
1978 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1979
1980         Implement feature flag for CSS Typed OM
1981         https://bugs.webkit.org/show_bug.cgi?id=192610
1982
1983         Reviewed by Ryosuke Niwa.
1984
1985         * Configurations/FeatureDefines.xcconfig:
1986
1987 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1988
1989         WebCore shouldn't have a Objective-C class named NSCursor
1990         https://bugs.webkit.org/show_bug.cgi?id=192602
1991         <rdar://problem/46615532>
1992
1993         Reviewed by Wenson Hsieh.
1994
1995         * WebView/WebFrameView.mm:
1996         (-[WebFrameView keyDown:keyDown:]):
1997         * WebView/WebHTMLView.mm:
1998         (-[WebHTMLView keyDown:]):
1999         (-[WebHTMLView performKeyEquivalent:]):
2000         Only use NSCursor on macOS.
2001
2002 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
2003
2004         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
2005         https://bugs.webkit.org/show_bug.cgi?id=192573
2006
2007         Reviewed by Simon Fraser.
2008
2009         * Configurations/FeatureDefines.xcconfig:
2010
2011 2018-12-10  Antti Koivisto  <antti@apple.com>
2012
2013         Rename "forced style recalc" to "full style rebuild"
2014         https://bugs.webkit.org/show_bug.cgi?id=192572
2015
2016         Reviewed by Zalan Bujtas.
2017
2018         * WebView/WebHTMLView.mm:
2019         (-[WebHTMLView setNeedsToApplyStyles:]):
2020
2021 2018-12-10  Darin Adler  <darin@apple.com>
2022
2023         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
2024         https://bugs.webkit.org/show_bug.cgi?id=192533
2025         rdar://problem/45732710
2026
2027         Reviewed by Anders Carlsson.
2028
2029         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2030         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
2031
2032 2018-12-10  Darin Adler  <darin@apple.com>
2033
2034         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
2035         https://bugs.webkit.org/show_bug.cgi?id=192532
2036         rdar://problem/45731047
2037
2038         Reviewed by Chris Dumez.
2039
2040         * Plugins/Hosted/NetscapePluginHostManager.mm:
2041         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
2042         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2043         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
2044
2045 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2046
2047         Turn WritingDirection into an enum class
2048         https://bugs.webkit.org/show_bug.cgi?id=192401
2049         Work towards <rdar://problem/42075638>
2050
2051         Reviewed by Dan Bernstein.
2052
2053         Change WritingDirection from an enum to an enum class. No change in behavior.
2054
2055         * WebView/WebHTMLView.mm:
2056         (-[WebHTMLView toggleBaseWritingDirection:]):
2057         (-[WebHTMLView changeBaseWritingDirection:]):
2058         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
2059
2060 2018-12-03  Alex Christensen  <achristensen@webkit.org>
2061
2062         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
2063         https://bugs.webkit.org/show_bug.cgi?id=192272
2064
2065         Reviewed by Brady Eidson.
2066
2067         * WebCoreSupport/WebFrameLoaderClient.h:
2068         * WebCoreSupport/WebFrameLoaderClient.mm:
2069         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2070
2071 2018-12-03  Jer Noble  <jer.noble@apple.com>
2072
2073         Get rid of old, dead Mac video fullscreen code.
2074         https://bugs.webkit.org/show_bug.cgi?id=192315
2075
2076         Reviewed by Eric Carlson.
2077
2078         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
2079         is no longer supported in the Mac port.
2080
2081         * WebView/WebVideoFullscreenController.h: Removed.
2082         * WebView/WebVideoFullscreenController.mm: Removed.
2083         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
2084         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
2085         * WebView/WebView.mm:
2086         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2087         (-[WebView _exitVideoFullscreen]):
2088
2089 2018-12-03  Daniel Bates  <dabates@apple.com>
2090
2091         [iOS] Do not handle key events that are key commands
2092         https://bugs.webkit.org/show_bug.cgi?id=191608
2093         <rdar://problem/46046013>
2094
2095         Reviewed by Ryosuke Niwa.
2096
2097         A key down event may be associated with a key command. If it is then we want to execute the
2098         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
2099         event as a key command to find out.
2100
2101         * WebView/WebHTMLView.mm:
2102         (-[WebHTMLView _handleEditingKeyEvent:]):
2103
2104 2018-12-02  Zalan Bujtas  <zalan@apple.com>
2105
2106         Add a runtime feature flag for LayoutFormattingContext.
2107         https://bugs.webkit.org/show_bug.cgi?id=192280
2108
2109         Reviewed by Simon Fraser.
2110
2111         * Configurations/FeatureDefines.xcconfig:
2112
2113 2018-11-30  Alex Christensen  <achristensen@webkit.org>
2114
2115         Move URL from WebCore to WTF
2116         https://bugs.webkit.org/show_bug.cgi?id=190234
2117
2118         Reviewed by Keith Miller.
2119
2120         * DOM/DOMAttr.mm:
2121         * DOM/DOMBlob.mm:
2122         * DOM/DOMCSSCharsetRule.mm:
2123         * DOM/DOMCSSImportRule.mm:
2124         * DOM/DOMCSSMediaRule.mm:
2125         * DOM/DOMCSSPageRule.mm:
2126         * DOM/DOMCSSPrimitiveValue.mm:
2127         * DOM/DOMCSSRule.mm:
2128         * DOM/DOMCSSStyleDeclaration.mm:
2129         * DOM/DOMCSSStyleRule.mm:
2130         * DOM/DOMCSSStyleSheet.mm:
2131         * DOM/DOMCSSValue.mm:
2132         * DOM/DOMCharacterData.mm:
2133         * DOM/DOMCounter.mm:
2134         * DOM/DOMDocument.mm:
2135         * DOM/DOMDocumentFragment.mm:
2136         * DOM/DOMDocumentType.mm:
2137         * DOM/DOMEvent.mm:
2138         * DOM/DOMFile.mm:
2139         * DOM/DOMHTMLAnchorElement.mm:
2140         * DOM/DOMHTMLAppletElement.mm:
2141         * DOM/DOMHTMLAreaElement.mm:
2142         * DOM/DOMHTMLBRElement.mm:
2143         * DOM/DOMHTMLBaseElement.mm:
2144         * DOM/DOMHTMLBaseFontElement.mm:
2145         * DOM/DOMHTMLBodyElement.mm:
2146         * DOM/DOMHTMLButtonElement.mm:
2147         * DOM/DOMHTMLCanvasElement.mm:
2148         * DOM/DOMHTMLCollection.mm:
2149         * DOM/DOMHTMLDivElement.mm:
2150         * DOM/DOMHTMLDocument.mm:
2151         * DOM/DOMHTMLElement.mm:
2152         * DOM/DOMHTMLEmbedElement.mm:
2153         * DOM/DOMHTMLFieldSetElement.mm:
2154         * DOM/DOMHTMLFontElement.mm:
2155         * DOM/DOMHTMLFormElement.mm:
2156         * DOM/DOMHTMLFrameElement.mm:
2157         * DOM/DOMHTMLFrameSetElement.mm:
2158         * DOM/DOMHTMLHRElement.mm:
2159         * DOM/DOMHTMLHeadElement.mm:
2160         * DOM/DOMHTMLHeadingElement.mm:
2161         * DOM/DOMHTMLHtmlElement.mm:
2162         * DOM/DOMHTMLIFrameElement.mm:
2163         * DOM/DOMHTMLImageElement.mm:
2164         * DOM/DOMHTMLInputElement.mm:
2165         * DOM/DOMHTMLLIElement.mm:
2166         * DOM/DOMHTMLLabelElement.mm:
2167         * DOM/DOMHTMLLegendElement.mm:
2168         * DOM/DOMHTMLLinkElement.mm:
2169         * DOM/DOMHTMLMapElement.mm:
2170         * DOM/DOMHTMLMarqueeElement.mm:
2171         * DOM/DOMHTMLMediaElement.mm:
2172         * DOM/DOMHTMLMetaElement.mm:
2173         * DOM/DOMHTMLModElement.mm:
2174         * DOM/DOMHTMLOListElement.mm:
2175         * DOM/DOMHTMLObjectElement.mm:
2176         * DOM/DOMHTMLOptGroupElement.mm:
2177         * DOM/DOMHTMLOptionElement.mm:
2178         * DOM/DOMHTMLOptionsCollection.mm:
2179         * DOM/DOMHTMLParagraphElement.mm:
2180         * DOM/DOMHTMLParamElement.mm:
2181         * DOM/DOMHTMLQuoteElement.mm:
2182         * DOM/DOMHTMLScriptElement.mm:
2183         * DOM/DOMHTMLSelectElement.mm:
2184         * DOM/DOMHTMLStyleElement.mm:
2185         * DOM/DOMHTMLTableCaptionElement.mm:
2186         * DOM/DOMHTMLTableCellElement.mm:
2187         * DOM/DOMHTMLTableColElement.mm:
2188         * DOM/DOMHTMLTableElement.mm:
2189         * DOM/DOMHTMLTableRowElement.mm:
2190         * DOM/DOMHTMLTableSectionElement.mm:
2191         * DOM/DOMHTMLTitleElement.mm:
2192         * DOM/DOMHTMLUListElement.mm:
2193         * DOM/DOMHTMLVideoElement.mm:
2194         * DOM/DOMKeyboardEvent.mm:
2195         * DOM/DOMMediaList.mm:
2196         * DOM/DOMMouseEvent.mm:
2197         * DOM/DOMMutationEvent.mm:
2198         * DOM/DOMNamedNodeMap.mm:
2199         * DOM/DOMProcessingInstruction.mm:
2200         * DOM/DOMRange.mm:
2201         * DOM/DOMStyleSheet.mm:
2202         * DOM/DOMText.mm:
2203         * DOM/DOMTextEvent.mm:
2204         * DOM/DOMTokenList.mm:
2205         * DOM/DOMUIEvent.mm:
2206         * DOM/DOMXPathResult.mm:
2207         * History/WebHistoryItem.mm:
2208         * Misc/WebNSURLExtras.mm:
2209         (-[NSURL _web_userVisibleString]):
2210         (-[NSURL _web_URLByRemovingUserInfo]):
2211         (-[NSURL _web_dataForURLComponentType:]):
2212         (-[NSURL _web_schemeData]):
2213         (-[NSURL _web_hostData]):
2214         * Misc/WebUserContentURLPattern.mm:
2215         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2216         * Plugins/WebNetscapePluginStream.h:
2217         (WebNetscapePluginStream::setRequestURL):
2218         * WebCoreSupport/WebChromeClient.h:
2219         * WebCoreSupport/WebChromeClient.mm:
2220         (WebChromeClient::signedPublicKeyAndChallengeString const):
2221         * WebCoreSupport/WebContextMenuClient.h:
2222         * WebCoreSupport/WebContextMenuClient.mm:
2223         * WebCoreSupport/WebDragClient.h:
2224         * WebCoreSupport/WebFrameLoaderClient.h:
2225         * WebCoreSupport/WebFrameLoaderClient.mm:
2226         (WebFrameLoaderClient::updateGlobalHistory):
2227         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2228         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2229         (WebPaymentCoordinatorClient::showPaymentUI):
2230         * WebCoreSupport/WebPlatformStrategies.h:
2231         * WebCoreSupport/WebPlatformStrategies.mm:
2232         (WebPlatformStrategies::readURLFromPasteboard):
2233         * WebCoreSupport/WebPluginInfoProvider.h:
2234         * WebCoreSupport/WebPluginInfoProvider.mm:
2235         (WebPluginInfoProvider::webVisiblePluginInfo):
2236         * WebCoreSupport/WebSecurityOrigin.mm:
2237         * WebCoreSupport/WebVisitedLinkStore.h:
2238         * WebView/WebDataSource.mm:
2239         * WebView/WebFrame.mm:
2240         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2241         * WebView/WebImmediateActionController.mm:
2242         (-[WebImmediateActionController _defaultAnimationController]):
2243         * WebView/WebPDFView.mm:
2244         * WebView/WebScriptDebugger.mm:
2245         * WebView/WebViewInternal.h:
2246
2247 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
2248
2249         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
2250         https://bugs.webkit.org/show_bug.cgi?id=192197
2251
2252         Reviewed by Jiewen Tan.
2253
2254         * Configurations/FeatureDefines.xcconfig:
2255         * WebCoreSupport/WebChromeClient.h:
2256         * WebCoreSupport/WebChromeClient.mm:
2257
2258 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2259
2260         Remove dead code from an earlier attempt at implementing safe browsing
2261         https://bugs.webkit.org/show_bug.cgi?id=192067
2262
2263         Reviewed by Chris Dumez.
2264
2265         * WebCoreSupport/WebFrameLoaderClient.h:
2266         * WebCoreSupport/WebFrameLoaderClient.mm:
2267         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2268
2269 2018-11-27  Mark Lam  <mark.lam@apple.com>
2270
2271         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2272         https://bugs.webkit.org/show_bug.cgi?id=192055
2273         <rdar://problem/46288783>
2274
2275         Reviewed by Saam Barati.
2276
2277         * Configurations/FeatureDefines.xcconfig:
2278
2279 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2280
2281         Make it possible to insert editable images with a gesture
2282         https://bugs.webkit.org/show_bug.cgi?id=191937
2283
2284         Reviewed by Wenson Hsieh.
2285
2286         * WebCoreSupport/WebEditorClient.mm:
2287         (undoNameForEditAction):
2288         Add a undo name.
2289
2290 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2291
2292         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2293         https://bugs.webkit.org/show_bug.cgi?id=191945
2294
2295         Reviewed by Anders Carlsson.
2296
2297         * WebCoreSupport/WebEditorClient.mm:
2298         (undoNameForEditAction):
2299
2300 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2301
2302         Enable drag and drop support for iOSMac
2303         https://bugs.webkit.org/show_bug.cgi?id=191818
2304         <rdar://problem/43907454>
2305
2306         Reviewed by Dean Jackson.
2307
2308         * Configurations/FeatureDefines.xcconfig:
2309
2310 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2311
2312         Address post-review feedback after r238438
2313         https://bugs.webkit.org/show_bug.cgi?id=191913
2314
2315         Reviewed by Ryosuke Niwa.
2316
2317         * WebView/WebFrame.mm:
2318         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2319         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2320         * WebView/WebView.mm:
2321         (-[WebView setSelectedDOMRange:affinity:]):
2322
2323 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2324
2325         Web Inspector: "Reload Web Inspector" button no longer partially works
2326         https://bugs.webkit.org/show_bug.cgi?id=191773
2327         <rdar://problem/46139932>
2328
2329         Reviewed by Devin Rousso.
2330
2331         * WebCoreSupport/WebInspectorClient.h:
2332         * WebCoreSupport/WebInspectorClient.mm:
2333         (WebInspectorFrontendClient::reopen):
2334
2335 2018-11-17  Devin Rousso  <drousso@apple.com>
2336
2337         Web Inspector: Network: add button to show system certificate dialog
2338         https://bugs.webkit.org/show_bug.cgi?id=191458
2339         <rdar://problem/45977019>
2340
2341         Reviewed by Joseph Pecoraro.
2342
2343         * WebCoreSupport/WebInspectorClient.h:
2344         * WebCoreSupport/WebInspectorClient.mm:
2345         (WebInspectorFrontendClient::showCertificate): Added.
2346
2347         * Configurations/WebKitLegacy.xcconfig:
2348
2349 2018-11-15  Truitt Savell  <tsavell@apple.com>
2350
2351         Unreviewed, rolling out r238244.
2352
2353         Caused High Sierra test runs to fail early with 50 crashes and
2354         casued 25 API failures.
2355
2356         Reverted changeset:
2357
2358         "[css-logical] Implement flow-relative margin, padding and
2359         border shorthands"
2360         https://bugs.webkit.org/show_bug.cgi?id=188697
2361         https://trac.webkit.org/changeset/238244
2362
2363 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2364
2365         [css-logical] Implement flow-relative margin, padding and border shorthands
2366         https://bugs.webkit.org/show_bug.cgi?id=188697
2367
2368         Reviewed by Simon Fraser and Antti Koivisto.
2369
2370         Add CSSLogicalEnabled runtime flag.
2371
2372         * WebView/WebPreferenceKeysPrivate.h:
2373         * WebView/WebPreferences.mm:
2374         (+[WebPreferences initialize]):
2375         (-[WebPreferences cssLogicalEnabled]):
2376         (-[WebPreferences setCSSLogicalEnabled:]):
2377         * WebView/WebPreferencesPrivate.h:
2378         * WebView/WebView.mm:
2379         (-[WebView _preferencesChanged:]):
2380
2381 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2382
2383         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2384         https://bugs.webkit.org/show_bug.cgi?id=191612
2385
2386         Reviewed by Matt Baker.
2387
2388         * WebCoreSupport/WebInspectorClient.mm:
2389         (-[WebInspectorWindowController destroyInspectorView]):
2390
2391 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2392
2393         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2394         https://bugs.webkit.org/show_bug.cgi?id=191494
2395         <rdar://problem/45469854>
2396
2397         Reviewed by Devin Rousso.
2398
2399         * WebCoreSupport/WebInspectorClient.h:
2400         WebKitLegacy will still have remote inspection of the Page directly.
2401
2402 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2403
2404         Make compositing updates incremental
2405         https://bugs.webkit.org/show_bug.cgi?id=90342
2406
2407         Reviewed by Antti Koivisto.
2408
2409         Fix spelling error.
2410
2411         * WebView/WebView.mm:
2412         (-[WebView _setMediaLayer:forPluginView:]):
2413
2414 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2415
2416         Implement a new edit command to change the enclosing list type
2417         https://bugs.webkit.org/show_bug.cgi?id=191487
2418         <rdar://problem/45955922>
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2423
2424         * WebCoreSupport/WebEditorClient.mm:
2425         (undoNameForEditAction):
2426
2427 2018-11-11  Daniel Bates  <dabates@apple.com>
2428
2429         [iOS] Draw caps lock indicator in password fields
2430         https://bugs.webkit.org/show_bug.cgi?id=190565
2431         <rdar://problem/45262343>
2432
2433         Reviewed by Dean Jackson.
2434
2435         Update the caps lock state when a hardware keyboard is attached or detached.
2436
2437         * WebView/WebHTMLView.mm:
2438         (hardwareKeyboardAvailabilityChangedCallback): Added.
2439         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2440         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2441
2442 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2443
2444         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2445         https://bugs.webkit.org/show_bug.cgi?id=191492
2446
2447         Reviewed by Alex Christensen.
2448
2449         * Carbon/HIWebView.mm:
2450         * Misc/WebNSFileManagerExtras.mm:
2451         * Misc/WebNSURLExtras.mm:
2452         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2453         * Plugins/WebBasePluginPackage.mm:
2454         * Plugins/WebPluginContainerCheck.mm:
2455         * WebCoreSupport/WebCachedFramePlatformData.h:
2456         * WebCoreSupport/WebDeviceOrientationClient.mm:
2457         * WebView/WebDelegateImplementationCaching.mm:
2458         * WebView/WebHTMLView.mm:
2459         * WebView/WebPDFRepresentation.mm:
2460         * WebView/WebPolicyDelegate.mm:
2461         * WebView/WebView.mm:
2462
2463 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2464
2465         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2466         https://bugs.webkit.org/show_bug.cgi?id=191492
2467
2468         Reviewed by Alex Christensen.
2469
2470         * Carbon/HIWebView.mm:
2471         (UpdateCommandStatus):
2472         * Misc/WebNSFileManagerExtras.mm:
2473         * Misc/WebNSURLExtras.mm:
2474         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2475         * Plugins/WebBasePluginPackage.mm:
2476         * Plugins/WebPluginContainerCheck.mm:
2477         (-[WebPluginContainerCheck _continueWithPolicy:]):
2478         * WebCoreSupport/WebCachedFramePlatformData.h:
2479         (WebCachedFramePlatformData::clear):
2480         * WebCoreSupport/WebDeviceOrientationClient.mm:
2481         (WebDeviceOrientationClient::getProvider const):
2482         * WebView/WebDelegateImplementationCaching.mm:
2483         (CallDelegate):
2484         (CallDelegateReturningBoolean):
2485         (CallResourceLoadDelegateReturningBoolean):
2486         (CallFormDelegate):
2487         (CallFormDelegateReturningBoolean):
2488         * WebView/WebHTMLView.mm:
2489         * WebView/WebPDFRepresentation.mm:
2490         * WebView/WebPolicyDelegate.mm:
2491         (-[WebPolicyDecisionListener _usePolicy:]):
2492         * WebView/WebView.mm:
2493
2494 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2495
2496         Unreviewed, rolling out r238047.
2497
2498         Introduced layout test failures on iOS simulator.
2499
2500         Reverted changeset:
2501
2502         "[iOS] Draw caps lock indicator in password fields"
2503         https://bugs.webkit.org/show_bug.cgi?id=190565
2504         https://trac.webkit.org/changeset/238047
2505
2506 2018-11-09  Antti Koivisto  <antti@apple.com>
2507
2508         Use OptionSet for layout milestones
2509         https://bugs.webkit.org/show_bug.cgi?id=191470
2510
2511         Reviewed by Dean Jackson.
2512
2513         * WebCoreSupport/WebFrameLoaderClient.h:
2514         * WebCoreSupport/WebFrameLoaderClient.mm:
2515         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2516         * WebView/WebView.mm:
2517         (coreLayoutMilestones):
2518         (kitLayoutMilestones):
2519         (-[WebView _cacheFrameLoadDelegateImplementations]):
2520         * WebView/WebViewInternal.h:
2521
2522 2018-11-09  Daniel Bates  <dabates@apple.com>
2523
2524         [iOS] Draw caps lock indicator in password fields
2525         https://bugs.webkit.org/show_bug.cgi?id=190565
2526         <rdar://problem/45262343>
2527
2528         Reviewed by Dean Jackson.
2529
2530         Update the caps lock state when a hardware keyboard is attached or detached.
2531
2532         * WebView/WebHTMLView.mm:
2533         (hardwareKeyboardAvailabilityChangedCallback): Added.
2534         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2535         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2536
2537 2018-11-09  Daniel Bates  <dabates@apple.com>
2538
2539         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2540         action when forward delete is pressed outside a text field
2541         https://bugs.webkit.org/show_bug.cgi?id=190566
2542         <rdar://problem/45262367>
2543
2544         Reviewed by Wenson Hsieh.
2545
2546         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2547         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2548         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2549
2550         * WebView/WebHTMLView.mm:
2551         (-[WebHTMLView _handleEditingKeyEvent:]):
2552
2553 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2554
2555         Adopt Reveal Framework to replace Lookup
2556         https://bugs.webkit.org/show_bug.cgi?id=191097
2557         <rdar://problem/45924508>
2558
2559         Reviewed by Tim Horton.
2560
2561         Pass in what it needed to clear the textIndicators. This is better than
2562         the current notification structure.
2563
2564         * WebView/WebView.mm:
2565         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2566         (-[WebView _prepareForDictionaryLookup]):
2567
2568 2018-11-06  Justin Fan  <justin_fan@apple.com>
2569
2570         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2571         https://bugs.webkit.org/show_bug.cgi?id=191291
2572
2573         Reviewed by Myles Maxfield.
2574
2575         Properly disable WEBGPU on all non-Metal platforms for now.
2576
2577         * Configurations/FeatureDefines.xcconfig:
2578
2579 2018-11-02  Daniel Bates  <dabates@apple.com>
2580
2581         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2582         https://bugs.webkit.org/show_bug.cgi?id=190487
2583
2584         Reviewed by Tim Horton.
2585
2586         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2587         allow the default handling.
2588
2589         * WebView/WebHTMLView.mm:
2590         (-[WebHTMLView _handleEditingKeyEvent:]):
2591
2592 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2593
2594         Add a storage limit for IndexedDB
2595         https://bugs.webkit.org/show_bug.cgi?id=190598
2596         <rdar://problem/44654715>
2597
2598         Reviewed by Chris Dumez.
2599
2600         * Storage/WebDatabaseManager.mm:
2601         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2602         * Storage/WebDatabaseManagerPrivate.h:
2603
2604 2018-10-31  Antti Koivisto  <antti@apple.com>
2605
2606         Remove LayerFlushScheduler
2607         https://bugs.webkit.org/show_bug.cgi?id=191103
2608
2609         Reviewed by Anders Carlsson.
2610
2611         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2612         all the virtual cruft.
2613
2614         * WebView/WebViewData.h:
2615         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2616         (): Deleted.
2617         * WebView/WebViewData.mm:
2618         (currentRunLoop):
2619         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2620         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2621         (WebViewLayerFlushScheduler::schedule):
2622         (WebViewLayerFlushScheduler::invalidate):
2623         (WebViewLayerFlushScheduler::layerFlushCallback):
2624
2625 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2626
2627         Enable InstallAPI for iOS unconditionally
2628         https://bugs.webkit.org/show_bug.cgi?id=191043
2629         rdar://problem/32728423
2630
2631         Reviewed by Dan Bernstein.
2632
2633         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2634         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2635         shouldn't be processed by InstallAPI.
2636         * MigrateHeaders.make: Removed an obsolete workaround.
2637         * Misc/NSURLDownloadSPI.h: Added.
2638         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2639
2640 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2641
2642         Clean up some obsolete MAX_ALLOWED macros
2643         https://bugs.webkit.org/show_bug.cgi?id=190916
2644
2645         Reviewed by Tim Horton.
2646
2647         * WebView/WebHTMLView.mm:
2648         (-[WebHTMLView pressureChangeWithEvent:]):
2649         * WebView/WebPDFView.h:
2650
2651 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2652
2653         Unreviewed, rolling out r237600 and r237604.
2654         https://bugs.webkit.org/show_bug.cgi?id=191086
2655
2656         Breaks internal iOS builds (Requested by ryanhadd_ on
2657         #webkit).
2658
2659         Reverted changesets:
2660
2661         "Enable InstallAPI for iOS unconditionally"
2662         https://bugs.webkit.org/show_bug.cgi?id=191043
2663         https://trac.webkit.org/changeset/237600
2664
2665         "Build fix attempt after enabling InstallAPI for iOS."
2666         https://bugs.webkit.org/show_bug.cgi?id=191043
2667         https://trac.webkit.org/changeset/237604
2668
2669 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2670
2671         Enable InstallAPI for iOS unconditionally
2672         https://bugs.webkit.org/show_bug.cgi?id=191043
2673         rdar://problem/32728423
2674
2675         Reviewed by Dan Bernstein.
2676
2677         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2678         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2679         shouldn't be processed by InstallAPI.
2680         * MigrateHeaders.make: Removed an obsolete workaround.
2681         * Misc/NSURLDownloadSPI.h: Added.
2682         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2683
2684 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2685
2686         Modernize WebKit nibs and lprojs for localization's sake
2687         https://bugs.webkit.org/show_bug.cgi?id=190911
2688         <rdar://problem/45349466>
2689
2690         Reviewed by Dan Bernstein.
2691
2692         * Misc/WebNSControlExtras.m:
2693         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2694         NSWindow and its contents are both in the same scale space these days; avoid
2695         double-applying the scale factor, or you can't see the prompt.
2696
2697         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2698         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2699         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2700         NIB->XIB
2701
2702 2018-10-25  Antoine Quint  <graouts@apple.com>
2703
2704         [Web Animations] Turn Web Animations CSS Integration off by default
2705         https://bugs.webkit.org/show_bug.cgi?id=190901
2706
2707         Reviewed by Dean Jackson.
2708
2709         * WebView/WebPreferences.mm:
2710         (+[WebPreferences initialize]):
2711
2712 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2713
2714         Clean up some obsolete macOS version guards
2715         https://bugs.webkit.org/show_bug.cgi?id=190887
2716
2717         Reviewed by Dan Bernstein.
2718
2719         * Misc/WebNSPasteboardExtras.mm:
2720         (+[NSPasteboard _web_dragTypesForURL]):
2721         * WebCoreSupport/PopupMenuMac.mm:
2722         (PopupMenuMac::show):
2723         * WebCoreSupport/WebEditorClient.h:
2724         * WebCoreSupport/WebEditorClient.mm:
2725         (WebEditorClient::respondToChangedSelection):
2726         * WebView/WebPDFView.mm:
2727         (-[WebPDFView _clipViewForPDFDocumentView]):
2728
2729 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2730
2731         Turn on Conic Gradients
2732         https://bugs.webkit.org/show_bug.cgi?id=190810
2733
2734         Reviewed by Tim Horton.
2735
2736         * Configurations/FeatureDefines.xcconfig:
2737
2738 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2739
2740         Cleanup: MIMETypeRegistry functions
2741         https://bugs.webkit.org/show_bug.cgi?id=190838
2742
2743         Reviewed by Simon Fraser.
2744
2745         * Misc/WebNSPasteboardExtras.mm:
2746         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2747         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2748         because they were identical.
2749
2750         * WebView/WebHTMLRepresentation.mm:
2751         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2752         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2753         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2754         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2755         * WebView/WebView.mm:
2756         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2757         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2758         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2759
2760 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2761
2762         Fix false positive leaks when using custom -init methods that don't start with -init
2763         <https://webkit.org/b/190818>
2764         <rdar://problem/45476042>
2765
2766         Reviewed by Dan Bernstein.
2767
2768         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2769         it is accessible by both categories.
2770         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2771         NSError (WebKitInternal) category.  Add attribute to make this
2772         behave like an -init method.
2773         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2774         NSError (WebKitInternal) category.  Modernize method.  Replace
2775         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2776
2777 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2778
2779         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2780         https://bugs.webkit.org/show_bug.cgi?id=190729
2781
2782         Reviewed by Tim Horton.
2783
2784         * DOM/DOM.mm:
2785         (-[DOMNode boundingBox]):
2786         * DOM/DOMElement.mm:
2787         * DOM/DOMHTML.mm:
2788         * DOM/DOMInternal.mm:
2789         * DOM/DOMUIKitExtensions.mm:
2790         * DOM/WebDOMOperations.mm:
2791         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2792         * DefaultDelegates/WebDefaultEditingDelegate.m:
2793         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2794         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2795         * DefaultDelegates/WebDefaultUIDelegate.h:
2796         * DefaultDelegates/WebDefaultUIDelegate.mm:
2797         (-[WebDefaultUIDelegate webViewClose:]):
2798         (-[WebDefaultUIDelegate webViewFocus:]):
2799         (-[WebDefaultUIDelegate webViewUnfocus:]):
2800         (-[WebDefaultUIDelegate webViewIsResizable:]):
2801         (-[WebDefaultUIDelegate webView:setResizable:]):
2802         (-[WebDefaultUIDelegate webView:setFrame:]):
2803         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2804         * History/BackForwardList.h:
2805         * History/BackForwardList.mm:
2806         * History/WebBackForwardList.mm:
2807         (+[WebBackForwardList initialize]):
2808         (bumperCarBackForwardHackNeeded):
2809         * History/WebHistory.mm:
2810         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2811         (-[WebHistory _sendNotification:entries:]):
2812         (-[WebHistory loadFromURL:error:]):
2813         (-[WebHistory saveToURL:error:]):
2814         * History/WebHistoryItem.mm:
2815         (WKNotifyHistoryItemChanged):
2816         (+[WebHistoryItem initialize]):
2817         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2818         * History/WebURLsWithTitles.m:
2819         * Misc/WebCache.mm:
2820         (+[WebCache initialize]):
2821         * Misc/WebDownload.mm:
2822         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2823         * Misc/WebElementDictionary.mm:
2824         (+[WebElementDictionary initialize]):
2825         (+[WebElementDictionary initializeLookupTable]):
2826         * Misc/WebIconDatabase.mm:
2827         * Misc/WebKitNSStringExtras.mm:
2828         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2829         * Misc/WebKitVersionChecks.h:
2830         * Misc/WebKitVersionChecks.mm:
2831         (WebKitLinkedOnOrAfter):
2832         (WebKitLinkTimeVersion):
2833         * Misc/WebLocalizableStrings.mm:
2834         * Misc/WebNSControlExtras.h:
2835         * Misc/WebNSControlExtras.m:
2836         * Misc/WebNSEventExtras.m:
2837         * Misc/WebNSFileManagerExtras.mm:
2838         * Misc/WebNSImageExtras.h:
2839         * Misc/WebNSImageExtras.m:
2840         * Misc/WebNSPasteboardExtras.mm:
2841         * Misc/WebNSPrintOperationExtras.h:
2842         * Misc/WebNSPrintOperationExtras.m:
2843         * Misc/WebNSViewExtras.m:
2844         * Misc/WebNSWindowExtras.m:
2845         * Panels/WebAuthenticationPanel.h:
2846         * Panels/WebAuthenticationPanel.m:
2847         * Panels/WebPanelAuthenticationHandler.m:
2848         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2849         (+[WebHostedNetscapePluginView initialize]):
2850         * Plugins/WebBasePluginPackage.h:
2851         * Plugins/WebBasePluginPackage.mm:
2852         * Plugins/WebJavaPlugIn.h:
2853         * Plugins/WebPluginContainerCheck.mm:
2854         * Plugins/WebPluginController.h:
2855         * Plugins/WebPluginController.mm:
2856         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2857         (-[WebPluginController addPlugin:]):
2858         (-[WebPluginController destroyPlugin:]):
2859         (-[WebPluginController destroyAllPlugins]):
2860         * Plugins/WebPluginDatabase.mm:
2861         (+[WebPluginDatabase _defaultPlugInPaths]):
2862         * Plugins/WebPluginPackage.mm:
2863         (-[WebPluginPackage initWithPath:]):
2864         * Storage/WebDatabaseManager.mm:
2865         (-[WebDatabaseManager deleteAllDatabases]):
2866         * Storage/WebDatabaseManagerClient.h:
2867         * Storage/WebDatabaseManagerClient.mm:
2868         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2869         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2870         * Storage/WebStorageManager.mm:
2871         (-[WebStorageManager deleteAllOrigins]):
2872         (WebKitInitializeStorageIfNecessary):
2873         * WebCoreSupport/WebAlternativeTextClient.h:
2874         * WebCoreSupport/WebApplicationCache.mm:
2875         (applicationCacheBundleIdentifier):
2876         * WebCoreSupport/WebChromeClient.h:
2877         * WebCoreSupport/WebChromeClient.mm:
2878         (WebChromeClient::setWindowRect):
2879         (WebChromeClient::windowRect):
2880         (WebChromeClient::takeFocus):
2881         (WebChromeClient::addMessageToConsole):
2882         (WebChromeClient::enableSuddenTermination):
2883         (WebChromeClient::disableSuddenTermination):
2884         (WebChromeClient::createPopupMenu const):
2885         (WebChromeClient::createSearchPopupMenu const):
2886         (WebChromeClient::shouldPaintEntireContents const):
2887         (WebChromeClient::supportsVideoFullscreen):
2888         (WebChromeClient::supportsFullScreenForElement):
2889         (WebChromeClient::enterFullScreenForElement):
2890         (WebChromeClient::exitFullScreenForElement):
2891         * WebCoreSupport/WebContextMenuClient.mm:
2892         * WebCoreSupport/WebDragClient.mm:
2893         * WebCoreSupport/WebEditorClient.h:
2894         * WebCoreSupport/WebEditorClient.mm:
2895         (+[WebUndoStep initialize]):
2896         (updateFontPanel):
2897         (WebEditorClient::didBeginEditing):
2898         (WebEditorClient::respondToChangedContents):
2899         (WebEditorClient::respondToChangedSelection):
2900         (WebEditorClient::canceledComposition):
2901         (WebEditorClient::didEndEditing):
2902         (WebEditorClient::didWriteSelectionToPasteboard):
2903         (attributesForAttributedStringConversion):
2904         (WebEditorClient::setInsertionPasteboard):
2905         (WebEditorClient::registerUndoOrRedoStep):
2906         (WebEditorClient::handleKeyboardEvent):
2907         (WebEditorClient::handleInputMethodKeydown):
2908         (WebEditorClient::textDidChangeInTextField):
2909         (WebEditorClient::requestCheckingOfString):
2910         * WebCoreSupport/WebFrameLoaderClient.h:
2911         * WebCoreSupport/WebFrameLoaderClient.mm:
2912         (WebFrameLoaderClient::detachedFromParent2):
2913         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2914         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2915         (WebFrameLoaderClient::dispatchWillSendRequest):
2916         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2917         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2918         (WebFrameLoaderClient::willCacheResponse const):
2919         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2920         (WebFrameLoaderClient::dispatchDidFinishLoading):
2921         (WebFrameLoaderClient::dispatchDidFailLoading):
2922         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2923         (WebFrameLoaderClient::dispatchWillClose):
2924         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2925         (WebFrameLoaderClient::dispatchDidCommitLoad):
2926         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2927         (WebFrameLoaderClient::dispatchDidFailLoad):
2928         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2929         (WebFrameLoaderClient::dispatchDidFinishLoad):
2930         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2931         (WebFrameLoaderClient::willChangeTitle):
2932         (WebFrameLoaderClient::didChangeTitle):
2933         (WebFrameLoaderClient::didReplaceMultipartContent):
2934         (WebFrameLoaderClient::updateGlobalHistory):
2935         (WebFrameLoaderClient::saveViewStateToItem):
2936         (WebFrameLoaderClient::restoreViewState):
2937         (WebFrameLoaderClient::provisionalLoadStarted):
2938         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2939         (WebFrameLoaderClient::setTitle):
2940         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2941         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2942         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2943         (WebFrameLoaderClient::didRestoreFromPageCache):
2944         (WebFrameLoaderClient::actionDictionary const):
2945         (WebFrameLoaderClient::createPlugin):
2946         (WebFrameLoaderClient::getLoadDecisionForIcons):
2947         (WebFrameLoaderClient::finishedLoadingIcon):
2948         (+[WebFramePolicyListener initialize]):
2949         * WebCoreSupport/WebFrameNetworkingContext.mm:
2950         * WebCoreSupport/WebGeolocationClient.h:
2951         * WebCoreSupport/WebGeolocationClient.mm:
2952         (WebGeolocationClient::requestPermission):
2953         * WebCoreSupport/WebInspectorClient.h:
2954         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2955         * WebCoreSupport/WebNotificationClient.mm:
2956         * WebCoreSupport/WebOpenPanelResultListener.mm:
2957         * WebCoreSupport/WebPlatformStrategies.h:
2958         * WebCoreSupport/WebPlatformStrategies.mm:
2959         * WebCoreSupport/WebProgressTrackerClient.h:
2960         * WebCoreSupport/WebProgressTrackerClient.mm:
2961         (WebProgressTrackerClient::progressStarted):
2962         (WebProgressTrackerClient::progressEstimateChanged):
2963         (WebProgressTrackerClient::progressFinished):
2964         * WebCoreSupport/WebSecurityOrigin.mm:
2965         * WebInspector/WebNodeHighlight.h:
2966         * WebInspector/WebNodeHighlight.mm:
2967         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2968         (-[WebNodeHighlight dealloc]):
2969         (-[WebNodeHighlight attach]):
2970         * WebInspector/WebNodeHighlightView.h:
2971         * WebInspector/WebNodeHighlightView.mm:
2972         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2973         (-[WebNodeHighlightView dealloc]):
2974         * WebInspector/WebNodeHighlighter.mm:
2975         (-[WebNodeHighlighter highlight]):
2976         * WebView/WebArchive.mm:
2977         (+[WebArchivePrivate initialize]):
2978         * WebView/WebClipView.h:
2979         * WebView/WebDataSource.mm:
2980         (WebDataSourcePrivate::WebDataSourcePrivate):
2981         (+[WebDataSource initialize]):
2982         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2983         (-[WebDataSource _makeRepresentation]):
2984         * WebView/WebDelegateImplementationCaching.h:
2985         * WebView/WebDelegateImplementationCaching.mm:
2986         (CallDelegate):
2987         (CallDelegateReturningFloat):
2988         (CallDelegateReturningBoolean):
2989         (CallUIDelegate):
2990         (CallUIDelegateReturningFloat):
2991         (CallUIDelegateReturningBoolean):
2992         (CallFrameLoadDelegate):
2993         (CallFrameLoadDelegateReturningBoolean):
2994         (CallResourceLoadDelegate):
2995         (CallScriptDebugDelegate):
2996         (CallFormDelegate):
2997         (CallFormDelegateReturningBoolean):
2998         * WebView/WebDeviceOrientation.mm:
2999         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3000         * WebView/WebDocumentInternal.h:
3001         * WebView/WebDocumentLoaderMac.mm:
3002         (needsDataLoadWorkaround):
3003         * WebView/WebDynamicScrollBarsViewInternal.h:
3004         * WebView/WebFormDelegate.m:
3005         * WebView/WebFrame.mm:
3006         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3007         (-[WebFrame _unmarkAllMisspellings]):
3008         (-[WebFrame _paintBehaviorForDestinationContext:]):
3009         (-[WebFrame _drawRect:contentsOnly:]):
3010         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3011         (-[WebFrame _scrollDOMRangeToVisible:]):
3012         (-[WebFrame _bodyBackgroundColor]):
3013         (-[WebFrame accessibilityRoot]):
3014         (needsMicrosoftMessengerDOMDocumentWorkaround):
3015         * WebView/WebFrameInternal.h:
3016         * WebView/WebFrameView.mm:
3017         (-[WebFrameView _setDocumentView:]):
3018         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
3019         (-[WebFrameView _viewClassForMIMEType:]):
3020         (-[WebFrameView initWithFrame:]):
3021         (-[WebFrameView drawRect:]):
3022         (-[WebFrameView _firstResponderIsFormControl]):
3023         (-[WebFrameView keyDown:keyDown:]):
3024         (-[WebFrameView _isScrollable]):
3025         * WebView/WebFullScreenController.h:
3026         * WebView/WebFullScreenController.mm:
3027         * WebView/WebHTMLRepresentation.mm:
3028         * WebView/WebHTMLView.mm:
3029         (-[WebHTMLView hitTest:]):
3030         (-[WebHTMLView initWithFrame:]):
3031         (-[WebHTMLView dealloc]):
3032         (-[WebHTMLView addSubview:]):
3033         (-[WebHTMLView mouseDown:]):
3034         (-[WebHTMLView mouseUp:]):
3035         (-[WebHTMLView resignFirstResponder]):
3036         (-[WebHTMLView accessibilityHitTest:]):
3037         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3038         * WebView/WebHTMLViewInternal.h:
3039         * WebView/WebIndicateLayer.h:
3040         * WebView/WebIndicateLayer.mm:
3041         * WebView/WebMediaPlaybackTargetPicker.h:
3042         * WebView/WebMediaPlaybackTargetPicker.mm:
3043         * WebView/WebPDFDocumentExtras.h:
3044         * WebView/WebPDFDocumentExtras.mm:
3045         * WebView/WebPDFRepresentation.h:
3046         * WebView/WebPDFRepresentation.mm:
3047         * WebView/WebPDFView.h:
3048         * WebView/WebPreferences.mm:
3049         (cacheModelForMainBundle):
3050         (WebPreferencesPrivate::WebPreferencesPrivate):
3051         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
3052         (-[WebPreferences encodeWithCoder:]):
3053         (+[WebPreferences standardPreferences]):
3054         (+[WebPreferences initialize]):
3055         (-[WebPreferences _valueForKey:]):
3056         (-[WebPreferences _setStringValue:forKey:]):
3057         (-[WebPreferences _setIntegerValue:forKey:]):
3058         (-[WebPreferences _setUnsignedIntValue:forKey:]):
3059         (-[WebPreferences _setFloatValue:forKey:]):
3060         (-[WebPreferences _setBoolValue:forKey:]):
3061         (-[WebPreferences _setLongLongValue:forKey:]):
3062         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
3063         (-[WebPreferences _postCacheModelChangedNotification]):
3064         (-[WebPreferences _postPreferencesChangedNotification]):
3065         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3066         (-[WebPreferences setStorageBlockingPolicy:]):
3067         * WebView/WebResource.mm:
3068         (+[WebResourcePrivate initialize]):
3069         * WebView/WebTextCompletionController.h:
3070         * WebView/WebTextIterator.mm:
3071         (+[WebTextIteratorPrivate initialize]):
3072         * WebView/WebView.mm:
3073         (shouldEnableLoadDeferring):
3074         (shouldRestrictWindowFocus):
3075         (shouldRespectPriorityInCSSAttributeSetters):
3076         (shouldUseLegacyBackgroundSizeShorthandBehavior):
3077         (shouldAllowPictureInPictureMediaPlayback):
3078         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
3079         (shouldAllowWindowOpenWithoutUserGesture):
3080         (shouldConvertInvalidURLsToBlank):
3081         (shouldRequireUserGestureToLoadVideo):
3082         (-[WebView _commonInitializationWithFrameName:groupName:]):
3083         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
3084         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
3085         (-[WebView _closePluginDatabases]):
3086         (-[WebView _closeWithFastTeardown]):
3087         (-[WebView _close]):
3088         (+[WebView _MIMETypeForFile:]):
3089         (-[WebView setShowingInspectorIndication:]):
3090         (-[WebView _setFormDelegate:]):
3091         (-[WebView _needsPreHTML5ParserQuirks]):
3092         (-[WebView _preferencesChangedNotification:]):
3093         (-[WebView _preferencesChanged:]):
3094         (-[WebView _cacheResourceLoadDelegateImplementations]):
3095         (-[WebView _cacheFrameLoadDelegateImplementations]):
3096         (-[WebView _policyDelegateForwarder]):
3097         (-[WebView _UIDelegateForwarder]):
3098         (-[WebView _editingDelegateForwarder]):
3099         (-[WebView _updateActiveState]):
3100         (-[_WebSafeForwarder forwardInvocation:]):
3101         (+[WebView initialize]):
3102         (-[WebView _pluginForMIMEType:]):
3103         (-[WebView _pluginForExtension:]):
3104         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
3105         (+[WebView canShowMIMETypeAsHTML:]):
3106         (-[WebView _initWithArguments:]):
3107         (-[WebView initWithFrame:frameName:groupName:]):
3108         (-[WebView dealloc]):
3109         (-[WebView close]):
3110         (-[WebView viewDidMoveToWindow]):
3111         (-[WebView setUIDelegate:]):
3112         (-[WebView setResourceLoadDelegate:]):
3113         (-[WebView setPolicyDelegate:]):
3114         (-[WebView setFrameLoadDelegate:]):
3115         (-[WebView goBack]):
3116         (-[WebView goForward]):
3117         (-[WebView stringByEvaluatingJavaScriptFromString:]):
3118         (-[WebView setHostWindow:]):
3119         (-[WebView becomeFirstResponder]):
3120         (+[WebView _cacheModelChangedNotification:]):
3121         (-[WebView _frameViewAtWindowPoint:]):
3122         (+[WebView _preflightSpellCheckerNow:]):
3123         (+[WebView _preflightSpellChecker]):
3124         (-[WebView canGoBack]):
3125         (-[WebView canGoForward]):
3126         (-[WebView stopLoading:]):
3127         (-[WebView reload:]):
3128         (-[WebView setMainFrameDocumentReady:]):
3129         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3130         (-[WebView setContinuousSpellCheckingEnabled:]):
3131         (-[WebView undoManager]):
3132         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
3133         (-[WebView isAutomaticLinkDetectionEnabled]):
3134         (-[WebView isAutomaticDashSubstitutionEnabled]):
3135         (-[WebView isAutomaticTextReplacementEnabled]):
3136         (-[WebView isAutomaticSpellingCorrectionEnabled]):
3137         (+[WebView _setCacheModel:]):
3138         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
3139         (-[WebView _keyboardUIMode]):
3140         (LayerFlushController::flushLayers):
3141         (-[WebView _scheduleCompositingLayerFlush]):
3142         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
3143         (-[WebView fullScreenPlaceholderView]):
3144         (WebInstallMemoryPressureHandler):
3145         * WebView/WebViewData.h:
3146         * WebView/WebViewData.mm:
3147         (+[WebViewPrivate initialize]):
3148         (-[WebViewPrivate init]):
3149         (-[WebViewPrivate dealloc]):
3150         * WebView/WebViewInternal.h:
3151
3152 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3153
3154         Clean up FrameLoader two-state enums
3155         https://bugs.webkit.org/show_bug.cgi?id=190731
3156
3157         Reviewed by Chris Dumez.
3158
3159         * WebCoreSupport/WebFrameLoaderClient.h:
3160         * WebCoreSupport/WebFrameLoaderClient.mm:
3161         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3162
3163 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3164
3165         Unreviewed, rolling out r237137.
3166
3167         SPI is actually used
3168
3169         Reverted changeset:
3170
3171         "Remove unused WebFrame._loadType"
3172         https://bugs.webkit.org/show_bug.cgi?id=190583
3173         https://trac.webkit.org/changeset/237137
3174
3175 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3176
3177         Enable the datalist element by default on iOS and macOS
3178         https://bugs.webkit.org/show_bug.cgi?id=190594
3179         <rdar://problem/45281159>
3180
3181         Reviewed by Ryosuke Niwa and Tim Horton.
3182
3183         * Configurations/FeatureDefines.xcconfig:
3184
3185 2018-10-17  Alex Christensen  <achristensen@webkit.org>
3186
3187         BackForwardClient needs to be able to support UIProcess-only back/forward lists
3188         https://bugs.webkit.org/show_bug.cgi?id=190675
3189
3190         Reviewed by Chris Dumez.
3191
3192         * History/BackForwardList.h:
3193         * History/BackForwardList.mm:
3194         (BackForwardList::backItem):
3195         (BackForwardList::currentItem):
3196         (BackForwardList::forwardItem):
3197         (BackForwardList::backListCount const):
3198         (BackForwardList::forwardListCount const):
3199         (BackForwardList::itemAtIndex):
3200         * History/WebBackForwardList.mm:
3201         (-[WebBackForwardList backItem]):
3202         (-[WebBackForwardList currentItem]):
3203         (-[WebBackForwardList forwardItem]):
3204         (-[WebBackForwardList itemAtIndex:]):
3205
3206 2018-10-16  Timothy Hatcher  <timothy@apple.com>
3207
3208         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
3209         https://bugs.webkit.org/show_bug.cgi?id=190526
3210         rdar://problem/45230140
3211
3212         Reviewed by Dean Jackson.
3213
3214         * WebCoreSupport/WebEditorClient.mm:
3215         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
3216
3217 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3218
3219         Implement feature flag and bindings for CSS Painting API
3220         https://bugs.webkit.org/show_bug.cgi?id=190237
3221
3222         Reviewed by Ryosuke Niwa.
3223
3224         * Configurations/FeatureDefines.xcconfig:
3225
3226 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3227
3228         Replace HistoryItem* with HistoryItem& where possible
3229         https://bugs.webkit.org/show_bug.cgi?id=190617
3230
3231         Reviewed by Chris Dumez.
3232
3233         * History/BackForwardList.h:
3234         * History/BackForwardList.mm:
3235         (BackForwardList::goToItem):
3236         * History/WebBackForwardList.mm:
3237         (-[WebBackForwardList goToItem:]):
3238         * History/WebHistoryItem.mm:
3239         (WKNotifyHistoryItemChanged):
3240         * History/WebHistoryItemInternal.h:
3241
3242 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3243
3244         Remove unused WebHistoryItem._transientPropertyForKey
3245         https://bugs.webkit.org/show_bug.cgi?id=190606
3246
3247         Reviewed by Chris Dumez.
3248
3249         * History/WebHistoryItem.mm:
3250         * History/WebHistoryItemPrivate.h:
3251
3252 2018-10-15  Justin Fan  <justin_fan@apple.com>
3253
3254         Add WebGPU 2018 feature flag and experimental feature flag
3255         https://bugs.webkit.org/show_bug.cgi?id=190509
3256
3257         Reviewed by Dean Jackson.
3258
3259         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3260         for the 2018 WebGPU prototype.
3261
3262         * Configurations/FeatureDefines.xcconfig:
3263         * WebView/WebPreferenceKeysPrivate.h:
3264         * WebView/WebPreferences.mm:
3265         (+[WebPreferences initialize]):
3266         (-[WebPreferences webGPUEnabled]):
3267         (-[WebPreferences setWebGPUEnabled:]):
3268         * WebView/WebPreferencesPrivate.h:
3269         * WebView/WebView.mm:
3270         (-[WebView _preferencesChanged:]):
3271
3272 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3273
3274         Fix iOS build after r237157
3275
3276         * WebView/WebView.mm:
3277         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3278
3279 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3280
3281         Modernize BackForwardClient.h
3282         https://bugs.webkit.org/show_bug.cgi?id=190610
3283
3284         Reviewed by Chris Dumez.
3285
3286         * History/BackForwardList.h:
3287         * History/BackForwardList.mm:
3288         (BackForwardList::backListCount const):
3289         (BackForwardList::forwardListCount const):
3290         (BackForwardList::backListCount): Deleted.
3291         (BackForwardList::forwardListCount): Deleted.
3292         * History/WebBackForwardList.mm:
3293         (-[WebBackForwardList init]):
3294         * WebCoreSupport/WebFrameLoaderClient.mm:
3295         (WebFrameLoaderClient::canCachePage const):
3296         * WebView/WebFrameView.mm:
3297         (-[WebFrameView keyDown:keyDown:]):
3298         * WebView/WebView.mm:
3299         (-[WebView _commonInitializationWithFrameName:groupName:]):
3300         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3301         (-[WebView _loadBackForwardListFromOtherView:]):
3302         (-[WebView initWithCoder:]):
3303         (-[WebView encodeWithCoder:]):
3304         (-[WebView backForwardList]):
3305         (-[WebView setMaintainsBackForwardList:]):
3306
3307 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3308
3309         Add support for prefers-color-scheme media query
3310         https://bugs.webkit.org/show_bug.cgi?id=190499
3311         rdar://problem/45212025
3312
3313         Reviewed by Dean Jackson.
3314
3315         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3316
3317 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3318
3319         Remove unused WebView._globalHistoryItem
3320         https://bugs.webkit.org/show_bug.cgi?id=190601
3321
3322         Reviewed by Chris Dumez.
3323
3324         * WebCoreSupport/WebFrameLoaderClient.h:
3325         * WebCoreSupport/WebFrameLoaderClient.mm:
3326         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3327         * WebView/WebView.mm:
3328         (-[WebView _globalHistoryItem]): Deleted.
3329         (-[WebView _setGlobalHistoryItem:]): Deleted.
3330         * WebView/WebViewData.h:
3331         * WebView/WebViewInternal.h:
3332         * WebView/WebViewPrivate.h:
3333
3334 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3335
3336         Remove unused parameters from FrameLoaderClient::createFrame
3337         https://bugs.webkit.org/show_bug.cgi?id=190587
3338
3339         Reviewed by Chris Dumez.
3340
3341         * WebCoreSupport/WebFrameLoaderClient.h:
3342         * WebCoreSupport/WebFrameLoaderClient.mm:
3343         (WebFrameLoaderClient::createFrame):
3344
3345 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3346
3347         Remove unused WebFrame._loadType
3348         https://bugs.webkit.org/show_bug.cgi?id=190583
3349
3350         Reviewed by Chris Dumez.
3351
3352         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3353
3354         * WebView/WebFrame.mm:
3355         (toWebFrameLoadType): Deleted.
3356         (-[WebFrame _loadType]): Deleted.
3357         * WebView/WebFramePrivate.h:
3358
3359 2018-10-15  Chris Dumez  <cdumez@apple.com>
3360
3361         Restrict browsing context lookup by name to frames that are related to one another
3362         https://bugs.webkit.org/show_bug.cgi?id=190475
3363
3364         Reviewed by Alex Christensen.
3365
3366         * WebView/WebFrame.mm:
3367         (-[WebFrame findFrameNamed:]):
3368
3369 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3370
3371         Remove InjectedBundle processing of back/forward lists
3372         https://bugs.webkit.org/show_bug.cgi?id=190459
3373
3374         Reviewed by Chris Dumez.
3375
3376         * WebCoreSupport/WebFrameLoaderClient.h:
3377         * WebCoreSupport/WebFrameLoaderClient.mm:
3378         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3379
3380 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3381
3382         [JSC] Remove Option::useAsyncIterator
3383         https://bugs.webkit.org/show_bug.cgi?id=190567
3384
3385         Reviewed by Saam Barati.
3386
3387         * Configurations/FeatureDefines.xcconfig:
3388
3389 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3390
3391         Allow encoding of small enum classes
3392         https://bugs.webkit.org/show_bug.cgi?id=190531
3393
3394         Reviewed by Tim Horton.
3395
3396         * WebCoreSupport/WebFrameLoaderClient.mm:
3397         (-[WebFramePolicyListener dealloc]):
3398
3399 2018-10-11  Keith Rollin  <krollin@apple.com>
3400
3401         CURRENT_ARCH should not be used in Run Script phase.
3402         https://bugs.webkit.org/show_bug.cgi?id=190407
3403         <rdar://problem/45133556>
3404
3405         Reviewed by Alexey Proskuryakov.
3406
3407         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3408         CURRENT_ARCH is not well-defined during this phase (and may even have
3409         the value "undefined") since this phase is run just once per build
3410         rather than once per supported architecture. Migrate away from
3411         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3412         performing an operation for each value, or by picking the first entry
3413         in ARCHS and using that as a representative value.
3414
3415         * Configurations/WebKitLegacy.xcconfig: When generating
3416         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3417         macosx platforms.
3418
3419         * MigrateHeaders.make:
3420         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3421         generate one for each architecture in ARCHS.
3422
3423 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3424
3425         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3426         https://bugs.webkit.org/show_bug.cgi?id=190429
3427
3428         Reviewed by Saam Barati.
3429
3430         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3431
3432         * WebView/WebPDFRepresentation.mm:
3433         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3434
3435 2018-10-08  Justin Fan  <justin_fan@apple.com>
3436
3437         WebGPU: Rename old WebGPU prototype to WebMetal
3438         https://bugs.webkit.org/show_bug.cgi?id=190325
3439         <rdar://problem/44990443>
3440
3441         Reviewed by Dean Jackson.
3442
3443         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3444
3445         * Configurations/FeatureDefines.xcconfig:
3446         * WebView/WebPreferenceKeysPrivate.h:
3447         * WebView/WebPreferences.mm:
3448         (+[WebPreferences initialize]):
3449         (-[WebPreferences webMetalEnabled]):
3450         (-[WebPreferences setWebMetalEnabled:]):
3451         (-[WebPreferences webGPUEnabled]): Deleted.
3452         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3453         * WebView/WebPreferencesPrivate.h:
3454         * WebView/WebView.mm:
3455         (-[WebView _preferencesChanged:]):
3456
3457 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3458
3459         Make <input type=color> a runtime enabled (on-by-default) feature
3460         https://bugs.webkit.org/show_bug.cgi?id=189162
3461
3462         Reviewed by Wenson Hsieh and Tim Horton.
3463
3464         * Configurations/FeatureDefines.xcconfig:
3465
3466 2018-10-07  Dan Bernstein  <mitz@apple.com>
3467
3468         Fixed building with the latest macOS SDK
3469
3470         * Plugins/WebNetscapePluginPackage.mm:
3471         (-[WebNetscapePluginPackage openResourceFile]):
3472         (-[WebNetscapePluginPackage closeResourceFile:]):
3473
3474 2018-10-04  Dan Bernstein  <mitz@apple.com>
3475
3476         More Carbon build-fixing.
3477
3478         * Carbon/CarbonWindowAdapter.mm:
3479         (-[CarbonWindowAdapter _destroyRealWindow:]):
3480         (-[CarbonWindowAdapter _growBoxRect]):
3481
3482 2018-10-04  Dan Bernstein  <mitz@apple.com>
3483
3484         Retried to fix 32-bit macOS builds after r236846.
3485