a48482298333f0cf6ac209d32c85a24d3e0f2652
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-15  Brian Burg  <bburg@apple.com>
2
3         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4         https://bugs.webkit.org/show_bug.cgi?id=194411
5         <rdar://problem/47787614>
6
7         Reviewed by Joseph Pecoraro.
8
9         * Configurations/WebKitLegacy.xcconfig:
10         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
11
12         * WebCoreSupport/WebInspectorClient.mm:
13         (WebInspectorFrontendClient::localizedStringsURL):
14         (-[WebInspectorWindowController inspectorPagePath]):
15         (-[WebInspectorWindowController inspectorTestPagePath]):
16         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
17
18 2019-02-15  Commit Queue  <commit-queue@webkit.org>
19
20         Unreviewed, rolling out r241559 and r241566.
21         https://bugs.webkit.org/show_bug.cgi?id=194710
22
23         Causes layout test crashes under GuardMalloc (Requested by
24         ryanhaddad on #webkit).
25
26         Reverted changesets:
27
28         "[WTF] Add environment variable helpers"
29         https://bugs.webkit.org/show_bug.cgi?id=192405
30         https://trac.webkit.org/changeset/241559
31
32         "Unreviewed build fix for WinCairo Debug after r241559."
33         https://trac.webkit.org/changeset/241566
34
35 2019-02-15  Truitt Savell  <tsavell@apple.com>
36
37         Unreviewed, rolling out r241564.
38
39         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
40
41         Reverted changeset:
42
43         "[Mac] WebInspectorUI.framework does not need to be soft-
44         linked anymore"
45         https://bugs.webkit.org/show_bug.cgi?id=194411
46         https://trac.webkit.org/changeset/241564
47
48 2019-02-14  Brian Burg  <bburg@apple.com>
49
50         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
51         https://bugs.webkit.org/show_bug.cgi?id=194411
52         <rdar://problem/47787614>
53
54         Reviewed by Joseph Pecoraro.
55
56         * Configurations/WebKitLegacy.xcconfig:
57         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
58
59         * WebCoreSupport/WebInspectorClient.mm:
60         (WebInspectorFrontendClient::localizedStringsURL):
61         (-[WebInspectorWindowController inspectorPagePath]):
62         (-[WebInspectorWindowController inspectorTestPagePath]):
63         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
64
65 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
66
67         [WTF] Add environment variable helpers
68         https://bugs.webkit.org/show_bug.cgi?id=192405
69
70         Reviewed by Michael Catanzaro.
71
72         * WebView/WebView.mm:
73         (-[WebView _initWithFrame:frameName:groupName:]):
74         Utilize WTF::Environment where possible.
75
76 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
77
78         Allow pages to trigger programmatic paste from script on iOS
79         https://bugs.webkit.org/show_bug.cgi?id=194271
80         <rdar://problem/47808810>
81
82         Reviewed by Ryosuke Niwa.
83
84         See WebCore and WebKit ChangeLogs for more details.
85
86         * WebCoreSupport/WebEditorClient.h:
87
88 2019-02-12  Andy Estes  <aestes@apple.com>
89
90         [iOSMac] Enable Parental Controls Content Filtering
91         https://bugs.webkit.org/show_bug.cgi?id=194521
92         <rdar://39732376>
93
94         Reviewed by Tim Horton.
95
96         * Configurations/FeatureDefines.xcconfig:
97
98 2019-02-06  Andy Estes  <aestes@apple.com>
99
100         [Payment Request] It should be possible to require a phonetic name for shipping contacts
101         https://bugs.webkit.org/show_bug.cgi?id=194311
102         <rdar://46733045>
103
104         Reviewed by Alex Christensen.
105
106         * WebCoreSupport/WebPaymentCoordinatorClient.h:
107         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
108         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
109
110 2019-02-04  Said Abou-Hallawa  <said@apple.com>
111
112         [CG] Enable setAdditionalSupportedImageTypes for WK1
113         https://bugs.webkit.org/show_bug.cgi?id=194190
114
115         Reviewed by Tim Horton.
116
117         1. Define the preferences key AdditionalSupportedImageTypes.
118         2. Add additionalSupportedImageTypes as a private preference property.
119         3. Define the setter and the getter of the property.
120         4. Add function to convert from an id to an array of strings.
121         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
122
123         * WebView/WebPreferenceKeysPrivate.h:
124         * WebView/WebPreferences.mm:
125         (-[WebPreferences _stringArrayValueForKey:]):
126         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
127         (-[WebPreferences setAdditionalSupportedImageTypes:]):
128         (-[WebPreferences additionalSupportedImageTypes]):
129         * WebView/WebPreferencesPrivate.h:
130         * WebView/WebView.mm:
131         (-[WebView _preferencesChanged:]):
132
133 2019-02-04  Timothy Hatcher  <timothy@apple.com>
134
135         Add WebView SPI to temporarily force light or dark appearance on a page.
136         https://bugs.webkit.org/show_bug.cgi?id=194230
137
138         Reviewed by Tim Horton.
139
140         * WebView/WebView.mm:
141         (-[WebView _useDarkAppearance:]): Added.
142         (-[WebView _setUseDarkAppearance:]): Added.
143         * WebView/WebViewPrivate.h:
144
145 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
146
147         PageOverlayController's layers should be created lazily
148         https://bugs.webkit.org/show_bug.cgi?id=194199
149         rdar://problem/46571593
150
151         Reviewed by Tim Horton.
152
153         * WebCoreSupport/WebChromeClient.h:
154         * WebCoreSupport/WebChromeClient.mm:
155         (WebChromeClient::attachViewOverlayGraphicsLayer):
156
157 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
158
159         Make setNeedsLayout on the root more explicitly about triggering its side-effects
160         https://bugs.webkit.org/show_bug.cgi?id=194198
161
162         Reviewed by Antti Koivisto.
163
164         Call the newly named functions.
165
166         * WebView/WebFrame.mm:
167         (-[WebFrame setNeedsLayout]):
168         * WebView/WebHTMLView.mm:
169         (-[WebHTMLView setNeedsLayout:]):
170
171 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
172
173         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
174         https://bugs.webkit.org/show_bug.cgi?id=194189
175
176         Reviewed by Geoffrey Garen.
177
178         Pass the policy check identifier around functions and store it in WebFramePolicyListener
179         so that we can send it back to WebCore with the navigation policy decision.
180
181         * WebCoreSupport/WebFrameLoaderClient.h:
182         * WebCoreSupport/WebFrameLoaderClient.mm:
183         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
184         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
185         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
186         (WebFrameLoaderClient::dispatchWillSubmitForm):
187         (WebFrameLoaderClient::setUpPolicyListener):
188         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
189         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
190         (-[WebFramePolicyListener invalidate]):
191         (-[WebFramePolicyListener dealloc]):
192         (-[WebFramePolicyListener receivedPolicyDecision:]):
193         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
194         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
195
196 2019-01-31  Alex Christensen  <achristensen@webkit.org>
197
198         Revert r238819 which is unneeded and caused a performance regression.
199         https://bugs.webkit.org/show_bug.cgi?id=192272
200         <rdar://problem/46664625>
201
202         * WebCoreSupport/WebFrameLoaderClient.h:
203         * WebCoreSupport/WebFrameLoaderClient.mm:
204         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
205
206 2019-01-28  Devin Rousso  <drousso@apple.com>
207
208         Web Inspector: provide a way to edit page WebRTC settings on a remote target
209         https://bugs.webkit.org/show_bug.cgi?id=193863
210         <rdar://problem/47572764>
211
212         Reviewed by Joseph Pecoraro.
213
214         * WebView/WebView.mm:
215         (-[WebView _preferencesChanged:]):
216         Add page-level settings for WebRTC preferences.
217
218 2019-01-28  Andy Estes  <aestes@apple.com>
219
220         [watchOS] Enable Parental Controls content filtering
221         https://bugs.webkit.org/show_bug.cgi?id=193939
222         <rdar://problem/46641912>
223
224         Reviewed by Ryosuke Niwa.
225
226         * Configurations/FeatureDefines.xcconfig:
227
228 2019-01-28  Timothy Hatcher  <timothy@apple.com>
229
230         Make it easier for non-Apple ports to enable dark mode CSS support.
231         https://bugs.webkit.org/show_bug.cgi?id=193882
232
233         Reviewed by Megan Gardner.
234
235         * WebView/WebView.mm:
236         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
237         (-[WebView _effectiveAppearanceIsDark]): Ditto.
238
239 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
240
241         AX: Introduce a static accessibility tree
242         https://bugs.webkit.org/show_bug.cgi?id=193348
243         <rdar://problem/47203295>
244
245         Reviewed by Ryosuke Niwa.
246
247         * Configurations/FeatureDefines.xcconfig:
248
249 2019-01-25  Keith Rollin  <krollin@apple.com>
250
251         Update WebKitAdditions.xcconfig with correct order of variable definitions
252         https://bugs.webkit.org/show_bug.cgi?id=193793
253         <rdar://problem/47532439>
254
255         Reviewed by Alex Christensen.
256
257         XCBuild changes the way xcconfig variables are evaluated. In short,
258         all config file assignments are now considered in part of the
259         evaluation. When using the new build system and an .xcconfig file
260         contains multiple assignments of the same build setting:
261
262         - Later assignments using $(inherited) will inherit from earlier
263           assignments in the xcconfig file.
264         - Later assignments not using $(inherited) will take precedence over
265           earlier assignments. An assignment to a more general setting will
266           mask an earlier assignment to a less general setting. For example,
267           an assignment without a condition ('FOO = bar') will completely mask
268           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
269
270         This affects some of our .xcconfig files, in that sometimes platform-
271         or sdk-specific definitions appear before the general definitions.
272         Under the new evaluations rules, the general definitions alway take
273         effect because they always overwrite the more-specific definitions. The
274         solution is to swap the order, so that the general definitions are
275         established first, and then conditionally overwritten by the
276         more-specific definitions.
277
278         * Configurations/Version.xcconfig:
279         * Configurations/WebKitLegacy.xcconfig:
280
281 2019-01-25  David Kilzer  <ddkilzer@apple.com>
282
283         Move soft-linking of Lookup.framework out of LookupSPI.h
284         <https://webkit.org/b/193815>
285
286         Reviewed by Tim Horton.
287
288         * WebView/WebImmediateActionController.mm:
289         (-[WebImmediateActionController _animationControllerForText]):
290         * WebView/WebView.mm:
291         (-[WebView _prepareForDictionaryLookup]):
292         - Move soft-linking to LookupSoftLink.{h,mm}.
293
294 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
295
296         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
297         https://bugs.webkit.org/show_bug.cgi?id=193829
298
299         Reviewed by Tim Horton.
300
301         * WebCoreSupport/WebDragClient.mm:
302         (WebDragClient::didConcludeEditDrag):
303         * WebView/WebView.mm:
304         (-[WebView _requestStartDataInteraction:globalPosition:]):
305         (-[WebView _didConcludeEditDrag]):
306         (-[WebView _didConcludeEditDataInteraction]): Deleted.
307         * WebView/WebViewInternal.h:
308
309 2019-01-24  John Wilander  <wilander@apple.com>
310
311         Add Ad Click Attribution as an internal/experimental feature
312         https://bugs.webkit.org/show_bug.cgi?id=193685
313         <rdar://problem/47450399>
314
315         Reviewed by Brent Fulgham.
316
317         * WebView/WebPreferenceKeysPrivate.h:
318         * WebView/WebPreferences.mm:
319         (+[WebPreferences initialize]):
320         (-[WebPreferences adClickAttributionEnabled]):
321         (-[WebPreferences setAdClickAttributionEnabled:]):
322             Added support for experimental ad click attribution.
323         * WebView/WebPreferencesPrivate.h:
324         * WebView/WebView.mm:
325         (-[WebView _preferencesChanged:]):
326
327 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
328
329         Move FileSystem to WTF
330         https://bugs.webkit.org/show_bug.cgi?id=193602
331
332         Reviewed by Yusuke Suzuki.
333
334         * Misc/WebNSFileManagerExtras.mm:
335         * Storage/WebDatabaseProvider.mm:
336         * WebView/WebView.mm:
337
338 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
339
340         Fix the Apple Internal build. See <rdar://problem/47491383>.
341
342         Rubber-stamped by Tim Horton.
343
344         * WebCoreSupport/WebFrameLoaderClient.mm:
345
346 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
347
348         Clean up USE(WEB_THREAD)
349         https://bugs.webkit.org/show_bug.cgi?id=193698
350
351         Rubber-stamped by Tim Horton.
352
353         * Misc/WebCache.mm:
354         (+[WebCache emptyInMemoryResources]):
355         * WebCoreSupport/WebFrameLoaderClient.mm:
356         (-[WebFramePolicyListener use]):
357         * WebCoreSupport/WebGeolocationClient.mm:
358         (-[WebGeolocationPolicyListener allow]):
359         (-[WebGeolocationPolicyListener deny]):
360         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
361         * WebView/WebFrame.mm:
362         (-[WebFrame deviceOrientationChanged]):
363         * WebView/WebHTMLView.mm:
364         (hardwareKeyboardAvailabilityChangedCallback):
365         * WebView/WebView.mm:
366         (+[WebView _releaseMemoryNow]):
367         (+[WebView willEnterBackgroundWithCompletionHandler:]):
368         (-[WebView updateLayoutIgnorePendingStyleSheets]):
369         (-[WebView _dispatchUnloadEvent]):
370         (-[WebView _close]):
371         (-[WebView _preferencesChangedNotification:]):
372         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
373         (-[WebView goBack]):
374         (-[WebView goForward]):
375         (+[WebView _cacheModelChangedNotification:]):
376         (-[WebView stopLoading:]):
377         (-[WebView stopLoadingAndClear]):
378         (-[WebView reload:]):
379         (WebInstallMemoryPressureHandler):
380
381 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
382
383         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
384         https://bugs.webkit.org/show_bug.cgi?id=193706
385         <rdar://problem/44807048>
386
387         Reviewed by Ryosuke Niwa.
388
389         Use UndoStep::label().
390
391         * WebCoreSupport/WebEditorClient.h:
392         * WebCoreSupport/WebEditorClient.mm:
393         (-[WebUndoStep initWithUndoStep:]):
394         (+[WebUndoStep stepWithUndoStep:]):
395         (WebEditorClient::registerUndoOrRedoStep):
396         (WebEditorClient::registerUndoStep):
397         (WebEditorClient::registerRedoStep):
398
399 2019-01-22  Alex Christensen  <achristensen@webkit.org>
400
401         Move NetworkStorageSession ownership to NetworkProcess
402         https://bugs.webkit.org/show_bug.cgi?id=193580
403
404         Reviewed by Geoff Garen.
405
406         * Misc/WebCache.mm:
407         (+[WebCache clearCachedCredentials]):
408         * Misc/WebDownload.mm:
409         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
410         * Plugins/WebBaseNetscapePluginView.mm:
411         (WebKit::getAuthenticationInfo):
412         * WebCoreSupport/WebFrameNetworkingContext.mm:
413         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
414         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
415         (WebFrameNetworkingContext::storageSession const):
416         * WebView/WebPreferences.mm:
417         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
418         (+[WebPreferences _clearNetworkLoaderSession]):
419         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
420
421 2019-01-22  Daniel Bates  <dabates@apple.com>
422
423         [iOS] Interpret text key commands on keydown and app key commands on keypress
424         https://bugs.webkit.org/show_bug.cgi?id=192897
425         <rdar://problem/46857378>
426
427         Reviewed by Brent Fulgham.
428
429         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
430         is false) and keypress (isCharEvent is true), respectively.
431
432         * WebView/WebHTMLView.mm:
433         (-[WebHTMLView _handleEditingKeyEvent:]):
434
435 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
436
437         [css-logical] Implement flow-relative margin, padding and border shorthands
438         https://bugs.webkit.org/show_bug.cgi?id=188697
439
440         Reviewed by Simon Fraser and Antti Koivisto.
441
442         Add CSSLogicalEnabled runtime flag.
443
444         * WebView/WebPreferenceKeysPrivate.h:
445         * WebView/WebPreferences.mm:
446         (+[WebPreferences initialize]):
447         (-[WebPreferences cssLogicalEnabled]):
448         (-[WebPreferences setCSSLogicalEnabled:]):
449         * WebView/WebPreferencesPrivate.h:
450         * WebView/WebView.mm:
451         (-[WebView _preferencesChanged:]):
452
453 2019-01-15  Darin Adler  <darin@apple.com>
454
455         Use references rather than pointers for register/unregister functions, and more
456         https://bugs.webkit.org/show_bug.cgi?id=175028
457
458         Reviewed by Daniel Bates.
459
460         * WebCoreSupport/WebKitFullScreenListener.mm:
461         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
462         functions in Document; pass a reference.
463         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
464         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
465         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
466         * WebView/WebFullScreenController.mm:
467         (-[WebFullScreenController enterFullScreen:]): Ditto.
468         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
469         (-[WebFullScreenController exitFullScreen]): Ditto.
470         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
471         * WebView/WebFullScreenController.mm:
472         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
473
474 2019-01-12  Dan Bernstein  <mitz@apple.com>
475
476         [Cocoa] Avoid importing directly from subumbrella frameworks
477         https://bugs.webkit.org/show_bug.cgi?id=186016
478         <rdar://problem/40591038>
479
480         Reviewed by Sam Weinig.
481
482         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
483         * Carbon/CarbonWindowAdapter.mm: Ditto.
484         * Carbon/CarbonWindowFrame.m: Ditto.
485         * Carbon/HIViewAdapter.h: Ditto.
486         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
487           OTHER_CFLAGS_COCOA_TOUCH_NO.
488         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
489         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
490         * WebView/WebPDFView.h: Ditto.
491
492 2019-01-20  Antoine Quint  <graouts@apple.com>
493
494         Add a POINTER_EVENTS feature flag
495         https://bugs.webkit.org/show_bug.cgi?id=193577
496         <rdar://problem/47408511>
497
498         Unreviewed. Also enable Pointer Events for iosmac.
499
500         * Configurations/FeatureDefines.xcconfig:
501
502 2019-01-19  Antoine Quint  <graouts@apple.com>
503
504         Add a POINTER_EVENTS feature flag
505         https://bugs.webkit.org/show_bug.cgi?id=193577
506
507         Reviewed by Dean Jackson.
508
509         * Configurations/FeatureDefines.xcconfig:
510
511 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
512
513         Revert r238815, it broke WK1 video fullscreen on Mac
514         https://bugs.webkit.org/show_bug.cgi?id=193586
515         <rdar://problem/47358941>
516
517         Reviewed by Jer Noble.
518
519         * WebView/WebVideoFullscreenController.h: Added.
520         * WebView/WebVideoFullscreenController.mm: Added.
521         (SOFT_LINK_CLASS):
522         (-[WebVideoFullscreenController init]):
523         (-[WebVideoFullscreenController dealloc]):
524         (-[WebVideoFullscreenController fullscreenWindow]):
525         (-[WebVideoFullscreenController windowDidLoad]):
526         (-[WebVideoFullscreenController videoElement]):
527         (-[WebVideoFullscreenController setVideoElement:]):
528         (-[WebVideoFullscreenController clearFadeAnimation]):
529         (-[WebVideoFullscreenController windowDidExitFullscreen]):
530         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
531         (-[WebVideoFullscreenController videoElementRect]):
532         (-[WebVideoFullscreenController applicationDidResignActive:]):
533         (frameExpandedToRatioOfFrame):
534         (createBackgroundFullscreenWindow):
535         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
536         (-[WebVideoFullscreenController enterFullscreen:]):
537         (-[WebVideoFullscreenController exitFullscreen]):
538         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
539         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
540         (-[WebVideoFullscreenController _requestExit]):
541         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
542         (-[WebVideoFullscreenController requestExitFullscreen]):
543         (-[WebVideoFullscreenController fadeHUDIn]):
544         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
545         (-[WebVideoFullscreenController rateChanged:]):
546         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
547         (-[WebVideoFullscreenWindow dealloc]):
548         (-[WebVideoFullscreenWindow resignFirstResponder]):
549         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
550         (-[WebVideoFullscreenWindow mouseDown:]):
551         (-[WebVideoFullscreenWindow cancelOperation:]):
552         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
553         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
554         (-[WebVideoFullscreenWindow animationDidEnd:]):
555         (-[WebVideoFullscreenWindow mouseMoved:]):
556         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
557         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
558         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
559         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
560         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
561         (-[WebVideoFullscreenHUDWindow center]):
562         (-[WebVideoFullscreenHUDWindow keyDown:]):
563         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
564         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
565         (-[WebVideoFullscreenHUDWindowController init]):
566         (-[WebVideoFullscreenHUDWindowController dealloc]):
567         (-[WebVideoFullscreenHUDWindowController setArea:]):
568         (-[WebVideoFullscreenHUDWindowController keyDown:]):
569         (-[WebVideoFullscreenHUDWindowController delegate]):
570         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
571         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
572         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
573         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
574         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
575         (-[WebVideoFullscreenHUDWindowController closeWindow]):
576         (createMediaUIControl):
577         (createControlWithMediaUIControlType):
578         (createTimeTextField):
579         (createMediaUIBackgroundView):
580         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
581         (-[WebVideoFullscreenHUDWindowController updateVolume]):
582         (-[WebVideoFullscreenHUDWindowController updateTime]):
583         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
584         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
585         (-[WebVideoFullscreenHUDWindowController currentTime]):
586         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
587         (-[WebVideoFullscreenHUDWindowController duration]):
588         (-[WebVideoFullscreenHUDWindowController maxVolume]):
589         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
590         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
591         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
592         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
593         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
594         (-[WebVideoFullscreenHUDWindowController volume]):
595         (-[WebVideoFullscreenHUDWindowController setVolume:]):
596         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
597         (-[WebVideoFullscreenHUDWindowController updateRate]):
598         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
599         (-[WebVideoFullscreenHUDWindowController playing]):
600         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
601         (timeToString):
602         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
603         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
604         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
605         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
606         (-[WebVideoFullscreenHUDWindowController rewind:]):
607         (-[WebVideoFullscreenHUDWindowController fastForward:]):
608         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
609         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
610         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
611         * WebView/WebView.mm:
612         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
613         (-[WebView _exitVideoFullscreen]):
614
615 2019-01-18  Tim Horton  <timothy_horton@apple.com>
616
617         Get rid of ADVANCED_SPELL_CHECKING
618         https://bugs.webkit.org/show_bug.cgi?id=193592
619
620         Reviewed by Wenson Hsieh.
621
622         * WebCoreSupport/WebEditorClient.mm:
623         (insertionPointFromCurrentSelection):
624         (WebEditorClient::checkTextOfParagraph):
625         (WebEditorClient::getGuessesForWord):
626         (WebEditorClient::requestCandidatesForSelection):
627         (WebEditorClient::requestCheckingOfString):
628         * WebView/WebHTMLView.mm:
629         (-[WebHTMLView insertText:]):
630
631 2019-01-18  Jer Noble  <jer.noble@apple.com>
632
633         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
634         https://bugs.webkit.org/show_bug.cgi?id=189553
635
636         Reviewed by Tim Horton.
637
638         * Configurations/Base.xcconfig:
639         * Configurations/SDKVariant.xcconfig: Added.
640         * Configurations/WebKitLegacy.xcconfig:
641
642 2019-01-18  David Kilzer  <ddkilzer@apple.com>
643
644         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
645         <https://webkit.org/b/193568>
646         <rdar://problem/47381130>
647
648         Reviewed by Alex Christensen.
649
650         * WebView/WebView.mm:
651         - Remove unused soft-linking macros.
652         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
653         (-[WebUITextIndicatorData initWithImage:scale:]):
654         - Update to use exported PAL functions.
655
656 2019-01-17  Truitt Savell  <tsavell@apple.com>
657
658         Unreviewed, rolling out r240124.
659
660         This commit broke an internal build.
661
662         Reverted changeset:
663
664         "SDK_VARIANT build destinations should be separate from non-
665         SDK_VARIANT builds"
666         https://bugs.webkit.org/show_bug.cgi?id=189553
667         https://trac.webkit.org/changeset/240124
668
669 2019-01-17  Jer Noble  <jer.noble@apple.com>
670
671         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
672         https://bugs.webkit.org/show_bug.cgi?id=189553
673
674         Reviewed by Tim Horton.
675
676         * Configurations/Base.xcconfig:
677         * Configurations/SDKVariant.xcconfig: Added.
678         * Configurations/WebKitLegacy.xcconfig:
679
680 2019-01-17  Alex Christensen  <achristensen@webkit.org>
681
682         Stop using NetworkStorageSession::storageSession in WebCore
683         https://bugs.webkit.org/show_bug.cgi?id=193529
684
685         Reviewed by Tim Horton.
686
687         * Misc/WebCache.mm:
688         (+[WebCache addImageToCache:forURL:forFrame:]):
689         * WebView/WebView.mm:
690         (-[WebView _commonInitializationWithFrameName:groupName:]):
691         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
692
693 2019-01-15  Alex Christensen  <achristensen@webkit.org>
694
695         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
696         https://bugs.webkit.org/show_bug.cgi?id=193368
697
698         Reviewed by Geoff Garen.
699
700         * Misc/WebCache.mm:
701         (+[WebCache clearCachedCredentials]):
702         * Misc/WebDownload.mm:
703         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
704         * Plugins/WebBaseNetscapePluginView.mm:
705         (WebKit::getAuthenticationInfo):
706
707 2019-01-15  Alex Christensen  <achristensen@webkit.org>
708
709         Stop using CookiesStrategy
710         https://bugs.webkit.org/show_bug.cgi?id=161106
711
712         Reviewed by Don Olmstead and Antti Koivisto.
713
714         * Misc/WebCache.mm:
715         (+[WebCache addImageToCache:forURL:forFrame:]):
716         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
717         (WebKit::NetscapePluginInstanceProxy::getCookies):
718         (WebKit::NetscapePluginInstanceProxy::setCookies):
719         * Plugins/WebNetscapePluginView.mm:
720         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
721         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
722         * WebCoreSupport/WebPlatformStrategies.h:
723         * WebCoreSupport/WebPlatformStrategies.mm:
724         (WebPlatformStrategies::createCookiesStrategy): Deleted.
725         (WebPlatformStrategies::cookiesForDOM): Deleted.
726         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
727         (WebPlatformStrategies::cookiesEnabled): Deleted.
728         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
729         (WebPlatformStrategies::getRawCookies): Deleted.
730         (WebPlatformStrategies::deleteCookie): Deleted.
731         * WebView/WebView.mm:
732         (-[WebView _commonInitializationWithFrameName:groupName:]):
733         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
734
735 2019-01-15  Tim Horton  <timothy_horton@apple.com>
736
737         Cannot tab out of WKWebView on macOS
738         https://bugs.webkit.org/show_bug.cgi?id=161448
739         <rdar://problem/28100085>
740
741         Reviewed by Dean Jackson.
742
743         * WebCoreSupport/WebChromeClient.mm:
744         * WebView/WebView.mm:
745         Make use of SPI headers.
746
747 2019-01-14  Commit Queue  <commit-queue@webkit.org>
748
749         Unreviewed, rolling out r239901, r239909, r239910, r239912,
750         r239913, and r239914.
751         https://bugs.webkit.org/show_bug.cgi?id=193407
752
753         These revisions caused an internal failure (Requested by
754         Truitt on #webkit).
755
756         Reverted changesets:
757
758         "[Cocoa] Avoid importing directly from subumbrella frameworks"
759         https://bugs.webkit.org/show_bug.cgi?id=186016
760         https://trac.webkit.org/changeset/239901
761
762         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
763         https://trac.webkit.org/changeset/239909
764
765         "Tried to fix the build."
766         https://trac.webkit.org/changeset/239910
767
768         "Fixed iOS builds after r239910."
769         https://trac.webkit.org/changeset/239912
770
771         "More build fixing."
772         https://trac.webkit.org/changeset/239913
773
774         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
775         https://trac.webkit.org/changeset/239914
776
777 2019-01-14  Mark Lam  <mark.lam@apple.com>
778
779         Re-enable ability to build --cloop builds.
780         https://bugs.webkit.org/show_bug.cgi?id=192955
781         <rdar://problem/46882363>
782
783         Reviewed by Saam barati and Keith Miller.
784
785         * Configurations/FeatureDefines.xcconfig:
786
787 2019-01-13  Dan Bernstein  <mitz@apple.com>
788
789         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
790
791         Patch by Keith Rollin.
792
793         * WebView/PDFViewSPI.h:
794
795 2019-01-12  Timothy Hatcher  <timothy@apple.com>
796
797         Have prefers-color-scheme: light always match on macOS versions before Mojave.
798         https://bugs.webkit.org/show_bug.cgi?id=191655
799         rdar://problem/46074680
800
801         Reviewed by Megan Gardner.
802
803         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
804         * WebView/WebView.mm:
805         (-[WebView _effectiveAppearanceIsDark]):
806
807 2019-01-12  Dan Bernstein  <mitz@apple.com>
808
809         [Cocoa] Avoid importing directly from subumbrella frameworks
810         https://bugs.webkit.org/show_bug.cgi?id=186016
811         <rdar://problem/40591038>
812
813         Reviewed by Sam Weinig.
814
815         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
816         * Carbon/CarbonWindowAdapter.mm: Ditto.
817         * Carbon/CarbonWindowFrame.m: Ditto.
818         * Carbon/HIViewAdapter.h: Ditto.
819         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
820           OTHER_CFLAGS_COCOA_TOUCH_NO.
821         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
822         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
823         * WebView/WebPDFView.h: Ditto.
824
825 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
826
827         Enable visual viewport API by default
828         https://bugs.webkit.org/show_bug.cgi?id=193376
829
830         Reviewed by Simon Fraser.
831
832         * WebView/WebPreferences.mm:
833         (+[WebPreferences initialize]):
834
835 2019-01-11  John Wilander  <wilander@apple.com>
836
837         Compile out Web API Statistics Collection
838         https://bugs.webkit.org/show_bug.cgi?id=193370
839         <rdar://problem/45388584>
840
841         Reviewed by Brent Fulgham.
842
843         * Configurations/FeatureDefines.xcconfig:
844             Defined ENABLE_WEB_API_STATISTICS, off by default.
845
846 2019-01-08  Alex Christensen  <achristensen@webkit.org>
847
848         Stop using NetworkStorageSession in WebProcess
849         https://bugs.webkit.org/show_bug.cgi?id=193236
850
851         Reviewed by Don Olmstead.
852
853         * WebCoreSupport/WebFrameNetworkingContext.h:
854         * WebCoreSupport/WebFrameNetworkingContext.mm:
855         (WebFrameNetworkingContext::storageSession const):
856         * WebCoreSupport/WebPlatformStrategies.h:
857         * WebCoreSupport/WebPlatformStrategies.mm:
858         (WebPlatformStrategies::cookiesForDOM):
859         (WebPlatformStrategies::setCookiesFromDOM):
860         (WebPlatformStrategies::cookiesEnabled):
861         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
862         (WebPlatformStrategies::getRawCookies):
863         (WebPlatformStrategies::deleteCookie):
864         * WebView/WebView.mm:
865         (-[WebView _cachedResponseForURL:]):
866         (-[WebView _clearCredentials]):
867
868 2019-01-08  Alex Christensen  <achristensen@webkit.org>
869
870         Unreviewed, rolling out r239727.
871
872         Broke API tests
873
874         Reverted changeset:
875
876         "Stop using NetworkStorageSession in WebProcess"
877         https://bugs.webkit.org/show_bug.cgi?id=193236
878         https://trac.webkit.org/changeset/239727
879
880 2019-01-08  Alex Christensen  <achristensen@webkit.org>
881
882         Stop using NetworkStorageSession in WebProcess
883         https://bugs.webkit.org/show_bug.cgi?id=193236
884
885         Reviewed by Don Olmstead.
886
887         * WebCoreSupport/WebFrameNetworkingContext.h:
888         * WebCoreSupport/WebFrameNetworkingContext.mm:
889         (WebFrameNetworkingContext::storageSession const):
890         * WebView/WebView.mm:
891         (-[WebView _cachedResponseForURL:]):
892         (-[WebView _clearCredentials]):
893
894 2019-01-07  David Kilzer  <ddkilzer@apple.com>
895
896         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
897         <https://webkit.org/b/193056>
898
899         Reviewed by Alex Christensen.
900
901         * Plugins/Hosted/NetscapePluginHostProxy.h:
902         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
903         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
904         (WebKit::NetscapePluginInstanceProxy::enumerate):
905         (WebKit::NetscapePluginInstanceProxy::marshalValue):
906         (WebKit::NetscapePluginInstanceProxy::marshalValues):
907         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
908         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
909         * Plugins/Hosted/ProxyInstance.mm:
910         (WebKit::ProxyInstance::invoke):
911         * WebCoreSupport/WebGeolocationClient.mm:
912         * WebView/WebDataSource.mm:
913         (-[WebDataSource _receivedData:]):
914         * WebView/WebView.mm:
915         (-[WebView _cachedResponseForURL:]):
916         - Remove '*' from RetainPtr<> type.
917
918 2019-01-04  Alex Christensen  <achristensen@webkit.org>
919
920         Progress towards fixing Mac CMake build
921         https://bugs.webkit.org/show_bug.cgi?id=193105
922
923         Reviewed by Don Olmstead.
924
925         * WebKitPrefix.h:
926
927 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
928
929         Web Inspector: Use save sheet instead of dialog where possible
930         https://bugs.webkit.org/show_bug.cgi?id=193160
931         <rdar://problem/37399759>
932
933         Reviewed by Devin Rousso.
934
935         * WebCoreSupport/WebInspectorClient.mm:
936         (WebInspectorFrontendClient::save):
937
938 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
939
940         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
941         https://bugs.webkit.org/show_bug.cgi?id=193129
942
943         Reviewed by Tim Horton.
944
945         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
946
947         * WebCoreSupport/WebEditorClient.mm:
948         (WebEditorClient::registerUndoOrRedoStep):
949         (undoNameForEditAction): Deleted.
950
951 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
952
953         Add support for using the current text selection as the find string on iOS
954         https://bugs.webkit.org/show_bug.cgi?id=193034
955         <rdar://problem/45138739>
956
957         Reviewed by Tim Horton.
958
959         Add a method stub for WebKitLegacy.
960
961         * WebCoreSupport/WebEditorClient.h:
962
963 2019-01-01  Jeff Miller  <jeffm@apple.com>
964
965         Update user-visible copyright strings to include 2019
966         https://bugs.webkit.org/show_bug.cgi?id=192811
967
968         Reviewed by Mark Lam.
969
970         * Info.plist:
971
972 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
973
974         Use Ref<> as much as possible
975         https://bugs.webkit.org/show_bug.cgi?id=192808
976
977         Reviewed by Alex Christensen.
978
979         * DOM/DOM.mm:
980         (-[DOMNode getPreviewSnapshotImage:andRects:]):
981         * Plugins/Hosted/NetscapePluginHostManager.mm:
982         (WebKit::NetscapePluginHostManager::instantiatePlugin):
983         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
984         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
985         (WebKit::NetscapePluginInstanceProxy::loadRequest):
986         * Plugins/WebNetscapePluginView.mm:
987         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
988         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
989         * WebCoreSupport/WebContextMenuClient.mm:
990         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
991         * WebCoreSupport/WebFrameLoaderClient.mm:
992         (WebFrameLoaderClient::transitionToCommittedForNewPage):
993         * WebView/WebFrame.mm:
994         (-[WebFrame getDictationResultRanges:andMetadatas:]):
995         * WebView/WebHTMLView.mm:
996         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
997         * WebView/WebView.mm:
998         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
999         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1000
1001 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1002
1003         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1004         https://bugs.webkit.org/show_bug.cgi?id=192821
1005
1006         Reviewed by Chris Dumez.
1007
1008         When a window becomes occluded, the window server informs the application.
1009         This should be used to suspend any work that is not visible by the user.
1010
1011         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1012         In some cases, that lead to performance impact (see radar).
1013
1014         This patch adds an observer for the occlusion notification. I tried to stick
1015         with the same names used by WebKit2.
1016
1017         * WebView/WebView.mm:
1018         (-[WebView _isViewVisible]):
1019         (-[WebView addWindowObserversForWindow:]):
1020         (-[WebView removeWindowObservers]):
1021         (-[WebView _windowDidChangeOcclusionState:]):
1022
1023 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1024
1025         [WebAuthN] Add a runtime flag for local authenticator
1026         https://bugs.webkit.org/show_bug.cgi?id=192792
1027         <rdar://problem/46798738>
1028
1029         Reviewed by Brent Fulgham.
1030
1031         * WebView/WebPreferenceKeysPrivate.h:
1032         * WebView/WebPreferences.mm:
1033         (+[WebPreferences initialize]):
1034         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1035         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1036         * WebView/WebPreferencesPrivate.h:
1037         * WebView/WebView.mm:
1038         (-[WebView _preferencesChanged:]):
1039
1040 2018-12-20  Chris Dumez  <cdumez@apple.com>
1041
1042         Use Optional::valueOr() instead of Optional::value_or()
1043         https://bugs.webkit.org/show_bug.cgi?id=192933
1044
1045         Reviewed by Geoffrey Garen.
1046
1047         * WebCoreSupport/WebSecurityOrigin.mm:
1048         (-[WebSecurityOrigin port]):
1049
1050 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1051
1052         Unreviewed, rolling out r239417.
1053
1054         Introduced two API test failures on macOS.
1055
1056         Reverted changeset:
1057
1058         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1059         occlusion changes"
1060         https://bugs.webkit.org/show_bug.cgi?id=192821
1061         https://trac.webkit.org/changeset/239417
1062
1063 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1064
1065         WKWebView default UA doesn't freeze the build number
1066         https://bugs.webkit.org/show_bug.cgi?id=192809
1067         <rdar://problem/44687185>
1068
1069         Reviewed by Andy Estes.
1070
1071         Always reports the frozen build number.
1072
1073         * WebView/WebView.mm:
1074         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1075         actual build number through this method call.
1076         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1077
1078 2018-12-19  Chris Dumez  <cdumez@apple.com>
1079
1080         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1081         https://bugs.webkit.org/show_bug.cgi?id=192728
1082         <rdar://problem/46746779>
1083
1084         Reviewed by Geoff Garen.
1085
1086         * DOM/*:
1087         * Plugins/*:
1088         * WebCoreSupport/*:
1089         * WebView/*:
1090
1091 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1092
1093         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1094         https://bugs.webkit.org/show_bug.cgi?id=192821
1095
1096         Reviewed by Chris Dumez.
1097
1098         When a window becomes occluded, the window server informs the application.
1099         This should be used to suspend any work that is not visible by the user.
1100
1101         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1102         In some cases, that lead to performance impact (see radar).
1103
1104         This patch adds an observer for the occlusion notification. I tried to stick
1105         with the same names used by WebKit2.
1106
1107         * WebView/WebView.mm:
1108         (-[WebView _isViewVisible]):
1109         (-[WebView addWindowObserversForWindow:]):
1110         (-[WebView removeWindowObservers]):
1111         (-[WebView _windowDidChangeOcclusionState:]):
1112
1113 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1114
1115         Allow clients to set the navigator platform
1116         https://bugs.webkit.org/show_bug.cgi?id=192735
1117
1118         Reviewed by Tim Horton.
1119
1120         Add stubs to fill out the added functionality in FrameLoaderClient.
1121
1122         * WebCoreSupport/WebFrameLoaderClient.h:
1123         * WebCoreSupport/WebFrameLoaderClient.mm:
1124         (WebFrameLoaderClient::navigatorPlatform):
1125
1126 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1127
1128         offsetLeft and offsetParent should adjust across shadow boundaries
1129         https://bugs.webkit.org/show_bug.cgi?id=157437
1130         <rdar://problem/26154021>
1131
1132         Reviewed by Simon Fraser.
1133
1134         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1135
1136         * DOM/DOMElement.mm:
1137         (-[DOMElement offsetLeft]):
1138         (-[DOMElement offsetTop]):
1139         (-[DOMElement offsetParent]):
1140
1141 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1142
1143         Unreviewed build fix.
1144
1145         * WebView/WebFrame.mm:
1146         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1147
1148 2018-12-15  Darin Adler  <darin@apple.com>
1149
1150         Use warning-ignoring macros more consistently and simply
1151         https://bugs.webkit.org/show_bug.cgi?id=192743
1152
1153         Reviewed by Mark Lam.
1154
1155         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1156         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1157         compilers in Objective-C++ code.
1158
1159         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1160         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1161         accomodate non-clang compilers here. Also use #pragma once, add a missing
1162         "explicit" and fix conditionals.
1163
1164 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1165
1166         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1167         https://bugs.webkit.org/show_bug.cgi?id=192653
1168
1169         Reviewed by Wenson Hsieh.
1170
1171         * WebView/WebHTMLView.mm:
1172         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1173
1174 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1175
1176         Implement feature flag for CSS Typed OM
1177         https://bugs.webkit.org/show_bug.cgi?id=192610
1178
1179         Reviewed by Ryosuke Niwa.
1180
1181         * Configurations/FeatureDefines.xcconfig:
1182
1183 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1184
1185         WebCore shouldn't have a Objective-C class named NSCursor
1186         https://bugs.webkit.org/show_bug.cgi?id=192602
1187         <rdar://problem/46615532>
1188
1189         Reviewed by Wenson Hsieh.
1190
1191         * WebView/WebFrameView.mm:
1192         (-[WebFrameView keyDown:keyDown:]):
1193         * WebView/WebHTMLView.mm:
1194         (-[WebHTMLView keyDown:]):
1195         (-[WebHTMLView performKeyEquivalent:]):
1196         Only use NSCursor on macOS.
1197
1198 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1199
1200         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1201         https://bugs.webkit.org/show_bug.cgi?id=192573
1202
1203         Reviewed by Simon Fraser.
1204
1205         * Configurations/FeatureDefines.xcconfig:
1206
1207 2018-12-10  Antti Koivisto  <antti@apple.com>
1208
1209         Rename "forced style recalc" to "full style rebuild"
1210         https://bugs.webkit.org/show_bug.cgi?id=192572
1211
1212         Reviewed by Zalan Bujtas.
1213
1214         * WebView/WebHTMLView.mm:
1215         (-[WebHTMLView setNeedsToApplyStyles:]):
1216
1217 2018-12-10  Darin Adler  <darin@apple.com>
1218
1219         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1220         https://bugs.webkit.org/show_bug.cgi?id=192533
1221         rdar://problem/45732710
1222
1223         Reviewed by Anders Carlsson.
1224
1225         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1226         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1227
1228 2018-12-10  Darin Adler  <darin@apple.com>
1229
1230         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1231         https://bugs.webkit.org/show_bug.cgi?id=192532
1232         rdar://problem/45731047
1233
1234         Reviewed by Chris Dumez.
1235
1236         * Plugins/Hosted/NetscapePluginHostManager.mm:
1237         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1238         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1239         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1240
1241 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1242
1243         Turn WritingDirection into an enum class
1244         https://bugs.webkit.org/show_bug.cgi?id=192401
1245         Work towards <rdar://problem/42075638>
1246
1247         Reviewed by Dan Bernstein.
1248
1249         Change WritingDirection from an enum to an enum class. No change in behavior.
1250
1251         * WebView/WebHTMLView.mm:
1252         (-[WebHTMLView toggleBaseWritingDirection:]):
1253         (-[WebHTMLView changeBaseWritingDirection:]):
1254         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1255
1256 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1257
1258         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1259         https://bugs.webkit.org/show_bug.cgi?id=192272
1260
1261         Reviewed by Brady Eidson.
1262
1263         * WebCoreSupport/WebFrameLoaderClient.h:
1264         * WebCoreSupport/WebFrameLoaderClient.mm:
1265         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1266
1267 2018-12-03  Jer Noble  <jer.noble@apple.com>
1268
1269         Get rid of old, dead Mac video fullscreen code.
1270         https://bugs.webkit.org/show_bug.cgi?id=192315
1271
1272         Reviewed by Eric Carlson.
1273
1274         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1275         is no longer supported in the Mac port.
1276
1277         * WebView/WebVideoFullscreenController.h: Removed.
1278         * WebView/WebVideoFullscreenController.mm: Removed.
1279         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1280         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1281         * WebView/WebView.mm:
1282         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1283         (-[WebView _exitVideoFullscreen]):
1284
1285 2018-12-03  Daniel Bates  <dabates@apple.com>
1286
1287         [iOS] Do not handle key events that are key commands
1288         https://bugs.webkit.org/show_bug.cgi?id=191608
1289         <rdar://problem/46046013>
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         A key down event may be associated with a key command. If it is then we want to execute the
1294         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1295         event as a key command to find out.
1296
1297         * WebView/WebHTMLView.mm:
1298         (-[WebHTMLView _handleEditingKeyEvent:]):
1299
1300 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1301
1302         Add a runtime feature flag for LayoutFormattingContext.
1303         https://bugs.webkit.org/show_bug.cgi?id=192280
1304
1305         Reviewed by Simon Fraser.
1306
1307         * Configurations/FeatureDefines.xcconfig:
1308
1309 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1310
1311         Move URL from WebCore to WTF
1312         https://bugs.webkit.org/show_bug.cgi?id=190234
1313
1314         Reviewed by Keith Miller.
1315
1316         * DOM/DOMAttr.mm:
1317         * DOM/DOMBlob.mm:
1318         * DOM/DOMCSSCharsetRule.mm:
1319         * DOM/DOMCSSImportRule.mm:
1320         * DOM/DOMCSSMediaRule.mm:
1321         * DOM/DOMCSSPageRule.mm:
1322         * DOM/DOMCSSPrimitiveValue.mm:
1323         * DOM/DOMCSSRule.mm:
1324         * DOM/DOMCSSStyleDeclaration.mm:
1325         * DOM/DOMCSSStyleRule.mm:
1326         * DOM/DOMCSSStyleSheet.mm:
1327         * DOM/DOMCSSValue.mm:
1328         * DOM/DOMCharacterData.mm:
1329         * DOM/DOMCounter.mm:
1330         * DOM/DOMDocument.mm:
1331         * DOM/DOMDocumentFragment.mm:
1332         * DOM/DOMDocumentType.mm:
1333         * DOM/DOMEvent.mm:
1334         * DOM/DOMFile.mm:
1335         * DOM/DOMHTMLAnchorElement.mm:
1336         * DOM/DOMHTMLAppletElement.mm:
1337         * DOM/DOMHTMLAreaElement.mm:
1338         * DOM/DOMHTMLBRElement.mm:
1339         * DOM/DOMHTMLBaseElement.mm:
1340         * DOM/DOMHTMLBaseFontElement.mm:
1341         * DOM/DOMHTMLBodyElement.mm:
1342         * DOM/DOMHTMLButtonElement.mm:
1343         * DOM/DOMHTMLCanvasElement.mm:
1344         * DOM/DOMHTMLCollection.mm:
1345         * DOM/DOMHTMLDivElement.mm:
1346         * DOM/DOMHTMLDocument.mm:
1347         * DOM/DOMHTMLElement.mm:
1348         * DOM/DOMHTMLEmbedElement.mm:
1349         * DOM/DOMHTMLFieldSetElement.mm:
1350         * DOM/DOMHTMLFontElement.mm:
1351         * DOM/DOMHTMLFormElement.mm:
1352         * DOM/DOMHTMLFrameElement.mm:
1353         * DOM/DOMHTMLFrameSetElement.mm:
1354         * DOM/DOMHTMLHRElement.mm:
1355         * DOM/DOMHTMLHeadElement.mm:
1356         * DOM/DOMHTMLHeadingElement.mm:
1357         * DOM/DOMHTMLHtmlElement.mm:
1358         * DOM/DOMHTMLIFrameElement.mm:
1359         * DOM/DOMHTMLImageElement.mm:
1360         * DOM/DOMHTMLInputElement.mm:
1361         * DOM/DOMHTMLLIElement.mm:
1362         * DOM/DOMHTMLLabelElement.mm:
1363         * DOM/DOMHTMLLegendElement.mm:
1364         * DOM/DOMHTMLLinkElement.mm:
1365         * DOM/DOMHTMLMapElement.mm:
1366         * DOM/DOMHTMLMarqueeElement.mm:
1367         * DOM/DOMHTMLMediaElement.mm:
1368         * DOM/DOMHTMLMetaElement.mm:
1369         * DOM/DOMHTMLModElement.mm:
1370         * DOM/DOMHTMLOListElement.mm:
1371         * DOM/DOMHTMLObjectElement.mm:
1372         * DOM/DOMHTMLOptGroupElement.mm:
1373         * DOM/DOMHTMLOptionElement.mm:
1374         * DOM/DOMHTMLOptionsCollection.mm:
1375         * DOM/DOMHTMLParagraphElement.mm:
1376         * DOM/DOMHTMLParamElement.mm:
1377         * DOM/DOMHTMLQuoteElement.mm:
1378         * DOM/DOMHTMLScriptElement.mm:
1379         * DOM/DOMHTMLSelectElement.mm:
1380         * DOM/DOMHTMLStyleElement.mm:
1381         * DOM/DOMHTMLTableCaptionElement.mm:
1382         * DOM/DOMHTMLTableCellElement.mm:
1383         * DOM/DOMHTMLTableColElement.mm:
1384         * DOM/DOMHTMLTableElement.mm:
1385         * DOM/DOMHTMLTableRowElement.mm:
1386         * DOM/DOMHTMLTableSectionElement.mm:
1387         * DOM/DOMHTMLTitleElement.mm:
1388         * DOM/DOMHTMLUListElement.mm:
1389         * DOM/DOMHTMLVideoElement.mm:
1390         * DOM/DOMKeyboardEvent.mm:
1391         * DOM/DOMMediaList.mm:
1392         * DOM/DOMMouseEvent.mm:
1393         * DOM/DOMMutationEvent.mm:
1394         * DOM/DOMNamedNodeMap.mm:
1395         * DOM/DOMProcessingInstruction.mm:
1396         * DOM/DOMRange.mm:
1397         * DOM/DOMStyleSheet.mm:
1398         * DOM/DOMText.mm:
1399         * DOM/DOMTextEvent.mm:
1400         * DOM/DOMTokenList.mm:
1401         * DOM/DOMUIEvent.mm:
1402         * DOM/DOMXPathResult.mm:
1403         * History/WebHistoryItem.mm:
1404         * Misc/WebNSURLExtras.mm:
1405         (-[NSURL _web_userVisibleString]):
1406         (-[NSURL _web_URLByRemovingUserInfo]):
1407         (-[NSURL _web_dataForURLComponentType:]):
1408         (-[NSURL _web_schemeData]):
1409         (-[NSURL _web_hostData]):
1410         * Misc/WebUserContentURLPattern.mm:
1411         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1412         * Plugins/WebNetscapePluginStream.h:
1413         (WebNetscapePluginStream::setRequestURL):
1414         * WebCoreSupport/WebChromeClient.h:
1415         * WebCoreSupport/WebChromeClient.mm:
1416         (WebChromeClient::signedPublicKeyAndChallengeString const):
1417         * WebCoreSupport/WebContextMenuClient.h:
1418         * WebCoreSupport/WebContextMenuClient.mm:
1419         * WebCoreSupport/WebDragClient.h:
1420         * WebCoreSupport/WebFrameLoaderClient.h:
1421         * WebCoreSupport/WebFrameLoaderClient.mm:
1422         (WebFrameLoaderClient::updateGlobalHistory):
1423         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1424         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1425         (WebPaymentCoordinatorClient::showPaymentUI):
1426         * WebCoreSupport/WebPlatformStrategies.h:
1427         * WebCoreSupport/WebPlatformStrategies.mm:
1428         (WebPlatformStrategies::readURLFromPasteboard):
1429         * WebCoreSupport/WebPluginInfoProvider.h:
1430         * WebCoreSupport/WebPluginInfoProvider.mm:
1431         (WebPluginInfoProvider::webVisiblePluginInfo):
1432         * WebCoreSupport/WebSecurityOrigin.mm:
1433         * WebCoreSupport/WebVisitedLinkStore.h:
1434         * WebView/WebDataSource.mm:
1435         * WebView/WebFrame.mm:
1436         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1437         * WebView/WebImmediateActionController.mm:
1438         (-[WebImmediateActionController _defaultAnimationController]):
1439         * WebView/WebPDFView.mm:
1440         * WebView/WebScriptDebugger.mm:
1441         * WebView/WebViewInternal.h:
1442
1443 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1444
1445         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1446         https://bugs.webkit.org/show_bug.cgi?id=192197
1447
1448         Reviewed by Jiewen Tan.
1449
1450         * Configurations/FeatureDefines.xcconfig:
1451         * WebCoreSupport/WebChromeClient.h:
1452         * WebCoreSupport/WebChromeClient.mm:
1453
1454 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1455
1456         Remove dead code from an earlier attempt at implementing safe browsing
1457         https://bugs.webkit.org/show_bug.cgi?id=192067
1458
1459         Reviewed by Chris Dumez.
1460
1461         * WebCoreSupport/WebFrameLoaderClient.h:
1462         * WebCoreSupport/WebFrameLoaderClient.mm:
1463         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1464
1465 2018-11-27  Mark Lam  <mark.lam@apple.com>
1466
1467         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1468         https://bugs.webkit.org/show_bug.cgi?id=192055
1469         <rdar://problem/46288783>
1470
1471         Reviewed by Saam Barati.
1472
1473         * Configurations/FeatureDefines.xcconfig:
1474
1475 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1476
1477         Make it possible to insert editable images with a gesture
1478         https://bugs.webkit.org/show_bug.cgi?id=191937
1479
1480         Reviewed by Wenson Hsieh.
1481
1482         * WebCoreSupport/WebEditorClient.mm:
1483         (undoNameForEditAction):
1484         Add a undo name.
1485
1486 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1487
1488         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1489         https://bugs.webkit.org/show_bug.cgi?id=191945
1490
1491         Reviewed by Anders Carlsson.
1492
1493         * WebCoreSupport/WebEditorClient.mm:
1494         (undoNameForEditAction):
1495
1496 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1497
1498         Enable drag and drop support for iOSMac
1499         https://bugs.webkit.org/show_bug.cgi?id=191818
1500         <rdar://problem/43907454>
1501
1502         Reviewed by Dean Jackson.
1503
1504         * Configurations/FeatureDefines.xcconfig:
1505
1506 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1507
1508         Address post-review feedback after r238438
1509         https://bugs.webkit.org/show_bug.cgi?id=191913
1510
1511         Reviewed by Ryosuke Niwa.
1512
1513         * WebView/WebFrame.mm:
1514         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1515         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1516         * WebView/WebView.mm:
1517         (-[WebView setSelectedDOMRange:affinity:]):
1518
1519 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1520
1521         Web Inspector: "Reload Web Inspector" button no longer partially works
1522         https://bugs.webkit.org/show_bug.cgi?id=191773
1523         <rdar://problem/46139932>
1524
1525         Reviewed by Devin Rousso.
1526
1527         * WebCoreSupport/WebInspectorClient.h:
1528         * WebCoreSupport/WebInspectorClient.mm:
1529         (WebInspectorFrontendClient::reopen):
1530
1531 2018-11-17  Devin Rousso  <drousso@apple.com>
1532
1533         Web Inspector: Network: add button to show system certificate dialog
1534         https://bugs.webkit.org/show_bug.cgi?id=191458
1535         <rdar://problem/45977019>
1536
1537         Reviewed by Joseph Pecoraro.
1538
1539         * WebCoreSupport/WebInspectorClient.h:
1540         * WebCoreSupport/WebInspectorClient.mm:
1541         (WebInspectorFrontendClient::showCertificate): Added.
1542
1543         * Configurations/WebKitLegacy.xcconfig:
1544
1545 2018-11-15  Truitt Savell  <tsavell@apple.com>
1546
1547         Unreviewed, rolling out r238244.
1548
1549         Caused High Sierra test runs to fail early with 50 crashes and
1550         casued 25 API failures.
1551
1552         Reverted changeset:
1553
1554         "[css-logical] Implement flow-relative margin, padding and
1555         border shorthands"
1556         https://bugs.webkit.org/show_bug.cgi?id=188697
1557         https://trac.webkit.org/changeset/238244
1558
1559 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1560
1561         [css-logical] Implement flow-relative margin, padding and border shorthands
1562         https://bugs.webkit.org/show_bug.cgi?id=188697
1563
1564         Reviewed by Simon Fraser and Antti Koivisto.
1565
1566         Add CSSLogicalEnabled runtime flag.
1567
1568         * WebView/WebPreferenceKeysPrivate.h:
1569         * WebView/WebPreferences.mm:
1570         (+[WebPreferences initialize]):
1571         (-[WebPreferences cssLogicalEnabled]):
1572         (-[WebPreferences setCSSLogicalEnabled:]):
1573         * WebView/WebPreferencesPrivate.h:
1574         * WebView/WebView.mm:
1575         (-[WebView _preferencesChanged:]):
1576
1577 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1578
1579         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1580         https://bugs.webkit.org/show_bug.cgi?id=191612
1581
1582         Reviewed by Matt Baker.
1583
1584         * WebCoreSupport/WebInspectorClient.mm:
1585         (-[WebInspectorWindowController destroyInspectorView]):
1586
1587 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1588
1589         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1590         https://bugs.webkit.org/show_bug.cgi?id=191494
1591         <rdar://problem/45469854>
1592
1593         Reviewed by Devin Rousso.
1594
1595         * WebCoreSupport/WebInspectorClient.h:
1596         WebKitLegacy will still have remote inspection of the Page directly.
1597
1598 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1599
1600         Make compositing updates incremental
1601         https://bugs.webkit.org/show_bug.cgi?id=90342
1602
1603         Reviewed by Antti Koivisto.
1604
1605         Fix spelling error.
1606
1607         * WebView/WebView.mm:
1608         (-[WebView _setMediaLayer:forPluginView:]):
1609
1610 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1611
1612         Implement a new edit command to change the enclosing list type
1613         https://bugs.webkit.org/show_bug.cgi?id=191487
1614         <rdar://problem/45955922>
1615
1616         Reviewed by Ryosuke Niwa.
1617
1618         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1619
1620         * WebCoreSupport/WebEditorClient.mm:
1621         (undoNameForEditAction):
1622
1623 2018-11-11  Daniel Bates  <dabates@apple.com>
1624
1625         [iOS] Draw caps lock indicator in password fields
1626         https://bugs.webkit.org/show_bug.cgi?id=190565
1627         <rdar://problem/45262343>
1628
1629         Reviewed by Dean Jackson.
1630
1631         Update the caps lock state when a hardware keyboard is attached or detached.
1632
1633         * WebView/WebHTMLView.mm:
1634         (hardwareKeyboardAvailabilityChangedCallback): Added.
1635         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1636         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1637
1638 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1639
1640         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1641         https://bugs.webkit.org/show_bug.cgi?id=191492
1642
1643         Reviewed by Alex Christensen.
1644
1645         * Carbon/HIWebView.mm:
1646         * Misc/WebNSFileManagerExtras.mm:
1647         * Misc/WebNSURLExtras.mm:
1648         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1649         * Plugins/WebBasePluginPackage.mm:
1650         * Plugins/WebPluginContainerCheck.mm:
1651         * WebCoreSupport/WebCachedFramePlatformData.h:
1652         * WebCoreSupport/WebDeviceOrientationClient.mm:
1653         * WebView/WebDelegateImplementationCaching.mm:
1654         * WebView/WebHTMLView.mm:
1655         * WebView/WebPDFRepresentation.mm:
1656         * WebView/WebPolicyDelegate.mm:
1657         * WebView/WebView.mm:
1658
1659 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1660
1661         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1662         https://bugs.webkit.org/show_bug.cgi?id=191492
1663
1664         Reviewed by Alex Christensen.
1665
1666         * Carbon/HIWebView.mm:
1667         (UpdateCommandStatus):
1668         * Misc/WebNSFileManagerExtras.mm:
1669         * Misc/WebNSURLExtras.mm:
1670         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1671         * Plugins/WebBasePluginPackage.mm:
1672         * Plugins/WebPluginContainerCheck.mm:
1673         (-[WebPluginContainerCheck _continueWithPolicy:]):
1674         * WebCoreSupport/WebCachedFramePlatformData.h:
1675         (WebCachedFramePlatformData::clear):
1676         * WebCoreSupport/WebDeviceOrientationClient.mm:
1677         (WebDeviceOrientationClient::getProvider const):
1678         * WebView/WebDelegateImplementationCaching.mm:
1679         (CallDelegate):
1680         (CallDelegateReturningBoolean):
1681         (CallResourceLoadDelegateReturningBoolean):
1682         (CallFormDelegate):
1683         (CallFormDelegateReturningBoolean):
1684         * WebView/WebHTMLView.mm:
1685         * WebView/WebPDFRepresentation.mm:
1686         * WebView/WebPolicyDelegate.mm:
1687         (-[WebPolicyDecisionListener _usePolicy:]):
1688         * WebView/WebView.mm:
1689
1690 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1691
1692         Unreviewed, rolling out r238047.
1693
1694         Introduced layout test failures on iOS simulator.
1695
1696         Reverted changeset:
1697
1698         "[iOS] Draw caps lock indicator in password fields"
1699         https://bugs.webkit.org/show_bug.cgi?id=190565
1700         https://trac.webkit.org/changeset/238047
1701
1702 2018-11-09  Antti Koivisto  <antti@apple.com>
1703
1704         Use OptionSet for layout milestones
1705         https://bugs.webkit.org/show_bug.cgi?id=191470
1706
1707         Reviewed by Dean Jackson.
1708
1709         * WebCoreSupport/WebFrameLoaderClient.h:
1710         * WebCoreSupport/WebFrameLoaderClient.mm:
1711         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1712         * WebView/WebView.mm:
1713         (coreLayoutMilestones):
1714         (kitLayoutMilestones):
1715         (-[WebView _cacheFrameLoadDelegateImplementations]):
1716         * WebView/WebViewInternal.h:
1717
1718 2018-11-09  Daniel Bates  <dabates@apple.com>
1719
1720         [iOS] Draw caps lock indicator in password fields
1721         https://bugs.webkit.org/show_bug.cgi?id=190565
1722         <rdar://problem/45262343>
1723
1724         Reviewed by Dean Jackson.
1725
1726         Update the caps lock state when a hardware keyboard is attached or detached.
1727
1728         * WebView/WebHTMLView.mm:
1729         (hardwareKeyboardAvailabilityChangedCallback): Added.
1730         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1731         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1732
1733 2018-11-09  Daniel Bates  <dabates@apple.com>
1734
1735         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1736         action when forward delete is pressed outside a text field
1737         https://bugs.webkit.org/show_bug.cgi?id=190566
1738         <rdar://problem/45262367>
1739
1740         Reviewed by Wenson Hsieh.
1741
1742         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1743         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1744         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1745
1746         * WebView/WebHTMLView.mm:
1747         (-[WebHTMLView _handleEditingKeyEvent:]):
1748
1749 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1750
1751         Adopt Reveal Framework to replace Lookup
1752         https://bugs.webkit.org/show_bug.cgi?id=191097
1753         <rdar://problem/45924508>
1754
1755         Reviewed by Tim Horton.
1756
1757         Pass in what it needed to clear the textIndicators. This is better than
1758         the current notification structure.
1759
1760         * WebView/WebView.mm:
1761         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1762         (-[WebView _prepareForDictionaryLookup]):
1763
1764 2018-11-06  Justin Fan  <justin_fan@apple.com>
1765
1766         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1767         https://bugs.webkit.org/show_bug.cgi?id=191291
1768
1769         Reviewed by Myles Maxfield.
1770
1771         Properly disable WEBGPU on all non-Metal platforms for now.
1772
1773         * Configurations/FeatureDefines.xcconfig:
1774
1775 2018-11-02  Daniel Bates  <dabates@apple.com>
1776
1777         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1778         https://bugs.webkit.org/show_bug.cgi?id=190487
1779
1780         Reviewed by Tim Horton.
1781
1782         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1783         allow the default handling.
1784
1785         * WebView/WebHTMLView.mm:
1786         (-[WebHTMLView _handleEditingKeyEvent:]):
1787
1788 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1789
1790         Add a storage limit for IndexedDB
1791         https://bugs.webkit.org/show_bug.cgi?id=190598
1792         <rdar://problem/44654715>
1793
1794         Reviewed by Chris Dumez.
1795
1796         * Storage/WebDatabaseManager.mm:
1797         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1798         * Storage/WebDatabaseManagerPrivate.h:
1799
1800 2018-10-31  Antti Koivisto  <antti@apple.com>
1801
1802         Remove LayerFlushScheduler
1803         https://bugs.webkit.org/show_bug.cgi?id=191103
1804
1805         Reviewed by Anders Carlsson.
1806
1807         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1808         all the virtual cruft.
1809
1810         * WebView/WebViewData.h:
1811         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1812         (): Deleted.
1813         * WebView/WebViewData.mm:
1814         (currentRunLoop):
1815         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1816         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1817         (WebViewLayerFlushScheduler::schedule):
1818         (WebViewLayerFlushScheduler::invalidate):
1819         (WebViewLayerFlushScheduler::layerFlushCallback):
1820
1821 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1822
1823         Enable InstallAPI for iOS unconditionally
1824         https://bugs.webkit.org/show_bug.cgi?id=191043
1825         rdar://problem/32728423
1826
1827         Reviewed by Dan Bernstein.
1828
1829         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1830         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1831         shouldn't be processed by InstallAPI.
1832         * MigrateHeaders.make: Removed an obsolete workaround.
1833         * Misc/NSURLDownloadSPI.h: Added.
1834         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1835
1836 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1837
1838         Clean up some obsolete MAX_ALLOWED macros
1839         https://bugs.webkit.org/show_bug.cgi?id=190916
1840
1841         Reviewed by Tim Horton.
1842
1843         * WebView/WebHTMLView.mm:
1844         (-[WebHTMLView pressureChangeWithEvent:]):
1845         * WebView/WebPDFView.h:
1846
1847 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1848
1849         Unreviewed, rolling out r237600 and r237604.
1850         https://bugs.webkit.org/show_bug.cgi?id=191086
1851
1852         Breaks internal iOS builds (Requested by ryanhadd_ on
1853         #webkit).
1854
1855         Reverted changesets:
1856
1857         "Enable InstallAPI for iOS unconditionally"
1858         https://bugs.webkit.org/show_bug.cgi?id=191043
1859         https://trac.webkit.org/changeset/237600
1860
1861         "Build fix attempt after enabling InstallAPI for iOS."
1862         https://bugs.webkit.org/show_bug.cgi?id=191043
1863         https://trac.webkit.org/changeset/237604
1864
1865 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1866
1867         Enable InstallAPI for iOS unconditionally
1868         https://bugs.webkit.org/show_bug.cgi?id=191043
1869         rdar://problem/32728423
1870
1871         Reviewed by Dan Bernstein.
1872
1873         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1874         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1875         shouldn't be processed by InstallAPI.
1876         * MigrateHeaders.make: Removed an obsolete workaround.
1877         * Misc/NSURLDownloadSPI.h: Added.
1878         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1879
1880 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1881
1882         Modernize WebKit nibs and lprojs for localization's sake
1883         https://bugs.webkit.org/show_bug.cgi?id=190911
1884         <rdar://problem/45349466>
1885
1886         Reviewed by Dan Bernstein.
1887
1888         * Misc/WebNSControlExtras.m:
1889         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1890         NSWindow and its contents are both in the same scale space these days; avoid
1891         double-applying the scale factor, or you can't see the prompt.
1892
1893         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1894         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1895         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1896         NIB->XIB
1897
1898 2018-10-25  Antoine Quint  <graouts@apple.com>
1899
1900         [Web Animations] Turn Web Animations CSS Integration off by default
1901         https://bugs.webkit.org/show_bug.cgi?id=190901
1902
1903         Reviewed by Dean Jackson.
1904
1905         * WebView/WebPreferences.mm:
1906         (+[WebPreferences initialize]):
1907
1908 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1909
1910         Clean up some obsolete macOS version guards
1911         https://bugs.webkit.org/show_bug.cgi?id=190887
1912
1913         Reviewed by Dan Bernstein.
1914
1915         * Misc/WebNSPasteboardExtras.mm:
1916         (+[NSPasteboard _web_dragTypesForURL]):
1917         * WebCoreSupport/PopupMenuMac.mm:
1918         (PopupMenuMac::show):
1919         * WebCoreSupport/WebEditorClient.h:
1920         * WebCoreSupport/WebEditorClient.mm:
1921         (WebEditorClient::respondToChangedSelection):
1922         * WebView/WebPDFView.mm:
1923         (-[WebPDFView _clipViewForPDFDocumentView]):
1924
1925 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1926
1927         Turn on Conic Gradients
1928         https://bugs.webkit.org/show_bug.cgi?id=190810
1929
1930         Reviewed by Tim Horton.
1931
1932         * Configurations/FeatureDefines.xcconfig:
1933
1934 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1935
1936         Cleanup: MIMETypeRegistry functions
1937         https://bugs.webkit.org/show_bug.cgi?id=190838
1938
1939         Reviewed by Simon Fraser.
1940
1941         * Misc/WebNSPasteboardExtras.mm:
1942         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1943         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1944         because they were identical.
1945
1946         * WebView/WebHTMLRepresentation.mm:
1947         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1948         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1949         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1950         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1951         * WebView/WebView.mm:
1952         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1953         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1954         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1955
1956 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1957
1958         Fix false positive leaks when using custom -init methods that don't start with -init
1959         <https://webkit.org/b/190818>
1960         <rdar://problem/45476042>
1961
1962         Reviewed by Dan Bernstein.
1963
1964         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1965         it is accessible by both categories.
1966         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1967         NSError (WebKitInternal) category.  Add attribute to make this
1968         behave like an -init method.
1969         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1970         NSError (WebKitInternal) category.  Modernize method.  Replace
1971         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1972
1973 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1974
1975         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1976         https://bugs.webkit.org/show_bug.cgi?id=190729
1977
1978         Reviewed by Tim Horton.
1979
1980         * DOM/DOM.mm:
1981         (-[DOMNode boundingBox]):
1982         * DOM/DOMElement.mm:
1983         * DOM/DOMHTML.mm:
1984         * DOM/DOMInternal.mm:
1985         * DOM/DOMUIKitExtensions.mm:
1986         * DOM/WebDOMOperations.mm:
1987         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1988         * DefaultDelegates/WebDefaultEditingDelegate.m:
1989         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1990         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1991         * DefaultDelegates/WebDefaultUIDelegate.h:
1992         * DefaultDelegates/WebDefaultUIDelegate.mm:
1993         (-[WebDefaultUIDelegate webViewClose:]):
1994         (-[WebDefaultUIDelegate webViewFocus:]):
1995         (-[WebDefaultUIDelegate webViewUnfocus:]):
1996         (-[WebDefaultUIDelegate webViewIsResizable:]):
1997         (-[WebDefaultUIDelegate webView:setResizable:]):
1998         (-[WebDefaultUIDelegate webView:setFrame:]):
1999         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2000         * History/BackForwardList.h:
2001         * History/BackForwardList.mm:
2002         * History/WebBackForwardList.mm:
2003         (+[WebBackForwardList initialize]):
2004         (bumperCarBackForwardHackNeeded):
2005         * History/WebHistory.mm:
2006         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2007         (-[WebHistory _sendNotification:entries:]):
2008         (-[WebHistory loadFromURL:error:]):
2009         (-[WebHistory saveToURL:error:]):
2010         * History/WebHistoryItem.mm:
2011         (WKNotifyHistoryItemChanged):
2012         (+[WebHistoryItem initialize]):
2013         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2014         * History/WebURLsWithTitles.m:
2015         * Misc/WebCache.mm:
2016         (+[WebCache initialize]):
2017         * Misc/WebDownload.mm:
2018         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2019         * Misc/WebElementDictionary.mm:
2020         (+[WebElementDictionary initialize]):
2021         (+[WebElementDictionary initializeLookupTable]):
2022         * Misc/WebIconDatabase.mm:
2023         * Misc/WebKitNSStringExtras.mm:
2024         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2025         * Misc/WebKitVersionChecks.h:
2026         * Misc/WebKitVersionChecks.mm:
2027         (WebKitLinkedOnOrAfter):
2028         (WebKitLinkTimeVersion):
2029         * Misc/WebLocalizableStrings.mm:
2030         * Misc/WebNSControlExtras.h:
2031         * Misc/WebNSControlExtras.m:
2032         * Misc/WebNSEventExtras.m:
2033         * Misc/WebNSFileManagerExtras.mm:
2034         * Misc/WebNSImageExtras.h:
2035         * Misc/WebNSImageExtras.m:
2036         * Misc/WebNSPasteboardExtras.mm:
2037         * Misc/WebNSPrintOperationExtras.h:
2038         * Misc/WebNSPrintOperationExtras.m:
2039         * Misc/WebNSViewExtras.m:
2040         * Misc/WebNSWindowExtras.m:
2041         * Panels/WebAuthenticationPanel.h:
2042         * Panels/WebAuthenticationPanel.m:
2043         * Panels/WebPanelAuthenticationHandler.m:
2044         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2045         (+[WebHostedNetscapePluginView initialize]):
2046         * Plugins/WebBasePluginPackage.h:
2047         * Plugins/WebBasePluginPackage.mm:
2048         * Plugins/WebJavaPlugIn.h:
2049         * Plugins/WebPluginContainerCheck.mm:
2050         * Plugins/WebPluginController.h:
2051         * Plugins/WebPluginController.mm:
2052         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2053         (-[WebPluginController addPlugin:]):
2054         (-[WebPluginController destroyPlugin:]):
2055         (-[WebPluginController destroyAllPlugins]):
2056         * Plugins/WebPluginDatabase.mm:
2057         (+[WebPluginDatabase _defaultPlugInPaths]):
2058         * Plugins/WebPluginPackage.mm:
2059         (-[WebPluginPackage initWithPath:]):
2060         * Storage/WebDatabaseManager.mm:
2061         (-[WebDatabaseManager deleteAllDatabases]):
2062         * Storage/WebDatabaseManagerClient.h:
2063         * Storage/WebDatabaseManagerClient.mm:
2064         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2065         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2066         * Storage/WebStorageManager.mm:
2067         (-[WebStorageManager deleteAllOrigins]):
2068         (WebKitInitializeStorageIfNecessary):
2069         * WebCoreSupport/WebAlternativeTextClient.h:
2070         * WebCoreSupport/WebApplicationCache.mm:
2071         (applicationCacheBundleIdentifier):
2072         * WebCoreSupport/WebChromeClient.h:
2073         * WebCoreSupport/WebChromeClient.mm:
2074         (WebChromeClient::setWindowRect):
2075         (WebChromeClient::windowRect):
2076         (WebChromeClient::takeFocus):
2077         (WebChromeClient::addMessageToConsole):
2078         (WebChromeClient::enableSuddenTermination):
2079         (WebChromeClient::disableSuddenTermination):
2080         (WebChromeClient::createPopupMenu const):
2081         (WebChromeClient::createSearchPopupMenu const):
2082         (WebChromeClient::shouldPaintEntireContents const):
2083         (WebChromeClient::supportsVideoFullscreen):
2084         (WebChromeClient::supportsFullScreenForElement):
2085         (WebChromeClient::enterFullScreenForElement):
2086         (WebChromeClient::exitFullScreenForElement):
2087         * WebCoreSupport/WebContextMenuClient.mm:
2088         * WebCoreSupport/WebDragClient.mm:
2089         * WebCoreSupport/WebEditorClient.h:
2090         * WebCoreSupport/WebEditorClient.mm:
2091         (+[WebUndoStep initialize]):
2092         (updateFontPanel):
2093         (WebEditorClient::didBeginEditing):
2094         (WebEditorClient::respondToChangedContents):
2095         (WebEditorClient::respondToChangedSelection):
2096         (WebEditorClient::canceledComposition):
2097         (WebEditorClient::didEndEditing):
2098         (WebEditorClient::didWriteSelectionToPasteboard):
2099         (attributesForAttributedStringConversion):
2100         (WebEditorClient::setInsertionPasteboard):
2101         (WebEditorClient::registerUndoOrRedoStep):
2102         (WebEditorClient::handleKeyboardEvent):
2103         (WebEditorClient::handleInputMethodKeydown):
2104         (WebEditorClient::textDidChangeInTextField):
2105         (WebEditorClient::requestCheckingOfString):
2106         * WebCoreSupport/WebFrameLoaderClient.h:
2107         * WebCoreSupport/WebFrameLoaderClient.mm:
2108         (WebFrameLoaderClient::detachedFromParent2):
2109         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2110         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2111         (WebFrameLoaderClient::dispatchWillSendRequest):
2112         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2113         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2114         (WebFrameLoaderClient::willCacheResponse const):
2115         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2116         (WebFrameLoaderClient::dispatchDidFinishLoading):
2117         (WebFrameLoaderClient::dispatchDidFailLoading):
2118         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2119         (WebFrameLoaderClient::dispatchWillClose):
2120         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2121         (WebFrameLoaderClient::dispatchDidCommitLoad):
2122         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2123         (WebFrameLoaderClient::dispatchDidFailLoad):
2124         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2125         (WebFrameLoaderClient::dispatchDidFinishLoad):
2126         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2127         (WebFrameLoaderClient::willChangeTitle):
2128         (WebFrameLoaderClient::didChangeTitle):
2129         (WebFrameLoaderClient::didReplaceMultipartContent):
2130         (WebFrameLoaderClient::updateGlobalHistory):
2131         (WebFrameLoaderClient::saveViewStateToItem):
2132         (WebFrameLoaderClient::restoreViewState):
2133         (WebFrameLoaderClient::provisionalLoadStarted):
2134         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2135         (WebFrameLoaderClient::setTitle):
2136         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2137         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2138         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2139         (WebFrameLoaderClient::didRestoreFromPageCache):
2140         (WebFrameLoaderClient::actionDictionary const):
2141         (WebFrameLoaderClient::createPlugin):
2142         (WebFrameLoaderClient::getLoadDecisionForIcons):
2143         (WebFrameLoaderClient::finishedLoadingIcon):
2144         (+[WebFramePolicyListener initialize]):
2145         * WebCoreSupport/WebFrameNetworkingContext.mm:
2146         * WebCoreSupport/WebGeolocationClient.h:
2147         * WebCoreSupport/WebGeolocationClient.mm:
2148         (WebGeolocationClient::requestPermission):
2149         * WebCoreSupport/WebInspectorClient.h:
2150         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2151         * WebCoreSupport/WebNotificationClient.mm:
2152         * WebCoreSupport/WebOpenPanelResultListener.mm:
2153         * WebCoreSupport/WebPlatformStrategies.h:
2154         * WebCoreSupport/WebPlatformStrategies.mm:
2155         * WebCoreSupport/WebProgressTrackerClient.h:
2156         * WebCoreSupport/WebProgressTrackerClient.mm:
2157         (WebProgressTrackerClient::progressStarted):
2158         (WebProgressTrackerClient::progressEstimateChanged):
2159         (WebProgressTrackerClient::progressFinished):
2160         * WebCoreSupport/WebSecurityOrigin.mm:
2161         * WebInspector/WebNodeHighlight.h:
2162         * WebInspector/WebNodeHighlight.mm:
2163         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2164         (-[WebNodeHighlight dealloc]):
2165         (-[WebNodeHighlight attach]):
2166         * WebInspector/WebNodeHighlightView.h:
2167         * WebInspector/WebNodeHighlightView.mm:
2168         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2169         (-[WebNodeHighlightView dealloc]):
2170         * WebInspector/WebNodeHighlighter.mm:
2171         (-[WebNodeHighlighter highlight]):
2172         * WebView/WebArchive.mm:
2173         (+[WebArchivePrivate initialize]):
2174         * WebView/WebClipView.h:
2175         * WebView/WebDataSource.mm:
2176         (WebDataSourcePrivate::WebDataSourcePrivate):
2177         (+[WebDataSource initialize]):
2178         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2179         (-[WebDataSource _makeRepresentation]):
2180         * WebView/WebDelegateImplementationCaching.h:
2181         * WebView/WebDelegateImplementationCaching.mm:
2182         (CallDelegate):
2183         (CallDelegateReturningFloat):
2184         (CallDelegateReturningBoolean):
2185         (CallUIDelegate):
2186         (CallUIDelegateReturningFloat):
2187         (CallUIDelegateReturningBoolean):
2188         (CallFrameLoadDelegate):
2189         (CallFrameLoadDelegateReturningBoolean):
2190         (CallResourceLoadDelegate):
2191         (CallScriptDebugDelegate):
2192         (CallFormDelegate):
2193         (CallFormDelegateReturningBoolean):
2194         * WebView/WebDeviceOrientation.mm:
2195         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2196         * WebView/WebDocumentInternal.h:
2197         * WebView/WebDocumentLoaderMac.mm:
2198         (needsDataLoadWorkaround):
2199         * WebView/WebDynamicScrollBarsViewInternal.h:
2200         * WebView/WebFormDelegate.m:
2201         * WebView/WebFrame.mm:
2202         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2203         (-[WebFrame _unmarkAllMisspellings]):
2204         (-[WebFrame _paintBehaviorForDestinationContext:]):
2205         (-[WebFrame _drawRect:contentsOnly:]):
2206         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2207         (-[WebFrame _scrollDOMRangeToVisible:]):
2208         (-[WebFrame _bodyBackgroundColor]):
2209         (-[WebFrame accessibilityRoot]):
2210         (needsMicrosoftMessengerDOMDocumentWorkaround):
2211         * WebView/WebFrameInternal.h:
2212         * WebView/WebFrameView.mm:
2213         (-[WebFrameView _setDocumentView:]):
2214         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2215         (-[WebFrameView _viewClassForMIMEType:]):
2216         (-[WebFrameView initWithFrame:]):
2217         (-[WebFrameView drawRect:]):
2218         (-[WebFrameView _firstResponderIsFormControl]):
2219         (-[WebFrameView keyDown:keyDown:]):
2220         (-[WebFrameView _isScrollable]):
2221         * WebView/WebFullScreenController.h:
2222         * WebView/WebFullScreenController.mm:
2223         * WebView/WebHTMLRepresentation.mm:
2224         * WebView/WebHTMLView.mm:
2225         (-[WebHTMLView hitTest:]):
2226         (-[WebHTMLView initWithFrame:]):
2227         (-[WebHTMLView dealloc]):
2228         (-[WebHTMLView addSubview:]):
2229         (-[WebHTMLView mouseDown:]):
2230         (-[WebHTMLView mouseUp:]):
2231         (-[WebHTMLView resignFirstResponder]):
2232         (-[WebHTMLView accessibilityHitTest:]):
2233         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2234         * WebView/WebHTMLViewInternal.h:
2235         * WebView/WebIndicateLayer.h:
2236         * WebView/WebIndicateLayer.mm:
2237         * WebView/WebMediaPlaybackTargetPicker.h:
2238         * WebView/WebMediaPlaybackTargetPicker.mm:
2239         * WebView/WebPDFDocumentExtras.h:
2240         * WebView/WebPDFDocumentExtras.mm:
2241         * WebView/WebPDFRepresentation.h:
2242         * WebView/WebPDFRepresentation.mm:
2243         * WebView/WebPDFView.h:
2244         * WebView/WebPreferences.mm:
2245         (cacheModelForMainBundle):
2246         (WebPreferencesPrivate::WebPreferencesPrivate):
2247         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2248         (-[WebPreferences encodeWithCoder:]):
2249         (+[WebPreferences standardPreferences]):
2250         (+[WebPreferences initialize]):
2251         (-[WebPreferences _valueForKey:]):
2252         (-[WebPreferences _setStringValue:forKey:]):
2253         (-[WebPreferences _setIntegerValue:forKey:]):
2254         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2255         (-[WebPreferences _setFloatValue:forKey:]):
2256         (-[WebPreferences _setBoolValue:forKey:]):
2257         (-[WebPreferences _setLongLongValue:forKey:]):
2258         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2259         (-[WebPreferences _postCacheModelChangedNotification]):
2260         (-[WebPreferences _postPreferencesChangedNotification]):
2261         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2262         (-[WebPreferences setStorageBlockingPolicy:]):
2263         * WebView/WebResource.mm:
2264         (+[WebResourcePrivate initialize]):
2265         * WebView/WebTextCompletionController.h:
2266         * WebView/WebTextIterator.mm:
2267         (+[WebTextIteratorPrivate initialize]):
2268         * WebView/WebView.mm:
2269         (shouldEnableLoadDeferring):
2270         (shouldRestrictWindowFocus):
2271         (shouldRespectPriorityInCSSAttributeSetters):
2272         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2273         (shouldAllowPictureInPictureMediaPlayback):
2274         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2275         (shouldAllowWindowOpenWithoutUserGesture):
2276         (shouldConvertInvalidURLsToBlank):
2277         (shouldRequireUserGestureToLoadVideo):
2278         (-[WebView _commonInitializationWithFrameName:groupName:]):
2279         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2280         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2281         (-[WebView _closePluginDatabases]):
2282         (-[WebView _closeWithFastTeardown]):
2283         (-[WebView _close]):
2284         (+[WebView _MIMETypeForFile:]):
2285         (-[WebView setShowingInspectorIndication:]):
2286         (-[WebView _setFormDelegate:]):
2287         (-[WebView _needsPreHTML5ParserQuirks]):
2288         (-[WebView _preferencesChangedNotification:]):
2289         (-[WebView _preferencesChanged:]):
2290         (-[WebView _cacheResourceLoadDelegateImplementations]):
2291         (-[WebView _cacheFrameLoadDelegateImplementations]):
2292         (-[WebView _policyDelegateForwarder]):
2293         (-[WebView _UIDelegateForwarder]):
2294         (-[WebView _editingDelegateForwarder]):
2295         (-[WebView _updateActiveState]):
2296         (-[_WebSafeForwarder forwardInvocation:]):
2297         (+[WebView initialize]):
2298         (-[WebView _pluginForMIMEType:]):
2299         (-[WebView _pluginForExtension:]):
2300         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2301         (+[WebView canShowMIMETypeAsHTML:]):
2302         (-[WebView _initWithArguments:]):
2303         (-[WebView initWithFrame:frameName:groupName:]):
2304         (-[WebView dealloc]):
2305         (-[WebView close]):
2306         (-[WebView viewDidMoveToWindow]):
2307         (-[WebView setUIDelegate:]):
2308         (-[WebView setResourceLoadDelegate:]):
2309         (-[WebView setPolicyDelegate:]):
2310         (-[WebView setFrameLoadDelegate:]):
2311         (-[WebView goBack]):
2312         (-[WebView goForward]):
2313         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2314         (-[WebView setHostWindow:]):
2315         (-[WebView becomeFirstResponder]):
2316         (+[WebView _cacheModelChangedNotification:]):
2317         (-[WebView _frameViewAtWindowPoint:]):
2318         (+[WebView _preflightSpellCheckerNow:]):
2319         (+[WebView _preflightSpellChecker]):
2320         (-[WebView canGoBack]):
2321         (-[WebView canGoForward]):
2322         (-[WebView stopLoading:]):
2323         (-[WebView reload:]):
2324         (-[WebView setMainFrameDocumentReady:]):
2325         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2326         (-[WebView setContinuousSpellCheckingEnabled:]):
2327         (-[WebView undoManager]):
2328         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2329         (-[WebView isAutomaticLinkDetectionEnabled]):
2330         (-[WebView isAutomaticDashSubstitutionEnabled]):
2331         (-[WebView isAutomaticTextReplacementEnabled]):
2332         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2333         (+[WebView _setCacheModel:]):
2334         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2335         (-[WebView _keyboardUIMode]):
2336         (LayerFlushController::flushLayers):
2337         (-[WebView _scheduleCompositingLayerFlush]):
2338         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2339         (-[WebView fullScreenPlaceholderView]):
2340         (WebInstallMemoryPressureHandler):
2341         * WebView/WebViewData.h:
2342         * WebView/WebViewData.mm:
2343         (+[WebViewPrivate initialize]):
2344         (-[WebViewPrivate init]):
2345         (-[WebViewPrivate dealloc]):
2346         * WebView/WebViewInternal.h:
2347
2348 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2349
2350         Clean up FrameLoader two-state enums
2351         https://bugs.webkit.org/show_bug.cgi?id=190731
2352
2353         Reviewed by Chris Dumez.
2354
2355         * WebCoreSupport/WebFrameLoaderClient.h:
2356         * WebCoreSupport/WebFrameLoaderClient.mm:
2357         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2358
2359 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2360
2361         Unreviewed, rolling out r237137.
2362
2363         SPI is actually used
2364
2365         Reverted changeset:
2366
2367         "Remove unused WebFrame._loadType"
2368         https://bugs.webkit.org/show_bug.cgi?id=190583
2369         https://trac.webkit.org/changeset/237137
2370
2371 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2372
2373         Enable the datalist element by default on iOS and macOS
2374         https://bugs.webkit.org/show_bug.cgi?id=190594
2375         <rdar://problem/45281159>
2376
2377         Reviewed by Ryosuke Niwa and Tim Horton.
2378
2379         * Configurations/FeatureDefines.xcconfig:
2380
2381 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2382
2383         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2384         https://bugs.webkit.org/show_bug.cgi?id=190675
2385
2386         Reviewed by Chris Dumez.
2387
2388         * History/BackForwardList.h:
2389         * History/BackForwardList.mm:
2390         (BackForwardList::backItem):
2391         (BackForwardList::currentItem):
2392         (BackForwardList::forwardItem):
2393         (BackForwardList::backListCount const):
2394         (BackForwardList::forwardListCount const):
2395         (BackForwardList::itemAtIndex):
2396         * History/WebBackForwardList.mm:
2397         (-[WebBackForwardList backItem]):
2398         (-[WebBackForwardList currentItem]):
2399         (-[WebBackForwardList forwardItem]):
2400         (-[WebBackForwardList itemAtIndex:]):
2401
2402 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2403
2404         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2405         https://bugs.webkit.org/show_bug.cgi?id=190526
2406         rdar://problem/45230140
2407
2408         Reviewed by Dean Jackson.
2409
2410         * WebCoreSupport/WebEditorClient.mm:
2411         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2412
2413 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2414
2415         Implement feature flag and bindings for CSS Painting API
2416         https://bugs.webkit.org/show_bug.cgi?id=190237
2417
2418         Reviewed by Ryosuke Niwa.
2419
2420         * Configurations/FeatureDefines.xcconfig:
2421
2422 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2423
2424         Replace HistoryItem* with HistoryItem& where possible
2425         https://bugs.webkit.org/show_bug.cgi?id=190617
2426
2427         Reviewed by Chris Dumez.
2428
2429         * History/BackForwardList.h:
2430         * History/BackForwardList.mm:
2431         (BackForwardList::goToItem):
2432         * History/WebBackForwardList.mm:
2433         (-[WebBackForwardList goToItem:]):
2434         * History/WebHistoryItem.mm:
2435         (WKNotifyHistoryItemChanged):
2436         * History/WebHistoryItemInternal.h:
2437
2438 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2439
2440         Remove unused WebHistoryItem._transientPropertyForKey
2441         https://bugs.webkit.org/show_bug.cgi?id=190606
2442
2443         Reviewed by Chris Dumez.
2444
2445         * History/WebHistoryItem.mm:
2446         * History/WebHistoryItemPrivate.h:
2447
2448 2018-10-15  Justin Fan  <justin_fan@apple.com>
2449
2450         Add WebGPU 2018 feature flag and experimental feature flag
2451         https://bugs.webkit.org/show_bug.cgi?id=190509
2452
2453         Reviewed by Dean Jackson.
2454
2455         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2456         for the 2018 WebGPU prototype.
2457
2458         * Configurations/FeatureDefines.xcconfig:
2459         * WebView/WebPreferenceKeysPrivate.h:
2460         * WebView/WebPreferences.mm:
2461         (+[WebPreferences initialize]):
2462         (-[WebPreferences webGPUEnabled]):
2463         (-[WebPreferences setWebGPUEnabled:]):
2464         * WebView/WebPreferencesPrivate.h:
2465         * WebView/WebView.mm:
2466         (-[WebView _preferencesChanged:]):
2467
2468 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2469
2470         Fix iOS build after r237157
2471
2472         * WebView/WebView.mm:
2473         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2474
2475 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2476
2477         Modernize BackForwardClient.h
2478         https://bugs.webkit.org/show_bug.cgi?id=190610
2479
2480         Reviewed by Chris Dumez.
2481
2482         * History/BackForwardList.h:
2483         * History/BackForwardList.mm:
2484         (BackForwardList::backListCount const):
2485         (BackForwardList::forwardListCount const):
2486         (BackForwardList::backListCount): Deleted.
2487         (BackForwardList::forwardListCount): Deleted.
2488         * History/WebBackForwardList.mm:
2489         (-[WebBackForwardList init]):
2490         * WebCoreSupport/WebFrameLoaderClient.mm:
2491         (WebFrameLoaderClient::canCachePage const):
2492         * WebView/WebFrameView.mm:
2493         (-[WebFrameView keyDown:keyDown:]):
2494         * WebView/WebView.mm:
2495         (-[WebView _commonInitializationWithFrameName:groupName:]):
2496         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2497         (-[WebView _loadBackForwardListFromOtherView:]):
2498         (-[WebView initWithCoder:]):
2499         (-[WebView encodeWithCoder:]):
2500         (-[WebView backForwardList]):
2501         (-[WebView setMaintainsBackForwardList:]):
2502
2503 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2504
2505         Add support for prefers-color-scheme media query
2506         https://bugs.webkit.org/show_bug.cgi?id=190499
2507         rdar://problem/45212025
2508
2509         Reviewed by Dean Jackson.
2510
2511         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2512
2513 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2514
2515         Remove unused WebView._globalHistoryItem
2516         https://bugs.webkit.org/show_bug.cgi?id=190601
2517
2518         Reviewed by Chris Dumez.
2519
2520         * WebCoreSupport/WebFrameLoaderClient.h:
2521         * WebCoreSupport/WebFrameLoaderClient.mm:
2522         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2523         * WebView/WebView.mm:
2524         (-[WebView _globalHistoryItem]): Deleted.
2525         (-[WebView _setGlobalHistoryItem:]): Deleted.
2526         * WebView/WebViewData.h:
2527         * WebView/WebViewInternal.h:
2528         * WebView/WebViewPrivate.h:
2529
2530 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2531
2532         Remove unused parameters from FrameLoaderClient::createFrame
2533         https://bugs.webkit.org/show_bug.cgi?id=190587
2534
2535         Reviewed by Chris Dumez.
2536
2537         * WebCoreSupport/WebFrameLoaderClient.h:
2538         * WebCoreSupport/WebFrameLoaderClient.mm:
2539         (WebFrameLoaderClient::createFrame):
2540
2541 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2542
2543         Remove unused WebFrame._loadType
2544         https://bugs.webkit.org/show_bug.cgi?id=190583
2545
2546         Reviewed by Chris Dumez.
2547
2548         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2549
2550         * WebView/WebFrame.mm:
2551         (toWebFrameLoadType): Deleted.
2552         (-[WebFrame _loadType]): Deleted.
2553         * WebView/WebFramePrivate.h:
2554
2555 2018-10-15  Chris Dumez  <cdumez@apple.com>
2556
2557         Restrict browsing context lookup by name to frames that are related to one another
2558         https://bugs.webkit.org/show_bug.cgi?id=190475
2559
2560         Reviewed by Alex Christensen.
2561
2562         * WebView/WebFrame.mm:
2563         (-[WebFrame findFrameNamed:]):
2564
2565 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2566
2567         Remove InjectedBundle processing of back/forward lists
2568         https://bugs.webkit.org/show_bug.cgi?id=190459
2569
2570         Reviewed by Chris Dumez.
2571
2572         * WebCoreSupport/WebFrameLoaderClient.h:
2573         * WebCoreSupport/WebFrameLoaderClient.mm:
2574         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2575
2576 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2577
2578         [JSC] Remove Option::useAsyncIterator
2579         https://bugs.webkit.org/show_bug.cgi?id=190567
2580
2581         Reviewed by Saam Barati.
2582
2583         * Configurations/FeatureDefines.xcconfig:
2584
2585 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2586
2587         Allow encoding of small enum classes
2588         https://bugs.webkit.org/show_bug.cgi?id=190531
2589
2590         Reviewed by Tim Horton.
2591
2592         * WebCoreSupport/WebFrameLoaderClient.mm:
2593         (-[WebFramePolicyListener dealloc]):
2594
2595 2018-10-11  Keith Rollin  <krollin@apple.com>
2596
2597         CURRENT_ARCH should not be used in Run Script phase.
2598         https://bugs.webkit.org/show_bug.cgi?id=190407
2599         <rdar://problem/45133556>
2600
2601         Reviewed by Alexey Proskuryakov.
2602
2603         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2604         CURRENT_ARCH is not well-defined during this phase (and may even have
2605         the value "undefined") since this phase is run just once per build
2606         rather than once per supported architecture. Migrate away from
2607         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2608         performing an operation for each value, or by picking the first entry
2609         in ARCHS and using that as a representative value.
2610
2611         * Configurations/WebKitLegacy.xcconfig: When generating
2612         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2613         macosx platforms.
2614
2615         * MigrateHeaders.make:
2616         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2617         generate one for each architecture in ARCHS.
2618
2619 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2620
2621         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2622         https://bugs.webkit.org/show_bug.cgi?id=190429
2623
2624         Reviewed by Saam Barati.
2625
2626         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2627
2628         * WebView/WebPDFRepresentation.mm:
2629         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2630
2631 2018-10-08  Justin Fan  <justin_fan@apple.com>
2632
2633         WebGPU: Rename old WebGPU prototype to WebMetal
2634         https://bugs.webkit.org/show_bug.cgi?id=190325
2635         <rdar://problem/44990443>
2636
2637         Reviewed by Dean Jackson.
2638
2639         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2640
2641         * Configurations/FeatureDefines.xcconfig:
2642         * WebView/WebPreferenceKeysPrivate.h:
2643         * WebView/WebPreferences.mm:
2644         (+[WebPreferences initialize]):
2645         (-[WebPreferences webMetalEnabled]):
2646         (-[WebPreferences setWebMetalEnabled:]):
2647         (-[WebPreferences webGPUEnabled]): Deleted.
2648         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2649         * WebView/WebPreferencesPrivate.h:
2650         * WebView/WebView.mm:
2651         (-[WebView _preferencesChanged:]):
2652
2653 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2654
2655         Make <input type=color> a runtime enabled (on-by-default) feature
2656         https://bugs.webkit.org/show_bug.cgi?id=189162
2657
2658         Reviewed by Wenson Hsieh and Tim Horton.
2659
2660         * Configurations/FeatureDefines.xcconfig:
2661
2662 2018-10-07  Dan Bernstein  <mitz@apple.com>
2663
2664         Fixed building with the latest macOS SDK
2665
2666         * Plugins/WebNetscapePluginPackage.mm:
2667         (-[WebNetscapePluginPackage openResourceFile]):
2668         (-[WebNetscapePluginPackage closeResourceFile:]):
2669
2670 2018-10-04  Dan Bernstein  <mitz@apple.com>
2671
2672         More Carbon build-fixing.
2673
2674         * Carbon/CarbonWindowAdapter.mm:
2675         (-[CarbonWindowAdapter _destroyRealWindow:]):
2676         (-[CarbonWindowAdapter _growBoxRect]):
2677
2678 2018-10-04  Dan Bernstein  <mitz@apple.com>
2679
2680         Retried to fix 32-bit macOS builds after r236846.
2681
2682         * WebView/WebHTMLView.mm:
2683         (-[WebHTMLView setMarkedText:selectedRange:]):
2684
2685 2018-10-04  Dan Bernstein  <mitz@apple.com>
2686
2687         Retried to fix 32-bit macOS builds after r236846.
2688
2689         * Carbon/HIWebView.mm:
2690         (ActiveStateChanged):
2691
2692 2018-10-04  Dan Bernstein  <mitz@apple.com>
2693
2694         Tried to fix 32-bit macOS builds after r236846.
2695
2696         * Carbon/HIWebView.mm:
2697         (_NSSelectorForHICommand):
2698
2699 2018-10-04  Dan Bernstein  <mitz@apple.com>
2700
2701         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2702         https://bugs.webkit.org/show_bug.cgi?id=190250
2703
2704         Reviewed by Andy Estes.
2705
2706         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2707           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2708           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2709           an earlier line set it to YES.
2710
2711         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2712         changes below.
2713
2714         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2715           provides some missing method declarations.
2716
2717         * Misc/WebDownload.mm:
2718         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2719           a deprecated method.
2720
2721         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2722
2723         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2724           other code in the file uses a method from it.
2725
2726         * Plugins/WebBaseNetscapePluginView.mm:
2727         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2728           a deprecated method.
2729
2730         * Plugins/WebPluginController.mm:
2731         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2732           around use of a selector that may be present in some WebKit client.
2733
2734         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2735           method declarations.
2736
2737         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2738           from here.
2739
2740         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2741           missing method declarations.
2742
2743         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2744           from here.
2745
2746         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2747           call from here.
2748         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2749           an obsolete delegate method for binary compatibility.
2750         (pluginView): Ditto.
2751
2752         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2753           call from here.
2754
2755         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2756           WebDeviceOrientationProviderMock protocol.
2757
2758         * WebView/WebDeviceOrientationProviderMock.mm:
2759         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2760           main @implementation.
2761
2762         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2763           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2764
2765         * WebView/WebDynamicScrollBarsView.mm:
2766         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2767           of a deprecated method.
2768
2769         * WebView/WebHTMLView.mm:
2770         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2771           selector warning around action methods that are not declared anywhere in WebKit.
2772
2773         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2774           about implementing this deprecated method.
2775         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2776         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2777         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2778         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2779         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2780         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2781         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2782         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2783         (-[WebHTMLView doCommandBySelector:]): Ditto.
2784         (-[WebHTMLView insertText:]): Ditto.
2785
2786         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2787
2788         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2789
2790         * WebView/WebPDFView.h: Removed previewView ivar.
2791
2792         * WebView/WebPDFView.mm:
2793           Removed declaration of FileInternal category and merged its implementation with the main
2794           implementation.
2795         (-[WebPDFView dealloc]): Removed previewView ivar.
2796         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2797           exist in macOS versions we support.
2798         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2799         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2800           action methods internal to PDFKit.
2801         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2802         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2803
2804         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2805           call on macOS, even though in r86988 we started calling different methods on iOS.
2806
2807         * WebView/WebView.mm:
2808         - Imported headers that declare delegate methods that we call.
2809         - Removed declaration of WebFileInternal category and merged its implementation with the
2810           main implementation.
2811         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2812           category, which made them impossible to call from the main implementation. Moved those
2813           into the main implementation. One of those had to be declared in a class extension,
2814           because it is called from a method implemented in the WebPrivate category, and that
2815           category’s implementation appears first in the file.
2816
2817         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2818           around use of obsolete delegate method for binary compatibility.
2819
2820         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2821
2822 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2823
2824         Runtime flag and IDL for MediaRecorder
2825         https://bugs.webkit.org/show_bug.cgi?id=190018
2826
2827         Reviewed by Youenn Fablet and Chris Dumez.
2828
2829         * WebView/WebPreferenceKeysPrivate.h:
2830         * WebView/WebPreferences.mm:
2831         (+[WebPreferences initialize]):
2832         (-[WebPreferences mediaRecorderEnabled]):
2833         (-[WebPreferences setMediaRecorderEnabled:]):
2834         * WebView/WebPreferencesPrivate.h:
2835         * WebView/WebView.mm:
2836         (-[WebView _preferencesChanged:]):
2837
2838 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2839
2840         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2841         https://bugs.webkit.org/show_bug.cgi?id=190238
2842
2843         Reviewed by Antti Koivisto.
2844
2845         Enabled the feature by default.
2846
2847         * WebView/WebPreferences.mm:
2848         (+[WebPreferences initialize]):
2849
2850 2018-10-01  Dean Jackson  <dino@apple.com>
2851
2852         [macOS] Switching to discrete GPU should be done in the UI process
2853         https://bugs.webkit.org/show_bug.cgi?id=189361
2854         <rdar://problem/43949622>
2855
2856         Reviewed by Simon Fraser.
2857
2858         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2859         not support swapping to the discrete GPU in this configuration.
2860
2861         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2862         (WebKit::WebSwitchingGPUClient::singleton):
2863         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2864         * WebView/WebView.mm:
2865         (-[WebView _commonInitializationWithFrameName:groupName:]):
2866
2867 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2868
2869         Remove ParsedURLString
2870         https://bugs.webkit.org/show_bug.cgi?id=190154
2871
2872         Reviewed by Chris Dumez.
2873
2874         * WebView/WebScriptDebugger.mm:
2875         (toNSURL):
2876
2877 2018-10-01  Dean Jackson  <dino@apple.com>
2878
2879         Remove CSS Animation Triggers
2880         https://bugs.webkit.org/show_bug.cgi?id=190175
2881         <rdar://problem/44925626>
2882
2883         Reviewed by Simon Fraser.
2884
2885         * Configurations/FeatureDefines.xcconfig:
2886
2887 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2888
2889         Unreviewed, rolling out r236624 and r236671.
2890         https://bugs.webkit.org/show_bug.cgi?id=190207
2891
2892         The change in r236624 introduced crashes on the bots
2893         (Requested by ryanhaddad on #webkit).
2894
2895         Reverted changesets:
2896
2897         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2898         https://bugs.webkit.org/show_bug.cgi?id=188747
2899         https://trac.webkit.org/changeset/236624
2900
2901         "Unify implementation in VideoFullscreenInterfaceAVKit"
2902         https://bugs.webkit.org/show_bug.cgi?id=190091
2903         https://trac.webkit.org/changeset/236671
2904
2905 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2906
2907         URL should not use TextEncoding internally
2908         https://bugs.webkit.org/show_bug.cgi?id=190111
2909
2910         Reviewed by Andy Estes.
2911
2912         * Misc/WebNSURLExtras.mm:
2913
2914 2018-09-28  Jer Noble  <jer.noble@apple.com>
2915
2916         Refactoring: eliminate raw pointer usage in Fullscreen code
2917         https://bugs.webkit.org/show_bug.cgi?id=188747
2918         <rdar://problem/43541164>
2919
2920         Reviewed by Alex Christensen.
2921
2922         PlaybackSessionInterface no longer has an invalidate() method.
2923
2924         * WebView/WebView.mm:
2925         (-[WebView _clearPlaybackControlsManager]):
2926
2927 2018-09-28  Chris Dumez  <cdumez@apple.com>
2928
2929         Drop support for cross-origin-window-policy header
2930         https://bugs.webkit.org/show_bug.cgi?id=190081
2931
2932         Reviewed by Ryosuke Niwa.
2933
2934         * WebView/WebPreferenceKeysPrivate.h:
2935         * WebView/WebPreferences.mm:
2936         (+[WebPreferences initialize]):
2937         * WebView/WebPreferencesPrivate.h:
2938         * WebView/WebView.mm:
2939         (-[WebView _preferencesChanged:]):
2940
2941 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2942
2943         Rename createMarkup to serializePreservingVisualAppearance
2944         https://bugs.webkit.org/show_bug.cgi?id=190086
2945
2946         Reviewed by Wenson Hsieh.
2947
2948         * DOM/WebDOMOperations.mm:
2949         (-[DOMRange markupString]):
2950
2951 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2952
2953         Unreviewed, rolling out r236605.
2954         https://bugs.webkit.org/show_bug.cgi?id=190087
2955
2956         caused three API test timeouts (Requested by jernoble on
2957         #webkit).
2958
2959         Reverted changeset:
2960
2961         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2962         https://bugs.webkit.org/show_bug.cgi?id=188747
2963         https://trac.webkit.org/changeset/236605
2964
2965 2018-09-28  Jer Noble  <jer.noble@apple.com>
2966
2967         Refactoring: eliminate raw pointer usage in Fullscreen code
2968         https://bugs.webkit.org/show_bug.cgi?id=188747
2969         <rdar://problem/43541164>
2970
2971         Reviewed by Alex Christensen.
2972
2973         PlaybackSessionInterface no longer has an invalidate() method.
2974
2975         * WebView/WebView.mm:
2976         (-[WebView _clearPlaybackControlsManager]):
2977
2978 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2979
2980         Use enum class in createMarkup arguments
2981         https://bugs.webkit.org/show_bug.cgi?id=190028
2982
2983         Reviewed by Wenson Hsieh.
2984
2985         * DOM/WebDOMOperations.mm:
2986         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2987         (-[DOMRange markupString]): Ditto.
2988
2989 2018-09-27  Antoine Quint  <graouts@apple.com>
2990
2991         [Web Animations] Turn Web Animations with CSS integration on
2992         https://bugs.webkit.org/show_bug.cgi?id=184819
2993         <rdar://problem/39597337>
2994
2995         Reviewed by Dean Jackson.
2996
2997         * WebView/WebPreferences.mm:
2998         (+[WebPreferences initialize]):
2999
3000 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3001
3002         Selection should work across shadow boundary when initiated by a mouse drag
3003         https://bugs.webkit.org/show_bug.cgi?id=151380
3004         <rdar://problem/24363872>
3005
3006         Reviewed by Wenson Hsieh.
3007
3008         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3009
3010         * WebView/WebPreferenceKeysPrivate.h:
3011         * WebView/WebPreferences.mm:
3012         (+[WebPreferences initialize]):
3013         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3014         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3015         * WebView/WebPreferencesPrivate.h:
3016         * WebView/WebView.mm:
3017         (-[WebView _preferencesChanged:]):
3018
3019 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3020
3021         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3022         https://bugs.webkit.org/show_bug.cgi?id=189918
3023         Work towards <rdar://problem/44648705>
3024
3025         Reviewed by Tim Horton.
3026
3027         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3028
3029         * WebView/WebHTMLView.mm:
3030         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3031         (-[WebHTMLView _updateFontPanel]):
3032         * WebView/WebView.mm:
3033         (-[WebView typingAttributes]):
3034
3035 2018-09-17  Darin Adler  <darin@apple.com>
3036
3037         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3038         https://bugs.webkit.org/show_bug.cgi?id=189652
3039
3040         Reviewed by Saam Barati.
3041
3042         * WebView/WebPDFRepresentation.mm:
3043         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3044
3045 2018-09-14  Jer Noble  <jer.noble@apple.com>
3046
3047         Turn SourceBufferChangeTypeEnabled on by default
3048         https://bugs.webkit.org/show_bug.cgi?id=189527
3049
3050         Reviewed by Eric Carlson.
3051
3052         * WebView/WebPreferences.mm:
3053         (+[WebPreferences initialize]):
3054
3055 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3056
3057         Fix an internal build after r235935
3058         https://bugs.webkit.org/show_bug.cgi?id=188996
3059
3060         * Carbon/HIWebView.mm:
3061         (Draw):
3062         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3063
3064 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3065
3066         Add IGNORE_WARNING_.* macros
3067         https://bugs.webkit.org/show_bug.cgi?id=188996
3068
3069         Reviewed by Michael Catanzaro.
3070
3071         * Carbon/CarbonUtils.m:
3072         (PoolCleaner):
3073         * Carbon/CarbonWindowAdapter.mm:
3074         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3075         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3076         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3077         (-[CarbonWindowAdapter _termWindowIfOwner]):
3078         (-[CarbonWindowAdapter _windowMovedToRect:]):
3079         (-[CarbonWindowAdapter setContentView:]):
3080         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3081         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3082         * Carbon/CarbonWindowFrame.m:
3083         (-[CarbonWindowFrame title]):
3084         * Carbon/HIViewAdapter.m:
3085         (+[HIViewAdapter getHIViewForNSView:]):
3086         * Carbon/HIWebView.mm:
3087         (overrideCGContext):
3088         (restoreCGContext):
3089         (Draw):
3090         * DOM/DOM.mm:
3091         * History/WebHistory.mm:
3092         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3093         * History/WebHistoryItem.mm:
3094         (-[WebHistoryItem icon]):
3095         * Misc/WebKitNSStringExtras.mm:
3096         (-[NSString _web_drawAtPoint:font:textColor:]):
3097         * Misc/WebNSImageExtras.m:
3098         (-[NSImage _web_scaleToMaxSize:]):
3099         (-[NSImage _web_dissolveToFraction:]):
3100         * Misc/WebNSPasteboardExtras.mm:
3101         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3102         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3103         * Panels/WebAuthenticationPanel.m:
3104         (-[WebAuthenticationPanel loadNib]):
3105         * Plugins/Hosted/NetscapePluginHostManager.mm:
3106         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3107         (WebKit::NetscapePluginHostManager::didCreateWindow):
3108         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3109         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3110         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3111         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3112         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3113         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3114         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3115         (-[WebHostedNetscapePluginView drawRect:]):
3116         * Plugins/Hosted/WebTextInputWindowController.m:
3117         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3118         * Plugins/WebBaseNetscapePluginView.mm:
3119         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3120         * Plugins/WebNetscapePluginPackage.mm:
3121         (-[WebNetscapePluginPackage _tryLoad]):
3122         * Plugins/WebNetscapePluginView.mm:
3123         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3124         (-[WebNetscapePluginView sendDrawRectEvent:]):
3125         (-[WebNetscapePluginView drawRect:]):
3126         * Plugins/WebPluginController.mm:
3127         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3128         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3129         * WebCoreSupport/PopupMenuMac.mm:
3130         (PopupMenuMac::populate):
3131         * WebCoreSupport/WebAlternativeTextClient.h:
3132         * WebCoreSupport/WebDragClient.mm:
3133         (WebDragClient::startDrag):
3134         * WebCoreSupport/WebFrameLoaderClient.mm:
3135         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3136         (webGetNSImage):
3137         * WebInspector/WebNodeHighlight.mm:
3138         * WebInspector/WebNodeHighlightView.mm:
3139         (-[WebNodeHighlightView drawRect:]):
3140         * WebView/WebClipView.mm:
3141         (-[WebClipView initWithFrame:]):
3142         * WebView/WebFrame.mm:
3143         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3144         (-[WebFrame _drawRect:contentsOnly:]):
3145         (-[WebFrame accessibilityRoot]):
3146         * WebView/WebFullScreenController.mm:
3147         (-[WebFullScreenController enterFullScreen:]):
3148         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3149         (-[WebFullScreenController exitFullScreen]):
3150         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3151         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3152         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3153         * WebView/WebHTMLView.mm:
3154         (-[NSWindow _web_borderView]):
3155         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3156         (-[WebHTMLView _setAsideSubviews]):
3157         (-[WebHTMLView _autoscroll]):
3158         (-[WebHTMLView drawRect:]):
3159         (-[WebHTMLView mouseDown:]):
3160         (-[WebHTMLView mouseDragged:]):
3161         (-[WebHTMLView mouseUp:]):
3162         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3163         (-[WebHTMLView knowsPageRange:]):
3164         (-[WebHTMLView accessibilityHitTest:]):
3165         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3166         (-[WebHTMLView _colorAsString:]):
3167         (-[WebHTMLView copyFont:]):
3168         (-[WebHTMLView _executeSavedKeypressCommands]):
3169         (-[WebHTMLView attachRootLayer:]):
3170         (-[WebHTMLView textStorage]):
3171         (-[WebHTMLView _updateSelectionForInputManager]):
3172         * WebView/WebPDFView.mm:
3173         (_applicationInfoForMIMEType):
3174         (-[WebPDFView centerSelectionInVisibleArea:]):
3175         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3176         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3177         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3178         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3179         * WebView/WebTextCompletionController.mm:
3180         (-[WebTextCompletionController _buildUI]):
3181         (-[WebTextCompletionController _placePopupWindow:]):
3182         * WebView/WebVideoFullscreenController.mm:
3183         * WebView/WebVideoFullscreenHUDWindowController.mm:
3184         (createMediaUIBackgroundView):
3185         * WebView/WebView.mm:
3186         (-[WebTextListTouchBarViewController initWithWebView:]):
3187         (-[WebView _dispatchTileDidDraw:]):
3188         (-[WebView encodeWithCoder:]):
3189         (-[WebView mainFrameIcon]):
3190         (LayerFlushController::flushLayers):
3191         * WebView/WebWindowAnimation.mm:
3192         (setScaledFrameForWindow):
3193
3194 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3195
3196         Remove unused needsDestruction class variables from HashTraits
3197         https://bugs.webkit.org/show_bug.cgi?id=189490
3198
3199         Reviewed by Daniel Bates.
3200
3201         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3202
3203 2018-09-07  Frederic Wang  <fwang@igalia.com>
3204
3205         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3206         https://bugs.webkit.org/show_bug.cgi?id=182230
3207
3208         Reviewed by Simon Fraser.
3209
3210         * DOM/DOMDocument.mm:
3211         (-[DOMDocument scrollingElement]): Use the new name.
3212
3213 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         Refactor WebCore::EditAction to be an 8-bit enum class
3216         https://bugs.webkit.org/show_bug.cgi?id=189383
3217
3218         Reviewed by Dan Bernstein.
3219
3220         * WebCoreSupport/WebEditorClient.mm:
3221         (undoNameForEditAction):
3222         * WebView/WebHTMLView.mm:
3223         (-[WebHTMLView pasteFont:]):
3224         (-[WebHTMLView changeFont:]):
3225         (-[WebHTMLView changeAttributes:]):
3226         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3227         (-[WebHTMLView changeColor:]):
3228         * WebView/WebView.mm:
3229         (-[WebView setTypingStyle:]):
3230
3231 2018-09-06  Frederic Wang  <fwang@igalia.com>
3232
3233         Group options of scrollRectToVisible into a struct
3234         https://bugs.webkit.org/show_bug.cgi?id=189352
3235
3236         Reviewed by Simon Fraser.
3237
3238         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3239         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3240         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3241
3242 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3243
3244         [macOS] Cannot change font size at selection until font panel is shown
3245         https://bugs.webkit.org/show_bug.cgi?id=189295
3246         <rdar://problem/35593389>
3247
3248         Reviewed by Ryosuke Niwa.
3249
3250         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3251         WebCore ChangeLog for more details.
3252
3253         * WebView/WebHTMLView.mm:
3254         (-[WebHTMLView changeFont:]):
3255         (-[WebHTMLView changeAttributes:]):
3256         (-[WebHTMLView _originalFontA]): Deleted.
3257         (-[WebHTMLView _originalFontB]): Deleted.
3258         (fontNameForDescription): Deleted.
3259         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3260         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3261         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3262
3263 2018-09-05  Jer Noble  <jer.noble@apple.com>
3264
3265         Add MediaCapabilities as an Experimental Feature
3266         https://bugs.webkit.org/show_bug.cgi?id=189209
3267
3268         Reviewed by Eric Carlson.
3269
3270         RuntimeEnabledFeature -> Setting.
3271
3272         * WebView/WebView.mm:
3273         (-[WebView _preferencesChanged:]):
3274
3275 2018-09-04  Frederic Wang  <fwang@igalia.com>
3276
3277         Add basic support for ScrollIntoViewOptions
3278         https://bugs.webkit.org/show_bug.cgi?id=189258
3279
3280         Reviewed by Simon Fraser.
3281
3282         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3283         header so that this file can build despite the new scrollIntoView function.
3284
3285 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3286
3287         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3288         https://bugs.webkit.org/show_bug.cgi?id=188890
3289         <rdar://problem/43648605>
3290
3291         Reviewed by Tim Horton.
3292
3293         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3294         more detail.
3295
3296         * WebCoreSupport/WebPlatformStrategies.h:
3297         * WebCoreSupport/WebPlatformStrategies.mm:
3298         (WebPlatformStrategies::allStringsForType):
3299
3300 2018-09-01  Darin Adler  <darin@apple.com>
3301
3302         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3303         https://bugs.webkit.org/show_bug.cgi?id=189072
3304         Reviewed by Dan Bernstein.
3305
3306         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3307         and declarations for NSURLDownload init methods.
3308
3309         * Misc/WebDownloadInternal.h: Removed.
3310
3311         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3312         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3313         "-Wdeprecated-declarations" because the method used here is deprecated.
3314
3315         * WebView/WebView.mm:
3316         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3317         used here is deprecated.
3318
3319 2018-08-31  Chris Dumez  <cdumez@apple.com>
3320
3321         Assertion hit in ~CompletionHandler() from ~WebFrame()
3322         https://bugs.webkit.org/show_bug.cgi?id=189199
3323         <rdar://problem/42657233>
3324
3325         Reviewed by Youenn Fablet.
3326
3327         * WebCoreSupport/WebFrameLoaderClient.h:
3328         * WebCoreSupport/WebFrameLoaderClient.mm:
3329         (WebFrameLoaderClient::dispatchWillSubmitForm):
3330
3331 2018-08-31  Antti Koivisto  <antti@apple.com>
3332
3333         Replace OptionSet |= and -= operators with add() and remove() functions
3334         https://bugs.webkit.org/show_bug.cgi?id=189169
3335
3336         Reviewed by Anders Carlsson.
3337
3338         * WebView/WebFrame.mm:
3339         (-[WebFrame _drawRect:contentsOnly:]):
3340         * WebView/WebView.mm:
3341         (coreOptions):
3342
3343 2018-08-31  Frederic Wang  <fwang@igalia.com>
3344
3345         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3346         https://bugs.webkit.org/show_bug.cgi?id=182053
3347
3348         Reviewed by Simon Fraser.
3349
3350         Add developer flag to use standard behavior for scrolling* attributes.
3351
3352         * WebView/WebPreferenceKeysPrivate.h:
3353         * WebView/WebPreferences.mm:
3354         (+[WebPreferences initialize]):
3355         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3356         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3357         * WebView/WebPreferencesPrivate.h:
3358         * WebView/WebView.mm:
3359         (-[WebView _preferencesChanged:]):
3360
3361 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3362
3363         Implement the Web Share API
3364         https://bugs.webkit.org/show_bug.cgi?id=171100
3365         <rdar://problem/31751734>
3366
3367         Reviewed by Tim Horton.
3368
3369         * WebCoreSupport/WebChromeClient.h:
3370         * WebCoreSupport/WebChromeClient.mm:
3371         (WebChromeClient::showShareSheet):
3372         Empty declaration of showShareSheet.
3373
3374 2018-08-29  Youenn Fablet  <youenn@apple.com>
3375
3376         Remove WebRTC legacy API implementation
3377         https://bugs.webkit.org/show_bug.cgi?id=189040
3378
3379         Reviewed by Eric Carlson.
3380
3381         * WebView/WebPreferenceKeysPrivate.h:
3382         * WebView/WebPreferences.mm:
3383         (+[WebPreferences initialize]):
3384         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3385         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3386         * WebView/WebPreferencesPrivate.h:
3387         * WebView/WebView.mm:
3388         (-[WebView _preferencesChanged:]):
3389
3390 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3391
3392         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3393         https://bugs.webkit.org/show_bug.cgi?id=189054
3394
3395         Reviewed by Andy Estes.
3396
3397         Remove the pasteboard type argument from readURLFromPasteboard.
3398
3399         * WebCoreSupport/WebPlatformStrategies.h:
3400         * WebCoreSupport/WebPlatformStrategies.mm:
3401         (WebPlatformStrategies::readURLFromPasteboard):
3402
3403 2018-08-27  Keith Rollin  <krollin@apple.com>
3404
3405         Unreviewed build fix -- disable LTO for production builds
3406
3407         * Configurations/Base.xcconfig:
3408
3409 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3410
3411         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3412         https://bugs.webkit.org/show_bug.cgi?id=188931
3413
3414         Reviewed by Wenson Hsieh.
3415
3416         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3417
3418 2018-08-27  Keith Rollin  <krollin@apple.com>
3419
3420         Build system support for LTO
3421         https://bugs.webkit.org/show_bug.cgi?id=187785
3422         <rdar://problem/42353132>
3423
3424         Reviewed by Dan Bernstein.
3425
3426         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3427         LTO.
3428
3429         * Configurations/Base.xcconfig:
3430         * Configurations/DebugRelease.xcconfig:
3431
3432 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3433
3434         Pass in IsComposed flag to Event constructors
3435         https://bugs.webkit.org/show_bug.cgi?id=188720
3436         <rdar://problem/43580387>
3437
3438         Reviewed by Simon Fraser.
3439
3440         * WebView/WebPDFView.mm:
3441         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3442         whether it's simulated or not.
3443
3444 2018-08-23  Mark Lam  <mark.lam@apple.com>
3445
3446         Move vmEntryGlobalObject() to VM from CallFrame.
3447         https://bugs.webkit.org/show_bug.cgi?id=188900
3448         <rdar://problem/43655753>
3449
3450         Reviewed by Michael Saboff.
3451
3452         * WebView/WebScriptDebugger.mm:
3453         (WebScriptDebugger::sourceParsed):
3454
3455 2018-08-23  Andy Estes  <aestes@apple.com>
3456
3457         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3458         https://bugs.webkit.org/show_bug.cgi?id=188829
3459
3460         Reviewed by Tim Horton.
3461
3462         * Configurations/FeatureDefines.xcconfig:
3463
3464 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3465
3466         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3467         https://bugs.webkit.org/show_bug.cgi?id=188777
3468
3469         Reviewed by Simon Fraser.
3470
3471         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3472         being "true" before the code change.
3473
3474         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3475
3476         * WebView/WebPDFView.mm:
3477         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3478
3479 2018-08-21  Daniel Bates  <dabates@apple.com>
3480
3481         Replace TextCheckingTypeMask with OptionSet
3482         https://bugs.webkit.org/show_bug.cgi?id=188678
3483
3484         Reviewed by Antti Koivisto.
3485
3486         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3487         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3488         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3489         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3490
3491         * WebCoreSupport/WebEditorClient.h:
3492         * WebCoreSupport/WebEditorClient.mm:
3493         (WebEditorClient::checkTextOfParagraph):
3494         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3495         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3496         left as this is more readable and unncessary now that modern compilers like Clang have
3497         diagnostics to catch accidental assignments when equality was intended.
3498         (WebEditorClient::didCheckSucceed):
3499         * WebView/WebView.mm:
3500         (coreTextCheckingType):
3501         (textCheckingResultFromNSTextCheckingResult):
3502
3503 2018-08-21  Daniel Bates  <dabates@apple.com>
3504
3505         [iOS][WK1] Support toggling continuous spell checking from tests
3506         https://bugs.webkit.org/show_bug.cgi?id=188763
3507
3508         Reviewed by Simon Fraser.
3509
3510         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3511         spell checking from tests in iOS WebKit Legacy.
3512
3513         * WebCoreSupport/WebEditorClient.h:
3514         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3515         * WebCoreSupport/WebEditorClient.mm:
3516         * WebView/WebView.h:
3517         * WebView/WebView.mm:
3518         (-[WebView toggleContinuousSpellChecking:]):
3519         (-[WebView toggleSmartInsertDelete:]):
3520
3521 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3522
3523         Add some plumbing for safe browsing
3524         https://bugs.webkit.org/show_bug.cgi?id=188709
3525
3526         Reviewed by Tim Horton.
3527
3528         * WebCoreSupport/WebFrameLoaderClient.h:
3529         * WebCoreSupport/WebFrameLoaderClient.mm:
3530         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3531
3532 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3533
3534         Replace canBubble and cancelable booleans in Event by enum classes
3535         https://bugs.webkit.org/show_bug.cgi?id=188692
3536
3537         Reviewed by Alex Christensen.
3538
3539         * WebView/WebPDFView.mm:
3540         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3541         * WebView/WebView.mm:
3542         (-[WebView _dispatchUnloadEvent]):
3543
3544 2018-08-16  Jer Noble  <jer.noble@apple.com>
3545
3546         Add Experimental Feature support for SourceBuffer.changeType()
3547         https://bugs.webkit.org/show_bug.cgi?id=188626
3548         <rdar://problem/43356021>
3549
3550         Reviewed by Eric Carlson.
3551
3552         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3553
3554         * WebView/WebPreferenceKeysPrivate.h:
3555         * WebView/WebPreferences.mm:
3556         (+[WebPreferences initialize]):
3557         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3558         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3559         * WebView/WebPreferencesPrivate.h:
3560         * WebView/WebView.mm:
3561         (-[WebView _preferencesChanged:]):
3562
3563 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3564
3565         Support drag-and-drop for input[type=color]
3566         https://bugs.webkit.org/show_bug.cgi?id=188464
3567
3568         Reviewed by Wenson Hsieh.
3569
3570         * WebCoreSupport/WebPlatformStrategies.h:
3571         * WebCoreSupport/WebPlatformStrategies.mm:
3572         (WebPlatformStrategies::setColor):
3573
3574 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3575
3576         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3577         https://bugs.webkit.org/show_bug.cgi?id=188569
3578         <rdar://problem/34201095>
3579
3580         Reviewed by Megan Gardner.
3581
3582         * WebView/WebImmediateActionController.mm:
3583         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3584         Speculative fix; the crashes indicate font is null, but we just checked it,
3585         so it must be getting made null by convertFont:toSize:. Check again!
3586
3587 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3588
3589         Use a 1-byte enum class for TextDirection
3590         https://bugs.webkit.org/show_bug.cgi?id=188350
3591
3592         Reviewed by Simon Fraser.
3593
3594         * WebCoreSupport/PopupMenuMac.mm:
3595         (PopupMenuMac::populate):
3596         (PopupMenuMac::show):
3597         * WebCoreSupport/WebFrameLoaderClient.mm:
3598         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3599         * WebView/WebFrame.mm:
3600         (-[WebFrame _dispatchDidReceiveTitle:]):
3601
3602 2018-08-09  Ali Juma  <ajuma@chromium.org>
3603
3604         Import WPTs for IntersectionObserver
3605         https://bugs.webkit.org/show_bug.cgi?id=188416
3606
3607         Reviewed by Simon Fraser.
3608
3609         * WebView/WebPreferencesPrivate.h:
3610
3611 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3612
3613         Follow-up build fix for r234685
3614         https://bugs.webkit.org/show_bug.cgi?id=188245
3615
3616         Unreviewed build fix.
3617
3618         * WebCoreSupport/WebSecurityOriginPrivate.h:
3619
3620 2018-08-05  Darin Adler  <darin@apple.com>
3621
3622         [Cocoa] More tweaks and refactoring to prepare for ARC
3623         https://bugs.webkit.org/show_bug.cgi?id=188245
3624
3625         Reviewed by Dan Bernstein.
3626
3627         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3628
3629         * Carbon/CarbonWindowFrame.m:
3630         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3631
3632         * DOM/DOM.mm:
3633         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3634         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3635         garbage collection so this method isn't useful.
3636
3637         * DOM/DOMXPath.mm:
3638         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3639         Objective-C garbage collection so this method isn't useful.
3640
3641         * History/WebHistory.mm:
3642         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3643
3644         * Misc/WebElementDictionary.mm:
3645         (addLookupKey): Use a bridging cast.
3646         (cacheValueForKey): Ditto.
3647         (-[WebElementDictionary _fillCache]): Ditto.
3648         (-[WebElementDictionary objectForKey:]): Ditto.
3649
3650         * Misc/WebKitNSStringExtras.mm:
3651         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3652         (-[NSString _web_widthWithFont:]): Ditto.
3653         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3654
3655         * Misc/WebLocalizableStrings.mm:
3656         (WebLocalizedString): Use a bridging cast.
3657
3658         * Misc/WebNSDataExtras.mm:
3659         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3660         and use CFBridgingRelease instead of calling autorelease directly.
3661         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3662         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3663         on the amount of explicit release and autorelease.
3664
3665         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3666         * Misc/WebNSDictionaryExtras.m:
3667         (-[NSDictionary _webkit_intForKey:]): Deleted.
3668         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3669         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3670         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3671         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3672         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3673         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3674
3675         * Misc/WebStringTruncator.mm:
3676         (fontFromNSFont): Use a bridging cast.
3677
3678         * Plugins/Hosted/NetscapePluginHostManager.mm:
3679         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3680
3681         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3682         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3683         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3684         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3685         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3686         * Plugins/Hosted/ProxyInstance.mm:
3687         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3688         * Plugins/WebBasePluginPackage.mm:
3689         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3690         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3691         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3692         * Plugins/WebNetscapePluginPackage.mm:
3693         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3694
3695         * Plugins/WebNetscapePluginView.mm:
3696         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3697         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3698         (-[WebNetscapePluginView status:]): Use a bridging cast.
3699         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3700
3701         * Plugins/WebPluginController.mm:
3702         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3703
3704         * Plugins/WebPluginDatabase.mm:
3705         (checkCandidate): Use explicit __strong for out argument types.
3706
3707         * Plugins/npapi.mm:
3708         (pluginViewForInstance): Use a bridging cast.
3709
3710         * Storage/WebDatabaseManager.mm:
3711         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3712         explicit NSNumber and NSDictionary calls.
3713
3714         * WebCoreSupport/WebContextMenuClient.mm:
3715         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3716
3717         * WebCoreSupport/WebEditorClient.mm:
3718         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3719         (WebEditorClient::handleInputMethodKeydown): Ditto.
3720
3721         * WebCoreSupport/WebFrameNetworkingContext.mm:
3722         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3723
3724         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3725         as a struct rather than an Objective-C class, since that's how it's defined.
3726
3727         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3728
3729         * WebView/WebFullScreenController.mm:
3730         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3731         * WebView/WebHTMLView.mm:
3732         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3733         Ditto.
3734         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3735
3736         * WebView/WebImmediateActionController.mm:
3737         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3738         go down to the document and then back to the frame.
3739         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3740         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3741         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3742
3743         * WebView/WebJSPDFDoc.mm:
3744         (jsPDFDocInitialize): Removed some unneeded type casting.
3745         (jsPDFDocFinalize): Ditto.
3746         (jsPDFDocPrint): Use a bridging cast.
3747
3748         * WebView/WebPDFView.mm:
3749         (_applicationInfoForMIMEType): Use bridging casts.
3750
3751         * WebView/WebPreferences.mm:
3752         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3753         instead of methods from WebNSDictionaryExtras.
3754         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3755         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3756         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3757         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3758         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3759
3760         * WebView/WebView.mm:
3761         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3762         (-[WebView _addToAllWebViewsSet]): Ditto.
3763         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3764         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3765         so it can be called from WebViewData methods.
3766
3767         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3768         method, _windowVisibilityChanged:.
3769
3770         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3771         called from WebViewData methods.
3772
3773 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3774
3775         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3776         https://bugs.webkit.org/show_bug.cgi?id=188323
3777
3778         Reviewed by Simon Fraser.
3779
3780         * WebCoreSupport/WebContextMenuClient.mm:
3781         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3782         * WebView/WebFrame.mm:
3783         (-[WebFrame _paintBehaviorForDestinationContext:]):
3784         (-[WebFrame _drawRect:contentsOnly:]):
3785         * WebView/WebHTMLView.mm:
3786         (imageFromRect):
3787         (selectionImage):
3788
3789 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3790
3791         Add support for microtasks in workers
3792         https://bugs.webkit.org/show_bug.cgi?id=188246
3793
3794         Reviewed by Darin Adler.
3795
3796         Rename JSMainThreadExecState.h to JSExecState.h.
3797
3798         * DOM/DOMAttr.mm:
3799         * DOM/DOMBlob.mm:
3800         * DOM/DOMCDATASection.mm:
3801         * DOM/DOMCSSCharsetRule.mm:
3802         * DOM/DOMCSSFontFaceRule.mm:
3803         * DOM/DOMCSSImportRule.mm:
3804         * DOM/DOMCSSMediaRule.mm:
3805         * DOM/DOMCSSPageRule.mm:
3806         * DOM/DOMCSSPrimitiveValue.mm:
3807         * DOM/DOMCSSRule.mm:
3808         * DOM/DOMCSSRuleList.mm:
3809         * DOM/DOMCSSStyleDeclaration.mm:
3810         * DOM/DOMCSSStyleRule.mm:
3811         * DOM/DOMCSSStyleSheet.mm:
3812         * DOM/DOMCSSUnknownRule.mm:
3813         * DOM/DOMCSSValue.mm:
3814         * DOM/DOMCSSValueList.mm:
3815         * DOM/DOMCharacterData.mm:
3816         * DOM/DOMComment.mm:
3817         * DOM/DOMCounter.mm:
3818         * DOM/DOMDocument.mm:
3819         * DOM/DOMDocumentFragment.mm:
3820         * DOM/DOMDocumentType.mm:
3821         * DOM/DOMElement.mm:
3822         * DOM/DOMEvent.mm:
3823         * DOM/DOMFile.mm:
3824         * DOM/DOMFileList.mm:
3825         * DOM/DOMHTML.mm:
3826         * DOM/DOMHTMLAnchorElement.mm:
3827         * DOM/DOMHTMLAppletElement.mm:
3828         * DOM/DOMHTMLAreaElement.mm:
3829         * DOM/DOMHTMLBRElement.mm:
3830         * DOM/DOMHTMLBaseElement.mm:
3831         * DOM/DOMHTMLBaseFontElement.mm:
3832         * DOM/DOMHTMLBodyElement.mm:
3833         * DOM/DOMHTMLButtonElement.mm:
3834         * DOM/DOMHTMLCanvasElement.mm:
3835         * DOM/DOMHTMLCollection.mm:
3836         * DOM/DOMHTMLDListElement.mm:
3837         * DOM/DOMHTMLDirectoryElement.mm:
3838         * DOM/DOMHTMLDivElement.mm:
3839         * DOM/DOMHTMLDocument.mm:
3840         * DOM/DOMHTMLElement.mm:
3841         * DOM/DOMHTMLEmbedElement.mm:
3842         * DOM/DOMHTMLFieldSetElement.mm:
3843         * DOM/DOMHTMLFontElement.mm:
3844         * DOM/DOMHTMLFormElement.mm:
3845         * DOM/DOMHTMLFrameElement.mm:
3846         * DOM/DOMHTMLFrameSetElement.mm:
3847         * DOM/DOMHTMLHRElement.mm:
3848         * DOM/DOMHTMLHeadElement.mm:
3849         * DOM/DOMHTMLHeadingElement.mm:
3850         * DOM/DOMHTMLHtmlElement.mm:
3851         * DOM/DOMHTMLIFrameElement.mm:
3852         * DOM/DOMHTMLImageElement.mm:
3853         * DOM/DOMHTMLInputElement.mm:
3854         * DOM/DOMHTMLLIElement.mm:
3855         * DOM/DOMHTMLLabelElement.mm:
3856         * DOM/DOMHTMLLegendElement.mm:
3857         * DOM/DOMHTMLLinkElement.mm:
3858         * DOM/DOMHTMLMapElement.mm:
3859         * DOM/DOMHTMLMarqueeElement.mm:
3860         * DOM/DOMHTMLMediaElement.mm:
3861         * DOM/DOMHTMLMenuElement.mm:
3862         * DOM/DOMHTMLMetaElement.mm:
3863         * DOM/DOMHTMLModElement.mm:
3864         * DOM/DOMHTMLOListElement.mm:
3865         * DOM/DOMHTMLObjectElement.mm:
3866         * DOM/DOMHTMLOptGroupElement.mm:
3867         * DOM/DOMHTMLOptionElement.mm:
3868         * DOM/DOMHTMLOptionsCollection.mm:
3869         * DOM/DOMHTMLParagraphElement.mm:
3870         * DOM/DOMHTMLParamElement.mm:
3871         * DOM/DOMHTMLPreElement.mm:
3872         * DOM/DOMHTMLQuoteElement.mm:
3873         * DOM/DOMHTMLScriptElement.mm:
3874         * DOM/DOMHTMLSelectElement.mm:
3875         * DOM/DOMHTMLStyleElement.mm:
3876         * DOM/DOMHTMLTableCaptionElement.mm:
3877         * DOM/DOMHTMLTableCellElement.mm:
3878         * DOM/DOMHTMLTableColElement.mm:
3879         * DOM/DOMHTMLTableElement.mm:
3880         * DOM/DOMHTMLTableRowElement.mm:
3881         * DOM/DOMHTMLTableSectionElement.mm:
3882         * DOM/DOMHTMLTextAreaElement.mm:
3883         * DOM/DOMHTMLTitleElement.mm:
3884         * DOM/DOMHTMLUListElement.mm:
3885         * DOM/DOMHTMLVideoElement.mm:
3886         * DOM/DOMImplementation.mm:
3887         * DOM/DOMKeyboardEvent.mm:
3888         * DOM/DOMMediaError.mm:
3889         * DOM/DOMMediaList.mm:
3890         * DOM/DOMMouseEvent.mm:
3891         * DOM/DOMMutationEvent.mm:
3892         * DOM/DOMNamedNodeMap.mm:
3893         * DOM/DOMNode.mm:
3894         * DOM/DOMNodeIterator.mm:
3895         * DOM/DOMNodeList.mm:
3896         * DOM/DOMOverflowEvent.mm:
3897         * DOM/DOMProcessingInstruction.mm:
3898         * DOM/DOMProgressEvent.mm:
3899         * DOM/DOMRGBColor.mm:
3900         * DOM/DOMRange.mm:
3901         * DOM/DOMRect.mm:
3902         * DOM/DOMStyleSheet.mm:
3903         * DOM/DOMStyleSheetList.mm:
3904         * DOM/DOMText.mm:
3905         * DOM/DOMTextEvent.mm:
3906         * DOM/DOMTimeRanges.mm:
3907         * DOM/DOMTokenList.mm:
3908         * DOM/DOMTreeWalker.mm:
3909         * DOM/DOMUIEvent.mm:
3910         * DOM/DOMWheelEvent.mm:
3911         * DOM/DOMXPathExpression.mm:
3912         * DOM/DOMXPathResult.mm:
3913         * DOM/ObjCEventListener.mm:
3914
3915 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3916
3917         Fix spelling of "overridden"
3918         https://bugs.webkit.org/show_bug.cgi?id=188315
3919
3920         Reviewed by Darin Adler.
3921
3922         * Misc/WebKitVersionChecks.mm:
3923         (setWebKitLinkTimeVersion):
3924         (WebKitLinkTimeVersion):
3925         * Plugins/WebBaseNetscapePluginView.mm:
3926         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3927         * WebCoreSupport/PopupMenuMac.mm:
3928         (PopupMenuMac::populate):
3929
3930 2018-08-01  Nan Wang  <n_wang@apple.com>
3931
3932         AX: AOM: Add ARIA IDL Attribute Reflection
3933         https://bugs.webkit.org/show_bug.cgi?id=184676
3934         <rdar://problem/39476882>
3935
3936         Reviewed by Chris Fleizach.
3937
3938         * WebView/WebPreferenceKeysPrivate.h:
3939         * WebView/WebPreferences.mm:
3940         (+[WebPreferences initialize]):
3941         (-[WebPreferences ariaReflectionEnabled]):
3942         (-[WebPreferences setAriaReflectionEnabled:]):
3943         * WebView/WebPreferencesPrivate.h:
3944         * WebView/WebView.mm:
3945         (-[WebView _preferencesChanged:]):
3946
3947 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3948
3949         Shrink GraphicsLayerCA
3950         https://bugs.webkit.org/show_bug.cgi?id=188141
3951
3952         Reviewed by Zalan Bujtas.
3953
3954         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3955         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3956         * moving all the animation-related stuff into the lazily-allocated m_animations
3957         * making enums be 8-bit
3958         * re-ordering data members
3959
3960         * WebView/WebView.mm:
3961         (-[WebView _setMediaLayer:forPluginView:]):
3962
3963 2018-07-30  Rob Buis  <rbuis@igalia.com>
3964
3965         Merge PlatformCookieJar functions into NetworkStorageSession
3966         https://bugs.webkit.org/show_bug.cgi?id=188137
3967
3968         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3969
3970         Reviewed by Alex Christensen.
3971
3972         * WebCoreSupport/WebPlatformStrategies.mm:
3973         (WebPlatformStrategies::cookiesForDOM):
3974         (WebPlatformStrategies::setCookiesFromDOM):
3975         (WebPlatformStrategies::cookiesEnabled):
3976         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3977         (WebPlatformStrategies::getRawCookies):
3978         (WebPlatformStrategies::deleteCookie):
3979         * WebView/WebPreferences.mm:
3980         (+[WebPreferences _clearNetworkLoaderSession]):
3981
3982 2018-07-28  Darin Adler  <darin@apple.com>
3983
3984         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3985         https://bugs.webkit.org/show_bug.cgi?id=188140
3986
3987         Reviewed by Sam Weinig.
3988
3989         * WebView/WebImmediateActionController.mm:
3990         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3991         new DictionaryLookup function that returns a tuple instead of using an out argument.
3992
3993 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3994
3995         [INTL] Remove INTL sub-feature compile flags
3996         https://bugs.webkit.org/show_bug.cgi?id=188081
3997
3998         Reviewed by Michael Catanzaro.
3999
4000         * Configurations/FeatureDefines.xcconfig:
4001
4002 2018-07-26  Commit Queue  <commit-queue@webkit.org>
4003
4004         Unreviewed, rolling out r234181 and r234189.
4005         https://bugs.webkit.org/show_bug.cgi?id=188075
4006
4007         These are not needed right now (Requested by thorton on
4008         #webkit).
4009
4010         Reverted changesets:
4011
4012         "Enable Web Content Filtering on watchOS"
4013         https://bugs.webkit.org/show_bug.cgi?id=187979
4014         https://trac.webkit.org/changeset/234181
4015
4016         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
4017         https://bugs.webkit.org/show_bug.cgi?id=187985
4018         https://trac.webkit.org/changeset/234189
4019
4020 2018-07-26  Timothy Hatcher  <timothy@apple.com>
4021
4022         Use the Page's appearance when converting pasteboard attributed strings.
4023         https://bugs.webkit.org/show_bug.cgi?id=188067
4024         rdar://problem/42632246
4025
4026         Reviewed by Wenson Hsieh.
4027
4028         * WebCoreSupport/WebEditorClient.mm:
4029         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
4030
4031 2018-07-25  Chris Dumez  <cdumez@apple.com>
4032
4033         navigator.userAgent may return outdated value after webView.customUserAgent is set
4034         https://bugs.webkit.org/show_bug.cgi?id=188009
4035         <rdar://problem/42566456>
4036
4037         Reviewed by Alex Christensen.
4038
4039         Let the page know when the user agent changes.
4040
4041         * WebView/WebView.mm:
4042         (-[WebView _preferencesChanged:]):
4043         (-[WebView setApplicationNameForUserAgent:]):
4044         (-[WebView _invalidateUserAgentCache]):
4045         (-[WebView setCustomUserAgent:]):
4046         * WebView/WebViewInternal.h:
4047
4048 2018-07-24  Tim Horton  <timothy_horton@apple.com>
4049
4050         Enable Web Content Filtering on watchOS
4051         https://bugs.webkit.org/show_bug.cgi?id=187979
4052         <rdar://problem/42559346>
4053
4054         Reviewed by Wenson Hsieh.
4055
4056         * Configurations/FeatureDefines.xcconfig:
4057
4058 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
4059
4060         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
4061         https://bugs.webkit.org/show_bug.cgi?id=187846
4062
4063         Reviewed by Simon Fraser.
4064
4065         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
4066
4067         * WebView/WebHTMLView.mm:
4068         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
4069         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
4070
4071 2018-07-11  Dean Jackson  <dino@apple.com>
4072
4073         Allow removal of white backgrounds
4074