Use SecurityOriginData more consistently in Service Worker code
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-24  Chris Dumez  <cdumez@apple.com>
2
3         Use SecurityOriginData more consistently in Service Worker code
4         https://bugs.webkit.org/show_bug.cgi?id=183969
5
6         Reviewed by Darin Adler.
7
8         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
9
10         * Storage/WebDatabaseManager.mm:
11         (-[WebDatabaseManager databasesWithOrigin:]):
12         (-[WebDatabaseManager deleteOrigin:]):
13         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
14         * Storage/WebDatabaseQuotaManager.mm:
15         (-[WebDatabaseQuotaManager usage]):
16         (-[WebDatabaseQuotaManager quota]):
17         (-[WebDatabaseQuotaManager setQuota:]):
18         * Storage/WebStorageManager.mm:
19         (-[WebStorageManager deleteOrigin:]):
20         * WebCoreSupport/WebSecurityOrigin.mm:
21         (-[WebSecurityOrigin databaseIdentifier]):
22         (-[WebSecurityOrigin usage]):
23         (-[WebSecurityOrigin quota]):
24         (-[WebSecurityOrigin setQuota:]):
25
26 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
27
28         Fix the build
29
30         * WebView/WebView.mm:
31
32 2018-03-23  Tim Horton  <timothy_horton@apple.com>
33
34         Fix the build with no pasteboard
35         https://bugs.webkit.org/show_bug.cgi?id=183973
36
37         Reviewed by Dan Bernstein.
38
39         * Configurations/FeatureDefines.xcconfig:
40         * WebView/WebView.mm:
41         (-[WebView _requestStartDataInteraction:globalPosition:]):
42         (-[WebView _getDataInteractionData]):
43         (-[WebView _dataOperationTextIndicator]):
44         (-[WebView _dragSourceAction]):
45         (-[WebView _draggedLinkTitle]):
46         (-[WebView _draggedLinkURL]):
47         (-[WebView _draggedElementBounds]):
48         (-[WebView _enteredDataInteraction:client:global:operation:]):
49         (-[WebView _updatedDataInteraction:client:global:operation:]):
50         (-[WebView _exitedDataInteraction:client:global:operation:]):
51         (-[WebView _performDataInteraction:client:global:operation:]):
52         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
53         (-[WebView _endedDataInteraction:global:]):
54         (-[WebView _dataInteractionCaretRect]):
55         * WebView/WebViewPrivate.h:
56
57 2018-03-23  Tim Horton  <timothy_horton@apple.com>
58
59         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
60         https://bugs.webkit.org/show_bug.cgi?id=183960
61         <rdar://problem/38812356>
62
63         Reviewed by Dan Bernstein.
64
65         * Configurations/WebKitLegacy.xcconfig:
66
67 2018-03-23  Tim Horton  <timothy_horton@apple.com>
68
69         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
70         https://bugs.webkit.org/show_bug.cgi?id=183954
71         <rdar://problem/38808858>
72
73         Reviewed by Dan Bernstein.
74
75         * WebView/WebPreferences.mm:
76         (-[WebPreferences setAudioSessionCategoryOverride:]):
77
78 2018-03-23  Tim Horton  <timothy_horton@apple.com>
79
80         Adopt WK_PLATFORM_NAME in WebKitLegacy
81         https://bugs.webkit.org/show_bug.cgi?id=183948
82         <rdar://problem/38803908>
83
84         Reviewed by Dan Bernstein.
85
86         * Configurations/WebKitLegacy.xcconfig:
87         * MigrateHeaders.make:
88         * postprocess-headers.sh:
89
90 2018-03-23  Brady Eidson  <beidson@apple.com>
91
92         Go to back/forward list items after a process-swapped navigation.
93         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
94
95         Reviewed by Andy Estes.
96
97         * WebView/WebView.mm:
98         (-[WebView _loadBackForwardListFromOtherView:]):
99         (-[WebView goToBackForwardItem:]):
100
101 2018-03-22  Tim Horton  <timothy_horton@apple.com>
102
103         Improve readability of WebCore's OTHER_LDFLAGS
104         https://bugs.webkit.org/show_bug.cgi?id=183909
105         <rdar://problem/38760992>
106
107         Reviewed by Dan Bernstein.
108
109         * Configurations/Base.xcconfig:
110         * Configurations/FeatureDefines.xcconfig:
111
112 2018-03-20  Tim Horton  <timothy_horton@apple.com>
113
114         Enable the minimal simulator feature flag when appropriate
115         https://bugs.webkit.org/show_bug.cgi?id=183807
116
117         Reviewed by Dan Bernstein.
118
119         * Configurations/FeatureDefines.xcconfig:
120
121 2018-03-20  Tim Horton  <timothy_horton@apple.com>
122
123         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
124         https://bugs.webkit.org/show_bug.cgi?id=183758
125         <rdar://problem/38017644>
126
127         Reviewed by Dan Bernstein.
128
129         * Configurations/FeatureDefines.xcconfig:
130
131 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
132
133         Clear style colors when setting default appearance
134         https://bugs.webkit.org/show_bug.cgi?id=183759
135
136         Reviewed by Tim Horton.
137
138         Colors are cached and need to be cleared and recalculated.
139         Refactor to do all style recalcs together.
140
141         * WebView/WebView.mm:
142         (-[WebView _setDefaultAppearanceAndClearStyle]):
143         (-[WebView _setUseSystemAppearance:]):
144         (-[WebView effectiveAppearanceDidChange]):
145
146 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
147
148         Unreviewed, another quick fix for r229699
149
150         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
151
152         * Configurations/FeatureDefines.xcconfig:
153
154 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
155
156         Ensure that style is updated when the effective appearance changes
157         https://bugs.webkit.org/show_bug.cgi?id=183690
158         <rdar://problem/38385900>
159
160         Reviewed by Tim Horton and Wenson Hsieh.
161
162         Respond to and respect the effective appearance changing.
163
164         * WebView/WebView.mm:
165         (-[WebView _setUseSystemAppearance:]):
166         (-[WebView effectiveAppearanceDidChange]):
167
168 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
169
170         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
171         https://bugs.webkit.org/show_bug.cgi?id=183677
172
173         Reviewed by Tim Horton.
174
175         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
176
177         * DOM/DOM.mm:
178         (-[DOMHTMLLinkElement _mediaQueryMatches]):
179
180 2018-03-14  Tim Horton  <timothy_horton@apple.com>
181
182         Fix the build after r229567
183
184         * Configurations/FeatureDefines.xcconfig:
185
186 2018-03-12  Tim Horton  <timothy_horton@apple.com>
187
188         Stop using SDK conditionals to control feature definitions
189         https://bugs.webkit.org/show_bug.cgi?id=183430
190         <rdar://problem/38251619>
191
192         Reviewed by Dan Bernstein.
193
194         * Configurations/FeatureDefines.xcconfig:
195         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
196
197 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
198
199         Runtime flag for link prefetch and remove link subresource.
200         https://bugs.webkit.org/show_bug.cgi?id=183540
201
202         Reviewed by Chris Dumez.
203
204         Remove the LINK_PREFETCH build time flag.
205
206         * Configurations/FeatureDefines.xcconfig:
207
208 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
209
210         Remove GridLayout runtime flag
211         https://bugs.webkit.org/show_bug.cgi?id=183484
212
213         Reviewed by Myles C. Maxfield.
214
215         The Grid Layout feature has been enabled by default for almost a
216         year, so I think it's time to remove the runtime flag and the
217
218         * WebView/WebPreferenceKeysPrivate.h:
219         * WebView/WebPreferences.mm:
220         (+[WebPreferences initialize]):
221         * WebView/WebPreferencesPrivate.h:
222         * WebView/WebView.mm:
223         (-[WebView _preferencesChanged:]):
224
225 2018-03-12  Antoine Quint  <graouts@apple.com>
226
227         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
228         https://bugs.webkit.org/show_bug.cgi?id=183504
229         <rdar://problem/38372965>
230
231         Reviewed by Dean Jackson and Jon Lee.
232
233         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
234         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
235
236         * WebView/WebPreferenceKeysPrivate.h:
237         * WebView/WebPreferences.mm:
238         (+[WebPreferences initialize]):
239         (-[WebPreferences setModernMediaControlsEnabled:]):
240         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
241         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
242         * WebView/WebPreferencesPrivate.h:
243         * WebView/WebView.mm:
244         (-[WebView _preferencesChanged:]):
245
246 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
247
248         Media query for default appearance
249         https://bugs.webkit.org/show_bug.cgi?id=183539
250         <rdar://problem/38326388>
251
252         Reviewed by Tim Horton.
253
254         Write a media query to evaluate appearance.
255
256         * WebView/WebView.mm:
257         (-[WebView _commonInitializationWithFrameName:groupName:]):
258         (-[WebView _setUseSystemAppearance:]):
259
260 2018-03-09  Andy Estes  <aestes@apple.com>
261
262         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
263         https://bugs.webkit.org/show_bug.cgi?id=183489
264         <rdar://problem/38267517>
265
266         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
267         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
268         to issue a sandbox extension for this directory, but for security reasons App Sandbox
269         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
270         block with a nil error and a valid file URL, but no file will actually exist at that URL.
271
272         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
273         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
274         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
275         drop destination.
276
277         Reviewed by Wenson Hsieh.
278
279         * WebView/WebView.mm:
280         (-[WebView performDragOperation:]):
281
282 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
283
284         Allow WebViews to disable system appearance
285         https://bugs.webkit.org/show_bug.cgi?id=183418
286         <rdar://problem/36975642>
287
288         Reviewed by Tim Horton.
289
290         Allow webviews to choose whether or not to follow the default system appearance.
291
292         * WebView/WebView.mm:
293         (-[WebView _setUseSystemAppearance:]):
294         (-[WebView _useSystemAppearance]):
295         * WebView/WebViewPrivate.h:
296
297 2018-03-08  Youenn Fablet  <youenn@apple.com>
298
299         libwebrtc update broke internal builds
300         https://bugs.webkit.org/show_bug.cgi?id=183454
301
302         Reviewed by Eric Carlson.
303
304         * Configurations/WebKitLegacy.xcconfig:
305
306 2018-03-08  Chris Dumez  <cdumez@apple.com>
307
308         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
309         https://bugs.webkit.org/show_bug.cgi?id=183455
310         <rdar://problem/38191749>
311
312         Reviewed by Youenn Fablet.
313
314         Add a null check for the page as we have evidence from crashes that it can be null.
315         Other functions in WebFrameNetworkingContext already null check the page as well,
316         not just the frame so this is consistent.
317
318         * WebCoreSupport/WebFrameNetworkingContext.mm:
319         (WebFrameNetworkingContext::storageSession const):
320
321 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
322
323         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
324         https://bugs.webkit.org/show_bug.cgi?id=183429
325
326         Reviewed by Mark Lam.
327
328         * DOM/DOM.mm:
329         (+[DOMNode _nodeFromJSWrapper:]):
330         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
331         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
332         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
333         * Plugins/Hosted/ProxyInstance.mm:
334         (WebKit::ProxyInstance::invokeMethod):
335         * WebView/WebView.mm:
336         (aeDescFromJSValue):
337
338 2018-03-08  Tim Horton  <timothy_horton@apple.com>
339
340         Stop linking ApplicationServices directly
341         https://bugs.webkit.org/show_bug.cgi?id=182867
342         <rdar://problem/38252142>
343
344         Reviewed by Alex Christensen.
345
346         The frameworks that we use that live inside ApplicationServices
347         have mostly moved out, so import them directly.
348
349         * Carbon/CarbonUtils.h:
350         * WebKitPrefix.h:
351         * WebView/WebHTMLView.mm:
352         * WebView/WebPDFView.mm:
353
354 2018-03-07  Tim Horton  <timothy_horton@apple.com>
355
356         Sort and separate FeatureDefines.xcconfig
357         https://bugs.webkit.org/show_bug.cgi?id=183427
358
359         Reviewed by Dan Bernstein.
360
361         * Configurations/FeatureDefines.xcconfig:
362         Sort and split FeatureDefines into paragraphs
363         (to make it easier to sort later).
364
365 2018-03-07  Youenn Fablet  <youenn@apple.com>
366
367         Match unsupported plugins based on domains and not origin
368         https://bugs.webkit.org/show_bug.cgi?id=183384
369
370         Reviewed by Chris Dumez.
371
372         * WebCoreSupport/WebPluginInfoProvider.h:
373         * WebCoreSupport/WebPluginInfoProvider.mm:
374         (WebPluginInfoProvider::getPluginInfo):
375         (WebPluginInfoProvider::getWebVisiblePluginInfo):
376
377 2018-03-05  Andy Estes  <aestes@apple.com>
378
379         [Mac] Teach WebCore::Pasteboard about file promise drags
380         https://bugs.webkit.org/show_bug.cgi?id=183314
381         <rdar://problem/38105493>
382
383         Reviewed by Darin Adler.
384
385         Added a FIXME comment.
386
387         * WebView/WebView.mm:
388         (-[WebView performDragOperation:]):
389
390 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
391
392         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
393         https://bugs.webkit.org/show_bug.cgi?id=183312
394
395         Reviewed by Mark Lam.
396
397         Remove wtf/CurrentTime.h include pragma.
398
399         * WebView/WebFrame.mm:
400         * WebView/WebPDFView.mm:
401
402 2018-03-04  Tim Horton  <timothy_horton@apple.com>
403
404         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
405         https://bugs.webkit.org/show_bug.cgi?id=183283
406         <rdar://problem/38062148>
407
408         Reviewed by Sam Weinig.
409
410         * Configurations/FeatureDefines.xcconfig:
411
412 2018-02-28  Alex Christensen  <achristensen@webkit.org>
413
414         Reduce use of NetworkingContext in WebKit
415         https://bugs.webkit.org/show_bug.cgi?id=183213
416
417         Reviewed by Brady Eidson.
418
419         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
420         (WebKit::NetscapePluginInstanceProxy::getProxy):
421         * Plugins/WebNetscapePluginView.mm:
422         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
423
424 2018-02-17  Darin Adler  <darin@apple.com>
425
426         Prepare for ExtendedColor changes (first step)
427         https://bugs.webkit.org/show_bug.cgi?id=182904
428
429         Reviewed by Sam Weinig.
430
431         * Misc/WebKitNSStringExtras.mm:
432         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
433
434 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
435
436         Remove currentTime() / currentTimeMS()
437         https://bugs.webkit.org/show_bug.cgi?id=183052
438
439         Reviewed by Mark Lam.
440
441         * WebCoreSupport/WebFrameLoaderClient.h:
442         * WebCoreSupport/WebFrameLoaderClient.mm:
443         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
444
445 2018-02-16  Youenn Fablet  <youenn@apple.com>
446
447         Allow specifying which plug-ins are supported
448         https://bugs.webkit.org/show_bug.cgi?id=182748
449
450         Reviewed by Chris Dumez.
451
452         * WebCoreSupport/WebPluginInfoProvider.h:
453         * WebCoreSupport/WebPluginInfoProvider.mm:
454         (WebPluginInfoProvider::getPluginInfo):
455         (WebPluginInfoProvider::getWebVisiblePluginInfo):
456
457 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
458
459         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
460         https://bugs.webkit.org/show_bug.cgi?id=182882
461         <rdar://problem/35672661>
462
463         Reviewed by Dan Bernstein.
464
465         Make sure the smart pointer hold the collection of subviews lives at least as
466         long as the loop using it.
467
468         * WebView/WebHTMLView.mm:
469         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
470
471 2018-02-14  Daniel Bates  <dabates@apple.com>
472
473         Disallow cross-origin subresources from asking for credentials
474         https://bugs.webkit.org/show_bug.cgi?id=182579
475         <rdar://problem/36162271>
476
477         Reviewed by Andy Estes.
478
479         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
480         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
481
482         * WebView/WebPreferenceKeysPrivate.h:
483         * WebView/WebPreferences.mm:
484         (+[WebPreferences initialize]):
485         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
486         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
487         * WebView/WebPreferencesPrivate.h:
488         * WebView/WebView.mm:
489         (-[WebView _preferencesChanged:]):
490
491 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
492
493         Remove ForwardingHeaders directory from WebKitLegacy/mac.
494         https://bugs.webkit.org/show_bug.cgi?id=182738
495
496         Reviewed by Darin Adler.
497
498         * ForwardingHeaders/collector/handles/Global.h: Removed.
499         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
500         * ForwardingHeaders/runtime/Completion.h: Removed.
501         * ForwardingHeaders/runtime/Error.h: Removed.
502         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
503         * ForwardingHeaders/runtime/JSFunction.h: Removed.
504         * ForwardingHeaders/runtime/JSLock.h: Removed.
505         * ForwardingHeaders/runtime/JSObject.h: Removed.
506         * ForwardingHeaders/runtime/JSString.h: Removed.
507         * ForwardingHeaders/runtime/Protect.h: Removed.
508         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
509
510 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
511
512         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
513         https://bugs.webkit.org/show_bug.cgi?id=182641
514
515         Reviewed by Dan Bernstein.
516
517         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
518         https://trac.webkit.org/changeset/228308.
519
520         * WebView/WebVideoFullscreenController.h:
521         * WebView/WebVideoFullscreenHUDWindowController.mm:
522         * WebView/WebWindowAnimation.h:
523         * WebView/WebWindowAnimation.mm:
524         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
525         (WebCore::scaledRect): Deleted.
526         (WebCore::squaredDistance): Deleted.
527
528 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
529
530         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
531
532         * WebView/WebWindowAnimation.mm:
533         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
534
535 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
536
537         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
538         https://bugs.webkit.org/show_bug.cgi?id=182615
539
540         Reviewed by Eric Carlson.
541
542         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
543         Ideally, we should not reference NSApp in WebCore.
544
545         * WebView/WebFullScreenController.mm:
546         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
547         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
548         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
549         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
550         * WebView/WebView.mm:
551         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
552         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
553
554 2018-01-13  Darin Adler  <darin@apple.com>
555
556         Event improvements
557         https://bugs.webkit.org/show_bug.cgi?id=179591
558
559         Reviewed by Chris Dumez.
560
561         * DOM/DOMWheelEvent.mm:
562         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
563         Call initWebKitWheelEvent.
564
565         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
566         * WebCoreSupport/WebInspectorClient.mm: Ditto.
567         * WebView/WebFrame.mm: Ditto.
568
569         * WebView/WebHTMLView.mm:
570         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
571         underlyingPlatformEvent.
572         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
573
574         * WebView/WebScriptWorld.mm:
575         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
576
577         * WebView/WebView.mm: Removed include of ScriptValue.h.
578
579 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
580
581         Remove WebCore/ForwardingHeaders directory
582         https://bugs.webkit.org/show_bug.cgi?id=182347
583
584         Reviewed by Keith Miller.
585
586         * Carbon/CarbonWindowAdapter.mm:
587         * DOM/WebDOMOperations.mm:
588         * History/WebBackForwardList.mm:
589         * History/WebHistoryItem.mm:
590         * Misc/WebCache.mm:
591         * Misc/WebElementDictionary.mm:
592         * Misc/WebIconDatabase.mm:
593         * Misc/WebStringTruncator.mm:
594         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
595         * Plugins/Hosted/ProxyInstance.mm:
596         * Plugins/Hosted/ProxyRuntimeObject.mm:
597         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
598         * Plugins/WebBaseNetscapePluginView.mm:
599         * Plugins/WebBasePluginPackage.mm:
600         * Plugins/WebNetscapePluginStream.mm:
601         * Plugins/WebNetscapePluginView.mm:
602         * Plugins/WebPluginController.mm:
603         * WebCoreSupport/WebEditorClient.mm:
604         * WebCoreSupport/WebFrameLoaderClient.mm:
605         * WebCoreSupport/WebInspectorClient.h:
606         * WebCoreSupport/WebInspectorClient.mm:
607         * WebView/WebDataSource.mm:
608         * WebView/WebFrame.mm:
609         * WebView/WebHTMLRepresentation.mm:
610         * WebView/WebHTMLView.mm:
611         * WebView/WebPreferences.mm:
612         * WebView/WebScriptDebugDelegate.mm:
613         * WebView/WebScriptDebugger.h:
614         * WebView/WebTextIterator.mm:
615         * WebView/WebView.mm:
616         * WebView/WebViewData.mm:
617
618 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
619
620         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
621         https://bugs.webkit.org/show_bug.cgi?id=182312
622
623         Reviewed by Michael Catanzaro.
624
625         * WebKitPrefix.h:
626
627 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
628
629         [WebAuthN] Add a compile-time feature flag
630         https://bugs.webkit.org/show_bug.cgi?id=182211
631         <rdar://problem/36936365>
632
633         Reviewed by Brent Fulgham.
634
635         * Configurations/FeatureDefines.xcconfig:
636
637 2018-01-27  Dan Bernstein  <mitz@apple.com>
638
639         HaveInternalSDK includes should be "#include?"
640         https://bugs.webkit.org/show_bug.cgi?id=179670
641
642         * Configurations/Base.xcconfig:
643
644 2018-01-24  Alex Christensen  <achristensen@webkit.org>
645
646         Remove unused QTKit preference
647         https://bugs.webkit.org/show_bug.cgi?id=181968
648
649         Reviewed by Alexey Proskuryakov.
650
651         * WebView/WebPreferenceKeysPrivate.h:
652         * WebView/WebPreferences.mm:
653         (+[WebPreferences initialize]):
654         (-[WebPreferences setQTKitEnabled:]): Deleted.
655         (-[WebPreferences isQTKitEnabled]): Deleted.
656         * WebView/WebPreferencesPrivate.h:
657         * WebView/WebView.mm:
658         (-[WebView _preferencesChanged:]):
659
660 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
661
662         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
663         https://bugs.webkit.org/show_bug.cgi?id=182037
664         <rdar://problem/36747812>
665
666         Reviewed by Ryosuke Niwa.
667
668         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
669         for more details.
670
671         * WebView/WebHTMLRepresentation.mm:
672         (-[WebHTMLRepresentation elementWithName:inForm:]):
673         (-[WebHTMLRepresentation controlsInForm:]):
674
675 2018-01-23  Alex Christensen  <achristensen@webkit.org>
676
677         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
678         https://bugs.webkit.org/show_bug.cgi?id=181961
679
680         Reviewed by Michael Catanzaro.
681
682         * WebView/WebPreferences.mm:
683
684 2018-01-23  Commit Queue  <commit-queue@webkit.org>
685
686         Unreviewed, rolling out r227437.
687         https://bugs.webkit.org/show_bug.cgi?id=182011
688
689         broke build (Requested by alexchristensen on #webkit).
690
691         Reverted changeset:
692
693         "Remove unused QTKit preference"
694         https://bugs.webkit.org/show_bug.cgi?id=181968
695         https://trac.webkit.org/changeset/227437
696
697 2018-01-23  Alex Christensen  <achristensen@webkit.org>
698
699         Remove unused QTKit preference
700         https://bugs.webkit.org/show_bug.cgi?id=181968
701
702         Reviewed by Alexey Proskuryakov.
703
704         * WebView/WebPreferenceKeysPrivate.h:
705         * WebView/WebPreferences.mm:
706         (+[WebPreferences initialize]):
707         (-[WebPreferences setQTKitEnabled:]): Deleted.
708         (-[WebPreferences isQTKitEnabled]): Deleted.
709         * WebView/WebPreferencesPrivate.h:
710         * WebView/WebView.mm:
711         (-[WebView _preferencesChanged:]):
712
713 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
716         https://bugs.webkit.org/show_bug.cgi?id=181960
717         <rdar://problem/36431678>
718
719         Reviewed by Tim Horton.
720
721         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
722         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
723         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
724
725         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
726         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
727         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
728
729         * WebView/WebView.mm:
730         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
731
732 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
733
734         Turning off custom pasteboard data doesn't actually turn it off in WK2
735         https://bugs.webkit.org/show_bug.cgi?id=181920
736         <rdar://problem/36686429>
737
738         Reviewed by Wenson Hsieh.
739
740         Always disable custom pasteboard data in WebKit1. See r226156 for details.
741
742         * WebView/WebPreferences.mm:
743         (+[WebPreferences initialize]):
744         * WebView/WebView.mm:
745         (-[WebView _preferencesChanged:]):
746
747 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
748
749         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
750         https://bugs.webkit.org/show_bug.cgi?id=181918
751
752         Reviewed by Tim Horton.
753
754         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
755
756         * Configurations/FeatureDefines.xcconfig:
757
758 2018-01-20  Andy Estes  <aestes@apple.com>
759
760         [Apple Pay] Stop eagerly loading PassKit.framework
761         https://bugs.webkit.org/show_bug.cgi?id=181911
762         <rdar://problem/36555369>
763
764         Reviewed by Tim Horton.
765
766         * WebCoreSupport/WebPaymentCoordinatorClient.h:
767         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
768         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
769
770         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
771
772 2018-01-19  Dean Jackson  <dino@apple.com>
773
774         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
775         https://bugs.webkit.org/show_bug.cgi?id=181817
776         <rdar://problem/35274055>
777
778         Reviewed by Simon Fraser.
779
780         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
781
782         * Misc/WebKitVersionChecks.h:
783         * WebView/WebView.mm:
784         (-[WebView _commonInitializationWithFrameName:groupName:]):
785
786 2018-01-19  Alex Christensen  <achristensen@webkit.org>
787
788         Remove unused WebViewPrivate _allowCookies
789         https://bugs.webkit.org/show_bug.cgi?id=181812
790
791         Reviewed by Tim Horton.
792
793         * WebView/WebView.mm:
794         (+[WebView _setAllowCookies:]): Deleted.
795         (+[WebView _allowCookies]): Deleted.
796         * WebView/WebViewPrivate.h:
797
798 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
799
800         Build fix, remove a call to -[NSWindow setOneShot:]
801         https://bugs.webkit.org/show_bug.cgi?id=181809
802
803         Reviewed by Tim Horton.
804
805         * WebView/WebTextCompletionController.mm:
806         (-[WebTextCompletionController _buildUI]):
807
808 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
809
810         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
811
812         * Carbon/HIWebView.mm:
813         (overrideCGContext):
814         (restoreCGContext):
815
816 2018-01-18  Dan Bernstein  <mitz@apple.com>
817
818         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
819         https://bugs.webkit.org/show_bug.cgi?id=181803
820
821         Reviewed by Tim Horton.
822
823         * Configurations/Base.xcconfig: Updated.
824         * Configurations/DebugRelease.xcconfig: Ditto.
825         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
826         * Configurations/Version.xcconfig: Updated.
827         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
828           useful for defining settings that depend on the target macOS version.
829
830 2018-01-17  Youenn Fablet  <youenn@apple.com>
831
832         Put fetch Request.keepalive behind a runtime flag
833         https://bugs.webkit.org/show_bug.cgi?id=181592
834
835         Reviewed by Chris Dumez.
836
837         * WebView/WebPreferenceKeysPrivate.h:
838         * WebView/WebPreferences.mm:
839         (+[WebPreferences initialize]):
840         (-[WebPreferences fetchAPIKeepAliveEnabled]):
841         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
842         * WebView/WebPreferencesPrivate.h:
843         * WebView/WebView.mm:
844         (-[WebView _preferencesChanged:]):
845
846 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
847
848         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
849         https://bugs.webkit.org/show_bug.cgi?id=181637
850         <rdar://problem/36508471>
851
852         Reviewed by Tim Horton.
853
854         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
855
856         * WebCoreSupport/WebEditorClient.h:
857         * WebCoreSupport/WebEditorClient.mm:
858         (WebEditorClient::replacementURLForResource):
859
860 2018-01-11  Keith Miller  <keith_miller@apple.com>
861
862         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
863         https://bugs.webkit.org/show_bug.cgi?id=181573
864
865         Reviewed by Simon Fraser.
866
867         * Configurations/FeatureDefines.xcconfig:
868
869 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
870
871         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
872         https://bugs.webkit.org/show_bug.cgi?id=181497
873
874         Reviewed by Tim Horton.
875
876         See other ChangeLogs for more detail.
877
878         * WebCoreSupport/WebDragClient.h:
879
880 2018-01-11  Tim Horton  <timothy_horton@apple.com>
881
882         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
883         https://bugs.webkit.org/show_bug.cgi?id=181523
884         <rdar://problem/28959131>
885
886         Reviewed by Alex Christensen.
887
888         * WebView/WebImmediateActionController.mm:
889         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
890         Apply the change made in r216652 to WebKit1's immediate action controller.
891
892         Speculative (but successful in WebKit2) fix for non-reproducible crash when
893         the startContainer of the range is in an anonymous node.
894
895 2018-01-11  Youenn Fablet  <youenn@apple.com>
896
897         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
898         https://bugs.webkit.org/show_bug.cgi?id=181480
899
900         Reviewed by Eric Carlson.
901
902         * WebView/WebPreferences.mm:
903         (+[WebPreferences initialize]):
904
905 2018-01-08  David Kilzer  <ddkilzer@apple.com>
906
907         Fix check-webkit-style issues with WebNSDataExtras.mm
908         <https://webkit.org/b/181369>
909
910         Reviewed by Alex Christensen.
911
912         * Misc/WebNSDataExtras.mm:
913         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
914         (-[NSData _webkit_guessedMIMETypeForXML]):
915         (-[NSData _webkit_guessedMIMEType]):
916         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
917         (_findEOL):
918         (-[NSData _webkit_parseRFC822HeaderFields]):
919         (-[NSData _web_locationAfterFirstBlankLine]):
920         - Fix all the check-webkit-style warnings.
921
922 2018-01-08  David Kilzer  <ddkilzer@apple.com>
923
924         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
925         <https://webkit.org/b/181256>
926         <rdar://problem/36281730>
927
928         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
929         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
930         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
931           to avoid warnings from casting CFStringRef to NPNSString*.
932           Note that CFMutableStringRef is the same as CFStringRef
933           without the const modifier, hence its use in the const_cast<>
934           above.
935
936 2018-01-08  David Kilzer  <ddkilzer@apple.com>
937
938         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
939         <https://webkit.org/b/181256>
940         <rdar://problem/36281730>
941
942         * Carbon/HIWebView.mm:
943         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
944         checked_cf_cast<CFRunLoopRef>() to fix warning.
945
946 2018-01-07  David Kilzer  <ddkilzer@apple.com>
947
948         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
949         <https://webkit.org/b/181256>
950         <rdar://problem/36281730>
951
952         Reviewed by Darin Adler.
953
954         * Carbon/CarbonUtils.m:
955         (PoolCleaner):
956         - Use #pragmas to ignore -Wcast-qual warnings when using a
957           C-style cast from CFTypeRef to CFRunloopRef.
958         * Carbon/CarbonWindowFrame.m:
959         (-[CarbonWindowFrame title]):
960         - Use #pragmas to ignore -Wcast-qual warnings when using a
961           C-style cast from CFStringRef to NSString *.
962         * Carbon/HIViewAdapter.m:
963         (+[HIViewAdapter getHIViewForNSView:]):
964         - Use #pragmas to ignore -Wcast-qual warnings when using a
965           C-style cast from CFTypeRef to HIViewRef.
966         * Configurations/Base.xcconfig:
967         (WARNING_CFLAGS): Add -Wcast-qual.
968         * Misc/WebElementDictionary.mm:
969         (-[WebElementDictionary objectForKey:]):
970         - Use static_cast<SEL>(const_cast<void*>()) to fix
971           warning.
972         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
973         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
974         (-[NSData _webkit_guessedMIMETypeForXML]):
975         (-[NSData _webkit_guessedMIMEType]):
976         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
977         (_findEOL):
978         (-[NSData _webkit_parseRFC822HeaderFields]):
979         (-[NSData _web_startsWithBlankLine]):
980         (-[NSData _web_locationAfterFirstBlankLine]):
981         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
982           type to Objective-C++.  This fixes the warnings about
983           discarding the `const` modifier when casing from CFStringRef
984           to NSString * because in older clang versions, -Wcast-qual was
985           completely broken when compiling C++ and Objective-C++ source
986           files.  In newer clang versions, discarding the `const`
987           modifier for toll-free bridged types is ignored when compiling
988           Objective-C++ source.
989         - Update copyright and license header.
990         - Use reinterpret_cast<> and static_cast<> to fix warnings
991           unrelated to (NSString *) C-style casts.
992         - Replace use of MIN() macro with std::min<> template functions.
993         - Fix location of `*` for local variables modified above.
994         * Plugins/Hosted/NetscapePluginHostManager.mm:
995         (WebKit::NetscapePluginHostManager::spawnPluginHost):
996         (WebKit::NetscapePluginHostManager::initializeVendorPort):
997         (WebKit::NetscapePluginHostManager::instantiatePlugin):
998         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
999           warnings.
1000         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1001         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1002         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1003           to fix warning.
1004         * Plugins/Hosted/ProxyInstance.mm:
1005         (WebKit::ProxyInstance::invoke):
1006         - Use static_cast<char*>(const_cast<void*>()) to fix
1007           warning when using -[NSData bytes].
1008         (WebKit::ProxyInstance::fieldValue const):
1009         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1010           to fix warning when using CFDataGetBytePtr().
1011         * Plugins/Hosted/WebTextInputWindowController.m:
1012         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1013         - Use #pragma to ignore -Wcast-qual warning since there
1014           is not a good way to avoid this warning in Objective-C.
1015         * Plugins/WebNetscapePluginStream.mm:
1016         (WebNetscapePluginStream::deliverData):
1017         - Use const_cast<void*>() to fix warning when using
1018           -[NSData bytes].
1019         * Plugins/WebNetscapePluginView.mm:
1020         (-[WebNetscapePluginView _createPlugin]):
1021         - Change C-style cast to const_cast<char*>() to fix
1022           warning.
1023         * WebCoreSupport/WebChromeClient.mm:
1024         (WebChromeClient::wrapCryptoKey const):
1025         (WebChromeClient::unwrapCryptoKey const):
1026         - Change C-style cast to
1027           static_cast<uint8_t*>(const_cast<void*>() to fix
1028           warning.
1029         * WebView/WebPDFView.mm:
1030         (_applicationInfoForMIMEType):
1031         - Change local variable type from 'NSURL *' to
1032           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1033           when calling -[NSURL path].
1034
1035 2018-01-05  Dan Bernstein  <mitz@apple.com>
1036
1037         Fixed the build following AppKit API deprecations in a recent SDKs
1038
1039         * WebView/WebFullScreenController.mm:
1040         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1041         (-[WebFullScreenController exitFullScreen]): Ditto.
1042         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1043         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1044         * WebView/WebHTMLView.mm:
1045         (-[WebHTMLView drawRect:]): Ditto.
1046         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1047         (-[WebHTMLView knowsPageRange:]): Ditto.
1048         * WebView/WebView.mm:
1049         (LayerFlushController::flushLayers): Ditto.
1050
1051 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1052
1053         [Attachment Support] Create attachment elements when dropping files on iOS
1054         https://bugs.webkit.org/show_bug.cgi?id=181192
1055         <rdar://problem/36280945>
1056
1057         Reviewed by Tim Horton.
1058
1059         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1060
1061         * WebCoreSupport/WebPlatformStrategies.h:
1062         * WebCoreSupport/WebPlatformStrategies.mm:
1063         (WebPlatformStrategies::informationForItemAtIndex):
1064         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1065
1066 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1067
1068         [Attachment Support] Add plumbing for starting a drag with promised blob data
1069         https://bugs.webkit.org/show_bug.cgi?id=181201
1070
1071         Reviewed by Tim Horton.
1072
1073         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1074
1075         * WebCoreSupport/WebDragClient.h:
1076
1077 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1078
1079         Add a WebAuthentication runtime feature flag
1080         https://bugs.webkit.org/show_bug.cgi?id=181220
1081         <rdar://problem/36055305>
1082
1083         Reviewed by Brent Fulgham.
1084
1085         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1086
1087         * WebView/WebPreferenceKeysPrivate.h:
1088         * WebView/WebPreferences.mm:
1089         (+[WebPreferences initialize]):
1090         (-[WebPreferences webAuthenticationEnabled]):
1091         (-[WebPreferences setWebAuthenticationEnabled:]):
1092         (-[WebPreferences credentialManagementEnabled]): Deleted.
1093         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1094         * WebView/WebPreferencesPrivate.h:
1095         * WebView/WebView.mm:
1096         (-[WebView _preferencesChanged:]):
1097
1098 2017-12-22  Jeff Miller  <jeffm@apple.com>
1099
1100         Update user-visible copyright strings to include 2018
1101         https://bugs.webkit.org/show_bug.cgi?id=181141
1102
1103         Reviewed by Dan Bernstein.
1104
1105         * Info.plist:
1106
1107 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1108
1109         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1110         https://bugs.webkit.org/show_bug.cgi?id=181188
1111
1112         Reviewed by Dan Bernstein.
1113
1114         See WebCore/ChangeLog for more detail.
1115
1116         * WebCoreSupport/WebDragClient.h:
1117         * WebCoreSupport/WebDragClient.mm:
1118         (WebDragClient::declareAndWriteAttachment): Deleted.
1119         * WebView/WebHTMLView.mm:
1120         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1121
1122 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1123
1124         Unreviewed, continue to fix build failures due to AppKit API deprecation
1125
1126         Wraps more code in -Wdeprecated-declarations.
1127
1128         * Carbon/HIWebView.mm:
1129         (overrideCGContext):
1130
1131 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1132
1133         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1134
1135         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1136
1137         * Carbon/CarbonWindowAdapter.mm:
1138         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1139         * Plugins/WebNetscapePluginView.mm:
1140         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1141         (-[WebNetscapePluginView sendDrawRectEvent:]):
1142         (-[WebNetscapePluginView drawRect:]):
1143
1144 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1145
1146         Fix build failures due to using deprecated AppKit symbols
1147         https://bugs.webkit.org/show_bug.cgi?id=181110
1148         <rdar://problem/36162865>
1149
1150         Reviewed by Dan Bernstein and Tim Horton.
1151
1152         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1153
1154         * Misc/WebKitNSStringExtras.mm:
1155         (-[NSString _web_drawAtPoint:font:textColor:]):
1156         * Misc/WebNSPasteboardExtras.h:
1157         * Misc/WebNSPasteboardExtras.mm:
1158         (+[NSPasteboard _web_writableTypesForURL]):
1159         (_createWritableTypesForImageWithoutArchive):
1160         (_createWritableTypesForImageWithArchive):
1161         (+[NSPasteboard _web_dragTypesForURL]):
1162         (-[NSPasteboard _web_bestURL]):
1163         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1164         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1165         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1166         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1167         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1168         * Panels/WebAuthenticationPanel.m:
1169         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1170         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1171         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1172         (-[WebHostedNetscapePluginView drawRect:]):
1173         * WebInspector/WebNodeHighlightView.mm:
1174         (-[WebNodeHighlightView drawRect:]):
1175         * WebView/WebFrame.mm:
1176         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1177         (-[WebFrame _drawRect:contentsOnly:]):
1178         * WebView/WebHTMLView.mm:
1179         (kit):
1180         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1181         (-[WebHTMLView _plainTextFromPasteboard:]):
1182         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1183         (+[WebHTMLView _insertablePasteboardTypes]):
1184         (+[WebHTMLView _selectionPasteboardTypes]):
1185         (-[WebHTMLView pasteboard:provideDataForType:]):
1186         (-[WebHTMLView _writeSelectionToPasteboard:]):
1187         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1188         (-[WebHTMLView validRequestorForSendType:returnType:]):
1189         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1190         (createMenuItem):
1191         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1192         (-[WebHTMLView _colorAsString:]):
1193         (-[WebHTMLView copyFont:]):
1194         * WebView/WebPDFView.mm:
1195         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1196         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1197         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1198         (-[WebPDFView pasteboardTypesForSelection]):
1199         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1200         * WebView/WebView.h:
1201         * WebView/WebView.mm:
1202         (-[WebView performDragOperation:]):
1203         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1204         (-[WebView _searchWithGoogleFromMenu:]):
1205
1206 2017-12-21  Youenn Fablet  <youenn@apple.com>
1207
1208         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1209         https://bugs.webkit.org/show_bug.cgi?id=181000
1210
1211         Reviewed by Chris Dumez.
1212
1213         * Misc/WebCache.mm:
1214         (+[WebCache addImageToCache:forURL:forFrame:]):
1215
1216 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1217
1218         Update FULLSCREEN_API feature defines.
1219         https://bugs.webkit.org/show_bug.cgi?id=181015
1220
1221         Reviewed by Tim Horton.
1222
1223         Change enabled iphone sdk for FULLSCREEN_API.
1224
1225         * Configurations/FeatureDefines.xcconfig:
1226
1227 2017-12-21  Jer Noble  <jer.noble@apple.com>
1228
1229         Add initial DOM support for Media Capabilities
1230         https://bugs.webkit.org/show_bug.cgi?id=181064
1231
1232         Reviewed by Eric Carlson.
1233
1234         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1235
1236         * WebView/WebPreferenceKeysPrivate.h:
1237         * WebView/WebPreferences.mm:
1238         (+[WebPreferences initialize]):
1239         (-[WebPreferences mediaCapabilitiesEnabled]):
1240         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1241         * WebView/WebPreferencesPrivate.h:
1242         * WebView/WebView.mm:
1243         (-[WebView _preferencesChanged:]):
1244
1245 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1246
1247         Enable picture-in-picture from inline element on suspend.
1248         https://bugs.webkit.org/show_bug.cgi?id=180942
1249         rdar://problem/34745234
1250
1251         Reviewed by Jer Noble.
1252
1253         Update signature of enterVideoFullscreenForVideoElement().
1254
1255         * WebCoreSupport/WebChromeClient.h:
1256         * WebCoreSupport/WebChromeClient.mm:
1257         (WebChromeClient::enterVideoFullscreenForVideoElement):
1258
1259 2017-12-20  Daniel Bates  <dabates@apple.com>
1260
1261         Remove Alternative Presentation Button
1262         https://bugs.webkit.org/show_bug.cgi?id=180500
1263         <rdar://problem/35891047>
1264
1265         Reviewed by Simon Fraser.
1266
1267         We no longer need the alternative presentation button.
1268
1269         * Configurations/FeatureDefines.xcconfig:
1270
1271 2017-12-19  Jer Noble  <jer.noble@apple.com>
1272
1273         Playing media elements which call "pause(); play()" will have the play promise rejected.
1274         https://bugs.webkit.org/show_bug.cgi?id=180781
1275         <rdar://problem/33191377>
1276
1277         Reviewed by Eric Carlson.
1278
1279         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1280
1281         * WebView/WebView.mm:
1282         (shouldRequireUserGestureToLoadVideo):
1283
1284 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1285
1286         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1287         https://bugs.webkit.org/show_bug.cgi?id=180977
1288
1289         Reviewed by Tim Horton.
1290
1291         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1292         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1293         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1294
1295         * WebCoreSupport/WebEditorClient.mm:
1296         (attributesForAttributedStringConversion):
1297         * WebView/WebHTMLView.mm:
1298         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1299
1300 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1301
1302         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1303
1304         Attempt to fix the following warnings:
1305
1306             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1307
1308         For the following instance variables:
1309
1310             _borderView
1311             _contentView
1312             _frame
1313             _wFlags
1314
1315         * Carbon/CarbonWindowAdapter.mm:
1316         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1317         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1318         (-[CarbonWindowAdapter _termWindowIfOwner]):
1319         (-[CarbonWindowAdapter _windowMovedToRect:]):
1320         (-[CarbonWindowAdapter setContentView:]):
1321         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1322         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1323
1324 2017-12-16  Dan Bernstein  <mitz@apple.com>
1325
1326         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1327         https://bugs.webkit.org/show_bug.cgi?id=180613
1328         <rdar://problem/35946124>
1329
1330         Reviewed by Geoff Garen.
1331
1332         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1333           clients.
1334         * WebView/WebDynamicScrollBarsView.h: Ditto.
1335         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1336
1337 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1338
1339         Enable -Wstrict-prototypes for WebKit
1340         <https://webkit.org/b/180757>
1341         <rdar://problem/36024132>
1342
1343         Rubber-stamped by Joseph Pecoraro.
1344
1345         * Configurations/Base.xcconfig:
1346         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1347
1348 2017-12-14  John Wilander  <wilander@apple.com>
1349
1350         Storage Access API: Implement frame-specific access in the document.cookie layer
1351         https://bugs.webkit.org/show_bug.cgi?id=180682
1352         <rdar://problem/35982257>
1353
1354         Reviewed by Alex Christensen.
1355
1356         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1357         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1358         CookiesStrategy::getRawCookies() now take optional parameters for
1359         frameID and pageID to allow frame-specific scoping of cookies.
1360
1361         This change makes the return values of FrameLoaderClient::frameID()
1362         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1363         WebCore can call those getters and get the right return values in
1364         WebKit and std:nullopt in WebKitLegacy.
1365
1366         * WebCoreSupport/WebFrameLoaderClient.h:
1367         * WebCoreSupport/WebFrameLoaderClient.mm:
1368         (WebFrameLoaderClient::pageID const):
1369         (WebFrameLoaderClient::frameID const):
1370         * WebCoreSupport/WebPlatformStrategies.h:
1371         * WebCoreSupport/WebPlatformStrategies.mm:
1372         (WebPlatformStrategies::cookiesForDOM):
1373         (WebPlatformStrategies::setCookiesFromDOM):
1374         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1375         (WebPlatformStrategies::getRawCookies):
1376
1377 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1378
1379         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1380         https://bugs.webkit.org/show_bug.cgi?id=180689
1381
1382         Reviewed by Tim Horton.
1383
1384         Use sRGBColorSpaceRef() from WebCore.
1385
1386         * WebView/WebHTMLView.mm:
1387         (imageFromRect):
1388
1389 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1390
1391         Stop using deprecated target conditional for simulator builds
1392         https://bugs.webkit.org/show_bug.cgi?id=180662
1393         <rdar://problem/35136156>
1394
1395         Reviewed by Simon Fraser.
1396
1397         * postprocess-headers.sh:
1398
1399 2017-12-11  David Quesada  <david_quesada@apple.com>
1400
1401         Turn on ENABLE_APPLICATION_MANIFEST
1402         https://bugs.webkit.org/show_bug.cgi?id=180562
1403         rdar://problem/35924737
1404
1405         Reviewed by Geoffrey Garen.
1406
1407         * Configurations/FeatureDefines.xcconfig:
1408
1409 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1410
1411         Remove pthread_once in favor of dispatch_once
1412         https://bugs.webkit.org/show_bug.cgi?id=180591
1413
1414         Reviewed by Saam Barati.
1415
1416         * Misc/WebKitErrors.m:
1417         (+[NSError _registerWebKitErrors]):
1418         (registerErrors): Deleted.
1419         * Storage/WebStorageManager.mm:
1420         (+[WebStorageManager _storageDirectoryPath]):
1421         (initializeLocalStoragePath): Deleted.
1422
1423 2017-12-07  Darin Adler  <darin@apple.com>
1424
1425         Remove some unused code from WebKitLegacy
1426         https://bugs.webkit.org/show_bug.cgi?id=180567
1427
1428         Reviewed by Anders Carlsson.
1429
1430         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1431         macOS (back a few versions) and iOS and removed unused
1432         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1433         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1434         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1435         _webkit_stringByCollapsingNonPrintingCharacters,
1436         _webkit_stringByCollapsingWhitespaceCharacters,
1437         _web_stringWithData:textEncodingName:, and
1438         _webkit_localStorageDirectoryWithBundleIdentifier:.
1439
1440         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1441         this source file.
1442         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1443         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1444         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1445         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1446         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1447         handle font smoothing options.
1448         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1449         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1450         from header and made it a little clearer.
1451         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1452         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1453         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1454         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1455         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1456         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1457         implementation a bit and used whole words instead of abbreviations.
1458         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1459
1460         * Misc/WebNSFileManagerExtras.mm:
1461         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1462         filenameByFixingIllegalCharacters function from WebCore directly instead of
1463         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1464
1465         * Plugins/WebBaseNetscapePluginView.mm:
1466         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1467         string replacements instead of _web_stringByStrippingReturnCharacters
1468         and to use NSString methods instead of CFString functions.
1469
1470 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1471
1472         Ignore deprecation warnings.
1473
1474         * WebView/WebHTMLView.mm:
1475         (-[NSWindow _web_borderView]):
1476         (-[WebHTMLView _setAsideSubviews]):
1477         * WebView/WebView.mm:
1478         (-[WebView encodeWithCoder:]):
1479
1480 2017-12-02  Darin Adler  <darin@apple.com>
1481
1482         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1483         https://bugs.webkit.org/show_bug.cgi?id=180009
1484
1485         Reviewed by Alex Christensen.
1486
1487         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1488
1489         * Plugins/WebBaseNetscapePluginView.mm:
1490         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1491         of strcasecmp.
1492
1493         * WebView/WebPreferences.mm:
1494         (contains): Ditto. Also made this a template so it's easier to call on an array.
1495         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1496
1497 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1498
1499         Limit user agent versioning to an upper bound
1500         https://bugs.webkit.org/show_bug.cgi?id=180365
1501         <rdar://problem/34550617>
1502
1503         Reviewed by Joseph Pecoraro.
1504
1505         * WebView/WebView.mm:
1506         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1507         creating the User Agent string.
1508         (webKitBundleVersionString): Deleted.
1509
1510 2017-12-05  Andy Estes  <aestes@apple.com>
1511
1512         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1513         https://bugs.webkit.org/show_bug.cgi?id=180457
1514         <rdar://problem/35143007>
1515
1516         Reviewed by Tim Horton.
1517
1518         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1519         check for this macro during post-processing.
1520
1521         * postprocess-headers.sh:
1522
1523 2017-12-04  David Quesada  <david_quesada@apple.com>
1524
1525         Add a class for parsing application manifests
1526         https://bugs.webkit.org/show_bug.cgi?id=177973
1527         rdar://problem/34747949
1528
1529         Reviewed by Geoffrey Garen.
1530
1531         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1532
1533 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1534
1535         Make LegacyCustomProtocolManager optional for network process
1536         https://bugs.webkit.org/show_bug.cgi?id=176230
1537
1538         Reviewed by Alex Christensen.
1539
1540         * Configurations/FeatureDefines.xcconfig:
1541
1542 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1543
1544         Fix some NSOperationQueue leaks
1545         https://bugs.webkit.org/show_bug.cgi?id=180221
1546
1547         Reviewed by Wenson Hsieh.
1548
1549         * WebView/WebView.mm:
1550         (-[WebView performDragOperation:]):
1551
1552 2017-11-30  Darin Adler  <darin@apple.com>
1553
1554         [Mac] remove unneeded RetainPtr use introduced in r225142
1555         https://bugs.webkit.org/show_bug.cgi?id=180202
1556
1557         Reviewed by Tim Horton.
1558
1559         * WebView/WebImmediateActionController.mm:
1560         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1561         RetainPtr.
1562
1563 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1564
1565         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1566         https://bugs.webkit.org/show_bug.cgi?id=175595
1567
1568         Reviewed by Darin Adler.
1569
1570         * WebView/WebPreferences.mm:
1571
1572 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1573
1574         One too many zeroes in macOS version number in FeatureDefines
1575         https://bugs.webkit.org/show_bug.cgi?id=180011
1576
1577         Reviewed by Dan Bernstein.
1578
1579         * Configurations/FeatureDefines.xcconfig:
1580
1581 2017-11-23  Darin Adler  <darin@apple.com>
1582
1583         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1584         https://bugs.webkit.org/show_bug.cgi?id=179981
1585
1586         Reviewed by Sam Weinig.
1587
1588         * WebView/WebImmediateActionController.mm:
1589         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1590         * WebView/WebView.mm:
1591         (coreOptions): Use |= instead of | to build up FindOptions.
1592
1593 2017-11-23  Sam Weinig  <sam@webkit.org>
1594
1595         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1596         https://bugs.webkit.org/show_bug.cgi?id=179954
1597
1598         Reviewed by Darin Adler.
1599
1600         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1601         with direct calls to the corresponding UserGestureIndicator functions.
1602
1603         * Plugins/WebPluginController.mm:
1604         (-[WebPluginController processingUserGesture]):
1605         * WebView/WebView.mm:
1606         (-[WebView _isProcessingUserGesture]):
1607
1608 2017-11-23  Darin Adler  <darin@apple.com>
1609
1610         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1611         https://bugs.webkit.org/show_bug.cgi?id=179907
1612
1613         Reviewed by Sam Weinig.
1614
1615         * History/BinaryPropertyList.cpp:
1616         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1617         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1618         * WebView/WebHTMLRepresentation.mm:
1619         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1620         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1621
1622 2017-11-22  Ali Juma  <ajuma@chromium.org>
1623
1624         Implement VisualViewport API attributes
1625         https://bugs.webkit.org/show_bug.cgi?id=179385
1626
1627         Reviewed by Frédéric Wang.
1628
1629         Add a VisualViewportAPI preference.
1630
1631         * WebView/WebPreferenceKeysPrivate.h:
1632         * WebView/WebPreferences.mm:
1633         (+[WebPreferences initialize]):
1634         (-[WebPreferences visualViewportAPIEnabled]):
1635         (-[WebPreferences setVisualViewportAPIEnabled:]):
1636         * WebView/WebPreferencesPrivate.h:
1637         * WebView/WebView.mm:
1638         (-[WebView _preferencesChanged:]):
1639
1640 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1641
1642         WebCoreObjCExtras.h is being included in too many places
1643         https://bugs.webkit.org/show_bug.cgi?id=179931
1644
1645         Reviewed by Darin Adler.
1646
1647         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1648         * Plugins/WebBaseNetscapePluginView.mm:
1649         * Plugins/WebBasePluginPackage.mm:
1650         * Plugins/WebNetscapePluginStream.mm:
1651         * Plugins/WebNetscapePluginView.mm:
1652         * WebView/WebTextIterator.mm:
1653         * WebView/WebViewData.mm:
1654
1655 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1656
1657         Unreviewed, rolling out r225093.
1658         https://bugs.webkit.org/show_bug.cgi?id=179938
1659
1660         Compilation failed on WinCairo 64-bit Release (Requested by
1661         fredw on #webkit).
1662
1663         Reverted changeset:
1664
1665         "Implement VisualViewport API attributes"
1666         https://bugs.webkit.org/show_bug.cgi?id=179385
1667         https://trac.webkit.org/changeset/225093
1668
1669 2017-11-21  Ali Juma  <ajuma@chromium.org>
1670
1671         Implement VisualViewport API attributes
1672         https://bugs.webkit.org/show_bug.cgi?id=179385
1673
1674         Reviewed by Frédéric Wang.
1675
1676         Add a VisualViewportAPI preference.
1677
1678         * WebView/WebPreferenceKeysPrivate.h:
1679         * WebView/WebPreferences.mm:
1680         (+[WebPreferences initialize]):
1681         (-[WebPreferences visualViewportAPIEnabled]):
1682         (-[WebPreferences setVisualViewportAPIEnabled:]):
1683         * WebView/WebPreferencesPrivate.h:
1684         * WebView/WebView.mm:
1685         (-[WebView _preferencesChanged:]):
1686
1687 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1688
1689         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1690         https://bugs.webkit.org/show_bug.cgi?id=179504
1691
1692         Reviewed by Darin Adler.
1693
1694         * Misc/WebKitNSStringExtras.mm:
1695         * Plugins/Hosted/NetscapePluginHostManager.mm:
1696         * Plugins/WebBasePluginPackage.mm:
1697
1698 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1699
1700         Remove unused TOUCH_ICON_LOADING feature flag
1701         https://bugs.webkit.org/show_bug.cgi?id=179873
1702
1703         Reviewed by Simon Fraser.
1704
1705         * Configurations/FeatureDefines.xcconfig:
1706
1707 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1708
1709         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1710         https://bugs.webkit.org/show_bug.cgi?id=179872
1711
1712         Reviewed by Darin Adler.
1713
1714         * Configurations/FeatureDefines.xcconfig:
1715
1716 2017-11-16  Daniel Bates  <dabates@apple.com>
1717
1718         Add feature define for alternative presentation button element
1719         https://bugs.webkit.org/show_bug.cgi?id=179692
1720         Part of <rdar://problem/34917108>
1721
1722         Reviewed by Andy Estes.
1723
1724         Only enabled on Cocoa platforms by default.
1725
1726         * Configurations/FeatureDefines.xcconfig:
1727
1728 2017-11-14  Nan Wang  <n_wang@apple.com>
1729
1730         AX: AOM: Implement AccessibleNode class and support label and role attributes
1731         https://bugs.webkit.org/show_bug.cgi?id=179494
1732
1733         Reviewed by Ryosuke Niwa.
1734
1735         * WebView/WebPreferenceKeysPrivate.h:
1736         * WebView/WebPreferences.mm:
1737         (+[WebPreferences initialize]):
1738         (-[WebPreferences accessibilityObjectModelEnabled]):
1739         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1740         * WebView/WebPreferencesPrivate.h:
1741         * WebView/WebView.mm:
1742         (-[WebView _preferencesChanged:]):
1743
1744 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1745
1746         Remove Cocoa CFURLConnection loading code
1747         https://bugs.webkit.org/show_bug.cgi?id=179688
1748
1749         Reviewed by Antti Koivisto.
1750
1751         * Misc/WebDownload.mm:
1752         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1753         * Misc/WebDownloadInternal.h:
1754         * Plugins/WebBaseNetscapePluginView.mm:
1755         * WebCoreSupport/WebFrameLoaderClient.mm:
1756         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1757         * WebView/WebView.mm:
1758         (-[WebView scheduleInRunLoop:forMode:]):
1759         (-[WebView unscheduleFromRunLoop:forMode:]):
1760
1761 2017-11-14  Daniel Bates  <dabates@apple.com>
1762
1763         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1764         for feature defines
1765
1766         Following r195498 and r201917 the Visual Studio property files for feature defines have
1767         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1768         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1769         files.
1770
1771         * Configurations/FeatureDefines.xcconfig:
1772
1773 2017-11-14  Jer Noble  <jer.noble@apple.com>
1774
1775         Enable Modern EME tests in DumpRenderTree
1776         https://bugs.webkit.org/show_bug.cgi?id=179544
1777
1778         Reviewed by Alex Christensen.
1779
1780         Add a WebPreferences property to enable the (modern) EME API.
1781
1782         * WebView/WebPreferenceKeysPrivate.h:
1783         * WebView/WebPreferences.mm:
1784         (+[WebPreferences initialize]):
1785         (-[WebPreferences encryptedMediaAPIEnabled]):
1786         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1787         * WebView/WebPreferencesPrivate.h:
1788         * WebView/WebView.mm:
1789         (-[WebView _preferencesChanged:]):
1790
1791 2017-11-14  Antti Koivisto  <antti@apple.com>
1792
1793         Enable display:contents by default
1794         https://bugs.webkit.org/show_bug.cgi?id=179655
1795
1796         Reviewed by Sam Weinig.
1797
1798         * WebView/WebPreferences.mm:
1799         (+[WebPreferences initialize]):
1800
1801 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1802
1803         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1804         https://bugs.webkit.org/show_bug.cgi?id=178751
1805
1806         Reviewed by Brady Eidson.
1807
1808         * WebCoreSupport/WebFrameNetworkingContext.mm:
1809         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1810
1811 2017-11-08  Keith Miller  <keith_miller@apple.com>
1812
1813         Async iteration should only fetch the next method once and add feature flag
1814         https://bugs.webkit.org/show_bug.cgi?id=179451
1815
1816         Reviewed by Geoffrey Garen.
1817
1818         Add feature flag for Async iteration.
1819
1820         * Configurations/FeatureDefines.xcconfig:
1821
1822 2017-11-13  Mark Lam  <mark.lam@apple.com>
1823
1824         Add more overflow check book-keeping for MarkedArgumentBuffer.
1825         https://bugs.webkit.org/show_bug.cgi?id=179634
1826         <rdar://problem/35492517>
1827
1828         Reviewed by Saam Barati.
1829
1830         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1831         (WebKit::NetscapePluginInstanceProxy::invoke):
1832         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1833         (WebKit::NetscapePluginInstanceProxy::construct):
1834
1835 2017-11-12  Darin Adler  <darin@apple.com>
1836
1837         More is<> and downcast<>, less static_cast<>
1838         https://bugs.webkit.org/show_bug.cgi?id=179600
1839
1840         Reviewed by Chris Dumez.
1841
1842         * DOM/DOM.mm:
1843         (kit): Use is/downcast.
1844         * WebCoreSupport/WebEditorClient.mm:
1845         (WebEditorClient::handleKeyboardEvent): Ditto.
1846         (WebEditorClient::handleInputMethodKeydown): Ditto.
1847         * WebView/WebHTMLView.mm:
1848         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1849
1850 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1851
1852         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1853         https://bugs.webkit.org/show_bug.cgi?id=179397
1854
1855         Reviewed by Wenson Hsieh.
1856
1857         * DOM/DOMHTMLInputElement.mm:
1858         (-[DOMHTMLInputElement insertTextSuggestion:]):
1859
1860 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1861
1862         HTMLMediaElement should not use element fullscreen on iOS
1863         https://bugs.webkit.org/show_bug.cgi?id=179418
1864         rdar://problem/35409277
1865
1866         Reviewed by Eric Carlson.
1867
1868         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1869
1870         * Configurations/FeatureDefines.xcconfig:
1871
1872 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1873
1874         Make ResourceLoader::willSendRequestInternal asynchronous
1875         https://bugs.webkit.org/show_bug.cgi?id=179251
1876
1877         Reviewed by Andy Estes.
1878
1879         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1880         (WebKit::HostedNetscapePluginStream::start):
1881         * Plugins/WebNetscapePluginStream.mm:
1882         (WebNetscapePluginStream::start):
1883
1884 2017-11-01  Darin Adler  <darin@apple.com>
1885
1886         Simplify event dispatch code and make it a bit more consistent
1887         https://bugs.webkit.org/show_bug.cgi?id=178991
1888
1889         Reviewed by Chris Dumez.
1890
1891         * DOM/DOMEvent.mm:
1892         (-[DOMEvent srcElement]): Call target instead of srcElement.
1893
1894 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1895
1896         [Touch Bar Web API] Add support for menuitem tag
1897         https://bugs.webkit.org/show_bug.cgi?id=179020
1898
1899         Reviewed by Ryosuke Niwa.
1900
1901         Adds in properties and methods that allow the menuitem runtime feature
1902         to be enabled or disabled.
1903
1904         * WebView/WebPreferenceKeysPrivate.h:
1905         * WebView/WebPreferences.mm:
1906         (-[WebPreferences menuItemElementEnabled]):
1907         (-[WebPreferences setMenuItemElementEnabled:]):
1908         * WebView/WebPreferencesPrivate.h:
1909         * WebView/WebView.mm:
1910         (-[WebView _preferencesChanged:]):
1911
1912 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1913
1914         Use CompletionHandlers for redirects
1915         https://bugs.webkit.org/show_bug.cgi?id=179163
1916
1917         Reviewed by Tim Horton.
1918
1919         * Plugins/Hosted/HostedNetscapePluginStream.h:
1920         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1921         (WebKit::HostedNetscapePluginStream::willSendRequest):
1922         * Plugins/WebNetscapePluginStream.h:
1923         * Plugins/WebNetscapePluginStream.mm:
1924         (WebNetscapePluginStream::willSendRequest):
1925
1926 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1927
1928         Add a FileSystem namespace to FileSystem.cpp
1929         https://bugs.webkit.org/show_bug.cgi?id=179063
1930
1931         Reviewed by Darin Adler.
1932
1933         * Misc/WebNSFileManagerExtras.mm:
1934         * Storage/WebDatabaseProvider.mm:
1935
1936 2017-11-02  Frederic Wang  <fwang@igalia.com>
1937
1938         Add references to bug 179167 in FIXME comments
1939         https://bugs.webkit.org/show_bug.cgi?id=179168
1940
1941         Reviewed by Daniel Bates.
1942
1943         * Configurations/FeatureDefines.xcconfig:
1944
1945 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1946
1947         Implement WKFullscreenWindowController for iOS.
1948         https://bugs.webkit.org/show_bug.cgi?id=178924
1949         rdar://problem/34697120
1950
1951         Reviewed by Simon Fraser.
1952
1953         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1954
1955         * Configurations/FeatureDefines.xcconfig:
1956         * WebView/WebView.mm:
1957         (-[WebView fullScreenPlaceholderView]):
1958
1959 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1960
1961         Clean up some drag and drop feature flags
1962         https://bugs.webkit.org/show_bug.cgi?id=179082
1963
1964         Reviewed by Simon Fraser.
1965
1966         * Configurations/FeatureDefines.xcconfig:
1967
1968 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1969
1970         Make it possible to test rubber-banding in overflow scroll
1971         https://bugs.webkit.org/show_bug.cgi?id=179078
1972
1973         Reviewed by Sam Weinig.
1974
1975         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1976         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1977
1978         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1979         functions, since most callers want clamped.
1980
1981         * DOM/DOMHTML.mm:
1982         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1983
1984 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1985
1986         Fix up some content filtering feature flags
1987         https://bugs.webkit.org/show_bug.cgi?id=179079
1988
1989         Reviewed by Simon Fraser.
1990
1991         * Configurations/FeatureDefines.xcconfig:
1992
1993 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1994
1995         [FrameView::layout cleanup] Move core layout logic to a separate class.
1996         https://bugs.webkit.org/show_bug.cgi?id=178771
1997         <rdar://problem/35166542>
1998
1999         Reviewed by Simon Fraser.
2000
2001         Move layout code out from FrameView to LayoutContext.
2002
2003         * WebView/WebClipView.mm:
2004         (-[WebClipView _immediateScrollToPoint:]):
2005         * WebView/WebFrame.mm:
2006         (-[WebFrame layoutCount]):
2007
2008 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2009
2010         Fix issues with WebView subframe painting
2011         https://bugs.webkit.org/show_bug.cgi?id=178842
2012         rdar://problem/34072253
2013
2014         Reviewed by Daniel Bates.
2015         
2016         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2017         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2018         High Sierra, so match the new signature.
2019
2020         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2021
2022         * WebView/WebHTMLView.mm:
2023         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2024         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2025
2026 2017-10-25  Youenn Fablet  <youenn@apple.com>
2027
2028         Enable ServiceWorker to fetch resources
2029         https://bugs.webkit.org/show_bug.cgi?id=178673
2030
2031         Reviewed by Brady Eidson.
2032
2033         * WebCoreSupport/WebFrameLoaderClient.mm:
2034         (WebFrameLoaderClient::pageID const):
2035         (WebFrameLoaderClient::frameID const):
2036         (WebFrameLoaderClient::sessionID const):
2037
2038         Added implementation to the new getters.
2039         They are noop in the context of WK1.
2040
2041 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2042
2043         Web Inspector: Enable WebKit logging configuration and display
2044         https://bugs.webkit.org/show_bug.cgi?id=177027
2045         <rdar://problem/33964767>
2046
2047         Reviewed by Joseph Pecoraro.
2048
2049         * WebCoreSupport/WebChromeClient.mm:
2050         (stringForMessageSource): Deal with Media and WebRTC message sources.
2051
2052 2017-10-20  Antoine Quint  <graouts@apple.com>
2053
2054         [Web Animations] Provide basic timeline and animation interfaces
2055         https://bugs.webkit.org/show_bug.cgi?id=178526
2056
2057         Reviewed by Dean Jackson.
2058
2059         Remove the WEB_ANIMATIONS compile-time flag.
2060
2061         * Configurations/FeatureDefines.xcconfig:
2062         * WebView/WebPreferences.mm:
2063         (+[WebPreferences initialize]):
2064         * WebView/WebView.mm:
2065         (-[WebView _preferencesChanged:]):
2066
2067 2017-10-19  Sam Weinig  <sam@webkit.org>
2068
2069         [Settings] Move global settings into their own file
2070         https://bugs.webkit.org/show_bug.cgi?id=178512
2071
2072         Reviewed by Darin Adler.
2073
2074         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2075
2076         * WebCoreSupport/WebChromeClient.mm:
2077         (WebChromeClient::supportsVideoFullscreen):
2078         * WebView/WebDynamicScrollBarsView.mm:
2079         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2080         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2081         * WebView/WebPreferences.mm:
2082         (+[WebPreferences initialize]):
2083         * WebView/WebView.mm:
2084         (-[WebView _commonInitializationWithFrameName:groupName:]):
2085         (-[WebView _preferencesChanged:]):
2086         (+[WebView _doNotStartObservingNetworkReachability]):
2087
2088 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2089
2090         Replace some stack raw pointers with RefPtrs within WebCore/html
2091         https://bugs.webkit.org/show_bug.cgi?id=178201
2092         <rdar://problem/34841692>
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         * DOM/DOM.mm:
2097         (kit):
2098         Change the type of node as toNode() is changed to return RefPtr.
2099
2100 2017-10-18  Chris Dumez  <cdumez@apple.com>
2101
2102         [Service Worker] Add stubs for Client / WindowClient / Clients
2103         https://bugs.webkit.org/show_bug.cgi?id=178469
2104
2105         Reviewed by Youenn Fablet.
2106
2107         Rename PageVisiblityState to VisibilityState.
2108
2109         * WebView/WebView.mm:
2110         (kit):
2111
2112 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2113
2114         Unreviewed, rolling out r223291.
2115
2116         See WebCore ChangeLog for more detail.
2117
2118         Reverted changeset:
2119
2120         "Remove Editor::simplifyMarkup"
2121         https://bugs.webkit.org/show_bug.cgi?id=178271
2122         https://trac.webkit.org/changeset/223291
2123
2124 2017-10-17  Keith Miller  <keith_miller@apple.com>
2125
2126         Change WebCore sources to work with unified source builds
2127         https://bugs.webkit.org/show_bug.cgi?id=178229
2128
2129         Rubber stamped by Tim Horton.
2130
2131         * Configurations/FeatureDefines.xcconfig:
2132
2133 2017-10-16  Sam Weinig  <sam@webkit.org>
2134
2135         [Settings] Remove all custom code from Settings.h/cpp
2136         https://bugs.webkit.org/show_bug.cgi?id=178330
2137
2138         Reviewed by Simon Fraser.
2139
2140         * WebView/WebPreferences.mm:
2141         (+[WebPreferences initialize]):
2142         
2143             Update for naming changes of FrameFlattening now that it is an enum class.
2144
2145 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2146
2147         Remove Editor::simplifyMarkup
2148         https://bugs.webkit.org/show_bug.cgi?id=178271
2149
2150         Reviewed by Wenson Hsieh.
2151
2152         * WebView/WebView.mm:
2153         (-[WebView _simplifyMarkup:endNode:]):
2154
2155 2017-10-12  Chris Dumez  <cdumez@apple.com>
2156
2157         [Mac] Add support for MouseEvent.buttons
2158         https://bugs.webkit.org/show_bug.cgi?id=178214
2159
2160         Reviewed by Ryosuke Niwa.
2161
2162         * WebView/WebPDFView.mm:
2163         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2164
2165 2017-10-11  Sam Weinig  <sam@webkit.org>
2166
2167         Remove out-parameter variants of copyToVector
2168         https://bugs.webkit.org/show_bug.cgi?id=178155
2169
2170         Reviewed by Tim Horton.
2171
2172         * Plugins/WebNetscapePluginView.mm:
2173         (-[WebNetscapePluginView destroyPlugin]):
2174         * WebView/WebHTMLRepresentation.mm:
2175         (newArrayWithStrings):
2176
2177             Replace out-parameter based copyToVector, with one that returns a Vector.
2178
2179 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2180
2181         Sanitize URL in pasteboard for other applications and cross origin content
2182         https://bugs.webkit.org/show_bug.cgi?id=178060
2183         <rdar://problem/34874518>
2184
2185         Reviewed by Wenson Hsieh.
2186
2187         * WebCoreSupport/WebPlatformStrategies.h:
2188         * WebCoreSupport/WebPlatformStrategies.mm:
2189         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2190
2191 2017-10-11  Chris Dumez  <cdumez@apple.com>
2192
2193         Modernize Geolocation code
2194         https://bugs.webkit.org/show_bug.cgi?id=178148
2195
2196         Reviewed by Ryosuke Niwa.
2197
2198         * WebCoreSupport/WebGeolocationClient.h:
2199         * WebCoreSupport/WebGeolocationClient.mm:
2200         (WebGeolocationClient::lastPosition):
2201         * WebView/WebGeolocationPosition.mm:
2202         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2203         (core):
2204         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2205         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2206         * WebView/WebGeolocationPositionInternal.h:
2207
2208 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2209
2210         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2211         https://bugs.webkit.org/show_bug.cgi?id=178154
2212
2213         Reviewed by Wenson Hsieh.
2214
2215         Enable custom pasteboard data by default.
2216
2217         * WebView/WebPreferenceKeysPrivate.h:
2218         * WebView/WebPreferences.mm:
2219         (+[WebPreferences initialize]):
2220         (-[WebPreferences customPasteboardDataEnabled]): Added.
2221         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2222         * WebView/WebPreferencesPrivate.h:
2223         * WebView/WebView.mm:
2224         (-[WebView _preferencesChanged:]):
2225
2226 2017-10-10  Sam Weinig  <sam@webkit.org>
2227
2228         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2229         https://bugs.webkit.org/show_bug.cgi?id=178102
2230
2231         Reviewed by Tim Horton.
2232
2233         * History/WebHistory.mm:
2234         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2235         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2236         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2237         * WebCoreSupport/WebUserMediaClient.mm:
2238         (WebUserMediaClient::pageDestroyed):
2239
2240 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2241
2242         Make the names of the options consistent
2243         https://bugs.webkit.org/show_bug.cgi?id=177933
2244
2245         Reviewed by Saam Barati.
2246
2247         * WebView/WebFrame.h:
2248         * WebView/WebHTMLView.mm:
2249         (-[WebHTMLView setMarkedText:selectedRange:]):
2250         * WebView/WebView.h:
2251
2252 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2253
2254         [iOS] Tweak support for classifying form controls (followup to r222487)
2255         https://bugs.webkit.org/show_bug.cgi?id=177917
2256         <rdar://problem/34820122>
2257
2258         Reviewed by Dean Jackson.
2259
2260         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2261
2262         * DOM/DOMHTMLInputElement.mm:
2263         (-[DOMHTMLInputElement _autofillContext]):
2264         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2265         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2266
2267 2017-10-05  Keith Miller  <keith_miller@apple.com>
2268
2269         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2270
2271         * Configurations/WebKitLegacy.xcconfig:
2272
2273 2017-10-05  Jer Noble  <jer.noble@apple.com>
2274
2275         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2276         https://bugs.webkit.org/show_bug.cgi?id=177261
2277
2278         Reviewed by Eric Carlson.
2279
2280         * Configurations/FeatureDefines.xcconfig:
2281
2282 2017-10-05  Chris Dumez  <cdumez@apple.com>
2283
2284         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2285         https://bugs.webkit.org/show_bug.cgi?id=177957
2286
2287         Reviewed by Alex Christensen.
2288
2289         * WebCoreSupport/WebPlatformStrategies.h:
2290         * WebCoreSupport/WebPlatformStrategies.mm:
2291         (WebPlatformStrategies::cookiesEnabled):
2292
2293 2017-10-05  Youenn Fablet  <youenn@apple.com>
2294
2295         Make LibWebRTCProvider port agnostic
2296         https://bugs.webkit.org/show_bug.cgi?id=177747
2297
2298         Reviewed by Alex Christensen & Alex Garcia.
2299
2300         * WebView/WebView.mm:
2301         (-[WebView _commonInitializationWithFrameName:groupName:]):
2302         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2303
2304 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2305
2306         Stop linking with WebKitSystemInterface
2307         https://bugs.webkit.org/show_bug.cgi?id=177915
2308
2309         Reviewed by Antti Koivisto.
2310
2311         * Configurations/DebugRelease.xcconfig:
2312         * Configurations/WebKitLegacy.xcconfig:
2313
2314 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2315
2316         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2317         https://bugs.webkit.org/show_bug.cgi?id=177912
2318
2319         Reviewed by Saam Barati.
2320
2321         * Carbon/CarbonUtils.m:
2322         * Carbon/CarbonWindowAdapter.mm:
2323         * Carbon/HIWebView.mm:
2324         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2325         * Misc/WebNSFileManagerExtras.mm:
2326         * Misc/WebNSPasteboardExtras.mm:
2327         * Misc/WebNSURLExtras.mm:
2328         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2329         * Plugins/Hosted/NetscapePluginHostManager.mm:
2330         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2331         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2332         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2333         * Plugins/Hosted/WebTextInputWindowController.m:
2334         * Plugins/WebBaseNetscapePluginView.mm:
2335         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2336         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2337         * Plugins/WebNetscapePluginStream.mm:
2338         * Plugins/WebNetscapePluginView.mm:
2339         * Plugins/WebPluginDatabase.mm:
2340         * WebCoreSupport/PopupMenuMac.mm:
2341         * WebCoreSupport/WebChromeClient.mm:
2342         * WebCoreSupport/WebFrameLoaderClient.mm:
2343         * WebCoreSupport/WebInspectorClient.mm:
2344         * WebCoreSupport/WebPlatformStrategies.mm:
2345         * WebCoreSupport/WebSystemInterface.mm:
2346         * WebView/WebDynamicScrollBarsView.mm:
2347         * WebView/WebFrame.mm:
2348         * WebView/WebFrameView.mm:
2349         * WebView/WebFullScreenController.mm:
2350         * WebView/WebHTMLView.mm:
2351         * WebView/WebPreferences.mm:
2352         * WebView/WebView.mm:
2353
2354 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2355
2356         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2357         rdar://problem/34705779
2358
2359         Addressing review comments that I somehow landed without.
2360
2361         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2362
2363 2017-09-29  Chris Dumez  <cdumez@apple.com>
2364
2365         Split some logic out of VisitedLinkStore and make it reusable
2366         https://bugs.webkit.org/show_bug.cgi?id=177575
2367
2368         Reviewed by Alex Christensen.
2369
2370         * WebCoreSupport/WebVisitedLinkStore.h:
2371         * WebCoreSupport/WebVisitedLinkStore.mm:
2372         (WebVisitedLinkStore::addVisitedLink):
2373         (WebVisitedLinkStore::removeVisitedLink):
2374         (WebVisitedLinkStore::isLinkVisited):
2375         (WebVisitedLinkStore::addVisitedLinkHash):
2376
2377 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2378
2379         Build fix for High Sierra 32 bit Mac
2380         https://bugs.webkit.org/show_bug.cgi?id=177551
2381         <rdar://problem/34690283>
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2386         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2387         also made.
2388
2389         * Carbon/CarbonWindowAdapter.mm:
2390         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2391         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2392         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2393         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2394         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2395         (-[CarbonWindowAdapter dealloc]):
2396         (-[CarbonWindowAdapter windowRef]):
2397         (-[CarbonWindowAdapter _hasWindowRef]):
2398         (-[CarbonWindowAdapter _managesWindowRef]):
2399         (-[CarbonWindowAdapter _removeWindowRef]):
2400         (-[CarbonWindowAdapter _carbonWindowClass]):
2401         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2402         (-[CarbonWindowAdapter sendSuperEvent:]):
2403         (-[CarbonWindowAdapter relinquishFocus]):
2404         (-[CarbonWindowAdapter _cancelKey:]):
2405         (-[CarbonWindowAdapter _commonAwake]):
2406         (-[CarbonWindowAdapter _destroyRealWindow:]):
2407         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2408         (-[CarbonWindowAdapter _termWindowIfOwner]):
2409         (-[CarbonWindowAdapter _windowMovedToRect:]):
2410         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2411         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2412         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2413         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2414         (-[CarbonWindowAdapter canBecomeMainWindow]):
2415         (-[CarbonWindowAdapter encodeWithCoder:]):
2416         (-[CarbonWindowAdapter initWithCoder:]):
2417         (-[CarbonWindowAdapter setContentView:]):
2418         (-[CarbonWindowAdapter worksWhenModal]):
2419         (-[CarbonWindowAdapter _setModalWindowLevel]):
2420         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2421         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2422         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2423         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2424         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2425         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2426         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2427         (NSCarbonWindowHandleEvent):
2428         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2429         (-[CarbonWindowAdapter _growBoxRect]):
2430         * Carbon/HIWebView.mm:
2431         (HIWebViewGetWebView):
2432         (HIWebViewConstructor):
2433         (HIWebViewDestructor):
2434         (HIWebViewRegisterClass):
2435         (GetBehaviors):
2436         (Draw):
2437         (HitTest):
2438         (GetRegion):
2439         (GetWindowRef):
2440         (CreateNSEventAdoptingCGEvent):
2441         (CopyEventCGEvent):
2442         (CreateNSEventWithCarbonClickEvent):
2443         (Click):
2444         (CreateNSEventWithCarbonEvent):
2445         (MouseUp):
2446         (CreateNSEventWithCarbonMouseMoveEvent):
2447         (MouseMoved):
2448         (MouseDragged):
2449         (MouseWheelMoved):
2450         (ContextMenuClick):
2451         (GetKind):
2452         (BoundsChanged):
2453         (OwningWindowChanged):
2454         (WindowHandler):
2455         (SyncFrame):
2456         (SetFocusPart):
2457         (AdvanceFocus):
2458         (RelinquishFocus):
2459         (ActiveStateChanged):
2460         (ProcessCommand):
2461         (UpdateCommandStatus):
2462         (_NSSelectorForHICommand):
2463         (HIWebViewEventHandler):
2464         (StartUpdateObserver):
2465         (StopUpdateObserver):
2466         (UpdateObserver):
2467
2468 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2469
2470         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2471         https://bugs.webkit.org/show_bug.cgi?id=172526
2472         <rdar://problem/32396081>
2473
2474         Reviewed by Ryosuke Niwa.
2475
2476         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2477
2478         * WebCoreSupport/WebPlatformStrategies.h:
2479         * WebCoreSupport/WebPlatformStrategies.mm:
2480         (WebPlatformStrategies::webExposedTypes):
2481         (WebPlatformStrategies::writeCustomData):
2482
2483 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2484
2485         Unreviewed, rolling out r222567.
2486
2487         This broke and internal build.
2488
2489         Reverted changeset:
2490
2491         "Build fix for High Sierra 32 bit Mac"
2492         https://bugs.webkit.org/show_bug.cgi?id=177551
2493         http://trac.webkit.org/changeset/222567
2494
2495 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2496
2497         Build fix for High Sierra 32 bit Mac
2498         https://bugs.webkit.org/show_bug.cgi?id=177551
2499         <rdar://problem/34690283>
2500
2501         Reviewed by Alexey Proskuryakov.
2502
2503         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2504         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2505         also made.
2506
2507         * Carbon/CarbonWindowAdapter.mm:
2508         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2509         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2510         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2511         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2512         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2513         (-[CarbonWindowAdapter dealloc]):
2514         (-[CarbonWindowAdapter windowRef]):
2515         (-[CarbonWindowAdapter _hasWindowRef]):
2516         (-[CarbonWindowAdapter _managesWindowRef]):
2517         (-[CarbonWindowAdapter _removeWindowRef]):
2518         (-[CarbonWindowAdapter _carbonWindowClass]):
2519         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2520         (-[CarbonWindowAdapter sendSuperEvent:]):
2521         (-[CarbonWindowAdapter relinquishFocus]):
2522         (-[CarbonWindowAdapter _cancelKey:]):
2523         (-[CarbonWindowAdapter _commonAwake]):
2524         (-[CarbonWindowAdapter _destroyRealWindow:]):
2525         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2526         (-[CarbonWindowAdapter _termWindowIfOwner]):
2527         (-[CarbonWindowAdapter _windowMovedToRect:]):
2528         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2529         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2530         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2531         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2532         (-[CarbonWindowAdapter canBecomeMainWindow]):
2533         (-[CarbonWindowAdapter encodeWithCoder:]):
2534         (-[CarbonWindowAdapter initWithCoder:]):
2535         (-[CarbonWindowAdapter setContentView:]):
2536         (-[CarbonWindowAdapter worksWhenModal]):
2537         (-[CarbonWindowAdapter _setModalWindowLevel]):
2538         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2539         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2540         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2541         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2542         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2543         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2544         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2545         (NSCarbonWindowHandleEvent):
2546         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2547         (-[CarbonWindowAdapter _growBoxRect]):
2548         * Carbon/HIWebView.mm:
2549         (HIWebViewGetWebView):
2550         (HIWebViewConstructor):
2551         (HIWebViewDestructor):
2552         (HIWebViewRegisterClass):
2553         (GetBehaviors):
2554         (Draw):
2555         (HitTest):
2556         (GetRegion):
2557         (GetWindowRef):
2558         (CreateNSEventAdoptingCGEvent):
2559         (CopyEventCGEvent):
2560         (CreateNSEventWithCarbonClickEvent):
2561         (Click):
2562         (CreateNSEventWithCarbonEvent):
2563         (MouseUp):
2564         (CreateNSEventWithCarbonMouseMoveEvent):
2565         (MouseMoved):
2566         (MouseDragged):
2567         (MouseWheelMoved):
2568         (ContextMenuClick):
2569         (GetKind):
2570         (BoundsChanged):
2571         (OwningWindowChanged):
2572         (WindowHandler):
2573         (SyncFrame):
2574         (SetFocusPart):
2575         (AdvanceFocus):
2576         (RelinquishFocus):
2577         (ActiveStateChanged):
2578         (ProcessCommand):
2579         (UpdateCommandStatus):
2580         (_NSSelectorForHICommand):
2581         (HIWebViewEventHandler):
2582         (StartUpdateObserver):
2583         (StopUpdateObserver):
2584         (UpdateObserver):
2585
2586 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2587
2588         Make PolicyAction an encodable enum class
2589         https://bugs.webkit.org/show_bug.cgi?id=177480
2590
2591         Reviewed by Antti Koivisto.
2592
2593         * Plugins/WebPluginContainerCheck.mm:
2594         (-[WebPluginContainerCheck _continueWithPolicy:]):
2595         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2596         * WebCoreSupport/WebFrameLoaderClient.mm:
2597         (-[WebFramePolicyListener invalidate]):
2598         (-[WebFramePolicyListener ignore]):
2599         (-[WebFramePolicyListener download]):
2600         (-[WebFramePolicyListener use]):
2601         (-[WebFramePolicyListener continue]):
2602         * WebView/WebPolicyDelegate.mm:
2603         (-[WebPolicyDecisionListener use]):
2604         (-[WebPolicyDecisionListener ignore]):
2605         (-[WebPolicyDecisionListener download]):
2606
2607 2017-09-25  Frederik Riedel  <riedel@apple.com>
2608
2609         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2610         https://bugs.webkit.org/show_bug.cgi?id=174394
2611         <rdar://problem/33183504>
2612
2613         Reviewed by Ryosuke Niwa.
2614
2615         * DOM/DOMHTMLInputElement.h:
2616         * DOM/DOMHTMLInputElement.mm:
2617         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2618         Determines if this HTMLInputElement is part of a login screen.
2619         (-[DOMHTMLInputElement representingPageUrl]):
2620         Returns the webpage's URL that is currently displayed in the Web View.
2621         (-[DOMHTMLInputElement insertTextSuggestion:]):
2622         Inserts login credentials into the Web View.
2623
2624 2017-09-25  Sam Weinig  <sam@webkit.org>
2625
2626         Remove unused EditorClient functions
2627         https://bugs.webkit.org/show_bug.cgi?id=177463
2628
2629         Reviewed by Alex Christensen.
2630
2631         Remove unused EditorClient functions.
2632
2633         * WebCoreSupport/WebEditorClient.h:
2634         * WebCoreSupport/WebEditorClient.mm:
2635         (WebEditorClient::canonicalizeURL): Deleted.
2636         (WebEditorClient::canonicalizeURLString): Deleted.
2637         (WebEditorClient::writeDataToPasteboard): Deleted.
2638         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2639         (WebEditorClient::readDataFromPasteboard): Deleted.
2640         (WebEditorClient::pasteboardChangeCount): Deleted.
2641
2642 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2643
2644         Stop using PolicyCallback
2645         https://bugs.webkit.org/show_bug.cgi?id=176088
2646
2647         Reviewed by Andy Estes.
2648
2649         * WebCoreSupport/WebFrameLoaderClient.mm:
2650         (-[WebFramePolicyListener invalidate]):
2651         (-[WebFramePolicyListener receivedPolicyDecision:]):
2652
2653 2017-09-25  Sam Weinig  <sam@webkit.org>
2654
2655         Remove unnecessary userVisibleString EditorClient function
2656         https://bugs.webkit.org/show_bug.cgi?id=177456
2657
2658         Reviewed by Dan Bernstein.
2659
2660         * WebCoreSupport/WebEditorClient.h:
2661         * WebCoreSupport/WebEditorClient.mm:
2662         (WebEditorClient::userVisibleString): Deleted.
2663
2664             Remove userVisibleString client function.
2665
2666 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2667
2668         Separate form submission from PolicyChecker infrastructure
2669         https://bugs.webkit.org/show_bug.cgi?id=177396
2670
2671         Reviewed by Geoffrey Garen.
2672
2673         * WebCoreSupport/WebFrameLoaderClient.h:
2674         * WebCoreSupport/WebFrameLoaderClient.mm:
2675         (WebFrameLoaderClient::dispatchWillSubmitForm):
2676
2677 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2678
2679         WeakPtrFactory should populate m_ref lazily.
2680         https://bugs.webkit.org/show_bug.cgi?id=177375
2681
2682         Reviewed by Geoffrey Garen.
2683
2684         * WebCoreSupport/WebEditorClient.mm:
2685         (WebEditorClient::WebEditorClient):
2686         (WebEditorClient::requestCandidatesForSelection):
2687
2688 2017-09-22  Chris Dumez  <cdumez@apple.com>
2689
2690         Use high resolution timestamp for event time
2691         https://bugs.webkit.org/show_bug.cgi?id=154246
2692         <rdar://problem/34333304>
2693
2694         Reviewed by Ryosuke Niwa.
2695
2696         Use WallTime / MonotonicTime instead of double type for clarity.
2697
2698         * DOM/DOMEvent.mm:
2699         (-[DOMEvent timeStamp]):
2700         * WebView/WebFrame.mm:
2701         (-[WebFrame _dragSourceEndedAt:operation:]):
2702         * WebView/WebPDFView.mm:
2703         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2704
2705 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2706
2707         Enable dataTransfer.items on macOS and iOS
2708         https://bugs.webkit.org/show_bug.cgi?id=177335
2709
2710         Reviewed by Sam Weinig.
2711
2712         * WebView/WebPreferences.mm:
2713         (+[WebPreferences initialize]):
2714
2715 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2716
2717         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2718         https://bugs.webkit.org/show_bug.cgi?id=177101
2719         <rdar://problem/34500648>
2720
2721         Reviewed by Brian Burg.
2722
2723         * WebInspector/WebNodeHighlight.mm:
2724         Ensure we close the window that we have just removed.
2725
2726 2017-09-20  Antti Koivisto  <antti@apple.com>
2727
2728         Remove DOM and styling support for CSS Regions
2729         https://bugs.webkit.org/show_bug.cgi?id=177221
2730
2731         Reviewed by Andreas Kling.
2732
2733         * Configurations/FeatureDefines.xcconfig:
2734         * DOM/DOMCSS.mm:
2735         (kitClass):
2736         * DOM/DOMElement.mm:
2737         (-[DOMElement webkitRegionOverset]): Deleted.
2738
2739 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Layering violation in Editor::createFragment
2742         https://bugs.webkit.org/show_bug.cgi?id=176123
2743
2744         Reviewed by Darin Adler.
2745
2746         * Misc/WebNSURLExtras.h:
2747         * Misc/WebNSURLExtras.mm:
2748         * WebView/WebFrame.mm:
2749         * WebView/WebHTMLView.mm:
2750         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2751
2752         * WebCoreSupport/WebEditorClient.mm:
2753         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2754         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2755         way to avoid exporting the symbol just on newer OSes.
2756
2757 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2758
2759         On iOS, getData can't get text set by setData during copy event
2760         https://bugs.webkit.org/show_bug.cgi?id=176980
2761         <rdar://problem/34453915>
2762
2763         Reviewed by Darin Adler.
2764
2765         * WebCoreSupport/WebPlatformStrategies.h:
2766         * WebCoreSupport/WebPlatformStrategies.mm:
2767         (WebPlatformStrategies::copy): Deleted.
2768
2769 2017-09-18  Andy Estes  <aestes@apple.com>
2770
2771         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2772         https://bugs.webkit.org/show_bug.cgi?id=177029
2773
2774         Reviewed by Alex Christensen.
2775
2776         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2777         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2778         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2779         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2780         * WebCoreSupport/PopupMenuMac.mm:
2781         (PopupMenuMac::show):
2782         * WebCoreSupport/WebSystemInterface.mm:
2783         (InitWebCoreSystemInterface):
2784         * WebView/WebHTMLView.mm:
2785         (-[WebHTMLView setDataSource:]):
2786         (-[WebHTMLView attachRootLayer:]):
2787         * WebView/WebView.mm:
2788         (-[WebView _needsAdobeFrameReloadingQuirk]):
2789         (-[WebView _needsLinkElementTextCSSQuirk]):
2790         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2791         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2792         (-[WebView _preferencesChanged:]):
2793
2794 2017-09-15  Andy Estes  <aestes@apple.com>
2795
2796         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2797         https://bugs.webkit.org/show_bug.cgi?id=176953
2798
2799         Reviewed by Eric Carlson.
2800
2801         * WebCoreSupport/WebSystemInterface.mm:
2802         (InitWebCoreSystemInterface):
2803
2804 2017-09-14  Andy Estes  <aestes@apple.com>
2805
2806         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2807         https://bugs.webkit.org/show_bug.cgi?id=176931
2808
2809         Reviewed by Joseph Pecoraro.
2810
2811         * WebCoreSupport/WebSystemInterface.mm:
2812         (InitWebCoreSystemInterface):
2813
2814 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2815
2816         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2817         https://bugs.webkit.org/show_bug.cgi?id=176867
2818
2819         Reviewed by Sam Weinig.
2820
2821         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2822         (WebKit::NetscapePluginInstanceProxy::enumerate):
2823
2824 2017-09-13  Andy Estes  <aestes@apple.com>
2825
2826         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2827         https://bugs.webkit.org/show_bug.cgi?id=176729
2828
2829         Reviewed by Alex Christensen.
2830
2831         * WebCoreSupport/WebSystemInterface.mm:
2832         (InitWebCoreSystemInterface):
2833         * WebView/WebView.mm:
2834         (+[WebView _setCacheModel:]):
2835
2836 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2837
2838         Refactor WebContentReader out of EditorMac and EditorIOS
2839         https://bugs.webkit.org/show_bug.cgi?id=176770
2840
2841         Reviewed by Sam Weinig.
2842
2843         * WebCoreSupport/WebEditorClient.mm:
2844
2845 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2846
2847         Dragging & dropping a file creates an attachment element even when it's disabled
2848         https://bugs.webkit.org/show_bug.cgi?id=176769
2849
2850         Reviewed by Tim Horton.
2851
2852         * WebView/WebView.mm:
2853         (-[WebView _preferencesChanged:]):
2854
2855 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2856
2857         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2858         https://bugs.webkit.org/show_bug.cgi?id=176721
2859         <rdar://problem/34373660>
2860
2861         Reviewed by Tim Horton.
2862
2863         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2864         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2865
2866         * WebView/WebView.mm:
2867         (-[WebView _startDrag:]):
2868         (-[WebView _draggedElementBounds]):
2869         (-[WebView _endedDataInteraction:global:]):
2870         * WebView/WebViewData.h:
2871
2872 2017-09-11  Andy Estes  <aestes@apple.com>
2873
2874         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2875         https://bugs.webkit.org/show_bug.cgi?id=176472
2876
2877         Reviewed by Eric Carlson.
2878
2879         * WebCoreSupport/WebSystemInterface.mm:
2880         (InitWebCoreSystemInterface):
2881
2882 2017-09-09  Mark Lam  <mark.lam@apple.com>
2883
2884         Avoid duplicate computations of ExecState::vm().
2885         https://bugs.webkit.org/show_bug.cgi?id=176647
2886
2887         Reviewed by Saam Barati.
2888
2889         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2890         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2891         (WebKit::NetscapePluginInstanceProxy::construct):
2892         (WebKit::NetscapePluginInstanceProxy::setProperty):
2893         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2894         (WebKit::NetscapePluginInstanceProxy::enumerate):
2895         * Plugins/Hosted/ProxyInstance.mm:
2896         (WebKit::ProxyRuntimeMethod::create):
2897
2898 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2899
2900         Unreviewed, rolling out r221773.
2901         https://bugs.webkit.org/show_bug.cgi?id=176614
2902
2903         This caused build failures. (Requested by mlewis13 on
2904         #webkit).
2905
2906         Reverted changeset:
2907
2908         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2909         https://bugs.webkit.org/show_bug.cgi?id=176472
2910         http://trac.webkit.org/changeset/221773
2911
2912 2017-09-07  Andy Estes  <aestes@apple.com>
2913
2914         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2915         https://bugs.webkit.org/show_bug.cgi?id=176472
2916
2917         Reviewed by Eric Carlson.
2918
2919         * WebCoreSupport/WebSystemInterface.mm:
2920         (InitWebCoreSystemInterface):
2921
2922 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2923
2924         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2925         https://bugs.webkit.org/show_bug.cgi?id=176561
2926
2927         Reviewed by Brent Fulgham.
2928
2929         * Misc/WebNSUserDefaultsExtras.mm:
2930
2931 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2932
2933         Modernize Geolocation code
2934         https://bugs.webkit.org/show_bug.cgi?id=176496
2935
2936         Reviewed by Andy Estes.
2937
2938         * WebCoreSupport/WebGeolocationClient.h:
2939         * WebCoreSupport/WebGeolocationClient.mm:
2940         (WebGeolocationClient::requestPermission):
2941         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2942         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2943         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2944         * WebView/WebView.mm:
2945         (-[WebView _commonInitializationWithFrameName:groupName:]):
2946         (-[WebView _geolocationDidFailWithMessage:]):
2947
2948 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2949
2950         Remove some unused bits of code and resources
2951         https://bugs.webkit.org/show_bug.cgi?id=176275
2952
2953         Reviewed by Dan Bernstein.
2954
2955         * Misc/WebNSFileManagerExtras.mm:
2956         Include FileSystem instead of FileSystemIOS.
2957
2958 2017-09-03  Darin Adler  <darin@apple.com>
2959
2960         [Cocoa] Tidy a few things in legacy WebHTMLView
2961         https://bugs.webkit.org/show_bug.cgi?id=176280
2962
2963         Reviewed by Dan Bernstein.
2964
2965         * WebCoreSupport/WebChromeClient.mm:
2966         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2967         methods it calls on WebHTMLView were doing nothing on iOS.
2968
2969         * WebView/WebFrame.mm:
2970         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2971         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2972
2973         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2974         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2975         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2976         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2977         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2978         Use RetainPtr instead of writing retain/release wherever possible.
2979         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2980         initialization for it. Removed various unused methods and declarations of methods.
2981         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2982         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2983         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2984         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2985         and remove CFRetain no longer needed since we don't support garbage collection any more.
2986         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2987         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2988         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2989         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2990         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2991         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2992         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2993         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2994         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2995         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2996         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2997         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2998         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2999         debug flag; we haven't used it for years and it's not clearly helpful.
3000         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3001         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3002         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3003         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3004         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3005         two additional methods in the WebPrivate category and still be called by the two
3006         methods in the WebInternal category that were already using it.
3007         (-[WebHTMLView didAddSubview:]): Deleted.
3008         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3009         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3010         place this was called, the close method.
3011         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3012         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3013         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3014         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3015         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3016         Added helper method to make the one below simpler.
3017         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3018         Compared pasteboard type strings using isEqualToString: rather than using == since
3019         we want to actually compare the string contents. Also updated to use modern for loop,
3020         renamed a local variable from "s" to "localSubresources", and factored out the handling
3021         of three image types to use the helper method above.
3022         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3023         _web_makePluginSubviewsPerformSelector:withObject: method.
3024         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3025         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3026         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3027         not call the -[NSView subviews] method to make this identical on both platforms and used
3028         a modern for loop.
3029         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3030         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3031         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3032         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3033         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3034         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3035         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3036         of it is Mac-only.
3037         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3038         method did was call itself on the main thread, and do nothing if called on main thread.
3039         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3040         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3041         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3042         half of this method.
3043         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3044         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3045         Simplified using a modern for loop and RetainPtr.
3046         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3047         (-[WebHTMLView keyDown:]): Ditto.
3048         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3049         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3050         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3051         (-[WebHTMLView complete:]): Ditto.
3052         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3053         now macOS-only.
3054         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3055         iOS since that is now macOS-only.
3056         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3057         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3058         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3059         and reorganized to use early return.
3060         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3061         on iOS, but kept there so we don't have to do #if at every call site.
3062         (-[WebHTMLView _pluginController]): Moved into internal category.
3063         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3064         there only for GC, using C++ initialization, removing obsolete comment.
3065         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3066         peculiar iOS-only comment.
3067         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3068
3069         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3070         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3071         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3072         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3073         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3074
3075         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3076         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3077         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3078         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3079         them at this time.
3080
3081 2017-09-03  Sam Weinig  <sam@webkit.org>
3082
3083         Remove CanvasProxy
3084         https://bugs.webkit.org/show_bug.cgi?id=176288
3085
3086         Reviewed by Yusuke Suzuki.
3087
3088         CanvasProxy does not appear to be in any current HTML spec
3089         and was disabled and unimplemented in our tree. Time to 
3090         get rid of it.
3091
3092         * Configurations/FeatureDefines.xcconfig:
3093
3094 2017-09-02  Andy Estes  <aestes@apple.com>
3095
3096         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3097         https://bugs.webkit.org/show_bug.cgi?id=176270
3098
3099         Reviewed by Tim Horton.
3100
3101         * Plugins/Hosted/NetscapePluginHostManager.mm:
3102         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3103         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3104         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3105         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3106         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3107         (WebKit::SoftwareCARenderer::context const):
3108         (WebKit::SoftwareCARenderer::renderContext const):
3109         (WebKit::SoftwareCARenderer::render):
3110         (-[WebHostedNetscapePluginView createPlugin]):
3111         (-[WebHostedNetscapePluginView createPluginLayer]):
3112         (-[WebHostedNetscapePluginView destroyPlugin]):
3113         (-[WebHostedNetscapePluginView drawRect:]):
3114         * WebCoreSupport/WebSystemInterface.mm:
3115         (InitWebCoreSystemInterface):
3116
3117 2017-09-01  Andy Estes  <aestes@apple.com>
3118
3119         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3120         https://bugs.webkit.org/show_bug.cgi?id=176200
3121
3122         Reviewed by Tim Horton.
3123
3124         * Carbon/HIWebView.mm:
3125         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3126         (overrideCGContext):
3127         (restoreCGContext):
3128         (Draw):
3129         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3130         (+[WebHostedNetscapePluginView initialize]):
3131         * Plugins/WebBaseNetscapePluginView.h:
3132         * Plugins/WebBaseNetscapePluginView.mm:
3133         (WebKit::sendUserChangeNotifications):
3134         * Plugins/WebNetscapePluginView.mm:
3135         (+[WebNetscapePluginView initialize]):
3136         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3137         * WebCoreSupport/WebSystemInterface.mm:
3138         (InitWebCoreSystemInterface):
3139         * WebView/WebFrame.mm:
3140         (-[WebFrame _paintBehaviorForDestinationContext:]):
3141         * WebView/WebFullScreenController.mm:
3142         (setClipRectForWindow):
3143         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3144         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3145         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3146         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3147
3148 2017-08-31  Andy Estes  <aestes@apple.com>
3149
3150         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3151         https://bugs.webkit.org/show_bug.cgi?id=176175
3152
3153         Reviewed by Brady Eidson.
3154
3155         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3156         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3157         * Plugins/Hosted/WebTextInputWindowController.m:
3158         (-[WebTextInputPanel init]):
3159         * WebCoreSupport/WebSystemInterface.mm:
3160         (InitWebCoreSystemInterface):
3161         * WebView/WebDynamicScrollBarsView.mm:
3162         (-[WebDynamicScrollBarsView scrollWheel:]):
3163         * WebView/WebHTMLView.mm:
3164         (-[WebHTMLView _removeWindowObservers]):
3165         (-[WebHTMLView addWindowObservers]):
3166         * WebView/WebView.mm:
3167         (-[WebView addWindowObserversForWindow:]):
3168         (-[WebView removeWindowObservers]):
3169         (-[WebView viewWillMoveToWindow:]):
3170
3171 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3172
3173         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3174         https://bugs.webkit.org/show_bug.cgi?id=175779
3175         <rdar://problem/22367975>
3176
3177         Reviewed by Tim Horton.
3178
3179         * WebCoreSupport/WebFrameLoaderClient.h:
3180         * WebCoreSupport/WebFrameLoaderClient.mm:
3181         (WebFrameLoaderClient::webGLPolicyForURL const):
3182         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3183
3184 2017-08-30  Andy Estes  <aestes@apple.com>
3185
3186         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3187         https://bugs.webkit.org/show_bug.cgi?id=176093
3188
3189         Reviewed by Eric Carlson.
3190
3191         * WebCoreSupport/WebSystemInterface.mm:
3192         (InitWebCoreSystemInterface):
3193
3194 2017-08-30  Andy Estes  <aestes@apple.com>
3195
3196         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3197         https://bugs.webkit.org/show_bug.cgi?id=176087
3198
3199         Reviewed by Alex Christensen.
3200
3201         * Carbon/CarbonUtils.m:
3202         (getNSAutoreleasePoolCount):
3203         (WebInitForCarbon):
3204         (PoolCleaner):
3205         * Carbon/CarbonWindowAdapter.mm:
3206         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3207         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3208         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3209         (-[CarbonWindowAdapter _windowMovedToRect:]):
3210         * Carbon/HIViewAdapter.m:
3211         * Carbon/HIWebView.mm:
3212         (Draw):
3213         (CreateNSEventAdoptingCGEvent):
3214         (CopyEventCGEvent):
3215         (CreateNSEventWithCarbonClickEvent):
3216         (Click):
3217         (CreateNSEventWithCarbonEvent):
3218         (MouseUp):
3219         (CreateNSEventWithCarbonMouseMoveEvent):
3220         (MouseMoved):
3221         (MouseDragged):
3222         (MouseWheelMoved):
3223         (WindowHandler):
3224         (HIWebViewEventHandler):
3225         * Misc/QuickDrawCompatibility.h: Removed.
3226         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3227         (getCarbonEvent):
3228         (WebNetscapePluginEventHandlerCarbon::keyDown):
3229         (WebNetscapePluginEventHandlerCarbon::keyUp):
3230         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3231         (WebNetscapePluginEventHandlerCocoa::keyDown):
3232         * Plugins/WebNetscapePluginView.mm:
3233         (-[WebNetscapePluginView tellQuickTimeToChill]):
3234
3235 2017-08-29  Andy Estes  <aestes@apple.com>
3236
3237         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3238         https://bugs.webkit.org/show_bug.cgi?id=176046
3239
3240         Reviewed by Alex Christensen.
3241
3242         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3243         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3244
3245         * Misc/WebNSFileManagerExtras.mm:
3246         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3247         (setMetaData): Deleted.
3248         * WebCoreSupport/WebSystemInterface.mm:
3249         (InitWebCoreSystemInterface):
3250
3251 2017-08-28  Andy Estes  <aestes@apple.com>
3252
3253         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3254         https://bugs.webkit.org/show_bug.cgi?id=176039
3255
3256         Reviewed by Alex Christensen.
3257
3258         * WebCoreSupport/WebSystemInterface.mm:
3259         (InitWebCoreSystemInterface):
3260         * WebView/WebPreferences.mm:
3261         (+[WebPreferences _systemCFStringEncoding]):
3262
3263 2017-08-28  Andy Estes  <aestes@apple.com>
3264
3265         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3266         https://bugs.webkit.org/show_bug.cgi?id=176032
3267
3268         Reviewed by Alex Christensen.
3269
3270         * WebCoreSupport/WebSystemInterface.mm:
3271         (InitWebCoreSystemInterface):
3272         * WebView/WebView.mm:
3273         (-[WebView _cachedResponseForURL:]):
3274
3275 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3276
3277         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3278         https://bugs.webkit.org/show_bug.cgi?id=175992
3279         <rdar://problem/34086613>
3280
3281         Reviewed by Daniel Bates.
3282
3283         * WebCoreSupport/WebPlatformStrategies.h:
3284         * WebCoreSupport/WebPlatformStrategies.mm:
3285         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3286         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3287         indicating if secure cookies were accessed.
3288
3289 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3290
3291         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3292         https://bugs.webkit.org/show_bug.cgi?id=170955
3293         <rdar://problem/31697653>
3294
3295         Reviewed by Ryosuke Niwa.
3296
3297         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3298         text is being replaced.
3299
3300         * WebView/WebHTMLView.mm:
3301         (-[WebHTMLView insertText:]):
3302
3303 2017-08-24  Chris Dumez  <cdumez@apple.com>
3304
3305         [Directory Upload] Add basic support for input.webkitdirectory
3306         https://bugs.webkit.org/show_bug.cgi?id=175950
3307         <rdar://problem/33951915>
3308
3309         Reviewed by Geoffrey Garen.
3310
3311         Add private API to toggle Directory Upload support on Mac WebKit1.
3312
3313         * WebView/WebPreferenceKeysPrivate.h:
3314         * WebView/WebPreferences.mm:
3315         (+[WebPreferences initialize]):
3316         (-[WebPreferences setDirectoryUploadEnabled:]):
3317         (-[WebPreferences directoryUploadEnabled]):
3318         * WebView/WebPreferencesPrivate.h:
3319         * WebView/WebView.mm:
3320         (-[WebView _preferencesChanged:]):
3321
3322 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3323
3324         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3325         https://bugs.webkit.org/show_bug.cgi?id=175370
3326         <rdar://problem/33799806>
3327
3328         Reviewed by Ryosuke Niwa.
3329
3330         Adjust WebEditorClient for interface changes.
3331
3332         * WebCoreSupport/WebEditorClient.h:
3333
3334 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3335
3336         Remove ChromeClient::scrollbarsModeDidChange
3337         https://bugs.webkit.org/show_bug.cgi?id=175805
3338
3339         Reviewed by Daniel Bates.
3340
3341         * WebCoreSupport/WebChromeClient.h:
3342
3343 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3344
3345         Remove ChromeClient::hasOpenedPopup
3346         https://bugs.webkit.org/show_bug.cgi?id=175804
3347
3348         Reviewed by Sam Weinig.
3349
3350         * WebCoreSupport/WebChromeClient.h:
3351         * WebCoreSupport/WebChromeClient.mm:
3352         (WebChromeClient::hasOpenedPopup const): Deleted.
3353
3354 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3355
3356         Disable access to secure cookies if an HTTPS site loads mixed content
3357         https://bugs.webkit.org/show_bug.cgi?id=157053
3358         <rdar://problem/11290808>
3359
3360         Reviewed by Dan Bates.
3361
3362         * WebCoreSupport/WebPlatformStrategies.h:
3363         * WebCoreSupport/WebPlatformStrategies.mm:
3364         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3365         indicating whether secure cookies should be included in the response.
3366
3367 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3368
3369         [PAL] Move spi/mac directory into PAL
3370         https://bugs.webkit.org/show_bug.cgi?id=175649
3371
3372         Reviewed by Myles C. Maxfield.
3373
3374         * Misc/WebSharingServicePickerController.h:
3375         * WebCoreSupport/WebContextMenuClient.mm:
3376         * WebCoreSupport/WebEditorClient.mm:
3377         * WebCoreSupport/WebSelectionServiceController.mm:
3378         * WebView/WebHTMLView.mm:
3379         * WebView/WebImmediateActionController.h:
3380         * WebView/WebImmediateActionController.mm:
3381         * WebView/WebView.mm:
3382
3383 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3384
3385         [PAL] Relocate SessionID to root
3386         https://bugs.webkit.org/show_bug.cgi?id=175684
3387
3388         Reviewed by Alex Christensen.
3389
3390         * WebCoreSupport/WebFrameNetworkingContext.mm:
3391
3392 2017-08-17  Andreas Kling  <akling@apple.com>
3393
3394         Disable CSS regions at compile time
3395         https://bugs.webkit.org/show_bug.cgi?id=175630
3396
3397         Reviewed by Antti Koivisto.
3398
3399         * Configurations/FeatureDefines.xcconfig:
3400
3401 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3402
3403         [PAL] Move SessionID into PAL
3404         https://bugs.webkit.org/show_bug.cgi?id=174192
3405
3406         Reviewed by Antti Koivisto.
3407
3408         * Misc/WebCache.mm:
3409         (+[WebCache imageForURL:]):
3410         * WebCoreSupport/WebFrameLoaderClient.h:
3411         * WebCoreSupport/WebFrameLoaderClient.mm:
3412         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3413         * WebCoreSupport/WebFrameNetworkingContext.mm:
3414         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3415         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3416         (WebFrameNetworkingContext::storageSession const):
3417         * WebCoreSupport/WebPlatformStrategies.h:
3418         * WebCoreSupport/WebPlatformStrategies.mm:
3419         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3420         * WebKitPrefix.h:
3421
3422 2017-08-16  Andy Estes  <aestes@apple.com>
3423
3424         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3425         https://bugs.webkit.org/show_bug.cgi?id=175648
3426
3427         Reviewed by Tim Horton.
3428
3429         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3430         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3431         (WebPaymentCoordinatorClient::showPaymentUI):
3432
3433 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3434
3435         [PAL] Move spi/ios and spi/win directories into PAL
3436         https://bugs.webkit.org/show_bug.cgi?id=175171
3437
3438         Reviewed by Antti Koivisto.
3439
3440         * WebCoreSupport/WebFrameLoaderClient.mm:
3441         * WebView/WebView.mm:
3442
3443 2017-08-16  Andy Estes  <aestes@apple.com>
3444
3445         [Payment Request] Add an ENABLE flag and an experimental feature preference
3446         https://bugs.webkit.org/show_bug.cgi?id=175622
3447
3448         Reviewed by Tim Horton.
3449
3450         * Configurations/FeatureDefines.xcconfig:
3451
3452 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3453
3454         [PAL] Move Sleep classes into PAL
3455         https://bugs.webkit.org/show_bug.cgi?id=175456
3456
3457         Reviewed by Ryosuke Niwa.
3458
3459         * WebView/WebFullScreenController.h:
3460
3461 2017-08-15  Youenn Fablet  <youenn@apple.com>
3462
3463         [Cache API] Adding generic support for CacheStorage and Cache methods
3464         https://bugs.webkit.org/show_bug.cgi?id=175455
3465
3466         Reviewed by Chris Dumez.
3467
3468         * WebView/WebView.mm:
3469         (-[WebView _commonInitializationWithFrameName:groupName:]):
3470
3471 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3472
3473         Remove Proximity Events and related code
3474         https://bugs.webkit.org/show_bug.cgi?id=175545
3475
3476         Reviewed by Daniel Bates.
3477
3478         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3479         and other related code.
3480
3481         * Configurations/FeatureDefines.xcconfig:
3482
3483 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3484
3485         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3486         https://bugs.webkit.org/show_bug.cgi?id=175504
3487
3488         Reviewed by Sam Weinig.
3489
3490         * Configurations/FeatureDefines.xcconfig:
3491         * DOM/DOMHTMLFormElement.mm:
3492         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.