9b1bbe03f13443f907b6127a7ca889276890f746
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-09-20  Keith Rollin  <krollin@apple.com>
2
3         Remove some support for < iOS 13
4         https://bugs.webkit.org/show_bug.cgi?id=202032
5         <rdar://problem/55548468>
6
7         Reviewed by Alex Christensen.
8
9         Remove some support for iOS versions less than 13.0.
10
11         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
12         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
13         values >= 130000. This means that expressions like
14         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and
15         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.
16
17         This removal is part of a series of patches effecting the removal of
18         dead code for old versions of iOS. This particular pass involves
19         changes in which Dan Bates was involved. These changes are isolated
20         from other similar changes in order to facilitate the reviewing
21         process.
22
23         * WebView/WebHTMLView.mm:
24         (-[WebHTMLView _handleEditingKeyEvent:]):
25
26 2019-09-18  Jer Noble  <jer.noble@apple.com>
27
28         Add -suspend and -resumeAllMediaPlayback to WebView
29         https://bugs.webkit.org/show_bug.cgi?id=201951
30
31         Reviewed by Eric Carlson.
32
33         * WebView/WebView.mm:
34         (-[WebView suspendAllMediaPlayback]):
35         (-[WebView resumeAllMediaPlayback]):
36         * WebView/WebViewPrivate.h:
37
38 2019-09-18  Chris Dumez  <cdumez@apple.com>
39
40         BlobRegistry no longer needs SessionIDs
41         https://bugs.webkit.org/show_bug.cgi?id=201936
42
43         Reviewed by Geoffrey Garen.
44
45         BlobRegistry no longer needs SessionIDs, now that we have a single session per WebProcess.
46
47         * WebCoreSupport/WebPlatformStrategies.mm:
48
49 2019-09-18  Chris Dumez  <cdumez@apple.com>
50
51         CacheStorageProvider::createCacheStorageConnection() does not need to take in a SessionID
52         https://bugs.webkit.org/show_bug.cgi?id=201920
53
54         Reviewed by Geoffrey Garen.
55
56         CacheStorageProvider::createCacheStorageConnection() does not need to take in a SessionID.
57         This sessionID is no longer used now that we have a session per WebProcess.
58
59         * WebCoreSupport/WebPlatformStrategies.mm:
60
61 2019-09-18  Chris Dumez  <cdumez@apple.com>
62
63         Drop FrameLoaderClient::sessionID()
64         https://bugs.webkit.org/show_bug.cgi?id=201916
65
66         Reviewed by Geoffrey Garen.
67
68         Drop FrameLoaderClient::sessionID(). The Frame can get the sessionID from its page (Which is
69         what the FrameLoaderClient::sessionID() ended up doing) and other call sites at WebKit2 layer
70         can get the sessionID from the WebProcess singleton.
71
72         * WebCoreSupport/WebFrameLoaderClient.h:
73         * WebCoreSupport/WebFrameLoaderClient.mm:
74
75 2019-09-17  Chris Dumez  <cdumez@apple.com>
76
77         Stop calling Page::setSessionID() from WebKit2
78         https://bugs.webkit.org/show_bug.cgi?id=201888
79
80         Reviewed by Alex Christensen.
81
82         Stop calling Page::setSessionID() from WebKit2 since Page's sessionID can never change when
83         using WebKit2 (We process-swap and create a new Page in a new process when changing data
84         store). Instead, we now pass the sessionID ID when constructing the Page, as part of the
85         PageConfiguration structure.
86
87         * WebView/WebView.mm:
88         (-[WebView _commonInitializationWithFrameName:groupName:]):
89
90 2019-09-09  Alex Christensen  <achristensen@webkit.org>
91
92         Disable TLS 1.0 and 1.1 in WebSockets
93         https://bugs.webkit.org/show_bug.cgi?id=201573
94
95         Reviewed by Youenn Fablet.
96
97         * WebView/WebView.mm:
98         (-[WebView _commonInitializationWithFrameName:groupName:]):
99
100 2019-09-06  Alex Christensen  <achristensen@webkit.org>
101
102         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
103         https://bugs.webkit.org/show_bug.cgi?id=201480
104
105         Reviewed by Youenn Fablet.
106
107         * WebView/WebView.mm:
108         (-[WebView _preferencesChanged:]):
109
110 2019-09-06  Rob Buis  <rbuis@igalia.com>
111
112         Add runtime flag for lazy image loading
113         https://bugs.webkit.org/show_bug.cgi?id=199794
114
115         Reviewed by Frédéric Wang.
116
117         Remove parts of r248409 that were meant for WK1 since
118         lazy image loading is WK2 only.
119
120         * WebView/WebPreferenceKeysPrivate.h:
121         * WebView/WebPreferences.mm:
122         (+[WebPreferences initialize]):
123         (-[WebPreferences lazyImageLoadingEnabled]): Deleted.
124         (-[WebPreferences setLazyImageLoadingEnabled:]): Deleted.
125         * WebView/WebPreferencesPrivate.h:
126         * WebView/WebView.mm:
127         (-[WebView _preferencesChanged:]):
128
129 2019-09-04  Alex Christensen  <achristensen@webkit.org>
130
131         Remove unused SPI that accesses MemoryCache directly
132         https://bugs.webkit.org/show_bug.cgi?id=201468
133
134         Reviewed by Tim Horton.
135
136         * Misc/WebCache.h:
137         * Misc/WebCache.mm:
138         (+[WebCache addImageToCache:forURL:]): Deleted.
139         (+[WebCache addImageToCache:forURL:forFrame:]): Deleted.
140         (+[WebCache removeImageFromCacheForURL:]): Deleted.
141         (+[WebCache removeImageFromCacheForURL:forFrame:]): Deleted.
142
143 2019-08-30  Keith Rollin  <krollin@apple.com>
144
145         Remove AppKitCompatibilityDeclarations.h
146         https://bugs.webkit.org/show_bug.cgi?id=201283
147         <rdar://problem/54822042>
148
149         Reviewed by Alexey Proskuryakov.
150
151         The two copies of these files -- on in WTF, one in MiniBrowser -- are
152         empty and can be removed.
153
154         * Misc/WebNSEventExtras.m:
155         * Misc/WebNSViewExtras.m:
156         * WebKitPrefix.h:
157
158 2019-08-30  Keith Rollin  <krollin@apple.com>
159
160         Remove extra braces
161         https://bugs.webkit.org/show_bug.cgi?id=201285
162
163         Reviewed by Alexey Proskuryakov.
164
165         Some code evolved such that there was only a single statement under an
166         'if' statement. The braces surrounding the single-line block can now
167         be removed.
168
169         * WebView/WebView.mm:
170         (-[WebView updateMediaTouchBar]):
171
172 2019-08-29  Keith Rollin  <krollin@apple.com>
173
174         Update .xcconfig symbols to reflect the current set of past and future product versions.
175         https://bugs.webkit.org/show_bug.cgi?id=200720
176         <rdar://problem/54305032>
177
178         Reviewed by Alex Christensen.
179
180         Remove version symbols related to old OS's we no longer support,
181         ensure that version symbols are defined for OS's we do support.
182
183         * Configurations/Base.xcconfig:
184         * Configurations/DebugRelease.xcconfig:
185         * Configurations/Version.xcconfig:
186
187 2019-08-29  Keith Rollin  <krollin@apple.com>
188
189         Remove support for macOS < 10.13 (part 3)
190         https://bugs.webkit.org/show_bug.cgi?id=201224
191         <rdar://problem/54795934>
192
193         Reviewed by Darin Adler.
194
195         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
196         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
197         like _MACOS_SINCE_1013.
198
199         * Configurations/WebKitTargetConditionals.xcconfig:
200
201 2019-08-29  Dean Jackson  <dino@apple.com>
202
203         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
204         https://bugs.webkit.org/show_bug.cgi?id=201200
205
206         Reverting r249211 after Dan Bernstein pointed out it will cause
207         an error with the public iOS 13 SDK.
208
209         * Misc/WebDownload.h:
210
211 2019-08-28  Dean Jackson  <dino@apple.com>
212
213         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
214         https://bugs.webkit.org/show_bug.cgi?id=201200
215
216         Reviewed by Simon Fraser.
217
218         We want to include Foundation/NSURLDownload.h if we're on
219         a newer iOS.
220
221         * Misc/WebDownload.h:
222
223 2019-08-28  Keith Rollin  <krollin@apple.com>
224
225         Remove support for macOS < 10.13 (part 2)
226         https://bugs.webkit.org/show_bug.cgi?id=201197
227         <rdar://problem/54759985>
228
229         Reviewed by Darin Adler.
230
231         Update conditionals that reference WK_MACOS_1013 and suffixes like
232         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
233         later and that these conditionals are always True or False.
234
235         See Bug 200694 for earlier changes in this area.
236
237         * Configurations/FeatureDefines.xcconfig:
238
239 2019-08-27  Mark Lam  <mark.lam@apple.com>
240
241         Refactor to use VM& instead of VM* at as many places as possible.
242         https://bugs.webkit.org/show_bug.cgi?id=201172
243
244         Reviewed by Yusuke Suzuki.
245
246         * DOM/DOM.mm:
247         (+[DOMNode _nodeFromJSWrapper:]):
248         * DOM/DOMUtility.mm:
249         (createDOMWrapper):
250         * Plugins/Hosted/NetscapePluginHostProxy.mm:
251         (identifierFromIdentifierRep):
252         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
253         (WebKit::NetscapePluginInstanceProxy::enumerate):
254         (WebKit::getObjectID):
255         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
256         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
257         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
258         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
259         * Plugins/Hosted/ProxyInstance.mm:
260         (WebKit::ProxyInstance::stringValue const):
261         (WebKit::ProxyInstance::getPropertyNames):
262         * WebView/WebFrame.mm:
263         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
264
265 2019-08-23  Chris Dumez  <cdumez@apple.com>
266
267         [geolocation] Rename interfaces and remove [NoInterfaceObject]
268         https://bugs.webkit.org/show_bug.cgi?id=200885
269
270         Reviewed by Alex Christensen.
271
272         * WebCoreSupport/WebGeolocationClient.h:
273         * WebCoreSupport/WebGeolocationClient.mm:
274         (WebGeolocationClient::lastPosition):
275         * WebView/WebGeolocationPosition.mm:
276         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
277         (core):
278         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
279         (-[WebGeolocationPosition initWithGeolocationPosition:]):
280         * WebView/WebGeolocationPositionInternal.h:
281
282 2019-08-22  Andy Estes  <aestes@apple.com>
283
284         [watchOS] Disable Content Filtering in the simulator build
285         https://bugs.webkit.org/show_bug.cgi?id=201047
286
287         Reviewed by Tim Horton.
288
289         * Configurations/FeatureDefines.xcconfig:
290
291 2019-08-21  Tim Horton  <timothy_horton@apple.com>
292
293         [Mail] Tapping top of message scrolls back to copied text instead of top of the message
294         https://bugs.webkit.org/show_bug.cgi?id=200999
295         <rdar://problem/54564878>
296
297         Reviewed by Wenson Hsieh.
298
299         * WebCoreSupport/WebEditorClient.h:
300         * WebCoreSupport/WebEditorClient.mm:
301         (WebEditorClient::shouldAllowSingleClickToChangeSelection const):
302         Copy the existing behavior from EventHandler.
303         We do not fix the bug in WebKitLegacy for a multitude of reasons, primarily
304         because we do not know of any user impact.
305
306 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
307
308         Put keygen element behind a runtime flag and disable it by default
309         https://bugs.webkit.org/show_bug.cgi?id=200850
310
311         Reviewed by Antti Koivisto.
312
313         * WebView/WebPreferenceKeysPrivate.h:
314         * WebView/WebPreferences.mm:
315         (-[WebPreferences keygenElementEnabled]):
316         (-[WebPreferences setKeygenElementEnabled:]):
317         * WebView/WebPreferencesPrivate.h:
318         * WebView/WebView.mm:
319         (-[WebView _preferencesChanged:]):
320
321 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
322
323         Remove IDB-specific quota
324         https://bugs.webkit.org/show_bug.cgi?id=196545
325         <rdar://problem/54201783>
326
327         Reviewed by Youenn Fablet.
328
329         * Storage/WebDatabaseManager.mm:
330         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
331         * Storage/WebDatabaseManagerPrivate.h:
332
333 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
334
335         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
336         https://bugs.webkit.org/show_bug.cgi?id=200620
337
338         Reviewed by Geoffrey Garen.
339
340         * History/WebHistory.mm:
341         (-[WebHistoryPrivate init]):
342         * History/WebHistoryItem.mm:
343         (-[WebHistoryItem initFromDictionaryRepresentation:]):
344         * Plugins/Hosted/NetscapePluginHostProxy.mm:
345         (WKPCGetScriptableNPObjectReply):
346         (WKPCBooleanReply):
347         (WKPCBooleanAndDataReply):
348         (WKPCInstantiatePluginReply):
349         * Plugins/Hosted/ProxyInstance.mm:
350         (WebKit::ProxyInstance::methodNamed):
351         (WebKit::ProxyInstance::fieldNamed):
352         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
353         (-[WebHostedNetscapePluginView createPlugin]):
354         * Plugins/WebNetscapePluginEventHandler.mm:
355         (WebNetscapePluginEventHandler::create):
356         * Plugins/WebNetscapePluginView.mm:
357         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
358         * Storage/WebDatabaseManagerClient.mm:
359         (DidModifyOriginData::dispatchToMainThread):
360         * WebCoreSupport/WebFrameLoaderClient.mm:
361         (addRedirectURL):
362         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
363         * WebCoreSupport/WebInspectorClient.mm:
364         (WebInspectorClient::openLocalFrontend):
365         * WebView/WebDeviceOrientationProviderMock.mm:
366         * WebView/WebFrame.mm:
367         (-[WebFrame _attachScriptDebugger]):
368         * WebView/WebMediaPlaybackTargetPicker.mm:
369         (WebMediaPlaybackTargetPicker::create):
370         * WebView/WebTextIterator.mm:
371         (-[WebTextIterator initWithRange:]):
372         * WebView/WebView.mm:
373         (-[WebView _injectOutlookQuirksScript]):
374         (-[WebView _commonInitializationWithFrameName:groupName:]):
375         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
376         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
377         (-[WebView _selectionServiceController]):
378         (-[WebView _setTextIndicator:withLifetime:]):
379         * WebView/WebViewData.mm:
380         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
381         (-[WebViewPrivate init]):
382
383 2019-08-17  Darin Adler  <darin@apple.com>
384
385         Tidy up checks to see if a character is in the Latin-1 range by using isLatin1 consistently
386         https://bugs.webkit.org/show_bug.cgi?id=200861
387
388         Reviewed by Ross Kirsling.
389
390         * Misc/WebKitNSStringExtras.mm:
391         (canUseFastRenderer): Use isLatin1.
392
393 2019-08-16  Chris Dumez  <cdumez@apple.com>
394
395         LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted
396         https://bugs.webkit.org/show_bug.cgi?id=200825
397
398         Reviewed by Alex Christensen.
399
400         * Misc/WebKitVersionChecks.h:
401         * Storage/WebStorageManager.mm:
402         (WebKitInitializeStorageIfNecessary):
403
404 2019-08-16  Ryosuke Niwa  <rniwa@webkit.org>
405
406         Split tabIndex computation for DOM and the rest of WebCore
407         https://bugs.webkit.org/show_bug.cgi?id=200806
408
409         Reviewed by Chris Dumez.
410
411         * DOM/DOMHTMLElement.mm:
412         (-[DOMHTMLElement tabIndex]):
413         (-[DOMHTMLElement setTabIndex:]):
414
415 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
416
417         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
418         https://bugs.webkit.org/show_bug.cgi?id=200620
419
420         Reviewed by Geoffrey Garen.
421
422         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
423         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
424         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
425         * Storage/WebDatabaseManagerClient.mm:
426         * WebCoreSupport/WebAlternativeTextClient.h:
427         * WebCoreSupport/WebCachedFramePlatformData.h:
428         * WebCoreSupport/WebChromeClient.h:
429         * WebCoreSupport/WebContextMenuClient.h:
430         * WebCoreSupport/WebDragClient.h:
431         * WebCoreSupport/WebEditorClient.h:
432         * WebCoreSupport/WebGeolocationClient.h:
433         * WebCoreSupport/WebInspectorClient.h:
434         * WebCoreSupport/WebNotificationClient.h:
435         * WebCoreSupport/WebSelectionServiceController.h:
436         * WebView/WebMediaPlaybackTargetPicker.h:
437
438 2019-08-15  Tim Horton  <timothy_horton@apple.com>
439
440         Yellow Lookup highlight gets stuck over Mail messages
441         https://bugs.webkit.org/show_bug.cgi?id=200778
442         <rdar://problem/53868514>
443
444         Reviewed by Wenson Hsieh.
445
446         * WebView/WebView.mm:
447         (-[WebView _showDictionaryLookupPopup:]):
448         Add a dismissal callback so that when Reveal hides the panel, it also
449         dismisses the yellow indicator. This matches the behavior in modern WebKit.
450
451 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
452
453         Some improvements on web storage
454         https://bugs.webkit.org/show_bug.cgi?id=200373
455
456         Reviewed by Geoffrey Garen.
457
458         * WebView/WebView.mm:
459         (-[WebView _preferencesChanged:]): notify storageNamespaceProvider about session change.
460
461 2019-08-15  Youenn Fablet  <youenn@apple.com>
462
463         Always create a Document with a valid SessionID
464         https://bugs.webkit.org/show_bug.cgi?id=200727
465
466         Reviewed by Alex Christensen.
467
468         Implement WebKit1 sessionID getter like done for WebKit2.
469         Either the loader client has a page in which case the page session ID is used
470         or the client has no page, in which case the default session ID is used.
471         This is the same behavior as CachedResourceLoader.
472
473         * WebCoreSupport/WebFrameLoaderClient.mm:
474         (WebFrameLoaderClient::sessionID const):
475
476 2019-08-15  Simon Fraser  <simon.fraser@apple.com>
477
478         Use ObjectIdentifier<FrameIdentifierType> for frameIDs
479         https://bugs.webkit.org/show_bug.cgi?id=199986
480
481         Reviewed by Ryosuke Niwa.
482
483         Use the strongly-typed FrameIdentifier instead of uint64_t as frame identifiers everywhere.
484
485         * WebCoreSupport/WebFrameLoaderClient.h:
486         * WebCoreSupport/WebFrameLoaderClient.mm:
487         (WebFrameLoaderClient::frameID const):
488
489 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
490
491         Unreviewed, rolling out r248526.
492
493         Caused two IndexedDB perf tests to fail
494
495         Reverted changeset:
496
497         "Remove IDB-specific quota"
498         https://bugs.webkit.org/show_bug.cgi?id=196545
499         https://trac.webkit.org/changeset/248526
500
501 2019-08-14  Keith Rollin  <krollin@apple.com>
502
503         Remove support for macOS < 10.13
504         https://bugs.webkit.org/show_bug.cgi?id=200694
505         <rdar://problem/54278851>
506
507         Reviewed by Youenn Fablet.
508
509         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
510         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
511         101300. This means that expressions like
512         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
513         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
514
515         * WebCoreSupport/WebEditorClient.mm:
516         * WebView/PDFViewSPI.h:
517         * WebView/WebHTMLView.mm:
518         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:]):
519         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:]):
520         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
521         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
522         * WebView/WebPreferences.mm:
523         (+[WebPreferences initialize]):
524         * WebView/WebView.mm:
525         (-[WebView performDragOperation:]):
526         (LayerFlushController::flushLayers):
527         (-[WebView updateMediaTouchBar]):
528         * WebView/WebViewData.h:
529
530 2019-08-14  Youenn Fablet  <youenn@apple.com>
531
532         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
533         https://bugs.webkit.org/show_bug.cgi?id=200671
534
535         Reviewed by ALex Christensen.
536
537         * WebCoreSupport/WebPlatformStrategies.mm:
538
539 2019-08-13  Youenn Fablet  <youenn@apple.com>
540
541         Blob registries should be keyed by session IDs
542         https://bugs.webkit.org/show_bug.cgi?id=200567
543
544         Reviewed by Alex Christensen.
545
546         * WebCoreSupport/WebPlatformStrategies.mm:
547         (WebPlatformStrategies::createBlobRegistry):
548         Ignore sessionID parameter for WK1.
549
550 2019-08-12  Chris Dumez  <cdumez@apple.com>
551
552         Add threading assertions to RefCounted
553         https://bugs.webkit.org/show_bug.cgi?id=200507
554
555         Reviewed by Ryosuke Niwa.
556
557         * WebView/WebView.mm:
558         (+[WebView initialize]):
559         Enable new RefCounted threading assertions for WebKitLegacy.
560
561 2019-08-12  Chris Dumez  <cdumez@apple.com>
562
563         Unreviewed, rolling out r248525.
564
565         Revert new threading assertions while I work on fixing the
566         issues they exposed
567
568         Reverted changeset:
569
570         "Add threading assertions to RefCounted"
571         https://bugs.webkit.org/show_bug.cgi?id=200507
572         https://trac.webkit.org/changeset/248525
573
574 2019-08-12  Youenn Fablet  <youenn@apple.com>
575
576         Remove IDB-specific quota
577         https://bugs.webkit.org/show_bug.cgi?id=196545
578
579         Reviewed by Alex Christensen.
580
581         * Storage/WebDatabaseManager.mm:
582         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
583         * Storage/WebDatabaseManagerPrivate.h:
584
585 2019-08-11  Chris Dumez  <cdumez@apple.com>
586
587         Add threading assertions to RefCounted
588         https://bugs.webkit.org/show_bug.cgi?id=200507
589
590         Reviewed by Ryosuke Niwa.
591
592         * WebView/WebView.mm:
593         (+[WebView initialize]):
594         Enable new RefCounted threading assertions for WebKitLegacy.
595
596 2019-08-10  Tim Horton  <timothy_horton@apple.com>
597
598         Remove some more unused 32-bit code
599         https://bugs.webkit.org/show_bug.cgi?id=200607
600
601         Reviewed by Alexey Proskuryakov.
602
603         * Configurations/WebKitLegacy.xcconfig:
604         * Misc/WebSharingServicePickerController.mm:
605         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
606         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
607         (-[WebSharingServicePickerController sharingService:didShareItems:]):
608         * Plugins/WebNetscapePluginEventHandler.mm:
609         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Removed.
610         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Removed.
611         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
612         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
613         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
614         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
615         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
616         (WebNetscapePluginEventHandlerCocoa::keyDown):
617         (WebNetscapePluginEventHandlerCocoa::focusChanged):
618         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
619         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
620         (WebNetscapePluginEventHandlerCocoa::TSMEventHandler): Deleted.
621         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): Deleted.
622         * WebCoreSupport/WebContextMenuClient.mm:
623         (WebContextMenuClient::contextMenuForEvent):
624         * WebView/WebHTMLView.mm:
625         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
626         (-[WebHTMLView pressureChangeWithEvent:]):
627         * WebView/WebView.mm:
628         (LayerFlushController::flushLayers):
629
630 2019-08-08  Rob Buis  <rbuis@igalia.com>
631
632         Add runtime flag for lazy image loading
633         https://bugs.webkit.org/show_bug.cgi?id=199794
634
635         Reviewed by Darin Adler.
636
637         Set lazyImageLoading runtime flag if preference is set.
638
639         * WebView/WebPreferenceKeysPrivate.h:
640         * WebView/WebPreferences.mm:
641         (+[WebPreferences initialize]):
642         (-[WebPreferences lazyImageLoadingEnabled]):
643         (-[WebPreferences setLazyImageLoadingEnabled:]):
644         * WebView/WebPreferencesPrivate.h:
645         * WebView/WebView.mm:
646         (-[WebView _preferencesChanged:]):
647
648 2019-08-07  Priyanka Agarwal  <pagarwal999@apple.com>
649
650         Allow clients to toggle a text input field between being viewable and having characters hidden while maintaining 
651         a yellow auto-filled appearance
652         https://bugs.webkit.org/show_bug.cgi?id=200037
653         rdar://problem/51900961
654
655         Reviewed by Daniel Bates.
656
657         * DOM/WebDOMOperations.mm:
658         (-[DOMHTMLInputElement _isAutoFilledAndViewable]):
659         (-[DOMHTMLInputElement _setAutoFilledAndViewable:]):
660         * DOM/WebDOMOperationsPrivate.h:
661
662 2019-08-02  Keith Rollin  <krollin@apple.com>
663
664         Consistently use Obj-C boolean literals
665         https://bugs.webkit.org/show_bug.cgi?id=200405
666         <rdar://problem/53880043>
667
668         Reviewed by Simon Fraser, Joseph Pecoraro.
669
670         There are places where we use equivalent but different expressions for
671         Obj-C boolean objects. For example, we use both [NSNumber
672         numberWithBool:YES] and @YES. There are places where both are used in
673         the same function, such as -[WebPreferences initialize]. The boolean
674         literal is in greater use and is more succinct, so standardize on
675         that. Also, change @(YES/NO) to @YES/NO.
676
677         * History/WebHistoryItem.mm:
678         * WebView/WebFrame.mm:
679         (-[WebFrame _cacheabilityDictionary]):
680         * WebView/WebPreferences.mm:
681         (+[WebPreferences initialize]):
682
683 2019-08-01  Alex Christensen  <achristensen@webkit.org>
684
685         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
686         https://bugs.webkit.org/show_bug.cgi?id=200102
687         <rdar://problem/53275114>
688
689         Reviewed by Darin Adler.
690
691         * DefaultDelegates/WebDefaultUIDelegate.mm:
692         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): Deleted.
693         (-[WebDefaultUIDelegate webView:generateReplacementFile:]): Deleted.
694         * WebCoreSupport/WebChromeClient.h:
695         * WebCoreSupport/WebChromeClient.mm:
696         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Deleted.
697         (WebChromeClient::generateReplacementFile): Deleted.
698         * WebView/WebUIDelegatePrivate.h:
699
700 2019-07-25  Dean Jackson  <dino@apple.com>
701
702         Add helper for ignoring deprecated implementation warnings
703         https://bugs.webkit.org/show_bug.cgi?id=200135
704
705         Reviewed by Wenson Hsieh.
706
707         Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
708         is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
709
710         * Misc/WebDownload.mm:
711         (-[WebDownload initWithRequest:delegate:]):
712         * Misc/WebIconDatabase.mm:
713         * Plugins/WebBaseNetscapePluginView.mm:
714         (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
715         (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.
716         * WebView/WebDynamicScrollBarsView.mm:
717         (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
718         (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.
719         * WebView/WebHTMLView.mm:
720         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
721         (-[WebHTMLView draggedImage:endedAt:operation:]):
722         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
723         (-[WebHTMLView accessibilityAttributeValue:]):
724         (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
725         (-[WebHTMLView characterIndexForPoint:]):
726         (-[WebHTMLView firstRectForCharacterRange:]):
727         (-[WebHTMLView attributedSubstringFromRange:]):
728         (-[WebHTMLView setMarkedText:selectedRange:]):
729         (-[WebHTMLView doCommandBySelector:]):
730         (-[WebHTMLView insertText:]):
731         (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.
732
733 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
734
735         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
736         https://bugs.webkit.org/show_bug.cgi?id=200021
737         <rdar://problem/53301325>
738
739         Reviewed by Ryosuke Niwa.
740
741         Implement a new editing client hook. In WebKit1, this always returns true on macOS and false on iOS.
742
743         * WebCoreSupport/WebEditorClient.h:
744
745 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
746
747         Fix WebView iframe rendering in macOS Catalina
748         https://bugs.webkit.org/show_bug.cgi?id=200022
749         rdar://problem/49102040
750
751         Reviewed by Darin Adler.
752
753         Adapt to internal NSView method renames in Catalina.
754
755         * WebView/WebHTMLView.mm:
756         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
757         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
758
759 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
760
761         Enable CSSOMViewScrollingAPIEnabled in WebKit1
762         https://bugs.webkit.org/show_bug.cgi?id=200008
763         rdar://problem/53409062
764
765         Reviewed by Tim Horton.
766
767         Default WebKitCSSOMViewScrollingAPIEnabledPreferenceKey to YES, so that 
768         CSSOMViewScrollingAPIEnabled is on for both WebKit1 and WebKit2.
769
770         DumpRenderTree already turns this preference on, so this change is not
771         detected by tests.
772
773         * WebView/WebPreferences.mm:
774         (+[WebPreferences initialize]):
775
776 2019-07-22  Youenn Fablet  <youenn@apple.com>
777
778         Disable MediaRecorder for legacy WebKit
779         https://bugs.webkit.org/show_bug.cgi?id=200001
780         <rdar://problem/53400030>
781
782         Reviewed by Eric Carlson.
783
784         Disable MediaRecorder by default in legacy WebKit.
785         Add SPI to set/get this preference.
786
787         * WebView/WebPreferences.mm:
788         (+[WebPreferences initialize]):
789         (-[WebPreferences _mediaRecorderEnabled]):
790         (-[WebPreferences _setMediaRecorderEnabled:]):
791         * WebView/WebPreferencesPrivate.h:
792
793 2019-07-18  Alex Christensen  <achristensen@webkit.org>
794
795         Unify builds in WebKitLegacy/mac/DOM
796         https://bugs.webkit.org/show_bug.cgi?id=199771
797
798         Reviewed by Geoffrey Garen.
799
800         * DOM/DOMAbstractView.mm:
801         * DOM/DOMAttr.mm:
802         * DOM/DOMBlob.mm:
803         * DOM/DOMCDATASection.mm:
804         * DOM/DOMCSSFontFaceRule.mm:
805         * DOM/DOMCSSImportRule.mm:
806         * DOM/DOMCSSMediaRule.mm:
807         * DOM/DOMCSSPageRule.mm:
808         * DOM/DOMCSSPrimitiveValue.mm:
809         * DOM/DOMCSSRule.mm:
810         * DOM/DOMCSSRuleList.mm:
811         * DOM/DOMCSSStyleDeclaration.mm:
812         * DOM/DOMCSSStyleRule.mm:
813         * DOM/DOMCSSStyleSheet.mm:
814         * DOM/DOMCSSUnknownRule.mm:
815         * DOM/DOMCSSValue.mm:
816         * DOM/DOMCSSValueList.mm:
817         * DOM/DOMCharacterData.mm:
818         * DOM/DOMComment.mm:
819         * DOM/DOMCounter.mm:
820         * DOM/DOMDocument.mm:
821         * DOM/DOMDocumentFragment.mm:
822         * DOM/DOMDocumentType.mm:
823         * DOM/DOMEvent.mm:
824         * DOM/DOMFile.mm:
825         * DOM/DOMFileList.mm:
826         * DOM/DOMHTMLAnchorElement.mm:
827         * DOM/DOMHTMLAppletElement.mm:
828         * DOM/DOMHTMLAreaElement.mm:
829         * DOM/DOMHTMLBRElement.mm:
830         * DOM/DOMHTMLBaseElement.mm:
831         * DOM/DOMHTMLBaseFontElement.mm:
832         * DOM/DOMHTMLBodyElement.mm:
833         * DOM/DOMHTMLButtonElement.mm:
834         * DOM/DOMHTMLCanvasElement.mm:
835         * DOM/DOMHTMLCollection.mm:
836         * DOM/DOMHTMLDListElement.mm:
837         * DOM/DOMHTMLDirectoryElement.mm:
838         * DOM/DOMHTMLDivElement.mm:
839         * DOM/DOMHTMLDocument.mm:
840         * DOM/DOMHTMLElement.mm:
841         * DOM/DOMHTMLEmbedElement.mm:
842         * DOM/DOMHTMLFieldSetElement.mm:
843         * DOM/DOMHTMLFontElement.mm:
844         * DOM/DOMHTMLFormElement.mm:
845         * DOM/DOMHTMLFrameElement.mm:
846         * DOM/DOMHTMLFrameSetElement.mm:
847         * DOM/DOMHTMLHRElement.mm:
848         * DOM/DOMHTMLHeadElement.mm:
849         * DOM/DOMHTMLHeadingElement.mm:
850         * DOM/DOMHTMLHtmlElement.mm:
851         * DOM/DOMHTMLIFrameElement.mm:
852         * DOM/DOMHTMLImageElement.mm:
853         * DOM/DOMHTMLInputElement.mm:
854         * DOM/DOMHTMLLIElement.mm:
855         * DOM/DOMHTMLLabelElement.mm:
856         * DOM/DOMHTMLLegendElement.mm:
857         * DOM/DOMHTMLLinkElement.mm:
858         * DOM/DOMHTMLMapElement.mm:
859         * DOM/DOMHTMLMarqueeElement.mm:
860         * DOM/DOMHTMLMediaElement.mm:
861         * DOM/DOMHTMLMenuElement.mm:
862         * DOM/DOMHTMLMetaElement.mm:
863         * DOM/DOMHTMLModElement.mm:
864         * DOM/DOMHTMLOListElement.mm:
865         * DOM/DOMHTMLObjectElement.mm:
866         * DOM/DOMHTMLOptGroupElement.mm:
867         * DOM/DOMHTMLOptionElement.mm:
868         * DOM/DOMHTMLOptionsCollection.mm:
869         * DOM/DOMHTMLParagraphElement.mm:
870         * DOM/DOMHTMLParamElement.mm:
871         * DOM/DOMHTMLPreElement.mm:
872         * DOM/DOMHTMLQuoteElement.mm:
873         * DOM/DOMHTMLScriptElement.mm:
874         * DOM/DOMHTMLSelectElement.mm:
875         * DOM/DOMHTMLStyleElement.mm:
876         * DOM/DOMHTMLTableCaptionElement.mm:
877         * DOM/DOMHTMLTableCellElement.mm:
878         * DOM/DOMHTMLTableColElement.mm:
879         * DOM/DOMHTMLTableElement.mm:
880         * DOM/DOMHTMLTableRowElement.mm:
881         * DOM/DOMHTMLTableSectionElement.mm:
882         * DOM/DOMHTMLTitleElement.mm:
883         * DOM/DOMHTMLUListElement.mm:
884         * DOM/DOMHTMLVideoElement.mm:
885         * DOM/DOMKeyboardEvent.mm:
886         * DOM/DOMMediaError.mm:
887         * DOM/DOMMediaList.mm:
888         * DOM/DOMMouseEvent.mm:
889         * DOM/DOMMutationEvent.mm:
890         * DOM/DOMNamedNodeMap.mm:
891         * DOM/DOMNodeIterator.mm:
892         * DOM/DOMNodeList.mm:
893         * DOM/DOMOverflowEvent.mm:
894         * DOM/DOMProcessingInstruction.mm:
895         * DOM/DOMProgressEvent.mm:
896         * DOM/DOMRGBColor.mm:
897         * DOM/DOMRange.mm:
898         * DOM/DOMRect.mm:
899         * DOM/DOMStyleSheet.mm:
900         * DOM/DOMStyleSheetList.mm:
901         * DOM/DOMText.mm:
902         * DOM/DOMTextEvent.mm:
903         * DOM/DOMTimeRanges.mm:
904         * DOM/DOMTokenList.mm:
905         * DOM/DOMTreeWalker.mm:
906         * DOM/DOMUIEvent.mm:
907         * DOM/DOMWheelEvent.mm:
908         * DOM/DOMXPath.mm:
909         * DOM/DOMXPathExpression.mm:
910         * DOM/DOMXPathResult.mm:
911
912 2019-07-17  Antoine Quint  <graouts@apple.com>
913
914         Disable Pointer Events prior to watchOS 6
915         https://bugs.webkit.org/show_bug.cgi?id=199890
916         <rdar://problem/53206113>
917
918         Reviewed by Dean Jackson.
919
920         * Configurations/FeatureDefines.xcconfig:
921
922 2019-07-17  Zalan Bujtas  <zalan@apple.com>
923
924         Unable to tap buttons at top of Wells Fargo app’s Payees screen
925         https://bugs.webkit.org/show_bug.cgi?id=199846
926         <rdar://problem/48112220>
927
928         Reviewed by Simon Fraser.
929
930         * WebView/WebFrame.mm:
931         (-[WebFrame approximateNodeAtViewportLocation:]):
932
933 2019-07-17  Alex Christensen  <achristensen@webkit.org>
934
935         Add a runtime-disabled dialog element skeleton
936         https://bugs.webkit.org/show_bug.cgi?id=199839
937
938         Reviewed by Ryosuke Niwa.
939
940         * WebView/WebPreferenceKeysPrivate.h:
941         * WebView/WebPreferences.mm:
942         (+[WebPreferences initialize]):
943         (-[WebPreferences dialogElementEnabled]):
944         (-[WebPreferences setDialogElementEnabled:]):
945         * WebView/WebPreferencesPrivate.h:
946         * WebView/WebView.mm:
947         (-[WebView _preferencesChanged:]):
948         Add SPI to enable the dialog element for tests.
949
950 2019-07-15  Dean Jackson  <dino@apple.com>
951
952         [WebGL] Remove software rendering and simplify context creation on macOS
953         https://bugs.webkit.org/show_bug.cgi?id=199789
954
955         Reviewed by Sam Weinig.
956
957         Remove force software WebGL setting.
958
959         * WebView/WebPreferenceKeysPrivate.h:
960         * WebView/WebPreferences.mm:
961         (+[WebPreferences initialize]):
962         (-[WebPreferences forceSoftwareWebGLRendering]): Deleted.
963         (-[WebPreferences setForceSoftwareWebGLRendering:]): Deleted.
964         * WebView/WebPreferencesPrivate.h:
965         * WebView/WebView.mm:
966         (-[WebView _preferencesChanged:]):
967
968 2019-07-13  Zalan Bujtas  <zalan@apple.com>
969
970         Cannot bring up custom media controls at all on v.youku.com
971         https://bugs.webkit.org/show_bug.cgi?id=199699
972         <rdar://problem/51835327>
973
974         Reviewed by Simon Fraser.
975
976         * WebCoreSupport/WebFrameLoaderClient.mm:
977         (WebFrameLoaderClient::actionDictionary const):
978         * WebView/WebFrame.mm:
979         (-[WebFrame elementAtPoint:]):
980         * WebView/WebHTMLView.mm:
981         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
982         * WebView/WebImmediateActionController.mm:
983         (-[WebImmediateActionController performHitTestAtPoint:]):
984
985 2019-07-12  Alex Christensen  <achristensen@webkit.org>
986
987         Begin unifying WebKitLegacy sources
988         https://bugs.webkit.org/show_bug.cgi?id=199730
989
990         Reviewed by Keith Miller.
991
992         * Configurations/WebKitLegacy.xcconfig:
993
994 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
995
996         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
997         https://bugs.webkit.org/show_bug.cgi?id=199625
998
999         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
1000         with ENABLE(ACCESSIBILITY) in the code.
1001
1002         Additionally, the TestRunner code generator now honors the
1003         Conditional IDL format.
1004
1005         Reviewed by Konstantin Tokarev.
1006
1007         * WebView/WebFrame.mm:
1008         (-[WebFrame setAccessibleName:]):
1009         (-[WebFrame enhancedAccessibilityEnabled]):
1010         (-[WebFrame setEnhancedAccessibility:]):
1011         (-[WebFrame accessibilityRoot]):
1012
1013 2019-07-08  Antoine Quint  <graouts@apple.com>
1014
1015         [Pointer Events] Enable only on the most recent version of the supported iOS family
1016         https://bugs.webkit.org/show_bug.cgi?id=199562
1017         <rdar://problem/52766511>
1018
1019         Reviewed by Dean Jackson.
1020
1021         * Configurations/FeatureDefines.xcconfig:
1022
1023 2019-07-03  Sam Weinig  <weinig@apple.com>
1024
1025         Adopt simple structured bindings in more places
1026         https://bugs.webkit.org/show_bug.cgi?id=199247
1027
1028         Reviewed by Alex Christensen.
1029
1030         Replaces simple uses of std::tie() with structured bindings. Does not touch
1031         uses of std::tie() that are not initial declarations, use std::ignore or in
1032         case where the binding is captured by a lambda, as structured bindings don't
1033         work for those cases yet.
1034
1035         * WebView/WebImmediateActionController.mm:
1036         (-[WebImmediateActionController _animationControllerForText]):
1037
1038 2019-07-02  Devin Rousso  <drousso@apple.com>
1039
1040         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
1041         https://bugs.webkit.org/show_bug.cgi?id=198956
1042
1043         Reviewed by Matt Baker.
1044
1045         * WebCoreSupport/WebInspectorClient.h:
1046         * WebCoreSupport/WebInspectorClient.mm:
1047         (WebInspectorFrontendClient::resetWindowState): Added.
1048
1049 2019-06-28  Timothy Hatcher  <timothy@apple.com>
1050
1051         Rename effectiveAppearanceIsInactive and useInactiveAppearance to better match UIUserInterfaceLevel.
1052         https://bugs.webkit.org/show_bug.cgi?id=199336
1053         rdar://problem/52348938
1054
1055         Reviewed by Tim Horton.
1056
1057         * WebView/WebView.mm:
1058         (-[WebView _commonInitializationWithFrameName:groupName:]):
1059         (-[WebView _setUseDarkAppearance:]):
1060         (-[WebView _useElevatedUserInterfaceLevel]):
1061         (-[WebView _setUseElevatedUserInterfaceLevel:]):
1062         (-[WebView _setUseDarkAppearance:useInactiveAppearance:]):
1063         (-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]):
1064         (-[WebView _effectiveUserInterfaceLevelIsElevated]):
1065         (-[WebView viewDidChangeEffectiveAppearance]):
1066         (-[WebView _useInactiveAppearance]): Deleted.
1067         (-[WebView _setUseInactiveAppearance:]): Deleted.
1068         (-[WebView _effectiveAppearanceIsInactive]): Deleted.
1069         * WebView/WebViewPrivate.h:
1070
1071 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
1072
1073         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
1074         https://bugs.webkit.org/show_bug.cgi?id=199317
1075
1076         Reviewed by Michael Catanzaro.
1077
1078         While IconDatabase and all code using it was removed,
1079         ENABLE_ICONDATABASE still exists as build option and C++ macro.
1080
1081         * Configurations/FeatureDefines.xcconfig:
1082         * WebView/WebView.mm:
1083         (-[WebView _cacheFrameLoadDelegateImplementations]): Use PLATFORM(MAC)
1084         guard instead of ENABLE_ICONDATABASE, because ENABLE_ICONDATABASE was
1085         enabled for macOS only.
1086
1087 2019-06-27  Timothy Hatcher  <timothy@apple.com>
1088
1089         Move WebKitLegacy off of a couple AppKit ivars.
1090         https://bugs.webkit.org/show_bug.cgi?id=199279
1091         rdar://problem/34983438
1092
1093         Reviewed by Tim Horton.
1094
1095         * WebView/WebHTMLView.mm:
1096         (-[NSView _setSubviewsIvar:]): Added. Implement on older systems.
1097         (-[NSView _subviewsIvar]): Added. Ditto.
1098         (needsCursorRectsSupportAtPoint): Use _borderView property.
1099         (-[WebHTMLView _setAsideSubviews]): Use _subviewsIvar property.
1100         (-[NSWindow _web_borderView]): Deleted.
1101
1102 2019-06-27  Beth Dakin  <bdakin@apple.com>
1103
1104         Upstream use of MACCATALYST
1105         https://bugs.webkit.org/show_bug.cgi?id=199245
1106         rdar://problem/51687723
1107
1108         Reviewed by Tim Horton.
1109
1110         * Configurations/Base.xcconfig:
1111         * Configurations/FeatureDefines.xcconfig:
1112         * Configurations/SDKVariant.xcconfig:
1113
1114 2019-06-27  Saam Barati  <sbarati@apple.com>
1115
1116         Make WEBGPU enabled only on Mojave and later.
1117
1118         Rubber-stamped by Myles C. Maxfield.
1119
1120         * Configurations/FeatureDefines.xcconfig:
1121
1122 2019-06-16  Darin Adler  <darin@apple.com>
1123
1124         Rename AtomicString to AtomString
1125         https://bugs.webkit.org/show_bug.cgi?id=195276
1126
1127         Reviewed by Michael Catanzaro.
1128
1129         * many files: Let do-webcore-rename do the renaming.
1130
1131 2019-06-14  Megan Gardner  <megan_gardner@apple.com>
1132
1133         Move Synthetic Editing Commands to behind an experimental feature flag
1134         https://bugs.webkit.org/show_bug.cgi?id=198842
1135         <rdar://problem/50594700>
1136
1137         Reviewed by Simon Fraser.
1138
1139         Add plumbing for synthetic editing command feature flag.
1140
1141         * WebView/WebPreferenceKeysPrivate.h:
1142         * WebView/WebPreferences.mm:
1143         (+[WebPreferences initialize]):
1144         (-[WebPreferences syntheticEditingCommandsEnabled]):
1145         (-[WebPreferences setSyntheticEditingCommandsEnabled:]):
1146         * WebView/WebPreferencesPrivate.h:
1147         * WebView/WebView.mm:
1148         (-[WebView _preferencesChanged:]):
1149
1150 2019-06-13  Antoine Quint  <graouts@apple.com>
1151
1152         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1153         https://bugs.webkit.org/show_bug.cgi?id=198800
1154         <rdar://problem/51679634>
1155
1156         Reviewed by Tim Horton.
1157
1158         Expose a private method that we need to use from DumpRenderTree.
1159
1160         * WebView/WebHTMLView.mm:
1161         (-[WebHTMLView _hitViewForEvent:]):
1162         * WebView/WebHTMLViewPrivate.h:
1163
1164 2019-06-10  Sam Weinig  <weinig@apple.com>
1165
1166         Remove Dashboard support
1167         https://bugs.webkit.org/show_bug.cgi?id=198615
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         Removes implementation, but keeps privatly exported interfaces and enums
1172         around until we can confirm there are no more users of them. 
1173
1174         * Configurations/FeatureDefines.xcconfig:
1175         * Plugins/WebBaseNetscapePluginView.mm:
1176         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1177         * WebCoreSupport/WebChromeClient.h:
1178         * WebCoreSupport/WebChromeClient.mm:
1179         (WebChromeClient::annotatedRegionsChanged): Deleted.
1180         * WebView/WebClipView.mm:
1181         (-[WebClipView _focusRingVisibleRect]):
1182         (-[WebClipView scrollWheel:]):
1183         * WebView/WebDashboardRegion.h:
1184         * WebView/WebDashboardRegion.mm:
1185         * WebView/WebHTMLView.mm:
1186         (-[WebHTMLView _updateMouseoverWithEvent:]):
1187         (-[WebHTMLView acceptsFirstMouse:]):
1188         (-[WebHTMLView setDataSource:]):
1189         * WebView/WebPreferences.mm:
1190         (cacheModelForMainBundle):
1191         * WebView/WebUIDelegatePrivate.h:
1192         * WebView/WebView.mm:
1193         (-[WebView _needsPreHTML5ParserQuirks]):
1194         (-[WebView _preferencesChanged:]):
1195         (-[WebView _addScrollerDashboardRegions:]):
1196         (-[WebView _dashboardRegions]):
1197         (-[WebView _setDashboardBehavior:to:]):
1198         (-[WebView _dashboardBehavior:]):
1199         (-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted.
1200         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted.
1201         (-[WebView _addScrollerDashboardRegions:from:]): Deleted.
1202         * WebView/WebViewData.h:
1203         * WebView/WebViewData.mm:
1204         (-[WebViewPrivate init]):
1205         * WebView/WebViewPrivate.h:
1206
1207 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1208
1209         Integrate dark mode support for iOS.
1210         https://bugs.webkit.org/show_bug.cgi?id=198687
1211         rdar://problem/51545643
1212
1213         Reviewed by Tim Horton.
1214
1215         * Configurations/FeatureDefines.xcconfig:
1216
1217 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1218
1219         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1220         https://bugs.webkit.org/show_bug.cgi?id=198664
1221
1222         Reviewed by Simon Fraser.
1223
1224         WK1 has to skip using DisplayRefreshMonitor when layers need to be updated.
1225
1226         * WebCoreSupport/WebChromeClient.h:
1227         (WebChromeClient::needsImmediateScheduleCompositingLayerFlush):
1228
1229 == Rolled over to ChangeLog-2019-06-05 ==