98965658f6f8e5cf0b22e911a7bc5961381c1cdb
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2
3         Move FileSystem to WTF
4         https://bugs.webkit.org/show_bug.cgi?id=193602
5
6         Reviewed by Yusuke Suzuki.
7
8         * Misc/WebNSFileManagerExtras.mm:
9         * Storage/WebDatabaseProvider.mm:
10         * WebView/WebView.mm:
11
12 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
13
14         Fix the Apple Internal build. See <rdar://problem/47491383>.
15
16         Rubber-stamped by Tim Horton.
17
18         * WebCoreSupport/WebFrameLoaderClient.mm:
19
20 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
21
22         Clean up USE(WEB_THREAD)
23         https://bugs.webkit.org/show_bug.cgi?id=193698
24
25         Rubber-stamped by Tim Horton.
26
27         * Misc/WebCache.mm:
28         (+[WebCache emptyInMemoryResources]):
29         * WebCoreSupport/WebFrameLoaderClient.mm:
30         (-[WebFramePolicyListener use]):
31         * WebCoreSupport/WebGeolocationClient.mm:
32         (-[WebGeolocationPolicyListener allow]):
33         (-[WebGeolocationPolicyListener deny]):
34         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
35         * WebView/WebFrame.mm:
36         (-[WebFrame deviceOrientationChanged]):
37         * WebView/WebHTMLView.mm:
38         (hardwareKeyboardAvailabilityChangedCallback):
39         * WebView/WebView.mm:
40         (+[WebView _releaseMemoryNow]):
41         (+[WebView willEnterBackgroundWithCompletionHandler:]):
42         (-[WebView updateLayoutIgnorePendingStyleSheets]):
43         (-[WebView _dispatchUnloadEvent]):
44         (-[WebView _close]):
45         (-[WebView _preferencesChangedNotification:]):
46         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
47         (-[WebView goBack]):
48         (-[WebView goForward]):
49         (+[WebView _cacheModelChangedNotification:]):
50         (-[WebView stopLoading:]):
51         (-[WebView stopLoadingAndClear]):
52         (-[WebView reload:]):
53         (WebInstallMemoryPressureHandler):
54
55 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
56
57         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
58         https://bugs.webkit.org/show_bug.cgi?id=193706
59         <rdar://problem/44807048>
60
61         Reviewed by Ryosuke Niwa.
62
63         Use UndoStep::label().
64
65         * WebCoreSupport/WebEditorClient.h:
66         * WebCoreSupport/WebEditorClient.mm:
67         (-[WebUndoStep initWithUndoStep:]):
68         (+[WebUndoStep stepWithUndoStep:]):
69         (WebEditorClient::registerUndoOrRedoStep):
70         (WebEditorClient::registerUndoStep):
71         (WebEditorClient::registerRedoStep):
72
73 2019-01-22  Alex Christensen  <achristensen@webkit.org>
74
75         Move NetworkStorageSession ownership to NetworkProcess
76         https://bugs.webkit.org/show_bug.cgi?id=193580
77
78         Reviewed by Geoff Garen.
79
80         * Misc/WebCache.mm:
81         (+[WebCache clearCachedCredentials]):
82         * Misc/WebDownload.mm:
83         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
84         * Plugins/WebBaseNetscapePluginView.mm:
85         (WebKit::getAuthenticationInfo):
86         * WebCoreSupport/WebFrameNetworkingContext.mm:
87         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
88         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
89         (WebFrameNetworkingContext::storageSession const):
90         * WebView/WebPreferences.mm:
91         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
92         (+[WebPreferences _clearNetworkLoaderSession]):
93         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
94
95 2019-01-22  Daniel Bates  <dabates@apple.com>
96
97         [iOS] Interpret text key commands on keydown and app key commands on keypress
98         https://bugs.webkit.org/show_bug.cgi?id=192897
99         <rdar://problem/46857378>
100
101         Reviewed by Brent Fulgham.
102
103         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
104         is false) and keypress (isCharEvent is true), respectively.
105
106         * WebView/WebHTMLView.mm:
107         (-[WebHTMLView _handleEditingKeyEvent:]):
108
109 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
110
111         [css-logical] Implement flow-relative margin, padding and border shorthands
112         https://bugs.webkit.org/show_bug.cgi?id=188697
113
114         Reviewed by Simon Fraser and Antti Koivisto.
115
116         Add CSSLogicalEnabled runtime flag.
117
118         * WebView/WebPreferenceKeysPrivate.h:
119         * WebView/WebPreferences.mm:
120         (+[WebPreferences initialize]):
121         (-[WebPreferences cssLogicalEnabled]):
122         (-[WebPreferences setCSSLogicalEnabled:]):
123         * WebView/WebPreferencesPrivate.h:
124         * WebView/WebView.mm:
125         (-[WebView _preferencesChanged:]):
126
127 2019-01-15  Darin Adler  <darin@apple.com>
128
129         Use references rather than pointers for register/unregister functions, and more
130         https://bugs.webkit.org/show_bug.cgi?id=175028
131
132         Reviewed by Daniel Bates.
133
134         * WebCoreSupport/WebKitFullScreenListener.mm:
135         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
136         functions in Document; pass a reference.
137         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
138         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
139         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
140         * WebView/WebFullScreenController.mm:
141         (-[WebFullScreenController enterFullScreen:]): Ditto.
142         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
143         (-[WebFullScreenController exitFullScreen]): Ditto.
144         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
145         * WebView/WebFullScreenController.mm:
146         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
147
148 2019-01-12  Dan Bernstein  <mitz@apple.com>
149
150         [Cocoa] Avoid importing directly from subumbrella frameworks
151         https://bugs.webkit.org/show_bug.cgi?id=186016
152         <rdar://problem/40591038>
153
154         Reviewed by Sam Weinig.
155
156         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
157         * Carbon/CarbonWindowAdapter.mm: Ditto.
158         * Carbon/CarbonWindowFrame.m: Ditto.
159         * Carbon/HIViewAdapter.h: Ditto.
160         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
161           OTHER_CFLAGS_COCOA_TOUCH_NO.
162         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
163         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
164         * WebView/WebPDFView.h: Ditto.
165
166 2019-01-20  Antoine Quint  <graouts@apple.com>
167
168         Add a POINTER_EVENTS feature flag
169         https://bugs.webkit.org/show_bug.cgi?id=193577
170         <rdar://problem/47408511>
171
172         Unreviewed. Also enable Pointer Events for iosmac.
173
174         * Configurations/FeatureDefines.xcconfig:
175
176 2019-01-19  Antoine Quint  <graouts@apple.com>
177
178         Add a POINTER_EVENTS feature flag
179         https://bugs.webkit.org/show_bug.cgi?id=193577
180
181         Reviewed by Dean Jackson.
182
183         * Configurations/FeatureDefines.xcconfig:
184
185 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
186
187         Revert r238815, it broke WK1 video fullscreen on Mac
188         https://bugs.webkit.org/show_bug.cgi?id=193586
189         <rdar://problem/47358941>
190
191         Reviewed by Jer Noble.
192
193         * WebView/WebVideoFullscreenController.h: Added.
194         * WebView/WebVideoFullscreenController.mm: Added.
195         (SOFT_LINK_CLASS):
196         (-[WebVideoFullscreenController init]):
197         (-[WebVideoFullscreenController dealloc]):
198         (-[WebVideoFullscreenController fullscreenWindow]):
199         (-[WebVideoFullscreenController windowDidLoad]):
200         (-[WebVideoFullscreenController videoElement]):
201         (-[WebVideoFullscreenController setVideoElement:]):
202         (-[WebVideoFullscreenController clearFadeAnimation]):
203         (-[WebVideoFullscreenController windowDidExitFullscreen]):
204         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
205         (-[WebVideoFullscreenController videoElementRect]):
206         (-[WebVideoFullscreenController applicationDidResignActive:]):
207         (frameExpandedToRatioOfFrame):
208         (createBackgroundFullscreenWindow):
209         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
210         (-[WebVideoFullscreenController enterFullscreen:]):
211         (-[WebVideoFullscreenController exitFullscreen]):
212         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
213         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
214         (-[WebVideoFullscreenController _requestExit]):
215         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
216         (-[WebVideoFullscreenController requestExitFullscreen]):
217         (-[WebVideoFullscreenController fadeHUDIn]):
218         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
219         (-[WebVideoFullscreenController rateChanged:]):
220         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
221         (-[WebVideoFullscreenWindow dealloc]):
222         (-[WebVideoFullscreenWindow resignFirstResponder]):
223         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
224         (-[WebVideoFullscreenWindow mouseDown:]):
225         (-[WebVideoFullscreenWindow cancelOperation:]):
226         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
227         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
228         (-[WebVideoFullscreenWindow animationDidEnd:]):
229         (-[WebVideoFullscreenWindow mouseMoved:]):
230         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
231         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
232         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
233         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
234         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
235         (-[WebVideoFullscreenHUDWindow center]):
236         (-[WebVideoFullscreenHUDWindow keyDown:]):
237         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
238         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
239         (-[WebVideoFullscreenHUDWindowController init]):
240         (-[WebVideoFullscreenHUDWindowController dealloc]):
241         (-[WebVideoFullscreenHUDWindowController setArea:]):
242         (-[WebVideoFullscreenHUDWindowController keyDown:]):
243         (-[WebVideoFullscreenHUDWindowController delegate]):
244         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
245         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
246         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
247         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
248         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
249         (-[WebVideoFullscreenHUDWindowController closeWindow]):
250         (createMediaUIControl):
251         (createControlWithMediaUIControlType):
252         (createTimeTextField):
253         (createMediaUIBackgroundView):
254         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
255         (-[WebVideoFullscreenHUDWindowController updateVolume]):
256         (-[WebVideoFullscreenHUDWindowController updateTime]):
257         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
258         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
259         (-[WebVideoFullscreenHUDWindowController currentTime]):
260         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
261         (-[WebVideoFullscreenHUDWindowController duration]):
262         (-[WebVideoFullscreenHUDWindowController maxVolume]):
263         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
264         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
265         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
266         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
267         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
268         (-[WebVideoFullscreenHUDWindowController volume]):
269         (-[WebVideoFullscreenHUDWindowController setVolume:]):
270         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
271         (-[WebVideoFullscreenHUDWindowController updateRate]):
272         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
273         (-[WebVideoFullscreenHUDWindowController playing]):
274         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
275         (timeToString):
276         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
277         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
278         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
279         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
280         (-[WebVideoFullscreenHUDWindowController rewind:]):
281         (-[WebVideoFullscreenHUDWindowController fastForward:]):
282         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
283         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
284         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
285         * WebView/WebView.mm:
286         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
287         (-[WebView _exitVideoFullscreen]):
288
289 2019-01-18  Tim Horton  <timothy_horton@apple.com>
290
291         Get rid of ADVANCED_SPELL_CHECKING
292         https://bugs.webkit.org/show_bug.cgi?id=193592
293
294         Reviewed by Wenson Hsieh.
295
296         * WebCoreSupport/WebEditorClient.mm:
297         (insertionPointFromCurrentSelection):
298         (WebEditorClient::checkTextOfParagraph):
299         (WebEditorClient::getGuessesForWord):
300         (WebEditorClient::requestCandidatesForSelection):
301         (WebEditorClient::requestCheckingOfString):
302         * WebView/WebHTMLView.mm:
303         (-[WebHTMLView insertText:]):
304
305 2019-01-18  Jer Noble  <jer.noble@apple.com>
306
307         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
308         https://bugs.webkit.org/show_bug.cgi?id=189553
309
310         Reviewed by Tim Horton.
311
312         * Configurations/Base.xcconfig:
313         * Configurations/SDKVariant.xcconfig: Added.
314         * Configurations/WebKitLegacy.xcconfig:
315
316 2019-01-18  David Kilzer  <ddkilzer@apple.com>
317
318         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
319         <https://webkit.org/b/193568>
320         <rdar://problem/47381130>
321
322         Reviewed by Alex Christensen.
323
324         * WebView/WebView.mm:
325         - Remove unused soft-linking macros.
326         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
327         (-[WebUITextIndicatorData initWithImage:scale:]):
328         - Update to use exported PAL functions.
329
330 2019-01-17  Truitt Savell  <tsavell@apple.com>
331
332         Unreviewed, rolling out r240124.
333
334         This commit broke an internal build.
335
336         Reverted changeset:
337
338         "SDK_VARIANT build destinations should be separate from non-
339         SDK_VARIANT builds"
340         https://bugs.webkit.org/show_bug.cgi?id=189553
341         https://trac.webkit.org/changeset/240124
342
343 2019-01-17  Jer Noble  <jer.noble@apple.com>
344
345         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
346         https://bugs.webkit.org/show_bug.cgi?id=189553
347
348         Reviewed by Tim Horton.
349
350         * Configurations/Base.xcconfig:
351         * Configurations/SDKVariant.xcconfig: Added.
352         * Configurations/WebKitLegacy.xcconfig:
353
354 2019-01-17  Alex Christensen  <achristensen@webkit.org>
355
356         Stop using NetworkStorageSession::storageSession in WebCore
357         https://bugs.webkit.org/show_bug.cgi?id=193529
358
359         Reviewed by Tim Horton.
360
361         * Misc/WebCache.mm:
362         (+[WebCache addImageToCache:forURL:forFrame:]):
363         * WebView/WebView.mm:
364         (-[WebView _commonInitializationWithFrameName:groupName:]):
365         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
366
367 2019-01-15  Alex Christensen  <achristensen@webkit.org>
368
369         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
370         https://bugs.webkit.org/show_bug.cgi?id=193368
371
372         Reviewed by Geoff Garen.
373
374         * Misc/WebCache.mm:
375         (+[WebCache clearCachedCredentials]):
376         * Misc/WebDownload.mm:
377         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
378         * Plugins/WebBaseNetscapePluginView.mm:
379         (WebKit::getAuthenticationInfo):
380
381 2019-01-15  Alex Christensen  <achristensen@webkit.org>
382
383         Stop using CookiesStrategy
384         https://bugs.webkit.org/show_bug.cgi?id=161106
385
386         Reviewed by Don Olmstead and Antti Koivisto.
387
388         * Misc/WebCache.mm:
389         (+[WebCache addImageToCache:forURL:forFrame:]):
390         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
391         (WebKit::NetscapePluginInstanceProxy::getCookies):
392         (WebKit::NetscapePluginInstanceProxy::setCookies):
393         * Plugins/WebNetscapePluginView.mm:
394         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
395         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
396         * WebCoreSupport/WebPlatformStrategies.h:
397         * WebCoreSupport/WebPlatformStrategies.mm:
398         (WebPlatformStrategies::createCookiesStrategy): Deleted.
399         (WebPlatformStrategies::cookiesForDOM): Deleted.
400         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
401         (WebPlatformStrategies::cookiesEnabled): Deleted.
402         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
403         (WebPlatformStrategies::getRawCookies): Deleted.
404         (WebPlatformStrategies::deleteCookie): Deleted.
405         * WebView/WebView.mm:
406         (-[WebView _commonInitializationWithFrameName:groupName:]):
407         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
408
409 2019-01-15  Tim Horton  <timothy_horton@apple.com>
410
411         Cannot tab out of WKWebView on macOS
412         https://bugs.webkit.org/show_bug.cgi?id=161448
413         <rdar://problem/28100085>
414
415         Reviewed by Dean Jackson.
416
417         * WebCoreSupport/WebChromeClient.mm:
418         * WebView/WebView.mm:
419         Make use of SPI headers.
420
421 2019-01-14  Commit Queue  <commit-queue@webkit.org>
422
423         Unreviewed, rolling out r239901, r239909, r239910, r239912,
424         r239913, and r239914.
425         https://bugs.webkit.org/show_bug.cgi?id=193407
426
427         These revisions caused an internal failure (Requested by
428         Truitt on #webkit).
429
430         Reverted changesets:
431
432         "[Cocoa] Avoid importing directly from subumbrella frameworks"
433         https://bugs.webkit.org/show_bug.cgi?id=186016
434         https://trac.webkit.org/changeset/239901
435
436         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
437         https://trac.webkit.org/changeset/239909
438
439         "Tried to fix the build."
440         https://trac.webkit.org/changeset/239910
441
442         "Fixed iOS builds after r239910."
443         https://trac.webkit.org/changeset/239912
444
445         "More build fixing."
446         https://trac.webkit.org/changeset/239913
447
448         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
449         https://trac.webkit.org/changeset/239914
450
451 2019-01-14  Mark Lam  <mark.lam@apple.com>
452
453         Re-enable ability to build --cloop builds.
454         https://bugs.webkit.org/show_bug.cgi?id=192955
455         <rdar://problem/46882363>
456
457         Reviewed by Saam barati and Keith Miller.
458
459         * Configurations/FeatureDefines.xcconfig:
460
461 2019-01-13  Dan Bernstein  <mitz@apple.com>
462
463         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
464
465         Patch by Keith Rollin.
466
467         * WebView/PDFViewSPI.h:
468
469 2019-01-12  Timothy Hatcher  <timothy@apple.com>
470
471         Have prefers-color-scheme: light always match on macOS versions before Mojave.
472         https://bugs.webkit.org/show_bug.cgi?id=191655
473         rdar://problem/46074680
474
475         Reviewed by Megan Gardner.
476
477         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
478         * WebView/WebView.mm:
479         (-[WebView _effectiveAppearanceIsDark]):
480
481 2019-01-12  Dan Bernstein  <mitz@apple.com>
482
483         [Cocoa] Avoid importing directly from subumbrella frameworks
484         https://bugs.webkit.org/show_bug.cgi?id=186016
485         <rdar://problem/40591038>
486
487         Reviewed by Sam Weinig.
488
489         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
490         * Carbon/CarbonWindowAdapter.mm: Ditto.
491         * Carbon/CarbonWindowFrame.m: Ditto.
492         * Carbon/HIViewAdapter.h: Ditto.
493         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
494           OTHER_CFLAGS_COCOA_TOUCH_NO.
495         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
496         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
497         * WebView/WebPDFView.h: Ditto.
498
499 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
500
501         Enable visual viewport API by default
502         https://bugs.webkit.org/show_bug.cgi?id=193376
503
504         Reviewed by Simon Fraser.
505
506         * WebView/WebPreferences.mm:
507         (+[WebPreferences initialize]):
508
509 2019-01-11  John Wilander  <wilander@apple.com>
510
511         Compile out Web API Statistics Collection
512         https://bugs.webkit.org/show_bug.cgi?id=193370
513         <rdar://problem/45388584>
514
515         Reviewed by Brent Fulgham.
516
517         * Configurations/FeatureDefines.xcconfig:
518             Defined ENABLE_WEB_API_STATISTICS, off by default.
519
520 2019-01-08  Alex Christensen  <achristensen@webkit.org>
521
522         Stop using NetworkStorageSession in WebProcess
523         https://bugs.webkit.org/show_bug.cgi?id=193236
524
525         Reviewed by Don Olmstead.
526
527         * WebCoreSupport/WebFrameNetworkingContext.h:
528         * WebCoreSupport/WebFrameNetworkingContext.mm:
529         (WebFrameNetworkingContext::storageSession const):
530         * WebCoreSupport/WebPlatformStrategies.h:
531         * WebCoreSupport/WebPlatformStrategies.mm:
532         (WebPlatformStrategies::cookiesForDOM):
533         (WebPlatformStrategies::setCookiesFromDOM):
534         (WebPlatformStrategies::cookiesEnabled):
535         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
536         (WebPlatformStrategies::getRawCookies):
537         (WebPlatformStrategies::deleteCookie):
538         * WebView/WebView.mm:
539         (-[WebView _cachedResponseForURL:]):
540         (-[WebView _clearCredentials]):
541
542 2019-01-08  Alex Christensen  <achristensen@webkit.org>
543
544         Unreviewed, rolling out r239727.
545
546         Broke API tests
547
548         Reverted changeset:
549
550         "Stop using NetworkStorageSession in WebProcess"
551         https://bugs.webkit.org/show_bug.cgi?id=193236
552         https://trac.webkit.org/changeset/239727
553
554 2019-01-08  Alex Christensen  <achristensen@webkit.org>
555
556         Stop using NetworkStorageSession in WebProcess
557         https://bugs.webkit.org/show_bug.cgi?id=193236
558
559         Reviewed by Don Olmstead.
560
561         * WebCoreSupport/WebFrameNetworkingContext.h:
562         * WebCoreSupport/WebFrameNetworkingContext.mm:
563         (WebFrameNetworkingContext::storageSession const):
564         * WebView/WebView.mm:
565         (-[WebView _cachedResponseForURL:]):
566         (-[WebView _clearCredentials]):
567
568 2019-01-07  David Kilzer  <ddkilzer@apple.com>
569
570         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
571         <https://webkit.org/b/193056>
572
573         Reviewed by Alex Christensen.
574
575         * Plugins/Hosted/NetscapePluginHostProxy.h:
576         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
577         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
578         (WebKit::NetscapePluginInstanceProxy::enumerate):
579         (WebKit::NetscapePluginInstanceProxy::marshalValue):
580         (WebKit::NetscapePluginInstanceProxy::marshalValues):
581         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
582         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
583         * Plugins/Hosted/ProxyInstance.mm:
584         (WebKit::ProxyInstance::invoke):
585         * WebCoreSupport/WebGeolocationClient.mm:
586         * WebView/WebDataSource.mm:
587         (-[WebDataSource _receivedData:]):
588         * WebView/WebView.mm:
589         (-[WebView _cachedResponseForURL:]):
590         - Remove '*' from RetainPtr<> type.
591
592 2019-01-04  Alex Christensen  <achristensen@webkit.org>
593
594         Progress towards fixing Mac CMake build
595         https://bugs.webkit.org/show_bug.cgi?id=193105
596
597         Reviewed by Don Olmstead.
598
599         * WebKitPrefix.h:
600
601 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
602
603         Web Inspector: Use save sheet instead of dialog where possible
604         https://bugs.webkit.org/show_bug.cgi?id=193160
605         <rdar://problem/37399759>
606
607         Reviewed by Devin Rousso.
608
609         * WebCoreSupport/WebInspectorClient.mm:
610         (WebInspectorFrontendClient::save):
611
612 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
613
614         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
615         https://bugs.webkit.org/show_bug.cgi?id=193129
616
617         Reviewed by Tim Horton.
618
619         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
620
621         * WebCoreSupport/WebEditorClient.mm:
622         (WebEditorClient::registerUndoOrRedoStep):
623         (undoNameForEditAction): Deleted.
624
625 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
626
627         Add support for using the current text selection as the find string on iOS
628         https://bugs.webkit.org/show_bug.cgi?id=193034
629         <rdar://problem/45138739>
630
631         Reviewed by Tim Horton.
632
633         Add a method stub for WebKitLegacy.
634
635         * WebCoreSupport/WebEditorClient.h:
636
637 2019-01-01  Jeff Miller  <jeffm@apple.com>
638
639         Update user-visible copyright strings to include 2019
640         https://bugs.webkit.org/show_bug.cgi?id=192811
641
642         Reviewed by Mark Lam.
643
644         * Info.plist:
645
646 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
647
648         Use Ref<> as much as possible
649         https://bugs.webkit.org/show_bug.cgi?id=192808
650
651         Reviewed by Alex Christensen.
652
653         * DOM/DOM.mm:
654         (-[DOMNode getPreviewSnapshotImage:andRects:]):
655         * Plugins/Hosted/NetscapePluginHostManager.mm:
656         (WebKit::NetscapePluginHostManager::instantiatePlugin):
657         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
658         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
659         (WebKit::NetscapePluginInstanceProxy::loadRequest):
660         * Plugins/WebNetscapePluginView.mm:
661         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
662         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
663         * WebCoreSupport/WebContextMenuClient.mm:
664         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
665         * WebCoreSupport/WebFrameLoaderClient.mm:
666         (WebFrameLoaderClient::transitionToCommittedForNewPage):
667         * WebView/WebFrame.mm:
668         (-[WebFrame getDictationResultRanges:andMetadatas:]):
669         * WebView/WebHTMLView.mm:
670         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
671         * WebView/WebView.mm:
672         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
673         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
674
675 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
676
677         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
678         https://bugs.webkit.org/show_bug.cgi?id=192821
679
680         Reviewed by Chris Dumez.
681
682         When a window becomes occluded, the window server informs the application.
683         This should be used to suspend any work that is not visible by the user.
684
685         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
686         In some cases, that lead to performance impact (see radar).
687
688         This patch adds an observer for the occlusion notification. I tried to stick
689         with the same names used by WebKit2.
690
691         * WebView/WebView.mm:
692         (-[WebView _isViewVisible]):
693         (-[WebView addWindowObserversForWindow:]):
694         (-[WebView removeWindowObservers]):
695         (-[WebView _windowDidChangeOcclusionState:]):
696
697 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
698
699         [WebAuthN] Add a runtime flag for local authenticator
700         https://bugs.webkit.org/show_bug.cgi?id=192792
701         <rdar://problem/46798738>
702
703         Reviewed by Brent Fulgham.
704
705         * WebView/WebPreferenceKeysPrivate.h:
706         * WebView/WebPreferences.mm:
707         (+[WebPreferences initialize]):
708         (-[WebPreferences webAuthenticationEnabled]): Deleted.
709         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
710         * WebView/WebPreferencesPrivate.h:
711         * WebView/WebView.mm:
712         (-[WebView _preferencesChanged:]):
713
714 2018-12-20  Chris Dumez  <cdumez@apple.com>
715
716         Use Optional::valueOr() instead of Optional::value_or()
717         https://bugs.webkit.org/show_bug.cgi?id=192933
718
719         Reviewed by Geoffrey Garen.
720
721         * WebCoreSupport/WebSecurityOrigin.mm:
722         (-[WebSecurityOrigin port]):
723
724 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
725
726         Unreviewed, rolling out r239417.
727
728         Introduced two API test failures on macOS.
729
730         Reverted changeset:
731
732         "<rdar://problem/46194315> macOS: WebKit1 does not handle
733         occlusion changes"
734         https://bugs.webkit.org/show_bug.cgi?id=192821
735         https://trac.webkit.org/changeset/239417
736
737 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
738
739         WKWebView default UA doesn't freeze the build number
740         https://bugs.webkit.org/show_bug.cgi?id=192809
741         <rdar://problem/44687185>
742
743         Reviewed by Andy Estes.
744
745         Always reports the frozen build number.
746
747         * WebView/WebView.mm:
748         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
749         actual build number through this method call.
750         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
751
752 2018-12-19  Chris Dumez  <cdumez@apple.com>
753
754         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
755         https://bugs.webkit.org/show_bug.cgi?id=192728
756         <rdar://problem/46746779>
757
758         Reviewed by Geoff Garen.
759
760         * DOM/*:
761         * Plugins/*:
762         * WebCoreSupport/*:
763         * WebView/*:
764
765 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
766
767         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
768         https://bugs.webkit.org/show_bug.cgi?id=192821
769
770         Reviewed by Chris Dumez.
771
772         When a window becomes occluded, the window server informs the application.
773         This should be used to suspend any work that is not visible by the user.
774
775         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
776         In some cases, that lead to performance impact (see radar).
777
778         This patch adds an observer for the occlusion notification. I tried to stick
779         with the same names used by WebKit2.
780
781         * WebView/WebView.mm:
782         (-[WebView _isViewVisible]):
783         (-[WebView addWindowObserversForWindow:]):
784         (-[WebView removeWindowObservers]):
785         (-[WebView _windowDidChangeOcclusionState:]):
786
787 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
788
789         Allow clients to set the navigator platform
790         https://bugs.webkit.org/show_bug.cgi?id=192735
791
792         Reviewed by Tim Horton.
793
794         Add stubs to fill out the added functionality in FrameLoaderClient.
795
796         * WebCoreSupport/WebFrameLoaderClient.h:
797         * WebCoreSupport/WebFrameLoaderClient.mm:
798         (WebFrameLoaderClient::navigatorPlatform):
799
800 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
801
802         offsetLeft and offsetParent should adjust across shadow boundaries
803         https://bugs.webkit.org/show_bug.cgi?id=157437
804         <rdar://problem/26154021>
805
806         Reviewed by Simon Fraser.
807
808         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
809
810         * DOM/DOMElement.mm:
811         (-[DOMElement offsetLeft]):
812         (-[DOMElement offsetTop]):
813         (-[DOMElement offsetParent]):
814
815 2018-12-17  Zalan Bujtas  <zalan@apple.com>
816
817         Unreviewed build fix.
818
819         * WebView/WebFrame.mm:
820         (-[WebFrame getDictationResultRanges:andMetadatas:]):
821
822 2018-12-15  Darin Adler  <darin@apple.com>
823
824         Use warning-ignoring macros more consistently and simply
825         https://bugs.webkit.org/show_bug.cgi?id=192743
826
827         Reviewed by Mark Lam.
828
829         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
830         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
831         compilers in Objective-C++ code.
832
833         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
834         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
835         accomodate non-clang compilers here. Also use #pragma once, add a missing
836         "explicit" and fix conditionals.
837
838 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
839
840         Make TextInputController.legacyAttributedString take DOM nodes and offsets
841         https://bugs.webkit.org/show_bug.cgi?id=192653
842
843         Reviewed by Wenson Hsieh.
844
845         * WebView/WebHTMLView.mm:
846         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
847
848 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
849
850         Implement feature flag for CSS Typed OM
851         https://bugs.webkit.org/show_bug.cgi?id=192610
852
853         Reviewed by Ryosuke Niwa.
854
855         * Configurations/FeatureDefines.xcconfig:
856
857 2018-12-11  Tim Horton  <timothy_horton@apple.com>
858
859         WebCore shouldn't have a Objective-C class named NSCursor
860         https://bugs.webkit.org/show_bug.cgi?id=192602
861         <rdar://problem/46615532>
862
863         Reviewed by Wenson Hsieh.
864
865         * WebView/WebFrameView.mm:
866         (-[WebFrameView keyDown:keyDown:]):
867         * WebView/WebHTMLView.mm:
868         (-[WebHTMLView keyDown:]):
869         (-[WebHTMLView performKeyEquivalent:]):
870         Only use NSCursor on macOS.
871
872 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
873
874         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
875         https://bugs.webkit.org/show_bug.cgi?id=192573
876
877         Reviewed by Simon Fraser.
878
879         * Configurations/FeatureDefines.xcconfig:
880
881 2018-12-10  Antti Koivisto  <antti@apple.com>
882
883         Rename "forced style recalc" to "full style rebuild"
884         https://bugs.webkit.org/show_bug.cgi?id=192572
885
886         Reviewed by Zalan Bujtas.
887
888         * WebView/WebHTMLView.mm:
889         (-[WebHTMLView setNeedsToApplyStyles:]):
890
891 2018-12-10  Darin Adler  <darin@apple.com>
892
893         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
894         https://bugs.webkit.org/show_bug.cgi?id=192533
895         rdar://problem/45732710
896
897         Reviewed by Anders Carlsson.
898
899         * Plugins/Hosted/NetscapePluginHostProxy.mm:
900         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
901
902 2018-12-10  Darin Adler  <darin@apple.com>
903
904         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
905         https://bugs.webkit.org/show_bug.cgi?id=192532
906         rdar://problem/45731047
907
908         Reviewed by Chris Dumez.
909
910         * Plugins/Hosted/NetscapePluginHostManager.mm:
911         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
912         * Plugins/Hosted/NetscapePluginHostProxy.mm:
913         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
914
915 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
916
917         Turn WritingDirection into an enum class
918         https://bugs.webkit.org/show_bug.cgi?id=192401
919         Work towards <rdar://problem/42075638>
920
921         Reviewed by Dan Bernstein.
922
923         Change WritingDirection from an enum to an enum class. No change in behavior.
924
925         * WebView/WebHTMLView.mm:
926         (-[WebHTMLView toggleBaseWritingDirection:]):
927         (-[WebHTMLView changeBaseWritingDirection:]):
928         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
929
930 2018-12-03  Alex Christensen  <achristensen@webkit.org>
931
932         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
933         https://bugs.webkit.org/show_bug.cgi?id=192272
934
935         Reviewed by Brady Eidson.
936
937         * WebCoreSupport/WebFrameLoaderClient.h:
938         * WebCoreSupport/WebFrameLoaderClient.mm:
939         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
940
941 2018-12-03  Jer Noble  <jer.noble@apple.com>
942
943         Get rid of old, dead Mac video fullscreen code.
944         https://bugs.webkit.org/show_bug.cgi?id=192315
945
946         Reviewed by Eric Carlson.
947
948         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
949         is no longer supported in the Mac port.
950
951         * WebView/WebVideoFullscreenController.h: Removed.
952         * WebView/WebVideoFullscreenController.mm: Removed.
953         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
954         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
955         * WebView/WebView.mm:
956         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
957         (-[WebView _exitVideoFullscreen]):
958
959 2018-12-03  Daniel Bates  <dabates@apple.com>
960
961         [iOS] Do not handle key events that are key commands
962         https://bugs.webkit.org/show_bug.cgi?id=191608
963         <rdar://problem/46046013>
964
965         Reviewed by Ryosuke Niwa.
966
967         A key down event may be associated with a key command. If it is then we want to execute the
968         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
969         event as a key command to find out.
970
971         * WebView/WebHTMLView.mm:
972         (-[WebHTMLView _handleEditingKeyEvent:]):
973
974 2018-12-02  Zalan Bujtas  <zalan@apple.com>
975
976         Add a runtime feature flag for LayoutFormattingContext.
977         https://bugs.webkit.org/show_bug.cgi?id=192280
978
979         Reviewed by Simon Fraser.
980
981         * Configurations/FeatureDefines.xcconfig:
982
983 2018-11-30  Alex Christensen  <achristensen@webkit.org>
984
985         Move URL from WebCore to WTF
986         https://bugs.webkit.org/show_bug.cgi?id=190234
987
988         Reviewed by Keith Miller.
989
990         * DOM/DOMAttr.mm:
991         * DOM/DOMBlob.mm:
992         * DOM/DOMCSSCharsetRule.mm:
993         * DOM/DOMCSSImportRule.mm:
994         * DOM/DOMCSSMediaRule.mm:
995         * DOM/DOMCSSPageRule.mm:
996         * DOM/DOMCSSPrimitiveValue.mm:
997         * DOM/DOMCSSRule.mm:
998         * DOM/DOMCSSStyleDeclaration.mm:
999         * DOM/DOMCSSStyleRule.mm:
1000         * DOM/DOMCSSStyleSheet.mm:
1001         * DOM/DOMCSSValue.mm:
1002         * DOM/DOMCharacterData.mm:
1003         * DOM/DOMCounter.mm:
1004         * DOM/DOMDocument.mm:
1005         * DOM/DOMDocumentFragment.mm:
1006         * DOM/DOMDocumentType.mm:
1007         * DOM/DOMEvent.mm:
1008         * DOM/DOMFile.mm:
1009         * DOM/DOMHTMLAnchorElement.mm:
1010         * DOM/DOMHTMLAppletElement.mm:
1011         * DOM/DOMHTMLAreaElement.mm:
1012         * DOM/DOMHTMLBRElement.mm:
1013         * DOM/DOMHTMLBaseElement.mm:
1014         * DOM/DOMHTMLBaseFontElement.mm:
1015         * DOM/DOMHTMLBodyElement.mm:
1016         * DOM/DOMHTMLButtonElement.mm:
1017         * DOM/DOMHTMLCanvasElement.mm:
1018         * DOM/DOMHTMLCollection.mm:
1019         * DOM/DOMHTMLDivElement.mm:
1020         * DOM/DOMHTMLDocument.mm:
1021         * DOM/DOMHTMLElement.mm:
1022         * DOM/DOMHTMLEmbedElement.mm:
1023         * DOM/DOMHTMLFieldSetElement.mm:
1024         * DOM/DOMHTMLFontElement.mm:
1025         * DOM/DOMHTMLFormElement.mm:
1026         * DOM/DOMHTMLFrameElement.mm:
1027         * DOM/DOMHTMLFrameSetElement.mm:
1028         * DOM/DOMHTMLHRElement.mm:
1029         * DOM/DOMHTMLHeadElement.mm:
1030         * DOM/DOMHTMLHeadingElement.mm:
1031         * DOM/DOMHTMLHtmlElement.mm:
1032         * DOM/DOMHTMLIFrameElement.mm:
1033         * DOM/DOMHTMLImageElement.mm:
1034         * DOM/DOMHTMLInputElement.mm:
1035         * DOM/DOMHTMLLIElement.mm:
1036         * DOM/DOMHTMLLabelElement.mm:
1037         * DOM/DOMHTMLLegendElement.mm:
1038         * DOM/DOMHTMLLinkElement.mm:
1039         * DOM/DOMHTMLMapElement.mm:
1040         * DOM/DOMHTMLMarqueeElement.mm:
1041         * DOM/DOMHTMLMediaElement.mm:
1042         * DOM/DOMHTMLMetaElement.mm:
1043         * DOM/DOMHTMLModElement.mm:
1044         * DOM/DOMHTMLOListElement.mm:
1045         * DOM/DOMHTMLObjectElement.mm:
1046         * DOM/DOMHTMLOptGroupElement.mm:
1047         * DOM/DOMHTMLOptionElement.mm:
1048         * DOM/DOMHTMLOptionsCollection.mm:
1049         * DOM/DOMHTMLParagraphElement.mm:
1050         * DOM/DOMHTMLParamElement.mm:
1051         * DOM/DOMHTMLQuoteElement.mm:
1052         * DOM/DOMHTMLScriptElement.mm:
1053         * DOM/DOMHTMLSelectElement.mm:
1054         * DOM/DOMHTMLStyleElement.mm:
1055         * DOM/DOMHTMLTableCaptionElement.mm:
1056         * DOM/DOMHTMLTableCellElement.mm:
1057         * DOM/DOMHTMLTableColElement.mm:
1058         * DOM/DOMHTMLTableElement.mm:
1059         * DOM/DOMHTMLTableRowElement.mm:
1060         * DOM/DOMHTMLTableSectionElement.mm:
1061         * DOM/DOMHTMLTitleElement.mm:
1062         * DOM/DOMHTMLUListElement.mm:
1063         * DOM/DOMHTMLVideoElement.mm:
1064         * DOM/DOMKeyboardEvent.mm:
1065         * DOM/DOMMediaList.mm:
1066         * DOM/DOMMouseEvent.mm:
1067         * DOM/DOMMutationEvent.mm:
1068         * DOM/DOMNamedNodeMap.mm:
1069         * DOM/DOMProcessingInstruction.mm:
1070         * DOM/DOMRange.mm:
1071         * DOM/DOMStyleSheet.mm:
1072         * DOM/DOMText.mm:
1073         * DOM/DOMTextEvent.mm:
1074         * DOM/DOMTokenList.mm:
1075         * DOM/DOMUIEvent.mm:
1076         * DOM/DOMXPathResult.mm:
1077         * History/WebHistoryItem.mm:
1078         * Misc/WebNSURLExtras.mm:
1079         (-[NSURL _web_userVisibleString]):
1080         (-[NSURL _web_URLByRemovingUserInfo]):
1081         (-[NSURL _web_dataForURLComponentType:]):
1082         (-[NSURL _web_schemeData]):
1083         (-[NSURL _web_hostData]):
1084         * Misc/WebUserContentURLPattern.mm:
1085         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1086         * Plugins/WebNetscapePluginStream.h:
1087         (WebNetscapePluginStream::setRequestURL):
1088         * WebCoreSupport/WebChromeClient.h:
1089         * WebCoreSupport/WebChromeClient.mm:
1090         (WebChromeClient::signedPublicKeyAndChallengeString const):
1091         * WebCoreSupport/WebContextMenuClient.h:
1092         * WebCoreSupport/WebContextMenuClient.mm:
1093         * WebCoreSupport/WebDragClient.h:
1094         * WebCoreSupport/WebFrameLoaderClient.h:
1095         * WebCoreSupport/WebFrameLoaderClient.mm:
1096         (WebFrameLoaderClient::updateGlobalHistory):
1097         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1098         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1099         (WebPaymentCoordinatorClient::showPaymentUI):
1100         * WebCoreSupport/WebPlatformStrategies.h:
1101         * WebCoreSupport/WebPlatformStrategies.mm:
1102         (WebPlatformStrategies::readURLFromPasteboard):
1103         * WebCoreSupport/WebPluginInfoProvider.h:
1104         * WebCoreSupport/WebPluginInfoProvider.mm:
1105         (WebPluginInfoProvider::webVisiblePluginInfo):
1106         * WebCoreSupport/WebSecurityOrigin.mm:
1107         * WebCoreSupport/WebVisitedLinkStore.h:
1108         * WebView/WebDataSource.mm:
1109         * WebView/WebFrame.mm:
1110         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1111         * WebView/WebImmediateActionController.mm:
1112         (-[WebImmediateActionController _defaultAnimationController]):
1113         * WebView/WebPDFView.mm:
1114         * WebView/WebScriptDebugger.mm:
1115         * WebView/WebViewInternal.h:
1116
1117 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1118
1119         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1120         https://bugs.webkit.org/show_bug.cgi?id=192197
1121
1122         Reviewed by Jiewen Tan.
1123
1124         * Configurations/FeatureDefines.xcconfig:
1125         * WebCoreSupport/WebChromeClient.h:
1126         * WebCoreSupport/WebChromeClient.mm:
1127
1128 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1129
1130         Remove dead code from an earlier attempt at implementing safe browsing
1131         https://bugs.webkit.org/show_bug.cgi?id=192067
1132
1133         Reviewed by Chris Dumez.
1134
1135         * WebCoreSupport/WebFrameLoaderClient.h:
1136         * WebCoreSupport/WebFrameLoaderClient.mm:
1137         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1138
1139 2018-11-27  Mark Lam  <mark.lam@apple.com>
1140
1141         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1142         https://bugs.webkit.org/show_bug.cgi?id=192055
1143         <rdar://problem/46288783>
1144
1145         Reviewed by Saam Barati.
1146
1147         * Configurations/FeatureDefines.xcconfig:
1148
1149 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1150
1151         Make it possible to insert editable images with a gesture
1152         https://bugs.webkit.org/show_bug.cgi?id=191937
1153
1154         Reviewed by Wenson Hsieh.
1155
1156         * WebCoreSupport/WebEditorClient.mm:
1157         (undoNameForEditAction):
1158         Add a undo name.
1159
1160 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1161
1162         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1163         https://bugs.webkit.org/show_bug.cgi?id=191945
1164
1165         Reviewed by Anders Carlsson.
1166
1167         * WebCoreSupport/WebEditorClient.mm:
1168         (undoNameForEditAction):
1169
1170 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1171
1172         Enable drag and drop support for iOSMac
1173         https://bugs.webkit.org/show_bug.cgi?id=191818
1174         <rdar://problem/43907454>
1175
1176         Reviewed by Dean Jackson.
1177
1178         * Configurations/FeatureDefines.xcconfig:
1179
1180 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         Address post-review feedback after r238438
1183         https://bugs.webkit.org/show_bug.cgi?id=191913
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         * WebView/WebFrame.mm:
1188         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1189         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1190         * WebView/WebView.mm:
1191         (-[WebView setSelectedDOMRange:affinity:]):
1192
1193 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1194
1195         Web Inspector: "Reload Web Inspector" button no longer partially works
1196         https://bugs.webkit.org/show_bug.cgi?id=191773
1197         <rdar://problem/46139932>
1198
1199         Reviewed by Devin Rousso.
1200
1201         * WebCoreSupport/WebInspectorClient.h:
1202         * WebCoreSupport/WebInspectorClient.mm:
1203         (WebInspectorFrontendClient::reopen):
1204
1205 2018-11-17  Devin Rousso  <drousso@apple.com>
1206
1207         Web Inspector: Network: add button to show system certificate dialog
1208         https://bugs.webkit.org/show_bug.cgi?id=191458
1209         <rdar://problem/45977019>
1210
1211         Reviewed by Joseph Pecoraro.
1212
1213         * WebCoreSupport/WebInspectorClient.h:
1214         * WebCoreSupport/WebInspectorClient.mm:
1215         (WebInspectorFrontendClient::showCertificate): Added.
1216
1217         * Configurations/WebKitLegacy.xcconfig:
1218
1219 2018-11-15  Truitt Savell  <tsavell@apple.com>
1220
1221         Unreviewed, rolling out r238244.
1222
1223         Caused High Sierra test runs to fail early with 50 crashes and
1224         casued 25 API failures.
1225
1226         Reverted changeset:
1227
1228         "[css-logical] Implement flow-relative margin, padding and
1229         border shorthands"
1230         https://bugs.webkit.org/show_bug.cgi?id=188697
1231         https://trac.webkit.org/changeset/238244
1232
1233 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1234
1235         [css-logical] Implement flow-relative margin, padding and border shorthands
1236         https://bugs.webkit.org/show_bug.cgi?id=188697
1237
1238         Reviewed by Simon Fraser and Antti Koivisto.
1239
1240         Add CSSLogicalEnabled runtime flag.
1241
1242         * WebView/WebPreferenceKeysPrivate.h:
1243         * WebView/WebPreferences.mm:
1244         (+[WebPreferences initialize]):
1245         (-[WebPreferences cssLogicalEnabled]):
1246         (-[WebPreferences setCSSLogicalEnabled:]):
1247         * WebView/WebPreferencesPrivate.h:
1248         * WebView/WebView.mm:
1249         (-[WebView _preferencesChanged:]):
1250
1251 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1252
1253         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1254         https://bugs.webkit.org/show_bug.cgi?id=191612
1255
1256         Reviewed by Matt Baker.
1257
1258         * WebCoreSupport/WebInspectorClient.mm:
1259         (-[WebInspectorWindowController destroyInspectorView]):
1260
1261 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1262
1263         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1264         https://bugs.webkit.org/show_bug.cgi?id=191494
1265         <rdar://problem/45469854>
1266
1267         Reviewed by Devin Rousso.
1268
1269         * WebCoreSupport/WebInspectorClient.h:
1270         WebKitLegacy will still have remote inspection of the Page directly.
1271
1272 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1273
1274         Make compositing updates incremental
1275         https://bugs.webkit.org/show_bug.cgi?id=90342
1276
1277         Reviewed by Antti Koivisto.
1278
1279         Fix spelling error.
1280
1281         * WebView/WebView.mm:
1282         (-[WebView _setMediaLayer:forPluginView:]):
1283
1284 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1285
1286         Implement a new edit command to change the enclosing list type
1287         https://bugs.webkit.org/show_bug.cgi?id=191487
1288         <rdar://problem/45955922>
1289
1290         Reviewed by Ryosuke Niwa.
1291
1292         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1293
1294         * WebCoreSupport/WebEditorClient.mm:
1295         (undoNameForEditAction):
1296
1297 2018-11-11  Daniel Bates  <dabates@apple.com>
1298
1299         [iOS] Draw caps lock indicator in password fields
1300         https://bugs.webkit.org/show_bug.cgi?id=190565
1301         <rdar://problem/45262343>
1302
1303         Reviewed by Dean Jackson.
1304
1305         Update the caps lock state when a hardware keyboard is attached or detached.
1306
1307         * WebView/WebHTMLView.mm:
1308         (hardwareKeyboardAvailabilityChangedCallback): Added.
1309         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1310         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1311
1312 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1313
1314         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1315         https://bugs.webkit.org/show_bug.cgi?id=191492
1316
1317         Reviewed by Alex Christensen.
1318
1319         * Carbon/HIWebView.mm:
1320         * Misc/WebNSFileManagerExtras.mm:
1321         * Misc/WebNSURLExtras.mm:
1322         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1323         * Plugins/WebBasePluginPackage.mm:
1324         * Plugins/WebPluginContainerCheck.mm:
1325         * WebCoreSupport/WebCachedFramePlatformData.h:
1326         * WebCoreSupport/WebDeviceOrientationClient.mm:
1327         * WebView/WebDelegateImplementationCaching.mm:
1328         * WebView/WebHTMLView.mm:
1329         * WebView/WebPDFRepresentation.mm:
1330         * WebView/WebPolicyDelegate.mm:
1331         * WebView/WebView.mm:
1332
1333 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1334
1335         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1336         https://bugs.webkit.org/show_bug.cgi?id=191492
1337
1338         Reviewed by Alex Christensen.
1339
1340         * Carbon/HIWebView.mm:
1341         (UpdateCommandStatus):
1342         * Misc/WebNSFileManagerExtras.mm:
1343         * Misc/WebNSURLExtras.mm:
1344         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1345         * Plugins/WebBasePluginPackage.mm:
1346         * Plugins/WebPluginContainerCheck.mm:
1347         (-[WebPluginContainerCheck _continueWithPolicy:]):
1348         * WebCoreSupport/WebCachedFramePlatformData.h:
1349         (WebCachedFramePlatformData::clear):
1350         * WebCoreSupport/WebDeviceOrientationClient.mm:
1351         (WebDeviceOrientationClient::getProvider const):
1352         * WebView/WebDelegateImplementationCaching.mm:
1353         (CallDelegate):
1354         (CallDelegateReturningBoolean):
1355         (CallResourceLoadDelegateReturningBoolean):
1356         (CallFormDelegate):
1357         (CallFormDelegateReturningBoolean):
1358         * WebView/WebHTMLView.mm:
1359         * WebView/WebPDFRepresentation.mm:
1360         * WebView/WebPolicyDelegate.mm:
1361         (-[WebPolicyDecisionListener _usePolicy:]):
1362         * WebView/WebView.mm:
1363
1364 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1365
1366         Unreviewed, rolling out r238047.
1367
1368         Introduced layout test failures on iOS simulator.
1369
1370         Reverted changeset:
1371
1372         "[iOS] Draw caps lock indicator in password fields"
1373         https://bugs.webkit.org/show_bug.cgi?id=190565
1374         https://trac.webkit.org/changeset/238047
1375
1376 2018-11-09  Antti Koivisto  <antti@apple.com>
1377
1378         Use OptionSet for layout milestones
1379         https://bugs.webkit.org/show_bug.cgi?id=191470
1380
1381         Reviewed by Dean Jackson.
1382
1383         * WebCoreSupport/WebFrameLoaderClient.h:
1384         * WebCoreSupport/WebFrameLoaderClient.mm:
1385         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1386         * WebView/WebView.mm:
1387         (coreLayoutMilestones):
1388         (kitLayoutMilestones):
1389         (-[WebView _cacheFrameLoadDelegateImplementations]):
1390         * WebView/WebViewInternal.h:
1391
1392 2018-11-09  Daniel Bates  <dabates@apple.com>
1393
1394         [iOS] Draw caps lock indicator in password fields
1395         https://bugs.webkit.org/show_bug.cgi?id=190565
1396         <rdar://problem/45262343>
1397
1398         Reviewed by Dean Jackson.
1399
1400         Update the caps lock state when a hardware keyboard is attached or detached.
1401
1402         * WebView/WebHTMLView.mm:
1403         (hardwareKeyboardAvailabilityChangedCallback): Added.
1404         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1405         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1406
1407 2018-11-09  Daniel Bates  <dabates@apple.com>
1408
1409         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1410         action when forward delete is pressed outside a text field
1411         https://bugs.webkit.org/show_bug.cgi?id=190566
1412         <rdar://problem/45262367>
1413
1414         Reviewed by Wenson Hsieh.
1415
1416         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1417         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1418         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1419
1420         * WebView/WebHTMLView.mm:
1421         (-[WebHTMLView _handleEditingKeyEvent:]):
1422
1423 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1424
1425         Adopt Reveal Framework to replace Lookup
1426         https://bugs.webkit.org/show_bug.cgi?id=191097
1427         <rdar://problem/45924508>
1428
1429         Reviewed by Tim Horton.
1430
1431         Pass in what it needed to clear the textIndicators. This is better than
1432         the current notification structure.
1433
1434         * WebView/WebView.mm:
1435         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1436         (-[WebView _prepareForDictionaryLookup]):
1437
1438 2018-11-06  Justin Fan  <justin_fan@apple.com>
1439
1440         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1441         https://bugs.webkit.org/show_bug.cgi?id=191291
1442
1443         Reviewed by Myles Maxfield.
1444
1445         Properly disable WEBGPU on all non-Metal platforms for now.
1446
1447         * Configurations/FeatureDefines.xcconfig:
1448
1449 2018-11-02  Daniel Bates  <dabates@apple.com>
1450
1451         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1452         https://bugs.webkit.org/show_bug.cgi?id=190487
1453
1454         Reviewed by Tim Horton.
1455
1456         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1457         allow the default handling.
1458
1459         * WebView/WebHTMLView.mm:
1460         (-[WebHTMLView _handleEditingKeyEvent:]):
1461
1462 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1463
1464         Add a storage limit for IndexedDB
1465         https://bugs.webkit.org/show_bug.cgi?id=190598
1466         <rdar://problem/44654715>
1467
1468         Reviewed by Chris Dumez.
1469
1470         * Storage/WebDatabaseManager.mm:
1471         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1472         * Storage/WebDatabaseManagerPrivate.h:
1473
1474 2018-10-31  Antti Koivisto  <antti@apple.com>
1475
1476         Remove LayerFlushScheduler
1477         https://bugs.webkit.org/show_bug.cgi?id=191103
1478
1479         Reviewed by Anders Carlsson.
1480
1481         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1482         all the virtual cruft.
1483
1484         * WebView/WebViewData.h:
1485         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1486         (): Deleted.
1487         * WebView/WebViewData.mm:
1488         (currentRunLoop):
1489         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1490         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1491         (WebViewLayerFlushScheduler::schedule):
1492         (WebViewLayerFlushScheduler::invalidate):
1493         (WebViewLayerFlushScheduler::layerFlushCallback):
1494
1495 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1496
1497         Enable InstallAPI for iOS unconditionally
1498         https://bugs.webkit.org/show_bug.cgi?id=191043
1499         rdar://problem/32728423
1500
1501         Reviewed by Dan Bernstein.
1502
1503         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1504         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1505         shouldn't be processed by InstallAPI.
1506         * MigrateHeaders.make: Removed an obsolete workaround.
1507         * Misc/NSURLDownloadSPI.h: Added.
1508         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1509
1510 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1511
1512         Clean up some obsolete MAX_ALLOWED macros
1513         https://bugs.webkit.org/show_bug.cgi?id=190916
1514
1515         Reviewed by Tim Horton.
1516
1517         * WebView/WebHTMLView.mm:
1518         (-[WebHTMLView pressureChangeWithEvent:]):
1519         * WebView/WebPDFView.h:
1520
1521 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1522
1523         Unreviewed, rolling out r237600 and r237604.
1524         https://bugs.webkit.org/show_bug.cgi?id=191086
1525
1526         Breaks internal iOS builds (Requested by ryanhadd_ on
1527         #webkit).
1528
1529         Reverted changesets:
1530
1531         "Enable InstallAPI for iOS unconditionally"
1532         https://bugs.webkit.org/show_bug.cgi?id=191043
1533         https://trac.webkit.org/changeset/237600
1534
1535         "Build fix attempt after enabling InstallAPI for iOS."
1536         https://bugs.webkit.org/show_bug.cgi?id=191043
1537         https://trac.webkit.org/changeset/237604
1538
1539 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1540
1541         Enable InstallAPI for iOS unconditionally
1542         https://bugs.webkit.org/show_bug.cgi?id=191043
1543         rdar://problem/32728423
1544
1545         Reviewed by Dan Bernstein.
1546
1547         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1548         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1549         shouldn't be processed by InstallAPI.
1550         * MigrateHeaders.make: Removed an obsolete workaround.
1551         * Misc/NSURLDownloadSPI.h: Added.
1552         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1553
1554 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1555
1556         Modernize WebKit nibs and lprojs for localization's sake
1557         https://bugs.webkit.org/show_bug.cgi?id=190911
1558         <rdar://problem/45349466>
1559
1560         Reviewed by Dan Bernstein.
1561
1562         * Misc/WebNSControlExtras.m:
1563         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1564         NSWindow and its contents are both in the same scale space these days; avoid
1565         double-applying the scale factor, or you can't see the prompt.
1566
1567         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1568         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1569         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1570         NIB->XIB
1571
1572 2018-10-25  Antoine Quint  <graouts@apple.com>
1573
1574         [Web Animations] Turn Web Animations CSS Integration off by default
1575         https://bugs.webkit.org/show_bug.cgi?id=190901
1576
1577         Reviewed by Dean Jackson.
1578
1579         * WebView/WebPreferences.mm:
1580         (+[WebPreferences initialize]):
1581
1582 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1583
1584         Clean up some obsolete macOS version guards
1585         https://bugs.webkit.org/show_bug.cgi?id=190887
1586
1587         Reviewed by Dan Bernstein.
1588
1589         * Misc/WebNSPasteboardExtras.mm:
1590         (+[NSPasteboard _web_dragTypesForURL]):
1591         * WebCoreSupport/PopupMenuMac.mm:
1592         (PopupMenuMac::show):
1593         * WebCoreSupport/WebEditorClient.h:
1594         * WebCoreSupport/WebEditorClient.mm:
1595         (WebEditorClient::respondToChangedSelection):
1596         * WebView/WebPDFView.mm:
1597         (-[WebPDFView _clipViewForPDFDocumentView]):
1598
1599 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1600
1601         Turn on Conic Gradients
1602         https://bugs.webkit.org/show_bug.cgi?id=190810
1603
1604         Reviewed by Tim Horton.
1605
1606         * Configurations/FeatureDefines.xcconfig:
1607
1608 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1609
1610         Cleanup: MIMETypeRegistry functions
1611         https://bugs.webkit.org/show_bug.cgi?id=190838
1612
1613         Reviewed by Simon Fraser.
1614
1615         * Misc/WebNSPasteboardExtras.mm:
1616         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1617         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1618         because they were identical.
1619
1620         * WebView/WebHTMLRepresentation.mm:
1621         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1622         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1623         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1624         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1625         * WebView/WebView.mm:
1626         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1627         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1628         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1629
1630 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1631
1632         Fix false positive leaks when using custom -init methods that don't start with -init
1633         <https://webkit.org/b/190818>
1634         <rdar://problem/45476042>
1635
1636         Reviewed by Dan Bernstein.
1637
1638         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1639         it is accessible by both categories.
1640         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1641         NSError (WebKitInternal) category.  Add attribute to make this
1642         behave like an -init method.
1643         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1644         NSError (WebKitInternal) category.  Modernize method.  Replace
1645         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1646
1647 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1648
1649         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1650         https://bugs.webkit.org/show_bug.cgi?id=190729
1651
1652         Reviewed by Tim Horton.
1653
1654         * DOM/DOM.mm:
1655         (-[DOMNode boundingBox]):
1656         * DOM/DOMElement.mm:
1657         * DOM/DOMHTML.mm:
1658         * DOM/DOMInternal.mm:
1659         * DOM/DOMUIKitExtensions.mm:
1660         * DOM/WebDOMOperations.mm:
1661         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1662         * DefaultDelegates/WebDefaultEditingDelegate.m:
1663         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1664         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1665         * DefaultDelegates/WebDefaultUIDelegate.h:
1666         * DefaultDelegates/WebDefaultUIDelegate.mm:
1667         (-[WebDefaultUIDelegate webViewClose:]):
1668         (-[WebDefaultUIDelegate webViewFocus:]):
1669         (-[WebDefaultUIDelegate webViewUnfocus:]):
1670         (-[WebDefaultUIDelegate webViewIsResizable:]):
1671         (-[WebDefaultUIDelegate webView:setResizable:]):
1672         (-[WebDefaultUIDelegate webView:setFrame:]):
1673         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1674         * History/BackForwardList.h:
1675         * History/BackForwardList.mm:
1676         * History/WebBackForwardList.mm:
1677         (+[WebBackForwardList initialize]):
1678         (bumperCarBackForwardHackNeeded):
1679         * History/WebHistory.mm:
1680         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1681         (-[WebHistory _sendNotification:entries:]):
1682         (-[WebHistory loadFromURL:error:]):
1683         (-[WebHistory saveToURL:error:]):
1684         * History/WebHistoryItem.mm:
1685         (WKNotifyHistoryItemChanged):
1686         (+[WebHistoryItem initialize]):
1687         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1688         * History/WebURLsWithTitles.m:
1689         * Misc/WebCache.mm:
1690         (+[WebCache initialize]):
1691         * Misc/WebDownload.mm:
1692         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1693         * Misc/WebElementDictionary.mm:
1694         (+[WebElementDictionary initialize]):
1695         (+[WebElementDictionary initializeLookupTable]):
1696         * Misc/WebIconDatabase.mm:
1697         * Misc/WebKitNSStringExtras.mm:
1698         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1699         * Misc/WebKitVersionChecks.h:
1700         * Misc/WebKitVersionChecks.mm:
1701         (WebKitLinkedOnOrAfter):
1702         (WebKitLinkTimeVersion):
1703         * Misc/WebLocalizableStrings.mm:
1704         * Misc/WebNSControlExtras.h:
1705         * Misc/WebNSControlExtras.m:
1706         * Misc/WebNSEventExtras.m:
1707         * Misc/WebNSFileManagerExtras.mm:
1708         * Misc/WebNSImageExtras.h:
1709         * Misc/WebNSImageExtras.m:
1710         * Misc/WebNSPasteboardExtras.mm:
1711         * Misc/WebNSPrintOperationExtras.h:
1712         * Misc/WebNSPrintOperationExtras.m:
1713         * Misc/WebNSViewExtras.m:
1714         * Misc/WebNSWindowExtras.m:
1715         * Panels/WebAuthenticationPanel.h:
1716         * Panels/WebAuthenticationPanel.m:
1717         * Panels/WebPanelAuthenticationHandler.m:
1718         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1719         (+[WebHostedNetscapePluginView initialize]):
1720         * Plugins/WebBasePluginPackage.h:
1721         * Plugins/WebBasePluginPackage.mm:
1722         * Plugins/WebJavaPlugIn.h:
1723         * Plugins/WebPluginContainerCheck.mm:
1724         * Plugins/WebPluginController.h:
1725         * Plugins/WebPluginController.mm:
1726         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1727         (-[WebPluginController addPlugin:]):
1728         (-[WebPluginController destroyPlugin:]):
1729         (-[WebPluginController destroyAllPlugins]):
1730         * Plugins/WebPluginDatabase.mm:
1731         (+[WebPluginDatabase _defaultPlugInPaths]):
1732         * Plugins/WebPluginPackage.mm:
1733         (-[WebPluginPackage initWithPath:]):
1734         * Storage/WebDatabaseManager.mm:
1735         (-[WebDatabaseManager deleteAllDatabases]):
1736         * Storage/WebDatabaseManagerClient.h:
1737         * Storage/WebDatabaseManagerClient.mm:
1738         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1739         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1740         * Storage/WebStorageManager.mm:
1741         (-[WebStorageManager deleteAllOrigins]):
1742         (WebKitInitializeStorageIfNecessary):
1743         * WebCoreSupport/WebAlternativeTextClient.h:
1744         * WebCoreSupport/WebApplicationCache.mm:
1745         (applicationCacheBundleIdentifier):
1746         * WebCoreSupport/WebChromeClient.h:
1747         * WebCoreSupport/WebChromeClient.mm:
1748         (WebChromeClient::setWindowRect):
1749         (WebChromeClient::windowRect):
1750         (WebChromeClient::takeFocus):
1751         (WebChromeClient::addMessageToConsole):
1752         (WebChromeClient::enableSuddenTermination):
1753         (WebChromeClient::disableSuddenTermination):
1754         (WebChromeClient::createPopupMenu const):
1755         (WebChromeClient::createSearchPopupMenu const):
1756         (WebChromeClient::shouldPaintEntireContents const):
1757         (WebChromeClient::supportsVideoFullscreen):
1758         (WebChromeClient::supportsFullScreenForElement):
1759         (WebChromeClient::enterFullScreenForElement):
1760         (WebChromeClient::exitFullScreenForElement):
1761         * WebCoreSupport/WebContextMenuClient.mm:
1762         * WebCoreSupport/WebDragClient.mm:
1763         * WebCoreSupport/WebEditorClient.h:
1764         * WebCoreSupport/WebEditorClient.mm:
1765         (+[WebUndoStep initialize]):
1766         (updateFontPanel):
1767         (WebEditorClient::didBeginEditing):
1768         (WebEditorClient::respondToChangedContents):
1769         (WebEditorClient::respondToChangedSelection):
1770         (WebEditorClient::canceledComposition):
1771         (WebEditorClient::didEndEditing):
1772         (WebEditorClient::didWriteSelectionToPasteboard):
1773         (attributesForAttributedStringConversion):
1774         (WebEditorClient::setInsertionPasteboard):
1775         (WebEditorClient::registerUndoOrRedoStep):
1776         (WebEditorClient::handleKeyboardEvent):
1777         (WebEditorClient::handleInputMethodKeydown):
1778         (WebEditorClient::textDidChangeInTextField):
1779         (WebEditorClient::requestCheckingOfString):
1780         * WebCoreSupport/WebFrameLoaderClient.h:
1781         * WebCoreSupport/WebFrameLoaderClient.mm:
1782         (WebFrameLoaderClient::detachedFromParent2):
1783         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1784         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1785         (WebFrameLoaderClient::dispatchWillSendRequest):
1786         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1787         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1788         (WebFrameLoaderClient::willCacheResponse const):
1789         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1790         (WebFrameLoaderClient::dispatchDidFinishLoading):
1791         (WebFrameLoaderClient::dispatchDidFailLoading):
1792         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1793         (WebFrameLoaderClient::dispatchWillClose):
1794         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1795         (WebFrameLoaderClient::dispatchDidCommitLoad):
1796         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1797         (WebFrameLoaderClient::dispatchDidFailLoad):
1798         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1799         (WebFrameLoaderClient::dispatchDidFinishLoad):
1800         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1801         (WebFrameLoaderClient::willChangeTitle):
1802         (WebFrameLoaderClient::didChangeTitle):
1803         (WebFrameLoaderClient::didReplaceMultipartContent):
1804         (WebFrameLoaderClient::updateGlobalHistory):
1805         (WebFrameLoaderClient::saveViewStateToItem):
1806         (WebFrameLoaderClient::restoreViewState):
1807         (WebFrameLoaderClient::provisionalLoadStarted):
1808         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1809         (WebFrameLoaderClient::setTitle):
1810         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1811         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1812         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1813         (WebFrameLoaderClient::didRestoreFromPageCache):
1814         (WebFrameLoaderClient::actionDictionary const):
1815         (WebFrameLoaderClient::createPlugin):
1816         (WebFrameLoaderClient::getLoadDecisionForIcons):
1817         (WebFrameLoaderClient::finishedLoadingIcon):
1818         (+[WebFramePolicyListener initialize]):
1819         * WebCoreSupport/WebFrameNetworkingContext.mm:
1820         * WebCoreSupport/WebGeolocationClient.h:
1821         * WebCoreSupport/WebGeolocationClient.mm:
1822         (WebGeolocationClient::requestPermission):
1823         * WebCoreSupport/WebInspectorClient.h:
1824         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1825         * WebCoreSupport/WebNotificationClient.mm:
1826         * WebCoreSupport/WebOpenPanelResultListener.mm:
1827         * WebCoreSupport/WebPlatformStrategies.h:
1828         * WebCoreSupport/WebPlatformStrategies.mm:
1829         * WebCoreSupport/WebProgressTrackerClient.h:
1830         * WebCoreSupport/WebProgressTrackerClient.mm:
1831         (WebProgressTrackerClient::progressStarted):
1832         (WebProgressTrackerClient::progressEstimateChanged):
1833         (WebProgressTrackerClient::progressFinished):
1834         * WebCoreSupport/WebSecurityOrigin.mm:
1835         * WebInspector/WebNodeHighlight.h:
1836         * WebInspector/WebNodeHighlight.mm:
1837         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1838         (-[WebNodeHighlight dealloc]):
1839         (-[WebNodeHighlight attach]):
1840         * WebInspector/WebNodeHighlightView.h:
1841         * WebInspector/WebNodeHighlightView.mm:
1842         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1843         (-[WebNodeHighlightView dealloc]):
1844         * WebInspector/WebNodeHighlighter.mm:
1845         (-[WebNodeHighlighter highlight]):
1846         * WebView/WebArchive.mm:
1847         (+[WebArchivePrivate initialize]):
1848         * WebView/WebClipView.h:
1849         * WebView/WebDataSource.mm:
1850         (WebDataSourcePrivate::WebDataSourcePrivate):
1851         (+[WebDataSource initialize]):
1852         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1853         (-[WebDataSource _makeRepresentation]):
1854         * WebView/WebDelegateImplementationCaching.h:
1855         * WebView/WebDelegateImplementationCaching.mm:
1856         (CallDelegate):
1857         (CallDelegateReturningFloat):
1858         (CallDelegateReturningBoolean):
1859         (CallUIDelegate):
1860         (CallUIDelegateReturningFloat):
1861         (CallUIDelegateReturningBoolean):
1862         (CallFrameLoadDelegate):
1863         (CallFrameLoadDelegateReturningBoolean):
1864         (CallResourceLoadDelegate):
1865         (CallScriptDebugDelegate):
1866         (CallFormDelegate):
1867         (CallFormDelegateReturningBoolean):
1868         * WebView/WebDeviceOrientation.mm:
1869         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1870         * WebView/WebDocumentInternal.h:
1871         * WebView/WebDocumentLoaderMac.mm:
1872         (needsDataLoadWorkaround):
1873         * WebView/WebDynamicScrollBarsViewInternal.h:
1874         * WebView/WebFormDelegate.m:
1875         * WebView/WebFrame.mm:
1876         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1877         (-[WebFrame _unmarkAllMisspellings]):
1878         (-[WebFrame _paintBehaviorForDestinationContext:]):
1879         (-[WebFrame _drawRect:contentsOnly:]):
1880         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1881         (-[WebFrame _scrollDOMRangeToVisible:]):
1882         (-[WebFrame _bodyBackgroundColor]):
1883         (-[WebFrame accessibilityRoot]):
1884         (needsMicrosoftMessengerDOMDocumentWorkaround):
1885         * WebView/WebFrameInternal.h:
1886         * WebView/WebFrameView.mm:
1887         (-[WebFrameView _setDocumentView:]):
1888         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1889         (-[WebFrameView _viewClassForMIMEType:]):
1890         (-[WebFrameView initWithFrame:]):
1891         (-[WebFrameView drawRect:]):
1892         (-[WebFrameView _firstResponderIsFormControl]):
1893         (-[WebFrameView keyDown:keyDown:]):
1894         (-[WebFrameView _isScrollable]):
1895         * WebView/WebFullScreenController.h:
1896         * WebView/WebFullScreenController.mm:
1897         * WebView/WebHTMLRepresentation.mm:
1898         * WebView/WebHTMLView.mm:
1899         (-[WebHTMLView hitTest:]):
1900         (-[WebHTMLView initWithFrame:]):
1901         (-[WebHTMLView dealloc]):
1902         (-[WebHTMLView addSubview:]):
1903         (-[WebHTMLView mouseDown:]):
1904         (-[WebHTMLView mouseUp:]):
1905         (-[WebHTMLView resignFirstResponder]):
1906         (-[WebHTMLView accessibilityHitTest:]):
1907         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1908         * WebView/WebHTMLViewInternal.h:
1909         * WebView/WebIndicateLayer.h:
1910         * WebView/WebIndicateLayer.mm:
1911         * WebView/WebMediaPlaybackTargetPicker.h:
1912         * WebView/WebMediaPlaybackTargetPicker.mm:
1913         * WebView/WebPDFDocumentExtras.h:
1914         * WebView/WebPDFDocumentExtras.mm:
1915         * WebView/WebPDFRepresentation.h:
1916         * WebView/WebPDFRepresentation.mm:
1917         * WebView/WebPDFView.h:
1918         * WebView/WebPreferences.mm:
1919         (cacheModelForMainBundle):
1920         (WebPreferencesPrivate::WebPreferencesPrivate):
1921         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1922         (-[WebPreferences encodeWithCoder:]):
1923         (+[WebPreferences standardPreferences]):
1924         (+[WebPreferences initialize]):
1925         (-[WebPreferences _valueForKey:]):
1926         (-[WebPreferences _setStringValue:forKey:]):
1927         (-[WebPreferences _setIntegerValue:forKey:]):
1928         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1929         (-[WebPreferences _setFloatValue:forKey:]):
1930         (-[WebPreferences _setBoolValue:forKey:]):
1931         (-[WebPreferences _setLongLongValue:forKey:]):
1932         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1933         (-[WebPreferences _postCacheModelChangedNotification]):
1934         (-[WebPreferences _postPreferencesChangedNotification]):
1935         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1936         (-[WebPreferences setStorageBlockingPolicy:]):
1937         * WebView/WebResource.mm:
1938         (+[WebResourcePrivate initialize]):
1939         * WebView/WebTextCompletionController.h:
1940         * WebView/WebTextIterator.mm:
1941         (+[WebTextIteratorPrivate initialize]):
1942         * WebView/WebView.mm:
1943         (shouldEnableLoadDeferring):
1944         (shouldRestrictWindowFocus):
1945         (shouldRespectPriorityInCSSAttributeSetters):
1946         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1947         (shouldAllowPictureInPictureMediaPlayback):
1948         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1949         (shouldAllowWindowOpenWithoutUserGesture):
1950         (shouldConvertInvalidURLsToBlank):
1951         (shouldRequireUserGestureToLoadVideo):
1952         (-[WebView _commonInitializationWithFrameName:groupName:]):
1953         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1954         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1955         (-[WebView _closePluginDatabases]):
1956         (-[WebView _closeWithFastTeardown]):
1957         (-[WebView _close]):
1958         (+[WebView _MIMETypeForFile:]):
1959         (-[WebView setShowingInspectorIndication:]):
1960         (-[WebView _setFormDelegate:]):
1961         (-[WebView _needsPreHTML5ParserQuirks]):
1962         (-[WebView _preferencesChangedNotification:]):
1963         (-[WebView _preferencesChanged:]):
1964         (-[WebView _cacheResourceLoadDelegateImplementations]):
1965         (-[WebView _cacheFrameLoadDelegateImplementations]):
1966         (-[WebView _policyDelegateForwarder]):
1967         (-[WebView _UIDelegateForwarder]):
1968         (-[WebView _editingDelegateForwarder]):
1969         (-[WebView _updateActiveState]):
1970         (-[_WebSafeForwarder forwardInvocation:]):
1971         (+[WebView initialize]):
1972         (-[WebView _pluginForMIMEType:]):
1973         (-[WebView _pluginForExtension:]):
1974         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1975         (+[WebView canShowMIMETypeAsHTML:]):
1976         (-[WebView _initWithArguments:]):
1977         (-[WebView initWithFrame:frameName:groupName:]):
1978         (-[WebView dealloc]):
1979         (-[WebView close]):
1980         (-[WebView viewDidMoveToWindow]):
1981         (-[WebView setUIDelegate:]):
1982         (-[WebView setResourceLoadDelegate:]):
1983         (-[WebView setPolicyDelegate:]):
1984         (-[WebView setFrameLoadDelegate:]):
1985         (-[WebView goBack]):
1986         (-[WebView goForward]):
1987         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1988         (-[WebView setHostWindow:]):
1989         (-[WebView becomeFirstResponder]):
1990         (+[WebView _cacheModelChangedNotification:]):
1991         (-[WebView _frameViewAtWindowPoint:]):
1992         (+[WebView _preflightSpellCheckerNow:]):
1993         (+[WebView _preflightSpellChecker]):
1994         (-[WebView canGoBack]):
1995         (-[WebView canGoForward]):
1996         (-[WebView stopLoading:]):
1997         (-[WebView reload:]):
1998         (-[WebView setMainFrameDocumentReady:]):
1999         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2000         (-[WebView setContinuousSpellCheckingEnabled:]):
2001         (-[WebView undoManager]):
2002         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2003         (-[WebView isAutomaticLinkDetectionEnabled]):
2004         (-[WebView isAutomaticDashSubstitutionEnabled]):
2005         (-[WebView isAutomaticTextReplacementEnabled]):
2006         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2007         (+[WebView _setCacheModel:]):
2008         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2009         (-[WebView _keyboardUIMode]):
2010         (LayerFlushController::flushLayers):
2011         (-[WebView _scheduleCompositingLayerFlush]):
2012         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2013         (-[WebView fullScreenPlaceholderView]):
2014         (WebInstallMemoryPressureHandler):
2015         * WebView/WebViewData.h:
2016         * WebView/WebViewData.mm:
2017         (+[WebViewPrivate initialize]):
2018         (-[WebViewPrivate init]):
2019         (-[WebViewPrivate dealloc]):
2020         * WebView/WebViewInternal.h:
2021
2022 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2023
2024         Clean up FrameLoader two-state enums
2025         https://bugs.webkit.org/show_bug.cgi?id=190731
2026
2027         Reviewed by Chris Dumez.
2028
2029         * WebCoreSupport/WebFrameLoaderClient.h:
2030         * WebCoreSupport/WebFrameLoaderClient.mm:
2031         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2032
2033 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2034
2035         Unreviewed, rolling out r237137.
2036
2037         SPI is actually used
2038
2039         Reverted changeset:
2040
2041         "Remove unused WebFrame._loadType"
2042         https://bugs.webkit.org/show_bug.cgi?id=190583
2043         https://trac.webkit.org/changeset/237137
2044
2045 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2046
2047         Enable the datalist element by default on iOS and macOS
2048         https://bugs.webkit.org/show_bug.cgi?id=190594
2049         <rdar://problem/45281159>
2050
2051         Reviewed by Ryosuke Niwa and Tim Horton.
2052
2053         * Configurations/FeatureDefines.xcconfig:
2054
2055 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2056
2057         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2058         https://bugs.webkit.org/show_bug.cgi?id=190675
2059
2060         Reviewed by Chris Dumez.
2061
2062         * History/BackForwardList.h:
2063         * History/BackForwardList.mm:
2064         (BackForwardList::backItem):
2065         (BackForwardList::currentItem):
2066         (BackForwardList::forwardItem):
2067         (BackForwardList::backListCount const):
2068         (BackForwardList::forwardListCount const):
2069         (BackForwardList::itemAtIndex):
2070         * History/WebBackForwardList.mm:
2071         (-[WebBackForwardList backItem]):
2072         (-[WebBackForwardList currentItem]):
2073         (-[WebBackForwardList forwardItem]):
2074         (-[WebBackForwardList itemAtIndex:]):
2075
2076 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2077
2078         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2079         https://bugs.webkit.org/show_bug.cgi?id=190526
2080         rdar://problem/45230140
2081
2082         Reviewed by Dean Jackson.
2083
2084         * WebCoreSupport/WebEditorClient.mm:
2085         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2086
2087 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2088
2089         Implement feature flag and bindings for CSS Painting API
2090         https://bugs.webkit.org/show_bug.cgi?id=190237
2091
2092         Reviewed by Ryosuke Niwa.
2093
2094         * Configurations/FeatureDefines.xcconfig:
2095
2096 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2097
2098         Replace HistoryItem* with HistoryItem& where possible
2099         https://bugs.webkit.org/show_bug.cgi?id=190617
2100
2101         Reviewed by Chris Dumez.
2102
2103         * History/BackForwardList.h:
2104         * History/BackForwardList.mm:
2105         (BackForwardList::goToItem):
2106         * History/WebBackForwardList.mm:
2107         (-[WebBackForwardList goToItem:]):
2108         * History/WebHistoryItem.mm:
2109         (WKNotifyHistoryItemChanged):
2110         * History/WebHistoryItemInternal.h:
2111
2112 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2113
2114         Remove unused WebHistoryItem._transientPropertyForKey
2115         https://bugs.webkit.org/show_bug.cgi?id=190606
2116
2117         Reviewed by Chris Dumez.
2118
2119         * History/WebHistoryItem.mm:
2120         * History/WebHistoryItemPrivate.h:
2121
2122 2018-10-15  Justin Fan  <justin_fan@apple.com>
2123
2124         Add WebGPU 2018 feature flag and experimental feature flag
2125         https://bugs.webkit.org/show_bug.cgi?id=190509
2126
2127         Reviewed by Dean Jackson.
2128
2129         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2130         for the 2018 WebGPU prototype.
2131
2132         * Configurations/FeatureDefines.xcconfig:
2133         * WebView/WebPreferenceKeysPrivate.h:
2134         * WebView/WebPreferences.mm:
2135         (+[WebPreferences initialize]):
2136         (-[WebPreferences webGPUEnabled]):
2137         (-[WebPreferences setWebGPUEnabled:]):
2138         * WebView/WebPreferencesPrivate.h:
2139         * WebView/WebView.mm:
2140         (-[WebView _preferencesChanged:]):
2141
2142 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2143
2144         Fix iOS build after r237157
2145
2146         * WebView/WebView.mm:
2147         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2148
2149 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2150
2151         Modernize BackForwardClient.h
2152         https://bugs.webkit.org/show_bug.cgi?id=190610
2153
2154         Reviewed by Chris Dumez.
2155
2156         * History/BackForwardList.h:
2157         * History/BackForwardList.mm:
2158         (BackForwardList::backListCount const):
2159         (BackForwardList::forwardListCount const):
2160         (BackForwardList::backListCount): Deleted.
2161         (BackForwardList::forwardListCount): Deleted.
2162         * History/WebBackForwardList.mm:
2163         (-[WebBackForwardList init]):
2164         * WebCoreSupport/WebFrameLoaderClient.mm:
2165         (WebFrameLoaderClient::canCachePage const):
2166         * WebView/WebFrameView.mm:
2167         (-[WebFrameView keyDown:keyDown:]):
2168         * WebView/WebView.mm:
2169         (-[WebView _commonInitializationWithFrameName:groupName:]):
2170         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2171         (-[WebView _loadBackForwardListFromOtherView:]):
2172         (-[WebView initWithCoder:]):
2173         (-[WebView encodeWithCoder:]):
2174         (-[WebView backForwardList]):
2175         (-[WebView setMaintainsBackForwardList:]):
2176
2177 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2178
2179         Add support for prefers-color-scheme media query
2180         https://bugs.webkit.org/show_bug.cgi?id=190499
2181         rdar://problem/45212025
2182
2183         Reviewed by Dean Jackson.
2184
2185         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2186
2187 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2188
2189         Remove unused WebView._globalHistoryItem
2190         https://bugs.webkit.org/show_bug.cgi?id=190601
2191
2192         Reviewed by Chris Dumez.
2193
2194         * WebCoreSupport/WebFrameLoaderClient.h:
2195         * WebCoreSupport/WebFrameLoaderClient.mm:
2196         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2197         * WebView/WebView.mm:
2198         (-[WebView _globalHistoryItem]): Deleted.
2199         (-[WebView _setGlobalHistoryItem:]): Deleted.
2200         * WebView/WebViewData.h:
2201         * WebView/WebViewInternal.h:
2202         * WebView/WebViewPrivate.h:
2203
2204 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2205
2206         Remove unused parameters from FrameLoaderClient::createFrame
2207         https://bugs.webkit.org/show_bug.cgi?id=190587
2208
2209         Reviewed by Chris Dumez.
2210
2211         * WebCoreSupport/WebFrameLoaderClient.h:
2212         * WebCoreSupport/WebFrameLoaderClient.mm:
2213         (WebFrameLoaderClient::createFrame):
2214
2215 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2216
2217         Remove unused WebFrame._loadType
2218         https://bugs.webkit.org/show_bug.cgi?id=190583
2219
2220         Reviewed by Chris Dumez.
2221
2222         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2223
2224         * WebView/WebFrame.mm:
2225         (toWebFrameLoadType): Deleted.
2226         (-[WebFrame _loadType]): Deleted.
2227         * WebView/WebFramePrivate.h:
2228
2229 2018-10-15  Chris Dumez  <cdumez@apple.com>
2230
2231         Restrict browsing context lookup by name to frames that are related to one another
2232         https://bugs.webkit.org/show_bug.cgi?id=190475
2233
2234         Reviewed by Alex Christensen.
2235
2236         * WebView/WebFrame.mm:
2237         (-[WebFrame findFrameNamed:]):
2238
2239 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2240
2241         Remove InjectedBundle processing of back/forward lists
2242         https://bugs.webkit.org/show_bug.cgi?id=190459
2243
2244         Reviewed by Chris Dumez.
2245
2246         * WebCoreSupport/WebFrameLoaderClient.h:
2247         * WebCoreSupport/WebFrameLoaderClient.mm:
2248         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2249
2250 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2251
2252         [JSC] Remove Option::useAsyncIterator
2253         https://bugs.webkit.org/show_bug.cgi?id=190567
2254
2255         Reviewed by Saam Barati.
2256
2257         * Configurations/FeatureDefines.xcconfig:
2258
2259 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2260
2261         Allow encoding of small enum classes
2262         https://bugs.webkit.org/show_bug.cgi?id=190531
2263
2264         Reviewed by Tim Horton.
2265
2266         * WebCoreSupport/WebFrameLoaderClient.mm:
2267         (-[WebFramePolicyListener dealloc]):
2268
2269 2018-10-11  Keith Rollin  <krollin@apple.com>
2270
2271         CURRENT_ARCH should not be used in Run Script phase.
2272         https://bugs.webkit.org/show_bug.cgi?id=190407
2273         <rdar://problem/45133556>
2274
2275         Reviewed by Alexey Proskuryakov.
2276
2277         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2278         CURRENT_ARCH is not well-defined during this phase (and may even have
2279         the value "undefined") since this phase is run just once per build
2280         rather than once per supported architecture. Migrate away from
2281         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2282         performing an operation for each value, or by picking the first entry
2283         in ARCHS and using that as a representative value.
2284
2285         * Configurations/WebKitLegacy.xcconfig: When generating
2286         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2287         macosx platforms.
2288
2289         * MigrateHeaders.make:
2290         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2291         generate one for each architecture in ARCHS.
2292
2293 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2294
2295         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2296         https://bugs.webkit.org/show_bug.cgi?id=190429
2297
2298         Reviewed by Saam Barati.
2299
2300         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2301
2302         * WebView/WebPDFRepresentation.mm:
2303         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2304
2305 2018-10-08  Justin Fan  <justin_fan@apple.com>
2306
2307         WebGPU: Rename old WebGPU prototype to WebMetal
2308         https://bugs.webkit.org/show_bug.cgi?id=190325
2309         <rdar://problem/44990443>
2310
2311         Reviewed by Dean Jackson.
2312
2313         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2314
2315         * Configurations/FeatureDefines.xcconfig:
2316         * WebView/WebPreferenceKeysPrivate.h:
2317         * WebView/WebPreferences.mm:
2318         (+[WebPreferences initialize]):
2319         (-[WebPreferences webMetalEnabled]):
2320         (-[WebPreferences setWebMetalEnabled:]):
2321         (-[WebPreferences webGPUEnabled]): Deleted.
2322         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2323         * WebView/WebPreferencesPrivate.h:
2324         * WebView/WebView.mm:
2325         (-[WebView _preferencesChanged:]):
2326
2327 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2328
2329         Make <input type=color> a runtime enabled (on-by-default) feature
2330         https://bugs.webkit.org/show_bug.cgi?id=189162
2331
2332         Reviewed by Wenson Hsieh and Tim Horton.
2333
2334         * Configurations/FeatureDefines.xcconfig:
2335
2336 2018-10-07  Dan Bernstein  <mitz@apple.com>
2337
2338         Fixed building with the latest macOS SDK
2339
2340         * Plugins/WebNetscapePluginPackage.mm:
2341         (-[WebNetscapePluginPackage openResourceFile]):
2342         (-[WebNetscapePluginPackage closeResourceFile:]):
2343
2344 2018-10-04  Dan Bernstein  <mitz@apple.com>
2345
2346         More Carbon build-fixing.
2347
2348         * Carbon/CarbonWindowAdapter.mm:
2349         (-[CarbonWindowAdapter _destroyRealWindow:]):
2350         (-[CarbonWindowAdapter _growBoxRect]):
2351
2352 2018-10-04  Dan Bernstein  <mitz@apple.com>
2353
2354         Retried to fix 32-bit macOS builds after r236846.
2355
2356         * WebView/WebHTMLView.mm:
2357         (-[WebHTMLView setMarkedText:selectedRange:]):
2358
2359 2018-10-04  Dan Bernstein  <mitz@apple.com>
2360
2361         Retried to fix 32-bit macOS builds after r236846.
2362
2363         * Carbon/HIWebView.mm:
2364         (ActiveStateChanged):
2365
2366 2018-10-04  Dan Bernstein  <mitz@apple.com>
2367
2368         Tried to fix 32-bit macOS builds after r236846.
2369
2370         * Carbon/HIWebView.mm:
2371         (_NSSelectorForHICommand):
2372
2373 2018-10-04  Dan Bernstein  <mitz@apple.com>
2374
2375         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2376         https://bugs.webkit.org/show_bug.cgi?id=190250
2377
2378         Reviewed by Andy Estes.
2379
2380         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2381           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2382           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2383           an earlier line set it to YES.
2384
2385         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2386         changes below.
2387
2388         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2389           provides some missing method declarations.
2390
2391         * Misc/WebDownload.mm:
2392         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2393           a deprecated method.
2394
2395         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2396
2397         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2398           other code in the file uses a method from it.
2399
2400         * Plugins/WebBaseNetscapePluginView.mm:
2401         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2402           a deprecated method.
2403
2404         * Plugins/WebPluginController.mm:
2405         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2406           around use of a selector that may be present in some WebKit client.
2407
2408         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2409           method declarations.
2410
2411         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2412           from here.
2413
2414         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2415           missing method declarations.
2416
2417         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2418           from here.
2419
2420         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2421           call from here.
2422         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2423           an obsolete delegate method for binary compatibility.
2424         (pluginView): Ditto.
2425
2426         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2427           call from here.
2428
2429         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2430           WebDeviceOrientationProviderMock protocol.
2431
2432         * WebView/WebDeviceOrientationProviderMock.mm:
2433         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2434           main @implementation.
2435
2436         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2437           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2438
2439         * WebView/WebDynamicScrollBarsView.mm:
2440         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2441           of a deprecated method.
2442
2443         * WebView/WebHTMLView.mm:
2444         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2445           selector warning around action methods that are not declared anywhere in WebKit.
2446
2447         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2448           about implementing this deprecated method.
2449         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2450         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2451         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2452         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2453         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2454         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2455         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2456         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2457         (-[WebHTMLView doCommandBySelector:]): Ditto.
2458         (-[WebHTMLView insertText:]): Ditto.
2459
2460         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2461
2462         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2463
2464         * WebView/WebPDFView.h: Removed previewView ivar.
2465
2466         * WebView/WebPDFView.mm:
2467           Removed declaration of FileInternal category and merged its implementation with the main
2468           implementation.
2469         (-[WebPDFView dealloc]): Removed previewView ivar.
2470         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2471           exist in macOS versions we support.
2472         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2473         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2474           action methods internal to PDFKit.
2475         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2476         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2477
2478         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2479           call on macOS, even though in r86988 we started calling different methods on iOS.
2480
2481         * WebView/WebView.mm:
2482         - Imported headers that declare delegate methods that we call.
2483         - Removed declaration of WebFileInternal category and merged its implementation with the
2484           main implementation.
2485         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2486           category, which made them impossible to call from the main implementation. Moved those
2487           into the main implementation. One of those had to be declared in a class extension,
2488           because it is called from a method implemented in the WebPrivate category, and that
2489           category’s implementation appears first in the file.
2490
2491         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2492           around use of obsolete delegate method for binary compatibility.
2493
2494         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2495
2496 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2497
2498         Runtime flag and IDL for MediaRecorder
2499         https://bugs.webkit.org/show_bug.cgi?id=190018
2500
2501         Reviewed by Youenn Fablet and Chris Dumez.
2502
2503         * WebView/WebPreferenceKeysPrivate.h:
2504         * WebView/WebPreferences.mm:
2505         (+[WebPreferences initialize]):
2506         (-[WebPreferences mediaRecorderEnabled]):
2507         (-[WebPreferences setMediaRecorderEnabled:]):
2508         * WebView/WebPreferencesPrivate.h:
2509         * WebView/WebView.mm:
2510         (-[WebView _preferencesChanged:]):
2511
2512 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2515         https://bugs.webkit.org/show_bug.cgi?id=190238
2516
2517         Reviewed by Antti Koivisto.
2518
2519         Enabled the feature by default.
2520
2521         * WebView/WebPreferences.mm:
2522         (+[WebPreferences initialize]):
2523
2524 2018-10-01  Dean Jackson  <dino@apple.com>
2525
2526         [macOS] Switching to discrete GPU should be done in the UI process
2527         https://bugs.webkit.org/show_bug.cgi?id=189361
2528         <rdar://problem/43949622>
2529
2530         Reviewed by Simon Fraser.
2531
2532         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2533         not support swapping to the discrete GPU in this configuration.
2534
2535         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2536         (WebKit::WebSwitchingGPUClient::singleton):
2537         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2538         * WebView/WebView.mm:
2539         (-[WebView _commonInitializationWithFrameName:groupName:]):
2540
2541 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2542
2543         Remove ParsedURLString
2544         https://bugs.webkit.org/show_bug.cgi?id=190154
2545
2546         Reviewed by Chris Dumez.
2547
2548         * WebView/WebScriptDebugger.mm:
2549         (toNSURL):
2550
2551 2018-10-01  Dean Jackson  <dino@apple.com>
2552
2553         Remove CSS Animation Triggers
2554         https://bugs.webkit.org/show_bug.cgi?id=190175
2555         <rdar://problem/44925626>
2556
2557         Reviewed by Simon Fraser.
2558
2559         * Configurations/FeatureDefines.xcconfig:
2560
2561 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2562
2563         Unreviewed, rolling out r236624 and r236671.
2564         https://bugs.webkit.org/show_bug.cgi?id=190207
2565
2566         The change in r236624 introduced crashes on the bots
2567         (Requested by ryanhaddad on #webkit).
2568
2569         Reverted changesets:
2570
2571         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2572         https://bugs.webkit.org/show_bug.cgi?id=188747
2573         https://trac.webkit.org/changeset/236624
2574
2575         "Unify implementation in VideoFullscreenInterfaceAVKit"
2576         https://bugs.webkit.org/show_bug.cgi?id=190091
2577         https://trac.webkit.org/changeset/236671
2578
2579 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2580
2581         URL should not use TextEncoding internally
2582         https://bugs.webkit.org/show_bug.cgi?id=190111
2583
2584         Reviewed by Andy Estes.
2585
2586         * Misc/WebNSURLExtras.mm:
2587
2588 2018-09-28  Jer Noble  <jer.noble@apple.com>
2589
2590         Refactoring: eliminate raw pointer usage in Fullscreen code
2591         https://bugs.webkit.org/show_bug.cgi?id=188747
2592         <rdar://problem/43541164>
2593
2594         Reviewed by Alex Christensen.
2595
2596         PlaybackSessionInterface no longer has an invalidate() method.
2597
2598         * WebView/WebView.mm:
2599         (-[WebView _clearPlaybackControlsManager]):
2600
2601 2018-09-28  Chris Dumez  <cdumez@apple.com>
2602
2603         Drop support for cross-origin-window-policy header
2604         https://bugs.webkit.org/show_bug.cgi?id=190081
2605
2606         Reviewed by Ryosuke Niwa.
2607
2608         * WebView/WebPreferenceKeysPrivate.h:
2609         * WebView/WebPreferences.mm:
2610         (+[WebPreferences initialize]):
2611         * WebView/WebPreferencesPrivate.h:
2612         * WebView/WebView.mm:
2613         (-[WebView _preferencesChanged:]):
2614
2615 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2616
2617         Rename createMarkup to serializePreservingVisualAppearance
2618         https://bugs.webkit.org/show_bug.cgi?id=190086
2619
2620         Reviewed by Wenson Hsieh.
2621
2622         * DOM/WebDOMOperations.mm:
2623         (-[DOMRange markupString]):
2624
2625 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2626
2627         Unreviewed, rolling out r236605.
2628         https://bugs.webkit.org/show_bug.cgi?id=190087
2629
2630         caused three API test timeouts (Requested by jernoble on
2631         #webkit).
2632
2633         Reverted changeset:
2634
2635         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2636         https://bugs.webkit.org/show_bug.cgi?id=188747
2637         https://trac.webkit.org/changeset/236605
2638
2639 2018-09-28  Jer Noble  <jer.noble@apple.com>
2640
2641         Refactoring: eliminate raw pointer usage in Fullscreen code
2642         https://bugs.webkit.org/show_bug.cgi?id=188747
2643         <rdar://problem/43541164>
2644
2645         Reviewed by Alex Christensen.
2646
2647         PlaybackSessionInterface no longer has an invalidate() method.
2648
2649         * WebView/WebView.mm:
2650         (-[WebView _clearPlaybackControlsManager]):
2651
2652 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2653
2654         Use enum class in createMarkup arguments
2655         https://bugs.webkit.org/show_bug.cgi?id=190028
2656
2657         Reviewed by Wenson Hsieh.
2658
2659         * DOM/WebDOMOperations.mm:
2660         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2661         (-[DOMRange markupString]): Ditto.
2662
2663 2018-09-27  Antoine Quint  <graouts@apple.com>
2664
2665         [Web Animations] Turn Web Animations with CSS integration on
2666         https://bugs.webkit.org/show_bug.cgi?id=184819
2667         <rdar://problem/39597337>
2668
2669         Reviewed by Dean Jackson.
2670
2671         * WebView/WebPreferences.mm:
2672         (+[WebPreferences initialize]):
2673
2674 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         Selection should work across shadow boundary when initiated by a mouse drag
2677         https://bugs.webkit.org/show_bug.cgi?id=151380
2678         <rdar://problem/24363872>
2679
2680         Reviewed by Wenson Hsieh.
2681
2682         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2683
2684         * WebView/WebPreferenceKeysPrivate.h:
2685         * WebView/WebPreferences.mm:
2686         (+[WebPreferences initialize]):
2687         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2688         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2689         * WebView/WebPreferencesPrivate.h:
2690         * WebView/WebView.mm:
2691         (-[WebView _preferencesChanged:]):
2692
2693 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2694
2695         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2696         https://bugs.webkit.org/show_bug.cgi?id=189918
2697         Work towards <rdar://problem/44648705>
2698
2699         Reviewed by Tim Horton.
2700
2701         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2702
2703         * WebView/WebHTMLView.mm:
2704         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2705         (-[WebHTMLView _updateFontPanel]):
2706         * WebView/WebView.mm:
2707         (-[WebView typingAttributes]):
2708
2709 2018-09-17  Darin Adler  <darin@apple.com>
2710
2711         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2712         https://bugs.webkit.org/show_bug.cgi?id=189652
2713
2714         Reviewed by Saam Barati.
2715
2716         * WebView/WebPDFRepresentation.mm:
2717         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2718
2719 2018-09-14  Jer Noble  <jer.noble@apple.com>
2720
2721         Turn SourceBufferChangeTypeEnabled on by default
2722         https://bugs.webkit.org/show_bug.cgi?id=189527
2723
2724         Reviewed by Eric Carlson.
2725
2726         * WebView/WebPreferences.mm:
2727         (+[WebPreferences initialize]):
2728
2729 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2730
2731         Fix an internal build after r235935
2732         https://bugs.webkit.org/show_bug.cgi?id=188996
2733
2734         * Carbon/HIWebView.mm:
2735         (Draw):
2736         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2737
2738 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2739
2740         Add IGNORE_WARNING_.* macros
2741         https://bugs.webkit.org/show_bug.cgi?id=188996
2742
2743         Reviewed by Michael Catanzaro.
2744
2745         * Carbon/CarbonUtils.m:
2746         (PoolCleaner):
2747         * Carbon/CarbonWindowAdapter.mm:
2748         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2749         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2750         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2751         (-[CarbonWindowAdapter _termWindowIfOwner]):
2752         (-[CarbonWindowAdapter _windowMovedToRect:]):
2753         (-[CarbonWindowAdapter setContentView:]):
2754         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2755         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2756         * Carbon/CarbonWindowFrame.m:
2757         (-[CarbonWindowFrame title]):
2758         * Carbon/HIViewAdapter.m:
2759         (+[HIViewAdapter getHIViewForNSView:]):
2760         * Carbon/HIWebView.mm:
2761         (overrideCGContext):
2762         (restoreCGContext):
2763         (Draw):
2764         * DOM/DOM.mm:
2765         * History/WebHistory.mm:
2766         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2767         * History/WebHistoryItem.mm:
2768         (-[WebHistoryItem icon]):
2769         * Misc/WebKitNSStringExtras.mm:
2770         (-[NSString _web_drawAtPoint:font:textColor:]):
2771         * Misc/WebNSImageExtras.m:
2772         (-[NSImage _web_scaleToMaxSize:]):
2773         (-[NSImage _web_dissolveToFraction:]):
2774         * Misc/WebNSPasteboardExtras.mm:
2775         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2776         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2777         * Panels/WebAuthenticationPanel.m:
2778         (-[WebAuthenticationPanel loadNib]):
2779         * Plugins/Hosted/NetscapePluginHostManager.mm:
2780         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2781         (WebKit::NetscapePluginHostManager::didCreateWindow):
2782         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2783         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2784         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2785         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2786         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2787         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2788         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2789         (-[WebHostedNetscapePluginView drawRect:]):
2790         * Plugins/Hosted/WebTextInputWindowController.m:
2791         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2792         * Plugins/WebBaseNetscapePluginView.mm:
2793         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2794         * Plugins/WebNetscapePluginPackage.mm:
2795         (-[WebNetscapePluginPackage _tryLoad]):
2796         * Plugins/WebNetscapePluginView.mm:
2797         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2798         (-[WebNetscapePluginView sendDrawRectEvent:]):
2799         (-[WebNetscapePluginView drawRect:]):
2800         * Plugins/WebPluginController.mm:
2801         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2802         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2803         * WebCoreSupport/PopupMenuMac.mm:
2804         (PopupMenuMac::populate):
2805         * WebCoreSupport/WebAlternativeTextClient.h:
2806         * WebCoreSupport/WebDragClient.mm:
2807         (WebDragClient::startDrag):
2808         * WebCoreSupport/WebFrameLoaderClient.mm:
2809         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2810         (webGetNSImage):
2811         * WebInspector/WebNodeHighlight.mm:
2812         * WebInspector/WebNodeHighlightView.mm:
2813         (-[WebNodeHighlightView drawRect:]):
2814         * WebView/WebClipView.mm:
2815         (-[WebClipView initWithFrame:]):
2816         * WebView/WebFrame.mm:
2817         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2818         (-[WebFrame _drawRect:contentsOnly:]):
2819         (-[WebFrame accessibilityRoot]):
2820         * WebView/WebFullScreenController.mm:
2821         (-[WebFullScreenController enterFullScreen:]):
2822         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2823         (-[WebFullScreenController exitFullScreen]):
2824         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2825         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2826         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2827         * WebView/WebHTMLView.mm:
2828         (-[NSWindow _web_borderView]):
2829         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2830         (-[WebHTMLView _setAsideSubviews]):
2831         (-[WebHTMLView _autoscroll]):
2832         (-[WebHTMLView drawRect:]):
2833         (-[WebHTMLView mouseDown:]):
2834         (-[WebHTMLView mouseDragged:]):
2835         (-[WebHTMLView mouseUp:]):
2836         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2837         (-[WebHTMLView knowsPageRange:]):
2838         (-[WebHTMLView accessibilityHitTest:]):
2839         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2840         (-[WebHTMLView _colorAsString:]):
2841         (-[WebHTMLView copyFont:]):
2842         (-[WebHTMLView _executeSavedKeypressCommands]):
2843         (-[WebHTMLView attachRootLayer:]):
2844         (-[WebHTMLView textStorage]):
2845         (-[WebHTMLView _updateSelectionForInputManager]):
2846         * WebView/WebPDFView.mm:
2847         (_applicationInfoForMIMEType):
2848         (-[WebPDFView centerSelectionInVisibleArea:]):
2849         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2850         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2851         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2852         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2853         * WebView/WebTextCompletionController.mm:
2854         (-[WebTextCompletionController _buildUI]):
2855         (-[WebTextCompletionController _placePopupWindow:]):
2856         * WebView/WebVideoFullscreenController.mm:
2857         * WebView/WebVideoFullscreenHUDWindowController.mm:
2858         (createMediaUIBackgroundView):
2859         * WebView/WebView.mm:
2860         (-[WebTextListTouchBarViewController initWithWebView:]):
2861         (-[WebView _dispatchTileDidDraw:]):
2862         (-[WebView encodeWithCoder:]):
2863         (-[WebView mainFrameIcon]):
2864         (LayerFlushController::flushLayers):
2865         * WebView/WebWindowAnimation.mm:
2866         (setScaledFrameForWindow):
2867
2868 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2869
2870         Remove unused needsDestruction class variables from HashTraits
2871         https://bugs.webkit.org/show_bug.cgi?id=189490
2872
2873         Reviewed by Daniel Bates.
2874
2875         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2876
2877 2018-09-07  Frederic Wang  <fwang@igalia.com>
2878
2879         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2880         https://bugs.webkit.org/show_bug.cgi?id=182230
2881
2882         Reviewed by Simon Fraser.
2883
2884         * DOM/DOMDocument.mm:
2885         (-[DOMDocument scrollingElement]): Use the new name.
2886
2887 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         Refactor WebCore::EditAction to be an 8-bit enum class
2890         https://bugs.webkit.org/show_bug.cgi?id=189383
2891
2892         Reviewed by Dan Bernstein.
2893
2894         * WebCoreSupport/WebEditorClient.mm:
2895         (undoNameForEditAction):
2896         * WebView/WebHTMLView.mm:
2897         (-[WebHTMLView pasteFont:]):
2898         (-[WebHTMLView changeFont:]):
2899         (-[WebHTMLView changeAttributes:]):
2900         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2901         (-[WebHTMLView changeColor:]):
2902         * WebView/WebView.mm:
2903         (-[WebView setTypingStyle:]):
2904
2905 2018-09-06  Frederic Wang  <fwang@igalia.com>
2906
2907         Group options of scrollRectToVisible into a struct
2908         https://bugs.webkit.org/show_bug.cgi?id=189352
2909
2910         Reviewed by Simon Fraser.
2911
2912         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2913         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2914         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2915
2916 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2917
2918         [macOS] Cannot change font size at selection until font panel is shown
2919         https://bugs.webkit.org/show_bug.cgi?id=189295
2920         <rdar://problem/35593389>
2921
2922         Reviewed by Ryosuke Niwa.
2923
2924         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2925         WebCore ChangeLog for more details.
2926
2927         * WebView/WebHTMLView.mm:
2928         (-[WebHTMLView changeFont:]):
2929         (-[WebHTMLView changeAttributes:]):
2930         (-[WebHTMLView _originalFontA]): Deleted.
2931         (-[WebHTMLView _originalFontB]): Deleted.
2932         (fontNameForDescription): Deleted.
2933         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2934         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2935         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2936
2937 2018-09-05  Jer Noble  <jer.noble@apple.com>
2938
2939         Add MediaCapabilities as an Experimental Feature
2940         https://bugs.webkit.org/show_bug.cgi?id=189209
2941
2942         Reviewed by Eric Carlson.
2943
2944         RuntimeEnabledFeature -> Setting.
2945
2946         * WebView/WebView.mm:
2947         (-[WebView _preferencesChanged:]):
2948
2949 2018-09-04  Frederic Wang  <fwang@igalia.com>
2950
2951         Add basic support for ScrollIntoViewOptions
2952         https://bugs.webkit.org/show_bug.cgi?id=189258
2953
2954         Reviewed by Simon Fraser.
2955
2956         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2957         header so that this file can build despite the new scrollIntoView function.
2958
2959 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2960
2961         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2962         https://bugs.webkit.org/show_bug.cgi?id=188890
2963         <rdar://problem/43648605>
2964
2965         Reviewed by Tim Horton.
2966
2967         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2968         more detail.
2969
2970         * WebCoreSupport/WebPlatformStrategies.h:
2971         * WebCoreSupport/WebPlatformStrategies.mm:
2972         (WebPlatformStrategies::allStringsForType):
2973
2974 2018-09-01  Darin Adler  <darin@apple.com>
2975
2976         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2977         https://bugs.webkit.org/show_bug.cgi?id=189072
2978         Reviewed by Dan Bernstein.
2979
2980         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2981         and declarations for NSURLDownload init methods.
2982
2983         * Misc/WebDownloadInternal.h: Removed.
2984
2985         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2986         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2987         "-Wdeprecated-declarations" because the method used here is deprecated.
2988
2989         * WebView/WebView.mm:
2990         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2991         used here is deprecated.
2992
2993 2018-08-31  Chris Dumez  <cdumez@apple.com>
2994
2995         Assertion hit in ~CompletionHandler() from ~WebFrame()
2996         https://bugs.webkit.org/show_bug.cgi?id=189199
2997         <rdar://problem/42657233>
2998
2999         Reviewed by Youenn Fablet.
3000
3001         * WebCoreSupport/WebFrameLoaderClient.h:
3002         * WebCoreSupport/WebFrameLoaderClient.mm:
3003         (WebFrameLoaderClient::dispatchWillSubmitForm):
3004
3005 2018-08-31  Antti Koivisto  <antti@apple.com>
3006
3007         Replace OptionSet |= and -= operators with add() and remove() functions
3008         https://bugs.webkit.org/show_bug.cgi?id=189169
3009
3010         Reviewed by Anders Carlsson.
3011
3012         * WebView/WebFrame.mm:
3013         (-[WebFrame _drawRect:contentsOnly:]):
3014         * WebView/WebView.mm:
3015         (coreOptions):
3016
3017 2018-08-31  Frederic Wang  <fwang@igalia.com>
3018
3019         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3020         https://bugs.webkit.org/show_bug.cgi?id=182053
3021
3022         Reviewed by Simon Fraser.
3023
3024         Add developer flag to use standard behavior for scrolling* attributes.
3025
3026         * WebView/WebPreferenceKeysPrivate.h:
3027         * WebView/WebPreferences.mm:
3028         (+[WebPreferences initialize]):
3029         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3030         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3031         * WebView/WebPreferencesPrivate.h:
3032         * WebView/WebView.mm:
3033         (-[WebView _preferencesChanged:]):
3034
3035 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3036
3037         Implement the Web Share API
3038         https://bugs.webkit.org/show_bug.cgi?id=171100
3039         <rdar://problem/31751734>
3040
3041         Reviewed by Tim Horton.
3042
3043         * WebCoreSupport/WebChromeClient.h:
3044         * WebCoreSupport/WebChromeClient.mm:
3045         (WebChromeClient::showShareSheet):
3046         Empty declaration of showShareSheet.
3047
3048 2018-08-29  Youenn Fablet  <youenn@apple.com>
3049
3050         Remove WebRTC legacy API implementation
3051         https://bugs.webkit.org/show_bug.cgi?id=189040
3052
3053         Reviewed by Eric Carlson.
3054
3055         * WebView/WebPreferenceKeysPrivate.h:
3056         * WebView/WebPreferences.mm:
3057         (+[WebPreferences initialize]):
3058         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3059         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3060         * WebView/WebPreferencesPrivate.h:
3061         * WebView/WebView.mm:
3062         (-[WebView _preferencesChanged:]):
3063
3064 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3065
3066         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3067         https://bugs.webkit.org/show_bug.cgi?id=189054
3068
3069         Reviewed by Andy Estes.
3070
3071         Remove the pasteboard type argument from readURLFromPasteboard.
3072
3073         * WebCoreSupport/WebPlatformStrategies.h:
3074         * WebCoreSupport/WebPlatformStrategies.mm:
3075         (WebPlatformStrategies::readURLFromPasteboard):
3076
3077 2018-08-27  Keith Rollin  <krollin@apple.com>
3078
3079         Unreviewed build fix -- disable LTO for production builds
3080
3081         * Configurations/Base.xcconfig:
3082
3083 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3084
3085         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3086         https://bugs.webkit.org/show_bug.cgi?id=188931
3087
3088         Reviewed by Wenson Hsieh.
3089
3090         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3091
3092 2018-08-27  Keith Rollin  <krollin@apple.com>
3093
3094         Build system support for LTO
3095         https://bugs.webkit.org/show_bug.cgi?id=187785
3096         <rdar://problem/42353132>
3097
3098         Reviewed by Dan Bernstein.
3099
3100         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3101         LTO.
3102
3103         * Configurations/Base.xcconfig:
3104         * Configurations/DebugRelease.xcconfig:
3105
3106 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3107
3108         Pass in IsComposed flag to Event constructors
3109         https://bugs.webkit.org/show_bug.cgi?id=188720
3110         <rdar://problem/43580387>
3111
3112         Reviewed by Simon Fraser.
3113
3114         * WebView/WebPDFView.mm:
3115         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3116         whether it's simulated or not.
3117
3118 2018-08-23  Mark Lam  <mark.lam@apple.com>
3119
3120         Move vmEntryGlobalObject() to VM from CallFrame.
3121         https://bugs.webkit.org/show_bug.cgi?id=188900
3122         <rdar://problem/43655753>
3123
3124         Reviewed by Michael Saboff.
3125
3126         * WebView/WebScriptDebugger.mm:
3127         (WebScriptDebugger::sourceParsed):
3128
3129 2018-08-23  Andy Estes  <aestes@apple.com>
3130
3131         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3132         https://bugs.webkit.org/show_bug.cgi?id=188829
3133
3134         Reviewed by Tim Horton.
3135
3136         * Configurations/FeatureDefines.xcconfig:
3137
3138 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3139
3140         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3141         https://bugs.webkit.org/show_bug.cgi?id=188777
3142
3143         Reviewed by Simon Fraser.
3144
3145         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3146         being "true" before the code change.
3147
3148         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3149
3150         * WebView/WebPDFView.mm:
3151         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3152
3153 2018-08-21  Daniel Bates  <dabates@apple.com>
3154
3155         Replace TextCheckingTypeMask with OptionSet
3156         https://bugs.webkit.org/show_bug.cgi?id=188678
3157
3158         Reviewed by Antti Koivisto.
3159
3160         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3161         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3162         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3163         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3164
3165         * WebCoreSupport/WebEditorClient.h:
3166         * WebCoreSupport/WebEditorClient.mm:
3167         (WebEditorClient::checkTextOfParagraph):
3168         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3169         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3170         left as this is more readable and unncessary now that modern compilers like Clang have
3171         diagnostics to catch accidental assignments when equality was intended.
3172         (WebEditorClient::didCheckSucceed):
3173         * WebView/WebView.mm:
3174         (coreTextCheckingType):
3175         (textCheckingResultFromNSTextCheckingResult):
3176
3177 2018-08-21  Daniel Bates  <dabates@apple.com>
3178
3179         [iOS][WK1] Support toggling continuous spell checking from tests
3180         https://bugs.webkit.org/show_bug.cgi?id=188763
3181
3182         Reviewed by Simon Fraser.
3183
3184         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3185         spell checking from tests in iOS WebKit Legacy.
3186
3187         * WebCoreSupport/WebEditorClient.h:
3188         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3189         * WebCoreSupport/WebEditorClient.mm:
3190         * WebView/WebView.h:
3191         * WebView/WebView.mm:
3192         (-[WebView toggleContinuousSpellChecking:]):
3193         (-[WebView toggleSmartInsertDelete:]):
3194
3195 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3196
3197         Add some plumbing for safe browsing
3198         https://bugs.webkit.org/show_bug.cgi?id=188709
3199
3200         Reviewed by Tim Horton.
3201
3202         * WebCoreSupport/WebFrameLoaderClient.h:
3203         * WebCoreSupport/WebFrameLoaderClient.mm:
3204         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3205
3206 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3207
3208         Replace canBubble and cancelable booleans in Event by enum classes
3209         https://bugs.webkit.org/show_bug.cgi?id=188692
3210
3211         Reviewed by Alex Christensen.
3212
3213         * WebView/WebPDFView.mm:
3214         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3215         * WebView/WebView.mm:
3216         (-[WebView _dispatchUnloadEvent]):
3217
3218 2018-08-16  Jer Noble  <jer.noble@apple.com>
3219
3220         Add Experimental Feature support for SourceBuffer.changeType()
3221         https://bugs.webkit.org/show_bug.cgi?id=188626
3222         <rdar://problem/43356021>
3223
3224         Reviewed by Eric Carlson.
3225
3226         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3227
3228         * WebView/WebPreferenceKeysPrivate.h:
3229         * WebView/WebPreferences.mm:
3230         (+[WebPreferences initialize]):
3231         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3232         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3233         * WebView/WebPreferencesPrivate.h:
3234         * WebView/WebView.mm:
3235         (-[WebView _preferencesChanged:]):
3236
3237 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3238
3239         Support drag-and-drop for input[type=color]
3240         https://bugs.webkit.org/show_bug.cgi?id=188464
3241
3242         Reviewed by Wenson Hsieh.
3243
3244         * WebCoreSupport/WebPlatformStrategies.h:
3245         * WebCoreSupport/WebPlatformStrategies.mm:
3246         (WebPlatformStrategies::setColor):
3247
3248 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3249
3250         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3251         https://bugs.webkit.org/show_bug.cgi?id=188569
3252         <rdar://problem/34201095>
3253
3254         Reviewed by Megan Gardner.
3255
3256         * WebView/WebImmediateActionController.mm:
3257         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3258         Speculative fix; the crashes indicate font is null, but we just checked it,
3259         so it must be getting made null by convertFont:toSize:. Check again!
3260
3261 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3262
3263         Use a 1-byte enum class for TextDirection
3264         https://bugs.webkit.org/show_bug.cgi?id=188350
3265
3266         Reviewed by Simon Fraser.
3267
3268         * WebCoreSupport/PopupMenuMac.mm:
3269         (PopupMenuMac::populate):
3270         (PopupMenuMac::show):
3271         * WebCoreSupport/WebFrameLoaderClient.mm:
3272         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3273         * WebView/WebFrame.mm:
3274         (-[WebFrame _dispatchDidReceiveTitle:]):
3275
3276 2018-08-09  Ali Juma  <ajuma@chromium.org>
3277
3278         Import WPTs for IntersectionObserver
3279         https://bugs.webkit.org/show_bug.cgi?id=188416
3280
3281         Reviewed by Simon Fraser.
3282
3283         * WebView/WebPreferencesPrivate.h:
3284
3285 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3286
3287         Follow-up build fix for r234685
3288         https://bugs.webkit.org/show_bug.cgi?id=188245
3289
3290         Unreviewed build fix.
3291
3292         * WebCoreSupport/WebSecurityOriginPrivate.h:
3293
3294 2018-08-05  Darin Adler  <darin@apple.com>
3295
3296         [Cocoa] More tweaks and refactoring to prepare for ARC
3297         https://bugs.webkit.org/show_bug.cgi?id=188245
3298
3299         Reviewed by Dan Bernstein.
3300
3301         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3302
3303         * Carbon/CarbonWindowFrame.m:
3304         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3305
3306         * DOM/DOM.mm:
3307         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3308         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3309         garbage collection so this method isn't useful.
3310
3311         * DOM/DOMXPath.mm:
3312         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3313         Objective-C garbage collection so this method isn't useful.
3314
3315         * History/WebHistory.mm:
3316         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3317
3318         * Misc/WebElementDictionary.mm:
3319         (addLookupKey): Use a bridging cast.
3320         (cacheValueForKey): Ditto.
3321         (-[WebElementDictionary _fillCache]): Ditto.
3322         (-[WebElementDictionary objectForKey:]): Ditto.
3323
3324         * Misc/WebKitNSStringExtras.mm:
3325         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3326         (-[NSString _web_widthWithFont:]): Ditto.
3327         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3328
3329         * Misc/WebLocalizableStrings.mm:
3330         (WebLocalizedString): Use a bridging cast.
3331
3332         * Misc/WebNSDataExtras.mm:
3333         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3334         and use CFBridgingRelease instead of calling autorelease directly.
3335         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3336         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3337         on the amount of explicit release and autorelease.
3338
3339         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3340         * Misc/WebNSDictionaryExtras.m:
3341         (-[NSDictionary _webkit_intForKey:]): Deleted.
3342         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3343         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3344         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3345         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3346         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3347         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3348
3349         * Misc/WebStringTruncator.mm:
3350         (fontFromNSFont): Use a bridging cast.
3351
3352         * Plugins/Hosted/NetscapePluginHostManager.mm:
3353         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3354
3355         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3356         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3357         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3358         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3359         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3360         * Plugins/Hosted/ProxyInstance.mm:
3361         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3362         * Plugins/WebBasePluginPackage.mm:
3363         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3364         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3365         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3366         * Plugins/WebNetscapePluginPackage.mm:
3367         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3368
3369         * Plugins/WebNetscapePluginView.mm:
3370         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3371         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3372         (-[WebNetscapePluginView status:]): Use a bridging cast.
3373         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3374
3375         * Plugins/WebPluginController.mm:
3376         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3377
3378         * Plugins/WebPluginDatabase.mm:
3379         (checkCandidate): Use explicit __strong for out argument types.
3380
3381         * Plugins/npapi.mm:
3382         (pluginViewForInstance): Use a bridging cast.
3383
3384         * Storage/WebDatabaseManager.mm:
3385         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3386         explicit NSNumber and NSDictionary calls.
3387
3388         * WebCoreSupport/WebContextMenuClient.mm:
3389         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3390
3391         * WebCoreSupport/WebEditorClient.mm:
3392         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3393         (WebEditorClient::handleInputMethodKeydown): Ditto.
3394
3395         * WebCoreSupport/WebFrameNetworkingContext.mm:
3396         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3397
3398         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3399         as a struct rather than an Objective-C class, since that's how it's defined.
3400
3401         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3402
3403         * WebView/WebFullScreenController.mm:
3404         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3405         * WebView/WebHTMLView.mm:
3406         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3407         Ditto.
3408         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3409
3410         * WebView/WebImmediateActionController.mm:
3411         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3412         go down to the document and then back to the frame.
3413         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3414         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3415         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3416
3417         * WebView/WebJSPDFDoc.mm:
3418         (jsPDFDocInitialize): Removed some unneeded type casting.
3419         (jsPDFDocFinalize): Ditto.
3420         (jsPDFDocPrint): Use a bridging cast.
3421
3422         * WebView/WebPDFView.mm:
3423         (_applicationInfoForMIMEType): Use bridging casts.
3424
3425         * WebView/WebPreferences.mm:
3426         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3427         instead of methods from WebNSDictionaryExtras.
3428         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3429         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3430         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3431         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3432         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3433
3434         * WebView/WebView.mm:
3435         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3436         (-[WebView _addToAllWebViewsSet]): Ditto.
3437         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3438         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3439         so it can be called from WebViewData methods.
3440
3441         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3442         method, _windowVisibilityChanged:.
3443
3444         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3445         called from WebViewData methods.
3446
3447 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3448
3449         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3450         https://bugs.webkit.org/show_bug.cgi?id=188323
3451
3452         Reviewed by Simon Fraser.
3453
3454         * WebCoreSupport/WebContextMenuClient.mm:
3455         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3456         * WebView/WebFrame.mm:
3457         (-[WebFrame _paintBehaviorForDestinationContext:]):
3458         (-[WebFrame _drawRect:contentsOnly:]):
3459         * WebView/WebHTMLView.mm:
3460         (imageFromRect):
3461         (selectionImage):
3462
3463 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3464
3465         Add support for microtasks in workers
3466         https://bugs.webkit.org/show_bug.cgi?id=188246
3467
3468         Reviewed by Darin Adler.
3469
3470         Rename JSMainThreadExecState.h to JSExecState.h.
3471
3472         * DOM/DOMAttr.mm:
3473         * DOM/DOMBlob.mm:
3474         * DOM/DOMCDATASection.mm:
3475         * DOM/DOMCSSCharsetRule.mm:
3476         * DOM/DOMCSSFontFaceRule.mm:
3477         * DOM/DOMCSSImportRule.mm:
3478         * DOM/DOMCSSMediaRule.mm:
3479         * DOM/DOMCSSPageRule.mm:
3480         * DOM/DOMCSSPrimitiveValue.mm:
3481         * DOM/DOMCSSRule.mm:
3482         * DOM/DOMCSSRuleList.mm:
3483         * DOM/DOMCSSStyleDeclaration.mm:
3484         * DOM/DOMCSSStyleRule.mm:
3485         * DOM/DOMCSSStyleSheet.mm:
3486         * DOM/DOMCSSUnknownRule.mm:
3487         * DOM/DOMCSSValue.mm:
3488         * DOM/DOMCSSValueList.mm:
3489         * DOM/DOMCharacterData.mm:
3490         * DOM/DOMComment.mm:
3491         * DOM/DOMCounter.mm:
3492         * DOM/DOMDocument.mm:
3493         * DOM/DOMDocumentFragment.mm:
3494         * DOM/DOMDocumentType.mm:
3495         * DOM/DOMElement.mm:
3496         * DOM/DOMEvent.mm:
3497         * DOM/DOMFile.mm:
3498         * DOM/DOMFileList.mm:
3499         * DOM/DOMHTML.mm:
3500         * DOM/DOMHTMLAnchorElement.mm:
3501         * DOM/DOMHTMLAppletElement.mm:
3502         * DOM/DOMHTMLAreaElement.mm:
3503         * DOM/DOMHTMLBRElement.mm:
3504         * DOM/DOMHTMLBaseElement.mm:
3505         * DOM/DOMHTMLBaseFontElement.mm:
3506         * DOM/DOMHTMLBodyElement.mm:
3507         * DOM/DOMHTMLButtonElement.mm:
3508         * DOM/DOMHTMLCanvasElement.mm:
3509         * DOM/DOMHTMLCollection.mm:
3510         * DOM/DOMHTMLDListElement.mm:
3511         * DOM/DOMHTMLDirectoryElement.mm:
3512         * DOM/DOMHTMLDivElement.mm:
3513         * DOM/DOMHTMLDocument.mm:
3514         * DOM/DOMHTMLElement.mm:
3515         * DOM/DOMHTMLEmbedElement.mm:
3516         * DOM/DOMHTMLFieldSetElement.mm:
3517         * DOM/DOMHTMLFontElement.mm:
3518         * DOM/DOMHTMLFormElement.mm:
3519         * DOM/DOMHTMLFrameElement.mm:
3520         * DOM/DOMHTMLFrameSetElement.mm:
3521         * DOM/DOMHTMLHRElement.mm:
3522         * DOM/DOMHTMLHeadElement.mm:
3523         * DOM/DOMHTMLHeadingElement.mm:
3524         * DOM/DOMHTMLHtmlElement.mm:
3525         * DOM/DOMHTMLIFrameElement.mm:
3526         * DOM/DOMHTMLImageElement.mm:
3527         * DOM/DOMHTMLInputElement.mm:
3528         * DOM/DOMHTMLLIElement.mm:
3529         * DOM/DOMHTMLLabelElement.mm:
3530         * DOM/DOMHTMLLegendElement.mm:
3531         * DOM/DOMHTMLLinkElement.mm:
3532         * DOM/DOMHTMLMapElement.mm:
3533         * DOM/DOMHTMLMarqueeElement.mm:
3534         * DOM/DOMHTMLMediaElement.mm:
3535         * DOM/DOMHTMLMenuElement.mm:
3536         * DOM/DOMHTMLMetaElement.mm:
3537         * DOM/DOMHTMLModElement.mm:
3538         * DOM/DOMHTMLOListElement.mm:
3539         * DOM/DOMHTMLObjectElement.mm:
3540         * DOM/DOMHTMLOptGroupElement.mm:
3541         * DOM/DOMHTMLOptionElement.mm:
3542         * DOM/DOMHTMLOptionsCollection.mm:
3543         * DOM/DOMHTMLParagraphElement.mm:
3544         * DOM/DOMHTMLParamElement.mm:
3545         * DOM/DOMHTMLPreElement.mm:
3546         * DOM/DOMHTMLQuoteElement.mm:
3547         * DOM/DOMHTMLScriptElement.mm:
3548         * DOM/DOMHTMLSelectElement.mm:
3549         * DOM/DOMHTMLStyleElement.mm:
3550         * DOM/DOMHTMLTableCaptionElement.mm:
3551         * DOM/DOMHTMLTableCellElement.mm:
3552         * DOM/DOMHTMLTableColElement.mm:
3553         * DOM/DOMHTMLTableElement.mm:
3554         * DOM/DOMHTMLTableRowElement.mm:
3555         * DOM/DOMHTMLTableSectionElement.mm:
3556         * DOM/DOMHTMLTextAreaElement.mm:
3557         * DOM/DOMHTMLTitleElement.mm:
3558         * DOM/DOMHTMLUListElement.mm:
3559         * DOM/DOMHTMLVideoElement.mm:
3560         * DOM/DOMImplementation.mm:
3561         * DOM/DOMKeyboardEvent.mm:
3562         * DOM/DOMMediaError.mm:
3563         * DOM/DOMMediaList.mm:
3564         * DOM/DOMMouseEvent.mm:
3565         * DOM/DOMMutationEvent.mm:
3566         * DOM/DOMNamedNodeMap.mm:
3567         * DOM/DOMNode.mm:
3568         * DOM/DOMNodeIterator.mm:
3569         * DOM/DOMNodeList.mm:
3570         * DOM/DOMOverflowEvent.mm:
3571         * DOM/DOMProcessingInstruction.mm:
3572         * DOM/DOMProgressEvent.mm:
3573         * DOM/DOMRGBColor.mm:
3574         * DOM/DOMRange.mm:
3575         * DOM/DOMRect.mm:
3576         * DOM/DOMStyleSheet.mm:
3577         * DOM/DOMStyleSheetList.mm:
3578         * DOM/DOMText.mm:
3579         * DOM/DOMTextEvent.mm:
3580         * DOM/DOMTimeRanges.mm:
3581         * DOM/DOMTokenList.mm:
3582         * DOM/DOMTreeWalker.mm:
3583         * DOM/DOMUIEvent.mm:
3584         * DOM/DOMWheelEvent.mm:
3585         * DOM/DOMXPathExpression.mm:
3586         * DOM/DOMXPathResult.mm:
3587         * DOM/ObjCEventListener.mm:
3588
3589 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3590
3591         Fix spelling of "overridden"
3592         https://bugs.webkit.org/show_bug.cgi?id=188315
3593
3594         Reviewed by Darin Adler.
3595
3596         * Misc/WebKitVersionChecks.mm:
3597         (setWebKitLinkTimeVersion):
3598         (WebKitLinkTimeVersion):
3599         * Plugins/WebBaseNetscapePluginView.mm:
3600         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3601         * WebCoreSupport/PopupMenuMac.mm:
3602         (PopupMenuMac::populate):
3603
3604 2018-08-01  Nan Wang  <n_wang@apple.com>
3605
3606         AX: AOM: Add ARIA IDL Attribute Reflection
3607         https://bugs.webkit.org/show_bug.cgi?id=184676
3608         <rdar://problem/39476882>
3609
3610         Reviewed by Chris Fleizach.
3611
3612         * WebView/WebPreferenceKeysPrivate.h:
3613         * WebView/WebPreferences.mm:
3614         (+[WebPreferences initialize]):
3615         (-[WebPreferences ariaReflectionEnabled]):
3616         (-[WebPreferences setAriaReflectionEnabled:]):
3617         * WebView/WebPreferencesPrivate.h:
3618         * WebView/WebView.mm:
3619         (-[WebView _preferencesChanged:]):
3620
3621 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3622
3623         Shrink GraphicsLayerCA
3624         https://bugs.webkit.org/show_bug.cgi?id=188141
3625
3626         Reviewed by Zalan Bujtas.
3627
3628         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3629         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3630         * moving all the animation-related stuff into the lazily-allocated m_animations
3631         * making enums be 8-bit
3632         * re-ordering data members
3633
3634         * WebView/WebView.mm:
3635         (-[WebView _setMediaLayer:forPluginView:]):
3636
3637 2018-07-30  Rob Buis  <rbuis@igalia.com>
3638
3639         Merge PlatformCookieJar functions into NetworkStorageSession
3640         https://bugs.webkit.org/show_bug.cgi?id=188137
3641
3642         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3643
3644         Reviewed by Alex Christensen.
3645
3646         * WebCoreSupport/WebPlatformStrategies.mm:
3647         (WebPlatformStrategies::cookiesForDOM):
3648         (WebPlatformStrategies::setCookiesFromDOM):
3649         (WebPlatformStrategies::cookiesEnabled):
3650         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3651         (WebPlatformStrategies::getRawCookies):
3652         (WebPlatformStrategies::deleteCookie):
3653         * WebView/WebPreferences.mm:
3654         (+[WebPreferences _clearNetworkLoaderSession]):
3655
3656 2018-07-28  Darin Adler  <darin@apple.com>
3657
3658         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3659         https://bugs.webkit.org/show_bug.cgi?id=188140
3660
3661         Reviewed by Sam Weinig.
3662
3663         * WebView/WebImmediateActionController.mm:
3664         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3665         new DictionaryLookup function that returns a tuple instead of using an out argument.
3666
3667 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3668
3669         [INTL] Remove INTL sub-feature compile flags
3670         https://bugs.webkit.org/show_bug.cgi?id=188081
3671
3672         Reviewed by Michael Catanzaro.
3673
3674         * Configurations/FeatureDefines.xcconfig:
3675
3676 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3677
3678         Unreviewed, rolling out r234181 and r234189.
3679         https://bugs.webkit.org/show_bug.cgi?id=188075
3680
3681         These are not needed right now (Requested by thorton on
3682         #webkit).
3683
3684         Reverted changesets:
3685
3686         "Enable Web Content Filtering on watchOS"
3687         https://bugs.webkit.org/show_bug.cgi?id=187979
3688         https://trac.webkit.org/changeset/234181
3689
3690         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3691         https://bugs.webkit.org/show_bug.cgi?id=187985
3692         https://trac.webkit.org/changeset/234189
3693
3694 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3695
3696         Use the Page's appearance when converting pasteboard attributed strings.
3697         https://bugs.webkit.org/show_bug.cgi?id=188067
3698         rdar://problem/42632246
3699
3700         Reviewed by Wenson Hsieh.
3701
3702         * WebCoreSupport/WebEditorClient.mm:
3703         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3704
3705 2018-07-25  Chris Dumez  <cdumez@apple.com>
3706
3707         navigator.userAgent may return outdated value after webView.customUserAgent is set
3708         https://bugs.webkit.org/show_bug.cgi?id=188009
3709         <rdar://problem/42566456>
3710
3711         Reviewed by Alex Christensen.
3712
3713         Let the page know when the user agent changes.
3714
3715         * WebView/WebView.mm:
3716         (-[WebView _preferencesChanged:]):
3717         (-[WebView setApplicationNameForUserAgent:]):
3718         (-[WebView _invalidateUserAgentCache]):
3719         (-[WebView setCustomUserAgent:]):
3720         * WebView/WebViewInternal.h:
3721
3722 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3723
3724         Enable Web Content Filtering on watchOS
3725         https://bugs.webkit.org/show_bug.cgi?id=187979
3726         <rdar://problem/42559346>
3727
3728         Reviewed by Wenson Hsieh.
3729
3730         * Configurations/FeatureDefines.xcconfig:
3731
3732 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3733
3734         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3735         https://bugs.webkit.org/show_bug.cgi?id=187846
3736
3737         Reviewed by Simon Fraser.
3738
3739         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3740
3741         * WebView/WebHTMLView.mm:
3742         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3743         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3744
3745 2018-07-11  Dean Jackson  <dino@apple.com>
3746
3747         Allow removal of white backgrounds
3748         https://bugs.webkit.org/show_bug.cgi?id=187574
3749         <rdar://problem/41146792>
3750
3751         Reviewed by Simon Fraser.
3752
3753         Add a new WebPreference for punching out white backgrounds.
3754
3755         * WebView/WebPreferenceKeysPrivate.h:
3756         * WebView/WebPreferences.mm:
3757         (+[WebPreferences initialize]):
3758         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3759         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3760         * WebView/WebPreferencesPrivate.h:
3761         * WebView/WebView.mm:
3762         (-[WebView _preferencesChanged:]):
3763
3764 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3765
3766         Ensure WebKit stack is ad-hoc signed
3767         https://bugs.webkit.org/show_bug.cgi?id=187667
3768
3769         Reviewed by Alexey Proskuryakov.
3770
3771         * Configurations/Base.xcconfig:
3772
3773 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3774
3775         REGRESSION (231276): Attempting to copy an image fails
3776         https://bugs.webkit.org/show_bug.cgi?id=187212
3777         <rdar://problem/41540074>
3778
3779         Reviewed by Ryosuke Niwa.
3780
3781         Renamed methods to make it clear that one URL and one title are being passed in.
3782
3783         * WebCoreSupport/WebPlatformStrategies.h:
3784         * WebCoreSupport/WebPlatformStrategies.mm:
3785         (WebPlatformStrategies::setURL):
3786
3787 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3788
3789         Disable cross-origin-window-policy by default
3790         https://bugs.webkit.org/show_bug.cgi?id=187509
3791
3792         Reviewed by Chris Dumez.
3793
3794         * WebView/WebPreferences.mm:
3795         (+[WebPreferences initialize]):
3796
3797 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3798
3799         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3800         https://bugs.webkit.org/show_bug.cgi?id=187425
3801         rdar://problem/39948240
3802
3803         Reviewed by Tim Horton.
3804
3805         * WebView/WebView.mm:
3806         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3807         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3808         a call in this method to setUseDarkAppearance.
3809         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3810         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3811         (-[WebView _updateDefaultAppearance]): Deleted.
3812         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3813
3814 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3815
3816         Shrink various loading-related enums to shrink CachedResource
3817         https://bugs.webkit.org/show_bug.cgi?id=187443
3818
3819         Reviewed by Chris Dumez.
3820
3821         * WebCoreSupport/WebFrameLoaderClient.mm:
3822         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3823         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3824         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3825         (WebFrameLoaderClient::dispatchWillSendRequest):
3826         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3827         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3828         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3829         (WebFrameLoaderClient::updateGlobalHistory):
3830         (WebFrameLoaderClient::canHandleRequest const):
3831         * WebView/WebDataSource.mm:
3832         (-[WebDataSource initialRequest]):
3833         (-[WebDataSource request]):
3834
3835 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3836
3837         Unreviewed, rolling out r233612.
3838         https://bugs.webkit.org/show_bug.cgi?id=187475
3839
3840         Revision caused the api test LinkColorWithSystemAppearance to
3841         fail on all systems. (Requested by Truitt on #webkit).
3842
3843         Reverted changeset:
3844
3845         "Semantic colors don't update when accessibility Increase
3846         Contrast mode is enabled."
3847         https://bugs.webkit.org/show_bug.cgi?id=187425
3848         https://trac.webkit.org/changeset/233612
3849
3850 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3851
3852         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3853         https://bugs.webkit.org/show_bug.cgi?id=187425
3854         rdar://problem/39948240
3855
3856         Reviewed by Tim Horton.
3857
3858         * WebView/WebView.mm:
3859         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3860         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3861         a call in this method to setUseDarkAppearance.
3862         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3863         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3864         (-[WebView _updateDefaultAppearance]): Deleted.
3865         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3866
3867 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3868
3869         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3870         https://bugs.webkit.org/show_bug.cgi?id=187369
3871         rdar://problem/41870420
3872
3873         Reviewed by Tim Horton.
3874
3875         * WebView/WebMediaPlaybackTargetPicker.mm:
3876         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3877         * WebView/WebView.mm:
3878         (-[WebView _commonInitializationWithFrameName:groupName:]):
3879         (-[WebView _effectiveAppearanceIsDark]):
3880         (-[WebView _updateDefaultAppearance]):
3881         (-[WebView _defaultAppearance]): Deleted.
3882
3883 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3884
3885         Youtube video pages crash after a couple of minutes
3886         https://bugs.webkit.org/show_bug.cgi?id=187316
3887
3888         Reviewed by Antti Koivisto.
3889
3890         * WebView/WebView.mm:
3891         (-[WebView _preferencesChanged:]):
3892
3893 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3894
3895         Introduce PLATFORM(IOSMAC)
3896         https://bugs.webkit.org/show_bug.cgi?id=187315
3897
3898         Reviewed by Dan Bernstein.
3899
3900         * Configurations/Base.xcconfig:
3901         * Configurations/FeatureDefines.xcconfig:
3902
3903 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3904
3905         [iOS] DataTransfer.getData always returns the empty string when dropping text
3906         https://bugs.webkit.org/show_bug.cgi?id=187130
3907         <rdar://problem/41014117>
3908
3909         Reviewed by Ryosuke Niwa.
3910
3911         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3912
3913         * WebCoreSupport/WebPlatformStrategies.h:
3914         * WebCoreSupport/WebPlatformStrategies.mm:
3915         (WebPlatformStrategies::allPasteboardItemInfo):
3916
3917 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3918
3919         [Mac] AirPlay picker uses incorrect theme in Dark mode
3920         https://bugs.webkit.org/show_bug.cgi?id=187054
3921         <rdar://problem/41291093>
3922
3923         Reviewed by Timothy Hatcher.
3924
3925         * WebView/WebMediaPlaybackTargetPicker.mm:
3926         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3927
3928 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3929
3930         [WTF] Add user-defined literal for ASCIILiteral
3931         https://bugs.webkit.org/show_bug.cgi?id=186839
3932
3933         Reviewed by Darin Adler.
3934
3935         * DOM/ExceptionHandlers.mm:
3936         (raiseDOMErrorException):
3937         * Plugins/Hosted/ProxyInstance.mm:
3938         (WebKit::ProxyInstance::invokeMethod):
3939         * Storage/WebDatabaseProvider.mm:
3940         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3941
3942 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3943
3944         Recalc styles every time defaultAppearance changes.
3945         https://bugs.webkit.org/show_bug.cgi?id=186866
3946         rdar://problem/41309805
3947
3948         Reviewed by Tim Horton.
3949
3950         * WebView/WebView.mm:
3951         (-[WebView _updateDefaultAppearance]):
3952         (-[WebView _setUseSystemAppearance:]):
3953         (-[WebView _useSystemAppearance]):
3954
3955 2018-06-20  Darin Adler  <darin@apple.com>
3956
3957         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3958         https://bugs.webkit.org/show_bug.cgi?id=186875
3959
3960         Reviewed by Anders Carlsson.
3961
3962         * WebView/WebHTMLView.mm:
3963         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3964         to write te file to.
3965         * WebView/WebPreferences.mm:
3966         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3967         * WebView/WebView.mm:
3968         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3969
3970 2018-06-12  Darin Adler  <darin@apple.com>
3971
3972         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3973         https://bugs.webkit.org/show_bug.cgi?id=186526
3974
3975         Reviewed by Anders Carlsson.
3976
3977         * Plugins/Hosted/NetscapePluginHostManager.mm:
3978         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3979
3980         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3981         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3982         assignment rather than adoptNS/leakRef.
3983         * Plugins/WebNetscapePluginView.mm:
3984         (-[WebNetscapePluginView createPlugin]): Ditto.
3985
3986         * WebCoreSupport/WebContextMenuClient.mm:
3987         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3988         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3989         argument, so use RetainPtr::get instead.
3990
3991         * WebView/WebHTMLView.mm:
3992         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3993         No need to autorelease the result when the return type is RetainPtr.
3994
3995         * WebView/WebPDFRepresentation.mm:
3996         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3997
3998 2018-06-13  Youenn Fablet  <youenn@apple.com>
3999
4000         Supported plugin check should be based on plugin identifier
4001         https://bugs.webkit.org/show_bug.cgi?id=186578
4002         <rdar://problem/40523828>
4003
4004         Reviewed by Darin Adler.
4005
4006         * WebCoreSupport/WebPluginInfoProvider.h:
4007         * WebCoreSupport/WebPluginInfoProvider.mm:
4008         (WebPluginInfoProvider::pluginInfo):
4009         (WebPluginInfoProvider::webVisiblePluginInfo):
4010
4011 2018-06-13  Chris Dumez  <cdumez@apple.com>
4012
4013         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
4014         https://bugs.webkit.org/show_bug.cgi?id=186545
4015
4016         Reviewed by Brady Eidson.
4017
4018         Update client delegate now that parameter type has changed.
4019
4020         * WebCoreSupport/WebFrameLoaderClient.h:
4021         * WebCoreSupport/WebFrameLoaderClient.mm:
4022         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4023
4024 2018-06-11  Tim Horton  <timothy_horton@apple.com>
4025
4026         Link drag image is inconsistently unreadable in dark mode
4027         https://bugs.webkit.org/show_bug.cgi?id=186472
4028
4029         Reviewed by Timothy Hatcher.
4030
4031         * WebView/WebView.mm:
4032         (-[WebView _defaultAppearance]):
4033         Make defaultAppearance accurate even if useSystemAppearance is false.
4034         Some parts of WebKit (like the link drag image, but also context menus)
4035         want to be able to follow the system appearance regardless of whether
4036         the view or content has opted in.
4037
4038 2018-06-11  Chris Dumez  <cdumez@apple.com>
4039
4040         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
4041         https://bugs.webkit.org/show_bug.cgi?id=186441
4042
4043         Reviewed by Brady Eidson.
4044
4045         Rename existing flag to something a bit more generic, now that it is used for
4046         more things than bypassing the navigation policy check.
4047
4048         * WebView/WebView.mm:
4049         (-[WebView _loadBackForwardListFromOtherView:]):
4050         (-[WebView goToBackForwardItem:]):
4051
4052 2018-06-09  Dan Bernstein  <mitz@apple.com>
4053
4054         [Xcode] Clean up and modernize some build setting definitions
4055         https://bugs.webkit.org/show_bug.cgi?id=186463
4056
4057         Reviewed by Sam Weinig.
4058
4059         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
4060         * Configurations/DebugRelease.xcconfig: Ditto.
4061         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
4062           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
4063         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
4064         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
4065           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
4066         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
4067
4068 2018-06-08  Darin Adler  <darin@apple.com>
4069
4070         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
4071         https://bugs.webkit.org/show_bug.cgi?id=186436
4072