937ec86b47698bea0586891fd0b4bbd8577afe7b
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-04  Tim Horton  <timothy_horton@apple.com>
2
3         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
4         https://bugs.webkit.org/show_bug.cgi?id=183283
5         <rdar://problem/38062148>
6
7         Reviewed by Sam Weinig.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2018-02-28  Alex Christensen  <achristensen@webkit.org>
12
13         Reduce use of NetworkingContext in WebKit
14         https://bugs.webkit.org/show_bug.cgi?id=183213
15
16         Reviewed by Brady Eidson.
17
18         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19         (WebKit::NetscapePluginInstanceProxy::getProxy):
20         * Plugins/WebNetscapePluginView.mm:
21         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
22
23 2018-02-17  Darin Adler  <darin@apple.com>
24
25         Prepare for ExtendedColor changes (first step)
26         https://bugs.webkit.org/show_bug.cgi?id=182904
27
28         Reviewed by Sam Weinig.
29
30         * Misc/WebKitNSStringExtras.mm:
31         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
32
33 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
34
35         Remove currentTime() / currentTimeMS()
36         https://bugs.webkit.org/show_bug.cgi?id=183052
37
38         Reviewed by Mark Lam.
39
40         * WebCoreSupport/WebFrameLoaderClient.h:
41         * WebCoreSupport/WebFrameLoaderClient.mm:
42         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
43
44 2018-02-16  Youenn Fablet  <youenn@apple.com>
45
46         Allow specifying which plug-ins are supported
47         https://bugs.webkit.org/show_bug.cgi?id=182748
48
49         Reviewed by Chris Dumez.
50
51         * WebCoreSupport/WebPluginInfoProvider.h:
52         * WebCoreSupport/WebPluginInfoProvider.mm:
53         (WebPluginInfoProvider::getPluginInfo):
54         (WebPluginInfoProvider::getWebVisiblePluginInfo):
55
56 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
57
58         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
59         https://bugs.webkit.org/show_bug.cgi?id=182882
60         <rdar://problem/35672661>
61
62         Reviewed by Dan Bernstein.
63
64         Make sure the smart pointer hold the collection of subviews lives at least as
65         long as the loop using it.
66
67         * WebView/WebHTMLView.mm:
68         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
69
70 2018-02-14  Daniel Bates  <dabates@apple.com>
71
72         Disallow cross-origin subresources from asking for credentials
73         https://bugs.webkit.org/show_bug.cgi?id=182579
74         <rdar://problem/36162271>
75
76         Reviewed by Andy Estes.
77
78         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
79         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
80
81         * WebView/WebPreferenceKeysPrivate.h:
82         * WebView/WebPreferences.mm:
83         (+[WebPreferences initialize]):
84         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
85         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
86         * WebView/WebPreferencesPrivate.h:
87         * WebView/WebView.mm:
88         (-[WebView _preferencesChanged:]):
89
90 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
91
92         Remove ForwardingHeaders directory from WebKitLegacy/mac.
93         https://bugs.webkit.org/show_bug.cgi?id=182738
94
95         Reviewed by Darin Adler.
96
97         * ForwardingHeaders/collector/handles/Global.h: Removed.
98         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
99         * ForwardingHeaders/runtime/Completion.h: Removed.
100         * ForwardingHeaders/runtime/Error.h: Removed.
101         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
102         * ForwardingHeaders/runtime/JSFunction.h: Removed.
103         * ForwardingHeaders/runtime/JSLock.h: Removed.
104         * ForwardingHeaders/runtime/JSObject.h: Removed.
105         * ForwardingHeaders/runtime/JSString.h: Removed.
106         * ForwardingHeaders/runtime/Protect.h: Removed.
107         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
108
109 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
110
111         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
112         https://bugs.webkit.org/show_bug.cgi?id=182641
113
114         Reviewed by Dan Bernstein.
115
116         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
117         https://trac.webkit.org/changeset/228308.
118
119         * WebView/WebVideoFullscreenController.h:
120         * WebView/WebVideoFullscreenHUDWindowController.mm:
121         * WebView/WebWindowAnimation.h:
122         * WebView/WebWindowAnimation.mm:
123         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
124         (WebCore::scaledRect): Deleted.
125         (WebCore::squaredDistance): Deleted.
126
127 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
128
129         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
130
131         * WebView/WebWindowAnimation.mm:
132         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
133
134 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
135
136         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
137         https://bugs.webkit.org/show_bug.cgi?id=182615
138
139         Reviewed by Eric Carlson.
140
141         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
142         Ideally, we should not reference NSApp in WebCore.
143
144         * WebView/WebFullScreenController.mm:
145         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
146         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
147         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
148         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
149         * WebView/WebView.mm:
150         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
151         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
152
153 2018-01-13  Darin Adler  <darin@apple.com>
154
155         Event improvements
156         https://bugs.webkit.org/show_bug.cgi?id=179591
157
158         Reviewed by Chris Dumez.
159
160         * DOM/DOMWheelEvent.mm:
161         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
162         Call initWebKitWheelEvent.
163
164         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
165         * WebCoreSupport/WebInspectorClient.mm: Ditto.
166         * WebView/WebFrame.mm: Ditto.
167
168         * WebView/WebHTMLView.mm:
169         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
170         underlyingPlatformEvent.
171         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
172
173         * WebView/WebScriptWorld.mm:
174         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
175
176         * WebView/WebView.mm: Removed include of ScriptValue.h.
177
178 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
179
180         Remove WebCore/ForwardingHeaders directory
181         https://bugs.webkit.org/show_bug.cgi?id=182347
182
183         Reviewed by Keith Miller.
184
185         * Carbon/CarbonWindowAdapter.mm:
186         * DOM/WebDOMOperations.mm:
187         * History/WebBackForwardList.mm:
188         * History/WebHistoryItem.mm:
189         * Misc/WebCache.mm:
190         * Misc/WebElementDictionary.mm:
191         * Misc/WebIconDatabase.mm:
192         * Misc/WebStringTruncator.mm:
193         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
194         * Plugins/Hosted/ProxyInstance.mm:
195         * Plugins/Hosted/ProxyRuntimeObject.mm:
196         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
197         * Plugins/WebBaseNetscapePluginView.mm:
198         * Plugins/WebBasePluginPackage.mm:
199         * Plugins/WebNetscapePluginStream.mm:
200         * Plugins/WebNetscapePluginView.mm:
201         * Plugins/WebPluginController.mm:
202         * WebCoreSupport/WebEditorClient.mm:
203         * WebCoreSupport/WebFrameLoaderClient.mm:
204         * WebCoreSupport/WebInspectorClient.h:
205         * WebCoreSupport/WebInspectorClient.mm:
206         * WebView/WebDataSource.mm:
207         * WebView/WebFrame.mm:
208         * WebView/WebHTMLRepresentation.mm:
209         * WebView/WebHTMLView.mm:
210         * WebView/WebPreferences.mm:
211         * WebView/WebScriptDebugDelegate.mm:
212         * WebView/WebScriptDebugger.h:
213         * WebView/WebTextIterator.mm:
214         * WebView/WebView.mm:
215         * WebView/WebViewData.mm:
216
217 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
218
219         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
220         https://bugs.webkit.org/show_bug.cgi?id=182312
221
222         Reviewed by Michael Catanzaro.
223
224         * WebKitPrefix.h:
225
226 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
227
228         [WebAuthN] Add a compile-time feature flag
229         https://bugs.webkit.org/show_bug.cgi?id=182211
230         <rdar://problem/36936365>
231
232         Reviewed by Brent Fulgham.
233
234         * Configurations/FeatureDefines.xcconfig:
235
236 2018-01-27  Dan Bernstein  <mitz@apple.com>
237
238         HaveInternalSDK includes should be "#include?"
239         https://bugs.webkit.org/show_bug.cgi?id=179670
240
241         * Configurations/Base.xcconfig:
242
243 2018-01-24  Alex Christensen  <achristensen@webkit.org>
244
245         Remove unused QTKit preference
246         https://bugs.webkit.org/show_bug.cgi?id=181968
247
248         Reviewed by Alexey Proskuryakov.
249
250         * WebView/WebPreferenceKeysPrivate.h:
251         * WebView/WebPreferences.mm:
252         (+[WebPreferences initialize]):
253         (-[WebPreferences setQTKitEnabled:]): Deleted.
254         (-[WebPreferences isQTKitEnabled]): Deleted.
255         * WebView/WebPreferencesPrivate.h:
256         * WebView/WebView.mm:
257         (-[WebView _preferencesChanged:]):
258
259 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
260
261         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
262         https://bugs.webkit.org/show_bug.cgi?id=182037
263         <rdar://problem/36747812>
264
265         Reviewed by Ryosuke Niwa.
266
267         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
268         for more details.
269
270         * WebView/WebHTMLRepresentation.mm:
271         (-[WebHTMLRepresentation elementWithName:inForm:]):
272         (-[WebHTMLRepresentation controlsInForm:]):
273
274 2018-01-23  Alex Christensen  <achristensen@webkit.org>
275
276         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
277         https://bugs.webkit.org/show_bug.cgi?id=181961
278
279         Reviewed by Michael Catanzaro.
280
281         * WebView/WebPreferences.mm:
282
283 2018-01-23  Commit Queue  <commit-queue@webkit.org>
284
285         Unreviewed, rolling out r227437.
286         https://bugs.webkit.org/show_bug.cgi?id=182011
287
288         broke build (Requested by alexchristensen on #webkit).
289
290         Reverted changeset:
291
292         "Remove unused QTKit preference"
293         https://bugs.webkit.org/show_bug.cgi?id=181968
294         https://trac.webkit.org/changeset/227437
295
296 2018-01-23  Alex Christensen  <achristensen@webkit.org>
297
298         Remove unused QTKit preference
299         https://bugs.webkit.org/show_bug.cgi?id=181968
300
301         Reviewed by Alexey Proskuryakov.
302
303         * WebView/WebPreferenceKeysPrivate.h:
304         * WebView/WebPreferences.mm:
305         (+[WebPreferences initialize]):
306         (-[WebPreferences setQTKitEnabled:]): Deleted.
307         (-[WebPreferences isQTKitEnabled]): Deleted.
308         * WebView/WebPreferencesPrivate.h:
309         * WebView/WebView.mm:
310         (-[WebView _preferencesChanged:]):
311
312 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
313
314         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
315         https://bugs.webkit.org/show_bug.cgi?id=181960
316         <rdar://problem/36431678>
317
318         Reviewed by Tim Horton.
319
320         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
321         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
322         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
323
324         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
325         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
326         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
327
328         * WebView/WebView.mm:
329         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
330
331 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
332
333         Turning off custom pasteboard data doesn't actually turn it off in WK2
334         https://bugs.webkit.org/show_bug.cgi?id=181920
335         <rdar://problem/36686429>
336
337         Reviewed by Wenson Hsieh.
338
339         Always disable custom pasteboard data in WebKit1. See r226156 for details.
340
341         * WebView/WebPreferences.mm:
342         (+[WebPreferences initialize]):
343         * WebView/WebView.mm:
344         (-[WebView _preferencesChanged:]):
345
346 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
349         https://bugs.webkit.org/show_bug.cgi?id=181918
350
351         Reviewed by Tim Horton.
352
353         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
354
355         * Configurations/FeatureDefines.xcconfig:
356
357 2018-01-20  Andy Estes  <aestes@apple.com>
358
359         [Apple Pay] Stop eagerly loading PassKit.framework
360         https://bugs.webkit.org/show_bug.cgi?id=181911
361         <rdar://problem/36555369>
362
363         Reviewed by Tim Horton.
364
365         * WebCoreSupport/WebPaymentCoordinatorClient.h:
366         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
367         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
368
369         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
370
371 2018-01-19  Dean Jackson  <dino@apple.com>
372
373         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
374         https://bugs.webkit.org/show_bug.cgi?id=181817
375         <rdar://problem/35274055>
376
377         Reviewed by Simon Fraser.
378
379         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
380
381         * Misc/WebKitVersionChecks.h:
382         * WebView/WebView.mm:
383         (-[WebView _commonInitializationWithFrameName:groupName:]):
384
385 2018-01-19  Alex Christensen  <achristensen@webkit.org>
386
387         Remove unused WebViewPrivate _allowCookies
388         https://bugs.webkit.org/show_bug.cgi?id=181812
389
390         Reviewed by Tim Horton.
391
392         * WebView/WebView.mm:
393         (+[WebView _setAllowCookies:]): Deleted.
394         (+[WebView _allowCookies]): Deleted.
395         * WebView/WebViewPrivate.h:
396
397 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
398
399         Build fix, remove a call to -[NSWindow setOneShot:]
400         https://bugs.webkit.org/show_bug.cgi?id=181809
401
402         Reviewed by Tim Horton.
403
404         * WebView/WebTextCompletionController.mm:
405         (-[WebTextCompletionController _buildUI]):
406
407 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
408
409         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
410
411         * Carbon/HIWebView.mm:
412         (overrideCGContext):
413         (restoreCGContext):
414
415 2018-01-18  Dan Bernstein  <mitz@apple.com>
416
417         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
418         https://bugs.webkit.org/show_bug.cgi?id=181803
419
420         Reviewed by Tim Horton.
421
422         * Configurations/Base.xcconfig: Updated.
423         * Configurations/DebugRelease.xcconfig: Ditto.
424         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
425         * Configurations/Version.xcconfig: Updated.
426         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
427           useful for defining settings that depend on the target macOS version.
428
429 2018-01-17  Youenn Fablet  <youenn@apple.com>
430
431         Put fetch Request.keepalive behind a runtime flag
432         https://bugs.webkit.org/show_bug.cgi?id=181592
433
434         Reviewed by Chris Dumez.
435
436         * WebView/WebPreferenceKeysPrivate.h:
437         * WebView/WebPreferences.mm:
438         (+[WebPreferences initialize]):
439         (-[WebPreferences fetchAPIKeepAliveEnabled]):
440         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
441         * WebView/WebPreferencesPrivate.h:
442         * WebView/WebView.mm:
443         (-[WebView _preferencesChanged:]):
444
445 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
446
447         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
448         https://bugs.webkit.org/show_bug.cgi?id=181637
449         <rdar://problem/36508471>
450
451         Reviewed by Tim Horton.
452
453         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
454
455         * WebCoreSupport/WebEditorClient.h:
456         * WebCoreSupport/WebEditorClient.mm:
457         (WebEditorClient::replacementURLForResource):
458
459 2018-01-11  Keith Miller  <keith_miller@apple.com>
460
461         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
462         https://bugs.webkit.org/show_bug.cgi?id=181573
463
464         Reviewed by Simon Fraser.
465
466         * Configurations/FeatureDefines.xcconfig:
467
468 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
469
470         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
471         https://bugs.webkit.org/show_bug.cgi?id=181497
472
473         Reviewed by Tim Horton.
474
475         See other ChangeLogs for more detail.
476
477         * WebCoreSupport/WebDragClient.h:
478
479 2018-01-11  Tim Horton  <timothy_horton@apple.com>
480
481         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
482         https://bugs.webkit.org/show_bug.cgi?id=181523
483         <rdar://problem/28959131>
484
485         Reviewed by Alex Christensen.
486
487         * WebView/WebImmediateActionController.mm:
488         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
489         Apply the change made in r216652 to WebKit1's immediate action controller.
490
491         Speculative (but successful in WebKit2) fix for non-reproducible crash when
492         the startContainer of the range is in an anonymous node.
493
494 2018-01-11  Youenn Fablet  <youenn@apple.com>
495
496         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
497         https://bugs.webkit.org/show_bug.cgi?id=181480
498
499         Reviewed by Eric Carlson.
500
501         * WebView/WebPreferences.mm:
502         (+[WebPreferences initialize]):
503
504 2018-01-08  David Kilzer  <ddkilzer@apple.com>
505
506         Fix check-webkit-style issues with WebNSDataExtras.mm
507         <https://webkit.org/b/181369>
508
509         Reviewed by Alex Christensen.
510
511         * Misc/WebNSDataExtras.mm:
512         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
513         (-[NSData _webkit_guessedMIMETypeForXML]):
514         (-[NSData _webkit_guessedMIMEType]):
515         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
516         (_findEOL):
517         (-[NSData _webkit_parseRFC822HeaderFields]):
518         (-[NSData _web_locationAfterFirstBlankLine]):
519         - Fix all the check-webkit-style warnings.
520
521 2018-01-08  David Kilzer  <ddkilzer@apple.com>
522
523         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
524         <https://webkit.org/b/181256>
525         <rdar://problem/36281730>
526
527         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
528         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
529         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
530           to avoid warnings from casting CFStringRef to NPNSString*.
531           Note that CFMutableStringRef is the same as CFStringRef
532           without the const modifier, hence its use in the const_cast<>
533           above.
534
535 2018-01-08  David Kilzer  <ddkilzer@apple.com>
536
537         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
538         <https://webkit.org/b/181256>
539         <rdar://problem/36281730>
540
541         * Carbon/HIWebView.mm:
542         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
543         checked_cf_cast<CFRunLoopRef>() to fix warning.
544
545 2018-01-07  David Kilzer  <ddkilzer@apple.com>
546
547         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
548         <https://webkit.org/b/181256>
549         <rdar://problem/36281730>
550
551         Reviewed by Darin Adler.
552
553         * Carbon/CarbonUtils.m:
554         (PoolCleaner):
555         - Use #pragmas to ignore -Wcast-qual warnings when using a
556           C-style cast from CFTypeRef to CFRunloopRef.
557         * Carbon/CarbonWindowFrame.m:
558         (-[CarbonWindowFrame title]):
559         - Use #pragmas to ignore -Wcast-qual warnings when using a
560           C-style cast from CFStringRef to NSString *.
561         * Carbon/HIViewAdapter.m:
562         (+[HIViewAdapter getHIViewForNSView:]):
563         - Use #pragmas to ignore -Wcast-qual warnings when using a
564           C-style cast from CFTypeRef to HIViewRef.
565         * Configurations/Base.xcconfig:
566         (WARNING_CFLAGS): Add -Wcast-qual.
567         * Misc/WebElementDictionary.mm:
568         (-[WebElementDictionary objectForKey:]):
569         - Use static_cast<SEL>(const_cast<void*>()) to fix
570           warning.
571         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
572         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
573         (-[NSData _webkit_guessedMIMETypeForXML]):
574         (-[NSData _webkit_guessedMIMEType]):
575         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
576         (_findEOL):
577         (-[NSData _webkit_parseRFC822HeaderFields]):
578         (-[NSData _web_startsWithBlankLine]):
579         (-[NSData _web_locationAfterFirstBlankLine]):
580         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
581           type to Objective-C++.  This fixes the warnings about
582           discarding the `const` modifier when casing from CFStringRef
583           to NSString * because in older clang versions, -Wcast-qual was
584           completely broken when compiling C++ and Objective-C++ source
585           files.  In newer clang versions, discarding the `const`
586           modifier for toll-free bridged types is ignored when compiling
587           Objective-C++ source.
588         - Update copyright and license header.
589         - Use reinterpret_cast<> and static_cast<> to fix warnings
590           unrelated to (NSString *) C-style casts.
591         - Replace use of MIN() macro with std::min<> template functions.
592         - Fix location of `*` for local variables modified above.
593         * Plugins/Hosted/NetscapePluginHostManager.mm:
594         (WebKit::NetscapePluginHostManager::spawnPluginHost):
595         (WebKit::NetscapePluginHostManager::initializeVendorPort):
596         (WebKit::NetscapePluginHostManager::instantiatePlugin):
597         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
598           warnings.
599         * Plugins/Hosted/NetscapePluginHostProxy.mm:
600         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
601         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
602           to fix warning.
603         * Plugins/Hosted/ProxyInstance.mm:
604         (WebKit::ProxyInstance::invoke):
605         - Use static_cast<char*>(const_cast<void*>()) to fix
606           warning when using -[NSData bytes].
607         (WebKit::ProxyInstance::fieldValue const):
608         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
609           to fix warning when using CFDataGetBytePtr().
610         * Plugins/Hosted/WebTextInputWindowController.m:
611         (-[WebTextInputPanel _interpretKeyEvent:string:]):
612         - Use #pragma to ignore -Wcast-qual warning since there
613           is not a good way to avoid this warning in Objective-C.
614         * Plugins/WebNetscapePluginStream.mm:
615         (WebNetscapePluginStream::deliverData):
616         - Use const_cast<void*>() to fix warning when using
617           -[NSData bytes].
618         * Plugins/WebNetscapePluginView.mm:
619         (-[WebNetscapePluginView _createPlugin]):
620         - Change C-style cast to const_cast<char*>() to fix
621           warning.
622         * WebCoreSupport/WebChromeClient.mm:
623         (WebChromeClient::wrapCryptoKey const):
624         (WebChromeClient::unwrapCryptoKey const):
625         - Change C-style cast to
626           static_cast<uint8_t*>(const_cast<void*>() to fix
627           warning.
628         * WebView/WebPDFView.mm:
629         (_applicationInfoForMIMEType):
630         - Change local variable type from 'NSURL *' to
631           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
632           when calling -[NSURL path].
633
634 2018-01-05  Dan Bernstein  <mitz@apple.com>
635
636         Fixed the build following AppKit API deprecations in a recent SDKs
637
638         * WebView/WebFullScreenController.mm:
639         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
640         (-[WebFullScreenController exitFullScreen]): Ditto.
641         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
642         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
643         * WebView/WebHTMLView.mm:
644         (-[WebHTMLView drawRect:]): Ditto.
645         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
646         (-[WebHTMLView knowsPageRange:]): Ditto.
647         * WebView/WebView.mm:
648         (LayerFlushController::flushLayers): Ditto.
649
650 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
651
652         [Attachment Support] Create attachment elements when dropping files on iOS
653         https://bugs.webkit.org/show_bug.cgi?id=181192
654         <rdar://problem/36280945>
655
656         Reviewed by Tim Horton.
657
658         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
659
660         * WebCoreSupport/WebPlatformStrategies.h:
661         * WebCoreSupport/WebPlatformStrategies.mm:
662         (WebPlatformStrategies::informationForItemAtIndex):
663         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
664
665 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
666
667         [Attachment Support] Add plumbing for starting a drag with promised blob data
668         https://bugs.webkit.org/show_bug.cgi?id=181201
669
670         Reviewed by Tim Horton.
671
672         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
673
674         * WebCoreSupport/WebDragClient.h:
675
676 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
677
678         Add a WebAuthentication runtime feature flag
679         https://bugs.webkit.org/show_bug.cgi?id=181220
680         <rdar://problem/36055305>
681
682         Reviewed by Brent Fulgham.
683
684         Renames the CredentialManagement runtime feature flag into WebAuthentication.
685
686         * WebView/WebPreferenceKeysPrivate.h:
687         * WebView/WebPreferences.mm:
688         (+[WebPreferences initialize]):
689         (-[WebPreferences webAuthenticationEnabled]):
690         (-[WebPreferences setWebAuthenticationEnabled:]):
691         (-[WebPreferences credentialManagementEnabled]): Deleted.
692         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
693         * WebView/WebPreferencesPrivate.h:
694         * WebView/WebView.mm:
695         (-[WebView _preferencesChanged:]):
696
697 2017-12-22  Jeff Miller  <jeffm@apple.com>
698
699         Update user-visible copyright strings to include 2018
700         https://bugs.webkit.org/show_bug.cgi?id=181141
701
702         Reviewed by Dan Bernstein.
703
704         * Info.plist:
705
706 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
707
708         [Attachment Support] Remove current macOS support for dragging file-backed attachments
709         https://bugs.webkit.org/show_bug.cgi?id=181188
710
711         Reviewed by Dan Bernstein.
712
713         See WebCore/ChangeLog for more detail.
714
715         * WebCoreSupport/WebDragClient.h:
716         * WebCoreSupport/WebDragClient.mm:
717         (WebDragClient::declareAndWriteAttachment): Deleted.
718         * WebView/WebHTMLView.mm:
719         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
720
721 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
722
723         Unreviewed, continue to fix build failures due to AppKit API deprecation
724
725         Wraps more code in -Wdeprecated-declarations.
726
727         * Carbon/HIWebView.mm:
728         (overrideCGContext):
729
730 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
731
732         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
733
734         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
735
736         * Carbon/CarbonWindowAdapter.mm:
737         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
738         * Plugins/WebNetscapePluginView.mm:
739         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
740         (-[WebNetscapePluginView sendDrawRectEvent:]):
741         (-[WebNetscapePluginView drawRect:]):
742
743 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
744
745         Fix build failures due to using deprecated AppKit symbols
746         https://bugs.webkit.org/show_bug.cgi?id=181110
747         <rdar://problem/36162865>
748
749         Reviewed by Dan Bernstein and Tim Horton.
750
751         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
752
753         * Misc/WebKitNSStringExtras.mm:
754         (-[NSString _web_drawAtPoint:font:textColor:]):
755         * Misc/WebNSPasteboardExtras.h:
756         * Misc/WebNSPasteboardExtras.mm:
757         (+[NSPasteboard _web_writableTypesForURL]):
758         (_createWritableTypesForImageWithoutArchive):
759         (_createWritableTypesForImageWithArchive):
760         (+[NSPasteboard _web_dragTypesForURL]):
761         (-[NSPasteboard _web_bestURL]):
762         (-[NSPasteboard _web_writeURL:andTitle:types:]):
763         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
764         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
765         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
766         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
767         * Panels/WebAuthenticationPanel.m:
768         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
769         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
770         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
771         (-[WebHostedNetscapePluginView drawRect:]):
772         * WebInspector/WebNodeHighlightView.mm:
773         (-[WebNodeHighlightView drawRect:]):
774         * WebView/WebFrame.mm:
775         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
776         (-[WebFrame _drawRect:contentsOnly:]):
777         * WebView/WebHTMLView.mm:
778         (kit):
779         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
780         (-[WebHTMLView _plainTextFromPasteboard:]):
781         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
782         (+[WebHTMLView _insertablePasteboardTypes]):
783         (+[WebHTMLView _selectionPasteboardTypes]):
784         (-[WebHTMLView pasteboard:provideDataForType:]):
785         (-[WebHTMLView _writeSelectionToPasteboard:]):
786         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
787         (-[WebHTMLView validRequestorForSendType:returnType:]):
788         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
789         (createMenuItem):
790         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
791         (-[WebHTMLView _colorAsString:]):
792         (-[WebHTMLView copyFont:]):
793         * WebView/WebPDFView.mm:
794         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
795         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
796         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
797         (-[WebPDFView pasteboardTypesForSelection]):
798         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
799         * WebView/WebView.h:
800         * WebView/WebView.mm:
801         (-[WebView performDragOperation:]):
802         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
803         (-[WebView _searchWithGoogleFromMenu:]):
804
805 2017-12-21  Youenn Fablet  <youenn@apple.com>
806
807         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
808         https://bugs.webkit.org/show_bug.cgi?id=181000
809
810         Reviewed by Chris Dumez.
811
812         * Misc/WebCache.mm:
813         (+[WebCache addImageToCache:forURL:forFrame:]):
814
815 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
816
817         Update FULLSCREEN_API feature defines.
818         https://bugs.webkit.org/show_bug.cgi?id=181015
819
820         Reviewed by Tim Horton.
821
822         Change enabled iphone sdk for FULLSCREEN_API.
823
824         * Configurations/FeatureDefines.xcconfig:
825
826 2017-12-21  Jer Noble  <jer.noble@apple.com>
827
828         Add initial DOM support for Media Capabilities
829         https://bugs.webkit.org/show_bug.cgi?id=181064
830
831         Reviewed by Eric Carlson.
832
833         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
834
835         * WebView/WebPreferenceKeysPrivate.h:
836         * WebView/WebPreferences.mm:
837         (+[WebPreferences initialize]):
838         (-[WebPreferences mediaCapabilitiesEnabled]):
839         (-[WebPreferences setMediaCapabilitiesEnabled:]):
840         * WebView/WebPreferencesPrivate.h:
841         * WebView/WebView.mm:
842         (-[WebView _preferencesChanged:]):
843
844 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
845
846         Enable picture-in-picture from inline element on suspend.
847         https://bugs.webkit.org/show_bug.cgi?id=180942
848         rdar://problem/34745234
849
850         Reviewed by Jer Noble.
851
852         Update signature of enterVideoFullscreenForVideoElement().
853
854         * WebCoreSupport/WebChromeClient.h:
855         * WebCoreSupport/WebChromeClient.mm:
856         (WebChromeClient::enterVideoFullscreenForVideoElement):
857
858 2017-12-20  Daniel Bates  <dabates@apple.com>
859
860         Remove Alternative Presentation Button
861         https://bugs.webkit.org/show_bug.cgi?id=180500
862         <rdar://problem/35891047>
863
864         Reviewed by Simon Fraser.
865
866         We no longer need the alternative presentation button.
867
868         * Configurations/FeatureDefines.xcconfig:
869
870 2017-12-19  Jer Noble  <jer.noble@apple.com>
871
872         Playing media elements which call "pause(); play()" will have the play promise rejected.
873         https://bugs.webkit.org/show_bug.cgi?id=180781
874         <rdar://problem/33191377>
875
876         Reviewed by Eric Carlson.
877
878         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
879
880         * WebView/WebView.mm:
881         (shouldRequireUserGestureToLoadVideo):
882
883 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
884
885         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
886         https://bugs.webkit.org/show_bug.cgi?id=180977
887
888         Reviewed by Tim Horton.
889
890         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
891         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
892         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
893
894         * WebCoreSupport/WebEditorClient.mm:
895         (attributesForAttributedStringConversion):
896         * WebView/WebHTMLView.mm:
897         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
898
899 2017-12-18  David Kilzer  <ddkilzer@apple.com>
900
901         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
902
903         Attempt to fix the following warnings:
904
905             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
906
907         For the following instance variables:
908
909             _borderView
910             _contentView
911             _frame
912             _wFlags
913
914         * Carbon/CarbonWindowAdapter.mm:
915         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
916         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
917         (-[CarbonWindowAdapter _termWindowIfOwner]):
918         (-[CarbonWindowAdapter _windowMovedToRect:]):
919         (-[CarbonWindowAdapter setContentView:]):
920         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
921         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
922
923 2017-12-16  Dan Bernstein  <mitz@apple.com>
924
925         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
926         https://bugs.webkit.org/show_bug.cgi?id=180613
927         <rdar://problem/35946124>
928
929         Reviewed by Geoff Garen.
930
931         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
932           clients.
933         * WebView/WebDynamicScrollBarsView.h: Ditto.
934         * WebView/WebDynamicScrollBarsView.mm: Ditto.
935
936 2017-12-14  David Kilzer  <ddkilzer@apple.com>
937
938         Enable -Wstrict-prototypes for WebKit
939         <https://webkit.org/b/180757>
940         <rdar://problem/36024132>
941
942         Rubber-stamped by Joseph Pecoraro.
943
944         * Configurations/Base.xcconfig:
945         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
946
947 2017-12-14  John Wilander  <wilander@apple.com>
948
949         Storage Access API: Implement frame-specific access in the document.cookie layer
950         https://bugs.webkit.org/show_bug.cgi?id=180682
951         <rdar://problem/35982257>
952
953         Reviewed by Alex Christensen.
954
955         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
956         CookiesStrategy::cookieRequestHeaderFieldValue(), and
957         CookiesStrategy::getRawCookies() now take optional parameters for
958         frameID and pageID to allow frame-specific scoping of cookies.
959
960         This change makes the return values of FrameLoaderClient::frameID()
961         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
962         WebCore can call those getters and get the right return values in
963         WebKit and std:nullopt in WebKitLegacy.
964
965         * WebCoreSupport/WebFrameLoaderClient.h:
966         * WebCoreSupport/WebFrameLoaderClient.mm:
967         (WebFrameLoaderClient::pageID const):
968         (WebFrameLoaderClient::frameID const):
969         * WebCoreSupport/WebPlatformStrategies.h:
970         * WebCoreSupport/WebPlatformStrategies.mm:
971         (WebPlatformStrategies::cookiesForDOM):
972         (WebPlatformStrategies::setCookiesFromDOM):
973         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
974         (WebPlatformStrategies::getRawCookies):
975
976 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
977
978         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
979         https://bugs.webkit.org/show_bug.cgi?id=180689
980
981         Reviewed by Tim Horton.
982
983         Use sRGBColorSpaceRef() from WebCore.
984
985         * WebView/WebHTMLView.mm:
986         (imageFromRect):
987
988 2017-12-11  Tim Horton  <timothy_horton@apple.com>
989
990         Stop using deprecated target conditional for simulator builds
991         https://bugs.webkit.org/show_bug.cgi?id=180662
992         <rdar://problem/35136156>
993
994         Reviewed by Simon Fraser.
995
996         * postprocess-headers.sh:
997
998 2017-12-11  David Quesada  <david_quesada@apple.com>
999
1000         Turn on ENABLE_APPLICATION_MANIFEST
1001         https://bugs.webkit.org/show_bug.cgi?id=180562
1002         rdar://problem/35924737
1003
1004         Reviewed by Geoffrey Garen.
1005
1006         * Configurations/FeatureDefines.xcconfig:
1007
1008 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1009
1010         Remove pthread_once in favor of dispatch_once
1011         https://bugs.webkit.org/show_bug.cgi?id=180591
1012
1013         Reviewed by Saam Barati.
1014
1015         * Misc/WebKitErrors.m:
1016         (+[NSError _registerWebKitErrors]):
1017         (registerErrors): Deleted.
1018         * Storage/WebStorageManager.mm:
1019         (+[WebStorageManager _storageDirectoryPath]):
1020         (initializeLocalStoragePath): Deleted.
1021
1022 2017-12-07  Darin Adler  <darin@apple.com>
1023
1024         Remove some unused code from WebKitLegacy
1025         https://bugs.webkit.org/show_bug.cgi?id=180567
1026
1027         Reviewed by Anders Carlsson.
1028
1029         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1030         macOS (back a few versions) and iOS and removed unused
1031         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1032         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1033         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1034         _webkit_stringByCollapsingNonPrintingCharacters,
1035         _webkit_stringByCollapsingWhitespaceCharacters,
1036         _web_stringWithData:textEncodingName:, and
1037         _webkit_localStorageDirectoryWithBundleIdentifier:.
1038
1039         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1040         this source file.
1041         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1042         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1043         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1044         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1045         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1046         handle font smoothing options.
1047         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1048         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1049         from header and made it a little clearer.
1050         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1051         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1052         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1053         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1054         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1055         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1056         implementation a bit and used whole words instead of abbreviations.
1057         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1058
1059         * Misc/WebNSFileManagerExtras.mm:
1060         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1061         filenameByFixingIllegalCharacters function from WebCore directly instead of
1062         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1063
1064         * Plugins/WebBaseNetscapePluginView.mm:
1065         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1066         string replacements instead of _web_stringByStrippingReturnCharacters
1067         and to use NSString methods instead of CFString functions.
1068
1069 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1070
1071         Ignore deprecation warnings.
1072
1073         * WebView/WebHTMLView.mm:
1074         (-[NSWindow _web_borderView]):
1075         (-[WebHTMLView _setAsideSubviews]):
1076         * WebView/WebView.mm:
1077         (-[WebView encodeWithCoder:]):
1078
1079 2017-12-02  Darin Adler  <darin@apple.com>
1080
1081         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1082         https://bugs.webkit.org/show_bug.cgi?id=180009
1083
1084         Reviewed by Alex Christensen.
1085
1086         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1087
1088         * Plugins/WebBaseNetscapePluginView.mm:
1089         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1090         of strcasecmp.
1091
1092         * WebView/WebPreferences.mm:
1093         (contains): Ditto. Also made this a template so it's easier to call on an array.
1094         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1095
1096 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1097
1098         Limit user agent versioning to an upper bound
1099         https://bugs.webkit.org/show_bug.cgi?id=180365
1100         <rdar://problem/34550617>
1101
1102         Reviewed by Joseph Pecoraro.
1103
1104         * WebView/WebView.mm:
1105         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1106         creating the User Agent string.
1107         (webKitBundleVersionString): Deleted.
1108
1109 2017-12-05  Andy Estes  <aestes@apple.com>
1110
1111         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1112         https://bugs.webkit.org/show_bug.cgi?id=180457
1113         <rdar://problem/35143007>
1114
1115         Reviewed by Tim Horton.
1116
1117         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1118         check for this macro during post-processing.
1119
1120         * postprocess-headers.sh:
1121
1122 2017-12-04  David Quesada  <david_quesada@apple.com>
1123
1124         Add a class for parsing application manifests
1125         https://bugs.webkit.org/show_bug.cgi?id=177973
1126         rdar://problem/34747949
1127
1128         Reviewed by Geoffrey Garen.
1129
1130         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1131
1132 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1133
1134         Make LegacyCustomProtocolManager optional for network process
1135         https://bugs.webkit.org/show_bug.cgi?id=176230
1136
1137         Reviewed by Alex Christensen.
1138
1139         * Configurations/FeatureDefines.xcconfig:
1140
1141 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1142
1143         Fix some NSOperationQueue leaks
1144         https://bugs.webkit.org/show_bug.cgi?id=180221
1145
1146         Reviewed by Wenson Hsieh.
1147
1148         * WebView/WebView.mm:
1149         (-[WebView performDragOperation:]):
1150
1151 2017-11-30  Darin Adler  <darin@apple.com>
1152
1153         [Mac] remove unneeded RetainPtr use introduced in r225142
1154         https://bugs.webkit.org/show_bug.cgi?id=180202
1155
1156         Reviewed by Tim Horton.
1157
1158         * WebView/WebImmediateActionController.mm:
1159         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1160         RetainPtr.
1161
1162 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1163
1164         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1165         https://bugs.webkit.org/show_bug.cgi?id=175595
1166
1167         Reviewed by Darin Adler.
1168
1169         * WebView/WebPreferences.mm:
1170
1171 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1172
1173         One too many zeroes in macOS version number in FeatureDefines
1174         https://bugs.webkit.org/show_bug.cgi?id=180011
1175
1176         Reviewed by Dan Bernstein.
1177
1178         * Configurations/FeatureDefines.xcconfig:
1179
1180 2017-11-23  Darin Adler  <darin@apple.com>
1181
1182         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1183         https://bugs.webkit.org/show_bug.cgi?id=179981
1184
1185         Reviewed by Sam Weinig.
1186
1187         * WebView/WebImmediateActionController.mm:
1188         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1189         * WebView/WebView.mm:
1190         (coreOptions): Use |= instead of | to build up FindOptions.
1191
1192 2017-11-23  Sam Weinig  <sam@webkit.org>
1193
1194         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1195         https://bugs.webkit.org/show_bug.cgi?id=179954
1196
1197         Reviewed by Darin Adler.
1198
1199         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1200         with direct calls to the corresponding UserGestureIndicator functions.
1201
1202         * Plugins/WebPluginController.mm:
1203         (-[WebPluginController processingUserGesture]):
1204         * WebView/WebView.mm:
1205         (-[WebView _isProcessingUserGesture]):
1206
1207 2017-11-23  Darin Adler  <darin@apple.com>
1208
1209         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1210         https://bugs.webkit.org/show_bug.cgi?id=179907
1211
1212         Reviewed by Sam Weinig.
1213
1214         * History/BinaryPropertyList.cpp:
1215         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1216         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1217         * WebView/WebHTMLRepresentation.mm:
1218         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1219         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1220
1221 2017-11-22  Ali Juma  <ajuma@chromium.org>
1222
1223         Implement VisualViewport API attributes
1224         https://bugs.webkit.org/show_bug.cgi?id=179385
1225
1226         Reviewed by Frédéric Wang.
1227
1228         Add a VisualViewportAPI preference.
1229
1230         * WebView/WebPreferenceKeysPrivate.h:
1231         * WebView/WebPreferences.mm:
1232         (+[WebPreferences initialize]):
1233         (-[WebPreferences visualViewportAPIEnabled]):
1234         (-[WebPreferences setVisualViewportAPIEnabled:]):
1235         * WebView/WebPreferencesPrivate.h:
1236         * WebView/WebView.mm:
1237         (-[WebView _preferencesChanged:]):
1238
1239 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1240
1241         WebCoreObjCExtras.h is being included in too many places
1242         https://bugs.webkit.org/show_bug.cgi?id=179931
1243
1244         Reviewed by Darin Adler.
1245
1246         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1247         * Plugins/WebBaseNetscapePluginView.mm:
1248         * Plugins/WebBasePluginPackage.mm:
1249         * Plugins/WebNetscapePluginStream.mm:
1250         * Plugins/WebNetscapePluginView.mm:
1251         * WebView/WebTextIterator.mm:
1252         * WebView/WebViewData.mm:
1253
1254 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1255
1256         Unreviewed, rolling out r225093.
1257         https://bugs.webkit.org/show_bug.cgi?id=179938
1258
1259         Compilation failed on WinCairo 64-bit Release (Requested by
1260         fredw on #webkit).
1261
1262         Reverted changeset:
1263
1264         "Implement VisualViewport API attributes"
1265         https://bugs.webkit.org/show_bug.cgi?id=179385
1266         https://trac.webkit.org/changeset/225093
1267
1268 2017-11-21  Ali Juma  <ajuma@chromium.org>
1269
1270         Implement VisualViewport API attributes
1271         https://bugs.webkit.org/show_bug.cgi?id=179385
1272
1273         Reviewed by Frédéric Wang.
1274
1275         Add a VisualViewportAPI preference.
1276
1277         * WebView/WebPreferenceKeysPrivate.h:
1278         * WebView/WebPreferences.mm:
1279         (+[WebPreferences initialize]):
1280         (-[WebPreferences visualViewportAPIEnabled]):
1281         (-[WebPreferences setVisualViewportAPIEnabled:]):
1282         * WebView/WebPreferencesPrivate.h:
1283         * WebView/WebView.mm:
1284         (-[WebView _preferencesChanged:]):
1285
1286 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1287
1288         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1289         https://bugs.webkit.org/show_bug.cgi?id=179504
1290
1291         Reviewed by Darin Adler.
1292
1293         * Misc/WebKitNSStringExtras.mm:
1294         * Plugins/Hosted/NetscapePluginHostManager.mm:
1295         * Plugins/WebBasePluginPackage.mm:
1296
1297 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1298
1299         Remove unused TOUCH_ICON_LOADING feature flag
1300         https://bugs.webkit.org/show_bug.cgi?id=179873
1301
1302         Reviewed by Simon Fraser.
1303
1304         * Configurations/FeatureDefines.xcconfig:
1305
1306 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1307
1308         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1309         https://bugs.webkit.org/show_bug.cgi?id=179872
1310
1311         Reviewed by Darin Adler.
1312
1313         * Configurations/FeatureDefines.xcconfig:
1314
1315 2017-11-16  Daniel Bates  <dabates@apple.com>
1316
1317         Add feature define for alternative presentation button element
1318         https://bugs.webkit.org/show_bug.cgi?id=179692
1319         Part of <rdar://problem/34917108>
1320
1321         Reviewed by Andy Estes.
1322
1323         Only enabled on Cocoa platforms by default.
1324
1325         * Configurations/FeatureDefines.xcconfig:
1326
1327 2017-11-14  Nan Wang  <n_wang@apple.com>
1328
1329         AX: AOM: Implement AccessibleNode class and support label and role attributes
1330         https://bugs.webkit.org/show_bug.cgi?id=179494
1331
1332         Reviewed by Ryosuke Niwa.
1333
1334         * WebView/WebPreferenceKeysPrivate.h:
1335         * WebView/WebPreferences.mm:
1336         (+[WebPreferences initialize]):
1337         (-[WebPreferences accessibilityObjectModelEnabled]):
1338         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1339         * WebView/WebPreferencesPrivate.h:
1340         * WebView/WebView.mm:
1341         (-[WebView _preferencesChanged:]):
1342
1343 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1344
1345         Remove Cocoa CFURLConnection loading code
1346         https://bugs.webkit.org/show_bug.cgi?id=179688
1347
1348         Reviewed by Antti Koivisto.
1349
1350         * Misc/WebDownload.mm:
1351         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1352         * Misc/WebDownloadInternal.h:
1353         * Plugins/WebBaseNetscapePluginView.mm:
1354         * WebCoreSupport/WebFrameLoaderClient.mm:
1355         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1356         * WebView/WebView.mm:
1357         (-[WebView scheduleInRunLoop:forMode:]):
1358         (-[WebView unscheduleFromRunLoop:forMode:]):
1359
1360 2017-11-14  Daniel Bates  <dabates@apple.com>
1361
1362         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1363         for feature defines
1364
1365         Following r195498 and r201917 the Visual Studio property files for feature defines have
1366         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1367         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1368         files.
1369
1370         * Configurations/FeatureDefines.xcconfig:
1371
1372 2017-11-14  Jer Noble  <jer.noble@apple.com>
1373
1374         Enable Modern EME tests in DumpRenderTree
1375         https://bugs.webkit.org/show_bug.cgi?id=179544
1376
1377         Reviewed by Alex Christensen.
1378
1379         Add a WebPreferences property to enable the (modern) EME API.
1380
1381         * WebView/WebPreferenceKeysPrivate.h:
1382         * WebView/WebPreferences.mm:
1383         (+[WebPreferences initialize]):
1384         (-[WebPreferences encryptedMediaAPIEnabled]):
1385         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1386         * WebView/WebPreferencesPrivate.h:
1387         * WebView/WebView.mm:
1388         (-[WebView _preferencesChanged:]):
1389
1390 2017-11-14  Antti Koivisto  <antti@apple.com>
1391
1392         Enable display:contents by default
1393         https://bugs.webkit.org/show_bug.cgi?id=179655
1394
1395         Reviewed by Sam Weinig.
1396
1397         * WebView/WebPreferences.mm:
1398         (+[WebPreferences initialize]):
1399
1400 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1401
1402         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1403         https://bugs.webkit.org/show_bug.cgi?id=178751
1404
1405         Reviewed by Brady Eidson.
1406
1407         * WebCoreSupport/WebFrameNetworkingContext.mm:
1408         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1409
1410 2017-11-08  Keith Miller  <keith_miller@apple.com>
1411
1412         Async iteration should only fetch the next method once and add feature flag
1413         https://bugs.webkit.org/show_bug.cgi?id=179451
1414
1415         Reviewed by Geoffrey Garen.
1416
1417         Add feature flag for Async iteration.
1418
1419         * Configurations/FeatureDefines.xcconfig:
1420
1421 2017-11-13  Mark Lam  <mark.lam@apple.com>
1422
1423         Add more overflow check book-keeping for MarkedArgumentBuffer.
1424         https://bugs.webkit.org/show_bug.cgi?id=179634
1425         <rdar://problem/35492517>
1426
1427         Reviewed by Saam Barati.
1428
1429         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1430         (WebKit::NetscapePluginInstanceProxy::invoke):
1431         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1432         (WebKit::NetscapePluginInstanceProxy::construct):
1433
1434 2017-11-12  Darin Adler  <darin@apple.com>
1435
1436         More is<> and downcast<>, less static_cast<>
1437         https://bugs.webkit.org/show_bug.cgi?id=179600
1438
1439         Reviewed by Chris Dumez.
1440
1441         * DOM/DOM.mm:
1442         (kit): Use is/downcast.
1443         * WebCoreSupport/WebEditorClient.mm:
1444         (WebEditorClient::handleKeyboardEvent): Ditto.
1445         (WebEditorClient::handleInputMethodKeydown): Ditto.
1446         * WebView/WebHTMLView.mm:
1447         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1448
1449 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1450
1451         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1452         https://bugs.webkit.org/show_bug.cgi?id=179397
1453
1454         Reviewed by Wenson Hsieh.
1455
1456         * DOM/DOMHTMLInputElement.mm:
1457         (-[DOMHTMLInputElement insertTextSuggestion:]):
1458
1459 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1460
1461         HTMLMediaElement should not use element fullscreen on iOS
1462         https://bugs.webkit.org/show_bug.cgi?id=179418
1463         rdar://problem/35409277
1464
1465         Reviewed by Eric Carlson.
1466
1467         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1468
1469         * Configurations/FeatureDefines.xcconfig:
1470
1471 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1472
1473         Make ResourceLoader::willSendRequestInternal asynchronous
1474         https://bugs.webkit.org/show_bug.cgi?id=179251
1475
1476         Reviewed by Andy Estes.
1477
1478         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1479         (WebKit::HostedNetscapePluginStream::start):
1480         * Plugins/WebNetscapePluginStream.mm:
1481         (WebNetscapePluginStream::start):
1482
1483 2017-11-01  Darin Adler  <darin@apple.com>
1484
1485         Simplify event dispatch code and make it a bit more consistent
1486         https://bugs.webkit.org/show_bug.cgi?id=178991
1487
1488         Reviewed by Chris Dumez.
1489
1490         * DOM/DOMEvent.mm:
1491         (-[DOMEvent srcElement]): Call target instead of srcElement.
1492
1493 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1494
1495         [Touch Bar Web API] Add support for menuitem tag
1496         https://bugs.webkit.org/show_bug.cgi?id=179020
1497
1498         Reviewed by Ryosuke Niwa.
1499
1500         Adds in properties and methods that allow the menuitem runtime feature
1501         to be enabled or disabled.
1502
1503         * WebView/WebPreferenceKeysPrivate.h:
1504         * WebView/WebPreferences.mm:
1505         (-[WebPreferences menuItemElementEnabled]):
1506         (-[WebPreferences setMenuItemElementEnabled:]):
1507         * WebView/WebPreferencesPrivate.h:
1508         * WebView/WebView.mm:
1509         (-[WebView _preferencesChanged:]):
1510
1511 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1512
1513         Use CompletionHandlers for redirects
1514         https://bugs.webkit.org/show_bug.cgi?id=179163
1515
1516         Reviewed by Tim Horton.
1517
1518         * Plugins/Hosted/HostedNetscapePluginStream.h:
1519         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1520         (WebKit::HostedNetscapePluginStream::willSendRequest):
1521         * Plugins/WebNetscapePluginStream.h:
1522         * Plugins/WebNetscapePluginStream.mm:
1523         (WebNetscapePluginStream::willSendRequest):
1524
1525 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1526
1527         Add a FileSystem namespace to FileSystem.cpp
1528         https://bugs.webkit.org/show_bug.cgi?id=179063
1529
1530         Reviewed by Darin Adler.
1531
1532         * Misc/WebNSFileManagerExtras.mm:
1533         * Storage/WebDatabaseProvider.mm:
1534
1535 2017-11-02  Frederic Wang  <fwang@igalia.com>
1536
1537         Add references to bug 179167 in FIXME comments
1538         https://bugs.webkit.org/show_bug.cgi?id=179168
1539
1540         Reviewed by Daniel Bates.
1541
1542         * Configurations/FeatureDefines.xcconfig:
1543
1544 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1545
1546         Implement WKFullscreenWindowController for iOS.
1547         https://bugs.webkit.org/show_bug.cgi?id=178924
1548         rdar://problem/34697120
1549
1550         Reviewed by Simon Fraser.
1551
1552         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1553
1554         * Configurations/FeatureDefines.xcconfig:
1555         * WebView/WebView.mm:
1556         (-[WebView fullScreenPlaceholderView]):
1557
1558 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1559
1560         Clean up some drag and drop feature flags
1561         https://bugs.webkit.org/show_bug.cgi?id=179082
1562
1563         Reviewed by Simon Fraser.
1564
1565         * Configurations/FeatureDefines.xcconfig:
1566
1567 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1568
1569         Make it possible to test rubber-banding in overflow scroll
1570         https://bugs.webkit.org/show_bug.cgi?id=179078
1571
1572         Reviewed by Sam Weinig.
1573
1574         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1575         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1576
1577         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1578         functions, since most callers want clamped.
1579
1580         * DOM/DOMHTML.mm:
1581         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1582
1583 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1584
1585         Fix up some content filtering feature flags
1586         https://bugs.webkit.org/show_bug.cgi?id=179079
1587
1588         Reviewed by Simon Fraser.
1589
1590         * Configurations/FeatureDefines.xcconfig:
1591
1592 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1593
1594         [FrameView::layout cleanup] Move core layout logic to a separate class.
1595         https://bugs.webkit.org/show_bug.cgi?id=178771
1596         <rdar://problem/35166542>
1597
1598         Reviewed by Simon Fraser.
1599
1600         Move layout code out from FrameView to LayoutContext.
1601
1602         * WebView/WebClipView.mm:
1603         (-[WebClipView _immediateScrollToPoint:]):
1604         * WebView/WebFrame.mm:
1605         (-[WebFrame layoutCount]):
1606
1607 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1608
1609         Fix issues with WebView subframe painting
1610         https://bugs.webkit.org/show_bug.cgi?id=178842
1611         rdar://problem/34072253
1612
1613         Reviewed by Daniel Bates.
1614         
1615         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1616         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1617         High Sierra, so match the new signature.
1618
1619         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1620
1621         * WebView/WebHTMLView.mm:
1622         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1623         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1624
1625 2017-10-25  Youenn Fablet  <youenn@apple.com>
1626
1627         Enable ServiceWorker to fetch resources
1628         https://bugs.webkit.org/show_bug.cgi?id=178673
1629
1630         Reviewed by Brady Eidson.
1631
1632         * WebCoreSupport/WebFrameLoaderClient.mm:
1633         (WebFrameLoaderClient::pageID const):
1634         (WebFrameLoaderClient::frameID const):
1635         (WebFrameLoaderClient::sessionID const):
1636
1637         Added implementation to the new getters.
1638         They are noop in the context of WK1.
1639
1640 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1641
1642         Web Inspector: Enable WebKit logging configuration and display
1643         https://bugs.webkit.org/show_bug.cgi?id=177027
1644         <rdar://problem/33964767>
1645
1646         Reviewed by Joseph Pecoraro.
1647
1648         * WebCoreSupport/WebChromeClient.mm:
1649         (stringForMessageSource): Deal with Media and WebRTC message sources.
1650
1651 2017-10-20  Antoine Quint  <graouts@apple.com>
1652
1653         [Web Animations] Provide basic timeline and animation interfaces
1654         https://bugs.webkit.org/show_bug.cgi?id=178526
1655
1656         Reviewed by Dean Jackson.
1657
1658         Remove the WEB_ANIMATIONS compile-time flag.
1659
1660         * Configurations/FeatureDefines.xcconfig:
1661         * WebView/WebPreferences.mm:
1662         (+[WebPreferences initialize]):
1663         * WebView/WebView.mm:
1664         (-[WebView _preferencesChanged:]):
1665
1666 2017-10-19  Sam Weinig  <sam@webkit.org>
1667
1668         [Settings] Move global settings into their own file
1669         https://bugs.webkit.org/show_bug.cgi?id=178512
1670
1671         Reviewed by Darin Adler.
1672
1673         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1674
1675         * WebCoreSupport/WebChromeClient.mm:
1676         (WebChromeClient::supportsVideoFullscreen):
1677         * WebView/WebDynamicScrollBarsView.mm:
1678         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1679         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1680         * WebView/WebPreferences.mm:
1681         (+[WebPreferences initialize]):
1682         * WebView/WebView.mm:
1683         (-[WebView _commonInitializationWithFrameName:groupName:]):
1684         (-[WebView _preferencesChanged:]):
1685         (+[WebView _doNotStartObservingNetworkReachability]):
1686
1687 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1688
1689         Replace some stack raw pointers with RefPtrs within WebCore/html
1690         https://bugs.webkit.org/show_bug.cgi?id=178201
1691         <rdar://problem/34841692>
1692
1693         Reviewed by Ryosuke Niwa.
1694
1695         * DOM/DOM.mm:
1696         (kit):
1697         Change the type of node as toNode() is changed to return RefPtr.
1698
1699 2017-10-18  Chris Dumez  <cdumez@apple.com>
1700
1701         [Service Worker] Add stubs for Client / WindowClient / Clients
1702         https://bugs.webkit.org/show_bug.cgi?id=178469
1703
1704         Reviewed by Youenn Fablet.
1705
1706         Rename PageVisiblityState to VisibilityState.
1707
1708         * WebView/WebView.mm:
1709         (kit):
1710
1711 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1712
1713         Unreviewed, rolling out r223291.
1714
1715         See WebCore ChangeLog for more detail.
1716
1717         Reverted changeset:
1718
1719         "Remove Editor::simplifyMarkup"
1720         https://bugs.webkit.org/show_bug.cgi?id=178271
1721         https://trac.webkit.org/changeset/223291
1722
1723 2017-10-17  Keith Miller  <keith_miller@apple.com>
1724
1725         Change WebCore sources to work with unified source builds
1726         https://bugs.webkit.org/show_bug.cgi?id=178229
1727
1728         Rubber stamped by Tim Horton.
1729
1730         * Configurations/FeatureDefines.xcconfig:
1731
1732 2017-10-16  Sam Weinig  <sam@webkit.org>
1733
1734         [Settings] Remove all custom code from Settings.h/cpp
1735         https://bugs.webkit.org/show_bug.cgi?id=178330
1736
1737         Reviewed by Simon Fraser.
1738
1739         * WebView/WebPreferences.mm:
1740         (+[WebPreferences initialize]):
1741         
1742             Update for naming changes of FrameFlattening now that it is an enum class.
1743
1744 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1745
1746         Remove Editor::simplifyMarkup
1747         https://bugs.webkit.org/show_bug.cgi?id=178271
1748
1749         Reviewed by Wenson Hsieh.
1750
1751         * WebView/WebView.mm:
1752         (-[WebView _simplifyMarkup:endNode:]):
1753
1754 2017-10-12  Chris Dumez  <cdumez@apple.com>
1755
1756         [Mac] Add support for MouseEvent.buttons
1757         https://bugs.webkit.org/show_bug.cgi?id=178214
1758
1759         Reviewed by Ryosuke Niwa.
1760
1761         * WebView/WebPDFView.mm:
1762         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1763
1764 2017-10-11  Sam Weinig  <sam@webkit.org>
1765
1766         Remove out-parameter variants of copyToVector
1767         https://bugs.webkit.org/show_bug.cgi?id=178155
1768
1769         Reviewed by Tim Horton.
1770
1771         * Plugins/WebNetscapePluginView.mm:
1772         (-[WebNetscapePluginView destroyPlugin]):
1773         * WebView/WebHTMLRepresentation.mm:
1774         (newArrayWithStrings):
1775
1776             Replace out-parameter based copyToVector, with one that returns a Vector.
1777
1778 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1779
1780         Sanitize URL in pasteboard for other applications and cross origin content
1781         https://bugs.webkit.org/show_bug.cgi?id=178060
1782         <rdar://problem/34874518>
1783
1784         Reviewed by Wenson Hsieh.
1785
1786         * WebCoreSupport/WebPlatformStrategies.h:
1787         * WebCoreSupport/WebPlatformStrategies.mm:
1788         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1789
1790 2017-10-11  Chris Dumez  <cdumez@apple.com>
1791
1792         Modernize Geolocation code
1793         https://bugs.webkit.org/show_bug.cgi?id=178148
1794
1795         Reviewed by Ryosuke Niwa.
1796
1797         * WebCoreSupport/WebGeolocationClient.h:
1798         * WebCoreSupport/WebGeolocationClient.mm:
1799         (WebGeolocationClient::lastPosition):
1800         * WebView/WebGeolocationPosition.mm:
1801         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1802         (core):
1803         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1804         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1805         * WebView/WebGeolocationPositionInternal.h:
1806
1807 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1808
1809         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1810         https://bugs.webkit.org/show_bug.cgi?id=178154
1811
1812         Reviewed by Wenson Hsieh.
1813
1814         Enable custom pasteboard data by default.
1815
1816         * WebView/WebPreferenceKeysPrivate.h:
1817         * WebView/WebPreferences.mm:
1818         (+[WebPreferences initialize]):
1819         (-[WebPreferences customPasteboardDataEnabled]): Added.
1820         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1821         * WebView/WebPreferencesPrivate.h:
1822         * WebView/WebView.mm:
1823         (-[WebView _preferencesChanged:]):
1824
1825 2017-10-10  Sam Weinig  <sam@webkit.org>
1826
1827         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1828         https://bugs.webkit.org/show_bug.cgi?id=178102
1829
1830         Reviewed by Tim Horton.
1831
1832         * History/WebHistory.mm:
1833         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1834         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1835         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1836         * WebCoreSupport/WebUserMediaClient.mm:
1837         (WebUserMediaClient::pageDestroyed):
1838
1839 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1840
1841         Make the names of the options consistent
1842         https://bugs.webkit.org/show_bug.cgi?id=177933
1843
1844         Reviewed by Saam Barati.
1845
1846         * WebView/WebFrame.h:
1847         * WebView/WebHTMLView.mm:
1848         (-[WebHTMLView setMarkedText:selectedRange:]):
1849         * WebView/WebView.h:
1850
1851 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1852
1853         [iOS] Tweak support for classifying form controls (followup to r222487)
1854         https://bugs.webkit.org/show_bug.cgi?id=177917
1855         <rdar://problem/34820122>
1856
1857         Reviewed by Dean Jackson.
1858
1859         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1860
1861         * DOM/DOMHTMLInputElement.mm:
1862         (-[DOMHTMLInputElement _autofillContext]):
1863         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1864         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1865
1866 2017-10-05  Keith Miller  <keith_miller@apple.com>
1867
1868         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1869
1870         * Configurations/WebKitLegacy.xcconfig:
1871
1872 2017-10-05  Jer Noble  <jer.noble@apple.com>
1873
1874         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1875         https://bugs.webkit.org/show_bug.cgi?id=177261
1876
1877         Reviewed by Eric Carlson.
1878
1879         * Configurations/FeatureDefines.xcconfig:
1880
1881 2017-10-05  Chris Dumez  <cdumez@apple.com>
1882
1883         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1884         https://bugs.webkit.org/show_bug.cgi?id=177957
1885
1886         Reviewed by Alex Christensen.
1887
1888         * WebCoreSupport/WebPlatformStrategies.h:
1889         * WebCoreSupport/WebPlatformStrategies.mm:
1890         (WebPlatformStrategies::cookiesEnabled):
1891
1892 2017-10-05  Youenn Fablet  <youenn@apple.com>
1893
1894         Make LibWebRTCProvider port agnostic
1895         https://bugs.webkit.org/show_bug.cgi?id=177747
1896
1897         Reviewed by Alex Christensen & Alex Garcia.
1898
1899         * WebView/WebView.mm:
1900         (-[WebView _commonInitializationWithFrameName:groupName:]):
1901         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1902
1903 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1904
1905         Stop linking with WebKitSystemInterface
1906         https://bugs.webkit.org/show_bug.cgi?id=177915
1907
1908         Reviewed by Antti Koivisto.
1909
1910         * Configurations/DebugRelease.xcconfig:
1911         * Configurations/WebKitLegacy.xcconfig:
1912
1913 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1914
1915         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1916         https://bugs.webkit.org/show_bug.cgi?id=177912
1917
1918         Reviewed by Saam Barati.
1919
1920         * Carbon/CarbonUtils.m:
1921         * Carbon/CarbonWindowAdapter.mm:
1922         * Carbon/HIWebView.mm:
1923         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1924         * Misc/WebNSFileManagerExtras.mm:
1925         * Misc/WebNSPasteboardExtras.mm:
1926         * Misc/WebNSURLExtras.mm:
1927         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1928         * Plugins/Hosted/NetscapePluginHostManager.mm:
1929         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1930         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1931         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1932         * Plugins/Hosted/WebTextInputWindowController.m:
1933         * Plugins/WebBaseNetscapePluginView.mm:
1934         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1935         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1936         * Plugins/WebNetscapePluginStream.mm:
1937         * Plugins/WebNetscapePluginView.mm:
1938         * Plugins/WebPluginDatabase.mm:
1939         * WebCoreSupport/PopupMenuMac.mm:
1940         * WebCoreSupport/WebChromeClient.mm:
1941         * WebCoreSupport/WebFrameLoaderClient.mm:
1942         * WebCoreSupport/WebInspectorClient.mm:
1943         * WebCoreSupport/WebPlatformStrategies.mm:
1944         * WebCoreSupport/WebSystemInterface.mm:
1945         * WebView/WebDynamicScrollBarsView.mm:
1946         * WebView/WebFrame.mm:
1947         * WebView/WebFrameView.mm:
1948         * WebView/WebFullScreenController.mm:
1949         * WebView/WebHTMLView.mm:
1950         * WebView/WebPreferences.mm:
1951         * WebView/WebView.mm:
1952
1953 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1954
1955         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1956         rdar://problem/34705779
1957
1958         Addressing review comments that I somehow landed without.
1959
1960         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1961
1962 2017-09-29  Chris Dumez  <cdumez@apple.com>
1963
1964         Split some logic out of VisitedLinkStore and make it reusable
1965         https://bugs.webkit.org/show_bug.cgi?id=177575
1966
1967         Reviewed by Alex Christensen.
1968
1969         * WebCoreSupport/WebVisitedLinkStore.h:
1970         * WebCoreSupport/WebVisitedLinkStore.mm:
1971         (WebVisitedLinkStore::addVisitedLink):
1972         (WebVisitedLinkStore::removeVisitedLink):
1973         (WebVisitedLinkStore::isLinkVisited):
1974         (WebVisitedLinkStore::addVisitedLinkHash):
1975
1976 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1977
1978         Build fix for High Sierra 32 bit Mac
1979         https://bugs.webkit.org/show_bug.cgi?id=177551
1980         <rdar://problem/34690283>
1981
1982         Reviewed by Alexey Proskuryakov.
1983
1984         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1985         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1986         also made.
1987
1988         * Carbon/CarbonWindowAdapter.mm:
1989         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1990         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1991         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1992         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1993         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1994         (-[CarbonWindowAdapter dealloc]):
1995         (-[CarbonWindowAdapter windowRef]):
1996         (-[CarbonWindowAdapter _hasWindowRef]):
1997         (-[CarbonWindowAdapter _managesWindowRef]):
1998         (-[CarbonWindowAdapter _removeWindowRef]):
1999         (-[CarbonWindowAdapter _carbonWindowClass]):
2000         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2001         (-[CarbonWindowAdapter sendSuperEvent:]):
2002         (-[CarbonWindowAdapter relinquishFocus]):
2003         (-[CarbonWindowAdapter _cancelKey:]):
2004         (-[CarbonWindowAdapter _commonAwake]):
2005         (-[CarbonWindowAdapter _destroyRealWindow:]):
2006         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2007         (-[CarbonWindowAdapter _termWindowIfOwner]):
2008         (-[CarbonWindowAdapter _windowMovedToRect:]):
2009         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2010         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2011         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2012         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2013         (-[CarbonWindowAdapter canBecomeMainWindow]):
2014         (-[CarbonWindowAdapter encodeWithCoder:]):
2015         (-[CarbonWindowAdapter initWithCoder:]):
2016         (-[CarbonWindowAdapter setContentView:]):
2017         (-[CarbonWindowAdapter worksWhenModal]):
2018         (-[CarbonWindowAdapter _setModalWindowLevel]):
2019         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2020         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2021         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2022         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2023         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2024         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2025         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2026         (NSCarbonWindowHandleEvent):
2027         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2028         (-[CarbonWindowAdapter _growBoxRect]):
2029         * Carbon/HIWebView.mm:
2030         (HIWebViewGetWebView):
2031         (HIWebViewConstructor):
2032         (HIWebViewDestructor):
2033         (HIWebViewRegisterClass):
2034         (GetBehaviors):
2035         (Draw):
2036         (HitTest):
2037         (GetRegion):
2038         (GetWindowRef):
2039         (CreateNSEventAdoptingCGEvent):
2040         (CopyEventCGEvent):
2041         (CreateNSEventWithCarbonClickEvent):
2042         (Click):
2043         (CreateNSEventWithCarbonEvent):
2044         (MouseUp):
2045         (CreateNSEventWithCarbonMouseMoveEvent):
2046         (MouseMoved):
2047         (MouseDragged):
2048         (MouseWheelMoved):
2049         (ContextMenuClick):
2050         (GetKind):
2051         (BoundsChanged):
2052         (OwningWindowChanged):
2053         (WindowHandler):
2054         (SyncFrame):
2055         (SetFocusPart):
2056         (AdvanceFocus):
2057         (RelinquishFocus):
2058         (ActiveStateChanged):
2059         (ProcessCommand):
2060         (UpdateCommandStatus):
2061         (_NSSelectorForHICommand):
2062         (HIWebViewEventHandler):
2063         (StartUpdateObserver):
2064         (StopUpdateObserver):
2065         (UpdateObserver):
2066
2067 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2068
2069         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2070         https://bugs.webkit.org/show_bug.cgi?id=172526
2071         <rdar://problem/32396081>
2072
2073         Reviewed by Ryosuke Niwa.
2074
2075         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2076
2077         * WebCoreSupport/WebPlatformStrategies.h:
2078         * WebCoreSupport/WebPlatformStrategies.mm:
2079         (WebPlatformStrategies::webExposedTypes):
2080         (WebPlatformStrategies::writeCustomData):
2081
2082 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2083
2084         Unreviewed, rolling out r222567.
2085
2086         This broke and internal build.
2087
2088         Reverted changeset:
2089
2090         "Build fix for High Sierra 32 bit Mac"
2091         https://bugs.webkit.org/show_bug.cgi?id=177551
2092         http://trac.webkit.org/changeset/222567
2093
2094 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2095
2096         Build fix for High Sierra 32 bit Mac
2097         https://bugs.webkit.org/show_bug.cgi?id=177551
2098         <rdar://problem/34690283>
2099
2100         Reviewed by Alexey Proskuryakov.
2101
2102         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2103         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2104         also made.
2105
2106         * Carbon/CarbonWindowAdapter.mm:
2107         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2108         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2109         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2110         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2111         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2112         (-[CarbonWindowAdapter dealloc]):
2113         (-[CarbonWindowAdapter windowRef]):
2114         (-[CarbonWindowAdapter _hasWindowRef]):
2115         (-[CarbonWindowAdapter _managesWindowRef]):
2116         (-[CarbonWindowAdapter _removeWindowRef]):
2117         (-[CarbonWindowAdapter _carbonWindowClass]):
2118         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2119         (-[CarbonWindowAdapter sendSuperEvent:]):
2120         (-[CarbonWindowAdapter relinquishFocus]):
2121         (-[CarbonWindowAdapter _cancelKey:]):
2122         (-[CarbonWindowAdapter _commonAwake]):
2123         (-[CarbonWindowAdapter _destroyRealWindow:]):
2124         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2125         (-[CarbonWindowAdapter _termWindowIfOwner]):
2126         (-[CarbonWindowAdapter _windowMovedToRect:]):
2127         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2128         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2129         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2130         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2131         (-[CarbonWindowAdapter canBecomeMainWindow]):
2132         (-[CarbonWindowAdapter encodeWithCoder:]):
2133         (-[CarbonWindowAdapter initWithCoder:]):
2134         (-[CarbonWindowAdapter setContentView:]):
2135         (-[CarbonWindowAdapter worksWhenModal]):
2136         (-[CarbonWindowAdapter _setModalWindowLevel]):
2137         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2138         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2139         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2140         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2141         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2142         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2143         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2144         (NSCarbonWindowHandleEvent):
2145         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2146         (-[CarbonWindowAdapter _growBoxRect]):
2147         * Carbon/HIWebView.mm:
2148         (HIWebViewGetWebView):
2149         (HIWebViewConstructor):
2150         (HIWebViewDestructor):
2151         (HIWebViewRegisterClass):
2152         (GetBehaviors):
2153         (Draw):
2154         (HitTest):
2155         (GetRegion):
2156         (GetWindowRef):
2157         (CreateNSEventAdoptingCGEvent):
2158         (CopyEventCGEvent):
2159         (CreateNSEventWithCarbonClickEvent):
2160         (Click):
2161         (CreateNSEventWithCarbonEvent):
2162         (MouseUp):
2163         (CreateNSEventWithCarbonMouseMoveEvent):
2164         (MouseMoved):
2165         (MouseDragged):
2166         (MouseWheelMoved):
2167         (ContextMenuClick):
2168         (GetKind):
2169         (BoundsChanged):
2170         (OwningWindowChanged):
2171         (WindowHandler):
2172         (SyncFrame):
2173         (SetFocusPart):
2174         (AdvanceFocus):
2175         (RelinquishFocus):
2176         (ActiveStateChanged):
2177         (ProcessCommand):
2178         (UpdateCommandStatus):
2179         (_NSSelectorForHICommand):
2180         (HIWebViewEventHandler):
2181         (StartUpdateObserver):
2182         (StopUpdateObserver):
2183         (UpdateObserver):
2184
2185 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2186
2187         Make PolicyAction an encodable enum class
2188         https://bugs.webkit.org/show_bug.cgi?id=177480
2189
2190         Reviewed by Antti Koivisto.
2191
2192         * Plugins/WebPluginContainerCheck.mm:
2193         (-[WebPluginContainerCheck _continueWithPolicy:]):
2194         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2195         * WebCoreSupport/WebFrameLoaderClient.mm:
2196         (-[WebFramePolicyListener invalidate]):
2197         (-[WebFramePolicyListener ignore]):
2198         (-[WebFramePolicyListener download]):
2199         (-[WebFramePolicyListener use]):
2200         (-[WebFramePolicyListener continue]):
2201         * WebView/WebPolicyDelegate.mm:
2202         (-[WebPolicyDecisionListener use]):
2203         (-[WebPolicyDecisionListener ignore]):
2204         (-[WebPolicyDecisionListener download]):
2205
2206 2017-09-25  Frederik Riedel  <riedel@apple.com>
2207
2208         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2209         https://bugs.webkit.org/show_bug.cgi?id=174394
2210         <rdar://problem/33183504>
2211
2212         Reviewed by Ryosuke Niwa.
2213
2214         * DOM/DOMHTMLInputElement.h:
2215         * DOM/DOMHTMLInputElement.mm:
2216         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2217         Determines if this HTMLInputElement is part of a login screen.
2218         (-[DOMHTMLInputElement representingPageUrl]):
2219         Returns the webpage's URL that is currently displayed in the Web View.
2220         (-[DOMHTMLInputElement insertTextSuggestion:]):
2221         Inserts login credentials into the Web View.
2222
2223 2017-09-25  Sam Weinig  <sam@webkit.org>
2224
2225         Remove unused EditorClient functions
2226         https://bugs.webkit.org/show_bug.cgi?id=177463
2227
2228         Reviewed by Alex Christensen.
2229
2230         Remove unused EditorClient functions.
2231
2232         * WebCoreSupport/WebEditorClient.h:
2233         * WebCoreSupport/WebEditorClient.mm:
2234         (WebEditorClient::canonicalizeURL): Deleted.
2235         (WebEditorClient::canonicalizeURLString): Deleted.
2236         (WebEditorClient::writeDataToPasteboard): Deleted.
2237         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2238         (WebEditorClient::readDataFromPasteboard): Deleted.
2239         (WebEditorClient::pasteboardChangeCount): Deleted.
2240
2241 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2242
2243         Stop using PolicyCallback
2244         https://bugs.webkit.org/show_bug.cgi?id=176088
2245
2246         Reviewed by Andy Estes.
2247
2248         * WebCoreSupport/WebFrameLoaderClient.mm:
2249         (-[WebFramePolicyListener invalidate]):
2250         (-[WebFramePolicyListener receivedPolicyDecision:]):
2251
2252 2017-09-25  Sam Weinig  <sam@webkit.org>
2253
2254         Remove unnecessary userVisibleString EditorClient function
2255         https://bugs.webkit.org/show_bug.cgi?id=177456
2256
2257         Reviewed by Dan Bernstein.
2258
2259         * WebCoreSupport/WebEditorClient.h:
2260         * WebCoreSupport/WebEditorClient.mm:
2261         (WebEditorClient::userVisibleString): Deleted.
2262
2263             Remove userVisibleString client function.
2264
2265 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2266
2267         Separate form submission from PolicyChecker infrastructure
2268         https://bugs.webkit.org/show_bug.cgi?id=177396
2269
2270         Reviewed by Geoffrey Garen.
2271
2272         * WebCoreSupport/WebFrameLoaderClient.h:
2273         * WebCoreSupport/WebFrameLoaderClient.mm:
2274         (WebFrameLoaderClient::dispatchWillSubmitForm):
2275
2276 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2277
2278         WeakPtrFactory should populate m_ref lazily.
2279         https://bugs.webkit.org/show_bug.cgi?id=177375
2280
2281         Reviewed by Geoffrey Garen.
2282
2283         * WebCoreSupport/WebEditorClient.mm:
2284         (WebEditorClient::WebEditorClient):
2285         (WebEditorClient::requestCandidatesForSelection):
2286
2287 2017-09-22  Chris Dumez  <cdumez@apple.com>
2288
2289         Use high resolution timestamp for event time
2290         https://bugs.webkit.org/show_bug.cgi?id=154246
2291         <rdar://problem/34333304>
2292
2293         Reviewed by Ryosuke Niwa.
2294
2295         Use WallTime / MonotonicTime instead of double type for clarity.
2296
2297         * DOM/DOMEvent.mm:
2298         (-[DOMEvent timeStamp]):
2299         * WebView/WebFrame.mm:
2300         (-[WebFrame _dragSourceEndedAt:operation:]):
2301         * WebView/WebPDFView.mm:
2302         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2303
2304 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2305
2306         Enable dataTransfer.items on macOS and iOS
2307         https://bugs.webkit.org/show_bug.cgi?id=177335
2308
2309         Reviewed by Sam Weinig.
2310
2311         * WebView/WebPreferences.mm:
2312         (+[WebPreferences initialize]):
2313
2314 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2315
2316         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2317         https://bugs.webkit.org/show_bug.cgi?id=177101
2318         <rdar://problem/34500648>
2319
2320         Reviewed by Brian Burg.
2321
2322         * WebInspector/WebNodeHighlight.mm:
2323         Ensure we close the window that we have just removed.
2324
2325 2017-09-20  Antti Koivisto  <antti@apple.com>
2326
2327         Remove DOM and styling support for CSS Regions
2328         https://bugs.webkit.org/show_bug.cgi?id=177221
2329
2330         Reviewed by Andreas Kling.
2331
2332         * Configurations/FeatureDefines.xcconfig:
2333         * DOM/DOMCSS.mm:
2334         (kitClass):
2335         * DOM/DOMElement.mm:
2336         (-[DOMElement webkitRegionOverset]): Deleted.
2337
2338 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2339
2340         Layering violation in Editor::createFragment
2341         https://bugs.webkit.org/show_bug.cgi?id=176123
2342
2343         Reviewed by Darin Adler.
2344
2345         * Misc/WebNSURLExtras.h:
2346         * Misc/WebNSURLExtras.mm:
2347         * WebView/WebFrame.mm:
2348         * WebView/WebHTMLView.mm:
2349         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2350
2351         * WebCoreSupport/WebEditorClient.mm:
2352         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2353         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2354         way to avoid exporting the symbol just on newer OSes.
2355
2356 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2357
2358         On iOS, getData can't get text set by setData during copy event
2359         https://bugs.webkit.org/show_bug.cgi?id=176980
2360         <rdar://problem/34453915>
2361
2362         Reviewed by Darin Adler.
2363
2364         * WebCoreSupport/WebPlatformStrategies.h:
2365         * WebCoreSupport/WebPlatformStrategies.mm:
2366         (WebPlatformStrategies::copy): Deleted.
2367
2368 2017-09-18  Andy Estes  <aestes@apple.com>
2369
2370         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2371         https://bugs.webkit.org/show_bug.cgi?id=177029
2372
2373         Reviewed by Alex Christensen.
2374
2375         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2376         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2377         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2378         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2379         * WebCoreSupport/PopupMenuMac.mm:
2380         (PopupMenuMac::show):
2381         * WebCoreSupport/WebSystemInterface.mm:
2382         (InitWebCoreSystemInterface):
2383         * WebView/WebHTMLView.mm:
2384         (-[WebHTMLView setDataSource:]):
2385         (-[WebHTMLView attachRootLayer:]):
2386         * WebView/WebView.mm:
2387         (-[WebView _needsAdobeFrameReloadingQuirk]):
2388         (-[WebView _needsLinkElementTextCSSQuirk]):
2389         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2390         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2391         (-[WebView _preferencesChanged:]):
2392
2393 2017-09-15  Andy Estes  <aestes@apple.com>
2394
2395         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2396         https://bugs.webkit.org/show_bug.cgi?id=176953
2397
2398         Reviewed by Eric Carlson.
2399
2400         * WebCoreSupport/WebSystemInterface.mm:
2401         (InitWebCoreSystemInterface):
2402
2403 2017-09-14  Andy Estes  <aestes@apple.com>
2404
2405         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2406         https://bugs.webkit.org/show_bug.cgi?id=176931
2407
2408         Reviewed by Joseph Pecoraro.
2409
2410         * WebCoreSupport/WebSystemInterface.mm:
2411         (InitWebCoreSystemInterface):
2412
2413 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2414
2415         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2416         https://bugs.webkit.org/show_bug.cgi?id=176867
2417
2418         Reviewed by Sam Weinig.
2419
2420         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2421         (WebKit::NetscapePluginInstanceProxy::enumerate):
2422
2423 2017-09-13  Andy Estes  <aestes@apple.com>
2424
2425         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2426         https://bugs.webkit.org/show_bug.cgi?id=176729
2427
2428         Reviewed by Alex Christensen.
2429
2430         * WebCoreSupport/WebSystemInterface.mm:
2431         (InitWebCoreSystemInterface):
2432         * WebView/WebView.mm:
2433         (+[WebView _setCacheModel:]):
2434
2435 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Refactor WebContentReader out of EditorMac and EditorIOS
2438         https://bugs.webkit.org/show_bug.cgi?id=176770
2439
2440         Reviewed by Sam Weinig.
2441
2442         * WebCoreSupport/WebEditorClient.mm:
2443
2444 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2445
2446         Dragging & dropping a file creates an attachment element even when it's disabled
2447         https://bugs.webkit.org/show_bug.cgi?id=176769
2448
2449         Reviewed by Tim Horton.
2450
2451         * WebView/WebView.mm:
2452         (-[WebView _preferencesChanged:]):
2453
2454 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2455
2456         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2457         https://bugs.webkit.org/show_bug.cgi?id=176721
2458         <rdar://problem/34373660>
2459
2460         Reviewed by Tim Horton.
2461
2462         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2463         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2464
2465         * WebView/WebView.mm:
2466         (-[WebView _startDrag:]):
2467         (-[WebView _draggedElementBounds]):
2468         (-[WebView _endedDataInteraction:global:]):
2469         * WebView/WebViewData.h:
2470
2471 2017-09-11  Andy Estes  <aestes@apple.com>
2472
2473         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2474         https://bugs.webkit.org/show_bug.cgi?id=176472
2475
2476         Reviewed by Eric Carlson.
2477
2478         * WebCoreSupport/WebSystemInterface.mm:
2479         (InitWebCoreSystemInterface):
2480
2481 2017-09-09  Mark Lam  <mark.lam@apple.com>
2482
2483         Avoid duplicate computations of ExecState::vm().
2484         https://bugs.webkit.org/show_bug.cgi?id=176647
2485
2486         Reviewed by Saam Barati.
2487
2488         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2489         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2490         (WebKit::NetscapePluginInstanceProxy::construct):
2491         (WebKit::NetscapePluginInstanceProxy::setProperty):
2492         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2493         (WebKit::NetscapePluginInstanceProxy::enumerate):
2494         * Plugins/Hosted/ProxyInstance.mm:
2495         (WebKit::ProxyRuntimeMethod::create):
2496
2497 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2498
2499         Unreviewed, rolling out r221773.
2500         https://bugs.webkit.org/show_bug.cgi?id=176614
2501
2502         This caused build failures. (Requested by mlewis13 on
2503         #webkit).
2504
2505         Reverted changeset:
2506
2507         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2508         https://bugs.webkit.org/show_bug.cgi?id=176472
2509         http://trac.webkit.org/changeset/221773
2510
2511 2017-09-07  Andy Estes  <aestes@apple.com>
2512
2513         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2514         https://bugs.webkit.org/show_bug.cgi?id=176472
2515
2516         Reviewed by Eric Carlson.
2517
2518         * WebCoreSupport/WebSystemInterface.mm:
2519         (InitWebCoreSystemInterface):
2520
2521 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2522
2523         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2524         https://bugs.webkit.org/show_bug.cgi?id=176561
2525
2526         Reviewed by Brent Fulgham.
2527
2528         * Misc/WebNSUserDefaultsExtras.mm:
2529
2530 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2531
2532         Modernize Geolocation code
2533         https://bugs.webkit.org/show_bug.cgi?id=176496
2534
2535         Reviewed by Andy Estes.
2536
2537         * WebCoreSupport/WebGeolocationClient.h:
2538         * WebCoreSupport/WebGeolocationClient.mm:
2539         (WebGeolocationClient::requestPermission):
2540         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2541         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2542         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2543         * WebView/WebView.mm:
2544         (-[WebView _commonInitializationWithFrameName:groupName:]):
2545         (-[WebView _geolocationDidFailWithMessage:]):
2546
2547 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2548
2549         Remove some unused bits of code and resources
2550         https://bugs.webkit.org/show_bug.cgi?id=176275
2551
2552         Reviewed by Dan Bernstein.
2553
2554         * Misc/WebNSFileManagerExtras.mm:
2555         Include FileSystem instead of FileSystemIOS.
2556
2557 2017-09-03  Darin Adler  <darin@apple.com>
2558
2559         [Cocoa] Tidy a few things in legacy WebHTMLView
2560         https://bugs.webkit.org/show_bug.cgi?id=176280
2561
2562         Reviewed by Dan Bernstein.
2563
2564         * WebCoreSupport/WebChromeClient.mm:
2565         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2566         methods it calls on WebHTMLView were doing nothing on iOS.
2567
2568         * WebView/WebFrame.mm:
2569         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2570         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2571
2572         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2573         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2574         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2575         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2576         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2577         Use RetainPtr instead of writing retain/release wherever possible.
2578         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2579         initialization for it. Removed various unused methods and declarations of methods.
2580         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2581         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2582         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2583         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2584         and remove CFRetain no longer needed since we don't support garbage collection any more.
2585         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2586         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2587         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2588         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2589         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2590         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2591         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2592         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2593         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2594         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2595         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2596         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2597         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2598         debug flag; we haven't used it for years and it's not clearly helpful.
2599         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2600         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2601         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2602         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2603         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2604         two additional methods in the WebPrivate category and still be called by the two
2605         methods in the WebInternal category that were already using it.
2606         (-[WebHTMLView didAddSubview:]): Deleted.
2607         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2608         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2609         place this was called, the close method.
2610         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2611         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2612         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2613         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2614         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2615         Added helper method to make the one below simpler.
2616         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2617         Compared pasteboard type strings using isEqualToString: rather than using == since
2618         we want to actually compare the string contents. Also updated to use modern for loop,
2619         renamed a local variable from "s" to "localSubresources", and factored out the handling
2620         of three image types to use the helper method above.
2621         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2622         _web_makePluginSubviewsPerformSelector:withObject: method.
2623         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2624         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2625         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2626         not call the -[NSView subviews] method to make this identical on both platforms and used
2627         a modern for loop.
2628         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2629         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2630         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2631         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2632         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2633         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2634         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2635         of it is Mac-only.
2636         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2637         method did was call itself on the main thread, and do nothing if called on main thread.
2638         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2639         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2640         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2641         half of this method.
2642         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2643         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2644         Simplified using a modern for loop and RetainPtr.
2645         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2646         (-[WebHTMLView keyDown:]): Ditto.
2647         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2648         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2649         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2650         (-[WebHTMLView complete:]): Ditto.
2651         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2652         now macOS-only.
2653         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2654         iOS since that is now macOS-only.
2655         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2656         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2657         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2658         and reorganized to use early return.
2659         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2660         on iOS, but kept there so we don't have to do #if at every call site.
2661         (-[WebHTMLView _pluginController]): Moved into internal category.
2662         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2663         there only for GC, using C++ initialization, removing obsolete comment.
2664         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2665         peculiar iOS-only comment.
2666         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2667
2668         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2669         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2670         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2671         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2672         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2673
2674         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2675         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2676         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2677         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2678         them at this time.
2679
2680 2017-09-03  Sam Weinig  <sam@webkit.org>
2681
2682         Remove CanvasProxy
2683         https://bugs.webkit.org/show_bug.cgi?id=176288
2684
2685         Reviewed by Yusuke Suzuki.
2686
2687         CanvasProxy does not appear to be in any current HTML spec
2688         and was disabled and unimplemented in our tree. Time to 
2689         get rid of it.
2690
2691         * Configurations/FeatureDefines.xcconfig:
2692
2693 2017-09-02  Andy Estes  <aestes@apple.com>
2694
2695         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2696         https://bugs.webkit.org/show_bug.cgi?id=176270
2697
2698         Reviewed by Tim Horton.
2699
2700         * Plugins/Hosted/NetscapePluginHostManager.mm:
2701         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2702         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2703         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2704         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2705         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2706         (WebKit::SoftwareCARenderer::context const):
2707         (WebKit::SoftwareCARenderer::renderContext const):
2708         (WebKit::SoftwareCARenderer::render):
2709         (-[WebHostedNetscapePluginView createPlugin]):
2710         (-[WebHostedNetscapePluginView createPluginLayer]):
2711         (-[WebHostedNetscapePluginView destroyPlugin]):
2712         (-[WebHostedNetscapePluginView drawRect:]):
2713         * WebCoreSupport/WebSystemInterface.mm:
2714         (InitWebCoreSystemInterface):
2715
2716 2017-09-01  Andy Estes  <aestes@apple.com>
2717
2718         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2719         https://bugs.webkit.org/show_bug.cgi?id=176200
2720
2721         Reviewed by Tim Horton.
2722
2723         * Carbon/HIWebView.mm:
2724         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2725         (overrideCGContext):
2726         (restoreCGContext):
2727         (Draw):
2728         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2729         (+[WebHostedNetscapePluginView initialize]):
2730         * Plugins/WebBaseNetscapePluginView.h:
2731         * Plugins/WebBaseNetscapePluginView.mm:
2732         (WebKit::sendUserChangeNotifications):
2733         * Plugins/WebNetscapePluginView.mm:
2734         (+[WebNetscapePluginView initialize]):
2735         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2736         * WebCoreSupport/WebSystemInterface.mm:
2737         (InitWebCoreSystemInterface):
2738         * WebView/WebFrame.mm:
2739         (-[WebFrame _paintBehaviorForDestinationContext:]):
2740         * WebView/WebFullScreenController.mm:
2741         (setClipRectForWindow):
2742         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2743         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2744         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2745         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2746
2747 2017-08-31  Andy Estes  <aestes@apple.com>
2748
2749         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2750         https://bugs.webkit.org/show_bug.cgi?id=176175
2751
2752         Reviewed by Brady Eidson.
2753
2754         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2755         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2756         * Plugins/Hosted/WebTextInputWindowController.m:
2757         (-[WebTextInputPanel init]):
2758         * WebCoreSupport/WebSystemInterface.mm:
2759         (InitWebCoreSystemInterface):
2760         * WebView/WebDynamicScrollBarsView.mm:
2761         (-[WebDynamicScrollBarsView scrollWheel:]):
2762         * WebView/WebHTMLView.mm:
2763         (-[WebHTMLView _removeWindowObservers]):
2764         (-[WebHTMLView addWindowObservers]):
2765         * WebView/WebView.mm:
2766         (-[WebView addWindowObserversForWindow:]):
2767         (-[WebView removeWindowObservers]):
2768         (-[WebView viewWillMoveToWindow:]):
2769
2770 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2771
2772         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2773         https://bugs.webkit.org/show_bug.cgi?id=175779
2774         <rdar://problem/22367975>
2775
2776         Reviewed by Tim Horton.
2777
2778         * WebCoreSupport/WebFrameLoaderClient.h:
2779         * WebCoreSupport/WebFrameLoaderClient.mm:
2780         (WebFrameLoaderClient::webGLPolicyForURL const):
2781         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2782
2783 2017-08-30  Andy Estes  <aestes@apple.com>
2784
2785         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2786         https://bugs.webkit.org/show_bug.cgi?id=176093
2787
2788         Reviewed by Eric Carlson.
2789
2790         * WebCoreSupport/WebSystemInterface.mm:
2791         (InitWebCoreSystemInterface):
2792
2793 2017-08-30  Andy Estes  <aestes@apple.com>
2794
2795         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2796         https://bugs.webkit.org/show_bug.cgi?id=176087
2797
2798         Reviewed by Alex Christensen.
2799
2800         * Carbon/CarbonUtils.m:
2801         (getNSAutoreleasePoolCount):
2802         (WebInitForCarbon):
2803         (PoolCleaner):
2804         * Carbon/CarbonWindowAdapter.mm:
2805         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2806         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2807         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2808         (-[CarbonWindowAdapter _windowMovedToRect:]):
2809         * Carbon/HIViewAdapter.m:
2810         * Carbon/HIWebView.mm:
2811         (Draw):
2812         (CreateNSEventAdoptingCGEvent):
2813         (CopyEventCGEvent):
2814         (CreateNSEventWithCarbonClickEvent):
2815         (Click):
2816         (CreateNSEventWithCarbonEvent):
2817         (MouseUp):
2818         (CreateNSEventWithCarbonMouseMoveEvent):
2819         (MouseMoved):
2820         (MouseDragged):
2821         (MouseWheelMoved):
2822         (WindowHandler):
2823         (HIWebViewEventHandler):
2824         * Misc/QuickDrawCompatibility.h: Removed.
2825         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2826         (getCarbonEvent):
2827         (WebNetscapePluginEventHandlerCarbon::keyDown):
2828         (WebNetscapePluginEventHandlerCarbon::keyUp):
2829         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2830         (WebNetscapePluginEventHandlerCocoa::keyDown):
2831         * Plugins/WebNetscapePluginView.mm:
2832         (-[WebNetscapePluginView tellQuickTimeToChill]):
2833
2834 2017-08-29  Andy Estes  <aestes@apple.com>
2835
2836         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2837         https://bugs.webkit.org/show_bug.cgi?id=176046
2838
2839         Reviewed by Alex Christensen.
2840
2841         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2842         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2843
2844         * Misc/WebNSFileManagerExtras.mm:
2845         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2846         (setMetaData): Deleted.
2847         * WebCoreSupport/WebSystemInterface.mm:
2848         (InitWebCoreSystemInterface):
2849
2850 2017-08-28  Andy Estes  <aestes@apple.com>
2851
2852         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2853         https://bugs.webkit.org/show_bug.cgi?id=176039
2854
2855         Reviewed by Alex Christensen.
2856
2857         * WebCoreSupport/WebSystemInterface.mm:
2858         (InitWebCoreSystemInterface):
2859         * WebView/WebPreferences.mm:
2860         (+[WebPreferences _systemCFStringEncoding]):
2861
2862 2017-08-28  Andy Estes  <aestes@apple.com>
2863
2864         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2865         https://bugs.webkit.org/show_bug.cgi?id=176032
2866
2867         Reviewed by Alex Christensen.
2868
2869         * WebCoreSupport/WebSystemInterface.mm:
2870         (InitWebCoreSystemInterface):
2871         * WebView/WebView.mm:
2872         (-[WebView _cachedResponseForURL:]):
2873
2874 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2875
2876         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2877         https://bugs.webkit.org/show_bug.cgi?id=175992
2878         <rdar://problem/34086613>
2879
2880         Reviewed by Daniel Bates.
2881
2882         * WebCoreSupport/WebPlatformStrategies.h:
2883         * WebCoreSupport/WebPlatformStrategies.mm:
2884         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2885         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2886         indicating if secure cookies were accessed.
2887
2888 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2889
2890         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2891         https://bugs.webkit.org/show_bug.cgi?id=170955
2892         <rdar://problem/31697653>
2893
2894         Reviewed by Ryosuke Niwa.
2895
2896         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2897         text is being replaced.
2898
2899         * WebView/WebHTMLView.mm:
2900         (-[WebHTMLView insertText:]):
2901
2902 2017-08-24  Chris Dumez  <cdumez@apple.com>
2903
2904         [Directory Upload] Add basic support for input.webkitdirectory
2905         https://bugs.webkit.org/show_bug.cgi?id=175950
2906         <rdar://problem/33951915>
2907
2908         Reviewed by Geoffrey Garen.
2909
2910         Add private API to toggle Directory Upload support on Mac WebKit1.
2911
2912         * WebView/WebPreferenceKeysPrivate.h:
2913         * WebView/WebPreferences.mm:
2914         (+[WebPreferences initialize]):
2915         (-[WebPreferences setDirectoryUploadEnabled:]):
2916         (-[WebPreferences directoryUploadEnabled]):
2917         * WebView/WebPreferencesPrivate.h:
2918         * WebView/WebView.mm:
2919         (-[WebView _preferencesChanged:]):
2920
2921 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2922
2923         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2924         https://bugs.webkit.org/show_bug.cgi?id=175370
2925         <rdar://problem/33799806>
2926
2927         Reviewed by Ryosuke Niwa.
2928
2929         Adjust WebEditorClient for interface changes.
2930
2931         * WebCoreSupport/WebEditorClient.h:
2932
2933 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2934
2935         Remove ChromeClient::scrollbarsModeDidChange
2936         https://bugs.webkit.org/show_bug.cgi?id=175805
2937
2938         Reviewed by Daniel Bates.
2939
2940         * WebCoreSupport/WebChromeClient.h:
2941
2942 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2943
2944         Remove ChromeClient::hasOpenedPopup
2945         https://bugs.webkit.org/show_bug.cgi?id=175804
2946
2947         Reviewed by Sam Weinig.
2948
2949         * WebCoreSupport/WebChromeClient.h:
2950         * WebCoreSupport/WebChromeClient.mm:
2951         (WebChromeClient::hasOpenedPopup const): Deleted.
2952
2953 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2954
2955         Disable access to secure cookies if an HTTPS site loads mixed content
2956         https://bugs.webkit.org/show_bug.cgi?id=157053
2957         <rdar://problem/11290808>
2958
2959         Reviewed by Dan Bates.
2960
2961         * WebCoreSupport/WebPlatformStrategies.h:
2962         * WebCoreSupport/WebPlatformStrategies.mm:
2963         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2964         indicating whether secure cookies should be included in the response.
2965
2966 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2967
2968         [PAL] Move spi/mac directory into PAL
2969         https://bugs.webkit.org/show_bug.cgi?id=175649
2970
2971         Reviewed by Myles C. Maxfield.
2972
2973         * Misc/WebSharingServicePickerController.h:
2974         * WebCoreSupport/WebContextMenuClient.mm:
2975         * WebCoreSupport/WebEditorClient.mm:
2976         * WebCoreSupport/WebSelectionServiceController.mm:
2977         * WebView/WebHTMLView.mm:
2978         * WebView/WebImmediateActionController.h:
2979         * WebView/WebImmediateActionController.mm:
2980         * WebView/WebView.mm:
2981
2982 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2983
2984         [PAL] Relocate SessionID to root
2985         https://bugs.webkit.org/show_bug.cgi?id=175684
2986
2987         Reviewed by Alex Christensen.
2988
2989         * WebCoreSupport/WebFrameNetworkingContext.mm:
2990
2991 2017-08-17  Andreas Kling  <akling@apple.com>
2992
2993         Disable CSS regions at compile time
2994         https://bugs.webkit.org/show_bug.cgi?id=175630
2995
2996         Reviewed by Antti Koivisto.
2997
2998         * Configurations/FeatureDefines.xcconfig:
2999
3000 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3001
3002         [PAL] Move SessionID into PAL
3003         https://bugs.webkit.org/show_bug.cgi?id=174192
3004
3005         Reviewed by Antti Koivisto.
3006
3007         * Misc/WebCache.mm:
3008         (+[WebCache imageForURL:]):
3009         * WebCoreSupport/WebFrameLoaderClient.h:
3010         * WebCoreSupport/WebFrameLoaderClient.mm:
3011         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3012         * WebCoreSupport/WebFrameNetworkingContext.mm:
3013         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3014         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3015         (WebFrameNetworkingContext::storageSession const):
3016         * WebCoreSupport/WebPlatformStrategies.h:
3017         * WebCoreSupport/WebPlatformStrategies.mm:
3018         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3019         * WebKitPrefix.h:
3020
3021 2017-08-16  Andy Estes  <aestes@apple.com>
3022
3023         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3024         https://bugs.webkit.org/show_bug.cgi?id=175648
3025
3026         Reviewed by Tim Horton.
3027
3028         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3029         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3030         (WebPaymentCoordinatorClient::showPaymentUI):
3031
3032 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3033
3034         [PAL] Move spi/ios and spi/win directories into PAL
3035         https://bugs.webkit.org/show_bug.cgi?id=175171
3036
3037         Reviewed by Antti Koivisto.
3038
3039         * WebCoreSupport/WebFrameLoaderClient.mm:
3040         * WebView/WebView.mm:
3041
3042 2017-08-16  Andy Estes  <aestes@apple.com>
3043
3044         [Payment Request] Add an ENABLE flag and an experimental feature preference
3045         https://bugs.webkit.org/show_bug.cgi?id=175622
3046
3047         Reviewed by Tim Horton.
3048
3049         * Configurations/FeatureDefines.xcconfig:
3050
3051 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3052
3053         [PAL] Move Sleep classes into PAL
3054         https://bugs.webkit.org/show_bug.cgi?id=175456
3055
3056         Reviewed by Ryosuke Niwa.
3057
3058         * WebView/WebFullScreenController.h:
3059
3060 2017-08-15  Youenn Fablet  <youenn@apple.com>
3061
3062         [Cache API] Adding generic support for CacheStorage and Cache methods
3063         https://bugs.webkit.org/show_bug.cgi?id=175455
3064
3065         Reviewed by Chris Dumez.
3066
3067         * WebView/WebView.mm:
3068         (-[WebView _commonInitializationWithFrameName:groupName:]):
3069
3070 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3071
3072         Remove Proximity Events and related code
3073         https://bugs.webkit.org/show_bug.cgi?id=175545
3074
3075         Reviewed by Daniel Bates.
3076
3077         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3078         and other related code.
3079
3080         * Configurations/FeatureDefines.xcconfig:
3081
3082 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3083
3084         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3085         https://bugs.webkit.org/show_bug.cgi?id=175504
3086
3087         Reviewed by Sam Weinig.
3088
3089         * Configurations/FeatureDefines.xcconfig:
3090         * DOM/DOMHTMLFormElement.mm:
3091         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3092         * WebCoreSupport/WebFrameLoaderClient.h:
3093
3094 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3095
3096         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3097         https://bugs.webkit.org/show_bug.cgi?id=175557
3098
3099         Reviewed by Jon Lee.
3100
3101         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3102
3103         * Configurations/FeatureDefines.xcconfig:
3104
3105 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3106
3107         Composition underline color is always black
3108         https://bugs.webkit.org/show_bug.cgi?id=174675
3109
3110         Reviewed by Ryosuke Niwa.
3111
3112         * WebView/WebHTMLView.mm:
3113         (extractUnderlines): If NSUnderlineColorAttributeName
3114         is not present use text color for composition underline.
3115         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3116         for composition underline in the plain text case.
3117
3118 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3119
3120         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3121         https://bugs.webkit.org/show_bug.cgi?id=175474
3122         <rdar://problem/33844628>
3123
3124         Reviewed by Wenson Hsieh.
3125
3126         Replaced the build flag by a runtime flag and disabled the feature by default.
3127
3128         * Configurations/FeatureDefines.xcconfig:
3129         * WebView/WebPreferenceKeysPrivate.h:
3130         * WebView/WebPreferences.mm:
3131         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3132         (-[WebPreferences dataTransferItemsEnabled]): Added.
3133         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3134         * WebView/WebPreferencesPrivate.h:
3135         * WebView/WebView.mm:
3136         (-[WebView _preferencesChanged:]):
3137
3138 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3139
3140         Remove ENABLE_GAMEPAD_DEPRECATED
3141         https://bugs.webkit.org/show_bug.cgi?id=175361
3142
3143         Reviewed by Carlos Garcia Campos.
3144
3145         * Configurations/FeatureDefines.xcconfig:
3146
3147 2017-08-09  Chris Dumez  <cdumez@apple.com>
3148
3149         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3150         https://bugs.webkit.org/show_bug.cgi?id=175401
3151
3152         Reviewed by Brady Eidson.
3153
3154         * WebView/WebPreferenceKeysPrivate.h:
3155         * WebView/WebPreferences.mm:
3156         (+[WebPreferences initialize]):
3157         (-[WebPreferences beaconAPIEnabled]): Deleted.
3158         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3159         * WebView/WebPreferencesPrivate.h:
3160         * WebView/WebView.mm:
3161         (-[WebView _preferencesChanged:]):
3162
3163 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3164
3165         [PAL] Move spi/cocoa and spi/cg directories into PAL
3166         https://bugs.webkit.org/show_bug.cgi?id=175175
3167
3168         Reviewed by Myles C. Maxfield.
3169
3170         * History/WebHistory.mm:
3171         * Misc/WebDownload.mm:
3172         * Misc/WebKitNSStringExtras.mm:
3173         * Plugins/Hosted/NetscapePluginHostManager.mm:
3174         * Plugins/WebPluginDatabase.mm:
3175         * WebCoreSupport/WebFrameLoaderClient.mm:
3176         * WebInspector/WebNodeHighlight.mm:
3177         * WebView/WebHTMLView.mm:
3178         * WebView/WebIndicateLayer.mm:
3179         * WebView/WebView.mm:
3180         * WebView/WebViewData.h:
3181
3182 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3183
3184         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3185         https://bugs.webkit.org/show_bug.cgi?id=175392
3186         <rdar://problem/33783207>
3187
3188         Reviewed by Tim Horton and Megan Gardner.
3189
3190         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3191
3192         * Configurations/FeatureDefines.xcconfig:
3193
3194 2017-08-09  Daniel Bates  <dabates@apple.com>
3195
3196         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3197         https://bugs.webkit.org/show_bug.cgi?id=175247
3198         <rdar://problem/33679804>
3199
3200         Reviewed by Brady Eidson.
3201
3202         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3203         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3204         clients that need to make use of this information at this time. If such a needs comes up
3205         then we can expose API/SPI similar to what we do for WebKit.
3206
3207         * WebCoreSupport/WebFrameLoaderClient.h:
3208         * WebCoreSupport/WebFrameLoaderClient.mm:
3209         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3210
3211 2017-08-08  Brady Eidson  <beidson@apple.com>
3212
3213         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3214         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3215
3216         Reviewed by Andy Estes.
3217
3218         * Misc/WebKitVersionChecks.h:
3219         * WebCoreSupport/WebFrameLoaderClient.mm:
3220         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3221           the app is linked against new WebKit with the new behavior.
3222
3223 2017-08-07  Devin Rousso  <drousso@apple.com>
3224
3225         Web Inspector: Preview Canvas path when viewing a recording
3226         https://bugs.webkit.org/show_bug.cgi?id=174967
3227
3228         Reviewed by Brian Burg.
3229
3230         * WebView/WebPreferenceKeysPrivate.h:
3231         * WebView/WebPreferences.mm:
3232         (+[WebPreferences initialize]):
3233         (-[WebPreferences inspectorAdditionsEnabled]):
3234         (-[WebPreferences setInspectorAdditionsEnabled:]):
3235         * WebView/WebPreferencesPrivate.h:
3236         * WebView/WebView.mm:
3237         (-[WebView _preferencesChanged:]):
3238         Add plumbing for new InspectorAdditions runtime flag.
3239
3240 2017-08-07  Brian Burg  <bburg@apple.com>
3241
3242         Remove CANVAS_PATH compilation guard
3243         https://bugs.webkit.org/show_bug.cgi?id=175207
3244
3245         Reviewed by Sam Weinig.
3246
3247         * Configurations/FeatureDefines.xcconfig:
3248
3249 2017-08-04  Youenn Fablet  <youenn@apple.com>
3250
3251         [Cache API] Add Cache and CacheStorage IDL definitions
3252         https://bugs.webkit.org/show_bug.cgi?id=175201
3253
3254         Reviewed by Brady Eidson.
3255
3256         * WebView/WebPreferenceKeysPrivate.h:
3257         * WebView/WebPreferences.mm:
3258         (+[WebPreferences initialize]):
3259         (-[WebPreferences cacheAPIEnabled]):
3260         (-[WebPreferences setCacheAPIEnabled:]):
3261         * WebView/WebPreferencesPrivate.h:
3262         * WebView/WebView.mm:
3263         (-[WebView _preferencesChanged:]):
3264
3265 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3266
3267         Unreviewed, rolling out r220271.
3268
3269         Rolling out due to Layout Test failing on iOS Simulator.
3270
3271         Reverted changeset:
3272
3273         "Remove STREAMS_API compilation guard"
3274         https://bugs.webkit.org/show_bug.cgi?id=175165
3275         http://trac.webkit.org/changeset/220271
3276
3277 2017-08-04  Youenn Fablet  <youenn@apple.com>
3278
3279         Remove STREAMS_API compilation guard
3280         https://bugs.webkit.org/show_bug.cgi?id=175165
3281
3282         Reviewed by Darin Adler.
3283
3284         * Configurations/FeatureDefines.xcconfig:
3285         * WebView/WebPreferences.mm:
3286         (+[WebPreferences initialize]):
3287         * WebView/WebView.mm:
3288         (-[WebView _preferencesChanged:]):
3289
3290 2017-08-03  Brian Burg  <bburg@apple.com>
3291
3292         Remove ENABLE(WEB_SOCKET) guards
3293         https://bugs.webkit.org/show_bug.cgi?id=167044
3294
3295         Reviewed by Joseph Pecoraro.
3296
3297         * Configurations/FeatureDefines.xcconfig:
3298         * WebView/WebPreferencesPrivate.h:
3299
3300 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3301
3302         [PAL] Move spi/cf directory into PAL
3303         https://bugs.webkit.org/show_bug.cgi?id=175057
3304
3305         Reviewed by Antti Koivisto.
3306
3307         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3308         * Plugins/WebNetscapePluginStream.mm:
3309         * WebCoreSupport/WebFrameNetworkingContext.mm:
3310         * WebView/WebPreferences.mm:
3311         * WebView/WebView.mm:
3312
3313 2017-08-03  Youenn Fablet  <youenn@apple.com>
3314
3315         Remove FETCH_API compilation guard
3316         https://bugs.webkit.org/show_bug.cgi?id=175154
3317
3318         Reviewed by Chris Dumez.
3319
3320         * Configurations/FeatureDefines.xcconfig:
3321         * WebView/WebPreferences.mm:
3322         (+[WebPreferences initialize]):
3323         * WebView/WebView.mm:
3324         (-[WebView _preferencesChanged:]):
3325
3326 2017-08-03  Brady Eidson  <beidson@apple.com>
3327
3328         Add SW IDLs and stub out basic functionality.
3329         https://bugs.webkit.org/show_bug.cgi?id=175115
3330
3331         Reviewed by Chris Dumez.
3332
3333         * Configurations/FeatureDefines.xcconfig:
3334
3335 2017-08-02  Sam Weinig  <sam@webkit.org>
3336
3337         [WebIDL] Convert MutationCallback to be a normal generated callback
3338         https://bugs.webkit.org/show_bug.cgi?id=174140
3339
3340         Reviewed by Darin Adler.
3341
3342         * DOM/DOMDocument.mm:
3343         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3344         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3345         Pass, now necessary, Document to NativeNodeFilter constructor.
3346
3347 2017-08-01  Chris Dumez  <cdumez@apple.com>
3348
3349         Add initial support for navigator.sendBeacon
3350         https://bugs.webkit.org/show_bug.cgi?id=175007
3351         <rdar://problem/33547728>
3352
3353         Reviewed by Sam Weinig.
3354
3355         Add setting to toggle support for the Beacon API (it is disabled by default).
3356
3357         * WebView/WebPreferenceKeysPrivate.h:
3358         * WebView/WebPreferences.mm:
3359         (+[WebPreferences initialize]):
3360         (-[WebPreferences beaconAPIEnabled]):
3361         (-[WebPreferences setBeaconAPIEnabled:]):
3362         * WebView/WebPreferencesPrivate.h:
3363         * WebView/WebView.mm:
3364         (-[WebView _preferencesChanged:]):
3365
3366 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3367
3368         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3369         https://bugs.webkit.org/show_bug.cgi?id=174437
3370
3371         Reviewed by Darin Adler.
3372
3373         Remove redundant Web- prefix from classes in WebKit namespace.
3374
3375         * WebView/WebView.mm:
3376         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3377         * WebView/WebViewData.h:
3378         * WebView/WebViewData.mm:
3379
3380 2017-07-26  Brian Burg  <bburg@apple.com>
3381
3382         Remove WEB_TIMING feature flag
3383         https://bugs.webkit.org/show_bug.cgi?id=174795
3384
3385         Reviewed by Alex Christensen.
3386
3387         * Configurations/FeatureDefines.xcconfig:
3388
3389 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3390
3391         Async image decoding for large images should be disabled after the first time a tile is painted
3392         https://bugs.webkit.org/show_bug.cgi?id=174451
3393         <rdar://problem/31246421>
3394
3395         Reviewed by Simon Fraser.
3396
3397         * WebView/WebFrame.mm:
3398         (-[WebFrame _paintBehaviorForDestinationContext:]):
3399         (-[WebFrame _drawRect:contentsOnly:]):
3400         * WebView/WebHTMLView.mm:
3401         (imageFromRect):
3402
3403 2017-07-23  Darin Adler  <darin@apple.com>
3404
3405         More NeverDestroyed and related cleanup
3406         https://bugs.webkit.org/show_bug.cgi?id=174745
3407
3408         Reviewed by Alex Christensen.
3409
3410         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3411         for names that aren't even used in this file.
3412         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3413         -[NSArray arrayWithObject:].
3414         (-[DOMNode absoluteQuads]): Ditto.
3415         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3416         of writing out various types.
3417         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3418         syntax instea of -[NSArray arrayWithObject:].
3419         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3420         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3421         of writing out various types.
3422         (-[DOMHTMLImageElement mimeType]): Ditto.
3423
3424 2017-07-24  Chris Dumez  <cdumez@apple.com>
3425
3426         ExceptionCode enumeration should use modern exception names
3427         https://bugs.webkit.org/show_bug.cgi?id=174794
3428
3429         Reviewed by Geoffrey Garen.
3430
3431         * DOM/ExceptionHandlers.mm:
3432         (raiseNotSupportedErrorException):
3433
3434 2017-07-23  Chris Dumez  <cdumez@apple.com>
3435
3436         Drop ExceptionCodeDescription class
3437         https://bugs.webkit.org/show_bug.cgi?id=174757
3438
3439         Reviewed by Darin Adler.
3440
3441         Stop using ExceptionCodeDescription.
3442
3443         * DOM/ExceptionHandlers.mm:
3444         (raiseDOMErrorException):
3445
3446 2017-07-21  Andreas Kling  <akling@apple.com>
3447
3448         Use more references in event dispatch code
3449         https://bugs.webkit.org/show_bug.cgi?id=174681
3450
3451         Reviewed by Geoffrey Garen.
3452
3453         * DOM/ObjCEventListener.h:
3454         * DOM/ObjCEventListener.mm:
3455         (WebCore::ObjCEventListener::handleEvent):
3456         * WebCoreSupport/WebFrameLoaderClient.mm:
3457         (NetscapePluginWidget::handleEvent):
3458
3459 2017-07-21  Brady Eidson  <beidson@apple.com>
3460
3461         Get rid of WebCore IconDatabase code.
3462         https://bugs.webkit.org/show_bug.cgi?id=174700
3463
3464         Reviewed by Tim Horton.
3465
3466         * Misc/WebCoreStatistics.mm:
3467         (+[WebCoreStatistics iconPageURLMappingCount]):
3468         (+[WebCoreStatistics iconRetainedPageURLCount]):
3469         (+[WebCoreStatistics iconRecordCount]):
3470         (+[WebCoreStatistics iconsWithDataCount]):
3471         * WebCoreSupport/WebFrameLoaderClient.h:
3472         * WebCoreSupport/WebFrameLoaderClient.mm:
3473         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3474         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3475         * WebView/WebView.mm:
3476         (-[WebView mainFrameIconURL]):
3477
3478 2017-07-20  Chris Dumez  <cdumez@apple.com>
3479
3480         Drop legacy XPathException type
3481         https://bugs.webkit.org/show_bug.cgi?id=174679
3482
3483         Reviewed by Sam Weinig.
3484
3485         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3486         no longer expose XPathException.
3487
3488         * DOM/ExceptionHandlers.mm:
3489         (raiseDOMErrorException):
3490
3491 2017-07-20  Chris Dumez  <cdumez@apple.com>
3492
3493         Unreviewed, rolling out r219706.
3494
3495         Broke iOS build
3496
3497         Reverted changeset:
3498
3499         "Drop legacy XPathException type"
3500         https://bugs.webkit.org/show_bug.cgi?id=174679
3501         http://trac.webkit.org/changeset/219706
3502
3503 2017-07-20  Chris Dumez  <cdumez@apple.com>
3504
3505         Drop legacy XPathException type
3506         https://bugs.webkit.org/show_bug.cgi?id=174679
3507
3508         Reviewed by Sam Weinig.
3509
3510         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3511         no longer expose XPathException.
3512
3513         * DOM/ExceptionHandlers.mm:
3514         (raiseDOMErrorException):
3515         * WebKit.exp:
3516
3517 2017-07-20  Chris Dumez  <cdumez@apple.com>
3518
3519         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3520         https://bugs.webkit.org/show_bug.cgi?id=174660
3521
3522         Reviewed by Geoffrey Garen.
3523
3524         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3525         This essentially replaces a branch to figure out if the new size is less or greater than the
3526         current size by an assertion.
3527
3528         * Plugins/WebNetscapePluginView.mm:
3529         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3530
3531 2017-07-20  Brady Eidson  <beidson@apple.com>
3532
3533         Deprecate WebIconDatabase in WebKitLegacy/mac.
3534         https://bugs.webkit.org/show_bug.cgi?id=174607
3535
3536         Reviewed by Alex Christensen.
3537
3538         This patch:
3539         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3540         2 - Guts the class to where it can only return the default icon at the small size
3541         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3542             use something else or to not do anything.
3543         
3544         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3545         and that patch will remove all of the last remnants of WebIconDatabase.
3546         
3547         * History/WebHistoryItem.mm:
3548         (-[WebHistoryItem icon]):
3549
3550         * Misc/WebIconDatabase.h:
3551         * Misc/WebIconDatabase.mm:
3552         (-[WebIconDatabase init]):
3553         (-[WebIconDatabase iconForURL:withSize:cache:]):
3554         (-[WebIconDatabase iconForURL:withSize:]):
3555         (-[WebIconDatabase defaultIconWithSize:]):
3556         (-[WebIconDatabase defaultIconForURL:withSize:]):
3557         (-[WebIconDatabase iconURLForURL:]):
3558         (-[WebIconDatabase retainIconForURL:]):
3559         (-[WebIconDatabase releaseIconForURL:]):
3560         (+[WebIconDatabase delayDatabaseCleanup]):
3561         (+[WebIconDatabase allowDatabaseCleanup]):
3562         (-[WebIconDatabase setDelegate:]):
3563         (-[WebIconDatabase delegate]):
3564         (+[WebIconDatabase initialize]): Deleted.
3565         (-[WebIconDatabase isEnabled]): Deleted.
3566         (-[WebIconDatabase setEnabled:]): Deleted.
3567         (-[WebIconDatabase removeAllIcons]): Deleted.
3568         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3569         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3570         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3571         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3572         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3573         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3574         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3575         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3576         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3577         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3578         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3579         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3580         (-[WebIconDatabase _databaseDirectory]): Deleted.
3581         (webGetNSImage): Deleted.
3582
3583         * Misc/WebIconDatabaseDelegate.h: Removed.
3584         * Misc/WebIconDatabaseInternal.h: Removed.
3585         * Misc/WebIconDatabasePrivate.h: Removed.
3586
3587         * WebCoreSupport/WebFrameLoaderClient.mm:
3588         (webGetNSImage):
3589
3590         * WebCoreSupport/WebIconDatabaseClient.mm:
3591         (WebIconDatabaseClient::didRemoveAllIcons):
3592         (WebIconDatabaseClient::didImportIconURLForPageURL):
3593
3594         * WebView/WebView.mm:
3595         (-[WebView setFrameLoadDelegate:]):
3596         (-[WebView mainFrameIcon]):
3597
3598 2017-07-18  Andy Estes  <aestes@apple.com>
3599
3600         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3601         https://bugs.webkit.org/show_bug.cgi?id=174631
3602
3603         Reviewed by Tim Horton.
3604
3605         * Configurations/Base.xcconfig:
3606
3607 2017-07-18  Andy Estes  <aestes@apple.com>
3608
3609         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3610         https://bugs.webkit.org/show_bug.cgi?id=174631
3611
3612         Reviewed by Sam Weinig.
3613
3614         * Configurations/Base.xcconfig:
3615
3616 2017-07-18  Andy Estes  <aestes@apple.com>
3617
3618         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3619         https://bugs.webkit.org/show_bug.cgi?id=174631
3620
3621         Reviewed by Dan Bernstein.
3622
3623         * Configurations/Base.xcconfig:
3624
3625 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3626
3627         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3628         https://bugs.webkit.org/show_bug.cgi?id=174640
3629         <rdar://problem/33297400>
3630
3631         Reviewed by Tim Horton.
3632
3633         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3634         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3635         web thread here, to match the other WebView drag and drop SPI methods.
3636
3637         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3638         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3639         should make this robust against future UIKit changes that could make this no longer the case.
3640
3641         * WebView/WebView.mm:
3642         (-[WebView _requestStartDataInteraction:globalPosition:]):
3643         (-[WebView _dataInteractionCaretRect]):
3644
3645 2017-07-18  Andy Estes  <aestes@apple.com>
3646
3647         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3648         https://bugs.webkit.org/show_bug.cgi?id=174631
3649
3650         Reviewed by Darin Adler.
3651
3652         * Configurations/Base.xcconfig:
3653
3654 2017-07-17  Sam Weinig  <sam@webkit.org>
3655
3656         [WebIDL] Remove custom bindings that require non-caching JS strings
3657         https://bugs.webkit.org/show_bug.cgi?id=174552
3658
3659         Reviewed by Darin Adler.
3660
3661         * DOM/DOMHTMLCanvasElement.mm:
3662         (-[DOMHTMLCanvasElement toDataURL:]):
3663         Update to account for implementation now returning an UncachedString.
3664
3665 2017-07-17  Darin Adler  <darin@apple.com>
3666
3667         Improve use of NeverDestroyed
3668         https://bugs.webkit.org/show_bug.cgi?id=174348
3669
3670         Reviewed by Sam Weinig.
3671
3672         * Misc/WebStringTruncator.mm:
3673         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3674         NeverDestroyed<RetainPtr> with just an NSFont * global.
3675
3676         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3677         NeverDestroyed.h.
3678         * Storage/WebDatabaseManager.mm: Ditto.
3679         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3680         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3681
3682         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3683         (aeDescFromJSValue): Removed double hashing by using the return value from
3684         add rather than calling contains before calling add.
3685
3686 2017-07-14  Jer Noble  <jer.noble@apple.com>
3687
3688         Allow clients to override their own hardware media requirements where no fallback media exists.
3689         https://bugs.webkit.org/show_bug.cgi?id=174426
3690         <rdar://problem/32537704>
3691
3692         Reviewed by Eric Carlson.
3693
3694         Add a new WebPreferences property to control WebCore's new
3695         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3696
3697         * WebView/WebPreferenceKeysPrivate.h:
3698         * WebView/WebPreferences.mm:
3699         (+[WebPreferences initialize]):
3700         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3701         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3702         * WebView/WebPreferencesPrivate.h:
3703         * WebView/WebView.mm:
3704         (-[WebView _preferencesChanged:]):
3705
3706 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3707
3708         Async image decoding for large images should be disabled by default
3709         https://bugs.webkit.org/show_bug.cgi?id=174432
3710
3711         Reviewed by Simon Fraser.
3712
3713         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3714         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3715         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3716            a child view instead of propagating PaintBehaviorSnapshotting.
3717         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3718            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3719
3720         * WebView/WebFrame.mm:
3721         (-[WebFrame _paintBehaviorForDestinationContext:]):
3722         (-[WebFrame _drawRect:contentsOnly:]):
3723         * WebView/WebHTMLView.mm:
3724         (imageFromRect):
3725
3726 2017-07-12  Daniel Bates  <dabates@apple.com>
3727
3728         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3729         https://bugs.webkit.org/show_bug.cgi?id=174427
3730
3731         Rubber-stamped by Brady Eidson.
3732
3733         * WebView/WebPDFView.mm:
3734         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3735
3736 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3737
3738         Unreviewed, rolling out r219401.
3739
3740         This revision rolled out the previous patch, but after talking
3741         with reviewer, a rebaseline is what was needed.Rolling back in
3742         before rebaseline.
3743
3744         Reverted changeset:
3745
3746         "Unreviewed, rolling out r219379."
3747         https://bugs.webkit.org/show_bug.cgi?id=174400
3748         http://trac.webkit.org/changeset/219401
3749
3750 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3751
3752         Unreviewed, rolling out r219379.
3753
3754         This revision caused a consistent failure in the test
3755         fast/dom/Window/property-access-on-cached-window-after-frame-
3756         removed.html.
3757
3758         Reverted changeset:
3759
3760         "Remove NAVIGATOR_HWCONCURRENCY"
3761         https://bugs.webkit.org/show_bug.cgi?id=174400
3762         http://trac.webkit.org/changeset/219379
3763
3764 2017-07-11  Dean Jackson  <dino@apple.com>
3765
3766         Remove NAVIGATOR_HWCONCURRENCY
3767         https://bugs.webkit.org/show_bug.cgi?id=174400
3768
3769         * Configurations/FeatureDefines.xcconfig:
3770
3771 2017-07-11  Dean Jackson  <dino@apple.com>
3772
3773         Rolling out r219372.
3774
3775         * Configurations/FeatureDefines.xcconfig:
3776
3777 2017-07-11  Dean Jackson  <dino@apple.com>
3778
3779         Remove NAVIGATOR_HWCONCURRENCY
3780         https://bugs.webkit.org/show_bug.cgi?id=174400
3781
3782         * Configurations/FeatureDefines.xcconfig:
3783
3784 2017-07-03  Brian Burg  <bburg@apple.com>
3785
3786         Web Replay: remove some unused code
3787         https://bugs.webkit.org/show_bug.cgi?id=173903
3788
3789         Rubber-stamped by Joseph Pecoraro.
3790
3791         * Configurations/FeatureDefines.xcconfig:
3792
3793 2017-07-09  Brady Eidson  <beidson@apple.com>
3794
3795         Remove some obsolete WebKitVersionChecks.
3796         https://bugs.webkit.org/show_bug.cgi?id=174294
3797
3798         Reviewed by Dan Bernstein.
3799
3800         * Misc/WebKitVersionChecks.h:
3801
3802         * WebView/WebHTMLView.mm:
3803         (-[WebHTMLView hitTest:]):
3804
3805         * WebView/WebView.mm:
3806         (shouldRespectPriorityInCSSAttributeSetters):
3807         (-[WebView _commonInitializationWithFrameName:groupName:]):
3808         (-[WebView _preferencesChanged:]):
3809         (shouldTransformsAffectOverflow): Deleted.
3810         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3811
3812 2017-07-08  Brady Eidson  <beidson@apple.com>
3813
3814         Remove some obsolete RuntimeApplicationChecks.
3815         https://bugs.webkit.org/show_bug.cgi?id=174293
3816
3817         Reviewed by Dan Bernstein.
3818
3819         * Misc/WebKitVersionChecks.h:
3820         * WebView/WebView.mm:
3821         (+[WebView enableWebThread]):
3822         (-[WebView _needsPreHTML5ParserQuirks]):
3823
3824 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3825
3826         Drop NOSNIFF compile flag
3827         https://bugs.webkit.org/show_bug.cgi?id=174289
3828
3829         Reviewed by Michael Catanzaro.
3830
3831         * Configurations/FeatureDefines.xcconfig:
3832
3833 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3834
3835         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3836         https://bugs.webkit.org/show_bug.cgi?id=174150
3837
3838         Reviewed by Mark Lam.
3839
3840         * DOM/DOM.mm:
3841         (lookupElementClass):
3842
3843 2017-07-06  Brady Eidson  <beidson@apple.com>
3844
3845         Add logging to first attempt to use the WebIconDatabase class.
3846         https://bugs.webkit.org/show_bug.cgi?id=174190
3847
3848         Reviewed by Andy Estes.
3849
3850         * Misc/WebIconDatabase.mm:
3851         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3852         * Misc/WebKitVersionChecks.h:
3853
3854 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3855
3856         Unreviewed, rolling out r219178.
3857
3858         This caused a consistent failure with the API test
3859         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3860
3861         Reverted changeset:
3862
3863         "[WTF] Clean up StringStatics.cpp by using
3864         LazyNeverDestroyed<> for Atoms"
3865         https://bugs.webkit.org/show_bug.cgi?id=174150
3866         http://trac.webkit.org/changeset/219178
3867
3868 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3869
3870         [WTF] Move SoftLinking.h into WTF
3871         https://bugs.webkit.org/show_bug.cgi?id=174000
3872
3873         Reviewed by Alex Christensen.
3874
3875         * Plugins/WebNetscapePluginView.mm:
3876         * Plugins/WebPluginController.mm:
3877         * WebCoreSupport/WebInspectorClient.mm:
3878         * WebView/WebFullScreenController.mm:
3879         * WebView/WebImmediateActionController.mm:
3880         * WebView/WebView.mm:
3881
3882 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3883
3884         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3885         https://bugs.webkit.org/show_bug.cgi?id=174150
3886
3887         Reviewed by Mark Lam.
3888
3889         * DOM/DOM.mm:
3890         (lookupElementClass):
3891
3892 2017-07-05  Brady Eidson  <beidson@apple.com>
3893
3894         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3895         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3896
3897         Reviewed by Alex Christensen.
3898
3899         Adopt to the new constructor for FrameLoadRequest.
3900
3901         * WebView/WebPDFView.mm:
3902         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3903
3904 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3905
3906         Make WebKit's public headers on Mac and iOS C++ module safe
3907         https://bugs.webkit.org/show_bug.cgi?id=174175
3908
3909         Reviewed by Alex Christensen.
3910
3911         Fixed the header files.
3912
3913         * Misc/WebDownload.h:
3914         * Misc/WebKitErrors.h:
3915         * Plugins/WebPluginContainer.h:
3916         * WebView/WebResourceLoadDelegate.h:
3917
3918 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3919
3920         Remove copy of ICU headers from WebKit
3921         https://bugs.webkit.org/show_bug.cgi?id=116407
3922
3923         Reviewed by Alex Christensen.
3924
3925         Use WTF's copy of ICU headers.
3926
3927         * Configurations/WebKitLegacy.xcconfig:
3928         * icu/unicode/localpointer.h: Removed.
3929         * icu/unicode/parseerr.h: Removed.
3930         * icu/unicode/platform.h: Removed.
3931         * icu/unicode/ptypes.h: Removed.
3932         * icu/unicode/putil.h: Removed.
3933         * icu/unicode/uchar.h: Removed.
3934         * icu/unicode/uconfig.h: Removed.
3935         * icu/unicode/ucurr.h: Removed.
3936         * icu/unicode/uidna.h: Removed.
3937         * icu/unicode/uiter.h: Removed.
3938         * icu/unicode/umachine.h: Removed.
3939         * icu/unicode/unorm.h: Removed.
3940         * icu/unicode/unorm2.h: Removed.
3941         * icu/unicode/urename.h: Removed.
3942         * icu/unicode/uscript.h: Removed.
3943         * icu/unicode/ustring.h: Removed.
3944         * icu/unicode/utf.h: Removed.
3945         * icu/unicode/utf16.h: Removed.
3946         * icu/unicode/utf8.h: Removed.
3947         * icu/unicode/utf_old.h: Removed.
3948         * icu/unicode/utypes.h: Removed.
3949         * icu/unicode/uvernum.h: Removed.
3950         * icu/unicode/uversion.h: Removed.
3951
3952 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3953
3954         Add WebKitPrivateFrameworkStubs for iOS 11
3955         https://bugs.webkit.org/show_bug.cgi?id=173988
3956
3957         Reviewed by David Kilzer.
3958
3959         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3960         use the same directory for private framework stubs.
3961
3962 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3963
3964         Unreviewed, rolling out r219103.
3965
3966         Caused multiple build failures.
3967
3968         Reverted changeset:
3969
3970         "Remove copy of ICU headers from WebKit"
3971         https://bugs.webkit.org/show_bug.cgi?id=116407
3972         http://trac.webkit.org/changeset/219103
3973
3974 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3975
3976         Remove copy of ICU headers from WebKit
3977         https://bugs.webkit.org/show_bug.cgi?id=116407
3978
3979         Reviewed by Alex Christensen.
3980
3981         Use WTF's copy of ICU headers.
3982
3983         * Configurations/WebKitLegacy.xcconfig:
3984         * icu/unicode/localpointer.h: Removed.
3985         * icu/unicode/parseerr.h: Removed.
3986         * icu/unicode/platform.h: Removed.
3987         * icu/unicode/ptypes.h: Removed.
3988         * icu/unicode/putil.h: Removed.
3989         * icu/unicode/uchar.h: Removed.
3990         * icu/unicode/uconfig.h: Removed.
3991         * icu/unicode/ucurr.h: Removed.
3992         * icu/unicode/uidna.h: Removed.
3993         * icu/unicode/uiter.h: Removed.
3994         * icu/unicode/umachine.h: Removed.
3995         * icu/unicode/unorm.h: Removed.
3996         * icu/unicode/unorm2.h: Removed.
3997         * icu/unicode/urename.h: Removed.
3998         * icu/unicode/uscript.h: Removed.
3999         * icu/unicode/ustring.h: Removed.
4000         * icu/unicode/utf.h: Removed.
4001         * icu/unicode/utf16.h: Removed.
4002         * icu/unicode/utf8.h: Removed.
4003         * icu/unicode/utf_old.h: Removed.
4004         * icu/unicode/utypes.h: Removed.
4005         * icu/unicode/uvernum.h: Removed.
4006         * icu/unicode/uversion.h: Removed.
4007
4008 2017-07-03  Brady Eidson  <beidson@apple.com>
4009
4010         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
4011         https://bugs.webkit.org/show_bug.cgi?id=174073
4012
4013         Reviewed by Andy Estes.
4014
4015         WebView now keeps a direct copy of its main frame icon as a member variable.
4016         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
4017         
4018         This change causes a progression in KVO observation of the mainFrameIcon property as we now
4019         have both the old icon and new icon at the time it changes.
4020
4021         * WebCoreSupport/WebFrameLoaderClient.h:
4022         * WebCoreSupport/WebFrameLoaderClient.mm:
4023         (WebFrameLoaderClient::prepareForDataSourceReplacement):
4024         (WebFrameLoaderClient::getLoadDecisionForIcons):
4025         (WebFrameLoaderClient::finishedLoadingIcon):
4026         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
4027         (WebFrameLoaderClient::registerForIconNotification): Deleted.
4028
4029         * WebView/WebView.mm:
4030         (+[WebView _setIconLoadingEnabled:]):
4031         (+[WebView _isIconLoadingEnabled]):
4032         (-[WebView mainFrameIcon]):
4033         (-[WebView _setMainFrameIcon:]):
4034         (-[WebView _receivedIconChangedNotification:]): Deleted.
4035         (-[WebView _registerForIconNotification:]): Deleted.
4036         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
4037         * WebView/WebViewData.h:
4038         * WebView/WebViewInternal.h:
4039         * WebView/WebViewPrivate.h:
4040
4041 2017-07-03  Sam Weinig  <sam@webkit.org>
4042
4043         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
4044         https://bugs.webkit.org/show_bug.cgi?id=174083
4045
4046         Reviewed by Alex Christensen.
4047
4048         * Configurations/FeatureDefines.xcconfig:
4049         Add ENABLE_NAVIGATOR_STANDALONE.
4050
4051 2017-07-03  Tim Horton  <timothy_horton@apple.com>
4052
4053         Expose unobscuredSafeAreaInsets on WebView
4054         https://bugs.webkit.org/show_bug.cgi?id=174075
4055         <rdar://problem/33096997>
4056
4057         Reviewed by Beth Dakin.
4058
4059         * WebView/WebView.mm:
4060         (-[WebView _setUnobscuredSafeAreaInsets:]):
4061         (-[WebView _unobscuredSafeAreaInsets]):
4062         * WebView/WebViewPrivate.h:
4063         Expose unobscuredSafeAreaInsets as a new private property on WebView,
4064         similar to how it is exposed in WebKit2.
4065
4066 2017-07-03  Andy Estes  <aestes@apple.com>
4067
4068         [Xcode] Add an experimental setting to build with ccache
4069         https://bugs.webkit.org/show_bug.cgi?id=173875
4070
4071         Reviewed by Tim Horton.
4072
4073         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
4074
4075 2017-07-03  Tim Horton  <timothy_horton@apple.com>
4076
4077         Expose WebPreferences for viewport-fit and constant() properties
4078         https://bugs.webkit.org/show_bug.cgi?id=174072
4079         <rdar://problem/33096639>
4080
4081         Reviewed by Ryosuke Niwa.
4082
4083         * WebView/WebPreferenceKeysPrivate.h:
4084         * WebView/WebPreferences.mm:
4085         (-[WebPreferences viewportFitEnabled]):
4086         (-[WebPreferences setViewportFitEnabled:]):
4087         (-[WebPreferences constantPropertiesEnabled]):
4088         (-[WebPreferences setConstantPropertiesEnabled:]):
4089         * WebView/WebPreferencesPrivate.h:
4090         * WebView/WebView.mm:
4091         (-[WebView _preferencesChanged:]):
4092
4093 2017-07-01  Tim Horton  <timothy_horton@apple.com>
4094
4095         Expose viewport-fit value to UIKit via viewport arguments dictionary
4096         https://bugs.webkit.org/show_bug.cgi?id=174071
4097         <rdar://problem/33096620>
4098
4099         Reviewed by Wenson Hsieh.
4100
4101         * History/WebHistoryItem.mm:
4102         * History/WebHistoryItemPrivate.h:
4103         Add another dictionary key and three values.
4104
4105 2017-07-01  Dan Bernstein