[WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
4         https://bugs.webkit.org/show_bug.cgi?id=183312
5
6         Reviewed by Mark Lam.
7
8         Remove wtf/CurrentTime.h include pragma.
9
10         * WebView/WebFrame.mm:
11         * WebView/WebPDFView.mm:
12
13 2018-03-04  Tim Horton  <timothy_horton@apple.com>
14
15         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
16         https://bugs.webkit.org/show_bug.cgi?id=183283
17         <rdar://problem/38062148>
18
19         Reviewed by Sam Weinig.
20
21         * Configurations/FeatureDefines.xcconfig:
22
23 2018-02-28  Alex Christensen  <achristensen@webkit.org>
24
25         Reduce use of NetworkingContext in WebKit
26         https://bugs.webkit.org/show_bug.cgi?id=183213
27
28         Reviewed by Brady Eidson.
29
30         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
31         (WebKit::NetscapePluginInstanceProxy::getProxy):
32         * Plugins/WebNetscapePluginView.mm:
33         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
34
35 2018-02-17  Darin Adler  <darin@apple.com>
36
37         Prepare for ExtendedColor changes (first step)
38         https://bugs.webkit.org/show_bug.cgi?id=182904
39
40         Reviewed by Sam Weinig.
41
42         * Misc/WebKitNSStringExtras.mm:
43         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
44
45 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
46
47         Remove currentTime() / currentTimeMS()
48         https://bugs.webkit.org/show_bug.cgi?id=183052
49
50         Reviewed by Mark Lam.
51
52         * WebCoreSupport/WebFrameLoaderClient.h:
53         * WebCoreSupport/WebFrameLoaderClient.mm:
54         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
55
56 2018-02-16  Youenn Fablet  <youenn@apple.com>
57
58         Allow specifying which plug-ins are supported
59         https://bugs.webkit.org/show_bug.cgi?id=182748
60
61         Reviewed by Chris Dumez.
62
63         * WebCoreSupport/WebPluginInfoProvider.h:
64         * WebCoreSupport/WebPluginInfoProvider.mm:
65         (WebPluginInfoProvider::getPluginInfo):
66         (WebPluginInfoProvider::getWebVisiblePluginInfo):
67
68 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
69
70         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
71         https://bugs.webkit.org/show_bug.cgi?id=182882
72         <rdar://problem/35672661>
73
74         Reviewed by Dan Bernstein.
75
76         Make sure the smart pointer hold the collection of subviews lives at least as
77         long as the loop using it.
78
79         * WebView/WebHTMLView.mm:
80         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
81
82 2018-02-14  Daniel Bates  <dabates@apple.com>
83
84         Disallow cross-origin subresources from asking for credentials
85         https://bugs.webkit.org/show_bug.cgi?id=182579
86         <rdar://problem/36162271>
87
88         Reviewed by Andy Estes.
89
90         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
91         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
92
93         * WebView/WebPreferenceKeysPrivate.h:
94         * WebView/WebPreferences.mm:
95         (+[WebPreferences initialize]):
96         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
97         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
98         * WebView/WebPreferencesPrivate.h:
99         * WebView/WebView.mm:
100         (-[WebView _preferencesChanged:]):
101
102 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
103
104         Remove ForwardingHeaders directory from WebKitLegacy/mac.
105         https://bugs.webkit.org/show_bug.cgi?id=182738
106
107         Reviewed by Darin Adler.
108
109         * ForwardingHeaders/collector/handles/Global.h: Removed.
110         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
111         * ForwardingHeaders/runtime/Completion.h: Removed.
112         * ForwardingHeaders/runtime/Error.h: Removed.
113         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
114         * ForwardingHeaders/runtime/JSFunction.h: Removed.
115         * ForwardingHeaders/runtime/JSLock.h: Removed.
116         * ForwardingHeaders/runtime/JSObject.h: Removed.
117         * ForwardingHeaders/runtime/JSString.h: Removed.
118         * ForwardingHeaders/runtime/Protect.h: Removed.
119         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
120
121 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
122
123         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
124         https://bugs.webkit.org/show_bug.cgi?id=182641
125
126         Reviewed by Dan Bernstein.
127
128         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
129         https://trac.webkit.org/changeset/228308.
130
131         * WebView/WebVideoFullscreenController.h:
132         * WebView/WebVideoFullscreenHUDWindowController.mm:
133         * WebView/WebWindowAnimation.h:
134         * WebView/WebWindowAnimation.mm:
135         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
136         (WebCore::scaledRect): Deleted.
137         (WebCore::squaredDistance): Deleted.
138
139 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
140
141         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
142
143         * WebView/WebWindowAnimation.mm:
144         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
145
146 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
147
148         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
149         https://bugs.webkit.org/show_bug.cgi?id=182615
150
151         Reviewed by Eric Carlson.
152
153         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
154         Ideally, we should not reference NSApp in WebCore.
155
156         * WebView/WebFullScreenController.mm:
157         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
158         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
159         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
160         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
161         * WebView/WebView.mm:
162         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
163         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
164
165 2018-01-13  Darin Adler  <darin@apple.com>
166
167         Event improvements
168         https://bugs.webkit.org/show_bug.cgi?id=179591
169
170         Reviewed by Chris Dumez.
171
172         * DOM/DOMWheelEvent.mm:
173         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
174         Call initWebKitWheelEvent.
175
176         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
177         * WebCoreSupport/WebInspectorClient.mm: Ditto.
178         * WebView/WebFrame.mm: Ditto.
179
180         * WebView/WebHTMLView.mm:
181         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
182         underlyingPlatformEvent.
183         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
184
185         * WebView/WebScriptWorld.mm:
186         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
187
188         * WebView/WebView.mm: Removed include of ScriptValue.h.
189
190 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
191
192         Remove WebCore/ForwardingHeaders directory
193         https://bugs.webkit.org/show_bug.cgi?id=182347
194
195         Reviewed by Keith Miller.
196
197         * Carbon/CarbonWindowAdapter.mm:
198         * DOM/WebDOMOperations.mm:
199         * History/WebBackForwardList.mm:
200         * History/WebHistoryItem.mm:
201         * Misc/WebCache.mm:
202         * Misc/WebElementDictionary.mm:
203         * Misc/WebIconDatabase.mm:
204         * Misc/WebStringTruncator.mm:
205         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
206         * Plugins/Hosted/ProxyInstance.mm:
207         * Plugins/Hosted/ProxyRuntimeObject.mm:
208         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
209         * Plugins/WebBaseNetscapePluginView.mm:
210         * Plugins/WebBasePluginPackage.mm:
211         * Plugins/WebNetscapePluginStream.mm:
212         * Plugins/WebNetscapePluginView.mm:
213         * Plugins/WebPluginController.mm:
214         * WebCoreSupport/WebEditorClient.mm:
215         * WebCoreSupport/WebFrameLoaderClient.mm:
216         * WebCoreSupport/WebInspectorClient.h:
217         * WebCoreSupport/WebInspectorClient.mm:
218         * WebView/WebDataSource.mm:
219         * WebView/WebFrame.mm:
220         * WebView/WebHTMLRepresentation.mm:
221         * WebView/WebHTMLView.mm:
222         * WebView/WebPreferences.mm:
223         * WebView/WebScriptDebugDelegate.mm:
224         * WebView/WebScriptDebugger.h:
225         * WebView/WebTextIterator.mm:
226         * WebView/WebView.mm:
227         * WebView/WebViewData.mm:
228
229 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
230
231         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
232         https://bugs.webkit.org/show_bug.cgi?id=182312
233
234         Reviewed by Michael Catanzaro.
235
236         * WebKitPrefix.h:
237
238 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
239
240         [WebAuthN] Add a compile-time feature flag
241         https://bugs.webkit.org/show_bug.cgi?id=182211
242         <rdar://problem/36936365>
243
244         Reviewed by Brent Fulgham.
245
246         * Configurations/FeatureDefines.xcconfig:
247
248 2018-01-27  Dan Bernstein  <mitz@apple.com>
249
250         HaveInternalSDK includes should be "#include?"
251         https://bugs.webkit.org/show_bug.cgi?id=179670
252
253         * Configurations/Base.xcconfig:
254
255 2018-01-24  Alex Christensen  <achristensen@webkit.org>
256
257         Remove unused QTKit preference
258         https://bugs.webkit.org/show_bug.cgi?id=181968
259
260         Reviewed by Alexey Proskuryakov.
261
262         * WebView/WebPreferenceKeysPrivate.h:
263         * WebView/WebPreferences.mm:
264         (+[WebPreferences initialize]):
265         (-[WebPreferences setQTKitEnabled:]): Deleted.
266         (-[WebPreferences isQTKitEnabled]): Deleted.
267         * WebView/WebPreferencesPrivate.h:
268         * WebView/WebView.mm:
269         (-[WebView _preferencesChanged:]):
270
271 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
272
273         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
274         https://bugs.webkit.org/show_bug.cgi?id=182037
275         <rdar://problem/36747812>
276
277         Reviewed by Ryosuke Niwa.
278
279         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
280         for more details.
281
282         * WebView/WebHTMLRepresentation.mm:
283         (-[WebHTMLRepresentation elementWithName:inForm:]):
284         (-[WebHTMLRepresentation controlsInForm:]):
285
286 2018-01-23  Alex Christensen  <achristensen@webkit.org>
287
288         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
289         https://bugs.webkit.org/show_bug.cgi?id=181961
290
291         Reviewed by Michael Catanzaro.
292
293         * WebView/WebPreferences.mm:
294
295 2018-01-23  Commit Queue  <commit-queue@webkit.org>
296
297         Unreviewed, rolling out r227437.
298         https://bugs.webkit.org/show_bug.cgi?id=182011
299
300         broke build (Requested by alexchristensen on #webkit).
301
302         Reverted changeset:
303
304         "Remove unused QTKit preference"
305         https://bugs.webkit.org/show_bug.cgi?id=181968
306         https://trac.webkit.org/changeset/227437
307
308 2018-01-23  Alex Christensen  <achristensen@webkit.org>
309
310         Remove unused QTKit preference
311         https://bugs.webkit.org/show_bug.cgi?id=181968
312
313         Reviewed by Alexey Proskuryakov.
314
315         * WebView/WebPreferenceKeysPrivate.h:
316         * WebView/WebPreferences.mm:
317         (+[WebPreferences initialize]):
318         (-[WebPreferences setQTKitEnabled:]): Deleted.
319         (-[WebPreferences isQTKitEnabled]): Deleted.
320         * WebView/WebPreferencesPrivate.h:
321         * WebView/WebView.mm:
322         (-[WebView _preferencesChanged:]):
323
324 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
325
326         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
327         https://bugs.webkit.org/show_bug.cgi?id=181960
328         <rdar://problem/36431678>
329
330         Reviewed by Tim Horton.
331
332         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
333         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
334         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
335
336         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
337         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
338         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
339
340         * WebView/WebView.mm:
341         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
342
343 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
344
345         Turning off custom pasteboard data doesn't actually turn it off in WK2
346         https://bugs.webkit.org/show_bug.cgi?id=181920
347         <rdar://problem/36686429>
348
349         Reviewed by Wenson Hsieh.
350
351         Always disable custom pasteboard data in WebKit1. See r226156 for details.
352
353         * WebView/WebPreferences.mm:
354         (+[WebPreferences initialize]):
355         * WebView/WebView.mm:
356         (-[WebView _preferencesChanged:]):
357
358 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
359
360         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
361         https://bugs.webkit.org/show_bug.cgi?id=181918
362
363         Reviewed by Tim Horton.
364
365         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
366
367         * Configurations/FeatureDefines.xcconfig:
368
369 2018-01-20  Andy Estes  <aestes@apple.com>
370
371         [Apple Pay] Stop eagerly loading PassKit.framework
372         https://bugs.webkit.org/show_bug.cgi?id=181911
373         <rdar://problem/36555369>
374
375         Reviewed by Tim Horton.
376
377         * WebCoreSupport/WebPaymentCoordinatorClient.h:
378         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
379         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
380
381         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
382
383 2018-01-19  Dean Jackson  <dino@apple.com>
384
385         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
386         https://bugs.webkit.org/show_bug.cgi?id=181817
387         <rdar://problem/35274055>
388
389         Reviewed by Simon Fraser.
390
391         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
392
393         * Misc/WebKitVersionChecks.h:
394         * WebView/WebView.mm:
395         (-[WebView _commonInitializationWithFrameName:groupName:]):
396
397 2018-01-19  Alex Christensen  <achristensen@webkit.org>
398
399         Remove unused WebViewPrivate _allowCookies
400         https://bugs.webkit.org/show_bug.cgi?id=181812
401
402         Reviewed by Tim Horton.
403
404         * WebView/WebView.mm:
405         (+[WebView _setAllowCookies:]): Deleted.
406         (+[WebView _allowCookies]): Deleted.
407         * WebView/WebViewPrivate.h:
408
409 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
410
411         Build fix, remove a call to -[NSWindow setOneShot:]
412         https://bugs.webkit.org/show_bug.cgi?id=181809
413
414         Reviewed by Tim Horton.
415
416         * WebView/WebTextCompletionController.mm:
417         (-[WebTextCompletionController _buildUI]):
418
419 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
420
421         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
422
423         * Carbon/HIWebView.mm:
424         (overrideCGContext):
425         (restoreCGContext):
426
427 2018-01-18  Dan Bernstein  <mitz@apple.com>
428
429         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
430         https://bugs.webkit.org/show_bug.cgi?id=181803
431
432         Reviewed by Tim Horton.
433
434         * Configurations/Base.xcconfig: Updated.
435         * Configurations/DebugRelease.xcconfig: Ditto.
436         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
437         * Configurations/Version.xcconfig: Updated.
438         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
439           useful for defining settings that depend on the target macOS version.
440
441 2018-01-17  Youenn Fablet  <youenn@apple.com>
442
443         Put fetch Request.keepalive behind a runtime flag
444         https://bugs.webkit.org/show_bug.cgi?id=181592
445
446         Reviewed by Chris Dumez.
447
448         * WebView/WebPreferenceKeysPrivate.h:
449         * WebView/WebPreferences.mm:
450         (+[WebPreferences initialize]):
451         (-[WebPreferences fetchAPIKeepAliveEnabled]):
452         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
453         * WebView/WebPreferencesPrivate.h:
454         * WebView/WebView.mm:
455         (-[WebView _preferencesChanged:]):
456
457 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
458
459         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
460         https://bugs.webkit.org/show_bug.cgi?id=181637
461         <rdar://problem/36508471>
462
463         Reviewed by Tim Horton.
464
465         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
466
467         * WebCoreSupport/WebEditorClient.h:
468         * WebCoreSupport/WebEditorClient.mm:
469         (WebEditorClient::replacementURLForResource):
470
471 2018-01-11  Keith Miller  <keith_miller@apple.com>
472
473         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
474         https://bugs.webkit.org/show_bug.cgi?id=181573
475
476         Reviewed by Simon Fraser.
477
478         * Configurations/FeatureDefines.xcconfig:
479
480 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
481
482         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
483         https://bugs.webkit.org/show_bug.cgi?id=181497
484
485         Reviewed by Tim Horton.
486
487         See other ChangeLogs for more detail.
488
489         * WebCoreSupport/WebDragClient.h:
490
491 2018-01-11  Tim Horton  <timothy_horton@apple.com>
492
493         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
494         https://bugs.webkit.org/show_bug.cgi?id=181523
495         <rdar://problem/28959131>
496
497         Reviewed by Alex Christensen.
498
499         * WebView/WebImmediateActionController.mm:
500         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
501         Apply the change made in r216652 to WebKit1's immediate action controller.
502
503         Speculative (but successful in WebKit2) fix for non-reproducible crash when
504         the startContainer of the range is in an anonymous node.
505
506 2018-01-11  Youenn Fablet  <youenn@apple.com>
507
508         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
509         https://bugs.webkit.org/show_bug.cgi?id=181480
510
511         Reviewed by Eric Carlson.
512
513         * WebView/WebPreferences.mm:
514         (+[WebPreferences initialize]):
515
516 2018-01-08  David Kilzer  <ddkilzer@apple.com>
517
518         Fix check-webkit-style issues with WebNSDataExtras.mm
519         <https://webkit.org/b/181369>
520
521         Reviewed by Alex Christensen.
522
523         * Misc/WebNSDataExtras.mm:
524         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
525         (-[NSData _webkit_guessedMIMETypeForXML]):
526         (-[NSData _webkit_guessedMIMEType]):
527         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
528         (_findEOL):
529         (-[NSData _webkit_parseRFC822HeaderFields]):
530         (-[NSData _web_locationAfterFirstBlankLine]):
531         - Fix all the check-webkit-style warnings.
532
533 2018-01-08  David Kilzer  <ddkilzer@apple.com>
534
535         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
536         <https://webkit.org/b/181256>
537         <rdar://problem/36281730>
538
539         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
540         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
541         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
542           to avoid warnings from casting CFStringRef to NPNSString*.
543           Note that CFMutableStringRef is the same as CFStringRef
544           without the const modifier, hence its use in the const_cast<>
545           above.
546
547 2018-01-08  David Kilzer  <ddkilzer@apple.com>
548
549         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
550         <https://webkit.org/b/181256>
551         <rdar://problem/36281730>
552
553         * Carbon/HIWebView.mm:
554         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
555         checked_cf_cast<CFRunLoopRef>() to fix warning.
556
557 2018-01-07  David Kilzer  <ddkilzer@apple.com>
558
559         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
560         <https://webkit.org/b/181256>
561         <rdar://problem/36281730>
562
563         Reviewed by Darin Adler.
564
565         * Carbon/CarbonUtils.m:
566         (PoolCleaner):
567         - Use #pragmas to ignore -Wcast-qual warnings when using a
568           C-style cast from CFTypeRef to CFRunloopRef.
569         * Carbon/CarbonWindowFrame.m:
570         (-[CarbonWindowFrame title]):
571         - Use #pragmas to ignore -Wcast-qual warnings when using a
572           C-style cast from CFStringRef to NSString *.
573         * Carbon/HIViewAdapter.m:
574         (+[HIViewAdapter getHIViewForNSView:]):
575         - Use #pragmas to ignore -Wcast-qual warnings when using a
576           C-style cast from CFTypeRef to HIViewRef.
577         * Configurations/Base.xcconfig:
578         (WARNING_CFLAGS): Add -Wcast-qual.
579         * Misc/WebElementDictionary.mm:
580         (-[WebElementDictionary objectForKey:]):
581         - Use static_cast<SEL>(const_cast<void*>()) to fix
582           warning.
583         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
584         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
585         (-[NSData _webkit_guessedMIMETypeForXML]):
586         (-[NSData _webkit_guessedMIMEType]):
587         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
588         (_findEOL):
589         (-[NSData _webkit_parseRFC822HeaderFields]):
590         (-[NSData _web_startsWithBlankLine]):
591         (-[NSData _web_locationAfterFirstBlankLine]):
592         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
593           type to Objective-C++.  This fixes the warnings about
594           discarding the `const` modifier when casing from CFStringRef
595           to NSString * because in older clang versions, -Wcast-qual was
596           completely broken when compiling C++ and Objective-C++ source
597           files.  In newer clang versions, discarding the `const`
598           modifier for toll-free bridged types is ignored when compiling
599           Objective-C++ source.
600         - Update copyright and license header.
601         - Use reinterpret_cast<> and static_cast<> to fix warnings
602           unrelated to (NSString *) C-style casts.
603         - Replace use of MIN() macro with std::min<> template functions.
604         - Fix location of `*` for local variables modified above.
605         * Plugins/Hosted/NetscapePluginHostManager.mm:
606         (WebKit::NetscapePluginHostManager::spawnPluginHost):
607         (WebKit::NetscapePluginHostManager::initializeVendorPort):
608         (WebKit::NetscapePluginHostManager::instantiatePlugin):
609         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
610           warnings.
611         * Plugins/Hosted/NetscapePluginHostProxy.mm:
612         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
613         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
614           to fix warning.
615         * Plugins/Hosted/ProxyInstance.mm:
616         (WebKit::ProxyInstance::invoke):
617         - Use static_cast<char*>(const_cast<void*>()) to fix
618           warning when using -[NSData bytes].
619         (WebKit::ProxyInstance::fieldValue const):
620         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
621           to fix warning when using CFDataGetBytePtr().
622         * Plugins/Hosted/WebTextInputWindowController.m:
623         (-[WebTextInputPanel _interpretKeyEvent:string:]):
624         - Use #pragma to ignore -Wcast-qual warning since there
625           is not a good way to avoid this warning in Objective-C.
626         * Plugins/WebNetscapePluginStream.mm:
627         (WebNetscapePluginStream::deliverData):
628         - Use const_cast<void*>() to fix warning when using
629           -[NSData bytes].
630         * Plugins/WebNetscapePluginView.mm:
631         (-[WebNetscapePluginView _createPlugin]):
632         - Change C-style cast to const_cast<char*>() to fix
633           warning.
634         * WebCoreSupport/WebChromeClient.mm:
635         (WebChromeClient::wrapCryptoKey const):
636         (WebChromeClient::unwrapCryptoKey const):
637         - Change C-style cast to
638           static_cast<uint8_t*>(const_cast<void*>() to fix
639           warning.
640         * WebView/WebPDFView.mm:
641         (_applicationInfoForMIMEType):
642         - Change local variable type from 'NSURL *' to
643           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
644           when calling -[NSURL path].
645
646 2018-01-05  Dan Bernstein  <mitz@apple.com>
647
648         Fixed the build following AppKit API deprecations in a recent SDKs
649
650         * WebView/WebFullScreenController.mm:
651         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
652         (-[WebFullScreenController exitFullScreen]): Ditto.
653         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
654         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
655         * WebView/WebHTMLView.mm:
656         (-[WebHTMLView drawRect:]): Ditto.
657         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
658         (-[WebHTMLView knowsPageRange:]): Ditto.
659         * WebView/WebView.mm:
660         (LayerFlushController::flushLayers): Ditto.
661
662 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
663
664         [Attachment Support] Create attachment elements when dropping files on iOS
665         https://bugs.webkit.org/show_bug.cgi?id=181192
666         <rdar://problem/36280945>
667
668         Reviewed by Tim Horton.
669
670         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
671
672         * WebCoreSupport/WebPlatformStrategies.h:
673         * WebCoreSupport/WebPlatformStrategies.mm:
674         (WebPlatformStrategies::informationForItemAtIndex):
675         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
676
677 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
678
679         [Attachment Support] Add plumbing for starting a drag with promised blob data
680         https://bugs.webkit.org/show_bug.cgi?id=181201
681
682         Reviewed by Tim Horton.
683
684         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
685
686         * WebCoreSupport/WebDragClient.h:
687
688 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
689
690         Add a WebAuthentication runtime feature flag
691         https://bugs.webkit.org/show_bug.cgi?id=181220
692         <rdar://problem/36055305>
693
694         Reviewed by Brent Fulgham.
695
696         Renames the CredentialManagement runtime feature flag into WebAuthentication.
697
698         * WebView/WebPreferenceKeysPrivate.h:
699         * WebView/WebPreferences.mm:
700         (+[WebPreferences initialize]):
701         (-[WebPreferences webAuthenticationEnabled]):
702         (-[WebPreferences setWebAuthenticationEnabled:]):
703         (-[WebPreferences credentialManagementEnabled]): Deleted.
704         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
705         * WebView/WebPreferencesPrivate.h:
706         * WebView/WebView.mm:
707         (-[WebView _preferencesChanged:]):
708
709 2017-12-22  Jeff Miller  <jeffm@apple.com>
710
711         Update user-visible copyright strings to include 2018
712         https://bugs.webkit.org/show_bug.cgi?id=181141
713
714         Reviewed by Dan Bernstein.
715
716         * Info.plist:
717
718 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
719
720         [Attachment Support] Remove current macOS support for dragging file-backed attachments
721         https://bugs.webkit.org/show_bug.cgi?id=181188
722
723         Reviewed by Dan Bernstein.
724
725         See WebCore/ChangeLog for more detail.
726
727         * WebCoreSupport/WebDragClient.h:
728         * WebCoreSupport/WebDragClient.mm:
729         (WebDragClient::declareAndWriteAttachment): Deleted.
730         * WebView/WebHTMLView.mm:
731         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
732
733 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
734
735         Unreviewed, continue to fix build failures due to AppKit API deprecation
736
737         Wraps more code in -Wdeprecated-declarations.
738
739         * Carbon/HIWebView.mm:
740         (overrideCGContext):
741
742 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
743
744         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
745
746         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
747
748         * Carbon/CarbonWindowAdapter.mm:
749         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
750         * Plugins/WebNetscapePluginView.mm:
751         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
752         (-[WebNetscapePluginView sendDrawRectEvent:]):
753         (-[WebNetscapePluginView drawRect:]):
754
755 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
756
757         Fix build failures due to using deprecated AppKit symbols
758         https://bugs.webkit.org/show_bug.cgi?id=181110
759         <rdar://problem/36162865>
760
761         Reviewed by Dan Bernstein and Tim Horton.
762
763         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
764
765         * Misc/WebKitNSStringExtras.mm:
766         (-[NSString _web_drawAtPoint:font:textColor:]):
767         * Misc/WebNSPasteboardExtras.h:
768         * Misc/WebNSPasteboardExtras.mm:
769         (+[NSPasteboard _web_writableTypesForURL]):
770         (_createWritableTypesForImageWithoutArchive):
771         (_createWritableTypesForImageWithArchive):
772         (+[NSPasteboard _web_dragTypesForURL]):
773         (-[NSPasteboard _web_bestURL]):
774         (-[NSPasteboard _web_writeURL:andTitle:types:]):
775         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
776         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
777         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
778         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
779         * Panels/WebAuthenticationPanel.m:
780         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
781         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
782         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
783         (-[WebHostedNetscapePluginView drawRect:]):
784         * WebInspector/WebNodeHighlightView.mm:
785         (-[WebNodeHighlightView drawRect:]):
786         * WebView/WebFrame.mm:
787         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
788         (-[WebFrame _drawRect:contentsOnly:]):
789         * WebView/WebHTMLView.mm:
790         (kit):
791         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
792         (-[WebHTMLView _plainTextFromPasteboard:]):
793         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
794         (+[WebHTMLView _insertablePasteboardTypes]):
795         (+[WebHTMLView _selectionPasteboardTypes]):
796         (-[WebHTMLView pasteboard:provideDataForType:]):
797         (-[WebHTMLView _writeSelectionToPasteboard:]):
798         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
799         (-[WebHTMLView validRequestorForSendType:returnType:]):
800         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
801         (createMenuItem):
802         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
803         (-[WebHTMLView _colorAsString:]):
804         (-[WebHTMLView copyFont:]):
805         * WebView/WebPDFView.mm:
806         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
807         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
808         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
809         (-[WebPDFView pasteboardTypesForSelection]):
810         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
811         * WebView/WebView.h:
812         * WebView/WebView.mm:
813         (-[WebView performDragOperation:]):
814         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
815         (-[WebView _searchWithGoogleFromMenu:]):
816
817 2017-12-21  Youenn Fablet  <youenn@apple.com>
818
819         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
820         https://bugs.webkit.org/show_bug.cgi?id=181000
821
822         Reviewed by Chris Dumez.
823
824         * Misc/WebCache.mm:
825         (+[WebCache addImageToCache:forURL:forFrame:]):
826
827 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
828
829         Update FULLSCREEN_API feature defines.
830         https://bugs.webkit.org/show_bug.cgi?id=181015
831
832         Reviewed by Tim Horton.
833
834         Change enabled iphone sdk for FULLSCREEN_API.
835
836         * Configurations/FeatureDefines.xcconfig:
837
838 2017-12-21  Jer Noble  <jer.noble@apple.com>
839
840         Add initial DOM support for Media Capabilities
841         https://bugs.webkit.org/show_bug.cgi?id=181064
842
843         Reviewed by Eric Carlson.
844
845         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
846
847         * WebView/WebPreferenceKeysPrivate.h:
848         * WebView/WebPreferences.mm:
849         (+[WebPreferences initialize]):
850         (-[WebPreferences mediaCapabilitiesEnabled]):
851         (-[WebPreferences setMediaCapabilitiesEnabled:]):
852         * WebView/WebPreferencesPrivate.h:
853         * WebView/WebView.mm:
854         (-[WebView _preferencesChanged:]):
855
856 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
857
858         Enable picture-in-picture from inline element on suspend.
859         https://bugs.webkit.org/show_bug.cgi?id=180942
860         rdar://problem/34745234
861
862         Reviewed by Jer Noble.
863
864         Update signature of enterVideoFullscreenForVideoElement().
865
866         * WebCoreSupport/WebChromeClient.h:
867         * WebCoreSupport/WebChromeClient.mm:
868         (WebChromeClient::enterVideoFullscreenForVideoElement):
869
870 2017-12-20  Daniel Bates  <dabates@apple.com>
871
872         Remove Alternative Presentation Button
873         https://bugs.webkit.org/show_bug.cgi?id=180500
874         <rdar://problem/35891047>
875
876         Reviewed by Simon Fraser.
877
878         We no longer need the alternative presentation button.
879
880         * Configurations/FeatureDefines.xcconfig:
881
882 2017-12-19  Jer Noble  <jer.noble@apple.com>
883
884         Playing media elements which call "pause(); play()" will have the play promise rejected.
885         https://bugs.webkit.org/show_bug.cgi?id=180781
886         <rdar://problem/33191377>
887
888         Reviewed by Eric Carlson.
889
890         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
891
892         * WebView/WebView.mm:
893         (shouldRequireUserGestureToLoadVideo):
894
895 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
896
897         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
898         https://bugs.webkit.org/show_bug.cgi?id=180977
899
900         Reviewed by Tim Horton.
901
902         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
903         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
904         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
905
906         * WebCoreSupport/WebEditorClient.mm:
907         (attributesForAttributedStringConversion):
908         * WebView/WebHTMLView.mm:
909         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
910
911 2017-12-18  David Kilzer  <ddkilzer@apple.com>
912
913         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
914
915         Attempt to fix the following warnings:
916
917             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
918
919         For the following instance variables:
920
921             _borderView
922             _contentView
923             _frame
924             _wFlags
925
926         * Carbon/CarbonWindowAdapter.mm:
927         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
928         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
929         (-[CarbonWindowAdapter _termWindowIfOwner]):
930         (-[CarbonWindowAdapter _windowMovedToRect:]):
931         (-[CarbonWindowAdapter setContentView:]):
932         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
933         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
934
935 2017-12-16  Dan Bernstein  <mitz@apple.com>
936
937         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
938         https://bugs.webkit.org/show_bug.cgi?id=180613
939         <rdar://problem/35946124>
940
941         Reviewed by Geoff Garen.
942
943         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
944           clients.
945         * WebView/WebDynamicScrollBarsView.h: Ditto.
946         * WebView/WebDynamicScrollBarsView.mm: Ditto.
947
948 2017-12-14  David Kilzer  <ddkilzer@apple.com>
949
950         Enable -Wstrict-prototypes for WebKit
951         <https://webkit.org/b/180757>
952         <rdar://problem/36024132>
953
954         Rubber-stamped by Joseph Pecoraro.
955
956         * Configurations/Base.xcconfig:
957         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
958
959 2017-12-14  John Wilander  <wilander@apple.com>
960
961         Storage Access API: Implement frame-specific access in the document.cookie layer
962         https://bugs.webkit.org/show_bug.cgi?id=180682
963         <rdar://problem/35982257>
964
965         Reviewed by Alex Christensen.
966
967         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
968         CookiesStrategy::cookieRequestHeaderFieldValue(), and
969         CookiesStrategy::getRawCookies() now take optional parameters for
970         frameID and pageID to allow frame-specific scoping of cookies.
971
972         This change makes the return values of FrameLoaderClient::frameID()
973         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
974         WebCore can call those getters and get the right return values in
975         WebKit and std:nullopt in WebKitLegacy.
976
977         * WebCoreSupport/WebFrameLoaderClient.h:
978         * WebCoreSupport/WebFrameLoaderClient.mm:
979         (WebFrameLoaderClient::pageID const):
980         (WebFrameLoaderClient::frameID const):
981         * WebCoreSupport/WebPlatformStrategies.h:
982         * WebCoreSupport/WebPlatformStrategies.mm:
983         (WebPlatformStrategies::cookiesForDOM):
984         (WebPlatformStrategies::setCookiesFromDOM):
985         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
986         (WebPlatformStrategies::getRawCookies):
987
988 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
989
990         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
991         https://bugs.webkit.org/show_bug.cgi?id=180689
992
993         Reviewed by Tim Horton.
994
995         Use sRGBColorSpaceRef() from WebCore.
996
997         * WebView/WebHTMLView.mm:
998         (imageFromRect):
999
1000 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1001
1002         Stop using deprecated target conditional for simulator builds
1003         https://bugs.webkit.org/show_bug.cgi?id=180662
1004         <rdar://problem/35136156>
1005
1006         Reviewed by Simon Fraser.
1007
1008         * postprocess-headers.sh:
1009
1010 2017-12-11  David Quesada  <david_quesada@apple.com>
1011
1012         Turn on ENABLE_APPLICATION_MANIFEST
1013         https://bugs.webkit.org/show_bug.cgi?id=180562
1014         rdar://problem/35924737
1015
1016         Reviewed by Geoffrey Garen.
1017
1018         * Configurations/FeatureDefines.xcconfig:
1019
1020 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1021
1022         Remove pthread_once in favor of dispatch_once
1023         https://bugs.webkit.org/show_bug.cgi?id=180591
1024
1025         Reviewed by Saam Barati.
1026
1027         * Misc/WebKitErrors.m:
1028         (+[NSError _registerWebKitErrors]):
1029         (registerErrors): Deleted.
1030         * Storage/WebStorageManager.mm:
1031         (+[WebStorageManager _storageDirectoryPath]):
1032         (initializeLocalStoragePath): Deleted.
1033
1034 2017-12-07  Darin Adler  <darin@apple.com>
1035
1036         Remove some unused code from WebKitLegacy
1037         https://bugs.webkit.org/show_bug.cgi?id=180567
1038
1039         Reviewed by Anders Carlsson.
1040
1041         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1042         macOS (back a few versions) and iOS and removed unused
1043         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1044         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1045         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1046         _webkit_stringByCollapsingNonPrintingCharacters,
1047         _webkit_stringByCollapsingWhitespaceCharacters,
1048         _web_stringWithData:textEncodingName:, and
1049         _webkit_localStorageDirectoryWithBundleIdentifier:.
1050
1051         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1052         this source file.
1053         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1054         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1055         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1056         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1057         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1058         handle font smoothing options.
1059         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1060         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1061         from header and made it a little clearer.
1062         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1063         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1064         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1065         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1066         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1067         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1068         implementation a bit and used whole words instead of abbreviations.
1069         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1070
1071         * Misc/WebNSFileManagerExtras.mm:
1072         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1073         filenameByFixingIllegalCharacters function from WebCore directly instead of
1074         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1075
1076         * Plugins/WebBaseNetscapePluginView.mm:
1077         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1078         string replacements instead of _web_stringByStrippingReturnCharacters
1079         and to use NSString methods instead of CFString functions.
1080
1081 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1082
1083         Ignore deprecation warnings.
1084
1085         * WebView/WebHTMLView.mm:
1086         (-[NSWindow _web_borderView]):
1087         (-[WebHTMLView _setAsideSubviews]):
1088         * WebView/WebView.mm:
1089         (-[WebView encodeWithCoder:]):
1090
1091 2017-12-02  Darin Adler  <darin@apple.com>
1092
1093         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1094         https://bugs.webkit.org/show_bug.cgi?id=180009
1095
1096         Reviewed by Alex Christensen.
1097
1098         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1099
1100         * Plugins/WebBaseNetscapePluginView.mm:
1101         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1102         of strcasecmp.
1103
1104         * WebView/WebPreferences.mm:
1105         (contains): Ditto. Also made this a template so it's easier to call on an array.
1106         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1107
1108 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1109
1110         Limit user agent versioning to an upper bound
1111         https://bugs.webkit.org/show_bug.cgi?id=180365
1112         <rdar://problem/34550617>
1113
1114         Reviewed by Joseph Pecoraro.
1115
1116         * WebView/WebView.mm:
1117         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1118         creating the User Agent string.
1119         (webKitBundleVersionString): Deleted.
1120
1121 2017-12-05  Andy Estes  <aestes@apple.com>
1122
1123         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1124         https://bugs.webkit.org/show_bug.cgi?id=180457
1125         <rdar://problem/35143007>
1126
1127         Reviewed by Tim Horton.
1128
1129         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1130         check for this macro during post-processing.
1131
1132         * postprocess-headers.sh:
1133
1134 2017-12-04  David Quesada  <david_quesada@apple.com>
1135
1136         Add a class for parsing application manifests
1137         https://bugs.webkit.org/show_bug.cgi?id=177973
1138         rdar://problem/34747949
1139
1140         Reviewed by Geoffrey Garen.
1141
1142         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1143
1144 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1145
1146         Make LegacyCustomProtocolManager optional for network process
1147         https://bugs.webkit.org/show_bug.cgi?id=176230
1148
1149         Reviewed by Alex Christensen.
1150
1151         * Configurations/FeatureDefines.xcconfig:
1152
1153 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1154
1155         Fix some NSOperationQueue leaks
1156         https://bugs.webkit.org/show_bug.cgi?id=180221
1157
1158         Reviewed by Wenson Hsieh.
1159
1160         * WebView/WebView.mm:
1161         (-[WebView performDragOperation:]):
1162
1163 2017-11-30  Darin Adler  <darin@apple.com>
1164
1165         [Mac] remove unneeded RetainPtr use introduced in r225142
1166         https://bugs.webkit.org/show_bug.cgi?id=180202
1167
1168         Reviewed by Tim Horton.
1169
1170         * WebView/WebImmediateActionController.mm:
1171         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1172         RetainPtr.
1173
1174 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1175
1176         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1177         https://bugs.webkit.org/show_bug.cgi?id=175595
1178
1179         Reviewed by Darin Adler.
1180
1181         * WebView/WebPreferences.mm:
1182
1183 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1184
1185         One too many zeroes in macOS version number in FeatureDefines
1186         https://bugs.webkit.org/show_bug.cgi?id=180011
1187
1188         Reviewed by Dan Bernstein.
1189
1190         * Configurations/FeatureDefines.xcconfig:
1191
1192 2017-11-23  Darin Adler  <darin@apple.com>
1193
1194         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1195         https://bugs.webkit.org/show_bug.cgi?id=179981
1196
1197         Reviewed by Sam Weinig.
1198
1199         * WebView/WebImmediateActionController.mm:
1200         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1201         * WebView/WebView.mm:
1202         (coreOptions): Use |= instead of | to build up FindOptions.
1203
1204 2017-11-23  Sam Weinig  <sam@webkit.org>
1205
1206         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1207         https://bugs.webkit.org/show_bug.cgi?id=179954
1208
1209         Reviewed by Darin Adler.
1210
1211         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1212         with direct calls to the corresponding UserGestureIndicator functions.
1213
1214         * Plugins/WebPluginController.mm:
1215         (-[WebPluginController processingUserGesture]):
1216         * WebView/WebView.mm:
1217         (-[WebView _isProcessingUserGesture]):
1218
1219 2017-11-23  Darin Adler  <darin@apple.com>
1220
1221         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1222         https://bugs.webkit.org/show_bug.cgi?id=179907
1223
1224         Reviewed by Sam Weinig.
1225
1226         * History/BinaryPropertyList.cpp:
1227         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1228         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1229         * WebView/WebHTMLRepresentation.mm:
1230         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1231         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1232
1233 2017-11-22  Ali Juma  <ajuma@chromium.org>
1234
1235         Implement VisualViewport API attributes
1236         https://bugs.webkit.org/show_bug.cgi?id=179385
1237
1238         Reviewed by Frédéric Wang.
1239
1240         Add a VisualViewportAPI preference.
1241
1242         * WebView/WebPreferenceKeysPrivate.h:
1243         * WebView/WebPreferences.mm:
1244         (+[WebPreferences initialize]):
1245         (-[WebPreferences visualViewportAPIEnabled]):
1246         (-[WebPreferences setVisualViewportAPIEnabled:]):
1247         * WebView/WebPreferencesPrivate.h:
1248         * WebView/WebView.mm:
1249         (-[WebView _preferencesChanged:]):
1250
1251 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1252
1253         WebCoreObjCExtras.h is being included in too many places
1254         https://bugs.webkit.org/show_bug.cgi?id=179931
1255
1256         Reviewed by Darin Adler.
1257
1258         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1259         * Plugins/WebBaseNetscapePluginView.mm:
1260         * Plugins/WebBasePluginPackage.mm:
1261         * Plugins/WebNetscapePluginStream.mm:
1262         * Plugins/WebNetscapePluginView.mm:
1263         * WebView/WebTextIterator.mm:
1264         * WebView/WebViewData.mm:
1265
1266 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1267
1268         Unreviewed, rolling out r225093.
1269         https://bugs.webkit.org/show_bug.cgi?id=179938
1270
1271         Compilation failed on WinCairo 64-bit Release (Requested by
1272         fredw on #webkit).
1273
1274         Reverted changeset:
1275
1276         "Implement VisualViewport API attributes"
1277         https://bugs.webkit.org/show_bug.cgi?id=179385
1278         https://trac.webkit.org/changeset/225093
1279
1280 2017-11-21  Ali Juma  <ajuma@chromium.org>
1281
1282         Implement VisualViewport API attributes
1283         https://bugs.webkit.org/show_bug.cgi?id=179385
1284
1285         Reviewed by Frédéric Wang.
1286
1287         Add a VisualViewportAPI preference.
1288
1289         * WebView/WebPreferenceKeysPrivate.h:
1290         * WebView/WebPreferences.mm:
1291         (+[WebPreferences initialize]):
1292         (-[WebPreferences visualViewportAPIEnabled]):
1293         (-[WebPreferences setVisualViewportAPIEnabled:]):
1294         * WebView/WebPreferencesPrivate.h:
1295         * WebView/WebView.mm:
1296         (-[WebView _preferencesChanged:]):
1297
1298 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1299
1300         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1301         https://bugs.webkit.org/show_bug.cgi?id=179504
1302
1303         Reviewed by Darin Adler.
1304
1305         * Misc/WebKitNSStringExtras.mm:
1306         * Plugins/Hosted/NetscapePluginHostManager.mm:
1307         * Plugins/WebBasePluginPackage.mm:
1308
1309 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1310
1311         Remove unused TOUCH_ICON_LOADING feature flag
1312         https://bugs.webkit.org/show_bug.cgi?id=179873
1313
1314         Reviewed by Simon Fraser.
1315
1316         * Configurations/FeatureDefines.xcconfig:
1317
1318 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1319
1320         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1321         https://bugs.webkit.org/show_bug.cgi?id=179872
1322
1323         Reviewed by Darin Adler.
1324
1325         * Configurations/FeatureDefines.xcconfig:
1326
1327 2017-11-16  Daniel Bates  <dabates@apple.com>
1328
1329         Add feature define for alternative presentation button element
1330         https://bugs.webkit.org/show_bug.cgi?id=179692
1331         Part of <rdar://problem/34917108>
1332
1333         Reviewed by Andy Estes.
1334
1335         Only enabled on Cocoa platforms by default.
1336
1337         * Configurations/FeatureDefines.xcconfig:
1338
1339 2017-11-14  Nan Wang  <n_wang@apple.com>
1340
1341         AX: AOM: Implement AccessibleNode class and support label and role attributes
1342         https://bugs.webkit.org/show_bug.cgi?id=179494
1343
1344         Reviewed by Ryosuke Niwa.
1345
1346         * WebView/WebPreferenceKeysPrivate.h:
1347         * WebView/WebPreferences.mm:
1348         (+[WebPreferences initialize]):
1349         (-[WebPreferences accessibilityObjectModelEnabled]):
1350         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1351         * WebView/WebPreferencesPrivate.h:
1352         * WebView/WebView.mm:
1353         (-[WebView _preferencesChanged:]):
1354
1355 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1356
1357         Remove Cocoa CFURLConnection loading code
1358         https://bugs.webkit.org/show_bug.cgi?id=179688
1359
1360         Reviewed by Antti Koivisto.
1361
1362         * Misc/WebDownload.mm:
1363         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1364         * Misc/WebDownloadInternal.h:
1365         * Plugins/WebBaseNetscapePluginView.mm:
1366         * WebCoreSupport/WebFrameLoaderClient.mm:
1367         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1368         * WebView/WebView.mm:
1369         (-[WebView scheduleInRunLoop:forMode:]):
1370         (-[WebView unscheduleFromRunLoop:forMode:]):
1371
1372 2017-11-14  Daniel Bates  <dabates@apple.com>
1373
1374         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1375         for feature defines
1376
1377         Following r195498 and r201917 the Visual Studio property files for feature defines have
1378         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1379         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1380         files.
1381
1382         * Configurations/FeatureDefines.xcconfig:
1383
1384 2017-11-14  Jer Noble  <jer.noble@apple.com>
1385
1386         Enable Modern EME tests in DumpRenderTree
1387         https://bugs.webkit.org/show_bug.cgi?id=179544
1388
1389         Reviewed by Alex Christensen.
1390
1391         Add a WebPreferences property to enable the (modern) EME API.
1392
1393         * WebView/WebPreferenceKeysPrivate.h:
1394         * WebView/WebPreferences.mm:
1395         (+[WebPreferences initialize]):
1396         (-[WebPreferences encryptedMediaAPIEnabled]):
1397         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1398         * WebView/WebPreferencesPrivate.h:
1399         * WebView/WebView.mm:
1400         (-[WebView _preferencesChanged:]):
1401
1402 2017-11-14  Antti Koivisto  <antti@apple.com>
1403
1404         Enable display:contents by default
1405         https://bugs.webkit.org/show_bug.cgi?id=179655
1406
1407         Reviewed by Sam Weinig.
1408
1409         * WebView/WebPreferences.mm:
1410         (+[WebPreferences initialize]):
1411
1412 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1413
1414         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1415         https://bugs.webkit.org/show_bug.cgi?id=178751
1416
1417         Reviewed by Brady Eidson.
1418
1419         * WebCoreSupport/WebFrameNetworkingContext.mm:
1420         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1421
1422 2017-11-08  Keith Miller  <keith_miller@apple.com>
1423
1424         Async iteration should only fetch the next method once and add feature flag
1425         https://bugs.webkit.org/show_bug.cgi?id=179451
1426
1427         Reviewed by Geoffrey Garen.
1428
1429         Add feature flag for Async iteration.
1430
1431         * Configurations/FeatureDefines.xcconfig:
1432
1433 2017-11-13  Mark Lam  <mark.lam@apple.com>
1434
1435         Add more overflow check book-keeping for MarkedArgumentBuffer.
1436         https://bugs.webkit.org/show_bug.cgi?id=179634
1437         <rdar://problem/35492517>
1438
1439         Reviewed by Saam Barati.
1440
1441         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1442         (WebKit::NetscapePluginInstanceProxy::invoke):
1443         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1444         (WebKit::NetscapePluginInstanceProxy::construct):
1445
1446 2017-11-12  Darin Adler  <darin@apple.com>
1447
1448         More is<> and downcast<>, less static_cast<>
1449         https://bugs.webkit.org/show_bug.cgi?id=179600
1450
1451         Reviewed by Chris Dumez.
1452
1453         * DOM/DOM.mm:
1454         (kit): Use is/downcast.
1455         * WebCoreSupport/WebEditorClient.mm:
1456         (WebEditorClient::handleKeyboardEvent): Ditto.
1457         (WebEditorClient::handleInputMethodKeydown): Ditto.
1458         * WebView/WebHTMLView.mm:
1459         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1460
1461 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1462
1463         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1464         https://bugs.webkit.org/show_bug.cgi?id=179397
1465
1466         Reviewed by Wenson Hsieh.
1467
1468         * DOM/DOMHTMLInputElement.mm:
1469         (-[DOMHTMLInputElement insertTextSuggestion:]):
1470
1471 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1472
1473         HTMLMediaElement should not use element fullscreen on iOS
1474         https://bugs.webkit.org/show_bug.cgi?id=179418
1475         rdar://problem/35409277
1476
1477         Reviewed by Eric Carlson.
1478
1479         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1480
1481         * Configurations/FeatureDefines.xcconfig:
1482
1483 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1484
1485         Make ResourceLoader::willSendRequestInternal asynchronous
1486         https://bugs.webkit.org/show_bug.cgi?id=179251
1487
1488         Reviewed by Andy Estes.
1489
1490         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1491         (WebKit::HostedNetscapePluginStream::start):
1492         * Plugins/WebNetscapePluginStream.mm:
1493         (WebNetscapePluginStream::start):
1494
1495 2017-11-01  Darin Adler  <darin@apple.com>
1496
1497         Simplify event dispatch code and make it a bit more consistent
1498         https://bugs.webkit.org/show_bug.cgi?id=178991
1499
1500         Reviewed by Chris Dumez.
1501
1502         * DOM/DOMEvent.mm:
1503         (-[DOMEvent srcElement]): Call target instead of srcElement.
1504
1505 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1506
1507         [Touch Bar Web API] Add support for menuitem tag
1508         https://bugs.webkit.org/show_bug.cgi?id=179020
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         Adds in properties and methods that allow the menuitem runtime feature
1513         to be enabled or disabled.
1514
1515         * WebView/WebPreferenceKeysPrivate.h:
1516         * WebView/WebPreferences.mm:
1517         (-[WebPreferences menuItemElementEnabled]):
1518         (-[WebPreferences setMenuItemElementEnabled:]):
1519         * WebView/WebPreferencesPrivate.h:
1520         * WebView/WebView.mm:
1521         (-[WebView _preferencesChanged:]):
1522
1523 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1524
1525         Use CompletionHandlers for redirects
1526         https://bugs.webkit.org/show_bug.cgi?id=179163
1527
1528         Reviewed by Tim Horton.
1529
1530         * Plugins/Hosted/HostedNetscapePluginStream.h:
1531         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1532         (WebKit::HostedNetscapePluginStream::willSendRequest):
1533         * Plugins/WebNetscapePluginStream.h:
1534         * Plugins/WebNetscapePluginStream.mm:
1535         (WebNetscapePluginStream::willSendRequest):
1536
1537 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1538
1539         Add a FileSystem namespace to FileSystem.cpp
1540         https://bugs.webkit.org/show_bug.cgi?id=179063
1541
1542         Reviewed by Darin Adler.
1543
1544         * Misc/WebNSFileManagerExtras.mm:
1545         * Storage/WebDatabaseProvider.mm:
1546
1547 2017-11-02  Frederic Wang  <fwang@igalia.com>
1548
1549         Add references to bug 179167 in FIXME comments
1550         https://bugs.webkit.org/show_bug.cgi?id=179168
1551
1552         Reviewed by Daniel Bates.
1553
1554         * Configurations/FeatureDefines.xcconfig:
1555
1556 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1557
1558         Implement WKFullscreenWindowController for iOS.
1559         https://bugs.webkit.org/show_bug.cgi?id=178924
1560         rdar://problem/34697120
1561
1562         Reviewed by Simon Fraser.
1563
1564         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1565
1566         * Configurations/FeatureDefines.xcconfig:
1567         * WebView/WebView.mm:
1568         (-[WebView fullScreenPlaceholderView]):
1569
1570 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1571
1572         Clean up some drag and drop feature flags
1573         https://bugs.webkit.org/show_bug.cgi?id=179082
1574
1575         Reviewed by Simon Fraser.
1576
1577         * Configurations/FeatureDefines.xcconfig:
1578
1579 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1580
1581         Make it possible to test rubber-banding in overflow scroll
1582         https://bugs.webkit.org/show_bug.cgi?id=179078
1583
1584         Reviewed by Sam Weinig.
1585
1586         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1587         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1588
1589         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1590         functions, since most callers want clamped.
1591
1592         * DOM/DOMHTML.mm:
1593         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1594
1595 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1596
1597         Fix up some content filtering feature flags
1598         https://bugs.webkit.org/show_bug.cgi?id=179079
1599
1600         Reviewed by Simon Fraser.
1601
1602         * Configurations/FeatureDefines.xcconfig:
1603
1604 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1605
1606         [FrameView::layout cleanup] Move core layout logic to a separate class.
1607         https://bugs.webkit.org/show_bug.cgi?id=178771
1608         <rdar://problem/35166542>
1609
1610         Reviewed by Simon Fraser.
1611
1612         Move layout code out from FrameView to LayoutContext.
1613
1614         * WebView/WebClipView.mm:
1615         (-[WebClipView _immediateScrollToPoint:]):
1616         * WebView/WebFrame.mm:
1617         (-[WebFrame layoutCount]):
1618
1619 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1620
1621         Fix issues with WebView subframe painting
1622         https://bugs.webkit.org/show_bug.cgi?id=178842
1623         rdar://problem/34072253
1624
1625         Reviewed by Daniel Bates.
1626         
1627         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1628         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1629         High Sierra, so match the new signature.
1630
1631         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1632
1633         * WebView/WebHTMLView.mm:
1634         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1635         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1636
1637 2017-10-25  Youenn Fablet  <youenn@apple.com>
1638
1639         Enable ServiceWorker to fetch resources
1640         https://bugs.webkit.org/show_bug.cgi?id=178673
1641
1642         Reviewed by Brady Eidson.
1643
1644         * WebCoreSupport/WebFrameLoaderClient.mm:
1645         (WebFrameLoaderClient::pageID const):
1646         (WebFrameLoaderClient::frameID const):
1647         (WebFrameLoaderClient::sessionID const):
1648
1649         Added implementation to the new getters.
1650         They are noop in the context of WK1.
1651
1652 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1653
1654         Web Inspector: Enable WebKit logging configuration and display
1655         https://bugs.webkit.org/show_bug.cgi?id=177027
1656         <rdar://problem/33964767>
1657
1658         Reviewed by Joseph Pecoraro.
1659
1660         * WebCoreSupport/WebChromeClient.mm:
1661         (stringForMessageSource): Deal with Media and WebRTC message sources.
1662
1663 2017-10-20  Antoine Quint  <graouts@apple.com>
1664
1665         [Web Animations] Provide basic timeline and animation interfaces
1666         https://bugs.webkit.org/show_bug.cgi?id=178526
1667
1668         Reviewed by Dean Jackson.
1669
1670         Remove the WEB_ANIMATIONS compile-time flag.
1671
1672         * Configurations/FeatureDefines.xcconfig:
1673         * WebView/WebPreferences.mm:
1674         (+[WebPreferences initialize]):
1675         * WebView/WebView.mm:
1676         (-[WebView _preferencesChanged:]):
1677
1678 2017-10-19  Sam Weinig  <sam@webkit.org>
1679
1680         [Settings] Move global settings into their own file
1681         https://bugs.webkit.org/show_bug.cgi?id=178512
1682
1683         Reviewed by Darin Adler.
1684
1685         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1686
1687         * WebCoreSupport/WebChromeClient.mm:
1688         (WebChromeClient::supportsVideoFullscreen):
1689         * WebView/WebDynamicScrollBarsView.mm:
1690         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1691         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1692         * WebView/WebPreferences.mm:
1693         (+[WebPreferences initialize]):
1694         * WebView/WebView.mm:
1695         (-[WebView _commonInitializationWithFrameName:groupName:]):
1696         (-[WebView _preferencesChanged:]):
1697         (+[WebView _doNotStartObservingNetworkReachability]):
1698
1699 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1700
1701         Replace some stack raw pointers with RefPtrs within WebCore/html
1702         https://bugs.webkit.org/show_bug.cgi?id=178201
1703         <rdar://problem/34841692>
1704
1705         Reviewed by Ryosuke Niwa.
1706
1707         * DOM/DOM.mm:
1708         (kit):
1709         Change the type of node as toNode() is changed to return RefPtr.
1710
1711 2017-10-18  Chris Dumez  <cdumez@apple.com>
1712
1713         [Service Worker] Add stubs for Client / WindowClient / Clients
1714         https://bugs.webkit.org/show_bug.cgi?id=178469
1715
1716         Reviewed by Youenn Fablet.
1717
1718         Rename PageVisiblityState to VisibilityState.
1719
1720         * WebView/WebView.mm:
1721         (kit):
1722
1723 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1724
1725         Unreviewed, rolling out r223291.
1726
1727         See WebCore ChangeLog for more detail.
1728
1729         Reverted changeset:
1730
1731         "Remove Editor::simplifyMarkup"
1732         https://bugs.webkit.org/show_bug.cgi?id=178271
1733         https://trac.webkit.org/changeset/223291
1734
1735 2017-10-17  Keith Miller  <keith_miller@apple.com>
1736
1737         Change WebCore sources to work with unified source builds
1738         https://bugs.webkit.org/show_bug.cgi?id=178229
1739
1740         Rubber stamped by Tim Horton.
1741
1742         * Configurations/FeatureDefines.xcconfig:
1743
1744 2017-10-16  Sam Weinig  <sam@webkit.org>
1745
1746         [Settings] Remove all custom code from Settings.h/cpp
1747         https://bugs.webkit.org/show_bug.cgi?id=178330
1748
1749         Reviewed by Simon Fraser.
1750
1751         * WebView/WebPreferences.mm:
1752         (+[WebPreferences initialize]):
1753         
1754             Update for naming changes of FrameFlattening now that it is an enum class.
1755
1756 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1757
1758         Remove Editor::simplifyMarkup
1759         https://bugs.webkit.org/show_bug.cgi?id=178271
1760
1761         Reviewed by Wenson Hsieh.
1762
1763         * WebView/WebView.mm:
1764         (-[WebView _simplifyMarkup:endNode:]):
1765
1766 2017-10-12  Chris Dumez  <cdumez@apple.com>
1767
1768         [Mac] Add support for MouseEvent.buttons
1769         https://bugs.webkit.org/show_bug.cgi?id=178214
1770
1771         Reviewed by Ryosuke Niwa.
1772
1773         * WebView/WebPDFView.mm:
1774         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1775
1776 2017-10-11  Sam Weinig  <sam@webkit.org>
1777
1778         Remove out-parameter variants of copyToVector
1779         https://bugs.webkit.org/show_bug.cgi?id=178155
1780
1781         Reviewed by Tim Horton.
1782
1783         * Plugins/WebNetscapePluginView.mm:
1784         (-[WebNetscapePluginView destroyPlugin]):
1785         * WebView/WebHTMLRepresentation.mm:
1786         (newArrayWithStrings):
1787
1788             Replace out-parameter based copyToVector, with one that returns a Vector.
1789
1790 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1791
1792         Sanitize URL in pasteboard for other applications and cross origin content
1793         https://bugs.webkit.org/show_bug.cgi?id=178060
1794         <rdar://problem/34874518>
1795
1796         Reviewed by Wenson Hsieh.
1797
1798         * WebCoreSupport/WebPlatformStrategies.h:
1799         * WebCoreSupport/WebPlatformStrategies.mm:
1800         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1801
1802 2017-10-11  Chris Dumez  <cdumez@apple.com>
1803
1804         Modernize Geolocation code
1805         https://bugs.webkit.org/show_bug.cgi?id=178148
1806
1807         Reviewed by Ryosuke Niwa.
1808
1809         * WebCoreSupport/WebGeolocationClient.h:
1810         * WebCoreSupport/WebGeolocationClient.mm:
1811         (WebGeolocationClient::lastPosition):
1812         * WebView/WebGeolocationPosition.mm:
1813         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1814         (core):
1815         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1816         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1817         * WebView/WebGeolocationPositionInternal.h:
1818
1819 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1820
1821         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1822         https://bugs.webkit.org/show_bug.cgi?id=178154
1823
1824         Reviewed by Wenson Hsieh.
1825
1826         Enable custom pasteboard data by default.
1827
1828         * WebView/WebPreferenceKeysPrivate.h:
1829         * WebView/WebPreferences.mm:
1830         (+[WebPreferences initialize]):
1831         (-[WebPreferences customPasteboardDataEnabled]): Added.
1832         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1833         * WebView/WebPreferencesPrivate.h:
1834         * WebView/WebView.mm:
1835         (-[WebView _preferencesChanged:]):
1836
1837 2017-10-10  Sam Weinig  <sam@webkit.org>
1838
1839         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1840         https://bugs.webkit.org/show_bug.cgi?id=178102
1841
1842         Reviewed by Tim Horton.
1843
1844         * History/WebHistory.mm:
1845         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1846         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1847         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1848         * WebCoreSupport/WebUserMediaClient.mm:
1849         (WebUserMediaClient::pageDestroyed):
1850
1851 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1852
1853         Make the names of the options consistent
1854         https://bugs.webkit.org/show_bug.cgi?id=177933
1855
1856         Reviewed by Saam Barati.
1857
1858         * WebView/WebFrame.h:
1859         * WebView/WebHTMLView.mm:
1860         (-[WebHTMLView setMarkedText:selectedRange:]):
1861         * WebView/WebView.h:
1862
1863 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1864
1865         [iOS] Tweak support for classifying form controls (followup to r222487)
1866         https://bugs.webkit.org/show_bug.cgi?id=177917
1867         <rdar://problem/34820122>
1868
1869         Reviewed by Dean Jackson.
1870
1871         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1872
1873         * DOM/DOMHTMLInputElement.mm:
1874         (-[DOMHTMLInputElement _autofillContext]):
1875         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1876         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1877
1878 2017-10-05  Keith Miller  <keith_miller@apple.com>
1879
1880         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1881
1882         * Configurations/WebKitLegacy.xcconfig:
1883
1884 2017-10-05  Jer Noble  <jer.noble@apple.com>
1885
1886         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1887         https://bugs.webkit.org/show_bug.cgi?id=177261
1888
1889         Reviewed by Eric Carlson.
1890
1891         * Configurations/FeatureDefines.xcconfig:
1892
1893 2017-10-05  Chris Dumez  <cdumez@apple.com>
1894
1895         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1896         https://bugs.webkit.org/show_bug.cgi?id=177957
1897
1898         Reviewed by Alex Christensen.
1899
1900         * WebCoreSupport/WebPlatformStrategies.h:
1901         * WebCoreSupport/WebPlatformStrategies.mm:
1902         (WebPlatformStrategies::cookiesEnabled):
1903
1904 2017-10-05  Youenn Fablet  <youenn@apple.com>
1905
1906         Make LibWebRTCProvider port agnostic
1907         https://bugs.webkit.org/show_bug.cgi?id=177747
1908
1909         Reviewed by Alex Christensen & Alex Garcia.
1910
1911         * WebView/WebView.mm:
1912         (-[WebView _commonInitializationWithFrameName:groupName:]):
1913         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1914
1915 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1916
1917         Stop linking with WebKitSystemInterface
1918         https://bugs.webkit.org/show_bug.cgi?id=177915
1919
1920         Reviewed by Antti Koivisto.
1921
1922         * Configurations/DebugRelease.xcconfig:
1923         * Configurations/WebKitLegacy.xcconfig:
1924
1925 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1926
1927         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1928         https://bugs.webkit.org/show_bug.cgi?id=177912
1929
1930         Reviewed by Saam Barati.
1931
1932         * Carbon/CarbonUtils.m:
1933         * Carbon/CarbonWindowAdapter.mm:
1934         * Carbon/HIWebView.mm:
1935         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1936         * Misc/WebNSFileManagerExtras.mm:
1937         * Misc/WebNSPasteboardExtras.mm:
1938         * Misc/WebNSURLExtras.mm:
1939         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1940         * Plugins/Hosted/NetscapePluginHostManager.mm:
1941         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1942         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1943         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1944         * Plugins/Hosted/WebTextInputWindowController.m:
1945         * Plugins/WebBaseNetscapePluginView.mm:
1946         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1947         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1948         * Plugins/WebNetscapePluginStream.mm:
1949         * Plugins/WebNetscapePluginView.mm:
1950         * Plugins/WebPluginDatabase.mm:
1951         * WebCoreSupport/PopupMenuMac.mm:
1952         * WebCoreSupport/WebChromeClient.mm:
1953         * WebCoreSupport/WebFrameLoaderClient.mm:
1954         * WebCoreSupport/WebInspectorClient.mm:
1955         * WebCoreSupport/WebPlatformStrategies.mm:
1956         * WebCoreSupport/WebSystemInterface.mm:
1957         * WebView/WebDynamicScrollBarsView.mm:
1958         * WebView/WebFrame.mm:
1959         * WebView/WebFrameView.mm:
1960         * WebView/WebFullScreenController.mm:
1961         * WebView/WebHTMLView.mm:
1962         * WebView/WebPreferences.mm:
1963         * WebView/WebView.mm:
1964
1965 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1966
1967         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1968         rdar://problem/34705779
1969
1970         Addressing review comments that I somehow landed without.
1971
1972         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1973
1974 2017-09-29  Chris Dumez  <cdumez@apple.com>
1975
1976         Split some logic out of VisitedLinkStore and make it reusable
1977         https://bugs.webkit.org/show_bug.cgi?id=177575
1978
1979         Reviewed by Alex Christensen.
1980
1981         * WebCoreSupport/WebVisitedLinkStore.h:
1982         * WebCoreSupport/WebVisitedLinkStore.mm:
1983         (WebVisitedLinkStore::addVisitedLink):
1984         (WebVisitedLinkStore::removeVisitedLink):
1985         (WebVisitedLinkStore::isLinkVisited):
1986         (WebVisitedLinkStore::addVisitedLinkHash):
1987
1988 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1989
1990         Build fix for High Sierra 32 bit Mac
1991         https://bugs.webkit.org/show_bug.cgi?id=177551
1992         <rdar://problem/34690283>
1993
1994         Reviewed by Alexey Proskuryakov.
1995
1996         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1997         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1998         also made.
1999
2000         * Carbon/CarbonWindowAdapter.mm:
2001         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2002         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2003         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2004         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2005         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2006         (-[CarbonWindowAdapter dealloc]):
2007         (-[CarbonWindowAdapter windowRef]):
2008         (-[CarbonWindowAdapter _hasWindowRef]):
2009         (-[CarbonWindowAdapter _managesWindowRef]):
2010         (-[CarbonWindowAdapter _removeWindowRef]):
2011         (-[CarbonWindowAdapter _carbonWindowClass]):
2012         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2013         (-[CarbonWindowAdapter sendSuperEvent:]):
2014         (-[CarbonWindowAdapter relinquishFocus]):
2015         (-[CarbonWindowAdapter _cancelKey:]):
2016         (-[CarbonWindowAdapter _commonAwake]):
2017         (-[CarbonWindowAdapter _destroyRealWindow:]):
2018         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2019         (-[CarbonWindowAdapter _termWindowIfOwner]):
2020         (-[CarbonWindowAdapter _windowMovedToRect:]):
2021         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2022         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2023         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2024         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2025         (-[CarbonWindowAdapter canBecomeMainWindow]):
2026         (-[CarbonWindowAdapter encodeWithCoder:]):
2027         (-[CarbonWindowAdapter initWithCoder:]):
2028         (-[CarbonWindowAdapter setContentView:]):
2029         (-[CarbonWindowAdapter worksWhenModal]):
2030         (-[CarbonWindowAdapter _setModalWindowLevel]):
2031         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2032         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2033         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2034         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2035         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2036         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2037         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2038         (NSCarbonWindowHandleEvent):
2039         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2040         (-[CarbonWindowAdapter _growBoxRect]):
2041         * Carbon/HIWebView.mm:
2042         (HIWebViewGetWebView):
2043         (HIWebViewConstructor):
2044         (HIWebViewDestructor):
2045         (HIWebViewRegisterClass):
2046         (GetBehaviors):
2047         (Draw):
2048         (HitTest):
2049         (GetRegion):
2050         (GetWindowRef):
2051         (CreateNSEventAdoptingCGEvent):
2052         (CopyEventCGEvent):
2053         (CreateNSEventWithCarbonClickEvent):
2054         (Click):
2055         (CreateNSEventWithCarbonEvent):
2056         (MouseUp):
2057         (CreateNSEventWithCarbonMouseMoveEvent):
2058         (MouseMoved):
2059         (MouseDragged):
2060         (MouseWheelMoved):
2061         (ContextMenuClick):
2062         (GetKind):
2063         (BoundsChanged):
2064         (OwningWindowChanged):
2065         (WindowHandler):
2066         (SyncFrame):
2067         (SetFocusPart):
2068         (AdvanceFocus):
2069         (RelinquishFocus):
2070         (ActiveStateChanged):
2071         (ProcessCommand):
2072         (UpdateCommandStatus):
2073         (_NSSelectorForHICommand):
2074         (HIWebViewEventHandler):
2075         (StartUpdateObserver):
2076         (StopUpdateObserver):
2077         (UpdateObserver):
2078
2079 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2080
2081         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2082         https://bugs.webkit.org/show_bug.cgi?id=172526
2083         <rdar://problem/32396081>
2084
2085         Reviewed by Ryosuke Niwa.
2086
2087         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2088
2089         * WebCoreSupport/WebPlatformStrategies.h:
2090         * WebCoreSupport/WebPlatformStrategies.mm:
2091         (WebPlatformStrategies::webExposedTypes):
2092         (WebPlatformStrategies::writeCustomData):
2093
2094 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2095
2096         Unreviewed, rolling out r222567.
2097
2098         This broke and internal build.
2099
2100         Reverted changeset:
2101
2102         "Build fix for High Sierra 32 bit Mac"
2103         https://bugs.webkit.org/show_bug.cgi?id=177551
2104         http://trac.webkit.org/changeset/222567
2105
2106 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2107
2108         Build fix for High Sierra 32 bit Mac
2109         https://bugs.webkit.org/show_bug.cgi?id=177551
2110         <rdar://problem/34690283>
2111
2112         Reviewed by Alexey Proskuryakov.
2113
2114         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2115         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2116         also made.
2117
2118         * Carbon/CarbonWindowAdapter.mm:
2119         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2120         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2121         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2122         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2123         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2124         (-[CarbonWindowAdapter dealloc]):
2125         (-[CarbonWindowAdapter windowRef]):
2126         (-[CarbonWindowAdapter _hasWindowRef]):
2127         (-[CarbonWindowAdapter _managesWindowRef]):
2128         (-[CarbonWindowAdapter _removeWindowRef]):
2129         (-[CarbonWindowAdapter _carbonWindowClass]):
2130         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2131         (-[CarbonWindowAdapter sendSuperEvent:]):
2132         (-[CarbonWindowAdapter relinquishFocus]):
2133         (-[CarbonWindowAdapter _cancelKey:]):
2134         (-[CarbonWindowAdapter _commonAwake]):
2135         (-[CarbonWindowAdapter _destroyRealWindow:]):
2136         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2137         (-[CarbonWindowAdapter _termWindowIfOwner]):
2138         (-[CarbonWindowAdapter _windowMovedToRect:]):
2139         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2140         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2141         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2142         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2143         (-[CarbonWindowAdapter canBecomeMainWindow]):
2144         (-[CarbonWindowAdapter encodeWithCoder:]):
2145         (-[CarbonWindowAdapter initWithCoder:]):
2146         (-[CarbonWindowAdapter setContentView:]):
2147         (-[CarbonWindowAdapter worksWhenModal]):
2148         (-[CarbonWindowAdapter _setModalWindowLevel]):
2149         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2150         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2151         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2152         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2153         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2154         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2155         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2156         (NSCarbonWindowHandleEvent):
2157         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2158         (-[CarbonWindowAdapter _growBoxRect]):
2159         * Carbon/HIWebView.mm:
2160         (HIWebViewGetWebView):
2161         (HIWebViewConstructor):
2162         (HIWebViewDestructor):
2163         (HIWebViewRegisterClass):
2164         (GetBehaviors):
2165         (Draw):
2166         (HitTest):
2167         (GetRegion):
2168         (GetWindowRef):
2169         (CreateNSEventAdoptingCGEvent):
2170         (CopyEventCGEvent):
2171         (CreateNSEventWithCarbonClickEvent):
2172         (Click):
2173         (CreateNSEventWithCarbonEvent):
2174         (MouseUp):
2175         (CreateNSEventWithCarbonMouseMoveEvent):
2176         (MouseMoved):
2177         (MouseDragged):
2178         (MouseWheelMoved):
2179         (ContextMenuClick):
2180         (GetKind):
2181         (BoundsChanged):
2182         (OwningWindowChanged):
2183         (WindowHandler):
2184         (SyncFrame):
2185         (SetFocusPart):
2186         (AdvanceFocus):
2187         (RelinquishFocus):
2188         (ActiveStateChanged):
2189         (ProcessCommand):
2190         (UpdateCommandStatus):
2191         (_NSSelectorForHICommand):
2192         (HIWebViewEventHandler):
2193         (StartUpdateObserver):
2194         (StopUpdateObserver):
2195         (UpdateObserver):
2196
2197 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2198
2199         Make PolicyAction an encodable enum class
2200         https://bugs.webkit.org/show_bug.cgi?id=177480
2201
2202         Reviewed by Antti Koivisto.
2203
2204         * Plugins/WebPluginContainerCheck.mm:
2205         (-[WebPluginContainerCheck _continueWithPolicy:]):
2206         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2207         * WebCoreSupport/WebFrameLoaderClient.mm:
2208         (-[WebFramePolicyListener invalidate]):
2209         (-[WebFramePolicyListener ignore]):
2210         (-[WebFramePolicyListener download]):
2211         (-[WebFramePolicyListener use]):
2212         (-[WebFramePolicyListener continue]):
2213         * WebView/WebPolicyDelegate.mm:
2214         (-[WebPolicyDecisionListener use]):
2215         (-[WebPolicyDecisionListener ignore]):
2216         (-[WebPolicyDecisionListener download]):
2217
2218 2017-09-25  Frederik Riedel  <riedel@apple.com>
2219
2220         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2221         https://bugs.webkit.org/show_bug.cgi?id=174394
2222         <rdar://problem/33183504>
2223
2224         Reviewed by Ryosuke Niwa.
2225
2226         * DOM/DOMHTMLInputElement.h:
2227         * DOM/DOMHTMLInputElement.mm:
2228         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2229         Determines if this HTMLInputElement is part of a login screen.
2230         (-[DOMHTMLInputElement representingPageUrl]):
2231         Returns the webpage's URL that is currently displayed in the Web View.
2232         (-[DOMHTMLInputElement insertTextSuggestion:]):
2233         Inserts login credentials into the Web View.
2234
2235 2017-09-25  Sam Weinig  <sam@webkit.org>
2236
2237         Remove unused EditorClient functions
2238         https://bugs.webkit.org/show_bug.cgi?id=177463
2239
2240         Reviewed by Alex Christensen.
2241
2242         Remove unused EditorClient functions.
2243
2244         * WebCoreSupport/WebEditorClient.h:
2245         * WebCoreSupport/WebEditorClient.mm:
2246         (WebEditorClient::canonicalizeURL): Deleted.
2247         (WebEditorClient::canonicalizeURLString): Deleted.
2248         (WebEditorClient::writeDataToPasteboard): Deleted.
2249         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2250         (WebEditorClient::readDataFromPasteboard): Deleted.
2251         (WebEditorClient::pasteboardChangeCount): Deleted.
2252
2253 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2254
2255         Stop using PolicyCallback
2256         https://bugs.webkit.org/show_bug.cgi?id=176088
2257
2258         Reviewed by Andy Estes.
2259
2260         * WebCoreSupport/WebFrameLoaderClient.mm:
2261         (-[WebFramePolicyListener invalidate]):
2262         (-[WebFramePolicyListener receivedPolicyDecision:]):
2263
2264 2017-09-25  Sam Weinig  <sam@webkit.org>
2265
2266         Remove unnecessary userVisibleString EditorClient function
2267         https://bugs.webkit.org/show_bug.cgi?id=177456
2268
2269         Reviewed by Dan Bernstein.
2270
2271         * WebCoreSupport/WebEditorClient.h:
2272         * WebCoreSupport/WebEditorClient.mm:
2273         (WebEditorClient::userVisibleString): Deleted.
2274
2275             Remove userVisibleString client function.
2276
2277 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2278
2279         Separate form submission from PolicyChecker infrastructure
2280         https://bugs.webkit.org/show_bug.cgi?id=177396
2281
2282         Reviewed by Geoffrey Garen.
2283
2284         * WebCoreSupport/WebFrameLoaderClient.h:
2285         * WebCoreSupport/WebFrameLoaderClient.mm:
2286         (WebFrameLoaderClient::dispatchWillSubmitForm):
2287
2288 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2289
2290         WeakPtrFactory should populate m_ref lazily.
2291         https://bugs.webkit.org/show_bug.cgi?id=177375
2292
2293         Reviewed by Geoffrey Garen.
2294
2295         * WebCoreSupport/WebEditorClient.mm:
2296         (WebEditorClient::WebEditorClient):
2297         (WebEditorClient::requestCandidatesForSelection):
2298
2299 2017-09-22  Chris Dumez  <cdumez@apple.com>
2300
2301         Use high resolution timestamp for event time
2302         https://bugs.webkit.org/show_bug.cgi?id=154246
2303         <rdar://problem/34333304>
2304
2305         Reviewed by Ryosuke Niwa.
2306
2307         Use WallTime / MonotonicTime instead of double type for clarity.
2308
2309         * DOM/DOMEvent.mm:
2310         (-[DOMEvent timeStamp]):
2311         * WebView/WebFrame.mm:
2312         (-[WebFrame _dragSourceEndedAt:operation:]):
2313         * WebView/WebPDFView.mm:
2314         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2315
2316 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2317
2318         Enable dataTransfer.items on macOS and iOS
2319         https://bugs.webkit.org/show_bug.cgi?id=177335
2320
2321         Reviewed by Sam Weinig.
2322
2323         * WebView/WebPreferences.mm:
2324         (+[WebPreferences initialize]):
2325
2326 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2327
2328         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2329         https://bugs.webkit.org/show_bug.cgi?id=177101
2330         <rdar://problem/34500648>
2331
2332         Reviewed by Brian Burg.
2333
2334         * WebInspector/WebNodeHighlight.mm:
2335         Ensure we close the window that we have just removed.
2336
2337 2017-09-20  Antti Koivisto  <antti@apple.com>
2338
2339         Remove DOM and styling support for CSS Regions
2340         https://bugs.webkit.org/show_bug.cgi?id=177221
2341
2342         Reviewed by Andreas Kling.
2343
2344         * Configurations/FeatureDefines.xcconfig:
2345         * DOM/DOMCSS.mm:
2346         (kitClass):
2347         * DOM/DOMElement.mm:
2348         (-[DOMElement webkitRegionOverset]): Deleted.
2349
2350 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2351
2352         Layering violation in Editor::createFragment
2353         https://bugs.webkit.org/show_bug.cgi?id=176123
2354
2355         Reviewed by Darin Adler.
2356
2357         * Misc/WebNSURLExtras.h:
2358         * Misc/WebNSURLExtras.mm:
2359         * WebView/WebFrame.mm:
2360         * WebView/WebHTMLView.mm:
2361         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2362
2363         * WebCoreSupport/WebEditorClient.mm:
2364         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2365         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2366         way to avoid exporting the symbol just on newer OSes.
2367
2368 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2369
2370         On iOS, getData can't get text set by setData during copy event
2371         https://bugs.webkit.org/show_bug.cgi?id=176980
2372         <rdar://problem/34453915>
2373
2374         Reviewed by Darin Adler.
2375
2376         * WebCoreSupport/WebPlatformStrategies.h:
2377         * WebCoreSupport/WebPlatformStrategies.mm:
2378         (WebPlatformStrategies::copy): Deleted.
2379
2380 2017-09-18  Andy Estes  <aestes@apple.com>
2381
2382         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2383         https://bugs.webkit.org/show_bug.cgi?id=177029
2384
2385         Reviewed by Alex Christensen.
2386
2387         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2388         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2389         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2390         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2391         * WebCoreSupport/PopupMenuMac.mm:
2392         (PopupMenuMac::show):
2393         * WebCoreSupport/WebSystemInterface.mm:
2394         (InitWebCoreSystemInterface):
2395         * WebView/WebHTMLView.mm:
2396         (-[WebHTMLView setDataSource:]):
2397         (-[WebHTMLView attachRootLayer:]):
2398         * WebView/WebView.mm:
2399         (-[WebView _needsAdobeFrameReloadingQuirk]):
2400         (-[WebView _needsLinkElementTextCSSQuirk]):
2401         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2402         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2403         (-[WebView _preferencesChanged:]):
2404
2405 2017-09-15  Andy Estes  <aestes@apple.com>
2406
2407         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2408         https://bugs.webkit.org/show_bug.cgi?id=176953
2409
2410         Reviewed by Eric Carlson.
2411
2412         * WebCoreSupport/WebSystemInterface.mm:
2413         (InitWebCoreSystemInterface):
2414
2415 2017-09-14  Andy Estes  <aestes@apple.com>
2416
2417         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2418         https://bugs.webkit.org/show_bug.cgi?id=176931
2419
2420         Reviewed by Joseph Pecoraro.
2421
2422         * WebCoreSupport/WebSystemInterface.mm:
2423         (InitWebCoreSystemInterface):
2424
2425 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2426
2427         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2428         https://bugs.webkit.org/show_bug.cgi?id=176867
2429
2430         Reviewed by Sam Weinig.
2431
2432         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2433         (WebKit::NetscapePluginInstanceProxy::enumerate):
2434
2435 2017-09-13  Andy Estes  <aestes@apple.com>
2436
2437         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2438         https://bugs.webkit.org/show_bug.cgi?id=176729
2439
2440         Reviewed by Alex Christensen.
2441
2442         * WebCoreSupport/WebSystemInterface.mm:
2443         (InitWebCoreSystemInterface):
2444         * WebView/WebView.mm:
2445         (+[WebView _setCacheModel:]):
2446
2447 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2448
2449         Refactor WebContentReader out of EditorMac and EditorIOS
2450         https://bugs.webkit.org/show_bug.cgi?id=176770
2451
2452         Reviewed by Sam Weinig.
2453
2454         * WebCoreSupport/WebEditorClient.mm:
2455
2456 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2457
2458         Dragging & dropping a file creates an attachment element even when it's disabled
2459         https://bugs.webkit.org/show_bug.cgi?id=176769
2460
2461         Reviewed by Tim Horton.
2462
2463         * WebView/WebView.mm:
2464         (-[WebView _preferencesChanged:]):
2465
2466 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2467
2468         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2469         https://bugs.webkit.org/show_bug.cgi?id=176721
2470         <rdar://problem/34373660>
2471
2472         Reviewed by Tim Horton.
2473
2474         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2475         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2476
2477         * WebView/WebView.mm:
2478         (-[WebView _startDrag:]):
2479         (-[WebView _draggedElementBounds]):
2480         (-[WebView _endedDataInteraction:global:]):
2481         * WebView/WebViewData.h:
2482
2483 2017-09-11  Andy Estes  <aestes@apple.com>
2484
2485         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2486         https://bugs.webkit.org/show_bug.cgi?id=176472
2487
2488         Reviewed by Eric Carlson.
2489
2490         * WebCoreSupport/WebSystemInterface.mm:
2491         (InitWebCoreSystemInterface):
2492
2493 2017-09-09  Mark Lam  <mark.lam@apple.com>
2494
2495         Avoid duplicate computations of ExecState::vm().
2496         https://bugs.webkit.org/show_bug.cgi?id=176647
2497
2498         Reviewed by Saam Barati.
2499
2500         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2501         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2502         (WebKit::NetscapePluginInstanceProxy::construct):
2503         (WebKit::NetscapePluginInstanceProxy::setProperty):
2504         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2505         (WebKit::NetscapePluginInstanceProxy::enumerate):
2506         * Plugins/Hosted/ProxyInstance.mm:
2507         (WebKit::ProxyRuntimeMethod::create):
2508
2509 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2510
2511         Unreviewed, rolling out r221773.
2512         https://bugs.webkit.org/show_bug.cgi?id=176614
2513
2514         This caused build failures. (Requested by mlewis13 on
2515         #webkit).
2516
2517         Reverted changeset:
2518
2519         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2520         https://bugs.webkit.org/show_bug.cgi?id=176472
2521         http://trac.webkit.org/changeset/221773
2522
2523 2017-09-07  Andy Estes  <aestes@apple.com>
2524
2525         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2526         https://bugs.webkit.org/show_bug.cgi?id=176472
2527
2528         Reviewed by Eric Carlson.
2529
2530         * WebCoreSupport/WebSystemInterface.mm:
2531         (InitWebCoreSystemInterface):
2532
2533 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2534
2535         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2536         https://bugs.webkit.org/show_bug.cgi?id=176561
2537
2538         Reviewed by Brent Fulgham.
2539
2540         * Misc/WebNSUserDefaultsExtras.mm:
2541
2542 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2543
2544         Modernize Geolocation code
2545         https://bugs.webkit.org/show_bug.cgi?id=176496
2546
2547         Reviewed by Andy Estes.
2548
2549         * WebCoreSupport/WebGeolocationClient.h:
2550         * WebCoreSupport/WebGeolocationClient.mm:
2551         (WebGeolocationClient::requestPermission):
2552         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2553         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2554         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2555         * WebView/WebView.mm:
2556         (-[WebView _commonInitializationWithFrameName:groupName:]):
2557         (-[WebView _geolocationDidFailWithMessage:]):
2558
2559 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2560
2561         Remove some unused bits of code and resources
2562         https://bugs.webkit.org/show_bug.cgi?id=176275
2563
2564         Reviewed by Dan Bernstein.
2565
2566         * Misc/WebNSFileManagerExtras.mm:
2567         Include FileSystem instead of FileSystemIOS.
2568
2569 2017-09-03  Darin Adler  <darin@apple.com>
2570
2571         [Cocoa] Tidy a few things in legacy WebHTMLView
2572         https://bugs.webkit.org/show_bug.cgi?id=176280
2573
2574         Reviewed by Dan Bernstein.
2575
2576         * WebCoreSupport/WebChromeClient.mm:
2577         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2578         methods it calls on WebHTMLView were doing nothing on iOS.
2579
2580         * WebView/WebFrame.mm:
2581         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2582         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2583
2584         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2585         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2586         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2587         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2588         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2589         Use RetainPtr instead of writing retain/release wherever possible.
2590         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2591         initialization for it. Removed various unused methods and declarations of methods.
2592         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2593         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2594         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2595         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2596         and remove CFRetain no longer needed since we don't support garbage collection any more.
2597         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2598         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2599         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2600         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2601         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2602         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2603         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2604         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2605         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2606         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2607         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2608         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2609         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2610         debug flag; we haven't used it for years and it's not clearly helpful.
2611         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2612         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2613         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2614         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2615         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2616         two additional methods in the WebPrivate category and still be called by the two
2617         methods in the WebInternal category that were already using it.
2618         (-[WebHTMLView didAddSubview:]): Deleted.
2619         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2620         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2621         place this was called, the close method.
2622         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2623         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2624         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2625         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2626         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2627         Added helper method to make the one below simpler.
2628         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2629         Compared pasteboard type strings using isEqualToString: rather than using == since
2630         we want to actually compare the string contents. Also updated to use modern for loop,
2631         renamed a local variable from "s" to "localSubresources", and factored out the handling
2632         of three image types to use the helper method above.
2633         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2634         _web_makePluginSubviewsPerformSelector:withObject: method.
2635         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2636         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2637         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2638         not call the -[NSView subviews] method to make this identical on both platforms and used
2639         a modern for loop.
2640         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2641         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2642         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2643         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2644         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2645         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2646         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2647         of it is Mac-only.
2648         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2649         method did was call itself on the main thread, and do nothing if called on main thread.
2650         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2651         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2652         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2653         half of this method.
2654         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2655         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2656         Simplified using a modern for loop and RetainPtr.
2657         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2658         (-[WebHTMLView keyDown:]): Ditto.
2659         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2660         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2661         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2662         (-[WebHTMLView complete:]): Ditto.
2663         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2664         now macOS-only.
2665         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2666         iOS since that is now macOS-only.
2667         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2668         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2669         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2670         and reorganized to use early return.
2671         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2672         on iOS, but kept there so we don't have to do #if at every call site.
2673         (-[WebHTMLView _pluginController]): Moved into internal category.
2674         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2675         there only for GC, using C++ initialization, removing obsolete comment.
2676         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2677         peculiar iOS-only comment.
2678         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2679
2680         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2681         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2682         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2683         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2684         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2685
2686         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2687         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2688         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2689         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2690         them at this time.
2691
2692 2017-09-03  Sam Weinig  <sam@webkit.org>
2693
2694         Remove CanvasProxy
2695         https://bugs.webkit.org/show_bug.cgi?id=176288
2696
2697         Reviewed by Yusuke Suzuki.
2698
2699         CanvasProxy does not appear to be in any current HTML spec
2700         and was disabled and unimplemented in our tree. Time to 
2701         get rid of it.
2702
2703         * Configurations/FeatureDefines.xcconfig:
2704
2705 2017-09-02  Andy Estes  <aestes@apple.com>
2706
2707         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2708         https://bugs.webkit.org/show_bug.cgi?id=176270
2709
2710         Reviewed by Tim Horton.
2711
2712         * Plugins/Hosted/NetscapePluginHostManager.mm:
2713         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2714         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2715         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2716         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2717         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2718         (WebKit::SoftwareCARenderer::context const):
2719         (WebKit::SoftwareCARenderer::renderContext const):
2720         (WebKit::SoftwareCARenderer::render):
2721         (-[WebHostedNetscapePluginView createPlugin]):
2722         (-[WebHostedNetscapePluginView createPluginLayer]):
2723         (-[WebHostedNetscapePluginView destroyPlugin]):
2724         (-[WebHostedNetscapePluginView drawRect:]):
2725         * WebCoreSupport/WebSystemInterface.mm:
2726         (InitWebCoreSystemInterface):
2727
2728 2017-09-01  Andy Estes  <aestes@apple.com>
2729
2730         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2731         https://bugs.webkit.org/show_bug.cgi?id=176200
2732
2733         Reviewed by Tim Horton.
2734
2735         * Carbon/HIWebView.mm:
2736         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2737         (overrideCGContext):
2738         (restoreCGContext):
2739         (Draw):
2740         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2741         (+[WebHostedNetscapePluginView initialize]):
2742         * Plugins/WebBaseNetscapePluginView.h:
2743         * Plugins/WebBaseNetscapePluginView.mm:
2744         (WebKit::sendUserChangeNotifications):
2745         * Plugins/WebNetscapePluginView.mm:
2746         (+[WebNetscapePluginView initialize]):
2747         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2748         * WebCoreSupport/WebSystemInterface.mm:
2749         (InitWebCoreSystemInterface):
2750         * WebView/WebFrame.mm:
2751         (-[WebFrame _paintBehaviorForDestinationContext:]):
2752         * WebView/WebFullScreenController.mm:
2753         (setClipRectForWindow):
2754         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2755         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2756         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2757         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2758
2759 2017-08-31  Andy Estes  <aestes@apple.com>
2760
2761         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2762         https://bugs.webkit.org/show_bug.cgi?id=176175
2763
2764         Reviewed by Brady Eidson.
2765
2766         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2767         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2768         * Plugins/Hosted/WebTextInputWindowController.m:
2769         (-[WebTextInputPanel init]):
2770         * WebCoreSupport/WebSystemInterface.mm:
2771         (InitWebCoreSystemInterface):
2772         * WebView/WebDynamicScrollBarsView.mm:
2773         (-[WebDynamicScrollBarsView scrollWheel:]):
2774         * WebView/WebHTMLView.mm:
2775         (-[WebHTMLView _removeWindowObservers]):
2776         (-[WebHTMLView addWindowObservers]):
2777         * WebView/WebView.mm:
2778         (-[WebView addWindowObserversForWindow:]):
2779         (-[WebView removeWindowObservers]):
2780         (-[WebView viewWillMoveToWindow:]):
2781
2782 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2783
2784         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2785         https://bugs.webkit.org/show_bug.cgi?id=175779
2786         <rdar://problem/22367975>
2787
2788         Reviewed by Tim Horton.
2789
2790         * WebCoreSupport/WebFrameLoaderClient.h:
2791         * WebCoreSupport/WebFrameLoaderClient.mm:
2792         (WebFrameLoaderClient::webGLPolicyForURL const):
2793         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2794
2795 2017-08-30  Andy Estes  <aestes@apple.com>
2796
2797         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2798         https://bugs.webkit.org/show_bug.cgi?id=176093
2799
2800         Reviewed by Eric Carlson.
2801
2802         * WebCoreSupport/WebSystemInterface.mm:
2803         (InitWebCoreSystemInterface):
2804
2805 2017-08-30  Andy Estes  <aestes@apple.com>
2806
2807         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2808         https://bugs.webkit.org/show_bug.cgi?id=176087
2809
2810         Reviewed by Alex Christensen.
2811
2812         * Carbon/CarbonUtils.m:
2813         (getNSAutoreleasePoolCount):
2814         (WebInitForCarbon):
2815         (PoolCleaner):
2816         * Carbon/CarbonWindowAdapter.mm:
2817         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2818         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2819         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2820         (-[CarbonWindowAdapter _windowMovedToRect:]):
2821         * Carbon/HIViewAdapter.m:
2822         * Carbon/HIWebView.mm:
2823         (Draw):
2824         (CreateNSEventAdoptingCGEvent):
2825         (CopyEventCGEvent):
2826         (CreateNSEventWithCarbonClickEvent):
2827         (Click):
2828         (CreateNSEventWithCarbonEvent):
2829         (MouseUp):
2830         (CreateNSEventWithCarbonMouseMoveEvent):
2831         (MouseMoved):
2832         (MouseDragged):
2833         (MouseWheelMoved):
2834         (WindowHandler):
2835         (HIWebViewEventHandler):
2836         * Misc/QuickDrawCompatibility.h: Removed.
2837         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2838         (getCarbonEvent):
2839         (WebNetscapePluginEventHandlerCarbon::keyDown):
2840         (WebNetscapePluginEventHandlerCarbon::keyUp):
2841         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2842         (WebNetscapePluginEventHandlerCocoa::keyDown):
2843         * Plugins/WebNetscapePluginView.mm:
2844         (-[WebNetscapePluginView tellQuickTimeToChill]):
2845
2846 2017-08-29  Andy Estes  <aestes@apple.com>
2847
2848         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2849         https://bugs.webkit.org/show_bug.cgi?id=176046
2850
2851         Reviewed by Alex Christensen.
2852
2853         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2854         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2855
2856         * Misc/WebNSFileManagerExtras.mm:
2857         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2858         (setMetaData): Deleted.
2859         * WebCoreSupport/WebSystemInterface.mm:
2860         (InitWebCoreSystemInterface):
2861
2862 2017-08-28  Andy Estes  <aestes@apple.com>
2863
2864         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2865         https://bugs.webkit.org/show_bug.cgi?id=176039
2866
2867         Reviewed by Alex Christensen.
2868
2869         * WebCoreSupport/WebSystemInterface.mm:
2870         (InitWebCoreSystemInterface):
2871         * WebView/WebPreferences.mm:
2872         (+[WebPreferences _systemCFStringEncoding]):
2873
2874 2017-08-28  Andy Estes  <aestes@apple.com>
2875
2876         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2877         https://bugs.webkit.org/show_bug.cgi?id=176032
2878
2879         Reviewed by Alex Christensen.
2880
2881         * WebCoreSupport/WebSystemInterface.mm:
2882         (InitWebCoreSystemInterface):
2883         * WebView/WebView.mm:
2884         (-[WebView _cachedResponseForURL:]):
2885
2886 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2887
2888         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2889         https://bugs.webkit.org/show_bug.cgi?id=175992
2890         <rdar://problem/34086613>
2891
2892         Reviewed by Daniel Bates.
2893
2894         * WebCoreSupport/WebPlatformStrategies.h:
2895         * WebCoreSupport/WebPlatformStrategies.mm:
2896         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2897         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2898         indicating if secure cookies were accessed.
2899
2900 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2901
2902         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2903         https://bugs.webkit.org/show_bug.cgi?id=170955
2904         <rdar://problem/31697653>
2905
2906         Reviewed by Ryosuke Niwa.
2907
2908         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2909         text is being replaced.
2910
2911         * WebView/WebHTMLView.mm:
2912         (-[WebHTMLView insertText:]):
2913
2914 2017-08-24  Chris Dumez  <cdumez@apple.com>
2915
2916         [Directory Upload] Add basic support for input.webkitdirectory
2917         https://bugs.webkit.org/show_bug.cgi?id=175950
2918         <rdar://problem/33951915>
2919
2920         Reviewed by Geoffrey Garen.
2921
2922         Add private API to toggle Directory Upload support on Mac WebKit1.
2923
2924         * WebView/WebPreferenceKeysPrivate.h:
2925         * WebView/WebPreferences.mm:
2926         (+[WebPreferences initialize]):
2927         (-[WebPreferences setDirectoryUploadEnabled:]):
2928         (-[WebPreferences directoryUploadEnabled]):
2929         * WebView/WebPreferencesPrivate.h:
2930         * WebView/WebView.mm:
2931         (-[WebView _preferencesChanged:]):
2932
2933 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2934
2935         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2936         https://bugs.webkit.org/show_bug.cgi?id=175370
2937         <rdar://problem/33799806>
2938
2939         Reviewed by Ryosuke Niwa.
2940
2941         Adjust WebEditorClient for interface changes.
2942
2943         * WebCoreSupport/WebEditorClient.h:
2944
2945 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2946
2947         Remove ChromeClient::scrollbarsModeDidChange
2948         https://bugs.webkit.org/show_bug.cgi?id=175805
2949
2950         Reviewed by Daniel Bates.
2951
2952         * WebCoreSupport/WebChromeClient.h:
2953
2954 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2955
2956         Remove ChromeClient::hasOpenedPopup
2957         https://bugs.webkit.org/show_bug.cgi?id=175804
2958
2959         Reviewed by Sam Weinig.
2960
2961         * WebCoreSupport/WebChromeClient.h:
2962         * WebCoreSupport/WebChromeClient.mm:
2963         (WebChromeClient::hasOpenedPopup const): Deleted.
2964
2965 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2966
2967         Disable access to secure cookies if an HTTPS site loads mixed content
2968         https://bugs.webkit.org/show_bug.cgi?id=157053
2969         <rdar://problem/11290808>
2970
2971         Reviewed by Dan Bates.
2972
2973         * WebCoreSupport/WebPlatformStrategies.h:
2974         * WebCoreSupport/WebPlatformStrategies.mm:
2975         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2976         indicating whether secure cookies should be included in the response.
2977
2978 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2979
2980         [PAL] Move spi/mac directory into PAL
2981         https://bugs.webkit.org/show_bug.cgi?id=175649
2982
2983         Reviewed by Myles C. Maxfield.
2984
2985         * Misc/WebSharingServicePickerController.h:
2986         * WebCoreSupport/WebContextMenuClient.mm:
2987         * WebCoreSupport/WebEditorClient.mm:
2988         * WebCoreSupport/WebSelectionServiceController.mm:
2989         * WebView/WebHTMLView.mm:
2990         * WebView/WebImmediateActionController.h:
2991         * WebView/WebImmediateActionController.mm:
2992         * WebView/WebView.mm:
2993
2994 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2995
2996         [PAL] Relocate SessionID to root
2997         https://bugs.webkit.org/show_bug.cgi?id=175684
2998
2999         Reviewed by Alex Christensen.
3000
3001         * WebCoreSupport/WebFrameNetworkingContext.mm:
3002
3003 2017-08-17  Andreas Kling  <akling@apple.com>
3004
3005         Disable CSS regions at compile time
3006         https://bugs.webkit.org/show_bug.cgi?id=175630
3007
3008         Reviewed by Antti Koivisto.
3009
3010         * Configurations/FeatureDefines.xcconfig:
3011
3012 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3013
3014         [PAL] Move SessionID into PAL
3015         https://bugs.webkit.org/show_bug.cgi?id=174192
3016
3017         Reviewed by Antti Koivisto.
3018
3019         * Misc/WebCache.mm:
3020         (+[WebCache imageForURL:]):
3021         * WebCoreSupport/WebFrameLoaderClient.h:
3022         * WebCoreSupport/WebFrameLoaderClient.mm:
3023         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3024         * WebCoreSupport/WebFrameNetworkingContext.mm:
3025         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3026         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3027         (WebFrameNetworkingContext::storageSession const):
3028         * WebCoreSupport/WebPlatformStrategies.h:
3029         * WebCoreSupport/WebPlatformStrategies.mm:
3030         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3031         * WebKitPrefix.h:
3032
3033 2017-08-16  Andy Estes  <aestes@apple.com>
3034
3035         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3036         https://bugs.webkit.org/show_bug.cgi?id=175648
3037
3038         Reviewed by Tim Horton.
3039
3040         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3041         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3042         (WebPaymentCoordinatorClient::showPaymentUI):
3043
3044 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3045
3046         [PAL] Move spi/ios and spi/win directories into PAL
3047         https://bugs.webkit.org/show_bug.cgi?id=175171
3048
3049         Reviewed by Antti Koivisto.
3050
3051         * WebCoreSupport/WebFrameLoaderClient.mm:
3052         * WebView/WebView.mm:
3053
3054 2017-08-16  Andy Estes  <aestes@apple.com>
3055
3056         [Payment Request] Add an ENABLE flag and an experimental feature preference
3057         https://bugs.webkit.org/show_bug.cgi?id=175622
3058
3059         Reviewed by Tim Horton.
3060
3061         * Configurations/FeatureDefines.xcconfig:
3062
3063 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3064
3065         [PAL] Move Sleep classes into PAL
3066         https://bugs.webkit.org/show_bug.cgi?id=175456
3067
3068         Reviewed by Ryosuke Niwa.
3069
3070         * WebView/WebFullScreenController.h:
3071
3072 2017-08-15  Youenn Fablet  <youenn@apple.com>
3073
3074         [Cache API] Adding generic support for CacheStorage and Cache methods
3075         https://bugs.webkit.org/show_bug.cgi?id=175455
3076
3077         Reviewed by Chris Dumez.
3078
3079         * WebView/WebView.mm:
3080         (-[WebView _commonInitializationWithFrameName:groupName:]):
3081
3082 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3083
3084         Remove Proximity Events and related code
3085         https://bugs.webkit.org/show_bug.cgi?id=175545
3086
3087         Reviewed by Daniel Bates.
3088
3089         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3090         and other related code.
3091
3092         * Configurations/FeatureDefines.xcconfig:
3093
3094 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3095
3096         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3097         https://bugs.webkit.org/show_bug.cgi?id=175504
3098
3099         Reviewed by Sam Weinig.
3100
3101         * Configurations/FeatureDefines.xcconfig:
3102         * DOM/DOMHTMLFormElement.mm:
3103         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3104         * WebCoreSupport/WebFrameLoaderClient.h:
3105
3106 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3107
3108         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3109         https://bugs.webkit.org/show_bug.cgi?id=175557
3110
3111         Reviewed by Jon Lee.
3112
3113         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3114
3115         * Configurations/FeatureDefines.xcconfig:
3116
3117 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3118
3119         Composition underline color is always black
3120         https://bugs.webkit.org/show_bug.cgi?id=174675
3121
3122         Reviewed by Ryosuke Niwa.
3123
3124         * WebView/WebHTMLView.mm:
3125         (extractUnderlines): If NSUnderlineColorAttributeName
3126         is not present use text color for composition underline.
3127         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3128         for composition underline in the plain text case.
3129
3130 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3131
3132         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3133         https://bugs.webkit.org/show_bug.cgi?id=175474
3134         <rdar://problem/33844628>
3135
3136         Reviewed by Wenson Hsieh.
3137
3138         Replaced the build flag by a runtime flag and disabled the feature by default.
3139
3140         * Configurations/FeatureDefines.xcconfig:
3141         * WebView/WebPreferenceKeysPrivate.h:
3142         * WebView/WebPreferences.mm:
3143         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3144         (-[WebPreferences dataTransferItemsEnabled]): Added.
3145         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3146         * WebView/WebPreferencesPrivate.h:
3147         * WebView/WebView.mm:
3148         (-[WebView _preferencesChanged:]):
3149
3150 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3151
3152         Remove ENABLE_GAMEPAD_DEPRECATED
3153         https://bugs.webkit.org/show_bug.cgi?id=175361
3154
3155         Reviewed by Carlos Garcia Campos.
3156
3157         * Configurations/FeatureDefines.xcconfig:
3158
3159 2017-08-09  Chris Dumez  <cdumez@apple.com>
3160
3161         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3162         https://bugs.webkit.org/show_bug.cgi?id=175401
3163
3164         Reviewed by Brady Eidson.
3165
3166         * WebView/WebPreferenceKeysPrivate.h:
3167         * WebView/WebPreferences.mm:
3168         (+[WebPreferences initialize]):
3169         (-[WebPreferences beaconAPIEnabled]): Deleted.
3170         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3171         * WebView/WebPreferencesPrivate.h:
3172         * WebView/WebView.mm:
3173         (-[WebView _preferencesChanged:]):
3174
3175 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3176
3177         [PAL] Move spi/cocoa and spi/cg directories into PAL
3178         https://bugs.webkit.org/show_bug.cgi?id=175175
3179
3180         Reviewed by Myles C. Maxfield.
3181
3182         * History/WebHistory.mm:
3183         * Misc/WebDownload.mm:
3184         * Misc/WebKitNSStringExtras.mm:
3185         * Plugins/Hosted/NetscapePluginHostManager.mm:
3186         * Plugins/WebPluginDatabase.mm:
3187         * WebCoreSupport/WebFrameLoaderClient.mm:
3188         * WebInspector/WebNodeHighlight.mm:
3189         * WebView/WebHTMLView.mm:
3190         * WebView/WebIndicateLayer.mm:
3191         * WebView/WebView.mm:
3192         * WebView/WebViewData.h:
3193
3194 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3195
3196         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3197         https://bugs.webkit.org/show_bug.cgi?id=175392
3198         <rdar://problem/33783207>
3199
3200         Reviewed by Tim Horton and Megan Gardner.
3201
3202         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3203
3204         * Configurations/FeatureDefines.xcconfig:
3205
3206 2017-08-09  Daniel Bates  <dabates@apple.com>
3207
3208         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3209         https://bugs.webkit.org/show_bug.cgi?id=175247
3210         <rdar://problem/33679804>
3211
3212         Reviewed by Brady Eidson.
3213
3214         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3215         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3216         clients that need to make use of this information at this time. If such a needs comes up
3217         then we can expose API/SPI similar to what we do for WebKit.
3218
3219         * WebCoreSupport/WebFrameLoaderClient.h:
3220         * WebCoreSupport/WebFrameLoaderClient.mm:
3221         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3222
3223 2017-08-08  Brady Eidson  <beidson@apple.com>
3224
3225         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3226         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3227
3228         Reviewed by Andy Estes.
3229
3230         * Misc/WebKitVersionChecks.h:
3231         * WebCoreSupport/WebFrameLoaderClient.mm:
3232         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3233           the app is linked against new WebKit with the new behavior.
3234
3235 2017-08-07  Devin Rousso  <drousso@apple.com>
3236
3237         Web Inspector: Preview Canvas path when viewing a recording
3238         https://bugs.webkit.org/show_bug.cgi?id=174967
3239
3240         Reviewed by Brian Burg.
3241
3242         * WebView/WebPreferenceKeysPrivate.h:
3243         * WebView/WebPreferences.mm:
3244         (+[WebPreferences initialize]):
3245         (-[WebPreferences inspectorAdditionsEnabled]):
3246         (-[WebPreferences setInspectorAdditionsEnabled:]):
3247         * WebView/WebPreferencesPrivate.h:
3248         * WebView/WebView.mm:
3249         (-[WebView _preferencesChanged:]):
3250         Add plumbing for new InspectorAdditions runtime flag.
3251
3252 2017-08-07  Brian Burg  <bburg@apple.com>
3253
3254         Remove CANVAS_PATH compilation guard
3255         https://bugs.webkit.org/show_bug.cgi?id=175207
3256
3257         Reviewed by Sam Weinig.
3258
3259         * Configurations/FeatureDefines.xcconfig:
3260
3261 2017-08-04  Youenn Fablet  <youenn@apple.com>
3262
3263         [Cache API] Add Cache and CacheStorage IDL definitions
3264         https://bugs.webkit.org/show_bug.cgi?id=175201
3265
3266         Reviewed by Brady Eidson.
3267
3268         * WebView/WebPreferenceKeysPrivate.h:
3269         * WebView/WebPreferences.mm:
3270         (+[WebPreferences initialize]):
3271         (-[WebPreferences cacheAPIEnabled]):
3272         (-[WebPreferences setCacheAPIEnabled:]):
3273         * WebView/WebPreferencesPrivate.h:
3274         * WebView/WebView.mm:
3275         (-[WebView _preferencesChanged:]):
3276
3277 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3278
3279         Unreviewed, rolling out r220271.
3280
3281         Rolling out due to Layout Test failing on iOS Simulator.
3282
3283         Reverted changeset:
3284
3285         "Remove STREAMS_API compilation guard"
3286         https://bugs.webkit.org/show_bug.cgi?id=175165
3287         http://trac.webkit.org/changeset/220271
3288
3289 2017-08-04  Youenn Fablet  <youenn@apple.com>
3290
3291         Remove STREAMS_API compilation guard
3292         https://bugs.webkit.org/show_bug.cgi?id=175165
3293
3294         Reviewed by Darin Adler.
3295
3296         * Configurations/FeatureDefines.xcconfig:
3297         * WebView/WebPreferences.mm:
3298         (+[WebPreferences initialize]):
3299         * WebView/WebView.mm:
3300         (-[WebView _preferencesChanged:]):
3301
3302 2017-08-03  Brian Burg  <bburg@apple.com>
3303
3304         Remove ENABLE(WEB_SOCKET) guards
3305         https://bugs.webkit.org/show_bug.cgi?id=167044
3306
3307         Reviewed by Joseph Pecoraro.
3308
3309         * Configurations/FeatureDefines.xcconfig:
3310         * WebView/WebPreferencesPrivate.h:
3311
3312 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3313
3314         [PAL] Move spi/cf directory into PAL
3315         https://bugs.webkit.org/show_bug.cgi?id=175057
3316
3317         Reviewed by Antti Koivisto.
3318
3319         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3320         * Plugins/WebNetscapePluginStream.mm:
3321         * WebCoreSupport/WebFrameNetworkingContext.mm:
3322         * WebView/WebPreferences.mm:
3323         * WebView/WebView.mm:
3324
3325 2017-08-03  Youenn Fablet  <youenn@apple.com>
3326
3327         Remove FETCH_API compilation guard
3328         https://bugs.webkit.org/show_bug.cgi?id=175154
3329
3330         Reviewed by Chris Dumez.
3331
3332         * Configurations/FeatureDefines.xcconfig:
3333         * WebView/WebPreferences.mm:
3334         (+[WebPreferences initialize]):
3335         * WebView/WebView.mm:
3336         (-[WebView _preferencesChanged:]):
3337
3338 2017-08-03  Brady Eidson  <beidson@apple.com>
3339
3340         Add SW IDLs and stub out basic functionality.
3341         https://bugs.webkit.org/show_bug.cgi?id=175115
3342
3343         Reviewed by Chris Dumez.
3344
3345         * Configurations/FeatureDefines.xcconfig:
3346
3347 2017-08-02  Sam Weinig  <sam@webkit.org>
3348
3349         [WebIDL] Convert MutationCallback to be a normal generated callback
3350         https://bugs.webkit.org/show_bug.cgi?id=174140
3351
3352         Reviewed by Darin Adler.
3353
3354         * DOM/DOMDocument.mm:
3355         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3356         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3357         Pass, now necessary, Document to NativeNodeFilter constructor.
3358
3359 2017-08-01  Chris Dumez  <cdumez@apple.com>
3360
3361         Add initial support for navigator.sendBeacon
3362         https://bugs.webkit.org/show_bug.cgi?id=175007
3363         <rdar://problem/33547728>
3364
3365         Reviewed by Sam Weinig.
3366
3367         Add setting to toggle support for the Beacon API (it is disabled by default).
3368
3369         * WebView/WebPreferenceKeysPrivate.h:
3370         * WebView/WebPreferences.mm:
3371         (+[WebPreferences initialize]):
3372         (-[WebPreferences beaconAPIEnabled]):
3373         (-[WebPreferences setBeaconAPIEnabled:]):
3374         * WebView/WebPreferencesPrivate.h:
3375         * WebView/WebView.mm:
3376         (-[WebView _preferencesChanged:]):
3377
3378 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3379
3380         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3381         https://bugs.webkit.org/show_bug.cgi?id=174437
3382
3383         Reviewed by Darin Adler.
3384
3385         Remove redundant Web- prefix from classes in WebKit namespace.
3386
3387         * WebView/WebView.mm:
3388         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3389         * WebView/WebViewData.h:
3390         * WebView/WebViewData.mm:
3391
3392 2017-07-26  Brian Burg  <bburg@apple.com>
3393
3394         Remove WEB_TIMING feature flag
3395         https://bugs.webkit.org/show_bug.cgi?id=174795
3396
3397         Reviewed by Alex Christensen.
3398
3399         * Configurations/FeatureDefines.xcconfig:
3400
3401 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3402
3403         Async image decoding for large images should be disabled after the first time a tile is painted
3404         https://bugs.webkit.org/show_bug.cgi?id=174451
3405         <rdar://problem/31246421>
3406
3407         Reviewed by Simon Fraser.
3408
3409         * WebView/WebFrame.mm:
3410         (-[WebFrame _paintBehaviorForDestinationContext:]):
3411         (-[WebFrame _drawRect:contentsOnly:]):
3412         * WebView/WebHTMLView.mm:
3413         (imageFromRect):
3414
3415 2017-07-23  Darin Adler  <darin@apple.com>
3416
3417         More NeverDestroyed and related cleanup
3418         https://bugs.webkit.org/show_bug.cgi?id=174745
3419
3420         Reviewed by Alex Christensen.
3421
3422         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3423         for names that aren't even used in this file.
3424         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3425         -[NSArray arrayWithObject:].
3426         (-[DOMNode absoluteQuads]): Ditto.
3427         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3428         of writing out various types.
3429         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3430         syntax instea of -[NSArray arrayWithObject:].
3431         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3432         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3433         of writing out various types.
3434         (-[DOMHTMLImageElement mimeType]): Ditto.
3435
3436 2017-07-24  Chris Dumez  <cdumez@apple.com>
3437
3438         ExceptionCode enumeration should use modern exception names
3439         https://bugs.webkit.org/show_bug.cgi?id=174794
3440
3441         Reviewed by Geoffrey Garen.
3442
3443         * DOM/ExceptionHandlers.mm:
3444         (raiseNotSupportedErrorException):
3445
3446 2017-07-23  Chris Dumez  <cdumez@apple.com>
3447
3448         Drop ExceptionCodeDescription class
3449         https://bugs.webkit.org/show_bug.cgi?id=174757
3450
3451         Reviewed by Darin Adler.
3452
3453         Stop using ExceptionCodeDescription.
3454
3455         * DOM/ExceptionHandlers.mm:
3456         (raiseDOMErrorException):
3457
3458 2017-07-21  Andreas Kling  <akling@apple.com>
3459
3460         Use more references in event dispatch code
3461         https://bugs.webkit.org/show_bug.cgi?id=174681
3462
3463         Reviewed by Geoffrey Garen.
3464
3465         * DOM/ObjCEventListener.h:
3466         * DOM/ObjCEventListener.mm:
3467         (WebCore::ObjCEventListener::handleEvent):
3468         * WebCoreSupport/WebFrameLoaderClient.mm:
3469         (NetscapePluginWidget::handleEvent):
3470
3471 2017-07-21  Brady Eidson  <beidson@apple.com>
3472
3473         Get rid of WebCore IconDatabase code.
3474         https://bugs.webkit.org/show_bug.cgi?id=174700
3475
3476         Reviewed by Tim Horton.
3477
3478         * Misc/WebCoreStatistics.mm:
3479         (+[WebCoreStatistics iconPageURLMappingCount]):
3480         (+[WebCoreStatistics iconRetainedPageURLCount]):
3481         (+[WebCoreStatistics iconRecordCount]):
3482         (+[WebCoreStatistics iconsWithDataCount]):
3483         * WebCoreSupport/WebFrameLoaderClient.h:
3484         * WebCoreSupport/WebFrameLoaderClient.mm:
3485         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3486         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3487         * WebView/WebView.mm:
3488         (-[WebView mainFrameIconURL]):
3489
3490 2017-07-20  Chris Dumez  <cdumez@apple.com>
3491
3492         Drop legacy XPathException type