Improve use of NeverDestroyed
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-07-17  Darin Adler  <darin@apple.com>
2
3         Improve use of NeverDestroyed
4         https://bugs.webkit.org/show_bug.cgi?id=174348
5
6         Reviewed by Sam Weinig.
7
8         * Misc/WebStringTruncator.mm:
9         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
10         NeverDestroyed<RetainPtr> with just an NSFont * global.
11
12         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
13         NeverDestroyed.h.
14         * Storage/WebDatabaseManager.mm: Ditto.
15         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
16         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
17
18         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
19         (aeDescFromJSValue): Removed double hashing by using the return value from
20         add rather than calling contains before calling add.
21
22 2017-07-14  Jer Noble  <jer.noble@apple.com>
23
24         Allow clients to override their own hardware media requirements where no fallback media exists.
25         https://bugs.webkit.org/show_bug.cgi?id=174426
26         <rdar://problem/32537704>
27
28         Reviewed by Eric Carlson.
29
30         Add a new WebPreferences property to control WebCore's new
31         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
32
33         * WebView/WebPreferenceKeysPrivate.h:
34         * WebView/WebPreferences.mm:
35         (+[WebPreferences initialize]):
36         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
37         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
38         * WebView/WebPreferencesPrivate.h:
39         * WebView/WebView.mm:
40         (-[WebView _preferencesChanged:]):
41
42 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
43
44         Async image decoding for large images should be disabled by default
45         https://bugs.webkit.org/show_bug.cgi?id=174432
46
47         Reviewed by Simon Fraser.
48
49         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
50         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
51         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
52            a child view instead of propagating PaintBehaviorSnapshotting.
53         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
54            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
55
56         * WebView/WebFrame.mm:
57         (-[WebFrame _paintBehaviorForDestinationContext:]):
58         (-[WebFrame _drawRect:contentsOnly:]):
59         * WebView/WebHTMLView.mm:
60         (imageFromRect):
61
62 2017-07-12  Daniel Bates  <dabates@apple.com>
63
64         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
65         https://bugs.webkit.org/show_bug.cgi?id=174427
66
67         Rubber-stamped by Brady Eidson.
68
69         * WebView/WebPDFView.mm:
70         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
71
72 2017-07-12  Matt Lewis  <jlewis3@apple.com>
73
74         Unreviewed, rolling out r219401.
75
76         This revision rolled out the previous patch, but after talking
77         with reviewer, a rebaseline is what was needed.Rolling back in
78         before rebaseline.
79
80         Reverted changeset:
81
82         "Unreviewed, rolling out r219379."
83         https://bugs.webkit.org/show_bug.cgi?id=174400
84         http://trac.webkit.org/changeset/219401
85
86 2017-07-12  Matt Lewis  <jlewis3@apple.com>
87
88         Unreviewed, rolling out r219379.
89
90         This revision caused a consistent failure in the test
91         fast/dom/Window/property-access-on-cached-window-after-frame-
92         removed.html.
93
94         Reverted changeset:
95
96         "Remove NAVIGATOR_HWCONCURRENCY"
97         https://bugs.webkit.org/show_bug.cgi?id=174400
98         http://trac.webkit.org/changeset/219379
99
100 2017-07-11  Dean Jackson  <dino@apple.com>
101
102         Remove NAVIGATOR_HWCONCURRENCY
103         https://bugs.webkit.org/show_bug.cgi?id=174400
104
105         * Configurations/FeatureDefines.xcconfig:
106
107 2017-07-11  Dean Jackson  <dino@apple.com>
108
109         Rolling out r219372.
110
111         * Configurations/FeatureDefines.xcconfig:
112
113 2017-07-11  Dean Jackson  <dino@apple.com>
114
115         Remove NAVIGATOR_HWCONCURRENCY
116         https://bugs.webkit.org/show_bug.cgi?id=174400
117
118         * Configurations/FeatureDefines.xcconfig:
119
120 2017-07-03  Brian Burg  <bburg@apple.com>
121
122         Web Replay: remove some unused code
123         https://bugs.webkit.org/show_bug.cgi?id=173903
124
125         Rubber-stamped by Joseph Pecoraro.
126
127         * Configurations/FeatureDefines.xcconfig:
128
129 2017-07-09  Brady Eidson  <beidson@apple.com>
130
131         Remove some obsolete WebKitVersionChecks.
132         https://bugs.webkit.org/show_bug.cgi?id=174294
133
134         Reviewed by Dan Bernstein.
135
136         * Misc/WebKitVersionChecks.h:
137
138         * WebView/WebHTMLView.mm:
139         (-[WebHTMLView hitTest:]):
140
141         * WebView/WebView.mm:
142         (shouldRespectPriorityInCSSAttributeSetters):
143         (-[WebView _commonInitializationWithFrameName:groupName:]):
144         (-[WebView _preferencesChanged:]):
145         (shouldTransformsAffectOverflow): Deleted.
146         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
147
148 2017-07-08  Brady Eidson  <beidson@apple.com>
149
150         Remove some obsolete RuntimeApplicationChecks.
151         https://bugs.webkit.org/show_bug.cgi?id=174293
152
153         Reviewed by Dan Bernstein.
154
155         * Misc/WebKitVersionChecks.h:
156         * WebView/WebView.mm:
157         (+[WebView enableWebThread]):
158         (-[WebView _needsPreHTML5ParserQuirks]):
159
160 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
161
162         Drop NOSNIFF compile flag
163         https://bugs.webkit.org/show_bug.cgi?id=174289
164
165         Reviewed by Michael Catanzaro.
166
167         * Configurations/FeatureDefines.xcconfig:
168
169 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
170
171         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
172         https://bugs.webkit.org/show_bug.cgi?id=174150
173
174         Reviewed by Mark Lam.
175
176         * DOM/DOM.mm:
177         (lookupElementClass):
178
179 2017-07-06  Brady Eidson  <beidson@apple.com>
180
181         Add logging to first attempt to use the WebIconDatabase class.
182         https://bugs.webkit.org/show_bug.cgi?id=174190
183
184         Reviewed by Andy Estes.
185
186         * Misc/WebIconDatabase.mm:
187         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
188         * Misc/WebKitVersionChecks.h:
189
190 2017-07-06  Matt Lewis  <jlewis3@apple.com>
191
192         Unreviewed, rolling out r219178.
193
194         This caused a consistent failure with the API test
195         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
196
197         Reverted changeset:
198
199         "[WTF] Clean up StringStatics.cpp by using
200         LazyNeverDestroyed<> for Atoms"
201         https://bugs.webkit.org/show_bug.cgi?id=174150
202         http://trac.webkit.org/changeset/219178
203
204 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
205
206         [WTF] Move SoftLinking.h into WTF
207         https://bugs.webkit.org/show_bug.cgi?id=174000
208
209         Reviewed by Alex Christensen.
210
211         * Plugins/WebNetscapePluginView.mm:
212         * Plugins/WebPluginController.mm:
213         * WebCoreSupport/WebInspectorClient.mm:
214         * WebView/WebFullScreenController.mm:
215         * WebView/WebImmediateActionController.mm:
216         * WebView/WebView.mm:
217
218 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
219
220         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
221         https://bugs.webkit.org/show_bug.cgi?id=174150
222
223         Reviewed by Mark Lam.
224
225         * DOM/DOM.mm:
226         (lookupElementClass):
227
228 2017-07-05  Brady Eidson  <beidson@apple.com>
229
230         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
231         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
232
233         Reviewed by Alex Christensen.
234
235         Adopt to the new constructor for FrameLoadRequest.
236
237         * WebView/WebPDFView.mm:
238         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
239
240 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
241
242         Make WebKit's public headers on Mac and iOS C++ module safe
243         https://bugs.webkit.org/show_bug.cgi?id=174175
244
245         Reviewed by Alex Christensen.
246
247         Fixed the header files.
248
249         * Misc/WebDownload.h:
250         * Misc/WebKitErrors.h:
251         * Plugins/WebPluginContainer.h:
252         * WebView/WebResourceLoadDelegate.h:
253
254 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
255
256         Remove copy of ICU headers from WebKit
257         https://bugs.webkit.org/show_bug.cgi?id=116407
258
259         Reviewed by Alex Christensen.
260
261         Use WTF's copy of ICU headers.
262
263         * Configurations/WebKitLegacy.xcconfig:
264         * icu/unicode/localpointer.h: Removed.
265         * icu/unicode/parseerr.h: Removed.
266         * icu/unicode/platform.h: Removed.
267         * icu/unicode/ptypes.h: Removed.
268         * icu/unicode/putil.h: Removed.
269         * icu/unicode/uchar.h: Removed.
270         * icu/unicode/uconfig.h: Removed.
271         * icu/unicode/ucurr.h: Removed.
272         * icu/unicode/uidna.h: Removed.
273         * icu/unicode/uiter.h: Removed.
274         * icu/unicode/umachine.h: Removed.
275         * icu/unicode/unorm.h: Removed.
276         * icu/unicode/unorm2.h: Removed.
277         * icu/unicode/urename.h: Removed.
278         * icu/unicode/uscript.h: Removed.
279         * icu/unicode/ustring.h: Removed.
280         * icu/unicode/utf.h: Removed.
281         * icu/unicode/utf16.h: Removed.
282         * icu/unicode/utf8.h: Removed.
283         * icu/unicode/utf_old.h: Removed.
284         * icu/unicode/utypes.h: Removed.
285         * icu/unicode/uvernum.h: Removed.
286         * icu/unicode/uversion.h: Removed.
287
288 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
289
290         Add WebKitPrivateFrameworkStubs for iOS 11
291         https://bugs.webkit.org/show_bug.cgi?id=173988
292
293         Reviewed by David Kilzer.
294
295         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
296         use the same directory for private framework stubs.
297
298 2017-07-03  Matt Lewis  <jlewis3@apple.com>
299
300         Unreviewed, rolling out r219103.
301
302         Caused multiple build failures.
303
304         Reverted changeset:
305
306         "Remove copy of ICU headers from WebKit"
307         https://bugs.webkit.org/show_bug.cgi?id=116407
308         http://trac.webkit.org/changeset/219103
309
310 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
311
312         Remove copy of ICU headers from WebKit
313         https://bugs.webkit.org/show_bug.cgi?id=116407
314
315         Reviewed by Alex Christensen.
316
317         Use WTF's copy of ICU headers.
318
319         * Configurations/WebKitLegacy.xcconfig:
320         * icu/unicode/localpointer.h: Removed.
321         * icu/unicode/parseerr.h: Removed.
322         * icu/unicode/platform.h: Removed.
323         * icu/unicode/ptypes.h: Removed.
324         * icu/unicode/putil.h: Removed.
325         * icu/unicode/uchar.h: Removed.
326         * icu/unicode/uconfig.h: Removed.
327         * icu/unicode/ucurr.h: Removed.
328         * icu/unicode/uidna.h: Removed.
329         * icu/unicode/uiter.h: Removed.
330         * icu/unicode/umachine.h: Removed.
331         * icu/unicode/unorm.h: Removed.
332         * icu/unicode/unorm2.h: Removed.
333         * icu/unicode/urename.h: Removed.
334         * icu/unicode/uscript.h: Removed.
335         * icu/unicode/ustring.h: Removed.
336         * icu/unicode/utf.h: Removed.
337         * icu/unicode/utf16.h: Removed.
338         * icu/unicode/utf8.h: Removed.
339         * icu/unicode/utf_old.h: Removed.
340         * icu/unicode/utypes.h: Removed.
341         * icu/unicode/uvernum.h: Removed.
342         * icu/unicode/uversion.h: Removed.
343
344 2017-07-03  Brady Eidson  <beidson@apple.com>
345
346         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
347         https://bugs.webkit.org/show_bug.cgi?id=174073
348
349         Reviewed by Andy Estes.
350
351         WebView now keeps a direct copy of its main frame icon as a member variable.
352         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
353         
354         This change causes a progression in KVO observation of the mainFrameIcon property as we now
355         have both the old icon and new icon at the time it changes.
356
357         * WebCoreSupport/WebFrameLoaderClient.h:
358         * WebCoreSupport/WebFrameLoaderClient.mm:
359         (WebFrameLoaderClient::prepareForDataSourceReplacement):
360         (WebFrameLoaderClient::getLoadDecisionForIcons):
361         (WebFrameLoaderClient::finishedLoadingIcon):
362         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
363         (WebFrameLoaderClient::registerForIconNotification): Deleted.
364
365         * WebView/WebView.mm:
366         (+[WebView _setIconLoadingEnabled:]):
367         (+[WebView _isIconLoadingEnabled]):
368         (-[WebView mainFrameIcon]):
369         (-[WebView _setMainFrameIcon:]):
370         (-[WebView _receivedIconChangedNotification:]): Deleted.
371         (-[WebView _registerForIconNotification:]): Deleted.
372         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
373         * WebView/WebViewData.h:
374         * WebView/WebViewInternal.h:
375         * WebView/WebViewPrivate.h:
376
377 2017-07-03  Sam Weinig  <sam@webkit.org>
378
379         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
380         https://bugs.webkit.org/show_bug.cgi?id=174083
381
382         Reviewed by Alex Christensen.
383
384         * Configurations/FeatureDefines.xcconfig:
385         Add ENABLE_NAVIGATOR_STANDALONE.
386
387 2017-07-03  Tim Horton  <timothy_horton@apple.com>
388
389         Expose unobscuredSafeAreaInsets on WebView
390         https://bugs.webkit.org/show_bug.cgi?id=174075
391         <rdar://problem/33096997>
392
393         Reviewed by Beth Dakin.
394
395         * WebView/WebView.mm:
396         (-[WebView _setUnobscuredSafeAreaInsets:]):
397         (-[WebView _unobscuredSafeAreaInsets]):
398         * WebView/WebViewPrivate.h:
399         Expose unobscuredSafeAreaInsets as a new private property on WebView,
400         similar to how it is exposed in WebKit2.
401
402 2017-07-03  Andy Estes  <aestes@apple.com>
403
404         [Xcode] Add an experimental setting to build with ccache
405         https://bugs.webkit.org/show_bug.cgi?id=173875
406
407         Reviewed by Tim Horton.
408
409         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
410
411 2017-07-03  Tim Horton  <timothy_horton@apple.com>
412
413         Expose WebPreferences for viewport-fit and constant() properties
414         https://bugs.webkit.org/show_bug.cgi?id=174072
415         <rdar://problem/33096639>
416
417         Reviewed by Ryosuke Niwa.
418
419         * WebView/WebPreferenceKeysPrivate.h:
420         * WebView/WebPreferences.mm:
421         (-[WebPreferences viewportFitEnabled]):
422         (-[WebPreferences setViewportFitEnabled:]):
423         (-[WebPreferences constantPropertiesEnabled]):
424         (-[WebPreferences setConstantPropertiesEnabled:]):
425         * WebView/WebPreferencesPrivate.h:
426         * WebView/WebView.mm:
427         (-[WebView _preferencesChanged:]):
428
429 2017-07-01  Tim Horton  <timothy_horton@apple.com>
430
431         Expose viewport-fit value to UIKit via viewport arguments dictionary
432         https://bugs.webkit.org/show_bug.cgi?id=174071
433         <rdar://problem/33096620>
434
435         Reviewed by Wenson Hsieh.
436
437         * History/WebHistoryItem.mm:
438         * History/WebHistoryItemPrivate.h:
439         Add another dictionary key and three values.
440
441 2017-07-01  Dan Bernstein  <mitz@apple.com>
442
443         [iOS] Remove code only needed when building for iOS 9.x
444         https://bugs.webkit.org/show_bug.cgi?id=174068
445
446         Reviewed by Tim Horton.
447
448         * Configurations/FeatureDefines.xcconfig:
449
450 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
451
452         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
453         https://bugs.webkit.org/show_bug.cgi?id=174004
454
455         Reviewed by Simon Fraser.
456
457         * WebCoreSupport/WebPluginInfoProvider.mm:
458
459 2017-07-01  Dan Bernstein  <mitz@apple.com>
460
461         [macOS] Remove code only needed when building for OS X Yosemite
462         https://bugs.webkit.org/show_bug.cgi?id=174067
463
464         Reviewed by Tim Horton.
465
466         * Configurations/Base.xcconfig:
467         * Configurations/DebugRelease.xcconfig:
468         * Configurations/FeatureDefines.xcconfig:
469         * Configurations/Version.xcconfig:
470         * Plugins/WebBasePluginPackage.mm:
471         (-[WebBasePluginPackage getPluginInfoFromPLists]):
472         * WebCoreSupport/PopupMenuMac.mm:
473         (PopupMenuMac::show):
474         * WebCoreSupport/WebInspectorClient.mm:
475         (WebInspectorFrontendClient::startWindowDrag):
476         (-[WebInspectorWindowController window]):
477         * WebView/WebView.mm:
478         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
479
480 2017-06-30  Daniel Bates  <dabates@apple.com>
481
482         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
483         https://bugs.webkit.org/show_bug.cgi?id=165160
484         <rdar://problem/29451999>
485
486         Reviewed by Brady Eidson.
487
488         Pass the document that is requesting the load to the loader.
489
490         * WebView/WebPDFView.mm:
491         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
492
493 2017-06-29  Jer Noble  <jer.noble@apple.com>
494
495         Make Legacy EME API controlled by RuntimeEnabled setting.
496         https://bugs.webkit.org/show_bug.cgi?id=173994
497
498         Reviewed by Sam Weinig.
499
500         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
501
502         * Configurations/FeatureDefines.xcconfig:
503         * WebView/WebPreferenceKeysPrivate.h:
504         * WebView/WebPreferences.mm:
505         (+[WebPreferences initialize]):
506         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
507         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
508         * WebView/WebPreferencesPrivate.h:
509         * WebView/WebView.mm:
510         (-[WebView _preferencesChanged:]):
511
512 2017-06-30  Chris Dumez  <cdumez@apple.com>
513
514         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
515         https://bugs.webkit.org/show_bug.cgi?id=174013
516
517         Reviewed by Brent Fulgham.
518
519         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
520         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
521
522         * WebView/WebView.mm:
523         (-[WebView _commonInitializationWithFrameName:groupName:]):
524
525 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
526
527         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
528         https://bugs.webkit.org/show_bug.cgi?id=174017
529         <rdar://problem/32959782>
530
531         Reviewed by Simon Fraser.
532
533         Use root view coordinates when computing the drag caret rect.
534
535         * WebView/WebView.mm:
536         (-[WebView _dataInteractionCaretRect]):
537
538 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
539
540         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
541         https://bugs.webkit.org/show_bug.cgi?id=173899
542         rdar://problem/32994474
543
544         Reviewed by Tim Horton.
545
546         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
547         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
548         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
549
550         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
551         documentView is a WebHTMLView.
552
553         * WebView/WebFrame.mm:
554         (-[WebFrame _webHTMLDocumentView]):
555         (-[WebFrame _paintBehaviorForDestinationContext:]):
556         (-[WebFrame _drawRect:contentsOnly:]):
557         (-[WebFrame setTimeoutsPaused:]):
558         (-[WebFrame prepareForPause]):
559         (-[WebFrame resumeFromPause]):
560         (-[WebFrame resetTextAutosizingBeforeLayout]):
561         * WebView/WebHTMLView.mm:
562         (-[WebHTMLView drawLayer:inContext:]):
563         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
564         * WebView/WebHTMLViewInternal.h:
565
566 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
567
568         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
569         https://bugs.webkit.org/show_bug.cgi?id=173854
570         <rdar://problem/32236827>
571
572         Reviewed by Ryosuke Niwa and Tim Horton.
573
574         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
575         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
576
577         * WebView/WebView.mm:
578         (-[WebView _startDrag:]):
579         (-[WebView _dragSourceAction]):
580         (-[WebView _draggedLinkTitle]):
581         (-[WebView _draggedLinkURL]):
582         (-[WebView _draggedElementBounds]):
583         (-[WebView _endedDataInteraction:global:]):
584         * WebView/WebViewData.h:
585         * WebView/WebViewPrivate.h:
586
587 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         Refactor drag start codepaths to plumb a DragItem to client layers
590         https://bugs.webkit.org/show_bug.cgi?id=173832
591         Work towards <rdar://problem/32236827>
592
593         Reviewed by Ryosuke Niwa and Tim Horton.
594
595         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
596         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
597         to _startDrag: to match logic used to start a drag on other platforms.
598
599         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
600         through the DragItem struct.
601
602         * WebCoreSupport/WebDragClient.h:
603         * WebCoreSupport/WebDragClient.mm:
604         (WebDragClient::startDrag):
605         (WebDragClient::dragSourceActionMaskForPoint):
606         (WebDragClient::willPerformDragSourceAction):
607         (WebDragClient::beginDrag):
608         * WebView/WebView.mm:
609         (-[WebView _startDrag:]):
610         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
611         * WebView/WebViewInternal.h:
612
613 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
614
615         Remove excessive headers from JavaScriptCore
616         https://bugs.webkit.org/show_bug.cgi?id=173812
617
618         Reviewed by Darin Adler.
619
620         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
621         * WebView/WebView.mm:
622
623 2017-06-23  Tim Horton  <timothy_horton@apple.com>
624
625         Remove an unused typedef from WebFrameLoaderClient
626         https://bugs.webkit.org/show_bug.cgi?id=173795
627
628         Reviewed by Simon Fraser.
629
630         * WebCoreSupport/WebFrameLoaderClient.h:
631         This unused typedef in the global namespace conflicts with one in a macOS system header.
632         Also... it's unused.
633         Remove it.
634
635 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
636
637         Remove excessive headers from WebCore/{bindings,css,dom}
638         https://bugs.webkit.org/show_bug.cgi?id=173766
639
640         Reviewed by Simon Fraser.
641
642         * DOM/DOMInternal.mm:
643
644 2017-06-22  Daniel Bates  <dabates@apple.com>
645
646         Make FrameLoadRequest a move-only type
647         https://bugs.webkit.org/show_bug.cgi?id=173682
648
649         Reviewed by Alex Christensen and Darin Adler.
650
651         A FrameLoadRequest groups together the information to perform a load into a single object
652         that is more manageable to pass around than its constituent parts. Code that receives a
653         FrameLoadRequest is expected to extract out the information it needs to complete its task.
654         And it does not make sense to re-use the same FrameLoadRequest object for more than one
655         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
656
657         * Plugins/WebPluginController.mm:
658         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
659         * WebView/WebPDFView.mm:
660         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
661
662 2017-06-21  Antoine Quint  <graouts@apple.com>
663
664         Ensure DRT always logs rAF suspension debugging code
665         https://bugs.webkit.org/show_bug.cgi?id=173681
666
667         Reviewed by Tim "Mr. T" Horton.
668
669         * WebView/WebPreferenceKeysPrivate.h:
670         * WebView/WebPreferences.mm:
671         (+[WebPreferences initialize]):
672         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
673         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
674         * WebView/WebPreferencesPrivate.h:
675         * WebView/WebView.mm:
676         (-[WebView _preferencesChanged:]):
677
678 2017-06-21  Daniel Bates  <dabates@apple.com>
679
680         Cleanup FrameLoadRequest
681         https://bugs.webkit.org/show_bug.cgi?id=173564
682         <rdar://problem/32903570>
683
684         Reviewed by Brent Fulgham.
685
686         * WebView/WebPDFView.mm:
687         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
688         into a local variable and use C++11 brace initialization syntax to make it easier to identify
689         the arguments passed to FrameLoader::loadFrameRequest().
690
691 2017-06-21  Antoine Quint  <graouts@apple.com>
692
693         Add logging to identify when the Page suspends scripted animations
694         https://bugs.webkit.org/show_bug.cgi?id=173626
695
696         Reviewed by Tim Horton.
697
698         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
699         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
700
701         * WebView/WebPreferenceKeysPrivate.h:
702         * WebView/WebPreferences.mm:
703         (+[WebPreferences initialize]):
704         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
705         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
706         * WebView/WebPreferencesPrivate.h:
707         * WebView/WebView.mm:
708         (-[WebView _preferencesChanged:]):
709
710 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
711
712         Disable font variations on macOS Sierra and iOS 10
713         https://bugs.webkit.org/show_bug.cgi?id=173618
714         <rdar://problem/32879164>
715
716         Reviewed by Jon Lee.
717
718         * Configurations/FeatureDefines.xcconfig:
719
720 2017-06-20  Daniel Bates  <dabates@apple.com>
721
722         Have FrameLoadRequest takes a Frame& instead of a Frame*
723         https://bugs.webkit.org/show_bug.cgi?id=173614
724         <rdar://problem/32884890>
725
726         Reviewed by Brent Fulgham.
727
728         * Plugins/WebPluginController.mm:
729         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
730         * WebView/WebFrame.mm:
731         (-[WebFrame loadRequest:]):
732         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
733
734 2017-06-19  Frederic Wang  <fwang@igalia.com>
735
736         [Mac] Add an experimental feature setting for async frame scrolling
737         https://bugs.webkit.org/show_bug.cgi?id=173359
738
739         Reviewed by Simon Fraser.
740
741         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
742         * WebView/WebPreferences.mm:
743         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
744         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
745         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
746         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
747         * WebView/WebView.mm:
748         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
749         scrolling.
750
751 2017-06-19  Chris Dumez  <cdumez@apple.com>
752
753         Use WTF::Function instead of std::function in more places in WebCore/
754         https://bugs.webkit.org/show_bug.cgi?id=173535
755
756         Reviewed by Antti Koivisto.
757
758         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
759
760         * WebCoreSupport/WebFrameLoaderClient.h:
761         * WebCoreSupport/WebFrameLoaderClient.mm:
762         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
763         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
764         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
765         (WebFrameLoaderClient::dispatchWillSubmitForm):
766         (WebFrameLoaderClient::setUpPolicyListener):
767         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
768         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
769
770 2017-05-14 Frederic Wang  <fwang@igalia.com>
771
772         Add heuristic to avoid flattening "fullscreen" iframes
773         https://bugs.webkit.org/show_bug.cgi?id=171914
774
775         Reviewed by Simon Fraser.
776
777         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
778
779         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
780         * WebView/WebPreferences.mm:
781         (+[WebPreferences initialize]): Handle frame flattening as an enum.
782         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
783         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
784         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
785         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
786         * WebView/WebPreferencesPrivate.h: Ditto.
787         * WebView/WebView.mm:
788         (-[WebView _preferencesChanged:]): Ditto.
789         * WebView/WebPreferencesPrivate.h: Add new enum definition.
790
791 2017-06-17  Chris Dumez  <cdumez@apple.com>
792
793         Use WTF::Function instead of std::function in WebKit2/
794         https://bugs.webkit.org/show_bug.cgi?id=173504
795
796         Reviewed by Darin Adler.
797
798         Use WTF::Function instead of std::function in WebKit2/ to avoid
799         unnecessary copying.
800
801         * Plugins/Hosted/HostedNetscapePluginStream.h:
802         * Plugins/Hosted/HostedNetscapePluginStream.mm:
803         (WebKit::HostedNetscapePluginStream::willSendRequest):
804         * Plugins/WebNetscapePluginStream.h:
805         * Plugins/WebNetscapePluginStream.mm:
806         (WebNetscapePluginStream::willSendRequest):
807         * WebCoreSupport/WebPaymentCoordinatorClient.h:
808         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
809         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
810         (WebPaymentCoordinatorClient::openPaymentSetup):
811
812 2017-06-16  Sam Weinig  <sam@webkit.org>
813
814         [WebIDL] Remove custom bindings for HTMLDocument
815         https://bugs.webkit.org/show_bug.cgi?id=173444
816
817         Reviewed by Darin Adler.
818
819         * DOM/DOMHTMLDocument.mm:
820         (-[DOMHTMLDocument linkColor]):
821         (-[DOMHTMLDocument setLinkColor:]):
822         (-[DOMHTMLDocument write:]):
823         (-[DOMHTMLDocument writeln:]):
824         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
825
826 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
827
828         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
829         https://bugs.webkit.org/show_bug.cgi?id=173366
830         <rdar://problem/32767014>
831
832         Reviewed by Tim Horton.
833
834         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
835
836         * Configurations/FeatureDefines.xcconfig:
837         * WebCoreSupport/WebDragClient.mm:
838         (WebDragClient::useLegacyDragClient):
839         (WebDragClient::willPerformDragDestinationAction):
840         (WebDragClient::dragSourceActionMaskForPoint):
841         (WebDragClient::willPerformDragSourceAction):
842         (WebDragClient::startDrag):
843         (WebDragClient::beginDrag):
844         (WebDragClient::declareAndWriteDragImage):
845         (WebDragClient::declareAndWriteAttachment):
846         (WebDragClient::didConcludeEditDrag):
847         * WebView/WebView.mm:
848         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
849         (-[WebView _getDataInteractionData]):
850         (-[WebView dragDataForSession:client:global:operation:]):
851         (-[WebView _enteredDataInteraction:client:global:operation:]):
852         (-[WebView _updatedDataInteraction:client:global:operation:]):
853         (-[WebView _exitedDataInteraction:client:global:operation:]):
854         (-[WebView _performDataInteraction:client:global:operation:]):
855         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
856         (-[WebView _endedDataInteraction:global:]):
857         (-[WebView _didConcludeEditDataInteraction]):
858         (floatRectsForCGRectArray): Deleted.
859         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
860         * WebView/WebViewData.h:
861         * WebView/WebViewData.mm:
862         (-[WebViewPrivate dealloc]):
863         * WebView/WebViewPrivate.h:
864
865 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
866
867         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
868         https://bugs.webkit.org/show_bug.cgi?id=173454
869         <rdar://problem/31720671>
870
871         Reviewed by Tim Horton.
872
873         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
874         If unimplemented, the default UI delegate allows all actions except for URL loading.
875
876         * DefaultDelegates/WebDefaultUIDelegate.mm:
877         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
878         * WebView/WebUIDelegatePrivate.h:
879         * WebView/WebView.mm:
880         (-[WebView dragDestinationActionMaskForSession:]):
881
882 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
883
884         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
885         https://bugs.webkit.org/show_bug.cgi?id=173338
886         <rdar://problem/32777720>
887
888         Reviewed by Tim Horton.
889
890         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
891
892         * WebCoreSupport/WebPlatformStrategies.h:
893         * WebCoreSupport/WebPlatformStrategies.mm:
894         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
895         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
896
897 2017-06-13  Daniel Bates  <dabates@apple.com>
898
899         Implement W3C Secure Contexts Draft Specification
900         https://bugs.webkit.org/show_bug.cgi?id=158121
901         <rdar://problem/26012994>
902
903         Reviewed by Brent Fulgham.
904
905         Part 4
906
907         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
908
909         * WebView/WebPreferenceKeysPrivate.h:
910         * WebView/WebPreferences.mm:
911         (+[WebPreferences initialize]):
912         (-[WebPreferences isSecureContextAttributeEnabled]):
913         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
914         * WebView/WebPreferencesPrivate.h:
915         * WebView/WebView.mm:
916         (-[WebView _preferencesChanged:]):
917
918 2017-06-13  Sam Weinig  <sam@webkit.org>
919
920         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
921         https://bugs.webkit.org/show_bug.cgi?id=80733
922
923         Reviewed by Chris Dumez.
924
925         * DOM/DOMUtility.mm:
926         (createDOMWrapper):
927         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
928         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
929         * WebView/WebFrame.mm:
930         (-[WebFrame _attachScriptDebugger]):
931         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
932
933 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
934
935         [WebCrypto] Remove experimental feature flag of SubtleCrypto
936         https://bugs.webkit.org/show_bug.cgi?id=173197
937         <rdar://problem/32688148>
938
939         Reviewed by Brent Fulgham.
940
941         * WebView/WebPreferences.mm:
942         (+[WebPreferences initialize]):
943         (-[WebPreferences subtleCryptoEnabled]): Deleted.
944         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
945         * WebView/WebPreferencesPrivate.h:
946         * WebView/WebView.mm:
947         (-[WebView _preferencesChanged:]):
948
949 2017-06-10  Dan Bernstein  <mitz@apple.com>
950
951         Reverted r218056 because it made the IDE reindex constantly.
952
953         * Configurations/DebugRelease.xcconfig:
954
955 2017-06-10  Dan Bernstein  <mitz@apple.com>
956
957         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
958         https://bugs.webkit.org/show_bug.cgi?id=173223
959
960         Reviewed by Sam Weinig.
961
962         The rebuilds were happening due to a difference in the compiler options that the IDE and
963         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
964         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
965         specify an appropriate path in CLANG_INDEX_STORE_PATH.
966
967         * Configurations/DebugRelease.xcconfig:
968
969 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
970
971         [iOS DnD] Add a hook to perform two-step drops in editable content
972         https://bugs.webkit.org/show_bug.cgi?id=172992
973         <rdar://problem/32590174>
974
975         Reviewed by Tim Horton.
976
977         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
978         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
979         returning NO will continue with default WebKit behavior.
980
981         * WebCoreSupport/WebEditorClient.h:
982         * WebCoreSupport/WebEditorClient.mm:
983         (WebEditorClient::performTwoStepDrop):
984
985 2017-06-08  Jer Noble  <jer.noble@apple.com>
986
987         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
988         https://bugs.webkit.org/show_bug.cgi?id=173091
989
990         Reviewed by Eric Carlson.
991
992         * WebView/WebPreferences.mm:
993         (+[WebPreferences initialize]):
994
995 2017-06-07  Jer Noble  <jer.noble@apple.com>
996
997         Clean-up: RenderElement.h includes headers it doesn't use
998         https://bugs.webkit.org/show_bug.cgi?id=173046
999
1000         Reviewed by Andy Estes.
1001
1002         * WebView/WebImmediateActionController.mm:
1003
1004 2017-06-07  Zalan Bujtas  <zalan@apple.com>
1005
1006         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
1007         https://bugs.webkit.org/show_bug.cgi?id=173044
1008         <rdar://problem/32449338>
1009
1010         Reviewed by Tim Horton.
1011
1012         Cache the current device orientation so that we don't have to lift the WebThread lock
1013         to collect it.
1014
1015         * WebView/WebFrame.mm:
1016         (-[WebFrame deviceOrientationChanged]):
1017         * WebView/WebView.mm:
1018         (-[WebView _commonInitializationWithFrameName:groupName:]):
1019         (-[WebView _setDeviceOrientation:]):
1020         (-[WebView _deviceOrientation]):
1021         * WebView/WebViewData.h:
1022         * WebView/WebViewInternal.h:
1023
1024 2017-06-06  Jer Noble  <jer.noble@apple.com>
1025
1026         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
1027         https://bugs.webkit.org/show_bug.cgi?id=173008
1028
1029         Reviewed by Eric Carlson.
1030
1031         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
1032
1033         * WebView/WebPreferenceKeysPrivate.h:
1034         * WebView/WebPreferences.mm:
1035         (+[WebPreferences initialize]):
1036         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1037         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1038         * WebView/WebPreferencesPrivate.h:
1039         * WebView/WebView.mm:
1040         (-[WebView _preferencesChanged:]):
1041
1042 2017-06-06  Youenn Fablet  <youenn@apple.com>
1043
1044         Add an option to disable getUserMedia prompt in case of mock capture sources
1045         https://bugs.webkit.org/show_bug.cgi?id=172981
1046         <rdar://problem/32580325>
1047
1048         Reviewed by Eric Carlson.
1049
1050         Defining the option, getter and setter.
1051
1052         * WebView/WebPreferences.mm:
1053         (+[WebPreferences initialize]):
1054         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
1055         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
1056         * WebView/WebPreferencesPrivate.h:
1057
1058 2017-06-05  Dan Bernstein  <mitz@apple.com>
1059
1060         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
1061
1062         * WebView/WebView.mm:
1063         (-[WebView updateMediaTouchBar]):
1064         * WebView/WebViewData.h:
1065
1066 2017-06-03  Darin Adler  <darin@apple.com>
1067
1068         Streamline handling of attributes, using references as much as possible
1069         https://bugs.webkit.org/show_bug.cgi?id=172899
1070
1071         Reviewed by Chris Dumez.
1072
1073         * WebView/WebHTMLRepresentation.mm:
1074         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
1075         passed in element can't be null. Removed unnecessary conversion from NSString to String
1076         and then back to NSString.
1077
1078 2017-06-01  Andy Estes  <aestes@apple.com>
1079
1080         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1081         https://bugs.webkit.org/show_bug.cgi?id=172828
1082
1083         Reviewed by Beth Dakin.
1084
1085         * Configurations/FeatureDefines.xcconfig:
1086
1087 2017-05-31  Andy Estes  <aestes@apple.com>
1088
1089         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1090         https://bugs.webkit.org/show_bug.cgi?id=172366
1091
1092         Reviewed by Daniel Bates.
1093
1094         * Configurations/FeatureDefines.xcconfig:
1095
1096 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1097
1098         Only include DataDetectorsUI headers in iOS
1099         https://bugs.webkit.org/show_bug.cgi?id=172633
1100
1101         Reviewed by David Kilzer.
1102
1103         Enable data detectors only on iOS and not other variants of iOS.
1104
1105         * WebCoreSupport/WebFrameLoaderClient.mm:
1106
1107 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1108
1109         Update libwebrtc configuration
1110         https://bugs.webkit.org/show_bug.cgi?id=172727
1111
1112         Reviewed by Geoffrey Garen.
1113
1114         * Configurations/FeatureDefines.xcconfig:
1115
1116 2017-05-28  Dan Bernstein  <mitz@apple.com>
1117
1118         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1119         https://bugs.webkit.org/show_bug.cgi?id=172691
1120
1121         Reviewed by Tim Horton.
1122
1123         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1124
1125 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
1126
1127         [WK2] Address thread safety issues with ResourceLoadStatistics
1128         https://bugs.webkit.org/show_bug.cgi?id=172519
1129         <rdar://problem/31707642>
1130
1131         Reviewed by Chris Dumez.
1132
1133         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
1134
1135         * WebView/WebView.mm:
1136         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
1137
1138 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1139
1140         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1141         https://bugs.webkit.org/show_bug.cgi?id=172554
1142         <rdar://problem/31247133>
1143
1144         Reviewed by Simon Fraser.
1145
1146         Update an overridden internal AppKit function to the new signature.
1147
1148         * WebView/WebHTMLView.mm:
1149         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
1150         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1151         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
1152         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1153
1154 2017-05-24  Jer Noble  <jer.noble@apple.com>
1155
1156         Rename DisplaySleepDisabler -> SleepDisabler
1157         https://bugs.webkit.org/show_bug.cgi?id=172478
1158
1159         Reviewed by Sam Weinig.
1160
1161         * WebView/WebFullScreenController.h:
1162
1163 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
1164
1165         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
1166         https://bugs.webkit.org/show_bug.cgi?id=172522
1167         rdar://problem/31071812
1168
1169         Reviewed by Tim Horton.
1170
1171         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
1172         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
1173         versions this synchronization is no longer required.
1174
1175         * WebView/WebView.mm:
1176         (LayerFlushController::flushLayers):
1177
1178 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
1179
1180         Snapshotting via -renderInContext: should do synchronous image decodes
1181         https://bugs.webkit.org/show_bug.cgi?id=172485
1182         rdar://problem/32276146
1183
1184         Reviewed by Tim Horton.
1185
1186         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
1187         has any callers.
1188
1189         * Plugins/WebBaseNetscapePluginView.h:
1190         * Plugins/WebBaseNetscapePluginView.mm:
1191         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
1192         * WebView/WebFrame.mm:
1193         (-[WebFrame _paintBehaviorForDestinationContext:]):
1194         (-[WebFrame _drawRect:contentsOnly:]):
1195         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
1196         * WebView/WebHTMLView.mm:
1197         (imageFromRect):
1198         * WebView/WebView.mm:
1199         (-[WebView _commonInitializationWithFrameName:groupName:]):
1200         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
1201         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
1202         * WebView/WebViewData.h:
1203         * WebView/WebViewPrivate.h:
1204
1205 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
1206
1207         Remove dead ENABLE(FONT_LOAD_EVENTS) code
1208         https://bugs.webkit.org/show_bug.cgi?id=172517
1209
1210         Rubber-stamped by Simon Fraser.
1211
1212         * Configurations/FeatureDefines.xcconfig:
1213
1214 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1215
1216         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1217         https://bugs.webkit.org/show_bug.cgi?id=171984
1218
1219         Reviewed by Antti Koivisto.
1220
1221         * WebView/WebPreferenceKeysPrivate.h:
1222         * WebView/WebPreferences.mm:
1223         (+[WebPreferences initialize]):
1224         (-[WebPreferences displayContentsEnabled]):
1225         (-[WebPreferences setDisplayContentsEnabled:]):
1226         * WebView/WebPreferencesPrivate.h:
1227         * WebView/WebView.mm:
1228         (-[WebView _preferencesChanged:]):
1229
1230 2017-05-22  Youenn Fablet  <youenn@apple.com>
1231
1232         Remove AVAudioCaptureSource
1233         https://bugs.webkit.org/show_bug.cgi?id=172360
1234
1235         Reviewed by Sam Weinig.
1236
1237         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1238
1239         * WebView/WebPreferenceKeysPrivate.h:
1240         * WebView/WebPreferences.mm:
1241         (+[WebPreferences initialize]):
1242         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1243         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1244         * WebView/WebPreferencesPrivate.h:
1245         * WebView/WebView.mm:
1246         (-[WebView _preferencesChanged:]):
1247
1248 2017-05-22  Sam Weinig  <sam@webkit.org>
1249
1250         [WebIDL] Support callbacks with arbitrary return types
1251         https://bugs.webkit.org/show_bug.cgi?id=172407
1252
1253         Reviewed by Chris Dumez.
1254
1255         * DOM/DOM.mm:
1256         (-[DOMNodeFilter acceptNode:]):
1257         Update for CallbackResult adoption in the base class.
1258
1259         * DOM/DOMNodeIterator.mm:
1260         * DOM/DOMTreeWalker.mm:
1261         Update to account for new WebCore implementation return types. We return nil
1262         if there was an exception, since retains the existing behavior if a javascript
1263         NodeFilter had been used (an exception would cause all nodes to be rejected,
1264         thus returning nullptr).
1265
1266         * DOM/ObjCNodeFilterCondition.h:
1267         * DOM/ObjCNodeFilterCondition.mm:
1268         Update to match new interface of NodeFilterCondition.
1269
1270 2017-05-18  Sam Weinig  <sam@webkit.org>
1271
1272         [WebIDL] Remove the need for the generator to know about native type mapping
1273         https://bugs.webkit.org/show_bug.cgi?id=172310
1274
1275         Reviewed by Darin Adler.
1276
1277         * DOM/DOM.mm:
1278         (-[DOMNodeFilter acceptNode:]):
1279         Update to pass Node by reference.
1280
1281 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1282
1283         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1284         https://bugs.webkit.org/show_bug.cgi?id=172098
1285
1286         Reviewed by Saam Barati.
1287
1288         * Plugins/Hosted/ProxyInstance.mm:
1289         * Plugins/Hosted/ProxyRuntimeObject.mm:
1290
1291 2017-05-18  Andy Estes  <aestes@apple.com>
1292
1293         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1294         https://bugs.webkit.org/show_bug.cgi?id=172305
1295
1296         Reviewed by Anders Carlsson.
1297
1298         * Configurations/FeatureDefines.xcconfig:
1299
1300 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1301
1302         Unreviewed, rolling out r217031, r217032, and r217037.
1303         https://bugs.webkit.org/show_bug.cgi?id=172293
1304
1305         cause linking errors in Windows (Requested by yusukesuzuki on
1306         #webkit).
1307
1308         Reverted changesets:
1309
1310         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1311         https://bugs.webkit.org/show_bug.cgi?id=172098
1312         http://trac.webkit.org/changeset/217031
1313
1314         "Unreviewed, rebaseline for newly added ClassInfo"
1315         https://bugs.webkit.org/show_bug.cgi?id=172098
1316         http://trac.webkit.org/changeset/217032
1317
1318         "Unreviewed, fix debug and non-JIT build"
1319         https://bugs.webkit.org/show_bug.cgi?id=172098
1320         http://trac.webkit.org/changeset/217037
1321
1322 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1323
1324         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1325         https://bugs.webkit.org/show_bug.cgi?id=172098
1326
1327         Reviewed by Saam Barati.
1328
1329         * Plugins/Hosted/ProxyInstance.mm:
1330         * Plugins/Hosted/ProxyRuntimeObject.mm:
1331
1332 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1333
1334         Unreviewed, rolling out r216974.
1335
1336         Revision caused consistent timeouts on all platforms.
1337
1338         Reverted changeset:
1339
1340         "Add a RuntimeEnabledFeature for display: contents, defaulted
1341         to false."
1342         https://bugs.webkit.org/show_bug.cgi?id=171984
1343         http://trac.webkit.org/changeset/216974
1344
1345 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1346
1347         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1348         https://bugs.webkit.org/show_bug.cgi?id=171984
1349
1350         Reviewed by Antti Koivisto.
1351
1352         * WebView/WebPreferenceKeysPrivate.h:
1353         * WebView/WebPreferences.mm:
1354         (+[WebPreferences initialize]):
1355         (-[WebPreferences displayContentsEnabled]):
1356         (-[WebPreferences setDisplayContentsEnabled:]):
1357         * WebView/WebPreferencesPrivate.h:
1358         * WebView/WebView.mm:
1359         (-[WebView _preferencesChanged:]):
1360
1361 2017-05-16  Sam Weinig  <sam@webkit.org>
1362
1363         Bring Notification.idl up to spec
1364         https://bugs.webkit.org/show_bug.cgi?id=172156
1365
1366         Reviewed by Chris Dumez.
1367
1368         * WebCoreSupport/WebNotificationClient.h:
1369         * WebCoreSupport/WebNotificationClient.mm:
1370         (generateNotificationID):
1371         (WebNotificationClient::show):
1372         (WebNotificationClient::cancel):
1373         (WebNotificationClient::clearNotifications):
1374         (WebNotificationClient::notificationObjectDestroyed):
1375         (WebNotificationClient::requestPermission):
1376         (WebNotificationClient::hasPendingPermissionRequests):
1377         (WebNotificationClient::checkPermission):
1378         (-[WebNotificationPolicyListener allow]):
1379         (-[WebNotificationPolicyListener deny]):
1380         * WebView/WebNotification.mm:
1381         (-[WebNotification iconURL]):
1382         (-[WebNotification dir]):
1383         Simplify #ifdefs and update for enum vs String usage.
1384
1385 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1386
1387         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1388         https://bugs.webkit.org/show_bug.cgi?id=170640
1389
1390         Reviewed by Simon Fraser.
1391
1392         Enable the async decoding for large images.
1393
1394         * WebView/WebView.mm:
1395         (-[WebView _preferencesChanged:]):
1396
1397 2017-05-15  Jer Noble  <jer.noble@apple.com>
1398
1399         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1400         https://bugs.webkit.org/show_bug.cgi?id=172131
1401
1402         Reviewed by Eric Carlson.
1403
1404         * WebView/WebPreferenceKeysPrivate.h:
1405         * WebView/WebPreferences.mm:
1406         (+[WebPreferences initialize]):
1407         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1408         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1409         * WebView/WebPreferencesPrivate.h:
1410
1411 2017-05-12  Chris Dumez  <cdumez@apple.com>
1412
1413         Drop uses of PassRefPtr in WebKit/mac
1414         https://bugs.webkit.org/show_bug.cgi?id=172066
1415
1416         Reviewed by Sam Weinig.
1417
1418         * History/WebBackForwardListInternal.h:
1419         * History/WebHistoryItem.mm:
1420         (kit):
1421         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1422         * History/WebHistoryItemInternal.h:
1423         * Plugins/Hosted/HostedNetscapePluginStream.h:
1424         (WebKit::HostedNetscapePluginStream::create):
1425         * Plugins/Hosted/NetscapePluginHostManager.h:
1426         * Plugins/Hosted/NetscapePluginHostManager.mm:
1427         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1428         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1429         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1430         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1431         (WebKit::NetscapePluginInstanceProxy::create):
1432         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1433         * Plugins/Hosted/ProxyInstance.h:
1434         (WebKit::ProxyInstance::create):
1435         * Plugins/Hosted/ProxyInstance.mm:
1436         (WebKit::ProxyInstance::ProxyInstance):
1437         (WebKit::ProxyInstance::newRuntimeObject):
1438         * Plugins/Hosted/ProxyRuntimeObject.h:
1439         (WebKit::ProxyRuntimeObject::create):
1440         * Plugins/Hosted/ProxyRuntimeObject.mm:
1441         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1442         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1443         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1444         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1445         * Plugins/WebBaseNetscapePluginView.h:
1446         * Plugins/WebBaseNetscapePluginView.mm:
1447         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1448         * Plugins/WebNetscapePluginStream.h:
1449         (WebNetscapePluginStream::create):
1450         * Plugins/WebNetscapePluginView.h:
1451         * Plugins/WebNetscapePluginView.mm:
1452         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1453         * WebCoreSupport/WebChromeClient.mm:
1454         * WebCoreSupport/WebEditorClient.mm:
1455         * WebCoreSupport/WebNotificationClient.mm:
1456         (WebNotificationClient::requestPermission):
1457         (-[WebNotificationPolicyListener initWithCallback:]):
1458         * WebCoreSupport/WebOpenPanelResultListener.mm:
1459         * WebCoreSupport/WebUserMediaClient.mm:
1460         (WebUserMediaClient::requestUserMediaAccess):
1461         (WebUserMediaClient::enumerateMediaDevices):
1462         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1463         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1464         * WebView/WebArchive.mm:
1465         (-[WebArchivePrivate initWithCoreArchive:]):
1466         (-[WebArchivePrivate setCoreArchive:]):
1467         (-[WebArchive initWithData:]):
1468         (-[WebArchive subframeArchives]):
1469         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1470         * WebView/WebArchiveInternal.h:
1471         * WebView/WebDataSource.mm:
1472         (WebDataSourcePrivate::WebDataSourcePrivate):
1473         (WebDataSourcePrivate::~WebDataSourcePrivate):
1474         (-[WebDataSource _initWithDocumentLoader:]):
1475         * WebView/WebDataSourceInternal.h:
1476         * WebView/WebDeviceOrientation.mm:
1477         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1478         * WebView/WebDeviceOrientationInternal.h:
1479         * WebView/WebFrame.mm:
1480         (-[WebFrame _convertToDOMRange:]):
1481         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1482         * WebView/WebFrameInternal.h:
1483         * WebView/WebFullScreenController.h:
1484         * WebView/WebFullScreenController.mm:
1485         (-[WebFullScreenController setElement:]):
1486         * WebView/WebGeolocationPosition.mm:
1487         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1488         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1489         * WebView/WebHTMLView.mm:
1490         (currentKeyboardEvent):
1491         * WebView/WebResource.mm:
1492         * WebView/WebScriptWorld.mm:
1493         (-[WebScriptWorld initWithWorld:]):
1494         (+[WebScriptWorld standardWorld]):
1495         (+[WebScriptWorld findOrCreateWorld:]):
1496         * WebView/WebViewData.h:
1497         (LayerFlushController::create):
1498
1499 2017-05-11  Chris Dumez  <cdumez@apple.com>
1500
1501         Drop remaining uses of PassRefPtr in WebCore
1502         https://bugs.webkit.org/show_bug.cgi?id=172013
1503
1504         Reviewed by Yusuke Suzuki.
1505
1506         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1507         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1508         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1509         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1510         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1511         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1512
1513 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1514
1515         Mail spins launching spell checker when typing
1516         https://bugs.webkit.org/show_bug.cgi?id=171986
1517         <rdar://problem/26305327>
1518
1519         Reviewed by Beth Dakin.
1520
1521         * WebView/WebView.mm:
1522         (-[WebView setEditable:]):
1523         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1524
1525 2017-05-09  Sam Weinig  <sam@webkit.org>
1526
1527         Remove support for legacy Notifications
1528         https://bugs.webkit.org/show_bug.cgi?id=171487
1529
1530         Reviewed by Jon Lee.
1531
1532         * Configurations/FeatureDefines.xcconfig:
1533         * WebCoreSupport/WebNotificationClient.h:
1534         * WebCoreSupport/WebNotificationClient.mm:
1535         * WebView/WebNotification.mm:
1536         * WebView/WebNotificationInternal.h:
1537         * WebView/WebView.mm:
1538         (-[WebView _commonInitializationWithFrameName:groupName:]):
1539         (-[WebView _notificationIDForTesting:]):
1540         Remove legacy notification specific code.
1541
1542 2017-05-10  Chris Dumez  <cdumez@apple.com>
1543
1544         Simplify relationship between Attr and Element now that Attr is childless
1545         https://bugs.webkit.org/show_bug.cgi?id=171909
1546
1547         Reviewed by Ryosuke Niwa.
1548
1549         Build fix.
1550
1551         * DOM/DOMAttr.mm:
1552         (-[DOMAttr value]):
1553         (-[DOMAttr setValue:]):
1554
1555 2017-05-08  Chris Dumez  <cdumez@apple.com>
1556
1557         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1558         https://bugs.webkit.org/show_bug.cgi?id=171795
1559
1560         Reviewed by Alex Christensen.
1561
1562         Build fix.
1563
1564         * DOM/DOMElement.mm:
1565         (-[DOMElement style]):
1566         * WebCoreSupport/WebEditorClient.mm:
1567         (WebEditorClient::shouldApplyStyle):
1568         * WebView/WebFrame.mm:
1569         (-[WebFrame _typingStyle]):
1570
1571 2017-05-06  Chris Dumez  <cdumez@apple.com>
1572
1573         Align our IDL files with the latest DOM specification
1574         https://bugs.webkit.org/show_bug.cgi?id=171777
1575
1576         Reviewed by Sam Weinig.
1577
1578         Build fix.
1579
1580         * DOM/DOMDocument.mm:
1581         (-[DOMDocument readyState]):
1582
1583 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1584
1585         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1586         https://bugs.webkit.org/show_bug.cgi?id=171610
1587         <rdar://problem/31976820>
1588
1589         Reviewed by Eric Carlson.
1590
1591         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1592
1593         * WebCoreSupport/WebChromeClient.h:
1594         * WebCoreSupport/WebChromeClient.mm:
1595         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1596
1597 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1598
1599         Unreviewed, rolling out r216206.
1600         https://bugs.webkit.org/show_bug.cgi?id=171714
1601
1602         Multiple LayoutTests crashing in Document::page() (Requested
1603         by ap on #webkit).
1604
1605         Reverted changeset:
1606
1607         "Remove support for legacy Notifications"
1608         https://bugs.webkit.org/show_bug.cgi?id=171487
1609         http://trac.webkit.org/changeset/216206
1610
1611 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
1612
1613         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
1614         https://bugs.webkit.org/show_bug.cgi?id=171704
1615
1616         Reviewed by Jer Noble.
1617
1618         Fix build by casting result of +whiteColor to UIColor.
1619
1620         * WebView/WebView.mm:
1621         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1622
1623 2017-05-04  Sam Weinig  <sam@webkit.org>
1624
1625         Remove support for legacy Notifications
1626         https://bugs.webkit.org/show_bug.cgi?id=171487
1627
1628         Reviewed by Jon Lee.
1629
1630         * Configurations/FeatureDefines.xcconfig:
1631         * WebCoreSupport/WebNotificationClient.h:
1632         * WebCoreSupport/WebNotificationClient.mm:
1633         * WebView/WebNotification.mm:
1634         * WebView/WebNotificationInternal.h:
1635         * WebView/WebView.mm:
1636         (-[WebView _commonInitializationWithFrameName:groupName:]):
1637         (-[WebView _notificationIDForTesting:]):
1638         Remove legacy notification specific code.
1639
1640 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
1641
1642         [Cocoa] Stop exporting symbols for ivars that were made private
1643         https://bugs.webkit.org/show_bug.cgi?id=171631
1644
1645         Reviewed by Dan Bernstein.
1646
1647         * WebKit.exp:
1648
1649 2017-05-01  Chris Dumez  <cdumez@apple.com>
1650
1651         Remove some usage of PassRefPtr in editing code
1652         https://bugs.webkit.org/show_bug.cgi?id=171490
1653
1654         Reviewed by Darin Adler.
1655
1656         * WebView/WebFrame.mm:
1657         (-[WebFrame dictationResultMetadataForRange:]):
1658         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1659
1660 2017-05-01  Beth Dakin  <bdakin@apple.com>
1661
1662         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1663         start of a paragraph
1664         https://bugs.webkit.org/show_bug.cgi?id=171453
1665         -and corresponding-
1666         rdar://problem/29779764
1667
1668         Reviewed by Tim Horton.
1669
1670         This bug only happens when the caret is at the beginning of the paragraph, and it 
1671         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
1672         might be correct that absoluteTextQuads() returns no quads in this case, so this 
1673         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
1674
1675         * WebCoreSupport/WebEditorClient.mm:
1676         (WebEditorClient::handleRequestedCandidates):
1677
1678 2017-04-30  Dan Bernstein  <mitz@apple.com>
1679
1680         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
1681         https://bugs.webkit.org/show_bug.cgi?id=171485
1682
1683         Reviewed by Geoffrey Garen.
1684
1685         * WebView/WebView.mm:
1686         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1687         (-[WebUITextIndicatorData initWithImage:scale:]):
1688
1689 2017-04-28  Youenn Fablet  <youenn@apple.com>
1690
1691         Adding a runtime flag specific to MediaDevices
1692         https://bugs.webkit.org/show_bug.cgi?id=171433
1693
1694         Reviewed by Geoffrey Garen.
1695
1696         Adding a preference for MediaDevices.
1697         Setting media devices runtime flag to false by default.
1698         Setting peer connection and media stream flags to true by default.
1699
1700         * WebView/WebPreferenceKeysPrivate.h:
1701         * WebView/WebPreferences.mm:
1702         (+[WebPreferences initialize]):
1703         (-[WebPreferences mediaDevicesEnabled]):
1704         (-[WebPreferences setMediaDevicesEnabled:]):
1705         * WebView/WebPreferencesPrivate.h:
1706         * WebView/WebView.mm:
1707         (-[WebView _preferencesChanged:]):
1708
1709 2017-04-27  Chris Dumez  <cdumez@apple.com>
1710
1711         Align colspan/rowspan limits with the latest HTML specification
1712         https://bugs.webkit.org/show_bug.cgi?id=171322
1713
1714         Reviewed by Darin Adler.
1715
1716         ObjC bindings build fix.
1717
1718         * DOM/DOMHTMLTableCellElement.mm:
1719         (-[DOMHTMLTableCellElement colSpan]):
1720         (-[DOMHTMLTableCellElement setColSpan:]):
1721
1722 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1723
1724         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
1725         https://bugs.webkit.org/show_bug.cgi?id=170333
1726
1727         Reviewed by Simon Fraser.
1728
1729         Disbale the async decoding for large images for now.
1730
1731         * WebView/WebView.mm:
1732         (-[WebView _preferencesChanged:]):
1733
1734 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1735
1736         Modernize Frame.h
1737         https://bugs.webkit.org/show_bug.cgi?id=171357
1738
1739         Reviewed by Andy Estes.
1740
1741         * WebCoreSupport/WebEditorClient.h:
1742         * WebCoreSupport/WebEditorClient.mm:
1743         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
1744
1745 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1746
1747         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
1748         https://bugs.webkit.org/show_bug.cgi?id=171369
1749         <rdar://problem/31858853>
1750
1751         Reviewed by Dan Bernstein.
1752
1753         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
1754         returns whether or not the data interaction was handled. Due to the difference only in return type
1755         and some staging constraints, this version is prefixed with "_tryTo".
1756
1757         * WebView/WebView.mm:
1758         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1759         * WebView/WebViewPrivate.h:
1760
1761 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1762
1763         WebItemProviderPasteboard should not synchronously load provided data
1764         https://bugs.webkit.org/show_bug.cgi?id=171341
1765         <rdar://problem/31614010>
1766
1767         Reviewed by Tim Horton.
1768
1769         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
1770
1771         * WebCoreSupport/WebPlatformStrategies.h:
1772         * WebCoreSupport/WebPlatformStrategies.mm:
1773         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
1774
1775 2017-04-26  Zalan Bujtas  <zalan@apple.com>
1776
1777         RTL: recent searches popover is displayed in incorrect location
1778         https://bugs.webkit.org/show_bug.cgi?id=171338
1779         <rdar://problem/31377807>
1780
1781         Reviewed by Dean Jackson.
1782
1783         Add RTL support for the pop-under branch.
1784
1785         * WebCoreSupport/PopupMenuMac.mm:
1786         (PopupMenuMac::show):
1787
1788 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1789
1790         Limit allowed size of document.title to avoid locking WebKit clients
1791         https://bugs.webkit.org/show_bug.cgi?id=165113
1792         <rdar://problem/28324389>
1793
1794         Reviewed by Darin Adler.
1795
1796         When a web application attempts to set an extremely long title, truncate the
1797         title to a more reasonable size.
1798
1799         We do this at at the presentation layer, rather than in the DOM, so that we do
1800         not affect script function. Instead, we merely limit display to a level that is
1801         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
1802         layer, so it is a waste of effort to send across IPC.
1803
1804         * WebCoreSupport/WebFrameLoaderClient.h:
1805         * WebCoreSupport/WebFrameLoaderClient.mm:
1806         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1807
1808 2017-04-25  Daniel Bates  <dabates@apple.com>
1809
1810         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1811         https://bugs.webkit.org/show_bug.cgi?id=136452
1812         <rdar://problem/23412620>
1813
1814         Reviewed by Brent Fulgham.
1815
1816         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1817
1818         * Configurations/FeatureDefines.xcconfig:
1819
1820 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1821
1822         Support reading NSURL titles from the pasteboard when performing data interaction
1823         https://bugs.webkit.org/show_bug.cgi?id=171156
1824         <rdar://problem/31356937>
1825
1826         Reviewed by Tim Horton.
1827
1828         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
1829
1830         * WebCoreSupport/WebPlatformStrategies.h:
1831         * WebCoreSupport/WebPlatformStrategies.mm:
1832         (WebPlatformStrategies::readURLFromPasteboard):
1833         * WebView/WebFrame.mm:
1834         (-[WebFrame hasRichlyEditableDragCaret]):
1835         * WebView/WebFramePrivate.h:
1836
1837 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
1838
1839         Clean up ICU headers
1840         https://bugs.webkit.org/show_bug.cgi?id=170997
1841
1842         Reviewed by JF Bastien.
1843
1844         Update all icu headers to 55.1
1845
1846         * icu/README: Explain ICU headers for OS X better
1847         * icu/unicode/localpointer.h:
1848         (LocalPointer::LocalPointer):
1849         (LocalPointer::adoptInsteadAndCheckErrorCode):
1850         * icu/unicode/platform.h:
1851         * icu/unicode/putil.h:
1852         * icu/unicode/uchar.h:
1853         * icu/unicode/uconfig.h:
1854         * icu/unicode/ucurr.h:
1855         * icu/unicode/uidna.h:
1856         * icu/unicode/umachine.h:
1857         * icu/unicode/urename.h:
1858         * icu/unicode/uscript.h:
1859         * icu/unicode/ustring.h:
1860         * icu/unicode/utf8.h:
1861         * icu/unicode/utypes.h:
1862         * icu/unicode/uvernum.h:
1863
1864 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1865
1866         Respect fidelity order when reading web content from item providers
1867         https://bugs.webkit.org/show_bug.cgi?id=171155
1868         <rdar://problem/31356937>
1869
1870         Reviewed by Tim Horton.
1871
1872         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
1873
1874         * WebCoreSupport/WebPlatformStrategies.h:
1875         * WebCoreSupport/WebPlatformStrategies.mm:
1876         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
1877
1878 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1879
1880         Reduce copies and allocations in SharedBuffer::append
1881         https://bugs.webkit.org/show_bug.cgi?id=170956
1882
1883         Reviewed by Andreas Kling.
1884
1885         * WebView/WebArchive.mm:
1886         (-[WebArchive initWithData:]):
1887         * WebView/WebFrame.mm:
1888         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1889         * WebView/WebResource.mm:
1890         (-[WebResource initWithCoder:]):
1891         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1892
1893 2017-04-24  Dan Bernstein  <mitz@apple.com>
1894
1895         [Cocoa] Some ivars are needlessly @protected
1896         https://bugs.webkit.org/show_bug.cgi?id=171208
1897
1898         Reviewed by Anders Carlsson
1899
1900         Made ivars @private where possible.
1901
1902         * Misc/WebUserContentURLPattern.h:
1903         * Plugins/WebPluginDatabase.h:
1904         * Storage/WebDatabaseQuotaManager.h:
1905         * WebCoreSupport/WebSecurityOriginPrivate.h:
1906         * WebInspector/WebInspector.h:
1907         * WebView/WebDeviceOrientation.h:
1908         * WebView/WebDeviceOrientationProviderMock.h:
1909         * WebView/WebGeolocationPosition.h:
1910         * WebView/WebHTMLRepresentation.h:
1911         * WebView/WebNotification.h:
1912
1913 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1914
1915         Support writing link titles to the pasteboard when beginning data interaction on a link
1916         https://bugs.webkit.org/show_bug.cgi?id=171154
1917         <rdar://problem/31356937>
1918
1919         Reviewed by Andy Estes.
1920
1921         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
1922         and WebKit2 ChangeLogs for more details.
1923
1924         * WebCoreSupport/WebPlatformStrategies.h:
1925         * WebCoreSupport/WebPlatformStrategies.mm:
1926         (WebPlatformStrategies::writeToPasteboard):
1927
1928 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1929
1930         Unreviewed, rolling out r215608.
1931
1932         Hundreds of test failures on GTK bot
1933
1934         Reverted changeset:
1935
1936         "Reduce copies and allocations in SharedBuffer::append"
1937         https://bugs.webkit.org/show_bug.cgi?id=170956
1938         http://trac.webkit.org/changeset/215608
1939
1940 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1941
1942         Reduce copies and allocations in SharedBuffer::append
1943         https://bugs.webkit.org/show_bug.cgi?id=170956
1944
1945         Reviewed by Andreas Kling.
1946
1947         * WebView/WebArchive.mm:
1948         (-[WebArchive initWithData:]):
1949         * WebView/WebFrame.mm:
1950         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1951         * WebView/WebResource.mm:
1952         (-[WebResource initWithCoder:]):
1953         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1954
1955 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
1956
1957         Build fix to start using C++14.
1958         https://bugs.webkit.org/show_bug.cgi?id=171038
1959
1960         Reviewed by Alex Christensen.
1961
1962         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
1963
1964         * Configurations/WebKitLegacy.xcconfig:
1965
1966 2017-04-19  Youenn Fablet  <youenn@apple.com>
1967
1968         [Mac] Allow customizing H264 encoder
1969         https://bugs.webkit.org/show_bug.cgi?id=170829
1970
1971         Reviewed by Alex Christensen.
1972
1973         * Configurations/FeatureDefines.xcconfig:
1974
1975 2017-04-19  Anders Carlsson  <andersca@apple.com>
1976
1977         Stop using deprecated APIs, part 3
1978         https://bugs.webkit.org/show_bug.cgi?id=171003
1979         rdar://problem/31589635
1980
1981         Reviewed by Tim Horton.
1982
1983         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1984         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1985         (WebPaymentCoordinatorClient::cancelPaymentSession):
1986         Update for WebCore changes.
1987
1988 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1989
1990         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
1991         https://bugs.webkit.org/show_bug.cgi?id=170880
1992         <rdar://problem/31314689>
1993
1994         Reviewed by Tim Horton.
1995
1996         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
1997
1998         * WebCoreSupport/WebPlatformStrategies.h:
1999         * WebCoreSupport/WebPlatformStrategies.mm:
2000         (WebPlatformStrategies::getFilenamesForDataInteraction):
2001
2002 2017-04-17  Youenn Fablet  <youenn@apple.com>
2003
2004         Disable outdated WritableStream API
2005         https://bugs.webkit.org/show_bug.cgi?id=170749
2006         <rdar://problem/31446233>
2007
2008         Reviewed by Alex Christensen.
2009
2010         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2011         - A STREAMS_API compilation flag.
2012         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2013
2014         * Configurations/FeatureDefines.xcconfig:
2015         * WebView/WebPreferenceKeysPrivate.h:
2016         * WebView/WebPreferences.mm:
2017         (+[WebPreferences initialize]):
2018         (-[WebPreferences readableByteStreamAPIEnabled]):
2019         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
2020         (-[WebPreferences writableStreamAPIEnabled]):
2021         (-[WebPreferences setWritableStreamAPIEnabled:]):
2022         * WebView/WebPreferencesPrivate.h:
2023         * WebView/WebView.mm:
2024         (-[WebView _preferencesChanged:]):
2025
2026 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2027
2028         [WK2] Support data interaction of files into file inputs
2029         https://bugs.webkit.org/show_bug.cgi?id=170803
2030         <rdar://problem/31286130>
2031
2032         Reviewed by Tim Horton.
2033
2034         Add boilerplate plumbing for fetching the number of files in the pasteboard.
2035
2036         * WebCoreSupport/WebPlatformStrategies.h:
2037         * WebCoreSupport/WebPlatformStrategies.mm:
2038         (WebPlatformStrategies::getNumberOfFiles):
2039
2040 2017-04-14  Mark Lam  <mark.lam@apple.com>
2041
2042         Update architectures in xcconfig files.
2043         https://bugs.webkit.org/show_bug.cgi?id=170867
2044         <rdar://problem/31628104>
2045
2046         Reviewed by Joseph Pecoraro.
2047
2048         * Configurations/FeatureDefines.xcconfig:
2049
2050 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2051
2052         [WK2] Support Icon creation from file URLs on iOS
2053         https://bugs.webkit.org/show_bug.cgi?id=170809
2054         <rdar://problem/31286130>
2055
2056         Reviewed by Tim Horton.
2057
2058         Adjust for changes in the ChromeClient in WebCore.
2059
2060         * WebCoreSupport/WebChromeClient.h:
2061         * WebCoreSupport/WebChromeClient.mm:
2062         (WebChromeClient::loadIconForFiles):
2063         (WebChromeClient::createIconForFiles):
2064
2065 2017-04-12  Dan Bernstein  <mitz@apple.com>
2066
2067         [Mac] Future-proof .xcconfig files
2068         https://bugs.webkit.org/show_bug.cgi?id=170802
2069
2070         Reviewed by Tim Horton.
2071
2072         * Configurations/Base.xcconfig:
2073         * Configurations/DebugRelease.xcconfig:
2074         * Configurations/FeatureDefines.xcconfig:
2075         * Configurations/Version.xcconfig:
2076
2077 2017-04-12  Beth Dakin  <bdakin@apple.com>
2078
2079         Build fix.
2080
2081         * WebView/WebViewData.h:
2082
2083 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
2084
2085         Should always override -[WebStorageManager init].
2086         https://bugs.webkit.org/show_bug.cgi?id=170787
2087         -and corresponding-
2088         rdar://problem/31371835
2089
2090         Reviewed by Anders Carlsson.
2091
2092         * Storage/WebStorageManager.mm:
2093         (-[WebStorageManager init]):
2094
2095 2017-04-12  Beth Dakin  <bdakin@apple.com>
2096
2097         Speculative build fix. 
2098
2099         * WebView/WebViewData.h:
2100
2101 2017-04-12  Beth Dakin  <bdakin@apple.com>
2102
2103         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
2104         https://bugs.webkit.org/show_bug.cgi?id=170693
2105         -and corresponding-
2106         rdar://problem/31230018
2107
2108         Reviewed by Sam Weinig.
2109
2110         Since the new names only apply to some versions of macOS, this patch uses typedefs 
2111         for the older OS’s. SO:
2112
2113         AVFunctionBarScrubber is now AVTouchBarScrubber
2114
2115         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
2116
2117         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
2118
2119         And the protocol AVFunctionBarPlaybackControlsControlling is now 
2120         AVTouchBarPlaybackControlsControlling
2121
2122         Soft links and allocations cannot use the typedefs.
2123         * WebView/WebView.mm:
2124         (-[WebView updateMediaTouchBar]):
2125         * WebView/WebViewData.h:
2126
2127 2017-04-11  Dean Jackson  <dino@apple.com>
2128
2129         Disable outdated WritableStream API
2130         https://bugs.webkit.org/show_bug.cgi?id=170749
2131         <rdar://problem/31446233>
2132
2133         Reviewed by Tim Horton.
2134
2135         The API we implement is no longer accurate. Disable it until we
2136         are compatible with the new specification
2137
2138         * Configurations/FeatureDefines.xcconfig:
2139
2140 2017-04-11  Dan Bernstein  <mitz@apple.com>
2141
2142         [iOS] Simple HTML documents should allow non-markup JavaScript
2143         https://bugs.webkit.org/show_bug.cgi?id=170734
2144
2145         Reviewed by Sam Weinig.
2146
2147         * WebView/WebView.mm:
2148         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
2149           but disabled scripting markup.
2150
2151 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2152
2153         Revert r215217
2154         https://bugs.webkit.org/show_bug.cgi?id=170703
2155
2156         * Configurations/FeatureDefines.xcconfig:
2157
2158 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2159
2160         Continue enabling WebRTC
2161         https://bugs.webkit.org/show_bug.cgi?id=170703
2162
2163         Reviewed by Youenn Fablet.
2164
2165         * Configurations/FeatureDefines.xcconfig:
2166
2167 2017-04-10  Anders Carlsson  <andersca@apple.com>
2168
2169         Remove call to WKShowKeyAndMain
2170         https://bugs.webkit.org/show_bug.cgi?id=170691
2171         rdar://problem/31050032
2172
2173         Reviewed by Beth Dakin.
2174
2175         * Carbon/CarbonWindowAdapter.mm:
2176         (-[CarbonWindowAdapter makeKeyWindow]):
2177
2178 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
2179
2180         Add CoreAudioCaptureSource.
2181         https://bugs.webkit.org/show_bug.cgi?id=170112
2182         rdar://problem/30293338
2183
2184         Reviewed by Eric Carlson.
2185
2186         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
2187
2188         * WebView/WebPreferenceKeysPrivate.h:
2189         * WebView/WebPreferences.mm:
2190         (+[WebPreferences initialize]):
2191         (-[WebPreferences useAVFoundationAudioCapture]):
2192         (-[WebPreferences setUseAVFoundationAudioCapture:]):
2193         * WebView/WebPreferencesPrivate.h:
2194         * WebView/WebView.mm:
2195         (-[WebView _preferencesChanged:]):
2196
2197 2017-04-10  Chris Dumez  <cdumez@apple.com>
2198
2199         Drop Timer::startOneShot() overload taking a double
2200         https://bugs.webkit.org/show_bug.cgi?id=170659
2201
2202         Reviewed by Yusuke Suzuki.
2203
2204         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2205
2206         * Plugins/WebNetscapePluginView.mm:
2207         (PluginTimer::start):
2208         * Storage/WebStorageManager.mm:
2209         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2210
2211 2017-04-09  Chris Dumez  <cdumez@apple.com>
2212
2213         Drop Timer::startRepeating() overload taking a double
2214         https://bugs.webkit.org/show_bug.cgi?id=170656
2215
2216         Reviewed by Yusuke Suzuki.
2217
2218         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2219
2220         * Plugins/WebNetscapePluginView.mm:
2221         (PluginTimer::start):
2222
2223 2017-04-09  Chris Dumez  <cdumez@apple.com>
2224
2225         Start dropping Timer API dealing with double
2226         https://bugs.webkit.org/show_bug.cgi?id=170649
2227
2228         Reviewed by Yusuke Suzuki.
2229
2230         Start dropping Timer API dealing with double as people should use Seconds now.
2231
2232         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2233         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2234         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2235         * Plugins/WebNetscapePluginStream.mm:
2236         (WebNetscapePluginStream::deliverData):
2237
2238 2017-04-08  Chris Dumez  <cdumez@apple.com>
2239
2240         Drop std::chrono support from Timer class
2241         https://bugs.webkit.org/show_bug.cgi?id=170645
2242
2243         Reviewed by Sam Weinig.
2244
2245         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2246
2247         * WebView/WebView.mm:
2248         (+[WebView _setCacheModel:]):
2249
2250 2017-04-08  Youenn Fablet  <youenn@apple.com>
2251
2252         WebRTC tests gardening
2253         https://bugs.webkit.org/show_bug.cgi?id=170508
2254
2255         Reviewed by Eric Carlson.
2256
2257         * Configurations/FeatureDefines.xcconfig:
2258
2259 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2260
2261         Unreviewed, rolling out r215046.
2262
2263         This change broke internal builds.
2264
2265         Reverted changeset:
2266
2267         "WebRTC tests gardening"
2268         https://bugs.webkit.org/show_bug.cgi?id=170508
2269         http://trac.webkit.org/changeset/215046
2270
2271 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2272
2273         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2274         https://bugs.webkit.org/show_bug.cgi?id=170566
2275
2276         Reviewed by Simon Fraser.
2277
2278         * DOM/DOMCSS.mm:
2279         (kitClass):
2280         Use the WebCore-side enum for this, since that's actually what we're switching over.
2281         This allows us to handle values here without adding them to the API header.
2282         All of the other kitClass() functions work the same way.
2283         Also, unindent for style purposes.
2284
2285 2017-04-06  Youenn Fablet  <youenn@apple.com>
2286
2287         WebRTC tests gardening
2288         https://bugs.webkit.org/show_bug.cgi?id=170508
2289
2290         Reviewed by Eric Carlson.
2291
2292         * Configurations/FeatureDefines.xcconfig:
2293
2294 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2295
2296         Fix leaks in WebUITextIndicatorData
2297         https://bugs.webkit.org/show_bug.cgi?id=170480
2298
2299         Reviewed by Wenson Hsieh.
2300
2301         Removes extraneous retains.
2302
2303         * WebView/WebView.mm:
2304         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2305
2306 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2307
2308         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2309         https://bugs.webkit.org/show_bug.cgi?id=165801
2310         <rdar://problem/29649535>
2311
2312         Reviewed by Wenson Hsieh.
2313
2314         * WebView/WebView.mm:
2315         (incrementFrame):
2316         Adjust to the new CanWrap enum.
2317
2318 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2319
2320         Web Inspector: Saving files should not suggest the top level directory
2321         https://bugs.webkit.org/show_bug.cgi?id=170085
2322         <rdar://problem/30197794>
2323
2324         Reviewed by Matt Baker.
2325
2326         * WebCoreSupport/WebInspectorClient.mm:
2327         (WebInspectorFrontendClient::save):
2328         Don't set panel.directoryURL unless we have a good suggestion.
2329
2330 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2331
2332         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2333         https://bugs.webkit.org/show_bug.cgi?id=169168
2334         <rdar://problem/30688374>
2335
2336         Reviewed by Tim Horton.
2337
2338         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2339         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2340         we need to import a C++ header for linkedOnOrAfter().
2341
2342         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2343         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2344         the new default value of everything but DragDestinationActionLoad.
2345
2346         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2347         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2348         * Misc/WebKitVersionChecks.h:
2349         * WebCoreSupport/WebDragClient.h:
2350         * WebCoreSupport/WebDragClient.mm:
2351         (WebDragClient::actionMaskForDrag): Deleted.
2352         * WebView/WebView.mm:
2353         (-[WebView draggingEntered:]):
2354         (-[WebView draggingUpdated:]):
2355
2356 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2357
2358         Add support for showing the platform data interaction caret
2359         https://bugs.webkit.org/show_bug.cgi?id=169898
2360         <rdar://problem/31146295>
2361
2362         Reviewed by Beth Dakin.
2363
2364         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2365
2366         * WebView/WebView.mm:
2367         (-[WebView _dataInteractionCaretRect]):
2368         * WebView/WebViewPrivate.h:
2369
2370 2017-03-22  Dan Bernstein  <mitz@apple.com>
2371
2372         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2373         https://bugs.webkit.org/show_bug.cgi?id=169967
2374         <rdar://problem/30406898>
2375
2376         Reviewed by Anders Carlsson.
2377
2378         * WebView/WebView.mm:
2379         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2380           Settings::downloadableBinaryFontsEnabled. The default is true.
2381
2382 2017-03-22  Andy Estes  <aestes@apple.com>
2383
2384         [QuickLook] Rename QuickLookHandle to PreviewLoader
2385         https://bugs.webkit.org/show_bug.cgi?id=169961
2386
2387         Reviewed by Andreas Kling.
2388
2389         * WebCoreSupport/WebFrameLoaderClient.h:
2390         * WebCoreSupport/WebFrameLoaderClient.mm:
2391         (WebFrameLoaderClient::createPreviewLoaderClient):
2392         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2393
2394 2017-03-21  Anders Carlsson  <andersca@apple.com>
2395
2396         Remove bogus availability annotations from DOM SPI headers.
2397         rdar://problem/31015675
2398
2399         Rubber-stamped by Dan Bernstein.
2400
2401         * DOM/DOMHTMLMediaElement.h:
2402         * DOM/DOMHTMLVideoElement.h:
2403         * DOM/DOMMediaError.h:
2404         * DOM/DOMTextEvent.h:
2405         * DOM/DOMTimeRanges.h:
2406         * DOM/DOMTokenList.h:
2407
2408 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2409
2410         Teach TextIndicator to estimate the background color of the given Range
2411         https://bugs.webkit.org/show_bug.cgi?id=169869
2412         <rdar://problem/31127272>
2413
2414         Reviewed by Anders Carlsson and Simon Fraser.
2415
2416         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2417
2418         * WebView/WebView.mm:
2419         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2420         (-[WebUITextIndicatorData dealloc]):
2421         * WebView/WebViewPrivate.h:
2422
2423 2017-03-20  Dan Bernstein  <mitz@apple.com>
2424
2425         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2426         https://bugs.webkit.org/show_bug.cgi?id=169861
2427
2428         Reviewed by Sam Weinig.
2429
2430         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2431         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2432           timestamp file used by the Xcode project to determine whether to run the script.
2433
2434 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2435
2436         WebHTMLView is useless as WebResourceHandler
2437         https://bugs.webkit.org/show_bug.cgi?id=169857
2438
2439         Reviewed by Dan Bernstein.
2440
2441         * WebView/WebHTMLView.mm:
2442         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2443         WebHTMLView doesnt implement any of WebResourceHandler methods.
2444
2445 2017-03-17  Michael Saboff  <msaboff@apple.com>
2446
2447         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2448         https://bugs.webkit.org/show_bug.cgi?id=169817
2449
2450         Reviewed by Filip Pizlo.
2451
2452         * Configurations/FeatureDefines.xcconfig:
2453
2454 2017-03-17  Antti Koivisto  <antti@apple.com>
2455
2456         Add a reload policy where only expired subresources are revalidated
2457         https://bugs.webkit.org/show_bug.cgi?id=169756
2458
2459         Reviewed by Andreas Kling.
2460
2461         * WebView/WebFrame.mm:
2462         (toWebFrameLoadType):
2463         (-[WebFrame reload]):
2464         (-[WebFrame reloadFromOrigin]):
2465
2466 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2467
2468         [WK1] Support animated transitions when performing a data interaction operation
2469         https://bugs.webkit.org/show_bug.cgi?id=169805
2470         <rdar://problem/31045767>
2471
2472         Reviewed by Beth Dakin and Megan Gardner.
2473
2474         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2475         for more details.
2476
2477         * DOM/DOMElement.h:
2478         * DOM/DOMElement.mm:
2479         (-[DOMElement boundsInRootViewSpace]):
2480
2481         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2482
2483         * WebCoreSupport/WebDragClient.h:
2484         (): Deleted.
2485         * WebCoreSupport/WebDragClient.mm:
2486         (WebDragClient::didConcludeEditDrag):
2487
2488         Add boilerplate plumbing.
2489
2490         * WebView/WebView.mm:
2491         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2492
2493         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2494
2495         (floatRectsForCGRectArray):
2496         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2497
2498         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2499         image of some text, as well as clipping rects to apply to the image.
2500
2501         (-[WebView _dataOperationTextIndicator]):
2502
2503         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2504
2505         (-[WebView _didConcludeEditDataInteraction]):
2506         * WebView/WebViewData.h:
2507         * WebView/WebViewInternal.h:
2508         * WebView/WebViewPrivate.h:
2509
2510 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2511
2512         Improve the system tracing points
2513         https://bugs.webkit.org/show_bug.cgi?id=169790
2514
2515         Reviewed by Zalan Bujtas.
2516
2517         Use a more cohesive set of system trace points that give a good overview of what
2518         WebKit is doing. Added points for resource loading, render tree building, sync messages
2519         to the web process, async image decode, WASM and fetching cookies.
2520
2521         * WebView/WebHTMLView.mm:
2522         (-[WebHTMLView drawRect:]):
2523
2524 2017-03-16  Youenn Fablet  <youenn@apple.com>
2525
2526         Wrap legacy WebRTC API in runtime flag
2527         https://bugs.webkit.org/show_bug.cgi?id=169646
2528
2529         Reviewed by Alex Christensen.
2530
2531         * WebView/WebPreferenceKeysPrivate.h:
2532         * WebView/WebPreferences.mm:
2533         (+[WebPreferences initialize]):
2534         (-[WebPreferences webRTCLegacyAPIEnabled]):
2535         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2536         * WebView/WebPreferencesPrivate.h:
2537         * WebView/WebView.mm:
2538         (-[WebView _preferencesChanged:]):
2539
2540 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2541
2542         Correctly export WebItemProviderPasteboard
2543         https://bugs.webkit.org/show_bug.cgi?id=169578
2544
2545         Reviewed by Tim Horton.
2546
2547         * MigrateHeaders.make:
2548
2549 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2550
2551         [WK2] Data interaction tests occasionally hit assertions in debug builds
2552         https://bugs.webkit.org/show_bug.cgi?id=169002
2553         <rdar://problem/30994806>
2554
2555         Reviewed by Tim Horton.
2556
2557         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2558
2559         * WebView/WebHTMLView.mm:
2560         (-[WebHTMLView _updateSelectionForInputManager]):
2561         * WebView/WebView.mm:
2562         (-[WebView updateTextTouchBar]):
2563
2564 2017-03-13  Anders Carlsson  <andersca@apple.com>
2565
2566         Fix build warnings.
2567
2568         * WebCoreSupport/WebInspectorClient.mm:
2569         (WebInspectorFrontendClient::save):
2570         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2571
2572 2017-03-11  Brady Eidson  <beidson@apple.com>
2573
2574         Cleanup "addCookie" and its sole user.
2575         https://bugs.webkit.org/show_bug.cgi?id=169486
2576
2577         Reviewed by Brian Burg.
2578
2579         * WebCoreSupport/WebPlatformStrategies.h:
2580         * WebCoreSupport/WebPlatformStrategies.mm:
2581         (WebPlatformStrategies::addCookie): Deleted.
2582
2583 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2584
2585         Fix watch and tv builds after r213294
2586         https://bugs.webkit.org/show_bug.cgi?id=169508
2587
2588         Reviewed by Dan Bernstein.
2589
2590         * Configurations/FeatureDefines.xcconfig:
2591
2592 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2593
2594         Fix CMake build.
2595
2596         * WebView/WebNotification.h:
2597         Don't assume we have already included something that includes NSObject.h.
2598
2599 2017-03-09  Daniel Bates  <dabates@apple.com>
2600
2601         Guard Credential Management implementation behind a runtime enabled feature flag
2602         https://bugs.webkit.org/show_bug.cgi?id=169364
2603         <rdar://problem/30957425>
2604
2605         Reviewed by Brent Fulgham.
2606
2607         Add WebKit preference for Credential Management (disabled by default).
2608
2609         * WebView/WebPreferenceKeysPrivate.h:
2610         * WebView/WebPreferences.mm:
2611         (+[WebPreferences initialize]):
2612         (-[WebPreferences credentialManagementEnabled]): Added.
2613         (-[WebPreferences setCredentialManagementEnabled:]): Added.
2614         * WebView/WebPreferencesPrivate.h:
2615         * WebView/WebView.mm:
2616         (-[WebView _preferencesChanged:]):
2617
2618 2017-03-09  Anders Carlsson  <andersca@apple.com>
2619
2620         Add delegate support to WebCore
2621         https://bugs.webkit.org/show_bug.cgi?id=169427
2622         Part of rdar://problem/28880714.
2623
2624         Reviewed by Geoffrey Garen.
2625
2626         * Configurations/FeatureDefines.xcconfig:
2627         Add feature define.
2628
2629 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2630
2631         Fix DataInteraction guards
2632         https://bugs.webkit.org/show_bug.cgi?id=169404
2633
2634         Reviewed by Wenson Hsieh.
2635
2636         * WebCoreSupport/WebDragClient.mm:
2637
2638 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2639
2640         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
2641         https://bugs.webkit.org/show_bug.cgi?id=169392
2642         <rdar://problem/30882974>
2643
2644         Reviewed by Tim Horton.
2645
2646         Add a stub implementation of WebDragClient::didConcludeEditDrag.
2647
2648         * WebCoreSupport/WebDragClient.h:
2649
2650 2017-03-08  Anders Carlsson  <andersca@apple.com>
2651
2652         Simplify the PaymentCoordinator interface
2653         https://bugs.webkit.org/show_bug.cgi?id=169382
2654         Part of rdar://problem/28880714.
2655
2656         Reviewed by Tim Horton.
2657
2658         Update for PaymentCoordinatorClient changes.
2659
2660         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2661         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2662         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2663         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2664         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2665         (WebPaymentCoordinatorClient::completePaymentSession):
2666
2667 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2668
2669         Fix for dependency fix
2670         https://bugs.webkit.org/show_bug.cgi?id=169369
2671
2672         Reviewed by Beth Dakin.
2673
2674         * WebView/WebViewPrivate.h:
2675
2676 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2677
2678         Fix Project Dependency
2679         https://bugs.webkit.org/show_bug.cgi?id=169340
2680
2681         Unreviewed Dependency Fix.
2682
2683         * WebView/WebViewPrivate.h:
2684
2685 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
2686
2687         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
2688         https://bugs.webkit.org/show_bug.cgi?id=169341
2689         <rdar://problem/30913788>
2690
2691         Reviewed by Dan Bernstein.
2692
2693         * MigrateHeaders.make:
2694
2695 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2696
2697         Have fixedPositionCreatesStackingContext be on by default everywhere
2698         https://bugs.webkit.org/show_bug.cgi?id=169334
2699
2700         Reviewed by Zalan Bujtas.
2701
2702         It makes no sense to have web-exposed CSS functionality be different based on setting,
2703         and other browser are now aligned with having position:fixed create stacking context.
2704
2705         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
2706         always force stacking context for position:fixed.
2707
2708         * WebView/WebView.mm:
2709         (-[WebView _preferencesChanged:]):
2710
2711 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
2712
2713         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
2714         https://bugs.webkit.org/show_bug.cgi?id=169230
2715
2716         Reviewed by Tim Horton.
2717
2718         * WebView/WebView.mm:
2719         (-[WebView _preferencesChanged:]):
2720
2721 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2722
2723         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
2724         https://bugs.webkit.org/show_bug.cgi?id=169329
2725
2726         Reviewed by Tim Horton.
2727
2728         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
2729
2730         * WebView/WebPreferences.mm:
2731         (+[WebPreferences initialize]):
2732
2733 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2734
2735         Additional DataInteraction Support
2736         https://bugs.webkit.org/show_bug.cgi?id=169316
2737         <rdar://problem/30884234>
2738
2739         Reviewed by Wenson Hsieh.
2740
2741         Add stub implementations to WebView for methods that handle data interaction
2742
2743         * WebView/WebView.mm:
2744         (-[WebView _enteredDataInteraction:client:global:operation:]):
2745         (-[WebView _updatedDataInteraction:client:global:operation:]):
2746         (-[WebView _exitedDataInteraction:client:global:operation:]):
2747         (-[WebView _performDataInteraction:client:global:operation:]):
2748         (-[WebView _endedDataInteraction:global:]):
2749         * WebView/WebViewPrivate.h:
2750
2751 2017-03-07  Dean Jackson  <dino@apple.com>
2752
2753         Some platforms won't be able to create a GPUDevice
2754         https://bugs.webkit.org/show_bug.cgi?id=169314
2755         <rdar://problems/30907521>
2756
2757         Reviewed by Jon Lee.
2758
2759         Disable WEB_GPU on the iOS Simulator.
2760
2761         * Configurations/FeatureDefines.xcconfig:
2762
2763 2017-03-07  Maureen Daum  <mdaum@apple.com>
2764
2765         Correctly check for an empty database file.
2766         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
2767         https://bugs.webkit.org/show_bug.cgi?id=169256
2768
2769         Reviewed by Brady Eidson.
2770
2771         Check if the folder for an origin's WebSQL databases is empty after trying to delete
2772         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
2773         of files that were in the folder. However, when we delete the actual database file in
2774         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
2775         the database file, but deletedDatabaseFileCount only gets incremented once.
2776
2777         * Storage/WebDatabaseManager.mm:
2778         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
2779         Delete the folder if it is empty.
2780
2781 2017-03-06  Michael Saboff  <msaboff@apple.com>
2782
2783         Unreviewed build fix to add
2784         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
2785         for objective C++ files.
2786
2787         * Configurations/WebKitLegacy.xcconfig:
2788
2789 2017-03-06  Michael Saboff  <msaboff@apple.com>
2790
2791         Take advantage of fast permissions switching of JIT memory for devices that support it
2792         https://bugs.webkit.org/show_bug.cgi?id=169155
2793
2794         Reviewed by Saam Barati.
2795
2796         Updated the Xcode config files to match what is in the JavaScriptCore ones.
2797
2798         * Configurations/FeatureDefines.xcconfig:
2799
2800 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2801
2802         Expand font-weight and font-stretch to take any number
2803         https://bugs.webkit.org/show_bug.cgi?id=168889
2804
2805         Reviewed by Simon Fraser.
2806
2807         Migrate off old enum types.
2808
2809         * WebCoreSupport/PopupMenuMac.mm:
2810         (PopupMenuMac::populate):
2811         * WebView/WebHTMLView.mm:
2812         (fontNameForDescription):
2813         * WebView/WebView.mm:
2814         (-[WebView updateTextTouchBar]):
2815
2816 2017-03-03  Dean Jackson  <dino@apple.com>
2817
2818         Add WebGPU compile flag and experimental feature flag
2819         https://bugs.webkit.org/show_bug.cgi?id=169161
2820         <rdar://problem/30846689>
2821
2822         Reviewed by Tim Horton.
2823
2824         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2825         and an InternalSetting.
2826
2827         * Configurations/FeatureDefines.xcconfig:
2828         * WebView/WebPreferenceKeysPrivate.h:
2829         * WebView/WebPreferences.mm:
2830         (+[WebPreferences initialize]):
2831         (-[WebPreferences webGPUEnabled]):
2832         (-[WebPreferences setWebGPUEnabled:]):
2833         * WebView/WebPreferencesPrivate.h:
2834         * WebView/WebView.mm:
2835         (-[WebView _preferencesChanged:]):
2836
2837 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
2838
2839         Build fix
2840         rdar://problem/30825660
2841
2842         Suggested by Dan Bernstein.
2843
2844         * Configurations/WebKitLegacy.xcconfig:
2845
2846 2017-03-02  Sam Weinig  <sam@webkit.org>
2847
2848         Rename htmlediting.h/cpp to Editing.h/cpp
2849         https://bugs.webkit.org/show_bug.cgi?id=169103
2850
2851         Reviewed by Alex Christensen.
2852
2853         * DOM/DOMUIKitExtensions.mm:
2854         * WebView/WebFrame.mm:
2855         * WebView/WebView.mm:
2856
2857 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2858
2859         Fix 32-bit
2860         https://bugs.webkit.org/show_bug.cgi?id=169114
2861
2862         Reviewed by Alex Christensen.
2863
2864         * WebView/WebView.mm:
2865
2866 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2867
2868         More guard fixing
2869         https://bugs.webkit.org/show_bug.cgi?id=169112
2870
2871         Reviewed by Alex Christensen.
2872
2873         Fixed an internal build.
2874
2875         * WebView/WebView.mm:
2876         * WebView/WebViewPrivate.h:
2877
2878 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2879
2880         Data Interaction build fixes
2881         https://bugs.webkit.org/show_bug.cgi?id=169096
2882
2883         Reviewed by Tim Horton.
2884
2885         Guards weren't all correct, also missed a selector name change.
2886
2887         * WebView/WebView.mm:
2888         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2889         * WebView/WebViewData.h:
2890         * WebView/WebViewData.mm:
2891         (-[WebViewPrivate dealloc]):
2892
2893 2017-03-02  Alex Christensen  <achristensen@webkit.org>
2894
2895         Continue enabling WebRTC
2896         https://bugs.webkit.org/show_bug.cgi?id=169056
2897
2898         Reviewed by Jon Lee.
2899
2900         * Configurations/FeatureDefines.xcconfig:
2901
2902 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
2903
2904         Data interaction support for WK1
2905         https://bugs.webkit.org/show_bug.cgi?id=169062
2906
2907         Reviewed by Wenson Hsieh.
2908
2909         Support for data interaction in WebKit1
2910
2911         * WebCoreSupport/WebDragClient.mm:
2912         * WebView/WebView.mm:
2913         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
2914         (-[WebUITextIndicatorData initWithImage:scale:]):
2915         (-[WebUITextIndicatorData dealloc]):
2916         (-[WebView _requestStartDataInteraction:globalPosition:]):
2917         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2918         (-[WebView _getDataInteractionData]):
2919         * WebView/WebViewData.h:
2920         * WebView/WebViewData.mm:
2921         (-[WebViewPrivate dealloc]):
2922         * WebView/WebViewInternal.h:
2923         * WebView/WebViewPrivate.h:
2924
2925 2017-03-02  Youenn Fablet  <youenn@apple.com>
2926
2927         [WebRTC] Activate ICE candidate privacy policy
2928         https://bugs.webkit.org/show_bug.cgi?id=168975
2929
2930         Reviewed by Alex Christensen.
2931
2932         * WebView/WebPreferenceKeysPrivate.h:
2933         * WebView/WebPreferences.mm:
2934         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
2935         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
2936         (-[WebPreferences iceCandidateFilteringEnabled]):
2937         (-[WebPreferences setIceCandidateFilteringEnabled:]):
2938         * WebView/WebPreferencesPrivate.h:
2939
2940 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2941
2942         Unreviewed, rolling out r213259.
2943
2944         Broke an internal build
2945
2946         Reverted changeset:
2947
2948         "Continue enabling WebRTC"
2949         https://bugs.webkit.org/show_bug.cgi?id=169056
2950         http://trac.webkit.org/changeset/213259
2951
2952 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2953
2954         Continue enabling WebRTC
2955         https://bugs.webkit.org/show_bug.cgi?id=169056
2956
2957         Reviewed by Jon Lee.
2958
2959         * Configurations/FeatureDefines.xcconfig:
2960
2961 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2962
2963         Begin enabling WebRTC on 64-bit
2964         https://bugs.webkit.org/show_bug.cgi?id=168915
2965
2966         Reviewed by Eric Carlson.
2967
2968         * Configurations/FeatureDefines.xcconfig:
2969
2970 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
2971
2972         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
2973         https://bugs.webkit.org/show_bug.cgi?id=168919
2974
2975         Reviewed by Tim Horton.
2976
2977         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
2978         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
2979
2980 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2981
2982         [libwebrtc] Enable WebRTC in some Production Builds
2983         https://bugs.webkit.org/show_bug.cgi?id=168858
2984
2985         * Configurations/FeatureDefines.xcconfig:
2986
2987 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
2988
2989         Don't import RetainPtr in WebNotification.h
2990         https://bugs.webkit.org/show_bug.cgi?id=168876
2991
2992         Reviewed by Dan Bernstein.
2993
2994         This is an Objective-C SPI header.
2995
2996         * WebView/WebNotification.h:
2997         * WebView/WebNotification.mm:
2998         (-[WebNotification initWithCoreNotification:notificationID:]):
2999         (-[WebNotification dealloc]):
3000
3001 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
3002
3003         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
3004         https://bugs.webkit.org/show_bug.cgi?id=168819
3005
3006         Reviewed by Dan Bernstein.
3007
3008         * Configurations/WebKitLegacy.xcconfig:
3009
3010 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3011
3012         Export Objective-C symbols for variables in Webkit SPI
3013         https://bugs.webkit.org/show_bug.cgi?id=168758
3014
3015         Reviewed by Alexey Proskuryakov.
3016
3017         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
3018         * WebKit.exp: Added various Objective-C symbols.
3019
3020 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3021
3022         Move instance members from WKQuadObject to implementation file
3023         https://bugs.webkit.org/show_bug.cgi?id=168740
3024
3025         Reviewed by Tim Horton.
3026
3027         * DOM/DOM.mm: Moving instance member to implementation file.
3028         * DOM/DOMExtensions.h: Ditto.
3029
3030 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3031
3032         Move iOS specific symbols to WebKit.ios.exp
3033         https://bugs.webkit.org/show_bug.cgi?id=168726
3034
3035         Reviewed by Alexey Proskuryakov.
3036
3037         * WebKit.exp:
3038
3039 2017-02-21  Youenn Fablet  <youenn@apple.com>
3040
3041         [WebRTC][Mac] Activate libwebrtc
3042         https://bugs.webkit.org/show_bug.cgi?id=167293
3043         <rdar://problem/30401864>
3044
3045         Reviewed by Alex Christensen.
3046
3047         * Configurations/FeatureDefines.xcconfig:
3048
3049 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3050
3051         Export various NSString symbols from WebFramePrivate.h
3052         https://bugs.webkit.org/show_bug.cgi?id=168702
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         * WebKit.exp:
3057
3058 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3059
3060         Export various NSString symbols from WebPreferencesPrivate.h
3061         https://bugs.webkit.org/show_bug.cgi?id=168701
3062
3063         Reviewed by Alexey Proskuryakov.
3064
3065         * WebKit.exp:
3066
3067 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3068
3069         Add missing WebConsoleMessage string key
3070         https://bugs.webkit.org/show_bug.cgi?id=168690
3071
3072         Reviewed by Alexey Proskuryakov.
3073
3074         * WebKit.exp:
3075         * WebView/WebUIDelegatePrivate.h:
3076         This key has an implementation but was not extern / exported like the others.
3077
3078 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3079
3080         Export various NSString symbols from WebViewPrivate.h
3081         https://bugs.webkit.org/show_bug.cgi?id=168689
3082
3083         Reviewed by Alexey Proskuryakov.
3084
3085         * WebKit.exp:
3086
3087 2017-02-21  Commit Queue  <commit-queue@webkit.org>
3088
3089         Unreviewed, rolling out r212768.
3090         https://bugs.webkit.org/show_bug.cgi?id=168698
3091
3092         Rolling out since this would break other projects. (Requested
3093         by aakashjain on #webkit).
3094
3095         Reverted changeset:
3096
3097         "[iOS] Remove old WebKit1 MemoryMeasure helper."
3098         https://bugs.webkit.org/show_bug.cgi?id=168675
3099         http://trac.webkit.org/changeset/212768
3100
3101 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
3102
3103         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
3104         https://bugs.webkit.org/show_bug.cgi?id=168620
3105         <rdar://problem/30617772>
3106
3107         Reviewed by Tim Horton.
3108
3109         * WebView/WebPreferenceKeysPrivate.h:
3110         * WebView/WebPreferences.mm:
3111         (+[WebPreferences initialize]):
3112         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
3113         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
3114         * WebView/WebPreferencesPrivate.h:
3115
3116 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3117
3118         Export various NSString symbols from WebUIDelegatePrivate.h
3119         https://bugs.webkit.org/show_bug.cgi?id=168679
3120
3121         Reviewed by Joseph Pecoraro.
3122
3123         * WebKit.exp:
3124
3125 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3126
3127         Export symbols for various classes present in webkit SPI
3128         https://bugs.webkit.org/show_bug.cgi?id=168674
3129
3130         Reviewed by Dan Bernstein.
3131
3132         * WebKit.exp:
3133
3134 2017-02-21  Andreas Kling  <akling@apple.com>
3135
3136         [iOS] Remove old WebKit1 MemoryMeasure helper.
3137         <https://webkit.org/b/168675>
3138
3139         Reviewed by Sam Weinig.
3140
3141         * Configurations/WebKitLegacy.xcconfig:
3142         * Misc/WebCache.mm:
3143         (+[WebCache emptyInMemoryResources]):
3144         * WebView/WebView.mm:
3145
3146 2017-02-21  Andreas Kling  <akling@apple.com>
3147
3148         [iOS] WebKit1 should use shared memory pressure handler code.
3149         <https://webkit.org/b/168653>
3150
3151         Reviewed by Antti Koivisto.
3152
3153         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
3154         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
3155         dead code since MobileSafari has been using WebKit2 for quite a while.
3156
3157         * WebView/WebView.h:
3158         * WebView/WebView.mm:
3159         (WebInstallMemoryPressureHandler):
3160         (+[WebView _handleMemoryWarning]): Deleted.
3161         (+[WebView registerForMemoryNotifications]): Deleted.
3162         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
3163         (+[WebView garbageCollectNow]): Deleted.
3164         (+[WebView purgeInactiveFontData]): Deleted.
3165         (+[WebView drainLayerPool]): Deleted.
3166         (+[WebView discardAllCompiledCode]): Deleted.
3167         (+[WebView _clearMemoryPressure]): Deleted.
3168         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
3169         * WebView/WebViewPrivate.h:
3170
3171 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3172
3173         Stop exporting interface WebCoreScrollView on iOS
3174         https://bugs.webkit.org/show_bug.cgi?id=168536
3175
3176         Reviewed by Dan Bernstein.
3177
3178         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
3179         * WebKit.mac.exp: Ditto.
3180         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
3181
3182 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3183
3184         Exclude various mac-specific header files from iOS build
3185         https://bugs.webkit.org/show_bug.cgi?id=168621
3186
3187         Reviewed by Dan Bernstein.
3188
3189         * Configurations/WebKitLegacy.xcconfig:
3190
3191 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3192
3193         Add plumbing to the UI process for TextIndicatorData when computing the drag image
3194         https://bugs.webkit.org/show_bug.cgi?id=168583
3195         Work towards <rdar://problem/30313681>
3196
3197         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
3198
3199         Reviewed by Tim Horton.
3200
3201         * WebView/WebHTMLView.mm:
3202         (-[WebHTMLView _selectionDraggingImage]):
3203         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3204
3205 2017-02-17  Anders Carlsson  <andersca@apple.com>
3206
3207         Add a new drag code path and use it for dragging plain text
3208         https://bugs.webkit.org/show_bug.cgi?id=168534
3209
3210         Reviewed by Geoffrey Garen.
3211
3212         * WebCoreSupport/WebDragClient.h:
3213         Add new members.
3214
3215         * WebCoreSupport/WebDragClient.mm:
3216         (WebDragClient::useLegacyDragClient):
3217         Return false here.
3218
3219         (WebDragClient::beginDrag):
3220         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
3221
3222         * WebView/WebHTMLView.mm:
3223         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
3224         Get the source operation mask from WebCore.
3225
3226         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3227         Send a fake mouse up event.
3228
3229         * WebView/WebHTMLViewInternal.h:
3230         Declare that WebHTMLView conforms to NSDraggingSource.
3231
3232 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3233
3234         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3235         https://bugs.webkit.org/show_bug.cgi?id=168342
3236         rdar://problem/26182266
3237
3238         Reviewed by Tim Horton.
3239
3240         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3241         symbols to re-export.
3242
3243 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3244
3245         Stop exporting DOMTokenList from WebKit
3246         https://bugs.webkit.org/show_bug.cgi?id=168544
3247
3248         Reviewed by Alexey Proskuryakov.
3249
3250         * WebKit.exp:
3251
3252 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3253
3254         Clean up how WebKit exports _WebCreateFragment
3255         https://bugs.webkit.org/show_bug.cgi?id=168579
3256
3257         Reviewed by Dan Bernstein.
3258
3259         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3260         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3261
3262 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3263
3264         Stop exporting DOMNodeFilter
3265         https://bugs.webkit.org/show_bug.cgi?id=168542
3266
3267         Reviewed by Alexey Proskuryakov.
3268
3269         * WebKit.exp:
3270
3271 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3272
3273         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3274         https://bugs.webkit.org/show_bug.cgi?id=167693
3275
3276         Reviewed by Sergio Villar Senin.
3277
3278         * Configurations/FeatureDefines.xcconfig:
3279         * WebView/WebPreferences.mm:
3280         (+[WebPreferences initialize]):
3281         * WebView/WebView.mm:
3282         (-[WebView _preferencesChanged:]):
3283
3284 2017-02-15  Brady Eidson  <beidson@apple.com>
3285
3286         Stop backing up localStorage databases to iCloud by default.
3287         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3288
3289         Reviewed by Geoffrey Garen.
3290
3291         * Misc/WebKitVersionChecks.h:
3292         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3293         (WebKitLinkedOnOrAfter):
3294         (setWebKitLinkTimeVersion):
3295         (WebKitLinkTimeVersion):
3296         (linkedOnOrAfter):
3297
3298         * Storage/WebStorageManager.mm:
3299         (WebKitInitializeStorageIfNecessary):
3300
3301 2017-02-16  Daniel Bates  <dabates@apple.com>
3302
3303         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3304         https://bugs.webkit.org/show_bug.cgi?id=168417
3305         <rdar://problem/30541748>
3306
3307         Reviewed by Brent Fulgham.
3308
3309         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3310         Widget* as it is always called with a valid Widget.
3311
3312         * WebCoreSupport/WebFrameLoaderClient.h:
3313         * WebCoreSupport/WebFrameLoaderClient.mm:
3314         (WebFrameLoaderClient::redirectDataToPlugin):
3315         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3316         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3317         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3318
3319 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3320
3321         [JSC] Drop PassRefPtr in inspector/
3322         https://bugs.webkit.org/show_bug.cgi?id=168420
3323
3324         Reviewed by Alex Christensen.
3325
3326         * WebView/WebScriptDebugger.mm:
3327         (WebScriptDebugger::handlePause):
3328
3329 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3330
3331         Clean up use of some CALayer-related SPI
3332         https://bugs.webkit.org/show_bug.cgi?id=168401
3333
3334         Reviewed by Tim Horton.
3335
3336         Include CALayer.h not CATiledLayer.h.
3337
3338         * WebInspector/WebNodeHighlight.h:
3339
3340 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3341
3342         Fix the build after r212379
3343
3344         Rubber-stamped by Anders Carlsson.
3345
3346         * WebCoreSupport/WebDragClient.mm:
3347         (WebDragClient::startDrag):
3348
3349 2017-02-15  Anders Carlsson  <andersca@apple.com>
3350
3351         Modernize DragClient::startDrag somewhat
3352         https://bugs.webkit.org/show_bug.cgi?id=168379
3353
3354         Reviewed by Tim Horton.
3355
3356         Update for WebCore changes.
3357
3358         * WebCoreSupport/WebDragClient.h:
3359         * WebCoreSupport/WebDragClient.mm:
3360         (WebDragClient::startDrag):
3361
3362 2017-02-14  Dean Jackson  <dino@apple.com>
3363
3364         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3365         https://bugs.webkit.org/show_bug.cgi?id=168339
3366
3367         Reviewed by Simon Fraser.
3368
3369         Use a better name.
3370
3371         * WebView/WebPreferenceKeysPrivate.h:
3372         * WebView/WebPreferences.mm:
3373         (+[WebPreferences initialize]):
3374         (-[WebPreferences forceLowPowerGPUForWebGL]):
3375         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3376         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3377         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3378         * WebView/WebPreferencesPrivate.h:
3379         * WebView/WebView.mm:
3380         (-[WebView _preferencesChanged:]):
3381
3382 2017-02-14  Chris Dumez  <cdumez@apple.com>
3383
3384         HTML Form Validation bubble should take minimum font size setting into consideration
3385         https://bugs.webkit.org/show_bug.cgi?id=168271
3386         <rdar://problem/29869869>
3387
3388         Reviewed by Simon Fraser.
3389
3390         * WebView/WebView.mm:
3391         (-[WebView _contentsOfUserInterfaceItem:]):
3392         Return font size used in the validation bubble.
3393
3394         (-[WebView showFormValidationMessage:withAnchorRect:]):
3395         Pass minimum font size setting when constructing the validation bubble.
3396
3397 2017-02-14  Anders Carlsson  <andersca@apple.com>
3398
3399         Remove an unused delegate method
3400         https://bugs.webkit.org/show_bug.cgi?id=168328
3401
3402         Reviewed by Wenson Hsieh.
3403
3404         * DefaultDelegates/WebDefaultUIDelegate.m:
3405         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3406
3407 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3408
3409         WebCore shouldn't export SystemMemory.h
3410         https://bugs.webkit.org/show_bug.cgi?id=168285
3411
3412         Reviewed by Alex Christensen.
3413
3414         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3415
3416 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3417
3418         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3419         https://bugs.webkit.org/show_bug.cgi?id=168282
3420
3421         Reviewed by Dan Bernstein.
3422
3423         * MigrateHeaders.make:
3424
3425 2017-02-12  Dan Bernstein  <mitz@apple.com>
3426
3427         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3428
3429         * WebView/WebHTMLView.mm:
3430         (createShareMenuItem): Use non-deprecated method.
3431
3432 2017-02-12  Dan Bernstein  <mitz@apple.com>
3433
3434         [Cocoa] Some -respondsToSelector: checks are unnecessary
3435         https://bugs.webkit.org/show_bug.cgi?id=168183
3436
3437         Reviewed by Tim Horton.
3438
3439         * WebView/WebFullScreenController.mm:
3440         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3441           responds to -isOnActiveSpace.
3442         (-[WebFullScreenController exitFullScreen]): Ditto.
3443         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3444           NSApplication responds to -setPresentationOptions.
3445
3446         * WebView/WebHTMLView.mm:
3447         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3448         (-[WebHTMLView otherMouseDown:]): Ditto.
3449
3450         * WebView/WebImmediateActionController.mm:
3451         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3452         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3453
3454         * WebView/WebView.mm:
3455         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3456         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3457
3458 2017-02-10  Daniel Bates  <dabates@apple.com>
3459
3460         Detach frame from document when entering page cache
3461         https://bugs.webkit.org/show_bug.cgi?id=166774
3462         <rdar://problem/29904368>
3463
3464         Reviewed by Chris Dumez.
3465
3466         * WebView/WebPreferenceKeysPrivate.h:
3467         * WebView/WebPreferences.mm:
3468         (+[WebPreferences initialize]):
3469         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3470         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3471         * WebView/WebPreferencesPrivate.h:
3472         * WebView/WebView.mm:
3473         (-[WebView _preferencesChanged:]):
3474
3475 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3476
3477         [Resource Timing] Enable Resource Timing by default in Tests
3478         https://bugs.webkit.org/show_bug.cgi?id=168145
3479
3480         Reviewed by Ryosuke Niwa.
3481
3482         * WebView/WebPreferenceKeysPrivate.h:
3483         * WebView/WebPreferences.mm:
3484         (+[WebPreferences initialize]):
3485         (-[WebPreferences resourceTimingEnabled]):
3486         (-[WebPreferences setResourceTimingEnabled:]):
3487         * WebView/WebPreferencesPrivate.h:
3488         * WebView/WebView.mm:
3489         (-[WebView _preferencesChanged:]):
3490
3491 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3492
3493         cleanup WebLocalizableStrings.
3494         https://bugs.webkit.org/show_bug.cgi?id=168078
3495
3496         Reviewed by Alexey Proskuryakov.
3497
3498         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3499         as it's for each framework's own consumption, and never needs to be exported.
3500
3501 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3502
3503         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3504         https://bugs.webkit.org/show_bug.cgi?id=168096
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3509
3510 2017-02-09  Antti Koivisto  <antti@apple.com>
3511
3512         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3513         https://bugs.webkit.org/show_bug.cgi?id=167990
3514
3515         Reviewed by Sam Weinig.
3516
3517         * Misc/WebCache.mm:
3518         (+[WebCache addImageToCache:forURL:forFrame:]):
3519         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3520         * WebCoreSupport/WebSystemInterface.mm:
3521         (InitWebCoreSystemInterface):
3522
3523 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3524
3525         Don't migrate WebKit DOM headers in MigrateHeaders.make
3526         https://bugs.webkit.org/show_bug.cgi?id=167608
3527
3528         Reviewed by Darin Adler.
3529
3530         Stop migrating DOM headers that are now in WebKit.
3531
3532         * DOM/DOMDOMImplementation.h: Removed.
3533         * DOM/DOMDOMImplementation.mm: Removed.
3534         * DOM/DOMDOMImplementationInternal.h: Removed.
3535         * DOM/DOMDOMTokenList.h: Removed.
3536         * DOM/DOMDOMTokenList.mm: Removed.
3537         * DOM/DOMDOMTokenListInternal.h: Removed.
3538         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3539         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3540         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3