8a30d748fe71f014e55d11aad4fb90a52b928aa5
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r244627.
4         https://bugs.webkit.org/show_bug.cgi?id=197282
5
6         Causing internal build failures (Requested by ShawnRoberts on
7         #webkit).
8
9         Reverted changeset:
10
11         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
12         https://bugs.webkit.org/show_bug.cgi?id=197171
13         https://trac.webkit.org/changeset/244627
14
15 2019-04-24  Zalan Bujtas  <zalan@apple.com>
16
17         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
18         https://bugs.webkit.org/show_bug.cgi?id=196948
19         <rdar://problem/49927131>
20
21         Reviewed by Tim Horton.
22
23         * WebCoreSupport/WebChromeClient.h:
24
25 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
26
27         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
28         https://bugs.webkit.org/show_bug.cgi?id=197171
29         <rdar://problem/47454979>
30
31         Reviewed by Youenn Fablet.
32
33         * WebView/WebVideoFullscreenController.mm:
34         (-[WebVideoFullscreenController setVideoElement:]):
35         (-[WebVideoFullscreenController windowDidExitFullscreen]):
36         (SOFT_LINK_CLASS): Deleted.
37
38 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
39
40         Make it possible to control the renderTreeAsText output by setting options on testRunner
41         https://bugs.webkit.org/show_bug.cgi?id=197133
42
43         Reviewed by Sam Weinig.
44
45         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
46         that make sense in testing (those that don't dump unstable data like addresses), and plumb
47         these flags through the various framework layers.
48
49         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
50
51         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
52         and hand-code DumpRenderTree bindings.
53
54         Some cleanup of the TestRunners, using member initializers.
55
56         * Misc/WebCoreStatistics.h:
57         * Misc/WebCoreStatistics.mm:
58         (-[WebFrame renderTreeAsExternalRepresentationForPrinting]):
59         (toRenderAsTextFlags):
60         (-[WebFrame renderTreeAsExternalRepresentationWithOptions:]):
61         (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): Deleted.
62
63 2019-04-23  Commit Queue  <commit-queue@webkit.org>
64
65         Unreviewed, rolling out r244556.
66         https://bugs.webkit.org/show_bug.cgi?id=197212
67
68         Causing build failures on multiple builders (Requested by
69         ShawnRoberts on #webkit).
70
71         Reverted changeset:
72
73         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
74         https://bugs.webkit.org/show_bug.cgi?id=197171
75         https://trac.webkit.org/changeset/244556
76
77 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
78
79         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
80         https://bugs.webkit.org/show_bug.cgi?id=197171
81         <rdar://problem/47454979>
82
83         Reviewed by Youenn Fablet.
84
85         * WebView/WebVideoFullscreenController.mm:
86         (-[WebVideoFullscreenController setVideoElement:]):
87         (-[WebVideoFullscreenController windowDidExitFullscreen]):
88         (SOFT_LINK_CLASS): Deleted.
89
90 2019-04-23  Chris Dumez  <cdumez@apple.com>
91
92         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
93         https://bugs.webkit.org/show_bug.cgi?id=197097
94         <rdar://problem/50048318>
95
96         Reviewed by Alex Christensen.
97
98         * WebCoreSupport/WebFrameLoaderClient.h:
99         * WebCoreSupport/WebFrameLoaderClient.mm:
100         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
101
102 2019-04-18  Daniel Bates  <dabates@apple.com>
103
104         Use existing KeyEventCodesIOS constants instead of duplicating them
105         https://bugs.webkit.org/show_bug.cgi?id=197081
106
107         Rubber-stamped by Wenson Hsieh.
108
109         * WebView/WebHTMLView.mm:
110         (-[WebHTMLView _handleEditingKeyEvent:]):
111
112 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
113
114         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
115         https://bugs.webkit.org/show_bug.cgi?id=197079
116
117         Reviewed by Darin Adler.
118
119         The crash was caused by the fact deleting a node could end up deleting Objective-C event listeners
120         some of which may be the last object holding onto WebView itself in the middle of running GC.
121
122         It's not generally safe to delete Objective-C objects defiend by client applications since
123         dealloc could execute arbitrary code, and for instance, try to execute JavaScript or load new page.
124
125         Fixed the bug by delaying the dealloc'ing of Objective event listeners via autorelease pool.
126
127         * DOM/ObjCEventListener.mm:
128         (WebCore::ObjCEventListener::~ObjCEventListener):
129
130 2019-04-18  Jer Noble  <jer.noble@apple.com>
131
132         Refactoring: Pull all fullscreen code out of Document and into its own helper class
133         https://bugs.webkit.org/show_bug.cgi?id=197017
134
135         Reviewed by Eric Carlson.
136
137         * DOM/DOMDocument.mm:
138         (-[DOMDocument webkitIsFullScreen]):
139         (-[DOMDocument webkitFullScreenKeyboardInputAllowed]):
140         (-[DOMDocument webkitCurrentFullScreenElement]):
141         (-[DOMDocument webkitFullscreenEnabled]):
142         (-[DOMDocument webkitFullscreenElement]):
143         (-[DOMDocument webkitCancelFullScreen]):
144         (-[DOMDocument webkitExitFullscreen]):
145         * WebCoreSupport/WebChromeClient.mm:
146         (WebChromeClient::createWindow):
147         * WebCoreSupport/WebKitFullScreenListener.mm:
148         (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
149         (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
150         (-[WebKitFullScreenListener webkitWillExitFullScreen]):
151         (-[WebKitFullScreenListener webkitDidExitFullScreen]):
152         * WebView/WebFullScreenController.mm:
153         (-[WebFullScreenController enterFullScreen:]):
154         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
155         (-[WebFullScreenController requestExitFullScreen]):
156         (-[WebFullScreenController exitFullScreen]):
157         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
158         (-[WebFullScreenController _manager]):
159         * WebView/WebView.mm:
160         (-[WebView _didStartProvisionalLoadForFrame:]):
161
162 2019-04-17  Brady Eidson  <beidson@apple.com>
163
164         Link clicks in PDFs shouldn't send referrer headers.
165         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
166
167         Reviewed by Tim Horton.
168
169         * WebView/WebPDFView.mm:
170         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
171
172 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
173
174         requestAnimationFrame should execute before the next frame
175         https://bugs.webkit.org/show_bug.cgi?id=177484
176
177         Reviewed by Simon Fraser.
178
179         * WebView/WebView.mm:
180         (-[WebView _viewWillDrawInternal]):
181         (-[WebView _flushCompositingChanges]):
182         Call Page::updateRendering() which implements "Update the rendering"
183         step of the HTML Event Loop specification.
184
185 2019-04-10  Devin Rousso  <drousso@apple.com>
186
187         Web Inspector: save sheet should be anchored underneath the tab bar when detached
188         https://bugs.webkit.org/show_bug.cgi?id=196722
189         <rdar://problem/49613280>
190
191         Reviewed by Timothy Hatcher.
192
193         * WebCoreSupport/WebInspectorClient.h:
194         (WebInspectorFrontendClient::sheetRect const): Added.
195         * WebCoreSupport/WebInspectorClient.mm:
196         (-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
197         (WebInspectorFrontendClient::setSheetRect): Added.
198
199 2019-04-10  Alex Christensen  <achristensen@webkit.org>
200
201         Add SPI WKNavigationResponse._downloadAttribute
202         https://bugs.webkit.org/show_bug.cgi?id=196755
203         <rdar://49587365>
204
205         Reviewed by Brady Eidson.
206
207         * WebCoreSupport/WebFrameLoaderClient.h:
208         * WebCoreSupport/WebFrameLoaderClient.mm:
209         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
210
211 2019-04-10  Antoine Quint  <graouts@apple.com>
212
213         Enable Pointer Events on watchOS
214         https://bugs.webkit.org/show_bug.cgi?id=196771
215         <rdar://problem/49040909>
216
217         Reviewed by Dean Jackson.
218
219         * Configurations/FeatureDefines.xcconfig:
220
221 2019-04-08  Justin Fan  <justin_fan@apple.com>
222
223         [Web GPU] Fix Web GPU experimental feature on iOS
224         https://bugs.webkit.org/show_bug.cgi?id=196632
225
226         Reviewed by Myles C. Maxfield.
227
228         Add feature conditionals for iOS 11.
229         Properly make Web GPU available on iOS 11+.
230
231         * Configurations/FeatureDefines.xcconfig:
232         * Configurations/WebKitTargetConditionals.xcconfig:
233
234 2019-04-05  Alex Christensen  <achristensen@webkit.org>
235
236         REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on non-main thread
237         https://bugs.webkit.org/show_bug.cgi?id=190918
238         <rdar://problem/45603890>
239
240         Reviewed by Darin Adler.
241
242         Since we not doing networking on the main thread but WebView is to be used on the main thread,
243         we need to hop delegate calls to the main thread similarly to how we do it in the non-download
244         delegate calls in WebCoreResourceHandleAsOperationQueueDelegate.
245
246         * Misc/WebDownload.mm:
247         (-[WebDownloadInternal downloadDidBegin:]):
248         (-[WebDownloadInternal download:willSendRequest:redirectResponse:]):
249         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
250         (-[WebDownloadInternal download:didReceiveResponse:]):
251         (-[WebDownloadInternal download:didReceiveDataOfLength:]):
252         (-[WebDownloadInternal download:shouldDecodeSourceDataOfMIMEType:]):
253         (-[WebDownloadInternal download:decideDestinationWithSuggestedFilename:]):
254         (-[WebDownloadInternal download:didCreateDestination:]):
255         (-[WebDownloadInternal downloadDidFinish:]):
256         (-[WebDownloadInternal download:didFailWithError:]):
257
258 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
259
260         Remove AUDIO_TOOLBOX_AUDIO_SESSION
261         https://bugs.webkit.org/show_bug.cgi?id=196653
262         <rdar://problem/49652098>
263
264         Reviewed by Jer Noble.
265
266         * WebView/WebPreferences.mm:
267         (-[WebPreferences setAudioSessionCategoryOverride:]):
268
269 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
270
271         Stop including <AudioToolbox/AudioSession.h>
272         https://bugs.webkit.org/show_bug.cgi?id=196648
273         <rdar://problem/39665771>
274
275         Reviewed by Jer Noble.
276
277         * WebView/WebPreferencesPrivate.h:
278
279 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
280
281         Have ScrollableArea store a ScrollType for the current scroll
282         https://bugs.webkit.org/show_bug.cgi?id=196627
283
284         Reviewed by Zalan Bujtas.
285
286         Send the programmatic scroll type.
287
288         * DOM/DOMHTML.mm:
289         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
290
291 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
292
293         -apple-trailing-word is needed for browser detection
294         https://bugs.webkit.org/show_bug.cgi?id=196575
295
296         Unreviewed.
297
298         * Configurations/FeatureDefines.xcconfig:
299
300 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
301
302         Remove support for -apple-trailing-word
303         https://bugs.webkit.org/show_bug.cgi?id=196525
304
305         Reviewed by Zalan Bujtas.
306
307         This CSS property is nonstandard and not used.
308
309         * Configurations/FeatureDefines.xcconfig:
310
311 2019-04-01  Alex Christensen  <achristensen@webkit.org>
312
313         Add SPI to canonicalize NSURLs with WTF::URL
314         https://bugs.webkit.org/show_bug.cgi?id=196415
315         <rdar://problem/44980271>
316
317         Reviewed by Darin Adler.
318
319         * Misc/WebNSURLExtras.h:
320         * Misc/WebNSURLExtras.mm:
321         (-[NSURL _webkit_canonicalize_with_wtf]):
322         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
323         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
324
325 2019-03-31  Sam Weinig  <weinig@apple.com>
326
327         Remove more i386 specific configurations
328         https://bugs.webkit.org/show_bug.cgi?id=196430
329
330         Reviewed by Alexey Proskuryakov.
331
332         * Configurations/FeatureDefines.xcconfig:
333         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
334
335 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
336
337         Delete WebMetal implementation in favor of WebGPU
338         https://bugs.webkit.org/show_bug.cgi?id=195418
339
340         Reviewed by Dean Jackson.
341
342         * Configurations/FeatureDefines.xcconfig:
343         * WebView/WebPreferenceKeysPrivate.h:
344         * WebView/WebPreferences.mm:
345         (+[WebPreferences initialize]):
346         (-[WebPreferences webMetalEnabled]): Deleted.
347         (-[WebPreferences setWebMetalEnabled:]): Deleted.
348         * WebView/WebPreferencesPrivate.h:
349         * WebView/WebView.mm:
350         (-[WebView _preferencesChanged:]):
351
352 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
353
354         Implement ResizeObserver.
355         https://bugs.webkit.org/show_bug.cgi?id=157743
356
357         Reviewed by Simon Fraser.
358
359         * Configurations/FeatureDefines.xcconfig:
360         * WebView/WebPreferenceKeysPrivate.h:
361         * WebView/WebPreferences.mm:
362         (+[WebPreferences initialize]):
363         (-[WebPreferences resizeObserverEnabled]):
364         (-[WebPreferences setResizeObserverEnabled:]):
365         * WebView/WebPreferencesPrivate.h:
366         * WebView/WebView.mm:
367         (-[WebView _preferencesChanged:]):
368         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
369
370 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
371
372         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
373         https://bugs.webkit.org/show_bug.cgi?id=196336
374
375         Reviewed by Tim Horton.
376
377         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
378
379         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
380
381         * WebCoreSupport/PopupMenuMac.mm:
382         (PopupMenuMac::hide):
383
384 2019-03-25  Andy Estes  <aestes@apple.com>
385
386         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
387         https://bugs.webkit.org/show_bug.cgi?id=194964
388         <rdar://problem/48279441>
389
390         Reviewed by Alex Christensen.
391
392         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
393         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
394         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
395         PreviewLoaderClient alive for its lifetime. This ensures that as long as
396         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
397         by WebKit.
398
399         * WebCoreSupport/WebFrameLoaderClient.mm:
400         (WebFrameLoaderClient::createPreviewLoaderClient):
401         * WebView/WebDataSource.mm:
402         (-[WebDataSource _quickLookPreviewLoaderClient]):
403         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
404         * WebView/WebDataSourceInternal.h:
405
406 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
407
408         Remove NavigatorContentUtils in WebCore/Modules
409         https://bugs.webkit.org/show_bug.cgi?id=196070
410
411         Reviewed by Alex Christensen.
412
413         NavigatorContentUtils was to support the custom scheme spec [1].
414         However, in WebKit side, no port has supported the feature in
415         WebKit layer after EFL port was removed. So there has been the
416         only IDL implementation of the NavigatorContentUtils in WebCore.
417         So we don't need to keep the implementation in WebKit.
418
419         * Configurations/FeatureDefines.xcconfig:
420
421 2019-03-22  Keith Rollin  <krollin@apple.com>
422
423         Enable ThinLTO support in Production builds
424         https://bugs.webkit.org/show_bug.cgi?id=190758
425         <rdar://problem/45413233>
426
427         Reviewed by Daniel Bates.
428
429         Enable building with Thin LTO in Production when using Xcode 10.2 or
430         later. This change results in a 1.45% progression in PLT5. Full
431         Production build times increase about 2-3%. Incremental build times
432         are more severely affected, and so LTO is not enabled for local
433         engineering builds.
434
435         LTO is enabled only on macOS for now, until rdar://problem/49013399,
436         which affects ARM builds, is fixed.
437
438         To change the LTO setting when building locally:
439
440         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
441           command line.
442         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
443           on the command line.
444         - If building with `build-root`, specify --lto={none,thin,full} on the
445           command line.
446         - If building with Xcode, create a LocalOverrides.xcconfig file at the
447           top level of your repository directory (if needed) and define
448           WK_LTO_MODE to full, thin, or none.
449
450         * Configurations/Base.xcconfig:
451
452 2019-03-21  Andy Estes  <aestes@apple.com>
453
454         [iOS] Apple Pay should be available in documents with no user agent scripts
455         https://bugs.webkit.org/show_bug.cgi?id=196061
456         <rdar://problem/48649391>
457
458         Reviewed by Brady Eidson.
459
460         * WebView/WebFrame.mm:
461         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
462
463 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
464
465         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
466         https://bugs.webkit.org/show_bug.cgi?id=196049
467
468         Reviewed by Tim Horton.
469
470         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
471         overflow scrolling in general, so rename it.
472
473         * Configurations/FeatureDefines.xcconfig:
474
475 2019-03-13  Dean Jackson  <dino@apple.com>
476
477         Block all plugins smaller than 5x5px
478         https://bugs.webkit.org/show_bug.cgi?id=195702
479         <rdar://problem/28435204>
480
481         Reviewed by Sam Weinig.
482
483         Removed a function that was never being called.
484
485         * WebCoreSupport/WebFrameLoaderClient.h:
486         * WebCoreSupport/WebFrameLoaderClient.mm:
487         (WebFrameLoaderClient::recreatePlugin): Deleted.
488
489 2019-03-13  Keith Rollin  <krollin@apple.com>
490
491         Add support for new StagedFrameworks layout
492         https://bugs.webkit.org/show_bug.cgi?id=195543
493
494         Reviewed by Alexey Proskuryakov.
495
496         When creating the WebKit layout for out-of-band Safari/WebKit updates,
497         use an optional path prefix when called for.
498
499         * Configurations/WebKitLegacy.xcconfig:
500
501 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
502
503         Remove a site specific hack for AppleConnect plugin
504         https://bugs.webkit.org/show_bug.cgi?id=195643
505
506         Reviewed by Simon Fraser.
507
508         r66437 added a workaround for AppleConnect plugin.
509
510         Remove this code since Safari doesn't even use WebKitLegacy anymore,
511         and other WebKit clients support AppleConnect plugins.
512
513         * WebCoreSupport/WebFrameLoaderClient.mm:
514         (WebFrameLoaderClient::createPlugin):
515
516 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
517
518         Unreviewed, rolling out r242688, r242643, r242624.
519
520         Caused multiple layout test failures and crashes on iOS and macOS.
521
522         Reverted changeset:
523
524         "requestAnimationFrame should execute before the next frame"
525         https://bugs.webkit.org/show_bug.cgi?id=177484
526         https://trac.webkit.org/changeset/242624/webkit
527
528         * WebView/WebView.mm:
529         (-[WebView _viewWillDrawInternal]):
530
531 2019-03-09  Andy Estes  <aestes@apple.com>
532
533         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
534         https://bugs.webkit.org/show_bug.cgi?id=195526
535         <rdar://problem/48745636>
536
537         Reviewed by Chris Dumez.
538
539         * WebCoreSupport/WebPaymentCoordinatorClient.h:
540         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
541         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
542         (WebPaymentCoordinatorClient::openPaymentSetup):
543
544 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
545
546         requestAnimationFrame should execute before the next frame
547         https://bugs.webkit.org/show_bug.cgi?id=177484
548
549         Reviewed by Simon Fraser.
550
551         * WebView/WebView.mm:
552         (-[WebView _viewWillDrawInternal]):
553         Call Page::renderingUpdate() which implements  "Update the rendering"
554         step of the HTML Event Loop specification.
555
556 2019-03-07  Zalan Bujtas  <zalan@apple.com>
557
558         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
559         https://bugs.webkit.org/show_bug.cgi?id=195353
560         <rdar://problem/48626394>
561
562         Reviewed by Simon Fraser.
563
564         * WebView/WebPreferenceKeysPrivate.h:
565         * WebView/WebPreferences.mm:
566         (+[WebPreferences initialize]):
567         (-[WebPreferences contentChangeObserverEnabled]):
568         (-[WebPreferences setContentChangeObserverEnabled:]):
569         * WebView/WebPreferencesPrivate.h:
570         * WebView/WebView.mm:
571         (-[WebView _preferencesChanged:]):
572
573 2019-03-06  Sam Weinig  <sam@webkit.org>
574
575         WebKitLegacy does not need to generate an export file for i386 anymore
576         https://bugs.webkit.org/show_bug.cgi?id=195380
577
578         Reviewed by Dan Bernstein.
579
580         * Configurations/WebKitLegacy.xcconfig:
581         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
582         It still needs to be generated, since we are concatenating the shared exports
583         file with a macOS or iOS specific one.
584
585         * WebKit.mac.exp:
586         Remove i386 specific symbols that we were previously stripping.
587
588 2019-03-06  Rob Buis  <rbuis@igalia.com>
589
590         Consider supporting the `referrerpolicy` attribute.
591         https://bugs.webkit.org/show_bug.cgi?id=179053
592
593         Reviewed by Darin Adler.
594
595         Add a runtime flag for referrerpolicy attribute.
596
597         * WebView/WebPreferenceKeysPrivate.h:
598         * WebView/WebPreferences.mm:
599         (+[WebPreferences initialize]):
600         (-[WebPreferences referrerPolicyAttributeEnabled]):
601         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
602         * WebView/WebPreferencesPrivate.h:
603         * WebView/WebView.mm:
604         (-[WebView _preferencesChanged:]):
605
606 2019-03-03  Tim Horton  <timothy_horton@apple.com>
607
608         Remove some more unused 32-bit code
609         https://bugs.webkit.org/show_bug.cgi?id=195255
610
611         Reviewed by Darin Adler.
612
613         * Plugins/WebNetscapePluginEventHandler.mm:
614         (WebNetscapePluginEventHandler::create):
615         * Plugins/WebNetscapePluginView.h:
616         * Plugins/WebNetscapePluginView.mm:
617         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
618         (-[WebNetscapePluginView restorePortState:]):
619         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
620         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
621         (-[WebNetscapePluginView updateAndSetWindow]):
622         (-[WebNetscapePluginView setWindowIfNecessary]):
623         (-[WebNetscapePluginView createPlugin]):
624         (-[WebNetscapePluginView fini]):
625         (-[WebNetscapePluginView drawRect:]):
626         (-[WebNetscapePluginView invalidateRegion:]):
627         (-[WebNetscapePluginView getVariable:value:]):
628         (-[WebNetscapePluginView setVariable:value:]):
629         (isDrawingModelQuickDraw): Deleted.
630         (-[WebNetscapePluginView fixWindowPort]): Deleted.
631         (getQDPixelFormatForBitmapContext): Deleted.
632         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
633         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
634         * WebView/WebDelegateImplementationCaching.mm:
635
636 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
637
638         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
639         https://bugs.webkit.org/show_bug.cgi?id=195053
640         <rdar://problem/48134710>
641
642         Reviewed by Ryosuke Niwa.
643
644         * WebCoreSupport/WebEditorClient.h:
645
646 2019-03-01  Tim Horton  <timothy_horton@apple.com>
647
648         Remove unused code in WebKitLegacy
649         https://bugs.webkit.org/show_bug.cgi?id=189614
650
651         Reviewed by Simon Fraser.
652
653         * Carbon/CarbonUtils.h: Removed.
654         * Carbon/CarbonUtils.m: Removed.
655         * Carbon/CarbonWindowAdapter.h: Removed.
656         * Carbon/CarbonWindowAdapter.mm: Removed.
657         * Carbon/CarbonWindowContentView.h: Removed.
658         * Carbon/CarbonWindowContentView.m: Removed.
659         * Carbon/CarbonWindowFrame.h: Removed.
660         * Carbon/CarbonWindowFrame.m: Removed.
661         * Carbon/HIViewAdapter.h: Removed.
662         * Carbon/HIViewAdapter.m: Removed.
663         * Carbon/HIWebView.h: Removed.
664         * Carbon/HIWebView.mm: Removed.
665         * Configurations/WebKitLegacy.xcconfig:
666         * WebKit.mac.exp:
667
668 2019-03-01  Justin Fan  <justin_fan@apple.com>
669
670         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
671         https://bugs.webkit.org/show_bug.cgi?id=195191
672
673         Rubber-stamped by Dean Jackson.
674
675         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
676
677         * Configurations/FeatureDefines.xcconfig:
678
679 2019-02-28  Antoine Quint  <graouts@apple.com>
680
681         Enable the Pointer Events runtime flag by default
682         https://bugs.webkit.org/show_bug.cgi?id=195156
683
684         Reviewed by Dean Jackson.
685
686         * WebView/WebPreferences.mm:
687         (+[WebPreferences initialize]):
688
689 2019-02-28  Justin Fan  <justin_fan@apple.com>
690
691         [Web GPU] Enable Web GPU only on 64-bit
692         https://bugs.webkit.org/show_bug.cgi?id=195139
693
694         Because Metal is only supported on 64 bit apps.
695
696         Unreviewed build fix.
697
698         * Configurations/FeatureDefines.xcconfig:
699
700 2019-02-27  Antoine Quint  <graouts@apple.com>
701
702         Support Pointer Events on macOS
703         https://bugs.webkit.org/show_bug.cgi?id=195008
704         <rdar://problem/47454419>
705
706         Reviewed by Dean Jackson.
707
708         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
709
710         * Configurations/FeatureDefines.xcconfig:
711         * WebView/WebPreferenceKeysPrivate.h:
712         * WebView/WebPreferences.mm:
713         (+[WebPreferences initialize]):
714         (-[WebPreferences pointerEventsEnabled]):
715         (-[WebPreferences setPointerEventsEnabled:]):
716         * WebView/WebPreferencesPrivate.h:
717         * WebView/WebView.mm:
718         (-[WebView _preferencesChanged:]):
719
720 2019-02-23  Keith Miller  <keith_miller@apple.com>
721
722         Add new mac target numbers
723         https://bugs.webkit.org/show_bug.cgi?id=194955
724
725         Reviewed by Tim Horton.
726
727         * Configurations/Base.xcconfig:
728         * Configurations/DebugRelease.xcconfig:
729
730 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
731
732         Hardcode Visual Viewports on everywhere except iOS WK1
733         https://bugs.webkit.org/show_bug.cgi?id=194928
734
735         Reviewed by Zalan Bujtas.
736
737         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
738         change the default value of the Setting to 'true', and hardcode WebView on iOS to
739         set it to false. The setting has shipped for several years and there's no need to turn
740         it off now.
741
742         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
743         Visual Viewports are not enabled.
744         
745         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
746         that only runs in WK2
747
748         * WebView/WebPreferenceKeysPrivate.h:
749         * WebView/WebPreferences.mm:
750         (+[WebPreferences initialize]):
751         (-[WebPreferences visualViewportEnabled]): Deleted.
752         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
753         * WebView/WebPreferencesPrivate.h:
754         * WebView/WebView.mm:
755         (-[WebView _preferencesChanged:]):
756
757 2019-02-21  Darin Adler  <darin@apple.com>
758
759         Some refinements for Node and Document
760         https://bugs.webkit.org/show_bug.cgi?id=194764
761
762         Reviewed by Ryosuke Niwa.
763
764         * DOM/DOMDocument.mm:
765         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
766         through to WebCore or even looking at the arguments.
767         (-[DOMDocument getOverrideStyle::]): Ditto.
768
769 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
770
771         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
772         https://bugs.webkit.org/show_bug.cgi?id=194670
773         <rdar://problem/39066529>
774
775         Reviewed by Tim Horton.
776
777         * WebCoreSupport/WebEditorClient.h:
778         * WebCoreSupport/WebEditorClient.mm:
779         (WebEditorClient::replacementURLForResource): Deleted.
780         * WebCoreSupport/WebPlatformStrategies.h:
781         * WebCoreSupport/WebPlatformStrategies.mm:
782         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
783
784 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
785
786         Add MSE logging configuration
787         https://bugs.webkit.org/show_bug.cgi?id=194719
788         <rdar://problem/48122151>
789
790         Reviewed by Joseph Pecoraro.
791
792         * WebCoreSupport/WebChromeClient.mm:
793         (stringForMessageSource): Recognize the MSE message source.
794
795 2019-02-17  David Kilzer  <ddkilzer@apple.com>
796
797         Unreviewed, rolling out r241620.
798
799         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
800         (Requested by ddkilzer on #webkit.)
801
802         Reverted changeset:
803
804         "[WTF] Add environment variable helpers"
805         https://bugs.webkit.org/show_bug.cgi?id=192405
806         https://trac.webkit.org/changeset/241620
807
808 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
809
810         [WTF] Add environment variable helpers
811         https://bugs.webkit.org/show_bug.cgi?id=192405
812
813         Reviewed by Michael Catanzaro.
814
815         * WebView/WebView.mm:
816         (-[WebView _initWithFrame:frameName:groupName:]):
817         Utilize WTF::Environment where possible.
818
819 2019-02-15  Brian Burg  <bburg@apple.com>
820
821         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
822         https://bugs.webkit.org/show_bug.cgi?id=194411
823         <rdar://problem/47787614>
824
825         Reviewed by Joseph Pecoraro.
826
827         * Configurations/WebKitLegacy.xcconfig:
828         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
829
830         * WebCoreSupport/WebInspectorClient.mm:
831         (WebInspectorFrontendClient::localizedStringsURL):
832         (-[WebInspectorWindowController inspectorPagePath]):
833         (-[WebInspectorWindowController inspectorTestPagePath]):
834         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
835
836 2019-02-15  Commit Queue  <commit-queue@webkit.org>
837
838         Unreviewed, rolling out r241559 and r241566.
839         https://bugs.webkit.org/show_bug.cgi?id=194710
840
841         Causes layout test crashes under GuardMalloc (Requested by
842         ryanhaddad on #webkit).
843
844         Reverted changesets:
845
846         "[WTF] Add environment variable helpers"
847         https://bugs.webkit.org/show_bug.cgi?id=192405
848         https://trac.webkit.org/changeset/241559
849
850         "Unreviewed build fix for WinCairo Debug after r241559."
851         https://trac.webkit.org/changeset/241566
852
853 2019-02-15  Truitt Savell  <tsavell@apple.com>
854
855         Unreviewed, rolling out r241564.
856
857         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
858
859         Reverted changeset:
860
861         "[Mac] WebInspectorUI.framework does not need to be soft-
862         linked anymore"
863         https://bugs.webkit.org/show_bug.cgi?id=194411
864         https://trac.webkit.org/changeset/241564
865
866 2019-02-14  Brian Burg  <bburg@apple.com>
867
868         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
869         https://bugs.webkit.org/show_bug.cgi?id=194411
870         <rdar://problem/47787614>
871
872         Reviewed by Joseph Pecoraro.
873
874         * Configurations/WebKitLegacy.xcconfig:
875         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
876
877         * WebCoreSupport/WebInspectorClient.mm:
878         (WebInspectorFrontendClient::localizedStringsURL):
879         (-[WebInspectorWindowController inspectorPagePath]):
880         (-[WebInspectorWindowController inspectorTestPagePath]):
881         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
882
883 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
884
885         [WTF] Add environment variable helpers
886         https://bugs.webkit.org/show_bug.cgi?id=192405
887
888         Reviewed by Michael Catanzaro.
889
890         * WebView/WebView.mm:
891         (-[WebView _initWithFrame:frameName:groupName:]):
892         Utilize WTF::Environment where possible.
893
894 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
895
896         Allow pages to trigger programmatic paste from script on iOS
897         https://bugs.webkit.org/show_bug.cgi?id=194271
898         <rdar://problem/47808810>
899
900         Reviewed by Ryosuke Niwa.
901
902         See WebCore and WebKit ChangeLogs for more details.
903
904         * WebCoreSupport/WebEditorClient.h:
905
906 2019-02-12  Andy Estes  <aestes@apple.com>
907
908         [iOSMac] Enable Parental Controls Content Filtering
909         https://bugs.webkit.org/show_bug.cgi?id=194521
910         <rdar://39732376>
911
912         Reviewed by Tim Horton.
913
914         * Configurations/FeatureDefines.xcconfig:
915
916 2019-02-06  Andy Estes  <aestes@apple.com>
917
918         [Payment Request] It should be possible to require a phonetic name for shipping contacts
919         https://bugs.webkit.org/show_bug.cgi?id=194311
920         <rdar://46733045>
921
922         Reviewed by Alex Christensen.
923
924         * WebCoreSupport/WebPaymentCoordinatorClient.h:
925         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
926         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
927
928 2019-02-04  Said Abou-Hallawa  <said@apple.com>
929
930         [CG] Enable setAdditionalSupportedImageTypes for WK1
931         https://bugs.webkit.org/show_bug.cgi?id=194190
932
933         Reviewed by Tim Horton.
934
935         1. Define the preferences key AdditionalSupportedImageTypes.
936         2. Add additionalSupportedImageTypes as a private preference property.
937         3. Define the setter and the getter of the property.
938         4. Add function to convert from an id to an array of strings.
939         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
940
941         * WebView/WebPreferenceKeysPrivate.h:
942         * WebView/WebPreferences.mm:
943         (-[WebPreferences _stringArrayValueForKey:]):
944         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
945         (-[WebPreferences setAdditionalSupportedImageTypes:]):
946         (-[WebPreferences additionalSupportedImageTypes]):
947         * WebView/WebPreferencesPrivate.h:
948         * WebView/WebView.mm:
949         (-[WebView _preferencesChanged:]):
950
951 2019-02-04  Timothy Hatcher  <timothy@apple.com>
952
953         Add WebView SPI to temporarily force light or dark appearance on a page.
954         https://bugs.webkit.org/show_bug.cgi?id=194230
955
956         Reviewed by Tim Horton.
957
958         * WebView/WebView.mm:
959         (-[WebView _useDarkAppearance:]): Added.
960         (-[WebView _setUseDarkAppearance:]): Added.
961         * WebView/WebViewPrivate.h:
962
963 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
964
965         PageOverlayController's layers should be created lazily
966         https://bugs.webkit.org/show_bug.cgi?id=194199
967         rdar://problem/46571593
968
969         Reviewed by Tim Horton.
970
971         * WebCoreSupport/WebChromeClient.h:
972         * WebCoreSupport/WebChromeClient.mm:
973         (WebChromeClient::attachViewOverlayGraphicsLayer):
974
975 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
976
977         Make setNeedsLayout on the root more explicitly about triggering its side-effects
978         https://bugs.webkit.org/show_bug.cgi?id=194198
979
980         Reviewed by Antti Koivisto.
981
982         Call the newly named functions.
983
984         * WebView/WebFrame.mm:
985         (-[WebFrame setNeedsLayout]):
986         * WebView/WebHTMLView.mm:
987         (-[WebHTMLView setNeedsLayout:]):
988
989 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
990
991         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
992         https://bugs.webkit.org/show_bug.cgi?id=194189
993
994         Reviewed by Geoffrey Garen.
995
996         Pass the policy check identifier around functions and store it in WebFramePolicyListener
997         so that we can send it back to WebCore with the navigation policy decision.
998
999         * WebCoreSupport/WebFrameLoaderClient.h:
1000         * WebCoreSupport/WebFrameLoaderClient.mm:
1001         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1002         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1003         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1004         (WebFrameLoaderClient::dispatchWillSubmitForm):
1005         (WebFrameLoaderClient::setUpPolicyListener):
1006         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
1007         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
1008         (-[WebFramePolicyListener invalidate]):
1009         (-[WebFramePolicyListener dealloc]):
1010         (-[WebFramePolicyListener receivedPolicyDecision:]):
1011         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
1012         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
1013
1014 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1015
1016         Revert r238819 which is unneeded and caused a performance regression.
1017         https://bugs.webkit.org/show_bug.cgi?id=192272
1018         <rdar://problem/46664625>
1019
1020         * WebCoreSupport/WebFrameLoaderClient.h:
1021         * WebCoreSupport/WebFrameLoaderClient.mm:
1022         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1023
1024 2019-01-28  Devin Rousso  <drousso@apple.com>
1025
1026         Web Inspector: provide a way to edit page WebRTC settings on a remote target
1027         https://bugs.webkit.org/show_bug.cgi?id=193863
1028         <rdar://problem/47572764>
1029
1030         Reviewed by Joseph Pecoraro.
1031
1032         * WebView/WebView.mm:
1033         (-[WebView _preferencesChanged:]):
1034         Add page-level settings for WebRTC preferences.
1035
1036 2019-01-28  Andy Estes  <aestes@apple.com>
1037
1038         [watchOS] Enable Parental Controls content filtering
1039         https://bugs.webkit.org/show_bug.cgi?id=193939
1040         <rdar://problem/46641912>
1041
1042         Reviewed by Ryosuke Niwa.
1043
1044         * Configurations/FeatureDefines.xcconfig:
1045
1046 2019-01-28  Timothy Hatcher  <timothy@apple.com>
1047
1048         Make it easier for non-Apple ports to enable dark mode CSS support.
1049         https://bugs.webkit.org/show_bug.cgi?id=193882
1050
1051         Reviewed by Megan Gardner.
1052
1053         * WebView/WebView.mm:
1054         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
1055         (-[WebView _effectiveAppearanceIsDark]): Ditto.
1056
1057 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1058
1059         AX: Introduce a static accessibility tree
1060         https://bugs.webkit.org/show_bug.cgi?id=193348
1061         <rdar://problem/47203295>
1062
1063         Reviewed by Ryosuke Niwa.
1064
1065         * Configurations/FeatureDefines.xcconfig:
1066
1067 2019-01-25  Keith Rollin  <krollin@apple.com>
1068
1069         Update WebKitAdditions.xcconfig with correct order of variable definitions
1070         https://bugs.webkit.org/show_bug.cgi?id=193793
1071         <rdar://problem/47532439>
1072
1073         Reviewed by Alex Christensen.
1074
1075         XCBuild changes the way xcconfig variables are evaluated. In short,
1076         all config file assignments are now considered in part of the
1077         evaluation. When using the new build system and an .xcconfig file
1078         contains multiple assignments of the same build setting:
1079
1080         - Later assignments using $(inherited) will inherit from earlier
1081           assignments in the xcconfig file.
1082         - Later assignments not using $(inherited) will take precedence over
1083           earlier assignments. An assignment to a more general setting will
1084           mask an earlier assignment to a less general setting. For example,
1085           an assignment without a condition ('FOO = bar') will completely mask
1086           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
1087
1088         This affects some of our .xcconfig files, in that sometimes platform-
1089         or sdk-specific definitions appear before the general definitions.
1090         Under the new evaluations rules, the general definitions alway take
1091         effect because they always overwrite the more-specific definitions. The
1092         solution is to swap the order, so that the general definitions are
1093         established first, and then conditionally overwritten by the
1094         more-specific definitions.
1095
1096         * Configurations/Version.xcconfig:
1097         * Configurations/WebKitLegacy.xcconfig:
1098
1099 2019-01-25  David Kilzer  <ddkilzer@apple.com>
1100
1101         Move soft-linking of Lookup.framework out of LookupSPI.h
1102         <https://webkit.org/b/193815>
1103
1104         Reviewed by Tim Horton.
1105
1106         * WebView/WebImmediateActionController.mm:
1107         (-[WebImmediateActionController _animationControllerForText]):
1108         * WebView/WebView.mm:
1109         (-[WebView _prepareForDictionaryLookup]):
1110         - Move soft-linking to LookupSoftLink.{h,mm}.
1111
1112 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1113
1114         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
1115         https://bugs.webkit.org/show_bug.cgi?id=193829
1116
1117         Reviewed by Tim Horton.
1118
1119         * WebCoreSupport/WebDragClient.mm:
1120         (WebDragClient::didConcludeEditDrag):
1121         * WebView/WebView.mm:
1122         (-[WebView _requestStartDataInteraction:globalPosition:]):
1123         (-[WebView _didConcludeEditDrag]):
1124         (-[WebView _didConcludeEditDataInteraction]): Deleted.
1125         * WebView/WebViewInternal.h:
1126
1127 2019-01-24  John Wilander  <wilander@apple.com>
1128
1129         Add Ad Click Attribution as an internal/experimental feature
1130         https://bugs.webkit.org/show_bug.cgi?id=193685
1131         <rdar://problem/47450399>
1132
1133         Reviewed by Brent Fulgham.
1134
1135         * WebView/WebPreferenceKeysPrivate.h:
1136         * WebView/WebPreferences.mm:
1137         (+[WebPreferences initialize]):
1138         (-[WebPreferences adClickAttributionEnabled]):
1139         (-[WebPreferences setAdClickAttributionEnabled:]):
1140             Added support for experimental ad click attribution.
1141         * WebView/WebPreferencesPrivate.h:
1142         * WebView/WebView.mm:
1143         (-[WebView _preferencesChanged:]):
1144
1145 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1146
1147         Move FileSystem to WTF
1148         https://bugs.webkit.org/show_bug.cgi?id=193602
1149
1150         Reviewed by Yusuke Suzuki.
1151
1152         * Misc/WebNSFileManagerExtras.mm:
1153         * Storage/WebDatabaseProvider.mm:
1154         * WebView/WebView.mm:
1155
1156 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
1157
1158         Fix the Apple Internal build. See <rdar://problem/47491383>.
1159
1160         Rubber-stamped by Tim Horton.
1161
1162         * WebCoreSupport/WebFrameLoaderClient.mm:
1163
1164 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
1165
1166         Clean up USE(WEB_THREAD)
1167         https://bugs.webkit.org/show_bug.cgi?id=193698
1168
1169         Rubber-stamped by Tim Horton.
1170
1171         * Misc/WebCache.mm:
1172         (+[WebCache emptyInMemoryResources]):
1173         * WebCoreSupport/WebFrameLoaderClient.mm:
1174         (-[WebFramePolicyListener use]):
1175         * WebCoreSupport/WebGeolocationClient.mm:
1176         (-[WebGeolocationPolicyListener allow]):
1177         (-[WebGeolocationPolicyListener deny]):
1178         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
1179         * WebView/WebFrame.mm:
1180         (-[WebFrame deviceOrientationChanged]):
1181         * WebView/WebHTMLView.mm:
1182         (hardwareKeyboardAvailabilityChangedCallback):
1183         * WebView/WebView.mm:
1184         (+[WebView _releaseMemoryNow]):
1185         (+[WebView willEnterBackgroundWithCompletionHandler:]):
1186         (-[WebView updateLayoutIgnorePendingStyleSheets]):
1187         (-[WebView _dispatchUnloadEvent]):
1188         (-[WebView _close]):
1189         (-[WebView _preferencesChangedNotification:]):
1190         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1191         (-[WebView goBack]):
1192         (-[WebView goForward]):
1193         (+[WebView _cacheModelChangedNotification:]):
1194         (-[WebView stopLoading:]):
1195         (-[WebView stopLoadingAndClear]):
1196         (-[WebView reload:]):
1197         (WebInstallMemoryPressureHandler):
1198
1199 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
1202         https://bugs.webkit.org/show_bug.cgi?id=193706
1203         <rdar://problem/44807048>
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         Use UndoStep::label().
1208
1209         * WebCoreSupport/WebEditorClient.h:
1210         * WebCoreSupport/WebEditorClient.mm:
1211         (-[WebUndoStep initWithUndoStep:]):
1212         (+[WebUndoStep stepWithUndoStep:]):
1213         (WebEditorClient::registerUndoOrRedoStep):
1214         (WebEditorClient::registerUndoStep):
1215         (WebEditorClient::registerRedoStep):
1216
1217 2019-01-22  Alex Christensen  <achristensen@webkit.org>
1218
1219         Move NetworkStorageSession ownership to NetworkProcess
1220         https://bugs.webkit.org/show_bug.cgi?id=193580
1221
1222         Reviewed by Geoff Garen.
1223
1224         * Misc/WebCache.mm:
1225         (+[WebCache clearCachedCredentials]):
1226         * Misc/WebDownload.mm:
1227         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1228         * Plugins/WebBaseNetscapePluginView.mm:
1229         (WebKit::getAuthenticationInfo):
1230         * WebCoreSupport/WebFrameNetworkingContext.mm:
1231         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1232         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1233         (WebFrameNetworkingContext::storageSession const):
1234         * WebView/WebPreferences.mm:
1235         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1236         (+[WebPreferences _clearNetworkLoaderSession]):
1237         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1238
1239 2019-01-22  Daniel Bates  <dabates@apple.com>
1240
1241         [iOS] Interpret text key commands on keydown and app key commands on keypress
1242         https://bugs.webkit.org/show_bug.cgi?id=192897
1243         <rdar://problem/46857378>
1244
1245         Reviewed by Brent Fulgham.
1246
1247         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
1248         is false) and keypress (isCharEvent is true), respectively.
1249
1250         * WebView/WebHTMLView.mm:
1251         (-[WebHTMLView _handleEditingKeyEvent:]):
1252
1253 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1254
1255         [css-logical] Implement flow-relative margin, padding and border shorthands
1256         https://bugs.webkit.org/show_bug.cgi?id=188697
1257
1258         Reviewed by Simon Fraser and Antti Koivisto.
1259
1260         Add CSSLogicalEnabled runtime flag.
1261
1262         * WebView/WebPreferenceKeysPrivate.h:
1263         * WebView/WebPreferences.mm:
1264         (+[WebPreferences initialize]):
1265         (-[WebPreferences cssLogicalEnabled]):
1266         (-[WebPreferences setCSSLogicalEnabled:]):
1267         * WebView/WebPreferencesPrivate.h:
1268         * WebView/WebView.mm:
1269         (-[WebView _preferencesChanged:]):
1270
1271 2019-01-15  Darin Adler  <darin@apple.com>
1272
1273         Use references rather than pointers for register/unregister functions, and more
1274         https://bugs.webkit.org/show_bug.cgi?id=175028
1275
1276         Reviewed by Daniel Bates.
1277
1278         * WebCoreSupport/WebKitFullScreenListener.mm:
1279         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1280         functions in Document; pass a reference.
1281         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1282         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1283         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1284         * WebView/WebFullScreenController.mm:
1285         (-[WebFullScreenController enterFullScreen:]): Ditto.
1286         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1287         (-[WebFullScreenController exitFullScreen]): Ditto.
1288         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1289         * WebView/WebFullScreenController.mm:
1290         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1291
1292 2019-01-12  Dan Bernstein  <mitz@apple.com>
1293
1294         [Cocoa] Avoid importing directly from subumbrella frameworks
1295         https://bugs.webkit.org/show_bug.cgi?id=186016
1296         <rdar://problem/40591038>
1297
1298         Reviewed by Sam Weinig.
1299
1300         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1301         * Carbon/CarbonWindowAdapter.mm: Ditto.
1302         * Carbon/CarbonWindowFrame.m: Ditto.
1303         * Carbon/HIViewAdapter.h: Ditto.
1304         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1305           OTHER_CFLAGS_COCOA_TOUCH_NO.
1306         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1307         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1308         * WebView/WebPDFView.h: Ditto.
1309
1310 2019-01-20  Antoine Quint  <graouts@apple.com>
1311
1312         Add a POINTER_EVENTS feature flag
1313         https://bugs.webkit.org/show_bug.cgi?id=193577
1314         <rdar://problem/47408511>
1315
1316         Unreviewed. Also enable Pointer Events for iosmac.
1317
1318         * Configurations/FeatureDefines.xcconfig:
1319
1320 2019-01-19  Antoine Quint  <graouts@apple.com>
1321
1322         Add a POINTER_EVENTS feature flag
1323         https://bugs.webkit.org/show_bug.cgi?id=193577
1324
1325         Reviewed by Dean Jackson.
1326
1327         * Configurations/FeatureDefines.xcconfig:
1328
1329 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1330
1331         Revert r238815, it broke WK1 video fullscreen on Mac
1332         https://bugs.webkit.org/show_bug.cgi?id=193586
1333         <rdar://problem/47358941>
1334
1335         Reviewed by Jer Noble.
1336
1337         * WebView/WebVideoFullscreenController.h: Added.
1338         * WebView/WebVideoFullscreenController.mm: Added.
1339         (SOFT_LINK_CLASS):
1340         (-[WebVideoFullscreenController init]):
1341         (-[WebVideoFullscreenController dealloc]):
1342         (-[WebVideoFullscreenController fullscreenWindow]):
1343         (-[WebVideoFullscreenController windowDidLoad]):
1344         (-[WebVideoFullscreenController videoElement]):
1345         (-[WebVideoFullscreenController setVideoElement:]):
1346         (-[WebVideoFullscreenController clearFadeAnimation]):
1347         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1348         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1349         (-[WebVideoFullscreenController videoElementRect]):
1350         (-[WebVideoFullscreenController applicationDidResignActive:]):
1351         (frameExpandedToRatioOfFrame):
1352         (createBackgroundFullscreenWindow):
1353         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1354         (-[WebVideoFullscreenController enterFullscreen:]):
1355         (-[WebVideoFullscreenController exitFullscreen]):
1356         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1357         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1358         (-[WebVideoFullscreenController _requestExit]):
1359         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1360         (-[WebVideoFullscreenController requestExitFullscreen]):
1361         (-[WebVideoFullscreenController fadeHUDIn]):
1362         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1363         (-[WebVideoFullscreenController rateChanged:]):
1364         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1365         (-[WebVideoFullscreenWindow dealloc]):
1366         (-[WebVideoFullscreenWindow resignFirstResponder]):
1367         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1368         (-[WebVideoFullscreenWindow mouseDown:]):
1369         (-[WebVideoFullscreenWindow cancelOperation:]):
1370         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1371         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1372         (-[WebVideoFullscreenWindow animationDidEnd:]):
1373         (-[WebVideoFullscreenWindow mouseMoved:]):
1374         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1375         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1376         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1377         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1378         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1379         (-[WebVideoFullscreenHUDWindow center]):
1380         (-[WebVideoFullscreenHUDWindow keyDown:]):
1381         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1382         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1383         (-[WebVideoFullscreenHUDWindowController init]):
1384         (-[WebVideoFullscreenHUDWindowController dealloc]):
1385         (-[WebVideoFullscreenHUDWindowController setArea:]):
1386         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1387         (-[WebVideoFullscreenHUDWindowController delegate]):
1388         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1389         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1390         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1391         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1392         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1393         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1394         (createMediaUIControl):
1395         (createControlWithMediaUIControlType):
1396         (createTimeTextField):
1397         (createMediaUIBackgroundView):
1398         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1399         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1400         (-[WebVideoFullscreenHUDWindowController updateTime]):
1401         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1402         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1403         (-[WebVideoFullscreenHUDWindowController currentTime]):
1404         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1405         (-[WebVideoFullscreenHUDWindowController duration]):
1406         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1407         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1408         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1409         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1410         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1411         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1412         (-[WebVideoFullscreenHUDWindowController volume]):
1413         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1414         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1415         (-[WebVideoFullscreenHUDWindowController updateRate]):
1416         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1417         (-[WebVideoFullscreenHUDWindowController playing]):
1418         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1419         (timeToString):
1420         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1421         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1422         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1423         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1424         (-[WebVideoFullscreenHUDWindowController rewind:]):
1425         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1426         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1427         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1428         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1429         * WebView/WebView.mm:
1430         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1431         (-[WebView _exitVideoFullscreen]):
1432
1433 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1434
1435         Get rid of ADVANCED_SPELL_CHECKING
1436         https://bugs.webkit.org/show_bug.cgi?id=193592
1437
1438         Reviewed by Wenson Hsieh.
1439
1440         * WebCoreSupport/WebEditorClient.mm:
1441         (insertionPointFromCurrentSelection):
1442         (WebEditorClient::checkTextOfParagraph):
1443         (WebEditorClient::getGuessesForWord):
1444         (WebEditorClient::requestCandidatesForSelection):
1445         (WebEditorClient::requestCheckingOfString):
1446         * WebView/WebHTMLView.mm:
1447         (-[WebHTMLView insertText:]):
1448
1449 2019-01-18  Jer Noble  <jer.noble@apple.com>
1450
1451         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1452         https://bugs.webkit.org/show_bug.cgi?id=189553
1453
1454         Reviewed by Tim Horton.
1455
1456         * Configurations/Base.xcconfig:
1457         * Configurations/SDKVariant.xcconfig: Added.
1458         * Configurations/WebKitLegacy.xcconfig:
1459
1460 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1461
1462         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1463         <https://webkit.org/b/193568>
1464         <rdar://problem/47381130>
1465
1466         Reviewed by Alex Christensen.
1467
1468         * WebView/WebView.mm:
1469         - Remove unused soft-linking macros.
1470         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1471         (-[WebUITextIndicatorData initWithImage:scale:]):
1472         - Update to use exported PAL functions.
1473
1474 2019-01-17  Truitt Savell  <tsavell@apple.com>
1475
1476         Unreviewed, rolling out r240124.
1477
1478         This commit broke an internal build.
1479
1480         Reverted changeset:
1481
1482         "SDK_VARIANT build destinations should be separate from non-
1483         SDK_VARIANT builds"
1484         https://bugs.webkit.org/show_bug.cgi?id=189553
1485         https://trac.webkit.org/changeset/240124
1486
1487 2019-01-17  Jer Noble  <jer.noble@apple.com>
1488
1489         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1490         https://bugs.webkit.org/show_bug.cgi?id=189553
1491
1492         Reviewed by Tim Horton.
1493
1494         * Configurations/Base.xcconfig:
1495         * Configurations/SDKVariant.xcconfig: Added.
1496         * Configurations/WebKitLegacy.xcconfig:
1497
1498 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1499
1500         Stop using NetworkStorageSession::storageSession in WebCore
1501         https://bugs.webkit.org/show_bug.cgi?id=193529
1502
1503         Reviewed by Tim Horton.
1504
1505         * Misc/WebCache.mm:
1506         (+[WebCache addImageToCache:forURL:forFrame:]):
1507         * WebView/WebView.mm:
1508         (-[WebView _commonInitializationWithFrameName:groupName:]):
1509         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1510
1511 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1512
1513         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1514         https://bugs.webkit.org/show_bug.cgi?id=193368
1515
1516         Reviewed by Geoff Garen.
1517
1518         * Misc/WebCache.mm:
1519         (+[WebCache clearCachedCredentials]):
1520         * Misc/WebDownload.mm:
1521         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1522         * Plugins/WebBaseNetscapePluginView.mm:
1523         (WebKit::getAuthenticationInfo):
1524
1525 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1526
1527         Stop using CookiesStrategy
1528         https://bugs.webkit.org/show_bug.cgi?id=161106
1529
1530         Reviewed by Don Olmstead and Antti Koivisto.
1531
1532         * Misc/WebCache.mm:
1533         (+[WebCache addImageToCache:forURL:forFrame:]):
1534         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1535         (WebKit::NetscapePluginInstanceProxy::getCookies):
1536         (WebKit::NetscapePluginInstanceProxy::setCookies):
1537         * Plugins/WebNetscapePluginView.mm:
1538         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1539         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1540         * WebCoreSupport/WebPlatformStrategies.h:
1541         * WebCoreSupport/WebPlatformStrategies.mm:
1542         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1543         (WebPlatformStrategies::cookiesForDOM): Deleted.
1544         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1545         (WebPlatformStrategies::cookiesEnabled): Deleted.
1546         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1547         (WebPlatformStrategies::getRawCookies): Deleted.
1548         (WebPlatformStrategies::deleteCookie): Deleted.
1549         * WebView/WebView.mm:
1550         (-[WebView _commonInitializationWithFrameName:groupName:]):
1551         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1552
1553 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1554
1555         Cannot tab out of WKWebView on macOS
1556         https://bugs.webkit.org/show_bug.cgi?id=161448
1557         <rdar://problem/28100085>
1558
1559         Reviewed by Dean Jackson.
1560
1561         * WebCoreSupport/WebChromeClient.mm:
1562         * WebView/WebView.mm:
1563         Make use of SPI headers.
1564
1565 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1566
1567         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1568         r239913, and r239914.
1569         https://bugs.webkit.org/show_bug.cgi?id=193407
1570
1571         These revisions caused an internal failure (Requested by
1572         Truitt on #webkit).
1573
1574         Reverted changesets:
1575
1576         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1577         https://bugs.webkit.org/show_bug.cgi?id=186016
1578         https://trac.webkit.org/changeset/239901
1579
1580         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1581         https://trac.webkit.org/changeset/239909
1582
1583         "Tried to fix the build."
1584         https://trac.webkit.org/changeset/239910
1585
1586         "Fixed iOS builds after r239910."
1587         https://trac.webkit.org/changeset/239912
1588
1589         "More build fixing."
1590         https://trac.webkit.org/changeset/239913
1591
1592         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1593         https://trac.webkit.org/changeset/239914
1594
1595 2019-01-14  Mark Lam  <mark.lam@apple.com>
1596
1597         Re-enable ability to build --cloop builds.
1598         https://bugs.webkit.org/show_bug.cgi?id=192955
1599         <rdar://problem/46882363>
1600
1601         Reviewed by Saam barati and Keith Miller.
1602
1603         * Configurations/FeatureDefines.xcconfig:
1604
1605 2019-01-13  Dan Bernstein  <mitz@apple.com>
1606
1607         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1608
1609         Patch by Keith Rollin.
1610
1611         * WebView/PDFViewSPI.h:
1612
1613 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1614
1615         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1616         https://bugs.webkit.org/show_bug.cgi?id=191655
1617         rdar://problem/46074680
1618
1619         Reviewed by Megan Gardner.
1620
1621         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1622         * WebView/WebView.mm:
1623         (-[WebView _effectiveAppearanceIsDark]):
1624
1625 2019-01-12  Dan Bernstein  <mitz@apple.com>
1626
1627         [Cocoa] Avoid importing directly from subumbrella frameworks
1628         https://bugs.webkit.org/show_bug.cgi?id=186016
1629         <rdar://problem/40591038>
1630
1631         Reviewed by Sam Weinig.
1632
1633         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1634         * Carbon/CarbonWindowAdapter.mm: Ditto.
1635         * Carbon/CarbonWindowFrame.m: Ditto.
1636         * Carbon/HIViewAdapter.h: Ditto.
1637         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1638           OTHER_CFLAGS_COCOA_TOUCH_NO.
1639         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1640         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1641         * WebView/WebPDFView.h: Ditto.
1642
1643 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1644
1645         Enable visual viewport API by default
1646         https://bugs.webkit.org/show_bug.cgi?id=193376
1647
1648         Reviewed by Simon Fraser.
1649
1650         * WebView/WebPreferences.mm:
1651         (+[WebPreferences initialize]):
1652
1653 2019-01-11  John Wilander  <wilander@apple.com>
1654
1655         Compile out Web API Statistics Collection
1656         https://bugs.webkit.org/show_bug.cgi?id=193370
1657         <rdar://problem/45388584>
1658
1659         Reviewed by Brent Fulgham.
1660
1661         * Configurations/FeatureDefines.xcconfig:
1662             Defined ENABLE_WEB_API_STATISTICS, off by default.
1663
1664 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1665
1666         Stop using NetworkStorageSession in WebProcess
1667         https://bugs.webkit.org/show_bug.cgi?id=193236
1668
1669         Reviewed by Don Olmstead.
1670
1671         * WebCoreSupport/WebFrameNetworkingContext.h:
1672         * WebCoreSupport/WebFrameNetworkingContext.mm:
1673         (WebFrameNetworkingContext::storageSession const):
1674         * WebCoreSupport/WebPlatformStrategies.h:
1675         * WebCoreSupport/WebPlatformStrategies.mm:
1676         (WebPlatformStrategies::cookiesForDOM):
1677         (WebPlatformStrategies::setCookiesFromDOM):
1678         (WebPlatformStrategies::cookiesEnabled):
1679         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1680         (WebPlatformStrategies::getRawCookies):
1681         (WebPlatformStrategies::deleteCookie):
1682         * WebView/WebView.mm:
1683         (-[WebView _cachedResponseForURL:]):
1684         (-[WebView _clearCredentials]):
1685
1686 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1687
1688         Unreviewed, rolling out r239727.
1689
1690         Broke API tests
1691
1692         Reverted changeset:
1693
1694         "Stop using NetworkStorageSession in WebProcess"
1695         https://bugs.webkit.org/show_bug.cgi?id=193236
1696         https://trac.webkit.org/changeset/239727
1697
1698 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1699
1700         Stop using NetworkStorageSession in WebProcess
1701         https://bugs.webkit.org/show_bug.cgi?id=193236
1702
1703         Reviewed by Don Olmstead.
1704
1705         * WebCoreSupport/WebFrameNetworkingContext.h:
1706         * WebCoreSupport/WebFrameNetworkingContext.mm:
1707         (WebFrameNetworkingContext::storageSession const):
1708         * WebView/WebView.mm:
1709         (-[WebView _cachedResponseForURL:]):
1710         (-[WebView _clearCredentials]):
1711
1712 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1713
1714         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1715         <https://webkit.org/b/193056>
1716
1717         Reviewed by Alex Christensen.
1718
1719         * Plugins/Hosted/NetscapePluginHostProxy.h:
1720         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1721         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1722         (WebKit::NetscapePluginInstanceProxy::enumerate):
1723         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1724         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1725         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1726         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1727         * Plugins/Hosted/ProxyInstance.mm:
1728         (WebKit::ProxyInstance::invoke):
1729         * WebCoreSupport/WebGeolocationClient.mm:
1730         * WebView/WebDataSource.mm:
1731         (-[WebDataSource _receivedData:]):
1732         * WebView/WebView.mm:
1733         (-[WebView _cachedResponseForURL:]):
1734         - Remove '*' from RetainPtr<> type.
1735
1736 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1737
1738         Progress towards fixing Mac CMake build
1739         https://bugs.webkit.org/show_bug.cgi?id=193105
1740
1741         Reviewed by Don Olmstead.
1742
1743         * WebKitPrefix.h:
1744
1745 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1746
1747         Web Inspector: Use save sheet instead of dialog where possible
1748         https://bugs.webkit.org/show_bug.cgi?id=193160
1749         <rdar://problem/37399759>
1750
1751         Reviewed by Devin Rousso.
1752
1753         * WebCoreSupport/WebInspectorClient.mm:
1754         (WebInspectorFrontendClient::save):
1755
1756 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1757
1758         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1759         https://bugs.webkit.org/show_bug.cgi?id=193129
1760
1761         Reviewed by Tim Horton.
1762
1763         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1764
1765         * WebCoreSupport/WebEditorClient.mm:
1766         (WebEditorClient::registerUndoOrRedoStep):
1767         (undoNameForEditAction): Deleted.
1768
1769 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1770
1771         Add support for using the current text selection as the find string on iOS
1772         https://bugs.webkit.org/show_bug.cgi?id=193034
1773         <rdar://problem/45138739>
1774
1775         Reviewed by Tim Horton.
1776
1777         Add a method stub for WebKitLegacy.
1778
1779         * WebCoreSupport/WebEditorClient.h:
1780
1781 2019-01-01  Jeff Miller  <jeffm@apple.com>
1782
1783         Update user-visible copyright strings to include 2019
1784         https://bugs.webkit.org/show_bug.cgi?id=192811
1785
1786         Reviewed by Mark Lam.
1787
1788         * Info.plist:
1789
1790 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1791
1792         Use Ref<> as much as possible
1793         https://bugs.webkit.org/show_bug.cgi?id=192808
1794
1795         Reviewed by Alex Christensen.
1796
1797         * DOM/DOM.mm:
1798         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1799         * Plugins/Hosted/NetscapePluginHostManager.mm:
1800         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1801         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1802         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1803         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1804         * Plugins/WebNetscapePluginView.mm:
1805         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1806         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1807         * WebCoreSupport/WebContextMenuClient.mm:
1808         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1809         * WebCoreSupport/WebFrameLoaderClient.mm:
1810         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1811         * WebView/WebFrame.mm:
1812         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1813         * WebView/WebHTMLView.mm:
1814         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1815         * WebView/WebView.mm:
1816         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1817         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1818
1819 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1820
1821         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1822         https://bugs.webkit.org/show_bug.cgi?id=192821
1823
1824         Reviewed by Chris Dumez.
1825
1826         When a window becomes occluded, the window server informs the application.
1827         This should be used to suspend any work that is not visible by the user.
1828
1829         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1830         In some cases, that lead to performance impact (see radar).
1831
1832         This patch adds an observer for the occlusion notification. I tried to stick
1833         with the same names used by WebKit2.
1834
1835         * WebView/WebView.mm:
1836         (-[WebView _isViewVisible]):
1837         (-[WebView addWindowObserversForWindow:]):
1838         (-[WebView removeWindowObservers]):
1839         (-[WebView _windowDidChangeOcclusionState:]):
1840
1841 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1842
1843         [WebAuthN] Add a runtime flag for local authenticator
1844         https://bugs.webkit.org/show_bug.cgi?id=192792
1845         <rdar://problem/46798738>
1846
1847         Reviewed by Brent Fulgham.
1848
1849         * WebView/WebPreferenceKeysPrivate.h:
1850         * WebView/WebPreferences.mm:
1851         (+[WebPreferences initialize]):
1852         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1853         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1854         * WebView/WebPreferencesPrivate.h:
1855         * WebView/WebView.mm:
1856         (-[WebView _preferencesChanged:]):
1857
1858 2018-12-20  Chris Dumez  <cdumez@apple.com>
1859
1860         Use Optional::valueOr() instead of Optional::value_or()
1861         https://bugs.webkit.org/show_bug.cgi?id=192933
1862
1863         Reviewed by Geoffrey Garen.
1864
1865         * WebCoreSupport/WebSecurityOrigin.mm:
1866         (-[WebSecurityOrigin port]):
1867
1868 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1869
1870         Unreviewed, rolling out r239417.
1871
1872         Introduced two API test failures on macOS.
1873
1874         Reverted changeset:
1875
1876         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1877         occlusion changes"
1878         https://bugs.webkit.org/show_bug.cgi?id=192821
1879         https://trac.webkit.org/changeset/239417
1880
1881 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1882
1883         WKWebView default UA doesn't freeze the build number
1884         https://bugs.webkit.org/show_bug.cgi?id=192809
1885         <rdar://problem/44687185>
1886
1887         Reviewed by Andy Estes.
1888
1889         Always reports the frozen build number.
1890
1891         * WebView/WebView.mm:
1892         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1893         actual build number through this method call.
1894         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1895
1896 2018-12-19  Chris Dumez  <cdumez@apple.com>
1897
1898         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1899         https://bugs.webkit.org/show_bug.cgi?id=192728
1900         <rdar://problem/46746779>
1901
1902         Reviewed by Geoff Garen.
1903
1904         * DOM/*:
1905         * Plugins/*:
1906         * WebCoreSupport/*:
1907         * WebView/*:
1908
1909 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1910
1911         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1912         https://bugs.webkit.org/show_bug.cgi?id=192821
1913
1914         Reviewed by Chris Dumez.
1915
1916         When a window becomes occluded, the window server informs the application.
1917         This should be used to suspend any work that is not visible by the user.
1918
1919         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1920         In some cases, that lead to performance impact (see radar).
1921
1922         This patch adds an observer for the occlusion notification. I tried to stick
1923         with the same names used by WebKit2.
1924
1925         * WebView/WebView.mm:
1926         (-[WebView _isViewVisible]):
1927         (-[WebView addWindowObserversForWindow:]):
1928         (-[WebView removeWindowObservers]):
1929         (-[WebView _windowDidChangeOcclusionState:]):
1930
1931 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1932
1933         Allow clients to set the navigator platform
1934         https://bugs.webkit.org/show_bug.cgi?id=192735
1935
1936         Reviewed by Tim Horton.
1937
1938         Add stubs to fill out the added functionality in FrameLoaderClient.
1939
1940         * WebCoreSupport/WebFrameLoaderClient.h:
1941         * WebCoreSupport/WebFrameLoaderClient.mm:
1942         (WebFrameLoaderClient::navigatorPlatform):
1943
1944 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1945
1946         offsetLeft and offsetParent should adjust across shadow boundaries
1947         https://bugs.webkit.org/show_bug.cgi?id=157437
1948         <rdar://problem/26154021>
1949
1950         Reviewed by Simon Fraser.
1951
1952         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1953
1954         * DOM/DOMElement.mm:
1955         (-[DOMElement offsetLeft]):
1956         (-[DOMElement offsetTop]):
1957         (-[DOMElement offsetParent]):
1958
1959 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1960
1961         Unreviewed build fix.
1962
1963         * WebView/WebFrame.mm:
1964         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1965
1966 2018-12-15  Darin Adler  <darin@apple.com>
1967
1968         Use warning-ignoring macros more consistently and simply
1969         https://bugs.webkit.org/show_bug.cgi?id=192743
1970
1971         Reviewed by Mark Lam.
1972
1973         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1974         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1975         compilers in Objective-C++ code.
1976
1977         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1978         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1979         accomodate non-clang compilers here. Also use #pragma once, add a missing
1980         "explicit" and fix conditionals.
1981
1982 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1983
1984         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1985         https://bugs.webkit.org/show_bug.cgi?id=192653
1986
1987         Reviewed by Wenson Hsieh.
1988
1989         * WebView/WebHTMLView.mm:
1990         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1991
1992 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1993
1994         Implement feature flag for CSS Typed OM
1995         https://bugs.webkit.org/show_bug.cgi?id=192610
1996
1997         Reviewed by Ryosuke Niwa.
1998
1999         * Configurations/FeatureDefines.xcconfig:
2000
2001 2018-12-11  Tim Horton  <timothy_horton@apple.com>
2002
2003         WebCore shouldn't have a Objective-C class named NSCursor
2004         https://bugs.webkit.org/show_bug.cgi?id=192602
2005         <rdar://problem/46615532>
2006
2007         Reviewed by Wenson Hsieh.
2008
2009         * WebView/WebFrameView.mm:
2010         (-[WebFrameView keyDown:keyDown:]):
2011         * WebView/WebHTMLView.mm:
2012         (-[WebHTMLView keyDown:]):
2013         (-[WebHTMLView performKeyEquivalent:]):
2014         Only use NSCursor on macOS.
2015
2016 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
2017
2018         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
2019         https://bugs.webkit.org/show_bug.cgi?id=192573
2020
2021         Reviewed by Simon Fraser.
2022
2023         * Configurations/FeatureDefines.xcconfig:
2024
2025 2018-12-10  Antti Koivisto  <antti@apple.com>
2026
2027         Rename "forced style recalc" to "full style rebuild"
2028         https://bugs.webkit.org/show_bug.cgi?id=192572
2029
2030         Reviewed by Zalan Bujtas.
2031
2032         * WebView/WebHTMLView.mm:
2033         (-[WebHTMLView setNeedsToApplyStyles:]):
2034
2035 2018-12-10  Darin Adler  <darin@apple.com>
2036
2037         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
2038         https://bugs.webkit.org/show_bug.cgi?id=192533
2039         rdar://problem/45732710
2040
2041         Reviewed by Anders Carlsson.
2042
2043         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2044         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
2045
2046 2018-12-10  Darin Adler  <darin@apple.com>
2047
2048         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
2049         https://bugs.webkit.org/show_bug.cgi?id=192532
2050         rdar://problem/45731047
2051
2052         Reviewed by Chris Dumez.
2053
2054         * Plugins/Hosted/NetscapePluginHostManager.mm:
2055         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
2056         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2057         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
2058
2059 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         Turn WritingDirection into an enum class
2062         https://bugs.webkit.org/show_bug.cgi?id=192401
2063         Work towards <rdar://problem/42075638>
2064
2065         Reviewed by Dan Bernstein.
2066
2067         Change WritingDirection from an enum to an enum class. No change in behavior.
2068
2069         * WebView/WebHTMLView.mm:
2070         (-[WebHTMLView toggleBaseWritingDirection:]):
2071         (-[WebHTMLView changeBaseWritingDirection:]):
2072         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
2073
2074 2018-12-03  Alex Christensen  <achristensen@webkit.org>
2075
2076         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
2077         https://bugs.webkit.org/show_bug.cgi?id=192272
2078
2079         Reviewed by Brady Eidson.
2080
2081         * WebCoreSupport/WebFrameLoaderClient.h:
2082         * WebCoreSupport/WebFrameLoaderClient.mm:
2083         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2084
2085 2018-12-03  Jer Noble  <jer.noble@apple.com>
2086
2087         Get rid of old, dead Mac video fullscreen code.
2088         https://bugs.webkit.org/show_bug.cgi?id=192315
2089
2090         Reviewed by Eric Carlson.
2091
2092         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
2093         is no longer supported in the Mac port.
2094
2095         * WebView/WebVideoFullscreenController.h: Removed.
2096         * WebView/WebVideoFullscreenController.mm: Removed.
2097         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
2098         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
2099         * WebView/WebView.mm:
2100         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2101         (-[WebView _exitVideoFullscreen]):
2102
2103 2018-12-03  Daniel Bates  <dabates@apple.com>
2104
2105         [iOS] Do not handle key events that are key commands
2106         https://bugs.webkit.org/show_bug.cgi?id=191608
2107         <rdar://problem/46046013>
2108
2109         Reviewed by Ryosuke Niwa.
2110
2111         A key down event may be associated with a key command. If it is then we want to execute the
2112         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
2113         event as a key command to find out.
2114
2115         * WebView/WebHTMLView.mm:
2116         (-[WebHTMLView _handleEditingKeyEvent:]):
2117
2118 2018-12-02  Zalan Bujtas  <zalan@apple.com>
2119
2120         Add a runtime feature flag for LayoutFormattingContext.
2121         https://bugs.webkit.org/show_bug.cgi?id=192280
2122
2123         Reviewed by Simon Fraser.
2124
2125         * Configurations/FeatureDefines.xcconfig:
2126
2127 2018-11-30  Alex Christensen  <achristensen@webkit.org>
2128
2129         Move URL from WebCore to WTF
2130         https://bugs.webkit.org/show_bug.cgi?id=190234
2131
2132         Reviewed by Keith Miller.
2133
2134         * DOM/DOMAttr.mm:
2135         * DOM/DOMBlob.mm:
2136         * DOM/DOMCSSCharsetRule.mm:
2137         * DOM/DOMCSSImportRule.mm:
2138         * DOM/DOMCSSMediaRule.mm:
2139         * DOM/DOMCSSPageRule.mm:
2140         * DOM/DOMCSSPrimitiveValue.mm:
2141         * DOM/DOMCSSRule.mm:
2142         * DOM/DOMCSSStyleDeclaration.mm:
2143         * DOM/DOMCSSStyleRule.mm:
2144         * DOM/DOMCSSStyleSheet.mm:
2145         * DOM/DOMCSSValue.mm:
2146         * DOM/DOMCharacterData.mm:
2147         * DOM/DOMCounter.mm:
2148         * DOM/DOMDocument.mm:
2149         * DOM/DOMDocumentFragment.mm:
2150         * DOM/DOMDocumentType.mm:
2151         * DOM/DOMEvent.mm:
2152         * DOM/DOMFile.mm:
2153         * DOM/DOMHTMLAnchorElement.mm:
2154         * DOM/DOMHTMLAppletElement.mm:
2155         * DOM/DOMHTMLAreaElement.mm:
2156         * DOM/DOMHTMLBRElement.mm:
2157         * DOM/DOMHTMLBaseElement.mm:
2158         * DOM/DOMHTMLBaseFontElement.mm:
2159         * DOM/DOMHTMLBodyElement.mm:
2160         * DOM/DOMHTMLButtonElement.mm:
2161         * DOM/DOMHTMLCanvasElement.mm:
2162         * DOM/DOMHTMLCollection.mm:
2163         * DOM/DOMHTMLDivElement.mm:
2164         * DOM/DOMHTMLDocument.mm:
2165         * DOM/DOMHTMLElement.mm:
2166         * DOM/DOMHTMLEmbedElement.mm:
2167         * DOM/DOMHTMLFieldSetElement.mm:
2168         * DOM/DOMHTMLFontElement.mm:
2169         * DOM/DOMHTMLFormElement.mm:
2170         * DOM/DOMHTMLFrameElement.mm:
2171         * DOM/DOMHTMLFrameSetElement.mm:
2172         * DOM/DOMHTMLHRElement.mm:
2173         * DOM/DOMHTMLHeadElement.mm:
2174         * DOM/DOMHTMLHeadingElement.mm:
2175         * DOM/DOMHTMLHtmlElement.mm:
2176         * DOM/DOMHTMLIFrameElement.mm:
2177         * DOM/DOMHTMLImageElement.mm:
2178         * DOM/DOMHTMLInputElement.mm:
2179         * DOM/DOMHTMLLIElement.mm:
2180         * DOM/DOMHTMLLabelElement.mm:
2181         * DOM/DOMHTMLLegendElement.mm:
2182         * DOM/DOMHTMLLinkElement.mm:
2183         * DOM/DOMHTMLMapElement.mm:
2184         * DOM/DOMHTMLMarqueeElement.mm:
2185         * DOM/DOMHTMLMediaElement.mm:
2186         * DOM/DOMHTMLMetaElement.mm:
2187         * DOM/DOMHTMLModElement.mm:
2188         * DOM/DOMHTMLOListElement.mm:
2189         * DOM/DOMHTMLObjectElement.mm:
2190         * DOM/DOMHTMLOptGroupElement.mm:
2191         * DOM/DOMHTMLOptionElement.mm:
2192         * DOM/DOMHTMLOptionsCollection.mm:
2193         * DOM/DOMHTMLParagraphElement.mm:
2194         * DOM/DOMHTMLParamElement.mm:
2195         * DOM/DOMHTMLQuoteElement.mm:
2196         * DOM/DOMHTMLScriptElement.mm:
2197         * DOM/DOMHTMLSelectElement.mm:
2198         * DOM/DOMHTMLStyleElement.mm:
2199         * DOM/DOMHTMLTableCaptionElement.mm:
2200         * DOM/DOMHTMLTableCellElement.mm:
2201         * DOM/DOMHTMLTableColElement.mm:
2202         * DOM/DOMHTMLTableElement.mm:
2203         * DOM/DOMHTMLTableRowElement.mm:
2204         * DOM/DOMHTMLTableSectionElement.mm:
2205         * DOM/DOMHTMLTitleElement.mm:
2206         * DOM/DOMHTMLUListElement.mm:
2207         * DOM/DOMHTMLVideoElement.mm:
2208         * DOM/DOMKeyboardEvent.mm:
2209         * DOM/DOMMediaList.mm:
2210         * DOM/DOMMouseEvent.mm:
2211         * DOM/DOMMutationEvent.mm:
2212         * DOM/DOMNamedNodeMap.mm:
2213         * DOM/DOMProcessingInstruction.mm:
2214         * DOM/DOMRange.mm:
2215         * DOM/DOMStyleSheet.mm:
2216         * DOM/DOMText.mm:
2217         * DOM/DOMTextEvent.mm:
2218         * DOM/DOMTokenList.mm:
2219         * DOM/DOMUIEvent.mm:
2220         * DOM/DOMXPathResult.mm:
2221         * History/WebHistoryItem.mm:
2222         * Misc/WebNSURLExtras.mm:
2223         (-[NSURL _web_userVisibleString]):
2224         (-[NSURL _web_URLByRemovingUserInfo]):
2225         (-[NSURL _web_dataForURLComponentType:]):
2226         (-[NSURL _web_schemeData]):
2227         (-[NSURL _web_hostData]):
2228         * Misc/WebUserContentURLPattern.mm:
2229         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2230         * Plugins/WebNetscapePluginStream.h:
2231         (WebNetscapePluginStream::setRequestURL):
2232         * WebCoreSupport/WebChromeClient.h:
2233         * WebCoreSupport/WebChromeClient.mm:
2234         (WebChromeClient::signedPublicKeyAndChallengeString const):
2235         * WebCoreSupport/WebContextMenuClient.h:
2236         * WebCoreSupport/WebContextMenuClient.mm:
2237         * WebCoreSupport/WebDragClient.h:
2238         * WebCoreSupport/WebFrameLoaderClient.h:
2239         * WebCoreSupport/WebFrameLoaderClient.mm:
2240         (WebFrameLoaderClient::updateGlobalHistory):
2241         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2242         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2243         (WebPaymentCoordinatorClient::showPaymentUI):
2244         * WebCoreSupport/WebPlatformStrategies.h:
2245         * WebCoreSupport/WebPlatformStrategies.mm:
2246         (WebPlatformStrategies::readURLFromPasteboard):
2247         * WebCoreSupport/WebPluginInfoProvider.h:
2248         * WebCoreSupport/WebPluginInfoProvider.mm:
2249         (WebPluginInfoProvider::webVisiblePluginInfo):
2250         * WebCoreSupport/WebSecurityOrigin.mm:
2251         * WebCoreSupport/WebVisitedLinkStore.h:
2252         * WebView/WebDataSource.mm:
2253         * WebView/WebFrame.mm:
2254         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2255         * WebView/WebImmediateActionController.mm:
2256         (-[WebImmediateActionController _defaultAnimationController]):
2257         * WebView/WebPDFView.mm:
2258         * WebView/WebScriptDebugger.mm:
2259         * WebView/WebViewInternal.h:
2260
2261 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
2262
2263         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
2264         https://bugs.webkit.org/show_bug.cgi?id=192197
2265
2266         Reviewed by Jiewen Tan.
2267
2268         * Configurations/FeatureDefines.xcconfig:
2269         * WebCoreSupport/WebChromeClient.h:
2270         * WebCoreSupport/WebChromeClient.mm:
2271
2272 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2273
2274         Remove dead code from an earlier attempt at implementing safe browsing
2275         https://bugs.webkit.org/show_bug.cgi?id=192067
2276
2277         Reviewed by Chris Dumez.
2278
2279         * WebCoreSupport/WebFrameLoaderClient.h:
2280         * WebCoreSupport/WebFrameLoaderClient.mm:
2281         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2282
2283 2018-11-27  Mark Lam  <mark.lam@apple.com>
2284
2285         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2286         https://bugs.webkit.org/show_bug.cgi?id=192055
2287         <rdar://problem/46288783>
2288
2289         Reviewed by Saam Barati.
2290
2291         * Configurations/FeatureDefines.xcconfig:
2292
2293 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2294
2295         Make it possible to insert editable images with a gesture
2296         https://bugs.webkit.org/show_bug.cgi?id=191937
2297
2298         Reviewed by Wenson Hsieh.
2299
2300         * WebCoreSupport/WebEditorClient.mm:
2301         (undoNameForEditAction):
2302         Add a undo name.
2303
2304 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2305
2306         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2307         https://bugs.webkit.org/show_bug.cgi?id=191945
2308
2309         Reviewed by Anders Carlsson.
2310
2311         * WebCoreSupport/WebEditorClient.mm:
2312         (undoNameForEditAction):
2313
2314 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2315
2316         Enable drag and drop support for iOSMac
2317         https://bugs.webkit.org/show_bug.cgi?id=191818
2318         <rdar://problem/43907454>
2319
2320         Reviewed by Dean Jackson.
2321
2322         * Configurations/FeatureDefines.xcconfig:
2323
2324 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2325
2326         Address post-review feedback after r238438
2327         https://bugs.webkit.org/show_bug.cgi?id=191913
2328
2329         Reviewed by Ryosuke Niwa.
2330
2331         * WebView/WebFrame.mm:
2332         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2333         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2334         * WebView/WebView.mm:
2335         (-[WebView setSelectedDOMRange:affinity:]):
2336
2337 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2338
2339         Web Inspector: "Reload Web Inspector" button no longer partially works
2340         https://bugs.webkit.org/show_bug.cgi?id=191773
2341         <rdar://problem/46139932>
2342
2343         Reviewed by Devin Rousso.
2344
2345         * WebCoreSupport/WebInspectorClient.h:
2346         * WebCoreSupport/WebInspectorClient.mm:
2347         (WebInspectorFrontendClient::reopen):
2348
2349 2018-11-17  Devin Rousso  <drousso@apple.com>
2350
2351         Web Inspector: Network: add button to show system certificate dialog
2352         https://bugs.webkit.org/show_bug.cgi?id=191458
2353         <rdar://problem/45977019>
2354
2355         Reviewed by Joseph Pecoraro.
2356
2357         * WebCoreSupport/WebInspectorClient.h:
2358         * WebCoreSupport/WebInspectorClient.mm:
2359         (WebInspectorFrontendClient::showCertificate): Added.
2360
2361         * Configurations/WebKitLegacy.xcconfig:
2362
2363 2018-11-15  Truitt Savell  <tsavell@apple.com>
2364
2365         Unreviewed, rolling out r238244.
2366
2367         Caused High Sierra test runs to fail early with 50 crashes and
2368         casued 25 API failures.
2369
2370         Reverted changeset:
2371
2372         "[css-logical] Implement flow-relative margin, padding and
2373         border shorthands"
2374         https://bugs.webkit.org/show_bug.cgi?id=188697
2375         https://trac.webkit.org/changeset/238244
2376
2377 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2378
2379         [css-logical] Implement flow-relative margin, padding and border shorthands
2380         https://bugs.webkit.org/show_bug.cgi?id=188697
2381
2382         Reviewed by Simon Fraser and Antti Koivisto.
2383
2384         Add CSSLogicalEnabled runtime flag.
2385
2386         * WebView/WebPreferenceKeysPrivate.h:
2387         * WebView/WebPreferences.mm:
2388         (+[WebPreferences initialize]):
2389         (-[WebPreferences cssLogicalEnabled]):
2390         (-[WebPreferences setCSSLogicalEnabled:]):
2391         * WebView/WebPreferencesPrivate.h:
2392         * WebView/WebView.mm:
2393         (-[WebView _preferencesChanged:]):
2394
2395 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2396
2397         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2398         https://bugs.webkit.org/show_bug.cgi?id=191612
2399
2400         Reviewed by Matt Baker.
2401
2402         * WebCoreSupport/WebInspectorClient.mm:
2403         (-[WebInspectorWindowController destroyInspectorView]):
2404
2405 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2406
2407         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2408         https://bugs.webkit.org/show_bug.cgi?id=191494
2409         <rdar://problem/45469854>
2410
2411         Reviewed by Devin Rousso.
2412
2413         * WebCoreSupport/WebInspectorClient.h:
2414         WebKitLegacy will still have remote inspection of the Page directly.
2415
2416 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2417
2418         Make compositing updates incremental
2419         https://bugs.webkit.org/show_bug.cgi?id=90342
2420
2421         Reviewed by Antti Koivisto.
2422
2423         Fix spelling error.
2424
2425         * WebView/WebView.mm:
2426         (-[WebView _setMediaLayer:forPluginView:]):
2427
2428 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2429
2430         Implement a new edit command to change the enclosing list type
2431         https://bugs.webkit.org/show_bug.cgi?id=191487
2432         <rdar://problem/45955922>
2433
2434         Reviewed by Ryosuke Niwa.
2435
2436         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2437
2438         * WebCoreSupport/WebEditorClient.mm:
2439         (undoNameForEditAction):
2440
2441 2018-11-11  Daniel Bates  <dabates@apple.com>
2442
2443         [iOS] Draw caps lock indicator in password fields
2444         https://bugs.webkit.org/show_bug.cgi?id=190565
2445         <rdar://problem/45262343>
2446
2447         Reviewed by Dean Jackson.
2448
2449         Update the caps lock state when a hardware keyboard is attached or detached.
2450
2451         * WebView/WebHTMLView.mm:
2452         (hardwareKeyboardAvailabilityChangedCallback): Added.
2453         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2454         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2455
2456 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2457
2458         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2459         https://bugs.webkit.org/show_bug.cgi?id=191492
2460
2461         Reviewed by Alex Christensen.
2462
2463         * Carbon/HIWebView.mm:
2464         * Misc/WebNSFileManagerExtras.mm:
2465         * Misc/WebNSURLExtras.mm:
2466         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2467         * Plugins/WebBasePluginPackage.mm:
2468         * Plugins/WebPluginContainerCheck.mm:
2469         * WebCoreSupport/WebCachedFramePlatformData.h:
2470         * WebCoreSupport/WebDeviceOrientationClient.mm:
2471         * WebView/WebDelegateImplementationCaching.mm:
2472         * WebView/WebHTMLView.mm:
2473         * WebView/WebPDFRepresentation.mm:
2474         * WebView/WebPolicyDelegate.mm:
2475         * WebView/WebView.mm:
2476
2477 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2478
2479         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2480         https://bugs.webkit.org/show_bug.cgi?id=191492
2481
2482         Reviewed by Alex Christensen.
2483
2484         * Carbon/HIWebView.mm:
2485         (UpdateCommandStatus):
2486         * Misc/WebNSFileManagerExtras.mm:
2487         * Misc/WebNSURLExtras.mm:
2488         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2489         * Plugins/WebBasePluginPackage.mm:
2490         * Plugins/WebPluginContainerCheck.mm:
2491         (-[WebPluginContainerCheck _continueWithPolicy:]):
2492         * WebCoreSupport/WebCachedFramePlatformData.h:
2493         (WebCachedFramePlatformData::clear):
2494         * WebCoreSupport/WebDeviceOrientationClient.mm:
2495         (WebDeviceOrientationClient::getProvider const):
2496         * WebView/WebDelegateImplementationCaching.mm:
2497         (CallDelegate):
2498         (CallDelegateReturningBoolean):
2499         (CallResourceLoadDelegateReturningBoolean):
2500         (CallFormDelegate):
2501         (CallFormDelegateReturningBoolean):
2502         * WebView/WebHTMLView.mm:
2503         * WebView/WebPDFRepresentation.mm:
2504         * WebView/WebPolicyDelegate.mm:
2505         (-[WebPolicyDecisionListener _usePolicy:]):
2506         * WebView/WebView.mm:
2507
2508 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2509
2510         Unreviewed, rolling out r238047.
2511
2512         Introduced layout test failures on iOS simulator.
2513
2514         Reverted changeset:
2515
2516         "[iOS] Draw caps lock indicator in password fields"
2517         https://bugs.webkit.org/show_bug.cgi?id=190565
2518         https://trac.webkit.org/changeset/238047
2519
2520 2018-11-09  Antti Koivisto  <antti@apple.com>
2521
2522         Use OptionSet for layout milestones
2523         https://bugs.webkit.org/show_bug.cgi?id=191470
2524
2525         Reviewed by Dean Jackson.
2526
2527         * WebCoreSupport/WebFrameLoaderClient.h:
2528         * WebCoreSupport/WebFrameLoaderClient.mm:
2529         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2530         * WebView/WebView.mm:
2531         (coreLayoutMilestones):
2532         (kitLayoutMilestones):
2533         (-[WebView _cacheFrameLoadDelegateImplementations]):
2534         * WebView/WebViewInternal.h:
2535
2536 2018-11-09  Daniel Bates  <dabates@apple.com>
2537
2538         [iOS] Draw caps lock indicator in password fields
2539         https://bugs.webkit.org/show_bug.cgi?id=190565
2540         <rdar://problem/45262343>
2541
2542         Reviewed by Dean Jackson.
2543
2544         Update the caps lock state when a hardware keyboard is attached or detached.
2545
2546         * WebView/WebHTMLView.mm:
2547         (hardwareKeyboardAvailabilityChangedCallback): Added.
2548         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2549         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2550
2551 2018-11-09  Daniel Bates  <dabates@apple.com>
2552
2553         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2554         action when forward delete is pressed outside a text field
2555         https://bugs.webkit.org/show_bug.cgi?id=190566
2556         <rdar://problem/45262367>
2557
2558         Reviewed by Wenson Hsieh.
2559
2560         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2561         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2562         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2563
2564         * WebView/WebHTMLView.mm:
2565         (-[WebHTMLView _handleEditingKeyEvent:]):
2566
2567 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2568
2569         Adopt Reveal Framework to replace Lookup
2570         https://bugs.webkit.org/show_bug.cgi?id=191097
2571         <rdar://problem/45924508>
2572
2573         Reviewed by Tim Horton.
2574
2575         Pass in what it needed to clear the textIndicators. This is better than
2576         the current notification structure.
2577
2578         * WebView/WebView.mm:
2579         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2580         (-[WebView _prepareForDictionaryLookup]):
2581
2582 2018-11-06  Justin Fan  <justin_fan@apple.com>
2583
2584         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2585         https://bugs.webkit.org/show_bug.cgi?id=191291
2586
2587         Reviewed by Myles Maxfield.
2588
2589         Properly disable WEBGPU on all non-Metal platforms for now.
2590
2591         * Configurations/FeatureDefines.xcconfig:
2592
2593 2018-11-02  Daniel Bates  <dabates@apple.com>
2594
2595         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2596         https://bugs.webkit.org/show_bug.cgi?id=190487
2597
2598         Reviewed by Tim Horton.
2599
2600         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2601         allow the default handling.
2602
2603         * WebView/WebHTMLView.mm:
2604         (-[WebHTMLView _handleEditingKeyEvent:]):
2605
2606 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2607
2608         Add a storage limit for IndexedDB
2609         https://bugs.webkit.org/show_bug.cgi?id=190598
2610         <rdar://problem/44654715>
2611
2612         Reviewed by Chris Dumez.
2613
2614         * Storage/WebDatabaseManager.mm:
2615         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2616         * Storage/WebDatabaseManagerPrivate.h:
2617
2618 2018-10-31  Antti Koivisto  <antti@apple.com>
2619
2620         Remove LayerFlushScheduler
2621         https://bugs.webkit.org/show_bug.cgi?id=191103
2622
2623         Reviewed by Anders Carlsson.
2624
2625         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2626         all the virtual cruft.
2627
2628         * WebView/WebViewData.h:
2629         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2630         (): Deleted.
2631         * WebView/WebViewData.mm:
2632         (currentRunLoop):
2633         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2634         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2635         (WebViewLayerFlushScheduler::schedule):
2636         (WebViewLayerFlushScheduler::invalidate):
2637         (WebViewLayerFlushScheduler::layerFlushCallback):
2638
2639 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2640
2641         Enable InstallAPI for iOS unconditionally
2642         https://bugs.webkit.org/show_bug.cgi?id=191043
2643         rdar://problem/32728423
2644
2645         Reviewed by Dan Bernstein.
2646
2647         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2648         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2649         shouldn't be processed by InstallAPI.
2650         * MigrateHeaders.make: Removed an obsolete workaround.
2651         * Misc/NSURLDownloadSPI.h: Added.
2652         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2653
2654 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2655
2656         Clean up some obsolete MAX_ALLOWED macros
2657         https://bugs.webkit.org/show_bug.cgi?id=190916
2658
2659         Reviewed by Tim Horton.
2660
2661         * WebView/WebHTMLView.mm:
2662         (-[WebHTMLView pressureChangeWithEvent:]):
2663         * WebView/WebPDFView.h:
2664
2665 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2666
2667         Unreviewed, rolling out r237600 and r237604.
2668         https://bugs.webkit.org/show_bug.cgi?id=191086
2669
2670         Breaks internal iOS builds (Requested by ryanhadd_ on
2671         #webkit).
2672
2673         Reverted changesets:
2674
2675         "Enable InstallAPI for iOS unconditionally"
2676         https://bugs.webkit.org/show_bug.cgi?id=191043
2677         https://trac.webkit.org/changeset/237600
2678
2679         "Build fix attempt after enabling InstallAPI for iOS."
2680         https://bugs.webkit.org/show_bug.cgi?id=191043
2681         https://trac.webkit.org/changeset/237604
2682
2683 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2684
2685         Enable InstallAPI for iOS unconditionally
2686         https://bugs.webkit.org/show_bug.cgi?id=191043
2687         rdar://problem/32728423
2688
2689         Reviewed by Dan Bernstein.
2690
2691         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2692         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2693         shouldn't be processed by InstallAPI.
2694         * MigrateHeaders.make: Removed an obsolete workaround.
2695         * Misc/NSURLDownloadSPI.h: Added.
2696         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2697
2698 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2699
2700         Modernize WebKit nibs and lprojs for localization's sake
2701         https://bugs.webkit.org/show_bug.cgi?id=190911
2702         <rdar://problem/45349466>
2703
2704         Reviewed by Dan Bernstein.
2705
2706         * Misc/WebNSControlExtras.m:
2707         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2708         NSWindow and its contents are both in the same scale space these days; avoid
2709         double-applying the scale factor, or you can't see the prompt.
2710
2711         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2712         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2713         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2714         NIB->XIB
2715
2716 2018-10-25  Antoine Quint  <graouts@apple.com>
2717
2718         [Web Animations] Turn Web Animations CSS Integration off by default
2719         https://bugs.webkit.org/show_bug.cgi?id=190901
2720
2721         Reviewed by Dean Jackson.
2722
2723         * WebView/WebPreferences.mm:
2724         (+[WebPreferences initialize]):
2725
2726 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2727
2728         Clean up some obsolete macOS version guards
2729         https://bugs.webkit.org/show_bug.cgi?id=190887
2730
2731         Reviewed by Dan Bernstein.
2732
2733         * Misc/WebNSPasteboardExtras.mm:
2734         (+[NSPasteboard _web_dragTypesForURL]):
2735         * WebCoreSupport/PopupMenuMac.mm:
2736         (PopupMenuMac::show):
2737         * WebCoreSupport/WebEditorClient.h:
2738         * WebCoreSupport/WebEditorClient.mm:
2739         (WebEditorClient::respondToChangedSelection):
2740         * WebView/WebPDFView.mm:
2741         (-[WebPDFView _clipViewForPDFDocumentView]):
2742
2743 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2744
2745         Turn on Conic Gradients
2746         https://bugs.webkit.org/show_bug.cgi?id=190810
2747
2748         Reviewed by Tim Horton.
2749
2750         * Configurations/FeatureDefines.xcconfig:
2751
2752 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2753
2754         Cleanup: MIMETypeRegistry functions
2755         https://bugs.webkit.org/show_bug.cgi?id=190838
2756
2757         Reviewed by Simon Fraser.
2758
2759         * Misc/WebNSPasteboardExtras.mm:
2760         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2761         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2762         because they were identical.
2763
2764         * WebView/WebHTMLRepresentation.mm:
2765         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2766         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2767         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2768         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2769         * WebView/WebView.mm:
2770         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2771         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2772         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2773
2774 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2775
2776         Fix false positive leaks when using custom -init methods that don't start with -init
2777         <https://webkit.org/b/190818>
2778         <rdar://problem/45476042>
2779
2780         Reviewed by Dan Bernstein.
2781
2782         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2783         it is accessible by both categories.
2784         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2785         NSError (WebKitInternal) category.  Add attribute to make this
2786         behave like an -init method.
2787         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2788         NSError (WebKitInternal) category.  Modernize method.  Replace
2789         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2790
2791 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2792
2793         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2794         https://bugs.webkit.org/show_bug.cgi?id=190729
2795
2796         Reviewed by Tim Horton.
2797
2798         * DOM/DOM.mm:
2799         (-[DOMNode boundingBox]):
2800         * DOM/DOMElement.mm:
2801         * DOM/DOMHTML.mm:
2802         * DOM/DOMInternal.mm:
2803         * DOM/DOMUIKitExtensions.mm:
2804         * DOM/WebDOMOperations.mm:
2805         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2806         * DefaultDelegates/WebDefaultEditingDelegate.m:
2807         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2808         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2809         * DefaultDelegates/WebDefaultUIDelegate.h:
2810         * DefaultDelegates/WebDefaultUIDelegate.mm:
2811         (-[WebDefaultUIDelegate webViewClose:]):
2812         (-[WebDefaultUIDelegate webViewFocus:]):
2813         (-[WebDefaultUIDelegate webViewUnfocus:]):
2814         (-[WebDefaultUIDelegate webViewIsResizable:]):
2815         (-[WebDefaultUIDelegate webView:setResizable:]):
2816         (-[WebDefaultUIDelegate webView:setFrame:]):
2817         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2818         * History/BackForwardList.h:
2819         * History/BackForwardList.mm:
2820         * History/WebBackForwardList.mm:
2821         (+[WebBackForwardList initialize]):
2822         (bumperCarBackForwardHackNeeded):
2823         * History/WebHistory.mm:
2824         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2825         (-[WebHistory _sendNotification:entries:]):
2826         (-[WebHistory loadFromURL:error:]):
2827         (-[WebHistory saveToURL:error:]):
2828         * History/WebHistoryItem.mm:
2829         (WKNotifyHistoryItemChanged):
2830         (+[WebHistoryItem initialize]):
2831         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2832         * History/WebURLsWithTitles.m:
2833         * Misc/WebCache.mm:
2834         (+[WebCache initialize]):
2835         * Misc/WebDownload.mm:
2836         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2837         * Misc/WebElementDictionary.mm:
2838         (+[WebElementDictionary initialize]):
2839         (+[WebElementDictionary initializeLookupTable]):
2840         * Misc/WebIconDatabase.mm:
2841         * Misc/WebKitNSStringExtras.mm:
2842         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2843         * Misc/WebKitVersionChecks.h:
2844         * Misc/WebKitVersionChecks.mm:
2845         (WebKitLinkedOnOrAfter):
2846         (WebKitLinkTimeVersion):
2847         * Misc/WebLocalizableStrings.mm:
2848         * Misc/WebNSControlExtras.h:
2849         * Misc/WebNSControlExtras.m:
2850         * Misc/WebNSEventExtras.m:
2851         * Misc/WebNSFileManagerExtras.mm:
2852         * Misc/WebNSImageExtras.h:
2853         * Misc/WebNSImageExtras.m:
2854         * Misc/WebNSPasteboardExtras.mm:
2855         * Misc/WebNSPrintOperationExtras.h:
2856         * Misc/WebNSPrintOperationExtras.m:
2857         * Misc/WebNSViewExtras.m:
2858         * Misc/WebNSWindowExtras.m:
2859         * Panels/WebAuthenticationPanel.h:
2860         * Panels/WebAuthenticationPanel.m:
2861         * Panels/WebPanelAuthenticationHandler.m:
2862         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2863         (+[WebHostedNetscapePluginView initialize]):
2864         * Plugins/WebBasePluginPackage.h:
2865         * Plugins/WebBasePluginPackage.mm:
2866         * Plugins/WebJavaPlugIn.h:
2867         * Plugins/WebPluginContainerCheck.mm:
2868         * Plugins/WebPluginController.h:
2869         * Plugins/WebPluginController.mm:
2870         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2871         (-[WebPluginController addPlugin:]):
2872         (-[WebPluginController destroyPlugin:]):
2873         (-[WebPluginController destroyAllPlugins]):
2874         * Plugins/WebPluginDatabase.mm:
2875         (+[WebPluginDatabase _defaultPlugInPaths]):
2876         * Plugins/WebPluginPackage.mm:
2877         (-[WebPluginPackage initWithPath:]):
2878         * Storage/WebDatabaseManager.mm:
2879         (-[WebDatabaseManager deleteAllDatabases]):
2880         * Storage/WebDatabaseManagerClient.h:
2881         * Storage/WebDatabaseManagerClient.mm:
2882         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2883         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2884         * Storage/WebStorageManager.mm:
2885         (-[WebStorageManager deleteAllOrigins]):
2886         (WebKitInitializeStorageIfNecessary):
2887         * WebCoreSupport/WebAlternativeTextClient.h:
2888         * WebCoreSupport/WebApplicationCache.mm:
2889         (applicationCacheBundleIdentifier):
2890         * WebCoreSupport/WebChromeClient.h:
2891         * WebCoreSupport/WebChromeClient.mm:
2892         (WebChromeClient::setWindowRect):
2893         (WebChromeClient::windowRect):
2894         (WebChromeClient::takeFocus):
2895         (WebChromeClient::addMessageToConsole):
2896         (WebChromeClient::enableSuddenTermination):
2897         (WebChromeClient::disableSuddenTermination):
2898         (WebChromeClient::createPopupMenu const):
2899         (WebChromeClient::createSearchPopupMenu const):
2900         (WebChromeClient::shouldPaintEntireContents const):
2901         (WebChromeClient::supportsVideoFullscreen):
2902         (WebChromeClient::supportsFullScreenForElement):
2903         (WebChromeClient::enterFullScreenForElement):
2904         (WebChromeClient::exitFullScreenForElement):
2905         * WebCoreSupport/WebContextMenuClient.mm:
2906         * WebCoreSupport/WebDragClient.mm:
2907         * WebCoreSupport/WebEditorClient.h:
2908         * WebCoreSupport/WebEditorClient.mm:
2909         (+[WebUndoStep initialize]):
2910         (updateFontPanel):
2911         (WebEditorClient::didBeginEditing):
2912         (WebEditorClient::respondToChangedContents):
2913         (WebEditorClient::respondToChangedSelection):
2914         (WebEditorClient::canceledComposition):
2915         (WebEditorClient::didEndEditing):
2916         (WebEditorClient::didWriteSelectionToPasteboard):
2917         (attributesForAttributedStringConversion):
2918         (WebEditorClient::setInsertionPasteboard):
2919         (WebEditorClient::registerUndoOrRedoStep):
2920         (WebEditorClient::handleKeyboardEvent):
2921         (WebEditorClient::handleInputMethodKeydown):
2922         (WebEditorClient::textDidChangeInTextField):
2923         (WebEditorClient::requestCheckingOfString):
2924         * WebCoreSupport/WebFrameLoaderClient.h:
2925         * WebCoreSupport/WebFrameLoaderClient.mm:
2926         (WebFrameLoaderClient::detachedFromParent2):
2927         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2928         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2929         (WebFrameLoaderClient::dispatchWillSendRequest):
2930         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2931         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2932         (WebFrameLoaderClient::willCacheResponse const):
2933         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2934         (WebFrameLoaderClient::dispatchDidFinishLoading):
2935         (WebFrameLoaderClient::dispatchDidFailLoading):
2936         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2937         (WebFrameLoaderClient::dispatchWillClose):
2938         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2939         (WebFrameLoaderClient::dispatchDidCommitLoad):
2940         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2941         (WebFrameLoaderClient::dispatchDidFailLoad):
2942         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2943         (WebFrameLoaderClient::dispatchDidFinishLoad):
2944         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2945         (WebFrameLoaderClient::willChangeTitle):
2946         (WebFrameLoaderClient::didChangeTitle):
2947         (WebFrameLoaderClient::didReplaceMultipartContent):
2948         (WebFrameLoaderClient::updateGlobalHistory):
2949         (WebFrameLoaderClient::saveViewStateToItem):
2950         (WebFrameLoaderClient::restoreViewState):
2951         (WebFrameLoaderClient::provisionalLoadStarted):
2952         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2953         (WebFrameLoaderClient::setTitle):
2954         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2955         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2956         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2957         (WebFrameLoaderClient::didRestoreFromPageCache):
2958         (WebFrameLoaderClient::actionDictionary const):
2959         (WebFrameLoaderClient::createPlugin):
2960         (WebFrameLoaderClient::getLoadDecisionForIcons):
2961         (WebFrameLoaderClient::finishedLoadingIcon):
2962         (+[WebFramePolicyListener initialize]):
2963         * WebCoreSupport/WebFrameNetworkingContext.mm:
2964         * WebCoreSupport/WebGeolocationClient.h:
2965         * WebCoreSupport/WebGeolocationClient.mm:
2966         (WebGeolocationClient::requestPermission):
2967         * WebCoreSupport/WebInspectorClient.h:
2968         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2969         * WebCoreSupport/WebNotificationClient.mm:
2970         * WebCoreSupport/WebOpenPanelResultListener.mm:
2971         * WebCoreSupport/WebPlatformStrategies.h:
2972         * WebCoreSupport/WebPlatformStrategies.mm:
2973         * WebCoreSupport/WebProgressTrackerClient.h:
2974         * WebCoreSupport/WebProgressTrackerClient.mm:
2975         (WebProgressTrackerClient::progressStarted):
2976         (WebProgressTrackerClient::progressEstimateChanged):
2977         (WebProgressTrackerClient::progressFinished):
2978         * WebCoreSupport/WebSecurityOrigin.mm:
2979         * WebInspector/WebNodeHighlight.h:
2980         * WebInspector/WebNodeHighlight.mm:
2981         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2982         (-[WebNodeHighlight dealloc]):
2983         (-[WebNodeHighlight attach]):
2984         * WebInspector/WebNodeHighlightView.h:
2985         * WebInspector/WebNodeHighlightView.mm:
2986         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2987         (-[WebNodeHighlightView dealloc]):
2988         * WebInspector/WebNodeHighlighter.mm:
2989         (-[WebNodeHighlighter highlight]):
2990         * WebView/WebArchive.mm:
2991         (+[WebArchivePrivate initialize]):
2992         * WebView/WebClipView.h:
2993         * WebView/WebDataSource.mm:
2994         (WebDataSourcePrivate::WebDataSourcePrivate):
2995         (+[WebDataSource initialize]):
2996         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2997         (-[WebDataSource _makeRepresentation]):
2998         * WebView/WebDelegateImplementationCaching.h:
2999         * WebView/WebDelegateImplementationCaching.mm:
3000         (CallDelegate):
3001         (CallDelegateReturningFloat):
3002         (CallDelegateReturningBoolean):
3003         (CallUIDelegate):
3004         (CallUIDelegateReturningFloat):
3005         (CallUIDelegateReturningBoolean):
3006         (CallFrameLoadDelegate):
3007         (CallFrameLoadDelegateReturningBoolean):
3008         (CallResourceLoadDelegate):
3009         (CallScriptDebugDelegate):
3010         (CallFormDelegate):
3011         (CallFormDelegateReturningBoolean):
3012         * WebView/WebDeviceOrientation.mm:
3013         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3014         * WebView/WebDocumentInternal.h:
3015         * WebView/WebDocumentLoaderMac.mm:
3016         (needsDataLoadWorkaround):
3017         * WebView/WebDynamicScrollBarsViewInternal.h:
3018         * WebView/WebFormDelegate.m:
3019         * WebView/WebFrame.mm:
3020         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3021         (-[WebFrame _unmarkAllMisspellings]):
3022         (-[WebFrame _paintBehaviorForDestinationContext:]):
3023         (-[WebFrame _drawRect:contentsOnly:]):
3024         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3025         (-[WebFrame _scrollDOMRangeToVisible:]):
3026         (-[WebFrame _bodyBackgroundColor]):
3027         (-[WebFrame accessibilityRoot]):
3028         (needsMicrosoftMessengerDOMDocumentWorkaround):
3029         * WebView/WebFrameInternal.h:
3030         * WebView/WebFrameView.mm:
3031         (-[WebFrameView _setDocumentView:]):
3032         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
3033         (-[WebFrameView _viewClassForMIMEType:]):
3034         (-[WebFrameView initWithFrame:]):
3035         (-[WebFrameView drawRect:]):
3036         (-[WebFrameView _firstResponderIsFormControl]):
3037         (-[WebFrameView keyDown:keyDown:]):
3038         (-[WebFrameView _isScrollable]):
3039         * WebView/WebFullScreenController.h:
3040         * WebView/WebFullScreenController.mm:
3041         * WebView/WebHTMLRepresentation.mm:
3042         * WebView/WebHTMLView.mm:
3043         (-[WebHTMLView hitTest:]):
3044         (-[WebHTMLView initWithFrame:]):
3045         (-[WebHTMLView dealloc]):
3046         (-[WebHTMLView addSubview:]):
3047         (-[WebHTMLView mouseDown:]):
3048         (-[WebHTMLView mouseUp:]):
3049         (-[WebHTMLView resignFirstResponder]):
3050         (-[WebHTMLView accessibilityHitTest:]):
3051         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3052         * WebView/WebHTMLViewInternal.h:
3053         * WebView/WebIndicateLayer.h:
3054         * WebView/WebIndicateLayer.mm:
3055         * WebView/WebMediaPlaybackTargetPicker.h:
3056         * WebView/WebMediaPlaybackTargetPicker.mm:
3057         * WebView/WebPDFDocumentExtras.h:
3058         * WebView/WebPDFDocumentExtras.mm:
3059         * WebView/WebPDFRepresentation.h:
3060         * WebView/WebPDFRepresentation.mm:
3061         * WebView/WebPDFView.h:
3062         * WebView/WebPreferences.mm:
3063         (cacheModelForMainBundle):
3064         (WebPreferencesPrivate::WebPreferencesPrivate):
3065         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
3066         (-[WebPreferences encodeWithCoder:]):
3067         (+[WebPreferences standardPreferences]):
3068         (+[WebPreferences initialize]):
3069         (-[WebPreferences _valueForKey:]):
3070         (-[WebPreferences _setStringValue:forKey:]):
3071         (-[WebPreferences _setIntegerValue:forKey:]):
3072         (-[WebPreferences _setUnsignedIntValue:forKey:]):
3073         (-[WebPreferences _setFloatValue:forKey:]):
3074         (-[WebPreferences _setBoolValue:forKey:]):
3075         (-[WebPreferences _setLongLongValue:forKey:]):
3076         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
3077         (-[WebPreferences _postCacheModelChangedNotification]):
3078         (-[WebPreferences _postPreferencesChangedNotification]):
3079         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3080         (-[WebPreferences setStorageBlockingPolicy:]):
3081         * WebView/WebResource.mm:
3082         (+[WebResourcePrivate initialize]):
3083         * WebView/WebTextCompletionController.h:
3084         * WebView/WebTextIterator.mm:
3085         (+[WebTextIteratorPrivate initialize]):
3086         * WebView/WebView.mm:
3087         (shouldEnableLoadDeferring):
3088         (shouldRestrictWindowFocus):
3089         (shouldRespectPriorityInCSSAttributeSetters):
3090         (shouldUseLegacyBackgroundSizeShorthandBehavior):
3091         (shouldAllowPictureInPictureMediaPlayback):
3092         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
3093         (shouldAllowWindowOpenWithoutUserGesture):
3094         (shouldConvertInvalidURLsToBlank):
3095         (shouldRequireUserGestureToLoadVideo):
3096         (-[WebView _commonInitializationWithFrameName:groupName:]):
3097         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
3098         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
3099         (-[WebView _closePluginDatabases]):
3100         (-[WebView _closeWithFastTeardown]):
3101         (-[WebView _close]):
3102         (+[WebView _MIMETypeForFile:]):
3103         (-[WebView setShowingInspectorIndication:]):
3104         (-[WebView _setFormDelegate:]):
3105         (-[WebView _needsPreHTML5ParserQuirks]):
3106         (-[WebView _preferencesChangedNotification:]):
3107         (-[WebView _preferencesChanged:]):
3108         (-[WebView _cacheResourceLoadDelegateImplementations]):
3109         (-[WebView _cacheFrameLoadDelegateImplementations]):
3110         (-[WebView _policyDelegateForwarder]):
3111         (-[WebView _UIDelegateForwarder]):
3112         (-[WebView _editingDelegateForwarder]):
3113         (-[WebView _updateActiveState]):
3114         (-[_WebSafeForwarder forwardInvocation:]):
3115         (+[WebView initialize]):
3116         (-[WebView _pluginForMIMEType:]):
3117         (-[WebView _pluginForExtension:]):
3118         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
3119         (+[WebView canShowMIMETypeAsHTML:]):
3120         (-[WebView _initWithArguments:]):
3121         (-[WebView initWithFrame:frameName:groupName:]):
3122         (-[WebView dealloc]):
3123         (-[WebView close]):
3124         (-[WebView viewDidMoveToWindow]):
3125         (-[WebView setUIDelegate:]):
3126         (-[WebView setResourceLoadDelegate:]):
3127         (-[WebView setPolicyDelegate:]):
3128         (-[WebView setFrameLoadDelegate:]):
3129         (-[WebView goBack]):
3130         (-[WebView goForward]):
3131         (-[WebView stringByEvaluatingJavaScriptFromString:]):
3132         (-[WebView setHostWindow:]):
3133         (-[WebView becomeFirstResponder]):
3134         (+[WebView _cacheModelChangedNotification:]):
3135         (-[WebView _frameViewAtWindowPoint:]):
3136         (+[WebView _preflightSpellCheckerNow:]):
3137         (+[WebView _preflightSpellChecker]):
3138         (-[WebView canGoBack]):
3139         (-[WebView canGoForward]):
3140         (-[WebView stopLoading:]):
3141         (-[WebView reload:]):
3142         (-[WebView setMainFrameDocumentReady:]):
3143         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3144         (-[WebView setContinuousSpellCheckingEnabled:]):
3145         (-[WebView undoManager]):
3146         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
3147         (-[WebView isAutomaticLinkDetectionEnabled]):
3148         (-[WebView isAutomaticDashSubstitutionEnabled]):
3149         (-[WebView isAutomaticTextReplacementEnabled]):
3150         (-[WebView isAutomaticSpellingCorrectionEnabled]):
3151         (+[WebView _setCacheModel:]):
3152         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
3153         (-[WebView _keyboardUIMode]):
3154         (LayerFlushController::flushLayers):
3155         (-[WebView _scheduleCompositingLayerFlush]):
3156         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
3157         (-[WebView fullScreenPlaceholderView]):
3158         (WebInstallMemoryPressureHandler):
3159         * WebView/WebViewData.h:
3160         * WebView/WebViewData.mm:
3161         (+[WebViewPrivate initialize]):
3162         (-[WebViewPrivate init]):
3163         (-[WebViewPrivate dealloc]):
3164         * WebView/WebViewInternal.h:
3165
3166 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3167
3168         Clean up FrameLoader two-state enums
3169         https://bugs.webkit.org/show_bug.cgi?id=190731
3170
3171         Reviewed by Chris Dumez.
3172
3173         * WebCoreSupport/WebFrameLoaderClient.h:
3174         * WebCoreSupport/WebFrameLoaderClient.mm:
3175         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3176
3177 2018-10-18  Alex Christensen  <achristensen@webkit.org>
3178
3179         Unreviewed, rolling out r237137.
3180
3181         SPI is actually used
3182
3183         Reverted changeset:
3184
3185         "Remove unused WebFrame._loadType"
3186         https://bugs.webkit.org/show_bug.cgi?id=190583
3187         https://trac.webkit.org/changeset/237137
3188
3189 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3190
3191         Enable the datalist element by default on iOS and macOS
3192         https://bugs.webkit.org/show_bug.cgi?id=190594
3193         <rdar://problem/45281159>
3194
3195         Reviewed by Ryosuke Niwa and Tim Horton.
3196
3197         * Configurations/FeatureDefines.xcconfig:
3198
3199 2018-10-17  Alex Christensen  <achristensen@webkit.org>
3200
3201         BackForwardClient needs to be able to support UIProcess-only back/forward lists
3202         https://bugs.webkit.org/show_bug.cgi?id=190675
3203
3204         Reviewed by Chris Dumez.
3205
3206         * History/BackForwardList.h:
3207         * History/BackForwardList.mm:
3208         (BackForwardList::backItem):
3209         (BackForwardList::currentItem):
3210         (BackForwardList::forwardItem):
3211         (BackForwardList::backListCount const):
3212         (BackForwardList::forwardListCount const):
3213         (BackForwardList::itemAtIndex):
3214         * History/WebBackForwardList.mm:
3215         (-[WebBackForwardList backItem]):
3216         (-[WebBackForwardList currentItem]):
3217         (-[WebBackForwardList forwardItem]):
3218         (-[WebBackForwardList itemAtIndex:]):
3219
3220 2018-10-16  Timothy Hatcher  <timothy@apple.com>
3221
3222         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
3223         https://bugs.webkit.org/show_bug.cgi?id=190526
3224         rdar://problem/45230140
3225
3226         Reviewed by Dean Jackson.
3227
3228         * WebCoreSupport/WebEditorClient.mm:
3229         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
3230
3231 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3232
3233         Implement feature flag and bindings for CSS Painting API
3234         https://bugs.webkit.org/show_bug.cgi?id=190237
3235
3236         Reviewed by Ryosuke Niwa.
3237
3238         * Configurations/FeatureDefines.xcconfig:
3239
3240 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3241
3242         Replace HistoryItem* with HistoryItem& where possible
3243         https://bugs.webkit.org/show_bug.cgi?id=190617
3244
3245         Reviewed by Chris Dumez.
3246
3247         * History/BackForwardList.h:
3248         * History/BackForwardList.mm:
3249         (BackForwardList::goToItem):
3250         * History/WebBackForwardList.mm:
3251         (-[WebBackForwardList goToItem:]):
3252         * History/WebHistoryItem.mm:
3253         (WKNotifyHistoryItemChanged):
3254         * History/WebHistoryItemInternal.h:
3255
3256 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3257
3258         Remove unused WebHistoryItem._transientPropertyForKey
3259         https://bugs.webkit.org/show_bug.cgi?id=190606
3260
3261         Reviewed by Chris Dumez.
3262
3263         * History/WebHistoryItem.mm:
3264         * History/WebHistoryItemPrivate.h:
3265
3266 2018-10-15  Justin Fan  <justin_fan@apple.com>
3267
3268         Add WebGPU 2018 feature flag and experimental feature flag
3269         https://bugs.webkit.org/show_bug.cgi?id=190509
3270
3271         Reviewed by Dean Jackson.
3272
3273         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3274         for the 2018 WebGPU prototype.
3275
3276         * Configurations/FeatureDefines.xcconfig:
3277         * WebView/WebPreferenceKeysPrivate.h:
3278         * WebView/WebPreferences.mm:
3279         (+[WebPreferences initialize]):
3280         (-[WebPreferences webGPUEnabled]):
3281         (-[WebPreferences setWebGPUEnabled:]):
3282         * WebView/WebPreferencesPrivate.h:
3283         * WebView/WebView.mm:
3284         (-[WebView _preferencesChanged:]):
3285
3286 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3287
3288         Fix iOS build after r237157
3289
3290         * WebView/WebView.mm:
3291         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3292
3293 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3294
3295         Modernize BackForwardClient.h
3296         https://bugs.webkit.org/show_bug.cgi?id=190610
3297
3298         Reviewed by Chris Dumez.
3299
3300         * History/BackForwardList.h:
3301         * History/BackForwardList.mm:
3302         (BackForwardList::backListCount const):
3303         (BackForwardList::forwardListCount const):
3304         (BackForwardList::backListCount): Deleted.
3305         (BackForwardList::forwardListCount): Deleted.
3306         * History/WebBackForwardList.mm:
3307         (-[WebBackForwardList init]):
3308         * WebCoreSupport/WebFrameLoaderClient.mm:
3309         (WebFrameLoaderClient::canCachePage const):
3310         * WebView/WebFrameView.mm:
3311         (-[WebFrameView keyDown:keyDown:]):
3312         * WebView/WebView.mm:
3313         (-[WebView _commonInitializationWithFrameName:groupName:]):
3314         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3315         (-[WebView _loadBackForwardListFromOtherView:]):
3316         (-[WebView initWithCoder:]):
3317         (-[WebView encodeWithCoder:]):
3318         (-[WebView backForwardList]):
3319         (-[WebView setMaintainsBackForwardList:]):
3320
3321 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3322
3323         Add support for prefers-color-scheme media query
3324         https://bugs.webkit.org/show_bug.cgi?id=190499
3325         rdar://problem/45212025
3326
3327         Reviewed by Dean Jackson.
3328
3329         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3330
3331 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3332
3333         Remove unused WebView._globalHistoryItem
3334         https://bugs.webkit.org/show_bug.cgi?id=190601
3335
3336         Reviewed by Chris Dumez.
3337
3338         * WebCoreSupport/WebFrameLoaderClient.h:
3339         * WebCoreSupport/WebFrameLoaderClient.mm:
3340         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3341         * WebView/WebView.mm:
3342         (-[WebView _globalHistoryItem]): Deleted.
3343         (-[WebView _setGlobalHistoryItem:]): Deleted.
3344         * WebView/WebViewData.h:
3345         * WebView/WebViewInternal.h:
3346         * WebView/WebViewPrivate.h:
3347
3348 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3349
3350         Remove unused parameters from FrameLoaderClient::createFrame
3351         https://bugs.webkit.org/show_bug.cgi?id=190587
3352
3353         Reviewed by Chris Dumez.
3354
3355         * WebCoreSupport/WebFrameLoaderClient.h:
3356         * WebCoreSupport/WebFrameLoaderClient.mm:
3357         (WebFrameLoaderClient::createFrame):
3358
3359 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3360
3361         Remove unused WebFrame._loadType
3362         https://bugs.webkit.org/show_bug.cgi?id=190583
3363
3364         Reviewed by Chris Dumez.
3365
3366         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3367
3368         * WebView/WebFrame.mm:
3369         (toWebFrameLoadType): Deleted.
3370         (-[WebFrame _loadType]): Deleted.
3371         * WebView/WebFramePrivate.h:
3372
3373 2018-10-15  Chris Dumez  <cdumez@apple.com>
3374
3375         Restrict browsing context lookup by name to frames that are related to one another
3376         https://bugs.webkit.org/show_bug.cgi?id=190475
3377
3378         Reviewed by Alex Christensen.
3379
3380         * WebView/WebFrame.mm:
3381         (-[WebFrame findFrameNamed:]):
3382
3383 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3384
3385         Remove InjectedBundle processing of back/forward lists
3386         https://bugs.webkit.org/show_bug.cgi?id=190459
3387
3388         Reviewed by Chris Dumez.
3389
3390         * WebCoreSupport/WebFrameLoaderClient.h:
3391         * WebCoreSupport/WebFrameLoaderClient.mm:
3392         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3393
3394 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3395
3396         [JSC] Remove Option::useAsyncIterator
3397         https://bugs.webkit.org/show_bug.cgi?id=190567
3398
3399         Reviewed by Saam Barati.
3400
3401         * Configurations/FeatureDefines.xcconfig:
3402
3403 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3404
3405         Allow encoding of small enum classes
3406         https://bugs.webkit.org/show_bug.cgi?id=190531
3407
3408         Reviewed by Tim Horton.
3409
3410         * WebCoreSupport/WebFrameLoaderClient.mm:
3411         (-[WebFramePolicyListener dealloc]):
3412
3413 2018-10-11  Keith Rollin  <krollin@apple.com>
3414
3415         CURRENT_ARCH should not be used in Run Script phase.
3416         https://bugs.webkit.org/show_bug.cgi?id=190407
3417         <rdar://problem/45133556>
3418
3419         Reviewed by Alexey Proskuryakov.
3420
3421         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3422         CURRENT_ARCH is not well-defined during this phase (and may even have
3423         the value "undefined") since this phase is run just once per build
3424         rather than once per supported architecture. Migrate away from
3425         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3426         performing an operation for each value, or by picking the first entry
3427         in ARCHS and using that as a representative value.
3428
3429         * Configurations/WebKitLegacy.xcconfig: When generating
3430         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3431         macosx platforms.
3432
3433         * MigrateHeaders.make:
3434         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3435         generate one for each architecture in ARCHS.
3436
3437 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3438
3439         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3440         https://bugs.webkit.org/show_bug.cgi?id=190429
3441
3442         Reviewed by Saam Barati.
3443
3444         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3445
3446         * WebView/WebPDFRepresentation.mm:
3447         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3448
3449 2018-10-08  Justin Fan  <justin_fan@apple.com>
3450
3451         WebGPU: Rename old WebGPU prototype to WebMetal
3452         https://bugs.webkit.org/show_bug.cgi?id=190325
3453         <rdar://problem/44990443>
3454
3455         Reviewed by Dean Jackson.
3456
3457         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3458
3459         * Configurations/FeatureDefines.xcconfig:
3460         * WebView/WebPreferenceKeysPrivate.h:
3461         * WebView/WebPreferences.mm:
3462         (+[WebPreferences initialize]):
3463         (-[WebPreferences webMetalEnabled]):
3464         (-[WebPreferences setWebMetalEnabled:]):
3465         (-[WebPreferences webGPUEnabled]): Deleted.
3466         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3467         * WebView/WebPreferencesPrivate.h:
3468         * WebView/WebView.mm:
3469         (-[WebView _preferencesChanged:]):
3470
3471 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3472
3473         Make <input type=color> a runtime enabled (on-by-default) feature
3474         https://bugs.webkit.org/show_bug.cgi?id=189162
3475
3476         Reviewed by Wenson Hsieh and Tim Horton.
3477
3478         * Configurations/FeatureDefines.xcconfig:
3479
3480 2018-10-07  Dan Bernstein  <mitz@apple.com>
3481
3482         Fixed building with the latest macOS SDK
3483
3484         * Plugins/WebNetscapePluginPackage.mm:
3485         (-[WebNetscapePluginPackage openResourceFile]):
3486         (-[WebNetscapePluginPackage closeResourceFile:]):
3487
3488 2018-10-04  Dan Bernstein  <mitz@apple.com>
3489
3490         More Carbon build-fixing.
3491
3492         * Carbon/CarbonWindowAdapter.mm:
3493         (-[CarbonWindowAdapter _destroyRealWindow:]):
3494         (-[CarbonWindowAdapter _growBoxRect]):
3495
3496 2018-10-04  Dan Bernstein  <mitz@apple.com>
3497
3498         Retried to fix 32-bit macOS builds after r236846.
3499
3500         * WebView/WebHTMLView.mm:
3501         (-[WebHTMLView setMarkedText:selectedRange:]):
3502
3503 2018-10-04  Dan Bernstein  <mitz@apple.com>
3504
3505         Retried to fix 32-bit macOS builds after r236846.
3506
3507         * Carbon/HIWebView.mm:
3508         (ActiveStateChanged):
3509
3510 2018-10-04  Dan Bernstein  <mitz@apple.com>
3511
3512         Tried to fix 32-bit macOS builds after r236846.
3513
3514         * Carbon/HIWebView.mm:
3515         (_NSSelectorForHICommand):
3516
3517 2018-10-04  Dan Bernstein  <mitz@apple.com>
3518
3519         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3520         https://bugs.webkit.org/show_bug.cgi?id=190250
3521
3522         Reviewed by Andy Estes.
3523
3524         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3525           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3526           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3527           an earlier line set it to YES.
3528
3529         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3530         changes below.
3531
3532         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3533           provides some missing method declarations.
3534
3535         * Misc/WebDownload.mm:
3536         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3537           a deprecated method.
3538
3539         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3540
3541         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3542           other code in the file uses a method from it.
3543
3544         * Plugins/WebBaseNetscapePluginView.mm:
3545         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3546           a deprecated method.
3547
3548         * Plugins/WebPluginController.mm:
3549         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3550           around use of a selector that may be present in some WebKit client.
3551
3552         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3553           method declarations.
3554
3555         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3556           from here.
3557
3558         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3559           missing method declarations.
3560
3561         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3562           from here.
3563
3564         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3565           call from here.
3566         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3567           an obsolete delegate method for binary compatibility.
3568         (pluginView): Ditto.
3569
3570         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3571           call from here.
3572
3573         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3574           WebDeviceOrientationProviderMock protocol.
3575
3576         * WebView/WebDeviceOrientationProviderMock.mm:
3577         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3578           main @implementation.
3579
3580         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3581           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3582
3583         * WebView/WebDynamicScrollBarsView.mm:
3584         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3585           of a deprecated method.
3586
3587         * WebView/WebHTMLView.mm:
3588         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3589           selector warning around action methods that are not declared anywhere in WebKit.
3590
3591         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3592           about implementing this deprecated method.
3593         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3594         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3595         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3596         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3597         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3598         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3599         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3600         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3601         (-[WebHTMLView doCommandBySelector:]): Ditto.
3602         (-[WebHTMLView insertText:]): Ditto.
3603
3604         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3605
3606         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3607
3608         * WebView/WebPDFView.h: Removed previewView ivar.
3609
3610         * WebView/WebPDFView.mm:
3611           Removed declaration of FileInternal category and merged its implementation with the main
3612           implementation.
3613         (-[WebPDFView dealloc]): Removed previewView ivar.
3614         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3615           exist in macOS versions we support.
3616         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3617         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3618           action methods internal to PDFKit.
3619         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3620         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3621
3622         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3623           call on macOS, even though in r86988 we started calling different methods on iOS.
3624
3625         * WebView/WebView.mm:
3626         - Imported headers that declare delegate methods that we call.
3627         - Removed declaration of WebFileInternal category and merged its implementation with the
3628           main implementation.
3629         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3630           category, which made them impossible to call from the main implementation. Moved those
3631           into the main implementation. One of those had to be declared in a class extension,
3632           because it is called from a method implemented in the WebPrivate category, and that
3633           category’s implementation appears first in the file.
3634
3635         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3636           around use of obsolete delegate method for binary compatibility.
3637
3638         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3639
3640 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3641
3642         Runtime flag and IDL for MediaRecorder
3643         https://bugs.webkit.org/show_bug.cgi?id=190018
3644
3645         Reviewed by Youenn Fablet and Chris Dumez.
3646
3647         * WebView/WebPreferenceKeysPrivate.h:
3648         * WebView/WebPreferences.mm:
3649         (+[WebPreferences initialize]):
3650         (-[WebPreferences mediaRecorderEnabled]):
3651         (-[WebPreferences setMediaRecorderEnabled:]):
3652         * WebView/WebPreferencesPrivate.h:
3653         * WebView/WebView.mm:
3654         (-[WebView _preferencesChanged:]):
3655
3656 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3657
3658         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3659         https://bugs.webkit.org/show_bug.cgi?id=190238
3660
3661         Reviewed by Antti Koivisto.
3662
3663         Enabled the feature by default.
3664
3665         * WebView/WebPreferences.mm:
3666         (+[WebPreferences initialize]):
3667
3668 2018-10-01  Dean Jackson  <dino@apple.com>
3669
3670         [macOS] Switching to discrete GPU should be done in the UI process
3671         https://bugs.webkit.org/show_bug.cgi?id=189361
3672         <rdar://problem/43949622>
3673
3674         Reviewed by Simon Fraser.
3675
3676         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3677         not support swapping to the discrete GPU in this configuration.
3678
3679         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3680         (WebKit::WebSwitchingGPUClient::singleton):
3681         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3682         * WebView/WebView.mm:
3683         (-[WebView _commonInitializationWithFrameName:groupName:]):
3684
3685 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3686
3687         Remove ParsedURLString
3688         https://bugs.webkit.org/show_bug.cgi?id=190154
3689
3690         Reviewed by Chris Dumez.
3691
3692         * WebView/WebScriptDebugger.mm:
3693         (toNSURL):
3694
3695 2018-10-01  Dean Jackson  <dino@apple.com>
3696
3697         Remove CSS Animation Triggers
3698         https://bugs.webkit.org/show_bug.cgi?id=190175
3699         <rdar://problem/44925626>
3700
3701         Reviewed by Simon Fraser.
3702
3703         * Configurations/FeatureDefines.xcconfig:
3704
3705 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3706
3707         Unreviewed, rolling out r236624 and r236671.
3708         https://bugs.webkit.org/show_bug.cgi?id=190207
3709
3710         The change in r236624 introduced crashes on the bots
3711         (Requested by ryanhaddad on #webkit).
3712
3713         Reverted changesets:
3714
3715         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3716         https://bugs.webkit.org/show_bug.cgi?id=188747
3717         https://trac.webkit.org/changeset/236624
3718
3719         "Unify implementation in VideoFullscreenInterfaceAVKit"
3720         https://bugs.webkit.org/show_bug.cgi?id=190091
3721         https://trac.webkit.org/changeset/236671
3722
3723 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3724
3725         URL should not use TextEncoding internally
3726         https://bugs.webkit.org/show_bug.cgi?id=190111
3727
3728         Reviewed by Andy Estes.
3729
3730         * Misc/WebNSURLExtras.mm:
3731
3732 2018-09-28  Jer Noble  <jer.noble@apple.com>
3733
3734         Refactoring: eliminate raw pointer usage in Fullscreen code
3735         https://bugs.webkit.org/show_bug.cgi?id=188747
3736         <rdar://problem/43541164>
3737
3738         Reviewed by Alex Christensen.
3739
3740         PlaybackSessionInterface no longer has an invalidate() method.
3741
3742         * WebView/WebView.mm:
3743         (-[WebView _clearPlaybackControlsManager]):
3744
3745 2018-09-28  Chris Dumez  <cdumez@apple.com>
3746
3747         Drop support for cross-origin-window-policy header
3748         https://bugs.webkit.org/show_bug.cgi?id=190081
3749
3750         Reviewed by Ryosuke Niwa.
3751
3752         * WebView/WebPreferenceKeysPrivate.h:
3753         * WebView/WebPreferences.mm:
3754         (+[WebPreferences initialize]):
3755         * WebView/WebPreferencesPrivate.h:
3756         * WebView/WebView.mm:
3757         (-[WebView _preferencesChanged:]):
3758
3759 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3760
3761         Rename createMarkup to serializePreservingVisualAppearance
3762         https://bugs.webkit.org/show_bug.cgi?id=190086
3763
3764         Reviewed by Wenson Hsieh.
3765
3766         * DOM/WebDOMOperations.mm:
3767         (-[DOMRange markupString]):
3768
3769 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3770
3771         Unreviewed, rolling out r236605.
3772         https://bugs.webkit.org/show_bug.cgi?id=190087
3773
3774         caused three API test timeouts (Requested by jernoble on
3775         #webkit).
3776
3777         Reverted changeset:
3778
3779         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3780         https://bugs.webkit.org/show_bug.cgi?id=188747
3781         https://trac.webkit.org/changeset/236605
3782
3783 2018-09-28  Jer Noble  <jer.noble@apple.com>
3784
3785         Refactoring: eliminate raw pointer usage in Fullscreen code
3786         https://bugs.webkit.org/show_bug.cgi?id=188747
3787         <rdar://problem/43541164>
3788
3789         Reviewed by Alex Christensen.
3790
3791         PlaybackSessionInterface no longer has an invalidate() method.
3792
3793         * WebView/WebView.mm:
3794         (-[WebView _clearPlaybackControlsManager]):
3795
3796 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3797
3798         Use enum class in createMarkup arguments
3799         https://bugs.webkit.org/show_bug.cgi?id=190028
3800
3801         Reviewed by Wenson Hsieh.
3802
3803         * DOM/WebDOMOperations.mm:
3804         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3805         (-[DOMRange markupString]): Ditto.
3806
3807 2018-09-27  Antoine Quint  <graouts@apple.com>
3808
3809         [Web Animations] Turn Web Animations with CSS integration on
3810         https://bugs.webkit.org/show_bug.cgi?id=184819
3811         <rdar://problem/39597337>
3812
3813         Reviewed by Dean Jackson.
3814
3815         * WebView/WebPreferences.mm:
3816         (+[WebPreferences initialize]):
3817
3818 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3819
3820         Selection should work across shadow boundary when initiated by a mouse drag
3821         https://bugs.webkit.org/show_bug.cgi?id=151380
3822         <rdar://problem/24363872>
3823
3824         Reviewed by Wenson Hsieh.
3825
3826         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3827
3828         * WebView/WebPreferenceKeysPrivate.h:
3829         * WebView/WebPreferences.mm:
3830         (+[WebPreferences initialize]):
3831         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3832         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3833         * WebView/WebPreferencesPrivate.h:
3834         * WebView/WebView.mm:
3835         (-[WebView _preferencesChanged:]):
3836
3837 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3838
3839         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3840         https://bugs.webkit.org/show_bug.cgi?id=189918
3841         Work towards <rdar://problem/44648705>
3842
3843         Reviewed by Tim Horton.
3844
3845         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3846
3847         * WebView/WebHTMLView.mm:
3848         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3849         (-[WebHTMLView _updateFontPanel]):
3850         * WebView/WebView.mm:
3851         (-[WebView typingAttributes]):
3852
3853 2018-09-17  Darin Adler  <darin@apple.com>
3854
3855         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3856         https://bugs.webkit.org/show_bug.cgi?id=189652
3857
3858         Reviewed by Saam Barati.
3859
3860         * WebView/WebPDFRepresentation.mm:
3861         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3862
3863 2018-09-14  Jer Noble  <jer.noble@apple.com>
3864
3865         Turn SourceBufferChangeTypeEnabled on by default
3866         https://bugs.webkit.org/show_bug.cgi?id=189527
3867
3868         Reviewed by Eric Carlson.
3869
3870         * WebView/WebPreferences.mm:
3871         (+[WebPreferences initialize]):
3872
3873 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3874
3875         Fix an internal build after r235935
3876         https://bugs.webkit.org/show_bug.cgi?id=188996
3877
3878         * Carbon/HIWebView.mm:
3879         (Draw):
3880         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3881
3882 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3883
3884         Add IGNORE_WARNING_.* macros
3885         https://bugs.webkit.org/show_bug.cgi?id=188996
3886
3887         Reviewed by Michael Catanzaro.
3888
3889         * Carbon/CarbonUtils.m:
3890         (PoolCleaner):
3891         * Carbon/CarbonWindowAdapter.mm:
3892         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3893         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3894         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3895         (-[CarbonWindowAdapter _termWindowIfOwner]):
3896         (-[CarbonWindowAdapter _windowMovedToRect:]):
3897         (-[CarbonWindowAdapter setContentView:]):
3898         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3899         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3900         * Carbon/CarbonWindowFrame.m:
3901         (-[CarbonWindowFrame title]):
3902         * Carbon/HIViewAdapter.m:
3903         (+[HIViewAdapter getHIViewForNSView:]):
3904         * Carbon/HIWebView.mm:
3905         (overrideCGContext):
3906         (restoreCGContext):
3907         (Draw):
3908         * DOM/DOM.mm:
3909         * History/WebHistory.mm:
3910         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3911         * History/WebHistoryItem.mm:
3912         (-[WebHistoryItem icon]):
3913         * Misc/WebKitNSStringExtras.mm:
3914         (-[NSString _web_drawAtPoint:font:textColor:]):
3915         * Misc/WebNSImageExtras.m:
3916         (-[NSImage _web_scaleToMaxSize:]):
3917         (-[NSImage _web_dissolveToFraction:]):
3918         * Misc/WebNSPasteboardExtras.mm:
3919         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3920         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3921         * Panels/WebAuthenticationPanel.m:
3922         (-[WebAuthenticationPanel loadNib]):
3923         * Plugins/Hosted/NetscapePluginHostManager.mm:
3924         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3925         (WebKit::NetscapePluginHostManager::didCreateWindow):
3926         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3927         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3928         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3929         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3930         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3931         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3932         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3933         (-[WebHostedNetscapePluginView drawRect:]):
3934         * Plugins/Hosted/WebTextInputWindowController.m:
3935         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3936         * Plugins/WebBaseNetscapePluginView.mm:
3937         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3938         * Plugins/WebNetscapePluginPackage.mm:
3939         (-[WebNetscapePluginPackage _tryLoad]):
3940         * Plugins/WebNetscapePluginView.mm:
3941         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3942         (-[WebNetscapePluginView sendDrawRectEvent:]):
3943         (-[WebNetscapePluginView drawRect:]):
3944         * Plugins/WebPluginController.mm:
3945         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3946         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3947         * WebCoreSupport/PopupMenuMac.mm:
3948         (PopupMenuMac::populate):
3949         * WebCoreSupport/WebAlternativeTextClient.h:
3950         * WebCoreSupport/WebDragClient.mm:
3951         (WebDragClient::startDrag):
3952         * WebCoreSupport/WebFrameLoaderClient.mm:
3953         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3954         (webGetNSImage):
3955         * WebInspector/WebNodeHighlight.mm:
3956         * WebInspector/WebNodeHighlightView.mm:
3957         (-[WebNodeHighlightView drawRect:]):
3958         * WebView/WebClipView.mm:
3959         (-[WebClipView initWithFrame:]):
3960         * WebView/WebFrame.mm:
3961         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3962         (-[WebFrame _drawRect:contentsOnly:]):
3963         (-[WebFrame accessibilityRoot]):
3964         * WebView/WebFullScreenController.mm:
3965         (-[WebFullScreenController enterFullScreen:]):
3966         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3967         (-[WebFullScreenController exitFullScreen]):
3968         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3969         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3970         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3971         * WebView/WebHTMLView.mm:
3972         (-[NSWindow _web_borderView]):
3973         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3974         (-[WebHTMLView _setAsideSubviews]):
3975         (-[WebHTMLView _autoscroll]):
3976         (-[WebHTMLView drawRect:]):
3977         (-[WebHTMLView mouseDown:]):
3978         (-[WebHTMLView mouseDragged:]):
3979         (-[WebHTMLView mouseUp:]):
3980         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3981         (-[WebHTMLView knowsPageRange:]):
3982         (-[WebHTMLView accessibilityHitTest:]):
3983         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3984         (-[WebHTMLView _colorAsString:]):
3985         (-[WebHTMLView copyFont:]):
3986         (-[WebHTMLView _executeSavedKeypressCommands]):
3987         (-[WebHTMLView attachRootLayer:]):
3988         (-[WebHTMLView textStorage]):
3989         (-[WebHTMLView _updateSelectionForInputManager]):
3990         * WebView/WebPDFView.mm:
3991         (_applicationInfoForMIMEType):
3992         (-[WebPDFView centerSelectionInVisibleArea:]):
3993         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3994         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3995         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3996         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3997         * WebView/WebTextCompletionController.mm:
3998         (-[WebTextCompletionController _buildUI]):
3999         (-[WebTextCompletionController _placePopupWindow:]):
4000         * WebView/WebVideoFullscreenController.mm:
4001         * WebView/WebVideoFullscreenHUDWindowController.mm:
4002         (createMediaUIBackgroundView):
4003         * WebView/WebView.mm:
4004         (-[WebTextListTouchBarViewController initWithWebView:]):
4005         (-[WebView _dispatchTileDidDraw:]):
4006         (-[WebView encodeWithCoder:]):
4007         (-[WebView mainFrameIcon]):
4008         (LayerFlushController::flushLayers):
4009         * WebView/WebWindowAnimation.mm:
4010         (setScaledFrameForWindow):
4011
4012 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
4013
4014         Remove unused needsDestruction class variables from HashTraits
4015         https://bugs.webkit.org/show_bug.cgi?id=189490
4016
4017         Reviewed by Daniel Bates.
4018
4019         * History/BinaryPropertyList.cpp: Removed needsDestruction.
4020
4021 2018-09-07  Frederic Wang  <fwang@igalia.com>
4022
4023         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
4024         https://bugs.webkit.org/show_bug.cgi?id=182230
4025
4026         Reviewed by Simon Fraser.
4027
4028         * DOM/DOMDocument.mm:
4029         (-[DOMDocument scrollingElement]): Use the new name.
4030
4031 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4032
4033         Refactor WebCore::EditAction to be an 8-bit enum class
4034         https://bugs.webkit.org/show_bug.cgi?id=189383
4035
4036         Reviewed by Dan Bernstein.
4037
4038         * WebCoreSupport/WebEditorClient.mm:
4039         (undoNameForEditAction):
4040         * WebView/WebHTMLView.mm:
4041         (-[WebHTMLView pasteFont:]):
4042         (-[WebHTMLView changeFont:]):
4043         (-[WebHTMLView changeAttributes:]):
4044         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
4045         (-[WebHTMLView changeColor:]):
4046         * WebView/WebView.mm:
4047         (-[WebView setTypingStyle:]):
4048
4049 2018-09-06  Frederic Wang  <fwang@igalia.com>
4050
4051         Group options of scrollRectToVisible into a struct
4052         https://bugs.webkit.org/show_bug.cgi?id=189352
4053
4054         Reviewed by Simon Fraser.
4055
4056         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
4057         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
4058         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
4059
4060 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4061
4062         [macOS] Cannot change font size at selection until font panel is shown
4063         https://bugs.webkit.org/show_bug.cgi?id=189295
4064         <rdar://problem/35593389>
4065
4066         Reviewed by Ryosuke Niwa.
4067
4068         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
4069         WebCore ChangeLog for more details.
4070
4071         * WebView/WebHTMLView.mm:
4072         (-[WebHTMLView changeFont:]):
4073         (-[WebHTMLView changeAttributes:]):
4074         (-[WebHTMLView _originalFontA]): Deleted.
4075         (-[WebHTMLView _originalFontB]): Deleted.
4076         (fontNameForDescription): Deleted.
4077         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
4078         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
4079         (-[WebHTMLView _styleForAttributeChange:]): Deleted.