Ensure that style is updated when the effective appearance changes
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
2
3         Ensure that style is updated when the effective appearance changes
4         https://bugs.webkit.org/show_bug.cgi?id=183690
5         <rdar://problem/38385900>
6
7         Reviewed by Tim Horton and Wenson Hsieh.
8
9         Respond to and respect the effective appearance changing.
10
11         * WebView/WebView.mm:
12         (-[WebView _setUseSystemAppearance:]):
13         (-[WebView effectiveAppearanceDidChange]):
14
15 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
16
17         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
18         https://bugs.webkit.org/show_bug.cgi?id=183677
19
20         Reviewed by Tim Horton.
21
22         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
23
24         * DOM/DOM.mm:
25         (-[DOMHTMLLinkElement _mediaQueryMatches]):
26
27 2018-03-14  Tim Horton  <timothy_horton@apple.com>
28
29         Fix the build after r229567
30
31         * Configurations/FeatureDefines.xcconfig:
32
33 2018-03-12  Tim Horton  <timothy_horton@apple.com>
34
35         Stop using SDK conditionals to control feature definitions
36         https://bugs.webkit.org/show_bug.cgi?id=183430
37         <rdar://problem/38251619>
38
39         Reviewed by Dan Bernstein.
40
41         * Configurations/FeatureDefines.xcconfig:
42         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
43
44 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
45
46         Runtime flag for link prefetch and remove link subresource.
47         https://bugs.webkit.org/show_bug.cgi?id=183540
48
49         Reviewed by Chris Dumez.
50
51         Remove the LINK_PREFETCH build time flag.
52
53         * Configurations/FeatureDefines.xcconfig:
54
55 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
56
57         Remove GridLayout runtime flag
58         https://bugs.webkit.org/show_bug.cgi?id=183484
59
60         Reviewed by Myles C. Maxfield.
61
62         The Grid Layout feature has been enabled by default for almost a
63         year, so I think it's time to remove the runtime flag and the
64
65         * WebView/WebPreferenceKeysPrivate.h:
66         * WebView/WebPreferences.mm:
67         (+[WebPreferences initialize]):
68         * WebView/WebPreferencesPrivate.h:
69         * WebView/WebView.mm:
70         (-[WebView _preferencesChanged:]):
71
72 2018-03-12  Antoine Quint  <graouts@apple.com>
73
74         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
75         https://bugs.webkit.org/show_bug.cgi?id=183504
76         <rdar://problem/38372965>
77
78         Reviewed by Dean Jackson and Jon Lee.
79
80         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
81         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
82
83         * WebView/WebPreferenceKeysPrivate.h:
84         * WebView/WebPreferences.mm:
85         (+[WebPreferences initialize]):
86         (-[WebPreferences setModernMediaControlsEnabled:]):
87         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
88         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
89         * WebView/WebPreferencesPrivate.h:
90         * WebView/WebView.mm:
91         (-[WebView _preferencesChanged:]):
92
93 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
94
95         Media query for default appearance
96         https://bugs.webkit.org/show_bug.cgi?id=183539
97         <rdar://problem/38326388>
98
99         Reviewed by Tim Horton.
100
101         Write a media query to evaluate appearance.
102
103         * WebView/WebView.mm:
104         (-[WebView _commonInitializationWithFrameName:groupName:]):
105         (-[WebView _setUseSystemAppearance:]):
106
107 2018-03-09  Andy Estes  <aestes@apple.com>
108
109         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
110         https://bugs.webkit.org/show_bug.cgi?id=183489
111         <rdar://problem/38267517>
112
113         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
114         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
115         to issue a sandbox extension for this directory, but for security reasons App Sandbox
116         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
117         block with a nil error and a valid file URL, but no file will actually exist at that URL.
118
119         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
120         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
121         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
122         drop destination.
123
124         Reviewed by Wenson Hsieh.
125
126         * WebView/WebView.mm:
127         (-[WebView performDragOperation:]):
128
129 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
130
131         Allow WebViews to disable system appearance
132         https://bugs.webkit.org/show_bug.cgi?id=183418
133         <rdar://problem/36975642>
134
135         Reviewed by Tim Horton.
136
137         Allow webviews to choose whether or not to follow the default system appearance.
138
139         * WebView/WebView.mm:
140         (-[WebView _setUseSystemAppearance:]):
141         (-[WebView _useSystemAppearance]):
142         * WebView/WebViewPrivate.h:
143
144 2018-03-08  Youenn Fablet  <youenn@apple.com>
145
146         libwebrtc update broke internal builds
147         https://bugs.webkit.org/show_bug.cgi?id=183454
148
149         Reviewed by Eric Carlson.
150
151         * Configurations/WebKitLegacy.xcconfig:
152
153 2018-03-08  Chris Dumez  <cdumez@apple.com>
154
155         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
156         https://bugs.webkit.org/show_bug.cgi?id=183455
157         <rdar://problem/38191749>
158
159         Reviewed by Youenn Fablet.
160
161         Add a null check for the page as we have evidence from crashes that it can be null.
162         Other functions in WebFrameNetworkingContext already null check the page as well,
163         not just the frame so this is consistent.
164
165         * WebCoreSupport/WebFrameNetworkingContext.mm:
166         (WebFrameNetworkingContext::storageSession const):
167
168 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
169
170         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
171         https://bugs.webkit.org/show_bug.cgi?id=183429
172
173         Reviewed by Mark Lam.
174
175         * DOM/DOM.mm:
176         (+[DOMNode _nodeFromJSWrapper:]):
177         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
178         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
179         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
180         * Plugins/Hosted/ProxyInstance.mm:
181         (WebKit::ProxyInstance::invokeMethod):
182         * WebView/WebView.mm:
183         (aeDescFromJSValue):
184
185 2018-03-08  Tim Horton  <timothy_horton@apple.com>
186
187         Stop linking ApplicationServices directly
188         https://bugs.webkit.org/show_bug.cgi?id=182867
189         <rdar://problem/38252142>
190
191         Reviewed by Alex Christensen.
192
193         The frameworks that we use that live inside ApplicationServices
194         have mostly moved out, so import them directly.
195
196         * Carbon/CarbonUtils.h:
197         * WebKitPrefix.h:
198         * WebView/WebHTMLView.mm:
199         * WebView/WebPDFView.mm:
200
201 2018-03-07  Tim Horton  <timothy_horton@apple.com>
202
203         Sort and separate FeatureDefines.xcconfig
204         https://bugs.webkit.org/show_bug.cgi?id=183427
205
206         Reviewed by Dan Bernstein.
207
208         * Configurations/FeatureDefines.xcconfig:
209         Sort and split FeatureDefines into paragraphs
210         (to make it easier to sort later).
211
212 2018-03-07  Youenn Fablet  <youenn@apple.com>
213
214         Match unsupported plugins based on domains and not origin
215         https://bugs.webkit.org/show_bug.cgi?id=183384
216
217         Reviewed by Chris Dumez.
218
219         * WebCoreSupport/WebPluginInfoProvider.h:
220         * WebCoreSupport/WebPluginInfoProvider.mm:
221         (WebPluginInfoProvider::getPluginInfo):
222         (WebPluginInfoProvider::getWebVisiblePluginInfo):
223
224 2018-03-05  Andy Estes  <aestes@apple.com>
225
226         [Mac] Teach WebCore::Pasteboard about file promise drags
227         https://bugs.webkit.org/show_bug.cgi?id=183314
228         <rdar://problem/38105493>
229
230         Reviewed by Darin Adler.
231
232         Added a FIXME comment.
233
234         * WebView/WebView.mm:
235         (-[WebView performDragOperation:]):
236
237 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
238
239         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
240         https://bugs.webkit.org/show_bug.cgi?id=183312
241
242         Reviewed by Mark Lam.
243
244         Remove wtf/CurrentTime.h include pragma.
245
246         * WebView/WebFrame.mm:
247         * WebView/WebPDFView.mm:
248
249 2018-03-04  Tim Horton  <timothy_horton@apple.com>
250
251         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
252         https://bugs.webkit.org/show_bug.cgi?id=183283
253         <rdar://problem/38062148>
254
255         Reviewed by Sam Weinig.
256
257         * Configurations/FeatureDefines.xcconfig:
258
259 2018-02-28  Alex Christensen  <achristensen@webkit.org>
260
261         Reduce use of NetworkingContext in WebKit
262         https://bugs.webkit.org/show_bug.cgi?id=183213
263
264         Reviewed by Brady Eidson.
265
266         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
267         (WebKit::NetscapePluginInstanceProxy::getProxy):
268         * Plugins/WebNetscapePluginView.mm:
269         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
270
271 2018-02-17  Darin Adler  <darin@apple.com>
272
273         Prepare for ExtendedColor changes (first step)
274         https://bugs.webkit.org/show_bug.cgi?id=182904
275
276         Reviewed by Sam Weinig.
277
278         * Misc/WebKitNSStringExtras.mm:
279         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
280
281 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
282
283         Remove currentTime() / currentTimeMS()
284         https://bugs.webkit.org/show_bug.cgi?id=183052
285
286         Reviewed by Mark Lam.
287
288         * WebCoreSupport/WebFrameLoaderClient.h:
289         * WebCoreSupport/WebFrameLoaderClient.mm:
290         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
291
292 2018-02-16  Youenn Fablet  <youenn@apple.com>
293
294         Allow specifying which plug-ins are supported
295         https://bugs.webkit.org/show_bug.cgi?id=182748
296
297         Reviewed by Chris Dumez.
298
299         * WebCoreSupport/WebPluginInfoProvider.h:
300         * WebCoreSupport/WebPluginInfoProvider.mm:
301         (WebPluginInfoProvider::getPluginInfo):
302         (WebPluginInfoProvider::getWebVisiblePluginInfo):
303
304 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
305
306         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
307         https://bugs.webkit.org/show_bug.cgi?id=182882
308         <rdar://problem/35672661>
309
310         Reviewed by Dan Bernstein.
311
312         Make sure the smart pointer hold the collection of subviews lives at least as
313         long as the loop using it.
314
315         * WebView/WebHTMLView.mm:
316         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
317
318 2018-02-14  Daniel Bates  <dabates@apple.com>
319
320         Disallow cross-origin subresources from asking for credentials
321         https://bugs.webkit.org/show_bug.cgi?id=182579
322         <rdar://problem/36162271>
323
324         Reviewed by Andy Estes.
325
326         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
327         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
328
329         * WebView/WebPreferenceKeysPrivate.h:
330         * WebView/WebPreferences.mm:
331         (+[WebPreferences initialize]):
332         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
333         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
334         * WebView/WebPreferencesPrivate.h:
335         * WebView/WebView.mm:
336         (-[WebView _preferencesChanged:]):
337
338 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
339
340         Remove ForwardingHeaders directory from WebKitLegacy/mac.
341         https://bugs.webkit.org/show_bug.cgi?id=182738
342
343         Reviewed by Darin Adler.
344
345         * ForwardingHeaders/collector/handles/Global.h: Removed.
346         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
347         * ForwardingHeaders/runtime/Completion.h: Removed.
348         * ForwardingHeaders/runtime/Error.h: Removed.
349         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
350         * ForwardingHeaders/runtime/JSFunction.h: Removed.
351         * ForwardingHeaders/runtime/JSLock.h: Removed.
352         * ForwardingHeaders/runtime/JSObject.h: Removed.
353         * ForwardingHeaders/runtime/JSString.h: Removed.
354         * ForwardingHeaders/runtime/Protect.h: Removed.
355         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
356
357 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
358
359         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
360         https://bugs.webkit.org/show_bug.cgi?id=182641
361
362         Reviewed by Dan Bernstein.
363
364         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
365         https://trac.webkit.org/changeset/228308.
366
367         * WebView/WebVideoFullscreenController.h:
368         * WebView/WebVideoFullscreenHUDWindowController.mm:
369         * WebView/WebWindowAnimation.h:
370         * WebView/WebWindowAnimation.mm:
371         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
372         (WebCore::scaledRect): Deleted.
373         (WebCore::squaredDistance): Deleted.
374
375 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
376
377         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
378
379         * WebView/WebWindowAnimation.mm:
380         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
381
382 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
383
384         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
385         https://bugs.webkit.org/show_bug.cgi?id=182615
386
387         Reviewed by Eric Carlson.
388
389         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
390         Ideally, we should not reference NSApp in WebCore.
391
392         * WebView/WebFullScreenController.mm:
393         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
394         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
395         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
396         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
397         * WebView/WebView.mm:
398         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
399         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
400
401 2018-01-13  Darin Adler  <darin@apple.com>
402
403         Event improvements
404         https://bugs.webkit.org/show_bug.cgi?id=179591
405
406         Reviewed by Chris Dumez.
407
408         * DOM/DOMWheelEvent.mm:
409         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
410         Call initWebKitWheelEvent.
411
412         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
413         * WebCoreSupport/WebInspectorClient.mm: Ditto.
414         * WebView/WebFrame.mm: Ditto.
415
416         * WebView/WebHTMLView.mm:
417         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
418         underlyingPlatformEvent.
419         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
420
421         * WebView/WebScriptWorld.mm:
422         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
423
424         * WebView/WebView.mm: Removed include of ScriptValue.h.
425
426 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
427
428         Remove WebCore/ForwardingHeaders directory
429         https://bugs.webkit.org/show_bug.cgi?id=182347
430
431         Reviewed by Keith Miller.
432
433         * Carbon/CarbonWindowAdapter.mm:
434         * DOM/WebDOMOperations.mm:
435         * History/WebBackForwardList.mm:
436         * History/WebHistoryItem.mm:
437         * Misc/WebCache.mm:
438         * Misc/WebElementDictionary.mm:
439         * Misc/WebIconDatabase.mm:
440         * Misc/WebStringTruncator.mm:
441         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
442         * Plugins/Hosted/ProxyInstance.mm:
443         * Plugins/Hosted/ProxyRuntimeObject.mm:
444         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
445         * Plugins/WebBaseNetscapePluginView.mm:
446         * Plugins/WebBasePluginPackage.mm:
447         * Plugins/WebNetscapePluginStream.mm:
448         * Plugins/WebNetscapePluginView.mm:
449         * Plugins/WebPluginController.mm:
450         * WebCoreSupport/WebEditorClient.mm:
451         * WebCoreSupport/WebFrameLoaderClient.mm:
452         * WebCoreSupport/WebInspectorClient.h:
453         * WebCoreSupport/WebInspectorClient.mm:
454         * WebView/WebDataSource.mm:
455         * WebView/WebFrame.mm:
456         * WebView/WebHTMLRepresentation.mm:
457         * WebView/WebHTMLView.mm:
458         * WebView/WebPreferences.mm:
459         * WebView/WebScriptDebugDelegate.mm:
460         * WebView/WebScriptDebugger.h:
461         * WebView/WebTextIterator.mm:
462         * WebView/WebView.mm:
463         * WebView/WebViewData.mm:
464
465 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
466
467         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
468         https://bugs.webkit.org/show_bug.cgi?id=182312
469
470         Reviewed by Michael Catanzaro.
471
472         * WebKitPrefix.h:
473
474 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
475
476         [WebAuthN] Add a compile-time feature flag
477         https://bugs.webkit.org/show_bug.cgi?id=182211
478         <rdar://problem/36936365>
479
480         Reviewed by Brent Fulgham.
481
482         * Configurations/FeatureDefines.xcconfig:
483
484 2018-01-27  Dan Bernstein  <mitz@apple.com>
485
486         HaveInternalSDK includes should be "#include?"
487         https://bugs.webkit.org/show_bug.cgi?id=179670
488
489         * Configurations/Base.xcconfig:
490
491 2018-01-24  Alex Christensen  <achristensen@webkit.org>
492
493         Remove unused QTKit preference
494         https://bugs.webkit.org/show_bug.cgi?id=181968
495
496         Reviewed by Alexey Proskuryakov.
497
498         * WebView/WebPreferenceKeysPrivate.h:
499         * WebView/WebPreferences.mm:
500         (+[WebPreferences initialize]):
501         (-[WebPreferences setQTKitEnabled:]): Deleted.
502         (-[WebPreferences isQTKitEnabled]): Deleted.
503         * WebView/WebPreferencesPrivate.h:
504         * WebView/WebView.mm:
505         (-[WebView _preferencesChanged:]):
506
507 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
508
509         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
510         https://bugs.webkit.org/show_bug.cgi?id=182037
511         <rdar://problem/36747812>
512
513         Reviewed by Ryosuke Niwa.
514
515         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
516         for more details.
517
518         * WebView/WebHTMLRepresentation.mm:
519         (-[WebHTMLRepresentation elementWithName:inForm:]):
520         (-[WebHTMLRepresentation controlsInForm:]):
521
522 2018-01-23  Alex Christensen  <achristensen@webkit.org>
523
524         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
525         https://bugs.webkit.org/show_bug.cgi?id=181961
526
527         Reviewed by Michael Catanzaro.
528
529         * WebView/WebPreferences.mm:
530
531 2018-01-23  Commit Queue  <commit-queue@webkit.org>
532
533         Unreviewed, rolling out r227437.
534         https://bugs.webkit.org/show_bug.cgi?id=182011
535
536         broke build (Requested by alexchristensen on #webkit).
537
538         Reverted changeset:
539
540         "Remove unused QTKit preference"
541         https://bugs.webkit.org/show_bug.cgi?id=181968
542         https://trac.webkit.org/changeset/227437
543
544 2018-01-23  Alex Christensen  <achristensen@webkit.org>
545
546         Remove unused QTKit preference
547         https://bugs.webkit.org/show_bug.cgi?id=181968
548
549         Reviewed by Alexey Proskuryakov.
550
551         * WebView/WebPreferenceKeysPrivate.h:
552         * WebView/WebPreferences.mm:
553         (+[WebPreferences initialize]):
554         (-[WebPreferences setQTKitEnabled:]): Deleted.
555         (-[WebPreferences isQTKitEnabled]): Deleted.
556         * WebView/WebPreferencesPrivate.h:
557         * WebView/WebView.mm:
558         (-[WebView _preferencesChanged:]):
559
560 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
561
562         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
563         https://bugs.webkit.org/show_bug.cgi?id=181960
564         <rdar://problem/36431678>
565
566         Reviewed by Tim Horton.
567
568         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
569         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
570         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
571
572         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
573         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
574         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
575
576         * WebView/WebView.mm:
577         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
578
579 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
580
581         Turning off custom pasteboard data doesn't actually turn it off in WK2
582         https://bugs.webkit.org/show_bug.cgi?id=181920
583         <rdar://problem/36686429>
584
585         Reviewed by Wenson Hsieh.
586
587         Always disable custom pasteboard data in WebKit1. See r226156 for details.
588
589         * WebView/WebPreferences.mm:
590         (+[WebPreferences initialize]):
591         * WebView/WebView.mm:
592         (-[WebView _preferencesChanged:]):
593
594 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
595
596         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
597         https://bugs.webkit.org/show_bug.cgi?id=181918
598
599         Reviewed by Tim Horton.
600
601         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
602
603         * Configurations/FeatureDefines.xcconfig:
604
605 2018-01-20  Andy Estes  <aestes@apple.com>
606
607         [Apple Pay] Stop eagerly loading PassKit.framework
608         https://bugs.webkit.org/show_bug.cgi?id=181911
609         <rdar://problem/36555369>
610
611         Reviewed by Tim Horton.
612
613         * WebCoreSupport/WebPaymentCoordinatorClient.h:
614         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
615         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
616
617         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
618
619 2018-01-19  Dean Jackson  <dino@apple.com>
620
621         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
622         https://bugs.webkit.org/show_bug.cgi?id=181817
623         <rdar://problem/35274055>
624
625         Reviewed by Simon Fraser.
626
627         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
628
629         * Misc/WebKitVersionChecks.h:
630         * WebView/WebView.mm:
631         (-[WebView _commonInitializationWithFrameName:groupName:]):
632
633 2018-01-19  Alex Christensen  <achristensen@webkit.org>
634
635         Remove unused WebViewPrivate _allowCookies
636         https://bugs.webkit.org/show_bug.cgi?id=181812
637
638         Reviewed by Tim Horton.
639
640         * WebView/WebView.mm:
641         (+[WebView _setAllowCookies:]): Deleted.
642         (+[WebView _allowCookies]): Deleted.
643         * WebView/WebViewPrivate.h:
644
645 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
646
647         Build fix, remove a call to -[NSWindow setOneShot:]
648         https://bugs.webkit.org/show_bug.cgi?id=181809
649
650         Reviewed by Tim Horton.
651
652         * WebView/WebTextCompletionController.mm:
653         (-[WebTextCompletionController _buildUI]):
654
655 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
656
657         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
658
659         * Carbon/HIWebView.mm:
660         (overrideCGContext):
661         (restoreCGContext):
662
663 2018-01-18  Dan Bernstein  <mitz@apple.com>
664
665         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
666         https://bugs.webkit.org/show_bug.cgi?id=181803
667
668         Reviewed by Tim Horton.
669
670         * Configurations/Base.xcconfig: Updated.
671         * Configurations/DebugRelease.xcconfig: Ditto.
672         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
673         * Configurations/Version.xcconfig: Updated.
674         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
675           useful for defining settings that depend on the target macOS version.
676
677 2018-01-17  Youenn Fablet  <youenn@apple.com>
678
679         Put fetch Request.keepalive behind a runtime flag
680         https://bugs.webkit.org/show_bug.cgi?id=181592
681
682         Reviewed by Chris Dumez.
683
684         * WebView/WebPreferenceKeysPrivate.h:
685         * WebView/WebPreferences.mm:
686         (+[WebPreferences initialize]):
687         (-[WebPreferences fetchAPIKeepAliveEnabled]):
688         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
689         * WebView/WebPreferencesPrivate.h:
690         * WebView/WebView.mm:
691         (-[WebView _preferencesChanged:]):
692
693 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
694
695         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
696         https://bugs.webkit.org/show_bug.cgi?id=181637
697         <rdar://problem/36508471>
698
699         Reviewed by Tim Horton.
700
701         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
702
703         * WebCoreSupport/WebEditorClient.h:
704         * WebCoreSupport/WebEditorClient.mm:
705         (WebEditorClient::replacementURLForResource):
706
707 2018-01-11  Keith Miller  <keith_miller@apple.com>
708
709         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
710         https://bugs.webkit.org/show_bug.cgi?id=181573
711
712         Reviewed by Simon Fraser.
713
714         * Configurations/FeatureDefines.xcconfig:
715
716 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
717
718         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
719         https://bugs.webkit.org/show_bug.cgi?id=181497
720
721         Reviewed by Tim Horton.
722
723         See other ChangeLogs for more detail.
724
725         * WebCoreSupport/WebDragClient.h:
726
727 2018-01-11  Tim Horton  <timothy_horton@apple.com>
728
729         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
730         https://bugs.webkit.org/show_bug.cgi?id=181523
731         <rdar://problem/28959131>
732
733         Reviewed by Alex Christensen.
734
735         * WebView/WebImmediateActionController.mm:
736         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
737         Apply the change made in r216652 to WebKit1's immediate action controller.
738
739         Speculative (but successful in WebKit2) fix for non-reproducible crash when
740         the startContainer of the range is in an anonymous node.
741
742 2018-01-11  Youenn Fablet  <youenn@apple.com>
743
744         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
745         https://bugs.webkit.org/show_bug.cgi?id=181480
746
747         Reviewed by Eric Carlson.
748
749         * WebView/WebPreferences.mm:
750         (+[WebPreferences initialize]):
751
752 2018-01-08  David Kilzer  <ddkilzer@apple.com>
753
754         Fix check-webkit-style issues with WebNSDataExtras.mm
755         <https://webkit.org/b/181369>
756
757         Reviewed by Alex Christensen.
758
759         * Misc/WebNSDataExtras.mm:
760         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
761         (-[NSData _webkit_guessedMIMETypeForXML]):
762         (-[NSData _webkit_guessedMIMEType]):
763         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
764         (_findEOL):
765         (-[NSData _webkit_parseRFC822HeaderFields]):
766         (-[NSData _web_locationAfterFirstBlankLine]):
767         - Fix all the check-webkit-style warnings.
768
769 2018-01-08  David Kilzer  <ddkilzer@apple.com>
770
771         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
772         <https://webkit.org/b/181256>
773         <rdar://problem/36281730>
774
775         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
776         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
777         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
778           to avoid warnings from casting CFStringRef to NPNSString*.
779           Note that CFMutableStringRef is the same as CFStringRef
780           without the const modifier, hence its use in the const_cast<>
781           above.
782
783 2018-01-08  David Kilzer  <ddkilzer@apple.com>
784
785         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
786         <https://webkit.org/b/181256>
787         <rdar://problem/36281730>
788
789         * Carbon/HIWebView.mm:
790         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
791         checked_cf_cast<CFRunLoopRef>() to fix warning.
792
793 2018-01-07  David Kilzer  <ddkilzer@apple.com>
794
795         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
796         <https://webkit.org/b/181256>
797         <rdar://problem/36281730>
798
799         Reviewed by Darin Adler.
800
801         * Carbon/CarbonUtils.m:
802         (PoolCleaner):
803         - Use #pragmas to ignore -Wcast-qual warnings when using a
804           C-style cast from CFTypeRef to CFRunloopRef.
805         * Carbon/CarbonWindowFrame.m:
806         (-[CarbonWindowFrame title]):
807         - Use #pragmas to ignore -Wcast-qual warnings when using a
808           C-style cast from CFStringRef to NSString *.
809         * Carbon/HIViewAdapter.m:
810         (+[HIViewAdapter getHIViewForNSView:]):
811         - Use #pragmas to ignore -Wcast-qual warnings when using a
812           C-style cast from CFTypeRef to HIViewRef.
813         * Configurations/Base.xcconfig:
814         (WARNING_CFLAGS): Add -Wcast-qual.
815         * Misc/WebElementDictionary.mm:
816         (-[WebElementDictionary objectForKey:]):
817         - Use static_cast<SEL>(const_cast<void*>()) to fix
818           warning.
819         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
820         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
821         (-[NSData _webkit_guessedMIMETypeForXML]):
822         (-[NSData _webkit_guessedMIMEType]):
823         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
824         (_findEOL):
825         (-[NSData _webkit_parseRFC822HeaderFields]):
826         (-[NSData _web_startsWithBlankLine]):
827         (-[NSData _web_locationAfterFirstBlankLine]):
828         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
829           type to Objective-C++.  This fixes the warnings about
830           discarding the `const` modifier when casing from CFStringRef
831           to NSString * because in older clang versions, -Wcast-qual was
832           completely broken when compiling C++ and Objective-C++ source
833           files.  In newer clang versions, discarding the `const`
834           modifier for toll-free bridged types is ignored when compiling
835           Objective-C++ source.
836         - Update copyright and license header.
837         - Use reinterpret_cast<> and static_cast<> to fix warnings
838           unrelated to (NSString *) C-style casts.
839         - Replace use of MIN() macro with std::min<> template functions.
840         - Fix location of `*` for local variables modified above.
841         * Plugins/Hosted/NetscapePluginHostManager.mm:
842         (WebKit::NetscapePluginHostManager::spawnPluginHost):
843         (WebKit::NetscapePluginHostManager::initializeVendorPort):
844         (WebKit::NetscapePluginHostManager::instantiatePlugin):
845         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
846           warnings.
847         * Plugins/Hosted/NetscapePluginHostProxy.mm:
848         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
849         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
850           to fix warning.
851         * Plugins/Hosted/ProxyInstance.mm:
852         (WebKit::ProxyInstance::invoke):
853         - Use static_cast<char*>(const_cast<void*>()) to fix
854           warning when using -[NSData bytes].
855         (WebKit::ProxyInstance::fieldValue const):
856         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
857           to fix warning when using CFDataGetBytePtr().
858         * Plugins/Hosted/WebTextInputWindowController.m:
859         (-[WebTextInputPanel _interpretKeyEvent:string:]):
860         - Use #pragma to ignore -Wcast-qual warning since there
861           is not a good way to avoid this warning in Objective-C.
862         * Plugins/WebNetscapePluginStream.mm:
863         (WebNetscapePluginStream::deliverData):
864         - Use const_cast<void*>() to fix warning when using
865           -[NSData bytes].
866         * Plugins/WebNetscapePluginView.mm:
867         (-[WebNetscapePluginView _createPlugin]):
868         - Change C-style cast to const_cast<char*>() to fix
869           warning.
870         * WebCoreSupport/WebChromeClient.mm:
871         (WebChromeClient::wrapCryptoKey const):
872         (WebChromeClient::unwrapCryptoKey const):
873         - Change C-style cast to
874           static_cast<uint8_t*>(const_cast<void*>() to fix
875           warning.
876         * WebView/WebPDFView.mm:
877         (_applicationInfoForMIMEType):
878         - Change local variable type from 'NSURL *' to
879           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
880           when calling -[NSURL path].
881
882 2018-01-05  Dan Bernstein  <mitz@apple.com>
883
884         Fixed the build following AppKit API deprecations in a recent SDKs
885
886         * WebView/WebFullScreenController.mm:
887         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
888         (-[WebFullScreenController exitFullScreen]): Ditto.
889         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
890         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
891         * WebView/WebHTMLView.mm:
892         (-[WebHTMLView drawRect:]): Ditto.
893         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
894         (-[WebHTMLView knowsPageRange:]): Ditto.
895         * WebView/WebView.mm:
896         (LayerFlushController::flushLayers): Ditto.
897
898 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
899
900         [Attachment Support] Create attachment elements when dropping files on iOS
901         https://bugs.webkit.org/show_bug.cgi?id=181192
902         <rdar://problem/36280945>
903
904         Reviewed by Tim Horton.
905
906         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
907
908         * WebCoreSupport/WebPlatformStrategies.h:
909         * WebCoreSupport/WebPlatformStrategies.mm:
910         (WebPlatformStrategies::informationForItemAtIndex):
911         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
912
913 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
914
915         [Attachment Support] Add plumbing for starting a drag with promised blob data
916         https://bugs.webkit.org/show_bug.cgi?id=181201
917
918         Reviewed by Tim Horton.
919
920         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
921
922         * WebCoreSupport/WebDragClient.h:
923
924 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
925
926         Add a WebAuthentication runtime feature flag
927         https://bugs.webkit.org/show_bug.cgi?id=181220
928         <rdar://problem/36055305>
929
930         Reviewed by Brent Fulgham.
931
932         Renames the CredentialManagement runtime feature flag into WebAuthentication.
933
934         * WebView/WebPreferenceKeysPrivate.h:
935         * WebView/WebPreferences.mm:
936         (+[WebPreferences initialize]):
937         (-[WebPreferences webAuthenticationEnabled]):
938         (-[WebPreferences setWebAuthenticationEnabled:]):
939         (-[WebPreferences credentialManagementEnabled]): Deleted.
940         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
941         * WebView/WebPreferencesPrivate.h:
942         * WebView/WebView.mm:
943         (-[WebView _preferencesChanged:]):
944
945 2017-12-22  Jeff Miller  <jeffm@apple.com>
946
947         Update user-visible copyright strings to include 2018
948         https://bugs.webkit.org/show_bug.cgi?id=181141
949
950         Reviewed by Dan Bernstein.
951
952         * Info.plist:
953
954 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
955
956         [Attachment Support] Remove current macOS support for dragging file-backed attachments
957         https://bugs.webkit.org/show_bug.cgi?id=181188
958
959         Reviewed by Dan Bernstein.
960
961         See WebCore/ChangeLog for more detail.
962
963         * WebCoreSupport/WebDragClient.h:
964         * WebCoreSupport/WebDragClient.mm:
965         (WebDragClient::declareAndWriteAttachment): Deleted.
966         * WebView/WebHTMLView.mm:
967         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
968
969 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
970
971         Unreviewed, continue to fix build failures due to AppKit API deprecation
972
973         Wraps more code in -Wdeprecated-declarations.
974
975         * Carbon/HIWebView.mm:
976         (overrideCGContext):
977
978 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
979
980         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
981
982         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
983
984         * Carbon/CarbonWindowAdapter.mm:
985         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
986         * Plugins/WebNetscapePluginView.mm:
987         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
988         (-[WebNetscapePluginView sendDrawRectEvent:]):
989         (-[WebNetscapePluginView drawRect:]):
990
991 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
992
993         Fix build failures due to using deprecated AppKit symbols
994         https://bugs.webkit.org/show_bug.cgi?id=181110
995         <rdar://problem/36162865>
996
997         Reviewed by Dan Bernstein and Tim Horton.
998
999         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1000
1001         * Misc/WebKitNSStringExtras.mm:
1002         (-[NSString _web_drawAtPoint:font:textColor:]):
1003         * Misc/WebNSPasteboardExtras.h:
1004         * Misc/WebNSPasteboardExtras.mm:
1005         (+[NSPasteboard _web_writableTypesForURL]):
1006         (_createWritableTypesForImageWithoutArchive):
1007         (_createWritableTypesForImageWithArchive):
1008         (+[NSPasteboard _web_dragTypesForURL]):
1009         (-[NSPasteboard _web_bestURL]):
1010         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1011         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1012         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1013         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1014         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1015         * Panels/WebAuthenticationPanel.m:
1016         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1017         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1018         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1019         (-[WebHostedNetscapePluginView drawRect:]):
1020         * WebInspector/WebNodeHighlightView.mm:
1021         (-[WebNodeHighlightView drawRect:]):
1022         * WebView/WebFrame.mm:
1023         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1024         (-[WebFrame _drawRect:contentsOnly:]):
1025         * WebView/WebHTMLView.mm:
1026         (kit):
1027         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1028         (-[WebHTMLView _plainTextFromPasteboard:]):
1029         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1030         (+[WebHTMLView _insertablePasteboardTypes]):
1031         (+[WebHTMLView _selectionPasteboardTypes]):
1032         (-[WebHTMLView pasteboard:provideDataForType:]):
1033         (-[WebHTMLView _writeSelectionToPasteboard:]):
1034         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1035         (-[WebHTMLView validRequestorForSendType:returnType:]):
1036         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1037         (createMenuItem):
1038         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1039         (-[WebHTMLView _colorAsString:]):
1040         (-[WebHTMLView copyFont:]):
1041         * WebView/WebPDFView.mm:
1042         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1043         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1044         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1045         (-[WebPDFView pasteboardTypesForSelection]):
1046         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1047         * WebView/WebView.h:
1048         * WebView/WebView.mm:
1049         (-[WebView performDragOperation:]):
1050         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1051         (-[WebView _searchWithGoogleFromMenu:]):
1052
1053 2017-12-21  Youenn Fablet  <youenn@apple.com>
1054
1055         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1056         https://bugs.webkit.org/show_bug.cgi?id=181000
1057
1058         Reviewed by Chris Dumez.
1059
1060         * Misc/WebCache.mm:
1061         (+[WebCache addImageToCache:forURL:forFrame:]):
1062
1063 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1064
1065         Update FULLSCREEN_API feature defines.
1066         https://bugs.webkit.org/show_bug.cgi?id=181015
1067
1068         Reviewed by Tim Horton.
1069
1070         Change enabled iphone sdk for FULLSCREEN_API.
1071
1072         * Configurations/FeatureDefines.xcconfig:
1073
1074 2017-12-21  Jer Noble  <jer.noble@apple.com>
1075
1076         Add initial DOM support for Media Capabilities
1077         https://bugs.webkit.org/show_bug.cgi?id=181064
1078
1079         Reviewed by Eric Carlson.
1080
1081         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1082
1083         * WebView/WebPreferenceKeysPrivate.h:
1084         * WebView/WebPreferences.mm:
1085         (+[WebPreferences initialize]):
1086         (-[WebPreferences mediaCapabilitiesEnabled]):
1087         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1088         * WebView/WebPreferencesPrivate.h:
1089         * WebView/WebView.mm:
1090         (-[WebView _preferencesChanged:]):
1091
1092 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1093
1094         Enable picture-in-picture from inline element on suspend.
1095         https://bugs.webkit.org/show_bug.cgi?id=180942
1096         rdar://problem/34745234
1097
1098         Reviewed by Jer Noble.
1099
1100         Update signature of enterVideoFullscreenForVideoElement().
1101
1102         * WebCoreSupport/WebChromeClient.h:
1103         * WebCoreSupport/WebChromeClient.mm:
1104         (WebChromeClient::enterVideoFullscreenForVideoElement):
1105
1106 2017-12-20  Daniel Bates  <dabates@apple.com>
1107
1108         Remove Alternative Presentation Button
1109         https://bugs.webkit.org/show_bug.cgi?id=180500
1110         <rdar://problem/35891047>
1111
1112         Reviewed by Simon Fraser.
1113
1114         We no longer need the alternative presentation button.
1115
1116         * Configurations/FeatureDefines.xcconfig:
1117
1118 2017-12-19  Jer Noble  <jer.noble@apple.com>
1119
1120         Playing media elements which call "pause(); play()" will have the play promise rejected.
1121         https://bugs.webkit.org/show_bug.cgi?id=180781
1122         <rdar://problem/33191377>
1123
1124         Reviewed by Eric Carlson.
1125
1126         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1127
1128         * WebView/WebView.mm:
1129         (shouldRequireUserGestureToLoadVideo):
1130
1131 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1132
1133         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1134         https://bugs.webkit.org/show_bug.cgi?id=180977
1135
1136         Reviewed by Tim Horton.
1137
1138         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1139         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1140         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1141
1142         * WebCoreSupport/WebEditorClient.mm:
1143         (attributesForAttributedStringConversion):
1144         * WebView/WebHTMLView.mm:
1145         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1146
1147 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1148
1149         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1150
1151         Attempt to fix the following warnings:
1152
1153             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1154
1155         For the following instance variables:
1156
1157             _borderView
1158             _contentView
1159             _frame
1160             _wFlags
1161
1162         * Carbon/CarbonWindowAdapter.mm:
1163         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1164         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1165         (-[CarbonWindowAdapter _termWindowIfOwner]):
1166         (-[CarbonWindowAdapter _windowMovedToRect:]):
1167         (-[CarbonWindowAdapter setContentView:]):
1168         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1169         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1170
1171 2017-12-16  Dan Bernstein  <mitz@apple.com>
1172
1173         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1174         https://bugs.webkit.org/show_bug.cgi?id=180613
1175         <rdar://problem/35946124>
1176
1177         Reviewed by Geoff Garen.
1178
1179         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1180           clients.
1181         * WebView/WebDynamicScrollBarsView.h: Ditto.
1182         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1183
1184 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1185
1186         Enable -Wstrict-prototypes for WebKit
1187         <https://webkit.org/b/180757>
1188         <rdar://problem/36024132>
1189
1190         Rubber-stamped by Joseph Pecoraro.
1191
1192         * Configurations/Base.xcconfig:
1193         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1194
1195 2017-12-14  John Wilander  <wilander@apple.com>
1196
1197         Storage Access API: Implement frame-specific access in the document.cookie layer
1198         https://bugs.webkit.org/show_bug.cgi?id=180682
1199         <rdar://problem/35982257>
1200
1201         Reviewed by Alex Christensen.
1202
1203         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1204         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1205         CookiesStrategy::getRawCookies() now take optional parameters for
1206         frameID and pageID to allow frame-specific scoping of cookies.
1207
1208         This change makes the return values of FrameLoaderClient::frameID()
1209         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1210         WebCore can call those getters and get the right return values in
1211         WebKit and std:nullopt in WebKitLegacy.
1212
1213         * WebCoreSupport/WebFrameLoaderClient.h:
1214         * WebCoreSupport/WebFrameLoaderClient.mm:
1215         (WebFrameLoaderClient::pageID const):
1216         (WebFrameLoaderClient::frameID const):
1217         * WebCoreSupport/WebPlatformStrategies.h:
1218         * WebCoreSupport/WebPlatformStrategies.mm:
1219         (WebPlatformStrategies::cookiesForDOM):
1220         (WebPlatformStrategies::setCookiesFromDOM):
1221         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1222         (WebPlatformStrategies::getRawCookies):
1223
1224 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1225
1226         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1227         https://bugs.webkit.org/show_bug.cgi?id=180689
1228
1229         Reviewed by Tim Horton.
1230
1231         Use sRGBColorSpaceRef() from WebCore.
1232
1233         * WebView/WebHTMLView.mm:
1234         (imageFromRect):
1235
1236 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1237
1238         Stop using deprecated target conditional for simulator builds
1239         https://bugs.webkit.org/show_bug.cgi?id=180662
1240         <rdar://problem/35136156>
1241
1242         Reviewed by Simon Fraser.
1243
1244         * postprocess-headers.sh:
1245
1246 2017-12-11  David Quesada  <david_quesada@apple.com>
1247
1248         Turn on ENABLE_APPLICATION_MANIFEST
1249         https://bugs.webkit.org/show_bug.cgi?id=180562
1250         rdar://problem/35924737
1251
1252         Reviewed by Geoffrey Garen.
1253
1254         * Configurations/FeatureDefines.xcconfig:
1255
1256 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1257
1258         Remove pthread_once in favor of dispatch_once
1259         https://bugs.webkit.org/show_bug.cgi?id=180591
1260
1261         Reviewed by Saam Barati.
1262
1263         * Misc/WebKitErrors.m:
1264         (+[NSError _registerWebKitErrors]):
1265         (registerErrors): Deleted.
1266         * Storage/WebStorageManager.mm:
1267         (+[WebStorageManager _storageDirectoryPath]):
1268         (initializeLocalStoragePath): Deleted.
1269
1270 2017-12-07  Darin Adler  <darin@apple.com>
1271
1272         Remove some unused code from WebKitLegacy
1273         https://bugs.webkit.org/show_bug.cgi?id=180567
1274
1275         Reviewed by Anders Carlsson.
1276
1277         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1278         macOS (back a few versions) and iOS and removed unused
1279         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1280         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1281         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1282         _webkit_stringByCollapsingNonPrintingCharacters,
1283         _webkit_stringByCollapsingWhitespaceCharacters,
1284         _web_stringWithData:textEncodingName:, and
1285         _webkit_localStorageDirectoryWithBundleIdentifier:.
1286
1287         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1288         this source file.
1289         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1290         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1291         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1292         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1293         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1294         handle font smoothing options.
1295         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1296         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1297         from header and made it a little clearer.
1298         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1299         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1300         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1301         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1302         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1303         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1304         implementation a bit and used whole words instead of abbreviations.
1305         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1306
1307         * Misc/WebNSFileManagerExtras.mm:
1308         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1309         filenameByFixingIllegalCharacters function from WebCore directly instead of
1310         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1311
1312         * Plugins/WebBaseNetscapePluginView.mm:
1313         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1314         string replacements instead of _web_stringByStrippingReturnCharacters
1315         and to use NSString methods instead of CFString functions.
1316
1317 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1318
1319         Ignore deprecation warnings.
1320
1321         * WebView/WebHTMLView.mm:
1322         (-[NSWindow _web_borderView]):
1323         (-[WebHTMLView _setAsideSubviews]):
1324         * WebView/WebView.mm:
1325         (-[WebView encodeWithCoder:]):
1326
1327 2017-12-02  Darin Adler  <darin@apple.com>
1328
1329         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1330         https://bugs.webkit.org/show_bug.cgi?id=180009
1331
1332         Reviewed by Alex Christensen.
1333
1334         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1335
1336         * Plugins/WebBaseNetscapePluginView.mm:
1337         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1338         of strcasecmp.
1339
1340         * WebView/WebPreferences.mm:
1341         (contains): Ditto. Also made this a template so it's easier to call on an array.
1342         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1343
1344 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1345
1346         Limit user agent versioning to an upper bound
1347         https://bugs.webkit.org/show_bug.cgi?id=180365
1348         <rdar://problem/34550617>
1349
1350         Reviewed by Joseph Pecoraro.
1351
1352         * WebView/WebView.mm:
1353         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1354         creating the User Agent string.
1355         (webKitBundleVersionString): Deleted.
1356
1357 2017-12-05  Andy Estes  <aestes@apple.com>
1358
1359         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1360         https://bugs.webkit.org/show_bug.cgi?id=180457
1361         <rdar://problem/35143007>
1362
1363         Reviewed by Tim Horton.
1364
1365         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1366         check for this macro during post-processing.
1367
1368         * postprocess-headers.sh:
1369
1370 2017-12-04  David Quesada  <david_quesada@apple.com>
1371
1372         Add a class for parsing application manifests
1373         https://bugs.webkit.org/show_bug.cgi?id=177973
1374         rdar://problem/34747949
1375
1376         Reviewed by Geoffrey Garen.
1377
1378         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1379
1380 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1381
1382         Make LegacyCustomProtocolManager optional for network process
1383         https://bugs.webkit.org/show_bug.cgi?id=176230
1384
1385         Reviewed by Alex Christensen.
1386
1387         * Configurations/FeatureDefines.xcconfig:
1388
1389 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1390
1391         Fix some NSOperationQueue leaks
1392         https://bugs.webkit.org/show_bug.cgi?id=180221
1393
1394         Reviewed by Wenson Hsieh.
1395
1396         * WebView/WebView.mm:
1397         (-[WebView performDragOperation:]):
1398
1399 2017-11-30  Darin Adler  <darin@apple.com>
1400
1401         [Mac] remove unneeded RetainPtr use introduced in r225142
1402         https://bugs.webkit.org/show_bug.cgi?id=180202
1403
1404         Reviewed by Tim Horton.
1405
1406         * WebView/WebImmediateActionController.mm:
1407         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1408         RetainPtr.
1409
1410 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1411
1412         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1413         https://bugs.webkit.org/show_bug.cgi?id=175595
1414
1415         Reviewed by Darin Adler.
1416
1417         * WebView/WebPreferences.mm:
1418
1419 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1420
1421         One too many zeroes in macOS version number in FeatureDefines
1422         https://bugs.webkit.org/show_bug.cgi?id=180011
1423
1424         Reviewed by Dan Bernstein.
1425
1426         * Configurations/FeatureDefines.xcconfig:
1427
1428 2017-11-23  Darin Adler  <darin@apple.com>
1429
1430         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1431         https://bugs.webkit.org/show_bug.cgi?id=179981
1432
1433         Reviewed by Sam Weinig.
1434
1435         * WebView/WebImmediateActionController.mm:
1436         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1437         * WebView/WebView.mm:
1438         (coreOptions): Use |= instead of | to build up FindOptions.
1439
1440 2017-11-23  Sam Weinig  <sam@webkit.org>
1441
1442         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1443         https://bugs.webkit.org/show_bug.cgi?id=179954
1444
1445         Reviewed by Darin Adler.
1446
1447         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1448         with direct calls to the corresponding UserGestureIndicator functions.
1449
1450         * Plugins/WebPluginController.mm:
1451         (-[WebPluginController processingUserGesture]):
1452         * WebView/WebView.mm:
1453         (-[WebView _isProcessingUserGesture]):
1454
1455 2017-11-23  Darin Adler  <darin@apple.com>
1456
1457         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1458         https://bugs.webkit.org/show_bug.cgi?id=179907
1459
1460         Reviewed by Sam Weinig.
1461
1462         * History/BinaryPropertyList.cpp:
1463         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1464         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1465         * WebView/WebHTMLRepresentation.mm:
1466         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1467         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1468
1469 2017-11-22  Ali Juma  <ajuma@chromium.org>
1470
1471         Implement VisualViewport API attributes
1472         https://bugs.webkit.org/show_bug.cgi?id=179385
1473
1474         Reviewed by Frédéric Wang.
1475
1476         Add a VisualViewportAPI preference.
1477
1478         * WebView/WebPreferenceKeysPrivate.h:
1479         * WebView/WebPreferences.mm:
1480         (+[WebPreferences initialize]):
1481         (-[WebPreferences visualViewportAPIEnabled]):
1482         (-[WebPreferences setVisualViewportAPIEnabled:]):
1483         * WebView/WebPreferencesPrivate.h:
1484         * WebView/WebView.mm:
1485         (-[WebView _preferencesChanged:]):
1486
1487 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1488
1489         WebCoreObjCExtras.h is being included in too many places
1490         https://bugs.webkit.org/show_bug.cgi?id=179931
1491
1492         Reviewed by Darin Adler.
1493
1494         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1495         * Plugins/WebBaseNetscapePluginView.mm:
1496         * Plugins/WebBasePluginPackage.mm:
1497         * Plugins/WebNetscapePluginStream.mm:
1498         * Plugins/WebNetscapePluginView.mm:
1499         * WebView/WebTextIterator.mm:
1500         * WebView/WebViewData.mm:
1501
1502 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1503
1504         Unreviewed, rolling out r225093.
1505         https://bugs.webkit.org/show_bug.cgi?id=179938
1506
1507         Compilation failed on WinCairo 64-bit Release (Requested by
1508         fredw on #webkit).
1509
1510         Reverted changeset:
1511
1512         "Implement VisualViewport API attributes"
1513         https://bugs.webkit.org/show_bug.cgi?id=179385
1514         https://trac.webkit.org/changeset/225093
1515
1516 2017-11-21  Ali Juma  <ajuma@chromium.org>
1517
1518         Implement VisualViewport API attributes
1519         https://bugs.webkit.org/show_bug.cgi?id=179385
1520
1521         Reviewed by Frédéric Wang.
1522
1523         Add a VisualViewportAPI preference.
1524
1525         * WebView/WebPreferenceKeysPrivate.h:
1526         * WebView/WebPreferences.mm:
1527         (+[WebPreferences initialize]):
1528         (-[WebPreferences visualViewportAPIEnabled]):
1529         (-[WebPreferences setVisualViewportAPIEnabled:]):
1530         * WebView/WebPreferencesPrivate.h:
1531         * WebView/WebView.mm:
1532         (-[WebView _preferencesChanged:]):
1533
1534 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1535
1536         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1537         https://bugs.webkit.org/show_bug.cgi?id=179504
1538
1539         Reviewed by Darin Adler.
1540
1541         * Misc/WebKitNSStringExtras.mm:
1542         * Plugins/Hosted/NetscapePluginHostManager.mm:
1543         * Plugins/WebBasePluginPackage.mm:
1544
1545 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1546
1547         Remove unused TOUCH_ICON_LOADING feature flag
1548         https://bugs.webkit.org/show_bug.cgi?id=179873
1549
1550         Reviewed by Simon Fraser.
1551
1552         * Configurations/FeatureDefines.xcconfig:
1553
1554 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1555
1556         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1557         https://bugs.webkit.org/show_bug.cgi?id=179872
1558
1559         Reviewed by Darin Adler.
1560
1561         * Configurations/FeatureDefines.xcconfig:
1562
1563 2017-11-16  Daniel Bates  <dabates@apple.com>
1564
1565         Add feature define for alternative presentation button element
1566         https://bugs.webkit.org/show_bug.cgi?id=179692
1567         Part of <rdar://problem/34917108>
1568
1569         Reviewed by Andy Estes.
1570
1571         Only enabled on Cocoa platforms by default.
1572
1573         * Configurations/FeatureDefines.xcconfig:
1574
1575 2017-11-14  Nan Wang  <n_wang@apple.com>
1576
1577         AX: AOM: Implement AccessibleNode class and support label and role attributes
1578         https://bugs.webkit.org/show_bug.cgi?id=179494
1579
1580         Reviewed by Ryosuke Niwa.
1581
1582         * WebView/WebPreferenceKeysPrivate.h:
1583         * WebView/WebPreferences.mm:
1584         (+[WebPreferences initialize]):
1585         (-[WebPreferences accessibilityObjectModelEnabled]):
1586         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1587         * WebView/WebPreferencesPrivate.h:
1588         * WebView/WebView.mm:
1589         (-[WebView _preferencesChanged:]):
1590
1591 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1592
1593         Remove Cocoa CFURLConnection loading code
1594         https://bugs.webkit.org/show_bug.cgi?id=179688
1595
1596         Reviewed by Antti Koivisto.
1597
1598         * Misc/WebDownload.mm:
1599         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1600         * Misc/WebDownloadInternal.h:
1601         * Plugins/WebBaseNetscapePluginView.mm:
1602         * WebCoreSupport/WebFrameLoaderClient.mm:
1603         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1604         * WebView/WebView.mm:
1605         (-[WebView scheduleInRunLoop:forMode:]):
1606         (-[WebView unscheduleFromRunLoop:forMode:]):
1607
1608 2017-11-14  Daniel Bates  <dabates@apple.com>
1609
1610         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1611         for feature defines
1612
1613         Following r195498 and r201917 the Visual Studio property files for feature defines have
1614         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1615         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1616         files.
1617
1618         * Configurations/FeatureDefines.xcconfig:
1619
1620 2017-11-14  Jer Noble  <jer.noble@apple.com>
1621
1622         Enable Modern EME tests in DumpRenderTree
1623         https://bugs.webkit.org/show_bug.cgi?id=179544
1624
1625         Reviewed by Alex Christensen.
1626
1627         Add a WebPreferences property to enable the (modern) EME API.
1628
1629         * WebView/WebPreferenceKeysPrivate.h:
1630         * WebView/WebPreferences.mm:
1631         (+[WebPreferences initialize]):
1632         (-[WebPreferences encryptedMediaAPIEnabled]):
1633         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1634         * WebView/WebPreferencesPrivate.h:
1635         * WebView/WebView.mm:
1636         (-[WebView _preferencesChanged:]):
1637
1638 2017-11-14  Antti Koivisto  <antti@apple.com>
1639
1640         Enable display:contents by default
1641         https://bugs.webkit.org/show_bug.cgi?id=179655
1642
1643         Reviewed by Sam Weinig.
1644
1645         * WebView/WebPreferences.mm:
1646         (+[WebPreferences initialize]):
1647
1648 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1649
1650         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1651         https://bugs.webkit.org/show_bug.cgi?id=178751
1652
1653         Reviewed by Brady Eidson.
1654
1655         * WebCoreSupport/WebFrameNetworkingContext.mm:
1656         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1657
1658 2017-11-08  Keith Miller  <keith_miller@apple.com>
1659
1660         Async iteration should only fetch the next method once and add feature flag
1661         https://bugs.webkit.org/show_bug.cgi?id=179451
1662
1663         Reviewed by Geoffrey Garen.
1664
1665         Add feature flag for Async iteration.
1666
1667         * Configurations/FeatureDefines.xcconfig:
1668
1669 2017-11-13  Mark Lam  <mark.lam@apple.com>
1670
1671         Add more overflow check book-keeping for MarkedArgumentBuffer.
1672         https://bugs.webkit.org/show_bug.cgi?id=179634
1673         <rdar://problem/35492517>
1674
1675         Reviewed by Saam Barati.
1676
1677         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1678         (WebKit::NetscapePluginInstanceProxy::invoke):
1679         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1680         (WebKit::NetscapePluginInstanceProxy::construct):
1681
1682 2017-11-12  Darin Adler  <darin@apple.com>
1683
1684         More is<> and downcast<>, less static_cast<>
1685         https://bugs.webkit.org/show_bug.cgi?id=179600
1686
1687         Reviewed by Chris Dumez.
1688
1689         * DOM/DOM.mm:
1690         (kit): Use is/downcast.
1691         * WebCoreSupport/WebEditorClient.mm:
1692         (WebEditorClient::handleKeyboardEvent): Ditto.
1693         (WebEditorClient::handleInputMethodKeydown): Ditto.
1694         * WebView/WebHTMLView.mm:
1695         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1696
1697 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1698
1699         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1700         https://bugs.webkit.org/show_bug.cgi?id=179397
1701
1702         Reviewed by Wenson Hsieh.
1703
1704         * DOM/DOMHTMLInputElement.mm:
1705         (-[DOMHTMLInputElement insertTextSuggestion:]):
1706
1707 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1708
1709         HTMLMediaElement should not use element fullscreen on iOS
1710         https://bugs.webkit.org/show_bug.cgi?id=179418
1711         rdar://problem/35409277
1712
1713         Reviewed by Eric Carlson.
1714
1715         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1716
1717         * Configurations/FeatureDefines.xcconfig:
1718
1719 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1720
1721         Make ResourceLoader::willSendRequestInternal asynchronous
1722         https://bugs.webkit.org/show_bug.cgi?id=179251
1723
1724         Reviewed by Andy Estes.
1725
1726         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1727         (WebKit::HostedNetscapePluginStream::start):
1728         * Plugins/WebNetscapePluginStream.mm:
1729         (WebNetscapePluginStream::start):
1730
1731 2017-11-01  Darin Adler  <darin@apple.com>
1732
1733         Simplify event dispatch code and make it a bit more consistent
1734         https://bugs.webkit.org/show_bug.cgi?id=178991
1735
1736         Reviewed by Chris Dumez.
1737
1738         * DOM/DOMEvent.mm:
1739         (-[DOMEvent srcElement]): Call target instead of srcElement.
1740
1741 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1742
1743         [Touch Bar Web API] Add support for menuitem tag
1744         https://bugs.webkit.org/show_bug.cgi?id=179020
1745
1746         Reviewed by Ryosuke Niwa.
1747
1748         Adds in properties and methods that allow the menuitem runtime feature
1749         to be enabled or disabled.
1750
1751         * WebView/WebPreferenceKeysPrivate.h:
1752         * WebView/WebPreferences.mm:
1753         (-[WebPreferences menuItemElementEnabled]):
1754         (-[WebPreferences setMenuItemElementEnabled:]):
1755         * WebView/WebPreferencesPrivate.h:
1756         * WebView/WebView.mm:
1757         (-[WebView _preferencesChanged:]):
1758
1759 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1760
1761         Use CompletionHandlers for redirects
1762         https://bugs.webkit.org/show_bug.cgi?id=179163
1763
1764         Reviewed by Tim Horton.
1765
1766         * Plugins/Hosted/HostedNetscapePluginStream.h:
1767         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1768         (WebKit::HostedNetscapePluginStream::willSendRequest):
1769         * Plugins/WebNetscapePluginStream.h:
1770         * Plugins/WebNetscapePluginStream.mm:
1771         (WebNetscapePluginStream::willSendRequest):
1772
1773 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1774
1775         Add a FileSystem namespace to FileSystem.cpp
1776         https://bugs.webkit.org/show_bug.cgi?id=179063
1777
1778         Reviewed by Darin Adler.
1779
1780         * Misc/WebNSFileManagerExtras.mm:
1781         * Storage/WebDatabaseProvider.mm:
1782
1783 2017-11-02  Frederic Wang  <fwang@igalia.com>
1784
1785         Add references to bug 179167 in FIXME comments
1786         https://bugs.webkit.org/show_bug.cgi?id=179168
1787
1788         Reviewed by Daniel Bates.
1789
1790         * Configurations/FeatureDefines.xcconfig:
1791
1792 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1793
1794         Implement WKFullscreenWindowController for iOS.
1795         https://bugs.webkit.org/show_bug.cgi?id=178924
1796         rdar://problem/34697120
1797
1798         Reviewed by Simon Fraser.
1799
1800         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1801
1802         * Configurations/FeatureDefines.xcconfig:
1803         * WebView/WebView.mm:
1804         (-[WebView fullScreenPlaceholderView]):
1805
1806 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1807
1808         Clean up some drag and drop feature flags
1809         https://bugs.webkit.org/show_bug.cgi?id=179082
1810
1811         Reviewed by Simon Fraser.
1812
1813         * Configurations/FeatureDefines.xcconfig:
1814
1815 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1816
1817         Make it possible to test rubber-banding in overflow scroll
1818         https://bugs.webkit.org/show_bug.cgi?id=179078
1819
1820         Reviewed by Sam Weinig.
1821
1822         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1823         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1824
1825         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1826         functions, since most callers want clamped.
1827
1828         * DOM/DOMHTML.mm:
1829         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1830
1831 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1832
1833         Fix up some content filtering feature flags
1834         https://bugs.webkit.org/show_bug.cgi?id=179079
1835
1836         Reviewed by Simon Fraser.
1837
1838         * Configurations/FeatureDefines.xcconfig:
1839
1840 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1841
1842         [FrameView::layout cleanup] Move core layout logic to a separate class.
1843         https://bugs.webkit.org/show_bug.cgi?id=178771
1844         <rdar://problem/35166542>
1845
1846         Reviewed by Simon Fraser.
1847
1848         Move layout code out from FrameView to LayoutContext.
1849
1850         * WebView/WebClipView.mm:
1851         (-[WebClipView _immediateScrollToPoint:]):
1852         * WebView/WebFrame.mm:
1853         (-[WebFrame layoutCount]):
1854
1855 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1856
1857         Fix issues with WebView subframe painting
1858         https://bugs.webkit.org/show_bug.cgi?id=178842
1859         rdar://problem/34072253
1860
1861         Reviewed by Daniel Bates.
1862         
1863         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1864         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1865         High Sierra, so match the new signature.
1866
1867         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1868
1869         * WebView/WebHTMLView.mm:
1870         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1871         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1872
1873 2017-10-25  Youenn Fablet  <youenn@apple.com>
1874
1875         Enable ServiceWorker to fetch resources
1876         https://bugs.webkit.org/show_bug.cgi?id=178673
1877
1878         Reviewed by Brady Eidson.
1879
1880         * WebCoreSupport/WebFrameLoaderClient.mm:
1881         (WebFrameLoaderClient::pageID const):
1882         (WebFrameLoaderClient::frameID const):
1883         (WebFrameLoaderClient::sessionID const):
1884
1885         Added implementation to the new getters.
1886         They are noop in the context of WK1.
1887
1888 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1889
1890         Web Inspector: Enable WebKit logging configuration and display
1891         https://bugs.webkit.org/show_bug.cgi?id=177027
1892         <rdar://problem/33964767>
1893
1894         Reviewed by Joseph Pecoraro.
1895
1896         * WebCoreSupport/WebChromeClient.mm:
1897         (stringForMessageSource): Deal with Media and WebRTC message sources.
1898
1899 2017-10-20  Antoine Quint  <graouts@apple.com>
1900
1901         [Web Animations] Provide basic timeline and animation interfaces
1902         https://bugs.webkit.org/show_bug.cgi?id=178526
1903
1904         Reviewed by Dean Jackson.
1905
1906         Remove the WEB_ANIMATIONS compile-time flag.
1907
1908         * Configurations/FeatureDefines.xcconfig:
1909         * WebView/WebPreferences.mm:
1910         (+[WebPreferences initialize]):
1911         * WebView/WebView.mm:
1912         (-[WebView _preferencesChanged:]):
1913
1914 2017-10-19  Sam Weinig  <sam@webkit.org>
1915
1916         [Settings] Move global settings into their own file
1917         https://bugs.webkit.org/show_bug.cgi?id=178512
1918
1919         Reviewed by Darin Adler.
1920
1921         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1922
1923         * WebCoreSupport/WebChromeClient.mm:
1924         (WebChromeClient::supportsVideoFullscreen):
1925         * WebView/WebDynamicScrollBarsView.mm:
1926         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1927         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1928         * WebView/WebPreferences.mm:
1929         (+[WebPreferences initialize]):
1930         * WebView/WebView.mm:
1931         (-[WebView _commonInitializationWithFrameName:groupName:]):
1932         (-[WebView _preferencesChanged:]):
1933         (+[WebView _doNotStartObservingNetworkReachability]):
1934
1935 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1936
1937         Replace some stack raw pointers with RefPtrs within WebCore/html
1938         https://bugs.webkit.org/show_bug.cgi?id=178201
1939         <rdar://problem/34841692>
1940
1941         Reviewed by Ryosuke Niwa.
1942
1943         * DOM/DOM.mm:
1944         (kit):
1945         Change the type of node as toNode() is changed to return RefPtr.
1946
1947 2017-10-18  Chris Dumez  <cdumez@apple.com>
1948
1949         [Service Worker] Add stubs for Client / WindowClient / Clients
1950         https://bugs.webkit.org/show_bug.cgi?id=178469
1951
1952         Reviewed by Youenn Fablet.
1953
1954         Rename PageVisiblityState to VisibilityState.
1955
1956         * WebView/WebView.mm:
1957         (kit):
1958
1959 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1960
1961         Unreviewed, rolling out r223291.
1962
1963         See WebCore ChangeLog for more detail.
1964
1965         Reverted changeset:
1966
1967         "Remove Editor::simplifyMarkup"
1968         https://bugs.webkit.org/show_bug.cgi?id=178271
1969         https://trac.webkit.org/changeset/223291
1970
1971 2017-10-17  Keith Miller  <keith_miller@apple.com>
1972
1973         Change WebCore sources to work with unified source builds
1974         https://bugs.webkit.org/show_bug.cgi?id=178229
1975
1976         Rubber stamped by Tim Horton.
1977
1978         * Configurations/FeatureDefines.xcconfig:
1979
1980 2017-10-16  Sam Weinig  <sam@webkit.org>
1981
1982         [Settings] Remove all custom code from Settings.h/cpp
1983         https://bugs.webkit.org/show_bug.cgi?id=178330
1984
1985         Reviewed by Simon Fraser.
1986
1987         * WebView/WebPreferences.mm:
1988         (+[WebPreferences initialize]):
1989         
1990             Update for naming changes of FrameFlattening now that it is an enum class.
1991
1992 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1993
1994         Remove Editor::simplifyMarkup
1995         https://bugs.webkit.org/show_bug.cgi?id=178271
1996
1997         Reviewed by Wenson Hsieh.
1998
1999         * WebView/WebView.mm:
2000         (-[WebView _simplifyMarkup:endNode:]):
2001
2002 2017-10-12  Chris Dumez  <cdumez@apple.com>
2003
2004         [Mac] Add support for MouseEvent.buttons
2005         https://bugs.webkit.org/show_bug.cgi?id=178214
2006
2007         Reviewed by Ryosuke Niwa.
2008
2009         * WebView/WebPDFView.mm:
2010         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2011
2012 2017-10-11  Sam Weinig  <sam@webkit.org>
2013
2014         Remove out-parameter variants of copyToVector
2015         https://bugs.webkit.org/show_bug.cgi?id=178155
2016
2017         Reviewed by Tim Horton.
2018
2019         * Plugins/WebNetscapePluginView.mm:
2020         (-[WebNetscapePluginView destroyPlugin]):
2021         * WebView/WebHTMLRepresentation.mm:
2022         (newArrayWithStrings):
2023
2024             Replace out-parameter based copyToVector, with one that returns a Vector.
2025
2026 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2027
2028         Sanitize URL in pasteboard for other applications and cross origin content
2029         https://bugs.webkit.org/show_bug.cgi?id=178060
2030         <rdar://problem/34874518>
2031
2032         Reviewed by Wenson Hsieh.
2033
2034         * WebCoreSupport/WebPlatformStrategies.h:
2035         * WebCoreSupport/WebPlatformStrategies.mm:
2036         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2037
2038 2017-10-11  Chris Dumez  <cdumez@apple.com>
2039
2040         Modernize Geolocation code
2041         https://bugs.webkit.org/show_bug.cgi?id=178148
2042
2043         Reviewed by Ryosuke Niwa.
2044
2045         * WebCoreSupport/WebGeolocationClient.h:
2046         * WebCoreSupport/WebGeolocationClient.mm:
2047         (WebGeolocationClient::lastPosition):
2048         * WebView/WebGeolocationPosition.mm:
2049         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2050         (core):
2051         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2052         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2053         * WebView/WebGeolocationPositionInternal.h:
2054
2055 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2056
2057         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2058         https://bugs.webkit.org/show_bug.cgi?id=178154
2059
2060         Reviewed by Wenson Hsieh.
2061
2062         Enable custom pasteboard data by default.
2063
2064         * WebView/WebPreferenceKeysPrivate.h:
2065         * WebView/WebPreferences.mm:
2066         (+[WebPreferences initialize]):
2067         (-[WebPreferences customPasteboardDataEnabled]): Added.
2068         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2069         * WebView/WebPreferencesPrivate.h:
2070         * WebView/WebView.mm:
2071         (-[WebView _preferencesChanged:]):
2072
2073 2017-10-10  Sam Weinig  <sam@webkit.org>
2074
2075         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2076         https://bugs.webkit.org/show_bug.cgi?id=178102
2077
2078         Reviewed by Tim Horton.
2079
2080         * History/WebHistory.mm:
2081         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2082         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2083         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2084         * WebCoreSupport/WebUserMediaClient.mm:
2085         (WebUserMediaClient::pageDestroyed):
2086
2087 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2088
2089         Make the names of the options consistent
2090         https://bugs.webkit.org/show_bug.cgi?id=177933
2091
2092         Reviewed by Saam Barati.
2093
2094         * WebView/WebFrame.h:
2095         * WebView/WebHTMLView.mm:
2096         (-[WebHTMLView setMarkedText:selectedRange:]):
2097         * WebView/WebView.h:
2098
2099 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2100
2101         [iOS] Tweak support for classifying form controls (followup to r222487)
2102         https://bugs.webkit.org/show_bug.cgi?id=177917
2103         <rdar://problem/34820122>
2104
2105         Reviewed by Dean Jackson.
2106
2107         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2108
2109         * DOM/DOMHTMLInputElement.mm:
2110         (-[DOMHTMLInputElement _autofillContext]):
2111         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2112         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2113
2114 2017-10-05  Keith Miller  <keith_miller@apple.com>
2115
2116         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2117
2118         * Configurations/WebKitLegacy.xcconfig:
2119
2120 2017-10-05  Jer Noble  <jer.noble@apple.com>
2121
2122         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2123         https://bugs.webkit.org/show_bug.cgi?id=177261
2124
2125         Reviewed by Eric Carlson.
2126
2127         * Configurations/FeatureDefines.xcconfig:
2128
2129 2017-10-05  Chris Dumez  <cdumez@apple.com>
2130
2131         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2132         https://bugs.webkit.org/show_bug.cgi?id=177957
2133
2134         Reviewed by Alex Christensen.
2135
2136         * WebCoreSupport/WebPlatformStrategies.h:
2137         * WebCoreSupport/WebPlatformStrategies.mm:
2138         (WebPlatformStrategies::cookiesEnabled):
2139
2140 2017-10-05  Youenn Fablet  <youenn@apple.com>
2141
2142         Make LibWebRTCProvider port agnostic
2143         https://bugs.webkit.org/show_bug.cgi?id=177747
2144
2145         Reviewed by Alex Christensen & Alex Garcia.
2146
2147         * WebView/WebView.mm:
2148         (-[WebView _commonInitializationWithFrameName:groupName:]):
2149         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2150
2151 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2152
2153         Stop linking with WebKitSystemInterface
2154         https://bugs.webkit.org/show_bug.cgi?id=177915
2155
2156         Reviewed by Antti Koivisto.
2157
2158         * Configurations/DebugRelease.xcconfig:
2159         * Configurations/WebKitLegacy.xcconfig:
2160
2161 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2162
2163         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2164         https://bugs.webkit.org/show_bug.cgi?id=177912
2165
2166         Reviewed by Saam Barati.
2167
2168         * Carbon/CarbonUtils.m:
2169         * Carbon/CarbonWindowAdapter.mm:
2170         * Carbon/HIWebView.mm:
2171         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2172         * Misc/WebNSFileManagerExtras.mm:
2173         * Misc/WebNSPasteboardExtras.mm:
2174         * Misc/WebNSURLExtras.mm:
2175         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2176         * Plugins/Hosted/NetscapePluginHostManager.mm:
2177         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2178         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2179         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2180         * Plugins/Hosted/WebTextInputWindowController.m:
2181         * Plugins/WebBaseNetscapePluginView.mm:
2182         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2183         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2184         * Plugins/WebNetscapePluginStream.mm:
2185         * Plugins/WebNetscapePluginView.mm:
2186         * Plugins/WebPluginDatabase.mm:
2187         * WebCoreSupport/PopupMenuMac.mm:
2188         * WebCoreSupport/WebChromeClient.mm:
2189         * WebCoreSupport/WebFrameLoaderClient.mm:
2190         * WebCoreSupport/WebInspectorClient.mm:
2191         * WebCoreSupport/WebPlatformStrategies.mm:
2192         * WebCoreSupport/WebSystemInterface.mm:
2193         * WebView/WebDynamicScrollBarsView.mm:
2194         * WebView/WebFrame.mm:
2195         * WebView/WebFrameView.mm:
2196         * WebView/WebFullScreenController.mm:
2197         * WebView/WebHTMLView.mm:
2198         * WebView/WebPreferences.mm:
2199         * WebView/WebView.mm:
2200
2201 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2202
2203         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2204         rdar://problem/34705779
2205
2206         Addressing review comments that I somehow landed without.
2207
2208         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2209
2210 2017-09-29  Chris Dumez  <cdumez@apple.com>
2211
2212         Split some logic out of VisitedLinkStore and make it reusable
2213         https://bugs.webkit.org/show_bug.cgi?id=177575
2214
2215         Reviewed by Alex Christensen.
2216
2217         * WebCoreSupport/WebVisitedLinkStore.h:
2218         * WebCoreSupport/WebVisitedLinkStore.mm:
2219         (WebVisitedLinkStore::addVisitedLink):
2220         (WebVisitedLinkStore::removeVisitedLink):
2221         (WebVisitedLinkStore::isLinkVisited):
2222         (WebVisitedLinkStore::addVisitedLinkHash):
2223
2224 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2225
2226         Build fix for High Sierra 32 bit Mac
2227         https://bugs.webkit.org/show_bug.cgi?id=177551
2228         <rdar://problem/34690283>
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2233         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2234         also made.
2235
2236         * Carbon/CarbonWindowAdapter.mm:
2237         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2238         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2239         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2240         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2241         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2242         (-[CarbonWindowAdapter dealloc]):
2243         (-[CarbonWindowAdapter windowRef]):
2244         (-[CarbonWindowAdapter _hasWindowRef]):
2245         (-[CarbonWindowAdapter _managesWindowRef]):
2246         (-[CarbonWindowAdapter _removeWindowRef]):
2247         (-[CarbonWindowAdapter _carbonWindowClass]):
2248         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2249         (-[CarbonWindowAdapter sendSuperEvent:]):
2250         (-[CarbonWindowAdapter relinquishFocus]):
2251         (-[CarbonWindowAdapter _cancelKey:]):
2252         (-[CarbonWindowAdapter _commonAwake]):
2253         (-[CarbonWindowAdapter _destroyRealWindow:]):
2254         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2255         (-[CarbonWindowAdapter _termWindowIfOwner]):
2256         (-[CarbonWindowAdapter _windowMovedToRect:]):
2257         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2258         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2259         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2260         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2261         (-[CarbonWindowAdapter canBecomeMainWindow]):
2262         (-[CarbonWindowAdapter encodeWithCoder:]):
2263         (-[CarbonWindowAdapter initWithCoder:]):
2264         (-[CarbonWindowAdapter setContentView:]):
2265         (-[CarbonWindowAdapter worksWhenModal]):
2266         (-[CarbonWindowAdapter _setModalWindowLevel]):
2267         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2268         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2269         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2270         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2271         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2272         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2273         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2274         (NSCarbonWindowHandleEvent):
2275         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2276         (-[CarbonWindowAdapter _growBoxRect]):
2277         * Carbon/HIWebView.mm:
2278         (HIWebViewGetWebView):
2279         (HIWebViewConstructor):
2280         (HIWebViewDestructor):
2281         (HIWebViewRegisterClass):
2282         (GetBehaviors):
2283         (Draw):
2284         (HitTest):
2285         (GetRegion):
2286         (GetWindowRef):
2287         (CreateNSEventAdoptingCGEvent):
2288         (CopyEventCGEvent):
2289         (CreateNSEventWithCarbonClickEvent):
2290         (Click):
2291         (CreateNSEventWithCarbonEvent):
2292         (MouseUp):
2293         (CreateNSEventWithCarbonMouseMoveEvent):
2294         (MouseMoved):
2295         (MouseDragged):
2296         (MouseWheelMoved):
2297         (ContextMenuClick):
2298         (GetKind):
2299         (BoundsChanged):
2300         (OwningWindowChanged):
2301         (WindowHandler):
2302         (SyncFrame):
2303         (SetFocusPart):
2304         (AdvanceFocus):
2305         (RelinquishFocus):
2306         (ActiveStateChanged):
2307         (ProcessCommand):
2308         (UpdateCommandStatus):
2309         (_NSSelectorForHICommand):
2310         (HIWebViewEventHandler):
2311         (StartUpdateObserver):
2312         (StopUpdateObserver):
2313         (UpdateObserver):
2314
2315 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2316
2317         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2318         https://bugs.webkit.org/show_bug.cgi?id=172526
2319         <rdar://problem/32396081>
2320
2321         Reviewed by Ryosuke Niwa.
2322
2323         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2324
2325         * WebCoreSupport/WebPlatformStrategies.h:
2326         * WebCoreSupport/WebPlatformStrategies.mm:
2327         (WebPlatformStrategies::webExposedTypes):
2328         (WebPlatformStrategies::writeCustomData):
2329
2330 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2331
2332         Unreviewed, rolling out r222567.
2333
2334         This broke and internal build.
2335
2336         Reverted changeset:
2337
2338         "Build fix for High Sierra 32 bit Mac"
2339         https://bugs.webkit.org/show_bug.cgi?id=177551
2340         http://trac.webkit.org/changeset/222567
2341
2342 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2343
2344         Build fix for High Sierra 32 bit Mac
2345         https://bugs.webkit.org/show_bug.cgi?id=177551
2346         <rdar://problem/34690283>
2347
2348         Reviewed by Alexey Proskuryakov.
2349
2350         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2351         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2352         also made.
2353
2354         * Carbon/CarbonWindowAdapter.mm:
2355         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2356         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2357         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2358         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2359         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2360         (-[CarbonWindowAdapter dealloc]):
2361         (-[CarbonWindowAdapter windowRef]):
2362         (-[CarbonWindowAdapter _hasWindowRef]):
2363         (-[CarbonWindowAdapter _managesWindowRef]):
2364         (-[CarbonWindowAdapter _removeWindowRef]):
2365         (-[CarbonWindowAdapter _carbonWindowClass]):
2366         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2367         (-[CarbonWindowAdapter sendSuperEvent:]):
2368         (-[CarbonWindowAdapter relinquishFocus]):
2369         (-[CarbonWindowAdapter _cancelKey:]):
2370         (-[CarbonWindowAdapter _commonAwake]):
2371         (-[CarbonWindowAdapter _destroyRealWindow:]):
2372         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2373         (-[CarbonWindowAdapter _termWindowIfOwner]):
2374         (-[CarbonWindowAdapter _windowMovedToRect:]):
2375         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2376         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2377         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2378         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2379         (-[CarbonWindowAdapter canBecomeMainWindow]):
2380         (-[CarbonWindowAdapter encodeWithCoder:]):
2381         (-[CarbonWindowAdapter initWithCoder:]):
2382         (-[CarbonWindowAdapter setContentView:]):
2383         (-[CarbonWindowAdapter worksWhenModal]):
2384         (-[CarbonWindowAdapter _setModalWindowLevel]):
2385         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2386         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2387         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2388         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2389         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2390         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2391         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2392         (NSCarbonWindowHandleEvent):
2393         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2394         (-[CarbonWindowAdapter _growBoxRect]):
2395         * Carbon/HIWebView.mm:
2396         (HIWebViewGetWebView):
2397         (HIWebViewConstructor):
2398         (HIWebViewDestructor):
2399         (HIWebViewRegisterClass):
2400         (GetBehaviors):
2401         (Draw):
2402         (HitTest):
2403         (GetRegion):
2404         (GetWindowRef):
2405         (CreateNSEventAdoptingCGEvent):
2406         (CopyEventCGEvent):
2407         (CreateNSEventWithCarbonClickEvent):
2408         (Click):
2409         (CreateNSEventWithCarbonEvent):
2410         (MouseUp):
2411         (CreateNSEventWithCarbonMouseMoveEvent):
2412         (MouseMoved):
2413         (MouseDragged):
2414         (MouseWheelMoved):
2415         (ContextMenuClick):
2416         (GetKind):
2417         (BoundsChanged):
2418         (OwningWindowChanged):
2419         (WindowHandler):
2420         (SyncFrame):
2421         (SetFocusPart):
2422         (AdvanceFocus):
2423         (RelinquishFocus):
2424         (ActiveStateChanged):
2425         (ProcessCommand):
2426         (UpdateCommandStatus):
2427         (_NSSelectorForHICommand):
2428         (HIWebViewEventHandler):
2429         (StartUpdateObserver):
2430         (StopUpdateObserver):
2431         (UpdateObserver):
2432
2433 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2434
2435         Make PolicyAction an encodable enum class
2436         https://bugs.webkit.org/show_bug.cgi?id=177480
2437
2438         Reviewed by Antti Koivisto.
2439
2440         * Plugins/WebPluginContainerCheck.mm:
2441         (-[WebPluginContainerCheck _continueWithPolicy:]):
2442         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2443         * WebCoreSupport/WebFrameLoaderClient.mm:
2444         (-[WebFramePolicyListener invalidate]):
2445         (-[WebFramePolicyListener ignore]):
2446         (-[WebFramePolicyListener download]):
2447         (-[WebFramePolicyListener use]):
2448         (-[WebFramePolicyListener continue]):
2449         * WebView/WebPolicyDelegate.mm:
2450         (-[WebPolicyDecisionListener use]):
2451         (-[WebPolicyDecisionListener ignore]):
2452         (-[WebPolicyDecisionListener download]):
2453
2454 2017-09-25  Frederik Riedel  <riedel@apple.com>
2455
2456         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2457         https://bugs.webkit.org/show_bug.cgi?id=174394
2458         <rdar://problem/33183504>
2459
2460         Reviewed by Ryosuke Niwa.
2461
2462         * DOM/DOMHTMLInputElement.h:
2463         * DOM/DOMHTMLInputElement.mm:
2464         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2465         Determines if this HTMLInputElement is part of a login screen.
2466         (-[DOMHTMLInputElement representingPageUrl]):
2467         Returns the webpage's URL that is currently displayed in the Web View.
2468         (-[DOMHTMLInputElement insertTextSuggestion:]):
2469         Inserts login credentials into the Web View.
2470
2471 2017-09-25  Sam Weinig  <sam@webkit.org>
2472
2473         Remove unused EditorClient functions
2474         https://bugs.webkit.org/show_bug.cgi?id=177463
2475
2476         Reviewed by Alex Christensen.
2477
2478         Remove unused EditorClient functions.
2479
2480         * WebCoreSupport/WebEditorClient.h:
2481         * WebCoreSupport/WebEditorClient.mm:
2482         (WebEditorClient::canonicalizeURL): Deleted.
2483         (WebEditorClient::canonicalizeURLString): Deleted.
2484         (WebEditorClient::writeDataToPasteboard): Deleted.
2485         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2486         (WebEditorClient::readDataFromPasteboard): Deleted.
2487         (WebEditorClient::pasteboardChangeCount): Deleted.
2488
2489 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2490
2491         Stop using PolicyCallback
2492         https://bugs.webkit.org/show_bug.cgi?id=176088
2493
2494         Reviewed by Andy Estes.
2495
2496         * WebCoreSupport/WebFrameLoaderClient.mm:
2497         (-[WebFramePolicyListener invalidate]):
2498         (-[WebFramePolicyListener receivedPolicyDecision:]):
2499
2500 2017-09-25  Sam Weinig  <sam@webkit.org>
2501
2502         Remove unnecessary userVisibleString EditorClient function
2503         https://bugs.webkit.org/show_bug.cgi?id=177456
2504
2505         Reviewed by Dan Bernstein.
2506
2507         * WebCoreSupport/WebEditorClient.h:
2508         * WebCoreSupport/WebEditorClient.mm:
2509         (WebEditorClient::userVisibleString): Deleted.
2510
2511             Remove userVisibleString client function.
2512
2513 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2514
2515         Separate form submission from PolicyChecker infrastructure
2516         https://bugs.webkit.org/show_bug.cgi?id=177396
2517
2518         Reviewed by Geoffrey Garen.
2519
2520         * WebCoreSupport/WebFrameLoaderClient.h:
2521         * WebCoreSupport/WebFrameLoaderClient.mm:
2522         (WebFrameLoaderClient::dispatchWillSubmitForm):
2523
2524 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2525
2526         WeakPtrFactory should populate m_ref lazily.
2527         https://bugs.webkit.org/show_bug.cgi?id=177375
2528
2529         Reviewed by Geoffrey Garen.
2530
2531         * WebCoreSupport/WebEditorClient.mm:
2532         (WebEditorClient::WebEditorClient):
2533         (WebEditorClient::requestCandidatesForSelection):
2534
2535 2017-09-22  Chris Dumez  <cdumez@apple.com>
2536
2537         Use high resolution timestamp for event time
2538         https://bugs.webkit.org/show_bug.cgi?id=154246
2539         <rdar://problem/34333304>
2540
2541         Reviewed by Ryosuke Niwa.
2542
2543         Use WallTime / MonotonicTime instead of double type for clarity.
2544
2545         * DOM/DOMEvent.mm:
2546         (-[DOMEvent timeStamp]):
2547         * WebView/WebFrame.mm:
2548         (-[WebFrame _dragSourceEndedAt:operation:]):
2549         * WebView/WebPDFView.mm:
2550         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2551
2552 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2553
2554         Enable dataTransfer.items on macOS and iOS
2555         https://bugs.webkit.org/show_bug.cgi?id=177335
2556
2557         Reviewed by Sam Weinig.
2558
2559         * WebView/WebPreferences.mm:
2560         (+[WebPreferences initialize]):
2561
2562 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2563
2564         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2565         https://bugs.webkit.org/show_bug.cgi?id=177101
2566         <rdar://problem/34500648>
2567
2568         Reviewed by Brian Burg.
2569
2570         * WebInspector/WebNodeHighlight.mm:
2571         Ensure we close the window that we have just removed.
2572
2573 2017-09-20  Antti Koivisto  <antti@apple.com>
2574
2575         Remove DOM and styling support for CSS Regions
2576         https://bugs.webkit.org/show_bug.cgi?id=177221
2577
2578         Reviewed by Andreas Kling.
2579
2580         * Configurations/FeatureDefines.xcconfig:
2581         * DOM/DOMCSS.mm:
2582         (kitClass):
2583         * DOM/DOMElement.mm:
2584         (-[DOMElement webkitRegionOverset]): Deleted.
2585
2586 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2587
2588         Layering violation in Editor::createFragment
2589         https://bugs.webkit.org/show_bug.cgi?id=176123
2590
2591         Reviewed by Darin Adler.
2592
2593         * Misc/WebNSURLExtras.h:
2594         * Misc/WebNSURLExtras.mm:
2595         * WebView/WebFrame.mm:
2596         * WebView/WebHTMLView.mm:
2597         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2598
2599         * WebCoreSupport/WebEditorClient.mm:
2600         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2601         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2602         way to avoid exporting the symbol just on newer OSes.
2603
2604 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2605
2606         On iOS, getData can't get text set by setData during copy event
2607         https://bugs.webkit.org/show_bug.cgi?id=176980
2608         <rdar://problem/34453915>
2609
2610         Reviewed by Darin Adler.
2611
2612         * WebCoreSupport/WebPlatformStrategies.h:
2613         * WebCoreSupport/WebPlatformStrategies.mm:
2614         (WebPlatformStrategies::copy): Deleted.
2615
2616 2017-09-18  Andy Estes  <aestes@apple.com>
2617
2618         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2619         https://bugs.webkit.org/show_bug.cgi?id=177029
2620
2621         Reviewed by Alex Christensen.
2622
2623         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2624         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2625         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2626         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2627         * WebCoreSupport/PopupMenuMac.mm:
2628         (PopupMenuMac::show):
2629         * WebCoreSupport/WebSystemInterface.mm:
2630         (InitWebCoreSystemInterface):
2631         * WebView/WebHTMLView.mm:
2632         (-[WebHTMLView setDataSource:]):
2633         (-[WebHTMLView attachRootLayer:]):
2634         * WebView/WebView.mm:
2635         (-[WebView _needsAdobeFrameReloadingQuirk]):
2636         (-[WebView _needsLinkElementTextCSSQuirk]):
2637         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2638         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2639         (-[WebView _preferencesChanged:]):
2640
2641 2017-09-15  Andy Estes  <aestes@apple.com>
2642
2643         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2644         https://bugs.webkit.org/show_bug.cgi?id=176953
2645
2646         Reviewed by Eric Carlson.
2647
2648         * WebCoreSupport/WebSystemInterface.mm:
2649         (InitWebCoreSystemInterface):
2650
2651 2017-09-14  Andy Estes  <aestes@apple.com>
2652
2653         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2654         https://bugs.webkit.org/show_bug.cgi?id=176931
2655
2656         Reviewed by Joseph Pecoraro.
2657
2658         * WebCoreSupport/WebSystemInterface.mm:
2659         (InitWebCoreSystemInterface):
2660
2661 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2662
2663         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2664         https://bugs.webkit.org/show_bug.cgi?id=176867
2665
2666         Reviewed by Sam Weinig.
2667
2668         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2669         (WebKit::NetscapePluginInstanceProxy::enumerate):
2670
2671 2017-09-13  Andy Estes  <aestes@apple.com>
2672
2673         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2674         https://bugs.webkit.org/show_bug.cgi?id=176729
2675
2676         Reviewed by Alex Christensen.
2677
2678         * WebCoreSupport/WebSystemInterface.mm:
2679         (InitWebCoreSystemInterface):
2680         * WebView/WebView.mm:
2681         (+[WebView _setCacheModel:]):
2682
2683 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2684
2685         Refactor WebContentReader out of EditorMac and EditorIOS
2686         https://bugs.webkit.org/show_bug.cgi?id=176770
2687
2688         Reviewed by Sam Weinig.
2689
2690         * WebCoreSupport/WebEditorClient.mm:
2691
2692 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         Dragging & dropping a file creates an attachment element even when it's disabled
2695         https://bugs.webkit.org/show_bug.cgi?id=176769
2696
2697         Reviewed by Tim Horton.
2698
2699         * WebView/WebView.mm:
2700         (-[WebView _preferencesChanged:]):
2701
2702 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2703
2704         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2705         https://bugs.webkit.org/show_bug.cgi?id=176721
2706         <rdar://problem/34373660>
2707
2708         Reviewed by Tim Horton.
2709
2710         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2711         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2712
2713         * WebView/WebView.mm:
2714         (-[WebView _startDrag:]):
2715         (-[WebView _draggedElementBounds]):
2716         (-[WebView _endedDataInteraction:global:]):
2717         * WebView/WebViewData.h:
2718
2719 2017-09-11  Andy Estes  <aestes@apple.com>
2720
2721         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2722         https://bugs.webkit.org/show_bug.cgi?id=176472
2723
2724         Reviewed by Eric Carlson.
2725
2726         * WebCoreSupport/WebSystemInterface.mm:
2727         (InitWebCoreSystemInterface):
2728
2729 2017-09-09  Mark Lam  <mark.lam@apple.com>
2730
2731         Avoid duplicate computations of ExecState::vm().
2732         https://bugs.webkit.org/show_bug.cgi?id=176647
2733
2734         Reviewed by Saam Barati.
2735
2736         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2737         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2738         (WebKit::NetscapePluginInstanceProxy::construct):
2739         (WebKit::NetscapePluginInstanceProxy::setProperty):
2740         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2741         (WebKit::NetscapePluginInstanceProxy::enumerate):
2742         * Plugins/Hosted/ProxyInstance.mm:
2743         (WebKit::ProxyRuntimeMethod::create):
2744
2745 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2746
2747         Unreviewed, rolling out r221773.
2748         https://bugs.webkit.org/show_bug.cgi?id=176614
2749
2750         This caused build failures. (Requested by mlewis13 on
2751         #webkit).
2752
2753         Reverted changeset:
2754
2755         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2756         https://bugs.webkit.org/show_bug.cgi?id=176472
2757         http://trac.webkit.org/changeset/221773
2758
2759 2017-09-07  Andy Estes  <aestes@apple.com>
2760
2761         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2762         https://bugs.webkit.org/show_bug.cgi?id=176472
2763
2764         Reviewed by Eric Carlson.
2765
2766         * WebCoreSupport/WebSystemInterface.mm:
2767         (InitWebCoreSystemInterface):
2768
2769 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2770
2771         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2772         https://bugs.webkit.org/show_bug.cgi?id=176561
2773
2774         Reviewed by Brent Fulgham.
2775
2776         * Misc/WebNSUserDefaultsExtras.mm:
2777
2778 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2779
2780         Modernize Geolocation code
2781         https://bugs.webkit.org/show_bug.cgi?id=176496
2782
2783         Reviewed by Andy Estes.
2784
2785         * WebCoreSupport/WebGeolocationClient.h:
2786         * WebCoreSupport/WebGeolocationClient.mm:
2787         (WebGeolocationClient::requestPermission):
2788         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2789         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2790         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2791         * WebView/WebView.mm:
2792         (-[WebView _commonInitializationWithFrameName:groupName:]):
2793         (-[WebView _geolocationDidFailWithMessage:]):
2794
2795 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2796
2797         Remove some unused bits of code and resources
2798         https://bugs.webkit.org/show_bug.cgi?id=176275
2799
2800         Reviewed by Dan Bernstein.
2801
2802         * Misc/WebNSFileManagerExtras.mm:
2803         Include FileSystem instead of FileSystemIOS.
2804
2805 2017-09-03  Darin Adler  <darin@apple.com>
2806
2807         [Cocoa] Tidy a few things in legacy WebHTMLView
2808         https://bugs.webkit.org/show_bug.cgi?id=176280
2809
2810         Reviewed by Dan Bernstein.
2811
2812         * WebCoreSupport/WebChromeClient.mm:
2813         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2814         methods it calls on WebHTMLView were doing nothing on iOS.
2815
2816         * WebView/WebFrame.mm:
2817         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2818         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2819
2820         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2821         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2822         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2823         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2824         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2825         Use RetainPtr instead of writing retain/release wherever possible.
2826         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2827         initialization for it. Removed various unused methods and declarations of methods.
2828         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2829         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2830         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2831         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2832         and remove CFRetain no longer needed since we don't support garbage collection any more.
2833         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2834         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2835         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2836         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2837         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2838         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2839         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2840         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2841         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2842         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2843         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2844         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2845         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2846         debug flag; we haven't used it for years and it's not clearly helpful.
2847         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2848         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2849         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2850         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2851         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2852         two additional methods in the WebPrivate category and still be called by the two
2853         methods in the WebInternal category that were already using it.
2854         (-[WebHTMLView didAddSubview:]): Deleted.
2855         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2856         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2857         place this was called, the close method.
2858         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2859         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2860         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2861         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2862         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2863         Added helper method to make the one below simpler.
2864         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2865         Compared pasteboard type strings using isEqualToString: rather than using == since
2866         we want to actually compare the string contents. Also updated to use modern for loop,
2867         renamed a local variable from "s" to "localSubresources", and factored out the handling
2868         of three image types to use the helper method above.
2869         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2870         _web_makePluginSubviewsPerformSelector:withObject: method.
2871         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2872         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2873         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2874         not call the -[NSView subviews] method to make this identical on both platforms and used
2875         a modern for loop.
2876         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2877         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2878         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2879         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2880         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2881         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2882         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2883         of it is Mac-only.
2884         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2885         method did was call itself on the main thread, and do nothing if called on main thread.
2886         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2887         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2888         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2889         half of this method.
2890         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2891         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2892         Simplified using a modern for loop and RetainPtr.
2893         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2894         (-[WebHTMLView keyDown:]): Ditto.
2895         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2896         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2897         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2898         (-[WebHTMLView complete:]): Ditto.
2899         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2900         now macOS-only.
2901         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2902         iOS since that is now macOS-only.
2903         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2904         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2905         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2906         and reorganized to use early return.
2907         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2908         on iOS, but kept there so we don't have to do #if at every call site.
2909         (-[WebHTMLView _pluginController]): Moved into internal category.
2910         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2911         there only for GC, using C++ initialization, removing obsolete comment.
2912         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2913         peculiar iOS-only comment.
2914         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2915
2916         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2917         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2918         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2919         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2920         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2921
2922         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2923         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2924         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2925         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2926         them at this time.
2927
2928 2017-09-03  Sam Weinig  <sam@webkit.org>
2929
2930         Remove CanvasProxy
2931         https://bugs.webkit.org/show_bug.cgi?id=176288
2932
2933         Reviewed by Yusuke Suzuki.
2934
2935         CanvasProxy does not appear to be in any current HTML spec
2936         and was disabled and unimplemented in our tree. Time to 
2937         get rid of it.
2938
2939         * Configurations/FeatureDefines.xcconfig:
2940
2941 2017-09-02  Andy Estes  <aestes@apple.com>
2942
2943         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2944         https://bugs.webkit.org/show_bug.cgi?id=176270
2945
2946         Reviewed by Tim Horton.
2947
2948         * Plugins/Hosted/NetscapePluginHostManager.mm:
2949         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2950         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2951         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2952         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2953         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2954         (WebKit::SoftwareCARenderer::context const):
2955         (WebKit::SoftwareCARenderer::renderContext const):
2956         (WebKit::SoftwareCARenderer::render):
2957         (-[WebHostedNetscapePluginView createPlugin]):
2958         (-[WebHostedNetscapePluginView createPluginLayer]):
2959         (-[WebHostedNetscapePluginView destroyPlugin]):
2960         (-[WebHostedNetscapePluginView drawRect:]):
2961         * WebCoreSupport/WebSystemInterface.mm:
2962         (InitWebCoreSystemInterface):
2963
2964 2017-09-01  Andy Estes  <aestes@apple.com>
2965
2966         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2967         https://bugs.webkit.org/show_bug.cgi?id=176200
2968
2969         Reviewed by Tim Horton.
2970
2971         * Carbon/HIWebView.mm:
2972         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2973         (overrideCGContext):
2974         (restoreCGContext):
2975         (Draw):
2976         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2977         (+[WebHostedNetscapePluginView initialize]):
2978         * Plugins/WebBaseNetscapePluginView.h:
2979         * Plugins/WebBaseNetscapePluginView.mm:
2980         (WebKit::sendUserChangeNotifications):
2981         * Plugins/WebNetscapePluginView.mm:
2982         (+[WebNetscapePluginView initialize]):
2983         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2984         * WebCoreSupport/WebSystemInterface.mm:
2985         (InitWebCoreSystemInterface):
2986         * WebView/WebFrame.mm:
2987         (-[WebFrame _paintBehaviorForDestinationContext:]):
2988         * WebView/WebFullScreenController.mm:
2989         (setClipRectForWindow):
2990         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2991         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2992         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2993         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2994
2995 2017-08-31  Andy Estes  <aestes@apple.com>
2996
2997         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2998         https://bugs.webkit.org/show_bug.cgi?id=176175
2999
3000         Reviewed by Brady Eidson.
3001
3002         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3003         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3004         * Plugins/Hosted/WebTextInputWindowController.m:
3005         (-[WebTextInputPanel init]):
3006         * WebCoreSupport/WebSystemInterface.mm:
3007         (InitWebCoreSystemInterface):
3008         * WebView/WebDynamicScrollBarsView.mm:
3009         (-[WebDynamicScrollBarsView scrollWheel:]):
3010         * WebView/WebHTMLView.mm:
3011         (-[WebHTMLView _removeWindowObservers]):
3012         (-[WebHTMLView addWindowObservers]):
3013         * WebView/WebView.mm:
3014         (-[WebView addWindowObserversForWindow:]):
3015         (-[WebView removeWindowObservers]):
3016         (-[WebView viewWillMoveToWindow:]):
3017
3018 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3019
3020         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3021         https://bugs.webkit.org/show_bug.cgi?id=175779
3022         <rdar://problem/22367975>
3023
3024         Reviewed by Tim Horton.
3025
3026         * WebCoreSupport/WebFrameLoaderClient.h:
3027         * WebCoreSupport/WebFrameLoaderClient.mm:
3028         (WebFrameLoaderClient::webGLPolicyForURL const):
3029         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3030
3031 2017-08-30  Andy Estes  <aestes@apple.com>
3032
3033         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3034         https://bugs.webkit.org/show_bug.cgi?id=176093
3035
3036         Reviewed by Eric Carlson.
3037
3038         * WebCoreSupport/WebSystemInterface.mm:
3039         (InitWebCoreSystemInterface):
3040
3041 2017-08-30  Andy Estes  <aestes@apple.com>
3042
3043         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3044         https://bugs.webkit.org/show_bug.cgi?id=176087
3045
3046         Reviewed by Alex Christensen.
3047
3048         * Carbon/CarbonUtils.m:
3049         (getNSAutoreleasePoolCount):
3050         (WebInitForCarbon):
3051         (PoolCleaner):
3052         * Carbon/CarbonWindowAdapter.mm:
3053         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3054         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3055         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3056         (-[CarbonWindowAdapter _windowMovedToRect:]):
3057         * Carbon/HIViewAdapter.m:
3058         * Carbon/HIWebView.mm:
3059         (Draw):
3060         (CreateNSEventAdoptingCGEvent):
3061         (CopyEventCGEvent):
3062         (CreateNSEventWithCarbonClickEvent):
3063         (Click):
3064         (CreateNSEventWithCarbonEvent):
3065         (MouseUp):
3066         (CreateNSEventWithCarbonMouseMoveEvent):
3067         (MouseMoved):
3068         (MouseDragged):
3069         (MouseWheelMoved):
3070         (WindowHandler):
3071         (HIWebViewEventHandler):
3072         * Misc/QuickDrawCompatibility.h: Removed.
3073         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3074         (getCarbonEvent):
3075         (WebNetscapePluginEventHandlerCarbon::keyDown):
3076         (WebNetscapePluginEventHandlerCarbon::keyUp):
3077         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3078         (WebNetscapePluginEventHandlerCocoa::keyDown):
3079         * Plugins/WebNetscapePluginView.mm:
3080         (-[WebNetscapePluginView tellQuickTimeToChill]):
3081
3082 2017-08-29  Andy Estes  <aestes@apple.com>
3083
3084         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3085         https://bugs.webkit.org/show_bug.cgi?id=176046
3086
3087         Reviewed by Alex Christensen.
3088
3089         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3090         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3091
3092         * Misc/WebNSFileManagerExtras.mm:
3093         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3094         (setMetaData): Deleted.
3095         * WebCoreSupport/WebSystemInterface.mm:
3096         (InitWebCoreSystemInterface):
3097
3098 2017-08-28  Andy Estes  <aestes@apple.com>
3099
3100         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3101         https://bugs.webkit.org/show_bug.cgi?id=176039
3102
3103         Reviewed by Alex Christensen.
3104
3105         * WebCoreSupport/WebSystemInterface.mm:
3106         (InitWebCoreSystemInterface):
3107         * WebView/WebPreferences.mm:
3108         (+[WebPreferences _systemCFStringEncoding]):
3109
3110 2017-08-28  Andy Estes  <aestes@apple.com>
3111
3112         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3113         https://bugs.webkit.org/show_bug.cgi?id=176032
3114
3115         Reviewed by Alex Christensen.
3116
3117         * WebCoreSupport/WebSystemInterface.mm:
3118         (InitWebCoreSystemInterface):
3119         * WebView/WebView.mm:
3120         (-[WebView _cachedResponseForURL:]):
3121
3122 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3123
3124         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3125         https://bugs.webkit.org/show_bug.cgi?id=175992
3126         <rdar://problem/34086613>
3127
3128         Reviewed by Daniel Bates.
3129
3130         * WebCoreSupport/WebPlatformStrategies.h:
3131         * WebCoreSupport/WebPlatformStrategies.mm:
3132         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3133         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3134         indicating if secure cookies were accessed.
3135
3136 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3137
3138         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3139         https://bugs.webkit.org/show_bug.cgi?id=170955
3140         <rdar://problem/31697653>
3141
3142         Reviewed by Ryosuke Niwa.
3143
3144         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3145         text is being replaced.
3146
3147         * WebView/WebHTMLView.mm:
3148         (-[WebHTMLView insertText:]):
3149
3150 2017-08-24  Chris Dumez  <cdumez@apple.com>
3151
3152         [Directory Upload] Add basic support for input.webkitdirectory
3153         https://bugs.webkit.org/show_bug.cgi?id=175950
3154         <rdar://problem/33951915>
3155
3156         Reviewed by Geoffrey Garen.
3157
3158         Add private API to toggle Directory Upload support on Mac WebKit1.
3159
3160         * WebView/WebPreferenceKeysPrivate.h:
3161         * WebView/WebPreferences.mm:
3162         (+[WebPreferences initialize]):
3163         (-[WebPreferences setDirectoryUploadEnabled:]):
3164         (-[WebPreferences directoryUploadEnabled]):
3165         * WebView/WebPreferencesPrivate.h:
3166         * WebView/WebView.mm:
3167         (-[WebView _preferencesChanged:]):
3168
3169 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3170
3171         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3172         https://bugs.webkit.org/show_bug.cgi?id=175370
3173         <rdar://problem/33799806>
3174
3175         Reviewed by Ryosuke Niwa.
3176
3177         Adjust WebEditorClient for interface changes.
3178
3179         * WebCoreSupport/WebEditorClient.h:
3180
3181 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3182
3183         Remove ChromeClient::scrollbarsModeDidChange
3184         https://bugs.webkit.org/show_bug.cgi?id=175805
3185
3186         Reviewed by Daniel Bates.
3187
3188         * WebCoreSupport/WebChromeClient.h:
3189
3190 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3191
3192         Remove ChromeClient::hasOpenedPopup
3193         https://bugs.webkit.org/show_bug.cgi?id=175804
3194
3195         Reviewed by Sam Weinig.
3196
3197         * WebCoreSupport/WebChromeClient.h:
3198         * WebCoreSupport/WebChromeClient.mm:
3199         (WebChromeClient::hasOpenedPopup const): Deleted.
3200
3201 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3202
3203         Disable access to secure cookies if an HTTPS site loads mixed content
3204         https://bugs.webkit.org/show_bug.cgi?id=157053
3205         <rdar://problem/11290808>
3206
3207         Reviewed by Dan Bates.
3208
3209         * WebCoreSupport/WebPlatformStrategies.h:
3210         * WebCoreSupport/WebPlatformStrategies.mm:
3211         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3212         indicating whether secure cookies should be included in the response.
3213
3214 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3215
3216         [PAL] Move spi/mac directory into PAL
3217         https://bugs.webkit.org/show_bug.cgi?id=175649
3218
3219         Reviewed by Myles C. Maxfield.
3220
3221         * Misc/WebSharingServicePickerController.h:
3222         * WebCoreSupport/WebContextMenuClient.mm:
3223         * WebCoreSupport/WebEditorClient.mm:
3224         * WebCoreSupport/WebSelectionServiceController.mm:
3225         * WebView/WebHTMLView.mm:
3226         * WebView/WebImmediateActionController.h:
3227         * WebView/WebImmediateActionController.mm:
3228         * WebView/WebView.mm:
3229
3230 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3231
3232         [PAL] Relocate SessionID to root
3233         https://bugs.webkit.org/show_bug.cgi?id=175684
3234
3235         Reviewed by Alex Christensen.
3236
3237         * WebCoreSupport/WebFrameNetworkingContext.mm:
3238
3239 2017-08-17  Andreas Kling  <akling@apple.com>
3240
3241         Disable CSS regions at compile time
3242         https://bugs.webkit.org/show_bug.cgi?id=175630
3243
3244         Reviewed by Antti Koivisto.
3245
3246         * Configurations/FeatureDefines.xcconfig:
3247
3248 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3249
3250         [PAL] Move SessionID into PAL
3251         https://bugs.webkit.org/show_bug.cgi?id=174192
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * Misc/WebCache.mm:
3256         (+[WebCache imageForURL:]):
3257         * WebCoreSupport/WebFrameLoaderClient.h:
3258         * WebCoreSupport/WebFrameLoaderClient.mm:
3259         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3260         * WebCoreSupport/WebFrameNetworkingContext.mm:
3261         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3262         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3263         (WebFrameNetworkingContext::storageSession const):
3264         * WebCoreSupport/WebPlatformStrategies.h:
3265         * WebCoreSupport/WebPlatformStrategies.mm:
3266         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3267         * WebKitPrefix.h:
3268
3269 2017-08-16  Andy Estes  <aestes@apple.com>
3270
3271         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3272         https://bugs.webkit.org/show_bug.cgi?id=175648
3273
3274         Reviewed by Tim Horton.
3275
3276         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3277         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3278         (WebPaymentCoordinatorClient::showPaymentUI):
3279
3280 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3281
3282         [PAL] Move spi/ios and spi/win directories into PAL
3283         https://bugs.webkit.org/show_bug.cgi?id=175171
3284
3285         Reviewed by Antti Koivisto.
3286
3287         * WebCoreSupport/WebFrameLoaderClient.mm:
3288         * WebView/WebView.mm:
3289
3290 2017-08-16  Andy Estes  <aestes@apple.com>
3291
3292         [Payment Request] Add an ENABLE flag and an experimental feature preference
3293         https://bugs.webkit.org/show_bug.cgi?id=175622
3294
3295         Reviewed by Tim Horton.
3296
3297         * Configurations/FeatureDefines.xcconfig:
3298
3299 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3300
3301         [PAL] Move Sleep classes into PAL
3302         https://bugs.webkit.org/show_bug.cgi?id=175456
3303
3304         Reviewed by Ryosuke Niwa.
3305
3306         * WebView/WebFullScreenController.h:
3307
3308 2017-08-15  Youenn Fablet  <youenn@apple.com>
3309
3310         [Cache API] Adding generic support for CacheStorage and Cache methods
3311         https://bugs.webkit.org/show_bug.cgi?id=175455
3312
3313         Reviewed by Chris Dumez.
3314
3315         * WebView/WebView.mm:
3316         (-[WebView _commonInitializationWithFrameName:groupName:]):
3317
3318 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3319
3320         Remove Proximity Events and related code
3321         https://bugs.webkit.org/show_bug.cgi?id=175545
3322
3323         Reviewed by Daniel Bates.
3324
3325         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3326         and other related code.
3327
3328         * Configurations/FeatureDefines.xcconfig:
3329
3330 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3331
3332         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3333         https://bugs.webkit.org/show_bug.cgi?id=175504
3334
3335         Reviewed by Sam Weinig.
3336
3337         * Configurations/FeatureDefines.xcconfig:
3338         * DOM/DOMHTMLFormElement.mm:
3339         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3340         * WebCoreSupport/WebFrameLoaderClient.h:
3341
3342 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3343
3344         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3345         https://bugs.webkit.org/show_bug.cgi?id=175557
3346
3347         Reviewed by Jon Lee.
3348
3349         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3350
3351         * Configurations/FeatureDefines.xcconfig:
3352
3353 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3354
3355         Composition underline color is always black
3356         https://bugs.webkit.org/show_bug.cgi?id=174675
3357
3358         Reviewed by Ryosuke Niwa.
3359
3360         * WebView/WebHTMLView.mm:
3361         (extractUnderlines): If NSUnderlineColorAttributeName
3362         is not present use text color for composition underline.
3363         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3364         for composition underline in the plain text case.
3365
3366 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3367
3368         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3369         https://bugs.webkit.org/show_bug.cgi?id=175474
3370         <rdar://problem/33844628>
3371
3372         Reviewed by Wenson Hsieh.
3373
3374         Replaced the build flag by a runtime flag and disabled the feature by default.
3375
3376         * Configurations/FeatureDefines.xcconfig:
3377         * WebView/WebPreferenceKeysPrivate.h:
3378         * WebView/WebPreferences.mm:
3379         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3380         (-[WebPreferences dataTransferItemsEnabled]): Added.
3381         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3382         * WebView/WebPreferencesPrivate.h:
3383         * WebView/WebView.mm:
3384         (-[WebView _preferencesChanged:]):
3385
3386 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3387
3388         Remove ENABLE_GAMEPAD_DEPRECATED
3389         https://bugs.webkit.org/show_bug.cgi?id=175361
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         * Configurations/FeatureDefines.xcconfig:
3394
3395 2017-08-09  Chris Dumez  <cdumez@apple.com>
3396
3397         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3398         https://bugs.webkit.org/show_bug.cgi?id=175401
3399
3400         Reviewed by Brady Eidson.
3401
3402         * WebView/WebPreferenceKeysPrivate.h:
3403         * WebView/WebPreferences.mm:
3404         (+[WebPreferences initialize]):
3405         (-[WebPreferences beaconAPIEnabled]): Deleted.
3406         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3407         * WebView/WebPreferencesPrivate.h:
3408         * WebView/WebView.mm:
3409         (-[WebView _preferencesChanged:]):
3410
3411 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3412
3413         [PAL] Move spi/cocoa and spi/cg directories into PAL
3414         https://bugs.webkit.org/show_bug.cgi?id=175175
3415
3416         Reviewed by Myles C. Maxfield.
3417
3418         * History/WebHistory.mm:
3419         * Misc/WebDownload.mm:
3420         * Misc/WebKitNSStringExtras.mm:
3421         * Plugins/Hosted/NetscapePluginHostManager.mm:
3422         * Plugins/WebPluginDatabase.mm:
3423         * WebCoreSupport/WebFrameLoaderClient.mm:
3424         * WebInspector/WebNodeHighlight.mm:
3425         * WebView/WebHTMLView.mm:
3426         * WebView/WebIndicateLayer.mm:
3427         * WebView/WebView.mm:
3428         * WebView/WebViewData.h:
3429
3430 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3433         https://bugs.webkit.org/show_bug.cgi?id=175392
3434         <rdar://problem/33783207>
3435
3436         Reviewed by Tim Horton and Megan Gardner.
3437
3438         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3439
3440         * Configurations/FeatureDefines.xcconfig:
3441
3442 2017-08-09  Daniel Bates  <dabates@apple.com>
3443
3444         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3445         https://bugs.webkit.org/show_bug.cgi?id=175247
3446         <rdar://problem/33679804>
3447
3448         Reviewed by Brady Eidson.
3449
3450         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3451         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3452         clients that need to make use of this information at this time. If such a needs comes up
3453         then we can expose API/SPI similar to what we do for WebKit.
3454
3455         * WebCoreSupport/WebFrameLoaderClient.h:
3456         * WebCoreSupport/WebFrameLoaderClient.mm:
3457         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3458
3459 2017-08-08  Brady Eidson  <beidson@apple.com>
3460
3461         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3462         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3463
3464         Reviewed by Andy Estes.
3465
3466         * Misc/WebKitVersionChecks.h:
3467         * WebCoreSupport/WebFrameLoaderClient.mm:
3468         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3469           the app is linked against new WebKit with the new behavior.
3470
3471 2017-08-07  Devin Rousso  <drousso@apple.com>
3472
3473         Web Inspector: Preview Canvas path when viewing a recording
3474         https://bugs.webkit.org/show_bug.cgi?id=174967
3475
3476         Reviewed by Brian Burg.
3477
3478         * WebView/WebPreferenceKeysPrivate.h:
3479         * WebView/WebPreferences.mm:
3480         (+[WebPreferences initialize]):
3481         (-[WebPreferences inspectorAdditionsEnabled]):
3482         (-[WebPreferences setInspectorAdditionsEnabled:]):
3483         * WebView/WebPreferencesPrivate.h:
3484         * WebView/WebView.mm:
3485         (-[WebView _preferencesChanged:]):
3486         Add plumbing for new InspectorAdditions runtime flag.
3487
3488 2017