Stop including <AudioToolbox/AudioSession.h>
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
2
3         Stop including <AudioToolbox/AudioSession.h>
4         https://bugs.webkit.org/show_bug.cgi?id=196648
5         <rdar://problem/39665771>
6
7         Reviewed by Jer Noble.
8
9         * WebView/WebPreferencesPrivate.h:
10
11 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
12
13         Have ScrollableArea store a ScrollType for the current scroll
14         https://bugs.webkit.org/show_bug.cgi?id=196627
15
16         Reviewed by Zalan Bujtas.
17
18         Send the programmatic scroll type.
19
20         * DOM/DOMHTML.mm:
21         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
22
23 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
24
25         -apple-trailing-word is needed for browser detection
26         https://bugs.webkit.org/show_bug.cgi?id=196575
27
28         Unreviewed.
29
30         * Configurations/FeatureDefines.xcconfig:
31
32 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
33
34         Remove support for -apple-trailing-word
35         https://bugs.webkit.org/show_bug.cgi?id=196525
36
37         Reviewed by Zalan Bujtas.
38
39         This CSS property is nonstandard and not used.
40
41         * Configurations/FeatureDefines.xcconfig:
42
43 2019-04-01  Alex Christensen  <achristensen@webkit.org>
44
45         Add SPI to canonicalize NSURLs with WTF::URL
46         https://bugs.webkit.org/show_bug.cgi?id=196415
47         <rdar://problem/44980271>
48
49         Reviewed by Darin Adler.
50
51         * Misc/WebNSURLExtras.h:
52         * Misc/WebNSURLExtras.mm:
53         (-[NSURL _webkit_canonicalize_with_wtf]):
54         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
55         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
56
57 2019-03-31  Sam Weinig  <weinig@apple.com>
58
59         Remove more i386 specific configurations
60         https://bugs.webkit.org/show_bug.cgi?id=196430
61
62         Reviewed by Alexey Proskuryakov.
63
64         * Configurations/FeatureDefines.xcconfig:
65         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
66
67 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
68
69         Delete WebMetal implementation in favor of WebGPU
70         https://bugs.webkit.org/show_bug.cgi?id=195418
71
72         Reviewed by Dean Jackson.
73
74         * Configurations/FeatureDefines.xcconfig:
75         * WebView/WebPreferenceKeysPrivate.h:
76         * WebView/WebPreferences.mm:
77         (+[WebPreferences initialize]):
78         (-[WebPreferences webMetalEnabled]): Deleted.
79         (-[WebPreferences setWebMetalEnabled:]): Deleted.
80         * WebView/WebPreferencesPrivate.h:
81         * WebView/WebView.mm:
82         (-[WebView _preferencesChanged:]):
83
84 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
85
86         Implement ResizeObserver.
87         https://bugs.webkit.org/show_bug.cgi?id=157743
88
89         Reviewed by Simon Fraser.
90
91         * Configurations/FeatureDefines.xcconfig:
92         * WebView/WebPreferenceKeysPrivate.h:
93         * WebView/WebPreferences.mm:
94         (+[WebPreferences initialize]):
95         (-[WebPreferences resizeObserverEnabled]):
96         (-[WebPreferences setResizeObserverEnabled:]):
97         * WebView/WebPreferencesPrivate.h:
98         * WebView/WebView.mm:
99         (-[WebView _preferencesChanged:]):
100         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
101
102 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
103
104         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
105         https://bugs.webkit.org/show_bug.cgi?id=196336
106
107         Reviewed by Tim Horton.
108
109         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
110
111         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
112
113         * WebCoreSupport/PopupMenuMac.mm:
114         (PopupMenuMac::hide):
115
116 2019-03-25  Andy Estes  <aestes@apple.com>
117
118         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
119         https://bugs.webkit.org/show_bug.cgi?id=194964
120         <rdar://problem/48279441>
121
122         Reviewed by Alex Christensen.
123
124         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
125         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
126         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
127         PreviewLoaderClient alive for its lifetime. This ensures that as long as
128         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
129         by WebKit.
130
131         * WebCoreSupport/WebFrameLoaderClient.mm:
132         (WebFrameLoaderClient::createPreviewLoaderClient):
133         * WebView/WebDataSource.mm:
134         (-[WebDataSource _quickLookPreviewLoaderClient]):
135         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
136         * WebView/WebDataSourceInternal.h:
137
138 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
139
140         Remove NavigatorContentUtils in WebCore/Modules
141         https://bugs.webkit.org/show_bug.cgi?id=196070
142
143         Reviewed by Alex Christensen.
144
145         NavigatorContentUtils was to support the custom scheme spec [1].
146         However, in WebKit side, no port has supported the feature in
147         WebKit layer after EFL port was removed. So there has been the
148         only IDL implementation of the NavigatorContentUtils in WebCore.
149         So we don't need to keep the implementation in WebKit.
150
151         * Configurations/FeatureDefines.xcconfig:
152
153 2019-03-22  Keith Rollin  <krollin@apple.com>
154
155         Enable ThinLTO support in Production builds
156         https://bugs.webkit.org/show_bug.cgi?id=190758
157         <rdar://problem/45413233>
158
159         Reviewed by Daniel Bates.
160
161         Enable building with Thin LTO in Production when using Xcode 10.2 or
162         later. This change results in a 1.45% progression in PLT5. Full
163         Production build times increase about 2-3%. Incremental build times
164         are more severely affected, and so LTO is not enabled for local
165         engineering builds.
166
167         LTO is enabled only on macOS for now, until rdar://problem/49013399,
168         which affects ARM builds, is fixed.
169
170         To change the LTO setting when building locally:
171
172         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
173           command line.
174         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
175           on the command line.
176         - If building with `build-root`, specify --lto={none,thin,full} on the
177           command line.
178         - If building with Xcode, create a LocalOverrides.xcconfig file at the
179           top level of your repository directory (if needed) and define
180           WK_LTO_MODE to full, thin, or none.
181
182         * Configurations/Base.xcconfig:
183
184 2019-03-21  Andy Estes  <aestes@apple.com>
185
186         [iOS] Apple Pay should be available in documents with no user agent scripts
187         https://bugs.webkit.org/show_bug.cgi?id=196061
188         <rdar://problem/48649391>
189
190         Reviewed by Brady Eidson.
191
192         * WebView/WebFrame.mm:
193         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
194
195 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
196
197         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
198         https://bugs.webkit.org/show_bug.cgi?id=196049
199
200         Reviewed by Tim Horton.
201
202         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
203         overflow scrolling in general, so rename it.
204
205         * Configurations/FeatureDefines.xcconfig:
206
207 2019-03-13  Dean Jackson  <dino@apple.com>
208
209         Block all plugins smaller than 5x5px
210         https://bugs.webkit.org/show_bug.cgi?id=195702
211         <rdar://problem/28435204>
212
213         Reviewed by Sam Weinig.
214
215         Removed a function that was never being called.
216
217         * WebCoreSupport/WebFrameLoaderClient.h:
218         * WebCoreSupport/WebFrameLoaderClient.mm:
219         (WebFrameLoaderClient::recreatePlugin): Deleted.
220
221 2019-03-13  Keith Rollin  <krollin@apple.com>
222
223         Add support for new StagedFrameworks layout
224         https://bugs.webkit.org/show_bug.cgi?id=195543
225
226         Reviewed by Alexey Proskuryakov.
227
228         When creating the WebKit layout for out-of-band Safari/WebKit updates,
229         use an optional path prefix when called for.
230
231         * Configurations/WebKitLegacy.xcconfig:
232
233 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
234
235         Remove a site specific hack for AppleConnect plugin
236         https://bugs.webkit.org/show_bug.cgi?id=195643
237
238         Reviewed by Simon Fraser.
239
240         r66437 added a workaround for AppleConnect plugin.
241
242         Remove this code since Safari doesn't even use WebKitLegacy anymore,
243         and other WebKit clients support AppleConnect plugins.
244
245         * WebCoreSupport/WebFrameLoaderClient.mm:
246         (WebFrameLoaderClient::createPlugin):
247
248 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
249
250         Unreviewed, rolling out r242688, r242643, r242624.
251
252         Caused multiple layout test failures and crashes on iOS and macOS.
253
254         Reverted changeset:
255
256         "requestAnimationFrame should execute before the next frame"
257         https://bugs.webkit.org/show_bug.cgi?id=177484
258         https://trac.webkit.org/changeset/242624/webkit
259
260         * WebView/WebView.mm:
261         (-[WebView _viewWillDrawInternal]):
262
263 2019-03-09  Andy Estes  <aestes@apple.com>
264
265         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
266         https://bugs.webkit.org/show_bug.cgi?id=195526
267         <rdar://problem/48745636>
268
269         Reviewed by Chris Dumez.
270
271         * WebCoreSupport/WebPaymentCoordinatorClient.h:
272         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
273         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
274         (WebPaymentCoordinatorClient::openPaymentSetup):
275
276 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
277
278         requestAnimationFrame should execute before the next frame
279         https://bugs.webkit.org/show_bug.cgi?id=177484
280
281         Reviewed by Simon Fraser.
282
283         * WebView/WebView.mm:
284         (-[WebView _viewWillDrawInternal]):
285         Call Page::renderingUpdate() which implements  "Update the rendering"
286         step of the HTML Event Loop specification.
287
288 2019-03-07  Zalan Bujtas  <zalan@apple.com>
289
290         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
291         https://bugs.webkit.org/show_bug.cgi?id=195353
292         <rdar://problem/48626394>
293
294         Reviewed by Simon Fraser.
295
296         * WebView/WebPreferenceKeysPrivate.h:
297         * WebView/WebPreferences.mm:
298         (+[WebPreferences initialize]):
299         (-[WebPreferences contentChangeObserverEnabled]):
300         (-[WebPreferences setContentChangeObserverEnabled:]):
301         * WebView/WebPreferencesPrivate.h:
302         * WebView/WebView.mm:
303         (-[WebView _preferencesChanged:]):
304
305 2019-03-06  Sam Weinig  <sam@webkit.org>
306
307         WebKitLegacy does not need to generate an export file for i386 anymore
308         https://bugs.webkit.org/show_bug.cgi?id=195380
309
310         Reviewed by Dan Bernstein.
311
312         * Configurations/WebKitLegacy.xcconfig:
313         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
314         It still needs to be generated, since we are concatenating the shared exports
315         file with a macOS or iOS specific one.
316
317         * WebKit.mac.exp:
318         Remove i386 specific symbols that we were previously stripping.
319
320 2019-03-06  Rob Buis  <rbuis@igalia.com>
321
322         Consider supporting the `referrerpolicy` attribute.
323         https://bugs.webkit.org/show_bug.cgi?id=179053
324
325         Reviewed by Darin Adler.
326
327         Add a runtime flag for referrerpolicy attribute.
328
329         * WebView/WebPreferenceKeysPrivate.h:
330         * WebView/WebPreferences.mm:
331         (+[WebPreferences initialize]):
332         (-[WebPreferences referrerPolicyAttributeEnabled]):
333         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
334         * WebView/WebPreferencesPrivate.h:
335         * WebView/WebView.mm:
336         (-[WebView _preferencesChanged:]):
337
338 2019-03-03  Tim Horton  <timothy_horton@apple.com>
339
340         Remove some more unused 32-bit code
341         https://bugs.webkit.org/show_bug.cgi?id=195255
342
343         Reviewed by Darin Adler.
344
345         * Plugins/WebNetscapePluginEventHandler.mm:
346         (WebNetscapePluginEventHandler::create):
347         * Plugins/WebNetscapePluginView.h:
348         * Plugins/WebNetscapePluginView.mm:
349         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
350         (-[WebNetscapePluginView restorePortState:]):
351         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
352         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
353         (-[WebNetscapePluginView updateAndSetWindow]):
354         (-[WebNetscapePluginView setWindowIfNecessary]):
355         (-[WebNetscapePluginView createPlugin]):
356         (-[WebNetscapePluginView fini]):
357         (-[WebNetscapePluginView drawRect:]):
358         (-[WebNetscapePluginView invalidateRegion:]):
359         (-[WebNetscapePluginView getVariable:value:]):
360         (-[WebNetscapePluginView setVariable:value:]):
361         (isDrawingModelQuickDraw): Deleted.
362         (-[WebNetscapePluginView fixWindowPort]): Deleted.
363         (getQDPixelFormatForBitmapContext): Deleted.
364         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
365         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
366         * WebView/WebDelegateImplementationCaching.mm:
367
368 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
369
370         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
371         https://bugs.webkit.org/show_bug.cgi?id=195053
372         <rdar://problem/48134710>
373
374         Reviewed by Ryosuke Niwa.
375
376         * WebCoreSupport/WebEditorClient.h:
377
378 2019-03-01  Tim Horton  <timothy_horton@apple.com>
379
380         Remove unused code in WebKitLegacy
381         https://bugs.webkit.org/show_bug.cgi?id=189614
382
383         Reviewed by Simon Fraser.
384
385         * Carbon/CarbonUtils.h: Removed.
386         * Carbon/CarbonUtils.m: Removed.
387         * Carbon/CarbonWindowAdapter.h: Removed.
388         * Carbon/CarbonWindowAdapter.mm: Removed.
389         * Carbon/CarbonWindowContentView.h: Removed.
390         * Carbon/CarbonWindowContentView.m: Removed.
391         * Carbon/CarbonWindowFrame.h: Removed.
392         * Carbon/CarbonWindowFrame.m: Removed.
393         * Carbon/HIViewAdapter.h: Removed.
394         * Carbon/HIViewAdapter.m: Removed.
395         * Carbon/HIWebView.h: Removed.
396         * Carbon/HIWebView.mm: Removed.
397         * Configurations/WebKitLegacy.xcconfig:
398         * WebKit.mac.exp:
399
400 2019-03-01  Justin Fan  <justin_fan@apple.com>
401
402         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
403         https://bugs.webkit.org/show_bug.cgi?id=195191
404
405         Rubber-stamped by Dean Jackson.
406
407         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
408
409         * Configurations/FeatureDefines.xcconfig:
410
411 2019-02-28  Antoine Quint  <graouts@apple.com>
412
413         Enable the Pointer Events runtime flag by default
414         https://bugs.webkit.org/show_bug.cgi?id=195156
415
416         Reviewed by Dean Jackson.
417
418         * WebView/WebPreferences.mm:
419         (+[WebPreferences initialize]):
420
421 2019-02-28  Justin Fan  <justin_fan@apple.com>
422
423         [Web GPU] Enable Web GPU only on 64-bit
424         https://bugs.webkit.org/show_bug.cgi?id=195139
425
426         Because Metal is only supported on 64 bit apps.
427
428         Unreviewed build fix.
429
430         * Configurations/FeatureDefines.xcconfig:
431
432 2019-02-27  Antoine Quint  <graouts@apple.com>
433
434         Support Pointer Events on macOS
435         https://bugs.webkit.org/show_bug.cgi?id=195008
436         <rdar://problem/47454419>
437
438         Reviewed by Dean Jackson.
439
440         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
441
442         * Configurations/FeatureDefines.xcconfig:
443         * WebView/WebPreferenceKeysPrivate.h:
444         * WebView/WebPreferences.mm:
445         (+[WebPreferences initialize]):
446         (-[WebPreferences pointerEventsEnabled]):
447         (-[WebPreferences setPointerEventsEnabled:]):
448         * WebView/WebPreferencesPrivate.h:
449         * WebView/WebView.mm:
450         (-[WebView _preferencesChanged:]):
451
452 2019-02-23  Keith Miller  <keith_miller@apple.com>
453
454         Add new mac target numbers
455         https://bugs.webkit.org/show_bug.cgi?id=194955
456
457         Reviewed by Tim Horton.
458
459         * Configurations/Base.xcconfig:
460         * Configurations/DebugRelease.xcconfig:
461
462 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
463
464         Hardcode Visual Viewports on everywhere except iOS WK1
465         https://bugs.webkit.org/show_bug.cgi?id=194928
466
467         Reviewed by Zalan Bujtas.
468
469         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
470         change the default value of the Setting to 'true', and hardcode WebView on iOS to
471         set it to false. The setting has shipped for several years and there's no need to turn
472         it off now.
473
474         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
475         Visual Viewports are not enabled.
476         
477         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
478         that only runs in WK2
479
480         * WebView/WebPreferenceKeysPrivate.h:
481         * WebView/WebPreferences.mm:
482         (+[WebPreferences initialize]):
483         (-[WebPreferences visualViewportEnabled]): Deleted.
484         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
485         * WebView/WebPreferencesPrivate.h:
486         * WebView/WebView.mm:
487         (-[WebView _preferencesChanged:]):
488
489 2019-02-21  Darin Adler  <darin@apple.com>
490
491         Some refinements for Node and Document
492         https://bugs.webkit.org/show_bug.cgi?id=194764
493
494         Reviewed by Ryosuke Niwa.
495
496         * DOM/DOMDocument.mm:
497         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
498         through to WebCore or even looking at the arguments.
499         (-[DOMDocument getOverrideStyle::]): Ditto.
500
501 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
502
503         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
504         https://bugs.webkit.org/show_bug.cgi?id=194670
505         <rdar://problem/39066529>
506
507         Reviewed by Tim Horton.
508
509         * WebCoreSupport/WebEditorClient.h:
510         * WebCoreSupport/WebEditorClient.mm:
511         (WebEditorClient::replacementURLForResource): Deleted.
512         * WebCoreSupport/WebPlatformStrategies.h:
513         * WebCoreSupport/WebPlatformStrategies.mm:
514         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
515
516 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
517
518         Add MSE logging configuration
519         https://bugs.webkit.org/show_bug.cgi?id=194719
520         <rdar://problem/48122151>
521
522         Reviewed by Joseph Pecoraro.
523
524         * WebCoreSupport/WebChromeClient.mm:
525         (stringForMessageSource): Recognize the MSE message source.
526
527 2019-02-17  David Kilzer  <ddkilzer@apple.com>
528
529         Unreviewed, rolling out r241620.
530
531         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
532         (Requested by ddkilzer on #webkit.)
533
534         Reverted changeset:
535
536         "[WTF] Add environment variable helpers"
537         https://bugs.webkit.org/show_bug.cgi?id=192405
538         https://trac.webkit.org/changeset/241620
539
540 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
541
542         [WTF] Add environment variable helpers
543         https://bugs.webkit.org/show_bug.cgi?id=192405
544
545         Reviewed by Michael Catanzaro.
546
547         * WebView/WebView.mm:
548         (-[WebView _initWithFrame:frameName:groupName:]):
549         Utilize WTF::Environment where possible.
550
551 2019-02-15  Brian Burg  <bburg@apple.com>
552
553         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
554         https://bugs.webkit.org/show_bug.cgi?id=194411
555         <rdar://problem/47787614>
556
557         Reviewed by Joseph Pecoraro.
558
559         * Configurations/WebKitLegacy.xcconfig:
560         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
561
562         * WebCoreSupport/WebInspectorClient.mm:
563         (WebInspectorFrontendClient::localizedStringsURL):
564         (-[WebInspectorWindowController inspectorPagePath]):
565         (-[WebInspectorWindowController inspectorTestPagePath]):
566         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
567
568 2019-02-15  Commit Queue  <commit-queue@webkit.org>
569
570         Unreviewed, rolling out r241559 and r241566.
571         https://bugs.webkit.org/show_bug.cgi?id=194710
572
573         Causes layout test crashes under GuardMalloc (Requested by
574         ryanhaddad on #webkit).
575
576         Reverted changesets:
577
578         "[WTF] Add environment variable helpers"
579         https://bugs.webkit.org/show_bug.cgi?id=192405
580         https://trac.webkit.org/changeset/241559
581
582         "Unreviewed build fix for WinCairo Debug after r241559."
583         https://trac.webkit.org/changeset/241566
584
585 2019-02-15  Truitt Savell  <tsavell@apple.com>
586
587         Unreviewed, rolling out r241564.
588
589         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
590
591         Reverted changeset:
592
593         "[Mac] WebInspectorUI.framework does not need to be soft-
594         linked anymore"
595         https://bugs.webkit.org/show_bug.cgi?id=194411
596         https://trac.webkit.org/changeset/241564
597
598 2019-02-14  Brian Burg  <bburg@apple.com>
599
600         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
601         https://bugs.webkit.org/show_bug.cgi?id=194411
602         <rdar://problem/47787614>
603
604         Reviewed by Joseph Pecoraro.
605
606         * Configurations/WebKitLegacy.xcconfig:
607         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
608
609         * WebCoreSupport/WebInspectorClient.mm:
610         (WebInspectorFrontendClient::localizedStringsURL):
611         (-[WebInspectorWindowController inspectorPagePath]):
612         (-[WebInspectorWindowController inspectorTestPagePath]):
613         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
614
615 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
616
617         [WTF] Add environment variable helpers
618         https://bugs.webkit.org/show_bug.cgi?id=192405
619
620         Reviewed by Michael Catanzaro.
621
622         * WebView/WebView.mm:
623         (-[WebView _initWithFrame:frameName:groupName:]):
624         Utilize WTF::Environment where possible.
625
626 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
627
628         Allow pages to trigger programmatic paste from script on iOS
629         https://bugs.webkit.org/show_bug.cgi?id=194271
630         <rdar://problem/47808810>
631
632         Reviewed by Ryosuke Niwa.
633
634         See WebCore and WebKit ChangeLogs for more details.
635
636         * WebCoreSupport/WebEditorClient.h:
637
638 2019-02-12  Andy Estes  <aestes@apple.com>
639
640         [iOSMac] Enable Parental Controls Content Filtering
641         https://bugs.webkit.org/show_bug.cgi?id=194521
642         <rdar://39732376>
643
644         Reviewed by Tim Horton.
645
646         * Configurations/FeatureDefines.xcconfig:
647
648 2019-02-06  Andy Estes  <aestes@apple.com>
649
650         [Payment Request] It should be possible to require a phonetic name for shipping contacts
651         https://bugs.webkit.org/show_bug.cgi?id=194311
652         <rdar://46733045>
653
654         Reviewed by Alex Christensen.
655
656         * WebCoreSupport/WebPaymentCoordinatorClient.h:
657         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
658         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
659
660 2019-02-04  Said Abou-Hallawa  <said@apple.com>
661
662         [CG] Enable setAdditionalSupportedImageTypes for WK1
663         https://bugs.webkit.org/show_bug.cgi?id=194190
664
665         Reviewed by Tim Horton.
666
667         1. Define the preferences key AdditionalSupportedImageTypes.
668         2. Add additionalSupportedImageTypes as a private preference property.
669         3. Define the setter and the getter of the property.
670         4. Add function to convert from an id to an array of strings.
671         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
672
673         * WebView/WebPreferenceKeysPrivate.h:
674         * WebView/WebPreferences.mm:
675         (-[WebPreferences _stringArrayValueForKey:]):
676         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
677         (-[WebPreferences setAdditionalSupportedImageTypes:]):
678         (-[WebPreferences additionalSupportedImageTypes]):
679         * WebView/WebPreferencesPrivate.h:
680         * WebView/WebView.mm:
681         (-[WebView _preferencesChanged:]):
682
683 2019-02-04  Timothy Hatcher  <timothy@apple.com>
684
685         Add WebView SPI to temporarily force light or dark appearance on a page.
686         https://bugs.webkit.org/show_bug.cgi?id=194230
687
688         Reviewed by Tim Horton.
689
690         * WebView/WebView.mm:
691         (-[WebView _useDarkAppearance:]): Added.
692         (-[WebView _setUseDarkAppearance:]): Added.
693         * WebView/WebViewPrivate.h:
694
695 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
696
697         PageOverlayController's layers should be created lazily
698         https://bugs.webkit.org/show_bug.cgi?id=194199
699         rdar://problem/46571593
700
701         Reviewed by Tim Horton.
702
703         * WebCoreSupport/WebChromeClient.h:
704         * WebCoreSupport/WebChromeClient.mm:
705         (WebChromeClient::attachViewOverlayGraphicsLayer):
706
707 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
708
709         Make setNeedsLayout on the root more explicitly about triggering its side-effects
710         https://bugs.webkit.org/show_bug.cgi?id=194198
711
712         Reviewed by Antti Koivisto.
713
714         Call the newly named functions.
715
716         * WebView/WebFrame.mm:
717         (-[WebFrame setNeedsLayout]):
718         * WebView/WebHTMLView.mm:
719         (-[WebHTMLView setNeedsLayout:]):
720
721 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
722
723         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
724         https://bugs.webkit.org/show_bug.cgi?id=194189
725
726         Reviewed by Geoffrey Garen.
727
728         Pass the policy check identifier around functions and store it in WebFramePolicyListener
729         so that we can send it back to WebCore with the navigation policy decision.
730
731         * WebCoreSupport/WebFrameLoaderClient.h:
732         * WebCoreSupport/WebFrameLoaderClient.mm:
733         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
734         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
735         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
736         (WebFrameLoaderClient::dispatchWillSubmitForm):
737         (WebFrameLoaderClient::setUpPolicyListener):
738         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
739         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
740         (-[WebFramePolicyListener invalidate]):
741         (-[WebFramePolicyListener dealloc]):
742         (-[WebFramePolicyListener receivedPolicyDecision:]):
743         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
744         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
745
746 2019-01-31  Alex Christensen  <achristensen@webkit.org>
747
748         Revert r238819 which is unneeded and caused a performance regression.
749         https://bugs.webkit.org/show_bug.cgi?id=192272
750         <rdar://problem/46664625>
751
752         * WebCoreSupport/WebFrameLoaderClient.h:
753         * WebCoreSupport/WebFrameLoaderClient.mm:
754         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
755
756 2019-01-28  Devin Rousso  <drousso@apple.com>
757
758         Web Inspector: provide a way to edit page WebRTC settings on a remote target
759         https://bugs.webkit.org/show_bug.cgi?id=193863
760         <rdar://problem/47572764>
761
762         Reviewed by Joseph Pecoraro.
763
764         * WebView/WebView.mm:
765         (-[WebView _preferencesChanged:]):
766         Add page-level settings for WebRTC preferences.
767
768 2019-01-28  Andy Estes  <aestes@apple.com>
769
770         [watchOS] Enable Parental Controls content filtering
771         https://bugs.webkit.org/show_bug.cgi?id=193939
772         <rdar://problem/46641912>
773
774         Reviewed by Ryosuke Niwa.
775
776         * Configurations/FeatureDefines.xcconfig:
777
778 2019-01-28  Timothy Hatcher  <timothy@apple.com>
779
780         Make it easier for non-Apple ports to enable dark mode CSS support.
781         https://bugs.webkit.org/show_bug.cgi?id=193882
782
783         Reviewed by Megan Gardner.
784
785         * WebView/WebView.mm:
786         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
787         (-[WebView _effectiveAppearanceIsDark]): Ditto.
788
789 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
790
791         AX: Introduce a static accessibility tree
792         https://bugs.webkit.org/show_bug.cgi?id=193348
793         <rdar://problem/47203295>
794
795         Reviewed by Ryosuke Niwa.
796
797         * Configurations/FeatureDefines.xcconfig:
798
799 2019-01-25  Keith Rollin  <krollin@apple.com>
800
801         Update WebKitAdditions.xcconfig with correct order of variable definitions
802         https://bugs.webkit.org/show_bug.cgi?id=193793
803         <rdar://problem/47532439>
804
805         Reviewed by Alex Christensen.
806
807         XCBuild changes the way xcconfig variables are evaluated. In short,
808         all config file assignments are now considered in part of the
809         evaluation. When using the new build system and an .xcconfig file
810         contains multiple assignments of the same build setting:
811
812         - Later assignments using $(inherited) will inherit from earlier
813           assignments in the xcconfig file.
814         - Later assignments not using $(inherited) will take precedence over
815           earlier assignments. An assignment to a more general setting will
816           mask an earlier assignment to a less general setting. For example,
817           an assignment without a condition ('FOO = bar') will completely mask
818           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
819
820         This affects some of our .xcconfig files, in that sometimes platform-
821         or sdk-specific definitions appear before the general definitions.
822         Under the new evaluations rules, the general definitions alway take
823         effect because they always overwrite the more-specific definitions. The
824         solution is to swap the order, so that the general definitions are
825         established first, and then conditionally overwritten by the
826         more-specific definitions.
827
828         * Configurations/Version.xcconfig:
829         * Configurations/WebKitLegacy.xcconfig:
830
831 2019-01-25  David Kilzer  <ddkilzer@apple.com>
832
833         Move soft-linking of Lookup.framework out of LookupSPI.h
834         <https://webkit.org/b/193815>
835
836         Reviewed by Tim Horton.
837
838         * WebView/WebImmediateActionController.mm:
839         (-[WebImmediateActionController _animationControllerForText]):
840         * WebView/WebView.mm:
841         (-[WebView _prepareForDictionaryLookup]):
842         - Move soft-linking to LookupSoftLink.{h,mm}.
843
844 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
847         https://bugs.webkit.org/show_bug.cgi?id=193829
848
849         Reviewed by Tim Horton.
850
851         * WebCoreSupport/WebDragClient.mm:
852         (WebDragClient::didConcludeEditDrag):
853         * WebView/WebView.mm:
854         (-[WebView _requestStartDataInteraction:globalPosition:]):
855         (-[WebView _didConcludeEditDrag]):
856         (-[WebView _didConcludeEditDataInteraction]): Deleted.
857         * WebView/WebViewInternal.h:
858
859 2019-01-24  John Wilander  <wilander@apple.com>
860
861         Add Ad Click Attribution as an internal/experimental feature
862         https://bugs.webkit.org/show_bug.cgi?id=193685
863         <rdar://problem/47450399>
864
865         Reviewed by Brent Fulgham.
866
867         * WebView/WebPreferenceKeysPrivate.h:
868         * WebView/WebPreferences.mm:
869         (+[WebPreferences initialize]):
870         (-[WebPreferences adClickAttributionEnabled]):
871         (-[WebPreferences setAdClickAttributionEnabled:]):
872             Added support for experimental ad click attribution.
873         * WebView/WebPreferencesPrivate.h:
874         * WebView/WebView.mm:
875         (-[WebView _preferencesChanged:]):
876
877 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
878
879         Move FileSystem to WTF
880         https://bugs.webkit.org/show_bug.cgi?id=193602
881
882         Reviewed by Yusuke Suzuki.
883
884         * Misc/WebNSFileManagerExtras.mm:
885         * Storage/WebDatabaseProvider.mm:
886         * WebView/WebView.mm:
887
888 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
889
890         Fix the Apple Internal build. See <rdar://problem/47491383>.
891
892         Rubber-stamped by Tim Horton.
893
894         * WebCoreSupport/WebFrameLoaderClient.mm:
895
896 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
897
898         Clean up USE(WEB_THREAD)
899         https://bugs.webkit.org/show_bug.cgi?id=193698
900
901         Rubber-stamped by Tim Horton.
902
903         * Misc/WebCache.mm:
904         (+[WebCache emptyInMemoryResources]):
905         * WebCoreSupport/WebFrameLoaderClient.mm:
906         (-[WebFramePolicyListener use]):
907         * WebCoreSupport/WebGeolocationClient.mm:
908         (-[WebGeolocationPolicyListener allow]):
909         (-[WebGeolocationPolicyListener deny]):
910         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
911         * WebView/WebFrame.mm:
912         (-[WebFrame deviceOrientationChanged]):
913         * WebView/WebHTMLView.mm:
914         (hardwareKeyboardAvailabilityChangedCallback):
915         * WebView/WebView.mm:
916         (+[WebView _releaseMemoryNow]):
917         (+[WebView willEnterBackgroundWithCompletionHandler:]):
918         (-[WebView updateLayoutIgnorePendingStyleSheets]):
919         (-[WebView _dispatchUnloadEvent]):
920         (-[WebView _close]):
921         (-[WebView _preferencesChangedNotification:]):
922         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
923         (-[WebView goBack]):
924         (-[WebView goForward]):
925         (+[WebView _cacheModelChangedNotification:]):
926         (-[WebView stopLoading:]):
927         (-[WebView stopLoadingAndClear]):
928         (-[WebView reload:]):
929         (WebInstallMemoryPressureHandler):
930
931 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
932
933         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
934         https://bugs.webkit.org/show_bug.cgi?id=193706
935         <rdar://problem/44807048>
936
937         Reviewed by Ryosuke Niwa.
938
939         Use UndoStep::label().
940
941         * WebCoreSupport/WebEditorClient.h:
942         * WebCoreSupport/WebEditorClient.mm:
943         (-[WebUndoStep initWithUndoStep:]):
944         (+[WebUndoStep stepWithUndoStep:]):
945         (WebEditorClient::registerUndoOrRedoStep):
946         (WebEditorClient::registerUndoStep):
947         (WebEditorClient::registerRedoStep):
948
949 2019-01-22  Alex Christensen  <achristensen@webkit.org>
950
951         Move NetworkStorageSession ownership to NetworkProcess
952         https://bugs.webkit.org/show_bug.cgi?id=193580
953
954         Reviewed by Geoff Garen.
955
956         * Misc/WebCache.mm:
957         (+[WebCache clearCachedCredentials]):
958         * Misc/WebDownload.mm:
959         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
960         * Plugins/WebBaseNetscapePluginView.mm:
961         (WebKit::getAuthenticationInfo):
962         * WebCoreSupport/WebFrameNetworkingContext.mm:
963         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
964         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
965         (WebFrameNetworkingContext::storageSession const):
966         * WebView/WebPreferences.mm:
967         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
968         (+[WebPreferences _clearNetworkLoaderSession]):
969         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
970
971 2019-01-22  Daniel Bates  <dabates@apple.com>
972
973         [iOS] Interpret text key commands on keydown and app key commands on keypress
974         https://bugs.webkit.org/show_bug.cgi?id=192897
975         <rdar://problem/46857378>
976
977         Reviewed by Brent Fulgham.
978
979         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
980         is false) and keypress (isCharEvent is true), respectively.
981
982         * WebView/WebHTMLView.mm:
983         (-[WebHTMLView _handleEditingKeyEvent:]):
984
985 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
986
987         [css-logical] Implement flow-relative margin, padding and border shorthands
988         https://bugs.webkit.org/show_bug.cgi?id=188697
989
990         Reviewed by Simon Fraser and Antti Koivisto.
991
992         Add CSSLogicalEnabled runtime flag.
993
994         * WebView/WebPreferenceKeysPrivate.h:
995         * WebView/WebPreferences.mm:
996         (+[WebPreferences initialize]):
997         (-[WebPreferences cssLogicalEnabled]):
998         (-[WebPreferences setCSSLogicalEnabled:]):
999         * WebView/WebPreferencesPrivate.h:
1000         * WebView/WebView.mm:
1001         (-[WebView _preferencesChanged:]):
1002
1003 2019-01-15  Darin Adler  <darin@apple.com>
1004
1005         Use references rather than pointers for register/unregister functions, and more
1006         https://bugs.webkit.org/show_bug.cgi?id=175028
1007
1008         Reviewed by Daniel Bates.
1009
1010         * WebCoreSupport/WebKitFullScreenListener.mm:
1011         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1012         functions in Document; pass a reference.
1013         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1014         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1015         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1016         * WebView/WebFullScreenController.mm:
1017         (-[WebFullScreenController enterFullScreen:]): Ditto.
1018         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1019         (-[WebFullScreenController exitFullScreen]): Ditto.
1020         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1021         * WebView/WebFullScreenController.mm:
1022         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1023
1024 2019-01-12  Dan Bernstein  <mitz@apple.com>
1025
1026         [Cocoa] Avoid importing directly from subumbrella frameworks
1027         https://bugs.webkit.org/show_bug.cgi?id=186016
1028         <rdar://problem/40591038>
1029
1030         Reviewed by Sam Weinig.
1031
1032         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1033         * Carbon/CarbonWindowAdapter.mm: Ditto.
1034         * Carbon/CarbonWindowFrame.m: Ditto.
1035         * Carbon/HIViewAdapter.h: Ditto.
1036         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1037           OTHER_CFLAGS_COCOA_TOUCH_NO.
1038         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1039         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1040         * WebView/WebPDFView.h: Ditto.
1041
1042 2019-01-20  Antoine Quint  <graouts@apple.com>
1043
1044         Add a POINTER_EVENTS feature flag
1045         https://bugs.webkit.org/show_bug.cgi?id=193577
1046         <rdar://problem/47408511>
1047
1048         Unreviewed. Also enable Pointer Events for iosmac.
1049
1050         * Configurations/FeatureDefines.xcconfig:
1051
1052 2019-01-19  Antoine Quint  <graouts@apple.com>
1053
1054         Add a POINTER_EVENTS feature flag
1055         https://bugs.webkit.org/show_bug.cgi?id=193577
1056
1057         Reviewed by Dean Jackson.
1058
1059         * Configurations/FeatureDefines.xcconfig:
1060
1061 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1062
1063         Revert r238815, it broke WK1 video fullscreen on Mac
1064         https://bugs.webkit.org/show_bug.cgi?id=193586
1065         <rdar://problem/47358941>
1066
1067         Reviewed by Jer Noble.
1068
1069         * WebView/WebVideoFullscreenController.h: Added.
1070         * WebView/WebVideoFullscreenController.mm: Added.
1071         (SOFT_LINK_CLASS):
1072         (-[WebVideoFullscreenController init]):
1073         (-[WebVideoFullscreenController dealloc]):
1074         (-[WebVideoFullscreenController fullscreenWindow]):
1075         (-[WebVideoFullscreenController windowDidLoad]):
1076         (-[WebVideoFullscreenController videoElement]):
1077         (-[WebVideoFullscreenController setVideoElement:]):
1078         (-[WebVideoFullscreenController clearFadeAnimation]):
1079         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1080         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1081         (-[WebVideoFullscreenController videoElementRect]):
1082         (-[WebVideoFullscreenController applicationDidResignActive:]):
1083         (frameExpandedToRatioOfFrame):
1084         (createBackgroundFullscreenWindow):
1085         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1086         (-[WebVideoFullscreenController enterFullscreen:]):
1087         (-[WebVideoFullscreenController exitFullscreen]):
1088         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1089         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1090         (-[WebVideoFullscreenController _requestExit]):
1091         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1092         (-[WebVideoFullscreenController requestExitFullscreen]):
1093         (-[WebVideoFullscreenController fadeHUDIn]):
1094         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1095         (-[WebVideoFullscreenController rateChanged:]):
1096         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1097         (-[WebVideoFullscreenWindow dealloc]):
1098         (-[WebVideoFullscreenWindow resignFirstResponder]):
1099         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1100         (-[WebVideoFullscreenWindow mouseDown:]):
1101         (-[WebVideoFullscreenWindow cancelOperation:]):
1102         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1103         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1104         (-[WebVideoFullscreenWindow animationDidEnd:]):
1105         (-[WebVideoFullscreenWindow mouseMoved:]):
1106         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1107         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1108         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1109         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1110         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1111         (-[WebVideoFullscreenHUDWindow center]):
1112         (-[WebVideoFullscreenHUDWindow keyDown:]):
1113         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1114         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1115         (-[WebVideoFullscreenHUDWindowController init]):
1116         (-[WebVideoFullscreenHUDWindowController dealloc]):
1117         (-[WebVideoFullscreenHUDWindowController setArea:]):
1118         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1119         (-[WebVideoFullscreenHUDWindowController delegate]):
1120         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1121         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1122         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1123         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1124         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1125         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1126         (createMediaUIControl):
1127         (createControlWithMediaUIControlType):
1128         (createTimeTextField):
1129         (createMediaUIBackgroundView):
1130         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1131         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1132         (-[WebVideoFullscreenHUDWindowController updateTime]):
1133         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1134         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1135         (-[WebVideoFullscreenHUDWindowController currentTime]):
1136         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1137         (-[WebVideoFullscreenHUDWindowController duration]):
1138         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1139         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1140         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1141         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1142         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1143         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1144         (-[WebVideoFullscreenHUDWindowController volume]):
1145         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1146         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1147         (-[WebVideoFullscreenHUDWindowController updateRate]):
1148         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1149         (-[WebVideoFullscreenHUDWindowController playing]):
1150         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1151         (timeToString):
1152         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1153         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1154         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1155         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1156         (-[WebVideoFullscreenHUDWindowController rewind:]):
1157         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1158         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1159         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1160         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1161         * WebView/WebView.mm:
1162         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1163         (-[WebView _exitVideoFullscreen]):
1164
1165 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1166
1167         Get rid of ADVANCED_SPELL_CHECKING
1168         https://bugs.webkit.org/show_bug.cgi?id=193592
1169
1170         Reviewed by Wenson Hsieh.
1171
1172         * WebCoreSupport/WebEditorClient.mm:
1173         (insertionPointFromCurrentSelection):
1174         (WebEditorClient::checkTextOfParagraph):
1175         (WebEditorClient::getGuessesForWord):
1176         (WebEditorClient::requestCandidatesForSelection):
1177         (WebEditorClient::requestCheckingOfString):
1178         * WebView/WebHTMLView.mm:
1179         (-[WebHTMLView insertText:]):
1180
1181 2019-01-18  Jer Noble  <jer.noble@apple.com>
1182
1183         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1184         https://bugs.webkit.org/show_bug.cgi?id=189553
1185
1186         Reviewed by Tim Horton.
1187
1188         * Configurations/Base.xcconfig:
1189         * Configurations/SDKVariant.xcconfig: Added.
1190         * Configurations/WebKitLegacy.xcconfig:
1191
1192 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1193
1194         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1195         <https://webkit.org/b/193568>
1196         <rdar://problem/47381130>
1197
1198         Reviewed by Alex Christensen.
1199
1200         * WebView/WebView.mm:
1201         - Remove unused soft-linking macros.
1202         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1203         (-[WebUITextIndicatorData initWithImage:scale:]):
1204         - Update to use exported PAL functions.
1205
1206 2019-01-17  Truitt Savell  <tsavell@apple.com>
1207
1208         Unreviewed, rolling out r240124.
1209
1210         This commit broke an internal build.
1211
1212         Reverted changeset:
1213
1214         "SDK_VARIANT build destinations should be separate from non-
1215         SDK_VARIANT builds"
1216         https://bugs.webkit.org/show_bug.cgi?id=189553
1217         https://trac.webkit.org/changeset/240124
1218
1219 2019-01-17  Jer Noble  <jer.noble@apple.com>
1220
1221         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1222         https://bugs.webkit.org/show_bug.cgi?id=189553
1223
1224         Reviewed by Tim Horton.
1225
1226         * Configurations/Base.xcconfig:
1227         * Configurations/SDKVariant.xcconfig: Added.
1228         * Configurations/WebKitLegacy.xcconfig:
1229
1230 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1231
1232         Stop using NetworkStorageSession::storageSession in WebCore
1233         https://bugs.webkit.org/show_bug.cgi?id=193529
1234
1235         Reviewed by Tim Horton.
1236
1237         * Misc/WebCache.mm:
1238         (+[WebCache addImageToCache:forURL:forFrame:]):
1239         * WebView/WebView.mm:
1240         (-[WebView _commonInitializationWithFrameName:groupName:]):
1241         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1242
1243 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1244
1245         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1246         https://bugs.webkit.org/show_bug.cgi?id=193368
1247
1248         Reviewed by Geoff Garen.
1249
1250         * Misc/WebCache.mm:
1251         (+[WebCache clearCachedCredentials]):
1252         * Misc/WebDownload.mm:
1253         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1254         * Plugins/WebBaseNetscapePluginView.mm:
1255         (WebKit::getAuthenticationInfo):
1256
1257 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1258
1259         Stop using CookiesStrategy
1260         https://bugs.webkit.org/show_bug.cgi?id=161106
1261
1262         Reviewed by Don Olmstead and Antti Koivisto.
1263
1264         * Misc/WebCache.mm:
1265         (+[WebCache addImageToCache:forURL:forFrame:]):
1266         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1267         (WebKit::NetscapePluginInstanceProxy::getCookies):
1268         (WebKit::NetscapePluginInstanceProxy::setCookies):
1269         * Plugins/WebNetscapePluginView.mm:
1270         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1271         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1272         * WebCoreSupport/WebPlatformStrategies.h:
1273         * WebCoreSupport/WebPlatformStrategies.mm:
1274         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1275         (WebPlatformStrategies::cookiesForDOM): Deleted.
1276         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1277         (WebPlatformStrategies::cookiesEnabled): Deleted.
1278         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1279         (WebPlatformStrategies::getRawCookies): Deleted.
1280         (WebPlatformStrategies::deleteCookie): Deleted.
1281         * WebView/WebView.mm:
1282         (-[WebView _commonInitializationWithFrameName:groupName:]):
1283         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1284
1285 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1286
1287         Cannot tab out of WKWebView on macOS
1288         https://bugs.webkit.org/show_bug.cgi?id=161448
1289         <rdar://problem/28100085>
1290
1291         Reviewed by Dean Jackson.
1292
1293         * WebCoreSupport/WebChromeClient.mm:
1294         * WebView/WebView.mm:
1295         Make use of SPI headers.
1296
1297 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1298
1299         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1300         r239913, and r239914.
1301         https://bugs.webkit.org/show_bug.cgi?id=193407
1302
1303         These revisions caused an internal failure (Requested by
1304         Truitt on #webkit).
1305
1306         Reverted changesets:
1307
1308         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1309         https://bugs.webkit.org/show_bug.cgi?id=186016
1310         https://trac.webkit.org/changeset/239901
1311
1312         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1313         https://trac.webkit.org/changeset/239909
1314
1315         "Tried to fix the build."
1316         https://trac.webkit.org/changeset/239910
1317
1318         "Fixed iOS builds after r239910."
1319         https://trac.webkit.org/changeset/239912
1320
1321         "More build fixing."
1322         https://trac.webkit.org/changeset/239913
1323
1324         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1325         https://trac.webkit.org/changeset/239914
1326
1327 2019-01-14  Mark Lam  <mark.lam@apple.com>
1328
1329         Re-enable ability to build --cloop builds.
1330         https://bugs.webkit.org/show_bug.cgi?id=192955
1331         <rdar://problem/46882363>
1332
1333         Reviewed by Saam barati and Keith Miller.
1334
1335         * Configurations/FeatureDefines.xcconfig:
1336
1337 2019-01-13  Dan Bernstein  <mitz@apple.com>
1338
1339         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1340
1341         Patch by Keith Rollin.
1342
1343         * WebView/PDFViewSPI.h:
1344
1345 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1346
1347         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1348         https://bugs.webkit.org/show_bug.cgi?id=191655
1349         rdar://problem/46074680
1350
1351         Reviewed by Megan Gardner.
1352
1353         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1354         * WebView/WebView.mm:
1355         (-[WebView _effectiveAppearanceIsDark]):
1356
1357 2019-01-12  Dan Bernstein  <mitz@apple.com>
1358
1359         [Cocoa] Avoid importing directly from subumbrella frameworks
1360         https://bugs.webkit.org/show_bug.cgi?id=186016
1361         <rdar://problem/40591038>
1362
1363         Reviewed by Sam Weinig.
1364
1365         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1366         * Carbon/CarbonWindowAdapter.mm: Ditto.
1367         * Carbon/CarbonWindowFrame.m: Ditto.
1368         * Carbon/HIViewAdapter.h: Ditto.
1369         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1370           OTHER_CFLAGS_COCOA_TOUCH_NO.
1371         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1372         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1373         * WebView/WebPDFView.h: Ditto.
1374
1375 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1376
1377         Enable visual viewport API by default
1378         https://bugs.webkit.org/show_bug.cgi?id=193376
1379
1380         Reviewed by Simon Fraser.
1381
1382         * WebView/WebPreferences.mm:
1383         (+[WebPreferences initialize]):
1384
1385 2019-01-11  John Wilander  <wilander@apple.com>
1386
1387         Compile out Web API Statistics Collection
1388         https://bugs.webkit.org/show_bug.cgi?id=193370
1389         <rdar://problem/45388584>
1390
1391         Reviewed by Brent Fulgham.
1392
1393         * Configurations/FeatureDefines.xcconfig:
1394             Defined ENABLE_WEB_API_STATISTICS, off by default.
1395
1396 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1397
1398         Stop using NetworkStorageSession in WebProcess
1399         https://bugs.webkit.org/show_bug.cgi?id=193236
1400
1401         Reviewed by Don Olmstead.
1402
1403         * WebCoreSupport/WebFrameNetworkingContext.h:
1404         * WebCoreSupport/WebFrameNetworkingContext.mm:
1405         (WebFrameNetworkingContext::storageSession const):
1406         * WebCoreSupport/WebPlatformStrategies.h:
1407         * WebCoreSupport/WebPlatformStrategies.mm:
1408         (WebPlatformStrategies::cookiesForDOM):
1409         (WebPlatformStrategies::setCookiesFromDOM):
1410         (WebPlatformStrategies::cookiesEnabled):
1411         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1412         (WebPlatformStrategies::getRawCookies):
1413         (WebPlatformStrategies::deleteCookie):
1414         * WebView/WebView.mm:
1415         (-[WebView _cachedResponseForURL:]):
1416         (-[WebView _clearCredentials]):
1417
1418 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1419
1420         Unreviewed, rolling out r239727.
1421
1422         Broke API tests
1423
1424         Reverted changeset:
1425
1426         "Stop using NetworkStorageSession in WebProcess"
1427         https://bugs.webkit.org/show_bug.cgi?id=193236
1428         https://trac.webkit.org/changeset/239727
1429
1430 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1431
1432         Stop using NetworkStorageSession in WebProcess
1433         https://bugs.webkit.org/show_bug.cgi?id=193236
1434
1435         Reviewed by Don Olmstead.
1436
1437         * WebCoreSupport/WebFrameNetworkingContext.h:
1438         * WebCoreSupport/WebFrameNetworkingContext.mm:
1439         (WebFrameNetworkingContext::storageSession const):
1440         * WebView/WebView.mm:
1441         (-[WebView _cachedResponseForURL:]):
1442         (-[WebView _clearCredentials]):
1443
1444 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1445
1446         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1447         <https://webkit.org/b/193056>
1448
1449         Reviewed by Alex Christensen.
1450
1451         * Plugins/Hosted/NetscapePluginHostProxy.h:
1452         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1453         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1454         (WebKit::NetscapePluginInstanceProxy::enumerate):
1455         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1456         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1457         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1458         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1459         * Plugins/Hosted/ProxyInstance.mm:
1460         (WebKit::ProxyInstance::invoke):
1461         * WebCoreSupport/WebGeolocationClient.mm:
1462         * WebView/WebDataSource.mm:
1463         (-[WebDataSource _receivedData:]):
1464         * WebView/WebView.mm:
1465         (-[WebView _cachedResponseForURL:]):
1466         - Remove '*' from RetainPtr<> type.
1467
1468 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1469
1470         Progress towards fixing Mac CMake build
1471         https://bugs.webkit.org/show_bug.cgi?id=193105
1472
1473         Reviewed by Don Olmstead.
1474
1475         * WebKitPrefix.h:
1476
1477 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1478
1479         Web Inspector: Use save sheet instead of dialog where possible
1480         https://bugs.webkit.org/show_bug.cgi?id=193160
1481         <rdar://problem/37399759>
1482
1483         Reviewed by Devin Rousso.
1484
1485         * WebCoreSupport/WebInspectorClient.mm:
1486         (WebInspectorFrontendClient::save):
1487
1488 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1489
1490         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1491         https://bugs.webkit.org/show_bug.cgi?id=193129
1492
1493         Reviewed by Tim Horton.
1494
1495         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1496
1497         * WebCoreSupport/WebEditorClient.mm:
1498         (WebEditorClient::registerUndoOrRedoStep):
1499         (undoNameForEditAction): Deleted.
1500
1501 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         Add support for using the current text selection as the find string on iOS
1504         https://bugs.webkit.org/show_bug.cgi?id=193034
1505         <rdar://problem/45138739>
1506
1507         Reviewed by Tim Horton.
1508
1509         Add a method stub for WebKitLegacy.
1510
1511         * WebCoreSupport/WebEditorClient.h:
1512
1513 2019-01-01  Jeff Miller  <jeffm@apple.com>
1514
1515         Update user-visible copyright strings to include 2019
1516         https://bugs.webkit.org/show_bug.cgi?id=192811
1517
1518         Reviewed by Mark Lam.
1519
1520         * Info.plist:
1521
1522 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1523
1524         Use Ref<> as much as possible
1525         https://bugs.webkit.org/show_bug.cgi?id=192808
1526
1527         Reviewed by Alex Christensen.
1528
1529         * DOM/DOM.mm:
1530         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1531         * Plugins/Hosted/NetscapePluginHostManager.mm:
1532         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1533         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1534         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1535         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1536         * Plugins/WebNetscapePluginView.mm:
1537         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1538         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1539         * WebCoreSupport/WebContextMenuClient.mm:
1540         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1541         * WebCoreSupport/WebFrameLoaderClient.mm:
1542         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1543         * WebView/WebFrame.mm:
1544         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1545         * WebView/WebHTMLView.mm:
1546         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1547         * WebView/WebView.mm:
1548         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1549         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1550
1551 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1552
1553         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1554         https://bugs.webkit.org/show_bug.cgi?id=192821
1555
1556         Reviewed by Chris Dumez.
1557
1558         When a window becomes occluded, the window server informs the application.
1559         This should be used to suspend any work that is not visible by the user.
1560
1561         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1562         In some cases, that lead to performance impact (see radar).
1563
1564         This patch adds an observer for the occlusion notification. I tried to stick
1565         with the same names used by WebKit2.
1566
1567         * WebView/WebView.mm:
1568         (-[WebView _isViewVisible]):
1569         (-[WebView addWindowObserversForWindow:]):
1570         (-[WebView removeWindowObservers]):
1571         (-[WebView _windowDidChangeOcclusionState:]):
1572
1573 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1574
1575         [WebAuthN] Add a runtime flag for local authenticator
1576         https://bugs.webkit.org/show_bug.cgi?id=192792
1577         <rdar://problem/46798738>
1578
1579         Reviewed by Brent Fulgham.
1580
1581         * WebView/WebPreferenceKeysPrivate.h:
1582         * WebView/WebPreferences.mm:
1583         (+[WebPreferences initialize]):
1584         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1585         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1586         * WebView/WebPreferencesPrivate.h:
1587         * WebView/WebView.mm:
1588         (-[WebView _preferencesChanged:]):
1589
1590 2018-12-20  Chris Dumez  <cdumez@apple.com>
1591
1592         Use Optional::valueOr() instead of Optional::value_or()
1593         https://bugs.webkit.org/show_bug.cgi?id=192933
1594
1595         Reviewed by Geoffrey Garen.
1596
1597         * WebCoreSupport/WebSecurityOrigin.mm:
1598         (-[WebSecurityOrigin port]):
1599
1600 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1601
1602         Unreviewed, rolling out r239417.
1603
1604         Introduced two API test failures on macOS.
1605
1606         Reverted changeset:
1607
1608         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1609         occlusion changes"
1610         https://bugs.webkit.org/show_bug.cgi?id=192821
1611         https://trac.webkit.org/changeset/239417
1612
1613 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1614
1615         WKWebView default UA doesn't freeze the build number
1616         https://bugs.webkit.org/show_bug.cgi?id=192809
1617         <rdar://problem/44687185>
1618
1619         Reviewed by Andy Estes.
1620
1621         Always reports the frozen build number.
1622
1623         * WebView/WebView.mm:
1624         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1625         actual build number through this method call.
1626         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1627
1628 2018-12-19  Chris Dumez  <cdumez@apple.com>
1629
1630         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1631         https://bugs.webkit.org/show_bug.cgi?id=192728
1632         <rdar://problem/46746779>
1633
1634         Reviewed by Geoff Garen.
1635
1636         * DOM/*:
1637         * Plugins/*:
1638         * WebCoreSupport/*:
1639         * WebView/*:
1640
1641 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1642
1643         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1644         https://bugs.webkit.org/show_bug.cgi?id=192821
1645
1646         Reviewed by Chris Dumez.
1647
1648         When a window becomes occluded, the window server informs the application.
1649         This should be used to suspend any work that is not visible by the user.
1650
1651         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1652         In some cases, that lead to performance impact (see radar).
1653
1654         This patch adds an observer for the occlusion notification. I tried to stick
1655         with the same names used by WebKit2.
1656
1657         * WebView/WebView.mm:
1658         (-[WebView _isViewVisible]):
1659         (-[WebView addWindowObserversForWindow:]):
1660         (-[WebView removeWindowObservers]):
1661         (-[WebView _windowDidChangeOcclusionState:]):
1662
1663 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1664
1665         Allow clients to set the navigator platform
1666         https://bugs.webkit.org/show_bug.cgi?id=192735
1667
1668         Reviewed by Tim Horton.
1669
1670         Add stubs to fill out the added functionality in FrameLoaderClient.
1671
1672         * WebCoreSupport/WebFrameLoaderClient.h:
1673         * WebCoreSupport/WebFrameLoaderClient.mm:
1674         (WebFrameLoaderClient::navigatorPlatform):
1675
1676 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1677
1678         offsetLeft and offsetParent should adjust across shadow boundaries
1679         https://bugs.webkit.org/show_bug.cgi?id=157437
1680         <rdar://problem/26154021>
1681
1682         Reviewed by Simon Fraser.
1683
1684         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1685
1686         * DOM/DOMElement.mm:
1687         (-[DOMElement offsetLeft]):
1688         (-[DOMElement offsetTop]):
1689         (-[DOMElement offsetParent]):
1690
1691 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1692
1693         Unreviewed build fix.
1694
1695         * WebView/WebFrame.mm:
1696         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1697
1698 2018-12-15  Darin Adler  <darin@apple.com>
1699
1700         Use warning-ignoring macros more consistently and simply
1701         https://bugs.webkit.org/show_bug.cgi?id=192743
1702
1703         Reviewed by Mark Lam.
1704
1705         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1706         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1707         compilers in Objective-C++ code.
1708
1709         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1710         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1711         accomodate non-clang compilers here. Also use #pragma once, add a missing
1712         "explicit" and fix conditionals.
1713
1714 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1715
1716         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1717         https://bugs.webkit.org/show_bug.cgi?id=192653
1718
1719         Reviewed by Wenson Hsieh.
1720
1721         * WebView/WebHTMLView.mm:
1722         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1723
1724 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1725
1726         Implement feature flag for CSS Typed OM
1727         https://bugs.webkit.org/show_bug.cgi?id=192610
1728
1729         Reviewed by Ryosuke Niwa.
1730
1731         * Configurations/FeatureDefines.xcconfig:
1732
1733 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1734
1735         WebCore shouldn't have a Objective-C class named NSCursor
1736         https://bugs.webkit.org/show_bug.cgi?id=192602
1737         <rdar://problem/46615532>
1738
1739         Reviewed by Wenson Hsieh.
1740
1741         * WebView/WebFrameView.mm:
1742         (-[WebFrameView keyDown:keyDown:]):
1743         * WebView/WebHTMLView.mm:
1744         (-[WebHTMLView keyDown:]):
1745         (-[WebHTMLView performKeyEquivalent:]):
1746         Only use NSCursor on macOS.
1747
1748 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1749
1750         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1751         https://bugs.webkit.org/show_bug.cgi?id=192573
1752
1753         Reviewed by Simon Fraser.
1754
1755         * Configurations/FeatureDefines.xcconfig:
1756
1757 2018-12-10  Antti Koivisto  <antti@apple.com>
1758
1759         Rename "forced style recalc" to "full style rebuild"
1760         https://bugs.webkit.org/show_bug.cgi?id=192572
1761
1762         Reviewed by Zalan Bujtas.
1763
1764         * WebView/WebHTMLView.mm:
1765         (-[WebHTMLView setNeedsToApplyStyles:]):
1766
1767 2018-12-10  Darin Adler  <darin@apple.com>
1768
1769         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1770         https://bugs.webkit.org/show_bug.cgi?id=192533
1771         rdar://problem/45732710
1772
1773         Reviewed by Anders Carlsson.
1774
1775         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1776         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1777
1778 2018-12-10  Darin Adler  <darin@apple.com>
1779
1780         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1781         https://bugs.webkit.org/show_bug.cgi?id=192532
1782         rdar://problem/45731047
1783
1784         Reviewed by Chris Dumez.
1785
1786         * Plugins/Hosted/NetscapePluginHostManager.mm:
1787         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1788         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1789         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1790
1791 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1792
1793         Turn WritingDirection into an enum class
1794         https://bugs.webkit.org/show_bug.cgi?id=192401
1795         Work towards <rdar://problem/42075638>
1796
1797         Reviewed by Dan Bernstein.
1798
1799         Change WritingDirection from an enum to an enum class. No change in behavior.
1800
1801         * WebView/WebHTMLView.mm:
1802         (-[WebHTMLView toggleBaseWritingDirection:]):
1803         (-[WebHTMLView changeBaseWritingDirection:]):
1804         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1805
1806 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1807
1808         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1809         https://bugs.webkit.org/show_bug.cgi?id=192272
1810
1811         Reviewed by Brady Eidson.
1812
1813         * WebCoreSupport/WebFrameLoaderClient.h:
1814         * WebCoreSupport/WebFrameLoaderClient.mm:
1815         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1816
1817 2018-12-03  Jer Noble  <jer.noble@apple.com>
1818
1819         Get rid of old, dead Mac video fullscreen code.
1820         https://bugs.webkit.org/show_bug.cgi?id=192315
1821
1822         Reviewed by Eric Carlson.
1823
1824         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1825         is no longer supported in the Mac port.
1826
1827         * WebView/WebVideoFullscreenController.h: Removed.
1828         * WebView/WebVideoFullscreenController.mm: Removed.
1829         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1830         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1831         * WebView/WebView.mm:
1832         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1833         (-[WebView _exitVideoFullscreen]):
1834
1835 2018-12-03  Daniel Bates  <dabates@apple.com>
1836
1837         [iOS] Do not handle key events that are key commands
1838         https://bugs.webkit.org/show_bug.cgi?id=191608
1839         <rdar://problem/46046013>
1840
1841         Reviewed by Ryosuke Niwa.
1842
1843         A key down event may be associated with a key command. If it is then we want to execute the
1844         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1845         event as a key command to find out.
1846
1847         * WebView/WebHTMLView.mm:
1848         (-[WebHTMLView _handleEditingKeyEvent:]):
1849
1850 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1851
1852         Add a runtime feature flag for LayoutFormattingContext.
1853         https://bugs.webkit.org/show_bug.cgi?id=192280
1854
1855         Reviewed by Simon Fraser.
1856
1857         * Configurations/FeatureDefines.xcconfig:
1858
1859 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1860
1861         Move URL from WebCore to WTF
1862         https://bugs.webkit.org/show_bug.cgi?id=190234
1863
1864         Reviewed by Keith Miller.
1865
1866         * DOM/DOMAttr.mm:
1867         * DOM/DOMBlob.mm:
1868         * DOM/DOMCSSCharsetRule.mm:
1869         * DOM/DOMCSSImportRule.mm:
1870         * DOM/DOMCSSMediaRule.mm:
1871         * DOM/DOMCSSPageRule.mm:
1872         * DOM/DOMCSSPrimitiveValue.mm:
1873         * DOM/DOMCSSRule.mm:
1874         * DOM/DOMCSSStyleDeclaration.mm:
1875         * DOM/DOMCSSStyleRule.mm:
1876         * DOM/DOMCSSStyleSheet.mm:
1877         * DOM/DOMCSSValue.mm:
1878         * DOM/DOMCharacterData.mm:
1879         * DOM/DOMCounter.mm:
1880         * DOM/DOMDocument.mm:
1881         * DOM/DOMDocumentFragment.mm:
1882         * DOM/DOMDocumentType.mm:
1883         * DOM/DOMEvent.mm:
1884         * DOM/DOMFile.mm:
1885         * DOM/DOMHTMLAnchorElement.mm:
1886         * DOM/DOMHTMLAppletElement.mm:
1887         * DOM/DOMHTMLAreaElement.mm:
1888         * DOM/DOMHTMLBRElement.mm:
1889         * DOM/DOMHTMLBaseElement.mm:
1890         * DOM/DOMHTMLBaseFontElement.mm:
1891         * DOM/DOMHTMLBodyElement.mm:
1892         * DOM/DOMHTMLButtonElement.mm:
1893         * DOM/DOMHTMLCanvasElement.mm:
1894         * DOM/DOMHTMLCollection.mm:
1895         * DOM/DOMHTMLDivElement.mm:
1896         * DOM/DOMHTMLDocument.mm:
1897         * DOM/DOMHTMLElement.mm:
1898         * DOM/DOMHTMLEmbedElement.mm:
1899         * DOM/DOMHTMLFieldSetElement.mm:
1900         * DOM/DOMHTMLFontElement.mm:
1901         * DOM/DOMHTMLFormElement.mm:
1902         * DOM/DOMHTMLFrameElement.mm:
1903         * DOM/DOMHTMLFrameSetElement.mm:
1904         * DOM/DOMHTMLHRElement.mm:
1905         * DOM/DOMHTMLHeadElement.mm:
1906         * DOM/DOMHTMLHeadingElement.mm:
1907         * DOM/DOMHTMLHtmlElement.mm:
1908         * DOM/DOMHTMLIFrameElement.mm:
1909         * DOM/DOMHTMLImageElement.mm:
1910         * DOM/DOMHTMLInputElement.mm:
1911         * DOM/DOMHTMLLIElement.mm:
1912         * DOM/DOMHTMLLabelElement.mm:
1913         * DOM/DOMHTMLLegendElement.mm:
1914         * DOM/DOMHTMLLinkElement.mm:
1915         * DOM/DOMHTMLMapElement.mm:
1916         * DOM/DOMHTMLMarqueeElement.mm:
1917         * DOM/DOMHTMLMediaElement.mm:
1918         * DOM/DOMHTMLMetaElement.mm:
1919         * DOM/DOMHTMLModElement.mm:
1920         * DOM/DOMHTMLOListElement.mm:
1921         * DOM/DOMHTMLObjectElement.mm:
1922         * DOM/DOMHTMLOptGroupElement.mm:
1923         * DOM/DOMHTMLOptionElement.mm:
1924         * DOM/DOMHTMLOptionsCollection.mm:
1925         * DOM/DOMHTMLParagraphElement.mm:
1926         * DOM/DOMHTMLParamElement.mm:
1927         * DOM/DOMHTMLQuoteElement.mm:
1928         * DOM/DOMHTMLScriptElement.mm:
1929         * DOM/DOMHTMLSelectElement.mm:
1930         * DOM/DOMHTMLStyleElement.mm:
1931         * DOM/DOMHTMLTableCaptionElement.mm:
1932         * DOM/DOMHTMLTableCellElement.mm:
1933         * DOM/DOMHTMLTableColElement.mm:
1934         * DOM/DOMHTMLTableElement.mm:
1935         * DOM/DOMHTMLTableRowElement.mm:
1936         * DOM/DOMHTMLTableSectionElement.mm:
1937         * DOM/DOMHTMLTitleElement.mm:
1938         * DOM/DOMHTMLUListElement.mm:
1939         * DOM/DOMHTMLVideoElement.mm:
1940         * DOM/DOMKeyboardEvent.mm:
1941         * DOM/DOMMediaList.mm:
1942         * DOM/DOMMouseEvent.mm:
1943         * DOM/DOMMutationEvent.mm:
1944         * DOM/DOMNamedNodeMap.mm:
1945         * DOM/DOMProcessingInstruction.mm:
1946         * DOM/DOMRange.mm:
1947         * DOM/DOMStyleSheet.mm:
1948         * DOM/DOMText.mm:
1949         * DOM/DOMTextEvent.mm:
1950         * DOM/DOMTokenList.mm:
1951         * DOM/DOMUIEvent.mm:
1952         * DOM/DOMXPathResult.mm:
1953         * History/WebHistoryItem.mm:
1954         * Misc/WebNSURLExtras.mm:
1955         (-[NSURL _web_userVisibleString]):
1956         (-[NSURL _web_URLByRemovingUserInfo]):
1957         (-[NSURL _web_dataForURLComponentType:]):
1958         (-[NSURL _web_schemeData]):
1959         (-[NSURL _web_hostData]):
1960         * Misc/WebUserContentURLPattern.mm:
1961         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1962         * Plugins/WebNetscapePluginStream.h:
1963         (WebNetscapePluginStream::setRequestURL):
1964         * WebCoreSupport/WebChromeClient.h:
1965         * WebCoreSupport/WebChromeClient.mm:
1966         (WebChromeClient::signedPublicKeyAndChallengeString const):
1967         * WebCoreSupport/WebContextMenuClient.h:
1968         * WebCoreSupport/WebContextMenuClient.mm:
1969         * WebCoreSupport/WebDragClient.h:
1970         * WebCoreSupport/WebFrameLoaderClient.h:
1971         * WebCoreSupport/WebFrameLoaderClient.mm:
1972         (WebFrameLoaderClient::updateGlobalHistory):
1973         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1974         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1975         (WebPaymentCoordinatorClient::showPaymentUI):
1976         * WebCoreSupport/WebPlatformStrategies.h:
1977         * WebCoreSupport/WebPlatformStrategies.mm:
1978         (WebPlatformStrategies::readURLFromPasteboard):
1979         * WebCoreSupport/WebPluginInfoProvider.h:
1980         * WebCoreSupport/WebPluginInfoProvider.mm:
1981         (WebPluginInfoProvider::webVisiblePluginInfo):
1982         * WebCoreSupport/WebSecurityOrigin.mm:
1983         * WebCoreSupport/WebVisitedLinkStore.h:
1984         * WebView/WebDataSource.mm:
1985         * WebView/WebFrame.mm:
1986         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1987         * WebView/WebImmediateActionController.mm:
1988         (-[WebImmediateActionController _defaultAnimationController]):
1989         * WebView/WebPDFView.mm:
1990         * WebView/WebScriptDebugger.mm:
1991         * WebView/WebViewInternal.h:
1992
1993 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1994
1995         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1996         https://bugs.webkit.org/show_bug.cgi?id=192197
1997
1998         Reviewed by Jiewen Tan.
1999
2000         * Configurations/FeatureDefines.xcconfig:
2001         * WebCoreSupport/WebChromeClient.h:
2002         * WebCoreSupport/WebChromeClient.mm:
2003
2004 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2005
2006         Remove dead code from an earlier attempt at implementing safe browsing
2007         https://bugs.webkit.org/show_bug.cgi?id=192067
2008
2009         Reviewed by Chris Dumez.
2010
2011         * WebCoreSupport/WebFrameLoaderClient.h:
2012         * WebCoreSupport/WebFrameLoaderClient.mm:
2013         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2014
2015 2018-11-27  Mark Lam  <mark.lam@apple.com>
2016
2017         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2018         https://bugs.webkit.org/show_bug.cgi?id=192055
2019         <rdar://problem/46288783>
2020
2021         Reviewed by Saam Barati.
2022
2023         * Configurations/FeatureDefines.xcconfig:
2024
2025 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2026
2027         Make it possible to insert editable images with a gesture
2028         https://bugs.webkit.org/show_bug.cgi?id=191937
2029
2030         Reviewed by Wenson Hsieh.
2031
2032         * WebCoreSupport/WebEditorClient.mm:
2033         (undoNameForEditAction):
2034         Add a undo name.
2035
2036 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2037
2038         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2039         https://bugs.webkit.org/show_bug.cgi?id=191945
2040
2041         Reviewed by Anders Carlsson.
2042
2043         * WebCoreSupport/WebEditorClient.mm:
2044         (undoNameForEditAction):
2045
2046 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2047
2048         Enable drag and drop support for iOSMac
2049         https://bugs.webkit.org/show_bug.cgi?id=191818
2050         <rdar://problem/43907454>
2051
2052         Reviewed by Dean Jackson.
2053
2054         * Configurations/FeatureDefines.xcconfig:
2055
2056 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2057
2058         Address post-review feedback after r238438
2059         https://bugs.webkit.org/show_bug.cgi?id=191913
2060
2061         Reviewed by Ryosuke Niwa.
2062
2063         * WebView/WebFrame.mm:
2064         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2065         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2066         * WebView/WebView.mm:
2067         (-[WebView setSelectedDOMRange:affinity:]):
2068
2069 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2070
2071         Web Inspector: "Reload Web Inspector" button no longer partially works
2072         https://bugs.webkit.org/show_bug.cgi?id=191773
2073         <rdar://problem/46139932>
2074
2075         Reviewed by Devin Rousso.
2076
2077         * WebCoreSupport/WebInspectorClient.h:
2078         * WebCoreSupport/WebInspectorClient.mm:
2079         (WebInspectorFrontendClient::reopen):
2080
2081 2018-11-17  Devin Rousso  <drousso@apple.com>
2082
2083         Web Inspector: Network: add button to show system certificate dialog
2084         https://bugs.webkit.org/show_bug.cgi?id=191458
2085         <rdar://problem/45977019>
2086
2087         Reviewed by Joseph Pecoraro.
2088
2089         * WebCoreSupport/WebInspectorClient.h:
2090         * WebCoreSupport/WebInspectorClient.mm:
2091         (WebInspectorFrontendClient::showCertificate): Added.
2092
2093         * Configurations/WebKitLegacy.xcconfig:
2094
2095 2018-11-15  Truitt Savell  <tsavell@apple.com>
2096
2097         Unreviewed, rolling out r238244.
2098
2099         Caused High Sierra test runs to fail early with 50 crashes and
2100         casued 25 API failures.
2101
2102         Reverted changeset:
2103
2104         "[css-logical] Implement flow-relative margin, padding and
2105         border shorthands"
2106         https://bugs.webkit.org/show_bug.cgi?id=188697
2107         https://trac.webkit.org/changeset/238244
2108
2109 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2110
2111         [css-logical] Implement flow-relative margin, padding and border shorthands
2112         https://bugs.webkit.org/show_bug.cgi?id=188697
2113
2114         Reviewed by Simon Fraser and Antti Koivisto.
2115
2116         Add CSSLogicalEnabled runtime flag.
2117
2118         * WebView/WebPreferenceKeysPrivate.h:
2119         * WebView/WebPreferences.mm:
2120         (+[WebPreferences initialize]):
2121         (-[WebPreferences cssLogicalEnabled]):
2122         (-[WebPreferences setCSSLogicalEnabled:]):
2123         * WebView/WebPreferencesPrivate.h:
2124         * WebView/WebView.mm:
2125         (-[WebView _preferencesChanged:]):
2126
2127 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2128
2129         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2130         https://bugs.webkit.org/show_bug.cgi?id=191612
2131
2132         Reviewed by Matt Baker.
2133
2134         * WebCoreSupport/WebInspectorClient.mm:
2135         (-[WebInspectorWindowController destroyInspectorView]):
2136
2137 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2138
2139         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2140         https://bugs.webkit.org/show_bug.cgi?id=191494
2141         <rdar://problem/45469854>
2142
2143         Reviewed by Devin Rousso.
2144
2145         * WebCoreSupport/WebInspectorClient.h:
2146         WebKitLegacy will still have remote inspection of the Page directly.
2147
2148 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2149
2150         Make compositing updates incremental
2151         https://bugs.webkit.org/show_bug.cgi?id=90342
2152
2153         Reviewed by Antti Koivisto.
2154
2155         Fix spelling error.
2156
2157         * WebView/WebView.mm:
2158         (-[WebView _setMediaLayer:forPluginView:]):
2159
2160 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2161
2162         Implement a new edit command to change the enclosing list type
2163         https://bugs.webkit.org/show_bug.cgi?id=191487
2164         <rdar://problem/45955922>
2165
2166         Reviewed by Ryosuke Niwa.
2167
2168         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2169
2170         * WebCoreSupport/WebEditorClient.mm:
2171         (undoNameForEditAction):
2172
2173 2018-11-11  Daniel Bates  <dabates@apple.com>
2174
2175         [iOS] Draw caps lock indicator in password fields
2176         https://bugs.webkit.org/show_bug.cgi?id=190565
2177         <rdar://problem/45262343>
2178
2179         Reviewed by Dean Jackson.
2180
2181         Update the caps lock state when a hardware keyboard is attached or detached.
2182
2183         * WebView/WebHTMLView.mm:
2184         (hardwareKeyboardAvailabilityChangedCallback): Added.
2185         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2186         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2187
2188 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2189
2190         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2191         https://bugs.webkit.org/show_bug.cgi?id=191492
2192
2193         Reviewed by Alex Christensen.
2194
2195         * Carbon/HIWebView.mm:
2196         * Misc/WebNSFileManagerExtras.mm:
2197         * Misc/WebNSURLExtras.mm:
2198         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2199         * Plugins/WebBasePluginPackage.mm:
2200         * Plugins/WebPluginContainerCheck.mm:
2201         * WebCoreSupport/WebCachedFramePlatformData.h:
2202         * WebCoreSupport/WebDeviceOrientationClient.mm:
2203         * WebView/WebDelegateImplementationCaching.mm:
2204         * WebView/WebHTMLView.mm:
2205         * WebView/WebPDFRepresentation.mm:
2206         * WebView/WebPolicyDelegate.mm:
2207         * WebView/WebView.mm:
2208
2209 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2210
2211         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2212         https://bugs.webkit.org/show_bug.cgi?id=191492
2213
2214         Reviewed by Alex Christensen.
2215
2216         * Carbon/HIWebView.mm:
2217         (UpdateCommandStatus):
2218         * Misc/WebNSFileManagerExtras.mm:
2219         * Misc/WebNSURLExtras.mm:
2220         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2221         * Plugins/WebBasePluginPackage.mm:
2222         * Plugins/WebPluginContainerCheck.mm:
2223         (-[WebPluginContainerCheck _continueWithPolicy:]):
2224         * WebCoreSupport/WebCachedFramePlatformData.h:
2225         (WebCachedFramePlatformData::clear):
2226         * WebCoreSupport/WebDeviceOrientationClient.mm:
2227         (WebDeviceOrientationClient::getProvider const):
2228         * WebView/WebDelegateImplementationCaching.mm:
2229         (CallDelegate):
2230         (CallDelegateReturningBoolean):
2231         (CallResourceLoadDelegateReturningBoolean):
2232         (CallFormDelegate):
2233         (CallFormDelegateReturningBoolean):
2234         * WebView/WebHTMLView.mm:
2235         * WebView/WebPDFRepresentation.mm:
2236         * WebView/WebPolicyDelegate.mm:
2237         (-[WebPolicyDecisionListener _usePolicy:]):
2238         * WebView/WebView.mm:
2239
2240 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2241
2242         Unreviewed, rolling out r238047.
2243
2244         Introduced layout test failures on iOS simulator.
2245
2246         Reverted changeset:
2247
2248         "[iOS] Draw caps lock indicator in password fields"
2249         https://bugs.webkit.org/show_bug.cgi?id=190565
2250         https://trac.webkit.org/changeset/238047
2251
2252 2018-11-09  Antti Koivisto  <antti@apple.com>
2253
2254         Use OptionSet for layout milestones
2255         https://bugs.webkit.org/show_bug.cgi?id=191470
2256
2257         Reviewed by Dean Jackson.
2258
2259         * WebCoreSupport/WebFrameLoaderClient.h:
2260         * WebCoreSupport/WebFrameLoaderClient.mm:
2261         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2262         * WebView/WebView.mm:
2263         (coreLayoutMilestones):
2264         (kitLayoutMilestones):
2265         (-[WebView _cacheFrameLoadDelegateImplementations]):
2266         * WebView/WebViewInternal.h:
2267
2268 2018-11-09  Daniel Bates  <dabates@apple.com>
2269
2270         [iOS] Draw caps lock indicator in password fields
2271         https://bugs.webkit.org/show_bug.cgi?id=190565
2272         <rdar://problem/45262343>
2273
2274         Reviewed by Dean Jackson.
2275
2276         Update the caps lock state when a hardware keyboard is attached or detached.
2277
2278         * WebView/WebHTMLView.mm:
2279         (hardwareKeyboardAvailabilityChangedCallback): Added.
2280         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2281         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2282
2283 2018-11-09  Daniel Bates  <dabates@apple.com>
2284
2285         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2286         action when forward delete is pressed outside a text field
2287         https://bugs.webkit.org/show_bug.cgi?id=190566
2288         <rdar://problem/45262367>
2289
2290         Reviewed by Wenson Hsieh.
2291
2292         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2293         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2294         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2295
2296         * WebView/WebHTMLView.mm:
2297         (-[WebHTMLView _handleEditingKeyEvent:]):
2298
2299 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2300
2301         Adopt Reveal Framework to replace Lookup
2302         https://bugs.webkit.org/show_bug.cgi?id=191097
2303         <rdar://problem/45924508>
2304
2305         Reviewed by Tim Horton.
2306
2307         Pass in what it needed to clear the textIndicators. This is better than
2308         the current notification structure.
2309
2310         * WebView/WebView.mm:
2311         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2312         (-[WebView _prepareForDictionaryLookup]):
2313
2314 2018-11-06  Justin Fan  <justin_fan@apple.com>
2315
2316         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2317         https://bugs.webkit.org/show_bug.cgi?id=191291
2318
2319         Reviewed by Myles Maxfield.
2320
2321         Properly disable WEBGPU on all non-Metal platforms for now.
2322
2323         * Configurations/FeatureDefines.xcconfig:
2324
2325 2018-11-02  Daniel Bates  <dabates@apple.com>
2326
2327         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2328         https://bugs.webkit.org/show_bug.cgi?id=190487
2329
2330         Reviewed by Tim Horton.
2331
2332         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2333         allow the default handling.
2334
2335         * WebView/WebHTMLView.mm:
2336         (-[WebHTMLView _handleEditingKeyEvent:]):
2337
2338 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2339
2340         Add a storage limit for IndexedDB
2341         https://bugs.webkit.org/show_bug.cgi?id=190598
2342         <rdar://problem/44654715>
2343
2344         Reviewed by Chris Dumez.
2345
2346         * Storage/WebDatabaseManager.mm:
2347         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2348         * Storage/WebDatabaseManagerPrivate.h:
2349
2350 2018-10-31  Antti Koivisto  <antti@apple.com>
2351
2352         Remove LayerFlushScheduler
2353         https://bugs.webkit.org/show_bug.cgi?id=191103
2354
2355         Reviewed by Anders Carlsson.
2356
2357         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2358         all the virtual cruft.
2359
2360         * WebView/WebViewData.h:
2361         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2362         (): Deleted.
2363         * WebView/WebViewData.mm:
2364         (currentRunLoop):
2365         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2366         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2367         (WebViewLayerFlushScheduler::schedule):
2368         (WebViewLayerFlushScheduler::invalidate):
2369         (WebViewLayerFlushScheduler::layerFlushCallback):
2370
2371 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2372
2373         Enable InstallAPI for iOS unconditionally
2374         https://bugs.webkit.org/show_bug.cgi?id=191043
2375         rdar://problem/32728423
2376
2377         Reviewed by Dan Bernstein.
2378
2379         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2380         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2381         shouldn't be processed by InstallAPI.
2382         * MigrateHeaders.make: Removed an obsolete workaround.
2383         * Misc/NSURLDownloadSPI.h: Added.
2384         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2385
2386 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2387
2388         Clean up some obsolete MAX_ALLOWED macros
2389         https://bugs.webkit.org/show_bug.cgi?id=190916
2390
2391         Reviewed by Tim Horton.
2392
2393         * WebView/WebHTMLView.mm:
2394         (-[WebHTMLView pressureChangeWithEvent:]):
2395         * WebView/WebPDFView.h:
2396
2397 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2398
2399         Unreviewed, rolling out r237600 and r237604.
2400         https://bugs.webkit.org/show_bug.cgi?id=191086
2401
2402         Breaks internal iOS builds (Requested by ryanhadd_ on
2403         #webkit).
2404
2405         Reverted changesets:
2406
2407         "Enable InstallAPI for iOS unconditionally"
2408         https://bugs.webkit.org/show_bug.cgi?id=191043
2409         https://trac.webkit.org/changeset/237600
2410
2411         "Build fix attempt after enabling InstallAPI for iOS."
2412         https://bugs.webkit.org/show_bug.cgi?id=191043
2413         https://trac.webkit.org/changeset/237604
2414
2415 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2416
2417         Enable InstallAPI for iOS unconditionally
2418         https://bugs.webkit.org/show_bug.cgi?id=191043
2419         rdar://problem/32728423
2420
2421         Reviewed by Dan Bernstein.
2422
2423         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2424         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2425         shouldn't be processed by InstallAPI.
2426         * MigrateHeaders.make: Removed an obsolete workaround.
2427         * Misc/NSURLDownloadSPI.h: Added.
2428         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2429
2430 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2431
2432         Modernize WebKit nibs and lprojs for localization's sake
2433         https://bugs.webkit.org/show_bug.cgi?id=190911
2434         <rdar://problem/45349466>
2435
2436         Reviewed by Dan Bernstein.
2437
2438         * Misc/WebNSControlExtras.m:
2439         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2440         NSWindow and its contents are both in the same scale space these days; avoid
2441         double-applying the scale factor, or you can't see the prompt.
2442
2443         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2444         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2445         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2446         NIB->XIB
2447
2448 2018-10-25  Antoine Quint  <graouts@apple.com>
2449
2450         [Web Animations] Turn Web Animations CSS Integration off by default
2451         https://bugs.webkit.org/show_bug.cgi?id=190901
2452
2453         Reviewed by Dean Jackson.
2454
2455         * WebView/WebPreferences.mm:
2456         (+[WebPreferences initialize]):
2457
2458 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2459
2460         Clean up some obsolete macOS version guards
2461         https://bugs.webkit.org/show_bug.cgi?id=190887
2462
2463         Reviewed by Dan Bernstein.
2464
2465         * Misc/WebNSPasteboardExtras.mm:
2466         (+[NSPasteboard _web_dragTypesForURL]):
2467         * WebCoreSupport/PopupMenuMac.mm:
2468         (PopupMenuMac::show):
2469         * WebCoreSupport/WebEditorClient.h:
2470         * WebCoreSupport/WebEditorClient.mm:
2471         (WebEditorClient::respondToChangedSelection):
2472         * WebView/WebPDFView.mm:
2473         (-[WebPDFView _clipViewForPDFDocumentView]):
2474
2475 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2476
2477         Turn on Conic Gradients
2478         https://bugs.webkit.org/show_bug.cgi?id=190810
2479
2480         Reviewed by Tim Horton.
2481
2482         * Configurations/FeatureDefines.xcconfig:
2483
2484 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2485
2486         Cleanup: MIMETypeRegistry functions
2487         https://bugs.webkit.org/show_bug.cgi?id=190838
2488
2489         Reviewed by Simon Fraser.
2490
2491         * Misc/WebNSPasteboardExtras.mm:
2492         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2493         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2494         because they were identical.
2495
2496         * WebView/WebHTMLRepresentation.mm:
2497         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2498         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2499         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2500         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2501         * WebView/WebView.mm:
2502         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2503         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2504         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2505
2506 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2507
2508         Fix false positive leaks when using custom -init methods that don't start with -init
2509         <https://webkit.org/b/190818>
2510         <rdar://problem/45476042>
2511
2512         Reviewed by Dan Bernstein.
2513
2514         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2515         it is accessible by both categories.
2516         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2517         NSError (WebKitInternal) category.  Add attribute to make this
2518         behave like an -init method.
2519         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2520         NSError (WebKitInternal) category.  Modernize method.  Replace
2521         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2522
2523 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2524
2525         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2526         https://bugs.webkit.org/show_bug.cgi?id=190729
2527
2528         Reviewed by Tim Horton.
2529
2530         * DOM/DOM.mm:
2531         (-[DOMNode boundingBox]):
2532         * DOM/DOMElement.mm:
2533         * DOM/DOMHTML.mm:
2534         * DOM/DOMInternal.mm:
2535         * DOM/DOMUIKitExtensions.mm:
2536         * DOM/WebDOMOperations.mm:
2537         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2538         * DefaultDelegates/WebDefaultEditingDelegate.m:
2539         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2540         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2541         * DefaultDelegates/WebDefaultUIDelegate.h:
2542         * DefaultDelegates/WebDefaultUIDelegate.mm:
2543         (-[WebDefaultUIDelegate webViewClose:]):
2544         (-[WebDefaultUIDelegate webViewFocus:]):
2545         (-[WebDefaultUIDelegate webViewUnfocus:]):
2546         (-[WebDefaultUIDelegate webViewIsResizable:]):
2547         (-[WebDefaultUIDelegate webView:setResizable:]):
2548         (-[WebDefaultUIDelegate webView:setFrame:]):
2549         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2550         * History/BackForwardList.h:
2551         * History/BackForwardList.mm:
2552         * History/WebBackForwardList.mm:
2553         (+[WebBackForwardList initialize]):
2554         (bumperCarBackForwardHackNeeded):
2555         * History/WebHistory.mm:
2556         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2557         (-[WebHistory _sendNotification:entries:]):
2558         (-[WebHistory loadFromURL:error:]):
2559         (-[WebHistory saveToURL:error:]):
2560         * History/WebHistoryItem.mm:
2561         (WKNotifyHistoryItemChanged):
2562         (+[WebHistoryItem initialize]):
2563         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2564         * History/WebURLsWithTitles.m:
2565         * Misc/WebCache.mm:
2566         (+[WebCache initialize]):
2567         * Misc/WebDownload.mm:
2568         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2569         * Misc/WebElementDictionary.mm:
2570         (+[WebElementDictionary initialize]):
2571         (+[WebElementDictionary initializeLookupTable]):
2572         * Misc/WebIconDatabase.mm:
2573         * Misc/WebKitNSStringExtras.mm:
2574         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2575         * Misc/WebKitVersionChecks.h:
2576         * Misc/WebKitVersionChecks.mm:
2577         (WebKitLinkedOnOrAfter):
2578         (WebKitLinkTimeVersion):
2579         * Misc/WebLocalizableStrings.mm:
2580         * Misc/WebNSControlExtras.h:
2581         * Misc/WebNSControlExtras.m:
2582         * Misc/WebNSEventExtras.m:
2583         * Misc/WebNSFileManagerExtras.mm:
2584         * Misc/WebNSImageExtras.h:
2585         * Misc/WebNSImageExtras.m:
2586         * Misc/WebNSPasteboardExtras.mm:
2587         * Misc/WebNSPrintOperationExtras.h:
2588         * Misc/WebNSPrintOperationExtras.m:
2589         * Misc/WebNSViewExtras.m:
2590         * Misc/WebNSWindowExtras.m:
2591         * Panels/WebAuthenticationPanel.h:
2592         * Panels/WebAuthenticationPanel.m:
2593         * Panels/WebPanelAuthenticationHandler.m:
2594         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2595         (+[WebHostedNetscapePluginView initialize]):
2596         * Plugins/WebBasePluginPackage.h:
2597         * Plugins/WebBasePluginPackage.mm:
2598         * Plugins/WebJavaPlugIn.h:
2599         * Plugins/WebPluginContainerCheck.mm:
2600         * Plugins/WebPluginController.h:
2601         * Plugins/WebPluginController.mm:
2602         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2603         (-[WebPluginController addPlugin:]):
2604         (-[WebPluginController destroyPlugin:]):
2605         (-[WebPluginController destroyAllPlugins]):
2606         * Plugins/WebPluginDatabase.mm:
2607         (+[WebPluginDatabase _defaultPlugInPaths]):
2608         * Plugins/WebPluginPackage.mm:
2609         (-[WebPluginPackage initWithPath:]):
2610         * Storage/WebDatabaseManager.mm:
2611         (-[WebDatabaseManager deleteAllDatabases]):
2612         * Storage/WebDatabaseManagerClient.h:
2613         * Storage/WebDatabaseManagerClient.mm:
2614         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2615         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2616         * Storage/WebStorageManager.mm:
2617         (-[WebStorageManager deleteAllOrigins]):
2618         (WebKitInitializeStorageIfNecessary):
2619         * WebCoreSupport/WebAlternativeTextClient.h:
2620         * WebCoreSupport/WebApplicationCache.mm:
2621         (applicationCacheBundleIdentifier):
2622         * WebCoreSupport/WebChromeClient.h:
2623         * WebCoreSupport/WebChromeClient.mm:
2624         (WebChromeClient::setWindowRect):
2625         (WebChromeClient::windowRect):
2626         (WebChromeClient::takeFocus):
2627         (WebChromeClient::addMessageToConsole):
2628         (WebChromeClient::enableSuddenTermination):
2629         (WebChromeClient::disableSuddenTermination):
2630         (WebChromeClient::createPopupMenu const):
2631         (WebChromeClient::createSearchPopupMenu const):
2632         (WebChromeClient::shouldPaintEntireContents const):
2633         (WebChromeClient::supportsVideoFullscreen):
2634         (WebChromeClient::supportsFullScreenForElement):
2635         (WebChromeClient::enterFullScreenForElement):
2636         (WebChromeClient::exitFullScreenForElement):
2637         * WebCoreSupport/WebContextMenuClient.mm:
2638         * WebCoreSupport/WebDragClient.mm:
2639         * WebCoreSupport/WebEditorClient.h:
2640         * WebCoreSupport/WebEditorClient.mm:
2641         (+[WebUndoStep initialize]):
2642         (updateFontPanel):
2643         (WebEditorClient::didBeginEditing):
2644         (WebEditorClient::respondToChangedContents):
2645         (WebEditorClient::respondToChangedSelection):
2646         (WebEditorClient::canceledComposition):
2647         (WebEditorClient::didEndEditing):
2648         (WebEditorClient::didWriteSelectionToPasteboard):
2649         (attributesForAttributedStringConversion):
2650         (WebEditorClient::setInsertionPasteboard):
2651         (WebEditorClient::registerUndoOrRedoStep):
2652         (WebEditorClient::handleKeyboardEvent):
2653         (WebEditorClient::handleInputMethodKeydown):
2654         (WebEditorClient::textDidChangeInTextField):
2655         (WebEditorClient::requestCheckingOfString):
2656         * WebCoreSupport/WebFrameLoaderClient.h:
2657         * WebCoreSupport/WebFrameLoaderClient.mm:
2658         (WebFrameLoaderClient::detachedFromParent2):
2659         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2660         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2661         (WebFrameLoaderClient::dispatchWillSendRequest):
2662         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2663         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2664         (WebFrameLoaderClient::willCacheResponse const):
2665         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2666         (WebFrameLoaderClient::dispatchDidFinishLoading):
2667         (WebFrameLoaderClient::dispatchDidFailLoading):
2668         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2669         (WebFrameLoaderClient::dispatchWillClose):
2670         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2671         (WebFrameLoaderClient::dispatchDidCommitLoad):
2672         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2673         (WebFrameLoaderClient::dispatchDidFailLoad):
2674         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2675         (WebFrameLoaderClient::dispatchDidFinishLoad):
2676         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2677         (WebFrameLoaderClient::willChangeTitle):
2678         (WebFrameLoaderClient::didChangeTitle):
2679         (WebFrameLoaderClient::didReplaceMultipartContent):
2680         (WebFrameLoaderClient::updateGlobalHistory):
2681         (WebFrameLoaderClient::saveViewStateToItem):
2682         (WebFrameLoaderClient::restoreViewState):
2683         (WebFrameLoaderClient::provisionalLoadStarted):
2684         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2685         (WebFrameLoaderClient::setTitle):
2686         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2687         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2688         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2689         (WebFrameLoaderClient::didRestoreFromPageCache):
2690         (WebFrameLoaderClient::actionDictionary const):
2691         (WebFrameLoaderClient::createPlugin):
2692         (WebFrameLoaderClient::getLoadDecisionForIcons):
2693         (WebFrameLoaderClient::finishedLoadingIcon):
2694         (+[WebFramePolicyListener initialize]):
2695         * WebCoreSupport/WebFrameNetworkingContext.mm:
2696         * WebCoreSupport/WebGeolocationClient.h:
2697         * WebCoreSupport/WebGeolocationClient.mm:
2698         (WebGeolocationClient::requestPermission):
2699         * WebCoreSupport/WebInspectorClient.h:
2700         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2701         * WebCoreSupport/WebNotificationClient.mm:
2702         * WebCoreSupport/WebOpenPanelResultListener.mm:
2703         * WebCoreSupport/WebPlatformStrategies.h:
2704         * WebCoreSupport/WebPlatformStrategies.mm:
2705         * WebCoreSupport/WebProgressTrackerClient.h:
2706         * WebCoreSupport/WebProgressTrackerClient.mm:
2707         (WebProgressTrackerClient::progressStarted):
2708         (WebProgressTrackerClient::progressEstimateChanged):
2709         (WebProgressTrackerClient::progressFinished):
2710         * WebCoreSupport/WebSecurityOrigin.mm:
2711         * WebInspector/WebNodeHighlight.h:
2712         * WebInspector/WebNodeHighlight.mm:
2713         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2714         (-[WebNodeHighlight dealloc]):
2715         (-[WebNodeHighlight attach]):
2716         * WebInspector/WebNodeHighlightView.h:
2717         * WebInspector/WebNodeHighlightView.mm:
2718         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2719         (-[WebNodeHighlightView dealloc]):
2720         * WebInspector/WebNodeHighlighter.mm:
2721         (-[WebNodeHighlighter highlight]):
2722         * WebView/WebArchive.mm:
2723         (+[WebArchivePrivate initialize]):
2724         * WebView/WebClipView.h:
2725         * WebView/WebDataSource.mm:
2726         (WebDataSourcePrivate::WebDataSourcePrivate):
2727         (+[WebDataSource initialize]):
2728         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2729         (-[WebDataSource _makeRepresentation]):
2730         * WebView/WebDelegateImplementationCaching.h:
2731         * WebView/WebDelegateImplementationCaching.mm:
2732         (CallDelegate):
2733         (CallDelegateReturningFloat):
2734         (CallDelegateReturningBoolean):
2735         (CallUIDelegate):
2736         (CallUIDelegateReturningFloat):
2737         (CallUIDelegateReturningBoolean):
2738         (CallFrameLoadDelegate):
2739         (CallFrameLoadDelegateReturningBoolean):
2740         (CallResourceLoadDelegate):
2741         (CallScriptDebugDelegate):
2742         (CallFormDelegate):
2743         (CallFormDelegateReturningBoolean):
2744         * WebView/WebDeviceOrientation.mm:
2745         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2746         * WebView/WebDocumentInternal.h:
2747         * WebView/WebDocumentLoaderMac.mm:
2748         (needsDataLoadWorkaround):
2749         * WebView/WebDynamicScrollBarsViewInternal.h:
2750         * WebView/WebFormDelegate.m:
2751         * WebView/WebFrame.mm:
2752         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2753         (-[WebFrame _unmarkAllMisspellings]):
2754         (-[WebFrame _paintBehaviorForDestinationContext:]):
2755         (-[WebFrame _drawRect:contentsOnly:]):
2756         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2757         (-[WebFrame _scrollDOMRangeToVisible:]):
2758         (-[WebFrame _bodyBackgroundColor]):
2759         (-[WebFrame accessibilityRoot]):
2760         (needsMicrosoftMessengerDOMDocumentWorkaround):
2761         * WebView/WebFrameInternal.h:
2762         * WebView/WebFrameView.mm:
2763         (-[WebFrameView _setDocumentView:]):
2764         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2765         (-[WebFrameView _viewClassForMIMEType:]):
2766         (-[WebFrameView initWithFrame:]):
2767         (-[WebFrameView drawRect:]):
2768         (-[WebFrameView _firstResponderIsFormControl]):
2769         (-[WebFrameView keyDown:keyDown:]):
2770         (-[WebFrameView _isScrollable]):
2771         * WebView/WebFullScreenController.h:
2772         * WebView/WebFullScreenController.mm:
2773         * WebView/WebHTMLRepresentation.mm:
2774         * WebView/WebHTMLView.mm:
2775         (-[WebHTMLView hitTest:]):
2776         (-[WebHTMLView initWithFrame:]):
2777         (-[WebHTMLView dealloc]):
2778         (-[WebHTMLView addSubview:]):
2779         (-[WebHTMLView mouseDown:]):
2780         (-[WebHTMLView mouseUp:]):
2781         (-[WebHTMLView resignFirstResponder]):
2782         (-[WebHTMLView accessibilityHitTest:]):
2783         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2784         * WebView/WebHTMLViewInternal.h:
2785         * WebView/WebIndicateLayer.h:
2786         * WebView/WebIndicateLayer.mm:
2787         * WebView/WebMediaPlaybackTargetPicker.h:
2788         * WebView/WebMediaPlaybackTargetPicker.mm:
2789         * WebView/WebPDFDocumentExtras.h:
2790         * WebView/WebPDFDocumentExtras.mm:
2791         * WebView/WebPDFRepresentation.h:
2792         * WebView/WebPDFRepresentation.mm:
2793         * WebView/WebPDFView.h:
2794         * WebView/WebPreferences.mm:
2795         (cacheModelForMainBundle):
2796         (WebPreferencesPrivate::WebPreferencesPrivate):
2797         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2798         (-[WebPreferences encodeWithCoder:]):
2799         (+[WebPreferences standardPreferences]):
2800         (+[WebPreferences initialize]):
2801         (-[WebPreferences _valueForKey:]):
2802         (-[WebPreferences _setStringValue:forKey:]):
2803         (-[WebPreferences _setIntegerValue:forKey:]):
2804         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2805         (-[WebPreferences _setFloatValue:forKey:]):
2806         (-[WebPreferences _setBoolValue:forKey:]):
2807         (-[WebPreferences _setLongLongValue:forKey:]):
2808         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2809         (-[WebPreferences _postCacheModelChangedNotification]):
2810         (-[WebPreferences _postPreferencesChangedNotification]):
2811         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2812         (-[WebPreferences setStorageBlockingPolicy:]):
2813         * WebView/WebResource.mm:
2814         (+[WebResourcePrivate initialize]):
2815         * WebView/WebTextCompletionController.h:
2816         * WebView/WebTextIterator.mm:
2817         (+[WebTextIteratorPrivate initialize]):
2818         * WebView/WebView.mm:
2819         (shouldEnableLoadDeferring):
2820         (shouldRestrictWindowFocus):
2821         (shouldRespectPriorityInCSSAttributeSetters):
2822         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2823         (shouldAllowPictureInPictureMediaPlayback):
2824         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2825         (shouldAllowWindowOpenWithoutUserGesture):
2826         (shouldConvertInvalidURLsToBlank):
2827         (shouldRequireUserGestureToLoadVideo):
2828         (-[WebView _commonInitializationWithFrameName:groupName:]):
2829         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2830         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2831         (-[WebView _closePluginDatabases]):
2832         (-[WebView _closeWithFastTeardown]):
2833         (-[WebView _close]):
2834         (+[WebView _MIMETypeForFile:]):
2835         (-[WebView setShowingInspectorIndication:]):
2836         (-[WebView _setFormDelegate:]):
2837         (-[WebView _needsPreHTML5ParserQuirks]):
2838         (-[WebView _preferencesChangedNotification:]):
2839         (-[WebView _preferencesChanged:]):
2840         (-[WebView _cacheResourceLoadDelegateImplementations]):
2841         (-[WebView _cacheFrameLoadDelegateImplementations]):
2842         (-[WebView _policyDelegateForwarder]):
2843         (-[WebView _UIDelegateForwarder]):
2844         (-[WebView _editingDelegateForwarder]):
2845         (-[WebView _updateActiveState]):
2846         (-[_WebSafeForwarder forwardInvocation:]):
2847         (+[WebView initialize]):
2848         (-[WebView _pluginForMIMEType:]):
2849         (-[WebView _pluginForExtension:]):
2850         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2851         (+[WebView canShowMIMETypeAsHTML:]):
2852         (-[WebView _initWithArguments:]):
2853         (-[WebView initWithFrame:frameName:groupName:]):
2854         (-[WebView dealloc]):
2855         (-[WebView close]):
2856         (-[WebView viewDidMoveToWindow]):
2857         (-[WebView setUIDelegate:]):
2858         (-[WebView setResourceLoadDelegate:]):
2859         (-[WebView setPolicyDelegate:]):
2860         (-[WebView setFrameLoadDelegate:]):
2861         (-[WebView goBack]):
2862         (-[WebView goForward]):
2863         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2864         (-[WebView setHostWindow:]):
2865         (-[WebView becomeFirstResponder]):
2866         (+[WebView _cacheModelChangedNotification:]):
2867         (-[WebView _frameViewAtWindowPoint:]):
2868         (+[WebView _preflightSpellCheckerNow:]):
2869         (+[WebView _preflightSpellChecker]):
2870         (-[WebView canGoBack]):
2871         (-[WebView canGoForward]):
2872         (-[WebView stopLoading:]):
2873         (-[WebView reload:]):
2874         (-[WebView setMainFrameDocumentReady:]):
2875         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2876         (-[WebView setContinuousSpellCheckingEnabled:]):
2877         (-[WebView undoManager]):
2878         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2879         (-[WebView isAutomaticLinkDetectionEnabled]):
2880         (-[WebView isAutomaticDashSubstitutionEnabled]):
2881         (-[WebView isAutomaticTextReplacementEnabled]):
2882         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2883         (+[WebView _setCacheModel:]):
2884         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2885         (-[WebView _keyboardUIMode]):
2886         (LayerFlushController::flushLayers):
2887         (-[WebView _scheduleCompositingLayerFlush]):
2888         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2889         (-[WebView fullScreenPlaceholderView]):
2890         (WebInstallMemoryPressureHandler):
2891         * WebView/WebViewData.h:
2892         * WebView/WebViewData.mm:
2893         (+[WebViewPrivate initialize]):
2894         (-[WebViewPrivate init]):
2895         (-[WebViewPrivate dealloc]):
2896         * WebView/WebViewInternal.h:
2897
2898 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2899
2900         Clean up FrameLoader two-state enums
2901         https://bugs.webkit.org/show_bug.cgi?id=190731
2902
2903         Reviewed by Chris Dumez.
2904
2905         * WebCoreSupport/WebFrameLoaderClient.h:
2906         * WebCoreSupport/WebFrameLoaderClient.mm:
2907         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2908
2909 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2910
2911         Unreviewed, rolling out r237137.
2912
2913         SPI is actually used
2914
2915         Reverted changeset:
2916
2917         "Remove unused WebFrame._loadType"
2918         https://bugs.webkit.org/show_bug.cgi?id=190583
2919         https://trac.webkit.org/changeset/237137
2920
2921 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2922
2923         Enable the datalist element by default on iOS and macOS
2924         https://bugs.webkit.org/show_bug.cgi?id=190594
2925         <rdar://problem/45281159>
2926
2927         Reviewed by Ryosuke Niwa and Tim Horton.
2928
2929         * Configurations/FeatureDefines.xcconfig:
2930
2931 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2932
2933         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2934         https://bugs.webkit.org/show_bug.cgi?id=190675
2935
2936         Reviewed by Chris Dumez.
2937
2938         * History/BackForwardList.h:
2939         * History/BackForwardList.mm:
2940         (BackForwardList::backItem):
2941         (BackForwardList::currentItem):
2942         (BackForwardList::forwardItem):
2943         (BackForwardList::backListCount const):
2944         (BackForwardList::forwardListCount const):
2945         (BackForwardList::itemAtIndex):
2946         * History/WebBackForwardList.mm:
2947         (-[WebBackForwardList backItem]):
2948         (-[WebBackForwardList currentItem]):
2949         (-[WebBackForwardList forwardItem]):
2950         (-[WebBackForwardList itemAtIndex:]):
2951
2952 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2953
2954         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2955         https://bugs.webkit.org/show_bug.cgi?id=190526
2956         rdar://problem/45230140
2957
2958         Reviewed by Dean Jackson.
2959
2960         * WebCoreSupport/WebEditorClient.mm:
2961         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2962
2963 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2964
2965         Implement feature flag and bindings for CSS Painting API
2966         https://bugs.webkit.org/show_bug.cgi?id=190237
2967
2968         Reviewed by Ryosuke Niwa.
2969
2970         * Configurations/FeatureDefines.xcconfig:
2971
2972 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2973
2974         Replace HistoryItem* with HistoryItem& where possible
2975         https://bugs.webkit.org/show_bug.cgi?id=190617
2976
2977         Reviewed by Chris Dumez.
2978
2979         * History/BackForwardList.h:
2980         * History/BackForwardList.mm:
2981         (BackForwardList::goToItem):
2982         * History/WebBackForwardList.mm:
2983         (-[WebBackForwardList goToItem:]):
2984         * History/WebHistoryItem.mm:
2985         (WKNotifyHistoryItemChanged):
2986         * History/WebHistoryItemInternal.h:
2987
2988 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2989
2990         Remove unused WebHistoryItem._transientPropertyForKey
2991         https://bugs.webkit.org/show_bug.cgi?id=190606
2992
2993         Reviewed by Chris Dumez.
2994
2995         * History/WebHistoryItem.mm:
2996         * History/WebHistoryItemPrivate.h:
2997
2998 2018-10-15  Justin Fan  <justin_fan@apple.com>
2999
3000         Add WebGPU 2018 feature flag and experimental feature flag
3001         https://bugs.webkit.org/show_bug.cgi?id=190509
3002
3003         Reviewed by Dean Jackson.
3004
3005         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3006         for the 2018 WebGPU prototype.
3007
3008         * Configurations/FeatureDefines.xcconfig:
3009         * WebView/WebPreferenceKeysPrivate.h:
3010         * WebView/WebPreferences.mm:
3011         (+[WebPreferences initialize]):
3012         (-[WebPreferences webGPUEnabled]):
3013         (-[WebPreferences setWebGPUEnabled:]):
3014         * WebView/WebPreferencesPrivate.h:
3015         * WebView/WebView.mm:
3016         (-[WebView _preferencesChanged:]):
3017
3018 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3019
3020         Fix iOS build after r237157
3021
3022         * WebView/WebView.mm:
3023         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3024
3025 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3026
3027         Modernize BackForwardClient.h
3028         https://bugs.webkit.org/show_bug.cgi?id=190610
3029
3030         Reviewed by Chris Dumez.
3031
3032         * History/BackForwardList.h:
3033         * History/BackForwardList.mm:
3034         (BackForwardList::backListCount const):
3035         (BackForwardList::forwardListCount const):
3036         (BackForwardList::backListCount): Deleted.
3037         (BackForwardList::forwardListCount): Deleted.
3038         * History/WebBackForwardList.mm:
3039         (-[WebBackForwardList init]):
3040         * WebCoreSupport/WebFrameLoaderClient.mm:
3041         (WebFrameLoaderClient::canCachePage const):
3042         * WebView/WebFrameView.mm:
3043         (-[WebFrameView keyDown:keyDown:]):
3044         * WebView/WebView.mm:
3045         (-[WebView _commonInitializationWithFrameName:groupName:]):
3046         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3047         (-[WebView _loadBackForwardListFromOtherView:]):
3048         (-[WebView initWithCoder:]):
3049         (-[WebView encodeWithCoder:]):
3050         (-[WebView backForwardList]):
3051         (-[WebView setMaintainsBackForwardList:]):
3052
3053 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3054
3055         Add support for prefers-color-scheme media query
3056         https://bugs.webkit.org/show_bug.cgi?id=190499
3057         rdar://problem/45212025
3058
3059         Reviewed by Dean Jackson.
3060
3061         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3062
3063 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3064
3065         Remove unused WebView._globalHistoryItem
3066         https://bugs.webkit.org/show_bug.cgi?id=190601
3067
3068         Reviewed by Chris Dumez.
3069
3070         * WebCoreSupport/WebFrameLoaderClient.h:
3071         * WebCoreSupport/WebFrameLoaderClient.mm:
3072         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3073         * WebView/WebView.mm:
3074         (-[WebView _globalHistoryItem]): Deleted.
3075         (-[WebView _setGlobalHistoryItem:]): Deleted.
3076         * WebView/WebViewData.h:
3077         * WebView/WebViewInternal.h:
3078         * WebView/WebViewPrivate.h:
3079
3080 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3081
3082         Remove unused parameters from FrameLoaderClient::createFrame
3083         https://bugs.webkit.org/show_bug.cgi?id=190587
3084
3085         Reviewed by Chris Dumez.
3086
3087         * WebCoreSupport/WebFrameLoaderClient.h:
3088         * WebCoreSupport/WebFrameLoaderClient.mm:
3089         (WebFrameLoaderClient::createFrame):
3090
3091 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3092
3093         Remove unused WebFrame._loadType
3094         https://bugs.webkit.org/show_bug.cgi?id=190583
3095
3096         Reviewed by Chris Dumez.
3097
3098         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3099
3100         * WebView/WebFrame.mm:
3101         (toWebFrameLoadType): Deleted.
3102         (-[WebFrame _loadType]): Deleted.
3103         * WebView/WebFramePrivate.h:
3104
3105 2018-10-15  Chris Dumez  <cdumez@apple.com>
3106
3107         Restrict browsing context lookup by name to frames that are related to one another
3108         https://bugs.webkit.org/show_bug.cgi?id=190475
3109
3110         Reviewed by Alex Christensen.
3111
3112         * WebView/WebFrame.mm:
3113         (-[WebFrame findFrameNamed:]):
3114
3115 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3116
3117         Remove InjectedBundle processing of back/forward lists
3118         https://bugs.webkit.org/show_bug.cgi?id=190459
3119
3120         Reviewed by Chris Dumez.
3121
3122         * WebCoreSupport/WebFrameLoaderClient.h:
3123         * WebCoreSupport/WebFrameLoaderClient.mm:
3124         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3125
3126 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3127
3128         [JSC] Remove Option::useAsyncIterator
3129         https://bugs.webkit.org/show_bug.cgi?id=190567
3130
3131         Reviewed by Saam Barati.
3132
3133         * Configurations/FeatureDefines.xcconfig:
3134
3135 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3136
3137         Allow encoding of small enum classes
3138         https://bugs.webkit.org/show_bug.cgi?id=190531
3139
3140         Reviewed by Tim Horton.
3141
3142         * WebCoreSupport/WebFrameLoaderClient.mm:
3143         (-[WebFramePolicyListener dealloc]):
3144
3145 2018-10-11  Keith Rollin  <krollin@apple.com>
3146
3147         CURRENT_ARCH should not be used in Run Script phase.
3148         https://bugs.webkit.org/show_bug.cgi?id=190407
3149         <rdar://problem/45133556>
3150
3151         Reviewed by Alexey Proskuryakov.
3152
3153         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3154         CURRENT_ARCH is not well-defined during this phase (and may even have
3155         the value "undefined") since this phase is run just once per build
3156         rather than once per supported architecture. Migrate away from
3157         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3158         performing an operation for each value, or by picking the first entry
3159         in ARCHS and using that as a representative value.
3160
3161         * Configurations/WebKitLegacy.xcconfig: When generating
3162         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3163         macosx platforms.
3164
3165         * MigrateHeaders.make:
3166         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3167         generate one for each architecture in ARCHS.
3168
3169 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3170
3171         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3172         https://bugs.webkit.org/show_bug.cgi?id=190429
3173
3174         Reviewed by Saam Barati.
3175
3176         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3177
3178         * WebView/WebPDFRepresentation.mm:
3179         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3180
3181 2018-10-08  Justin Fan  <justin_fan@apple.com>
3182
3183         WebGPU: Rename old WebGPU prototype to WebMetal
3184         https://bugs.webkit.org/show_bug.cgi?id=190325
3185         <rdar://problem/44990443>
3186
3187         Reviewed by Dean Jackson.
3188
3189         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3190
3191         * Configurations/FeatureDefines.xcconfig:
3192         * WebView/WebPreferenceKeysPrivate.h:
3193         * WebView/WebPreferences.mm:
3194         (+[WebPreferences initialize]):
3195         (-[WebPreferences webMetalEnabled]):
3196         (-[WebPreferences setWebMetalEnabled:]):
3197         (-[WebPreferences webGPUEnabled]): Deleted.
3198         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3199         * WebView/WebPreferencesPrivate.h:
3200         * WebView/WebView.mm:
3201         (-[WebView _preferencesChanged:]):
3202
3203 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3204
3205         Make <input type=color> a runtime enabled (on-by-default) feature
3206         https://bugs.webkit.org/show_bug.cgi?id=189162
3207
3208         Reviewed by Wenson Hsieh and Tim Horton.
3209
3210         * Configurations/FeatureDefines.xcconfig:
3211
3212 2018-10-07  Dan Bernstein  <mitz@apple.com>
3213
3214         Fixed building with the latest macOS SDK
3215
3216         * Plugins/WebNetscapePluginPackage.mm:
3217         (-[WebNetscapePluginPackage openResourceFile]):
3218         (-[WebNetscapePluginPackage closeResourceFile:]):
3219
3220 2018-10-04  Dan Bernstein  <mitz@apple.com>
3221
3222         More Carbon build-fixing.
3223
3224         * Carbon/CarbonWindowAdapter.mm:
3225         (-[CarbonWindowAdapter _destroyRealWindow:]):
3226         (-[CarbonWindowAdapter _growBoxRect]):
3227
3228 2018-10-04  Dan Bernstein  <mitz@apple.com>
3229
3230         Retried to fix 32-bit macOS builds after r236846.
3231
3232         * WebView/WebHTMLView.mm:
3233         (-[WebHTMLView setMarkedText:selectedRange:]):
3234
3235 2018-10-04  Dan Bernstein  <mitz@apple.com>
3236
3237         Retried to fix 32-bit macOS builds after r236846.
3238
3239         * Carbon/HIWebView.mm:
3240         (ActiveStateChanged):
3241
3242 2018-10-04  Dan Bernstein  <mitz@apple.com>
3243
3244         Tried to fix 32-bit macOS builds after r236846.
3245
3246         * Carbon/HIWebView.mm:
3247         (_NSSelectorForHICommand):
3248
3249 2018-10-04  Dan Bernstein  <mitz@apple.com>
3250
3251         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3252         https://bugs.webkit.org/show_bug.cgi?id=190250
3253
3254         Reviewed by Andy Estes.
3255
3256         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3257           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3258           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3259           an earlier line set it to YES.
3260
3261         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3262         changes below.
3263
3264         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3265           provides some missing method declarations.
3266
3267         * Misc/WebDownload.mm:
3268         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3269           a deprecated method.
3270
3271         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3272
3273         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3274           other code in the file uses a method from it.
3275
3276         * Plugins/WebBaseNetscapePluginView.mm:
3277         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3278           a deprecated method.
3279
3280         * Plugins/WebPluginController.mm:
3281         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3282           around use of a selector that may be present in some WebKit client.
3283
3284         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3285           method declarations.
3286
3287         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3288           from here.
3289
3290         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3291           missing method declarations.
3292
3293         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3294           from here.
3295
3296         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3297           call from here.
3298         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3299           an obsolete delegate method for binary compatibility.
3300         (pluginView): Ditto.
3301
3302         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3303           call from here.
3304
3305         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3306           WebDeviceOrientationProviderMock protocol.
3307
3308         * WebView/WebDeviceOrientationProviderMock.mm:
3309         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3310           main @implementation.
3311
3312         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3313           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3314
3315         * WebView/WebDynamicScrollBarsView.mm:
3316         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3317           of a deprecated method.
3318
3319         * WebView/WebHTMLView.mm:
3320         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3321           selector warning around action methods that are not declared anywhere in WebKit.
3322
3323         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3324           about implementing this deprecated method.
3325         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3326         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3327         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3328         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3329         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3330         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3331         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3332         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3333         (-[WebHTMLView doCommandBySelector:]): Ditto.
3334         (-[WebHTMLView insertText:]): Ditto.
3335
3336         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3337
3338         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3339
3340         * WebView/WebPDFView.h: Removed previewView ivar.
3341
3342         * WebView/WebPDFView.mm:
3343           Removed declaration of FileInternal category and merged its implementation with the main
3344           implementation.
3345         (-[WebPDFView dealloc]): Removed previewView ivar.
3346         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3347           exist in macOS versions we support.
3348         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3349         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3350           action methods internal to PDFKit.
3351         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3352         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3353
3354         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3355           call on macOS, even though in r86988 we started calling different methods on iOS.
3356
3357         * WebView/WebView.mm:
3358         - Imported headers that declare delegate methods that we call.
3359         - Removed declaration of WebFileInternal category and merged its implementation with the
3360           main implementation.
3361         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3362           category, which made them impossible to call from the main implementation. Moved those
3363           into the main implementation. One of those had to be declared in a class extension,
3364           because it is called from a method implemented in the WebPrivate category, and that
3365           category’s implementation appears first in the file.
3366
3367         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3368           around use of obsolete delegate method for binary compatibility.
3369
3370         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3371
3372 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3373
3374         Runtime flag and IDL for MediaRecorder
3375         https://bugs.webkit.org/show_bug.cgi?id=190018
3376
3377         Reviewed by Youenn Fablet and Chris Dumez.
3378
3379         * WebView/WebPreferenceKeysPrivate.h:
3380         * WebView/WebPreferences.mm:
3381         (+[WebPreferences initialize]):
3382         (-[WebPreferences mediaRecorderEnabled]):
3383         (-[WebPreferences setMediaRecorderEnabled:]):
3384         * WebView/WebPreferencesPrivate.h:
3385         * WebView/WebView.mm:
3386         (-[WebView _preferencesChanged:]):
3387
3388 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3389
3390         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3391         https://bugs.webkit.org/show_bug.cgi?id=190238
3392
3393         Reviewed by Antti Koivisto.
3394
3395         Enabled the feature by default.
3396
3397         * WebView/WebPreferences.mm:
3398         (+[WebPreferences initialize]):
3399
3400 2018-10-01  Dean Jackson  <dino@apple.com>
3401
3402         [macOS] Switching to discrete GPU should be done in the UI process
3403         https://bugs.webkit.org/show_bug.cgi?id=189361
3404         <rdar://problem/43949622>
3405
3406         Reviewed by Simon Fraser.
3407
3408         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3409         not support swapping to the discrete GPU in this configuration.
3410
3411         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3412         (WebKit::WebSwitchingGPUClient::singleton):
3413         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3414         * WebView/WebView.mm:
3415         (-[WebView _commonInitializationWithFrameName:groupName:]):
3416
3417 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3418
3419         Remove ParsedURLString
3420         https://bugs.webkit.org/show_bug.cgi?id=190154
3421
3422         Reviewed by Chris Dumez.
3423
3424         * WebView/WebScriptDebugger.mm:
3425         (toNSURL):
3426
3427 2018-10-01  Dean Jackson  <dino@apple.com>
3428
3429         Remove CSS Animation Triggers
3430         https://bugs.webkit.org/show_bug.cgi?id=190175
3431         <rdar://problem/44925626>
3432
3433         Reviewed by Simon Fraser.
3434
3435         * Configurations/FeatureDefines.xcconfig:
3436
3437 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3438
3439         Unreviewed, rolling out r236624 and r236671.
3440         https://bugs.webkit.org/show_bug.cgi?id=190207
3441
3442         The change in r236624 introduced crashes on the bots
3443         (Requested by ryanhaddad on #webkit).
3444
3445         Reverted changesets:
3446
3447         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3448         https://bugs.webkit.org/show_bug.cgi?id=188747
3449         https://trac.webkit.org/changeset/236624
3450
3451         "Unify implementation in VideoFullscreenInterfaceAVKit"
3452         https://bugs.webkit.org/show_bug.cgi?id=190091
3453         https://trac.webkit.org/changeset/236671
3454
3455 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3456
3457         URL should not use TextEncoding internally
3458         https://bugs.webkit.org/show_bug.cgi?id=190111
3459
3460         Reviewed by Andy Estes.
3461
3462         * Misc/WebNSURLExtras.mm:
3463
3464 2018-09-28  Jer Noble  <jer.noble@apple.com>
3465
3466         Refactoring: eliminate raw pointer usage in Fullscreen code
3467         https://bugs.webkit.org/show_bug.cgi?id=188747
3468         <rdar://problem/43541164>
3469
3470         Reviewed by Alex Christensen.
3471
3472         PlaybackSessionInterface no longer has an invalidate() method.
3473
3474         * WebView/WebView.mm:
3475         (-[WebView _clearPlaybackControlsManager]):
3476
3477 2018-09-28  Chris Dumez  <cdumez@apple.com>
3478
3479         Drop support for cross-origin-window-policy header