WeakPtrFactory should populate m_ref lazily.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2
3         WeakPtrFactory should populate m_ref lazily.
4         https://bugs.webkit.org/show_bug.cgi?id=177375
5
6         Reviewed by Geoffrey Garen.
7
8         * WebCoreSupport/WebEditorClient.mm:
9         (WebEditorClient::WebEditorClient):
10         (WebEditorClient::requestCandidatesForSelection):
11
12 2017-09-22  Chris Dumez  <cdumez@apple.com>
13
14         Use high resolution timestamp for event time
15         https://bugs.webkit.org/show_bug.cgi?id=154246
16         <rdar://problem/34333304>
17
18         Reviewed by Ryosuke Niwa.
19
20         Use WallTime / MonotonicTime instead of double type for clarity.
21
22         * DOM/DOMEvent.mm:
23         (-[DOMEvent timeStamp]):
24         * WebView/WebFrame.mm:
25         (-[WebFrame _dragSourceEndedAt:operation:]):
26         * WebView/WebPDFView.mm:
27         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
28
29 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
30
31         Enable dataTransfer.items on macOS and iOS
32         https://bugs.webkit.org/show_bug.cgi?id=177335
33
34         Reviewed by Sam Weinig.
35
36         * WebView/WebPreferences.mm:
37         (+[WebPreferences initialize]):
38
39 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
40
41         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
42         https://bugs.webkit.org/show_bug.cgi?id=177101
43         <rdar://problem/34500648>
44
45         Reviewed by Brian Burg.
46
47         * WebInspector/WebNodeHighlight.mm:
48         Ensure we close the window that we have just removed.
49
50 2017-09-20  Antti Koivisto  <antti@apple.com>
51
52         Remove DOM and styling support for CSS Regions
53         https://bugs.webkit.org/show_bug.cgi?id=177221
54
55         Reviewed by Andreas Kling.
56
57         * Configurations/FeatureDefines.xcconfig:
58         * DOM/DOMCSS.mm:
59         (kitClass):
60         * DOM/DOMElement.mm:
61         (-[DOMElement webkitRegionOverset]): Deleted.
62
63 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
64
65         Layering violation in Editor::createFragment
66         https://bugs.webkit.org/show_bug.cgi?id=176123
67
68         Reviewed by Darin Adler.
69
70         * Misc/WebNSURLExtras.h:
71         * Misc/WebNSURLExtras.mm:
72         * WebView/WebFrame.mm:
73         * WebView/WebHTMLView.mm:
74         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
75
76         * WebCoreSupport/WebEditorClient.mm:
77         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
78         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
79         way to avoid exporting the symbol just on newer OSes.
80
81 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
82
83         On iOS, getData can't get text set by setData during copy event
84         https://bugs.webkit.org/show_bug.cgi?id=176980
85         <rdar://problem/34453915>
86
87         Reviewed by Darin Adler.
88
89         * WebCoreSupport/WebPlatformStrategies.h:
90         * WebCoreSupport/WebPlatformStrategies.mm:
91         (WebPlatformStrategies::copy): Deleted.
92
93 2017-09-18  Andy Estes  <aestes@apple.com>
94
95         [Mac] Upstream miscellaneous WebKitSystemInterface functions
96         https://bugs.webkit.org/show_bug.cgi?id=177029
97
98         Reviewed by Alex Christensen.
99
100         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
101         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
102         * Plugins/Hosted/NetscapePluginHostProxy.mm:
103         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
104         * WebCoreSupport/PopupMenuMac.mm:
105         (PopupMenuMac::show):
106         * WebCoreSupport/WebSystemInterface.mm:
107         (InitWebCoreSystemInterface):
108         * WebView/WebHTMLView.mm:
109         (-[WebHTMLView setDataSource:]):
110         (-[WebHTMLView attachRootLayer:]):
111         * WebView/WebView.mm:
112         (-[WebView _needsAdobeFrameReloadingQuirk]):
113         (-[WebView _needsLinkElementTextCSSQuirk]):
114         (-[WebView _needsIsLoadingInAPISenseQuirk]):
115         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
116         (-[WebView _preferencesChanged:]):
117
118 2017-09-15  Andy Estes  <aestes@apple.com>
119
120         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
121         https://bugs.webkit.org/show_bug.cgi?id=176953
122
123         Reviewed by Eric Carlson.
124
125         * WebCoreSupport/WebSystemInterface.mm:
126         (InitWebCoreSystemInterface):
127
128 2017-09-14  Andy Estes  <aestes@apple.com>
129
130         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
131         https://bugs.webkit.org/show_bug.cgi?id=176931
132
133         Reviewed by Joseph Pecoraro.
134
135         * WebCoreSupport/WebSystemInterface.mm:
136         (InitWebCoreSystemInterface):
137
138 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
139
140         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
141         https://bugs.webkit.org/show_bug.cgi?id=176867
142
143         Reviewed by Sam Weinig.
144
145         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
146         (WebKit::NetscapePluginInstanceProxy::enumerate):
147
148 2017-09-13  Andy Estes  <aestes@apple.com>
149
150         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
151         https://bugs.webkit.org/show_bug.cgi?id=176729
152
153         Reviewed by Alex Christensen.
154
155         * WebCoreSupport/WebSystemInterface.mm:
156         (InitWebCoreSystemInterface):
157         * WebView/WebView.mm:
158         (+[WebView _setCacheModel:]):
159
160 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
161
162         Refactor WebContentReader out of EditorMac and EditorIOS
163         https://bugs.webkit.org/show_bug.cgi?id=176770
164
165         Reviewed by Sam Weinig.
166
167         * WebCoreSupport/WebEditorClient.mm:
168
169 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
170
171         Dragging & dropping a file creates an attachment element even when it's disabled
172         https://bugs.webkit.org/show_bug.cgi?id=176769
173
174         Reviewed by Tim Horton.
175
176         * WebView/WebView.mm:
177         (-[WebView _preferencesChanged:]):
178
179 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
180
181         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
182         https://bugs.webkit.org/show_bug.cgi?id=176721
183         <rdar://problem/34373660>
184
185         Reviewed by Tim Horton.
186
187         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
188         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
189
190         * WebView/WebView.mm:
191         (-[WebView _startDrag:]):
192         (-[WebView _draggedElementBounds]):
193         (-[WebView _endedDataInteraction:global:]):
194         * WebView/WebViewData.h:
195
196 2017-09-11  Andy Estes  <aestes@apple.com>
197
198         [Mac] Upstream QTKit-related WebKitSystemInterface functions
199         https://bugs.webkit.org/show_bug.cgi?id=176472
200
201         Reviewed by Eric Carlson.
202
203         * WebCoreSupport/WebSystemInterface.mm:
204         (InitWebCoreSystemInterface):
205
206 2017-09-09  Mark Lam  <mark.lam@apple.com>
207
208         Avoid duplicate computations of ExecState::vm().
209         https://bugs.webkit.org/show_bug.cgi?id=176647
210
211         Reviewed by Saam Barati.
212
213         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
214         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
215         (WebKit::NetscapePluginInstanceProxy::construct):
216         (WebKit::NetscapePluginInstanceProxy::setProperty):
217         (WebKit::NetscapePluginInstanceProxy::removeProperty):
218         (WebKit::NetscapePluginInstanceProxy::enumerate):
219         * Plugins/Hosted/ProxyInstance.mm:
220         (WebKit::ProxyRuntimeMethod::create):
221
222 2017-09-08  Commit Queue  <commit-queue@webkit.org>
223
224         Unreviewed, rolling out r221773.
225         https://bugs.webkit.org/show_bug.cgi?id=176614
226
227         This caused build failures. (Requested by mlewis13 on
228         #webkit).
229
230         Reverted changeset:
231
232         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
233         https://bugs.webkit.org/show_bug.cgi?id=176472
234         http://trac.webkit.org/changeset/221773
235
236 2017-09-07  Andy Estes  <aestes@apple.com>
237
238         [Mac] Upstream QTKit-related WebKitSystemInterface functions
239         https://bugs.webkit.org/show_bug.cgi?id=176472
240
241         Reviewed by Eric Carlson.
242
243         * WebCoreSupport/WebSystemInterface.mm:
244         (InitWebCoreSystemInterface):
245
246 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
247
248         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
249         https://bugs.webkit.org/show_bug.cgi?id=176561
250
251         Reviewed by Brent Fulgham.
252
253         * Misc/WebNSUserDefaultsExtras.mm:
254
255 2017-09-07  Alex Christensen  <achristensen@webkit.org>
256
257         Modernize Geolocation code
258         https://bugs.webkit.org/show_bug.cgi?id=176496
259
260         Reviewed by Andy Estes.
261
262         * WebCoreSupport/WebGeolocationClient.h:
263         * WebCoreSupport/WebGeolocationClient.mm:
264         (WebGeolocationClient::requestPermission):
265         (-[WebGeolocationPolicyListener initWithGeolocation:]):
266         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
267         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
268         * WebView/WebView.mm:
269         (-[WebView _commonInitializationWithFrameName:groupName:]):
270         (-[WebView _geolocationDidFailWithMessage:]):
271
272 2017-09-05  Tim Horton  <timothy_horton@apple.com>
273
274         Remove some unused bits of code and resources
275         https://bugs.webkit.org/show_bug.cgi?id=176275
276
277         Reviewed by Dan Bernstein.
278
279         * Misc/WebNSFileManagerExtras.mm:
280         Include FileSystem instead of FileSystemIOS.
281
282 2017-09-03  Darin Adler  <darin@apple.com>
283
284         [Cocoa] Tidy a few things in legacy WebHTMLView
285         https://bugs.webkit.org/show_bug.cgi?id=176280
286
287         Reviewed by Dan Bernstein.
288
289         * WebCoreSupport/WebChromeClient.mm:
290         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
291         methods it calls on WebHTMLView were doing nothing on iOS.
292
293         * WebView/WebFrame.mm:
294         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
295         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
296
297         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
298         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
299         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
300         order. Removed all sorts of unused things. Made more code and fields Mac-only where
301         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
302         Use RetainPtr instead of writing retain/release wherever possible.
303         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
304         initialization for it. Removed various unused methods and declarations of methods.
305         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
306         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
307         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
308         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
309         and remove CFRetain no longer needed since we don't support garbage collection any more.
310         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
311         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
312         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
313         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
314         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
315         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
316         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
317         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
318         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
319         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
320         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
321         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
322         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
323         debug flag; we haven't used it for years and it's not clearly helpful.
324         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
325         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
326         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
327         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
328         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
329         two additional methods in the WebPrivate category and still be called by the two
330         methods in the WebInternal category that were already using it.
331         (-[WebHTMLView didAddSubview:]): Deleted.
332         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
333         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
334         place this was called, the close method.
335         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
336         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
337         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
338         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
339         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
340         Added helper method to make the one below simpler.
341         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
342         Compared pasteboard type strings using isEqualToString: rather than using == since
343         we want to actually compare the string contents. Also updated to use modern for loop,
344         renamed a local variable from "s" to "localSubresources", and factored out the handling
345         of three image types to use the helper method above.
346         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
347         _web_makePluginSubviewsPerformSelector:withObject: method.
348         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
349         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
350         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
351         not call the -[NSView subviews] method to make this identical on both platforms and used
352         a modern for loop.
353         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
354         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
355         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
356         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
357         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
358         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
359         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
360         of it is Mac-only.
361         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
362         method did was call itself on the main thread, and do nothing if called on main thread.
363         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
364         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
365         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
366         half of this method.
367         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
368         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
369         Simplified using a modern for loop and RetainPtr.
370         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
371         (-[WebHTMLView keyDown:]): Ditto.
372         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
373         (-[WebHTMLView performKeyEquivalent:]): Ditto.
374         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
375         (-[WebHTMLView complete:]): Ditto.
376         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
377         now macOS-only.
378         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
379         iOS since that is now macOS-only.
380         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
381         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
382         a private one because it is not used or needed outside WebKit. Also made it macOS-only
383         and reorganized to use early return.
384         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
385         on iOS, but kept there so we don't have to do #if at every call site.
386         (-[WebHTMLView _pluginController]): Moved into internal category.
387         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
388         there only for GC, using C++ initialization, removing obsolete comment.
389         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
390         peculiar iOS-only comment.
391         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
392
393         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
394         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
395         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
396         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
397         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
398
399         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
400         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
401         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
402         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
403         them at this time.
404
405 2017-09-03  Sam Weinig  <sam@webkit.org>
406
407         Remove CanvasProxy
408         https://bugs.webkit.org/show_bug.cgi?id=176288
409
410         Reviewed by Yusuke Suzuki.
411
412         CanvasProxy does not appear to be in any current HTML spec
413         and was disabled and unimplemented in our tree. Time to 
414         get rid of it.
415
416         * Configurations/FeatureDefines.xcconfig:
417
418 2017-09-02  Andy Estes  <aestes@apple.com>
419
420         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
421         https://bugs.webkit.org/show_bug.cgi?id=176270
422
423         Reviewed by Tim Horton.
424
425         * Plugins/Hosted/NetscapePluginHostManager.mm:
426         (WebKit::NetscapePluginHostManager::spawnPluginHost):
427         * Plugins/Hosted/WebHostedNetscapePluginView.h:
428         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
429         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
430         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
431         (WebKit::SoftwareCARenderer::context const):
432         (WebKit::SoftwareCARenderer::renderContext const):
433         (WebKit::SoftwareCARenderer::render):
434         (-[WebHostedNetscapePluginView createPlugin]):
435         (-[WebHostedNetscapePluginView createPluginLayer]):
436         (-[WebHostedNetscapePluginView destroyPlugin]):
437         (-[WebHostedNetscapePluginView drawRect:]):
438         * WebCoreSupport/WebSystemInterface.mm:
439         (InitWebCoreSystemInterface):
440
441 2017-09-01  Andy Estes  <aestes@apple.com>
442
443         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
444         https://bugs.webkit.org/show_bug.cgi?id=176200
445
446         Reviewed by Tim Horton.
447
448         * Carbon/HIWebView.mm:
449         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
450         (overrideCGContext):
451         (restoreCGContext):
452         (Draw):
453         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
454         (+[WebHostedNetscapePluginView initialize]):
455         * Plugins/WebBaseNetscapePluginView.h:
456         * Plugins/WebBaseNetscapePluginView.mm:
457         (WebKit::sendUserChangeNotifications):
458         * Plugins/WebNetscapePluginView.mm:
459         (+[WebNetscapePluginView initialize]):
460         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
461         * WebCoreSupport/WebSystemInterface.mm:
462         (InitWebCoreSystemInterface):
463         * WebView/WebFrame.mm:
464         (-[WebFrame _paintBehaviorForDestinationContext:]):
465         * WebView/WebFullScreenController.mm:
466         (setClipRectForWindow):
467         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
468         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
469         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
470         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
471
472 2017-08-31  Andy Estes  <aestes@apple.com>
473
474         [Mac] Upstream AppKit-related WebKitSystemInterface functions
475         https://bugs.webkit.org/show_bug.cgi?id=176175
476
477         Reviewed by Brady Eidson.
478
479         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
480         (WebKit::NetscapePluginInstanceProxy::keyEvent):
481         * Plugins/Hosted/WebTextInputWindowController.m:
482         (-[WebTextInputPanel init]):
483         * WebCoreSupport/WebSystemInterface.mm:
484         (InitWebCoreSystemInterface):
485         * WebView/WebDynamicScrollBarsView.mm:
486         (-[WebDynamicScrollBarsView scrollWheel:]):
487         * WebView/WebHTMLView.mm:
488         (-[WebHTMLView _removeWindowObservers]):
489         (-[WebHTMLView addWindowObservers]):
490         * WebView/WebView.mm:
491         (-[WebView addWindowObserversForWindow:]):
492         (-[WebView removeWindowObservers]):
493         (-[WebView viewWillMoveToWindow:]):
494
495 2017-08-31  Alex Christensen  <achristensen@webkit.org>
496
497         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
498         https://bugs.webkit.org/show_bug.cgi?id=175779
499         <rdar://problem/22367975>
500
501         Reviewed by Tim Horton.
502
503         * WebCoreSupport/WebFrameLoaderClient.h:
504         * WebCoreSupport/WebFrameLoaderClient.mm:
505         (WebFrameLoaderClient::webGLPolicyForURL const):
506         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
507
508 2017-08-30  Andy Estes  <aestes@apple.com>
509
510         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
511         https://bugs.webkit.org/show_bug.cgi?id=176093
512
513         Reviewed by Eric Carlson.
514
515         * WebCoreSupport/WebSystemInterface.mm:
516         (InitWebCoreSystemInterface):
517
518 2017-08-30  Andy Estes  <aestes@apple.com>
519
520         [Mac] Upstream Carbon-related WebKitSystemInterface functions
521         https://bugs.webkit.org/show_bug.cgi?id=176087
522
523         Reviewed by Alex Christensen.
524
525         * Carbon/CarbonUtils.m:
526         (getNSAutoreleasePoolCount):
527         (WebInitForCarbon):
528         (PoolCleaner):
529         * Carbon/CarbonWindowAdapter.mm:
530         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
531         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
532         (-[CarbonWindowAdapter _oldPlaceWindow:]):
533         (-[CarbonWindowAdapter _windowMovedToRect:]):
534         * Carbon/HIViewAdapter.m:
535         * Carbon/HIWebView.mm:
536         (Draw):
537         (CreateNSEventAdoptingCGEvent):
538         (CopyEventCGEvent):
539         (CreateNSEventWithCarbonClickEvent):
540         (Click):
541         (CreateNSEventWithCarbonEvent):
542         (MouseUp):
543         (CreateNSEventWithCarbonMouseMoveEvent):
544         (MouseMoved):
545         (MouseDragged):
546         (MouseWheelMoved):
547         (WindowHandler):
548         (HIWebViewEventHandler):
549         * Misc/QuickDrawCompatibility.h: Removed.
550         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
551         (getCarbonEvent):
552         (WebNetscapePluginEventHandlerCarbon::keyDown):
553         (WebNetscapePluginEventHandlerCarbon::keyUp):
554         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
555         (WebNetscapePluginEventHandlerCocoa::keyDown):
556         * Plugins/WebNetscapePluginView.mm:
557         (-[WebNetscapePluginView tellQuickTimeToChill]):
558
559 2017-08-29  Andy Estes  <aestes@apple.com>
560
561         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
562         https://bugs.webkit.org/show_bug.cgi?id=176046
563
564         Reviewed by Alex Christensen.
565
566         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
567         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
568
569         * Misc/WebNSFileManagerExtras.mm:
570         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
571         (setMetaData): Deleted.
572         * WebCoreSupport/WebSystemInterface.mm:
573         (InitWebCoreSystemInterface):
574
575 2017-08-28  Andy Estes  <aestes@apple.com>
576
577         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
578         https://bugs.webkit.org/show_bug.cgi?id=176039
579
580         Reviewed by Alex Christensen.
581
582         * WebCoreSupport/WebSystemInterface.mm:
583         (InitWebCoreSystemInterface):
584         * WebView/WebPreferences.mm:
585         (+[WebPreferences _systemCFStringEncoding]):
586
587 2017-08-28  Andy Estes  <aestes@apple.com>
588
589         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
590         https://bugs.webkit.org/show_bug.cgi?id=176032
591
592         Reviewed by Alex Christensen.
593
594         * WebCoreSupport/WebSystemInterface.mm:
595         (InitWebCoreSystemInterface):
596         * WebView/WebView.mm:
597         (-[WebView _cachedResponseForURL:]):
598
599 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
600
601         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
602         https://bugs.webkit.org/show_bug.cgi?id=175992
603         <rdar://problem/34086613>
604
605         Reviewed by Daniel Bates.
606
607         * WebCoreSupport/WebPlatformStrategies.h:
608         * WebCoreSupport/WebPlatformStrategies.mm:
609         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
610         cookies should be included, and return a pair containing the resulting cookie string and a boolean
611         indicating if secure cookies were accessed.
612
613 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
614
615         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
616         https://bugs.webkit.org/show_bug.cgi?id=170955
617         <rdar://problem/31697653>
618
619         Reviewed by Ryosuke Niwa.
620
621         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
622         text is being replaced.
623
624         * WebView/WebHTMLView.mm:
625         (-[WebHTMLView insertText:]):
626
627 2017-08-24  Chris Dumez  <cdumez@apple.com>
628
629         [Directory Upload] Add basic support for input.webkitdirectory
630         https://bugs.webkit.org/show_bug.cgi?id=175950
631         <rdar://problem/33951915>
632
633         Reviewed by Geoffrey Garen.
634
635         Add private API to toggle Directory Upload support on Mac WebKit1.
636
637         * WebView/WebPreferenceKeysPrivate.h:
638         * WebView/WebPreferences.mm:
639         (+[WebPreferences initialize]):
640         (-[WebPreferences setDirectoryUploadEnabled:]):
641         (-[WebPreferences directoryUploadEnabled]):
642         * WebView/WebPreferencesPrivate.h:
643         * WebView/WebView.mm:
644         (-[WebView _preferencesChanged:]):
645
646 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
647
648         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
649         https://bugs.webkit.org/show_bug.cgi?id=175370
650         <rdar://problem/33799806>
651
652         Reviewed by Ryosuke Niwa.
653
654         Adjust WebEditorClient for interface changes.
655
656         * WebCoreSupport/WebEditorClient.h:
657
658 2017-08-22  Alex Christensen  <achristensen@webkit.org>
659
660         Remove ChromeClient::scrollbarsModeDidChange
661         https://bugs.webkit.org/show_bug.cgi?id=175805
662
663         Reviewed by Daniel Bates.
664
665         * WebCoreSupport/WebChromeClient.h:
666
667 2017-08-22  Alex Christensen  <achristensen@webkit.org>
668
669         Remove ChromeClient::hasOpenedPopup
670         https://bugs.webkit.org/show_bug.cgi?id=175804
671
672         Reviewed by Sam Weinig.
673
674         * WebCoreSupport/WebChromeClient.h:
675         * WebCoreSupport/WebChromeClient.mm:
676         (WebChromeClient::hasOpenedPopup const): Deleted.
677
678 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
679
680         Disable access to secure cookies if an HTTPS site loads mixed content
681         https://bugs.webkit.org/show_bug.cgi?id=157053
682         <rdar://problem/11290808>
683
684         Reviewed by Dan Bates.
685
686         * WebCoreSupport/WebPlatformStrategies.h:
687         * WebCoreSupport/WebPlatformStrategies.mm:
688         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
689         indicating whether secure cookies should be included in the response.
690
691 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
692
693         [PAL] Move spi/mac directory into PAL
694         https://bugs.webkit.org/show_bug.cgi?id=175649
695
696         Reviewed by Myles C. Maxfield.
697
698         * Misc/WebSharingServicePickerController.h:
699         * WebCoreSupport/WebContextMenuClient.mm:
700         * WebCoreSupport/WebEditorClient.mm:
701         * WebCoreSupport/WebSelectionServiceController.mm:
702         * WebView/WebHTMLView.mm:
703         * WebView/WebImmediateActionController.h:
704         * WebView/WebImmediateActionController.mm:
705         * WebView/WebView.mm:
706
707 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
708
709         [PAL] Relocate SessionID to root
710         https://bugs.webkit.org/show_bug.cgi?id=175684
711
712         Reviewed by Alex Christensen.
713
714         * WebCoreSupport/WebFrameNetworkingContext.mm:
715
716 2017-08-17  Andreas Kling  <akling@apple.com>
717
718         Disable CSS regions at compile time
719         https://bugs.webkit.org/show_bug.cgi?id=175630
720
721         Reviewed by Antti Koivisto.
722
723         * Configurations/FeatureDefines.xcconfig:
724
725 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
726
727         [PAL] Move SessionID into PAL
728         https://bugs.webkit.org/show_bug.cgi?id=174192
729
730         Reviewed by Antti Koivisto.
731
732         * Misc/WebCache.mm:
733         (+[WebCache imageForURL:]):
734         * WebCoreSupport/WebFrameLoaderClient.h:
735         * WebCoreSupport/WebFrameLoaderClient.mm:
736         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
737         * WebCoreSupport/WebFrameNetworkingContext.mm:
738         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
739         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
740         (WebFrameNetworkingContext::storageSession const):
741         * WebCoreSupport/WebPlatformStrategies.h:
742         * WebCoreSupport/WebPlatformStrategies.mm:
743         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
744         * WebKitPrefix.h:
745
746 2017-08-16  Andy Estes  <aestes@apple.com>
747
748         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
749         https://bugs.webkit.org/show_bug.cgi?id=175648
750
751         Reviewed by Tim Horton.
752
753         * WebCoreSupport/WebPaymentCoordinatorClient.h:
754         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
755         (WebPaymentCoordinatorClient::showPaymentUI):
756
757 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
758
759         [PAL] Move spi/ios and spi/win directories into PAL
760         https://bugs.webkit.org/show_bug.cgi?id=175171
761
762         Reviewed by Antti Koivisto.
763
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         * WebView/WebView.mm:
766
767 2017-08-16  Andy Estes  <aestes@apple.com>
768
769         [Payment Request] Add an ENABLE flag and an experimental feature preference
770         https://bugs.webkit.org/show_bug.cgi?id=175622
771
772         Reviewed by Tim Horton.
773
774         * Configurations/FeatureDefines.xcconfig:
775
776 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
777
778         [PAL] Move Sleep classes into PAL
779         https://bugs.webkit.org/show_bug.cgi?id=175456
780
781         Reviewed by Ryosuke Niwa.
782
783         * WebView/WebFullScreenController.h:
784
785 2017-08-15  Youenn Fablet  <youenn@apple.com>
786
787         [Cache API] Adding generic support for CacheStorage and Cache methods
788         https://bugs.webkit.org/show_bug.cgi?id=175455
789
790         Reviewed by Chris Dumez.
791
792         * WebView/WebView.mm:
793         (-[WebView _commonInitializationWithFrameName:groupName:]):
794
795 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
796
797         Remove Proximity Events and related code
798         https://bugs.webkit.org/show_bug.cgi?id=175545
799
800         Reviewed by Daniel Bates.
801
802         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
803         and other related code.
804
805         * Configurations/FeatureDefines.xcconfig:
806
807 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
808
809         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
810         https://bugs.webkit.org/show_bug.cgi?id=175504
811
812         Reviewed by Sam Weinig.
813
814         * Configurations/FeatureDefines.xcconfig:
815         * DOM/DOMHTMLFormElement.mm:
816         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
817         * WebCoreSupport/WebFrameLoaderClient.h:
818
819 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
820
821         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
822         https://bugs.webkit.org/show_bug.cgi?id=175557
823
824         Reviewed by Jon Lee.
825
826         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
827
828         * Configurations/FeatureDefines.xcconfig:
829
830 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
831
832         Composition underline color is always black
833         https://bugs.webkit.org/show_bug.cgi?id=174675
834
835         Reviewed by Ryosuke Niwa.
836
837         * WebView/WebHTMLView.mm:
838         (extractUnderlines): If NSUnderlineColorAttributeName
839         is not present use text color for composition underline.
840         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
841         for composition underline in the plain text case.
842
843 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
844
845         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
846         https://bugs.webkit.org/show_bug.cgi?id=175474
847         <rdar://problem/33844628>
848
849         Reviewed by Wenson Hsieh.
850
851         Replaced the build flag by a runtime flag and disabled the feature by default.
852
853         * Configurations/FeatureDefines.xcconfig:
854         * WebView/WebPreferenceKeysPrivate.h:
855         * WebView/WebPreferences.mm:
856         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
857         (-[WebPreferences dataTransferItemsEnabled]): Added.
858         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
859         * WebView/WebPreferencesPrivate.h:
860         * WebView/WebView.mm:
861         (-[WebView _preferencesChanged:]):
862
863 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
864
865         Remove ENABLE_GAMEPAD_DEPRECATED
866         https://bugs.webkit.org/show_bug.cgi?id=175361
867
868         Reviewed by Carlos Garcia Campos.
869
870         * Configurations/FeatureDefines.xcconfig:
871
872 2017-08-09  Chris Dumez  <cdumez@apple.com>
873
874         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
875         https://bugs.webkit.org/show_bug.cgi?id=175401
876
877         Reviewed by Brady Eidson.
878
879         * WebView/WebPreferenceKeysPrivate.h:
880         * WebView/WebPreferences.mm:
881         (+[WebPreferences initialize]):
882         (-[WebPreferences beaconAPIEnabled]): Deleted.
883         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
884         * WebView/WebPreferencesPrivate.h:
885         * WebView/WebView.mm:
886         (-[WebView _preferencesChanged:]):
887
888 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
889
890         [PAL] Move spi/cocoa and spi/cg directories into PAL
891         https://bugs.webkit.org/show_bug.cgi?id=175175
892
893         Reviewed by Myles C. Maxfield.
894
895         * History/WebHistory.mm:
896         * Misc/WebDownload.mm:
897         * Misc/WebKitNSStringExtras.mm:
898         * Plugins/Hosted/NetscapePluginHostManager.mm:
899         * Plugins/WebPluginDatabase.mm:
900         * WebCoreSupport/WebFrameLoaderClient.mm:
901         * WebInspector/WebNodeHighlight.mm:
902         * WebView/WebHTMLView.mm:
903         * WebView/WebIndicateLayer.mm:
904         * WebView/WebView.mm:
905         * WebView/WebViewData.h:
906
907 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
908
909         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
910         https://bugs.webkit.org/show_bug.cgi?id=175392
911         <rdar://problem/33783207>
912
913         Reviewed by Tim Horton and Megan Gardner.
914
915         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
916
917         * Configurations/FeatureDefines.xcconfig:
918
919 2017-08-09  Daniel Bates  <dabates@apple.com>
920
921         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
922         https://bugs.webkit.org/show_bug.cgi?id=175247
923         <rdar://problem/33679804>
924
925         Reviewed by Brady Eidson.
926
927         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
928         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
929         clients that need to make use of this information at this time. If such a needs comes up
930         then we can expose API/SPI similar to what we do for WebKit.
931
932         * WebCoreSupport/WebFrameLoaderClient.h:
933         * WebCoreSupport/WebFrameLoaderClient.mm:
934         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
935
936 2017-08-08  Brady Eidson  <beidson@apple.com>
937
938         Don't enable default icon loading in WK1 for apps linked against old SDKs.
939         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
940
941         Reviewed by Andy Estes.
942
943         * Misc/WebKitVersionChecks.h:
944         * WebCoreSupport/WebFrameLoaderClient.mm:
945         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
946           the app is linked against new WebKit with the new behavior.
947
948 2017-08-07  Devin Rousso  <drousso@apple.com>
949
950         Web Inspector: Preview Canvas path when viewing a recording
951         https://bugs.webkit.org/show_bug.cgi?id=174967
952
953         Reviewed by Brian Burg.
954
955         * WebView/WebPreferenceKeysPrivate.h:
956         * WebView/WebPreferences.mm:
957         (+[WebPreferences initialize]):
958         (-[WebPreferences inspectorAdditionsEnabled]):
959         (-[WebPreferences setInspectorAdditionsEnabled:]):
960         * WebView/WebPreferencesPrivate.h:
961         * WebView/WebView.mm:
962         (-[WebView _preferencesChanged:]):
963         Add plumbing for new InspectorAdditions runtime flag.
964
965 2017-08-07  Brian Burg  <bburg@apple.com>
966
967         Remove CANVAS_PATH compilation guard
968         https://bugs.webkit.org/show_bug.cgi?id=175207
969
970         Reviewed by Sam Weinig.
971
972         * Configurations/FeatureDefines.xcconfig:
973
974 2017-08-04  Youenn Fablet  <youenn@apple.com>
975
976         [Cache API] Add Cache and CacheStorage IDL definitions
977         https://bugs.webkit.org/show_bug.cgi?id=175201
978
979         Reviewed by Brady Eidson.
980
981         * WebView/WebPreferenceKeysPrivate.h:
982         * WebView/WebPreferences.mm:
983         (+[WebPreferences initialize]):
984         (-[WebPreferences cacheAPIEnabled]):
985         (-[WebPreferences setCacheAPIEnabled:]):
986         * WebView/WebPreferencesPrivate.h:
987         * WebView/WebView.mm:
988         (-[WebView _preferencesChanged:]):
989
990 2017-08-04  Matt Lewis  <jlewis3@apple.com>
991
992         Unreviewed, rolling out r220271.
993
994         Rolling out due to Layout Test failing on iOS Simulator.
995
996         Reverted changeset:
997
998         "Remove STREAMS_API compilation guard"
999         https://bugs.webkit.org/show_bug.cgi?id=175165
1000         http://trac.webkit.org/changeset/220271
1001
1002 2017-08-04  Youenn Fablet  <youenn@apple.com>
1003
1004         Remove STREAMS_API compilation guard
1005         https://bugs.webkit.org/show_bug.cgi?id=175165
1006
1007         Reviewed by Darin Adler.
1008
1009         * Configurations/FeatureDefines.xcconfig:
1010         * WebView/WebPreferences.mm:
1011         (+[WebPreferences initialize]):
1012         * WebView/WebView.mm:
1013         (-[WebView _preferencesChanged:]):
1014
1015 2017-08-03  Brian Burg  <bburg@apple.com>
1016
1017         Remove ENABLE(WEB_SOCKET) guards
1018         https://bugs.webkit.org/show_bug.cgi?id=167044
1019
1020         Reviewed by Joseph Pecoraro.
1021
1022         * Configurations/FeatureDefines.xcconfig:
1023         * WebView/WebPreferencesPrivate.h:
1024
1025 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1026
1027         [PAL] Move spi/cf directory into PAL
1028         https://bugs.webkit.org/show_bug.cgi?id=175057
1029
1030         Reviewed by Antti Koivisto.
1031
1032         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1033         * Plugins/WebNetscapePluginStream.mm:
1034         * WebCoreSupport/WebFrameNetworkingContext.mm:
1035         * WebView/WebPreferences.mm:
1036         * WebView/WebView.mm:
1037
1038 2017-08-03  Youenn Fablet  <youenn@apple.com>
1039
1040         Remove FETCH_API compilation guard
1041         https://bugs.webkit.org/show_bug.cgi?id=175154
1042
1043         Reviewed by Chris Dumez.
1044
1045         * Configurations/FeatureDefines.xcconfig:
1046         * WebView/WebPreferences.mm:
1047         (+[WebPreferences initialize]):
1048         * WebView/WebView.mm:
1049         (-[WebView _preferencesChanged:]):
1050
1051 2017-08-03  Brady Eidson  <beidson@apple.com>
1052
1053         Add SW IDLs and stub out basic functionality.
1054         https://bugs.webkit.org/show_bug.cgi?id=175115
1055
1056         Reviewed by Chris Dumez.
1057
1058         * Configurations/FeatureDefines.xcconfig:
1059
1060 2017-08-02  Sam Weinig  <sam@webkit.org>
1061
1062         [WebIDL] Convert MutationCallback to be a normal generated callback
1063         https://bugs.webkit.org/show_bug.cgi?id=174140
1064
1065         Reviewed by Darin Adler.
1066
1067         * DOM/DOMDocument.mm:
1068         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1069         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1070         Pass, now necessary, Document to NativeNodeFilter constructor.
1071
1072 2017-08-01  Chris Dumez  <cdumez@apple.com>
1073
1074         Add initial support for navigator.sendBeacon
1075         https://bugs.webkit.org/show_bug.cgi?id=175007
1076         <rdar://problem/33547728>
1077
1078         Reviewed by Sam Weinig.
1079
1080         Add setting to toggle support for the Beacon API (it is disabled by default).
1081
1082         * WebView/WebPreferenceKeysPrivate.h:
1083         * WebView/WebPreferences.mm:
1084         (+[WebPreferences initialize]):
1085         (-[WebPreferences beaconAPIEnabled]):
1086         (-[WebPreferences setBeaconAPIEnabled:]):
1087         * WebView/WebPreferencesPrivate.h:
1088         * WebView/WebView.mm:
1089         (-[WebView _preferencesChanged:]):
1090
1091 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
1092
1093         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
1094         https://bugs.webkit.org/show_bug.cgi?id=174437
1095
1096         Reviewed by Darin Adler.
1097
1098         Remove redundant Web- prefix from classes in WebKit namespace.
1099
1100         * WebView/WebView.mm:
1101         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1102         * WebView/WebViewData.h:
1103         * WebView/WebViewData.mm:
1104
1105 2017-07-26  Brian Burg  <bburg@apple.com>
1106
1107         Remove WEB_TIMING feature flag
1108         https://bugs.webkit.org/show_bug.cgi?id=174795
1109
1110         Reviewed by Alex Christensen.
1111
1112         * Configurations/FeatureDefines.xcconfig:
1113
1114 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
1115
1116         Async image decoding for large images should be disabled after the first time a tile is painted
1117         https://bugs.webkit.org/show_bug.cgi?id=174451
1118         <rdar://problem/31246421>
1119
1120         Reviewed by Simon Fraser.
1121
1122         * WebView/WebFrame.mm:
1123         (-[WebFrame _paintBehaviorForDestinationContext:]):
1124         (-[WebFrame _drawRect:contentsOnly:]):
1125         * WebView/WebHTMLView.mm:
1126         (imageFromRect):
1127
1128 2017-07-23  Darin Adler  <darin@apple.com>
1129
1130         More NeverDestroyed and related cleanup
1131         https://bugs.webkit.org/show_bug.cgi?id=174745
1132
1133         Reviewed by Alex Christensen.
1134
1135         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
1136         for names that aren't even used in this file.
1137         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
1138         -[NSArray arrayWithObject:].
1139         (-[DOMNode absoluteQuads]): Ditto.
1140         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
1141         of writing out various types.
1142         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
1143         syntax instea of -[NSArray arrayWithObject:].
1144         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
1145         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
1146         of writing out various types.
1147         (-[DOMHTMLImageElement mimeType]): Ditto.
1148
1149 2017-07-24  Chris Dumez  <cdumez@apple.com>
1150
1151         ExceptionCode enumeration should use modern exception names
1152         https://bugs.webkit.org/show_bug.cgi?id=174794
1153
1154         Reviewed by Geoffrey Garen.
1155
1156         * DOM/ExceptionHandlers.mm:
1157         (raiseNotSupportedErrorException):
1158
1159 2017-07-23  Chris Dumez  <cdumez@apple.com>
1160
1161         Drop ExceptionCodeDescription class
1162         https://bugs.webkit.org/show_bug.cgi?id=174757
1163
1164         Reviewed by Darin Adler.
1165
1166         Stop using ExceptionCodeDescription.
1167
1168         * DOM/ExceptionHandlers.mm:
1169         (raiseDOMErrorException):
1170
1171 2017-07-21  Andreas Kling  <akling@apple.com>
1172
1173         Use more references in event dispatch code
1174         https://bugs.webkit.org/show_bug.cgi?id=174681
1175
1176         Reviewed by Geoffrey Garen.
1177
1178         * DOM/ObjCEventListener.h:
1179         * DOM/ObjCEventListener.mm:
1180         (WebCore::ObjCEventListener::handleEvent):
1181         * WebCoreSupport/WebFrameLoaderClient.mm:
1182         (NetscapePluginWidget::handleEvent):
1183
1184 2017-07-21  Brady Eidson  <beidson@apple.com>
1185
1186         Get rid of WebCore IconDatabase code.
1187         https://bugs.webkit.org/show_bug.cgi?id=174700
1188
1189         Reviewed by Tim Horton.
1190
1191         * Misc/WebCoreStatistics.mm:
1192         (+[WebCoreStatistics iconPageURLMappingCount]):
1193         (+[WebCoreStatistics iconRetainedPageURLCount]):
1194         (+[WebCoreStatistics iconRecordCount]):
1195         (+[WebCoreStatistics iconsWithDataCount]):
1196         * WebCoreSupport/WebFrameLoaderClient.h:
1197         * WebCoreSupport/WebFrameLoaderClient.mm:
1198         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
1199         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
1200         * WebView/WebView.mm:
1201         (-[WebView mainFrameIconURL]):
1202
1203 2017-07-20  Chris Dumez  <cdumez@apple.com>
1204
1205         Drop legacy XPathException type
1206         https://bugs.webkit.org/show_bug.cgi?id=174679
1207
1208         Reviewed by Sam Weinig.
1209
1210         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
1211         no longer expose XPathException.
1212
1213         * DOM/ExceptionHandlers.mm:
1214         (raiseDOMErrorException):
1215
1216 2017-07-20  Chris Dumez  <cdumez@apple.com>
1217
1218         Unreviewed, rolling out r219706.
1219
1220         Broke iOS build
1221
1222         Reverted changeset:
1223
1224         "Drop legacy XPathException type"
1225         https://bugs.webkit.org/show_bug.cgi?id=174679
1226         http://trac.webkit.org/changeset/219706
1227
1228 2017-07-20  Chris Dumez  <cdumez@apple.com>
1229
1230         Drop legacy XPathException type
1231         https://bugs.webkit.org/show_bug.cgi?id=174679
1232
1233         Reviewed by Sam Weinig.
1234
1235         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
1236         no longer expose XPathException.
1237
1238         * DOM/ExceptionHandlers.mm:
1239         (raiseDOMErrorException):
1240         * WebKit.exp:
1241
1242 2017-07-20  Chris Dumez  <cdumez@apple.com>
1243
1244         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
1245         https://bugs.webkit.org/show_bug.cgi?id=174660
1246
1247         Reviewed by Geoffrey Garen.
1248
1249         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
1250         This essentially replaces a branch to figure out if the new size is less or greater than the
1251         current size by an assertion.
1252
1253         * Plugins/WebNetscapePluginView.mm:
1254         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1255
1256 2017-07-20  Brady Eidson  <beidson@apple.com>
1257
1258         Deprecate WebIconDatabase in WebKitLegacy/mac.
1259         https://bugs.webkit.org/show_bug.cgi?id=174607
1260
1261         Reviewed by Alex Christensen.
1262
1263         This patch:
1264         1 - Formally deprecates WebIconDatabase (which was never API anyways)
1265         2 - Guts the class to where it can only return the default icon at the small size
1266         3 - Reworks other parts of WebKitLegacy that used it for anything to either
1267             use something else or to not do anything.
1268         
1269         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
1270         and that patch will remove all of the last remnants of WebIconDatabase.
1271         
1272         * History/WebHistoryItem.mm:
1273         (-[WebHistoryItem icon]):
1274
1275         * Misc/WebIconDatabase.h:
1276         * Misc/WebIconDatabase.mm:
1277         (-[WebIconDatabase init]):
1278         (-[WebIconDatabase iconForURL:withSize:cache:]):
1279         (-[WebIconDatabase iconForURL:withSize:]):
1280         (-[WebIconDatabase defaultIconWithSize:]):
1281         (-[WebIconDatabase defaultIconForURL:withSize:]):
1282         (-[WebIconDatabase iconURLForURL:]):
1283         (-[WebIconDatabase retainIconForURL:]):
1284         (-[WebIconDatabase releaseIconForURL:]):
1285         (+[WebIconDatabase delayDatabaseCleanup]):
1286         (+[WebIconDatabase allowDatabaseCleanup]):
1287         (-[WebIconDatabase setDelegate:]):
1288         (-[WebIconDatabase delegate]):
1289         (+[WebIconDatabase initialize]): Deleted.
1290         (-[WebIconDatabase isEnabled]): Deleted.
1291         (-[WebIconDatabase setEnabled:]): Deleted.
1292         (-[WebIconDatabase removeAllIcons]): Deleted.
1293         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
1294         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
1295         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
1296         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
1297         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
1298         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
1299         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
1300         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
1301         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
1302         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
1303         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
1304         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
1305         (-[WebIconDatabase _databaseDirectory]): Deleted.
1306         (webGetNSImage): Deleted.
1307
1308         * Misc/WebIconDatabaseDelegate.h: Removed.
1309         * Misc/WebIconDatabaseInternal.h: Removed.
1310         * Misc/WebIconDatabasePrivate.h: Removed.
1311
1312         * WebCoreSupport/WebFrameLoaderClient.mm:
1313         (webGetNSImage):
1314
1315         * WebCoreSupport/WebIconDatabaseClient.mm:
1316         (WebIconDatabaseClient::didRemoveAllIcons):
1317         (WebIconDatabaseClient::didImportIconURLForPageURL):
1318
1319         * WebView/WebView.mm:
1320         (-[WebView setFrameLoadDelegate:]):
1321         (-[WebView mainFrameIcon]):
1322
1323 2017-07-18  Andy Estes  <aestes@apple.com>
1324
1325         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1326         https://bugs.webkit.org/show_bug.cgi?id=174631
1327
1328         Reviewed by Tim Horton.
1329
1330         * Configurations/Base.xcconfig:
1331
1332 2017-07-18  Andy Estes  <aestes@apple.com>
1333
1334         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1335         https://bugs.webkit.org/show_bug.cgi?id=174631
1336
1337         Reviewed by Sam Weinig.
1338
1339         * Configurations/Base.xcconfig:
1340
1341 2017-07-18  Andy Estes  <aestes@apple.com>
1342
1343         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1344         https://bugs.webkit.org/show_bug.cgi?id=174631
1345
1346         Reviewed by Dan Bernstein.
1347
1348         * Configurations/Base.xcconfig:
1349
1350 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1351
1352         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
1353         https://bugs.webkit.org/show_bug.cgi?id=174640
1354         <rdar://problem/33297400>
1355
1356         Reviewed by Tim Horton.
1357
1358         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
1359         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
1360         web thread here, to match the other WebView drag and drop SPI methods.
1361
1362         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
1363         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
1364         should make this robust against future UIKit changes that could make this no longer the case.
1365
1366         * WebView/WebView.mm:
1367         (-[WebView _requestStartDataInteraction:globalPosition:]):
1368         (-[WebView _dataInteractionCaretRect]):
1369
1370 2017-07-18  Andy Estes  <aestes@apple.com>
1371
1372         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1373         https://bugs.webkit.org/show_bug.cgi?id=174631
1374
1375         Reviewed by Darin Adler.
1376
1377         * Configurations/Base.xcconfig:
1378
1379 2017-07-17  Sam Weinig  <sam@webkit.org>
1380
1381         [WebIDL] Remove custom bindings that require non-caching JS strings
1382         https://bugs.webkit.org/show_bug.cgi?id=174552
1383
1384         Reviewed by Darin Adler.
1385
1386         * DOM/DOMHTMLCanvasElement.mm:
1387         (-[DOMHTMLCanvasElement toDataURL:]):
1388         Update to account for implementation now returning an UncachedString.
1389
1390 2017-07-17  Darin Adler  <darin@apple.com>
1391
1392         Improve use of NeverDestroyed
1393         https://bugs.webkit.org/show_bug.cgi?id=174348
1394
1395         Reviewed by Sam Weinig.
1396
1397         * Misc/WebStringTruncator.mm:
1398         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
1399         NeverDestroyed<RetainPtr> with just an NSFont * global.
1400
1401         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
1402         NeverDestroyed.h.
1403         * Storage/WebDatabaseManager.mm: Ditto.
1404         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
1405         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
1406
1407         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
1408         (aeDescFromJSValue): Removed double hashing by using the return value from
1409         add rather than calling contains before calling add.
1410
1411 2017-07-14  Jer Noble  <jer.noble@apple.com>
1412
1413         Allow clients to override their own hardware media requirements where no fallback media exists.
1414         https://bugs.webkit.org/show_bug.cgi?id=174426
1415         <rdar://problem/32537704>
1416
1417         Reviewed by Eric Carlson.
1418
1419         Add a new WebPreferences property to control WebCore's new
1420         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
1421
1422         * WebView/WebPreferenceKeysPrivate.h:
1423         * WebView/WebPreferences.mm:
1424         (+[WebPreferences initialize]):
1425         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
1426         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
1427         * WebView/WebPreferencesPrivate.h:
1428         * WebView/WebView.mm:
1429         (-[WebView _preferencesChanged:]):
1430
1431 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
1432
1433         Async image decoding for large images should be disabled by default
1434         https://bugs.webkit.org/show_bug.cgi?id=174432
1435
1436         Reviewed by Simon Fraser.
1437
1438         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
1439         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
1440         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
1441            a child view instead of propagating PaintBehaviorSnapshotting.
1442         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
1443            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
1444
1445         * WebView/WebFrame.mm:
1446         (-[WebFrame _paintBehaviorForDestinationContext:]):
1447         (-[WebFrame _drawRect:contentsOnly:]):
1448         * WebView/WebHTMLView.mm:
1449         (imageFromRect):
1450
1451 2017-07-12  Daniel Bates  <dabates@apple.com>
1452
1453         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
1454         https://bugs.webkit.org/show_bug.cgi?id=174427
1455
1456         Rubber-stamped by Brady Eidson.
1457
1458         * WebView/WebPDFView.mm:
1459         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1460
1461 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1462
1463         Unreviewed, rolling out r219401.
1464
1465         This revision rolled out the previous patch, but after talking
1466         with reviewer, a rebaseline is what was needed.Rolling back in
1467         before rebaseline.
1468
1469         Reverted changeset:
1470
1471         "Unreviewed, rolling out r219379."
1472         https://bugs.webkit.org/show_bug.cgi?id=174400
1473         http://trac.webkit.org/changeset/219401
1474
1475 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1476
1477         Unreviewed, rolling out r219379.
1478
1479         This revision caused a consistent failure in the test
1480         fast/dom/Window/property-access-on-cached-window-after-frame-
1481         removed.html.
1482
1483         Reverted changeset:
1484
1485         "Remove NAVIGATOR_HWCONCURRENCY"
1486         https://bugs.webkit.org/show_bug.cgi?id=174400
1487         http://trac.webkit.org/changeset/219379
1488
1489 2017-07-11  Dean Jackson  <dino@apple.com>
1490
1491         Remove NAVIGATOR_HWCONCURRENCY
1492         https://bugs.webkit.org/show_bug.cgi?id=174400
1493
1494         * Configurations/FeatureDefines.xcconfig:
1495
1496 2017-07-11  Dean Jackson  <dino@apple.com>
1497
1498         Rolling out r219372.
1499
1500         * Configurations/FeatureDefines.xcconfig:
1501
1502 2017-07-11  Dean Jackson  <dino@apple.com>
1503
1504         Remove NAVIGATOR_HWCONCURRENCY
1505         https://bugs.webkit.org/show_bug.cgi?id=174400
1506
1507         * Configurations/FeatureDefines.xcconfig:
1508
1509 2017-07-03  Brian Burg  <bburg@apple.com>
1510
1511         Web Replay: remove some unused code
1512         https://bugs.webkit.org/show_bug.cgi?id=173903
1513
1514         Rubber-stamped by Joseph Pecoraro.
1515
1516         * Configurations/FeatureDefines.xcconfig:
1517
1518 2017-07-09  Brady Eidson  <beidson@apple.com>
1519
1520         Remove some obsolete WebKitVersionChecks.
1521         https://bugs.webkit.org/show_bug.cgi?id=174294
1522
1523         Reviewed by Dan Bernstein.
1524
1525         * Misc/WebKitVersionChecks.h:
1526
1527         * WebView/WebHTMLView.mm:
1528         (-[WebHTMLView hitTest:]):
1529
1530         * WebView/WebView.mm:
1531         (shouldRespectPriorityInCSSAttributeSetters):
1532         (-[WebView _commonInitializationWithFrameName:groupName:]):
1533         (-[WebView _preferencesChanged:]):
1534         (shouldTransformsAffectOverflow): Deleted.
1535         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
1536
1537 2017-07-08  Brady Eidson  <beidson@apple.com>
1538
1539         Remove some obsolete RuntimeApplicationChecks.
1540         https://bugs.webkit.org/show_bug.cgi?id=174293
1541
1542         Reviewed by Dan Bernstein.
1543
1544         * Misc/WebKitVersionChecks.h:
1545         * WebView/WebView.mm:
1546         (+[WebView enableWebThread]):
1547         (-[WebView _needsPreHTML5ParserQuirks]):
1548
1549 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1550
1551         Drop NOSNIFF compile flag
1552         https://bugs.webkit.org/show_bug.cgi?id=174289
1553
1554         Reviewed by Michael Catanzaro.
1555
1556         * Configurations/FeatureDefines.xcconfig:
1557
1558 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1559
1560         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1561         https://bugs.webkit.org/show_bug.cgi?id=174150
1562
1563         Reviewed by Mark Lam.
1564
1565         * DOM/DOM.mm:
1566         (lookupElementClass):
1567
1568 2017-07-06  Brady Eidson  <beidson@apple.com>
1569
1570         Add logging to first attempt to use the WebIconDatabase class.
1571         https://bugs.webkit.org/show_bug.cgi?id=174190
1572
1573         Reviewed by Andy Estes.
1574
1575         * Misc/WebIconDatabase.mm:
1576         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
1577         * Misc/WebKitVersionChecks.h:
1578
1579 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1580
1581         Unreviewed, rolling out r219178.
1582
1583         This caused a consistent failure with the API test
1584         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1585
1586         Reverted changeset:
1587
1588         "[WTF] Clean up StringStatics.cpp by using
1589         LazyNeverDestroyed<> for Atoms"
1590         https://bugs.webkit.org/show_bug.cgi?id=174150
1591         http://trac.webkit.org/changeset/219178
1592
1593 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1594
1595         [WTF] Move SoftLinking.h into WTF
1596         https://bugs.webkit.org/show_bug.cgi?id=174000
1597
1598         Reviewed by Alex Christensen.
1599
1600         * Plugins/WebNetscapePluginView.mm:
1601         * Plugins/WebPluginController.mm:
1602         * WebCoreSupport/WebInspectorClient.mm:
1603         * WebView/WebFullScreenController.mm:
1604         * WebView/WebImmediateActionController.mm:
1605         * WebView/WebView.mm:
1606
1607 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1608
1609         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1610         https://bugs.webkit.org/show_bug.cgi?id=174150
1611
1612         Reviewed by Mark Lam.
1613
1614         * DOM/DOM.mm:
1615         (lookupElementClass):
1616
1617 2017-07-05  Brady Eidson  <beidson@apple.com>
1618
1619         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
1620         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
1621
1622         Reviewed by Alex Christensen.
1623
1624         Adopt to the new constructor for FrameLoadRequest.
1625
1626         * WebView/WebPDFView.mm:
1627         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1628
1629 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
1630
1631         Make WebKit's public headers on Mac and iOS C++ module safe
1632         https://bugs.webkit.org/show_bug.cgi?id=174175
1633
1634         Reviewed by Alex Christensen.
1635
1636         Fixed the header files.
1637
1638         * Misc/WebDownload.h:
1639         * Misc/WebKitErrors.h:
1640         * Plugins/WebPluginContainer.h:
1641         * WebView/WebResourceLoadDelegate.h:
1642
1643 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1644
1645         Remove copy of ICU headers from WebKit
1646         https://bugs.webkit.org/show_bug.cgi?id=116407
1647
1648         Reviewed by Alex Christensen.
1649
1650         Use WTF's copy of ICU headers.
1651
1652         * Configurations/WebKitLegacy.xcconfig:
1653         * icu/unicode/localpointer.h: Removed.
1654         * icu/unicode/parseerr.h: Removed.
1655         * icu/unicode/platform.h: Removed.
1656         * icu/unicode/ptypes.h: Removed.
1657         * icu/unicode/putil.h: Removed.
1658         * icu/unicode/uchar.h: Removed.
1659         * icu/unicode/uconfig.h: Removed.
1660         * icu/unicode/ucurr.h: Removed.
1661         * icu/unicode/uidna.h: Removed.
1662         * icu/unicode/uiter.h: Removed.
1663         * icu/unicode/umachine.h: Removed.
1664         * icu/unicode/unorm.h: Removed.
1665         * icu/unicode/unorm2.h: Removed.
1666         * icu/unicode/urename.h: Removed.
1667         * icu/unicode/uscript.h: Removed.
1668         * icu/unicode/ustring.h: Removed.
1669         * icu/unicode/utf.h: Removed.
1670         * icu/unicode/utf16.h: Removed.
1671         * icu/unicode/utf8.h: Removed.
1672         * icu/unicode/utf_old.h: Removed.
1673         * icu/unicode/utypes.h: Removed.
1674         * icu/unicode/uvernum.h: Removed.
1675         * icu/unicode/uversion.h: Removed.
1676
1677 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1678
1679         Add WebKitPrivateFrameworkStubs for iOS 11
1680         https://bugs.webkit.org/show_bug.cgi?id=173988
1681
1682         Reviewed by David Kilzer.
1683
1684         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
1685         use the same directory for private framework stubs.
1686
1687 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1688
1689         Unreviewed, rolling out r219103.
1690
1691         Caused multiple build failures.
1692
1693         Reverted changeset:
1694
1695         "Remove copy of ICU headers from WebKit"
1696         https://bugs.webkit.org/show_bug.cgi?id=116407
1697         http://trac.webkit.org/changeset/219103
1698
1699 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1700
1701         Remove copy of ICU headers from WebKit
1702         https://bugs.webkit.org/show_bug.cgi?id=116407
1703
1704         Reviewed by Alex Christensen.
1705
1706         Use WTF's copy of ICU headers.
1707
1708         * Configurations/WebKitLegacy.xcconfig:
1709         * icu/unicode/localpointer.h: Removed.
1710         * icu/unicode/parseerr.h: Removed.
1711         * icu/unicode/platform.h: Removed.
1712         * icu/unicode/ptypes.h: Removed.
1713         * icu/unicode/putil.h: Removed.
1714         * icu/unicode/uchar.h: Removed.
1715         * icu/unicode/uconfig.h: Removed.
1716         * icu/unicode/ucurr.h: Removed.
1717         * icu/unicode/uidna.h: Removed.
1718         * icu/unicode/uiter.h: Removed.
1719         * icu/unicode/umachine.h: Removed.
1720         * icu/unicode/unorm.h: Removed.
1721         * icu/unicode/unorm2.h: Removed.
1722         * icu/unicode/urename.h: Removed.
1723         * icu/unicode/uscript.h: Removed.
1724         * icu/unicode/ustring.h: Removed.
1725         * icu/unicode/utf.h: Removed.
1726         * icu/unicode/utf16.h: Removed.
1727         * icu/unicode/utf8.h: Removed.
1728         * icu/unicode/utf_old.h: Removed.
1729         * icu/unicode/utypes.h: Removed.
1730         * icu/unicode/uvernum.h: Removed.
1731         * icu/unicode/uversion.h: Removed.
1732
1733 2017-07-03  Brady Eidson  <beidson@apple.com>
1734
1735         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1736         https://bugs.webkit.org/show_bug.cgi?id=174073
1737
1738         Reviewed by Andy Estes.
1739
1740         WebView now keeps a direct copy of its main frame icon as a member variable.
1741         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
1742         
1743         This change causes a progression in KVO observation of the mainFrameIcon property as we now
1744         have both the old icon and new icon at the time it changes.
1745
1746         * WebCoreSupport/WebFrameLoaderClient.h:
1747         * WebCoreSupport/WebFrameLoaderClient.mm:
1748         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1749         (WebFrameLoaderClient::getLoadDecisionForIcons):
1750         (WebFrameLoaderClient::finishedLoadingIcon):
1751         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
1752         (WebFrameLoaderClient::registerForIconNotification): Deleted.
1753
1754         * WebView/WebView.mm:
1755         (+[WebView _setIconLoadingEnabled:]):
1756         (+[WebView _isIconLoadingEnabled]):
1757         (-[WebView mainFrameIcon]):
1758         (-[WebView _setMainFrameIcon:]):
1759         (-[WebView _receivedIconChangedNotification:]): Deleted.
1760         (-[WebView _registerForIconNotification:]): Deleted.
1761         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
1762         * WebView/WebViewData.h:
1763         * WebView/WebViewInternal.h:
1764         * WebView/WebViewPrivate.h:
1765
1766 2017-07-03  Sam Weinig  <sam@webkit.org>
1767
1768         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
1769         https://bugs.webkit.org/show_bug.cgi?id=174083
1770
1771         Reviewed by Alex Christensen.
1772
1773         * Configurations/FeatureDefines.xcconfig:
1774         Add ENABLE_NAVIGATOR_STANDALONE.
1775
1776 2017-07-03  Tim Horton  <timothy_horton@apple.com>
1777
1778         Expose unobscuredSafeAreaInsets on WebView
1779         https://bugs.webkit.org/show_bug.cgi?id=174075
1780         <rdar://problem/33096997>
1781
1782         Reviewed by Beth Dakin.
1783
1784         * WebView/WebView.mm:
1785         (-[WebView _setUnobscuredSafeAreaInsets:]):
1786         (-[WebView _unobscuredSafeAreaInsets]):
1787         * WebView/WebViewPrivate.h:
1788         Expose unobscuredSafeAreaInsets as a new private property on WebView,
1789         similar to how it is exposed in WebKit2.
1790
1791 2017-07-03  Andy Estes  <aestes@apple.com>
1792
1793         [Xcode] Add an experimental setting to build with ccache
1794         https://bugs.webkit.org/show_bug.cgi?id=173875
1795
1796         Reviewed by Tim Horton.
1797
1798         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
1799
1800 2017-07-03  Tim Horton  <timothy_horton@apple.com>
1801
1802         Expose WebPreferences for viewport-fit and constant() properties
1803         https://bugs.webkit.org/show_bug.cgi?id=174072
1804         <rdar://problem/33096639>
1805
1806         Reviewed by Ryosuke Niwa.
1807
1808         * WebView/WebPreferenceKeysPrivate.h:
1809         * WebView/WebPreferences.mm:
1810         (-[WebPreferences viewportFitEnabled]):
1811         (-[WebPreferences setViewportFitEnabled:]):
1812         (-[WebPreferences constantPropertiesEnabled]):
1813         (-[WebPreferences setConstantPropertiesEnabled:]):
1814         * WebView/WebPreferencesPrivate.h:
1815         * WebView/WebView.mm:
1816         (-[WebView _preferencesChanged:]):
1817
1818 2017-07-01  Tim Horton  <timothy_horton@apple.com>
1819
1820         Expose viewport-fit value to UIKit via viewport arguments dictionary
1821         https://bugs.webkit.org/show_bug.cgi?id=174071
1822         <rdar://problem/33096620>
1823
1824         Reviewed by Wenson Hsieh.
1825
1826         * History/WebHistoryItem.mm:
1827         * History/WebHistoryItemPrivate.h:
1828         Add another dictionary key and three values.
1829
1830 2017-07-01  Dan Bernstein  <mitz@apple.com>
1831
1832         [iOS] Remove code only needed when building for iOS 9.x
1833         https://bugs.webkit.org/show_bug.cgi?id=174068
1834
1835         Reviewed by Tim Horton.
1836
1837         * Configurations/FeatureDefines.xcconfig:
1838
1839 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
1840
1841         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
1842         https://bugs.webkit.org/show_bug.cgi?id=174004
1843
1844         Reviewed by Simon Fraser.
1845
1846         * WebCoreSupport/WebPluginInfoProvider.mm:
1847
1848 2017-07-01  Dan Bernstein  <mitz@apple.com>
1849
1850         [macOS] Remove code only needed when building for OS X Yosemite
1851         https://bugs.webkit.org/show_bug.cgi?id=174067
1852
1853         Reviewed by Tim Horton.
1854
1855         * Configurations/Base.xcconfig:
1856         * Configurations/DebugRelease.xcconfig:
1857         * Configurations/FeatureDefines.xcconfig:
1858         * Configurations/Version.xcconfig:
1859         * Plugins/WebBasePluginPackage.mm:
1860         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1861         * WebCoreSupport/PopupMenuMac.mm:
1862         (PopupMenuMac::show):
1863         * WebCoreSupport/WebInspectorClient.mm:
1864         (WebInspectorFrontendClient::startWindowDrag):
1865         (-[WebInspectorWindowController window]):
1866         * WebView/WebView.mm:
1867         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1868
1869 2017-06-30  Daniel Bates  <dabates@apple.com>
1870
1871         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1872         https://bugs.webkit.org/show_bug.cgi?id=165160
1873         <rdar://problem/29451999>
1874
1875         Reviewed by Brady Eidson.
1876
1877         Pass the document that is requesting the load to the loader.
1878
1879         * WebView/WebPDFView.mm:
1880         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1881
1882 2017-06-29  Jer Noble  <jer.noble@apple.com>
1883
1884         Make Legacy EME API controlled by RuntimeEnabled setting.
1885         https://bugs.webkit.org/show_bug.cgi?id=173994
1886
1887         Reviewed by Sam Weinig.
1888
1889         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
1890
1891         * Configurations/FeatureDefines.xcconfig:
1892         * WebView/WebPreferenceKeysPrivate.h:
1893         * WebView/WebPreferences.mm:
1894         (+[WebPreferences initialize]):
1895         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
1896         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
1897         * WebView/WebPreferencesPrivate.h:
1898         * WebView/WebView.mm:
1899         (-[WebView _preferencesChanged:]):
1900
1901 2017-06-30  Chris Dumez  <cdumez@apple.com>
1902
1903         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
1904         https://bugs.webkit.org/show_bug.cgi?id=174013
1905
1906         Reviewed by Brent Fulgham.
1907
1908         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
1909         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
1910
1911         * WebView/WebView.mm:
1912         (-[WebView _commonInitializationWithFrameName:groupName:]):
1913
1914 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1915
1916         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
1917         https://bugs.webkit.org/show_bug.cgi?id=174017
1918         <rdar://problem/32959782>
1919
1920         Reviewed by Simon Fraser.
1921
1922         Use root view coordinates when computing the drag caret rect.
1923
1924         * WebView/WebView.mm:
1925         (-[WebView _dataInteractionCaretRect]):
1926
1927 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
1928
1929         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
1930         https://bugs.webkit.org/show_bug.cgi?id=173899
1931         rdar://problem/32994474
1932
1933         Reviewed by Tim Horton.
1934
1935         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
1936         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
1937         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
1938
1939         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
1940         documentView is a WebHTMLView.
1941
1942         * WebView/WebFrame.mm:
1943         (-[WebFrame _webHTMLDocumentView]):
1944         (-[WebFrame _paintBehaviorForDestinationContext:]):
1945         (-[WebFrame _drawRect:contentsOnly:]):
1946         (-[WebFrame setTimeoutsPaused:]):
1947         (-[WebFrame prepareForPause]):
1948         (-[WebFrame resumeFromPause]):
1949         (-[WebFrame resetTextAutosizingBeforeLayout]):
1950         * WebView/WebHTMLView.mm:
1951         (-[WebHTMLView drawLayer:inContext:]):
1952         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
1953         * WebView/WebHTMLViewInternal.h:
1954
1955 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1956
1957         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
1958         https://bugs.webkit.org/show_bug.cgi?id=173854
1959         <rdar://problem/32236827>
1960
1961         Reviewed by Ryosuke Niwa and Tim Horton.
1962
1963         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
1964         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
1965
1966         * WebView/WebView.mm:
1967         (-[WebView _startDrag:]):
1968         (-[WebView _dragSourceAction]):
1969         (-[WebView _draggedLinkTitle]):
1970         (-[WebView _draggedLinkURL]):
1971         (-[WebView _draggedElementBounds]):
1972         (-[WebView _endedDataInteraction:global:]):
1973         * WebView/WebViewData.h:
1974         * WebView/WebViewPrivate.h:
1975
1976 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1977
1978         Refactor drag start codepaths to plumb a DragItem to client layers
1979         https://bugs.webkit.org/show_bug.cgi?id=173832
1980         Work towards <rdar://problem/32236827>
1981
1982         Reviewed by Ryosuke Niwa and Tim Horton.
1983
1984         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
1985         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
1986         to _startDrag: to match logic used to start a drag on other platforms.
1987
1988         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
1989         through the DragItem struct.
1990
1991         * WebCoreSupport/WebDragClient.h:
1992         * WebCoreSupport/WebDragClient.mm:
1993         (WebDragClient::startDrag):
1994         (WebDragClient::dragSourceActionMaskForPoint):
1995         (WebDragClient::willPerformDragSourceAction):
1996         (WebDragClient::beginDrag):
1997         * WebView/WebView.mm:
1998         (-[WebView _startDrag:]):
1999         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
2000         * WebView/WebViewInternal.h:
2001
2002 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2003
2004         Remove excessive headers from JavaScriptCore
2005         https://bugs.webkit.org/show_bug.cgi?id=173812
2006
2007         Reviewed by Darin Adler.
2008
2009         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2010         * WebView/WebView.mm:
2011
2012 2017-06-23  Tim Horton  <timothy_horton@apple.com>
2013
2014         Remove an unused typedef from WebFrameLoaderClient
2015         https://bugs.webkit.org/show_bug.cgi?id=173795
2016
2017         Reviewed by Simon Fraser.
2018
2019         * WebCoreSupport/WebFrameLoaderClient.h:
2020         This unused typedef in the global namespace conflicts with one in a macOS system header.
2021         Also... it's unused.
2022         Remove it.
2023
2024 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
2025
2026         Remove excessive headers from WebCore/{bindings,css,dom}
2027         https://bugs.webkit.org/show_bug.cgi?id=173766
2028
2029         Reviewed by Simon Fraser.
2030
2031         * DOM/DOMInternal.mm:
2032
2033 2017-06-22  Daniel Bates  <dabates@apple.com>
2034
2035         Make FrameLoadRequest a move-only type
2036         https://bugs.webkit.org/show_bug.cgi?id=173682
2037
2038         Reviewed by Alex Christensen and Darin Adler.
2039
2040         A FrameLoadRequest groups together the information to perform a load into a single object
2041         that is more manageable to pass around than its constituent parts. Code that receives a
2042         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2043         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2044         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2045
2046         * Plugins/WebPluginController.mm:
2047         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2048         * WebView/WebPDFView.mm:
2049         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2050
2051 2017-06-21  Antoine Quint  <graouts@apple.com>
2052
2053         Ensure DRT always logs rAF suspension debugging code
2054         https://bugs.webkit.org/show_bug.cgi?id=173681
2055
2056         Reviewed by Tim "Mr. T" Horton.
2057
2058         * WebView/WebPreferenceKeysPrivate.h:
2059         * WebView/WebPreferences.mm:
2060         (+[WebPreferences initialize]):
2061         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
2062         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
2063         * WebView/WebPreferencesPrivate.h:
2064         * WebView/WebView.mm:
2065         (-[WebView _preferencesChanged:]):
2066
2067 2017-06-21  Daniel Bates  <dabates@apple.com>
2068
2069         Cleanup FrameLoadRequest
2070         https://bugs.webkit.org/show_bug.cgi?id=173564
2071         <rdar://problem/32903570>
2072
2073         Reviewed by Brent Fulgham.
2074
2075         * WebView/WebPDFView.mm:
2076         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
2077         into a local variable and use C++11 brace initialization syntax to make it easier to identify
2078         the arguments passed to FrameLoader::loadFrameRequest().
2079
2080 2017-06-21  Antoine Quint  <graouts@apple.com>
2081
2082         Add logging to identify when the Page suspends scripted animations
2083         https://bugs.webkit.org/show_bug.cgi?id=173626
2084
2085         Reviewed by Tim Horton.
2086
2087         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
2088         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
2089
2090         * WebView/WebPreferenceKeysPrivate.h:
2091         * WebView/WebPreferences.mm:
2092         (+[WebPreferences initialize]):
2093         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
2094         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
2095         * WebView/WebPreferencesPrivate.h:
2096         * WebView/WebView.mm:
2097         (-[WebView _preferencesChanged:]):
2098
2099 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2100
2101         Disable font variations on macOS Sierra and iOS 10
2102         https://bugs.webkit.org/show_bug.cgi?id=173618
2103         <rdar://problem/32879164>
2104
2105         Reviewed by Jon Lee.
2106
2107         * Configurations/FeatureDefines.xcconfig:
2108
2109 2017-06-20  Daniel Bates  <dabates@apple.com>
2110
2111         Have FrameLoadRequest takes a Frame& instead of a Frame*
2112         https://bugs.webkit.org/show_bug.cgi?id=173614
2113         <rdar://problem/32884890>
2114
2115         Reviewed by Brent Fulgham.
2116
2117         * Plugins/WebPluginController.mm:
2118         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2119         * WebView/WebFrame.mm:
2120         (-[WebFrame loadRequest:]):
2121         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2122
2123 2017-06-19  Frederic Wang  <fwang@igalia.com>
2124
2125         [Mac] Add an experimental feature setting for async frame scrolling
2126         https://bugs.webkit.org/show_bug.cgi?id=173359
2127
2128         Reviewed by Simon Fraser.
2129
2130         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
2131         * WebView/WebPreferences.mm:
2132         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
2133         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
2134         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
2135         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
2136         * WebView/WebView.mm:
2137         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
2138         scrolling.
2139
2140 2017-06-19  Chris Dumez  <cdumez@apple.com>
2141
2142         Use WTF::Function instead of std::function in more places in WebCore/
2143         https://bugs.webkit.org/show_bug.cgi?id=173535
2144
2145         Reviewed by Antti Koivisto.
2146
2147         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2148
2149         * WebCoreSupport/WebFrameLoaderClient.h:
2150         * WebCoreSupport/WebFrameLoaderClient.mm:
2151         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2152         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2153         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2154         (WebFrameLoaderClient::dispatchWillSubmitForm):
2155         (WebFrameLoaderClient::setUpPolicyListener):
2156         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
2157         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
2158
2159 2017-05-14 Frederic Wang  <fwang@igalia.com>
2160
2161         Add heuristic to avoid flattening "fullscreen" iframes
2162         https://bugs.webkit.org/show_bug.cgi?id=171914
2163
2164         Reviewed by Simon Fraser.
2165
2166         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
2167
2168         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
2169         * WebView/WebPreferences.mm:
2170         (+[WebPreferences initialize]): Handle frame flattening as an enum.
2171         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
2172         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
2173         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
2174         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
2175         * WebView/WebPreferencesPrivate.h: Ditto.
2176         * WebView/WebView.mm:
2177         (-[WebView _preferencesChanged:]): Ditto.
2178         * WebView/WebPreferencesPrivate.h: Add new enum definition.
2179
2180 2017-06-17  Chris Dumez  <cdumez@apple.com>
2181
2182         Use WTF::Function instead of std::function in WebKit2/
2183         https://bugs.webkit.org/show_bug.cgi?id=173504
2184
2185         Reviewed by Darin Adler.
2186
2187         Use WTF::Function instead of std::function in WebKit2/ to avoid
2188         unnecessary copying.
2189
2190         * Plugins/Hosted/HostedNetscapePluginStream.h:
2191         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2192         (WebKit::HostedNetscapePluginStream::willSendRequest):
2193         * Plugins/WebNetscapePluginStream.h:
2194         * Plugins/WebNetscapePluginStream.mm:
2195         (WebNetscapePluginStream::willSendRequest):
2196         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2197         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2198         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
2199         (WebPaymentCoordinatorClient::openPaymentSetup):
2200
2201 2017-06-16  Sam Weinig  <sam@webkit.org>
2202
2203         [WebIDL] Remove custom bindings for HTMLDocument
2204         https://bugs.webkit.org/show_bug.cgi?id=173444
2205
2206         Reviewed by Darin Adler.
2207
2208         * DOM/DOMHTMLDocument.mm:
2209         (-[DOMHTMLDocument linkColor]):
2210         (-[DOMHTMLDocument setLinkColor:]):
2211         (-[DOMHTMLDocument write:]):
2212         (-[DOMHTMLDocument writeln:]):
2213         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
2214
2215 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2216
2217         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
2218         https://bugs.webkit.org/show_bug.cgi?id=173366
2219         <rdar://problem/32767014>
2220
2221         Reviewed by Tim Horton.
2222
2223         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
2224
2225         * Configurations/FeatureDefines.xcconfig:
2226         * WebCoreSupport/WebDragClient.mm:
2227         (WebDragClient::useLegacyDragClient):
2228         (WebDragClient::willPerformDragDestinationAction):
2229         (WebDragClient::dragSourceActionMaskForPoint):
2230         (WebDragClient::willPerformDragSourceAction):
2231         (WebDragClient::startDrag):
2232         (WebDragClient::beginDrag):
2233         (WebDragClient::declareAndWriteDragImage):
2234         (WebDragClient::declareAndWriteAttachment):
2235         (WebDragClient::didConcludeEditDrag):
2236         * WebView/WebView.mm:
2237         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2238         (-[WebView _getDataInteractionData]):
2239         (-[WebView dragDataForSession:client:global:operation:]):
2240         (-[WebView _enteredDataInteraction:client:global:operation:]):
2241         (-[WebView _updatedDataInteraction:client:global:operation:]):
2242         (-[WebView _exitedDataInteraction:client:global:operation:]):
2243         (-[WebView _performDataInteraction:client:global:operation:]):
2244         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
2245         (-[WebView _endedDataInteraction:global:]):
2246         (-[WebView _didConcludeEditDataInteraction]):
2247         (floatRectsForCGRectArray): Deleted.
2248         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
2249         * WebView/WebViewData.h:
2250         * WebView/WebViewData.mm:
2251         (-[WebViewPrivate dealloc]):
2252         * WebView/WebViewPrivate.h:
2253
2254 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2255
2256         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
2257         https://bugs.webkit.org/show_bug.cgi?id=173454
2258         <rdar://problem/31720671>
2259
2260         Reviewed by Tim Horton.
2261
2262         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
2263         If unimplemented, the default UI delegate allows all actions except for URL loading.
2264
2265         * DefaultDelegates/WebDefaultUIDelegate.mm:
2266         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
2267         * WebView/WebUIDelegatePrivate.h:
2268         * WebView/WebView.mm:
2269         (-[WebView dragDestinationActionMaskForSession:]):
2270
2271 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2272
2273         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
2274         https://bugs.webkit.org/show_bug.cgi?id=173338
2275         <rdar://problem/32777720>
2276
2277         Reviewed by Tim Horton.
2278
2279         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
2280
2281         * WebCoreSupport/WebPlatformStrategies.h:
2282         * WebCoreSupport/WebPlatformStrategies.mm:
2283         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
2284         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
2285
2286 2017-06-13  Daniel Bates  <dabates@apple.com>
2287
2288         Implement W3C Secure Contexts Draft Specification
2289         https://bugs.webkit.org/show_bug.cgi?id=158121
2290         <rdar://problem/26012994>
2291
2292         Reviewed by Brent Fulgham.
2293
2294         Part 4
2295
2296         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2297
2298         * WebView/WebPreferenceKeysPrivate.h:
2299         * WebView/WebPreferences.mm:
2300         (+[WebPreferences initialize]):
2301         (-[WebPreferences isSecureContextAttributeEnabled]):
2302         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
2303         * WebView/WebPreferencesPrivate.h:
2304         * WebView/WebView.mm:
2305         (-[WebView _preferencesChanged:]):
2306
2307 2017-06-13  Sam Weinig  <sam@webkit.org>
2308
2309         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
2310         https://bugs.webkit.org/show_bug.cgi?id=80733
2311
2312         Reviewed by Chris Dumez.
2313
2314         * DOM/DOMUtility.mm:
2315         (createDOMWrapper):
2316         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2317         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2318         * WebView/WebFrame.mm:
2319         (-[WebFrame _attachScriptDebugger]):
2320         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2321
2322 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2323
2324         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2325         https://bugs.webkit.org/show_bug.cgi?id=173197
2326         <rdar://problem/32688148>
2327
2328         Reviewed by Brent Fulgham.
2329
2330         * WebView/WebPreferences.mm:
2331         (+[WebPreferences initialize]):
2332         (-[WebPreferences subtleCryptoEnabled]): Deleted.
2333         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
2334         * WebView/WebPreferencesPrivate.h:
2335         * WebView/WebView.mm:
2336         (-[WebView _preferencesChanged:]):
2337
2338 2017-06-10  Dan Bernstein  <mitz@apple.com>
2339
2340         Reverted r218056 because it made the IDE reindex constantly.
2341
2342         * Configurations/DebugRelease.xcconfig:
2343
2344 2017-06-10  Dan Bernstein  <mitz@apple.com>
2345
2346         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2347         https://bugs.webkit.org/show_bug.cgi?id=173223
2348
2349         Reviewed by Sam Weinig.
2350
2351         The rebuilds were happening due to a difference in the compiler options that the IDE and
2352         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2353         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2354         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2355
2356         * Configurations/DebugRelease.xcconfig:
2357
2358 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2359
2360         [iOS DnD] Add a hook to perform two-step drops in editable content
2361         https://bugs.webkit.org/show_bug.cgi?id=172992
2362         <rdar://problem/32590174>
2363
2364         Reviewed by Tim Horton.
2365
2366         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
2367         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
2368         returning NO will continue with default WebKit behavior.
2369
2370         * WebCoreSupport/WebEditorClient.h:
2371         * WebCoreSupport/WebEditorClient.mm:
2372         (WebEditorClient::performTwoStepDrop):
2373
2374 2017-06-08  Jer Noble  <jer.noble@apple.com>
2375
2376         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
2377         https://bugs.webkit.org/show_bug.cgi?id=173091
2378
2379         Reviewed by Eric Carlson.
2380
2381         * WebView/WebPreferences.mm:
2382         (+[WebPreferences initialize]):
2383
2384 2017-06-07  Jer Noble  <jer.noble@apple.com>
2385
2386         Clean-up: RenderElement.h includes headers it doesn't use
2387         https://bugs.webkit.org/show_bug.cgi?id=173046
2388
2389         Reviewed by Andy Estes.
2390
2391         * WebView/WebImmediateActionController.mm:
2392
2393 2017-06-07  Zalan Bujtas  <zalan@apple.com>
2394
2395         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
2396         https://bugs.webkit.org/show_bug.cgi?id=173044
2397         <rdar://problem/32449338>
2398
2399         Reviewed by Tim Horton.
2400
2401         Cache the current device orientation so that we don't have to lift the WebThread lock
2402         to collect it.
2403
2404         * WebView/WebFrame.mm:
2405         (-[WebFrame deviceOrientationChanged]):
2406         * WebView/WebView.mm:
2407         (-[WebView _commonInitializationWithFrameName:groupName:]):
2408         (-[WebView _setDeviceOrientation:]):
2409         (-[WebView _deviceOrientation]):
2410         * WebView/WebViewData.h:
2411         * WebView/WebViewInternal.h:
2412
2413 2017-06-06  Jer Noble  <jer.noble@apple.com>
2414
2415         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
2416         https://bugs.webkit.org/show_bug.cgi?id=173008
2417
2418         Reviewed by Eric Carlson.
2419
2420         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
2421
2422         * WebView/WebPreferenceKeysPrivate.h:
2423         * WebView/WebPreferences.mm:
2424         (+[WebPreferences initialize]):
2425         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
2426         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
2427         * WebView/WebPreferencesPrivate.h:
2428         * WebView/WebView.mm:
2429         (-[WebView _preferencesChanged:]):
2430
2431 2017-06-06  Youenn Fablet  <youenn@apple.com>
2432
2433         Add an option to disable getUserMedia prompt in case of mock capture sources
2434         https://bugs.webkit.org/show_bug.cgi?id=172981
2435         <rdar://problem/32580325>
2436
2437         Reviewed by Eric Carlson.
2438
2439         Defining the option, getter and setter.
2440
2441         * WebView/WebPreferences.mm:
2442         (+[WebPreferences initialize]):
2443         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
2444         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
2445         * WebView/WebPreferencesPrivate.h:
2446
2447 2017-06-05  Dan Bernstein  <mitz@apple.com>
2448
2449         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
2450
2451         * WebView/WebView.mm:
2452         (-[WebView updateMediaTouchBar]):
2453         * WebView/WebViewData.h:
2454
2455 2017-06-03  Darin Adler  <darin@apple.com>
2456
2457         Streamline handling of attributes, using references as much as possible
2458         https://bugs.webkit.org/show_bug.cgi?id=172899
2459
2460         Reviewed by Chris Dumez.
2461
2462         * WebView/WebHTMLRepresentation.mm:
2463         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
2464         passed in element can't be null. Removed unnecessary conversion from NSString to String
2465         and then back to NSString.
2466
2467 2017-06-01  Andy Estes  <aestes@apple.com>
2468
2469         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2470         https://bugs.webkit.org/show_bug.cgi?id=172828
2471
2472         Reviewed by Beth Dakin.
2473
2474         * Configurations/FeatureDefines.xcconfig:
2475
2476 2017-05-31  Andy Estes  <aestes@apple.com>
2477
2478         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2479         https://bugs.webkit.org/show_bug.cgi?id=172366
2480
2481         Reviewed by Daniel Bates.
2482
2483         * Configurations/FeatureDefines.xcconfig:
2484
2485 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2486
2487         Only include DataDetectorsUI headers in iOS
2488         https://bugs.webkit.org/show_bug.cgi?id=172633
2489
2490         Reviewed by David Kilzer.
2491
2492         Enable data detectors only on iOS and not other variants of iOS.
2493
2494         * WebCoreSupport/WebFrameLoaderClient.mm:
2495
2496 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2497
2498         Update libwebrtc configuration
2499         https://bugs.webkit.org/show_bug.cgi?id=172727
2500
2501         Reviewed by Geoffrey Garen.
2502
2503         * Configurations/FeatureDefines.xcconfig:
2504
2505 2017-05-28  Dan Bernstein  <mitz@apple.com>
2506
2507         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
2508         https://bugs.webkit.org/show_bug.cgi?id=172691
2509
2510         Reviewed by Tim Horton.
2511
2512         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
2513
2514 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
2515
2516         [WK2] Address thread safety issues with ResourceLoadStatistics
2517         https://bugs.webkit.org/show_bug.cgi?id=172519
2518         <rdar://problem/31707642>
2519
2520         Reviewed by Chris Dumez.
2521
2522         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
2523
2524         * WebView/WebView.mm:
2525         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
2526
2527 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
2528
2529         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
2530         https://bugs.webkit.org/show_bug.cgi?id=172554
2531         <rdar://problem/31247133>
2532
2533         Reviewed by Simon Fraser.
2534
2535         Update an overridden internal AppKit function to the new signature.
2536
2537         * WebView/WebHTMLView.mm:
2538         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
2539         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2540         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
2541         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2542
2543 2017-05-24  Jer Noble  <jer.noble@apple.com>
2544
2545         Rename DisplaySleepDisabler -> SleepDisabler
2546         https://bugs.webkit.org/show_bug.cgi?id=172478
2547
2548         Reviewed by Sam Weinig.
2549
2550         * WebView/WebFullScreenController.h:
2551
2552 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2553
2554         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2555         https://bugs.webkit.org/show_bug.cgi?id=172522
2556         rdar://problem/31071812
2557
2558         Reviewed by Tim Horton.
2559
2560         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
2561         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
2562         versions this synchronization is no longer required.
2563
2564         * WebView/WebView.mm:
2565         (LayerFlushController::flushLayers):
2566
2567 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2568
2569         Snapshotting via -renderInContext: should do synchronous image decodes
2570         https://bugs.webkit.org/show_bug.cgi?id=172485
2571         rdar://problem/32276146
2572
2573         Reviewed by Tim Horton.
2574
2575         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
2576         has any callers.
2577
2578         * Plugins/WebBaseNetscapePluginView.h:
2579         * Plugins/WebBaseNetscapePluginView.mm:
2580         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
2581         * WebView/WebFrame.mm:
2582         (-[WebFrame _paintBehaviorForDestinationContext:]):
2583         (-[WebFrame _drawRect:contentsOnly:]):
2584         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
2585         * WebView/WebHTMLView.mm:
2586         (imageFromRect):
2587         * WebView/WebView.mm:
2588         (-[WebView _commonInitializationWithFrameName:groupName:]):
2589         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
2590         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
2591         * WebView/WebViewData.h:
2592         * WebView/WebViewPrivate.h:
2593
2594 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2595
2596         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2597         https://bugs.webkit.org/show_bug.cgi?id=172517
2598
2599         Rubber-stamped by Simon Fraser.
2600
2601         * Configurations/FeatureDefines.xcconfig:
2602
2603 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2604
2605         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2606         https://bugs.webkit.org/show_bug.cgi?id=171984
2607
2608         Reviewed by Antti Koivisto.
2609
2610         * WebView/WebPreferenceKeysPrivate.h:
2611         * WebView/WebPreferences.mm:
2612         (+[WebPreferences initialize]):
2613         (-[WebPreferences displayContentsEnabled]):
2614         (-[WebPreferences setDisplayContentsEnabled:]):
2615         * WebView/WebPreferencesPrivate.h:
2616         * WebView/WebView.mm:
2617         (-[WebView _preferencesChanged:]):
2618
2619 2017-05-22  Youenn Fablet  <youenn@apple.com>
2620
2621         Remove AVAudioCaptureSource
2622         https://bugs.webkit.org/show_bug.cgi?id=172360
2623
2624         Reviewed by Sam Weinig.
2625
2626         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
2627
2628         * WebView/WebPreferenceKeysPrivate.h:
2629         * WebView/WebPreferences.mm:
2630         (+[WebPreferences initialize]):
2631         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
2632         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
2633         * WebView/WebPreferencesPrivate.h:
2634         * WebView/WebView.mm:
2635         (-[WebView _preferencesChanged:]):
2636
2637 2017-05-22  Sam Weinig  <sam@webkit.org>
2638
2639         [WebIDL] Support callbacks with arbitrary return types
2640         https://bugs.webkit.org/show_bug.cgi?id=172407
2641
2642         Reviewed by Chris Dumez.
2643
2644         * DOM/DOM.mm:
2645         (-[DOMNodeFilter acceptNode:]):
2646         Update for CallbackResult adoption in the base class.
2647
2648         * DOM/DOMNodeIterator.mm:
2649         * DOM/DOMTreeWalker.mm:
2650         Update to account for new WebCore implementation return types. We return nil
2651         if there was an exception, since retains the existing behavior if a javascript
2652         NodeFilter had been used (an exception would cause all nodes to be rejected,
2653         thus returning nullptr).
2654
2655         * DOM/ObjCNodeFilterCondition.h:
2656         * DOM/ObjCNodeFilterCondition.mm:
2657         Update to match new interface of NodeFilterCondition.
2658
2659 2017-05-18  Sam Weinig  <sam@webkit.org>
2660
2661         [WebIDL] Remove the need for the generator to know about native type mapping
2662         https://bugs.webkit.org/show_bug.cgi?id=172310
2663
2664         Reviewed by Darin Adler.
2665
2666         * DOM/DOM.mm:
2667         (-[DOMNodeFilter acceptNode:]):
2668         Update to pass Node by reference.
2669
2670 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2671
2672         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
2673         https://bugs.webkit.org/show_bug.cgi?id=172098
2674
2675         Reviewed by Saam Barati.
2676
2677         * Plugins/Hosted/ProxyInstance.mm:
2678         * Plugins/Hosted/ProxyRuntimeObject.mm:
2679
2680 2017-05-18  Andy Estes  <aestes@apple.com>
2681
2682         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
2683         https://bugs.webkit.org/show_bug.cgi?id=172305
2684
2685         Reviewed by Anders Carlsson.
2686
2687         * Configurations/FeatureDefines.xcconfig:
2688
2689 2017-05-18  Commit Queue  <commit-queue@webkit.org>
2690
2691         Unreviewed, rolling out r217031, r217032, and r217037.
2692         https://bugs.webkit.org/show_bug.cgi?id=172293
2693
2694         cause linking errors in Windows (Requested by yusukesuzuki on
2695         #webkit).
2696
2697         Reverted changesets:
2698
2699         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
2700         https://bugs.webkit.org/show_bug.cgi?id=172098
2701         http://trac.webkit.org/changeset/217031
2702
2703         "Unreviewed, rebaseline for newly added ClassInfo"
2704         https://bugs.webkit.org/show_bug.cgi?id=172098
2705         http://trac.webkit.org/changeset/217032
2706
2707         "Unreviewed, fix debug and non-JIT build"
2708         https://bugs.webkit.org/show_bug.cgi?id=172098
2709         http://trac.webkit.org/changeset/217037
2710
2711 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2712
2713         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
2714         https://bugs.webkit.org/show_bug.cgi?id=172098
2715
2716         Reviewed by Saam Barati.
2717
2718         * Plugins/Hosted/ProxyInstance.mm:
2719         * Plugins/Hosted/ProxyRuntimeObject.mm:
2720
2721 2017-05-17  Matt Lewis  <jlewis3@apple.com>
2722
2723         Unreviewed, rolling out r216974.
2724
2725         Revision caused consistent timeouts on all platforms.
2726
2727         Reverted changeset:
2728
2729         "Add a RuntimeEnabledFeature for display: contents, defaulted
2730         to false."
2731         https://bugs.webkit.org/show_bug.cgi?id=171984
2732         http://trac.webkit.org/changeset/216974
2733
2734 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
2735
2736         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2737         https://bugs.webkit.org/show_bug.cgi?id=171984
2738
2739         Reviewed by Antti Koivisto.
2740
2741         * WebView/WebPreferenceKeysPrivate.h:
2742         * WebView/WebPreferences.mm:
2743         (+[WebPreferences initialize]):
2744         (-[WebPreferences displayContentsEnabled]):
2745         (-[WebPreferences setDisplayContentsEnabled:]):
2746         * WebView/WebPreferencesPrivate.h:
2747         * WebView/WebView.mm:
2748         (-[WebView _preferencesChanged:]):
2749
2750 2017-05-16  Sam Weinig  <sam@webkit.org>
2751
2752         Bring Notification.idl up to spec
2753         https://bugs.webkit.org/show_bug.cgi?id=172156
2754
2755         Reviewed by Chris Dumez.
2756
2757         * WebCoreSupport/WebNotificationClient.h:
2758         * WebCoreSupport/WebNotificationClient.mm:
2759         (generateNotificationID):
2760         (WebNotificationClient::show):
2761         (WebNotificationClient::cancel):
2762         (WebNotificationClient::clearNotifications):
2763         (WebNotificationClient::notificationObjectDestroyed):
2764         (WebNotificationClient::requestPermission):
2765         (WebNotificationClient::hasPendingPermissionRequests):
2766         (WebNotificationClient::checkPermission):
2767         (-[WebNotificationPolicyListener allow]):
2768         (-[WebNotificationPolicyListener deny]):
2769         * WebView/WebNotification.mm:
2770         (-[WebNotification iconURL]):
2771         (-[WebNotification dir]):
2772         Simplify #ifdefs and update for enum vs String usage.
2773
2774 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2775
2776         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
2777         https://bugs.webkit.org/show_bug.cgi?id=170640
2778
2779         Reviewed by Simon Fraser.
2780
2781         Enable the async decoding for large images.
2782
2783         * WebView/WebView.mm:
2784         (-[WebView _preferencesChanged:]):
2785
2786 2017-05-15  Jer Noble  <jer.noble@apple.com>
2787
2788         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
2789         https://bugs.webkit.org/show_bug.cgi?id=172131
2790
2791         Reviewed by Eric Carlson.
2792
2793         * WebView/WebPreferenceKeysPrivate.h:
2794         * WebView/WebPreferences.mm:
2795         (+[WebPreferences initialize]):
2796         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
2797         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
2798         * WebView/WebPreferencesPrivate.h:
2799
2800 2017-05-12  Chris Dumez  <cdumez@apple.com>
2801
2802         Drop uses of PassRefPtr in WebKit/mac
2803         https://bugs.webkit.org/show_bug.cgi?id=172066
2804
2805         Reviewed by Sam Weinig.
2806
2807         * History/WebBackForwardListInternal.h:
2808         * History/WebHistoryItem.mm:
2809         (kit):
2810         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
2811         * History/WebHistoryItemInternal.h:
2812         * Plugins/Hosted/HostedNetscapePluginStream.h:
2813         (WebKit::HostedNetscapePluginStream::create):
2814         * Plugins/Hosted/NetscapePluginHostManager.h:
2815         * Plugins/Hosted/NetscapePluginHostManager.mm:
2816         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2817         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2818         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2819         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
2820         (WebKit::NetscapePluginInstanceProxy::create):
2821         (WebKit::NetscapePluginInstanceProxy::setManualStream):
2822         * Plugins/Hosted/ProxyInstance.h:
2823         (WebKit::ProxyInstance::create):
2824         * Plugins/Hosted/ProxyInstance.mm:
2825         (WebKit::ProxyInstance::ProxyInstance):
2826         (WebKit::ProxyInstance::newRuntimeObject):
2827         * Plugins/Hosted/ProxyRuntimeObject.h:
2828         (WebKit::ProxyRuntimeObject::create):
2829         * Plugins/Hosted/ProxyRuntimeObject.mm:
2830         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2831         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2832         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2833         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
2834         * Plugins/WebBaseNetscapePluginView.h:
2835         * Plugins/WebBaseNetscapePluginView.mm:
2836         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
2837         * Plugins/WebNetscapePluginStream.h:
2838         (WebNetscapePluginStream::create):
2839         * Plugins/WebNetscapePluginView.h:
2840         * Plugins/WebNetscapePluginView.mm:
2841         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
2842         * WebCoreSupport/WebChromeClient.mm:
2843         * WebCoreSupport/WebEditorClient.mm:
2844         * WebCoreSupport/WebNotificationClient.mm:
2845         (WebNotificationClient::requestPermission):
2846         (-[WebNotificationPolicyListener initWithCallback:]):
2847         * WebCoreSupport/WebOpenPanelResultListener.mm:
2848         * WebCoreSupport/WebUserMediaClient.mm:
2849         (WebUserMediaClient::requestUserMediaAccess):
2850         (WebUserMediaClient::enumerateMediaDevices):
2851         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
2852         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2853         * WebView/WebArchive.mm:
2854         (-[WebArchivePrivate initWithCoreArchive:]):
2855         (-[WebArchivePrivate setCoreArchive:]):
2856         (-[WebArchive initWithData:]):
2857         (-[WebArchive subframeArchives]):
2858         (-[WebArchive _initWithCoreLegacyWebArchive:]):
2859         * WebView/WebArchiveInternal.h:
2860         * WebView/WebDataSource.mm:
2861         (WebDataSourcePrivate::WebDataSourcePrivate):
2862         (WebDataSourcePrivate::~WebDataSourcePrivate):
2863         (-[WebDataSource _initWithDocumentLoader:]):
2864         * WebView/WebDataSourceInternal.h:
2865         * WebView/WebDeviceOrientation.mm:
2866         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
2867         * WebView/WebDeviceOrientationInternal.h:
2868         * WebView/WebFrame.mm:
2869         (-[WebFrame _convertToDOMRange:]):
2870         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
2871         * WebView/WebFrameInternal.h:
2872         * WebView/WebFullScreenController.h:
2873         * WebView/WebFullScreenController.mm:
2874         (-[WebFullScreenController setElement:]):
2875         * WebView/WebGeolocationPosition.mm:
2876         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2877         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2878         * WebView/WebHTMLView.mm:
2879         (currentKeyboardEvent):
2880         * WebView/WebResource.mm:
2881         * WebView/WebScriptWorld.mm:
2882         (-[WebScriptWorld initWithWorld:]):
2883         (+[WebScriptWorld standardWorld]):
2884         (+[WebScriptWorld findOrCreateWorld:]):
2885         * WebView/WebViewData.h:
2886         (LayerFlushController::create):
2887
2888 2017-05-11  Chris Dumez  <cdumez@apple.com>
2889
2890         Drop remaining uses of PassRefPtr in WebCore
2891         https://bugs.webkit.org/show_bug.cgi?id=172013
2892
2893         Reviewed by Yusuke Suzuki.
2894
2895         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2896         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2897         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2898         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
2899         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2900         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
2901
2902 2017-05-11  Tim Horton  <timothy_horton@apple.com>
2903
2904         Mail spins launching spell checker when typing
2905         https://bugs.webkit.org/show_bug.cgi?id=171986
2906         <rdar://problem/26305327>
2907
2908         Reviewed by Beth Dakin.
2909
2910         * WebView/WebView.mm:
2911         (-[WebView setEditable:]):
2912         Asynchronously pre-warm the spell checker when a WebView becomes editable.
2913
2914 2017-05-09  Sam Weinig  <sam@webkit.org>
2915
2916         Remove support for legacy Notifications
2917         https://bugs.webkit.org/show_bug.cgi?id=171487
2918
2919         Reviewed by Jon Lee.
2920
2921         * Configurations/FeatureDefines.xcconfig:
2922         * WebCoreSupport/WebNotificationClient.h:
2923         * WebCoreSupport/WebNotificationClient.mm:
2924         * WebView/WebNotification.mm:
2925         * WebView/WebNotificationInternal.h:
2926         * WebView/WebView.mm:
2927         (-[WebView _commonInitializationWithFrameName:groupName:]):
2928         (-[WebView _notificationIDForTesting:]):
2929         Remove legacy notification specific code.
2930
2931 2017-05-10  Chris Dumez  <cdumez@apple.com>
2932
2933         Simplify relationship between Attr and Element now that Attr is childless
2934         https://bugs.webkit.org/show_bug.cgi?id=171909
2935
2936         Reviewed by Ryosuke Niwa.
2937
2938         Build fix.
2939
2940         * DOM/DOMAttr.mm:
2941         (-[DOMAttr value]):
2942         (-[DOMAttr setValue:]):
2943
2944 2017-05-08  Chris Dumez  <cdumez@apple.com>
2945
2946         Move 'style' from Element to HTMLElement / SVGElement and make it settable
2947         https://bugs.webkit.org/show_bug.cgi?id=171795
2948
2949         Reviewed by Alex Christensen.
2950
2951         Build fix.
2952
2953         * DOM/DOMElement.mm:
2954         (-[DOMElement style]):
2955         * WebCoreSupport/WebEditorClient.mm:
2956         (WebEditorClient::shouldApplyStyle):
2957         * WebView/WebFrame.mm:
2958         (-[WebFrame _typingStyle]):
2959
2960 2017-05-06  Chris Dumez  <cdumez@apple.com>
2961
2962         Align our IDL files with the latest DOM specification
2963         https://bugs.webkit.org/show_bug.cgi?id=171777
2964
2965         Reviewed by Sam Weinig.
2966
2967         Build fix.
2968
2969         * DOM/DOMDocument.mm:
2970         (-[DOMDocument readyState]):
2971
2972 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
2973
2974         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
2975         https://bugs.webkit.org/show_bug.cgi?id=171610
2976         <rdar://problem/31976820>
2977
2978         Reviewed by Eric Carlson.
2979
2980         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
2981
2982         * WebCoreSupport/WebChromeClient.h:
2983         * WebCoreSupport/WebChromeClient.mm:
2984         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
2985
2986 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2987
2988         Unreviewed, rolling out r216206.
2989         https://bugs.webkit.org/show_bug.cgi?id=171714
2990
2991         Multiple LayoutTests crashing in Document::page() (Requested
2992         by ap on #webkit).
2993
2994         Reverted changeset:
2995
2996         "Remove support for legacy Notifications"
2997         https://bugs.webkit.org/show_bug.cgi?id=171487
2998         http://trac.webkit.org/changeset/216206
2999
3000 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
3001
3002         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
3003         https://bugs.webkit.org/show_bug.cgi?id=171704
3004
3005         Reviewed by Jer Noble.
3006
3007         Fix build by casting result of +whiteColor to UIColor.
3008
3009         * WebView/WebView.mm:
3010         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
3011
3012 2017-05-04  Sam Weinig  <sam@webkit.org>
3013
3014         Remove support for legacy Notifications
3015         https://bugs.webkit.org/show_bug.cgi?id=171487
3016
3017         Reviewed by Jon Lee.
3018
3019         * Configurations/FeatureDefines.xcconfig:
3020         * WebCoreSupport/WebNotificationClient.h:
3021         * WebCoreSupport/WebNotificationClient.mm:
3022         * WebView/WebNotification.mm:
3023         * WebView/WebNotificationInternal.h:
3024         * WebView/WebView.mm:
3025         (-[WebView _commonInitializationWithFrameName:groupName:]):
3026         (-[WebView _notificationIDForTesting:]):
3027         Remove legacy notification specific code.
3028
3029 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
3030
3031         [Cocoa] Stop exporting symbols for ivars that were made private
3032         https://bugs.webkit.org/show_bug.cgi?id=171631
3033
3034         Reviewed by Dan Bernstein.
3035
3036         * WebKit.exp:
3037
3038 2017-05-01  Chris Dumez  <cdumez@apple.com>
3039
3040         Remove some usage of PassRefPtr in editing code
3041         https://bugs.webkit.org/show_bug.cgi?id=171490
3042
3043         Reviewed by Darin Adler.
3044
3045         * WebView/WebFrame.mm:
3046         (-[WebFrame dictationResultMetadataForRange:]):
3047         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3048
3049 2017-05-01  Beth Dakin  <bdakin@apple.com>
3050
3051         On-screen panel for candidate bar is in the wrong place when the caret is at the 
3052         start of a paragraph
3053         https://bugs.webkit.org/show_bug.cgi?id=171453
3054         -and corresponding-
3055         rdar://problem/29779764
3056
3057         Reviewed by Tim Horton.
3058
3059         This bug only happens when the caret is at the beginning of the paragraph, and it 
3060         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
3061         might be correct that absoluteTextQuads() returns no quads in this case, so this 
3062         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
3063
3064         * WebCoreSupport/WebEditorClient.mm:
3065         (WebEditorClient::handleRequestedCandidates):
3066
3067 2017-04-30  Dan Bernstein  <mitz@apple.com>
3068
3069         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
3070         https://bugs.webkit.org/show_bug.cgi?id=171485
3071
3072         Reviewed by Geoffrey Garen.
3073
3074         * WebView/WebView.mm:
3075         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
3076         (-[WebUITextIndicatorData initWithImage:scale:]):
3077
3078 2017-04-28  Youenn Fablet  <youenn@apple.com>
3079
3080         Adding a runtime flag specific to MediaDevices
3081         https://bugs.webkit.org/show_bug.cgi?id=171433
3082
3083         Reviewed by Geoffrey Garen.
3084
3085         Adding a preference for MediaDevices.
3086         Setting media devices runtime flag to false by default.
3087         Setting peer connection and media stream flags to true by default.
3088
3089         * WebView/WebPreferenceKeysPrivate.h:
3090         * WebView/WebPreferences.mm:
3091         (+[WebPreferences initialize]):
3092         (-[WebPreferences mediaDevicesEnabled]):
3093         (-[WebPreferences setMediaDevicesEnabled:]):
3094         * WebView/WebPreferencesPrivate.h:
3095         * WebView/WebView.mm:
3096         (-[WebView _preferencesChanged:]):
3097
3098 2017-04-27  Chris Dumez  <cdumez@apple.com>
3099
3100         Align colspan/rowspan limits with the latest HTML specification
3101         https://bugs.webkit.org/show_bug.cgi?id=171322
3102
3103         Reviewed by Darin Adler.
3104
3105         ObjC bindings build fix.
3106
3107         * DOM/DOMHTMLTableCellElement.mm:
3108         (-[DOMHTMLTableCellElement colSpan]):
3109         (-[DOMHTMLTableCellElement setColSpan:]):
3110
3111 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
3112
3113         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
3114         https://bugs.webkit.org/show_bug.cgi?id=170333
3115
3116         Reviewed by Simon Fraser.
3117
3118         Disbale the async decoding for large images for now.
3119
3120         * WebView/WebView.mm:
3121         (-[WebView _preferencesChanged:]):
3122
3123 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3124
3125         Modernize Frame.h
3126         https://bugs.webkit.org/show_bug.cgi?id=171357
3127
3128         Reviewed by Andy Estes.
3129
3130         * WebCoreSupport/WebEditorClient.h:
3131         * WebCoreSupport/WebEditorClient.mm:
3132         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3133
3134 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3135
3136         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
3137         https://bugs.webkit.org/show_bug.cgi?id=171369
3138         <rdar://problem/31858853>
3139
3140         Reviewed by Dan Bernstein.
3141
3142         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
3143         returns whether or not the data interaction was handled. Due to the difference only in return type
3144         and some staging constraints, this version is prefixed with "_tryTo".
3145
3146         * WebView/WebView.mm:
3147         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3148         * WebView/WebViewPrivate.h:
3149
3150 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         WebItemProviderPasteboard should not synchronously load provided data
3153         https://bugs.webkit.org/show_bug.cgi?id=171341
3154         <rdar://problem/31614010>
3155
3156         Reviewed by Tim Horton.
3157
3158         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
3159
3160         * WebCoreSupport/WebPlatformStrategies.h:
3161         * WebCoreSupport/WebPlatformStrategies.mm:
3162         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
3163
3164 2017-04-26  Zalan Bujtas  <zalan@apple.com>
3165
3166         RTL: recent searches popover is displayed in incorrect location
3167         https://bugs.webkit.org/show_bug.cgi?id=171338
3168         <rdar://problem/31377807>
3169
3170         Reviewed by Dean Jackson.
3171
3172         Add RTL support for the pop-under branch.
3173
3174         * WebCoreSupport/PopupMenuMac.mm:
3175         (PopupMenuMac::show):
3176
3177 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
3178
3179         Limit allowed size of document.title to avoid locking WebKit clients
3180         https://bugs.webkit.org/show_bug.cgi?id=165113
3181         <rdar://problem/28324389>
3182
3183         Reviewed by Darin Adler.
3184
3185         When a web application attempts to set an extremely long title, truncate the
3186         title to a more reasonable size.
3187
3188         We do this at at the presentation layer, rather than in the DOM, so that we do
3189         not affect script function. Instead, we merely limit display to a level that is
3190         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
3191         layer, so it is a waste of effort to send across IPC.
3192
3193         * WebCoreSupport/WebFrameLoaderClient.h:
3194         * WebCoreSupport/WebFrameLoaderClient.mm:
3195         (WebFrameLoaderClient::dispatchDidReceiveTitle):
3196
3197 2017-04-25  Daniel Bates  <dabates@apple.com>
3198
3199         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
3200         https://bugs.webkit.org/show_bug.cgi?id=136452
3201         <rdar://problem/23412620>
3202
3203         Reviewed by Brent Fulgham.
3204
3205         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
3206
3207         * Configurations/FeatureDefines.xcconfig:
3208
3209 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3210
3211         Support reading NSURL titles from the pasteboard when performing data interaction
3212         https://bugs.webkit.org/show_bug.cgi?id=171156
3213         <rdar://problem/31356937>
3214
3215         Reviewed by Tim Horton.
3216
3217         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
3218
3219         * WebCoreSupport/WebPlatformStrategies.h:
3220         * WebCoreSupport/WebPlatformStrategies.mm:
3221         (WebPlatformStrategies::readURLFromPasteboard):
3222         * WebView/WebFrame.mm:
3223         (-[WebFrame hasRichlyEditableDragCaret]):
3224         * WebView/WebFramePrivate.h:
3225
3226 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
3227
3228         Clean up ICU headers
3229         https://bugs.webkit.org/show_bug.cgi?id=170997
3230
3231         Reviewed by JF Bastien.
3232
3233         Update all icu headers to 55.1
3234
3235         * icu/README: Explain ICU headers for OS X better
3236         * icu/unicode/localpointer.h:
3237         (LocalPointer::LocalPointer):
3238         (LocalPointer::adoptInsteadAndCheckErrorCode):
3239         * icu/unicode/platform.h:
3240         * icu/unicode/putil.h:
3241         * icu/unicode/uchar.h:
3242         * icu/unicode/uconfig.h:
3243         * icu/unicode/ucurr.h:
3244         * icu/unicode/uidna.h:
3245         * icu/unicode/umachine.h:
3246         * icu/unicode/urename.h:
3247         * icu/unicode/uscript.h:
3248         * icu/unicode/ustring.h:
3249         * icu/unicode/utf8.h:
3250         * icu/unicode/utypes.h:
3251         * icu/unicode/uvernum.h:
3252
3253 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3254
3255         Respect fidelity order when reading web content from item providers
3256         https://bugs.webkit.org/show_bug.cgi?id=171155
3257         <rdar://problem/31356937>
3258
3259         Reviewed by Tim Horton.
3260
3261         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
3262
3263         * WebCoreSupport/WebPlatformStrategies.h:
3264         * WebCoreSupport/WebPlatformStrategies.mm:
3265         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
3266
3267 2017-04-24  Alex Christensen  <achristensen@webkit.org>
3268
3269         Reduce copies and allocations in SharedBuffer::append
3270         https://bugs.webkit.org/show_bug.cgi?id=170956
3271
3272         Reviewed by Andreas Kling.
3273
3274         * WebView/WebArchive.mm:
3275         (-[WebArchive initWithData:]):
3276         * WebView/WebFrame.mm:
3277         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3278         * WebView/WebResource.mm:
3279         (-[WebResource initWithCoder:]):
3280         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3281
3282 2017-04-24  Dan Bernstein  <mitz@apple.com>
3283
3284         [Cocoa] Some ivars are needlessly @protected
3285         https://bugs.webkit.org/show_bug.cgi?id=171208
3286
3287         Reviewed by Anders Carlsson
3288
3289         Made ivars @private where possible.
3290
3291         * Misc/WebUserContentURLPattern.h:
3292         * Plugins/WebPluginDatabase.h:
3293         * Storage/WebDatabaseQuotaManager.h:
3294         * WebCoreSupport/WebSecurityOriginPrivate.h:
3295         * WebInspector/WebInspector.h:
3296         * WebView/WebDeviceOrientation.h:
3297         * WebView/WebDeviceOrientationProviderMock.h:
3298         * WebView/WebGeolocationPosition.h:
3299         * WebView/WebHTMLRepresentation.h:
3300         * WebView/WebNotification.h:
3301
3302 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3303
3304         Support writing link titles to the pasteboard when beginning data interaction on a link
3305         https://bugs.webkit.org/show_bug.cgi?id=171154
3306         <rdar://problem/31356937>
3307
3308         Reviewed by Andy Estes.
3309
3310         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
3311         and WebKit2 ChangeLogs for more details.
3312
3313         * WebCoreSupport/WebPlatformStrategies.h:
3314         * WebCoreSupport/WebPlatformStrategies.mm:
3315         (WebPlatformStrategies::writeToPasteboard):
3316
3317 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3318
3319         Unreviewed, rolling out r215608.
3320
3321         Hundreds of test failures on GTK bot
3322
3323         Reverted changeset:
3324
3325         "Reduce copies and allocations in SharedBuffer::append"
3326         https://bugs.webkit.org/show_bug.cgi?id=170956
3327         http://trac.webkit.org/changeset/215608
3328
3329 2017-04-21  Alex Christensen  <achristensen@webkit.org>
3330
3331         Reduce copies and allocations in SharedBuffer::append
3332         https://bugs.webkit.org/show_bug.cgi?id=170956
3333
3334         Reviewed by Andreas Kling.
3335
3336         * WebView/WebArchive.mm:
3337         (-[WebArchive initWithData:]):
3338         * WebView/WebFrame.mm:
3339         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3340         * WebView/WebResource.mm:
3341         (-[WebResource initWithCoder:]):
3342         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3343
3344 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
3345
3346         Build fix to start using C++14.
3347         https://bugs.webkit.org/show_bug.cgi?id=171038
3348
3349         Reviewed by Alex Christensen.
3350
3351         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
3352
3353         * Configurations/WebKitLegacy.xcconfig:
3354
3355 2017-04-19  Youenn Fablet  <youenn@apple.com>
3356
3357         [Mac] Allow customizing H264 encoder
3358         https://bugs.webkit.org/show_bug.cgi?id=170829
3359
3360         Reviewed by Alex Christensen.
3361
3362         * Configurations/FeatureDefines.xcconfig:
3363
3364 2017-04-19  Anders Carlsson  <andersca@apple.com>
3365
3366         Stop using deprecated APIs, part 3
3367         https://bugs.webkit.org/show_bug.cgi?id=171003
3368         rdar://problem/31589635
3369
3370         Reviewed by Tim Horton.
3371
3372         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3373         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3374         (WebPaymentCoordinatorClient::cancelPaymentSession):
3375         Update for WebCore changes.
3376
3377 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3378
3379         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
3380         https://bugs.webkit.org/show_bug.cgi?id=170880
3381         <rdar://problem/31314689>
3382
3383         Reviewed by Tim Horton.
3384
3385         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
3386
3387         * WebCoreSupport/WebPlatformStrategies.h:
3388         * WebCoreSupport/WebPlatformStrategies.mm:
3389         (WebPlatformStrategies::getFilenamesForDataInteraction):
3390
3391 2017-04-17  Youenn Fablet  <youenn@apple.com>
3392
3393         Disable outdated WritableStream API
3394         https://bugs.webkit.org/show_bug.cgi?id=170749
3395         <rdar://problem/31446233>
3396
3397         Reviewed by Alex Christensen.
3398
3399         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
3400         - A STREAMS_API compilation flag.
3401         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
3402
3403         * Configurations/FeatureDefines.xcconfig:
3404         * WebView/WebPreferenceKeysPrivate.h:
3405         * WebView/WebPreferences.mm:
3406         (+[WebPreferences initialize]):
3407         (-[WebPreferences readableByteStreamAPIEnabled]):
3408         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
3409         (-[WebPreferences writableStreamAPIEnabled]):
3410         (-[WebPreferences setWritableStreamAPIEnabled:]):
3411         * WebView/WebPreferencesPrivate.h:
3412         * WebView/WebView.mm:
3413         (-[WebView _preferencesChanged:]):
3414
3415 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         [WK2] Support data interaction of files into file inputs
3418         https://bugs.webkit.org/show_bug.cgi?id=170803
3419         <rdar://problem/31286130>
3420
3421         Reviewed by Tim Horton.
3422
3423         Add boilerplate plumbing for fetching the number of files in the pasteboard.
3424
3425         * WebCoreSupport/WebPlatformStrategies.h:
3426         * WebCoreSupport/WebPlatformStrategies.mm:
3427         (WebPlatformStrategies::getNumberOfFiles):
3428
3429 2017-04-14  Mark Lam  <mark.lam@apple.com>
3430
3431         Update architectures in xcconfig files.
3432         https://bugs.webkit.org/show_bug.cgi?id=170867
3433         <rdar://problem/31628104>
3434
3435         Reviewed by Joseph Pecoraro.
3436
3437         * Configurations/FeatureDefines.xcconfig:
3438
3439 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3440
3441         [WK2] Support Icon creation from file URLs on iOS
3442         https://bugs.webkit.org/show_bug.cgi?id=170809
3443         <rdar://problem/31286130>
3444
3445         Reviewed by Tim Horton.
3446
3447         Adjust for changes in the ChromeClient in WebCore.
3448
3449         * WebCoreSupport/WebChromeClient.h:
3450         * WebCoreSupport/WebChromeClient.mm:
3451         (WebChromeClient::loadIconForFiles):
3452         (WebChromeClient::createIconForFiles):
3453
3454 2017-04-12  Dan Bernstein  <mitz@apple.com>
3455
3456         [Mac] Future-proof .xcconfig files
3457         https://bugs.webkit.org/show_bug.cgi?id=170802
3458
3459         Reviewed by Tim Horton.
3460
3461         * Configurations/Base.xcconfig:
3462         * Configurations/DebugRelease.xcconfig:
3463         * Configurations/FeatureDefines.xcconfig:
3464         * Configurations/Version.xcconfig:
3465
3466 2017-04-12  Beth Dakin  <bdakin@apple.com>
3467
3468         Build fix.
3469
3470         * WebView/WebViewData.h:
3471
3472 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
3473
3474         Should always override -[WebStorageManager init].
3475         https://bugs.webkit.org/show_bug.cgi?id=170787
3476         -and corresponding-
3477         rdar://problem/31371835
3478
3479         Reviewed by Anders Carlsson.
3480
3481         * Storage/WebStorageManager.mm:
3482         (-[WebStorageManager init]):
3483
3484 2017-04-12  Beth Dakin  <bdakin@apple.com>
3485
3486         Speculative build fix. 
3487
3488         * WebView/WebViewData.h:
3489
3490 2017-04-12  Beth Dakin  <bdakin@apple.com>
3491
3492         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
3493         https://bugs.webkit.org/show_bug.cgi?id=170693
3494         -and corresponding-
3495         rdar://problem/31230018
3496
3497         Reviewed by Sam Weinig.