Use a 1-byte enum class for TextDirection
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2
3         Use a 1-byte enum class for TextDirection
4         https://bugs.webkit.org/show_bug.cgi?id=188350
5
6         Reviewed by Simon Fraser.
7
8         * WebCoreSupport/PopupMenuMac.mm:
9         (PopupMenuMac::populate):
10         (PopupMenuMac::show):
11         * WebCoreSupport/WebFrameLoaderClient.mm:
12         (WebFrameLoaderClient::transitionToCommittedForNewPage):
13         * WebView/WebFrame.mm:
14         (-[WebFrame _dispatchDidReceiveTitle:]):
15
16 2018-08-09  Ali Juma  <ajuma@chromium.org>
17
18         Import WPTs for IntersectionObserver
19         https://bugs.webkit.org/show_bug.cgi?id=188416
20
21         Reviewed by Simon Fraser.
22
23         * WebView/WebPreferencesPrivate.h:
24
25 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
26
27         Follow-up build fix for r234685
28         https://bugs.webkit.org/show_bug.cgi?id=188245
29
30         Unreviewed build fix.
31
32         * WebCoreSupport/WebSecurityOriginPrivate.h:
33
34 2018-08-05  Darin Adler  <darin@apple.com>
35
36         [Cocoa] More tweaks and refactoring to prepare for ARC
37         https://bugs.webkit.org/show_bug.cgi?id=188245
38
39         Reviewed by Dan Bernstein.
40
41         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
42
43         * Carbon/CarbonWindowFrame.m:
44         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
45
46         * DOM/DOM.mm:
47         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
48         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
49         garbage collection so this method isn't useful.
50
51         * DOM/DOMXPath.mm:
52         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
53         Objective-C garbage collection so this method isn't useful.
54
55         * History/WebHistory.mm:
56         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
57
58         * Misc/WebElementDictionary.mm:
59         (addLookupKey): Use a bridging cast.
60         (cacheValueForKey): Ditto.
61         (-[WebElementDictionary _fillCache]): Ditto.
62         (-[WebElementDictionary objectForKey:]): Ditto.
63
64         * Misc/WebKitNSStringExtras.mm:
65         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
66         (-[NSString _web_widthWithFont:]): Ditto.
67         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
68
69         * Misc/WebLocalizableStrings.mm:
70         (WebLocalizedString): Use a bridging cast.
71
72         * Misc/WebNSDataExtras.mm:
73         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
74         and use CFBridgingRelease instead of calling autorelease directly.
75         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
76         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
77         on the amount of explicit release and autorelease.
78
79         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
80         * Misc/WebNSDictionaryExtras.m:
81         (-[NSDictionary _webkit_intForKey:]): Deleted.
82         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
83         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
84         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
85         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
86         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
87         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
88
89         * Misc/WebStringTruncator.mm:
90         (fontFromNSFont): Use a bridging cast.
91
92         * Plugins/Hosted/NetscapePluginHostManager.mm:
93         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
94
95         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
96         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
97         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
98         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
99         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
100         * Plugins/Hosted/ProxyInstance.mm:
101         (WebKit::ProxyInstance::getPropertyNames): Ditto.
102         * Plugins/WebBasePluginPackage.mm:
103         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
104         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
105         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
106         * Plugins/WebNetscapePluginPackage.mm:
107         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
108
109         * Plugins/WebNetscapePluginView.mm:
110         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
111         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
112         (-[WebNetscapePluginView status:]): Use a bridging cast.
113         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
114
115         * Plugins/WebPluginController.mm:
116         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
117
118         * Plugins/WebPluginDatabase.mm:
119         (checkCandidate): Use explicit __strong for out argument types.
120
121         * Plugins/npapi.mm:
122         (pluginViewForInstance): Use a bridging cast.
123
124         * Storage/WebDatabaseManager.mm:
125         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
126         explicit NSNumber and NSDictionary calls.
127
128         * WebCoreSupport/WebContextMenuClient.mm:
129         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
130
131         * WebCoreSupport/WebEditorClient.mm:
132         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
133         (WebEditorClient::handleInputMethodKeydown): Ditto.
134
135         * WebCoreSupport/WebFrameNetworkingContext.mm:
136         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
137
138         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
139         as a struct rather than an Objective-C class, since that's how it's defined.
140
141         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
142
143         * WebView/WebFullScreenController.mm:
144         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
145         * WebView/WebHTMLView.mm:
146         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
147         Ditto.
148         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
149
150         * WebView/WebImmediateActionController.mm:
151         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
152         go down to the document and then back to the frame.
153         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
154         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
155         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
156
157         * WebView/WebJSPDFDoc.mm:
158         (jsPDFDocInitialize): Removed some unneeded type casting.
159         (jsPDFDocFinalize): Ditto.
160         (jsPDFDocPrint): Use a bridging cast.
161
162         * WebView/WebPDFView.mm:
163         (_applicationInfoForMIMEType): Use bridging casts.
164
165         * WebView/WebPreferences.mm:
166         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
167         instead of methods from WebNSDictionaryExtras.
168         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
169         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
170         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
171         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
172         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
173
174         * WebView/WebView.mm:
175         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
176         (-[WebView _addToAllWebViewsSet]): Ditto.
177         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
178         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
179         so it can be called from WebViewData methods.
180
181         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
182         method, _windowVisibilityChanged:.
183
184         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
185         called from WebViewData methods.
186
187 2018-08-06  Alex Christensen  <achristensen@webkit.org>
188
189         Use enum classes and OptionSets for PaintPhase and PaintBehavior
190         https://bugs.webkit.org/show_bug.cgi?id=188323
191
192         Reviewed by Simon Fraser.
193
194         * WebCoreSupport/WebContextMenuClient.mm:
195         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
196         * WebView/WebFrame.mm:
197         (-[WebFrame _paintBehaviorForDestinationContext:]):
198         (-[WebFrame _drawRect:contentsOnly:]):
199         * WebView/WebHTMLView.mm:
200         (imageFromRect):
201         (selectionImage):
202
203 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
204
205         Add support for microtasks in workers
206         https://bugs.webkit.org/show_bug.cgi?id=188246
207
208         Reviewed by Darin Adler.
209
210         Rename JSMainThreadExecState.h to JSExecState.h.
211
212         * DOM/DOMAttr.mm:
213         * DOM/DOMBlob.mm:
214         * DOM/DOMCDATASection.mm:
215         * DOM/DOMCSSCharsetRule.mm:
216         * DOM/DOMCSSFontFaceRule.mm:
217         * DOM/DOMCSSImportRule.mm:
218         * DOM/DOMCSSMediaRule.mm:
219         * DOM/DOMCSSPageRule.mm:
220         * DOM/DOMCSSPrimitiveValue.mm:
221         * DOM/DOMCSSRule.mm:
222         * DOM/DOMCSSRuleList.mm:
223         * DOM/DOMCSSStyleDeclaration.mm:
224         * DOM/DOMCSSStyleRule.mm:
225         * DOM/DOMCSSStyleSheet.mm:
226         * DOM/DOMCSSUnknownRule.mm:
227         * DOM/DOMCSSValue.mm:
228         * DOM/DOMCSSValueList.mm:
229         * DOM/DOMCharacterData.mm:
230         * DOM/DOMComment.mm:
231         * DOM/DOMCounter.mm:
232         * DOM/DOMDocument.mm:
233         * DOM/DOMDocumentFragment.mm:
234         * DOM/DOMDocumentType.mm:
235         * DOM/DOMElement.mm:
236         * DOM/DOMEvent.mm:
237         * DOM/DOMFile.mm:
238         * DOM/DOMFileList.mm:
239         * DOM/DOMHTML.mm:
240         * DOM/DOMHTMLAnchorElement.mm:
241         * DOM/DOMHTMLAppletElement.mm:
242         * DOM/DOMHTMLAreaElement.mm:
243         * DOM/DOMHTMLBRElement.mm:
244         * DOM/DOMHTMLBaseElement.mm:
245         * DOM/DOMHTMLBaseFontElement.mm:
246         * DOM/DOMHTMLBodyElement.mm:
247         * DOM/DOMHTMLButtonElement.mm:
248         * DOM/DOMHTMLCanvasElement.mm:
249         * DOM/DOMHTMLCollection.mm:
250         * DOM/DOMHTMLDListElement.mm:
251         * DOM/DOMHTMLDirectoryElement.mm:
252         * DOM/DOMHTMLDivElement.mm:
253         * DOM/DOMHTMLDocument.mm:
254         * DOM/DOMHTMLElement.mm:
255         * DOM/DOMHTMLEmbedElement.mm:
256         * DOM/DOMHTMLFieldSetElement.mm:
257         * DOM/DOMHTMLFontElement.mm:
258         * DOM/DOMHTMLFormElement.mm:
259         * DOM/DOMHTMLFrameElement.mm:
260         * DOM/DOMHTMLFrameSetElement.mm:
261         * DOM/DOMHTMLHRElement.mm:
262         * DOM/DOMHTMLHeadElement.mm:
263         * DOM/DOMHTMLHeadingElement.mm:
264         * DOM/DOMHTMLHtmlElement.mm:
265         * DOM/DOMHTMLIFrameElement.mm:
266         * DOM/DOMHTMLImageElement.mm:
267         * DOM/DOMHTMLInputElement.mm:
268         * DOM/DOMHTMLLIElement.mm:
269         * DOM/DOMHTMLLabelElement.mm:
270         * DOM/DOMHTMLLegendElement.mm:
271         * DOM/DOMHTMLLinkElement.mm:
272         * DOM/DOMHTMLMapElement.mm:
273         * DOM/DOMHTMLMarqueeElement.mm:
274         * DOM/DOMHTMLMediaElement.mm:
275         * DOM/DOMHTMLMenuElement.mm:
276         * DOM/DOMHTMLMetaElement.mm:
277         * DOM/DOMHTMLModElement.mm:
278         * DOM/DOMHTMLOListElement.mm:
279         * DOM/DOMHTMLObjectElement.mm:
280         * DOM/DOMHTMLOptGroupElement.mm:
281         * DOM/DOMHTMLOptionElement.mm:
282         * DOM/DOMHTMLOptionsCollection.mm:
283         * DOM/DOMHTMLParagraphElement.mm:
284         * DOM/DOMHTMLParamElement.mm:
285         * DOM/DOMHTMLPreElement.mm:
286         * DOM/DOMHTMLQuoteElement.mm:
287         * DOM/DOMHTMLScriptElement.mm:
288         * DOM/DOMHTMLSelectElement.mm:
289         * DOM/DOMHTMLStyleElement.mm:
290         * DOM/DOMHTMLTableCaptionElement.mm:
291         * DOM/DOMHTMLTableCellElement.mm:
292         * DOM/DOMHTMLTableColElement.mm:
293         * DOM/DOMHTMLTableElement.mm:
294         * DOM/DOMHTMLTableRowElement.mm:
295         * DOM/DOMHTMLTableSectionElement.mm:
296         * DOM/DOMHTMLTextAreaElement.mm:
297         * DOM/DOMHTMLTitleElement.mm:
298         * DOM/DOMHTMLUListElement.mm:
299         * DOM/DOMHTMLVideoElement.mm:
300         * DOM/DOMImplementation.mm:
301         * DOM/DOMKeyboardEvent.mm:
302         * DOM/DOMMediaError.mm:
303         * DOM/DOMMediaList.mm:
304         * DOM/DOMMouseEvent.mm:
305         * DOM/DOMMutationEvent.mm:
306         * DOM/DOMNamedNodeMap.mm:
307         * DOM/DOMNode.mm:
308         * DOM/DOMNodeIterator.mm:
309         * DOM/DOMNodeList.mm:
310         * DOM/DOMOverflowEvent.mm:
311         * DOM/DOMProcessingInstruction.mm:
312         * DOM/DOMProgressEvent.mm:
313         * DOM/DOMRGBColor.mm:
314         * DOM/DOMRange.mm:
315         * DOM/DOMRect.mm:
316         * DOM/DOMStyleSheet.mm:
317         * DOM/DOMStyleSheetList.mm:
318         * DOM/DOMText.mm:
319         * DOM/DOMTextEvent.mm:
320         * DOM/DOMTimeRanges.mm:
321         * DOM/DOMTokenList.mm:
322         * DOM/DOMTreeWalker.mm:
323         * DOM/DOMUIEvent.mm:
324         * DOM/DOMWheelEvent.mm:
325         * DOM/DOMXPathExpression.mm:
326         * DOM/DOMXPathResult.mm:
327         * DOM/ObjCEventListener.mm:
328
329 2018-08-03  Alex Christensen  <achristensen@webkit.org>
330
331         Fix spelling of "overridden"
332         https://bugs.webkit.org/show_bug.cgi?id=188315
333
334         Reviewed by Darin Adler.
335
336         * Misc/WebKitVersionChecks.mm:
337         (setWebKitLinkTimeVersion):
338         (WebKitLinkTimeVersion):
339         * Plugins/WebBaseNetscapePluginView.mm:
340         (-[WebBaseNetscapePluginView handleMouseMoved:]):
341         * WebCoreSupport/PopupMenuMac.mm:
342         (PopupMenuMac::populate):
343
344 2018-08-01  Nan Wang  <n_wang@apple.com>
345
346         AX: AOM: Add ARIA IDL Attribute Reflection
347         https://bugs.webkit.org/show_bug.cgi?id=184676
348         <rdar://problem/39476882>
349
350         Reviewed by Chris Fleizach.
351
352         * WebView/WebPreferenceKeysPrivate.h:
353         * WebView/WebPreferences.mm:
354         (+[WebPreferences initialize]):
355         (-[WebPreferences ariaReflectionEnabled]):
356         (-[WebPreferences setAriaReflectionEnabled:]):
357         * WebView/WebPreferencesPrivate.h:
358         * WebView/WebView.mm:
359         (-[WebView _preferencesChanged:]):
360
361 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
362
363         Shrink GraphicsLayerCA
364         https://bugs.webkit.org/show_bug.cgi?id=188141
365
366         Reviewed by Zalan Bujtas.
367
368         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
369         * moving all the clone-related stuff into the lazily-allocated m_layerClones
370         * moving all the animation-related stuff into the lazily-allocated m_animations
371         * making enums be 8-bit
372         * re-ordering data members
373
374         * WebView/WebView.mm:
375         (-[WebView _setMediaLayer:forPluginView:]):
376
377 2018-07-30  Rob Buis  <rbuis@igalia.com>
378
379         Merge PlatformCookieJar functions into NetworkStorageSession
380         https://bugs.webkit.org/show_bug.cgi?id=188137
381
382         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
383
384         Reviewed by Alex Christensen.
385
386         * WebCoreSupport/WebPlatformStrategies.mm:
387         (WebPlatformStrategies::cookiesForDOM):
388         (WebPlatformStrategies::setCookiesFromDOM):
389         (WebPlatformStrategies::cookiesEnabled):
390         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
391         (WebPlatformStrategies::getRawCookies):
392         (WebPlatformStrategies::deleteCookie):
393         * WebView/WebPreferences.mm:
394         (+[WebPreferences _clearNetworkLoaderSession]):
395
396 2018-07-28  Darin Adler  <darin@apple.com>
397
398         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
399         https://bugs.webkit.org/show_bug.cgi?id=188140
400
401         Reviewed by Sam Weinig.
402
403         * WebView/WebImmediateActionController.mm:
404         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
405         new DictionaryLookup function that returns a tuple instead of using an out argument.
406
407 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
408
409         [INTL] Remove INTL sub-feature compile flags
410         https://bugs.webkit.org/show_bug.cgi?id=188081
411
412         Reviewed by Michael Catanzaro.
413
414         * Configurations/FeatureDefines.xcconfig:
415
416 2018-07-26  Commit Queue  <commit-queue@webkit.org>
417
418         Unreviewed, rolling out r234181 and r234189.
419         https://bugs.webkit.org/show_bug.cgi?id=188075
420
421         These are not needed right now (Requested by thorton on
422         #webkit).
423
424         Reverted changesets:
425
426         "Enable Web Content Filtering on watchOS"
427         https://bugs.webkit.org/show_bug.cgi?id=187979
428         https://trac.webkit.org/changeset/234181
429
430         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
431         https://bugs.webkit.org/show_bug.cgi?id=187985
432         https://trac.webkit.org/changeset/234189
433
434 2018-07-26  Timothy Hatcher  <timothy@apple.com>
435
436         Use the Page's appearance when converting pasteboard attributed strings.
437         https://bugs.webkit.org/show_bug.cgi?id=188067
438         rdar://problem/42632246
439
440         Reviewed by Wenson Hsieh.
441
442         * WebCoreSupport/WebEditorClient.mm:
443         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
444
445 2018-07-25  Chris Dumez  <cdumez@apple.com>
446
447         navigator.userAgent may return outdated value after webView.customUserAgent is set
448         https://bugs.webkit.org/show_bug.cgi?id=188009
449         <rdar://problem/42566456>
450
451         Reviewed by Alex Christensen.
452
453         Let the page know when the user agent changes.
454
455         * WebView/WebView.mm:
456         (-[WebView _preferencesChanged:]):
457         (-[WebView setApplicationNameForUserAgent:]):
458         (-[WebView _invalidateUserAgentCache]):
459         (-[WebView setCustomUserAgent:]):
460         * WebView/WebViewInternal.h:
461
462 2018-07-24  Tim Horton  <timothy_horton@apple.com>
463
464         Enable Web Content Filtering on watchOS
465         https://bugs.webkit.org/show_bug.cgi?id=187979
466         <rdar://problem/42559346>
467
468         Reviewed by Wenson Hsieh.
469
470         * Configurations/FeatureDefines.xcconfig:
471
472 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
473
474         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
475         https://bugs.webkit.org/show_bug.cgi?id=187846
476
477         Reviewed by Simon Fraser.
478
479         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
480
481         * WebView/WebHTMLView.mm:
482         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
483         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
484
485 2018-07-11  Dean Jackson  <dino@apple.com>
486
487         Allow removal of white backgrounds
488         https://bugs.webkit.org/show_bug.cgi?id=187574
489         <rdar://problem/41146792>
490
491         Reviewed by Simon Fraser.
492
493         Add a new WebPreference for punching out white backgrounds.
494
495         * WebView/WebPreferenceKeysPrivate.h:
496         * WebView/WebPreferences.mm:
497         (+[WebPreferences initialize]):
498         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
499         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
500         * WebView/WebPreferencesPrivate.h:
501         * WebView/WebView.mm:
502         (-[WebView _preferencesChanged:]):
503
504 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
505
506         Ensure WebKit stack is ad-hoc signed
507         https://bugs.webkit.org/show_bug.cgi?id=187667
508
509         Reviewed by Alexey Proskuryakov.
510
511         * Configurations/Base.xcconfig:
512
513 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
514
515         REGRESSION (231276): Attempting to copy an image fails
516         https://bugs.webkit.org/show_bug.cgi?id=187212
517         <rdar://problem/41540074>
518
519         Reviewed by Ryosuke Niwa.
520
521         Renamed methods to make it clear that one URL and one title are being passed in.
522
523         * WebCoreSupport/WebPlatformStrategies.h:
524         * WebCoreSupport/WebPlatformStrategies.mm:
525         (WebPlatformStrategies::setURL):
526
527 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
528
529         Disable cross-origin-window-policy by default
530         https://bugs.webkit.org/show_bug.cgi?id=187509
531
532         Reviewed by Chris Dumez.
533
534         * WebView/WebPreferences.mm:
535         (+[WebPreferences initialize]):
536
537 2018-07-09  Timothy Hatcher  <timothy@apple.com>
538
539         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
540         https://bugs.webkit.org/show_bug.cgi?id=187425
541         rdar://problem/39948240
542
543         Reviewed by Tim Horton.
544
545         * WebView/WebView.mm:
546         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
547         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
548         a call in this method to setUseDarkAppearance.
549         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
550         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
551         (-[WebView _updateDefaultAppearance]): Deleted.
552         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
553
554 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
555
556         Shrink various loading-related enums to shrink CachedResource
557         https://bugs.webkit.org/show_bug.cgi?id=187443
558
559         Reviewed by Chris Dumez.
560
561         * WebCoreSupport/WebFrameLoaderClient.mm:
562         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
563         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
564         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
565         (WebFrameLoaderClient::dispatchWillSendRequest):
566         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
567         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
568         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
569         (WebFrameLoaderClient::updateGlobalHistory):
570         (WebFrameLoaderClient::canHandleRequest const):
571         * WebView/WebDataSource.mm:
572         (-[WebDataSource initialRequest]):
573         (-[WebDataSource request]):
574
575 2018-07-09  Commit Queue  <commit-queue@webkit.org>
576
577         Unreviewed, rolling out r233612.
578         https://bugs.webkit.org/show_bug.cgi?id=187475
579
580         Revision caused the api test LinkColorWithSystemAppearance to
581         fail on all systems. (Requested by Truitt on #webkit).
582
583         Reverted changeset:
584
585         "Semantic colors don't update when accessibility Increase
586         Contrast mode is enabled."
587         https://bugs.webkit.org/show_bug.cgi?id=187425
588         https://trac.webkit.org/changeset/233612
589
590 2018-07-06  Timothy Hatcher  <timothy@apple.com>
591
592         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
593         https://bugs.webkit.org/show_bug.cgi?id=187425
594         rdar://problem/39948240
595
596         Reviewed by Tim Horton.
597
598         * WebView/WebView.mm:
599         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
600         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
601         a call in this method to setUseDarkAppearance.
602         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
603         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
604         (-[WebView _updateDefaultAppearance]): Deleted.
605         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
606
607 2018-07-05  Timothy Hatcher  <timothy@apple.com>
608
609         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
610         https://bugs.webkit.org/show_bug.cgi?id=187369
611         rdar://problem/41870420
612
613         Reviewed by Tim Horton.
614
615         * WebView/WebMediaPlaybackTargetPicker.mm:
616         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
617         * WebView/WebView.mm:
618         (-[WebView _commonInitializationWithFrameName:groupName:]):
619         (-[WebView _effectiveAppearanceIsDark]):
620         (-[WebView _updateDefaultAppearance]):
621         (-[WebView _defaultAppearance]): Deleted.
622
623 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
624
625         Youtube video pages crash after a couple of minutes
626         https://bugs.webkit.org/show_bug.cgi?id=187316
627
628         Reviewed by Antti Koivisto.
629
630         * WebView/WebView.mm:
631         (-[WebView _preferencesChanged:]):
632
633 2018-07-04  Tim Horton  <timothy_horton@apple.com>
634
635         Introduce PLATFORM(IOSMAC)
636         https://bugs.webkit.org/show_bug.cgi?id=187315
637
638         Reviewed by Dan Bernstein.
639
640         * Configurations/Base.xcconfig:
641         * Configurations/FeatureDefines.xcconfig:
642
643 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
644
645         [iOS] DataTransfer.getData always returns the empty string when dropping text
646         https://bugs.webkit.org/show_bug.cgi?id=187130
647         <rdar://problem/41014117>
648
649         Reviewed by Ryosuke Niwa.
650
651         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
652
653         * WebCoreSupport/WebPlatformStrategies.h:
654         * WebCoreSupport/WebPlatformStrategies.mm:
655         (WebPlatformStrategies::allPasteboardItemInfo):
656
657 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
658
659         [Mac] AirPlay picker uses incorrect theme in Dark mode
660         https://bugs.webkit.org/show_bug.cgi?id=187054
661         <rdar://problem/41291093>
662
663         Reviewed by Timothy Hatcher.
664
665         * WebView/WebMediaPlaybackTargetPicker.mm:
666         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
667
668 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
669
670         [WTF] Add user-defined literal for ASCIILiteral
671         https://bugs.webkit.org/show_bug.cgi?id=186839
672
673         Reviewed by Darin Adler.
674
675         * DOM/ExceptionHandlers.mm:
676         (raiseDOMErrorException):
677         * Plugins/Hosted/ProxyInstance.mm:
678         (WebKit::ProxyInstance::invokeMethod):
679         * Storage/WebDatabaseProvider.mm:
680         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
681
682 2018-06-22  Timothy Hatcher  <timothy@apple.com>
683
684         Recalc styles every time defaultAppearance changes.
685         https://bugs.webkit.org/show_bug.cgi?id=186866
686         rdar://problem/41309805
687
688         Reviewed by Tim Horton.
689
690         * WebView/WebView.mm:
691         (-[WebView _updateDefaultAppearance]):
692         (-[WebView _setUseSystemAppearance:]):
693         (-[WebView _useSystemAppearance]):
694
695 2018-06-20  Darin Adler  <darin@apple.com>
696
697         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
698         https://bugs.webkit.org/show_bug.cgi?id=186875
699
700         Reviewed by Anders Carlsson.
701
702         * WebView/WebHTMLView.mm:
703         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
704         to write te file to.
705         * WebView/WebPreferences.mm:
706         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
707         * WebView/WebView.mm:
708         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
709
710 2018-06-12  Darin Adler  <darin@apple.com>
711
712         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
713         https://bugs.webkit.org/show_bug.cgi?id=186526
714
715         Reviewed by Anders Carlsson.
716
717         * Plugins/Hosted/NetscapePluginHostManager.mm:
718         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
719
720         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
721         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
722         assignment rather than adoptNS/leakRef.
723         * Plugins/WebNetscapePluginView.mm:
724         (-[WebNetscapePluginView createPlugin]): Ditto.
725
726         * WebCoreSupport/WebContextMenuClient.mm:
727         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
728         RetainPtr::autorelease; no need to autorelease just to pass something as a function
729         argument, so use RetainPtr::get instead.
730
731         * WebView/WebHTMLView.mm:
732         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
733         No need to autorelease the result when the return type is RetainPtr.
734
735         * WebView/WebPDFRepresentation.mm:
736         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
737
738 2018-06-13  Youenn Fablet  <youenn@apple.com>
739
740         Supported plugin check should be based on plugin identifier
741         https://bugs.webkit.org/show_bug.cgi?id=186578
742         <rdar://problem/40523828>
743
744         Reviewed by Darin Adler.
745
746         * WebCoreSupport/WebPluginInfoProvider.h:
747         * WebCoreSupport/WebPluginInfoProvider.mm:
748         (WebPluginInfoProvider::pluginInfo):
749         (WebPluginInfoProvider::webVisiblePluginInfo):
750
751 2018-06-13  Chris Dumez  <cdumez@apple.com>
752
753         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
754         https://bugs.webkit.org/show_bug.cgi?id=186545
755
756         Reviewed by Brady Eidson.
757
758         Update client delegate now that parameter type has changed.
759
760         * WebCoreSupport/WebFrameLoaderClient.h:
761         * WebCoreSupport/WebFrameLoaderClient.mm:
762         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
763
764 2018-06-11  Tim Horton  <timothy_horton@apple.com>
765
766         Link drag image is inconsistently unreadable in dark mode
767         https://bugs.webkit.org/show_bug.cgi?id=186472
768
769         Reviewed by Timothy Hatcher.
770
771         * WebView/WebView.mm:
772         (-[WebView _defaultAppearance]):
773         Make defaultAppearance accurate even if useSystemAppearance is false.
774         Some parts of WebKit (like the link drag image, but also context menus)
775         want to be able to follow the system appearance regardless of whether
776         the view or content has opted in.
777
778 2018-06-11  Chris Dumez  <cdumez@apple.com>
779
780         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
781         https://bugs.webkit.org/show_bug.cgi?id=186441
782
783         Reviewed by Brady Eidson.
784
785         Rename existing flag to something a bit more generic, now that it is used for
786         more things than bypassing the navigation policy check.
787
788         * WebView/WebView.mm:
789         (-[WebView _loadBackForwardListFromOtherView:]):
790         (-[WebView goToBackForwardItem:]):
791
792 2018-06-09  Dan Bernstein  <mitz@apple.com>
793
794         [Xcode] Clean up and modernize some build setting definitions
795         https://bugs.webkit.org/show_bug.cgi?id=186463
796
797         Reviewed by Sam Weinig.
798
799         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
800         * Configurations/DebugRelease.xcconfig: Ditto.
801         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
802           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
803         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
804         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
805           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
806         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
807
808 2018-06-08  Darin Adler  <darin@apple.com>
809
810         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
811         https://bugs.webkit.org/show_bug.cgi?id=186436
812
813         Reviewed by Anders Carlsson.
814
815         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
816         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
817         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
818         (PoolCleaner): Ditto.
819
820         * History/WebHistory.mm:
821         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
822         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
823         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
824         now hardly used if at all.
825         * WebView/WebView.mm:
826         (-[WebView rectsForTextMatches]): Ditto.
827
828 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
829
830         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
831         https://bugs.webkit.org/show_bug.cgi?id=186442
832         <rdar://problem/40879364>
833
834         Reviewed by Tim Horton.
835
836         * Configurations/FeatureDefines.xcconfig:
837
838 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
839
840         [Datalist] Allow TextFieldInputType to show and hide suggestions
841         https://bugs.webkit.org/show_bug.cgi?id=186151
842
843         Reviewed by Tim Horton.
844
845         * WebCoreSupport/WebChromeClient.h:
846         * WebCoreSupport/WebChromeClient.mm:
847         (WebChromeClient::createDataListSuggestionPicker):
848
849 2018-06-07  Chris Dumez  <cdumez@apple.com>
850
851         Add base class to get WeakPtrFactory member and avoid some boilerplate code
852         https://bugs.webkit.org/show_bug.cgi?id=186407
853
854         Reviewed by Brent Fulgham.
855
856         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
857         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
858         This also gets rid of old-style createWeakPtr() methods in favor of the newer
859         makeWeakPtr().
860
861         * WebCoreSupport/WebEditorClient.h:
862         * WebCoreSupport/WebEditorClient.mm:
863         (WebEditorClient::requestCandidatesForSelection):
864
865 2018-06-05  Chris Dumez  <cdumez@apple.com>
866
867         Regression(r232082): Websites get loaded inside of Messages App chat transcript
868         https://bugs.webkit.org/show_bug.cgi?id=186331
869         <rdar://problem/40735446>
870
871         Reviewed by Darin Adler.
872
873         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
874         but does not call use / ignore on the listener, then we would do "use" by default.
875         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
876         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
877         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
878         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
879         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
880         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
881         and Box.app is still working properly.
882
883         * WebCoreSupport/WebFrameLoaderClient.h:
884         * WebCoreSupport/WebFrameLoaderClient.mm:
885         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
886         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
887         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
888         (WebFrameLoaderClient::dispatchWillSubmitForm):
889         (WebFrameLoaderClient::setUpPolicyListener):
890         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
891         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
892         (-[WebFramePolicyListener dealloc]):
893         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
894         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
895
896 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
897
898         Adjust compile and runtime flags to match shippable state of features
899         https://bugs.webkit.org/show_bug.cgi?id=186319
900         <rdar://problem/40352045>
901
902         Reviewed by Maciej Stachowiak, Jon Lee, and others.
903
904         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
905         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
906         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
907         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
908         Cocoa builds.
909
910 2018-06-05  Timothy Hatcher  <timothy@apple.com>
911
912         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
913
914         https://bugs.webkit.org/show_bug.cgi?id=186323
915         rdar://problem/38382252
916
917         Reviewed by Tim Horton.
918
919         * WebView/WebView.mm:
920         (-[WebView _defaultAppearance]):
921
922 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
923
924         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
925         https://bugs.webkit.org/show_bug.cgi?id=186286
926         <rdar://problem/40782992>
927
928         Reviewed by Dan Bernstein.
929
930         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
931         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
932         change this flag when preparing for a production release.
933
934         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
935         whether experimental features should be enabled, and use it to properly define the
936         feature flag.
937
938 2018-06-03  Darin Adler  <darin@apple.com>
939
940         Simplify and remove some unused video element code (helpful for ARC-compatibility)
941         https://bugs.webkit.org/show_bug.cgi?id=186258
942
943         Reviewed by Daniel Bates.
944
945         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
946         forward declarations. Removed methods that don't need to be public.
947
948         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
949         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
950         unnamed category in here and also replaced the HUDWindowControllerDelegate
951         with the unnamed category. Removed unused NSWindow category defining the
952         isOnActiveSpace, which is not called anywhere in this file at this time.
953         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
954         into setVideoElement.
955         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
956         and removed unneeded typecast.
957         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
958         using statement at the top of the file.
959         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
960         the many side effects and special considerations that this method that sounds
961         like a setter has. Updated code to use the new
962         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
963         HTMLVideoElement::platformMedia function. Also straightened out the logic a
964         bit and added some FIXME comments about small problems noticed but not fixed.
965         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
966         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
967         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
968         typecast. Removed call to updatePowerAssertions method.
969         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
970         updatePowerAssertions method.
971         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
972         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
973         else, so this was dead code that did nothing.
974         (-[WebVideoFullscreenController rateChanged:]): Removed call to
975         updatePowerAssertions method.
976
977 2018-06-04  Chris Dumez  <cdumez@apple.com>
978
979         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
980         https://bugs.webkit.org/show_bug.cgi?id=186287
981         <rdar://problem/40783352>
982
983         Reviewed by Youenn Fablet.
984
985         * WebView/WebPreferenceKeysPrivate.h:
986         * WebView/WebPreferences.mm:
987         (+[WebPreferences initialize]):
988         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
989         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
990         * WebView/WebPreferencesPrivate.h:
991         * WebView/WebView.mm:
992         (-[WebView _preferencesChanged:]):
993
994 2018-06-02  Darin Adler  <darin@apple.com>
995
996         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
997         https://bugs.webkit.org/show_bug.cgi?id=186227
998
999         Reviewed by Dan Bernstein.
1000
1001         * Misc/WebKitErrors.m:
1002         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
1003         * Plugins/WebPluginDatabase.mm:
1004         (-[WebPluginDatabase refresh]): Ditto.
1005         * WebCoreSupport/WebChromeClient.mm:
1006         (WebChromeClient::setStatusbarText): Ditto.
1007
1008 2018-06-01  Chris Dumez  <cdumez@apple.com>
1009
1010         REGRESSION (r231456): Colloquy is broken
1011         https://bugs.webkit.org/show_bug.cgi?id=186197
1012         <rdar://problem/40722960>
1013
1014         Reviewed by Timothy Hatcher.
1015
1016         Restore pre-r231456 behavior for Colloquy app so that it works again.
1017
1018         * WebView/WebView.mm:
1019         (-[WebView _needsFrameNameFallbackToIdQuirk]):
1020         (-[WebView _preferencesChanged:]):
1021
1022 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1023
1024         [JSC] Pass VM& parameter as much as possible
1025         https://bugs.webkit.org/show_bug.cgi?id=186085
1026
1027         Reviewed by Saam Barati.
1028
1029         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1030         (WebKit::NetscapePluginInstanceProxy::invoke):
1031
1032 2018-05-30  Daniel Bates  <dabates@apple.com>
1033
1034         NavigationAction does not need to hold initiating DOM Event
1035         https://bugs.webkit.org/show_bug.cgi?id=185958
1036         <rdar://problem/40531539>
1037
1038         Reviewed by Simon Fraser.
1039
1040         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
1041
1042         * WebCoreSupport/WebFrameLoaderClient.mm:
1043         (WebFrameLoaderClient::actionDictionary const):
1044         (findMouseEvent): Deleted.
1045
1046 2018-05-27  Dan Bernstein  <mitz@apple.com>
1047
1048         Reverted the changes made for https://webkit.org/b/186016
1049
1050         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1051
1052
1053 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1054
1055         [iOS] Fix warnings about leaks found by clang static analyzer
1056         <https://webkit.org/b/186009>
1057         <rdar://problem/40574267>
1058
1059         Reviewed by Daniel Bates.
1060
1061         * WebView/WebHTMLView.mm:
1062         (-[WebHTMLView doCommandBySelector:]): Fix use of an
1063         uninitialized boolean variable (`eventWasHandled`) that only
1064         happened on iOS.
1065
1066 2018-05-27  Dan Bernstein  <mitz@apple.com>
1067
1068         [Cocoa] Avoid importing directly from subumbrella frameworks
1069         https://bugs.webkit.org/show_bug.cgi?id=186016
1070
1071         Reviewed by Sam Weinig.
1072
1073         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1074         * Carbon/CarbonWindowAdapter.mm: Ditto.
1075         * Carbon/CarbonWindowFrame.m: Ditto.
1076         * Carbon/HIViewAdapter.h: Ditto.
1077         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
1078           OTHER_CPLUSPLUSFLAGS.
1079         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1080         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1081         * WebView/WebPDFView.h: Ditto.
1082
1083 2018-05-27  Sam Weinig  <sam@webkit.org>
1084
1085         Modernize RenderStyleConstants.h - Part 3
1086         https://bugs.webkit.org/show_bug.cgi?id=186015
1087
1088         Reviewed by Yusuke Suzuki.
1089
1090         * WebView/WebView.mm:
1091         (-[WebView updateTextTouchBar]):
1092         Update for new enum name.
1093
1094 2018-05-25  Chris Dumez  <cdumez@apple.com>
1095
1096         Minor ApplicationCacheStorage clean up
1097         https://bugs.webkit.org/show_bug.cgi?id=185984
1098
1099         Reviewed by Youenn Fablet.
1100
1101         * WebCoreSupport/WebApplicationCache.mm:
1102         (+[WebApplicationCache originsWithCache]):
1103
1104 2018-05-25  David Kilzer  <ddkilzer@apple.com>
1105
1106         Fix issues with -dealloc methods found by clang static analyzer
1107         <https://webkit.org/b/185887>
1108
1109         Reviewed by Joseph Pecoraro.
1110
1111         * WebView/WebView.mm:
1112         (-[WebUITextIndicatorData dealloc]):
1113         - Move method implementation from (WebUITextIndicatorInternal)
1114           category to the main category since this is public API.  This
1115           fixes the false positive warning about a missing -dealloc
1116           method.
1117
1118 2018-05-24  Sam Weinig  <sam@webkit.org>
1119
1120         Modernize RenderStyleConstants.h - Part 2
1121         https://bugs.webkit.org/show_bug.cgi?id=185901
1122
1123         Reviewed by Simon Fraser.
1124
1125         * WebView/WebHTMLRepresentation.mm:
1126         (searchForLabelsBeforeElement):
1127         * WebView/WebView.mm:
1128         (nsTextAlignmentFromRenderStyle):
1129         Update for new enum names.
1130
1131 2018-05-22  Chris Dumez  <cdumez@apple.com>
1132
1133         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1134         https://bugs.webkit.org/show_bug.cgi?id=185832
1135         <rdar://problem/40307871>
1136
1137         Reviewed by Geoffrey Garen.
1138
1139         We used to have a bug where where we would fail to wait for the policy decision for
1140         the navigation response from the client and the load would keep going, racing with
1141         the client's policy decision. If the client did not respond in time, the behavior
1142         would be the same as "Use" policy action.
1143
1144         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
1145         but the load happened to proceed anyway due to our bug. Now that we've fixed the
1146         WebKit bug, however, the load would hang because the completion handler for the
1147         decidePolicyForNavigationResponse would never get called.
1148
1149         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
1150         instead of retaining it. If the policy listener object gets destroyed because getting
1151         resolved, we now use "Use" policy action in its dealloc function to maintain previous
1152         behavior.
1153
1154         * WebCoreSupport/WebFrameLoaderClient.h:
1155         * WebCoreSupport/WebFrameLoaderClient.mm:
1156         (WebFrameLoaderClient::cancelPolicyCheck):
1157         (WebFrameLoaderClient::setUpPolicyListener):
1158         (-[WebFramePolicyListener dealloc]):
1159
1160 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1161
1162         Unreviewed, rolling out r232052.
1163
1164         Breaks internal builds.
1165
1166         Reverted changeset:
1167
1168         "Use more C++17"
1169         https://bugs.webkit.org/show_bug.cgi?id=185176
1170         https://trac.webkit.org/changeset/232052
1171
1172 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1173
1174         Use more C++17
1175         https://bugs.webkit.org/show_bug.cgi?id=185176
1176
1177         Reviewed by JF Bastien.
1178
1179         * Configurations/Base.xcconfig:
1180         * Configurations/WebKitLegacy.xcconfig:
1181
1182 2018-05-21  Chris Nardi  <cnardi@chromium.org>
1183
1184         Remove dead exception in MediaList.appendMedium
1185         https://bugs.webkit.org/show_bug.cgi?id=185278
1186
1187         Reviewed by Chris Dumez.
1188
1189         Remove code pertaining to an exception being thrown by appendMedium().
1190
1191         * DOM/DOMMediaList.mm:
1192         (-[DOMMediaList appendMedium:]):
1193
1194 2018-05-21  Jer Noble  <jer.noble@apple.com>
1195
1196         Complete fix for enabling modern EME by default
1197         https://bugs.webkit.org/show_bug.cgi?id=185770
1198         <rdar://problem/40368220>
1199
1200         Reviewed by Eric Carlson.
1201
1202         * Configurations/FeatureDefines.xcconfig:
1203
1204 2018-05-21  Antti Koivisto  <antti@apple.com>
1205
1206         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
1207         https://bugs.webkit.org/show_bug.cgi?id=185815
1208         <rdar://problem/40310069>
1209
1210         Reviewed by Simon Fraser.
1211
1212         User stylesheet parsing may depend on the colorFilterEnabled preference.
1213
1214         * WebView/WebView.mm:
1215         (-[WebView _preferencesChanged:]):
1216
1217 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1218
1219         Unreviewed, rolling out r231982.
1220         https://bugs.webkit.org/show_bug.cgi?id=185793
1221
1222         Caused layout test failures (Requested by realdawei on
1223         #webkit).
1224
1225         Reverted changeset:
1226
1227         "Complete fix for enabling modern EME by default"
1228         https://bugs.webkit.org/show_bug.cgi?id=185770
1229         https://trac.webkit.org/changeset/231982
1230
1231 2018-05-18  Jer Noble  <jer.noble@apple.com>
1232
1233         Complete fix for enabling modern EME by default
1234         https://bugs.webkit.org/show_bug.cgi?id=185770
1235         <rdar://problem/40368220>
1236
1237         Reviewed by Eric Carlson.
1238
1239         * Configurations/FeatureDefines.xcconfig:
1240
1241 2018-05-18  Chris Dumez  <cdumez@apple.com>
1242
1243         Avoid keeping the frame alive when ref'ing a WindowProxy
1244         https://bugs.webkit.org/show_bug.cgi?id=185737
1245         <rdar://problem/40004666>
1246
1247         Reviewed by Sam Weinig.
1248
1249         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1250         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1251
1252 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1253
1254         Add support for Intl NumberFormat formatToParts
1255         https://bugs.webkit.org/show_bug.cgi?id=185375
1256
1257         Reviewed by Yusuke Suzuki.
1258
1259         Add flag for NumberFormat formatToParts.
1260
1261         * Configurations/FeatureDefines.xcconfig:
1262
1263 2018-05-16  Chris Nardi  <cnardi@chromium.org>
1264
1265         Fixup after r231849: Do not mark Mac API methods as deprecated
1266         https://bugs.webkit.org/show_bug.cgi?id=185684
1267
1268         Reviewed by Darin Adler.
1269
1270         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
1271         as the entire class is already marked as deprecated, so it is unnecessary.
1272
1273         * DOM/DOMDocument.h:
1274
1275 2018-05-16  Chris Nardi  <cnardi@chromium.org>
1276
1277         Remove Document#selectedStylesheetSet/preferredStylesheetSet
1278         https://bugs.webkit.org/show_bug.cgi?id=185381
1279
1280         Reviewed by Darin Adler.
1281
1282         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
1283         and make them do nothing.
1284
1285         * DOM/DOMDocument.h:
1286         * DOM/DOMDocument.mm:
1287         (-[DOMDocument preferredStylesheetSet]):
1288         (-[DOMDocument selectedStylesheetSet]):
1289         (-[DOMDocument setSelectedStylesheetSet:]):
1290
1291 2018-05-15  Antoine Quint  <graouts@apple.com>
1292
1293         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1294         https://bugs.webkit.org/show_bug.cgi?id=185647
1295
1296         Reviewed by Dean Jackson.
1297
1298         Rename the Web Animations CSS integration flag.
1299
1300         * WebView/WebPreferenceKeysPrivate.h:
1301         * WebView/WebPreferences.mm:
1302         (+[WebPreferences initialize]):
1303         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
1304         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
1305         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
1306         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
1307         * WebView/WebPreferencesPrivate.h:
1308         * WebView/WebView.mm:
1309         (-[WebView _preferencesChanged:]):
1310
1311 2018-05-14  Daniel Bates  <dabates@apple.com>
1312
1313         Fix the Apple Internal build
1314
1315         See <rdar://problem/40237873> for more details.
1316
1317         * WebView/WebFullScreenController.mm:
1318         (-[WebFullScreenController enterFullScreen:]):
1319         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1320         (-[WebFullScreenController exitFullScreen]):
1321         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1322         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1323         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1324
1325 2018-05-11  Timothy Hatcher  <timothy@apple.com>
1326
1327         WebHTMLView is not setting aside subviews when drawing.
1328
1329         https://bugs.webkit.org/show_bug.cgi?id=185561
1330         rdar://problem/40172894
1331
1332         Reviewed by Simon Fraser.
1333
1334         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
1335
1336         * WebView/WebHTMLView.mm:
1337         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
1338
1339 2018-05-07  Daniel Bates  <dabates@apple.com>
1340
1341         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1342         https://bugs.webkit.org/show_bug.cgi?id=185170
1343
1344         Reviewed by Per Arne Vollan.
1345
1346         * Misc/WebCache.mm:
1347         (+[WebCache empty]):
1348
1349 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1350
1351         Deprecate legacy WebView and friends
1352         https://bugs.webkit.org/show_bug.cgi?id=185279
1353         rdar://problem/33268700
1354
1355         Reviewed by Tim Horton.
1356
1357         Added deprecation macros to all the classes, extern strings, and enums.
1358
1359         * Configurations/WebKitLegacy.xcconfig:
1360         Added BUILDING_WEBKIT define to disable the deprecation macros.
1361         * DOM/DOMAbstractView.h:
1362         * DOM/DOMAttr.h:
1363         * DOM/DOMBlob.h:
1364         * DOM/DOMCDATASection.h:
1365         * DOM/DOMCSSCharsetRule.h:
1366         * DOM/DOMCSSFontFaceRule.h:
1367         * DOM/DOMCSSImportRule.h:
1368         * DOM/DOMCSSMediaRule.h:
1369         * DOM/DOMCSSPageRule.h:
1370         * DOM/DOMCSSPrimitiveValue.h:
1371         * DOM/DOMCSSRule.h:
1372         * DOM/DOMCSSRuleList.h:
1373         * DOM/DOMCSSStyleDeclaration.h:
1374         * DOM/DOMCSSStyleRule.h:
1375         * DOM/DOMCSSStyleSheet.h:
1376         * DOM/DOMCSSUnknownRule.h:
1377         * DOM/DOMCSSValue.h:
1378         * DOM/DOMCSSValueList.h:
1379         * DOM/DOMCharacterData.h:
1380         * DOM/DOMComment.h:
1381         * DOM/DOMCounter.h:
1382         * DOM/DOMDocument.h:
1383         * DOM/DOMDocumentFragment.h:
1384         * DOM/DOMDocumentType.h:
1385         * DOM/DOMElement.h:
1386         * DOM/DOMEntity.h:
1387         * DOM/DOMEntityReference.h:
1388         * DOM/DOMEvent.h:
1389         * DOM/DOMEventException.h:
1390         * DOM/DOMEventListener.h:
1391         * DOM/DOMEventTarget.h:
1392         * DOM/DOMException.h:
1393         * DOM/DOMFile.h:
1394         * DOM/DOMFileList.h:
1395         * DOM/DOMHTMLAnchorElement.h:
1396         * DOM/DOMHTMLAppletElement.h:
1397         * DOM/DOMHTMLAreaElement.h:
1398         * DOM/DOMHTMLBRElement.h:
1399         * DOM/DOMHTMLBaseElement.h:
1400         * DOM/DOMHTMLBaseFontElement.h:
1401         * DOM/DOMHTMLBodyElement.h:
1402         * DOM/DOMHTMLButtonElement.h:
1403         * DOM/DOMHTMLCanvasElement.h:
1404         * DOM/DOMHTMLCollection.h:
1405         * DOM/DOMHTMLDListElement.h:
1406         * DOM/DOMHTMLDirectoryElement.h:
1407         * DOM/DOMHTMLDivElement.h:
1408         * DOM/DOMHTMLDocument.h:
1409         * DOM/DOMHTMLElement.h:
1410         * DOM/DOMHTMLEmbedElement.h:
1411         * DOM/DOMHTMLFieldSetElement.h:
1412         * DOM/DOMHTMLFontElement.h:
1413         * DOM/DOMHTMLFormElement.h:
1414         * DOM/DOMHTMLFrameElement.h:
1415         * DOM/DOMHTMLFrameSetElement.h:
1416         * DOM/DOMHTMLHRElement.h:
1417         * DOM/DOMHTMLHeadElement.h:
1418         * DOM/DOMHTMLHeadingElement.h:
1419         * DOM/DOMHTMLHtmlElement.h:
1420         * DOM/DOMHTMLIFrameElement.h:
1421         * DOM/DOMHTMLImageElement.h:
1422         * DOM/DOMHTMLInputElement.h:
1423         * DOM/DOMHTMLLIElement.h:
1424         * DOM/DOMHTMLLabelElement.h:
1425         * DOM/DOMHTMLLegendElement.h:
1426         * DOM/DOMHTMLLinkElement.h:
1427         * DOM/DOMHTMLMapElement.h:
1428         * DOM/DOMHTMLMarqueeElement.h:
1429         * DOM/DOMHTMLMediaElement.h:
1430         * DOM/DOMHTMLMenuElement.h:
1431         * DOM/DOMHTMLMetaElement.h:
1432         * DOM/DOMHTMLModElement.h:
1433         * DOM/DOMHTMLOListElement.h:
1434         * DOM/DOMHTMLObjectElement.h:
1435         * DOM/DOMHTMLOptGroupElement.h:
1436         * DOM/DOMHTMLOptionElement.h:
1437         * DOM/DOMHTMLOptionsCollection.h:
1438         * DOM/DOMHTMLParagraphElement.h:
1439         * DOM/DOMHTMLParamElement.h:
1440         * DOM/DOMHTMLPreElement.h:
1441         * DOM/DOMHTMLQuoteElement.h:
1442         * DOM/DOMHTMLScriptElement.h:
1443         * DOM/DOMHTMLSelectElement.h:
1444         * DOM/DOMHTMLStyleElement.h:
1445         * DOM/DOMHTMLTableCaptionElement.h:
1446         * DOM/DOMHTMLTableCellElement.h:
1447         * DOM/DOMHTMLTableColElement.h:
1448         * DOM/DOMHTMLTableElement.h:
1449         * DOM/DOMHTMLTableRowElement.h:
1450         * DOM/DOMHTMLTableSectionElement.h:
1451         * DOM/DOMHTMLTextAreaElement.h:
1452         * DOM/DOMHTMLTitleElement.h:
1453         * DOM/DOMHTMLUListElement.h:
1454         * DOM/DOMHTMLVideoElement.h:
1455         * DOM/DOMImplementation.h:
1456         * DOM/DOMKeyboardEvent.h:
1457         * DOM/DOMMediaError.h:
1458         * DOM/DOMMediaList.h:
1459         * DOM/DOMMouseEvent.h:
1460         * DOM/DOMMutationEvent.h:
1461         * DOM/DOMNamedNodeMap.h:
1462         * DOM/DOMNode.h:
1463         * DOM/DOMNodeFilter.h:
1464         * DOM/DOMNodeIterator.h:
1465         * DOM/DOMNodeList.h:
1466         * DOM/DOMObject.h:
1467         * DOM/DOMOverflowEvent.h:
1468         * DOM/DOMProcessingInstruction.h:
1469         * DOM/DOMProgressEvent.h:
1470         * DOM/DOMRGBColor.h:
1471         * DOM/DOMRange.h:
1472         * DOM/DOMRangeException.h:
1473         * DOM/DOMRect.h:
1474         * DOM/DOMStyleSheet.h:
1475         * DOM/DOMStyleSheetList.h:
1476         * DOM/DOMText.h:
1477         * DOM/DOMTextEvent.h:
1478         * DOM/DOMTimeRanges.h:
1479         * DOM/DOMTokenList.h:
1480         * DOM/DOMTreeWalker.h:
1481         * DOM/DOMUIEvent.h:
1482         * DOM/DOMWheelEvent.h:
1483         * DOM/DOMXPathException.h:
1484         * DOM/DOMXPathExpression.h:
1485         * DOM/DOMXPathNSResolver.h:
1486         * DOM/DOMXPathResult.h:
1487         * History/WebBackForwardList.h:
1488         * History/WebHistory.h:
1489         * History/WebHistoryItem.h:
1490         * Misc/WebDownload.h:
1491         * Misc/WebKitErrors.h:
1492         * Plugins/WebPluginViewFactory.h:
1493         * WebView/WebArchive.h:
1494         * WebView/WebDataSource.h:
1495         * WebView/WebDocument.h:
1496         * WebView/WebEditingDelegate.h:
1497         * WebView/WebFormDelegate.h:
1498         * WebView/WebFrame.h:
1499         * WebView/WebFrameLoadDelegate.h:
1500         * WebView/WebFrameView.h:
1501         * WebView/WebPolicyDelegate.h:
1502         * WebView/WebPreferences.h:
1503         * WebView/WebPreferencesPrivate.h:
1504         * WebView/WebResourceLoadDelegate.h:
1505         * WebView/WebUIDelegate.h:
1506         * WebView/WebUIDelegatePrivate.h:
1507         * WebView/WebView.h:
1508         * WebView/WebViewPrivate.h:
1509         * postprocess-headers.sh:
1510         Remove step that converts WEBKIT macros to NS macros.
1511         Change it to just remove the macros on iOS builds.
1512
1513 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1514
1515         [MediaStream] remove WK1 support
1516         https://bugs.webkit.org/show_bug.cgi?id=185136
1517
1518         Reviewed by Youenn Fablet.
1519
1520         * WebCoreSupport/WebUserMediaClient.h: Removed.
1521         * WebCoreSupport/WebUserMediaClient.mm: Removed.
1522         * WebView/WebView.mm:
1523         (-[WebView _commonInitializationWithFrameName:groupName:]):
1524         (-[WebView _preferencesChanged:]):
1525         (-[WebView _setUserMediaClient:]): Deleted.
1526         (-[WebView _userMediaClient]): Deleted.
1527         * WebView/WebViewData.h:
1528         * WebView/WebViewPrivate.h:
1529
1530 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1531
1532         WebAssembly: add support for stream APIs - JavaScript API
1533         https://bugs.webkit.org/show_bug.cgi?id=183442
1534
1535         Reviewed by Yusuke Suzuki and JF Bastien.
1536
1537         Add WEBASSEMBLY_STREAMINNG_API feature flag
1538
1539         * Configurations/FeatureDefines.xcconfig:
1540
1541 2018-04-30  JF Bastien  <jfbastien@apple.com>
1542
1543         Use some C++17 features
1544         https://bugs.webkit.org/show_bug.cgi?id=185135
1545
1546         Reviewed by Alex Christensen.
1547
1548         * Configurations/WebKitLegacy.xcconfig:
1549
1550 2018-04-27  Chris Dumez  <cdumez@apple.com>
1551
1552         Use WindowProxy instead of DOMWindow in our IDL
1553         https://bugs.webkit.org/show_bug.cgi?id=185022
1554
1555         Reviewed by Sam Weinig.
1556
1557         * DOM/DOMAbstractView.mm:
1558         (kit):
1559         (toWindowProxy):
1560         * DOM/DOMAbstractViewInternal.h:
1561         * DOM/DOMDocument.mm:
1562         (-[DOMDocument defaultView]):
1563         (-[DOMDocument getComputedStyle:pseudoElement:]):
1564         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
1565         * DOM/DOMHTMLFrameElement.mm:
1566         (-[DOMHTMLFrameElement contentWindow]):
1567         * DOM/DOMHTMLIFrameElement.mm:
1568         (-[DOMHTMLIFrameElement contentWindow]):
1569         * DOM/DOMKeyboardEvent.mm:
1570         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
1571         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
1572         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
1573         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
1574         * DOM/DOMMouseEvent.mm:
1575         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
1576         * DOM/DOMTextEvent.mm:
1577         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
1578         * DOM/DOMUIEvent.mm:
1579         (-[DOMUIEvent view]):
1580         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
1581         * DOM/DOMWheelEvent.mm:
1582         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1583
1584 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
1585
1586         Implement rendering support for the color-filter CSS property
1587         https://bugs.webkit.org/show_bug.cgi?id=185047
1588         rdar://problem/39664967
1589
1590         Reviewed by Tim Horton.
1591         
1592         The body background should reflect the filtered color.
1593
1594         * WebView/WebFrame.mm:
1595         (-[WebFrame _bodyBackgroundColor]):
1596         * WebView/WebView.mm:
1597         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
1598
1599 2018-04-26  Jer Noble  <jer.noble@apple.com>
1600
1601         WK_COCOA_TOUCH all the things.
1602         https://bugs.webkit.org/show_bug.cgi?id=185006
1603
1604         Reviewed by Tim Horton.
1605
1606         * Configurations/WebKitLegacy.xcconfig:
1607
1608 2018-04-26  Daniel Bates  <dabates@apple.com>
1609
1610         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
1611         https://bugs.webkit.org/show_bug.cgi?id=184161
1612         <rdar://problem/39051645>
1613
1614         Reviewed by Dan Bernstein.
1615
1616         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
1617         dropping a PDF embedded using an HTML image element into the same web view.
1618
1619         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
1620         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
1621         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
1622         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
1623         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
1624         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
1625         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
1626         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
1627         image document when navigated to directly. Since we can support dragging PDF document images we need to
1628         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
1629         We need to do both such queries before falling back to using the main resource of the Web Archive as
1630         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
1631         not an image document.
1632
1633         * Misc/WebNSPasteboardExtras.mm:
1634         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1635
1636 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1637
1638         Disable content filtering in minimal simulator mode
1639         https://bugs.webkit.org/show_bug.cgi?id=185027
1640         <rdar://problem/39736091>
1641
1642         Reviewed by Jer Noble.
1643
1644         * Configurations/FeatureDefines.xcconfig:
1645
1646 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1647
1648         [INTL] Implement Intl.PluralRules
1649         https://bugs.webkit.org/show_bug.cgi?id=184312
1650
1651         Reviewed by JF Bastien.
1652
1653         Added Intl.PluralRules feature flag.
1654
1655         * Configurations/FeatureDefines.xcconfig:
1656
1657 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1658
1659         Remove access to keychain from the WebContent process
1660         https://bugs.webkit.org/show_bug.cgi?id=184428
1661         <rdar://problem/13150903>
1662
1663         Reviewed by Brent Fulgham.
1664
1665         This patch does the followings:
1666         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
1667         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
1668         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
1669
1670         * WebCoreSupport/WebChromeClient.h:
1671         * WebCoreSupport/WebChromeClient.mm:
1672         (WebChromeClient::signedPublicKeyAndChallengeString const):
1673         * WebView/WebUIDelegatePrivate.h:
1674
1675 2018-04-24  Jer Noble  <jer.noble@apple.com>
1676
1677         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
1678         https://bugs.webkit.org/show_bug.cgi?id=184786
1679
1680         Reviewed by Tim Horton.
1681
1682         * Configurations/WebKitLegacy.xcconfig:
1683         * MigrateHeaders.make:
1684
1685 2018-04-23  Daniel Bates  <dabates@apple.com>
1686
1687         Implement Same-Site cookies
1688         https://bugs.webkit.org/show_bug.cgi?id=159464
1689         <rdar://problem/27196358>
1690
1691         Reviewed by Brent Fulgham.
1692
1693         Pass the Same-Site info through the strategy.
1694
1695         * WebCoreSupport/WebPlatformStrategies.h:
1696         * WebCoreSupport/WebPlatformStrategies.mm:
1697         (WebPlatformStrategies::cookiesForDOM):
1698         (WebPlatformStrategies::setCookiesFromDOM):
1699         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1700         (WebPlatformStrategies::getRawCookies):
1701
1702 2018-04-23  Zalan Bujtas  <zalan@apple.com>
1703
1704         [LayoutFormattingContext] Initial commit.
1705         https://bugs.webkit.org/show_bug.cgi?id=184896
1706
1707         Reviewed by Antti Koivisto.
1708
1709         * Configurations/FeatureDefines.xcconfig:
1710
1711 2018-04-23  Daniel Bates  <dabates@apple.com>
1712
1713         Implement Same-Site cookies
1714         https://bugs.webkit.org/show_bug.cgi?id=159464
1715         <rdar://problem/27196358>
1716
1717         Reviewed by Brent Fulgham.
1718
1719         Pass the Same-Site info through the strategy.
1720
1721         * WebCoreSupport/WebPlatformStrategies.h:
1722         * WebCoreSupport/WebPlatformStrategies.mm:
1723         (WebPlatformStrategies::cookiesForDOM):
1724         (WebPlatformStrategies::setCookiesFromDOM):
1725         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1726         (WebPlatformStrategies::getRawCookies):
1727
1728 2018-04-20  Timothy Hatcher  <timothy@apple.com>
1729
1730         NULL dereference crash sometimes under [super initWithCoder:] in WebView
1731
1732         https://bugs.webkit.org/show_bug.cgi?id=184851
1733         rdar://problem/39611236
1734
1735         Reviewed by Tim Horton.
1736
1737         * WebView/WebView.mm:
1738         (-[WebView _commonInitializationWithFrameName:groupName:]):
1739         (-[WebView effectiveAppearanceDidChange]):
1740         Added a null check and call the code later in initialization.
1741
1742 2018-04-20  Tim Horton  <timothy_horton@apple.com>
1743
1744         Adjust geolocation feature flag
1745         https://bugs.webkit.org/show_bug.cgi?id=184856
1746
1747         Reviewed by Wenson Hsieh.
1748
1749         * Configurations/FeatureDefines.xcconfig:
1750
1751 2018-04-18  Jer Noble  <jer.noble@apple.com>
1752
1753         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
1754         https://bugs.webkit.org/show_bug.cgi?id=184762
1755
1756         Reviewed by Dan Bernstein.
1757
1758         * Configurations/WebKitLegacy.xcconfig:
1759
1760 2018-04-20  Youenn Fablet  <youenn@apple.com>
1761
1762         Make PluginData cache its web visible plugins
1763         https://bugs.webkit.org/show_bug.cgi?id=184421
1764
1765         Reviewed by Chris Dumez.
1766
1767         * WebCoreSupport/WebPluginInfoProvider.h:
1768         * WebCoreSupport/WebPluginInfoProvider.mm:
1769         (WebPluginInfoProvider::pluginInfo):
1770         (WebPluginInfoProvider::webVisiblePluginInfo):
1771
1772 2018-04-19  Chris Dumez  <cdumez@apple.com>
1773
1774         Rename JSDOMWindowProxy to JSWindowProxy
1775         https://bugs.webkit.org/show_bug.cgi?id=184797
1776
1777         Reviewed by Sam Weinig.
1778
1779         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1780
1781         * DOM/DOMUtility.mm:
1782         (createDOMWrapper):
1783         * WebView/WebFrame.mm:
1784         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1785
1786 2018-04-19  David Kilzer  <ddkilzer@apple.com>
1787
1788         Enable Objective-C weak references
1789         <https://webkit.org/b/184789>
1790         <rdar://problem/39571716>
1791
1792         Reviewed by Dan Bernstein.
1793
1794         * Configurations/Base.xcconfig:
1795         (CLANG_ENABLE_OBJC_WEAK): Enable.
1796
1797 2018-04-18  Chris Dumez  <cdumez@apple.com>
1798
1799         Rename WindowProxyController to WindowProxy
1800         https://bugs.webkit.org/show_bug.cgi?id=184756
1801
1802         Reviewed by Sam Weinig.
1803
1804         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
1805         needed use WindowProxyController type, which was a bit confusing.
1806
1807         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1808         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1809         * WebView/WebFrame.mm:
1810         (-[WebFrame _attachScriptDebugger]):
1811
1812 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1813
1814         Unreviewed rollout of r230632. Regression in memory usage.
1815
1816         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1817
1818         * WebView/WebPreferences.mm:
1819         (+[WebPreferences initialize]):
1820
1821 2018-04-17  Chris Dumez  <cdumez@apple.com>
1822
1823         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1824         https://bugs.webkit.org/show_bug.cgi?id=184678
1825         <rdar://problem/39422122>
1826
1827         Reviewed by Alex Christensen.
1828
1829         Add new parameter to dispatchDecidePolicyForNavigationAction.
1830
1831         * WebCoreSupport/WebFrameLoaderClient.h:
1832         * WebCoreSupport/WebFrameLoaderClient.mm:
1833         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1834
1835 2018-04-13  Chris Dumez  <cdumez@apple.com>
1836
1837         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
1838         https://bugs.webkit.org/show_bug.cgi?id=184591
1839
1840         Reviewed by Sam Weinig.
1841
1842         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
1843         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
1844         This is work towards fixing Bug 184515.
1845
1846         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1847         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1848         * WebView/WebFrame.mm:
1849         (-[WebFrame _attachScriptDebugger]):
1850
1851 2018-04-12  Antoine Quint  <graouts@apple.com>
1852
1853         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1854         https://bugs.webkit.org/show_bug.cgi?id=184569
1855         <rdar://problem/38671301>
1856
1857         Reviewed by Jon Lee.
1858
1859         * WebView/WebPreferences.mm:
1860
1861 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1862
1863         [WTF] Remove StaticLock
1864         https://bugs.webkit.org/show_bug.cgi?id=184332
1865
1866         Reviewed by Mark Lam.
1867
1868         * DOM/DOMInternal.mm:
1869         (getDOMWrapper):
1870         (addDOMWrapper):
1871         (removeDOMWrapper):
1872
1873 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
1874
1875         Failures from mach port reference handling should be fatal
1876         https://bugs.webkit.org/show_bug.cgi?id=184202
1877         <rdar://problem/37771114>
1878
1879         Reviewed by Anders Carlsson.
1880
1881         * Plugins/Hosted/NetscapePluginHostManager.mm:
1882         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
1883
1884 2018-04-03  Andy Estes  <aestes@apple.com>
1885
1886         [Mac] Prioritize file promises over filenames during drag and drop
1887         https://bugs.webkit.org/show_bug.cgi?id=184237
1888         <rdar://problem/38278076>
1889
1890         Reviewed by Wenson Hsieh.
1891
1892         * WebView/WebView.mm:
1893         (-[WebView performDragOperation:]):
1894
1895 2018-04-03  Chris Dumez  <cdumez@apple.com>
1896
1897         Drop MainFrame class
1898         https://bugs.webkit.org/show_bug.cgi?id=184191
1899
1900         Reviewed by Darin Adler.
1901
1902         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1903         relationship between the Page and the MainFrame.
1904
1905         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1906
1907         * WebCoreSupport/WebDragClient.mm:
1908         * WebCoreSupport/WebFrameLoaderClient.mm:
1909         * WebCoreSupport/WebInspectorClient.mm:
1910         * WebCoreSupport/WebPlatformStrategies.mm:
1911         * WebCoreSupport/WebPluginInfoProvider.mm:
1912         * WebView/WebFrame.mm:
1913         * WebView/WebFrameView.mm:
1914         * WebView/WebHTMLView.mm:
1915         * WebView/WebView.mm:
1916
1917 2018-04-02  Jer Noble  <jer.noble@apple.com>
1918
1919         Enable Legacy EME for all WebKit & WebKitLegacy clients
1920         https://bugs.webkit.org/show_bug.cgi?id=184018
1921         <rdar://problem/34887387>
1922
1923         Reviewed by Eric Carlson.
1924
1925         * WebView/WebPreferences.mm:
1926         (+[WebPreferences initialize]):
1927
1928 2018-03-29  JF Bastien  <jfbastien@apple.com>
1929
1930         Use Forward.h instead of forward-declaring WTF::String
1931         https://bugs.webkit.org/show_bug.cgi?id=184172
1932         <rdar://problem/39026146>
1933
1934         Reviewed by Yusuke Suzuki.
1935
1936         As part of #184164 I'm changing WTF::String, and the forward
1937         declarations are just wrong because I'm making it templated. We
1938         should use Forward.h anyways, so do that instead.
1939
1940         * WebView/WebScriptDebugger.h:
1941
1942 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
1943
1944         Protect against invalid mach ports returned by mach_port_request_notification
1945         https://bugs.webkit.org/show_bug.cgi?id=184106
1946         <rdar://problem/37865316>
1947
1948         Reviewed by Chris Dumez.
1949
1950         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1951         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
1952         and clean up if it experienced an error.
1953         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
1954
1955 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
1956
1957         Avoid uninitialized mach ports
1958         https://bugs.webkit.org/show_bug.cgi?id=184090
1959         <rdar://problem/37261129>
1960
1961         Reviewed by Chris Dumez.
1962
1963         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
1964         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
1965         there is a potential for us to try to use invalid ports.
1966
1967         We should always check return values, and ensure that the mach port variables we seek to initialize are
1968         kept in a valid state.
1969
1970         Reviewed by Chris Dumez.
1971
1972         * Plugins/Hosted/NetscapePluginHostManager.h:
1973         * Plugins/Hosted/NetscapePluginHostManager.mm:
1974         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
1975         port is passed to an API function.
1976         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
1977         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
1978         * Plugins/Hosted/NetscapePluginHostProxy.h:
1979         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1980         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
1981         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1982         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
1983         (WKPCStatusText): Ditto.
1984         (WKPCLoadURL): Ditto.
1985         (WKPCCancelLoadURL): Ditto.
1986         (WKPCInvalidateRect): Ditto.
1987         (WKPCGetScriptableNPObjectReply): Ditto.
1988         (WKPCBooleanReply): Ditto.
1989         (WKPCBooleanAndDataReply): Ditto.
1990         (WKPCInstantiatePluginReply): Ditto.
1991         (WKPCGetWindowNPObject): Ditto.
1992         (WKPCGetPluginElementNPObject): Ditto.
1993         (WKPCForgetBrowserObject): Ditto.
1994         (WKPCEvaluate): Ditto.
1995         (WKPCGetStringIdentifier): Ditto.
1996         (WKPCGetIntIdentifier): Ditto.
1997         (WKPCInvoke): Ditto.
1998         (WKPCInvokeDefault): Ditto.
1999         (WKPCConstruct): Ditto.
2000         (WKPCGetProperty): Ditto.
2001         (WKPCSetProperty): Ditto.
2002         (WKPCRemoveProperty): Ditto.
2003         (WKPCHasProperty): Ditto.
2004         (WKPCHasMethod): Ditto.
2005         (WKPCIdentifierInfo): Ditto.
2006         (WKPCEnumerate): Ditto.
2007         (WKPCSetMenuBarVisible): Ditto.
2008         (WKPCSetFullscreenWindowIsShowing): Ditto.
2009         (WKPCSetModal): Ditto.
2010         (WKPCGetCookies): Ditto.
2011         (WKPCGetProxy): Ditto.
2012         (WKPCSetCookies): Ditto.
2013         (WKPCGetAuthenticationInfo): Ditto.
2014         (WKPCConvertPoint): Ditto.
2015         (WKPCLayerHostingModeChanged): Ditto.
2016         (WKPCSetException): Ditto.
2017
2018 2018-03-26  Tim Horton  <timothy_horton@apple.com>
2019
2020         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
2021         https://bugs.webkit.org/show_bug.cgi?id=184030
2022         <rdar://problem/38895281>
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * Configurations/Base.xcconfig:
2027
2028 2018-03-26  Chris Dumez  <cdumez@apple.com>
2029
2030         Use SecurityOriginData more consistently in Service Worker code
2031         https://bugs.webkit.org/show_bug.cgi?id=183969
2032
2033         Reviewed by Darin Adler.
2034
2035         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2036
2037         * Storage/WebDatabaseManager.mm:
2038         (-[WebDatabaseManager databasesWithOrigin:]):
2039         (-[WebDatabaseManager deleteOrigin:]):
2040         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2041         * Storage/WebDatabaseQuotaManager.mm:
2042         (-[WebDatabaseQuotaManager usage]):
2043         (-[WebDatabaseQuotaManager quota]):
2044         (-[WebDatabaseQuotaManager setQuota:]):
2045         * Storage/WebStorageManager.mm:
2046         (-[WebStorageManager deleteOrigin:]):
2047         * WebCoreSupport/WebSecurityOrigin.mm:
2048         (-[WebSecurityOrigin databaseIdentifier]):
2049         (-[WebSecurityOrigin usage]):
2050         (-[WebSecurityOrigin quota]):
2051         (-[WebSecurityOrigin setQuota:]):
2052
2053 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2054
2055         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2056         https://bugs.webkit.org/show_bug.cgi?id=183911
2057         <rdar://problem/38762306>
2058
2059         Reviewed by Youenn Fablet.
2060
2061         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2062
2063         * WebView/WebView.mm:
2064         (+[WebView initialize]):
2065
2066 2018-03-26  Alex Christensen  <achristensen@webkit.org>
2067
2068         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
2069         https://bugs.webkit.org/show_bug.cgi?id=183965
2070
2071         Reviewed by Chris Dumez.
2072
2073         * WebCoreSupport/WebFrameLoaderClient.h:
2074         * WebCoreSupport/WebFrameLoaderClient.mm:
2075         (WebFrameLoaderClient::willCacheResponse const):
2076
2077 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2078
2079         Unreviewed, rolling out r229954.
2080         https://bugs.webkit.org/show_bug.cgi?id=184000
2081
2082         Caused many layout tests to crash on Apple High Sierra,
2083         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2084         by dydz on #webkit).
2085
2086         Reverted changeset:
2087
2088         "Use SecurityOriginData more consistently in Service Worker
2089         code"
2090         https://bugs.webkit.org/show_bug.cgi?id=183969
2091         https://trac.webkit.org/changeset/229954
2092
2093 2018-03-24  Chris Dumez  <cdumez@apple.com>
2094
2095         Use SecurityOriginData more consistently in Service Worker code
2096         https://bugs.webkit.org/show_bug.cgi?id=183969
2097
2098         Reviewed by Darin Adler.
2099
2100         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2101
2102         * Storage/WebDatabaseManager.mm:
2103         (-[WebDatabaseManager databasesWithOrigin:]):
2104         (-[WebDatabaseManager deleteOrigin:]):
2105         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2106         * Storage/WebDatabaseQuotaManager.mm:
2107         (-[WebDatabaseQuotaManager usage]):
2108         (-[WebDatabaseQuotaManager quota]):
2109         (-[WebDatabaseQuotaManager setQuota:]):
2110         * Storage/WebStorageManager.mm:
2111         (-[WebStorageManager deleteOrigin:]):
2112         * WebCoreSupport/WebSecurityOrigin.mm:
2113         (-[WebSecurityOrigin databaseIdentifier]):
2114         (-[WebSecurityOrigin usage]):
2115         (-[WebSecurityOrigin quota]):
2116         (-[WebSecurityOrigin setQuota:]):
2117
2118 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
2119
2120         Fix the build
2121
2122         * WebView/WebView.mm:
2123
2124 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2125
2126         Fix the build with no pasteboard
2127         https://bugs.webkit.org/show_bug.cgi?id=183973
2128
2129         Reviewed by Dan Bernstein.
2130
2131         * Configurations/FeatureDefines.xcconfig:
2132         * WebView/WebView.mm:
2133         (-[WebView _requestStartDataInteraction:globalPosition:]):
2134         (-[WebView _getDataInteractionData]):
2135         (-[WebView _dataOperationTextIndicator]):
2136         (-[WebView _dragSourceAction]):
2137         (-[WebView _draggedLinkTitle]):
2138         (-[WebView _draggedLinkURL]):
2139         (-[WebView _draggedElementBounds]):
2140         (-[WebView _enteredDataInteraction:client:global:operation:]):
2141         (-[WebView _updatedDataInteraction:client:global:operation:]):
2142         (-[WebView _exitedDataInteraction:client:global:operation:]):
2143         (-[WebView _performDataInteraction:client:global:operation:]):
2144         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
2145         (-[WebView _endedDataInteraction:global:]):
2146         (-[WebView _dataInteractionCaretRect]):
2147         * WebView/WebViewPrivate.h:
2148
2149 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2150
2151         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
2152         https://bugs.webkit.org/show_bug.cgi?id=183960
2153         <rdar://problem/38812356>
2154
2155         Reviewed by Dan Bernstein.
2156
2157         * Configurations/WebKitLegacy.xcconfig:
2158
2159 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2160
2161         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
2162         https://bugs.webkit.org/show_bug.cgi?id=183954
2163         <rdar://problem/38808858>
2164
2165         Reviewed by Dan Bernstein.
2166
2167         * WebView/WebPreferences.mm:
2168         (-[WebPreferences setAudioSessionCategoryOverride:]):
2169
2170 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2171
2172         Adopt WK_PLATFORM_NAME in WebKitLegacy
2173         https://bugs.webkit.org/show_bug.cgi?id=183948
2174         <rdar://problem/38803908>
2175
2176         Reviewed by Dan Bernstein.
2177
2178         * Configurations/WebKitLegacy.xcconfig:
2179         * MigrateHeaders.make:
2180         * postprocess-headers.sh:
2181
2182 2018-03-23  Brady Eidson  <beidson@apple.com>
2183
2184         Go to back/forward list items after a process-swapped navigation.
2185         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2186
2187         Reviewed by Andy Estes.
2188
2189         * WebView/WebView.mm:
2190         (-[WebView _loadBackForwardListFromOtherView:]):
2191         (-[WebView goToBackForwardItem:]):
2192
2193 2018-03-22  Tim Horton  <timothy_horton@apple.com>
2194
2195         Improve readability of WebCore's OTHER_LDFLAGS
2196         https://bugs.webkit.org/show_bug.cgi?id=183909
2197         <rdar://problem/38760992>
2198
2199         Reviewed by Dan Bernstein.
2200
2201         * Configurations/Base.xcconfig:
2202         * Configurations/FeatureDefines.xcconfig:
2203
2204 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2205
2206         Enable the minimal simulator feature flag when appropriate
2207         https://bugs.webkit.org/show_bug.cgi?id=183807
2208
2209         Reviewed by Dan Bernstein.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2018-03-20  Tim Horton  <timothy_horton@apple.com>
2214
2215         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
2216         https://bugs.webkit.org/show_bug.cgi?id=183758
2217         <rdar://problem/38017644>
2218
2219         Reviewed by Dan Bernstein.
2220
2221         * Configurations/FeatureDefines.xcconfig:
2222
2223 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
2224
2225         Clear style colors when setting default appearance
2226         https://bugs.webkit.org/show_bug.cgi?id=183759
2227
2228         Reviewed by Tim Horton.
2229
2230         Colors are cached and need to be cleared and recalculated.
2231         Refactor to do all style recalcs together.
2232
2233         * WebView/WebView.mm:
2234         (-[WebView _setDefaultAppearanceAndClearStyle]):
2235         (-[WebView _setUseSystemAppearance:]):
2236         (-[WebView effectiveAppearanceDidChange]):
2237
2238 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2239
2240         Unreviewed, another quick fix for r229699
2241
2242         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
2243
2244         * Configurations/FeatureDefines.xcconfig:
2245
2246 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
2247
2248         Ensure that style is updated when the effective appearance changes
2249         https://bugs.webkit.org/show_bug.cgi?id=183690
2250         <rdar://problem/38385900>
2251
2252         Reviewed by Tim Horton and Wenson Hsieh.
2253
2254         Respond to and respect the effective appearance changing.
2255
2256         * WebView/WebView.mm:
2257         (-[WebView _setUseSystemAppearance:]):
2258         (-[WebView effectiveAppearanceDidChange]):
2259
2260 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
2261
2262         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
2263         https://bugs.webkit.org/show_bug.cgi?id=183677
2264
2265         Reviewed by Tim Horton.
2266
2267         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
2268
2269         * DOM/DOM.mm:
2270         (-[DOMHTMLLinkElement _mediaQueryMatches]):
2271
2272 2018-03-14  Tim Horton  <timothy_horton@apple.com>
2273
2274         Fix the build after r229567
2275
2276         * Configurations/FeatureDefines.xcconfig:
2277
2278 2018-03-12  Tim Horton  <timothy_horton@apple.com>
2279
2280         Stop using SDK conditionals to control feature definitions
2281         https://bugs.webkit.org/show_bug.cgi?id=183430
2282         <rdar://problem/38251619>
2283
2284         Reviewed by Dan Bernstein.
2285
2286         * Configurations/FeatureDefines.xcconfig:
2287         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
2288
2289 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
2290
2291         Runtime flag for link prefetch and remove link subresource.
2292         https://bugs.webkit.org/show_bug.cgi?id=183540
2293
2294         Reviewed by Chris Dumez.
2295
2296         Remove the LINK_PREFETCH build time flag.
2297
2298         * Configurations/FeatureDefines.xcconfig:
2299
2300 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
2301
2302         Remove GridLayout runtime flag
2303         https://bugs.webkit.org/show_bug.cgi?id=183484
2304
2305         Reviewed by Myles C. Maxfield.
2306
2307         The Grid Layout feature has been enabled by default for almost a
2308         year, so I think it's time to remove the runtime flag and the
2309
2310         * WebView/WebPreferenceKeysPrivate.h:
2311         * WebView/WebPreferences.mm:
2312         (+[WebPreferences initialize]):
2313         * WebView/WebPreferencesPrivate.h:
2314         * WebView/WebView.mm:
2315         (-[WebView _preferencesChanged:]):
2316
2317 2018-03-12  Antoine Quint  <graouts@apple.com>
2318
2319         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2320         https://bugs.webkit.org/show_bug.cgi?id=183504
2321         <rdar://problem/38372965>
2322
2323         Reviewed by Dean Jackson and Jon Lee.
2324
2325         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2326         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2327
2328         * WebView/WebPreferenceKeysPrivate.h:
2329         * WebView/WebPreferences.mm:
2330         (+[WebPreferences initialize]):
2331         (-[WebPreferences setModernMediaControlsEnabled:]):
2332         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
2333         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
2334         * WebView/WebPreferencesPrivate.h:
2335         * WebView/WebView.mm:
2336         (-[WebView _preferencesChanged:]):
2337
2338 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
2339
2340         Media query for default appearance
2341         https://bugs.webkit.org/show_bug.cgi?id=183539
2342         <rdar://problem/38326388>
2343
2344         Reviewed by Tim Horton.
2345
2346         Write a media query to evaluate appearance.
2347
2348         * WebView/WebView.mm:
2349         (-[WebView _commonInitializationWithFrameName:groupName:]):
2350         (-[WebView _setUseSystemAppearance:]):
2351
2352 2018-03-09  Andy Estes  <aestes@apple.com>
2353
2354         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
2355         https://bugs.webkit.org/show_bug.cgi?id=183489
2356         <rdar://problem/38267517>
2357
2358         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
2359         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
2360         to issue a sandbox extension for this directory, but for security reasons App Sandbox
2361         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
2362         block with a nil error and a valid file URL, but no file will actually exist at that URL.
2363
2364         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
2365         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
2366         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
2367         drop destination.
2368
2369         Reviewed by Wenson Hsieh.
2370
2371         * WebView/WebView.mm:
2372         (-[WebView performDragOperation:]):
2373
2374 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
2375
2376         Allow WebViews to disable system appearance
2377         https://bugs.webkit.org/show_bug.cgi?id=183418
2378         <rdar://problem/36975642>
2379
2380         Reviewed by Tim Horton.
2381
2382         Allow webviews to choose whether or not to follow the default system appearance.
2383
2384         * WebView/WebView.mm:
2385         (-[WebView _setUseSystemAppearance:]):
2386         (-[WebView _useSystemAppearance]):
2387         * WebView/WebViewPrivate.h:
2388
2389 2018-03-08  Youenn Fablet  <youenn@apple.com>
2390
2391         libwebrtc update broke internal builds
2392         https://bugs.webkit.org/show_bug.cgi?id=183454
2393
2394         Reviewed by Eric Carlson.
2395
2396         * Configurations/WebKitLegacy.xcconfig:
2397
2398 2018-03-08  Chris Dumez  <cdumez@apple.com>
2399
2400         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
2401         https://bugs.webkit.org/show_bug.cgi?id=183455
2402         <rdar://problem/38191749>
2403
2404         Reviewed by Youenn Fablet.
2405
2406         Add a null check for the page as we have evidence from crashes that it can be null.
2407         Other functions in WebFrameNetworkingContext already null check the page as well,
2408         not just the frame so this is consistent.
2409
2410         * WebCoreSupport/WebFrameNetworkingContext.mm:
2411         (WebFrameNetworkingContext::storageSession const):
2412
2413 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2414
2415         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2416         https://bugs.webkit.org/show_bug.cgi?id=183429
2417
2418         Reviewed by Mark Lam.
2419
2420         * DOM/DOM.mm:
2421         (+[DOMNode _nodeFromJSWrapper:]):
2422         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2423         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
2424         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
2425         * Plugins/Hosted/ProxyInstance.mm:
2426         (WebKit::ProxyInstance::invokeMethod):
2427         * WebView/WebView.mm:
2428         (aeDescFromJSValue):
2429
2430 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2431
2432         Stop linking ApplicationServices directly
2433         https://bugs.webkit.org/show_bug.cgi?id=182867
2434         <rdar://problem/38252142>
2435
2436         Reviewed by Alex Christensen.
2437
2438         The frameworks that we use that live inside ApplicationServices
2439         have mostly moved out, so import them directly.
2440
2441         * Carbon/CarbonUtils.h:
2442         * WebKitPrefix.h:
2443         * WebView/WebHTMLView.mm:
2444         * WebView/WebPDFView.mm:
2445
2446 2018-03-07  Tim Horton  <timothy_horton@apple.com>
2447
2448         Sort and separate FeatureDefines.xcconfig
2449         https://bugs.webkit.org/show_bug.cgi?id=183427
2450
2451         Reviewed by Dan Bernstein.
2452
2453         * Configurations/FeatureDefines.xcconfig:
2454         Sort and split FeatureDefines into paragraphs
2455         (to make it easier to sort later).
2456
2457 2018-03-07  Youenn Fablet  <youenn@apple.com>
2458
2459         Match unsupported plugins based on domains and not origin
2460         https://bugs.webkit.org/show_bug.cgi?id=183384
2461
2462         Reviewed by Chris Dumez.
2463
2464         * WebCoreSupport/WebPluginInfoProvider.h:
2465         * WebCoreSupport/WebPluginInfoProvider.mm:
2466         (WebPluginInfoProvider::getPluginInfo):
2467         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2468
2469 2018-03-05  Andy Estes  <aestes@apple.com>
2470
2471         [Mac] Teach WebCore::Pasteboard about file promise drags
2472         https://bugs.webkit.org/show_bug.cgi?id=183314
2473         <rdar://problem/38105493>
2474
2475         Reviewed by Darin Adler.
2476
2477         Added a FIXME comment.
2478
2479         * WebView/WebView.mm:
2480         (-[WebView performDragOperation:]):
2481
2482 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2483
2484         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2485         https://bugs.webkit.org/show_bug.cgi?id=183312
2486
2487         Reviewed by Mark Lam.
2488
2489         Remove wtf/CurrentTime.h include pragma.
2490
2491         * WebView/WebFrame.mm:
2492         * WebView/WebPDFView.mm:
2493
2494 2018-03-04  Tim Horton  <timothy_horton@apple.com>
2495
2496         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
2497         https://bugs.webkit.org/show_bug.cgi?id=183283
2498         <rdar://problem/38062148>
2499
2500         Reviewed by Sam Weinig.
2501
2502         * Configurations/FeatureDefines.xcconfig:
2503
2504 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2505
2506         Reduce use of NetworkingContext in WebKit
2507         https://bugs.webkit.org/show_bug.cgi?id=183213
2508
2509         Reviewed by Brady Eidson.
2510
2511         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2512         (WebKit::NetscapePluginInstanceProxy::getProxy):
2513         * Plugins/WebNetscapePluginView.mm:
2514         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2515
2516 2018-02-17  Darin Adler  <darin@apple.com>
2517
2518         Prepare for ExtendedColor changes (first step)
2519         https://bugs.webkit.org/show_bug.cgi?id=182904
2520
2521         Reviewed by Sam Weinig.
2522
2523         * Misc/WebKitNSStringExtras.mm:
2524         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
2525
2526 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2527
2528         Remove currentTime() / currentTimeMS()
2529         https://bugs.webkit.org/show_bug.cgi?id=183052
2530
2531         Reviewed by Mark Lam.
2532
2533         * WebCoreSupport/WebFrameLoaderClient.h:
2534         * WebCoreSupport/WebFrameLoaderClient.mm:
2535         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2536
2537 2018-02-16  Youenn Fablet  <youenn@apple.com>
2538
2539         Allow specifying which plug-ins are supported
2540         https://bugs.webkit.org/show_bug.cgi?id=182748
2541
2542         Reviewed by Chris Dumez.
2543
2544         * WebCoreSupport/WebPluginInfoProvider.h:
2545         * WebCoreSupport/WebPluginInfoProvider.mm:
2546         (WebPluginInfoProvider::getPluginInfo):
2547         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2548
2549 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
2550
2551         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
2552         https://bugs.webkit.org/show_bug.cgi?id=182882
2553         <rdar://problem/35672661>
2554
2555         Reviewed by Dan Bernstein.
2556
2557         Make sure the smart pointer hold the collection of subviews lives at least as
2558         long as the loop using it.
2559
2560         * WebView/WebHTMLView.mm:
2561         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
2562
2563 2018-02-14  Daniel Bates  <dabates@apple.com>
2564
2565         Disallow cross-origin subresources from asking for credentials
2566         https://bugs.webkit.org/show_bug.cgi?id=182579
2567         <rdar://problem/36162271>
2568
2569         Reviewed by Andy Estes.
2570
2571         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
2572         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
2573
2574         * WebView/WebPreferenceKeysPrivate.h:
2575         * WebView/WebPreferences.mm:
2576         (+[WebPreferences initialize]):
2577         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
2578         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
2579         * WebView/WebPreferencesPrivate.h:
2580         * WebView/WebView.mm:
2581         (-[WebView _preferencesChanged:]):
2582
2583 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2584
2585         Remove ForwardingHeaders directory from WebKitLegacy/mac.
2586         https://bugs.webkit.org/show_bug.cgi?id=182738
2587
2588         Reviewed by Darin Adler.
2589
2590         * ForwardingHeaders/collector/handles/Global.h: Removed.
2591         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
2592         * ForwardingHeaders/runtime/Completion.h: Removed.
2593         * ForwardingHeaders/runtime/Error.h: Removed.
2594         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
2595         * ForwardingHeaders/runtime/JSFunction.h: Removed.
2596         * ForwardingHeaders/runtime/JSLock.h: Removed.
2597         * ForwardingHeaders/runtime/JSObject.h: Removed.
2598         * ForwardingHeaders/runtime/JSString.h: Removed.
2599         * ForwardingHeaders/runtime/Protect.h: Removed.
2600         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
2601
2602 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
2603
2604         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
2605         https://bugs.webkit.org/show_bug.cgi?id=182641
2606
2607         Reviewed by Dan Bernstein.
2608
2609         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
2610         https://trac.webkit.org/changeset/228308.
2611
2612         * WebView/WebVideoFullscreenController.h:
2613         * WebView/WebVideoFullscreenHUDWindowController.mm:
2614         * WebView/WebWindowAnimation.h:
2615         * WebView/WebWindowAnimation.mm:
2616         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
2617         (WebCore::scaledRect): Deleted.
2618         (WebCore::squaredDistance): Deleted.
2619
2620 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
2621
2622         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
2623
2624         * WebView/WebWindowAnimation.mm:
2625         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
2626
2627 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
2628
2629         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
2630         https://bugs.webkit.org/show_bug.cgi?id=182615
2631
2632         Reviewed by Eric Carlson.
2633
2634         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
2635         Ideally, we should not reference NSApp in WebCore.
2636
2637         * WebView/WebFullScreenController.mm:
2638         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
2639         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
2640         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
2641         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
2642         * WebView/WebView.mm:
2643         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
2644         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
2645
2646 2018-01-13  Darin Adler  <darin@apple.com>
2647
2648         Event improvements
2649         https://bugs.webkit.org/show_bug.cgi?id=179591
2650
2651         Reviewed by Chris Dumez.
2652
2653         * DOM/DOMWheelEvent.mm:
2654         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2655         Call initWebKitWheelEvent.
2656
2657         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
2658         * WebCoreSupport/WebInspectorClient.mm: Ditto.
2659         * WebView/WebFrame.mm: Ditto.
2660
2661         * WebView/WebHTMLView.mm:
2662         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
2663         underlyingPlatformEvent.
2664         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
2665
2666         * WebView/WebScriptWorld.mm:
2667         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
2668
2669         * WebView/WebView.mm: Removed include of ScriptValue.h.
2670
2671 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2672
2673         Remove WebCore/ForwardingHeaders directory
2674         https://bugs.webkit.org/show_bug.cgi?id=182347
2675
2676         Reviewed by Keith Miller.
2677
2678         * Carbon/CarbonWindowAdapter.mm:
2679         * DOM/WebDOMOperations.mm:
2680         * History/WebBackForwardList.mm:
2681         * History/WebHistoryItem.mm:
2682         * Misc/WebCache.mm:
2683         * Misc/WebElementDictionary.mm:
2684         * Misc/WebIconDatabase.mm:
2685         * Misc/WebStringTruncator.mm:
2686         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2687         * Plugins/Hosted/ProxyInstance.mm:
2688         * Plugins/Hosted/ProxyRuntimeObject.mm:
2689         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2690         * Plugins/WebBaseNetscapePluginView.mm:
2691         * Plugins/WebBasePluginPackage.mm:
2692         * Plugins/WebNetscapePluginStream.mm:
2693         * Plugins/WebNetscapePluginView.mm:
2694         * Plugins/WebPluginController.mm:
2695         * WebCoreSupport/WebEditorClient.mm:
2696         * WebCoreSupport/WebFrameLoaderClient.mm:
2697         * WebCoreSupport/WebInspectorClient.h:
2698         * WebCoreSupport/WebInspectorClient.mm:
2699         * WebView/WebDataSource.mm:
2700         * WebView/WebFrame.mm:
2701         * WebView/WebHTMLRepresentation.mm:
2702         * WebView/WebHTMLView.mm:
2703         * WebView/WebPreferences.mm:
2704         * WebView/WebScriptDebugDelegate.mm:
2705         * WebView/WebScriptDebugger.h:
2706         * WebView/WebTextIterator.mm:
2707         * WebView/WebView.mm:
2708         * WebView/WebViewData.mm:
2709
2710 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
2711
2712         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
2713         https://bugs.webkit.org/show_bug.cgi?id=182312
2714
2715         Reviewed by Michael Catanzaro.
2716
2717         * WebKitPrefix.h:
2718
2719 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
2720
2721         [WebAuthN] Add a compile-time feature flag
2722         https://bugs.webkit.org/show_bug.cgi?id=182211
2723         <rdar://problem/36936365>
2724
2725         Reviewed by Brent Fulgham.
2726
2727         * Configurations/FeatureDefines.xcconfig:
2728
2729 2018-01-27  Dan Bernstein  <mitz@apple.com>
2730
2731         HaveInternalSDK includes should be "#include?"
2732         https://bugs.webkit.org/show_bug.cgi?id=179670
2733
2734         * Configurations/Base.xcconfig:
2735
2736 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2737
2738         Remove unused QTKit preference
2739         https://bugs.webkit.org/show_bug.cgi?id=181968
2740
2741         Reviewed by Alexey Proskuryakov.
2742
2743         * WebView/WebPreferenceKeysPrivate.h:
2744         * WebView/WebPreferences.mm:
2745         (+[WebPreferences initialize]):
2746         (-[WebPreferences setQTKitEnabled:]): Deleted.
2747         (-[WebPreferences isQTKitEnabled]): Deleted.
2748         * WebView/WebPreferencesPrivate.h:
2749         * WebView/WebView.mm:
2750         (-[WebView _preferencesChanged:]):
2751
2752 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2753
2754         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
2755         https://bugs.webkit.org/show_bug.cgi?id=182037
2756         <rdar://problem/36747812>
2757
2758         Reviewed by Ryosuke Niwa.
2759
2760         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
2761         for more details.
2762
2763         * WebView/WebHTMLRepresentation.mm:
2764         (-[WebHTMLRepresentation elementWithName:inForm:]):
2765         (-[WebHTMLRepresentation controlsInForm:]):
2766
2767 2018-01-23  Alex Christensen  <achristensen@webkit.org>
2768
2769         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
2770         https://bugs.webkit.org/show_bug.cgi?id=181961
2771
2772         Reviewed by Michael Catanzaro.
2773
2774         * WebView/WebPreferences.mm:
2775
2776 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2777
2778         Unreviewed, rolling out r227437.
2779         https://bugs.webkit.org/show_bug.cgi?id=182011
2780
2781         broke build (Requested by alexchristensen on #webkit).
2782
2783         Reverted changeset:
2784
2785         "Remove unused QTKit preference"
2786         https://bugs.webkit.org/show_bug.cgi?id=181968
2787         https://trac.webkit.org/changeset/227437
2788
2789 2018-01-23  Alex Christensen  <achristensen@webkit.org>
2790
2791         Remove unused QTKit preference
2792         https://bugs.webkit.org/show_bug.cgi?id=181968
2793
2794         Reviewed by Alexey Proskuryakov.
2795
2796         * WebView/WebPreferenceKeysPrivate.h:
2797         * WebView/WebPreferences.mm:
2798         (+[WebPreferences initialize]):
2799         (-[WebPreferences setQTKitEnabled:]): Deleted.
2800         (-[WebPreferences isQTKitEnabled]): Deleted.
2801         * WebView/WebPreferencesPrivate.h:
2802         * WebView/WebView.mm:
2803         (-[WebView _preferencesChanged:]):
2804
2805 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2806
2807         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
2808         https://bugs.webkit.org/show_bug.cgi?id=181960
2809         <rdar://problem/36431678>
2810
2811         Reviewed by Tim Horton.
2812
2813         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
2814         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
2815         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
2816
2817         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
2818         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
2819         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
2820
2821         * WebView/WebView.mm:
2822         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2823
2824 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
2825
2826         Turning off custom pasteboard data doesn't actually turn it off in WK2
2827         https://bugs.webkit.org/show_bug.cgi?id=181920
2828         <rdar://problem/36686429>
2829
2830         Reviewed by Wenson Hsieh.
2831
2832         Always disable custom pasteboard data in WebKit1. See r226156 for details.
2833
2834         * WebView/WebPreferences.mm:
2835         (+[WebPreferences initialize]):
2836         * WebView/WebView.mm:
2837         (-[WebView _preferencesChanged:]):
2838
2839 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2840
2841         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2842         https://bugs.webkit.org/show_bug.cgi?id=181918
2843
2844         Reviewed by Tim Horton.
2845
2846         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2847
2848         * Configurations/FeatureDefines.xcconfig:
2849
2850 2018-01-20  Andy Estes  <aestes@apple.com>
2851
2852         [Apple Pay] Stop eagerly loading PassKit.framework
2853         https://bugs.webkit.org/show_bug.cgi?id=181911
2854         <rdar://problem/36555369>
2855
2856         Reviewed by Tim Horton.
2857
2858         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2859         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2860         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
2861
2862         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
2863
2864 2018-01-19  Dean Jackson  <dino@apple.com>
2865
2866         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
2867         https://bugs.webkit.org/show_bug.cgi?id=181817
2868         <rdar://problem/35274055>
2869
2870         Reviewed by Simon Fraser.
2871
2872         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
2873
2874         * Misc/WebKitVersionChecks.h:
2875         * WebView/WebView.mm:
2876         (-[WebView _commonInitializationWithFrameName:groupName:]):
2877
2878 2018-01-19  Alex Christensen  <achristensen@webkit.org>
2879
2880         Remove unused WebViewPrivate _allowCookies
2881         https://bugs.webkit.org/show_bug.cgi?id=181812
2882
2883         Reviewed by Tim Horton.
2884
2885         * WebView/WebView.mm:
2886         (+[WebView _setAllowCookies:]): Deleted.
2887         (+[WebView _allowCookies]): Deleted.
2888         * WebView/WebViewPrivate.h:
2889
2890 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
2891
2892         Build fix, remove a call to -[NSWindow setOneShot:]
2893         https://bugs.webkit.org/show_bug.cgi?id=181809
2894
2895         Reviewed by Tim Horton.
2896
2897         * WebView/WebTextCompletionController.mm:
2898         (-[WebTextCompletionController _buildUI]):
2899
2900 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2901
2902         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
2903
2904         * Carbon/HIWebView.mm:
2905         (overrideCGContext):
2906         (restoreCGContext):
2907
2908 2018-01-18  Dan Bernstein  <mitz@apple.com>
2909
2910         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2911         https://bugs.webkit.org/show_bug.cgi?id=181803
2912
2913         Reviewed by Tim Horton.
2914
2915         * Configurations/Base.xcconfig: Updated.
2916         * Configurations/DebugRelease.xcconfig: Ditto.
2917         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
2918         * Configurations/Version.xcconfig: Updated.
2919         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
2920           useful for defining settings that depend on the target macOS version.
2921
2922 2018-01-17  Youenn Fablet  <youenn@apple.com>
2923
2924         Put fetch Request.keepalive behind a runtime flag
2925         https://bugs.webkit.org/show_bug.cgi?id=181592
2926
2927         Reviewed by Chris Dumez.
2928
2929         * WebView/WebPreferenceKeysPrivate.h:
2930         * WebView/WebPreferences.mm:
2931         (+[WebPreferences initialize]):
2932         (-[WebPreferences fetchAPIKeepAliveEnabled]):
2933         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
2934         * WebView/WebPreferencesPrivate.h:
2935         * WebView/WebView.mm:
2936         (-[WebView _preferencesChanged:]):
2937
2938 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2939
2940         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2941         https://bugs.webkit.org/show_bug.cgi?id=181637
2942         <rdar://problem/36508471>
2943
2944         Reviewed by Tim Horton.
2945
2946         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2947
2948         * WebCoreSupport/WebEditorClient.h:
2949         * WebCoreSupport/WebEditorClient.mm:
2950         (WebEditorClient::replacementURLForResource):
2951
2952 2018-01-11  Keith Miller  <keith_miller@apple.com>
2953
2954         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2955         https://bugs.webkit.org/show_bug.cgi?id=181573
2956
2957         Reviewed by Simon Fraser.
2958
2959         * Configurations/FeatureDefines.xcconfig:
2960
2961 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2962
2963         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
2964         https://bugs.webkit.org/show_bug.cgi?id=181497
2965
2966         Reviewed by Tim Horton.
2967
2968         See other ChangeLogs for more detail.
2969
2970         * WebCoreSupport/WebDragClient.h:
2971
2972 2018-01-11  Tim Horton  <timothy_horton@apple.com>
2973
2974         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
2975         https://bugs.webkit.org/show_bug.cgi?id=181523
2976         <rdar://problem/28959131>
2977
2978         Reviewed by Alex Christensen.
2979
2980         * WebView/WebImmediateActionController.mm:
2981         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2982         Apply the change made in r216652 to WebKit1's immediate action controller.
2983
2984         Speculative (but successful in WebKit2) fix for non-reproducible crash when
2985         the startContainer of the range is in an anonymous node.
2986
2987 2018-01-11  Youenn Fablet  <youenn@apple.com>
2988
2989         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
2990         https://bugs.webkit.org/show_bug.cgi?id=181480
2991
2992         Reviewed by Eric Carlson.
2993
2994         * WebView/WebPreferences.mm:
2995         (+[WebPreferences initialize]):
2996
2997 2018-01-08  David Kilzer  <ddkilzer@apple.com>
2998
2999         Fix check-webkit-style issues with WebNSDataExtras.mm
3000         <https://webkit.org/b/181369>
3001
3002         Reviewed by Alex Christensen.
3003
3004         * Misc/WebNSDataExtras.mm:
3005         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3006         (-[NSData _webkit_guessedMIMETypeForXML]):
3007         (-[NSData _webkit_guessedMIMEType]):
3008         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3009         (_findEOL):
3010         (-[NSData _webkit_parseRFC822HeaderFields]):
3011         (-[NSData _web_locationAfterFirstBlankLine]):
3012         - Fix all the check-webkit-style warnings.
3013
3014 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3015
3016         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3017         <https://webkit.org/b/181256>
3018         <rdar://problem/36281730>
3019
3020         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3021         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
3022         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
3023           to avoid warnings from casting CFStringRef to NPNSString*.
3024           Note that CFMutableStringRef is the same as CFStringRef
3025           without the const modifier, hence its use in the const_cast<>
3026           above.
3027
3028 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3029
3030         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3031         <https://webkit.org/b/181256>
3032         <rdar://problem/36281730>
3033
3034         * Carbon/HIWebView.mm:
3035         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
3036         checked_cf_cast<CFRunLoopRef>() to fix warning.
3037
3038 2018-01-07  David Kilzer  <ddkilzer@apple.com>
3039
3040         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3041         <https://webkit.org/b/181256>
3042         <rdar://problem/36281730>
3043
3044         Reviewed by Darin Adler.
3045
3046         * Carbon/CarbonUtils.m:
3047         (PoolCleaner):
3048         - Use #pragmas to ignore -Wcast-qual warnings when using a
3049           C-style cast from CFTypeRef to CFRunloopRef.
3050         * Carbon/CarbonWindowFrame.m:
3051         (-[CarbonWindowFrame title]):
3052         - Use #pragmas to ignore -Wcast-qual warnings when using a
3053           C-style cast from CFStringRef to NSString *.
3054         * Carbon/HIViewAdapter.m:
3055         (+[HIViewAdapter getHIViewForNSView:]):
3056         - Use #pragmas to ignore -Wcast-qual warnings when using a
3057           C-style cast from CFTypeRef to HIViewRef.
3058         * Configurations/Base.xcconfig:
3059         (WARNING_CFLAGS): Add -Wcast-qual.
3060         * Misc/WebElementDictionary.mm:
3061         (-[WebElementDictionary objectForKey:]):
3062         - Use static_cast<SEL>(const_cast<void*>()) to fix
3063           warning.
3064         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
3065         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3066         (-[NSData _webkit_guessedMIMETypeForXML]):
3067         (-[NSData _webkit_guessedMIMEType]):
3068         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3069         (_findEOL):
3070         (-[NSData _webkit_parseRFC822HeaderFields]):
3071         (-[NSData _web_startsWithBlankLine]):
3072         (-[NSData _web_locationAfterFirstBlankLine]):
3073         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
3074           type to Objective-C++.  This fixes the warnings about
3075           discarding the `const` modifier when casing from CFStringRef
3076           to NSString * because in older clang versions, -Wcast-qual was
3077           completely broken when compiling C++ and Objective-C++ source
3078           files.  In newer clang versions, discarding the `const`
3079           modifier for toll-free bridged types is ignored when compiling
3080           Objective-C++ source.
3081         - Update copyright and license header.
3082         - Use reinterpret_cast<> and static_cast<> to fix warnings
3083           unrelated to (NSString *) C-style casts.
3084         - Replace use of MIN() macro with std::min<> template functions.
3085         - Fix location of `*` for local variables modified above.
3086         * Plugins/Hosted/NetscapePluginHostManager.mm:
3087         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3088         (WebKit::NetscapePluginHostManager::initializeVendorPort):
3089         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3090         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
3091           warnings.
3092         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3093         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3094         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
3095           to fix warning.
3096         * Plugins/Hosted/ProxyInstance.mm:
3097         (WebKit::ProxyInstance::invoke):
3098         - Use static_cast<char*>(const_cast<void*>()) to fix
3099           warning when using -[NSData bytes].
3100         (WebKit::ProxyInstance::fieldValue const):
3101         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
3102           to fix warning when using CFDataGetBytePtr().
3103         * Plugins/Hosted/WebTextInputWindowController.m:
3104         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3105         - Use #pragma to ignore -Wcast-qual warning since there
3106           is not a good way to avoid this warning in Objective-C.
3107         * Plugins/WebNetscapePluginStream.mm:
3108         (WebNetscapePluginStream::deliverData):
3109         - Use const_cast<void*>() to fix warning when using
3110           -[NSData bytes].
3111         * Plugins/WebNetscapePluginView.mm:
3112         (-[WebNetscapePluginView _createPlugin]):
3113         - Change C-style cast to const_cast<char*>() to fix
3114           warning.
3115         * WebCoreSupport/WebChromeClient.mm:
3116         (WebChromeClient::wrapCryptoKey const):
3117         (WebChromeClient::unwrapCryptoKey const):
3118         - Change C-style cast to
3119           static_cast<uint8_t*>(const_cast<void*>() to fix
3120           warning.
3121         * WebView/WebPDFView.mm:
3122         (_applicationInfoForMIMEType):
3123         - Change local variable type from 'NSURL *' to
3124           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
3125           when calling -[NSURL path].
3126
3127 2018-01-05  Dan Bernstein  <mitz@apple.com>
3128
3129         Fixed the build following AppKit API deprecations in a recent SDKs
3130
3131         * WebView/WebFullScreenController.mm:
3132         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
3133         (-[WebFullScreenController exitFullScreen]): Ditto.
3134         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
3135         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
3136         * WebView/WebHTMLView.mm:
3137         (-[WebHTMLView drawRect:]): Ditto.
3138         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
3139         (-[WebHTMLView knowsPageRange:]): Ditto.
3140         * WebView/WebView.mm:
3141         (LayerFlushController::flushLayers): Ditto.
3142
3143 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3144
3145         [Attachment Support] Create attachment elements when dropping files on iOS
3146         https://bugs.webkit.org/show_bug.cgi?id=181192
3147         <rdar://problem/36280945>
3148
3149         Reviewed by Tim Horton.
3150
3151         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
3152
3153         * WebCoreSupport/WebPlatformStrategies.h:
3154         * WebCoreSupport/WebPlatformStrategies.mm:
3155         (WebPlatformStrategies::informationForItemAtIndex):
3156         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
3157
3158 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3159
3160         [Attachment Support] Add plumbing for starting a drag with promised blob data
3161         https://bugs.webkit.org/show_bug.cgi?id=181201
3162
3163         Reviewed by Tim Horton.
3164
3165         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
3166
3167         * WebCoreSupport/WebDragClient.h:
3168
3169 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3170
3171         Add a WebAuthentication runtime feature flag
3172         https://bugs.webkit.org/show_bug.cgi?id=181220
3173         <rdar://problem/36055305>
3174
3175         Reviewed by Brent Fulgham.
3176
3177         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3178
3179         * WebView/WebPreferenceKeysPrivate.h:
3180         * WebView/WebPreferences.mm:
3181         (+[WebPreferences initialize]):
3182         (-[WebPreferences webAuthenticationEnabled]):
3183         (-[WebPreferences setWebAuthenticationEnabled:]):
3184         (-[WebPreferences credentialManagementEnabled]): Deleted.
3185         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
3186         * WebView/WebPreferencesPrivate.h:
3187         * WebView/WebView.mm:
3188         (-[WebView _preferencesChanged:]):
3189
3190 2017-12-22  Jeff Miller  <jeffm@apple.com>
3191
3192         Update user-visible copyright strings to include 2018
3193         https://bugs.webkit.org/show_bug.cgi?id=181141
3194
3195         Reviewed by Dan Bernstein.
3196
3197         * Info.plist:
3198
3199 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3200
3201         [Attachment Support] Remove current macOS support for dragging file-backed attachments
3202         https://bugs.webkit.org/show_bug.cgi?id=181188
3203
3204         Reviewed by Dan Bernstein.
3205
3206         See WebCore/ChangeLog for more detail.
3207
3208         * WebCoreSupport/WebDragClient.h:
3209         * WebCoreSupport/WebDragClient.mm:
3210         (WebDragClient::declareAndWriteAttachment): Deleted.
3211         * WebView/WebHTMLView.mm:
3212         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
3213
3214 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3215
3216         Unreviewed, continue to fix build failures due to AppKit API deprecation
3217
3218         Wraps more code in -Wdeprecated-declarations.
3219
3220         * Carbon/HIWebView.mm:
3221         (overrideCGContext):
3222
3223 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3224
3225         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
3226
3227         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
3228
3229         * Carbon/CarbonWindowAdapter.mm:
3230         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3231         * Plugins/WebNetscapePluginView.mm:
3232         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3233         (-[WebNetscapePluginView sendDrawRectEvent:]):
3234         (-[WebNetscapePluginView drawRect:]):
3235
3236 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3237
3238         Fix build failures due to using deprecated AppKit symbols
3239         https://bugs.webkit.org/show_bug.cgi?id=181110
3240         <rdar://problem/36162865>
3241
3242         Reviewed by Dan Bernstein and Tim Horton.
3243
3244         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
3245
3246         * Misc/WebKitNSStringExtras.mm:
3247         (-[NSString _web_drawAtPoint:font:textColor:]):
3248         * Misc/WebNSPasteboardExtras.h:
3249         * Misc/WebNSPasteboardExtras.mm:
3250         (+[NSPasteboard _web_writableTypesForURL]):
3251         (_createWritableTypesForImageWithoutArchive):
3252         (_createWritableTypesForImageWithArchive):
3253         (+[NSPasteboard _web_dragTypesForURL]):
3254         (-[NSPasteboard _web_bestURL]):
3255         (-[NSPasteboard _web_writeURL:andTitle:types:]):
3256         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3257         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
3258         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
3259         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3260         * Panels/WebAuthenticationPanel.m:
3261         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
3262         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
3263         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3264         (-[WebHostedNetscapePluginView drawRect:]):
3265         * WebInspector/WebNodeHighlightView.mm:
3266         (-[WebNodeHighlightView drawRect:]):
3267         * WebView/WebFrame.mm:
3268         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3269         (-[WebFrame _drawRect:contentsOnly:]):
3270         * WebView/WebHTMLView.mm:
3271         (kit):
3272         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
3273         (-[WebHTMLView _plainTextFromPasteboard:]):
3274         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3275         (+[WebHTMLView _insertablePasteboardTypes]):
3276         (+[WebHTMLView _selectionPasteboardTypes]):
3277         (-[WebHTMLView pasteboard:provideDataForType:]):
3278         (-[WebHTMLView _writeSelectionToPasteboard:]):
3279         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3280         (-[WebHTMLView validRequestorForSendType:returnType:]):
3281         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3282         (createMenuItem):
3283         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3284         (-[WebHTMLView _colorAsString:]):
3285         (-[WebHTMLView copyFont:]):
3286         * WebView/WebPDFView.mm:
3287         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3288         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3289         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3290         (-[WebPDFView pasteboardTypesForSelection]):
3291         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
3292         * WebView/WebView.h:
3293         * WebView/WebView.mm:
3294         (-[WebView performDragOperation:]):
3295         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
3296         (-[WebView _searchWithGoogleFromMenu:]):
3297
3298 2017-12-21  Youenn Fablet  <youenn@apple.com>
3299
3300         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
3301         https://bugs.webkit.org/show_bug.cgi?id=181000
3302
3303         Reviewed by Chris Dumez.
3304
3305         * Misc/WebCache.mm:
3306         (+[WebCache addImageToCache:forURL:forFrame:]):
3307
3308 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
3309
3310         Update FULLSCREEN_API feature defines.
3311         https://bugs.webkit.org/show_bug.cgi?id=181015
3312
3313         Reviewed by Tim Horton.
3314
3315         Change enabled iphone sdk for FULLSCREEN_API.
3316
3317         * Configurations/FeatureDefines.xcconfig:
3318
3319 2017-12-21  Jer Noble  <jer.noble@apple.com>
3320
3321         Add initial DOM support for Media Capabilities
3322         https://bugs.webkit.org/show_bug.cgi?id=181064
3323
3324         Reviewed by Eric Carlson.
3325
3326         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
3327
3328         * WebView/WebPreferenceKeysPrivate.h:
3329         * WebView/WebPreferences.mm:
3330         (+[WebPreferences initialize]):
3331         (-[WebPreferences mediaCapabilitiesEnabled]):
3332         (-[WebPreferences setMediaCapabilitiesEnabled:]):
3333         * WebView/WebPreferencesPrivate.h:
3334         * WebView/WebView.mm:
3335         (-[WebView _preferencesChanged:]):
3336
3337 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
3338
3339         Enable picture-in-picture from inline element on suspend.
3340         https://bugs.webkit.org/show_bug.cgi?id=180942
3341         rdar://problem/34745234
3342
3343         Reviewed by Jer Noble.
3344
3345         Update signature of enterVideoFullscreenForVideoElement().
3346
3347         * WebCoreSupport/WebChromeClient.h:
3348         * WebCoreSupport/WebChromeClient.mm:
3349         (WebChromeClient::enterVideoFullscreenForVideoElement):
3350
3351 2017-12-20  Daniel Bates  <dabates@apple.com>
3352
3353         Remove Alternative Presentation Button
3354         https://bugs.webkit.org/show_bug.cgi?id=180500
3355         <rdar://problem/35891047>
3356
3357         Reviewed by Simon Fraser.
3358
3359         We no longer need the alternative presentation button.
3360
3361         * Configurations/FeatureDefines.xcconfig:
3362
3363 2017-12-19  Jer Noble  <jer.noble@apple.com>
3364
3365         Playing media elements which call "pause(); play()" will have the play promise rejected.
3366         https://bugs.webkit.org/show_bug.cgi?id=180781
3367         <rdar://problem/33191377>
3368
3369         Reviewed by Eric Carlson.
3370
3371         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
3372
3373         * WebView/WebView.mm:
3374         (shouldRequireUserGestureToLoadVideo):
3375
3376 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3377
3378         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
3379         https://bugs.webkit.org/show_bug.cgi?id=180977
3380
3381         Reviewed by Tim Horton.
3382
3383         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
3384         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
3385         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
3386
3387         * WebCoreSupport/WebEditorClient.mm:
3388         (attributesForAttributedStringConversion):
3389         * WebView/WebHTMLView.mm:
3390         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
3391
3392 2017-12-18  David Kilzer  <ddkilzer@apple.com>
3393
3394         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
3395
3396         Attempt to fix the following warnings:
3397
3398             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
3399
3400         For the following instance variables:
3401
3402             _borderView
3403             _contentView
3404             _frame
3405             _wFlags
3406
3407         * Carbon/CarbonWindowAdapter.mm:
3408         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3409         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3410         (-[CarbonWindowAdapter _termWindowIfOwner]):
3411         (-[CarbonWindowAdapter _windowMovedToRect:]):
3412         (-[CarbonWindowAdapter setContentView:]):
3413         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3414         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3415
3416 2017-12-16  Dan Bernstein  <mitz@apple.com>
3417
3418         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
3419         https://bugs.webkit.org/show_bug.cgi?id=180613
3420         <rdar://problem/35946124>
3421
3422         Reviewed by Geoff Garen.
3423
3424         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
3425           clients.
3426         * WebView/WebDynamicScrollBarsView.h: Ditto.
3427         * WebView/WebDynamicScrollBarsView.mm: Ditto.
3428
3429 2017-12-14  David Kilzer  <ddkilzer@apple.com>
3430
3431         Enable -Wstrict-prototypes for WebKit
3432         <https://webkit.org/b/180757>
3433         <rdar://problem/36024132>
3434
3435         Rubber-stamped by Joseph Pecoraro.
3436
3437         * Configurations/Base.xcconfig:
3438         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
3439
3440 2017-12-14  John Wilander  <wilander@apple.com>
3441
3442         Storage Access API: Implement frame-specific access in the document.cookie layer
3443         https://bugs.webkit.org/show_bug.cgi?id=180682
3444         <rdar://problem/35982257>
3445
3446         Reviewed by Alex Christensen.
3447
3448         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
3449         CookiesStrategy::cookieRequestHeaderFieldValue(), and
3450         CookiesStrategy::getRawCookies() now take optional parameters for
3451         frameID and pageID to allow frame-specific scoping of cookies.
3452
3453         This change makes the return values of FrameLoaderClient::frameID()
3454         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
3455         WebCore can call those getters and get the right return values in
3456         WebKit and std:nullopt in WebKitLegacy.
3457
3458         * WebCoreSupport/WebFrameLoaderClient.h:
3459         * WebCoreSupport/WebFrameLoaderClient.mm:
3460         (WebFrameLoaderClient::pageID const):
3461         (WebFrameLoaderClient::frameID const):
3462         * WebCoreSupport/WebPlatformStrategies.h:
3463         * WebCoreSupport/WebPlatformStrategies.mm:
3464         (WebPlatformStrategies::cookiesForDOM):
3465         (WebPlatformStrategies::setCookiesFromDOM):
3466         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3467         (WebPlatformStrategies::getRawCookies):
3468
3469 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
3470
3471         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
3472         https://bugs.webkit.org/show_bug.cgi?id=180689
3473
3474         Reviewed by Tim Horton.
3475