66af2f6848a390410994df9cff297e5d39502e7a
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-20  Antoine Quint  <graouts@apple.com>
2
3         Add a POINTER_EVENTS feature flag
4         https://bugs.webkit.org/show_bug.cgi?id=193577
5         <rdar://problem/47408511>
6
7         Unreviewed. Also enable Pointer Events for iosmac.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2019-01-19  Antoine Quint  <graouts@apple.com>
12
13         Add a POINTER_EVENTS feature flag
14         https://bugs.webkit.org/show_bug.cgi?id=193577
15
16         Reviewed by Dean Jackson.
17
18         * Configurations/FeatureDefines.xcconfig:
19
20 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
21
22         Revert r238815, it broke WK1 video fullscreen on Mac
23         https://bugs.webkit.org/show_bug.cgi?id=193586
24         <rdar://problem/47358941>
25
26         Reviewed by Jer Noble.
27
28         * WebView/WebVideoFullscreenController.h: Added.
29         * WebView/WebVideoFullscreenController.mm: Added.
30         (SOFT_LINK_CLASS):
31         (-[WebVideoFullscreenController init]):
32         (-[WebVideoFullscreenController dealloc]):
33         (-[WebVideoFullscreenController fullscreenWindow]):
34         (-[WebVideoFullscreenController windowDidLoad]):
35         (-[WebVideoFullscreenController videoElement]):
36         (-[WebVideoFullscreenController setVideoElement:]):
37         (-[WebVideoFullscreenController clearFadeAnimation]):
38         (-[WebVideoFullscreenController windowDidExitFullscreen]):
39         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
40         (-[WebVideoFullscreenController videoElementRect]):
41         (-[WebVideoFullscreenController applicationDidResignActive:]):
42         (frameExpandedToRatioOfFrame):
43         (createBackgroundFullscreenWindow):
44         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
45         (-[WebVideoFullscreenController enterFullscreen:]):
46         (-[WebVideoFullscreenController exitFullscreen]):
47         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
48         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
49         (-[WebVideoFullscreenController _requestExit]):
50         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
51         (-[WebVideoFullscreenController requestExitFullscreen]):
52         (-[WebVideoFullscreenController fadeHUDIn]):
53         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
54         (-[WebVideoFullscreenController rateChanged:]):
55         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
56         (-[WebVideoFullscreenWindow dealloc]):
57         (-[WebVideoFullscreenWindow resignFirstResponder]):
58         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
59         (-[WebVideoFullscreenWindow mouseDown:]):
60         (-[WebVideoFullscreenWindow cancelOperation:]):
61         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
62         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
63         (-[WebVideoFullscreenWindow animationDidEnd:]):
64         (-[WebVideoFullscreenWindow mouseMoved:]):
65         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
66         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
67         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
68         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
69         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
70         (-[WebVideoFullscreenHUDWindow center]):
71         (-[WebVideoFullscreenHUDWindow keyDown:]):
72         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
73         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
74         (-[WebVideoFullscreenHUDWindowController init]):
75         (-[WebVideoFullscreenHUDWindowController dealloc]):
76         (-[WebVideoFullscreenHUDWindowController setArea:]):
77         (-[WebVideoFullscreenHUDWindowController keyDown:]):
78         (-[WebVideoFullscreenHUDWindowController delegate]):
79         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
80         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
81         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
82         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
83         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
84         (-[WebVideoFullscreenHUDWindowController closeWindow]):
85         (createMediaUIControl):
86         (createControlWithMediaUIControlType):
87         (createTimeTextField):
88         (createMediaUIBackgroundView):
89         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
90         (-[WebVideoFullscreenHUDWindowController updateVolume]):
91         (-[WebVideoFullscreenHUDWindowController updateTime]):
92         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
93         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
94         (-[WebVideoFullscreenHUDWindowController currentTime]):
95         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
96         (-[WebVideoFullscreenHUDWindowController duration]):
97         (-[WebVideoFullscreenHUDWindowController maxVolume]):
98         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
99         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
100         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
101         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
102         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
103         (-[WebVideoFullscreenHUDWindowController volume]):
104         (-[WebVideoFullscreenHUDWindowController setVolume:]):
105         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
106         (-[WebVideoFullscreenHUDWindowController updateRate]):
107         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
108         (-[WebVideoFullscreenHUDWindowController playing]):
109         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
110         (timeToString):
111         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
112         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
113         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
114         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
115         (-[WebVideoFullscreenHUDWindowController rewind:]):
116         (-[WebVideoFullscreenHUDWindowController fastForward:]):
117         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
118         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
119         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
120         * WebView/WebView.mm:
121         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
122         (-[WebView _exitVideoFullscreen]):
123
124 2019-01-18  Tim Horton  <timothy_horton@apple.com>
125
126         Get rid of ADVANCED_SPELL_CHECKING
127         https://bugs.webkit.org/show_bug.cgi?id=193592
128
129         Reviewed by Wenson Hsieh.
130
131         * WebCoreSupport/WebEditorClient.mm:
132         (insertionPointFromCurrentSelection):
133         (WebEditorClient::checkTextOfParagraph):
134         (WebEditorClient::getGuessesForWord):
135         (WebEditorClient::requestCandidatesForSelection):
136         (WebEditorClient::requestCheckingOfString):
137         * WebView/WebHTMLView.mm:
138         (-[WebHTMLView insertText:]):
139
140 2019-01-18  Jer Noble  <jer.noble@apple.com>
141
142         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
143         https://bugs.webkit.org/show_bug.cgi?id=189553
144
145         Reviewed by Tim Horton.
146
147         * Configurations/Base.xcconfig:
148         * Configurations/SDKVariant.xcconfig: Added.
149         * Configurations/WebKitLegacy.xcconfig:
150
151 2019-01-18  David Kilzer  <ddkilzer@apple.com>
152
153         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
154         <https://webkit.org/b/193568>
155         <rdar://problem/47381130>
156
157         Reviewed by Alex Christensen.
158
159         * WebView/WebView.mm:
160         - Remove unused soft-linking macros.
161         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
162         (-[WebUITextIndicatorData initWithImage:scale:]):
163         - Update to use exported PAL functions.
164
165 2019-01-17  Truitt Savell  <tsavell@apple.com>
166
167         Unreviewed, rolling out r240124.
168
169         This commit broke an internal build.
170
171         Reverted changeset:
172
173         "SDK_VARIANT build destinations should be separate from non-
174         SDK_VARIANT builds"
175         https://bugs.webkit.org/show_bug.cgi?id=189553
176         https://trac.webkit.org/changeset/240124
177
178 2019-01-17  Jer Noble  <jer.noble@apple.com>
179
180         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
181         https://bugs.webkit.org/show_bug.cgi?id=189553
182
183         Reviewed by Tim Horton.
184
185         * Configurations/Base.xcconfig:
186         * Configurations/SDKVariant.xcconfig: Added.
187         * Configurations/WebKitLegacy.xcconfig:
188
189 2019-01-17  Alex Christensen  <achristensen@webkit.org>
190
191         Stop using NetworkStorageSession::storageSession in WebCore
192         https://bugs.webkit.org/show_bug.cgi?id=193529
193
194         Reviewed by Tim Horton.
195
196         * Misc/WebCache.mm:
197         (+[WebCache addImageToCache:forURL:forFrame:]):
198         * WebView/WebView.mm:
199         (-[WebView _commonInitializationWithFrameName:groupName:]):
200         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
201
202 2019-01-15  Alex Christensen  <achristensen@webkit.org>
203
204         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
205         https://bugs.webkit.org/show_bug.cgi?id=193368
206
207         Reviewed by Geoff Garen.
208
209         * Misc/WebCache.mm:
210         (+[WebCache clearCachedCredentials]):
211         * Misc/WebDownload.mm:
212         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
213         * Plugins/WebBaseNetscapePluginView.mm:
214         (WebKit::getAuthenticationInfo):
215
216 2019-01-15  Alex Christensen  <achristensen@webkit.org>
217
218         Stop using CookiesStrategy
219         https://bugs.webkit.org/show_bug.cgi?id=161106
220
221         Reviewed by Don Olmstead and Antti Koivisto.
222
223         * Misc/WebCache.mm:
224         (+[WebCache addImageToCache:forURL:forFrame:]):
225         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
226         (WebKit::NetscapePluginInstanceProxy::getCookies):
227         (WebKit::NetscapePluginInstanceProxy::setCookies):
228         * Plugins/WebNetscapePluginView.mm:
229         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
230         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
231         * WebCoreSupport/WebPlatformStrategies.h:
232         * WebCoreSupport/WebPlatformStrategies.mm:
233         (WebPlatformStrategies::createCookiesStrategy): Deleted.
234         (WebPlatformStrategies::cookiesForDOM): Deleted.
235         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
236         (WebPlatformStrategies::cookiesEnabled): Deleted.
237         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
238         (WebPlatformStrategies::getRawCookies): Deleted.
239         (WebPlatformStrategies::deleteCookie): Deleted.
240         * WebView/WebView.mm:
241         (-[WebView _commonInitializationWithFrameName:groupName:]):
242         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
243
244 2019-01-15  Tim Horton  <timothy_horton@apple.com>
245
246         Cannot tab out of WKWebView on macOS
247         https://bugs.webkit.org/show_bug.cgi?id=161448
248         <rdar://problem/28100085>
249
250         Reviewed by Dean Jackson.
251
252         * WebCoreSupport/WebChromeClient.mm:
253         * WebView/WebView.mm:
254         Make use of SPI headers.
255
256 2019-01-14  Commit Queue  <commit-queue@webkit.org>
257
258         Unreviewed, rolling out r239901, r239909, r239910, r239912,
259         r239913, and r239914.
260         https://bugs.webkit.org/show_bug.cgi?id=193407
261
262         These revisions caused an internal failure (Requested by
263         Truitt on #webkit).
264
265         Reverted changesets:
266
267         "[Cocoa] Avoid importing directly from subumbrella frameworks"
268         https://bugs.webkit.org/show_bug.cgi?id=186016
269         https://trac.webkit.org/changeset/239901
270
271         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
272         https://trac.webkit.org/changeset/239909
273
274         "Tried to fix the build."
275         https://trac.webkit.org/changeset/239910
276
277         "Fixed iOS builds after r239910."
278         https://trac.webkit.org/changeset/239912
279
280         "More build fixing."
281         https://trac.webkit.org/changeset/239913
282
283         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
284         https://trac.webkit.org/changeset/239914
285
286 2019-01-14  Mark Lam  <mark.lam@apple.com>
287
288         Re-enable ability to build --cloop builds.
289         https://bugs.webkit.org/show_bug.cgi?id=192955
290         <rdar://problem/46882363>
291
292         Reviewed by Saam barati and Keith Miller.
293
294         * Configurations/FeatureDefines.xcconfig:
295
296 2019-01-13  Dan Bernstein  <mitz@apple.com>
297
298         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
299
300         Patch by Keith Rollin.
301
302         * WebView/PDFViewSPI.h:
303
304 2019-01-12  Timothy Hatcher  <timothy@apple.com>
305
306         Have prefers-color-scheme: light always match on macOS versions before Mojave.
307         https://bugs.webkit.org/show_bug.cgi?id=191655
308         rdar://problem/46074680
309
310         Reviewed by Megan Gardner.
311
312         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
313         * WebView/WebView.mm:
314         (-[WebView _effectiveAppearanceIsDark]):
315
316 2019-01-12  Dan Bernstein  <mitz@apple.com>
317
318         [Cocoa] Avoid importing directly from subumbrella frameworks
319         https://bugs.webkit.org/show_bug.cgi?id=186016
320         <rdar://problem/40591038>
321
322         Reviewed by Sam Weinig.
323
324         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
325         * Carbon/CarbonWindowAdapter.mm: Ditto.
326         * Carbon/CarbonWindowFrame.m: Ditto.
327         * Carbon/HIViewAdapter.h: Ditto.
328         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
329           OTHER_CFLAGS_COCOA_TOUCH_NO.
330         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
331         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
332         * WebView/WebPDFView.h: Ditto.
333
334 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
335
336         Enable visual viewport API by default
337         https://bugs.webkit.org/show_bug.cgi?id=193376
338
339         Reviewed by Simon Fraser.
340
341         * WebView/WebPreferences.mm:
342         (+[WebPreferences initialize]):
343
344 2019-01-11  John Wilander  <wilander@apple.com>
345
346         Compile out Web API Statistics Collection
347         https://bugs.webkit.org/show_bug.cgi?id=193370
348         <rdar://problem/45388584>
349
350         Reviewed by Brent Fulgham.
351
352         * Configurations/FeatureDefines.xcconfig:
353             Defined ENABLE_WEB_API_STATISTICS, off by default.
354
355 2019-01-08  Alex Christensen  <achristensen@webkit.org>
356
357         Stop using NetworkStorageSession in WebProcess
358         https://bugs.webkit.org/show_bug.cgi?id=193236
359
360         Reviewed by Don Olmstead.
361
362         * WebCoreSupport/WebFrameNetworkingContext.h:
363         * WebCoreSupport/WebFrameNetworkingContext.mm:
364         (WebFrameNetworkingContext::storageSession const):
365         * WebCoreSupport/WebPlatformStrategies.h:
366         * WebCoreSupport/WebPlatformStrategies.mm:
367         (WebPlatformStrategies::cookiesForDOM):
368         (WebPlatformStrategies::setCookiesFromDOM):
369         (WebPlatformStrategies::cookiesEnabled):
370         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
371         (WebPlatformStrategies::getRawCookies):
372         (WebPlatformStrategies::deleteCookie):
373         * WebView/WebView.mm:
374         (-[WebView _cachedResponseForURL:]):
375         (-[WebView _clearCredentials]):
376
377 2019-01-08  Alex Christensen  <achristensen@webkit.org>
378
379         Unreviewed, rolling out r239727.
380
381         Broke API tests
382
383         Reverted changeset:
384
385         "Stop using NetworkStorageSession in WebProcess"
386         https://bugs.webkit.org/show_bug.cgi?id=193236
387         https://trac.webkit.org/changeset/239727
388
389 2019-01-08  Alex Christensen  <achristensen@webkit.org>
390
391         Stop using NetworkStorageSession in WebProcess
392         https://bugs.webkit.org/show_bug.cgi?id=193236
393
394         Reviewed by Don Olmstead.
395
396         * WebCoreSupport/WebFrameNetworkingContext.h:
397         * WebCoreSupport/WebFrameNetworkingContext.mm:
398         (WebFrameNetworkingContext::storageSession const):
399         * WebView/WebView.mm:
400         (-[WebView _cachedResponseForURL:]):
401         (-[WebView _clearCredentials]):
402
403 2019-01-07  David Kilzer  <ddkilzer@apple.com>
404
405         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
406         <https://webkit.org/b/193056>
407
408         Reviewed by Alex Christensen.
409
410         * Plugins/Hosted/NetscapePluginHostProxy.h:
411         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
412         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
413         (WebKit::NetscapePluginInstanceProxy::enumerate):
414         (WebKit::NetscapePluginInstanceProxy::marshalValue):
415         (WebKit::NetscapePluginInstanceProxy::marshalValues):
416         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
417         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
418         * Plugins/Hosted/ProxyInstance.mm:
419         (WebKit::ProxyInstance::invoke):
420         * WebCoreSupport/WebGeolocationClient.mm:
421         * WebView/WebDataSource.mm:
422         (-[WebDataSource _receivedData:]):
423         * WebView/WebView.mm:
424         (-[WebView _cachedResponseForURL:]):
425         - Remove '*' from RetainPtr<> type.
426
427 2019-01-04  Alex Christensen  <achristensen@webkit.org>
428
429         Progress towards fixing Mac CMake build
430         https://bugs.webkit.org/show_bug.cgi?id=193105
431
432         Reviewed by Don Olmstead.
433
434         * WebKitPrefix.h:
435
436 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
437
438         Web Inspector: Use save sheet instead of dialog where possible
439         https://bugs.webkit.org/show_bug.cgi?id=193160
440         <rdar://problem/37399759>
441
442         Reviewed by Devin Rousso.
443
444         * WebCoreSupport/WebInspectorClient.mm:
445         (WebInspectorFrontendClient::save):
446
447 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
450         https://bugs.webkit.org/show_bug.cgi?id=193129
451
452         Reviewed by Tim Horton.
453
454         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
455
456         * WebCoreSupport/WebEditorClient.mm:
457         (WebEditorClient::registerUndoOrRedoStep):
458         (undoNameForEditAction): Deleted.
459
460 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
461
462         Add support for using the current text selection as the find string on iOS
463         https://bugs.webkit.org/show_bug.cgi?id=193034
464         <rdar://problem/45138739>
465
466         Reviewed by Tim Horton.
467
468         Add a method stub for WebKitLegacy.
469
470         * WebCoreSupport/WebEditorClient.h:
471
472 2019-01-01  Jeff Miller  <jeffm@apple.com>
473
474         Update user-visible copyright strings to include 2019
475         https://bugs.webkit.org/show_bug.cgi?id=192811
476
477         Reviewed by Mark Lam.
478
479         * Info.plist:
480
481 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
482
483         Use Ref<> as much as possible
484         https://bugs.webkit.org/show_bug.cgi?id=192808
485
486         Reviewed by Alex Christensen.
487
488         * DOM/DOM.mm:
489         (-[DOMNode getPreviewSnapshotImage:andRects:]):
490         * Plugins/Hosted/NetscapePluginHostManager.mm:
491         (WebKit::NetscapePluginHostManager::instantiatePlugin):
492         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
493         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
494         (WebKit::NetscapePluginInstanceProxy::loadRequest):
495         * Plugins/WebNetscapePluginView.mm:
496         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
497         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
498         * WebCoreSupport/WebContextMenuClient.mm:
499         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
500         * WebCoreSupport/WebFrameLoaderClient.mm:
501         (WebFrameLoaderClient::transitionToCommittedForNewPage):
502         * WebView/WebFrame.mm:
503         (-[WebFrame getDictationResultRanges:andMetadatas:]):
504         * WebView/WebHTMLView.mm:
505         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
506         * WebView/WebView.mm:
507         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
508         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
509
510 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
511
512         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
513         https://bugs.webkit.org/show_bug.cgi?id=192821
514
515         Reviewed by Chris Dumez.
516
517         When a window becomes occluded, the window server informs the application.
518         This should be used to suspend any work that is not visible by the user.
519
520         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
521         In some cases, that lead to performance impact (see radar).
522
523         This patch adds an observer for the occlusion notification. I tried to stick
524         with the same names used by WebKit2.
525
526         * WebView/WebView.mm:
527         (-[WebView _isViewVisible]):
528         (-[WebView addWindowObserversForWindow:]):
529         (-[WebView removeWindowObservers]):
530         (-[WebView _windowDidChangeOcclusionState:]):
531
532 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
533
534         [WebAuthN] Add a runtime flag for local authenticator
535         https://bugs.webkit.org/show_bug.cgi?id=192792
536         <rdar://problem/46798738>
537
538         Reviewed by Brent Fulgham.
539
540         * WebView/WebPreferenceKeysPrivate.h:
541         * WebView/WebPreferences.mm:
542         (+[WebPreferences initialize]):
543         (-[WebPreferences webAuthenticationEnabled]): Deleted.
544         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
545         * WebView/WebPreferencesPrivate.h:
546         * WebView/WebView.mm:
547         (-[WebView _preferencesChanged:]):
548
549 2018-12-20  Chris Dumez  <cdumez@apple.com>
550
551         Use Optional::valueOr() instead of Optional::value_or()
552         https://bugs.webkit.org/show_bug.cgi?id=192933
553
554         Reviewed by Geoffrey Garen.
555
556         * WebCoreSupport/WebSecurityOrigin.mm:
557         (-[WebSecurityOrigin port]):
558
559 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
560
561         Unreviewed, rolling out r239417.
562
563         Introduced two API test failures on macOS.
564
565         Reverted changeset:
566
567         "<rdar://problem/46194315> macOS: WebKit1 does not handle
568         occlusion changes"
569         https://bugs.webkit.org/show_bug.cgi?id=192821
570         https://trac.webkit.org/changeset/239417
571
572 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
573
574         WKWebView default UA doesn't freeze the build number
575         https://bugs.webkit.org/show_bug.cgi?id=192809
576         <rdar://problem/44687185>
577
578         Reviewed by Andy Estes.
579
580         Always reports the frozen build number.
581
582         * WebView/WebView.mm:
583         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
584         actual build number through this method call.
585         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
586
587 2018-12-19  Chris Dumez  <cdumez@apple.com>
588
589         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
590         https://bugs.webkit.org/show_bug.cgi?id=192728
591         <rdar://problem/46746779>
592
593         Reviewed by Geoff Garen.
594
595         * DOM/*:
596         * Plugins/*:
597         * WebCoreSupport/*:
598         * WebView/*:
599
600 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
601
602         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
603         https://bugs.webkit.org/show_bug.cgi?id=192821
604
605         Reviewed by Chris Dumez.
606
607         When a window becomes occluded, the window server informs the application.
608         This should be used to suspend any work that is not visible by the user.
609
610         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
611         In some cases, that lead to performance impact (see radar).
612
613         This patch adds an observer for the occlusion notification. I tried to stick
614         with the same names used by WebKit2.
615
616         * WebView/WebView.mm:
617         (-[WebView _isViewVisible]):
618         (-[WebView addWindowObserversForWindow:]):
619         (-[WebView removeWindowObservers]):
620         (-[WebView _windowDidChangeOcclusionState:]):
621
622 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
623
624         Allow clients to set the navigator platform
625         https://bugs.webkit.org/show_bug.cgi?id=192735
626
627         Reviewed by Tim Horton.
628
629         Add stubs to fill out the added functionality in FrameLoaderClient.
630
631         * WebCoreSupport/WebFrameLoaderClient.h:
632         * WebCoreSupport/WebFrameLoaderClient.mm:
633         (WebFrameLoaderClient::navigatorPlatform):
634
635 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
636
637         offsetLeft and offsetParent should adjust across shadow boundaries
638         https://bugs.webkit.org/show_bug.cgi?id=157437
639         <rdar://problem/26154021>
640
641         Reviewed by Simon Fraser.
642
643         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
644
645         * DOM/DOMElement.mm:
646         (-[DOMElement offsetLeft]):
647         (-[DOMElement offsetTop]):
648         (-[DOMElement offsetParent]):
649
650 2018-12-17  Zalan Bujtas  <zalan@apple.com>
651
652         Unreviewed build fix.
653
654         * WebView/WebFrame.mm:
655         (-[WebFrame getDictationResultRanges:andMetadatas:]):
656
657 2018-12-15  Darin Adler  <darin@apple.com>
658
659         Use warning-ignoring macros more consistently and simply
660         https://bugs.webkit.org/show_bug.cgi?id=192743
661
662         Reviewed by Mark Lam.
663
664         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
665         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
666         compilers in Objective-C++ code.
667
668         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
669         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
670         accomodate non-clang compilers here. Also use #pragma once, add a missing
671         "explicit" and fix conditionals.
672
673 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
674
675         Make TextInputController.legacyAttributedString take DOM nodes and offsets
676         https://bugs.webkit.org/show_bug.cgi?id=192653
677
678         Reviewed by Wenson Hsieh.
679
680         * WebView/WebHTMLView.mm:
681         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
682
683 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
684
685         Implement feature flag for CSS Typed OM
686         https://bugs.webkit.org/show_bug.cgi?id=192610
687
688         Reviewed by Ryosuke Niwa.
689
690         * Configurations/FeatureDefines.xcconfig:
691
692 2018-12-11  Tim Horton  <timothy_horton@apple.com>
693
694         WebCore shouldn't have a Objective-C class named NSCursor
695         https://bugs.webkit.org/show_bug.cgi?id=192602
696         <rdar://problem/46615532>
697
698         Reviewed by Wenson Hsieh.
699
700         * WebView/WebFrameView.mm:
701         (-[WebFrameView keyDown:keyDown:]):
702         * WebView/WebHTMLView.mm:
703         (-[WebHTMLView keyDown:]):
704         (-[WebHTMLView performKeyEquivalent:]):
705         Only use NSCursor on macOS.
706
707 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
708
709         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
710         https://bugs.webkit.org/show_bug.cgi?id=192573
711
712         Reviewed by Simon Fraser.
713
714         * Configurations/FeatureDefines.xcconfig:
715
716 2018-12-10  Antti Koivisto  <antti@apple.com>
717
718         Rename "forced style recalc" to "full style rebuild"
719         https://bugs.webkit.org/show_bug.cgi?id=192572
720
721         Reviewed by Zalan Bujtas.
722
723         * WebView/WebHTMLView.mm:
724         (-[WebHTMLView setNeedsToApplyStyles:]):
725
726 2018-12-10  Darin Adler  <darin@apple.com>
727
728         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
729         https://bugs.webkit.org/show_bug.cgi?id=192533
730         rdar://problem/45732710
731
732         Reviewed by Anders Carlsson.
733
734         * Plugins/Hosted/NetscapePluginHostProxy.mm:
735         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
736
737 2018-12-10  Darin Adler  <darin@apple.com>
738
739         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
740         https://bugs.webkit.org/show_bug.cgi?id=192532
741         rdar://problem/45731047
742
743         Reviewed by Chris Dumez.
744
745         * Plugins/Hosted/NetscapePluginHostManager.mm:
746         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
747         * Plugins/Hosted/NetscapePluginHostProxy.mm:
748         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
749
750 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
751
752         Turn WritingDirection into an enum class
753         https://bugs.webkit.org/show_bug.cgi?id=192401
754         Work towards <rdar://problem/42075638>
755
756         Reviewed by Dan Bernstein.
757
758         Change WritingDirection from an enum to an enum class. No change in behavior.
759
760         * WebView/WebHTMLView.mm:
761         (-[WebHTMLView toggleBaseWritingDirection:]):
762         (-[WebHTMLView changeBaseWritingDirection:]):
763         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
764
765 2018-12-03  Alex Christensen  <achristensen@webkit.org>
766
767         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
768         https://bugs.webkit.org/show_bug.cgi?id=192272
769
770         Reviewed by Brady Eidson.
771
772         * WebCoreSupport/WebFrameLoaderClient.h:
773         * WebCoreSupport/WebFrameLoaderClient.mm:
774         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
775
776 2018-12-03  Jer Noble  <jer.noble@apple.com>
777
778         Get rid of old, dead Mac video fullscreen code.
779         https://bugs.webkit.org/show_bug.cgi?id=192315
780
781         Reviewed by Eric Carlson.
782
783         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
784         is no longer supported in the Mac port.
785
786         * WebView/WebVideoFullscreenController.h: Removed.
787         * WebView/WebVideoFullscreenController.mm: Removed.
788         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
789         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
790         * WebView/WebView.mm:
791         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
792         (-[WebView _exitVideoFullscreen]):
793
794 2018-12-03  Daniel Bates  <dabates@apple.com>
795
796         [iOS] Do not handle key events that are key commands
797         https://bugs.webkit.org/show_bug.cgi?id=191608
798         <rdar://problem/46046013>
799
800         Reviewed by Ryosuke Niwa.
801
802         A key down event may be associated with a key command. If it is then we want to execute the
803         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
804         event as a key command to find out.
805
806         * WebView/WebHTMLView.mm:
807         (-[WebHTMLView _handleEditingKeyEvent:]):
808
809 2018-12-02  Zalan Bujtas  <zalan@apple.com>
810
811         Add a runtime feature flag for LayoutFormattingContext.
812         https://bugs.webkit.org/show_bug.cgi?id=192280
813
814         Reviewed by Simon Fraser.
815
816         * Configurations/FeatureDefines.xcconfig:
817
818 2018-11-30  Alex Christensen  <achristensen@webkit.org>
819
820         Move URL from WebCore to WTF
821         https://bugs.webkit.org/show_bug.cgi?id=190234
822
823         Reviewed by Keith Miller.
824
825         * DOM/DOMAttr.mm:
826         * DOM/DOMBlob.mm:
827         * DOM/DOMCSSCharsetRule.mm:
828         * DOM/DOMCSSImportRule.mm:
829         * DOM/DOMCSSMediaRule.mm:
830         * DOM/DOMCSSPageRule.mm:
831         * DOM/DOMCSSPrimitiveValue.mm:
832         * DOM/DOMCSSRule.mm:
833         * DOM/DOMCSSStyleDeclaration.mm:
834         * DOM/DOMCSSStyleRule.mm:
835         * DOM/DOMCSSStyleSheet.mm:
836         * DOM/DOMCSSValue.mm:
837         * DOM/DOMCharacterData.mm:
838         * DOM/DOMCounter.mm:
839         * DOM/DOMDocument.mm:
840         * DOM/DOMDocumentFragment.mm:
841         * DOM/DOMDocumentType.mm:
842         * DOM/DOMEvent.mm:
843         * DOM/DOMFile.mm:
844         * DOM/DOMHTMLAnchorElement.mm:
845         * DOM/DOMHTMLAppletElement.mm:
846         * DOM/DOMHTMLAreaElement.mm:
847         * DOM/DOMHTMLBRElement.mm:
848         * DOM/DOMHTMLBaseElement.mm:
849         * DOM/DOMHTMLBaseFontElement.mm:
850         * DOM/DOMHTMLBodyElement.mm:
851         * DOM/DOMHTMLButtonElement.mm:
852         * DOM/DOMHTMLCanvasElement.mm:
853         * DOM/DOMHTMLCollection.mm:
854         * DOM/DOMHTMLDivElement.mm:
855         * DOM/DOMHTMLDocument.mm:
856         * DOM/DOMHTMLElement.mm:
857         * DOM/DOMHTMLEmbedElement.mm:
858         * DOM/DOMHTMLFieldSetElement.mm:
859         * DOM/DOMHTMLFontElement.mm:
860         * DOM/DOMHTMLFormElement.mm:
861         * DOM/DOMHTMLFrameElement.mm:
862         * DOM/DOMHTMLFrameSetElement.mm:
863         * DOM/DOMHTMLHRElement.mm:
864         * DOM/DOMHTMLHeadElement.mm:
865         * DOM/DOMHTMLHeadingElement.mm:
866         * DOM/DOMHTMLHtmlElement.mm:
867         * DOM/DOMHTMLIFrameElement.mm:
868         * DOM/DOMHTMLImageElement.mm:
869         * DOM/DOMHTMLInputElement.mm:
870         * DOM/DOMHTMLLIElement.mm:
871         * DOM/DOMHTMLLabelElement.mm:
872         * DOM/DOMHTMLLegendElement.mm:
873         * DOM/DOMHTMLLinkElement.mm:
874         * DOM/DOMHTMLMapElement.mm:
875         * DOM/DOMHTMLMarqueeElement.mm:
876         * DOM/DOMHTMLMediaElement.mm:
877         * DOM/DOMHTMLMetaElement.mm:
878         * DOM/DOMHTMLModElement.mm:
879         * DOM/DOMHTMLOListElement.mm:
880         * DOM/DOMHTMLObjectElement.mm:
881         * DOM/DOMHTMLOptGroupElement.mm:
882         * DOM/DOMHTMLOptionElement.mm:
883         * DOM/DOMHTMLOptionsCollection.mm:
884         * DOM/DOMHTMLParagraphElement.mm:
885         * DOM/DOMHTMLParamElement.mm:
886         * DOM/DOMHTMLQuoteElement.mm:
887         * DOM/DOMHTMLScriptElement.mm:
888         * DOM/DOMHTMLSelectElement.mm:
889         * DOM/DOMHTMLStyleElement.mm:
890         * DOM/DOMHTMLTableCaptionElement.mm:
891         * DOM/DOMHTMLTableCellElement.mm:
892         * DOM/DOMHTMLTableColElement.mm:
893         * DOM/DOMHTMLTableElement.mm:
894         * DOM/DOMHTMLTableRowElement.mm:
895         * DOM/DOMHTMLTableSectionElement.mm:
896         * DOM/DOMHTMLTitleElement.mm:
897         * DOM/DOMHTMLUListElement.mm:
898         * DOM/DOMHTMLVideoElement.mm:
899         * DOM/DOMKeyboardEvent.mm:
900         * DOM/DOMMediaList.mm:
901         * DOM/DOMMouseEvent.mm:
902         * DOM/DOMMutationEvent.mm:
903         * DOM/DOMNamedNodeMap.mm:
904         * DOM/DOMProcessingInstruction.mm:
905         * DOM/DOMRange.mm:
906         * DOM/DOMStyleSheet.mm:
907         * DOM/DOMText.mm:
908         * DOM/DOMTextEvent.mm:
909         * DOM/DOMTokenList.mm:
910         * DOM/DOMUIEvent.mm:
911         * DOM/DOMXPathResult.mm:
912         * History/WebHistoryItem.mm:
913         * Misc/WebNSURLExtras.mm:
914         (-[NSURL _web_userVisibleString]):
915         (-[NSURL _web_URLByRemovingUserInfo]):
916         (-[NSURL _web_dataForURLComponentType:]):
917         (-[NSURL _web_schemeData]):
918         (-[NSURL _web_hostData]):
919         * Misc/WebUserContentURLPattern.mm:
920         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
921         * Plugins/WebNetscapePluginStream.h:
922         (WebNetscapePluginStream::setRequestURL):
923         * WebCoreSupport/WebChromeClient.h:
924         * WebCoreSupport/WebChromeClient.mm:
925         (WebChromeClient::signedPublicKeyAndChallengeString const):
926         * WebCoreSupport/WebContextMenuClient.h:
927         * WebCoreSupport/WebContextMenuClient.mm:
928         * WebCoreSupport/WebDragClient.h:
929         * WebCoreSupport/WebFrameLoaderClient.h:
930         * WebCoreSupport/WebFrameLoaderClient.mm:
931         (WebFrameLoaderClient::updateGlobalHistory):
932         * WebCoreSupport/WebPaymentCoordinatorClient.h:
933         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
934         (WebPaymentCoordinatorClient::showPaymentUI):
935         * WebCoreSupport/WebPlatformStrategies.h:
936         * WebCoreSupport/WebPlatformStrategies.mm:
937         (WebPlatformStrategies::readURLFromPasteboard):
938         * WebCoreSupport/WebPluginInfoProvider.h:
939         * WebCoreSupport/WebPluginInfoProvider.mm:
940         (WebPluginInfoProvider::webVisiblePluginInfo):
941         * WebCoreSupport/WebSecurityOrigin.mm:
942         * WebCoreSupport/WebVisitedLinkStore.h:
943         * WebView/WebDataSource.mm:
944         * WebView/WebFrame.mm:
945         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
946         * WebView/WebImmediateActionController.mm:
947         (-[WebImmediateActionController _defaultAnimationController]):
948         * WebView/WebPDFView.mm:
949         * WebView/WebScriptDebugger.mm:
950         * WebView/WebViewInternal.h:
951
952 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
953
954         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
955         https://bugs.webkit.org/show_bug.cgi?id=192197
956
957         Reviewed by Jiewen Tan.
958
959         * Configurations/FeatureDefines.xcconfig:
960         * WebCoreSupport/WebChromeClient.h:
961         * WebCoreSupport/WebChromeClient.mm:
962
963 2018-11-28  Alex Christensen  <achristensen@webkit.org>
964
965         Remove dead code from an earlier attempt at implementing safe browsing
966         https://bugs.webkit.org/show_bug.cgi?id=192067
967
968         Reviewed by Chris Dumez.
969
970         * WebCoreSupport/WebFrameLoaderClient.h:
971         * WebCoreSupport/WebFrameLoaderClient.mm:
972         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
973
974 2018-11-27  Mark Lam  <mark.lam@apple.com>
975
976         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
977         https://bugs.webkit.org/show_bug.cgi?id=192055
978         <rdar://problem/46288783>
979
980         Reviewed by Saam Barati.
981
982         * Configurations/FeatureDefines.xcconfig:
983
984 2018-11-25  Tim Horton  <timothy_horton@apple.com>
985
986         Make it possible to insert editable images with a gesture
987         https://bugs.webkit.org/show_bug.cgi?id=191937
988
989         Reviewed by Wenson Hsieh.
990
991         * WebCoreSupport/WebEditorClient.mm:
992         (undoNameForEditAction):
993         Add a undo name.
994
995 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
996
997         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
998         https://bugs.webkit.org/show_bug.cgi?id=191945
999
1000         Reviewed by Anders Carlsson.
1001
1002         * WebCoreSupport/WebEditorClient.mm:
1003         (undoNameForEditAction):
1004
1005 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1006
1007         Enable drag and drop support for iOSMac
1008         https://bugs.webkit.org/show_bug.cgi?id=191818
1009         <rdar://problem/43907454>
1010
1011         Reviewed by Dean Jackson.
1012
1013         * Configurations/FeatureDefines.xcconfig:
1014
1015 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1016
1017         Address post-review feedback after r238438
1018         https://bugs.webkit.org/show_bug.cgi?id=191913
1019
1020         Reviewed by Ryosuke Niwa.
1021
1022         * WebView/WebFrame.mm:
1023         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1024         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1025         * WebView/WebView.mm:
1026         (-[WebView setSelectedDOMRange:affinity:]):
1027
1028 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1029
1030         Web Inspector: "Reload Web Inspector" button no longer partially works
1031         https://bugs.webkit.org/show_bug.cgi?id=191773
1032         <rdar://problem/46139932>
1033
1034         Reviewed by Devin Rousso.
1035
1036         * WebCoreSupport/WebInspectorClient.h:
1037         * WebCoreSupport/WebInspectorClient.mm:
1038         (WebInspectorFrontendClient::reopen):
1039
1040 2018-11-17  Devin Rousso  <drousso@apple.com>
1041
1042         Web Inspector: Network: add button to show system certificate dialog
1043         https://bugs.webkit.org/show_bug.cgi?id=191458
1044         <rdar://problem/45977019>
1045
1046         Reviewed by Joseph Pecoraro.
1047
1048         * WebCoreSupport/WebInspectorClient.h:
1049         * WebCoreSupport/WebInspectorClient.mm:
1050         (WebInspectorFrontendClient::showCertificate): Added.
1051
1052         * Configurations/WebKitLegacy.xcconfig:
1053
1054 2018-11-15  Truitt Savell  <tsavell@apple.com>
1055
1056         Unreviewed, rolling out r238244.
1057
1058         Caused High Sierra test runs to fail early with 50 crashes and
1059         casued 25 API failures.
1060
1061         Reverted changeset:
1062
1063         "[css-logical] Implement flow-relative margin, padding and
1064         border shorthands"
1065         https://bugs.webkit.org/show_bug.cgi?id=188697
1066         https://trac.webkit.org/changeset/238244
1067
1068 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1069
1070         [css-logical] Implement flow-relative margin, padding and border shorthands
1071         https://bugs.webkit.org/show_bug.cgi?id=188697
1072
1073         Reviewed by Simon Fraser and Antti Koivisto.
1074
1075         Add CSSLogicalEnabled runtime flag.
1076
1077         * WebView/WebPreferenceKeysPrivate.h:
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]):
1080         (-[WebPreferences cssLogicalEnabled]):
1081         (-[WebPreferences setCSSLogicalEnabled:]):
1082         * WebView/WebPreferencesPrivate.h:
1083         * WebView/WebView.mm:
1084         (-[WebView _preferencesChanged:]):
1085
1086 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1087
1088         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1089         https://bugs.webkit.org/show_bug.cgi?id=191612
1090
1091         Reviewed by Matt Baker.
1092
1093         * WebCoreSupport/WebInspectorClient.mm:
1094         (-[WebInspectorWindowController destroyInspectorView]):
1095
1096 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1097
1098         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1099         https://bugs.webkit.org/show_bug.cgi?id=191494
1100         <rdar://problem/45469854>
1101
1102         Reviewed by Devin Rousso.
1103
1104         * WebCoreSupport/WebInspectorClient.h:
1105         WebKitLegacy will still have remote inspection of the Page directly.
1106
1107 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1108
1109         Make compositing updates incremental
1110         https://bugs.webkit.org/show_bug.cgi?id=90342
1111
1112         Reviewed by Antti Koivisto.
1113
1114         Fix spelling error.
1115
1116         * WebView/WebView.mm:
1117         (-[WebView _setMediaLayer:forPluginView:]):
1118
1119 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1120
1121         Implement a new edit command to change the enclosing list type
1122         https://bugs.webkit.org/show_bug.cgi?id=191487
1123         <rdar://problem/45955922>
1124
1125         Reviewed by Ryosuke Niwa.
1126
1127         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1128
1129         * WebCoreSupport/WebEditorClient.mm:
1130         (undoNameForEditAction):
1131
1132 2018-11-11  Daniel Bates  <dabates@apple.com>
1133
1134         [iOS] Draw caps lock indicator in password fields
1135         https://bugs.webkit.org/show_bug.cgi?id=190565
1136         <rdar://problem/45262343>
1137
1138         Reviewed by Dean Jackson.
1139
1140         Update the caps lock state when a hardware keyboard is attached or detached.
1141
1142         * WebView/WebHTMLView.mm:
1143         (hardwareKeyboardAvailabilityChangedCallback): Added.
1144         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1145         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1146
1147 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1148
1149         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1150         https://bugs.webkit.org/show_bug.cgi?id=191492
1151
1152         Reviewed by Alex Christensen.
1153
1154         * Carbon/HIWebView.mm:
1155         * Misc/WebNSFileManagerExtras.mm:
1156         * Misc/WebNSURLExtras.mm:
1157         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1158         * Plugins/WebBasePluginPackage.mm:
1159         * Plugins/WebPluginContainerCheck.mm:
1160         * WebCoreSupport/WebCachedFramePlatformData.h:
1161         * WebCoreSupport/WebDeviceOrientationClient.mm:
1162         * WebView/WebDelegateImplementationCaching.mm:
1163         * WebView/WebHTMLView.mm:
1164         * WebView/WebPDFRepresentation.mm:
1165         * WebView/WebPolicyDelegate.mm:
1166         * WebView/WebView.mm:
1167
1168 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1169
1170         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1171         https://bugs.webkit.org/show_bug.cgi?id=191492
1172
1173         Reviewed by Alex Christensen.
1174
1175         * Carbon/HIWebView.mm:
1176         (UpdateCommandStatus):
1177         * Misc/WebNSFileManagerExtras.mm:
1178         * Misc/WebNSURLExtras.mm:
1179         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1180         * Plugins/WebBasePluginPackage.mm:
1181         * Plugins/WebPluginContainerCheck.mm:
1182         (-[WebPluginContainerCheck _continueWithPolicy:]):
1183         * WebCoreSupport/WebCachedFramePlatformData.h:
1184         (WebCachedFramePlatformData::clear):
1185         * WebCoreSupport/WebDeviceOrientationClient.mm:
1186         (WebDeviceOrientationClient::getProvider const):
1187         * WebView/WebDelegateImplementationCaching.mm:
1188         (CallDelegate):
1189         (CallDelegateReturningBoolean):
1190         (CallResourceLoadDelegateReturningBoolean):
1191         (CallFormDelegate):
1192         (CallFormDelegateReturningBoolean):
1193         * WebView/WebHTMLView.mm:
1194         * WebView/WebPDFRepresentation.mm:
1195         * WebView/WebPolicyDelegate.mm:
1196         (-[WebPolicyDecisionListener _usePolicy:]):
1197         * WebView/WebView.mm:
1198
1199 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1200
1201         Unreviewed, rolling out r238047.
1202
1203         Introduced layout test failures on iOS simulator.
1204
1205         Reverted changeset:
1206
1207         "[iOS] Draw caps lock indicator in password fields"
1208         https://bugs.webkit.org/show_bug.cgi?id=190565
1209         https://trac.webkit.org/changeset/238047
1210
1211 2018-11-09  Antti Koivisto  <antti@apple.com>
1212
1213         Use OptionSet for layout milestones
1214         https://bugs.webkit.org/show_bug.cgi?id=191470
1215
1216         Reviewed by Dean Jackson.
1217
1218         * WebCoreSupport/WebFrameLoaderClient.h:
1219         * WebCoreSupport/WebFrameLoaderClient.mm:
1220         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1221         * WebView/WebView.mm:
1222         (coreLayoutMilestones):
1223         (kitLayoutMilestones):
1224         (-[WebView _cacheFrameLoadDelegateImplementations]):
1225         * WebView/WebViewInternal.h:
1226
1227 2018-11-09  Daniel Bates  <dabates@apple.com>
1228
1229         [iOS] Draw caps lock indicator in password fields
1230         https://bugs.webkit.org/show_bug.cgi?id=190565
1231         <rdar://problem/45262343>
1232
1233         Reviewed by Dean Jackson.
1234
1235         Update the caps lock state when a hardware keyboard is attached or detached.
1236
1237         * WebView/WebHTMLView.mm:
1238         (hardwareKeyboardAvailabilityChangedCallback): Added.
1239         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1240         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1241
1242 2018-11-09  Daniel Bates  <dabates@apple.com>
1243
1244         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1245         action when forward delete is pressed outside a text field
1246         https://bugs.webkit.org/show_bug.cgi?id=190566
1247         <rdar://problem/45262367>
1248
1249         Reviewed by Wenson Hsieh.
1250
1251         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1252         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1253         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1254
1255         * WebView/WebHTMLView.mm:
1256         (-[WebHTMLView _handleEditingKeyEvent:]):
1257
1258 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1259
1260         Adopt Reveal Framework to replace Lookup
1261         https://bugs.webkit.org/show_bug.cgi?id=191097
1262         <rdar://problem/45924508>
1263
1264         Reviewed by Tim Horton.
1265
1266         Pass in what it needed to clear the textIndicators. This is better than
1267         the current notification structure.
1268
1269         * WebView/WebView.mm:
1270         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1271         (-[WebView _prepareForDictionaryLookup]):
1272
1273 2018-11-06  Justin Fan  <justin_fan@apple.com>
1274
1275         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1276         https://bugs.webkit.org/show_bug.cgi?id=191291
1277
1278         Reviewed by Myles Maxfield.
1279
1280         Properly disable WEBGPU on all non-Metal platforms for now.
1281
1282         * Configurations/FeatureDefines.xcconfig:
1283
1284 2018-11-02  Daniel Bates  <dabates@apple.com>
1285
1286         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1287         https://bugs.webkit.org/show_bug.cgi?id=190487
1288
1289         Reviewed by Tim Horton.
1290
1291         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1292         allow the default handling.
1293
1294         * WebView/WebHTMLView.mm:
1295         (-[WebHTMLView _handleEditingKeyEvent:]):
1296
1297 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1298
1299         Add a storage limit for IndexedDB
1300         https://bugs.webkit.org/show_bug.cgi?id=190598
1301         <rdar://problem/44654715>
1302
1303         Reviewed by Chris Dumez.
1304
1305         * Storage/WebDatabaseManager.mm:
1306         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1307         * Storage/WebDatabaseManagerPrivate.h:
1308
1309 2018-10-31  Antti Koivisto  <antti@apple.com>
1310
1311         Remove LayerFlushScheduler
1312         https://bugs.webkit.org/show_bug.cgi?id=191103
1313
1314         Reviewed by Anders Carlsson.
1315
1316         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1317         all the virtual cruft.
1318
1319         * WebView/WebViewData.h:
1320         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1321         (): Deleted.
1322         * WebView/WebViewData.mm:
1323         (currentRunLoop):
1324         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1325         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1326         (WebViewLayerFlushScheduler::schedule):
1327         (WebViewLayerFlushScheduler::invalidate):
1328         (WebViewLayerFlushScheduler::layerFlushCallback):
1329
1330 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1331
1332         Enable InstallAPI for iOS unconditionally
1333         https://bugs.webkit.org/show_bug.cgi?id=191043
1334         rdar://problem/32728423
1335
1336         Reviewed by Dan Bernstein.
1337
1338         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1339         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1340         shouldn't be processed by InstallAPI.
1341         * MigrateHeaders.make: Removed an obsolete workaround.
1342         * Misc/NSURLDownloadSPI.h: Added.
1343         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1344
1345 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1346
1347         Clean up some obsolete MAX_ALLOWED macros
1348         https://bugs.webkit.org/show_bug.cgi?id=190916
1349
1350         Reviewed by Tim Horton.
1351
1352         * WebView/WebHTMLView.mm:
1353         (-[WebHTMLView pressureChangeWithEvent:]):
1354         * WebView/WebPDFView.h:
1355
1356 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1357
1358         Unreviewed, rolling out r237600 and r237604.
1359         https://bugs.webkit.org/show_bug.cgi?id=191086
1360
1361         Breaks internal iOS builds (Requested by ryanhadd_ on
1362         #webkit).
1363
1364         Reverted changesets:
1365
1366         "Enable InstallAPI for iOS unconditionally"
1367         https://bugs.webkit.org/show_bug.cgi?id=191043
1368         https://trac.webkit.org/changeset/237600
1369
1370         "Build fix attempt after enabling InstallAPI for iOS."
1371         https://bugs.webkit.org/show_bug.cgi?id=191043
1372         https://trac.webkit.org/changeset/237604
1373
1374 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1375
1376         Enable InstallAPI for iOS unconditionally
1377         https://bugs.webkit.org/show_bug.cgi?id=191043
1378         rdar://problem/32728423
1379
1380         Reviewed by Dan Bernstein.
1381
1382         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1383         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1384         shouldn't be processed by InstallAPI.
1385         * MigrateHeaders.make: Removed an obsolete workaround.
1386         * Misc/NSURLDownloadSPI.h: Added.
1387         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1388
1389 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1390
1391         Modernize WebKit nibs and lprojs for localization's sake
1392         https://bugs.webkit.org/show_bug.cgi?id=190911
1393         <rdar://problem/45349466>
1394
1395         Reviewed by Dan Bernstein.
1396
1397         * Misc/WebNSControlExtras.m:
1398         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1399         NSWindow and its contents are both in the same scale space these days; avoid
1400         double-applying the scale factor, or you can't see the prompt.
1401
1402         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1403         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1404         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1405         NIB->XIB
1406
1407 2018-10-25  Antoine Quint  <graouts@apple.com>
1408
1409         [Web Animations] Turn Web Animations CSS Integration off by default
1410         https://bugs.webkit.org/show_bug.cgi?id=190901
1411
1412         Reviewed by Dean Jackson.
1413
1414         * WebView/WebPreferences.mm:
1415         (+[WebPreferences initialize]):
1416
1417 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1418
1419         Clean up some obsolete macOS version guards
1420         https://bugs.webkit.org/show_bug.cgi?id=190887
1421
1422         Reviewed by Dan Bernstein.
1423
1424         * Misc/WebNSPasteboardExtras.mm:
1425         (+[NSPasteboard _web_dragTypesForURL]):
1426         * WebCoreSupport/PopupMenuMac.mm:
1427         (PopupMenuMac::show):
1428         * WebCoreSupport/WebEditorClient.h:
1429         * WebCoreSupport/WebEditorClient.mm:
1430         (WebEditorClient::respondToChangedSelection):
1431         * WebView/WebPDFView.mm:
1432         (-[WebPDFView _clipViewForPDFDocumentView]):
1433
1434 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1435
1436         Turn on Conic Gradients
1437         https://bugs.webkit.org/show_bug.cgi?id=190810
1438
1439         Reviewed by Tim Horton.
1440
1441         * Configurations/FeatureDefines.xcconfig:
1442
1443 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1444
1445         Cleanup: MIMETypeRegistry functions
1446         https://bugs.webkit.org/show_bug.cgi?id=190838
1447
1448         Reviewed by Simon Fraser.
1449
1450         * Misc/WebNSPasteboardExtras.mm:
1451         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1452         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1453         because they were identical.
1454
1455         * WebView/WebHTMLRepresentation.mm:
1456         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1457         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1458         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1459         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1460         * WebView/WebView.mm:
1461         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1462         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1463         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1464
1465 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1466
1467         Fix false positive leaks when using custom -init methods that don't start with -init
1468         <https://webkit.org/b/190818>
1469         <rdar://problem/45476042>
1470
1471         Reviewed by Dan Bernstein.
1472
1473         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1474         it is accessible by both categories.
1475         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1476         NSError (WebKitInternal) category.  Add attribute to make this
1477         behave like an -init method.
1478         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1479         NSError (WebKitInternal) category.  Modernize method.  Replace
1480         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1481
1482 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1483
1484         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1485         https://bugs.webkit.org/show_bug.cgi?id=190729
1486
1487         Reviewed by Tim Horton.
1488
1489         * DOM/DOM.mm:
1490         (-[DOMNode boundingBox]):
1491         * DOM/DOMElement.mm:
1492         * DOM/DOMHTML.mm:
1493         * DOM/DOMInternal.mm:
1494         * DOM/DOMUIKitExtensions.mm:
1495         * DOM/WebDOMOperations.mm:
1496         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1497         * DefaultDelegates/WebDefaultEditingDelegate.m:
1498         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1499         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1500         * DefaultDelegates/WebDefaultUIDelegate.h:
1501         * DefaultDelegates/WebDefaultUIDelegate.mm:
1502         (-[WebDefaultUIDelegate webViewClose:]):
1503         (-[WebDefaultUIDelegate webViewFocus:]):
1504         (-[WebDefaultUIDelegate webViewUnfocus:]):
1505         (-[WebDefaultUIDelegate webViewIsResizable:]):
1506         (-[WebDefaultUIDelegate webView:setResizable:]):
1507         (-[WebDefaultUIDelegate webView:setFrame:]):
1508         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1509         * History/BackForwardList.h:
1510         * History/BackForwardList.mm:
1511         * History/WebBackForwardList.mm:
1512         (+[WebBackForwardList initialize]):
1513         (bumperCarBackForwardHackNeeded):
1514         * History/WebHistory.mm:
1515         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1516         (-[WebHistory _sendNotification:entries:]):
1517         (-[WebHistory loadFromURL:error:]):
1518         (-[WebHistory saveToURL:error:]):
1519         * History/WebHistoryItem.mm:
1520         (WKNotifyHistoryItemChanged):
1521         (+[WebHistoryItem initialize]):
1522         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1523         * History/WebURLsWithTitles.m:
1524         * Misc/WebCache.mm:
1525         (+[WebCache initialize]):
1526         * Misc/WebDownload.mm:
1527         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1528         * Misc/WebElementDictionary.mm:
1529         (+[WebElementDictionary initialize]):
1530         (+[WebElementDictionary initializeLookupTable]):
1531         * Misc/WebIconDatabase.mm:
1532         * Misc/WebKitNSStringExtras.mm:
1533         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1534         * Misc/WebKitVersionChecks.h:
1535         * Misc/WebKitVersionChecks.mm:
1536         (WebKitLinkedOnOrAfter):
1537         (WebKitLinkTimeVersion):
1538         * Misc/WebLocalizableStrings.mm:
1539         * Misc/WebNSControlExtras.h:
1540         * Misc/WebNSControlExtras.m:
1541         * Misc/WebNSEventExtras.m:
1542         * Misc/WebNSFileManagerExtras.mm:
1543         * Misc/WebNSImageExtras.h:
1544         * Misc/WebNSImageExtras.m:
1545         * Misc/WebNSPasteboardExtras.mm:
1546         * Misc/WebNSPrintOperationExtras.h:
1547         * Misc/WebNSPrintOperationExtras.m:
1548         * Misc/WebNSViewExtras.m:
1549         * Misc/WebNSWindowExtras.m:
1550         * Panels/WebAuthenticationPanel.h:
1551         * Panels/WebAuthenticationPanel.m:
1552         * Panels/WebPanelAuthenticationHandler.m:
1553         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1554         (+[WebHostedNetscapePluginView initialize]):
1555         * Plugins/WebBasePluginPackage.h:
1556         * Plugins/WebBasePluginPackage.mm:
1557         * Plugins/WebJavaPlugIn.h:
1558         * Plugins/WebPluginContainerCheck.mm:
1559         * Plugins/WebPluginController.h:
1560         * Plugins/WebPluginController.mm:
1561         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1562         (-[WebPluginController addPlugin:]):
1563         (-[WebPluginController destroyPlugin:]):
1564         (-[WebPluginController destroyAllPlugins]):
1565         * Plugins/WebPluginDatabase.mm:
1566         (+[WebPluginDatabase _defaultPlugInPaths]):
1567         * Plugins/WebPluginPackage.mm:
1568         (-[WebPluginPackage initWithPath:]):
1569         * Storage/WebDatabaseManager.mm:
1570         (-[WebDatabaseManager deleteAllDatabases]):
1571         * Storage/WebDatabaseManagerClient.h:
1572         * Storage/WebDatabaseManagerClient.mm:
1573         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1574         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1575         * Storage/WebStorageManager.mm:
1576         (-[WebStorageManager deleteAllOrigins]):
1577         (WebKitInitializeStorageIfNecessary):
1578         * WebCoreSupport/WebAlternativeTextClient.h:
1579         * WebCoreSupport/WebApplicationCache.mm:
1580         (applicationCacheBundleIdentifier):
1581         * WebCoreSupport/WebChromeClient.h:
1582         * WebCoreSupport/WebChromeClient.mm:
1583         (WebChromeClient::setWindowRect):
1584         (WebChromeClient::windowRect):
1585         (WebChromeClient::takeFocus):
1586         (WebChromeClient::addMessageToConsole):
1587         (WebChromeClient::enableSuddenTermination):
1588         (WebChromeClient::disableSuddenTermination):
1589         (WebChromeClient::createPopupMenu const):
1590         (WebChromeClient::createSearchPopupMenu const):
1591         (WebChromeClient::shouldPaintEntireContents const):
1592         (WebChromeClient::supportsVideoFullscreen):
1593         (WebChromeClient::supportsFullScreenForElement):
1594         (WebChromeClient::enterFullScreenForElement):
1595         (WebChromeClient::exitFullScreenForElement):
1596         * WebCoreSupport/WebContextMenuClient.mm:
1597         * WebCoreSupport/WebDragClient.mm:
1598         * WebCoreSupport/WebEditorClient.h:
1599         * WebCoreSupport/WebEditorClient.mm:
1600         (+[WebUndoStep initialize]):
1601         (updateFontPanel):
1602         (WebEditorClient::didBeginEditing):
1603         (WebEditorClient::respondToChangedContents):
1604         (WebEditorClient::respondToChangedSelection):
1605         (WebEditorClient::canceledComposition):
1606         (WebEditorClient::didEndEditing):
1607         (WebEditorClient::didWriteSelectionToPasteboard):
1608         (attributesForAttributedStringConversion):
1609         (WebEditorClient::setInsertionPasteboard):
1610         (WebEditorClient::registerUndoOrRedoStep):
1611         (WebEditorClient::handleKeyboardEvent):
1612         (WebEditorClient::handleInputMethodKeydown):
1613         (WebEditorClient::textDidChangeInTextField):
1614         (WebEditorClient::requestCheckingOfString):
1615         * WebCoreSupport/WebFrameLoaderClient.h:
1616         * WebCoreSupport/WebFrameLoaderClient.mm:
1617         (WebFrameLoaderClient::detachedFromParent2):
1618         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1619         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1620         (WebFrameLoaderClient::dispatchWillSendRequest):
1621         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1622         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1623         (WebFrameLoaderClient::willCacheResponse const):
1624         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1625         (WebFrameLoaderClient::dispatchDidFinishLoading):
1626         (WebFrameLoaderClient::dispatchDidFailLoading):
1627         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1628         (WebFrameLoaderClient::dispatchWillClose):
1629         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1630         (WebFrameLoaderClient::dispatchDidCommitLoad):
1631         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1632         (WebFrameLoaderClient::dispatchDidFailLoad):
1633         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1634         (WebFrameLoaderClient::dispatchDidFinishLoad):
1635         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1636         (WebFrameLoaderClient::willChangeTitle):
1637         (WebFrameLoaderClient::didChangeTitle):
1638         (WebFrameLoaderClient::didReplaceMultipartContent):
1639         (WebFrameLoaderClient::updateGlobalHistory):
1640         (WebFrameLoaderClient::saveViewStateToItem):
1641         (WebFrameLoaderClient::restoreViewState):
1642         (WebFrameLoaderClient::provisionalLoadStarted):
1643         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1644         (WebFrameLoaderClient::setTitle):
1645         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1646         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1647         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1648         (WebFrameLoaderClient::didRestoreFromPageCache):
1649         (WebFrameLoaderClient::actionDictionary const):
1650         (WebFrameLoaderClient::createPlugin):
1651         (WebFrameLoaderClient::getLoadDecisionForIcons):
1652         (WebFrameLoaderClient::finishedLoadingIcon):
1653         (+[WebFramePolicyListener initialize]):
1654         * WebCoreSupport/WebFrameNetworkingContext.mm:
1655         * WebCoreSupport/WebGeolocationClient.h:
1656         * WebCoreSupport/WebGeolocationClient.mm:
1657         (WebGeolocationClient::requestPermission):
1658         * WebCoreSupport/WebInspectorClient.h:
1659         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1660         * WebCoreSupport/WebNotificationClient.mm:
1661         * WebCoreSupport/WebOpenPanelResultListener.mm:
1662         * WebCoreSupport/WebPlatformStrategies.h:
1663         * WebCoreSupport/WebPlatformStrategies.mm:
1664         * WebCoreSupport/WebProgressTrackerClient.h:
1665         * WebCoreSupport/WebProgressTrackerClient.mm:
1666         (WebProgressTrackerClient::progressStarted):
1667         (WebProgressTrackerClient::progressEstimateChanged):
1668         (WebProgressTrackerClient::progressFinished):
1669         * WebCoreSupport/WebSecurityOrigin.mm:
1670         * WebInspector/WebNodeHighlight.h:
1671         * WebInspector/WebNodeHighlight.mm:
1672         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1673         (-[WebNodeHighlight dealloc]):
1674         (-[WebNodeHighlight attach]):
1675         * WebInspector/WebNodeHighlightView.h:
1676         * WebInspector/WebNodeHighlightView.mm:
1677         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1678         (-[WebNodeHighlightView dealloc]):
1679         * WebInspector/WebNodeHighlighter.mm:
1680         (-[WebNodeHighlighter highlight]):
1681         * WebView/WebArchive.mm:
1682         (+[WebArchivePrivate initialize]):
1683         * WebView/WebClipView.h:
1684         * WebView/WebDataSource.mm:
1685         (WebDataSourcePrivate::WebDataSourcePrivate):
1686         (+[WebDataSource initialize]):
1687         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1688         (-[WebDataSource _makeRepresentation]):
1689         * WebView/WebDelegateImplementationCaching.h:
1690         * WebView/WebDelegateImplementationCaching.mm:
1691         (CallDelegate):
1692         (CallDelegateReturningFloat):
1693         (CallDelegateReturningBoolean):
1694         (CallUIDelegate):
1695         (CallUIDelegateReturningFloat):
1696         (CallUIDelegateReturningBoolean):
1697         (CallFrameLoadDelegate):
1698         (CallFrameLoadDelegateReturningBoolean):
1699         (CallResourceLoadDelegate):
1700         (CallScriptDebugDelegate):
1701         (CallFormDelegate):
1702         (CallFormDelegateReturningBoolean):
1703         * WebView/WebDeviceOrientation.mm:
1704         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1705         * WebView/WebDocumentInternal.h:
1706         * WebView/WebDocumentLoaderMac.mm:
1707         (needsDataLoadWorkaround):
1708         * WebView/WebDynamicScrollBarsViewInternal.h:
1709         * WebView/WebFormDelegate.m:
1710         * WebView/WebFrame.mm:
1711         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1712         (-[WebFrame _unmarkAllMisspellings]):
1713         (-[WebFrame _paintBehaviorForDestinationContext:]):
1714         (-[WebFrame _drawRect:contentsOnly:]):
1715         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1716         (-[WebFrame _scrollDOMRangeToVisible:]):
1717         (-[WebFrame _bodyBackgroundColor]):
1718         (-[WebFrame accessibilityRoot]):
1719         (needsMicrosoftMessengerDOMDocumentWorkaround):
1720         * WebView/WebFrameInternal.h:
1721         * WebView/WebFrameView.mm:
1722         (-[WebFrameView _setDocumentView:]):
1723         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1724         (-[WebFrameView _viewClassForMIMEType:]):
1725         (-[WebFrameView initWithFrame:]):
1726         (-[WebFrameView drawRect:]):
1727         (-[WebFrameView _firstResponderIsFormControl]):
1728         (-[WebFrameView keyDown:keyDown:]):
1729         (-[WebFrameView _isScrollable]):
1730         * WebView/WebFullScreenController.h:
1731         * WebView/WebFullScreenController.mm:
1732         * WebView/WebHTMLRepresentation.mm:
1733         * WebView/WebHTMLView.mm:
1734         (-[WebHTMLView hitTest:]):
1735         (-[WebHTMLView initWithFrame:]):
1736         (-[WebHTMLView dealloc]):
1737         (-[WebHTMLView addSubview:]):
1738         (-[WebHTMLView mouseDown:]):
1739         (-[WebHTMLView mouseUp:]):
1740         (-[WebHTMLView resignFirstResponder]):
1741         (-[WebHTMLView accessibilityHitTest:]):
1742         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1743         * WebView/WebHTMLViewInternal.h:
1744         * WebView/WebIndicateLayer.h:
1745         * WebView/WebIndicateLayer.mm:
1746         * WebView/WebMediaPlaybackTargetPicker.h:
1747         * WebView/WebMediaPlaybackTargetPicker.mm:
1748         * WebView/WebPDFDocumentExtras.h:
1749         * WebView/WebPDFDocumentExtras.mm:
1750         * WebView/WebPDFRepresentation.h:
1751         * WebView/WebPDFRepresentation.mm:
1752         * WebView/WebPDFView.h:
1753         * WebView/WebPreferences.mm:
1754         (cacheModelForMainBundle):
1755         (WebPreferencesPrivate::WebPreferencesPrivate):
1756         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1757         (-[WebPreferences encodeWithCoder:]):
1758         (+[WebPreferences standardPreferences]):
1759         (+[WebPreferences initialize]):
1760         (-[WebPreferences _valueForKey:]):
1761         (-[WebPreferences _setStringValue:forKey:]):
1762         (-[WebPreferences _setIntegerValue:forKey:]):
1763         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1764         (-[WebPreferences _setFloatValue:forKey:]):
1765         (-[WebPreferences _setBoolValue:forKey:]):
1766         (-[WebPreferences _setLongLongValue:forKey:]):
1767         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1768         (-[WebPreferences _postCacheModelChangedNotification]):
1769         (-[WebPreferences _postPreferencesChangedNotification]):
1770         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1771         (-[WebPreferences setStorageBlockingPolicy:]):
1772         * WebView/WebResource.mm:
1773         (+[WebResourcePrivate initialize]):
1774         * WebView/WebTextCompletionController.h:
1775         * WebView/WebTextIterator.mm:
1776         (+[WebTextIteratorPrivate initialize]):
1777         * WebView/WebView.mm:
1778         (shouldEnableLoadDeferring):
1779         (shouldRestrictWindowFocus):
1780         (shouldRespectPriorityInCSSAttributeSetters):
1781         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1782         (shouldAllowPictureInPictureMediaPlayback):
1783         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1784         (shouldAllowWindowOpenWithoutUserGesture):
1785         (shouldConvertInvalidURLsToBlank):
1786         (shouldRequireUserGestureToLoadVideo):
1787         (-[WebView _commonInitializationWithFrameName:groupName:]):
1788         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1789         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1790         (-[WebView _closePluginDatabases]):
1791         (-[WebView _closeWithFastTeardown]):
1792         (-[WebView _close]):
1793         (+[WebView _MIMETypeForFile:]):
1794         (-[WebView setShowingInspectorIndication:]):
1795         (-[WebView _setFormDelegate:]):
1796         (-[WebView _needsPreHTML5ParserQuirks]):
1797         (-[WebView _preferencesChangedNotification:]):
1798         (-[WebView _preferencesChanged:]):
1799         (-[WebView _cacheResourceLoadDelegateImplementations]):
1800         (-[WebView _cacheFrameLoadDelegateImplementations]):
1801         (-[WebView _policyDelegateForwarder]):
1802         (-[WebView _UIDelegateForwarder]):
1803         (-[WebView _editingDelegateForwarder]):
1804         (-[WebView _updateActiveState]):
1805         (-[_WebSafeForwarder forwardInvocation:]):
1806         (+[WebView initialize]):
1807         (-[WebView _pluginForMIMEType:]):
1808         (-[WebView _pluginForExtension:]):
1809         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1810         (+[WebView canShowMIMETypeAsHTML:]):
1811         (-[WebView _initWithArguments:]):
1812         (-[WebView initWithFrame:frameName:groupName:]):
1813         (-[WebView dealloc]):
1814         (-[WebView close]):
1815         (-[WebView viewDidMoveToWindow]):
1816         (-[WebView setUIDelegate:]):
1817         (-[WebView setResourceLoadDelegate:]):
1818         (-[WebView setPolicyDelegate:]):
1819         (-[WebView setFrameLoadDelegate:]):
1820         (-[WebView goBack]):
1821         (-[WebView goForward]):
1822         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1823         (-[WebView setHostWindow:]):
1824         (-[WebView becomeFirstResponder]):
1825         (+[WebView _cacheModelChangedNotification:]):
1826         (-[WebView _frameViewAtWindowPoint:]):
1827         (+[WebView _preflightSpellCheckerNow:]):
1828         (+[WebView _preflightSpellChecker]):
1829         (-[WebView canGoBack]):
1830         (-[WebView canGoForward]):
1831         (-[WebView stopLoading:]):
1832         (-[WebView reload:]):
1833         (-[WebView setMainFrameDocumentReady:]):
1834         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1835         (-[WebView setContinuousSpellCheckingEnabled:]):
1836         (-[WebView undoManager]):
1837         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1838         (-[WebView isAutomaticLinkDetectionEnabled]):
1839         (-[WebView isAutomaticDashSubstitutionEnabled]):
1840         (-[WebView isAutomaticTextReplacementEnabled]):
1841         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1842         (+[WebView _setCacheModel:]):
1843         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1844         (-[WebView _keyboardUIMode]):
1845         (LayerFlushController::flushLayers):
1846         (-[WebView _scheduleCompositingLayerFlush]):
1847         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1848         (-[WebView fullScreenPlaceholderView]):
1849         (WebInstallMemoryPressureHandler):
1850         * WebView/WebViewData.h:
1851         * WebView/WebViewData.mm:
1852         (+[WebViewPrivate initialize]):
1853         (-[WebViewPrivate init]):
1854         (-[WebViewPrivate dealloc]):
1855         * WebView/WebViewInternal.h:
1856
1857 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1858
1859         Clean up FrameLoader two-state enums
1860         https://bugs.webkit.org/show_bug.cgi?id=190731
1861
1862         Reviewed by Chris Dumez.
1863
1864         * WebCoreSupport/WebFrameLoaderClient.h:
1865         * WebCoreSupport/WebFrameLoaderClient.mm:
1866         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1867
1868 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1869
1870         Unreviewed, rolling out r237137.
1871
1872         SPI is actually used
1873
1874         Reverted changeset:
1875
1876         "Remove unused WebFrame._loadType"
1877         https://bugs.webkit.org/show_bug.cgi?id=190583
1878         https://trac.webkit.org/changeset/237137
1879
1880 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1881
1882         Enable the datalist element by default on iOS and macOS
1883         https://bugs.webkit.org/show_bug.cgi?id=190594
1884         <rdar://problem/45281159>
1885
1886         Reviewed by Ryosuke Niwa and Tim Horton.
1887
1888         * Configurations/FeatureDefines.xcconfig:
1889
1890 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1891
1892         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1893         https://bugs.webkit.org/show_bug.cgi?id=190675
1894
1895         Reviewed by Chris Dumez.
1896
1897         * History/BackForwardList.h:
1898         * History/BackForwardList.mm:
1899         (BackForwardList::backItem):
1900         (BackForwardList::currentItem):
1901         (BackForwardList::forwardItem):
1902         (BackForwardList::backListCount const):
1903         (BackForwardList::forwardListCount const):
1904         (BackForwardList::itemAtIndex):
1905         * History/WebBackForwardList.mm:
1906         (-[WebBackForwardList backItem]):
1907         (-[WebBackForwardList currentItem]):
1908         (-[WebBackForwardList forwardItem]):
1909         (-[WebBackForwardList itemAtIndex:]):
1910
1911 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1912
1913         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1914         https://bugs.webkit.org/show_bug.cgi?id=190526
1915         rdar://problem/45230140
1916
1917         Reviewed by Dean Jackson.
1918
1919         * WebCoreSupport/WebEditorClient.mm:
1920         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1921
1922 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1923
1924         Implement feature flag and bindings for CSS Painting API
1925         https://bugs.webkit.org/show_bug.cgi?id=190237
1926
1927         Reviewed by Ryosuke Niwa.
1928
1929         * Configurations/FeatureDefines.xcconfig:
1930
1931 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1932
1933         Replace HistoryItem* with HistoryItem& where possible
1934         https://bugs.webkit.org/show_bug.cgi?id=190617
1935
1936         Reviewed by Chris Dumez.
1937
1938         * History/BackForwardList.h:
1939         * History/BackForwardList.mm:
1940         (BackForwardList::goToItem):
1941         * History/WebBackForwardList.mm:
1942         (-[WebBackForwardList goToItem:]):
1943         * History/WebHistoryItem.mm:
1944         (WKNotifyHistoryItemChanged):
1945         * History/WebHistoryItemInternal.h:
1946
1947 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1948
1949         Remove unused WebHistoryItem._transientPropertyForKey
1950         https://bugs.webkit.org/show_bug.cgi?id=190606
1951
1952         Reviewed by Chris Dumez.
1953
1954         * History/WebHistoryItem.mm:
1955         * History/WebHistoryItemPrivate.h:
1956
1957 2018-10-15  Justin Fan  <justin_fan@apple.com>
1958
1959         Add WebGPU 2018 feature flag and experimental feature flag
1960         https://bugs.webkit.org/show_bug.cgi?id=190509
1961
1962         Reviewed by Dean Jackson.
1963
1964         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1965         for the 2018 WebGPU prototype.
1966
1967         * Configurations/FeatureDefines.xcconfig:
1968         * WebView/WebPreferenceKeysPrivate.h:
1969         * WebView/WebPreferences.mm:
1970         (+[WebPreferences initialize]):
1971         (-[WebPreferences webGPUEnabled]):
1972         (-[WebPreferences setWebGPUEnabled:]):
1973         * WebView/WebPreferencesPrivate.h:
1974         * WebView/WebView.mm:
1975         (-[WebView _preferencesChanged:]):
1976
1977 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1978
1979         Fix iOS build after r237157
1980
1981         * WebView/WebView.mm:
1982         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1983
1984 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1985
1986         Modernize BackForwardClient.h
1987         https://bugs.webkit.org/show_bug.cgi?id=190610
1988
1989         Reviewed by Chris Dumez.
1990
1991         * History/BackForwardList.h:
1992         * History/BackForwardList.mm:
1993         (BackForwardList::backListCount const):
1994         (BackForwardList::forwardListCount const):
1995         (BackForwardList::backListCount): Deleted.
1996         (BackForwardList::forwardListCount): Deleted.
1997         * History/WebBackForwardList.mm:
1998         (-[WebBackForwardList init]):
1999         * WebCoreSupport/WebFrameLoaderClient.mm:
2000         (WebFrameLoaderClient::canCachePage const):
2001         * WebView/WebFrameView.mm:
2002         (-[WebFrameView keyDown:keyDown:]):
2003         * WebView/WebView.mm:
2004         (-[WebView _commonInitializationWithFrameName:groupName:]):
2005         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2006         (-[WebView _loadBackForwardListFromOtherView:]):
2007         (-[WebView initWithCoder:]):
2008         (-[WebView encodeWithCoder:]):
2009         (-[WebView backForwardList]):
2010         (-[WebView setMaintainsBackForwardList:]):
2011
2012 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2013
2014         Add support for prefers-color-scheme media query
2015         https://bugs.webkit.org/show_bug.cgi?id=190499
2016         rdar://problem/45212025
2017
2018         Reviewed by Dean Jackson.
2019
2020         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2021
2022 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2023
2024         Remove unused WebView._globalHistoryItem
2025         https://bugs.webkit.org/show_bug.cgi?id=190601
2026
2027         Reviewed by Chris Dumez.
2028
2029         * WebCoreSupport/WebFrameLoaderClient.h:
2030         * WebCoreSupport/WebFrameLoaderClient.mm:
2031         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2032         * WebView/WebView.mm:
2033         (-[WebView _globalHistoryItem]): Deleted.
2034         (-[WebView _setGlobalHistoryItem:]): Deleted.
2035         * WebView/WebViewData.h:
2036         * WebView/WebViewInternal.h:
2037         * WebView/WebViewPrivate.h:
2038
2039 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2040
2041         Remove unused parameters from FrameLoaderClient::createFrame
2042         https://bugs.webkit.org/show_bug.cgi?id=190587
2043
2044         Reviewed by Chris Dumez.
2045
2046         * WebCoreSupport/WebFrameLoaderClient.h:
2047         * WebCoreSupport/WebFrameLoaderClient.mm:
2048         (WebFrameLoaderClient::createFrame):
2049
2050 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2051
2052         Remove unused WebFrame._loadType
2053         https://bugs.webkit.org/show_bug.cgi?id=190583
2054
2055         Reviewed by Chris Dumez.
2056
2057         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2058
2059         * WebView/WebFrame.mm:
2060         (toWebFrameLoadType): Deleted.
2061         (-[WebFrame _loadType]): Deleted.
2062         * WebView/WebFramePrivate.h:
2063
2064 2018-10-15  Chris Dumez  <cdumez@apple.com>
2065
2066         Restrict browsing context lookup by name to frames that are related to one another
2067         https://bugs.webkit.org/show_bug.cgi?id=190475
2068
2069         Reviewed by Alex Christensen.
2070
2071         * WebView/WebFrame.mm:
2072         (-[WebFrame findFrameNamed:]):
2073
2074 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2075
2076         Remove InjectedBundle processing of back/forward lists
2077         https://bugs.webkit.org/show_bug.cgi?id=190459
2078
2079         Reviewed by Chris Dumez.
2080
2081         * WebCoreSupport/WebFrameLoaderClient.h:
2082         * WebCoreSupport/WebFrameLoaderClient.mm:
2083         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2084
2085 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2086
2087         [JSC] Remove Option::useAsyncIterator
2088         https://bugs.webkit.org/show_bug.cgi?id=190567
2089
2090         Reviewed by Saam Barati.
2091
2092         * Configurations/FeatureDefines.xcconfig:
2093
2094 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2095
2096         Allow encoding of small enum classes
2097         https://bugs.webkit.org/show_bug.cgi?id=190531
2098
2099         Reviewed by Tim Horton.
2100
2101         * WebCoreSupport/WebFrameLoaderClient.mm:
2102         (-[WebFramePolicyListener dealloc]):
2103
2104 2018-10-11  Keith Rollin  <krollin@apple.com>
2105
2106         CURRENT_ARCH should not be used in Run Script phase.
2107         https://bugs.webkit.org/show_bug.cgi?id=190407
2108         <rdar://problem/45133556>
2109
2110         Reviewed by Alexey Proskuryakov.
2111
2112         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2113         CURRENT_ARCH is not well-defined during this phase (and may even have
2114         the value "undefined") since this phase is run just once per build
2115         rather than once per supported architecture. Migrate away from
2116         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2117         performing an operation for each value, or by picking the first entry
2118         in ARCHS and using that as a representative value.
2119
2120         * Configurations/WebKitLegacy.xcconfig: When generating
2121         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2122         macosx platforms.
2123
2124         * MigrateHeaders.make:
2125         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2126         generate one for each architecture in ARCHS.
2127
2128 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2129
2130         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2131         https://bugs.webkit.org/show_bug.cgi?id=190429
2132
2133         Reviewed by Saam Barati.
2134
2135         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2136
2137         * WebView/WebPDFRepresentation.mm:
2138         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2139
2140 2018-10-08  Justin Fan  <justin_fan@apple.com>
2141
2142         WebGPU: Rename old WebGPU prototype to WebMetal
2143         https://bugs.webkit.org/show_bug.cgi?id=190325
2144         <rdar://problem/44990443>
2145
2146         Reviewed by Dean Jackson.
2147
2148         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2149
2150         * Configurations/FeatureDefines.xcconfig:
2151         * WebView/WebPreferenceKeysPrivate.h:
2152         * WebView/WebPreferences.mm:
2153         (+[WebPreferences initialize]):
2154         (-[WebPreferences webMetalEnabled]):
2155         (-[WebPreferences setWebMetalEnabled:]):
2156         (-[WebPreferences webGPUEnabled]): Deleted.
2157         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2158         * WebView/WebPreferencesPrivate.h:
2159         * WebView/WebView.mm:
2160         (-[WebView _preferencesChanged:]):
2161
2162 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2163
2164         Make <input type=color> a runtime enabled (on-by-default) feature
2165         https://bugs.webkit.org/show_bug.cgi?id=189162
2166
2167         Reviewed by Wenson Hsieh and Tim Horton.
2168
2169         * Configurations/FeatureDefines.xcconfig:
2170
2171 2018-10-07  Dan Bernstein  <mitz@apple.com>
2172
2173         Fixed building with the latest macOS SDK
2174
2175         * Plugins/WebNetscapePluginPackage.mm:
2176         (-[WebNetscapePluginPackage openResourceFile]):
2177         (-[WebNetscapePluginPackage closeResourceFile:]):
2178
2179 2018-10-04  Dan Bernstein  <mitz@apple.com>
2180
2181         More Carbon build-fixing.
2182
2183         * Carbon/CarbonWindowAdapter.mm:
2184         (-[CarbonWindowAdapter _destroyRealWindow:]):
2185         (-[CarbonWindowAdapter _growBoxRect]):
2186
2187 2018-10-04  Dan Bernstein  <mitz@apple.com>
2188
2189         Retried to fix 32-bit macOS builds after r236846.
2190
2191         * WebView/WebHTMLView.mm:
2192         (-[WebHTMLView setMarkedText:selectedRange:]):
2193
2194 2018-10-04  Dan Bernstein  <mitz@apple.com>
2195
2196         Retried to fix 32-bit macOS builds after r236846.
2197
2198         * Carbon/HIWebView.mm:
2199         (ActiveStateChanged):
2200
2201 2018-10-04  Dan Bernstein  <mitz@apple.com>
2202
2203         Tried to fix 32-bit macOS builds after r236846.
2204
2205         * Carbon/HIWebView.mm:
2206         (_NSSelectorForHICommand):
2207
2208 2018-10-04  Dan Bernstein  <mitz@apple.com>
2209
2210         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2211         https://bugs.webkit.org/show_bug.cgi?id=190250
2212
2213         Reviewed by Andy Estes.
2214
2215         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2216           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2217           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2218           an earlier line set it to YES.
2219
2220         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2221         changes below.
2222
2223         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2224           provides some missing method declarations.
2225
2226         * Misc/WebDownload.mm:
2227         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2228           a deprecated method.
2229
2230         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2231
2232         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2233           other code in the file uses a method from it.
2234
2235         * Plugins/WebBaseNetscapePluginView.mm:
2236         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2237           a deprecated method.
2238
2239         * Plugins/WebPluginController.mm:
2240         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2241           around use of a selector that may be present in some WebKit client.
2242
2243         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2244           method declarations.
2245
2246         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2247           from here.
2248
2249         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2250           missing method declarations.
2251
2252         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2253           from here.
2254
2255         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2256           call from here.
2257         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2258           an obsolete delegate method for binary compatibility.
2259         (pluginView): Ditto.
2260
2261         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2262           call from here.
2263
2264         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2265           WebDeviceOrientationProviderMock protocol.
2266
2267         * WebView/WebDeviceOrientationProviderMock.mm:
2268         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2269           main @implementation.
2270
2271         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2272           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2273
2274         * WebView/WebDynamicScrollBarsView.mm:
2275         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2276           of a deprecated method.
2277
2278         * WebView/WebHTMLView.mm:
2279         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2280           selector warning around action methods that are not declared anywhere in WebKit.
2281
2282         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2283           about implementing this deprecated method.
2284         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2285         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2286         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2287         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2288         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2289         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2290         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2291         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2292         (-[WebHTMLView doCommandBySelector:]): Ditto.
2293         (-[WebHTMLView insertText:]): Ditto.
2294
2295         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2296
2297         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2298
2299         * WebView/WebPDFView.h: Removed previewView ivar.
2300
2301         * WebView/WebPDFView.mm:
2302           Removed declaration of FileInternal category and merged its implementation with the main
2303           implementation.
2304         (-[WebPDFView dealloc]): Removed previewView ivar.
2305         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2306           exist in macOS versions we support.
2307         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2308         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2309           action methods internal to PDFKit.
2310         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2311         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2312
2313         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2314           call on macOS, even though in r86988 we started calling different methods on iOS.
2315
2316         * WebView/WebView.mm:
2317         - Imported headers that declare delegate methods that we call.
2318         - Removed declaration of WebFileInternal category and merged its implementation with the
2319           main implementation.
2320         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2321           category, which made them impossible to call from the main implementation. Moved those
2322           into the main implementation. One of those had to be declared in a class extension,
2323           because it is called from a method implemented in the WebPrivate category, and that
2324           category’s implementation appears first in the file.
2325
2326         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2327           around use of obsolete delegate method for binary compatibility.
2328
2329         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2330
2331 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2332
2333         Runtime flag and IDL for MediaRecorder
2334         https://bugs.webkit.org/show_bug.cgi?id=190018
2335
2336         Reviewed by Youenn Fablet and Chris Dumez.
2337
2338         * WebView/WebPreferenceKeysPrivate.h:
2339         * WebView/WebPreferences.mm:
2340         (+[WebPreferences initialize]):
2341         (-[WebPreferences mediaRecorderEnabled]):
2342         (-[WebPreferences setMediaRecorderEnabled:]):
2343         * WebView/WebPreferencesPrivate.h:
2344         * WebView/WebView.mm:
2345         (-[WebView _preferencesChanged:]):
2346
2347 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2348
2349         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2350         https://bugs.webkit.org/show_bug.cgi?id=190238
2351
2352         Reviewed by Antti Koivisto.
2353
2354         Enabled the feature by default.
2355
2356         * WebView/WebPreferences.mm:
2357         (+[WebPreferences initialize]):
2358
2359 2018-10-01  Dean Jackson  <dino@apple.com>
2360
2361         [macOS] Switching to discrete GPU should be done in the UI process
2362         https://bugs.webkit.org/show_bug.cgi?id=189361
2363         <rdar://problem/43949622>
2364
2365         Reviewed by Simon Fraser.
2366
2367         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2368         not support swapping to the discrete GPU in this configuration.
2369
2370         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2371         (WebKit::WebSwitchingGPUClient::singleton):
2372         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2373         * WebView/WebView.mm:
2374         (-[WebView _commonInitializationWithFrameName:groupName:]):
2375
2376 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2377
2378         Remove ParsedURLString
2379         https://bugs.webkit.org/show_bug.cgi?id=190154
2380
2381         Reviewed by Chris Dumez.
2382
2383         * WebView/WebScriptDebugger.mm:
2384         (toNSURL):
2385
2386 2018-10-01  Dean Jackson  <dino@apple.com>
2387
2388         Remove CSS Animation Triggers
2389         https://bugs.webkit.org/show_bug.cgi?id=190175
2390         <rdar://problem/44925626>
2391
2392         Reviewed by Simon Fraser.
2393
2394         * Configurations/FeatureDefines.xcconfig:
2395
2396 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2397
2398         Unreviewed, rolling out r236624 and r236671.
2399         https://bugs.webkit.org/show_bug.cgi?id=190207
2400
2401         The change in r236624 introduced crashes on the bots
2402         (Requested by ryanhaddad on #webkit).
2403
2404         Reverted changesets:
2405
2406         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2407         https://bugs.webkit.org/show_bug.cgi?id=188747
2408         https://trac.webkit.org/changeset/236624
2409
2410         "Unify implementation in VideoFullscreenInterfaceAVKit"
2411         https://bugs.webkit.org/show_bug.cgi?id=190091
2412         https://trac.webkit.org/changeset/236671
2413
2414 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2415
2416         URL should not use TextEncoding internally
2417         https://bugs.webkit.org/show_bug.cgi?id=190111
2418
2419         Reviewed by Andy Estes.
2420
2421         * Misc/WebNSURLExtras.mm:
2422
2423 2018-09-28  Jer Noble  <jer.noble@apple.com>
2424
2425         Refactoring: eliminate raw pointer usage in Fullscreen code
2426         https://bugs.webkit.org/show_bug.cgi?id=188747
2427         <rdar://problem/43541164>
2428
2429         Reviewed by Alex Christensen.
2430
2431         PlaybackSessionInterface no longer has an invalidate() method.
2432
2433         * WebView/WebView.mm:
2434         (-[WebView _clearPlaybackControlsManager]):
2435
2436 2018-09-28  Chris Dumez  <cdumez@apple.com>
2437
2438         Drop support for cross-origin-window-policy header
2439         https://bugs.webkit.org/show_bug.cgi?id=190081
2440
2441         Reviewed by Ryosuke Niwa.
2442
2443         * WebView/WebPreferenceKeysPrivate.h:
2444         * WebView/WebPreferences.mm:
2445         (+[WebPreferences initialize]):
2446         * WebView/WebPreferencesPrivate.h:
2447         * WebView/WebView.mm:
2448         (-[WebView _preferencesChanged:]):
2449
2450 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2451
2452         Rename createMarkup to serializePreservingVisualAppearance
2453         https://bugs.webkit.org/show_bug.cgi?id=190086
2454
2455         Reviewed by Wenson Hsieh.
2456
2457         * DOM/WebDOMOperations.mm:
2458         (-[DOMRange markupString]):
2459
2460 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2461
2462         Unreviewed, rolling out r236605.
2463         https://bugs.webkit.org/show_bug.cgi?id=190087
2464
2465         caused three API test timeouts (Requested by jernoble on
2466         #webkit).
2467
2468         Reverted changeset:
2469
2470         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2471         https://bugs.webkit.org/show_bug.cgi?id=188747
2472         https://trac.webkit.org/changeset/236605
2473
2474 2018-09-28  Jer Noble  <jer.noble@apple.com>
2475
2476         Refactoring: eliminate raw pointer usage in Fullscreen code
2477         https://bugs.webkit.org/show_bug.cgi?id=188747
2478         <rdar://problem/43541164>
2479
2480         Reviewed by Alex Christensen.
2481
2482         PlaybackSessionInterface no longer has an invalidate() method.
2483
2484         * WebView/WebView.mm:
2485         (-[WebView _clearPlaybackControlsManager]):
2486
2487 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2488
2489         Use enum class in createMarkup arguments
2490         https://bugs.webkit.org/show_bug.cgi?id=190028
2491
2492         Reviewed by Wenson Hsieh.
2493
2494         * DOM/WebDOMOperations.mm:
2495         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2496         (-[DOMRange markupString]): Ditto.
2497
2498 2018-09-27  Antoine Quint  <graouts@apple.com>
2499
2500         [Web Animations] Turn Web Animations with CSS integration on
2501         https://bugs.webkit.org/show_bug.cgi?id=184819
2502         <rdar://problem/39597337>
2503
2504         Reviewed by Dean Jackson.
2505
2506         * WebView/WebPreferences.mm:
2507         (+[WebPreferences initialize]):
2508
2509 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2510
2511         Selection should work across shadow boundary when initiated by a mouse drag
2512         https://bugs.webkit.org/show_bug.cgi?id=151380
2513         <rdar://problem/24363872>
2514
2515         Reviewed by Wenson Hsieh.
2516
2517         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2518
2519         * WebView/WebPreferenceKeysPrivate.h:
2520         * WebView/WebPreferences.mm:
2521         (+[WebPreferences initialize]):
2522         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2523         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2524         * WebView/WebPreferencesPrivate.h:
2525         * WebView/WebView.mm:
2526         (-[WebView _preferencesChanged:]):
2527
2528 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2529
2530         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2531         https://bugs.webkit.org/show_bug.cgi?id=189918
2532         Work towards <rdar://problem/44648705>
2533
2534         Reviewed by Tim Horton.
2535
2536         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2537
2538         * WebView/WebHTMLView.mm:
2539         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2540         (-[WebHTMLView _updateFontPanel]):
2541         * WebView/WebView.mm:
2542         (-[WebView typingAttributes]):
2543
2544 2018-09-17  Darin Adler  <darin@apple.com>
2545
2546         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2547         https://bugs.webkit.org/show_bug.cgi?id=189652
2548
2549         Reviewed by Saam Barati.
2550
2551         * WebView/WebPDFRepresentation.mm:
2552         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2553
2554 2018-09-14  Jer Noble  <jer.noble@apple.com>
2555
2556         Turn SourceBufferChangeTypeEnabled on by default
2557         https://bugs.webkit.org/show_bug.cgi?id=189527
2558
2559         Reviewed by Eric Carlson.
2560
2561         * WebView/WebPreferences.mm:
2562         (+[WebPreferences initialize]):
2563
2564 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2565
2566         Fix an internal build after r235935
2567         https://bugs.webkit.org/show_bug.cgi?id=188996
2568
2569         * Carbon/HIWebView.mm:
2570         (Draw):
2571         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2572
2573 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2574
2575         Add IGNORE_WARNING_.* macros
2576         https://bugs.webkit.org/show_bug.cgi?id=188996
2577
2578         Reviewed by Michael Catanzaro.
2579
2580         * Carbon/CarbonUtils.m:
2581         (PoolCleaner):
2582         * Carbon/CarbonWindowAdapter.mm:
2583         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2584         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2585         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2586         (-[CarbonWindowAdapter _termWindowIfOwner]):
2587         (-[CarbonWindowAdapter _windowMovedToRect:]):
2588         (-[CarbonWindowAdapter setContentView:]):
2589         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2590         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2591         * Carbon/CarbonWindowFrame.m:
2592         (-[CarbonWindowFrame title]):
2593         * Carbon/HIViewAdapter.m:
2594         (+[HIViewAdapter getHIViewForNSView:]):
2595         * Carbon/HIWebView.mm:
2596         (overrideCGContext):
2597         (restoreCGContext):
2598         (Draw):
2599         * DOM/DOM.mm:
2600         * History/WebHistory.mm:
2601         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2602         * History/WebHistoryItem.mm:
2603         (-[WebHistoryItem icon]):
2604         * Misc/WebKitNSStringExtras.mm:
2605         (-[NSString _web_drawAtPoint:font:textColor:]):
2606         * Misc/WebNSImageExtras.m:
2607         (-[NSImage _web_scaleToMaxSize:]):
2608         (-[NSImage _web_dissolveToFraction:]):
2609         * Misc/WebNSPasteboardExtras.mm:
2610         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2611         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2612         * Panels/WebAuthenticationPanel.m:
2613         (-[WebAuthenticationPanel loadNib]):
2614         * Plugins/Hosted/NetscapePluginHostManager.mm:
2615         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2616         (WebKit::NetscapePluginHostManager::didCreateWindow):
2617         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2618         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2619         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2620         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2621         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2622         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2623         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2624         (-[WebHostedNetscapePluginView drawRect:]):
2625         * Plugins/Hosted/WebTextInputWindowController.m:
2626         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2627         * Plugins/WebBaseNetscapePluginView.mm:
2628         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2629         * Plugins/WebNetscapePluginPackage.mm:
2630         (-[WebNetscapePluginPackage _tryLoad]):
2631         * Plugins/WebNetscapePluginView.mm:
2632         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2633         (-[WebNetscapePluginView sendDrawRectEvent:]):
2634         (-[WebNetscapePluginView drawRect:]):
2635         * Plugins/WebPluginController.mm:
2636         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2637         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2638         * WebCoreSupport/PopupMenuMac.mm:
2639         (PopupMenuMac::populate):
2640         * WebCoreSupport/WebAlternativeTextClient.h:
2641         * WebCoreSupport/WebDragClient.mm:
2642         (WebDragClient::startDrag):
2643         * WebCoreSupport/WebFrameLoaderClient.mm:
2644         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2645         (webGetNSImage):
2646         * WebInspector/WebNodeHighlight.mm:
2647         * WebInspector/WebNodeHighlightView.mm:
2648         (-[WebNodeHighlightView drawRect:]):
2649         * WebView/WebClipView.mm:
2650         (-[WebClipView initWithFrame:]):
2651         * WebView/WebFrame.mm:
2652         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2653         (-[WebFrame _drawRect:contentsOnly:]):
2654         (-[WebFrame accessibilityRoot]):
2655         * WebView/WebFullScreenController.mm:
2656         (-[WebFullScreenController enterFullScreen:]):
2657         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2658         (-[WebFullScreenController exitFullScreen]):
2659         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2660         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2661         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2662         * WebView/WebHTMLView.mm:
2663         (-[NSWindow _web_borderView]):
2664         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2665         (-[WebHTMLView _setAsideSubviews]):
2666         (-[WebHTMLView _autoscroll]):
2667         (-[WebHTMLView drawRect:]):
2668         (-[WebHTMLView mouseDown:]):
2669         (-[WebHTMLView mouseDragged:]):
2670         (-[WebHTMLView mouseUp:]):
2671         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2672         (-[WebHTMLView knowsPageRange:]):
2673         (-[WebHTMLView accessibilityHitTest:]):
2674         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2675         (-[WebHTMLView _colorAsString:]):
2676         (-[WebHTMLView copyFont:]):
2677         (-[WebHTMLView _executeSavedKeypressCommands]):
2678         (-[WebHTMLView attachRootLayer:]):
2679         (-[WebHTMLView textStorage]):
2680         (-[WebHTMLView _updateSelectionForInputManager]):
2681         * WebView/WebPDFView.mm:
2682         (_applicationInfoForMIMEType):
2683         (-[WebPDFView centerSelectionInVisibleArea:]):
2684         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2685         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2686         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2687         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2688         * WebView/WebTextCompletionController.mm:
2689         (-[WebTextCompletionController _buildUI]):
2690         (-[WebTextCompletionController _placePopupWindow:]):
2691         * WebView/WebVideoFullscreenController.mm:
2692         * WebView/WebVideoFullscreenHUDWindowController.mm:
2693         (createMediaUIBackgroundView):
2694         * WebView/WebView.mm:
2695         (-[WebTextListTouchBarViewController initWithWebView:]):
2696         (-[WebView _dispatchTileDidDraw:]):
2697         (-[WebView encodeWithCoder:]):
2698         (-[WebView mainFrameIcon]):
2699         (LayerFlushController::flushLayers):
2700         * WebView/WebWindowAnimation.mm:
2701         (setScaledFrameForWindow):
2702
2703 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2704
2705         Remove unused needsDestruction class variables from HashTraits
2706         https://bugs.webkit.org/show_bug.cgi?id=189490
2707
2708         Reviewed by Daniel Bates.
2709
2710         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2711
2712 2018-09-07  Frederic Wang  <fwang@igalia.com>
2713
2714         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2715         https://bugs.webkit.org/show_bug.cgi?id=182230
2716
2717         Reviewed by Simon Fraser.
2718
2719         * DOM/DOMDocument.mm:
2720         (-[DOMDocument scrollingElement]): Use the new name.
2721
2722 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2723
2724         Refactor WebCore::EditAction to be an 8-bit enum class
2725         https://bugs.webkit.org/show_bug.cgi?id=189383
2726
2727         Reviewed by Dan Bernstein.
2728
2729         * WebCoreSupport/WebEditorClient.mm:
2730         (undoNameForEditAction):
2731         * WebView/WebHTMLView.mm:
2732         (-[WebHTMLView pasteFont:]):
2733         (-[WebHTMLView changeFont:]):
2734         (-[WebHTMLView changeAttributes:]):
2735         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2736         (-[WebHTMLView changeColor:]):
2737         * WebView/WebView.mm:
2738         (-[WebView setTypingStyle:]):
2739
2740 2018-09-06  Frederic Wang  <fwang@igalia.com>
2741
2742         Group options of scrollRectToVisible into a struct
2743         https://bugs.webkit.org/show_bug.cgi?id=189352
2744
2745         Reviewed by Simon Fraser.
2746
2747         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2748         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2749         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2750
2751 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2752
2753         [macOS] Cannot change font size at selection until font panel is shown
2754         https://bugs.webkit.org/show_bug.cgi?id=189295
2755         <rdar://problem/35593389>
2756
2757         Reviewed by Ryosuke Niwa.
2758
2759         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2760         WebCore ChangeLog for more details.
2761
2762         * WebView/WebHTMLView.mm:
2763         (-[WebHTMLView changeFont:]):
2764         (-[WebHTMLView changeAttributes:]):
2765         (-[WebHTMLView _originalFontA]): Deleted.
2766         (-[WebHTMLView _originalFontB]): Deleted.
2767         (fontNameForDescription): Deleted.
2768         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2769         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2770         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2771
2772 2018-09-05  Jer Noble  <jer.noble@apple.com>
2773
2774         Add MediaCapabilities as an Experimental Feature
2775         https://bugs.webkit.org/show_bug.cgi?id=189209
2776
2777         Reviewed by Eric Carlson.
2778
2779         RuntimeEnabledFeature -> Setting.
2780
2781         * WebView/WebView.mm:
2782         (-[WebView _preferencesChanged:]):
2783
2784 2018-09-04  Frederic Wang  <fwang@igalia.com>
2785
2786         Add basic support for ScrollIntoViewOptions
2787         https://bugs.webkit.org/show_bug.cgi?id=189258
2788
2789         Reviewed by Simon Fraser.
2790
2791         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2792         header so that this file can build despite the new scrollIntoView function.
2793
2794 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2795
2796         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2797         https://bugs.webkit.org/show_bug.cgi?id=188890
2798         <rdar://problem/43648605>
2799
2800         Reviewed by Tim Horton.
2801
2802         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2803         more detail.
2804
2805         * WebCoreSupport/WebPlatformStrategies.h:
2806         * WebCoreSupport/WebPlatformStrategies.mm:
2807         (WebPlatformStrategies::allStringsForType):
2808
2809 2018-09-01  Darin Adler  <darin@apple.com>
2810
2811         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2812         https://bugs.webkit.org/show_bug.cgi?id=189072
2813         Reviewed by Dan Bernstein.
2814
2815         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2816         and declarations for NSURLDownload init methods.
2817
2818         * Misc/WebDownloadInternal.h: Removed.
2819
2820         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2821         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2822         "-Wdeprecated-declarations" because the method used here is deprecated.
2823
2824         * WebView/WebView.mm:
2825         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2826         used here is deprecated.
2827
2828 2018-08-31  Chris Dumez  <cdumez@apple.com>
2829
2830         Assertion hit in ~CompletionHandler() from ~WebFrame()
2831         https://bugs.webkit.org/show_bug.cgi?id=189199
2832         <rdar://problem/42657233>
2833
2834         Reviewed by Youenn Fablet.
2835
2836         * WebCoreSupport/WebFrameLoaderClient.h:
2837         * WebCoreSupport/WebFrameLoaderClient.mm:
2838         (WebFrameLoaderClient::dispatchWillSubmitForm):
2839
2840 2018-08-31  Antti Koivisto  <antti@apple.com>
2841
2842         Replace OptionSet |= and -= operators with add() and remove() functions
2843         https://bugs.webkit.org/show_bug.cgi?id=189169
2844
2845         Reviewed by Anders Carlsson.
2846
2847         * WebView/WebFrame.mm:
2848         (-[WebFrame _drawRect:contentsOnly:]):
2849         * WebView/WebView.mm:
2850         (coreOptions):
2851
2852 2018-08-31  Frederic Wang  <fwang@igalia.com>
2853
2854         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2855         https://bugs.webkit.org/show_bug.cgi?id=182053
2856
2857         Reviewed by Simon Fraser.
2858
2859         Add developer flag to use standard behavior for scrolling* attributes.
2860
2861         * WebView/WebPreferenceKeysPrivate.h:
2862         * WebView/WebPreferences.mm:
2863         (+[WebPreferences initialize]):
2864         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2865         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2866         * WebView/WebPreferencesPrivate.h:
2867         * WebView/WebView.mm:
2868         (-[WebView _preferencesChanged:]):
2869
2870 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2871
2872         Implement the Web Share API
2873         https://bugs.webkit.org/show_bug.cgi?id=171100
2874         <rdar://problem/31751734>
2875
2876         Reviewed by Tim Horton.
2877
2878         * WebCoreSupport/WebChromeClient.h:
2879         * WebCoreSupport/WebChromeClient.mm:
2880         (WebChromeClient::showShareSheet):
2881         Empty declaration of showShareSheet.
2882
2883 2018-08-29  Youenn Fablet  <youenn@apple.com>
2884
2885         Remove WebRTC legacy API implementation
2886         https://bugs.webkit.org/show_bug.cgi?id=189040
2887
2888         Reviewed by Eric Carlson.
2889
2890         * WebView/WebPreferenceKeysPrivate.h:
2891         * WebView/WebPreferences.mm:
2892         (+[WebPreferences initialize]):
2893         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2894         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2895         * WebView/WebPreferencesPrivate.h:
2896         * WebView/WebView.mm:
2897         (-[WebView _preferencesChanged:]):
2898
2899 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2900
2901         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2902         https://bugs.webkit.org/show_bug.cgi?id=189054
2903
2904         Reviewed by Andy Estes.
2905
2906         Remove the pasteboard type argument from readURLFromPasteboard.
2907
2908         * WebCoreSupport/WebPlatformStrategies.h:
2909         * WebCoreSupport/WebPlatformStrategies.mm:
2910         (WebPlatformStrategies::readURLFromPasteboard):
2911
2912 2018-08-27  Keith Rollin  <krollin@apple.com>
2913
2914         Unreviewed build fix -- disable LTO for production builds
2915
2916         * Configurations/Base.xcconfig:
2917
2918 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2919
2920         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2921         https://bugs.webkit.org/show_bug.cgi?id=188931
2922
2923         Reviewed by Wenson Hsieh.
2924
2925         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2926
2927 2018-08-27  Keith Rollin  <krollin@apple.com>
2928
2929         Build system support for LTO
2930         https://bugs.webkit.org/show_bug.cgi?id=187785
2931         <rdar://problem/42353132>
2932
2933         Reviewed by Dan Bernstein.
2934
2935         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2936         LTO.
2937
2938         * Configurations/Base.xcconfig:
2939         * Configurations/DebugRelease.xcconfig:
2940
2941 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2942
2943         Pass in IsComposed flag to Event constructors
2944         https://bugs.webkit.org/show_bug.cgi?id=188720
2945         <rdar://problem/43580387>
2946
2947         Reviewed by Simon Fraser.
2948
2949         * WebView/WebPDFView.mm:
2950         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2951         whether it's simulated or not.
2952
2953 2018-08-23  Mark Lam  <mark.lam@apple.com>
2954
2955         Move vmEntryGlobalObject() to VM from CallFrame.
2956         https://bugs.webkit.org/show_bug.cgi?id=188900
2957         <rdar://problem/43655753>
2958
2959         Reviewed by Michael Saboff.
2960
2961         * WebView/WebScriptDebugger.mm:
2962         (WebScriptDebugger::sourceParsed):
2963
2964 2018-08-23  Andy Estes  <aestes@apple.com>
2965
2966         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2967         https://bugs.webkit.org/show_bug.cgi?id=188829
2968
2969         Reviewed by Tim Horton.
2970
2971         * Configurations/FeatureDefines.xcconfig:
2972
2973 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2974
2975         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2976         https://bugs.webkit.org/show_bug.cgi?id=188777
2977
2978         Reviewed by Simon Fraser.
2979
2980         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2981         being "true" before the code change.
2982
2983         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2984
2985         * WebView/WebPDFView.mm:
2986         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2987
2988 2018-08-21  Daniel Bates  <dabates@apple.com>
2989
2990         Replace TextCheckingTypeMask with OptionSet
2991         https://bugs.webkit.org/show_bug.cgi?id=188678
2992
2993         Reviewed by Antti Koivisto.
2994
2995         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2996         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2997         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2998         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2999
3000         * WebCoreSupport/WebEditorClient.h:
3001         * WebCoreSupport/WebEditorClient.mm:
3002         (WebEditorClient::checkTextOfParagraph):
3003         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3004         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3005         left as this is more readable and unncessary now that modern compilers like Clang have
3006         diagnostics to catch accidental assignments when equality was intended.
3007         (WebEditorClient::didCheckSucceed):
3008         * WebView/WebView.mm:
3009         (coreTextCheckingType):
3010         (textCheckingResultFromNSTextCheckingResult):
3011
3012 2018-08-21  Daniel Bates  <dabates@apple.com>
3013
3014         [iOS][WK1] Support toggling continuous spell checking from tests
3015         https://bugs.webkit.org/show_bug.cgi?id=188763
3016
3017         Reviewed by Simon Fraser.
3018
3019         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3020         spell checking from tests in iOS WebKit Legacy.
3021
3022         * WebCoreSupport/WebEditorClient.h:
3023         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3024         * WebCoreSupport/WebEditorClient.mm:
3025         * WebView/WebView.h:
3026         * WebView/WebView.mm:
3027         (-[WebView toggleContinuousSpellChecking:]):
3028         (-[WebView toggleSmartInsertDelete:]):
3029
3030 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3031
3032         Add some plumbing for safe browsing
3033         https://bugs.webkit.org/show_bug.cgi?id=188709
3034
3035         Reviewed by Tim Horton.
3036
3037         * WebCoreSupport/WebFrameLoaderClient.h:
3038         * WebCoreSupport/WebFrameLoaderClient.mm:
3039         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3040
3041 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3042
3043         Replace canBubble and cancelable booleans in Event by enum classes
3044         https://bugs.webkit.org/show_bug.cgi?id=188692
3045
3046         Reviewed by Alex Christensen.
3047
3048         * WebView/WebPDFView.mm:
3049         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3050         * WebView/WebView.mm:
3051         (-[WebView _dispatchUnloadEvent]):
3052
3053 2018-08-16  Jer Noble  <jer.noble@apple.com>
3054
3055         Add Experimental Feature support for SourceBuffer.changeType()
3056         https://bugs.webkit.org/show_bug.cgi?id=188626
3057         <rdar://problem/43356021>
3058
3059         Reviewed by Eric Carlson.
3060
3061         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3062
3063         * WebView/WebPreferenceKeysPrivate.h:
3064         * WebView/WebPreferences.mm:
3065         (+[WebPreferences initialize]):
3066         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3067         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3068         * WebView/WebPreferencesPrivate.h:
3069         * WebView/WebView.mm:
3070         (-[WebView _preferencesChanged:]):
3071
3072 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3073
3074         Support drag-and-drop for input[type=color]
3075         https://bugs.webkit.org/show_bug.cgi?id=188464
3076
3077         Reviewed by Wenson Hsieh.
3078
3079         * WebCoreSupport/WebPlatformStrategies.h:
3080         * WebCoreSupport/WebPlatformStrategies.mm:
3081         (WebPlatformStrategies::setColor):
3082
3083 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3084
3085         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3086         https://bugs.webkit.org/show_bug.cgi?id=188569
3087         <rdar://problem/34201095>
3088
3089         Reviewed by Megan Gardner.
3090
3091         * WebView/WebImmediateActionController.mm:
3092         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3093         Speculative fix; the crashes indicate font is null, but we just checked it,
3094         so it must be getting made null by convertFont:toSize:. Check again!
3095
3096 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3097
3098         Use a 1-byte enum class for TextDirection
3099         https://bugs.webkit.org/show_bug.cgi?id=188350
3100
3101         Reviewed by Simon Fraser.
3102
3103         * WebCoreSupport/PopupMenuMac.mm:
3104         (PopupMenuMac::populate):
3105         (PopupMenuMac::show):
3106         * WebCoreSupport/WebFrameLoaderClient.mm:
3107         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3108         * WebView/WebFrame.mm:
3109         (-[WebFrame _dispatchDidReceiveTitle:]):
3110
3111 2018-08-09  Ali Juma  <ajuma@chromium.org>
3112
3113         Import WPTs for IntersectionObserver
3114         https://bugs.webkit.org/show_bug.cgi?id=188416
3115
3116         Reviewed by Simon Fraser.
3117
3118         * WebView/WebPreferencesPrivate.h:
3119
3120 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3121
3122         Follow-up build fix for r234685
3123         https://bugs.webkit.org/show_bug.cgi?id=188245
3124
3125         Unreviewed build fix.
3126
3127         * WebCoreSupport/WebSecurityOriginPrivate.h:
3128
3129 2018-08-05  Darin Adler  <darin@apple.com>
3130
3131         [Cocoa] More tweaks and refactoring to prepare for ARC
3132         https://bugs.webkit.org/show_bug.cgi?id=188245
3133
3134         Reviewed by Dan Bernstein.
3135
3136         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3137
3138         * Carbon/CarbonWindowFrame.m:
3139         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3140
3141         * DOM/DOM.mm:
3142         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3143         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3144         garbage collection so this method isn't useful.
3145
3146         * DOM/DOMXPath.mm:
3147         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3148         Objective-C garbage collection so this method isn't useful.
3149
3150         * History/WebHistory.mm:
3151         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3152
3153         * Misc/WebElementDictionary.mm:
3154         (addLookupKey): Use a bridging cast.
3155         (cacheValueForKey): Ditto.
3156         (-[WebElementDictionary _fillCache]): Ditto.
3157         (-[WebElementDictionary objectForKey:]): Ditto.
3158
3159         * Misc/WebKitNSStringExtras.mm:
3160         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3161         (-[NSString _web_widthWithFont:]): Ditto.
3162         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3163
3164         * Misc/WebLocalizableStrings.mm:
3165         (WebLocalizedString): Use a bridging cast.
3166
3167         * Misc/WebNSDataExtras.mm:
3168         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3169         and use CFBridgingRelease instead of calling autorelease directly.
3170         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3171         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3172         on the amount of explicit release and autorelease.
3173
3174         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3175         * Misc/WebNSDictionaryExtras.m:
3176         (-[NSDictionary _webkit_intForKey:]): Deleted.
3177         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3178         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3179         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3180         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3181         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3182         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3183
3184         * Misc/WebStringTruncator.mm:
3185         (fontFromNSFont): Use a bridging cast.
3186
3187         * Plugins/Hosted/NetscapePluginHostManager.mm:
3188         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3189
3190         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3191         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3192         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3193         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3194         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3195         * Plugins/Hosted/ProxyInstance.mm:
3196         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3197         * Plugins/WebBasePluginPackage.mm:
3198         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3199         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3200         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3201         * Plugins/WebNetscapePluginPackage.mm:
3202         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3203
3204         * Plugins/WebNetscapePluginView.mm:
3205         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3206         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3207         (-[WebNetscapePluginView status:]): Use a bridging cast.
3208         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3209
3210         * Plugins/WebPluginController.mm:
3211         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3212
3213         * Plugins/WebPluginDatabase.mm:
3214         (checkCandidate): Use explicit __strong for out argument types.
3215
3216         * Plugins/npapi.mm:
3217         (pluginViewForInstance): Use a bridging cast.
3218
3219         * Storage/WebDatabaseManager.mm:
3220         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3221         explicit NSNumber and NSDictionary calls.
3222
3223         * WebCoreSupport/WebContextMenuClient.mm:
3224         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3225
3226         * WebCoreSupport/WebEditorClient.mm:
3227         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3228         (WebEditorClient::handleInputMethodKeydown): Ditto.
3229
3230         * WebCoreSupport/WebFrameNetworkingContext.mm:
3231         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3232
3233         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3234         as a struct rather than an Objective-C class, since that's how it's defined.
3235
3236         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3237
3238         * WebView/WebFullScreenController.mm:
3239         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3240         * WebView/WebHTMLView.mm:
3241         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3242         Ditto.
3243         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3244
3245         * WebView/WebImmediateActionController.mm:
3246         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3247         go down to the document and then back to the frame.
3248         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3249         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3250         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3251
3252         * WebView/WebJSPDFDoc.mm:
3253         (jsPDFDocInitialize): Removed some unneeded type casting.
3254         (jsPDFDocFinalize): Ditto.
3255         (jsPDFDocPrint): Use a bridging cast.
3256
3257         * WebView/WebPDFView.mm:
3258         (_applicationInfoForMIMEType): Use bridging casts.
3259
3260         * WebView/WebPreferences.mm:
3261         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3262         instead of methods from WebNSDictionaryExtras.
3263         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3264         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3265         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3266         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3267         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3268
3269         * WebView/WebView.mm:
3270         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3271         (-[WebView _addToAllWebViewsSet]): Ditto.
3272         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3273         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3274         so it can be called from WebViewData methods.
3275
3276         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3277         method, _windowVisibilityChanged:.
3278
3279         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3280         called from WebViewData methods.
3281
3282 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3283
3284         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3285         https://bugs.webkit.org/show_bug.cgi?id=188323
3286
3287         Reviewed by Simon Fraser.
3288
3289         * WebCoreSupport/WebContextMenuClient.mm:
3290         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3291         * WebView/WebFrame.mm:
3292         (-[WebFrame _paintBehaviorForDestinationContext:]):
3293         (-[WebFrame _drawRect:contentsOnly:]):
3294         * WebView/WebHTMLView.mm:
3295         (imageFromRect):
3296         (selectionImage):
3297
3298 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3299
3300         Add support for microtasks in workers
3301         https://bugs.webkit.org/show_bug.cgi?id=188246
3302
3303         Reviewed by Darin Adler.
3304
3305         Rename JSMainThreadExecState.h to JSExecState.h.
3306
3307         * DOM/DOMAttr.mm:
3308         * DOM/DOMBlob.mm:
3309         * DOM/DOMCDATASection.mm:
3310         * DOM/DOMCSSCharsetRule.mm:
3311         * DOM/DOMCSSFontFaceRule.mm:
3312         * DOM/DOMCSSImportRule.mm:
3313         * DOM/DOMCSSMediaRule.mm:
3314         * DOM/DOMCSSPageRule.mm:
3315         * DOM/DOMCSSPrimitiveValue.mm:
3316         * DOM/DOMCSSRule.mm:
3317         * DOM/DOMCSSRuleList.mm:
3318         * DOM/DOMCSSStyleDeclaration.mm:
3319         * DOM/DOMCSSStyleRule.mm:
3320         * DOM/DOMCSSStyleSheet.mm:
3321         * DOM/DOMCSSUnknownRule.mm:
3322         * DOM/DOMCSSValue.mm:
3323         * DOM/DOMCSSValueList.mm:
3324         * DOM/DOMCharacterData.mm:
3325         * DOM/DOMComment.mm:
3326         * DOM/DOMCounter.mm:
3327         * DOM/DOMDocument.mm:
3328         * DOM/DOMDocumentFragment.mm:
3329         * DOM/DOMDocumentType.mm:
3330         * DOM/DOMElement.mm:
3331         * DOM/DOMEvent.mm:
3332         * DOM/DOMFile.mm:
3333         * DOM/DOMFileList.mm:
3334         * DOM/DOMHTML.mm:
3335         * DOM/DOMHTMLAnchorElement.mm:
3336         * DOM/DOMHTMLAppletElement.mm:
3337         * DOM/DOMHTMLAreaElement.mm:
3338         * DOM/DOMHTMLBRElement.mm:
3339         * DOM/DOMHTMLBaseElement.mm:
3340         * DOM/DOMHTMLBaseFontElement.mm:
3341         * DOM/DOMHTMLBodyElement.mm:
3342         * DOM/DOMHTMLButtonElement.mm:
3343         * DOM/DOMHTMLCanvasElement.mm:
3344         * DOM/DOMHTMLCollection.mm:
3345         * DOM/DOMHTMLDListElement.mm:
3346         * DOM/DOMHTMLDirectoryElement.mm:
3347         * DOM/DOMHTMLDivElement.mm:
3348         * DOM/DOMHTMLDocument.mm:
3349         * DOM/DOMHTMLElement.mm:
3350         * DOM/DOMHTMLEmbedElement.mm:
3351         * DOM/DOMHTMLFieldSetElement.mm:
3352         * DOM/DOMHTMLFontElement.mm:
3353         * DOM/DOMHTMLFormElement.mm:
3354         * DOM/DOMHTMLFrameElement.mm:
3355         * DOM/DOMHTMLFrameSetElement.mm:
3356         * DOM/DOMHTMLHRElement.mm:
3357         * DOM/DOMHTMLHeadElement.mm:
3358         * DOM/DOMHTMLHeadingElement.mm:
3359         * DOM/DOMHTMLHtmlElement.mm:
3360         * DOM/DOMHTMLIFrameElement.mm:
3361         * DOM/DOMHTMLImageElement.mm:
3362         * DOM/DOMHTMLInputElement.mm:
3363         * DOM/DOMHTMLLIElement.mm:
3364         * DOM/DOMHTMLLabelElement.mm:
3365         * DOM/DOMHTMLLegendElement.mm:
3366         * DOM/DOMHTMLLinkElement.mm:
3367         * DOM/DOMHTMLMapElement.mm:
3368         * DOM/DOMHTMLMarqueeElement.mm:
3369         * DOM/DOMHTMLMediaElement.mm:
3370         * DOM/DOMHTMLMenuElement.mm:
3371         * DOM/DOMHTMLMetaElement.mm:
3372         * DOM/DOMHTMLModElement.mm:
3373         * DOM/DOMHTMLOListElement.mm:
3374         * DOM/DOMHTMLObjectElement.mm:
3375         * DOM/DOMHTMLOptGroupElement.mm:
3376         * DOM/DOMHTMLOptionElement.mm:
3377         * DOM/DOMHTMLOptionsCollection.mm:
3378         * DOM/DOMHTMLParagraphElement.mm:
3379         * DOM/DOMHTMLParamElement.mm:
3380         * DOM/DOMHTMLPreElement.mm:
3381         * DOM/DOMHTMLQuoteElement.mm:
3382         * DOM/DOMHTMLScriptElement.mm:
3383         * DOM/DOMHTMLSelectElement.mm:
3384         * DOM/DOMHTMLStyleElement.mm:
3385         * DOM/DOMHTMLTableCaptionElement.mm:
3386         * DOM/DOMHTMLTableCellElement.mm:
3387         * DOM/DOMHTMLTableColElement.mm:
3388         * DOM/DOMHTMLTableElement.mm:
3389         * DOM/DOMHTMLTableRowElement.mm:
3390         * DOM/DOMHTMLTableSectionElement.mm:
3391         * DOM/DOMHTMLTextAreaElement.mm:
3392         * DOM/DOMHTMLTitleElement.mm:
3393         * DOM/DOMHTMLUListElement.mm:
3394         * DOM/DOMHTMLVideoElement.mm:
3395         * DOM/DOMImplementation.mm:
3396         * DOM/DOMKeyboardEvent.mm:
3397         * DOM/DOMMediaError.mm:
3398         * DOM/DOMMediaList.mm:
3399         * DOM/DOMMouseEvent.mm:
3400         * DOM/DOMMutationEvent.mm:
3401         * DOM/DOMNamedNodeMap.mm:
3402         * DOM/DOMNode.mm:
3403         * DOM/DOMNodeIterator.mm:
3404         * DOM/DOMNodeList.mm:
3405         * DOM/DOMOverflowEvent.mm:
3406         * DOM/DOMProcessingInstruction.mm:
3407         * DOM/DOMProgressEvent.mm:
3408         * DOM/DOMRGBColor.mm:
3409         * DOM/DOMRange.mm:
3410         * DOM/DOMRect.mm:
3411         * DOM/DOMStyleSheet.mm:
3412         * DOM/DOMStyleSheetList.mm:
3413         * DOM/DOMText.mm:
3414         * DOM/DOMTextEvent.mm:
3415         * DOM/DOMTimeRanges.mm:
3416         * DOM/DOMTokenList.mm:
3417         * DOM/DOMTreeWalker.mm:
3418         * DOM/DOMUIEvent.mm:
3419         * DOM/DOMWheelEvent.mm:
3420         * DOM/DOMXPathExpression.mm:
3421         * DOM/DOMXPathResult.mm:
3422         * DOM/ObjCEventListener.mm:
3423
3424 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3425
3426         Fix spelling of "overridden"
3427         https://bugs.webkit.org/show_bug.cgi?id=188315
3428
3429         Reviewed by Darin Adler.
3430
3431         * Misc/WebKitVersionChecks.mm:
3432         (setWebKitLinkTimeVersion):
3433         (WebKitLinkTimeVersion):
3434         * Plugins/WebBaseNetscapePluginView.mm:
3435         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3436         * WebCoreSupport/PopupMenuMac.mm:
3437         (PopupMenuMac::populate):
3438
3439 2018-08-01  Nan Wang  <n_wang@apple.com>
3440
3441         AX: AOM: Add ARIA IDL Attribute Reflection
3442         https://bugs.webkit.org/show_bug.cgi?id=184676
3443         <rdar://problem/39476882>
3444
3445         Reviewed by Chris Fleizach.
3446
3447         * WebView/WebPreferenceKeysPrivate.h:
3448         * WebView/WebPreferences.mm:
3449         (+[WebPreferences initialize]):
3450         (-[WebPreferences ariaReflectionEnabled]):
3451         (-[WebPreferences setAriaReflectionEnabled:]):
3452         * WebView/WebPreferencesPrivate.h:
3453         * WebView/WebView.mm:
3454         (-[WebView _preferencesChanged:]):
3455
3456 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3457
3458         Shrink GraphicsLayerCA
3459         https://bugs.webkit.org/show_bug.cgi?id=188141
3460
3461         Reviewed by Zalan Bujtas.
3462
3463         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3464         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3465         * moving all the animation-related stuff into the lazily-allocated m_animations
3466         * making enums be 8-bit
3467         * re-ordering data members
3468
3469         * WebView/WebView.mm:
3470         (-[WebView _setMediaLayer:forPluginView:]):
3471
3472 2018-07-30  Rob Buis  <rbuis@igalia.com>
3473
3474         Merge PlatformCookieJar functions into NetworkStorageSession
3475         https://bugs.webkit.org/show_bug