662e3acd9d0328d6e229f252b589dfa27c3c6188
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-23  Tim Horton  <timothy_horton@apple.com>
2
3         Adopt WK_PLATFORM_NAME in WebKitLegacy
4         https://bugs.webkit.org/show_bug.cgi?id=183948
5         <rdar://problem/38803908>
6
7         Reviewed by Dan Bernstein.
8
9         * Configurations/WebKitLegacy.xcconfig:
10         * MigrateHeaders.make:
11         * postprocess-headers.sh:
12
13 2018-03-23  Brady Eidson  <beidson@apple.com>
14
15         Go to back/forward list items after a process-swapped navigation.
16         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
17
18         Reviewed by Andy Estes.
19
20         * WebView/WebView.mm:
21         (-[WebView _loadBackForwardListFromOtherView:]):
22         (-[WebView goToBackForwardItem:]):
23
24 2018-03-22  Tim Horton  <timothy_horton@apple.com>
25
26         Improve readability of WebCore's OTHER_LDFLAGS
27         https://bugs.webkit.org/show_bug.cgi?id=183909
28         <rdar://problem/38760992>
29
30         Reviewed by Dan Bernstein.
31
32         * Configurations/Base.xcconfig:
33         * Configurations/FeatureDefines.xcconfig:
34
35 2018-03-20  Tim Horton  <timothy_horton@apple.com>
36
37         Enable the minimal simulator feature flag when appropriate
38         https://bugs.webkit.org/show_bug.cgi?id=183807
39
40         Reviewed by Dan Bernstein.
41
42         * Configurations/FeatureDefines.xcconfig:
43
44 2018-03-20  Tim Horton  <timothy_horton@apple.com>
45
46         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
47         https://bugs.webkit.org/show_bug.cgi?id=183758
48         <rdar://problem/38017644>
49
50         Reviewed by Dan Bernstein.
51
52         * Configurations/FeatureDefines.xcconfig:
53
54 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
55
56         Clear style colors when setting default appearance
57         https://bugs.webkit.org/show_bug.cgi?id=183759
58
59         Reviewed by Tim Horton.
60
61         Colors are cached and need to be cleared and recalculated.
62         Refactor to do all style recalcs together.
63
64         * WebView/WebView.mm:
65         (-[WebView _setDefaultAppearanceAndClearStyle]):
66         (-[WebView _setUseSystemAppearance:]):
67         (-[WebView effectiveAppearanceDidChange]):
68
69 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
70
71         Unreviewed, another quick fix for r229699
72
73         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
74
75         * Configurations/FeatureDefines.xcconfig:
76
77 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
78
79         Ensure that style is updated when the effective appearance changes
80         https://bugs.webkit.org/show_bug.cgi?id=183690
81         <rdar://problem/38385900>
82
83         Reviewed by Tim Horton and Wenson Hsieh.
84
85         Respond to and respect the effective appearance changing.
86
87         * WebView/WebView.mm:
88         (-[WebView _setUseSystemAppearance:]):
89         (-[WebView effectiveAppearanceDidChange]):
90
91 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
92
93         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
94         https://bugs.webkit.org/show_bug.cgi?id=183677
95
96         Reviewed by Tim Horton.
97
98         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
99
100         * DOM/DOM.mm:
101         (-[DOMHTMLLinkElement _mediaQueryMatches]):
102
103 2018-03-14  Tim Horton  <timothy_horton@apple.com>
104
105         Fix the build after r229567
106
107         * Configurations/FeatureDefines.xcconfig:
108
109 2018-03-12  Tim Horton  <timothy_horton@apple.com>
110
111         Stop using SDK conditionals to control feature definitions
112         https://bugs.webkit.org/show_bug.cgi?id=183430
113         <rdar://problem/38251619>
114
115         Reviewed by Dan Bernstein.
116
117         * Configurations/FeatureDefines.xcconfig:
118         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
119
120 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
121
122         Runtime flag for link prefetch and remove link subresource.
123         https://bugs.webkit.org/show_bug.cgi?id=183540
124
125         Reviewed by Chris Dumez.
126
127         Remove the LINK_PREFETCH build time flag.
128
129         * Configurations/FeatureDefines.xcconfig:
130
131 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
132
133         Remove GridLayout runtime flag
134         https://bugs.webkit.org/show_bug.cgi?id=183484
135
136         Reviewed by Myles C. Maxfield.
137
138         The Grid Layout feature has been enabled by default for almost a
139         year, so I think it's time to remove the runtime flag and the
140
141         * WebView/WebPreferenceKeysPrivate.h:
142         * WebView/WebPreferences.mm:
143         (+[WebPreferences initialize]):
144         * WebView/WebPreferencesPrivate.h:
145         * WebView/WebView.mm:
146         (-[WebView _preferencesChanged:]):
147
148 2018-03-12  Antoine Quint  <graouts@apple.com>
149
150         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
151         https://bugs.webkit.org/show_bug.cgi?id=183504
152         <rdar://problem/38372965>
153
154         Reviewed by Dean Jackson and Jon Lee.
155
156         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
157         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
158
159         * WebView/WebPreferenceKeysPrivate.h:
160         * WebView/WebPreferences.mm:
161         (+[WebPreferences initialize]):
162         (-[WebPreferences setModernMediaControlsEnabled:]):
163         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
164         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
165         * WebView/WebPreferencesPrivate.h:
166         * WebView/WebView.mm:
167         (-[WebView _preferencesChanged:]):
168
169 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
170
171         Media query for default appearance
172         https://bugs.webkit.org/show_bug.cgi?id=183539
173         <rdar://problem/38326388>
174
175         Reviewed by Tim Horton.
176
177         Write a media query to evaluate appearance.
178
179         * WebView/WebView.mm:
180         (-[WebView _commonInitializationWithFrameName:groupName:]):
181         (-[WebView _setUseSystemAppearance:]):
182
183 2018-03-09  Andy Estes  <aestes@apple.com>
184
185         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
186         https://bugs.webkit.org/show_bug.cgi?id=183489
187         <rdar://problem/38267517>
188
189         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
190         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
191         to issue a sandbox extension for this directory, but for security reasons App Sandbox
192         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
193         block with a nil error and a valid file URL, but no file will actually exist at that URL.
194
195         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
196         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
197         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
198         drop destination.
199
200         Reviewed by Wenson Hsieh.
201
202         * WebView/WebView.mm:
203         (-[WebView performDragOperation:]):
204
205 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
206
207         Allow WebViews to disable system appearance
208         https://bugs.webkit.org/show_bug.cgi?id=183418
209         <rdar://problem/36975642>
210
211         Reviewed by Tim Horton.
212
213         Allow webviews to choose whether or not to follow the default system appearance.
214
215         * WebView/WebView.mm:
216         (-[WebView _setUseSystemAppearance:]):
217         (-[WebView _useSystemAppearance]):
218         * WebView/WebViewPrivate.h:
219
220 2018-03-08  Youenn Fablet  <youenn@apple.com>
221
222         libwebrtc update broke internal builds
223         https://bugs.webkit.org/show_bug.cgi?id=183454
224
225         Reviewed by Eric Carlson.
226
227         * Configurations/WebKitLegacy.xcconfig:
228
229 2018-03-08  Chris Dumez  <cdumez@apple.com>
230
231         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
232         https://bugs.webkit.org/show_bug.cgi?id=183455
233         <rdar://problem/38191749>
234
235         Reviewed by Youenn Fablet.
236
237         Add a null check for the page as we have evidence from crashes that it can be null.
238         Other functions in WebFrameNetworkingContext already null check the page as well,
239         not just the frame so this is consistent.
240
241         * WebCoreSupport/WebFrameNetworkingContext.mm:
242         (WebFrameNetworkingContext::storageSession const):
243
244 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
245
246         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
247         https://bugs.webkit.org/show_bug.cgi?id=183429
248
249         Reviewed by Mark Lam.
250
251         * DOM/DOM.mm:
252         (+[DOMNode _nodeFromJSWrapper:]):
253         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
254         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
255         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
256         * Plugins/Hosted/ProxyInstance.mm:
257         (WebKit::ProxyInstance::invokeMethod):
258         * WebView/WebView.mm:
259         (aeDescFromJSValue):
260
261 2018-03-08  Tim Horton  <timothy_horton@apple.com>
262
263         Stop linking ApplicationServices directly
264         https://bugs.webkit.org/show_bug.cgi?id=182867
265         <rdar://problem/38252142>
266
267         Reviewed by Alex Christensen.
268
269         The frameworks that we use that live inside ApplicationServices
270         have mostly moved out, so import them directly.
271
272         * Carbon/CarbonUtils.h:
273         * WebKitPrefix.h:
274         * WebView/WebHTMLView.mm:
275         * WebView/WebPDFView.mm:
276
277 2018-03-07  Tim Horton  <timothy_horton@apple.com>
278
279         Sort and separate FeatureDefines.xcconfig
280         https://bugs.webkit.org/show_bug.cgi?id=183427
281
282         Reviewed by Dan Bernstein.
283
284         * Configurations/FeatureDefines.xcconfig:
285         Sort and split FeatureDefines into paragraphs
286         (to make it easier to sort later).
287
288 2018-03-07  Youenn Fablet  <youenn@apple.com>
289
290         Match unsupported plugins based on domains and not origin
291         https://bugs.webkit.org/show_bug.cgi?id=183384
292
293         Reviewed by Chris Dumez.
294
295         * WebCoreSupport/WebPluginInfoProvider.h:
296         * WebCoreSupport/WebPluginInfoProvider.mm:
297         (WebPluginInfoProvider::getPluginInfo):
298         (WebPluginInfoProvider::getWebVisiblePluginInfo):
299
300 2018-03-05  Andy Estes  <aestes@apple.com>
301
302         [Mac] Teach WebCore::Pasteboard about file promise drags
303         https://bugs.webkit.org/show_bug.cgi?id=183314
304         <rdar://problem/38105493>
305
306         Reviewed by Darin Adler.
307
308         Added a FIXME comment.
309
310         * WebView/WebView.mm:
311         (-[WebView performDragOperation:]):
312
313 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
314
315         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
316         https://bugs.webkit.org/show_bug.cgi?id=183312
317
318         Reviewed by Mark Lam.
319
320         Remove wtf/CurrentTime.h include pragma.
321
322         * WebView/WebFrame.mm:
323         * WebView/WebPDFView.mm:
324
325 2018-03-04  Tim Horton  <timothy_horton@apple.com>
326
327         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
328         https://bugs.webkit.org/show_bug.cgi?id=183283
329         <rdar://problem/38062148>
330
331         Reviewed by Sam Weinig.
332
333         * Configurations/FeatureDefines.xcconfig:
334
335 2018-02-28  Alex Christensen  <achristensen@webkit.org>
336
337         Reduce use of NetworkingContext in WebKit
338         https://bugs.webkit.org/show_bug.cgi?id=183213
339
340         Reviewed by Brady Eidson.
341
342         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
343         (WebKit::NetscapePluginInstanceProxy::getProxy):
344         * Plugins/WebNetscapePluginView.mm:
345         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
346
347 2018-02-17  Darin Adler  <darin@apple.com>
348
349         Prepare for ExtendedColor changes (first step)
350         https://bugs.webkit.org/show_bug.cgi?id=182904
351
352         Reviewed by Sam Weinig.
353
354         * Misc/WebKitNSStringExtras.mm:
355         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
356
357 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
358
359         Remove currentTime() / currentTimeMS()
360         https://bugs.webkit.org/show_bug.cgi?id=183052
361
362         Reviewed by Mark Lam.
363
364         * WebCoreSupport/WebFrameLoaderClient.h:
365         * WebCoreSupport/WebFrameLoaderClient.mm:
366         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
367
368 2018-02-16  Youenn Fablet  <youenn@apple.com>
369
370         Allow specifying which plug-ins are supported
371         https://bugs.webkit.org/show_bug.cgi?id=182748
372
373         Reviewed by Chris Dumez.
374
375         * WebCoreSupport/WebPluginInfoProvider.h:
376         * WebCoreSupport/WebPluginInfoProvider.mm:
377         (WebPluginInfoProvider::getPluginInfo):
378         (WebPluginInfoProvider::getWebVisiblePluginInfo):
379
380 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
381
382         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
383         https://bugs.webkit.org/show_bug.cgi?id=182882
384         <rdar://problem/35672661>
385
386         Reviewed by Dan Bernstein.
387
388         Make sure the smart pointer hold the collection of subviews lives at least as
389         long as the loop using it.
390
391         * WebView/WebHTMLView.mm:
392         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
393
394 2018-02-14  Daniel Bates  <dabates@apple.com>
395
396         Disallow cross-origin subresources from asking for credentials
397         https://bugs.webkit.org/show_bug.cgi?id=182579
398         <rdar://problem/36162271>
399
400         Reviewed by Andy Estes.
401
402         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
403         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
404
405         * WebView/WebPreferenceKeysPrivate.h:
406         * WebView/WebPreferences.mm:
407         (+[WebPreferences initialize]):
408         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
409         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
410         * WebView/WebPreferencesPrivate.h:
411         * WebView/WebView.mm:
412         (-[WebView _preferencesChanged:]):
413
414 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
415
416         Remove ForwardingHeaders directory from WebKitLegacy/mac.
417         https://bugs.webkit.org/show_bug.cgi?id=182738
418
419         Reviewed by Darin Adler.
420
421         * ForwardingHeaders/collector/handles/Global.h: Removed.
422         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
423         * ForwardingHeaders/runtime/Completion.h: Removed.
424         * ForwardingHeaders/runtime/Error.h: Removed.
425         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
426         * ForwardingHeaders/runtime/JSFunction.h: Removed.
427         * ForwardingHeaders/runtime/JSLock.h: Removed.
428         * ForwardingHeaders/runtime/JSObject.h: Removed.
429         * ForwardingHeaders/runtime/JSString.h: Removed.
430         * ForwardingHeaders/runtime/Protect.h: Removed.
431         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
432
433 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
434
435         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
436         https://bugs.webkit.org/show_bug.cgi?id=182641
437
438         Reviewed by Dan Bernstein.
439
440         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
441         https://trac.webkit.org/changeset/228308.
442
443         * WebView/WebVideoFullscreenController.h:
444         * WebView/WebVideoFullscreenHUDWindowController.mm:
445         * WebView/WebWindowAnimation.h:
446         * WebView/WebWindowAnimation.mm:
447         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
448         (WebCore::scaledRect): Deleted.
449         (WebCore::squaredDistance): Deleted.
450
451 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
452
453         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
454
455         * WebView/WebWindowAnimation.mm:
456         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
457
458 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
459
460         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
461         https://bugs.webkit.org/show_bug.cgi?id=182615
462
463         Reviewed by Eric Carlson.
464
465         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
466         Ideally, we should not reference NSApp in WebCore.
467
468         * WebView/WebFullScreenController.mm:
469         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
470         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
471         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
472         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
473         * WebView/WebView.mm:
474         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
475         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
476
477 2018-01-13  Darin Adler  <darin@apple.com>
478
479         Event improvements
480         https://bugs.webkit.org/show_bug.cgi?id=179591
481
482         Reviewed by Chris Dumez.
483
484         * DOM/DOMWheelEvent.mm:
485         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
486         Call initWebKitWheelEvent.
487
488         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
489         * WebCoreSupport/WebInspectorClient.mm: Ditto.
490         * WebView/WebFrame.mm: Ditto.
491
492         * WebView/WebHTMLView.mm:
493         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
494         underlyingPlatformEvent.
495         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
496
497         * WebView/WebScriptWorld.mm:
498         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
499
500         * WebView/WebView.mm: Removed include of ScriptValue.h.
501
502 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
503
504         Remove WebCore/ForwardingHeaders directory
505         https://bugs.webkit.org/show_bug.cgi?id=182347
506
507         Reviewed by Keith Miller.
508
509         * Carbon/CarbonWindowAdapter.mm:
510         * DOM/WebDOMOperations.mm:
511         * History/WebBackForwardList.mm:
512         * History/WebHistoryItem.mm:
513         * Misc/WebCache.mm:
514         * Misc/WebElementDictionary.mm:
515         * Misc/WebIconDatabase.mm:
516         * Misc/WebStringTruncator.mm:
517         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
518         * Plugins/Hosted/ProxyInstance.mm:
519         * Plugins/Hosted/ProxyRuntimeObject.mm:
520         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
521         * Plugins/WebBaseNetscapePluginView.mm:
522         * Plugins/WebBasePluginPackage.mm:
523         * Plugins/WebNetscapePluginStream.mm:
524         * Plugins/WebNetscapePluginView.mm:
525         * Plugins/WebPluginController.mm:
526         * WebCoreSupport/WebEditorClient.mm:
527         * WebCoreSupport/WebFrameLoaderClient.mm:
528         * WebCoreSupport/WebInspectorClient.h:
529         * WebCoreSupport/WebInspectorClient.mm:
530         * WebView/WebDataSource.mm:
531         * WebView/WebFrame.mm:
532         * WebView/WebHTMLRepresentation.mm:
533         * WebView/WebHTMLView.mm:
534         * WebView/WebPreferences.mm:
535         * WebView/WebScriptDebugDelegate.mm:
536         * WebView/WebScriptDebugger.h:
537         * WebView/WebTextIterator.mm:
538         * WebView/WebView.mm:
539         * WebView/WebViewData.mm:
540
541 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
542
543         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
544         https://bugs.webkit.org/show_bug.cgi?id=182312
545
546         Reviewed by Michael Catanzaro.
547
548         * WebKitPrefix.h:
549
550 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
551
552         [WebAuthN] Add a compile-time feature flag
553         https://bugs.webkit.org/show_bug.cgi?id=182211
554         <rdar://problem/36936365>
555
556         Reviewed by Brent Fulgham.
557
558         * Configurations/FeatureDefines.xcconfig:
559
560 2018-01-27  Dan Bernstein  <mitz@apple.com>
561
562         HaveInternalSDK includes should be "#include?"
563         https://bugs.webkit.org/show_bug.cgi?id=179670
564
565         * Configurations/Base.xcconfig:
566
567 2018-01-24  Alex Christensen  <achristensen@webkit.org>
568
569         Remove unused QTKit preference
570         https://bugs.webkit.org/show_bug.cgi?id=181968
571
572         Reviewed by Alexey Proskuryakov.
573
574         * WebView/WebPreferenceKeysPrivate.h:
575         * WebView/WebPreferences.mm:
576         (+[WebPreferences initialize]):
577         (-[WebPreferences setQTKitEnabled:]): Deleted.
578         (-[WebPreferences isQTKitEnabled]): Deleted.
579         * WebView/WebPreferencesPrivate.h:
580         * WebView/WebView.mm:
581         (-[WebView _preferencesChanged:]):
582
583 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
584
585         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
586         https://bugs.webkit.org/show_bug.cgi?id=182037
587         <rdar://problem/36747812>
588
589         Reviewed by Ryosuke Niwa.
590
591         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
592         for more details.
593
594         * WebView/WebHTMLRepresentation.mm:
595         (-[WebHTMLRepresentation elementWithName:inForm:]):
596         (-[WebHTMLRepresentation controlsInForm:]):
597
598 2018-01-23  Alex Christensen  <achristensen@webkit.org>
599
600         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
601         https://bugs.webkit.org/show_bug.cgi?id=181961
602
603         Reviewed by Michael Catanzaro.
604
605         * WebView/WebPreferences.mm:
606
607 2018-01-23  Commit Queue  <commit-queue@webkit.org>
608
609         Unreviewed, rolling out r227437.
610         https://bugs.webkit.org/show_bug.cgi?id=182011
611
612         broke build (Requested by alexchristensen on #webkit).
613
614         Reverted changeset:
615
616         "Remove unused QTKit preference"
617         https://bugs.webkit.org/show_bug.cgi?id=181968
618         https://trac.webkit.org/changeset/227437
619
620 2018-01-23  Alex Christensen  <achristensen@webkit.org>
621
622         Remove unused QTKit preference
623         https://bugs.webkit.org/show_bug.cgi?id=181968
624
625         Reviewed by Alexey Proskuryakov.
626
627         * WebView/WebPreferenceKeysPrivate.h:
628         * WebView/WebPreferences.mm:
629         (+[WebPreferences initialize]):
630         (-[WebPreferences setQTKitEnabled:]): Deleted.
631         (-[WebPreferences isQTKitEnabled]): Deleted.
632         * WebView/WebPreferencesPrivate.h:
633         * WebView/WebView.mm:
634         (-[WebView _preferencesChanged:]):
635
636 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
637
638         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
639         https://bugs.webkit.org/show_bug.cgi?id=181960
640         <rdar://problem/36431678>
641
642         Reviewed by Tim Horton.
643
644         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
645         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
646         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
647
648         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
649         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
650         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
651
652         * WebView/WebView.mm:
653         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
654
655 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Turning off custom pasteboard data doesn't actually turn it off in WK2
658         https://bugs.webkit.org/show_bug.cgi?id=181920
659         <rdar://problem/36686429>
660
661         Reviewed by Wenson Hsieh.
662
663         Always disable custom pasteboard data in WebKit1. See r226156 for details.
664
665         * WebView/WebPreferences.mm:
666         (+[WebPreferences initialize]):
667         * WebView/WebView.mm:
668         (-[WebView _preferencesChanged:]):
669
670 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
671
672         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
673         https://bugs.webkit.org/show_bug.cgi?id=181918
674
675         Reviewed by Tim Horton.
676
677         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
678
679         * Configurations/FeatureDefines.xcconfig:
680
681 2018-01-20  Andy Estes  <aestes@apple.com>
682
683         [Apple Pay] Stop eagerly loading PassKit.framework
684         https://bugs.webkit.org/show_bug.cgi?id=181911
685         <rdar://problem/36555369>
686
687         Reviewed by Tim Horton.
688
689         * WebCoreSupport/WebPaymentCoordinatorClient.h:
690         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
691         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
692
693         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
694
695 2018-01-19  Dean Jackson  <dino@apple.com>
696
697         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
698         https://bugs.webkit.org/show_bug.cgi?id=181817
699         <rdar://problem/35274055>
700
701         Reviewed by Simon Fraser.
702
703         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
704
705         * Misc/WebKitVersionChecks.h:
706         * WebView/WebView.mm:
707         (-[WebView _commonInitializationWithFrameName:groupName:]):
708
709 2018-01-19  Alex Christensen  <achristensen@webkit.org>
710
711         Remove unused WebViewPrivate _allowCookies
712         https://bugs.webkit.org/show_bug.cgi?id=181812
713
714         Reviewed by Tim Horton.
715
716         * WebView/WebView.mm:
717         (+[WebView _setAllowCookies:]): Deleted.
718         (+[WebView _allowCookies]): Deleted.
719         * WebView/WebViewPrivate.h:
720
721 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
722
723         Build fix, remove a call to -[NSWindow setOneShot:]
724         https://bugs.webkit.org/show_bug.cgi?id=181809
725
726         Reviewed by Tim Horton.
727
728         * WebView/WebTextCompletionController.mm:
729         (-[WebTextCompletionController _buildUI]):
730
731 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
732
733         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
734
735         * Carbon/HIWebView.mm:
736         (overrideCGContext):
737         (restoreCGContext):
738
739 2018-01-18  Dan Bernstein  <mitz@apple.com>
740
741         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
742         https://bugs.webkit.org/show_bug.cgi?id=181803
743
744         Reviewed by Tim Horton.
745
746         * Configurations/Base.xcconfig: Updated.
747         * Configurations/DebugRelease.xcconfig: Ditto.
748         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
749         * Configurations/Version.xcconfig: Updated.
750         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
751           useful for defining settings that depend on the target macOS version.
752
753 2018-01-17  Youenn Fablet  <youenn@apple.com>
754
755         Put fetch Request.keepalive behind a runtime flag
756         https://bugs.webkit.org/show_bug.cgi?id=181592
757
758         Reviewed by Chris Dumez.
759
760         * WebView/WebPreferenceKeysPrivate.h:
761         * WebView/WebPreferences.mm:
762         (+[WebPreferences initialize]):
763         (-[WebPreferences fetchAPIKeepAliveEnabled]):
764         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
765         * WebView/WebPreferencesPrivate.h:
766         * WebView/WebView.mm:
767         (-[WebView _preferencesChanged:]):
768
769 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
770
771         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
772         https://bugs.webkit.org/show_bug.cgi?id=181637
773         <rdar://problem/36508471>
774
775         Reviewed by Tim Horton.
776
777         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
778
779         * WebCoreSupport/WebEditorClient.h:
780         * WebCoreSupport/WebEditorClient.mm:
781         (WebEditorClient::replacementURLForResource):
782
783 2018-01-11  Keith Miller  <keith_miller@apple.com>
784
785         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
786         https://bugs.webkit.org/show_bug.cgi?id=181573
787
788         Reviewed by Simon Fraser.
789
790         * Configurations/FeatureDefines.xcconfig:
791
792 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
793
794         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
795         https://bugs.webkit.org/show_bug.cgi?id=181497
796
797         Reviewed by Tim Horton.
798
799         See other ChangeLogs for more detail.
800
801         * WebCoreSupport/WebDragClient.h:
802
803 2018-01-11  Tim Horton  <timothy_horton@apple.com>
804
805         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
806         https://bugs.webkit.org/show_bug.cgi?id=181523
807         <rdar://problem/28959131>
808
809         Reviewed by Alex Christensen.
810
811         * WebView/WebImmediateActionController.mm:
812         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
813         Apply the change made in r216652 to WebKit1's immediate action controller.
814
815         Speculative (but successful in WebKit2) fix for non-reproducible crash when
816         the startContainer of the range is in an anonymous node.
817
818 2018-01-11  Youenn Fablet  <youenn@apple.com>
819
820         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
821         https://bugs.webkit.org/show_bug.cgi?id=181480
822
823         Reviewed by Eric Carlson.
824
825         * WebView/WebPreferences.mm:
826         (+[WebPreferences initialize]):
827
828 2018-01-08  David Kilzer  <ddkilzer@apple.com>
829
830         Fix check-webkit-style issues with WebNSDataExtras.mm
831         <https://webkit.org/b/181369>
832
833         Reviewed by Alex Christensen.
834
835         * Misc/WebNSDataExtras.mm:
836         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
837         (-[NSData _webkit_guessedMIMETypeForXML]):
838         (-[NSData _webkit_guessedMIMEType]):
839         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
840         (_findEOL):
841         (-[NSData _webkit_parseRFC822HeaderFields]):
842         (-[NSData _web_locationAfterFirstBlankLine]):
843         - Fix all the check-webkit-style warnings.
844
845 2018-01-08  David Kilzer  <ddkilzer@apple.com>
846
847         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
848         <https://webkit.org/b/181256>
849         <rdar://problem/36281730>
850
851         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
852         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
853         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
854           to avoid warnings from casting CFStringRef to NPNSString*.
855           Note that CFMutableStringRef is the same as CFStringRef
856           without the const modifier, hence its use in the const_cast<>
857           above.
858
859 2018-01-08  David Kilzer  <ddkilzer@apple.com>
860
861         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
862         <https://webkit.org/b/181256>
863         <rdar://problem/36281730>
864
865         * Carbon/HIWebView.mm:
866         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
867         checked_cf_cast<CFRunLoopRef>() to fix warning.
868
869 2018-01-07  David Kilzer  <ddkilzer@apple.com>
870
871         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
872         <https://webkit.org/b/181256>
873         <rdar://problem/36281730>
874
875         Reviewed by Darin Adler.
876
877         * Carbon/CarbonUtils.m:
878         (PoolCleaner):
879         - Use #pragmas to ignore -Wcast-qual warnings when using a
880           C-style cast from CFTypeRef to CFRunloopRef.
881         * Carbon/CarbonWindowFrame.m:
882         (-[CarbonWindowFrame title]):
883         - Use #pragmas to ignore -Wcast-qual warnings when using a
884           C-style cast from CFStringRef to NSString *.
885         * Carbon/HIViewAdapter.m:
886         (+[HIViewAdapter getHIViewForNSView:]):
887         - Use #pragmas to ignore -Wcast-qual warnings when using a
888           C-style cast from CFTypeRef to HIViewRef.
889         * Configurations/Base.xcconfig:
890         (WARNING_CFLAGS): Add -Wcast-qual.
891         * Misc/WebElementDictionary.mm:
892         (-[WebElementDictionary objectForKey:]):
893         - Use static_cast<SEL>(const_cast<void*>()) to fix
894           warning.
895         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
896         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
897         (-[NSData _webkit_guessedMIMETypeForXML]):
898         (-[NSData _webkit_guessedMIMEType]):
899         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
900         (_findEOL):
901         (-[NSData _webkit_parseRFC822HeaderFields]):
902         (-[NSData _web_startsWithBlankLine]):
903         (-[NSData _web_locationAfterFirstBlankLine]):
904         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
905           type to Objective-C++.  This fixes the warnings about
906           discarding the `const` modifier when casing from CFStringRef
907           to NSString * because in older clang versions, -Wcast-qual was
908           completely broken when compiling C++ and Objective-C++ source
909           files.  In newer clang versions, discarding the `const`
910           modifier for toll-free bridged types is ignored when compiling
911           Objective-C++ source.
912         - Update copyright and license header.
913         - Use reinterpret_cast<> and static_cast<> to fix warnings
914           unrelated to (NSString *) C-style casts.
915         - Replace use of MIN() macro with std::min<> template functions.
916         - Fix location of `*` for local variables modified above.
917         * Plugins/Hosted/NetscapePluginHostManager.mm:
918         (WebKit::NetscapePluginHostManager::spawnPluginHost):
919         (WebKit::NetscapePluginHostManager::initializeVendorPort):
920         (WebKit::NetscapePluginHostManager::instantiatePlugin):
921         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
922           warnings.
923         * Plugins/Hosted/NetscapePluginHostProxy.mm:
924         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
925         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
926           to fix warning.
927         * Plugins/Hosted/ProxyInstance.mm:
928         (WebKit::ProxyInstance::invoke):
929         - Use static_cast<char*>(const_cast<void*>()) to fix
930           warning when using -[NSData bytes].
931         (WebKit::ProxyInstance::fieldValue const):
932         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
933           to fix warning when using CFDataGetBytePtr().
934         * Plugins/Hosted/WebTextInputWindowController.m:
935         (-[WebTextInputPanel _interpretKeyEvent:string:]):
936         - Use #pragma to ignore -Wcast-qual warning since there
937           is not a good way to avoid this warning in Objective-C.
938         * Plugins/WebNetscapePluginStream.mm:
939         (WebNetscapePluginStream::deliverData):
940         - Use const_cast<void*>() to fix warning when using
941           -[NSData bytes].
942         * Plugins/WebNetscapePluginView.mm:
943         (-[WebNetscapePluginView _createPlugin]):
944         - Change C-style cast to const_cast<char*>() to fix
945           warning.
946         * WebCoreSupport/WebChromeClient.mm:
947         (WebChromeClient::wrapCryptoKey const):
948         (WebChromeClient::unwrapCryptoKey const):
949         - Change C-style cast to
950           static_cast<uint8_t*>(const_cast<void*>() to fix
951           warning.
952         * WebView/WebPDFView.mm:
953         (_applicationInfoForMIMEType):
954         - Change local variable type from 'NSURL *' to
955           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
956           when calling -[NSURL path].
957
958 2018-01-05  Dan Bernstein  <mitz@apple.com>
959
960         Fixed the build following AppKit API deprecations in a recent SDKs
961
962         * WebView/WebFullScreenController.mm:
963         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
964         (-[WebFullScreenController exitFullScreen]): Ditto.
965         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
966         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
967         * WebView/WebHTMLView.mm:
968         (-[WebHTMLView drawRect:]): Ditto.
969         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
970         (-[WebHTMLView knowsPageRange:]): Ditto.
971         * WebView/WebView.mm:
972         (LayerFlushController::flushLayers): Ditto.
973
974 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
975
976         [Attachment Support] Create attachment elements when dropping files on iOS
977         https://bugs.webkit.org/show_bug.cgi?id=181192
978         <rdar://problem/36280945>
979
980         Reviewed by Tim Horton.
981
982         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
983
984         * WebCoreSupport/WebPlatformStrategies.h:
985         * WebCoreSupport/WebPlatformStrategies.mm:
986         (WebPlatformStrategies::informationForItemAtIndex):
987         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
988
989 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
990
991         [Attachment Support] Add plumbing for starting a drag with promised blob data
992         https://bugs.webkit.org/show_bug.cgi?id=181201
993
994         Reviewed by Tim Horton.
995
996         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
997
998         * WebCoreSupport/WebDragClient.h:
999
1000 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1001
1002         Add a WebAuthentication runtime feature flag
1003         https://bugs.webkit.org/show_bug.cgi?id=181220
1004         <rdar://problem/36055305>
1005
1006         Reviewed by Brent Fulgham.
1007
1008         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1009
1010         * WebView/WebPreferenceKeysPrivate.h:
1011         * WebView/WebPreferences.mm:
1012         (+[WebPreferences initialize]):
1013         (-[WebPreferences webAuthenticationEnabled]):
1014         (-[WebPreferences setWebAuthenticationEnabled:]):
1015         (-[WebPreferences credentialManagementEnabled]): Deleted.
1016         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1017         * WebView/WebPreferencesPrivate.h:
1018         * WebView/WebView.mm:
1019         (-[WebView _preferencesChanged:]):
1020
1021 2017-12-22  Jeff Miller  <jeffm@apple.com>
1022
1023         Update user-visible copyright strings to include 2018
1024         https://bugs.webkit.org/show_bug.cgi?id=181141
1025
1026         Reviewed by Dan Bernstein.
1027
1028         * Info.plist:
1029
1030 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1033         https://bugs.webkit.org/show_bug.cgi?id=181188
1034
1035         Reviewed by Dan Bernstein.
1036
1037         See WebCore/ChangeLog for more detail.
1038
1039         * WebCoreSupport/WebDragClient.h:
1040         * WebCoreSupport/WebDragClient.mm:
1041         (WebDragClient::declareAndWriteAttachment): Deleted.
1042         * WebView/WebHTMLView.mm:
1043         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1044
1045 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1046
1047         Unreviewed, continue to fix build failures due to AppKit API deprecation
1048
1049         Wraps more code in -Wdeprecated-declarations.
1050
1051         * Carbon/HIWebView.mm:
1052         (overrideCGContext):
1053
1054 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1055
1056         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1057
1058         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1059
1060         * Carbon/CarbonWindowAdapter.mm:
1061         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1062         * Plugins/WebNetscapePluginView.mm:
1063         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1064         (-[WebNetscapePluginView sendDrawRectEvent:]):
1065         (-[WebNetscapePluginView drawRect:]):
1066
1067 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1068
1069         Fix build failures due to using deprecated AppKit symbols
1070         https://bugs.webkit.org/show_bug.cgi?id=181110
1071         <rdar://problem/36162865>
1072
1073         Reviewed by Dan Bernstein and Tim Horton.
1074
1075         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1076
1077         * Misc/WebKitNSStringExtras.mm:
1078         (-[NSString _web_drawAtPoint:font:textColor:]):
1079         * Misc/WebNSPasteboardExtras.h:
1080         * Misc/WebNSPasteboardExtras.mm:
1081         (+[NSPasteboard _web_writableTypesForURL]):
1082         (_createWritableTypesForImageWithoutArchive):
1083         (_createWritableTypesForImageWithArchive):
1084         (+[NSPasteboard _web_dragTypesForURL]):
1085         (-[NSPasteboard _web_bestURL]):
1086         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1087         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1088         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1089         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1090         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1091         * Panels/WebAuthenticationPanel.m:
1092         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1093         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1094         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1095         (-[WebHostedNetscapePluginView drawRect:]):
1096         * WebInspector/WebNodeHighlightView.mm:
1097         (-[WebNodeHighlightView drawRect:]):
1098         * WebView/WebFrame.mm:
1099         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1100         (-[WebFrame _drawRect:contentsOnly:]):
1101         * WebView/WebHTMLView.mm:
1102         (kit):
1103         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1104         (-[WebHTMLView _plainTextFromPasteboard:]):
1105         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1106         (+[WebHTMLView _insertablePasteboardTypes]):
1107         (+[WebHTMLView _selectionPasteboardTypes]):
1108         (-[WebHTMLView pasteboard:provideDataForType:]):
1109         (-[WebHTMLView _writeSelectionToPasteboard:]):
1110         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1111         (-[WebHTMLView validRequestorForSendType:returnType:]):
1112         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1113         (createMenuItem):
1114         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1115         (-[WebHTMLView _colorAsString:]):
1116         (-[WebHTMLView copyFont:]):
1117         * WebView/WebPDFView.mm:
1118         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1119         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1120         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1121         (-[WebPDFView pasteboardTypesForSelection]):
1122         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1123         * WebView/WebView.h:
1124         * WebView/WebView.mm:
1125         (-[WebView performDragOperation:]):
1126         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1127         (-[WebView _searchWithGoogleFromMenu:]):
1128
1129 2017-12-21  Youenn Fablet  <youenn@apple.com>
1130
1131         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1132         https://bugs.webkit.org/show_bug.cgi?id=181000
1133
1134         Reviewed by Chris Dumez.
1135
1136         * Misc/WebCache.mm:
1137         (+[WebCache addImageToCache:forURL:forFrame:]):
1138
1139 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1140
1141         Update FULLSCREEN_API feature defines.
1142         https://bugs.webkit.org/show_bug.cgi?id=181015
1143
1144         Reviewed by Tim Horton.
1145
1146         Change enabled iphone sdk for FULLSCREEN_API.
1147
1148         * Configurations/FeatureDefines.xcconfig:
1149
1150 2017-12-21  Jer Noble  <jer.noble@apple.com>
1151
1152         Add initial DOM support for Media Capabilities
1153         https://bugs.webkit.org/show_bug.cgi?id=181064
1154
1155         Reviewed by Eric Carlson.
1156
1157         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1158
1159         * WebView/WebPreferenceKeysPrivate.h:
1160         * WebView/WebPreferences.mm:
1161         (+[WebPreferences initialize]):
1162         (-[WebPreferences mediaCapabilitiesEnabled]):
1163         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1164         * WebView/WebPreferencesPrivate.h:
1165         * WebView/WebView.mm:
1166         (-[WebView _preferencesChanged:]):
1167
1168 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1169
1170         Enable picture-in-picture from inline element on suspend.
1171         https://bugs.webkit.org/show_bug.cgi?id=180942
1172         rdar://problem/34745234
1173
1174         Reviewed by Jer Noble.
1175
1176         Update signature of enterVideoFullscreenForVideoElement().
1177
1178         * WebCoreSupport/WebChromeClient.h:
1179         * WebCoreSupport/WebChromeClient.mm:
1180         (WebChromeClient::enterVideoFullscreenForVideoElement):
1181
1182 2017-12-20  Daniel Bates  <dabates@apple.com>
1183
1184         Remove Alternative Presentation Button
1185         https://bugs.webkit.org/show_bug.cgi?id=180500
1186         <rdar://problem/35891047>
1187
1188         Reviewed by Simon Fraser.
1189
1190         We no longer need the alternative presentation button.
1191
1192         * Configurations/FeatureDefines.xcconfig:
1193
1194 2017-12-19  Jer Noble  <jer.noble@apple.com>
1195
1196         Playing media elements which call "pause(); play()" will have the play promise rejected.
1197         https://bugs.webkit.org/show_bug.cgi?id=180781
1198         <rdar://problem/33191377>
1199
1200         Reviewed by Eric Carlson.
1201
1202         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1203
1204         * WebView/WebView.mm:
1205         (shouldRequireUserGestureToLoadVideo):
1206
1207 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1208
1209         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1210         https://bugs.webkit.org/show_bug.cgi?id=180977
1211
1212         Reviewed by Tim Horton.
1213
1214         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1215         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1216         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1217
1218         * WebCoreSupport/WebEditorClient.mm:
1219         (attributesForAttributedStringConversion):
1220         * WebView/WebHTMLView.mm:
1221         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1222
1223 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1224
1225         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1226
1227         Attempt to fix the following warnings:
1228
1229             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1230
1231         For the following instance variables:
1232
1233             _borderView
1234             _contentView
1235             _frame
1236             _wFlags
1237
1238         * Carbon/CarbonWindowAdapter.mm:
1239         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1240         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1241         (-[CarbonWindowAdapter _termWindowIfOwner]):
1242         (-[CarbonWindowAdapter _windowMovedToRect:]):
1243         (-[CarbonWindowAdapter setContentView:]):
1244         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1245         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1246
1247 2017-12-16  Dan Bernstein  <mitz@apple.com>
1248
1249         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1250         https://bugs.webkit.org/show_bug.cgi?id=180613
1251         <rdar://problem/35946124>
1252
1253         Reviewed by Geoff Garen.
1254
1255         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1256           clients.
1257         * WebView/WebDynamicScrollBarsView.h: Ditto.
1258         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1259
1260 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1261
1262         Enable -Wstrict-prototypes for WebKit
1263         <https://webkit.org/b/180757>
1264         <rdar://problem/36024132>
1265
1266         Rubber-stamped by Joseph Pecoraro.
1267
1268         * Configurations/Base.xcconfig:
1269         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1270
1271 2017-12-14  John Wilander  <wilander@apple.com>
1272
1273         Storage Access API: Implement frame-specific access in the document.cookie layer
1274         https://bugs.webkit.org/show_bug.cgi?id=180682
1275         <rdar://problem/35982257>
1276
1277         Reviewed by Alex Christensen.
1278
1279         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1280         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1281         CookiesStrategy::getRawCookies() now take optional parameters for
1282         frameID and pageID to allow frame-specific scoping of cookies.
1283
1284         This change makes the return values of FrameLoaderClient::frameID()
1285         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1286         WebCore can call those getters and get the right return values in
1287         WebKit and std:nullopt in WebKitLegacy.
1288
1289         * WebCoreSupport/WebFrameLoaderClient.h:
1290         * WebCoreSupport/WebFrameLoaderClient.mm:
1291         (WebFrameLoaderClient::pageID const):
1292         (WebFrameLoaderClient::frameID const):
1293         * WebCoreSupport/WebPlatformStrategies.h:
1294         * WebCoreSupport/WebPlatformStrategies.mm:
1295         (WebPlatformStrategies::cookiesForDOM):
1296         (WebPlatformStrategies::setCookiesFromDOM):
1297         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1298         (WebPlatformStrategies::getRawCookies):
1299
1300 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1301
1302         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1303         https://bugs.webkit.org/show_bug.cgi?id=180689
1304
1305         Reviewed by Tim Horton.
1306
1307         Use sRGBColorSpaceRef() from WebCore.
1308
1309         * WebView/WebHTMLView.mm:
1310         (imageFromRect):
1311
1312 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1313
1314         Stop using deprecated target conditional for simulator builds
1315         https://bugs.webkit.org/show_bug.cgi?id=180662
1316         <rdar://problem/35136156>
1317
1318         Reviewed by Simon Fraser.
1319
1320         * postprocess-headers.sh:
1321
1322 2017-12-11  David Quesada  <david_quesada@apple.com>
1323
1324         Turn on ENABLE_APPLICATION_MANIFEST
1325         https://bugs.webkit.org/show_bug.cgi?id=180562
1326         rdar://problem/35924737
1327
1328         Reviewed by Geoffrey Garen.
1329
1330         * Configurations/FeatureDefines.xcconfig:
1331
1332 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1333
1334         Remove pthread_once in favor of dispatch_once
1335         https://bugs.webkit.org/show_bug.cgi?id=180591
1336
1337         Reviewed by Saam Barati.
1338
1339         * Misc/WebKitErrors.m:
1340         (+[NSError _registerWebKitErrors]):
1341         (registerErrors): Deleted.
1342         * Storage/WebStorageManager.mm:
1343         (+[WebStorageManager _storageDirectoryPath]):
1344         (initializeLocalStoragePath): Deleted.
1345
1346 2017-12-07  Darin Adler  <darin@apple.com>
1347
1348         Remove some unused code from WebKitLegacy
1349         https://bugs.webkit.org/show_bug.cgi?id=180567
1350
1351         Reviewed by Anders Carlsson.
1352
1353         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1354         macOS (back a few versions) and iOS and removed unused
1355         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1356         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1357         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1358         _webkit_stringByCollapsingNonPrintingCharacters,
1359         _webkit_stringByCollapsingWhitespaceCharacters,
1360         _web_stringWithData:textEncodingName:, and
1361         _webkit_localStorageDirectoryWithBundleIdentifier:.
1362
1363         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1364         this source file.
1365         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1366         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1367         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1368         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1369         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1370         handle font smoothing options.
1371         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1372         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1373         from header and made it a little clearer.
1374         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1375         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1376         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1377         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1378         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1379         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1380         implementation a bit and used whole words instead of abbreviations.
1381         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1382
1383         * Misc/WebNSFileManagerExtras.mm:
1384         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1385         filenameByFixingIllegalCharacters function from WebCore directly instead of
1386         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1387
1388         * Plugins/WebBaseNetscapePluginView.mm:
1389         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1390         string replacements instead of _web_stringByStrippingReturnCharacters
1391         and to use NSString methods instead of CFString functions.
1392
1393 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1394
1395         Ignore deprecation warnings.
1396
1397         * WebView/WebHTMLView.mm:
1398         (-[NSWindow _web_borderView]):
1399         (-[WebHTMLView _setAsideSubviews]):
1400         * WebView/WebView.mm:
1401         (-[WebView encodeWithCoder:]):
1402
1403 2017-12-02  Darin Adler  <darin@apple.com>
1404
1405         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1406         https://bugs.webkit.org/show_bug.cgi?id=180009
1407
1408         Reviewed by Alex Christensen.
1409
1410         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1411
1412         * Plugins/WebBaseNetscapePluginView.mm:
1413         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1414         of strcasecmp.
1415
1416         * WebView/WebPreferences.mm:
1417         (contains): Ditto. Also made this a template so it's easier to call on an array.
1418         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1419
1420 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1421
1422         Limit user agent versioning to an upper bound
1423         https://bugs.webkit.org/show_bug.cgi?id=180365
1424         <rdar://problem/34550617>
1425
1426         Reviewed by Joseph Pecoraro.
1427
1428         * WebView/WebView.mm:
1429         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1430         creating the User Agent string.
1431         (webKitBundleVersionString): Deleted.
1432
1433 2017-12-05  Andy Estes  <aestes@apple.com>
1434
1435         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1436         https://bugs.webkit.org/show_bug.cgi?id=180457
1437         <rdar://problem/35143007>
1438
1439         Reviewed by Tim Horton.
1440
1441         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1442         check for this macro during post-processing.
1443
1444         * postprocess-headers.sh:
1445
1446 2017-12-04  David Quesada  <david_quesada@apple.com>
1447
1448         Add a class for parsing application manifests
1449         https://bugs.webkit.org/show_bug.cgi?id=177973
1450         rdar://problem/34747949
1451
1452         Reviewed by Geoffrey Garen.
1453
1454         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1455
1456 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1457
1458         Make LegacyCustomProtocolManager optional for network process
1459         https://bugs.webkit.org/show_bug.cgi?id=176230
1460
1461         Reviewed by Alex Christensen.
1462
1463         * Configurations/FeatureDefines.xcconfig:
1464
1465 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1466
1467         Fix some NSOperationQueue leaks
1468         https://bugs.webkit.org/show_bug.cgi?id=180221
1469
1470         Reviewed by Wenson Hsieh.
1471
1472         * WebView/WebView.mm:
1473         (-[WebView performDragOperation:]):
1474
1475 2017-11-30  Darin Adler  <darin@apple.com>
1476
1477         [Mac] remove unneeded RetainPtr use introduced in r225142
1478         https://bugs.webkit.org/show_bug.cgi?id=180202
1479
1480         Reviewed by Tim Horton.
1481
1482         * WebView/WebImmediateActionController.mm:
1483         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1484         RetainPtr.
1485
1486 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1487
1488         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1489         https://bugs.webkit.org/show_bug.cgi?id=175595
1490
1491         Reviewed by Darin Adler.
1492
1493         * WebView/WebPreferences.mm:
1494
1495 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1496
1497         One too many zeroes in macOS version number in FeatureDefines
1498         https://bugs.webkit.org/show_bug.cgi?id=180011
1499
1500         Reviewed by Dan Bernstein.
1501
1502         * Configurations/FeatureDefines.xcconfig:
1503
1504 2017-11-23  Darin Adler  <darin@apple.com>
1505
1506         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1507         https://bugs.webkit.org/show_bug.cgi?id=179981
1508
1509         Reviewed by Sam Weinig.
1510
1511         * WebView/WebImmediateActionController.mm:
1512         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1513         * WebView/WebView.mm:
1514         (coreOptions): Use |= instead of | to build up FindOptions.
1515
1516 2017-11-23  Sam Weinig  <sam@webkit.org>
1517
1518         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1519         https://bugs.webkit.org/show_bug.cgi?id=179954
1520
1521         Reviewed by Darin Adler.
1522
1523         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1524         with direct calls to the corresponding UserGestureIndicator functions.
1525
1526         * Plugins/WebPluginController.mm:
1527         (-[WebPluginController processingUserGesture]):
1528         * WebView/WebView.mm:
1529         (-[WebView _isProcessingUserGesture]):
1530
1531 2017-11-23  Darin Adler  <darin@apple.com>
1532
1533         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1534         https://bugs.webkit.org/show_bug.cgi?id=179907
1535
1536         Reviewed by Sam Weinig.
1537
1538         * History/BinaryPropertyList.cpp:
1539         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1540         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1541         * WebView/WebHTMLRepresentation.mm:
1542         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1543         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1544
1545 2017-11-22  Ali Juma  <ajuma@chromium.org>
1546
1547         Implement VisualViewport API attributes
1548         https://bugs.webkit.org/show_bug.cgi?id=179385
1549
1550         Reviewed by Frédéric Wang.
1551
1552         Add a VisualViewportAPI preference.
1553
1554         * WebView/WebPreferenceKeysPrivate.h:
1555         * WebView/WebPreferences.mm:
1556         (+[WebPreferences initialize]):
1557         (-[WebPreferences visualViewportAPIEnabled]):
1558         (-[WebPreferences setVisualViewportAPIEnabled:]):
1559         * WebView/WebPreferencesPrivate.h:
1560         * WebView/WebView.mm:
1561         (-[WebView _preferencesChanged:]):
1562
1563 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1564
1565         WebCoreObjCExtras.h is being included in too many places
1566         https://bugs.webkit.org/show_bug.cgi?id=179931
1567
1568         Reviewed by Darin Adler.
1569
1570         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1571         * Plugins/WebBaseNetscapePluginView.mm:
1572         * Plugins/WebBasePluginPackage.mm:
1573         * Plugins/WebNetscapePluginStream.mm:
1574         * Plugins/WebNetscapePluginView.mm:
1575         * WebView/WebTextIterator.mm:
1576         * WebView/WebViewData.mm:
1577
1578 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1579
1580         Unreviewed, rolling out r225093.
1581         https://bugs.webkit.org/show_bug.cgi?id=179938
1582
1583         Compilation failed on WinCairo 64-bit Release (Requested by
1584         fredw on #webkit).
1585
1586         Reverted changeset:
1587
1588         "Implement VisualViewport API attributes"
1589         https://bugs.webkit.org/show_bug.cgi?id=179385
1590         https://trac.webkit.org/changeset/225093
1591
1592 2017-11-21  Ali Juma  <ajuma@chromium.org>
1593
1594         Implement VisualViewport API attributes
1595         https://bugs.webkit.org/show_bug.cgi?id=179385
1596
1597         Reviewed by Frédéric Wang.
1598
1599         Add a VisualViewportAPI preference.
1600
1601         * WebView/WebPreferenceKeysPrivate.h:
1602         * WebView/WebPreferences.mm:
1603         (+[WebPreferences initialize]):
1604         (-[WebPreferences visualViewportAPIEnabled]):
1605         (-[WebPreferences setVisualViewportAPIEnabled:]):
1606         * WebView/WebPreferencesPrivate.h:
1607         * WebView/WebView.mm:
1608         (-[WebView _preferencesChanged:]):
1609
1610 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1611
1612         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1613         https://bugs.webkit.org/show_bug.cgi?id=179504
1614
1615         Reviewed by Darin Adler.
1616
1617         * Misc/WebKitNSStringExtras.mm:
1618         * Plugins/Hosted/NetscapePluginHostManager.mm:
1619         * Plugins/WebBasePluginPackage.mm:
1620
1621 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1622
1623         Remove unused TOUCH_ICON_LOADING feature flag
1624         https://bugs.webkit.org/show_bug.cgi?id=179873
1625
1626         Reviewed by Simon Fraser.
1627
1628         * Configurations/FeatureDefines.xcconfig:
1629
1630 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1631
1632         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1633         https://bugs.webkit.org/show_bug.cgi?id=179872
1634
1635         Reviewed by Darin Adler.
1636
1637         * Configurations/FeatureDefines.xcconfig:
1638
1639 2017-11-16  Daniel Bates  <dabates@apple.com>
1640
1641         Add feature define for alternative presentation button element
1642         https://bugs.webkit.org/show_bug.cgi?id=179692
1643         Part of <rdar://problem/34917108>
1644
1645         Reviewed by Andy Estes.
1646
1647         Only enabled on Cocoa platforms by default.
1648
1649         * Configurations/FeatureDefines.xcconfig:
1650
1651 2017-11-14  Nan Wang  <n_wang@apple.com>
1652
1653         AX: AOM: Implement AccessibleNode class and support label and role attributes
1654         https://bugs.webkit.org/show_bug.cgi?id=179494
1655
1656         Reviewed by Ryosuke Niwa.
1657
1658         * WebView/WebPreferenceKeysPrivate.h:
1659         * WebView/WebPreferences.mm:
1660         (+[WebPreferences initialize]):
1661         (-[WebPreferences accessibilityObjectModelEnabled]):
1662         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1663         * WebView/WebPreferencesPrivate.h:
1664         * WebView/WebView.mm:
1665         (-[WebView _preferencesChanged:]):
1666
1667 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1668
1669         Remove Cocoa CFURLConnection loading code
1670         https://bugs.webkit.org/show_bug.cgi?id=179688
1671
1672         Reviewed by Antti Koivisto.
1673
1674         * Misc/WebDownload.mm:
1675         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1676         * Misc/WebDownloadInternal.h:
1677         * Plugins/WebBaseNetscapePluginView.mm:
1678         * WebCoreSupport/WebFrameLoaderClient.mm:
1679         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1680         * WebView/WebView.mm:
1681         (-[WebView scheduleInRunLoop:forMode:]):
1682         (-[WebView unscheduleFromRunLoop:forMode:]):
1683
1684 2017-11-14  Daniel Bates  <dabates@apple.com>
1685
1686         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1687         for feature defines
1688
1689         Following r195498 and r201917 the Visual Studio property files for feature defines have
1690         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1691         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1692         files.
1693
1694         * Configurations/FeatureDefines.xcconfig:
1695
1696 2017-11-14  Jer Noble  <jer.noble@apple.com>
1697
1698         Enable Modern EME tests in DumpRenderTree
1699         https://bugs.webkit.org/show_bug.cgi?id=179544
1700
1701         Reviewed by Alex Christensen.
1702
1703         Add a WebPreferences property to enable the (modern) EME API.
1704
1705         * WebView/WebPreferenceKeysPrivate.h:
1706         * WebView/WebPreferences.mm:
1707         (+[WebPreferences initialize]):
1708         (-[WebPreferences encryptedMediaAPIEnabled]):
1709         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1710         * WebView/WebPreferencesPrivate.h:
1711         * WebView/WebView.mm:
1712         (-[WebView _preferencesChanged:]):
1713
1714 2017-11-14  Antti Koivisto  <antti@apple.com>
1715
1716         Enable display:contents by default
1717         https://bugs.webkit.org/show_bug.cgi?id=179655
1718
1719         Reviewed by Sam Weinig.
1720
1721         * WebView/WebPreferences.mm:
1722         (+[WebPreferences initialize]):
1723
1724 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1725
1726         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1727         https://bugs.webkit.org/show_bug.cgi?id=178751
1728
1729         Reviewed by Brady Eidson.
1730
1731         * WebCoreSupport/WebFrameNetworkingContext.mm:
1732         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1733
1734 2017-11-08  Keith Miller  <keith_miller@apple.com>
1735
1736         Async iteration should only fetch the next method once and add feature flag
1737         https://bugs.webkit.org/show_bug.cgi?id=179451
1738
1739         Reviewed by Geoffrey Garen.
1740
1741         Add feature flag for Async iteration.
1742
1743         * Configurations/FeatureDefines.xcconfig:
1744
1745 2017-11-13  Mark Lam  <mark.lam@apple.com>
1746
1747         Add more overflow check book-keeping for MarkedArgumentBuffer.
1748         https://bugs.webkit.org/show_bug.cgi?id=179634
1749         <rdar://problem/35492517>
1750
1751         Reviewed by Saam Barati.
1752
1753         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1754         (WebKit::NetscapePluginInstanceProxy::invoke):
1755         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1756         (WebKit::NetscapePluginInstanceProxy::construct):
1757
1758 2017-11-12  Darin Adler  <darin@apple.com>
1759
1760         More is<> and downcast<>, less static_cast<>
1761         https://bugs.webkit.org/show_bug.cgi?id=179600
1762
1763         Reviewed by Chris Dumez.
1764
1765         * DOM/DOM.mm:
1766         (kit): Use is/downcast.
1767         * WebCoreSupport/WebEditorClient.mm:
1768         (WebEditorClient::handleKeyboardEvent): Ditto.
1769         (WebEditorClient::handleInputMethodKeydown): Ditto.
1770         * WebView/WebHTMLView.mm:
1771         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1772
1773 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1774
1775         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1776         https://bugs.webkit.org/show_bug.cgi?id=179397
1777
1778         Reviewed by Wenson Hsieh.
1779
1780         * DOM/DOMHTMLInputElement.mm:
1781         (-[DOMHTMLInputElement insertTextSuggestion:]):
1782
1783 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1784
1785         HTMLMediaElement should not use element fullscreen on iOS
1786         https://bugs.webkit.org/show_bug.cgi?id=179418
1787         rdar://problem/35409277
1788
1789         Reviewed by Eric Carlson.
1790
1791         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1792
1793         * Configurations/FeatureDefines.xcconfig:
1794
1795 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1796
1797         Make ResourceLoader::willSendRequestInternal asynchronous
1798         https://bugs.webkit.org/show_bug.cgi?id=179251
1799
1800         Reviewed by Andy Estes.
1801
1802         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1803         (WebKit::HostedNetscapePluginStream::start):
1804         * Plugins/WebNetscapePluginStream.mm:
1805         (WebNetscapePluginStream::start):
1806
1807 2017-11-01  Darin Adler  <darin@apple.com>
1808
1809         Simplify event dispatch code and make it a bit more consistent
1810         https://bugs.webkit.org/show_bug.cgi?id=178991
1811
1812         Reviewed by Chris Dumez.
1813
1814         * DOM/DOMEvent.mm:
1815         (-[DOMEvent srcElement]): Call target instead of srcElement.
1816
1817 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1818
1819         [Touch Bar Web API] Add support for menuitem tag
1820         https://bugs.webkit.org/show_bug.cgi?id=179020
1821
1822         Reviewed by Ryosuke Niwa.
1823
1824         Adds in properties and methods that allow the menuitem runtime feature
1825         to be enabled or disabled.
1826
1827         * WebView/WebPreferenceKeysPrivate.h:
1828         * WebView/WebPreferences.mm:
1829         (-[WebPreferences menuItemElementEnabled]):
1830         (-[WebPreferences setMenuItemElementEnabled:]):
1831         * WebView/WebPreferencesPrivate.h:
1832         * WebView/WebView.mm:
1833         (-[WebView _preferencesChanged:]):
1834
1835 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1836
1837         Use CompletionHandlers for redirects
1838         https://bugs.webkit.org/show_bug.cgi?id=179163
1839
1840         Reviewed by Tim Horton.
1841
1842         * Plugins/Hosted/HostedNetscapePluginStream.h:
1843         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1844         (WebKit::HostedNetscapePluginStream::willSendRequest):
1845         * Plugins/WebNetscapePluginStream.h:
1846         * Plugins/WebNetscapePluginStream.mm:
1847         (WebNetscapePluginStream::willSendRequest):
1848
1849 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1850
1851         Add a FileSystem namespace to FileSystem.cpp
1852         https://bugs.webkit.org/show_bug.cgi?id=179063
1853
1854         Reviewed by Darin Adler.
1855
1856         * Misc/WebNSFileManagerExtras.mm:
1857         * Storage/WebDatabaseProvider.mm:
1858
1859 2017-11-02  Frederic Wang  <fwang@igalia.com>
1860
1861         Add references to bug 179167 in FIXME comments
1862         https://bugs.webkit.org/show_bug.cgi?id=179168
1863
1864         Reviewed by Daniel Bates.
1865
1866         * Configurations/FeatureDefines.xcconfig:
1867
1868 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1869
1870         Implement WKFullscreenWindowController for iOS.
1871         https://bugs.webkit.org/show_bug.cgi?id=178924
1872         rdar://problem/34697120
1873
1874         Reviewed by Simon Fraser.
1875
1876         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1877
1878         * Configurations/FeatureDefines.xcconfig:
1879         * WebView/WebView.mm:
1880         (-[WebView fullScreenPlaceholderView]):
1881
1882 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1883
1884         Clean up some drag and drop feature flags
1885         https://bugs.webkit.org/show_bug.cgi?id=179082
1886
1887         Reviewed by Simon Fraser.
1888
1889         * Configurations/FeatureDefines.xcconfig:
1890
1891 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1892
1893         Make it possible to test rubber-banding in overflow scroll
1894         https://bugs.webkit.org/show_bug.cgi?id=179078
1895
1896         Reviewed by Sam Weinig.
1897
1898         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1899         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1900
1901         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1902         functions, since most callers want clamped.
1903
1904         * DOM/DOMHTML.mm:
1905         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1906
1907 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1908
1909         Fix up some content filtering feature flags
1910         https://bugs.webkit.org/show_bug.cgi?id=179079
1911
1912         Reviewed by Simon Fraser.
1913
1914         * Configurations/FeatureDefines.xcconfig:
1915
1916 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1917
1918         [FrameView::layout cleanup] Move core layout logic to a separate class.
1919         https://bugs.webkit.org/show_bug.cgi?id=178771
1920         <rdar://problem/35166542>
1921
1922         Reviewed by Simon Fraser.
1923
1924         Move layout code out from FrameView to LayoutContext.
1925
1926         * WebView/WebClipView.mm:
1927         (-[WebClipView _immediateScrollToPoint:]):
1928         * WebView/WebFrame.mm:
1929         (-[WebFrame layoutCount]):
1930
1931 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1932
1933         Fix issues with WebView subframe painting
1934         https://bugs.webkit.org/show_bug.cgi?id=178842
1935         rdar://problem/34072253
1936
1937         Reviewed by Daniel Bates.
1938         
1939         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1940         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1941         High Sierra, so match the new signature.
1942
1943         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1944
1945         * WebView/WebHTMLView.mm:
1946         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1947         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1948
1949 2017-10-25  Youenn Fablet  <youenn@apple.com>
1950
1951         Enable ServiceWorker to fetch resources
1952         https://bugs.webkit.org/show_bug.cgi?id=178673
1953
1954         Reviewed by Brady Eidson.
1955
1956         * WebCoreSupport/WebFrameLoaderClient.mm:
1957         (WebFrameLoaderClient::pageID const):
1958         (WebFrameLoaderClient::frameID const):
1959         (WebFrameLoaderClient::sessionID const):
1960
1961         Added implementation to the new getters.
1962         They are noop in the context of WK1.
1963
1964 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1965
1966         Web Inspector: Enable WebKit logging configuration and display
1967         https://bugs.webkit.org/show_bug.cgi?id=177027
1968         <rdar://problem/33964767>
1969
1970         Reviewed by Joseph Pecoraro.
1971
1972         * WebCoreSupport/WebChromeClient.mm:
1973         (stringForMessageSource): Deal with Media and WebRTC message sources.
1974
1975 2017-10-20  Antoine Quint  <graouts@apple.com>
1976
1977         [Web Animations] Provide basic timeline and animation interfaces
1978         https://bugs.webkit.org/show_bug.cgi?id=178526
1979
1980         Reviewed by Dean Jackson.
1981
1982         Remove the WEB_ANIMATIONS compile-time flag.
1983
1984         * Configurations/FeatureDefines.xcconfig:
1985         * WebView/WebPreferences.mm:
1986         (+[WebPreferences initialize]):
1987         * WebView/WebView.mm:
1988         (-[WebView _preferencesChanged:]):
1989
1990 2017-10-19  Sam Weinig  <sam@webkit.org>
1991
1992         [Settings] Move global settings into their own file
1993         https://bugs.webkit.org/show_bug.cgi?id=178512
1994
1995         Reviewed by Darin Adler.
1996
1997         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1998
1999         * WebCoreSupport/WebChromeClient.mm:
2000         (WebChromeClient::supportsVideoFullscreen):
2001         * WebView/WebDynamicScrollBarsView.mm:
2002         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2003         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2004         * WebView/WebPreferences.mm:
2005         (+[WebPreferences initialize]):
2006         * WebView/WebView.mm:
2007         (-[WebView _commonInitializationWithFrameName:groupName:]):
2008         (-[WebView _preferencesChanged:]):
2009         (+[WebView _doNotStartObservingNetworkReachability]):
2010
2011 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2012
2013         Replace some stack raw pointers with RefPtrs within WebCore/html
2014         https://bugs.webkit.org/show_bug.cgi?id=178201
2015         <rdar://problem/34841692>
2016
2017         Reviewed by Ryosuke Niwa.
2018
2019         * DOM/DOM.mm:
2020         (kit):
2021         Change the type of node as toNode() is changed to return RefPtr.
2022
2023 2017-10-18  Chris Dumez  <cdumez@apple.com>
2024
2025         [Service Worker] Add stubs for Client / WindowClient / Clients
2026         https://bugs.webkit.org/show_bug.cgi?id=178469
2027
2028         Reviewed by Youenn Fablet.
2029
2030         Rename PageVisiblityState to VisibilityState.
2031
2032         * WebView/WebView.mm:
2033         (kit):
2034
2035 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Unreviewed, rolling out r223291.
2038
2039         See WebCore ChangeLog for more detail.
2040
2041         Reverted changeset:
2042
2043         "Remove Editor::simplifyMarkup"
2044         https://bugs.webkit.org/show_bug.cgi?id=178271
2045         https://trac.webkit.org/changeset/223291
2046
2047 2017-10-17  Keith Miller  <keith_miller@apple.com>
2048
2049         Change WebCore sources to work with unified source builds
2050         https://bugs.webkit.org/show_bug.cgi?id=178229
2051
2052         Rubber stamped by Tim Horton.
2053
2054         * Configurations/FeatureDefines.xcconfig:
2055
2056 2017-10-16  Sam Weinig  <sam@webkit.org>
2057
2058         [Settings] Remove all custom code from Settings.h/cpp
2059         https://bugs.webkit.org/show_bug.cgi?id=178330
2060
2061         Reviewed by Simon Fraser.
2062
2063         * WebView/WebPreferences.mm:
2064         (+[WebPreferences initialize]):
2065         
2066             Update for naming changes of FrameFlattening now that it is an enum class.
2067
2068 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2069
2070         Remove Editor::simplifyMarkup
2071         https://bugs.webkit.org/show_bug.cgi?id=178271
2072
2073         Reviewed by Wenson Hsieh.
2074
2075         * WebView/WebView.mm:
2076         (-[WebView _simplifyMarkup:endNode:]):
2077
2078 2017-10-12  Chris Dumez  <cdumez@apple.com>
2079
2080         [Mac] Add support for MouseEvent.buttons
2081         https://bugs.webkit.org/show_bug.cgi?id=178214
2082
2083         Reviewed by Ryosuke Niwa.
2084
2085         * WebView/WebPDFView.mm:
2086         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2087
2088 2017-10-11  Sam Weinig  <sam@webkit.org>
2089
2090         Remove out-parameter variants of copyToVector
2091         https://bugs.webkit.org/show_bug.cgi?id=178155
2092
2093         Reviewed by Tim Horton.
2094
2095         * Plugins/WebNetscapePluginView.mm:
2096         (-[WebNetscapePluginView destroyPlugin]):
2097         * WebView/WebHTMLRepresentation.mm:
2098         (newArrayWithStrings):
2099
2100             Replace out-parameter based copyToVector, with one that returns a Vector.
2101
2102 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2103
2104         Sanitize URL in pasteboard for other applications and cross origin content
2105         https://bugs.webkit.org/show_bug.cgi?id=178060
2106         <rdar://problem/34874518>
2107
2108         Reviewed by Wenson Hsieh.
2109
2110         * WebCoreSupport/WebPlatformStrategies.h:
2111         * WebCoreSupport/WebPlatformStrategies.mm:
2112         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2113
2114 2017-10-11  Chris Dumez  <cdumez@apple.com>
2115
2116         Modernize Geolocation code
2117         https://bugs.webkit.org/show_bug.cgi?id=178148
2118
2119         Reviewed by Ryosuke Niwa.
2120
2121         * WebCoreSupport/WebGeolocationClient.h:
2122         * WebCoreSupport/WebGeolocationClient.mm:
2123         (WebGeolocationClient::lastPosition):
2124         * WebView/WebGeolocationPosition.mm:
2125         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2126         (core):
2127         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2128         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2129         * WebView/WebGeolocationPositionInternal.h:
2130
2131 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2134         https://bugs.webkit.org/show_bug.cgi?id=178154
2135
2136         Reviewed by Wenson Hsieh.
2137
2138         Enable custom pasteboard data by default.
2139
2140         * WebView/WebPreferenceKeysPrivate.h:
2141         * WebView/WebPreferences.mm:
2142         (+[WebPreferences initialize]):
2143         (-[WebPreferences customPasteboardDataEnabled]): Added.
2144         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2145         * WebView/WebPreferencesPrivate.h:
2146         * WebView/WebView.mm:
2147         (-[WebView _preferencesChanged:]):
2148
2149 2017-10-10  Sam Weinig  <sam@webkit.org>
2150
2151         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2152         https://bugs.webkit.org/show_bug.cgi?id=178102
2153
2154         Reviewed by Tim Horton.
2155
2156         * History/WebHistory.mm:
2157         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2158         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2159         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2160         * WebCoreSupport/WebUserMediaClient.mm:
2161         (WebUserMediaClient::pageDestroyed):
2162
2163 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2164
2165         Make the names of the options consistent
2166         https://bugs.webkit.org/show_bug.cgi?id=177933
2167
2168         Reviewed by Saam Barati.
2169
2170         * WebView/WebFrame.h:
2171         * WebView/WebHTMLView.mm:
2172         (-[WebHTMLView setMarkedText:selectedRange:]):
2173         * WebView/WebView.h:
2174
2175 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2176
2177         [iOS] Tweak support for classifying form controls (followup to r222487)
2178         https://bugs.webkit.org/show_bug.cgi?id=177917
2179         <rdar://problem/34820122>
2180
2181         Reviewed by Dean Jackson.
2182
2183         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2184
2185         * DOM/DOMHTMLInputElement.mm:
2186         (-[DOMHTMLInputElement _autofillContext]):
2187         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2188         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2189
2190 2017-10-05  Keith Miller  <keith_miller@apple.com>
2191
2192         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2193
2194         * Configurations/WebKitLegacy.xcconfig:
2195
2196 2017-10-05  Jer Noble  <jer.noble@apple.com>
2197
2198         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2199         https://bugs.webkit.org/show_bug.cgi?id=177261
2200
2201         Reviewed by Eric Carlson.
2202
2203         * Configurations/FeatureDefines.xcconfig:
2204
2205 2017-10-05  Chris Dumez  <cdumez@apple.com>
2206
2207         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2208         https://bugs.webkit.org/show_bug.cgi?id=177957
2209
2210         Reviewed by Alex Christensen.
2211
2212         * WebCoreSupport/WebPlatformStrategies.h:
2213         * WebCoreSupport/WebPlatformStrategies.mm:
2214         (WebPlatformStrategies::cookiesEnabled):
2215
2216 2017-10-05  Youenn Fablet  <youenn@apple.com>
2217
2218         Make LibWebRTCProvider port agnostic
2219         https://bugs.webkit.org/show_bug.cgi?id=177747
2220
2221         Reviewed by Alex Christensen & Alex Garcia.
2222
2223         * WebView/WebView.mm:
2224         (-[WebView _commonInitializationWithFrameName:groupName:]):
2225         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2226
2227 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2228
2229         Stop linking with WebKitSystemInterface
2230         https://bugs.webkit.org/show_bug.cgi?id=177915
2231
2232         Reviewed by Antti Koivisto.
2233
2234         * Configurations/DebugRelease.xcconfig:
2235         * Configurations/WebKitLegacy.xcconfig:
2236
2237 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2238
2239         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2240         https://bugs.webkit.org/show_bug.cgi?id=177912
2241
2242         Reviewed by Saam Barati.
2243
2244         * Carbon/CarbonUtils.m:
2245         * Carbon/CarbonWindowAdapter.mm:
2246         * Carbon/HIWebView.mm:
2247         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2248         * Misc/WebNSFileManagerExtras.mm:
2249         * Misc/WebNSPasteboardExtras.mm:
2250         * Misc/WebNSURLExtras.mm:
2251         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2252         * Plugins/Hosted/NetscapePluginHostManager.mm:
2253         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2254         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2255         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2256         * Plugins/Hosted/WebTextInputWindowController.m:
2257         * Plugins/WebBaseNetscapePluginView.mm:
2258         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2259         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2260         * Plugins/WebNetscapePluginStream.mm:
2261         * Plugins/WebNetscapePluginView.mm:
2262         * Plugins/WebPluginDatabase.mm:
2263         * WebCoreSupport/PopupMenuMac.mm:
2264         * WebCoreSupport/WebChromeClient.mm:
2265         * WebCoreSupport/WebFrameLoaderClient.mm:
2266         * WebCoreSupport/WebInspectorClient.mm:
2267         * WebCoreSupport/WebPlatformStrategies.mm:
2268         * WebCoreSupport/WebSystemInterface.mm:
2269         * WebView/WebDynamicScrollBarsView.mm:
2270         * WebView/WebFrame.mm:
2271         * WebView/WebFrameView.mm:
2272         * WebView/WebFullScreenController.mm:
2273         * WebView/WebHTMLView.mm:
2274         * WebView/WebPreferences.mm:
2275         * WebView/WebView.mm:
2276
2277 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2278
2279         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2280         rdar://problem/34705779
2281
2282         Addressing review comments that I somehow landed without.
2283
2284         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2285
2286 2017-09-29  Chris Dumez  <cdumez@apple.com>
2287
2288         Split some logic out of VisitedLinkStore and make it reusable
2289         https://bugs.webkit.org/show_bug.cgi?id=177575
2290
2291         Reviewed by Alex Christensen.
2292
2293         * WebCoreSupport/WebVisitedLinkStore.h:
2294         * WebCoreSupport/WebVisitedLinkStore.mm:
2295         (WebVisitedLinkStore::addVisitedLink):
2296         (WebVisitedLinkStore::removeVisitedLink):
2297         (WebVisitedLinkStore::isLinkVisited):
2298         (WebVisitedLinkStore::addVisitedLinkHash):
2299
2300 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2301
2302         Build fix for High Sierra 32 bit Mac
2303         https://bugs.webkit.org/show_bug.cgi?id=177551
2304         <rdar://problem/34690283>
2305
2306         Reviewed by Alexey Proskuryakov.
2307
2308         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2309         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2310         also made.
2311
2312         * Carbon/CarbonWindowAdapter.mm:
2313         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2314         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2315         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2316         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2317         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2318         (-[CarbonWindowAdapter dealloc]):
2319         (-[CarbonWindowAdapter windowRef]):
2320         (-[CarbonWindowAdapter _hasWindowRef]):
2321         (-[CarbonWindowAdapter _managesWindowRef]):
2322         (-[CarbonWindowAdapter _removeWindowRef]):
2323         (-[CarbonWindowAdapter _carbonWindowClass]):
2324         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2325         (-[CarbonWindowAdapter sendSuperEvent:]):
2326         (-[CarbonWindowAdapter relinquishFocus]):
2327         (-[CarbonWindowAdapter _cancelKey:]):
2328         (-[CarbonWindowAdapter _commonAwake]):
2329         (-[CarbonWindowAdapter _destroyRealWindow:]):
2330         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2331         (-[CarbonWindowAdapter _termWindowIfOwner]):
2332         (-[CarbonWindowAdapter _windowMovedToRect:]):
2333         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2334         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2335         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2336         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2337         (-[CarbonWindowAdapter canBecomeMainWindow]):
2338         (-[CarbonWindowAdapter encodeWithCoder:]):
2339         (-[CarbonWindowAdapter initWithCoder:]):
2340         (-[CarbonWindowAdapter setContentView:]):
2341         (-[CarbonWindowAdapter worksWhenModal]):
2342         (-[CarbonWindowAdapter _setModalWindowLevel]):
2343         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2344         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2345         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2346         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2347         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2348         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2349         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2350         (NSCarbonWindowHandleEvent):
2351         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2352         (-[CarbonWindowAdapter _growBoxRect]):
2353         * Carbon/HIWebView.mm:
2354         (HIWebViewGetWebView):
2355         (HIWebViewConstructor):
2356         (HIWebViewDestructor):
2357         (HIWebViewRegisterClass):
2358         (GetBehaviors):
2359         (Draw):
2360         (HitTest):
2361         (GetRegion):
2362         (GetWindowRef):
2363         (CreateNSEventAdoptingCGEvent):
2364         (CopyEventCGEvent):
2365         (CreateNSEventWithCarbonClickEvent):
2366         (Click):
2367         (CreateNSEventWithCarbonEvent):
2368         (MouseUp):
2369         (CreateNSEventWithCarbonMouseMoveEvent):
2370         (MouseMoved):
2371         (MouseDragged):
2372         (MouseWheelMoved):
2373         (ContextMenuClick):
2374         (GetKind):
2375         (BoundsChanged):
2376         (OwningWindowChanged):
2377         (WindowHandler):
2378         (SyncFrame):
2379         (SetFocusPart):
2380         (AdvanceFocus):
2381         (RelinquishFocus):
2382         (ActiveStateChanged):
2383         (ProcessCommand):
2384         (UpdateCommandStatus):
2385         (_NSSelectorForHICommand):
2386         (HIWebViewEventHandler):
2387         (StartUpdateObserver):
2388         (StopUpdateObserver):
2389         (UpdateObserver):
2390
2391 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2392
2393         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2394         https://bugs.webkit.org/show_bug.cgi?id=172526
2395         <rdar://problem/32396081>
2396
2397         Reviewed by Ryosuke Niwa.
2398
2399         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2400
2401         * WebCoreSupport/WebPlatformStrategies.h:
2402         * WebCoreSupport/WebPlatformStrategies.mm:
2403         (WebPlatformStrategies::webExposedTypes):
2404         (WebPlatformStrategies::writeCustomData):
2405
2406 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2407
2408         Unreviewed, rolling out r222567.
2409
2410         This broke and internal build.
2411
2412         Reverted changeset:
2413
2414         "Build fix for High Sierra 32 bit Mac"
2415         https://bugs.webkit.org/show_bug.cgi?id=177551
2416         http://trac.webkit.org/changeset/222567
2417
2418 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2419
2420         Build fix for High Sierra 32 bit Mac
2421         https://bugs.webkit.org/show_bug.cgi?id=177551
2422         <rdar://problem/34690283>
2423
2424         Reviewed by Alexey Proskuryakov.
2425
2426         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2427         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2428         also made.
2429
2430         * Carbon/CarbonWindowAdapter.mm:
2431         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2432         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2433         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2434         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2435         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2436         (-[CarbonWindowAdapter dealloc]):
2437         (-[CarbonWindowAdapter windowRef]):
2438         (-[CarbonWindowAdapter _hasWindowRef]):
2439         (-[CarbonWindowAdapter _managesWindowRef]):
2440         (-[CarbonWindowAdapter _removeWindowRef]):
2441         (-[CarbonWindowAdapter _carbonWindowClass]):
2442         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2443         (-[CarbonWindowAdapter sendSuperEvent:]):
2444         (-[CarbonWindowAdapter relinquishFocus]):
2445         (-[CarbonWindowAdapter _cancelKey:]):
2446         (-[CarbonWindowAdapter _commonAwake]):
2447         (-[CarbonWindowAdapter _destroyRealWindow:]):
2448         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2449         (-[CarbonWindowAdapter _termWindowIfOwner]):
2450         (-[CarbonWindowAdapter _windowMovedToRect:]):
2451         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2452         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2453         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2454         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2455         (-[CarbonWindowAdapter canBecomeMainWindow]):
2456         (-[CarbonWindowAdapter encodeWithCoder:]):
2457         (-[CarbonWindowAdapter initWithCoder:]):
2458         (-[CarbonWindowAdapter setContentView:]):
2459         (-[CarbonWindowAdapter worksWhenModal]):
2460         (-[CarbonWindowAdapter _setModalWindowLevel]):
2461         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2462         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2463         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2464         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2465         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2466         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2467         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2468         (NSCarbonWindowHandleEvent):
2469         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2470         (-[CarbonWindowAdapter _growBoxRect]):
2471         * Carbon/HIWebView.mm:
2472         (HIWebViewGetWebView):
2473         (HIWebViewConstructor):
2474         (HIWebViewDestructor):
2475         (HIWebViewRegisterClass):
2476         (GetBehaviors):
2477         (Draw):
2478         (HitTest):
2479         (GetRegion):
2480         (GetWindowRef):
2481         (CreateNSEventAdoptingCGEvent):
2482         (CopyEventCGEvent):
2483         (CreateNSEventWithCarbonClickEvent):
2484         (Click):
2485         (CreateNSEventWithCarbonEvent):
2486         (MouseUp):
2487         (CreateNSEventWithCarbonMouseMoveEvent):
2488         (MouseMoved):
2489         (MouseDragged):
2490         (MouseWheelMoved):
2491         (ContextMenuClick):
2492         (GetKind):
2493         (BoundsChanged):
2494         (OwningWindowChanged):
2495         (WindowHandler):
2496         (SyncFrame):
2497         (SetFocusPart):
2498         (AdvanceFocus):
2499         (RelinquishFocus):
2500         (ActiveStateChanged):
2501         (ProcessCommand):
2502         (UpdateCommandStatus):
2503         (_NSSelectorForHICommand):
2504         (HIWebViewEventHandler):
2505         (StartUpdateObserver):
2506         (StopUpdateObserver):
2507         (UpdateObserver):
2508
2509 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2510
2511         Make PolicyAction an encodable enum class
2512         https://bugs.webkit.org/show_bug.cgi?id=177480
2513
2514         Reviewed by Antti Koivisto.
2515
2516         * Plugins/WebPluginContainerCheck.mm:
2517         (-[WebPluginContainerCheck _continueWithPolicy:]):
2518         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2519         * WebCoreSupport/WebFrameLoaderClient.mm:
2520         (-[WebFramePolicyListener invalidate]):
2521         (-[WebFramePolicyListener ignore]):
2522         (-[WebFramePolicyListener download]):
2523         (-[WebFramePolicyListener use]):
2524         (-[WebFramePolicyListener continue]):
2525         * WebView/WebPolicyDelegate.mm:
2526         (-[WebPolicyDecisionListener use]):
2527         (-[WebPolicyDecisionListener ignore]):
2528         (-[WebPolicyDecisionListener download]):
2529
2530 2017-09-25  Frederik Riedel  <riedel@apple.com>
2531
2532         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2533         https://bugs.webkit.org/show_bug.cgi?id=174394
2534         <rdar://problem/33183504>
2535
2536         Reviewed by Ryosuke Niwa.
2537
2538         * DOM/DOMHTMLInputElement.h:
2539         * DOM/DOMHTMLInputElement.mm:
2540         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2541         Determines if this HTMLInputElement is part of a login screen.
2542         (-[DOMHTMLInputElement representingPageUrl]):
2543         Returns the webpage's URL that is currently displayed in the Web View.
2544         (-[DOMHTMLInputElement insertTextSuggestion:]):
2545         Inserts login credentials into the Web View.
2546
2547 2017-09-25  Sam Weinig  <sam@webkit.org>
2548
2549         Remove unused EditorClient functions
2550         https://bugs.webkit.org/show_bug.cgi?id=177463
2551
2552         Reviewed by Alex Christensen.
2553
2554         Remove unused EditorClient functions.
2555
2556         * WebCoreSupport/WebEditorClient.h:
2557         * WebCoreSupport/WebEditorClient.mm:
2558         (WebEditorClient::canonicalizeURL): Deleted.
2559         (WebEditorClient::canonicalizeURLString): Deleted.
2560         (WebEditorClient::writeDataToPasteboard): Deleted.
2561         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2562         (WebEditorClient::readDataFromPasteboard): Deleted.
2563         (WebEditorClient::pasteboardChangeCount): Deleted.
2564
2565 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2566
2567         Stop using PolicyCallback
2568         https://bugs.webkit.org/show_bug.cgi?id=176088
2569
2570         Reviewed by Andy Estes.
2571
2572         * WebCoreSupport/WebFrameLoaderClient.mm:
2573         (-[WebFramePolicyListener invalidate]):
2574         (-[WebFramePolicyListener receivedPolicyDecision:]):
2575
2576 2017-09-25  Sam Weinig  <sam@webkit.org>
2577
2578         Remove unnecessary userVisibleString EditorClient function
2579         https://bugs.webkit.org/show_bug.cgi?id=177456
2580
2581         Reviewed by Dan Bernstein.
2582
2583         * WebCoreSupport/WebEditorClient.h:
2584         * WebCoreSupport/WebEditorClient.mm:
2585         (WebEditorClient::userVisibleString): Deleted.
2586
2587             Remove userVisibleString client function.
2588
2589 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2590
2591         Separate form submission from PolicyChecker infrastructure
2592         https://bugs.webkit.org/show_bug.cgi?id=177396
2593
2594         Reviewed by Geoffrey Garen.
2595
2596         * WebCoreSupport/WebFrameLoaderClient.h:
2597         * WebCoreSupport/WebFrameLoaderClient.mm:
2598         (WebFrameLoaderClient::dispatchWillSubmitForm):
2599
2600 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2601
2602         WeakPtrFactory should populate m_ref lazily.
2603         https://bugs.webkit.org/show_bug.cgi?id=177375
2604
2605         Reviewed by Geoffrey Garen.
2606
2607         * WebCoreSupport/WebEditorClient.mm:
2608         (WebEditorClient::WebEditorClient):
2609         (WebEditorClient::requestCandidatesForSelection):
2610
2611 2017-09-22  Chris Dumez  <cdumez@apple.com>
2612
2613         Use high resolution timestamp for event time
2614         https://bugs.webkit.org/show_bug.cgi?id=154246
2615         <rdar://problem/34333304>
2616
2617         Reviewed by Ryosuke Niwa.
2618
2619         Use WallTime / MonotonicTime instead of double type for clarity.
2620
2621         * DOM/DOMEvent.mm:
2622         (-[DOMEvent timeStamp]):
2623         * WebView/WebFrame.mm:
2624         (-[WebFrame _dragSourceEndedAt:operation:]):
2625         * WebView/WebPDFView.mm:
2626         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2627
2628 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2629
2630         Enable dataTransfer.items on macOS and iOS
2631         https://bugs.webkit.org/show_bug.cgi?id=177335
2632
2633         Reviewed by Sam Weinig.
2634
2635         * WebView/WebPreferences.mm:
2636         (+[WebPreferences initialize]):
2637
2638 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2639
2640         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2641         https://bugs.webkit.org/show_bug.cgi?id=177101
2642         <rdar://problem/34500648>
2643
2644         Reviewed by Brian Burg.
2645
2646         * WebInspector/WebNodeHighlight.mm:
2647         Ensure we close the window that we have just removed.
2648
2649 2017-09-20  Antti Koivisto  <antti@apple.com>
2650
2651         Remove DOM and styling support for CSS Regions
2652         https://bugs.webkit.org/show_bug.cgi?id=177221
2653
2654         Reviewed by Andreas Kling.
2655
2656         * Configurations/FeatureDefines.xcconfig:
2657         * DOM/DOMCSS.mm:
2658         (kitClass):
2659         * DOM/DOMElement.mm:
2660         (-[DOMElement webkitRegionOverset]): Deleted.
2661
2662 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2663
2664         Layering violation in Editor::createFragment
2665         https://bugs.webkit.org/show_bug.cgi?id=176123
2666
2667         Reviewed by Darin Adler.
2668
2669         * Misc/WebNSURLExtras.h:
2670         * Misc/WebNSURLExtras.mm:
2671         * WebView/WebFrame.mm:
2672         * WebView/WebHTMLView.mm:
2673         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2674
2675         * WebCoreSupport/WebEditorClient.mm:
2676         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2677         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2678         way to avoid exporting the symbol just on newer OSes.
2679
2680 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2681
2682         On iOS, getData can't get text set by setData during copy event
2683         https://bugs.webkit.org/show_bug.cgi?id=176980
2684         <rdar://problem/34453915>
2685
2686         Reviewed by Darin Adler.
2687
2688         * WebCoreSupport/WebPlatformStrategies.h:
2689         * WebCoreSupport/WebPlatformStrategies.mm:
2690         (WebPlatformStrategies::copy): Deleted.
2691
2692 2017-09-18  Andy Estes  <aestes@apple.com>
2693
2694         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2695         https://bugs.webkit.org/show_bug.cgi?id=177029
2696
2697         Reviewed by Alex Christensen.
2698
2699         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2700         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2701         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2702         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2703         * WebCoreSupport/PopupMenuMac.mm:
2704         (PopupMenuMac::show):
2705         * WebCoreSupport/WebSystemInterface.mm:
2706         (InitWebCoreSystemInterface):
2707         * WebView/WebHTMLView.mm:
2708         (-[WebHTMLView setDataSource:]):
2709         (-[WebHTMLView attachRootLayer:]):
2710         * WebView/WebView.mm:
2711         (-[WebView _needsAdobeFrameReloadingQuirk]):
2712         (-[WebView _needsLinkElementTextCSSQuirk]):
2713         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2714         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2715         (-[WebView _preferencesChanged:]):
2716
2717 2017-09-15  Andy Estes  <aestes@apple.com>
2718
2719         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2720         https://bugs.webkit.org/show_bug.cgi?id=176953
2721
2722         Reviewed by Eric Carlson.
2723
2724         * WebCoreSupport/WebSystemInterface.mm:
2725         (InitWebCoreSystemInterface):
2726
2727 2017-09-14  Andy Estes  <aestes@apple.com>
2728
2729         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2730         https://bugs.webkit.org/show_bug.cgi?id=176931
2731
2732         Reviewed by Joseph Pecoraro.
2733
2734         * WebCoreSupport/WebSystemInterface.mm:
2735         (InitWebCoreSystemInterface):
2736
2737 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2738
2739         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2740         https://bugs.webkit.org/show_bug.cgi?id=176867
2741
2742         Reviewed by Sam Weinig.
2743
2744         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2745         (WebKit::NetscapePluginInstanceProxy::enumerate):
2746
2747 2017-09-13  Andy Estes  <aestes@apple.com>
2748
2749         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2750         https://bugs.webkit.org/show_bug.cgi?id=176729
2751
2752         Reviewed by Alex Christensen.
2753
2754         * WebCoreSupport/WebSystemInterface.mm:
2755         (InitWebCoreSystemInterface):
2756         * WebView/WebView.mm:
2757         (+[WebView _setCacheModel:]):
2758
2759 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2760
2761         Refactor WebContentReader out of EditorMac and EditorIOS
2762         https://bugs.webkit.org/show_bug.cgi?id=176770
2763
2764         Reviewed by Sam Weinig.
2765
2766         * WebCoreSupport/WebEditorClient.mm:
2767
2768 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2769
2770         Dragging & dropping a file creates an attachment element even when it's disabled
2771         https://bugs.webkit.org/show_bug.cgi?id=176769
2772
2773         Reviewed by Tim Horton.
2774
2775         * WebView/WebView.mm:
2776         (-[WebView _preferencesChanged:]):
2777
2778 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2779
2780         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2781         https://bugs.webkit.org/show_bug.cgi?id=176721
2782         <rdar://problem/34373660>
2783
2784         Reviewed by Tim Horton.
2785
2786         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2787         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2788
2789         * WebView/WebView.mm:
2790         (-[WebView _startDrag:]):
2791         (-[WebView _draggedElementBounds]):
2792         (-[WebView _endedDataInteraction:global:]):
2793         * WebView/WebViewData.h:
2794
2795 2017-09-11  Andy Estes  <aestes@apple.com>
2796
2797         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2798         https://bugs.webkit.org/show_bug.cgi?id=176472
2799
2800         Reviewed by Eric Carlson.
2801
2802         * WebCoreSupport/WebSystemInterface.mm:
2803         (InitWebCoreSystemInterface):
2804
2805 2017-09-09  Mark Lam  <mark.lam@apple.com>
2806
2807         Avoid duplicate computations of ExecState::vm().
2808         https://bugs.webkit.org/show_bug.cgi?id=176647
2809
2810         Reviewed by Saam Barati.
2811
2812         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2813         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2814         (WebKit::NetscapePluginInstanceProxy::construct):
2815         (WebKit::NetscapePluginInstanceProxy::setProperty):
2816         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2817         (WebKit::NetscapePluginInstanceProxy::enumerate):
2818         * Plugins/Hosted/ProxyInstance.mm:
2819         (WebKit::ProxyRuntimeMethod::create):
2820
2821 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2822
2823         Unreviewed, rolling out r221773.
2824         https://bugs.webkit.org/show_bug.cgi?id=176614
2825
2826         This caused build failures. (Requested by mlewis13 on
2827         #webkit).
2828
2829         Reverted changeset:
2830
2831         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2832         https://bugs.webkit.org/show_bug.cgi?id=176472
2833         http://trac.webkit.org/changeset/221773
2834
2835 2017-09-07  Andy Estes  <aestes@apple.com>
2836
2837         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2838         https://bugs.webkit.org/show_bug.cgi?id=176472
2839
2840         Reviewed by Eric Carlson.
2841
2842         * WebCoreSupport/WebSystemInterface.mm:
2843         (InitWebCoreSystemInterface):
2844
2845 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2846
2847         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2848         https://bugs.webkit.org/show_bug.cgi?id=176561
2849
2850         Reviewed by Brent Fulgham.
2851
2852         * Misc/WebNSUserDefaultsExtras.mm:
2853
2854 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2855
2856         Modernize Geolocation code
2857         https://bugs.webkit.org/show_bug.cgi?id=176496
2858
2859         Reviewed by Andy Estes.
2860
2861         * WebCoreSupport/WebGeolocationClient.h:
2862         * WebCoreSupport/WebGeolocationClient.mm:
2863         (WebGeolocationClient::requestPermission):
2864         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2865         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2866         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2867         * WebView/WebView.mm:
2868         (-[WebView _commonInitializationWithFrameName:groupName:]):
2869         (-[WebView _geolocationDidFailWithMessage:]):
2870
2871 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2872
2873         Remove some unused bits of code and resources
2874         https://bugs.webkit.org/show_bug.cgi?id=176275
2875
2876         Reviewed by Dan Bernstein.
2877
2878         * Misc/WebNSFileManagerExtras.mm:
2879         Include FileSystem instead of FileSystemIOS.
2880
2881 2017-09-03  Darin Adler  <darin@apple.com>
2882
2883         [Cocoa] Tidy a few things in legacy WebHTMLView
2884         https://bugs.webkit.org/show_bug.cgi?id=176280
2885
2886         Reviewed by Dan Bernstein.
2887
2888         * WebCoreSupport/WebChromeClient.mm:
2889         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2890         methods it calls on WebHTMLView were doing nothing on iOS.
2891
2892         * WebView/WebFrame.mm:
2893         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2894         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2895
2896         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2897         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2898         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2899         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2900         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2901         Use RetainPtr instead of writing retain/release wherever possible.
2902         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2903         initialization for it. Removed various unused methods and declarations of methods.
2904         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2905         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2906         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2907         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2908         and remove CFRetain no longer needed since we don't support garbage collection any more.
2909         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2910         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2911         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2912         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2913         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2914         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2915         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2916         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2917         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2918         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2919         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2920         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2921         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2922         debug flag; we haven't used it for years and it's not clearly helpful.
2923         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2924         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2925         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2926         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2927         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2928         two additional methods in the WebPrivate category and still be called by the two
2929         methods in the WebInternal category that were already using it.
2930         (-[WebHTMLView didAddSubview:]): Deleted.
2931         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2932         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2933         place this was called, the close method.
2934         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2935         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2936         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2937         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2938         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2939         Added helper method to make the one below simpler.
2940         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2941         Compared pasteboard type strings using isEqualToString: rather than using == since
2942         we want to actually compare the string contents. Also updated to use modern for loop,
2943         renamed a local variable from "s" to "localSubresources", and factored out the handling
2944         of three image types to use the helper method above.
2945         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2946         _web_makePluginSubviewsPerformSelector:withObject: method.
2947         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2948         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2949         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2950         not call the -[NSView subviews] method to make this identical on both platforms and used
2951         a modern for loop.
2952         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2953         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2954         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2955         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2956         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2957         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2958         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2959         of it is Mac-only.
2960         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2961         method did was call itself on the main thread, and do nothing if called on main thread.
2962         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2963         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2964         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2965         half of this method.
2966         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2967         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2968         Simplified using a modern for loop and RetainPtr.
2969         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2970         (-[WebHTMLView keyDown:]): Ditto.
2971         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2972         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2973         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2974         (-[WebHTMLView complete:]): Ditto.
2975         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2976         now macOS-only.
2977         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2978         iOS since that is now macOS-only.
2979         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2980         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2981         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2982         and reorganized to use early return.
2983         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2984         on iOS, but kept there so we don't have to do #if at every call site.
2985         (-[WebHTMLView _pluginController]): Moved into internal category.
2986         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2987         there only for GC, using C++ initialization, removing obsolete comment.
2988         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2989         peculiar iOS-only comment.
2990         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2991
2992         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2993         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2994         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2995         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2996         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2997
2998         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2999         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3000         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3001         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3002         them at this time.
3003
3004 2017-09-03  Sam Weinig  <sam@webkit.org>
3005
3006         Remove CanvasProxy
3007         https://bugs.webkit.org/show_bug.cgi?id=176288
3008
3009         Reviewed by Yusuke Suzuki.
3010
3011         CanvasProxy does not appear to be in any current HTML spec
3012         and was disabled and unimplemented in our tree. Time to 
3013         get rid of it.
3014
3015         * Configurations/FeatureDefines.xcconfig:
3016
3017 2017-09-02  Andy Estes  <aestes@apple.com>
3018
3019         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3020         https://bugs.webkit.org/show_bug.cgi?id=176270
3021
3022         Reviewed by Tim Horton.
3023
3024         * Plugins/Hosted/NetscapePluginHostManager.mm:
3025         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3026         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3027         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3028         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3029         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3030         (WebKit::SoftwareCARenderer::context const):
3031         (WebKit::SoftwareCARenderer::renderContext const):
3032         (WebKit::SoftwareCARenderer::render):
3033         (-[WebHostedNetscapePluginView createPlugin]):
3034         (-[WebHostedNetscapePluginView createPluginLayer]):
3035         (-[WebHostedNetscapePluginView destroyPlugin]):
3036         (-[WebHostedNetscapePluginView drawRect:]):
3037         * WebCoreSupport/WebSystemInterface.mm:
3038         (InitWebCoreSystemInterface):
3039
3040 2017-09-01  Andy Estes  <aestes@apple.com>
3041
3042         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3043         https://bugs.webkit.org/show_bug.cgi?id=176200
3044
3045         Reviewed by Tim Horton.
3046
3047         * Carbon/HIWebView.mm:
3048         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3049         (overrideCGContext):
3050         (restoreCGContext):
3051         (Draw):
3052         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3053         (+[WebHostedNetscapePluginView initialize]):
3054         * Plugins/WebBaseNetscapePluginView.h:
3055         * Plugins/WebBaseNetscapePluginView.mm:
3056         (WebKit::sendUserChangeNotifications):
3057         * Plugins/WebNetscapePluginView.mm:
3058         (+[WebNetscapePluginView initialize]):
3059         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3060         * WebCoreSupport/WebSystemInterface.mm:
3061         (InitWebCoreSystemInterface):
3062         * WebView/WebFrame.mm:
3063         (-[WebFrame _paintBehaviorForDestinationContext:]):
3064         * WebView/WebFullScreenController.mm:
3065         (setClipRectForWindow):
3066         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3067         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3068         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3069         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3070
3071 2017-08-31  Andy Estes  <aestes@apple.com>
3072
3073         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3074         https://bugs.webkit.org/show_bug.cgi?id=176175
3075
3076         Reviewed by Brady Eidson.
3077
3078         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3079         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3080         * Plugins/Hosted/WebTextInputWindowController.m:
3081         (-[WebTextInputPanel init]):
3082         * WebCoreSupport/WebSystemInterface.mm:
3083         (InitWebCoreSystemInterface):
3084         * WebView/WebDynamicScrollBarsView.mm:
3085         (-[WebDynamicScrollBarsView scrollWheel:]):
3086         * WebView/WebHTMLView.mm:
3087         (-[WebHTMLView _removeWindowObservers]):
3088         (-[WebHTMLView addWindowObservers]):
3089         * WebView/WebView.mm:
3090         (-[WebView addWindowObserversForWindow:]):
3091         (-[WebView removeWindowObservers]):
3092         (-[WebView viewWillMoveToWindow:]):
3093
3094 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3095
3096         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3097         https://bugs.webkit.org/show_bug.cgi?id=175779
3098         <rdar://problem/22367975>
3099
3100         Reviewed by Tim Horton.
3101
3102         * WebCoreSupport/WebFrameLoaderClient.h:
3103         * WebCoreSupport/WebFrameLoaderClient.mm:
3104         (WebFrameLoaderClient::webGLPolicyForURL const):
3105         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3106
3107 2017-08-30  Andy Estes  <aestes@apple.com>
3108
3109         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3110         https://bugs.webkit.org/show_bug.cgi?id=176093
3111
3112         Reviewed by Eric Carlson.
3113
3114         * WebCoreSupport/WebSystemInterface.mm:
3115         (InitWebCoreSystemInterface):
3116
3117 2017-08-30  Andy Estes  <aestes@apple.com>
3118
3119         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3120         https://bugs.webkit.org/show_bug.cgi?id=176087
3121
3122         Reviewed by Alex Christensen.
3123
3124         * Carbon/CarbonUtils.m:
3125         (getNSAutoreleasePoolCount):
3126         (WebInitForCarbon):
3127         (PoolCleaner):
3128         * Carbon/CarbonWindowAdapter.mm:
3129         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3130         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3131         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3132         (-[CarbonWindowAdapter _windowMovedToRect:]):
3133         * Carbon/HIViewAdapter.m:
3134         * Carbon/HIWebView.mm:
3135         (Draw):
3136         (CreateNSEventAdoptingCGEvent):
3137         (CopyEventCGEvent):
3138         (CreateNSEventWithCarbonClickEvent):
3139         (Click):
3140         (CreateNSEventWithCarbonEvent):
3141         (MouseUp):
3142         (CreateNSEventWithCarbonMouseMoveEvent):
3143         (MouseMoved):
3144         (MouseDragged):
3145         (MouseWheelMoved):
3146         (WindowHandler):
3147         (HIWebViewEventHandler):
3148         * Misc/QuickDrawCompatibility.h: Removed.
3149         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3150         (getCarbonEvent):
3151         (WebNetscapePluginEventHandlerCarbon::keyDown):
3152         (WebNetscapePluginEventHandlerCarbon::keyUp):
3153         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3154         (WebNetscapePluginEventHandlerCocoa::keyDown):
3155         * Plugins/WebNetscapePluginView.mm:
3156         (-[WebNetscapePluginView tellQuickTimeToChill]):
3157
3158 2017-08-29  Andy Estes  <aestes@apple.com>
3159
3160         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3161         https://bugs.webkit.org/show_bug.cgi?id=176046
3162
3163         Reviewed by Alex Christensen.
3164
3165         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3166         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3167
3168         * Misc/WebNSFileManagerExtras.mm:
3169         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3170         (setMetaData): Deleted.
3171         * WebCoreSupport/WebSystemInterface.mm:
3172         (InitWebCoreSystemInterface):
3173
3174 2017-08-28  Andy Estes  <aestes@apple.com>
3175
3176         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3177         https://bugs.webkit.org/show_bug.cgi?id=176039
3178
3179         Reviewed by Alex Christensen.
3180
3181         * WebCoreSupport/WebSystemInterface.mm:
3182         (InitWebCoreSystemInterface):
3183         * WebView/WebPreferences.mm:
3184         (+[WebPreferences _systemCFStringEncoding]):
3185
3186 2017-08-28  Andy Estes  <aestes@apple.com>
3187
3188         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3189         https://bugs.webkit.org/show_bug.cgi?id=176032
3190
3191         Reviewed by Alex Christensen.
3192
3193         * WebCoreSupport/WebSystemInterface.mm:
3194         (InitWebCoreSystemInterface):
3195         * WebView/WebView.mm:
3196         (-[WebView _cachedResponseForURL:]):
3197
3198 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3199
3200         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3201         https://bugs.webkit.org/show_bug.cgi?id=175992
3202         <rdar://problem/34086613>
3203
3204         Reviewed by Daniel Bates.
3205
3206         * WebCoreSupport/WebPlatformStrategies.h:
3207         * WebCoreSupport/WebPlatformStrategies.mm:
3208         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3209         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3210         indicating if secure cookies were accessed.
3211
3212 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3213
3214         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3215         https://bugs.webkit.org/show_bug.cgi?id=170955
3216         <rdar://problem/31697653>
3217
3218         Reviewed by Ryosuke Niwa.
3219
3220         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3221         text is being replaced.
3222
3223         * WebView/WebHTMLView.mm:
3224         (-[WebHTMLView insertText:]):
3225
3226 2017-08-24  Chris Dumez  <cdumez@apple.com>
3227
3228         [Directory Upload] Add basic support for input.webkitdirectory
3229         https://bugs.webkit.org/show_bug.cgi?id=175950
3230         <rdar://problem/33951915>
3231
3232         Reviewed by Geoffrey Garen.
3233
3234         Add private API to toggle Directory Upload support on Mac WebKit1.
3235
3236         * WebView/WebPreferenceKeysPrivate.h:
3237         * WebView/WebPreferences.mm:
3238         (+[WebPreferences initialize]):
3239         (-[WebPreferences setDirectoryUploadEnabled:]):
3240         (-[WebPreferences directoryUploadEnabled]):
3241         * WebView/WebPreferencesPrivate.h:
3242         * WebView/WebView.mm:
3243         (-[WebView _preferencesChanged:]):
3244
3245 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3246
3247         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3248         https://bugs.webkit.org/show_bug.cgi?id=175370
3249         <rdar://problem/33799806>
3250
3251         Reviewed by Ryosuke Niwa.
3252
3253         Adjust WebEditorClient for interface changes.
3254
3255         * WebCoreSupport/WebEditorClient.h:
3256
3257 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3258
3259         Remove ChromeClient::scrollbarsModeDidChange
3260         https://bugs.webkit.org/show_bug.cgi?id=175805
3261
3262         Reviewed by Daniel Bates.
3263
3264         * WebCoreSupport/WebChromeClient.h:
3265
3266 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3267
3268         Remove ChromeClient::hasOpenedPopup
3269         https://bugs.webkit.org/show_bug.cgi?id=175804
3270
3271         Reviewed by Sam Weinig.
3272
3273         * WebCoreSupport/WebChromeClient.h:
3274         * WebCoreSupport/WebChromeClient.mm:
3275         (WebChromeClient::hasOpenedPopup const): Deleted.
3276
3277 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3278
3279         Disable access to secure cookies if an HTTPS site loads mixed content
3280         https://bugs.webkit.org/show_bug.cgi?id=157053
3281         <rdar://problem/11290808>
3282
3283         Reviewed by Dan Bates.
3284
3285         * WebCoreSupport/WebPlatformStrategies.h:
3286         * WebCoreSupport/WebPlatformStrategies.mm:
3287         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3288         indicating whether secure cookies should be included in the response.
3289
3290 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3291
3292         [PAL] Move spi/mac directory into PAL
3293         https://bugs.webkit.org/show_bug.cgi?id=175649
3294
3295         Reviewed by Myles C. Maxfield.
3296
3297         * Misc/WebSharingServicePickerController.h:
3298         * WebCoreSupport/WebContextMenuClient.mm:
3299         * WebCoreSupport/WebEditorClient.mm:
3300         * WebCoreSupport/WebSelectionServiceController.mm:
3301         * WebView/WebHTMLView.mm:
3302         * WebView/WebImmediateActionController.h:
3303         * WebView/WebImmediateActionController.mm:
3304         * WebView/WebView.mm:
3305
3306 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3307
3308         [PAL] Relocate SessionID to root
3309         https://bugs.webkit.org/show_bug.cgi?id=175684
3310
3311         Reviewed by Alex Christensen.
3312
3313         * WebCoreSupport/WebFrameNetworkingContext.mm:
3314
3315 2017-08-17  Andreas Kling  <akling@apple.com>
3316
3317         Disable CSS regions at compile time
3318         https://bugs.webkit.org/show_bug.cgi?id=175630
3319
3320         Reviewed by Antti Koivisto.
3321
3322         * Configurations/FeatureDefines.xcconfig:
3323
3324 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3325
3326         [PAL] Move SessionID into PAL
3327         https://bugs.webkit.org/show_bug.cgi?id=174192
3328
3329         Reviewed by Antti Koivisto.
3330
3331         * Misc/WebCache.mm:
3332         (+[WebCache imageForURL:]):
3333         * WebCoreSupport/WebFrameLoaderClient.h:
3334         * WebCoreSupport/WebFrameLoaderClient.mm:
3335         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3336         * WebCoreSupport/WebFrameNetworkingContext.mm:
3337         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3338         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3339         (WebFrameNetworkingContext::storageSession const):
3340         * WebCoreSupport/WebPlatformStrategies.h:
3341         * WebCoreSupport/WebPlatformStrategies.mm:
3342         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3343         * WebKitPrefix.h:
3344
3345 2017-08-16  Andy Estes  <aestes@apple.com>
3346
3347         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3348         https://bugs.webkit.org/show_bug.cgi?id=175648
3349
3350         Reviewed by Tim Horton.
3351
3352         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3353         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3354         (WebPaymentCoordinatorClient::showPaymentUI):
3355
3356 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3357
3358         [PAL] Move spi/ios and spi/win directories into PAL
3359         https://bugs.webkit.org/show_bug.cgi?id=175171
3360
3361         Reviewed by Antti Koivisto.
3362
3363         * WebCoreSupport/WebFrameLoaderClient.mm:
3364         * WebView/WebView.mm:
3365
3366 2017-08-16  Andy Estes  <aestes@apple.com>
3367
3368         [Payment Request] Add an ENABLE flag and an experimental feature preference
3369         https://bugs.webkit.org/show_bug.cgi?id=175622
3370
3371         Reviewed by Tim Horton.
3372
3373         * Configurations/FeatureDefines.xcconfig:
3374
3375 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3376
3377         [PAL] Move Sleep classes into PAL
3378         https://bugs.webkit.org/show_bug.cgi?id=175456
3379
3380         Reviewed by Ryosuke Niwa.
3381
3382         * WebView/WebFullScreenController.h:
3383
3384 2017-08-15  Youenn Fablet  <youenn@apple.com>
3385
3386         [Cache API] Adding generic support for CacheStorage and Cache methods
3387         https://bugs.webkit.org/show_bug.cgi?id=175455
3388
3389         Reviewed by Chris Dumez.
3390
3391         * WebView/WebView.mm:
3392         (-[WebView _commonInitializationWithFrameName:groupName:]):
3393
3394 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3395
3396         Remove Proximity Events and related code
3397         https://bugs.webkit.org/show_bug.cgi?id=175545
3398
3399         Reviewed by Daniel Bates.
3400
3401         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3402         and other related code.
3403
3404         * Configurations/FeatureDefines.xcconfig:
3405
3406 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3407
3408         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3409         https://bugs.webkit.org/show_bug.cgi?id=175504
3410
3411         Reviewed by Sam Weinig.
3412
3413         * Configurations/FeatureDefines.xcconfig:
3414         * DOM/DOMHTMLFormElement.mm:
3415         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3416         * WebCoreSupport/WebFrameLoaderClient.h:
3417
3418 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3419
3420         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3421         https://bugs.webkit.org/show_bug.cgi?id=175557
3422
3423         Reviewed by Jon Lee.
3424
3425         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3426
3427         * Configurations/FeatureDefines.xcconfig:
3428
3429 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3430
3431         Composition underline color is always black
3432         https://bugs.webkit.org/show_bug.cgi?id=174675
3433
3434         Reviewed by Ryosuke Niwa.
3435
3436         * WebView/WebHTMLView.mm:
3437         (extractUnderlines): If NSUnderlineColorAttributeName
3438         is not present use text color for composition underline.
3439         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3440         for composition underline in the plain text case.
3441
3442 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3443
3444         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3445         https://bugs.webkit.org/show_bug.cgi?id=175474
3446         <rdar://problem/33844628>
3447
3448         Reviewed by Wenson Hsieh.
3449
3450         Replaced the build flag by a runtime flag and disabled the feature by default.
3451
3452         * Configurations/FeatureDefines.xcconfig:
3453         * WebView/WebPreferenceKeysPrivate.h:
3454         * WebView/WebPreferences.mm:
3455         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3456         (-[WebPreferences dataTransferItemsEnabled]): Added.
3457         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3458         * WebView/WebPreferencesPrivate.h:
3459         * WebView/WebView.mm:
3460         (-[WebView _preferencesChanged:]):
3461
3462 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3463
3464         Remove ENABLE_GAMEPAD_DEPRECATED
3465         https://bugs.webkit.org/show_bug.cgi?id=175361
3466
3467         Reviewed by Carlos Garcia Campos.
3468
3469         * Configurations/FeatureDefines.xcconfig:
3470
3471 2017-08-09  Chris Dumez  <cdumez@apple.com>
3472
3473         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3474         https://bugs.webkit.org/show_bug.cgi?id=175401
3475
3476         Reviewed by Brady Eidson.
3477
3478         * WebView/WebPreferenceKeysPrivate.h:
3479         * WebView/WebPreferences.mm:
3480         (+[WebPreferences initialize]):
3481         (-[WebPreferences beaconAPIEnabled]): Deleted.
3482         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3483         * WebView/WebPreferencesPrivate.h:
3484         * WebView/WebView.mm:
3485         (-[WebView _preferencesChanged:]):
3486
3487 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3488
3489         [PAL] Move spi/cocoa and spi/cg directories into PAL
3490         https://bugs.webkit.org/show_bug.cgi?id=175175
3491
3492         Reviewed by Myles C. Maxfield.
3493
3494         * History/WebHistory.mm:
3495         * Misc/WebDownload.mm:
3496         * Misc/WebKitNSStringExtras.mm:
3497         * Plugins/Hosted/NetscapePluginHostManager.mm:
3498         * Plugins/WebPluginDatabase.mm:
3499         * WebCoreSupport/WebFrameLoaderClient.mm:
3500         * WebInspector/WebNodeHighlight.mm:
3501         * WebView/WebHTMLView.mm:
3502         * WebView/WebIndicateLayer.mm:
3503         * WebView/WebView.mm:
3504         * WebView/WebViewData.h:
3505
3506 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3507
3508         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3509         https://bugs.webkit.org/show_bug.cgi?id=175392
3510         <rdar://problem/33783207>
3511
3512         Reviewed by Tim Horton and Megan Gardner.
3513
3514         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3515
3516         * Configurations/FeatureDefines.xcconfig:
3517
3518 2017-08-09  Daniel Bates  <dabates@apple.com>
3519
3520         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3521         https://bugs.webkit.org/show_bug.cgi?id=175247
3522         <rdar://problem/33679804>
3523
3524         Reviewed by Brady Eidson.
3525
3526         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3527         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3528         clients that need to make use of this information at this time. If such a needs comes up
3529         then we can expose API/SPI similar to what we do for WebKit.
3530
3531         * WebCoreSupport/WebFrameLoaderClient.h:
3532         * WebCoreSupport/WebFrameLoaderClient.mm:
3533         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3534
3535 2017-08-08  Brady Eidson  <beidson@apple.com>
3536
3537         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3538         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3539
3540         Reviewed by Andy Estes.
3541
3542         * Misc/WebKitVersionChecks.h:
3543         * WebCoreSupport/WebFrameLoaderClient.mm:
3544         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3545           the app is linked against new WebKit with the new behavior.
3546
3547 2017-08-07  Devin Rousso  <drousso@apple.com>
3548
3549         Web Inspector: Preview Canvas path when viewing a recording
3550         https://bugs.webkit.org/show_bug.cgi?id=174967
3551
3552         Reviewed by Brian Burg.
3553
3554         * WebView/WebPreferenceKeysPrivate.h:
3555         * WebView/WebPreferences.mm:
3556         (+[WebPreferences initialize]):
3557         (-[WebPreferences inspectorAdditionsEnabled]):
3558         (-[WebPreferences setInspectorAdditionsEnabled:]):
3559         * WebView/WebPreferencesPrivate.h:
3560         * WebView/WebView.mm:
3561         (-[WebView _preferencesChanged:]):
3562         Add plumbing for new InspectorAdditions runtime flag.
3563
3564 2017-08-07  Brian Burg  <bburg@apple.com>
3565
3566         Remove CANVAS_PATH compilation guard
3567         https://bugs.webkit.org/show_bug.cgi?id=175207
3568
3569         Reviewed by Sam Weinig.
3570
3571         * Configurations/FeatureDefines.xcconfig:
3572
3573 2017-08-04  Youenn Fablet  <youenn@apple.com>
3574
3575         [Cache API] Add Cache and CacheStorage IDL definitions
3576         https://bugs.webkit.org/show_bug.cgi?id=175201
3577
3578         Reviewed by Brady Eidson.
3579
3580         * WebView/WebPreferenceKeysPrivate.h:
3581         * WebView/WebPreferences.mm:
3582         (+[WebPreferences initialize]):
3583         (-[WebPreferences cacheAPIEnabled]):
3584         (-[WebPreferences setCacheAPIEnabled:]):
3585         * WebView/WebPreferencesPrivate.h:
3586         * WebView/WebView.mm:
3587         (-[WebView _preferencesChanged:]):
3588
3589 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3590
3591         Unreviewed, rolling out r220271.
3592
3593         Rolling out due to Layout Test failing on iOS Simulator.
3594
3595         Reverted changeset:
3596
3597         "Remove STREAMS_API compilation guard"
3598         https://bugs.webkit.org/show_bug.cgi?id=175165
3599         http://trac.webkit.org/changeset/220271
3600
3601 2017-08-04  Youenn Fablet  <youenn@apple.com>
3602
3603         Remove STREAMS_API compilation guard
3604         https://bugs.webkit.org/show_bug.cgi?id=175165
3605
3606         Reviewed by Darin Adler.
3607
3608         * Configurations/FeatureDefines.xcconfig:
3609         * WebView/WebPreferences.mm:
3610         (+[WebPreferences initialize]):
3611         * WebView/WebView.mm:
3612         (-[WebView _preferencesChanged:]):
3613
3614 2017-08-03  Brian Burg  <bburg@apple.com>
3615
3616         Remove ENABLE(WEB_SOCKET) guards
3617         https://bugs.webkit.org/show_bug.cgi?id=167044
3618
3619         Reviewed by Joseph Pecoraro.
3620
3621         * Configurations/FeatureDefines.xcconfig:
3622         * WebView/WebPreferencesPrivate.h:
3623
3624 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3625
3626         [PAL] Move spi/cf directory into PAL
3627         https://bugs.webkit.org/show_bug.cgi?id=175057
3628
3629         Reviewed by Antti Koivisto.
3630
3631         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3632         * Plugins/WebNetscapePluginStream.mm:
3633         * WebCoreSupport/WebFrameNetworkingContext.mm:
3634         * WebView/WebPreferences.mm:
3635         * WebView/WebView.mm:
3636
3637 2017-08-03  Youenn Fablet  <youenn@apple.com>
3638
3639         Remove FETCH_API compilation guard
3640         https://bugs.webkit.org/show_bug.cgi?id=175154
3641
3642         Reviewed by Chris Dumez.
3643
3644         * Configurations/FeatureDefines.xcconfig:
3645         * WebView/WebPreferences.mm:
3646         (+[WebPreferences initialize]):
3647         * WebView/WebView.mm:
3648         (-[WebView _preferencesChanged:]):
3649
3650 2017-08-03  Brady Eidson  <beidson@apple.com>
3651
3652         Add SW IDLs and stub out basic functionality.
3653         https://bugs.webkit.org/show_bug.cgi?id=175115
3654
3655         Reviewed by Chris Dumez.
3656
3657         * Configurations/FeatureDefines.xcconfig:
3658
3659 2017-08-02  Sam Weinig  <sam@webkit.org>
3660
3661         [WebIDL] Convert MutationCallback to be a normal generated callback
3662         https://bugs.webkit.org/show_bug.cgi?id=174140
3663
3664         Reviewed by Darin Adler.
3665
3666         * DOM/DOMDocument.mm:
3667         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3668         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3669         Pass, now necessary, Document to NativeNodeFilter constructor.
3670
3671 2017-08-01  Chris Dumez  <cdumez@apple.com>
3672
3673         Add initial support for navigator.sendBeacon
3674         https://bugs.webkit.org/show_bug.cgi?id=175007
3675         <rdar://problem/33547728>
3676
3677         Reviewed by Sam Weinig.
3678
3679         Add setting to toggle support for the Beacon API (it is disabled by default).
3680
3681         * WebView/WebPreferenceKeysPrivate.h:
3682         * WebView/WebPreferences.mm:
3683         (+[WebPreferences initialize]):
3684         (-[WebPreferences beaconAPIEnabled]):
3685         (-[WebPreferences setBeaconAPIEnabled:]):
3686         * WebView/WebPreferencesPrivate.h:
3687         * WebView/WebView.mm:
3688         (-[WebView _preferencesChanged:]):
3689
3690 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3691
3692         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3693         https://bugs.webkit.org/show_bug.cgi?id=174437
3694
3695         Reviewed by Darin Adler.
3696
3697         Remove redundant Web- prefix from classes in WebKit namespace.
3698
3699         * WebView/WebView.mm:
3700         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3701         * WebView/WebViewData.h:
3702         * WebView/WebViewData.mm:
3703
3704 2017-07-26  Brian Burg  <bburg@apple.com>
3705
3706         Remove WEB_TIMING feature flag
3707         https://bugs.webkit.org/show_bug.cgi?id=174795
3708
3709         Reviewed by Alex Christensen.
3710
3711         * Configurations/FeatureDefines.xcconfig:
3712
3713 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3714
3715         Async image decoding for large images should be disabled after the first time a tile is painted
3716         https://bugs.webkit.org/show_bug.cgi?id=174451
3717         <rdar://problem/31246421>
3718
3719         Reviewed by Simon Fraser.
3720
3721         * WebView/WebFrame.mm:
3722         (-[WebFrame _paintBehaviorForDestinationContext:]):
3723         (-[WebFrame _drawRect:contentsOnly:]):
3724         * WebView/WebHTMLView.mm:
3725         (imageFromRect):
3726
3727 2017-07-23  Darin Adler  <darin@apple.com>
3728
3729         More NeverDestroyed and related cleanup
3730         https://bugs.webkit.org/show_bug.cgi?id=174745
3731
3732         Reviewed by Alex Christensen.
3733
3734         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3735         for names that aren't even used in this file.
3736         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3737         -[NSArray arrayWithObject:].
3738         (-[DOMNode absoluteQuads]): Ditto.
3739         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3740         of writing out various types.
3741         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3742         syntax instea of -[NSArray arrayWithObject:].
3743         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3744         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3745         of writing out various types.
3746         (-[DOMHTMLImageElement mimeType]): Ditto.
3747
3748 2017-07-24  Chris Dumez  <cdumez@apple.com>
3749
3750         ExceptionCode enumeration should use modern exception names
3751         https://bugs.webkit.org/show_bug.cgi?id=174794
3752
3753         Reviewed by Geoffrey Garen.
3754
3755         * DOM/ExceptionHandlers.mm:
3756         (raiseNotSupportedErrorException):
3757
3758 2017-07-23  Chris Dumez  <cdumez@apple.com>
3759
3760         Drop ExceptionCodeDescription class
3761         https://bugs.webkit.org/show_bug.cgi?id=174757
3762
3763         Reviewed by Darin Adler.
3764
3765         Stop using ExceptionCodeDescription.
3766
3767         * DOM/ExceptionHandlers.mm:
3768         (raiseDOMErrorException):
3769
3770 2017-07-21  Andreas Kling  <akling@apple.com>
3771
3772         Use more references in event dispatch code
3773         https://bugs.webkit.org/show_bug.cgi?id=174681
3774
3775         Reviewed by Geoffrey Garen.
3776
3777         * DOM/ObjCEventListener.h:
3778         * DOM/ObjCEventListener.mm:
3779         (WebCore::ObjCEventListener::handleEvent):
3780         * WebCoreSupport/WebFrameLoaderClient.mm:
3781         (NetscapePluginWidget::handleEvent):
3782
3783 2017-07-21  Brady Eidson  <beidson@apple.com>
3784
3785         Get rid of WebCore IconDatabase code.
3786         https://bugs.webkit.org/show_bug.cgi?id=174700
3787
3788         Reviewed by Tim Horton.
3789
3790         * Misc/WebCoreStatistics.mm:
3791         (+[WebCoreStatistics iconPageURLMappingCount]):
3792         (+[WebCoreStatistics iconRetainedPageURLCount]):
3793         (+[WebCoreStatistics iconRecordCount]):
3794         (+[WebCoreStatistics iconsWithDataCount]):
3795         * WebCoreSupport/WebFrameLoaderClient.h:
3796         * WebCoreSupport/WebFrameLoaderClient.mm:
3797         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3798         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3799         * WebView/WebView.mm:
3800         (-[WebView mainFrameIconURL]):
3801
3802 2017-07-20  Chris Dumez  <cdumez@apple.com>
3803
3804         Drop legacy XPathException type
3805         https://bugs.webkit.org/show_bug.cgi?id=174679
3806
3807         Reviewed by Sam Weinig.
3808
3809         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3810         no longer expose XPathException.
3811
3812         * DOM/ExceptionHandlers.mm:
3813         (raiseDOMErrorException):
3814
3815 2017-07-20  Chris Dumez  <cdumez@apple.com>
3816
3817         Unreviewed, rolling out r219706.
3818
3819         Broke iOS build
3820
3821         Reverted changeset:
3822
3823         "Drop legacy XPathException type"
3824         https://bugs.webkit.org/show_bug.cgi?id=174679
3825         http://trac.webkit.org/changeset/219706
3826
3827 2017-07-20  Chris Dumez  <cdumez@apple.com>
3828
3829         Drop legacy XPathException type
3830         https://bugs.webkit.org/show_bug.cgi?id=174679
3831
3832         Reviewed by Sam Weinig.
3833
3834         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3835         no longer expose XPathException.
3836
3837         * DOM/ExceptionHandlers.mm:
3838         (raiseDOMErrorException):
3839         * WebKit.exp:
3840
3841 2017-07-20  Chris Dumez  <cdumez@apple.com>
3842
3843         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3844         https://bugs.webkit.org/show_bug.cgi?id=174660
3845
3846         Reviewed by Geoffrey Garen.
3847
3848         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3849         This essentially replaces a branch to figure out if the new size is less or greater than the
3850         current size by an assertion.
3851
3852         * Plugins/WebNetscapePluginView.mm:
3853         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3854
3855 2017-07-20  Brady Eidson  <beidson@apple.com>
3856
3857         Deprecate WebIconDatabase in WebKitLegacy/mac.
3858         https://bugs.webkit.org/show_bug.cgi?id=174607
3859
3860         Reviewed by Alex Christensen.
3861
3862         This patch:
3863         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3864         2 - Guts the class to where it can only return the default icon at the small size
3865         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3866             use something else or to not do anything.
3867         
3868         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3869         and that patch will remove all of the last remnants of WebIconDatabase.
3870         
3871         * History/WebHistoryItem.mm:
3872         (-[WebHistoryItem icon]):
3873
3874         * Misc/WebIconDatabase.h:
3875         * Misc/WebIconDatabase.mm:
3876         (-[WebIconDatabase init]):
3877         (-[WebIconDatabase iconForURL:withSize:cache:]):
3878         (-[WebIconDatabase iconForURL:withSize:]):
3879         (-[WebIconDatabase defaultIconWithSize:]):
3880         (-[WebIconDatabase defaultIconForURL:withSize:]):
3881         (-[WebIconDatabase iconURLForURL:]):
3882         (-[WebIconDatabase retainIconForURL:]):
3883         (-[WebIconDatabase releaseIconForURL:]):
3884         (+[WebIconDatabase delayDatabaseCleanup]):
3885         (+[WebIconDatabase allowDatabaseCleanup]):
3886         (-[WebIconDatabase setDelegate:]):
3887         (-[WebIconDatabase delegate]):
3888         (+[WebIconDatabase initialize]): Deleted.
3889         (-[WebIconDatabase isEnabled]): Deleted.
3890         (-[WebIconDatabase setEnabled:]): Deleted.
3891         (-[WebIconDatabase removeAllIcons]): Deleted.
3892         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3893         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3894         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3895         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3896         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3897         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3898         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3899         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3900         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3901         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3902         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3903         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3904         (-[WebIconDatabase _databaseDirectory]): Deleted.
3905         (webGetNSImage): Deleted.
3906
3907         * Misc/WebIconDatabaseDelegate.h: Removed.
3908         * Misc/WebIconDatabaseInternal.h: Removed.
3909         * Misc/WebIconDatabasePrivate.h: Removed.
3910
3911         * WebCoreSupport/WebFrameLoaderClient.mm:
3912         (webGetNSImage):
3913
3914         * WebCoreSupport/WebIconDatabaseClient.mm:
3915         (WebIconDatabaseClient::didRemoveAllIcons):
3916         (WebIconDatabaseClient::didImportIconURLForPageURL):
3917
3918         * WebView/WebView.mm:
3919         (-[WebView setFrameLoadDelegate:]):
3920         (-[WebView mainFrameIcon]):
3921
3922 2017-07-18  Andy Estes  <aestes@apple.com>
3923
3924         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3925         https://bugs.webkit.org/show_bug.cgi?id=174631
3926
3927         Reviewed by Tim Horton.
3928
3929         * Configurations/Base.xcconfig:
3930
3931 2017-07-18  Andy Estes  <aestes@apple.com>
3932
3933         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3934         https://bugs.webkit.org/show_bug.cgi?id=174631
3935
3936         Reviewed by Sam Weinig.
3937
3938         * Configurations/Base.xcconfig:
3939
3940 2017-07-18  Andy Estes  <aestes@apple.com>
3941
3942         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3943         https://bugs.webkit.org/show_bug.cgi?id=174631
3944
3945         Reviewed by Dan Bernstein.
3946
3947         * Configurations/Base.xcconfig:
3948
3949 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3950
3951         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3952         https://bugs.webkit.org/show_bug.cgi?id=174640
3953         <rdar://problem/33297400>
3954
3955         Reviewed by Tim Horton.
3956
3957         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3958         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3959         web thread here, to match the other WebView drag and drop SPI methods.
3960
3961         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3962         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3963         should make this robust against future UIKit changes that could make this no longer the case.
3964
3965         * WebView/WebView.mm:
3966         (-[WebView _requestStartDataInteraction:globalPosition:]):
3967         (-[WebView _dataInteractionCaretRect]):
3968
3969 2017-07-18  Andy Estes  <aestes@apple.com>
3970
3971         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3972         https://bugs.webkit.org/show_bug.cgi?id=174631
3973
3974         Reviewed by Darin Adler.
3975
3976         * Configurations/Base.xcconfig:
3977
3978 2017-07-17  Sam Weinig  <sam@webkit.org>
3979
3980         [WebIDL] Remove custom bindings that require non-caching JS strings
3981         https://bugs.webkit.org/show_bug.cgi?id=174552
3982
3983         Reviewed by Darin Adler.
3984
3985         * DOM/DOMHTMLCanvasElement.mm:
3986         (-[DOMHTMLCanvasElement toDataURL:]):
3987         Update to account for implementation now returning an UncachedString.
3988
3989 2017-07-17  Darin Adler  <darin@apple.com>
3990
3991         Improve use of NeverDestroyed
3992         https://bugs.webkit.org/show_bug.cgi?id=174348
3993
3994         Reviewed by Sam Weinig.
3995
3996         * Misc/WebStringTruncator.mm:
3997         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3998         NeverDestroyed<RetainPtr> with just an NSFont * global.
3999
4000         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
4001         NeverDestroyed.h.
4002         * Storage/WebDatabaseManager.mm: Ditto.
4003         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
4004         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
4005
4006         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
4007         (aeDescFromJSValue): Removed double hashing by using the return value from
4008         add rather than calling contains before calling add.
4009
4010 2017-07-14  Jer Noble  <jer.noble@apple.com>
4011
4012         Allow clients to override their own hardware media requirements where no fallback media exists.
4013         https://bugs.webkit.org/show_bug.cgi?id=174426
4014         <rdar://problem/32537704>
4015
4016         Reviewed by Eric Carlson.
4017
4018         Add a new WebPreferences property to control WebCore's new
4019         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
4020
4021         * WebView/WebPreferenceKeysPrivate.h:
4022         * WebView/WebPreferences.mm:
4023         (+[WebPreferences initialize]):
4024         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
4025         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
4026         * WebView/WebPreferencesPrivate.h:
4027         * WebView/WebView.mm:
4028         (-[WebView _preferencesChanged:]):
4029
4030 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
4031
4032         Async image decoding for large images should be disabled by default
4033         https://bugs.webkit.org/show_bug.cgi?id=174432
4034
4035         Reviewed by Simon Fraser.
4036
4037         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
4038         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
4039         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
4040            a child view instead of propagating PaintBehaviorSnapshotting.
4041         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
4042            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
4043
4044         * WebView/WebFrame.mm:
4045         (-[WebFrame _paintBehaviorForDestinationContext:]):
4046         (-[WebFrame _drawRect:contentsOnly:]):
4047         * WebView/WebHTMLView.mm:
4048         (imageFromRect):
4049
4050 2017-07-12  Daniel Bates  <dabates@apple.com>
4051
4052         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
4053         https://bugs.webkit.org/show_bug.cgi?id=174427
4054
4055         Rubber-stamped by Brady Eidson.
4056
4057         * WebView/WebPDFView.mm:
4058         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4059
4060 2017-07-12  Matt Lewis  <jlewis3@apple.com>
4061
4062         Unreviewed, rolling out r219401.
4063
4064         This revision rolled out the previous patch, but after talking
4065         with reviewer, a rebaseline is what was needed.Rolling back in
4066         before rebaseline.
4067
4068         Reverted changeset:
4069
4070         "Unreviewed, rolling out r219379."
4071         https://bugs.webkit.org/show_bug.cgi?id=174400
4072         http://trac.webkit.org/changeset/219401
4073
4074 2017-07-12  Matt Lewis  <jlewis3@apple.com>
4075
4076         Unreviewed, rolling out r219379.
4077
4078         This revision caused a consistent failure in the test
4079         fast/dom/Window/property-access-on-cached-window-after-frame-
4080         removed.html.
4081
4082         Reverted changeset:
4083
4084         "Remove NAVIGATOR_HWCONCURRENCY"
4085         https://bugs.webkit.org/show_bug.cgi?id=174400
4086         http://trac.webkit.org/changeset/219379
4087
4088 2017-07-11  Dean Jackson  <dino@apple.com>
4089
4090         Remove NAVIGATOR_HWCONCURRENCY
4091         https://bugs.webkit.org/show_bug.cgi?id=174400
4092
4093         * Configurations/FeatureDefines.xcconfig:
4094
4095 2017-07-11  Dean Jackson  <dino@apple.com>
4096
4097         Rolling out r219372.
4098
4099         * Configurations/FeatureDefines.xcconfig:
4100
4101 2017-07-11  Dean Jackson  <dino@apple.com>
4102
4103         Remove NAVIGATOR_HWCONCURRENCY
4104         https://bugs.webkit.org/show_bug.cgi?id=174400
4105
4106         * Configurations/FeatureDefines.xcconfig: