61f00d3f6569cd7e9f526a68fafbd350b2dc5fb7
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: "Reload Web Inspector" button no longer partially works
4         https://bugs.webkit.org/show_bug.cgi?id=191773
5         <rdar://problem/46139932>
6
7         Reviewed by Devin Rousso.
8
9         * WebCoreSupport/WebInspectorClient.h:
10         * WebCoreSupport/WebInspectorClient.mm:
11         (WebInspectorFrontendClient::reopen):
12
13 2018-11-17  Devin Rousso  <drousso@apple.com>
14
15         Web Inspector: Network: add button to show system certificate dialog
16         https://bugs.webkit.org/show_bug.cgi?id=191458
17         <rdar://problem/45977019>
18
19         Reviewed by Joseph Pecoraro.
20
21         * WebCoreSupport/WebInspectorClient.h:
22         * WebCoreSupport/WebInspectorClient.mm:
23         (WebInspectorFrontendClient::showCertificate): Added.
24
25         * Configurations/WebKitLegacy.xcconfig:
26
27 2018-11-15  Truitt Savell  <tsavell@apple.com>
28
29         Unreviewed, rolling out r238244.
30
31         Caused High Sierra test runs to fail early with 50 crashes and
32         casued 25 API failures.
33
34         Reverted changeset:
35
36         "[css-logical] Implement flow-relative margin, padding and
37         border shorthands"
38         https://bugs.webkit.org/show_bug.cgi?id=188697
39         https://trac.webkit.org/changeset/238244
40
41 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
42
43         [css-logical] Implement flow-relative margin, padding and border shorthands
44         https://bugs.webkit.org/show_bug.cgi?id=188697
45
46         Reviewed by Simon Fraser and Antti Koivisto.
47
48         Add CSSLogicalEnabled runtime flag.
49
50         * WebView/WebPreferenceKeysPrivate.h:
51         * WebView/WebPreferences.mm:
52         (+[WebPreferences initialize]):
53         (-[WebPreferences cssLogicalEnabled]):
54         (-[WebPreferences setCSSLogicalEnabled:]):
55         * WebView/WebPreferencesPrivate.h:
56         * WebView/WebView.mm:
57         (-[WebView _preferencesChanged:]):
58
59 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
60
61         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
62         https://bugs.webkit.org/show_bug.cgi?id=191612
63
64         Reviewed by Matt Baker.
65
66         * WebCoreSupport/WebInspectorClient.mm:
67         (-[WebInspectorWindowController destroyInspectorView]):
68
69 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
70
71         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
72         https://bugs.webkit.org/show_bug.cgi?id=191494
73         <rdar://problem/45469854>
74
75         Reviewed by Devin Rousso.
76
77         * WebCoreSupport/WebInspectorClient.h:
78         WebKitLegacy will still have remote inspection of the Page directly.
79
80 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
81
82         Make compositing updates incremental
83         https://bugs.webkit.org/show_bug.cgi?id=90342
84
85         Reviewed by Antti Koivisto.
86
87         Fix spelling error.
88
89         * WebView/WebView.mm:
90         (-[WebView _setMediaLayer:forPluginView:]):
91
92 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
93
94         Implement a new edit command to change the enclosing list type
95         https://bugs.webkit.org/show_bug.cgi?id=191487
96         <rdar://problem/45955922>
97
98         Reviewed by Ryosuke Niwa.
99
100         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
101
102         * WebCoreSupport/WebEditorClient.mm:
103         (undoNameForEditAction):
104
105 2018-11-11  Daniel Bates  <dabates@apple.com>
106
107         [iOS] Draw caps lock indicator in password fields
108         https://bugs.webkit.org/show_bug.cgi?id=190565
109         <rdar://problem/45262343>
110
111         Reviewed by Dean Jackson.
112
113         Update the caps lock state when a hardware keyboard is attached or detached.
114
115         * WebView/WebHTMLView.mm:
116         (hardwareKeyboardAvailabilityChangedCallback): Added.
117         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
118         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
119
120 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
121
122         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
123         https://bugs.webkit.org/show_bug.cgi?id=191492
124
125         Reviewed by Alex Christensen.
126
127         * Carbon/HIWebView.mm:
128         * Misc/WebNSFileManagerExtras.mm:
129         * Misc/WebNSURLExtras.mm:
130         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
131         * Plugins/WebBasePluginPackage.mm:
132         * Plugins/WebPluginContainerCheck.mm:
133         * WebCoreSupport/WebCachedFramePlatformData.h:
134         * WebCoreSupport/WebDeviceOrientationClient.mm:
135         * WebView/WebDelegateImplementationCaching.mm:
136         * WebView/WebHTMLView.mm:
137         * WebView/WebPDFRepresentation.mm:
138         * WebView/WebPolicyDelegate.mm:
139         * WebView/WebView.mm:
140
141 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
142
143         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
144         https://bugs.webkit.org/show_bug.cgi?id=191492
145
146         Reviewed by Alex Christensen.
147
148         * Carbon/HIWebView.mm:
149         (UpdateCommandStatus):
150         * Misc/WebNSFileManagerExtras.mm:
151         * Misc/WebNSURLExtras.mm:
152         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
153         * Plugins/WebBasePluginPackage.mm:
154         * Plugins/WebPluginContainerCheck.mm:
155         (-[WebPluginContainerCheck _continueWithPolicy:]):
156         * WebCoreSupport/WebCachedFramePlatformData.h:
157         (WebCachedFramePlatformData::clear):
158         * WebCoreSupport/WebDeviceOrientationClient.mm:
159         (WebDeviceOrientationClient::getProvider const):
160         * WebView/WebDelegateImplementationCaching.mm:
161         (CallDelegate):
162         (CallDelegateReturningBoolean):
163         (CallResourceLoadDelegateReturningBoolean):
164         (CallFormDelegate):
165         (CallFormDelegateReturningBoolean):
166         * WebView/WebHTMLView.mm:
167         * WebView/WebPDFRepresentation.mm:
168         * WebView/WebPolicyDelegate.mm:
169         (-[WebPolicyDecisionListener _usePolicy:]):
170         * WebView/WebView.mm:
171
172 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
173
174         Unreviewed, rolling out r238047.
175
176         Introduced layout test failures on iOS simulator.
177
178         Reverted changeset:
179
180         "[iOS] Draw caps lock indicator in password fields"
181         https://bugs.webkit.org/show_bug.cgi?id=190565
182         https://trac.webkit.org/changeset/238047
183
184 2018-11-09  Antti Koivisto  <antti@apple.com>
185
186         Use OptionSet for layout milestones
187         https://bugs.webkit.org/show_bug.cgi?id=191470
188
189         Reviewed by Dean Jackson.
190
191         * WebCoreSupport/WebFrameLoaderClient.h:
192         * WebCoreSupport/WebFrameLoaderClient.mm:
193         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
194         * WebView/WebView.mm:
195         (coreLayoutMilestones):
196         (kitLayoutMilestones):
197         (-[WebView _cacheFrameLoadDelegateImplementations]):
198         * WebView/WebViewInternal.h:
199
200 2018-11-09  Daniel Bates  <dabates@apple.com>
201
202         [iOS] Draw caps lock indicator in password fields
203         https://bugs.webkit.org/show_bug.cgi?id=190565
204         <rdar://problem/45262343>
205
206         Reviewed by Dean Jackson.
207
208         Update the caps lock state when a hardware keyboard is attached or detached.
209
210         * WebView/WebHTMLView.mm:
211         (hardwareKeyboardAvailabilityChangedCallback): Added.
212         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
213         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
214
215 2018-11-09  Daniel Bates  <dabates@apple.com>
216
217         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
218         action when forward delete is pressed outside a text field
219         https://bugs.webkit.org/show_bug.cgi?id=190566
220         <rdar://problem/45262367>
221
222         Reviewed by Wenson Hsieh.
223
224         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
225         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
226         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
227
228         * WebView/WebHTMLView.mm:
229         (-[WebHTMLView _handleEditingKeyEvent:]):
230
231 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
232
233         Adopt Reveal Framework to replace Lookup
234         https://bugs.webkit.org/show_bug.cgi?id=191097
235         <rdar://problem/45924508>
236
237         Reviewed by Tim Horton.
238
239         Pass in what it needed to clear the textIndicators. This is better than
240         the current notification structure.
241
242         * WebView/WebView.mm:
243         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
244         (-[WebView _prepareForDictionaryLookup]):
245
246 2018-11-06  Justin Fan  <justin_fan@apple.com>
247
248         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
249         https://bugs.webkit.org/show_bug.cgi?id=191291
250
251         Reviewed by Myles Maxfield.
252
253         Properly disable WEBGPU on all non-Metal platforms for now.
254
255         * Configurations/FeatureDefines.xcconfig:
256
257 2018-11-02  Daniel Bates  <dabates@apple.com>
258
259         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
260         https://bugs.webkit.org/show_bug.cgi?id=190487
261
262         Reviewed by Tim Horton.
263
264         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
265         allow the default handling.
266
267         * WebView/WebHTMLView.mm:
268         (-[WebHTMLView _handleEditingKeyEvent:]):
269
270 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
271
272         Add a storage limit for IndexedDB
273         https://bugs.webkit.org/show_bug.cgi?id=190598
274         <rdar://problem/44654715>
275
276         Reviewed by Chris Dumez.
277
278         * Storage/WebDatabaseManager.mm:
279         (-[WebDatabaseManager setIDBPerOriginQuota:]):
280         * Storage/WebDatabaseManagerPrivate.h:
281
282 2018-10-31  Antti Koivisto  <antti@apple.com>
283
284         Remove LayerFlushScheduler
285         https://bugs.webkit.org/show_bug.cgi?id=191103
286
287         Reviewed by Anders Carlsson.
288
289         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
290         all the virtual cruft.
291
292         * WebView/WebViewData.h:
293         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
294         (): Deleted.
295         * WebView/WebViewData.mm:
296         (currentRunLoop):
297         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
298         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
299         (WebViewLayerFlushScheduler::schedule):
300         (WebViewLayerFlushScheduler::invalidate):
301         (WebViewLayerFlushScheduler::layerFlushCallback):
302
303 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
304
305         Enable InstallAPI for iOS unconditionally
306         https://bugs.webkit.org/show_bug.cgi?id=191043
307         rdar://problem/32728423
308
309         Reviewed by Dan Bernstein.
310
311         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
312         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
313         shouldn't be processed by InstallAPI.
314         * MigrateHeaders.make: Removed an obsolete workaround.
315         * Misc/NSURLDownloadSPI.h: Added.
316         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
317
318 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
319
320         Clean up some obsolete MAX_ALLOWED macros
321         https://bugs.webkit.org/show_bug.cgi?id=190916
322
323         Reviewed by Tim Horton.
324
325         * WebView/WebHTMLView.mm:
326         (-[WebHTMLView pressureChangeWithEvent:]):
327         * WebView/WebPDFView.h:
328
329 2018-10-30  Commit Queue  <commit-queue@webkit.org>
330
331         Unreviewed, rolling out r237600 and r237604.
332         https://bugs.webkit.org/show_bug.cgi?id=191086
333
334         Breaks internal iOS builds (Requested by ryanhadd_ on
335         #webkit).
336
337         Reverted changesets:
338
339         "Enable InstallAPI for iOS unconditionally"
340         https://bugs.webkit.org/show_bug.cgi?id=191043
341         https://trac.webkit.org/changeset/237600
342
343         "Build fix attempt after enabling InstallAPI for iOS."
344         https://bugs.webkit.org/show_bug.cgi?id=191043
345         https://trac.webkit.org/changeset/237604
346
347 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
348
349         Enable InstallAPI for iOS unconditionally
350         https://bugs.webkit.org/show_bug.cgi?id=191043
351         rdar://problem/32728423
352
353         Reviewed by Dan Bernstein.
354
355         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
356         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
357         shouldn't be processed by InstallAPI.
358         * MigrateHeaders.make: Removed an obsolete workaround.
359         * Misc/NSURLDownloadSPI.h: Added.
360         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
361
362 2018-10-29  Tim Horton  <timothy_horton@apple.com>
363
364         Modernize WebKit nibs and lprojs for localization's sake
365         https://bugs.webkit.org/show_bug.cgi?id=190911
366         <rdar://problem/45349466>
367
368         Reviewed by Dan Bernstein.
369
370         * Misc/WebNSControlExtras.m:
371         (-[NSControl sizeToFitAndAdjustWindowHeight]):
372         NSWindow and its contents are both in the same scale space these days; avoid
373         double-applying the scale factor, or you can't see the prompt.
374
375         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
376         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
377         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
378         NIB->XIB
379
380 2018-10-25  Antoine Quint  <graouts@apple.com>
381
382         [Web Animations] Turn Web Animations CSS Integration off by default
383         https://bugs.webkit.org/show_bug.cgi?id=190901
384
385         Reviewed by Dean Jackson.
386
387         * WebView/WebPreferences.mm:
388         (+[WebPreferences initialize]):
389
390 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
391
392         Clean up some obsolete macOS version guards
393         https://bugs.webkit.org/show_bug.cgi?id=190887
394
395         Reviewed by Dan Bernstein.
396
397         * Misc/WebNSPasteboardExtras.mm:
398         (+[NSPasteboard _web_dragTypesForURL]):
399         * WebCoreSupport/PopupMenuMac.mm:
400         (PopupMenuMac::show):
401         * WebCoreSupport/WebEditorClient.h:
402         * WebCoreSupport/WebEditorClient.mm:
403         (WebEditorClient::respondToChangedSelection):
404         * WebView/WebPDFView.mm:
405         (-[WebPDFView _clipViewForPDFDocumentView]):
406
407 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
408
409         Turn on Conic Gradients
410         https://bugs.webkit.org/show_bug.cgi?id=190810
411
412         Reviewed by Tim Horton.
413
414         * Configurations/FeatureDefines.xcconfig:
415
416 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
417
418         Cleanup: MIMETypeRegistry functions
419         https://bugs.webkit.org/show_bug.cgi?id=190838
420
421         Reviewed by Simon Fraser.
422
423         * Misc/WebNSPasteboardExtras.mm:
424         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
425         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
426         because they were identical.
427
428         * WebView/WebHTMLRepresentation.mm:
429         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
430         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
431         (+[WebHTMLRepresentation supportedImageMIMETypes]):
432         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
433         * WebView/WebView.mm:
434         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
435         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
436         (+[WebView registerViewClass:representationClass:forMIMEType:]):
437
438 2018-10-23  David Kilzer  <ddkilzer@apple.com>
439
440         Fix false positive leaks when using custom -init methods that don't start with -init
441         <https://webkit.org/b/190818>
442         <rdar://problem/45476042>
443
444         Reviewed by Dan Bernstein.
445
446         * Misc/WebKitErrors.m: Move `descriptions` static global so that
447         it is accessible by both categories.
448         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
449         NSError (WebKitInternal) category.  Add attribute to make this
450         behave like an -init method.
451         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
452         NSError (WebKitInternal) category.  Modernize method.  Replace
453         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
454
455 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
456
457         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
458         https://bugs.webkit.org/show_bug.cgi?id=190729
459
460         Reviewed by Tim Horton.
461
462         * DOM/DOM.mm:
463         (-[DOMNode boundingBox]):
464         * DOM/DOMElement.mm:
465         * DOM/DOMHTML.mm:
466         * DOM/DOMInternal.mm:
467         * DOM/DOMUIKitExtensions.mm:
468         * DOM/WebDOMOperations.mm:
469         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
470         * DefaultDelegates/WebDefaultEditingDelegate.m:
471         * DefaultDelegates/WebDefaultPolicyDelegate.m:
472         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
473         * DefaultDelegates/WebDefaultUIDelegate.h:
474         * DefaultDelegates/WebDefaultUIDelegate.mm:
475         (-[WebDefaultUIDelegate webViewClose:]):
476         (-[WebDefaultUIDelegate webViewFocus:]):
477         (-[WebDefaultUIDelegate webViewUnfocus:]):
478         (-[WebDefaultUIDelegate webViewIsResizable:]):
479         (-[WebDefaultUIDelegate webView:setResizable:]):
480         (-[WebDefaultUIDelegate webView:setFrame:]):
481         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
482         * History/BackForwardList.h:
483         * History/BackForwardList.mm:
484         * History/WebBackForwardList.mm:
485         (+[WebBackForwardList initialize]):
486         (bumperCarBackForwardHackNeeded):
487         * History/WebHistory.mm:
488         (-[WebHistoryPrivate addItem:discardDuplicate:]):
489         (-[WebHistory _sendNotification:entries:]):
490         (-[WebHistory loadFromURL:error:]):
491         (-[WebHistory saveToURL:error:]):
492         * History/WebHistoryItem.mm:
493         (WKNotifyHistoryItemChanged):
494         (+[WebHistoryItem initialize]):
495         (-[WebHistoryItem initFromDictionaryRepresentation:]):
496         * History/WebURLsWithTitles.m:
497         * Misc/WebCache.mm:
498         (+[WebCache initialize]):
499         * Misc/WebDownload.mm:
500         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
501         * Misc/WebElementDictionary.mm:
502         (+[WebElementDictionary initialize]):
503         (+[WebElementDictionary initializeLookupTable]):
504         * Misc/WebIconDatabase.mm:
505         * Misc/WebKitNSStringExtras.mm:
506         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
507         * Misc/WebKitVersionChecks.h:
508         * Misc/WebKitVersionChecks.mm:
509         (WebKitLinkedOnOrAfter):
510         (WebKitLinkTimeVersion):
511         * Misc/WebLocalizableStrings.mm:
512         * Misc/WebNSControlExtras.h:
513         * Misc/WebNSControlExtras.m:
514         * Misc/WebNSEventExtras.m:
515         * Misc/WebNSFileManagerExtras.mm:
516         * Misc/WebNSImageExtras.h:
517         * Misc/WebNSImageExtras.m:
518         * Misc/WebNSPasteboardExtras.mm:
519         * Misc/WebNSPrintOperationExtras.h:
520         * Misc/WebNSPrintOperationExtras.m:
521         * Misc/WebNSViewExtras.m:
522         * Misc/WebNSWindowExtras.m:
523         * Panels/WebAuthenticationPanel.h:
524         * Panels/WebAuthenticationPanel.m:
525         * Panels/WebPanelAuthenticationHandler.m:
526         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
527         (+[WebHostedNetscapePluginView initialize]):
528         * Plugins/WebBasePluginPackage.h:
529         * Plugins/WebBasePluginPackage.mm:
530         * Plugins/WebJavaPlugIn.h:
531         * Plugins/WebPluginContainerCheck.mm:
532         * Plugins/WebPluginController.h:
533         * Plugins/WebPluginController.mm:
534         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
535         (-[WebPluginController addPlugin:]):
536         (-[WebPluginController destroyPlugin:]):
537         (-[WebPluginController destroyAllPlugins]):
538         * Plugins/WebPluginDatabase.mm:
539         (+[WebPluginDatabase _defaultPlugInPaths]):
540         * Plugins/WebPluginPackage.mm:
541         (-[WebPluginPackage initWithPath:]):
542         * Storage/WebDatabaseManager.mm:
543         (-[WebDatabaseManager deleteAllDatabases]):
544         * Storage/WebDatabaseManagerClient.h:
545         * Storage/WebDatabaseManagerClient.mm:
546         (WebDatabaseManagerClient::WebDatabaseManagerClient):
547         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
548         * Storage/WebStorageManager.mm:
549         (-[WebStorageManager deleteAllOrigins]):
550         (WebKitInitializeStorageIfNecessary):
551         * WebCoreSupport/WebAlternativeTextClient.h:
552         * WebCoreSupport/WebApplicationCache.mm:
553         (applicationCacheBundleIdentifier):
554         * WebCoreSupport/WebChromeClient.h:
555         * WebCoreSupport/WebChromeClient.mm:
556         (WebChromeClient::setWindowRect):
557         (WebChromeClient::windowRect):
558         (WebChromeClient::takeFocus):
559         (WebChromeClient::addMessageToConsole):
560         (WebChromeClient::enableSuddenTermination):
561         (WebChromeClient::disableSuddenTermination):
562         (WebChromeClient::createPopupMenu const):
563         (WebChromeClient::createSearchPopupMenu const):
564         (WebChromeClient::shouldPaintEntireContents const):
565         (WebChromeClient::supportsVideoFullscreen):
566         (WebChromeClient::supportsFullScreenForElement):
567         (WebChromeClient::enterFullScreenForElement):
568         (WebChromeClient::exitFullScreenForElement):
569         * WebCoreSupport/WebContextMenuClient.mm:
570         * WebCoreSupport/WebDragClient.mm:
571         * WebCoreSupport/WebEditorClient.h:
572         * WebCoreSupport/WebEditorClient.mm:
573         (+[WebUndoStep initialize]):
574         (updateFontPanel):
575         (WebEditorClient::didBeginEditing):
576         (WebEditorClient::respondToChangedContents):
577         (WebEditorClient::respondToChangedSelection):
578         (WebEditorClient::canceledComposition):
579         (WebEditorClient::didEndEditing):
580         (WebEditorClient::didWriteSelectionToPasteboard):
581         (attributesForAttributedStringConversion):
582         (WebEditorClient::setInsertionPasteboard):
583         (WebEditorClient::registerUndoOrRedoStep):
584         (WebEditorClient::handleKeyboardEvent):
585         (WebEditorClient::handleInputMethodKeydown):
586         (WebEditorClient::textDidChangeInTextField):
587         (WebEditorClient::requestCheckingOfString):
588         * WebCoreSupport/WebFrameLoaderClient.h:
589         * WebCoreSupport/WebFrameLoaderClient.mm:
590         (WebFrameLoaderClient::detachedFromParent2):
591         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
592         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
593         (WebFrameLoaderClient::dispatchWillSendRequest):
594         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
595         (WebFrameLoaderClient::dispatchDidReceiveResponse):
596         (WebFrameLoaderClient::willCacheResponse const):
597         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
598         (WebFrameLoaderClient::dispatchDidFinishLoading):
599         (WebFrameLoaderClient::dispatchDidFailLoading):
600         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
601         (WebFrameLoaderClient::dispatchWillClose):
602         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
603         (WebFrameLoaderClient::dispatchDidCommitLoad):
604         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
605         (WebFrameLoaderClient::dispatchDidFailLoad):
606         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
607         (WebFrameLoaderClient::dispatchDidFinishLoad):
608         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
609         (WebFrameLoaderClient::willChangeTitle):
610         (WebFrameLoaderClient::didChangeTitle):
611         (WebFrameLoaderClient::didReplaceMultipartContent):
612         (WebFrameLoaderClient::updateGlobalHistory):
613         (WebFrameLoaderClient::saveViewStateToItem):
614         (WebFrameLoaderClient::restoreViewState):
615         (WebFrameLoaderClient::provisionalLoadStarted):
616         (WebFrameLoaderClient::prepareForDataSourceReplacement):
617         (WebFrameLoaderClient::setTitle):
618         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
619         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
620         (WebFrameLoaderClient::transitionToCommittedForNewPage):
621         (WebFrameLoaderClient::didRestoreFromPageCache):
622         (WebFrameLoaderClient::actionDictionary const):
623         (WebFrameLoaderClient::createPlugin):
624         (WebFrameLoaderClient::getLoadDecisionForIcons):
625         (WebFrameLoaderClient::finishedLoadingIcon):
626         (+[WebFramePolicyListener initialize]):
627         * WebCoreSupport/WebFrameNetworkingContext.mm:
628         * WebCoreSupport/WebGeolocationClient.h:
629         * WebCoreSupport/WebGeolocationClient.mm:
630         (WebGeolocationClient::requestPermission):
631         * WebCoreSupport/WebInspectorClient.h:
632         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
633         * WebCoreSupport/WebNotificationClient.mm:
634         * WebCoreSupport/WebOpenPanelResultListener.mm:
635         * WebCoreSupport/WebPlatformStrategies.h:
636         * WebCoreSupport/WebPlatformStrategies.mm:
637         * WebCoreSupport/WebProgressTrackerClient.h:
638         * WebCoreSupport/WebProgressTrackerClient.mm:
639         (WebProgressTrackerClient::progressStarted):
640         (WebProgressTrackerClient::progressEstimateChanged):
641         (WebProgressTrackerClient::progressFinished):
642         * WebCoreSupport/WebSecurityOrigin.mm:
643         * WebInspector/WebNodeHighlight.h:
644         * WebInspector/WebNodeHighlight.mm:
645         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
646         (-[WebNodeHighlight dealloc]):
647         (-[WebNodeHighlight attach]):
648         * WebInspector/WebNodeHighlightView.h:
649         * WebInspector/WebNodeHighlightView.mm:
650         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
651         (-[WebNodeHighlightView dealloc]):
652         * WebInspector/WebNodeHighlighter.mm:
653         (-[WebNodeHighlighter highlight]):
654         * WebView/WebArchive.mm:
655         (+[WebArchivePrivate initialize]):
656         * WebView/WebClipView.h:
657         * WebView/WebDataSource.mm:
658         (WebDataSourcePrivate::WebDataSourcePrivate):
659         (+[WebDataSource initialize]):
660         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
661         (-[WebDataSource _makeRepresentation]):
662         * WebView/WebDelegateImplementationCaching.h:
663         * WebView/WebDelegateImplementationCaching.mm:
664         (CallDelegate):
665         (CallDelegateReturningFloat):
666         (CallDelegateReturningBoolean):
667         (CallUIDelegate):
668         (CallUIDelegateReturningFloat):
669         (CallUIDelegateReturningBoolean):
670         (CallFrameLoadDelegate):
671         (CallFrameLoadDelegateReturningBoolean):
672         (CallResourceLoadDelegate):
673         (CallScriptDebugDelegate):
674         (CallFormDelegate):
675         (CallFormDelegateReturningBoolean):
676         * WebView/WebDeviceOrientation.mm:
677         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
678         * WebView/WebDocumentInternal.h:
679         * WebView/WebDocumentLoaderMac.mm:
680         (needsDataLoadWorkaround):
681         * WebView/WebDynamicScrollBarsViewInternal.h:
682         * WebView/WebFormDelegate.m:
683         * WebView/WebFrame.mm:
684         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
685         (-[WebFrame _unmarkAllMisspellings]):
686         (-[WebFrame _paintBehaviorForDestinationContext:]):
687         (-[WebFrame _drawRect:contentsOnly:]):
688         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
689         (-[WebFrame _scrollDOMRangeToVisible:]):
690         (-[WebFrame _bodyBackgroundColor]):
691         (-[WebFrame accessibilityRoot]):
692         (needsMicrosoftMessengerDOMDocumentWorkaround):
693         * WebView/WebFrameInternal.h:
694         * WebView/WebFrameView.mm:
695         (-[WebFrameView _setDocumentView:]):
696         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
697         (-[WebFrameView _viewClassForMIMEType:]):
698         (-[WebFrameView initWithFrame:]):
699         (-[WebFrameView drawRect:]):
700         (-[WebFrameView _firstResponderIsFormControl]):
701         (-[WebFrameView keyDown:keyDown:]):
702         (-[WebFrameView _isScrollable]):
703         * WebView/WebFullScreenController.h:
704         * WebView/WebFullScreenController.mm:
705         * WebView/WebHTMLRepresentation.mm:
706         * WebView/WebHTMLView.mm:
707         (-[WebHTMLView hitTest:]):
708         (-[WebHTMLView initWithFrame:]):
709         (-[WebHTMLView dealloc]):
710         (-[WebHTMLView addSubview:]):
711         (-[WebHTMLView mouseDown:]):
712         (-[WebHTMLView mouseUp:]):
713         (-[WebHTMLView resignFirstResponder]):
714         (-[WebHTMLView accessibilityHitTest:]):
715         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
716         * WebView/WebHTMLViewInternal.h:
717         * WebView/WebIndicateLayer.h:
718         * WebView/WebIndicateLayer.mm:
719         * WebView/WebMediaPlaybackTargetPicker.h:
720         * WebView/WebMediaPlaybackTargetPicker.mm:
721         * WebView/WebPDFDocumentExtras.h:
722         * WebView/WebPDFDocumentExtras.mm:
723         * WebView/WebPDFRepresentation.h:
724         * WebView/WebPDFRepresentation.mm:
725         * WebView/WebPDFView.h:
726         * WebView/WebPreferences.mm:
727         (cacheModelForMainBundle):
728         (WebPreferencesPrivate::WebPreferencesPrivate):
729         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
730         (-[WebPreferences encodeWithCoder:]):
731         (+[WebPreferences standardPreferences]):
732         (+[WebPreferences initialize]):
733         (-[WebPreferences _valueForKey:]):
734         (-[WebPreferences _setStringValue:forKey:]):
735         (-[WebPreferences _setIntegerValue:forKey:]):
736         (-[WebPreferences _setUnsignedIntValue:forKey:]):
737         (-[WebPreferences _setFloatValue:forKey:]):
738         (-[WebPreferences _setBoolValue:forKey:]):
739         (-[WebPreferences _setLongLongValue:forKey:]):
740         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
741         (-[WebPreferences _postCacheModelChangedNotification]):
742         (-[WebPreferences _postPreferencesChangedNotification]):
743         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
744         (-[WebPreferences setStorageBlockingPolicy:]):
745         * WebView/WebResource.mm:
746         (+[WebResourcePrivate initialize]):
747         * WebView/WebTextCompletionController.h:
748         * WebView/WebTextIterator.mm:
749         (+[WebTextIteratorPrivate initialize]):
750         * WebView/WebView.mm:
751         (shouldEnableLoadDeferring):
752         (shouldRestrictWindowFocus):
753         (shouldRespectPriorityInCSSAttributeSetters):
754         (shouldUseLegacyBackgroundSizeShorthandBehavior):
755         (shouldAllowPictureInPictureMediaPlayback):
756         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
757         (shouldAllowWindowOpenWithoutUserGesture):
758         (shouldConvertInvalidURLsToBlank):
759         (shouldRequireUserGestureToLoadVideo):
760         (-[WebView _commonInitializationWithFrameName:groupName:]):
761         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
762         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
763         (-[WebView _closePluginDatabases]):
764         (-[WebView _closeWithFastTeardown]):
765         (-[WebView _close]):
766         (+[WebView _MIMETypeForFile:]):
767         (-[WebView setShowingInspectorIndication:]):
768         (-[WebView _setFormDelegate:]):
769         (-[WebView _needsPreHTML5ParserQuirks]):
770         (-[WebView _preferencesChangedNotification:]):
771         (-[WebView _preferencesChanged:]):
772         (-[WebView _cacheResourceLoadDelegateImplementations]):
773         (-[WebView _cacheFrameLoadDelegateImplementations]):
774         (-[WebView _policyDelegateForwarder]):
775         (-[WebView _UIDelegateForwarder]):
776         (-[WebView _editingDelegateForwarder]):
777         (-[WebView _updateActiveState]):
778         (-[_WebSafeForwarder forwardInvocation:]):
779         (+[WebView initialize]):
780         (-[WebView _pluginForMIMEType:]):
781         (-[WebView _pluginForExtension:]):
782         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
783         (+[WebView canShowMIMETypeAsHTML:]):
784         (-[WebView _initWithArguments:]):
785         (-[WebView initWithFrame:frameName:groupName:]):
786         (-[WebView dealloc]):
787         (-[WebView close]):
788         (-[WebView viewDidMoveToWindow]):
789         (-[WebView setUIDelegate:]):
790         (-[WebView setResourceLoadDelegate:]):
791         (-[WebView setPolicyDelegate:]):
792         (-[WebView setFrameLoadDelegate:]):
793         (-[WebView goBack]):
794         (-[WebView goForward]):
795         (-[WebView stringByEvaluatingJavaScriptFromString:]):
796         (-[WebView setHostWindow:]):
797         (-[WebView becomeFirstResponder]):
798         (+[WebView _cacheModelChangedNotification:]):
799         (-[WebView _frameViewAtWindowPoint:]):
800         (+[WebView _preflightSpellCheckerNow:]):
801         (+[WebView _preflightSpellChecker]):
802         (-[WebView canGoBack]):
803         (-[WebView canGoForward]):
804         (-[WebView stopLoading:]):
805         (-[WebView reload:]):
806         (-[WebView setMainFrameDocumentReady:]):
807         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
808         (-[WebView setContinuousSpellCheckingEnabled:]):
809         (-[WebView undoManager]):
810         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
811         (-[WebView isAutomaticLinkDetectionEnabled]):
812         (-[WebView isAutomaticDashSubstitutionEnabled]):
813         (-[WebView isAutomaticTextReplacementEnabled]):
814         (-[WebView isAutomaticSpellingCorrectionEnabled]):
815         (+[WebView _setCacheModel:]):
816         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
817         (-[WebView _keyboardUIMode]):
818         (LayerFlushController::flushLayers):
819         (-[WebView _scheduleCompositingLayerFlush]):
820         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
821         (-[WebView fullScreenPlaceholderView]):
822         (WebInstallMemoryPressureHandler):
823         * WebView/WebViewData.h:
824         * WebView/WebViewData.mm:
825         (+[WebViewPrivate initialize]):
826         (-[WebViewPrivate init]):
827         (-[WebViewPrivate dealloc]):
828         * WebView/WebViewInternal.h:
829
830 2018-10-18  Alex Christensen  <achristensen@webkit.org>
831
832         Clean up FrameLoader two-state enums
833         https://bugs.webkit.org/show_bug.cgi?id=190731
834
835         Reviewed by Chris Dumez.
836
837         * WebCoreSupport/WebFrameLoaderClient.h:
838         * WebCoreSupport/WebFrameLoaderClient.mm:
839         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
840
841 2018-10-18  Alex Christensen  <achristensen@webkit.org>
842
843         Unreviewed, rolling out r237137.
844
845         SPI is actually used
846
847         Reverted changeset:
848
849         "Remove unused WebFrame._loadType"
850         https://bugs.webkit.org/show_bug.cgi?id=190583
851         https://trac.webkit.org/changeset/237137
852
853 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         Enable the datalist element by default on iOS and macOS
856         https://bugs.webkit.org/show_bug.cgi?id=190594
857         <rdar://problem/45281159>
858
859         Reviewed by Ryosuke Niwa and Tim Horton.
860
861         * Configurations/FeatureDefines.xcconfig:
862
863 2018-10-17  Alex Christensen  <achristensen@webkit.org>
864
865         BackForwardClient needs to be able to support UIProcess-only back/forward lists
866         https://bugs.webkit.org/show_bug.cgi?id=190675
867
868         Reviewed by Chris Dumez.
869
870         * History/BackForwardList.h:
871         * History/BackForwardList.mm:
872         (BackForwardList::backItem):
873         (BackForwardList::currentItem):
874         (BackForwardList::forwardItem):
875         (BackForwardList::backListCount const):
876         (BackForwardList::forwardListCount const):
877         (BackForwardList::itemAtIndex):
878         * History/WebBackForwardList.mm:
879         (-[WebBackForwardList backItem]):
880         (-[WebBackForwardList currentItem]):
881         (-[WebBackForwardList forwardItem]):
882         (-[WebBackForwardList itemAtIndex:]):
883
884 2018-10-16  Timothy Hatcher  <timothy@apple.com>
885
886         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
887         https://bugs.webkit.org/show_bug.cgi?id=190526
888         rdar://problem/45230140
889
890         Reviewed by Dean Jackson.
891
892         * WebCoreSupport/WebEditorClient.mm:
893         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
894
895 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
896
897         Implement feature flag and bindings for CSS Painting API
898         https://bugs.webkit.org/show_bug.cgi?id=190237
899
900         Reviewed by Ryosuke Niwa.
901
902         * Configurations/FeatureDefines.xcconfig:
903
904 2018-10-16  Alex Christensen  <achristensen@webkit.org>
905
906         Replace HistoryItem* with HistoryItem& where possible
907         https://bugs.webkit.org/show_bug.cgi?id=190617
908
909         Reviewed by Chris Dumez.
910
911         * History/BackForwardList.h:
912         * History/BackForwardList.mm:
913         (BackForwardList::goToItem):
914         * History/WebBackForwardList.mm:
915         (-[WebBackForwardList goToItem:]):
916         * History/WebHistoryItem.mm:
917         (WKNotifyHistoryItemChanged):
918         * History/WebHistoryItemInternal.h:
919
920 2018-10-16  Alex Christensen  <achristensen@webkit.org>
921
922         Remove unused WebHistoryItem._transientPropertyForKey
923         https://bugs.webkit.org/show_bug.cgi?id=190606
924
925         Reviewed by Chris Dumez.
926
927         * History/WebHistoryItem.mm:
928         * History/WebHistoryItemPrivate.h:
929
930 2018-10-15  Justin Fan  <justin_fan@apple.com>
931
932         Add WebGPU 2018 feature flag and experimental feature flag
933         https://bugs.webkit.org/show_bug.cgi?id=190509
934
935         Reviewed by Dean Jackson.
936
937         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
938         for the 2018 WebGPU prototype.
939
940         * Configurations/FeatureDefines.xcconfig:
941         * WebView/WebPreferenceKeysPrivate.h:
942         * WebView/WebPreferences.mm:
943         (+[WebPreferences initialize]):
944         (-[WebPreferences webGPUEnabled]):
945         (-[WebPreferences setWebGPUEnabled:]):
946         * WebView/WebPreferencesPrivate.h:
947         * WebView/WebView.mm:
948         (-[WebView _preferencesChanged:]):
949
950 2018-10-15  Alex Christensen  <achristensen@webkit.org>
951
952         Fix iOS build after r237157
953
954         * WebView/WebView.mm:
955         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
956
957 2018-10-15  Alex Christensen  <achristensen@webkit.org>
958
959         Modernize BackForwardClient.h
960         https://bugs.webkit.org/show_bug.cgi?id=190610
961
962         Reviewed by Chris Dumez.
963
964         * History/BackForwardList.h:
965         * History/BackForwardList.mm:
966         (BackForwardList::backListCount const):
967         (BackForwardList::forwardListCount const):
968         (BackForwardList::backListCount): Deleted.
969         (BackForwardList::forwardListCount): Deleted.
970         * History/WebBackForwardList.mm:
971         (-[WebBackForwardList init]):
972         * WebCoreSupport/WebFrameLoaderClient.mm:
973         (WebFrameLoaderClient::canCachePage const):
974         * WebView/WebFrameView.mm:
975         (-[WebFrameView keyDown:keyDown:]):
976         * WebView/WebView.mm:
977         (-[WebView _commonInitializationWithFrameName:groupName:]):
978         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
979         (-[WebView _loadBackForwardListFromOtherView:]):
980         (-[WebView initWithCoder:]):
981         (-[WebView encodeWithCoder:]):
982         (-[WebView backForwardList]):
983         (-[WebView setMaintainsBackForwardList:]):
984
985 2018-10-15  Timothy Hatcher  <timothy@apple.com>
986
987         Add support for prefers-color-scheme media query
988         https://bugs.webkit.org/show_bug.cgi?id=190499
989         rdar://problem/45212025
990
991         Reviewed by Dean Jackson.
992
993         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
994
995 2018-10-15  Alex Christensen  <achristensen@webkit.org>
996
997         Remove unused WebView._globalHistoryItem
998         https://bugs.webkit.org/show_bug.cgi?id=190601
999
1000         Reviewed by Chris Dumez.
1001
1002         * WebCoreSupport/WebFrameLoaderClient.h:
1003         * WebCoreSupport/WebFrameLoaderClient.mm:
1004         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1005         * WebView/WebView.mm:
1006         (-[WebView _globalHistoryItem]): Deleted.
1007         (-[WebView _setGlobalHistoryItem:]): Deleted.
1008         * WebView/WebViewData.h:
1009         * WebView/WebViewInternal.h:
1010         * WebView/WebViewPrivate.h:
1011
1012 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1013
1014         Remove unused parameters from FrameLoaderClient::createFrame
1015         https://bugs.webkit.org/show_bug.cgi?id=190587
1016
1017         Reviewed by Chris Dumez.
1018
1019         * WebCoreSupport/WebFrameLoaderClient.h:
1020         * WebCoreSupport/WebFrameLoaderClient.mm:
1021         (WebFrameLoaderClient::createFrame):
1022
1023 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1024
1025         Remove unused WebFrame._loadType
1026         https://bugs.webkit.org/show_bug.cgi?id=190583
1027
1028         Reviewed by Chris Dumez.
1029
1030         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1031
1032         * WebView/WebFrame.mm:
1033         (toWebFrameLoadType): Deleted.
1034         (-[WebFrame _loadType]): Deleted.
1035         * WebView/WebFramePrivate.h:
1036
1037 2018-10-15  Chris Dumez  <cdumez@apple.com>
1038
1039         Restrict browsing context lookup by name to frames that are related to one another
1040         https://bugs.webkit.org/show_bug.cgi?id=190475
1041
1042         Reviewed by Alex Christensen.
1043
1044         * WebView/WebFrame.mm:
1045         (-[WebFrame findFrameNamed:]):
1046
1047 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1048
1049         Remove InjectedBundle processing of back/forward lists
1050         https://bugs.webkit.org/show_bug.cgi?id=190459
1051
1052         Reviewed by Chris Dumez.
1053
1054         * WebCoreSupport/WebFrameLoaderClient.h:
1055         * WebCoreSupport/WebFrameLoaderClient.mm:
1056         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1057
1058 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1059
1060         [JSC] Remove Option::useAsyncIterator
1061         https://bugs.webkit.org/show_bug.cgi?id=190567
1062
1063         Reviewed by Saam Barati.
1064
1065         * Configurations/FeatureDefines.xcconfig:
1066
1067 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1068
1069         Allow encoding of small enum classes
1070         https://bugs.webkit.org/show_bug.cgi?id=190531
1071
1072         Reviewed by Tim Horton.
1073
1074         * WebCoreSupport/WebFrameLoaderClient.mm:
1075         (-[WebFramePolicyListener dealloc]):
1076
1077 2018-10-11  Keith Rollin  <krollin@apple.com>
1078
1079         CURRENT_ARCH should not be used in Run Script phase.
1080         https://bugs.webkit.org/show_bug.cgi?id=190407
1081         <rdar://problem/45133556>
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1086         CURRENT_ARCH is not well-defined during this phase (and may even have
1087         the value "undefined") since this phase is run just once per build
1088         rather than once per supported architecture. Migrate away from
1089         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1090         performing an operation for each value, or by picking the first entry
1091         in ARCHS and using that as a representative value.
1092
1093         * Configurations/WebKitLegacy.xcconfig: When generating
1094         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1095         macosx platforms.
1096
1097         * MigrateHeaders.make:
1098         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1099         generate one for each architecture in ARCHS.
1100
1101 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1102
1103         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1104         https://bugs.webkit.org/show_bug.cgi?id=190429
1105
1106         Reviewed by Saam Barati.
1107
1108         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1109
1110         * WebView/WebPDFRepresentation.mm:
1111         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1112
1113 2018-10-08  Justin Fan  <justin_fan@apple.com>
1114
1115         WebGPU: Rename old WebGPU prototype to WebMetal
1116         https://bugs.webkit.org/show_bug.cgi?id=190325
1117         <rdar://problem/44990443>
1118
1119         Reviewed by Dean Jackson.
1120
1121         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1122
1123         * Configurations/FeatureDefines.xcconfig:
1124         * WebView/WebPreferenceKeysPrivate.h:
1125         * WebView/WebPreferences.mm:
1126         (+[WebPreferences initialize]):
1127         (-[WebPreferences webMetalEnabled]):
1128         (-[WebPreferences setWebMetalEnabled:]):
1129         (-[WebPreferences webGPUEnabled]): Deleted.
1130         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1131         * WebView/WebPreferencesPrivate.h:
1132         * WebView/WebView.mm:
1133         (-[WebView _preferencesChanged:]):
1134
1135 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1136
1137         Make <input type=color> a runtime enabled (on-by-default) feature
1138         https://bugs.webkit.org/show_bug.cgi?id=189162
1139
1140         Reviewed by Wenson Hsieh and Tim Horton.
1141
1142         * Configurations/FeatureDefines.xcconfig:
1143
1144 2018-10-07  Dan Bernstein  <mitz@apple.com>
1145
1146         Fixed building with the latest macOS SDK
1147
1148         * Plugins/WebNetscapePluginPackage.mm:
1149         (-[WebNetscapePluginPackage openResourceFile]):
1150         (-[WebNetscapePluginPackage closeResourceFile:]):
1151
1152 2018-10-04  Dan Bernstein  <mitz@apple.com>
1153
1154         More Carbon build-fixing.
1155
1156         * Carbon/CarbonWindowAdapter.mm:
1157         (-[CarbonWindowAdapter _destroyRealWindow:]):
1158         (-[CarbonWindowAdapter _growBoxRect]):
1159
1160 2018-10-04  Dan Bernstein  <mitz@apple.com>
1161
1162         Retried to fix 32-bit macOS builds after r236846.
1163
1164         * WebView/WebHTMLView.mm:
1165         (-[WebHTMLView setMarkedText:selectedRange:]):
1166
1167 2018-10-04  Dan Bernstein  <mitz@apple.com>
1168
1169         Retried to fix 32-bit macOS builds after r236846.
1170
1171         * Carbon/HIWebView.mm:
1172         (ActiveStateChanged):
1173
1174 2018-10-04  Dan Bernstein  <mitz@apple.com>
1175
1176         Tried to fix 32-bit macOS builds after r236846.
1177
1178         * Carbon/HIWebView.mm:
1179         (_NSSelectorForHICommand):
1180
1181 2018-10-04  Dan Bernstein  <mitz@apple.com>
1182
1183         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1184         https://bugs.webkit.org/show_bug.cgi?id=190250
1185
1186         Reviewed by Andy Estes.
1187
1188         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1189           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1190           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1191           an earlier line set it to YES.
1192
1193         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1194         changes below.
1195
1196         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1197           provides some missing method declarations.
1198
1199         * Misc/WebDownload.mm:
1200         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1201           a deprecated method.
1202
1203         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1204
1205         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1206           other code in the file uses a method from it.
1207
1208         * Plugins/WebBaseNetscapePluginView.mm:
1209         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1210           a deprecated method.
1211
1212         * Plugins/WebPluginController.mm:
1213         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1214           around use of a selector that may be present in some WebKit client.
1215
1216         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1217           method declarations.
1218
1219         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1220           from here.
1221
1222         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1223           missing method declarations.
1224
1225         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1226           from here.
1227
1228         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1229           call from here.
1230         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1231           an obsolete delegate method for binary compatibility.
1232         (pluginView): Ditto.
1233
1234         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1235           call from here.
1236
1237         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1238           WebDeviceOrientationProviderMock protocol.
1239
1240         * WebView/WebDeviceOrientationProviderMock.mm:
1241         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1242           main @implementation.
1243
1244         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1245           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1246
1247         * WebView/WebDynamicScrollBarsView.mm:
1248         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1249           of a deprecated method.
1250
1251         * WebView/WebHTMLView.mm:
1252         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1253           selector warning around action methods that are not declared anywhere in WebKit.
1254
1255         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1256           about implementing this deprecated method.
1257         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1258         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1259         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1260         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1261         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1262         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1263         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1264         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1265         (-[WebHTMLView doCommandBySelector:]): Ditto.
1266         (-[WebHTMLView insertText:]): Ditto.
1267
1268         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1269
1270         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1271
1272         * WebView/WebPDFView.h: Removed previewView ivar.
1273
1274         * WebView/WebPDFView.mm:
1275           Removed declaration of FileInternal category and merged its implementation with the main
1276           implementation.
1277         (-[WebPDFView dealloc]): Removed previewView ivar.
1278         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1279           exist in macOS versions we support.
1280         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1281         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1282           action methods internal to PDFKit.
1283         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1284         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1285
1286         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1287           call on macOS, even though in r86988 we started calling different methods on iOS.
1288
1289         * WebView/WebView.mm:
1290         - Imported headers that declare delegate methods that we call.
1291         - Removed declaration of WebFileInternal category and merged its implementation with the
1292           main implementation.
1293         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1294           category, which made them impossible to call from the main implementation. Moved those
1295           into the main implementation. One of those had to be declared in a class extension,
1296           because it is called from a method implemented in the WebPrivate category, and that
1297           category’s implementation appears first in the file.
1298
1299         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1300           around use of obsolete delegate method for binary compatibility.
1301
1302         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1303
1304 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1305
1306         Runtime flag and IDL for MediaRecorder
1307         https://bugs.webkit.org/show_bug.cgi?id=190018
1308
1309         Reviewed by Youenn Fablet and Chris Dumez.
1310
1311         * WebView/WebPreferenceKeysPrivate.h:
1312         * WebView/WebPreferences.mm:
1313         (+[WebPreferences initialize]):
1314         (-[WebPreferences mediaRecorderEnabled]):
1315         (-[WebPreferences setMediaRecorderEnabled:]):
1316         * WebView/WebPreferencesPrivate.h:
1317         * WebView/WebView.mm:
1318         (-[WebView _preferencesChanged:]):
1319
1320 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1321
1322         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1323         https://bugs.webkit.org/show_bug.cgi?id=190238
1324
1325         Reviewed by Antti Koivisto.
1326
1327         Enabled the feature by default.
1328
1329         * WebView/WebPreferences.mm:
1330         (+[WebPreferences initialize]):
1331
1332 2018-10-01  Dean Jackson  <dino@apple.com>
1333
1334         [macOS] Switching to discrete GPU should be done in the UI process
1335         https://bugs.webkit.org/show_bug.cgi?id=189361
1336         <rdar://problem/43949622>
1337
1338         Reviewed by Simon Fraser.
1339
1340         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1341         not support swapping to the discrete GPU in this configuration.
1342
1343         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1344         (WebKit::WebSwitchingGPUClient::singleton):
1345         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1346         * WebView/WebView.mm:
1347         (-[WebView _commonInitializationWithFrameName:groupName:]):
1348
1349 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1350
1351         Remove ParsedURLString
1352         https://bugs.webkit.org/show_bug.cgi?id=190154
1353
1354         Reviewed by Chris Dumez.
1355
1356         * WebView/WebScriptDebugger.mm:
1357         (toNSURL):
1358
1359 2018-10-01  Dean Jackson  <dino@apple.com>
1360
1361         Remove CSS Animation Triggers
1362         https://bugs.webkit.org/show_bug.cgi?id=190175
1363         <rdar://problem/44925626>
1364
1365         Reviewed by Simon Fraser.
1366
1367         * Configurations/FeatureDefines.xcconfig:
1368
1369 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1370
1371         Unreviewed, rolling out r236624 and r236671.
1372         https://bugs.webkit.org/show_bug.cgi?id=190207
1373
1374         The change in r236624 introduced crashes on the bots
1375         (Requested by ryanhaddad on #webkit).
1376
1377         Reverted changesets:
1378
1379         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1380         https://bugs.webkit.org/show_bug.cgi?id=188747
1381         https://trac.webkit.org/changeset/236624
1382
1383         "Unify implementation in VideoFullscreenInterfaceAVKit"
1384         https://bugs.webkit.org/show_bug.cgi?id=190091
1385         https://trac.webkit.org/changeset/236671
1386
1387 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1388
1389         URL should not use TextEncoding internally
1390         https://bugs.webkit.org/show_bug.cgi?id=190111
1391
1392         Reviewed by Andy Estes.
1393
1394         * Misc/WebNSURLExtras.mm:
1395
1396 2018-09-28  Jer Noble  <jer.noble@apple.com>
1397
1398         Refactoring: eliminate raw pointer usage in Fullscreen code
1399         https://bugs.webkit.org/show_bug.cgi?id=188747
1400         <rdar://problem/43541164>
1401
1402         Reviewed by Alex Christensen.
1403
1404         PlaybackSessionInterface no longer has an invalidate() method.
1405
1406         * WebView/WebView.mm:
1407         (-[WebView _clearPlaybackControlsManager]):
1408
1409 2018-09-28  Chris Dumez  <cdumez@apple.com>
1410
1411         Drop support for cross-origin-window-policy header
1412         https://bugs.webkit.org/show_bug.cgi?id=190081
1413
1414         Reviewed by Ryosuke Niwa.
1415
1416         * WebView/WebPreferenceKeysPrivate.h:
1417         * WebView/WebPreferences.mm:
1418         (+[WebPreferences initialize]):
1419         * WebView/WebPreferencesPrivate.h:
1420         * WebView/WebView.mm:
1421         (-[WebView _preferencesChanged:]):
1422
1423 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         Rename createMarkup to serializePreservingVisualAppearance
1426         https://bugs.webkit.org/show_bug.cgi?id=190086
1427
1428         Reviewed by Wenson Hsieh.
1429
1430         * DOM/WebDOMOperations.mm:
1431         (-[DOMRange markupString]):
1432
1433 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1434
1435         Unreviewed, rolling out r236605.
1436         https://bugs.webkit.org/show_bug.cgi?id=190087
1437
1438         caused three API test timeouts (Requested by jernoble on
1439         #webkit).
1440
1441         Reverted changeset:
1442
1443         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1444         https://bugs.webkit.org/show_bug.cgi?id=188747
1445         https://trac.webkit.org/changeset/236605
1446
1447 2018-09-28  Jer Noble  <jer.noble@apple.com>
1448
1449         Refactoring: eliminate raw pointer usage in Fullscreen code
1450         https://bugs.webkit.org/show_bug.cgi?id=188747
1451         <rdar://problem/43541164>
1452
1453         Reviewed by Alex Christensen.
1454
1455         PlaybackSessionInterface no longer has an invalidate() method.
1456
1457         * WebView/WebView.mm:
1458         (-[WebView _clearPlaybackControlsManager]):
1459
1460 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         Use enum class in createMarkup arguments
1463         https://bugs.webkit.org/show_bug.cgi?id=190028
1464
1465         Reviewed by Wenson Hsieh.
1466
1467         * DOM/WebDOMOperations.mm:
1468         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1469         (-[DOMRange markupString]): Ditto.
1470
1471 2018-09-27  Antoine Quint  <graouts@apple.com>
1472
1473         [Web Animations] Turn Web Animations with CSS integration on
1474         https://bugs.webkit.org/show_bug.cgi?id=184819
1475         <rdar://problem/39597337>
1476
1477         Reviewed by Dean Jackson.
1478
1479         * WebView/WebPreferences.mm:
1480         (+[WebPreferences initialize]):
1481
1482 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1483
1484         Selection should work across shadow boundary when initiated by a mouse drag
1485         https://bugs.webkit.org/show_bug.cgi?id=151380
1486         <rdar://problem/24363872>
1487
1488         Reviewed by Wenson Hsieh.
1489
1490         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1491
1492         * WebView/WebPreferenceKeysPrivate.h:
1493         * WebView/WebPreferences.mm:
1494         (+[WebPreferences initialize]):
1495         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1496         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1497         * WebView/WebPreferencesPrivate.h:
1498         * WebView/WebView.mm:
1499         (-[WebView _preferencesChanged:]):
1500
1501 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1504         https://bugs.webkit.org/show_bug.cgi?id=189918
1505         Work towards <rdar://problem/44648705>
1506
1507         Reviewed by Tim Horton.
1508
1509         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1510
1511         * WebView/WebHTMLView.mm:
1512         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1513         (-[WebHTMLView _updateFontPanel]):
1514         * WebView/WebView.mm:
1515         (-[WebView typingAttributes]):
1516
1517 2018-09-17  Darin Adler  <darin@apple.com>
1518
1519         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1520         https://bugs.webkit.org/show_bug.cgi?id=189652
1521
1522         Reviewed by Saam Barati.
1523
1524         * WebView/WebPDFRepresentation.mm:
1525         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1526
1527 2018-09-14  Jer Noble  <jer.noble@apple.com>
1528
1529         Turn SourceBufferChangeTypeEnabled on by default
1530         https://bugs.webkit.org/show_bug.cgi?id=189527
1531
1532         Reviewed by Eric Carlson.
1533
1534         * WebView/WebPreferences.mm:
1535         (+[WebPreferences initialize]):
1536
1537 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1538
1539         Fix an internal build after r235935
1540         https://bugs.webkit.org/show_bug.cgi?id=188996
1541
1542         * Carbon/HIWebView.mm:
1543         (Draw):
1544         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1545
1546 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1547
1548         Add IGNORE_WARNING_.* macros
1549         https://bugs.webkit.org/show_bug.cgi?id=188996
1550
1551         Reviewed by Michael Catanzaro.
1552
1553         * Carbon/CarbonUtils.m:
1554         (PoolCleaner):
1555         * Carbon/CarbonWindowAdapter.mm:
1556         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1557         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1558         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1559         (-[CarbonWindowAdapter _termWindowIfOwner]):
1560         (-[CarbonWindowAdapter _windowMovedToRect:]):
1561         (-[CarbonWindowAdapter setContentView:]):
1562         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1563         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1564         * Carbon/CarbonWindowFrame.m:
1565         (-[CarbonWindowFrame title]):
1566         * Carbon/HIViewAdapter.m:
1567         (+[HIViewAdapter getHIViewForNSView:]):
1568         * Carbon/HIWebView.mm:
1569         (overrideCGContext):
1570         (restoreCGContext):
1571         (Draw):
1572         * DOM/DOM.mm:
1573         * History/WebHistory.mm:
1574         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1575         * History/WebHistoryItem.mm:
1576         (-[WebHistoryItem icon]):
1577         * Misc/WebKitNSStringExtras.mm:
1578         (-[NSString _web_drawAtPoint:font:textColor:]):
1579         * Misc/WebNSImageExtras.m:
1580         (-[NSImage _web_scaleToMaxSize:]):
1581         (-[NSImage _web_dissolveToFraction:]):
1582         * Misc/WebNSPasteboardExtras.mm:
1583         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1584         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1585         * Panels/WebAuthenticationPanel.m:
1586         (-[WebAuthenticationPanel loadNib]):
1587         * Plugins/Hosted/NetscapePluginHostManager.mm:
1588         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1589         (WebKit::NetscapePluginHostManager::didCreateWindow):
1590         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1591         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1592         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1593         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1594         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1595         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1596         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1597         (-[WebHostedNetscapePluginView drawRect:]):
1598         * Plugins/Hosted/WebTextInputWindowController.m:
1599         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1600         * Plugins/WebBaseNetscapePluginView.mm:
1601         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1602         * Plugins/WebNetscapePluginPackage.mm:
1603         (-[WebNetscapePluginPackage _tryLoad]):
1604         * Plugins/WebNetscapePluginView.mm:
1605         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1606         (-[WebNetscapePluginView sendDrawRectEvent:]):
1607         (-[WebNetscapePluginView drawRect:]):
1608         * Plugins/WebPluginController.mm:
1609         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1610         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1611         * WebCoreSupport/PopupMenuMac.mm:
1612         (PopupMenuMac::populate):
1613         * WebCoreSupport/WebAlternativeTextClient.h:
1614         * WebCoreSupport/WebDragClient.mm:
1615         (WebDragClient::startDrag):
1616         * WebCoreSupport/WebFrameLoaderClient.mm:
1617         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1618         (webGetNSImage):
1619         * WebInspector/WebNodeHighlight.mm:
1620         * WebInspector/WebNodeHighlightView.mm:
1621         (-[WebNodeHighlightView drawRect:]):
1622         * WebView/WebClipView.mm:
1623         (-[WebClipView initWithFrame:]):
1624         * WebView/WebFrame.mm:
1625         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1626         (-[WebFrame _drawRect:contentsOnly:]):
1627         (-[WebFrame accessibilityRoot]):
1628         * WebView/WebFullScreenController.mm:
1629         (-[WebFullScreenController enterFullScreen:]):
1630         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1631         (-[WebFullScreenController exitFullScreen]):
1632         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1633         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1634         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1635         * WebView/WebHTMLView.mm:
1636         (-[NSWindow _web_borderView]):
1637         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1638         (-[WebHTMLView _setAsideSubviews]):
1639         (-[WebHTMLView _autoscroll]):
1640         (-[WebHTMLView drawRect:]):
1641         (-[WebHTMLView mouseDown:]):
1642         (-[WebHTMLView mouseDragged:]):
1643         (-[WebHTMLView mouseUp:]):
1644         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1645         (-[WebHTMLView knowsPageRange:]):
1646         (-[WebHTMLView accessibilityHitTest:]):
1647         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1648         (-[WebHTMLView _colorAsString:]):
1649         (-[WebHTMLView copyFont:]):
1650         (-[WebHTMLView _executeSavedKeypressCommands]):
1651         (-[WebHTMLView attachRootLayer:]):
1652         (-[WebHTMLView textStorage]):
1653         (-[WebHTMLView _updateSelectionForInputManager]):
1654         * WebView/WebPDFView.mm:
1655         (_applicationInfoForMIMEType):
1656         (-[WebPDFView centerSelectionInVisibleArea:]):
1657         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1658         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1659         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1660         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1661         * WebView/WebTextCompletionController.mm:
1662         (-[WebTextCompletionController _buildUI]):
1663         (-[WebTextCompletionController _placePopupWindow:]):
1664         * WebView/WebVideoFullscreenController.mm:
1665         * WebView/WebVideoFullscreenHUDWindowController.mm:
1666         (createMediaUIBackgroundView):
1667         * WebView/WebView.mm:
1668         (-[WebTextListTouchBarViewController initWithWebView:]):
1669         (-[WebView _dispatchTileDidDraw:]):
1670         (-[WebView encodeWithCoder:]):
1671         (-[WebView mainFrameIcon]):
1672         (LayerFlushController::flushLayers):
1673         * WebView/WebWindowAnimation.mm:
1674         (setScaledFrameForWindow):
1675
1676 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1677
1678         Remove unused needsDestruction class variables from HashTraits
1679         https://bugs.webkit.org/show_bug.cgi?id=189490
1680
1681         Reviewed by Daniel Bates.
1682
1683         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1684
1685 2018-09-07  Frederic Wang  <fwang@igalia.com>
1686
1687         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1688         https://bugs.webkit.org/show_bug.cgi?id=182230
1689
1690         Reviewed by Simon Fraser.
1691
1692         * DOM/DOMDocument.mm:
1693         (-[DOMDocument scrollingElement]): Use the new name.
1694
1695 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1696
1697         Refactor WebCore::EditAction to be an 8-bit enum class
1698         https://bugs.webkit.org/show_bug.cgi?id=189383
1699
1700         Reviewed by Dan Bernstein.
1701
1702         * WebCoreSupport/WebEditorClient.mm:
1703         (undoNameForEditAction):
1704         * WebView/WebHTMLView.mm:
1705         (-[WebHTMLView pasteFont:]):
1706         (-[WebHTMLView changeFont:]):
1707         (-[WebHTMLView changeAttributes:]):
1708         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1709         (-[WebHTMLView changeColor:]):
1710         * WebView/WebView.mm:
1711         (-[WebView setTypingStyle:]):
1712
1713 2018-09-06  Frederic Wang  <fwang@igalia.com>
1714
1715         Group options of scrollRectToVisible into a struct
1716         https://bugs.webkit.org/show_bug.cgi?id=189352
1717
1718         Reviewed by Simon Fraser.
1719
1720         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1721         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1722         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1723
1724 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1725
1726         [macOS] Cannot change font size at selection until font panel is shown
1727         https://bugs.webkit.org/show_bug.cgi?id=189295
1728         <rdar://problem/35593389>
1729
1730         Reviewed by Ryosuke Niwa.
1731
1732         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1733         WebCore ChangeLog for more details.
1734
1735         * WebView/WebHTMLView.mm:
1736         (-[WebHTMLView changeFont:]):
1737         (-[WebHTMLView changeAttributes:]):
1738         (-[WebHTMLView _originalFontA]): Deleted.
1739         (-[WebHTMLView _originalFontB]): Deleted.
1740         (fontNameForDescription): Deleted.
1741         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1742         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1743         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1744
1745 2018-09-05  Jer Noble  <jer.noble@apple.com>
1746
1747         Add MediaCapabilities as an Experimental Feature
1748         https://bugs.webkit.org/show_bug.cgi?id=189209
1749
1750         Reviewed by Eric Carlson.
1751
1752         RuntimeEnabledFeature -> Setting.
1753
1754         * WebView/WebView.mm:
1755         (-[WebView _preferencesChanged:]):
1756
1757 2018-09-04  Frederic Wang  <fwang@igalia.com>
1758
1759         Add basic support for ScrollIntoViewOptions
1760         https://bugs.webkit.org/show_bug.cgi?id=189258
1761
1762         Reviewed by Simon Fraser.
1763
1764         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1765         header so that this file can build despite the new scrollIntoView function.
1766
1767 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1768
1769         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1770         https://bugs.webkit.org/show_bug.cgi?id=188890
1771         <rdar://problem/43648605>
1772
1773         Reviewed by Tim Horton.
1774
1775         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1776         more detail.
1777
1778         * WebCoreSupport/WebPlatformStrategies.h:
1779         * WebCoreSupport/WebPlatformStrategies.mm:
1780         (WebPlatformStrategies::allStringsForType):
1781
1782 2018-09-01  Darin Adler  <darin@apple.com>
1783
1784         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1785         https://bugs.webkit.org/show_bug.cgi?id=189072
1786         Reviewed by Dan Bernstein.
1787
1788         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1789         and declarations for NSURLDownload init methods.
1790
1791         * Misc/WebDownloadInternal.h: Removed.
1792
1793         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
1794         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
1795         "-Wdeprecated-declarations" because the method used here is deprecated.
1796
1797         * WebView/WebView.mm:
1798         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
1799         used here is deprecated.
1800
1801 2018-08-31  Chris Dumez  <cdumez@apple.com>
1802
1803         Assertion hit in ~CompletionHandler() from ~WebFrame()
1804         https://bugs.webkit.org/show_bug.cgi?id=189199
1805         <rdar://problem/42657233>
1806
1807         Reviewed by Youenn Fablet.
1808
1809         * WebCoreSupport/WebFrameLoaderClient.h:
1810         * WebCoreSupport/WebFrameLoaderClient.mm:
1811         (WebFrameLoaderClient::dispatchWillSubmitForm):
1812
1813 2018-08-31  Antti Koivisto  <antti@apple.com>
1814
1815         Replace OptionSet |= and -= operators with add() and remove() functions
1816         https://bugs.webkit.org/show_bug.cgi?id=189169
1817
1818         Reviewed by Anders Carlsson.
1819
1820         * WebView/WebFrame.mm:
1821         (-[WebFrame _drawRect:contentsOnly:]):
1822         * WebView/WebView.mm:
1823         (coreOptions):
1824
1825 2018-08-31  Frederic Wang  <fwang@igalia.com>
1826
1827         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1828         https://bugs.webkit.org/show_bug.cgi?id=182053
1829
1830         Reviewed by Simon Fraser.
1831
1832         Add developer flag to use standard behavior for scrolling* attributes.
1833
1834         * WebView/WebPreferenceKeysPrivate.h:
1835         * WebView/WebPreferences.mm:
1836         (+[WebPreferences initialize]):
1837         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
1838         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
1839         * WebView/WebPreferencesPrivate.h:
1840         * WebView/WebView.mm:
1841         (-[WebView _preferencesChanged:]):
1842
1843 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1844
1845         Implement the Web Share API
1846         https://bugs.webkit.org/show_bug.cgi?id=171100
1847         <rdar://problem/31751734>
1848
1849         Reviewed by Tim Horton.
1850
1851         * WebCoreSupport/WebChromeClient.h:
1852         * WebCoreSupport/WebChromeClient.mm:
1853         (WebChromeClient::showShareSheet):
1854         Empty declaration of showShareSheet.
1855
1856 2018-08-29  Youenn Fablet  <youenn@apple.com>
1857
1858         Remove WebRTC legacy API implementation
1859         https://bugs.webkit.org/show_bug.cgi?id=189040
1860
1861         Reviewed by Eric Carlson.
1862
1863         * WebView/WebPreferenceKeysPrivate.h:
1864         * WebView/WebPreferences.mm:
1865         (+[WebPreferences initialize]):
1866         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
1867         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
1868         * WebView/WebPreferencesPrivate.h:
1869         * WebView/WebView.mm:
1870         (-[WebView _preferencesChanged:]):
1871
1872 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1873
1874         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
1875         https://bugs.webkit.org/show_bug.cgi?id=189054
1876
1877         Reviewed by Andy Estes.
1878
1879         Remove the pasteboard type argument from readURLFromPasteboard.
1880
1881         * WebCoreSupport/WebPlatformStrategies.h:
1882         * WebCoreSupport/WebPlatformStrategies.mm:
1883         (WebPlatformStrategies::readURLFromPasteboard):
1884
1885 2018-08-27  Keith Rollin  <krollin@apple.com>
1886
1887         Unreviewed build fix -- disable LTO for production builds
1888
1889         * Configurations/Base.xcconfig:
1890
1891 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1892
1893         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1894         https://bugs.webkit.org/show_bug.cgi?id=188931
1895
1896         Reviewed by Wenson Hsieh.
1897
1898         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1899
1900 2018-08-27  Keith Rollin  <krollin@apple.com>
1901
1902         Build system support for LTO
1903         https://bugs.webkit.org/show_bug.cgi?id=187785
1904         <rdar://problem/42353132>
1905
1906         Reviewed by Dan Bernstein.
1907
1908         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1909         LTO.
1910
1911         * Configurations/Base.xcconfig:
1912         * Configurations/DebugRelease.xcconfig:
1913
1914 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1915
1916         Pass in IsComposed flag to Event constructors
1917         https://bugs.webkit.org/show_bug.cgi?id=188720
1918         <rdar://problem/43580387>
1919
1920         Reviewed by Simon Fraser.
1921
1922         * WebView/WebPDFView.mm:
1923         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1924         whether it's simulated or not.
1925
1926 2018-08-23  Mark Lam  <mark.lam@apple.com>
1927
1928         Move vmEntryGlobalObject() to VM from CallFrame.
1929         https://bugs.webkit.org/show_bug.cgi?id=188900
1930         <rdar://problem/43655753>
1931
1932         Reviewed by Michael Saboff.
1933
1934         * WebView/WebScriptDebugger.mm:
1935         (WebScriptDebugger::sourceParsed):
1936
1937 2018-08-23  Andy Estes  <aestes@apple.com>
1938
1939         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1940         https://bugs.webkit.org/show_bug.cgi?id=188829
1941
1942         Reviewed by Tim Horton.
1943
1944         * Configurations/FeatureDefines.xcconfig:
1945
1946 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1947
1948         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1949         https://bugs.webkit.org/show_bug.cgi?id=188777
1950
1951         Reviewed by Simon Fraser.
1952
1953         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1954         being "true" before the code change.
1955
1956         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1957
1958         * WebView/WebPDFView.mm:
1959         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1960
1961 2018-08-21  Daniel Bates  <dabates@apple.com>
1962
1963         Replace TextCheckingTypeMask with OptionSet
1964         https://bugs.webkit.org/show_bug.cgi?id=188678
1965
1966         Reviewed by Antti Koivisto.
1967
1968         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1969         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1970         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1971         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1972
1973         * WebCoreSupport/WebEditorClient.h:
1974         * WebCoreSupport/WebEditorClient.mm:
1975         (WebEditorClient::checkTextOfParagraph):
1976         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1977         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1978         left as this is more readable and unncessary now that modern compilers like Clang have
1979         diagnostics to catch accidental assignments when equality was intended.
1980         (WebEditorClient::didCheckSucceed):
1981         * WebView/WebView.mm:
1982         (coreTextCheckingType):
1983         (textCheckingResultFromNSTextCheckingResult):
1984
1985 2018-08-21  Daniel Bates  <dabates@apple.com>
1986
1987         [iOS][WK1] Support toggling continuous spell checking from tests
1988         https://bugs.webkit.org/show_bug.cgi?id=188763
1989
1990         Reviewed by Simon Fraser.
1991
1992         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1993         spell checking from tests in iOS WebKit Legacy.
1994
1995         * WebCoreSupport/WebEditorClient.h:
1996         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1997         * WebCoreSupport/WebEditorClient.mm:
1998         * WebView/WebView.h:
1999         * WebView/WebView.mm:
2000         (-[WebView toggleContinuousSpellChecking:]):
2001         (-[WebView toggleSmartInsertDelete:]):
2002
2003 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2004
2005         Add some plumbing for safe browsing
2006         https://bugs.webkit.org/show_bug.cgi?id=188709
2007
2008         Reviewed by Tim Horton.
2009
2010         * WebCoreSupport/WebFrameLoaderClient.h:
2011         * WebCoreSupport/WebFrameLoaderClient.mm:
2012         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2013
2014 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2015
2016         Replace canBubble and cancelable booleans in Event by enum classes
2017         https://bugs.webkit.org/show_bug.cgi?id=188692
2018
2019         Reviewed by Alex Christensen.
2020
2021         * WebView/WebPDFView.mm:
2022         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2023         * WebView/WebView.mm:
2024         (-[WebView _dispatchUnloadEvent]):
2025
2026 2018-08-16  Jer Noble  <jer.noble@apple.com>
2027
2028         Add Experimental Feature support for SourceBuffer.changeType()
2029         https://bugs.webkit.org/show_bug.cgi?id=188626
2030         <rdar://problem/43356021>
2031
2032         Reviewed by Eric Carlson.
2033
2034         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2035
2036         * WebView/WebPreferenceKeysPrivate.h:
2037         * WebView/WebPreferences.mm:
2038         (+[WebPreferences initialize]):
2039         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2040         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2041         * WebView/WebPreferencesPrivate.h:
2042         * WebView/WebView.mm:
2043         (-[WebView _preferencesChanged:]):
2044
2045 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2046
2047         Support drag-and-drop for input[type=color]
2048         https://bugs.webkit.org/show_bug.cgi?id=188464
2049
2050         Reviewed by Wenson Hsieh.
2051
2052         * WebCoreSupport/WebPlatformStrategies.h:
2053         * WebCoreSupport/WebPlatformStrategies.mm:
2054         (WebPlatformStrategies::setColor):
2055
2056 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2057
2058         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2059         https://bugs.webkit.org/show_bug.cgi?id=188569
2060         <rdar://problem/34201095>
2061
2062         Reviewed by Megan Gardner.
2063
2064         * WebView/WebImmediateActionController.mm:
2065         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2066         Speculative fix; the crashes indicate font is null, but we just checked it,
2067         so it must be getting made null by convertFont:toSize:. Check again!
2068
2069 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2070
2071         Use a 1-byte enum class for TextDirection
2072         https://bugs.webkit.org/show_bug.cgi?id=188350
2073
2074         Reviewed by Simon Fraser.
2075
2076         * WebCoreSupport/PopupMenuMac.mm:
2077         (PopupMenuMac::populate):
2078         (PopupMenuMac::show):
2079         * WebCoreSupport/WebFrameLoaderClient.mm:
2080         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2081         * WebView/WebFrame.mm:
2082         (-[WebFrame _dispatchDidReceiveTitle:]):
2083
2084 2018-08-09  Ali Juma  <ajuma@chromium.org>
2085
2086         Import WPTs for IntersectionObserver
2087         https://bugs.webkit.org/show_bug.cgi?id=188416
2088
2089         Reviewed by Simon Fraser.
2090
2091         * WebView/WebPreferencesPrivate.h:
2092
2093 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2094
2095         Follow-up build fix for r234685
2096         https://bugs.webkit.org/show_bug.cgi?id=188245
2097
2098         Unreviewed build fix.
2099
2100         * WebCoreSupport/WebSecurityOriginPrivate.h:
2101
2102 2018-08-05  Darin Adler  <darin@apple.com>
2103
2104         [Cocoa] More tweaks and refactoring to prepare for ARC
2105         https://bugs.webkit.org/show_bug.cgi?id=188245
2106
2107         Reviewed by Dan Bernstein.
2108
2109         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2110
2111         * Carbon/CarbonWindowFrame.m:
2112         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2113
2114         * DOM/DOM.mm:
2115         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2116         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2117         garbage collection so this method isn't useful.
2118
2119         * DOM/DOMXPath.mm:
2120         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2121         Objective-C garbage collection so this method isn't useful.
2122
2123         * History/WebHistory.mm:
2124         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2125
2126         * Misc/WebElementDictionary.mm:
2127         (addLookupKey): Use a bridging cast.
2128         (cacheValueForKey): Ditto.
2129         (-[WebElementDictionary _fillCache]): Ditto.
2130         (-[WebElementDictionary objectForKey:]): Ditto.
2131
2132         * Misc/WebKitNSStringExtras.mm:
2133         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2134         (-[NSString _web_widthWithFont:]): Ditto.
2135         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2136
2137         * Misc/WebLocalizableStrings.mm:
2138         (WebLocalizedString): Use a bridging cast.
2139
2140         * Misc/WebNSDataExtras.mm:
2141         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2142         and use CFBridgingRelease instead of calling autorelease directly.
2143         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2144         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2145         on the amount of explicit release and autorelease.
2146
2147         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2148         * Misc/WebNSDictionaryExtras.m:
2149         (-[NSDictionary _webkit_intForKey:]): Deleted.
2150         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2151         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2152         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2153         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2154         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2155         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2156
2157         * Misc/WebStringTruncator.mm:
2158         (fontFromNSFont): Use a bridging cast.
2159
2160         * Plugins/Hosted/NetscapePluginHostManager.mm:
2161         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2162
2163         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2164         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2165         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2166         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2167         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2168         * Plugins/Hosted/ProxyInstance.mm:
2169         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2170         * Plugins/WebBasePluginPackage.mm:
2171         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2172         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2173         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2174         * Plugins/WebNetscapePluginPackage.mm:
2175         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2176
2177         * Plugins/WebNetscapePluginView.mm:
2178         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2179         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2180         (-[WebNetscapePluginView status:]): Use a bridging cast.
2181         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2182
2183         * Plugins/WebPluginController.mm:
2184         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2185
2186         * Plugins/WebPluginDatabase.mm:
2187         (checkCandidate): Use explicit __strong for out argument types.
2188
2189         * Plugins/npapi.mm:
2190         (pluginViewForInstance): Use a bridging cast.
2191
2192         * Storage/WebDatabaseManager.mm:
2193         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2194         explicit NSNumber and NSDictionary calls.
2195
2196         * WebCoreSupport/WebContextMenuClient.mm:
2197         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2198
2199         * WebCoreSupport/WebEditorClient.mm:
2200         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2201         (WebEditorClient::handleInputMethodKeydown): Ditto.
2202
2203         * WebCoreSupport/WebFrameNetworkingContext.mm:
2204         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2205
2206         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2207         as a struct rather than an Objective-C class, since that's how it's defined.
2208
2209         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2210
2211         * WebView/WebFullScreenController.mm:
2212         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2213         * WebView/WebHTMLView.mm:
2214         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2215         Ditto.
2216         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2217
2218         * WebView/WebImmediateActionController.mm:
2219         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2220         go down to the document and then back to the frame.
2221         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2222         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2223         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2224
2225         * WebView/WebJSPDFDoc.mm:
2226         (jsPDFDocInitialize): Removed some unneeded type casting.
2227         (jsPDFDocFinalize): Ditto.
2228         (jsPDFDocPrint): Use a bridging cast.
2229
2230         * WebView/WebPDFView.mm:
2231         (_applicationInfoForMIMEType): Use bridging casts.
2232
2233         * WebView/WebPreferences.mm:
2234         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2235         instead of methods from WebNSDictionaryExtras.
2236         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2237         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2238         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2239         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2240         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2241
2242         * WebView/WebView.mm:
2243         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2244         (-[WebView _addToAllWebViewsSet]): Ditto.
2245         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2246         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2247         so it can be called from WebViewData methods.
2248
2249         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2250         method, _windowVisibilityChanged:.
2251
2252         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2253         called from WebViewData methods.
2254
2255 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2256
2257         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2258         https://bugs.webkit.org/show_bug.cgi?id=188323
2259
2260         Reviewed by Simon Fraser.
2261
2262         * WebCoreSupport/WebContextMenuClient.mm:
2263         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2264         * WebView/WebFrame.mm:
2265         (-[WebFrame _paintBehaviorForDestinationContext:]):
2266         (-[WebFrame _drawRect:contentsOnly:]):
2267         * WebView/WebHTMLView.mm:
2268         (imageFromRect):
2269         (selectionImage):
2270
2271 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2272
2273         Add support for microtasks in workers
2274         https://bugs.webkit.org/show_bug.cgi?id=188246
2275
2276         Reviewed by Darin Adler.
2277
2278         Rename JSMainThreadExecState.h to JSExecState.h.
2279
2280         * DOM/DOMAttr.mm:
2281         * DOM/DOMBlob.mm:
2282         * DOM/DOMCDATASection.mm:
2283         * DOM/DOMCSSCharsetRule.mm:
2284         * DOM/DOMCSSFontFaceRule.mm:
2285         * DOM/DOMCSSImportRule.mm:
2286         * DOM/DOMCSSMediaRule.mm:
2287         * DOM/DOMCSSPageRule.mm:
2288         * DOM/DOMCSSPrimitiveValue.mm:
2289         * DOM/DOMCSSRule.mm:
2290         * DOM/DOMCSSRuleList.mm:
2291         * DOM/DOMCSSStyleDeclaration.mm:
2292         * DOM/DOMCSSStyleRule.mm:
2293         * DOM/DOMCSSStyleSheet.mm:
2294         * DOM/DOMCSSUnknownRule.mm:
2295         * DOM/DOMCSSValue.mm:
2296         * DOM/DOMCSSValueList.mm:
2297         * DOM/DOMCharacterData.mm:
2298         * DOM/DOMComment.mm:
2299         * DOM/DOMCounter.mm:
2300         * DOM/DOMDocument.mm:
2301         * DOM/DOMDocumentFragment.mm:
2302         * DOM/DOMDocumentType.mm:
2303         * DOM/DOMElement.mm:
2304         * DOM/DOMEvent.mm:
2305         * DOM/DOMFile.mm:
2306         * DOM/DOMFileList.mm:
2307         * DOM/DOMHTML.mm:
2308         * DOM/DOMHTMLAnchorElement.mm:
2309         * DOM/DOMHTMLAppletElement.mm:
2310         * DOM/DOMHTMLAreaElement.mm:
2311         * DOM/DOMHTMLBRElement.mm:
2312         * DOM/DOMHTMLBaseElement.mm:
2313         * DOM/DOMHTMLBaseFontElement.mm:
2314         * DOM/DOMHTMLBodyElement.mm:
2315         * DOM/DOMHTMLButtonElement.mm:
2316         * DOM/DOMHTMLCanvasElement.mm:
2317         * DOM/DOMHTMLCollection.mm:
2318         * DOM/DOMHTMLDListElement.mm:
2319         * DOM/DOMHTMLDirectoryElement.mm:
2320         * DOM/DOMHTMLDivElement.mm:
2321         * DOM/DOMHTMLDocument.mm:
2322         * DOM/DOMHTMLElement.mm:
2323         * DOM/DOMHTMLEmbedElement.mm:
2324         * DOM/DOMHTMLFieldSetElement.mm:
2325         * DOM/DOMHTMLFontElement.mm:
2326         * DOM/DOMHTMLFormElement.mm:
2327         * DOM/DOMHTMLFrameElement.mm:
2328         * DOM/DOMHTMLFrameSetElement.mm:
2329         * DOM/DOMHTMLHRElement.mm:
2330         * DOM/DOMHTMLHeadElement.mm:
2331         * DOM/DOMHTMLHeadingElement.mm:
2332         * DOM/DOMHTMLHtmlElement.mm:
2333         * DOM/DOMHTMLIFrameElement.mm:
2334         * DOM/DOMHTMLImageElement.mm:
2335         * DOM/DOMHTMLInputElement.mm:
2336         * DOM/DOMHTMLLIElement.mm:
2337         * DOM/DOMHTMLLabelElement.mm:
2338         * DOM/DOMHTMLLegendElement.mm:
2339         * DOM/DOMHTMLLinkElement.mm:
2340         * DOM/DOMHTMLMapElement.mm:
2341         * DOM/DOMHTMLMarqueeElement.mm:
2342         * DOM/DOMHTMLMediaElement.mm:
2343         * DOM/DOMHTMLMenuElement.mm:
2344         * DOM/DOMHTMLMetaElement.mm:
2345         * DOM/DOMHTMLModElement.mm:
2346         * DOM/DOMHTMLOListElement.mm:
2347         * DOM/DOMHTMLObjectElement.mm:
2348         * DOM/DOMHTMLOptGroupElement.mm:
2349         * DOM/DOMHTMLOptionElement.mm:
2350         * DOM/DOMHTMLOptionsCollection.mm:
2351         * DOM/DOMHTMLParagraphElement.mm:
2352         * DOM/DOMHTMLParamElement.mm:
2353         * DOM/DOMHTMLPreElement.mm:
2354         * DOM/DOMHTMLQuoteElement.mm:
2355         * DOM/DOMHTMLScriptElement.mm:
2356         * DOM/DOMHTMLSelectElement.mm:
2357         * DOM/DOMHTMLStyleElement.mm:
2358         * DOM/DOMHTMLTableCaptionElement.mm:
2359         * DOM/DOMHTMLTableCellElement.mm:
2360         * DOM/DOMHTMLTableColElement.mm:
2361         * DOM/DOMHTMLTableElement.mm:
2362         * DOM/DOMHTMLTableRowElement.mm:
2363         * DOM/DOMHTMLTableSectionElement.mm:
2364         * DOM/DOMHTMLTextAreaElement.mm:
2365         * DOM/DOMHTMLTitleElement.mm:
2366         * DOM/DOMHTMLUListElement.mm:
2367         * DOM/DOMHTMLVideoElement.mm:
2368         * DOM/DOMImplementation.mm:
2369         * DOM/DOMKeyboardEvent.mm:
2370         * DOM/DOMMediaError.mm:
2371         * DOM/DOMMediaList.mm:
2372         * DOM/DOMMouseEvent.mm:
2373         * DOM/DOMMutationEvent.mm:
2374         * DOM/DOMNamedNodeMap.mm:
2375         * DOM/DOMNode.mm:
2376         * DOM/DOMNodeIterator.mm:
2377         * DOM/DOMNodeList.mm:
2378         * DOM/DOMOverflowEvent.mm:
2379         * DOM/DOMProcessingInstruction.mm:
2380         * DOM/DOMProgressEvent.mm:
2381         * DOM/DOMRGBColor.mm:
2382         * DOM/DOMRange.mm:
2383         * DOM/DOMRect.mm:
2384         * DOM/DOMStyleSheet.mm:
2385         * DOM/DOMStyleSheetList.mm:
2386         * DOM/DOMText.mm:
2387         * DOM/DOMTextEvent.mm:
2388         * DOM/DOMTimeRanges.mm:
2389         * DOM/DOMTokenList.mm:
2390         * DOM/DOMTreeWalker.mm:
2391         * DOM/DOMUIEvent.mm:
2392         * DOM/DOMWheelEvent.mm:
2393         * DOM/DOMXPathExpression.mm:
2394         * DOM/DOMXPathResult.mm:
2395         * DOM/ObjCEventListener.mm:
2396
2397 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2398
2399         Fix spelling of "overridden"
2400         https://bugs.webkit.org/show_bug.cgi?id=188315
2401
2402         Reviewed by Darin Adler.
2403
2404         * Misc/WebKitVersionChecks.mm:
2405         (setWebKitLinkTimeVersion):
2406         (WebKitLinkTimeVersion):
2407         * Plugins/WebBaseNetscapePluginView.mm:
2408         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2409         * WebCoreSupport/PopupMenuMac.mm:
2410         (PopupMenuMac::populate):
2411
2412 2018-08-01  Nan Wang  <n_wang@apple.com>
2413
2414         AX: AOM: Add ARIA IDL Attribute Reflection
2415         https://bugs.webkit.org/show_bug.cgi?id=184676
2416         <rdar://problem/39476882>
2417
2418         Reviewed by Chris Fleizach.
2419
2420         * WebView/WebPreferenceKeysPrivate.h:
2421         * WebView/WebPreferences.mm:
2422         (+[WebPreferences initialize]):
2423         (-[WebPreferences ariaReflectionEnabled]):
2424         (-[WebPreferences setAriaReflectionEnabled:]):
2425         * WebView/WebPreferencesPrivate.h:
2426         * WebView/WebView.mm:
2427         (-[WebView _preferencesChanged:]):
2428
2429 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2430
2431         Shrink GraphicsLayerCA
2432         https://bugs.webkit.org/show_bug.cgi?id=188141
2433
2434         Reviewed by Zalan Bujtas.
2435
2436         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2437         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2438         * moving all the animation-related stuff into the lazily-allocated m_animations
2439         * making enums be 8-bit
2440         * re-ordering data members
2441
2442         * WebView/WebView.mm:
2443         (-[WebView _setMediaLayer:forPluginView:]):
2444
2445 2018-07-30  Rob Buis  <rbuis@igalia.com>
2446
2447         Merge PlatformCookieJar functions into NetworkStorageSession
2448         https://bugs.webkit.org/show_bug.cgi?id=188137
2449
2450         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2451
2452         Reviewed by Alex Christensen.
2453
2454         * WebCoreSupport/WebPlatformStrategies.mm:
2455         (WebPlatformStrategies::cookiesForDOM):
2456         (WebPlatformStrategies::setCookiesFromDOM):
2457         (WebPlatformStrategies::cookiesEnabled):
2458         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2459         (WebPlatformStrategies::getRawCookies):
2460         (WebPlatformStrategies::deleteCookie):
2461         * WebView/WebPreferences.mm:
2462         (+[WebPreferences _clearNetworkLoaderSession]):
2463
2464 2018-07-28  Darin Adler  <darin@apple.com>
2465
2466         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2467         https://bugs.webkit.org/show_bug.cgi?id=188140
2468
2469         Reviewed by Sam Weinig.
2470
2471         * WebView/WebImmediateActionController.mm:
2472         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2473         new DictionaryLookup function that returns a tuple instead of using an out argument.
2474
2475 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2476
2477         [INTL] Remove INTL sub-feature compile flags
2478         https://bugs.webkit.org/show_bug.cgi?id=188081
2479
2480         Reviewed by Michael Catanzaro.
2481
2482         * Configurations/FeatureDefines.xcconfig:
2483
2484 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2485
2486         Unreviewed, rolling out r234181 and r234189.
2487         https://bugs.webkit.org/show_bug.cgi?id=188075
2488
2489         These are not needed right now (Requested by thorton on
2490         #webkit).
2491
2492         Reverted changesets:
2493
2494         "Enable Web Content Filtering on watchOS"
2495         https://bugs.webkit.org/show_bug.cgi?id=187979
2496         https://trac.webkit.org/changeset/234181
2497
2498         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2499         https://bugs.webkit.org/show_bug.cgi?id=187985
2500         https://trac.webkit.org/changeset/234189
2501
2502 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2503
2504         Use the Page's appearance when converting pasteboard attributed strings.
2505         https://bugs.webkit.org/show_bug.cgi?id=188067
2506         rdar://problem/42632246
2507
2508         Reviewed by Wenson Hsieh.
2509
2510         * WebCoreSupport/WebEditorClient.mm:
2511         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2512
2513 2018-07-25  Chris Dumez  <cdumez@apple.com>
2514
2515         navigator.userAgent may return outdated value after webView.customUserAgent is set
2516         https://bugs.webkit.org/show_bug.cgi?id=188009
2517         <rdar://problem/42566456>
2518
2519         Reviewed by Alex Christensen.
2520
2521         Let the page know when the user agent changes.
2522
2523         * WebView/WebView.mm:
2524         (-[WebView _preferencesChanged:]):
2525         (-[WebView setApplicationNameForUserAgent:]):
2526         (-[WebView _invalidateUserAgentCache]):
2527         (-[WebView setCustomUserAgent:]):
2528         * WebView/WebViewInternal.h:
2529
2530 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2531
2532         Enable Web Content Filtering on watchOS
2533         https://bugs.webkit.org/show_bug.cgi?id=187979
2534         <rdar://problem/42559346>
2535
2536         Reviewed by Wenson Hsieh.
2537
2538         * Configurations/FeatureDefines.xcconfig:
2539
2540 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2541
2542         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2543         https://bugs.webkit.org/show_bug.cgi?id=187846
2544
2545         Reviewed by Simon Fraser.
2546
2547         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2548
2549         * WebView/WebHTMLView.mm:
2550         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2551         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2552
2553 2018-07-11  Dean Jackson  <dino@apple.com>
2554
2555         Allow removal of white backgrounds
2556         https://bugs.webkit.org/show_bug.cgi?id=187574
2557         <rdar://problem/41146792>
2558
2559         Reviewed by Simon Fraser.
2560
2561         Add a new WebPreference for punching out white backgrounds.
2562
2563         * WebView/WebPreferenceKeysPrivate.h:
2564         * WebView/WebPreferences.mm:
2565         (+[WebPreferences initialize]):
2566         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2567         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2568         * WebView/WebPreferencesPrivate.h:
2569         * WebView/WebView.mm:
2570         (-[WebView _preferencesChanged:]):
2571
2572 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2573
2574         Ensure WebKit stack is ad-hoc signed
2575         https://bugs.webkit.org/show_bug.cgi?id=187667
2576
2577         Reviewed by Alexey Proskuryakov.
2578
2579         * Configurations/Base.xcconfig:
2580
2581 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2582
2583         REGRESSION (231276): Attempting to copy an image fails
2584         https://bugs.webkit.org/show_bug.cgi?id=187212
2585         <rdar://problem/41540074>
2586
2587         Reviewed by Ryosuke Niwa.
2588
2589         Renamed methods to make it clear that one URL and one title are being passed in.
2590
2591         * WebCoreSupport/WebPlatformStrategies.h:
2592         * WebCoreSupport/WebPlatformStrategies.mm:
2593         (WebPlatformStrategies::setURL):
2594
2595 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2596
2597         Disable cross-origin-window-policy by default
2598         https://bugs.webkit.org/show_bug.cgi?id=187509
2599
2600         Reviewed by Chris Dumez.
2601
2602         * WebView/WebPreferences.mm:
2603         (+[WebPreferences initialize]):
2604
2605 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2606
2607         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2608         https://bugs.webkit.org/show_bug.cgi?id=187425
2609         rdar://problem/39948240
2610
2611         Reviewed by Tim Horton.
2612
2613         * WebView/WebView.mm:
2614         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2615         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2616         a call in this method to setUseDarkAppearance.
2617         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2618         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2619         (-[WebView _updateDefaultAppearance]): Deleted.
2620         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2621
2622 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2623
2624         Shrink various loading-related enums to shrink CachedResource
2625         https://bugs.webkit.org/show_bug.cgi?id=187443
2626
2627         Reviewed by Chris Dumez.
2628
2629         * WebCoreSupport/WebFrameLoaderClient.mm:
2630         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2631         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2632         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2633         (WebFrameLoaderClient::dispatchWillSendRequest):
2634         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2635         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2636         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2637         (WebFrameLoaderClient::updateGlobalHistory):
2638         (WebFrameLoaderClient::canHandleRequest const):
2639         * WebView/WebDataSource.mm:
2640         (-[WebDataSource initialRequest]):
2641         (-[WebDataSource request]):
2642
2643 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2644
2645         Unreviewed, rolling out r233612.
2646         https://bugs.webkit.org/show_bug.cgi?id=187475
2647
2648         Revision caused the api test LinkColorWithSystemAppearance to
2649         fail on all systems. (Requested by Truitt on #webkit).
2650
2651         Reverted changeset:
2652
2653         "Semantic colors don't update when accessibility Increase
2654         Contrast mode is enabled."
2655         https://bugs.webkit.org/show_bug.cgi?id=187425
2656         https://trac.webkit.org/changeset/233612
2657
2658 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2659
2660         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2661         https://bugs.webkit.org/show_bug.cgi?id=187425
2662         rdar://problem/39948240
2663
2664         Reviewed by Tim Horton.
2665
2666         * WebView/WebView.mm:
2667         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2668         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2669         a call in this method to setUseDarkAppearance.
2670         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2671         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2672         (-[WebView _updateDefaultAppearance]): Deleted.
2673         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2674
2675 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2676
2677         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2678         https://bugs.webkit.org/show_bug.cgi?id=187369
2679         rdar://problem/41870420
2680
2681         Reviewed by Tim Horton.
2682
2683         * WebView/WebMediaPlaybackTargetPicker.mm:
2684         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2685         * WebView/WebView.mm:
2686         (-[WebView _commonInitializationWithFrameName:groupName:]):
2687         (-[WebView _effectiveAppearanceIsDark]):
2688         (-[WebView _updateDefaultAppearance]):
2689         (-[WebView _defaultAppearance]): Deleted.
2690
2691 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2692
2693         Youtube video pages crash after a couple of minutes
2694         https://bugs.webkit.org/show_bug.cgi?id=187316
2695
2696         Reviewed by Antti Koivisto.
2697
2698         * WebView/WebView.mm:
2699         (-[WebView _preferencesChanged:]):
2700
2701 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2702
2703         Introduce PLATFORM(IOSMAC)
2704         https://bugs.webkit.org/show_bug.cgi?id=187315
2705
2706         Reviewed by Dan Bernstein.
2707
2708         * Configurations/Base.xcconfig:
2709         * Configurations/FeatureDefines.xcconfig:
2710
2711 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         [iOS] DataTransfer.getData always returns the empty string when dropping text
2714         https://bugs.webkit.org/show_bug.cgi?id=187130
2715         <rdar://problem/41014117>
2716
2717         Reviewed by Ryosuke Niwa.
2718
2719         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2720
2721         * WebCoreSupport/WebPlatformStrategies.h:
2722         * WebCoreSupport/WebPlatformStrategies.mm:
2723         (WebPlatformStrategies::allPasteboardItemInfo):
2724
2725 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2726
2727         [Mac] AirPlay picker uses incorrect theme in Dark mode
2728         https://bugs.webkit.org/show_bug.cgi?id=187054
2729         <rdar://problem/41291093>
2730
2731         Reviewed by Timothy Hatcher.
2732
2733         * WebView/WebMediaPlaybackTargetPicker.mm:
2734         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2735
2736 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2737
2738         [WTF] Add user-defined literal for ASCIILiteral
2739         https://bugs.webkit.org/show_bug.cgi?id=186839
2740
2741         Reviewed by Darin Adler.
2742
2743         * DOM/ExceptionHandlers.mm:
2744         (raiseDOMErrorException):
2745         * Plugins/Hosted/ProxyInstance.mm:
2746         (WebKit::ProxyInstance::invokeMethod):
2747         * Storage/WebDatabaseProvider.mm:
2748         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2749
2750 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2751
2752         Recalc styles every time defaultAppearance changes.
2753         https://bugs.webkit.org/show_bug.cgi?id=186866
2754         rdar://problem/41309805
2755
2756         Reviewed by Tim Horton.
2757
2758         * WebView/WebView.mm:
2759         (-[WebView _updateDefaultAppearance]):
2760         (-[WebView _setUseSystemAppearance:]):
2761         (-[WebView _useSystemAppearance]):
2762
2763 2018-06-20  Darin Adler  <darin@apple.com>
2764
2765         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2766         https://bugs.webkit.org/show_bug.cgi?id=186875
2767
2768         Reviewed by Anders Carlsson.
2769
2770         * WebView/WebHTMLView.mm:
2771         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2772         to write te file to.
2773         * WebView/WebPreferences.mm:
2774         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2775         * WebView/WebView.mm:
2776         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2777
2778 2018-06-12  Darin Adler  <darin@apple.com>
2779
2780         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2781         https://bugs.webkit.org/show_bug.cgi?id=186526
2782
2783         Reviewed by Anders Carlsson.
2784
2785         * Plugins/Hosted/NetscapePluginHostManager.mm:
2786         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2787
2788         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2789         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
2790         assignment rather than adoptNS/leakRef.
2791         * Plugins/WebNetscapePluginView.mm:
2792         (-[WebNetscapePluginView createPlugin]): Ditto.
2793
2794         * WebCoreSupport/WebContextMenuClient.mm:
2795         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
2796         RetainPtr::autorelease; no need to autorelease just to pass something as a function
2797         argument, so use RetainPtr::get instead.
2798
2799         * WebView/WebHTMLView.mm:
2800         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
2801         No need to autorelease the result when the return type is RetainPtr.
2802
2803         * WebView/WebPDFRepresentation.mm:
2804         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
2805
2806 2018-06-13  Youenn Fablet  <youenn@apple.com>
2807
2808         Supported plugin check should be based on plugin identifier
2809         https://bugs.webkit.org/show_bug.cgi?id=186578
2810         <rdar://problem/40523828>
2811
2812         Reviewed by Darin Adler.
2813
2814         * WebCoreSupport/WebPluginInfoProvider.h:
2815         * WebCoreSupport/WebPluginInfoProvider.mm:
2816         (WebPluginInfoProvider::pluginInfo):
2817         (WebPluginInfoProvider::webVisiblePluginInfo):
2818
2819 2018-06-13  Chris Dumez  <cdumez@apple.com>
2820
2821         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2822         https://bugs.webkit.org/show_bug.cgi?id=186545
2823
2824         Reviewed by Brady Eidson.
2825
2826         Update client delegate now that parameter type has changed.
2827
2828         * WebCoreSupport/WebFrameLoaderClient.h:
2829         * WebCoreSupport/WebFrameLoaderClient.mm:
2830         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2831
2832 2018-06-11  Tim Horton  <timothy_horton@apple.com>
2833
2834         Link drag image is inconsistently unreadable in dark mode
2835         https://bugs.webkit.org/show_bug.cgi?id=186472
2836
2837         Reviewed by Timothy Hatcher.
2838
2839         * WebView/WebView.mm:
2840         (-[WebView _defaultAppearance]):
2841         Make defaultAppearance accurate even if useSystemAppearance is false.
2842         Some parts of WebKit (like the link drag image, but also context menus)
2843         want to be able to follow the system appearance regardless of whether
2844         the view or content has opted in.
2845
2846 2018-06-11  Chris Dumez  <cdumez@apple.com>
2847
2848         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2849         https://bugs.webkit.org/show_bug.cgi?id=186441
2850
2851         Reviewed by Brady Eidson.
2852
2853         Rename existing flag to something a bit more generic, now that it is used for
2854         more things than bypassing the navigation policy check.
2855
2856         * WebView/WebView.mm:
2857         (-[WebView _loadBackForwardListFromOtherView:]):
2858         (-[WebView goToBackForwardItem:]):
2859
2860 2018-06-09  Dan Bernstein  <mitz@apple.com>
2861
2862         [Xcode] Clean up and modernize some build setting definitions
2863         https://bugs.webkit.org/show_bug.cgi?id=186463
2864
2865         Reviewed by Sam Weinig.
2866
2867         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2868         * Configurations/DebugRelease.xcconfig: Ditto.
2869         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2870           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2871         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2872         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
2873           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
2874         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
2875
2876 2018-06-08  Darin Adler  <darin@apple.com>
2877
2878         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2879         https://bugs.webkit.org/show_bug.cgi?id=186436
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2884         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2885         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2886         (PoolCleaner): Ditto.
2887
2888         * History/WebHistory.mm:
2889         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2890         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2891         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2892         now hardly used if at all.
2893         * WebView/WebView.mm:
2894         (-[WebView rectsForTextMatches]): Ditto.
2895
2896 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2897
2898         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2899         https://bugs.webkit.org/show_bug.cgi?id=186442
2900         <rdar://problem/40879364>
2901
2902         Reviewed by Tim Horton.
2903
2904         * Configurations/FeatureDefines.xcconfig:
2905
2906 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2907
2908         [Datalist] Allow TextFieldInputType to show and hide suggestions
2909         https://bugs.webkit.org/show_bug.cgi?id=186151
2910
2911         Reviewed by Tim Horton.
2912
2913         * WebCoreSupport/WebChromeClient.h:
2914         * WebCoreSupport/WebChromeClient.mm:
2915         (WebChromeClient::createDataListSuggestionPicker):
2916
2917 2018-06-07  Chris Dumez  <cdumez@apple.com>
2918
2919         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2920         https://bugs.webkit.org/show_bug.cgi?id=186407
2921
2922         Reviewed by Brent Fulgham.
2923
2924         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2925         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2926         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2927         makeWeakPtr().
2928
2929         * WebCoreSupport/WebEditorClient.h:
2930         * WebCoreSupport/WebEditorClient.mm:
2931         (WebEditorClient::requestCandidatesForSelection):
2932
2933 2018-06-05  Chris Dumez  <cdumez@apple.com>
2934
2935         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2936         https://bugs.webkit.org/show_bug.cgi?id=186331
2937         <rdar://problem/40735446>
2938
2939         Reviewed by Darin Adler.
2940
2941         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2942         but does not call use / ignore on the listener, then we would do "use" by default.
2943         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2944         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2945         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2946         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2947         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2948         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2949         and Box.app is still working properly.
2950
2951         * WebCoreSupport/WebFrameLoaderClient.h:
2952         * WebCoreSupport/WebFrameLoaderClient.mm:
2953         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2954         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2955         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2956         (WebFrameLoaderClient::dispatchWillSubmitForm):
2957         (WebFrameLoaderClient::setUpPolicyListener):
2958         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2959         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2960         (-[WebFramePolicyListener dealloc]):
2961         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2962         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2963
2964 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2965
2966         Adjust compile and runtime flags to match shippable state of features
2967         https://bugs.webkit.org/show_bug.cgi?id=186319
2968         <rdar://problem/40352045>
2969
2970         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2971
2972         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2973         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2974         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2975         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2976         Cocoa builds.
2977
2978 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2979
2980         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2981
2982         https://bugs.webkit.org/show_bug.cgi?id=186323
2983         rdar://problem/38382252
2984
2985         Reviewed by Tim Horton.
2986
2987         * WebView/WebView.mm:
2988         (-[WebView _defaultAppearance]):
2989
2990 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2991
2992         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2993         https://bugs.webkit.org/show_bug.cgi?id=186286
2994         <rdar://problem/40782992>
2995
2996         Reviewed by Dan Bernstein.
2997
2998         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2999         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3000         change this flag when preparing for a production release.
3001
3002         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3003         whether experimental features should be enabled, and use it to properly define the
3004         feature flag.
3005
3006 2018-06-03  Darin Adler  <darin@apple.com>
3007
3008         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3009         https://bugs.webkit.org/show_bug.cgi?id=186258
3010
3011         Reviewed by Daniel Bates.
3012
3013         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3014         forward declarations. Removed methods that don't need to be public.
3015
3016         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3017         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3018         unnamed category in here and also replaced the HUDWindowControllerDelegate
3019         with the unnamed category. Removed unused NSWindow category defining the
3020         isOnActiveSpace, which is not called anywhere in this file at this time.
3021         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3022         into setVideoElement.
3023         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3024         and removed unneeded typecast.
3025         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3026         using statement at the top of the file.
3027         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3028         the many side effects and special considerations that this method that sounds
3029         like a setter has. Updated code to use the new
3030         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3031         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3032         bit and added some FIXME comments about small problems noticed but not fixed.
3033         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3034         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3035         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3036         typecast. Removed call to updatePowerAssertions method.
3037         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3038         updatePowerAssertions method.
3039         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3040         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3041         else, so this was dead code that did nothing.
3042         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3043         updatePowerAssertions method.
3044
3045 2018-06-04  Chris Dumez  <cdumez@apple.com>
3046
3047         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3048         https://bugs.webkit.org/show_bug.cgi?id=186287
3049         <rdar://problem/40783352>
3050
3051         Reviewed by Youenn Fablet.
3052
3053         * WebView/WebPreferenceKeysPrivate.h:
3054         * WebView/WebPreferences.mm:
3055         (+[WebPreferences initialize]):
3056         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3057         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3058         * WebView/WebPreferencesPrivate.h:
3059         * WebView/WebView.mm:
3060         (-[WebView _preferencesChanged:]):
3061
3062 2018-06-02  Darin Adler  <darin@apple.com>
3063
3064         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3065         https://bugs.webkit.org/show_bug.cgi?id=186227
3066
3067         Reviewed by Dan Bernstein.
3068
3069         * Misc/WebKitErrors.m:
3070         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3071         * Plugins/WebPluginDatabase.mm:
3072         (-[WebPluginDatabase refresh]): Ditto.
3073         * WebCoreSupport/WebChromeClient.mm:
3074         (WebChromeClient::setStatusbarText): Ditto.
3075
3076 2018-06-01  Chris Dumez  <cdumez@apple.com>
3077
3078         REGRESSION (r231456): Colloquy is broken
3079         https://bugs.webkit.org/show_bug.cgi?id=186197
3080         <rdar://problem/40722960>
3081
3082         Reviewed by Timothy Hatcher.
3083
3084         Restore pre-r231456 behavior for Colloquy app so that it works again.
3085
3086         * WebView/WebView.mm:
3087         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3088         (-[WebView _preferencesChanged:]):
3089
3090 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3091
3092         [JSC] Pass VM& parameter as much as possible
3093         https://bugs.webkit.org/show_bug.cgi?id=186085
3094
3095         Reviewed by Saam Barati.
3096
3097         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3098         (WebKit::NetscapePluginInstanceProxy::invoke):
3099
3100 2018-05-30  Daniel Bates  <dabates@apple.com>
3101
3102         NavigationAction does not need to hold initiating DOM Event
3103         https://bugs.webkit.org/show_bug.cgi?id=185958
3104         <rdar://problem/40531539>
3105
3106         Reviewed by Simon Fraser.
3107
3108         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3109
3110         * WebCoreSupport/WebFrameLoaderClient.mm:
3111         (WebFrameLoaderClient::actionDictionary const):
3112         (findMouseEvent): Deleted.
3113
3114 2018-05-27  Dan Bernstein  <mitz@apple.com>
3115
3116         Reverted the changes made for https://webkit.org/b/186016
3117
3118         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3119
3120
3121 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3122
3123         [iOS] Fix warnings about leaks found by clang static analyzer
3124         <https://webkit.org/b/186009>
3125         <rdar://problem/40574267>
3126
3127         Reviewed by Daniel Bates.
3128
3129         * WebView/WebHTMLView.mm:
3130         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3131         uninitialized boolean variable (`eventWasHandled`) that only
3132         happened on iOS.
3133
3134 2018-05-27  Dan Bernstein  <mitz@apple.com>
3135
3136         [Cocoa] Avoid importing directly from subumbrella frameworks
3137         https://bugs.webkit.org/show_bug.cgi?id=186016
3138
3139         Reviewed by Sam Weinig.
3140
3141         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3142         * Carbon/CarbonWindowAdapter.mm: Ditto.
3143         * Carbon/CarbonWindowFrame.m: Ditto.
3144         * Carbon/HIViewAdapter.h: Ditto.
3145         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3146           OTHER_CPLUSPLUSFLAGS.
3147         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3148         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3149         * WebView/WebPDFView.h: Ditto.
3150
3151 2018-05-27  Sam Weinig  <sam@webkit.org>
3152
3153         Modernize RenderStyleConstants.h - Part 3
3154         https://bugs.webkit.org/show_bug.cgi?id=186015
3155
3156         Reviewed by Yusuke Suzuki.
3157
3158         * WebView/WebView.mm:
3159         (-[WebView updateTextTouchBar]):
3160         Update for new enum name.
3161
3162 2018-05-25  Chris Dumez  <cdumez@apple.com>
3163
3164         Minor ApplicationCacheStorage clean up
3165         https://bugs.webkit.org/show_bug.cgi?id=185984
3166
3167         Reviewed by Youenn Fablet.
3168
3169         * WebCoreSupport/WebApplicationCache.mm:
3170         (+[WebApplicationCache originsWithCache]):
3171
3172 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3173
3174         Fix issues with -dealloc methods found by clang static analyzer
3175         <https://webkit.org/b/185887>
3176
3177         Reviewed by Joseph Pecoraro.
3178
3179         * WebView/WebView.mm:
3180         (-[WebUITextIndicatorData dealloc]):
3181         - Move method implementation from (WebUITextIndicatorInternal)
3182           category to the main category since this is public API.  This
3183           fixes the false positive warning about a missing -dealloc
3184           method.
3185
3186 2018-05-24  Sam Weinig  <sam@webkit.org>
3187
3188         Modernize RenderStyleConstants.h - Part 2
3189         https://bugs.webkit.org/show_bug.cgi?id=185901
3190
3191         Reviewed by Simon Fraser.
3192
3193         * WebView/WebHTMLRepresentation.mm:
3194         (searchForLabelsBeforeElement):
3195         * WebView/WebView.mm:
3196         (nsTextAlignmentFromRenderStyle):
3197         Update for new enum names.
3198
3199 2018-05-22  Chris Dumez  <cdumez@apple.com>
3200
3201         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3202         https://bugs.webkit.org/show_bug.cgi?id=185832
3203         <rdar://problem/40307871>
3204
3205         Reviewed by Geoffrey Garen.
3206
3207         We used to have a bug where where we would fail to wait for the policy decision for
3208         the navigation response from the client and the load would keep going, racing with
3209         the client's policy decision. If the client did not respond in time, the behavior
3210         would be the same as "Use" policy action.
3211
3212         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3213         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3214         WebKit bug, however, the load would hang because the completion handler for the
3215         decidePolicyForNavigationResponse would never get called.
3216
3217         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3218         instead of retaining it. If the policy listener object gets destroyed because getting
3219         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3220         behavior.
3221
3222         * WebCoreSupport/WebFrameLoaderClient.h:
3223         * WebCoreSupport/WebFrameLoaderClient.mm:
3224         (WebFrameLoaderClient::cancelPolicyCheck):
3225         (WebFrameLoaderClient::setUpPolicyListener):
3226         (-[WebFramePolicyListener dealloc]):
3227
3228 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3229
3230         Unreviewed, rolling out r232052.
3231
3232         Breaks internal builds.
3233
3234         Reverted changeset:
3235
3236         "Use more C++17"
3237         https://bugs.webkit.org/show_bug.cgi?id=185176
3238         https://trac.webkit.org/changeset/232052
3239
3240 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3241
3242         Use more C++17
3243         https://bugs.webkit.org/show_bug.cgi?id=185176
3244
3245         Reviewed by JF Bastien.
3246
3247         * Configurations/Base.xcconfig:
3248         * Configurations/WebKitLegacy.xcconfig:
3249
3250 2018-05-21  Chris Nardi  <cnardi@chromium.org>
3251
3252         Remove dead exception in MediaList.appendMedium
3253         https://bugs.webkit.org/show_bug.cgi?id=185278
3254
3255         Reviewed by Chris Dumez.
3256
3257         Remove code pertaining to an exception being thrown by appendMedium().
3258
3259         * DOM/DOMMediaList.mm:
3260         (-[DOMMediaList appendMedium:]):
3261
3262 2018-05-21  Jer Noble  <jer.noble@apple.com>
3263
3264         Complete fix for enabling modern EME by default
3265         https://bugs.webkit.org/show_bug.cgi?id=185770
3266         <rdar://problem/40368220>
3267
3268         Reviewed by Eric Carlson.
3269
3270         * Configurations/FeatureDefines.xcconfig:
3271
3272 2018-05-21  Antti Koivisto  <antti@apple.com>
3273
3274         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3275         https://bugs.webkit.org/show_bug.cgi?id=185815
3276         <rdar://problem/40310069>
3277
3278         Reviewed by Simon Fraser.
3279
3280         User stylesheet parsing may depend on the colorFilterEnabled preference.
3281
3282         * WebView/WebView.mm:
3283         (-[WebView _preferencesChanged:]):
3284
3285 2018-05-18  Commit Queue  <commit-queue@webkit.org>
3286
3287         Unreviewed, rolling out r231982.
3288         https://bugs.webkit.org/show_bug.cgi?id=185793
3289
3290         Caused layout test failures (Requested by realdawei on
3291         #webkit).
3292
3293         Reverted changeset:
3294
3295         "Complete fix for enabling modern EME by default"
3296         https://bugs.webkit.org/show_bug.cgi?id=185770
3297         https://trac.webkit.org/changeset/231982
3298
3299 2018-05-18  Jer Noble  <jer.noble@apple.com>
3300
3301         Complete fix for enabling modern EME by default
3302         https://bugs.webkit.org/show_bug.cgi?id=185770
3303         <rdar://problem/40368220>
3304
3305         Reviewed by Eric Carlson.
3306
3307         * Configurations/FeatureDefines.xcconfig:
3308
3309 2018-05-18  Chris Dumez  <cdumez@apple.com>
3310
3311         Avoid keeping the frame alive when ref'ing a WindowProxy
3312         https://bugs.webkit.org/show_bug.cgi?id=185737
3313         <rdar://problem/40004666>
3314
3315         Reviewed by Sam Weinig.
3316
3317         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3318         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3319
3320 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3321
3322         Add support for Intl NumberFormat formatToParts
3323         https://bugs.webkit.org/show_bug.cgi?id=185375
3324
3325         Reviewed by Yusuke Suzuki.
3326
3327         Add flag for NumberFormat formatToParts.
3328
3329         * Configurations/FeatureDefines.xcconfig:
3330
3331 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3332
3333         Fixup after r231849: Do not mark Mac API methods as deprecated
3334         https://bugs.webkit.org/show_bug.cgi?id=185684
3335
3336         Reviewed by Darin Adler.
3337
3338         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3339         as the entire class is already marked as deprecated, so it is unnecessary.
3340
3341         * DOM/DOMDocument.h:
3342
3343 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3344
3345         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3346         https://bugs.webkit.org/show_bug.cgi?id=185381
3347
3348         Reviewed by Darin Adler.
3349
3350         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3351         and make them do nothing.
3352
3353         * DOM/DOMDocument.h:
3354         * DOM/DOMDocument.mm:
3355         (-[DOMDocument preferredStylesheetSet]):
3356         (-[DOMDocument selectedStylesheetSet]):
3357         (-[DOMDocument setSelectedStylesheetSet:]):
3358
3359 2018-05-15  Antoine Quint  <graouts@apple.com>
3360
3361         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3362         https://bugs.webkit.org/show_bug.cgi?id=185647
3363
3364         Reviewed by Dean Jackson.
3365
3366         Rename the Web Animations CSS integration flag.
3367
3368         * WebView/WebPreferenceKeysPrivate.h:
3369         * WebView/WebPreferences.mm:
3370         (+[WebPreferences initialize]):
3371         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3372         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3373         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3374         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3375         * WebView/WebPreferencesPrivate.h:
3376         * WebView/WebView.mm:
3377         (-[WebView _preferencesChanged:]):
3378
3379 2018-05-14  Daniel Bates  <dabates@apple.com>
3380
3381         Fix the Apple Internal build
3382
3383         See <rdar://problem/40237873> for more details.
3384
3385         * WebView/WebFullScreenController.mm:
3386         (-[WebFullScreenController enterFullScreen:]):
3387         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3388         (-[WebFullScreenController exitFullScreen]):
3389         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3390         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3391         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3392
3393 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3394
3395         WebHTMLView is not setting aside subviews when drawing.
3396
3397         https://bugs.webkit.org/show_bug.cgi?id=185561
3398         rdar://problem/40172894
3399
3400         Reviewed by Simon Fraser.
3401
3402         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3403
3404         * WebView/WebHTMLView.mm:
3405         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3406
3407 2018-05-07  Daniel Bates  <dabates@apple.com>
3408
3409         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3410         https://bugs.webkit.org/show_bug.cgi?id=185170
3411
3412         Reviewed by Per Arne Vollan.
3413
3414         * Misc/WebCache.mm:
3415         (+[WebCache empty]):
3416
3417 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3418
3419         Deprecate legacy WebView and friends
3420         https://bugs.webkit.org/show_bug.cgi?id=185279
3421         rdar://problem/33268700
3422
3423         Reviewed by Tim Horton.
3424
3425         Added deprecation macros to all the classes, extern strings, and enums.
3426
3427         * Configurations/WebKitLegacy.xcconfig:
3428         Added BUILDING_WEBKIT define to disable the deprecation macros.
3429         * DOM/DOMAbstractView.h:
3430         * DOM/DOMAttr.h:
3431         * DOM/DOMBlob.h:
3432         * DOM/DOMCDATASection.h:
3433         * DOM/DOMCSSCharsetRule.h:
3434         * DOM/DOMCSSFontFaceRule.h:
3435         * DOM/DOMCSSImportRule.h:
3436         * DOM/DOMCSSMediaRule.h:
3437         * DOM/DOMCSSPageRule.h:
3438         * DOM/DOMCSSPrimitiveValue.h:
3439         * DOM/DOMCSSRule.h:
3440         * DOM/DOMCSSRuleList.h:
3441         * DOM/DOMCSSStyleDeclaration.h:
3442         * DOM/DOMCSSStyleRule.h:
3443         * DOM/DOMCSSStyleSheet.h:
3444         * DOM/DOMCSSUnknownRule.h:
3445         * DOM/DOMCSSValue.h:
3446         * DOM/DOMCSSValueList.h:
3447         * DOM/DOMCharacterData.h:
3448         * DOM/DOMComment.h:
3449         * DOM/DOMCounter.h:
3450         * DOM/DOMDocument.h:
3451         * DOM/DOMDocumentFragment.h:
3452         * DOM/DOMDocumentType.h:
3453         * DOM/DOMElement.h:
3454         * DOM/DOMEntity.h:
3455         * DOM/DOMEntityReference.h:
3456         * DOM/DOMEvent.h:
3457         * DOM/DOMEventException.h:
3458         * DOM/DOMEventListener.h:
3459         * DOM/DOMEventTarget.h:
3460         * DOM/DOMException.h:
3461         * DOM/DOMFile.h:
3462         * DOM/DOMFileList.h:
3463         * DOM/DOMHTMLAnchorElement.h:
3464         * DOM/DOMHTMLAppletElement.h:
3465         * DOM/DOMHTMLAreaElement.h:
3466         * DOM/DOMHTMLBRElement.h:
3467         * DOM/DOMHTMLBaseElement.h:
3468         * DOM/DOMHTMLBaseFontElement.h:
3469         * DOM/DOMHTMLBodyElement.h:
3470         * DOM/DOMHTMLButtonElement.h:
3471         * DOM/DOMHTMLCanvasElement.h:
3472         * DOM/DOMHTMLCollection.h:
3473         * DOM/DOMHTMLDListElement.h:
3474         * DOM/DOMHTMLDirectoryElement.h:
3475         * DOM/DOMHTMLDivElement.h:
3476         * DOM/DOMHTMLDocument.h:
3477         * DOM/DOMHTMLElement.h:
3478         * DOM/DOMHTMLEmbedElement.h:
3479         * DOM/DOMHTMLFieldSetElement.h:
3480         * DOM/DOMHTMLFontElement.h:
3481         * DOM/DOMHTMLFormElement.h:
3482         * DOM/DOMHTMLFrameElement.h:
3483         * DOM/DOMHTMLFrameSetElement.h:
3484         * DOM/DOMHTMLHRElement.h:
3485         * DOM/DOMHTMLHeadElement.h:
3486         * DOM/DOMHTMLHeadingElement.h:
3487         * DOM/DOMHTMLHtmlElement.h:
3488         * DOM/DOMHTMLIFrameElement.h:
3489         * DOM/DOMHTMLImageElement.h:
3490         * DOM/DOMHTMLInputElement.h:
3491         * DOM/DOMHTMLLIElement.h:
3492         * DOM/DOMHTMLLabelElement.h:
3493         * DOM/DOMHTMLLegendElement.h:
3494         * DOM/DOMHTMLLinkElement.h:
3495         * DOM/DOMHTMLMapElement.h:
3496         * DOM/DOMHTMLMarqueeElement.h:
3497         * DOM/DOMHTMLMediaElement.h:
3498         * DOM/DOMHTMLMenuElement.h:
3499         * DOM/DOMHTMLMetaElement.h:
3500         * DOM/DOMHTMLModElement.h:
3501         * DOM/DOMHTMLOListElement.h:
3502         * DOM/DOMHTMLObjectElement.h:
3503         * DOM/DOMHTMLOptGroupElement.h:
3504         * DOM/DOMHTMLOptionElement.h:
3505         * DOM/DOMHTMLOptionsCollection.h:
3506         * DOM/DOMHTMLParagraphElement.h:
3507         * DOM/DOMHTMLParamElement.h:
3508         * DOM/DOMHTMLPreElement.h:
3509         * DOM/DOMHTMLQuoteElement.h:
3510         * DOM/DOMHTMLScriptElement.h:
3511         * DOM/DOMHTMLSelectElement.h:
3512         * DOM/DOMHTMLStyleElement.h:
3513         * DOM/DOMHTMLTableCaptionElement.h:
3514         * DOM/DOMHTMLTableCellElement.h:
3515         * DOM/DOMHTMLTableColElement.h:
3516         * DOM/DOMHTMLTableElement.h:
3517         * DOM/DOMHTMLTableRowElement.h:
3518         * DOM/DOMHTMLTableSectionElement.h:
3519         * DOM/DOMHTMLTextAreaElement.h:
3520         * DOM/DOMHTMLTitleElement.h:
3521         * DOM/DOMHTMLUListElement.h:
3522         * DOM/DOMHTMLVideoElement.h:
3523         * DOM/DOMImplementation.h:
3524         * DOM/DOMKeyboardEvent.h:
3525         * DOM/DOMMediaError.h:
3526         * DOM/DOMMediaList.h:
3527         * DOM/DOMMouseEvent.h:
3528         * DOM/DOMMutationEvent.h:
3529         * DOM/DOMNamedNodeMap.h:
3530         * DOM/DOMNode.h:
3531         * DOM/DOMNodeFilter.h:
3532         * DOM/DOMNodeIterator.h:
3533         * DOM/DOMNodeList.h:
3534         * DOM/DOMObject.h:
3535         * DOM/DOMOverflowEvent.h:
3536         * DOM/DOMProcessingInstruction.h:
3537         * DOM/DOMProgressEvent.h:
3538         * DOM/DOMRGBColor.h:
3539         * DOM/DOMRange.h:
3540         * DOM/DOMRangeException.h:
3541         * DOM/DOMRect.h:
3542         * DOM/DOMStyleSheet.h:
3543         * DOM/DOMStyleSheetList.h:
3544         * DOM/DOMText.h:
3545         * DOM/DOMTextEvent.h:
3546         * DOM/DOMTimeRanges.h:
3547         * DOM/DOMTokenList.h:
3548         * DOM/DOMTreeWalker.h:
3549         * DOM/DOMUIEvent.h:
3550         * DOM/DOMWheelEvent.h:
3551         * DOM/DOMXPathException.h:
3552         * DOM/DOMXPathExpression.h:
3553         * DOM/DOMXPathNSResolver.h:
3554         * DOM/DOMXPathResult.h:
3555         * History/WebBackForwardList.h:
3556         * History/WebHistory.h:
3557         * History/WebHistoryItem.h:
3558         * Misc/WebDownload.h:
3559         * Misc/WebKitErrors.h:
3560         * Plugins/WebPluginViewFactory.h:
3561         * WebView/WebArchive.h:
3562         * WebView/WebDataSource.h:
3563         * WebView/WebDocument.h:
3564         * WebView/WebEditingDelegate.h:
3565         * WebView/WebFormDelegate.h:
3566         * WebView/WebFrame.h:
3567         * WebView/WebFrameLoadDelegate.h:
3568         * WebView/WebFrameView.h:
3569         * WebView/WebPolicyDelegate.h:
3570         * WebView/WebPreferences.h:
3571         * WebView/WebPreferencesPrivate.h:
3572         * WebView/WebResourceLoadDelegate.h:
3573         * WebView/WebUIDelegate.h:
3574         * WebView/WebUIDelegatePrivate.h:
3575         * WebView/WebView.h:
3576         * WebView/WebViewPrivate.h:
3577         * postprocess-headers.sh:
3578         Remove step that converts WEBKIT macros to NS macros.
3579         Change it to just remove the macros on iOS builds.
3580
3581 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3582
3583         [MediaStream] remove WK1 support
3584         https://bugs.webkit.org/show_bug.cgi?id=185136
3585
3586         Reviewed by Youenn Fablet.
3587
3588         * WebCoreSupport/WebUserMediaClient.h: Removed.
3589         * WebCoreSupport/WebUserMediaClient.mm: Removed.
3590         * WebView/WebView.mm:
3591         (-[WebView _commonInitializationWithFrameName:groupName:]):
3592         (-[WebView _preferencesChanged:]):
3593         (-[WebView _setUserMediaClient:]): Deleted.
3594         (-[WebView _userMediaClient]): Deleted.
3595         * WebView/WebViewData.h:
3596         * WebView/WebViewPrivate.h:
3597
3598 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3599
3600         WebAssembly: add support for stream APIs - JavaScript API
3601         https://bugs.webkit.org/show_bug.cgi?id=183442
3602
3603         Reviewed by Yusuke Suzuki and JF Bastien.
3604
3605         Add WEBASSEMBLY_STREAMINNG_API feature flag
3606
3607         * Configurations/FeatureDefines.xcconfig:
3608
3609 2018-04-30  JF Bastien  <jfbastien@apple.com>
3610
3611         Use some C++17 features
3612         https://bugs.webkit.org/show_bug.cgi?id=185135
3613
3614         Reviewed by Alex Christensen.
3615
3616         * Configurations/WebKitLegacy.xcconfig:
3617
3618 2018-04-27  Chris Dumez  <cdumez@apple.com>
3619
3620         Use WindowProxy instead of DOMWindow in our IDL
3621         https://bugs.webkit.org/show_bug.cgi?id=185022
3622
3623         Reviewed by Sam Weinig.
3624
3625         * DOM/DOMAbstractView.mm:
3626         (kit):
3627         (toWindowProxy):
3628         * DOM/DOMAbstractViewInternal.h:
3629         * DOM/DOMDocument.mm:
3630         (-[DOMDocument defaultView]):
3631         (-[DOMDocument getComputedStyle:pseudoElement:]):
3632         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
3633         * DOM/DOMHTMLFrameElement.mm:
3634         (-[DOMHTMLFrameElement contentWindow]):
3635         * DOM/DOMHTMLIFrameElement.mm:
3636         (-[DOMHTMLIFrameElement contentWindow]):
3637         * DOM/DOMKeyboardEvent.mm:
3638         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3639         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
3640         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3641         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
3642         * DOM/DOMMouseEvent.mm:
3643         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
3644         * DOM/DOMTextEvent.mm:
3645         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
3646         * DOM/DOMUIEvent.mm:
3647         (-[DOMUIEvent view]):
3648         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
3649         * DOM/DOMWheelEvent.mm:
3650         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3651
3652 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
3653
3654         Implement rendering support for the color-filter CSS property
3655         https://bugs.webkit.org/show_bug.cgi?id=185047
3656         rdar://problem/39664967
3657
3658         Reviewed by Tim Horton.
3659         
3660         The body background should reflect the filtered color.
3661
3662         * WebView/WebFrame.mm:
3663         (-[WebFrame _bodyBackgroundColor]):
3664         * WebView/WebView.mm:
3665         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
3666
3667 2018-04-26  Jer Noble  <jer.noble@apple.com>
3668
3669         WK_COCOA_TOUCH all the things.
3670         https://bugs.webkit.org/show_bug.cgi?id=185006
3671
3672         Reviewed by Tim Horton.
3673
3674         * Configurations/WebKitLegacy.xcconfig:
3675
3676 2018-04-26  Daniel Bates  <dabates@apple.com>
3677
3678         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
3679         https://bugs.webkit.org/show_bug.cgi?id=184161
3680         <rdar://problem/39051645>
3681
3682         Reviewed by Dan Bernstein.
3683
3684         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
3685         dropping a PDF embedded using an HTML image element into the same web view.
3686
3687         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
3688         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
3689         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
3690         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
3691         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
3692         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
3693         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
3694         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
3695         image document when navigated to directly. Since we can support dragging PDF document images we need to
3696         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
3697         We need to do both such queries before falling back to using the main resource of the Web Archive as
3698         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
3699         not an image document.
3700
3701         * Misc/WebNSPasteboardExtras.mm:
3702         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
3703
3704 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3705
3706         Disable content filtering in minimal simulator mode
3707         https://bugs.webkit.org/show_bug.cgi?id=185027
3708         <rdar://problem/39736091>
3709
3710         Reviewed by Jer Noble.
3711
3712         * Configurations/FeatureDefines.xcconfig:
3713
3714 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3715
3716         [INTL] Implement Intl.PluralRules
3717         https://bugs.webkit.org/show_bug.cgi?id=184312
3718
3719         Reviewed by JF Bastien.
3720
3721         Added Intl.PluralRules feature flag.
3722
3723         * Configurations/FeatureDefines.xcconfig:
3724
3725 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3726
3727         Remove access to keychain from the WebContent process
3728         https://bugs.webkit.org/show_bug.cgi?id=184428
3729         <rdar://problem/13150903>
3730
3731         Reviewed by Brent Fulgham.
3732
3733         This patch does the followings:
3734         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
3735         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
3736         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
3737
3738         * WebCoreSupport/WebChromeClient.h:
3739         * WebCoreSupport/WebChromeClient.mm:
3740         (WebChromeClient::signedPublicKeyAndChallengeString const):
3741         * WebView/WebUIDelegatePrivate.h:
3742
3743 2018-04-24  Jer Noble  <jer.noble@apple.com>
3744
3745         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3746         https://bugs.webkit.org/show_bug.cgi?id=184786
3747
3748         Reviewed by Tim Horton.
3749
3750         * Configurations/WebKitLegacy.xcconfig:
3751         * MigrateHeaders.make:
3752
3753 2018-04-23  Daniel Bates  <dabates@apple.com>
3754
3755         Implement Same-Site cookies
3756         https://bugs.webkit.org/show_bug.cgi?id=159464
3757         <rdar://problem/27196358>
3758
3759         Reviewed by Brent Fulgham.
3760
3761         Pass the Same-Site info through the strategy.
3762
3763         * WebCoreSupport/WebPlatformStrategies.h:
3764         * WebCoreSupport/WebPlatformStrategies.mm:
3765         (WebPlatformStrategies::cookiesForDOM):
3766         (WebPlatformStrategies::setCookiesFromDOM):
3767         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3768         (WebPlatformStrategies::getRawCookies):
3769
3770 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3771
3772         [LayoutFormattingContext] Initial commit.
3773         https://bugs.webkit.org/show_bug.cgi?id=184896
3774
3775         Reviewed by Antti Koivisto.
3776
3777         * Configurations/FeatureDefines.xcconfig:
3778
3779 2018-04-23  Daniel Bates  <dabates@apple.com>
3780
3781         Implement Same-Site cookies
3782         https://bugs.webkit.org/show_bug.cgi?id=159464
3783         <rdar://problem/27196358>
3784
3785         Reviewed by Brent Fulgham.
3786
3787         Pass the Same-Site info through the strategy.
3788
3789         * WebCoreSupport/WebPlatformStrategies.h:
3790         * WebCoreSupport/WebPlatformStrategies.mm:
3791         (WebPlatformStrategies::cookiesForDOM):
3792         (WebPlatformStrategies::setCookiesFromDOM):
3793         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3794         (WebPlatformStrategies::getRawCookies):
3795
3796 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3797
3798         NULL dereference crash sometimes under [super initWithCoder:] in WebView
3799
3800         https://bugs.webkit.org/show_bug.cgi?id=184851
3801         rdar://problem/39611236
3802
3803         Reviewed by Tim Horton.
3804
3805         * WebView/WebView.mm:
3806         (-[WebView _commonInitializationWithFrameName:groupName:]):
3807         (-[WebView effectiveAppearanceDidChange]):
3808         Added a null check and call the code later in initialization.
3809
3810 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3811
3812         Adjust geolocation feature flag
3813         https://bugs.webkit.org/show_bug.cgi?id=184856
3814
3815         Reviewed by Wenson Hsieh.
3816
3817         * Configurations/FeatureDefines.xcconfig:
3818
3819 2018-04-18  Jer Noble  <jer.noble@apple.com>
3820
3821         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3822         https://bugs.webkit.org/show_bug.cgi?id=184762
3823
3824         Reviewed by Dan Bernstein.
3825
3826         * Configurations/WebKitLegacy.xcconfig:
3827
3828 2018-04-20  Youenn Fablet  <youenn@apple.com>
3829
3830         Make PluginData cache its web visible plugins
3831         https://bugs.webkit.org/show_bug.cgi?id=184421
3832
3833         Reviewed by Chris Dumez.
3834
3835         * WebCoreSupport/WebPluginInfoProvider.h:
3836         * WebCoreSupport/WebPluginInfoProvider.mm:
3837         (WebPluginInfoProvider::pluginInfo):
3838         (WebPluginInfoProvider::webVisiblePluginInfo):
3839
3840 2018-04-19  Chris Dumez  <cdumez@apple.com>
3841
3842         Rename JSDOMWindowProxy to JSWindowProxy
3843         https://bugs.webkit.org/show_bug.cgi?id=184797
3844
3845         Reviewed by Sam Weinig.
3846
3847         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
3848
3849         * DOM/DOMUtility.mm:
3850         (createDOMWrapper):
3851         * WebView/WebFrame.mm:
3852         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3853
3854 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3855
3856         Enable Objective-C weak references
3857         <https://webkit.org/b/184789>
3858         <rdar://problem/39571716>
3859
3860         Reviewed by Dan Bernstein.
3861
3862         * Configurations/Base.xcconfig:
3863         (CLANG_ENABLE_OBJC_WEAK): Enable.
3864
3865 2018-04-18  Chris Dumez  <cdumez@apple.com>
3866
3867         Rename WindowProxyController to WindowProxy
3868         https://bugs.webkit.org/show_bug.cgi?id=184756
3869
3870         Reviewed by Sam Weinig.
3871
3872         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
3873         needed use WindowProxyController type, which was a bit confusing.
3874
3875         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3876         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3877         * WebView/WebFrame.mm:
3878         (-[WebFrame _attachScriptDebugger]):
3879
3880 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3881
3882         Unreviewed rollout of r230632. Regression in memory usage.
3883
3884         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3885
3886         * WebView/WebPreferences.mm:
3887         (+[WebPreferences initialize]):
3888
3889 2018-04-17  Chris Dumez  <cdumez@apple.com>
3890
3891         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3892         https://bugs.webkit.org/show_bug.cgi?id=184678
3893         <rdar://problem/39422122>
3894
3895         Reviewed by Alex Christensen.
3896
3897         Add new parameter to dispatchDecidePolicyForNavigationAction.
3898
3899         * WebCoreSupport/WebFrameLoaderClient.h:
3900         * WebCoreSupport/WebFrameLoaderClient.mm:
3901         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3902
3903 2018-04-13  Chris Dumez  <cdumez@apple.com>
3904
3905         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3906         https://bugs.webkit.org/show_bug.cgi?id=184591
3907
3908         Reviewed by Sam Weinig.
3909
3910         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3911         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3912         This is work towards fixing Bug 184515.
3913
3914         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3915         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3916         * WebView/WebFrame.mm:
3917         (-[WebFrame _attachScriptDebugger]):
3918
3919 2018-04-12  Antoine Quint  <graouts@apple.com>
3920
3921         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3922         https://bugs.webkit.org/show_bug.cgi?id=184569
3923         <rdar://problem/38671301>
3924
3925         Reviewed by Jon Lee.
3926
3927         * WebView/WebPreferences.mm:
3928
3929 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3930
3931         [WTF] Remove StaticLock
3932         https://bugs.webkit.org/show_bug.cgi?id=184332
3933
3934         Reviewed by Mark Lam.
3935
3936         * DOM/DOMInternal.mm:
3937         (getDOMWrapper):
3938         (addDOMWrapper):
3939         (removeDOMWrapper):
3940
3941 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3942
3943         Failures from mach port reference handling should be fatal
3944         https://bugs.webkit.org/show_bug.cgi?id=184202
3945         <rdar://problem/37771114>
3946
3947         Reviewed by Anders Carlsson.
3948
3949         * Plugins/Hosted/NetscapePluginHostManager.mm:
3950         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3951
3952 2018-04-03  Andy Estes  <aestes@apple.com>
3953
3954         [Mac] Prioritize file promises over filenames during drag and drop
3955         https://bugs.webkit.org/show_bug.cgi?id=184237
3956         <rdar://problem/38278076>
3957
3958         Reviewed by Wenson Hsieh.
3959
3960         * WebView/WebView.mm:
3961         (-[WebView performDragOperation:]):
3962
3963 2018-04-03  Chris Dumez  <cdumez@apple.com>
3964
3965         Drop MainFrame class
3966         https://bugs.webkit.org/show_bug.cgi?id=184191
3967
3968         Reviewed by Darin Adler.
3969
3970         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3971         relationship between the Page and the MainFrame.
3972
3973         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3974
3975         * WebCoreSupport/WebDragClient.mm:
3976         * WebCoreSupport/WebFrameLoaderClient.mm:
3977         * WebCoreSupport/WebInspectorClient.mm:
3978         * WebCoreSupport/WebPlatformStrategies.mm:
3979         * WebCoreSupport/WebPluginInfoProvider.mm:
3980         * WebView/WebFrame.mm:
3981         * WebView/WebFrameView.mm:
3982         * WebView/WebHTMLView.mm:
3983         * WebView/WebView.mm:
3984
3985 2018-04-02  Jer Noble  <jer.noble@apple.com>
3986
3987         Enable Legacy EME for all WebKit & WebKitLegacy clients
3988         https://bugs.webkit.org/show_bug.cgi?id=184018
3989         <rdar://problem/34887387>
3990
3991         Reviewed by Eric Carlson.
3992
3993         * WebView/WebPreferences.mm:
3994         (+[WebPreferences initialize]):
3995
3996 2018-03-29  JF Bastien  <jfbastien@apple.com>
3997
3998         Use Forward.h instead of forward-declaring WTF::String
3999         https://bugs.webkit.org/show_bug.cgi?id=184172
4000         <rdar://problem/39026146>
4001
4002         Reviewed by Yusuke Suzuki.
4003
4004         As part of #184164 I'm changing WTF::String, and the forward
4005         declarations are just wrong because I'm making it templated. We
4006         should use Forward.h anyways, so do that instead.
4007
4008         * WebView/WebScriptDebugger.h:
4009
4010 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
4011
4012         Protect against invalid mach ports returned by mach_port_request_notification
4013         https://bugs.webkit.org/show_bug.cgi?id=184106
4014         <rdar://problem/37865316>
4015
4016         Reviewed by Chris Dumez.
4017
4018         * Plugins/Hosted/NetscapePluginHostProxy.mm:
4019         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
4020         and clean up if it experienced an error.
4021         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
4022
4023 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
4024
4025         Avoid uninitialized mach ports
4026         https://bugs.webkit.org/show_bug.cgi?id=184090
4027         <rdar://problem/37261129>
4028
4029         Reviewed by Chris Dumez.
4030
4031         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
4032         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
4033         there is a potential for us to try to use invalid ports.
4034
4035         We should always check return values, and ensure that the mach port variables we seek to initialize are
4036         kept in a valid state.
4037
4038         Reviewed by Chris Dumez.
4039
4040         * Plugins/Hosted/NetscapePluginHostManager.h:
4041         * Plugins/Hosted/NetscapePluginHostManager.mm:
4042         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
4043         port is passed to an API function.
4044         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
4045         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
4046         * Plugins/Hosted/NetscapePluginHostProxy.h:
4047         * Plugins/Hosted/NetscapePluginHostProxy.mm:
4048         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
4049         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
4050         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
4051         (WKPCStatusText): Ditto.
4052         (WKPCLoadURL): Ditto.
4053         (WKPCCancelLoadURL): Ditto.
4054         (WKPCInvalidateRect): Ditto.
4055         (WKPCGetScriptableNPObjectReply): Ditto.
4056         (WKPCBooleanReply): Ditto.
4057         (WKPCBooleanAndDataReply): Ditto.
4058         (WKPCInstantiatePluginReply): Ditto.
4059         (WKPCGetWindowNPObject): Ditto.
4060         (WKPCGetPluginElementNPObject): Ditto.