Unreviewed, rolling out r227437.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r227437.
4         https://bugs.webkit.org/show_bug.cgi?id=182011
5
6         broke build (Requested by alexchristensen on #webkit).
7
8         Reverted changeset:
9
10         "Remove unused QTKit preference"
11         https://bugs.webkit.org/show_bug.cgi?id=181968
12         https://trac.webkit.org/changeset/227437
13
14 2018-01-23  Alex Christensen  <achristensen@webkit.org>
15
16         Remove unused QTKit preference
17         https://bugs.webkit.org/show_bug.cgi?id=181968
18
19         Reviewed by Alexey Proskuryakov.
20
21         * WebView/WebPreferenceKeysPrivate.h:
22         * WebView/WebPreferences.mm:
23         (+[WebPreferences initialize]):
24         (-[WebPreferences setQTKitEnabled:]): Deleted.
25         (-[WebPreferences isQTKitEnabled]): Deleted.
26         * WebView/WebPreferencesPrivate.h:
27         * WebView/WebView.mm:
28         (-[WebView _preferencesChanged:]):
29
30 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
31
32         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
33         https://bugs.webkit.org/show_bug.cgi?id=181960
34         <rdar://problem/36431678>
35
36         Reviewed by Tim Horton.
37
38         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
39         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
40         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
41
42         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
43         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
44         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
45
46         * WebView/WebView.mm:
47         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
48
49 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
50
51         Turning off custom pasteboard data doesn't actually turn it off in WK2
52         https://bugs.webkit.org/show_bug.cgi?id=181920
53         <rdar://problem/36686429>
54
55         Reviewed by Wenson Hsieh.
56
57         Always disable custom pasteboard data in WebKit1. See r226156 for details.
58
59         * WebView/WebPreferences.mm:
60         (+[WebPreferences initialize]):
61         * WebView/WebView.mm:
62         (-[WebView _preferencesChanged:]):
63
64 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
65
66         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
67         https://bugs.webkit.org/show_bug.cgi?id=181918
68
69         Reviewed by Tim Horton.
70
71         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
72
73         * Configurations/FeatureDefines.xcconfig:
74
75 2018-01-20  Andy Estes  <aestes@apple.com>
76
77         [Apple Pay] Stop eagerly loading PassKit.framework
78         https://bugs.webkit.org/show_bug.cgi?id=181911
79         <rdar://problem/36555369>
80
81         Reviewed by Tim Horton.
82
83         * WebCoreSupport/WebPaymentCoordinatorClient.h:
84         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
85         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
86
87         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
88
89 2018-01-19  Dean Jackson  <dino@apple.com>
90
91         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
92         https://bugs.webkit.org/show_bug.cgi?id=181817
93         <rdar://problem/35274055>
94
95         Reviewed by Simon Fraser.
96
97         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
98
99         * Misc/WebKitVersionChecks.h:
100         * WebView/WebView.mm:
101         (-[WebView _commonInitializationWithFrameName:groupName:]):
102
103 2018-01-19  Alex Christensen  <achristensen@webkit.org>
104
105         Remove unused WebViewPrivate _allowCookies
106         https://bugs.webkit.org/show_bug.cgi?id=181812
107
108         Reviewed by Tim Horton.
109
110         * WebView/WebView.mm:
111         (+[WebView _setAllowCookies:]): Deleted.
112         (+[WebView _allowCookies]): Deleted.
113         * WebView/WebViewPrivate.h:
114
115 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
116
117         Build fix, remove a call to -[NSWindow setOneShot:]
118         https://bugs.webkit.org/show_bug.cgi?id=181809
119
120         Reviewed by Tim Horton.
121
122         * WebView/WebTextCompletionController.mm:
123         (-[WebTextCompletionController _buildUI]):
124
125 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
126
127         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
128
129         * Carbon/HIWebView.mm:
130         (overrideCGContext):
131         (restoreCGContext):
132
133 2018-01-18  Dan Bernstein  <mitz@apple.com>
134
135         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
136         https://bugs.webkit.org/show_bug.cgi?id=181803
137
138         Reviewed by Tim Horton.
139
140         * Configurations/Base.xcconfig: Updated.
141         * Configurations/DebugRelease.xcconfig: Ditto.
142         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
143         * Configurations/Version.xcconfig: Updated.
144         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
145           useful for defining settings that depend on the target macOS version.
146
147 2018-01-17  Youenn Fablet  <youenn@apple.com>
148
149         Put fetch Request.keepalive behind a runtime flag
150         https://bugs.webkit.org/show_bug.cgi?id=181592
151
152         Reviewed by Chris Dumez.
153
154         * WebView/WebPreferenceKeysPrivate.h:
155         * WebView/WebPreferences.mm:
156         (+[WebPreferences initialize]):
157         (-[WebPreferences fetchAPIKeepAliveEnabled]):
158         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
159         * WebView/WebPreferencesPrivate.h:
160         * WebView/WebView.mm:
161         (-[WebView _preferencesChanged:]):
162
163 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
164
165         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
166         https://bugs.webkit.org/show_bug.cgi?id=181637
167         <rdar://problem/36508471>
168
169         Reviewed by Tim Horton.
170
171         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
172
173         * WebCoreSupport/WebEditorClient.h:
174         * WebCoreSupport/WebEditorClient.mm:
175         (WebEditorClient::replacementURLForResource):
176
177 2018-01-11  Keith Miller  <keith_miller@apple.com>
178
179         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
180         https://bugs.webkit.org/show_bug.cgi?id=181573
181
182         Reviewed by Simon Fraser.
183
184         * Configurations/FeatureDefines.xcconfig:
185
186 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
187
188         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
189         https://bugs.webkit.org/show_bug.cgi?id=181497
190
191         Reviewed by Tim Horton.
192
193         See other ChangeLogs for more detail.
194
195         * WebCoreSupport/WebDragClient.h:
196
197 2018-01-11  Tim Horton  <timothy_horton@apple.com>
198
199         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
200         https://bugs.webkit.org/show_bug.cgi?id=181523
201         <rdar://problem/28959131>
202
203         Reviewed by Alex Christensen.
204
205         * WebView/WebImmediateActionController.mm:
206         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
207         Apply the change made in r216652 to WebKit1's immediate action controller.
208
209         Speculative (but successful in WebKit2) fix for non-reproducible crash when
210         the startContainer of the range is in an anonymous node.
211
212 2018-01-11  Youenn Fablet  <youenn@apple.com>
213
214         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
215         https://bugs.webkit.org/show_bug.cgi?id=181480
216
217         Reviewed by Eric Carlson.
218
219         * WebView/WebPreferences.mm:
220         (+[WebPreferences initialize]):
221
222 2018-01-08  David Kilzer  <ddkilzer@apple.com>
223
224         Fix check-webkit-style issues with WebNSDataExtras.mm
225         <https://webkit.org/b/181369>
226
227         Reviewed by Alex Christensen.
228
229         * Misc/WebNSDataExtras.mm:
230         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
231         (-[NSData _webkit_guessedMIMETypeForXML]):
232         (-[NSData _webkit_guessedMIMEType]):
233         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
234         (_findEOL):
235         (-[NSData _webkit_parseRFC822HeaderFields]):
236         (-[NSData _web_locationAfterFirstBlankLine]):
237         - Fix all the check-webkit-style warnings.
238
239 2018-01-08  David Kilzer  <ddkilzer@apple.com>
240
241         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
242         <https://webkit.org/b/181256>
243         <rdar://problem/36281730>
244
245         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
246         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
247         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
248           to avoid warnings from casting CFStringRef to NPNSString*.
249           Note that CFMutableStringRef is the same as CFStringRef
250           without the const modifier, hence its use in the const_cast<>
251           above.
252
253 2018-01-08  David Kilzer  <ddkilzer@apple.com>
254
255         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
256         <https://webkit.org/b/181256>
257         <rdar://problem/36281730>
258
259         * Carbon/HIWebView.mm:
260         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
261         checked_cf_cast<CFRunLoopRef>() to fix warning.
262
263 2018-01-07  David Kilzer  <ddkilzer@apple.com>
264
265         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
266         <https://webkit.org/b/181256>
267         <rdar://problem/36281730>
268
269         Reviewed by Darin Adler.
270
271         * Carbon/CarbonUtils.m:
272         (PoolCleaner):
273         - Use #pragmas to ignore -Wcast-qual warnings when using a
274           C-style cast from CFTypeRef to CFRunloopRef.
275         * Carbon/CarbonWindowFrame.m:
276         (-[CarbonWindowFrame title]):
277         - Use #pragmas to ignore -Wcast-qual warnings when using a
278           C-style cast from CFStringRef to NSString *.
279         * Carbon/HIViewAdapter.m:
280         (+[HIViewAdapter getHIViewForNSView:]):
281         - Use #pragmas to ignore -Wcast-qual warnings when using a
282           C-style cast from CFTypeRef to HIViewRef.
283         * Configurations/Base.xcconfig:
284         (WARNING_CFLAGS): Add -Wcast-qual.
285         * Misc/WebElementDictionary.mm:
286         (-[WebElementDictionary objectForKey:]):
287         - Use static_cast<SEL>(const_cast<void*>()) to fix
288           warning.
289         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
290         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
291         (-[NSData _webkit_guessedMIMETypeForXML]):
292         (-[NSData _webkit_guessedMIMEType]):
293         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
294         (_findEOL):
295         (-[NSData _webkit_parseRFC822HeaderFields]):
296         (-[NSData _web_startsWithBlankLine]):
297         (-[NSData _web_locationAfterFirstBlankLine]):
298         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
299           type to Objective-C++.  This fixes the warnings about
300           discarding the `const` modifier when casing from CFStringRef
301           to NSString * because in older clang versions, -Wcast-qual was
302           completely broken when compiling C++ and Objective-C++ source
303           files.  In newer clang versions, discarding the `const`
304           modifier for toll-free bridged types is ignored when compiling
305           Objective-C++ source.
306         - Update copyright and license header.
307         - Use reinterpret_cast<> and static_cast<> to fix warnings
308           unrelated to (NSString *) C-style casts.
309         - Replace use of MIN() macro with std::min<> template functions.
310         - Fix location of `*` for local variables modified above.
311         * Plugins/Hosted/NetscapePluginHostManager.mm:
312         (WebKit::NetscapePluginHostManager::spawnPluginHost):
313         (WebKit::NetscapePluginHostManager::initializeVendorPort):
314         (WebKit::NetscapePluginHostManager::instantiatePlugin):
315         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
316           warnings.
317         * Plugins/Hosted/NetscapePluginHostProxy.mm:
318         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
319         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
320           to fix warning.
321         * Plugins/Hosted/ProxyInstance.mm:
322         (WebKit::ProxyInstance::invoke):
323         - Use static_cast<char*>(const_cast<void*>()) to fix
324           warning when using -[NSData bytes].
325         (WebKit::ProxyInstance::fieldValue const):
326         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
327           to fix warning when using CFDataGetBytePtr().
328         * Plugins/Hosted/WebTextInputWindowController.m:
329         (-[WebTextInputPanel _interpretKeyEvent:string:]):
330         - Use #pragma to ignore -Wcast-qual warning since there
331           is not a good way to avoid this warning in Objective-C.
332         * Plugins/WebNetscapePluginStream.mm:
333         (WebNetscapePluginStream::deliverData):
334         - Use const_cast<void*>() to fix warning when using
335           -[NSData bytes].
336         * Plugins/WebNetscapePluginView.mm:
337         (-[WebNetscapePluginView _createPlugin]):
338         - Change C-style cast to const_cast<char*>() to fix
339           warning.
340         * WebCoreSupport/WebChromeClient.mm:
341         (WebChromeClient::wrapCryptoKey const):
342         (WebChromeClient::unwrapCryptoKey const):
343         - Change C-style cast to
344           static_cast<uint8_t*>(const_cast<void*>() to fix
345           warning.
346         * WebView/WebPDFView.mm:
347         (_applicationInfoForMIMEType):
348         - Change local variable type from 'NSURL *' to
349           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
350           when calling -[NSURL path].
351
352 2018-01-05  Dan Bernstein  <mitz@apple.com>
353
354         Fixed the build following AppKit API deprecations in a recent SDKs
355
356         * WebView/WebFullScreenController.mm:
357         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
358         (-[WebFullScreenController exitFullScreen]): Ditto.
359         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
360         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
361         * WebView/WebHTMLView.mm:
362         (-[WebHTMLView drawRect:]): Ditto.
363         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
364         (-[WebHTMLView knowsPageRange:]): Ditto.
365         * WebView/WebView.mm:
366         (LayerFlushController::flushLayers): Ditto.
367
368 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
369
370         [Attachment Support] Create attachment elements when dropping files on iOS
371         https://bugs.webkit.org/show_bug.cgi?id=181192
372         <rdar://problem/36280945>
373
374         Reviewed by Tim Horton.
375
376         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
377
378         * WebCoreSupport/WebPlatformStrategies.h:
379         * WebCoreSupport/WebPlatformStrategies.mm:
380         (WebPlatformStrategies::informationForItemAtIndex):
381         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
382
383 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
384
385         [Attachment Support] Add plumbing for starting a drag with promised blob data
386         https://bugs.webkit.org/show_bug.cgi?id=181201
387
388         Reviewed by Tim Horton.
389
390         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
391
392         * WebCoreSupport/WebDragClient.h:
393
394 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
395
396         Add a WebAuthentication runtime feature flag
397         https://bugs.webkit.org/show_bug.cgi?id=181220
398         <rdar://problem/36055305>
399
400         Reviewed by Brent Fulgham.
401
402         Renames the CredentialManagement runtime feature flag into WebAuthentication.
403
404         * WebView/WebPreferenceKeysPrivate.h:
405         * WebView/WebPreferences.mm:
406         (+[WebPreferences initialize]):
407         (-[WebPreferences webAuthenticationEnabled]):
408         (-[WebPreferences setWebAuthenticationEnabled:]):
409         (-[WebPreferences credentialManagementEnabled]): Deleted.
410         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
411         * WebView/WebPreferencesPrivate.h:
412         * WebView/WebView.mm:
413         (-[WebView _preferencesChanged:]):
414
415 2017-12-22  Jeff Miller  <jeffm@apple.com>
416
417         Update user-visible copyright strings to include 2018
418         https://bugs.webkit.org/show_bug.cgi?id=181141
419
420         Reviewed by Dan Bernstein.
421
422         * Info.plist:
423
424 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
425
426         [Attachment Support] Remove current macOS support for dragging file-backed attachments
427         https://bugs.webkit.org/show_bug.cgi?id=181188
428
429         Reviewed by Dan Bernstein.
430
431         See WebCore/ChangeLog for more detail.
432
433         * WebCoreSupport/WebDragClient.h:
434         * WebCoreSupport/WebDragClient.mm:
435         (WebDragClient::declareAndWriteAttachment): Deleted.
436         * WebView/WebHTMLView.mm:
437         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
438
439 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
440
441         Unreviewed, continue to fix build failures due to AppKit API deprecation
442
443         Wraps more code in -Wdeprecated-declarations.
444
445         * Carbon/HIWebView.mm:
446         (overrideCGContext):
447
448 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
449
450         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
451
452         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
453
454         * Carbon/CarbonWindowAdapter.mm:
455         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
456         * Plugins/WebNetscapePluginView.mm:
457         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
458         (-[WebNetscapePluginView sendDrawRectEvent:]):
459         (-[WebNetscapePluginView drawRect:]):
460
461 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
462
463         Fix build failures due to using deprecated AppKit symbols
464         https://bugs.webkit.org/show_bug.cgi?id=181110
465         <rdar://problem/36162865>
466
467         Reviewed by Dan Bernstein and Tim Horton.
468
469         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
470
471         * Misc/WebKitNSStringExtras.mm:
472         (-[NSString _web_drawAtPoint:font:textColor:]):
473         * Misc/WebNSPasteboardExtras.h:
474         * Misc/WebNSPasteboardExtras.mm:
475         (+[NSPasteboard _web_writableTypesForURL]):
476         (_createWritableTypesForImageWithoutArchive):
477         (_createWritableTypesForImageWithArchive):
478         (+[NSPasteboard _web_dragTypesForURL]):
479         (-[NSPasteboard _web_bestURL]):
480         (-[NSPasteboard _web_writeURL:andTitle:types:]):
481         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
482         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
483         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
484         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
485         * Panels/WebAuthenticationPanel.m:
486         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
487         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
488         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
489         (-[WebHostedNetscapePluginView drawRect:]):
490         * WebInspector/WebNodeHighlightView.mm:
491         (-[WebNodeHighlightView drawRect:]):
492         * WebView/WebFrame.mm:
493         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
494         (-[WebFrame _drawRect:contentsOnly:]):
495         * WebView/WebHTMLView.mm:
496         (kit):
497         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
498         (-[WebHTMLView _plainTextFromPasteboard:]):
499         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
500         (+[WebHTMLView _insertablePasteboardTypes]):
501         (+[WebHTMLView _selectionPasteboardTypes]):
502         (-[WebHTMLView pasteboard:provideDataForType:]):
503         (-[WebHTMLView _writeSelectionToPasteboard:]):
504         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
505         (-[WebHTMLView validRequestorForSendType:returnType:]):
506         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
507         (createMenuItem):
508         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
509         (-[WebHTMLView _colorAsString:]):
510         (-[WebHTMLView copyFont:]):
511         * WebView/WebPDFView.mm:
512         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
513         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
514         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
515         (-[WebPDFView pasteboardTypesForSelection]):
516         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
517         * WebView/WebView.h:
518         * WebView/WebView.mm:
519         (-[WebView performDragOperation:]):
520         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
521         (-[WebView _searchWithGoogleFromMenu:]):
522
523 2017-12-21  Youenn Fablet  <youenn@apple.com>
524
525         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
526         https://bugs.webkit.org/show_bug.cgi?id=181000
527
528         Reviewed by Chris Dumez.
529
530         * Misc/WebCache.mm:
531         (+[WebCache addImageToCache:forURL:forFrame:]):
532
533 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
534
535         Update FULLSCREEN_API feature defines.
536         https://bugs.webkit.org/show_bug.cgi?id=181015
537
538         Reviewed by Tim Horton.
539
540         Change enabled iphone sdk for FULLSCREEN_API.
541
542         * Configurations/FeatureDefines.xcconfig:
543
544 2017-12-21  Jer Noble  <jer.noble@apple.com>
545
546         Add initial DOM support for Media Capabilities
547         https://bugs.webkit.org/show_bug.cgi?id=181064
548
549         Reviewed by Eric Carlson.
550
551         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
552
553         * WebView/WebPreferenceKeysPrivate.h:
554         * WebView/WebPreferences.mm:
555         (+[WebPreferences initialize]):
556         (-[WebPreferences mediaCapabilitiesEnabled]):
557         (-[WebPreferences setMediaCapabilitiesEnabled:]):
558         * WebView/WebPreferencesPrivate.h:
559         * WebView/WebView.mm:
560         (-[WebView _preferencesChanged:]):
561
562 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
563
564         Enable picture-in-picture from inline element on suspend.
565         https://bugs.webkit.org/show_bug.cgi?id=180942
566         rdar://problem/34745234
567
568         Reviewed by Jer Noble.
569
570         Update signature of enterVideoFullscreenForVideoElement().
571
572         * WebCoreSupport/WebChromeClient.h:
573         * WebCoreSupport/WebChromeClient.mm:
574         (WebChromeClient::enterVideoFullscreenForVideoElement):
575
576 2017-12-20  Daniel Bates  <dabates@apple.com>
577
578         Remove Alternative Presentation Button
579         https://bugs.webkit.org/show_bug.cgi?id=180500
580         <rdar://problem/35891047>
581
582         Reviewed by Simon Fraser.
583
584         We no longer need the alternative presentation button.
585
586         * Configurations/FeatureDefines.xcconfig:
587
588 2017-12-19  Jer Noble  <jer.noble@apple.com>
589
590         Playing media elements which call "pause(); play()" will have the play promise rejected.
591         https://bugs.webkit.org/show_bug.cgi?id=180781
592         <rdar://problem/33191377>
593
594         Reviewed by Eric Carlson.
595
596         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
597
598         * WebView/WebView.mm:
599         (shouldRequireUserGestureToLoadVideo):
600
601 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
602
603         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
604         https://bugs.webkit.org/show_bug.cgi?id=180977
605
606         Reviewed by Tim Horton.
607
608         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
609         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
610         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
611
612         * WebCoreSupport/WebEditorClient.mm:
613         (attributesForAttributedStringConversion):
614         * WebView/WebHTMLView.mm:
615         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
616
617 2017-12-18  David Kilzer  <ddkilzer@apple.com>
618
619         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
620
621         Attempt to fix the following warnings:
622
623             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
624
625         For the following instance variables:
626
627             _borderView
628             _contentView
629             _frame
630             _wFlags
631
632         * Carbon/CarbonWindowAdapter.mm:
633         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
634         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
635         (-[CarbonWindowAdapter _termWindowIfOwner]):
636         (-[CarbonWindowAdapter _windowMovedToRect:]):
637         (-[CarbonWindowAdapter setContentView:]):
638         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
639         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
640
641 2017-12-16  Dan Bernstein  <mitz@apple.com>
642
643         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
644         https://bugs.webkit.org/show_bug.cgi?id=180613
645         <rdar://problem/35946124>
646
647         Reviewed by Geoff Garen.
648
649         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
650           clients.
651         * WebView/WebDynamicScrollBarsView.h: Ditto.
652         * WebView/WebDynamicScrollBarsView.mm: Ditto.
653
654 2017-12-14  David Kilzer  <ddkilzer@apple.com>
655
656         Enable -Wstrict-prototypes for WebKit
657         <https://webkit.org/b/180757>
658         <rdar://problem/36024132>
659
660         Rubber-stamped by Joseph Pecoraro.
661
662         * Configurations/Base.xcconfig:
663         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
664
665 2017-12-14  John Wilander  <wilander@apple.com>
666
667         Storage Access API: Implement frame-specific access in the document.cookie layer
668         https://bugs.webkit.org/show_bug.cgi?id=180682
669         <rdar://problem/35982257>
670
671         Reviewed by Alex Christensen.
672
673         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
674         CookiesStrategy::cookieRequestHeaderFieldValue(), and
675         CookiesStrategy::getRawCookies() now take optional parameters for
676         frameID and pageID to allow frame-specific scoping of cookies.
677
678         This change makes the return values of FrameLoaderClient::frameID()
679         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
680         WebCore can call those getters and get the right return values in
681         WebKit and std:nullopt in WebKitLegacy.
682
683         * WebCoreSupport/WebFrameLoaderClient.h:
684         * WebCoreSupport/WebFrameLoaderClient.mm:
685         (WebFrameLoaderClient::pageID const):
686         (WebFrameLoaderClient::frameID const):
687         * WebCoreSupport/WebPlatformStrategies.h:
688         * WebCoreSupport/WebPlatformStrategies.mm:
689         (WebPlatformStrategies::cookiesForDOM):
690         (WebPlatformStrategies::setCookiesFromDOM):
691         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
692         (WebPlatformStrategies::getRawCookies):
693
694 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
695
696         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
697         https://bugs.webkit.org/show_bug.cgi?id=180689
698
699         Reviewed by Tim Horton.
700
701         Use sRGBColorSpaceRef() from WebCore.
702
703         * WebView/WebHTMLView.mm:
704         (imageFromRect):
705
706 2017-12-11  Tim Horton  <timothy_horton@apple.com>
707
708         Stop using deprecated target conditional for simulator builds
709         https://bugs.webkit.org/show_bug.cgi?id=180662
710         <rdar://problem/35136156>
711
712         Reviewed by Simon Fraser.
713
714         * postprocess-headers.sh:
715
716 2017-12-11  David Quesada  <david_quesada@apple.com>
717
718         Turn on ENABLE_APPLICATION_MANIFEST
719         https://bugs.webkit.org/show_bug.cgi?id=180562
720         rdar://problem/35924737
721
722         Reviewed by Geoffrey Garen.
723
724         * Configurations/FeatureDefines.xcconfig:
725
726 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
727
728         Remove pthread_once in favor of dispatch_once
729         https://bugs.webkit.org/show_bug.cgi?id=180591
730
731         Reviewed by Saam Barati.
732
733         * Misc/WebKitErrors.m:
734         (+[NSError _registerWebKitErrors]):
735         (registerErrors): Deleted.
736         * Storage/WebStorageManager.mm:
737         (+[WebStorageManager _storageDirectoryPath]):
738         (initializeLocalStoragePath): Deleted.
739
740 2017-12-07  Darin Adler  <darin@apple.com>
741
742         Remove some unused code from WebKitLegacy
743         https://bugs.webkit.org/show_bug.cgi?id=180567
744
745         Reviewed by Anders Carlsson.
746
747         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
748         macOS (back a few versions) and iOS and removed unused
749         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
750         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
751         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
752         _webkit_stringByCollapsingNonPrintingCharacters,
753         _webkit_stringByCollapsingWhitespaceCharacters,
754         _web_stringWithData:textEncodingName:, and
755         _webkit_localStorageDirectoryWithBundleIdentifier:.
756
757         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
758         this source file.
759         (canUseFastRenderer): Made this faster by not calling u_charDirection for
760         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
761         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
762         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
763         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
764         handle font smoothing options.
765         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
766         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
767         from header and made it a little clearer.
768         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
769         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
770         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
771         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
772         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
773         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
774         implementation a bit and used whole words instead of abbreviations.
775         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
776
777         * Misc/WebNSFileManagerExtras.mm:
778         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
779         filenameByFixingIllegalCharacters function from WebCore directly instead of
780         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
781
782         * Plugins/WebBaseNetscapePluginView.mm:
783         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
784         string replacements instead of _web_stringByStrippingReturnCharacters
785         and to use NSString methods instead of CFString functions.
786
787 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
788
789         Ignore deprecation warnings.
790
791         * WebView/WebHTMLView.mm:
792         (-[NSWindow _web_borderView]):
793         (-[WebHTMLView _setAsideSubviews]):
794         * WebView/WebView.mm:
795         (-[WebView encodeWithCoder:]):
796
797 2017-12-02  Darin Adler  <darin@apple.com>
798
799         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
800         https://bugs.webkit.org/show_bug.cgi?id=180009
801
802         Reviewed by Alex Christensen.
803
804         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
805
806         * Plugins/WebBaseNetscapePluginView.mm:
807         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
808         of strcasecmp.
809
810         * WebView/WebPreferences.mm:
811         (contains): Ditto. Also made this a template so it's easier to call on an array.
812         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
813
814 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
815
816         Limit user agent versioning to an upper bound
817         https://bugs.webkit.org/show_bug.cgi?id=180365
818         <rdar://problem/34550617>
819
820         Reviewed by Joseph Pecoraro.
821
822         * WebView/WebView.mm:
823         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
824         creating the User Agent string.
825         (webKitBundleVersionString): Deleted.
826
827 2017-12-05  Andy Estes  <aestes@apple.com>
828
829         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
830         https://bugs.webkit.org/show_bug.cgi?id=180457
831         <rdar://problem/35143007>
832
833         Reviewed by Tim Horton.
834
835         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
836         check for this macro during post-processing.
837
838         * postprocess-headers.sh:
839
840 2017-12-04  David Quesada  <david_quesada@apple.com>
841
842         Add a class for parsing application manifests
843         https://bugs.webkit.org/show_bug.cgi?id=177973
844         rdar://problem/34747949
845
846         Reviewed by Geoffrey Garen.
847
848         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
849
850 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
851
852         Make LegacyCustomProtocolManager optional for network process
853         https://bugs.webkit.org/show_bug.cgi?id=176230
854
855         Reviewed by Alex Christensen.
856
857         * Configurations/FeatureDefines.xcconfig:
858
859 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
860
861         Fix some NSOperationQueue leaks
862         https://bugs.webkit.org/show_bug.cgi?id=180221
863
864         Reviewed by Wenson Hsieh.
865
866         * WebView/WebView.mm:
867         (-[WebView performDragOperation:]):
868
869 2017-11-30  Darin Adler  <darin@apple.com>
870
871         [Mac] remove unneeded RetainPtr use introduced in r225142
872         https://bugs.webkit.org/show_bug.cgi?id=180202
873
874         Reviewed by Tim Horton.
875
876         * WebView/WebImmediateActionController.mm:
877         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
878         RetainPtr.
879
880 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
881
882         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
883         https://bugs.webkit.org/show_bug.cgi?id=175595
884
885         Reviewed by Darin Adler.
886
887         * WebView/WebPreferences.mm:
888
889 2017-11-27  Tim Horton  <timothy_horton@apple.com>
890
891         One too many zeroes in macOS version number in FeatureDefines
892         https://bugs.webkit.org/show_bug.cgi?id=180011
893
894         Reviewed by Dan Bernstein.
895
896         * Configurations/FeatureDefines.xcconfig:
897
898 2017-11-23  Darin Adler  <darin@apple.com>
899
900         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
901         https://bugs.webkit.org/show_bug.cgi?id=179981
902
903         Reviewed by Sam Weinig.
904
905         * WebView/WebImmediateActionController.mm:
906         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
907         * WebView/WebView.mm:
908         (coreOptions): Use |= instead of | to build up FindOptions.
909
910 2017-11-23  Sam Weinig  <sam@webkit.org>
911
912         Remove unneeded ScriptController::processingUserGesture() forwarding functions
913         https://bugs.webkit.org/show_bug.cgi?id=179954
914
915         Reviewed by Darin Adler.
916
917         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
918         with direct calls to the corresponding UserGestureIndicator functions.
919
920         * Plugins/WebPluginController.mm:
921         (-[WebPluginController processingUserGesture]):
922         * WebView/WebView.mm:
923         (-[WebView _isProcessingUserGesture]):
924
925 2017-11-23  Darin Adler  <darin@apple.com>
926
927         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
928         https://bugs.webkit.org/show_bug.cgi?id=179907
929
930         Reviewed by Sam Weinig.
931
932         * History/BinaryPropertyList.cpp:
933         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
934         (BinaryPropertyListSerializer::appendStringObject): Ditto.
935         * WebView/WebHTMLRepresentation.mm:
936         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
937         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
938
939 2017-11-22  Ali Juma  <ajuma@chromium.org>
940
941         Implement VisualViewport API attributes
942         https://bugs.webkit.org/show_bug.cgi?id=179385
943
944         Reviewed by Frédéric Wang.
945
946         Add a VisualViewportAPI preference.
947
948         * WebView/WebPreferenceKeysPrivate.h:
949         * WebView/WebPreferences.mm:
950         (+[WebPreferences initialize]):
951         (-[WebPreferences visualViewportAPIEnabled]):
952         (-[WebPreferences setVisualViewportAPIEnabled:]):
953         * WebView/WebPreferencesPrivate.h:
954         * WebView/WebView.mm:
955         (-[WebView _preferencesChanged:]):
956
957 2017-11-22  Christopher Reid  <chris.reid@sony.com>
958
959         WebCoreObjCExtras.h is being included in too many places
960         https://bugs.webkit.org/show_bug.cgi?id=179931
961
962         Reviewed by Darin Adler.
963
964         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
965         * Plugins/WebBaseNetscapePluginView.mm:
966         * Plugins/WebBasePluginPackage.mm:
967         * Plugins/WebNetscapePluginStream.mm:
968         * Plugins/WebNetscapePluginView.mm:
969         * WebView/WebTextIterator.mm:
970         * WebView/WebViewData.mm:
971
972 2017-11-22  Commit Queue  <commit-queue@webkit.org>
973
974         Unreviewed, rolling out r225093.
975         https://bugs.webkit.org/show_bug.cgi?id=179938
976
977         Compilation failed on WinCairo 64-bit Release (Requested by
978         fredw on #webkit).
979
980         Reverted changeset:
981
982         "Implement VisualViewport API attributes"
983         https://bugs.webkit.org/show_bug.cgi?id=179385
984         https://trac.webkit.org/changeset/225093
985
986 2017-11-21  Ali Juma  <ajuma@chromium.org>
987
988         Implement VisualViewport API attributes
989         https://bugs.webkit.org/show_bug.cgi?id=179385
990
991         Reviewed by Frédéric Wang.
992
993         Add a VisualViewportAPI preference.
994
995         * WebView/WebPreferenceKeysPrivate.h:
996         * WebView/WebPreferences.mm:
997         (+[WebPreferences initialize]):
998         (-[WebPreferences visualViewportAPIEnabled]):
999         (-[WebPreferences setVisualViewportAPIEnabled:]):
1000         * WebView/WebPreferencesPrivate.h:
1001         * WebView/WebView.mm:
1002         (-[WebView _preferencesChanged:]):
1003
1004 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1005
1006         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1007         https://bugs.webkit.org/show_bug.cgi?id=179504
1008
1009         Reviewed by Darin Adler.
1010
1011         * Misc/WebKitNSStringExtras.mm:
1012         * Plugins/Hosted/NetscapePluginHostManager.mm:
1013         * Plugins/WebBasePluginPackage.mm:
1014
1015 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1016
1017         Remove unused TOUCH_ICON_LOADING feature flag
1018         https://bugs.webkit.org/show_bug.cgi?id=179873
1019
1020         Reviewed by Simon Fraser.
1021
1022         * Configurations/FeatureDefines.xcconfig:
1023
1024 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1025
1026         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1027         https://bugs.webkit.org/show_bug.cgi?id=179872
1028
1029         Reviewed by Darin Adler.
1030
1031         * Configurations/FeatureDefines.xcconfig:
1032
1033 2017-11-16  Daniel Bates  <dabates@apple.com>
1034
1035         Add feature define for alternative presentation button element
1036         https://bugs.webkit.org/show_bug.cgi?id=179692
1037         Part of <rdar://problem/34917108>
1038
1039         Reviewed by Andy Estes.
1040
1041         Only enabled on Cocoa platforms by default.
1042
1043         * Configurations/FeatureDefines.xcconfig:
1044
1045 2017-11-14  Nan Wang  <n_wang@apple.com>
1046
1047         AX: AOM: Implement AccessibleNode class and support label and role attributes
1048         https://bugs.webkit.org/show_bug.cgi?id=179494
1049
1050         Reviewed by Ryosuke Niwa.
1051
1052         * WebView/WebPreferenceKeysPrivate.h:
1053         * WebView/WebPreferences.mm:
1054         (+[WebPreferences initialize]):
1055         (-[WebPreferences accessibilityObjectModelEnabled]):
1056         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1057         * WebView/WebPreferencesPrivate.h:
1058         * WebView/WebView.mm:
1059         (-[WebView _preferencesChanged:]):
1060
1061 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1062
1063         Remove Cocoa CFURLConnection loading code
1064         https://bugs.webkit.org/show_bug.cgi?id=179688
1065
1066         Reviewed by Antti Koivisto.
1067
1068         * Misc/WebDownload.mm:
1069         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1070         * Misc/WebDownloadInternal.h:
1071         * Plugins/WebBaseNetscapePluginView.mm:
1072         * WebCoreSupport/WebFrameLoaderClient.mm:
1073         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1074         * WebView/WebView.mm:
1075         (-[WebView scheduleInRunLoop:forMode:]):
1076         (-[WebView unscheduleFromRunLoop:forMode:]):
1077
1078 2017-11-14  Daniel Bates  <dabates@apple.com>
1079
1080         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1081         for feature defines
1082
1083         Following r195498 and r201917 the Visual Studio property files for feature defines have
1084         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1085         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1086         files.
1087
1088         * Configurations/FeatureDefines.xcconfig:
1089
1090 2017-11-14  Jer Noble  <jer.noble@apple.com>
1091
1092         Enable Modern EME tests in DumpRenderTree
1093         https://bugs.webkit.org/show_bug.cgi?id=179544
1094
1095         Reviewed by Alex Christensen.
1096
1097         Add a WebPreferences property to enable the (modern) EME API.
1098
1099         * WebView/WebPreferenceKeysPrivate.h:
1100         * WebView/WebPreferences.mm:
1101         (+[WebPreferences initialize]):
1102         (-[WebPreferences encryptedMediaAPIEnabled]):
1103         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1104         * WebView/WebPreferencesPrivate.h:
1105         * WebView/WebView.mm:
1106         (-[WebView _preferencesChanged:]):
1107
1108 2017-11-14  Antti Koivisto  <antti@apple.com>
1109
1110         Enable display:contents by default
1111         https://bugs.webkit.org/show_bug.cgi?id=179655
1112
1113         Reviewed by Sam Weinig.
1114
1115         * WebView/WebPreferences.mm:
1116         (+[WebPreferences initialize]):
1117
1118 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1119
1120         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1121         https://bugs.webkit.org/show_bug.cgi?id=178751
1122
1123         Reviewed by Brady Eidson.
1124
1125         * WebCoreSupport/WebFrameNetworkingContext.mm:
1126         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1127
1128 2017-11-08  Keith Miller  <keith_miller@apple.com>
1129
1130         Async iteration should only fetch the next method once and add feature flag
1131         https://bugs.webkit.org/show_bug.cgi?id=179451
1132
1133         Reviewed by Geoffrey Garen.
1134
1135         Add feature flag for Async iteration.
1136
1137         * Configurations/FeatureDefines.xcconfig:
1138
1139 2017-11-13  Mark Lam  <mark.lam@apple.com>
1140
1141         Add more overflow check book-keeping for MarkedArgumentBuffer.
1142         https://bugs.webkit.org/show_bug.cgi?id=179634
1143         <rdar://problem/35492517>
1144
1145         Reviewed by Saam Barati.
1146
1147         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1148         (WebKit::NetscapePluginInstanceProxy::invoke):
1149         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1150         (WebKit::NetscapePluginInstanceProxy::construct):
1151
1152 2017-11-12  Darin Adler  <darin@apple.com>
1153
1154         More is<> and downcast<>, less static_cast<>
1155         https://bugs.webkit.org/show_bug.cgi?id=179600
1156
1157         Reviewed by Chris Dumez.
1158
1159         * DOM/DOM.mm:
1160         (kit): Use is/downcast.
1161         * WebCoreSupport/WebEditorClient.mm:
1162         (WebEditorClient::handleKeyboardEvent): Ditto.
1163         (WebEditorClient::handleInputMethodKeydown): Ditto.
1164         * WebView/WebHTMLView.mm:
1165         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1166
1167 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1168
1169         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1170         https://bugs.webkit.org/show_bug.cgi?id=179397
1171
1172         Reviewed by Wenson Hsieh.
1173
1174         * DOM/DOMHTMLInputElement.mm:
1175         (-[DOMHTMLInputElement insertTextSuggestion:]):
1176
1177 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1178
1179         HTMLMediaElement should not use element fullscreen on iOS
1180         https://bugs.webkit.org/show_bug.cgi?id=179418
1181         rdar://problem/35409277
1182
1183         Reviewed by Eric Carlson.
1184
1185         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1186
1187         * Configurations/FeatureDefines.xcconfig:
1188
1189 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1190
1191         Make ResourceLoader::willSendRequestInternal asynchronous
1192         https://bugs.webkit.org/show_bug.cgi?id=179251
1193
1194         Reviewed by Andy Estes.
1195
1196         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1197         (WebKit::HostedNetscapePluginStream::start):
1198         * Plugins/WebNetscapePluginStream.mm:
1199         (WebNetscapePluginStream::start):
1200
1201 2017-11-01  Darin Adler  <darin@apple.com>
1202
1203         Simplify event dispatch code and make it a bit more consistent
1204         https://bugs.webkit.org/show_bug.cgi?id=178991
1205
1206         Reviewed by Chris Dumez.
1207
1208         * DOM/DOMEvent.mm:
1209         (-[DOMEvent srcElement]): Call target instead of srcElement.
1210
1211 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1212
1213         [Touch Bar Web API] Add support for menuitem tag
1214         https://bugs.webkit.org/show_bug.cgi?id=179020
1215
1216         Reviewed by Ryosuke Niwa.
1217
1218         Adds in properties and methods that allow the menuitem runtime feature
1219         to be enabled or disabled.
1220
1221         * WebView/WebPreferenceKeysPrivate.h:
1222         * WebView/WebPreferences.mm:
1223         (-[WebPreferences menuItemElementEnabled]):
1224         (-[WebPreferences setMenuItemElementEnabled:]):
1225         * WebView/WebPreferencesPrivate.h:
1226         * WebView/WebView.mm:
1227         (-[WebView _preferencesChanged:]):
1228
1229 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1230
1231         Use CompletionHandlers for redirects
1232         https://bugs.webkit.org/show_bug.cgi?id=179163
1233
1234         Reviewed by Tim Horton.
1235
1236         * Plugins/Hosted/HostedNetscapePluginStream.h:
1237         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1238         (WebKit::HostedNetscapePluginStream::willSendRequest):
1239         * Plugins/WebNetscapePluginStream.h:
1240         * Plugins/WebNetscapePluginStream.mm:
1241         (WebNetscapePluginStream::willSendRequest):
1242
1243 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1244
1245         Add a FileSystem namespace to FileSystem.cpp
1246         https://bugs.webkit.org/show_bug.cgi?id=179063
1247
1248         Reviewed by Darin Adler.
1249
1250         * Misc/WebNSFileManagerExtras.mm:
1251         * Storage/WebDatabaseProvider.mm:
1252
1253 2017-11-02  Frederic Wang  <fwang@igalia.com>
1254
1255         Add references to bug 179167 in FIXME comments
1256         https://bugs.webkit.org/show_bug.cgi?id=179168
1257
1258         Reviewed by Daniel Bates.
1259
1260         * Configurations/FeatureDefines.xcconfig:
1261
1262 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1263
1264         Implement WKFullscreenWindowController for iOS.
1265         https://bugs.webkit.org/show_bug.cgi?id=178924
1266         rdar://problem/34697120
1267
1268         Reviewed by Simon Fraser.
1269
1270         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1271
1272         * Configurations/FeatureDefines.xcconfig:
1273         * WebView/WebView.mm:
1274         (-[WebView fullScreenPlaceholderView]):
1275
1276 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1277
1278         Clean up some drag and drop feature flags
1279         https://bugs.webkit.org/show_bug.cgi?id=179082
1280
1281         Reviewed by Simon Fraser.
1282
1283         * Configurations/FeatureDefines.xcconfig:
1284
1285 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1286
1287         Make it possible to test rubber-banding in overflow scroll
1288         https://bugs.webkit.org/show_bug.cgi?id=179078
1289
1290         Reviewed by Sam Weinig.
1291
1292         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1293         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1294
1295         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1296         functions, since most callers want clamped.
1297
1298         * DOM/DOMHTML.mm:
1299         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1300
1301 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1302
1303         Fix up some content filtering feature flags
1304         https://bugs.webkit.org/show_bug.cgi?id=179079
1305
1306         Reviewed by Simon Fraser.
1307
1308         * Configurations/FeatureDefines.xcconfig:
1309
1310 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1311
1312         [FrameView::layout cleanup] Move core layout logic to a separate class.
1313         https://bugs.webkit.org/show_bug.cgi?id=178771
1314         <rdar://problem/35166542>
1315
1316         Reviewed by Simon Fraser.
1317
1318         Move layout code out from FrameView to LayoutContext.
1319
1320         * WebView/WebClipView.mm:
1321         (-[WebClipView _immediateScrollToPoint:]):
1322         * WebView/WebFrame.mm:
1323         (-[WebFrame layoutCount]):
1324
1325 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1326
1327         Fix issues with WebView subframe painting
1328         https://bugs.webkit.org/show_bug.cgi?id=178842
1329         rdar://problem/34072253
1330
1331         Reviewed by Daniel Bates.
1332         
1333         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1334         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1335         High Sierra, so match the new signature.
1336
1337         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1338
1339         * WebView/WebHTMLView.mm:
1340         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1341         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1342
1343 2017-10-25  Youenn Fablet  <youenn@apple.com>
1344
1345         Enable ServiceWorker to fetch resources
1346         https://bugs.webkit.org/show_bug.cgi?id=178673
1347
1348         Reviewed by Brady Eidson.
1349
1350         * WebCoreSupport/WebFrameLoaderClient.mm:
1351         (WebFrameLoaderClient::pageID const):
1352         (WebFrameLoaderClient::frameID const):
1353         (WebFrameLoaderClient::sessionID const):
1354
1355         Added implementation to the new getters.
1356         They are noop in the context of WK1.
1357
1358 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1359
1360         Web Inspector: Enable WebKit logging configuration and display
1361         https://bugs.webkit.org/show_bug.cgi?id=177027
1362         <rdar://problem/33964767>
1363
1364         Reviewed by Joseph Pecoraro.
1365
1366         * WebCoreSupport/WebChromeClient.mm:
1367         (stringForMessageSource): Deal with Media and WebRTC message sources.
1368
1369 2017-10-20  Antoine Quint  <graouts@apple.com>
1370
1371         [Web Animations] Provide basic timeline and animation interfaces
1372         https://bugs.webkit.org/show_bug.cgi?id=178526
1373
1374         Reviewed by Dean Jackson.
1375
1376         Remove the WEB_ANIMATIONS compile-time flag.
1377
1378         * Configurations/FeatureDefines.xcconfig:
1379         * WebView/WebPreferences.mm:
1380         (+[WebPreferences initialize]):
1381         * WebView/WebView.mm:
1382         (-[WebView _preferencesChanged:]):
1383
1384 2017-10-19  Sam Weinig  <sam@webkit.org>
1385
1386         [Settings] Move global settings into their own file
1387         https://bugs.webkit.org/show_bug.cgi?id=178512
1388
1389         Reviewed by Darin Adler.
1390
1391         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1392
1393         * WebCoreSupport/WebChromeClient.mm:
1394         (WebChromeClient::supportsVideoFullscreen):
1395         * WebView/WebDynamicScrollBarsView.mm:
1396         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1397         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1398         * WebView/WebPreferences.mm:
1399         (+[WebPreferences initialize]):
1400         * WebView/WebView.mm:
1401         (-[WebView _commonInitializationWithFrameName:groupName:]):
1402         (-[WebView _preferencesChanged:]):
1403         (+[WebView _doNotStartObservingNetworkReachability]):
1404
1405 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1406
1407         Replace some stack raw pointers with RefPtrs within WebCore/html
1408         https://bugs.webkit.org/show_bug.cgi?id=178201
1409         <rdar://problem/34841692>
1410
1411         Reviewed by Ryosuke Niwa.
1412
1413         * DOM/DOM.mm:
1414         (kit):
1415         Change the type of node as toNode() is changed to return RefPtr.
1416
1417 2017-10-18  Chris Dumez  <cdumez@apple.com>
1418
1419         [Service Worker] Add stubs for Client / WindowClient / Clients
1420         https://bugs.webkit.org/show_bug.cgi?id=178469
1421
1422         Reviewed by Youenn Fablet.
1423
1424         Rename PageVisiblityState to VisibilityState.
1425
1426         * WebView/WebView.mm:
1427         (kit):
1428
1429 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1430
1431         Unreviewed, rolling out r223291.
1432
1433         See WebCore ChangeLog for more detail.
1434
1435         Reverted changeset:
1436
1437         "Remove Editor::simplifyMarkup"
1438         https://bugs.webkit.org/show_bug.cgi?id=178271
1439         https://trac.webkit.org/changeset/223291
1440
1441 2017-10-17  Keith Miller  <keith_miller@apple.com>
1442
1443         Change WebCore sources to work with unified source builds
1444         https://bugs.webkit.org/show_bug.cgi?id=178229
1445
1446         Rubber stamped by Tim Horton.
1447
1448         * Configurations/FeatureDefines.xcconfig:
1449
1450 2017-10-16  Sam Weinig  <sam@webkit.org>
1451
1452         [Settings] Remove all custom code from Settings.h/cpp
1453         https://bugs.webkit.org/show_bug.cgi?id=178330
1454
1455         Reviewed by Simon Fraser.
1456
1457         * WebView/WebPreferences.mm:
1458         (+[WebPreferences initialize]):
1459         
1460             Update for naming changes of FrameFlattening now that it is an enum class.
1461
1462 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1463
1464         Remove Editor::simplifyMarkup
1465         https://bugs.webkit.org/show_bug.cgi?id=178271
1466
1467         Reviewed by Wenson Hsieh.
1468
1469         * WebView/WebView.mm:
1470         (-[WebView _simplifyMarkup:endNode:]):
1471
1472 2017-10-12  Chris Dumez  <cdumez@apple.com>
1473
1474         [Mac] Add support for MouseEvent.buttons
1475         https://bugs.webkit.org/show_bug.cgi?id=178214
1476
1477         Reviewed by Ryosuke Niwa.
1478
1479         * WebView/WebPDFView.mm:
1480         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1481
1482 2017-10-11  Sam Weinig  <sam@webkit.org>
1483
1484         Remove out-parameter variants of copyToVector
1485         https://bugs.webkit.org/show_bug.cgi?id=178155
1486
1487         Reviewed by Tim Horton.
1488
1489         * Plugins/WebNetscapePluginView.mm:
1490         (-[WebNetscapePluginView destroyPlugin]):
1491         * WebView/WebHTMLRepresentation.mm:
1492         (newArrayWithStrings):
1493
1494             Replace out-parameter based copyToVector, with one that returns a Vector.
1495
1496 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1497
1498         Sanitize URL in pasteboard for other applications and cross origin content
1499         https://bugs.webkit.org/show_bug.cgi?id=178060
1500         <rdar://problem/34874518>
1501
1502         Reviewed by Wenson Hsieh.
1503
1504         * WebCoreSupport/WebPlatformStrategies.h:
1505         * WebCoreSupport/WebPlatformStrategies.mm:
1506         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1507
1508 2017-10-11  Chris Dumez  <cdumez@apple.com>
1509
1510         Modernize Geolocation code
1511         https://bugs.webkit.org/show_bug.cgi?id=178148
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         * WebCoreSupport/WebGeolocationClient.h:
1516         * WebCoreSupport/WebGeolocationClient.mm:
1517         (WebGeolocationClient::lastPosition):
1518         * WebView/WebGeolocationPosition.mm:
1519         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1520         (core):
1521         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1522         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1523         * WebView/WebGeolocationPositionInternal.h:
1524
1525 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1526
1527         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1528         https://bugs.webkit.org/show_bug.cgi?id=178154
1529
1530         Reviewed by Wenson Hsieh.
1531
1532         Enable custom pasteboard data by default.
1533
1534         * WebView/WebPreferenceKeysPrivate.h:
1535         * WebView/WebPreferences.mm:
1536         (+[WebPreferences initialize]):
1537         (-[WebPreferences customPasteboardDataEnabled]): Added.
1538         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1539         * WebView/WebPreferencesPrivate.h:
1540         * WebView/WebView.mm:
1541         (-[WebView _preferencesChanged:]):
1542
1543 2017-10-10  Sam Weinig  <sam@webkit.org>
1544
1545         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1546         https://bugs.webkit.org/show_bug.cgi?id=178102
1547
1548         Reviewed by Tim Horton.
1549
1550         * History/WebHistory.mm:
1551         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1552         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1553         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1554         * WebCoreSupport/WebUserMediaClient.mm:
1555         (WebUserMediaClient::pageDestroyed):
1556
1557 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1558
1559         Make the names of the options consistent
1560         https://bugs.webkit.org/show_bug.cgi?id=177933
1561
1562         Reviewed by Saam Barati.
1563
1564         * WebView/WebFrame.h:
1565         * WebView/WebHTMLView.mm:
1566         (-[WebHTMLView setMarkedText:selectedRange:]):
1567         * WebView/WebView.h:
1568
1569 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1570
1571         [iOS] Tweak support for classifying form controls (followup to r222487)
1572         https://bugs.webkit.org/show_bug.cgi?id=177917
1573         <rdar://problem/34820122>
1574
1575         Reviewed by Dean Jackson.
1576
1577         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1578
1579         * DOM/DOMHTMLInputElement.mm:
1580         (-[DOMHTMLInputElement _autofillContext]):
1581         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1582         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1583
1584 2017-10-05  Keith Miller  <keith_miller@apple.com>
1585
1586         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1587
1588         * Configurations/WebKitLegacy.xcconfig:
1589
1590 2017-10-05  Jer Noble  <jer.noble@apple.com>
1591
1592         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1593         https://bugs.webkit.org/show_bug.cgi?id=177261
1594
1595         Reviewed by Eric Carlson.
1596
1597         * Configurations/FeatureDefines.xcconfig:
1598
1599 2017-10-05  Chris Dumez  <cdumez@apple.com>
1600
1601         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1602         https://bugs.webkit.org/show_bug.cgi?id=177957
1603
1604         Reviewed by Alex Christensen.
1605
1606         * WebCoreSupport/WebPlatformStrategies.h:
1607         * WebCoreSupport/WebPlatformStrategies.mm:
1608         (WebPlatformStrategies::cookiesEnabled):
1609
1610 2017-10-05  Youenn Fablet  <youenn@apple.com>
1611
1612         Make LibWebRTCProvider port agnostic
1613         https://bugs.webkit.org/show_bug.cgi?id=177747
1614
1615         Reviewed by Alex Christensen & Alex Garcia.
1616
1617         * WebView/WebView.mm:
1618         (-[WebView _commonInitializationWithFrameName:groupName:]):
1619         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1620
1621 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1622
1623         Stop linking with WebKitSystemInterface
1624         https://bugs.webkit.org/show_bug.cgi?id=177915
1625
1626         Reviewed by Antti Koivisto.
1627
1628         * Configurations/DebugRelease.xcconfig:
1629         * Configurations/WebKitLegacy.xcconfig:
1630
1631 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1632
1633         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1634         https://bugs.webkit.org/show_bug.cgi?id=177912
1635
1636         Reviewed by Saam Barati.
1637
1638         * Carbon/CarbonUtils.m:
1639         * Carbon/CarbonWindowAdapter.mm:
1640         * Carbon/HIWebView.mm:
1641         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1642         * Misc/WebNSFileManagerExtras.mm:
1643         * Misc/WebNSPasteboardExtras.mm:
1644         * Misc/WebNSURLExtras.mm:
1645         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1646         * Plugins/Hosted/NetscapePluginHostManager.mm:
1647         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1648         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1649         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1650         * Plugins/Hosted/WebTextInputWindowController.m:
1651         * Plugins/WebBaseNetscapePluginView.mm:
1652         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1653         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1654         * Plugins/WebNetscapePluginStream.mm:
1655         * Plugins/WebNetscapePluginView.mm:
1656         * Plugins/WebPluginDatabase.mm:
1657         * WebCoreSupport/PopupMenuMac.mm:
1658         * WebCoreSupport/WebChromeClient.mm:
1659         * WebCoreSupport/WebFrameLoaderClient.mm:
1660         * WebCoreSupport/WebInspectorClient.mm:
1661         * WebCoreSupport/WebPlatformStrategies.mm:
1662         * WebCoreSupport/WebSystemInterface.mm:
1663         * WebView/WebDynamicScrollBarsView.mm:
1664         * WebView/WebFrame.mm:
1665         * WebView/WebFrameView.mm:
1666         * WebView/WebFullScreenController.mm:
1667         * WebView/WebHTMLView.mm:
1668         * WebView/WebPreferences.mm:
1669         * WebView/WebView.mm:
1670
1671 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1672
1673         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1674         rdar://problem/34705779
1675
1676         Addressing review comments that I somehow landed without.
1677
1678         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1679
1680 2017-09-29  Chris Dumez  <cdumez@apple.com>
1681
1682         Split some logic out of VisitedLinkStore and make it reusable
1683         https://bugs.webkit.org/show_bug.cgi?id=177575
1684
1685         Reviewed by Alex Christensen.
1686
1687         * WebCoreSupport/WebVisitedLinkStore.h:
1688         * WebCoreSupport/WebVisitedLinkStore.mm:
1689         (WebVisitedLinkStore::addVisitedLink):
1690         (WebVisitedLinkStore::removeVisitedLink):
1691         (WebVisitedLinkStore::isLinkVisited):
1692         (WebVisitedLinkStore::addVisitedLinkHash):
1693
1694 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1695
1696         Build fix for High Sierra 32 bit Mac
1697         https://bugs.webkit.org/show_bug.cgi?id=177551
1698         <rdar://problem/34690283>
1699
1700         Reviewed by Alexey Proskuryakov.
1701
1702         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1703         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1704         also made.
1705
1706         * Carbon/CarbonWindowAdapter.mm:
1707         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1708         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1709         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1710         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1711         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1712         (-[CarbonWindowAdapter dealloc]):
1713         (-[CarbonWindowAdapter windowRef]):
1714         (-[CarbonWindowAdapter _hasWindowRef]):
1715         (-[CarbonWindowAdapter _managesWindowRef]):
1716         (-[CarbonWindowAdapter _removeWindowRef]):
1717         (-[CarbonWindowAdapter _carbonWindowClass]):
1718         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1719         (-[CarbonWindowAdapter sendSuperEvent:]):
1720         (-[CarbonWindowAdapter relinquishFocus]):
1721         (-[CarbonWindowAdapter _cancelKey:]):
1722         (-[CarbonWindowAdapter _commonAwake]):
1723         (-[CarbonWindowAdapter _destroyRealWindow:]):
1724         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1725         (-[CarbonWindowAdapter _termWindowIfOwner]):
1726         (-[CarbonWindowAdapter _windowMovedToRect:]):
1727         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1728         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1729         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1730         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1731         (-[CarbonWindowAdapter canBecomeMainWindow]):
1732         (-[CarbonWindowAdapter encodeWithCoder:]):
1733         (-[CarbonWindowAdapter initWithCoder:]):
1734         (-[CarbonWindowAdapter setContentView:]):
1735         (-[CarbonWindowAdapter worksWhenModal]):
1736         (-[CarbonWindowAdapter _setModalWindowLevel]):
1737         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1738         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1739         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1740         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1741         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1742         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1743         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1744         (NSCarbonWindowHandleEvent):
1745         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1746         (-[CarbonWindowAdapter _growBoxRect]):
1747         * Carbon/HIWebView.mm:
1748         (HIWebViewGetWebView):
1749         (HIWebViewConstructor):
1750         (HIWebViewDestructor):
1751         (HIWebViewRegisterClass):
1752         (GetBehaviors):
1753         (Draw):
1754         (HitTest):
1755         (GetRegion):
1756         (GetWindowRef):
1757         (CreateNSEventAdoptingCGEvent):
1758         (CopyEventCGEvent):
1759         (CreateNSEventWithCarbonClickEvent):
1760         (Click):
1761         (CreateNSEventWithCarbonEvent):
1762         (MouseUp):
1763         (CreateNSEventWithCarbonMouseMoveEvent):
1764         (MouseMoved):
1765         (MouseDragged):
1766         (MouseWheelMoved):
1767         (ContextMenuClick):
1768         (GetKind):
1769         (BoundsChanged):
1770         (OwningWindowChanged):
1771         (WindowHandler):
1772         (SyncFrame):
1773         (SetFocusPart):
1774         (AdvanceFocus):
1775         (RelinquishFocus):
1776         (ActiveStateChanged):
1777         (ProcessCommand):
1778         (UpdateCommandStatus):
1779         (_NSSelectorForHICommand):
1780         (HIWebViewEventHandler):
1781         (StartUpdateObserver):
1782         (StopUpdateObserver):
1783         (UpdateObserver):
1784
1785 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1786
1787         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1788         https://bugs.webkit.org/show_bug.cgi?id=172526
1789         <rdar://problem/32396081>
1790
1791         Reviewed by Ryosuke Niwa.
1792
1793         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1794
1795         * WebCoreSupport/WebPlatformStrategies.h:
1796         * WebCoreSupport/WebPlatformStrategies.mm:
1797         (WebPlatformStrategies::webExposedTypes):
1798         (WebPlatformStrategies::writeCustomData):
1799
1800 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1801
1802         Unreviewed, rolling out r222567.
1803
1804         This broke and internal build.
1805
1806         Reverted changeset:
1807
1808         "Build fix for High Sierra 32 bit Mac"
1809         https://bugs.webkit.org/show_bug.cgi?id=177551
1810         http://trac.webkit.org/changeset/222567
1811
1812 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1813
1814         Build fix for High Sierra 32 bit Mac
1815         https://bugs.webkit.org/show_bug.cgi?id=177551
1816         <rdar://problem/34690283>
1817
1818         Reviewed by Alexey Proskuryakov.
1819
1820         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1821         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1822         also made.
1823
1824         * Carbon/CarbonWindowAdapter.mm:
1825         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1826         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1827         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1828         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1829         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1830         (-[CarbonWindowAdapter dealloc]):
1831         (-[CarbonWindowAdapter windowRef]):
1832         (-[CarbonWindowAdapter _hasWindowRef]):
1833         (-[CarbonWindowAdapter _managesWindowRef]):
1834         (-[CarbonWindowAdapter _removeWindowRef]):
1835         (-[CarbonWindowAdapter _carbonWindowClass]):
1836         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1837         (-[CarbonWindowAdapter sendSuperEvent:]):
1838         (-[CarbonWindowAdapter relinquishFocus]):
1839         (-[CarbonWindowAdapter _cancelKey:]):
1840         (-[CarbonWindowAdapter _commonAwake]):
1841         (-[CarbonWindowAdapter _destroyRealWindow:]):
1842         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1843         (-[CarbonWindowAdapter _termWindowIfOwner]):
1844         (-[CarbonWindowAdapter _windowMovedToRect:]):
1845         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1846         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1847         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1848         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1849         (-[CarbonWindowAdapter canBecomeMainWindow]):
1850         (-[CarbonWindowAdapter encodeWithCoder:]):
1851         (-[CarbonWindowAdapter initWithCoder:]):
1852         (-[CarbonWindowAdapter setContentView:]):
1853         (-[CarbonWindowAdapter worksWhenModal]):
1854         (-[CarbonWindowAdapter _setModalWindowLevel]):
1855         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1856         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1857         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1858         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1859         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1860         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1861         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1862         (NSCarbonWindowHandleEvent):
1863         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1864         (-[CarbonWindowAdapter _growBoxRect]):
1865         * Carbon/HIWebView.mm:
1866         (HIWebViewGetWebView):
1867         (HIWebViewConstructor):
1868         (HIWebViewDestructor):
1869         (HIWebViewRegisterClass):
1870         (GetBehaviors):
1871         (Draw):
1872         (HitTest):
1873         (GetRegion):
1874         (GetWindowRef):
1875         (CreateNSEventAdoptingCGEvent):
1876         (CopyEventCGEvent):
1877         (CreateNSEventWithCarbonClickEvent):
1878         (Click):
1879         (CreateNSEventWithCarbonEvent):
1880         (MouseUp):
1881         (CreateNSEventWithCarbonMouseMoveEvent):
1882         (MouseMoved):
1883         (MouseDragged):
1884         (MouseWheelMoved):
1885         (ContextMenuClick):
1886         (GetKind):
1887         (BoundsChanged):
1888         (OwningWindowChanged):
1889         (WindowHandler):
1890         (SyncFrame):
1891         (SetFocusPart):
1892         (AdvanceFocus):
1893         (RelinquishFocus):
1894         (ActiveStateChanged):
1895         (ProcessCommand):
1896         (UpdateCommandStatus):
1897         (_NSSelectorForHICommand):
1898         (HIWebViewEventHandler):
1899         (StartUpdateObserver):
1900         (StopUpdateObserver):
1901         (UpdateObserver):
1902
1903 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1904
1905         Make PolicyAction an encodable enum class
1906         https://bugs.webkit.org/show_bug.cgi?id=177480
1907
1908         Reviewed by Antti Koivisto.
1909
1910         * Plugins/WebPluginContainerCheck.mm:
1911         (-[WebPluginContainerCheck _continueWithPolicy:]):
1912         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1913         * WebCoreSupport/WebFrameLoaderClient.mm:
1914         (-[WebFramePolicyListener invalidate]):
1915         (-[WebFramePolicyListener ignore]):
1916         (-[WebFramePolicyListener download]):
1917         (-[WebFramePolicyListener use]):
1918         (-[WebFramePolicyListener continue]):
1919         * WebView/WebPolicyDelegate.mm:
1920         (-[WebPolicyDecisionListener use]):
1921         (-[WebPolicyDecisionListener ignore]):
1922         (-[WebPolicyDecisionListener download]):
1923
1924 2017-09-25  Frederik Riedel  <riedel@apple.com>
1925
1926         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1927         https://bugs.webkit.org/show_bug.cgi?id=174394
1928         <rdar://problem/33183504>
1929
1930         Reviewed by Ryosuke Niwa.
1931
1932         * DOM/DOMHTMLInputElement.h:
1933         * DOM/DOMHTMLInputElement.mm:
1934         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1935         Determines if this HTMLInputElement is part of a login screen.
1936         (-[DOMHTMLInputElement representingPageUrl]):
1937         Returns the webpage's URL that is currently displayed in the Web View.
1938         (-[DOMHTMLInputElement insertTextSuggestion:]):
1939         Inserts login credentials into the Web View.
1940
1941 2017-09-25  Sam Weinig  <sam@webkit.org>
1942
1943         Remove unused EditorClient functions
1944         https://bugs.webkit.org/show_bug.cgi?id=177463
1945
1946         Reviewed by Alex Christensen.
1947
1948         Remove unused EditorClient functions.
1949
1950         * WebCoreSupport/WebEditorClient.h:
1951         * WebCoreSupport/WebEditorClient.mm:
1952         (WebEditorClient::canonicalizeURL): Deleted.
1953         (WebEditorClient::canonicalizeURLString): Deleted.
1954         (WebEditorClient::writeDataToPasteboard): Deleted.
1955         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1956         (WebEditorClient::readDataFromPasteboard): Deleted.
1957         (WebEditorClient::pasteboardChangeCount): Deleted.
1958
1959 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1960
1961         Stop using PolicyCallback
1962         https://bugs.webkit.org/show_bug.cgi?id=176088
1963
1964         Reviewed by Andy Estes.
1965
1966         * WebCoreSupport/WebFrameLoaderClient.mm:
1967         (-[WebFramePolicyListener invalidate]):
1968         (-[WebFramePolicyListener receivedPolicyDecision:]):
1969
1970 2017-09-25  Sam Weinig  <sam@webkit.org>
1971
1972         Remove unnecessary userVisibleString EditorClient function
1973         https://bugs.webkit.org/show_bug.cgi?id=177456
1974
1975         Reviewed by Dan Bernstein.
1976
1977         * WebCoreSupport/WebEditorClient.h:
1978         * WebCoreSupport/WebEditorClient.mm:
1979         (WebEditorClient::userVisibleString): Deleted.
1980
1981             Remove userVisibleString client function.
1982
1983 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1984
1985         Separate form submission from PolicyChecker infrastructure
1986         https://bugs.webkit.org/show_bug.cgi?id=177396
1987
1988         Reviewed by Geoffrey Garen.
1989
1990         * WebCoreSupport/WebFrameLoaderClient.h:
1991         * WebCoreSupport/WebFrameLoaderClient.mm:
1992         (WebFrameLoaderClient::dispatchWillSubmitForm):
1993
1994 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1995
1996         WeakPtrFactory should populate m_ref lazily.
1997         https://bugs.webkit.org/show_bug.cgi?id=177375
1998
1999         Reviewed by Geoffrey Garen.
2000
2001         * WebCoreSupport/WebEditorClient.mm:
2002         (WebEditorClient::WebEditorClient):
2003         (WebEditorClient::requestCandidatesForSelection):
2004
2005 2017-09-22  Chris Dumez  <cdumez@apple.com>
2006
2007         Use high resolution timestamp for event time
2008         https://bugs.webkit.org/show_bug.cgi?id=154246
2009         <rdar://problem/34333304>
2010
2011         Reviewed by Ryosuke Niwa.
2012
2013         Use WallTime / MonotonicTime instead of double type for clarity.
2014
2015         * DOM/DOMEvent.mm:
2016         (-[DOMEvent timeStamp]):
2017         * WebView/WebFrame.mm:
2018         (-[WebFrame _dragSourceEndedAt:operation:]):
2019         * WebView/WebPDFView.mm:
2020         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2021
2022 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2023
2024         Enable dataTransfer.items on macOS and iOS
2025         https://bugs.webkit.org/show_bug.cgi?id=177335
2026
2027         Reviewed by Sam Weinig.
2028
2029         * WebView/WebPreferences.mm:
2030         (+[WebPreferences initialize]):
2031
2032 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2033
2034         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2035         https://bugs.webkit.org/show_bug.cgi?id=177101
2036         <rdar://problem/34500648>
2037
2038         Reviewed by Brian Burg.
2039
2040         * WebInspector/WebNodeHighlight.mm:
2041         Ensure we close the window that we have just removed.
2042
2043 2017-09-20  Antti Koivisto  <antti@apple.com>
2044
2045         Remove DOM and styling support for CSS Regions
2046         https://bugs.webkit.org/show_bug.cgi?id=177221
2047
2048         Reviewed by Andreas Kling.
2049
2050         * Configurations/FeatureDefines.xcconfig:
2051         * DOM/DOMCSS.mm:
2052         (kitClass):
2053         * DOM/DOMElement.mm:
2054         (-[DOMElement webkitRegionOverset]): Deleted.
2055
2056 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2057
2058         Layering violation in Editor::createFragment
2059         https://bugs.webkit.org/show_bug.cgi?id=176123
2060
2061         Reviewed by Darin Adler.
2062
2063         * Misc/WebNSURLExtras.h:
2064         * Misc/WebNSURLExtras.mm:
2065         * WebView/WebFrame.mm:
2066         * WebView/WebHTMLView.mm:
2067         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2068
2069         * WebCoreSupport/WebEditorClient.mm:
2070         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2071         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2072         way to avoid exporting the symbol just on newer OSes.
2073
2074 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2075
2076         On iOS, getData can't get text set by setData during copy event
2077         https://bugs.webkit.org/show_bug.cgi?id=176980
2078         <rdar://problem/34453915>
2079
2080         Reviewed by Darin Adler.
2081
2082         * WebCoreSupport/WebPlatformStrategies.h:
2083         * WebCoreSupport/WebPlatformStrategies.mm:
2084         (WebPlatformStrategies::copy): Deleted.
2085
2086 2017-09-18  Andy Estes  <aestes@apple.com>
2087
2088         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2089         https://bugs.webkit.org/show_bug.cgi?id=177029
2090
2091         Reviewed by Alex Christensen.
2092
2093         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2094         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2095         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2096         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2097         * WebCoreSupport/PopupMenuMac.mm:
2098         (PopupMenuMac::show):
2099         * WebCoreSupport/WebSystemInterface.mm:
2100         (InitWebCoreSystemInterface):
2101         * WebView/WebHTMLView.mm:
2102         (-[WebHTMLView setDataSource:]):
2103         (-[WebHTMLView attachRootLayer:]):
2104         * WebView/WebView.mm:
2105         (-[WebView _needsAdobeFrameReloadingQuirk]):
2106         (-[WebView _needsLinkElementTextCSSQuirk]):
2107         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2108         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2109         (-[WebView _preferencesChanged:]):
2110
2111 2017-09-15  Andy Estes  <aestes@apple.com>
2112
2113         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2114         https://bugs.webkit.org/show_bug.cgi?id=176953
2115
2116         Reviewed by Eric Carlson.
2117
2118         * WebCoreSupport/WebSystemInterface.mm:
2119         (InitWebCoreSystemInterface):
2120
2121 2017-09-14  Andy Estes  <aestes@apple.com>
2122
2123         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2124         https://bugs.webkit.org/show_bug.cgi?id=176931
2125
2126         Reviewed by Joseph Pecoraro.
2127
2128         * WebCoreSupport/WebSystemInterface.mm:
2129         (InitWebCoreSystemInterface):
2130
2131 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2132
2133         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2134         https://bugs.webkit.org/show_bug.cgi?id=176867
2135
2136         Reviewed by Sam Weinig.
2137
2138         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2139         (WebKit::NetscapePluginInstanceProxy::enumerate):
2140
2141 2017-09-13  Andy Estes  <aestes@apple.com>
2142
2143         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2144         https://bugs.webkit.org/show_bug.cgi?id=176729
2145
2146         Reviewed by Alex Christensen.
2147
2148         * WebCoreSupport/WebSystemInterface.mm:
2149         (InitWebCoreSystemInterface):
2150         * WebView/WebView.mm:
2151         (+[WebView _setCacheModel:]):
2152
2153 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2154
2155         Refactor WebContentReader out of EditorMac and EditorIOS
2156         https://bugs.webkit.org/show_bug.cgi?id=176770
2157
2158         Reviewed by Sam Weinig.
2159
2160         * WebCoreSupport/WebEditorClient.mm:
2161
2162 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2163
2164         Dragging & dropping a file creates an attachment element even when it's disabled
2165         https://bugs.webkit.org/show_bug.cgi?id=176769
2166
2167         Reviewed by Tim Horton.
2168
2169         * WebView/WebView.mm:
2170         (-[WebView _preferencesChanged:]):
2171
2172 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2173
2174         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2175         https://bugs.webkit.org/show_bug.cgi?id=176721
2176         <rdar://problem/34373660>
2177
2178         Reviewed by Tim Horton.
2179
2180         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2181         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2182
2183         * WebView/WebView.mm:
2184         (-[WebView _startDrag:]):
2185         (-[WebView _draggedElementBounds]):
2186         (-[WebView _endedDataInteraction:global:]):
2187         * WebView/WebViewData.h:
2188
2189 2017-09-11  Andy Estes  <aestes@apple.com>
2190
2191         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2192         https://bugs.webkit.org/show_bug.cgi?id=176472
2193
2194         Reviewed by Eric Carlson.
2195
2196         * WebCoreSupport/WebSystemInterface.mm:
2197         (InitWebCoreSystemInterface):
2198
2199 2017-09-09  Mark Lam  <mark.lam@apple.com>
2200
2201         Avoid duplicate computations of ExecState::vm().
2202         https://bugs.webkit.org/show_bug.cgi?id=176647
2203
2204         Reviewed by Saam Barati.
2205
2206         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2207         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2208         (WebKit::NetscapePluginInstanceProxy::construct):
2209         (WebKit::NetscapePluginInstanceProxy::setProperty):
2210         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2211         (WebKit::NetscapePluginInstanceProxy::enumerate):
2212         * Plugins/Hosted/ProxyInstance.mm:
2213         (WebKit::ProxyRuntimeMethod::create):
2214
2215 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2216
2217         Unreviewed, rolling out r221773.
2218         https://bugs.webkit.org/show_bug.cgi?id=176614
2219
2220         This caused build failures. (Requested by mlewis13 on
2221         #webkit).
2222
2223         Reverted changeset:
2224
2225         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2226         https://bugs.webkit.org/show_bug.cgi?id=176472
2227         http://trac.webkit.org/changeset/221773
2228
2229 2017-09-07  Andy Estes  <aestes@apple.com>
2230
2231         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2232         https://bugs.webkit.org/show_bug.cgi?id=176472
2233
2234         Reviewed by Eric Carlson.
2235
2236         * WebCoreSupport/WebSystemInterface.mm:
2237         (InitWebCoreSystemInterface):
2238
2239 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2240
2241         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2242         https://bugs.webkit.org/show_bug.cgi?id=176561
2243
2244         Reviewed by Brent Fulgham.
2245
2246         * Misc/WebNSUserDefaultsExtras.mm:
2247
2248 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2249
2250         Modernize Geolocation code
2251         https://bugs.webkit.org/show_bug.cgi?id=176496
2252
2253         Reviewed by Andy Estes.
2254
2255         * WebCoreSupport/WebGeolocationClient.h:
2256         * WebCoreSupport/WebGeolocationClient.mm:
2257         (WebGeolocationClient::requestPermission):
2258         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2259         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2260         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2261         * WebView/WebView.mm:
2262         (-[WebView _commonInitializationWithFrameName:groupName:]):
2263         (-[WebView _geolocationDidFailWithMessage:]):
2264
2265 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2266
2267         Remove some unused bits of code and resources
2268         https://bugs.webkit.org/show_bug.cgi?id=176275
2269
2270         Reviewed by Dan Bernstein.
2271
2272         * Misc/WebNSFileManagerExtras.mm:
2273         Include FileSystem instead of FileSystemIOS.
2274
2275 2017-09-03  Darin Adler  <darin@apple.com>
2276
2277         [Cocoa] Tidy a few things in legacy WebHTMLView
2278         https://bugs.webkit.org/show_bug.cgi?id=176280
2279
2280         Reviewed by Dan Bernstein.
2281
2282         * WebCoreSupport/WebChromeClient.mm:
2283         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2284         methods it calls on WebHTMLView were doing nothing on iOS.
2285
2286         * WebView/WebFrame.mm:
2287         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2288         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2289
2290         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2291         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2292         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2293         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2294         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2295         Use RetainPtr instead of writing retain/release wherever possible.
2296         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2297         initialization for it. Removed various unused methods and declarations of methods.
2298         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2299         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2300         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2301         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2302         and remove CFRetain no longer needed since we don't support garbage collection any more.
2303         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2304         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2305         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2306         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2307         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2308         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2309         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2310         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2311         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2312         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2313         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2314         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2315         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2316         debug flag; we haven't used it for years and it's not clearly helpful.
2317         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2318         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2319         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2320         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2321         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2322         two additional methods in the WebPrivate category and still be called by the two
2323         methods in the WebInternal category that were already using it.
2324         (-[WebHTMLView didAddSubview:]): Deleted.
2325         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2326         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2327         place this was called, the close method.
2328         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2329         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2330         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2331         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2332         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2333         Added helper method to make the one below simpler.
2334         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2335         Compared pasteboard type strings using isEqualToString: rather than using == since
2336         we want to actually compare the string contents. Also updated to use modern for loop,
2337         renamed a local variable from "s" to "localSubresources", and factored out the handling
2338         of three image types to use the helper method above.
2339         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2340         _web_makePluginSubviewsPerformSelector:withObject: method.
2341         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2342         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2343         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2344         not call the -[NSView subviews] method to make this identical on both platforms and used
2345         a modern for loop.
2346         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2347         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2348         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2349         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2350         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2351         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2352         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2353         of it is Mac-only.
2354         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2355         method did was call itself on the main thread, and do nothing if called on main thread.
2356         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2357         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2358         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2359         half of this method.
2360         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2361         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2362         Simplified using a modern for loop and RetainPtr.
2363         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2364         (-[WebHTMLView keyDown:]): Ditto.
2365         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2366         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2367         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2368         (-[WebHTMLView complete:]): Ditto.
2369         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2370         now macOS-only.
2371         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2372         iOS since that is now macOS-only.
2373         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2374         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2375         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2376         and reorganized to use early return.
2377         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2378         on iOS, but kept there so we don't have to do #if at every call site.
2379         (-[WebHTMLView _pluginController]): Moved into internal category.
2380         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2381         there only for GC, using C++ initialization, removing obsolete comment.
2382         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2383         peculiar iOS-only comment.
2384         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2385
2386         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2387         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2388         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2389         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2390         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2391
2392         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2393         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2394         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2395         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2396         them at this time.
2397
2398 2017-09-03  Sam Weinig  <sam@webkit.org>
2399
2400         Remove CanvasProxy
2401         https://bugs.webkit.org/show_bug.cgi?id=176288
2402
2403         Reviewed by Yusuke Suzuki.
2404
2405         CanvasProxy does not appear to be in any current HTML spec
2406         and was disabled and unimplemented in our tree. Time to 
2407         get rid of it.
2408
2409         * Configurations/FeatureDefines.xcconfig:
2410
2411 2017-09-02  Andy Estes  <aestes@apple.com>
2412
2413         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2414         https://bugs.webkit.org/show_bug.cgi?id=176270
2415
2416         Reviewed by Tim Horton.
2417
2418         * Plugins/Hosted/NetscapePluginHostManager.mm:
2419         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2420         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2421         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2422         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2423         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2424         (WebKit::SoftwareCARenderer::context const):
2425         (WebKit::SoftwareCARenderer::renderContext const):
2426         (WebKit::SoftwareCARenderer::render):
2427         (-[WebHostedNetscapePluginView createPlugin]):
2428         (-[WebHostedNetscapePluginView createPluginLayer]):
2429         (-[WebHostedNetscapePluginView destroyPlugin]):
2430         (-[WebHostedNetscapePluginView drawRect:]):
2431         * WebCoreSupport/WebSystemInterface.mm:
2432         (InitWebCoreSystemInterface):
2433
2434 2017-09-01  Andy Estes  <aestes@apple.com>
2435
2436         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2437         https://bugs.webkit.org/show_bug.cgi?id=176200
2438
2439         Reviewed by Tim Horton.
2440
2441         * Carbon/HIWebView.mm:
2442         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2443         (overrideCGContext):
2444         (restoreCGContext):
2445         (Draw):
2446         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2447         (+[WebHostedNetscapePluginView initialize]):
2448         * Plugins/WebBaseNetscapePluginView.h:
2449         * Plugins/WebBaseNetscapePluginView.mm:
2450         (WebKit::sendUserChangeNotifications):
2451         * Plugins/WebNetscapePluginView.mm:
2452         (+[WebNetscapePluginView initialize]):
2453         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2454         * WebCoreSupport/WebSystemInterface.mm:
2455         (InitWebCoreSystemInterface):
2456         * WebView/WebFrame.mm:
2457         (-[WebFrame _paintBehaviorForDestinationContext:]):
2458         * WebView/WebFullScreenController.mm:
2459         (setClipRectForWindow):
2460         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2461         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2462         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2463         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2464
2465 2017-08-31  Andy Estes  <aestes@apple.com>
2466
2467         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2468         https://bugs.webkit.org/show_bug.cgi?id=176175
2469
2470         Reviewed by Brady Eidson.
2471
2472         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2473         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2474         * Plugins/Hosted/WebTextInputWindowController.m:
2475         (-[WebTextInputPanel init]):
2476         * WebCoreSupport/WebSystemInterface.mm:
2477         (InitWebCoreSystemInterface):
2478         * WebView/WebDynamicScrollBarsView.mm:
2479         (-[WebDynamicScrollBarsView scrollWheel:]):
2480         * WebView/WebHTMLView.mm:
2481         (-[WebHTMLView _removeWindowObservers]):
2482         (-[WebHTMLView addWindowObservers]):
2483         * WebView/WebView.mm:
2484         (-[WebView addWindowObserversForWindow:]):
2485         (-[WebView removeWindowObservers]):
2486         (-[WebView viewWillMoveToWindow:]):
2487
2488 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2489
2490         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2491         https://bugs.webkit.org/show_bug.cgi?id=175779
2492         <rdar://problem/22367975>
2493
2494         Reviewed by Tim Horton.
2495
2496         * WebCoreSupport/WebFrameLoaderClient.h:
2497         * WebCoreSupport/WebFrameLoaderClient.mm:
2498         (WebFrameLoaderClient::webGLPolicyForURL const):
2499         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2500
2501 2017-08-30  Andy Estes  <aestes@apple.com>
2502
2503         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2504         https://bugs.webkit.org/show_bug.cgi?id=176093
2505
2506         Reviewed by Eric Carlson.
2507
2508         * WebCoreSupport/WebSystemInterface.mm:
2509         (InitWebCoreSystemInterface):
2510
2511 2017-08-30  Andy Estes  <aestes@apple.com>
2512
2513         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2514         https://bugs.webkit.org/show_bug.cgi?id=176087
2515
2516         Reviewed by Alex Christensen.
2517
2518         * Carbon/CarbonUtils.m:
2519         (getNSAutoreleasePoolCount):
2520         (WebInitForCarbon):
2521         (PoolCleaner):
2522         * Carbon/CarbonWindowAdapter.mm:
2523         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2524         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2525         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2526         (-[CarbonWindowAdapter _windowMovedToRect:]):
2527         * Carbon/HIViewAdapter.m:
2528         * Carbon/HIWebView.mm:
2529         (Draw):
2530         (CreateNSEventAdoptingCGEvent):
2531         (CopyEventCGEvent):
2532         (CreateNSEventWithCarbonClickEvent):
2533         (Click):
2534         (CreateNSEventWithCarbonEvent):
2535         (MouseUp):
2536         (CreateNSEventWithCarbonMouseMoveEvent):
2537         (MouseMoved):
2538         (MouseDragged):
2539         (MouseWheelMoved):
2540         (WindowHandler):
2541         (HIWebViewEventHandler):
2542         * Misc/QuickDrawCompatibility.h: Removed.
2543         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2544         (getCarbonEvent):
2545         (WebNetscapePluginEventHandlerCarbon::keyDown):
2546         (WebNetscapePluginEventHandlerCarbon::keyUp):
2547         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2548         (WebNetscapePluginEventHandlerCocoa::keyDown):
2549         * Plugins/WebNetscapePluginView.mm:
2550         (-[WebNetscapePluginView tellQuickTimeToChill]):
2551
2552 2017-08-29  Andy Estes  <aestes@apple.com>
2553
2554         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2555         https://bugs.webkit.org/show_bug.cgi?id=176046
2556
2557         Reviewed by Alex Christensen.
2558
2559         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2560         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2561
2562         * Misc/WebNSFileManagerExtras.mm:
2563         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2564         (setMetaData): Deleted.
2565         * WebCoreSupport/WebSystemInterface.mm:
2566         (InitWebCoreSystemInterface):
2567
2568 2017-08-28  Andy Estes  <aestes@apple.com>
2569
2570         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2571         https://bugs.webkit.org/show_bug.cgi?id=176039
2572
2573         Reviewed by Alex Christensen.
2574
2575         * WebCoreSupport/WebSystemInterface.mm:
2576         (InitWebCoreSystemInterface):
2577         * WebView/WebPreferences.mm:
2578         (+[WebPreferences _systemCFStringEncoding]):
2579
2580 2017-08-28  Andy Estes  <aestes@apple.com>
2581
2582         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2583         https://bugs.webkit.org/show_bug.cgi?id=176032
2584
2585         Reviewed by Alex Christensen.
2586
2587         * WebCoreSupport/WebSystemInterface.mm:
2588         (InitWebCoreSystemInterface):
2589         * WebView/WebView.mm:
2590         (-[WebView _cachedResponseForURL:]):
2591
2592 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2593
2594         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2595         https://bugs.webkit.org/show_bug.cgi?id=175992
2596         <rdar://problem/34086613>
2597
2598         Reviewed by Daniel Bates.
2599
2600         * WebCoreSupport/WebPlatformStrategies.h:
2601         * WebCoreSupport/WebPlatformStrategies.mm:
2602         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2603         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2604         indicating if secure cookies were accessed.
2605
2606 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2607
2608         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2609         https://bugs.webkit.org/show_bug.cgi?id=170955
2610         <rdar://problem/31697653>
2611
2612         Reviewed by Ryosuke Niwa.
2613
2614         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2615         text is being replaced.
2616
2617         * WebView/WebHTMLView.mm:
2618         (-[WebHTMLView insertText:]):
2619
2620 2017-08-24  Chris Dumez  <cdumez@apple.com>
2621
2622         [Directory Upload] Add basic support for input.webkitdirectory
2623         https://bugs.webkit.org/show_bug.cgi?id=175950
2624         <rdar://problem/33951915>
2625
2626         Reviewed by Geoffrey Garen.
2627
2628         Add private API to toggle Directory Upload support on Mac WebKit1.
2629
2630         * WebView/WebPreferenceKeysPrivate.h:
2631         * WebView/WebPreferences.mm:
2632         (+[WebPreferences initialize]):
2633         (-[WebPreferences setDirectoryUploadEnabled:]):
2634         (-[WebPreferences directoryUploadEnabled]):
2635         * WebView/WebPreferencesPrivate.h:
2636         * WebView/WebView.mm:
2637         (-[WebView _preferencesChanged:]):
2638
2639 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2640
2641         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2642         https://bugs.webkit.org/show_bug.cgi?id=175370
2643         <rdar://problem/33799806>
2644
2645         Reviewed by Ryosuke Niwa.
2646
2647         Adjust WebEditorClient for interface changes.
2648
2649         * WebCoreSupport/WebEditorClient.h:
2650
2651 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2652
2653         Remove ChromeClient::scrollbarsModeDidChange
2654         https://bugs.webkit.org/show_bug.cgi?id=175805
2655
2656         Reviewed by Daniel Bates.
2657
2658         * WebCoreSupport/WebChromeClient.h:
2659
2660 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2661
2662         Remove ChromeClient::hasOpenedPopup
2663         https://bugs.webkit.org/show_bug.cgi?id=175804
2664
2665         Reviewed by Sam Weinig.
2666
2667         * WebCoreSupport/WebChromeClient.h:
2668         * WebCoreSupport/WebChromeClient.mm:
2669         (WebChromeClient::hasOpenedPopup const): Deleted.
2670
2671 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2672
2673         Disable access to secure cookies if an HTTPS site loads mixed content
2674         https://bugs.webkit.org/show_bug.cgi?id=157053
2675         <rdar://problem/11290808>
2676
2677         Reviewed by Dan Bates.
2678
2679         * WebCoreSupport/WebPlatformStrategies.h:
2680         * WebCoreSupport/WebPlatformStrategies.mm:
2681         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2682         indicating whether secure cookies should be included in the response.
2683
2684 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2685
2686         [PAL] Move spi/mac directory into PAL
2687         https://bugs.webkit.org/show_bug.cgi?id=175649
2688
2689         Reviewed by Myles C. Maxfield.
2690
2691         * Misc/WebSharingServicePickerController.h:
2692         * WebCoreSupport/WebContextMenuClient.mm:
2693         * WebCoreSupport/WebEditorClient.mm:
2694         * WebCoreSupport/WebSelectionServiceController.mm:
2695         * WebView/WebHTMLView.mm:
2696         * WebView/WebImmediateActionController.h:
2697         * WebView/WebImmediateActionController.mm:
2698         * WebView/WebView.mm:
2699
2700 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2701
2702         [PAL] Relocate SessionID to root
2703         https://bugs.webkit.org/show_bug.cgi?id=175684
2704
2705         Reviewed by Alex Christensen.
2706
2707         * WebCoreSupport/WebFrameNetworkingContext.mm:
2708
2709 2017-08-17  Andreas Kling  <akling@apple.com>
2710
2711         Disable CSS regions at compile time
2712         https://bugs.webkit.org/show_bug.cgi?id=175630
2713
2714         Reviewed by Antti Koivisto.
2715
2716         * Configurations/FeatureDefines.xcconfig:
2717
2718 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2719
2720         [PAL] Move SessionID into PAL
2721         https://bugs.webkit.org/show_bug.cgi?id=174192
2722
2723         Reviewed by Antti Koivisto.
2724
2725         * Misc/WebCache.mm:
2726         (+[WebCache imageForURL:]):
2727         * WebCoreSupport/WebFrameLoaderClient.h:
2728         * WebCoreSupport/WebFrameLoaderClient.mm:
2729         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2730         * WebCoreSupport/WebFrameNetworkingContext.mm:
2731         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2732         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2733         (WebFrameNetworkingContext::storageSession const):
2734         * WebCoreSupport/WebPlatformStrategies.h:
2735         * WebCoreSupport/WebPlatformStrategies.mm:
2736         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2737         * WebKitPrefix.h:
2738
2739 2017-08-16  Andy Estes  <aestes@apple.com>
2740
2741         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2742         https://bugs.webkit.org/show_bug.cgi?id=175648
2743
2744         Reviewed by Tim Horton.
2745
2746         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2747         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2748         (WebPaymentCoordinatorClient::showPaymentUI):
2749
2750 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2751
2752         [PAL] Move spi/ios and spi/win directories into PAL
2753         https://bugs.webkit.org/show_bug.cgi?id=175171
2754
2755         Reviewed by Antti Koivisto.
2756
2757         * WebCoreSupport/WebFrameLoaderClient.mm:
2758         * WebView/WebView.mm:
2759
2760 2017-08-16  Andy Estes  <aestes@apple.com>
2761
2762         [Payment Request] Add an ENABLE flag and an experimental feature preference
2763         https://bugs.webkit.org/show_bug.cgi?id=175622
2764
2765         Reviewed by Tim Horton.
2766
2767         * Configurations/FeatureDefines.xcconfig:
2768
2769 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2770
2771         [PAL] Move Sleep classes into PAL
2772         https://bugs.webkit.org/show_bug.cgi?id=175456
2773
2774         Reviewed by Ryosuke Niwa.
2775
2776         * WebView/WebFullScreenController.h:
2777
2778 2017-08-15  Youenn Fablet  <youenn@apple.com>
2779
2780         [Cache API] Adding generic support for CacheStorage and Cache methods
2781         https://bugs.webkit.org/show_bug.cgi?id=175455
2782
2783         Reviewed by Chris Dumez.
2784
2785         * WebView/WebView.mm:
2786         (-[WebView _commonInitializationWithFrameName:groupName:]):
2787
2788 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2789
2790         Remove Proximity Events and related code
2791         https://bugs.webkit.org/show_bug.cgi?id=175545
2792
2793         Reviewed by Daniel Bates.
2794
2795         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2796         and other related code.
2797
2798         * Configurations/FeatureDefines.xcconfig:
2799
2800 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2801
2802         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2803         https://bugs.webkit.org/show_bug.cgi?id=175504
2804
2805         Reviewed by Sam Weinig.
2806
2807         * Configurations/FeatureDefines.xcconfig:
2808         * DOM/DOMHTMLFormElement.mm:
2809         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2810         * WebCoreSupport/WebFrameLoaderClient.h:
2811
2812 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2813
2814         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2815         https://bugs.webkit.org/show_bug.cgi?id=175557
2816
2817         Reviewed by Jon Lee.
2818
2819         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2820
2821         * Configurations/FeatureDefines.xcconfig:
2822
2823 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2824
2825         Composition underline color is always black
2826         https://bugs.webkit.org/show_bug.cgi?id=174675
2827
2828         Reviewed by Ryosuke Niwa.
2829
2830         * WebView/WebHTMLView.mm:
2831         (extractUnderlines): If NSUnderlineColorAttributeName
2832         is not present use text color for composition underline.
2833         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2834         for composition underline in the plain text case.
2835
2836 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2837
2838         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2839         https://bugs.webkit.org/show_bug.cgi?id=175474
2840         <rdar://problem/33844628>
2841
2842         Reviewed by Wenson Hsieh.
2843
2844         Replaced the build flag by a runtime flag and disabled the feature by default.
2845
2846         * Configurations/FeatureDefines.xcconfig:
2847         * WebView/WebPreferenceKeysPrivate.h:
2848         * WebView/WebPreferences.mm:
2849         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2850         (-[WebPreferences dataTransferItemsEnabled]): Added.
2851         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2852         * WebView/WebPreferencesPrivate.h:
2853         * WebView/WebView.mm:
2854         (-[WebView _preferencesChanged:]):
2855
2856 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2857
2858         Remove ENABLE_GAMEPAD_DEPRECATED
2859         https://bugs.webkit.org/show_bug.cgi?id=175361
2860
2861         Reviewed by Carlos Garcia Campos.
2862
2863         * Configurations/FeatureDefines.xcconfig:
2864
2865 2017-08-09  Chris Dumez  <cdumez@apple.com>
2866
2867         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2868         https://bugs.webkit.org/show_bug.cgi?id=175401
2869
2870         Reviewed by Brady Eidson.
2871
2872         * WebView/WebPreferenceKeysPrivate.h:
2873         * WebView/WebPreferences.mm:
2874         (+[WebPreferences initialize]):
2875         (-[WebPreferences beaconAPIEnabled]): Deleted.
2876         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2877         * WebView/WebPreferencesPrivate.h:
2878         * WebView/WebView.mm:
2879         (-[WebView _preferencesChanged:]):
2880
2881 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2882
2883         [PAL] Move spi/cocoa and spi/cg directories into PAL
2884         https://bugs.webkit.org/show_bug.cgi?id=175175
2885
2886         Reviewed by Myles C. Maxfield.
2887
2888         * History/WebHistory.mm:
2889         * Misc/WebDownload.mm:
2890         * Misc/WebKitNSStringExtras.mm:
2891         * Plugins/Hosted/NetscapePluginHostManager.mm:
2892         * Plugins/WebPluginDatabase.mm:
2893         * WebCoreSupport/WebFrameLoaderClient.mm:
2894         * WebInspector/WebNodeHighlight.mm:
2895         * WebView/WebHTMLView.mm:
2896         * WebView/WebIndicateLayer.mm:
2897         * WebView/WebView.mm:
2898         * WebView/WebViewData.h:
2899
2900 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2901
2902         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2903         https://bugs.webkit.org/show_bug.cgi?id=175392
2904         <rdar://problem/33783207>
2905
2906         Reviewed by Tim Horton and Megan Gardner.
2907
2908         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2909
2910         * Configurations/FeatureDefines.xcconfig:
2911
2912 2017-08-09  Daniel Bates  <dabates@apple.com>
2913
2914         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2915         https://bugs.webkit.org/show_bug.cgi?id=175247
2916         <rdar://problem/33679804>
2917
2918         Reviewed by Brady Eidson.
2919
2920         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2921         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2922         clients that need to make use of this information at this time. If such a needs comes up
2923         then we can expose API/SPI similar to what we do for WebKit.
2924
2925         * WebCoreSupport/WebFrameLoaderClient.h:
2926         * WebCoreSupport/WebFrameLoaderClient.mm:
2927         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2928
2929 2017-08-08  Brady Eidson  <beidson@apple.com>
2930
2931         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2932         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2933
2934         Reviewed by Andy Estes.
2935
2936         * Misc/WebKitVersionChecks.h:
2937         * WebCoreSupport/WebFrameLoaderClient.mm:
2938         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2939           the app is linked against new WebKit with the new behavior.
2940
2941 2017-08-07  Devin Rousso  <drousso@apple.com>
2942
2943         Web Inspector: Preview Canvas path when viewing a recording
2944         https://bugs.webkit.org/show_bug.cgi?id=174967
2945
2946         Reviewed by Brian Burg.
2947
2948         * WebView/WebPreferenceKeysPrivate.h:
2949         * WebView/WebPreferences.mm:
2950         (+[WebPreferences initialize]):
2951         (-[WebPreferences inspectorAdditionsEnabled]):
2952         (-[WebPreferences setInspectorAdditionsEnabled:]):
2953         * WebView/WebPreferencesPrivate.h:
2954         * WebView/WebView.mm:
2955         (-[WebView _preferencesChanged:]):
2956         Add plumbing for new InspectorAdditions runtime flag.
2957
2958 2017-08-07  Brian Burg  <bburg@apple.com>
2959
2960         Remove CANVAS_PATH compilation guard
2961         https://bugs.webkit.org/show_bug.cgi?id=175207
2962
2963         Reviewed by Sam Weinig.
2964
2965         * Configurations/FeatureDefines.xcconfig:
2966
2967 2017-08-04  Youenn Fablet  <youenn@apple.com>
2968
2969         [Cache API] Add Cache and CacheStorage IDL definitions
2970         https://bugs.webkit.org/show_bug.cgi?id=175201
2971
2972         Reviewed by Brady Eidson.
2973
2974         * WebView/WebPreferenceKeysPrivate.h:
2975         * WebView/WebPreferences.mm:
2976         (+[WebPreferences initialize]):
2977         (-[WebPreferences cacheAPIEnabled]):
2978         (-[WebPreferences setCacheAPIEnabled:]):
2979         * WebView/WebPreferencesPrivate.h:
2980         * WebView/WebView.mm:
2981         (-[WebView _preferencesChanged:]):
2982
2983 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2984
2985         Unreviewed, rolling out r220271.
2986
2987         Rolling out due to Layout Test failing on iOS Simulator.
2988
2989         Reverted changeset:
2990
2991         "Remove STREAMS_API compilation guard"
2992         https://bugs.webkit.org/show_bug.cgi?id=175165
2993         http://trac.webkit.org/changeset/220271
2994
2995 2017-08-04  Youenn Fablet  <youenn@apple.com>
2996
2997         Remove STREAMS_API compilation guard
2998         https://bugs.webkit.org/show_bug.cgi?id=175165
2999
3000         Reviewed by Darin Adler.
3001
3002         * Configurations/FeatureDefines.xcconfig:
3003         * WebView/WebPreferences.mm:
3004         (+[WebPreferences initialize]):
3005         * WebView/WebView.mm:
3006         (-[WebView _preferencesChanged:]):
3007
3008 2017-08-03  Brian Burg  <bburg@apple.com>
3009
3010         Remove ENABLE(WEB_SOCKET) guards
3011         https://bugs.webkit.org/show_bug.cgi?id=167044
3012
3013         Reviewed by Joseph Pecoraro.
3014
3015         * Configurations/FeatureDefines.xcconfig:
3016         * WebView/WebPreferencesPrivate.h:
3017
3018 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3019
3020         [PAL] Move spi/cf directory into PAL
3021         https://bugs.webkit.org/show_bug.cgi?id=175057
3022
3023         Reviewed by Antti Koivisto.
3024
3025         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3026         * Plugins/WebNetscapePluginStream.mm:
3027         * WebCoreSupport/WebFrameNetworkingContext.mm:
3028         * WebView/WebPreferences.mm:
3029         * WebView/WebView.mm:
3030
3031 2017-08-03  Youenn Fablet  <youenn@apple.com>
3032
3033         Remove FETCH_API compilation guard
3034         https://bugs.webkit.org/show_bug.cgi?id=175154
3035
3036         Reviewed by Chris Dumez.
3037
3038         * Configurations/FeatureDefines.xcconfig:
3039         * WebView/WebPreferences.mm:
3040         (+[WebPreferences initialize]):
3041         * WebView/WebView.mm:
3042         (-[WebView _preferencesChanged:]):
3043
3044 2017-08-03  Brady Eidson  <beidson@apple.com>
3045
3046         Add SW IDLs and stub out basic functionality.
3047         https://bugs.webkit.org/show_bug.cgi?id=175115
3048
3049         Reviewed by Chris Dumez.
3050
3051         * Configurations/FeatureDefines.xcconfig:
3052
3053 2017-08-02  Sam Weinig  <sam@webkit.org>
3054
3055         [WebIDL] Convert MutationCallback to be a normal generated callback
3056         https://bugs.webkit.org/show_bug.cgi?id=174140
3057
3058         Reviewed by Darin Adler.
3059
3060         * DOM/DOMDocument.mm:
3061         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3062         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3063         Pass, now necessary, Document to NativeNodeFilter constructor.
3064
3065 2017-08-01  Chris Dumez  <cdumez@apple.com>
3066
3067         Add initial support for navigator.sendBeacon
3068         https://bugs.webkit.org/show_bug.cgi?id=175007
3069         <rdar://problem/33547728>
3070
3071         Reviewed by Sam Weinig.
3072
3073         Add setting to toggle support for the Beacon API (it is disabled by default).
3074
3075         * WebView/WebPreferenceKeysPrivate.h:
3076         * WebView/WebPreferences.mm:
3077         (+[WebPreferences initialize]):
3078         (-[WebPreferences beaconAPIEnabled]):
3079         (-[WebPreferences setBeaconAPIEnabled:]):
3080         * WebView/WebPreferencesPrivate.h:
3081         * WebView/WebView.mm:
3082         (-[WebView _preferencesChanged:]):
3083
3084 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3085
3086         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3087         https://bugs.webkit.org/show_bug.cgi?id=174437
3088
3089         Reviewed by Darin Adler.
3090
3091         Remove redundant Web- prefix from classes in WebKit namespace.
3092
3093         * WebView/WebView.mm:
3094         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3095         * WebView/WebViewData.h:
3096         * WebView/WebViewData.mm:
3097
3098 2017-07-26  Brian Burg  <bburg@apple.com>
3099
3100         Remove WEB_TIMING feature flag
3101         https://bugs.webkit.org/show_bug.cgi?id=174795
3102
3103         Reviewed by Alex Christensen.
3104
3105         * Configurations/FeatureDefines.xcconfig:
3106
3107 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3108
3109         Async image decoding for large images should be disabled after the first time a tile is painted
3110         https://bugs.webkit.org/show_bug.cgi?id=174451
3111         <rdar://problem/31246421>
3112
3113         Reviewed by Simon Fraser.
3114
3115         * WebView/WebFrame.mm:
3116         (-[WebFrame _paintBehaviorForDestinationContext:]):
3117         (-[WebFrame _drawRect:contentsOnly:]):
3118         * WebView/WebHTMLView.mm:
3119         (imageFromRect):
3120
3121 2017-07-23  Darin Adler  <darin@apple.com>
3122
3123         More NeverDestroyed and related cleanup
3124         https://bugs.webkit.org/show_bug.cgi?id=174745
3125
3126         Reviewed by Alex Christensen.
3127
3128         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3129         for names that aren't even used in this file.
3130         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3131         -[NSArray arrayWithObject:].
3132         (-[DOMNode absoluteQuads]): Ditto.
3133         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3134         of writing out various types.
3135         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3136         syntax instea of -[NSArray arrayWithObject:].
3137         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3138         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3139         of writing out various types.
3140         (-[DOMHTMLImageElement mimeType]): Ditto.
3141
3142 2017-07-24  Chris Dumez  <cdumez@apple.com>
3143
3144         ExceptionCode enumeration should use modern exception names
3145         https://bugs.webkit.org/show_bug.cgi?id=174794
3146
3147         Reviewed by Geoffrey Garen.
3148
3149         * DOM/ExceptionHandlers.mm:
3150         (raiseNotSupportedErrorException):
3151
3152 2017-07-23  Chris Dumez  <cdumez@apple.com>
3153
3154         Drop ExceptionCodeDescription class
3155         https://bugs.webkit.org/show_bug.cgi?id=174757
3156
3157         Reviewed by Darin Adler.
3158
3159         Stop using ExceptionCodeDescription.
3160
3161         * DOM/ExceptionHandlers.mm:
3162         (raiseDOMErrorException):
3163
3164 2017-07-21  Andreas Kling  <akling@apple.com>
3165
3166         Use more references in event dispatch code
3167         https://bugs.webkit.org/show_bug.cgi?id=174681
3168
3169         Reviewed by Geoffrey Garen.
3170
3171         * DOM/ObjCEventListener.h:
3172         * DOM/ObjCEventListener.mm:
3173         (WebCore::ObjCEventListener::handleEvent):
3174         * WebCoreSupport/WebFrameLoaderClient.mm:
3175         (NetscapePluginWidget::handleEvent):
3176
3177 2017-07-21  Brady Eidson  <beidson@apple.com>
3178
3179         Get rid of WebCore IconDatabase code.
3180         https://bugs.webkit.org/show_bug.cgi?id=174700
3181
3182         Reviewed by Tim Horton.
3183
3184         * Misc/WebCoreStatistics.mm:
3185         (+[WebCoreStatistics iconPageURLMappingCount]):
3186         (+[WebCoreStatistics iconRetainedPageURLCount]):
3187         (+[WebCoreStatistics iconRecordCount]):
3188         (+[WebCoreStatistics iconsWithDataCount]):
3189         * WebCoreSupport/WebFrameLoaderClient.h:
3190         * WebCoreSupport/WebFrameLoaderClient.mm:
3191         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3192         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3193         * WebView/WebView.mm:
3194         (-[WebView mainFrameIconURL]):
3195
3196 2017-07-20  Chris Dumez  <cdumez@apple.com>
3197
3198         Drop legacy XPathException type
3199         https://bugs.webkit.org/show_bug.cgi?id=174679
3200
3201         Reviewed by Sam Weinig.
3202
3203         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3204         no longer expose XPathException.
3205
3206         * DOM/ExceptionHandlers.mm:
3207         (raiseDOMErrorException):
3208
3209 2017-07-20  Chris Dumez  <cdumez@apple.com>
3210
3211         Unreviewed, rolling out r219706.
3212
3213         Broke iOS build
3214
3215         Reverted changeset:
3216
3217         "Drop legacy XPathException type"
3218         https://bugs.webkit.org/show_bug.cgi?id=174679
3219         http://trac.webkit.org/changeset/219706
3220
3221 2017-07-20  Chris Dumez  <cdumez@apple.com>
3222
3223         Drop legacy XPathException type
3224         https://bugs.webkit.org/show_bug.cgi?id=174679
3225
3226         Reviewed by Sam Weinig.
3227
3228         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3229         no longer expose XPathException.
3230
3231         * DOM/ExceptionHandlers.mm:
3232         (raiseDOMErrorException):
3233         * WebKit.exp:
3234
3235 2017-07-20  Chris Dumez  <cdumez@apple.com>
3236
3237         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3238         https://bugs.webkit.org/show_bug.cgi?id=174660
3239
3240         Reviewed by Geoffrey Garen.
3241
3242         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3243         This essentially replaces a branch to figure out if the new size is less or greater than the
3244         current size by an assertion.
3245
3246         * Plugins/WebNetscapePluginView.mm:
3247         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3248
3249 2017-07-20  Brady Eidson  <beidson@apple.com>
3250
3251         Deprecate WebIconDatabase in WebKitLegacy/mac.
3252         https://bugs.webkit.org/show_bug.cgi?id=174607
3253
3254         Reviewed by Alex Christensen.
3255
3256         This patch:
3257         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3258         2 - Guts the class to where it can only return the default icon at the small size
3259         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3260             use something else or to not do anything.
3261         
3262         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3263         and that patch will remove all of the last remnants of WebIconDatabase.
3264         
3265         * History/WebHistoryItem.mm:
3266         (-[WebHistoryItem icon]):
3267
3268         * Misc/WebIconDatabase.h:
3269         * Misc/WebIconDatabase.mm:
3270         (-[WebIconDatabase init]):
3271         (-[WebIconDatabase iconForURL:withSize:cache:]):
3272         (-[WebIconDatabase iconForURL:withSize:]):
3273         (-[WebIconDatabase defaultIconWithSize:]):
3274         (-[WebIconDatabase defaultIconForURL:withSize:]):
3275         (-[WebIconDatabase iconURLForURL:]):
3276         (-[WebIconDatabase retainIconForURL:]):
3277         (-[WebIconDatabase releaseIconForURL:]):
3278         (+[WebIconDatabase delayDatabaseCleanup]):
3279         (+[WebIconDatabase allowDatabaseCleanup]):
3280         (-[WebIconDatabase setDelegate:]):
3281         (-[WebIconDatabase delegate]):
3282         (+[WebIconDatabase initialize]): Deleted.
3283         (-[WebIconDatabase isEnabled]): Deleted.
3284         (-[WebIconDatabase setEnabled:]): Deleted.
3285         (-[WebIconDatabase removeAllIcons]): Deleted.
3286         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3287         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3288         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3289         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3290         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3291         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3292         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3293         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3294         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3295         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3296         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3297         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3298         (-[WebIconDatabase _databaseDirectory]): Deleted.
3299         (webGetNSImage): Deleted.
3300
3301         * Misc/WebIconDatabaseDelegate.h: Removed.
3302         * Misc/WebIconDatabaseInternal.h: Removed.
3303         * Misc/WebIconDatabasePrivate.h: Removed.
3304
3305         * WebCoreSupport/WebFrameLoaderClient.mm:
3306         (webGetNSImage):
3307
3308         * WebCoreSupport/WebIconDatabaseClient.mm:
3309         (WebIconDatabaseClient::didRemoveAllIcons):
3310         (WebIconDatabaseClient::didImportIconURLForPageURL):
3311
3312         * WebView/WebView.mm:
3313         (-[WebView setFrameLoadDelegate:]):
3314         (-[WebView mainFrameIcon]):
3315
3316 2017-07-18  Andy Estes  <aestes@apple.com>
3317
3318         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3319         https://bugs.webkit.org/show_bug.cgi?id=174631
3320
3321         Reviewed by Tim Horton.
3322
3323         * Configurations/Base.xcconfig:
3324
3325 2017-07-18  Andy Estes  <aestes@apple.com>
3326
3327         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3328         https://bugs.webkit.org/show_bug.cgi?id=174631
3329
3330         Reviewed by Sam Weinig.
3331
3332         * Configurations/Base.xcconfig:
3333
3334 2017-07-18  Andy Estes  <aestes@apple.com>
3335
3336         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3337         https://bugs.webkit.org/show_bug.cgi?id=174631
3338
3339         Reviewed by Dan Bernstein.
3340
3341         * Configurations/Base.xcconfig:
3342
3343 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3344
3345         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3346         https://bugs.webkit.org/show_bug.cgi?id=174640
3347         <rdar://problem/33297400>
3348
3349         Reviewed by Tim Horton.
3350
3351         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3352         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3353         web thread here, to match the other WebView drag and drop SPI methods.
3354
3355         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3356         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3357         should make this robust against future UIKit changes that could make this no longer the case.
3358
3359         * WebView/WebView.mm:
3360         (-[WebView _requestStartDataInteraction:globalPosition:]):
3361         (-[WebView _dataInteractionCaretRect]):
3362
3363 2017-07-18  Andy Estes  <aestes@apple.com>
3364
3365         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3366         https://bugs.webkit.org/show_bug.cgi?id=174631
3367
3368         Reviewed by Darin Adler.
3369
3370         * Configurations/Base.xcconfig:
3371
3372 2017-07-17  Sam Weinig  <sam@webkit.org>
3373
3374         [WebIDL] Remove custom bindings that require non-caching JS strings
3375         https://bugs.webkit.org/show_bug.cgi?id=174552
3376
3377         Reviewed by Darin Adler.
3378
3379         * DOM/DOMHTMLCanvasElement.mm:
3380         (-[DOMHTMLCanvasElement toDataURL:]):
3381         Update to account for implementation now returning an UncachedString.
3382
3383 2017-07-17  Darin Adler  <darin@apple.com>
3384
3385         Improve use of NeverDestroyed
3386         https://bugs.webkit.org/show_bug.cgi?id=174348
3387
3388         Reviewed by Sam Weinig.
3389
3390         * Misc/WebStringTruncator.mm:
3391         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3392         NeverDestroyed<RetainPtr> with just an NSFont * global.
3393
3394         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3395         NeverDestroyed.h.
3396         * Storage/WebDatabaseManager.mm: Ditto.
3397         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3398         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3399
3400         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3401         (aeDescFromJSValue): Removed double hashing by using the return value from
3402         add rather than calling contains before calling add.
3403
3404 2017-07-14  Jer Noble  <jer.noble@apple.com>
3405
3406         Allow clients to override their own hardware media requirements where no fallback media exists.
3407         https://bugs.webkit.org/show_bug.cgi?id=174426
3408         <rdar://problem/32537704>
3409
3410         Reviewed by Eric Carlson.
3411
3412         Add a new WebPreferences property to control WebCore's new
3413         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3414
3415         * WebView/WebPreferenceKeysPrivate.h:
3416         * WebView/WebPreferences.mm:
3417         (+[WebPreferences initialize]):
3418         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3419         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3420         * WebView/WebPreferencesPrivate.h:
3421         * WebView/WebView.mm:
3422         (-[WebView _preferencesChanged:]):
3423
3424 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3425
3426         Async image decoding for large images should be disabled by default
3427         https://bugs.webkit.org/show_bug.cgi?id=174432
3428
3429         Reviewed by Simon Fraser.
3430
3431         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3432         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3433         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3434            a child view instead of propagating PaintBehaviorSnapshotting.
3435         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3436            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3437
3438         * WebView/WebFrame.mm:
3439         (-[WebFrame _paintBehaviorForDestinationContext:]):
3440         (-[WebFrame _drawRect:contentsOnly:]):
3441         * WebView/WebHTMLView.mm:
3442         (imageFromRect):
3443
3444 2017-07-12  Daniel Bates  <dabates@apple.com>
3445
3446         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3447         https://bugs.webkit.org/show_bug.cgi?id=174427
3448
3449         Rubber-stamped by Brady Eidson.
3450
3451         * WebView/WebPDFView.mm:
3452         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3453
3454 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3455
3456         Unreviewed, rolling out r219401.
3457
3458         This revision rolled out the previous patch, but after talking
3459         with reviewer, a rebaseline is what was needed.Rolling back in
3460         before rebaseline.
3461
3462         Reverted changeset:
3463
3464         "Unreviewed, rolling out r219379."
3465         https://bugs.webkit.org/show_bug.cgi?id=174400
3466         http://trac.webkit.org/changeset/219401
3467
3468 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3469
3470         Unreviewed, rolling out r219379.
3471
3472         This revision caused a consistent failure in the test
3473         fast/dom/Window/property-access-on-cached-window-after-frame-
3474         removed.html.
3475
3476         Reverted changeset:
3477
3478         "Remove NAVIGATOR_HWCONCURRENCY"
3479         https://bugs.webkit.org/show_bug.cgi?id=174400
3480         http://trac.webkit.org/changeset/219379
3481
3482 2017-07-11  Dean Jackson  <dino@apple.com>
3483
3484         Remove NAVIGATOR_HWCONCURRENCY
3485         https://bugs.webkit.org/show_bug.cgi?id=174400
3486
3487         * Configurations/FeatureDefines.xcconfig:
3488
3489 2017-07-11  Dean Jackson  <dino@apple.com>