Make ResourceLoader::willSendRequestInternal asynchronous
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2
3         Make ResourceLoader::willSendRequestInternal asynchronous
4         https://bugs.webkit.org/show_bug.cgi?id=179251
5
6         Reviewed by Andy Estes.
7
8         * Plugins/Hosted/HostedNetscapePluginStream.mm:
9         (WebKit::HostedNetscapePluginStream::start):
10         * Plugins/WebNetscapePluginStream.mm:
11         (WebNetscapePluginStream::start):
12
13 2017-11-01  Darin Adler  <darin@apple.com>
14
15         Simplify event dispatch code and make it a bit more consistent
16         https://bugs.webkit.org/show_bug.cgi?id=178991
17
18         Reviewed by Chris Dumez.
19
20         * DOM/DOMEvent.mm:
21         (-[DOMEvent srcElement]): Call target instead of srcElement.
22
23 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
24
25         [Touch Bar Web API] Add support for menuitem tag
26         https://bugs.webkit.org/show_bug.cgi?id=179020
27
28         Reviewed by Ryosuke Niwa.
29
30         Adds in properties and methods that allow the menuitem runtime feature
31         to be enabled or disabled.
32
33         * WebView/WebPreferenceKeysPrivate.h:
34         * WebView/WebPreferences.mm:
35         (-[WebPreferences menuItemElementEnabled]):
36         (-[WebPreferences setMenuItemElementEnabled:]):
37         * WebView/WebPreferencesPrivate.h:
38         * WebView/WebView.mm:
39         (-[WebView _preferencesChanged:]):
40
41 2017-11-02  Alex Christensen  <achristensen@webkit.org>
42
43         Use CompletionHandlers for redirects
44         https://bugs.webkit.org/show_bug.cgi?id=179163
45
46         Reviewed by Tim Horton.
47
48         * Plugins/Hosted/HostedNetscapePluginStream.h:
49         * Plugins/Hosted/HostedNetscapePluginStream.mm:
50         (WebKit::HostedNetscapePluginStream::willSendRequest):
51         * Plugins/WebNetscapePluginStream.h:
52         * Plugins/WebNetscapePluginStream.mm:
53         (WebNetscapePluginStream::willSendRequest):
54
55 2017-11-02  Christopher Reid  <chris.reid@sony.com>
56
57         Add a FileSystem namespace to FileSystem.cpp
58         https://bugs.webkit.org/show_bug.cgi?id=179063
59
60         Reviewed by Darin Adler.
61
62         * Misc/WebNSFileManagerExtras.mm:
63         * Storage/WebDatabaseProvider.mm:
64
65 2017-11-02  Frederic Wang  <fwang@igalia.com>
66
67         Add references to bug 179167 in FIXME comments
68         https://bugs.webkit.org/show_bug.cgi?id=179168
69
70         Reviewed by Daniel Bates.
71
72         * Configurations/FeatureDefines.xcconfig:
73
74 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
75
76         Implement WKFullscreenWindowController for iOS.
77         https://bugs.webkit.org/show_bug.cgi?id=178924
78         rdar://problem/34697120
79
80         Reviewed by Simon Fraser.
81
82         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
83
84         * Configurations/FeatureDefines.xcconfig:
85         * WebView/WebView.mm:
86         (-[WebView fullScreenPlaceholderView]):
87
88 2017-10-31  Tim Horton  <timothy_horton@apple.com>
89
90         Clean up some drag and drop feature flags
91         https://bugs.webkit.org/show_bug.cgi?id=179082
92
93         Reviewed by Simon Fraser.
94
95         * Configurations/FeatureDefines.xcconfig:
96
97 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
98
99         Make it possible to test rubber-banding in overflow scroll
100         https://bugs.webkit.org/show_bug.cgi?id=179078
101
102         Reviewed by Sam Weinig.
103
104         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
105         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
106
107         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
108         functions, since most callers want clamped.
109
110         * DOM/DOMHTML.mm:
111         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
112
113 2017-10-31  Tim Horton  <timothy_horton@apple.com>
114
115         Fix up some content filtering feature flags
116         https://bugs.webkit.org/show_bug.cgi?id=179079
117
118         Reviewed by Simon Fraser.
119
120         * Configurations/FeatureDefines.xcconfig:
121
122 2017-10-28  Zalan Bujtas  <zalan@apple.com>
123
124         [FrameView::layout cleanup] Move core layout logic to a separate class.
125         https://bugs.webkit.org/show_bug.cgi?id=178771
126         <rdar://problem/35166542>
127
128         Reviewed by Simon Fraser.
129
130         Move layout code out from FrameView to LayoutContext.
131
132         * WebView/WebClipView.mm:
133         (-[WebClipView _immediateScrollToPoint:]):
134         * WebView/WebFrame.mm:
135         (-[WebFrame layoutCount]):
136
137 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
138
139         Fix issues with WebView subframe painting
140         https://bugs.webkit.org/show_bug.cgi?id=178842
141         rdar://problem/34072253
142
143         Reviewed by Daniel Bates.
144         
145         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
146         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
147         High Sierra, so match the new signature.
148
149         Also rename the 'rect' param to 'displayRect' to match AppKit code.
150
151         * WebView/WebHTMLView.mm:
152         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
153         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
154
155 2017-10-25  Youenn Fablet  <youenn@apple.com>
156
157         Enable ServiceWorker to fetch resources
158         https://bugs.webkit.org/show_bug.cgi?id=178673
159
160         Reviewed by Brady Eidson.
161
162         * WebCoreSupport/WebFrameLoaderClient.mm:
163         (WebFrameLoaderClient::pageID const):
164         (WebFrameLoaderClient::frameID const):
165         (WebFrameLoaderClient::sessionID const):
166
167         Added implementation to the new getters.
168         They are noop in the context of WK1.
169
170 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
171
172         Web Inspector: Enable WebKit logging configuration and display
173         https://bugs.webkit.org/show_bug.cgi?id=177027
174         <rdar://problem/33964767>
175
176         Reviewed by Joseph Pecoraro.
177
178         * WebCoreSupport/WebChromeClient.mm:
179         (stringForMessageSource): Deal with Media and WebRTC message sources.
180
181 2017-10-20  Antoine Quint  <graouts@apple.com>
182
183         [Web Animations] Provide basic timeline and animation interfaces
184         https://bugs.webkit.org/show_bug.cgi?id=178526
185
186         Reviewed by Dean Jackson.
187
188         Remove the WEB_ANIMATIONS compile-time flag.
189
190         * Configurations/FeatureDefines.xcconfig:
191         * WebView/WebPreferences.mm:
192         (+[WebPreferences initialize]):
193         * WebView/WebView.mm:
194         (-[WebView _preferencesChanged:]):
195
196 2017-10-19  Sam Weinig  <sam@webkit.org>
197
198         [Settings] Move global settings into their own file
199         https://bugs.webkit.org/show_bug.cgi?id=178512
200
201         Reviewed by Darin Adler.
202
203         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
204
205         * WebCoreSupport/WebChromeClient.mm:
206         (WebChromeClient::supportsVideoFullscreen):
207         * WebView/WebDynamicScrollBarsView.mm:
208         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
209         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
210         * WebView/WebPreferences.mm:
211         (+[WebPreferences initialize]):
212         * WebView/WebView.mm:
213         (-[WebView _commonInitializationWithFrameName:groupName:]):
214         (-[WebView _preferencesChanged:]):
215         (+[WebView _doNotStartObservingNetworkReachability]):
216
217 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
218
219         Replace some stack raw pointers with RefPtrs within WebCore/html
220         https://bugs.webkit.org/show_bug.cgi?id=178201
221         <rdar://problem/34841692>
222
223         Reviewed by Ryosuke Niwa.
224
225         * DOM/DOM.mm:
226         (kit):
227         Change the type of node as toNode() is changed to return RefPtr.
228
229 2017-10-18  Chris Dumez  <cdumez@apple.com>
230
231         [Service Worker] Add stubs for Client / WindowClient / Clients
232         https://bugs.webkit.org/show_bug.cgi?id=178469
233
234         Reviewed by Youenn Fablet.
235
236         Rename PageVisiblityState to VisibilityState.
237
238         * WebView/WebView.mm:
239         (kit):
240
241 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
242
243         Unreviewed, rolling out r223291.
244
245         See WebCore ChangeLog for more detail.
246
247         Reverted changeset:
248
249         "Remove Editor::simplifyMarkup"
250         https://bugs.webkit.org/show_bug.cgi?id=178271
251         https://trac.webkit.org/changeset/223291
252
253 2017-10-17  Keith Miller  <keith_miller@apple.com>
254
255         Change WebCore sources to work with unified source builds
256         https://bugs.webkit.org/show_bug.cgi?id=178229
257
258         Rubber stamped by Tim Horton.
259
260         * Configurations/FeatureDefines.xcconfig:
261
262 2017-10-16  Sam Weinig  <sam@webkit.org>
263
264         [Settings] Remove all custom code from Settings.h/cpp
265         https://bugs.webkit.org/show_bug.cgi?id=178330
266
267         Reviewed by Simon Fraser.
268
269         * WebView/WebPreferences.mm:
270         (+[WebPreferences initialize]):
271         
272             Update for naming changes of FrameFlattening now that it is an enum class.
273
274 2017-10-13  Alex Christensen  <achristensen@webkit.org>
275
276         Remove Editor::simplifyMarkup
277         https://bugs.webkit.org/show_bug.cgi?id=178271
278
279         Reviewed by Wenson Hsieh.
280
281         * WebView/WebView.mm:
282         (-[WebView _simplifyMarkup:endNode:]):
283
284 2017-10-12  Chris Dumez  <cdumez@apple.com>
285
286         [Mac] Add support for MouseEvent.buttons
287         https://bugs.webkit.org/show_bug.cgi?id=178214
288
289         Reviewed by Ryosuke Niwa.
290
291         * WebView/WebPDFView.mm:
292         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
293
294 2017-10-11  Sam Weinig  <sam@webkit.org>
295
296         Remove out-parameter variants of copyToVector
297         https://bugs.webkit.org/show_bug.cgi?id=178155
298
299         Reviewed by Tim Horton.
300
301         * Plugins/WebNetscapePluginView.mm:
302         (-[WebNetscapePluginView destroyPlugin]):
303         * WebView/WebHTMLRepresentation.mm:
304         (newArrayWithStrings):
305
306             Replace out-parameter based copyToVector, with one that returns a Vector.
307
308 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
309
310         Sanitize URL in pasteboard for other applications and cross origin content
311         https://bugs.webkit.org/show_bug.cgi?id=178060
312         <rdar://problem/34874518>
313
314         Reviewed by Wenson Hsieh.
315
316         * WebCoreSupport/WebPlatformStrategies.h:
317         * WebCoreSupport/WebPlatformStrategies.mm:
318         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
319
320 2017-10-11  Chris Dumez  <cdumez@apple.com>
321
322         Modernize Geolocation code
323         https://bugs.webkit.org/show_bug.cgi?id=178148
324
325         Reviewed by Ryosuke Niwa.
326
327         * WebCoreSupport/WebGeolocationClient.h:
328         * WebCoreSupport/WebGeolocationClient.mm:
329         (WebGeolocationClient::lastPosition):
330         * WebView/WebGeolocationPosition.mm:
331         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
332         (core):
333         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
334         (-[WebGeolocationPosition initWithGeolocationPosition:]):
335         * WebView/WebGeolocationPositionInternal.h:
336
337 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
338
339         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
340         https://bugs.webkit.org/show_bug.cgi?id=178154
341
342         Reviewed by Wenson Hsieh.
343
344         Enable custom pasteboard data by default.
345
346         * WebView/WebPreferenceKeysPrivate.h:
347         * WebView/WebPreferences.mm:
348         (+[WebPreferences initialize]):
349         (-[WebPreferences customPasteboardDataEnabled]): Added.
350         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
351         * WebView/WebPreferencesPrivate.h:
352         * WebView/WebView.mm:
353         (-[WebView _preferencesChanged:]):
354
355 2017-10-10  Sam Weinig  <sam@webkit.org>
356
357         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
358         https://bugs.webkit.org/show_bug.cgi?id=178102
359
360         Reviewed by Tim Horton.
361
362         * History/WebHistory.mm:
363         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
364         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
365         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
366         * WebCoreSupport/WebUserMediaClient.mm:
367         (WebUserMediaClient::pageDestroyed):
368
369 2017-10-09  Robin Morisset  <rmorisset@apple.com>
370
371         Make the names of the options consistent
372         https://bugs.webkit.org/show_bug.cgi?id=177933
373
374         Reviewed by Saam Barati.
375
376         * WebView/WebFrame.h:
377         * WebView/WebHTMLView.mm:
378         (-[WebHTMLView setMarkedText:selectedRange:]):
379         * WebView/WebView.h:
380
381 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
382
383         [iOS] Tweak support for classifying form controls (followup to r222487)
384         https://bugs.webkit.org/show_bug.cgi?id=177917
385         <rdar://problem/34820122>
386
387         Reviewed by Dean Jackson.
388
389         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
390
391         * DOM/DOMHTMLInputElement.mm:
392         (-[DOMHTMLInputElement _autofillContext]):
393         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
394         (-[DOMHTMLInputElement representingPageURL]): Deleted.
395
396 2017-10-05  Keith Miller  <keith_miller@apple.com>
397
398         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
399
400         * Configurations/WebKitLegacy.xcconfig:
401
402 2017-10-05  Jer Noble  <jer.noble@apple.com>
403
404         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
405         https://bugs.webkit.org/show_bug.cgi?id=177261
406
407         Reviewed by Eric Carlson.
408
409         * Configurations/FeatureDefines.xcconfig:
410
411 2017-10-05  Chris Dumez  <cdumez@apple.com>
412
413         Drop unused parameters for CookiesStrategy::cookiesEnabled()
414         https://bugs.webkit.org/show_bug.cgi?id=177957
415
416         Reviewed by Alex Christensen.
417
418         * WebCoreSupport/WebPlatformStrategies.h:
419         * WebCoreSupport/WebPlatformStrategies.mm:
420         (WebPlatformStrategies::cookiesEnabled):
421
422 2017-10-05  Youenn Fablet  <youenn@apple.com>
423
424         Make LibWebRTCProvider port agnostic
425         https://bugs.webkit.org/show_bug.cgi?id=177747
426
427         Reviewed by Alex Christensen & Alex Garcia.
428
429         * WebView/WebView.mm:
430         (-[WebView _commonInitializationWithFrameName:groupName:]):
431         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
432
433 2017-10-04  Alex Christensen  <achristensen@webkit.org>
434
435         Stop linking with WebKitSystemInterface
436         https://bugs.webkit.org/show_bug.cgi?id=177915
437
438         Reviewed by Antti Koivisto.
439
440         * Configurations/DebugRelease.xcconfig:
441         * Configurations/WebKitLegacy.xcconfig:
442
443 2017-10-04  Alex Christensen  <achristensen@webkit.org>
444
445         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
446         https://bugs.webkit.org/show_bug.cgi?id=177912
447
448         Reviewed by Saam Barati.
449
450         * Carbon/CarbonUtils.m:
451         * Carbon/CarbonWindowAdapter.mm:
452         * Carbon/HIWebView.mm:
453         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
454         * Misc/WebNSFileManagerExtras.mm:
455         * Misc/WebNSPasteboardExtras.mm:
456         * Misc/WebNSURLExtras.mm:
457         * Plugins/Hosted/HostedNetscapePluginStream.mm:
458         * Plugins/Hosted/NetscapePluginHostManager.mm:
459         * Plugins/Hosted/NetscapePluginHostProxy.mm:
460         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
461         * Plugins/Hosted/WebHostedNetscapePluginView.h:
462         * Plugins/Hosted/WebTextInputWindowController.m:
463         * Plugins/WebBaseNetscapePluginView.mm:
464         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
465         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
466         * Plugins/WebNetscapePluginStream.mm:
467         * Plugins/WebNetscapePluginView.mm:
468         * Plugins/WebPluginDatabase.mm:
469         * WebCoreSupport/PopupMenuMac.mm:
470         * WebCoreSupport/WebChromeClient.mm:
471         * WebCoreSupport/WebFrameLoaderClient.mm:
472         * WebCoreSupport/WebInspectorClient.mm:
473         * WebCoreSupport/WebPlatformStrategies.mm:
474         * WebCoreSupport/WebSystemInterface.mm:
475         * WebView/WebDynamicScrollBarsView.mm:
476         * WebView/WebFrame.mm:
477         * WebView/WebFrameView.mm:
478         * WebView/WebFullScreenController.mm:
479         * WebView/WebHTMLView.mm:
480         * WebView/WebPreferences.mm:
481         * WebView/WebView.mm:
482
483 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
484
485         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
486         rdar://problem/34705779
487
488         Addressing review comments that I somehow landed without.
489
490         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
491
492 2017-09-29  Chris Dumez  <cdumez@apple.com>
493
494         Split some logic out of VisitedLinkStore and make it reusable
495         https://bugs.webkit.org/show_bug.cgi?id=177575
496
497         Reviewed by Alex Christensen.
498
499         * WebCoreSupport/WebVisitedLinkStore.h:
500         * WebCoreSupport/WebVisitedLinkStore.mm:
501         (WebVisitedLinkStore::addVisitedLink):
502         (WebVisitedLinkStore::removeVisitedLink):
503         (WebVisitedLinkStore::isLinkVisited):
504         (WebVisitedLinkStore::addVisitedLinkHash):
505
506 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
507
508         Build fix for High Sierra 32 bit Mac
509         https://bugs.webkit.org/show_bug.cgi?id=177551
510         <rdar://problem/34690283>
511
512         Reviewed by Alexey Proskuryakov.
513
514         Some assertions have been removed from the SDK. Replace these assertions with equivalent
515         WTF assert code.  Since the files in this patch are using tabs, some style changes were
516         also made.
517
518         * Carbon/CarbonWindowAdapter.mm:
519         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
520         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
521         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
522         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
523         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
524         (-[CarbonWindowAdapter dealloc]):
525         (-[CarbonWindowAdapter windowRef]):
526         (-[CarbonWindowAdapter _hasWindowRef]):
527         (-[CarbonWindowAdapter _managesWindowRef]):
528         (-[CarbonWindowAdapter _removeWindowRef]):
529         (-[CarbonWindowAdapter _carbonWindowClass]):
530         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
531         (-[CarbonWindowAdapter sendSuperEvent:]):
532         (-[CarbonWindowAdapter relinquishFocus]):
533         (-[CarbonWindowAdapter _cancelKey:]):
534         (-[CarbonWindowAdapter _commonAwake]):
535         (-[CarbonWindowAdapter _destroyRealWindow:]):
536         (-[CarbonWindowAdapter _oldPlaceWindow:]):
537         (-[CarbonWindowAdapter _termWindowIfOwner]):
538         (-[CarbonWindowAdapter _windowMovedToRect:]):
539         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
540         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
541         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
542         (-[CarbonWindowAdapter canBecomeKeyWindow]):
543         (-[CarbonWindowAdapter canBecomeMainWindow]):
544         (-[CarbonWindowAdapter encodeWithCoder:]):
545         (-[CarbonWindowAdapter initWithCoder:]):
546         (-[CarbonWindowAdapter setContentView:]):
547         (-[CarbonWindowAdapter worksWhenModal]):
548         (-[CarbonWindowAdapter _setModalWindowLevel]):
549         (-[CarbonWindowAdapter _clearModalWindowLevel]):
550         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
551         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
552         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
553         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
554         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
555         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
556         (NSCarbonWindowHandleEvent):
557         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
558         (-[CarbonWindowAdapter _growBoxRect]):
559         * Carbon/HIWebView.mm:
560         (HIWebViewGetWebView):
561         (HIWebViewConstructor):
562         (HIWebViewDestructor):
563         (HIWebViewRegisterClass):
564         (GetBehaviors):
565         (Draw):
566         (HitTest):
567         (GetRegion):
568         (GetWindowRef):
569         (CreateNSEventAdoptingCGEvent):
570         (CopyEventCGEvent):
571         (CreateNSEventWithCarbonClickEvent):
572         (Click):
573         (CreateNSEventWithCarbonEvent):
574         (MouseUp):
575         (CreateNSEventWithCarbonMouseMoveEvent):
576         (MouseMoved):
577         (MouseDragged):
578         (MouseWheelMoved):
579         (ContextMenuClick):
580         (GetKind):
581         (BoundsChanged):
582         (OwningWindowChanged):
583         (WindowHandler):
584         (SyncFrame):
585         (SetFocusPart):
586         (AdvanceFocus):
587         (RelinquishFocus):
588         (ActiveStateChanged):
589         (ProcessCommand):
590         (UpdateCommandStatus):
591         (_NSSelectorForHICommand):
592         (HIWebViewEventHandler):
593         (StartUpdateObserver):
594         (StopUpdateObserver):
595         (UpdateObserver):
596
597 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
600         https://bugs.webkit.org/show_bug.cgi?id=172526
601         <rdar://problem/32396081>
602
603         Reviewed by Ryosuke Niwa.
604
605         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
606
607         * WebCoreSupport/WebPlatformStrategies.h:
608         * WebCoreSupport/WebPlatformStrategies.mm:
609         (WebPlatformStrategies::webExposedTypes):
610         (WebPlatformStrategies::writeCustomData):
611
612 2017-09-27  Matt Lewis  <jlewis3@apple.com>
613
614         Unreviewed, rolling out r222567.
615
616         This broke and internal build.
617
618         Reverted changeset:
619
620         "Build fix for High Sierra 32 bit Mac"
621         https://bugs.webkit.org/show_bug.cgi?id=177551
622         http://trac.webkit.org/changeset/222567
623
624 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
625
626         Build fix for High Sierra 32 bit Mac
627         https://bugs.webkit.org/show_bug.cgi?id=177551
628         <rdar://problem/34690283>
629
630         Reviewed by Alexey Proskuryakov.
631
632         Some assertions have been removed from the SDK. Replace these assertions with equivalent
633         WTF assert code.  Since the files in this patch are using tabs, some style changes were
634         also made.
635
636         * Carbon/CarbonWindowAdapter.mm:
637         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
638         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
639         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
640         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
641         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
642         (-[CarbonWindowAdapter dealloc]):
643         (-[CarbonWindowAdapter windowRef]):
644         (-[CarbonWindowAdapter _hasWindowRef]):
645         (-[CarbonWindowAdapter _managesWindowRef]):
646         (-[CarbonWindowAdapter _removeWindowRef]):
647         (-[CarbonWindowAdapter _carbonWindowClass]):
648         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
649         (-[CarbonWindowAdapter sendSuperEvent:]):
650         (-[CarbonWindowAdapter relinquishFocus]):
651         (-[CarbonWindowAdapter _cancelKey:]):
652         (-[CarbonWindowAdapter _commonAwake]):
653         (-[CarbonWindowAdapter _destroyRealWindow:]):
654         (-[CarbonWindowAdapter _oldPlaceWindow:]):
655         (-[CarbonWindowAdapter _termWindowIfOwner]):
656         (-[CarbonWindowAdapter _windowMovedToRect:]):
657         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
658         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
659         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
660         (-[CarbonWindowAdapter canBecomeKeyWindow]):
661         (-[CarbonWindowAdapter canBecomeMainWindow]):
662         (-[CarbonWindowAdapter encodeWithCoder:]):
663         (-[CarbonWindowAdapter initWithCoder:]):
664         (-[CarbonWindowAdapter setContentView:]):
665         (-[CarbonWindowAdapter worksWhenModal]):
666         (-[CarbonWindowAdapter _setModalWindowLevel]):
667         (-[CarbonWindowAdapter _clearModalWindowLevel]):
668         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
669         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
670         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
671         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
672         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
673         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
674         (NSCarbonWindowHandleEvent):
675         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
676         (-[CarbonWindowAdapter _growBoxRect]):
677         * Carbon/HIWebView.mm:
678         (HIWebViewGetWebView):
679         (HIWebViewConstructor):
680         (HIWebViewDestructor):
681         (HIWebViewRegisterClass):
682         (GetBehaviors):
683         (Draw):
684         (HitTest):
685         (GetRegion):
686         (GetWindowRef):
687         (CreateNSEventAdoptingCGEvent):
688         (CopyEventCGEvent):
689         (CreateNSEventWithCarbonClickEvent):
690         (Click):
691         (CreateNSEventWithCarbonEvent):
692         (MouseUp):
693         (CreateNSEventWithCarbonMouseMoveEvent):
694         (MouseMoved):
695         (MouseDragged):
696         (MouseWheelMoved):
697         (ContextMenuClick):
698         (GetKind):
699         (BoundsChanged):
700         (OwningWindowChanged):
701         (WindowHandler):
702         (SyncFrame):
703         (SetFocusPart):
704         (AdvanceFocus):
705         (RelinquishFocus):
706         (ActiveStateChanged):
707         (ProcessCommand):
708         (UpdateCommandStatus):
709         (_NSSelectorForHICommand):
710         (HIWebViewEventHandler):
711         (StartUpdateObserver):
712         (StopUpdateObserver):
713         (UpdateObserver):
714
715 2017-09-25  Alex Christensen  <achristensen@webkit.org>
716
717         Make PolicyAction an encodable enum class
718         https://bugs.webkit.org/show_bug.cgi?id=177480
719
720         Reviewed by Antti Koivisto.
721
722         * Plugins/WebPluginContainerCheck.mm:
723         (-[WebPluginContainerCheck _continueWithPolicy:]):
724         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
725         * WebCoreSupport/WebFrameLoaderClient.mm:
726         (-[WebFramePolicyListener invalidate]):
727         (-[WebFramePolicyListener ignore]):
728         (-[WebFramePolicyListener download]):
729         (-[WebFramePolicyListener use]):
730         (-[WebFramePolicyListener continue]):
731         * WebView/WebPolicyDelegate.mm:
732         (-[WebPolicyDecisionListener use]):
733         (-[WebPolicyDecisionListener ignore]):
734         (-[WebPolicyDecisionListener download]):
735
736 2017-09-25  Frederik Riedel  <riedel@apple.com>
737
738         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
739         https://bugs.webkit.org/show_bug.cgi?id=174394
740         <rdar://problem/33183504>
741
742         Reviewed by Ryosuke Niwa.
743
744         * DOM/DOMHTMLInputElement.h:
745         * DOM/DOMHTMLInputElement.mm:
746         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
747         Determines if this HTMLInputElement is part of a login screen.
748         (-[DOMHTMLInputElement representingPageUrl]):
749         Returns the webpage's URL that is currently displayed in the Web View.
750         (-[DOMHTMLInputElement insertTextSuggestion:]):
751         Inserts login credentials into the Web View.
752
753 2017-09-25  Sam Weinig  <sam@webkit.org>
754
755         Remove unused EditorClient functions
756         https://bugs.webkit.org/show_bug.cgi?id=177463
757
758         Reviewed by Alex Christensen.
759
760         Remove unused EditorClient functions.
761
762         * WebCoreSupport/WebEditorClient.h:
763         * WebCoreSupport/WebEditorClient.mm:
764         (WebEditorClient::canonicalizeURL): Deleted.
765         (WebEditorClient::canonicalizeURLString): Deleted.
766         (WebEditorClient::writeDataToPasteboard): Deleted.
767         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
768         (WebEditorClient::readDataFromPasteboard): Deleted.
769         (WebEditorClient::pasteboardChangeCount): Deleted.
770
771 2017-09-25  Alex Christensen  <achristensen@webkit.org>
772
773         Stop using PolicyCallback
774         https://bugs.webkit.org/show_bug.cgi?id=176088
775
776         Reviewed by Andy Estes.
777
778         * WebCoreSupport/WebFrameLoaderClient.mm:
779         (-[WebFramePolicyListener invalidate]):
780         (-[WebFramePolicyListener receivedPolicyDecision:]):
781
782 2017-09-25  Sam Weinig  <sam@webkit.org>
783
784         Remove unnecessary userVisibleString EditorClient function
785         https://bugs.webkit.org/show_bug.cgi?id=177456
786
787         Reviewed by Dan Bernstein.
788
789         * WebCoreSupport/WebEditorClient.h:
790         * WebCoreSupport/WebEditorClient.mm:
791         (WebEditorClient::userVisibleString): Deleted.
792
793             Remove userVisibleString client function.
794
795 2017-09-25  Alex Christensen  <achristensen@webkit.org>
796
797         Separate form submission from PolicyChecker infrastructure
798         https://bugs.webkit.org/show_bug.cgi?id=177396
799
800         Reviewed by Geoffrey Garen.
801
802         * WebCoreSupport/WebFrameLoaderClient.h:
803         * WebCoreSupport/WebFrameLoaderClient.mm:
804         (WebFrameLoaderClient::dispatchWillSubmitForm):
805
806 2017-09-22  Zalan Bujtas  <zalan@apple.com>
807
808         WeakPtrFactory should populate m_ref lazily.
809         https://bugs.webkit.org/show_bug.cgi?id=177375
810
811         Reviewed by Geoffrey Garen.
812
813         * WebCoreSupport/WebEditorClient.mm:
814         (WebEditorClient::WebEditorClient):
815         (WebEditorClient::requestCandidatesForSelection):
816
817 2017-09-22  Chris Dumez  <cdumez@apple.com>
818
819         Use high resolution timestamp for event time
820         https://bugs.webkit.org/show_bug.cgi?id=154246
821         <rdar://problem/34333304>
822
823         Reviewed by Ryosuke Niwa.
824
825         Use WallTime / MonotonicTime instead of double type for clarity.
826
827         * DOM/DOMEvent.mm:
828         (-[DOMEvent timeStamp]):
829         * WebView/WebFrame.mm:
830         (-[WebFrame _dragSourceEndedAt:operation:]):
831         * WebView/WebPDFView.mm:
832         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
833
834 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
835
836         Enable dataTransfer.items on macOS and iOS
837         https://bugs.webkit.org/show_bug.cgi?id=177335
838
839         Reviewed by Sam Weinig.
840
841         * WebView/WebPreferences.mm:
842         (+[WebPreferences initialize]):
843
844 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
845
846         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
847         https://bugs.webkit.org/show_bug.cgi?id=177101
848         <rdar://problem/34500648>
849
850         Reviewed by Brian Burg.
851
852         * WebInspector/WebNodeHighlight.mm:
853         Ensure we close the window that we have just removed.
854
855 2017-09-20  Antti Koivisto  <antti@apple.com>
856
857         Remove DOM and styling support for CSS Regions
858         https://bugs.webkit.org/show_bug.cgi?id=177221
859
860         Reviewed by Andreas Kling.
861
862         * Configurations/FeatureDefines.xcconfig:
863         * DOM/DOMCSS.mm:
864         (kitClass):
865         * DOM/DOMElement.mm:
866         (-[DOMElement webkitRegionOverset]): Deleted.
867
868 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
869
870         Layering violation in Editor::createFragment
871         https://bugs.webkit.org/show_bug.cgi?id=176123
872
873         Reviewed by Darin Adler.
874
875         * Misc/WebNSURLExtras.h:
876         * Misc/WebNSURLExtras.mm:
877         * WebView/WebFrame.mm:
878         * WebView/WebHTMLView.mm:
879         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
880
881         * WebCoreSupport/WebEditorClient.mm:
882         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
883         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
884         way to avoid exporting the symbol just on newer OSes.
885
886 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
887
888         On iOS, getData can't get text set by setData during copy event
889         https://bugs.webkit.org/show_bug.cgi?id=176980
890         <rdar://problem/34453915>
891
892         Reviewed by Darin Adler.
893
894         * WebCoreSupport/WebPlatformStrategies.h:
895         * WebCoreSupport/WebPlatformStrategies.mm:
896         (WebPlatformStrategies::copy): Deleted.
897
898 2017-09-18  Andy Estes  <aestes@apple.com>
899
900         [Mac] Upstream miscellaneous WebKitSystemInterface functions
901         https://bugs.webkit.org/show_bug.cgi?id=177029
902
903         Reviewed by Alex Christensen.
904
905         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
906         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
907         * Plugins/Hosted/NetscapePluginHostProxy.mm:
908         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
909         * WebCoreSupport/PopupMenuMac.mm:
910         (PopupMenuMac::show):
911         * WebCoreSupport/WebSystemInterface.mm:
912         (InitWebCoreSystemInterface):
913         * WebView/WebHTMLView.mm:
914         (-[WebHTMLView setDataSource:]):
915         (-[WebHTMLView attachRootLayer:]):
916         * WebView/WebView.mm:
917         (-[WebView _needsAdobeFrameReloadingQuirk]):
918         (-[WebView _needsLinkElementTextCSSQuirk]):
919         (-[WebView _needsIsLoadingInAPISenseQuirk]):
920         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
921         (-[WebView _preferencesChanged:]):
922
923 2017-09-15  Andy Estes  <aestes@apple.com>
924
925         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
926         https://bugs.webkit.org/show_bug.cgi?id=176953
927
928         Reviewed by Eric Carlson.
929
930         * WebCoreSupport/WebSystemInterface.mm:
931         (InitWebCoreSystemInterface):
932
933 2017-09-14  Andy Estes  <aestes@apple.com>
934
935         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
936         https://bugs.webkit.org/show_bug.cgi?id=176931
937
938         Reviewed by Joseph Pecoraro.
939
940         * WebCoreSupport/WebSystemInterface.mm:
941         (InitWebCoreSystemInterface):
942
943 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
944
945         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
946         https://bugs.webkit.org/show_bug.cgi?id=176867
947
948         Reviewed by Sam Weinig.
949
950         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
951         (WebKit::NetscapePluginInstanceProxy::enumerate):
952
953 2017-09-13  Andy Estes  <aestes@apple.com>
954
955         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
956         https://bugs.webkit.org/show_bug.cgi?id=176729
957
958         Reviewed by Alex Christensen.
959
960         * WebCoreSupport/WebSystemInterface.mm:
961         (InitWebCoreSystemInterface):
962         * WebView/WebView.mm:
963         (+[WebView _setCacheModel:]):
964
965 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
966
967         Refactor WebContentReader out of EditorMac and EditorIOS
968         https://bugs.webkit.org/show_bug.cgi?id=176770
969
970         Reviewed by Sam Weinig.
971
972         * WebCoreSupport/WebEditorClient.mm:
973
974 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
975
976         Dragging & dropping a file creates an attachment element even when it's disabled
977         https://bugs.webkit.org/show_bug.cgi?id=176769
978
979         Reviewed by Tim Horton.
980
981         * WebView/WebView.mm:
982         (-[WebView _preferencesChanged:]):
983
984 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
985
986         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
987         https://bugs.webkit.org/show_bug.cgi?id=176721
988         <rdar://problem/34373660>
989
990         Reviewed by Tim Horton.
991
992         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
993         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
994
995         * WebView/WebView.mm:
996         (-[WebView _startDrag:]):
997         (-[WebView _draggedElementBounds]):
998         (-[WebView _endedDataInteraction:global:]):
999         * WebView/WebViewData.h:
1000
1001 2017-09-11  Andy Estes  <aestes@apple.com>
1002
1003         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1004         https://bugs.webkit.org/show_bug.cgi?id=176472
1005
1006         Reviewed by Eric Carlson.
1007
1008         * WebCoreSupport/WebSystemInterface.mm:
1009         (InitWebCoreSystemInterface):
1010
1011 2017-09-09  Mark Lam  <mark.lam@apple.com>
1012
1013         Avoid duplicate computations of ExecState::vm().
1014         https://bugs.webkit.org/show_bug.cgi?id=176647
1015
1016         Reviewed by Saam Barati.
1017
1018         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1019         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1020         (WebKit::NetscapePluginInstanceProxy::construct):
1021         (WebKit::NetscapePluginInstanceProxy::setProperty):
1022         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1023         (WebKit::NetscapePluginInstanceProxy::enumerate):
1024         * Plugins/Hosted/ProxyInstance.mm:
1025         (WebKit::ProxyRuntimeMethod::create):
1026
1027 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1028
1029         Unreviewed, rolling out r221773.
1030         https://bugs.webkit.org/show_bug.cgi?id=176614
1031
1032         This caused build failures. (Requested by mlewis13 on
1033         #webkit).
1034
1035         Reverted changeset:
1036
1037         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1038         https://bugs.webkit.org/show_bug.cgi?id=176472
1039         http://trac.webkit.org/changeset/221773
1040
1041 2017-09-07  Andy Estes  <aestes@apple.com>
1042
1043         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1044         https://bugs.webkit.org/show_bug.cgi?id=176472
1045
1046         Reviewed by Eric Carlson.
1047
1048         * WebCoreSupport/WebSystemInterface.mm:
1049         (InitWebCoreSystemInterface):
1050
1051 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1052
1053         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1054         https://bugs.webkit.org/show_bug.cgi?id=176561
1055
1056         Reviewed by Brent Fulgham.
1057
1058         * Misc/WebNSUserDefaultsExtras.mm:
1059
1060 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1061
1062         Modernize Geolocation code
1063         https://bugs.webkit.org/show_bug.cgi?id=176496
1064
1065         Reviewed by Andy Estes.
1066
1067         * WebCoreSupport/WebGeolocationClient.h:
1068         * WebCoreSupport/WebGeolocationClient.mm:
1069         (WebGeolocationClient::requestPermission):
1070         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1071         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1072         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1073         * WebView/WebView.mm:
1074         (-[WebView _commonInitializationWithFrameName:groupName:]):
1075         (-[WebView _geolocationDidFailWithMessage:]):
1076
1077 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1078
1079         Remove some unused bits of code and resources
1080         https://bugs.webkit.org/show_bug.cgi?id=176275
1081
1082         Reviewed by Dan Bernstein.
1083
1084         * Misc/WebNSFileManagerExtras.mm:
1085         Include FileSystem instead of FileSystemIOS.
1086
1087 2017-09-03  Darin Adler  <darin@apple.com>
1088
1089         [Cocoa] Tidy a few things in legacy WebHTMLView
1090         https://bugs.webkit.org/show_bug.cgi?id=176280
1091
1092         Reviewed by Dan Bernstein.
1093
1094         * WebCoreSupport/WebChromeClient.mm:
1095         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1096         methods it calls on WebHTMLView were doing nothing on iOS.
1097
1098         * WebView/WebFrame.mm:
1099         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1100         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1101
1102         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1103         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1104         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1105         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1106         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1107         Use RetainPtr instead of writing retain/release wherever possible.
1108         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1109         initialization for it. Removed various unused methods and declarations of methods.
1110         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1111         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1112         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1113         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1114         and remove CFRetain no longer needed since we don't support garbage collection any more.
1115         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1116         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1117         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1118         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1119         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1120         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1121         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1122         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1123         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1124         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1125         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1126         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1127         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1128         debug flag; we haven't used it for years and it's not clearly helpful.
1129         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1130         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1131         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1132         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1133         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1134         two additional methods in the WebPrivate category and still be called by the two
1135         methods in the WebInternal category that were already using it.
1136         (-[WebHTMLView didAddSubview:]): Deleted.
1137         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1138         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1139         place this was called, the close method.
1140         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1141         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1142         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1143         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1144         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1145         Added helper method to make the one below simpler.
1146         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1147         Compared pasteboard type strings using isEqualToString: rather than using == since
1148         we want to actually compare the string contents. Also updated to use modern for loop,
1149         renamed a local variable from "s" to "localSubresources", and factored out the handling
1150         of three image types to use the helper method above.
1151         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1152         _web_makePluginSubviewsPerformSelector:withObject: method.
1153         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1154         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1155         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1156         not call the -[NSView subviews] method to make this identical on both platforms and used
1157         a modern for loop.
1158         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1159         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1160         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1161         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1162         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1163         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1164         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1165         of it is Mac-only.
1166         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1167         method did was call itself on the main thread, and do nothing if called on main thread.
1168         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1169         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1170         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1171         half of this method.
1172         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1173         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1174         Simplified using a modern for loop and RetainPtr.
1175         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1176         (-[WebHTMLView keyDown:]): Ditto.
1177         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1178         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1179         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1180         (-[WebHTMLView complete:]): Ditto.
1181         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1182         now macOS-only.
1183         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1184         iOS since that is now macOS-only.
1185         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1186         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1187         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1188         and reorganized to use early return.
1189         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1190         on iOS, but kept there so we don't have to do #if at every call site.
1191         (-[WebHTMLView _pluginController]): Moved into internal category.
1192         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1193         there only for GC, using C++ initialization, removing obsolete comment.
1194         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1195         peculiar iOS-only comment.
1196         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1197
1198         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1199         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1200         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1201         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1202         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1203
1204         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1205         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1206         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1207         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1208         them at this time.
1209
1210 2017-09-03  Sam Weinig  <sam@webkit.org>
1211
1212         Remove CanvasProxy
1213         https://bugs.webkit.org/show_bug.cgi?id=176288
1214
1215         Reviewed by Yusuke Suzuki.
1216
1217         CanvasProxy does not appear to be in any current HTML spec
1218         and was disabled and unimplemented in our tree. Time to 
1219         get rid of it.
1220
1221         * Configurations/FeatureDefines.xcconfig:
1222
1223 2017-09-02  Andy Estes  <aestes@apple.com>
1224
1225         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1226         https://bugs.webkit.org/show_bug.cgi?id=176270
1227
1228         Reviewed by Tim Horton.
1229
1230         * Plugins/Hosted/NetscapePluginHostManager.mm:
1231         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1232         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1233         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1234         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1235         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1236         (WebKit::SoftwareCARenderer::context const):
1237         (WebKit::SoftwareCARenderer::renderContext const):
1238         (WebKit::SoftwareCARenderer::render):
1239         (-[WebHostedNetscapePluginView createPlugin]):
1240         (-[WebHostedNetscapePluginView createPluginLayer]):
1241         (-[WebHostedNetscapePluginView destroyPlugin]):
1242         (-[WebHostedNetscapePluginView drawRect:]):
1243         * WebCoreSupport/WebSystemInterface.mm:
1244         (InitWebCoreSystemInterface):
1245
1246 2017-09-01  Andy Estes  <aestes@apple.com>
1247
1248         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1249         https://bugs.webkit.org/show_bug.cgi?id=176200
1250
1251         Reviewed by Tim Horton.
1252
1253         * Carbon/HIWebView.mm:
1254         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
1255         (overrideCGContext):
1256         (restoreCGContext):
1257         (Draw):
1258         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1259         (+[WebHostedNetscapePluginView initialize]):
1260         * Plugins/WebBaseNetscapePluginView.h:
1261         * Plugins/WebBaseNetscapePluginView.mm:
1262         (WebKit::sendUserChangeNotifications):
1263         * Plugins/WebNetscapePluginView.mm:
1264         (+[WebNetscapePluginView initialize]):
1265         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1266         * WebCoreSupport/WebSystemInterface.mm:
1267         (InitWebCoreSystemInterface):
1268         * WebView/WebFrame.mm:
1269         (-[WebFrame _paintBehaviorForDestinationContext:]):
1270         * WebView/WebFullScreenController.mm:
1271         (setClipRectForWindow):
1272         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1273         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1274         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1275         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1276
1277 2017-08-31  Andy Estes  <aestes@apple.com>
1278
1279         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1280         https://bugs.webkit.org/show_bug.cgi?id=176175
1281
1282         Reviewed by Brady Eidson.
1283
1284         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1285         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1286         * Plugins/Hosted/WebTextInputWindowController.m:
1287         (-[WebTextInputPanel init]):
1288         * WebCoreSupport/WebSystemInterface.mm:
1289         (InitWebCoreSystemInterface):
1290         * WebView/WebDynamicScrollBarsView.mm:
1291         (-[WebDynamicScrollBarsView scrollWheel:]):
1292         * WebView/WebHTMLView.mm:
1293         (-[WebHTMLView _removeWindowObservers]):
1294         (-[WebHTMLView addWindowObservers]):
1295         * WebView/WebView.mm:
1296         (-[WebView addWindowObserversForWindow:]):
1297         (-[WebView removeWindowObservers]):
1298         (-[WebView viewWillMoveToWindow:]):
1299
1300 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1301
1302         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1303         https://bugs.webkit.org/show_bug.cgi?id=175779
1304         <rdar://problem/22367975>
1305
1306         Reviewed by Tim Horton.
1307
1308         * WebCoreSupport/WebFrameLoaderClient.h:
1309         * WebCoreSupport/WebFrameLoaderClient.mm:
1310         (WebFrameLoaderClient::webGLPolicyForURL const):
1311         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1312
1313 2017-08-30  Andy Estes  <aestes@apple.com>
1314
1315         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1316         https://bugs.webkit.org/show_bug.cgi?id=176093
1317
1318         Reviewed by Eric Carlson.
1319
1320         * WebCoreSupport/WebSystemInterface.mm:
1321         (InitWebCoreSystemInterface):
1322
1323 2017-08-30  Andy Estes  <aestes@apple.com>
1324
1325         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1326         https://bugs.webkit.org/show_bug.cgi?id=176087
1327
1328         Reviewed by Alex Christensen.
1329
1330         * Carbon/CarbonUtils.m:
1331         (getNSAutoreleasePoolCount):
1332         (WebInitForCarbon):
1333         (PoolCleaner):
1334         * Carbon/CarbonWindowAdapter.mm:
1335         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1336         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1337         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1338         (-[CarbonWindowAdapter _windowMovedToRect:]):
1339         * Carbon/HIViewAdapter.m:
1340         * Carbon/HIWebView.mm:
1341         (Draw):
1342         (CreateNSEventAdoptingCGEvent):
1343         (CopyEventCGEvent):
1344         (CreateNSEventWithCarbonClickEvent):
1345         (Click):
1346         (CreateNSEventWithCarbonEvent):
1347         (MouseUp):
1348         (CreateNSEventWithCarbonMouseMoveEvent):
1349         (MouseMoved):
1350         (MouseDragged):
1351         (MouseWheelMoved):
1352         (WindowHandler):
1353         (HIWebViewEventHandler):
1354         * Misc/QuickDrawCompatibility.h: Removed.
1355         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1356         (getCarbonEvent):
1357         (WebNetscapePluginEventHandlerCarbon::keyDown):
1358         (WebNetscapePluginEventHandlerCarbon::keyUp):
1359         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1360         (WebNetscapePluginEventHandlerCocoa::keyDown):
1361         * Plugins/WebNetscapePluginView.mm:
1362         (-[WebNetscapePluginView tellQuickTimeToChill]):
1363
1364 2017-08-29  Andy Estes  <aestes@apple.com>
1365
1366         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
1367         https://bugs.webkit.org/show_bug.cgi?id=176046
1368
1369         Reviewed by Alex Christensen.
1370
1371         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
1372         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
1373
1374         * Misc/WebNSFileManagerExtras.mm:
1375         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1376         (setMetaData): Deleted.
1377         * WebCoreSupport/WebSystemInterface.mm:
1378         (InitWebCoreSystemInterface):
1379
1380 2017-08-28  Andy Estes  <aestes@apple.com>
1381
1382         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
1383         https://bugs.webkit.org/show_bug.cgi?id=176039
1384
1385         Reviewed by Alex Christensen.
1386
1387         * WebCoreSupport/WebSystemInterface.mm:
1388         (InitWebCoreSystemInterface):
1389         * WebView/WebPreferences.mm:
1390         (+[WebPreferences _systemCFStringEncoding]):
1391
1392 2017-08-28  Andy Estes  <aestes@apple.com>
1393
1394         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
1395         https://bugs.webkit.org/show_bug.cgi?id=176032
1396
1397         Reviewed by Alex Christensen.
1398
1399         * WebCoreSupport/WebSystemInterface.mm:
1400         (InitWebCoreSystemInterface):
1401         * WebView/WebView.mm:
1402         (-[WebView _cachedResponseForURL:]):
1403
1404 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1405
1406         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
1407         https://bugs.webkit.org/show_bug.cgi?id=175992
1408         <rdar://problem/34086613>
1409
1410         Reviewed by Daniel Bates.
1411
1412         * WebCoreSupport/WebPlatformStrategies.h:
1413         * WebCoreSupport/WebPlatformStrategies.mm:
1414         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
1415         cookies should be included, and return a pair containing the resulting cookie string and a boolean
1416         indicating if secure cookies were accessed.
1417
1418 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1419
1420         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
1421         https://bugs.webkit.org/show_bug.cgi?id=170955
1422         <rdar://problem/31697653>
1423
1424         Reviewed by Ryosuke Niwa.
1425
1426         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
1427         text is being replaced.
1428
1429         * WebView/WebHTMLView.mm:
1430         (-[WebHTMLView insertText:]):
1431
1432 2017-08-24  Chris Dumez  <cdumez@apple.com>
1433
1434         [Directory Upload] Add basic support for input.webkitdirectory
1435         https://bugs.webkit.org/show_bug.cgi?id=175950
1436         <rdar://problem/33951915>
1437
1438         Reviewed by Geoffrey Garen.
1439
1440         Add private API to toggle Directory Upload support on Mac WebKit1.
1441
1442         * WebView/WebPreferenceKeysPrivate.h:
1443         * WebView/WebPreferences.mm:
1444         (+[WebPreferences initialize]):
1445         (-[WebPreferences setDirectoryUploadEnabled:]):
1446         (-[WebPreferences directoryUploadEnabled]):
1447         * WebView/WebPreferencesPrivate.h:
1448         * WebView/WebView.mm:
1449         (-[WebView _preferencesChanged:]):
1450
1451 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1452
1453         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1454         https://bugs.webkit.org/show_bug.cgi?id=175370
1455         <rdar://problem/33799806>
1456
1457         Reviewed by Ryosuke Niwa.
1458
1459         Adjust WebEditorClient for interface changes.
1460
1461         * WebCoreSupport/WebEditorClient.h:
1462
1463 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1464
1465         Remove ChromeClient::scrollbarsModeDidChange
1466         https://bugs.webkit.org/show_bug.cgi?id=175805
1467
1468         Reviewed by Daniel Bates.
1469
1470         * WebCoreSupport/WebChromeClient.h:
1471
1472 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1473
1474         Remove ChromeClient::hasOpenedPopup
1475         https://bugs.webkit.org/show_bug.cgi?id=175804
1476
1477         Reviewed by Sam Weinig.
1478
1479         * WebCoreSupport/WebChromeClient.h:
1480         * WebCoreSupport/WebChromeClient.mm:
1481         (WebChromeClient::hasOpenedPopup const): Deleted.
1482
1483 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
1484
1485         Disable access to secure cookies if an HTTPS site loads mixed content
1486         https://bugs.webkit.org/show_bug.cgi?id=157053
1487         <rdar://problem/11290808>
1488
1489         Reviewed by Dan Bates.
1490
1491         * WebCoreSupport/WebPlatformStrategies.h:
1492         * WebCoreSupport/WebPlatformStrategies.mm:
1493         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
1494         indicating whether secure cookies should be included in the response.
1495
1496 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1497
1498         [PAL] Move spi/mac directory into PAL
1499         https://bugs.webkit.org/show_bug.cgi?id=175649
1500
1501         Reviewed by Myles C. Maxfield.
1502
1503         * Misc/WebSharingServicePickerController.h:
1504         * WebCoreSupport/WebContextMenuClient.mm:
1505         * WebCoreSupport/WebEditorClient.mm:
1506         * WebCoreSupport/WebSelectionServiceController.mm:
1507         * WebView/WebHTMLView.mm:
1508         * WebView/WebImmediateActionController.h:
1509         * WebView/WebImmediateActionController.mm:
1510         * WebView/WebView.mm:
1511
1512 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1513
1514         [PAL] Relocate SessionID to root
1515         https://bugs.webkit.org/show_bug.cgi?id=175684
1516
1517         Reviewed by Alex Christensen.
1518
1519         * WebCoreSupport/WebFrameNetworkingContext.mm:
1520
1521 2017-08-17  Andreas Kling  <akling@apple.com>
1522
1523         Disable CSS regions at compile time
1524         https://bugs.webkit.org/show_bug.cgi?id=175630
1525
1526         Reviewed by Antti Koivisto.
1527
1528         * Configurations/FeatureDefines.xcconfig:
1529
1530 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1531
1532         [PAL] Move SessionID into PAL
1533         https://bugs.webkit.org/show_bug.cgi?id=174192
1534
1535         Reviewed by Antti Koivisto.
1536
1537         * Misc/WebCache.mm:
1538         (+[WebCache imageForURL:]):
1539         * WebCoreSupport/WebFrameLoaderClient.h:
1540         * WebCoreSupport/WebFrameLoaderClient.mm:
1541         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1542         * WebCoreSupport/WebFrameNetworkingContext.mm:
1543         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1544         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1545         (WebFrameNetworkingContext::storageSession const):
1546         * WebCoreSupport/WebPlatformStrategies.h:
1547         * WebCoreSupport/WebPlatformStrategies.mm:
1548         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1549         * WebKitPrefix.h:
1550
1551 2017-08-16  Andy Estes  <aestes@apple.com>
1552
1553         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
1554         https://bugs.webkit.org/show_bug.cgi?id=175648
1555
1556         Reviewed by Tim Horton.
1557
1558         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1559         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1560         (WebPaymentCoordinatorClient::showPaymentUI):
1561
1562 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1563
1564         [PAL] Move spi/ios and spi/win directories into PAL
1565         https://bugs.webkit.org/show_bug.cgi?id=175171
1566
1567         Reviewed by Antti Koivisto.
1568
1569         * WebCoreSupport/WebFrameLoaderClient.mm:
1570         * WebView/WebView.mm:
1571
1572 2017-08-16  Andy Estes  <aestes@apple.com>
1573
1574         [Payment Request] Add an ENABLE flag and an experimental feature preference
1575         https://bugs.webkit.org/show_bug.cgi?id=175622
1576
1577         Reviewed by Tim Horton.
1578
1579         * Configurations/FeatureDefines.xcconfig:
1580
1581 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
1582
1583         [PAL] Move Sleep classes into PAL
1584         https://bugs.webkit.org/show_bug.cgi?id=175456
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         * WebView/WebFullScreenController.h:
1589
1590 2017-08-15  Youenn Fablet  <youenn@apple.com>
1591
1592         [Cache API] Adding generic support for CacheStorage and Cache methods
1593         https://bugs.webkit.org/show_bug.cgi?id=175455
1594
1595         Reviewed by Chris Dumez.
1596
1597         * WebView/WebView.mm:
1598         (-[WebView _commonInitializationWithFrameName:groupName:]):
1599
1600 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1601
1602         Remove Proximity Events and related code
1603         https://bugs.webkit.org/show_bug.cgi?id=175545
1604
1605         Reviewed by Daniel Bates.
1606
1607         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1608         and other related code.
1609
1610         * Configurations/FeatureDefines.xcconfig:
1611
1612 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1613
1614         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
1615         https://bugs.webkit.org/show_bug.cgi?id=175504
1616
1617         Reviewed by Sam Weinig.
1618
1619         * Configurations/FeatureDefines.xcconfig:
1620         * DOM/DOMHTMLFormElement.mm:
1621         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
1622         * WebCoreSupport/WebFrameLoaderClient.h:
1623
1624 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1625
1626         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1627         https://bugs.webkit.org/show_bug.cgi?id=175557
1628
1629         Reviewed by Jon Lee.
1630
1631         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1632
1633         * Configurations/FeatureDefines.xcconfig:
1634
1635 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
1636
1637         Composition underline color is always black
1638         https://bugs.webkit.org/show_bug.cgi?id=174675
1639
1640         Reviewed by Ryosuke Niwa.
1641
1642         * WebView/WebHTMLView.mm:
1643         (extractUnderlines): If NSUnderlineColorAttributeName
1644         is not present use text color for composition underline.
1645         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
1646         for composition underline in the plain text case.
1647
1648 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1649
1650         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1651         https://bugs.webkit.org/show_bug.cgi?id=175474
1652         <rdar://problem/33844628>
1653
1654         Reviewed by Wenson Hsieh.
1655
1656         Replaced the build flag by a runtime flag and disabled the feature by default.
1657
1658         * Configurations/FeatureDefines.xcconfig:
1659         * WebView/WebPreferenceKeysPrivate.h:
1660         * WebView/WebPreferences.mm:
1661         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
1662         (-[WebPreferences dataTransferItemsEnabled]): Added.
1663         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
1664         * WebView/WebPreferencesPrivate.h:
1665         * WebView/WebView.mm:
1666         (-[WebView _preferencesChanged:]):
1667
1668 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1669
1670         Remove ENABLE_GAMEPAD_DEPRECATED
1671         https://bugs.webkit.org/show_bug.cgi?id=175361
1672
1673         Reviewed by Carlos Garcia Campos.
1674
1675         * Configurations/FeatureDefines.xcconfig:
1676
1677 2017-08-09  Chris Dumez  <cdumez@apple.com>
1678
1679         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1680         https://bugs.webkit.org/show_bug.cgi?id=175401
1681
1682         Reviewed by Brady Eidson.
1683
1684         * WebView/WebPreferenceKeysPrivate.h:
1685         * WebView/WebPreferences.mm:
1686         (+[WebPreferences initialize]):
1687         (-[WebPreferences beaconAPIEnabled]): Deleted.
1688         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
1689         * WebView/WebPreferencesPrivate.h:
1690         * WebView/WebView.mm:
1691         (-[WebView _preferencesChanged:]):
1692
1693 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1694
1695         [PAL] Move spi/cocoa and spi/cg directories into PAL
1696         https://bugs.webkit.org/show_bug.cgi?id=175175
1697
1698         Reviewed by Myles C. Maxfield.
1699
1700         * History/WebHistory.mm:
1701         * Misc/WebDownload.mm:
1702         * Misc/WebKitNSStringExtras.mm:
1703         * Plugins/Hosted/NetscapePluginHostManager.mm:
1704         * Plugins/WebPluginDatabase.mm:
1705         * WebCoreSupport/WebFrameLoaderClient.mm:
1706         * WebInspector/WebNodeHighlight.mm:
1707         * WebView/WebHTMLView.mm:
1708         * WebView/WebIndicateLayer.mm:
1709         * WebView/WebView.mm:
1710         * WebView/WebViewData.h:
1711
1712 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1713
1714         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1715         https://bugs.webkit.org/show_bug.cgi?id=175392
1716         <rdar://problem/33783207>
1717
1718         Reviewed by Tim Horton and Megan Gardner.
1719
1720         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1721
1722         * Configurations/FeatureDefines.xcconfig:
1723
1724 2017-08-09  Daniel Bates  <dabates@apple.com>
1725
1726         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1727         https://bugs.webkit.org/show_bug.cgi?id=175247
1728         <rdar://problem/33679804>
1729
1730         Reviewed by Brady Eidson.
1731
1732         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
1733         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
1734         clients that need to make use of this information at this time. If such a needs comes up
1735         then we can expose API/SPI similar to what we do for WebKit.
1736
1737         * WebCoreSupport/WebFrameLoaderClient.h:
1738         * WebCoreSupport/WebFrameLoaderClient.mm:
1739         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1740
1741 2017-08-08  Brady Eidson  <beidson@apple.com>
1742
1743         Don't enable default icon loading in WK1 for apps linked against old SDKs.
1744         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
1745
1746         Reviewed by Andy Estes.
1747
1748         * Misc/WebKitVersionChecks.h:
1749         * WebCoreSupport/WebFrameLoaderClient.mm:
1750         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
1751           the app is linked against new WebKit with the new behavior.
1752
1753 2017-08-07  Devin Rousso  <drousso@apple.com>
1754
1755         Web Inspector: Preview Canvas path when viewing a recording
1756         https://bugs.webkit.org/show_bug.cgi?id=174967
1757
1758         Reviewed by Brian Burg.
1759
1760         * WebView/WebPreferenceKeysPrivate.h:
1761         * WebView/WebPreferences.mm:
1762         (+[WebPreferences initialize]):
1763         (-[WebPreferences inspectorAdditionsEnabled]):
1764         (-[WebPreferences setInspectorAdditionsEnabled:]):
1765         * WebView/WebPreferencesPrivate.h:
1766         * WebView/WebView.mm:
1767         (-[WebView _preferencesChanged:]):
1768         Add plumbing for new InspectorAdditions runtime flag.
1769
1770 2017-08-07  Brian Burg  <bburg@apple.com>
1771
1772         Remove CANVAS_PATH compilation guard
1773         https://bugs.webkit.org/show_bug.cgi?id=175207
1774
1775         Reviewed by Sam Weinig.
1776
1777         * Configurations/FeatureDefines.xcconfig:
1778
1779 2017-08-04  Youenn Fablet  <youenn@apple.com>
1780
1781         [Cache API] Add Cache and CacheStorage IDL definitions
1782         https://bugs.webkit.org/show_bug.cgi?id=175201
1783
1784         Reviewed by Brady Eidson.
1785
1786         * WebView/WebPreferenceKeysPrivate.h:
1787         * WebView/WebPreferences.mm:
1788         (+[WebPreferences initialize]):
1789         (-[WebPreferences cacheAPIEnabled]):
1790         (-[WebPreferences setCacheAPIEnabled:]):
1791         * WebView/WebPreferencesPrivate.h:
1792         * WebView/WebView.mm:
1793         (-[WebView _preferencesChanged:]):
1794
1795 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1796
1797         Unreviewed, rolling out r220271.
1798
1799         Rolling out due to Layout Test failing on iOS Simulator.
1800
1801         Reverted changeset:
1802
1803         "Remove STREAMS_API compilation guard"
1804         https://bugs.webkit.org/show_bug.cgi?id=175165
1805         http://trac.webkit.org/changeset/220271
1806
1807 2017-08-04  Youenn Fablet  <youenn@apple.com>
1808
1809         Remove STREAMS_API compilation guard
1810         https://bugs.webkit.org/show_bug.cgi?id=175165
1811
1812         Reviewed by Darin Adler.
1813
1814         * Configurations/FeatureDefines.xcconfig:
1815         * WebView/WebPreferences.mm:
1816         (+[WebPreferences initialize]):
1817         * WebView/WebView.mm:
1818         (-[WebView _preferencesChanged:]):
1819
1820 2017-08-03  Brian Burg  <bburg@apple.com>
1821
1822         Remove ENABLE(WEB_SOCKET) guards
1823         https://bugs.webkit.org/show_bug.cgi?id=167044
1824
1825         Reviewed by Joseph Pecoraro.
1826
1827         * Configurations/FeatureDefines.xcconfig:
1828         * WebView/WebPreferencesPrivate.h:
1829
1830 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1831
1832         [PAL] Move spi/cf directory into PAL
1833         https://bugs.webkit.org/show_bug.cgi?id=175057
1834
1835         Reviewed by Antti Koivisto.
1836
1837         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1838         * Plugins/WebNetscapePluginStream.mm:
1839         * WebCoreSupport/WebFrameNetworkingContext.mm:
1840         * WebView/WebPreferences.mm:
1841         * WebView/WebView.mm:
1842
1843 2017-08-03  Youenn Fablet  <youenn@apple.com>
1844
1845         Remove FETCH_API compilation guard
1846         https://bugs.webkit.org/show_bug.cgi?id=175154
1847
1848         Reviewed by Chris Dumez.
1849
1850         * Configurations/FeatureDefines.xcconfig:
1851         * WebView/WebPreferences.mm:
1852         (+[WebPreferences initialize]):
1853         * WebView/WebView.mm:
1854         (-[WebView _preferencesChanged:]):
1855
1856 2017-08-03  Brady Eidson  <beidson@apple.com>
1857
1858         Add SW IDLs and stub out basic functionality.
1859         https://bugs.webkit.org/show_bug.cgi?id=175115
1860
1861         Reviewed by Chris Dumez.
1862
1863         * Configurations/FeatureDefines.xcconfig:
1864
1865 2017-08-02  Sam Weinig  <sam@webkit.org>
1866
1867         [WebIDL] Convert MutationCallback to be a normal generated callback
1868         https://bugs.webkit.org/show_bug.cgi?id=174140
1869
1870         Reviewed by Darin Adler.
1871
1872         * DOM/DOMDocument.mm:
1873         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1874         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1875         Pass, now necessary, Document to NativeNodeFilter constructor.
1876
1877 2017-08-01  Chris Dumez  <cdumez@apple.com>
1878
1879         Add initial support for navigator.sendBeacon
1880         https://bugs.webkit.org/show_bug.cgi?id=175007
1881         <rdar://problem/33547728>
1882
1883         Reviewed by Sam Weinig.
1884
1885         Add setting to toggle support for the Beacon API (it is disabled by default).
1886
1887         * WebView/WebPreferenceKeysPrivate.h:
1888         * WebView/WebPreferences.mm:
1889         (+[WebPreferences initialize]):
1890         (-[WebPreferences beaconAPIEnabled]):
1891         (-[WebPreferences setBeaconAPIEnabled:]):
1892         * WebView/WebPreferencesPrivate.h:
1893         * WebView/WebView.mm:
1894         (-[WebView _preferencesChanged:]):
1895
1896 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
1897
1898         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
1899         https://bugs.webkit.org/show_bug.cgi?id=174437
1900
1901         Reviewed by Darin Adler.
1902
1903         Remove redundant Web- prefix from classes in WebKit namespace.
1904
1905         * WebView/WebView.mm:
1906         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1907         * WebView/WebViewData.h:
1908         * WebView/WebViewData.mm:
1909
1910 2017-07-26  Brian Burg  <bburg@apple.com>
1911
1912         Remove WEB_TIMING feature flag
1913         https://bugs.webkit.org/show_bug.cgi?id=174795
1914
1915         Reviewed by Alex Christensen.
1916
1917         * Configurations/FeatureDefines.xcconfig:
1918
1919 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
1920
1921         Async image decoding for large images should be disabled after the first time a tile is painted
1922         https://bugs.webkit.org/show_bug.cgi?id=174451
1923         <rdar://problem/31246421>
1924
1925         Reviewed by Simon Fraser.
1926
1927         * WebView/WebFrame.mm:
1928         (-[WebFrame _paintBehaviorForDestinationContext:]):
1929         (-[WebFrame _drawRect:contentsOnly:]):
1930         * WebView/WebHTMLView.mm:
1931         (imageFromRect):
1932
1933 2017-07-23  Darin Adler  <darin@apple.com>
1934
1935         More NeverDestroyed and related cleanup
1936         https://bugs.webkit.org/show_bug.cgi?id=174745
1937
1938         Reviewed by Alex Christensen.
1939
1940         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
1941         for names that aren't even used in this file.
1942         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
1943         -[NSArray arrayWithObject:].
1944         (-[DOMNode absoluteQuads]): Ditto.
1945         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
1946         of writing out various types.
1947         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
1948         syntax instea of -[NSArray arrayWithObject:].
1949         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
1950         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
1951         of writing out various types.
1952         (-[DOMHTMLImageElement mimeType]): Ditto.
1953
1954 2017-07-24  Chris Dumez  <cdumez@apple.com>
1955
1956         ExceptionCode enumeration should use modern exception names
1957         https://bugs.webkit.org/show_bug.cgi?id=174794
1958
1959         Reviewed by Geoffrey Garen.
1960
1961         * DOM/ExceptionHandlers.mm:
1962         (raiseNotSupportedErrorException):
1963
1964 2017-07-23  Chris Dumez  <cdumez@apple.com>
1965
1966         Drop ExceptionCodeDescription class
1967         https://bugs.webkit.org/show_bug.cgi?id=174757
1968
1969         Reviewed by Darin Adler.
1970
1971         Stop using ExceptionCodeDescription.
1972
1973         * DOM/ExceptionHandlers.mm:
1974         (raiseDOMErrorException):
1975
1976 2017-07-21  Andreas Kling  <akling@apple.com>
1977
1978         Use more references in event dispatch code
1979         https://bugs.webkit.org/show_bug.cgi?id=174681
1980
1981         Reviewed by Geoffrey Garen.
1982
1983         * DOM/ObjCEventListener.h:
1984         * DOM/ObjCEventListener.mm:
1985         (WebCore::ObjCEventListener::handleEvent):
1986         * WebCoreSupport/WebFrameLoaderClient.mm:
1987         (NetscapePluginWidget::handleEvent):
1988
1989 2017-07-21  Brady Eidson  <beidson@apple.com>
1990
1991         Get rid of WebCore IconDatabase code.
1992         https://bugs.webkit.org/show_bug.cgi?id=174700
1993
1994         Reviewed by Tim Horton.
1995
1996         * Misc/WebCoreStatistics.mm:
1997         (+[WebCoreStatistics iconPageURLMappingCount]):
1998         (+[WebCoreStatistics iconRetainedPageURLCount]):
1999         (+[WebCoreStatistics iconRecordCount]):
2000         (+[WebCoreStatistics iconsWithDataCount]):
2001         * WebCoreSupport/WebFrameLoaderClient.h:
2002         * WebCoreSupport/WebFrameLoaderClient.mm:
2003         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2004         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2005         * WebView/WebView.mm:
2006         (-[WebView mainFrameIconURL]):
2007
2008 2017-07-20  Chris Dumez  <cdumez@apple.com>
2009
2010         Drop legacy XPathException type
2011         https://bugs.webkit.org/show_bug.cgi?id=174679
2012
2013         Reviewed by Sam Weinig.
2014
2015         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2016         no longer expose XPathException.
2017
2018         * DOM/ExceptionHandlers.mm:
2019         (raiseDOMErrorException):
2020
2021 2017-07-20  Chris Dumez  <cdumez@apple.com>
2022
2023         Unreviewed, rolling out r219706.
2024
2025         Broke iOS build
2026
2027         Reverted changeset:
2028
2029         "Drop legacy XPathException type"
2030         https://bugs.webkit.org/show_bug.cgi?id=174679
2031         http://trac.webkit.org/changeset/219706
2032
2033 2017-07-20  Chris Dumez  <cdumez@apple.com>
2034
2035         Drop legacy XPathException type
2036         https://bugs.webkit.org/show_bug.cgi?id=174679
2037
2038         Reviewed by Sam Weinig.
2039
2040         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2041         no longer expose XPathException.
2042
2043         * DOM/ExceptionHandlers.mm:
2044         (raiseDOMErrorException):
2045         * WebKit.exp:
2046
2047 2017-07-20  Chris Dumez  <cdumez@apple.com>
2048
2049         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2050         https://bugs.webkit.org/show_bug.cgi?id=174660
2051
2052         Reviewed by Geoffrey Garen.
2053
2054         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2055         This essentially replaces a branch to figure out if the new size is less or greater than the
2056         current size by an assertion.
2057
2058         * Plugins/WebNetscapePluginView.mm:
2059         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2060
2061 2017-07-20  Brady Eidson  <beidson@apple.com>
2062
2063         Deprecate WebIconDatabase in WebKitLegacy/mac.
2064         https://bugs.webkit.org/show_bug.cgi?id=174607
2065
2066         Reviewed by Alex Christensen.
2067
2068         This patch:
2069         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2070         2 - Guts the class to where it can only return the default icon at the small size
2071         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2072             use something else or to not do anything.
2073         
2074         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2075         and that patch will remove all of the last remnants of WebIconDatabase.
2076         
2077         * History/WebHistoryItem.mm:
2078         (-[WebHistoryItem icon]):
2079
2080         * Misc/WebIconDatabase.h:
2081         * Misc/WebIconDatabase.mm:
2082         (-[WebIconDatabase init]):
2083         (-[WebIconDatabase iconForURL:withSize:cache:]):
2084         (-[WebIconDatabase iconForURL:withSize:]):
2085         (-[WebIconDatabase defaultIconWithSize:]):
2086         (-[WebIconDatabase defaultIconForURL:withSize:]):
2087         (-[WebIconDatabase iconURLForURL:]):
2088         (-[WebIconDatabase retainIconForURL:]):
2089         (-[WebIconDatabase releaseIconForURL:]):
2090         (+[WebIconDatabase delayDatabaseCleanup]):
2091         (+[WebIconDatabase allowDatabaseCleanup]):
2092         (-[WebIconDatabase setDelegate:]):
2093         (-[WebIconDatabase delegate]):
2094         (+[WebIconDatabase initialize]): Deleted.
2095         (-[WebIconDatabase isEnabled]): Deleted.
2096         (-[WebIconDatabase setEnabled:]): Deleted.
2097         (-[WebIconDatabase removeAllIcons]): Deleted.
2098         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2099         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2100         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2101         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2102         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2103         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2104         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2105         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2106         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2107         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2108         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2109         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2110         (-[WebIconDatabase _databaseDirectory]): Deleted.
2111         (webGetNSImage): Deleted.
2112
2113         * Misc/WebIconDatabaseDelegate.h: Removed.
2114         * Misc/WebIconDatabaseInternal.h: Removed.
2115         * Misc/WebIconDatabasePrivate.h: Removed.
2116
2117         * WebCoreSupport/WebFrameLoaderClient.mm:
2118         (webGetNSImage):
2119
2120         * WebCoreSupport/WebIconDatabaseClient.mm:
2121         (WebIconDatabaseClient::didRemoveAllIcons):
2122         (WebIconDatabaseClient::didImportIconURLForPageURL):
2123
2124         * WebView/WebView.mm:
2125         (-[WebView setFrameLoadDelegate:]):
2126         (-[WebView mainFrameIcon]):
2127
2128 2017-07-18  Andy Estes  <aestes@apple.com>
2129
2130         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2131         https://bugs.webkit.org/show_bug.cgi?id=174631
2132
2133         Reviewed by Tim Horton.
2134
2135         * Configurations/Base.xcconfig:
2136
2137 2017-07-18  Andy Estes  <aestes@apple.com>
2138
2139         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2140         https://bugs.webkit.org/show_bug.cgi?id=174631
2141
2142         Reviewed by Sam Weinig.
2143
2144         * Configurations/Base.xcconfig:
2145
2146 2017-07-18  Andy Estes  <aestes@apple.com>
2147
2148         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2149         https://bugs.webkit.org/show_bug.cgi?id=174631
2150
2151         Reviewed by Dan Bernstein.
2152
2153         * Configurations/Base.xcconfig:
2154
2155 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2156
2157         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2158         https://bugs.webkit.org/show_bug.cgi?id=174640
2159         <rdar://problem/33297400>
2160
2161         Reviewed by Tim Horton.
2162
2163         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2164         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2165         web thread here, to match the other WebView drag and drop SPI methods.
2166
2167         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2168         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2169         should make this robust against future UIKit changes that could make this no longer the case.
2170
2171         * WebView/WebView.mm:
2172         (-[WebView _requestStartDataInteraction:globalPosition:]):
2173         (-[WebView _dataInteractionCaretRect]):
2174
2175 2017-07-18  Andy Estes  <aestes@apple.com>
2176
2177         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2178         https://bugs.webkit.org/show_bug.cgi?id=174631
2179
2180         Reviewed by Darin Adler.
2181
2182         * Configurations/Base.xcconfig:
2183
2184 2017-07-17  Sam Weinig  <sam@webkit.org>
2185
2186         [WebIDL] Remove custom bindings that require non-caching JS strings
2187         https://bugs.webkit.org/show_bug.cgi?id=174552
2188
2189         Reviewed by Darin Adler.
2190
2191         * DOM/DOMHTMLCanvasElement.mm:
2192         (-[DOMHTMLCanvasElement toDataURL:]):
2193         Update to account for implementation now returning an UncachedString.
2194
2195 2017-07-17  Darin Adler  <darin@apple.com>
2196
2197         Improve use of NeverDestroyed
2198         https://bugs.webkit.org/show_bug.cgi?id=174348
2199
2200         Reviewed by Sam Weinig.
2201
2202         * Misc/WebStringTruncator.mm:
2203         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2204         NeverDestroyed<RetainPtr> with just an NSFont * global.
2205
2206         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2207         NeverDestroyed.h.
2208         * Storage/WebDatabaseManager.mm: Ditto.
2209         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2210         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2211
2212         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2213         (aeDescFromJSValue): Removed double hashing by using the return value from
2214         add rather than calling contains before calling add.
2215
2216 2017-07-14  Jer Noble  <jer.noble@apple.com>
2217
2218         Allow clients to override their own hardware media requirements where no fallback media exists.
2219         https://bugs.webkit.org/show_bug.cgi?id=174426
2220         <rdar://problem/32537704>
2221
2222         Reviewed by Eric Carlson.
2223
2224         Add a new WebPreferences property to control WebCore's new
2225         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2226
2227         * WebView/WebPreferenceKeysPrivate.h:
2228         * WebView/WebPreferences.mm:
2229         (+[WebPreferences initialize]):
2230         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2231         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2232         * WebView/WebPreferencesPrivate.h:
2233         * WebView/WebView.mm:
2234         (-[WebView _preferencesChanged:]):
2235
2236 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2237
2238         Async image decoding for large images should be disabled by default
2239         https://bugs.webkit.org/show_bug.cgi?id=174432
2240
2241         Reviewed by Simon Fraser.
2242
2243         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2244         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2245         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2246            a child view instead of propagating PaintBehaviorSnapshotting.
2247         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2248            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2249
2250         * WebView/WebFrame.mm:
2251         (-[WebFrame _paintBehaviorForDestinationContext:]):
2252         (-[WebFrame _drawRect:contentsOnly:]):
2253         * WebView/WebHTMLView.mm:
2254         (imageFromRect):
2255
2256 2017-07-12  Daniel Bates  <dabates@apple.com>
2257
2258         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2259         https://bugs.webkit.org/show_bug.cgi?id=174427
2260
2261         Rubber-stamped by Brady Eidson.
2262
2263         * WebView/WebPDFView.mm:
2264         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2265
2266 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2267
2268         Unreviewed, rolling out r219401.
2269
2270         This revision rolled out the previous patch, but after talking
2271         with reviewer, a rebaseline is what was needed.Rolling back in
2272         before rebaseline.
2273
2274         Reverted changeset:
2275
2276         "Unreviewed, rolling out r219379."
2277         https://bugs.webkit.org/show_bug.cgi?id=174400
2278         http://trac.webkit.org/changeset/219401
2279
2280 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2281
2282         Unreviewed, rolling out r219379.
2283
2284         This revision caused a consistent failure in the test
2285         fast/dom/Window/property-access-on-cached-window-after-frame-
2286         removed.html.
2287
2288         Reverted changeset:
2289
2290         "Remove NAVIGATOR_HWCONCURRENCY"
2291         https://bugs.webkit.org/show_bug.cgi?id=174400
2292         http://trac.webkit.org/changeset/219379
2293
2294 2017-07-11  Dean Jackson  <dino@apple.com>
2295
2296         Remove NAVIGATOR_HWCONCURRENCY
2297         https://bugs.webkit.org/show_bug.cgi?id=174400
2298
2299         * Configurations/FeatureDefines.xcconfig:
2300
2301 2017-07-11  Dean Jackson  <dino@apple.com>
2302
2303         Rolling out r219372.
2304
2305         * Configurations/FeatureDefines.xcconfig:
2306
2307 2017-07-11  Dean Jackson  <dino@apple.com>
2308
2309         Remove NAVIGATOR_HWCONCURRENCY
2310         https://bugs.webkit.org/show_bug.cgi?id=174400
2311
2312         * Configurations/FeatureDefines.xcconfig:
2313
2314 2017-07-03  Brian Burg  <bburg@apple.com>
2315
2316         Web Replay: remove some unused code
2317         https://bugs.webkit.org/show_bug.cgi?id=173903
2318
2319         Rubber-stamped by Joseph Pecoraro.
2320
2321         * Configurations/FeatureDefines.xcconfig:
2322
2323 2017-07-09  Brady Eidson  <beidson@apple.com>
2324
2325         Remove some obsolete WebKitVersionChecks.
2326         https://bugs.webkit.org/show_bug.cgi?id=174294
2327
2328         Reviewed by Dan Bernstein.
2329
2330         * Misc/WebKitVersionChecks.h:
2331
2332         * WebView/WebHTMLView.mm:
2333         (-[WebHTMLView hitTest:]):
2334
2335         * WebView/WebView.mm:
2336         (shouldRespectPriorityInCSSAttributeSetters):
2337         (-[WebView _commonInitializationWithFrameName:groupName:]):
2338         (-[WebView _preferencesChanged:]):
2339         (shouldTransformsAffectOverflow): Deleted.
2340         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2341
2342 2017-07-08  Brady Eidson  <beidson@apple.com>
2343
2344         Remove some obsolete RuntimeApplicationChecks.
2345         https://bugs.webkit.org/show_bug.cgi?id=174293
2346
2347         Reviewed by Dan Bernstein.
2348
2349         * Misc/WebKitVersionChecks.h:
2350         * WebView/WebView.mm:
2351         (+[WebView enableWebThread]):
2352         (-[WebView _needsPreHTML5ParserQuirks]):
2353
2354 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2355
2356         Drop NOSNIFF compile flag
2357         https://bugs.webkit.org/show_bug.cgi?id=174289
2358
2359         Reviewed by Michael Catanzaro.
2360
2361         * Configurations/FeatureDefines.xcconfig:
2362
2363 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2364
2365         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2366         https://bugs.webkit.org/show_bug.cgi?id=174150
2367
2368         Reviewed by Mark Lam.
2369
2370         * DOM/DOM.mm:
2371         (lookupElementClass):
2372
2373 2017-07-06  Brady Eidson  <beidson@apple.com>
2374
2375         Add logging to first attempt to use the WebIconDatabase class.
2376         https://bugs.webkit.org/show_bug.cgi?id=174190
2377
2378         Reviewed by Andy Estes.
2379
2380         * Misc/WebIconDatabase.mm:
2381         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
2382         * Misc/WebKitVersionChecks.h:
2383
2384 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2385
2386         Unreviewed, rolling out r219178.
2387
2388         This caused a consistent failure with the API test
2389         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2390
2391         Reverted changeset:
2392
2393         "[WTF] Clean up StringStatics.cpp by using
2394         LazyNeverDestroyed<> for Atoms"
2395         https://bugs.webkit.org/show_bug.cgi?id=174150
2396         http://trac.webkit.org/changeset/219178
2397
2398 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2399
2400         [WTF] Move SoftLinking.h into WTF
2401         https://bugs.webkit.org/show_bug.cgi?id=174000
2402
2403         Reviewed by Alex Christensen.
2404
2405         * Plugins/WebNetscapePluginView.mm:
2406         * Plugins/WebPluginController.mm:
2407         * WebCoreSupport/WebInspectorClient.mm:
2408         * WebView/WebFullScreenController.mm:
2409         * WebView/WebImmediateActionController.mm:
2410         * WebView/WebView.mm:
2411
2412 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2413
2414         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2415         https://bugs.webkit.org/show_bug.cgi?id=174150
2416
2417         Reviewed by Mark Lam.
2418
2419         * DOM/DOM.mm:
2420         (lookupElementClass):
2421
2422 2017-07-05  Brady Eidson  <beidson@apple.com>
2423
2424         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2425         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2426
2427         Reviewed by Alex Christensen.
2428
2429         Adopt to the new constructor for FrameLoadRequest.
2430
2431         * WebView/WebPDFView.mm:
2432         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2433
2434 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2435
2436         Make WebKit's public headers on Mac and iOS C++ module safe
2437         https://bugs.webkit.org/show_bug.cgi?id=174175
2438
2439         Reviewed by Alex Christensen.
2440
2441         Fixed the header files.
2442
2443         * Misc/WebDownload.h:
2444         * Misc/WebKitErrors.h:
2445         * Plugins/WebPluginContainer.h:
2446         * WebView/WebResourceLoadDelegate.h:
2447
2448 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2449
2450         Remove copy of ICU headers from WebKit
2451         https://bugs.webkit.org/show_bug.cgi?id=116407
2452
2453         Reviewed by Alex Christensen.
2454
2455         Use WTF's copy of ICU headers.
2456
2457         * Configurations/WebKitLegacy.xcconfig:
2458         * icu/unicode/localpointer.h: Removed.
2459         * icu/unicode/parseerr.h: Removed.
2460         * icu/unicode/platform.h: Removed.
2461         * icu/unicode/ptypes.h: Removed.
2462         * icu/unicode/putil.h: Removed.
2463         * icu/unicode/uchar.h: Removed.
2464         * icu/unicode/uconfig.h: Removed.
2465         * icu/unicode/ucurr.h: Removed.
2466         * icu/unicode/uidna.h: Removed.
2467         * icu/unicode/uiter.h: Removed.
2468         * icu/unicode/umachine.h: Removed.
2469         * icu/unicode/unorm.h: Removed.
2470         * icu/unicode/unorm2.h: Removed.
2471         * icu/unicode/urename.h: Removed.
2472         * icu/unicode/uscript.h: Removed.
2473         * icu/unicode/ustring.h: Removed.
2474         * icu/unicode/utf.h: Removed.
2475         * icu/unicode/utf16.h: Removed.
2476         * icu/unicode/utf8.h: Removed.
2477         * icu/unicode/utf_old.h: Removed.
2478         * icu/unicode/utypes.h: Removed.
2479         * icu/unicode/uvernum.h: Removed.
2480         * icu/unicode/uversion.h: Removed.
2481
2482 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2483
2484         Add WebKitPrivateFrameworkStubs for iOS 11
2485         https://bugs.webkit.org/show_bug.cgi?id=173988
2486
2487         Reviewed by David Kilzer.
2488
2489         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
2490         use the same directory for private framework stubs.
2491
2492 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2493
2494         Unreviewed, rolling out r219103.
2495
2496         Caused multiple build failures.
2497
2498         Reverted changeset:
2499
2500         "Remove copy of ICU headers from WebKit"
2501         https://bugs.webkit.org/show_bug.cgi?id=116407
2502         http://trac.webkit.org/changeset/219103
2503
2504 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2505
2506         Remove copy of ICU headers from WebKit
2507         https://bugs.webkit.org/show_bug.cgi?id=116407
2508
2509         Reviewed by Alex Christensen.
2510
2511         Use WTF's copy of ICU headers.
2512
2513         * Configurations/WebKitLegacy.xcconfig:
2514         * icu/unicode/localpointer.h: Removed.
2515         * icu/unicode/parseerr.h: Removed.
2516         * icu/unicode/platform.h: Removed.
2517         * icu/unicode/ptypes.h: Removed.
2518         * icu/unicode/putil.h: Removed.
2519         * icu/unicode/uchar.h: Removed.
2520         * icu/unicode/uconfig.h: Removed.
2521         * icu/unicode/ucurr.h: Removed.
2522         * icu/unicode/uidna.h: Removed.
2523         * icu/unicode/uiter.h: Removed.
2524         * icu/unicode/umachine.h: Removed.
2525         * icu/unicode/unorm.h: Removed.
2526         * icu/unicode/unorm2.h: Removed.
2527         * icu/unicode/urename.h: Removed.
2528         * icu/unicode/uscript.h: Removed.
2529         * icu/unicode/ustring.h: Removed.
2530         * icu/unicode/utf.h: Removed.
2531         * icu/unicode/utf16.h: Removed.
2532         * icu/unicode/utf8.h: Removed.
2533         * icu/unicode/utf_old.h: Removed.
2534         * icu/unicode/utypes.h: Removed.
2535         * icu/unicode/uvernum.h: Removed.
2536         * icu/unicode/uversion.h: Removed.
2537
2538 2017-07-03  Brady Eidson  <beidson@apple.com>
2539
2540         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2541         https://bugs.webkit.org/show_bug.cgi?id=174073
2542
2543         Reviewed by Andy Estes.
2544
2545         WebView now keeps a direct copy of its main frame icon as a member variable.
2546         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
2547         
2548         This change causes a progression in KVO observation of the mainFrameIcon property as we now
2549         have both the old icon and new icon at the time it changes.
2550
2551         * WebCoreSupport/WebFrameLoaderClient.h:
2552         * WebCoreSupport/WebFrameLoaderClient.mm:
2553         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2554         (WebFrameLoaderClient::getLoadDecisionForIcons):
2555         (WebFrameLoaderClient::finishedLoadingIcon):
2556         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2557         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2558
2559         * WebView/WebView.mm:
2560         (+[WebView _setIconLoadingEnabled:]):
2561         (+[WebView _isIconLoadingEnabled]):
2562         (-[WebView mainFrameIcon]):
2563         (-[WebView _setMainFrameIcon:]):
2564         (-[WebView _receivedIconChangedNotification:]): Deleted.
2565         (-[WebView _registerForIconNotification:]): Deleted.
2566         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
2567         * WebView/WebViewData.h:
2568         * WebView/WebViewInternal.h:
2569         * WebView/WebViewPrivate.h:
2570
2571 2017-07-03  Sam Weinig  <sam@webkit.org>
2572
2573         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
2574         https://bugs.webkit.org/show_bug.cgi?id=174083
2575
2576         Reviewed by Alex Christensen.
2577
2578         * Configurations/FeatureDefines.xcconfig:
2579         Add ENABLE_NAVIGATOR_STANDALONE.
2580
2581 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2582
2583         Expose unobscuredSafeAreaInsets on WebView
2584         https://bugs.webkit.org/show_bug.cgi?id=174075
2585         <rdar://problem/33096997>
2586
2587         Reviewed by Beth Dakin.
2588
2589         * WebView/WebView.mm:
2590         (-[WebView _setUnobscuredSafeAreaInsets:]):
2591         (-[WebView _unobscuredSafeAreaInsets]):
2592         * WebView/WebViewPrivate.h:
2593         Expose unobscuredSafeAreaInsets as a new private property on WebView,
2594         similar to how it is exposed in WebKit2.
2595
2596 2017-07-03  Andy Estes  <aestes@apple.com>
2597
2598         [Xcode] Add an experimental setting to build with ccache
2599         https://bugs.webkit.org/show_bug.cgi?id=173875
2600
2601         Reviewed by Tim Horton.
2602
2603         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2604
2605 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2606
2607         Expose WebPreferences for viewport-fit and constant() properties
2608         https://bugs.webkit.org/show_bug.cgi?id=174072
2609         <rdar://problem/33096639>
2610
2611         Reviewed by Ryosuke Niwa.
2612
2613         * WebView/WebPreferenceKeysPrivate.h:
2614         * WebView/WebPreferences.mm:
2615         (-[WebPreferences viewportFitEnabled]):
2616         (-[WebPreferences setViewportFitEnabled:]):
2617         (-[WebPreferences constantPropertiesEnabled]):
2618         (-[WebPreferences setConstantPropertiesEnabled:]):
2619         * WebView/WebPreferencesPrivate.h:
2620         * WebView/WebView.mm:
2621         (-[WebView _preferencesChanged:]):
2622
2623 2017-07-01  Tim Horton  <timothy_horton@apple.com>
2624
2625         Expose viewport-fit value to UIKit via viewport arguments dictionary
2626         https://bugs.webkit.org/show_bug.cgi?id=174071
2627         <rdar://problem/33096620>
2628
2629         Reviewed by Wenson Hsieh.
2630
2631         * History/WebHistoryItem.mm:
2632         * History/WebHistoryItemPrivate.h:
2633         Add another dictionary key and three values.
2634
2635 2017-07-01  Dan Bernstein  <mitz@apple.com>
2636
2637         [iOS] Remove code only needed when building for iOS 9.x
2638         https://bugs.webkit.org/show_bug.cgi?id=174068
2639
2640         Reviewed by Tim Horton.
2641
2642         * Configurations/FeatureDefines.xcconfig:
2643
2644 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2645
2646         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2647         https://bugs.webkit.org/show_bug.cgi?id=174004
2648
2649         Reviewed by Simon Fraser.
2650
2651         * WebCoreSupport/WebPluginInfoProvider.mm:
2652
2653 2017-07-01  Dan Bernstein  <mitz@apple.com>
2654
2655         [macOS] Remove code only needed when building for OS X Yosemite
2656         https://bugs.webkit.org/show_bug.cgi?id=174067
2657
2658         Reviewed by Tim Horton.
2659
2660         * Configurations/Base.xcconfig:
2661         * Configurations/DebugRelease.xcconfig:
2662         * Configurations/FeatureDefines.xcconfig:
2663         * Configurations/Version.xcconfig:
2664         * Plugins/WebBasePluginPackage.mm:
2665         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2666         * WebCoreSupport/PopupMenuMac.mm:
2667         (PopupMenuMac::show):
2668         * WebCoreSupport/WebInspectorClient.mm:
2669         (WebInspectorFrontendClient::startWindowDrag):
2670         (-[WebInspectorWindowController window]):
2671         * WebView/WebView.mm:
2672         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2673
2674 2017-06-30  Daniel Bates  <dabates@apple.com>
2675
2676         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2677         https://bugs.webkit.org/show_bug.cgi?id=165160
2678         <rdar://problem/29451999>
2679
2680         Reviewed by Brady Eidson.
2681
2682         Pass the document that is requesting the load to the loader.
2683
2684         * WebView/WebPDFView.mm:
2685         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2686
2687 2017-06-29  Jer Noble  <jer.noble@apple.com>
2688
2689         Make Legacy EME API controlled by RuntimeEnabled setting.
2690         https://bugs.webkit.org/show_bug.cgi?id=173994
2691
2692         Reviewed by Sam Weinig.
2693
2694         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
2695
2696         * Configurations/FeatureDefines.xcconfig:
2697         * WebView/WebPreferenceKeysPrivate.h:
2698         * WebView/WebPreferences.mm:
2699         (+[WebPreferences initialize]):
2700         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
2701         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
2702         * WebView/WebPreferencesPrivate.h:
2703         * WebView/WebView.mm:
2704         (-[WebView _preferencesChanged:]):
2705
2706 2017-06-30  Chris Dumez  <cdumez@apple.com>
2707
2708         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
2709         https://bugs.webkit.org/show_bug.cgi?id=174013
2710
2711         Reviewed by Brent Fulgham.
2712
2713         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
2714         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
2715
2716         * WebView/WebView.mm:
2717         (-[WebView _commonInitializationWithFrameName:groupName:]):
2718
2719 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2720
2721         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2722         https://bugs.webkit.org/show_bug.cgi?id=174017
2723         <rdar://problem/32959782>
2724
2725         Reviewed by Simon Fraser.
2726
2727         Use root view coordinates when computing the drag caret rect.
2728
2729         * WebView/WebView.mm:
2730         (-[WebView _dataInteractionCaretRect]):
2731
2732 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2733
2734         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
2735         https://bugs.webkit.org/show_bug.cgi?id=173899
2736         rdar://problem/32994474
2737
2738         Reviewed by Tim Horton.
2739
2740         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
2741         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
2742         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
2743
2744         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
2745         documentView is a WebHTMLView.
2746
2747         * WebView/WebFrame.mm:
2748         (-[WebFrame _webHTMLDocumentView]):
2749         (-[WebFrame _paintBehaviorForDestinationContext:]):
2750         (-[WebFrame _drawRect:contentsOnly:]):
2751         (-[WebFrame setTimeoutsPaused:]):
2752         (-[WebFrame prepareForPause]):
2753         (-[WebFrame resumeFromPause]):
2754         (-[WebFrame resetTextAutosizingBeforeLayout]):
2755         * WebView/WebHTMLView.mm:
2756         (-[WebHTMLView drawLayer:inContext:]):
2757         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
2758         * WebView/WebHTMLViewInternal.h:
2759
2760 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2761
2762         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2763         https://bugs.webkit.org/show_bug.cgi?id=173854
2764         <rdar://problem/32236827>
2765
2766         Reviewed by Ryosuke Niwa and Tim Horton.
2767
2768         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
2769         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
2770
2771         * WebView/WebView.mm:
2772         (-[WebView _startDrag:]):
2773         (-[WebView _dragSourceAction]):
2774         (-[WebView _draggedLinkTitle]):
2775         (-[WebView _draggedLinkURL]):
2776         (-[WebView _draggedElementBounds]):
2777         (-[WebView _endedDataInteraction:global:]):
2778         * WebView/WebViewData.h:
2779         * WebView/WebViewPrivate.h:
2780
2781 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2782
2783         Refactor drag start codepaths to plumb a DragItem to client layers
2784         https://bugs.webkit.org/show_bug.cgi?id=173832
2785         Work towards <rdar://problem/32236827>
2786
2787         Reviewed by Ryosuke Niwa and Tim Horton.
2788
2789         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
2790         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
2791         to _startDrag: to match logic used to start a drag on other platforms.
2792
2793         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
2794         through the DragItem struct.
2795
2796         * WebCoreSupport/WebDragClient.h:
2797         * WebCoreSupport/WebDragClient.mm:
2798         (WebDragClient::startDrag):
2799         (WebDragClient::dragSourceActionMaskForPoint):
2800         (WebDragClient::willPerformDragSourceAction):
2801         (WebDragClient::beginDrag):
2802         * WebView/WebView.mm:
2803         (-[WebView _startDrag:]):
2804         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
2805         * WebView/WebViewInternal.h:
2806
2807 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2808
2809         Remove excessive headers from JavaScriptCore
2810         https://bugs.webkit.org/show_bug.cgi?id=173812
2811
2812         Reviewed by Darin Adler.
2813
2814         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2815         * WebView/WebView.mm:
2816
2817 2017-06-23  Tim Horton  <timothy_horton@apple.com>
2818
2819         Remove an unused typedef from WebFrameLoaderClient
2820         https://bugs.webkit.org/show_bug.cgi?id=173795
2821
2822         Reviewed by Simon Fraser.
2823
2824         * WebCoreSupport/WebFrameLoaderClient.h:
2825         This unused typedef in the global namespace conflicts with one in a macOS system header.
2826         Also... it's unused.
2827         Remove it.
2828
2829 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
2830
2831         Remove excessive headers from WebCore/{bindings,css,dom}
2832         https://bugs.webkit.org/show_bug.cgi?id=173766
2833
2834         Reviewed by Simon Fraser.
2835
2836         * DOM/DOMInternal.mm:
2837
2838 2017-06-22  Daniel Bates  <dabates@apple.com>
2839
2840         Make FrameLoadRequest a move-only type
2841         https://bugs.webkit.org/show_bug.cgi?id=173682
2842
2843         Reviewed by Alex Christensen and Darin Adler.
2844
2845         A FrameLoadRequest groups together the information to perform a load into a single object
2846         that is more manageable to pass around than its constituent parts. Code that receives a
2847         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2848         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2849         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2850
2851         * Plugins/WebPluginController.mm:
2852         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2853         * WebView/WebPDFView.mm:
2854         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2855
2856 2017-06-21  Antoine Quint  <graouts@apple.com>
2857
2858         Ensure DRT always logs rAF suspension debugging code
2859         https://bugs.webkit.org/show_bug.cgi?id=173681
2860
2861         Reviewed by Tim "Mr. T" Horton.
2862
2863         * WebView/WebPreferenceKeysPrivate.h:
2864         * WebView/WebPreferences.mm:
2865         (+[WebPreferences initialize]):
2866         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
2867         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
2868         * WebView/WebPreferencesPrivate.h:
2869         * WebView/WebView.mm:
2870         (-[WebView _preferencesChanged:]):
2871
2872 2017-06-21  Daniel Bates  <dabates@apple.com>
2873
2874         Cleanup FrameLoadRequest
2875         https://bugs.webkit.org/show_bug.cgi?id=173564
2876         <rdar://problem/32903570>
2877
2878         Reviewed by Brent Fulgham.
2879
2880         * WebView/WebPDFView.mm:
2881         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
2882         into a local variable and use C++11 brace initialization syntax to make it easier to identify
2883         the arguments passed to FrameLoader::loadFrameRequest().
2884
2885 2017-06-21  Antoine Quint  <graouts@apple.com>
2886
2887         Add logging to identify when the Page suspends scripted animations
2888         https://bugs.webkit.org/show_bug.cgi?id=173626
2889
2890         Reviewed by Tim Horton.
2891
2892         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
2893         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
2894
2895         * WebView/WebPreferenceKeysPrivate.h:
2896         * WebView/WebPreferences.mm:
2897         (+[WebPreferences initialize]):
2898         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
2899         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
2900         * WebView/WebPreferencesPrivate.h:
2901         * WebView/WebView.mm:
2902         (-[WebView _preferencesChanged:]):
2903
2904 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2905
2906         Disable font variations on macOS Sierra and iOS 10
2907         https://bugs.webkit.org/show_bug.cgi?id=173618
2908         <rdar://problem/32879164>
2909
2910         Reviewed by Jon Lee.
2911
2912         * Configurations/FeatureDefines.xcconfig:
2913
2914 2017-06-20  Daniel Bates  <dabates@apple.com>
2915
2916         Have FrameLoadRequest takes a Frame& instead of a Frame*
2917         https://bugs.webkit.org/show_bug.cgi?id=173614
2918         <rdar://problem/32884890>
2919
2920         Reviewed by Brent Fulgham.
2921
2922         * Plugins/WebPluginController.mm:
2923         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2924         * WebView/WebFrame.mm:
2925         (-[WebFrame loadRequest:]):
2926         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2927
2928 2017-06-19  Frederic Wang  <fwang@igalia.com>
2929
2930         [Mac] Add an experimental feature setting for async frame scrolling
2931         https://bugs.webkit.org/show_bug.cgi?id=173359
2932
2933         Reviewed by Simon Fraser.
2934
2935         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
2936         * WebView/WebPreferences.mm:
2937         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
2938         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
2939         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
2940         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
2941         * WebView/WebView.mm:
2942         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
2943         scrolling.
2944
2945 2017-06-19  Chris Dumez  <cdumez@apple.com>
2946
2947         Use WTF::Function instead of std::function in more places in WebCore/
2948         https://bugs.webkit.org/show_bug.cgi?id=173535
2949
2950         Reviewed by Antti Koivisto.
2951
2952         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2953
2954         * WebCoreSupport/WebFrameLoaderClient.h:
2955         * WebCoreSupport/WebFrameLoaderClient.mm:
2956         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2957         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2958         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2959         (WebFrameLoaderClient::dispatchWillSubmitForm):
2960         (WebFrameLoaderClient::setUpPolicyListener):
2961         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
2962         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
2963
2964 2017-05-14 Frederic Wang  <fwang@igalia.com>
2965
2966         Add heuristic to avoid flattening "fullscreen" iframes
2967         https://bugs.webkit.org/show_bug.cgi?id=171914
2968
2969         Reviewed by Simon Fraser.
2970
2971         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
2972
2973         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
2974         * WebView/WebPreferences.mm:
2975         (+[WebPreferences initialize]): Handle frame flattening as an enum.
2976         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
2977         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
2978         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
2979         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
2980         * WebView/WebPreferencesPrivate.h: Ditto.
2981         * WebView/WebView.mm:
2982         (-[WebView _preferencesChanged:]): Ditto.
2983         * WebView/WebPreferencesPrivate.h: Add new enum definition.
2984
2985 2017-06-17  Chris Dumez  <cdumez@apple.com>
2986
2987         Use WTF::Function instead of std::function in WebKit2/
2988         https://bugs.webkit.org/show_bug.cgi?id=173504
2989
2990         Reviewed by Darin Adler.
2991
2992         Use WTF::Function instead of std::function in WebKit2/ to avoid
2993         unnecessary copying.
2994
2995         * Plugins/Hosted/HostedNetscapePluginStream.h:
2996         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2997         (WebKit::HostedNetscapePluginStream::willSendRequest):
2998         * Plugins/WebNetscapePluginStream.h:
2999         * Plugins/WebNetscapePluginStream.mm:
3000         (WebNetscapePluginStream::willSendRequest):
3001         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3002         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3003         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3004         (WebPaymentCoordinatorClient::openPaymentSetup):
3005
3006 2017-06-16  Sam Weinig  <sam@webkit.org>
3007
3008         [WebIDL] Remove custom bindings for HTMLDocument
3009         https://bugs.webkit.org/show_bug.cgi?id=173444
3010
3011         Reviewed by Darin Adler.
3012
3013         * DOM/DOMHTMLDocument.mm:
3014         (-[DOMHTMLDocument linkColor]):
3015         (-[DOMHTMLDocument setLinkColor:]):
3016         (-[DOMHTMLDocument write:]):
3017         (-[DOMHTMLDocument writeln:]):
3018         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3019
3020 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3021
3022         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3023         https://bugs.webkit.org/show_bug.cgi?id=173366
3024         <rdar://problem/32767014>
3025
3026         Reviewed by Tim Horton.
3027
3028         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3029
3030         * Configurations/FeatureDefines.xcconfig:
3031         * WebCoreSupport/WebDragClient.mm:
3032         (WebDragClient::useLegacyDragClient):
3033         (WebDragClient::willPerformDragDestinationAction):
3034         (WebDragClient::dragSourceActionMaskForPoint):
3035         (WebDragClient::willPerformDragSourceAction):
3036         (WebDragClient::startDrag):
3037         (WebDragClient::beginDrag):
3038         (WebDragClient::declareAndWriteDragImage):
3039         (WebDragClient::declareAndWriteAttachment):
3040         (WebDragClient::didConcludeEditDrag):
3041         * WebView/WebView.mm:
3042         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3043         (-[WebView _getDataInteractionData]):
3044         (-[WebView dragDataForSession:client:global:operation:]):
3045         (-[WebView _enteredDataInteraction:client:global:operation:]):
3046         (-[WebView _updatedDataInteraction:client:global:operation:]):
3047         (-[WebView _exitedDataInteraction:client:global:operation:]):
3048         (-[WebView _performDataInteraction:client:global:operation:]):
3049         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3050         (-[WebView _endedDataInteraction:global:]):
3051         (-[WebView _didConcludeEditDataInteraction]):
3052         (floatRectsForCGRectArray): Deleted.
3053         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3054         * WebView/WebViewData.h:
3055         * WebView/WebViewData.mm:
3056         (-[WebViewPrivate dealloc]):
3057         * WebView/WebViewPrivate.h:
3058
3059 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3060
3061         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3062         https://bugs.webkit.org/show_bug.cgi?id=173454
3063         <rdar://problem/31720671>
3064
3065         Reviewed by Tim Horton.
3066
3067         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3068         If unimplemented, the default UI delegate allows all actions except for URL loading.
3069
3070         * DefaultDelegates/WebDefaultUIDelegate.mm:
3071         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3072         * WebView/WebUIDelegatePrivate.h:
3073         * WebView/WebView.mm:
3074         (-[WebView dragDestinationActionMaskForSession:]):
3075
3076 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3079         https://bugs.webkit.org/show_bug.cgi?id=173338
3080         <rdar://problem/32777720>
3081
3082         Reviewed by Tim Horton.
3083
3084         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3085
3086         * WebCoreSupport/WebPlatformStrategies.h:
3087         * WebCoreSupport/WebPlatformStrategies.mm:
3088         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3089         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3090
3091 2017-06-13  Daniel Bates  <dabates@apple.com>
3092
3093         Implement W3C Secure Contexts Draft Specification
3094         https://bugs.webkit.org/show_bug.cgi?id=158121
3095         <rdar://problem/26012994>
3096
3097         Reviewed by Brent Fulgham.
3098
3099         Part 4
3100
3101         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3102
3103         * WebView/WebPreferenceKeysPrivate.h:
3104         * WebView/WebPreferences.mm:
3105         (+[WebPreferences initialize]):
3106         (-[WebPreferences isSecureContextAttributeEnabled]):
3107         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3108         * WebView/WebPreferencesPrivate.h:
3109         * WebView/WebView.mm:
3110         (-[WebView _preferencesChanged:]):
3111
3112 2017-06-13  Sam Weinig  <sam@webkit.org>
3113
3114         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3115         https://bugs.webkit.org/show_bug.cgi?id=80733
3116
3117         Reviewed by Chris Dumez.
3118
3119         * DOM/DOMUtility.mm:
3120         (createDOMWrapper):
3121         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3122         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3123         * WebView/WebFrame.mm:
3124         (-[WebFrame _attachScriptDebugger]):
3125         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3126
3127 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3128
3129         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3130         https://bugs.webkit.org/show_bug.cgi?id=173197
3131         <rdar://problem/32688148>
3132
3133         Reviewed by Brent Fulgham.
3134
3135         * WebView/WebPreferences.mm:
3136         (+[WebPreferences initialize]):
3137         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3138         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3139         * WebView/WebPreferencesPrivate.h:
3140         * WebView/WebView.mm:
3141         (-[WebView _preferencesChanged:]):
3142
3143 2017-06-10  Dan Bernstein  <mitz@apple.com>
3144
3145         Reverted r218056 because it made the IDE reindex constantly.
3146
3147         * Configurations/DebugRelease.xcconfig:
3148
3149 2017-06-10  Dan Bernstein  <mitz@apple.com>
3150
3151         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3152         https://bugs.webkit.org/show_bug.cgi?id=173223
3153
3154         Reviewed by Sam Weinig.
3155
3156         The rebuilds were happening due to a difference in the compiler options that the IDE and
3157         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3158         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3159         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3160
3161         * Configurations/DebugRelease.xcconfig:
3162
3163 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3164
3165         [iOS DnD] Add a hook to perform two-step drops in editable content
3166         https://bugs.webkit.org/show_bug.cgi?id=172992
3167         <rdar://problem/32590174>
3168
3169         Reviewed by Tim Horton.
3170
3171         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
3172         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
3173         returning NO will continue with default WebKit behavior.
3174
3175         * WebCoreSupport/WebEditorClient.h:
3176         * WebCoreSupport/WebEditorClient.mm:
3177         (WebEditorClient::performTwoStepDrop):
3178
3179 2017-06-08  Jer Noble  <jer.noble@apple.com>
3180
3181         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
3182         https://bugs.webkit.org/show_bug.cgi?id=173091
3183
3184         Reviewed by Eric Carlson.
3185
3186         * WebView/WebPreferences.mm:
3187         (+[WebPreferences initialize]):
3188
3189 2017-06-07  Jer Noble  <jer.noble@apple.com>
3190
3191         Clean-up: RenderElement.h includes headers it doesn't use
3192         https://bugs.webkit.org/show_bug.cgi?id=173046
3193
3194         Reviewed by Andy Estes.
3195
3196         * WebView/WebImmediateActionController.mm:
3197
3198 2017-06-07  Zalan Bujtas  <zalan@apple.com>
3199
3200         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
3201         https://bugs.webkit.org/show_bug.cgi?id=173044
3202         <rdar://problem/32449338>
3203
3204         Reviewed by Tim Horton.
3205
3206         Cache the current device orientation so that we don't have to lift the WebThread lock
3207         to collect it.
3208
3209         * WebView/WebFrame.mm:
3210         (-[WebFrame deviceOrientationChanged]):
3211         * WebView/WebView.mm:
3212         (-[WebView _commonInitializationWithFrameName:groupName:]):
3213         (-[WebView _setDeviceOrientation:]):
3214         (-[WebView _deviceOrientation]):
3215         * WebView/WebViewData.h:
3216         * WebView/WebViewInternal.h:
3217
3218 2017-06-06  Jer Noble  <jer.noble@apple.com>
3219
3220         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
3221         https://bugs.webkit.org/show_bug.cgi?id=173008
3222
3223         Reviewed by Eric Carlson.
3224
3225         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
3226
3227         * WebView/WebPreferenceKeysPrivate.h:
3228         * WebView/WebPreferences.mm:
3229         (+[WebPreferences initialize]):
3230         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3231         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3232         * WebView/WebPreferencesPrivate.h:
3233         * WebView/WebView.mm:
3234         (-[WebView _preferencesChanged:]):
3235
3236 2017-06-06  Youenn Fablet  <youenn@apple.com>
3237
3238         Add an option to disable getUserMedia prompt in case of mock capture sources
3239         https://bugs.webkit.org/show_bug.cgi?id=172981
3240         <rdar://problem/32580325>
3241
3242         Reviewed by Eric Carlson.
3243
3244         Defining the option, getter and setter.
3245
3246         * WebView/WebPreferences.mm:
3247         (+[WebPreferences initialize]):
3248         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
3249         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
3250         * WebView/WebPreferencesPrivate.h:
3251
3252 2017-06-05  Dan Bernstein  <mitz@apple.com>
3253
3254         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
3255
3256         * WebView/WebView.mm:
3257         (-[WebView updateMediaTouchBar]):
3258         * WebView/WebViewData.h:
3259
3260 2017-06-03  Darin Adler  <darin@apple.com>
3261
3262         Streamline handling of attributes, using references as much as possible
3263         https://bugs.webkit.org/show_bug.cgi?id=172899
3264
3265         Reviewed by Chris Dumez.
3266
3267         * WebView/WebHTMLRepresentation.mm:
3268         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
3269         passed in element can't be null. Removed unnecessary conversion from NSString to String
3270         and then back to NSString.
3271
3272 2017-06-01  Andy Estes  <aestes@apple.com>
3273
3274         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3275         https://bugs.webkit.org/show_bug.cgi?id=172828
3276
3277         Reviewed by Beth Dakin.
3278
3279         * Configurations/FeatureDefines.xcconfig:
3280
3281 2017-05-31  Andy Estes  <aestes@apple.com>
3282
3283         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3284         https://bugs.webkit.org/show_bug.cgi?id=172366
3285
3286         Reviewed by Daniel Bates.
3287
3288         * Configurations/FeatureDefines.xcconfig:
3289
3290 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3291
3292         Only include DataDetectorsUI headers in iOS
3293         https://bugs.webkit.org/show_bug.cgi?id=172633
3294
3295         Reviewed by David Kilzer.
3296
3297         Enable data detectors only on iOS and not other variants of iOS.
3298
3299         * WebCoreSupport/WebFrameLoaderClient.mm:
3300
3301 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3302
3303         Update libwebrtc configuration
3304         https://bugs.webkit.org/show_bug.cgi?id=172727
3305
3306         Reviewed by Geoffrey Garen.
3307
3308         * Configurations/FeatureDefines.xcconfig:
3309
3310 2017-05-28  Dan Bernstein  <mitz@apple.com>
3311
3312         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
3313         https://bugs.webkit.org/show_bug.cgi?id=172691
3314
3315         Reviewed by Tim Horton.
3316
3317         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
3318
3319 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
3320
3321         [WK2] Address thread safety issues with ResourceLoadStatistics
3322         https://bugs.webkit.org/show_bug.cgi?id=172519
3323         <rdar://problem/31707642>
3324
3325         Reviewed by Chris Dumez.
3326
3327         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
3328
3329         * WebView/WebView.mm:
3330         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
3331
3332 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3333
3334         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3335         https://bugs.webkit.org/show_bug.cgi?id=172554
3336         <rdar://problem/31247133>
3337
3338         Reviewed by Simon Fraser.
3339
3340         Update an overridden internal AppKit function to the new signature.
3341
3342         * WebView/WebHTMLView.mm:
3343         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
3344         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3345         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
3346         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
3347
3348 2017-05-24  Jer Noble  <jer.noble@apple.com>
3349
3350         Rename DisplaySleepDisabler -> SleepDisabler
3351         https://bugs.webkit.org/show_bug.cgi?id=172478
3352
3353         Reviewed by Sam Weinig.
3354
3355         * WebView/WebFullScreenController.h:
3356
3357 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3358
3359         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3360         https://bugs.webkit.org/show_bug.cgi?id=172522
3361         rdar://problem/31071812
3362
3363         Reviewed by Tim Horton.
3364
3365         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
3366         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
3367         versions this synchronization is no longer required.
3368
3369         * WebView/WebView.mm:
3370         (LayerFlushController::flushLayers):
3371
3372 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3373
3374         Snapshotting via -renderInContext: should do synchronous image decodes
3375         https://bugs.webkit.org/show_bug.cgi?id=172485
3376         rdar://problem/32276146
3377
3378         Reviewed by Tim Horton.
3379
3380         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
3381         has any callers.
3382
3383         * Plugins/WebBaseNetscapePluginView.h:
3384         * Plugins/WebBaseNetscapePluginView.mm:
3385         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
3386         * WebView/WebFrame.mm:
3387         (-[WebFrame _paintBehaviorForDestinationContext:]):
3388         (-[WebFrame _drawRect:contentsOnly:]):
3389         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
3390         * WebView/WebHTMLView.mm:
3391         (imageFromRect):
3392         * WebView/WebView.mm:
3393         (-[WebView _commonInitializationWithFrameName:groupName:]):
3394         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
3395         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
3396         * WebView/WebViewData.h:
3397         * WebView/WebViewPrivate.h:
3398
3399 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3400
3401         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3402         https://bugs.webkit.org/show_bug.cgi?id=172517
3403
3404         Rubber-stamped by Simon Fraser.
3405
3406         * Configurations/FeatureDefines.xcconfig:
3407
3408 2017-05-23  Emilio Cobos Ãlvarez  <ecobos@igalia.com>
3409
3410         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3411         https://bugs.webkit.org/show_bug.cgi?id=171984
3412
3413         Reviewed by Antti Koivisto.
3414
3415         * WebView/WebPreferenceKeysPrivate.h:
3416         * WebView/WebPreferences.mm:
3417         (+[WebPreferences initialize]):
3418         (-[WebPreferences displayContentsEnabled]):
3419         (-[WebPreferences setDisplayContentsEnabled:]):
3420         * WebView/WebPreferencesPrivate.h:
3421         * WebView/WebView.mm:
3422         (-[WebView _preferencesChanged:]):
3423
3424 2017-05-22  Youenn Fablet  <youenn@apple.com>
3425
3426         Remove AVAudioCaptureSource
3427         https://bugs.webkit.org/show_bug.cgi?id=172360
3428
3429         Reviewed by Sam Weinig.
3430
3431         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
3432
3433         * WebView/WebPreferenceKeysPrivate.h:
3434         * WebView/WebPreferences.mm:
3435         (+[WebPreferences initialize]):
3436         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
3437         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
3438         * WebView/WebPreferencesPrivate.h:
3439         * WebView/WebView.mm:
3440         (-[WebView _preferencesChanged:]):
3441
3442 2017-05-22  Sam Weinig  <sam@webkit.org>
3443
3444         [WebIDL] Support callbacks with arbitrary return types
3445         https://bugs.webkit.org/show_bug.cgi?id=172407
3446
3447         Reviewed by Chris Dumez.
3448
3449         * DOM/DOM.mm:
3450         (-[DOMNodeFilter acceptNode:]):
3451         Update for CallbackResult adoption in the base class.
3452
3453         * DOM/DOMNodeIterator.mm:
3454         * DOM/DOMTreeWalker.mm:
3455         Update to account for new WebCore implementation return types. We return nil
3456         if there was an exception, since retains the existing behavior if a javascript
3457         NodeFilter had been used (an exception would cause all nodes to be rejected,
3458         thus returning nullptr).
3459
3460         * DOM/ObjCNodeFilterCondition.h:
3461         * DOM/ObjCNodeFilterCondition.mm:
3462         Update to match new interface of NodeFilterCondition.
3463
3464 2017-05-18  Sam Weinig  <sam@webkit.org>
3465
3466         [WebIDL] Remove the need for the generator to know about native type mapping
3467         https://bugs.webkit.org/show_bug.cgi?id=172310
3468
3469         Reviewed by Darin Adler.
3470
3471         * DOM/DOM.mm:
3472         (-[DOMNodeFilter acceptNode:]):
3473         Update to pass Node by reference.
3474
3475 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3476
3477         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
3478         https://bugs.webkit.org/show_bug.cgi?id=172098
3479
3480         Reviewed by Saam Barati.
3481
3482         * Plugins/Hosted/ProxyInstance.mm:
3483         * Plugins/Hosted/ProxyRuntimeObject.mm:
3484
3485 2017-05-18  Andy Estes  <aestes@apple.com>
3486
3487         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3488         https://bugs.webkit.org/show_bug.cgi?id=172305
3489
3490         Reviewed by Anders Carlsson.
3491
3492         * Configurations/FeatureDefines.xcconfig:
3493
3494 2017-05-18  Commit Queue  <commit-queue@webkit.org>
3495
3496