5b8ec21cfd78de09d87929f5ba698f089e5ddeaf
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2
3         Async image decoding for large images should be disabled by default
4         https://bugs.webkit.org/show_bug.cgi?id=174432
5
6         Reviewed by Simon Fraser.
7
8         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
9         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
10         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
11            a child view instead of propagating PaintBehaviorSnapshotting.
12         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
13            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
14
15         * WebView/WebFrame.mm:
16         (-[WebFrame _paintBehaviorForDestinationContext:]):
17         (-[WebFrame _drawRect:contentsOnly:]):
18         * WebView/WebHTMLView.mm:
19         (imageFromRect):
20
21 2017-07-12  Daniel Bates  <dabates@apple.com>
22
23         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
24         https://bugs.webkit.org/show_bug.cgi?id=174427
25
26         Rubber-stamped by Brady Eidson.
27
28         * WebView/WebPDFView.mm:
29         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
30
31 2017-07-12  Matt Lewis  <jlewis3@apple.com>
32
33         Unreviewed, rolling out r219401.
34
35         This revision rolled out the previous patch, but after talking
36         with reviewer, a rebaseline is what was needed.Rolling back in
37         before rebaseline.
38
39         Reverted changeset:
40
41         "Unreviewed, rolling out r219379."
42         https://bugs.webkit.org/show_bug.cgi?id=174400
43         http://trac.webkit.org/changeset/219401
44
45 2017-07-12  Matt Lewis  <jlewis3@apple.com>
46
47         Unreviewed, rolling out r219379.
48
49         This revision caused a consistent failure in the test
50         fast/dom/Window/property-access-on-cached-window-after-frame-
51         removed.html.
52
53         Reverted changeset:
54
55         "Remove NAVIGATOR_HWCONCURRENCY"
56         https://bugs.webkit.org/show_bug.cgi?id=174400
57         http://trac.webkit.org/changeset/219379
58
59 2017-07-11  Dean Jackson  <dino@apple.com>
60
61         Remove NAVIGATOR_HWCONCURRENCY
62         https://bugs.webkit.org/show_bug.cgi?id=174400
63
64         * Configurations/FeatureDefines.xcconfig:
65
66 2017-07-11  Dean Jackson  <dino@apple.com>
67
68         Rolling out r219372.
69
70         * Configurations/FeatureDefines.xcconfig:
71
72 2017-07-11  Dean Jackson  <dino@apple.com>
73
74         Remove NAVIGATOR_HWCONCURRENCY
75         https://bugs.webkit.org/show_bug.cgi?id=174400
76
77         * Configurations/FeatureDefines.xcconfig:
78
79 2017-07-03  Brian Burg  <bburg@apple.com>
80
81         Web Replay: remove some unused code
82         https://bugs.webkit.org/show_bug.cgi?id=173903
83
84         Rubber-stamped by Joseph Pecoraro.
85
86         * Configurations/FeatureDefines.xcconfig:
87
88 2017-07-09  Brady Eidson  <beidson@apple.com>
89
90         Remove some obsolete WebKitVersionChecks.
91         https://bugs.webkit.org/show_bug.cgi?id=174294
92
93         Reviewed by Dan Bernstein.
94
95         * Misc/WebKitVersionChecks.h:
96
97         * WebView/WebHTMLView.mm:
98         (-[WebHTMLView hitTest:]):
99
100         * WebView/WebView.mm:
101         (shouldRespectPriorityInCSSAttributeSetters):
102         (-[WebView _commonInitializationWithFrameName:groupName:]):
103         (-[WebView _preferencesChanged:]):
104         (shouldTransformsAffectOverflow): Deleted.
105         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
106
107 2017-07-08  Brady Eidson  <beidson@apple.com>
108
109         Remove some obsolete RuntimeApplicationChecks.
110         https://bugs.webkit.org/show_bug.cgi?id=174293
111
112         Reviewed by Dan Bernstein.
113
114         * Misc/WebKitVersionChecks.h:
115         * WebView/WebView.mm:
116         (+[WebView enableWebThread]):
117         (-[WebView _needsPreHTML5ParserQuirks]):
118
119 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
120
121         Drop NOSNIFF compile flag
122         https://bugs.webkit.org/show_bug.cgi?id=174289
123
124         Reviewed by Michael Catanzaro.
125
126         * Configurations/FeatureDefines.xcconfig:
127
128 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
129
130         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
131         https://bugs.webkit.org/show_bug.cgi?id=174150
132
133         Reviewed by Mark Lam.
134
135         * DOM/DOM.mm:
136         (lookupElementClass):
137
138 2017-07-06  Brady Eidson  <beidson@apple.com>
139
140         Add logging to first attempt to use the WebIconDatabase class.
141         https://bugs.webkit.org/show_bug.cgi?id=174190
142
143         Reviewed by Andy Estes.
144
145         * Misc/WebIconDatabase.mm:
146         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
147         * Misc/WebKitVersionChecks.h:
148
149 2017-07-06  Matt Lewis  <jlewis3@apple.com>
150
151         Unreviewed, rolling out r219178.
152
153         This caused a consistent failure with the API test
154         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
155
156         Reverted changeset:
157
158         "[WTF] Clean up StringStatics.cpp by using
159         LazyNeverDestroyed<> for Atoms"
160         https://bugs.webkit.org/show_bug.cgi?id=174150
161         http://trac.webkit.org/changeset/219178
162
163 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
164
165         [WTF] Move SoftLinking.h into WTF
166         https://bugs.webkit.org/show_bug.cgi?id=174000
167
168         Reviewed by Alex Christensen.
169
170         * Plugins/WebNetscapePluginView.mm:
171         * Plugins/WebPluginController.mm:
172         * WebCoreSupport/WebInspectorClient.mm:
173         * WebView/WebFullScreenController.mm:
174         * WebView/WebImmediateActionController.mm:
175         * WebView/WebView.mm:
176
177 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
178
179         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
180         https://bugs.webkit.org/show_bug.cgi?id=174150
181
182         Reviewed by Mark Lam.
183
184         * DOM/DOM.mm:
185         (lookupElementClass):
186
187 2017-07-05  Brady Eidson  <beidson@apple.com>
188
189         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
190         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
191
192         Reviewed by Alex Christensen.
193
194         Adopt to the new constructor for FrameLoadRequest.
195
196         * WebView/WebPDFView.mm:
197         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
198
199 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
200
201         Make WebKit's public headers on Mac and iOS C++ module safe
202         https://bugs.webkit.org/show_bug.cgi?id=174175
203
204         Reviewed by Alex Christensen.
205
206         Fixed the header files.
207
208         * Misc/WebDownload.h:
209         * Misc/WebKitErrors.h:
210         * Plugins/WebPluginContainer.h:
211         * WebView/WebResourceLoadDelegate.h:
212
213 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
214
215         Remove copy of ICU headers from WebKit
216         https://bugs.webkit.org/show_bug.cgi?id=116407
217
218         Reviewed by Alex Christensen.
219
220         Use WTF's copy of ICU headers.
221
222         * Configurations/WebKitLegacy.xcconfig:
223         * icu/unicode/localpointer.h: Removed.
224         * icu/unicode/parseerr.h: Removed.
225         * icu/unicode/platform.h: Removed.
226         * icu/unicode/ptypes.h: Removed.
227         * icu/unicode/putil.h: Removed.
228         * icu/unicode/uchar.h: Removed.
229         * icu/unicode/uconfig.h: Removed.
230         * icu/unicode/ucurr.h: Removed.
231         * icu/unicode/uidna.h: Removed.
232         * icu/unicode/uiter.h: Removed.
233         * icu/unicode/umachine.h: Removed.
234         * icu/unicode/unorm.h: Removed.
235         * icu/unicode/unorm2.h: Removed.
236         * icu/unicode/urename.h: Removed.
237         * icu/unicode/uscript.h: Removed.
238         * icu/unicode/ustring.h: Removed.
239         * icu/unicode/utf.h: Removed.
240         * icu/unicode/utf16.h: Removed.
241         * icu/unicode/utf8.h: Removed.
242         * icu/unicode/utf_old.h: Removed.
243         * icu/unicode/utypes.h: Removed.
244         * icu/unicode/uvernum.h: Removed.
245         * icu/unicode/uversion.h: Removed.
246
247 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
248
249         Add WebKitPrivateFrameworkStubs for iOS 11
250         https://bugs.webkit.org/show_bug.cgi?id=173988
251
252         Reviewed by David Kilzer.
253
254         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
255         use the same directory for private framework stubs.
256
257 2017-07-03  Matt Lewis  <jlewis3@apple.com>
258
259         Unreviewed, rolling out r219103.
260
261         Caused multiple build failures.
262
263         Reverted changeset:
264
265         "Remove copy of ICU headers from WebKit"
266         https://bugs.webkit.org/show_bug.cgi?id=116407
267         http://trac.webkit.org/changeset/219103
268
269 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
270
271         Remove copy of ICU headers from WebKit
272         https://bugs.webkit.org/show_bug.cgi?id=116407
273
274         Reviewed by Alex Christensen.
275
276         Use WTF's copy of ICU headers.
277
278         * Configurations/WebKitLegacy.xcconfig:
279         * icu/unicode/localpointer.h: Removed.
280         * icu/unicode/parseerr.h: Removed.
281         * icu/unicode/platform.h: Removed.
282         * icu/unicode/ptypes.h: Removed.
283         * icu/unicode/putil.h: Removed.
284         * icu/unicode/uchar.h: Removed.
285         * icu/unicode/uconfig.h: Removed.
286         * icu/unicode/ucurr.h: Removed.
287         * icu/unicode/uidna.h: Removed.
288         * icu/unicode/uiter.h: Removed.
289         * icu/unicode/umachine.h: Removed.
290         * icu/unicode/unorm.h: Removed.
291         * icu/unicode/unorm2.h: Removed.
292         * icu/unicode/urename.h: Removed.
293         * icu/unicode/uscript.h: Removed.
294         * icu/unicode/ustring.h: Removed.
295         * icu/unicode/utf.h: Removed.
296         * icu/unicode/utf16.h: Removed.
297         * icu/unicode/utf8.h: Removed.
298         * icu/unicode/utf_old.h: Removed.
299         * icu/unicode/utypes.h: Removed.
300         * icu/unicode/uvernum.h: Removed.
301         * icu/unicode/uversion.h: Removed.
302
303 2017-07-03  Brady Eidson  <beidson@apple.com>
304
305         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
306         https://bugs.webkit.org/show_bug.cgi?id=174073
307
308         Reviewed by Andy Estes.
309
310         WebView now keeps a direct copy of its main frame icon as a member variable.
311         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
312         
313         This change causes a progression in KVO observation of the mainFrameIcon property as we now
314         have both the old icon and new icon at the time it changes.
315
316         * WebCoreSupport/WebFrameLoaderClient.h:
317         * WebCoreSupport/WebFrameLoaderClient.mm:
318         (WebFrameLoaderClient::prepareForDataSourceReplacement):
319         (WebFrameLoaderClient::getLoadDecisionForIcons):
320         (WebFrameLoaderClient::finishedLoadingIcon):
321         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
322         (WebFrameLoaderClient::registerForIconNotification): Deleted.
323
324         * WebView/WebView.mm:
325         (+[WebView _setIconLoadingEnabled:]):
326         (+[WebView _isIconLoadingEnabled]):
327         (-[WebView mainFrameIcon]):
328         (-[WebView _setMainFrameIcon:]):
329         (-[WebView _receivedIconChangedNotification:]): Deleted.
330         (-[WebView _registerForIconNotification:]): Deleted.
331         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
332         * WebView/WebViewData.h:
333         * WebView/WebViewInternal.h:
334         * WebView/WebViewPrivate.h:
335
336 2017-07-03  Sam Weinig  <sam@webkit.org>
337
338         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
339         https://bugs.webkit.org/show_bug.cgi?id=174083
340
341         Reviewed by Alex Christensen.
342
343         * Configurations/FeatureDefines.xcconfig:
344         Add ENABLE_NAVIGATOR_STANDALONE.
345
346 2017-07-03  Tim Horton  <timothy_horton@apple.com>
347
348         Expose unobscuredSafeAreaInsets on WebView
349         https://bugs.webkit.org/show_bug.cgi?id=174075
350         <rdar://problem/33096997>
351
352         Reviewed by Beth Dakin.
353
354         * WebView/WebView.mm:
355         (-[WebView _setUnobscuredSafeAreaInsets:]):
356         (-[WebView _unobscuredSafeAreaInsets]):
357         * WebView/WebViewPrivate.h:
358         Expose unobscuredSafeAreaInsets as a new private property on WebView,
359         similar to how it is exposed in WebKit2.
360
361 2017-07-03  Andy Estes  <aestes@apple.com>
362
363         [Xcode] Add an experimental setting to build with ccache
364         https://bugs.webkit.org/show_bug.cgi?id=173875
365
366         Reviewed by Tim Horton.
367
368         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
369
370 2017-07-03  Tim Horton  <timothy_horton@apple.com>
371
372         Expose WebPreferences for viewport-fit and constant() properties
373         https://bugs.webkit.org/show_bug.cgi?id=174072
374         <rdar://problem/33096639>
375
376         Reviewed by Ryosuke Niwa.
377
378         * WebView/WebPreferenceKeysPrivate.h:
379         * WebView/WebPreferences.mm:
380         (-[WebPreferences viewportFitEnabled]):
381         (-[WebPreferences setViewportFitEnabled:]):
382         (-[WebPreferences constantPropertiesEnabled]):
383         (-[WebPreferences setConstantPropertiesEnabled:]):
384         * WebView/WebPreferencesPrivate.h:
385         * WebView/WebView.mm:
386         (-[WebView _preferencesChanged:]):
387
388 2017-07-01  Tim Horton  <timothy_horton@apple.com>
389
390         Expose viewport-fit value to UIKit via viewport arguments dictionary
391         https://bugs.webkit.org/show_bug.cgi?id=174071
392         <rdar://problem/33096620>
393
394         Reviewed by Wenson Hsieh.
395
396         * History/WebHistoryItem.mm:
397         * History/WebHistoryItemPrivate.h:
398         Add another dictionary key and three values.
399
400 2017-07-01  Dan Bernstein  <mitz@apple.com>
401
402         [iOS] Remove code only needed when building for iOS 9.x
403         https://bugs.webkit.org/show_bug.cgi?id=174068
404
405         Reviewed by Tim Horton.
406
407         * Configurations/FeatureDefines.xcconfig:
408
409 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
410
411         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
412         https://bugs.webkit.org/show_bug.cgi?id=174004
413
414         Reviewed by Simon Fraser.
415
416         * WebCoreSupport/WebPluginInfoProvider.mm:
417
418 2017-07-01  Dan Bernstein  <mitz@apple.com>
419
420         [macOS] Remove code only needed when building for OS X Yosemite
421         https://bugs.webkit.org/show_bug.cgi?id=174067
422
423         Reviewed by Tim Horton.
424
425         * Configurations/Base.xcconfig:
426         * Configurations/DebugRelease.xcconfig:
427         * Configurations/FeatureDefines.xcconfig:
428         * Configurations/Version.xcconfig:
429         * Plugins/WebBasePluginPackage.mm:
430         (-[WebBasePluginPackage getPluginInfoFromPLists]):
431         * WebCoreSupport/PopupMenuMac.mm:
432         (PopupMenuMac::show):
433         * WebCoreSupport/WebInspectorClient.mm:
434         (WebInspectorFrontendClient::startWindowDrag):
435         (-[WebInspectorWindowController window]):
436         * WebView/WebView.mm:
437         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
438
439 2017-06-30  Daniel Bates  <dabates@apple.com>
440
441         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
442         https://bugs.webkit.org/show_bug.cgi?id=165160
443         <rdar://problem/29451999>
444
445         Reviewed by Brady Eidson.
446
447         Pass the document that is requesting the load to the loader.
448
449         * WebView/WebPDFView.mm:
450         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
451
452 2017-06-29  Jer Noble  <jer.noble@apple.com>
453
454         Make Legacy EME API controlled by RuntimeEnabled setting.
455         https://bugs.webkit.org/show_bug.cgi?id=173994
456
457         Reviewed by Sam Weinig.
458
459         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
460
461         * Configurations/FeatureDefines.xcconfig:
462         * WebView/WebPreferenceKeysPrivate.h:
463         * WebView/WebPreferences.mm:
464         (+[WebPreferences initialize]):
465         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
466         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
467         * WebView/WebPreferencesPrivate.h:
468         * WebView/WebView.mm:
469         (-[WebView _preferencesChanged:]):
470
471 2017-06-30  Chris Dumez  <cdumez@apple.com>
472
473         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
474         https://bugs.webkit.org/show_bug.cgi?id=174013
475
476         Reviewed by Brent Fulgham.
477
478         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
479         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
480
481         * WebView/WebView.mm:
482         (-[WebView _commonInitializationWithFrameName:groupName:]):
483
484 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
485
486         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
487         https://bugs.webkit.org/show_bug.cgi?id=174017
488         <rdar://problem/32959782>
489
490         Reviewed by Simon Fraser.
491
492         Use root view coordinates when computing the drag caret rect.
493
494         * WebView/WebView.mm:
495         (-[WebView _dataInteractionCaretRect]):
496
497 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
498
499         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
500         https://bugs.webkit.org/show_bug.cgi?id=173899
501         rdar://problem/32994474
502
503         Reviewed by Tim Horton.
504
505         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
506         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
507         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
508
509         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
510         documentView is a WebHTMLView.
511
512         * WebView/WebFrame.mm:
513         (-[WebFrame _webHTMLDocumentView]):
514         (-[WebFrame _paintBehaviorForDestinationContext:]):
515         (-[WebFrame _drawRect:contentsOnly:]):
516         (-[WebFrame setTimeoutsPaused:]):
517         (-[WebFrame prepareForPause]):
518         (-[WebFrame resumeFromPause]):
519         (-[WebFrame resetTextAutosizingBeforeLayout]):
520         * WebView/WebHTMLView.mm:
521         (-[WebHTMLView drawLayer:inContext:]):
522         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
523         * WebView/WebHTMLViewInternal.h:
524
525 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
526
527         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
528         https://bugs.webkit.org/show_bug.cgi?id=173854
529         <rdar://problem/32236827>
530
531         Reviewed by Ryosuke Niwa and Tim Horton.
532
533         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
534         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
535
536         * WebView/WebView.mm:
537         (-[WebView _startDrag:]):
538         (-[WebView _dragSourceAction]):
539         (-[WebView _draggedLinkTitle]):
540         (-[WebView _draggedLinkURL]):
541         (-[WebView _draggedElementBounds]):
542         (-[WebView _endedDataInteraction:global:]):
543         * WebView/WebViewData.h:
544         * WebView/WebViewPrivate.h:
545
546 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
547
548         Refactor drag start codepaths to plumb a DragItem to client layers
549         https://bugs.webkit.org/show_bug.cgi?id=173832
550         Work towards <rdar://problem/32236827>
551
552         Reviewed by Ryosuke Niwa and Tim Horton.
553
554         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
555         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
556         to _startDrag: to match logic used to start a drag on other platforms.
557
558         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
559         through the DragItem struct.
560
561         * WebCoreSupport/WebDragClient.h:
562         * WebCoreSupport/WebDragClient.mm:
563         (WebDragClient::startDrag):
564         (WebDragClient::dragSourceActionMaskForPoint):
565         (WebDragClient::willPerformDragSourceAction):
566         (WebDragClient::beginDrag):
567         * WebView/WebView.mm:
568         (-[WebView _startDrag:]):
569         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
570         * WebView/WebViewInternal.h:
571
572 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
573
574         Remove excessive headers from JavaScriptCore
575         https://bugs.webkit.org/show_bug.cgi?id=173812
576
577         Reviewed by Darin Adler.
578
579         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
580         * WebView/WebView.mm:
581
582 2017-06-23  Tim Horton  <timothy_horton@apple.com>
583
584         Remove an unused typedef from WebFrameLoaderClient
585         https://bugs.webkit.org/show_bug.cgi?id=173795
586
587         Reviewed by Simon Fraser.
588
589         * WebCoreSupport/WebFrameLoaderClient.h:
590         This unused typedef in the global namespace conflicts with one in a macOS system header.
591         Also... it's unused.
592         Remove it.
593
594 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
595
596         Remove excessive headers from WebCore/{bindings,css,dom}
597         https://bugs.webkit.org/show_bug.cgi?id=173766
598
599         Reviewed by Simon Fraser.
600
601         * DOM/DOMInternal.mm:
602
603 2017-06-22  Daniel Bates  <dabates@apple.com>
604
605         Make FrameLoadRequest a move-only type
606         https://bugs.webkit.org/show_bug.cgi?id=173682
607
608         Reviewed by Alex Christensen and Darin Adler.
609
610         A FrameLoadRequest groups together the information to perform a load into a single object
611         that is more manageable to pass around than its constituent parts. Code that receives a
612         FrameLoadRequest is expected to extract out the information it needs to complete its task.
613         And it does not make sense to re-use the same FrameLoadRequest object for more than one
614         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
615
616         * Plugins/WebPluginController.mm:
617         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
618         * WebView/WebPDFView.mm:
619         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
620
621 2017-06-21  Antoine Quint  <graouts@apple.com>
622
623         Ensure DRT always logs rAF suspension debugging code
624         https://bugs.webkit.org/show_bug.cgi?id=173681
625
626         Reviewed by Tim "Mr. T" Horton.
627
628         * WebView/WebPreferenceKeysPrivate.h:
629         * WebView/WebPreferences.mm:
630         (+[WebPreferences initialize]):
631         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
632         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
633         * WebView/WebPreferencesPrivate.h:
634         * WebView/WebView.mm:
635         (-[WebView _preferencesChanged:]):
636
637 2017-06-21  Daniel Bates  <dabates@apple.com>
638
639         Cleanup FrameLoadRequest
640         https://bugs.webkit.org/show_bug.cgi?id=173564
641         <rdar://problem/32903570>
642
643         Reviewed by Brent Fulgham.
644
645         * WebView/WebPDFView.mm:
646         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
647         into a local variable and use C++11 brace initialization syntax to make it easier to identify
648         the arguments passed to FrameLoader::loadFrameRequest().
649
650 2017-06-21  Antoine Quint  <graouts@apple.com>
651
652         Add logging to identify when the Page suspends scripted animations
653         https://bugs.webkit.org/show_bug.cgi?id=173626
654
655         Reviewed by Tim Horton.
656
657         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
658         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
659
660         * WebView/WebPreferenceKeysPrivate.h:
661         * WebView/WebPreferences.mm:
662         (+[WebPreferences initialize]):
663         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
664         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
665         * WebView/WebPreferencesPrivate.h:
666         * WebView/WebView.mm:
667         (-[WebView _preferencesChanged:]):
668
669 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
670
671         Disable font variations on macOS Sierra and iOS 10
672         https://bugs.webkit.org/show_bug.cgi?id=173618
673         <rdar://problem/32879164>
674
675         Reviewed by Jon Lee.
676
677         * Configurations/FeatureDefines.xcconfig:
678
679 2017-06-20  Daniel Bates  <dabates@apple.com>
680
681         Have FrameLoadRequest takes a Frame& instead of a Frame*
682         https://bugs.webkit.org/show_bug.cgi?id=173614
683         <rdar://problem/32884890>
684
685         Reviewed by Brent Fulgham.
686
687         * Plugins/WebPluginController.mm:
688         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
689         * WebView/WebFrame.mm:
690         (-[WebFrame loadRequest:]):
691         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
692
693 2017-06-19  Frederic Wang  <fwang@igalia.com>
694
695         [Mac] Add an experimental feature setting for async frame scrolling
696         https://bugs.webkit.org/show_bug.cgi?id=173359
697
698         Reviewed by Simon Fraser.
699
700         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
701         * WebView/WebPreferences.mm:
702         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
703         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
704         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
705         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
706         * WebView/WebView.mm:
707         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
708         scrolling.
709
710 2017-06-19  Chris Dumez  <cdumez@apple.com>
711
712         Use WTF::Function instead of std::function in more places in WebCore/
713         https://bugs.webkit.org/show_bug.cgi?id=173535
714
715         Reviewed by Antti Koivisto.
716
717         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
718
719         * WebCoreSupport/WebFrameLoaderClient.h:
720         * WebCoreSupport/WebFrameLoaderClient.mm:
721         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
722         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
723         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
724         (WebFrameLoaderClient::dispatchWillSubmitForm):
725         (WebFrameLoaderClient::setUpPolicyListener):
726         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
727         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
728
729 2017-05-14 Frederic Wang  <fwang@igalia.com>
730
731         Add heuristic to avoid flattening "fullscreen" iframes
732         https://bugs.webkit.org/show_bug.cgi?id=171914
733
734         Reviewed by Simon Fraser.
735
736         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
737
738         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
739         * WebView/WebPreferences.mm:
740         (+[WebPreferences initialize]): Handle frame flattening as an enum.
741         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
742         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
743         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
744         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
745         * WebView/WebPreferencesPrivate.h: Ditto.
746         * WebView/WebView.mm:
747         (-[WebView _preferencesChanged:]): Ditto.
748         * WebView/WebPreferencesPrivate.h: Add new enum definition.
749
750 2017-06-17  Chris Dumez  <cdumez@apple.com>
751
752         Use WTF::Function instead of std::function in WebKit2/
753         https://bugs.webkit.org/show_bug.cgi?id=173504
754
755         Reviewed by Darin Adler.
756
757         Use WTF::Function instead of std::function in WebKit2/ to avoid
758         unnecessary copying.
759
760         * Plugins/Hosted/HostedNetscapePluginStream.h:
761         * Plugins/Hosted/HostedNetscapePluginStream.mm:
762         (WebKit::HostedNetscapePluginStream::willSendRequest):
763         * Plugins/WebNetscapePluginStream.h:
764         * Plugins/WebNetscapePluginStream.mm:
765         (WebNetscapePluginStream::willSendRequest):
766         * WebCoreSupport/WebPaymentCoordinatorClient.h:
767         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
768         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
769         (WebPaymentCoordinatorClient::openPaymentSetup):
770
771 2017-06-16  Sam Weinig  <sam@webkit.org>
772
773         [WebIDL] Remove custom bindings for HTMLDocument
774         https://bugs.webkit.org/show_bug.cgi?id=173444
775
776         Reviewed by Darin Adler.
777
778         * DOM/DOMHTMLDocument.mm:
779         (-[DOMHTMLDocument linkColor]):
780         (-[DOMHTMLDocument setLinkColor:]):
781         (-[DOMHTMLDocument write:]):
782         (-[DOMHTMLDocument writeln:]):
783         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
784
785 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
786
787         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
788         https://bugs.webkit.org/show_bug.cgi?id=173366
789         <rdar://problem/32767014>
790
791         Reviewed by Tim Horton.
792
793         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
794
795         * Configurations/FeatureDefines.xcconfig:
796         * WebCoreSupport/WebDragClient.mm:
797         (WebDragClient::useLegacyDragClient):
798         (WebDragClient::willPerformDragDestinationAction):
799         (WebDragClient::dragSourceActionMaskForPoint):
800         (WebDragClient::willPerformDragSourceAction):
801         (WebDragClient::startDrag):
802         (WebDragClient::beginDrag):
803         (WebDragClient::declareAndWriteDragImage):
804         (WebDragClient::declareAndWriteAttachment):
805         (WebDragClient::didConcludeEditDrag):
806         * WebView/WebView.mm:
807         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
808         (-[WebView _getDataInteractionData]):
809         (-[WebView dragDataForSession:client:global:operation:]):
810         (-[WebView _enteredDataInteraction:client:global:operation:]):
811         (-[WebView _updatedDataInteraction:client:global:operation:]):
812         (-[WebView _exitedDataInteraction:client:global:operation:]):
813         (-[WebView _performDataInteraction:client:global:operation:]):
814         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
815         (-[WebView _endedDataInteraction:global:]):
816         (-[WebView _didConcludeEditDataInteraction]):
817         (floatRectsForCGRectArray): Deleted.
818         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
819         * WebView/WebViewData.h:
820         * WebView/WebViewData.mm:
821         (-[WebViewPrivate dealloc]):
822         * WebView/WebViewPrivate.h:
823
824 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
827         https://bugs.webkit.org/show_bug.cgi?id=173454
828         <rdar://problem/31720671>
829
830         Reviewed by Tim Horton.
831
832         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
833         If unimplemented, the default UI delegate allows all actions except for URL loading.
834
835         * DefaultDelegates/WebDefaultUIDelegate.mm:
836         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
837         * WebView/WebUIDelegatePrivate.h:
838         * WebView/WebView.mm:
839         (-[WebView dragDestinationActionMaskForSession:]):
840
841 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
842
843         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
844         https://bugs.webkit.org/show_bug.cgi?id=173338
845         <rdar://problem/32777720>
846
847         Reviewed by Tim Horton.
848
849         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
850
851         * WebCoreSupport/WebPlatformStrategies.h:
852         * WebCoreSupport/WebPlatformStrategies.mm:
853         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
854         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
855
856 2017-06-13  Daniel Bates  <dabates@apple.com>
857
858         Implement W3C Secure Contexts Draft Specification
859         https://bugs.webkit.org/show_bug.cgi?id=158121
860         <rdar://problem/26012994>
861
862         Reviewed by Brent Fulgham.
863
864         Part 4
865
866         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
867
868         * WebView/WebPreferenceKeysPrivate.h:
869         * WebView/WebPreferences.mm:
870         (+[WebPreferences initialize]):
871         (-[WebPreferences isSecureContextAttributeEnabled]):
872         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
873         * WebView/WebPreferencesPrivate.h:
874         * WebView/WebView.mm:
875         (-[WebView _preferencesChanged:]):
876
877 2017-06-13  Sam Weinig  <sam@webkit.org>
878
879         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
880         https://bugs.webkit.org/show_bug.cgi?id=80733
881
882         Reviewed by Chris Dumez.
883
884         * DOM/DOMUtility.mm:
885         (createDOMWrapper):
886         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
887         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
888         * WebView/WebFrame.mm:
889         (-[WebFrame _attachScriptDebugger]):
890         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
891
892 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
893
894         [WebCrypto] Remove experimental feature flag of SubtleCrypto
895         https://bugs.webkit.org/show_bug.cgi?id=173197
896         <rdar://problem/32688148>
897
898         Reviewed by Brent Fulgham.
899
900         * WebView/WebPreferences.mm:
901         (+[WebPreferences initialize]):
902         (-[WebPreferences subtleCryptoEnabled]): Deleted.
903         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
904         * WebView/WebPreferencesPrivate.h:
905         * WebView/WebView.mm:
906         (-[WebView _preferencesChanged:]):
907
908 2017-06-10  Dan Bernstein  <mitz@apple.com>
909
910         Reverted r218056 because it made the IDE reindex constantly.
911
912         * Configurations/DebugRelease.xcconfig:
913
914 2017-06-10  Dan Bernstein  <mitz@apple.com>
915
916         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
917         https://bugs.webkit.org/show_bug.cgi?id=173223
918
919         Reviewed by Sam Weinig.
920
921         The rebuilds were happening due to a difference in the compiler options that the IDE and
922         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
923         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
924         specify an appropriate path in CLANG_INDEX_STORE_PATH.
925
926         * Configurations/DebugRelease.xcconfig:
927
928 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
929
930         [iOS DnD] Add a hook to perform two-step drops in editable content
931         https://bugs.webkit.org/show_bug.cgi?id=172992
932         <rdar://problem/32590174>
933
934         Reviewed by Tim Horton.
935
936         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
937         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
938         returning NO will continue with default WebKit behavior.
939
940         * WebCoreSupport/WebEditorClient.h:
941         * WebCoreSupport/WebEditorClient.mm:
942         (WebEditorClient::performTwoStepDrop):
943
944 2017-06-08  Jer Noble  <jer.noble@apple.com>
945
946         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
947         https://bugs.webkit.org/show_bug.cgi?id=173091
948
949         Reviewed by Eric Carlson.
950
951         * WebView/WebPreferences.mm:
952         (+[WebPreferences initialize]):
953
954 2017-06-07  Jer Noble  <jer.noble@apple.com>
955
956         Clean-up: RenderElement.h includes headers it doesn't use
957         https://bugs.webkit.org/show_bug.cgi?id=173046
958
959         Reviewed by Andy Estes.
960
961         * WebView/WebImmediateActionController.mm:
962
963 2017-06-07  Zalan Bujtas  <zalan@apple.com>
964
965         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
966         https://bugs.webkit.org/show_bug.cgi?id=173044
967         <rdar://problem/32449338>
968
969         Reviewed by Tim Horton.
970
971         Cache the current device orientation so that we don't have to lift the WebThread lock
972         to collect it.
973
974         * WebView/WebFrame.mm:
975         (-[WebFrame deviceOrientationChanged]):
976         * WebView/WebView.mm:
977         (-[WebView _commonInitializationWithFrameName:groupName:]):
978         (-[WebView _setDeviceOrientation:]):
979         (-[WebView _deviceOrientation]):
980         * WebView/WebViewData.h:
981         * WebView/WebViewInternal.h:
982
983 2017-06-06  Jer Noble  <jer.noble@apple.com>
984
985         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
986         https://bugs.webkit.org/show_bug.cgi?id=173008
987
988         Reviewed by Eric Carlson.
989
990         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
991
992         * WebView/WebPreferenceKeysPrivate.h:
993         * WebView/WebPreferences.mm:
994         (+[WebPreferences initialize]):
995         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
996         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
997         * WebView/WebPreferencesPrivate.h:
998         * WebView/WebView.mm:
999         (-[WebView _preferencesChanged:]):
1000
1001 2017-06-06  Youenn Fablet  <youenn@apple.com>
1002
1003         Add an option to disable getUserMedia prompt in case of mock capture sources
1004         https://bugs.webkit.org/show_bug.cgi?id=172981
1005         <rdar://problem/32580325>
1006
1007         Reviewed by Eric Carlson.
1008
1009         Defining the option, getter and setter.
1010
1011         * WebView/WebPreferences.mm:
1012         (+[WebPreferences initialize]):
1013         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
1014         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
1015         * WebView/WebPreferencesPrivate.h:
1016
1017 2017-06-05  Dan Bernstein  <mitz@apple.com>
1018
1019         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
1020
1021         * WebView/WebView.mm:
1022         (-[WebView updateMediaTouchBar]):
1023         * WebView/WebViewData.h:
1024
1025 2017-06-03  Darin Adler  <darin@apple.com>
1026
1027         Streamline handling of attributes, using references as much as possible
1028         https://bugs.webkit.org/show_bug.cgi?id=172899
1029
1030         Reviewed by Chris Dumez.
1031
1032         * WebView/WebHTMLRepresentation.mm:
1033         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
1034         passed in element can't be null. Removed unnecessary conversion from NSString to String
1035         and then back to NSString.
1036
1037 2017-06-01  Andy Estes  <aestes@apple.com>
1038
1039         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1040         https://bugs.webkit.org/show_bug.cgi?id=172828
1041
1042         Reviewed by Beth Dakin.
1043
1044         * Configurations/FeatureDefines.xcconfig:
1045
1046 2017-05-31  Andy Estes  <aestes@apple.com>
1047
1048         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1049         https://bugs.webkit.org/show_bug.cgi?id=172366
1050
1051         Reviewed by Daniel Bates.
1052
1053         * Configurations/FeatureDefines.xcconfig:
1054
1055 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1056
1057         Only include DataDetectorsUI headers in iOS
1058         https://bugs.webkit.org/show_bug.cgi?id=172633
1059
1060         Reviewed by David Kilzer.
1061
1062         Enable data detectors only on iOS and not other variants of iOS.
1063
1064         * WebCoreSupport/WebFrameLoaderClient.mm:
1065
1066 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1067
1068         Update libwebrtc configuration
1069         https://bugs.webkit.org/show_bug.cgi?id=172727
1070
1071         Reviewed by Geoffrey Garen.
1072
1073         * Configurations/FeatureDefines.xcconfig:
1074
1075 2017-05-28  Dan Bernstein  <mitz@apple.com>
1076
1077         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1078         https://bugs.webkit.org/show_bug.cgi?id=172691
1079
1080         Reviewed by Tim Horton.
1081
1082         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1083
1084 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
1085
1086         [WK2] Address thread safety issues with ResourceLoadStatistics
1087         https://bugs.webkit.org/show_bug.cgi?id=172519
1088         <rdar://problem/31707642>
1089
1090         Reviewed by Chris Dumez.
1091
1092         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
1093
1094         * WebView/WebView.mm:
1095         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
1096
1097 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1098
1099         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1100         https://bugs.webkit.org/show_bug.cgi?id=172554
1101         <rdar://problem/31247133>
1102
1103         Reviewed by Simon Fraser.
1104
1105         Update an overridden internal AppKit function to the new signature.
1106
1107         * WebView/WebHTMLView.mm:
1108         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
1109         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1110         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
1111         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1112
1113 2017-05-24  Jer Noble  <jer.noble@apple.com>
1114
1115         Rename DisplaySleepDisabler -> SleepDisabler
1116         https://bugs.webkit.org/show_bug.cgi?id=172478
1117
1118         Reviewed by Sam Weinig.
1119
1120         * WebView/WebFullScreenController.h:
1121
1122 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
1123
1124         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
1125         https://bugs.webkit.org/show_bug.cgi?id=172522
1126         rdar://problem/31071812
1127
1128         Reviewed by Tim Horton.
1129
1130         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
1131         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
1132         versions this synchronization is no longer required.
1133
1134         * WebView/WebView.mm:
1135         (LayerFlushController::flushLayers):
1136
1137 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
1138
1139         Snapshotting via -renderInContext: should do synchronous image decodes
1140         https://bugs.webkit.org/show_bug.cgi?id=172485
1141         rdar://problem/32276146
1142
1143         Reviewed by Tim Horton.
1144
1145         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
1146         has any callers.
1147
1148         * Plugins/WebBaseNetscapePluginView.h:
1149         * Plugins/WebBaseNetscapePluginView.mm:
1150         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
1151         * WebView/WebFrame.mm:
1152         (-[WebFrame _paintBehaviorForDestinationContext:]):
1153         (-[WebFrame _drawRect:contentsOnly:]):
1154         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
1155         * WebView/WebHTMLView.mm:
1156         (imageFromRect):
1157         * WebView/WebView.mm:
1158         (-[WebView _commonInitializationWithFrameName:groupName:]):
1159         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
1160         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
1161         * WebView/WebViewData.h:
1162         * WebView/WebViewPrivate.h:
1163
1164 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
1165
1166         Remove dead ENABLE(FONT_LOAD_EVENTS) code
1167         https://bugs.webkit.org/show_bug.cgi?id=172517
1168
1169         Rubber-stamped by Simon Fraser.
1170
1171         * Configurations/FeatureDefines.xcconfig:
1172
1173 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1174
1175         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1176         https://bugs.webkit.org/show_bug.cgi?id=171984
1177
1178         Reviewed by Antti Koivisto.
1179
1180         * WebView/WebPreferenceKeysPrivate.h:
1181         * WebView/WebPreferences.mm:
1182         (+[WebPreferences initialize]):
1183         (-[WebPreferences displayContentsEnabled]):
1184         (-[WebPreferences setDisplayContentsEnabled:]):
1185         * WebView/WebPreferencesPrivate.h:
1186         * WebView/WebView.mm:
1187         (-[WebView _preferencesChanged:]):
1188
1189 2017-05-22  Youenn Fablet  <youenn@apple.com>
1190
1191         Remove AVAudioCaptureSource
1192         https://bugs.webkit.org/show_bug.cgi?id=172360
1193
1194         Reviewed by Sam Weinig.
1195
1196         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1197
1198         * WebView/WebPreferenceKeysPrivate.h:
1199         * WebView/WebPreferences.mm:
1200         (+[WebPreferences initialize]):
1201         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1202         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1203         * WebView/WebPreferencesPrivate.h:
1204         * WebView/WebView.mm:
1205         (-[WebView _preferencesChanged:]):
1206
1207 2017-05-22  Sam Weinig  <sam@webkit.org>
1208
1209         [WebIDL] Support callbacks with arbitrary return types
1210         https://bugs.webkit.org/show_bug.cgi?id=172407
1211
1212         Reviewed by Chris Dumez.
1213
1214         * DOM/DOM.mm:
1215         (-[DOMNodeFilter acceptNode:]):
1216         Update for CallbackResult adoption in the base class.
1217
1218         * DOM/DOMNodeIterator.mm:
1219         * DOM/DOMTreeWalker.mm:
1220         Update to account for new WebCore implementation return types. We return nil
1221         if there was an exception, since retains the existing behavior if a javascript
1222         NodeFilter had been used (an exception would cause all nodes to be rejected,
1223         thus returning nullptr).
1224
1225         * DOM/ObjCNodeFilterCondition.h:
1226         * DOM/ObjCNodeFilterCondition.mm:
1227         Update to match new interface of NodeFilterCondition.
1228
1229 2017-05-18  Sam Weinig  <sam@webkit.org>
1230
1231         [WebIDL] Remove the need for the generator to know about native type mapping
1232         https://bugs.webkit.org/show_bug.cgi?id=172310
1233
1234         Reviewed by Darin Adler.
1235
1236         * DOM/DOM.mm:
1237         (-[DOMNodeFilter acceptNode:]):
1238         Update to pass Node by reference.
1239
1240 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1241
1242         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1243         https://bugs.webkit.org/show_bug.cgi?id=172098
1244
1245         Reviewed by Saam Barati.
1246
1247         * Plugins/Hosted/ProxyInstance.mm:
1248         * Plugins/Hosted/ProxyRuntimeObject.mm:
1249
1250 2017-05-18  Andy Estes  <aestes@apple.com>
1251
1252         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1253         https://bugs.webkit.org/show_bug.cgi?id=172305
1254
1255         Reviewed by Anders Carlsson.
1256
1257         * Configurations/FeatureDefines.xcconfig:
1258
1259 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1260
1261         Unreviewed, rolling out r217031, r217032, and r217037.
1262         https://bugs.webkit.org/show_bug.cgi?id=172293
1263
1264         cause linking errors in Windows (Requested by yusukesuzuki on
1265         #webkit).
1266
1267         Reverted changesets:
1268
1269         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1270         https://bugs.webkit.org/show_bug.cgi?id=172098
1271         http://trac.webkit.org/changeset/217031
1272
1273         "Unreviewed, rebaseline for newly added ClassInfo"
1274         https://bugs.webkit.org/show_bug.cgi?id=172098
1275         http://trac.webkit.org/changeset/217032
1276
1277         "Unreviewed, fix debug and non-JIT build"
1278         https://bugs.webkit.org/show_bug.cgi?id=172098
1279         http://trac.webkit.org/changeset/217037
1280
1281 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1282
1283         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1284         https://bugs.webkit.org/show_bug.cgi?id=172098
1285
1286         Reviewed by Saam Barati.
1287
1288         * Plugins/Hosted/ProxyInstance.mm:
1289         * Plugins/Hosted/ProxyRuntimeObject.mm:
1290
1291 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1292
1293         Unreviewed, rolling out r216974.
1294
1295         Revision caused consistent timeouts on all platforms.
1296
1297         Reverted changeset:
1298
1299         "Add a RuntimeEnabledFeature for display: contents, defaulted
1300         to false."
1301         https://bugs.webkit.org/show_bug.cgi?id=171984
1302         http://trac.webkit.org/changeset/216974
1303
1304 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1305
1306         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1307         https://bugs.webkit.org/show_bug.cgi?id=171984
1308
1309         Reviewed by Antti Koivisto.
1310
1311         * WebView/WebPreferenceKeysPrivate.h:
1312         * WebView/WebPreferences.mm:
1313         (+[WebPreferences initialize]):
1314         (-[WebPreferences displayContentsEnabled]):
1315         (-[WebPreferences setDisplayContentsEnabled:]):
1316         * WebView/WebPreferencesPrivate.h:
1317         * WebView/WebView.mm:
1318         (-[WebView _preferencesChanged:]):
1319
1320 2017-05-16  Sam Weinig  <sam@webkit.org>
1321
1322         Bring Notification.idl up to spec
1323         https://bugs.webkit.org/show_bug.cgi?id=172156
1324
1325         Reviewed by Chris Dumez.
1326
1327         * WebCoreSupport/WebNotificationClient.h:
1328         * WebCoreSupport/WebNotificationClient.mm:
1329         (generateNotificationID):
1330         (WebNotificationClient::show):
1331         (WebNotificationClient::cancel):
1332         (WebNotificationClient::clearNotifications):
1333         (WebNotificationClient::notificationObjectDestroyed):
1334         (WebNotificationClient::requestPermission):
1335         (WebNotificationClient::hasPendingPermissionRequests):
1336         (WebNotificationClient::checkPermission):
1337         (-[WebNotificationPolicyListener allow]):
1338         (-[WebNotificationPolicyListener deny]):
1339         * WebView/WebNotification.mm:
1340         (-[WebNotification iconURL]):
1341         (-[WebNotification dir]):
1342         Simplify #ifdefs and update for enum vs String usage.
1343
1344 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1345
1346         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1347         https://bugs.webkit.org/show_bug.cgi?id=170640
1348
1349         Reviewed by Simon Fraser.
1350
1351         Enable the async decoding for large images.
1352
1353         * WebView/WebView.mm:
1354         (-[WebView _preferencesChanged:]):
1355
1356 2017-05-15  Jer Noble  <jer.noble@apple.com>
1357
1358         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1359         https://bugs.webkit.org/show_bug.cgi?id=172131
1360
1361         Reviewed by Eric Carlson.
1362
1363         * WebView/WebPreferenceKeysPrivate.h:
1364         * WebView/WebPreferences.mm:
1365         (+[WebPreferences initialize]):
1366         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1367         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1368         * WebView/WebPreferencesPrivate.h:
1369
1370 2017-05-12  Chris Dumez  <cdumez@apple.com>
1371
1372         Drop uses of PassRefPtr in WebKit/mac
1373         https://bugs.webkit.org/show_bug.cgi?id=172066
1374
1375         Reviewed by Sam Weinig.
1376
1377         * History/WebBackForwardListInternal.h:
1378         * History/WebHistoryItem.mm:
1379         (kit):
1380         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1381         * History/WebHistoryItemInternal.h:
1382         * Plugins/Hosted/HostedNetscapePluginStream.h:
1383         (WebKit::HostedNetscapePluginStream::create):
1384         * Plugins/Hosted/NetscapePluginHostManager.h:
1385         * Plugins/Hosted/NetscapePluginHostManager.mm:
1386         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1387         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1388         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1389         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1390         (WebKit::NetscapePluginInstanceProxy::create):
1391         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1392         * Plugins/Hosted/ProxyInstance.h:
1393         (WebKit::ProxyInstance::create):
1394         * Plugins/Hosted/ProxyInstance.mm:
1395         (WebKit::ProxyInstance::ProxyInstance):
1396         (WebKit::ProxyInstance::newRuntimeObject):
1397         * Plugins/Hosted/ProxyRuntimeObject.h:
1398         (WebKit::ProxyRuntimeObject::create):
1399         * Plugins/Hosted/ProxyRuntimeObject.mm:
1400         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1401         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1402         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1403         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1404         * Plugins/WebBaseNetscapePluginView.h:
1405         * Plugins/WebBaseNetscapePluginView.mm:
1406         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1407         * Plugins/WebNetscapePluginStream.h:
1408         (WebNetscapePluginStream::create):
1409         * Plugins/WebNetscapePluginView.h:
1410         * Plugins/WebNetscapePluginView.mm:
1411         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1412         * WebCoreSupport/WebChromeClient.mm:
1413         * WebCoreSupport/WebEditorClient.mm:
1414         * WebCoreSupport/WebNotificationClient.mm:
1415         (WebNotificationClient::requestPermission):
1416         (-[WebNotificationPolicyListener initWithCallback:]):
1417         * WebCoreSupport/WebOpenPanelResultListener.mm:
1418         * WebCoreSupport/WebUserMediaClient.mm:
1419         (WebUserMediaClient::requestUserMediaAccess):
1420         (WebUserMediaClient::enumerateMediaDevices):
1421         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1422         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1423         * WebView/WebArchive.mm:
1424         (-[WebArchivePrivate initWithCoreArchive:]):
1425         (-[WebArchivePrivate setCoreArchive:]):
1426         (-[WebArchive initWithData:]):
1427         (-[WebArchive subframeArchives]):
1428         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1429         * WebView/WebArchiveInternal.h:
1430         * WebView/WebDataSource.mm:
1431         (WebDataSourcePrivate::WebDataSourcePrivate):
1432         (WebDataSourcePrivate::~WebDataSourcePrivate):
1433         (-[WebDataSource _initWithDocumentLoader:]):
1434         * WebView/WebDataSourceInternal.h:
1435         * WebView/WebDeviceOrientation.mm:
1436         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1437         * WebView/WebDeviceOrientationInternal.h:
1438         * WebView/WebFrame.mm:
1439         (-[WebFrame _convertToDOMRange:]):
1440         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1441         * WebView/WebFrameInternal.h:
1442         * WebView/WebFullScreenController.h:
1443         * WebView/WebFullScreenController.mm:
1444         (-[WebFullScreenController setElement:]):
1445         * WebView/WebGeolocationPosition.mm:
1446         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1447         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1448         * WebView/WebHTMLView.mm:
1449         (currentKeyboardEvent):
1450         * WebView/WebResource.mm:
1451         * WebView/WebScriptWorld.mm:
1452         (-[WebScriptWorld initWithWorld:]):
1453         (+[WebScriptWorld standardWorld]):
1454         (+[WebScriptWorld findOrCreateWorld:]):
1455         * WebView/WebViewData.h:
1456         (LayerFlushController::create):
1457
1458 2017-05-11  Chris Dumez  <cdumez@apple.com>
1459
1460         Drop remaining uses of PassRefPtr in WebCore
1461         https://bugs.webkit.org/show_bug.cgi?id=172013
1462
1463         Reviewed by Yusuke Suzuki.
1464
1465         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1466         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1467         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1468         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1469         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1470         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1471
1472 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1473
1474         Mail spins launching spell checker when typing
1475         https://bugs.webkit.org/show_bug.cgi?id=171986
1476         <rdar://problem/26305327>
1477
1478         Reviewed by Beth Dakin.
1479
1480         * WebView/WebView.mm:
1481         (-[WebView setEditable:]):
1482         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1483
1484 2017-05-09  Sam Weinig  <sam@webkit.org>
1485
1486         Remove support for legacy Notifications
1487         https://bugs.webkit.org/show_bug.cgi?id=171487
1488
1489         Reviewed by Jon Lee.
1490
1491         * Configurations/FeatureDefines.xcconfig:
1492         * WebCoreSupport/WebNotificationClient.h:
1493         * WebCoreSupport/WebNotificationClient.mm:
1494         * WebView/WebNotification.mm:
1495         * WebView/WebNotificationInternal.h:
1496         * WebView/WebView.mm:
1497         (-[WebView _commonInitializationWithFrameName:groupName:]):
1498         (-[WebView _notificationIDForTesting:]):
1499         Remove legacy notification specific code.
1500
1501 2017-05-10  Chris Dumez  <cdumez@apple.com>
1502
1503         Simplify relationship between Attr and Element now that Attr is childless
1504         https://bugs.webkit.org/show_bug.cgi?id=171909
1505
1506         Reviewed by Ryosuke Niwa.
1507
1508         Build fix.
1509
1510         * DOM/DOMAttr.mm:
1511         (-[DOMAttr value]):
1512         (-[DOMAttr setValue:]):
1513
1514 2017-05-08  Chris Dumez  <cdumez@apple.com>
1515
1516         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1517         https://bugs.webkit.org/show_bug.cgi?id=171795
1518
1519         Reviewed by Alex Christensen.
1520
1521         Build fix.
1522
1523         * DOM/DOMElement.mm:
1524         (-[DOMElement style]):
1525         * WebCoreSupport/WebEditorClient.mm:
1526         (WebEditorClient::shouldApplyStyle):
1527         * WebView/WebFrame.mm:
1528         (-[WebFrame _typingStyle]):
1529
1530 2017-05-06  Chris Dumez  <cdumez@apple.com>
1531
1532         Align our IDL files with the latest DOM specification
1533         https://bugs.webkit.org/show_bug.cgi?id=171777
1534
1535         Reviewed by Sam Weinig.
1536
1537         Build fix.
1538
1539         * DOM/DOMDocument.mm:
1540         (-[DOMDocument readyState]):
1541
1542 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1543
1544         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1545         https://bugs.webkit.org/show_bug.cgi?id=171610
1546         <rdar://problem/31976820>
1547
1548         Reviewed by Eric Carlson.
1549
1550         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1551
1552         * WebCoreSupport/WebChromeClient.h:
1553         * WebCoreSupport/WebChromeClient.mm:
1554         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1555
1556 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1557
1558         Unreviewed, rolling out r216206.
1559         https://bugs.webkit.org/show_bug.cgi?id=171714
1560
1561         Multiple LayoutTests crashing in Document::page() (Requested
1562         by ap on #webkit).
1563
1564         Reverted changeset:
1565
1566         "Remove support for legacy Notifications"
1567         https://bugs.webkit.org/show_bug.cgi?id=171487
1568         http://trac.webkit.org/changeset/216206
1569
1570 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
1571
1572         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
1573         https://bugs.webkit.org/show_bug.cgi?id=171704
1574
1575         Reviewed by Jer Noble.
1576
1577         Fix build by casting result of +whiteColor to UIColor.
1578
1579         * WebView/WebView.mm:
1580         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1581
1582 2017-05-04  Sam Weinig  <sam@webkit.org>
1583
1584         Remove support for legacy Notifications
1585         https://bugs.webkit.org/show_bug.cgi?id=171487
1586
1587         Reviewed by Jon Lee.
1588
1589         * Configurations/FeatureDefines.xcconfig:
1590         * WebCoreSupport/WebNotificationClient.h:
1591         * WebCoreSupport/WebNotificationClient.mm:
1592         * WebView/WebNotification.mm:
1593         * WebView/WebNotificationInternal.h:
1594         * WebView/WebView.mm:
1595         (-[WebView _commonInitializationWithFrameName:groupName:]):
1596         (-[WebView _notificationIDForTesting:]):
1597         Remove legacy notification specific code.
1598
1599 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
1600
1601         [Cocoa] Stop exporting symbols for ivars that were made private
1602         https://bugs.webkit.org/show_bug.cgi?id=171631
1603
1604         Reviewed by Dan Bernstein.
1605
1606         * WebKit.exp:
1607
1608 2017-05-01  Chris Dumez  <cdumez@apple.com>
1609
1610         Remove some usage of PassRefPtr in editing code
1611         https://bugs.webkit.org/show_bug.cgi?id=171490
1612
1613         Reviewed by Darin Adler.
1614
1615         * WebView/WebFrame.mm:
1616         (-[WebFrame dictationResultMetadataForRange:]):
1617         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1618
1619 2017-05-01  Beth Dakin  <bdakin@apple.com>
1620
1621         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1622         start of a paragraph
1623         https://bugs.webkit.org/show_bug.cgi?id=171453
1624         -and corresponding-
1625         rdar://problem/29779764
1626
1627         Reviewed by Tim Horton.
1628
1629         This bug only happens when the caret is at the beginning of the paragraph, and it 
1630         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
1631         might be correct that absoluteTextQuads() returns no quads in this case, so this 
1632         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
1633
1634         * WebCoreSupport/WebEditorClient.mm:
1635         (WebEditorClient::handleRequestedCandidates):
1636
1637 2017-04-30  Dan Bernstein  <mitz@apple.com>
1638
1639         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
1640         https://bugs.webkit.org/show_bug.cgi?id=171485
1641
1642         Reviewed by Geoffrey Garen.
1643
1644         * WebView/WebView.mm:
1645         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1646         (-[WebUITextIndicatorData initWithImage:scale:]):
1647
1648 2017-04-28  Youenn Fablet  <youenn@apple.com>
1649
1650         Adding a runtime flag specific to MediaDevices
1651         https://bugs.webkit.org/show_bug.cgi?id=171433
1652
1653         Reviewed by Geoffrey Garen.
1654
1655         Adding a preference for MediaDevices.
1656         Setting media devices runtime flag to false by default.
1657         Setting peer connection and media stream flags to true by default.
1658
1659         * WebView/WebPreferenceKeysPrivate.h:
1660         * WebView/WebPreferences.mm:
1661         (+[WebPreferences initialize]):
1662         (-[WebPreferences mediaDevicesEnabled]):
1663         (-[WebPreferences setMediaDevicesEnabled:]):
1664         * WebView/WebPreferencesPrivate.h:
1665         * WebView/WebView.mm:
1666         (-[WebView _preferencesChanged:]):
1667
1668 2017-04-27  Chris Dumez  <cdumez@apple.com>
1669
1670         Align colspan/rowspan limits with the latest HTML specification
1671         https://bugs.webkit.org/show_bug.cgi?id=171322
1672
1673         Reviewed by Darin Adler.
1674
1675         ObjC bindings build fix.
1676
1677         * DOM/DOMHTMLTableCellElement.mm:
1678         (-[DOMHTMLTableCellElement colSpan]):
1679         (-[DOMHTMLTableCellElement setColSpan:]):
1680
1681 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1682
1683         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
1684         https://bugs.webkit.org/show_bug.cgi?id=170333
1685
1686         Reviewed by Simon Fraser.
1687
1688         Disbale the async decoding for large images for now.
1689
1690         * WebView/WebView.mm:
1691         (-[WebView _preferencesChanged:]):
1692
1693 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1694
1695         Modernize Frame.h
1696         https://bugs.webkit.org/show_bug.cgi?id=171357
1697
1698         Reviewed by Andy Estes.
1699
1700         * WebCoreSupport/WebEditorClient.h:
1701         * WebCoreSupport/WebEditorClient.mm:
1702         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
1703
1704 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1705
1706         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
1707         https://bugs.webkit.org/show_bug.cgi?id=171369
1708         <rdar://problem/31858853>
1709
1710         Reviewed by Dan Bernstein.
1711
1712         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
1713         returns whether or not the data interaction was handled. Due to the difference only in return type
1714         and some staging constraints, this version is prefixed with "_tryTo".
1715
1716         * WebView/WebView.mm:
1717         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1718         * WebView/WebViewPrivate.h:
1719
1720 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1721
1722         WebItemProviderPasteboard should not synchronously load provided data
1723         https://bugs.webkit.org/show_bug.cgi?id=171341
1724         <rdar://problem/31614010>
1725
1726         Reviewed by Tim Horton.
1727
1728         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
1729
1730         * WebCoreSupport/WebPlatformStrategies.h:
1731         * WebCoreSupport/WebPlatformStrategies.mm:
1732         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
1733
1734 2017-04-26  Zalan Bujtas  <zalan@apple.com>
1735
1736         RTL: recent searches popover is displayed in incorrect location
1737         https://bugs.webkit.org/show_bug.cgi?id=171338
1738         <rdar://problem/31377807>
1739
1740         Reviewed by Dean Jackson.
1741
1742         Add RTL support for the pop-under branch.
1743
1744         * WebCoreSupport/PopupMenuMac.mm:
1745         (PopupMenuMac::show):
1746
1747 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1748
1749         Limit allowed size of document.title to avoid locking WebKit clients
1750         https://bugs.webkit.org/show_bug.cgi?id=165113
1751         <rdar://problem/28324389>
1752
1753         Reviewed by Darin Adler.
1754
1755         When a web application attempts to set an extremely long title, truncate the
1756         title to a more reasonable size.
1757
1758         We do this at at the presentation layer, rather than in the DOM, so that we do
1759         not affect script function. Instead, we merely limit display to a level that is
1760         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
1761         layer, so it is a waste of effort to send across IPC.
1762
1763         * WebCoreSupport/WebFrameLoaderClient.h:
1764         * WebCoreSupport/WebFrameLoaderClient.mm:
1765         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1766
1767 2017-04-25  Daniel Bates  <dabates@apple.com>
1768
1769         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1770         https://bugs.webkit.org/show_bug.cgi?id=136452
1771         <rdar://problem/23412620>
1772
1773         Reviewed by Brent Fulgham.
1774
1775         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1776
1777         * Configurations/FeatureDefines.xcconfig:
1778
1779 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1780
1781         Support reading NSURL titles from the pasteboard when performing data interaction
1782         https://bugs.webkit.org/show_bug.cgi?id=171156
1783         <rdar://problem/31356937>
1784
1785         Reviewed by Tim Horton.
1786
1787         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
1788
1789         * WebCoreSupport/WebPlatformStrategies.h:
1790         * WebCoreSupport/WebPlatformStrategies.mm:
1791         (WebPlatformStrategies::readURLFromPasteboard):
1792         * WebView/WebFrame.mm:
1793         (-[WebFrame hasRichlyEditableDragCaret]):
1794         * WebView/WebFramePrivate.h:
1795
1796 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
1797
1798         Clean up ICU headers
1799         https://bugs.webkit.org/show_bug.cgi?id=170997
1800
1801         Reviewed by JF Bastien.
1802
1803         Update all icu headers to 55.1
1804
1805         * icu/README: Explain ICU headers for OS X better
1806         * icu/unicode/localpointer.h:
1807         (LocalPointer::LocalPointer):
1808         (LocalPointer::adoptInsteadAndCheckErrorCode):
1809         * icu/unicode/platform.h:
1810         * icu/unicode/putil.h:
1811         * icu/unicode/uchar.h:
1812         * icu/unicode/uconfig.h:
1813         * icu/unicode/ucurr.h:
1814         * icu/unicode/uidna.h:
1815         * icu/unicode/umachine.h:
1816         * icu/unicode/urename.h:
1817         * icu/unicode/uscript.h:
1818         * icu/unicode/ustring.h:
1819         * icu/unicode/utf8.h:
1820         * icu/unicode/utypes.h:
1821         * icu/unicode/uvernum.h:
1822
1823 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1824
1825         Respect fidelity order when reading web content from item providers
1826         https://bugs.webkit.org/show_bug.cgi?id=171155
1827         <rdar://problem/31356937>
1828
1829         Reviewed by Tim Horton.
1830
1831         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
1832
1833         * WebCoreSupport/WebPlatformStrategies.h:
1834         * WebCoreSupport/WebPlatformStrategies.mm:
1835         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
1836
1837 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1838
1839         Reduce copies and allocations in SharedBuffer::append
1840         https://bugs.webkit.org/show_bug.cgi?id=170956
1841
1842         Reviewed by Andreas Kling.
1843
1844         * WebView/WebArchive.mm:
1845         (-[WebArchive initWithData:]):
1846         * WebView/WebFrame.mm:
1847         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1848         * WebView/WebResource.mm:
1849         (-[WebResource initWithCoder:]):
1850         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1851
1852 2017-04-24  Dan Bernstein  <mitz@apple.com>
1853
1854         [Cocoa] Some ivars are needlessly @protected
1855         https://bugs.webkit.org/show_bug.cgi?id=171208
1856
1857         Reviewed by Anders Carlsson
1858
1859         Made ivars @private where possible.
1860
1861         * Misc/WebUserContentURLPattern.h:
1862         * Plugins/WebPluginDatabase.h:
1863         * Storage/WebDatabaseQuotaManager.h:
1864         * WebCoreSupport/WebSecurityOriginPrivate.h:
1865         * WebInspector/WebInspector.h:
1866         * WebView/WebDeviceOrientation.h:
1867         * WebView/WebDeviceOrientationProviderMock.h:
1868         * WebView/WebGeolocationPosition.h:
1869         * WebView/WebHTMLRepresentation.h:
1870         * WebView/WebNotification.h:
1871
1872 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1873
1874         Support writing link titles to the pasteboard when beginning data interaction on a link
1875         https://bugs.webkit.org/show_bug.cgi?id=171154
1876         <rdar://problem/31356937>
1877
1878         Reviewed by Andy Estes.
1879
1880         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
1881         and WebKit2 ChangeLogs for more details.
1882
1883         * WebCoreSupport/WebPlatformStrategies.h:
1884         * WebCoreSupport/WebPlatformStrategies.mm:
1885         (WebPlatformStrategies::writeToPasteboard):
1886
1887 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1888
1889         Unreviewed, rolling out r215608.
1890
1891         Hundreds of test failures on GTK bot
1892
1893         Reverted changeset:
1894
1895         "Reduce copies and allocations in SharedBuffer::append"
1896         https://bugs.webkit.org/show_bug.cgi?id=170956
1897         http://trac.webkit.org/changeset/215608
1898
1899 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1900
1901         Reduce copies and allocations in SharedBuffer::append
1902         https://bugs.webkit.org/show_bug.cgi?id=170956
1903
1904         Reviewed by Andreas Kling.
1905
1906         * WebView/WebArchive.mm:
1907         (-[WebArchive initWithData:]):
1908         * WebView/WebFrame.mm:
1909         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1910         * WebView/WebResource.mm:
1911         (-[WebResource initWithCoder:]):
1912         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1913
1914 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
1915
1916         Build fix to start using C++14.
1917         https://bugs.webkit.org/show_bug.cgi?id=171038
1918
1919         Reviewed by Alex Christensen.
1920
1921         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
1922
1923         * Configurations/WebKitLegacy.xcconfig:
1924
1925 2017-04-19  Youenn Fablet  <youenn@apple.com>
1926
1927         [Mac] Allow customizing H264 encoder
1928         https://bugs.webkit.org/show_bug.cgi?id=170829
1929
1930         Reviewed by Alex Christensen.
1931
1932         * Configurations/FeatureDefines.xcconfig:
1933
1934 2017-04-19  Anders Carlsson  <andersca@apple.com>
1935
1936         Stop using deprecated APIs, part 3
1937         https://bugs.webkit.org/show_bug.cgi?id=171003
1938         rdar://problem/31589635
1939
1940         Reviewed by Tim Horton.
1941
1942         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1943         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1944         (WebPaymentCoordinatorClient::cancelPaymentSession):
1945         Update for WebCore changes.
1946
1947 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
1950         https://bugs.webkit.org/show_bug.cgi?id=170880
1951         <rdar://problem/31314689>
1952
1953         Reviewed by Tim Horton.
1954
1955         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
1956
1957         * WebCoreSupport/WebPlatformStrategies.h:
1958         * WebCoreSupport/WebPlatformStrategies.mm:
1959         (WebPlatformStrategies::getFilenamesForDataInteraction):
1960
1961 2017-04-17  Youenn Fablet  <youenn@apple.com>
1962
1963         Disable outdated WritableStream API
1964         https://bugs.webkit.org/show_bug.cgi?id=170749
1965         <rdar://problem/31446233>
1966
1967         Reviewed by Alex Christensen.
1968
1969         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
1970         - A STREAMS_API compilation flag.
1971         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
1972
1973         * Configurations/FeatureDefines.xcconfig:
1974         * WebView/WebPreferenceKeysPrivate.h:
1975         * WebView/WebPreferences.mm:
1976         (+[WebPreferences initialize]):
1977         (-[WebPreferences readableByteStreamAPIEnabled]):
1978         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
1979         (-[WebPreferences writableStreamAPIEnabled]):
1980         (-[WebPreferences setWritableStreamAPIEnabled:]):
1981         * WebView/WebPreferencesPrivate.h:
1982         * WebView/WebView.mm:
1983         (-[WebView _preferencesChanged:]):
1984
1985 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1986
1987         [WK2] Support data interaction of files into file inputs
1988         https://bugs.webkit.org/show_bug.cgi?id=170803
1989         <rdar://problem/31286130>
1990
1991         Reviewed by Tim Horton.
1992
1993         Add boilerplate plumbing for fetching the number of files in the pasteboard.
1994
1995         * WebCoreSupport/WebPlatformStrategies.h:
1996         * WebCoreSupport/WebPlatformStrategies.mm:
1997         (WebPlatformStrategies::getNumberOfFiles):
1998
1999 2017-04-14  Mark Lam  <mark.lam@apple.com>
2000
2001         Update architectures in xcconfig files.
2002         https://bugs.webkit.org/show_bug.cgi?id=170867
2003         <rdar://problem/31628104>
2004
2005         Reviewed by Joseph Pecoraro.
2006
2007         * Configurations/FeatureDefines.xcconfig:
2008
2009 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2010
2011         [WK2] Support Icon creation from file URLs on iOS
2012         https://bugs.webkit.org/show_bug.cgi?id=170809
2013         <rdar://problem/31286130>
2014
2015         Reviewed by Tim Horton.
2016
2017         Adjust for changes in the ChromeClient in WebCore.
2018
2019         * WebCoreSupport/WebChromeClient.h:
2020         * WebCoreSupport/WebChromeClient.mm:
2021         (WebChromeClient::loadIconForFiles):
2022         (WebChromeClient::createIconForFiles):
2023
2024 2017-04-12  Dan Bernstein  <mitz@apple.com>
2025
2026         [Mac] Future-proof .xcconfig files
2027         https://bugs.webkit.org/show_bug.cgi?id=170802
2028
2029         Reviewed by Tim Horton.
2030
2031         * Configurations/Base.xcconfig:
2032         * Configurations/DebugRelease.xcconfig:
2033         * Configurations/FeatureDefines.xcconfig:
2034         * Configurations/Version.xcconfig:
2035
2036 2017-04-12  Beth Dakin  <bdakin@apple.com>
2037
2038         Build fix.
2039
2040         * WebView/WebViewData.h:
2041
2042 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
2043
2044         Should always override -[WebStorageManager init].
2045         https://bugs.webkit.org/show_bug.cgi?id=170787
2046         -and corresponding-
2047         rdar://problem/31371835
2048
2049         Reviewed by Anders Carlsson.
2050
2051         * Storage/WebStorageManager.mm:
2052         (-[WebStorageManager init]):
2053
2054 2017-04-12  Beth Dakin  <bdakin@apple.com>
2055
2056         Speculative build fix. 
2057
2058         * WebView/WebViewData.h:
2059
2060 2017-04-12  Beth Dakin  <bdakin@apple.com>
2061
2062         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
2063         https://bugs.webkit.org/show_bug.cgi?id=170693
2064         -and corresponding-
2065         rdar://problem/31230018
2066
2067         Reviewed by Sam Weinig.
2068
2069         Since the new names only apply to some versions of macOS, this patch uses typedefs 
2070         for the older OS’s. SO:
2071
2072         AVFunctionBarScrubber is now AVTouchBarScrubber
2073
2074         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
2075
2076         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
2077
2078         And the protocol AVFunctionBarPlaybackControlsControlling is now 
2079         AVTouchBarPlaybackControlsControlling
2080
2081         Soft links and allocations cannot use the typedefs.
2082         * WebView/WebView.mm:
2083         (-[WebView updateMediaTouchBar]):
2084         * WebView/WebViewData.h:
2085
2086 2017-04-11  Dean Jackson  <dino@apple.com>
2087
2088         Disable outdated WritableStream API
2089         https://bugs.webkit.org/show_bug.cgi?id=170749
2090         <rdar://problem/31446233>
2091
2092         Reviewed by Tim Horton.
2093
2094         The API we implement is no longer accurate. Disable it until we
2095         are compatible with the new specification
2096
2097         * Configurations/FeatureDefines.xcconfig:
2098
2099 2017-04-11  Dan Bernstein  <mitz@apple.com>
2100
2101         [iOS] Simple HTML documents should allow non-markup JavaScript
2102         https://bugs.webkit.org/show_bug.cgi?id=170734
2103
2104         Reviewed by Sam Weinig.
2105
2106         * WebView/WebView.mm:
2107         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
2108           but disabled scripting markup.
2109
2110 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2111
2112         Revert r215217
2113         https://bugs.webkit.org/show_bug.cgi?id=170703
2114
2115         * Configurations/FeatureDefines.xcconfig:
2116
2117 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2118
2119         Continue enabling WebRTC
2120         https://bugs.webkit.org/show_bug.cgi?id=170703
2121
2122         Reviewed by Youenn Fablet.
2123
2124         * Configurations/FeatureDefines.xcconfig:
2125
2126 2017-04-10  Anders Carlsson  <andersca@apple.com>
2127
2128         Remove call to WKShowKeyAndMain
2129         https://bugs.webkit.org/show_bug.cgi?id=170691
2130         rdar://problem/31050032
2131
2132         Reviewed by Beth Dakin.
2133
2134         * Carbon/CarbonWindowAdapter.mm:
2135         (-[CarbonWindowAdapter makeKeyWindow]):
2136
2137 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
2138
2139         Add CoreAudioCaptureSource.
2140         https://bugs.webkit.org/show_bug.cgi?id=170112
2141         rdar://problem/30293338
2142
2143         Reviewed by Eric Carlson.
2144
2145         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
2146
2147         * WebView/WebPreferenceKeysPrivate.h:
2148         * WebView/WebPreferences.mm:
2149         (+[WebPreferences initialize]):
2150         (-[WebPreferences useAVFoundationAudioCapture]):
2151         (-[WebPreferences setUseAVFoundationAudioCapture:]):
2152         * WebView/WebPreferencesPrivate.h:
2153         * WebView/WebView.mm:
2154         (-[WebView _preferencesChanged:]):
2155
2156 2017-04-10  Chris Dumez  <cdumez@apple.com>
2157
2158         Drop Timer::startOneShot() overload taking a double
2159         https://bugs.webkit.org/show_bug.cgi?id=170659
2160
2161         Reviewed by Yusuke Suzuki.
2162
2163         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2164
2165         * Plugins/WebNetscapePluginView.mm:
2166         (PluginTimer::start):
2167         * Storage/WebStorageManager.mm:
2168         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2169
2170 2017-04-09  Chris Dumez  <cdumez@apple.com>
2171
2172         Drop Timer::startRepeating() overload taking a double
2173         https://bugs.webkit.org/show_bug.cgi?id=170656
2174
2175         Reviewed by Yusuke Suzuki.
2176
2177         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2178
2179         * Plugins/WebNetscapePluginView.mm:
2180         (PluginTimer::start):
2181
2182 2017-04-09  Chris Dumez  <cdumez@apple.com>
2183
2184         Start dropping Timer API dealing with double
2185         https://bugs.webkit.org/show_bug.cgi?id=170649
2186
2187         Reviewed by Yusuke Suzuki.
2188
2189         Start dropping Timer API dealing with double as people should use Seconds now.
2190
2191         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2192         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2193         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2194         * Plugins/WebNetscapePluginStream.mm:
2195         (WebNetscapePluginStream::deliverData):
2196
2197 2017-04-08  Chris Dumez  <cdumez@apple.com>
2198
2199         Drop std::chrono support from Timer class
2200         https://bugs.webkit.org/show_bug.cgi?id=170645
2201
2202         Reviewed by Sam Weinig.
2203
2204         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2205
2206         * WebView/WebView.mm:
2207         (+[WebView _setCacheModel:]):
2208
2209 2017-04-08  Youenn Fablet  <youenn@apple.com>
2210
2211         WebRTC tests gardening
2212         https://bugs.webkit.org/show_bug.cgi?id=170508
2213
2214         Reviewed by Eric Carlson.
2215
2216         * Configurations/FeatureDefines.xcconfig:
2217
2218 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2219
2220         Unreviewed, rolling out r215046.
2221
2222         This change broke internal builds.
2223
2224         Reverted changeset:
2225
2226         "WebRTC tests gardening"
2227         https://bugs.webkit.org/show_bug.cgi?id=170508
2228         http://trac.webkit.org/changeset/215046
2229
2230 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2231
2232         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2233         https://bugs.webkit.org/show_bug.cgi?id=170566
2234
2235         Reviewed by Simon Fraser.
2236
2237         * DOM/DOMCSS.mm:
2238         (kitClass):
2239         Use the WebCore-side enum for this, since that's actually what we're switching over.
2240         This allows us to handle values here without adding them to the API header.
2241         All of the other kitClass() functions work the same way.
2242         Also, unindent for style purposes.
2243
2244 2017-04-06  Youenn Fablet  <youenn@apple.com>
2245
2246         WebRTC tests gardening
2247         https://bugs.webkit.org/show_bug.cgi?id=170508
2248
2249         Reviewed by Eric Carlson.
2250
2251         * Configurations/FeatureDefines.xcconfig:
2252
2253 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2254
2255         Fix leaks in WebUITextIndicatorData
2256         https://bugs.webkit.org/show_bug.cgi?id=170480
2257
2258         Reviewed by Wenson Hsieh.
2259
2260         Removes extraneous retains.
2261
2262         * WebView/WebView.mm:
2263         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2264
2265 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2266
2267         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2268         https://bugs.webkit.org/show_bug.cgi?id=165801
2269         <rdar://problem/29649535>
2270
2271         Reviewed by Wenson Hsieh.
2272
2273         * WebView/WebView.mm:
2274         (incrementFrame):
2275         Adjust to the new CanWrap enum.
2276
2277 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2278
2279         Web Inspector: Saving files should not suggest the top level directory
2280         https://bugs.webkit.org/show_bug.cgi?id=170085
2281         <rdar://problem/30197794>
2282
2283         Reviewed by Matt Baker.
2284
2285         * WebCoreSupport/WebInspectorClient.mm:
2286         (WebInspectorFrontendClient::save):
2287         Don't set panel.directoryURL unless we have a good suggestion.
2288
2289 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2290
2291         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2292         https://bugs.webkit.org/show_bug.cgi?id=169168
2293         <rdar://problem/30688374>
2294
2295         Reviewed by Tim Horton.
2296
2297         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2298         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2299         we need to import a C++ header for linkedOnOrAfter().
2300
2301         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2302         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2303         the new default value of everything but DragDestinationActionLoad.
2304
2305         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2306         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2307         * Misc/WebKitVersionChecks.h:
2308         * WebCoreSupport/WebDragClient.h:
2309         * WebCoreSupport/WebDragClient.mm:
2310         (WebDragClient::actionMaskForDrag): Deleted.
2311         * WebView/WebView.mm:
2312         (-[WebView draggingEntered:]):
2313         (-[WebView draggingUpdated:]):
2314
2315 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2316
2317         Add support for showing the platform data interaction caret
2318         https://bugs.webkit.org/show_bug.cgi?id=169898
2319         <rdar://problem/31146295>
2320
2321         Reviewed by Beth Dakin.
2322
2323         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2324
2325         * WebView/WebView.mm:
2326         (-[WebView _dataInteractionCaretRect]):
2327         * WebView/WebViewPrivate.h:
2328
2329 2017-03-22  Dan Bernstein  <mitz@apple.com>
2330
2331         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2332         https://bugs.webkit.org/show_bug.cgi?id=169967
2333         <rdar://problem/30406898>
2334
2335         Reviewed by Anders Carlsson.
2336
2337         * WebView/WebView.mm:
2338         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2339           Settings::downloadableBinaryFontsEnabled. The default is true.
2340
2341 2017-03-22  Andy Estes  <aestes@apple.com>
2342
2343         [QuickLook] Rename QuickLookHandle to PreviewLoader
2344         https://bugs.webkit.org/show_bug.cgi?id=169961
2345
2346         Reviewed by Andreas Kling.
2347
2348         * WebCoreSupport/WebFrameLoaderClient.h:
2349         * WebCoreSupport/WebFrameLoaderClient.mm:
2350         (WebFrameLoaderClient::createPreviewLoaderClient):
2351         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2352
2353 2017-03-21  Anders Carlsson  <andersca@apple.com>
2354
2355         Remove bogus availability annotations from DOM SPI headers.
2356         rdar://problem/31015675
2357
2358         Rubber-stamped by Dan Bernstein.
2359
2360         * DOM/DOMHTMLMediaElement.h:
2361         * DOM/DOMHTMLVideoElement.h:
2362         * DOM/DOMMediaError.h:
2363         * DOM/DOMTextEvent.h:
2364         * DOM/DOMTimeRanges.h:
2365         * DOM/DOMTokenList.h:
2366
2367 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2368
2369         Teach TextIndicator to estimate the background color of the given Range
2370         https://bugs.webkit.org/show_bug.cgi?id=169869
2371         <rdar://problem/31127272>
2372
2373         Reviewed by Anders Carlsson and Simon Fraser.
2374
2375         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2376
2377         * WebView/WebView.mm:
2378         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2379         (-[WebUITextIndicatorData dealloc]):
2380         * WebView/WebViewPrivate.h:
2381
2382 2017-03-20  Dan Bernstein  <mitz@apple.com>
2383
2384         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2385         https://bugs.webkit.org/show_bug.cgi?id=169861
2386
2387         Reviewed by Sam Weinig.
2388
2389         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2390         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2391           timestamp file used by the Xcode project to determine whether to run the script.
2392
2393 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2394
2395         WebHTMLView is useless as WebResourceHandler
2396         https://bugs.webkit.org/show_bug.cgi?id=169857
2397
2398         Reviewed by Dan Bernstein.
2399
2400         * WebView/WebHTMLView.mm:
2401         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2402         WebHTMLView doesnt implement any of WebResourceHandler methods.
2403
2404 2017-03-17  Michael Saboff  <msaboff@apple.com>
2405
2406         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2407         https://bugs.webkit.org/show_bug.cgi?id=169817
2408
2409         Reviewed by Filip Pizlo.
2410
2411         * Configurations/FeatureDefines.xcconfig:
2412
2413 2017-03-17  Antti Koivisto  <antti@apple.com>
2414
2415         Add a reload policy where only expired subresources are revalidated
2416         https://bugs.webkit.org/show_bug.cgi?id=169756
2417
2418         Reviewed by Andreas Kling.
2419
2420         * WebView/WebFrame.mm:
2421         (toWebFrameLoadType):
2422         (-[WebFrame reload]):
2423         (-[WebFrame reloadFromOrigin]):
2424
2425 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2426
2427         [WK1] Support animated transitions when performing a data interaction operation
2428         https://bugs.webkit.org/show_bug.cgi?id=169805
2429         <rdar://problem/31045767>
2430
2431         Reviewed by Beth Dakin and Megan Gardner.
2432
2433         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2434         for more details.
2435
2436         * DOM/DOMElement.h:
2437         * DOM/DOMElement.mm:
2438         (-[DOMElement boundsInRootViewSpace]):
2439
2440         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2441
2442         * WebCoreSupport/WebDragClient.h:
2443         (): Deleted.
2444         * WebCoreSupport/WebDragClient.mm:
2445         (WebDragClient::didConcludeEditDrag):
2446
2447         Add boilerplate plumbing.
2448
2449         * WebView/WebView.mm:
2450         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2451
2452         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2453
2454         (floatRectsForCGRectArray):
2455         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2456
2457         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2458         image of some text, as well as clipping rects to apply to the image.
2459
2460         (-[WebView _dataOperationTextIndicator]):
2461
2462         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2463
2464         (-[WebView _didConcludeEditDataInteraction]):
2465         * WebView/WebViewData.h:
2466         * WebView/WebViewInternal.h:
2467         * WebView/WebViewPrivate.h:
2468
2469 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2470
2471         Improve the system tracing points
2472         https://bugs.webkit.org/show_bug.cgi?id=169790
2473
2474         Reviewed by Zalan Bujtas.
2475
2476         Use a more cohesive set of system trace points that give a good overview of what
2477         WebKit is doing. Added points for resource loading, render tree building, sync messages
2478         to the web process, async image decode, WASM and fetching cookies.
2479
2480         * WebView/WebHTMLView.mm:
2481         (-[WebHTMLView drawRect:]):
2482
2483 2017-03-16  Youenn Fablet  <youenn@apple.com>
2484
2485         Wrap legacy WebRTC API in runtime flag
2486         https://bugs.webkit.org/show_bug.cgi?id=169646
2487
2488         Reviewed by Alex Christensen.
2489
2490         * WebView/WebPreferenceKeysPrivate.h:
2491         * WebView/WebPreferences.mm:
2492         (+[WebPreferences initialize]):
2493         (-[WebPreferences webRTCLegacyAPIEnabled]):
2494         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2495         * WebView/WebPreferencesPrivate.h:
2496         * WebView/WebView.mm:
2497         (-[WebView _preferencesChanged:]):
2498
2499 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2500
2501         Correctly export WebItemProviderPasteboard
2502         https://bugs.webkit.org/show_bug.cgi?id=169578
2503
2504         Reviewed by Tim Horton.
2505
2506         * MigrateHeaders.make:
2507
2508 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2509
2510         [WK2] Data interaction tests occasionally hit assertions in debug builds
2511         https://bugs.webkit.org/show_bug.cgi?id=169002
2512         <rdar://problem/30994806>
2513
2514         Reviewed by Tim Horton.
2515
2516         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2517
2518         * WebView/WebHTMLView.mm:
2519         (-[WebHTMLView _updateSelectionForInputManager]):
2520         * WebView/WebView.mm:
2521         (-[WebView updateTextTouchBar]):
2522
2523 2017-03-13  Anders Carlsson  <andersca@apple.com>
2524
2525         Fix build warnings.
2526
2527         * WebCoreSupport/WebInspectorClient.mm:
2528         (WebInspectorFrontendClient::save):
2529         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2530
2531 2017-03-11  Brady Eidson  <beidson@apple.com>
2532
2533         Cleanup "addCookie" and its sole user.
2534         https://bugs.webkit.org/show_bug.cgi?id=169486
2535
2536         Reviewed by Brian Burg.
2537
2538         * WebCoreSupport/WebPlatformStrategies.h:
2539         * WebCoreSupport/WebPlatformStrategies.mm:
2540         (WebPlatformStrategies::addCookie): Deleted.
2541
2542 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2543
2544         Fix watch and tv builds after r213294
2545         https://bugs.webkit.org/show_bug.cgi?id=169508
2546
2547         Reviewed by Dan Bernstein.
2548
2549         * Configurations/FeatureDefines.xcconfig:
2550
2551 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2552
2553         Fix CMake build.
2554
2555         * WebView/WebNotification.h:
2556         Don't assume we have already included something that includes NSObject.h.
2557
2558 2017-03-09  Daniel Bates  <dabates@apple.com>
2559
2560         Guard Credential Management implementation behind a runtime enabled feature flag
2561         https://bugs.webkit.org/show_bug.cgi?id=169364
2562         <rdar://problem/30957425>
2563
2564         Reviewed by Brent Fulgham.
2565
2566         Add WebKit preference for Credential Management (disabled by default).
2567
2568         * WebView/WebPreferenceKeysPrivate.h:
2569         * WebView/WebPreferences.mm:
2570         (+[WebPreferences initialize]):
2571         (-[WebPreferences credentialManagementEnabled]): Added.
2572         (-[WebPreferences setCredentialManagementEnabled:]): Added.
2573         * WebView/WebPreferencesPrivate.h:
2574         * WebView/WebView.mm:
2575         (-[WebView _preferencesChanged:]):
2576
2577 2017-03-09  Anders Carlsson  <andersca@apple.com>
2578
2579         Add delegate support to WebCore
2580         https://bugs.webkit.org/show_bug.cgi?id=169427
2581         Part of rdar://problem/28880714.
2582
2583         Reviewed by Geoffrey Garen.
2584
2585         * Configurations/FeatureDefines.xcconfig:
2586         Add feature define.
2587
2588 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2589
2590         Fix DataInteraction guards
2591         https://bugs.webkit.org/show_bug.cgi?id=169404
2592
2593         Reviewed by Wenson Hsieh.
2594
2595         * WebCoreSupport/WebDragClient.mm:
2596
2597 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2598
2599         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
2600         https://bugs.webkit.org/show_bug.cgi?id=169392
2601         <rdar://problem/30882974>
2602
2603         Reviewed by Tim Horton.
2604
2605         Add a stub implementation of WebDragClient::didConcludeEditDrag.
2606
2607         * WebCoreSupport/WebDragClient.h:
2608
2609 2017-03-08  Anders Carlsson  <andersca@apple.com>
2610
2611         Simplify the PaymentCoordinator interface
2612         https://bugs.webkit.org/show_bug.cgi?id=169382
2613         Part of rdar://problem/28880714.
2614
2615         Reviewed by Tim Horton.
2616
2617         Update for PaymentCoordinatorClient changes.
2618
2619         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2620         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2621         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2622         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2623         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2624         (WebPaymentCoordinatorClient::completePaymentSession):
2625
2626 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2627
2628         Fix for dependency fix
2629         https://bugs.webkit.org/show_bug.cgi?id=169369
2630
2631         Reviewed by Beth Dakin.
2632
2633         * WebView/WebViewPrivate.h:
2634
2635 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2636
2637         Fix Project Dependency
2638         https://bugs.webkit.org/show_bug.cgi?id=169340
2639
2640         Unreviewed Dependency Fix.
2641
2642         * WebView/WebViewPrivate.h:
2643
2644 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
2645
2646         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
2647         https://bugs.webkit.org/show_bug.cgi?id=169341
2648         <rdar://problem/30913788>
2649
2650         Reviewed by Dan Bernstein.
2651
2652         * MigrateHeaders.make:
2653
2654 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2655
2656         Have fixedPositionCreatesStackingContext be on by default everywhere
2657         https://bugs.webkit.org/show_bug.cgi?id=169334
2658
2659         Reviewed by Zalan Bujtas.
2660
2661         It makes no sense to have web-exposed CSS functionality be different based on setting,
2662         and other browser are now aligned with having position:fixed create stacking context.
2663
2664         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
2665         always force stacking context for position:fixed.
2666
2667         * WebView/WebView.mm:
2668         (-[WebView _preferencesChanged:]):
2669
2670 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
2671
2672         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
2673         https://bugs.webkit.org/show_bug.cgi?id=169230
2674
2675         Reviewed by Tim Horton.
2676
2677         * WebView/WebView.mm:
2678         (-[WebView _preferencesChanged:]):
2679
2680 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2681
2682         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
2683         https://bugs.webkit.org/show_bug.cgi?id=169329
2684
2685         Reviewed by Tim Horton.
2686
2687         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
2688
2689         * WebView/WebPreferences.mm:
2690         (+[WebPreferences initialize]):
2691
2692 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2693
2694         Additional DataInteraction Support
2695         https://bugs.webkit.org/show_bug.cgi?id=169316
2696         <rdar://problem/30884234>
2697
2698         Reviewed by Wenson Hsieh.
2699
2700         Add stub implementations to WebView for methods that handle data interaction
2701
2702         * WebView/WebView.mm:
2703         (-[WebView _enteredDataInteraction:client:global:operation:]):
2704         (-[WebView _updatedDataInteraction:client:global:operation:]):
2705         (-[WebView _exitedDataInteraction:client:global:operation:]):
2706         (-[WebView _performDataInteraction:client:global:operation:]):
2707         (-[WebView _endedDataInteraction:global:]):
2708         * WebView/WebViewPrivate.h:
2709
2710 2017-03-07  Dean Jackson  <dino@apple.com>
2711
2712         Some platforms won't be able to create a GPUDevice
2713         https://bugs.webkit.org/show_bug.cgi?id=169314
2714         <rdar://problems/30907521>
2715
2716         Reviewed by Jon Lee.
2717
2718         Disable WEB_GPU on the iOS Simulator.
2719
2720         * Configurations/FeatureDefines.xcconfig:
2721
2722 2017-03-07  Maureen Daum  <mdaum@apple.com>
2723
2724         Correctly check for an empty database file.
2725         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
2726         https://bugs.webkit.org/show_bug.cgi?id=169256
2727
2728         Reviewed by Brady Eidson.
2729
2730         Check if the folder for an origin's WebSQL databases is empty after trying to delete
2731         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
2732         of files that were in the folder. However, when we delete the actual database file in
2733         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
2734         the database file, but deletedDatabaseFileCount only gets incremented once.
2735
2736         * Storage/WebDatabaseManager.mm:
2737         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
2738         Delete the folder if it is empty.
2739
2740 2017-03-06  Michael Saboff  <msaboff@apple.com>
2741
2742         Unreviewed build fix to add
2743         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
2744         for objective C++ files.
2745
2746         * Configurations/WebKitLegacy.xcconfig:
2747
2748 2017-03-06  Michael Saboff  <msaboff@apple.com>
2749
2750         Take advantage of fast permissions switching of JIT memory for devices that support it
2751         https://bugs.webkit.org/show_bug.cgi?id=169155
2752
2753         Reviewed by Saam Barati.
2754
2755         Updated the Xcode config files to match what is in the JavaScriptCore ones.
2756
2757         * Configurations/FeatureDefines.xcconfig:
2758
2759 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2760
2761         Expand font-weight and font-stretch to take any number
2762         https://bugs.webkit.org/show_bug.cgi?id=168889
2763
2764         Reviewed by Simon Fraser.
2765
2766         Migrate off old enum types.
2767
2768         * WebCoreSupport/PopupMenuMac.mm:
2769         (PopupMenuMac::populate):
2770         * WebView/WebHTMLView.mm:
2771         (fontNameForDescription):
2772         * WebView/WebView.mm:
2773         (-[WebView updateTextTouchBar]):
2774
2775 2017-03-03  Dean Jackson  <dino@apple.com>
2776
2777         Add WebGPU compile flag and experimental feature flag
2778         https://bugs.webkit.org/show_bug.cgi?id=169161
2779         <rdar://problem/30846689>
2780
2781         Reviewed by Tim Horton.
2782
2783         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2784         and an InternalSetting.
2785
2786         * Configurations/FeatureDefines.xcconfig:
2787         * WebView/WebPreferenceKeysPrivate.h:
2788         * WebView/WebPreferences.mm:
2789         (+[WebPreferences initialize]):
2790         (-[WebPreferences webGPUEnabled]):
2791         (-[WebPreferences setWebGPUEnabled:]):
2792         * WebView/WebPreferencesPrivate.h:
2793         * WebView/WebView.mm:
2794         (-[WebView _preferencesChanged:]):
2795
2796 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
2797
2798         Build fix
2799         rdar://problem/30825660
2800
2801         Suggested by Dan Bernstein.
2802
2803         * Configurations/WebKitLegacy.xcconfig:
2804
2805 2017-03-02  Sam Weinig  <sam@webkit.org>
2806
2807         Rename htmlediting.h/cpp to Editing.h/cpp
2808         https://bugs.webkit.org/show_bug.cgi?id=169103
2809
2810         Reviewed by Alex Christensen.
2811
2812         * DOM/DOMUIKitExtensions.mm:
2813         * WebView/WebFrame.mm:
2814         * WebView/WebView.mm:
2815
2816 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2817
2818         Fix 32-bit
2819         https://bugs.webkit.org/show_bug.cgi?id=169114
2820
2821         Reviewed by Alex Christensen.
2822
2823         * WebView/WebView.mm:
2824
2825 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2826
2827         More guard fixing
2828         https://bugs.webkit.org/show_bug.cgi?id=169112
2829
2830         Reviewed by Alex Christensen.
2831
2832         Fixed an internal build.
2833
2834         * WebView/WebView.mm:
2835         * WebView/WebViewPrivate.h:
2836
2837 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2838
2839         Data Interaction build fixes
2840         https://bugs.webkit.org/show_bug.cgi?id=169096
2841
2842         Reviewed by Tim Horton.
2843
2844         Guards weren't all correct, also missed a selector name change.
2845
2846         * WebView/WebView.mm:
2847         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2848         * WebView/WebViewData.h:
2849         * WebView/WebViewData.mm:
2850         (-[WebViewPrivate dealloc]):
2851
2852 2017-03-02  Alex Christensen  <achristensen@webkit.org>
2853
2854         Continue enabling WebRTC
2855         https://bugs.webkit.org/show_bug.cgi?id=169056
2856
2857         Reviewed by Jon Lee.
2858
2859         * Configurations/FeatureDefines.xcconfig:
2860
2861 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
2862
2863         Data interaction support for WK1
2864         https://bugs.webkit.org/show_bug.cgi?id=169062
2865
2866         Reviewed by Wenson Hsieh.
2867
2868         Support for data interaction in WebKit1
2869
2870         * WebCoreSupport/WebDragClient.mm:
2871         * WebView/WebView.mm:
2872         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
2873         (-[WebUITextIndicatorData initWithImage:scale:]):
2874         (-[WebUITextIndicatorData dealloc]):
2875         (-[WebView _requestStartDataInteraction:globalPosition:]):
2876         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2877         (-[WebView _getDataInteractionData]):
2878         * WebView/WebViewData.h:
2879         * WebView/WebViewData.mm:
2880         (-[WebViewPrivate dealloc]):
2881         * WebView/WebViewInternal.h:
2882         * WebView/WebViewPrivate.h:
2883
2884 2017-03-02  Youenn Fablet  <youenn@apple.com>
2885
2886         [WebRTC] Activate ICE candidate privacy policy
2887         https://bugs.webkit.org/show_bug.cgi?id=168975
2888
2889         Reviewed by Alex Christensen.
2890
2891         * WebView/WebPreferenceKeysPrivate.h:
2892         * WebView/WebPreferences.mm:
2893         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
2894         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
2895         (-[WebPreferences iceCandidateFilteringEnabled]):
2896         (-[WebPreferences setIceCandidateFilteringEnabled:]):
2897         * WebView/WebPreferencesPrivate.h:
2898
2899 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2900
2901         Unreviewed, rolling out r213259.
2902
2903         Broke an internal build
2904
2905         Reverted changeset:
2906
2907         "Continue enabling WebRTC"
2908         https://bugs.webkit.org/show_bug.cgi?id=169056
2909         http://trac.webkit.org/changeset/213259
2910
2911 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2912
2913         Continue enabling WebRTC
2914         https://bugs.webkit.org/show_bug.cgi?id=169056
2915
2916         Reviewed by Jon Lee.
2917
2918         * Configurations/FeatureDefines.xcconfig:
2919
2920 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2921
2922         Begin enabling WebRTC on 64-bit
2923         https://bugs.webkit.org/show_bug.cgi?id=168915
2924
2925         Reviewed by Eric Carlson.
2926
2927         * Configurations/FeatureDefines.xcconfig:
2928
2929 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
2930
2931         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
2932         https://bugs.webkit.org/show_bug.cgi?id=168919
2933
2934         Reviewed by Tim Horton.
2935
2936         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
2937         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
2938
2939 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2940
2941         [libwebrtc] Enable WebRTC in some Production Builds
2942         https://bugs.webkit.org/show_bug.cgi?id=168858
2943
2944         * Configurations/FeatureDefines.xcconfig:
2945
2946 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
2947
2948         Don't import RetainPtr in WebNotification.h
2949         https://bugs.webkit.org/show_bug.cgi?id=168876
2950
2951         Reviewed by Dan Bernstein.
2952
2953         This is an Objective-C SPI header.
2954
2955         * WebView/WebNotification.h:
2956         * WebView/WebNotification.mm:
2957         (-[WebNotification initWithCoreNotification:notificationID:]):
2958         (-[WebNotification dealloc]):
2959
2960 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
2961
2962         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
2963         https://bugs.webkit.org/show_bug.cgi?id=168819
2964
2965         Reviewed by Dan Bernstein.
2966
2967         * Configurations/WebKitLegacy.xcconfig:
2968
2969 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2970
2971         Export Objective-C symbols for variables in Webkit SPI
2972         https://bugs.webkit.org/show_bug.cgi?id=168758
2973
2974         Reviewed by Alexey Proskuryakov.
2975
2976         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
2977         * WebKit.exp: Added various Objective-C symbols.
2978
2979 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2980
2981         Move instance members from WKQuadObject to implementation file
2982         https://bugs.webkit.org/show_bug.cgi?id=168740
2983
2984         Reviewed by Tim Horton.
2985
2986         * DOM/DOM.mm: Moving instance member to implementation file.
2987         * DOM/DOMExtensions.h: Ditto.
2988
2989 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2990
2991         Move iOS specific symbols to WebKit.ios.exp
2992         https://bugs.webkit.org/show_bug.cgi?id=168726
2993
2994         Reviewed by Alexey Proskuryakov.
2995
2996         * WebKit.exp:
2997
2998 2017-02-21  Youenn Fablet  <youenn@apple.com>
2999
3000         [WebRTC][Mac] Activate libwebrtc
3001         https://bugs.webkit.org/show_bug.cgi?id=167293
3002         <rdar://problem/30401864>
3003
3004         Reviewed by Alex Christensen.
3005
3006         * Configurations/FeatureDefines.xcconfig:
3007
3008 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3009
3010         Export various NSString symbols from WebFramePrivate.h
3011         https://bugs.webkit.org/show_bug.cgi?id=168702
3012
3013         Reviewed by Alexey Proskuryakov.
3014
3015         * WebKit.exp:
3016
3017 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3018
3019         Export various NSString symbols from WebPreferencesPrivate.h
3020         https://bugs.webkit.org/show_bug.cgi?id=168701
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         * WebKit.exp:
3025
3026 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3027
3028         Add missing WebConsoleMessage string key
3029         https://bugs.webkit.org/show_bug.cgi?id=168690
3030
3031         Reviewed by Alexey Proskuryakov.
3032
3033         * WebKit.exp:
3034         * WebView/WebUIDelegatePrivate.h:
3035         This key has an implementation but was not extern / exported like the others.
3036
3037 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3038
3039         Export various NSString symbols from WebViewPrivate.h
3040         https://bugs.webkit.org/show_bug.cgi?id=168689
3041
3042         Reviewed by Alexey Proskuryakov.
3043
3044         * WebKit.exp:
3045
3046 2017-02-21  Commit Queue  <commit-queue@webkit.org>
3047
3048         Unreviewed, rolling out r212768.
3049         https://bugs.webkit.org/show_bug.cgi?id=168698
3050
3051         Rolling out since this would break other projects. (Requested
3052         by aakashjain on #webkit).
3053
3054         Reverted changeset:
3055
3056         "[iOS] Remove old WebKit1 MemoryMeasure helper."
3057         https://bugs.webkit.org/show_bug.cgi?id=168675
3058         http://trac.webkit.org/changeset/212768
3059
3060 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
3061
3062         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
3063         https://bugs.webkit.org/show_bug.cgi?id=168620
3064         <rdar://problem/30617772>
3065
3066         Reviewed by Tim Horton.
3067
3068         * WebView/WebPreferenceKeysPrivate.h:
3069         * WebView/WebPreferences.mm:
3070         (+[WebPreferences initialize]):
3071         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
3072         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
3073         * WebView/WebPreferencesPrivate.h:
3074
3075 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3076
3077         Export various NSString symbols from WebUIDelegatePrivate.h
3078         https://bugs.webkit.org/show_bug.cgi?id=168679
3079
3080         Reviewed by Joseph Pecoraro.
3081
3082         * WebKit.exp:
3083
3084 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3085
3086         Export symbols for various classes present in webkit SPI
3087         https://bugs.webkit.org/show_bug.cgi?id=168674
3088
3089         Reviewed by Dan Bernstein.
3090
3091         * WebKit.exp:
3092
3093 2017-02-21  Andreas Kling  <akling@apple.com>
3094
3095         [iOS] Remove old WebKit1 MemoryMeasure helper.
3096         <https://webkit.org/b/168675>
3097
3098         Reviewed by Sam Weinig.
3099
3100         * Configurations/WebKitLegacy.xcconfig:
3101         * Misc/WebCache.mm:
3102         (+[WebCache emptyInMemoryResources]):
3103         * WebView/WebView.mm:
3104
3105 2017-02-21  Andreas Kling  <akling@apple.com>
3106
3107         [iOS] WebKit1 should use shared memory pressure handler code.
3108         <https://webkit.org/b/168653>
3109
3110         Reviewed by Antti Koivisto.
3111
3112         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
3113         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
3114         dead code since MobileSafari has been using WebKit2 for quite a while.
3115
3116         * WebView/WebView.h:
3117         * WebView/WebView.mm:
3118         (WebInstallMemoryPressureHandler):
3119         (+[WebView _handleMemoryWarning]): Deleted.
3120         (+[WebView registerForMemoryNotifications]): Deleted.
3121         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
3122         (+[WebView garbageCollectNow]): Deleted.
3123         (+[WebView purgeInactiveFontData]): Deleted.
3124         (+[WebView drainLayerPool]): Deleted.
3125         (+[WebView discardAllCompiledCode]): Deleted.
3126         (+[WebView _clearMemoryPressure]): Deleted.
3127         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
3128         * WebView/WebViewPrivate.h:
3129
3130 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3131
3132         Stop exporting interface WebCoreScrollView on iOS
3133         https://bugs.webkit.org/show_bug.cgi?id=168536
3134
3135         Reviewed by Dan Bernstein.
3136
3137         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
3138         * WebKit.mac.exp: Ditto.
3139         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
3140
3141 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3142
3143         Exclude various mac-specific header files from iOS build
3144         https://bugs.webkit.org/show_bug.cgi?id=168621
3145
3146         Reviewed by Dan Bernstein.
3147
3148         * Configurations/WebKitLegacy.xcconfig:
3149
3150 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         Add plumbing to the UI process for TextIndicatorData when computing the drag image
3153         https://bugs.webkit.org/show_bug.cgi?id=168583
3154         Work towards <rdar://problem/30313681>
3155
3156         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
3157
3158         Reviewed by Tim Horton.
3159
3160         * WebView/WebHTMLView.mm:
3161         (-[WebHTMLView _selectionDraggingImage]):
3162         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3163
3164 2017-02-17  Anders Carlsson  <andersca@apple.com>
3165
3166         Add a new drag code path and use it for dragging plain text
3167         https://bugs.webkit.org/show_bug.cgi?id=168534
3168
3169         Reviewed by Geoffrey Garen.
3170
3171         * WebCoreSupport/WebDragClient.h:
3172         Add new members.
3173
3174         * WebCoreSupport/WebDragClient.mm:
3175         (WebDragClient::useLegacyDragClient):
3176         Return false here.
3177
3178         (WebDragClient::beginDrag):
3179         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
3180
3181         * WebView/WebHTMLView.mm:
3182         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
3183         Get the source operation mask from WebCore.
3184
3185         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3186         Send a fake mouse up event.
3187
3188         * WebView/WebHTMLViewInternal.h:
3189         Declare that WebHTMLView conforms to NSDraggingSource.
3190
3191 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3192
3193         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3194         https://bugs.webkit.org/show_bug.cgi?id=168342
3195         rdar://problem/26182266
3196
3197         Reviewed by Tim Horton.
3198
3199         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3200         symbols to re-export.
3201
3202 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3203
3204         Stop exporting DOMTokenList from WebKit
3205         https://bugs.webkit.org/show_bug.cgi?id=168544
3206
3207         Reviewed by Alexey Proskuryakov.
3208
3209         * WebKit.exp:
3210
3211 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3212
3213         Clean up how WebKit exports _WebCreateFragment
3214         https://bugs.webkit.org/show_bug.cgi?id=168579
3215
3216         Reviewed by Dan Bernstein.
3217
3218         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3219         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3220
3221 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3222
3223         Stop exporting DOMNodeFilter
3224         https://bugs.webkit.org/show_bug.cgi?id=168542
3225
3226         Reviewed by Alexey Proskuryakov.
3227
3228         * WebKit.exp:
3229
3230 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3231
3232         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3233         https://bugs.webkit.org/show_bug.cgi?id=167693
3234
3235         Reviewed by Sergio Villar Senin.
3236
3237         * Configurations/FeatureDefines.xcconfig:
3238         * WebView/WebPreferences.mm:
3239         (+[WebPreferences initialize]):
3240         * WebView/WebView.mm:
3241         (-[WebView _preferencesChanged:]):
3242
3243 2017-02-15  Brady Eidson  <beidson@apple.com>
3244
3245         Stop backing up localStorage databases to iCloud by default.
3246         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3247
3248         Reviewed by Geoffrey Garen.
3249
3250         * Misc/WebKitVersionChecks.h:
3251         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3252         (WebKitLinkedOnOrAfter):
3253         (setWebKitLinkTimeVersion):
3254         (WebKitLinkTimeVersion):
3255         (linkedOnOrAfter):
3256
3257         * Storage/WebStorageManager.mm:
3258         (WebKitInitializeStorageIfNecessary):
3259
3260 2017-02-16  Daniel Bates  <dabates@apple.com>
3261
3262         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3263         https://bugs.webkit.org/show_bug.cgi?id=168417
3264         <rdar://problem/30541748>
3265
3266         Reviewed by Brent Fulgham.
3267
3268         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3269         Widget* as it is always called with a valid Widget.
3270
3271         * WebCoreSupport/WebFrameLoaderClient.h:
3272         * WebCoreSupport/WebFrameLoaderClient.mm:
3273         (WebFrameLoaderClient::redirectDataToPlugin):
3274         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3275         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3276         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3277
3278 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3279
3280         [JSC] Drop PassRefPtr in inspector/
3281         https://bugs.webkit.org/show_bug.cgi?id=168420
3282
3283         Reviewed by Alex Christensen.
3284
3285         * WebView/WebScriptDebugger.mm:
3286         (WebScriptDebugger::handlePause):
3287
3288 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3289
3290         Clean up use of some CALayer-related SPI
3291         https://bugs.webkit.org/show_bug.cgi?id=168401
3292
3293         Reviewed by Tim Horton.
3294
3295         Include CALayer.h not CATiledLayer.h.
3296
3297         * WebInspector/WebNodeHighlight.h:
3298
3299 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3300
3301         Fix the build after r212379
3302
3303         Rubber-stamped by Anders Carlsson.
3304
3305         * WebCoreSupport/WebDragClient.mm:
3306         (WebDragClient::startDrag):
3307
3308 2017-02-15  Anders Carlsson  <andersca@apple.com>
3309
3310         Modernize DragClient::startDrag somewhat
3311         https://bugs.webkit.org/show_bug.cgi?id=168379
3312
3313         Reviewed by Tim Horton.
3314
3315         Update for WebCore changes.
3316
3317         * WebCoreSupport/WebDragClient.h:
3318         * WebCoreSupport/WebDragClient.mm:
3319         (WebDragClient::startDrag):
3320
3321 2017-02-14  Dean Jackson  <dino@apple.com>
3322
3323         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3324         https://bugs.webkit.org/show_bug.cgi?id=168339
3325
3326         Reviewed by Simon Fraser.
3327
3328         Use a better name.
3329
3330         * WebView/WebPreferenceKeysPrivate.h:
3331         * WebView/WebPreferences.mm:
3332         (+[WebPreferences initialize]):
3333         (-[WebPreferences forceLowPowerGPUForWebGL]):
3334         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3335         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3336         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3337         * WebView/WebPreferencesPrivate.h:
3338         * WebView/WebView.mm:
3339         (-[WebView _preferencesChanged:]):
3340
3341 2017-02-14  Chris Dumez  <cdumez@apple.com>
3342
3343         HTML Form Validation bubble should take minimum font size setting into consideration
3344         https://bugs.webkit.org/show_bug.cgi?id=168271
3345         <rdar://problem/29869869>
3346
3347         Reviewed by Simon Fraser.
3348
3349         * WebView/WebView.mm:
3350         (-[WebView _contentsOfUserInterfaceItem:]):
3351         Return font size used in the validation bubble.
3352
3353         (-[WebView showFormValidationMessage:withAnchorRect:]):
3354         Pass minimum font size setting when constructing the validation bubble.
3355
3356 2017-02-14  Anders Carlsson  <andersca@apple.com>
3357
3358         Remove an unused delegate method
3359         https://bugs.webkit.org/show_bug.cgi?id=168328
3360
3361         Reviewed by Wenson Hsieh.
3362
3363         * DefaultDelegates/WebDefaultUIDelegate.m:
3364         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3365
3366 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3367
3368         WebCore shouldn't export SystemMemory.h
3369         https://bugs.webkit.org/show_bug.cgi?id=168285
3370
3371         Reviewed by Alex Christensen.
3372
3373         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3374
3375 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3376
3377         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3378         https://bugs.webkit.org/show_bug.cgi?id=168282
3379
3380         Reviewed by Dan Bernstein.
3381
3382         * MigrateHeaders.make:
3383
3384 2017-02-12  Dan Bernstein  <mitz@apple.com>
3385
3386         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3387
3388         * WebView/WebHTMLView.mm:
3389         (createShareMenuItem): Use non-deprecated method.
3390
3391 2017-02-12  Dan Bernstein  <mitz@apple.com>
3392
3393         [Cocoa] Some -respondsToSelector: checks are unnecessary
3394         https://bugs.webkit.org/show_bug.cgi?id=168183
3395
3396         Reviewed by Tim Horton.
3397
3398         * WebView/WebFullScreenController.mm:
3399         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3400           responds to -isOnActiveSpace.
3401         (-[WebFullScreenController exitFullScreen]): Ditto.
3402         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3403           NSApplication responds to -setPresentationOptions.
3404
3405         * WebView/WebHTMLView.mm:
3406         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3407         (-[WebHTMLView otherMouseDown:]): Ditto.
3408
3409         * WebView/WebImmediateActionController.mm:
3410         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3411         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3412
3413         * WebView/WebView.mm:
3414         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3415         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3416
3417 2017-02-10  Daniel Bates  <dabates@apple.com>
3418
3419         Detach frame from document when entering page cache
3420         https://bugs.webkit.org/show_bug.cgi?id=166774
3421         <rdar://problem/29904368>
3422
3423         Reviewed by Chris Dumez.
3424
3425         * WebView/WebPreferenceKeysPrivate.h:
3426         * WebView/WebPreferences.mm:
3427         (+[WebPreferences initialize]):
3428         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3429         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3430         * WebView/WebPreferencesPrivate.h:
3431         * WebView/WebView.mm:
3432         (-[WebView _preferencesChanged:]):
3433
3434 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3435
3436         [Resource Timing] Enable Resource Timing by default in Tests
3437         https://bugs.webkit.org/show_bug.cgi?id=168145
3438
3439         Reviewed by Ryosuke Niwa.
3440
3441         * WebView/WebPreferenceKeysPrivate.h:
3442         * WebView/WebPreferences.mm:
3443         (+[WebPreferences initialize]):
3444         (-[WebPreferences resourceTimingEnabled]):
3445         (-[WebPreferences setResourceTimingEnabled:]):
3446         * WebView/WebPreferencesPrivate.h:
3447         * WebView/WebView.mm:
3448         (-[WebView _preferencesChanged:]):
3449
3450 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3451
3452         cleanup WebLocalizableStrings.
3453         https://bugs.webkit.org/show_bug.cgi?id=168078
3454
3455         Reviewed by Alexey Proskuryakov.
3456
3457         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3458         as it's for each framework's own consumption, and never needs to be exported.
3459
3460 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3461
3462         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3463         https://bugs.webkit.org/show_bug.cgi?id=168096
3464
3465         Reviewed by Alexey Proskuryakov.
3466
3467         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3468
3469 2017-02-09  Antti Koivisto  <antti@apple.com>
3470
3471         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3472         https://bugs.webkit.org/show_bug.cgi?id=167990
3473
3474         Reviewed by Sam Weinig.
3475
3476         * Misc/WebCache.mm:
3477         (+[WebCache addImageToCache:forURL:forFrame:]):
3478         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3479         * WebCoreSupport/WebSystemInterface.mm:
3480         (InitWebCoreSystemInterface):
3481
3482 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3483
3484         Don't migrate WebKit DOM headers in MigrateHeaders.make
3485         https://bugs.webkit.org/show_bug.cgi?id=167608
3486
3487         Reviewed by Darin Adler.
3488
3489         Stop migrating DOM headers that are now in WebKit.
3490
3491         * DOM/DOMDOMImplementation.h: Removed.
3492         * DOM/DOMDOMImplementation.mm: Removed.
3493         * DOM/DOMDOMImplementationInternal.h: Removed.
3494         * DOM/DOMDOMTokenList.h: Removed.
3495         * DOM/DOMDOMTokenList.mm: Removed.
3496         * DOM/DOMDOMTokenListInternal.h: Removed.
3497         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3498         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3499         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3500         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
3501         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
3502         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
3503         As the files are not in WebCore any more, there is no need to differentiate from
3504         WebCore internal headers with the same name. This makes it possible to make these
3505         headers private using Xcode mechanisms, as opposed to copying with a shell script.
3506
3507         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
3508         files don't have it.
3509
3510         * DOM/DOMCore.h:
3511         * DOM/DOMDocument.mm:
3512         * DOM/DOMHTMLAnchorElement.mm:
3513         * DOM/DOMHTMLAreaElement.mm:
3514         * DOM/DOMHTMLLinkElement.mm:
3515         * DOM/DOMUtility.mm:
3516         No more "DOMDOM".
3517
3518         * WebKit.exp:
3519         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
3520         renaming it is likely to be safe.
3521
3522         * MigrateHeaders.make: Don't migrate WebKit headers.
3523
3524         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
3525         on macOS.
3526
3527 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3528
3529         Don't re-export PluginData.h from WebKit
3530         https://bugs.webkit.org/show_bug.cgi?id=168020
3531
3532         Reviewed by Alexey Proskuryakov.
3533
3534         * MigrateHeaders.make: Removed PluginData.h
3535
3536 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3537
3538         Don't re-export WKUtilities.h from WebKit
3539         https://bugs.webkit.org/show_bug.cgi?id=167977
3540
3541         Reviewed by Alexey Proskuryakov.
3542
3543         * MigrateHeaders.make: Removed WKUtilities.h
3544
3545 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3546
3547         credentials should be partitioned by main document domain
3548         https://bugs.webkit.org/show_bug.cgi?id=166998
3549         rdar://problem/22901123
3550
3551         Reviewed by Brady Eidson.
3552
3553         * Misc/WebDownload.mm:
3554         * Plugins/WebBaseNetscapePluginView.mm:
3555         (WebKit::getAuthenticationInfo):
3556         Don't use partitioned credentials for WebKit1 plugins or downloads.
3557         Downloads should be authenticated before becoming a download anyways.
3558
3559 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3560
3561         Rename AnimationController to CSSAnimationController
3562         https://bugs.webkit.org/show_bug.cgi?id=167829
3563
3564         Reviewed by Simon Fraser.
3565
3566         * WebView/WebFrame.mm:
3567         * WebView/WebView.mm:
3568
3569 2017-02-03  Chris Dumez  <cdumez@apple.com>
3570
3571         Dismiss HTML form validation popover when pressing Escape key
3572         https://bugs.webkit.org/show_bug.cgi?id=167716
3573         <rdar://problem/29872943>
3574
3575         Reviewed by Simon Fraser.
3576
3577         Override ValidationMessageClient::hideAnyValidationMessage().
3578
3579         * WebCoreSupport/WebValidationMessageClient.h:
3580         * WebCoreSupport/WebValidationMessageClient.mm:
3581         (WebValidationMessageClient::hideAnyValidationMessage):
3582
3583 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3584
3585         Drag images should be anchored to the mouse location
3586         https://bugs.webkit.org/show_bug.cgi?id=167690
3587         <rdar://problem/30295261>
3588
3589         Reviewed by Enrica Casucci.
3590
3591         Adds some plumbing for the anchor point in the WK1 client layer.
3592
3593         * WebCoreSupport/WebDragClient.h:
3594         * WebCoreSupport/WebDragClient.mm:
3595         (WebDragClient::startDrag):
3596
3597 2017-02-02  Chris Dumez  <cdumez@apple.com>
3598
3599         Rename Node::inDocument() to isConnected()
3600         https://bugs.webkit.org/show_bug.cgi?id=167743
3601
3602         Reviewed by Sam Weinig.
3603
3604         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
3605         - https://dom.spec.whatwg.org/#connected
3606
3607         * DOM/DOMNode.mm:
3608         (-[DOMNode isConnected]):
3609         * WebView/WebFrame.mm:
3610         (-[WebFrame selectNSRange:onElement:]):
3611
3612 2017-02-02  Chris Dumez  <cdumez@apple.com>
3613
3614         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3615         https://bugs.webkit.org/show_bug.cgi?id=167738
3616         <rdar://problem/30229990>
3617
3618         Reviewed by Andreas Kling.
3619
3620         The BackForwardClient no longer needs to worry about removing HistoryItems
3621         from the PageCache now that WebCore takes care of it.
3622
3623         * History/BackForwardList.mm:
3624         (BackForwardList::close):
3625
3626 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
3627
3628         In iOS, we should take background assertion when accessing localstorage databases.
3629         https://bugs.webkit.org/show_bug.cgi?id=165478
3630
3631         Move database transaction background task handling code from WebDatabaseManager to
3632         WebCore's WebSQLiteDatabaseTrackerClient.
3633
3634         Reviewed by Brady Eidson.
3635
3636         * Storage/WebDatabaseManager.mm:
3637         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
3638         * WebCoreSupport/WebApplicationCache.mm:
3639         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
3640         * WebView/WebView.mm:
3641         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
3642
3643 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3644
3645         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
3646         https://bugs.webkit.org/show_bug.cgi?id=167695
3647         <rdar://problem/30305390>
3648
3649         Reviewed by Sam Weinig.
3650
3651         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
3652         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
3653         is destroyed.
3654
3655         * WebView/WebView.mm:
3656         (-[WebView _commonInitializationWithFrameName:groupName:]):
3657
3658 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
3659
3660         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
3661         https://bugs.webkit.org/show_bug.cgi?id=167684
3662
3663         Reviewed by Dan Bernstein.
3664
3665         * DOM/DOMHTML.mm:
3666         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
3667         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
3668         Consolidate in the WebDOMOperationsPrivate category.
3669
3670         * DOM/DOMPrivate.h:
3671         Include WebDOMOperationsPrivate header to get other DOM Private categories.
3672
3673         * DOM/WebDOMOperations.mm:
3674         (-[DOMHTMLInputElement _isAutofilled]):
3675         * DOM/WebDOMOperationsPrivate.h:
3676         Include getter alongside the setter.
3677
3678 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
3679
3680         Build fix.
3681
3682         * Misc/WebNSPasteboardExtras.mm:
3683         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3684         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3685         * WebView/WebHTMLView.mm:
3686         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3687         (-[WebHTMLView copyFont:]):
3688
3689 2017-01-30  Andy Estes  <aestes@apple.com>
3690
3691         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
3692         https://bugs.webkit.org/show_bug.cgi?id=167625
3693
3694         Reviewed by Andreas Kling.
3695
3696         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
3697         * WebCoreSupport/WebFrameLoaderClient.mm:
3698         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
3699         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
3700
3701 2017-01-30  Chris Dumez  <cdumez@apple.com>
3702
3703         Drop legacy Attributes.isId attribute
3704         https://bugs.webkit.org/show_bug.cgi?id=167603
3705
3706         Reviewed by Ryosuke Niwa.
3707
3708         Keep Attr.isId in ObjC bindings.
3709
3710         * DOM/DOMAttr.mm:
3711         (-[DOMAttr isId]):
3712
3713 2017-01-30  Andreas Kling  <akling@apple.com>
3714
3715         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
3716         <https://webkit.org/b/167580>
3717
3718         Reviewed by Antti Koivisto.
3719
3720         Avoid the implicit strong capture of self by keeping it in a __block variable.
3721         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
3722         This fixes huge WebHTMLView leaks seen on the leaks bot.
3723
3724         * WebView/WebHTMLView.mm:
3725         (-[WebHTMLViewPrivate dealloc]):
3726         (-[WebHTMLView viewDidMoveToWindow]):
3727
3728 2017-01-29  Andy Estes  <aestes@apple.com>
3729
3730         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
3731         https://bugs.webkit.org/show_bug.cgi?id=167563
3732         <rdar://problem/30253207>
3733
3734         Reviewed by Andreas Kling.
3735
3736         Instead of only saving QuickLook documents to a temporary file when the client is
3737         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
3738
3739         This also changes the SPI for accessing the temporary file path and UTI. Instead of
3740         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
3741         the frame that saved the QuickLook document, the content dictionary is now stored as a
3742         property of WebDataSource.
3743
3744         This also removes the manual lifetime management of the QLPreviewConverter from
3745         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
3746         which ensures it lives long enough to respond to subresource requests.
3747
3748         New API test: QuickLook.LegacyQuickLookContent
3749
3750         * WebCoreSupport/WebFrameLoaderClient.mm:
3751         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
3752         write a temporary file to here from the QuickLookDocumentWriter constructor.
3753         * WebView/WebDataSource.mm: Declared _quickLookContent.
3754         (-[WebDataSource _quickLookContent]):
3755         (-[WebDataSource _setQuickLookContent:]):
3756         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
3757         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
3758         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
3759         * WebView/WebPreferences.mm:
3760         (-[WebPreferences quickLookDocumentSavingEnabled]):
3761         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
3762         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
3763         * WebView/WebView.mm:
3764         (-[WebView quickLookContentForURL:]): Changed to always return nil.
3765         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
3766         -[WebDataSource _quickLookContent] instead.
3767
3768 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3769
3770         Add Link Preload as an off-by-default experimental feature menu item.
3771         https://bugs.webkit.org/show_bug.cgi?id=167201
3772
3773         Reviewed by Ryosuke Niwa.
3774
3775         * WebView/WebPreferenceKeysPrivate.h:
3776         * WebView/WebPreferences.mm:
3777         (-[WebPreferences linkPreloadEnabled]):
3778         (-[WebPreferences setLinkPreloadEnabled:]):
3779         * WebView/WebPreferencesPrivate.h:
3780         * WebView/WebView.mm:
3781         (-[WebView _preferencesChanged:]):
3782
3783 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3784
3785         Add User Timing Experimental Feature
3786         https://bugs.webkit.org/show_bug.cgi?id=167542
3787         <rdar://problem/22746307>
3788
3789         Reviewed by Ryosuke Niwa.
3790
3791         * WebView/WebPreferenceKeysPrivate.h:
3792         * WebView/WebPreferences.mm:
3793         (+[WebPreferences initialize]):
3794         (-[WebPreferences userTimingEnabled]):
3795         (-[WebPreferences setUserTimingEnabled:]):
3796         * WebView/WebPreferencesPrivate.h:
3797         * WebView/WebView.mm:
3798         (-[WebView _preferencesChanged:]):
3799         Add setting for User Timing runtime enabled feature.
3800
3801 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3802
3803         [WK1] Do not prevent the drag client from initializing on Mac
3804         https://bugs.webkit.org/show_bug.cgi?id=167541
3805
3806         Reviewed by Dan Bernstein.
3807
3808         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
3809         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
3810         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
3811
3812         * WebCoreSupport/WebDragClient.mm:
3813         (WebDragClient::WebDragClient):
3814         (WebDragClient::actionMaskForDrag):
3815         (WebDragClient::willPerformDragDestinationAction):
3816         (WebDragClient::dragSourceActionMaskForPoint):
3817         (WebDragClient::willPerformDragSourceAction):
3818         (WebDragClient::startDrag):
3819         (WebDragClient::declareAndWriteDragImage):
3820         (WebDragClient::declareAndWriteAttachment):
3821         * WebView/WebView.mm:
3822         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3823
3824 2017-01-26  Chris Dumez  <cdumez@apple.com>
3825
3826         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3827         https://bugs.webkit.org/show_bug.cgi?id=167421
3828         <rdar://problem/30188490>
3829
3830         Reviewed by Darin Adler.
3831
3832         Add a new setting allowing layout tests to enable PageCache in a window
3833         that has an opener, for convenience.
3834
3835         * WebView/WebPreferenceKeysPrivate.h:
3836         * WebView/WebPreferences.mm:
3837         (+[WebPreferences initialize]):
3838         (-[WebPreferences allowsPageCacheWithWindowOpener]):
3839         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
3840         * WebView/WebPreferencesPrivate.h:
3841         * WebView/WebView.mm:
3842         (-[WebView _preferencesChanged:]):
3843
3844 2017-01-26  Keith Miller  <keith_miller@apple.com>
3845
3846         classInfo should take a VM so it is not materialized from the object on each call
3847         https://bugs.webkit.org/show_bug.cgi?id=167424
3848
3849         Rubber Stamped by Michael Saboff.
3850
3851         Previously, classInfo() would get the VM from the target's
3852         MarkedBlock.  Most callers already have a VM on hand, so it is
3853         wasteful to compute the VM from the marked block every time. This
3854         patch refactors some of the most common callers of classInfo(),
3855         jsDynamicCast and inherits to take a VM as well.
3856
3857         * DOM/DOM.mm:
3858         (+[DOMNode _nodeFromJSWrapper:]):
3859         * DOM/DOMUtility.mm:
3860         (createDOMWrapper):
3861         * DOM/WebDOMOperations.mm:
3862         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3863         (WebKit::getObjectID):
3864         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3865         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3866         * Plugins/Hosted/ProxyInstance.mm:
3867         (WebKit::ProxyRuntimeMethod::finishCreation):
3868         (WebKit::ProxyInstance::invokeMethod):
3869         * Plugins/Hosted/ProxyRuntimeObject.mm:
3870         (WebKit::ProxyRuntimeObject::finishCreation):
3871         * WebView/WebFrame.mm:
3872         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3873         * WebView/WebView.mm:
3874         (+[WebView _reportException:inContext:]):
3875         (aeDescFromJSValue):
3876         (-[WebView _notificationIDForTesting:]):
3877
3878 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3879
3880         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
3881         https://bugs.webkit.org/show_bug.cgi?id=167472
3882         <rdar://problem/30149809>
3883
3884         Reviewed by Beth Dakin.
3885
3886         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
3887         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
3888         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
3889         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
3890         previous state, so we should just allow the touch bar to update instead.
3891
3892         * WebView/WebView.mm:
3893         (-[WebView updateTextTouchBar]):
3894
3895 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
3896
3897         Crash when setting custom scale factor.
3898         https://bugs.webkit.org/show_bug.cgi?id=167369
3899
3900         Reviewed by Sam Weinig.
3901
3902         Add null pointer check.
3903
3904         * WebView/WebView.mm:
3905         (-[WebView _setCustomBackingScaleFactor:]):
3906
3907 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3908
3909         Refactor drag and drop implementation on Mac
3910         https://bugs.webkit.org/show_bug.cgi?id=167427
3911
3912         Reviewed by Enrica Casucci.
3913
3914         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
3915
3916         * Misc/WebNSPasteboardExtras.h:
3917         * WebCoreSupport/WebDragClient.mm:
3918         * WebView/WebFrame.mm:
3919         * WebView/WebFrameInternal.h:
3920         * WebView/WebHTMLView.mm:
3921         * WebView/WebView.mm:
3922         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3923
3924 2017-01-24  Youenn Fablet  <youennf@gmail.com>
3925
3926         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
3927         https://bugs.webkit.org/show_bug.cgi?id=167294
3928
3929         Reviewed by Alex Christensen.
3930
3931         * WebView/WebView.mm:
3932         (-[WebView _commonInitializationWithFrameName:groupName:]):
3933
3934 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3935
3936         Add support for named pasteboards, pasteboard strategies and platform pasteboards
3937         https://bugs.webkit.org/show_bug.cgi?id=167404
3938
3939         Reviewed by Enrica Casucci.
3940
3941         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
3942
3943         * WebCoreSupport/WebPlatformStrategies.h:
3944         * WebCoreSupport/WebPlatformStrategies.mm:
3945         (WebPlatformStrategies::writeToPasteboard):
3946         (WebPlatformStrategies::getPasteboardItemsCount):
3947         (WebPlatformStrategies::readBufferFromPasteboard):
3948         (WebPlatformStrategies::readURLFromPasteboard):
3949         (WebPlatformStrategies::readStringFromPasteboard):
3950
3951 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
3952
3953         LoadWebLocalizedStrings method should be moved in correct file
3954         https://bugs.webkit.org/show_bug.cgi?id=167393
3955
3956         Reviewed by Alexey Proskuryakov.
3957
3958         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
3959         * Misc/WebLocalizableStrings.mm:
3960         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
3961         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
3962
3963 2017-01-24  Zalan Bujtas  <zalan@apple.com>
3964
3965         Add simple line layout toggle to MiniBrowser
3966         https://bugs.webkit.org/show_bug.cgi?id=167405
3967
3968         Reviewed by Andreas Kling.
3969
3970         * WebView/WebPreferenceKeysPrivate.h:
3971         * WebView/WebPreferences.mm:
3972         (+[WebPreferences initialize]):
3973         (-[WebPreferences simpleLineLayoutEnabled]):
3974         (-[WebPreferences setSimpleLineLayoutEnabled:]):
3975         * WebView/WebPreferencesPrivate.h:
3976         * WebView/WebView.mm:
3977         (-[WebView _preferencesChanged:]):
3978
3979 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3980
3981         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
3982         https://bugs.webkit.org/show_bug.cgi?id=167394
3983
3984         Reviewed by Ryosuke Niwa.
3985
3986         * Configurations/FeatureDefines.xcconfig:
3987
3988 2017-01-23  Chris Dumez  <cdumez@apple.com>
3989
3990         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
3991         https://bugs.webkit.org/show_bug.cgi?id=167308
3992         <rdar://problem/30144964>
3993
3994         Unreviewed, do a partial revert of r211033 to fix assertion.
3995
3996         * WebCoreSupport/WebChromeClient.h:
3997         * WebCoreSupport/WebChromeClient.mm:
3998         (WebChromeClient::exitFullScreenForElement):
3999
4000 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
4001
4002         Remove allowWindowOpenWithoutUserGesture setting
4003         https://bugs.webkit.org/show_bug.cgi?id=167301
4004
4005         Reviewed by Darin Adler.
4006
4007         * WebView/WebView.mm:
4008         (-[WebView _preferencesChanged:]):
4009         Use the equivalent existing setting.
4010
4011 2017-01-20  Darin Adler  <darin@apple.com>
4012
4013         Remove PassRefPtr from "page" directory of WebCore, also deploy references
4014         https://bugs.webkit.org/show_bug.cgi?id=167224
4015
4016         Reviewed by Chris Dumez.
4017
4018         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
4019         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
4020
4021         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
4022         * WebCoreSupport/WebChromeClient.mm:
4023         (WebChromeClient::focusedElementChanged): Ditto.
4024         (WebChromeClient::createWindow): Ditto.
4025         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
4026         (WebChromeClient::runJavaScriptAlert): Ditto.
4027         (WebChromeClient::runJavaScriptConfirm): Ditto.
4028         (WebChromeClient::runJavaScriptPrompt): Ditto.
4029         (WebChromeClient::contentsSizeChanged): Ditto.
4030         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
4031         (WebChromeClient::print): Ditto.
4032         (WebChromeClient::exceededDatabaseQuota): Ditto.
4033         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
4034         (WebChromeClient::createColorChooser): Ditto.
4035         (WebChromeClient::elementDidFocus): Ditto.
4036         (WebChromeClient::elementDidBlur): Ditto.
4037         (WebChromeClient::createPopupMenu): Ditto.
4038         (WebChromeClient::createSearchPopupMenu): Ditto.
4039         (WebChromeClient::attachRootGraphicsLayer): Ditto.
4040         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
4041         (WebChromeClient::supportsFullScreenForElement): Ditto.
4042         (WebChromeClient::enterFullScreenForElement): Ditto.
4043         (WebChromeClient::exitFullScreenForElement): Ditto.
4044
4045         * WebView/WebFrame.mm:
4046         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
4047         Updated for change to the appendChild function.
4048
4049 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
4050
4051         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
4052         https://bugs.webkit.org/show_bug.cgi?id=167276
4053
4054         Reviewed by Alex Christensen.
4055         
4056         It was usurped by -deviceOrientationChanged in 2014.
4057
4058         * WebView/WebFrame.mm:
4059         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
4060         * WebView/WebFramePrivate.h:
4061
4062 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
4063
4064         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
4065         https://bugs.webkit.org/show_bug.cgi?id=167271
4066
4067         Reviewed by Alex Christensen.
4068         
4069         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
4070         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
4071
4072         * WebView/WebView.mm:
4073         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
4074         * WebView/WebViewPrivate.h:
4075
4076 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4077
4078         Remove never changing IndexedDB RuntimeEnabledFeature
4079         https://bugs.webkit.org/show_bug.cgi?id=167278
4080
4081         Reviewed by Darin Adler.
4082
4083         * WebView/WebView.mm:
4084         (-[WebView _preferencesChanged:]):
4085
4086 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4087
4088         Cleanup RuntimeEnabledFeatures
4089         https://bugs.webkit.org/show_bug.cgi?id=167228
4090
4091         Reviewed by Simon Fraser.
4092
4093         * WebView/WebView.mm:
4094         (-[WebView _preferencesChanged:]):
4095
4096 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4097
4098         Remove outdated ENABLE(CSP_NEXT) build flag
4099         https://bugs.webkit.org/show_bug.cgi?id=167252
4100
4101         Reviewed by Brent Fulgham.
4102
4103         * Configurations/FeatureDefines.xcconfig:
4104
4105 2017-01-20  Antoine Quint  <graouts@apple.com>
4106
4107         [Modern Media Controls] Turn modern media controls on by default
4108         https://bugs.webkit.org/show_bug.cgi?id=165668
4109
4110         Reviewed by Dean Jackson.
4111
4112         Enabled modern media controls by default in WK1.
4113
4114         * WebView/WebPreferences.mm:
4115         (+[WebPreferences initialize]):
4116
4117 2017-01-19  Chris Dumez  <cdumez@apple.com>
4118
4119         iterable<> should be enabled on WK1
4120         https://bugs.webkit.org/show_bug.cgi?id=167221
4121         <rdar://problem/30108531>
4122
4123         Reviewed by Youenn Fablet.
4124
4125         * WebView/WebPreferenceKeysPrivate.h:
4126         * WebView/WebPreferences.mm:
4127         (-[WebPreferences setCustomElementsEnabled:]):
4128         (-[WebPreferences DOMIteratorEnabled]): Deleted.
4129         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
4130         * WebView/WebPreferencesPrivate.h:
4131         * WebView/WebView.mm:
4132         (-[WebView _preferencesChanged:]):
4133
4134 2017-01-19  Chris Dumez  <cdumez@apple.com>
4135
4136         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
4137         https://bugs.webkit.org/show_bug.cgi?id=167215
4138         <rdar://problem/29885052>
4139
4140         Reviewed by Andreas Kling.
4141
4142         Make sure HTML validation bubble gets dismissed when its associated
4143         element's frame gets detached and that we do not crash.
4144
4145         * WebCoreSupport/WebValidationMessageClient.h:
4146         * WebCoreSupport/WebValidationMessageClient.mm:
4147         (WebValidationMessageClient::documentDetached):
4148
4149 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>