Implement rendering support for the color-filter CSS property
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2
3         Implement rendering support for the color-filter CSS property
4         https://bugs.webkit.org/show_bug.cgi?id=185047
5         rdar://problem/39664967
6
7         Reviewed by Tim Horton.
8         
9         The body background should reflect the filtered color.
10
11         * WebView/WebFrame.mm:
12         (-[WebFrame _bodyBackgroundColor]):
13         * WebView/WebView.mm:
14         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
15
16 2018-04-26  Jer Noble  <jer.noble@apple.com>
17
18         WK_COCOA_TOUCH all the things.
19         https://bugs.webkit.org/show_bug.cgi?id=185006
20
21         Reviewed by Tim Horton.
22
23         * Configurations/WebKitLegacy.xcconfig:
24
25 2018-04-26  Daniel Bates  <dabates@apple.com>
26
27         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
28         https://bugs.webkit.org/show_bug.cgi?id=184161
29         <rdar://problem/39051645>
30
31         Reviewed by Dan Bernstein.
32
33         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
34         dropping a PDF embedded using an HTML image element into the same web view.
35
36         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
37         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
38         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
39         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
40         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
41         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
42         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
43         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
44         image document when navigated to directly. Since we can support dragging PDF document images we need to
45         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
46         We need to do both such queries before falling back to using the main resource of the Web Archive as
47         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
48         not an image document.
49
50         * Misc/WebNSPasteboardExtras.mm:
51         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
52
53 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
54
55         Disable content filtering in minimal simulator mode
56         https://bugs.webkit.org/show_bug.cgi?id=185027
57         <rdar://problem/39736091>
58
59         Reviewed by Jer Noble.
60
61         * Configurations/FeatureDefines.xcconfig:
62
63 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
64
65         [INTL] Implement Intl.PluralRules
66         https://bugs.webkit.org/show_bug.cgi?id=184312
67
68         Reviewed by JF Bastien.
69
70         Added Intl.PluralRules feature flag.
71
72         * Configurations/FeatureDefines.xcconfig:
73
74 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
75
76         Remove access to keychain from the WebContent process
77         https://bugs.webkit.org/show_bug.cgi?id=184428
78         <rdar://problem/13150903>
79
80         Reviewed by Brent Fulgham.
81
82         This patch does the followings:
83         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
84         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
85         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
86
87         * WebCoreSupport/WebChromeClient.h:
88         * WebCoreSupport/WebChromeClient.mm:
89         (WebChromeClient::signedPublicKeyAndChallengeString const):
90         * WebView/WebUIDelegatePrivate.h:
91
92 2018-04-24  Jer Noble  <jer.noble@apple.com>
93
94         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
95         https://bugs.webkit.org/show_bug.cgi?id=184786
96
97         Reviewed by Tim Horton.
98
99         * Configurations/WebKitLegacy.xcconfig:
100         * MigrateHeaders.make:
101
102 2018-04-23  Daniel Bates  <dabates@apple.com>
103
104         Implement Same-Site cookies
105         https://bugs.webkit.org/show_bug.cgi?id=159464
106         <rdar://problem/27196358>
107
108         Reviewed by Brent Fulgham.
109
110         Pass the Same-Site info through the strategy.
111
112         * WebCoreSupport/WebPlatformStrategies.h:
113         * WebCoreSupport/WebPlatformStrategies.mm:
114         (WebPlatformStrategies::cookiesForDOM):
115         (WebPlatformStrategies::setCookiesFromDOM):
116         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
117         (WebPlatformStrategies::getRawCookies):
118
119 2018-04-23  Zalan Bujtas  <zalan@apple.com>
120
121         [LayoutFormattingContext] Initial commit.
122         https://bugs.webkit.org/show_bug.cgi?id=184896
123
124         Reviewed by Antti Koivisto.
125
126         * Configurations/FeatureDefines.xcconfig:
127
128 2018-04-23  Daniel Bates  <dabates@apple.com>
129
130         Implement Same-Site cookies
131         https://bugs.webkit.org/show_bug.cgi?id=159464
132         <rdar://problem/27196358>
133
134         Reviewed by Brent Fulgham.
135
136         Pass the Same-Site info through the strategy.
137
138         * WebCoreSupport/WebPlatformStrategies.h:
139         * WebCoreSupport/WebPlatformStrategies.mm:
140         (WebPlatformStrategies::cookiesForDOM):
141         (WebPlatformStrategies::setCookiesFromDOM):
142         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
143         (WebPlatformStrategies::getRawCookies):
144
145 2018-04-20  Timothy Hatcher  <timothy@apple.com>
146
147         NULL dereference crash sometimes under [super initWithCoder:] in WebView
148
149         https://bugs.webkit.org/show_bug.cgi?id=184851
150         rdar://problem/39611236
151
152         Reviewed by Tim Horton.
153
154         * WebView/WebView.mm:
155         (-[WebView _commonInitializationWithFrameName:groupName:]):
156         (-[WebView effectiveAppearanceDidChange]):
157         Added a null check and call the code later in initialization.
158
159 2018-04-20  Tim Horton  <timothy_horton@apple.com>
160
161         Adjust geolocation feature flag
162         https://bugs.webkit.org/show_bug.cgi?id=184856
163
164         Reviewed by Wenson Hsieh.
165
166         * Configurations/FeatureDefines.xcconfig:
167
168 2018-04-18  Jer Noble  <jer.noble@apple.com>
169
170         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
171         https://bugs.webkit.org/show_bug.cgi?id=184762
172
173         Reviewed by Dan Bernstein.
174
175         * Configurations/WebKitLegacy.xcconfig:
176
177 2018-04-20  Youenn Fablet  <youenn@apple.com>
178
179         Make PluginData cache its web visible plugins
180         https://bugs.webkit.org/show_bug.cgi?id=184421
181
182         Reviewed by Chris Dumez.
183
184         * WebCoreSupport/WebPluginInfoProvider.h:
185         * WebCoreSupport/WebPluginInfoProvider.mm:
186         (WebPluginInfoProvider::pluginInfo):
187         (WebPluginInfoProvider::webVisiblePluginInfo):
188
189 2018-04-19  Chris Dumez  <cdumez@apple.com>
190
191         Rename JSDOMWindowProxy to JSWindowProxy
192         https://bugs.webkit.org/show_bug.cgi?id=184797
193
194         Reviewed by Sam Weinig.
195
196         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
197
198         * DOM/DOMUtility.mm:
199         (createDOMWrapper):
200         * WebView/WebFrame.mm:
201         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
202
203 2018-04-19  David Kilzer  <ddkilzer@apple.com>
204
205         Enable Objective-C weak references
206         <https://webkit.org/b/184789>
207         <rdar://problem/39571716>
208
209         Reviewed by Dan Bernstein.
210
211         * Configurations/Base.xcconfig:
212         (CLANG_ENABLE_OBJC_WEAK): Enable.
213
214 2018-04-18  Chris Dumez  <cdumez@apple.com>
215
216         Rename WindowProxyController to WindowProxy
217         https://bugs.webkit.org/show_bug.cgi?id=184756
218
219         Reviewed by Sam Weinig.
220
221         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
222         needed use WindowProxyController type, which was a bit confusing.
223
224         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
225         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
226         * WebView/WebFrame.mm:
227         (-[WebFrame _attachScriptDebugger]):
228
229 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
230
231         Unreviewed rollout of r230632. Regression in memory usage.
232
233         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
234
235         * WebView/WebPreferences.mm:
236         (+[WebPreferences initialize]):
237
238 2018-04-17  Chris Dumez  <cdumez@apple.com>
239
240         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
241         https://bugs.webkit.org/show_bug.cgi?id=184678
242         <rdar://problem/39422122>
243
244         Reviewed by Alex Christensen.
245
246         Add new parameter to dispatchDecidePolicyForNavigationAction.
247
248         * WebCoreSupport/WebFrameLoaderClient.h:
249         * WebCoreSupport/WebFrameLoaderClient.mm:
250         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
251
252 2018-04-13  Chris Dumez  <cdumez@apple.com>
253
254         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
255         https://bugs.webkit.org/show_bug.cgi?id=184591
256
257         Reviewed by Sam Weinig.
258
259         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
260         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
261         This is work towards fixing Bug 184515.
262
263         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
264         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
265         * WebView/WebFrame.mm:
266         (-[WebFrame _attachScriptDebugger]):
267
268 2018-04-12  Antoine Quint  <graouts@apple.com>
269
270         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
271         https://bugs.webkit.org/show_bug.cgi?id=184569
272         <rdar://problem/38671301>
273
274         Reviewed by Jon Lee.
275
276         * WebView/WebPreferences.mm:
277
278 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
279
280         [WTF] Remove StaticLock
281         https://bugs.webkit.org/show_bug.cgi?id=184332
282
283         Reviewed by Mark Lam.
284
285         * DOM/DOMInternal.mm:
286         (getDOMWrapper):
287         (addDOMWrapper):
288         (removeDOMWrapper):
289
290 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
291
292         Failures from mach port reference handling should be fatal
293         https://bugs.webkit.org/show_bug.cgi?id=184202
294         <rdar://problem/37771114>
295
296         Reviewed by Anders Carlsson.
297
298         * Plugins/Hosted/NetscapePluginHostManager.mm:
299         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
300
301 2018-04-03  Andy Estes  <aestes@apple.com>
302
303         [Mac] Prioritize file promises over filenames during drag and drop
304         https://bugs.webkit.org/show_bug.cgi?id=184237
305         <rdar://problem/38278076>
306
307         Reviewed by Wenson Hsieh.
308
309         * WebView/WebView.mm:
310         (-[WebView performDragOperation:]):
311
312 2018-04-03  Chris Dumez  <cdumez@apple.com>
313
314         Drop MainFrame class
315         https://bugs.webkit.org/show_bug.cgi?id=184191
316
317         Reviewed by Darin Adler.
318
319         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
320         relationship between the Page and the MainFrame.
321
322         This is ground work for introducing LocalFrame / RemoteFrame concepts.
323
324         * WebCoreSupport/WebDragClient.mm:
325         * WebCoreSupport/WebFrameLoaderClient.mm:
326         * WebCoreSupport/WebInspectorClient.mm:
327         * WebCoreSupport/WebPlatformStrategies.mm:
328         * WebCoreSupport/WebPluginInfoProvider.mm:
329         * WebView/WebFrame.mm:
330         * WebView/WebFrameView.mm:
331         * WebView/WebHTMLView.mm:
332         * WebView/WebView.mm:
333
334 2018-04-02  Jer Noble  <jer.noble@apple.com>
335
336         Enable Legacy EME for all WebKit & WebKitLegacy clients
337         https://bugs.webkit.org/show_bug.cgi?id=184018
338         <rdar://problem/34887387>
339
340         Reviewed by Eric Carlson.
341
342         * WebView/WebPreferences.mm:
343         (+[WebPreferences initialize]):
344
345 2018-03-29  JF Bastien  <jfbastien@apple.com>
346
347         Use Forward.h instead of forward-declaring WTF::String
348         https://bugs.webkit.org/show_bug.cgi?id=184172
349         <rdar://problem/39026146>
350
351         Reviewed by Yusuke Suzuki.
352
353         As part of #184164 I'm changing WTF::String, and the forward
354         declarations are just wrong because I'm making it templated. We
355         should use Forward.h anyways, so do that instead.
356
357         * WebView/WebScriptDebugger.h:
358
359 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
360
361         Protect against invalid mach ports returned by mach_port_request_notification
362         https://bugs.webkit.org/show_bug.cgi?id=184106
363         <rdar://problem/37865316>
364
365         Reviewed by Chris Dumez.
366
367         * Plugins/Hosted/NetscapePluginHostProxy.mm:
368         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
369         and clean up if it experienced an error.
370         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
371
372 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
373
374         Avoid uninitialized mach ports
375         https://bugs.webkit.org/show_bug.cgi?id=184090
376         <rdar://problem/37261129>
377
378         Reviewed by Chris Dumez.
379
380         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
381         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
382         there is a potential for us to try to use invalid ports.
383
384         We should always check return values, and ensure that the mach port variables we seek to initialize are
385         kept in a valid state.
386
387         Reviewed by Chris Dumez.
388
389         * Plugins/Hosted/NetscapePluginHostManager.h:
390         * Plugins/Hosted/NetscapePluginHostManager.mm:
391         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
392         port is passed to an API function.
393         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
394         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
395         * Plugins/Hosted/NetscapePluginHostProxy.h:
396         * Plugins/Hosted/NetscapePluginHostProxy.mm:
397         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
398         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
399         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
400         (WKPCStatusText): Ditto.
401         (WKPCLoadURL): Ditto.
402         (WKPCCancelLoadURL): Ditto.
403         (WKPCInvalidateRect): Ditto.
404         (WKPCGetScriptableNPObjectReply): Ditto.
405         (WKPCBooleanReply): Ditto.
406         (WKPCBooleanAndDataReply): Ditto.
407         (WKPCInstantiatePluginReply): Ditto.
408         (WKPCGetWindowNPObject): Ditto.
409         (WKPCGetPluginElementNPObject): Ditto.
410         (WKPCForgetBrowserObject): Ditto.
411         (WKPCEvaluate): Ditto.
412         (WKPCGetStringIdentifier): Ditto.
413         (WKPCGetIntIdentifier): Ditto.
414         (WKPCInvoke): Ditto.
415         (WKPCInvokeDefault): Ditto.
416         (WKPCConstruct): Ditto.
417         (WKPCGetProperty): Ditto.
418         (WKPCSetProperty): Ditto.
419         (WKPCRemoveProperty): Ditto.
420         (WKPCHasProperty): Ditto.
421         (WKPCHasMethod): Ditto.
422         (WKPCIdentifierInfo): Ditto.
423         (WKPCEnumerate): Ditto.
424         (WKPCSetMenuBarVisible): Ditto.
425         (WKPCSetFullscreenWindowIsShowing): Ditto.
426         (WKPCSetModal): Ditto.
427         (WKPCGetCookies): Ditto.
428         (WKPCGetProxy): Ditto.
429         (WKPCSetCookies): Ditto.
430         (WKPCGetAuthenticationInfo): Ditto.
431         (WKPCConvertPoint): Ditto.
432         (WKPCLayerHostingModeChanged): Ditto.
433         (WKPCSetException): Ditto.
434
435 2018-03-26  Tim Horton  <timothy_horton@apple.com>
436
437         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
438         https://bugs.webkit.org/show_bug.cgi?id=184030
439         <rdar://problem/38895281>
440
441         Reviewed by Dan Bernstein.
442
443         * Configurations/Base.xcconfig:
444
445 2018-03-26  Chris Dumez  <cdumez@apple.com>
446
447         Use SecurityOriginData more consistently in Service Worker code
448         https://bugs.webkit.org/show_bug.cgi?id=183969
449
450         Reviewed by Darin Adler.
451
452         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
453
454         * Storage/WebDatabaseManager.mm:
455         (-[WebDatabaseManager databasesWithOrigin:]):
456         (-[WebDatabaseManager deleteOrigin:]):
457         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
458         * Storage/WebDatabaseQuotaManager.mm:
459         (-[WebDatabaseQuotaManager usage]):
460         (-[WebDatabaseQuotaManager quota]):
461         (-[WebDatabaseQuotaManager setQuota:]):
462         * Storage/WebStorageManager.mm:
463         (-[WebStorageManager deleteOrigin:]):
464         * WebCoreSupport/WebSecurityOrigin.mm:
465         (-[WebSecurityOrigin databaseIdentifier]):
466         (-[WebSecurityOrigin usage]):
467         (-[WebSecurityOrigin quota]):
468         (-[WebSecurityOrigin setQuota:]):
469
470 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
471
472         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
473         https://bugs.webkit.org/show_bug.cgi?id=183911
474         <rdar://problem/38762306>
475
476         Reviewed by Youenn Fablet.
477
478         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
479
480         * WebView/WebView.mm:
481         (+[WebView initialize]):
482
483 2018-03-26  Alex Christensen  <achristensen@webkit.org>
484
485         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
486         https://bugs.webkit.org/show_bug.cgi?id=183965
487
488         Reviewed by Chris Dumez.
489
490         * WebCoreSupport/WebFrameLoaderClient.h:
491         * WebCoreSupport/WebFrameLoaderClient.mm:
492         (WebFrameLoaderClient::willCacheResponse const):
493
494 2018-03-25  Commit Queue  <commit-queue@webkit.org>
495
496         Unreviewed, rolling out r229954.
497         https://bugs.webkit.org/show_bug.cgi?id=184000
498
499         Caused many layout tests to crash on Apple High Sierra,
500         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
501         by dydz on #webkit).
502
503         Reverted changeset:
504
505         "Use SecurityOriginData more consistently in Service Worker
506         code"
507         https://bugs.webkit.org/show_bug.cgi?id=183969
508         https://trac.webkit.org/changeset/229954
509
510 2018-03-24  Chris Dumez  <cdumez@apple.com>
511
512         Use SecurityOriginData more consistently in Service Worker code
513         https://bugs.webkit.org/show_bug.cgi?id=183969
514
515         Reviewed by Darin Adler.
516
517         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
518
519         * Storage/WebDatabaseManager.mm:
520         (-[WebDatabaseManager databasesWithOrigin:]):
521         (-[WebDatabaseManager deleteOrigin:]):
522         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
523         * Storage/WebDatabaseQuotaManager.mm:
524         (-[WebDatabaseQuotaManager usage]):
525         (-[WebDatabaseQuotaManager quota]):
526         (-[WebDatabaseQuotaManager setQuota:]):
527         * Storage/WebStorageManager.mm:
528         (-[WebStorageManager deleteOrigin:]):
529         * WebCoreSupport/WebSecurityOrigin.mm:
530         (-[WebSecurityOrigin databaseIdentifier]):
531         (-[WebSecurityOrigin usage]):
532         (-[WebSecurityOrigin quota]):
533         (-[WebSecurityOrigin setQuota:]):
534
535 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
536
537         Fix the build
538
539         * WebView/WebView.mm:
540
541 2018-03-23  Tim Horton  <timothy_horton@apple.com>
542
543         Fix the build with no pasteboard
544         https://bugs.webkit.org/show_bug.cgi?id=183973
545
546         Reviewed by Dan Bernstein.
547
548         * Configurations/FeatureDefines.xcconfig:
549         * WebView/WebView.mm:
550         (-[WebView _requestStartDataInteraction:globalPosition:]):
551         (-[WebView _getDataInteractionData]):
552         (-[WebView _dataOperationTextIndicator]):
553         (-[WebView _dragSourceAction]):
554         (-[WebView _draggedLinkTitle]):
555         (-[WebView _draggedLinkURL]):
556         (-[WebView _draggedElementBounds]):
557         (-[WebView _enteredDataInteraction:client:global:operation:]):
558         (-[WebView _updatedDataInteraction:client:global:operation:]):
559         (-[WebView _exitedDataInteraction:client:global:operation:]):
560         (-[WebView _performDataInteraction:client:global:operation:]):
561         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
562         (-[WebView _endedDataInteraction:global:]):
563         (-[WebView _dataInteractionCaretRect]):
564         * WebView/WebViewPrivate.h:
565
566 2018-03-23  Tim Horton  <timothy_horton@apple.com>
567
568         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
569         https://bugs.webkit.org/show_bug.cgi?id=183960
570         <rdar://problem/38812356>
571
572         Reviewed by Dan Bernstein.
573
574         * Configurations/WebKitLegacy.xcconfig:
575
576 2018-03-23  Tim Horton  <timothy_horton@apple.com>
577
578         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
579         https://bugs.webkit.org/show_bug.cgi?id=183954
580         <rdar://problem/38808858>
581
582         Reviewed by Dan Bernstein.
583
584         * WebView/WebPreferences.mm:
585         (-[WebPreferences setAudioSessionCategoryOverride:]):
586
587 2018-03-23  Tim Horton  <timothy_horton@apple.com>
588
589         Adopt WK_PLATFORM_NAME in WebKitLegacy
590         https://bugs.webkit.org/show_bug.cgi?id=183948
591         <rdar://problem/38803908>
592
593         Reviewed by Dan Bernstein.
594
595         * Configurations/WebKitLegacy.xcconfig:
596         * MigrateHeaders.make:
597         * postprocess-headers.sh:
598
599 2018-03-23  Brady Eidson  <beidson@apple.com>
600
601         Go to back/forward list items after a process-swapped navigation.
602         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
603
604         Reviewed by Andy Estes.
605
606         * WebView/WebView.mm:
607         (-[WebView _loadBackForwardListFromOtherView:]):
608         (-[WebView goToBackForwardItem:]):
609
610 2018-03-22  Tim Horton  <timothy_horton@apple.com>
611
612         Improve readability of WebCore's OTHER_LDFLAGS
613         https://bugs.webkit.org/show_bug.cgi?id=183909
614         <rdar://problem/38760992>
615
616         Reviewed by Dan Bernstein.
617
618         * Configurations/Base.xcconfig:
619         * Configurations/FeatureDefines.xcconfig:
620
621 2018-03-20  Tim Horton  <timothy_horton@apple.com>
622
623         Enable the minimal simulator feature flag when appropriate
624         https://bugs.webkit.org/show_bug.cgi?id=183807
625
626         Reviewed by Dan Bernstein.
627
628         * Configurations/FeatureDefines.xcconfig:
629
630 2018-03-20  Tim Horton  <timothy_horton@apple.com>
631
632         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
633         https://bugs.webkit.org/show_bug.cgi?id=183758
634         <rdar://problem/38017644>
635
636         Reviewed by Dan Bernstein.
637
638         * Configurations/FeatureDefines.xcconfig:
639
640 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
641
642         Clear style colors when setting default appearance
643         https://bugs.webkit.org/show_bug.cgi?id=183759
644
645         Reviewed by Tim Horton.
646
647         Colors are cached and need to be cleared and recalculated.
648         Refactor to do all style recalcs together.
649
650         * WebView/WebView.mm:
651         (-[WebView _setDefaultAppearanceAndClearStyle]):
652         (-[WebView _setUseSystemAppearance:]):
653         (-[WebView effectiveAppearanceDidChange]):
654
655 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
656
657         Unreviewed, another quick fix for r229699
658
659         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
660
661         * Configurations/FeatureDefines.xcconfig:
662
663 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
664
665         Ensure that style is updated when the effective appearance changes
666         https://bugs.webkit.org/show_bug.cgi?id=183690
667         <rdar://problem/38385900>
668
669         Reviewed by Tim Horton and Wenson Hsieh.
670
671         Respond to and respect the effective appearance changing.
672
673         * WebView/WebView.mm:
674         (-[WebView _setUseSystemAppearance:]):
675         (-[WebView effectiveAppearanceDidChange]):
676
677 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
678
679         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
680         https://bugs.webkit.org/show_bug.cgi?id=183677
681
682         Reviewed by Tim Horton.
683
684         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
685
686         * DOM/DOM.mm:
687         (-[DOMHTMLLinkElement _mediaQueryMatches]):
688
689 2018-03-14  Tim Horton  <timothy_horton@apple.com>
690
691         Fix the build after r229567
692
693         * Configurations/FeatureDefines.xcconfig:
694
695 2018-03-12  Tim Horton  <timothy_horton@apple.com>
696
697         Stop using SDK conditionals to control feature definitions
698         https://bugs.webkit.org/show_bug.cgi?id=183430
699         <rdar://problem/38251619>
700
701         Reviewed by Dan Bernstein.
702
703         * Configurations/FeatureDefines.xcconfig:
704         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
705
706 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
707
708         Runtime flag for link prefetch and remove link subresource.
709         https://bugs.webkit.org/show_bug.cgi?id=183540
710
711         Reviewed by Chris Dumez.
712
713         Remove the LINK_PREFETCH build time flag.
714
715         * Configurations/FeatureDefines.xcconfig:
716
717 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
718
719         Remove GridLayout runtime flag
720         https://bugs.webkit.org/show_bug.cgi?id=183484
721
722         Reviewed by Myles C. Maxfield.
723
724         The Grid Layout feature has been enabled by default for almost a
725         year, so I think it's time to remove the runtime flag and the
726
727         * WebView/WebPreferenceKeysPrivate.h:
728         * WebView/WebPreferences.mm:
729         (+[WebPreferences initialize]):
730         * WebView/WebPreferencesPrivate.h:
731         * WebView/WebView.mm:
732         (-[WebView _preferencesChanged:]):
733
734 2018-03-12  Antoine Quint  <graouts@apple.com>
735
736         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
737         https://bugs.webkit.org/show_bug.cgi?id=183504
738         <rdar://problem/38372965>
739
740         Reviewed by Dean Jackson and Jon Lee.
741
742         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
743         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
744
745         * WebView/WebPreferenceKeysPrivate.h:
746         * WebView/WebPreferences.mm:
747         (+[WebPreferences initialize]):
748         (-[WebPreferences setModernMediaControlsEnabled:]):
749         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
750         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
751         * WebView/WebPreferencesPrivate.h:
752         * WebView/WebView.mm:
753         (-[WebView _preferencesChanged:]):
754
755 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
756
757         Media query for default appearance
758         https://bugs.webkit.org/show_bug.cgi?id=183539
759         <rdar://problem/38326388>
760
761         Reviewed by Tim Horton.
762
763         Write a media query to evaluate appearance.
764
765         * WebView/WebView.mm:
766         (-[WebView _commonInitializationWithFrameName:groupName:]):
767         (-[WebView _setUseSystemAppearance:]):
768
769 2018-03-09  Andy Estes  <aestes@apple.com>
770
771         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
772         https://bugs.webkit.org/show_bug.cgi?id=183489
773         <rdar://problem/38267517>
774
775         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
776         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
777         to issue a sandbox extension for this directory, but for security reasons App Sandbox
778         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
779         block with a nil error and a valid file URL, but no file will actually exist at that URL.
780
781         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
782         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
783         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
784         drop destination.
785
786         Reviewed by Wenson Hsieh.
787
788         * WebView/WebView.mm:
789         (-[WebView performDragOperation:]):
790
791 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
792
793         Allow WebViews to disable system appearance
794         https://bugs.webkit.org/show_bug.cgi?id=183418
795         <rdar://problem/36975642>
796
797         Reviewed by Tim Horton.
798
799         Allow webviews to choose whether or not to follow the default system appearance.
800
801         * WebView/WebView.mm:
802         (-[WebView _setUseSystemAppearance:]):
803         (-[WebView _useSystemAppearance]):
804         * WebView/WebViewPrivate.h:
805
806 2018-03-08  Youenn Fablet  <youenn@apple.com>
807
808         libwebrtc update broke internal builds
809         https://bugs.webkit.org/show_bug.cgi?id=183454
810
811         Reviewed by Eric Carlson.
812
813         * Configurations/WebKitLegacy.xcconfig:
814
815 2018-03-08  Chris Dumez  <cdumez@apple.com>
816
817         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
818         https://bugs.webkit.org/show_bug.cgi?id=183455
819         <rdar://problem/38191749>
820
821         Reviewed by Youenn Fablet.
822
823         Add a null check for the page as we have evidence from crashes that it can be null.
824         Other functions in WebFrameNetworkingContext already null check the page as well,
825         not just the frame so this is consistent.
826
827         * WebCoreSupport/WebFrameNetworkingContext.mm:
828         (WebFrameNetworkingContext::storageSession const):
829
830 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
831
832         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
833         https://bugs.webkit.org/show_bug.cgi?id=183429
834
835         Reviewed by Mark Lam.
836
837         * DOM/DOM.mm:
838         (+[DOMNode _nodeFromJSWrapper:]):
839         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
840         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
841         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
842         * Plugins/Hosted/ProxyInstance.mm:
843         (WebKit::ProxyInstance::invokeMethod):
844         * WebView/WebView.mm:
845         (aeDescFromJSValue):
846
847 2018-03-08  Tim Horton  <timothy_horton@apple.com>
848
849         Stop linking ApplicationServices directly
850         https://bugs.webkit.org/show_bug.cgi?id=182867
851         <rdar://problem/38252142>
852
853         Reviewed by Alex Christensen.
854
855         The frameworks that we use that live inside ApplicationServices
856         have mostly moved out, so import them directly.
857
858         * Carbon/CarbonUtils.h:
859         * WebKitPrefix.h:
860         * WebView/WebHTMLView.mm:
861         * WebView/WebPDFView.mm:
862
863 2018-03-07  Tim Horton  <timothy_horton@apple.com>
864
865         Sort and separate FeatureDefines.xcconfig
866         https://bugs.webkit.org/show_bug.cgi?id=183427
867
868         Reviewed by Dan Bernstein.
869
870         * Configurations/FeatureDefines.xcconfig:
871         Sort and split FeatureDefines into paragraphs
872         (to make it easier to sort later).
873
874 2018-03-07  Youenn Fablet  <youenn@apple.com>
875
876         Match unsupported plugins based on domains and not origin
877         https://bugs.webkit.org/show_bug.cgi?id=183384
878
879         Reviewed by Chris Dumez.
880
881         * WebCoreSupport/WebPluginInfoProvider.h:
882         * WebCoreSupport/WebPluginInfoProvider.mm:
883         (WebPluginInfoProvider::getPluginInfo):
884         (WebPluginInfoProvider::getWebVisiblePluginInfo):
885
886 2018-03-05  Andy Estes  <aestes@apple.com>
887
888         [Mac] Teach WebCore::Pasteboard about file promise drags
889         https://bugs.webkit.org/show_bug.cgi?id=183314
890         <rdar://problem/38105493>
891
892         Reviewed by Darin Adler.
893
894         Added a FIXME comment.
895
896         * WebView/WebView.mm:
897         (-[WebView performDragOperation:]):
898
899 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
900
901         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
902         https://bugs.webkit.org/show_bug.cgi?id=183312
903
904         Reviewed by Mark Lam.
905
906         Remove wtf/CurrentTime.h include pragma.
907
908         * WebView/WebFrame.mm:
909         * WebView/WebPDFView.mm:
910
911 2018-03-04  Tim Horton  <timothy_horton@apple.com>
912
913         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
914         https://bugs.webkit.org/show_bug.cgi?id=183283
915         <rdar://problem/38062148>
916
917         Reviewed by Sam Weinig.
918
919         * Configurations/FeatureDefines.xcconfig:
920
921 2018-02-28  Alex Christensen  <achristensen@webkit.org>
922
923         Reduce use of NetworkingContext in WebKit
924         https://bugs.webkit.org/show_bug.cgi?id=183213
925
926         Reviewed by Brady Eidson.
927
928         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
929         (WebKit::NetscapePluginInstanceProxy::getProxy):
930         * Plugins/WebNetscapePluginView.mm:
931         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
932
933 2018-02-17  Darin Adler  <darin@apple.com>
934
935         Prepare for ExtendedColor changes (first step)
936         https://bugs.webkit.org/show_bug.cgi?id=182904
937
938         Reviewed by Sam Weinig.
939
940         * Misc/WebKitNSStringExtras.mm:
941         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
942
943 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
944
945         Remove currentTime() / currentTimeMS()
946         https://bugs.webkit.org/show_bug.cgi?id=183052
947
948         Reviewed by Mark Lam.
949
950         * WebCoreSupport/WebFrameLoaderClient.h:
951         * WebCoreSupport/WebFrameLoaderClient.mm:
952         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
953
954 2018-02-16  Youenn Fablet  <youenn@apple.com>
955
956         Allow specifying which plug-ins are supported
957         https://bugs.webkit.org/show_bug.cgi?id=182748
958
959         Reviewed by Chris Dumez.
960
961         * WebCoreSupport/WebPluginInfoProvider.h:
962         * WebCoreSupport/WebPluginInfoProvider.mm:
963         (WebPluginInfoProvider::getPluginInfo):
964         (WebPluginInfoProvider::getWebVisiblePluginInfo):
965
966 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
967
968         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
969         https://bugs.webkit.org/show_bug.cgi?id=182882
970         <rdar://problem/35672661>
971
972         Reviewed by Dan Bernstein.
973
974         Make sure the smart pointer hold the collection of subviews lives at least as
975         long as the loop using it.
976
977         * WebView/WebHTMLView.mm:
978         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
979
980 2018-02-14  Daniel Bates  <dabates@apple.com>
981
982         Disallow cross-origin subresources from asking for credentials
983         https://bugs.webkit.org/show_bug.cgi?id=182579
984         <rdar://problem/36162271>
985
986         Reviewed by Andy Estes.
987
988         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
989         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
990
991         * WebView/WebPreferenceKeysPrivate.h:
992         * WebView/WebPreferences.mm:
993         (+[WebPreferences initialize]):
994         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
995         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
996         * WebView/WebPreferencesPrivate.h:
997         * WebView/WebView.mm:
998         (-[WebView _preferencesChanged:]):
999
1000 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1001
1002         Remove ForwardingHeaders directory from WebKitLegacy/mac.
1003         https://bugs.webkit.org/show_bug.cgi?id=182738
1004
1005         Reviewed by Darin Adler.
1006
1007         * ForwardingHeaders/collector/handles/Global.h: Removed.
1008         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
1009         * ForwardingHeaders/runtime/Completion.h: Removed.
1010         * ForwardingHeaders/runtime/Error.h: Removed.
1011         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
1012         * ForwardingHeaders/runtime/JSFunction.h: Removed.
1013         * ForwardingHeaders/runtime/JSLock.h: Removed.
1014         * ForwardingHeaders/runtime/JSObject.h: Removed.
1015         * ForwardingHeaders/runtime/JSString.h: Removed.
1016         * ForwardingHeaders/runtime/Protect.h: Removed.
1017         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
1018
1019 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1020
1021         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
1022         https://bugs.webkit.org/show_bug.cgi?id=182641
1023
1024         Reviewed by Dan Bernstein.
1025
1026         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1027         https://trac.webkit.org/changeset/228308.
1028
1029         * WebView/WebVideoFullscreenController.h:
1030         * WebView/WebVideoFullscreenHUDWindowController.mm:
1031         * WebView/WebWindowAnimation.h:
1032         * WebView/WebWindowAnimation.mm:
1033         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1034         (WebCore::scaledRect): Deleted.
1035         (WebCore::squaredDistance): Deleted.
1036
1037 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1038
1039         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1040
1041         * WebView/WebWindowAnimation.mm:
1042         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1043
1044 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1045
1046         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1047         https://bugs.webkit.org/show_bug.cgi?id=182615
1048
1049         Reviewed by Eric Carlson.
1050
1051         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1052         Ideally, we should not reference NSApp in WebCore.
1053
1054         * WebView/WebFullScreenController.mm:
1055         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1056         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1057         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1058         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1059         * WebView/WebView.mm:
1060         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1061         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1062
1063 2018-01-13  Darin Adler  <darin@apple.com>
1064
1065         Event improvements
1066         https://bugs.webkit.org/show_bug.cgi?id=179591
1067
1068         Reviewed by Chris Dumez.
1069
1070         * DOM/DOMWheelEvent.mm:
1071         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1072         Call initWebKitWheelEvent.
1073
1074         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1075         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1076         * WebView/WebFrame.mm: Ditto.
1077
1078         * WebView/WebHTMLView.mm:
1079         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1080         underlyingPlatformEvent.
1081         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1082
1083         * WebView/WebScriptWorld.mm:
1084         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1085
1086         * WebView/WebView.mm: Removed include of ScriptValue.h.
1087
1088 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1089
1090         Remove WebCore/ForwardingHeaders directory
1091         https://bugs.webkit.org/show_bug.cgi?id=182347
1092
1093         Reviewed by Keith Miller.
1094
1095         * Carbon/CarbonWindowAdapter.mm:
1096         * DOM/WebDOMOperations.mm:
1097         * History/WebBackForwardList.mm:
1098         * History/WebHistoryItem.mm:
1099         * Misc/WebCache.mm:
1100         * Misc/WebElementDictionary.mm:
1101         * Misc/WebIconDatabase.mm:
1102         * Misc/WebStringTruncator.mm:
1103         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1104         * Plugins/Hosted/ProxyInstance.mm:
1105         * Plugins/Hosted/ProxyRuntimeObject.mm:
1106         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1107         * Plugins/WebBaseNetscapePluginView.mm:
1108         * Plugins/WebBasePluginPackage.mm:
1109         * Plugins/WebNetscapePluginStream.mm:
1110         * Plugins/WebNetscapePluginView.mm:
1111         * Plugins/WebPluginController.mm:
1112         * WebCoreSupport/WebEditorClient.mm:
1113         * WebCoreSupport/WebFrameLoaderClient.mm:
1114         * WebCoreSupport/WebInspectorClient.h:
1115         * WebCoreSupport/WebInspectorClient.mm:
1116         * WebView/WebDataSource.mm:
1117         * WebView/WebFrame.mm:
1118         * WebView/WebHTMLRepresentation.mm:
1119         * WebView/WebHTMLView.mm:
1120         * WebView/WebPreferences.mm:
1121         * WebView/WebScriptDebugDelegate.mm:
1122         * WebView/WebScriptDebugger.h:
1123         * WebView/WebTextIterator.mm:
1124         * WebView/WebView.mm:
1125         * WebView/WebViewData.mm:
1126
1127 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1128
1129         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1130         https://bugs.webkit.org/show_bug.cgi?id=182312
1131
1132         Reviewed by Michael Catanzaro.
1133
1134         * WebKitPrefix.h:
1135
1136 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1137
1138         [WebAuthN] Add a compile-time feature flag
1139         https://bugs.webkit.org/show_bug.cgi?id=182211
1140         <rdar://problem/36936365>
1141
1142         Reviewed by Brent Fulgham.
1143
1144         * Configurations/FeatureDefines.xcconfig:
1145
1146 2018-01-27  Dan Bernstein  <mitz@apple.com>
1147
1148         HaveInternalSDK includes should be "#include?"
1149         https://bugs.webkit.org/show_bug.cgi?id=179670
1150
1151         * Configurations/Base.xcconfig:
1152
1153 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1154
1155         Remove unused QTKit preference
1156         https://bugs.webkit.org/show_bug.cgi?id=181968
1157
1158         Reviewed by Alexey Proskuryakov.
1159
1160         * WebView/WebPreferenceKeysPrivate.h:
1161         * WebView/WebPreferences.mm:
1162         (+[WebPreferences initialize]):
1163         (-[WebPreferences setQTKitEnabled:]): Deleted.
1164         (-[WebPreferences isQTKitEnabled]): Deleted.
1165         * WebView/WebPreferencesPrivate.h:
1166         * WebView/WebView.mm:
1167         (-[WebView _preferencesChanged:]):
1168
1169 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1170
1171         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1172         https://bugs.webkit.org/show_bug.cgi?id=182037
1173         <rdar://problem/36747812>
1174
1175         Reviewed by Ryosuke Niwa.
1176
1177         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1178         for more details.
1179
1180         * WebView/WebHTMLRepresentation.mm:
1181         (-[WebHTMLRepresentation elementWithName:inForm:]):
1182         (-[WebHTMLRepresentation controlsInForm:]):
1183
1184 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1185
1186         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1187         https://bugs.webkit.org/show_bug.cgi?id=181961
1188
1189         Reviewed by Michael Catanzaro.
1190
1191         * WebView/WebPreferences.mm:
1192
1193 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1194
1195         Unreviewed, rolling out r227437.
1196         https://bugs.webkit.org/show_bug.cgi?id=182011
1197
1198         broke build (Requested by alexchristensen on #webkit).
1199
1200         Reverted changeset:
1201
1202         "Remove unused QTKit preference"
1203         https://bugs.webkit.org/show_bug.cgi?id=181968
1204         https://trac.webkit.org/changeset/227437
1205
1206 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1207
1208         Remove unused QTKit preference
1209         https://bugs.webkit.org/show_bug.cgi?id=181968
1210
1211         Reviewed by Alexey Proskuryakov.
1212
1213         * WebView/WebPreferenceKeysPrivate.h:
1214         * WebView/WebPreferences.mm:
1215         (+[WebPreferences initialize]):
1216         (-[WebPreferences setQTKitEnabled:]): Deleted.
1217         (-[WebPreferences isQTKitEnabled]): Deleted.
1218         * WebView/WebPreferencesPrivate.h:
1219         * WebView/WebView.mm:
1220         (-[WebView _preferencesChanged:]):
1221
1222 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1223
1224         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1225         https://bugs.webkit.org/show_bug.cgi?id=181960
1226         <rdar://problem/36431678>
1227
1228         Reviewed by Tim Horton.
1229
1230         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1231         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1232         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1233
1234         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1235         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1236         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1237
1238         * WebView/WebView.mm:
1239         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1240
1241 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1242
1243         Turning off custom pasteboard data doesn't actually turn it off in WK2
1244         https://bugs.webkit.org/show_bug.cgi?id=181920
1245         <rdar://problem/36686429>
1246
1247         Reviewed by Wenson Hsieh.
1248
1249         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1250
1251         * WebView/WebPreferences.mm:
1252         (+[WebPreferences initialize]):
1253         * WebView/WebView.mm:
1254         (-[WebView _preferencesChanged:]):
1255
1256 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1257
1258         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1259         https://bugs.webkit.org/show_bug.cgi?id=181918
1260
1261         Reviewed by Tim Horton.
1262
1263         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1264
1265         * Configurations/FeatureDefines.xcconfig:
1266
1267 2018-01-20  Andy Estes  <aestes@apple.com>
1268
1269         [Apple Pay] Stop eagerly loading PassKit.framework
1270         https://bugs.webkit.org/show_bug.cgi?id=181911
1271         <rdar://problem/36555369>
1272
1273         Reviewed by Tim Horton.
1274
1275         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1276         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1277         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1278
1279         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1280
1281 2018-01-19  Dean Jackson  <dino@apple.com>
1282
1283         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1284         https://bugs.webkit.org/show_bug.cgi?id=181817
1285         <rdar://problem/35274055>
1286
1287         Reviewed by Simon Fraser.
1288
1289         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1290
1291         * Misc/WebKitVersionChecks.h:
1292         * WebView/WebView.mm:
1293         (-[WebView _commonInitializationWithFrameName:groupName:]):
1294
1295 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1296
1297         Remove unused WebViewPrivate _allowCookies
1298         https://bugs.webkit.org/show_bug.cgi?id=181812
1299
1300         Reviewed by Tim Horton.
1301
1302         * WebView/WebView.mm:
1303         (+[WebView _setAllowCookies:]): Deleted.
1304         (+[WebView _allowCookies]): Deleted.
1305         * WebView/WebViewPrivate.h:
1306
1307 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1308
1309         Build fix, remove a call to -[NSWindow setOneShot:]
1310         https://bugs.webkit.org/show_bug.cgi?id=181809
1311
1312         Reviewed by Tim Horton.
1313
1314         * WebView/WebTextCompletionController.mm:
1315         (-[WebTextCompletionController _buildUI]):
1316
1317 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1318
1319         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1320
1321         * Carbon/HIWebView.mm:
1322         (overrideCGContext):
1323         (restoreCGContext):
1324
1325 2018-01-18  Dan Bernstein  <mitz@apple.com>
1326
1327         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1328         https://bugs.webkit.org/show_bug.cgi?id=181803
1329
1330         Reviewed by Tim Horton.
1331
1332         * Configurations/Base.xcconfig: Updated.
1333         * Configurations/DebugRelease.xcconfig: Ditto.
1334         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1335         * Configurations/Version.xcconfig: Updated.
1336         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1337           useful for defining settings that depend on the target macOS version.
1338
1339 2018-01-17  Youenn Fablet  <youenn@apple.com>
1340
1341         Put fetch Request.keepalive behind a runtime flag
1342         https://bugs.webkit.org/show_bug.cgi?id=181592
1343
1344         Reviewed by Chris Dumez.
1345
1346         * WebView/WebPreferenceKeysPrivate.h:
1347         * WebView/WebPreferences.mm:
1348         (+[WebPreferences initialize]):
1349         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1350         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1351         * WebView/WebPreferencesPrivate.h:
1352         * WebView/WebView.mm:
1353         (-[WebView _preferencesChanged:]):
1354
1355 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1356
1357         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1358         https://bugs.webkit.org/show_bug.cgi?id=181637
1359         <rdar://problem/36508471>
1360
1361         Reviewed by Tim Horton.
1362
1363         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1364
1365         * WebCoreSupport/WebEditorClient.h:
1366         * WebCoreSupport/WebEditorClient.mm:
1367         (WebEditorClient::replacementURLForResource):
1368
1369 2018-01-11  Keith Miller  <keith_miller@apple.com>
1370
1371         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1372         https://bugs.webkit.org/show_bug.cgi?id=181573
1373
1374         Reviewed by Simon Fraser.
1375
1376         * Configurations/FeatureDefines.xcconfig:
1377
1378 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1381         https://bugs.webkit.org/show_bug.cgi?id=181497
1382
1383         Reviewed by Tim Horton.
1384
1385         See other ChangeLogs for more detail.
1386
1387         * WebCoreSupport/WebDragClient.h:
1388
1389 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1390
1391         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1392         https://bugs.webkit.org/show_bug.cgi?id=181523
1393         <rdar://problem/28959131>
1394
1395         Reviewed by Alex Christensen.
1396
1397         * WebView/WebImmediateActionController.mm:
1398         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1399         Apply the change made in r216652 to WebKit1's immediate action controller.
1400
1401         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1402         the startContainer of the range is in an anonymous node.
1403
1404 2018-01-11  Youenn Fablet  <youenn@apple.com>
1405
1406         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1407         https://bugs.webkit.org/show_bug.cgi?id=181480
1408
1409         Reviewed by Eric Carlson.
1410
1411         * WebView/WebPreferences.mm:
1412         (+[WebPreferences initialize]):
1413
1414 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1415
1416         Fix check-webkit-style issues with WebNSDataExtras.mm
1417         <https://webkit.org/b/181369>
1418
1419         Reviewed by Alex Christensen.
1420
1421         * Misc/WebNSDataExtras.mm:
1422         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1423         (-[NSData _webkit_guessedMIMETypeForXML]):
1424         (-[NSData _webkit_guessedMIMEType]):
1425         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1426         (_findEOL):
1427         (-[NSData _webkit_parseRFC822HeaderFields]):
1428         (-[NSData _web_locationAfterFirstBlankLine]):
1429         - Fix all the check-webkit-style warnings.
1430
1431 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1432
1433         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1434         <https://webkit.org/b/181256>
1435         <rdar://problem/36281730>
1436
1437         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1438         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1439         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1440           to avoid warnings from casting CFStringRef to NPNSString*.
1441           Note that CFMutableStringRef is the same as CFStringRef
1442           without the const modifier, hence its use in the const_cast<>
1443           above.
1444
1445 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1446
1447         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1448         <https://webkit.org/b/181256>
1449         <rdar://problem/36281730>
1450
1451         * Carbon/HIWebView.mm:
1452         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1453         checked_cf_cast<CFRunLoopRef>() to fix warning.
1454
1455 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1456
1457         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1458         <https://webkit.org/b/181256>
1459         <rdar://problem/36281730>
1460
1461         Reviewed by Darin Adler.
1462
1463         * Carbon/CarbonUtils.m:
1464         (PoolCleaner):
1465         - Use #pragmas to ignore -Wcast-qual warnings when using a
1466           C-style cast from CFTypeRef to CFRunloopRef.
1467         * Carbon/CarbonWindowFrame.m:
1468         (-[CarbonWindowFrame title]):
1469         - Use #pragmas to ignore -Wcast-qual warnings when using a
1470           C-style cast from CFStringRef to NSString *.
1471         * Carbon/HIViewAdapter.m:
1472         (+[HIViewAdapter getHIViewForNSView:]):
1473         - Use #pragmas to ignore -Wcast-qual warnings when using a
1474           C-style cast from CFTypeRef to HIViewRef.
1475         * Configurations/Base.xcconfig:
1476         (WARNING_CFLAGS): Add -Wcast-qual.
1477         * Misc/WebElementDictionary.mm:
1478         (-[WebElementDictionary objectForKey:]):
1479         - Use static_cast<SEL>(const_cast<void*>()) to fix
1480           warning.
1481         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1482         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1483         (-[NSData _webkit_guessedMIMETypeForXML]):
1484         (-[NSData _webkit_guessedMIMEType]):
1485         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1486         (_findEOL):
1487         (-[NSData _webkit_parseRFC822HeaderFields]):
1488         (-[NSData _web_startsWithBlankLine]):
1489         (-[NSData _web_locationAfterFirstBlankLine]):
1490         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1491           type to Objective-C++.  This fixes the warnings about
1492           discarding the `const` modifier when casing from CFStringRef
1493           to NSString * because in older clang versions, -Wcast-qual was
1494           completely broken when compiling C++ and Objective-C++ source
1495           files.  In newer clang versions, discarding the `const`
1496           modifier for toll-free bridged types is ignored when compiling
1497           Objective-C++ source.
1498         - Update copyright and license header.
1499         - Use reinterpret_cast<> and static_cast<> to fix warnings
1500           unrelated to (NSString *) C-style casts.
1501         - Replace use of MIN() macro with std::min<> template functions.
1502         - Fix location of `*` for local variables modified above.
1503         * Plugins/Hosted/NetscapePluginHostManager.mm:
1504         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1505         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1506         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1507         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1508           warnings.
1509         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1510         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1511         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1512           to fix warning.
1513         * Plugins/Hosted/ProxyInstance.mm:
1514         (WebKit::ProxyInstance::invoke):
1515         - Use static_cast<char*>(const_cast<void*>()) to fix
1516           warning when using -[NSData bytes].
1517         (WebKit::ProxyInstance::fieldValue const):
1518         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1519           to fix warning when using CFDataGetBytePtr().
1520         * Plugins/Hosted/WebTextInputWindowController.m:
1521         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1522         - Use #pragma to ignore -Wcast-qual warning since there
1523           is not a good way to avoid this warning in Objective-C.
1524         * Plugins/WebNetscapePluginStream.mm:
1525         (WebNetscapePluginStream::deliverData):
1526         - Use const_cast<void*>() to fix warning when using
1527           -[NSData bytes].
1528         * Plugins/WebNetscapePluginView.mm:
1529         (-[WebNetscapePluginView _createPlugin]):
1530         - Change C-style cast to const_cast<char*>() to fix
1531           warning.
1532         * WebCoreSupport/WebChromeClient.mm:
1533         (WebChromeClient::wrapCryptoKey const):
1534         (WebChromeClient::unwrapCryptoKey const):
1535         - Change C-style cast to
1536           static_cast<uint8_t*>(const_cast<void*>() to fix
1537           warning.
1538         * WebView/WebPDFView.mm:
1539         (_applicationInfoForMIMEType):
1540         - Change local variable type from 'NSURL *' to
1541           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1542           when calling -[NSURL path].
1543
1544 2018-01-05  Dan Bernstein  <mitz@apple.com>
1545
1546         Fixed the build following AppKit API deprecations in a recent SDKs
1547
1548         * WebView/WebFullScreenController.mm:
1549         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1550         (-[WebFullScreenController exitFullScreen]): Ditto.
1551         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1552         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1553         * WebView/WebHTMLView.mm:
1554         (-[WebHTMLView drawRect:]): Ditto.
1555         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1556         (-[WebHTMLView knowsPageRange:]): Ditto.
1557         * WebView/WebView.mm:
1558         (LayerFlushController::flushLayers): Ditto.
1559
1560 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1561
1562         [Attachment Support] Create attachment elements when dropping files on iOS
1563         https://bugs.webkit.org/show_bug.cgi?id=181192
1564         <rdar://problem/36280945>
1565
1566         Reviewed by Tim Horton.
1567
1568         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1569
1570         * WebCoreSupport/WebPlatformStrategies.h:
1571         * WebCoreSupport/WebPlatformStrategies.mm:
1572         (WebPlatformStrategies::informationForItemAtIndex):
1573         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1574
1575 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1576
1577         [Attachment Support] Add plumbing for starting a drag with promised blob data
1578         https://bugs.webkit.org/show_bug.cgi?id=181201
1579
1580         Reviewed by Tim Horton.
1581
1582         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1583
1584         * WebCoreSupport/WebDragClient.h:
1585
1586 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1587
1588         Add a WebAuthentication runtime feature flag
1589         https://bugs.webkit.org/show_bug.cgi?id=181220
1590         <rdar://problem/36055305>
1591
1592         Reviewed by Brent Fulgham.
1593
1594         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1595
1596         * WebView/WebPreferenceKeysPrivate.h:
1597         * WebView/WebPreferences.mm:
1598         (+[WebPreferences initialize]):
1599         (-[WebPreferences webAuthenticationEnabled]):
1600         (-[WebPreferences setWebAuthenticationEnabled:]):
1601         (-[WebPreferences credentialManagementEnabled]): Deleted.
1602         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1603         * WebView/WebPreferencesPrivate.h:
1604         * WebView/WebView.mm:
1605         (-[WebView _preferencesChanged:]):
1606
1607 2017-12-22  Jeff Miller  <jeffm@apple.com>
1608
1609         Update user-visible copyright strings to include 2018
1610         https://bugs.webkit.org/show_bug.cgi?id=181141
1611
1612         Reviewed by Dan Bernstein.
1613
1614         * Info.plist:
1615
1616 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1617
1618         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1619         https://bugs.webkit.org/show_bug.cgi?id=181188
1620
1621         Reviewed by Dan Bernstein.
1622
1623         See WebCore/ChangeLog for more detail.
1624
1625         * WebCoreSupport/WebDragClient.h:
1626         * WebCoreSupport/WebDragClient.mm:
1627         (WebDragClient::declareAndWriteAttachment): Deleted.
1628         * WebView/WebHTMLView.mm:
1629         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1630
1631 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1632
1633         Unreviewed, continue to fix build failures due to AppKit API deprecation
1634
1635         Wraps more code in -Wdeprecated-declarations.
1636
1637         * Carbon/HIWebView.mm:
1638         (overrideCGContext):
1639
1640 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1641
1642         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1643
1644         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1645
1646         * Carbon/CarbonWindowAdapter.mm:
1647         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1648         * Plugins/WebNetscapePluginView.mm:
1649         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1650         (-[WebNetscapePluginView sendDrawRectEvent:]):
1651         (-[WebNetscapePluginView drawRect:]):
1652
1653 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1654
1655         Fix build failures due to using deprecated AppKit symbols
1656         https://bugs.webkit.org/show_bug.cgi?id=181110
1657         <rdar://problem/36162865>
1658
1659         Reviewed by Dan Bernstein and Tim Horton.
1660
1661         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1662
1663         * Misc/WebKitNSStringExtras.mm:
1664         (-[NSString _web_drawAtPoint:font:textColor:]):
1665         * Misc/WebNSPasteboardExtras.h:
1666         * Misc/WebNSPasteboardExtras.mm:
1667         (+[NSPasteboard _web_writableTypesForURL]):
1668         (_createWritableTypesForImageWithoutArchive):
1669         (_createWritableTypesForImageWithArchive):
1670         (+[NSPasteboard _web_dragTypesForURL]):
1671         (-[NSPasteboard _web_bestURL]):
1672         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1673         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1674         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1675         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1676         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1677         * Panels/WebAuthenticationPanel.m:
1678         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1679         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1680         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1681         (-[WebHostedNetscapePluginView drawRect:]):
1682         * WebInspector/WebNodeHighlightView.mm:
1683         (-[WebNodeHighlightView drawRect:]):
1684         * WebView/WebFrame.mm:
1685         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1686         (-[WebFrame _drawRect:contentsOnly:]):
1687         * WebView/WebHTMLView.mm:
1688         (kit):
1689         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1690         (-[WebHTMLView _plainTextFromPasteboard:]):
1691         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1692         (+[WebHTMLView _insertablePasteboardTypes]):
1693         (+[WebHTMLView _selectionPasteboardTypes]):
1694         (-[WebHTMLView pasteboard:provideDataForType:]):
1695         (-[WebHTMLView _writeSelectionToPasteboard:]):
1696         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1697         (-[WebHTMLView validRequestorForSendType:returnType:]):
1698         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1699         (createMenuItem):
1700         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1701         (-[WebHTMLView _colorAsString:]):
1702         (-[WebHTMLView copyFont:]):
1703         * WebView/WebPDFView.mm:
1704         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1705         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1706         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1707         (-[WebPDFView pasteboardTypesForSelection]):
1708         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1709         * WebView/WebView.h:
1710         * WebView/WebView.mm:
1711         (-[WebView performDragOperation:]):
1712         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1713         (-[WebView _searchWithGoogleFromMenu:]):
1714
1715 2017-12-21  Youenn Fablet  <youenn@apple.com>
1716
1717         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1718         https://bugs.webkit.org/show_bug.cgi?id=181000
1719
1720         Reviewed by Chris Dumez.
1721
1722         * Misc/WebCache.mm:
1723         (+[WebCache addImageToCache:forURL:forFrame:]):
1724
1725 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1726
1727         Update FULLSCREEN_API feature defines.
1728         https://bugs.webkit.org/show_bug.cgi?id=181015
1729
1730         Reviewed by Tim Horton.
1731
1732         Change enabled iphone sdk for FULLSCREEN_API.
1733
1734         * Configurations/FeatureDefines.xcconfig:
1735
1736 2017-12-21  Jer Noble  <jer.noble@apple.com>
1737
1738         Add initial DOM support for Media Capabilities
1739         https://bugs.webkit.org/show_bug.cgi?id=181064
1740
1741         Reviewed by Eric Carlson.
1742
1743         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1744
1745         * WebView/WebPreferenceKeysPrivate.h:
1746         * WebView/WebPreferences.mm:
1747         (+[WebPreferences initialize]):
1748         (-[WebPreferences mediaCapabilitiesEnabled]):
1749         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1750         * WebView/WebPreferencesPrivate.h:
1751         * WebView/WebView.mm:
1752         (-[WebView _preferencesChanged:]):
1753
1754 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1755
1756         Enable picture-in-picture from inline element on suspend.
1757         https://bugs.webkit.org/show_bug.cgi?id=180942
1758         rdar://problem/34745234
1759
1760         Reviewed by Jer Noble.
1761
1762         Update signature of enterVideoFullscreenForVideoElement().
1763
1764         * WebCoreSupport/WebChromeClient.h:
1765         * WebCoreSupport/WebChromeClient.mm:
1766         (WebChromeClient::enterVideoFullscreenForVideoElement):
1767
1768 2017-12-20  Daniel Bates  <dabates@apple.com>
1769
1770         Remove Alternative Presentation Button
1771         https://bugs.webkit.org/show_bug.cgi?id=180500
1772         <rdar://problem/35891047>
1773
1774         Reviewed by Simon Fraser.
1775
1776         We no longer need the alternative presentation button.
1777
1778         * Configurations/FeatureDefines.xcconfig:
1779
1780 2017-12-19  Jer Noble  <jer.noble@apple.com>
1781
1782         Playing media elements which call "pause(); play()" will have the play promise rejected.
1783         https://bugs.webkit.org/show_bug.cgi?id=180781
1784         <rdar://problem/33191377>
1785
1786         Reviewed by Eric Carlson.
1787
1788         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1789
1790         * WebView/WebView.mm:
1791         (shouldRequireUserGestureToLoadVideo):
1792
1793 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1794
1795         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1796         https://bugs.webkit.org/show_bug.cgi?id=180977
1797
1798         Reviewed by Tim Horton.
1799
1800         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1801         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1802         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1803
1804         * WebCoreSupport/WebEditorClient.mm:
1805         (attributesForAttributedStringConversion):
1806         * WebView/WebHTMLView.mm:
1807         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1808
1809 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1810
1811         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1812
1813         Attempt to fix the following warnings:
1814
1815             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1816
1817         For the following instance variables:
1818
1819             _borderView
1820             _contentView
1821             _frame
1822             _wFlags
1823
1824         * Carbon/CarbonWindowAdapter.mm:
1825         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1826         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1827         (-[CarbonWindowAdapter _termWindowIfOwner]):
1828         (-[CarbonWindowAdapter _windowMovedToRect:]):
1829         (-[CarbonWindowAdapter setContentView:]):
1830         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1831         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1832
1833 2017-12-16  Dan Bernstein  <mitz@apple.com>
1834
1835         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1836         https://bugs.webkit.org/show_bug.cgi?id=180613
1837         <rdar://problem/35946124>
1838
1839         Reviewed by Geoff Garen.
1840
1841         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1842           clients.
1843         * WebView/WebDynamicScrollBarsView.h: Ditto.
1844         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1845
1846 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1847
1848         Enable -Wstrict-prototypes for WebKit
1849         <https://webkit.org/b/180757>
1850         <rdar://problem/36024132>
1851
1852         Rubber-stamped by Joseph Pecoraro.
1853
1854         * Configurations/Base.xcconfig:
1855         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1856
1857 2017-12-14  John Wilander  <wilander@apple.com>
1858
1859         Storage Access API: Implement frame-specific access in the document.cookie layer
1860         https://bugs.webkit.org/show_bug.cgi?id=180682
1861         <rdar://problem/35982257>
1862
1863         Reviewed by Alex Christensen.
1864
1865         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1866         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1867         CookiesStrategy::getRawCookies() now take optional parameters for
1868         frameID and pageID to allow frame-specific scoping of cookies.
1869
1870         This change makes the return values of FrameLoaderClient::frameID()
1871         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1872         WebCore can call those getters and get the right return values in
1873         WebKit and std:nullopt in WebKitLegacy.
1874
1875         * WebCoreSupport/WebFrameLoaderClient.h:
1876         * WebCoreSupport/WebFrameLoaderClient.mm:
1877         (WebFrameLoaderClient::pageID const):
1878         (WebFrameLoaderClient::frameID const):
1879         * WebCoreSupport/WebPlatformStrategies.h:
1880         * WebCoreSupport/WebPlatformStrategies.mm:
1881         (WebPlatformStrategies::cookiesForDOM):
1882         (WebPlatformStrategies::setCookiesFromDOM):
1883         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1884         (WebPlatformStrategies::getRawCookies):
1885
1886 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1887
1888         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1889         https://bugs.webkit.org/show_bug.cgi?id=180689
1890
1891         Reviewed by Tim Horton.
1892
1893         Use sRGBColorSpaceRef() from WebCore.
1894
1895         * WebView/WebHTMLView.mm:
1896         (imageFromRect):
1897
1898 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1899
1900         Stop using deprecated target conditional for simulator builds
1901         https://bugs.webkit.org/show_bug.cgi?id=180662
1902         <rdar://problem/35136156>
1903
1904         Reviewed by Simon Fraser.
1905
1906         * postprocess-headers.sh:
1907
1908 2017-12-11  David Quesada  <david_quesada@apple.com>
1909
1910         Turn on ENABLE_APPLICATION_MANIFEST
1911         https://bugs.webkit.org/show_bug.cgi?id=180562
1912         rdar://problem/35924737
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         * Configurations/FeatureDefines.xcconfig:
1917
1918 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1919
1920         Remove pthread_once in favor of dispatch_once
1921         https://bugs.webkit.org/show_bug.cgi?id=180591
1922
1923         Reviewed by Saam Barati.
1924
1925         * Misc/WebKitErrors.m:
1926         (+[NSError _registerWebKitErrors]):
1927         (registerErrors): Deleted.
1928         * Storage/WebStorageManager.mm:
1929         (+[WebStorageManager _storageDirectoryPath]):
1930         (initializeLocalStoragePath): Deleted.
1931
1932 2017-12-07  Darin Adler  <darin@apple.com>
1933
1934         Remove some unused code from WebKitLegacy
1935         https://bugs.webkit.org/show_bug.cgi?id=180567
1936
1937         Reviewed by Anders Carlsson.
1938
1939         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1940         macOS (back a few versions) and iOS and removed unused
1941         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1942         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1943         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1944         _webkit_stringByCollapsingNonPrintingCharacters,
1945         _webkit_stringByCollapsingWhitespaceCharacters,
1946         _web_stringWithData:textEncodingName:, and
1947         _webkit_localStorageDirectoryWithBundleIdentifier:.
1948
1949         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1950         this source file.
1951         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1952         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1953         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1954         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1955         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1956         handle font smoothing options.
1957         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1958         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1959         from header and made it a little clearer.
1960         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1961         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1962         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1963         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1964         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1965         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1966         implementation a bit and used whole words instead of abbreviations.
1967         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1968
1969         * Misc/WebNSFileManagerExtras.mm:
1970         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1971         filenameByFixingIllegalCharacters function from WebCore directly instead of
1972         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1973
1974         * Plugins/WebBaseNetscapePluginView.mm:
1975         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1976         string replacements instead of _web_stringByStrippingReturnCharacters
1977         and to use NSString methods instead of CFString functions.
1978
1979 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1980
1981         Ignore deprecation warnings.
1982
1983         * WebView/WebHTMLView.mm:
1984         (-[NSWindow _web_borderView]):
1985         (-[WebHTMLView _setAsideSubviews]):
1986         * WebView/WebView.mm:
1987         (-[WebView encodeWithCoder:]):
1988
1989 2017-12-02  Darin Adler  <darin@apple.com>
1990
1991         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1992         https://bugs.webkit.org/show_bug.cgi?id=180009
1993
1994         Reviewed by Alex Christensen.
1995
1996         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1997
1998         * Plugins/WebBaseNetscapePluginView.mm:
1999         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
2000         of strcasecmp.
2001
2002         * WebView/WebPreferences.mm:
2003         (contains): Ditto. Also made this a template so it's easier to call on an array.
2004         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
2005
2006 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
2007
2008         Limit user agent versioning to an upper bound
2009         https://bugs.webkit.org/show_bug.cgi?id=180365
2010         <rdar://problem/34550617>
2011
2012         Reviewed by Joseph Pecoraro.
2013
2014         * WebView/WebView.mm:
2015         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
2016         creating the User Agent string.
2017         (webKitBundleVersionString): Deleted.
2018
2019 2017-12-05  Andy Estes  <aestes@apple.com>
2020
2021         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
2022         https://bugs.webkit.org/show_bug.cgi?id=180457
2023         <rdar://problem/35143007>
2024
2025         Reviewed by Tim Horton.
2026
2027         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2028         check for this macro during post-processing.
2029
2030         * postprocess-headers.sh:
2031
2032 2017-12-04  David Quesada  <david_quesada@apple.com>
2033
2034         Add a class for parsing application manifests
2035         https://bugs.webkit.org/show_bug.cgi?id=177973
2036         rdar://problem/34747949
2037
2038         Reviewed by Geoffrey Garen.
2039
2040         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2041
2042 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2043
2044         Make LegacyCustomProtocolManager optional for network process
2045         https://bugs.webkit.org/show_bug.cgi?id=176230
2046
2047         Reviewed by Alex Christensen.
2048
2049         * Configurations/FeatureDefines.xcconfig:
2050
2051 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2052
2053         Fix some NSOperationQueue leaks
2054         https://bugs.webkit.org/show_bug.cgi?id=180221
2055
2056         Reviewed by Wenson Hsieh.
2057
2058         * WebView/WebView.mm:
2059         (-[WebView performDragOperation:]):
2060
2061 2017-11-30  Darin Adler  <darin@apple.com>
2062
2063         [Mac] remove unneeded RetainPtr use introduced in r225142
2064         https://bugs.webkit.org/show_bug.cgi?id=180202
2065
2066         Reviewed by Tim Horton.
2067
2068         * WebView/WebImmediateActionController.mm:
2069         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2070         RetainPtr.
2071
2072 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2073
2074         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2075         https://bugs.webkit.org/show_bug.cgi?id=175595
2076
2077         Reviewed by Darin Adler.
2078
2079         * WebView/WebPreferences.mm:
2080
2081 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2082
2083         One too many zeroes in macOS version number in FeatureDefines
2084         https://bugs.webkit.org/show_bug.cgi?id=180011
2085
2086         Reviewed by Dan Bernstein.
2087
2088         * Configurations/FeatureDefines.xcconfig:
2089
2090 2017-11-23  Darin Adler  <darin@apple.com>
2091
2092         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2093         https://bugs.webkit.org/show_bug.cgi?id=179981
2094
2095         Reviewed by Sam Weinig.
2096
2097         * WebView/WebImmediateActionController.mm:
2098         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2099         * WebView/WebView.mm:
2100         (coreOptions): Use |= instead of | to build up FindOptions.
2101
2102 2017-11-23  Sam Weinig  <sam@webkit.org>
2103
2104         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2105         https://bugs.webkit.org/show_bug.cgi?id=179954
2106
2107         Reviewed by Darin Adler.
2108
2109         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2110         with direct calls to the corresponding UserGestureIndicator functions.
2111
2112         * Plugins/WebPluginController.mm:
2113         (-[WebPluginController processingUserGesture]):
2114         * WebView/WebView.mm:
2115         (-[WebView _isProcessingUserGesture]):
2116
2117 2017-11-23  Darin Adler  <darin@apple.com>
2118
2119         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2120         https://bugs.webkit.org/show_bug.cgi?id=179907
2121
2122         Reviewed by Sam Weinig.
2123
2124         * History/BinaryPropertyList.cpp:
2125         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2126         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2127         * WebView/WebHTMLRepresentation.mm:
2128         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2129         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2130
2131 2017-11-22  Ali Juma  <ajuma@chromium.org>
2132
2133         Implement VisualViewport API attributes
2134         https://bugs.webkit.org/show_bug.cgi?id=179385
2135
2136         Reviewed by Frédéric Wang.
2137
2138         Add a VisualViewportAPI preference.
2139
2140         * WebView/WebPreferenceKeysPrivate.h:
2141         * WebView/WebPreferences.mm:
2142         (+[WebPreferences initialize]):
2143         (-[WebPreferences visualViewportAPIEnabled]):
2144         (-[WebPreferences setVisualViewportAPIEnabled:]):
2145         * WebView/WebPreferencesPrivate.h:
2146         * WebView/WebView.mm:
2147         (-[WebView _preferencesChanged:]):
2148
2149 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2150
2151         WebCoreObjCExtras.h is being included in too many places
2152         https://bugs.webkit.org/show_bug.cgi?id=179931
2153
2154         Reviewed by Darin Adler.
2155
2156         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2157         * Plugins/WebBaseNetscapePluginView.mm:
2158         * Plugins/WebBasePluginPackage.mm:
2159         * Plugins/WebNetscapePluginStream.mm:
2160         * Plugins/WebNetscapePluginView.mm:
2161         * WebView/WebTextIterator.mm:
2162         * WebView/WebViewData.mm:
2163
2164 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2165
2166         Unreviewed, rolling out r225093.
2167         https://bugs.webkit.org/show_bug.cgi?id=179938
2168
2169         Compilation failed on WinCairo 64-bit Release (Requested by
2170         fredw on #webkit).
2171
2172         Reverted changeset:
2173
2174         "Implement VisualViewport API attributes"
2175         https://bugs.webkit.org/show_bug.cgi?id=179385
2176         https://trac.webkit.org/changeset/225093
2177
2178 2017-11-21  Ali Juma  <ajuma@chromium.org>
2179
2180         Implement VisualViewport API attributes
2181         https://bugs.webkit.org/show_bug.cgi?id=179385
2182
2183         Reviewed by Frédéric Wang.
2184
2185         Add a VisualViewportAPI preference.
2186
2187         * WebView/WebPreferenceKeysPrivate.h:
2188         * WebView/WebPreferences.mm:
2189         (+[WebPreferences initialize]):
2190         (-[WebPreferences visualViewportAPIEnabled]):
2191         (-[WebPreferences setVisualViewportAPIEnabled:]):
2192         * WebView/WebPreferencesPrivate.h:
2193         * WebView/WebView.mm:
2194         (-[WebView _preferencesChanged:]):
2195
2196 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2197
2198         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2199         https://bugs.webkit.org/show_bug.cgi?id=179504
2200
2201         Reviewed by Darin Adler.
2202
2203         * Misc/WebKitNSStringExtras.mm:
2204         * Plugins/Hosted/NetscapePluginHostManager.mm:
2205         * Plugins/WebBasePluginPackage.mm:
2206
2207 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2208
2209         Remove unused TOUCH_ICON_LOADING feature flag
2210         https://bugs.webkit.org/show_bug.cgi?id=179873
2211
2212         Reviewed by Simon Fraser.
2213
2214         * Configurations/FeatureDefines.xcconfig:
2215
2216 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2217
2218         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2219         https://bugs.webkit.org/show_bug.cgi?id=179872
2220
2221         Reviewed by Darin Adler.
2222
2223         * Configurations/FeatureDefines.xcconfig:
2224
2225 2017-11-16  Daniel Bates  <dabates@apple.com>
2226
2227         Add feature define for alternative presentation button element
2228         https://bugs.webkit.org/show_bug.cgi?id=179692
2229         Part of <rdar://problem/34917108>
2230
2231         Reviewed by Andy Estes.
2232
2233         Only enabled on Cocoa platforms by default.
2234
2235         * Configurations/FeatureDefines.xcconfig:
2236
2237 2017-11-14  Nan Wang  <n_wang@apple.com>
2238
2239         AX: AOM: Implement AccessibleNode class and support label and role attributes
2240         https://bugs.webkit.org/show_bug.cgi?id=179494
2241
2242         Reviewed by Ryosuke Niwa.
2243
2244         * WebView/WebPreferenceKeysPrivate.h:
2245         * WebView/WebPreferences.mm:
2246         (+[WebPreferences initialize]):
2247         (-[WebPreferences accessibilityObjectModelEnabled]):
2248         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2249         * WebView/WebPreferencesPrivate.h:
2250         * WebView/WebView.mm:
2251         (-[WebView _preferencesChanged:]):
2252
2253 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2254
2255         Remove Cocoa CFURLConnection loading code
2256         https://bugs.webkit.org/show_bug.cgi?id=179688
2257
2258         Reviewed by Antti Koivisto.
2259
2260         * Misc/WebDownload.mm:
2261         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2262         * Misc/WebDownloadInternal.h:
2263         * Plugins/WebBaseNetscapePluginView.mm:
2264         * WebCoreSupport/WebFrameLoaderClient.mm:
2265         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2266         * WebView/WebView.mm:
2267         (-[WebView scheduleInRunLoop:forMode:]):
2268         (-[WebView unscheduleFromRunLoop:forMode:]):
2269
2270 2017-11-14  Daniel Bates  <dabates@apple.com>
2271
2272         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2273         for feature defines
2274
2275         Following r195498 and r201917 the Visual Studio property files for feature defines have
2276         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2277         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2278         files.
2279
2280         * Configurations/FeatureDefines.xcconfig:
2281
2282 2017-11-14  Jer Noble  <jer.noble@apple.com>
2283
2284         Enable Modern EME tests in DumpRenderTree
2285         https://bugs.webkit.org/show_bug.cgi?id=179544
2286
2287         Reviewed by Alex Christensen.
2288
2289         Add a WebPreferences property to enable the (modern) EME API.
2290
2291         * WebView/WebPreferenceKeysPrivate.h:
2292         * WebView/WebPreferences.mm:
2293         (+[WebPreferences initialize]):
2294         (-[WebPreferences encryptedMediaAPIEnabled]):
2295         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2296         * WebView/WebPreferencesPrivate.h:
2297         * WebView/WebView.mm:
2298         (-[WebView _preferencesChanged:]):
2299
2300 2017-11-14  Antti Koivisto  <antti@apple.com>
2301
2302         Enable display:contents by default
2303         https://bugs.webkit.org/show_bug.cgi?id=179655
2304
2305         Reviewed by Sam Weinig.
2306
2307         * WebView/WebPreferences.mm:
2308         (+[WebPreferences initialize]):
2309
2310 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2311
2312         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2313         https://bugs.webkit.org/show_bug.cgi?id=178751
2314
2315         Reviewed by Brady Eidson.
2316
2317         * WebCoreSupport/WebFrameNetworkingContext.mm:
2318         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2319
2320 2017-11-08  Keith Miller  <keith_miller@apple.com>
2321
2322         Async iteration should only fetch the next method once and add feature flag
2323         https://bugs.webkit.org/show_bug.cgi?id=179451
2324
2325         Reviewed by Geoffrey Garen.
2326
2327         Add feature flag for Async iteration.
2328
2329         * Configurations/FeatureDefines.xcconfig:
2330
2331 2017-11-13  Mark Lam  <mark.lam@apple.com>
2332
2333         Add more overflow check book-keeping for MarkedArgumentBuffer.
2334         https://bugs.webkit.org/show_bug.cgi?id=179634
2335         <rdar://problem/35492517>
2336
2337         Reviewed by Saam Barati.
2338
2339         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2340         (WebKit::NetscapePluginInstanceProxy::invoke):
2341         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2342         (WebKit::NetscapePluginInstanceProxy::construct):
2343
2344 2017-11-12  Darin Adler  <darin@apple.com>
2345
2346         More is<> and downcast<>, less static_cast<>
2347         https://bugs.webkit.org/show_bug.cgi?id=179600
2348
2349         Reviewed by Chris Dumez.
2350
2351         * DOM/DOM.mm:
2352         (kit): Use is/downcast.
2353         * WebCoreSupport/WebEditorClient.mm:
2354         (WebEditorClient::handleKeyboardEvent): Ditto.
2355         (WebEditorClient::handleInputMethodKeydown): Ditto.
2356         * WebView/WebHTMLView.mm:
2357         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2358
2359 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2360
2361         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2362         https://bugs.webkit.org/show_bug.cgi?id=179397
2363
2364         Reviewed by Wenson Hsieh.
2365
2366         * DOM/DOMHTMLInputElement.mm:
2367         (-[DOMHTMLInputElement insertTextSuggestion:]):
2368
2369 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2370
2371         HTMLMediaElement should not use element fullscreen on iOS
2372         https://bugs.webkit.org/show_bug.cgi?id=179418
2373         rdar://problem/35409277
2374
2375         Reviewed by Eric Carlson.
2376
2377         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2378
2379         * Configurations/FeatureDefines.xcconfig:
2380
2381 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2382
2383         Make ResourceLoader::willSendRequestInternal asynchronous
2384         https://bugs.webkit.org/show_bug.cgi?id=179251
2385
2386         Reviewed by Andy Estes.
2387
2388         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2389         (WebKit::HostedNetscapePluginStream::start):
2390         * Plugins/WebNetscapePluginStream.mm:
2391         (WebNetscapePluginStream::start):
2392
2393 2017-11-01  Darin Adler  <darin@apple.com>
2394
2395         Simplify event dispatch code and make it a bit more consistent
2396         https://bugs.webkit.org/show_bug.cgi?id=178991
2397
2398         Reviewed by Chris Dumez.
2399
2400         * DOM/DOMEvent.mm:
2401         (-[DOMEvent srcElement]): Call target instead of srcElement.
2402
2403 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2404
2405         [Touch Bar Web API] Add support for menuitem tag
2406         https://bugs.webkit.org/show_bug.cgi?id=179020
2407
2408         Reviewed by Ryosuke Niwa.
2409
2410         Adds in properties and methods that allow the menuitem runtime feature
2411         to be enabled or disabled.
2412
2413         * WebView/WebPreferenceKeysPrivate.h:
2414         * WebView/WebPreferences.mm:
2415         (-[WebPreferences menuItemElementEnabled]):
2416         (-[WebPreferences setMenuItemElementEnabled:]):
2417         * WebView/WebPreferencesPrivate.h:
2418         * WebView/WebView.mm:
2419         (-[WebView _preferencesChanged:]):
2420
2421 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2422
2423         Use CompletionHandlers for redirects
2424         https://bugs.webkit.org/show_bug.cgi?id=179163
2425
2426         Reviewed by Tim Horton.
2427
2428         * Plugins/Hosted/HostedNetscapePluginStream.h:
2429         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2430         (WebKit::HostedNetscapePluginStream::willSendRequest):
2431         * Plugins/WebNetscapePluginStream.h:
2432         * Plugins/WebNetscapePluginStream.mm:
2433         (WebNetscapePluginStream::willSendRequest):
2434
2435 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2436
2437         Add a FileSystem namespace to FileSystem.cpp
2438         https://bugs.webkit.org/show_bug.cgi?id=179063
2439
2440         Reviewed by Darin Adler.
2441
2442         * Misc/WebNSFileManagerExtras.mm:
2443         * Storage/WebDatabaseProvider.mm:
2444
2445 2017-11-02  Frederic Wang  <fwang@igalia.com>
2446
2447         Add references to bug 179167 in FIXME comments
2448         https://bugs.webkit.org/show_bug.cgi?id=179168
2449
2450         Reviewed by Daniel Bates.
2451
2452         * Configurations/FeatureDefines.xcconfig:
2453
2454 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2455
2456         Implement WKFullscreenWindowController for iOS.
2457         https://bugs.webkit.org/show_bug.cgi?id=178924
2458         rdar://problem/34697120
2459
2460         Reviewed by Simon Fraser.
2461
2462         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2463
2464         * Configurations/FeatureDefines.xcconfig:
2465         * WebView/WebView.mm:
2466         (-[WebView fullScreenPlaceholderView]):
2467
2468 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2469
2470         Clean up some drag and drop feature flags
2471         https://bugs.webkit.org/show_bug.cgi?id=179082
2472
2473         Reviewed by Simon Fraser.
2474
2475         * Configurations/FeatureDefines.xcconfig:
2476
2477 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2478
2479         Make it possible to test rubber-banding in overflow scroll
2480         https://bugs.webkit.org/show_bug.cgi?id=179078
2481
2482         Reviewed by Sam Weinig.
2483
2484         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2485         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2486
2487         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2488         functions, since most callers want clamped.
2489
2490         * DOM/DOMHTML.mm:
2491         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2492
2493 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2494
2495         Fix up some content filtering feature flags
2496         https://bugs.webkit.org/show_bug.cgi?id=179079
2497
2498         Reviewed by Simon Fraser.
2499
2500         * Configurations/FeatureDefines.xcconfig:
2501
2502 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2503
2504         [FrameView::layout cleanup] Move core layout logic to a separate class.
2505         https://bugs.webkit.org/show_bug.cgi?id=178771
2506         <rdar://problem/35166542>
2507
2508         Reviewed by Simon Fraser.
2509
2510         Move layout code out from FrameView to LayoutContext.
2511
2512         * WebView/WebClipView.mm:
2513         (-[WebClipView _immediateScrollToPoint:]):
2514         * WebView/WebFrame.mm:
2515         (-[WebFrame layoutCount]):
2516
2517 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2518
2519         Fix issues with WebView subframe painting
2520         https://bugs.webkit.org/show_bug.cgi?id=178842
2521         rdar://problem/34072253
2522
2523         Reviewed by Daniel Bates.
2524         
2525         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2526         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2527         High Sierra, so match the new signature.
2528
2529         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2530
2531         * WebView/WebHTMLView.mm:
2532         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2533         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2534
2535 2017-10-25  Youenn Fablet  <youenn@apple.com>
2536
2537         Enable ServiceWorker to fetch resources
2538         https://bugs.webkit.org/show_bug.cgi?id=178673
2539
2540         Reviewed by Brady Eidson.
2541
2542         * WebCoreSupport/WebFrameLoaderClient.mm:
2543         (WebFrameLoaderClient::pageID const):
2544         (WebFrameLoaderClient::frameID const):
2545         (WebFrameLoaderClient::sessionID const):
2546
2547         Added implementation to the new getters.
2548         They are noop in the context of WK1.
2549
2550 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2551
2552         Web Inspector: Enable WebKit logging configuration and display
2553         https://bugs.webkit.org/show_bug.cgi?id=177027
2554         <rdar://problem/33964767>
2555
2556         Reviewed by Joseph Pecoraro.
2557
2558         * WebCoreSupport/WebChromeClient.mm:
2559         (stringForMessageSource): Deal with Media and WebRTC message sources.
2560
2561 2017-10-20  Antoine Quint  <graouts@apple.com>
2562
2563         [Web Animations] Provide basic timeline and animation interfaces
2564         https://bugs.webkit.org/show_bug.cgi?id=178526
2565
2566         Reviewed by Dean Jackson.
2567
2568         Remove the WEB_ANIMATIONS compile-time flag.
2569
2570         * Configurations/FeatureDefines.xcconfig:
2571         * WebView/WebPreferences.mm:
2572         (+[WebPreferences initialize]):
2573         * WebView/WebView.mm:
2574         (-[WebView _preferencesChanged:]):
2575
2576 2017-10-19  Sam Weinig  <sam@webkit.org>
2577
2578         [Settings] Move global settings into their own file
2579         https://bugs.webkit.org/show_bug.cgi?id=178512
2580
2581         Reviewed by Darin Adler.
2582
2583         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2584
2585         * WebCoreSupport/WebChromeClient.mm:
2586         (WebChromeClient::supportsVideoFullscreen):
2587         * WebView/WebDynamicScrollBarsView.mm:
2588         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2589         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2590         * WebView/WebPreferences.mm:
2591         (+[WebPreferences initialize]):
2592         * WebView/WebView.mm:
2593         (-[WebView _commonInitializationWithFrameName:groupName:]):
2594         (-[WebView _preferencesChanged:]):
2595         (+[WebView _doNotStartObservingNetworkReachability]):
2596
2597 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2598
2599         Replace some stack raw pointers with RefPtrs within WebCore/html
2600         https://bugs.webkit.org/show_bug.cgi?id=178201
2601         <rdar://problem/34841692>
2602
2603         Reviewed by Ryosuke Niwa.
2604
2605         * DOM/DOM.mm:
2606         (kit):
2607         Change the type of node as toNode() is changed to return RefPtr.
2608
2609 2017-10-18  Chris Dumez  <cdumez@apple.com>
2610
2611         [Service Worker] Add stubs for Client / WindowClient / Clients
2612         https://bugs.webkit.org/show_bug.cgi?id=178469
2613
2614         Reviewed by Youenn Fablet.
2615
2616         Rename PageVisiblityState to VisibilityState.
2617
2618         * WebView/WebView.mm:
2619         (kit):
2620
2621 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2622
2623         Unreviewed, rolling out r223291.
2624
2625         See WebCore ChangeLog for more detail.
2626
2627         Reverted changeset:
2628
2629         "Remove Editor::simplifyMarkup"
2630         https://bugs.webkit.org/show_bug.cgi?id=178271
2631         https://trac.webkit.org/changeset/223291
2632
2633 2017-10-17  Keith Miller  <keith_miller@apple.com>
2634
2635         Change WebCore sources to work with unified source builds
2636         https://bugs.webkit.org/show_bug.cgi?id=178229
2637
2638         Rubber stamped by Tim Horton.
2639
2640         * Configurations/FeatureDefines.xcconfig:
2641
2642 2017-10-16  Sam Weinig  <sam@webkit.org>
2643
2644         [Settings] Remove all custom code from Settings.h/cpp
2645         https://bugs.webkit.org/show_bug.cgi?id=178330
2646
2647         Reviewed by Simon Fraser.
2648
2649         * WebView/WebPreferences.mm:
2650         (+[WebPreferences initialize]):
2651         
2652             Update for naming changes of FrameFlattening now that it is an enum class.
2653
2654 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2655
2656         Remove Editor::simplifyMarkup
2657         https://bugs.webkit.org/show_bug.cgi?id=178271
2658
2659         Reviewed by Wenson Hsieh.
2660
2661         * WebView/WebView.mm:
2662         (-[WebView _simplifyMarkup:endNode:]):
2663
2664 2017-10-12  Chris Dumez  <cdumez@apple.com>
2665
2666         [Mac] Add support for MouseEvent.buttons
2667         https://bugs.webkit.org/show_bug.cgi?id=178214
2668
2669         Reviewed by Ryosuke Niwa.
2670
2671         * WebView/WebPDFView.mm:
2672         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2673
2674 2017-10-11  Sam Weinig  <sam@webkit.org>
2675
2676         Remove out-parameter variants of copyToVector
2677         https://bugs.webkit.org/show_bug.cgi?id=178155
2678
2679         Reviewed by Tim Horton.
2680
2681         * Plugins/WebNetscapePluginView.mm:
2682         (-[WebNetscapePluginView destroyPlugin]):
2683         * WebView/WebHTMLRepresentation.mm:
2684         (newArrayWithStrings):
2685
2686             Replace out-parameter based copyToVector, with one that returns a Vector.
2687
2688 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2689
2690         Sanitize URL in pasteboard for other applications and cross origin content
2691         https://bugs.webkit.org/show_bug.cgi?id=178060
2692         <rdar://problem/34874518>
2693
2694         Reviewed by Wenson Hsieh.
2695
2696         * WebCoreSupport/WebPlatformStrategies.h:
2697         * WebCoreSupport/WebPlatformStrategies.mm:
2698         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2699
2700 2017-10-11  Chris Dumez  <cdumez@apple.com>
2701
2702         Modernize Geolocation code
2703         https://bugs.webkit.org/show_bug.cgi?id=178148
2704
2705         Reviewed by Ryosuke Niwa.
2706
2707         * WebCoreSupport/WebGeolocationClient.h:
2708         * WebCoreSupport/WebGeolocationClient.mm:
2709         (WebGeolocationClient::lastPosition):
2710         * WebView/WebGeolocationPosition.mm:
2711         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2712         (core):
2713         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2714         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2715         * WebView/WebGeolocationPositionInternal.h:
2716
2717 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2718
2719         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2720         https://bugs.webkit.org/show_bug.cgi?id=178154
2721
2722         Reviewed by Wenson Hsieh.
2723
2724         Enable custom pasteboard data by default.
2725
2726         * WebView/WebPreferenceKeysPrivate.h:
2727         * WebView/WebPreferences.mm:
2728         (+[WebPreferences initialize]):
2729         (-[WebPreferences customPasteboardDataEnabled]): Added.
2730         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2731         * WebView/WebPreferencesPrivate.h:
2732         * WebView/WebView.mm:
2733         (-[WebView _preferencesChanged:]):
2734
2735 2017-10-10  Sam Weinig  <sam@webkit.org>
2736
2737         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2738         https://bugs.webkit.org/show_bug.cgi?id=178102
2739
2740         Reviewed by Tim Horton.
2741
2742         * History/WebHistory.mm:
2743         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2744         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2745         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2746         * WebCoreSupport/WebUserMediaClient.mm:
2747         (WebUserMediaClient::pageDestroyed):
2748
2749 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2750
2751         Make the names of the options consistent
2752         https://bugs.webkit.org/show_bug.cgi?id=177933
2753
2754         Reviewed by Saam Barati.
2755
2756         * WebView/WebFrame.h:
2757         * WebView/WebHTMLView.mm:
2758         (-[WebHTMLView setMarkedText:selectedRange:]):
2759         * WebView/WebView.h:
2760
2761 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2762
2763         [iOS] Tweak support for classifying form controls (followup to r222487)
2764         https://bugs.webkit.org/show_bug.cgi?id=177917
2765         <rdar://problem/34820122>
2766
2767         Reviewed by Dean Jackson.
2768
2769         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2770
2771         * DOM/DOMHTMLInputElement.mm:
2772         (-[DOMHTMLInputElement _autofillContext]):
2773         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2774         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2775
2776 2017-10-05  Keith Miller  <keith_miller@apple.com>
2777
2778         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2779
2780         * Configurations/WebKitLegacy.xcconfig:
2781
2782 2017-10-05  Jer Noble  <jer.noble@apple.com>
2783
2784         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2785         https://bugs.webkit.org/show_bug.cgi?id=177261
2786
2787         Reviewed by Eric Carlson.
2788
2789         * Configurations/FeatureDefines.xcconfig:
2790
2791 2017-10-05  Chris Dumez  <cdumez@apple.com>
2792
2793         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2794         https://bugs.webkit.org/show_bug.cgi?id=177957
2795
2796         Reviewed by Alex Christensen.
2797
2798         * WebCoreSupport/WebPlatformStrategies.h:
2799         * WebCoreSupport/WebPlatformStrategies.mm:
2800         (WebPlatformStrategies::cookiesEnabled):
2801
2802 2017-10-05  Youenn Fablet  <youenn@apple.com>
2803
2804         Make LibWebRTCProvider port agnostic
2805         https://bugs.webkit.org/show_bug.cgi?id=177747
2806
2807         Reviewed by Alex Christensen & Alex Garcia.
2808
2809         * WebView/WebView.mm:
2810         (-[WebView _commonInitializationWithFrameName:groupName:]):
2811         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2812
2813 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2814
2815         Stop linking with WebKitSystemInterface
2816         https://bugs.webkit.org/show_bug.cgi?id=177915
2817
2818         Reviewed by Antti Koivisto.
2819
2820         * Configurations/DebugRelease.xcconfig:
2821         * Configurations/WebKitLegacy.xcconfig:
2822
2823 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2824
2825         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2826         https://bugs.webkit.org/show_bug.cgi?id=177912
2827
2828         Reviewed by Saam Barati.
2829
2830         * Carbon/CarbonUtils.m:
2831         * Carbon/CarbonWindowAdapter.mm:
2832         * Carbon/HIWebView.mm:
2833         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2834         * Misc/WebNSFileManagerExtras.mm:
2835         * Misc/WebNSPasteboardExtras.mm:
2836         * Misc/WebNSURLExtras.mm:
2837         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2838         * Plugins/Hosted/NetscapePluginHostManager.mm:
2839         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2840         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2841         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2842         * Plugins/Hosted/WebTextInputWindowController.m:
2843         * Plugins/WebBaseNetscapePluginView.mm:
2844         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2845         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2846         * Plugins/WebNetscapePluginStream.mm:
2847         * Plugins/WebNetscapePluginView.mm:
2848         * Plugins/WebPluginDatabase.mm:
2849         * WebCoreSupport/PopupMenuMac.mm:
2850         * WebCoreSupport/WebChromeClient.mm:
2851         * WebCoreSupport/WebFrameLoaderClient.mm:
2852         * WebCoreSupport/WebInspectorClient.mm:
2853         * WebCoreSupport/WebPlatformStrategies.mm:
2854         * WebCoreSupport/WebSystemInterface.mm:
2855         * WebView/WebDynamicScrollBarsView.mm:
2856         * WebView/WebFrame.mm:
2857         * WebView/WebFrameView.mm:
2858         * WebView/WebFullScreenController.mm:
2859         * WebView/WebHTMLView.mm:
2860         * WebView/WebPreferences.mm:
2861         * WebView/WebView.mm:
2862
2863 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2864
2865         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2866         rdar://problem/34705779
2867
2868         Addressing review comments that I somehow landed without.
2869
2870         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2871
2872 2017-09-29  Chris Dumez  <cdumez@apple.com>
2873
2874         Split some logic out of VisitedLinkStore and make it reusable
2875         https://bugs.webkit.org/show_bug.cgi?id=177575
2876
2877         Reviewed by Alex Christensen.
2878
2879         * WebCoreSupport/WebVisitedLinkStore.h:
2880         * WebCoreSupport/WebVisitedLinkStore.mm:
2881         (WebVisitedLinkStore::addVisitedLink):
2882         (WebVisitedLinkStore::removeVisitedLink):
2883         (WebVisitedLinkStore::isLinkVisited):
2884         (WebVisitedLinkStore::addVisitedLinkHash):
2885
2886 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2887
2888         Build fix for High Sierra 32 bit Mac
2889         https://bugs.webkit.org/show_bug.cgi?id=177551
2890         <rdar://problem/34690283>
2891
2892         Reviewed by Alexey Proskuryakov.
2893
2894         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2895         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2896         also made.
2897
2898         * Carbon/CarbonWindowAdapter.mm:
2899         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2900         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2901         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2902         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2903         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2904         (-[CarbonWindowAdapter dealloc]):
2905         (-[CarbonWindowAdapter windowRef]):
2906         (-[CarbonWindowAdapter _hasWindowRef]):
2907         (-[CarbonWindowAdapter _managesWindowRef]):
2908         (-[CarbonWindowAdapter _removeWindowRef]):
2909         (-[CarbonWindowAdapter _carbonWindowClass]):
2910         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2911         (-[CarbonWindowAdapter sendSuperEvent:]):
2912         (-[CarbonWindowAdapter relinquishFocus]):
2913         (-[CarbonWindowAdapter _cancelKey:]):
2914         (-[CarbonWindowAdapter _commonAwake]):
2915         (-[CarbonWindowAdapter _destroyRealWindow:]):
2916         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2917         (-[CarbonWindowAdapter _termWindowIfOwner]):
2918         (-[CarbonWindowAdapter _windowMovedToRect:]):
2919         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2920         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2921         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2922         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2923         (-[CarbonWindowAdapter canBecomeMainWindow]):
2924         (-[CarbonWindowAdapter encodeWithCoder:]):
2925         (-[CarbonWindowAdapter initWithCoder:]):
2926         (-[CarbonWindowAdapter setContentView:]):
2927         (-[CarbonWindowAdapter worksWhenModal]):
2928         (-[CarbonWindowAdapter _setModalWindowLevel]):
2929         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2930         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2931         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2932         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2933         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2934         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2935         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2936         (NSCarbonWindowHandleEvent):
2937         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2938         (-[CarbonWindowAdapter _growBoxRect]):
2939         * Carbon/HIWebView.mm:
2940         (HIWebViewGetWebView):
2941         (HIWebViewConstructor):
2942         (HIWebViewDestructor):
2943         (HIWebViewRegisterClass):
2944         (GetBehaviors):
2945         (Draw):
2946         (HitTest):
2947         (GetRegion):
2948         (GetWindowRef):
2949         (CreateNSEventAdoptingCGEvent):
2950         (CopyEventCGEvent):
2951         (CreateNSEventWithCarbonClickEvent):
2952         (Click):
2953         (CreateNSEventWithCarbonEvent):
2954         (MouseUp):
2955         (CreateNSEventWithCarbonMouseMoveEvent):
2956         (MouseMoved):
2957         (MouseDragged):
2958         (MouseWheelMoved):
2959         (ContextMenuClick):
2960         (GetKind):
2961         (BoundsChanged):
2962         (OwningWindowChanged):
2963         (WindowHandler):
2964         (SyncFrame):
2965         (SetFocusPart):
2966         (AdvanceFocus):
2967         (RelinquishFocus):
2968         (ActiveStateChanged):
2969         (ProcessCommand):
2970         (UpdateCommandStatus):
2971         (_NSSelectorForHICommand):
2972         (HIWebViewEventHandler):
2973         (StartUpdateObserver):
2974         (StopUpdateObserver):
2975         (UpdateObserver):
2976
2977 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2978
2979         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2980         https://bugs.webkit.org/show_bug.cgi?id=172526
2981         <rdar://problem/32396081>
2982
2983         Reviewed by Ryosuke Niwa.
2984
2985         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2986
2987         * WebCoreSupport/WebPlatformStrategies.h:
2988         * WebCoreSupport/WebPlatformStrategies.mm:
2989         (WebPlatformStrategies::webExposedTypes):
2990         (WebPlatformStrategies::writeCustomData):
2991
2992 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2993
2994         Unreviewed, rolling out r222567.
2995
2996         This broke and internal build.
2997
2998         Reverted changeset:
2999
3000         "Build fix for High Sierra 32 bit Mac"
3001         https://bugs.webkit.org/show_bug.cgi?id=177551
3002         http://trac.webkit.org/changeset/222567
3003
3004 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
3005
3006         Build fix for High Sierra 32 bit Mac
3007         https://bugs.webkit.org/show_bug.cgi?id=177551
3008         <rdar://problem/34690283>
3009
3010         Reviewed by Alexey Proskuryakov.
3011
3012         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3013         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3014         also made.
3015
3016         * Carbon/CarbonWindowAdapter.mm:
3017         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3018         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3019         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3020         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3021         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3022         (-[CarbonWindowAdapter dealloc]):
3023         (-[CarbonWindowAdapter windowRef]):
3024         (-[CarbonWindowAdapter _hasWindowRef]):
3025         (-[CarbonWindowAdapter _managesWindowRef]):
3026         (-[CarbonWindowAdapter _removeWindowRef]):
3027         (-[CarbonWindowAdapter _carbonWindowClass]):
3028         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3029         (-[CarbonWindowAdapter sendSuperEvent:]):
3030         (-[CarbonWindowAdapter relinquishFocus]):
3031         (-[CarbonWindowAdapter _cancelKey:]):
3032         (-[CarbonWindowAdapter _commonAwake]):
3033         (-[CarbonWindowAdapter _destroyRealWindow:]):
3034         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3035         (-[CarbonWindowAdapter _termWindowIfOwner]):
3036         (-[CarbonWindowAdapter _windowMovedToRect:]):
3037         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3038         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3039         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3040         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3041         (-[CarbonWindowAdapter canBecomeMainWindow]):
3042         (-[CarbonWindowAdapter encodeWithCoder:]):
3043         (-[CarbonWindowAdapter initWithCoder:]):
3044         (-[CarbonWindowAdapter setContentView:]):
3045         (-[CarbonWindowAdapter worksWhenModal]):
3046         (-[CarbonWindowAdapter _setModalWindowLevel]):
3047         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3048         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3049         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3050         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3051         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3052         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3053         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3054         (NSCarbonWindowHandleEvent):
3055         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3056         (-[CarbonWindowAdapter _growBoxRect]):
3057         * Carbon/HIWebView.mm:
3058         (HIWebViewGetWebView):
3059         (HIWebViewConstructor):
3060         (HIWebViewDestructor):
3061         (HIWebViewRegisterClass):
3062         (GetBehaviors):
3063         (Draw):
3064         (HitTest):
3065         (GetRegion):
3066         (GetWindowRef):
3067         (CreateNSEventAdoptingCGEvent):
3068         (CopyEventCGEvent):
3069         (CreateNSEventWithCarbonClickEvent):
3070         (Click):
3071         (CreateNSEventWithCarbonEvent):
3072         (MouseUp):
3073         (CreateNSEventWithCarbonMouseMoveEvent):
3074         (MouseMoved):
3075         (MouseDragged):
3076         (MouseWheelMoved):
3077         (ContextMenuClick):
3078         (GetKind):
3079         (BoundsChanged):
3080         (OwningWindowChanged):
3081         (WindowHandler):
3082         (SyncFrame):
3083         (SetFocusPart):
3084         (AdvanceFocus):
3085         (RelinquishFocus):
3086         (ActiveStateChanged):
3087         (ProcessCommand):
3088         (UpdateCommandStatus):
3089         (_NSSelectorForHICommand):
3090         (HIWebViewEventHandler):
3091         (StartUpdateObserver):
3092         (StopUpdateObserver):
3093         (UpdateObserver):
3094
3095 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3096
3097         Make PolicyAction an encodable enum class
3098         https://bugs.webkit.org/show_bug.cgi?id=177480
3099
3100         Reviewed by Antti Koivisto.
3101
3102         * Plugins/WebPluginContainerCheck.mm:
3103         (-[WebPluginContainerCheck _continueWithPolicy:]):
3104         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3105         * WebCoreSupport/WebFrameLoaderClient.mm:
3106         (-[WebFramePolicyListener invalidate]):
3107         (-[WebFramePolicyListener ignore]):
3108         (-[WebFramePolicyListener download]):
3109         (-[WebFramePolicyListener use]):
3110         (-[WebFramePolicyListener continue]):
3111         * WebView/WebPolicyDelegate.mm:
3112         (-[WebPolicyDecisionListener use]):
3113         (-[WebPolicyDecisionListener ignore]):
3114         (-[WebPolicyDecisionListener download]):
3115
3116 2017-09-25  Frederik Riedel  <riedel@apple.com>
3117
3118         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3119         https://bugs.webkit.org/show_bug.cgi?id=174394
3120         <rdar://problem/33183504>
3121
3122         Reviewed by Ryosuke Niwa.
3123
3124         * DOM/DOMHTMLInputElement.h:
3125         * DOM/DOMHTMLInputElement.mm:
3126         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3127         Determines if this HTMLInputElement is part of a login screen.
3128         (-[DOMHTMLInputElement representingPageUrl]):
3129         Returns the webpage's URL that is currently displayed in the Web View.
3130         (-[DOMHTMLInputElement insertTextSuggestion:]):
3131         Inserts login credentials into the Web View.
3132
3133 2017-09-25  Sam Weinig  <sam@webkit.org>
3134
3135         Remove unused EditorClient functions
3136         https://bugs.webkit.org/show_bug.cgi?id=177463
3137
3138         Reviewed by Alex Christensen.
3139
3140         Remove unused EditorClient functions.
3141
3142         * WebCoreSupport/WebEditorClient.h:
3143         * WebCoreSupport/WebEditorClient.mm:
3144         (WebEditorClient::canonicalizeURL): Deleted.
3145         (WebEditorClient::canonicalizeURLString): Deleted.
3146         (WebEditorClient::writeDataToPasteboard): Deleted.
3147         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3148         (WebEditorClient::readDataFromPasteboard): Deleted.
3149         (WebEditorClient::pasteboardChangeCount): Deleted.
3150
3151 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3152
3153         Stop using PolicyCallback
3154         https://bugs.webkit.org/show_bug.cgi?id=176088
3155
3156         Reviewed by Andy Estes.
3157
3158         * WebCoreSupport/WebFrameLoaderClient.mm:
3159         (-[WebFramePolicyListener invalidate]):
3160         (-[WebFramePolicyListener receivedPolicyDecision:]):
3161
3162 2017-09-25  Sam Weinig  <sam@webkit.org>
3163
3164         Remove unnecessary userVisibleString EditorClient function
3165         https://bugs.webkit.org/show_bug.cgi?id=177456
3166
3167         Reviewed by Dan Bernstein.
3168
3169         * WebCoreSupport/WebEditorClient.h:
3170         * WebCoreSupport/WebEditorClient.mm:
3171         (WebEditorClient::userVisibleString): Deleted.
3172
3173             Remove userVisibleString client function.
3174
3175 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3176
3177         Separate form submission from PolicyChecker infrastructure
3178         https://bugs.webkit.org/show_bug.cgi?id=177396
3179
3180         Reviewed by Geoffrey Garen.
3181
3182         * WebCoreSupport/WebFrameLoaderClient.h:
3183         * WebCoreSupport/WebFrameLoaderClient.mm:
3184         (WebFrameLoaderClient::dispatchWillSubmitForm):
3185
3186 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3187
3188         WeakPtrFactory should populate m_ref lazily.
3189         https://bugs.webkit.org/show_bug.cgi?id=177375
3190
3191         Reviewed by Geoffrey Garen.
3192
3193         * WebCoreSupport/WebEditorClient.mm:
3194         (WebEditorClient::WebEditorClient):
3195         (WebEditorClient::requestCandidatesForSelection):
3196
3197 2017-09-22  Chris Dumez  <cdumez@apple.com>
3198
3199         Use high resolution timestamp for event time
3200         https://bugs.webkit.org/show_bug.cgi?id=154246
3201         <rdar://problem/34333304>
3202
3203         Reviewed by Ryosuke Niwa.
3204
3205         Use WallTime / MonotonicTime instead of double type for clarity.
3206
3207         * DOM/DOMEvent.mm:
3208         (-[DOMEvent timeStamp]):
3209         * WebView/WebFrame.mm:
3210         (-[WebFrame _dragSourceEndedAt:operation:]):
3211         * WebView/WebPDFView.mm:
3212         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3213
3214 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3215
3216         Enable dataTransfer.items on macOS and iOS
3217         https://bugs.webkit.org/show_bug.cgi?id=177335
3218
3219         Reviewed by Sam Weinig.
3220
3221         * WebView/WebPreferences.mm:
3222         (+[WebPreferences initialize]):
3223
3224 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3225
3226         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3227         https://bugs.webkit.org/show_bug.cgi?id=177101
3228         <rdar://problem/34500648>
3229
3230         Reviewed by Brian Burg.
3231
3232         * WebInspector/WebNodeHighlight.mm:
3233         Ensure we close the window that we have just removed.
3234
3235 2017-09-20  Antti Koivisto  <antti@apple.com>
3236
3237         Remove DOM and styling support for CSS Regions
3238         https://bugs.webkit.org/show_bug.cgi?id=177221
3239
3240         Reviewed by Andreas Kling.
3241
3242         * Configurations/FeatureDefines.xcconfig:
3243         * DOM/DOMCSS.mm:
3244         (kitClass):
3245         * DOM/DOMElement.mm:
3246         (-[DOMElement webkitRegionOverset]): Deleted.
3247
3248 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3249
3250         Layering violation in Editor::createFragment
3251         https://bugs.webkit.org/show_bug.cgi?id=176123
3252
3253         Reviewed by Darin Adler.
3254
3255         * Misc/WebNSURLExtras.h:
3256         * Misc/WebNSURLExtras.mm:
3257         * WebView/WebFrame.mm:
3258         * WebView/WebHTMLView.mm:
3259         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3260
3261         * WebCoreSupport/WebEditorClient.mm:
3262         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3263         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3264         way to avoid exporting the symbol just on newer OSes.
3265
3266 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3267
3268         On iOS, getData can't get text set by setData during copy event
3269         https://bugs.webkit.org/show_bug.cgi?id=176980
3270         <rdar://problem/34453915>
3271
3272         Reviewed by Darin Adler.
3273
3274         * WebCoreSupport/WebPlatformStrategies.h:
3275         * WebCoreSupport/WebPlatformStrategies.mm:
3276         (WebPlatformStrategies::copy): Deleted.
3277
3278 2017-09-18  Andy Estes  <aestes@apple.com>
3279
3280         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3281         https://bugs.webkit.org/show_bug.cgi?id=177029
3282
3283         Reviewed by Alex Christensen.
3284
3285         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3286         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3287         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3288         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3289         * WebCoreSupport/PopupMenuMac.mm:
3290         (PopupMenuMac::show):
3291         * WebCoreSupport/WebSystemInterface.mm:
3292         (InitWebCoreSystemInterface):
3293         * WebView/WebHTMLView.mm:
3294         (-[WebHTMLView setDataSource:]):
3295         (-[WebHTMLView attachRootLayer:]):
3296         * WebView/WebView.mm:
3297         (-[WebView _needsAdobeFrameReloadingQuirk]):
3298         (-[WebView _needsLinkElementTextCSSQuirk]):
3299         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3300         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3301         (-[WebView _preferencesChanged:]):
3302
3303 2017-09-15  Andy Estes  <aestes@apple.com>
3304
3305         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3306         https://bugs.webkit.org/show_bug.cgi?id=176953
3307
3308         Reviewed by Eric Carlson.
3309
3310         * WebCoreSupport/WebSystemInterface.mm:
3311         (InitWebCoreSystemInterface):
3312
3313 2017-09-14  Andy Estes  <aestes@apple.com>
3314
3315         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3316         https://bugs.webkit.org/show_bug.cgi?id=176931
3317
3318         Reviewed by Joseph Pecoraro.
3319
3320         * WebCoreSupport/WebSystemInterface.mm:
3321         (InitWebCoreSystemInterface):
3322
3323 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3324
3325         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3326         https://bugs.webkit.org/show_bug.cgi?id=176867
3327
3328         Reviewed by Sam Weinig.
3329
3330         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3331         (WebKit::NetscapePluginInstanceProxy::enumerate):
3332
3333 2017-09-13  Andy Estes  <aestes@apple.com>
3334
3335         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3336         https://bugs.webkit.org/show_bug.cgi?id=176729
3337
3338         Reviewed by Alex Christensen.
3339
3340         * WebCoreSupport/WebSystemInterface.mm:
3341         (InitWebCoreSystemInterface):
3342         * WebView/WebView.mm:
3343         (+[WebView _setCacheModel:]):
3344
3345 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3346
3347         Refactor WebContentReader out of EditorMac and EditorIOS
3348         https://bugs.webkit.org/show_bug.cgi?id=176770
3349
3350         Reviewed by Sam Weinig.
3351
3352         * WebCoreSupport/WebEditorClient.mm:
3353
3354 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3355
3356         Dragging & dropping a file creates an attachment element even when it's disabled
3357         https://bugs.webkit.org/show_bug.cgi?id=176769
3358
3359         Reviewed by Tim Horton.
3360
3361         * WebView/WebView.mm:
3362         (-[WebView _preferencesChanged:]):
3363
3364 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3365
3366         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3367         https://bugs.webkit.org/show_bug.cgi?id=176721
3368         <rdar://problem/34373660>
3369
3370         Reviewed by Tim Horton.
3371
3372         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3373         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3374
3375         * WebView/WebView.mm:
3376         (-[WebView _startDrag:]):
3377         (-[WebView _draggedElementBounds]):
3378         (-[WebView _endedDataInteraction:global:]):
3379         * WebView/WebViewData.h:
3380
3381 2017-09-11  Andy Estes  <aestes@apple.com>
3382
3383         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3384         https://bugs.webkit.org/show_bug.cgi?id=176472
3385
3386         Reviewed by Eric Carlson.
3387
3388         * WebCoreSupport/WebSystemInterface.mm:
3389         (InitWebCoreSystemInterface):
3390
3391 2017-09-09  Mark Lam  <mark.lam@apple.com>
3392
3393         Avoid duplicate computations of ExecState::vm().
3394         https://bugs.webkit.org/show_bug.cgi?id=176647
3395
3396         Reviewed by Saam Barati.
3397
3398         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3399         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3400         (WebKit::NetscapePluginInstanceProxy::construct):
3401         (WebKit::NetscapePluginInstanceProxy::setProperty):
3402         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3403         (WebKit::NetscapePluginInstanceProxy::enumerate):
3404         * Plugins/Hosted/ProxyInstance.mm:
3405         (WebKit::ProxyRuntimeMethod::create):
3406
3407 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3408
3409         Unreviewed, rolling out r221773.
3410         https://bugs.webkit.org/show_bug.cgi?id=176614
3411
3412         This caused build failures. (Requested by mlewis13 on
3413         #webkit).
3414
3415         Reverted changeset:
3416
3417         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3418         https://bugs.webkit.org/show_bug.cgi?id=176472
3419         http://trac.webkit.org/changeset/221773
3420
3421 2017-09-07  Andy Estes  <aestes@apple.com>
3422
3423         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3424         https://bugs.webkit.org/show_bug.cgi?id=176472
3425
3426         Reviewed by Eric Carlson.
3427
3428         * WebCoreSupport/WebSystemInterface.mm:
3429         (InitWebCoreSystemInterface):
3430
3431 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3432
3433         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3434         https://bugs.webkit.org/show_bug.cgi?id=176561
3435
3436         Reviewed by Brent Fulgham.
3437
3438         * Misc/WebNSUserDefaultsExtras.mm:
3439
3440 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3441
3442         Modernize Geolocation code
3443         https://bugs.webkit.org/show_bug.cgi?id=176496
3444
3445         Reviewed by Andy Estes.
3446
3447         * WebCoreSupport/WebGeolocationClient.h:
3448         * WebCoreSupport/WebGeolocationClient.mm:
3449         (WebGeolocationClient::requestPermission):
3450         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3451         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3452         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3453         * WebView/WebView.mm:
3454         (-[WebView _commonInitializationWithFrameName:groupName:]):
3455         (-[WebView _geolocationDidFailWithMessage:]):
3456
3457 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3458
3459         Remove some unused bits of code and resources
3460         https://bugs.webkit.org/show_bug.cgi?id=176275
3461
3462         Reviewed by Dan Bernstein.
3463
3464         * Misc/WebNSFileManagerExtras.mm:
3465         Include FileSystem instead of FileSystemIOS.
3466
3467 2017-09-03  Darin Adler  <darin@apple.com>
3468
3469         [Cocoa] Tidy a few things in legacy WebHTMLView
3470         https://bugs.webkit.org/show_bug.cgi?id=176280
3471
3472         Reviewed by Dan Bernstein.
3473
3474         * WebCoreSupport/WebChromeClient.mm:
3475         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3476         methods it calls on WebHTMLView were doing nothing on iOS.
3477
3478         * WebView/WebFrame.mm:
3479         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3480         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3481
3482         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3483         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3484         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3485         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3486         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3487         Use RetainPtr instead of writing retain/release wherever possible.
3488         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3489         initialization for it. Removed various unused methods and declarations of methods.
3490         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3491         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3492         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3493         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3494         and remove CFRetain no longer needed since we don't support garbage collection any more.
3495         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3496         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3497         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3498         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3499         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3500         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3501         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3502         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3503         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3504         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3505         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3506         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make