Use more C++17
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Use more C++17
4         https://bugs.webkit.org/show_bug.cgi?id=185176
5
6         Reviewed by JF Bastien.
7
8         * Configurations/Base.xcconfig:
9         * Configurations/WebKitLegacy.xcconfig:
10
11 2018-05-21  Chris Nardi  <cnardi@chromium.org>
12
13         Remove dead exception in MediaList.appendMedium
14         https://bugs.webkit.org/show_bug.cgi?id=185278
15
16         Reviewed by Chris Dumez.
17
18         Remove code pertaining to an exception being thrown by appendMedium().
19
20         * DOM/DOMMediaList.mm:
21         (-[DOMMediaList appendMedium:]):
22
23 2018-05-21  Jer Noble  <jer.noble@apple.com>
24
25         Complete fix for enabling modern EME by default
26         https://bugs.webkit.org/show_bug.cgi?id=185770
27         <rdar://problem/40368220>
28
29         Reviewed by Eric Carlson.
30
31         * Configurations/FeatureDefines.xcconfig:
32
33 2018-05-21  Antti Koivisto  <antti@apple.com>
34
35         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
36         https://bugs.webkit.org/show_bug.cgi?id=185815
37         <rdar://problem/40310069>
38
39         Reviewed by Simon Fraser.
40
41         User stylesheet parsing may depend on the colorFilterEnabled preference.
42
43         * WebView/WebView.mm:
44         (-[WebView _preferencesChanged:]):
45
46 2018-05-18  Commit Queue  <commit-queue@webkit.org>
47
48         Unreviewed, rolling out r231982.
49         https://bugs.webkit.org/show_bug.cgi?id=185793
50
51         Caused layout test failures (Requested by realdawei on
52         #webkit).
53
54         Reverted changeset:
55
56         "Complete fix for enabling modern EME by default"
57         https://bugs.webkit.org/show_bug.cgi?id=185770
58         https://trac.webkit.org/changeset/231982
59
60 2018-05-18  Jer Noble  <jer.noble@apple.com>
61
62         Complete fix for enabling modern EME by default
63         https://bugs.webkit.org/show_bug.cgi?id=185770
64         <rdar://problem/40368220>
65
66         Reviewed by Eric Carlson.
67
68         * Configurations/FeatureDefines.xcconfig:
69
70 2018-05-18  Chris Dumez  <cdumez@apple.com>
71
72         Avoid keeping the frame alive when ref'ing a WindowProxy
73         https://bugs.webkit.org/show_bug.cgi?id=185737
74         <rdar://problem/40004666>
75
76         Reviewed by Sam Weinig.
77
78         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
79         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
80
81 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
82
83         Add support for Intl NumberFormat formatToParts
84         https://bugs.webkit.org/show_bug.cgi?id=185375
85
86         Reviewed by Yusuke Suzuki.
87
88         Add flag for NumberFormat formatToParts.
89
90         * Configurations/FeatureDefines.xcconfig:
91
92 2018-05-16  Chris Nardi  <cnardi@chromium.org>
93
94         Fixup after r231849: Do not mark Mac API methods as deprecated
95         https://bugs.webkit.org/show_bug.cgi?id=185684
96
97         Reviewed by Darin Adler.
98
99         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
100         as the entire class is already marked as deprecated, so it is unnecessary.
101
102         * DOM/DOMDocument.h:
103
104 2018-05-16  Chris Nardi  <cnardi@chromium.org>
105
106         Remove Document#selectedStylesheetSet/preferredStylesheetSet
107         https://bugs.webkit.org/show_bug.cgi?id=185381
108
109         Reviewed by Darin Adler.
110
111         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
112         and make them do nothing.
113
114         * DOM/DOMDocument.h:
115         * DOM/DOMDocument.mm:
116         (-[DOMDocument preferredStylesheetSet]):
117         (-[DOMDocument selectedStylesheetSet]):
118         (-[DOMDocument setSelectedStylesheetSet:]):
119
120 2018-05-15  Antoine Quint  <graouts@apple.com>
121
122         [Web Animations] Expose Web Animations CSS integration as an experimental feature
123         https://bugs.webkit.org/show_bug.cgi?id=185647
124
125         Reviewed by Dean Jackson.
126
127         Rename the Web Animations CSS integration flag.
128
129         * WebView/WebPreferenceKeysPrivate.h:
130         * WebView/WebPreferences.mm:
131         (+[WebPreferences initialize]):
132         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
133         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
134         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
135         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
136         * WebView/WebPreferencesPrivate.h:
137         * WebView/WebView.mm:
138         (-[WebView _preferencesChanged:]):
139
140 2018-05-14  Daniel Bates  <dabates@apple.com>
141
142         Fix the Apple Internal build
143
144         See <rdar://problem/40237873> for more details.
145
146         * WebView/WebFullScreenController.mm:
147         (-[WebFullScreenController enterFullScreen:]):
148         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
149         (-[WebFullScreenController exitFullScreen]):
150         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
151         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
152         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
153
154 2018-05-11  Timothy Hatcher  <timothy@apple.com>
155
156         WebHTMLView is not setting aside subviews when drawing.
157
158         https://bugs.webkit.org/show_bug.cgi?id=185561
159         rdar://problem/40172894
160
161         Reviewed by Simon Fraser.
162
163         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
164
165         * WebView/WebHTMLView.mm:
166         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
167
168 2018-05-07  Daniel Bates  <dabates@apple.com>
169
170         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
171         https://bugs.webkit.org/show_bug.cgi?id=185170
172
173         Reviewed by Per Arne Vollan.
174
175         * Misc/WebCache.mm:
176         (+[WebCache empty]):
177
178 2018-05-04  Timothy Hatcher  <timothy@apple.com>
179
180         Deprecate legacy WebView and friends
181         https://bugs.webkit.org/show_bug.cgi?id=185279
182         rdar://problem/33268700
183
184         Reviewed by Tim Horton.
185
186         Added deprecation macros to all the classes, extern strings, and enums.
187
188         * Configurations/WebKitLegacy.xcconfig:
189         Added BUILDING_WEBKIT define to disable the deprecation macros.
190         * DOM/DOMAbstractView.h:
191         * DOM/DOMAttr.h:
192         * DOM/DOMBlob.h:
193         * DOM/DOMCDATASection.h:
194         * DOM/DOMCSSCharsetRule.h:
195         * DOM/DOMCSSFontFaceRule.h:
196         * DOM/DOMCSSImportRule.h:
197         * DOM/DOMCSSMediaRule.h:
198         * DOM/DOMCSSPageRule.h:
199         * DOM/DOMCSSPrimitiveValue.h:
200         * DOM/DOMCSSRule.h:
201         * DOM/DOMCSSRuleList.h:
202         * DOM/DOMCSSStyleDeclaration.h:
203         * DOM/DOMCSSStyleRule.h:
204         * DOM/DOMCSSStyleSheet.h:
205         * DOM/DOMCSSUnknownRule.h:
206         * DOM/DOMCSSValue.h:
207         * DOM/DOMCSSValueList.h:
208         * DOM/DOMCharacterData.h:
209         * DOM/DOMComment.h:
210         * DOM/DOMCounter.h:
211         * DOM/DOMDocument.h:
212         * DOM/DOMDocumentFragment.h:
213         * DOM/DOMDocumentType.h:
214         * DOM/DOMElement.h:
215         * DOM/DOMEntity.h:
216         * DOM/DOMEntityReference.h:
217         * DOM/DOMEvent.h:
218         * DOM/DOMEventException.h:
219         * DOM/DOMEventListener.h:
220         * DOM/DOMEventTarget.h:
221         * DOM/DOMException.h:
222         * DOM/DOMFile.h:
223         * DOM/DOMFileList.h:
224         * DOM/DOMHTMLAnchorElement.h:
225         * DOM/DOMHTMLAppletElement.h:
226         * DOM/DOMHTMLAreaElement.h:
227         * DOM/DOMHTMLBRElement.h:
228         * DOM/DOMHTMLBaseElement.h:
229         * DOM/DOMHTMLBaseFontElement.h:
230         * DOM/DOMHTMLBodyElement.h:
231         * DOM/DOMHTMLButtonElement.h:
232         * DOM/DOMHTMLCanvasElement.h:
233         * DOM/DOMHTMLCollection.h:
234         * DOM/DOMHTMLDListElement.h:
235         * DOM/DOMHTMLDirectoryElement.h:
236         * DOM/DOMHTMLDivElement.h:
237         * DOM/DOMHTMLDocument.h:
238         * DOM/DOMHTMLElement.h:
239         * DOM/DOMHTMLEmbedElement.h:
240         * DOM/DOMHTMLFieldSetElement.h:
241         * DOM/DOMHTMLFontElement.h:
242         * DOM/DOMHTMLFormElement.h:
243         * DOM/DOMHTMLFrameElement.h:
244         * DOM/DOMHTMLFrameSetElement.h:
245         * DOM/DOMHTMLHRElement.h:
246         * DOM/DOMHTMLHeadElement.h:
247         * DOM/DOMHTMLHeadingElement.h:
248         * DOM/DOMHTMLHtmlElement.h:
249         * DOM/DOMHTMLIFrameElement.h:
250         * DOM/DOMHTMLImageElement.h:
251         * DOM/DOMHTMLInputElement.h:
252         * DOM/DOMHTMLLIElement.h:
253         * DOM/DOMHTMLLabelElement.h:
254         * DOM/DOMHTMLLegendElement.h:
255         * DOM/DOMHTMLLinkElement.h:
256         * DOM/DOMHTMLMapElement.h:
257         * DOM/DOMHTMLMarqueeElement.h:
258         * DOM/DOMHTMLMediaElement.h:
259         * DOM/DOMHTMLMenuElement.h:
260         * DOM/DOMHTMLMetaElement.h:
261         * DOM/DOMHTMLModElement.h:
262         * DOM/DOMHTMLOListElement.h:
263         * DOM/DOMHTMLObjectElement.h:
264         * DOM/DOMHTMLOptGroupElement.h:
265         * DOM/DOMHTMLOptionElement.h:
266         * DOM/DOMHTMLOptionsCollection.h:
267         * DOM/DOMHTMLParagraphElement.h:
268         * DOM/DOMHTMLParamElement.h:
269         * DOM/DOMHTMLPreElement.h:
270         * DOM/DOMHTMLQuoteElement.h:
271         * DOM/DOMHTMLScriptElement.h:
272         * DOM/DOMHTMLSelectElement.h:
273         * DOM/DOMHTMLStyleElement.h:
274         * DOM/DOMHTMLTableCaptionElement.h:
275         * DOM/DOMHTMLTableCellElement.h:
276         * DOM/DOMHTMLTableColElement.h:
277         * DOM/DOMHTMLTableElement.h:
278         * DOM/DOMHTMLTableRowElement.h:
279         * DOM/DOMHTMLTableSectionElement.h:
280         * DOM/DOMHTMLTextAreaElement.h:
281         * DOM/DOMHTMLTitleElement.h:
282         * DOM/DOMHTMLUListElement.h:
283         * DOM/DOMHTMLVideoElement.h:
284         * DOM/DOMImplementation.h:
285         * DOM/DOMKeyboardEvent.h:
286         * DOM/DOMMediaError.h:
287         * DOM/DOMMediaList.h:
288         * DOM/DOMMouseEvent.h:
289         * DOM/DOMMutationEvent.h:
290         * DOM/DOMNamedNodeMap.h:
291         * DOM/DOMNode.h:
292         * DOM/DOMNodeFilter.h:
293         * DOM/DOMNodeIterator.h:
294         * DOM/DOMNodeList.h:
295         * DOM/DOMObject.h:
296         * DOM/DOMOverflowEvent.h:
297         * DOM/DOMProcessingInstruction.h:
298         * DOM/DOMProgressEvent.h:
299         * DOM/DOMRGBColor.h:
300         * DOM/DOMRange.h:
301         * DOM/DOMRangeException.h:
302         * DOM/DOMRect.h:
303         * DOM/DOMStyleSheet.h:
304         * DOM/DOMStyleSheetList.h:
305         * DOM/DOMText.h:
306         * DOM/DOMTextEvent.h:
307         * DOM/DOMTimeRanges.h:
308         * DOM/DOMTokenList.h:
309         * DOM/DOMTreeWalker.h:
310         * DOM/DOMUIEvent.h:
311         * DOM/DOMWheelEvent.h:
312         * DOM/DOMXPathException.h:
313         * DOM/DOMXPathExpression.h:
314         * DOM/DOMXPathNSResolver.h:
315         * DOM/DOMXPathResult.h:
316         * History/WebBackForwardList.h:
317         * History/WebHistory.h:
318         * History/WebHistoryItem.h:
319         * Misc/WebDownload.h:
320         * Misc/WebKitErrors.h:
321         * Plugins/WebPluginViewFactory.h:
322         * WebView/WebArchive.h:
323         * WebView/WebDataSource.h:
324         * WebView/WebDocument.h:
325         * WebView/WebEditingDelegate.h:
326         * WebView/WebFormDelegate.h:
327         * WebView/WebFrame.h:
328         * WebView/WebFrameLoadDelegate.h:
329         * WebView/WebFrameView.h:
330         * WebView/WebPolicyDelegate.h:
331         * WebView/WebPreferences.h:
332         * WebView/WebPreferencesPrivate.h:
333         * WebView/WebResourceLoadDelegate.h:
334         * WebView/WebUIDelegate.h:
335         * WebView/WebUIDelegatePrivate.h:
336         * WebView/WebView.h:
337         * WebView/WebViewPrivate.h:
338         * postprocess-headers.sh:
339         Remove step that converts WEBKIT macros to NS macros.
340         Change it to just remove the macros on iOS builds.
341
342 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
343
344         [MediaStream] remove WK1 support
345         https://bugs.webkit.org/show_bug.cgi?id=185136
346
347         Reviewed by Youenn Fablet.
348
349         * WebCoreSupport/WebUserMediaClient.h: Removed.
350         * WebCoreSupport/WebUserMediaClient.mm: Removed.
351         * WebView/WebView.mm:
352         (-[WebView _commonInitializationWithFrameName:groupName:]):
353         (-[WebView _preferencesChanged:]):
354         (-[WebView _setUserMediaClient:]): Deleted.
355         (-[WebView _userMediaClient]): Deleted.
356         * WebView/WebViewData.h:
357         * WebView/WebViewPrivate.h:
358
359 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
360
361         WebAssembly: add support for stream APIs - JavaScript API
362         https://bugs.webkit.org/show_bug.cgi?id=183442
363
364         Reviewed by Yusuke Suzuki and JF Bastien.
365
366         Add WEBASSEMBLY_STREAMINNG_API feature flag
367
368         * Configurations/FeatureDefines.xcconfig:
369
370 2018-04-30  JF Bastien  <jfbastien@apple.com>
371
372         Use some C++17 features
373         https://bugs.webkit.org/show_bug.cgi?id=185135
374
375         Reviewed by Alex Christensen.
376
377         * Configurations/WebKitLegacy.xcconfig:
378
379 2018-04-27  Chris Dumez  <cdumez@apple.com>
380
381         Use WindowProxy instead of DOMWindow in our IDL
382         https://bugs.webkit.org/show_bug.cgi?id=185022
383
384         Reviewed by Sam Weinig.
385
386         * DOM/DOMAbstractView.mm:
387         (kit):
388         (toWindowProxy):
389         * DOM/DOMAbstractViewInternal.h:
390         * DOM/DOMDocument.mm:
391         (-[DOMDocument defaultView]):
392         (-[DOMDocument getComputedStyle:pseudoElement:]):
393         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
394         * DOM/DOMHTMLFrameElement.mm:
395         (-[DOMHTMLFrameElement contentWindow]):
396         * DOM/DOMHTMLIFrameElement.mm:
397         (-[DOMHTMLIFrameElement contentWindow]):
398         * DOM/DOMKeyboardEvent.mm:
399         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
400         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
401         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
402         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
403         * DOM/DOMMouseEvent.mm:
404         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
405         * DOM/DOMTextEvent.mm:
406         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
407         * DOM/DOMUIEvent.mm:
408         (-[DOMUIEvent view]):
409         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
410         * DOM/DOMWheelEvent.mm:
411         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
412
413 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
414
415         Implement rendering support for the color-filter CSS property
416         https://bugs.webkit.org/show_bug.cgi?id=185047
417         rdar://problem/39664967
418
419         Reviewed by Tim Horton.
420         
421         The body background should reflect the filtered color.
422
423         * WebView/WebFrame.mm:
424         (-[WebFrame _bodyBackgroundColor]):
425         * WebView/WebView.mm:
426         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
427
428 2018-04-26  Jer Noble  <jer.noble@apple.com>
429
430         WK_COCOA_TOUCH all the things.
431         https://bugs.webkit.org/show_bug.cgi?id=185006
432
433         Reviewed by Tim Horton.
434
435         * Configurations/WebKitLegacy.xcconfig:
436
437 2018-04-26  Daniel Bates  <dabates@apple.com>
438
439         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
440         https://bugs.webkit.org/show_bug.cgi?id=184161
441         <rdar://problem/39051645>
442
443         Reviewed by Dan Bernstein.
444
445         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
446         dropping a PDF embedded using an HTML image element into the same web view.
447
448         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
449         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
450         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
451         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
452         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
453         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
454         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
455         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
456         image document when navigated to directly. Since we can support dragging PDF document images we need to
457         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
458         We need to do both such queries before falling back to using the main resource of the Web Archive as
459         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
460         not an image document.
461
462         * Misc/WebNSPasteboardExtras.mm:
463         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
464
465 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
466
467         Disable content filtering in minimal simulator mode
468         https://bugs.webkit.org/show_bug.cgi?id=185027
469         <rdar://problem/39736091>
470
471         Reviewed by Jer Noble.
472
473         * Configurations/FeatureDefines.xcconfig:
474
475 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
476
477         [INTL] Implement Intl.PluralRules
478         https://bugs.webkit.org/show_bug.cgi?id=184312
479
480         Reviewed by JF Bastien.
481
482         Added Intl.PluralRules feature flag.
483
484         * Configurations/FeatureDefines.xcconfig:
485
486 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
487
488         Remove access to keychain from the WebContent process
489         https://bugs.webkit.org/show_bug.cgi?id=184428
490         <rdar://problem/13150903>
491
492         Reviewed by Brent Fulgham.
493
494         This patch does the followings:
495         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
496         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
497         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
498
499         * WebCoreSupport/WebChromeClient.h:
500         * WebCoreSupport/WebChromeClient.mm:
501         (WebChromeClient::signedPublicKeyAndChallengeString const):
502         * WebView/WebUIDelegatePrivate.h:
503
504 2018-04-24  Jer Noble  <jer.noble@apple.com>
505
506         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
507         https://bugs.webkit.org/show_bug.cgi?id=184786
508
509         Reviewed by Tim Horton.
510
511         * Configurations/WebKitLegacy.xcconfig:
512         * MigrateHeaders.make:
513
514 2018-04-23  Daniel Bates  <dabates@apple.com>
515
516         Implement Same-Site cookies
517         https://bugs.webkit.org/show_bug.cgi?id=159464
518         <rdar://problem/27196358>
519
520         Reviewed by Brent Fulgham.
521
522         Pass the Same-Site info through the strategy.
523
524         * WebCoreSupport/WebPlatformStrategies.h:
525         * WebCoreSupport/WebPlatformStrategies.mm:
526         (WebPlatformStrategies::cookiesForDOM):
527         (WebPlatformStrategies::setCookiesFromDOM):
528         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
529         (WebPlatformStrategies::getRawCookies):
530
531 2018-04-23  Zalan Bujtas  <zalan@apple.com>
532
533         [LayoutFormattingContext] Initial commit.
534         https://bugs.webkit.org/show_bug.cgi?id=184896
535
536         Reviewed by Antti Koivisto.
537
538         * Configurations/FeatureDefines.xcconfig:
539
540 2018-04-23  Daniel Bates  <dabates@apple.com>
541
542         Implement Same-Site cookies
543         https://bugs.webkit.org/show_bug.cgi?id=159464
544         <rdar://problem/27196358>
545
546         Reviewed by Brent Fulgham.
547
548         Pass the Same-Site info through the strategy.
549
550         * WebCoreSupport/WebPlatformStrategies.h:
551         * WebCoreSupport/WebPlatformStrategies.mm:
552         (WebPlatformStrategies::cookiesForDOM):
553         (WebPlatformStrategies::setCookiesFromDOM):
554         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
555         (WebPlatformStrategies::getRawCookies):
556
557 2018-04-20  Timothy Hatcher  <timothy@apple.com>
558
559         NULL dereference crash sometimes under [super initWithCoder:] in WebView
560
561         https://bugs.webkit.org/show_bug.cgi?id=184851
562         rdar://problem/39611236
563
564         Reviewed by Tim Horton.
565
566         * WebView/WebView.mm:
567         (-[WebView _commonInitializationWithFrameName:groupName:]):
568         (-[WebView effectiveAppearanceDidChange]):
569         Added a null check and call the code later in initialization.
570
571 2018-04-20  Tim Horton  <timothy_horton@apple.com>
572
573         Adjust geolocation feature flag
574         https://bugs.webkit.org/show_bug.cgi?id=184856
575
576         Reviewed by Wenson Hsieh.
577
578         * Configurations/FeatureDefines.xcconfig:
579
580 2018-04-18  Jer Noble  <jer.noble@apple.com>
581
582         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
583         https://bugs.webkit.org/show_bug.cgi?id=184762
584
585         Reviewed by Dan Bernstein.
586
587         * Configurations/WebKitLegacy.xcconfig:
588
589 2018-04-20  Youenn Fablet  <youenn@apple.com>
590
591         Make PluginData cache its web visible plugins
592         https://bugs.webkit.org/show_bug.cgi?id=184421
593
594         Reviewed by Chris Dumez.
595
596         * WebCoreSupport/WebPluginInfoProvider.h:
597         * WebCoreSupport/WebPluginInfoProvider.mm:
598         (WebPluginInfoProvider::pluginInfo):
599         (WebPluginInfoProvider::webVisiblePluginInfo):
600
601 2018-04-19  Chris Dumez  <cdumez@apple.com>
602
603         Rename JSDOMWindowProxy to JSWindowProxy
604         https://bugs.webkit.org/show_bug.cgi?id=184797
605
606         Reviewed by Sam Weinig.
607
608         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
609
610         * DOM/DOMUtility.mm:
611         (createDOMWrapper):
612         * WebView/WebFrame.mm:
613         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
614
615 2018-04-19  David Kilzer  <ddkilzer@apple.com>
616
617         Enable Objective-C weak references
618         <https://webkit.org/b/184789>
619         <rdar://problem/39571716>
620
621         Reviewed by Dan Bernstein.
622
623         * Configurations/Base.xcconfig:
624         (CLANG_ENABLE_OBJC_WEAK): Enable.
625
626 2018-04-18  Chris Dumez  <cdumez@apple.com>
627
628         Rename WindowProxyController to WindowProxy
629         https://bugs.webkit.org/show_bug.cgi?id=184756
630
631         Reviewed by Sam Weinig.
632
633         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
634         needed use WindowProxyController type, which was a bit confusing.
635
636         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
637         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
638         * WebView/WebFrame.mm:
639         (-[WebFrame _attachScriptDebugger]):
640
641 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
642
643         Unreviewed rollout of r230632. Regression in memory usage.
644
645         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
646
647         * WebView/WebPreferences.mm:
648         (+[WebPreferences initialize]):
649
650 2018-04-17  Chris Dumez  <cdumez@apple.com>
651
652         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
653         https://bugs.webkit.org/show_bug.cgi?id=184678
654         <rdar://problem/39422122>
655
656         Reviewed by Alex Christensen.
657
658         Add new parameter to dispatchDecidePolicyForNavigationAction.
659
660         * WebCoreSupport/WebFrameLoaderClient.h:
661         * WebCoreSupport/WebFrameLoaderClient.mm:
662         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
663
664 2018-04-13  Chris Dumez  <cdumez@apple.com>
665
666         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
667         https://bugs.webkit.org/show_bug.cgi?id=184591
668
669         Reviewed by Sam Weinig.
670
671         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
672         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
673         This is work towards fixing Bug 184515.
674
675         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
676         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
677         * WebView/WebFrame.mm:
678         (-[WebFrame _attachScriptDebugger]):
679
680 2018-04-12  Antoine Quint  <graouts@apple.com>
681
682         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
683         https://bugs.webkit.org/show_bug.cgi?id=184569
684         <rdar://problem/38671301>
685
686         Reviewed by Jon Lee.
687
688         * WebView/WebPreferences.mm:
689
690 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
691
692         [WTF] Remove StaticLock
693         https://bugs.webkit.org/show_bug.cgi?id=184332
694
695         Reviewed by Mark Lam.
696
697         * DOM/DOMInternal.mm:
698         (getDOMWrapper):
699         (addDOMWrapper):
700         (removeDOMWrapper):
701
702 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
703
704         Failures from mach port reference handling should be fatal
705         https://bugs.webkit.org/show_bug.cgi?id=184202
706         <rdar://problem/37771114>
707
708         Reviewed by Anders Carlsson.
709
710         * Plugins/Hosted/NetscapePluginHostManager.mm:
711         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
712
713 2018-04-03  Andy Estes  <aestes@apple.com>
714
715         [Mac] Prioritize file promises over filenames during drag and drop
716         https://bugs.webkit.org/show_bug.cgi?id=184237
717         <rdar://problem/38278076>
718
719         Reviewed by Wenson Hsieh.
720
721         * WebView/WebView.mm:
722         (-[WebView performDragOperation:]):
723
724 2018-04-03  Chris Dumez  <cdumez@apple.com>
725
726         Drop MainFrame class
727         https://bugs.webkit.org/show_bug.cgi?id=184191
728
729         Reviewed by Darin Adler.
730
731         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
732         relationship between the Page and the MainFrame.
733
734         This is ground work for introducing LocalFrame / RemoteFrame concepts.
735
736         * WebCoreSupport/WebDragClient.mm:
737         * WebCoreSupport/WebFrameLoaderClient.mm:
738         * WebCoreSupport/WebInspectorClient.mm:
739         * WebCoreSupport/WebPlatformStrategies.mm:
740         * WebCoreSupport/WebPluginInfoProvider.mm:
741         * WebView/WebFrame.mm:
742         * WebView/WebFrameView.mm:
743         * WebView/WebHTMLView.mm:
744         * WebView/WebView.mm:
745
746 2018-04-02  Jer Noble  <jer.noble@apple.com>
747
748         Enable Legacy EME for all WebKit & WebKitLegacy clients
749         https://bugs.webkit.org/show_bug.cgi?id=184018
750         <rdar://problem/34887387>
751
752         Reviewed by Eric Carlson.
753
754         * WebView/WebPreferences.mm:
755         (+[WebPreferences initialize]):
756
757 2018-03-29  JF Bastien  <jfbastien@apple.com>
758
759         Use Forward.h instead of forward-declaring WTF::String
760         https://bugs.webkit.org/show_bug.cgi?id=184172
761         <rdar://problem/39026146>
762
763         Reviewed by Yusuke Suzuki.
764
765         As part of #184164 I'm changing WTF::String, and the forward
766         declarations are just wrong because I'm making it templated. We
767         should use Forward.h anyways, so do that instead.
768
769         * WebView/WebScriptDebugger.h:
770
771 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
772
773         Protect against invalid mach ports returned by mach_port_request_notification
774         https://bugs.webkit.org/show_bug.cgi?id=184106
775         <rdar://problem/37865316>
776
777         Reviewed by Chris Dumez.
778
779         * Plugins/Hosted/NetscapePluginHostProxy.mm:
780         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
781         and clean up if it experienced an error.
782         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
783
784 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
785
786         Avoid uninitialized mach ports
787         https://bugs.webkit.org/show_bug.cgi?id=184090
788         <rdar://problem/37261129>
789
790         Reviewed by Chris Dumez.
791
792         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
793         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
794         there is a potential for us to try to use invalid ports.
795
796         We should always check return values, and ensure that the mach port variables we seek to initialize are
797         kept in a valid state.
798
799         Reviewed by Chris Dumez.
800
801         * Plugins/Hosted/NetscapePluginHostManager.h:
802         * Plugins/Hosted/NetscapePluginHostManager.mm:
803         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
804         port is passed to an API function.
805         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
806         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
807         * Plugins/Hosted/NetscapePluginHostProxy.h:
808         * Plugins/Hosted/NetscapePluginHostProxy.mm:
809         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
810         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
811         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
812         (WKPCStatusText): Ditto.
813         (WKPCLoadURL): Ditto.
814         (WKPCCancelLoadURL): Ditto.
815         (WKPCInvalidateRect): Ditto.
816         (WKPCGetScriptableNPObjectReply): Ditto.
817         (WKPCBooleanReply): Ditto.
818         (WKPCBooleanAndDataReply): Ditto.
819         (WKPCInstantiatePluginReply): Ditto.
820         (WKPCGetWindowNPObject): Ditto.
821         (WKPCGetPluginElementNPObject): Ditto.
822         (WKPCForgetBrowserObject): Ditto.
823         (WKPCEvaluate): Ditto.
824         (WKPCGetStringIdentifier): Ditto.
825         (WKPCGetIntIdentifier): Ditto.
826         (WKPCInvoke): Ditto.
827         (WKPCInvokeDefault): Ditto.
828         (WKPCConstruct): Ditto.
829         (WKPCGetProperty): Ditto.
830         (WKPCSetProperty): Ditto.
831         (WKPCRemoveProperty): Ditto.
832         (WKPCHasProperty): Ditto.
833         (WKPCHasMethod): Ditto.
834         (WKPCIdentifierInfo): Ditto.
835         (WKPCEnumerate): Ditto.
836         (WKPCSetMenuBarVisible): Ditto.
837         (WKPCSetFullscreenWindowIsShowing): Ditto.
838         (WKPCSetModal): Ditto.
839         (WKPCGetCookies): Ditto.
840         (WKPCGetProxy): Ditto.
841         (WKPCSetCookies): Ditto.
842         (WKPCGetAuthenticationInfo): Ditto.
843         (WKPCConvertPoint): Ditto.
844         (WKPCLayerHostingModeChanged): Ditto.
845         (WKPCSetException): Ditto.
846
847 2018-03-26  Tim Horton  <timothy_horton@apple.com>
848
849         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
850         https://bugs.webkit.org/show_bug.cgi?id=184030
851         <rdar://problem/38895281>
852
853         Reviewed by Dan Bernstein.
854
855         * Configurations/Base.xcconfig:
856
857 2018-03-26  Chris Dumez  <cdumez@apple.com>
858
859         Use SecurityOriginData more consistently in Service Worker code
860         https://bugs.webkit.org/show_bug.cgi?id=183969
861
862         Reviewed by Darin Adler.
863
864         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
865
866         * Storage/WebDatabaseManager.mm:
867         (-[WebDatabaseManager databasesWithOrigin:]):
868         (-[WebDatabaseManager deleteOrigin:]):
869         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
870         * Storage/WebDatabaseQuotaManager.mm:
871         (-[WebDatabaseQuotaManager usage]):
872         (-[WebDatabaseQuotaManager quota]):
873         (-[WebDatabaseQuotaManager setQuota:]):
874         * Storage/WebStorageManager.mm:
875         (-[WebStorageManager deleteOrigin:]):
876         * WebCoreSupport/WebSecurityOrigin.mm:
877         (-[WebSecurityOrigin databaseIdentifier]):
878         (-[WebSecurityOrigin usage]):
879         (-[WebSecurityOrigin quota]):
880         (-[WebSecurityOrigin setQuota:]):
881
882 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
883
884         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
885         https://bugs.webkit.org/show_bug.cgi?id=183911
886         <rdar://problem/38762306>
887
888         Reviewed by Youenn Fablet.
889
890         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
891
892         * WebView/WebView.mm:
893         (+[WebView initialize]):
894
895 2018-03-26  Alex Christensen  <achristensen@webkit.org>
896
897         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
898         https://bugs.webkit.org/show_bug.cgi?id=183965
899
900         Reviewed by Chris Dumez.
901
902         * WebCoreSupport/WebFrameLoaderClient.h:
903         * WebCoreSupport/WebFrameLoaderClient.mm:
904         (WebFrameLoaderClient::willCacheResponse const):
905
906 2018-03-25  Commit Queue  <commit-queue@webkit.org>
907
908         Unreviewed, rolling out r229954.
909         https://bugs.webkit.org/show_bug.cgi?id=184000
910
911         Caused many layout tests to crash on Apple High Sierra,
912         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
913         by dydz on #webkit).
914
915         Reverted changeset:
916
917         "Use SecurityOriginData more consistently in Service Worker
918         code"
919         https://bugs.webkit.org/show_bug.cgi?id=183969
920         https://trac.webkit.org/changeset/229954
921
922 2018-03-24  Chris Dumez  <cdumez@apple.com>
923
924         Use SecurityOriginData more consistently in Service Worker code
925         https://bugs.webkit.org/show_bug.cgi?id=183969
926
927         Reviewed by Darin Adler.
928
929         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
930
931         * Storage/WebDatabaseManager.mm:
932         (-[WebDatabaseManager databasesWithOrigin:]):
933         (-[WebDatabaseManager deleteOrigin:]):
934         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
935         * Storage/WebDatabaseQuotaManager.mm:
936         (-[WebDatabaseQuotaManager usage]):
937         (-[WebDatabaseQuotaManager quota]):
938         (-[WebDatabaseQuotaManager setQuota:]):
939         * Storage/WebStorageManager.mm:
940         (-[WebStorageManager deleteOrigin:]):
941         * WebCoreSupport/WebSecurityOrigin.mm:
942         (-[WebSecurityOrigin databaseIdentifier]):
943         (-[WebSecurityOrigin usage]):
944         (-[WebSecurityOrigin quota]):
945         (-[WebSecurityOrigin setQuota:]):
946
947 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
948
949         Fix the build
950
951         * WebView/WebView.mm:
952
953 2018-03-23  Tim Horton  <timothy_horton@apple.com>
954
955         Fix the build with no pasteboard
956         https://bugs.webkit.org/show_bug.cgi?id=183973
957
958         Reviewed by Dan Bernstein.
959
960         * Configurations/FeatureDefines.xcconfig:
961         * WebView/WebView.mm:
962         (-[WebView _requestStartDataInteraction:globalPosition:]):
963         (-[WebView _getDataInteractionData]):
964         (-[WebView _dataOperationTextIndicator]):
965         (-[WebView _dragSourceAction]):
966         (-[WebView _draggedLinkTitle]):
967         (-[WebView _draggedLinkURL]):
968         (-[WebView _draggedElementBounds]):
969         (-[WebView _enteredDataInteraction:client:global:operation:]):
970         (-[WebView _updatedDataInteraction:client:global:operation:]):
971         (-[WebView _exitedDataInteraction:client:global:operation:]):
972         (-[WebView _performDataInteraction:client:global:operation:]):
973         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
974         (-[WebView _endedDataInteraction:global:]):
975         (-[WebView _dataInteractionCaretRect]):
976         * WebView/WebViewPrivate.h:
977
978 2018-03-23  Tim Horton  <timothy_horton@apple.com>
979
980         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
981         https://bugs.webkit.org/show_bug.cgi?id=183960
982         <rdar://problem/38812356>
983
984         Reviewed by Dan Bernstein.
985
986         * Configurations/WebKitLegacy.xcconfig:
987
988 2018-03-23  Tim Horton  <timothy_horton@apple.com>
989
990         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
991         https://bugs.webkit.org/show_bug.cgi?id=183954
992         <rdar://problem/38808858>
993
994         Reviewed by Dan Bernstein.
995
996         * WebView/WebPreferences.mm:
997         (-[WebPreferences setAudioSessionCategoryOverride:]):
998
999 2018-03-23  Tim Horton  <timothy_horton@apple.com>
1000
1001         Adopt WK_PLATFORM_NAME in WebKitLegacy
1002         https://bugs.webkit.org/show_bug.cgi?id=183948
1003         <rdar://problem/38803908>
1004
1005         Reviewed by Dan Bernstein.
1006
1007         * Configurations/WebKitLegacy.xcconfig:
1008         * MigrateHeaders.make:
1009         * postprocess-headers.sh:
1010
1011 2018-03-23  Brady Eidson  <beidson@apple.com>
1012
1013         Go to back/forward list items after a process-swapped navigation.
1014         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1015
1016         Reviewed by Andy Estes.
1017
1018         * WebView/WebView.mm:
1019         (-[WebView _loadBackForwardListFromOtherView:]):
1020         (-[WebView goToBackForwardItem:]):
1021
1022 2018-03-22  Tim Horton  <timothy_horton@apple.com>
1023
1024         Improve readability of WebCore's OTHER_LDFLAGS
1025         https://bugs.webkit.org/show_bug.cgi?id=183909
1026         <rdar://problem/38760992>
1027
1028         Reviewed by Dan Bernstein.
1029
1030         * Configurations/Base.xcconfig:
1031         * Configurations/FeatureDefines.xcconfig:
1032
1033 2018-03-20  Tim Horton  <timothy_horton@apple.com>
1034
1035         Enable the minimal simulator feature flag when appropriate
1036         https://bugs.webkit.org/show_bug.cgi?id=183807
1037
1038         Reviewed by Dan Bernstein.
1039
1040         * Configurations/FeatureDefines.xcconfig:
1041
1042 2018-03-20  Tim Horton  <timothy_horton@apple.com>
1043
1044         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
1045         https://bugs.webkit.org/show_bug.cgi?id=183758
1046         <rdar://problem/38017644>
1047
1048         Reviewed by Dan Bernstein.
1049
1050         * Configurations/FeatureDefines.xcconfig:
1051
1052 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
1053
1054         Clear style colors when setting default appearance
1055         https://bugs.webkit.org/show_bug.cgi?id=183759
1056
1057         Reviewed by Tim Horton.
1058
1059         Colors are cached and need to be cleared and recalculated.
1060         Refactor to do all style recalcs together.
1061
1062         * WebView/WebView.mm:
1063         (-[WebView _setDefaultAppearanceAndClearStyle]):
1064         (-[WebView _setUseSystemAppearance:]):
1065         (-[WebView effectiveAppearanceDidChange]):
1066
1067 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1068
1069         Unreviewed, another quick fix for r229699
1070
1071         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
1072
1073         * Configurations/FeatureDefines.xcconfig:
1074
1075 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
1076
1077         Ensure that style is updated when the effective appearance changes
1078         https://bugs.webkit.org/show_bug.cgi?id=183690
1079         <rdar://problem/38385900>
1080
1081         Reviewed by Tim Horton and Wenson Hsieh.
1082
1083         Respond to and respect the effective appearance changing.
1084
1085         * WebView/WebView.mm:
1086         (-[WebView _setUseSystemAppearance:]):
1087         (-[WebView effectiveAppearanceDidChange]):
1088
1089 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
1090
1091         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
1092         https://bugs.webkit.org/show_bug.cgi?id=183677
1093
1094         Reviewed by Tim Horton.
1095
1096         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
1097
1098         * DOM/DOM.mm:
1099         (-[DOMHTMLLinkElement _mediaQueryMatches]):
1100
1101 2018-03-14  Tim Horton  <timothy_horton@apple.com>
1102
1103         Fix the build after r229567
1104
1105         * Configurations/FeatureDefines.xcconfig:
1106
1107 2018-03-12  Tim Horton  <timothy_horton@apple.com>
1108
1109         Stop using SDK conditionals to control feature definitions
1110         https://bugs.webkit.org/show_bug.cgi?id=183430
1111         <rdar://problem/38251619>
1112
1113         Reviewed by Dan Bernstein.
1114
1115         * Configurations/FeatureDefines.xcconfig:
1116         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
1117
1118 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
1119
1120         Runtime flag for link prefetch and remove link subresource.
1121         https://bugs.webkit.org/show_bug.cgi?id=183540
1122
1123         Reviewed by Chris Dumez.
1124
1125         Remove the LINK_PREFETCH build time flag.
1126
1127         * Configurations/FeatureDefines.xcconfig:
1128
1129 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
1130
1131         Remove GridLayout runtime flag
1132         https://bugs.webkit.org/show_bug.cgi?id=183484
1133
1134         Reviewed by Myles C. Maxfield.
1135
1136         The Grid Layout feature has been enabled by default for almost a
1137         year, so I think it's time to remove the runtime flag and the
1138
1139         * WebView/WebPreferenceKeysPrivate.h:
1140         * WebView/WebPreferences.mm:
1141         (+[WebPreferences initialize]):
1142         * WebView/WebPreferencesPrivate.h:
1143         * WebView/WebView.mm:
1144         (-[WebView _preferencesChanged:]):
1145
1146 2018-03-12  Antoine Quint  <graouts@apple.com>
1147
1148         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1149         https://bugs.webkit.org/show_bug.cgi?id=183504
1150         <rdar://problem/38372965>
1151
1152         Reviewed by Dean Jackson and Jon Lee.
1153
1154         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1155         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1156
1157         * WebView/WebPreferenceKeysPrivate.h:
1158         * WebView/WebPreferences.mm:
1159         (+[WebPreferences initialize]):
1160         (-[WebPreferences setModernMediaControlsEnabled:]):
1161         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
1162         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
1163         * WebView/WebPreferencesPrivate.h:
1164         * WebView/WebView.mm:
1165         (-[WebView _preferencesChanged:]):
1166
1167 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
1168
1169         Media query for default appearance
1170         https://bugs.webkit.org/show_bug.cgi?id=183539
1171         <rdar://problem/38326388>
1172
1173         Reviewed by Tim Horton.
1174
1175         Write a media query to evaluate appearance.
1176
1177         * WebView/WebView.mm:
1178         (-[WebView _commonInitializationWithFrameName:groupName:]):
1179         (-[WebView _setUseSystemAppearance:]):
1180
1181 2018-03-09  Andy Estes  <aestes@apple.com>
1182
1183         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
1184         https://bugs.webkit.org/show_bug.cgi?id=183489
1185         <rdar://problem/38267517>
1186
1187         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
1188         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
1189         to issue a sandbox extension for this directory, but for security reasons App Sandbox
1190         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
1191         block with a nil error and a valid file URL, but no file will actually exist at that URL.
1192
1193         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
1194         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
1195         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
1196         drop destination.
1197
1198         Reviewed by Wenson Hsieh.
1199
1200         * WebView/WebView.mm:
1201         (-[WebView performDragOperation:]):
1202
1203 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
1204
1205         Allow WebViews to disable system appearance
1206         https://bugs.webkit.org/show_bug.cgi?id=183418
1207         <rdar://problem/36975642>
1208
1209         Reviewed by Tim Horton.
1210
1211         Allow webviews to choose whether or not to follow the default system appearance.
1212
1213         * WebView/WebView.mm:
1214         (-[WebView _setUseSystemAppearance:]):
1215         (-[WebView _useSystemAppearance]):
1216         * WebView/WebViewPrivate.h:
1217
1218 2018-03-08  Youenn Fablet  <youenn@apple.com>
1219
1220         libwebrtc update broke internal builds
1221         https://bugs.webkit.org/show_bug.cgi?id=183454
1222
1223         Reviewed by Eric Carlson.
1224
1225         * Configurations/WebKitLegacy.xcconfig:
1226
1227 2018-03-08  Chris Dumez  <cdumez@apple.com>
1228
1229         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
1230         https://bugs.webkit.org/show_bug.cgi?id=183455
1231         <rdar://problem/38191749>
1232
1233         Reviewed by Youenn Fablet.
1234
1235         Add a null check for the page as we have evidence from crashes that it can be null.
1236         Other functions in WebFrameNetworkingContext already null check the page as well,
1237         not just the frame so this is consistent.
1238
1239         * WebCoreSupport/WebFrameNetworkingContext.mm:
1240         (WebFrameNetworkingContext::storageSession const):
1241
1242 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1243
1244         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1245         https://bugs.webkit.org/show_bug.cgi?id=183429
1246
1247         Reviewed by Mark Lam.
1248
1249         * DOM/DOM.mm:
1250         (+[DOMNode _nodeFromJSWrapper:]):
1251         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1252         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1253         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1254         * Plugins/Hosted/ProxyInstance.mm:
1255         (WebKit::ProxyInstance::invokeMethod):
1256         * WebView/WebView.mm:
1257         (aeDescFromJSValue):
1258
1259 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1260
1261         Stop linking ApplicationServices directly
1262         https://bugs.webkit.org/show_bug.cgi?id=182867
1263         <rdar://problem/38252142>
1264
1265         Reviewed by Alex Christensen.
1266
1267         The frameworks that we use that live inside ApplicationServices
1268         have mostly moved out, so import them directly.
1269
1270         * Carbon/CarbonUtils.h:
1271         * WebKitPrefix.h:
1272         * WebView/WebHTMLView.mm:
1273         * WebView/WebPDFView.mm:
1274
1275 2018-03-07  Tim Horton  <timothy_horton@apple.com>
1276
1277         Sort and separate FeatureDefines.xcconfig
1278         https://bugs.webkit.org/show_bug.cgi?id=183427
1279
1280         Reviewed by Dan Bernstein.
1281
1282         * Configurations/FeatureDefines.xcconfig:
1283         Sort and split FeatureDefines into paragraphs
1284         (to make it easier to sort later).
1285
1286 2018-03-07  Youenn Fablet  <youenn@apple.com>
1287
1288         Match unsupported plugins based on domains and not origin
1289         https://bugs.webkit.org/show_bug.cgi?id=183384
1290
1291         Reviewed by Chris Dumez.
1292
1293         * WebCoreSupport/WebPluginInfoProvider.h:
1294         * WebCoreSupport/WebPluginInfoProvider.mm:
1295         (WebPluginInfoProvider::getPluginInfo):
1296         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1297
1298 2018-03-05  Andy Estes  <aestes@apple.com>
1299
1300         [Mac] Teach WebCore::Pasteboard about file promise drags
1301         https://bugs.webkit.org/show_bug.cgi?id=183314
1302         <rdar://problem/38105493>
1303
1304         Reviewed by Darin Adler.
1305
1306         Added a FIXME comment.
1307
1308         * WebView/WebView.mm:
1309         (-[WebView performDragOperation:]):
1310
1311 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1312
1313         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1314         https://bugs.webkit.org/show_bug.cgi?id=183312
1315
1316         Reviewed by Mark Lam.
1317
1318         Remove wtf/CurrentTime.h include pragma.
1319
1320         * WebView/WebFrame.mm:
1321         * WebView/WebPDFView.mm:
1322
1323 2018-03-04  Tim Horton  <timothy_horton@apple.com>
1324
1325         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
1326         https://bugs.webkit.org/show_bug.cgi?id=183283
1327         <rdar://problem/38062148>
1328
1329         Reviewed by Sam Weinig.
1330
1331         * Configurations/FeatureDefines.xcconfig:
1332
1333 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1334
1335         Reduce use of NetworkingContext in WebKit
1336         https://bugs.webkit.org/show_bug.cgi?id=183213
1337
1338         Reviewed by Brady Eidson.
1339
1340         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1341         (WebKit::NetscapePluginInstanceProxy::getProxy):
1342         * Plugins/WebNetscapePluginView.mm:
1343         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1344
1345 2018-02-17  Darin Adler  <darin@apple.com>
1346
1347         Prepare for ExtendedColor changes (first step)
1348         https://bugs.webkit.org/show_bug.cgi?id=182904
1349
1350         Reviewed by Sam Weinig.
1351
1352         * Misc/WebKitNSStringExtras.mm:
1353         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
1354
1355 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1356
1357         Remove currentTime() / currentTimeMS()
1358         https://bugs.webkit.org/show_bug.cgi?id=183052
1359
1360         Reviewed by Mark Lam.
1361
1362         * WebCoreSupport/WebFrameLoaderClient.h:
1363         * WebCoreSupport/WebFrameLoaderClient.mm:
1364         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1365
1366 2018-02-16  Youenn Fablet  <youenn@apple.com>
1367
1368         Allow specifying which plug-ins are supported
1369         https://bugs.webkit.org/show_bug.cgi?id=182748
1370
1371         Reviewed by Chris Dumez.
1372
1373         * WebCoreSupport/WebPluginInfoProvider.h:
1374         * WebCoreSupport/WebPluginInfoProvider.mm:
1375         (WebPluginInfoProvider::getPluginInfo):
1376         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1377
1378 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
1379
1380         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
1381         https://bugs.webkit.org/show_bug.cgi?id=182882
1382         <rdar://problem/35672661>
1383
1384         Reviewed by Dan Bernstein.
1385
1386         Make sure the smart pointer hold the collection of subviews lives at least as
1387         long as the loop using it.
1388
1389         * WebView/WebHTMLView.mm:
1390         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
1391
1392 2018-02-14  Daniel Bates  <dabates@apple.com>
1393
1394         Disallow cross-origin subresources from asking for credentials
1395         https://bugs.webkit.org/show_bug.cgi?id=182579
1396         <rdar://problem/36162271>
1397
1398         Reviewed by Andy Estes.
1399
1400         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
1401         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
1402
1403         * WebView/WebPreferenceKeysPrivate.h:
1404         * WebView/WebPreferences.mm:
1405         (+[WebPreferences initialize]):
1406         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
1407         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
1408         * WebView/WebPreferencesPrivate.h:
1409         * WebView/WebView.mm:
1410         (-[WebView _preferencesChanged:]):
1411
1412 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1413
1414         Remove ForwardingHeaders directory from WebKitLegacy/mac.
1415         https://bugs.webkit.org/show_bug.cgi?id=182738
1416
1417         Reviewed by Darin Adler.
1418
1419         * ForwardingHeaders/collector/handles/Global.h: Removed.
1420         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
1421         * ForwardingHeaders/runtime/Completion.h: Removed.
1422         * ForwardingHeaders/runtime/Error.h: Removed.
1423         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
1424         * ForwardingHeaders/runtime/JSFunction.h: Removed.
1425         * ForwardingHeaders/runtime/JSLock.h: Removed.
1426         * ForwardingHeaders/runtime/JSObject.h: Removed.
1427         * ForwardingHeaders/runtime/JSString.h: Removed.
1428         * ForwardingHeaders/runtime/Protect.h: Removed.
1429         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
1430
1431 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1432
1433         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
1434         https://bugs.webkit.org/show_bug.cgi?id=182641
1435
1436         Reviewed by Dan Bernstein.
1437
1438         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1439         https://trac.webkit.org/changeset/228308.
1440
1441         * WebView/WebVideoFullscreenController.h:
1442         * WebView/WebVideoFullscreenHUDWindowController.mm:
1443         * WebView/WebWindowAnimation.h:
1444         * WebView/WebWindowAnimation.mm:
1445         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1446         (WebCore::scaledRect): Deleted.
1447         (WebCore::squaredDistance): Deleted.
1448
1449 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1450
1451         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1452
1453         * WebView/WebWindowAnimation.mm:
1454         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1455
1456 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1457
1458         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1459         https://bugs.webkit.org/show_bug.cgi?id=182615
1460
1461         Reviewed by Eric Carlson.
1462
1463         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1464         Ideally, we should not reference NSApp in WebCore.
1465
1466         * WebView/WebFullScreenController.mm:
1467         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1468         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1469         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1470         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1471         * WebView/WebView.mm:
1472         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1473         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1474
1475 2018-01-13  Darin Adler  <darin@apple.com>
1476
1477         Event improvements
1478         https://bugs.webkit.org/show_bug.cgi?id=179591
1479
1480         Reviewed by Chris Dumez.
1481
1482         * DOM/DOMWheelEvent.mm:
1483         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1484         Call initWebKitWheelEvent.
1485
1486         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1487         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1488         * WebView/WebFrame.mm: Ditto.
1489
1490         * WebView/WebHTMLView.mm:
1491         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1492         underlyingPlatformEvent.
1493         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1494
1495         * WebView/WebScriptWorld.mm:
1496         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1497
1498         * WebView/WebView.mm: Removed include of ScriptValue.h.
1499
1500 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1501
1502         Remove WebCore/ForwardingHeaders directory
1503         https://bugs.webkit.org/show_bug.cgi?id=182347
1504
1505         Reviewed by Keith Miller.
1506
1507         * Carbon/CarbonWindowAdapter.mm:
1508         * DOM/WebDOMOperations.mm:
1509         * History/WebBackForwardList.mm:
1510         * History/WebHistoryItem.mm:
1511         * Misc/WebCache.mm:
1512         * Misc/WebElementDictionary.mm:
1513         * Misc/WebIconDatabase.mm:
1514         * Misc/WebStringTruncator.mm:
1515         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1516         * Plugins/Hosted/ProxyInstance.mm:
1517         * Plugins/Hosted/ProxyRuntimeObject.mm:
1518         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1519         * Plugins/WebBaseNetscapePluginView.mm:
1520         * Plugins/WebBasePluginPackage.mm:
1521         * Plugins/WebNetscapePluginStream.mm:
1522         * Plugins/WebNetscapePluginView.mm:
1523         * Plugins/WebPluginController.mm:
1524         * WebCoreSupport/WebEditorClient.mm:
1525         * WebCoreSupport/WebFrameLoaderClient.mm:
1526         * WebCoreSupport/WebInspectorClient.h:
1527         * WebCoreSupport/WebInspectorClient.mm:
1528         * WebView/WebDataSource.mm:
1529         * WebView/WebFrame.mm:
1530         * WebView/WebHTMLRepresentation.mm:
1531         * WebView/WebHTMLView.mm:
1532         * WebView/WebPreferences.mm:
1533         * WebView/WebScriptDebugDelegate.mm:
1534         * WebView/WebScriptDebugger.h:
1535         * WebView/WebTextIterator.mm:
1536         * WebView/WebView.mm:
1537         * WebView/WebViewData.mm:
1538
1539 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1540
1541         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1542         https://bugs.webkit.org/show_bug.cgi?id=182312
1543
1544         Reviewed by Michael Catanzaro.
1545
1546         * WebKitPrefix.h:
1547
1548 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1549
1550         [WebAuthN] Add a compile-time feature flag
1551         https://bugs.webkit.org/show_bug.cgi?id=182211
1552         <rdar://problem/36936365>
1553
1554         Reviewed by Brent Fulgham.
1555
1556         * Configurations/FeatureDefines.xcconfig:
1557
1558 2018-01-27  Dan Bernstein  <mitz@apple.com>
1559
1560         HaveInternalSDK includes should be "#include?"
1561         https://bugs.webkit.org/show_bug.cgi?id=179670
1562
1563         * Configurations/Base.xcconfig:
1564
1565 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1566
1567         Remove unused QTKit preference
1568         https://bugs.webkit.org/show_bug.cgi?id=181968
1569
1570         Reviewed by Alexey Proskuryakov.
1571
1572         * WebView/WebPreferenceKeysPrivate.h:
1573         * WebView/WebPreferences.mm:
1574         (+[WebPreferences initialize]):
1575         (-[WebPreferences setQTKitEnabled:]): Deleted.
1576         (-[WebPreferences isQTKitEnabled]): Deleted.
1577         * WebView/WebPreferencesPrivate.h:
1578         * WebView/WebView.mm:
1579         (-[WebView _preferencesChanged:]):
1580
1581 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1582
1583         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1584         https://bugs.webkit.org/show_bug.cgi?id=182037
1585         <rdar://problem/36747812>
1586
1587         Reviewed by Ryosuke Niwa.
1588
1589         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1590         for more details.
1591
1592         * WebView/WebHTMLRepresentation.mm:
1593         (-[WebHTMLRepresentation elementWithName:inForm:]):
1594         (-[WebHTMLRepresentation controlsInForm:]):
1595
1596 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1597
1598         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1599         https://bugs.webkit.org/show_bug.cgi?id=181961
1600
1601         Reviewed by Michael Catanzaro.
1602
1603         * WebView/WebPreferences.mm:
1604
1605 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1606
1607         Unreviewed, rolling out r227437.
1608         https://bugs.webkit.org/show_bug.cgi?id=182011
1609
1610         broke build (Requested by alexchristensen on #webkit).
1611
1612         Reverted changeset:
1613
1614         "Remove unused QTKit preference"
1615         https://bugs.webkit.org/show_bug.cgi?id=181968
1616         https://trac.webkit.org/changeset/227437
1617
1618 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1619
1620         Remove unused QTKit preference
1621         https://bugs.webkit.org/show_bug.cgi?id=181968
1622
1623         Reviewed by Alexey Proskuryakov.
1624
1625         * WebView/WebPreferenceKeysPrivate.h:
1626         * WebView/WebPreferences.mm:
1627         (+[WebPreferences initialize]):
1628         (-[WebPreferences setQTKitEnabled:]): Deleted.
1629         (-[WebPreferences isQTKitEnabled]): Deleted.
1630         * WebView/WebPreferencesPrivate.h:
1631         * WebView/WebView.mm:
1632         (-[WebView _preferencesChanged:]):
1633
1634 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1635
1636         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1637         https://bugs.webkit.org/show_bug.cgi?id=181960
1638         <rdar://problem/36431678>
1639
1640         Reviewed by Tim Horton.
1641
1642         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1643         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1644         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1645
1646         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1647         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1648         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1649
1650         * WebView/WebView.mm:
1651         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1652
1653 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1654
1655         Turning off custom pasteboard data doesn't actually turn it off in WK2
1656         https://bugs.webkit.org/show_bug.cgi?id=181920
1657         <rdar://problem/36686429>
1658
1659         Reviewed by Wenson Hsieh.
1660
1661         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1662
1663         * WebView/WebPreferences.mm:
1664         (+[WebPreferences initialize]):
1665         * WebView/WebView.mm:
1666         (-[WebView _preferencesChanged:]):
1667
1668 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1669
1670         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1671         https://bugs.webkit.org/show_bug.cgi?id=181918
1672
1673         Reviewed by Tim Horton.
1674
1675         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1676
1677         * Configurations/FeatureDefines.xcconfig:
1678
1679 2018-01-20  Andy Estes  <aestes@apple.com>
1680
1681         [Apple Pay] Stop eagerly loading PassKit.framework
1682         https://bugs.webkit.org/show_bug.cgi?id=181911
1683         <rdar://problem/36555369>
1684
1685         Reviewed by Tim Horton.
1686
1687         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1688         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1689         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1690
1691         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1692
1693 2018-01-19  Dean Jackson  <dino@apple.com>
1694
1695         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1696         https://bugs.webkit.org/show_bug.cgi?id=181817
1697         <rdar://problem/35274055>
1698
1699         Reviewed by Simon Fraser.
1700
1701         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1702
1703         * Misc/WebKitVersionChecks.h:
1704         * WebView/WebView.mm:
1705         (-[WebView _commonInitializationWithFrameName:groupName:]):
1706
1707 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1708
1709         Remove unused WebViewPrivate _allowCookies
1710         https://bugs.webkit.org/show_bug.cgi?id=181812
1711
1712         Reviewed by Tim Horton.
1713
1714         * WebView/WebView.mm:
1715         (+[WebView _setAllowCookies:]): Deleted.
1716         (+[WebView _allowCookies]): Deleted.
1717         * WebView/WebViewPrivate.h:
1718
1719 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1720
1721         Build fix, remove a call to -[NSWindow setOneShot:]
1722         https://bugs.webkit.org/show_bug.cgi?id=181809
1723
1724         Reviewed by Tim Horton.
1725
1726         * WebView/WebTextCompletionController.mm:
1727         (-[WebTextCompletionController _buildUI]):
1728
1729 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1730
1731         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1732
1733         * Carbon/HIWebView.mm:
1734         (overrideCGContext):
1735         (restoreCGContext):
1736
1737 2018-01-18  Dan Bernstein  <mitz@apple.com>
1738
1739         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1740         https://bugs.webkit.org/show_bug.cgi?id=181803
1741
1742         Reviewed by Tim Horton.
1743
1744         * Configurations/Base.xcconfig: Updated.
1745         * Configurations/DebugRelease.xcconfig: Ditto.
1746         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1747         * Configurations/Version.xcconfig: Updated.
1748         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1749           useful for defining settings that depend on the target macOS version.
1750
1751 2018-01-17  Youenn Fablet  <youenn@apple.com>
1752
1753         Put fetch Request.keepalive behind a runtime flag
1754         https://bugs.webkit.org/show_bug.cgi?id=181592
1755
1756         Reviewed by Chris Dumez.
1757
1758         * WebView/WebPreferenceKeysPrivate.h:
1759         * WebView/WebPreferences.mm:
1760         (+[WebPreferences initialize]):
1761         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1762         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1763         * WebView/WebPreferencesPrivate.h:
1764         * WebView/WebView.mm:
1765         (-[WebView _preferencesChanged:]):
1766
1767 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1768
1769         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1770         https://bugs.webkit.org/show_bug.cgi?id=181637
1771         <rdar://problem/36508471>
1772
1773         Reviewed by Tim Horton.
1774
1775         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1776
1777         * WebCoreSupport/WebEditorClient.h:
1778         * WebCoreSupport/WebEditorClient.mm:
1779         (WebEditorClient::replacementURLForResource):
1780
1781 2018-01-11  Keith Miller  <keith_miller@apple.com>
1782
1783         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1784         https://bugs.webkit.org/show_bug.cgi?id=181573
1785
1786         Reviewed by Simon Fraser.
1787
1788         * Configurations/FeatureDefines.xcconfig:
1789
1790 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1793         https://bugs.webkit.org/show_bug.cgi?id=181497
1794
1795         Reviewed by Tim Horton.
1796
1797         See other ChangeLogs for more detail.
1798
1799         * WebCoreSupport/WebDragClient.h:
1800
1801 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1802
1803         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1804         https://bugs.webkit.org/show_bug.cgi?id=181523
1805         <rdar://problem/28959131>
1806
1807         Reviewed by Alex Christensen.
1808
1809         * WebView/WebImmediateActionController.mm:
1810         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1811         Apply the change made in r216652 to WebKit1's immediate action controller.
1812
1813         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1814         the startContainer of the range is in an anonymous node.
1815
1816 2018-01-11  Youenn Fablet  <youenn@apple.com>
1817
1818         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1819         https://bugs.webkit.org/show_bug.cgi?id=181480
1820
1821         Reviewed by Eric Carlson.
1822
1823         * WebView/WebPreferences.mm:
1824         (+[WebPreferences initialize]):
1825
1826 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1827
1828         Fix check-webkit-style issues with WebNSDataExtras.mm
1829         <https://webkit.org/b/181369>
1830
1831         Reviewed by Alex Christensen.
1832
1833         * Misc/WebNSDataExtras.mm:
1834         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1835         (-[NSData _webkit_guessedMIMETypeForXML]):
1836         (-[NSData _webkit_guessedMIMEType]):
1837         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1838         (_findEOL):
1839         (-[NSData _webkit_parseRFC822HeaderFields]):
1840         (-[NSData _web_locationAfterFirstBlankLine]):
1841         - Fix all the check-webkit-style warnings.
1842
1843 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1844
1845         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1846         <https://webkit.org/b/181256>
1847         <rdar://problem/36281730>
1848
1849         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1850         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1851         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1852           to avoid warnings from casting CFStringRef to NPNSString*.
1853           Note that CFMutableStringRef is the same as CFStringRef
1854           without the const modifier, hence its use in the const_cast<>
1855           above.
1856
1857 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1858
1859         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1860         <https://webkit.org/b/181256>
1861         <rdar://problem/36281730>
1862
1863         * Carbon/HIWebView.mm:
1864         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1865         checked_cf_cast<CFRunLoopRef>() to fix warning.
1866
1867 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1868
1869         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1870         <https://webkit.org/b/181256>
1871         <rdar://problem/36281730>
1872
1873         Reviewed by Darin Adler.
1874
1875         * Carbon/CarbonUtils.m:
1876         (PoolCleaner):
1877         - Use #pragmas to ignore -Wcast-qual warnings when using a
1878           C-style cast from CFTypeRef to CFRunloopRef.
1879         * Carbon/CarbonWindowFrame.m:
1880         (-[CarbonWindowFrame title]):
1881         - Use #pragmas to ignore -Wcast-qual warnings when using a
1882           C-style cast from CFStringRef to NSString *.
1883         * Carbon/HIViewAdapter.m:
1884         (+[HIViewAdapter getHIViewForNSView:]):
1885         - Use #pragmas to ignore -Wcast-qual warnings when using a
1886           C-style cast from CFTypeRef to HIViewRef.
1887         * Configurations/Base.xcconfig:
1888         (WARNING_CFLAGS): Add -Wcast-qual.
1889         * Misc/WebElementDictionary.mm:
1890         (-[WebElementDictionary objectForKey:]):
1891         - Use static_cast<SEL>(const_cast<void*>()) to fix
1892           warning.
1893         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1894         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1895         (-[NSData _webkit_guessedMIMETypeForXML]):
1896         (-[NSData _webkit_guessedMIMEType]):
1897         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1898         (_findEOL):
1899         (-[NSData _webkit_parseRFC822HeaderFields]):
1900         (-[NSData _web_startsWithBlankLine]):
1901         (-[NSData _web_locationAfterFirstBlankLine]):
1902         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1903           type to Objective-C++.  This fixes the warnings about
1904           discarding the `const` modifier when casing from CFStringRef
1905           to NSString * because in older clang versions, -Wcast-qual was
1906           completely broken when compiling C++ and Objective-C++ source
1907           files.  In newer clang versions, discarding the `const`
1908           modifier for toll-free bridged types is ignored when compiling
1909           Objective-C++ source.
1910         - Update copyright and license header.
1911         - Use reinterpret_cast<> and static_cast<> to fix warnings
1912           unrelated to (NSString *) C-style casts.
1913         - Replace use of MIN() macro with std::min<> template functions.
1914         - Fix location of `*` for local variables modified above.
1915         * Plugins/Hosted/NetscapePluginHostManager.mm:
1916         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1917         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1918         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1919         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1920           warnings.
1921         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1922         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1923         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1924           to fix warning.
1925         * Plugins/Hosted/ProxyInstance.mm:
1926         (WebKit::ProxyInstance::invoke):
1927         - Use static_cast<char*>(const_cast<void*>()) to fix
1928           warning when using -[NSData bytes].
1929         (WebKit::ProxyInstance::fieldValue const):
1930         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1931           to fix warning when using CFDataGetBytePtr().
1932         * Plugins/Hosted/WebTextInputWindowController.m:
1933         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1934         - Use #pragma to ignore -Wcast-qual warning since there
1935           is not a good way to avoid this warning in Objective-C.
1936         * Plugins/WebNetscapePluginStream.mm:
1937         (WebNetscapePluginStream::deliverData):
1938         - Use const_cast<void*>() to fix warning when using
1939           -[NSData bytes].
1940         * Plugins/WebNetscapePluginView.mm:
1941         (-[WebNetscapePluginView _createPlugin]):
1942         - Change C-style cast to const_cast<char*>() to fix
1943           warning.
1944         * WebCoreSupport/WebChromeClient.mm:
1945         (WebChromeClient::wrapCryptoKey const):
1946         (WebChromeClient::unwrapCryptoKey const):
1947         - Change C-style cast to
1948           static_cast<uint8_t*>(const_cast<void*>() to fix
1949           warning.
1950         * WebView/WebPDFView.mm:
1951         (_applicationInfoForMIMEType):
1952         - Change local variable type from 'NSURL *' to
1953           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1954           when calling -[NSURL path].
1955
1956 2018-01-05  Dan Bernstein  <mitz@apple.com>
1957
1958         Fixed the build following AppKit API deprecations in a recent SDKs
1959
1960         * WebView/WebFullScreenController.mm:
1961         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1962         (-[WebFullScreenController exitFullScreen]): Ditto.
1963         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1964         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1965         * WebView/WebHTMLView.mm:
1966         (-[WebHTMLView drawRect:]): Ditto.
1967         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1968         (-[WebHTMLView knowsPageRange:]): Ditto.
1969         * WebView/WebView.mm:
1970         (LayerFlushController::flushLayers): Ditto.
1971
1972 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1973
1974         [Attachment Support] Create attachment elements when dropping files on iOS
1975         https://bugs.webkit.org/show_bug.cgi?id=181192
1976         <rdar://problem/36280945>
1977
1978         Reviewed by Tim Horton.
1979
1980         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1981
1982         * WebCoreSupport/WebPlatformStrategies.h:
1983         * WebCoreSupport/WebPlatformStrategies.mm:
1984         (WebPlatformStrategies::informationForItemAtIndex):
1985         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1986
1987 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1988
1989         [Attachment Support] Add plumbing for starting a drag with promised blob data
1990         https://bugs.webkit.org/show_bug.cgi?id=181201
1991
1992         Reviewed by Tim Horton.
1993
1994         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1995
1996         * WebCoreSupport/WebDragClient.h:
1997
1998 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1999
2000         Add a WebAuthentication runtime feature flag
2001         https://bugs.webkit.org/show_bug.cgi?id=181220
2002         <rdar://problem/36055305>
2003
2004         Reviewed by Brent Fulgham.
2005
2006         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2007
2008         * WebView/WebPreferenceKeysPrivate.h:
2009         * WebView/WebPreferences.mm:
2010         (+[WebPreferences initialize]):
2011         (-[WebPreferences webAuthenticationEnabled]):
2012         (-[WebPreferences setWebAuthenticationEnabled:]):
2013         (-[WebPreferences credentialManagementEnabled]): Deleted.
2014         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
2015         * WebView/WebPreferencesPrivate.h:
2016         * WebView/WebView.mm:
2017         (-[WebView _preferencesChanged:]):
2018
2019 2017-12-22  Jeff Miller  <jeffm@apple.com>
2020
2021         Update user-visible copyright strings to include 2018
2022         https://bugs.webkit.org/show_bug.cgi?id=181141
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * Info.plist:
2027
2028 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2029
2030         [Attachment Support] Remove current macOS support for dragging file-backed attachments
2031         https://bugs.webkit.org/show_bug.cgi?id=181188
2032
2033         Reviewed by Dan Bernstein.
2034
2035         See WebCore/ChangeLog for more detail.
2036
2037         * WebCoreSupport/WebDragClient.h:
2038         * WebCoreSupport/WebDragClient.mm:
2039         (WebDragClient::declareAndWriteAttachment): Deleted.
2040         * WebView/WebHTMLView.mm:
2041         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2042
2043 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2044
2045         Unreviewed, continue to fix build failures due to AppKit API deprecation
2046
2047         Wraps more code in -Wdeprecated-declarations.
2048
2049         * Carbon/HIWebView.mm:
2050         (overrideCGContext):
2051
2052 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2053
2054         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
2055
2056         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
2057
2058         * Carbon/CarbonWindowAdapter.mm:
2059         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2060         * Plugins/WebNetscapePluginView.mm:
2061         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2062         (-[WebNetscapePluginView sendDrawRectEvent:]):
2063         (-[WebNetscapePluginView drawRect:]):
2064
2065 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2066
2067         Fix build failures due to using deprecated AppKit symbols
2068         https://bugs.webkit.org/show_bug.cgi?id=181110
2069         <rdar://problem/36162865>
2070
2071         Reviewed by Dan Bernstein and Tim Horton.
2072
2073         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
2074
2075         * Misc/WebKitNSStringExtras.mm:
2076         (-[NSString _web_drawAtPoint:font:textColor:]):
2077         * Misc/WebNSPasteboardExtras.h:
2078         * Misc/WebNSPasteboardExtras.mm:
2079         (+[NSPasteboard _web_writableTypesForURL]):
2080         (_createWritableTypesForImageWithoutArchive):
2081         (_createWritableTypesForImageWithArchive):
2082         (+[NSPasteboard _web_dragTypesForURL]):
2083         (-[NSPasteboard _web_bestURL]):
2084         (-[NSPasteboard _web_writeURL:andTitle:types:]):
2085         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2086         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
2087         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
2088         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2089         * Panels/WebAuthenticationPanel.m:
2090         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
2091         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
2092         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2093         (-[WebHostedNetscapePluginView drawRect:]):
2094         * WebInspector/WebNodeHighlightView.mm:
2095         (-[WebNodeHighlightView drawRect:]):
2096         * WebView/WebFrame.mm:
2097         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2098         (-[WebFrame _drawRect:contentsOnly:]):
2099         * WebView/WebHTMLView.mm:
2100         (kit):
2101         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
2102         (-[WebHTMLView _plainTextFromPasteboard:]):
2103         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2104         (+[WebHTMLView _insertablePasteboardTypes]):
2105         (+[WebHTMLView _selectionPasteboardTypes]):
2106         (-[WebHTMLView pasteboard:provideDataForType:]):
2107         (-[WebHTMLView _writeSelectionToPasteboard:]):
2108         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2109         (-[WebHTMLView validRequestorForSendType:returnType:]):
2110         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2111         (createMenuItem):
2112         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2113         (-[WebHTMLView _colorAsString:]):
2114         (-[WebHTMLView copyFont:]):
2115         * WebView/WebPDFView.mm:
2116         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2117         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2118         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2119         (-[WebPDFView pasteboardTypesForSelection]):
2120         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
2121         * WebView/WebView.h:
2122         * WebView/WebView.mm:
2123         (-[WebView performDragOperation:]):
2124         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
2125         (-[WebView _searchWithGoogleFromMenu:]):
2126
2127 2017-12-21  Youenn Fablet  <youenn@apple.com>
2128
2129         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
2130         https://bugs.webkit.org/show_bug.cgi?id=181000
2131
2132         Reviewed by Chris Dumez.
2133
2134         * Misc/WebCache.mm:
2135         (+[WebCache addImageToCache:forURL:forFrame:]):
2136
2137 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2138
2139         Update FULLSCREEN_API feature defines.
2140         https://bugs.webkit.org/show_bug.cgi?id=181015
2141
2142         Reviewed by Tim Horton.
2143
2144         Change enabled iphone sdk for FULLSCREEN_API.
2145
2146         * Configurations/FeatureDefines.xcconfig:
2147
2148 2017-12-21  Jer Noble  <jer.noble@apple.com>
2149
2150         Add initial DOM support for Media Capabilities
2151         https://bugs.webkit.org/show_bug.cgi?id=181064
2152
2153         Reviewed by Eric Carlson.
2154
2155         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
2156
2157         * WebView/WebPreferenceKeysPrivate.h:
2158         * WebView/WebPreferences.mm:
2159         (+[WebPreferences initialize]):
2160         (-[WebPreferences mediaCapabilitiesEnabled]):
2161         (-[WebPreferences setMediaCapabilitiesEnabled:]):
2162         * WebView/WebPreferencesPrivate.h:
2163         * WebView/WebView.mm:
2164         (-[WebView _preferencesChanged:]):
2165
2166 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2167
2168         Enable picture-in-picture from inline element on suspend.
2169         https://bugs.webkit.org/show_bug.cgi?id=180942
2170         rdar://problem/34745234
2171
2172         Reviewed by Jer Noble.
2173
2174         Update signature of enterVideoFullscreenForVideoElement().
2175
2176         * WebCoreSupport/WebChromeClient.h:
2177         * WebCoreSupport/WebChromeClient.mm:
2178         (WebChromeClient::enterVideoFullscreenForVideoElement):
2179
2180 2017-12-20  Daniel Bates  <dabates@apple.com>
2181
2182         Remove Alternative Presentation Button
2183         https://bugs.webkit.org/show_bug.cgi?id=180500
2184         <rdar://problem/35891047>
2185
2186         Reviewed by Simon Fraser.
2187
2188         We no longer need the alternative presentation button.
2189
2190         * Configurations/FeatureDefines.xcconfig:
2191
2192 2017-12-19  Jer Noble  <jer.noble@apple.com>
2193
2194         Playing media elements which call "pause(); play()" will have the play promise rejected.
2195         https://bugs.webkit.org/show_bug.cgi?id=180781
2196         <rdar://problem/33191377>
2197
2198         Reviewed by Eric Carlson.
2199
2200         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
2201
2202         * WebView/WebView.mm:
2203         (shouldRequireUserGestureToLoadVideo):
2204
2205 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2206
2207         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
2208         https://bugs.webkit.org/show_bug.cgi?id=180977
2209
2210         Reviewed by Tim Horton.
2211
2212         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
2213         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
2214         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
2215
2216         * WebCoreSupport/WebEditorClient.mm:
2217         (attributesForAttributedStringConversion):
2218         * WebView/WebHTMLView.mm:
2219         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2220
2221 2017-12-18  David Kilzer  <ddkilzer@apple.com>
2222
2223         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
2224
2225         Attempt to fix the following warnings:
2226
2227             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
2228
2229         For the following instance variables:
2230
2231             _borderView
2232             _contentView
2233             _frame
2234             _wFlags
2235
2236         * Carbon/CarbonWindowAdapter.mm:
2237         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2238         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2239         (-[CarbonWindowAdapter _termWindowIfOwner]):
2240         (-[CarbonWindowAdapter _windowMovedToRect:]):
2241         (-[CarbonWindowAdapter setContentView:]):
2242         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2243         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2244
2245 2017-12-16  Dan Bernstein  <mitz@apple.com>
2246
2247         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
2248         https://bugs.webkit.org/show_bug.cgi?id=180613
2249         <rdar://problem/35946124>
2250
2251         Reviewed by Geoff Garen.
2252
2253         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
2254           clients.
2255         * WebView/WebDynamicScrollBarsView.h: Ditto.
2256         * WebView/WebDynamicScrollBarsView.mm: Ditto.
2257
2258 2017-12-14  David Kilzer  <ddkilzer@apple.com>
2259
2260         Enable -Wstrict-prototypes for WebKit
2261         <https://webkit.org/b/180757>
2262         <rdar://problem/36024132>
2263
2264         Rubber-stamped by Joseph Pecoraro.
2265
2266         * Configurations/Base.xcconfig:
2267         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
2268
2269 2017-12-14  John Wilander  <wilander@apple.com>
2270
2271         Storage Access API: Implement frame-specific access in the document.cookie layer
2272         https://bugs.webkit.org/show_bug.cgi?id=180682
2273         <rdar://problem/35982257>
2274
2275         Reviewed by Alex Christensen.
2276
2277         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2278         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2279         CookiesStrategy::getRawCookies() now take optional parameters for
2280         frameID and pageID to allow frame-specific scoping of cookies.
2281
2282         This change makes the return values of FrameLoaderClient::frameID()
2283         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2284         WebCore can call those getters and get the right return values in
2285         WebKit and std:nullopt in WebKitLegacy.
2286
2287         * WebCoreSupport/WebFrameLoaderClient.h:
2288         * WebCoreSupport/WebFrameLoaderClient.mm:
2289         (WebFrameLoaderClient::pageID const):
2290         (WebFrameLoaderClient::frameID const):
2291         * WebCoreSupport/WebPlatformStrategies.h:
2292         * WebCoreSupport/WebPlatformStrategies.mm:
2293         (WebPlatformStrategies::cookiesForDOM):
2294         (WebPlatformStrategies::setCookiesFromDOM):
2295         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2296         (WebPlatformStrategies::getRawCookies):
2297
2298 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
2299
2300         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
2301         https://bugs.webkit.org/show_bug.cgi?id=180689
2302
2303         Reviewed by Tim Horton.
2304
2305         Use sRGBColorSpaceRef() from WebCore.
2306
2307         * WebView/WebHTMLView.mm:
2308         (imageFromRect):
2309
2310 2017-12-11  Tim Horton  <timothy_horton@apple.com>
2311
2312         Stop using deprecated target conditional for simulator builds
2313         https://bugs.webkit.org/show_bug.cgi?id=180662
2314         <rdar://problem/35136156>
2315
2316         Reviewed by Simon Fraser.
2317
2318         * postprocess-headers.sh:
2319
2320 2017-12-11  David Quesada  <david_quesada@apple.com>
2321
2322         Turn on ENABLE_APPLICATION_MANIFEST
2323         https://bugs.webkit.org/show_bug.cgi?id=180562
2324         rdar://problem/35924737
2325
2326         Reviewed by Geoffrey Garen.
2327
2328         * Configurations/FeatureDefines.xcconfig:
2329
2330 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2331
2332         Remove pthread_once in favor of dispatch_once
2333         https://bugs.webkit.org/show_bug.cgi?id=180591
2334
2335         Reviewed by Saam Barati.
2336
2337         * Misc/WebKitErrors.m:
2338         (+[NSError _registerWebKitErrors]):
2339         (registerErrors): Deleted.
2340         * Storage/WebStorageManager.mm:
2341         (+[WebStorageManager _storageDirectoryPath]):
2342         (initializeLocalStoragePath): Deleted.
2343
2344 2017-12-07  Darin Adler  <darin@apple.com>
2345
2346         Remove some unused code from WebKitLegacy
2347         https://bugs.webkit.org/show_bug.cgi?id=180567
2348
2349         Reviewed by Anders Carlsson.
2350
2351         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
2352         macOS (back a few versions) and iOS and removed unused
2353         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
2354         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
2355         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
2356         _webkit_stringByCollapsingNonPrintingCharacters,
2357         _webkit_stringByCollapsingWhitespaceCharacters,
2358         _web_stringWithData:textEncodingName:, and
2359         _webkit_localStorageDirectoryWithBundleIdentifier:.
2360
2361         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
2362         this source file.
2363         (canUseFastRenderer): Made this faster by not calling u_charDirection for
2364         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
2365         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
2366         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
2367         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
2368         handle font smoothing options.
2369         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
2370         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
2371         from header and made it a little clearer.
2372         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
2373         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
2374         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
2375         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
2376         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
2377         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
2378         implementation a bit and used whole words instead of abbreviations.
2379         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
2380
2381         * Misc/WebNSFileManagerExtras.mm:
2382         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
2383         filenameByFixingIllegalCharacters function from WebCore directly instead of
2384         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
2385
2386         * Plugins/WebBaseNetscapePluginView.mm:
2387         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
2388         string replacements instead of _web_stringByStrippingReturnCharacters
2389         and to use NSString methods instead of CFString functions.
2390
2391 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
2392
2393         Ignore deprecation warnings.
2394
2395         * WebView/WebHTMLView.mm:
2396         (-[NSWindow _web_borderView]):
2397         (-[WebHTMLView _setAsideSubviews]):
2398         * WebView/WebView.mm:
2399         (-[WebView encodeWithCoder:]):
2400
2401 2017-12-02  Darin Adler  <darin@apple.com>
2402
2403         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
2404         https://bugs.webkit.org/show_bug.cgi?id=180009
2405
2406         Reviewed by Alex Christensen.
2407
2408         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
2409
2410         * Plugins/WebBaseNetscapePluginView.mm:
2411         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
2412         of strcasecmp.
2413
2414         * WebView/WebPreferences.mm:
2415         (contains): Ditto. Also made this a template so it's easier to call on an array.
2416         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
2417
2418 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
2419
2420         Limit user agent versioning to an upper bound
2421         https://bugs.webkit.org/show_bug.cgi?id=180365
2422         <rdar://problem/34550617>
2423
2424         Reviewed by Joseph Pecoraro.
2425
2426         * WebView/WebView.mm:
2427         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
2428         creating the User Agent string.
2429         (webKitBundleVersionString): Deleted.
2430
2431 2017-12-05  Andy Estes  <aestes@apple.com>
2432
2433         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
2434         https://bugs.webkit.org/show_bug.cgi?id=180457
2435         <rdar://problem/35143007>
2436
2437         Reviewed by Tim Horton.
2438
2439         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2440         check for this macro during post-processing.
2441
2442         * postprocess-headers.sh:
2443
2444 2017-12-04  David Quesada  <david_quesada@apple.com>
2445
2446         Add a class for parsing application manifests
2447         https://bugs.webkit.org/show_bug.cgi?id=177973
2448         rdar://problem/34747949
2449
2450         Reviewed by Geoffrey Garen.
2451
2452         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2453
2454 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2455
2456         Make LegacyCustomProtocolManager optional for network process
2457         https://bugs.webkit.org/show_bug.cgi?id=176230
2458
2459         Reviewed by Alex Christensen.
2460
2461         * Configurations/FeatureDefines.xcconfig:
2462
2463 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2464
2465         Fix some NSOperationQueue leaks
2466         https://bugs.webkit.org/show_bug.cgi?id=180221
2467
2468         Reviewed by Wenson Hsieh.
2469
2470         * WebView/WebView.mm:
2471         (-[WebView performDragOperation:]):
2472
2473 2017-11-30  Darin Adler  <darin@apple.com>
2474
2475         [Mac] remove unneeded RetainPtr use introduced in r225142
2476         https://bugs.webkit.org/show_bug.cgi?id=180202
2477
2478         Reviewed by Tim Horton.
2479
2480         * WebView/WebImmediateActionController.mm:
2481         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2482         RetainPtr.
2483
2484 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2485
2486         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2487         https://bugs.webkit.org/show_bug.cgi?id=175595
2488
2489         Reviewed by Darin Adler.
2490
2491         * WebView/WebPreferences.mm:
2492
2493 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2494
2495         One too many zeroes in macOS version number in FeatureDefines
2496         https://bugs.webkit.org/show_bug.cgi?id=180011
2497
2498         Reviewed by Dan Bernstein.
2499
2500         * Configurations/FeatureDefines.xcconfig:
2501
2502 2017-11-23  Darin Adler  <darin@apple.com>
2503
2504         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2505         https://bugs.webkit.org/show_bug.cgi?id=179981
2506
2507         Reviewed by Sam Weinig.
2508
2509         * WebView/WebImmediateActionController.mm:
2510         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2511         * WebView/WebView.mm:
2512         (coreOptions): Use |= instead of | to build up FindOptions.
2513
2514 2017-11-23  Sam Weinig  <sam@webkit.org>
2515
2516         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2517         https://bugs.webkit.org/show_bug.cgi?id=179954
2518
2519         Reviewed by Darin Adler.
2520
2521         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2522         with direct calls to the corresponding UserGestureIndicator functions.
2523
2524         * Plugins/WebPluginController.mm:
2525         (-[WebPluginController processingUserGesture]):
2526         * WebView/WebView.mm:
2527         (-[WebView _isProcessingUserGesture]):
2528
2529 2017-11-23  Darin Adler  <darin@apple.com>
2530
2531         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2532         https://bugs.webkit.org/show_bug.cgi?id=179907
2533
2534         Reviewed by Sam Weinig.
2535
2536         * History/BinaryPropertyList.cpp:
2537         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2538         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2539         * WebView/WebHTMLRepresentation.mm:
2540         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2541         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2542
2543 2017-11-22  Ali Juma  <ajuma@chromium.org>
2544
2545         Implement VisualViewport API attributes
2546         https://bugs.webkit.org/show_bug.cgi?id=179385
2547
2548         Reviewed by Frédéric Wang.
2549
2550         Add a VisualViewportAPI preference.
2551
2552         * WebView/WebPreferenceKeysPrivate.h:
2553         * WebView/WebPreferences.mm:
2554         (+[WebPreferences initialize]):
2555         (-[WebPreferences visualViewportAPIEnabled]):
2556         (-[WebPreferences setVisualViewportAPIEnabled:]):
2557         * WebView/WebPreferencesPrivate.h:
2558         * WebView/WebView.mm:
2559         (-[WebView _preferencesChanged:]):
2560
2561 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2562
2563         WebCoreObjCExtras.h is being included in too many places
2564         https://bugs.webkit.org/show_bug.cgi?id=179931
2565
2566         Reviewed by Darin Adler.
2567
2568         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2569         * Plugins/WebBaseNetscapePluginView.mm:
2570         * Plugins/WebBasePluginPackage.mm:
2571         * Plugins/WebNetscapePluginStream.mm:
2572         * Plugins/WebNetscapePluginView.mm:
2573         * WebView/WebTextIterator.mm:
2574         * WebView/WebViewData.mm:
2575
2576 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2577
2578         Unreviewed, rolling out r225093.
2579         https://bugs.webkit.org/show_bug.cgi?id=179938
2580
2581         Compilation failed on WinCairo 64-bit Release (Requested by
2582         fredw on #webkit).
2583
2584         Reverted changeset:
2585
2586         "Implement VisualViewport API attributes"
2587         https://bugs.webkit.org/show_bug.cgi?id=179385
2588         https://trac.webkit.org/changeset/225093
2589
2590 2017-11-21  Ali Juma  <ajuma@chromium.org>
2591
2592         Implement VisualViewport API attributes
2593         https://bugs.webkit.org/show_bug.cgi?id=179385
2594
2595         Reviewed by Frédéric Wang.
2596
2597         Add a VisualViewportAPI preference.
2598
2599         * WebView/WebPreferenceKeysPrivate.h:
2600         * WebView/WebPreferences.mm:
2601         (+[WebPreferences initialize]):
2602         (-[WebPreferences visualViewportAPIEnabled]):
2603         (-[WebPreferences setVisualViewportAPIEnabled:]):
2604         * WebView/WebPreferencesPrivate.h:
2605         * WebView/WebView.mm:
2606         (-[WebView _preferencesChanged:]):
2607
2608 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2609
2610         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2611         https://bugs.webkit.org/show_bug.cgi?id=179504
2612
2613         Reviewed by Darin Adler.
2614
2615         * Misc/WebKitNSStringExtras.mm:
2616         * Plugins/Hosted/NetscapePluginHostManager.mm:
2617         * Plugins/WebBasePluginPackage.mm:
2618
2619 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2620
2621         Remove unused TOUCH_ICON_LOADING feature flag
2622         https://bugs.webkit.org/show_bug.cgi?id=179873
2623
2624         Reviewed by Simon Fraser.
2625
2626         * Configurations/FeatureDefines.xcconfig:
2627
2628 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2629
2630         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2631         https://bugs.webkit.org/show_bug.cgi?id=179872
2632
2633         Reviewed by Darin Adler.
2634
2635         * Configurations/FeatureDefines.xcconfig:
2636
2637 2017-11-16  Daniel Bates  <dabates@apple.com>
2638
2639         Add feature define for alternative presentation button element
2640         https://bugs.webkit.org/show_bug.cgi?id=179692
2641         Part of <rdar://problem/34917108>
2642
2643         Reviewed by Andy Estes.
2644
2645         Only enabled on Cocoa platforms by default.
2646
2647         * Configurations/FeatureDefines.xcconfig:
2648
2649 2017-11-14  Nan Wang  <n_wang@apple.com>
2650
2651         AX: AOM: Implement AccessibleNode class and support label and role attributes
2652         https://bugs.webkit.org/show_bug.cgi?id=179494
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         * WebView/WebPreferenceKeysPrivate.h:
2657         * WebView/WebPreferences.mm:
2658         (+[WebPreferences initialize]):
2659         (-[WebPreferences accessibilityObjectModelEnabled]):
2660         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2661         * WebView/WebPreferencesPrivate.h:
2662         * WebView/WebView.mm:
2663         (-[WebView _preferencesChanged:]):
2664
2665 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2666
2667         Remove Cocoa CFURLConnection loading code
2668         https://bugs.webkit.org/show_bug.cgi?id=179688
2669
2670         Reviewed by Antti Koivisto.
2671
2672         * Misc/WebDownload.mm:
2673         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2674         * Misc/WebDownloadInternal.h:
2675         * Plugins/WebBaseNetscapePluginView.mm:
2676         * WebCoreSupport/WebFrameLoaderClient.mm:
2677         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2678         * WebView/WebView.mm:
2679         (-[WebView scheduleInRunLoop:forMode:]):
2680         (-[WebView unscheduleFromRunLoop:forMode:]):
2681
2682 2017-11-14  Daniel Bates  <dabates@apple.com>
2683
2684         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2685         for feature defines
2686
2687         Following r195498 and r201917 the Visual Studio property files for feature defines have
2688         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2689         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2690         files.
2691
2692         * Configurations/FeatureDefines.xcconfig:
2693
2694 2017-11-14  Jer Noble  <jer.noble@apple.com>
2695
2696         Enable Modern EME tests in DumpRenderTree
2697         https://bugs.webkit.org/show_bug.cgi?id=179544
2698
2699         Reviewed by Alex Christensen.
2700
2701         Add a WebPreferences property to enable the (modern) EME API.
2702
2703         * WebView/WebPreferenceKeysPrivate.h:
2704         * WebView/WebPreferences.mm:
2705         (+[WebPreferences initialize]):
2706         (-[WebPreferences encryptedMediaAPIEnabled]):
2707         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2708         * WebView/WebPreferencesPrivate.h:
2709         * WebView/WebView.mm:
2710         (-[WebView _preferencesChanged:]):
2711
2712 2017-11-14  Antti Koivisto  <antti@apple.com>
2713
2714         Enable display:contents by default
2715         https://bugs.webkit.org/show_bug.cgi?id=179655
2716
2717         Reviewed by Sam Weinig.
2718
2719         * WebView/WebPreferences.mm:
2720         (+[WebPreferences initialize]):
2721
2722 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2723
2724         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2725         https://bugs.webkit.org/show_bug.cgi?id=178751
2726
2727         Reviewed by Brady Eidson.
2728
2729         * WebCoreSupport/WebFrameNetworkingContext.mm:
2730         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2731
2732 2017-11-08  Keith Miller  <keith_miller@apple.com>
2733
2734         Async iteration should only fetch the next method once and add feature flag
2735         https://bugs.webkit.org/show_bug.cgi?id=179451
2736
2737         Reviewed by Geoffrey Garen.
2738
2739         Add feature flag for Async iteration.
2740
2741         * Configurations/FeatureDefines.xcconfig:
2742
2743 2017-11-13  Mark Lam  <mark.lam@apple.com>
2744
2745         Add more overflow check book-keeping for MarkedArgumentBuffer.
2746         https://bugs.webkit.org/show_bug.cgi?id=179634
2747         <rdar://problem/35492517>
2748
2749         Reviewed by Saam Barati.
2750
2751         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2752         (WebKit::NetscapePluginInstanceProxy::invoke):
2753         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2754         (WebKit::NetscapePluginInstanceProxy::construct):
2755
2756 2017-11-12  Darin Adler  <darin@apple.com>
2757
2758         More is<> and downcast<>, less static_cast<>
2759         https://bugs.webkit.org/show_bug.cgi?id=179600
2760
2761         Reviewed by Chris Dumez.
2762
2763         * DOM/DOM.mm:
2764         (kit): Use is/downcast.
2765         * WebCoreSupport/WebEditorClient.mm:
2766         (WebEditorClient::handleKeyboardEvent): Ditto.
2767         (WebEditorClient::handleInputMethodKeydown): Ditto.
2768         * WebView/WebHTMLView.mm:
2769         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2770
2771 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2772
2773         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2774         https://bugs.webkit.org/show_bug.cgi?id=179397
2775
2776         Reviewed by Wenson Hsieh.
2777
2778         * DOM/DOMHTMLInputElement.mm:
2779         (-[DOMHTMLInputElement insertTextSuggestion:]):
2780
2781 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2782
2783         HTMLMediaElement should not use element fullscreen on iOS
2784         https://bugs.webkit.org/show_bug.cgi?id=179418
2785         rdar://problem/35409277
2786
2787         Reviewed by Eric Carlson.
2788
2789         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2790
2791         * Configurations/FeatureDefines.xcconfig:
2792
2793 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2794
2795         Make ResourceLoader::willSendRequestInternal asynchronous
2796         https://bugs.webkit.org/show_bug.cgi?id=179251
2797
2798         Reviewed by Andy Estes.
2799
2800         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2801         (WebKit::HostedNetscapePluginStream::start):
2802         * Plugins/WebNetscapePluginStream.mm:
2803         (WebNetscapePluginStream::start):
2804
2805 2017-11-01  Darin Adler  <darin@apple.com>
2806
2807         Simplify event dispatch code and make it a bit more consistent
2808         https://bugs.webkit.org/show_bug.cgi?id=178991
2809
2810         Reviewed by Chris Dumez.
2811
2812         * DOM/DOMEvent.mm:
2813         (-[DOMEvent srcElement]): Call target instead of srcElement.
2814
2815 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2816
2817         [Touch Bar Web API] Add support for menuitem tag
2818         https://bugs.webkit.org/show_bug.cgi?id=179020
2819
2820         Reviewed by Ryosuke Niwa.
2821
2822         Adds in properties and methods that allow the menuitem runtime feature
2823         to be enabled or disabled.
2824
2825         * WebView/WebPreferenceKeysPrivate.h:
2826         * WebView/WebPreferences.mm:
2827         (-[WebPreferences menuItemElementEnabled]):
2828         (-[WebPreferences setMenuItemElementEnabled:]):
2829         * WebView/WebPreferencesPrivate.h:
2830         * WebView/WebView.mm:
2831         (-[WebView _preferencesChanged:]):
2832
2833 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2834
2835         Use CompletionHandlers for redirects
2836         https://bugs.webkit.org/show_bug.cgi?id=179163
2837
2838         Reviewed by Tim Horton.
2839
2840         * Plugins/Hosted/HostedNetscapePluginStream.h:
2841         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2842         (WebKit::HostedNetscapePluginStream::willSendRequest):
2843         * Plugins/WebNetscapePluginStream.h:
2844         * Plugins/WebNetscapePluginStream.mm:
2845         (WebNetscapePluginStream::willSendRequest):
2846
2847 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2848
2849         Add a FileSystem namespace to FileSystem.cpp
2850         https://bugs.webkit.org/show_bug.cgi?id=179063
2851
2852         Reviewed by Darin Adler.
2853
2854         * Misc/WebNSFileManagerExtras.mm:
2855         * Storage/WebDatabaseProvider.mm:
2856
2857 2017-11-02  Frederic Wang  <fwang@igalia.com>
2858
2859         Add references to bug 179167 in FIXME comments
2860         https://bugs.webkit.org/show_bug.cgi?id=179168
2861
2862         Reviewed by Daniel Bates.
2863
2864         * Configurations/FeatureDefines.xcconfig:
2865
2866 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2867
2868         Implement WKFullscreenWindowController for iOS.
2869         https://bugs.webkit.org/show_bug.cgi?id=178924
2870         rdar://problem/34697120
2871
2872         Reviewed by Simon Fraser.
2873
2874         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2875
2876         * Configurations/FeatureDefines.xcconfig:
2877         * WebView/WebView.mm:
2878         (-[WebView fullScreenPlaceholderView]):
2879
2880 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2881
2882         Clean up some drag and drop feature flags
2883         https://bugs.webkit.org/show_bug.cgi?id=179082
2884
2885         Reviewed by Simon Fraser.
2886
2887         * Configurations/FeatureDefines.xcconfig:
2888
2889 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2890
2891         Make it possible to test rubber-banding in overflow scroll
2892         https://bugs.webkit.org/show_bug.cgi?id=179078
2893
2894         Reviewed by Sam Weinig.
2895
2896         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2897         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2898
2899         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2900         functions, since most callers want clamped.
2901
2902         * DOM/DOMHTML.mm:
2903         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2904
2905 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2906
2907         Fix up some content filtering feature flags
2908         https://bugs.webkit.org/show_bug.cgi?id=179079
2909
2910         Reviewed by Simon Fraser.
2911
2912         * Configurations/FeatureDefines.xcconfig:
2913
2914 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2915
2916         [FrameView::layout cleanup] Move core layout logic to a separate class.
2917         https://bugs.webkit.org/show_bug.cgi?id=178771
2918         <rdar://problem/35166542>
2919
2920         Reviewed by Simon Fraser.
2921
2922         Move layout code out from FrameView to LayoutContext.
2923
2924         * WebView/WebClipView.mm:
2925         (-[WebClipView _immediateScrollToPoint:]):
2926         * WebView/WebFrame.mm:
2927         (-[WebFrame layoutCount]):
2928
2929 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2930
2931         Fix issues with WebView subframe painting
2932         https://bugs.webkit.org/show_bug.cgi?id=178842
2933         rdar://problem/34072253
2934
2935         Reviewed by Daniel Bates.
2936         
2937         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2938         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2939         High Sierra, so match the new signature.
2940
2941         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2942
2943         * WebView/WebHTMLView.mm:
2944         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2945         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2946
2947 2017-10-25  Youenn Fablet  <youenn@apple.com>
2948
2949         Enable ServiceWorker to fetch resources
2950         https://bugs.webkit.org/show_bug.cgi?id=178673
2951
2952         Reviewed by Brady Eidson.
2953
2954         * WebCoreSupport/WebFrameLoaderClient.mm:
2955         (WebFrameLoaderClient::pageID const):
2956         (WebFrameLoaderClient::frameID const):
2957         (WebFrameLoaderClient::sessionID const):
2958
2959         Added implementation to the new getters.
2960         They are noop in the context of WK1.
2961
2962 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2963
2964         Web Inspector: Enable WebKit logging configuration and display
2965         https://bugs.webkit.org/show_bug.cgi?id=177027
2966         <rdar://problem/33964767>
2967
2968         Reviewed by Joseph Pecoraro.
2969
2970         * WebCoreSupport/WebChromeClient.mm:
2971         (stringForMessageSource): Deal with Media and WebRTC message sources.
2972
2973 2017-10-20  Antoine Quint  <graouts@apple.com>
2974
2975         [Web Animations] Provide basic timeline and animation interfaces
2976         https://bugs.webkit.org/show_bug.cgi?id=178526
2977
2978         Reviewed by Dean Jackson.
2979
2980         Remove the WEB_ANIMATIONS compile-time flag.
2981
2982         * Configurations/FeatureDefines.xcconfig:
2983         * WebView/WebPreferences.mm:
2984         (+[WebPreferences initialize]):
2985         * WebView/WebView.mm:
2986         (-[WebView _preferencesChanged:]):
2987
2988 2017-10-19  Sam Weinig  <sam@webkit.org>
2989
2990         [Settings] Move global settings into their own file
2991         https://bugs.webkit.org/show_bug.cgi?id=178512
2992
2993         Reviewed by Darin Adler.
2994
2995         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2996
2997         * WebCoreSupport/WebChromeClient.mm:
2998         (WebChromeClient::supportsVideoFullscreen):
2999         * WebView/WebDynamicScrollBarsView.mm:
3000         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
3001         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
3002         * WebView/WebPreferences.mm:
3003         (+[WebPreferences initialize]):
3004         * WebView/WebView.mm:
3005         (-[WebView _commonInitializationWithFrameName:groupName:]):
3006         (-[WebView _preferencesChanged:]):
3007         (+[WebView _doNotStartObservingNetworkReachability]):
3008
3009 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3010
3011         Replace some stack raw pointers with RefPtrs within WebCore/html
3012         https://bugs.webkit.org/show_bug.cgi?id=178201
3013         <rdar://problem/34841692>
3014
3015         Reviewed by Ryosuke Niwa.
3016
3017         * DOM/DOM.mm:
3018         (kit):
3019         Change the type of node as toNode() is changed to return RefPtr.
3020
3021 2017-10-18  Chris Dumez  <cdumez@apple.com>
3022
3023         [Service Worker] Add stubs for Client / WindowClient / Clients
3024         https://bugs.webkit.org/show_bug.cgi?id=178469
3025
3026         Reviewed by Youenn Fablet.
3027
3028         Rename PageVisiblityState to VisibilityState.
3029
3030         * WebView/WebView.mm:
3031         (kit):
3032
3033 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3034
3035         Unreviewed, rolling out r223291.
3036
3037         See WebCore ChangeLog for more detail.
3038
3039         Reverted changeset:
3040
3041         "Remove Editor::simplifyMarkup"
3042         https://bugs.webkit.org/show_bug.cgi?id=178271
3043         https://trac.webkit.org/changeset/223291
3044
3045 2017-10-17  Keith Miller  <keith_miller@apple.com>
3046
3047         Change WebCore sources to work with unified source builds
3048         https://bugs.webkit.org/show_bug.cgi?id=178229
3049
3050         Rubber stamped by Tim Horton.
3051
3052         * Configurations/FeatureDefines.xcconfig:
3053
3054 2017-10-16  Sam Weinig  <sam@webkit.org>
3055
3056         [Settings] Remove all custom code from Settings.h/cpp
3057         https://bugs.webkit.org/show_bug.cgi?id=178330
3058
3059         Reviewed by Simon Fraser.
3060
3061         * WebView/WebPreferences.mm:
3062         (+[WebPreferences initialize]):
3063         
3064             Update for naming changes of FrameFlattening now that it is an enum class.
3065
3066 2017-10-13  Alex Christensen  <achristensen@webkit.org>
3067
3068         Remove Editor::simplifyMarkup
3069         https://bugs.webkit.org/show_bug.cgi?id=178271
3070
3071         Reviewed by Wenson Hsieh.
3072
3073         * WebView/WebView.mm:
3074         (-[WebView _simplifyMarkup:endNode:]):
3075
3076 2017-10-12  Chris Dumez  <cdumez@apple.com>
3077
3078         [Mac] Add support for MouseEvent.buttons
3079         https://bugs.webkit.org/show_bug.cgi?id=178214
3080
3081         Reviewed by Ryosuke Niwa.
3082
3083         * WebView/WebPDFView.mm:
3084         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3085
3086 2017-10-11  Sam Weinig  <sam@webkit.org>
3087
3088         Remove out-parameter variants of copyToVector
3089         https://bugs.webkit.org/show_bug.cgi?id=178155
3090
3091         Reviewed by Tim Horton.
3092
3093         * Plugins/WebNetscapePluginView.mm:
3094         (-[WebNetscapePluginView destroyPlugin]):
3095         * WebView/WebHTMLRepresentation.mm:
3096         (newArrayWithStrings):
3097
3098             Replace out-parameter based copyToVector, with one that returns a Vector.
3099
3100 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
3101
3102         Sanitize URL in pasteboard for other applications and cross origin content
3103         https://bugs.webkit.org/show_bug.cgi?id=178060
3104         <rdar://problem/34874518>
3105
3106         Reviewed by Wenson Hsieh.
3107
3108         * WebCoreSupport/WebPlatformStrategies.h:
3109         * WebCoreSupport/WebPlatformStrategies.mm:
3110         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
3111
3112 2017-10-11  Chris Dumez  <cdumez@apple.com>
3113
3114         Modernize Geolocation code
3115         https://bugs.webkit.org/show_bug.cgi?id=178148
3116
3117         Reviewed by Ryosuke Niwa.
3118
3119         * WebCoreSupport/WebGeolocationClient.h:
3120         * WebCoreSupport/WebGeolocationClient.mm:
3121         (WebGeolocationClient::lastPosition):
3122         * WebView/WebGeolocationPosition.mm:
3123         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
3124         (core):
3125         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
3126         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3127         * WebView/WebGeolocationPositionInternal.h:
3128
3129 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
3130
3131         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
3132         https://bugs.webkit.org/show_bug.cgi?id=178154
3133
3134         Reviewed by Wenson Hsieh.
3135
3136         Enable custom pasteboard data by default.
3137
3138         * WebView/WebPreferenceKeysPrivate.h:
3139         * WebView/WebPreferences.mm:
3140         (+[WebPreferences initialize]):
3141         (-[WebPreferences customPasteboardDataEnabled]): Added.
3142         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
3143         * WebView/WebPreferencesPrivate.h:
3144         * WebView/WebView.mm:
3145         (-[WebView _preferencesChanged:]):
3146
3147 2017-10-10  Sam Weinig  <sam@webkit.org>
3148
3149         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
3150         https://bugs.webkit.org/show_bug.cgi?id=178102
3151
3152         Reviewed by Tim Horton.
3153
3154         * History/WebHistory.mm:
3155         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
3156         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3157         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
3158         * WebCoreSupport/WebUserMediaClient.mm:
3159         (WebUserMediaClient::pageDestroyed):
3160
3161 2017-10-09  Robin Morisset  <rmorisset@apple.com>
3162
3163         Make the names of the options consistent
3164         https://bugs.webkit.org/show_bug.cgi?id=177933
3165
3166         Reviewed by Saam Barati.
3167
3168         * WebView/WebFrame.h:
3169         * WebView/WebHTMLView.mm:
3170         (-[WebHTMLView setMarkedText:selectedRange:]):
3171         * WebView/WebView.h:
3172
3173 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3174
3175         [iOS] Tweak support for classifying form controls (followup to r222487)
3176         https://bugs.webkit.org/show_bug.cgi?id=177917
3177         <rdar://problem/34820122>
3178
3179         Reviewed by Dean Jackson.
3180
3181         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
3182
3183         * DOM/DOMHTMLInputElement.mm:
3184         (-[DOMHTMLInputElement _autofillContext]):
3185         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
3186         (-[DOMHTMLInputElement representingPageURL]): Deleted.
3187
3188 2017-10-05  Keith Miller  <keith_miller@apple.com>
3189
3190         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
3191
3192         * Configurations/WebKitLegacy.xcconfig:
3193
3194 2017-10-05  Jer Noble  <jer.noble@apple.com>
3195
3196         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
3197         https://bugs.webkit.org/show_bug.cgi?id=177261
3198
3199         Reviewed by Eric Carlson.
3200
3201         * Configurations/FeatureDefines.xcconfig:
3202
3203 2017-10-05  Chris Dumez  <cdumez@apple.com>
3204
3205         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3206         https://bugs.webkit.org/show_bug.cgi?id=177957
3207
3208         Reviewed by Alex Christensen.
3209
3210         * WebCoreSupport/WebPlatformStrategies.h:
3211         * WebCoreSupport/WebPlatformStrategies.mm:
3212         (WebPlatformStrategies::cookiesEnabled):
3213
3214 2017-10-05  Youenn Fablet  <youenn@apple.com>
3215
3216         Make LibWebRTCProvider port agnostic
3217         https://bugs.webkit.org/show_bug.cgi?id=177747
3218
3219         Reviewed by Alex Christensen & Alex Garcia.
3220
3221         * WebView/WebView.mm:
3222         (-[WebView _commonInitializationWithFrameName:groupName:]):
3223         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3224
3225 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3226
3227         Stop linking with WebKitSystemInterface
3228         https://bugs.webkit.org/show_bug.cgi?id=177915
3229
3230         Reviewed by Antti Koivisto.
3231
3232         * Configurations/DebugRelease.xcconfig:
3233         * Configurations/WebKitLegacy.xcconfig:
3234
3235 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3236
3237         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
3238         https://bugs.webkit.org/show_bug.cgi?id=177912
3239
3240         Reviewed by Saam Barati.
3241
3242         * Carbon/CarbonUtils.m:
3243         * Carbon/CarbonWindowAdapter.mm:
3244         * Carbon/HIWebView.mm:
3245         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3246         * Misc/WebNSFileManagerExtras.mm:
3247         * Misc/WebNSPasteboardExtras.mm:
3248         * Misc/WebNSURLExtras.mm:
3249         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3250         * Plugins/Hosted/NetscapePluginHostManager.mm:
3251         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3252         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3253         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3254         * Plugins/Hosted/WebTextInputWindowController.m:
3255         * Plugins/WebBaseNetscapePluginView.mm:
3256         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3257         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3258         * Plugins/WebNetscapePluginStream.mm:
3259         * Plugins/WebNetscapePluginView.mm:
3260         * Plugins/WebPluginDatabase.mm:
3261         * WebCoreSupport/PopupMenuMac.mm:
3262         * WebCoreSupport/WebChromeClient.mm:
3263         * WebCoreSupport/WebFrameLoaderClient.mm:
3264         * WebCoreSupport/WebInspectorClient.mm:
3265         * WebCoreSupport/WebPlatformStrategies.mm:
3266         * WebCoreSupport/WebSystemInterface.mm:
3267         * WebView/WebDynamicScrollBarsView.mm:
3268         * WebView/WebFrame.mm:
3269         * WebView/WebFrameView.mm:
3270         * WebView/WebFullScreenController.mm:
3271         * WebView/WebHTMLView.mm:
3272         * WebView/WebPreferences.mm:
3273         * WebView/WebView.mm:
3274
3275 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
3276
3277         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
3278         rdar://problem/34705779
3279
3280         Addressing review comments that I somehow landed without.
3281
3282         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
3283
3284 2017-09-29  Chris Dumez  <cdumez@apple.com>
3285
3286         Split some logic out of VisitedLinkStore and make it reusable
3287         https://bugs.webkit.org/show_bug.cgi?id=177575
3288
3289         Reviewed by Alex Christensen.
3290
3291         * WebCoreSupport/WebVisitedLinkStore.h:
3292         * WebCoreSupport/WebVisitedLinkStore.mm:
3293         (WebVisitedLinkStore::addVisitedLink):
3294         (WebVisitedLinkStore::removeVisitedLink):
3295         (WebVisitedLinkStore::isLinkVisited):
3296         (WebVisitedLinkStore::addVisitedLinkHash):
3297
3298 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
3299
3300         Build fix for High Sierra 32 bit Mac
3301         https://bugs.webkit.org/show_bug.cgi?id=177551
3302         <rdar://problem/34690283>
3303
3304         Reviewed by Alexey Proskuryakov.
3305
3306         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3307         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3308         also made.
3309
3310         * Carbon/CarbonWindowAdapter.mm:
3311         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3312         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3313         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3314         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3315         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3316         (-[CarbonWindowAdapter dealloc]):
3317         (-[CarbonWindowAdapter windowRef]):
3318         (-[CarbonWindowAdapter _hasWindowRef]):
3319         (-[CarbonWindowAdapter _managesWindowRef]):
3320         (-[CarbonWindowAdapter _removeWindowRef]):
3321         (-[CarbonWindowAdapter _carbonWindowClass]):
3322         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3323         (-[CarbonWindowAdapter sendSuperEvent:]):
3324         (-[CarbonWindowAdapter relinquishFocus]):
3325         (-[CarbonWindowAdapter _cancelKey:]):
3326         (-[CarbonWindowAdapter _commonAwake]):
3327         (-[CarbonWindowAdapter _destroyRealWindow:]):
3328         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3329         (-[CarbonWindowAdapter _termWindowIfOwner]):
3330         (-[CarbonWindowAdapter _windowMovedToRect:]):
3331         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3332         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3333         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3334         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3335         (-[CarbonWindowAdapter canBecomeMainWindow]):
3336         (-[CarbonWindowAdapter encodeWithCoder:]):
3337         (-[CarbonWindowAdapter initWithCoder:]):
3338         (-[CarbonWindowAdapter setContentView:]):
3339         (-[CarbonWindowAdapter worksWhenModal]):
3340         (-[CarbonWindowAdapter _setModalWindowLevel]):
3341         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3342         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3343         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3344         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3345         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3346         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3347         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3348         (NSCarbonWindowHandleEvent):
3349         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3350         (-[CarbonWindowAdapter _growBoxRect]):
3351         * Carbon/HIWebView.mm:
3352         (HIWebViewGetWebView):
3353         (HIWebViewConstructor):
3354         (HIWebViewDestructor):
3355         (HIWebViewRegisterClass):
3356         (GetBehaviors):
3357         (Draw):
3358         (HitTest):
3359         (GetRegion):
3360         (GetWindowRef):
3361         (CreateNSEventAdoptingCGEvent):
3362         (CopyEventCGEvent):
3363         (CreateNSEventWithCarbonClickEvent):
3364         (Click):
3365         (CreateNSEventWithCarbonEvent):
3366         (MouseUp):
3367         (CreateNSEventWithCarbonMouseMoveEvent):
3368         (MouseMoved):
3369         (MouseDragged):
3370         (MouseWheelMoved):
3371         (ContextMenuClick):
3372         (GetKind):
3373         (BoundsChanged):
3374         (OwningWindowChanged):
3375         (WindowHandler):
3376         (SyncFrame):
3377         (SetFocusPart):
3378         (AdvanceFocus):
3379         (RelinquishFocus):
3380         (ActiveStateChanged):
3381         (ProcessCommand):
3382         (UpdateCommandStatus):
3383         (_NSSelectorForHICommand):
3384         (HIWebViewEventHandler):
3385         (StartUpdateObserver):
3386         (StopUpdateObserver):
3387         (UpdateObserver):
3388
3389 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3390
3391         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
3392         https://bugs.webkit.org/show_bug.cgi?id=172526
3393         <rdar://problem/32396081>
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
3398
3399         * WebCoreSupport/WebPlatformStrategies.h:
3400         * WebCoreSupport/WebPlatformStrategies.mm:
3401         (WebPlatformStrategies::webExposedTypes):
3402         (WebPlatformStrategies::writeCustomData):
3403
3404 2017-09-27  Matt Lewis  <jlewis3@apple.com>
3405
3406         Unreviewed, rolling out r222567.
3407
3408         This broke and internal build.
3409
3410         Reverted changeset:
3411
3412         "Build fix for High Sierra 32 bit Mac"
3413         https://bugs.webkit.org/show_bug.cgi?id=177551
3414         http://trac.webkit.org/changeset/222567
3415
3416 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
3417
3418         Build fix for High Sierra 32 bit Mac
3419         https://bugs.webkit.org/show_bug.cgi?id=177551
3420         <rdar://problem/34690283>
3421
3422         Reviewed by Alexey Proskuryakov.
3423
3424         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3425         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3426         also made.
3427
3428         * Carbon/CarbonWindowAdapter.mm:
3429         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3430         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3431         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3432         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3433         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3434         (-[CarbonWindowAdapter dealloc]):
3435         (-[CarbonWindowAdapter windowRef]):
3436         (-[CarbonWindowAdapter _hasWindowRef]):
3437         (-[CarbonWindowAdapter _managesWindowRef]):
3438         (-[CarbonWindowAdapter _removeWindowRef]):
3439         (-[CarbonWindowAdapter _carbonWindowClass]):
3440         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3441         (-[CarbonWindowAdapter sendSuperEvent:]):
3442         (-[CarbonWindowAdapter relinquishFocus]):
3443         (-[CarbonWindowAdapter _cancelKey:]):
3444         (-[CarbonWindowAdapter _commonAwake]):
3445         (-[CarbonWindowAdapter _destroyRealWindow:]):
3446         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3447         (-[CarbonWindowAdapter _termWindowIfOwner]):
3448         (-[CarbonWindowAdapter _windowMovedToRect:]):
3449         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3450         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3451         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3452         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3453         (-[CarbonWindowAdapter canBecomeMainWindow]):
3454         (-[CarbonWindowAdapter encodeWithCoder:]):
3455         (-[CarbonWindowAdapter initWithCoder:]):
3456         (-[CarbonWindowAdapter setContentView:]):
3457         (-[CarbonWindowAdapter worksWhenModal]):
3458         (-[CarbonWindowAdapter _setModalWindowLevel]):
3459         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3460         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3461         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3462         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3463         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3464         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3465         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3466         (NSCarbonWindowHandleEvent):
3467         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3468         (-[CarbonWindowAdapter _growBoxRect]):
3469         * Carbon/HIWebView.mm:
3470         (HIWebViewGetWebView):
3471         (HIWebViewConstructor):
3472         (HIWebViewDestructor):
3473         (HIWebViewRegisterClass):
3474         (GetBehaviors):
3475         (Draw):
3476         (HitTest):
3477         (GetRegion):
3478         (GetWindowRef):
3479         (CreateNSEventAdoptingCGEvent):
3480         (CopyEventCGEvent):
3481         (CreateNSEventWithCarbonClickEvent):
3482         (Click):
3483         (CreateNSEventWithCarbonEvent):
3484         (MouseUp):
3485         (CreateNSEventWithCarbonMouseMoveEvent):
3486         (MouseMoved):
3487         (MouseDragged):
3488         (MouseWheelMoved):
3489         (ContextMenuClick):
3490         (GetKind):
3491         (BoundsChanged):
3492         (OwningWindowChanged):
3493         (WindowHandler):
3494         (SyncFrame):
3495         (SetFocusPart):
3496         (AdvanceFocus):
3497         (RelinquishFocus):
3498         (ActiveStateChanged):
3499         (ProcessCommand):
3500         (UpdateCommandStatus):
3501         (_NSSelectorForHICommand):
3502         (HIWebViewEventHandler):
3503         (StartUpdateObserver):
3504         (StopUpdateObserver):
3505         (UpdateObserver):
3506
3507 2017-09-25  Alex Christensen  <achristensen@webkit.org>