315c1eaa8947c4f41b0216fadebaaefba43db760
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-08-21  Tim Horton  <timothy_horton@apple.com>
2
3         [Mail] Tapping top of message scrolls back to copied text instead of top of the message
4         https://bugs.webkit.org/show_bug.cgi?id=200999
5         <rdar://problem/54564878>
6
7         Reviewed by Wenson Hsieh.
8
9         * WebCoreSupport/WebEditorClient.h:
10         * WebCoreSupport/WebEditorClient.mm:
11         (WebEditorClient::shouldAllowSingleClickToChangeSelection const):
12         Copy the existing behavior from EventHandler.
13         We do not fix the bug in WebKitLegacy for a multitude of reasons, primarily
14         because we do not know of any user impact.
15
16 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
17
18         Put keygen element behind a runtime flag and disable it by default
19         https://bugs.webkit.org/show_bug.cgi?id=200850
20
21         Reviewed by Antti Koivisto.
22
23         * WebView/WebPreferenceKeysPrivate.h:
24         * WebView/WebPreferences.mm:
25         (-[WebPreferences keygenElementEnabled]):
26         (-[WebPreferences setKeygenElementEnabled:]):
27         * WebView/WebPreferencesPrivate.h:
28         * WebView/WebView.mm:
29         (-[WebView _preferencesChanged:]):
30
31 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
32
33         Remove IDB-specific quota
34         https://bugs.webkit.org/show_bug.cgi?id=196545
35         <rdar://problem/54201783>
36
37         Reviewed by Youenn Fablet.
38
39         * Storage/WebDatabaseManager.mm:
40         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
41         * Storage/WebDatabaseManagerPrivate.h:
42
43 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
44
45         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
46         https://bugs.webkit.org/show_bug.cgi?id=200620
47
48         Reviewed by Geoffrey Garen.
49
50         * History/WebHistory.mm:
51         (-[WebHistoryPrivate init]):
52         * History/WebHistoryItem.mm:
53         (-[WebHistoryItem initFromDictionaryRepresentation:]):
54         * Plugins/Hosted/NetscapePluginHostProxy.mm:
55         (WKPCGetScriptableNPObjectReply):
56         (WKPCBooleanReply):
57         (WKPCBooleanAndDataReply):
58         (WKPCInstantiatePluginReply):
59         * Plugins/Hosted/ProxyInstance.mm:
60         (WebKit::ProxyInstance::methodNamed):
61         (WebKit::ProxyInstance::fieldNamed):
62         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
63         (-[WebHostedNetscapePluginView createPlugin]):
64         * Plugins/WebNetscapePluginEventHandler.mm:
65         (WebNetscapePluginEventHandler::create):
66         * Plugins/WebNetscapePluginView.mm:
67         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
68         * Storage/WebDatabaseManagerClient.mm:
69         (DidModifyOriginData::dispatchToMainThread):
70         * WebCoreSupport/WebFrameLoaderClient.mm:
71         (addRedirectURL):
72         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
73         * WebCoreSupport/WebInspectorClient.mm:
74         (WebInspectorClient::openLocalFrontend):
75         * WebView/WebDeviceOrientationProviderMock.mm:
76         * WebView/WebFrame.mm:
77         (-[WebFrame _attachScriptDebugger]):
78         * WebView/WebMediaPlaybackTargetPicker.mm:
79         (WebMediaPlaybackTargetPicker::create):
80         * WebView/WebTextIterator.mm:
81         (-[WebTextIterator initWithRange:]):
82         * WebView/WebView.mm:
83         (-[WebView _injectOutlookQuirksScript]):
84         (-[WebView _commonInitializationWithFrameName:groupName:]):
85         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
86         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
87         (-[WebView _selectionServiceController]):
88         (-[WebView _setTextIndicator:withLifetime:]):
89         * WebView/WebViewData.mm:
90         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
91         (-[WebViewPrivate init]):
92
93 2019-08-17  Darin Adler  <darin@apple.com>
94
95         Tidy up checks to see if a character is in the Latin-1 range by using isLatin1 consistently
96         https://bugs.webkit.org/show_bug.cgi?id=200861
97
98         Reviewed by Ross Kirsling.
99
100         * Misc/WebKitNSStringExtras.mm:
101         (canUseFastRenderer): Use isLatin1.
102
103 2019-08-16  Chris Dumez  <cdumez@apple.com>
104
105         LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted
106         https://bugs.webkit.org/show_bug.cgi?id=200825
107
108         Reviewed by Alex Christensen.
109
110         * Misc/WebKitVersionChecks.h:
111         * Storage/WebStorageManager.mm:
112         (WebKitInitializeStorageIfNecessary):
113
114 2019-08-16  Ryosuke Niwa  <rniwa@webkit.org>
115
116         Split tabIndex computation for DOM and the rest of WebCore
117         https://bugs.webkit.org/show_bug.cgi?id=200806
118
119         Reviewed by Chris Dumez.
120
121         * DOM/DOMHTMLElement.mm:
122         (-[DOMHTMLElement tabIndex]):
123         (-[DOMHTMLElement setTabIndex:]):
124
125 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
126
127         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
128         https://bugs.webkit.org/show_bug.cgi?id=200620
129
130         Reviewed by Geoffrey Garen.
131
132         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
133         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
134         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
135         * Storage/WebDatabaseManagerClient.mm:
136         * WebCoreSupport/WebAlternativeTextClient.h:
137         * WebCoreSupport/WebCachedFramePlatformData.h:
138         * WebCoreSupport/WebChromeClient.h:
139         * WebCoreSupport/WebContextMenuClient.h:
140         * WebCoreSupport/WebDragClient.h:
141         * WebCoreSupport/WebEditorClient.h:
142         * WebCoreSupport/WebGeolocationClient.h:
143         * WebCoreSupport/WebInspectorClient.h:
144         * WebCoreSupport/WebNotificationClient.h:
145         * WebCoreSupport/WebSelectionServiceController.h:
146         * WebView/WebMediaPlaybackTargetPicker.h:
147
148 2019-08-15  Tim Horton  <timothy_horton@apple.com>
149
150         Yellow Lookup highlight gets stuck over Mail messages
151         https://bugs.webkit.org/show_bug.cgi?id=200778
152         <rdar://problem/53868514>
153
154         Reviewed by Wenson Hsieh.
155
156         * WebView/WebView.mm:
157         (-[WebView _showDictionaryLookupPopup:]):
158         Add a dismissal callback so that when Reveal hides the panel, it also
159         dismisses the yellow indicator. This matches the behavior in modern WebKit.
160
161 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
162
163         Some improvements on web storage
164         https://bugs.webkit.org/show_bug.cgi?id=200373
165
166         Reviewed by Geoffrey Garen.
167
168         * WebView/WebView.mm:
169         (-[WebView _preferencesChanged:]): notify storageNamespaceProvider about session change.
170
171 2019-08-15  Youenn Fablet  <youenn@apple.com>
172
173         Always create a Document with a valid SessionID
174         https://bugs.webkit.org/show_bug.cgi?id=200727
175
176         Reviewed by Alex Christensen.
177
178         Implement WebKit1 sessionID getter like done for WebKit2.
179         Either the loader client has a page in which case the page session ID is used
180         or the client has no page, in which case the default session ID is used.
181         This is the same behavior as CachedResourceLoader.
182
183         * WebCoreSupport/WebFrameLoaderClient.mm:
184         (WebFrameLoaderClient::sessionID const):
185
186 2019-08-15  Simon Fraser  <simon.fraser@apple.com>
187
188         Use ObjectIdentifier<FrameIdentifierType> for frameIDs
189         https://bugs.webkit.org/show_bug.cgi?id=199986
190
191         Reviewed by Ryosuke Niwa.
192
193         Use the strongly-typed FrameIdentifier instead of uint64_t as frame identifiers everywhere.
194
195         * WebCoreSupport/WebFrameLoaderClient.h:
196         * WebCoreSupport/WebFrameLoaderClient.mm:
197         (WebFrameLoaderClient::frameID const):
198
199 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
200
201         Unreviewed, rolling out r248526.
202
203         Caused two IndexedDB perf tests to fail
204
205         Reverted changeset:
206
207         "Remove IDB-specific quota"
208         https://bugs.webkit.org/show_bug.cgi?id=196545
209         https://trac.webkit.org/changeset/248526
210
211 2019-08-14  Keith Rollin  <krollin@apple.com>
212
213         Remove support for macOS < 10.13
214         https://bugs.webkit.org/show_bug.cgi?id=200694
215         <rdar://problem/54278851>
216
217         Reviewed by Youenn Fablet.
218
219         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
220         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
221         101300. This means that expressions like
222         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
223         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
224
225         * WebCoreSupport/WebEditorClient.mm:
226         * WebView/PDFViewSPI.h:
227         * WebView/WebHTMLView.mm:
228         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:]):
229         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:]):
230         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
231         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
232         * WebView/WebPreferences.mm:
233         (+[WebPreferences initialize]):
234         * WebView/WebView.mm:
235         (-[WebView performDragOperation:]):
236         (LayerFlushController::flushLayers):
237         (-[WebView updateMediaTouchBar]):
238         * WebView/WebViewData.h:
239
240 2019-08-14  Youenn Fablet  <youenn@apple.com>
241
242         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
243         https://bugs.webkit.org/show_bug.cgi?id=200671
244
245         Reviewed by ALex Christensen.
246
247         * WebCoreSupport/WebPlatformStrategies.mm:
248
249 2019-08-13  Youenn Fablet  <youenn@apple.com>
250
251         Blob registries should be keyed by session IDs
252         https://bugs.webkit.org/show_bug.cgi?id=200567
253
254         Reviewed by Alex Christensen.
255
256         * WebCoreSupport/WebPlatformStrategies.mm:
257         (WebPlatformStrategies::createBlobRegistry):
258         Ignore sessionID parameter for WK1.
259
260 2019-08-12  Chris Dumez  <cdumez@apple.com>
261
262         Add threading assertions to RefCounted
263         https://bugs.webkit.org/show_bug.cgi?id=200507
264
265         Reviewed by Ryosuke Niwa.
266
267         * WebView/WebView.mm:
268         (+[WebView initialize]):
269         Enable new RefCounted threading assertions for WebKitLegacy.
270
271 2019-08-12  Chris Dumez  <cdumez@apple.com>
272
273         Unreviewed, rolling out r248525.
274
275         Revert new threading assertions while I work on fixing the
276         issues they exposed
277
278         Reverted changeset:
279
280         "Add threading assertions to RefCounted"
281         https://bugs.webkit.org/show_bug.cgi?id=200507
282         https://trac.webkit.org/changeset/248525
283
284 2019-08-12  Youenn Fablet  <youenn@apple.com>
285
286         Remove IDB-specific quota
287         https://bugs.webkit.org/show_bug.cgi?id=196545
288
289         Reviewed by Alex Christensen.
290
291         * Storage/WebDatabaseManager.mm:
292         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
293         * Storage/WebDatabaseManagerPrivate.h:
294
295 2019-08-11  Chris Dumez  <cdumez@apple.com>
296
297         Add threading assertions to RefCounted
298         https://bugs.webkit.org/show_bug.cgi?id=200507
299
300         Reviewed by Ryosuke Niwa.
301
302         * WebView/WebView.mm:
303         (+[WebView initialize]):
304         Enable new RefCounted threading assertions for WebKitLegacy.
305
306 2019-08-10  Tim Horton  <timothy_horton@apple.com>
307
308         Remove some more unused 32-bit code
309         https://bugs.webkit.org/show_bug.cgi?id=200607
310
311         Reviewed by Alexey Proskuryakov.
312
313         * Configurations/WebKitLegacy.xcconfig:
314         * Misc/WebSharingServicePickerController.mm:
315         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
316         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
317         (-[WebSharingServicePickerController sharingService:didShareItems:]):
318         * Plugins/WebNetscapePluginEventHandler.mm:
319         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Removed.
320         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Removed.
321         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
322         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
323         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
324         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
325         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
326         (WebNetscapePluginEventHandlerCocoa::keyDown):
327         (WebNetscapePluginEventHandlerCocoa::focusChanged):
328         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
329         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
330         (WebNetscapePluginEventHandlerCocoa::TSMEventHandler): Deleted.
331         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): Deleted.
332         * WebCoreSupport/WebContextMenuClient.mm:
333         (WebContextMenuClient::contextMenuForEvent):
334         * WebView/WebHTMLView.mm:
335         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
336         (-[WebHTMLView pressureChangeWithEvent:]):
337         * WebView/WebView.mm:
338         (LayerFlushController::flushLayers):
339
340 2019-08-08  Rob Buis  <rbuis@igalia.com>
341
342         Add runtime flag for lazy image loading
343         https://bugs.webkit.org/show_bug.cgi?id=199794
344
345         Reviewed by Darin Adler.
346
347         Set lazyImageLoading runtime flag if preference is set.
348
349         * WebView/WebPreferenceKeysPrivate.h:
350         * WebView/WebPreferences.mm:
351         (+[WebPreferences initialize]):
352         (-[WebPreferences lazyImageLoadingEnabled]):
353         (-[WebPreferences setLazyImageLoadingEnabled:]):
354         * WebView/WebPreferencesPrivate.h:
355         * WebView/WebView.mm:
356         (-[WebView _preferencesChanged:]):
357
358 2019-08-07  Priyanka Agarwal  <pagarwal999@apple.com>
359
360         Allow clients to toggle a text input field between being viewable and having characters hidden while maintaining 
361         a yellow auto-filled appearance
362         https://bugs.webkit.org/show_bug.cgi?id=200037
363         rdar://problem/51900961
364
365         Reviewed by Daniel Bates.
366
367         * DOM/WebDOMOperations.mm:
368         (-[DOMHTMLInputElement _isAutoFilledAndViewable]):
369         (-[DOMHTMLInputElement _setAutoFilledAndViewable:]):
370         * DOM/WebDOMOperationsPrivate.h:
371
372 2019-08-02  Keith Rollin  <krollin@apple.com>
373
374         Consistently use Obj-C boolean literals
375         https://bugs.webkit.org/show_bug.cgi?id=200405
376         <rdar://problem/53880043>
377
378         Reviewed by Simon Fraser, Joseph Pecoraro.
379
380         There are places where we use equivalent but different expressions for
381         Obj-C boolean objects. For example, we use both [NSNumber
382         numberWithBool:YES] and @YES. There are places where both are used in
383         the same function, such as -[WebPreferences initialize]. The boolean
384         literal is in greater use and is more succinct, so standardize on
385         that. Also, change @(YES/NO) to @YES/NO.
386
387         * History/WebHistoryItem.mm:
388         * WebView/WebFrame.mm:
389         (-[WebFrame _cacheabilityDictionary]):
390         * WebView/WebPreferences.mm:
391         (+[WebPreferences initialize]):
392
393 2019-08-01  Alex Christensen  <achristensen@webkit.org>
394
395         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
396         https://bugs.webkit.org/show_bug.cgi?id=200102
397         <rdar://problem/53275114>
398
399         Reviewed by Darin Adler.
400
401         * DefaultDelegates/WebDefaultUIDelegate.mm:
402         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): Deleted.
403         (-[WebDefaultUIDelegate webView:generateReplacementFile:]): Deleted.
404         * WebCoreSupport/WebChromeClient.h:
405         * WebCoreSupport/WebChromeClient.mm:
406         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Deleted.
407         (WebChromeClient::generateReplacementFile): Deleted.
408         * WebView/WebUIDelegatePrivate.h:
409
410 2019-07-25  Dean Jackson  <dino@apple.com>
411
412         Add helper for ignoring deprecated implementation warnings
413         https://bugs.webkit.org/show_bug.cgi?id=200135
414
415         Reviewed by Wenson Hsieh.
416
417         Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
418         is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
419
420         * Misc/WebDownload.mm:
421         (-[WebDownload initWithRequest:delegate:]):
422         * Misc/WebIconDatabase.mm:
423         * Plugins/WebBaseNetscapePluginView.mm:
424         (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
425         (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.
426         * WebView/WebDynamicScrollBarsView.mm:
427         (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
428         (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.
429         * WebView/WebHTMLView.mm:
430         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
431         (-[WebHTMLView draggedImage:endedAt:operation:]):
432         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
433         (-[WebHTMLView accessibilityAttributeValue:]):
434         (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
435         (-[WebHTMLView characterIndexForPoint:]):
436         (-[WebHTMLView firstRectForCharacterRange:]):
437         (-[WebHTMLView attributedSubstringFromRange:]):
438         (-[WebHTMLView setMarkedText:selectedRange:]):
439         (-[WebHTMLView doCommandBySelector:]):
440         (-[WebHTMLView insertText:]):
441         (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.
442
443 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
444
445         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
446         https://bugs.webkit.org/show_bug.cgi?id=200021
447         <rdar://problem/53301325>
448
449         Reviewed by Ryosuke Niwa.
450
451         Implement a new editing client hook. In WebKit1, this always returns true on macOS and false on iOS.
452
453         * WebCoreSupport/WebEditorClient.h:
454
455 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
456
457         Fix WebView iframe rendering in macOS Catalina
458         https://bugs.webkit.org/show_bug.cgi?id=200022
459         rdar://problem/49102040
460
461         Reviewed by Darin Adler.
462
463         Adapt to internal NSView method renames in Catalina.
464
465         * WebView/WebHTMLView.mm:
466         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
467         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
468
469 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
470
471         Enable CSSOMViewScrollingAPIEnabled in WebKit1
472         https://bugs.webkit.org/show_bug.cgi?id=200008
473         rdar://problem/53409062
474
475         Reviewed by Tim Horton.
476
477         Default WebKitCSSOMViewScrollingAPIEnabledPreferenceKey to YES, so that 
478         CSSOMViewScrollingAPIEnabled is on for both WebKit1 and WebKit2.
479
480         DumpRenderTree already turns this preference on, so this change is not
481         detected by tests.
482
483         * WebView/WebPreferences.mm:
484         (+[WebPreferences initialize]):
485
486 2019-07-22  Youenn Fablet  <youenn@apple.com>
487
488         Disable MediaRecorder for legacy WebKit
489         https://bugs.webkit.org/show_bug.cgi?id=200001
490         <rdar://problem/53400030>
491
492         Reviewed by Eric Carlson.
493
494         Disable MediaRecorder by default in legacy WebKit.
495         Add SPI to set/get this preference.
496
497         * WebView/WebPreferences.mm:
498         (+[WebPreferences initialize]):
499         (-[WebPreferences _mediaRecorderEnabled]):
500         (-[WebPreferences _setMediaRecorderEnabled:]):
501         * WebView/WebPreferencesPrivate.h:
502
503 2019-07-18  Alex Christensen  <achristensen@webkit.org>
504
505         Unify builds in WebKitLegacy/mac/DOM
506         https://bugs.webkit.org/show_bug.cgi?id=199771
507
508         Reviewed by Geoffrey Garen.
509
510         * DOM/DOMAbstractView.mm:
511         * DOM/DOMAttr.mm:
512         * DOM/DOMBlob.mm:
513         * DOM/DOMCDATASection.mm:
514         * DOM/DOMCSSFontFaceRule.mm:
515         * DOM/DOMCSSImportRule.mm:
516         * DOM/DOMCSSMediaRule.mm:
517         * DOM/DOMCSSPageRule.mm:
518         * DOM/DOMCSSPrimitiveValue.mm:
519         * DOM/DOMCSSRule.mm:
520         * DOM/DOMCSSRuleList.mm:
521         * DOM/DOMCSSStyleDeclaration.mm:
522         * DOM/DOMCSSStyleRule.mm:
523         * DOM/DOMCSSStyleSheet.mm:
524         * DOM/DOMCSSUnknownRule.mm:
525         * DOM/DOMCSSValue.mm:
526         * DOM/DOMCSSValueList.mm:
527         * DOM/DOMCharacterData.mm:
528         * DOM/DOMComment.mm:
529         * DOM/DOMCounter.mm:
530         * DOM/DOMDocument.mm:
531         * DOM/DOMDocumentFragment.mm:
532         * DOM/DOMDocumentType.mm:
533         * DOM/DOMEvent.mm:
534         * DOM/DOMFile.mm:
535         * DOM/DOMFileList.mm:
536         * DOM/DOMHTMLAnchorElement.mm:
537         * DOM/DOMHTMLAppletElement.mm:
538         * DOM/DOMHTMLAreaElement.mm:
539         * DOM/DOMHTMLBRElement.mm:
540         * DOM/DOMHTMLBaseElement.mm:
541         * DOM/DOMHTMLBaseFontElement.mm:
542         * DOM/DOMHTMLBodyElement.mm:
543         * DOM/DOMHTMLButtonElement.mm:
544         * DOM/DOMHTMLCanvasElement.mm:
545         * DOM/DOMHTMLCollection.mm:
546         * DOM/DOMHTMLDListElement.mm:
547         * DOM/DOMHTMLDirectoryElement.mm:
548         * DOM/DOMHTMLDivElement.mm:
549         * DOM/DOMHTMLDocument.mm:
550         * DOM/DOMHTMLElement.mm:
551         * DOM/DOMHTMLEmbedElement.mm:
552         * DOM/DOMHTMLFieldSetElement.mm:
553         * DOM/DOMHTMLFontElement.mm:
554         * DOM/DOMHTMLFormElement.mm:
555         * DOM/DOMHTMLFrameElement.mm:
556         * DOM/DOMHTMLFrameSetElement.mm:
557         * DOM/DOMHTMLHRElement.mm:
558         * DOM/DOMHTMLHeadElement.mm:
559         * DOM/DOMHTMLHeadingElement.mm:
560         * DOM/DOMHTMLHtmlElement.mm:
561         * DOM/DOMHTMLIFrameElement.mm:
562         * DOM/DOMHTMLImageElement.mm:
563         * DOM/DOMHTMLInputElement.mm:
564         * DOM/DOMHTMLLIElement.mm:
565         * DOM/DOMHTMLLabelElement.mm:
566         * DOM/DOMHTMLLegendElement.mm:
567         * DOM/DOMHTMLLinkElement.mm:
568         * DOM/DOMHTMLMapElement.mm:
569         * DOM/DOMHTMLMarqueeElement.mm:
570         * DOM/DOMHTMLMediaElement.mm:
571         * DOM/DOMHTMLMenuElement.mm:
572         * DOM/DOMHTMLMetaElement.mm:
573         * DOM/DOMHTMLModElement.mm:
574         * DOM/DOMHTMLOListElement.mm:
575         * DOM/DOMHTMLObjectElement.mm:
576         * DOM/DOMHTMLOptGroupElement.mm:
577         * DOM/DOMHTMLOptionElement.mm:
578         * DOM/DOMHTMLOptionsCollection.mm:
579         * DOM/DOMHTMLParagraphElement.mm:
580         * DOM/DOMHTMLParamElement.mm:
581         * DOM/DOMHTMLPreElement.mm:
582         * DOM/DOMHTMLQuoteElement.mm:
583         * DOM/DOMHTMLScriptElement.mm:
584         * DOM/DOMHTMLSelectElement.mm:
585         * DOM/DOMHTMLStyleElement.mm:
586         * DOM/DOMHTMLTableCaptionElement.mm:
587         * DOM/DOMHTMLTableCellElement.mm:
588         * DOM/DOMHTMLTableColElement.mm:
589         * DOM/DOMHTMLTableElement.mm:
590         * DOM/DOMHTMLTableRowElement.mm:
591         * DOM/DOMHTMLTableSectionElement.mm:
592         * DOM/DOMHTMLTitleElement.mm:
593         * DOM/DOMHTMLUListElement.mm:
594         * DOM/DOMHTMLVideoElement.mm:
595         * DOM/DOMKeyboardEvent.mm:
596         * DOM/DOMMediaError.mm:
597         * DOM/DOMMediaList.mm:
598         * DOM/DOMMouseEvent.mm:
599         * DOM/DOMMutationEvent.mm:
600         * DOM/DOMNamedNodeMap.mm:
601         * DOM/DOMNodeIterator.mm:
602         * DOM/DOMNodeList.mm:
603         * DOM/DOMOverflowEvent.mm:
604         * DOM/DOMProcessingInstruction.mm:
605         * DOM/DOMProgressEvent.mm:
606         * DOM/DOMRGBColor.mm:
607         * DOM/DOMRange.mm:
608         * DOM/DOMRect.mm:
609         * DOM/DOMStyleSheet.mm:
610         * DOM/DOMStyleSheetList.mm:
611         * DOM/DOMText.mm:
612         * DOM/DOMTextEvent.mm:
613         * DOM/DOMTimeRanges.mm:
614         * DOM/DOMTokenList.mm:
615         * DOM/DOMTreeWalker.mm:
616         * DOM/DOMUIEvent.mm:
617         * DOM/DOMWheelEvent.mm:
618         * DOM/DOMXPath.mm:
619         * DOM/DOMXPathExpression.mm:
620         * DOM/DOMXPathResult.mm:
621
622 2019-07-17  Antoine Quint  <graouts@apple.com>
623
624         Disable Pointer Events prior to watchOS 6
625         https://bugs.webkit.org/show_bug.cgi?id=199890
626         <rdar://problem/53206113>
627
628         Reviewed by Dean Jackson.
629
630         * Configurations/FeatureDefines.xcconfig:
631
632 2019-07-17  Zalan Bujtas  <zalan@apple.com>
633
634         Unable to tap buttons at top of Wells Fargo app’s Payees screen
635         https://bugs.webkit.org/show_bug.cgi?id=199846
636         <rdar://problem/48112220>
637
638         Reviewed by Simon Fraser.
639
640         * WebView/WebFrame.mm:
641         (-[WebFrame approximateNodeAtViewportLocation:]):
642
643 2019-07-17  Alex Christensen  <achristensen@webkit.org>
644
645         Add a runtime-disabled dialog element skeleton
646         https://bugs.webkit.org/show_bug.cgi?id=199839
647
648         Reviewed by Ryosuke Niwa.
649
650         * WebView/WebPreferenceKeysPrivate.h:
651         * WebView/WebPreferences.mm:
652         (+[WebPreferences initialize]):
653         (-[WebPreferences dialogElementEnabled]):
654         (-[WebPreferences setDialogElementEnabled:]):
655         * WebView/WebPreferencesPrivate.h:
656         * WebView/WebView.mm:
657         (-[WebView _preferencesChanged:]):
658         Add SPI to enable the dialog element for tests.
659
660 2019-07-15  Dean Jackson  <dino@apple.com>
661
662         [WebGL] Remove software rendering and simplify context creation on macOS
663         https://bugs.webkit.org/show_bug.cgi?id=199789
664
665         Reviewed by Sam Weinig.
666
667         Remove force software WebGL setting.
668
669         * WebView/WebPreferenceKeysPrivate.h:
670         * WebView/WebPreferences.mm:
671         (+[WebPreferences initialize]):
672         (-[WebPreferences forceSoftwareWebGLRendering]): Deleted.
673         (-[WebPreferences setForceSoftwareWebGLRendering:]): Deleted.
674         * WebView/WebPreferencesPrivate.h:
675         * WebView/WebView.mm:
676         (-[WebView _preferencesChanged:]):
677
678 2019-07-13  Zalan Bujtas  <zalan@apple.com>
679
680         Cannot bring up custom media controls at all on v.youku.com
681         https://bugs.webkit.org/show_bug.cgi?id=199699
682         <rdar://problem/51835327>
683
684         Reviewed by Simon Fraser.
685
686         * WebCoreSupport/WebFrameLoaderClient.mm:
687         (WebFrameLoaderClient::actionDictionary const):
688         * WebView/WebFrame.mm:
689         (-[WebFrame elementAtPoint:]):
690         * WebView/WebHTMLView.mm:
691         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
692         * WebView/WebImmediateActionController.mm:
693         (-[WebImmediateActionController performHitTestAtPoint:]):
694
695 2019-07-12  Alex Christensen  <achristensen@webkit.org>
696
697         Begin unifying WebKitLegacy sources
698         https://bugs.webkit.org/show_bug.cgi?id=199730
699
700         Reviewed by Keith Miller.
701
702         * Configurations/WebKitLegacy.xcconfig:
703
704 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
705
706         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
707         https://bugs.webkit.org/show_bug.cgi?id=199625
708
709         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
710         with ENABLE(ACCESSIBILITY) in the code.
711
712         Additionally, the TestRunner code generator now honors the
713         Conditional IDL format.
714
715         Reviewed by Konstantin Tokarev.
716
717         * WebView/WebFrame.mm:
718         (-[WebFrame setAccessibleName:]):
719         (-[WebFrame enhancedAccessibilityEnabled]):
720         (-[WebFrame setEnhancedAccessibility:]):
721         (-[WebFrame accessibilityRoot]):
722
723 2019-07-08  Antoine Quint  <graouts@apple.com>
724
725         [Pointer Events] Enable only on the most recent version of the supported iOS family
726         https://bugs.webkit.org/show_bug.cgi?id=199562
727         <rdar://problem/52766511>
728
729         Reviewed by Dean Jackson.
730
731         * Configurations/FeatureDefines.xcconfig:
732
733 2019-07-03  Sam Weinig  <weinig@apple.com>
734
735         Adopt simple structured bindings in more places
736         https://bugs.webkit.org/show_bug.cgi?id=199247
737
738         Reviewed by Alex Christensen.
739
740         Replaces simple uses of std::tie() with structured bindings. Does not touch
741         uses of std::tie() that are not initial declarations, use std::ignore or in
742         case where the binding is captured by a lambda, as structured bindings don't
743         work for those cases yet.
744
745         * WebView/WebImmediateActionController.mm:
746         (-[WebImmediateActionController _animationControllerForText]):
747
748 2019-07-02  Devin Rousso  <drousso@apple.com>
749
750         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
751         https://bugs.webkit.org/show_bug.cgi?id=198956
752
753         Reviewed by Matt Baker.
754
755         * WebCoreSupport/WebInspectorClient.h:
756         * WebCoreSupport/WebInspectorClient.mm:
757         (WebInspectorFrontendClient::resetWindowState): Added.
758
759 2019-06-28  Timothy Hatcher  <timothy@apple.com>
760
761         Rename effectiveAppearanceIsInactive and useInactiveAppearance to better match UIUserInterfaceLevel.
762         https://bugs.webkit.org/show_bug.cgi?id=199336
763         rdar://problem/52348938
764
765         Reviewed by Tim Horton.
766
767         * WebView/WebView.mm:
768         (-[WebView _commonInitializationWithFrameName:groupName:]):
769         (-[WebView _setUseDarkAppearance:]):
770         (-[WebView _useElevatedUserInterfaceLevel]):
771         (-[WebView _setUseElevatedUserInterfaceLevel:]):
772         (-[WebView _setUseDarkAppearance:useInactiveAppearance:]):
773         (-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]):
774         (-[WebView _effectiveUserInterfaceLevelIsElevated]):
775         (-[WebView viewDidChangeEffectiveAppearance]):
776         (-[WebView _useInactiveAppearance]): Deleted.
777         (-[WebView _setUseInactiveAppearance:]): Deleted.
778         (-[WebView _effectiveAppearanceIsInactive]): Deleted.
779         * WebView/WebViewPrivate.h:
780
781 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
782
783         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
784         https://bugs.webkit.org/show_bug.cgi?id=199317
785
786         Reviewed by Michael Catanzaro.
787
788         While IconDatabase and all code using it was removed,
789         ENABLE_ICONDATABASE still exists as build option and C++ macro.
790
791         * Configurations/FeatureDefines.xcconfig:
792         * WebView/WebView.mm:
793         (-[WebView _cacheFrameLoadDelegateImplementations]): Use PLATFORM(MAC)
794         guard instead of ENABLE_ICONDATABASE, because ENABLE_ICONDATABASE was
795         enabled for macOS only.
796
797 2019-06-27  Timothy Hatcher  <timothy@apple.com>
798
799         Move WebKitLegacy off of a couple AppKit ivars.
800         https://bugs.webkit.org/show_bug.cgi?id=199279
801         rdar://problem/34983438
802
803         Reviewed by Tim Horton.
804
805         * WebView/WebHTMLView.mm:
806         (-[NSView _setSubviewsIvar:]): Added. Implement on older systems.
807         (-[NSView _subviewsIvar]): Added. Ditto.
808         (needsCursorRectsSupportAtPoint): Use _borderView property.
809         (-[WebHTMLView _setAsideSubviews]): Use _subviewsIvar property.
810         (-[NSWindow _web_borderView]): Deleted.
811
812 2019-06-27  Beth Dakin  <bdakin@apple.com>
813
814         Upstream use of MACCATALYST
815         https://bugs.webkit.org/show_bug.cgi?id=199245
816         rdar://problem/51687723
817
818         Reviewed by Tim Horton.
819
820         * Configurations/Base.xcconfig:
821         * Configurations/FeatureDefines.xcconfig:
822         * Configurations/SDKVariant.xcconfig:
823
824 2019-06-27  Saam Barati  <sbarati@apple.com>
825
826         Make WEBGPU enabled only on Mojave and later.
827
828         Rubber-stamped by Myles C. Maxfield.
829
830         * Configurations/FeatureDefines.xcconfig:
831
832 2019-06-16  Darin Adler  <darin@apple.com>
833
834         Rename AtomicString to AtomString
835         https://bugs.webkit.org/show_bug.cgi?id=195276
836
837         Reviewed by Michael Catanzaro.
838
839         * many files: Let do-webcore-rename do the renaming.
840
841 2019-06-14  Megan Gardner  <megan_gardner@apple.com>
842
843         Move Synthetic Editing Commands to behind an experimental feature flag
844         https://bugs.webkit.org/show_bug.cgi?id=198842
845         <rdar://problem/50594700>
846
847         Reviewed by Simon Fraser.
848
849         Add plumbing for synthetic editing command feature flag.
850
851         * WebView/WebPreferenceKeysPrivate.h:
852         * WebView/WebPreferences.mm:
853         (+[WebPreferences initialize]):
854         (-[WebPreferences syntheticEditingCommandsEnabled]):
855         (-[WebPreferences setSyntheticEditingCommandsEnabled:]):
856         * WebView/WebPreferencesPrivate.h:
857         * WebView/WebView.mm:
858         (-[WebView _preferencesChanged:]):
859
860 2019-06-13  Antoine Quint  <graouts@apple.com>
861
862         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
863         https://bugs.webkit.org/show_bug.cgi?id=198800
864         <rdar://problem/51679634>
865
866         Reviewed by Tim Horton.
867
868         Expose a private method that we need to use from DumpRenderTree.
869
870         * WebView/WebHTMLView.mm:
871         (-[WebHTMLView _hitViewForEvent:]):
872         * WebView/WebHTMLViewPrivate.h:
873
874 2019-06-10  Sam Weinig  <weinig@apple.com>
875
876         Remove Dashboard support
877         https://bugs.webkit.org/show_bug.cgi?id=198615
878
879         Reviewed by Ryosuke Niwa.
880
881         Removes implementation, but keeps privatly exported interfaces and enums
882         around until we can confirm there are no more users of them. 
883
884         * Configurations/FeatureDefines.xcconfig:
885         * Plugins/WebBaseNetscapePluginView.mm:
886         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
887         * WebCoreSupport/WebChromeClient.h:
888         * WebCoreSupport/WebChromeClient.mm:
889         (WebChromeClient::annotatedRegionsChanged): Deleted.
890         * WebView/WebClipView.mm:
891         (-[WebClipView _focusRingVisibleRect]):
892         (-[WebClipView scrollWheel:]):
893         * WebView/WebDashboardRegion.h:
894         * WebView/WebDashboardRegion.mm:
895         * WebView/WebHTMLView.mm:
896         (-[WebHTMLView _updateMouseoverWithEvent:]):
897         (-[WebHTMLView acceptsFirstMouse:]):
898         (-[WebHTMLView setDataSource:]):
899         * WebView/WebPreferences.mm:
900         (cacheModelForMainBundle):
901         * WebView/WebUIDelegatePrivate.h:
902         * WebView/WebView.mm:
903         (-[WebView _needsPreHTML5ParserQuirks]):
904         (-[WebView _preferencesChanged:]):
905         (-[WebView _addScrollerDashboardRegions:]):
906         (-[WebView _dashboardRegions]):
907         (-[WebView _setDashboardBehavior:to:]):
908         (-[WebView _dashboardBehavior:]):
909         (-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted.
910         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted.
911         (-[WebView _addScrollerDashboardRegions:from:]): Deleted.
912         * WebView/WebViewData.h:
913         * WebView/WebViewData.mm:
914         (-[WebViewPrivate init]):
915         * WebView/WebViewPrivate.h:
916
917 2019-06-10  Timothy Hatcher  <timothy@apple.com>
918
919         Integrate dark mode support for iOS.
920         https://bugs.webkit.org/show_bug.cgi?id=198687
921         rdar://problem/51545643
922
923         Reviewed by Tim Horton.
924
925         * Configurations/FeatureDefines.xcconfig:
926
927 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
928
929         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
930         https://bugs.webkit.org/show_bug.cgi?id=198664
931
932         Reviewed by Simon Fraser.
933
934         WK1 has to skip using DisplayRefreshMonitor when layers need to be updated.
935
936         * WebCoreSupport/WebChromeClient.h:
937         (WebChromeClient::needsImmediateScheduleCompositingLayerFlush):
938
939 == Rolled over to ChangeLog-2019-06-05 ==