Remove a site specific hack for AppleConnect plugin
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove a site specific hack for AppleConnect plugin
4         https://bugs.webkit.org/show_bug.cgi?id=195643
5
6         Reviewed by Simon Fraser.
7
8         r66437 added a workaround for AppleConnect plugin.
9
10         Remove this code since Safari doesn't even use WebKitLegacy anymore,
11         and other WebKit clients support AppleConnect plugins.
12
13         * WebCoreSupport/WebFrameLoaderClient.mm:
14         (WebFrameLoaderClient::createPlugin):
15
16 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
17
18         Unreviewed, rolling out r242688, r242643, r242624.
19
20         Caused multiple layout test failures and crashes on iOS and macOS.
21
22         Reverted changeset:
23
24         "requestAnimationFrame should execute before the next frame"
25         https://bugs.webkit.org/show_bug.cgi?id=177484
26         https://trac.webkit.org/changeset/242624/webkit
27
28         * WebView/WebView.mm:
29         (-[WebView _viewWillDrawInternal]):
30
31 2019-03-09  Andy Estes  <aestes@apple.com>
32
33         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
34         https://bugs.webkit.org/show_bug.cgi?id=195526
35         <rdar://problem/48745636>
36
37         Reviewed by Chris Dumez.
38
39         * WebCoreSupport/WebPaymentCoordinatorClient.h:
40         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
41         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
42         (WebPaymentCoordinatorClient::openPaymentSetup):
43
44 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
45
46         requestAnimationFrame should execute before the next frame
47         https://bugs.webkit.org/show_bug.cgi?id=177484
48
49         Reviewed by Simon Fraser.
50
51         * WebView/WebView.mm:
52         (-[WebView _viewWillDrawInternal]):
53         Call Page::renderingUpdate() which implements  "Update the rendering"
54         step of the HTML Event Loop specification.
55
56 2019-03-07  Zalan Bujtas  <zalan@apple.com>
57
58         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
59         https://bugs.webkit.org/show_bug.cgi?id=195353
60         <rdar://problem/48626394>
61
62         Reviewed by Simon Fraser.
63
64         * WebView/WebPreferenceKeysPrivate.h:
65         * WebView/WebPreferences.mm:
66         (+[WebPreferences initialize]):
67         (-[WebPreferences contentChangeObserverEnabled]):
68         (-[WebPreferences setContentChangeObserverEnabled:]):
69         * WebView/WebPreferencesPrivate.h:
70         * WebView/WebView.mm:
71         (-[WebView _preferencesChanged:]):
72
73 2019-03-06  Sam Weinig  <sam@webkit.org>
74
75         WebKitLegacy does not need to generate an export file for i386 anymore
76         https://bugs.webkit.org/show_bug.cgi?id=195380
77
78         Reviewed by Dan Bernstein.
79
80         * Configurations/WebKitLegacy.xcconfig:
81         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
82         It still needs to be generated, since we are concatenating the shared exports
83         file with a macOS or iOS specific one.
84
85         * WebKit.mac.exp:
86         Remove i386 specific symbols that we were previously stripping.
87
88 2019-03-06  Rob Buis  <rbuis@igalia.com>
89
90         Consider supporting the `referrerpolicy` attribute.
91         https://bugs.webkit.org/show_bug.cgi?id=179053
92
93         Reviewed by Darin Adler.
94
95         Add a runtime flag for referrerpolicy attribute.
96
97         * WebView/WebPreferenceKeysPrivate.h:
98         * WebView/WebPreferences.mm:
99         (+[WebPreferences initialize]):
100         (-[WebPreferences referrerPolicyAttributeEnabled]):
101         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
102         * WebView/WebPreferencesPrivate.h:
103         * WebView/WebView.mm:
104         (-[WebView _preferencesChanged:]):
105
106 2019-03-03  Tim Horton  <timothy_horton@apple.com>
107
108         Remove some more unused 32-bit code
109         https://bugs.webkit.org/show_bug.cgi?id=195255
110
111         Reviewed by Darin Adler.
112
113         * Plugins/WebNetscapePluginEventHandler.mm:
114         (WebNetscapePluginEventHandler::create):
115         * Plugins/WebNetscapePluginView.h:
116         * Plugins/WebNetscapePluginView.mm:
117         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
118         (-[WebNetscapePluginView restorePortState:]):
119         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
120         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
121         (-[WebNetscapePluginView updateAndSetWindow]):
122         (-[WebNetscapePluginView setWindowIfNecessary]):
123         (-[WebNetscapePluginView createPlugin]):
124         (-[WebNetscapePluginView fini]):
125         (-[WebNetscapePluginView drawRect:]):
126         (-[WebNetscapePluginView invalidateRegion:]):
127         (-[WebNetscapePluginView getVariable:value:]):
128         (-[WebNetscapePluginView setVariable:value:]):
129         (isDrawingModelQuickDraw): Deleted.
130         (-[WebNetscapePluginView fixWindowPort]): Deleted.
131         (getQDPixelFormatForBitmapContext): Deleted.
132         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
133         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
134         * WebView/WebDelegateImplementationCaching.mm:
135
136 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
137
138         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
139         https://bugs.webkit.org/show_bug.cgi?id=195053
140         <rdar://problem/48134710>
141
142         Reviewed by Ryosuke Niwa.
143
144         * WebCoreSupport/WebEditorClient.h:
145
146 2019-03-01  Tim Horton  <timothy_horton@apple.com>
147
148         Remove unused code in WebKitLegacy
149         https://bugs.webkit.org/show_bug.cgi?id=189614
150
151         Reviewed by Simon Fraser.
152
153         * Carbon/CarbonUtils.h: Removed.
154         * Carbon/CarbonUtils.m: Removed.
155         * Carbon/CarbonWindowAdapter.h: Removed.
156         * Carbon/CarbonWindowAdapter.mm: Removed.
157         * Carbon/CarbonWindowContentView.h: Removed.
158         * Carbon/CarbonWindowContentView.m: Removed.
159         * Carbon/CarbonWindowFrame.h: Removed.
160         * Carbon/CarbonWindowFrame.m: Removed.
161         * Carbon/HIViewAdapter.h: Removed.
162         * Carbon/HIViewAdapter.m: Removed.
163         * Carbon/HIWebView.h: Removed.
164         * Carbon/HIWebView.mm: Removed.
165         * Configurations/WebKitLegacy.xcconfig:
166         * WebKit.mac.exp:
167
168 2019-03-01  Justin Fan  <justin_fan@apple.com>
169
170         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
171         https://bugs.webkit.org/show_bug.cgi?id=195191
172
173         Rubber-stamped by Dean Jackson.
174
175         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
176
177         * Configurations/FeatureDefines.xcconfig:
178
179 2019-02-28  Antoine Quint  <graouts@apple.com>
180
181         Enable the Pointer Events runtime flag by default
182         https://bugs.webkit.org/show_bug.cgi?id=195156
183
184         Reviewed by Dean Jackson.
185
186         * WebView/WebPreferences.mm:
187         (+[WebPreferences initialize]):
188
189 2019-02-28  Justin Fan  <justin_fan@apple.com>
190
191         [Web GPU] Enable Web GPU only on 64-bit
192         https://bugs.webkit.org/show_bug.cgi?id=195139
193
194         Because Metal is only supported on 64 bit apps.
195
196         Unreviewed build fix.
197
198         * Configurations/FeatureDefines.xcconfig:
199
200 2019-02-27  Antoine Quint  <graouts@apple.com>
201
202         Support Pointer Events on macOS
203         https://bugs.webkit.org/show_bug.cgi?id=195008
204         <rdar://problem/47454419>
205
206         Reviewed by Dean Jackson.
207
208         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
209
210         * Configurations/FeatureDefines.xcconfig:
211         * WebView/WebPreferenceKeysPrivate.h:
212         * WebView/WebPreferences.mm:
213         (+[WebPreferences initialize]):
214         (-[WebPreferences pointerEventsEnabled]):
215         (-[WebPreferences setPointerEventsEnabled:]):
216         * WebView/WebPreferencesPrivate.h:
217         * WebView/WebView.mm:
218         (-[WebView _preferencesChanged:]):
219
220 2019-02-23  Keith Miller  <keith_miller@apple.com>
221
222         Add new mac target numbers
223         https://bugs.webkit.org/show_bug.cgi?id=194955
224
225         Reviewed by Tim Horton.
226
227         * Configurations/Base.xcconfig:
228         * Configurations/DebugRelease.xcconfig:
229
230 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
231
232         Hardcode Visual Viewports on everywhere except iOS WK1
233         https://bugs.webkit.org/show_bug.cgi?id=194928
234
235         Reviewed by Zalan Bujtas.
236
237         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
238         change the default value of the Setting to 'true', and hardcode WebView on iOS to
239         set it to false. The setting has shipped for several years and there's no need to turn
240         it off now.
241
242         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
243         Visual Viewports are not enabled.
244         
245         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
246         that only runs in WK2
247
248         * WebView/WebPreferenceKeysPrivate.h:
249         * WebView/WebPreferences.mm:
250         (+[WebPreferences initialize]):
251         (-[WebPreferences visualViewportEnabled]): Deleted.
252         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
253         * WebView/WebPreferencesPrivate.h:
254         * WebView/WebView.mm:
255         (-[WebView _preferencesChanged:]):
256
257 2019-02-21  Darin Adler  <darin@apple.com>
258
259         Some refinements for Node and Document
260         https://bugs.webkit.org/show_bug.cgi?id=194764
261
262         Reviewed by Ryosuke Niwa.
263
264         * DOM/DOMDocument.mm:
265         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
266         through to WebCore or even looking at the arguments.
267         (-[DOMDocument getOverrideStyle::]): Ditto.
268
269 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
270
271         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
272         https://bugs.webkit.org/show_bug.cgi?id=194670
273         <rdar://problem/39066529>
274
275         Reviewed by Tim Horton.
276
277         * WebCoreSupport/WebEditorClient.h:
278         * WebCoreSupport/WebEditorClient.mm:
279         (WebEditorClient::replacementURLForResource): Deleted.
280         * WebCoreSupport/WebPlatformStrategies.h:
281         * WebCoreSupport/WebPlatformStrategies.mm:
282         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
283
284 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
285
286         Add MSE logging configuration
287         https://bugs.webkit.org/show_bug.cgi?id=194719
288         <rdar://problem/48122151>
289
290         Reviewed by Joseph Pecoraro.
291
292         * WebCoreSupport/WebChromeClient.mm:
293         (stringForMessageSource): Recognize the MSE message source.
294
295 2019-02-17  David Kilzer  <ddkilzer@apple.com>
296
297         Unreviewed, rolling out r241620.
298
299         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
300         (Requested by ddkilzer on #webkit.)
301
302         Reverted changeset:
303
304         "[WTF] Add environment variable helpers"
305         https://bugs.webkit.org/show_bug.cgi?id=192405
306         https://trac.webkit.org/changeset/241620
307
308 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
309
310         [WTF] Add environment variable helpers
311         https://bugs.webkit.org/show_bug.cgi?id=192405
312
313         Reviewed by Michael Catanzaro.
314
315         * WebView/WebView.mm:
316         (-[WebView _initWithFrame:frameName:groupName:]):
317         Utilize WTF::Environment where possible.
318
319 2019-02-15  Brian Burg  <bburg@apple.com>
320
321         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
322         https://bugs.webkit.org/show_bug.cgi?id=194411
323         <rdar://problem/47787614>
324
325         Reviewed by Joseph Pecoraro.
326
327         * Configurations/WebKitLegacy.xcconfig:
328         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
329
330         * WebCoreSupport/WebInspectorClient.mm:
331         (WebInspectorFrontendClient::localizedStringsURL):
332         (-[WebInspectorWindowController inspectorPagePath]):
333         (-[WebInspectorWindowController inspectorTestPagePath]):
334         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
335
336 2019-02-15  Commit Queue  <commit-queue@webkit.org>
337
338         Unreviewed, rolling out r241559 and r241566.
339         https://bugs.webkit.org/show_bug.cgi?id=194710
340
341         Causes layout test crashes under GuardMalloc (Requested by
342         ryanhaddad on #webkit).
343
344         Reverted changesets:
345
346         "[WTF] Add environment variable helpers"
347         https://bugs.webkit.org/show_bug.cgi?id=192405
348         https://trac.webkit.org/changeset/241559
349
350         "Unreviewed build fix for WinCairo Debug after r241559."
351         https://trac.webkit.org/changeset/241566
352
353 2019-02-15  Truitt Savell  <tsavell@apple.com>
354
355         Unreviewed, rolling out r241564.
356
357         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
358
359         Reverted changeset:
360
361         "[Mac] WebInspectorUI.framework does not need to be soft-
362         linked anymore"
363         https://bugs.webkit.org/show_bug.cgi?id=194411
364         https://trac.webkit.org/changeset/241564
365
366 2019-02-14  Brian Burg  <bburg@apple.com>
367
368         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
369         https://bugs.webkit.org/show_bug.cgi?id=194411
370         <rdar://problem/47787614>
371
372         Reviewed by Joseph Pecoraro.
373
374         * Configurations/WebKitLegacy.xcconfig:
375         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
376
377         * WebCoreSupport/WebInspectorClient.mm:
378         (WebInspectorFrontendClient::localizedStringsURL):
379         (-[WebInspectorWindowController inspectorPagePath]):
380         (-[WebInspectorWindowController inspectorTestPagePath]):
381         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
382
383 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
384
385         [WTF] Add environment variable helpers
386         https://bugs.webkit.org/show_bug.cgi?id=192405
387
388         Reviewed by Michael Catanzaro.
389
390         * WebView/WebView.mm:
391         (-[WebView _initWithFrame:frameName:groupName:]):
392         Utilize WTF::Environment where possible.
393
394 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
395
396         Allow pages to trigger programmatic paste from script on iOS
397         https://bugs.webkit.org/show_bug.cgi?id=194271
398         <rdar://problem/47808810>
399
400         Reviewed by Ryosuke Niwa.
401
402         See WebCore and WebKit ChangeLogs for more details.
403
404         * WebCoreSupport/WebEditorClient.h:
405
406 2019-02-12  Andy Estes  <aestes@apple.com>
407
408         [iOSMac] Enable Parental Controls Content Filtering
409         https://bugs.webkit.org/show_bug.cgi?id=194521
410         <rdar://39732376>
411
412         Reviewed by Tim Horton.
413
414         * Configurations/FeatureDefines.xcconfig:
415
416 2019-02-06  Andy Estes  <aestes@apple.com>
417
418         [Payment Request] It should be possible to require a phonetic name for shipping contacts
419         https://bugs.webkit.org/show_bug.cgi?id=194311
420         <rdar://46733045>
421
422         Reviewed by Alex Christensen.
423
424         * WebCoreSupport/WebPaymentCoordinatorClient.h:
425         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
426         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
427
428 2019-02-04  Said Abou-Hallawa  <said@apple.com>
429
430         [CG] Enable setAdditionalSupportedImageTypes for WK1
431         https://bugs.webkit.org/show_bug.cgi?id=194190
432
433         Reviewed by Tim Horton.
434
435         1. Define the preferences key AdditionalSupportedImageTypes.
436         2. Add additionalSupportedImageTypes as a private preference property.
437         3. Define the setter and the getter of the property.
438         4. Add function to convert from an id to an array of strings.
439         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
440
441         * WebView/WebPreferenceKeysPrivate.h:
442         * WebView/WebPreferences.mm:
443         (-[WebPreferences _stringArrayValueForKey:]):
444         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
445         (-[WebPreferences setAdditionalSupportedImageTypes:]):
446         (-[WebPreferences additionalSupportedImageTypes]):
447         * WebView/WebPreferencesPrivate.h:
448         * WebView/WebView.mm:
449         (-[WebView _preferencesChanged:]):
450
451 2019-02-04  Timothy Hatcher  <timothy@apple.com>
452
453         Add WebView SPI to temporarily force light or dark appearance on a page.
454         https://bugs.webkit.org/show_bug.cgi?id=194230
455
456         Reviewed by Tim Horton.
457
458         * WebView/WebView.mm:
459         (-[WebView _useDarkAppearance:]): Added.
460         (-[WebView _setUseDarkAppearance:]): Added.
461         * WebView/WebViewPrivate.h:
462
463 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
464
465         PageOverlayController's layers should be created lazily
466         https://bugs.webkit.org/show_bug.cgi?id=194199
467         rdar://problem/46571593
468
469         Reviewed by Tim Horton.
470
471         * WebCoreSupport/WebChromeClient.h:
472         * WebCoreSupport/WebChromeClient.mm:
473         (WebChromeClient::attachViewOverlayGraphicsLayer):
474
475 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
476
477         Make setNeedsLayout on the root more explicitly about triggering its side-effects
478         https://bugs.webkit.org/show_bug.cgi?id=194198
479
480         Reviewed by Antti Koivisto.
481
482         Call the newly named functions.
483
484         * WebView/WebFrame.mm:
485         (-[WebFrame setNeedsLayout]):
486         * WebView/WebHTMLView.mm:
487         (-[WebHTMLView setNeedsLayout:]):
488
489 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
490
491         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
492         https://bugs.webkit.org/show_bug.cgi?id=194189
493
494         Reviewed by Geoffrey Garen.
495
496         Pass the policy check identifier around functions and store it in WebFramePolicyListener
497         so that we can send it back to WebCore with the navigation policy decision.
498
499         * WebCoreSupport/WebFrameLoaderClient.h:
500         * WebCoreSupport/WebFrameLoaderClient.mm:
501         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
502         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
503         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
504         (WebFrameLoaderClient::dispatchWillSubmitForm):
505         (WebFrameLoaderClient::setUpPolicyListener):
506         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
507         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
508         (-[WebFramePolicyListener invalidate]):
509         (-[WebFramePolicyListener dealloc]):
510         (-[WebFramePolicyListener receivedPolicyDecision:]):
511         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
512         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
513
514 2019-01-31  Alex Christensen  <achristensen@webkit.org>
515
516         Revert r238819 which is unneeded and caused a performance regression.
517         https://bugs.webkit.org/show_bug.cgi?id=192272
518         <rdar://problem/46664625>
519
520         * WebCoreSupport/WebFrameLoaderClient.h:
521         * WebCoreSupport/WebFrameLoaderClient.mm:
522         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
523
524 2019-01-28  Devin Rousso  <drousso@apple.com>
525
526         Web Inspector: provide a way to edit page WebRTC settings on a remote target
527         https://bugs.webkit.org/show_bug.cgi?id=193863
528         <rdar://problem/47572764>
529
530         Reviewed by Joseph Pecoraro.
531
532         * WebView/WebView.mm:
533         (-[WebView _preferencesChanged:]):
534         Add page-level settings for WebRTC preferences.
535
536 2019-01-28  Andy Estes  <aestes@apple.com>
537
538         [watchOS] Enable Parental Controls content filtering
539         https://bugs.webkit.org/show_bug.cgi?id=193939
540         <rdar://problem/46641912>
541
542         Reviewed by Ryosuke Niwa.
543
544         * Configurations/FeatureDefines.xcconfig:
545
546 2019-01-28  Timothy Hatcher  <timothy@apple.com>
547
548         Make it easier for non-Apple ports to enable dark mode CSS support.
549         https://bugs.webkit.org/show_bug.cgi?id=193882
550
551         Reviewed by Megan Gardner.
552
553         * WebView/WebView.mm:
554         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
555         (-[WebView _effectiveAppearanceIsDark]): Ditto.
556
557 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
558
559         AX: Introduce a static accessibility tree
560         https://bugs.webkit.org/show_bug.cgi?id=193348
561         <rdar://problem/47203295>
562
563         Reviewed by Ryosuke Niwa.
564
565         * Configurations/FeatureDefines.xcconfig:
566
567 2019-01-25  Keith Rollin  <krollin@apple.com>
568
569         Update WebKitAdditions.xcconfig with correct order of variable definitions
570         https://bugs.webkit.org/show_bug.cgi?id=193793
571         <rdar://problem/47532439>
572
573         Reviewed by Alex Christensen.
574
575         XCBuild changes the way xcconfig variables are evaluated. In short,
576         all config file assignments are now considered in part of the
577         evaluation. When using the new build system and an .xcconfig file
578         contains multiple assignments of the same build setting:
579
580         - Later assignments using $(inherited) will inherit from earlier
581           assignments in the xcconfig file.
582         - Later assignments not using $(inherited) will take precedence over
583           earlier assignments. An assignment to a more general setting will
584           mask an earlier assignment to a less general setting. For example,
585           an assignment without a condition ('FOO = bar') will completely mask
586           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
587
588         This affects some of our .xcconfig files, in that sometimes platform-
589         or sdk-specific definitions appear before the general definitions.
590         Under the new evaluations rules, the general definitions alway take
591         effect because they always overwrite the more-specific definitions. The
592         solution is to swap the order, so that the general definitions are
593         established first, and then conditionally overwritten by the
594         more-specific definitions.
595
596         * Configurations/Version.xcconfig:
597         * Configurations/WebKitLegacy.xcconfig:
598
599 2019-01-25  David Kilzer  <ddkilzer@apple.com>
600
601         Move soft-linking of Lookup.framework out of LookupSPI.h
602         <https://webkit.org/b/193815>
603
604         Reviewed by Tim Horton.
605
606         * WebView/WebImmediateActionController.mm:
607         (-[WebImmediateActionController _animationControllerForText]):
608         * WebView/WebView.mm:
609         (-[WebView _prepareForDictionaryLookup]):
610         - Move soft-linking to LookupSoftLink.{h,mm}.
611
612 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
613
614         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
615         https://bugs.webkit.org/show_bug.cgi?id=193829
616
617         Reviewed by Tim Horton.
618
619         * WebCoreSupport/WebDragClient.mm:
620         (WebDragClient::didConcludeEditDrag):
621         * WebView/WebView.mm:
622         (-[WebView _requestStartDataInteraction:globalPosition:]):
623         (-[WebView _didConcludeEditDrag]):
624         (-[WebView _didConcludeEditDataInteraction]): Deleted.
625         * WebView/WebViewInternal.h:
626
627 2019-01-24  John Wilander  <wilander@apple.com>
628
629         Add Ad Click Attribution as an internal/experimental feature
630         https://bugs.webkit.org/show_bug.cgi?id=193685
631         <rdar://problem/47450399>
632
633         Reviewed by Brent Fulgham.
634
635         * WebView/WebPreferenceKeysPrivate.h:
636         * WebView/WebPreferences.mm:
637         (+[WebPreferences initialize]):
638         (-[WebPreferences adClickAttributionEnabled]):
639         (-[WebPreferences setAdClickAttributionEnabled:]):
640             Added support for experimental ad click attribution.
641         * WebView/WebPreferencesPrivate.h:
642         * WebView/WebView.mm:
643         (-[WebView _preferencesChanged:]):
644
645 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
646
647         Move FileSystem to WTF
648         https://bugs.webkit.org/show_bug.cgi?id=193602
649
650         Reviewed by Yusuke Suzuki.
651
652         * Misc/WebNSFileManagerExtras.mm:
653         * Storage/WebDatabaseProvider.mm:
654         * WebView/WebView.mm:
655
656 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
657
658         Fix the Apple Internal build. See <rdar://problem/47491383>.
659
660         Rubber-stamped by Tim Horton.
661
662         * WebCoreSupport/WebFrameLoaderClient.mm:
663
664 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
665
666         Clean up USE(WEB_THREAD)
667         https://bugs.webkit.org/show_bug.cgi?id=193698
668
669         Rubber-stamped by Tim Horton.
670
671         * Misc/WebCache.mm:
672         (+[WebCache emptyInMemoryResources]):
673         * WebCoreSupport/WebFrameLoaderClient.mm:
674         (-[WebFramePolicyListener use]):
675         * WebCoreSupport/WebGeolocationClient.mm:
676         (-[WebGeolocationPolicyListener allow]):
677         (-[WebGeolocationPolicyListener deny]):
678         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
679         * WebView/WebFrame.mm:
680         (-[WebFrame deviceOrientationChanged]):
681         * WebView/WebHTMLView.mm:
682         (hardwareKeyboardAvailabilityChangedCallback):
683         * WebView/WebView.mm:
684         (+[WebView _releaseMemoryNow]):
685         (+[WebView willEnterBackgroundWithCompletionHandler:]):
686         (-[WebView updateLayoutIgnorePendingStyleSheets]):
687         (-[WebView _dispatchUnloadEvent]):
688         (-[WebView _close]):
689         (-[WebView _preferencesChangedNotification:]):
690         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
691         (-[WebView goBack]):
692         (-[WebView goForward]):
693         (+[WebView _cacheModelChangedNotification:]):
694         (-[WebView stopLoading:]):
695         (-[WebView stopLoadingAndClear]):
696         (-[WebView reload:]):
697         (WebInstallMemoryPressureHandler):
698
699 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
700
701         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
702         https://bugs.webkit.org/show_bug.cgi?id=193706
703         <rdar://problem/44807048>
704
705         Reviewed by Ryosuke Niwa.
706
707         Use UndoStep::label().
708
709         * WebCoreSupport/WebEditorClient.h:
710         * WebCoreSupport/WebEditorClient.mm:
711         (-[WebUndoStep initWithUndoStep:]):
712         (+[WebUndoStep stepWithUndoStep:]):
713         (WebEditorClient::registerUndoOrRedoStep):
714         (WebEditorClient::registerUndoStep):
715         (WebEditorClient::registerRedoStep):
716
717 2019-01-22  Alex Christensen  <achristensen@webkit.org>
718
719         Move NetworkStorageSession ownership to NetworkProcess
720         https://bugs.webkit.org/show_bug.cgi?id=193580
721
722         Reviewed by Geoff Garen.
723
724         * Misc/WebCache.mm:
725         (+[WebCache clearCachedCredentials]):
726         * Misc/WebDownload.mm:
727         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
728         * Plugins/WebBaseNetscapePluginView.mm:
729         (WebKit::getAuthenticationInfo):
730         * WebCoreSupport/WebFrameNetworkingContext.mm:
731         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
732         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
733         (WebFrameNetworkingContext::storageSession const):
734         * WebView/WebPreferences.mm:
735         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
736         (+[WebPreferences _clearNetworkLoaderSession]):
737         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
738
739 2019-01-22  Daniel Bates  <dabates@apple.com>
740
741         [iOS] Interpret text key commands on keydown and app key commands on keypress
742         https://bugs.webkit.org/show_bug.cgi?id=192897
743         <rdar://problem/46857378>
744
745         Reviewed by Brent Fulgham.
746
747         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
748         is false) and keypress (isCharEvent is true), respectively.
749
750         * WebView/WebHTMLView.mm:
751         (-[WebHTMLView _handleEditingKeyEvent:]):
752
753 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
754
755         [css-logical] Implement flow-relative margin, padding and border shorthands
756         https://bugs.webkit.org/show_bug.cgi?id=188697
757
758         Reviewed by Simon Fraser and Antti Koivisto.
759
760         Add CSSLogicalEnabled runtime flag.
761
762         * WebView/WebPreferenceKeysPrivate.h:
763         * WebView/WebPreferences.mm:
764         (+[WebPreferences initialize]):
765         (-[WebPreferences cssLogicalEnabled]):
766         (-[WebPreferences setCSSLogicalEnabled:]):
767         * WebView/WebPreferencesPrivate.h:
768         * WebView/WebView.mm:
769         (-[WebView _preferencesChanged:]):
770
771 2019-01-15  Darin Adler  <darin@apple.com>
772
773         Use references rather than pointers for register/unregister functions, and more
774         https://bugs.webkit.org/show_bug.cgi?id=175028
775
776         Reviewed by Daniel Bates.
777
778         * WebCoreSupport/WebKitFullScreenListener.mm:
779         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
780         functions in Document; pass a reference.
781         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
782         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
783         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
784         * WebView/WebFullScreenController.mm:
785         (-[WebFullScreenController enterFullScreen:]): Ditto.
786         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
787         (-[WebFullScreenController exitFullScreen]): Ditto.
788         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
789         * WebView/WebFullScreenController.mm:
790         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
791
792 2019-01-12  Dan Bernstein  <mitz@apple.com>
793
794         [Cocoa] Avoid importing directly from subumbrella frameworks
795         https://bugs.webkit.org/show_bug.cgi?id=186016
796         <rdar://problem/40591038>
797
798         Reviewed by Sam Weinig.
799
800         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
801         * Carbon/CarbonWindowAdapter.mm: Ditto.
802         * Carbon/CarbonWindowFrame.m: Ditto.
803         * Carbon/HIViewAdapter.h: Ditto.
804         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
805           OTHER_CFLAGS_COCOA_TOUCH_NO.
806         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
807         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
808         * WebView/WebPDFView.h: Ditto.
809
810 2019-01-20  Antoine Quint  <graouts@apple.com>
811
812         Add a POINTER_EVENTS feature flag
813         https://bugs.webkit.org/show_bug.cgi?id=193577
814         <rdar://problem/47408511>
815
816         Unreviewed. Also enable Pointer Events for iosmac.
817
818         * Configurations/FeatureDefines.xcconfig:
819
820 2019-01-19  Antoine Quint  <graouts@apple.com>
821
822         Add a POINTER_EVENTS feature flag
823         https://bugs.webkit.org/show_bug.cgi?id=193577
824
825         Reviewed by Dean Jackson.
826
827         * Configurations/FeatureDefines.xcconfig:
828
829 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
830
831         Revert r238815, it broke WK1 video fullscreen on Mac
832         https://bugs.webkit.org/show_bug.cgi?id=193586
833         <rdar://problem/47358941>
834
835         Reviewed by Jer Noble.
836
837         * WebView/WebVideoFullscreenController.h: Added.
838         * WebView/WebVideoFullscreenController.mm: Added.
839         (SOFT_LINK_CLASS):
840         (-[WebVideoFullscreenController init]):
841         (-[WebVideoFullscreenController dealloc]):
842         (-[WebVideoFullscreenController fullscreenWindow]):
843         (-[WebVideoFullscreenController windowDidLoad]):
844         (-[WebVideoFullscreenController videoElement]):
845         (-[WebVideoFullscreenController setVideoElement:]):
846         (-[WebVideoFullscreenController clearFadeAnimation]):
847         (-[WebVideoFullscreenController windowDidExitFullscreen]):
848         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
849         (-[WebVideoFullscreenController videoElementRect]):
850         (-[WebVideoFullscreenController applicationDidResignActive:]):
851         (frameExpandedToRatioOfFrame):
852         (createBackgroundFullscreenWindow):
853         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
854         (-[WebVideoFullscreenController enterFullscreen:]):
855         (-[WebVideoFullscreenController exitFullscreen]):
856         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
857         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
858         (-[WebVideoFullscreenController _requestExit]):
859         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
860         (-[WebVideoFullscreenController requestExitFullscreen]):
861         (-[WebVideoFullscreenController fadeHUDIn]):
862         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
863         (-[WebVideoFullscreenController rateChanged:]):
864         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
865         (-[WebVideoFullscreenWindow dealloc]):
866         (-[WebVideoFullscreenWindow resignFirstResponder]):
867         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
868         (-[WebVideoFullscreenWindow mouseDown:]):
869         (-[WebVideoFullscreenWindow cancelOperation:]):
870         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
871         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
872         (-[WebVideoFullscreenWindow animationDidEnd:]):
873         (-[WebVideoFullscreenWindow mouseMoved:]):
874         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
875         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
876         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
877         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
878         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
879         (-[WebVideoFullscreenHUDWindow center]):
880         (-[WebVideoFullscreenHUDWindow keyDown:]):
881         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
882         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
883         (-[WebVideoFullscreenHUDWindowController init]):
884         (-[WebVideoFullscreenHUDWindowController dealloc]):
885         (-[WebVideoFullscreenHUDWindowController setArea:]):
886         (-[WebVideoFullscreenHUDWindowController keyDown:]):
887         (-[WebVideoFullscreenHUDWindowController delegate]):
888         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
889         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
890         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
891         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
892         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
893         (-[WebVideoFullscreenHUDWindowController closeWindow]):
894         (createMediaUIControl):
895         (createControlWithMediaUIControlType):
896         (createTimeTextField):
897         (createMediaUIBackgroundView):
898         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
899         (-[WebVideoFullscreenHUDWindowController updateVolume]):
900         (-[WebVideoFullscreenHUDWindowController updateTime]):
901         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
902         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
903         (-[WebVideoFullscreenHUDWindowController currentTime]):
904         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
905         (-[WebVideoFullscreenHUDWindowController duration]):
906         (-[WebVideoFullscreenHUDWindowController maxVolume]):
907         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
908         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
909         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
910         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
911         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
912         (-[WebVideoFullscreenHUDWindowController volume]):
913         (-[WebVideoFullscreenHUDWindowController setVolume:]):
914         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
915         (-[WebVideoFullscreenHUDWindowController updateRate]):
916         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
917         (-[WebVideoFullscreenHUDWindowController playing]):
918         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
919         (timeToString):
920         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
921         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
922         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
923         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
924         (-[WebVideoFullscreenHUDWindowController rewind:]):
925         (-[WebVideoFullscreenHUDWindowController fastForward:]):
926         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
927         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
928         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
929         * WebView/WebView.mm:
930         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
931         (-[WebView _exitVideoFullscreen]):
932
933 2019-01-18  Tim Horton  <timothy_horton@apple.com>
934
935         Get rid of ADVANCED_SPELL_CHECKING
936         https://bugs.webkit.org/show_bug.cgi?id=193592
937
938         Reviewed by Wenson Hsieh.
939
940         * WebCoreSupport/WebEditorClient.mm:
941         (insertionPointFromCurrentSelection):
942         (WebEditorClient::checkTextOfParagraph):
943         (WebEditorClient::getGuessesForWord):
944         (WebEditorClient::requestCandidatesForSelection):
945         (WebEditorClient::requestCheckingOfString):
946         * WebView/WebHTMLView.mm:
947         (-[WebHTMLView insertText:]):
948
949 2019-01-18  Jer Noble  <jer.noble@apple.com>
950
951         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
952         https://bugs.webkit.org/show_bug.cgi?id=189553
953
954         Reviewed by Tim Horton.
955
956         * Configurations/Base.xcconfig:
957         * Configurations/SDKVariant.xcconfig: Added.
958         * Configurations/WebKitLegacy.xcconfig:
959
960 2019-01-18  David Kilzer  <ddkilzer@apple.com>
961
962         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
963         <https://webkit.org/b/193568>
964         <rdar://problem/47381130>
965
966         Reviewed by Alex Christensen.
967
968         * WebView/WebView.mm:
969         - Remove unused soft-linking macros.
970         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
971         (-[WebUITextIndicatorData initWithImage:scale:]):
972         - Update to use exported PAL functions.
973
974 2019-01-17  Truitt Savell  <tsavell@apple.com>
975
976         Unreviewed, rolling out r240124.
977
978         This commit broke an internal build.
979
980         Reverted changeset:
981
982         "SDK_VARIANT build destinations should be separate from non-
983         SDK_VARIANT builds"
984         https://bugs.webkit.org/show_bug.cgi?id=189553
985         https://trac.webkit.org/changeset/240124
986
987 2019-01-17  Jer Noble  <jer.noble@apple.com>
988
989         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
990         https://bugs.webkit.org/show_bug.cgi?id=189553
991
992         Reviewed by Tim Horton.
993
994         * Configurations/Base.xcconfig:
995         * Configurations/SDKVariant.xcconfig: Added.
996         * Configurations/WebKitLegacy.xcconfig:
997
998 2019-01-17  Alex Christensen  <achristensen@webkit.org>
999
1000         Stop using NetworkStorageSession::storageSession in WebCore
1001         https://bugs.webkit.org/show_bug.cgi?id=193529
1002
1003         Reviewed by Tim Horton.
1004
1005         * Misc/WebCache.mm:
1006         (+[WebCache addImageToCache:forURL:forFrame:]):
1007         * WebView/WebView.mm:
1008         (-[WebView _commonInitializationWithFrameName:groupName:]):
1009         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1010
1011 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1012
1013         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1014         https://bugs.webkit.org/show_bug.cgi?id=193368
1015
1016         Reviewed by Geoff Garen.
1017
1018         * Misc/WebCache.mm:
1019         (+[WebCache clearCachedCredentials]):
1020         * Misc/WebDownload.mm:
1021         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1022         * Plugins/WebBaseNetscapePluginView.mm:
1023         (WebKit::getAuthenticationInfo):
1024
1025 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1026
1027         Stop using CookiesStrategy
1028         https://bugs.webkit.org/show_bug.cgi?id=161106
1029
1030         Reviewed by Don Olmstead and Antti Koivisto.
1031
1032         * Misc/WebCache.mm:
1033         (+[WebCache addImageToCache:forURL:forFrame:]):
1034         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1035         (WebKit::NetscapePluginInstanceProxy::getCookies):
1036         (WebKit::NetscapePluginInstanceProxy::setCookies):
1037         * Plugins/WebNetscapePluginView.mm:
1038         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1039         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1040         * WebCoreSupport/WebPlatformStrategies.h:
1041         * WebCoreSupport/WebPlatformStrategies.mm:
1042         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1043         (WebPlatformStrategies::cookiesForDOM): Deleted.
1044         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1045         (WebPlatformStrategies::cookiesEnabled): Deleted.
1046         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1047         (WebPlatformStrategies::getRawCookies): Deleted.
1048         (WebPlatformStrategies::deleteCookie): Deleted.
1049         * WebView/WebView.mm:
1050         (-[WebView _commonInitializationWithFrameName:groupName:]):
1051         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1052
1053 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1054
1055         Cannot tab out of WKWebView on macOS
1056         https://bugs.webkit.org/show_bug.cgi?id=161448
1057         <rdar://problem/28100085>
1058
1059         Reviewed by Dean Jackson.
1060
1061         * WebCoreSupport/WebChromeClient.mm:
1062         * WebView/WebView.mm:
1063         Make use of SPI headers.
1064
1065 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1066
1067         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1068         r239913, and r239914.
1069         https://bugs.webkit.org/show_bug.cgi?id=193407
1070
1071         These revisions caused an internal failure (Requested by
1072         Truitt on #webkit).
1073
1074         Reverted changesets:
1075
1076         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1077         https://bugs.webkit.org/show_bug.cgi?id=186016
1078         https://trac.webkit.org/changeset/239901
1079
1080         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1081         https://trac.webkit.org/changeset/239909
1082
1083         "Tried to fix the build."
1084         https://trac.webkit.org/changeset/239910
1085
1086         "Fixed iOS builds after r239910."
1087         https://trac.webkit.org/changeset/239912
1088
1089         "More build fixing."
1090         https://trac.webkit.org/changeset/239913
1091
1092         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1093         https://trac.webkit.org/changeset/239914
1094
1095 2019-01-14  Mark Lam  <mark.lam@apple.com>
1096
1097         Re-enable ability to build --cloop builds.
1098         https://bugs.webkit.org/show_bug.cgi?id=192955
1099         <rdar://problem/46882363>
1100
1101         Reviewed by Saam barati and Keith Miller.
1102
1103         * Configurations/FeatureDefines.xcconfig:
1104
1105 2019-01-13  Dan Bernstein  <mitz@apple.com>
1106
1107         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1108
1109         Patch by Keith Rollin.
1110
1111         * WebView/PDFViewSPI.h:
1112
1113 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1114
1115         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1116         https://bugs.webkit.org/show_bug.cgi?id=191655
1117         rdar://problem/46074680
1118
1119         Reviewed by Megan Gardner.
1120
1121         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1122         * WebView/WebView.mm:
1123         (-[WebView _effectiveAppearanceIsDark]):
1124
1125 2019-01-12  Dan Bernstein  <mitz@apple.com>
1126
1127         [Cocoa] Avoid importing directly from subumbrella frameworks
1128         https://bugs.webkit.org/show_bug.cgi?id=186016
1129         <rdar://problem/40591038>
1130
1131         Reviewed by Sam Weinig.
1132
1133         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1134         * Carbon/CarbonWindowAdapter.mm: Ditto.
1135         * Carbon/CarbonWindowFrame.m: Ditto.
1136         * Carbon/HIViewAdapter.h: Ditto.
1137         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1138           OTHER_CFLAGS_COCOA_TOUCH_NO.
1139         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1140         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1141         * WebView/WebPDFView.h: Ditto.
1142
1143 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1144
1145         Enable visual viewport API by default
1146         https://bugs.webkit.org/show_bug.cgi?id=193376
1147
1148         Reviewed by Simon Fraser.
1149
1150         * WebView/WebPreferences.mm:
1151         (+[WebPreferences initialize]):
1152
1153 2019-01-11  John Wilander  <wilander@apple.com>
1154
1155         Compile out Web API Statistics Collection
1156         https://bugs.webkit.org/show_bug.cgi?id=193370
1157         <rdar://problem/45388584>
1158
1159         Reviewed by Brent Fulgham.
1160
1161         * Configurations/FeatureDefines.xcconfig:
1162             Defined ENABLE_WEB_API_STATISTICS, off by default.
1163
1164 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1165
1166         Stop using NetworkStorageSession in WebProcess
1167         https://bugs.webkit.org/show_bug.cgi?id=193236
1168
1169         Reviewed by Don Olmstead.
1170
1171         * WebCoreSupport/WebFrameNetworkingContext.h:
1172         * WebCoreSupport/WebFrameNetworkingContext.mm:
1173         (WebFrameNetworkingContext::storageSession const):
1174         * WebCoreSupport/WebPlatformStrategies.h:
1175         * WebCoreSupport/WebPlatformStrategies.mm:
1176         (WebPlatformStrategies::cookiesForDOM):
1177         (WebPlatformStrategies::setCookiesFromDOM):
1178         (WebPlatformStrategies::cookiesEnabled):
1179         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1180         (WebPlatformStrategies::getRawCookies):
1181         (WebPlatformStrategies::deleteCookie):
1182         * WebView/WebView.mm:
1183         (-[WebView _cachedResponseForURL:]):
1184         (-[WebView _clearCredentials]):
1185
1186 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1187
1188         Unreviewed, rolling out r239727.
1189
1190         Broke API tests
1191
1192         Reverted changeset:
1193
1194         "Stop using NetworkStorageSession in WebProcess"
1195         https://bugs.webkit.org/show_bug.cgi?id=193236
1196         https://trac.webkit.org/changeset/239727
1197
1198 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1199
1200         Stop using NetworkStorageSession in WebProcess
1201         https://bugs.webkit.org/show_bug.cgi?id=193236
1202
1203         Reviewed by Don Olmstead.
1204
1205         * WebCoreSupport/WebFrameNetworkingContext.h:
1206         * WebCoreSupport/WebFrameNetworkingContext.mm:
1207         (WebFrameNetworkingContext::storageSession const):
1208         * WebView/WebView.mm:
1209         (-[WebView _cachedResponseForURL:]):
1210         (-[WebView _clearCredentials]):
1211
1212 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1213
1214         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1215         <https://webkit.org/b/193056>
1216
1217         Reviewed by Alex Christensen.
1218
1219         * Plugins/Hosted/NetscapePluginHostProxy.h:
1220         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1221         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1222         (WebKit::NetscapePluginInstanceProxy::enumerate):
1223         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1224         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1225         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1226         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1227         * Plugins/Hosted/ProxyInstance.mm:
1228         (WebKit::ProxyInstance::invoke):
1229         * WebCoreSupport/WebGeolocationClient.mm:
1230         * WebView/WebDataSource.mm:
1231         (-[WebDataSource _receivedData:]):
1232         * WebView/WebView.mm:
1233         (-[WebView _cachedResponseForURL:]):
1234         - Remove '*' from RetainPtr<> type.
1235
1236 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1237
1238         Progress towards fixing Mac CMake build
1239         https://bugs.webkit.org/show_bug.cgi?id=193105
1240
1241         Reviewed by Don Olmstead.
1242
1243         * WebKitPrefix.h:
1244
1245 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1246
1247         Web Inspector: Use save sheet instead of dialog where possible
1248         https://bugs.webkit.org/show_bug.cgi?id=193160
1249         <rdar://problem/37399759>
1250
1251         Reviewed by Devin Rousso.
1252
1253         * WebCoreSupport/WebInspectorClient.mm:
1254         (WebInspectorFrontendClient::save):
1255
1256 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1257
1258         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1259         https://bugs.webkit.org/show_bug.cgi?id=193129
1260
1261         Reviewed by Tim Horton.
1262
1263         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1264
1265         * WebCoreSupport/WebEditorClient.mm:
1266         (WebEditorClient::registerUndoOrRedoStep):
1267         (undoNameForEditAction): Deleted.
1268
1269 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1270
1271         Add support for using the current text selection as the find string on iOS
1272         https://bugs.webkit.org/show_bug.cgi?id=193034
1273         <rdar://problem/45138739>
1274
1275         Reviewed by Tim Horton.
1276
1277         Add a method stub for WebKitLegacy.
1278
1279         * WebCoreSupport/WebEditorClient.h:
1280
1281 2019-01-01  Jeff Miller  <jeffm@apple.com>
1282
1283         Update user-visible copyright strings to include 2019
1284         https://bugs.webkit.org/show_bug.cgi?id=192811
1285
1286         Reviewed by Mark Lam.
1287
1288         * Info.plist:
1289
1290 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1291
1292         Use Ref<> as much as possible
1293         https://bugs.webkit.org/show_bug.cgi?id=192808
1294
1295         Reviewed by Alex Christensen.
1296
1297         * DOM/DOM.mm:
1298         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1299         * Plugins/Hosted/NetscapePluginHostManager.mm:
1300         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1301         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1302         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1303         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1304         * Plugins/WebNetscapePluginView.mm:
1305         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1306         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1307         * WebCoreSupport/WebContextMenuClient.mm:
1308         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1309         * WebCoreSupport/WebFrameLoaderClient.mm:
1310         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1311         * WebView/WebFrame.mm:
1312         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1313         * WebView/WebHTMLView.mm:
1314         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1315         * WebView/WebView.mm:
1316         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1317         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1318
1319 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1320
1321         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1322         https://bugs.webkit.org/show_bug.cgi?id=192821
1323
1324         Reviewed by Chris Dumez.
1325
1326         When a window becomes occluded, the window server informs the application.
1327         This should be used to suspend any work that is not visible by the user.
1328
1329         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1330         In some cases, that lead to performance impact (see radar).
1331
1332         This patch adds an observer for the occlusion notification. I tried to stick
1333         with the same names used by WebKit2.
1334
1335         * WebView/WebView.mm:
1336         (-[WebView _isViewVisible]):
1337         (-[WebView addWindowObserversForWindow:]):
1338         (-[WebView removeWindowObservers]):
1339         (-[WebView _windowDidChangeOcclusionState:]):
1340
1341 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1342
1343         [WebAuthN] Add a runtime flag for local authenticator
1344         https://bugs.webkit.org/show_bug.cgi?id=192792
1345         <rdar://problem/46798738>
1346
1347         Reviewed by Brent Fulgham.
1348
1349         * WebView/WebPreferenceKeysPrivate.h:
1350         * WebView/WebPreferences.mm:
1351         (+[WebPreferences initialize]):
1352         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1353         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1354         * WebView/WebPreferencesPrivate.h:
1355         * WebView/WebView.mm:
1356         (-[WebView _preferencesChanged:]):
1357
1358 2018-12-20  Chris Dumez  <cdumez@apple.com>
1359
1360         Use Optional::valueOr() instead of Optional::value_or()
1361         https://bugs.webkit.org/show_bug.cgi?id=192933
1362
1363         Reviewed by Geoffrey Garen.
1364
1365         * WebCoreSupport/WebSecurityOrigin.mm:
1366         (-[WebSecurityOrigin port]):
1367
1368 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1369
1370         Unreviewed, rolling out r239417.
1371
1372         Introduced two API test failures on macOS.
1373
1374         Reverted changeset:
1375
1376         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1377         occlusion changes"
1378         https://bugs.webkit.org/show_bug.cgi?id=192821
1379         https://trac.webkit.org/changeset/239417
1380
1381 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1382
1383         WKWebView default UA doesn't freeze the build number
1384         https://bugs.webkit.org/show_bug.cgi?id=192809
1385         <rdar://problem/44687185>
1386
1387         Reviewed by Andy Estes.
1388
1389         Always reports the frozen build number.
1390
1391         * WebView/WebView.mm:
1392         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1393         actual build number through this method call.
1394         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1395
1396 2018-12-19  Chris Dumez  <cdumez@apple.com>
1397
1398         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1399         https://bugs.webkit.org/show_bug.cgi?id=192728
1400         <rdar://problem/46746779>
1401
1402         Reviewed by Geoff Garen.
1403
1404         * DOM/*:
1405         * Plugins/*:
1406         * WebCoreSupport/*:
1407         * WebView/*:
1408
1409 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1410
1411         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1412         https://bugs.webkit.org/show_bug.cgi?id=192821
1413
1414         Reviewed by Chris Dumez.
1415
1416         When a window becomes occluded, the window server informs the application.
1417         This should be used to suspend any work that is not visible by the user.
1418
1419         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1420         In some cases, that lead to performance impact (see radar).
1421
1422         This patch adds an observer for the occlusion notification. I tried to stick
1423         with the same names used by WebKit2.
1424
1425         * WebView/WebView.mm:
1426         (-[WebView _isViewVisible]):
1427         (-[WebView addWindowObserversForWindow:]):
1428         (-[WebView removeWindowObservers]):
1429         (-[WebView _windowDidChangeOcclusionState:]):
1430
1431 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1432
1433         Allow clients to set the navigator platform
1434         https://bugs.webkit.org/show_bug.cgi?id=192735
1435
1436         Reviewed by Tim Horton.
1437
1438         Add stubs to fill out the added functionality in FrameLoaderClient.
1439
1440         * WebCoreSupport/WebFrameLoaderClient.h:
1441         * WebCoreSupport/WebFrameLoaderClient.mm:
1442         (WebFrameLoaderClient::navigatorPlatform):
1443
1444 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1445
1446         offsetLeft and offsetParent should adjust across shadow boundaries
1447         https://bugs.webkit.org/show_bug.cgi?id=157437
1448         <rdar://problem/26154021>
1449
1450         Reviewed by Simon Fraser.
1451
1452         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1453
1454         * DOM/DOMElement.mm:
1455         (-[DOMElement offsetLeft]):
1456         (-[DOMElement offsetTop]):
1457         (-[DOMElement offsetParent]):
1458
1459 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1460
1461         Unreviewed build fix.
1462
1463         * WebView/WebFrame.mm:
1464         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1465
1466 2018-12-15  Darin Adler  <darin@apple.com>
1467
1468         Use warning-ignoring macros more consistently and simply
1469         https://bugs.webkit.org/show_bug.cgi?id=192743
1470
1471         Reviewed by Mark Lam.
1472
1473         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1474         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1475         compilers in Objective-C++ code.
1476
1477         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1478         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1479         accomodate non-clang compilers here. Also use #pragma once, add a missing
1480         "explicit" and fix conditionals.
1481
1482 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1483
1484         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1485         https://bugs.webkit.org/show_bug.cgi?id=192653
1486
1487         Reviewed by Wenson Hsieh.
1488
1489         * WebView/WebHTMLView.mm:
1490         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1491
1492 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1493
1494         Implement feature flag for CSS Typed OM
1495         https://bugs.webkit.org/show_bug.cgi?id=192610
1496
1497         Reviewed by Ryosuke Niwa.
1498
1499         * Configurations/FeatureDefines.xcconfig:
1500
1501 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1502
1503         WebCore shouldn't have a Objective-C class named NSCursor
1504         https://bugs.webkit.org/show_bug.cgi?id=192602
1505         <rdar://problem/46615532>
1506
1507         Reviewed by Wenson Hsieh.
1508
1509         * WebView/WebFrameView.mm:
1510         (-[WebFrameView keyDown:keyDown:]):
1511         * WebView/WebHTMLView.mm:
1512         (-[WebHTMLView keyDown:]):
1513         (-[WebHTMLView performKeyEquivalent:]):
1514         Only use NSCursor on macOS.
1515
1516 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1517
1518         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1519         https://bugs.webkit.org/show_bug.cgi?id=192573
1520
1521         Reviewed by Simon Fraser.
1522
1523         * Configurations/FeatureDefines.xcconfig:
1524
1525 2018-12-10  Antti Koivisto  <antti@apple.com>
1526
1527         Rename "forced style recalc" to "full style rebuild"
1528         https://bugs.webkit.org/show_bug.cgi?id=192572
1529
1530         Reviewed by Zalan Bujtas.
1531
1532         * WebView/WebHTMLView.mm:
1533         (-[WebHTMLView setNeedsToApplyStyles:]):
1534
1535 2018-12-10  Darin Adler  <darin@apple.com>
1536
1537         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1538         https://bugs.webkit.org/show_bug.cgi?id=192533
1539         rdar://problem/45732710
1540
1541         Reviewed by Anders Carlsson.
1542
1543         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1544         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1545
1546 2018-12-10  Darin Adler  <darin@apple.com>
1547
1548         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1549         https://bugs.webkit.org/show_bug.cgi?id=192532
1550         rdar://problem/45731047
1551
1552         Reviewed by Chris Dumez.
1553
1554         * Plugins/Hosted/NetscapePluginHostManager.mm:
1555         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1556         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1557         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1558
1559 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1560
1561         Turn WritingDirection into an enum class
1562         https://bugs.webkit.org/show_bug.cgi?id=192401
1563         Work towards <rdar://problem/42075638>
1564
1565         Reviewed by Dan Bernstein.
1566
1567         Change WritingDirection from an enum to an enum class. No change in behavior.
1568
1569         * WebView/WebHTMLView.mm:
1570         (-[WebHTMLView toggleBaseWritingDirection:]):
1571         (-[WebHTMLView changeBaseWritingDirection:]):
1572         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1573
1574 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1575
1576         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1577         https://bugs.webkit.org/show_bug.cgi?id=192272
1578
1579         Reviewed by Brady Eidson.
1580
1581         * WebCoreSupport/WebFrameLoaderClient.h:
1582         * WebCoreSupport/WebFrameLoaderClient.mm:
1583         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1584
1585 2018-12-03  Jer Noble  <jer.noble@apple.com>
1586
1587         Get rid of old, dead Mac video fullscreen code.
1588         https://bugs.webkit.org/show_bug.cgi?id=192315
1589
1590         Reviewed by Eric Carlson.
1591
1592         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1593         is no longer supported in the Mac port.
1594
1595         * WebView/WebVideoFullscreenController.h: Removed.
1596         * WebView/WebVideoFullscreenController.mm: Removed.
1597         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1598         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1599         * WebView/WebView.mm:
1600         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1601         (-[WebView _exitVideoFullscreen]):
1602
1603 2018-12-03  Daniel Bates  <dabates@apple.com>
1604
1605         [iOS] Do not handle key events that are key commands
1606         https://bugs.webkit.org/show_bug.cgi?id=191608
1607         <rdar://problem/46046013>
1608
1609         Reviewed by Ryosuke Niwa.
1610
1611         A key down event may be associated with a key command. If it is then we want to execute the
1612         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1613         event as a key command to find out.
1614
1615         * WebView/WebHTMLView.mm:
1616         (-[WebHTMLView _handleEditingKeyEvent:]):
1617
1618 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1619
1620         Add a runtime feature flag for LayoutFormattingContext.
1621         https://bugs.webkit.org/show_bug.cgi?id=192280
1622
1623         Reviewed by Simon Fraser.
1624
1625         * Configurations/FeatureDefines.xcconfig:
1626
1627 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1628
1629         Move URL from WebCore to WTF
1630         https://bugs.webkit.org/show_bug.cgi?id=190234
1631
1632         Reviewed by Keith Miller.
1633
1634         * DOM/DOMAttr.mm:
1635         * DOM/DOMBlob.mm:
1636         * DOM/DOMCSSCharsetRule.mm:
1637         * DOM/DOMCSSImportRule.mm:
1638         * DOM/DOMCSSMediaRule.mm:
1639         * DOM/DOMCSSPageRule.mm:
1640         * DOM/DOMCSSPrimitiveValue.mm:
1641         * DOM/DOMCSSRule.mm:
1642         * DOM/DOMCSSStyleDeclaration.mm:
1643         * DOM/DOMCSSStyleRule.mm:
1644         * DOM/DOMCSSStyleSheet.mm:
1645         * DOM/DOMCSSValue.mm:
1646         * DOM/DOMCharacterData.mm:
1647         * DOM/DOMCounter.mm:
1648         * DOM/DOMDocument.mm:
1649         * DOM/DOMDocumentFragment.mm:
1650         * DOM/DOMDocumentType.mm:
1651         * DOM/DOMEvent.mm:
1652         * DOM/DOMFile.mm:
1653         * DOM/DOMHTMLAnchorElement.mm:
1654         * DOM/DOMHTMLAppletElement.mm:
1655         * DOM/DOMHTMLAreaElement.mm:
1656         * DOM/DOMHTMLBRElement.mm:
1657         * DOM/DOMHTMLBaseElement.mm:
1658         * DOM/DOMHTMLBaseFontElement.mm:
1659         * DOM/DOMHTMLBodyElement.mm:
1660         * DOM/DOMHTMLButtonElement.mm:
1661         * DOM/DOMHTMLCanvasElement.mm:
1662         * DOM/DOMHTMLCollection.mm:
1663         * DOM/DOMHTMLDivElement.mm:
1664         * DOM/DOMHTMLDocument.mm:
1665         * DOM/DOMHTMLElement.mm:
1666         * DOM/DOMHTMLEmbedElement.mm:
1667         * DOM/DOMHTMLFieldSetElement.mm:
1668         * DOM/DOMHTMLFontElement.mm:
1669         * DOM/DOMHTMLFormElement.mm:
1670         * DOM/DOMHTMLFrameElement.mm:
1671         * DOM/DOMHTMLFrameSetElement.mm:
1672         * DOM/DOMHTMLHRElement.mm:
1673         * DOM/DOMHTMLHeadElement.mm:
1674         * DOM/DOMHTMLHeadingElement.mm:
1675         * DOM/DOMHTMLHtmlElement.mm:
1676         * DOM/DOMHTMLIFrameElement.mm:
1677         * DOM/DOMHTMLImageElement.mm:
1678         * DOM/DOMHTMLInputElement.mm:
1679         * DOM/DOMHTMLLIElement.mm:
1680         * DOM/DOMHTMLLabelElement.mm:
1681         * DOM/DOMHTMLLegendElement.mm:
1682         * DOM/DOMHTMLLinkElement.mm:
1683         * DOM/DOMHTMLMapElement.mm:
1684         * DOM/DOMHTMLMarqueeElement.mm:
1685         * DOM/DOMHTMLMediaElement.mm:
1686         * DOM/DOMHTMLMetaElement.mm:
1687         * DOM/DOMHTMLModElement.mm:
1688         * DOM/DOMHTMLOListElement.mm:
1689         * DOM/DOMHTMLObjectElement.mm:
1690         * DOM/DOMHTMLOptGroupElement.mm:
1691         * DOM/DOMHTMLOptionElement.mm:
1692         * DOM/DOMHTMLOptionsCollection.mm:
1693         * DOM/DOMHTMLParagraphElement.mm:
1694         * DOM/DOMHTMLParamElement.mm:
1695         * DOM/DOMHTMLQuoteElement.mm:
1696         * DOM/DOMHTMLScriptElement.mm:
1697         * DOM/DOMHTMLSelectElement.mm:
1698         * DOM/DOMHTMLStyleElement.mm:
1699         * DOM/DOMHTMLTableCaptionElement.mm:
1700         * DOM/DOMHTMLTableCellElement.mm:
1701         * DOM/DOMHTMLTableColElement.mm:
1702         * DOM/DOMHTMLTableElement.mm:
1703         * DOM/DOMHTMLTableRowElement.mm:
1704         * DOM/DOMHTMLTableSectionElement.mm:
1705         * DOM/DOMHTMLTitleElement.mm:
1706         * DOM/DOMHTMLUListElement.mm:
1707         * DOM/DOMHTMLVideoElement.mm:
1708         * DOM/DOMKeyboardEvent.mm:
1709         * DOM/DOMMediaList.mm:
1710         * DOM/DOMMouseEvent.mm:
1711         * DOM/DOMMutationEvent.mm:
1712         * DOM/DOMNamedNodeMap.mm:
1713         * DOM/DOMProcessingInstruction.mm:
1714         * DOM/DOMRange.mm:
1715         * DOM/DOMStyleSheet.mm:
1716         * DOM/DOMText.mm:
1717         * DOM/DOMTextEvent.mm:
1718         * DOM/DOMTokenList.mm:
1719         * DOM/DOMUIEvent.mm:
1720         * DOM/DOMXPathResult.mm:
1721         * History/WebHistoryItem.mm:
1722         * Misc/WebNSURLExtras.mm:
1723         (-[NSURL _web_userVisibleString]):
1724         (-[NSURL _web_URLByRemovingUserInfo]):
1725         (-[NSURL _web_dataForURLComponentType:]):
1726         (-[NSURL _web_schemeData]):
1727         (-[NSURL _web_hostData]):
1728         * Misc/WebUserContentURLPattern.mm:
1729         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1730         * Plugins/WebNetscapePluginStream.h:
1731         (WebNetscapePluginStream::setRequestURL):
1732         * WebCoreSupport/WebChromeClient.h:
1733         * WebCoreSupport/WebChromeClient.mm:
1734         (WebChromeClient::signedPublicKeyAndChallengeString const):
1735         * WebCoreSupport/WebContextMenuClient.h:
1736         * WebCoreSupport/WebContextMenuClient.mm:
1737         * WebCoreSupport/WebDragClient.h:
1738         * WebCoreSupport/WebFrameLoaderClient.h:
1739         * WebCoreSupport/WebFrameLoaderClient.mm:
1740         (WebFrameLoaderClient::updateGlobalHistory):
1741         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1742         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1743         (WebPaymentCoordinatorClient::showPaymentUI):
1744         * WebCoreSupport/WebPlatformStrategies.h:
1745         * WebCoreSupport/WebPlatformStrategies.mm:
1746         (WebPlatformStrategies::readURLFromPasteboard):
1747         * WebCoreSupport/WebPluginInfoProvider.h:
1748         * WebCoreSupport/WebPluginInfoProvider.mm:
1749         (WebPluginInfoProvider::webVisiblePluginInfo):
1750         * WebCoreSupport/WebSecurityOrigin.mm:
1751         * WebCoreSupport/WebVisitedLinkStore.h:
1752         * WebView/WebDataSource.mm:
1753         * WebView/WebFrame.mm:
1754         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1755         * WebView/WebImmediateActionController.mm:
1756         (-[WebImmediateActionController _defaultAnimationController]):
1757         * WebView/WebPDFView.mm:
1758         * WebView/WebScriptDebugger.mm:
1759         * WebView/WebViewInternal.h:
1760
1761 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1762
1763         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1764         https://bugs.webkit.org/show_bug.cgi?id=192197
1765
1766         Reviewed by Jiewen Tan.
1767
1768         * Configurations/FeatureDefines.xcconfig:
1769         * WebCoreSupport/WebChromeClient.h:
1770         * WebCoreSupport/WebChromeClient.mm:
1771
1772 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1773
1774         Remove dead code from an earlier attempt at implementing safe browsing
1775         https://bugs.webkit.org/show_bug.cgi?id=192067
1776
1777         Reviewed by Chris Dumez.
1778
1779         * WebCoreSupport/WebFrameLoaderClient.h:
1780         * WebCoreSupport/WebFrameLoaderClient.mm:
1781         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1782
1783 2018-11-27  Mark Lam  <mark.lam@apple.com>
1784
1785         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1786         https://bugs.webkit.org/show_bug.cgi?id=192055
1787         <rdar://problem/46288783>
1788
1789         Reviewed by Saam Barati.
1790
1791         * Configurations/FeatureDefines.xcconfig:
1792
1793 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1794
1795         Make it possible to insert editable images with a gesture
1796         https://bugs.webkit.org/show_bug.cgi?id=191937
1797
1798         Reviewed by Wenson Hsieh.
1799
1800         * WebCoreSupport/WebEditorClient.mm:
1801         (undoNameForEditAction):
1802         Add a undo name.
1803
1804 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1805
1806         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1807         https://bugs.webkit.org/show_bug.cgi?id=191945
1808
1809         Reviewed by Anders Carlsson.
1810
1811         * WebCoreSupport/WebEditorClient.mm:
1812         (undoNameForEditAction):
1813
1814 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1815
1816         Enable drag and drop support for iOSMac
1817         https://bugs.webkit.org/show_bug.cgi?id=191818
1818         <rdar://problem/43907454>
1819
1820         Reviewed by Dean Jackson.
1821
1822         * Configurations/FeatureDefines.xcconfig:
1823
1824 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1825
1826         Address post-review feedback after r238438
1827         https://bugs.webkit.org/show_bug.cgi?id=191913
1828
1829         Reviewed by Ryosuke Niwa.
1830
1831         * WebView/WebFrame.mm:
1832         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1833         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1834         * WebView/WebView.mm:
1835         (-[WebView setSelectedDOMRange:affinity:]):
1836
1837 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1838
1839         Web Inspector: "Reload Web Inspector" button no longer partially works
1840         https://bugs.webkit.org/show_bug.cgi?id=191773
1841         <rdar://problem/46139932>
1842
1843         Reviewed by Devin Rousso.
1844
1845         * WebCoreSupport/WebInspectorClient.h:
1846         * WebCoreSupport/WebInspectorClient.mm:
1847         (WebInspectorFrontendClient::reopen):
1848
1849 2018-11-17  Devin Rousso  <drousso@apple.com>
1850
1851         Web Inspector: Network: add button to show system certificate dialog
1852         https://bugs.webkit.org/show_bug.cgi?id=191458
1853         <rdar://problem/45977019>
1854
1855         Reviewed by Joseph Pecoraro.
1856
1857         * WebCoreSupport/WebInspectorClient.h:
1858         * WebCoreSupport/WebInspectorClient.mm:
1859         (WebInspectorFrontendClient::showCertificate): Added.
1860
1861         * Configurations/WebKitLegacy.xcconfig:
1862
1863 2018-11-15  Truitt Savell  <tsavell@apple.com>
1864
1865         Unreviewed, rolling out r238244.
1866
1867         Caused High Sierra test runs to fail early with 50 crashes and
1868         casued 25 API failures.
1869
1870         Reverted changeset:
1871
1872         "[css-logical] Implement flow-relative margin, padding and
1873         border shorthands"
1874         https://bugs.webkit.org/show_bug.cgi?id=188697
1875         https://trac.webkit.org/changeset/238244
1876
1877 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1878
1879         [css-logical] Implement flow-relative margin, padding and border shorthands
1880         https://bugs.webkit.org/show_bug.cgi?id=188697
1881
1882         Reviewed by Simon Fraser and Antti Koivisto.
1883
1884         Add CSSLogicalEnabled runtime flag.
1885
1886         * WebView/WebPreferenceKeysPrivate.h:
1887         * WebView/WebPreferences.mm:
1888         (+[WebPreferences initialize]):
1889         (-[WebPreferences cssLogicalEnabled]):
1890         (-[WebPreferences setCSSLogicalEnabled:]):
1891         * WebView/WebPreferencesPrivate.h:
1892         * WebView/WebView.mm:
1893         (-[WebView _preferencesChanged:]):
1894
1895 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1896
1897         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1898         https://bugs.webkit.org/show_bug.cgi?id=191612
1899
1900         Reviewed by Matt Baker.
1901
1902         * WebCoreSupport/WebInspectorClient.mm:
1903         (-[WebInspectorWindowController destroyInspectorView]):
1904
1905 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1906
1907         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1908         https://bugs.webkit.org/show_bug.cgi?id=191494
1909         <rdar://problem/45469854>
1910
1911         Reviewed by Devin Rousso.
1912
1913         * WebCoreSupport/WebInspectorClient.h:
1914         WebKitLegacy will still have remote inspection of the Page directly.
1915
1916 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1917
1918         Make compositing updates incremental
1919         https://bugs.webkit.org/show_bug.cgi?id=90342
1920
1921         Reviewed by Antti Koivisto.
1922
1923         Fix spelling error.
1924
1925         * WebView/WebView.mm:
1926         (-[WebView _setMediaLayer:forPluginView:]):
1927
1928 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1929
1930         Implement a new edit command to change the enclosing list type
1931         https://bugs.webkit.org/show_bug.cgi?id=191487
1932         <rdar://problem/45955922>
1933
1934         Reviewed by Ryosuke Niwa.
1935
1936         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1937
1938         * WebCoreSupport/WebEditorClient.mm:
1939         (undoNameForEditAction):
1940
1941 2018-11-11  Daniel Bates  <dabates@apple.com>
1942
1943         [iOS] Draw caps lock indicator in password fields
1944         https://bugs.webkit.org/show_bug.cgi?id=190565
1945         <rdar://problem/45262343>
1946
1947         Reviewed by Dean Jackson.
1948
1949         Update the caps lock state when a hardware keyboard is attached or detached.
1950
1951         * WebView/WebHTMLView.mm:
1952         (hardwareKeyboardAvailabilityChangedCallback): Added.
1953         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1954         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1955
1956 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1957
1958         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1959         https://bugs.webkit.org/show_bug.cgi?id=191492
1960
1961         Reviewed by Alex Christensen.
1962
1963         * Carbon/HIWebView.mm:
1964         * Misc/WebNSFileManagerExtras.mm:
1965         * Misc/WebNSURLExtras.mm:
1966         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1967         * Plugins/WebBasePluginPackage.mm:
1968         * Plugins/WebPluginContainerCheck.mm:
1969         * WebCoreSupport/WebCachedFramePlatformData.h:
1970         * WebCoreSupport/WebDeviceOrientationClient.mm:
1971         * WebView/WebDelegateImplementationCaching.mm:
1972         * WebView/WebHTMLView.mm:
1973         * WebView/WebPDFRepresentation.mm:
1974         * WebView/WebPolicyDelegate.mm:
1975         * WebView/WebView.mm:
1976
1977 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1978
1979         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1980         https://bugs.webkit.org/show_bug.cgi?id=191492
1981
1982         Reviewed by Alex Christensen.
1983
1984         * Carbon/HIWebView.mm:
1985         (UpdateCommandStatus):
1986         * Misc/WebNSFileManagerExtras.mm:
1987         * Misc/WebNSURLExtras.mm:
1988         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1989         * Plugins/WebBasePluginPackage.mm:
1990         * Plugins/WebPluginContainerCheck.mm:
1991         (-[WebPluginContainerCheck _continueWithPolicy:]):
1992         * WebCoreSupport/WebCachedFramePlatformData.h:
1993         (WebCachedFramePlatformData::clear):
1994         * WebCoreSupport/WebDeviceOrientationClient.mm:
1995         (WebDeviceOrientationClient::getProvider const):
1996         * WebView/WebDelegateImplementationCaching.mm:
1997         (CallDelegate):
1998         (CallDelegateReturningBoolean):
1999         (CallResourceLoadDelegateReturningBoolean):
2000         (CallFormDelegate):
2001         (CallFormDelegateReturningBoolean):
2002         * WebView/WebHTMLView.mm:
2003         * WebView/WebPDFRepresentation.mm:
2004         * WebView/WebPolicyDelegate.mm:
2005         (-[WebPolicyDecisionListener _usePolicy:]):
2006         * WebView/WebView.mm:
2007
2008 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2009
2010         Unreviewed, rolling out r238047.
2011
2012         Introduced layout test failures on iOS simulator.
2013
2014         Reverted changeset:
2015
2016         "[iOS] Draw caps lock indicator in password fields"
2017         https://bugs.webkit.org/show_bug.cgi?id=190565
2018         https://trac.webkit.org/changeset/238047
2019
2020 2018-11-09  Antti Koivisto  <antti@apple.com>
2021
2022         Use OptionSet for layout milestones
2023         https://bugs.webkit.org/show_bug.cgi?id=191470
2024
2025         Reviewed by Dean Jackson.
2026
2027         * WebCoreSupport/WebFrameLoaderClient.h:
2028         * WebCoreSupport/WebFrameLoaderClient.mm:
2029         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2030         * WebView/WebView.mm:
2031         (coreLayoutMilestones):
2032         (kitLayoutMilestones):
2033         (-[WebView _cacheFrameLoadDelegateImplementations]):
2034         * WebView/WebViewInternal.h:
2035
2036 2018-11-09  Daniel Bates  <dabates@apple.com>
2037
2038         [iOS] Draw caps lock indicator in password fields
2039         https://bugs.webkit.org/show_bug.cgi?id=190565
2040         <rdar://problem/45262343>
2041
2042         Reviewed by Dean Jackson.
2043
2044         Update the caps lock state when a hardware keyboard is attached or detached.
2045
2046         * WebView/WebHTMLView.mm:
2047         (hardwareKeyboardAvailabilityChangedCallback): Added.
2048         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2049         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2050
2051 2018-11-09  Daniel Bates  <dabates@apple.com>
2052
2053         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2054         action when forward delete is pressed outside a text field
2055         https://bugs.webkit.org/show_bug.cgi?id=190566
2056         <rdar://problem/45262367>
2057
2058         Reviewed by Wenson Hsieh.
2059
2060         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2061         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2062         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2063
2064         * WebView/WebHTMLView.mm:
2065         (-[WebHTMLView _handleEditingKeyEvent:]):
2066
2067 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2068
2069         Adopt Reveal Framework to replace Lookup
2070         https://bugs.webkit.org/show_bug.cgi?id=191097
2071         <rdar://problem/45924508>
2072
2073         Reviewed by Tim Horton.
2074
2075         Pass in what it needed to clear the textIndicators. This is better than
2076         the current notification structure.
2077
2078         * WebView/WebView.mm:
2079         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2080         (-[WebView _prepareForDictionaryLookup]):
2081
2082 2018-11-06  Justin Fan  <justin_fan@apple.com>
2083
2084         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2085         https://bugs.webkit.org/show_bug.cgi?id=191291
2086
2087         Reviewed by Myles Maxfield.
2088
2089         Properly disable WEBGPU on all non-Metal platforms for now.
2090
2091         * Configurations/FeatureDefines.xcconfig:
2092
2093 2018-11-02  Daniel Bates  <dabates@apple.com>
2094
2095         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2096         https://bugs.webkit.org/show_bug.cgi?id=190487
2097
2098         Reviewed by Tim Horton.
2099
2100         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2101         allow the default handling.
2102
2103         * WebView/WebHTMLView.mm:
2104         (-[WebHTMLView _handleEditingKeyEvent:]):
2105
2106 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2107
2108         Add a storage limit for IndexedDB
2109         https://bugs.webkit.org/show_bug.cgi?id=190598
2110         <rdar://problem/44654715>
2111
2112         Reviewed by Chris Dumez.
2113
2114         * Storage/WebDatabaseManager.mm:
2115         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2116         * Storage/WebDatabaseManagerPrivate.h:
2117
2118 2018-10-31  Antti Koivisto  <antti@apple.com>
2119
2120         Remove LayerFlushScheduler
2121         https://bugs.webkit.org/show_bug.cgi?id=191103
2122
2123         Reviewed by Anders Carlsson.
2124
2125         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2126         all the virtual cruft.
2127
2128         * WebView/WebViewData.h:
2129         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2130         (): Deleted.
2131         * WebView/WebViewData.mm:
2132         (currentRunLoop):
2133         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2134         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2135         (WebViewLayerFlushScheduler::schedule):
2136         (WebViewLayerFlushScheduler::invalidate):
2137         (WebViewLayerFlushScheduler::layerFlushCallback):
2138
2139 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2140
2141         Enable InstallAPI for iOS unconditionally
2142         https://bugs.webkit.org/show_bug.cgi?id=191043
2143         rdar://problem/32728423
2144
2145         Reviewed by Dan Bernstein.
2146
2147         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2148         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2149         shouldn't be processed by InstallAPI.
2150         * MigrateHeaders.make: Removed an obsolete workaround.
2151         * Misc/NSURLDownloadSPI.h: Added.
2152         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2153
2154 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2155
2156         Clean up some obsolete MAX_ALLOWED macros
2157         https://bugs.webkit.org/show_bug.cgi?id=190916
2158
2159         Reviewed by Tim Horton.
2160
2161         * WebView/WebHTMLView.mm:
2162         (-[WebHTMLView pressureChangeWithEvent:]):
2163         * WebView/WebPDFView.h:
2164
2165 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2166
2167         Unreviewed, rolling out r237600 and r237604.
2168         https://bugs.webkit.org/show_bug.cgi?id=191086
2169
2170         Breaks internal iOS builds (Requested by ryanhadd_ on
2171         #webkit).
2172
2173         Reverted changesets:
2174
2175         "Enable InstallAPI for iOS unconditionally"
2176         https://bugs.webkit.org/show_bug.cgi?id=191043
2177         https://trac.webkit.org/changeset/237600
2178
2179         "Build fix attempt after enabling InstallAPI for iOS."
2180         https://bugs.webkit.org/show_bug.cgi?id=191043
2181         https://trac.webkit.org/changeset/237604
2182
2183 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2184
2185         Enable InstallAPI for iOS unconditionally
2186         https://bugs.webkit.org/show_bug.cgi?id=191043
2187         rdar://problem/32728423
2188
2189         Reviewed by Dan Bernstein.
2190
2191         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2192         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2193         shouldn't be processed by InstallAPI.
2194         * MigrateHeaders.make: Removed an obsolete workaround.
2195         * Misc/NSURLDownloadSPI.h: Added.
2196         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2197
2198 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2199
2200         Modernize WebKit nibs and lprojs for localization's sake
2201         https://bugs.webkit.org/show_bug.cgi?id=190911
2202         <rdar://problem/45349466>
2203
2204         Reviewed by Dan Bernstein.
2205
2206         * Misc/WebNSControlExtras.m:
2207         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2208         NSWindow and its contents are both in the same scale space these days; avoid
2209         double-applying the scale factor, or you can't see the prompt.
2210
2211         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2212         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2213         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2214         NIB->XIB
2215
2216 2018-10-25  Antoine Quint  <graouts@apple.com>
2217
2218         [Web Animations] Turn Web Animations CSS Integration off by default
2219         https://bugs.webkit.org/show_bug.cgi?id=190901
2220
2221         Reviewed by Dean Jackson.
2222
2223         * WebView/WebPreferences.mm:
2224         (+[WebPreferences initialize]):
2225
2226 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2227
2228         Clean up some obsolete macOS version guards
2229         https://bugs.webkit.org/show_bug.cgi?id=190887
2230
2231         Reviewed by Dan Bernstein.
2232
2233         * Misc/WebNSPasteboardExtras.mm:
2234         (+[NSPasteboard _web_dragTypesForURL]):
2235         * WebCoreSupport/PopupMenuMac.mm:
2236         (PopupMenuMac::show):
2237         * WebCoreSupport/WebEditorClient.h:
2238         * WebCoreSupport/WebEditorClient.mm:
2239         (WebEditorClient::respondToChangedSelection):
2240         * WebView/WebPDFView.mm:
2241         (-[WebPDFView _clipViewForPDFDocumentView]):
2242
2243 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2244
2245         Turn on Conic Gradients
2246         https://bugs.webkit.org/show_bug.cgi?id=190810
2247
2248         Reviewed by Tim Horton.
2249
2250         * Configurations/FeatureDefines.xcconfig:
2251
2252 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2253
2254         Cleanup: MIMETypeRegistry functions
2255         https://bugs.webkit.org/show_bug.cgi?id=190838
2256
2257         Reviewed by Simon Fraser.
2258
2259         * Misc/WebNSPasteboardExtras.mm:
2260         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2261         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2262         because they were identical.
2263
2264         * WebView/WebHTMLRepresentation.mm:
2265         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2266         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2267         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2268         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2269         * WebView/WebView.mm:
2270         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2271         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2272         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2273
2274 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2275
2276         Fix false positive leaks when using custom -init methods that don't start with -init
2277         <https://webkit.org/b/190818>
2278         <rdar://problem/45476042>
2279
2280         Reviewed by Dan Bernstein.
2281
2282         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2283         it is accessible by both categories.
2284         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2285         NSError (WebKitInternal) category.  Add attribute to make this
2286         behave like an -init method.
2287         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2288         NSError (WebKitInternal) category.  Modernize method.  Replace
2289         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2290
2291 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2292
2293         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2294         https://bugs.webkit.org/show_bug.cgi?id=190729
2295
2296         Reviewed by Tim Horton.
2297
2298         * DOM/DOM.mm:
2299         (-[DOMNode boundingBox]):
2300         * DOM/DOMElement.mm:
2301         * DOM/DOMHTML.mm:
2302         * DOM/DOMInternal.mm:
2303         * DOM/DOMUIKitExtensions.mm:
2304         * DOM/WebDOMOperations.mm:
2305         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2306         * DefaultDelegates/WebDefaultEditingDelegate.m:
2307         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2308         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2309         * DefaultDelegates/WebDefaultUIDelegate.h:
2310         * DefaultDelegates/WebDefaultUIDelegate.mm:
2311         (-[WebDefaultUIDelegate webViewClose:]):
2312         (-[WebDefaultUIDelegate webViewFocus:]):
2313         (-[WebDefaultUIDelegate webViewUnfocus:]):
2314         (-[WebDefaultUIDelegate webViewIsResizable:]):
2315         (-[WebDefaultUIDelegate webView:setResizable:]):
2316         (-[WebDefaultUIDelegate webView:setFrame:]):
2317         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2318         * History/BackForwardList.h:
2319         * History/BackForwardList.mm:
2320         * History/WebBackForwardList.mm:
2321         (+[WebBackForwardList initialize]):
2322         (bumperCarBackForwardHackNeeded):
2323         * History/WebHistory.mm:
2324         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2325         (-[WebHistory _sendNotification:entries:]):
2326         (-[WebHistory loadFromURL:error:]):
2327         (-[WebHistory saveToURL:error:]):
2328         * History/WebHistoryItem.mm:
2329         (WKNotifyHistoryItemChanged):
2330         (+[WebHistoryItem initialize]):
2331         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2332         * History/WebURLsWithTitles.m:
2333         * Misc/WebCache.mm:
2334         (+[WebCache initialize]):
2335         * Misc/WebDownload.mm:
2336         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2337         * Misc/WebElementDictionary.mm:
2338         (+[WebElementDictionary initialize]):
2339         (+[WebElementDictionary initializeLookupTable]):
2340         * Misc/WebIconDatabase.mm:
2341         * Misc/WebKitNSStringExtras.mm:
2342         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2343         * Misc/WebKitVersionChecks.h:
2344         * Misc/WebKitVersionChecks.mm:
2345         (WebKitLinkedOnOrAfter):
2346         (WebKitLinkTimeVersion):
2347         * Misc/WebLocalizableStrings.mm:
2348         * Misc/WebNSControlExtras.h:
2349         * Misc/WebNSControlExtras.m:
2350         * Misc/WebNSEventExtras.m:
2351         * Misc/WebNSFileManagerExtras.mm:
2352         * Misc/WebNSImageExtras.h:
2353         * Misc/WebNSImageExtras.m:
2354         * Misc/WebNSPasteboardExtras.mm:
2355         * Misc/WebNSPrintOperationExtras.h:
2356         * Misc/WebNSPrintOperationExtras.m:
2357         * Misc/WebNSViewExtras.m:
2358         * Misc/WebNSWindowExtras.m:
2359         * Panels/WebAuthenticationPanel.h:
2360         * Panels/WebAuthenticationPanel.m:
2361         * Panels/WebPanelAuthenticationHandler.m:
2362         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2363         (+[WebHostedNetscapePluginView initialize]):
2364         * Plugins/WebBasePluginPackage.h:
2365         * Plugins/WebBasePluginPackage.mm:
2366         * Plugins/WebJavaPlugIn.h:
2367         * Plugins/WebPluginContainerCheck.mm:
2368         * Plugins/WebPluginController.h:
2369         * Plugins/WebPluginController.mm:
2370         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2371         (-[WebPluginController addPlugin:]):
2372         (-[WebPluginController destroyPlugin:]):
2373         (-[WebPluginController destroyAllPlugins]):
2374         * Plugins/WebPluginDatabase.mm:
2375         (+[WebPluginDatabase _defaultPlugInPaths]):
2376         * Plugins/WebPluginPackage.mm:
2377         (-[WebPluginPackage initWithPath:]):
2378         * Storage/WebDatabaseManager.mm:
2379         (-[WebDatabaseManager deleteAllDatabases]):
2380         * Storage/WebDatabaseManagerClient.h:
2381         * Storage/WebDatabaseManagerClient.mm:
2382         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2383         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2384         * Storage/WebStorageManager.mm:
2385         (-[WebStorageManager deleteAllOrigins]):
2386         (WebKitInitializeStorageIfNecessary):
2387         * WebCoreSupport/WebAlternativeTextClient.h:
2388         * WebCoreSupport/WebApplicationCache.mm:
2389         (applicationCacheBundleIdentifier):
2390         * WebCoreSupport/WebChromeClient.h:
2391         * WebCoreSupport/WebChromeClient.mm:
2392         (WebChromeClient::setWindowRect):
2393         (WebChromeClient::windowRect):
2394         (WebChromeClient::takeFocus):
2395         (WebChromeClient::addMessageToConsole):
2396         (WebChromeClient::enableSuddenTermination):
2397         (WebChromeClient::disableSuddenTermination):
2398         (WebChromeClient::createPopupMenu const):
2399         (WebChromeClient::createSearchPopupMenu const):
2400         (WebChromeClient::shouldPaintEntireContents const):
2401         (WebChromeClient::supportsVideoFullscreen):
2402         (WebChromeClient::supportsFullScreenForElement):
2403         (WebChromeClient::enterFullScreenForElement):
2404         (WebChromeClient::exitFullScreenForElement):
2405         * WebCoreSupport/WebContextMenuClient.mm:
2406         * WebCoreSupport/WebDragClient.mm:
2407         * WebCoreSupport/WebEditorClient.h:
2408         * WebCoreSupport/WebEditorClient.mm:
2409         (+[WebUndoStep initialize]):
2410         (updateFontPanel):
2411         (WebEditorClient::didBeginEditing):
2412         (WebEditorClient::respondToChangedContents):
2413         (WebEditorClient::respondToChangedSelection):
2414         (WebEditorClient::canceledComposition):
2415         (WebEditorClient::didEndEditing):
2416         (WebEditorClient::didWriteSelectionToPasteboard):
2417         (attributesForAttributedStringConversion):
2418         (WebEditorClient::setInsertionPasteboard):
2419         (WebEditorClient::registerUndoOrRedoStep):
2420         (WebEditorClient::handleKeyboardEvent):
2421         (WebEditorClient::handleInputMethodKeydown):
2422         (WebEditorClient::textDidChangeInTextField):
2423         (WebEditorClient::requestCheckingOfString):
2424         * WebCoreSupport/WebFrameLoaderClient.h:
2425         * WebCoreSupport/WebFrameLoaderClient.mm:
2426         (WebFrameLoaderClient::detachedFromParent2):
2427         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2428         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2429         (WebFrameLoaderClient::dispatchWillSendRequest):
2430         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2431         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2432         (WebFrameLoaderClient::willCacheResponse const):
2433         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2434         (WebFrameLoaderClient::dispatchDidFinishLoading):
2435         (WebFrameLoaderClient::dispatchDidFailLoading):
2436         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2437         (WebFrameLoaderClient::dispatchWillClose):
2438         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2439         (WebFrameLoaderClient::dispatchDidCommitLoad):
2440         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2441         (WebFrameLoaderClient::dispatchDidFailLoad):
2442         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2443         (WebFrameLoaderClient::dispatchDidFinishLoad):
2444         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2445         (WebFrameLoaderClient::willChangeTitle):
2446         (WebFrameLoaderClient::didChangeTitle):
2447         (WebFrameLoaderClient::didReplaceMultipartContent):
2448         (WebFrameLoaderClient::updateGlobalHistory):
2449         (WebFrameLoaderClient::saveViewStateToItem):
2450         (WebFrameLoaderClient::restoreViewState):
2451         (WebFrameLoaderClient::provisionalLoadStarted):
2452         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2453         (WebFrameLoaderClient::setTitle):
2454         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2455         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2456         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2457         (WebFrameLoaderClient::didRestoreFromPageCache):
2458         (WebFrameLoaderClient::actionDictionary const):
2459         (WebFrameLoaderClient::createPlugin):
2460         (WebFrameLoaderClient::getLoadDecisionForIcons):
2461         (WebFrameLoaderClient::finishedLoadingIcon):
2462         (+[WebFramePolicyListener initialize]):
2463         * WebCoreSupport/WebFrameNetworkingContext.mm:
2464         * WebCoreSupport/WebGeolocationClient.h:
2465         * WebCoreSupport/WebGeolocationClient.mm:
2466         (WebGeolocationClient::requestPermission):
2467         * WebCoreSupport/WebInspectorClient.h:
2468         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2469         * WebCoreSupport/WebNotificationClient.mm:
2470         * WebCoreSupport/WebOpenPanelResultListener.mm:
2471         * WebCoreSupport/WebPlatformStrategies.h:
2472         * WebCoreSupport/WebPlatformStrategies.mm:
2473         * WebCoreSupport/WebProgressTrackerClient.h:
2474         * WebCoreSupport/WebProgressTrackerClient.mm:
2475         (WebProgressTrackerClient::progressStarted):
2476         (WebProgressTrackerClient::progressEstimateChanged):
2477         (WebProgressTrackerClient::progressFinished):
2478         * WebCoreSupport/WebSecurityOrigin.mm:
2479         * WebInspector/WebNodeHighlight.h:
2480         * WebInspector/WebNodeHighlight.mm:
2481         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2482         (-[WebNodeHighlight dealloc]):
2483         (-[WebNodeHighlight attach]):
2484         * WebInspector/WebNodeHighlightView.h:
2485         * WebInspector/WebNodeHighlightView.mm:
2486         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2487         (-[WebNodeHighlightView dealloc]):
2488         * WebInspector/WebNodeHighlighter.mm:
2489         (-[WebNodeHighlighter highlight]):
2490         * WebView/WebArchive.mm:
2491         (+[WebArchivePrivate initialize]):
2492         * WebView/WebClipView.h:
2493         * WebView/WebDataSource.mm:
2494         (WebDataSourcePrivate::WebDataSourcePrivate):
2495         (+[WebDataSource initialize]):
2496         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2497         (-[WebDataSource _makeRepresentation]):
2498         * WebView/WebDelegateImplementationCaching.h:
2499         * WebView/WebDelegateImplementationCaching.mm:
2500         (CallDelegate):
2501         (CallDelegateReturningFloat):
2502         (CallDelegateReturningBoolean):
2503         (CallUIDelegate):
2504         (CallUIDelegateReturningFloat):
2505         (CallUIDelegateReturningBoolean):
2506         (CallFrameLoadDelegate):
2507         (CallFrameLoadDelegateReturningBoolean):
2508         (CallResourceLoadDelegate):
2509         (CallScriptDebugDelegate):
2510         (CallFormDelegate):
2511         (CallFormDelegateReturningBoolean):
2512         * WebView/WebDeviceOrientation.mm:
2513         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2514         * WebView/WebDocumentInternal.h:
2515         * WebView/WebDocumentLoaderMac.mm:
2516         (needsDataLoadWorkaround):
2517         * WebView/WebDynamicScrollBarsViewInternal.h:
2518         * WebView/WebFormDelegate.m:
2519         * WebView/WebFrame.mm:
2520         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2521         (-[WebFrame _unmarkAllMisspellings]):
2522         (-[WebFrame _paintBehaviorForDestinationContext:]):
2523         (-[WebFrame _drawRect:contentsOnly:]):
2524         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2525         (-[WebFrame _scrollDOMRangeToVisible:]):
2526         (-[WebFrame _bodyBackgroundColor]):
2527         (-[WebFrame accessibilityRoot]):
2528         (needsMicrosoftMessengerDOMDocumentWorkaround):
2529         * WebView/WebFrameInternal.h:
2530         * WebView/WebFrameView.mm:
2531         (-[WebFrameView _setDocumentView:]):
2532         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2533         (-[WebFrameView _viewClassForMIMEType:]):
2534         (-[WebFrameView initWithFrame:]):
2535         (-[WebFrameView drawRect:]):
2536         (-[WebFrameView _firstResponderIsFormControl]):
2537         (-[WebFrameView keyDown:keyDown:]):
2538         (-[WebFrameView _isScrollable]):
2539         * WebView/WebFullScreenController.h:
2540         * WebView/WebFullScreenController.mm:
2541         * WebView/WebHTMLRepresentation.mm:
2542         * WebView/WebHTMLView.mm:
2543         (-[WebHTMLView hitTest:]):
2544         (-[WebHTMLView initWithFrame:]):
2545         (-[WebHTMLView dealloc]):
2546         (-[WebHTMLView addSubview:]):
2547         (-[WebHTMLView mouseDown:]):
2548         (-[WebHTMLView mouseUp:]):
2549         (-[WebHTMLView resignFirstResponder]):
2550         (-[WebHTMLView accessibilityHitTest:]):
2551         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2552         * WebView/WebHTMLViewInternal.h:
2553         * WebView/WebIndicateLayer.h:
2554         * WebView/WebIndicateLayer.mm:
2555         * WebView/WebMediaPlaybackTargetPicker.h:
2556         * WebView/WebMediaPlaybackTargetPicker.mm:
2557         * WebView/WebPDFDocumentExtras.h:
2558         * WebView/WebPDFDocumentExtras.mm:
2559         * WebView/WebPDFRepresentation.h:
2560         * WebView/WebPDFRepresentation.mm:
2561         * WebView/WebPDFView.h:
2562         * WebView/WebPreferences.mm:
2563         (cacheModelForMainBundle):
2564         (WebPreferencesPrivate::WebPreferencesPrivate):
2565         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2566         (-[WebPreferences encodeWithCoder:]):
2567         (+[WebPreferences standardPreferences]):
2568         (+[WebPreferences initialize]):
2569         (-[WebPreferences _valueForKey:]):
2570         (-[WebPreferences _setStringValue:forKey:]):
2571         (-[WebPreferences _setIntegerValue:forKey:]):
2572         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2573         (-[WebPreferences _setFloatValue:forKey:]):
2574         (-[WebPreferences _setBoolValue:forKey:]):
2575         (-[WebPreferences _setLongLongValue:forKey:]):
2576         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2577         (-[WebPreferences _postCacheModelChangedNotification]):
2578         (-[WebPreferences _postPreferencesChangedNotification]):
2579         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2580         (-[WebPreferences setStorageBlockingPolicy:]):
2581         * WebView/WebResource.mm:
2582         (+[WebResourcePrivate initialize]):
2583         * WebView/WebTextCompletionController.h:
2584         * WebView/WebTextIterator.mm:
2585         (+[WebTextIteratorPrivate initialize]):
2586         * WebView/WebView.mm:
2587         (shouldEnableLoadDeferring):
2588         (shouldRestrictWindowFocus):
2589         (shouldRespectPriorityInCSSAttributeSetters):
2590         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2591         (shouldAllowPictureInPictureMediaPlayback):
2592         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2593         (shouldAllowWindowOpenWithoutUserGesture):
2594         (shouldConvertInvalidURLsToBlank):
2595         (shouldRequireUserGestureToLoadVideo):
2596         (-[WebView _commonInitializationWithFrameName:groupName:]):
2597         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2598         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2599         (-[WebView _closePluginDatabases]):
2600         (-[WebView _closeWithFastTeardown]):
2601         (-[WebView _close]):
2602         (+[WebView _MIMETypeForFile:]):
2603         (-[WebView setShowingInspectorIndication:]):
2604         (-[WebView _setFormDelegate:]):
2605         (-[WebView _needsPreHTML5ParserQuirks]):
2606         (-[WebView _preferencesChangedNotification:]):
2607         (-[WebView _preferencesChanged:]):
2608         (-[WebView _cacheResourceLoadDelegateImplementations]):
2609         (-[WebView _cacheFrameLoadDelegateImplementations]):
2610         (-[WebView _policyDelegateForwarder]):
2611         (-[WebView _UIDelegateForwarder]):
2612         (-[WebView _editingDelegateForwarder]):
2613         (-[WebView _updateActiveState]):
2614         (-[_WebSafeForwarder forwardInvocation:]):
2615         (+[WebView initialize]):
2616         (-[WebView _pluginForMIMEType:]):
2617         (-[WebView _pluginForExtension:]):
2618         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2619         (+[WebView canShowMIMETypeAsHTML:]):
2620         (-[WebView _initWithArguments:]):
2621         (-[WebView initWithFrame:frameName:groupName:]):
2622         (-[WebView dealloc]):
2623         (-[WebView close]):
2624         (-[WebView viewDidMoveToWindow]):
2625         (-[WebView setUIDelegate:]):
2626         (-[WebView setResourceLoadDelegate:]):
2627         (-[WebView setPolicyDelegate:]):
2628         (-[WebView setFrameLoadDelegate:]):
2629         (-[WebView goBack]):
2630         (-[WebView goForward]):
2631         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2632         (-[WebView setHostWindow:]):
2633         (-[WebView becomeFirstResponder]):
2634         (+[WebView _cacheModelChangedNotification:]):
2635         (-[WebView _frameViewAtWindowPoint:]):
2636         (+[WebView _preflightSpellCheckerNow:]):
2637         (+[WebView _preflightSpellChecker]):
2638         (-[WebView canGoBack]):
2639         (-[WebView canGoForward]):
2640         (-[WebView stopLoading:]):
2641         (-[WebView reload:]):
2642         (-[WebView setMainFrameDocumentReady:]):
2643         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2644         (-[WebView setContinuousSpellCheckingEnabled:]):
2645         (-[WebView undoManager]):
2646         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2647         (-[WebView isAutomaticLinkDetectionEnabled]):
2648         (-[WebView isAutomaticDashSubstitutionEnabled]):
2649         (-[WebView isAutomaticTextReplacementEnabled]):
2650         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2651         (+[WebView _setCacheModel:]):
2652         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2653         (-[WebView _keyboardUIMode]):
2654         (LayerFlushController::flushLayers):
2655         (-[WebView _scheduleCompositingLayerFlush]):
2656         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2657         (-[WebView fullScreenPlaceholderView]):
2658         (WebInstallMemoryPressureHandler):
2659         * WebView/WebViewData.h:
2660         * WebView/WebViewData.mm:
2661         (+[WebViewPrivate initialize]):
2662         (-[WebViewPrivate init]):
2663         (-[WebViewPrivate dealloc]):
2664         * WebView/WebViewInternal.h:
2665
2666 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2667
2668         Clean up FrameLoader two-state enums
2669         https://bugs.webkit.org/show_bug.cgi?id=190731
2670
2671         Reviewed by Chris Dumez.
2672
2673         * WebCoreSupport/WebFrameLoaderClient.h:
2674         * WebCoreSupport/WebFrameLoaderClient.mm:
2675         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2676
2677 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2678
2679         Unreviewed, rolling out r237137.
2680
2681         SPI is actually used
2682
2683         Reverted changeset:
2684
2685         "Remove unused WebFrame._loadType"
2686         https://bugs.webkit.org/show_bug.cgi?id=190583
2687         https://trac.webkit.org/changeset/237137
2688
2689 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2690
2691         Enable the datalist element by default on iOS and macOS
2692         https://bugs.webkit.org/show_bug.cgi?id=190594
2693         <rdar://problem/45281159>
2694
2695         Reviewed by Ryosuke Niwa and Tim Horton.
2696
2697         * Configurations/FeatureDefines.xcconfig:
2698
2699 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2700
2701         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2702         https://bugs.webkit.org/show_bug.cgi?id=190675
2703
2704         Reviewed by Chris Dumez.
2705
2706         * History/BackForwardList.h:
2707         * History/BackForwardList.mm:
2708         (BackForwardList::backItem):
2709         (BackForwardList::currentItem):
2710         (BackForwardList::forwardItem):
2711         (BackForwardList::backListCount const):
2712         (BackForwardList::forwardListCount const):
2713         (BackForwardList::itemAtIndex):
2714         * History/WebBackForwardList.mm:
2715         (-[WebBackForwardList backItem]):
2716         (-[WebBackForwardList currentItem]):
2717         (-[WebBackForwardList forwardItem]):
2718         (-[WebBackForwardList itemAtIndex:]):
2719
2720 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2721
2722         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2723         https://bugs.webkit.org/show_bug.cgi?id=190526
2724         rdar://problem/45230140
2725
2726         Reviewed by Dean Jackson.
2727
2728         * WebCoreSupport/WebEditorClient.mm:
2729         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2730
2731 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2732
2733         Implement feature flag and bindings for CSS Painting API
2734         https://bugs.webkit.org/show_bug.cgi?id=190237
2735
2736         Reviewed by Ryosuke Niwa.
2737
2738         * Configurations/FeatureDefines.xcconfig:
2739
2740 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2741
2742         Replace HistoryItem* with HistoryItem& where possible
2743         https://bugs.webkit.org/show_bug.cgi?id=190617
2744
2745         Reviewed by Chris Dumez.
2746
2747         * History/BackForwardList.h:
2748         * History/BackForwardList.mm:
2749         (BackForwardList::goToItem):
2750         * History/WebBackForwardList.mm:
2751         (-[WebBackForwardList goToItem:]):
2752         * History/WebHistoryItem.mm:
2753         (WKNotifyHistoryItemChanged):
2754         * History/WebHistoryItemInternal.h:
2755
2756 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2757
2758         Remove unused WebHistoryItem._transientPropertyForKey
2759         https://bugs.webkit.org/show_bug.cgi?id=190606
2760
2761         Reviewed by Chris Dumez.
2762
2763         * History/WebHistoryItem.mm:
2764         * History/WebHistoryItemPrivate.h:
2765
2766 2018-10-15  Justin Fan  <justin_fan@apple.com>
2767
2768         Add WebGPU 2018 feature flag and experimental feature flag
2769         https://bugs.webkit.org/show_bug.cgi?id=190509
2770
2771         Reviewed by Dean Jackson.
2772
2773         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2774         for the 2018 WebGPU prototype.
2775
2776         * Configurations/FeatureDefines.xcconfig:
2777         * WebView/WebPreferenceKeysPrivate.h:
2778         * WebView/WebPreferences.mm:
2779         (+[WebPreferences initialize]):
2780         (-[WebPreferences webGPUEnabled]):
2781         (-[WebPreferences setWebGPUEnabled:]):
2782         * WebView/WebPreferencesPrivate.h:
2783         * WebView/WebView.mm:
2784         (-[WebView _preferencesChanged:]):
2785
2786 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2787
2788         Fix iOS build after r237157
2789
2790         * WebView/WebView.mm:
2791         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2792
2793 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2794
2795         Modernize BackForwardClient.h
2796         https://bugs.webkit.org/show_bug.cgi?id=190610
2797
2798         Reviewed by Chris Dumez.
2799
2800         * History/BackForwardList.h:
2801         * History/BackForwardList.mm:
2802         (BackForwardList::backListCount const):
2803         (BackForwardList::forwardListCount const):
2804         (BackForwardList::backListCount): Deleted.
2805         (BackForwardList::forwardListCount): Deleted.
2806         * History/WebBackForwardList.mm:
2807         (-[WebBackForwardList init]):
2808         * WebCoreSupport/WebFrameLoaderClient.mm:
2809         (WebFrameLoaderClient::canCachePage const):
2810         * WebView/WebFrameView.mm:
2811         (-[WebFrameView keyDown:keyDown:]):
2812         * WebView/WebView.mm:
2813         (-[WebView _commonInitializationWithFrameName:groupName:]):
2814         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2815         (-[WebView _loadBackForwardListFromOtherView:]):
2816         (-[WebView initWithCoder:]):
2817         (-[WebView encodeWithCoder:]):
2818         (-[WebView backForwardList]):
2819         (-[WebView setMaintainsBackForwardList:]):
2820
2821 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2822
2823         Add support for prefers-color-scheme media query
2824         https://bugs.webkit.org/show_bug.cgi?id=190499
2825         rdar://problem/45212025
2826
2827         Reviewed by Dean Jackson.
2828
2829         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2830
2831 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2832
2833         Remove unused WebView._globalHistoryItem
2834         https://bugs.webkit.org/show_bug.cgi?id=190601
2835
2836         Reviewed by Chris Dumez.
2837
2838         * WebCoreSupport/WebFrameLoaderClient.h:
2839         * WebCoreSupport/WebFrameLoaderClient.mm:
2840         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2841         * WebView/WebView.mm:
2842         (-[WebView _globalHistoryItem]): Deleted.
2843         (-[WebView _setGlobalHistoryItem:]): Deleted.
2844         * WebView/WebViewData.h:
2845         * WebView/WebViewInternal.h:
2846         * WebView/WebViewPrivate.h:
2847
2848 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2849
2850         Remove unused parameters from FrameLoaderClient::createFrame
2851         https://bugs.webkit.org/show_bug.cgi?id=190587
2852
2853         Reviewed by Chris Dumez.
2854
2855         * WebCoreSupport/WebFrameLoaderClient.h:
2856         * WebCoreSupport/WebFrameLoaderClient.mm:
2857         (WebFrameLoaderClient::createFrame):
2858
2859 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2860
2861         Remove unused WebFrame._loadType
2862         https://bugs.webkit.org/show_bug.cgi?id=190583
2863
2864         Reviewed by Chris Dumez.
2865
2866         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2867
2868         * WebView/WebFrame.mm:
2869         (toWebFrameLoadType): Deleted.
2870         (-[WebFrame _loadType]): Deleted.
2871         * WebView/WebFramePrivate.h:
2872
2873 2018-10-15  Chris Dumez  <cdumez@apple.com>
2874
2875         Restrict browsing context lookup by name to frames that are related to one another
2876         https://bugs.webkit.org/show_bug.cgi?id=190475
2877
2878         Reviewed by Alex Christensen.
2879
2880         * WebView/WebFrame.mm:
2881         (-[WebFrame findFrameNamed:]):
2882
2883 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2884
2885         Remove InjectedBundle processing of back/forward lists
2886         https://bugs.webkit.org/show_bug.cgi?id=190459
2887
2888         Reviewed by Chris Dumez.
2889
2890         * WebCoreSupport/WebFrameLoaderClient.h:
2891         * WebCoreSupport/WebFrameLoaderClient.mm:
2892         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2893
2894 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2895
2896         [JSC] Remove Option::useAsyncIterator
2897         https://bugs.webkit.org/show_bug.cgi?id=190567
2898
2899         Reviewed by Saam Barati.
2900
2901         * Configurations/FeatureDefines.xcconfig:
2902
2903 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2904
2905         Allow encoding of small enum classes
2906         https://bugs.webkit.org/show_bug.cgi?id=190531
2907
2908         Reviewed by Tim Horton.
2909
2910         * WebCoreSupport/WebFrameLoaderClient.mm:
2911         (-[WebFramePolicyListener dealloc]):
2912
2913 2018-10-11  Keith Rollin  <krollin@apple.com>
2914
2915         CURRENT_ARCH should not be used in Run Script phase.
2916         https://bugs.webkit.org/show_bug.cgi?id=190407
2917         <rdar://problem/45133556>
2918
2919         Reviewed by Alexey Proskuryakov.
2920
2921         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2922         CURRENT_ARCH is not well-defined during this phase (and may even have
2923         the value "undefined") since this phase is run just once per build
2924         rather than once per supported architecture. Migrate away from
2925         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2926         performing an operation for each value, or by picking the first entry
2927         in ARCHS and using that as a representative value.
2928
2929         * Configurations/WebKitLegacy.xcconfig: When generating
2930         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2931         macosx platforms.
2932
2933         * MigrateHeaders.make:
2934         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2935         generate one for each architecture in ARCHS.
2936
2937 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2938
2939         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2940         https://bugs.webkit.org/show_bug.cgi?id=190429
2941
2942         Reviewed by Saam Barati.
2943
2944         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2945
2946         * WebView/WebPDFRepresentation.mm:
2947         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2948
2949 2018-10-08  Justin Fan  <justin_fan@apple.com>
2950
2951         WebGPU: Rename old WebGPU prototype to WebMetal
2952         https://bugs.webkit.org/show_bug.cgi?id=190325
2953         <rdar://problem/44990443>
2954
2955         Reviewed by Dean Jackson.
2956
2957         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2958
2959         * Configurations/FeatureDefines.xcconfig:
2960         * WebView/WebPreferenceKeysPrivate.h:
2961         * WebView/WebPreferences.mm:
2962         (+[WebPreferences initialize]):
2963         (-[WebPreferences webMetalEnabled]):
2964         (-[WebPreferences setWebMetalEnabled:]):
2965         (-[WebPreferences webGPUEnabled]): Deleted.
2966         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2967         * WebView/WebPreferencesPrivate.h:
2968         * WebView/WebView.mm:
2969         (-[WebView _preferencesChanged:]):
2970
2971 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2972
2973         Make <input type=color> a runtime enabled (on-by-default) feature
2974         https://bugs.webkit.org/show_bug.cgi?id=189162
2975
2976         Reviewed by Wenson Hsieh and Tim Horton.
2977
2978         * Configurations/FeatureDefines.xcconfig:
2979
2980 2018-10-07  Dan Bernstein  <mitz@apple.com>
2981
2982         Fixed building with the latest macOS SDK
2983
2984         * Plugins/WebNetscapePluginPackage.mm:
2985         (-[WebNetscapePluginPackage openResourceFile]):
2986         (-[WebNetscapePluginPackage closeResourceFile:]):
2987
2988 2018-10-04  Dan Bernstein  <mitz@apple.com>
2989
2990         More Carbon build-fixing.
2991
2992         * Carbon/CarbonWindowAdapter.mm:
2993         (-[CarbonWindowAdapter _destroyRealWindow:]):
2994         (-[CarbonWindowAdapter _growBoxRect]):
2995
2996 2018-10-04  Dan Bernstein  <mitz@apple.com>
2997
2998         Retried to fix 32-bit macOS builds after r236846.
2999
3000         * WebView/WebHTMLView.mm:
3001         (-[WebHTMLView setMarkedText:selectedRange:]):
3002
3003 2018-10-04  Dan Bernstein  <mitz@apple.com>
3004
3005         Retried to fix 32-bit macOS builds after r236846.
3006
3007         * Carbon/HIWebView.mm:
3008         (ActiveStateChanged):
3009
3010 2018-10-04  Dan Bernstein  <mitz@apple.com>
3011
3012         Tried to fix 32-bit macOS builds after r236846.
3013
3014         * Carbon/HIWebView.mm:
3015         (_NSSelectorForHICommand):
3016
3017 2018-10-04  Dan Bernstein  <mitz@apple.com>
3018
3019         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3020         https://bugs.webkit.org/show_bug.cgi?id=190250
3021
3022         Reviewed by Andy Estes.
3023
3024         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3025           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3026           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3027           an earlier line set it to YES.
3028
3029         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3030         changes below.
3031
3032         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3033           provides some missing method declarations.
3034
3035         * Misc/WebDownload.mm:
3036         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3037           a deprecated method.
3038
3039         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3040
3041         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3042           other code in the file uses a method from it.
3043
3044         * Plugins/WebBaseNetscapePluginView.mm:
3045         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3046           a deprecated method.
3047
3048         * Plugins/WebPluginController.mm:
3049         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3050           around use of a selector that may be present in some WebKit client.
3051
3052         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3053           method declarations.
3054
3055         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3056           from here.
3057
3058         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3059           missing method declarations.
3060
3061         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3062           from here.
3063
3064         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3065           call from here.
3066         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3067           an obsolete delegate method for binary compatibility.
3068         (pluginView): Ditto.
3069
3070         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3071           call from here.
3072
3073         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3074           WebDeviceOrientationProviderMock protocol.
3075
3076         * WebView/WebDeviceOrientationProviderMock.mm:
3077         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3078           main @implementation.
3079
3080         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3081           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3082
3083         * WebView/WebDynamicScrollBarsView.mm:
3084         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3085           of a deprecated method.
3086
3087         * WebView/WebHTMLView.mm:
3088         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3089           selector warning around action methods that are not declared anywhere in WebKit.
3090
3091         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3092           about implementing this deprecated method.
3093         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3094         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3095         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3096         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3097         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3098         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3099         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3100         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3101         (-[WebHTMLView doCommandBySelector:]): Ditto.
3102         (-[WebHTMLView insertText:]): Ditto.
3103
3104         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3105
3106         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3107
3108         * WebView/WebPDFView.h: Removed previewView ivar.
3109
3110         * WebView/WebPDFView.mm:
3111           Removed declaration of FileInternal category and merged its implementation with the main
3112           implementation.
3113         (-[WebPDFView dealloc]): Removed previewView ivar.
3114         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3115           exist in macOS versions we support.
3116         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3117         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3118           action methods internal to PDFKit.
3119         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3120         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3121
3122         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3123           call on macOS, even though in r86988 we started calling different methods on iOS.
3124
3125         * WebView/WebView.mm:
3126         - Imported headers that declare delegate methods that we call.
3127         - Removed declaration of WebFileInternal category and merged its implementation with the
3128           main implementation.
3129         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3130           category, which made them impossible to call from the main implementation. Moved those
3131           into the main implementation. One of those had to be declared in a class extension,
3132           because it is called from a method implemented in the WebPrivate category, and that
3133           category’s implementation appears first in the file.
3134
3135         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3136           around use of obsolete delegate method for binary compatibility.
3137
3138         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3139
3140 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3141
3142         Runtime flag and IDL for MediaRecorder
3143         https://bugs.webkit.org/show_bug.cgi?id=190018
3144
3145         Reviewed by Youenn Fablet and Chris Dumez.
3146
3147         * WebView/WebPreferenceKeysPrivate.h:
3148         * WebView/WebPreferences.mm:
3149         (+[WebPreferences initialize]):
3150         (-[WebPreferences mediaRecorderEnabled]):
3151         (-[WebPreferences setMediaRecorderEnabled:]):
3152         * WebView/WebPreferencesPrivate.h:
3153         * WebView/WebView.mm:
3154         (-[WebView _preferencesChanged:]):
3155
3156 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3157
3158         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3159         https://bugs.webkit.org/show_bug.cgi?id=190238
3160
3161         Reviewed by Antti Koivisto.
3162
3163         Enabled the feature by default.
3164
3165         * WebView/WebPreferences.mm:
3166         (+[WebPreferences initialize]):
3167
3168 2018-10-01  Dean Jackson  <dino@apple.com>
3169
3170         [macOS] Switching to discrete GPU should be done in the UI process
3171         https://bugs.webkit.org/show_bug.cgi?id=189361
3172         <rdar://problem/43949622>
3173
3174         Reviewed by Simon Fraser.
3175
3176         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3177         not support swapping to the discrete GPU in this configuration.
3178
3179         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3180         (WebKit::WebSwitchingGPUClient::singleton):
3181         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3182         * WebView/WebView.mm:
3183         (-[WebView _commonInitializationWithFrameName:groupName:]):
3184
3185 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3186
3187         Remove ParsedURLString
3188         https://bugs.webkit.org/show_bug.cgi?id=190154
3189
3190         Reviewed by Chris Dumez.
3191
3192         * WebView/WebScriptDebugger.mm:
3193         (toNSURL):
3194
3195 2018-10-01  Dean Jackson  <dino@apple.com>
3196
3197         Remove CSS Animation Triggers
3198         https://bugs.webkit.org/show_bug.cgi?id=190175
3199         <rdar://problem/44925626>
3200
3201         Reviewed by Simon Fraser.
3202
3203         * Configurations/FeatureDefines.xcconfig:
3204
3205 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3206
3207         Unreviewed, rolling out r236624 and r236671.
3208         https://bugs.webkit.org/show_bug.cgi?id=190207
3209
3210         The change in r236624 introduced crashes on the bots
3211         (Requested by ryanhaddad on #webkit).
3212
3213         Reverted changesets:
3214
3215         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3216         https://bugs.webkit.org/show_bug.cgi?id=188747
3217         https://trac.webkit.org/changeset/236624
3218
3219         "Unify implementation in VideoFullscreenInterfaceAVKit"
3220         https://bugs.webkit.org/show_bug.cgi?id=190091
3221         https://trac.webkit.org/changeset/236671
3222
3223 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3224
3225         URL should not use TextEncoding internally
3226         https://bugs.webkit.org/show_bug.cgi?id=190111
3227
3228         Reviewed by Andy Estes.
3229
3230         * Misc/WebNSURLExtras.mm:
3231
3232 2018-09-28  Jer Noble  <jer.noble@apple.com>
3233
3234         Refactoring: eliminate raw pointer usage in Fullscreen code
3235         https://bugs.webkit.org/show_bug.cgi?id=188747
3236         <rdar://problem/43541164>
3237
3238         Reviewed by Alex Christensen.
3239
3240         PlaybackSessionInterface no longer has an invalidate() method.
3241
3242         * WebView/WebView.mm:
3243         (-[WebView _clearPlaybackControlsManager]):
3244
3245 2018-09-28  Chris Dumez  <cdumez@apple.com>
3246
3247         Drop support for cross-origin-window-policy header
3248         https://bugs.webkit.org/show_bug.cgi?id=190081
3249
3250         Reviewed by Ryosuke Niwa.
3251
3252         * WebView/WebPreferenceKeysPrivate.h:
3253         * WebView/WebPreferences.mm:
3254         (+[WebPreferences initialize]):
3255         * WebView/WebPreferencesPrivate.h:
3256         * WebView/WebView.mm:
3257         (-[WebView _preferencesChanged:]):
3258
3259 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3260
3261         Rename createMarkup to serializePreservingVisualAppearance
3262         https://bugs.webkit.org/show_bug.cgi?id=190086
3263
3264         Reviewed by Wenson Hsieh.
3265
3266         * DOM/WebDOMOperations.mm:
3267         (-[DOMRange markupString]):
3268
3269 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3270
3271         Unreviewed, rolling out r236605.
3272         https://bugs.webkit.org/show_bug.cgi?id=190087
3273
3274         caused three API test timeouts (Requested by jernoble on
3275         #webkit).
3276
3277         Reverted changeset:
3278
3279         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3280         https://bugs.webkit.org/show_bug.cgi?id=188747
3281         https://trac.webkit.org/changeset/236605
3282
3283 2018-09-28  Jer Noble  <jer.noble@apple.com>
3284
3285         Refactoring: eliminate raw pointer usage in Fullscreen code
3286         https://bugs.webkit.org/show_bug.cgi?id=188747
3287         <rdar://problem/43541164>
3288
3289         Reviewed by Alex Christensen.
3290
3291         PlaybackSessionInterface no longer has an invalidate() method.
3292
3293         * WebView/WebView.mm:
3294         (-[WebView _clearPlaybackControlsManager]):
3295
3296 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3297
3298         Use enum class in createMarkup arguments
3299         https://bugs.webkit.org/show_bug.cgi?id=190028
3300
3301         Reviewed by Wenson Hsieh.
3302
3303         * DOM/WebDOMOperations.mm:
3304         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3305         (-[DOMRange markupString]): Ditto.
3306
3307 2018-09-27  Antoine Quint  <graouts@apple.com>
3308
3309         [Web Animations] Turn Web Animations with CSS integration on
3310         https://bugs.webkit.org/show_bug.cgi?id=184819
3311         <rdar://problem/39597337>
3312
3313         Reviewed by Dean Jackson.
3314
3315         * WebView/WebPreferences.mm:
3316         (+[WebPreferences initialize]):
3317
3318 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3319
3320         Selection should work across shadow boundary when initiated by a mouse drag
3321         https://bugs.webkit.org/show_bug.cgi?id=151380
3322         <rdar://problem/24363872>
3323
3324         Reviewed by Wenson Hsieh.
3325
3326         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3327
3328         * WebView/WebPreferenceKeysPrivate.h:
3329         * WebView/WebPreferences.mm:
3330         (+[WebPreferences initialize]):
3331         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3332         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3333         * WebView/WebPreferencesPrivate.h:
3334         * WebView/WebView.mm:
3335         (-[WebView _preferencesChanged:]):
3336
3337 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3338
3339         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3340         https://bugs.webkit.org/show_bug.cgi?id=189918
3341         Work towards <rdar://problem/44648705>
3342
3343         Reviewed by Tim Horton.
3344
3345         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3346
3347         * WebView/WebHTMLView.mm:
3348         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3349         (-[WebHTMLView _updateFontPanel]):
3350         * WebView/WebView.mm:
3351         (-[WebView typingAttributes]):
3352
3353 2018-09-17  Darin Adler  <darin@apple.com>
3354
3355         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3356         https://bugs.webkit.org/show_bug.cgi?id=189652
3357
3358         Reviewed by Saam Barati.
3359
3360         * WebView/WebPDFRepresentation.mm:
3361         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3362
3363 2018-09-14  Jer Noble  <jer.noble@apple.com>
3364
3365         Turn SourceBufferChangeTypeEnabled on by default
3366         https://bugs.webkit.org/show_bug.cgi?id=189527
3367
3368         Reviewed by Eric Carlson.
3369
3370         * WebView/WebPreferences.mm:
3371         (+[WebPreferences initialize]):
3372
3373 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3374
3375         Fix an internal build after r235935
3376         https://bugs.webkit.org/show_bug.cgi?id=188996
3377
3378         * Carbon/HIWebView.mm:
3379         (Draw):
3380         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3381
3382 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3383
3384         Add IGNORE_WARNING_.* macros
3385         https://bugs.webkit.org/show_bug.cgi?id=188996
3386
3387         Reviewed by Michael Catanzaro.
3388
3389         * Carbon/CarbonUtils.m:
3390         (PoolCleaner):
3391         * Carbon/CarbonWindowAdapter.mm:
3392         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3393         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3394         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3395         (-[CarbonWindowAdapter _termWindowIfOwner]):
3396         (-[CarbonWindowAdapter _windowMovedToRect:]):
3397         (-[CarbonWindowAdapter setContentView:]):
3398         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3399         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3400         * Carbon/CarbonWindowFrame.m:
3401         (-[CarbonWindowFrame title]):
3402         * Carbon/HIViewAdapter.m:
3403         (+[HIViewAdapter getHIViewForNSView:]):
3404         * Carbon/HIWebView.mm:
3405         (overrideCGContext):
3406         (restoreCGContext):
3407         (Draw):
3408         * DOM/DOM.mm:
3409         * History/WebHistory.mm:
3410         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3411         * History/WebHistoryItem.mm:
3412         (-[WebHistoryItem icon]):
3413         * Misc/WebKitNSStringExtras.mm:
3414         (-[NSString _web_drawAtPoint:font:textColor:]):
3415         * Misc/WebNSImageExtras.m:
3416         (-[NSImage _web_scaleToMaxSize:]):
3417         (-[NSImage _web_dissolveToFraction:]):
3418         * Misc/WebNSPasteboardExtras.mm:
3419         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3420         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3421         * Panels/WebAuthenticationPanel.m:
3422         (-[WebAuthenticationPanel loadNib]):
3423         * Plugins/Hosted/NetscapePluginHostManager.mm:
3424         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3425         (WebKit::NetscapePluginHostManager::didCreateWindow):
3426         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3427         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3428         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3429         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3430         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3431         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3432         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3433         (-[WebHostedNetscapePluginView drawRect:]):
3434         * Plugins/Hosted/WebTextInputWindowController.m:
3435         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3436         * Plugins/WebBaseNetscapePluginView.mm:
3437         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3438         * Plugins/WebNetscapePluginPackage.mm:
3439         (-[WebNetscapePluginPackage _tryLoad]):
3440         * Plugins/WebNetscapePluginView.mm:
3441         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3442         (-[WebNetscapePluginView sendDrawRectEvent:]):
3443         (-[WebNetscapePluginView drawRect:]):
3444         * Plugins/WebPluginController.mm:
3445         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3446         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3447         * WebCoreSupport/PopupMenuMac.mm:
3448         (PopupMenuMac::populate):
3449         * WebCoreSupport/WebAlternativeTextClient.h:
3450         * WebCoreSupport/WebDragClient.mm:
3451         (WebDragClient::startDrag):
3452         * WebCoreSupport/WebFrameLoaderClient.mm:
3453         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3454         (webGetNSImage):
3455         * WebInspector/WebNodeHighlight.mm:
3456         * WebInspector/WebNodeHighlightView.mm:
3457         (-[WebNodeHighlightView drawRect:]):
3458         * WebView/WebClipView.mm:
3459         (-[WebClipView initWithFrame:]):
3460         * WebView/WebFrame.mm:
3461         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3462         (-[WebFrame _drawRect:contentsOnly:]):
3463         (-[WebFrame accessibilityRoot]):
3464         * WebView/WebFullScreenController.mm:
3465         (-[WebFullScreenController enterFullScreen:]):
3466         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3467         (-[WebFullScreenController exitFullScreen]):
3468         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3469         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3470         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3471         * WebView/WebHTMLView.mm:
3472         (-[NSWindow _web_borderView]):
3473         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3474         (-[WebHTMLView _setAsideSubviews]):
3475         (-[WebHTMLView _autoscroll]):
3476         (-[WebHTMLView drawRect:]):
3477  &