Remove unused QTKit preference
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-23  Alex Christensen  <achristensen@webkit.org>
2
3         Remove unused QTKit preference
4         https://bugs.webkit.org/show_bug.cgi?id=181968
5
6         Reviewed by Alexey Proskuryakov.
7
8         * WebView/WebPreferenceKeysPrivate.h:
9         * WebView/WebPreferences.mm:
10         (+[WebPreferences initialize]):
11         (-[WebPreferences setQTKitEnabled:]): Deleted.
12         (-[WebPreferences isQTKitEnabled]): Deleted.
13         * WebView/WebPreferencesPrivate.h:
14         * WebView/WebView.mm:
15         (-[WebView _preferencesChanged:]):
16
17 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
18
19         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
20         https://bugs.webkit.org/show_bug.cgi?id=181960
21         <rdar://problem/36431678>
22
23         Reviewed by Tim Horton.
24
25         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
26         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
27         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
28
29         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
30         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
31         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
32
33         * WebView/WebView.mm:
34         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
35
36 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
37
38         Turning off custom pasteboard data doesn't actually turn it off in WK2
39         https://bugs.webkit.org/show_bug.cgi?id=181920
40         <rdar://problem/36686429>
41
42         Reviewed by Wenson Hsieh.
43
44         Always disable custom pasteboard data in WebKit1. See r226156 for details.
45
46         * WebView/WebPreferences.mm:
47         (+[WebPreferences initialize]):
48         * WebView/WebView.mm:
49         (-[WebView _preferencesChanged:]):
50
51 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
52
53         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
54         https://bugs.webkit.org/show_bug.cgi?id=181918
55
56         Reviewed by Tim Horton.
57
58         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
59
60         * Configurations/FeatureDefines.xcconfig:
61
62 2018-01-20  Andy Estes  <aestes@apple.com>
63
64         [Apple Pay] Stop eagerly loading PassKit.framework
65         https://bugs.webkit.org/show_bug.cgi?id=181911
66         <rdar://problem/36555369>
67
68         Reviewed by Tim Horton.
69
70         * WebCoreSupport/WebPaymentCoordinatorClient.h:
71         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
72         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
73
74         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
75
76 2018-01-19  Dean Jackson  <dino@apple.com>
77
78         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
79         https://bugs.webkit.org/show_bug.cgi?id=181817
80         <rdar://problem/35274055>
81
82         Reviewed by Simon Fraser.
83
84         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
85
86         * Misc/WebKitVersionChecks.h:
87         * WebView/WebView.mm:
88         (-[WebView _commonInitializationWithFrameName:groupName:]):
89
90 2018-01-19  Alex Christensen  <achristensen@webkit.org>
91
92         Remove unused WebViewPrivate _allowCookies
93         https://bugs.webkit.org/show_bug.cgi?id=181812
94
95         Reviewed by Tim Horton.
96
97         * WebView/WebView.mm:
98         (+[WebView _setAllowCookies:]): Deleted.
99         (+[WebView _allowCookies]): Deleted.
100         * WebView/WebViewPrivate.h:
101
102 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
103
104         Build fix, remove a call to -[NSWindow setOneShot:]
105         https://bugs.webkit.org/show_bug.cgi?id=181809
106
107         Reviewed by Tim Horton.
108
109         * WebView/WebTextCompletionController.mm:
110         (-[WebTextCompletionController _buildUI]):
111
112 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
113
114         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
115
116         * Carbon/HIWebView.mm:
117         (overrideCGContext):
118         (restoreCGContext):
119
120 2018-01-18  Dan Bernstein  <mitz@apple.com>
121
122         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
123         https://bugs.webkit.org/show_bug.cgi?id=181803
124
125         Reviewed by Tim Horton.
126
127         * Configurations/Base.xcconfig: Updated.
128         * Configurations/DebugRelease.xcconfig: Ditto.
129         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
130         * Configurations/Version.xcconfig: Updated.
131         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
132           useful for defining settings that depend on the target macOS version.
133
134 2018-01-17  Youenn Fablet  <youenn@apple.com>
135
136         Put fetch Request.keepalive behind a runtime flag
137         https://bugs.webkit.org/show_bug.cgi?id=181592
138
139         Reviewed by Chris Dumez.
140
141         * WebView/WebPreferenceKeysPrivate.h:
142         * WebView/WebPreferences.mm:
143         (+[WebPreferences initialize]):
144         (-[WebPreferences fetchAPIKeepAliveEnabled]):
145         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
146         * WebView/WebPreferencesPrivate.h:
147         * WebView/WebView.mm:
148         (-[WebView _preferencesChanged:]):
149
150 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
151
152         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
153         https://bugs.webkit.org/show_bug.cgi?id=181637
154         <rdar://problem/36508471>
155
156         Reviewed by Tim Horton.
157
158         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
159
160         * WebCoreSupport/WebEditorClient.h:
161         * WebCoreSupport/WebEditorClient.mm:
162         (WebEditorClient::replacementURLForResource):
163
164 2018-01-11  Keith Miller  <keith_miller@apple.com>
165
166         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
167         https://bugs.webkit.org/show_bug.cgi?id=181573
168
169         Reviewed by Simon Fraser.
170
171         * Configurations/FeatureDefines.xcconfig:
172
173 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
174
175         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
176         https://bugs.webkit.org/show_bug.cgi?id=181497
177
178         Reviewed by Tim Horton.
179
180         See other ChangeLogs for more detail.
181
182         * WebCoreSupport/WebDragClient.h:
183
184 2018-01-11  Tim Horton  <timothy_horton@apple.com>
185
186         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
187         https://bugs.webkit.org/show_bug.cgi?id=181523
188         <rdar://problem/28959131>
189
190         Reviewed by Alex Christensen.
191
192         * WebView/WebImmediateActionController.mm:
193         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
194         Apply the change made in r216652 to WebKit1's immediate action controller.
195
196         Speculative (but successful in WebKit2) fix for non-reproducible crash when
197         the startContainer of the range is in an anonymous node.
198
199 2018-01-11  Youenn Fablet  <youenn@apple.com>
200
201         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
202         https://bugs.webkit.org/show_bug.cgi?id=181480
203
204         Reviewed by Eric Carlson.
205
206         * WebView/WebPreferences.mm:
207         (+[WebPreferences initialize]):
208
209 2018-01-08  David Kilzer  <ddkilzer@apple.com>
210
211         Fix check-webkit-style issues with WebNSDataExtras.mm
212         <https://webkit.org/b/181369>
213
214         Reviewed by Alex Christensen.
215
216         * Misc/WebNSDataExtras.mm:
217         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
218         (-[NSData _webkit_guessedMIMETypeForXML]):
219         (-[NSData _webkit_guessedMIMEType]):
220         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
221         (_findEOL):
222         (-[NSData _webkit_parseRFC822HeaderFields]):
223         (-[NSData _web_locationAfterFirstBlankLine]):
224         - Fix all the check-webkit-style warnings.
225
226 2018-01-08  David Kilzer  <ddkilzer@apple.com>
227
228         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
229         <https://webkit.org/b/181256>
230         <rdar://problem/36281730>
231
232         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
233         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
234         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
235           to avoid warnings from casting CFStringRef to NPNSString*.
236           Note that CFMutableStringRef is the same as CFStringRef
237           without the const modifier, hence its use in the const_cast<>
238           above.
239
240 2018-01-08  David Kilzer  <ddkilzer@apple.com>
241
242         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
243         <https://webkit.org/b/181256>
244         <rdar://problem/36281730>
245
246         * Carbon/HIWebView.mm:
247         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
248         checked_cf_cast<CFRunLoopRef>() to fix warning.
249
250 2018-01-07  David Kilzer  <ddkilzer@apple.com>
251
252         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
253         <https://webkit.org/b/181256>
254         <rdar://problem/36281730>
255
256         Reviewed by Darin Adler.
257
258         * Carbon/CarbonUtils.m:
259         (PoolCleaner):
260         - Use #pragmas to ignore -Wcast-qual warnings when using a
261           C-style cast from CFTypeRef to CFRunloopRef.
262         * Carbon/CarbonWindowFrame.m:
263         (-[CarbonWindowFrame title]):
264         - Use #pragmas to ignore -Wcast-qual warnings when using a
265           C-style cast from CFStringRef to NSString *.
266         * Carbon/HIViewAdapter.m:
267         (+[HIViewAdapter getHIViewForNSView:]):
268         - Use #pragmas to ignore -Wcast-qual warnings when using a
269           C-style cast from CFTypeRef to HIViewRef.
270         * Configurations/Base.xcconfig:
271         (WARNING_CFLAGS): Add -Wcast-qual.
272         * Misc/WebElementDictionary.mm:
273         (-[WebElementDictionary objectForKey:]):
274         - Use static_cast<SEL>(const_cast<void*>()) to fix
275           warning.
276         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
277         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
278         (-[NSData _webkit_guessedMIMETypeForXML]):
279         (-[NSData _webkit_guessedMIMEType]):
280         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
281         (_findEOL):
282         (-[NSData _webkit_parseRFC822HeaderFields]):
283         (-[NSData _web_startsWithBlankLine]):
284         (-[NSData _web_locationAfterFirstBlankLine]):
285         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
286           type to Objective-C++.  This fixes the warnings about
287           discarding the `const` modifier when casing from CFStringRef
288           to NSString * because in older clang versions, -Wcast-qual was
289           completely broken when compiling C++ and Objective-C++ source
290           files.  In newer clang versions, discarding the `const`
291           modifier for toll-free bridged types is ignored when compiling
292           Objective-C++ source.
293         - Update copyright and license header.
294         - Use reinterpret_cast<> and static_cast<> to fix warnings
295           unrelated to (NSString *) C-style casts.
296         - Replace use of MIN() macro with std::min<> template functions.
297         - Fix location of `*` for local variables modified above.
298         * Plugins/Hosted/NetscapePluginHostManager.mm:
299         (WebKit::NetscapePluginHostManager::spawnPluginHost):
300         (WebKit::NetscapePluginHostManager::initializeVendorPort):
301         (WebKit::NetscapePluginHostManager::instantiatePlugin):
302         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
303           warnings.
304         * Plugins/Hosted/NetscapePluginHostProxy.mm:
305         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
306         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
307           to fix warning.
308         * Plugins/Hosted/ProxyInstance.mm:
309         (WebKit::ProxyInstance::invoke):
310         - Use static_cast<char*>(const_cast<void*>()) to fix
311           warning when using -[NSData bytes].
312         (WebKit::ProxyInstance::fieldValue const):
313         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
314           to fix warning when using CFDataGetBytePtr().
315         * Plugins/Hosted/WebTextInputWindowController.m:
316         (-[WebTextInputPanel _interpretKeyEvent:string:]):
317         - Use #pragma to ignore -Wcast-qual warning since there
318           is not a good way to avoid this warning in Objective-C.
319         * Plugins/WebNetscapePluginStream.mm:
320         (WebNetscapePluginStream::deliverData):
321         - Use const_cast<void*>() to fix warning when using
322           -[NSData bytes].
323         * Plugins/WebNetscapePluginView.mm:
324         (-[WebNetscapePluginView _createPlugin]):
325         - Change C-style cast to const_cast<char*>() to fix
326           warning.
327         * WebCoreSupport/WebChromeClient.mm:
328         (WebChromeClient::wrapCryptoKey const):
329         (WebChromeClient::unwrapCryptoKey const):
330         - Change C-style cast to
331           static_cast<uint8_t*>(const_cast<void*>() to fix
332           warning.
333         * WebView/WebPDFView.mm:
334         (_applicationInfoForMIMEType):
335         - Change local variable type from 'NSURL *' to
336           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
337           when calling -[NSURL path].
338
339 2018-01-05  Dan Bernstein  <mitz@apple.com>
340
341         Fixed the build following AppKit API deprecations in a recent SDKs
342
343         * WebView/WebFullScreenController.mm:
344         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
345         (-[WebFullScreenController exitFullScreen]): Ditto.
346         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
347         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
348         * WebView/WebHTMLView.mm:
349         (-[WebHTMLView drawRect:]): Ditto.
350         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
351         (-[WebHTMLView knowsPageRange:]): Ditto.
352         * WebView/WebView.mm:
353         (LayerFlushController::flushLayers): Ditto.
354
355 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
356
357         [Attachment Support] Create attachment elements when dropping files on iOS
358         https://bugs.webkit.org/show_bug.cgi?id=181192
359         <rdar://problem/36280945>
360
361         Reviewed by Tim Horton.
362
363         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
364
365         * WebCoreSupport/WebPlatformStrategies.h:
366         * WebCoreSupport/WebPlatformStrategies.mm:
367         (WebPlatformStrategies::informationForItemAtIndex):
368         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
369
370 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
371
372         [Attachment Support] Add plumbing for starting a drag with promised blob data
373         https://bugs.webkit.org/show_bug.cgi?id=181201
374
375         Reviewed by Tim Horton.
376
377         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
378
379         * WebCoreSupport/WebDragClient.h:
380
381 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
382
383         Add a WebAuthentication runtime feature flag
384         https://bugs.webkit.org/show_bug.cgi?id=181220
385         <rdar://problem/36055305>
386
387         Reviewed by Brent Fulgham.
388
389         Renames the CredentialManagement runtime feature flag into WebAuthentication.
390
391         * WebView/WebPreferenceKeysPrivate.h:
392         * WebView/WebPreferences.mm:
393         (+[WebPreferences initialize]):
394         (-[WebPreferences webAuthenticationEnabled]):
395         (-[WebPreferences setWebAuthenticationEnabled:]):
396         (-[WebPreferences credentialManagementEnabled]): Deleted.
397         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
398         * WebView/WebPreferencesPrivate.h:
399         * WebView/WebView.mm:
400         (-[WebView _preferencesChanged:]):
401
402 2017-12-22  Jeff Miller  <jeffm@apple.com>
403
404         Update user-visible copyright strings to include 2018
405         https://bugs.webkit.org/show_bug.cgi?id=181141
406
407         Reviewed by Dan Bernstein.
408
409         * Info.plist:
410
411 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
412
413         [Attachment Support] Remove current macOS support for dragging file-backed attachments
414         https://bugs.webkit.org/show_bug.cgi?id=181188
415
416         Reviewed by Dan Bernstein.
417
418         See WebCore/ChangeLog for more detail.
419
420         * WebCoreSupport/WebDragClient.h:
421         * WebCoreSupport/WebDragClient.mm:
422         (WebDragClient::declareAndWriteAttachment): Deleted.
423         * WebView/WebHTMLView.mm:
424         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
425
426 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
427
428         Unreviewed, continue to fix build failures due to AppKit API deprecation
429
430         Wraps more code in -Wdeprecated-declarations.
431
432         * Carbon/HIWebView.mm:
433         (overrideCGContext):
434
435 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
436
437         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
438
439         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
440
441         * Carbon/CarbonWindowAdapter.mm:
442         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
443         * Plugins/WebNetscapePluginView.mm:
444         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
445         (-[WebNetscapePluginView sendDrawRectEvent:]):
446         (-[WebNetscapePluginView drawRect:]):
447
448 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
449
450         Fix build failures due to using deprecated AppKit symbols
451         https://bugs.webkit.org/show_bug.cgi?id=181110
452         <rdar://problem/36162865>
453
454         Reviewed by Dan Bernstein and Tim Horton.
455
456         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
457
458         * Misc/WebKitNSStringExtras.mm:
459         (-[NSString _web_drawAtPoint:font:textColor:]):
460         * Misc/WebNSPasteboardExtras.h:
461         * Misc/WebNSPasteboardExtras.mm:
462         (+[NSPasteboard _web_writableTypesForURL]):
463         (_createWritableTypesForImageWithoutArchive):
464         (_createWritableTypesForImageWithArchive):
465         (+[NSPasteboard _web_dragTypesForURL]):
466         (-[NSPasteboard _web_bestURL]):
467         (-[NSPasteboard _web_writeURL:andTitle:types:]):
468         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
469         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
470         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
471         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
472         * Panels/WebAuthenticationPanel.m:
473         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
474         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
475         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
476         (-[WebHostedNetscapePluginView drawRect:]):
477         * WebInspector/WebNodeHighlightView.mm:
478         (-[WebNodeHighlightView drawRect:]):
479         * WebView/WebFrame.mm:
480         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
481         (-[WebFrame _drawRect:contentsOnly:]):
482         * WebView/WebHTMLView.mm:
483         (kit):
484         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
485         (-[WebHTMLView _plainTextFromPasteboard:]):
486         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
487         (+[WebHTMLView _insertablePasteboardTypes]):
488         (+[WebHTMLView _selectionPasteboardTypes]):
489         (-[WebHTMLView pasteboard:provideDataForType:]):
490         (-[WebHTMLView _writeSelectionToPasteboard:]):
491         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
492         (-[WebHTMLView validRequestorForSendType:returnType:]):
493         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
494         (createMenuItem):
495         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
496         (-[WebHTMLView _colorAsString:]):
497         (-[WebHTMLView copyFont:]):
498         * WebView/WebPDFView.mm:
499         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
500         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
501         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
502         (-[WebPDFView pasteboardTypesForSelection]):
503         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
504         * WebView/WebView.h:
505         * WebView/WebView.mm:
506         (-[WebView performDragOperation:]):
507         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
508         (-[WebView _searchWithGoogleFromMenu:]):
509
510 2017-12-21  Youenn Fablet  <youenn@apple.com>
511
512         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
513         https://bugs.webkit.org/show_bug.cgi?id=181000
514
515         Reviewed by Chris Dumez.
516
517         * Misc/WebCache.mm:
518         (+[WebCache addImageToCache:forURL:forFrame:]):
519
520 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
521
522         Update FULLSCREEN_API feature defines.
523         https://bugs.webkit.org/show_bug.cgi?id=181015
524
525         Reviewed by Tim Horton.
526
527         Change enabled iphone sdk for FULLSCREEN_API.
528
529         * Configurations/FeatureDefines.xcconfig:
530
531 2017-12-21  Jer Noble  <jer.noble@apple.com>
532
533         Add initial DOM support for Media Capabilities
534         https://bugs.webkit.org/show_bug.cgi?id=181064
535
536         Reviewed by Eric Carlson.
537
538         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
539
540         * WebView/WebPreferenceKeysPrivate.h:
541         * WebView/WebPreferences.mm:
542         (+[WebPreferences initialize]):
543         (-[WebPreferences mediaCapabilitiesEnabled]):
544         (-[WebPreferences setMediaCapabilitiesEnabled:]):
545         * WebView/WebPreferencesPrivate.h:
546         * WebView/WebView.mm:
547         (-[WebView _preferencesChanged:]):
548
549 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
550
551         Enable picture-in-picture from inline element on suspend.
552         https://bugs.webkit.org/show_bug.cgi?id=180942
553         rdar://problem/34745234
554
555         Reviewed by Jer Noble.
556
557         Update signature of enterVideoFullscreenForVideoElement().
558
559         * WebCoreSupport/WebChromeClient.h:
560         * WebCoreSupport/WebChromeClient.mm:
561         (WebChromeClient::enterVideoFullscreenForVideoElement):
562
563 2017-12-20  Daniel Bates  <dabates@apple.com>
564
565         Remove Alternative Presentation Button
566         https://bugs.webkit.org/show_bug.cgi?id=180500
567         <rdar://problem/35891047>
568
569         Reviewed by Simon Fraser.
570
571         We no longer need the alternative presentation button.
572
573         * Configurations/FeatureDefines.xcconfig:
574
575 2017-12-19  Jer Noble  <jer.noble@apple.com>
576
577         Playing media elements which call "pause(); play()" will have the play promise rejected.
578         https://bugs.webkit.org/show_bug.cgi?id=180781
579         <rdar://problem/33191377>
580
581         Reviewed by Eric Carlson.
582
583         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
584
585         * WebView/WebView.mm:
586         (shouldRequireUserGestureToLoadVideo):
587
588 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
589
590         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
591         https://bugs.webkit.org/show_bug.cgi?id=180977
592
593         Reviewed by Tim Horton.
594
595         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
596         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
597         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
598
599         * WebCoreSupport/WebEditorClient.mm:
600         (attributesForAttributedStringConversion):
601         * WebView/WebHTMLView.mm:
602         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
603
604 2017-12-18  David Kilzer  <ddkilzer@apple.com>
605
606         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
607
608         Attempt to fix the following warnings:
609
610             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
611
612         For the following instance variables:
613
614             _borderView
615             _contentView
616             _frame
617             _wFlags
618
619         * Carbon/CarbonWindowAdapter.mm:
620         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
621         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
622         (-[CarbonWindowAdapter _termWindowIfOwner]):
623         (-[CarbonWindowAdapter _windowMovedToRect:]):
624         (-[CarbonWindowAdapter setContentView:]):
625         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
626         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
627
628 2017-12-16  Dan Bernstein  <mitz@apple.com>
629
630         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
631         https://bugs.webkit.org/show_bug.cgi?id=180613
632         <rdar://problem/35946124>
633
634         Reviewed by Geoff Garen.
635
636         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
637           clients.
638         * WebView/WebDynamicScrollBarsView.h: Ditto.
639         * WebView/WebDynamicScrollBarsView.mm: Ditto.
640
641 2017-12-14  David Kilzer  <ddkilzer@apple.com>
642
643         Enable -Wstrict-prototypes for WebKit
644         <https://webkit.org/b/180757>
645         <rdar://problem/36024132>
646
647         Rubber-stamped by Joseph Pecoraro.
648
649         * Configurations/Base.xcconfig:
650         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
651
652 2017-12-14  John Wilander  <wilander@apple.com>
653
654         Storage Access API: Implement frame-specific access in the document.cookie layer
655         https://bugs.webkit.org/show_bug.cgi?id=180682
656         <rdar://problem/35982257>
657
658         Reviewed by Alex Christensen.
659
660         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
661         CookiesStrategy::cookieRequestHeaderFieldValue(), and
662         CookiesStrategy::getRawCookies() now take optional parameters for
663         frameID and pageID to allow frame-specific scoping of cookies.
664
665         This change makes the return values of FrameLoaderClient::frameID()
666         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
667         WebCore can call those getters and get the right return values in
668         WebKit and std:nullopt in WebKitLegacy.
669
670         * WebCoreSupport/WebFrameLoaderClient.h:
671         * WebCoreSupport/WebFrameLoaderClient.mm:
672         (WebFrameLoaderClient::pageID const):
673         (WebFrameLoaderClient::frameID const):
674         * WebCoreSupport/WebPlatformStrategies.h:
675         * WebCoreSupport/WebPlatformStrategies.mm:
676         (WebPlatformStrategies::cookiesForDOM):
677         (WebPlatformStrategies::setCookiesFromDOM):
678         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
679         (WebPlatformStrategies::getRawCookies):
680
681 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
682
683         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
684         https://bugs.webkit.org/show_bug.cgi?id=180689
685
686         Reviewed by Tim Horton.
687
688         Use sRGBColorSpaceRef() from WebCore.
689
690         * WebView/WebHTMLView.mm:
691         (imageFromRect):
692
693 2017-12-11  Tim Horton  <timothy_horton@apple.com>
694
695         Stop using deprecated target conditional for simulator builds
696         https://bugs.webkit.org/show_bug.cgi?id=180662
697         <rdar://problem/35136156>
698
699         Reviewed by Simon Fraser.
700
701         * postprocess-headers.sh:
702
703 2017-12-11  David Quesada  <david_quesada@apple.com>
704
705         Turn on ENABLE_APPLICATION_MANIFEST
706         https://bugs.webkit.org/show_bug.cgi?id=180562
707         rdar://problem/35924737
708
709         Reviewed by Geoffrey Garen.
710
711         * Configurations/FeatureDefines.xcconfig:
712
713 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
714
715         Remove pthread_once in favor of dispatch_once
716         https://bugs.webkit.org/show_bug.cgi?id=180591
717
718         Reviewed by Saam Barati.
719
720         * Misc/WebKitErrors.m:
721         (+[NSError _registerWebKitErrors]):
722         (registerErrors): Deleted.
723         * Storage/WebStorageManager.mm:
724         (+[WebStorageManager _storageDirectoryPath]):
725         (initializeLocalStoragePath): Deleted.
726
727 2017-12-07  Darin Adler  <darin@apple.com>
728
729         Remove some unused code from WebKitLegacy
730         https://bugs.webkit.org/show_bug.cgi?id=180567
731
732         Reviewed by Anders Carlsson.
733
734         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
735         macOS (back a few versions) and iOS and removed unused
736         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
737         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
738         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
739         _webkit_stringByCollapsingNonPrintingCharacters,
740         _webkit_stringByCollapsingWhitespaceCharacters,
741         _web_stringWithData:textEncodingName:, and
742         _webkit_localStorageDirectoryWithBundleIdentifier:.
743
744         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
745         this source file.
746         (canUseFastRenderer): Made this faster by not calling u_charDirection for
747         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
748         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
749         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
750         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
751         handle font smoothing options.
752         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
753         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
754         from header and made it a little clearer.
755         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
756         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
757         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
758         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
759         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
760         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
761         implementation a bit and used whole words instead of abbreviations.
762         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
763
764         * Misc/WebNSFileManagerExtras.mm:
765         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
766         filenameByFixingIllegalCharacters function from WebCore directly instead of
767         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
768
769         * Plugins/WebBaseNetscapePluginView.mm:
770         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
771         string replacements instead of _web_stringByStrippingReturnCharacters
772         and to use NSString methods instead of CFString functions.
773
774 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
775
776         Ignore deprecation warnings.
777
778         * WebView/WebHTMLView.mm:
779         (-[NSWindow _web_borderView]):
780         (-[WebHTMLView _setAsideSubviews]):
781         * WebView/WebView.mm:
782         (-[WebView encodeWithCoder:]):
783
784 2017-12-02  Darin Adler  <darin@apple.com>
785
786         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
787         https://bugs.webkit.org/show_bug.cgi?id=180009
788
789         Reviewed by Alex Christensen.
790
791         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
792
793         * Plugins/WebBaseNetscapePluginView.mm:
794         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
795         of strcasecmp.
796
797         * WebView/WebPreferences.mm:
798         (contains): Ditto. Also made this a template so it's easier to call on an array.
799         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
800
801 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
802
803         Limit user agent versioning to an upper bound
804         https://bugs.webkit.org/show_bug.cgi?id=180365
805         <rdar://problem/34550617>
806
807         Reviewed by Joseph Pecoraro.
808
809         * WebView/WebView.mm:
810         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
811         creating the User Agent string.
812         (webKitBundleVersionString): Deleted.
813
814 2017-12-05  Andy Estes  <aestes@apple.com>
815
816         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
817         https://bugs.webkit.org/show_bug.cgi?id=180457
818         <rdar://problem/35143007>
819
820         Reviewed by Tim Horton.
821
822         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
823         check for this macro during post-processing.
824
825         * postprocess-headers.sh:
826
827 2017-12-04  David Quesada  <david_quesada@apple.com>
828
829         Add a class for parsing application manifests
830         https://bugs.webkit.org/show_bug.cgi?id=177973
831         rdar://problem/34747949
832
833         Reviewed by Geoffrey Garen.
834
835         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
836
837 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
838
839         Make LegacyCustomProtocolManager optional for network process
840         https://bugs.webkit.org/show_bug.cgi?id=176230
841
842         Reviewed by Alex Christensen.
843
844         * Configurations/FeatureDefines.xcconfig:
845
846 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
847
848         Fix some NSOperationQueue leaks
849         https://bugs.webkit.org/show_bug.cgi?id=180221
850
851         Reviewed by Wenson Hsieh.
852
853         * WebView/WebView.mm:
854         (-[WebView performDragOperation:]):
855
856 2017-11-30  Darin Adler  <darin@apple.com>
857
858         [Mac] remove unneeded RetainPtr use introduced in r225142
859         https://bugs.webkit.org/show_bug.cgi?id=180202
860
861         Reviewed by Tim Horton.
862
863         * WebView/WebImmediateActionController.mm:
864         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
865         RetainPtr.
866
867 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
868
869         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
870         https://bugs.webkit.org/show_bug.cgi?id=175595
871
872         Reviewed by Darin Adler.
873
874         * WebView/WebPreferences.mm:
875
876 2017-11-27  Tim Horton  <timothy_horton@apple.com>
877
878         One too many zeroes in macOS version number in FeatureDefines
879         https://bugs.webkit.org/show_bug.cgi?id=180011
880
881         Reviewed by Dan Bernstein.
882
883         * Configurations/FeatureDefines.xcconfig:
884
885 2017-11-23  Darin Adler  <darin@apple.com>
886
887         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
888         https://bugs.webkit.org/show_bug.cgi?id=179981
889
890         Reviewed by Sam Weinig.
891
892         * WebView/WebImmediateActionController.mm:
893         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
894         * WebView/WebView.mm:
895         (coreOptions): Use |= instead of | to build up FindOptions.
896
897 2017-11-23  Sam Weinig  <sam@webkit.org>
898
899         Remove unneeded ScriptController::processingUserGesture() forwarding functions
900         https://bugs.webkit.org/show_bug.cgi?id=179954
901
902         Reviewed by Darin Adler.
903
904         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
905         with direct calls to the corresponding UserGestureIndicator functions.
906
907         * Plugins/WebPluginController.mm:
908         (-[WebPluginController processingUserGesture]):
909         * WebView/WebView.mm:
910         (-[WebView _isProcessingUserGesture]):
911
912 2017-11-23  Darin Adler  <darin@apple.com>
913
914         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
915         https://bugs.webkit.org/show_bug.cgi?id=179907
916
917         Reviewed by Sam Weinig.
918
919         * History/BinaryPropertyList.cpp:
920         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
921         (BinaryPropertyListSerializer::appendStringObject): Ditto.
922         * WebView/WebHTMLRepresentation.mm:
923         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
924         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
925
926 2017-11-22  Ali Juma  <ajuma@chromium.org>
927
928         Implement VisualViewport API attributes
929         https://bugs.webkit.org/show_bug.cgi?id=179385
930
931         Reviewed by Frédéric Wang.
932
933         Add a VisualViewportAPI preference.
934
935         * WebView/WebPreferenceKeysPrivate.h:
936         * WebView/WebPreferences.mm:
937         (+[WebPreferences initialize]):
938         (-[WebPreferences visualViewportAPIEnabled]):
939         (-[WebPreferences setVisualViewportAPIEnabled:]):
940         * WebView/WebPreferencesPrivate.h:
941         * WebView/WebView.mm:
942         (-[WebView _preferencesChanged:]):
943
944 2017-11-22  Christopher Reid  <chris.reid@sony.com>
945
946         WebCoreObjCExtras.h is being included in too many places
947         https://bugs.webkit.org/show_bug.cgi?id=179931
948
949         Reviewed by Darin Adler.
950
951         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
952         * Plugins/WebBaseNetscapePluginView.mm:
953         * Plugins/WebBasePluginPackage.mm:
954         * Plugins/WebNetscapePluginStream.mm:
955         * Plugins/WebNetscapePluginView.mm:
956         * WebView/WebTextIterator.mm:
957         * WebView/WebViewData.mm:
958
959 2017-11-22  Commit Queue  <commit-queue@webkit.org>
960
961         Unreviewed, rolling out r225093.
962         https://bugs.webkit.org/show_bug.cgi?id=179938
963
964         Compilation failed on WinCairo 64-bit Release (Requested by
965         fredw on #webkit).
966
967         Reverted changeset:
968
969         "Implement VisualViewport API attributes"
970         https://bugs.webkit.org/show_bug.cgi?id=179385
971         https://trac.webkit.org/changeset/225093
972
973 2017-11-21  Ali Juma  <ajuma@chromium.org>
974
975         Implement VisualViewport API attributes
976         https://bugs.webkit.org/show_bug.cgi?id=179385
977
978         Reviewed by Frédéric Wang.
979
980         Add a VisualViewportAPI preference.
981
982         * WebView/WebPreferenceKeysPrivate.h:
983         * WebView/WebPreferences.mm:
984         (+[WebPreferences initialize]):
985         (-[WebPreferences visualViewportAPIEnabled]):
986         (-[WebPreferences setVisualViewportAPIEnabled:]):
987         * WebView/WebPreferencesPrivate.h:
988         * WebView/WebView.mm:
989         (-[WebView _preferencesChanged:]):
990
991 2017-11-21  Christopher Reid  <chris.reid@sony.com>
992
993         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
994         https://bugs.webkit.org/show_bug.cgi?id=179504
995
996         Reviewed by Darin Adler.
997
998         * Misc/WebKitNSStringExtras.mm:
999         * Plugins/Hosted/NetscapePluginHostManager.mm:
1000         * Plugins/WebBasePluginPackage.mm:
1001
1002 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1003
1004         Remove unused TOUCH_ICON_LOADING feature flag
1005         https://bugs.webkit.org/show_bug.cgi?id=179873
1006
1007         Reviewed by Simon Fraser.
1008
1009         * Configurations/FeatureDefines.xcconfig:
1010
1011 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1012
1013         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1014         https://bugs.webkit.org/show_bug.cgi?id=179872
1015
1016         Reviewed by Darin Adler.
1017
1018         * Configurations/FeatureDefines.xcconfig:
1019
1020 2017-11-16  Daniel Bates  <dabates@apple.com>
1021
1022         Add feature define for alternative presentation button element
1023         https://bugs.webkit.org/show_bug.cgi?id=179692
1024         Part of <rdar://problem/34917108>
1025
1026         Reviewed by Andy Estes.
1027
1028         Only enabled on Cocoa platforms by default.
1029
1030         * Configurations/FeatureDefines.xcconfig:
1031
1032 2017-11-14  Nan Wang  <n_wang@apple.com>
1033
1034         AX: AOM: Implement AccessibleNode class and support label and role attributes
1035         https://bugs.webkit.org/show_bug.cgi?id=179494
1036
1037         Reviewed by Ryosuke Niwa.
1038
1039         * WebView/WebPreferenceKeysPrivate.h:
1040         * WebView/WebPreferences.mm:
1041         (+[WebPreferences initialize]):
1042         (-[WebPreferences accessibilityObjectModelEnabled]):
1043         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1044         * WebView/WebPreferencesPrivate.h:
1045         * WebView/WebView.mm:
1046         (-[WebView _preferencesChanged:]):
1047
1048 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1049
1050         Remove Cocoa CFURLConnection loading code
1051         https://bugs.webkit.org/show_bug.cgi?id=179688
1052
1053         Reviewed by Antti Koivisto.
1054
1055         * Misc/WebDownload.mm:
1056         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1057         * Misc/WebDownloadInternal.h:
1058         * Plugins/WebBaseNetscapePluginView.mm:
1059         * WebCoreSupport/WebFrameLoaderClient.mm:
1060         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1061         * WebView/WebView.mm:
1062         (-[WebView scheduleInRunLoop:forMode:]):
1063         (-[WebView unscheduleFromRunLoop:forMode:]):
1064
1065 2017-11-14  Daniel Bates  <dabates@apple.com>
1066
1067         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1068         for feature defines
1069
1070         Following r195498 and r201917 the Visual Studio property files for feature defines have
1071         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1072         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1073         files.
1074
1075         * Configurations/FeatureDefines.xcconfig:
1076
1077 2017-11-14  Jer Noble  <jer.noble@apple.com>
1078
1079         Enable Modern EME tests in DumpRenderTree
1080         https://bugs.webkit.org/show_bug.cgi?id=179544
1081
1082         Reviewed by Alex Christensen.
1083
1084         Add a WebPreferences property to enable the (modern) EME API.
1085
1086         * WebView/WebPreferenceKeysPrivate.h:
1087         * WebView/WebPreferences.mm:
1088         (+[WebPreferences initialize]):
1089         (-[WebPreferences encryptedMediaAPIEnabled]):
1090         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1091         * WebView/WebPreferencesPrivate.h:
1092         * WebView/WebView.mm:
1093         (-[WebView _preferencesChanged:]):
1094
1095 2017-11-14  Antti Koivisto  <antti@apple.com>
1096
1097         Enable display:contents by default
1098         https://bugs.webkit.org/show_bug.cgi?id=179655
1099
1100         Reviewed by Sam Weinig.
1101
1102         * WebView/WebPreferences.mm:
1103         (+[WebPreferences initialize]):
1104
1105 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1106
1107         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1108         https://bugs.webkit.org/show_bug.cgi?id=178751
1109
1110         Reviewed by Brady Eidson.
1111
1112         * WebCoreSupport/WebFrameNetworkingContext.mm:
1113         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1114
1115 2017-11-08  Keith Miller  <keith_miller@apple.com>
1116
1117         Async iteration should only fetch the next method once and add feature flag
1118         https://bugs.webkit.org/show_bug.cgi?id=179451
1119
1120         Reviewed by Geoffrey Garen.
1121
1122         Add feature flag for Async iteration.
1123
1124         * Configurations/FeatureDefines.xcconfig:
1125
1126 2017-11-13  Mark Lam  <mark.lam@apple.com>
1127
1128         Add more overflow check book-keeping for MarkedArgumentBuffer.
1129         https://bugs.webkit.org/show_bug.cgi?id=179634
1130         <rdar://problem/35492517>
1131
1132         Reviewed by Saam Barati.
1133
1134         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1135         (WebKit::NetscapePluginInstanceProxy::invoke):
1136         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1137         (WebKit::NetscapePluginInstanceProxy::construct):
1138
1139 2017-11-12  Darin Adler  <darin@apple.com>
1140
1141         More is<> and downcast<>, less static_cast<>
1142         https://bugs.webkit.org/show_bug.cgi?id=179600
1143
1144         Reviewed by Chris Dumez.
1145
1146         * DOM/DOM.mm:
1147         (kit): Use is/downcast.
1148         * WebCoreSupport/WebEditorClient.mm:
1149         (WebEditorClient::handleKeyboardEvent): Ditto.
1150         (WebEditorClient::handleInputMethodKeydown): Ditto.
1151         * WebView/WebHTMLView.mm:
1152         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1153
1154 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1155
1156         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1157         https://bugs.webkit.org/show_bug.cgi?id=179397
1158
1159         Reviewed by Wenson Hsieh.
1160
1161         * DOM/DOMHTMLInputElement.mm:
1162         (-[DOMHTMLInputElement insertTextSuggestion:]):
1163
1164 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1165
1166         HTMLMediaElement should not use element fullscreen on iOS
1167         https://bugs.webkit.org/show_bug.cgi?id=179418
1168         rdar://problem/35409277
1169
1170         Reviewed by Eric Carlson.
1171
1172         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1173
1174         * Configurations/FeatureDefines.xcconfig:
1175
1176 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1177
1178         Make ResourceLoader::willSendRequestInternal asynchronous
1179         https://bugs.webkit.org/show_bug.cgi?id=179251
1180
1181         Reviewed by Andy Estes.
1182
1183         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1184         (WebKit::HostedNetscapePluginStream::start):
1185         * Plugins/WebNetscapePluginStream.mm:
1186         (WebNetscapePluginStream::start):
1187
1188 2017-11-01  Darin Adler  <darin@apple.com>
1189
1190         Simplify event dispatch code and make it a bit more consistent
1191         https://bugs.webkit.org/show_bug.cgi?id=178991
1192
1193         Reviewed by Chris Dumez.
1194
1195         * DOM/DOMEvent.mm:
1196         (-[DOMEvent srcElement]): Call target instead of srcElement.
1197
1198 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1199
1200         [Touch Bar Web API] Add support for menuitem tag
1201         https://bugs.webkit.org/show_bug.cgi?id=179020
1202
1203         Reviewed by Ryosuke Niwa.
1204
1205         Adds in properties and methods that allow the menuitem runtime feature
1206         to be enabled or disabled.
1207
1208         * WebView/WebPreferenceKeysPrivate.h:
1209         * WebView/WebPreferences.mm:
1210         (-[WebPreferences menuItemElementEnabled]):
1211         (-[WebPreferences setMenuItemElementEnabled:]):
1212         * WebView/WebPreferencesPrivate.h:
1213         * WebView/WebView.mm:
1214         (-[WebView _preferencesChanged:]):
1215
1216 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1217
1218         Use CompletionHandlers for redirects
1219         https://bugs.webkit.org/show_bug.cgi?id=179163
1220
1221         Reviewed by Tim Horton.
1222
1223         * Plugins/Hosted/HostedNetscapePluginStream.h:
1224         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1225         (WebKit::HostedNetscapePluginStream::willSendRequest):
1226         * Plugins/WebNetscapePluginStream.h:
1227         * Plugins/WebNetscapePluginStream.mm:
1228         (WebNetscapePluginStream::willSendRequest):
1229
1230 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1231
1232         Add a FileSystem namespace to FileSystem.cpp
1233         https://bugs.webkit.org/show_bug.cgi?id=179063
1234
1235         Reviewed by Darin Adler.
1236
1237         * Misc/WebNSFileManagerExtras.mm:
1238         * Storage/WebDatabaseProvider.mm:
1239
1240 2017-11-02  Frederic Wang  <fwang@igalia.com>
1241
1242         Add references to bug 179167 in FIXME comments
1243         https://bugs.webkit.org/show_bug.cgi?id=179168
1244
1245         Reviewed by Daniel Bates.
1246
1247         * Configurations/FeatureDefines.xcconfig:
1248
1249 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1250
1251         Implement WKFullscreenWindowController for iOS.
1252         https://bugs.webkit.org/show_bug.cgi?id=178924
1253         rdar://problem/34697120
1254
1255         Reviewed by Simon Fraser.
1256
1257         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1258
1259         * Configurations/FeatureDefines.xcconfig:
1260         * WebView/WebView.mm:
1261         (-[WebView fullScreenPlaceholderView]):
1262
1263 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1264
1265         Clean up some drag and drop feature flags
1266         https://bugs.webkit.org/show_bug.cgi?id=179082
1267
1268         Reviewed by Simon Fraser.
1269
1270         * Configurations/FeatureDefines.xcconfig:
1271
1272 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1273
1274         Make it possible to test rubber-banding in overflow scroll
1275         https://bugs.webkit.org/show_bug.cgi?id=179078
1276
1277         Reviewed by Sam Weinig.
1278
1279         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1280         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1281
1282         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1283         functions, since most callers want clamped.
1284
1285         * DOM/DOMHTML.mm:
1286         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1287
1288 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1289
1290         Fix up some content filtering feature flags
1291         https://bugs.webkit.org/show_bug.cgi?id=179079
1292
1293         Reviewed by Simon Fraser.
1294
1295         * Configurations/FeatureDefines.xcconfig:
1296
1297 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1298
1299         [FrameView::layout cleanup] Move core layout logic to a separate class.
1300         https://bugs.webkit.org/show_bug.cgi?id=178771
1301         <rdar://problem/35166542>
1302
1303         Reviewed by Simon Fraser.
1304
1305         Move layout code out from FrameView to LayoutContext.
1306
1307         * WebView/WebClipView.mm:
1308         (-[WebClipView _immediateScrollToPoint:]):
1309         * WebView/WebFrame.mm:
1310         (-[WebFrame layoutCount]):
1311
1312 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1313
1314         Fix issues with WebView subframe painting
1315         https://bugs.webkit.org/show_bug.cgi?id=178842
1316         rdar://problem/34072253
1317
1318         Reviewed by Daniel Bates.
1319         
1320         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1321         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1322         High Sierra, so match the new signature.
1323
1324         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1325
1326         * WebView/WebHTMLView.mm:
1327         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1328         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1329
1330 2017-10-25  Youenn Fablet  <youenn@apple.com>
1331
1332         Enable ServiceWorker to fetch resources
1333         https://bugs.webkit.org/show_bug.cgi?id=178673
1334
1335         Reviewed by Brady Eidson.
1336
1337         * WebCoreSupport/WebFrameLoaderClient.mm:
1338         (WebFrameLoaderClient::pageID const):
1339         (WebFrameLoaderClient::frameID const):
1340         (WebFrameLoaderClient::sessionID const):
1341
1342         Added implementation to the new getters.
1343         They are noop in the context of WK1.
1344
1345 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1346
1347         Web Inspector: Enable WebKit logging configuration and display
1348         https://bugs.webkit.org/show_bug.cgi?id=177027
1349         <rdar://problem/33964767>
1350
1351         Reviewed by Joseph Pecoraro.
1352
1353         * WebCoreSupport/WebChromeClient.mm:
1354         (stringForMessageSource): Deal with Media and WebRTC message sources.
1355
1356 2017-10-20  Antoine Quint  <graouts@apple.com>
1357
1358         [Web Animations] Provide basic timeline and animation interfaces
1359         https://bugs.webkit.org/show_bug.cgi?id=178526
1360
1361         Reviewed by Dean Jackson.
1362
1363         Remove the WEB_ANIMATIONS compile-time flag.
1364
1365         * Configurations/FeatureDefines.xcconfig:
1366         * WebView/WebPreferences.mm:
1367         (+[WebPreferences initialize]):
1368         * WebView/WebView.mm:
1369         (-[WebView _preferencesChanged:]):
1370
1371 2017-10-19  Sam Weinig  <sam@webkit.org>
1372
1373         [Settings] Move global settings into their own file
1374         https://bugs.webkit.org/show_bug.cgi?id=178512
1375
1376         Reviewed by Darin Adler.
1377
1378         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1379
1380         * WebCoreSupport/WebChromeClient.mm:
1381         (WebChromeClient::supportsVideoFullscreen):
1382         * WebView/WebDynamicScrollBarsView.mm:
1383         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1384         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1385         * WebView/WebPreferences.mm:
1386         (+[WebPreferences initialize]):
1387         * WebView/WebView.mm:
1388         (-[WebView _commonInitializationWithFrameName:groupName:]):
1389         (-[WebView _preferencesChanged:]):
1390         (+[WebView _doNotStartObservingNetworkReachability]):
1391
1392 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1393
1394         Replace some stack raw pointers with RefPtrs within WebCore/html
1395         https://bugs.webkit.org/show_bug.cgi?id=178201
1396         <rdar://problem/34841692>
1397
1398         Reviewed by Ryosuke Niwa.
1399
1400         * DOM/DOM.mm:
1401         (kit):
1402         Change the type of node as toNode() is changed to return RefPtr.
1403
1404 2017-10-18  Chris Dumez  <cdumez@apple.com>
1405
1406         [Service Worker] Add stubs for Client / WindowClient / Clients
1407         https://bugs.webkit.org/show_bug.cgi?id=178469
1408
1409         Reviewed by Youenn Fablet.
1410
1411         Rename PageVisiblityState to VisibilityState.
1412
1413         * WebView/WebView.mm:
1414         (kit):
1415
1416 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1417
1418         Unreviewed, rolling out r223291.
1419
1420         See WebCore ChangeLog for more detail.
1421
1422         Reverted changeset:
1423
1424         "Remove Editor::simplifyMarkup"
1425         https://bugs.webkit.org/show_bug.cgi?id=178271
1426         https://trac.webkit.org/changeset/223291
1427
1428 2017-10-17  Keith Miller  <keith_miller@apple.com>
1429
1430         Change WebCore sources to work with unified source builds
1431         https://bugs.webkit.org/show_bug.cgi?id=178229
1432
1433         Rubber stamped by Tim Horton.
1434
1435         * Configurations/FeatureDefines.xcconfig:
1436
1437 2017-10-16  Sam Weinig  <sam@webkit.org>
1438
1439         [Settings] Remove all custom code from Settings.h/cpp
1440         https://bugs.webkit.org/show_bug.cgi?id=178330
1441
1442         Reviewed by Simon Fraser.
1443
1444         * WebView/WebPreferences.mm:
1445         (+[WebPreferences initialize]):
1446         
1447             Update for naming changes of FrameFlattening now that it is an enum class.
1448
1449 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1450
1451         Remove Editor::simplifyMarkup
1452         https://bugs.webkit.org/show_bug.cgi?id=178271
1453
1454         Reviewed by Wenson Hsieh.
1455
1456         * WebView/WebView.mm:
1457         (-[WebView _simplifyMarkup:endNode:]):
1458
1459 2017-10-12  Chris Dumez  <cdumez@apple.com>
1460
1461         [Mac] Add support for MouseEvent.buttons
1462         https://bugs.webkit.org/show_bug.cgi?id=178214
1463
1464         Reviewed by Ryosuke Niwa.
1465
1466         * WebView/WebPDFView.mm:
1467         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1468
1469 2017-10-11  Sam Weinig  <sam@webkit.org>
1470
1471         Remove out-parameter variants of copyToVector
1472         https://bugs.webkit.org/show_bug.cgi?id=178155
1473
1474         Reviewed by Tim Horton.
1475
1476         * Plugins/WebNetscapePluginView.mm:
1477         (-[WebNetscapePluginView destroyPlugin]):
1478         * WebView/WebHTMLRepresentation.mm:
1479         (newArrayWithStrings):
1480
1481             Replace out-parameter based copyToVector, with one that returns a Vector.
1482
1483 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1484
1485         Sanitize URL in pasteboard for other applications and cross origin content
1486         https://bugs.webkit.org/show_bug.cgi?id=178060
1487         <rdar://problem/34874518>
1488
1489         Reviewed by Wenson Hsieh.
1490
1491         * WebCoreSupport/WebPlatformStrategies.h:
1492         * WebCoreSupport/WebPlatformStrategies.mm:
1493         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1494
1495 2017-10-11  Chris Dumez  <cdumez@apple.com>
1496
1497         Modernize Geolocation code
1498         https://bugs.webkit.org/show_bug.cgi?id=178148
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         * WebCoreSupport/WebGeolocationClient.h:
1503         * WebCoreSupport/WebGeolocationClient.mm:
1504         (WebGeolocationClient::lastPosition):
1505         * WebView/WebGeolocationPosition.mm:
1506         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1507         (core):
1508         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1509         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1510         * WebView/WebGeolocationPositionInternal.h:
1511
1512 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1513
1514         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1515         https://bugs.webkit.org/show_bug.cgi?id=178154
1516
1517         Reviewed by Wenson Hsieh.
1518
1519         Enable custom pasteboard data by default.
1520
1521         * WebView/WebPreferenceKeysPrivate.h:
1522         * WebView/WebPreferences.mm:
1523         (+[WebPreferences initialize]):
1524         (-[WebPreferences customPasteboardDataEnabled]): Added.
1525         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1526         * WebView/WebPreferencesPrivate.h:
1527         * WebView/WebView.mm:
1528         (-[WebView _preferencesChanged:]):
1529
1530 2017-10-10  Sam Weinig  <sam@webkit.org>
1531
1532         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1533         https://bugs.webkit.org/show_bug.cgi?id=178102
1534
1535         Reviewed by Tim Horton.
1536
1537         * History/WebHistory.mm:
1538         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1539         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1540         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1541         * WebCoreSupport/WebUserMediaClient.mm:
1542         (WebUserMediaClient::pageDestroyed):
1543
1544 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1545
1546         Make the names of the options consistent
1547         https://bugs.webkit.org/show_bug.cgi?id=177933
1548
1549         Reviewed by Saam Barati.
1550
1551         * WebView/WebFrame.h:
1552         * WebView/WebHTMLView.mm:
1553         (-[WebHTMLView setMarkedText:selectedRange:]):
1554         * WebView/WebView.h:
1555
1556 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1557
1558         [iOS] Tweak support for classifying form controls (followup to r222487)
1559         https://bugs.webkit.org/show_bug.cgi?id=177917
1560         <rdar://problem/34820122>
1561
1562         Reviewed by Dean Jackson.
1563
1564         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1565
1566         * DOM/DOMHTMLInputElement.mm:
1567         (-[DOMHTMLInputElement _autofillContext]):
1568         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1569         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1570
1571 2017-10-05  Keith Miller  <keith_miller@apple.com>
1572
1573         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1574
1575         * Configurations/WebKitLegacy.xcconfig:
1576
1577 2017-10-05  Jer Noble  <jer.noble@apple.com>
1578
1579         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1580         https://bugs.webkit.org/show_bug.cgi?id=177261
1581
1582         Reviewed by Eric Carlson.
1583
1584         * Configurations/FeatureDefines.xcconfig:
1585
1586 2017-10-05  Chris Dumez  <cdumez@apple.com>
1587
1588         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1589         https://bugs.webkit.org/show_bug.cgi?id=177957
1590
1591         Reviewed by Alex Christensen.
1592
1593         * WebCoreSupport/WebPlatformStrategies.h:
1594         * WebCoreSupport/WebPlatformStrategies.mm:
1595         (WebPlatformStrategies::cookiesEnabled):
1596
1597 2017-10-05  Youenn Fablet  <youenn@apple.com>
1598
1599         Make LibWebRTCProvider port agnostic
1600         https://bugs.webkit.org/show_bug.cgi?id=177747
1601
1602         Reviewed by Alex Christensen & Alex Garcia.
1603
1604         * WebView/WebView.mm:
1605         (-[WebView _commonInitializationWithFrameName:groupName:]):
1606         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1607
1608 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1609
1610         Stop linking with WebKitSystemInterface
1611         https://bugs.webkit.org/show_bug.cgi?id=177915
1612
1613         Reviewed by Antti Koivisto.
1614
1615         * Configurations/DebugRelease.xcconfig:
1616         * Configurations/WebKitLegacy.xcconfig:
1617
1618 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1619
1620         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1621         https://bugs.webkit.org/show_bug.cgi?id=177912
1622
1623         Reviewed by Saam Barati.
1624
1625         * Carbon/CarbonUtils.m:
1626         * Carbon/CarbonWindowAdapter.mm:
1627         * Carbon/HIWebView.mm:
1628         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1629         * Misc/WebNSFileManagerExtras.mm:
1630         * Misc/WebNSPasteboardExtras.mm:
1631         * Misc/WebNSURLExtras.mm:
1632         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1633         * Plugins/Hosted/NetscapePluginHostManager.mm:
1634         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1635         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1636         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1637         * Plugins/Hosted/WebTextInputWindowController.m:
1638         * Plugins/WebBaseNetscapePluginView.mm:
1639         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1640         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1641         * Plugins/WebNetscapePluginStream.mm:
1642         * Plugins/WebNetscapePluginView.mm:
1643         * Plugins/WebPluginDatabase.mm:
1644         * WebCoreSupport/PopupMenuMac.mm:
1645         * WebCoreSupport/WebChromeClient.mm:
1646         * WebCoreSupport/WebFrameLoaderClient.mm:
1647         * WebCoreSupport/WebInspectorClient.mm:
1648         * WebCoreSupport/WebPlatformStrategies.mm:
1649         * WebCoreSupport/WebSystemInterface.mm:
1650         * WebView/WebDynamicScrollBarsView.mm:
1651         * WebView/WebFrame.mm:
1652         * WebView/WebFrameView.mm:
1653         * WebView/WebFullScreenController.mm:
1654         * WebView/WebHTMLView.mm:
1655         * WebView/WebPreferences.mm:
1656         * WebView/WebView.mm:
1657
1658 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1659
1660         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1661         rdar://problem/34705779
1662
1663         Addressing review comments that I somehow landed without.
1664
1665         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1666
1667 2017-09-29  Chris Dumez  <cdumez@apple.com>
1668
1669         Split some logic out of VisitedLinkStore and make it reusable
1670         https://bugs.webkit.org/show_bug.cgi?id=177575
1671
1672         Reviewed by Alex Christensen.
1673
1674         * WebCoreSupport/WebVisitedLinkStore.h:
1675         * WebCoreSupport/WebVisitedLinkStore.mm:
1676         (WebVisitedLinkStore::addVisitedLink):
1677         (WebVisitedLinkStore::removeVisitedLink):
1678         (WebVisitedLinkStore::isLinkVisited):
1679         (WebVisitedLinkStore::addVisitedLinkHash):
1680
1681 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1682
1683         Build fix for High Sierra 32 bit Mac
1684         https://bugs.webkit.org/show_bug.cgi?id=177551
1685         <rdar://problem/34690283>
1686
1687         Reviewed by Alexey Proskuryakov.
1688
1689         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1690         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1691         also made.
1692
1693         * Carbon/CarbonWindowAdapter.mm:
1694         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1695         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1696         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1697         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1698         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1699         (-[CarbonWindowAdapter dealloc]):
1700         (-[CarbonWindowAdapter windowRef]):
1701         (-[CarbonWindowAdapter _hasWindowRef]):
1702         (-[CarbonWindowAdapter _managesWindowRef]):
1703         (-[CarbonWindowAdapter _removeWindowRef]):
1704         (-[CarbonWindowAdapter _carbonWindowClass]):
1705         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1706         (-[CarbonWindowAdapter sendSuperEvent:]):
1707         (-[CarbonWindowAdapter relinquishFocus]):
1708         (-[CarbonWindowAdapter _cancelKey:]):
1709         (-[CarbonWindowAdapter _commonAwake]):
1710         (-[CarbonWindowAdapter _destroyRealWindow:]):
1711         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1712         (-[CarbonWindowAdapter _termWindowIfOwner]):
1713         (-[CarbonWindowAdapter _windowMovedToRect:]):
1714         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1715         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1716         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1717         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1718         (-[CarbonWindowAdapter canBecomeMainWindow]):
1719         (-[CarbonWindowAdapter encodeWithCoder:]):
1720         (-[CarbonWindowAdapter initWithCoder:]):
1721         (-[CarbonWindowAdapter setContentView:]):
1722         (-[CarbonWindowAdapter worksWhenModal]):
1723         (-[CarbonWindowAdapter _setModalWindowLevel]):
1724         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1725         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1726         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1727         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1728         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1729         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1730         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1731         (NSCarbonWindowHandleEvent):
1732         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1733         (-[CarbonWindowAdapter _growBoxRect]):
1734         * Carbon/HIWebView.mm:
1735         (HIWebViewGetWebView):
1736         (HIWebViewConstructor):
1737         (HIWebViewDestructor):
1738         (HIWebViewRegisterClass):
1739         (GetBehaviors):
1740         (Draw):
1741         (HitTest):
1742         (GetRegion):
1743         (GetWindowRef):
1744         (CreateNSEventAdoptingCGEvent):
1745         (CopyEventCGEvent):
1746         (CreateNSEventWithCarbonClickEvent):
1747         (Click):
1748         (CreateNSEventWithCarbonEvent):
1749         (MouseUp):
1750         (CreateNSEventWithCarbonMouseMoveEvent):
1751         (MouseMoved):
1752         (MouseDragged):
1753         (MouseWheelMoved):
1754         (ContextMenuClick):
1755         (GetKind):
1756         (BoundsChanged):
1757         (OwningWindowChanged):
1758         (WindowHandler):
1759         (SyncFrame):
1760         (SetFocusPart):
1761         (AdvanceFocus):
1762         (RelinquishFocus):
1763         (ActiveStateChanged):
1764         (ProcessCommand):
1765         (UpdateCommandStatus):
1766         (_NSSelectorForHICommand):
1767         (HIWebViewEventHandler):
1768         (StartUpdateObserver):
1769         (StopUpdateObserver):
1770         (UpdateObserver):
1771
1772 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1773
1774         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1775         https://bugs.webkit.org/show_bug.cgi?id=172526
1776         <rdar://problem/32396081>
1777
1778         Reviewed by Ryosuke Niwa.
1779
1780         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1781
1782         * WebCoreSupport/WebPlatformStrategies.h:
1783         * WebCoreSupport/WebPlatformStrategies.mm:
1784         (WebPlatformStrategies::webExposedTypes):
1785         (WebPlatformStrategies::writeCustomData):
1786
1787 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1788
1789         Unreviewed, rolling out r222567.
1790
1791         This broke and internal build.
1792
1793         Reverted changeset:
1794
1795         "Build fix for High Sierra 32 bit Mac"
1796         https://bugs.webkit.org/show_bug.cgi?id=177551
1797         http://trac.webkit.org/changeset/222567
1798
1799 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1800
1801         Build fix for High Sierra 32 bit Mac
1802         https://bugs.webkit.org/show_bug.cgi?id=177551
1803         <rdar://problem/34690283>
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1808         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1809         also made.
1810
1811         * Carbon/CarbonWindowAdapter.mm:
1812         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1813         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1814         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1815         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1816         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1817         (-[CarbonWindowAdapter dealloc]):
1818         (-[CarbonWindowAdapter windowRef]):
1819         (-[CarbonWindowAdapter _hasWindowRef]):
1820         (-[CarbonWindowAdapter _managesWindowRef]):
1821         (-[CarbonWindowAdapter _removeWindowRef]):
1822         (-[CarbonWindowAdapter _carbonWindowClass]):
1823         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1824         (-[CarbonWindowAdapter sendSuperEvent:]):
1825         (-[CarbonWindowAdapter relinquishFocus]):
1826         (-[CarbonWindowAdapter _cancelKey:]):
1827         (-[CarbonWindowAdapter _commonAwake]):
1828         (-[CarbonWindowAdapter _destroyRealWindow:]):
1829         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1830         (-[CarbonWindowAdapter _termWindowIfOwner]):
1831         (-[CarbonWindowAdapter _windowMovedToRect:]):
1832         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1833         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1834         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1835         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1836         (-[CarbonWindowAdapter canBecomeMainWindow]):
1837         (-[CarbonWindowAdapter encodeWithCoder:]):
1838         (-[CarbonWindowAdapter initWithCoder:]):
1839         (-[CarbonWindowAdapter setContentView:]):
1840         (-[CarbonWindowAdapter worksWhenModal]):
1841         (-[CarbonWindowAdapter _setModalWindowLevel]):
1842         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1843         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1844         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1845         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1846         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1847         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1848         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1849         (NSCarbonWindowHandleEvent):
1850         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1851         (-[CarbonWindowAdapter _growBoxRect]):
1852         * Carbon/HIWebView.mm:
1853         (HIWebViewGetWebView):
1854         (HIWebViewConstructor):
1855         (HIWebViewDestructor):
1856         (HIWebViewRegisterClass):
1857         (GetBehaviors):
1858         (Draw):
1859         (HitTest):
1860         (GetRegion):
1861         (GetWindowRef):
1862         (CreateNSEventAdoptingCGEvent):
1863         (CopyEventCGEvent):
1864         (CreateNSEventWithCarbonClickEvent):
1865         (Click):
1866         (CreateNSEventWithCarbonEvent):
1867         (MouseUp):
1868         (CreateNSEventWithCarbonMouseMoveEvent):
1869         (MouseMoved):
1870         (MouseDragged):
1871         (MouseWheelMoved):
1872         (ContextMenuClick):
1873         (GetKind):
1874         (BoundsChanged):
1875         (OwningWindowChanged):
1876         (WindowHandler):
1877         (SyncFrame):
1878         (SetFocusPart):
1879         (AdvanceFocus):
1880         (RelinquishFocus):
1881         (ActiveStateChanged):
1882         (ProcessCommand):
1883         (UpdateCommandStatus):
1884         (_NSSelectorForHICommand):
1885         (HIWebViewEventHandler):
1886         (StartUpdateObserver):
1887         (StopUpdateObserver):
1888         (UpdateObserver):
1889
1890 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1891
1892         Make PolicyAction an encodable enum class
1893         https://bugs.webkit.org/show_bug.cgi?id=177480
1894
1895         Reviewed by Antti Koivisto.
1896
1897         * Plugins/WebPluginContainerCheck.mm:
1898         (-[WebPluginContainerCheck _continueWithPolicy:]):
1899         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1900         * WebCoreSupport/WebFrameLoaderClient.mm:
1901         (-[WebFramePolicyListener invalidate]):
1902         (-[WebFramePolicyListener ignore]):
1903         (-[WebFramePolicyListener download]):
1904         (-[WebFramePolicyListener use]):
1905         (-[WebFramePolicyListener continue]):
1906         * WebView/WebPolicyDelegate.mm:
1907         (-[WebPolicyDecisionListener use]):
1908         (-[WebPolicyDecisionListener ignore]):
1909         (-[WebPolicyDecisionListener download]):
1910
1911 2017-09-25  Frederik Riedel  <riedel@apple.com>
1912
1913         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1914         https://bugs.webkit.org/show_bug.cgi?id=174394
1915         <rdar://problem/33183504>
1916
1917         Reviewed by Ryosuke Niwa.
1918
1919         * DOM/DOMHTMLInputElement.h:
1920         * DOM/DOMHTMLInputElement.mm:
1921         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1922         Determines if this HTMLInputElement is part of a login screen.
1923         (-[DOMHTMLInputElement representingPageUrl]):
1924         Returns the webpage's URL that is currently displayed in the Web View.
1925         (-[DOMHTMLInputElement insertTextSuggestion:]):
1926         Inserts login credentials into the Web View.
1927
1928 2017-09-25  Sam Weinig  <sam@webkit.org>
1929
1930         Remove unused EditorClient functions
1931         https://bugs.webkit.org/show_bug.cgi?id=177463
1932
1933         Reviewed by Alex Christensen.
1934
1935         Remove unused EditorClient functions.
1936
1937         * WebCoreSupport/WebEditorClient.h:
1938         * WebCoreSupport/WebEditorClient.mm:
1939         (WebEditorClient::canonicalizeURL): Deleted.
1940         (WebEditorClient::canonicalizeURLString): Deleted.
1941         (WebEditorClient::writeDataToPasteboard): Deleted.
1942         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1943         (WebEditorClient::readDataFromPasteboard): Deleted.
1944         (WebEditorClient::pasteboardChangeCount): Deleted.
1945
1946 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1947
1948         Stop using PolicyCallback
1949         https://bugs.webkit.org/show_bug.cgi?id=176088
1950
1951         Reviewed by Andy Estes.
1952
1953         * WebCoreSupport/WebFrameLoaderClient.mm:
1954         (-[WebFramePolicyListener invalidate]):
1955         (-[WebFramePolicyListener receivedPolicyDecision:]):
1956
1957 2017-09-25  Sam Weinig  <sam@webkit.org>
1958
1959         Remove unnecessary userVisibleString EditorClient function
1960         https://bugs.webkit.org/show_bug.cgi?id=177456
1961
1962         Reviewed by Dan Bernstein.
1963
1964         * WebCoreSupport/WebEditorClient.h:
1965         * WebCoreSupport/WebEditorClient.mm:
1966         (WebEditorClient::userVisibleString): Deleted.
1967
1968             Remove userVisibleString client function.
1969
1970 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1971
1972         Separate form submission from PolicyChecker infrastructure
1973         https://bugs.webkit.org/show_bug.cgi?id=177396
1974
1975         Reviewed by Geoffrey Garen.
1976
1977         * WebCoreSupport/WebFrameLoaderClient.h:
1978         * WebCoreSupport/WebFrameLoaderClient.mm:
1979         (WebFrameLoaderClient::dispatchWillSubmitForm):
1980
1981 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1982
1983         WeakPtrFactory should populate m_ref lazily.
1984         https://bugs.webkit.org/show_bug.cgi?id=177375
1985
1986         Reviewed by Geoffrey Garen.
1987
1988         * WebCoreSupport/WebEditorClient.mm:
1989         (WebEditorClient::WebEditorClient):
1990         (WebEditorClient::requestCandidatesForSelection):
1991
1992 2017-09-22  Chris Dumez  <cdumez@apple.com>
1993
1994         Use high resolution timestamp for event time
1995         https://bugs.webkit.org/show_bug.cgi?id=154246
1996         <rdar://problem/34333304>
1997
1998         Reviewed by Ryosuke Niwa.
1999
2000         Use WallTime / MonotonicTime instead of double type for clarity.
2001
2002         * DOM/DOMEvent.mm:
2003         (-[DOMEvent timeStamp]):
2004         * WebView/WebFrame.mm:
2005         (-[WebFrame _dragSourceEndedAt:operation:]):
2006         * WebView/WebPDFView.mm:
2007         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2008
2009 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2010
2011         Enable dataTransfer.items on macOS and iOS
2012         https://bugs.webkit.org/show_bug.cgi?id=177335
2013
2014         Reviewed by Sam Weinig.
2015
2016         * WebView/WebPreferences.mm:
2017         (+[WebPreferences initialize]):
2018
2019 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2020
2021         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2022         https://bugs.webkit.org/show_bug.cgi?id=177101
2023         <rdar://problem/34500648>
2024
2025         Reviewed by Brian Burg.
2026
2027         * WebInspector/WebNodeHighlight.mm:
2028         Ensure we close the window that we have just removed.
2029
2030 2017-09-20  Antti Koivisto  <antti@apple.com>
2031
2032         Remove DOM and styling support for CSS Regions
2033         https://bugs.webkit.org/show_bug.cgi?id=177221
2034
2035         Reviewed by Andreas Kling.
2036
2037         * Configurations/FeatureDefines.xcconfig:
2038         * DOM/DOMCSS.mm:
2039         (kitClass):
2040         * DOM/DOMElement.mm:
2041         (-[DOMElement webkitRegionOverset]): Deleted.
2042
2043 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2044
2045         Layering violation in Editor::createFragment
2046         https://bugs.webkit.org/show_bug.cgi?id=176123
2047
2048         Reviewed by Darin Adler.
2049
2050         * Misc/WebNSURLExtras.h:
2051         * Misc/WebNSURLExtras.mm:
2052         * WebView/WebFrame.mm:
2053         * WebView/WebHTMLView.mm:
2054         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2055
2056         * WebCoreSupport/WebEditorClient.mm:
2057         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2058         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2059         way to avoid exporting the symbol just on newer OSes.
2060
2061 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         On iOS, getData can't get text set by setData during copy event
2064         https://bugs.webkit.org/show_bug.cgi?id=176980
2065         <rdar://problem/34453915>
2066
2067         Reviewed by Darin Adler.
2068
2069         * WebCoreSupport/WebPlatformStrategies.h:
2070         * WebCoreSupport/WebPlatformStrategies.mm:
2071         (WebPlatformStrategies::copy): Deleted.
2072
2073 2017-09-18  Andy Estes  <aestes@apple.com>
2074
2075         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2076         https://bugs.webkit.org/show_bug.cgi?id=177029
2077
2078         Reviewed by Alex Christensen.
2079
2080         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2081         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2082         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2083         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2084         * WebCoreSupport/PopupMenuMac.mm:
2085         (PopupMenuMac::show):
2086         * WebCoreSupport/WebSystemInterface.mm:
2087         (InitWebCoreSystemInterface):
2088         * WebView/WebHTMLView.mm:
2089         (-[WebHTMLView setDataSource:]):
2090         (-[WebHTMLView attachRootLayer:]):
2091         * WebView/WebView.mm:
2092         (-[WebView _needsAdobeFrameReloadingQuirk]):
2093         (-[WebView _needsLinkElementTextCSSQuirk]):
2094         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2095         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2096         (-[WebView _preferencesChanged:]):
2097
2098 2017-09-15  Andy Estes  <aestes@apple.com>
2099
2100         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2101         https://bugs.webkit.org/show_bug.cgi?id=176953
2102
2103         Reviewed by Eric Carlson.
2104
2105         * WebCoreSupport/WebSystemInterface.mm:
2106         (InitWebCoreSystemInterface):
2107
2108 2017-09-14  Andy Estes  <aestes@apple.com>
2109
2110         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2111         https://bugs.webkit.org/show_bug.cgi?id=176931
2112
2113         Reviewed by Joseph Pecoraro.
2114
2115         * WebCoreSupport/WebSystemInterface.mm:
2116         (InitWebCoreSystemInterface):
2117
2118 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2119
2120         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2121         https://bugs.webkit.org/show_bug.cgi?id=176867
2122
2123         Reviewed by Sam Weinig.
2124
2125         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2126         (WebKit::NetscapePluginInstanceProxy::enumerate):
2127
2128 2017-09-13  Andy Estes  <aestes@apple.com>
2129
2130         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2131         https://bugs.webkit.org/show_bug.cgi?id=176729
2132
2133         Reviewed by Alex Christensen.
2134
2135         * WebCoreSupport/WebSystemInterface.mm:
2136         (InitWebCoreSystemInterface):
2137         * WebView/WebView.mm:
2138         (+[WebView _setCacheModel:]):
2139
2140 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2141
2142         Refactor WebContentReader out of EditorMac and EditorIOS
2143         https://bugs.webkit.org/show_bug.cgi?id=176770
2144
2145         Reviewed by Sam Weinig.
2146
2147         * WebCoreSupport/WebEditorClient.mm:
2148
2149 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2150
2151         Dragging & dropping a file creates an attachment element even when it's disabled
2152         https://bugs.webkit.org/show_bug.cgi?id=176769
2153
2154         Reviewed by Tim Horton.
2155
2156         * WebView/WebView.mm:
2157         (-[WebView _preferencesChanged:]):
2158
2159 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2160
2161         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2162         https://bugs.webkit.org/show_bug.cgi?id=176721
2163         <rdar://problem/34373660>
2164
2165         Reviewed by Tim Horton.
2166
2167         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2168         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2169
2170         * WebView/WebView.mm:
2171         (-[WebView _startDrag:]):
2172         (-[WebView _draggedElementBounds]):
2173         (-[WebView _endedDataInteraction:global:]):
2174         * WebView/WebViewData.h:
2175
2176 2017-09-11  Andy Estes  <aestes@apple.com>
2177
2178         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2179         https://bugs.webkit.org/show_bug.cgi?id=176472
2180
2181         Reviewed by Eric Carlson.
2182
2183         * WebCoreSupport/WebSystemInterface.mm:
2184         (InitWebCoreSystemInterface):
2185
2186 2017-09-09  Mark Lam  <mark.lam@apple.com>
2187
2188         Avoid duplicate computations of ExecState::vm().
2189         https://bugs.webkit.org/show_bug.cgi?id=176647
2190
2191         Reviewed by Saam Barati.
2192
2193         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2194         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2195         (WebKit::NetscapePluginInstanceProxy::construct):
2196         (WebKit::NetscapePluginInstanceProxy::setProperty):
2197         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2198         (WebKit::NetscapePluginInstanceProxy::enumerate):
2199         * Plugins/Hosted/ProxyInstance.mm:
2200         (WebKit::ProxyRuntimeMethod::create):
2201
2202 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2203
2204         Unreviewed, rolling out r221773.
2205         https://bugs.webkit.org/show_bug.cgi?id=176614
2206
2207         This caused build failures. (Requested by mlewis13 on
2208         #webkit).
2209
2210         Reverted changeset:
2211
2212         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2213         https://bugs.webkit.org/show_bug.cgi?id=176472
2214         http://trac.webkit.org/changeset/221773
2215
2216 2017-09-07  Andy Estes  <aestes@apple.com>
2217
2218         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2219         https://bugs.webkit.org/show_bug.cgi?id=176472
2220
2221         Reviewed by Eric Carlson.
2222
2223         * WebCoreSupport/WebSystemInterface.mm:
2224         (InitWebCoreSystemInterface):
2225
2226 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2227
2228         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2229         https://bugs.webkit.org/show_bug.cgi?id=176561
2230
2231         Reviewed by Brent Fulgham.
2232
2233         * Misc/WebNSUserDefaultsExtras.mm:
2234
2235 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2236
2237         Modernize Geolocation code
2238         https://bugs.webkit.org/show_bug.cgi?id=176496
2239
2240         Reviewed by Andy Estes.
2241
2242         * WebCoreSupport/WebGeolocationClient.h:
2243         * WebCoreSupport/WebGeolocationClient.mm:
2244         (WebGeolocationClient::requestPermission):
2245         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2246         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2247         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2248         * WebView/WebView.mm:
2249         (-[WebView _commonInitializationWithFrameName:groupName:]):
2250         (-[WebView _geolocationDidFailWithMessage:]):
2251
2252 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2253
2254         Remove some unused bits of code and resources
2255         https://bugs.webkit.org/show_bug.cgi?id=176275
2256
2257         Reviewed by Dan Bernstein.
2258
2259         * Misc/WebNSFileManagerExtras.mm:
2260         Include FileSystem instead of FileSystemIOS.
2261
2262 2017-09-03  Darin Adler  <darin@apple.com>
2263
2264         [Cocoa] Tidy a few things in legacy WebHTMLView
2265         https://bugs.webkit.org/show_bug.cgi?id=176280
2266
2267         Reviewed by Dan Bernstein.
2268
2269         * WebCoreSupport/WebChromeClient.mm:
2270         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2271         methods it calls on WebHTMLView were doing nothing on iOS.
2272
2273         * WebView/WebFrame.mm:
2274         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2275         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2276
2277         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2278         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2279         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2280         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2281         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2282         Use RetainPtr instead of writing retain/release wherever possible.
2283         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2284         initialization for it. Removed various unused methods and declarations of methods.
2285         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2286         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2287         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2288         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2289         and remove CFRetain no longer needed since we don't support garbage collection any more.
2290         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2291         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2292         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2293         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2294         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2295         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2296         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2297         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2298         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2299         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2300         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2301         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2302         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2303         debug flag; we haven't used it for years and it's not clearly helpful.
2304         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2305         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2306         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2307         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2308         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2309         two additional methods in the WebPrivate category and still be called by the two
2310         methods in the WebInternal category that were already using it.
2311         (-[WebHTMLView didAddSubview:]): Deleted.
2312         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2313         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2314         place this was called, the close method.
2315         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2316         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2317         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2318         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2319         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2320         Added helper method to make the one below simpler.
2321         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2322         Compared pasteboard type strings using isEqualToString: rather than using == since
2323         we want to actually compare the string contents. Also updated to use modern for loop,
2324         renamed a local variable from "s" to "localSubresources", and factored out the handling
2325         of three image types to use the helper method above.
2326         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2327         _web_makePluginSubviewsPerformSelector:withObject: method.
2328         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2329         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2330         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2331         not call the -[NSView subviews] method to make this identical on both platforms and used
2332         a modern for loop.
2333         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2334         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2335         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2336         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2337         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2338         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2339         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2340         of it is Mac-only.
2341         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2342         method did was call itself on the main thread, and do nothing if called on main thread.
2343         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2344         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2345         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2346         half of this method.
2347         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2348         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2349         Simplified using a modern for loop and RetainPtr.
2350         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2351         (-[WebHTMLView keyDown:]): Ditto.
2352         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2353         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2354         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2355         (-[WebHTMLView complete:]): Ditto.
2356         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2357         now macOS-only.
2358         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2359         iOS since that is now macOS-only.
2360         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2361         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2362         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2363         and reorganized to use early return.
2364         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2365         on iOS, but kept there so we don't have to do #if at every call site.
2366         (-[WebHTMLView _pluginController]): Moved into internal category.
2367         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2368         there only for GC, using C++ initialization, removing obsolete comment.
2369         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2370         peculiar iOS-only comment.
2371         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2372
2373         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2374         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2375         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2376         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2377         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2378
2379         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2380         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2381         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2382         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2383         them at this time.
2384
2385 2017-09-03  Sam Weinig  <sam@webkit.org>
2386
2387         Remove CanvasProxy
2388         https://bugs.webkit.org/show_bug.cgi?id=176288
2389
2390         Reviewed by Yusuke Suzuki.
2391
2392         CanvasProxy does not appear to be in any current HTML spec
2393         and was disabled and unimplemented in our tree. Time to 
2394         get rid of it.
2395
2396         * Configurations/FeatureDefines.xcconfig:
2397
2398 2017-09-02  Andy Estes  <aestes@apple.com>
2399
2400         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2401         https://bugs.webkit.org/show_bug.cgi?id=176270
2402
2403         Reviewed by Tim Horton.
2404
2405         * Plugins/Hosted/NetscapePluginHostManager.mm:
2406         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2407         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2408         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2409         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2410         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2411         (WebKit::SoftwareCARenderer::context const):
2412         (WebKit::SoftwareCARenderer::renderContext const):
2413         (WebKit::SoftwareCARenderer::render):
2414         (-[WebHostedNetscapePluginView createPlugin]):
2415         (-[WebHostedNetscapePluginView createPluginLayer]):
2416         (-[WebHostedNetscapePluginView destroyPlugin]):
2417         (-[WebHostedNetscapePluginView drawRect:]):
2418         * WebCoreSupport/WebSystemInterface.mm:
2419         (InitWebCoreSystemInterface):
2420
2421 2017-09-01  Andy Estes  <aestes@apple.com>
2422
2423         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2424         https://bugs.webkit.org/show_bug.cgi?id=176200
2425
2426         Reviewed by Tim Horton.
2427
2428         * Carbon/HIWebView.mm:
2429         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2430         (overrideCGContext):
2431         (restoreCGContext):
2432         (Draw):
2433         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2434         (+[WebHostedNetscapePluginView initialize]):
2435         * Plugins/WebBaseNetscapePluginView.h:
2436         * Plugins/WebBaseNetscapePluginView.mm:
2437         (WebKit::sendUserChangeNotifications):
2438         * Plugins/WebNetscapePluginView.mm:
2439         (+[WebNetscapePluginView initialize]):
2440         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2441         * WebCoreSupport/WebSystemInterface.mm:
2442         (InitWebCoreSystemInterface):
2443         * WebView/WebFrame.mm:
2444         (-[WebFrame _paintBehaviorForDestinationContext:]):
2445         * WebView/WebFullScreenController.mm:
2446         (setClipRectForWindow):
2447         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2448         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2449         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2450         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2451
2452 2017-08-31  Andy Estes  <aestes@apple.com>
2453
2454         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2455         https://bugs.webkit.org/show_bug.cgi?id=176175
2456
2457         Reviewed by Brady Eidson.
2458
2459         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2460         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2461         * Plugins/Hosted/WebTextInputWindowController.m:
2462         (-[WebTextInputPanel init]):
2463         * WebCoreSupport/WebSystemInterface.mm:
2464         (InitWebCoreSystemInterface):
2465         * WebView/WebDynamicScrollBarsView.mm:
2466         (-[WebDynamicScrollBarsView scrollWheel:]):
2467         * WebView/WebHTMLView.mm:
2468         (-[WebHTMLView _removeWindowObservers]):
2469         (-[WebHTMLView addWindowObservers]):
2470         * WebView/WebView.mm:
2471         (-[WebView addWindowObserversForWindow:]):
2472         (-[WebView removeWindowObservers]):
2473         (-[WebView viewWillMoveToWindow:]):
2474
2475 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2476
2477         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2478         https://bugs.webkit.org/show_bug.cgi?id=175779
2479         <rdar://problem/22367975>
2480
2481         Reviewed by Tim Horton.
2482
2483         * WebCoreSupport/WebFrameLoaderClient.h:
2484         * WebCoreSupport/WebFrameLoaderClient.mm:
2485         (WebFrameLoaderClient::webGLPolicyForURL const):
2486         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2487
2488 2017-08-30  Andy Estes  <aestes@apple.com>
2489
2490         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2491         https://bugs.webkit.org/show_bug.cgi?id=176093
2492
2493         Reviewed by Eric Carlson.
2494
2495         * WebCoreSupport/WebSystemInterface.mm:
2496         (InitWebCoreSystemInterface):
2497
2498 2017-08-30  Andy Estes  <aestes@apple.com>
2499
2500         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2501         https://bugs.webkit.org/show_bug.cgi?id=176087
2502
2503         Reviewed by Alex Christensen.
2504
2505         * Carbon/CarbonUtils.m:
2506         (getNSAutoreleasePoolCount):
2507         (WebInitForCarbon):
2508         (PoolCleaner):
2509         * Carbon/CarbonWindowAdapter.mm:
2510         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2511         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2512         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2513         (-[CarbonWindowAdapter _windowMovedToRect:]):
2514         * Carbon/HIViewAdapter.m:
2515         * Carbon/HIWebView.mm:
2516         (Draw):
2517         (CreateNSEventAdoptingCGEvent):
2518         (CopyEventCGEvent):
2519         (CreateNSEventWithCarbonClickEvent):
2520         (Click):
2521         (CreateNSEventWithCarbonEvent):
2522         (MouseUp):
2523         (CreateNSEventWithCarbonMouseMoveEvent):
2524         (MouseMoved):
2525         (MouseDragged):
2526         (MouseWheelMoved):
2527         (WindowHandler):
2528         (HIWebViewEventHandler):
2529         * Misc/QuickDrawCompatibility.h: Removed.
2530         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2531         (getCarbonEvent):
2532         (WebNetscapePluginEventHandlerCarbon::keyDown):
2533         (WebNetscapePluginEventHandlerCarbon::keyUp):
2534         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2535         (WebNetscapePluginEventHandlerCocoa::keyDown):
2536         * Plugins/WebNetscapePluginView.mm:
2537         (-[WebNetscapePluginView tellQuickTimeToChill]):
2538
2539 2017-08-29  Andy Estes  <aestes@apple.com>
2540
2541         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2542         https://bugs.webkit.org/show_bug.cgi?id=176046
2543
2544         Reviewed by Alex Christensen.
2545
2546         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2547         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2548
2549         * Misc/WebNSFileManagerExtras.mm:
2550         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2551         (setMetaData): Deleted.
2552         * WebCoreSupport/WebSystemInterface.mm:
2553         (InitWebCoreSystemInterface):
2554
2555 2017-08-28  Andy Estes  <aestes@apple.com>
2556
2557         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2558         https://bugs.webkit.org/show_bug.cgi?id=176039
2559
2560         Reviewed by Alex Christensen.
2561
2562         * WebCoreSupport/WebSystemInterface.mm:
2563         (InitWebCoreSystemInterface):
2564         * WebView/WebPreferences.mm:
2565         (+[WebPreferences _systemCFStringEncoding]):
2566
2567 2017-08-28  Andy Estes  <aestes@apple.com>
2568
2569         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2570         https://bugs.webkit.org/show_bug.cgi?id=176032
2571
2572         Reviewed by Alex Christensen.
2573
2574         * WebCoreSupport/WebSystemInterface.mm:
2575         (InitWebCoreSystemInterface):
2576         * WebView/WebView.mm:
2577         (-[WebView _cachedResponseForURL:]):
2578
2579 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2580
2581         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2582         https://bugs.webkit.org/show_bug.cgi?id=175992
2583         <rdar://problem/34086613>
2584
2585         Reviewed by Daniel Bates.
2586
2587         * WebCoreSupport/WebPlatformStrategies.h:
2588         * WebCoreSupport/WebPlatformStrategies.mm:
2589         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2590         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2591         indicating if secure cookies were accessed.
2592
2593 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2594
2595         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2596         https://bugs.webkit.org/show_bug.cgi?id=170955
2597         <rdar://problem/31697653>
2598
2599         Reviewed by Ryosuke Niwa.
2600
2601         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2602         text is being replaced.
2603
2604         * WebView/WebHTMLView.mm:
2605         (-[WebHTMLView insertText:]):
2606
2607 2017-08-24  Chris Dumez  <cdumez@apple.com>
2608
2609         [Directory Upload] Add basic support for input.webkitdirectory
2610         https://bugs.webkit.org/show_bug.cgi?id=175950
2611         <rdar://problem/33951915>
2612
2613         Reviewed by Geoffrey Garen.
2614
2615         Add private API to toggle Directory Upload support on Mac WebKit1.
2616
2617         * WebView/WebPreferenceKeysPrivate.h:
2618         * WebView/WebPreferences.mm:
2619         (+[WebPreferences initialize]):
2620         (-[WebPreferences setDirectoryUploadEnabled:]):
2621         (-[WebPreferences directoryUploadEnabled]):
2622         * WebView/WebPreferencesPrivate.h:
2623         * WebView/WebView.mm:
2624         (-[WebView _preferencesChanged:]):
2625
2626 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2627
2628         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2629         https://bugs.webkit.org/show_bug.cgi?id=175370
2630         <rdar://problem/33799806>
2631
2632         Reviewed by Ryosuke Niwa.
2633
2634         Adjust WebEditorClient for interface changes.
2635
2636         * WebCoreSupport/WebEditorClient.h:
2637
2638 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2639
2640         Remove ChromeClient::scrollbarsModeDidChange
2641         https://bugs.webkit.org/show_bug.cgi?id=175805
2642
2643         Reviewed by Daniel Bates.
2644
2645         * WebCoreSupport/WebChromeClient.h:
2646
2647 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2648
2649         Remove ChromeClient::hasOpenedPopup
2650         https://bugs.webkit.org/show_bug.cgi?id=175804
2651
2652         Reviewed by Sam Weinig.
2653
2654         * WebCoreSupport/WebChromeClient.h:
2655         * WebCoreSupport/WebChromeClient.mm:
2656         (WebChromeClient::hasOpenedPopup const): Deleted.
2657
2658 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2659
2660         Disable access to secure cookies if an HTTPS site loads mixed content
2661         https://bugs.webkit.org/show_bug.cgi?id=157053
2662         <rdar://problem/11290808>
2663
2664         Reviewed by Dan Bates.
2665
2666         * WebCoreSupport/WebPlatformStrategies.h:
2667         * WebCoreSupport/WebPlatformStrategies.mm:
2668         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2669         indicating whether secure cookies should be included in the response.
2670
2671 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2672
2673         [PAL] Move spi/mac directory into PAL
2674         https://bugs.webkit.org/show_bug.cgi?id=175649
2675
2676         Reviewed by Myles C. Maxfield.
2677
2678         * Misc/WebSharingServicePickerController.h:
2679         * WebCoreSupport/WebContextMenuClient.mm:
2680         * WebCoreSupport/WebEditorClient.mm:
2681         * WebCoreSupport/WebSelectionServiceController.mm:
2682         * WebView/WebHTMLView.mm:
2683         * WebView/WebImmediateActionController.h:
2684         * WebView/WebImmediateActionController.mm:
2685         * WebView/WebView.mm:
2686
2687 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2688
2689         [PAL] Relocate SessionID to root
2690         https://bugs.webkit.org/show_bug.cgi?id=175684
2691
2692         Reviewed by Alex Christensen.
2693
2694         * WebCoreSupport/WebFrameNetworkingContext.mm:
2695
2696 2017-08-17  Andreas Kling  <akling@apple.com>
2697
2698         Disable CSS regions at compile time
2699         https://bugs.webkit.org/show_bug.cgi?id=175630
2700
2701         Reviewed by Antti Koivisto.
2702
2703         * Configurations/FeatureDefines.xcconfig:
2704
2705 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2706
2707         [PAL] Move SessionID into PAL
2708         https://bugs.webkit.org/show_bug.cgi?id=174192
2709
2710         Reviewed by Antti Koivisto.
2711
2712         * Misc/WebCache.mm:
2713         (+[WebCache imageForURL:]):
2714         * WebCoreSupport/WebFrameLoaderClient.h:
2715         * WebCoreSupport/WebFrameLoaderClient.mm:
2716         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2717         * WebCoreSupport/WebFrameNetworkingContext.mm:
2718         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2719         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2720         (WebFrameNetworkingContext::storageSession const):
2721         * WebCoreSupport/WebPlatformStrategies.h:
2722         * WebCoreSupport/WebPlatformStrategies.mm:
2723         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2724         * WebKitPrefix.h:
2725
2726 2017-08-16  Andy Estes  <aestes@apple.com>
2727
2728         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2729         https://bugs.webkit.org/show_bug.cgi?id=175648
2730
2731         Reviewed by Tim Horton.
2732
2733         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2734         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2735         (WebPaymentCoordinatorClient::showPaymentUI):
2736
2737 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2738
2739         [PAL] Move spi/ios and spi/win directories into PAL
2740         https://bugs.webkit.org/show_bug.cgi?id=175171
2741
2742         Reviewed by Antti Koivisto.
2743
2744         * WebCoreSupport/WebFrameLoaderClient.mm:
2745         * WebView/WebView.mm:
2746
2747 2017-08-16  Andy Estes  <aestes@apple.com>
2748
2749         [Payment Request] Add an ENABLE flag and an experimental feature preference
2750         https://bugs.webkit.org/show_bug.cgi?id=175622
2751
2752         Reviewed by Tim Horton.
2753
2754         * Configurations/FeatureDefines.xcconfig:
2755
2756 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2757
2758         [PAL] Move Sleep classes into PAL
2759         https://bugs.webkit.org/show_bug.cgi?id=175456
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         * WebView/WebFullScreenController.h:
2764
2765 2017-08-15  Youenn Fablet  <youenn@apple.com>
2766
2767         [Cache API] Adding generic support for CacheStorage and Cache methods
2768         https://bugs.webkit.org/show_bug.cgi?id=175455
2769
2770         Reviewed by Chris Dumez.
2771
2772         * WebView/WebView.mm:
2773         (-[WebView _commonInitializationWithFrameName:groupName:]):
2774
2775 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2776
2777         Remove Proximity Events and related code
2778         https://bugs.webkit.org/show_bug.cgi?id=175545
2779
2780         Reviewed by Daniel Bates.
2781
2782         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2783         and other related code.
2784
2785         * Configurations/FeatureDefines.xcconfig:
2786
2787 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2788
2789         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2790         https://bugs.webkit.org/show_bug.cgi?id=175504
2791
2792         Reviewed by Sam Weinig.
2793
2794         * Configurations/FeatureDefines.xcconfig:
2795         * DOM/DOMHTMLFormElement.mm:
2796         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2797         * WebCoreSupport/WebFrameLoaderClient.h:
2798
2799 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2800
2801         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2802         https://bugs.webkit.org/show_bug.cgi?id=175557
2803
2804         Reviewed by Jon Lee.
2805
2806         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2807
2808         * Configurations/FeatureDefines.xcconfig:
2809
2810 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2811
2812         Composition underline color is always black
2813         https://bugs.webkit.org/show_bug.cgi?id=174675
2814
2815         Reviewed by Ryosuke Niwa.
2816
2817         * WebView/WebHTMLView.mm:
2818         (extractUnderlines): If NSUnderlineColorAttributeName
2819         is not present use text color for composition underline.
2820         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2821         for composition underline in the plain text case.
2822
2823 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2824
2825         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2826         https://bugs.webkit.org/show_bug.cgi?id=175474
2827         <rdar://problem/33844628>
2828
2829         Reviewed by Wenson Hsieh.
2830
2831         Replaced the build flag by a runtime flag and disabled the feature by default.
2832
2833         * Configurations/FeatureDefines.xcconfig:
2834         * WebView/WebPreferenceKeysPrivate.h:
2835         * WebView/WebPreferences.mm:
2836         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2837         (-[WebPreferences dataTransferItemsEnabled]): Added.
2838         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2839         * WebView/WebPreferencesPrivate.h:
2840         * WebView/WebView.mm:
2841         (-[WebView _preferencesChanged:]):
2842
2843 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2844
2845         Remove ENABLE_GAMEPAD_DEPRECATED
2846         https://bugs.webkit.org/show_bug.cgi?id=175361
2847
2848         Reviewed by Carlos Garcia Campos.
2849
2850         * Configurations/FeatureDefines.xcconfig:
2851
2852 2017-08-09  Chris Dumez  <cdumez@apple.com>
2853
2854         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2855         https://bugs.webkit.org/show_bug.cgi?id=175401
2856
2857         Reviewed by Brady Eidson.
2858
2859         * WebView/WebPreferenceKeysPrivate.h:
2860         * WebView/WebPreferences.mm:
2861         (+[WebPreferences initialize]):
2862         (-[WebPreferences beaconAPIEnabled]): Deleted.
2863         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2864         * WebView/WebPreferencesPrivate.h:
2865         * WebView/WebView.mm:
2866         (-[WebView _preferencesChanged:]):
2867
2868 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2869
2870         [PAL] Move spi/cocoa and spi/cg directories into PAL
2871         https://bugs.webkit.org/show_bug.cgi?id=175175
2872
2873         Reviewed by Myles C. Maxfield.
2874
2875         * History/WebHistory.mm:
2876         * Misc/WebDownload.mm:
2877         * Misc/WebKitNSStringExtras.mm:
2878         * Plugins/Hosted/NetscapePluginHostManager.mm:
2879         * Plugins/WebPluginDatabase.mm:
2880         * WebCoreSupport/WebFrameLoaderClient.mm:
2881         * WebInspector/WebNodeHighlight.mm:
2882         * WebView/WebHTMLView.mm:
2883         * WebView/WebIndicateLayer.mm:
2884         * WebView/WebView.mm:
2885         * WebView/WebViewData.h:
2886
2887 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2890         https://bugs.webkit.org/show_bug.cgi?id=175392
2891         <rdar://problem/33783207>
2892
2893         Reviewed by Tim Horton and Megan Gardner.
2894
2895         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2896
2897         * Configurations/FeatureDefines.xcconfig:
2898
2899 2017-08-09  Daniel Bates  <dabates@apple.com>
2900
2901         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2902         https://bugs.webkit.org/show_bug.cgi?id=175247
2903         <rdar://problem/33679804>
2904
2905         Reviewed by Brady Eidson.
2906
2907         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2908         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2909         clients that need to make use of this information at this time. If such a needs comes up
2910         then we can expose API/SPI similar to what we do for WebKit.
2911
2912         * WebCoreSupport/WebFrameLoaderClient.h:
2913         * WebCoreSupport/WebFrameLoaderClient.mm:
2914         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2915
2916 2017-08-08  Brady Eidson  <beidson@apple.com>
2917
2918         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2919         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2920
2921         Reviewed by Andy Estes.
2922
2923         * Misc/WebKitVersionChecks.h:
2924         * WebCoreSupport/WebFrameLoaderClient.mm:
2925         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2926           the app is linked against new WebKit with the new behavior.
2927
2928 2017-08-07  Devin Rousso  <drousso@apple.com>
2929
2930         Web Inspector: Preview Canvas path when viewing a recording
2931         https://bugs.webkit.org/show_bug.cgi?id=174967
2932
2933         Reviewed by Brian Burg.
2934
2935         * WebView/WebPreferenceKeysPrivate.h:
2936         * WebView/WebPreferences.mm:
2937         (+[WebPreferences initialize]):
2938         (-[WebPreferences inspectorAdditionsEnabled]):
2939         (-[WebPreferences setInspectorAdditionsEnabled:]):
2940         * WebView/WebPreferencesPrivate.h:
2941         * WebView/WebView.mm:
2942         (-[WebView _preferencesChanged:]):
2943         Add plumbing for new InspectorAdditions runtime flag.
2944
2945 2017-08-07  Brian Burg  <bburg@apple.com>
2946
2947         Remove CANVAS_PATH compilation guard
2948         https://bugs.webkit.org/show_bug.cgi?id=175207
2949
2950         Reviewed by Sam Weinig.
2951
2952         * Configurations/FeatureDefines.xcconfig:
2953
2954 2017-08-04  Youenn Fablet  <youenn@apple.com>
2955
2956         [Cache API] Add Cache and CacheStorage IDL definitions
2957         https://bugs.webkit.org/show_bug.cgi?id=175201
2958
2959         Reviewed by Brady Eidson.
2960
2961         * WebView/WebPreferenceKeysPrivate.h:
2962         * WebView/WebPreferences.mm:
2963         (+[WebPreferences initialize]):
2964         (-[WebPreferences cacheAPIEnabled]):
2965         (-[WebPreferences setCacheAPIEnabled:]):
2966         * WebView/WebPreferencesPrivate.h:
2967         * WebView/WebView.mm:
2968         (-[WebView _preferencesChanged:]):
2969
2970 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2971
2972         Unreviewed, rolling out r220271.
2973
2974         Rolling out due to Layout Test failing on iOS Simulator.
2975
2976         Reverted changeset:
2977
2978         "Remove STREAMS_API compilation guard"
2979         https://bugs.webkit.org/show_bug.cgi?id=175165
2980         http://trac.webkit.org/changeset/220271
2981
2982 2017-08-04  Youenn Fablet  <youenn@apple.com>
2983
2984         Remove STREAMS_API compilation guard
2985         https://bugs.webkit.org/show_bug.cgi?id=175165
2986
2987         Reviewed by Darin Adler.
2988
2989         * Configurations/FeatureDefines.xcconfig:
2990         * WebView/WebPreferences.mm:
2991         (+[WebPreferences initialize]):
2992         * WebView/WebView.mm:
2993         (-[WebView _preferencesChanged:]):
2994
2995 2017-08-03  Brian Burg  <bburg@apple.com>
2996
2997         Remove ENABLE(WEB_SOCKET) guards
2998         https://bugs.webkit.org/show_bug.cgi?id=167044
2999
3000         Reviewed by Joseph Pecoraro.
3001
3002         * Configurations/FeatureDefines.xcconfig:
3003         * WebView/WebPreferencesPrivate.h:
3004
3005 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3006
3007         [PAL] Move spi/cf directory into PAL
3008         https://bugs.webkit.org/show_bug.cgi?id=175057
3009
3010         Reviewed by Antti Koivisto.
3011
3012         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3013         * Plugins/WebNetscapePluginStream.mm:
3014         * WebCoreSupport/WebFrameNetworkingContext.mm:
3015         * WebView/WebPreferences.mm:
3016         * WebView/WebView.mm:
3017
3018 2017-08-03  Youenn Fablet  <youenn@apple.com>
3019
3020         Remove FETCH_API compilation guard
3021         https://bugs.webkit.org/show_bug.cgi?id=175154
3022
3023         Reviewed by Chris Dumez.
3024
3025         * Configurations/FeatureDefines.xcconfig:
3026         * WebView/WebPreferences.mm:
3027         (+[WebPreferences initialize]):
3028         * WebView/WebView.mm:
3029         (-[WebView _preferencesChanged:]):
3030
3031 2017-08-03  Brady Eidson  <beidson@apple.com>
3032
3033         Add SW IDLs and stub out basic functionality.
3034         https://bugs.webkit.org/show_bug.cgi?id=175115
3035
3036         Reviewed by Chris Dumez.
3037
3038         * Configurations/FeatureDefines.xcconfig:
3039
3040 2017-08-02  Sam Weinig  <sam@webkit.org>
3041
3042         [WebIDL] Convert MutationCallback to be a normal generated callback
3043         https://bugs.webkit.org/show_bug.cgi?id=174140
3044
3045         Reviewed by Darin Adler.
3046
3047         * DOM/DOMDocument.mm:
3048         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3049         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3050         Pass, now necessary, Document to NativeNodeFilter constructor.
3051
3052 2017-08-01  Chris Dumez  <cdumez@apple.com>
3053
3054         Add initial support for navigator.sendBeacon
3055         https://bugs.webkit.org/show_bug.cgi?id=175007
3056         <rdar://problem/33547728>
3057
3058         Reviewed by Sam Weinig.
3059
3060         Add setting to toggle support for the Beacon API (it is disabled by default).
3061
3062         * WebView/WebPreferenceKeysPrivate.h:
3063         * WebView/WebPreferences.mm:
3064         (+[WebPreferences initialize]):
3065         (-[WebPreferences beaconAPIEnabled]):
3066         (-[WebPreferences setBeaconAPIEnabled:]):
3067         * WebView/WebPreferencesPrivate.h:
3068         * WebView/WebView.mm:
3069         (-[WebView _preferencesChanged:]):
3070
3071 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3072
3073         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3074         https://bugs.webkit.org/show_bug.cgi?id=174437
3075
3076         Reviewed by Darin Adler.
3077
3078         Remove redundant Web- prefix from classes in WebKit namespace.
3079
3080         * WebView/WebView.mm:
3081         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3082         * WebView/WebViewData.h:
3083         * WebView/WebViewData.mm:
3084
3085 2017-07-26  Brian Burg  <bburg@apple.com>
3086
3087         Remove WEB_TIMING feature flag
3088         https://bugs.webkit.org/show_bug.cgi?id=174795
3089
3090         Reviewed by Alex Christensen.
3091
3092         * Configurations/FeatureDefines.xcconfig:
3093
3094 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3095
3096         Async image decoding for large images should be disabled after the first time a tile is painted
3097         https://bugs.webkit.org/show_bug.cgi?id=174451
3098         <rdar://problem/31246421>
3099
3100         Reviewed by Simon Fraser.
3101
3102         * WebView/WebFrame.mm:
3103         (-[WebFrame _paintBehaviorForDestinationContext:]):
3104         (-[WebFrame _drawRect:contentsOnly:]):
3105         * WebView/WebHTMLView.mm:
3106         (imageFromRect):
3107
3108 2017-07-23  Darin Adler  <darin@apple.com>
3109
3110         More NeverDestroyed and related cleanup
3111         https://bugs.webkit.org/show_bug.cgi?id=174745
3112
3113         Reviewed by Alex Christensen.
3114
3115         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3116         for names that aren't even used in this file.
3117         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3118         -[NSArray arrayWithObject:].
3119         (-[DOMNode absoluteQuads]): Ditto.
3120         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3121         of writing out various types.
3122         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3123         syntax instea of -[NSArray arrayWithObject:].
3124         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3125         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3126         of writing out various types.
3127         (-[DOMHTMLImageElement mimeType]): Ditto.
3128
3129 2017-07-24  Chris Dumez  <cdumez@apple.com>
3130
3131         ExceptionCode enumeration should use modern exception names
3132         https://bugs.webkit.org/show_bug.cgi?id=174794
3133
3134         Reviewed by Geoffrey Garen.
3135
3136         * DOM/ExceptionHandlers.mm:
3137         (raiseNotSupportedErrorException):
3138
3139 2017-07-23  Chris Dumez  <cdumez@apple.com>
3140
3141         Drop ExceptionCodeDescription class
3142         https://bugs.webkit.org/show_bug.cgi?id=174757
3143
3144         Reviewed by Darin Adler.
3145
3146         Stop using ExceptionCodeDescription.
3147
3148         * DOM/ExceptionHandlers.mm:
3149         (raiseDOMErrorException):
3150
3151 2017-07-21  Andreas Kling  <akling@apple.com>
3152
3153         Use more references in event dispatch code
3154         https://bugs.webkit.org/show_bug.cgi?id=174681
3155
3156         Reviewed by Geoffrey Garen.
3157
3158         * DOM/ObjCEventListener.h:
3159         * DOM/ObjCEventListener.mm:
3160         (WebCore::ObjCEventListener::handleEvent):
3161         * WebCoreSupport/WebFrameLoaderClient.mm:
3162         (NetscapePluginWidget::handleEvent):
3163
3164 2017-07-21  Brady Eidson  <beidson@apple.com>
3165
3166         Get rid of WebCore IconDatabase code.
3167         https://bugs.webkit.org/show_bug.cgi?id=174700
3168
3169         Reviewed by Tim Horton.
3170
3171         * Misc/WebCoreStatistics.mm:
3172         (+[WebCoreStatistics iconPageURLMappingCount]):
3173         (+[WebCoreStatistics iconRetainedPageURLCount]):
3174         (+[WebCoreStatistics iconRecordCount]):
3175         (+[WebCoreStatistics iconsWithDataCount]):
3176         * WebCoreSupport/WebFrameLoaderClient.h:
3177         * WebCoreSupport/WebFrameLoaderClient.mm:
3178         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3179         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3180         * WebView/WebView.mm:
3181         (-[WebView mainFrameIconURL]):
3182
3183 2017-07-20  Chris Dumez  <cdumez@apple.com>
3184
3185         Drop legacy XPathException type
3186         https://bugs.webkit.org/show_bug.cgi?id=174679
3187
3188         Reviewed by Sam Weinig.
3189
3190         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3191         no longer expose XPathException.
3192
3193         * DOM/ExceptionHandlers.mm:
3194         (raiseDOMErrorException):
3195
3196 2017-07-20  Chris Dumez  <cdumez@apple.com>
3197
3198         Unreviewed, rolling out r219706.
3199
3200         Broke iOS build
3201
3202         Reverted changeset:
3203
3204         "Drop legacy XPathException type"
3205         https://bugs.webkit.org/show_bug.cgi?id=174679
3206         http://trac.webkit.org/changeset/219706
3207
3208 2017-07-20  Chris Dumez  <cdumez@apple.com>
3209
3210         Drop legacy XPathException type
3211         https://bugs.webkit.org/show_bug.cgi?id=174679
3212
3213         Reviewed by Sam Weinig.
3214
3215         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3216         no longer expose XPathException.
3217
3218         * DOM/ExceptionHandlers.mm:
3219         (raiseDOMErrorException):
3220         * WebKit.exp:
3221
3222 2017-07-20  Chris Dumez  <cdumez@apple.com>
3223
3224         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3225         https://bugs.webkit.org/show_bug.cgi?id=174660
3226
3227         Reviewed by Geoffrey Garen.
3228
3229         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3230         This essentially replaces a branch to figure out if the new size is less or greater than the
3231         current size by an assertion.
3232
3233         * Plugins/WebNetscapePluginView.mm:
3234         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3235
3236 2017-07-20  Brady Eidson  <beidson@apple.com>
3237
3238         Deprecate WebIconDatabase in WebKitLegacy/mac.
3239         https://bugs.webkit.org/show_bug.cgi?id=174607
3240
3241         Reviewed by Alex Christensen.
3242
3243         This patch:
3244         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3245         2 - Guts the class to where it can only return the default icon at the small size
3246         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3247             use something else or to not do anything.
3248         
3249         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3250         and that patch will remove all of the last remnants of WebIconDatabase.
3251         
3252         * History/WebHistoryItem.mm:
3253         (-[WebHistoryItem icon]):
3254
3255         * Misc/WebIconDatabase.h:
3256         * Misc/WebIconDatabase.mm:
3257         (-[WebIconDatabase init]):
3258         (-[WebIconDatabase iconForURL:withSize:cache:]):
3259         (-[WebIconDatabase iconForURL:withSize:]):
3260         (-[WebIconDatabase defaultIconWithSize:]):
3261         (-[WebIconDatabase defaultIconForURL:withSize:]):
3262         (-[WebIconDatabase iconURLForURL:]):
3263         (-[WebIconDatabase retainIconForURL:]):
3264         (-[WebIconDatabase releaseIconForURL:]):
3265         (+[WebIconDatabase delayDatabaseCleanup]):
3266         (+[WebIconDatabase allowDatabaseCleanup]):
3267         (-[WebIconDatabase setDelegate:]):
3268         (-[WebIconDatabase delegate]):
3269         (+[WebIconDatabase initialize]): Deleted.
3270         (-[WebIconDatabase isEnabled]): Deleted.
3271         (-[WebIconDatabase setEnabled:]): Deleted.
3272         (-[WebIconDatabase removeAllIcons]): Deleted.
3273         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3274         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3275         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3276         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3277         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3278         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3279         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3280         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3281         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3282         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3283         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3284         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3285         (-[WebIconDatabase _databaseDirectory]): Deleted.
3286         (webGetNSImage): Deleted.
3287
3288         * Misc/WebIconDatabaseDelegate.h: Removed.
3289         * Misc/WebIconDatabaseInternal.h: Removed.
3290         * Misc/WebIconDatabasePrivate.h: Removed.
3291
3292         * WebCoreSupport/WebFrameLoaderClient.mm:
3293         (webGetNSImage):
3294
3295         * WebCoreSupport/WebIconDatabaseClient.mm:
3296         (WebIconDatabaseClient::didRemoveAllIcons):
3297         (WebIconDatabaseClient::didImportIconURLForPageURL):
3298
3299         * WebView/WebView.mm:
3300         (-[WebView setFrameLoadDelegate:]):
3301         (-[WebView mainFrameIcon]):
3302
3303 2017-07-18  Andy Estes  <aestes@apple.com>
3304
3305         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3306         https://bugs.webkit.org/show_bug.cgi?id=174631
3307
3308         Reviewed by Tim Horton.
3309
3310         * Configurations/Base.xcconfig:
3311
3312 2017-07-18  Andy Estes  <aestes@apple.com>
3313
3314         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3315         https://bugs.webkit.org/show_bug.cgi?id=174631
3316
3317         Reviewed by Sam Weinig.
3318
3319         * Configurations/Base.xcconfig:
3320
3321 2017-07-18  Andy Estes  <aestes@apple.com>
3322
3323         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3324         https://bugs.webkit.org/show_bug.cgi?id=174631
3325
3326         Reviewed by Dan Bernstein.
3327
3328         * Configurations/Base.xcconfig:
3329
3330 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3331
3332         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3333         https://bugs.webkit.org/show_bug.cgi?id=174640
3334         <rdar://problem/33297400>
3335
3336         Reviewed by Tim Horton.
3337
3338         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3339         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3340         web thread here, to match the other WebView drag and drop SPI methods.
3341
3342         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3343         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3344         should make this robust against future UIKit changes that could make this no longer the case.
3345
3346         * WebView/WebView.mm:
3347         (-[WebView _requestStartDataInteraction:globalPosition:]):
3348         (-[WebView _dataInteractionCaretRect]):
3349
3350 2017-07-18  Andy Estes  <aestes@apple.com>
3351
3352         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3353         https://bugs.webkit.org/show_bug.cgi?id=174631
3354
3355         Reviewed by Darin Adler.
3356
3357         * Configurations/Base.xcconfig:
3358
3359 2017-07-17  Sam Weinig  <sam@webkit.org>
3360
3361         [WebIDL] Remove custom bindings that require non-caching JS strings
3362         https://bugs.webkit.org/show_bug.cgi?id=174552
3363
3364         Reviewed by Darin Adler.
3365
3366         * DOM/DOMHTMLCanvasElement.mm:
3367         (-[DOMHTMLCanvasElement toDataURL:]):
3368         Update to account for implementation now returning an UncachedString.
3369
3370 2017-07-17  Darin Adler  <darin@apple.com>
3371
3372         Improve use of NeverDestroyed
3373         https://bugs.webkit.org/show_bug.cgi?id=174348
3374
3375         Reviewed by Sam Weinig.
3376
3377         * Misc/WebStringTruncator.mm:
3378         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3379         NeverDestroyed<RetainPtr> with just an NSFont * global.
3380
3381         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3382         NeverDestroyed.h.
3383         * Storage/WebDatabaseManager.mm: Ditto.
3384         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3385         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3386
3387         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3388         (aeDescFromJSValue): Removed double hashing by using the return value from
3389         add rather than calling contains before calling add.
3390
3391 2017-07-14  Jer Noble  <jer.noble@apple.com>
3392
3393         Allow clients to override their own hardware media requirements where no fallback media exists.
3394         https://bugs.webkit.org/show_bug.cgi?id=174426
3395         <rdar://problem/32537704>
3396
3397         Reviewed by Eric Carlson.
3398
3399         Add a new WebPreferences property to control WebCore's new
3400         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3401
3402         * WebView/WebPreferenceKeysPrivate.h:
3403         * WebView/WebPreferences.mm:
3404         (+[WebPreferences initialize]):
3405         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3406         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3407         * WebView/WebPreferencesPrivate.h:
3408         * WebView/WebView.mm:
3409         (-[WebView _preferencesChanged:]):
3410
3411 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3412
3413         Async image decoding for large images should be disabled by default
3414         https://bugs.webkit.org/show_bug.cgi?id=174432
3415
3416         Reviewed by Simon Fraser.
3417
3418         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3419         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3420         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3421            a child view instead of propagating PaintBehaviorSnapshotting.
3422         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3423            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3424
3425         * WebView/WebFrame.mm:
3426         (-[WebFrame _paintBehaviorForDestinationContext:]):
3427         (-[WebFrame _drawRect:contentsOnly:]):
3428         * WebView/WebHTMLView.mm:
3429         (imageFromRect):
3430
3431 2017-07-12  Daniel Bates  <dabates@apple.com>
3432
3433         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3434         https://bugs.webkit.org/show_bug.cgi?id=174427
3435
3436         Rubber-stamped by Brady Eidson.
3437
3438         * WebView/WebPDFView.mm:
3439         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3440
3441 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3442
3443         Unreviewed, rolling out r219401.
3444
3445         This revision rolled out the previous patch, but after talking
3446         with reviewer, a rebaseline is what was needed.Rolling back in
3447         before rebaseline.
3448
3449         Reverted changeset:
3450
3451         "Unreviewed, rolling out r219379."
3452         https://bugs.webkit.org/show_bug.cgi?id=174400
3453         http://trac.webkit.org/changeset/219401
3454
3455 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3456
3457         Unreviewed, rolling out r219379.
3458
3459         This revision caused a consistent failure in the test
3460         fast/dom/Window/property-access-on-cached-window-after-frame-
3461         removed.html.
3462
3463         Reverted changeset:
3464
3465         "Remove NAVIGATOR_HWCONCURRENCY"
3466         https://bugs.webkit.org/show_bug.cgi?id=174400
3467         http://trac.webkit.org/changeset/219379
3468
3469 2017-07-11  Dean Jackson  <dino@apple.com>
3470
3471         Remove NAVIGATOR_HWCONCURRENCY
3472         https://bugs.webkit.org/show_bug.cgi?id=174400
3473
3474         * Configurations/FeatureDefines.xcconfig:
3475
3476 2017-07-11  Dean Jackson  <dino@apple.com>
3477
3478         Rolling out r219372.
3479
3480         * Configurations/FeatureDefines.xcconfig:
3481
3482 2017-07-11  Dean Jackson  <dino@apple.com>
3483
3484         Remove NAVIGATOR_HWCONCURRENCY
3485         https://bugs.webkit.org/show_bug.cgi?id=174400
3486
3487         * Configurations/FeatureDefines.xcconfig:
3488
3489 2017-07-03  Brian Burg  <bburg@apple.com>
3490