[iOS] Rename some WebKit-internal functions and variables that reference "data intera...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
4         https://bugs.webkit.org/show_bug.cgi?id=193829
5
6         Reviewed by Tim Horton.
7
8         * WebCoreSupport/WebDragClient.mm:
9         (WebDragClient::didConcludeEditDrag):
10         * WebView/WebView.mm:
11         (-[WebView _requestStartDataInteraction:globalPosition:]):
12         (-[WebView _didConcludeEditDrag]):
13         (-[WebView _didConcludeEditDataInteraction]): Deleted.
14         * WebView/WebViewInternal.h:
15
16 2019-01-24  John Wilander  <wilander@apple.com>
17
18         Add Ad Click Attribution as an internal/experimental feature
19         https://bugs.webkit.org/show_bug.cgi?id=193685
20         <rdar://problem/47450399>
21
22         Reviewed by Brent Fulgham.
23
24         * WebView/WebPreferenceKeysPrivate.h:
25         * WebView/WebPreferences.mm:
26         (+[WebPreferences initialize]):
27         (-[WebPreferences adClickAttributionEnabled]):
28         (-[WebPreferences setAdClickAttributionEnabled:]):
29             Added support for experimental ad click attribution.
30         * WebView/WebPreferencesPrivate.h:
31         * WebView/WebView.mm:
32         (-[WebView _preferencesChanged:]):
33
34 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
35
36         Move FileSystem to WTF
37         https://bugs.webkit.org/show_bug.cgi?id=193602
38
39         Reviewed by Yusuke Suzuki.
40
41         * Misc/WebNSFileManagerExtras.mm:
42         * Storage/WebDatabaseProvider.mm:
43         * WebView/WebView.mm:
44
45 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
46
47         Fix the Apple Internal build. See <rdar://problem/47491383>.
48
49         Rubber-stamped by Tim Horton.
50
51         * WebCoreSupport/WebFrameLoaderClient.mm:
52
53 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
54
55         Clean up USE(WEB_THREAD)
56         https://bugs.webkit.org/show_bug.cgi?id=193698
57
58         Rubber-stamped by Tim Horton.
59
60         * Misc/WebCache.mm:
61         (+[WebCache emptyInMemoryResources]):
62         * WebCoreSupport/WebFrameLoaderClient.mm:
63         (-[WebFramePolicyListener use]):
64         * WebCoreSupport/WebGeolocationClient.mm:
65         (-[WebGeolocationPolicyListener allow]):
66         (-[WebGeolocationPolicyListener deny]):
67         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
68         * WebView/WebFrame.mm:
69         (-[WebFrame deviceOrientationChanged]):
70         * WebView/WebHTMLView.mm:
71         (hardwareKeyboardAvailabilityChangedCallback):
72         * WebView/WebView.mm:
73         (+[WebView _releaseMemoryNow]):
74         (+[WebView willEnterBackgroundWithCompletionHandler:]):
75         (-[WebView updateLayoutIgnorePendingStyleSheets]):
76         (-[WebView _dispatchUnloadEvent]):
77         (-[WebView _close]):
78         (-[WebView _preferencesChangedNotification:]):
79         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
80         (-[WebView goBack]):
81         (-[WebView goForward]):
82         (+[WebView _cacheModelChangedNotification:]):
83         (-[WebView stopLoading:]):
84         (-[WebView stopLoadingAndClear]):
85         (-[WebView reload:]):
86         (WebInstallMemoryPressureHandler):
87
88 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
89
90         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
91         https://bugs.webkit.org/show_bug.cgi?id=193706
92         <rdar://problem/44807048>
93
94         Reviewed by Ryosuke Niwa.
95
96         Use UndoStep::label().
97
98         * WebCoreSupport/WebEditorClient.h:
99         * WebCoreSupport/WebEditorClient.mm:
100         (-[WebUndoStep initWithUndoStep:]):
101         (+[WebUndoStep stepWithUndoStep:]):
102         (WebEditorClient::registerUndoOrRedoStep):
103         (WebEditorClient::registerUndoStep):
104         (WebEditorClient::registerRedoStep):
105
106 2019-01-22  Alex Christensen  <achristensen@webkit.org>
107
108         Move NetworkStorageSession ownership to NetworkProcess
109         https://bugs.webkit.org/show_bug.cgi?id=193580
110
111         Reviewed by Geoff Garen.
112
113         * Misc/WebCache.mm:
114         (+[WebCache clearCachedCredentials]):
115         * Misc/WebDownload.mm:
116         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
117         * Plugins/WebBaseNetscapePluginView.mm:
118         (WebKit::getAuthenticationInfo):
119         * WebCoreSupport/WebFrameNetworkingContext.mm:
120         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
121         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
122         (WebFrameNetworkingContext::storageSession const):
123         * WebView/WebPreferences.mm:
124         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
125         (+[WebPreferences _clearNetworkLoaderSession]):
126         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
127
128 2019-01-22  Daniel Bates  <dabates@apple.com>
129
130         [iOS] Interpret text key commands on keydown and app key commands on keypress
131         https://bugs.webkit.org/show_bug.cgi?id=192897
132         <rdar://problem/46857378>
133
134         Reviewed by Brent Fulgham.
135
136         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
137         is false) and keypress (isCharEvent is true), respectively.
138
139         * WebView/WebHTMLView.mm:
140         (-[WebHTMLView _handleEditingKeyEvent:]):
141
142 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
143
144         [css-logical] Implement flow-relative margin, padding and border shorthands
145         https://bugs.webkit.org/show_bug.cgi?id=188697
146
147         Reviewed by Simon Fraser and Antti Koivisto.
148
149         Add CSSLogicalEnabled runtime flag.
150
151         * WebView/WebPreferenceKeysPrivate.h:
152         * WebView/WebPreferences.mm:
153         (+[WebPreferences initialize]):
154         (-[WebPreferences cssLogicalEnabled]):
155         (-[WebPreferences setCSSLogicalEnabled:]):
156         * WebView/WebPreferencesPrivate.h:
157         * WebView/WebView.mm:
158         (-[WebView _preferencesChanged:]):
159
160 2019-01-15  Darin Adler  <darin@apple.com>
161
162         Use references rather than pointers for register/unregister functions, and more
163         https://bugs.webkit.org/show_bug.cgi?id=175028
164
165         Reviewed by Daniel Bates.
166
167         * WebCoreSupport/WebKitFullScreenListener.mm:
168         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
169         functions in Document; pass a reference.
170         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
171         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
172         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
173         * WebView/WebFullScreenController.mm:
174         (-[WebFullScreenController enterFullScreen:]): Ditto.
175         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
176         (-[WebFullScreenController exitFullScreen]): Ditto.
177         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
178         * WebView/WebFullScreenController.mm:
179         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
180
181 2019-01-12  Dan Bernstein  <mitz@apple.com>
182
183         [Cocoa] Avoid importing directly from subumbrella frameworks
184         https://bugs.webkit.org/show_bug.cgi?id=186016
185         <rdar://problem/40591038>
186
187         Reviewed by Sam Weinig.
188
189         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
190         * Carbon/CarbonWindowAdapter.mm: Ditto.
191         * Carbon/CarbonWindowFrame.m: Ditto.
192         * Carbon/HIViewAdapter.h: Ditto.
193         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
194           OTHER_CFLAGS_COCOA_TOUCH_NO.
195         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
196         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
197         * WebView/WebPDFView.h: Ditto.
198
199 2019-01-20  Antoine Quint  <graouts@apple.com>
200
201         Add a POINTER_EVENTS feature flag
202         https://bugs.webkit.org/show_bug.cgi?id=193577
203         <rdar://problem/47408511>
204
205         Unreviewed. Also enable Pointer Events for iosmac.
206
207         * Configurations/FeatureDefines.xcconfig:
208
209 2019-01-19  Antoine Quint  <graouts@apple.com>
210
211         Add a POINTER_EVENTS feature flag
212         https://bugs.webkit.org/show_bug.cgi?id=193577
213
214         Reviewed by Dean Jackson.
215
216         * Configurations/FeatureDefines.xcconfig:
217
218 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
219
220         Revert r238815, it broke WK1 video fullscreen on Mac
221         https://bugs.webkit.org/show_bug.cgi?id=193586
222         <rdar://problem/47358941>
223
224         Reviewed by Jer Noble.
225
226         * WebView/WebVideoFullscreenController.h: Added.
227         * WebView/WebVideoFullscreenController.mm: Added.
228         (SOFT_LINK_CLASS):
229         (-[WebVideoFullscreenController init]):
230         (-[WebVideoFullscreenController dealloc]):
231         (-[WebVideoFullscreenController fullscreenWindow]):
232         (-[WebVideoFullscreenController windowDidLoad]):
233         (-[WebVideoFullscreenController videoElement]):
234         (-[WebVideoFullscreenController setVideoElement:]):
235         (-[WebVideoFullscreenController clearFadeAnimation]):
236         (-[WebVideoFullscreenController windowDidExitFullscreen]):
237         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
238         (-[WebVideoFullscreenController videoElementRect]):
239         (-[WebVideoFullscreenController applicationDidResignActive:]):
240         (frameExpandedToRatioOfFrame):
241         (createBackgroundFullscreenWindow):
242         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
243         (-[WebVideoFullscreenController enterFullscreen:]):
244         (-[WebVideoFullscreenController exitFullscreen]):
245         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
246         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
247         (-[WebVideoFullscreenController _requestExit]):
248         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
249         (-[WebVideoFullscreenController requestExitFullscreen]):
250         (-[WebVideoFullscreenController fadeHUDIn]):
251         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
252         (-[WebVideoFullscreenController rateChanged:]):
253         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
254         (-[WebVideoFullscreenWindow dealloc]):
255         (-[WebVideoFullscreenWindow resignFirstResponder]):
256         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
257         (-[WebVideoFullscreenWindow mouseDown:]):
258         (-[WebVideoFullscreenWindow cancelOperation:]):
259         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
260         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
261         (-[WebVideoFullscreenWindow animationDidEnd:]):
262         (-[WebVideoFullscreenWindow mouseMoved:]):
263         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
264         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
265         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
266         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
267         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
268         (-[WebVideoFullscreenHUDWindow center]):
269         (-[WebVideoFullscreenHUDWindow keyDown:]):
270         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
271         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
272         (-[WebVideoFullscreenHUDWindowController init]):
273         (-[WebVideoFullscreenHUDWindowController dealloc]):
274         (-[WebVideoFullscreenHUDWindowController setArea:]):
275         (-[WebVideoFullscreenHUDWindowController keyDown:]):
276         (-[WebVideoFullscreenHUDWindowController delegate]):
277         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
278         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
279         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
280         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
281         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
282         (-[WebVideoFullscreenHUDWindowController closeWindow]):
283         (createMediaUIControl):
284         (createControlWithMediaUIControlType):
285         (createTimeTextField):
286         (createMediaUIBackgroundView):
287         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
288         (-[WebVideoFullscreenHUDWindowController updateVolume]):
289         (-[WebVideoFullscreenHUDWindowController updateTime]):
290         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
291         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
292         (-[WebVideoFullscreenHUDWindowController currentTime]):
293         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
294         (-[WebVideoFullscreenHUDWindowController duration]):
295         (-[WebVideoFullscreenHUDWindowController maxVolume]):
296         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
297         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
298         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
299         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
300         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
301         (-[WebVideoFullscreenHUDWindowController volume]):
302         (-[WebVideoFullscreenHUDWindowController setVolume:]):
303         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
304         (-[WebVideoFullscreenHUDWindowController updateRate]):
305         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
306         (-[WebVideoFullscreenHUDWindowController playing]):
307         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
308         (timeToString):
309         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
310         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
311         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
312         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
313         (-[WebVideoFullscreenHUDWindowController rewind:]):
314         (-[WebVideoFullscreenHUDWindowController fastForward:]):
315         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
316         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
317         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
318         * WebView/WebView.mm:
319         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
320         (-[WebView _exitVideoFullscreen]):
321
322 2019-01-18  Tim Horton  <timothy_horton@apple.com>
323
324         Get rid of ADVANCED_SPELL_CHECKING
325         https://bugs.webkit.org/show_bug.cgi?id=193592
326
327         Reviewed by Wenson Hsieh.
328
329         * WebCoreSupport/WebEditorClient.mm:
330         (insertionPointFromCurrentSelection):
331         (WebEditorClient::checkTextOfParagraph):
332         (WebEditorClient::getGuessesForWord):
333         (WebEditorClient::requestCandidatesForSelection):
334         (WebEditorClient::requestCheckingOfString):
335         * WebView/WebHTMLView.mm:
336         (-[WebHTMLView insertText:]):
337
338 2019-01-18  Jer Noble  <jer.noble@apple.com>
339
340         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
341         https://bugs.webkit.org/show_bug.cgi?id=189553
342
343         Reviewed by Tim Horton.
344
345         * Configurations/Base.xcconfig:
346         * Configurations/SDKVariant.xcconfig: Added.
347         * Configurations/WebKitLegacy.xcconfig:
348
349 2019-01-18  David Kilzer  <ddkilzer@apple.com>
350
351         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
352         <https://webkit.org/b/193568>
353         <rdar://problem/47381130>
354
355         Reviewed by Alex Christensen.
356
357         * WebView/WebView.mm:
358         - Remove unused soft-linking macros.
359         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
360         (-[WebUITextIndicatorData initWithImage:scale:]):
361         - Update to use exported PAL functions.
362
363 2019-01-17  Truitt Savell  <tsavell@apple.com>
364
365         Unreviewed, rolling out r240124.
366
367         This commit broke an internal build.
368
369         Reverted changeset:
370
371         "SDK_VARIANT build destinations should be separate from non-
372         SDK_VARIANT builds"
373         https://bugs.webkit.org/show_bug.cgi?id=189553
374         https://trac.webkit.org/changeset/240124
375
376 2019-01-17  Jer Noble  <jer.noble@apple.com>
377
378         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
379         https://bugs.webkit.org/show_bug.cgi?id=189553
380
381         Reviewed by Tim Horton.
382
383         * Configurations/Base.xcconfig:
384         * Configurations/SDKVariant.xcconfig: Added.
385         * Configurations/WebKitLegacy.xcconfig:
386
387 2019-01-17  Alex Christensen  <achristensen@webkit.org>
388
389         Stop using NetworkStorageSession::storageSession in WebCore
390         https://bugs.webkit.org/show_bug.cgi?id=193529
391
392         Reviewed by Tim Horton.
393
394         * Misc/WebCache.mm:
395         (+[WebCache addImageToCache:forURL:forFrame:]):
396         * WebView/WebView.mm:
397         (-[WebView _commonInitializationWithFrameName:groupName:]):
398         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
399
400 2019-01-15  Alex Christensen  <achristensen@webkit.org>
401
402         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
403         https://bugs.webkit.org/show_bug.cgi?id=193368
404
405         Reviewed by Geoff Garen.
406
407         * Misc/WebCache.mm:
408         (+[WebCache clearCachedCredentials]):
409         * Misc/WebDownload.mm:
410         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
411         * Plugins/WebBaseNetscapePluginView.mm:
412         (WebKit::getAuthenticationInfo):
413
414 2019-01-15  Alex Christensen  <achristensen@webkit.org>
415
416         Stop using CookiesStrategy
417         https://bugs.webkit.org/show_bug.cgi?id=161106
418
419         Reviewed by Don Olmstead and Antti Koivisto.
420
421         * Misc/WebCache.mm:
422         (+[WebCache addImageToCache:forURL:forFrame:]):
423         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
424         (WebKit::NetscapePluginInstanceProxy::getCookies):
425         (WebKit::NetscapePluginInstanceProxy::setCookies):
426         * Plugins/WebNetscapePluginView.mm:
427         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
428         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
429         * WebCoreSupport/WebPlatformStrategies.h:
430         * WebCoreSupport/WebPlatformStrategies.mm:
431         (WebPlatformStrategies::createCookiesStrategy): Deleted.
432         (WebPlatformStrategies::cookiesForDOM): Deleted.
433         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
434         (WebPlatformStrategies::cookiesEnabled): Deleted.
435         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
436         (WebPlatformStrategies::getRawCookies): Deleted.
437         (WebPlatformStrategies::deleteCookie): Deleted.
438         * WebView/WebView.mm:
439         (-[WebView _commonInitializationWithFrameName:groupName:]):
440         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
441
442 2019-01-15  Tim Horton  <timothy_horton@apple.com>
443
444         Cannot tab out of WKWebView on macOS
445         https://bugs.webkit.org/show_bug.cgi?id=161448
446         <rdar://problem/28100085>
447
448         Reviewed by Dean Jackson.
449
450         * WebCoreSupport/WebChromeClient.mm:
451         * WebView/WebView.mm:
452         Make use of SPI headers.
453
454 2019-01-14  Commit Queue  <commit-queue@webkit.org>
455
456         Unreviewed, rolling out r239901, r239909, r239910, r239912,
457         r239913, and r239914.
458         https://bugs.webkit.org/show_bug.cgi?id=193407
459
460         These revisions caused an internal failure (Requested by
461         Truitt on #webkit).
462
463         Reverted changesets:
464
465         "[Cocoa] Avoid importing directly from subumbrella frameworks"
466         https://bugs.webkit.org/show_bug.cgi?id=186016
467         https://trac.webkit.org/changeset/239901
468
469         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
470         https://trac.webkit.org/changeset/239909
471
472         "Tried to fix the build."
473         https://trac.webkit.org/changeset/239910
474
475         "Fixed iOS builds after r239910."
476         https://trac.webkit.org/changeset/239912
477
478         "More build fixing."
479         https://trac.webkit.org/changeset/239913
480
481         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
482         https://trac.webkit.org/changeset/239914
483
484 2019-01-14  Mark Lam  <mark.lam@apple.com>
485
486         Re-enable ability to build --cloop builds.
487         https://bugs.webkit.org/show_bug.cgi?id=192955
488         <rdar://problem/46882363>
489
490         Reviewed by Saam barati and Keith Miller.
491
492         * Configurations/FeatureDefines.xcconfig:
493
494 2019-01-13  Dan Bernstein  <mitz@apple.com>
495
496         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
497
498         Patch by Keith Rollin.
499
500         * WebView/PDFViewSPI.h:
501
502 2019-01-12  Timothy Hatcher  <timothy@apple.com>
503
504         Have prefers-color-scheme: light always match on macOS versions before Mojave.
505         https://bugs.webkit.org/show_bug.cgi?id=191655
506         rdar://problem/46074680
507
508         Reviewed by Megan Gardner.
509
510         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
511         * WebView/WebView.mm:
512         (-[WebView _effectiveAppearanceIsDark]):
513
514 2019-01-12  Dan Bernstein  <mitz@apple.com>
515
516         [Cocoa] Avoid importing directly from subumbrella frameworks
517         https://bugs.webkit.org/show_bug.cgi?id=186016
518         <rdar://problem/40591038>
519
520         Reviewed by Sam Weinig.
521
522         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
523         * Carbon/CarbonWindowAdapter.mm: Ditto.
524         * Carbon/CarbonWindowFrame.m: Ditto.
525         * Carbon/HIViewAdapter.h: Ditto.
526         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
527           OTHER_CFLAGS_COCOA_TOUCH_NO.
528         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
529         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
530         * WebView/WebPDFView.h: Ditto.
531
532 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
533
534         Enable visual viewport API by default
535         https://bugs.webkit.org/show_bug.cgi?id=193376
536
537         Reviewed by Simon Fraser.
538
539         * WebView/WebPreferences.mm:
540         (+[WebPreferences initialize]):
541
542 2019-01-11  John Wilander  <wilander@apple.com>
543
544         Compile out Web API Statistics Collection
545         https://bugs.webkit.org/show_bug.cgi?id=193370
546         <rdar://problem/45388584>
547
548         Reviewed by Brent Fulgham.
549
550         * Configurations/FeatureDefines.xcconfig:
551             Defined ENABLE_WEB_API_STATISTICS, off by default.
552
553 2019-01-08  Alex Christensen  <achristensen@webkit.org>
554
555         Stop using NetworkStorageSession in WebProcess
556         https://bugs.webkit.org/show_bug.cgi?id=193236
557
558         Reviewed by Don Olmstead.
559
560         * WebCoreSupport/WebFrameNetworkingContext.h:
561         * WebCoreSupport/WebFrameNetworkingContext.mm:
562         (WebFrameNetworkingContext::storageSession const):
563         * WebCoreSupport/WebPlatformStrategies.h:
564         * WebCoreSupport/WebPlatformStrategies.mm:
565         (WebPlatformStrategies::cookiesForDOM):
566         (WebPlatformStrategies::setCookiesFromDOM):
567         (WebPlatformStrategies::cookiesEnabled):
568         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
569         (WebPlatformStrategies::getRawCookies):
570         (WebPlatformStrategies::deleteCookie):
571         * WebView/WebView.mm:
572         (-[WebView _cachedResponseForURL:]):
573         (-[WebView _clearCredentials]):
574
575 2019-01-08  Alex Christensen  <achristensen@webkit.org>
576
577         Unreviewed, rolling out r239727.
578
579         Broke API tests
580
581         Reverted changeset:
582
583         "Stop using NetworkStorageSession in WebProcess"
584         https://bugs.webkit.org/show_bug.cgi?id=193236
585         https://trac.webkit.org/changeset/239727
586
587 2019-01-08  Alex Christensen  <achristensen@webkit.org>
588
589         Stop using NetworkStorageSession in WebProcess
590         https://bugs.webkit.org/show_bug.cgi?id=193236
591
592         Reviewed by Don Olmstead.
593
594         * WebCoreSupport/WebFrameNetworkingContext.h:
595         * WebCoreSupport/WebFrameNetworkingContext.mm:
596         (WebFrameNetworkingContext::storageSession const):
597         * WebView/WebView.mm:
598         (-[WebView _cachedResponseForURL:]):
599         (-[WebView _clearCredentials]):
600
601 2019-01-07  David Kilzer  <ddkilzer@apple.com>
602
603         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
604         <https://webkit.org/b/193056>
605
606         Reviewed by Alex Christensen.
607
608         * Plugins/Hosted/NetscapePluginHostProxy.h:
609         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
610         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
611         (WebKit::NetscapePluginInstanceProxy::enumerate):
612         (WebKit::NetscapePluginInstanceProxy::marshalValue):
613         (WebKit::NetscapePluginInstanceProxy::marshalValues):
614         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
615         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
616         * Plugins/Hosted/ProxyInstance.mm:
617         (WebKit::ProxyInstance::invoke):
618         * WebCoreSupport/WebGeolocationClient.mm:
619         * WebView/WebDataSource.mm:
620         (-[WebDataSource _receivedData:]):
621         * WebView/WebView.mm:
622         (-[WebView _cachedResponseForURL:]):
623         - Remove '*' from RetainPtr<> type.
624
625 2019-01-04  Alex Christensen  <achristensen@webkit.org>
626
627         Progress towards fixing Mac CMake build
628         https://bugs.webkit.org/show_bug.cgi?id=193105
629
630         Reviewed by Don Olmstead.
631
632         * WebKitPrefix.h:
633
634 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
635
636         Web Inspector: Use save sheet instead of dialog where possible
637         https://bugs.webkit.org/show_bug.cgi?id=193160
638         <rdar://problem/37399759>
639
640         Reviewed by Devin Rousso.
641
642         * WebCoreSupport/WebInspectorClient.mm:
643         (WebInspectorFrontendClient::save):
644
645 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
646
647         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
648         https://bugs.webkit.org/show_bug.cgi?id=193129
649
650         Reviewed by Tim Horton.
651
652         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
653
654         * WebCoreSupport/WebEditorClient.mm:
655         (WebEditorClient::registerUndoOrRedoStep):
656         (undoNameForEditAction): Deleted.
657
658 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
659
660         Add support for using the current text selection as the find string on iOS
661         https://bugs.webkit.org/show_bug.cgi?id=193034
662         <rdar://problem/45138739>
663
664         Reviewed by Tim Horton.
665
666         Add a method stub for WebKitLegacy.
667
668         * WebCoreSupport/WebEditorClient.h:
669
670 2019-01-01  Jeff Miller  <jeffm@apple.com>
671
672         Update user-visible copyright strings to include 2019
673         https://bugs.webkit.org/show_bug.cgi?id=192811
674
675         Reviewed by Mark Lam.
676
677         * Info.plist:
678
679 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
680
681         Use Ref<> as much as possible
682         https://bugs.webkit.org/show_bug.cgi?id=192808
683
684         Reviewed by Alex Christensen.
685
686         * DOM/DOM.mm:
687         (-[DOMNode getPreviewSnapshotImage:andRects:]):
688         * Plugins/Hosted/NetscapePluginHostManager.mm:
689         (WebKit::NetscapePluginHostManager::instantiatePlugin):
690         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
691         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
692         (WebKit::NetscapePluginInstanceProxy::loadRequest):
693         * Plugins/WebNetscapePluginView.mm:
694         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
695         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
696         * WebCoreSupport/WebContextMenuClient.mm:
697         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
698         * WebCoreSupport/WebFrameLoaderClient.mm:
699         (WebFrameLoaderClient::transitionToCommittedForNewPage):
700         * WebView/WebFrame.mm:
701         (-[WebFrame getDictationResultRanges:andMetadatas:]):
702         * WebView/WebHTMLView.mm:
703         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
704         * WebView/WebView.mm:
705         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
706         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
707
708 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
709
710         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
711         https://bugs.webkit.org/show_bug.cgi?id=192821
712
713         Reviewed by Chris Dumez.
714
715         When a window becomes occluded, the window server informs the application.
716         This should be used to suspend any work that is not visible by the user.
717
718         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
719         In some cases, that lead to performance impact (see radar).
720
721         This patch adds an observer for the occlusion notification. I tried to stick
722         with the same names used by WebKit2.
723
724         * WebView/WebView.mm:
725         (-[WebView _isViewVisible]):
726         (-[WebView addWindowObserversForWindow:]):
727         (-[WebView removeWindowObservers]):
728         (-[WebView _windowDidChangeOcclusionState:]):
729
730 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
731
732         [WebAuthN] Add a runtime flag for local authenticator
733         https://bugs.webkit.org/show_bug.cgi?id=192792
734         <rdar://problem/46798738>
735
736         Reviewed by Brent Fulgham.
737
738         * WebView/WebPreferenceKeysPrivate.h:
739         * WebView/WebPreferences.mm:
740         (+[WebPreferences initialize]):
741         (-[WebPreferences webAuthenticationEnabled]): Deleted.
742         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
743         * WebView/WebPreferencesPrivate.h:
744         * WebView/WebView.mm:
745         (-[WebView _preferencesChanged:]):
746
747 2018-12-20  Chris Dumez  <cdumez@apple.com>
748
749         Use Optional::valueOr() instead of Optional::value_or()
750         https://bugs.webkit.org/show_bug.cgi?id=192933
751
752         Reviewed by Geoffrey Garen.
753
754         * WebCoreSupport/WebSecurityOrigin.mm:
755         (-[WebSecurityOrigin port]):
756
757 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
758
759         Unreviewed, rolling out r239417.
760
761         Introduced two API test failures on macOS.
762
763         Reverted changeset:
764
765         "<rdar://problem/46194315> macOS: WebKit1 does not handle
766         occlusion changes"
767         https://bugs.webkit.org/show_bug.cgi?id=192821
768         https://trac.webkit.org/changeset/239417
769
770 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
771
772         WKWebView default UA doesn't freeze the build number
773         https://bugs.webkit.org/show_bug.cgi?id=192809
774         <rdar://problem/44687185>
775
776         Reviewed by Andy Estes.
777
778         Always reports the frozen build number.
779
780         * WebView/WebView.mm:
781         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
782         actual build number through this method call.
783         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
784
785 2018-12-19  Chris Dumez  <cdumez@apple.com>
786
787         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
788         https://bugs.webkit.org/show_bug.cgi?id=192728
789         <rdar://problem/46746779>
790
791         Reviewed by Geoff Garen.
792
793         * DOM/*:
794         * Plugins/*:
795         * WebCoreSupport/*:
796         * WebView/*:
797
798 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
799
800         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
801         https://bugs.webkit.org/show_bug.cgi?id=192821
802
803         Reviewed by Chris Dumez.
804
805         When a window becomes occluded, the window server informs the application.
806         This should be used to suspend any work that is not visible by the user.
807
808         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
809         In some cases, that lead to performance impact (see radar).
810
811         This patch adds an observer for the occlusion notification. I tried to stick
812         with the same names used by WebKit2.
813
814         * WebView/WebView.mm:
815         (-[WebView _isViewVisible]):
816         (-[WebView addWindowObserversForWindow:]):
817         (-[WebView removeWindowObservers]):
818         (-[WebView _windowDidChangeOcclusionState:]):
819
820 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
821
822         Allow clients to set the navigator platform
823         https://bugs.webkit.org/show_bug.cgi?id=192735
824
825         Reviewed by Tim Horton.
826
827         Add stubs to fill out the added functionality in FrameLoaderClient.
828
829         * WebCoreSupport/WebFrameLoaderClient.h:
830         * WebCoreSupport/WebFrameLoaderClient.mm:
831         (WebFrameLoaderClient::navigatorPlatform):
832
833 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
834
835         offsetLeft and offsetParent should adjust across shadow boundaries
836         https://bugs.webkit.org/show_bug.cgi?id=157437
837         <rdar://problem/26154021>
838
839         Reviewed by Simon Fraser.
840
841         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
842
843         * DOM/DOMElement.mm:
844         (-[DOMElement offsetLeft]):
845         (-[DOMElement offsetTop]):
846         (-[DOMElement offsetParent]):
847
848 2018-12-17  Zalan Bujtas  <zalan@apple.com>
849
850         Unreviewed build fix.
851
852         * WebView/WebFrame.mm:
853         (-[WebFrame getDictationResultRanges:andMetadatas:]):
854
855 2018-12-15  Darin Adler  <darin@apple.com>
856
857         Use warning-ignoring macros more consistently and simply
858         https://bugs.webkit.org/show_bug.cgi?id=192743
859
860         Reviewed by Mark Lam.
861
862         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
863         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
864         compilers in Objective-C++ code.
865
866         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
867         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
868         accomodate non-clang compilers here. Also use #pragma once, add a missing
869         "explicit" and fix conditionals.
870
871 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
872
873         Make TextInputController.legacyAttributedString take DOM nodes and offsets
874         https://bugs.webkit.org/show_bug.cgi?id=192653
875
876         Reviewed by Wenson Hsieh.
877
878         * WebView/WebHTMLView.mm:
879         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
880
881 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
882
883         Implement feature flag for CSS Typed OM
884         https://bugs.webkit.org/show_bug.cgi?id=192610
885
886         Reviewed by Ryosuke Niwa.
887
888         * Configurations/FeatureDefines.xcconfig:
889
890 2018-12-11  Tim Horton  <timothy_horton@apple.com>
891
892         WebCore shouldn't have a Objective-C class named NSCursor
893         https://bugs.webkit.org/show_bug.cgi?id=192602
894         <rdar://problem/46615532>
895
896         Reviewed by Wenson Hsieh.
897
898         * WebView/WebFrameView.mm:
899         (-[WebFrameView keyDown:keyDown:]):
900         * WebView/WebHTMLView.mm:
901         (-[WebHTMLView keyDown:]):
902         (-[WebHTMLView performKeyEquivalent:]):
903         Only use NSCursor on macOS.
904
905 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
906
907         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
908         https://bugs.webkit.org/show_bug.cgi?id=192573
909
910         Reviewed by Simon Fraser.
911
912         * Configurations/FeatureDefines.xcconfig:
913
914 2018-12-10  Antti Koivisto  <antti@apple.com>
915
916         Rename "forced style recalc" to "full style rebuild"
917         https://bugs.webkit.org/show_bug.cgi?id=192572
918
919         Reviewed by Zalan Bujtas.
920
921         * WebView/WebHTMLView.mm:
922         (-[WebHTMLView setNeedsToApplyStyles:]):
923
924 2018-12-10  Darin Adler  <darin@apple.com>
925
926         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
927         https://bugs.webkit.org/show_bug.cgi?id=192533
928         rdar://problem/45732710
929
930         Reviewed by Anders Carlsson.
931
932         * Plugins/Hosted/NetscapePluginHostProxy.mm:
933         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
934
935 2018-12-10  Darin Adler  <darin@apple.com>
936
937         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
938         https://bugs.webkit.org/show_bug.cgi?id=192532
939         rdar://problem/45731047
940
941         Reviewed by Chris Dumez.
942
943         * Plugins/Hosted/NetscapePluginHostManager.mm:
944         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
945         * Plugins/Hosted/NetscapePluginHostProxy.mm:
946         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
947
948 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
949
950         Turn WritingDirection into an enum class
951         https://bugs.webkit.org/show_bug.cgi?id=192401
952         Work towards <rdar://problem/42075638>
953
954         Reviewed by Dan Bernstein.
955
956         Change WritingDirection from an enum to an enum class. No change in behavior.
957
958         * WebView/WebHTMLView.mm:
959         (-[WebHTMLView toggleBaseWritingDirection:]):
960         (-[WebHTMLView changeBaseWritingDirection:]):
961         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
962
963 2018-12-03  Alex Christensen  <achristensen@webkit.org>
964
965         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
966         https://bugs.webkit.org/show_bug.cgi?id=192272
967
968         Reviewed by Brady Eidson.
969
970         * WebCoreSupport/WebFrameLoaderClient.h:
971         * WebCoreSupport/WebFrameLoaderClient.mm:
972         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
973
974 2018-12-03  Jer Noble  <jer.noble@apple.com>
975
976         Get rid of old, dead Mac video fullscreen code.
977         https://bugs.webkit.org/show_bug.cgi?id=192315
978
979         Reviewed by Eric Carlson.
980
981         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
982         is no longer supported in the Mac port.
983
984         * WebView/WebVideoFullscreenController.h: Removed.
985         * WebView/WebVideoFullscreenController.mm: Removed.
986         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
987         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
988         * WebView/WebView.mm:
989         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
990         (-[WebView _exitVideoFullscreen]):
991
992 2018-12-03  Daniel Bates  <dabates@apple.com>
993
994         [iOS] Do not handle key events that are key commands
995         https://bugs.webkit.org/show_bug.cgi?id=191608
996         <rdar://problem/46046013>
997
998         Reviewed by Ryosuke Niwa.
999
1000         A key down event may be associated with a key command. If it is then we want to execute the
1001         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1002         event as a key command to find out.
1003
1004         * WebView/WebHTMLView.mm:
1005         (-[WebHTMLView _handleEditingKeyEvent:]):
1006
1007 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1008
1009         Add a runtime feature flag for LayoutFormattingContext.
1010         https://bugs.webkit.org/show_bug.cgi?id=192280
1011
1012         Reviewed by Simon Fraser.
1013
1014         * Configurations/FeatureDefines.xcconfig:
1015
1016 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1017
1018         Move URL from WebCore to WTF
1019         https://bugs.webkit.org/show_bug.cgi?id=190234
1020
1021         Reviewed by Keith Miller.
1022
1023         * DOM/DOMAttr.mm:
1024         * DOM/DOMBlob.mm:
1025         * DOM/DOMCSSCharsetRule.mm:
1026         * DOM/DOMCSSImportRule.mm:
1027         * DOM/DOMCSSMediaRule.mm:
1028         * DOM/DOMCSSPageRule.mm:
1029         * DOM/DOMCSSPrimitiveValue.mm:
1030         * DOM/DOMCSSRule.mm:
1031         * DOM/DOMCSSStyleDeclaration.mm:
1032         * DOM/DOMCSSStyleRule.mm:
1033         * DOM/DOMCSSStyleSheet.mm:
1034         * DOM/DOMCSSValue.mm:
1035         * DOM/DOMCharacterData.mm:
1036         * DOM/DOMCounter.mm:
1037         * DOM/DOMDocument.mm:
1038         * DOM/DOMDocumentFragment.mm:
1039         * DOM/DOMDocumentType.mm:
1040         * DOM/DOMEvent.mm:
1041         * DOM/DOMFile.mm:
1042         * DOM/DOMHTMLAnchorElement.mm:
1043         * DOM/DOMHTMLAppletElement.mm:
1044         * DOM/DOMHTMLAreaElement.mm:
1045         * DOM/DOMHTMLBRElement.mm:
1046         * DOM/DOMHTMLBaseElement.mm:
1047         * DOM/DOMHTMLBaseFontElement.mm:
1048         * DOM/DOMHTMLBodyElement.mm:
1049         * DOM/DOMHTMLButtonElement.mm:
1050         * DOM/DOMHTMLCanvasElement.mm:
1051         * DOM/DOMHTMLCollection.mm:
1052         * DOM/DOMHTMLDivElement.mm:
1053         * DOM/DOMHTMLDocument.mm:
1054         * DOM/DOMHTMLElement.mm:
1055         * DOM/DOMHTMLEmbedElement.mm:
1056         * DOM/DOMHTMLFieldSetElement.mm:
1057         * DOM/DOMHTMLFontElement.mm:
1058         * DOM/DOMHTMLFormElement.mm:
1059         * DOM/DOMHTMLFrameElement.mm:
1060         * DOM/DOMHTMLFrameSetElement.mm:
1061         * DOM/DOMHTMLHRElement.mm:
1062         * DOM/DOMHTMLHeadElement.mm:
1063         * DOM/DOMHTMLHeadingElement.mm:
1064         * DOM/DOMHTMLHtmlElement.mm:
1065         * DOM/DOMHTMLIFrameElement.mm:
1066         * DOM/DOMHTMLImageElement.mm:
1067         * DOM/DOMHTMLInputElement.mm:
1068         * DOM/DOMHTMLLIElement.mm:
1069         * DOM/DOMHTMLLabelElement.mm:
1070         * DOM/DOMHTMLLegendElement.mm:
1071         * DOM/DOMHTMLLinkElement.mm:
1072         * DOM/DOMHTMLMapElement.mm:
1073         * DOM/DOMHTMLMarqueeElement.mm:
1074         * DOM/DOMHTMLMediaElement.mm:
1075         * DOM/DOMHTMLMetaElement.mm:
1076         * DOM/DOMHTMLModElement.mm:
1077         * DOM/DOMHTMLOListElement.mm:
1078         * DOM/DOMHTMLObjectElement.mm:
1079         * DOM/DOMHTMLOptGroupElement.mm:
1080         * DOM/DOMHTMLOptionElement.mm:
1081         * DOM/DOMHTMLOptionsCollection.mm:
1082         * DOM/DOMHTMLParagraphElement.mm:
1083         * DOM/DOMHTMLParamElement.mm:
1084         * DOM/DOMHTMLQuoteElement.mm:
1085         * DOM/DOMHTMLScriptElement.mm:
1086         * DOM/DOMHTMLSelectElement.mm:
1087         * DOM/DOMHTMLStyleElement.mm:
1088         * DOM/DOMHTMLTableCaptionElement.mm:
1089         * DOM/DOMHTMLTableCellElement.mm:
1090         * DOM/DOMHTMLTableColElement.mm:
1091         * DOM/DOMHTMLTableElement.mm:
1092         * DOM/DOMHTMLTableRowElement.mm:
1093         * DOM/DOMHTMLTableSectionElement.mm:
1094         * DOM/DOMHTMLTitleElement.mm:
1095         * DOM/DOMHTMLUListElement.mm:
1096         * DOM/DOMHTMLVideoElement.mm:
1097         * DOM/DOMKeyboardEvent.mm:
1098         * DOM/DOMMediaList.mm:
1099         * DOM/DOMMouseEvent.mm:
1100         * DOM/DOMMutationEvent.mm:
1101         * DOM/DOMNamedNodeMap.mm:
1102         * DOM/DOMProcessingInstruction.mm:
1103         * DOM/DOMRange.mm:
1104         * DOM/DOMStyleSheet.mm:
1105         * DOM/DOMText.mm:
1106         * DOM/DOMTextEvent.mm:
1107         * DOM/DOMTokenList.mm:
1108         * DOM/DOMUIEvent.mm:
1109         * DOM/DOMXPathResult.mm:
1110         * History/WebHistoryItem.mm:
1111         * Misc/WebNSURLExtras.mm:
1112         (-[NSURL _web_userVisibleString]):
1113         (-[NSURL _web_URLByRemovingUserInfo]):
1114         (-[NSURL _web_dataForURLComponentType:]):
1115         (-[NSURL _web_schemeData]):
1116         (-[NSURL _web_hostData]):
1117         * Misc/WebUserContentURLPattern.mm:
1118         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1119         * Plugins/WebNetscapePluginStream.h:
1120         (WebNetscapePluginStream::setRequestURL):
1121         * WebCoreSupport/WebChromeClient.h:
1122         * WebCoreSupport/WebChromeClient.mm:
1123         (WebChromeClient::signedPublicKeyAndChallengeString const):
1124         * WebCoreSupport/WebContextMenuClient.h:
1125         * WebCoreSupport/WebContextMenuClient.mm:
1126         * WebCoreSupport/WebDragClient.h:
1127         * WebCoreSupport/WebFrameLoaderClient.h:
1128         * WebCoreSupport/WebFrameLoaderClient.mm:
1129         (WebFrameLoaderClient::updateGlobalHistory):
1130         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1131         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1132         (WebPaymentCoordinatorClient::showPaymentUI):
1133         * WebCoreSupport/WebPlatformStrategies.h:
1134         * WebCoreSupport/WebPlatformStrategies.mm:
1135         (WebPlatformStrategies::readURLFromPasteboard):
1136         * WebCoreSupport/WebPluginInfoProvider.h:
1137         * WebCoreSupport/WebPluginInfoProvider.mm:
1138         (WebPluginInfoProvider::webVisiblePluginInfo):
1139         * WebCoreSupport/WebSecurityOrigin.mm:
1140         * WebCoreSupport/WebVisitedLinkStore.h:
1141         * WebView/WebDataSource.mm:
1142         * WebView/WebFrame.mm:
1143         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1144         * WebView/WebImmediateActionController.mm:
1145         (-[WebImmediateActionController _defaultAnimationController]):
1146         * WebView/WebPDFView.mm:
1147         * WebView/WebScriptDebugger.mm:
1148         * WebView/WebViewInternal.h:
1149
1150 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1151
1152         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1153         https://bugs.webkit.org/show_bug.cgi?id=192197
1154
1155         Reviewed by Jiewen Tan.
1156
1157         * Configurations/FeatureDefines.xcconfig:
1158         * WebCoreSupport/WebChromeClient.h:
1159         * WebCoreSupport/WebChromeClient.mm:
1160
1161 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1162
1163         Remove dead code from an earlier attempt at implementing safe browsing
1164         https://bugs.webkit.org/show_bug.cgi?id=192067
1165
1166         Reviewed by Chris Dumez.
1167
1168         * WebCoreSupport/WebFrameLoaderClient.h:
1169         * WebCoreSupport/WebFrameLoaderClient.mm:
1170         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1171
1172 2018-11-27  Mark Lam  <mark.lam@apple.com>
1173
1174         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1175         https://bugs.webkit.org/show_bug.cgi?id=192055
1176         <rdar://problem/46288783>
1177
1178         Reviewed by Saam Barati.
1179
1180         * Configurations/FeatureDefines.xcconfig:
1181
1182 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1183
1184         Make it possible to insert editable images with a gesture
1185         https://bugs.webkit.org/show_bug.cgi?id=191937
1186
1187         Reviewed by Wenson Hsieh.
1188
1189         * WebCoreSupport/WebEditorClient.mm:
1190         (undoNameForEditAction):
1191         Add a undo name.
1192
1193 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1194
1195         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1196         https://bugs.webkit.org/show_bug.cgi?id=191945
1197
1198         Reviewed by Anders Carlsson.
1199
1200         * WebCoreSupport/WebEditorClient.mm:
1201         (undoNameForEditAction):
1202
1203 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         Enable drag and drop support for iOSMac
1206         https://bugs.webkit.org/show_bug.cgi?id=191818
1207         <rdar://problem/43907454>
1208
1209         Reviewed by Dean Jackson.
1210
1211         * Configurations/FeatureDefines.xcconfig:
1212
1213 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1214
1215         Address post-review feedback after r238438
1216         https://bugs.webkit.org/show_bug.cgi?id=191913
1217
1218         Reviewed by Ryosuke Niwa.
1219
1220         * WebView/WebFrame.mm:
1221         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1222         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1223         * WebView/WebView.mm:
1224         (-[WebView setSelectedDOMRange:affinity:]):
1225
1226 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1227
1228         Web Inspector: "Reload Web Inspector" button no longer partially works
1229         https://bugs.webkit.org/show_bug.cgi?id=191773
1230         <rdar://problem/46139932>
1231
1232         Reviewed by Devin Rousso.
1233
1234         * WebCoreSupport/WebInspectorClient.h:
1235         * WebCoreSupport/WebInspectorClient.mm:
1236         (WebInspectorFrontendClient::reopen):
1237
1238 2018-11-17  Devin Rousso  <drousso@apple.com>
1239
1240         Web Inspector: Network: add button to show system certificate dialog
1241         https://bugs.webkit.org/show_bug.cgi?id=191458
1242         <rdar://problem/45977019>
1243
1244         Reviewed by Joseph Pecoraro.
1245
1246         * WebCoreSupport/WebInspectorClient.h:
1247         * WebCoreSupport/WebInspectorClient.mm:
1248         (WebInspectorFrontendClient::showCertificate): Added.
1249
1250         * Configurations/WebKitLegacy.xcconfig:
1251
1252 2018-11-15  Truitt Savell  <tsavell@apple.com>
1253
1254         Unreviewed, rolling out r238244.
1255
1256         Caused High Sierra test runs to fail early with 50 crashes and
1257         casued 25 API failures.
1258
1259         Reverted changeset:
1260
1261         "[css-logical] Implement flow-relative margin, padding and
1262         border shorthands"
1263         https://bugs.webkit.org/show_bug.cgi?id=188697
1264         https://trac.webkit.org/changeset/238244
1265
1266 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1267
1268         [css-logical] Implement flow-relative margin, padding and border shorthands
1269         https://bugs.webkit.org/show_bug.cgi?id=188697
1270
1271         Reviewed by Simon Fraser and Antti Koivisto.
1272
1273         Add CSSLogicalEnabled runtime flag.
1274
1275         * WebView/WebPreferenceKeysPrivate.h:
1276         * WebView/WebPreferences.mm:
1277         (+[WebPreferences initialize]):
1278         (-[WebPreferences cssLogicalEnabled]):
1279         (-[WebPreferences setCSSLogicalEnabled:]):
1280         * WebView/WebPreferencesPrivate.h:
1281         * WebView/WebView.mm:
1282         (-[WebView _preferencesChanged:]):
1283
1284 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1285
1286         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1287         https://bugs.webkit.org/show_bug.cgi?id=191612
1288
1289         Reviewed by Matt Baker.
1290
1291         * WebCoreSupport/WebInspectorClient.mm:
1292         (-[WebInspectorWindowController destroyInspectorView]):
1293
1294 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1295
1296         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1297         https://bugs.webkit.org/show_bug.cgi?id=191494
1298         <rdar://problem/45469854>
1299
1300         Reviewed by Devin Rousso.
1301
1302         * WebCoreSupport/WebInspectorClient.h:
1303         WebKitLegacy will still have remote inspection of the Page directly.
1304
1305 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1306
1307         Make compositing updates incremental
1308         https://bugs.webkit.org/show_bug.cgi?id=90342
1309
1310         Reviewed by Antti Koivisto.
1311
1312         Fix spelling error.
1313
1314         * WebView/WebView.mm:
1315         (-[WebView _setMediaLayer:forPluginView:]):
1316
1317 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1318
1319         Implement a new edit command to change the enclosing list type
1320         https://bugs.webkit.org/show_bug.cgi?id=191487
1321         <rdar://problem/45955922>
1322
1323         Reviewed by Ryosuke Niwa.
1324
1325         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1326
1327         * WebCoreSupport/WebEditorClient.mm:
1328         (undoNameForEditAction):
1329
1330 2018-11-11  Daniel Bates  <dabates@apple.com>
1331
1332         [iOS] Draw caps lock indicator in password fields
1333         https://bugs.webkit.org/show_bug.cgi?id=190565
1334         <rdar://problem/45262343>
1335
1336         Reviewed by Dean Jackson.
1337
1338         Update the caps lock state when a hardware keyboard is attached or detached.
1339
1340         * WebView/WebHTMLView.mm:
1341         (hardwareKeyboardAvailabilityChangedCallback): Added.
1342         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1343         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1344
1345 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1346
1347         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1348         https://bugs.webkit.org/show_bug.cgi?id=191492
1349
1350         Reviewed by Alex Christensen.
1351
1352         * Carbon/HIWebView.mm:
1353         * Misc/WebNSFileManagerExtras.mm:
1354         * Misc/WebNSURLExtras.mm:
1355         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1356         * Plugins/WebBasePluginPackage.mm:
1357         * Plugins/WebPluginContainerCheck.mm:
1358         * WebCoreSupport/WebCachedFramePlatformData.h:
1359         * WebCoreSupport/WebDeviceOrientationClient.mm:
1360         * WebView/WebDelegateImplementationCaching.mm:
1361         * WebView/WebHTMLView.mm:
1362         * WebView/WebPDFRepresentation.mm:
1363         * WebView/WebPolicyDelegate.mm:
1364         * WebView/WebView.mm:
1365
1366 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1367
1368         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1369         https://bugs.webkit.org/show_bug.cgi?id=191492
1370
1371         Reviewed by Alex Christensen.
1372
1373         * Carbon/HIWebView.mm:
1374         (UpdateCommandStatus):
1375         * Misc/WebNSFileManagerExtras.mm:
1376         * Misc/WebNSURLExtras.mm:
1377         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1378         * Plugins/WebBasePluginPackage.mm:
1379         * Plugins/WebPluginContainerCheck.mm:
1380         (-[WebPluginContainerCheck _continueWithPolicy:]):
1381         * WebCoreSupport/WebCachedFramePlatformData.h:
1382         (WebCachedFramePlatformData::clear):
1383         * WebCoreSupport/WebDeviceOrientationClient.mm:
1384         (WebDeviceOrientationClient::getProvider const):
1385         * WebView/WebDelegateImplementationCaching.mm:
1386         (CallDelegate):
1387         (CallDelegateReturningBoolean):
1388         (CallResourceLoadDelegateReturningBoolean):
1389         (CallFormDelegate):
1390         (CallFormDelegateReturningBoolean):
1391         * WebView/WebHTMLView.mm:
1392         * WebView/WebPDFRepresentation.mm:
1393         * WebView/WebPolicyDelegate.mm:
1394         (-[WebPolicyDecisionListener _usePolicy:]):
1395         * WebView/WebView.mm:
1396
1397 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1398
1399         Unreviewed, rolling out r238047.
1400
1401         Introduced layout test failures on iOS simulator.
1402
1403         Reverted changeset:
1404
1405         "[iOS] Draw caps lock indicator in password fields"
1406         https://bugs.webkit.org/show_bug.cgi?id=190565
1407         https://trac.webkit.org/changeset/238047
1408
1409 2018-11-09  Antti Koivisto  <antti@apple.com>
1410
1411         Use OptionSet for layout milestones
1412         https://bugs.webkit.org/show_bug.cgi?id=191470
1413
1414         Reviewed by Dean Jackson.
1415
1416         * WebCoreSupport/WebFrameLoaderClient.h:
1417         * WebCoreSupport/WebFrameLoaderClient.mm:
1418         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1419         * WebView/WebView.mm:
1420         (coreLayoutMilestones):
1421         (kitLayoutMilestones):
1422         (-[WebView _cacheFrameLoadDelegateImplementations]):
1423         * WebView/WebViewInternal.h:
1424
1425 2018-11-09  Daniel Bates  <dabates@apple.com>
1426
1427         [iOS] Draw caps lock indicator in password fields
1428         https://bugs.webkit.org/show_bug.cgi?id=190565
1429         <rdar://problem/45262343>
1430
1431         Reviewed by Dean Jackson.
1432
1433         Update the caps lock state when a hardware keyboard is attached or detached.
1434
1435         * WebView/WebHTMLView.mm:
1436         (hardwareKeyboardAvailabilityChangedCallback): Added.
1437         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1438         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1439
1440 2018-11-09  Daniel Bates  <dabates@apple.com>
1441
1442         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1443         action when forward delete is pressed outside a text field
1444         https://bugs.webkit.org/show_bug.cgi?id=190566
1445         <rdar://problem/45262367>
1446
1447         Reviewed by Wenson Hsieh.
1448
1449         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1450         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1451         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1452
1453         * WebView/WebHTMLView.mm:
1454         (-[WebHTMLView _handleEditingKeyEvent:]):
1455
1456 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1457
1458         Adopt Reveal Framework to replace Lookup
1459         https://bugs.webkit.org/show_bug.cgi?id=191097
1460         <rdar://problem/45924508>
1461
1462         Reviewed by Tim Horton.
1463
1464         Pass in what it needed to clear the textIndicators. This is better than
1465         the current notification structure.
1466
1467         * WebView/WebView.mm:
1468         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1469         (-[WebView _prepareForDictionaryLookup]):
1470
1471 2018-11-06  Justin Fan  <justin_fan@apple.com>
1472
1473         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1474         https://bugs.webkit.org/show_bug.cgi?id=191291
1475
1476         Reviewed by Myles Maxfield.
1477
1478         Properly disable WEBGPU on all non-Metal platforms for now.
1479
1480         * Configurations/FeatureDefines.xcconfig:
1481
1482 2018-11-02  Daniel Bates  <dabates@apple.com>
1483
1484         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1485         https://bugs.webkit.org/show_bug.cgi?id=190487
1486
1487         Reviewed by Tim Horton.
1488
1489         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1490         allow the default handling.
1491
1492         * WebView/WebHTMLView.mm:
1493         (-[WebHTMLView _handleEditingKeyEvent:]):
1494
1495 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1496
1497         Add a storage limit for IndexedDB
1498         https://bugs.webkit.org/show_bug.cgi?id=190598
1499         <rdar://problem/44654715>
1500
1501         Reviewed by Chris Dumez.
1502
1503         * Storage/WebDatabaseManager.mm:
1504         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1505         * Storage/WebDatabaseManagerPrivate.h:
1506
1507 2018-10-31  Antti Koivisto  <antti@apple.com>
1508
1509         Remove LayerFlushScheduler
1510         https://bugs.webkit.org/show_bug.cgi?id=191103
1511
1512         Reviewed by Anders Carlsson.
1513
1514         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1515         all the virtual cruft.
1516
1517         * WebView/WebViewData.h:
1518         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1519         (): Deleted.
1520         * WebView/WebViewData.mm:
1521         (currentRunLoop):
1522         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1523         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1524         (WebViewLayerFlushScheduler::schedule):
1525         (WebViewLayerFlushScheduler::invalidate):
1526         (WebViewLayerFlushScheduler::layerFlushCallback):
1527
1528 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1529
1530         Enable InstallAPI for iOS unconditionally
1531         https://bugs.webkit.org/show_bug.cgi?id=191043
1532         rdar://problem/32728423
1533
1534         Reviewed by Dan Bernstein.
1535
1536         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1537         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1538         shouldn't be processed by InstallAPI.
1539         * MigrateHeaders.make: Removed an obsolete workaround.
1540         * Misc/NSURLDownloadSPI.h: Added.
1541         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1542
1543 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1544
1545         Clean up some obsolete MAX_ALLOWED macros
1546         https://bugs.webkit.org/show_bug.cgi?id=190916
1547
1548         Reviewed by Tim Horton.
1549
1550         * WebView/WebHTMLView.mm:
1551         (-[WebHTMLView pressureChangeWithEvent:]):
1552         * WebView/WebPDFView.h:
1553
1554 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1555
1556         Unreviewed, rolling out r237600 and r237604.
1557         https://bugs.webkit.org/show_bug.cgi?id=191086
1558
1559         Breaks internal iOS builds (Requested by ryanhadd_ on
1560         #webkit).
1561
1562         Reverted changesets:
1563
1564         "Enable InstallAPI for iOS unconditionally"
1565         https://bugs.webkit.org/show_bug.cgi?id=191043
1566         https://trac.webkit.org/changeset/237600
1567
1568         "Build fix attempt after enabling InstallAPI for iOS."
1569         https://bugs.webkit.org/show_bug.cgi?id=191043
1570         https://trac.webkit.org/changeset/237604
1571
1572 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1573
1574         Enable InstallAPI for iOS unconditionally
1575         https://bugs.webkit.org/show_bug.cgi?id=191043
1576         rdar://problem/32728423
1577
1578         Reviewed by Dan Bernstein.
1579
1580         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1581         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1582         shouldn't be processed by InstallAPI.
1583         * MigrateHeaders.make: Removed an obsolete workaround.
1584         * Misc/NSURLDownloadSPI.h: Added.
1585         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1586
1587 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1588
1589         Modernize WebKit nibs and lprojs for localization's sake
1590         https://bugs.webkit.org/show_bug.cgi?id=190911
1591         <rdar://problem/45349466>
1592
1593         Reviewed by Dan Bernstein.
1594
1595         * Misc/WebNSControlExtras.m:
1596         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1597         NSWindow and its contents are both in the same scale space these days; avoid
1598         double-applying the scale factor, or you can't see the prompt.
1599
1600         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1601         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1602         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1603         NIB->XIB
1604
1605 2018-10-25  Antoine Quint  <graouts@apple.com>
1606
1607         [Web Animations] Turn Web Animations CSS Integration off by default
1608         https://bugs.webkit.org/show_bug.cgi?id=190901
1609
1610         Reviewed by Dean Jackson.
1611
1612         * WebView/WebPreferences.mm:
1613         (+[WebPreferences initialize]):
1614
1615 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1616
1617         Clean up some obsolete macOS version guards
1618         https://bugs.webkit.org/show_bug.cgi?id=190887
1619
1620         Reviewed by Dan Bernstein.
1621
1622         * Misc/WebNSPasteboardExtras.mm:
1623         (+[NSPasteboard _web_dragTypesForURL]):
1624         * WebCoreSupport/PopupMenuMac.mm:
1625         (PopupMenuMac::show):
1626         * WebCoreSupport/WebEditorClient.h:
1627         * WebCoreSupport/WebEditorClient.mm:
1628         (WebEditorClient::respondToChangedSelection):
1629         * WebView/WebPDFView.mm:
1630         (-[WebPDFView _clipViewForPDFDocumentView]):
1631
1632 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1633
1634         Turn on Conic Gradients
1635         https://bugs.webkit.org/show_bug.cgi?id=190810
1636
1637         Reviewed by Tim Horton.
1638
1639         * Configurations/FeatureDefines.xcconfig:
1640
1641 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1642
1643         Cleanup: MIMETypeRegistry functions
1644         https://bugs.webkit.org/show_bug.cgi?id=190838
1645
1646         Reviewed by Simon Fraser.
1647
1648         * Misc/WebNSPasteboardExtras.mm:
1649         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1650         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1651         because they were identical.
1652
1653         * WebView/WebHTMLRepresentation.mm:
1654         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1655         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1656         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1657         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1658         * WebView/WebView.mm:
1659         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1660         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1661         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1662
1663 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1664
1665         Fix false positive leaks when using custom -init methods that don't start with -init
1666         <https://webkit.org/b/190818>
1667         <rdar://problem/45476042>
1668
1669         Reviewed by Dan Bernstein.
1670
1671         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1672         it is accessible by both categories.
1673         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1674         NSError (WebKitInternal) category.  Add attribute to make this
1675         behave like an -init method.
1676         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1677         NSError (WebKitInternal) category.  Modernize method.  Replace
1678         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1679
1680 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1681
1682         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1683         https://bugs.webkit.org/show_bug.cgi?id=190729
1684
1685         Reviewed by Tim Horton.
1686
1687         * DOM/DOM.mm:
1688         (-[DOMNode boundingBox]):
1689         * DOM/DOMElement.mm:
1690         * DOM/DOMHTML.mm:
1691         * DOM/DOMInternal.mm:
1692         * DOM/DOMUIKitExtensions.mm:
1693         * DOM/WebDOMOperations.mm:
1694         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1695         * DefaultDelegates/WebDefaultEditingDelegate.m:
1696         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1697         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1698         * DefaultDelegates/WebDefaultUIDelegate.h:
1699         * DefaultDelegates/WebDefaultUIDelegate.mm:
1700         (-[WebDefaultUIDelegate webViewClose:]):
1701         (-[WebDefaultUIDelegate webViewFocus:]):
1702         (-[WebDefaultUIDelegate webViewUnfocus:]):
1703         (-[WebDefaultUIDelegate webViewIsResizable:]):
1704         (-[WebDefaultUIDelegate webView:setResizable:]):
1705         (-[WebDefaultUIDelegate webView:setFrame:]):
1706         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1707         * History/BackForwardList.h:
1708         * History/BackForwardList.mm:
1709         * History/WebBackForwardList.mm:
1710         (+[WebBackForwardList initialize]):
1711         (bumperCarBackForwardHackNeeded):
1712         * History/WebHistory.mm:
1713         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1714         (-[WebHistory _sendNotification:entries:]):
1715         (-[WebHistory loadFromURL:error:]):
1716         (-[WebHistory saveToURL:error:]):
1717         * History/WebHistoryItem.mm:
1718         (WKNotifyHistoryItemChanged):
1719         (+[WebHistoryItem initialize]):
1720         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1721         * History/WebURLsWithTitles.m:
1722         * Misc/WebCache.mm:
1723         (+[WebCache initialize]):
1724         * Misc/WebDownload.mm:
1725         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1726         * Misc/WebElementDictionary.mm:
1727         (+[WebElementDictionary initialize]):
1728         (+[WebElementDictionary initializeLookupTable]):
1729         * Misc/WebIconDatabase.mm:
1730         * Misc/WebKitNSStringExtras.mm:
1731         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1732         * Misc/WebKitVersionChecks.h:
1733         * Misc/WebKitVersionChecks.mm:
1734         (WebKitLinkedOnOrAfter):
1735         (WebKitLinkTimeVersion):
1736         * Misc/WebLocalizableStrings.mm:
1737         * Misc/WebNSControlExtras.h:
1738         * Misc/WebNSControlExtras.m:
1739         * Misc/WebNSEventExtras.m:
1740         * Misc/WebNSFileManagerExtras.mm:
1741         * Misc/WebNSImageExtras.h:
1742         * Misc/WebNSImageExtras.m:
1743         * Misc/WebNSPasteboardExtras.mm:
1744         * Misc/WebNSPrintOperationExtras.h:
1745         * Misc/WebNSPrintOperationExtras.m:
1746         * Misc/WebNSViewExtras.m:
1747         * Misc/WebNSWindowExtras.m:
1748         * Panels/WebAuthenticationPanel.h:
1749         * Panels/WebAuthenticationPanel.m:
1750         * Panels/WebPanelAuthenticationHandler.m:
1751         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1752         (+[WebHostedNetscapePluginView initialize]):
1753         * Plugins/WebBasePluginPackage.h:
1754         * Plugins/WebBasePluginPackage.mm:
1755         * Plugins/WebJavaPlugIn.h:
1756         * Plugins/WebPluginContainerCheck.mm:
1757         * Plugins/WebPluginController.h:
1758         * Plugins/WebPluginController.mm:
1759         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1760         (-[WebPluginController addPlugin:]):
1761         (-[WebPluginController destroyPlugin:]):
1762         (-[WebPluginController destroyAllPlugins]):
1763         * Plugins/WebPluginDatabase.mm:
1764         (+[WebPluginDatabase _defaultPlugInPaths]):
1765         * Plugins/WebPluginPackage.mm:
1766         (-[WebPluginPackage initWithPath:]):
1767         * Storage/WebDatabaseManager.mm:
1768         (-[WebDatabaseManager deleteAllDatabases]):
1769         * Storage/WebDatabaseManagerClient.h:
1770         * Storage/WebDatabaseManagerClient.mm:
1771         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1772         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1773         * Storage/WebStorageManager.mm:
1774         (-[WebStorageManager deleteAllOrigins]):
1775         (WebKitInitializeStorageIfNecessary):
1776         * WebCoreSupport/WebAlternativeTextClient.h:
1777         * WebCoreSupport/WebApplicationCache.mm:
1778         (applicationCacheBundleIdentifier):
1779         * WebCoreSupport/WebChromeClient.h:
1780         * WebCoreSupport/WebChromeClient.mm:
1781         (WebChromeClient::setWindowRect):
1782         (WebChromeClient::windowRect):
1783         (WebChromeClient::takeFocus):
1784         (WebChromeClient::addMessageToConsole):
1785         (WebChromeClient::enableSuddenTermination):
1786         (WebChromeClient::disableSuddenTermination):
1787         (WebChromeClient::createPopupMenu const):
1788         (WebChromeClient::createSearchPopupMenu const):
1789         (WebChromeClient::shouldPaintEntireContents const):
1790         (WebChromeClient::supportsVideoFullscreen):
1791         (WebChromeClient::supportsFullScreenForElement):
1792         (WebChromeClient::enterFullScreenForElement):
1793         (WebChromeClient::exitFullScreenForElement):
1794         * WebCoreSupport/WebContextMenuClient.mm:
1795         * WebCoreSupport/WebDragClient.mm:
1796         * WebCoreSupport/WebEditorClient.h:
1797         * WebCoreSupport/WebEditorClient.mm:
1798         (+[WebUndoStep initialize]):
1799         (updateFontPanel):
1800         (WebEditorClient::didBeginEditing):
1801         (WebEditorClient::respondToChangedContents):
1802         (WebEditorClient::respondToChangedSelection):
1803         (WebEditorClient::canceledComposition):
1804         (WebEditorClient::didEndEditing):
1805         (WebEditorClient::didWriteSelectionToPasteboard):
1806         (attributesForAttributedStringConversion):
1807         (WebEditorClient::setInsertionPasteboard):
1808         (WebEditorClient::registerUndoOrRedoStep):
1809         (WebEditorClient::handleKeyboardEvent):
1810         (WebEditorClient::handleInputMethodKeydown):
1811         (WebEditorClient::textDidChangeInTextField):
1812         (WebEditorClient::requestCheckingOfString):
1813         * WebCoreSupport/WebFrameLoaderClient.h:
1814         * WebCoreSupport/WebFrameLoaderClient.mm:
1815         (WebFrameLoaderClient::detachedFromParent2):
1816         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1817         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1818         (WebFrameLoaderClient::dispatchWillSendRequest):
1819         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1820         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1821         (WebFrameLoaderClient::willCacheResponse const):
1822         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1823         (WebFrameLoaderClient::dispatchDidFinishLoading):
1824         (WebFrameLoaderClient::dispatchDidFailLoading):
1825         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1826         (WebFrameLoaderClient::dispatchWillClose):
1827         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1828         (WebFrameLoaderClient::dispatchDidCommitLoad):
1829         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1830         (WebFrameLoaderClient::dispatchDidFailLoad):
1831         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1832         (WebFrameLoaderClient::dispatchDidFinishLoad):
1833         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1834         (WebFrameLoaderClient::willChangeTitle):
1835         (WebFrameLoaderClient::didChangeTitle):
1836         (WebFrameLoaderClient::didReplaceMultipartContent):
1837         (WebFrameLoaderClient::updateGlobalHistory):
1838         (WebFrameLoaderClient::saveViewStateToItem):
1839         (WebFrameLoaderClient::restoreViewState):
1840         (WebFrameLoaderClient::provisionalLoadStarted):
1841         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1842         (WebFrameLoaderClient::setTitle):
1843         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1844         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1845         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1846         (WebFrameLoaderClient::didRestoreFromPageCache):
1847         (WebFrameLoaderClient::actionDictionary const):
1848         (WebFrameLoaderClient::createPlugin):
1849         (WebFrameLoaderClient::getLoadDecisionForIcons):
1850         (WebFrameLoaderClient::finishedLoadingIcon):
1851         (+[WebFramePolicyListener initialize]):
1852         * WebCoreSupport/WebFrameNetworkingContext.mm:
1853         * WebCoreSupport/WebGeolocationClient.h:
1854         * WebCoreSupport/WebGeolocationClient.mm:
1855         (WebGeolocationClient::requestPermission):
1856         * WebCoreSupport/WebInspectorClient.h:
1857         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1858         * WebCoreSupport/WebNotificationClient.mm:
1859         * WebCoreSupport/WebOpenPanelResultListener.mm:
1860         * WebCoreSupport/WebPlatformStrategies.h:
1861         * WebCoreSupport/WebPlatformStrategies.mm:
1862         * WebCoreSupport/WebProgressTrackerClient.h:
1863         * WebCoreSupport/WebProgressTrackerClient.mm:
1864         (WebProgressTrackerClient::progressStarted):
1865         (WebProgressTrackerClient::progressEstimateChanged):
1866         (WebProgressTrackerClient::progressFinished):
1867         * WebCoreSupport/WebSecurityOrigin.mm:
1868         * WebInspector/WebNodeHighlight.h:
1869         * WebInspector/WebNodeHighlight.mm:
1870         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1871         (-[WebNodeHighlight dealloc]):
1872         (-[WebNodeHighlight attach]):
1873         * WebInspector/WebNodeHighlightView.h:
1874         * WebInspector/WebNodeHighlightView.mm:
1875         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1876         (-[WebNodeHighlightView dealloc]):
1877         * WebInspector/WebNodeHighlighter.mm:
1878         (-[WebNodeHighlighter highlight]):
1879         * WebView/WebArchive.mm:
1880         (+[WebArchivePrivate initialize]):
1881         * WebView/WebClipView.h:
1882         * WebView/WebDataSource.mm:
1883         (WebDataSourcePrivate::WebDataSourcePrivate):
1884         (+[WebDataSource initialize]):
1885         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1886         (-[WebDataSource _makeRepresentation]):
1887         * WebView/WebDelegateImplementationCaching.h:
1888         * WebView/WebDelegateImplementationCaching.mm:
1889         (CallDelegate):
1890         (CallDelegateReturningFloat):
1891         (CallDelegateReturningBoolean):
1892         (CallUIDelegate):
1893         (CallUIDelegateReturningFloat):
1894         (CallUIDelegateReturningBoolean):
1895         (CallFrameLoadDelegate):
1896         (CallFrameLoadDelegateReturningBoolean):
1897         (CallResourceLoadDelegate):
1898         (CallScriptDebugDelegate):
1899         (CallFormDelegate):
1900         (CallFormDelegateReturningBoolean):
1901         * WebView/WebDeviceOrientation.mm:
1902         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1903         * WebView/WebDocumentInternal.h:
1904         * WebView/WebDocumentLoaderMac.mm:
1905         (needsDataLoadWorkaround):
1906         * WebView/WebDynamicScrollBarsViewInternal.h:
1907         * WebView/WebFormDelegate.m:
1908         * WebView/WebFrame.mm:
1909         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1910         (-[WebFrame _unmarkAllMisspellings]):
1911         (-[WebFrame _paintBehaviorForDestinationContext:]):
1912         (-[WebFrame _drawRect:contentsOnly:]):
1913         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1914         (-[WebFrame _scrollDOMRangeToVisible:]):
1915         (-[WebFrame _bodyBackgroundColor]):
1916         (-[WebFrame accessibilityRoot]):
1917         (needsMicrosoftMessengerDOMDocumentWorkaround):
1918         * WebView/WebFrameInternal.h:
1919         * WebView/WebFrameView.mm:
1920         (-[WebFrameView _setDocumentView:]):
1921         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1922         (-[WebFrameView _viewClassForMIMEType:]):
1923         (-[WebFrameView initWithFrame:]):
1924         (-[WebFrameView drawRect:]):
1925         (-[WebFrameView _firstResponderIsFormControl]):
1926         (-[WebFrameView keyDown:keyDown:]):
1927         (-[WebFrameView _isScrollable]):
1928         * WebView/WebFullScreenController.h:
1929         * WebView/WebFullScreenController.mm:
1930         * WebView/WebHTMLRepresentation.mm:
1931         * WebView/WebHTMLView.mm:
1932         (-[WebHTMLView hitTest:]):
1933         (-[WebHTMLView initWithFrame:]):
1934         (-[WebHTMLView dealloc]):
1935         (-[WebHTMLView addSubview:]):
1936         (-[WebHTMLView mouseDown:]):
1937         (-[WebHTMLView mouseUp:]):
1938         (-[WebHTMLView resignFirstResponder]):
1939         (-[WebHTMLView accessibilityHitTest:]):
1940         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1941         * WebView/WebHTMLViewInternal.h:
1942         * WebView/WebIndicateLayer.h:
1943         * WebView/WebIndicateLayer.mm:
1944         * WebView/WebMediaPlaybackTargetPicker.h:
1945         * WebView/WebMediaPlaybackTargetPicker.mm:
1946         * WebView/WebPDFDocumentExtras.h:
1947         * WebView/WebPDFDocumentExtras.mm:
1948         * WebView/WebPDFRepresentation.h:
1949         * WebView/WebPDFRepresentation.mm:
1950         * WebView/WebPDFView.h:
1951         * WebView/WebPreferences.mm:
1952         (cacheModelForMainBundle):
1953         (WebPreferencesPrivate::WebPreferencesPrivate):
1954         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1955         (-[WebPreferences encodeWithCoder:]):
1956         (+[WebPreferences standardPreferences]):
1957         (+[WebPreferences initialize]):
1958         (-[WebPreferences _valueForKey:]):
1959         (-[WebPreferences _setStringValue:forKey:]):
1960         (-[WebPreferences _setIntegerValue:forKey:]):
1961         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1962         (-[WebPreferences _setFloatValue:forKey:]):
1963         (-[WebPreferences _setBoolValue:forKey:]):
1964         (-[WebPreferences _setLongLongValue:forKey:]):
1965         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1966         (-[WebPreferences _postCacheModelChangedNotification]):
1967         (-[WebPreferences _postPreferencesChangedNotification]):
1968         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1969         (-[WebPreferences setStorageBlockingPolicy:]):
1970         * WebView/WebResource.mm:
1971         (+[WebResourcePrivate initialize]):
1972         * WebView/WebTextCompletionController.h:
1973         * WebView/WebTextIterator.mm:
1974         (+[WebTextIteratorPrivate initialize]):
1975         * WebView/WebView.mm:
1976         (shouldEnableLoadDeferring):
1977         (shouldRestrictWindowFocus):
1978         (shouldRespectPriorityInCSSAttributeSetters):
1979         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1980         (shouldAllowPictureInPictureMediaPlayback):
1981         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1982         (shouldAllowWindowOpenWithoutUserGesture):
1983         (shouldConvertInvalidURLsToBlank):
1984         (shouldRequireUserGestureToLoadVideo):
1985         (-[WebView _commonInitializationWithFrameName:groupName:]):
1986         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1987         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1988         (-[WebView _closePluginDatabases]):
1989         (-[WebView _closeWithFastTeardown]):
1990         (-[WebView _close]):
1991         (+[WebView _MIMETypeForFile:]):
1992         (-[WebView setShowingInspectorIndication:]):
1993         (-[WebView _setFormDelegate:]):
1994         (-[WebView _needsPreHTML5ParserQuirks]):
1995         (-[WebView _preferencesChangedNotification:]):
1996         (-[WebView _preferencesChanged:]):
1997         (-[WebView _cacheResourceLoadDelegateImplementations]):
1998         (-[WebView _cacheFrameLoadDelegateImplementations]):
1999         (-[WebView _policyDelegateForwarder]):
2000         (-[WebView _UIDelegateForwarder]):
2001         (-[WebView _editingDelegateForwarder]):
2002         (-[WebView _updateActiveState]):
2003         (-[_WebSafeForwarder forwardInvocation:]):
2004         (+[WebView initialize]):
2005         (-[WebView _pluginForMIMEType:]):
2006         (-[WebView _pluginForExtension:]):
2007         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2008         (+[WebView canShowMIMETypeAsHTML:]):
2009         (-[WebView _initWithArguments:]):
2010         (-[WebView initWithFrame:frameName:groupName:]):
2011         (-[WebView dealloc]):
2012         (-[WebView close]):
2013         (-[WebView viewDidMoveToWindow]):
2014         (-[WebView setUIDelegate:]):
2015         (-[WebView setResourceLoadDelegate:]):
2016         (-[WebView setPolicyDelegate:]):
2017         (-[WebView setFrameLoadDelegate:]):
2018         (-[WebView goBack]):
2019         (-[WebView goForward]):
2020         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2021         (-[WebView setHostWindow:]):
2022         (-[WebView becomeFirstResponder]):
2023         (+[WebView _cacheModelChangedNotification:]):
2024         (-[WebView _frameViewAtWindowPoint:]):
2025         (+[WebView _preflightSpellCheckerNow:]):
2026         (+[WebView _preflightSpellChecker]):
2027         (-[WebView canGoBack]):
2028         (-[WebView canGoForward]):
2029         (-[WebView stopLoading:]):
2030         (-[WebView reload:]):
2031         (-[WebView setMainFrameDocumentReady:]):
2032         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2033         (-[WebView setContinuousSpellCheckingEnabled:]):
2034         (-[WebView undoManager]):
2035         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2036         (-[WebView isAutomaticLinkDetectionEnabled]):
2037         (-[WebView isAutomaticDashSubstitutionEnabled]):
2038         (-[WebView isAutomaticTextReplacementEnabled]):
2039         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2040         (+[WebView _setCacheModel:]):
2041         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2042         (-[WebView _keyboardUIMode]):
2043         (LayerFlushController::flushLayers):
2044         (-[WebView _scheduleCompositingLayerFlush]):
2045         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2046         (-[WebView fullScreenPlaceholderView]):
2047         (WebInstallMemoryPressureHandler):
2048         * WebView/WebViewData.h:
2049         * WebView/WebViewData.mm:
2050         (+[WebViewPrivate initialize]):
2051         (-[WebViewPrivate init]):
2052         (-[WebViewPrivate dealloc]):
2053         * WebView/WebViewInternal.h:
2054
2055 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2056
2057         Clean up FrameLoader two-state enums
2058         https://bugs.webkit.org/show_bug.cgi?id=190731
2059
2060         Reviewed by Chris Dumez.
2061
2062         * WebCoreSupport/WebFrameLoaderClient.h:
2063         * WebCoreSupport/WebFrameLoaderClient.mm:
2064         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2065
2066 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2067
2068         Unreviewed, rolling out r237137.
2069
2070         SPI is actually used
2071
2072         Reverted changeset:
2073
2074         "Remove unused WebFrame._loadType"
2075         https://bugs.webkit.org/show_bug.cgi?id=190583
2076         https://trac.webkit.org/changeset/237137
2077
2078 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2079
2080         Enable the datalist element by default on iOS and macOS
2081         https://bugs.webkit.org/show_bug.cgi?id=190594
2082         <rdar://problem/45281159>
2083
2084         Reviewed by Ryosuke Niwa and Tim Horton.
2085
2086         * Configurations/FeatureDefines.xcconfig:
2087
2088 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2089
2090         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2091         https://bugs.webkit.org/show_bug.cgi?id=190675
2092
2093         Reviewed by Chris Dumez.
2094
2095         * History/BackForwardList.h:
2096         * History/BackForwardList.mm:
2097         (BackForwardList::backItem):
2098         (BackForwardList::currentItem):
2099         (BackForwardList::forwardItem):
2100         (BackForwardList::backListCount const):
2101         (BackForwardList::forwardListCount const):
2102         (BackForwardList::itemAtIndex):
2103         * History/WebBackForwardList.mm:
2104         (-[WebBackForwardList backItem]):
2105         (-[WebBackForwardList currentItem]):
2106         (-[WebBackForwardList forwardItem]):
2107         (-[WebBackForwardList itemAtIndex:]):
2108
2109 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2110
2111         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2112         https://bugs.webkit.org/show_bug.cgi?id=190526
2113         rdar://problem/45230140
2114
2115         Reviewed by Dean Jackson.
2116
2117         * WebCoreSupport/WebEditorClient.mm:
2118         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2119
2120 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2121
2122         Implement feature flag and bindings for CSS Painting API
2123         https://bugs.webkit.org/show_bug.cgi?id=190237
2124
2125         Reviewed by Ryosuke Niwa.
2126
2127         * Configurations/FeatureDefines.xcconfig:
2128
2129 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2130
2131         Replace HistoryItem* with HistoryItem& where possible
2132         https://bugs.webkit.org/show_bug.cgi?id=190617
2133
2134         Reviewed by Chris Dumez.
2135
2136         * History/BackForwardList.h:
2137         * History/BackForwardList.mm:
2138         (BackForwardList::goToItem):
2139         * History/WebBackForwardList.mm:
2140         (-[WebBackForwardList goToItem:]):
2141         * History/WebHistoryItem.mm:
2142         (WKNotifyHistoryItemChanged):
2143         * History/WebHistoryItemInternal.h:
2144
2145 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2146
2147         Remove unused WebHistoryItem._transientPropertyForKey
2148         https://bugs.webkit.org/show_bug.cgi?id=190606
2149
2150         Reviewed by Chris Dumez.
2151
2152         * History/WebHistoryItem.mm:
2153         * History/WebHistoryItemPrivate.h:
2154
2155 2018-10-15  Justin Fan  <justin_fan@apple.com>
2156
2157         Add WebGPU 2018 feature flag and experimental feature flag
2158         https://bugs.webkit.org/show_bug.cgi?id=190509
2159
2160         Reviewed by Dean Jackson.
2161
2162         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2163         for the 2018 WebGPU prototype.
2164
2165         * Configurations/FeatureDefines.xcconfig:
2166         * WebView/WebPreferenceKeysPrivate.h:
2167         * WebView/WebPreferences.mm:
2168         (+[WebPreferences initialize]):
2169         (-[WebPreferences webGPUEnabled]):
2170         (-[WebPreferences setWebGPUEnabled:]):
2171         * WebView/WebPreferencesPrivate.h:
2172         * WebView/WebView.mm:
2173         (-[WebView _preferencesChanged:]):
2174
2175 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2176
2177         Fix iOS build after r237157
2178
2179         * WebView/WebView.mm:
2180         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2181
2182 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2183
2184         Modernize BackForwardClient.h
2185         https://bugs.webkit.org/show_bug.cgi?id=190610
2186
2187         Reviewed by Chris Dumez.
2188
2189         * History/BackForwardList.h:
2190         * History/BackForwardList.mm:
2191         (BackForwardList::backListCount const):
2192         (BackForwardList::forwardListCount const):
2193         (BackForwardList::backListCount): Deleted.
2194         (BackForwardList::forwardListCount): Deleted.
2195         * History/WebBackForwardList.mm:
2196         (-[WebBackForwardList init]):
2197         * WebCoreSupport/WebFrameLoaderClient.mm:
2198         (WebFrameLoaderClient::canCachePage const):
2199         * WebView/WebFrameView.mm:
2200         (-[WebFrameView keyDown:keyDown:]):
2201         * WebView/WebView.mm:
2202         (-[WebView _commonInitializationWithFrameName:groupName:]):
2203         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2204         (-[WebView _loadBackForwardListFromOtherView:]):
2205         (-[WebView initWithCoder:]):
2206         (-[WebView encodeWithCoder:]):
2207         (-[WebView backForwardList]):
2208         (-[WebView setMaintainsBackForwardList:]):
2209
2210 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2211
2212         Add support for prefers-color-scheme media query
2213         https://bugs.webkit.org/show_bug.cgi?id=190499
2214         rdar://problem/45212025
2215
2216         Reviewed by Dean Jackson.
2217
2218         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2219
2220 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2221
2222         Remove unused WebView._globalHistoryItem
2223         https://bugs.webkit.org/show_bug.cgi?id=190601
2224
2225         Reviewed by Chris Dumez.
2226
2227         * WebCoreSupport/WebFrameLoaderClient.h:
2228         * WebCoreSupport/WebFrameLoaderClient.mm:
2229         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2230         * WebView/WebView.mm:
2231         (-[WebView _globalHistoryItem]): Deleted.
2232         (-[WebView _setGlobalHistoryItem:]): Deleted.
2233         * WebView/WebViewData.h:
2234         * WebView/WebViewInternal.h:
2235         * WebView/WebViewPrivate.h:
2236
2237 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2238
2239         Remove unused parameters from FrameLoaderClient::createFrame
2240         https://bugs.webkit.org/show_bug.cgi?id=190587
2241
2242         Reviewed by Chris Dumez.
2243
2244         * WebCoreSupport/WebFrameLoaderClient.h:
2245         * WebCoreSupport/WebFrameLoaderClient.mm:
2246         (WebFrameLoaderClient::createFrame):
2247
2248 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2249
2250         Remove unused WebFrame._loadType
2251         https://bugs.webkit.org/show_bug.cgi?id=190583
2252
2253         Reviewed by Chris Dumez.
2254
2255         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2256
2257         * WebView/WebFrame.mm:
2258         (toWebFrameLoadType): Deleted.
2259         (-[WebFrame _loadType]): Deleted.
2260         * WebView/WebFramePrivate.h:
2261
2262 2018-10-15  Chris Dumez  <cdumez@apple.com>
2263
2264         Restrict browsing context lookup by name to frames that are related to one another
2265         https://bugs.webkit.org/show_bug.cgi?id=190475
2266
2267         Reviewed by Alex Christensen.
2268
2269         * WebView/WebFrame.mm:
2270         (-[WebFrame findFrameNamed:]):
2271
2272 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2273
2274         Remove InjectedBundle processing of back/forward lists
2275         https://bugs.webkit.org/show_bug.cgi?id=190459
2276
2277         Reviewed by Chris Dumez.
2278
2279         * WebCoreSupport/WebFrameLoaderClient.h:
2280         * WebCoreSupport/WebFrameLoaderClient.mm:
2281         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2282
2283 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2284
2285         [JSC] Remove Option::useAsyncIterator
2286         https://bugs.webkit.org/show_bug.cgi?id=190567
2287
2288         Reviewed by Saam Barati.
2289
2290         * Configurations/FeatureDefines.xcconfig:
2291
2292 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2293
2294         Allow encoding of small enum classes
2295         https://bugs.webkit.org/show_bug.cgi?id=190531
2296
2297         Reviewed by Tim Horton.
2298
2299         * WebCoreSupport/WebFrameLoaderClient.mm:
2300         (-[WebFramePolicyListener dealloc]):
2301
2302 2018-10-11  Keith Rollin  <krollin@apple.com>
2303
2304         CURRENT_ARCH should not be used in Run Script phase.
2305         https://bugs.webkit.org/show_bug.cgi?id=190407
2306         <rdar://problem/45133556>
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2311         CURRENT_ARCH is not well-defined during this phase (and may even have
2312         the value "undefined") since this phase is run just once per build
2313         rather than once per supported architecture. Migrate away from
2314         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2315         performing an operation for each value, or by picking the first entry
2316         in ARCHS and using that as a representative value.
2317
2318         * Configurations/WebKitLegacy.xcconfig: When generating
2319         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2320         macosx platforms.
2321
2322         * MigrateHeaders.make:
2323         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2324         generate one for each architecture in ARCHS.
2325
2326 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2327
2328         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2329         https://bugs.webkit.org/show_bug.cgi?id=190429
2330
2331         Reviewed by Saam Barati.
2332
2333         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2334
2335         * WebView/WebPDFRepresentation.mm:
2336         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2337
2338 2018-10-08  Justin Fan  <justin_fan@apple.com>
2339
2340         WebGPU: Rename old WebGPU prototype to WebMetal
2341         https://bugs.webkit.org/show_bug.cgi?id=190325
2342         <rdar://problem/44990443>
2343
2344         Reviewed by Dean Jackson.
2345
2346         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2347
2348         * Configurations/FeatureDefines.xcconfig:
2349         * WebView/WebPreferenceKeysPrivate.h:
2350         * WebView/WebPreferences.mm:
2351         (+[WebPreferences initialize]):
2352         (-[WebPreferences webMetalEnabled]):
2353         (-[WebPreferences setWebMetalEnabled:]):
2354         (-[WebPreferences webGPUEnabled]): Deleted.
2355         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2356         * WebView/WebPreferencesPrivate.h:
2357         * WebView/WebView.mm:
2358         (-[WebView _preferencesChanged:]):
2359
2360 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2361
2362         Make <input type=color> a runtime enabled (on-by-default) feature
2363         https://bugs.webkit.org/show_bug.cgi?id=189162
2364
2365         Reviewed by Wenson Hsieh and Tim Horton.
2366
2367         * Configurations/FeatureDefines.xcconfig:
2368
2369 2018-10-07  Dan Bernstein  <mitz@apple.com>
2370
2371         Fixed building with the latest macOS SDK
2372
2373         * Plugins/WebNetscapePluginPackage.mm:
2374         (-[WebNetscapePluginPackage openResourceFile]):
2375         (-[WebNetscapePluginPackage closeResourceFile:]):
2376
2377 2018-10-04  Dan Bernstein  <mitz@apple.com>
2378
2379         More Carbon build-fixing.
2380
2381         * Carbon/CarbonWindowAdapter.mm:
2382         (-[CarbonWindowAdapter _destroyRealWindow:]):
2383         (-[CarbonWindowAdapter _growBoxRect]):
2384
2385 2018-10-04  Dan Bernstein  <mitz@apple.com>
2386
2387         Retried to fix 32-bit macOS builds after r236846.
2388
2389         * WebView/WebHTMLView.mm:
2390         (-[WebHTMLView setMarkedText:selectedRange:]):
2391
2392 2018-10-04  Dan Bernstein  <mitz@apple.com>
2393
2394         Retried to fix 32-bit macOS builds after r236846.
2395
2396         * Carbon/HIWebView.mm:
2397         (ActiveStateChanged):
2398
2399 2018-10-04  Dan Bernstein  <mitz@apple.com>
2400
2401         Tried to fix 32-bit macOS builds after r236846.
2402
2403         * Carbon/HIWebView.mm:
2404         (_NSSelectorForHICommand):
2405
2406 2018-10-04  Dan Bernstein  <mitz@apple.com>
2407
2408         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2409         https://bugs.webkit.org/show_bug.cgi?id=190250
2410
2411         Reviewed by Andy Estes.
2412
2413         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2414           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2415           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2416           an earlier line set it to YES.
2417
2418         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2419         changes below.
2420
2421         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2422           provides some missing method declarations.
2423
2424         * Misc/WebDownload.mm:
2425         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2426           a deprecated method.
2427
2428         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2429
2430         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2431           other code in the file uses a method from it.
2432
2433         * Plugins/WebBaseNetscapePluginView.mm:
2434         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2435           a deprecated method.
2436
2437         * Plugins/WebPluginController.mm:
2438         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2439           around use of a selector that may be present in some WebKit client.
2440
2441         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2442           method declarations.
2443
2444         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2445           from here.
2446
2447         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2448           missing method declarations.
2449
2450         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2451           from here.
2452
2453         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2454           call from here.
2455         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2456           an obsolete delegate method for binary compatibility.
2457         (pluginView): Ditto.
2458
2459         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2460           call from here.
2461
2462         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2463           WebDeviceOrientationProviderMock protocol.
2464
2465         * WebView/WebDeviceOrientationProviderMock.mm:
2466         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2467           main @implementation.
2468
2469         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2470           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2471
2472         * WebView/WebDynamicScrollBarsView.mm:
2473         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2474           of a deprecated method.
2475
2476         * WebView/WebHTMLView.mm:
2477         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2478           selector warning around action methods that are not declared anywhere in WebKit.
2479
2480         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2481           about implementing this deprecated method.
2482         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2483         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2484         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2485         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2486         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2487         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2488         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2489         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2490         (-[WebHTMLView doCommandBySelector:]): Ditto.
2491         (-[WebHTMLView insertText:]): Ditto.
2492
2493         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2494
2495         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2496
2497         * WebView/WebPDFView.h: Removed previewView ivar.
2498
2499         * WebView/WebPDFView.mm:
2500           Removed declaration of FileInternal category and merged its implementation with the main
2501           implementation.
2502         (-[WebPDFView dealloc]): Removed previewView ivar.
2503         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2504           exist in macOS versions we support.
2505         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2506         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2507           action methods internal to PDFKit.
2508         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2509         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2510
2511         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2512           call on macOS, even though in r86988 we started calling different methods on iOS.
2513
2514         * WebView/WebView.mm:
2515         - Imported headers that declare delegate methods that we call.
2516         - Removed declaration of WebFileInternal category and merged its implementation with the
2517           main implementation.
2518         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2519           category, which made them impossible to call from the main implementation. Moved those
2520           into the main implementation. One of those had to be declared in a class extension,
2521           because it is called from a method implemented in the WebPrivate category, and that
2522           category’s implementation appears first in the file.
2523
2524         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2525           around use of obsolete delegate method for binary compatibility.
2526
2527         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2528
2529 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2530
2531         Runtime flag and IDL for MediaRecorder
2532         https://bugs.webkit.org/show_bug.cgi?id=190018
2533
2534         Reviewed by Youenn Fablet and Chris Dumez.
2535
2536         * WebView/WebPreferenceKeysPrivate.h:
2537         * WebView/WebPreferences.mm:
2538         (+[WebPreferences initialize]):
2539         (-[WebPreferences mediaRecorderEnabled]):
2540         (-[WebPreferences setMediaRecorderEnabled:]):
2541         * WebView/WebPreferencesPrivate.h:
2542         * WebView/WebView.mm:
2543         (-[WebView _preferencesChanged:]):
2544
2545 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2546
2547         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2548         https://bugs.webkit.org/show_bug.cgi?id=190238
2549
2550         Reviewed by Antti Koivisto.
2551
2552         Enabled the feature by default.
2553
2554         * WebView/WebPreferences.mm:
2555         (+[WebPreferences initialize]):
2556
2557 2018-10-01  Dean Jackson  <dino@apple.com>
2558
2559         [macOS] Switching to discrete GPU should be done in the UI process
2560         https://bugs.webkit.org/show_bug.cgi?id=189361
2561         <rdar://problem/43949622>
2562
2563         Reviewed by Simon Fraser.
2564
2565         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2566         not support swapping to the discrete GPU in this configuration.
2567
2568         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2569         (WebKit::WebSwitchingGPUClient::singleton):
2570         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2571         * WebView/WebView.mm:
2572         (-[WebView _commonInitializationWithFrameName:groupName:]):
2573
2574 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2575
2576         Remove ParsedURLString
2577         https://bugs.webkit.org/show_bug.cgi?id=190154
2578
2579         Reviewed by Chris Dumez.
2580
2581         * WebView/WebScriptDebugger.mm:
2582         (toNSURL):
2583
2584 2018-10-01  Dean Jackson  <dino@apple.com>
2585
2586         Remove CSS Animation Triggers
2587         https://bugs.webkit.org/show_bug.cgi?id=190175
2588         <rdar://problem/44925626>
2589
2590         Reviewed by Simon Fraser.
2591
2592         * Configurations/FeatureDefines.xcconfig:
2593
2594 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2595
2596         Unreviewed, rolling out r236624 and r236671.
2597         https://bugs.webkit.org/show_bug.cgi?id=190207
2598
2599         The change in r236624 introduced crashes on the bots
2600         (Requested by ryanhaddad on #webkit).
2601
2602         Reverted changesets:
2603
2604         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2605         https://bugs.webkit.org/show_bug.cgi?id=188747
2606         https://trac.webkit.org/changeset/236624
2607
2608         "Unify implementation in VideoFullscreenInterfaceAVKit"
2609         https://bugs.webkit.org/show_bug.cgi?id=190091
2610         https://trac.webkit.org/changeset/236671
2611
2612 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2613
2614         URL should not use TextEncoding internally
2615         https://bugs.webkit.org/show_bug.cgi?id=190111
2616
2617         Reviewed by Andy Estes.
2618
2619         * Misc/WebNSURLExtras.mm:
2620
2621 2018-09-28  Jer Noble  <jer.noble@apple.com>
2622
2623         Refactoring: eliminate raw pointer usage in Fullscreen code
2624         https://bugs.webkit.org/show_bug.cgi?id=188747
2625         <rdar://problem/43541164>
2626
2627         Reviewed by Alex Christensen.
2628
2629         PlaybackSessionInterface no longer has an invalidate() method.
2630
2631         * WebView/WebView.mm:
2632         (-[WebView _clearPlaybackControlsManager]):
2633
2634 2018-09-28  Chris Dumez  <cdumez@apple.com>
2635
2636         Drop support for cross-origin-window-policy header
2637         https://bugs.webkit.org/show_bug.cgi?id=190081
2638
2639         Reviewed by Ryosuke Niwa.
2640
2641         * WebView/WebPreferenceKeysPrivate.h:
2642         * WebView/WebPreferences.mm:
2643         (+[WebPreferences initialize]):
2644         * WebView/WebPreferencesPrivate.h:
2645         * WebView/WebView.mm:
2646         (-[WebView _preferencesChanged:]):
2647
2648 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2649
2650         Rename createMarkup to serializePreservingVisualAppearance
2651         https://bugs.webkit.org/show_bug.cgi?id=190086
2652
2653         Reviewed by Wenson Hsieh.
2654
2655         * DOM/WebDOMOperations.mm:
2656         (-[DOMRange markupString]):
2657
2658 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2659
2660         Unreviewed, rolling out r236605.
2661         https://bugs.webkit.org/show_bug.cgi?id=190087
2662
2663         caused three API test timeouts (Requested by jernoble on
2664         #webkit).
2665
2666         Reverted changeset:
2667
2668         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2669         https://bugs.webkit.org/show_bug.cgi?id=188747
2670         https://trac.webkit.org/changeset/236605
2671
2672 2018-09-28  Jer Noble  <jer.noble@apple.com>
2673
2674         Refactoring: eliminate raw pointer usage in Fullscreen code
2675         https://bugs.webkit.org/show_bug.cgi?id=188747
2676         <rdar://problem/43541164>
2677
2678         Reviewed by Alex Christensen.
2679
2680         PlaybackSessionInterface no longer has an invalidate() method.
2681
2682         * WebView/WebView.mm:
2683         (-[WebView _clearPlaybackControlsManager]):
2684
2685 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2686
2687         Use enum class in createMarkup arguments
2688         https://bugs.webkit.org/show_bug.cgi?id=190028
2689
2690         Reviewed by Wenson Hsieh.
2691
2692         * DOM/WebDOMOperations.mm:
2693         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2694         (-[DOMRange markupString]): Ditto.
2695
2696 2018-09-27  Antoine Quint  <graouts@apple.com>
2697
2698         [Web Animations] Turn Web Animations with CSS integration on
2699         https://bugs.webkit.org/show_bug.cgi?id=184819
2700         <rdar://problem/39597337>
2701
2702         Reviewed by Dean Jackson.
2703
2704         * WebView/WebPreferences.mm:
2705         (+[WebPreferences initialize]):
2706
2707 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2708
2709         Selection should work across shadow boundary when initiated by a mouse drag
2710         https://bugs.webkit.org/show_bug.cgi?id=151380
2711         <rdar://problem/24363872>
2712
2713         Reviewed by Wenson Hsieh.
2714
2715         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2716
2717         * WebView/WebPreferenceKeysPrivate.h:
2718         * WebView/WebPreferences.mm:
2719         (+[WebPreferences initialize]):
2720         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2721         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2722         * WebView/WebPreferencesPrivate.h:
2723         * WebView/WebView.mm:
2724         (-[WebView _preferencesChanged:]):
2725
2726 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2727
2728         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2729         https://bugs.webkit.org/show_bug.cgi?id=189918
2730         Work towards <rdar://problem/44648705>
2731
2732         Reviewed by Tim Horton.
2733
2734         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2735
2736         * WebView/WebHTMLView.mm:
2737         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2738         (-[WebHTMLView _updateFontPanel]):
2739         * WebView/WebView.mm:
2740         (-[WebView typingAttributes]):
2741
2742 2018-09-17  Darin Adler  <darin@apple.com>
2743
2744         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2745         https://bugs.webkit.org/show_bug.cgi?id=189652
2746
2747         Reviewed by Saam Barati.
2748
2749         * WebView/WebPDFRepresentation.mm:
2750         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2751
2752 2018-09-14  Jer Noble  <jer.noble@apple.com>
2753
2754         Turn SourceBufferChangeTypeEnabled on by default
2755         https://bugs.webkit.org/show_bug.cgi?id=189527
2756
2757         Reviewed by Eric Carlson.
2758
2759         * WebView/WebPreferences.mm:
2760         (+[WebPreferences initialize]):
2761
2762 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2763
2764         Fix an internal build after r235935
2765         https://bugs.webkit.org/show_bug.cgi?id=188996
2766
2767         * Carbon/HIWebView.mm:
2768         (Draw):
2769         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2770
2771 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2772
2773         Add IGNORE_WARNING_.* macros
2774         https://bugs.webkit.org/show_bug.cgi?id=188996
2775
2776         Reviewed by Michael Catanzaro.
2777
2778         * Carbon/CarbonUtils.m:
2779         (PoolCleaner):
2780         * Carbon/CarbonWindowAdapter.mm:
2781         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2782         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2783         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2784         (-[CarbonWindowAdapter _termWindowIfOwner]):
2785         (-[CarbonWindowAdapter _windowMovedToRect:]):
2786         (-[CarbonWindowAdapter setContentView:]):
2787         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2788         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2789         * Carbon/CarbonWindowFrame.m:
2790         (-[CarbonWindowFrame title]):
2791         * Carbon/HIViewAdapter.m:
2792         (+[HIViewAdapter getHIViewForNSView:]):
2793         * Carbon/HIWebView.mm:
2794         (overrideCGContext):
2795         (restoreCGContext):
2796         (Draw):
2797         * DOM/DOM.mm:
2798         * History/WebHistory.mm:
2799         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2800         * History/WebHistoryItem.mm:
2801         (-[WebHistoryItem icon]):
2802         * Misc/WebKitNSStringExtras.mm:
2803         (-[NSString _web_drawAtPoint:font:textColor:]):
2804         * Misc/WebNSImageExtras.m:
2805         (-[NSImage _web_scaleToMaxSize:]):
2806         (-[NSImage _web_dissolveToFraction:]):
2807         * Misc/WebNSPasteboardExtras.mm:
2808         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2809         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2810         * Panels/WebAuthenticationPanel.m:
2811         (-[WebAuthenticationPanel loadNib]):
2812         * Plugins/Hosted/NetscapePluginHostManager.mm:
2813         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2814         (WebKit::NetscapePluginHostManager::didCreateWindow):
2815         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2816         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2817         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2818         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2819         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2820         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2821         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2822         (-[WebHostedNetscapePluginView drawRect:]):
2823         * Plugins/Hosted/WebTextInputWindowController.m:
2824         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2825         * Plugins/WebBaseNetscapePluginView.mm:
2826         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2827         * Plugins/WebNetscapePluginPackage.mm:
2828         (-[WebNetscapePluginPackage _tryLoad]):
2829         * Plugins/WebNetscapePluginView.mm:
2830         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2831         (-[WebNetscapePluginView sendDrawRectEvent:]):
2832         (-[WebNetscapePluginView drawRect:]):
2833         * Plugins/WebPluginController.mm:
2834         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2835         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2836         * WebCoreSupport/PopupMenuMac.mm:
2837         (PopupMenuMac::populate):
2838         * WebCoreSupport/WebAlternativeTextClient.h:
2839         * WebCoreSupport/WebDragClient.mm:
2840         (WebDragClient::startDrag):
2841         * WebCoreSupport/WebFrameLoaderClient.mm:
2842         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2843         (webGetNSImage):
2844         * WebInspector/WebNodeHighlight.mm:
2845         * WebInspector/WebNodeHighlightView.mm:
2846         (-[WebNodeHighlightView drawRect:]):
2847         * WebView/WebClipView.mm:
2848         (-[WebClipView initWithFrame:]):
2849         * WebView/WebFrame.mm:
2850         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2851         (-[WebFrame _drawRect:contentsOnly:]):
2852         (-[WebFrame accessibilityRoot]):
2853         * WebView/WebFullScreenController.mm:
2854         (-[WebFullScreenController enterFullScreen:]):
2855         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2856         (-[WebFullScreenController exitFullScreen]):
2857         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2858         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2859         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2860         * WebView/WebHTMLView.mm:
2861         (-[NSWindow _web_borderView]):
2862         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2863         (-[WebHTMLView _setAsideSubviews]):
2864         (-[WebHTMLView _autoscroll]):
2865         (-[WebHTMLView drawRect:]):
2866         (-[WebHTMLView mouseDown:]):
2867         (-[WebHTMLView mouseDragged:]):
2868         (-[WebHTMLView mouseUp:]):
2869         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2870         (-[WebHTMLView knowsPageRange:]):
2871         (-[WebHTMLView accessibilityHitTest:]):
2872         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2873         (-[WebHTMLView _colorAsString:]):
2874         (-[WebHTMLView copyFont:]):
2875         (-[WebHTMLView _executeSavedKeypressCommands]):
2876         (-[WebHTMLView attachRootLayer:]):
2877         (-[WebHTMLView textStorage]):
2878         (-[WebHTMLView _updateSelectionForInputManager]):
2879         * WebView/WebPDFView.mm:
2880         (_applicationInfoForMIMEType):
2881         (-[WebPDFView centerSelectionInVisibleArea:]):
2882         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2883         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2884         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2885         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2886         * WebView/WebTextCompletionController.mm:
2887         (-[WebTextCompletionController _buildUI]):
2888         (-[WebTextCompletionController _placePopupWindow:]):
2889         * WebView/WebVideoFullscreenController.mm:
2890         * WebView/WebVideoFullscreenHUDWindowController.mm:
2891         (createMediaUIBackgroundView):
2892         * WebView/WebView.mm:
2893         (-[WebTextListTouchBarViewController initWithWebView:]):
2894         (-[WebView _dispatchTileDidDraw:]):
2895         (-[WebView encodeWithCoder:]):
2896         (-[WebView mainFrameIcon]):
2897         (LayerFlushController::flushLayers):
2898         * WebView/WebWindowAnimation.mm:
2899         (setScaledFrameForWindow):
2900
2901 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2902
2903         Remove unused needsDestruction class variables from HashTraits
2904         https://bugs.webkit.org/show_bug.cgi?id=189490
2905
2906         Reviewed by Daniel Bates.
2907
2908         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2909
2910 2018-09-07  Frederic Wang  <fwang@igalia.com>
2911
2912         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2913         https://bugs.webkit.org/show_bug.cgi?id=182230
2914
2915         Reviewed by Simon Fraser.
2916
2917         * DOM/DOMDocument.mm:
2918         (-[DOMDocument scrollingElement]): Use the new name.
2919
2920 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2921
2922         Refactor WebCore::EditAction to be an 8-bit enum class
2923         https://bugs.webkit.org/show_bug.cgi?id=189383
2924
2925         Reviewed by Dan Bernstein.
2926
2927         * WebCoreSupport/WebEditorClient.mm:
2928         (undoNameForEditAction):
2929         * WebView/WebHTMLView.mm:
2930         (-[WebHTMLView pasteFont:]):
2931         (-[WebHTMLView changeFont:]):
2932         (-[WebHTMLView changeAttributes:]):
2933         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2934         (-[WebHTMLView changeColor:]):
2935         * WebView/WebView.mm:
2936         (-[WebView setTypingStyle:]):
2937
2938 2018-09-06  Frederic Wang  <fwang@igalia.com>
2939
2940         Group options of scrollRectToVisible into a struct
2941         https://bugs.webkit.org/show_bug.cgi?id=189352
2942
2943         Reviewed by Simon Fraser.
2944
2945         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2946         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2947         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2948
2949 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2950
2951         [macOS] Cannot change font size at selection until font panel is shown
2952         https://bugs.webkit.org/show_bug.cgi?id=189295
2953         <rdar://problem/35593389>
2954
2955         Reviewed by Ryosuke Niwa.
2956
2957         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2958         WebCore ChangeLog for more details.
2959
2960         * WebView/WebHTMLView.mm:
2961         (-[WebHTMLView changeFont:]):
2962         (-[WebHTMLView changeAttributes:]):
2963         (-[WebHTMLView _originalFontA]): Deleted.
2964         (-[WebHTMLView _originalFontB]): Deleted.
2965         (fontNameForDescription): Deleted.
2966         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2967         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2968         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2969
2970 2018-09-05  Jer Noble  <jer.noble@apple.com>
2971
2972         Add MediaCapabilities as an Experimental Feature
2973         https://bugs.webkit.org/show_bug.cgi?id=189209
2974
2975         Reviewed by Eric Carlson.
2976
2977         RuntimeEnabledFeature -> Setting.
2978
2979         * WebView/WebView.mm:
2980         (-[WebView _preferencesChanged:]):
2981
2982 2018-09-04  Frederic Wang  <fwang@igalia.com>
2983
2984         Add basic support for ScrollIntoViewOptions
2985         https://bugs.webkit.org/show_bug.cgi?id=189258
2986
2987         Reviewed by Simon Fraser.
2988
2989         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2990         header so that this file can build despite the new scrollIntoView function.
2991
2992 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2993
2994         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2995         https://bugs.webkit.org/show_bug.cgi?id=188890
2996         <rdar://problem/43648605>
2997
2998         Reviewed by Tim Horton.
2999
3000         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3001         more detail.
3002
3003         * WebCoreSupport/WebPlatformStrategies.h:
3004         * WebCoreSupport/WebPlatformStrategies.mm:
3005         (WebPlatformStrategies::allStringsForType):
3006
3007 2018-09-01  Darin Adler  <darin@apple.com>
3008
3009         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3010         https://bugs.webkit.org/show_bug.cgi?id=189072
3011         Reviewed by Dan Bernstein.
3012
3013         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3014         and declarations for NSURLDownload init methods.
3015
3016         * Misc/WebDownloadInternal.h: Removed.
3017
3018         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3019         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3020         "-Wdeprecated-declarations" because the method used here is deprecated.
3021
3022         * WebView/WebView.mm:
3023         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3024         used here is deprecated.
3025
3026 2018-08-31  Chris Dumez  <cdumez@apple.com>
3027
3028         Assertion hit in ~CompletionHandler() from ~WebFrame()
3029         https://bugs.webkit.org/show_bug.cgi?id=189199
3030         <rdar://problem/42657233>
3031
3032         Reviewed by Youenn Fablet.
3033
3034         * WebCoreSupport/WebFrameLoaderClient.h:
3035         * WebCoreSupport/WebFrameLoaderClient.mm:
3036         (WebFrameLoaderClient::dispatchWillSubmitForm):
3037
3038 2018-08-31  Antti Koivisto  <antti@apple.com>
3039
3040         Replace OptionSet |= and -= operators with add() and remove() functions
3041         https://bugs.webkit.org/show_bug.cgi?id=189169
3042
3043         Reviewed by Anders Carlsson.
3044
3045         * WebView/WebFrame.mm:
3046         (-[WebFrame _drawRect:contentsOnly:]):
3047         * WebView/WebView.mm:
3048         (coreOptions):
3049
3050 2018-08-31  Frederic Wang  <fwang@igalia.com>
3051
3052         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3053         https://bugs.webkit.org/show_bug.cgi?id=182053
3054
3055         Reviewed by Simon Fraser.
3056
3057         Add developer flag to use standard behavior for scrolling* attributes.
3058
3059         * WebView/WebPreferenceKeysPrivate.h:
3060         * WebView/WebPreferences.mm:
3061         (+[WebPreferences initialize]):
3062         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3063         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3064         * WebView/WebPreferencesPrivate.h:
3065         * WebView/WebView.mm:
3066         (-[WebView _preferencesChanged:]):
3067
3068 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3069
3070         Implement the Web Share API
3071         https://bugs.webkit.org/show_bug.cgi?id=171100
3072         <rdar://problem/31751734>
3073
3074         Reviewed by Tim Horton.
3075
3076         * WebCoreSupport/WebChromeClient.h:
3077         * WebCoreSupport/WebChromeClient.mm:
3078         (WebChromeClient::showShareSheet):
3079         Empty declaration of showShareSheet.
3080
3081 2018-08-29  Youenn Fablet  <youenn@apple.com>
3082
3083         Remove WebRTC legacy API implementation
3084         https://bugs.webkit.org/show_bug.cgi?id=189040
3085
3086         Reviewed by Eric Carlson.
3087
3088         * WebView/WebPreferenceKeysPrivate.h:
3089         * WebView/WebPreferences.mm:
3090         (+[WebPreferences initialize]):
3091         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3092         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3093         * WebView/WebPreferencesPrivate.h:
3094         * WebView/WebView.mm:
3095         (-[WebView _preferencesChanged:]):
3096
3097 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3098
3099         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3100         https://bugs.webkit.org/show_bug.cgi?id=189054
3101
3102         Reviewed by Andy Estes.
3103
3104         Remove the pasteboard type argument from readURLFromPasteboard.
3105
3106         * WebCoreSupport/WebPlatformStrategies.h:
3107         * WebCoreSupport/WebPlatformStrategies.mm:
3108         (WebPlatformStrategies::readURLFromPasteboard):
3109
3110 2018-08-27  Keith Rollin  <krollin@apple.com>
3111
3112         Unreviewed build fix -- disable LTO for production builds
3113
3114         * Configurations/Base.xcconfig:
3115
3116 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3117
3118         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3119         https://bugs.webkit.org/show_bug.cgi?id=188931
3120
3121         Reviewed by Wenson Hsieh.
3122
3123         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3124
3125 2018-08-27  Keith Rollin  <krollin@apple.com>
3126
3127         Build system support for LTO
3128         https://bugs.webkit.org/show_bug.cgi?id=187785
3129         <rdar://problem/42353132>
3130
3131         Reviewed by Dan Bernstein.
3132
3133         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3134         LTO.
3135
3136         * Configurations/Base.xcconfig:
3137         * Configurations/DebugRelease.xcconfig:
3138
3139 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3140
3141         Pass in IsComposed flag to Event constructors
3142         https://bugs.webkit.org/show_bug.cgi?id=188720
3143         <rdar://problem/43580387>
3144
3145         Reviewed by Simon Fraser.
3146
3147         * WebView/WebPDFView.mm:
3148         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3149         whether it's simulated or not.
3150
3151 2018-08-23  Mark Lam  <mark.lam@apple.com>
3152
3153         Move vmEntryGlobalObject() to VM from CallFrame.
3154         https://bugs.webkit.org/show_bug.cgi?id=188900
3155         <rdar://problem/43655753>
3156
3157         Reviewed by Michael Saboff.
3158
3159         * WebView/WebScriptDebugger.mm:
3160         (WebScriptDebugger::sourceParsed):
3161
3162 2018-08-23  Andy Estes  <aestes@apple.com>
3163
3164         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3165         https://bugs.webkit.org/show_bug.cgi?id=188829
3166
3167         Reviewed by Tim Horton.
3168
3169         * Configurations/FeatureDefines.xcconfig:
3170
3171 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3172
3173         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3174         https://bugs.webkit.org/show_bug.cgi?id=188777
3175
3176         Reviewed by Simon Fraser.
3177
3178         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3179         being "true" before the code change.
3180
3181         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3182
3183         * WebView/WebPDFView.mm:
3184         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3185
3186 2018-08-21  Daniel Bates  <dabates@apple.com>
3187
3188         Replace TextCheckingTypeMask with OptionSet
3189         https://bugs.webkit.org/show_bug.cgi?id=188678
3190
3191         Reviewed by Antti Koivisto.
3192
3193         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3194         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3195         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3196         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3197
3198         * WebCoreSupport/WebEditorClient.h:
3199         * WebCoreSupport/WebEditorClient.mm:
3200         (WebEditorClient::checkTextOfParagraph):
3201         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3202         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3203         left as this is more readable and unncessary now that modern compilers like Clang have
3204         diagnostics to catch accidental assignments when equality was intended.
3205         (WebEditorClient::didCheckSucceed):
3206         * WebView/WebView.mm:
3207         (coreTextCheckingType):
3208         (textCheckingResultFromNSTextCheckingResult):
3209
3210 2018-08-21  Daniel Bates  <dabates@apple.com>
3211
3212         [iOS][WK1] Support toggling continuous spell checking from tests
3213         https://bugs.webkit.org/show_bug.cgi?id=188763
3214
3215         Reviewed by Simon Fraser.
3216
3217         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3218         spell checking from tests in iOS WebKit Legacy.
3219
3220         * WebCoreSupport/WebEditorClient.h:
3221         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3222         * WebCoreSupport/WebEditorClient.mm:
3223         * WebView/WebView.h:
3224         * WebView/WebView.mm:
3225         (-[WebView toggleContinuousSpellChecking:]):
3226         (-[WebView toggleSmartInsertDelete:]):
3227
3228 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3229
3230         Add some plumbing for safe browsing
3231         https://bugs.webkit.org/show_bug.cgi?id=188709
3232
3233         Reviewed by Tim Horton.
3234
3235         * WebCoreSupport/WebFrameLoaderClient.h:
3236         * WebCoreSupport/WebFrameLoaderClient.mm:
3237         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3238
3239 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3240
3241         Replace canBubble and cancelable booleans in Event by enum classes
3242         https://bugs.webkit.org/show_bug.cgi?id=188692
3243
3244         Reviewed by Alex Christensen.
3245
3246         * WebView/WebPDFView.mm:
3247         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3248         * WebView/WebView.mm:
3249         (-[WebView _dispatchUnloadEvent]):
3250
3251 2018-08-16  Jer Noble  <jer.noble@apple.com>
3252
3253         Add Experimental Feature support for SourceBuffer.changeType()
3254         https://bugs.webkit.org/show_bug.cgi?id=188626
3255         <rdar://problem/43356021>
3256
3257         Reviewed by Eric Carlson.
3258
3259         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3260
3261         * WebView/WebPreferenceKeysPrivate.h:
3262         * WebView/WebPreferences.mm:
3263         (+[WebPreferences initialize]):
3264         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3265         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3266         * WebView/WebPreferencesPrivate.h:
3267         * WebView/WebView.mm:
3268         (-[WebView _preferencesChanged:]):
3269
3270 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3271
3272         Support drag-and-drop for input[type=color]
3273         https://bugs.webkit.org/show_bug.cgi?id=188464
3274
3275         Reviewed by Wenson Hsieh.
3276
3277         * WebCoreSupport/WebPlatformStrategies.h:
3278         * WebCoreSupport/WebPlatformStrategies.mm:
3279         (WebPlatformStrategies::setColor):
3280
3281 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3282
3283         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3284         https://bugs.webkit.org/show_bug.cgi?id=188569
3285         <rdar://problem/34201095>
3286
3287         Reviewed by Megan Gardner.
3288
3289         * WebView/WebImmediateActionController.mm:
3290         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3291         Speculative fix; the crashes indicate font is null, but we just checked it,
3292         so it must be getting made null by convertFont:toSize:. Check again!
3293
3294 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3295
3296         Use a 1-byte enum class for TextDirection
3297         https://bugs.webkit.org/show_bug.cgi?id=188350
3298
3299         Reviewed by Simon Fraser.
3300
3301         * WebCoreSupport/PopupMenuMac.mm:
3302         (PopupMenuMac::populate):
3303         (PopupMenuMac::show):
3304         * WebCoreSupport/WebFrameLoaderClient.mm:
3305         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3306         * WebView/WebFrame.mm:
3307         (-[WebFrame _dispatchDidReceiveTitle:]):
3308
3309 2018-08-09  Ali Juma  <ajuma@chromium.org>
3310
3311         Import WPTs for IntersectionObserver
3312         https://bugs.webkit.org/show_bug.cgi?id=188416
3313
3314         Reviewed by Simon Fraser.
3315
3316         * WebView/WebPreferencesPrivate.h:
3317
3318 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3319
3320         Follow-up build fix for r234685
3321         https://bugs.webkit.org/show_bug.cgi?id=188245
3322
3323         Unreviewed build fix.
3324
3325         * WebCoreSupport/WebSecurityOriginPrivate.h:
3326
3327 2018-08-05  Darin Adler  <darin@apple.com>
3328
3329         [Cocoa] More tweaks and refactoring to prepare for ARC
3330         https://bugs.webkit.org/show_bug.cgi?id=188245
3331
3332         Reviewed by Dan Bernstein.
3333
3334         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3335
3336         * Carbon/CarbonWindowFrame.m:
3337         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3338
3339         * DOM/DOM.mm:
3340         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3341         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3342         garbage collection so this method isn't useful.
3343
3344         * DOM/DOMXPath.mm:
3345         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3346         Objective-C garbage collection so this method isn't useful.
3347
3348         * History/WebHistory.mm:
3349         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3350
3351         * Misc/WebElementDictionary.mm:
3352         (addLookupKey): Use a bridging cast.
3353         (cacheValueForKey): Ditto.
3354         (-[WebElementDictionary _fillCache]): Ditto.
3355         (-[WebElementDictionary objectForKey:]): Ditto.
3356
3357         * Misc/WebKitNSStringExtras.mm:
3358         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3359         (-[NSString _web_widthWithFont:]): Ditto.
3360         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3361
3362         * Misc/WebLocalizableStrings.mm:
3363         (WebLocalizedString): Use a bridging cast.
3364
3365         * Misc/WebNSDataExtras.mm:
3366         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3367         and use CFBridgingRelease instead of calling autorelease directly.
3368         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3369         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3370         on the amount of explicit release and autorelease.
3371
3372         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3373         * Misc/WebNSDictionaryExtras.m:
3374         (-[NSDictionary _webkit_intForKey:]): Deleted.
3375         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3376         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3377         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3378         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3379         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3380         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3381
3382         * Misc/WebStringTruncator.mm:
3383         (fontFromNSFont): Use a bridging cast.
3384
3385         * Plugins/Hosted/NetscapePluginHostManager.mm:
3386         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3387
3388         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3389         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3390         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3391         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3392         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3393         * Plugins/Hosted/ProxyInstance.mm:
3394         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3395         * Plugins/WebBasePluginPackage.mm:
3396         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3397         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3398         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3399         * Plugins/WebNetscapePluginPackage.mm:
3400         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3401
3402         * Plugins/WebNetscapePluginView.mm:
3403         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3404         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3405         (-[WebNetscapePluginView status:]): Use a bridging cast.
3406         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3407
3408         * Plugins/WebPluginController.mm:
3409         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3410
3411         * Plugins/WebPluginDatabase.mm:
3412         (checkCandidate): Use explicit __strong for out argument types.
3413
3414         * Plugins/npapi.mm:
3415         (pluginViewForInstance): Use a bridging cast.
3416
3417         * Storage/WebDatabaseManager.mm:
3418         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3419         explicit NSNumber and NSDictionary calls.
3420
3421         * WebCoreSupport/WebContextMenuClient.mm:
3422         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3423
3424         * WebCoreSupport/WebEditorClient.mm:
3425         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3426         (WebEditorClient::handleInputMethodKeydown): Ditto.
3427
3428         * WebCoreSupport/WebFrameNetworkingContext.mm:
3429         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3430
3431         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3432         as a struct rather than an Objective-C class, since that's how it's defined.
3433
3434         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3435
3436         * WebView/WebFullScreenController.mm:
3437         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3438         * WebView/WebHTMLView.mm:
3439         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3440         Ditto.
3441         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3442
3443         * WebView/WebImmediateActionController.mm:
3444         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3445         go down to the document and then back to the frame.
3446         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3447         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3448         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3449
3450         * WebView/WebJSPDFDoc.mm:
3451         (jsPDFDocInitialize): Removed some unneeded type casting.
3452         (jsPDFDocFinalize): Ditto.
3453         (jsPDFDocPrint): Use a bridging cast.
3454
3455         * WebView/WebPDFView.mm:
3456         (_applicationInfoForMIMEType): Use bridging casts.
3457
3458         * WebView/WebPreferences.mm:
3459         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3460         instead of methods from WebNSDictionaryExtras.
3461         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3462         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3463         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3464         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3465         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3466
3467         * WebView/WebView.mm:
3468         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3469         (-[WebView _addToAllWebViewsSet]): Ditto.
3470         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.